{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/49755514","id":49755514,"diff_hunk":"@@ -447,308 +423,145 @@ func (k *Executor) attemptSuicide(driver bindings.ExecutorDriver, abort <-chan s\n \t}\n }\n \n-// async continuation of LaunchTask\n-func (k *Executor) launchTask(driver bindings.ExecutorDriver, taskId string, pod *api.Pod) {\n-\tdeleteTask := func() {\n-\t\tk.lock.Lock()\n-\t\tdefer k.lock.Unlock()\n-\t\tdelete(k.tasks, taskId)\n-\t\tk.resetSuicideWatch(driver)\n-\t}\n-\n-\t// TODO(k8s): use Pods interface for binding once clusters are upgraded\n-\t// return b.Pods(binding.Namespace).Bind(binding)\n-\tif pod.Spec.NodeName == \"\" {\n-\t\t//HACK(jdef): cloned binding construction from k8s plugin/pkg/scheduler/framework.go\n-\t\tbinding := &api.Binding{\n-\t\t\tObjectMeta: api.ObjectMeta{\n-\t\t\t\tNamespace:   pod.Namespace,\n-\t\t\t\tName:        pod.Name,\n-\t\t\t\tAnnotations: make(map[string]string),\n-\t\t\t},\n-\t\t\tTarget: api.ObjectReference{\n-\t\t\t\tKind: \"Node\",\n-\t\t\t\tName: pod.Annotations[meta.BindingHostKey],\n-\t\t\t},\n-\t\t}\n-\n-\t\t// forward the annotations that the scheduler wants to apply\n-\t\tfor k, v := range pod.Annotations {\n-\t\t\tbinding.Annotations[k] = v\n-\t\t}\n-\n-\t\t// create binding on apiserver\n-\t\tlog.Infof(\"Binding '%v/%v' to '%v' with annotations %+v...\", pod.Namespace, pod.Name, binding.Target.Name, binding.Annotations)\n-\t\tctx := api.WithNamespace(api.NewContext(), binding.Namespace)\n-\t\terr := k.client.Post().Namespace(api.NamespaceValue(ctx)).Resource(\"bindings\").Body(binding).Do().Error()\n-\t\tif err != nil {\n-\t\t\tdeleteTask()\n-\t\t\tk.sendStatus(driver, newStatus(mutil.NewTaskID(taskId), mesos.TaskState_TASK_FAILED,\n-\t\t\t\tmessages.CreateBindingFailure))\n-\t\t\treturn\n-\t\t}\n-\t} else {\n-\t\t// post annotations update to apiserver\n-\t\tpatch := struct {\n-\t\t\tMetadata struct {\n-\t\t\t\tAnnotations map[string]string `json:\"annotations\"`\n-\t\t\t} `json:\"metadata\"`\n-\t\t}{}\n-\t\tpatch.Metadata.Annotations = pod.Annotations\n-\t\tpatchJson, _ := json.Marshal(patch)\n-\t\tlog.V(4).Infof(\"Patching annotations %v of pod %v/%v: %v\", pod.Annotations, pod.Namespace, pod.Name, string(patchJson))\n-\t\terr := k.client.Patch(api.MergePatchType).RequestURI(pod.SelfLink).Body(patchJson).Do().Error()\n-\t\tif err != nil {\n-\t\t\tlog.Errorf(\"Error updating annotations of ready-to-launch pod %v/%v: %v\", pod.Namespace, pod.Name, err)\n-\t\t\tdeleteTask()\n-\t\t\tk.sendStatus(driver, newStatus(mutil.NewTaskID(taskId), mesos.TaskState_TASK_FAILED,\n-\t\t\t\tmessages.AnnotationUpdateFailure))\n-\t\t\treturn\n-\t\t}\n-\t}\n-\n+func podStatusData(pod *api.Pod, status api.PodStatus) ([]byte, string, error) {\n \tpodFullName := container.GetPodFullName(pod)\n-\n-\t// allow a recently failed-over scheduler the chance to recover the task/pod binding:\n-\t// it may have failed and recovered before the apiserver is able to report the updated\n-\t// binding information. replays of this status event will signal to the scheduler that\n-\t// the apiserver should be up-to-date.\n \tdata, err := json.Marshal(api.PodStatusResult{\n \t\tObjectMeta: api.ObjectMeta{\n \t\t\tName:     podFullName,\n \t\t\tSelfLink: \"/podstatusresult\",\n \t\t},\n+\t\tStatus: status,\n \t})\n-\tif err != nil {\n-\t\tdeleteTask()\n-\t\tlog.Errorf(\"failed to marshal pod status result: %v\", err)\n-\t\tk.sendStatus(driver, newStatus(mutil.NewTaskID(taskId), mesos.TaskState_TASK_FAILED,\n-\t\t\terr.Error()))\n-\t\treturn\n-\t}\n+\treturn data, podFullName, err\n+}\n \n-\tk.lock.Lock()\n-\tdefer k.lock.Unlock()\n+// async continuation of LaunchTask\n+func (k *Executor) launchTask(driver bindings.ExecutorDriver, task *mesos.TaskInfo, launchTimer *time.Timer, pod *api.Pod) {\n+\tsuccess := false\n+\tdefer func() {\n+\t\tif !success {\n+\t\t\tk.killPodTask(driver, task.TaskId.GetValue())\n+\t\t\tk.resetSuicideWatch(driver)\n+\t\t}\n+\t}()\n \n-\t// find task\n-\ttask, found := k.tasks[taskId]\n-\tif !found {\n-\t\tlog.V(1).Infof(\"task %v not found, probably killed: aborting launch, reporting lost\", taskId)\n-\t\tk.reportLostTask(driver, taskId, messages.LaunchTaskFailed)\n+\t// generate this first, in case there's problems we don't need to worry about a pod that's already bound\n+\t// --\n+\t// allow a recently failed-over scheduler the chance to recover the task/pod binding:\n+\t// it may have failed and recovered before the apiserver is able to report the updated\n+\t// binding information. replays of this status event will signal to the scheduler that\n+\t// the apiserver should be up-to-date.\n+\tstartingData, _, err := podStatusData(pod, api.PodStatus{})\n+\tif err != nil {\n+\t\tlog.Errorf(\"failed to generate pod-task starting data: %v\", err)\n+\t\tk.sendStatus(driver, newStatus(task.TaskId, mesos.TaskState_TASK_FAILED, err.Error()))\n \t\treturn\n \t}\n \n-\t//TODO(jdef) check for duplicate pod name, if found send TASK_ERROR\n-\n-\t// send the new pod to the kubelet which will spin it up\n-\ttask.podName = podFullName\n-\tk.pods[podFullName] = pod\n-\tok := k.sendPodsSnapshot()\n-\tif !ok {\n-\t\ttask.podName = \"\"\n-\t\tdelete(k.pods, podFullName)\n-\t\treturn // executor is terminating, cancel launch\n+\terr = k.registry.bind(task.TaskId.GetValue(), pod)\n+\tif err != nil {\n+\t\tlog.Errorf(\"failed to bind pod %v/%v: %v\", pod.Namespace, pod.Name, err)\n+\t\tk.sendStatus(driver, newStatus(task.TaskId, mesos.TaskState_TASK_FAILED, err.Error()))\n+\t\treturn\n \t}\n \n-\t// From here on, we need to delete containers associated with the task upon\n-\t// it going into a terminal state.\n-\n-\t// report task is starting to scheduler\n-\tstatusUpdate := &mesos.TaskStatus{\n-\t\tTaskId:  mutil.NewTaskID(taskId),\n+\t// send TASK_STARTING\n+\tk.sendStatus(driver, &mesos.TaskStatus{\n+\t\tTaskId:  task.TaskId,\n \t\tState:   mesos.TaskState_TASK_STARTING.Enum(),\n \t\tMessage: proto.String(messages.CreateBindingSuccess),\n-\t\tData:    data,\n-\t}\n-\tk.sendStatus(driver, statusUpdate)\n-\n-\t// Delay reporting 'task running' until container is up.\n-\tpsf := podStatusFunc(func() (*api.PodStatus, error) {\n-\t\treturn k.podStatusFunc(pod)\n+\t\tData:    startingData,\n \t})\n-\tgo k._launchTask(driver, taskId, podFullName, psf, task.launchTimer.C)\n-}\n \n-func (k *Executor) _launchTask(driver bindings.ExecutorDriver, taskId, podFullName string, psf podStatusFunc, expired <-chan time.Time) {\n-\tgetMarshalledInfo := func() (data []byte, cancel bool) {\n-\t\t// potentially long call..\n-\t\tif podStatus, err := psf(); err == nil && podStatus != nil {\n-\t\t\tselect {\n-\t\t\tcase <-expired:\n-\t\t\t\tcancel = true\n-\t\t\tdefault:\n-\t\t\t\tk.lock.Lock()\n-\t\t\t\tdefer k.lock.Unlock()\n-\t\t\t\tif _, found := k.tasks[taskId]; !found {\n-\t\t\t\t\t// don't bother with the pod status if the task is already gone\n-\t\t\t\t\tcancel = true\n-\t\t\t\t\tbreak\n-\t\t\t\t} else if podStatus.Phase != api.PodRunning {\n-\t\t\t\t\t// avoid sending back a running status before it's really running\n-\t\t\t\t\tbreak\n-\t\t\t\t}\n-\t\t\t\tlog.V(2).Infof(\"Found pod status: '%v'\", podStatus)\n-\t\t\t\tresult := api.PodStatusResult{\n-\t\t\t\t\tObjectMeta: api.ObjectMeta{\n-\t\t\t\t\t\tName:     podFullName,\n-\t\t\t\t\t\tSelfLink: \"/podstatusresult\",\n-\t\t\t\t\t},\n-\t\t\t\t\tStatus: *podStatus,\n-\t\t\t\t}\n-\t\t\t\tif data, err = json.Marshal(result); err != nil {\n-\t\t\t\t\tlog.Errorf(\"failed to marshal pod status result: %v\", err)\n+\t// within the launch timeout window we should see a pod-task update via k.registry.\n+\t// if we see a Running update then we need to generate a TASK_RUNNING status update for mesos.\n+\thandlerFinished := make(chan struct{})\n+\texpired := make(chan struct{})\n+\tgo func() {\n+\t\tdefer close(expired)\n+\t\t<-launchTimer.C\n+\t}()\n+\thandler := podWatchHandler{\n+\t\taction: func(pod *RegisteredPod) (bool, error) {\n+\t\t\tif pod == nil {\n+\t\t\t\t// expired!!\n+\t\t\t\tselect {\n+\t\t\t\tcase <-handlerFinished:\n+\t\t\t\t\t// noop, someone else (maybe us) has already informed mesos\n+\t\t\t\t\t// about the status of the task\n+\t\t\t\tdefault:\n+\t\t\t\t\t// launch timeout expired\n+\t\t\t\t\tk.killPodTask(driver, task.TaskId.GetValue())\n \t\t\t\t}\n+\t\t\t\treturn true, nil\n \t\t\t}\n-\t\t}\n-\t\treturn\n-\t}\n \n-waitForRunningPod:\n-\tfor {\n-\t\tselect {\n-\t\tcase <-expired:\n-\t\t\tlog.Warningf(\"Launch expired grace period of '%v'\", k.launchGracePeriod)\n-\t\t\tbreak waitForRunningPod\n-\t\tcase <-time.After(containerPollTime):\n-\t\t\tif data, cancel := getMarshalledInfo(); cancel {\n-\t\t\t\tbreak waitForRunningPod\n-\t\t\t} else if data == nil {\n-\t\t\t\tcontinue waitForRunningPod\n-\t\t\t} else {\n-\t\t\t\tk.lock.Lock()\n-\t\t\t\tdefer k.lock.Unlock()\n-\t\t\t\ttask, found := k.tasks[taskId]\n-\t\t\t\tif !found {\n-\t\t\t\t\tgoto reportLost\n-\t\t\t\t}\n-\n-\t\t\t\tstatusUpdate := &mesos.TaskStatus{\n-\t\t\t\t\tTaskId:  mutil.NewTaskID(taskId),\n-\t\t\t\t\tState:   mesos.TaskState_TASK_RUNNING.Enum(),\n-\t\t\t\t\tMessage: proto.String(fmt.Sprintf(\"pod-running:%s\", podFullName)),\n-\t\t\t\t\tData:    data,\n-\t\t\t\t}\n+\t\t\tif pod.event == RegistrationEventDeleted {\n+\t\t\t\tdefer launchTimer.Stop()\n+\t\t\t\tdefer close(handlerFinished)\n \n-\t\t\t\tk.sendStatus(driver, statusUpdate)\n-\t\t\t\ttask.launchTimer.Stop()\n+\t\t\t\t// we're done monitoring because pod has been deleted\n+\t\t\t\treturn true, nil\n+\t\t\t}\n \n-\t\t\t\t// continue to monitor the health of the pod\n-\t\t\t\tgo k.__launchTask(driver, taskId, podFullName, psf)\n-\t\t\t\treturn\n+\t\t\tif !podTaskRunning(pod) {","path":"contrib/mesos/pkg/executor/executor.go","position":488,"original_position":488,"commit_id":"b47fb3a61593a9eb49b6206d342b7eedfe121a12","original_commit_id":"b47fb3a61593a9eb49b6206d342b7eedfe121a12","user":{"login":"jdef","id":2348332,"avatar_url":"https://avatars.githubusercontent.com/u/2348332?v=3","gravatar_id":"","url":"https://api.github.com/users/jdef","html_url":"https://github.com/jdef","followers_url":"https://api.github.com/users/jdef/followers","following_url":"https://api.github.com/users/jdef/following{/other_user}","gists_url":"https://api.github.com/users/jdef/gists{/gist_id}","starred_url":"https://api.github.com/users/jdef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdef/subscriptions","organizations_url":"https://api.github.com/users/jdef/orgs","repos_url":"https://api.github.com/users/jdef/repos","events_url":"https://api.github.com/users/jdef/events{/privacy}","received_events_url":"https://api.github.com/users/jdef/received_events","type":"User","site_admin":false},"body":"ack","created_at":"2016-01-14T17:21:54Z","updated_at":"2016-01-14T17:21:54Z","html_url":"https://github.com/kubernetes/kubernetes/pull/19632#discussion_r49755514","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19632","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/49755514"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/19632#discussion_r49755514"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19632"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19632","id":55984024,"html_url":"https://github.com/kubernetes/kubernetes/pull/19632","diff_url":"https://github.com/kubernetes/kubernetes/pull/19632.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/19632.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/19632","number":19632,"state":"open","locked":false,"title":"WIP/MESOS: unified pod watcher implementation","user":{"login":"jdef","id":2348332,"avatar_url":"https://avatars.githubusercontent.com/u/2348332?v=3","gravatar_id":"","url":"https://api.github.com/users/jdef","html_url":"https://github.com/jdef","followers_url":"https://api.github.com/users/jdef/followers","following_url":"https://api.github.com/users/jdef/following{/other_user}","gists_url":"https://api.github.com/users/jdef/gists{/gist_id}","starred_url":"https://api.github.com/users/jdef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdef/subscriptions","organizations_url":"https://api.github.com/users/jdef/orgs","repos_url":"https://api.github.com/users/jdef/repos","events_url":"https://api.github.com/users/jdef/events{/privacy}","received_events_url":"https://api.github.com/users/jdef/received_events","type":"User","site_admin":false},"body":"xref https://github.com/mesosphere/kubernetes-mesos/issues/730\r\n\r\n* replace pod-observer and check-for-lost-pod polling with a single pod watcher and task registry\r\n\r\nTODO:\r\n- [ ] get unit tests passing\r\n- [ ] write some additional unit tests for new code\r\n- [x] pod deletion is detected in a filter, which sucks; upon deletion there's never a call to a pending action handler (one that might be waiting for the pod to start up)","created_at":"2016-01-14T02:06:07Z","updated_at":"2016-01-14T17:21:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b28f3b864de926783556a21f658f59ddc7a69d3","assignee":{"login":"jdef","id":2348332,"avatar_url":"https://avatars.githubusercontent.com/u/2348332?v=3","gravatar_id":"","url":"https://api.github.com/users/jdef","html_url":"https://github.com/jdef","followers_url":"https://api.github.com/users/jdef/followers","following_url":"https://api.github.com/users/jdef/following{/other_user}","gists_url":"https://api.github.com/users/jdef/gists{/gist_id}","starred_url":"https://api.github.com/users/jdef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdef/subscriptions","organizations_url":"https://api.github.com/users/jdef/orgs","repos_url":"https://api.github.com/users/jdef/repos","events_url":"https://api.github.com/users/jdef/events{/privacy}","received_events_url":"https://api.github.com/users/jdef/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19632/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19632/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/19632/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/b47fb3a61593a9eb49b6206d342b7eedfe121a12","head":{"label":"mesosphere:jdef_unified_pod_watch","ref":"jdef_unified_pod_watch","sha":"b47fb3a61593a9eb49b6206d342b7eedfe121a12","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":22277046,"name":"kubernetes","full_name":"mesosphere/kubernetes","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/mesosphere/kubernetes","forks_url":"https://api.github.com/repos/mesosphere/kubernetes/forks","keys_url":"https://api.github.com/repos/mesosphere/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/kubernetes/teams","hooks_url":"https://api.github.com/repos/mesosphere/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/kubernetes/events","assignees_url":"https://api.github.com/repos/mesosphere/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/kubernetes/tags","blobs_url":"https://api.github.com/repos/mesosphere/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/kubernetes/languages","stargazers_url":"https://api.github.com/repos/mesosphere/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/kubernetes/subscription","commits_url":"https://api.github.com/repos/mesosphere/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/kubernetes/merges","archive_url":"https://api.github.com/repos/mesosphere/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/kubernetes/downloads","issues_url":"https://api.github.com/repos/mesosphere/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/kubernetes/releases{/id}","created_at":"2014-07-26T02:50:13Z","updated_at":"2016-01-09T00:17:34Z","pushed_at":"2016-01-14T17:05:37Z","git_url":"git://github.com/mesosphere/kubernetes.git","ssh_url":"git@github.com:mesosphere/kubernetes.git","clone_url":"https://github.com/mesosphere/kubernetes.git","svn_url":"https://github.com/mesosphere/kubernetes","homepage":null,"size":150220,"stargazers_count":22,"watchers_count":22,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":22,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"5007d7c4a9758ca778db2dcd3f2c283fef2357be","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-01-14T17:07:30Z","pushed_at":"2016-01-14T17:15:52Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":304527,"stargazers_count":12134,"watchers_count":12134,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3409,"mirror_url":null,"open_issues_count":2784,"forks":3409,"open_issues":2784,"watchers":12134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19632"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/19632"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/19632"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/19632/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19632/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19632/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/b47fb3a61593a9eb49b6206d342b7eedfe121a12"}}}}