{"action":"created","issue":{"url":"https://api.github.com/repos/timabell/msaccess-vcs-integration/issues/47","repository_url":"https://api.github.com/repos/timabell/msaccess-vcs-integration","labels_url":"https://api.github.com/repos/timabell/msaccess-vcs-integration/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/timabell/msaccess-vcs-integration/issues/47/comments","events_url":"https://api.github.com/repos/timabell/msaccess-vcs-integration/issues/47/events","html_url":"https://github.com/timabell/msaccess-vcs-integration/pull/47","id":159951036,"number":47,"title":"Changed the handling of Table Defs and renamed functions to prevent conflicts.","user":{"login":"seanchase","id":3017397,"avatar_url":"https://avatars.githubusercontent.com/u/3017397?v=3","gravatar_id":"","url":"https://api.github.com/users/seanchase","html_url":"https://github.com/seanchase","followers_url":"https://api.github.com/users/seanchase/followers","following_url":"https://api.github.com/users/seanchase/following{/other_user}","gists_url":"https://api.github.com/users/seanchase/gists{/gist_id}","starred_url":"https://api.github.com/users/seanchase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanchase/subscriptions","organizations_url":"https://api.github.com/users/seanchase/orgs","repos_url":"https://api.github.com/users/seanchase/repos","events_url":"https://api.github.com/users/seanchase/events{/privacy}","received_events_url":"https://api.github.com/users/seanchase/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-06-13T13:32:57Z","updated_at":"2016-06-15T23:36:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/timabell/msaccess-vcs-integration/pulls/47","html_url":"https://github.com/timabell/msaccess-vcs-integration/pull/47","diff_url":"https://github.com/timabell/msaccess-vcs-integration/pull/47.diff","patch_url":"https://github.com/timabell/msaccess-vcs-integration/pull/47.patch"},"body":"The major changes are centered around (Im/Ex)portTableDef, removing unused code, and renaming all public functions outside \"VCS_ImportExport\" by appending \"VCS_\" to them.\n\nTableDefs are now stored in XML Table Schema instead of SQL text files. This is HUGE because you no longer need to add ADO references and can import directly into existing AccessDBs.\n\nWith new TableDefs functions there were a couple functions no longer needed. I scrubbed the code and found several more and removed them as well.\n\nAs far as renaming the other functions goes, I was getting several naming conflicts with existing code. \"FileExists\" function being the obvious example. Adding VCS_ to everything looks ugly but makes the project more robust. It shrinks the conflict target down to 4 functions. Main() is still very vulnerable to this.\n\nIn my opinion the project is all 'Guest' code serving an existing project. Eventually, I'd like to see everything go back to one module so as not to crowd out the already busy modules list. It should be able to be dropped into any Access Database and compile without conflict. The real work people should be doing is getting their project on GitHub or other VCS and start collaborating. Not getting the damn thing to work."},"comment":{"url":"https://api.github.com/repos/timabell/msaccess-vcs-integration/issues/comments/226350500","html_url":"https://github.com/timabell/msaccess-vcs-integration/pull/47#issuecomment-226350500","issue_url":"https://api.github.com/repos/timabell/msaccess-vcs-integration/issues/47","id":226350500,"user":{"login":"seanchase","id":3017397,"avatar_url":"https://avatars.githubusercontent.com/u/3017397?v=3","gravatar_id":"","url":"https://api.github.com/users/seanchase","html_url":"https://github.com/seanchase","followers_url":"https://api.github.com/users/seanchase/followers","following_url":"https://api.github.com/users/seanchase/following{/other_user}","gists_url":"https://api.github.com/users/seanchase/gists{/gist_id}","starred_url":"https://api.github.com/users/seanchase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanchase/subscriptions","organizations_url":"https://api.github.com/users/seanchase/orgs","repos_url":"https://api.github.com/users/seanchase/repos","events_url":"https://api.github.com/users/seanchase/events{/privacy}","received_events_url":"https://api.github.com/users/seanchase/received_events","type":"User","site_admin":false},"created_at":"2016-06-15T23:36:07Z","updated_at":"2016-06-15T23:36:07Z","body":"While it is possible to leave the old code and have SQL and schema output , the biggest issue is that brings back the terrible ADO library dependencies. My original idea to be less disruptive was to output the xml, parse out the DECIMAL values needed, and use that instead of the function with the dependencies. The moment I started to code I figured why bother? It shows up as 4 lines for clarity, but in reality its 1 line of code that replaces at least 100+ and is much more stable. And the import is saves another 70+. \r\nHow much code it replaced is not important. The significance is it's stable and uses built in, documented, functionality. I see the value in having it in SQL as well. It would give me a reason to learn how to parse XML 😁. \r\n\r\nTLDR: new way is better, it will take some work to add it back. "}}
{"actor":{"display_login":"seanchase"}}