{"action":"closed","number":473,"pull_request":{"url":"https://api.github.com/repos/RackHD/RackHD/pulls/473","id":91585370,"html_url":"https://github.com/RackHD/RackHD/pull/473","diff_url":"https://github.com/RackHD/RackHD/pull/473.diff","patch_url":"https://github.com/RackHD/RackHD/pull/473.patch","issue_url":"https://api.github.com/repos/RackHD/RackHD/issues/473","number":473,"state":"closed","locked":false,"title":"RackHD OVA","user":{"login":"panpan0000","id":14049268,"avatar_url":"https://avatars.githubusercontent.com/u/14049268?v=3","gravatar_id":"","url":"https://api.github.com/users/panpan0000","html_url":"https://github.com/panpan0000","followers_url":"https://api.github.com/users/panpan0000/followers","following_url":"https://api.github.com/users/panpan0000/following{/other_user}","gists_url":"https://api.github.com/users/panpan0000/gists{/gist_id}","starred_url":"https://api.github.com/users/panpan0000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panpan0000/subscriptions","organizations_url":"https://api.github.com/users/panpan0000/orgs","repos_url":"https://api.github.com/users/panpan0000/repos","events_url":"https://api.github.com/users/panpan0000/events{/privacy}","received_events_url":"https://api.github.com/users/panpan0000/received_events","type":"User","site_admin":false},"body":"This PR depends on @changev https://github.com/RackHD/RackHD/pull/459\r\n\r\nsummary of PR:\r\n1. apt-get install on-xxx package requires service starting . so we need eth1(172.31.128.1) configuabled at that time.\r\n2. align OnRack for 4 NICs (ADMIN/CONTROL/BMC/PDU)\r\n3. both 14.04 and 16.04 are supported.\r\n4. config eth1 IP to align the typical config.json\r\n5. add HWIMO-BUILD, to build an OVA and sign.\r\n6. a fix to show how to address : https://github.com/RackHD/RackHD/issues/472   (this commit will conflict @changev's PR)\r\n\r\n\r\n@changev @PengTian0 @RackHD/corecommitters  \r\n\r\nsome explanation of the code tech details:\r\n\r\n1. <wait> is not a must in boot_command\r\n2. put 2 NIC in vmx_data( when packer provison VM) , so that package can be installed with eht1 exists\r\n3. note that ethernet.connectiontype: nat. without it , it will use 'bridged' mode (you can find from vmx file). but packer only support seek dhcp.lease from vmnet8 (which is for NAT)\r\n4. note that ethernet0.networkName can't be set in vmx_data. that's because it will make the \"connectiontype: nat\" useless. I filed https://github.com/mitchellh/packer/issues/4091 to packer\r\n5. note that pcislotnumber is a must in vmx_data. without it, VMWare will make eth0 as 33 and eth1 as 32. when OS boot , it will treat PCI dev 32 as eth0. then SSH timeout\r\n6. the HWIMO-BUILD is derived from OnRack side.\r\n7. didn't use \"format:ova\" in json , instead, export as default vmx , because we need to do virus scan against vmdk file. so will turn to ova afterward..\r\n","created_at":"2016-10-31T10:23:53Z","updated_at":"2016-11-16T04:59:12Z","closed_at":"2016-11-16T04:59:12Z","merged_at":"2016-11-16T04:59:12Z","merge_commit_sha":"65ef4f516e04fdded67e442c3f12ee61baa24bb6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/RackHD/RackHD/pulls/473/commits","review_comments_url":"https://api.github.com/repos/RackHD/RackHD/pulls/473/comments","review_comment_url":"https://api.github.com/repos/RackHD/RackHD/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RackHD/RackHD/issues/473/comments","statuses_url":"https://api.github.com/repos/RackHD/RackHD/statuses/a3c8277d7b12af179b916c7411abec7d27459d46","head":{"label":"panpan0000:OVA-Build-branch","ref":"OVA-Build-branch","sha":"a3c8277d7b12af179b916c7411abec7d27459d46","user":{"login":"panpan0000","id":14049268,"avatar_url":"https://avatars.githubusercontent.com/u/14049268?v=3","gravatar_id":"","url":"https://api.github.com/users/panpan0000","html_url":"https://github.com/panpan0000","followers_url":"https://api.github.com/users/panpan0000/followers","following_url":"https://api.github.com/users/panpan0000/following{/other_user}","gists_url":"https://api.github.com/users/panpan0000/gists{/gist_id}","starred_url":"https://api.github.com/users/panpan0000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panpan0000/subscriptions","organizations_url":"https://api.github.com/users/panpan0000/orgs","repos_url":"https://api.github.com/users/panpan0000/repos","events_url":"https://api.github.com/users/panpan0000/events{/privacy}","received_events_url":"https://api.github.com/users/panpan0000/received_events","type":"User","site_admin":false},"repo":{"id":58909915,"name":"RackHD","full_name":"panpan0000/RackHD","owner":{"login":"panpan0000","id":14049268,"avatar_url":"https://avatars.githubusercontent.com/u/14049268?v=3","gravatar_id":"","url":"https://api.github.com/users/panpan0000","html_url":"https://github.com/panpan0000","followers_url":"https://api.github.com/users/panpan0000/followers","following_url":"https://api.github.com/users/panpan0000/following{/other_user}","gists_url":"https://api.github.com/users/panpan0000/gists{/gist_id}","starred_url":"https://api.github.com/users/panpan0000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panpan0000/subscriptions","organizations_url":"https://api.github.com/users/panpan0000/orgs","repos_url":"https://api.github.com/users/panpan0000/repos","events_url":"https://api.github.com/users/panpan0000/events{/privacy}","received_events_url":"https://api.github.com/users/panpan0000/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/panpan0000/RackHD","description":"RackHD™ provides hardware management and orchestration services","fork":true,"url":"https://api.github.com/repos/panpan0000/RackHD","forks_url":"https://api.github.com/repos/panpan0000/RackHD/forks","keys_url":"https://api.github.com/repos/panpan0000/RackHD/keys{/key_id}","collaborators_url":"https://api.github.com/repos/panpan0000/RackHD/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/panpan0000/RackHD/teams","hooks_url":"https://api.github.com/repos/panpan0000/RackHD/hooks","issue_events_url":"https://api.github.com/repos/panpan0000/RackHD/issues/events{/number}","events_url":"https://api.github.com/repos/panpan0000/RackHD/events","assignees_url":"https://api.github.com/repos/panpan0000/RackHD/assignees{/user}","branches_url":"https://api.github.com/repos/panpan0000/RackHD/branches{/branch}","tags_url":"https://api.github.com/repos/panpan0000/RackHD/tags","blobs_url":"https://api.github.com/repos/panpan0000/RackHD/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/panpan0000/RackHD/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/panpan0000/RackHD/git/refs{/sha}","trees_url":"https://api.github.com/repos/panpan0000/RackHD/git/trees{/sha}","statuses_url":"https://api.github.com/repos/panpan0000/RackHD/statuses/{sha}","languages_url":"https://api.github.com/repos/panpan0000/RackHD/languages","stargazers_url":"https://api.github.com/repos/panpan0000/RackHD/stargazers","contributors_url":"https://api.github.com/repos/panpan0000/RackHD/contributors","subscribers_url":"https://api.github.com/repos/panpan0000/RackHD/subscribers","subscription_url":"https://api.github.com/repos/panpan0000/RackHD/subscription","commits_url":"https://api.github.com/repos/panpan0000/RackHD/commits{/sha}","git_commits_url":"https://api.github.com/repos/panpan0000/RackHD/git/commits{/sha}","comments_url":"https://api.github.com/repos/panpan0000/RackHD/comments{/number}","issue_comment_url":"https://api.github.com/repos/panpan0000/RackHD/issues/comments{/number}","contents_url":"https://api.github.com/repos/panpan0000/RackHD/contents/{+path}","compare_url":"https://api.github.com/repos/panpan0000/RackHD/compare/{base}...{head}","merges_url":"https://api.github.com/repos/panpan0000/RackHD/merges","archive_url":"https://api.github.com/repos/panpan0000/RackHD/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/panpan0000/RackHD/downloads","issues_url":"https://api.github.com/repos/panpan0000/RackHD/issues{/number}","pulls_url":"https://api.github.com/repos/panpan0000/RackHD/pulls{/number}","milestones_url":"https://api.github.com/repos/panpan0000/RackHD/milestones{/number}","notifications_url":"https://api.github.com/repos/panpan0000/RackHD/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/panpan0000/RackHD/labels{/name}","releases_url":"https://api.github.com/repos/panpan0000/RackHD/releases{/id}","deployments_url":"https://api.github.com/repos/panpan0000/RackHD/deployments","created_at":"2016-05-16T06:45:45Z","updated_at":"2016-07-28T06:48:29Z","pushed_at":"2016-11-15T08:56:18Z","git_url":"git://github.com/panpan0000/RackHD.git","ssh_url":"git@github.com:panpan0000/RackHD.git","clone_url":"https://github.com/panpan0000/RackHD.git","svn_url":"https://github.com/panpan0000/RackHD","homepage":" http://rackhd.readthedocs.io","size":2648,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"RackHD:master","ref":"master","sha":"ec2a54d23403c60f5adee7064ecc06e100a70c3c","user":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars.githubusercontent.com/u/13982662?v=3","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"repo":{"id":45687347,"name":"RackHD","full_name":"RackHD/RackHD","owner":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars.githubusercontent.com/u/13982662?v=3","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RackHD/RackHD","description":"RackHD™ provides hardware management and orchestration services","fork":false,"url":"https://api.github.com/repos/RackHD/RackHD","forks_url":"https://api.github.com/repos/RackHD/RackHD/forks","keys_url":"https://api.github.com/repos/RackHD/RackHD/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RackHD/RackHD/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RackHD/RackHD/teams","hooks_url":"https://api.github.com/repos/RackHD/RackHD/hooks","issue_events_url":"https://api.github.com/repos/RackHD/RackHD/issues/events{/number}","events_url":"https://api.github.com/repos/RackHD/RackHD/events","assignees_url":"https://api.github.com/repos/RackHD/RackHD/assignees{/user}","branches_url":"https://api.github.com/repos/RackHD/RackHD/branches{/branch}","tags_url":"https://api.github.com/repos/RackHD/RackHD/tags","blobs_url":"https://api.github.com/repos/RackHD/RackHD/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RackHD/RackHD/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RackHD/RackHD/git/refs{/sha}","trees_url":"https://api.github.com/repos/RackHD/RackHD/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RackHD/RackHD/statuses/{sha}","languages_url":"https://api.github.com/repos/RackHD/RackHD/languages","stargazers_url":"https://api.github.com/repos/RackHD/RackHD/stargazers","contributors_url":"https://api.github.com/repos/RackHD/RackHD/contributors","subscribers_url":"https://api.github.com/repos/RackHD/RackHD/subscribers","subscription_url":"https://api.github.com/repos/RackHD/RackHD/subscription","commits_url":"https://api.github.com/repos/RackHD/RackHD/commits{/sha}","git_commits_url":"https://api.github.com/repos/RackHD/RackHD/git/commits{/sha}","comments_url":"https://api.github.com/repos/RackHD/RackHD/comments{/number}","issue_comment_url":"https://api.github.com/repos/RackHD/RackHD/issues/comments{/number}","contents_url":"https://api.github.com/repos/RackHD/RackHD/contents/{+path}","compare_url":"https://api.github.com/repos/RackHD/RackHD/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RackHD/RackHD/merges","archive_url":"https://api.github.com/repos/RackHD/RackHD/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RackHD/RackHD/downloads","issues_url":"https://api.github.com/repos/RackHD/RackHD/issues{/number}","pulls_url":"https://api.github.com/repos/RackHD/RackHD/pulls{/number}","milestones_url":"https://api.github.com/repos/RackHD/RackHD/milestones{/number}","notifications_url":"https://api.github.com/repos/RackHD/RackHD/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RackHD/RackHD/labels{/name}","releases_url":"https://api.github.com/repos/RackHD/RackHD/releases{/id}","deployments_url":"https://api.github.com/repos/RackHD/RackHD/deployments","created_at":"2015-11-06T14:42:16Z","updated_at":"2016-11-15T14:57:11Z","pushed_at":"2016-11-16T04:59:12Z","git_url":"git://github.com/RackHD/RackHD.git","ssh_url":"git@github.com:RackHD/RackHD.git","clone_url":"https://github.com/RackHD/RackHD.git","svn_url":"https://github.com/RackHD/RackHD","homepage":" http://rackhd.readthedocs.io","size":3158,"stargazers_count":185,"watchers_count":185,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":89,"mirror_url":null,"open_issues_count":92,"forks":89,"open_issues":92,"watchers":185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RackHD/RackHD/pulls/473"},"html":{"href":"https://github.com/RackHD/RackHD/pull/473"},"issue":{"href":"https://api.github.com/repos/RackHD/RackHD/issues/473"},"comments":{"href":"https://api.github.com/repos/RackHD/RackHD/issues/473/comments"},"review_comments":{"href":"https://api.github.com/repos/RackHD/RackHD/pulls/473/comments"},"review_comment":{"href":"https://api.github.com/repos/RackHD/RackHD/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RackHD/RackHD/pulls/473/commits"},"statuses":{"href":"https://api.github.com/repos/RackHD/RackHD/statuses/a3c8277d7b12af179b916c7411abec7d27459d46"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"yyscamper","id":511378,"avatar_url":"https://avatars.githubusercontent.com/u/511378?v=3","gravatar_id":"","url":"https://api.github.com/users/yyscamper","html_url":"https://github.com/yyscamper","followers_url":"https://api.github.com/users/yyscamper/followers","following_url":"https://api.github.com/users/yyscamper/following{/other_user}","gists_url":"https://api.github.com/users/yyscamper/gists{/gist_id}","starred_url":"https://api.github.com/users/yyscamper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyscamper/subscriptions","organizations_url":"https://api.github.com/users/yyscamper/orgs","repos_url":"https://api.github.com/users/yyscamper/repos","events_url":"https://api.github.com/users/yyscamper/events{/privacy}","received_events_url":"https://api.github.com/users/yyscamper/received_events","type":"User","site_admin":false},"comments":6,"review_comments":19,"commits":7,"additions":404,"deletions":54,"changed_files":9}}
{"actor":{"display_login":"yyscamper"}}