{"action":"created","issue":{"url":"https://api.github.com/repos/meetecho/janus-gateway/issues/470","repository_url":"https://api.github.com/repos/meetecho/janus-gateway","labels_url":"https://api.github.com/repos/meetecho/janus-gateway/issues/470/labels{/name}","comments_url":"https://api.github.com/repos/meetecho/janus-gateway/issues/470/comments","events_url":"https://api.github.com/repos/meetecho/janus-gateway/issues/470/events","html_url":"https://github.com/meetecho/janus-gateway/pull/470","id":134535959,"number":470,"title":"Added optional SDES-SRTP support to SIP plugin","user":{"login":"lminiero","id":3684796,"avatar_url":"https://avatars.githubusercontent.com/u/3684796?v=3","gravatar_id":"","url":"https://api.github.com/users/lminiero","html_url":"https://github.com/lminiero","followers_url":"https://api.github.com/users/lminiero/followers","following_url":"https://api.github.com/users/lminiero/following{/other_user}","gists_url":"https://api.github.com/users/lminiero/gists{/gist_id}","starred_url":"https://api.github.com/users/lminiero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lminiero/subscriptions","organizations_url":"https://api.github.com/users/lminiero/orgs","repos_url":"https://api.github.com/users/lminiero/repos","events_url":"https://api.github.com/users/lminiero/events{/privacy}","received_events_url":"https://api.github.com/users/lminiero/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2016-02-18T10:14:44Z","updated_at":"2016-03-01T13:10:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/meetecho/janus-gateway/pulls/470","html_url":"https://github.com/meetecho/janus-gateway/pull/470","diff_url":"https://github.com/meetecho/janus-gateway/pull/470.diff","patch_url":"https://github.com/meetecho/janus-gateway/pull/470.patch"},"body":"This PR adds support for SDES-SRTP to calls handled by the SIP plugin. To enable this for outgoing calls, just add a ```srtp:true``` attribute to a ```\"call\"``` request. It will be enabled automatically, instead, for incoming calls with a crypto line in it.\r\n\r\nTested in different scenarios and it seems to be working fine both for incoming and outgoing calls. The parsing of crypto lines can definitely be improved (we don't handle all the possibilities for the ```inline``` part, for instance, assuming it's always just the base64 encoded key/salt), but there will be time for that.\r\n\r\nFeel free to play with this, especially if you have SDES endpoints you want to test this with (I've only tested this with Asterisk 13.6.0). Feedback welcome as I plan to merge this soon."},"comment":{"url":"https://api.github.com/repos/meetecho/janus-gateway/issues/comments/190717337","html_url":"https://github.com/meetecho/janus-gateway/pull/470#issuecomment-190717337","issue_url":"https://api.github.com/repos/meetecho/janus-gateway/issues/470","id":190717337,"user":{"login":"lminiero","id":3684796,"avatar_url":"https://avatars.githubusercontent.com/u/3684796?v=3","gravatar_id":"","url":"https://api.github.com/users/lminiero","html_url":"https://github.com/lminiero","followers_url":"https://api.github.com/users/lminiero/followers","following_url":"https://api.github.com/users/lminiero/following{/other_user}","gists_url":"https://api.github.com/users/lminiero/gists{/gist_id}","starred_url":"https://api.github.com/users/lminiero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lminiero/subscriptions","organizations_url":"https://api.github.com/users/lminiero/orgs","repos_url":"https://api.github.com/users/lminiero/repos","events_url":"https://api.github.com/users/lminiero/events{/privacy}","received_events_url":"https://api.github.com/users/lminiero/received_events","type":"User","site_admin":false},"created_at":"2016-03-01T13:10:23Z","updated_at":"2016-03-01T13:10:23Z","body":"Cool, thanks! Merging then."}}