{"action":"created","issue":{"url":"https://api.github.com/repos/frerich/clcache/issues/156","repository_url":"https://api.github.com/repos/frerich/clcache","labels_url":"https://api.github.com/repos/frerich/clcache/issues/156/labels{/name}","comments_url":"https://api.github.com/repos/frerich/clcache/issues/156/comments","events_url":"https://api.github.com/repos/frerich/clcache/issues/156/events","html_url":"https://github.com/frerich/clcache/pull/156","id":164686656,"number":156,"title":"Fix print stderr bug on preprocessor fail","user":{"login":"webmaster128","id":2603011,"avatar_url":"https://avatars.githubusercontent.com/u/2603011?v=3","gravatar_id":"","url":"https://api.github.com/users/webmaster128","html_url":"https://github.com/webmaster128","followers_url":"https://api.github.com/users/webmaster128/followers","following_url":"https://api.github.com/users/webmaster128/following{/other_user}","gists_url":"https://api.github.com/users/webmaster128/gists{/gist_id}","starred_url":"https://api.github.com/users/webmaster128/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmaster128/subscriptions","organizations_url":"https://api.github.com/users/webmaster128/orgs","repos_url":"https://api.github.com/users/webmaster128/repos","events_url":"https://api.github.com/users/webmaster128/events{/privacy}","received_events_url":"https://api.github.com/users/webmaster128/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":21,"created_at":"2016-07-09T21:32:52Z","updated_at":"2016-07-12T18:55:10Z","closed_at":"2016-07-12T17:50:24Z","pull_request":{"url":"https://api.github.com/repos/frerich/clcache/pulls/156","html_url":"https://github.com/frerich/clcache/pull/156","diff_url":"https://github.com/frerich/clcache/pull/156.diff","patch_url":"https://github.com/frerich/clcache/pull/156.patch"},"body":"This is a follow-up on #153 because I think I found a place in the code, that does not do proper binary output to stdout/stderr:\r\n\r\n```python\r\n    @staticmethod\r\n    def computeKey(compilerBinary, commandLine):\r\n        ppcmd = [compilerBinary, \"/EP\"]\r\n        ppcmd += [arg for arg in commandLine if arg not in (\"-c\", \"/c\")]\r\n        preprocessor = Popen(ppcmd, stdout=PIPE, stderr=PIPE)\r\n        (preprocessedSourceCode, pperr) = preprocessor.communicate()\r\n\r\n        if preprocessor.returncode != 0:\r\n            sys.stderr.write(pperr)\r\n            sys.stderr.write(\"clcache: preprocessor failed\\n\")\r\n            sys.exit(preprocessor.returncode)\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/frerich/clcache/issues/comments/232144280","html_url":"https://github.com/frerich/clcache/pull/156#issuecomment-232144280","issue_url":"https://api.github.com/repos/frerich/clcache/issues/156","id":232144280,"user":{"login":"webmaster128","id":2603011,"avatar_url":"https://avatars.githubusercontent.com/u/2603011?v=3","gravatar_id":"","url":"https://api.github.com/users/webmaster128","html_url":"https://github.com/webmaster128","followers_url":"https://api.github.com/users/webmaster128/followers","following_url":"https://api.github.com/users/webmaster128/following{/other_user}","gists_url":"https://api.github.com/users/webmaster128/gists{/gist_id}","starred_url":"https://api.github.com/users/webmaster128/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmaster128/subscriptions","organizations_url":"https://api.github.com/users/webmaster128/orgs","repos_url":"https://api.github.com/users/webmaster128/repos","events_url":"https://api.github.com/users/webmaster128/events{/privacy}","received_events_url":"https://api.github.com/users/webmaster128/received_events","type":"User","site_admin":false},"created_at":"2016-07-12T18:55:10Z","updated_at":"2016-07-12T18:55:10Z","body":"I am out of ideas and don't know how to continue with this. Dropping Python 2 support seems like a good idea, since solid IO is a core requirement for clcache.\r\n\r\nThe list of supported Windows systems should be roughly same as long as we support Python 3.4:\r\n\r\n> Up to 2.5, Python was still compatible with Windows 95, 98 and ME (but already raised a deprecation warning on installation). For Python 2.6 (and all following releases), this support was dropped and new releases are just expected to work on the Windows NT family.\r\n\r\nhttps://docs.python.org/2/using/windows.html\r\n\r\n> As specified in PEP 11, a Python release only supports a Windows platform while Microsoft considers the platform under extended support. This means that Python 3.5 supports Windows Vista and newer. If you require Windows XP support then please install Python 3.4.\r\n\r\nhttps://docs.python.org/3/using/windows.html#supported-versions"}}
{"actor":{"display_login":"webmaster128"}}