{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-init/pulls/comments/72611353","id":72611353,"diff_hunk":"@@ -185,14 +211,29 @@ def crowbar_status(request_type = :html)\n           }\n         end\n \n+        # TODO: this method needs to be refactored a bit in general\n         def wait_for_crowbar\n           logger.debug(\"Waiting for crowbar to become available\")\n-          sleep 1 until crowbar_status[:body]\n-          sleep 1 until crowbar_status[:body].include? \"installer-installers\"\n-\n-          # apache takes some time to perform the final switch\n-          # TODO: implement a busyloop\n-          sleep 15\n+          begin\n+            # TODO: add a timeout handling and set the status in case of a timeout\n+            sleep 1 until crowbar_status[:body]\n+            sleep 1 until crowbar_status[:body].include? \"installer-installers\"\n+\n+            # apache takes some time to perform the final switch\n+            # TODO: implement a busyloop\n+            sleep 15\n+            {\n+              stdout: \"\",\n+              stderr: \"\",\n+              exit_code: 0\n+            }\n+          rescue => e\n+            {\n+              stdout: \"\",\n+              stderr: \"#{e.message.inspect}\",","path":"lib/crowbar/init/application.rb","position":153,"original_position":153,"commit_id":"36e2bb78b72cc4a79c4df832d348760ad4752ecf","original_commit_id":"36e2bb78b72cc4a79c4df832d348760ad4752ecf","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Style/UnneededInterpolation: Prefer `to_s` over string interpolation.","created_at":"2016-07-28T12:23:41Z","updated_at":"2016-07-28T12:23:41Z","html_url":"https://github.com/crowbar/crowbar-init/pull/16#discussion_r72611353","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-init/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-init/pulls/comments/72611353"},"html":{"href":"https://github.com/crowbar/crowbar-init/pull/16#discussion_r72611353"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-init/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-init/pulls/16","id":79009456,"html_url":"https://github.com/crowbar/crowbar-init/pull/16","diff_url":"https://github.com/crowbar/crowbar-init/pull/16.diff","patch_url":"https://github.com/crowbar/crowbar-init/pull/16.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-init/issues/16","number":16,"state":"open","locked":false,"title":"cleanup, fixes and adding endpoint to test connections","user":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-27T11:41:27Z","updated_at":"2016-07-28T12:23:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a3eb32424a7ccfba3d672fcfd2c0eb40cce9907","assignee":{"login":"rsalevsky","id":4128547,"avatar_url":"https://avatars.githubusercontent.com/u/4128547?v=3","gravatar_id":"","url":"https://api.github.com/users/rsalevsky","html_url":"https://github.com/rsalevsky","followers_url":"https://api.github.com/users/rsalevsky/followers","following_url":"https://api.github.com/users/rsalevsky/following{/other_user}","gists_url":"https://api.github.com/users/rsalevsky/gists{/gist_id}","starred_url":"https://api.github.com/users/rsalevsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsalevsky/subscriptions","organizations_url":"https://api.github.com/users/rsalevsky/orgs","repos_url":"https://api.github.com/users/rsalevsky/repos","events_url":"https://api.github.com/users/rsalevsky/events{/privacy}","received_events_url":"https://api.github.com/users/rsalevsky/received_events","type":"User","site_admin":false},"assignees":[{"login":"rsalevsky","id":4128547,"avatar_url":"https://avatars.githubusercontent.com/u/4128547?v=3","gravatar_id":"","url":"https://api.github.com/users/rsalevsky","html_url":"https://github.com/rsalevsky","followers_url":"https://api.github.com/users/rsalevsky/followers","following_url":"https://api.github.com/users/rsalevsky/following{/other_user}","gists_url":"https://api.github.com/users/rsalevsky/gists{/gist_id}","starred_url":"https://api.github.com/users/rsalevsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsalevsky/subscriptions","organizations_url":"https://api.github.com/users/rsalevsky/orgs","repos_url":"https://api.github.com/users/rsalevsky/repos","events_url":"https://api.github.com/users/rsalevsky/events{/privacy}","received_events_url":"https://api.github.com/users/rsalevsky/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-init/pulls/16/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-init/pulls/16/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-init/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-init/issues/16/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-init/statuses/36e2bb78b72cc4a79c4df832d348760ad4752ecf","head":{"label":"MaximilianMeister:cleanup-fixes","ref":"cleanup-fixes","sha":"36e2bb78b72cc4a79c4df832d348760ad4752ecf","user":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"repo":{"id":56776659,"name":"crowbar-init","full_name":"MaximilianMeister/crowbar-init","owner":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MaximilianMeister/crowbar-init","description":"Init process for Crowbar","fork":true,"url":"https://api.github.com/repos/MaximilianMeister/crowbar-init","forks_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/forks","keys_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/teams","hooks_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/hooks","issue_events_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/issues/events{/number}","events_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/events","assignees_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/assignees{/user}","branches_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/branches{/branch}","tags_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/tags","blobs_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/statuses/{sha}","languages_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/languages","stargazers_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/stargazers","contributors_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/contributors","subscribers_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/subscribers","subscription_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/subscription","commits_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/issues/comments{/number}","contents_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/contents/{+path}","compare_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/merges","archive_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/downloads","issues_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/issues{/number}","pulls_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/pulls{/number}","milestones_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/milestones{/number}","notifications_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/labels{/name}","releases_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/releases{/id}","deployments_url":"https://api.github.com/repos/MaximilianMeister/crowbar-init/deployments","created_at":"2016-04-21T13:37:40Z","updated_at":"2016-04-21T13:37:41Z","pushed_at":"2016-07-28T12:23:33Z","git_url":"git://github.com/MaximilianMeister/crowbar-init.git","ssh_url":"git@github.com:MaximilianMeister/crowbar-init.git","clone_url":"https://github.com/MaximilianMeister/crowbar-init.git","svn_url":"https://github.com/MaximilianMeister/crowbar-init","homepage":"","size":176,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"ea4bff5f856b2a9d6d1c524846ed0ef37f7e0c5c","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":56591765,"name":"crowbar-init","full_name":"crowbar/crowbar-init","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-init","description":"Init process for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-init","forks_url":"https://api.github.com/repos/crowbar/crowbar-init/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-init/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-init/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-init/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-init/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-init/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-init/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-init/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-init/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-init/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-init/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-init/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-init/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-init/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-init/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-init/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-init/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-init/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-init/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-init/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-init/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-init/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-init/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-init/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-init/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-init/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-init/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-init/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-init/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-init/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-init/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-init/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-init/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-init/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-init/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-init/deployments","created_at":"2016-04-19T11:41:06Z","updated_at":"2016-04-20T13:25:08Z","pushed_at":"2016-07-28T12:23:34Z","git_url":"git://github.com/crowbar/crowbar-init.git","ssh_url":"git@github.com:crowbar/crowbar-init.git","clone_url":"https://github.com/crowbar/crowbar-init.git","svn_url":"https://github.com/crowbar/crowbar-init","homepage":"","size":150,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-init/pulls/16"},"html":{"href":"https://github.com/crowbar/crowbar-init/pull/16"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-init/issues/16"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-init/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-init/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-init/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-init/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-init/statuses/36e2bb78b72cc4a79c4df832d348760ad4752ecf"}}}}
{"actor":{"display_login":"houndci-bot"}}