{"action":"created","comment":{"url":"https://api.github.com/repos/AArnott/pinvoke/pulls/comments/63735554","id":63735554,"diff_hunk":"@@ -938,6 +938,66 @@ public static partial class Kernel32\n         public static extern SafeLibraryHandle LoadLibraryEx(string lpFileName, IntPtr hFile, LoadLibraryExFlags dwFlags);\n \n         /// <summary>\n+        /// Retrieves a module handle for the specified module. The module must have been loaded by the calling process.\n+        /// </summary>\n+        /// <param name=\"lpModuleName\">\n+        /// The name of the loaded module (either a .dll or .exe file).\n+        /// If the file name extension is omitted, the default library extension .dll is appended.\n+        /// The file name string can include a trailing point character (.) to indicate that the module name has no extension.\n+        /// The string does not have to specify a path. When specifying a path, be sure to use backslashes (\\), not forward slashes (/).\n+        /// The name is compared (case independently) to the names of modules currently mapped into the address space of the calling process.\n+        /// If this parameter is NULL, it returns a handle to the file used to create the calling process (.exe file).\n+        /// </param>\n+        /// <returns>\n+        /// If the function succeeds, the return value is a handle to the specified module.\n+        /// If the function fails, the return value is NULL.To get extended error information, call GetLastError.\n+        /// </returns>\n+        /// <remarks>\n+        /// This function does not retrieve handles for modules that were loaded using the <see cref=\"LoadLibraryExFlags.LOAD_LIBRARY_AS_DATAFILE\"/> flag.\n+        /// This function returns a handle to a mapped module without incrementing its reference count.\n+        /// However, if this handle is passed to the <see cref=\"FreeLibrary\"/> function, the reference count of the mapped module will be decremented.\n+        /// Therefore, do not pass a handle returned by this function to the <see cref=\"FreeLibrary\"/> function. Doing so can cause a DLL module to be unmapped prematurely.\n+        /// </remarks>\n+        [DllImport(nameof(Kernel32), SetLastError = true, CharSet = CharSet.Auto)]\n+        public static extern SafeLibraryHandle GetModuleHandle(string lpModuleName);\n+\n+        /// <summary>\n+        /// Retrieves a module handle for the specified module and increments the module's reference count unless <see cref=\"GetModuleHandleExFlags.GET_MODULE_HANDLE_EX_FLAG_UNCHANGED_REFCOUNT\"/> is specified.\n+        /// The module must have been loaded by the calling process.\n+        /// </summary>\n+        /// <param name=\"dwFlags\">\n+        /// This parameter can be zero or one or more of the following values.\n+        /// If the module's reference count is incremented, the caller must use the <see cref=\"FreeLibrary\"/> function to decrement the reference count when the module handle is no longer needed.</param>\n+        /// <param name=\"lpModuleName\">The name of the loaded module (either a .dll or .exe file), or an address in the module (if <paramref name=\"dwFlags\"/> is <see cref=\"GetModuleHandleExFlags.GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS\"/>).</param>\n+        /// <param name=\"phModule\">\n+        /// A handle to the specified module. If the function fails, this parameter is NULL.\n+        /// </param>\n+        /// <returns>\n+        /// If the function succeeds, returns true. If the function fails, the returns false.\n+        /// To get extended error information, see <see cref=\"GetLastError\"/>.\n+        /// </returns>\n+        /// <remarks>\n+        /// The handle returned is not global or inheritable. It cannot be duplicated or used by another process.\n+        /// This function does not retrieve handles for modules that were loaded using the <see cref=\"LoadLibraryExFlags.LOAD_LIBRARY_AS_DATAFILE\"/> flag.\n+        /// </remarks>\n+        [DllImport(nameof(Kernel32), SetLastError = true, CharSet = CharSet.Auto)]","path":"src/Kernel32.Desktop/Kernel32.cs","position":46,"original_position":46,"commit_id":"c487d1335b8fcc7fbbcba1ac1b2186cd81737175","original_commit_id":"c487d1335b8fcc7fbbcba1ac1b2186cd81737175","user":{"login":"arlm","id":326831,"avatar_url":"https://avatars.githubusercontent.com/u/326831?v=3","gravatar_id":"","url":"https://api.github.com/users/arlm","html_url":"https://github.com/arlm","followers_url":"https://api.github.com/users/arlm/followers","following_url":"https://api.github.com/users/arlm/following{/other_user}","gists_url":"https://api.github.com/users/arlm/gists{/gist_id}","starred_url":"https://api.github.com/users/arlm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arlm/subscriptions","organizations_url":"https://api.github.com/users/arlm/orgs","repos_url":"https://api.github.com/users/arlm/repos","events_url":"https://api.github.com/users/arlm/events{/privacy}","received_events_url":"https://api.github.com/users/arlm/received_events","type":"User","site_admin":false},"body":"I don't know. For me Unicode is always best but what are our guidelines on CharSets on this project?","created_at":"2016-05-18T16:22:03Z","updated_at":"2016-05-18T16:22:03Z","html_url":"https://github.com/AArnott/pinvoke/pull/246#discussion_r63735554","pull_request_url":"https://api.github.com/repos/AArnott/pinvoke/pulls/246","_links":{"self":{"href":"https://api.github.com/repos/AArnott/pinvoke/pulls/comments/63735554"},"html":{"href":"https://github.com/AArnott/pinvoke/pull/246#discussion_r63735554"},"pull_request":{"href":"https://api.github.com/repos/AArnott/pinvoke/pulls/246"}}},"pull_request":{"url":"https://api.github.com/repos/AArnott/pinvoke/pulls/246","id":70542258,"html_url":"https://github.com/AArnott/pinvoke/pull/246","diff_url":"https://github.com/AArnott/pinvoke/pull/246.diff","patch_url":"https://github.com/AArnott/pinvoke/pull/246.patch","issue_url":"https://api.github.com/repos/AArnott/pinvoke/issues/246","number":246,"state":"open","locked":false,"title":"Some Kernel32 functions","user":{"login":"arlm","id":326831,"avatar_url":"https://avatars.githubusercontent.com/u/326831?v=3","gravatar_id":"","url":"https://api.github.com/users/arlm","html_url":"https://github.com/arlm","followers_url":"https://api.github.com/users/arlm/followers","following_url":"https://api.github.com/users/arlm/following{/other_user}","gists_url":"https://api.github.com/users/arlm/gists{/gist_id}","starred_url":"https://api.github.com/users/arlm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arlm/subscriptions","organizations_url":"https://api.github.com/users/arlm/orgs","repos_url":"https://api.github.com/users/arlm/repos","events_url":"https://api.github.com/users/arlm/events{/privacy}","received_events_url":"https://api.github.com/users/arlm/received_events","type":"User","site_admin":false},"body":"As I was looking around on the enums, I have noticed that some introduced a zero-state None field, but the naming is inconsistent. Some are just None, some follow the inner enum naming system like SH_FLAG_NONE. which one is the most appropriate? If it is the inner naming system, can I add the fix to this commit?","created_at":"2016-05-18T14:52:12Z","updated_at":"2016-05-18T16:22:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e26eac66167edf6c2381580bb873dba698d2a86","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AArnott/pinvoke/pulls/246/commits","review_comments_url":"https://api.github.com/repos/AArnott/pinvoke/pulls/246/comments","review_comment_url":"https://api.github.com/repos/AArnott/pinvoke/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AArnott/pinvoke/issues/246/comments","statuses_url":"https://api.github.com/repos/AArnott/pinvoke/statuses/c487d1335b8fcc7fbbcba1ac1b2186cd81737175","head":{"label":"arlm:feature/kernel32","ref":"feature/kernel32","sha":"c487d1335b8fcc7fbbcba1ac1b2186cd81737175","user":{"login":"arlm","id":326831,"avatar_url":"https://avatars.githubusercontent.com/u/326831?v=3","gravatar_id":"","url":"https://api.github.com/users/arlm","html_url":"https://github.com/arlm","followers_url":"https://api.github.com/users/arlm/followers","following_url":"https://api.github.com/users/arlm/following{/other_user}","gists_url":"https://api.github.com/users/arlm/gists{/gist_id}","starred_url":"https://api.github.com/users/arlm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arlm/subscriptions","organizations_url":"https://api.github.com/users/arlm/orgs","repos_url":"https://api.github.com/users/arlm/repos","events_url":"https://api.github.com/users/arlm/events{/privacy}","received_events_url":"https://api.github.com/users/arlm/received_events","type":"User","site_admin":false},"repo":{"id":54407852,"name":"pinvoke","full_name":"arlm/pinvoke","owner":{"login":"arlm","id":326831,"avatar_url":"https://avatars.githubusercontent.com/u/326831?v=3","gravatar_id":"","url":"https://api.github.com/users/arlm","html_url":"https://github.com/arlm","followers_url":"https://api.github.com/users/arlm/followers","following_url":"https://api.github.com/users/arlm/following{/other_user}","gists_url":"https://api.github.com/users/arlm/gists{/gist_id}","starred_url":"https://api.github.com/users/arlm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arlm/subscriptions","organizations_url":"https://api.github.com/users/arlm/orgs","repos_url":"https://api.github.com/users/arlm/repos","events_url":"https://api.github.com/users/arlm/events{/privacy}","received_events_url":"https://api.github.com/users/arlm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arlm/pinvoke","description":"A library containing all PInvoke code so you don't have to import it every time. Maintained and updated to support the latest Windows OS.","fork":true,"url":"https://api.github.com/repos/arlm/pinvoke","forks_url":"https://api.github.com/repos/arlm/pinvoke/forks","keys_url":"https://api.github.com/repos/arlm/pinvoke/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arlm/pinvoke/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arlm/pinvoke/teams","hooks_url":"https://api.github.com/repos/arlm/pinvoke/hooks","issue_events_url":"https://api.github.com/repos/arlm/pinvoke/issues/events{/number}","events_url":"https://api.github.com/repos/arlm/pinvoke/events","assignees_url":"https://api.github.com/repos/arlm/pinvoke/assignees{/user}","branches_url":"https://api.github.com/repos/arlm/pinvoke/branches{/branch}","tags_url":"https://api.github.com/repos/arlm/pinvoke/tags","blobs_url":"https://api.github.com/repos/arlm/pinvoke/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arlm/pinvoke/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arlm/pinvoke/git/refs{/sha}","trees_url":"https://api.github.com/repos/arlm/pinvoke/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arlm/pinvoke/statuses/{sha}","languages_url":"https://api.github.com/repos/arlm/pinvoke/languages","stargazers_url":"https://api.github.com/repos/arlm/pinvoke/stargazers","contributors_url":"https://api.github.com/repos/arlm/pinvoke/contributors","subscribers_url":"https://api.github.com/repos/arlm/pinvoke/subscribers","subscription_url":"https://api.github.com/repos/arlm/pinvoke/subscription","commits_url":"https://api.github.com/repos/arlm/pinvoke/commits{/sha}","git_commits_url":"https://api.github.com/repos/arlm/pinvoke/git/commits{/sha}","comments_url":"https://api.github.com/repos/arlm/pinvoke/comments{/number}","issue_comment_url":"https://api.github.com/repos/arlm/pinvoke/issues/comments{/number}","contents_url":"https://api.github.com/repos/arlm/pinvoke/contents/{+path}","compare_url":"https://api.github.com/repos/arlm/pinvoke/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arlm/pinvoke/merges","archive_url":"https://api.github.com/repos/arlm/pinvoke/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arlm/pinvoke/downloads","issues_url":"https://api.github.com/repos/arlm/pinvoke/issues{/number}","pulls_url":"https://api.github.com/repos/arlm/pinvoke/pulls{/number}","milestones_url":"https://api.github.com/repos/arlm/pinvoke/milestones{/number}","notifications_url":"https://api.github.com/repos/arlm/pinvoke/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arlm/pinvoke/labels{/name}","releases_url":"https://api.github.com/repos/arlm/pinvoke/releases{/id}","deployments_url":"https://api.github.com/repos/arlm/pinvoke/deployments","created_at":"2016-03-21T17:05:34Z","updated_at":"2016-03-21T17:05:36Z","pushed_at":"2016-05-18T15:58:29Z","git_url":"git://github.com/arlm/pinvoke.git","ssh_url":"git@github.com:arlm/pinvoke.git","clone_url":"https://github.com/arlm/pinvoke.git","svn_url":"https://github.com/arlm/pinvoke","homepage":null,"size":2029,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AArnott:master","ref":"master","sha":"b2b6b00a7a6720569699302524a0b1d877a1f5af","user":{"login":"AArnott","id":3548,"avatar_url":"https://avatars.githubusercontent.com/u/3548?v=3","gravatar_id":"","url":"https://api.github.com/users/AArnott","html_url":"https://github.com/AArnott","followers_url":"https://api.github.com/users/AArnott/followers","following_url":"https://api.github.com/users/AArnott/following{/other_user}","gists_url":"https://api.github.com/users/AArnott/gists{/gist_id}","starred_url":"https://api.github.com/users/AArnott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AArnott/subscriptions","organizations_url":"https://api.github.com/users/AArnott/orgs","repos_url":"https://api.github.com/users/AArnott/repos","events_url":"https://api.github.com/users/AArnott/events{/privacy}","received_events_url":"https://api.github.com/users/AArnott/received_events","type":"User","site_admin":false},"repo":{"id":44758360,"name":"pinvoke","full_name":"AArnott/pinvoke","owner":{"login":"AArnott","id":3548,"avatar_url":"https://avatars.githubusercontent.com/u/3548?v=3","gravatar_id":"","url":"https://api.github.com/users/AArnott","html_url":"https://github.com/AArnott","followers_url":"https://api.github.com/users/AArnott/followers","following_url":"https://api.github.com/users/AArnott/following{/other_user}","gists_url":"https://api.github.com/users/AArnott/gists{/gist_id}","starred_url":"https://api.github.com/users/AArnott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AArnott/subscriptions","organizations_url":"https://api.github.com/users/AArnott/orgs","repos_url":"https://api.github.com/users/AArnott/repos","events_url":"https://api.github.com/users/AArnott/events{/privacy}","received_events_url":"https://api.github.com/users/AArnott/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AArnott/pinvoke","description":"A library containing all PInvoke code so you don't have to import it every time. Maintained and updated to support the latest Windows OS.","fork":false,"url":"https://api.github.com/repos/AArnott/pinvoke","forks_url":"https://api.github.com/repos/AArnott/pinvoke/forks","keys_url":"https://api.github.com/repos/AArnott/pinvoke/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AArnott/pinvoke/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AArnott/pinvoke/teams","hooks_url":"https://api.github.com/repos/AArnott/pinvoke/hooks","issue_events_url":"https://api.github.com/repos/AArnott/pinvoke/issues/events{/number}","events_url":"https://api.github.com/repos/AArnott/pinvoke/events","assignees_url":"https://api.github.com/repos/AArnott/pinvoke/assignees{/user}","branches_url":"https://api.github.com/repos/AArnott/pinvoke/branches{/branch}","tags_url":"https://api.github.com/repos/AArnott/pinvoke/tags","blobs_url":"https://api.github.com/repos/AArnott/pinvoke/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AArnott/pinvoke/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AArnott/pinvoke/git/refs{/sha}","trees_url":"https://api.github.com/repos/AArnott/pinvoke/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AArnott/pinvoke/statuses/{sha}","languages_url":"https://api.github.com/repos/AArnott/pinvoke/languages","stargazers_url":"https://api.github.com/repos/AArnott/pinvoke/stargazers","contributors_url":"https://api.github.com/repos/AArnott/pinvoke/contributors","subscribers_url":"https://api.github.com/repos/AArnott/pinvoke/subscribers","subscription_url":"https://api.github.com/repos/AArnott/pinvoke/subscription","commits_url":"https://api.github.com/repos/AArnott/pinvoke/commits{/sha}","git_commits_url":"https://api.github.com/repos/AArnott/pinvoke/git/commits{/sha}","comments_url":"https://api.github.com/repos/AArnott/pinvoke/comments{/number}","issue_comment_url":"https://api.github.com/repos/AArnott/pinvoke/issues/comments{/number}","contents_url":"https://api.github.com/repos/AArnott/pinvoke/contents/{+path}","compare_url":"https://api.github.com/repos/AArnott/pinvoke/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AArnott/pinvoke/merges","archive_url":"https://api.github.com/repos/AArnott/pinvoke/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AArnott/pinvoke/downloads","issues_url":"https://api.github.com/repos/AArnott/pinvoke/issues{/number}","pulls_url":"https://api.github.com/repos/AArnott/pinvoke/pulls{/number}","milestones_url":"https://api.github.com/repos/AArnott/pinvoke/milestones{/number}","notifications_url":"https://api.github.com/repos/AArnott/pinvoke/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AArnott/pinvoke/labels{/name}","releases_url":"https://api.github.com/repos/AArnott/pinvoke/releases{/id}","deployments_url":"https://api.github.com/repos/AArnott/pinvoke/deployments","created_at":"2015-10-22T16:28:01Z","updated_at":"2016-05-18T16:21:09Z","pushed_at":"2016-05-18T15:58:29Z","git_url":"git://github.com/AArnott/pinvoke.git","ssh_url":"git@github.com:AArnott/pinvoke.git","clone_url":"https://github.com/AArnott/pinvoke.git","svn_url":"https://github.com/AArnott/pinvoke","homepage":null,"size":2100,"stargazers_count":147,"watchers_count":147,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":11,"forks":17,"open_issues":11,"watchers":147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AArnott/pinvoke/pulls/246"},"html":{"href":"https://github.com/AArnott/pinvoke/pull/246"},"issue":{"href":"https://api.github.com/repos/AArnott/pinvoke/issues/246"},"comments":{"href":"https://api.github.com/repos/AArnott/pinvoke/issues/246/comments"},"review_comments":{"href":"https://api.github.com/repos/AArnott/pinvoke/pulls/246/comments"},"review_comment":{"href":"https://api.github.com/repos/AArnott/pinvoke/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AArnott/pinvoke/pulls/246/commits"},"statuses":{"href":"https://api.github.com/repos/AArnott/pinvoke/statuses/c487d1335b8fcc7fbbcba1ac1b2186cd81737175"}}}}