{"action":"created","issue":{"url":"https://api.github.com/repos/rails/rails/issues/26067","repository_url":"https://api.github.com/repos/rails/rails","labels_url":"https://api.github.com/repos/rails/rails/issues/26067/labels{/name}","comments_url":"https://api.github.com/repos/rails/rails/issues/26067/comments","events_url":"https://api.github.com/repos/rails/rails/issues/26067/events","html_url":"https://github.com/rails/rails/pull/26067","id":169680784,"number":26067,"title":"Use `FETCH FIRST` for Oracle12 and test `ROWNUM <=` for Oracle 11g or older version to test sql limit behavior","user":{"login":"yahonda","id":73684,"avatar_url":"https://avatars.githubusercontent.com/u/73684?v=3","gravatar_id":"","url":"https://api.github.com/users/yahonda","html_url":"https://github.com/yahonda","followers_url":"https://api.github.com/users/yahonda/followers","following_url":"https://api.github.com/users/yahonda/following{/other_user}","gists_url":"https://api.github.com/users/yahonda/gists{/gist_id}","starred_url":"https://api.github.com/users/yahonda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahonda/subscriptions","organizations_url":"https://api.github.com/users/yahonda/orgs","repos_url":"https://api.github.com/users/yahonda/repos","events_url":"https://api.github.com/users/yahonda/events{/privacy}","received_events_url":"https://api.github.com/users/yahonda/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rails/rails/labels/activerecord","name":"activerecord","color":"0b02e1"}],"state":"open","locked":false,"assignee":{"login":"matthewd","id":1034,"avatar_url":"https://avatars.githubusercontent.com/u/1034?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewd","html_url":"https://github.com/matthewd","followers_url":"https://api.github.com/users/matthewd/followers","following_url":"https://api.github.com/users/matthewd/following{/other_user}","gists_url":"https://api.github.com/users/matthewd/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewd/subscriptions","organizations_url":"https://api.github.com/users/matthewd/orgs","repos_url":"https://api.github.com/users/matthewd/repos","events_url":"https://api.github.com/users/matthewd/events{/privacy}","received_events_url":"https://api.github.com/users/matthewd/received_events","type":"User","site_admin":false},"assignees":[{"login":"matthewd","id":1034,"avatar_url":"https://avatars.githubusercontent.com/u/1034?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewd","html_url":"https://github.com/matthewd","followers_url":"https://api.github.com/users/matthewd/followers","following_url":"https://api.github.com/users/matthewd/following{/other_user}","gists_url":"https://api.github.com/users/matthewd/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewd/subscriptions","organizations_url":"https://api.github.com/users/matthewd/orgs","repos_url":"https://api.github.com/users/matthewd/repos","events_url":"https://api.github.com/users/matthewd/events{/privacy}","received_events_url":"https://api.github.com/users/matthewd/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2016-08-05T19:35:59Z","updated_at":"2016-08-08T14:47:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/26067","html_url":"https://github.com/rails/rails/pull/26067","diff_url":"https://github.com/rails/rails/pull/26067.diff","patch_url":"https://github.com/rails/rails/pull/26067.patch"},"body":"### Summary\r\n\r\nThis pull request addresses this following failure when tested with Oracle Database 12c.\r\n\r\n```ruby\r\n$ cd activerecord\r\n$ ARCONN=oracle bundle exec ruby -W -w -I\"lib:test\" test/cases/finder_test.rb -n test_take_and_first_and_last_with_integer_should_use_sql_limit\r\n\r\n... snip ...\r\n\r\n# Running:\r\n\r\nF\r\n\r\nFinished in 0.826707s, 1.2096 runs/s, 1.2096 assertions/s.\r\n\r\n  1) Failure:\r\nFinderTest#test_take_and_first_and_last_with_integer_should_use_sql_limit [test/cases/finder_test.rb:568]:\r\nQuery pattern(s) /LIMIT|ROWNUM <=/ not found.\r\nQueries:\r\nSELECT  \"TOPICS\".* FROM \"TOPICS\" FETCH FIRST :a1 ROWS ONLY\r\n\r\n1 runs, 1 assertions, 1 failures, 0 errors, 0 skips\r\n$\r\n```\r\nSince Oracle 12c database introduces better top N query using `FETCH FIRST n ROWS` and Arel supports [this syntax](https://github.com/rails/arel/blob/master/lib/arel/visitors/oracle12.rb)\r\n\r\n### Other Information\r\n```\r\n* Rails `master` branch\r\n* Oracle enhanced adapter `rails51` branch\r\n* Oracle Database 12c Enterprise Edition Release 12.1.0.2.0 - 64bit Production\r\n* ruby 2.4.0dev (2016-08-04 trunk 55812) [x86_64-linux]\r\n```"},"comment":{"url":"https://api.github.com/repos/rails/rails/issues/comments/238260911","html_url":"https://github.com/rails/rails/pull/26067#issuecomment-238260911","issue_url":"https://api.github.com/repos/rails/rails/issues/26067","id":238260911,"user":{"login":"yahonda","id":73684,"avatar_url":"https://avatars.githubusercontent.com/u/73684?v=3","gravatar_id":"","url":"https://api.github.com/users/yahonda","html_url":"https://github.com/yahonda","followers_url":"https://api.github.com/users/yahonda/followers","following_url":"https://api.github.com/users/yahonda/following{/other_user}","gists_url":"https://api.github.com/users/yahonda/gists{/gist_id}","starred_url":"https://api.github.com/users/yahonda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahonda/subscriptions","organizations_url":"https://api.github.com/users/yahonda/orgs","repos_url":"https://api.github.com/users/yahonda/repos","events_url":"https://api.github.com/users/yahonda/events{/privacy}","received_events_url":"https://api.github.com/users/yahonda/received_events","type":"User","site_admin":false},"created_at":"2016-08-08T14:47:58Z","updated_at":"2016-08-08T14:47:58Z","body":"Add Oracle 11g support then squashed. Somehow it gets an error at ActionCable https://travis-ci.org/rails/rails/jobs/150643333 "}}
{"actor":{"display_login":"yahonda"}}