{"action":"created","issue":{"url":"https://api.github.com/repos/hyperledger/fabric/issues/1520","repository_url":"https://api.github.com/repos/hyperledger/fabric","labels_url":"https://api.github.com/repos/hyperledger/fabric/issues/1520/labels{/name}","comments_url":"https://api.github.com/repos/hyperledger/fabric/issues/1520/comments","events_url":"https://api.github.com/repos/hyperledger/fabric/issues/1520/events","html_url":"https://github.com/hyperledger/fabric/pull/1520","id":155778579,"number":1520,"title":"Connection code centralization.","user":{"login":"gennadylaventman","id":18242450,"avatar_url":"https://avatars.githubusercontent.com/u/18242450?v=3","gravatar_id":"","url":"https://api.github.com/users/gennadylaventman","html_url":"https://github.com/gennadylaventman","followers_url":"https://api.github.com/users/gennadylaventman/followers","following_url":"https://api.github.com/users/gennadylaventman/following{/other_user}","gists_url":"https://api.github.com/users/gennadylaventman/gists{/gist_id}","starred_url":"https://api.github.com/users/gennadylaventman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gennadylaventman/subscriptions","organizations_url":"https://api.github.com/users/gennadylaventman/orgs","repos_url":"https://api.github.com/users/gennadylaventman/repos","events_url":"https://api.github.com/users/gennadylaventman/events{/privacy}","received_events_url":"https://api.github.com/users/gennadylaventman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-05-19T16:22:06Z","updated_at":"2016-05-25T10:11:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hyperledger/fabric/pulls/1520","html_url":"https://github.com/hyperledger/fabric/pull/1520","diff_url":"https://github.com/hyperledger/fabric/pull/1520.diff","patch_url":"https://github.com/hyperledger/fabric/pull/1520.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\nMoving connection creation code to central place\r\n\r\n## Motivation and Context\r\n1. Connection creation code moved from\r\ncore/chaincode/shim/chaincode.go, core/peer/peer.go, events/consumer/consumer.go and core/crypto/node_grpc.go to new package core/comm (connection.go file) - issue #1362\r\n2. Cached configuration (\"peer.tls.enabled\") moved to comm/config.go instead peer/config.go, to avoid circular dependency.\r\n3. Added method to read peer tls credentials InitTLSForPeer to comm/connection.go, instead reading it in each file (peer.go, chaincode.go, consumer.go)\r\n4. Fixed hardcoded peer address in core/chaincode/shim/chaincode.go - issue #1304\r\n\r\nFixes #1362 \r\n\r\n## How Has This Been Tested?\r\nRun unit tests and behave tests\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have added a [Signed-off-by](https://github.com/hyperledger/fabric/blob/master/CONTRIBUTING.md#legal-stuff)\r\n- [x] Either no new documentation is required by this change, OR I added new documentation\r\n- [x] Either no new tests are required by this change, OR I added new tests\r\n- [x] I have run [goimports](https://godoc.org/golang.org/x/tools/cmd/goimports), [go vet](https://golang.org/cmd/vet/), and [golint](https://github.com/golang/lint). I have cleaned up all valid errors and warnings in code I have added or modified. These tools may generate false positives. Don't be worried about ignoring some errors or warnings. The goal is clean, consistent, and readable code.\r\n\r\nSigned-off-by: Gennady Laventman <gennady@il.ibm.com>"},"comment":{"url":"https://api.github.com/repos/hyperledger/fabric/issues/comments/221530810","html_url":"https://github.com/hyperledger/fabric/pull/1520#issuecomment-221530810","issue_url":"https://api.github.com/repos/hyperledger/fabric/issues/1520","id":221530810,"user":{"login":"gennadylaventman","id":18242450,"avatar_url":"https://avatars.githubusercontent.com/u/18242450?v=3","gravatar_id":"","url":"https://api.github.com/users/gennadylaventman","html_url":"https://github.com/gennadylaventman","followers_url":"https://api.github.com/users/gennadylaventman/followers","following_url":"https://api.github.com/users/gennadylaventman/following{/other_user}","gists_url":"https://api.github.com/users/gennadylaventman/gists{/gist_id}","starred_url":"https://api.github.com/users/gennadylaventman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gennadylaventman/subscriptions","organizations_url":"https://api.github.com/users/gennadylaventman/orgs","repos_url":"https://api.github.com/users/gennadylaventman/repos","events_url":"https://api.github.com/users/gennadylaventman/events{/privacy}","received_events_url":"https://api.github.com/users/gennadylaventman/received_events","type":"User","site_admin":false},"created_at":"2016-05-25T10:11:44Z","updated_at":"2016-05-25T10:11:44Z","body":"@mastersingh24 \r\nWill add it."}}
{"actor":{"display_login":"gennadylaventman"}}