{"push_id":1258318184,"size":36,"distinct_size":36,"ref":"refs/heads/master","head":"eb4e2880431cef2913bb8f093bc39ebf9d286e02","before":"836e67404fb1cfd750afe86c69a786fb69800946","commits":[{"sha":"8b2994bfba9212d0b6c214466f6d188c213813b8","author":{"name":"Dennis Fischer","email":"aa670e81a041b69a756e27462d546f88af5397d8@live.de"},"message":"Fix some failing test on non-english machines","distinct":true,"url":"https://api.github.com/repos/brettfo/roslyn/commits/8b2994bfba9212d0b6c214466f6d188c213813b8"},{"sha":"bf16d01235b4c3b79aa251dd99146ce93e3cb4c1","author":{"name":"Jonathon Marolf","email":"c0cac678ac3f080871362b231b64cd253e8afbed@microsoft.com"},"message":"fixing up stack trace logic as per Cyrus' suggestions","distinct":true,"url":"https://api.github.com/repos/brettfo/roslyn/commits/bf16d01235b4c3b79aa251dd99146ce93e3cb4c1"},{"sha":"664e6f670bde9273c34084923c176f60abac3404","author":{"name":"Nick Guerrera","email":"d253de2e036efd4bc2b8127fbae43e811a1813a5@microsoft.com"},"message":"Add support for embedding VB source in portable pdb","distinct":true,"url":"https://api.github.com/repos/brettfo/roslyn/commits/664e6f670bde9273c34084923c176f60abac3404"},{"sha":"fe9b69e204c44ae3f5daa4515424b7d90d89a4aa","author":{"name":"Nick Guerrera","email":"d253de2e036efd4bc2b8127fbae43e811a1813a5@microsoft.com"},"message":"Port C# /embed command-line tests to VB","distinct":true,"url":"https://api.github.com/repos/brettfo/roslyn/commits/fe9b69e204c44ae3f5daa4515424b7d90d89a4aa"},{"sha":"febbd63e14549e1fef1d3debf8cb200442630141","author":{"name":"Nick Guerrera","email":"d253de2e036efd4bc2b8127fbae43e811a1813a5@microsoft.com"},"message":"Port C# API-level embedded source tests to VB","distinct":true,"url":"https://api.github.com/repos/brettfo/roslyn/commits/febbd63e14549e1fef1d3debf8cb200442630141"},{"sha":"0d977aa749c60878a1bb1d736f3597976129ce11","author":{"name":"Nick Guerrera","email":"d253de2e036efd4bc2b8127fbae43e811a1813a5@microsoft.com"},"message":"Add EmbeddedFiles to VB task targets","distinct":true,"url":"https://api.github.com/repos/brettfo/roslyn/commits/0d977aa749c60878a1bb1d736f3597976129ce11"},{"sha":"f978dadcddae08dad2732b618afb34eb82286fbb","author":{"name":"CyrusNajmabadi","email":"e8403a592890f01f6615b2c4c091d0c6f8d6653b@microsoft.com"},"message":"Remove file that exists on disk, but isn't referenced by any Roslyn project.","distinct":true,"url":"https://api.github.com/repos/brettfo/roslyn/commits/f978dadcddae08dad2732b618afb34eb82286fbb"},{"sha":"bf3d55dc98b515e1669cf04dcfdbeb29c2fd263e","author":{"name":"CyrusNajmabadi","email":"e8403a592890f01f6615b2c4c091d0c6f8d6653b@microsoft.com"},"message":"Merge pull request #13224 from CyrusNajmabadi/removeDeadFile\n\nRemove file that exists on disk, but isn't referenced by any Roslyn project.","distinct":true,"url":"https://api.github.com/repos/brettfo/roslyn/commits/bf3d55dc98b515e1669cf04dcfdbeb29c2fd263e"},{"sha":"1842182228327fd34ce958d572eb61396290b4dd","author":{"name":"Ty Overby","email":"d4b55a5f2f8b5aed5e8462f4e51304a51069cd0c@pre-alpha.com"},"message":"Update CPC to version 3 (#13199)\n\n* Pull down CPC\r\n\r\n* clear files before testing","distinct":true,"url":"https://api.github.com/repos/brettfo/roslyn/commits/1842182228327fd34ce958d572eb61396290b4dd"},{"sha":"31c57103626b148b9f2224a62d63c7687cef15f1","author":{"name":"Dustin Campbell","email":"56b08fe8ce653d8a7a7096b8d075e915474fdbf3@teamcampbell.org"},"message":"Code Model: Implement CodeNamespace.Comment and CodeNamespace.DocComment properties\n\nThis change properly implements the CodeNamespace.Comment and CodeNamespace.DocComment properties. Historically, C# would throw an exception if either of these properties were accessed on a CodeNamespace, but VB allowed them to work. With this change, the properties will work for *both* C# and VB (even though DocComment doesn't make much sense). Technically, this is a breaking change for C# in the sense that an exception will no longer be thrown. However, I expect that it will generally make life a bit easier for Code Model consumers by keeping the implementations consistent between C# and VB.","distinct":true,"url":"https://api.github.com/repos/brettfo/roslyn/commits/31c57103626b148b9f2224a62d63c7687cef15f1"},{"sha":"f024493b420189c817e8f1eabe730d36abe32f2f","author":{"name":"Heejae Chang","email":"c0f22768d3a122cdeb61e07103a02d116ef5cdf0@microsoft.com"},"message":"made checksum tree builder to only use green node not only to cache but to build tree. this should prevent checksum builder to realize all red nodes for solution just to create checksum tree.\n\nthis change also include using specialized small dictionary to prevent creating more expensive dictionary.\n\nanother optimization can be done is moving checksum data into solution itself so we don't need to have side collections to map between solution green node to checksum node. but I will do that once I get to point where I do more aggressive perf optimizatino to reduce memory foot print if that is necessary","distinct":true,"url":"https://api.github.com/repos/brettfo/roslyn/commits/f024493b420189c817e8f1eabe730d36abe32f2f"},{"sha":"dd87f5082c596691214eaef37b445dbbfcdff801","author":{"name":"Tomáš Matoušek","email":"e773c3be1be7b8257fcad8f53007a8babef4bb63@users.noreply.github.com"},"message":"Fix loc files (#13232)","distinct":true,"url":"https://api.github.com/repos/brettfo/roslyn/commits/dd87f5082c596691214eaef37b445dbbfcdff801"},{"sha":"334e8097f06ddc98e460f5691d6b01ebe07f847f","author":{"name":"Tomáš Matoušek","email":"e773c3be1be7b8257fcad8f53007a8babef4bb63@users.noreply.github.com"},"message":"A couple of fixes to DevDivInsertionFiles (#13237)","distinct":true,"url":"https://api.github.com/repos/brettfo/roslyn/commits/334e8097f06ddc98e460f5691d6b01ebe07f847f"},{"sha":"8cc31fe512a47b055b34767e237837f4d832ea8d","author":{"name":"Heejae Chang","email":"c0f22768d3a122cdeb61e07103a02d116ef5cdf0@microsoft.com"},"message":"existing diagnostic tagger didn't check workspace diagnostics belong to before it removes them.\n\nthat caused host workspace's diagnostics to be removed when preview workspace's diagnostics are removed since two shared same documentId and projectId.\n\nthe code already had the logic to check what workspace the diagnostics belong to, it just happen to check that after removing diagnostics. fix is moving the checking before removing diagnostics.","distinct":true,"url":"https://api.github.com/repos/brettfo/roslyn/commits/8cc31fe512a47b055b34767e237837f4d832ea8d"},{"sha":"8e9028ea7569aa86f969ede574f4397ec9c090eb","author":{"name":"Heejae Chang","email":"c0f22768d3a122cdeb61e07103a02d116ef5cdf0@microsoft.com"},"message":"fixed race in analyzer driver\n\nhttp://source.roslyn.io/#Microsoft.CodeAnalysis/DiagnosticAnalyzer/AnalyzerDriver.cs,1699\n\nvar declarationAnalysisData = compilationData.GetOrComputeDeclarationAnalysisData(\ndecl,\nallocateData => ComputeDeclarationAnalysisData(symbol, decl, semanticModel, shouldExecuteSyntaxNodeActions, analysisScope, allocateData, cancellationToken),\ncacheAnalysisData);\n\nGetOrComputeDeclarationAnalysisData caches declarationAnalysisData only based on declaration, but the data it caches (DeclarationAnalysisData) depends on more context than declaration node. such as analysisScope. more specifically FilterSpanOpt or executeSyntaxNodeActions flag.\n\ndue to that, it now has a race where depends on what analyzer are loaded to VS first, some syntax node action works, or some other one doesn't.\n\nthe fix I made here is removing one of those context when caching the result","distinct":true,"url":"https://api.github.com/repos/brettfo/roslyn/commits/8e9028ea7569aa86f969ede574f4397ec9c090eb"},{"sha":"53339635b04e274748b7c537607e0c1de35200b1","author":{"name":"Heejae Chang","email":"c0f22768d3a122cdeb61e07103a02d116ef5cdf0@microsoft.com"},"message":"add more cancellation checking in LB code path.\n\ncode path where code fix uses didn't check cancellation itself but just pass it down to workspace/compiler. but that will make it to not cancel if all diagnostics are already calculated and cached. so it will always run to end and then right after that, code fix service will throw cancellation exception.\n\nby adding some cancellation here, we can prevent us from doing unnecessary work.","distinct":true,"url":"https://api.github.com/repos/brettfo/roslyn/commits/53339635b04e274748b7c537607e0c1de35200b1"},{"sha":"2d329f88b5d469aef749c3e94d5818207a12b7fe","author":{"name":"Heejae Chang","email":"c0f22768d3a122cdeb61e07103a02d116ef5cdf0@microsoft.com"},"message":"push file read to Background thread.\n\nthis should fix /workaround one particular case of dead lock but it won't fix the root cause of this where DispatcherSynchronizationContext Wait allowing re-enterance of COM call which, if re-entered code ever use Wait/Result, causes VS to dead lock.\n\nalternative to this fix is using Dispatcher.CurrentDispatcer.DisableProcessing(), but since workspace event is so busy code path, didn't want to play with global state (resource) all other people are using.","distinct":true,"url":"https://api.github.com/repos/brettfo/roslyn/commits/2d329f88b5d469aef749c3e94d5818207a12b7fe"},{"sha":"466b4f9876f7f8a26422fbca563d32b10712d48e","author":{"name":"Ty Overby","email":"d4b55a5f2f8b5aed5e8462f4e51304a51069cd0c@pre-alpha.com"},"message":"Add jenkins automation for perf testing (#12301)\n\n* test perf.groovy file\r\n\r\n* Pull down CPC\r\n\r\n* Changes machine pool name\r\n\r\n* Set env-variable for willow install\r\n\r\n* Generate PR job too\r\n\r\n* address feedback\r\n\r\n* Remove diagnostic\r\n\r\n* Correct regex","distinct":true,"url":"https://api.github.com/repos/brettfo/roslyn/commits/466b4f9876f7f8a26422fbca563d32b10712d48e"},{"sha":"4523b6727743c280c4938885f27275496fdae956","author":{"name":"Ty Overby","email":"d4b55a5f2f8b5aed5e8462f4e51304a51069cd0c@pre-alpha.com"},"message":"fix regex in perf.groovy","distinct":true,"url":"https://api.github.com/repos/brettfo/roslyn/commits/4523b6727743c280c4938885f27275496fdae956"},{"sha":"144c2882ce72f79ce59166ceff10df202d479195","author":{"name":"Dustin Campbell","email":"56b08fe8ce653d8a7a7096b8d075e915474fdbf3@teamcampbell.org"},"message":"Merge pull request #13230 from DustinCampbell/code-model-namespace-comments\n\nCode Model: Implement CodeNamespace.Comment and CodeNamespace.DocComment properties","distinct":true,"url":"https://api.github.com/repos/brettfo/roslyn/commits/144c2882ce72f79ce59166ceff10df202d479195"}]}
{"actor":{"display_login":"brettfo"}}