{"action":"created","comment":{"url":"https://api.github.com/repos/heroku/heroku-pg/pulls/comments/92662322","pull_request_review_id":13182279,"id":92662322,"diff_hunk":"@@ -30,6 +31,20 @@ function exec (cmd, opts = {}) {\n   }\n }\n \n+function spawn (cmd) {\n+  const {spawn} = require('child_process')\n+  return new Promise((resolve, reject) => {\n+    let result = ''\n+    let psql = spawn(cmd, [], {encoding: 'utf8', stdio: [ 'ignore', 'pipe', 'inherit' ], shell: true})\n+    psql.stdout.on('data', function (data) {\n+      result += data.toString()\n+    })\n+    psql.on('close', function (code) {","path":"commands/pull.js","position":20,"original_position":20,"commit_id":"d4b9c633041ca66bbcfa8bdc617c3414b32e5092","original_commit_id":"0bbeae349b5a0bca82d326921ccc2a728e7138fd","user":{"login":"dickeyxxx","id":216188,"avatar_url":"https://avatars.githubusercontent.com/u/216188?v=3","gravatar_id":"","url":"https://api.github.com/users/dickeyxxx","html_url":"https://github.com/dickeyxxx","followers_url":"https://api.github.com/users/dickeyxxx/followers","following_url":"https://api.github.com/users/dickeyxxx/following{/other_user}","gists_url":"https://api.github.com/users/dickeyxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/dickeyxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dickeyxxx/subscriptions","organizations_url":"https://api.github.com/users/dickeyxxx/orgs","repos_url":"https://api.github.com/users/dickeyxxx/repos","events_url":"https://api.github.com/users/dickeyxxx/events{/privacy}","received_events_url":"https://api.github.com/users/dickeyxxx/received_events","type":"User","site_admin":false},"body":"oh that's maybe ok. Not having matching extensions seems like more of a warning scenario than an error one. Especially since it errors on non-equal extensions, but if there are more extensions on the target that should be fine.","created_at":"2016-12-15T17:49:42Z","updated_at":"2016-12-15T17:49:42Z","html_url":"https://github.com/heroku/heroku-pg/pull/74#discussion_r92662322","pull_request_url":"https://api.github.com/repos/heroku/heroku-pg/pulls/74","_links":{"self":{"href":"https://api.github.com/repos/heroku/heroku-pg/pulls/comments/92662322"},"html":{"href":"https://github.com/heroku/heroku-pg/pull/74#discussion_r92662322"},"pull_request":{"href":"https://api.github.com/repos/heroku/heroku-pg/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/heroku/heroku-pg/pulls/74","id":98058124,"html_url":"https://github.com/heroku/heroku-pg/pull/74","diff_url":"https://github.com/heroku/heroku-pg/pull/74.diff","patch_url":"https://github.com/heroku/heroku-pg/pull/74.patch","issue_url":"https://api.github.com/repos/heroku/heroku-pg/issues/74","number":74,"state":"open","locked":false,"title":"Use bastions to tunnel in pg:pull & pg:push","user":{"login":"ransombriggs","id":62452,"avatar_url":"https://avatars.githubusercontent.com/u/62452?v=3","gravatar_id":"","url":"https://api.github.com/users/ransombriggs","html_url":"https://github.com/ransombriggs","followers_url":"https://api.github.com/users/ransombriggs/followers","following_url":"https://api.github.com/users/ransombriggs/following{/other_user}","gists_url":"https://api.github.com/users/ransombriggs/gists{/gist_id}","starred_url":"https://api.github.com/users/ransombriggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ransombriggs/subscriptions","organizations_url":"https://api.github.com/users/ransombriggs/orgs","repos_url":"https://api.github.com/users/ransombriggs/repos","events_url":"https://api.github.com/users/ransombriggs/events{/privacy}","received_events_url":"https://api.github.com/users/ransombriggs/received_events","type":"User","site_admin":false},"body":"@dickeyxxx was getting really close, but it still hangs.  See my debugging notes here, it appears that the tunnel is getting set up correctly, but that the command itself hangs for unknown reasons.  If you want the command we shell out and run it manually during that wait period it does return the expected output, not sure why it does not work through exec yet while psql seems to have no issues (although psql uses spawn and sets things up via environment variables passed down to spawn)\r\n\r\n[1ca782669f9fa62a1c35d472b142325f55bda222](https://github.com/heroku/heroku-pg/commit/1ca782669f9fa62a1c35d472b142325f55bda222#diff-caacc9db9d4fdff25c7eacfa9b8d4fdcR94)","created_at":"2016-12-14T23:29:06Z","updated_at":"2016-12-15T17:49:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5d93087180d278e686a1bdd46af1b522e6f5415","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/heroku/heroku-pg/pulls/74/commits","review_comments_url":"https://api.github.com/repos/heroku/heroku-pg/pulls/74/comments","review_comment_url":"https://api.github.com/repos/heroku/heroku-pg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heroku/heroku-pg/issues/74/comments","statuses_url":"https://api.github.com/repos/heroku/heroku-pg/statuses/d4b9c633041ca66bbcfa8bdc617c3414b32e5092","head":{"label":"heroku:fix-spaces-pg-pull","ref":"fix-spaces-pg-pull","sha":"d4b9c633041ca66bbcfa8bdc617c3414b32e5092","user":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=3","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"repo":{"id":53694724,"name":"heroku-pg","full_name":"heroku/heroku-pg","owner":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=3","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heroku/heroku-pg","description":"Heroku CLI Plugin for Heroku Postgres","fork":false,"url":"https://api.github.com/repos/heroku/heroku-pg","forks_url":"https://api.github.com/repos/heroku/heroku-pg/forks","keys_url":"https://api.github.com/repos/heroku/heroku-pg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heroku/heroku-pg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heroku/heroku-pg/teams","hooks_url":"https://api.github.com/repos/heroku/heroku-pg/hooks","issue_events_url":"https://api.github.com/repos/heroku/heroku-pg/issues/events{/number}","events_url":"https://api.github.com/repos/heroku/heroku-pg/events","assignees_url":"https://api.github.com/repos/heroku/heroku-pg/assignees{/user}","branches_url":"https://api.github.com/repos/heroku/heroku-pg/branches{/branch}","tags_url":"https://api.github.com/repos/heroku/heroku-pg/tags","blobs_url":"https://api.github.com/repos/heroku/heroku-pg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heroku/heroku-pg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heroku/heroku-pg/git/refs{/sha}","trees_url":"https://api.github.com/repos/heroku/heroku-pg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heroku/heroku-pg/statuses/{sha}","languages_url":"https://api.github.com/repos/heroku/heroku-pg/languages","stargazers_url":"https://api.github.com/repos/heroku/heroku-pg/stargazers","contributors_url":"https://api.github.com/repos/heroku/heroku-pg/contributors","subscribers_url":"https://api.github.com/repos/heroku/heroku-pg/subscribers","subscription_url":"https://api.github.com/repos/heroku/heroku-pg/subscription","commits_url":"https://api.github.com/repos/heroku/heroku-pg/commits{/sha}","git_commits_url":"https://api.github.com/repos/heroku/heroku-pg/git/commits{/sha}","comments_url":"https://api.github.com/repos/heroku/heroku-pg/comments{/number}","issue_comment_url":"https://api.github.com/repos/heroku/heroku-pg/issues/comments{/number}","contents_url":"https://api.github.com/repos/heroku/heroku-pg/contents/{+path}","compare_url":"https://api.github.com/repos/heroku/heroku-pg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heroku/heroku-pg/merges","archive_url":"https://api.github.com/repos/heroku/heroku-pg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heroku/heroku-pg/downloads","issues_url":"https://api.github.com/repos/heroku/heroku-pg/issues{/number}","pulls_url":"https://api.github.com/repos/heroku/heroku-pg/pulls{/number}","milestones_url":"https://api.github.com/repos/heroku/heroku-pg/milestones{/number}","notifications_url":"https://api.github.com/repos/heroku/heroku-pg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heroku/heroku-pg/labels{/name}","releases_url":"https://api.github.com/repos/heroku/heroku-pg/releases{/id}","deployments_url":"https://api.github.com/repos/heroku/heroku-pg/deployments","created_at":"2016-03-11T20:25:21Z","updated_at":"2016-12-13T19:31:28Z","pushed_at":"2016-12-15T17:45:54Z","git_url":"git://github.com/heroku/heroku-pg.git","ssh_url":"git@github.com:heroku/heroku-pg.git","clone_url":"https://github.com/heroku/heroku-pg.git","svn_url":"https://github.com/heroku/heroku-pg","homepage":"","size":150,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":9,"forks":1,"open_issues":9,"watchers":2,"default_branch":"master"}},"base":{"label":"heroku:master","ref":"master","sha":"1a286a745a3e478343e699cb685f91f7e5dc1814","user":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=3","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"repo":{"id":53694724,"name":"heroku-pg","full_name":"heroku/heroku-pg","owner":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=3","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heroku/heroku-pg","description":"Heroku CLI Plugin for Heroku Postgres","fork":false,"url":"https://api.github.com/repos/heroku/heroku-pg","forks_url":"https://api.github.com/repos/heroku/heroku-pg/forks","keys_url":"https://api.github.com/repos/heroku/heroku-pg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heroku/heroku-pg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heroku/heroku-pg/teams","hooks_url":"https://api.github.com/repos/heroku/heroku-pg/hooks","issue_events_url":"https://api.github.com/repos/heroku/heroku-pg/issues/events{/number}","events_url":"https://api.github.com/repos/heroku/heroku-pg/events","assignees_url":"https://api.github.com/repos/heroku/heroku-pg/assignees{/user}","branches_url":"https://api.github.com/repos/heroku/heroku-pg/branches{/branch}","tags_url":"https://api.github.com/repos/heroku/heroku-pg/tags","blobs_url":"https://api.github.com/repos/heroku/heroku-pg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heroku/heroku-pg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heroku/heroku-pg/git/refs{/sha}","trees_url":"https://api.github.com/repos/heroku/heroku-pg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heroku/heroku-pg/statuses/{sha}","languages_url":"https://api.github.com/repos/heroku/heroku-pg/languages","stargazers_url":"https://api.github.com/repos/heroku/heroku-pg/stargazers","contributors_url":"https://api.github.com/repos/heroku/heroku-pg/contributors","subscribers_url":"https://api.github.com/repos/heroku/heroku-pg/subscribers","subscription_url":"https://api.github.com/repos/heroku/heroku-pg/subscription","commits_url":"https://api.github.com/repos/heroku/heroku-pg/commits{/sha}","git_commits_url":"https://api.github.com/repos/heroku/heroku-pg/git/commits{/sha}","comments_url":"https://api.github.com/repos/heroku/heroku-pg/comments{/number}","issue_comment_url":"https://api.github.com/repos/heroku/heroku-pg/issues/comments{/number}","contents_url":"https://api.github.com/repos/heroku/heroku-pg/contents/{+path}","compare_url":"https://api.github.com/repos/heroku/heroku-pg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heroku/heroku-pg/merges","archive_url":"https://api.github.com/repos/heroku/heroku-pg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heroku/heroku-pg/downloads","issues_url":"https://api.github.com/repos/heroku/heroku-pg/issues{/number}","pulls_url":"https://api.github.com/repos/heroku/heroku-pg/pulls{/number}","milestones_url":"https://api.github.com/repos/heroku/heroku-pg/milestones{/number}","notifications_url":"https://api.github.com/repos/heroku/heroku-pg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heroku/heroku-pg/labels{/name}","releases_url":"https://api.github.com/repos/heroku/heroku-pg/releases{/id}","deployments_url":"https://api.github.com/repos/heroku/heroku-pg/deployments","created_at":"2016-03-11T20:25:21Z","updated_at":"2016-12-13T19:31:28Z","pushed_at":"2016-12-15T17:45:54Z","git_url":"git://github.com/heroku/heroku-pg.git","ssh_url":"git@github.com:heroku/heroku-pg.git","clone_url":"https://github.com/heroku/heroku-pg.git","svn_url":"https://github.com/heroku/heroku-pg","homepage":"","size":150,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":9,"forks":1,"open_issues":9,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heroku/heroku-pg/pulls/74"},"html":{"href":"https://github.com/heroku/heroku-pg/pull/74"},"issue":{"href":"https://api.github.com/repos/heroku/heroku-pg/issues/74"},"comments":{"href":"https://api.github.com/repos/heroku/heroku-pg/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/heroku/heroku-pg/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/heroku/heroku-pg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heroku/heroku-pg/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/heroku/heroku-pg/statuses/d4b9c633041ca66bbcfa8bdc617c3414b32e5092"}}}}
{"actor":{"display_login":"dickeyxxx"}}