{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/62710212","id":62710212,"diff_hunk":"@@ -294,6 +294,25 @@ def set_gecko_property(ffi_name, expr):\n <%call expr=\"impl_split_style_coord(ident, '%s.mUnit' % gecko_ffi_name, '%s.mValue' % gecko_ffi_name)\"></%call>\n </%def>\n \n+<%def name=\"impl_corner_style_coord(ident, x_unit_ffi_name, x_union_ffi_name, y_unit_ffi_name, y_union_ffi_name)\">\n+    fn set_${ident}(&mut self, v: longhands::${ident}::computed_value::T) {\n+        v.0.width.to_gecko_style_coord(&mut self.gecko.${x_unit_ffi_name},\n+                                       &mut self.gecko.${x_union_ffi_name});\n+        v.0.height.to_gecko_style_coord(&mut self.gecko.${y_unit_ffi_name},\n+                                        &mut self.gecko.${y_union_ffi_name});\n+    }\n+    fn copy_${ident}_from(&mut self, other: &Self) {\n+        use gecko_style_structs::nsStyleUnit::eStyleUnit_Calc;\n+        assert!(self.gecko.${x_unit_ffi_name} != eStyleUnit_Calc &&","path":"ports/geckolib/properties.mako.rs","position":13,"original_position":13,"commit_id":"1872fc9373b216d08f917e6d7909a020f533f0c1","original_commit_id":"5f6f32bb85d40b3a037d04b5fe66df6f9d628174","user":{"login":"bholley","id":377435,"avatar_url":"https://avatars.githubusercontent.com/u/377435?v=3","gravatar_id":"","url":"https://api.github.com/users/bholley","html_url":"https://github.com/bholley","followers_url":"https://api.github.com/users/bholley/followers","following_url":"https://api.github.com/users/bholley/following{/other_user}","gists_url":"https://api.github.com/users/bholley/gists{/gist_id}","starred_url":"https://api.github.com/users/bholley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bholley/subscriptions","organizations_url":"https://api.github.com/users/bholley/orgs","repos_url":"https://api.github.com/users/bholley/repos","events_url":"https://api.github.com/users/bholley/events{/privacy}","received_events_url":"https://api.github.com/users/bholley/received_events","type":"User","site_admin":false},"body":"And please also fix the one in impl_split_style_coord.","created_at":"2016-05-10T16:58:13Z","updated_at":"2016-05-10T16:58:13Z","html_url":"https://github.com/servo/servo/pull/11086#discussion_r62710212","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/11086","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/62710212"},"html":{"href":"https://github.com/servo/servo/pull/11086#discussion_r62710212"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/11086"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/11086","id":69288169,"html_url":"https://github.com/servo/servo/pull/11086","diff_url":"https://github.com/servo/servo/pull/11086.diff","patch_url":"https://github.com/servo/servo/pull/11086.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/11086","number":11086,"state":"open","locked":false,"title":"Support border/outline-radius properties in geckolib.","user":{"login":"heycam","id":1484434,"avatar_url":"https://avatars.githubusercontent.com/u/1484434?v=3","gravatar_id":"","url":"https://api.github.com/users/heycam","html_url":"https://github.com/heycam","followers_url":"https://api.github.com/users/heycam/followers","following_url":"https://api.github.com/users/heycam/following{/other_user}","gists_url":"https://api.github.com/users/heycam/gists{/gist_id}","starred_url":"https://api.github.com/users/heycam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heycam/subscriptions","organizations_url":"https://api.github.com/users/heycam/orgs","repos_url":"https://api.github.com/users/heycam/repos","events_url":"https://api.github.com/users/heycam/events{/privacy}","received_events_url":"https://api.github.com/users/heycam/received_events","type":"User","site_admin":false},"body":"<s>Because of the way Gecko stores outline-width in nsStyleOutline::mOutlineWidth (i.e., as its specified value for keywords) we need separate property implementations for servo/gecko products.</s>\r\n\r\nThe -moz-outline-radius parsing is a bit of a hack; I was just avoiding the effort of factoring out the parsing into a separate method. Let me know if I should do that.\r\n\r\n<s>Gecko-side changes are https://bugzilla.mozilla.org/show_bug.cgi?id=1271168.</s>\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/11086)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-05-09T02:11:25Z","updated_at":"2016-05-10T16:58:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e978b45dc0b7f4e9c018a68b68c1fecdb9ec9d84","assignee":{"login":"bholley","id":377435,"avatar_url":"https://avatars.githubusercontent.com/u/377435?v=3","gravatar_id":"","url":"https://api.github.com/users/bholley","html_url":"https://github.com/bholley","followers_url":"https://api.github.com/users/bholley/followers","following_url":"https://api.github.com/users/bholley/following{/other_user}","gists_url":"https://api.github.com/users/bholley/gists{/gist_id}","starred_url":"https://api.github.com/users/bholley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bholley/subscriptions","organizations_url":"https://api.github.com/users/bholley/orgs","repos_url":"https://api.github.com/users/bholley/repos","events_url":"https://api.github.com/users/bholley/events{/privacy}","received_events_url":"https://api.github.com/users/bholley/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/11086/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/11086/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/11086/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/1872fc9373b216d08f917e6d7909a020f533f0c1","head":{"label":"heycam:radius","ref":"radius","sha":"1872fc9373b216d08f917e6d7909a020f533f0c1","user":{"login":"heycam","id":1484434,"avatar_url":"https://avatars.githubusercontent.com/u/1484434?v=3","gravatar_id":"","url":"https://api.github.com/users/heycam","html_url":"https://github.com/heycam","followers_url":"https://api.github.com/users/heycam/followers","following_url":"https://api.github.com/users/heycam/following{/other_user}","gists_url":"https://api.github.com/users/heycam/gists{/gist_id}","starred_url":"https://api.github.com/users/heycam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heycam/subscriptions","organizations_url":"https://api.github.com/users/heycam/orgs","repos_url":"https://api.github.com/users/heycam/repos","events_url":"https://api.github.com/users/heycam/events{/privacy}","received_events_url":"https://api.github.com/users/heycam/received_events","type":"User","site_admin":false},"repo":{"id":49548345,"name":"servo","full_name":"heycam/servo","owner":{"login":"heycam","id":1484434,"avatar_url":"https://avatars.githubusercontent.com/u/1484434?v=3","gravatar_id":"","url":"https://api.github.com/users/heycam","html_url":"https://github.com/heycam","followers_url":"https://api.github.com/users/heycam/followers","following_url":"https://api.github.com/users/heycam/following{/other_user}","gists_url":"https://api.github.com/users/heycam/gists{/gist_id}","starred_url":"https://api.github.com/users/heycam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heycam/subscriptions","organizations_url":"https://api.github.com/users/heycam/orgs","repos_url":"https://api.github.com/users/heycam/repos","events_url":"https://api.github.com/users/heycam/events{/privacy}","received_events_url":"https://api.github.com/users/heycam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/heycam/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/heycam/servo","forks_url":"https://api.github.com/repos/heycam/servo/forks","keys_url":"https://api.github.com/repos/heycam/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heycam/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heycam/servo/teams","hooks_url":"https://api.github.com/repos/heycam/servo/hooks","issue_events_url":"https://api.github.com/repos/heycam/servo/issues/events{/number}","events_url":"https://api.github.com/repos/heycam/servo/events","assignees_url":"https://api.github.com/repos/heycam/servo/assignees{/user}","branches_url":"https://api.github.com/repos/heycam/servo/branches{/branch}","tags_url":"https://api.github.com/repos/heycam/servo/tags","blobs_url":"https://api.github.com/repos/heycam/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heycam/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heycam/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/heycam/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heycam/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/heycam/servo/languages","stargazers_url":"https://api.github.com/repos/heycam/servo/stargazers","contributors_url":"https://api.github.com/repos/heycam/servo/contributors","subscribers_url":"https://api.github.com/repos/heycam/servo/subscribers","subscription_url":"https://api.github.com/repos/heycam/servo/subscription","commits_url":"https://api.github.com/repos/heycam/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/heycam/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/heycam/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/heycam/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/heycam/servo/contents/{+path}","compare_url":"https://api.github.com/repos/heycam/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heycam/servo/merges","archive_url":"https://api.github.com/repos/heycam/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heycam/servo/downloads","issues_url":"https://api.github.com/repos/heycam/servo/issues{/number}","pulls_url":"https://api.github.com/repos/heycam/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/heycam/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/heycam/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heycam/servo/labels{/name}","releases_url":"https://api.github.com/repos/heycam/servo/releases{/id}","deployments_url":"https://api.github.com/repos/heycam/servo/deployments","created_at":"2016-01-13T04:03:14Z","updated_at":"2016-01-12T21:59:54Z","pushed_at":"2016-05-10T02:58:03Z","git_url":"git://github.com/heycam/servo.git","ssh_url":"git@github.com:heycam/servo.git","clone_url":"https://github.com/heycam/servo.git","svn_url":"https://github.com/heycam/servo","homepage":"http://servo.org/","size":182336,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"47c28586470982a3bc81d774cece3280ab692faa","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2016-05-10T15:45:36Z","pushed_at":"2016-05-10T16:29:52Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":242348,"stargazers_count":6661,"watchers_count":6661,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1095,"mirror_url":null,"open_issues_count":1467,"forks":1095,"open_issues":1467,"watchers":6661,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/11086"},"html":{"href":"https://github.com/servo/servo/pull/11086"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/11086"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/11086/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/11086/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/11086/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/1872fc9373b216d08f917e6d7909a020f533f0c1"}}}}