{"action":"closed","number":128,"pull_request":{"url":"https://api.github.com/repos/graphframes/graphframes/pulls/128","id":92691201,"html_url":"https://github.com/graphframes/graphframes/pull/128","diff_url":"https://github.com/graphframes/graphframes/pull/128.diff","patch_url":"https://github.com/graphframes/graphframes/pull/128.patch","issue_url":"https://api.github.com/repos/graphframes/graphframes/issues/128","number":128,"state":"closed","locked":false,"title":"use DecimalType for the sum in connected components","user":{"login":"mengxr","id":829644,"avatar_url":"https://avatars.githubusercontent.com/u/829644?v=3","gravatar_id":"","url":"https://api.github.com/users/mengxr","html_url":"https://github.com/mengxr","followers_url":"https://api.github.com/users/mengxr/followers","following_url":"https://api.github.com/users/mengxr/following{/other_user}","gists_url":"https://api.github.com/users/mengxr/gists{/gist_id}","starred_url":"https://api.github.com/users/mengxr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mengxr/subscriptions","organizations_url":"https://api.github.com/users/mengxr/orgs","repos_url":"https://api.github.com/users/mengxr/repos","events_url":"https://api.github.com/users/mengxr/events{/privacy}","received_events_url":"https://api.github.com/users/mengxr/received_events","type":"User","site_admin":false},"body":"This PR uses decimal type to compute the sum to avoid possible overflow issues. Note that even with long integer overflow, it is very unlikely to have `prevSum == currSum` happen before convergence. This PR just removed that possibility.\r\n\r\ncc: @jkbradley ","created_at":"2016-11-08T00:10:40Z","updated_at":"2016-11-09T03:38:25Z","closed_at":"2016-11-09T03:38:25Z","merged_at":"2016-11-09T03:38:25Z","merge_commit_sha":"29c27111a7608f42e7d0b5f8a22b1957a196d74e","assignee":{"login":"jkbradley","id":5084283,"avatar_url":"https://avatars.githubusercontent.com/u/5084283?v=3","gravatar_id":"","url":"https://api.github.com/users/jkbradley","html_url":"https://github.com/jkbradley","followers_url":"https://api.github.com/users/jkbradley/followers","following_url":"https://api.github.com/users/jkbradley/following{/other_user}","gists_url":"https://api.github.com/users/jkbradley/gists{/gist_id}","starred_url":"https://api.github.com/users/jkbradley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkbradley/subscriptions","organizations_url":"https://api.github.com/users/jkbradley/orgs","repos_url":"https://api.github.com/users/jkbradley/repos","events_url":"https://api.github.com/users/jkbradley/events{/privacy}","received_events_url":"https://api.github.com/users/jkbradley/received_events","type":"User","site_admin":false},"assignees":[{"login":"jkbradley","id":5084283,"avatar_url":"https://avatars.githubusercontent.com/u/5084283?v=3","gravatar_id":"","url":"https://api.github.com/users/jkbradley","html_url":"https://github.com/jkbradley","followers_url":"https://api.github.com/users/jkbradley/followers","following_url":"https://api.github.com/users/jkbradley/following{/other_user}","gists_url":"https://api.github.com/users/jkbradley/gists{/gist_id}","starred_url":"https://api.github.com/users/jkbradley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkbradley/subscriptions","organizations_url":"https://api.github.com/users/jkbradley/orgs","repos_url":"https://api.github.com/users/jkbradley/repos","events_url":"https://api.github.com/users/jkbradley/events{/privacy}","received_events_url":"https://api.github.com/users/jkbradley/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/graphframes/graphframes/pulls/128/commits","review_comments_url":"https://api.github.com/repos/graphframes/graphframes/pulls/128/comments","review_comment_url":"https://api.github.com/repos/graphframes/graphframes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graphframes/graphframes/issues/128/comments","statuses_url":"https://api.github.com/repos/graphframes/graphframes/statuses/d022bcf46926768ca62a558d9c1eec533ed4ee6b","head":{"label":"mengxr:cc-overflow","ref":"cc-overflow","sha":"d022bcf46926768ca62a558d9c1eec533ed4ee6b","user":{"login":"mengxr","id":829644,"avatar_url":"https://avatars.githubusercontent.com/u/829644?v=3","gravatar_id":"","url":"https://api.github.com/users/mengxr","html_url":"https://github.com/mengxr","followers_url":"https://api.github.com/users/mengxr/followers","following_url":"https://api.github.com/users/mengxr/following{/other_user}","gists_url":"https://api.github.com/users/mengxr/gists{/gist_id}","starred_url":"https://api.github.com/users/mengxr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mengxr/subscriptions","organizations_url":"https://api.github.com/users/mengxr/orgs","repos_url":"https://api.github.com/users/mengxr/repos","events_url":"https://api.github.com/users/mengxr/events{/privacy}","received_events_url":"https://api.github.com/users/mengxr/received_events","type":"User","site_admin":false},"repo":{"id":52120354,"name":"graphframes","full_name":"mengxr/graphframes","owner":{"login":"mengxr","id":829644,"avatar_url":"https://avatars.githubusercontent.com/u/829644?v=3","gravatar_id":"","url":"https://api.github.com/users/mengxr","html_url":"https://github.com/mengxr","followers_url":"https://api.github.com/users/mengxr/followers","following_url":"https://api.github.com/users/mengxr/following{/other_user}","gists_url":"https://api.github.com/users/mengxr/gists{/gist_id}","starred_url":"https://api.github.com/users/mengxr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mengxr/subscriptions","organizations_url":"https://api.github.com/users/mengxr/orgs","repos_url":"https://api.github.com/users/mengxr/repos","events_url":"https://api.github.com/users/mengxr/events{/privacy}","received_events_url":"https://api.github.com/users/mengxr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mengxr/graphframes","description":null,"fork":true,"url":"https://api.github.com/repos/mengxr/graphframes","forks_url":"https://api.github.com/repos/mengxr/graphframes/forks","keys_url":"https://api.github.com/repos/mengxr/graphframes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mengxr/graphframes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mengxr/graphframes/teams","hooks_url":"https://api.github.com/repos/mengxr/graphframes/hooks","issue_events_url":"https://api.github.com/repos/mengxr/graphframes/issues/events{/number}","events_url":"https://api.github.com/repos/mengxr/graphframes/events","assignees_url":"https://api.github.com/repos/mengxr/graphframes/assignees{/user}","branches_url":"https://api.github.com/repos/mengxr/graphframes/branches{/branch}","tags_url":"https://api.github.com/repos/mengxr/graphframes/tags","blobs_url":"https://api.github.com/repos/mengxr/graphframes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mengxr/graphframes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mengxr/graphframes/git/refs{/sha}","trees_url":"https://api.github.com/repos/mengxr/graphframes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mengxr/graphframes/statuses/{sha}","languages_url":"https://api.github.com/repos/mengxr/graphframes/languages","stargazers_url":"https://api.github.com/repos/mengxr/graphframes/stargazers","contributors_url":"https://api.github.com/repos/mengxr/graphframes/contributors","subscribers_url":"https://api.github.com/repos/mengxr/graphframes/subscribers","subscription_url":"https://api.github.com/repos/mengxr/graphframes/subscription","commits_url":"https://api.github.com/repos/mengxr/graphframes/commits{/sha}","git_commits_url":"https://api.github.com/repos/mengxr/graphframes/git/commits{/sha}","comments_url":"https://api.github.com/repos/mengxr/graphframes/comments{/number}","issue_comment_url":"https://api.github.com/repos/mengxr/graphframes/issues/comments{/number}","contents_url":"https://api.github.com/repos/mengxr/graphframes/contents/{+path}","compare_url":"https://api.github.com/repos/mengxr/graphframes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mengxr/graphframes/merges","archive_url":"https://api.github.com/repos/mengxr/graphframes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mengxr/graphframes/downloads","issues_url":"https://api.github.com/repos/mengxr/graphframes/issues{/number}","pulls_url":"https://api.github.com/repos/mengxr/graphframes/pulls{/number}","milestones_url":"https://api.github.com/repos/mengxr/graphframes/milestones{/number}","notifications_url":"https://api.github.com/repos/mengxr/graphframes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mengxr/graphframes/labels{/name}","releases_url":"https://api.github.com/repos/mengxr/graphframes/releases{/id}","deployments_url":"https://api.github.com/repos/mengxr/graphframes/deployments","created_at":"2016-02-19T22:21:39Z","updated_at":"2016-02-19T22:21:41Z","pushed_at":"2016-11-09T03:09:06Z","git_url":"git://github.com/mengxr/graphframes.git","ssh_url":"git@github.com:mengxr/graphframes.git","clone_url":"https://github.com/mengxr/graphframes.git","svn_url":"https://github.com/mengxr/graphframes","homepage":null,"size":702,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"graphframes:master","ref":"master","sha":"3ca57b38e9f2ead71e24e42abc84f3ba558d2b38","user":{"login":"graphframes","id":16808115,"avatar_url":"https://avatars.githubusercontent.com/u/16808115?v=3","gravatar_id":"","url":"https://api.github.com/users/graphframes","html_url":"https://github.com/graphframes","followers_url":"https://api.github.com/users/graphframes/followers","following_url":"https://api.github.com/users/graphframes/following{/other_user}","gists_url":"https://api.github.com/users/graphframes/gists{/gist_id}","starred_url":"https://api.github.com/users/graphframes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphframes/subscriptions","organizations_url":"https://api.github.com/users/graphframes/orgs","repos_url":"https://api.github.com/users/graphframes/repos","events_url":"https://api.github.com/users/graphframes/events{/privacy}","received_events_url":"https://api.github.com/users/graphframes/received_events","type":"Organization","site_admin":false},"repo":{"id":50067430,"name":"graphframes","full_name":"graphframes/graphframes","owner":{"login":"graphframes","id":16808115,"avatar_url":"https://avatars.githubusercontent.com/u/16808115?v=3","gravatar_id":"","url":"https://api.github.com/users/graphframes","html_url":"https://github.com/graphframes","followers_url":"https://api.github.com/users/graphframes/followers","following_url":"https://api.github.com/users/graphframes/following{/other_user}","gists_url":"https://api.github.com/users/graphframes/gists{/gist_id}","starred_url":"https://api.github.com/users/graphframes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphframes/subscriptions","organizations_url":"https://api.github.com/users/graphframes/orgs","repos_url":"https://api.github.com/users/graphframes/repos","events_url":"https://api.github.com/users/graphframes/events{/privacy}","received_events_url":"https://api.github.com/users/graphframes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graphframes/graphframes","description":null,"fork":false,"url":"https://api.github.com/repos/graphframes/graphframes","forks_url":"https://api.github.com/repos/graphframes/graphframes/forks","keys_url":"https://api.github.com/repos/graphframes/graphframes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graphframes/graphframes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graphframes/graphframes/teams","hooks_url":"https://api.github.com/repos/graphframes/graphframes/hooks","issue_events_url":"https://api.github.com/repos/graphframes/graphframes/issues/events{/number}","events_url":"https://api.github.com/repos/graphframes/graphframes/events","assignees_url":"https://api.github.com/repos/graphframes/graphframes/assignees{/user}","branches_url":"https://api.github.com/repos/graphframes/graphframes/branches{/branch}","tags_url":"https://api.github.com/repos/graphframes/graphframes/tags","blobs_url":"https://api.github.com/repos/graphframes/graphframes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graphframes/graphframes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graphframes/graphframes/git/refs{/sha}","trees_url":"https://api.github.com/repos/graphframes/graphframes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graphframes/graphframes/statuses/{sha}","languages_url":"https://api.github.com/repos/graphframes/graphframes/languages","stargazers_url":"https://api.github.com/repos/graphframes/graphframes/stargazers","contributors_url":"https://api.github.com/repos/graphframes/graphframes/contributors","subscribers_url":"https://api.github.com/repos/graphframes/graphframes/subscribers","subscription_url":"https://api.github.com/repos/graphframes/graphframes/subscription","commits_url":"https://api.github.com/repos/graphframes/graphframes/commits{/sha}","git_commits_url":"https://api.github.com/repos/graphframes/graphframes/git/commits{/sha}","comments_url":"https://api.github.com/repos/graphframes/graphframes/comments{/number}","issue_comment_url":"https://api.github.com/repos/graphframes/graphframes/issues/comments{/number}","contents_url":"https://api.github.com/repos/graphframes/graphframes/contents/{+path}","compare_url":"https://api.github.com/repos/graphframes/graphframes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graphframes/graphframes/merges","archive_url":"https://api.github.com/repos/graphframes/graphframes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graphframes/graphframes/downloads","issues_url":"https://api.github.com/repos/graphframes/graphframes/issues{/number}","pulls_url":"https://api.github.com/repos/graphframes/graphframes/pulls{/number}","milestones_url":"https://api.github.com/repos/graphframes/graphframes/milestones{/number}","notifications_url":"https://api.github.com/repos/graphframes/graphframes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graphframes/graphframes/labels{/name}","releases_url":"https://api.github.com/repos/graphframes/graphframes/releases{/id}","deployments_url":"https://api.github.com/repos/graphframes/graphframes/deployments","created_at":"2016-01-20T23:17:56Z","updated_at":"2016-11-08T19:43:54Z","pushed_at":"2016-11-09T03:38:25Z","git_url":"git://github.com/graphframes/graphframes.git","ssh_url":"git@github.com:graphframes/graphframes.git","clone_url":"https://github.com/graphframes/graphframes.git","svn_url":"https://github.com/graphframes/graphframes","homepage":"http://graphframes.github.io/","size":831,"stargazers_count":174,"watchers_count":174,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":31,"forks":56,"open_issues":31,"watchers":174,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graphframes/graphframes/pulls/128"},"html":{"href":"https://github.com/graphframes/graphframes/pull/128"},"issue":{"href":"https://api.github.com/repos/graphframes/graphframes/issues/128"},"comments":{"href":"https://api.github.com/repos/graphframes/graphframes/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/graphframes/graphframes/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/graphframes/graphframes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graphframes/graphframes/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/graphframes/graphframes/statuses/d022bcf46926768ca62a558d9c1eec533ed4ee6b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jkbradley","id":5084283,"avatar_url":"https://avatars.githubusercontent.com/u/5084283?v=3","gravatar_id":"","url":"https://api.github.com/users/jkbradley","html_url":"https://github.com/jkbradley","followers_url":"https://api.github.com/users/jkbradley/followers","following_url":"https://api.github.com/users/jkbradley/following{/other_user}","gists_url":"https://api.github.com/users/jkbradley/gists{/gist_id}","starred_url":"https://api.github.com/users/jkbradley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkbradley/subscriptions","organizations_url":"https://api.github.com/users/jkbradley/orgs","repos_url":"https://api.github.com/users/jkbradley/repos","events_url":"https://api.github.com/users/jkbradley/events{/privacy}","received_events_url":"https://api.github.com/users/jkbradley/received_events","type":"User","site_admin":false},"comments":1,"review_comments":6,"commits":3,"additions":34,"deletions":10,"changed_files":2}}
{"actor":{"display_login":"jkbradley"}}