{"action":"created","issue":{"url":"https://api.github.com/repos/timber/timber/issues/990","repository_url":"https://api.github.com/repos/timber/timber","labels_url":"https://api.github.com/repos/timber/timber/issues/990/labels{/name}","comments_url":"https://api.github.com/repos/timber/timber/issues/990/comments","events_url":"https://api.github.com/repos/timber/timber/issues/990/events","html_url":"https://github.com/timber/timber/pull/990","id":154137700,"number":990,"title":"Comment form redux1","user":{"login":"jarednova","id":1298086,"avatar_url":"https://avatars.githubusercontent.com/u/1298086?v=3","gravatar_id":"","url":"https://api.github.com/users/jarednova","html_url":"https://github.com/jarednova","followers_url":"https://api.github.com/users/jarednova/followers","following_url":"https://api.github.com/users/jarednova/following{/other_user}","gists_url":"https://api.github.com/users/jarednova/gists{/gist_id}","starred_url":"https://api.github.com/users/jarednova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarednova/subscriptions","organizations_url":"https://api.github.com/users/jarednova/orgs","repos_url":"https://api.github.com/users/jarednova/repos","events_url":"https://api.github.com/users/jarednova/events{/privacy}","received_events_url":"https://api.github.com/users/jarednova/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"connorjburton","id":10538031,"avatar_url":"https://avatars.githubusercontent.com/u/10538031?v=3","gravatar_id":"","url":"https://api.github.com/users/connorjburton","html_url":"https://github.com/connorjburton","followers_url":"https://api.github.com/users/connorjburton/followers","following_url":"https://api.github.com/users/connorjburton/following{/other_user}","gists_url":"https://api.github.com/users/connorjburton/gists{/gist_id}","starred_url":"https://api.github.com/users/connorjburton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connorjburton/subscriptions","organizations_url":"https://api.github.com/users/connorjburton/orgs","repos_url":"https://api.github.com/users/connorjburton/repos","events_url":"https://api.github.com/users/connorjburton/events{/privacy}","received_events_url":"https://api.github.com/users/connorjburton/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2016-05-11T00:45:45Z","updated_at":"2016-05-11T08:21:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/timber/timber/pulls/990","html_url":"https://github.com/timber/timber/pull/990","diff_url":"https://github.com/timber/timber/pull/990.diff","patch_url":"https://github.com/timber/timber/pull/990.patch"},"body":"**Reviewer**: @connorjburton \r\n\r\n#### Issue\r\nMany people (especially on the WordPress.org forums) have reported problems with the deprecated `TimberHelper::get_comment_form` function. Well of course they have, it was removed!\r\n\r\nhttps://wordpress.org/support/topic/fatal-error-class-not-found-in-101?replies=2\r\nhttps://wordpress.org/support/topic/get_comment_form-returns-empty?replies=4\r\n\r\n... that said, the problem they're running into isn't entirely of their making. The `single.php` file in the Starter Theme had a call to `TimberHelper::get_comment_form` that I'm sure many developers left in w/o realizing what it was doing. I'd like to reduce 1.0 pain as much as possible\r\n\r\n#### Solution\r\nRestore the `Helper::get_comment_form` method (for now). But introduce a better method through `{{ post.comment_form }}` for folks to use.\r\n\r\n#### Impact\r\nA little extra code\r\n\r\n#### Usage\r\nWe should update elements of the Starter Theme to use `{{ post.comment_form }}`\r\n\r\n#### Considerations\r\nI don't like the idea of a Timber object method returning HTML. But I also sympathize that hand-building a comment form's HTML is no one's idea of a good time.\r\n\r\n#### Testing\r\nUnit tests included!"},"comment":{"url":"https://api.github.com/repos/timber/timber/issues/comments/218393413","html_url":"https://github.com/timber/timber/pull/990#issuecomment-218393413","issue_url":"https://api.github.com/repos/timber/timber/issues/990","id":218393413,"user":{"login":"connorjburton","id":10538031,"avatar_url":"https://avatars.githubusercontent.com/u/10538031?v=3","gravatar_id":"","url":"https://api.github.com/users/connorjburton","html_url":"https://github.com/connorjburton","followers_url":"https://api.github.com/users/connorjburton/followers","following_url":"https://api.github.com/users/connorjburton/following{/other_user}","gists_url":"https://api.github.com/users/connorjburton/gists{/gist_id}","starred_url":"https://api.github.com/users/connorjburton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connorjburton/subscriptions","organizations_url":"https://api.github.com/users/connorjburton/orgs","repos_url":"https://api.github.com/users/connorjburton/repos","events_url":"https://api.github.com/users/connorjburton/events{/privacy}","received_events_url":"https://api.github.com/users/connorjburton/received_events","type":"User","site_admin":false},"created_at":"2016-05-11T08:21:41Z","updated_at":"2016-05-11T08:21:41Z","body":"Yes I agree, this is probably the biggest issue I have seen with upgrades. Would this be the final version of this, or are you thinking of developing it further (other than removing the deprecated version eventually)."}}