{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-systemml/issues/105","repository_url":"https://api.github.com/repos/apache/incubator-systemml","labels_url":"https://api.github.com/repos/apache/incubator-systemml/issues/105/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-systemml/issues/105/comments","events_url":"https://api.github.com/repos/apache/incubator-systemml/issues/105/events","html_url":"https://github.com/apache/incubator-systemml/pull/105","id":146461234,"number":105,"title":"[SYSTEMML-617] Override default namespace for imported custom functions","user":{"login":"gweidner","id":12058879,"avatar_url":"https://avatars.githubusercontent.com/u/12058879?v=3","gravatar_id":"","url":"https://api.github.com/users/gweidner","html_url":"https://github.com/gweidner","followers_url":"https://api.github.com/users/gweidner/followers","following_url":"https://api.github.com/users/gweidner/following{/other_user}","gists_url":"https://api.github.com/users/gweidner/gists{/gist_id}","starred_url":"https://api.github.com/users/gweidner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gweidner/subscriptions","organizations_url":"https://api.github.com/users/gweidner/orgs","repos_url":"https://api.github.com/users/gweidner/repos","events_url":"https://api.github.com/users/gweidner/events{/privacy}","received_events_url":"https://api.github.com/users/gweidner/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-04-06T23:08:22Z","updated_at":"2016-04-09T00:21:46Z","closed_at":"2016-04-09T00:21:23Z","pull_request":{"url":"https://api.github.com/repos/apache/incubator-systemml/pulls/105","html_url":"https://github.com/apache/incubator-systemml/pull/105","diff_url":"https://github.com/apache/incubator-systemml/pull/105.diff","patch_url":"https://github.com/apache/incubator-systemml/pull/105.patch"},"body":"This patch with dml/pydml tests is intended to incrementally improve namespace handling to facilitate defining and reusing functions across multiple scripts.  It includes isolated changes to target a specific scenario where dependent functions (e.g., function1 internally calls function2 defined in same script) but are also imported by another script.  The change to StatementBlock was not required but included to help compare blocks when inspecting variables under IDE debugger.\r\nPrior to this patch, the internal call would fail as described in [SYSTEMML-590] which is covered under 'testFunctionSourceNS'.  The other 2 tests were included to show this patch does not change expected behavior where imported custom function was not fully qualified (testFunctionWithoutNS) and internal custom function call without namespace ok when run directly (testFunctionDefaultNS).\r\nA few built-in functions were also ran to verify built-ins still found in defaultns.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/apache/incubator-systemml/issues/comments/207661077","html_url":"https://github.com/apache/incubator-systemml/pull/105#issuecomment-207661077","issue_url":"https://api.github.com/repos/apache/incubator-systemml/issues/105","id":207661077,"user":{"login":"dusenberrymw","id":5431337,"avatar_url":"https://avatars.githubusercontent.com/u/5431337?v=3","gravatar_id":"","url":"https://api.github.com/users/dusenberrymw","html_url":"https://github.com/dusenberrymw","followers_url":"https://api.github.com/users/dusenberrymw/followers","following_url":"https://api.github.com/users/dusenberrymw/following{/other_user}","gists_url":"https://api.github.com/users/dusenberrymw/gists{/gist_id}","starred_url":"https://api.github.com/users/dusenberrymw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dusenberrymw/subscriptions","organizations_url":"https://api.github.com/users/dusenberrymw/orgs","repos_url":"https://api.github.com/users/dusenberrymw/repos","events_url":"https://api.github.com/users/dusenberrymw/events{/privacy}","received_events_url":"https://api.github.com/users/dusenberrymw/received_events","type":"User","site_admin":false},"created_at":"2016-04-09T00:21:46Z","updated_at":"2016-04-09T00:21:46Z","body":"Merged. Thanks @gweidner!"}}