{"action":"reopened","number":2307,"pull_request":{"url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls/2307","id":27154277,"html_url":"https://github.com/unknown-horizons/unknown-horizons/pull/2307","diff_url":"https://github.com/unknown-horizons/unknown-horizons/pull/2307.diff","patch_url":"https://github.com/unknown-horizons/unknown-horizons/pull/2307.patch","issue_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues/2307","number":2307,"state":"open","locked":false,"title":"Issue 1688 [NEED TO BE FIXED]","user":{"login":"qsorix","id":224864,"avatar_url":"https://avatars.githubusercontent.com/u/224864?v=3","gravatar_id":"","url":"https://api.github.com/users/qsorix","html_url":"https://github.com/qsorix","followers_url":"https://api.github.com/users/qsorix/followers","following_url":"https://api.github.com/users/qsorix/following{/other_user}","gists_url":"https://api.github.com/users/qsorix/gists{/gist_id}","starred_url":"https://api.github.com/users/qsorix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qsorix/subscriptions","organizations_url":"https://api.github.com/users/qsorix/orgs","repos_url":"https://api.github.com/users/qsorix/repos","events_url":"https://api.github.com/users/qsorix/events{/privacy}","received_events_url":"https://api.github.com/users/qsorix/received_events","type":"User","site_admin":false},"body":"My attempt at 3 out of 4 problems mentioned in #1688. I left auto-enabling out as I don't agree with this suggestion.\r\n\r\nThe dialog looks like this after my changes\r\nhttp://up.unknown-horizons.org/f/?id=692&n=traderoute.png\r\n\r\nI'm happy to improve the code. If you don't like something, please do tell me.","created_at":"2015-01-10T20:42:37Z","updated_at":"2016-10-16T16:49:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0e5b0a8658ddb29bb644fe3b261539fca366e86","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/milestones/21","html_url":"https://github.com/unknown-horizons/unknown-horizons/milestones/next","labels_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/milestones/21/labels","id":1430156,"number":21,"title":"next","description":"","creator":{"login":"LinuxDonald","id":1757651,"avatar_url":"https://avatars.githubusercontent.com/u/1757651?v=3","gravatar_id":"","url":"https://api.github.com/users/LinuxDonald","html_url":"https://github.com/LinuxDonald","followers_url":"https://api.github.com/users/LinuxDonald/followers","following_url":"https://api.github.com/users/LinuxDonald/following{/other_user}","gists_url":"https://api.github.com/users/LinuxDonald/gists{/gist_id}","starred_url":"https://api.github.com/users/LinuxDonald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LinuxDonald/subscriptions","organizations_url":"https://api.github.com/users/LinuxDonald/orgs","repos_url":"https://api.github.com/users/LinuxDonald/repos","events_url":"https://api.github.com/users/LinuxDonald/events{/privacy}","received_events_url":"https://api.github.com/users/LinuxDonald/received_events","type":"User","site_admin":false},"open_issues":42,"closed_issues":13,"state":"open","created_at":"2015-11-25T22:26:29Z","updated_at":"2016-10-16T16:49:44Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls/2307/commits","review_comments_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls/2307/comments","review_comment_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues/2307/comments","statuses_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/statuses/7f7dcff6fa55694a94587d42227992903b5e5a5c","head":{"label":"qsorix:issue_1688","ref":"issue_1688","sha":"7f7dcff6fa55694a94587d42227992903b5e5a5c","user":{"login":"qsorix","id":224864,"avatar_url":"https://avatars.githubusercontent.com/u/224864?v=3","gravatar_id":"","url":"https://api.github.com/users/qsorix","html_url":"https://github.com/qsorix","followers_url":"https://api.github.com/users/qsorix/followers","following_url":"https://api.github.com/users/qsorix/following{/other_user}","gists_url":"https://api.github.com/users/qsorix/gists{/gist_id}","starred_url":"https://api.github.com/users/qsorix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qsorix/subscriptions","organizations_url":"https://api.github.com/users/qsorix/orgs","repos_url":"https://api.github.com/users/qsorix/repos","events_url":"https://api.github.com/users/qsorix/events{/privacy}","received_events_url":"https://api.github.com/users/qsorix/received_events","type":"User","site_admin":false},"repo":{"id":28882971,"name":"unknown-horizons","full_name":"qsorix/unknown-horizons","owner":{"login":"qsorix","id":224864,"avatar_url":"https://avatars.githubusercontent.com/u/224864?v=3","gravatar_id":"","url":"https://api.github.com/users/qsorix","html_url":"https://github.com/qsorix","followers_url":"https://api.github.com/users/qsorix/followers","following_url":"https://api.github.com/users/qsorix/following{/other_user}","gists_url":"https://api.github.com/users/qsorix/gists{/gist_id}","starred_url":"https://api.github.com/users/qsorix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qsorix/subscriptions","organizations_url":"https://api.github.com/users/qsorix/orgs","repos_url":"https://api.github.com/users/qsorix/repos","events_url":"https://api.github.com/users/qsorix/events{/privacy}","received_events_url":"https://api.github.com/users/qsorix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qsorix/unknown-horizons","description":"Unknown Horizons official code repository","fork":true,"url":"https://api.github.com/repos/qsorix/unknown-horizons","forks_url":"https://api.github.com/repos/qsorix/unknown-horizons/forks","keys_url":"https://api.github.com/repos/qsorix/unknown-horizons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qsorix/unknown-horizons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qsorix/unknown-horizons/teams","hooks_url":"https://api.github.com/repos/qsorix/unknown-horizons/hooks","issue_events_url":"https://api.github.com/repos/qsorix/unknown-horizons/issues/events{/number}","events_url":"https://api.github.com/repos/qsorix/unknown-horizons/events","assignees_url":"https://api.github.com/repos/qsorix/unknown-horizons/assignees{/user}","branches_url":"https://api.github.com/repos/qsorix/unknown-horizons/branches{/branch}","tags_url":"https://api.github.com/repos/qsorix/unknown-horizons/tags","blobs_url":"https://api.github.com/repos/qsorix/unknown-horizons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qsorix/unknown-horizons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qsorix/unknown-horizons/git/refs{/sha}","trees_url":"https://api.github.com/repos/qsorix/unknown-horizons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qsorix/unknown-horizons/statuses/{sha}","languages_url":"https://api.github.com/repos/qsorix/unknown-horizons/languages","stargazers_url":"https://api.github.com/repos/qsorix/unknown-horizons/stargazers","contributors_url":"https://api.github.com/repos/qsorix/unknown-horizons/contributors","subscribers_url":"https://api.github.com/repos/qsorix/unknown-horizons/subscribers","subscription_url":"https://api.github.com/repos/qsorix/unknown-horizons/subscription","commits_url":"https://api.github.com/repos/qsorix/unknown-horizons/commits{/sha}","git_commits_url":"https://api.github.com/repos/qsorix/unknown-horizons/git/commits{/sha}","comments_url":"https://api.github.com/repos/qsorix/unknown-horizons/comments{/number}","issue_comment_url":"https://api.github.com/repos/qsorix/unknown-horizons/issues/comments{/number}","contents_url":"https://api.github.com/repos/qsorix/unknown-horizons/contents/{+path}","compare_url":"https://api.github.com/repos/qsorix/unknown-horizons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qsorix/unknown-horizons/merges","archive_url":"https://api.github.com/repos/qsorix/unknown-horizons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qsorix/unknown-horizons/downloads","issues_url":"https://api.github.com/repos/qsorix/unknown-horizons/issues{/number}","pulls_url":"https://api.github.com/repos/qsorix/unknown-horizons/pulls{/number}","milestones_url":"https://api.github.com/repos/qsorix/unknown-horizons/milestones{/number}","notifications_url":"https://api.github.com/repos/qsorix/unknown-horizons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qsorix/unknown-horizons/labels{/name}","releases_url":"https://api.github.com/repos/qsorix/unknown-horizons/releases{/id}","deployments_url":"https://api.github.com/repos/qsorix/unknown-horizons/deployments","created_at":"2015-01-06T20:52:10Z","updated_at":"2015-01-06T20:52:17Z","pushed_at":"2015-01-11T18:07:17Z","git_url":"git://github.com/qsorix/unknown-horizons.git","ssh_url":"git@github.com:qsorix/unknown-horizons.git","clone_url":"https://github.com/qsorix/unknown-horizons.git","svn_url":"https://github.com/qsorix/unknown-horizons","homepage":"http://www.unknown-horizons.org","size":355409,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"unknown-horizons:master","ref":"master","sha":"a7d1464efc934bd4dd52517f59bd21920bd9adfb","user":{"login":"unknown-horizons","id":372796,"avatar_url":"https://avatars.githubusercontent.com/u/372796?v=3","gravatar_id":"","url":"https://api.github.com/users/unknown-horizons","html_url":"https://github.com/unknown-horizons","followers_url":"https://api.github.com/users/unknown-horizons/followers","following_url":"https://api.github.com/users/unknown-horizons/following{/other_user}","gists_url":"https://api.github.com/users/unknown-horizons/gists{/gist_id}","starred_url":"https://api.github.com/users/unknown-horizons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unknown-horizons/subscriptions","organizations_url":"https://api.github.com/users/unknown-horizons/orgs","repos_url":"https://api.github.com/users/unknown-horizons/repos","events_url":"https://api.github.com/users/unknown-horizons/events{/privacy}","received_events_url":"https://api.github.com/users/unknown-horizons/received_events","type":"Organization","site_admin":false},"repo":{"id":856193,"name":"unknown-horizons","full_name":"unknown-horizons/unknown-horizons","owner":{"login":"unknown-horizons","id":372796,"avatar_url":"https://avatars.githubusercontent.com/u/372796?v=3","gravatar_id":"","url":"https://api.github.com/users/unknown-horizons","html_url":"https://github.com/unknown-horizons","followers_url":"https://api.github.com/users/unknown-horizons/followers","following_url":"https://api.github.com/users/unknown-horizons/following{/other_user}","gists_url":"https://api.github.com/users/unknown-horizons/gists{/gist_id}","starred_url":"https://api.github.com/users/unknown-horizons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unknown-horizons/subscriptions","organizations_url":"https://api.github.com/users/unknown-horizons/orgs","repos_url":"https://api.github.com/users/unknown-horizons/repos","events_url":"https://api.github.com/users/unknown-horizons/events{/privacy}","received_events_url":"https://api.github.com/users/unknown-horizons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unknown-horizons/unknown-horizons","description":"Unknown Horizons official code repository","fork":false,"url":"https://api.github.com/repos/unknown-horizons/unknown-horizons","forks_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/forks","keys_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/teams","hooks_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/hooks","issue_events_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues/events{/number}","events_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/events","assignees_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/assignees{/user}","branches_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/branches{/branch}","tags_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/tags","blobs_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/git/refs{/sha}","trees_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/statuses/{sha}","languages_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/languages","stargazers_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/stargazers","contributors_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/contributors","subscribers_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/subscribers","subscription_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/subscription","commits_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/commits{/sha}","git_commits_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/git/commits{/sha}","comments_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/comments{/number}","issue_comment_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues/comments{/number}","contents_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/contents/{+path}","compare_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/merges","archive_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/downloads","issues_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues{/number}","pulls_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls{/number}","milestones_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/milestones{/number}","notifications_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/labels{/name}","releases_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/releases{/id}","deployments_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/deployments","created_at":"2010-08-23T08:48:29Z","updated_at":"2016-10-16T13:11:29Z","pushed_at":"2016-10-16T16:46:13Z","git_url":"git://github.com/unknown-horizons/unknown-horizons.git","ssh_url":"git@github.com:unknown-horizons/unknown-horizons.git","clone_url":"https://github.com/unknown-horizons/unknown-horizons.git","svn_url":"https://github.com/unknown-horizons/unknown-horizons","homepage":"http://www.unknown-horizons.org","size":524404,"stargazers_count":342,"watchers_count":342,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":126,"mirror_url":null,"open_issues_count":258,"forks":126,"open_issues":258,"watchers":342,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls/2307"},"html":{"href":"https://github.com/unknown-horizons/unknown-horizons/pull/2307"},"issue":{"href":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues/2307"},"comments":{"href":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues/2307/comments"},"review_comments":{"href":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls/2307/comments"},"review_comment":{"href":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unknown-horizons/unknown-horizons/pulls/2307/commits"},"statuses":{"href":"https://api.github.com/repos/unknown-horizons/unknown-horizons/statuses/7f7dcff6fa55694a94587d42227992903b5e5a5c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":10,"review_comments":0,"commits":3,"additions":170,"deletions":35,"changed_files":8}}
{"actor":{"display_login":"LinuxDonald"}}