{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments/90651129","pull_request_review_id":11170197,"id":90651129,"diff_hunk":"@@ -15,6 +15,24 @@ spec:\n         imagePullPolicy: Always\n         ports:\n         - containerPort: 10000\n+        livenessProbe:\n+          httpGet:\n+            path: /healthz\n+            port: 10000\n+          failureThreshold: 3\n+          initialDelaySeconds: 5\n+          periodSeconds: 10\n+          successThreshold: 1\n+          timeoutSeconds: 2\n+        readinessProbe:\n+          httpGet:\n+            path: /healthz\n+            port: 10000\n+          failureThreshold: 1","path":"deploy/catalog/templates/catalog.yaml","position":17,"original_position":17,"commit_id":"1d30b1e34c2d724774c254d1ca51232b51ed3d79","original_commit_id":"1d30b1e34c2d724774c254d1ca51232b51ed3d79","user":{"login":"martinmaly","id":5521294,"avatar_url":"https://avatars.githubusercontent.com/u/5521294?v=3","gravatar_id":"","url":"https://api.github.com/users/martinmaly","html_url":"https://github.com/martinmaly","followers_url":"https://api.github.com/users/martinmaly/followers","following_url":"https://api.github.com/users/martinmaly/following{/other_user}","gists_url":"https://api.github.com/users/martinmaly/gists{/gist_id}","starred_url":"https://api.github.com/users/martinmaly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinmaly/subscriptions","organizations_url":"https://api.github.com/users/martinmaly/orgs","repos_url":"https://api.github.com/users/martinmaly/repos","events_url":"https://api.github.com/users/martinmaly/events{/privacy}","received_events_url":"https://api.github.com/users/martinmaly/received_events","type":"User","site_admin":false},"body":"just curious whether just one failure to declare not ready is optimal (I don't have enough experience with k8s probes to tell). It is great starting point (imo) and we can tweak as needed.","created_at":"2016-12-02T14:34:31Z","updated_at":"2016-12-02T14:35:11Z","html_url":"https://github.com/kubernetes-incubator/service-catalog/pull/91#discussion_r90651129","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/91","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments/90651129"},"html":{"href":"https://github.com/kubernetes-incubator/service-catalog/pull/91#discussion_r90651129"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/91"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/91","id":96138458,"html_url":"https://github.com/kubernetes-incubator/service-catalog/pull/91","diff_url":"https://github.com/kubernetes-incubator/service-catalog/pull/91.diff","patch_url":"https://github.com/kubernetes-incubator/service-catalog/pull/91.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/91","number":91,"state":"open","locked":false,"title":"Add liveness and readiness probes for controller","user":{"login":"krancour","id":1821014,"avatar_url":"https://avatars.githubusercontent.com/u/1821014?v=3","gravatar_id":"","url":"https://api.github.com/users/krancour","html_url":"https://github.com/krancour","followers_url":"https://api.github.com/users/krancour/followers","following_url":"https://api.github.com/users/krancour/following{/other_user}","gists_url":"https://api.github.com/users/krancour/gists{/gist_id}","starred_url":"https://api.github.com/users/krancour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krancour/subscriptions","organizations_url":"https://api.github.com/users/krancour/orgs","repos_url":"https://api.github.com/users/krancour/repos","events_url":"https://api.github.com/users/krancour/events{/privacy}","received_events_url":"https://api.github.com/users/krancour/received_events","type":"User","site_admin":false},"body":"This is a follow up to #84. It requires #84 to be merged first.","created_at":"2016-12-01T17:55:23Z","updated_at":"2016-12-02T14:35:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9eefdbc925c98cc74ff629951ac3168ba078e623","assignee":{"login":"krancour","id":1821014,"avatar_url":"https://avatars.githubusercontent.com/u/1821014?v=3","gravatar_id":"","url":"https://api.github.com/users/krancour","html_url":"https://github.com/krancour","followers_url":"https://api.github.com/users/krancour/followers","following_url":"https://api.github.com/users/krancour/following{/other_user}","gists_url":"https://api.github.com/users/krancour/gists{/gist_id}","starred_url":"https://api.github.com/users/krancour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krancour/subscriptions","organizations_url":"https://api.github.com/users/krancour/orgs","repos_url":"https://api.github.com/users/krancour/repos","events_url":"https://api.github.com/users/krancour/events{/privacy}","received_events_url":"https://api.github.com/users/krancour/received_events","type":"User","site_admin":false},"assignees":[{"login":"krancour","id":1821014,"avatar_url":"https://avatars.githubusercontent.com/u/1821014?v=3","gravatar_id":"","url":"https://api.github.com/users/krancour","html_url":"https://github.com/krancour","followers_url":"https://api.github.com/users/krancour/followers","following_url":"https://api.github.com/users/krancour/following{/other_user}","gists_url":"https://api.github.com/users/krancour/gists{/gist_id}","starred_url":"https://api.github.com/users/krancour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krancour/subscriptions","organizations_url":"https://api.github.com/users/krancour/orgs","repos_url":"https://api.github.com/users/krancour/repos","events_url":"https://api.github.com/users/krancour/events{/privacy}","received_events_url":"https://api.github.com/users/krancour/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/91/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/91/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/91/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/1d30b1e34c2d724774c254d1ca51232b51ed3d79","head":{"label":"krancour:probes","ref":"probes","sha":"1d30b1e34c2d724774c254d1ca51232b51ed3d79","user":{"login":"krancour","id":1821014,"avatar_url":"https://avatars.githubusercontent.com/u/1821014?v=3","gravatar_id":"","url":"https://api.github.com/users/krancour","html_url":"https://github.com/krancour","followers_url":"https://api.github.com/users/krancour/followers","following_url":"https://api.github.com/users/krancour/following{/other_user}","gists_url":"https://api.github.com/users/krancour/gists{/gist_id}","starred_url":"https://api.github.com/users/krancour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krancour/subscriptions","organizations_url":"https://api.github.com/users/krancour/orgs","repos_url":"https://api.github.com/users/krancour/repos","events_url":"https://api.github.com/users/krancour/events{/privacy}","received_events_url":"https://api.github.com/users/krancour/received_events","type":"User","site_admin":false},"repo":{"id":75102233,"name":"service-catalog","full_name":"krancour/service-catalog","owner":{"login":"krancour","id":1821014,"avatar_url":"https://avatars.githubusercontent.com/u/1821014?v=3","gravatar_id":"","url":"https://api.github.com/users/krancour","html_url":"https://github.com/krancour","followers_url":"https://api.github.com/users/krancour/followers","following_url":"https://api.github.com/users/krancour/following{/other_user}","gists_url":"https://api.github.com/users/krancour/gists{/gist_id}","starred_url":"https://api.github.com/users/krancour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krancour/subscriptions","organizations_url":"https://api.github.com/users/krancour/orgs","repos_url":"https://api.github.com/users/krancour/repos","events_url":"https://api.github.com/users/krancour/events{/privacy}","received_events_url":"https://api.github.com/users/krancour/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krancour/service-catalog","description":"Share and consume services in Kubernetes using service brokers","fork":true,"url":"https://api.github.com/repos/krancour/service-catalog","forks_url":"https://api.github.com/repos/krancour/service-catalog/forks","keys_url":"https://api.github.com/repos/krancour/service-catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krancour/service-catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krancour/service-catalog/teams","hooks_url":"https://api.github.com/repos/krancour/service-catalog/hooks","issue_events_url":"https://api.github.com/repos/krancour/service-catalog/issues/events{/number}","events_url":"https://api.github.com/repos/krancour/service-catalog/events","assignees_url":"https://api.github.com/repos/krancour/service-catalog/assignees{/user}","branches_url":"https://api.github.com/repos/krancour/service-catalog/branches{/branch}","tags_url":"https://api.github.com/repos/krancour/service-catalog/tags","blobs_url":"https://api.github.com/repos/krancour/service-catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krancour/service-catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krancour/service-catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/krancour/service-catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krancour/service-catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/krancour/service-catalog/languages","stargazers_url":"https://api.github.com/repos/krancour/service-catalog/stargazers","contributors_url":"https://api.github.com/repos/krancour/service-catalog/contributors","subscribers_url":"https://api.github.com/repos/krancour/service-catalog/subscribers","subscription_url":"https://api.github.com/repos/krancour/service-catalog/subscription","commits_url":"https://api.github.com/repos/krancour/service-catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/krancour/service-catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/krancour/service-catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/krancour/service-catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/krancour/service-catalog/contents/{+path}","compare_url":"https://api.github.com/repos/krancour/service-catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krancour/service-catalog/merges","archive_url":"https://api.github.com/repos/krancour/service-catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krancour/service-catalog/downloads","issues_url":"https://api.github.com/repos/krancour/service-catalog/issues{/number}","pulls_url":"https://api.github.com/repos/krancour/service-catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/krancour/service-catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/krancour/service-catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krancour/service-catalog/labels{/name}","releases_url":"https://api.github.com/repos/krancour/service-catalog/releases{/id}","deployments_url":"https://api.github.com/repos/krancour/service-catalog/deployments","created_at":"2016-11-29T16:50:51Z","updated_at":"2016-11-29T16:50:53Z","pushed_at":"2016-12-01T17:54:30Z","git_url":"git://github.com/krancour/service-catalog.git","ssh_url":"git@github.com:krancour/service-catalog.git","clone_url":"https://github.com/krancour/service-catalog.git","svn_url":"https://github.com/krancour/service-catalog","homepage":"","size":39391,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"2976e8619bf617be85cffbe7297e75473f333666","user":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":68024288,"name":"service-catalog","full_name":"kubernetes-incubator/service-catalog","owner":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/service-catalog","description":"Share and consume services in Kubernetes using service brokers","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog","forks_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/deployments","created_at":"2016-09-12T15:58:39Z","updated_at":"2016-12-02T08:32:16Z","pushed_at":"2016-12-02T06:12:53Z","git_url":"git://github.com/kubernetes-incubator/service-catalog.git","ssh_url":"git@github.com:kubernetes-incubator/service-catalog.git","clone_url":"https://github.com/kubernetes-incubator/service-catalog.git","svn_url":"https://github.com/kubernetes-incubator/service-catalog","homepage":"","size":39562,"stargazers_count":24,"watchers_count":24,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":28,"forks":19,"open_issues":28,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/91"},"html":{"href":"https://github.com/kubernetes-incubator/service-catalog/pull/91"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/91"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/1d30b1e34c2d724774c254d1ca51232b51ed3d79"}}}}
{"actor":{"display_login":"martinmaly"}}