{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/RPresto/pulls/comments/86655875","pull_request_review_id":7306557,"id":86655875,"diff_hunk":"@@ -17,7 +17,6 @@ Depends:\n Imports:\n     DBI (>= 0.3.0),\n     httr (>= 0.6),\n-    RCurl,","path":"DESCRIPTION","position":4,"original_position":4,"commit_id":"455af8976848fd2084744eba04d0f5f65b876dd5","original_commit_id":"455af8976848fd2084744eba04d0f5f65b876dd5","user":{"login":"onurfiliz","id":1843577,"avatar_url":"https://avatars.githubusercontent.com/u/1843577?v=3","gravatar_id":"","url":"https://api.github.com/users/onurfiliz","html_url":"https://github.com/onurfiliz","followers_url":"https://api.github.com/users/onurfiliz/followers","following_url":"https://api.github.com/users/onurfiliz/following{/other_user}","gists_url":"https://api.github.com/users/onurfiliz/gists{/gist_id}","starred_url":"https://api.github.com/users/onurfiliz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onurfiliz/subscriptions","organizations_url":"https://api.github.com/users/onurfiliz/orgs","repos_url":"https://api.github.com/users/onurfiliz/repos","events_url":"https://api.github.com/users/onurfiliz/events{/privacy}","received_events_url":"https://api.github.com/users/onurfiliz/received_events","type":"User","site_admin":false},"body":"Could you add `openssl` to the imports instead then? Otherwise things could break if httr moves away from openssl.","created_at":"2016-11-05T02:05:17Z","updated_at":"2016-11-05T02:05:49Z","html_url":"https://github.com/prestodb/RPresto/pull/67#discussion_r86655875","pull_request_url":"https://api.github.com/repos/prestodb/RPresto/pulls/67","_links":{"self":{"href":"https://api.github.com/repos/prestodb/RPresto/pulls/comments/86655875"},"html":{"href":"https://github.com/prestodb/RPresto/pull/67#discussion_r86655875"},"pull_request":{"href":"https://api.github.com/repos/prestodb/RPresto/pulls/67"}}},"pull_request":{"url":"https://api.github.com/repos/prestodb/RPresto/pulls/67","id":92275708,"html_url":"https://github.com/prestodb/RPresto/pull/67","diff_url":"https://github.com/prestodb/RPresto/pull/67.diff","patch_url":"https://github.com/prestodb/RPresto/pull/67.patch","issue_url":"https://api.github.com/repos/prestodb/RPresto/issues/67","number":67,"state":"open","locked":false,"title":"Drop RCurl Dependency","user":{"login":"saurfang","id":4317392,"avatar_url":"https://avatars.githubusercontent.com/u/4317392?v=3","gravatar_id":"","url":"https://api.github.com/users/saurfang","html_url":"https://github.com/saurfang","followers_url":"https://api.github.com/users/saurfang/followers","following_url":"https://api.github.com/users/saurfang/following{/other_user}","gists_url":"https://api.github.com/users/saurfang/gists{/gist_id}","starred_url":"https://api.github.com/users/saurfang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saurfang/subscriptions","organizations_url":"https://api.github.com/users/saurfang/orgs","repos_url":"https://api.github.com/users/saurfang/repos","events_url":"https://api.github.com/users/saurfang/events{/privacy}","received_events_url":"https://api.github.com/users/saurfang/received_events","type":"User","site_admin":false},"body":"Now that `httr` dropped `RCurl` dependency, `RPresto` can drop one more dependency by using `base64decode` from `openssl` instead of `RCurl`.\r\n\r\nThis is PR is motivated by repeated issues my colleagues and I faced when installing `RCurl`. We often get 404 error like this one: https://github.com/swirldev/swirl/issues/291 \r\nI know this is likely a CRAN mirror issue instead but one less dependency one less thing to worry about 😆 \r\n\r\nAlso one of the tests failed on me and it looks like due to some `dplyr` changes:\r\n```r\r\nFailed -------------------------------------------------------------------------\r\n1. Error: as() works (@test-src_translate_env.R#67) ----------------------------\r\nis.character(vars) is not TRUE\r\n1: dplyr::tbl(s, from = dplyr::sql_subquery(s[[\"con\"]], dplyr::sql(\"SELECT 1\")), vars = list(as.name(\"x\"))) at /Users/sen_fang/workspace/RPresto/tests/testthat/test-src_translate_env.R:67\r\n2: tbl.src_presto(s, from = dplyr::sql_subquery(s[[\"con\"]], dplyr::sql(\"SELECT 1\")), \r\n       vars = list(as.name(\"x\")))\r\n3: dplyr::tbl_sql(\"presto\", src = src, from = from, ...) at /Users/sen_fang/workspace/RPresto/R/tbl.src.presto.R:28\r\n4: make_tbl(c(subclass, \"sql\", \"lazy\"), src = src, ops = op_base_remote(src, from, vars))\r\n5: structure(list(...), class = c(subclass, \"tbl\"))\r\n6: op_base_remote(src, from, vars)\r\n7: op_base(\"remote\", src, x, vars)\r\n8: stopifnot(is.character(vars))\r\n9: stop(sprintf(ngettext(length(r), \"%s is not TRUE\", \"%s are not all TRUE\"), ch), call. = FALSE, \r\n       domain = NA)\r\n\r\nDONE ===========================================================================\r\n```\r\n\r\nAll test suites pass otherwise.","created_at":"2016-11-04T02:43:31Z","updated_at":"2016-11-05T02:05:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4aca62d21a6206733ffa873ba8802e0aaa1321ed","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/RPresto/pulls/67/commits","review_comments_url":"https://api.github.com/repos/prestodb/RPresto/pulls/67/comments","review_comment_url":"https://api.github.com/repos/prestodb/RPresto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/RPresto/issues/67/comments","statuses_url":"https://api.github.com/repos/prestodb/RPresto/statuses/455af8976848fd2084744eba04d0f5f65b876dd5","head":{"label":"saurfang:openssl_base64","ref":"openssl_base64","sha":"455af8976848fd2084744eba04d0f5f65b876dd5","user":{"login":"saurfang","id":4317392,"avatar_url":"https://avatars.githubusercontent.com/u/4317392?v=3","gravatar_id":"","url":"https://api.github.com/users/saurfang","html_url":"https://github.com/saurfang","followers_url":"https://api.github.com/users/saurfang/followers","following_url":"https://api.github.com/users/saurfang/following{/other_user}","gists_url":"https://api.github.com/users/saurfang/gists{/gist_id}","starred_url":"https://api.github.com/users/saurfang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saurfang/subscriptions","organizations_url":"https://api.github.com/users/saurfang/orgs","repos_url":"https://api.github.com/users/saurfang/repos","events_url":"https://api.github.com/users/saurfang/events{/privacy}","received_events_url":"https://api.github.com/users/saurfang/received_events","type":"User","site_admin":false},"repo":{"id":61331399,"name":"RPresto","full_name":"saurfang/RPresto","owner":{"login":"saurfang","id":4317392,"avatar_url":"https://avatars.githubusercontent.com/u/4317392?v=3","gravatar_id":"","url":"https://api.github.com/users/saurfang","html_url":"https://github.com/saurfang","followers_url":"https://api.github.com/users/saurfang/followers","following_url":"https://api.github.com/users/saurfang/following{/other_user}","gists_url":"https://api.github.com/users/saurfang/gists{/gist_id}","starred_url":"https://api.github.com/users/saurfang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saurfang/subscriptions","organizations_url":"https://api.github.com/users/saurfang/orgs","repos_url":"https://api.github.com/users/saurfang/repos","events_url":"https://api.github.com/users/saurfang/events{/privacy}","received_events_url":"https://api.github.com/users/saurfang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saurfang/RPresto","description":"DBI-based adapter for Presto for the statistical programming language R.","fork":true,"url":"https://api.github.com/repos/saurfang/RPresto","forks_url":"https://api.github.com/repos/saurfang/RPresto/forks","keys_url":"https://api.github.com/repos/saurfang/RPresto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saurfang/RPresto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saurfang/RPresto/teams","hooks_url":"https://api.github.com/repos/saurfang/RPresto/hooks","issue_events_url":"https://api.github.com/repos/saurfang/RPresto/issues/events{/number}","events_url":"https://api.github.com/repos/saurfang/RPresto/events","assignees_url":"https://api.github.com/repos/saurfang/RPresto/assignees{/user}","branches_url":"https://api.github.com/repos/saurfang/RPresto/branches{/branch}","tags_url":"https://api.github.com/repos/saurfang/RPresto/tags","blobs_url":"https://api.github.com/repos/saurfang/RPresto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saurfang/RPresto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saurfang/RPresto/git/refs{/sha}","trees_url":"https://api.github.com/repos/saurfang/RPresto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saurfang/RPresto/statuses/{sha}","languages_url":"https://api.github.com/repos/saurfang/RPresto/languages","stargazers_url":"https://api.github.com/repos/saurfang/RPresto/stargazers","contributors_url":"https://api.github.com/repos/saurfang/RPresto/contributors","subscribers_url":"https://api.github.com/repos/saurfang/RPresto/subscribers","subscription_url":"https://api.github.com/repos/saurfang/RPresto/subscription","commits_url":"https://api.github.com/repos/saurfang/RPresto/commits{/sha}","git_commits_url":"https://api.github.com/repos/saurfang/RPresto/git/commits{/sha}","comments_url":"https://api.github.com/repos/saurfang/RPresto/comments{/number}","issue_comment_url":"https://api.github.com/repos/saurfang/RPresto/issues/comments{/number}","contents_url":"https://api.github.com/repos/saurfang/RPresto/contents/{+path}","compare_url":"https://api.github.com/repos/saurfang/RPresto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saurfang/RPresto/merges","archive_url":"https://api.github.com/repos/saurfang/RPresto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saurfang/RPresto/downloads","issues_url":"https://api.github.com/repos/saurfang/RPresto/issues{/number}","pulls_url":"https://api.github.com/repos/saurfang/RPresto/pulls{/number}","milestones_url":"https://api.github.com/repos/saurfang/RPresto/milestones{/number}","notifications_url":"https://api.github.com/repos/saurfang/RPresto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saurfang/RPresto/labels{/name}","releases_url":"https://api.github.com/repos/saurfang/RPresto/releases{/id}","deployments_url":"https://api.github.com/repos/saurfang/RPresto/deployments","created_at":"2016-06-16T23:08:48Z","updated_at":"2016-06-16T23:08:49Z","pushed_at":"2016-11-04T02:33:29Z","git_url":"git://github.com/saurfang/RPresto.git","ssh_url":"git@github.com:saurfang/RPresto.git","clone_url":"https://github.com/saurfang/RPresto.git","svn_url":"https://github.com/saurfang/RPresto","homepage":null,"size":172,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"9103b04a3b0bc970997eb3431966b052a4cc9c6c","user":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":32487073,"name":"RPresto","full_name":"prestodb/RPresto","owner":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/RPresto","description":"DBI-based adapter for Presto for the statistical programming language R.","fork":false,"url":"https://api.github.com/repos/prestodb/RPresto","forks_url":"https://api.github.com/repos/prestodb/RPresto/forks","keys_url":"https://api.github.com/repos/prestodb/RPresto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/RPresto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/RPresto/teams","hooks_url":"https://api.github.com/repos/prestodb/RPresto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/RPresto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/RPresto/events","assignees_url":"https://api.github.com/repos/prestodb/RPresto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/RPresto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/RPresto/tags","blobs_url":"https://api.github.com/repos/prestodb/RPresto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/RPresto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/RPresto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/RPresto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/RPresto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/RPresto/languages","stargazers_url":"https://api.github.com/repos/prestodb/RPresto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/RPresto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/RPresto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/RPresto/subscription","commits_url":"https://api.github.com/repos/prestodb/RPresto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/RPresto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/RPresto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/RPresto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/RPresto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/RPresto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/RPresto/merges","archive_url":"https://api.github.com/repos/prestodb/RPresto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/RPresto/downloads","issues_url":"https://api.github.com/repos/prestodb/RPresto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/RPresto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/RPresto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/RPresto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/RPresto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/RPresto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/RPresto/deployments","created_at":"2015-03-18T22:11:28Z","updated_at":"2016-10-14T07:37:27Z","pushed_at":"2016-11-04T02:43:31Z","git_url":"git://github.com/prestodb/RPresto.git","ssh_url":"git@github.com:prestodb/RPresto.git","clone_url":"https://github.com/prestodb/RPresto.git","svn_url":"https://github.com/prestodb/RPresto","homepage":null,"size":178,"stargazers_count":51,"watchers_count":51,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":4,"forks":9,"open_issues":4,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/RPresto/pulls/67"},"html":{"href":"https://github.com/prestodb/RPresto/pull/67"},"issue":{"href":"https://api.github.com/repos/prestodb/RPresto/issues/67"},"comments":{"href":"https://api.github.com/repos/prestodb/RPresto/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/RPresto/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/RPresto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/RPresto/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/RPresto/statuses/455af8976848fd2084744eba04d0f5f65b876dd5"}}}}
{"actor":{"display_login":"onurfiliz"}}