{"action":"created","comment":{"url":"https://api.github.com/repos/cfpb/hmda-platform/pulls/comments/64135807","id":64135807,"diff_hunk":"@@ -0,0 +1,19 @@\n+package hmda.validation.rules.lar.validity\n+\n+import hmda.model.fi.lar.LoanApplicationRegister\n+import hmda.validation.dsl.Result\n+import hmda.validation.rules.EditCheck\n+import hmda.validation.dsl.PredicateCommon._\n+import hmda.validation.dsl.PredicateSyntax._\n+\n+object V540 extends EditCheck[LoanApplicationRegister] {\n+\n+  val ActionTakenList = List(2, 3, 4, 5, 7, 8)","path":"validation/src/main/scala/hmda/validation/rules/lar/validity/V540.scala","position":11,"original_position":11,"commit_id":"ca661cd5c656fcffe66d29a53d01d3678e1a9c86","original_commit_id":"ca661cd5c656fcffe66d29a53d01d3678e1a9c86","user":{"login":"jmarin","id":438146,"avatar_url":"https://avatars.githubusercontent.com/u/438146?v=3","gravatar_id":"","url":"https://api.github.com/users/jmarin","html_url":"https://github.com/jmarin","followers_url":"https://api.github.com/users/jmarin/followers","following_url":"https://api.github.com/users/jmarin/following{/other_user}","gists_url":"https://api.github.com/users/jmarin/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarin/subscriptions","organizations_url":"https://api.github.com/users/jmarin/orgs","repos_url":"https://api.github.com/users/jmarin/repos","events_url":"https://api.github.com/users/jmarin/events{/privacy}","received_events_url":"https://api.github.com/users/jmarin/received_events","type":"User","site_admin":false},"body":"Small thing, but usually by convention variables follow camel casing with the first letter being lower case (i.e. actionTakenList)","created_at":"2016-05-21T15:08:06Z","updated_at":"2016-05-21T15:08:06Z","html_url":"https://github.com/cfpb/hmda-platform/pull/339#discussion_r64135807","pull_request_url":"https://api.github.com/repos/cfpb/hmda-platform/pulls/339","_links":{"self":{"href":"https://api.github.com/repos/cfpb/hmda-platform/pulls/comments/64135807"},"html":{"href":"https://github.com/cfpb/hmda-platform/pull/339#discussion_r64135807"},"pull_request":{"href":"https://api.github.com/repos/cfpb/hmda-platform/pulls/339"}}},"pull_request":{"url":"https://api.github.com/repos/cfpb/hmda-platform/pulls/339","id":70717643,"html_url":"https://github.com/cfpb/hmda-platform/pull/339","diff_url":"https://github.com/cfpb/hmda-platform/pull/339.diff","patch_url":"https://github.com/cfpb/hmda-platform/pull/339.patch","issue_url":"https://api.github.com/repos/cfpb/hmda-platform/issues/339","number":339,"state":"open","locked":false,"title":"V535, V540","user":{"login":"kgudel","id":13244336,"avatar_url":"https://avatars.githubusercontent.com/u/13244336?v=3","gravatar_id":"","url":"https://api.github.com/users/kgudel","html_url":"https://github.com/kgudel","followers_url":"https://api.github.com/users/kgudel/followers","following_url":"https://api.github.com/users/kgudel/following{/other_user}","gists_url":"https://api.github.com/users/kgudel/gists{/gist_id}","starred_url":"https://api.github.com/users/kgudel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgudel/subscriptions","organizations_url":"https://api.github.com/users/kgudel/orgs","repos_url":"https://api.github.com/users/kgudel/repos","events_url":"https://api.github.com/users/kgudel/events{/privacy}","received_events_url":"https://api.github.com/users/kgudel/received_events","type":"User","site_admin":false},"body":"Closes #170 \r\nCloses #172 ","created_at":"2016-05-19T15:43:22Z","updated_at":"2016-05-21T15:08:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"786e65e209a74565e8175b22d6ead2ef03226003","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cfpb/hmda-platform/pulls/339/commits","review_comments_url":"https://api.github.com/repos/cfpb/hmda-platform/pulls/339/comments","review_comment_url":"https://api.github.com/repos/cfpb/hmda-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cfpb/hmda-platform/issues/339/comments","statuses_url":"https://api.github.com/repos/cfpb/hmda-platform/statuses/ca661cd5c656fcffe66d29a53d01d3678e1a9c86","head":{"label":"kgudel:hoepaStatus","ref":"hoepaStatus","sha":"ca661cd5c656fcffe66d29a53d01d3678e1a9c86","user":{"login":"kgudel","id":13244336,"avatar_url":"https://avatars.githubusercontent.com/u/13244336?v=3","gravatar_id":"","url":"https://api.github.com/users/kgudel","html_url":"https://github.com/kgudel","followers_url":"https://api.github.com/users/kgudel/followers","following_url":"https://api.github.com/users/kgudel/following{/other_user}","gists_url":"https://api.github.com/users/kgudel/gists{/gist_id}","starred_url":"https://api.github.com/users/kgudel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgudel/subscriptions","organizations_url":"https://api.github.com/users/kgudel/orgs","repos_url":"https://api.github.com/users/kgudel/repos","events_url":"https://api.github.com/users/kgudel/events{/privacy}","received_events_url":"https://api.github.com/users/kgudel/received_events","type":"User","site_admin":false},"repo":{"id":57915203,"name":"hmda-platform","full_name":"kgudel/hmda-platform","owner":{"login":"kgudel","id":13244336,"avatar_url":"https://avatars.githubusercontent.com/u/13244336?v=3","gravatar_id":"","url":"https://api.github.com/users/kgudel","html_url":"https://github.com/kgudel","followers_url":"https://api.github.com/users/kgudel/followers","following_url":"https://api.github.com/users/kgudel/following{/other_user}","gists_url":"https://api.github.com/users/kgudel/gists{/gist_id}","starred_url":"https://api.github.com/users/kgudel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgudel/subscriptions","organizations_url":"https://api.github.com/users/kgudel/orgs","repos_url":"https://api.github.com/users/kgudel/repos","events_url":"https://api.github.com/users/kgudel/events{/privacy}","received_events_url":"https://api.github.com/users/kgudel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kgudel/hmda-platform","description":"","fork":true,"url":"https://api.github.com/repos/kgudel/hmda-platform","forks_url":"https://api.github.com/repos/kgudel/hmda-platform/forks","keys_url":"https://api.github.com/repos/kgudel/hmda-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kgudel/hmda-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kgudel/hmda-platform/teams","hooks_url":"https://api.github.com/repos/kgudel/hmda-platform/hooks","issue_events_url":"https://api.github.com/repos/kgudel/hmda-platform/issues/events{/number}","events_url":"https://api.github.com/repos/kgudel/hmda-platform/events","assignees_url":"https://api.github.com/repos/kgudel/hmda-platform/assignees{/user}","branches_url":"https://api.github.com/repos/kgudel/hmda-platform/branches{/branch}","tags_url":"https://api.github.com/repos/kgudel/hmda-platform/tags","blobs_url":"https://api.github.com/repos/kgudel/hmda-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kgudel/hmda-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kgudel/hmda-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/kgudel/hmda-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kgudel/hmda-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/kgudel/hmda-platform/languages","stargazers_url":"https://api.github.com/repos/kgudel/hmda-platform/stargazers","contributors_url":"https://api.github.com/repos/kgudel/hmda-platform/contributors","subscribers_url":"https://api.github.com/repos/kgudel/hmda-platform/subscribers","subscription_url":"https://api.github.com/repos/kgudel/hmda-platform/subscription","commits_url":"https://api.github.com/repos/kgudel/hmda-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/kgudel/hmda-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/kgudel/hmda-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/kgudel/hmda-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/kgudel/hmda-platform/contents/{+path}","compare_url":"https://api.github.com/repos/kgudel/hmda-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kgudel/hmda-platform/merges","archive_url":"https://api.github.com/repos/kgudel/hmda-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kgudel/hmda-platform/downloads","issues_url":"https://api.github.com/repos/kgudel/hmda-platform/issues{/number}","pulls_url":"https://api.github.com/repos/kgudel/hmda-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/kgudel/hmda-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/kgudel/hmda-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kgudel/hmda-platform/labels{/name}","releases_url":"https://api.github.com/repos/kgudel/hmda-platform/releases{/id}","deployments_url":"https://api.github.com/repos/kgudel/hmda-platform/deployments","created_at":"2016-05-02T19:22:32Z","updated_at":"2016-05-02T19:22:35Z","pushed_at":"2016-05-20T20:18:25Z","git_url":"git://github.com/kgudel/hmda-platform.git","ssh_url":"git@github.com:kgudel/hmda-platform.git","clone_url":"https://github.com/kgudel/hmda-platform.git","svn_url":"https://github.com/kgudel/hmda-platform","homepage":"","size":3229,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cfpb:master","ref":"master","sha":"df06eec6641260f80d94cffd93277c21751ca4ae","user":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"repo":{"id":50141662,"name":"hmda-platform","full_name":"cfpb/hmda-platform","owner":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfpb/hmda-platform","description":"","fork":false,"url":"https://api.github.com/repos/cfpb/hmda-platform","forks_url":"https://api.github.com/repos/cfpb/hmda-platform/forks","keys_url":"https://api.github.com/repos/cfpb/hmda-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfpb/hmda-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfpb/hmda-platform/teams","hooks_url":"https://api.github.com/repos/cfpb/hmda-platform/hooks","issue_events_url":"https://api.github.com/repos/cfpb/hmda-platform/issues/events{/number}","events_url":"https://api.github.com/repos/cfpb/hmda-platform/events","assignees_url":"https://api.github.com/repos/cfpb/hmda-platform/assignees{/user}","branches_url":"https://api.github.com/repos/cfpb/hmda-platform/branches{/branch}","tags_url":"https://api.github.com/repos/cfpb/hmda-platform/tags","blobs_url":"https://api.github.com/repos/cfpb/hmda-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfpb/hmda-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfpb/hmda-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfpb/hmda-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfpb/hmda-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/cfpb/hmda-platform/languages","stargazers_url":"https://api.github.com/repos/cfpb/hmda-platform/stargazers","contributors_url":"https://api.github.com/repos/cfpb/hmda-platform/contributors","subscribers_url":"https://api.github.com/repos/cfpb/hmda-platform/subscribers","subscription_url":"https://api.github.com/repos/cfpb/hmda-platform/subscription","commits_url":"https://api.github.com/repos/cfpb/hmda-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfpb/hmda-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfpb/hmda-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfpb/hmda-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfpb/hmda-platform/contents/{+path}","compare_url":"https://api.github.com/repos/cfpb/hmda-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfpb/hmda-platform/merges","archive_url":"https://api.github.com/repos/cfpb/hmda-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfpb/hmda-platform/downloads","issues_url":"https://api.github.com/repos/cfpb/hmda-platform/issues{/number}","pulls_url":"https://api.github.com/repos/cfpb/hmda-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/cfpb/hmda-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/cfpb/hmda-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfpb/hmda-platform/labels{/name}","releases_url":"https://api.github.com/repos/cfpb/hmda-platform/releases{/id}","deployments_url":"https://api.github.com/repos/cfpb/hmda-platform/deployments","created_at":"2016-01-21T22:39:17Z","updated_at":"2016-05-18T17:14:26Z","pushed_at":"2016-05-20T22:28:26Z","git_url":"git://github.com/cfpb/hmda-platform.git","ssh_url":"git@github.com:cfpb/hmda-platform.git","clone_url":"https://github.com/cfpb/hmda-platform.git","svn_url":"https://github.com/cfpb/hmda-platform","homepage":"","size":4712,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":171,"forks":9,"open_issues":171,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cfpb/hmda-platform/pulls/339"},"html":{"href":"https://github.com/cfpb/hmda-platform/pull/339"},"issue":{"href":"https://api.github.com/repos/cfpb/hmda-platform/issues/339"},"comments":{"href":"https://api.github.com/repos/cfpb/hmda-platform/issues/339/comments"},"review_comments":{"href":"https://api.github.com/repos/cfpb/hmda-platform/pulls/339/comments"},"review_comment":{"href":"https://api.github.com/repos/cfpb/hmda-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cfpb/hmda-platform/pulls/339/commits"},"statuses":{"href":"https://api.github.com/repos/cfpb/hmda-platform/statuses/ca661cd5c656fcffe66d29a53d01d3678e1a9c86"}}}}
{"actor":{"display_login":"jmarin"}}