{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/3587","repository_url":"https://api.github.com/repos/dotnet/coreclr","labels_url":"https://api.github.com/repos/dotnet/coreclr/issues/3587/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/3587/comments","events_url":"https://api.github.com/repos/dotnet/coreclr/issues/3587/events","html_url":"https://github.com/dotnet/coreclr/pull/3587","id":139334579,"number":3587,"title":"Use jitstd::list in the LSRA.","user":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/coreclr/labels/2%20-%20In%20Progress","name":"2 - In Progress","color":"CCCCCC"},{"url":"https://api.github.com/repos/dotnet/coreclr/labels/cla-already-signed","name":"cla-already-signed","color":"009800"},{"url":"https://api.github.com/repos/dotnet/coreclr/labels/CodeGen","name":"CodeGen","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-08T17:04:11Z","updated_at":"2016-03-08T19:22:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/3587","html_url":"https://github.com/dotnet/coreclr/pull/3587","diff_url":"https://github.com/dotnet/coreclr/pull/3587.diff","patch_url":"https://github.com/dotnet/coreclr/pull/3587.patch"},"body":"This removes the only usage of ArrayList in the JIT."},"comment":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/comments/193929963","html_url":"https://github.com/dotnet/coreclr/pull/3587#issuecomment-193929963","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/3587","id":193929963,"user":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"created_at":"2016-03-08T19:22:54Z","updated_at":"2016-03-08T19:22:54Z","body":"> Now it is inconsistent - perhaps we should change over to using all references, but I'm not happy with the inconsistency (and, in general, pointers are used all over the JIT, so perhaps this is a conventions kind of question).\r\n\r\nThe use of references is somewhat necessary with the change to jitstd::list<T>, since its elements are accessed as `T&` during iteration (in contrast to `StructArrayList<T>`, whose iterator returns values of type `T*`). If you're very concerned with the difference, I can change the few sites where wide-scale changes were necessary to something like the following:\r\n\r\n```\r\nfor (auto& refPosition : refPositions)\r\n{\r\n    RefPosition* currentRefPosition = &refPosition;\r\n    ...\r\n}\r\n```\r\n\r\nwhich also has the side-effect of producing a smaller diff in some places."}}