{"action":"created","issue":{"url":"https://api.github.com/repos/evd2014/blockly/issues/29","repository_url":"https://api.github.com/repos/evd2014/blockly","labels_url":"https://api.github.com/repos/evd2014/blockly/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/evd2014/blockly/issues/29/comments","events_url":"https://api.github.com/repos/evd2014/blockly/issues/29/events","html_url":"https://github.com/evd2014/blockly/pull/29","id":168772081,"number":29,"title":"Workspace Factory #9: Import Toolbox XML","user":{"login":"evd2014","id":18580768,"avatar_url":"https://avatars.githubusercontent.com/u/18580768?v=3","gravatar_id":"","url":"https://api.github.com/users/evd2014","html_url":"https://github.com/evd2014","followers_url":"https://api.github.com/users/evd2014/followers","following_url":"https://api.github.com/users/evd2014/following{/other_user}","gists_url":"https://api.github.com/users/evd2014/gists{/gist_id}","starred_url":"https://api.github.com/users/evd2014/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evd2014/subscriptions","organizations_url":"https://api.github.com/users/evd2014/orgs","repos_url":"https://api.github.com/users/evd2014/repos","events_url":"https://api.github.com/users/evd2014/events{/privacy}","received_events_url":"https://api.github.com/users/evd2014/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"picklesrus","id":15675877,"avatar_url":"https://avatars.githubusercontent.com/u/15675877?v=3","gravatar_id":"","url":"https://api.github.com/users/picklesrus","html_url":"https://github.com/picklesrus","followers_url":"https://api.github.com/users/picklesrus/followers","following_url":"https://api.github.com/users/picklesrus/following{/other_user}","gists_url":"https://api.github.com/users/picklesrus/gists{/gist_id}","starred_url":"https://api.github.com/users/picklesrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/picklesrus/subscriptions","organizations_url":"https://api.github.com/users/picklesrus/orgs","repos_url":"https://api.github.com/users/picklesrus/repos","events_url":"https://api.github.com/users/picklesrus/events{/privacy}","received_events_url":"https://api.github.com/users/picklesrus/received_events","type":"User","site_admin":false},"assignees":[{"login":"quachtina96","id":10423718,"avatar_url":"https://avatars.githubusercontent.com/u/10423718?v=3","gravatar_id":"","url":"https://api.github.com/users/quachtina96","html_url":"https://github.com/quachtina96","followers_url":"https://api.github.com/users/quachtina96/followers","following_url":"https://api.github.com/users/quachtina96/following{/other_user}","gists_url":"https://api.github.com/users/quachtina96/gists{/gist_id}","starred_url":"https://api.github.com/users/quachtina96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quachtina96/subscriptions","organizations_url":"https://api.github.com/users/quachtina96/orgs","repos_url":"https://api.github.com/users/quachtina96/repos","events_url":"https://api.github.com/users/quachtina96/events{/privacy}","received_events_url":"https://api.github.com/users/quachtina96/received_events","type":"User","site_admin":false},{"login":"vicng","id":13488389,"avatar_url":"https://avatars.githubusercontent.com/u/13488389?v=3","gravatar_id":"","url":"https://api.github.com/users/vicng","html_url":"https://github.com/vicng","followers_url":"https://api.github.com/users/vicng/followers","following_url":"https://api.github.com/users/vicng/following{/other_user}","gists_url":"https://api.github.com/users/vicng/gists{/gist_id}","starred_url":"https://api.github.com/users/vicng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicng/subscriptions","organizations_url":"https://api.github.com/users/vicng/orgs","repos_url":"https://api.github.com/users/vicng/repos","events_url":"https://api.github.com/users/vicng/events{/privacy}","received_events_url":"https://api.github.com/users/vicng/received_events","type":"User","site_admin":false},{"login":"rachel-fenichel","id":13686399,"avatar_url":"https://avatars.githubusercontent.com/u/13686399?v=3","gravatar_id":"","url":"https://api.github.com/users/rachel-fenichel","html_url":"https://github.com/rachel-fenichel","followers_url":"https://api.github.com/users/rachel-fenichel/followers","following_url":"https://api.github.com/users/rachel-fenichel/following{/other_user}","gists_url":"https://api.github.com/users/rachel-fenichel/gists{/gist_id}","starred_url":"https://api.github.com/users/rachel-fenichel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rachel-fenichel/subscriptions","organizations_url":"https://api.github.com/users/rachel-fenichel/orgs","repos_url":"https://api.github.com/users/rachel-fenichel/repos","events_url":"https://api.github.com/users/rachel-fenichel/events{/privacy}","received_events_url":"https://api.github.com/users/rachel-fenichel/received_events","type":"User","site_admin":false},{"login":"picklesrus","id":15675877,"avatar_url":"https://avatars.githubusercontent.com/u/15675877?v=3","gravatar_id":"","url":"https://api.github.com/users/picklesrus","html_url":"https://github.com/picklesrus","followers_url":"https://api.github.com/users/picklesrus/followers","following_url":"https://api.github.com/users/picklesrus/following{/other_user}","gists_url":"https://api.github.com/users/picklesrus/gists{/gist_id}","starred_url":"https://api.github.com/users/picklesrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/picklesrus/subscriptions","organizations_url":"https://api.github.com/users/picklesrus/orgs","repos_url":"https://api.github.com/users/picklesrus/repos","events_url":"https://api.github.com/users/picklesrus/events{/privacy}","received_events_url":"https://api.github.com/users/picklesrus/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-08-02T00:20:55Z","updated_at":"2016-08-02T00:34:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/evd2014/blockly/pulls/29","html_url":"https://github.com/evd2014/blockly/pull/29","diff_url":"https://github.com/evd2014/blockly/pull/29.diff","patch_url":"https://github.com/evd2014/blockly/pull/29.patch"},"body":"Allows user to choose a local file containing toolbox XML and load it into the workspace factory editing space to continue editing it. If the user does not choose a valid XML file, it prints an error message. \r\n\r\nAlso adds a \"Clear\" button to entirely clear the workspace factory editing space. This was trivial to add because it is necessary to clear before loading a toolbox from a file. \r\n![import button](https://cloud.githubusercontent.com/assets/18580768/17312955/4a6664da-580c-11e6-8d6a-3705765d3c8c.png)\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/evd2014/blockly/29)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/evd2014/blockly/issues/comments/236753887","html_url":"https://github.com/evd2014/blockly/pull/29#issuecomment-236753887","issue_url":"https://api.github.com/repos/evd2014/blockly/issues/29","id":236753887,"user":{"login":"quachtina96","id":10423718,"avatar_url":"https://avatars.githubusercontent.com/u/10423718?v=3","gravatar_id":"","url":"https://api.github.com/users/quachtina96","html_url":"https://github.com/quachtina96","followers_url":"https://api.github.com/users/quachtina96/followers","following_url":"https://api.github.com/users/quachtina96/following{/other_user}","gists_url":"https://api.github.com/users/quachtina96/gists{/gist_id}","starred_url":"https://api.github.com/users/quachtina96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quachtina96/subscriptions","organizations_url":"https://api.github.com/users/quachtina96/orgs","repos_url":"https://api.github.com/users/quachtina96/repos","events_url":"https://api.github.com/users/quachtina96/events{/privacy}","received_events_url":"https://api.github.com/users/quachtina96/received_events","type":"User","site_admin":false},"created_at":"2016-08-02T00:34:53Z","updated_at":"2016-08-02T00:34:53Z","body":"\n\n\n\nReview status: 0 of 5 files reviewed at latest revision, 2 unresolved discussions.\n\n---\n\n*[demos/workspacefactory/factory_controller.js, line 521 \\[r1\\]](https://reviewable.io:443/reviews/evd2014/blockly/29#-KO7eiPIG7PPMaxRfeT3:-KO7eiPIG7PPMaxRfeT4:1554720499) ([raw file](https://github.com/evd2014/blockly/blob/0d52c2dec7863009e004682b628649a7674a9d9f/demos/workspacefactory/factory_controller.js#L521)):*\n> ```JavaScript\n>       if (item.tagName == 'category') {\n>         this.createCategory(item.getAttribute('name'), false);\n>         this.switchElement(this.model.getElementByIndex(i).id);\n> ```\n\nmaybe you could provide an alias for\n\"this.model.getElementByIndex(i)\"  at the start of the for loop--might make the code more readable\n\n---\n\n*[demos/workspacefactory/factory_view.js, line 67 \\[r1\\]](https://reviewable.io:443/reviews/evd2014/blockly/29#-KO7eIeQhSEENfPGwmcK:-KO7eIeQhSEENfPGwmcL:-1158588620) ([raw file](https://github.com/evd2014/blockly/blob/0d52c2dec7863009e004682b628649a7674a9d9f/demos/workspacefactory/factory_view.js#L67)):*\n> ```JavaScript\n> };\n> \n> FactoryView.prototype.addEmptyCategoryMessage = function() {\n> ```\n\ncomment this function\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/evd2014/blockly/29)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"quachtina96"}}