{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/92360560","pull_request_review_id":12865323,"id":92360560,"diff_hunk":"@@ -58,7 +59,10 @@ class SortITCase(\n     val expected = sortExpectedly(tupleDataSetStrings)\n     val results = t.toDataSet[Row].mapPartition(rows => Seq(rows.toSeq)).collect()\n \n-    val result = results.filterNot(_.isEmpty).sortBy(p => p.head).reduceLeft(_ ++ _)\n+    val result = results\n+      .filterNot(_.isEmpty)\n+      .sortBy(_.head)(Ordering.by(f=> f.toString))","path":"flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/SortITCase.scala","position":17,"original_position":17,"commit_id":"b94b5a765fe4bfbc09e1769ce5f297fae3fc0628","original_commit_id":"b94b5a765fe4bfbc09e1769ce5f297fae3fc0628","user":{"login":"fhueske","id":2388347,"avatar_url":"https://avatars.githubusercontent.com/u/2388347?v=3","gravatar_id":"","url":"https://api.github.com/users/fhueske","html_url":"https://github.com/fhueske","followers_url":"https://api.github.com/users/fhueske/followers","following_url":"https://api.github.com/users/fhueske/following{/other_user}","gists_url":"https://api.github.com/users/fhueske/gists{/gist_id}","starred_url":"https://api.github.com/users/fhueske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhueske/subscriptions","organizations_url":"https://api.github.com/users/fhueske/orgs","repos_url":"https://api.github.com/users/fhueske/repos","events_url":"https://api.github.com/users/fhueske/events{/privacy}","received_events_url":"https://api.github.com/users/fhueske/received_events","type":"User","site_admin":false},"body":"Can we remove the implicit `Product` ordering above?","created_at":"2016-12-14T10:07:43Z","updated_at":"2016-12-14T10:14:21Z","html_url":"https://github.com/apache/flink/pull/3003#discussion_r92360560","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/3003","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/92360560"},"html":{"href":"https://github.com/apache/flink/pull/3003#discussion_r92360560"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/3003"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/3003","id":97899871,"html_url":"https://github.com/apache/flink/pull/3003","diff_url":"https://github.com/apache/flink/pull/3003.diff","patch_url":"https://github.com/apache/flink/pull/3003.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/3003","number":3003,"state":"open","locked":false,"title":"[FLINK-5188] Create analog of RowCsvInputFormat in java and adjust all the imports of Row and RowTypeInfo","user":{"login":"tonycox","id":15128562,"avatar_url":"https://avatars.githubusercontent.com/u/15128562?v=3","gravatar_id":"","url":"https://api.github.com/users/tonycox","html_url":"https://github.com/tonycox","followers_url":"https://api.github.com/users/tonycox/followers","following_url":"https://api.github.com/users/tonycox/following{/other_user}","gists_url":"https://api.github.com/users/tonycox/gists{/gist_id}","starred_url":"https://api.github.com/users/tonycox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonycox/subscriptions","organizations_url":"https://api.github.com/users/tonycox/orgs","repos_url":"https://api.github.com/users/tonycox/repos","events_url":"https://api.github.com/users/tonycox/events{/privacy}","received_events_url":"https://api.github.com/users/tonycox/received_events","type":"User","site_admin":false},"body":"Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.\r\nIf your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).\r\nIn addition to going through the list, please provide a meaningful description of your changes.\r\n\r\n- [ ] General\r\n  - The pull request references the related JIRA issue (\"[FLINK-XXX] Jira title text\")\r\n  - The pull request addresses only one issue\r\n  - Each commit in the PR has a meaningful commit message (including the JIRA id)\r\n\r\n- [ ] Documentation\r\n  - Documentation has been added for new functionality\r\n  - Old documentation affected by the pull request has been updated\r\n  - JavaDoc for public methods has been added\r\n\r\n- [ ] Tests & Build\r\n  - Functionality added by the pull request is covered by tests\r\n  - `mvn clean verify` has been executed successfully locally or a Travis build has passed\r\n","created_at":"2016-12-14T07:23:31Z","updated_at":"2016-12-14T10:14:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e0c6c4a7fd2039307b2271699d9098e54704d03","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/3003/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/3003/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/3003/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/b94b5a765fe4bfbc09e1769ce5f297fae3fc0628","head":{"label":"tonycox:FLINK-5188","ref":"FLINK-5188","sha":"b94b5a765fe4bfbc09e1769ce5f297fae3fc0628","user":{"login":"tonycox","id":15128562,"avatar_url":"https://avatars.githubusercontent.com/u/15128562?v=3","gravatar_id":"","url":"https://api.github.com/users/tonycox","html_url":"https://github.com/tonycox","followers_url":"https://api.github.com/users/tonycox/followers","following_url":"https://api.github.com/users/tonycox/following{/other_user}","gists_url":"https://api.github.com/users/tonycox/gists{/gist_id}","starred_url":"https://api.github.com/users/tonycox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonycox/subscriptions","organizations_url":"https://api.github.com/users/tonycox/orgs","repos_url":"https://api.github.com/users/tonycox/repos","events_url":"https://api.github.com/users/tonycox/events{/privacy}","received_events_url":"https://api.github.com/users/tonycox/received_events","type":"User","site_admin":false},"repo":{"id":69664884,"name":"flink","full_name":"tonycox/flink","owner":{"login":"tonycox","id":15128562,"avatar_url":"https://avatars.githubusercontent.com/u/15128562?v=3","gravatar_id":"","url":"https://api.github.com/users/tonycox","html_url":"https://github.com/tonycox","followers_url":"https://api.github.com/users/tonycox/followers","following_url":"https://api.github.com/users/tonycox/following{/other_user}","gists_url":"https://api.github.com/users/tonycox/gists{/gist_id}","starred_url":"https://api.github.com/users/tonycox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonycox/subscriptions","organizations_url":"https://api.github.com/users/tonycox/orgs","repos_url":"https://api.github.com/users/tonycox/repos","events_url":"https://api.github.com/users/tonycox/events{/privacy}","received_events_url":"https://api.github.com/users/tonycox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tonycox/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/tonycox/flink","forks_url":"https://api.github.com/repos/tonycox/flink/forks","keys_url":"https://api.github.com/repos/tonycox/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tonycox/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tonycox/flink/teams","hooks_url":"https://api.github.com/repos/tonycox/flink/hooks","issue_events_url":"https://api.github.com/repos/tonycox/flink/issues/events{/number}","events_url":"https://api.github.com/repos/tonycox/flink/events","assignees_url":"https://api.github.com/repos/tonycox/flink/assignees{/user}","branches_url":"https://api.github.com/repos/tonycox/flink/branches{/branch}","tags_url":"https://api.github.com/repos/tonycox/flink/tags","blobs_url":"https://api.github.com/repos/tonycox/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tonycox/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tonycox/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/tonycox/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tonycox/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/tonycox/flink/languages","stargazers_url":"https://api.github.com/repos/tonycox/flink/stargazers","contributors_url":"https://api.github.com/repos/tonycox/flink/contributors","subscribers_url":"https://api.github.com/repos/tonycox/flink/subscribers","subscription_url":"https://api.github.com/repos/tonycox/flink/subscription","commits_url":"https://api.github.com/repos/tonycox/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/tonycox/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/tonycox/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/tonycox/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/tonycox/flink/contents/{+path}","compare_url":"https://api.github.com/repos/tonycox/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tonycox/flink/merges","archive_url":"https://api.github.com/repos/tonycox/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tonycox/flink/downloads","issues_url":"https://api.github.com/repos/tonycox/flink/issues{/number}","pulls_url":"https://api.github.com/repos/tonycox/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/tonycox/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/tonycox/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tonycox/flink/labels{/name}","releases_url":"https://api.github.com/repos/tonycox/flink/releases{/id}","deployments_url":"https://api.github.com/repos/tonycox/flink/deployments","created_at":"2016-09-30T12:26:44Z","updated_at":"2016-09-30T12:27:03Z","pushed_at":"2016-12-14T09:48:03Z","git_url":"git://github.com/tonycox/flink.git","ssh_url":"git@github.com:tonycox/flink.git","clone_url":"https://github.com/tonycox/flink.git","svn_url":"https://github.com/tonycox/flink","homepage":null,"size":108377,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"8a7288ea9af6b6822ea1f4022bb08a10b7b82318","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2016-12-13T16:56:48Z","pushed_at":"2016-12-14T09:48:04Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":109521,"stargazers_count":1820,"watchers_count":1820,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1244,"mirror_url":"git://git.apache.org/flink.git","open_issues_count":201,"forks":1244,"open_issues":201,"watchers":1820,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/3003"},"html":{"href":"https://github.com/apache/flink/pull/3003"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/3003"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/3003/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/3003/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/3003/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/b94b5a765fe4bfbc09e1769ce5f297fae3fc0628"}}}}
{"actor":{"display_login":"fhueske"}}