{"action":"created","issue":{"url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/1538","labels_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/1538/labels{/name}","comments_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/1538/comments","events_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/1538/events","html_url":"https://github.com/react-bootstrap/react-bootstrap/issues/1538","id":119794451,"number":1538,"title":"Modal doesn't guarantee listener clean up","user":{"login":"joshgagnon","id":850974,"avatar_url":"https://avatars.githubusercontent.com/u/850974?v=3","gravatar_id":"","url":"https://api.github.com/users/joshgagnon","html_url":"https://github.com/joshgagnon","followers_url":"https://api.github.com/users/joshgagnon/followers","following_url":"https://api.github.com/users/joshgagnon/following{/other_user}","gists_url":"https://api.github.com/users/joshgagnon/gists{/gist_id}","starred_url":"https://api.github.com/users/joshgagnon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshgagnon/subscriptions","organizations_url":"https://api.github.com/users/joshgagnon/orgs","repos_url":"https://api.github.com/users/joshgagnon/repos","events_url":"https://api.github.com/users/joshgagnon/events{/privacy}","received_events_url":"https://api.github.com/users/joshgagnon/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-12-01T19:55:24Z","updated_at":"2016-01-20T04:05:01Z","closed_at":"2015-12-24T01:53:33Z","body":"The window resize handler for a modal is controlled by [Modal._onHide](https://github.com/react-bootstrap/react-bootstrap/blob/master/src/Modal.js#L175),  but there is no guarantee that this function will be called by the child base modal component.\r\n\r\nThis leads to a bug where after a modal is closed, a window resize event can throw an error due to the component no longer existing.\r\n\r\nI'm unsure of the best way to ensure cleanup other than adding it to componentWillUnmount (I am currently doing this as a workaround)."},"comment":{"url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/comments/173079237","html_url":"https://github.com/react-bootstrap/react-bootstrap/issues/1538#issuecomment-173079237","issue_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/1538","id":173079237,"user":{"login":"taion","id":3112159,"avatar_url":"https://avatars.githubusercontent.com/u/3112159?v=3","gravatar_id":"","url":"https://api.github.com/users/taion","html_url":"https://github.com/taion","followers_url":"https://api.github.com/users/taion/followers","following_url":"https://api.github.com/users/taion/following{/other_user}","gists_url":"https://api.github.com/users/taion/gists{/gist_id}","starred_url":"https://api.github.com/users/taion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taion/subscriptions","organizations_url":"https://api.github.com/users/taion/orgs","repos_url":"https://api.github.com/users/taion/repos","events_url":"https://api.github.com/users/taion/events{/privacy}","received_events_url":"https://api.github.com/users/taion/received_events","type":"User","site_admin":false},"created_at":"2016-01-20T04:05:01Z","updated_at":"2016-01-20T04:05:01Z","body":"We're pretty confident this is fully fixed in the latest release. Make sure you've updated everything correctly."}}