{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-quickstep/issues/97","repository_url":"https://api.github.com/repos/apache/incubator-quickstep","labels_url":"https://api.github.com/repos/apache/incubator-quickstep/issues/97/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-quickstep/issues/97/comments","events_url":"https://api.github.com/repos/apache/incubator-quickstep/issues/97/events","html_url":"https://github.com/apache/incubator-quickstep/pull/97","id":174358758,"number":97,"title":"QUICKSTEP-44 Separate Date type from Datetime type","user":{"login":"hbdeshmukh","id":3750801,"avatar_url":"https://avatars.githubusercontent.com/u/3750801?v=3","gravatar_id":"","url":"https://api.github.com/users/hbdeshmukh","html_url":"https://github.com/hbdeshmukh","followers_url":"https://api.github.com/users/hbdeshmukh/followers","following_url":"https://api.github.com/users/hbdeshmukh/following{/other_user}","gists_url":"https://api.github.com/users/hbdeshmukh/gists{/gist_id}","starred_url":"https://api.github.com/users/hbdeshmukh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbdeshmukh/subscriptions","organizations_url":"https://api.github.com/users/hbdeshmukh/orgs","repos_url":"https://api.github.com/users/hbdeshmukh/repos","events_url":"https://api.github.com/users/hbdeshmukh/events{/privacy}","received_events_url":"https://api.github.com/users/hbdeshmukh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-31T19:33:20Z","updated_at":"2016-09-05T09:59:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-quickstep/pulls/97","html_url":"https://github.com/apache/incubator-quickstep/pull/97","diff_url":"https://github.com/apache/incubator-quickstep/pull/97.diff","patch_url":"https://github.com/apache/incubator-quickstep/pull/97.patch"},"body":"- Beginning from the parser to the operator execution level, treat Date type\r\n  sepearately than the Datetime type.\r\n- Provide support for the extract function when applied on the Date\r\n  type, implemented in the DateExtractOperation.\r\n- Modified the tests.\r\n\r\nRunning the following query on master vs this branch on TPC-H SF100 dataset:\r\n\r\n``SELECT EXTRACT(year FROM o_orderdate) AS orderyear FROM orders;``\r\n\r\n| Master  | datetype-fix |\r\n| ------------- | ------------- |\r\n| 31700 ms  | 256 ms |\r\n\r\nThe reason for the performance improvement is because in the earlier implementation, a temporary date was created using the ``gmtime_r`` function call, which involves acquiring a mutex lock. In this branch, we don't need such locks as the extract function only works on the given date, stored in the storage blocks. "},"comment":{"url":"https://api.github.com/repos/apache/incubator-quickstep/issues/comments/244708588","html_url":"https://github.com/apache/incubator-quickstep/pull/97#issuecomment-244708588","issue_url":"https://api.github.com/repos/apache/incubator-quickstep/issues/97","id":244708588,"user":{"login":"pateljm","id":8864916,"avatar_url":"https://avatars.githubusercontent.com/u/8864916?v=3","gravatar_id":"","url":"https://api.github.com/users/pateljm","html_url":"https://github.com/pateljm","followers_url":"https://api.github.com/users/pateljm/followers","following_url":"https://api.github.com/users/pateljm/following{/other_user}","gists_url":"https://api.github.com/users/pateljm/gists{/gist_id}","starred_url":"https://api.github.com/users/pateljm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pateljm/subscriptions","organizations_url":"https://api.github.com/users/pateljm/orgs","repos_url":"https://api.github.com/users/pateljm/repos","events_url":"https://api.github.com/users/pateljm/events{/privacy}","received_events_url":"https://api.github.com/users/pateljm/received_events","type":"User","site_admin":false},"created_at":"2016-09-05T09:59:44Z","updated_at":"2016-09-05T09:59:44Z","body":"With the fix to the spelling name above, shall we close this PR? @hbdeshmukh @zuyu Thanks!"}}
{"actor":{"display_login":"pateljm"}}