{"action":"created","comment":{"url":"https://api.github.com/repos/talis/persona-php-client/pulls/comments/60027030","id":60027030,"diff_hunk":"@@ -55,40 +57,50 @@\n     private $defaultTtl;\n \n     /**\n+     * @var string\n+     */\n+    private $appUserAgent;\n+\n+    /**\n      * Constructor\n      *\n+     * @param string $appUserAgent Consuming application user agent string @since 2.0.0\n+     *      examples: rl/5.2 (php/5.3), rl, rl/5, rl/5.2(php/5.3; linux/2.5)\n      * @param array $config An array of options with the following keys: <pre>\n      *      persona_host: (string) the persona host you'll be making requests to (e.g. 'http://localhost')\n      *      persona_oauth_route: (string) the token api route to query ( e.g: '/oauth/tokens')\n      *      cacheBackend: (Doctrine\\Common\\Cache\\CacheProvider) optional cache storage (defaults to Filesystem)\n      *      cacheKeyPrefix: (string) optional prefix to append to the cache keys\n      *      cacheDefaultTTL: (integer) optional cache TTL value\n-     * @param @deprecated $logger optional logger instance\n-     * @param @deprecated $cacheBackend optional cache backend see\n-     *  https://github.com/doctrine/cache/tree/master/lib/Doctrine/Common/Cache\n-     *  https://doctrine-orm.readthedocs.org/projects/doctrine-orm/en/latest/reference/caching.html\n      * @throws \\InvalidArgumentException if any of the required config parameters are missing\n-     * \n+     * @throws \\InvalidArgumentException if the user agent format is invalid\n      */\n     public function __construct(\n-        array $config,\n-        \\Psr\\Log\\LoggerInterface $logger = null,\n-        CacheProvider $cacheBackend = null\n+        $appUserAgent,","path":"src/Talis/Persona/Client/Base.php","position":42,"original_position":42,"commit_id":"f463766ae90a90100d375d9b941e3432c2d5daf6","original_commit_id":"25d58fe05ac98cb102b19e41b4f8094524b929e4","user":{"login":"rgubby","id":5399177,"avatar_url":"https://avatars.githubusercontent.com/u/5399177?v=3","gravatar_id":"","url":"https://api.github.com/users/rgubby","html_url":"https://github.com/rgubby","followers_url":"https://api.github.com/users/rgubby/followers","following_url":"https://api.github.com/users/rgubby/following{/other_user}","gists_url":"https://api.github.com/users/rgubby/gists{/gist_id}","starred_url":"https://api.github.com/users/rgubby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgubby/subscriptions","organizations_url":"https://api.github.com/users/rgubby/orgs","repos_url":"https://api.github.com/users/rgubby/repos","events_url":"https://api.github.com/users/rgubby/events{/privacy}","received_events_url":"https://api.github.com/users/rgubby/received_events","type":"User","site_admin":false},"body":"Just for my benefit as i may have missed the convo on this, but why is passing a UA string into here mandatory?","created_at":"2016-04-18T09:12:09Z","updated_at":"2016-04-18T09:12:09Z","html_url":"https://github.com/talis/persona-php-client/pull/27#discussion_r60027030","pull_request_url":"https://api.github.com/repos/talis/persona-php-client/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/talis/persona-php-client/pulls/comments/60027030"},"html":{"href":"https://github.com/talis/persona-php-client/pull/27#discussion_r60027030"},"pull_request":{"href":"https://api.github.com/repos/talis/persona-php-client/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/talis/persona-php-client/pulls/27","id":66625804,"html_url":"https://github.com/talis/persona-php-client/pull/27","diff_url":"https://github.com/talis/persona-php-client/pull/27.diff","patch_url":"https://github.com/talis/persona-php-client/pull/27.patch","issue_url":"https://api.github.com/repos/talis/persona-php-client/issues/27","number":27,"state":"open","locked":false,"title":"90% - PLAT-207 - Token Cache TTL Leeway","user":{"login":"markwallsgrove","id":6328824,"avatar_url":"https://avatars.githubusercontent.com/u/6328824?v=3","gravatar_id":"","url":"https://api.github.com/users/markwallsgrove","html_url":"https://github.com/markwallsgrove","followers_url":"https://api.github.com/users/markwallsgrove/followers","following_url":"https://api.github.com/users/markwallsgrove/following{/other_user}","gists_url":"https://api.github.com/users/markwallsgrove/gists{/gist_id}","starred_url":"https://api.github.com/users/markwallsgrove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markwallsgrove/subscriptions","organizations_url":"https://api.github.com/users/markwallsgrove/orgs","repos_url":"https://api.github.com/users/markwallsgrove/repos","events_url":"https://api.github.com/users/markwallsgrove/events{/privacy}","received_events_url":"https://api.github.com/users/markwallsgrove/received_events","type":"User","site_admin":false},"body":" - [x] 60 second leeway to the token cache to avoid the token becoming invalid\r\n - [x] unique request id to track requests through the system\r\n - [x] user agent string to identify where requests have come from\r\n - [x] depreciated 2 parameters on Base\r\n\r\nfixes https://github.com/talis/platform/issues/207","created_at":"2016-04-15T11:07:03Z","updated_at":"2016-04-18T09:12:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11ac171def73324df06c505128124a5eec96ee2c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/talis/persona-php-client/pulls/27/commits","review_comments_url":"https://api.github.com/repos/talis/persona-php-client/pulls/27/comments","review_comment_url":"https://api.github.com/repos/talis/persona-php-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/talis/persona-php-client/issues/27/comments","statuses_url":"https://api.github.com/repos/talis/persona-php-client/statuses/f463766ae90a90100d375d9b941e3432c2d5daf6","head":{"label":"talis:PLAT-207-DecreaseCacheTTL","ref":"PLAT-207-DecreaseCacheTTL","sha":"f463766ae90a90100d375d9b941e3432c2d5daf6","user":{"login":"talis","id":181416,"avatar_url":"https://avatars.githubusercontent.com/u/181416?v=3","gravatar_id":"","url":"https://api.github.com/users/talis","html_url":"https://github.com/talis","followers_url":"https://api.github.com/users/talis/followers","following_url":"https://api.github.com/users/talis/following{/other_user}","gists_url":"https://api.github.com/users/talis/gists{/gist_id}","starred_url":"https://api.github.com/users/talis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talis/subscriptions","organizations_url":"https://api.github.com/users/talis/orgs","repos_url":"https://api.github.com/users/talis/repos","events_url":"https://api.github.com/users/talis/events{/privacy}","received_events_url":"https://api.github.com/users/talis/received_events","type":"Organization","site_admin":false},"repo":{"id":16688350,"name":"persona-php-client","full_name":"talis/persona-php-client","owner":{"login":"talis","id":181416,"avatar_url":"https://avatars.githubusercontent.com/u/181416?v=3","gravatar_id":"","url":"https://api.github.com/users/talis","html_url":"https://github.com/talis","followers_url":"https://api.github.com/users/talis/followers","following_url":"https://api.github.com/users/talis/following{/other_user}","gists_url":"https://api.github.com/users/talis/gists{/gist_id}","starred_url":"https://api.github.com/users/talis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talis/subscriptions","organizations_url":"https://api.github.com/users/talis/orgs","repos_url":"https://api.github.com/users/talis/repos","events_url":"https://api.github.com/users/talis/events{/privacy}","received_events_url":"https://api.github.com/users/talis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/talis/persona-php-client","description":"This is a php client library for Persona supporting generation, validation and caching of Oauth Tokens","fork":false,"url":"https://api.github.com/repos/talis/persona-php-client","forks_url":"https://api.github.com/repos/talis/persona-php-client/forks","keys_url":"https://api.github.com/repos/talis/persona-php-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/talis/persona-php-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/talis/persona-php-client/teams","hooks_url":"https://api.github.com/repos/talis/persona-php-client/hooks","issue_events_url":"https://api.github.com/repos/talis/persona-php-client/issues/events{/number}","events_url":"https://api.github.com/repos/talis/persona-php-client/events","assignees_url":"https://api.github.com/repos/talis/persona-php-client/assignees{/user}","branches_url":"https://api.github.com/repos/talis/persona-php-client/branches{/branch}","tags_url":"https://api.github.com/repos/talis/persona-php-client/tags","blobs_url":"https://api.github.com/repos/talis/persona-php-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/talis/persona-php-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/talis/persona-php-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/talis/persona-php-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/talis/persona-php-client/statuses/{sha}","languages_url":"https://api.github.com/repos/talis/persona-php-client/languages","stargazers_url":"https://api.github.com/repos/talis/persona-php-client/stargazers","contributors_url":"https://api.github.com/repos/talis/persona-php-client/contributors","subscribers_url":"https://api.github.com/repos/talis/persona-php-client/subscribers","subscription_url":"https://api.github.com/repos/talis/persona-php-client/subscription","commits_url":"https://api.github.com/repos/talis/persona-php-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/talis/persona-php-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/talis/persona-php-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/talis/persona-php-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/talis/persona-php-client/contents/{+path}","compare_url":"https://api.github.com/repos/talis/persona-php-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/talis/persona-php-client/merges","archive_url":"https://api.github.com/repos/talis/persona-php-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/talis/persona-php-client/downloads","issues_url":"https://api.github.com/repos/talis/persona-php-client/issues{/number}","pulls_url":"https://api.github.com/repos/talis/persona-php-client/pulls{/number}","milestones_url":"https://api.github.com/repos/talis/persona-php-client/milestones{/number}","notifications_url":"https://api.github.com/repos/talis/persona-php-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/talis/persona-php-client/labels{/name}","releases_url":"https://api.github.com/repos/talis/persona-php-client/releases{/id}","deployments_url":"https://api.github.com/repos/talis/persona-php-client/deployments","created_at":"2014-02-10T07:57:51Z","updated_at":"2016-03-04T09:45:34Z","pushed_at":"2016-04-18T09:03:38Z","git_url":"git://github.com/talis/persona-php-client.git","ssh_url":"git@github.com:talis/persona-php-client.git","clone_url":"https://github.com/talis/persona-php-client.git","svn_url":"https://github.com/talis/persona-php-client","homepage":null,"size":167,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"talis:master","ref":"master","sha":"f672ffba19f7d59978e124a9a4c6cf4f831dba85","user":{"login":"talis","id":181416,"avatar_url":"https://avatars.githubusercontent.com/u/181416?v=3","gravatar_id":"","url":"https://api.github.com/users/talis","html_url":"https://github.com/talis","followers_url":"https://api.github.com/users/talis/followers","following_url":"https://api.github.com/users/talis/following{/other_user}","gists_url":"https://api.github.com/users/talis/gists{/gist_id}","starred_url":"https://api.github.com/users/talis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talis/subscriptions","organizations_url":"https://api.github.com/users/talis/orgs","repos_url":"https://api.github.com/users/talis/repos","events_url":"https://api.github.com/users/talis/events{/privacy}","received_events_url":"https://api.github.com/users/talis/received_events","type":"Organization","site_admin":false},"repo":{"id":16688350,"name":"persona-php-client","full_name":"talis/persona-php-client","owner":{"login":"talis","id":181416,"avatar_url":"https://avatars.githubusercontent.com/u/181416?v=3","gravatar_id":"","url":"https://api.github.com/users/talis","html_url":"https://github.com/talis","followers_url":"https://api.github.com/users/talis/followers","following_url":"https://api.github.com/users/talis/following{/other_user}","gists_url":"https://api.github.com/users/talis/gists{/gist_id}","starred_url":"https://api.github.com/users/talis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talis/subscriptions","organizations_url":"https://api.github.com/users/talis/orgs","repos_url":"https://api.github.com/users/talis/repos","events_url":"https://api.github.com/users/talis/events{/privacy}","received_events_url":"https://api.github.com/users/talis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/talis/persona-php-client","description":"This is a php client library for Persona supporting generation, validation and caching of Oauth Tokens","fork":false,"url":"https://api.github.com/repos/talis/persona-php-client","forks_url":"https://api.github.com/repos/talis/persona-php-client/forks","keys_url":"https://api.github.com/repos/talis/persona-php-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/talis/persona-php-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/talis/persona-php-client/teams","hooks_url":"https://api.github.com/repos/talis/persona-php-client/hooks","issue_events_url":"https://api.github.com/repos/talis/persona-php-client/issues/events{/number}","events_url":"https://api.github.com/repos/talis/persona-php-client/events","assignees_url":"https://api.github.com/repos/talis/persona-php-client/assignees{/user}","branches_url":"https://api.github.com/repos/talis/persona-php-client/branches{/branch}","tags_url":"https://api.github.com/repos/talis/persona-php-client/tags","blobs_url":"https://api.github.com/repos/talis/persona-php-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/talis/persona-php-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/talis/persona-php-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/talis/persona-php-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/talis/persona-php-client/statuses/{sha}","languages_url":"https://api.github.com/repos/talis/persona-php-client/languages","stargazers_url":"https://api.github.com/repos/talis/persona-php-client/stargazers","contributors_url":"https://api.github.com/repos/talis/persona-php-client/contributors","subscribers_url":"https://api.github.com/repos/talis/persona-php-client/subscribers","subscription_url":"https://api.github.com/repos/talis/persona-php-client/subscription","commits_url":"https://api.github.com/repos/talis/persona-php-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/talis/persona-php-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/talis/persona-php-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/talis/persona-php-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/talis/persona-php-client/contents/{+path}","compare_url":"https://api.github.com/repos/talis/persona-php-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/talis/persona-php-client/merges","archive_url":"https://api.github.com/repos/talis/persona-php-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/talis/persona-php-client/downloads","issues_url":"https://api.github.com/repos/talis/persona-php-client/issues{/number}","pulls_url":"https://api.github.com/repos/talis/persona-php-client/pulls{/number}","milestones_url":"https://api.github.com/repos/talis/persona-php-client/milestones{/number}","notifications_url":"https://api.github.com/repos/talis/persona-php-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/talis/persona-php-client/labels{/name}","releases_url":"https://api.github.com/repos/talis/persona-php-client/releases{/id}","deployments_url":"https://api.github.com/repos/talis/persona-php-client/deployments","created_at":"2014-02-10T07:57:51Z","updated_at":"2016-03-04T09:45:34Z","pushed_at":"2016-04-18T09:03:38Z","git_url":"git://github.com/talis/persona-php-client.git","ssh_url":"git@github.com:talis/persona-php-client.git","clone_url":"https://github.com/talis/persona-php-client.git","svn_url":"https://github.com/talis/persona-php-client","homepage":null,"size":167,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/talis/persona-php-client/pulls/27"},"html":{"href":"https://github.com/talis/persona-php-client/pull/27"},"issue":{"href":"https://api.github.com/repos/talis/persona-php-client/issues/27"},"comments":{"href":"https://api.github.com/repos/talis/persona-php-client/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/talis/persona-php-client/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/talis/persona-php-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/talis/persona-php-client/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/talis/persona-php-client/statuses/f463766ae90a90100d375d9b941e3432c2d5daf6"}}}}