{"action":"created","issue":{"url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/971","repository_url":"https://api.github.com/repos/simplabs/ember-simple-auth","labels_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/971/labels{/name}","comments_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/971/comments","events_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/971/events","html_url":"https://github.com/simplabs/ember-simple-auth/pull/971","id":150994446,"number":971,"title":"WIP Extend Router DSL  #904","user":{"login":"ryanlabouve","id":1318878,"avatar_url":"https://avatars.githubusercontent.com/u/1318878?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanlabouve","html_url":"https://github.com/ryanlabouve","followers_url":"https://api.github.com/users/ryanlabouve/followers","following_url":"https://api.github.com/users/ryanlabouve/following{/other_user}","gists_url":"https://api.github.com/users/ryanlabouve/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanlabouve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanlabouve/subscriptions","organizations_url":"https://api.github.com/users/ryanlabouve/orgs","repos_url":"https://api.github.com/users/ryanlabouve/repos","events_url":"https://api.github.com/users/ryanlabouve/events{/privacy}","received_events_url":"https://api.github.com/users/ryanlabouve/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ryanlabouve","id":1318878,"avatar_url":"https://avatars.githubusercontent.com/u/1318878?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanlabouve","html_url":"https://github.com/ryanlabouve","followers_url":"https://api.github.com/users/ryanlabouve/followers","following_url":"https://api.github.com/users/ryanlabouve/following{/other_user}","gists_url":"https://api.github.com/users/ryanlabouve/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanlabouve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanlabouve/subscriptions","organizations_url":"https://api.github.com/users/ryanlabouve/orgs","repos_url":"https://api.github.com/users/ryanlabouve/repos","events_url":"https://api.github.com/users/ryanlabouve/events{/privacy}","received_events_url":"https://api.github.com/users/ryanlabouve/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/simplabs/ember-simple-auth/milestones/23","html_url":"https://github.com/simplabs/ember-simple-auth/milestones/1.2","labels_url":"https://api.github.com/repos/simplabs/ember-simple-auth/milestones/23/labels","id":1570361,"number":23,"title":"1.2","description":"","creator":{"login":"marcoow","id":1510,"avatar_url":"https://avatars.githubusercontent.com/u/1510?v=3","gravatar_id":"","url":"https://api.github.com/users/marcoow","html_url":"https://github.com/marcoow","followers_url":"https://api.github.com/users/marcoow/followers","following_url":"https://api.github.com/users/marcoow/following{/other_user}","gists_url":"https://api.github.com/users/marcoow/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoow/subscriptions","organizations_url":"https://api.github.com/users/marcoow/orgs","repos_url":"https://api.github.com/users/marcoow/repos","events_url":"https://api.github.com/users/marcoow/events{/privacy}","received_events_url":"https://api.github.com/users/marcoow/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":8,"state":"open","created_at":"2016-02-08T13:37:28Z","updated_at":"2016-06-15T15:18:46Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-04-25T22:10:14Z","updated_at":"2016-06-16T06:58:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/971","html_url":"https://github.com/simplabs/ember-simple-auth/pull/971","diff_url":"https://github.com/simplabs/ember-simple-auth/pull/971.diff","patch_url":"https://github.com/simplabs/ember-simple-auth/pull/971.patch"},"body":"Opening a WIP PR since this issue had quite a bit of activity today to give some transparency with where things are at.\r\n\r\nI'm definitely welcome to suggestions! Here's my current list of questions:\r\n\r\n* How should we handle `authenticatedRoute` name conflict?\r\n* How should we bring over the container utilities?\r\n* Any suggestions on tests?\r\n\r\nWill make some more progress on this tonight. After we figure out how to handle the name conflict, expanding to handle authenticatedRoute will be easy.\r\n\r\n#### There is a name conflict with `authenticatedRoute` via torii\r\n\r\nSince torii is currently using `this.unauthenticatedRoute` on Router, we have no way to distinguish whether they want torii or ESA mixins.\r\n\r\nShould we somehow namespace our new routes to Ember Simple Auth? (That's why I started with `unauthenticatedRoute`.)\r\n\r\n#### Should we combine container utilities into one file?\r\n\r\nSeveral container utilities are needed for registering the mixin on a given route. `addon/utils/lookup.js` is an example of one that ESA already had. Grabbed `register` and `lookup-factory` from troii. Should we consolidate this into one file in ESA, pull out into independent addon, or leave in different files?\r\n\r\n`addon/utils/lookup.js`\r\n`addon/utils/register.js` from https://github.com/Vestorly/torii/blob/master/addon/lib/container-utils.js\r\n\r\n`addon/utils/lookup-factory.js` from https://github.com/Vestorly/torii/blob/master/addon/lib/container-utils.js\r\n\r\n#### Still working on the tests.\r\n\r\nSuggestions welcome. I still want to verify that `addon/bootstrap/routing.js` is properly applying a mixin via test. Will probalby break this out into its own unit test.\r\n\r\nMay rethink some of the tests based off of reading https://github.com/Vestorly/torii/blob/master/tests/acceptance/routing-test.js. (Probably should have done that much earlier)\r\n\r\n/cc @mdentremont"},"comment":{"url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/comments/226403527","html_url":"https://github.com/simplabs/ember-simple-auth/pull/971#issuecomment-226403527","issue_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/971","id":226403527,"user":{"login":"mtangoo","id":1502872,"avatar_url":"https://avatars.githubusercontent.com/u/1502872?v=3","gravatar_id":"","url":"https://api.github.com/users/mtangoo","html_url":"https://github.com/mtangoo","followers_url":"https://api.github.com/users/mtangoo/followers","following_url":"https://api.github.com/users/mtangoo/following{/other_user}","gists_url":"https://api.github.com/users/mtangoo/gists{/gist_id}","starred_url":"https://api.github.com/users/mtangoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtangoo/subscriptions","organizations_url":"https://api.github.com/users/mtangoo/orgs","repos_url":"https://api.github.com/users/mtangoo/repos","events_url":"https://api.github.com/users/mtangoo/events{/privacy}","received_events_url":"https://api.github.com/users/mtangoo/received_events","type":"User","site_admin":false},"created_at":"2016-06-16T06:58:14Z","updated_at":"2016-06-16T06:58:14Z","body":"Thanks,  @marcow. Didn't know that "}}
{"actor":{"display_login":"mtangoo"}}