{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/72665062","id":72665062,"diff_hunk":"@@ -265,6 +269,10 @@ func (t *http2Server) HandleStreams(handle func(*Stream)) {\n \t\t\t\tt.controlBuf.put(&resetStream{se.StreamID, se.Code})\n \t\t\t\tcontinue\n \t\t\t}\n+\t\t\tif err == io.EOF || err == io.ErrUnexpectedEOF {\n+\t\t\t\tt.Close()\n+\t\t\t\treturn\n+\t\t\t}","path":"transport/http2_server.go","position":18,"original_position":18,"commit_id":"9b2081cd39613bef19f7680900e51c428687e5ea","original_commit_id":"9b2081cd39613bef19f7680900e51c428687e5ea","user":{"login":"iamqizhao","id":10121772,"avatar_url":"https://avatars.githubusercontent.com/u/10121772?v=3","gravatar_id":"","url":"https://api.github.com/users/iamqizhao","html_url":"https://github.com/iamqizhao","followers_url":"https://api.github.com/users/iamqizhao/followers","following_url":"https://api.github.com/users/iamqizhao/following{/other_user}","gists_url":"https://api.github.com/users/iamqizhao/gists{/gist_id}","starred_url":"https://api.github.com/users/iamqizhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamqizhao/subscriptions","organizations_url":"https://api.github.com/users/iamqizhao/orgs","repos_url":"https://api.github.com/users/iamqizhao/repos","events_url":"https://api.github.com/users/iamqizhao/events{/privacy}","received_events_url":"https://api.github.com/users/iamqizhao/received_events","type":"User","site_admin":false},"body":"The above block is not need because t.Close is called in line#277.","created_at":"2016-07-28T17:28:22Z","updated_at":"2016-07-28T17:28:22Z","html_url":"https://github.com/grpc/grpc-go/pull/787#discussion_r72665062","pull_request_url":"https://api.github.com/repos/grpc/grpc-go/pulls/787","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/72665062"},"html":{"href":"https://github.com/grpc/grpc-go/pull/787#discussion_r72665062"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/787"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/787","id":79212362,"html_url":"https://github.com/grpc/grpc-go/pull/787","diff_url":"https://github.com/grpc/grpc-go/pull/787.diff","patch_url":"https://github.com/grpc/grpc-go/pull/787.patch","issue_url":"https://api.github.com/repos/grpc/grpc-go/issues/787","number":787,"state":"open","locked":false,"title":"Fixing #786","user":{"login":"cube2222","id":7013055,"avatar_url":"https://avatars.githubusercontent.com/u/7013055?v=3","gravatar_id":"","url":"https://api.github.com/users/cube2222","html_url":"https://github.com/cube2222","followers_url":"https://api.github.com/users/cube2222/followers","following_url":"https://api.github.com/users/cube2222/following{/other_user}","gists_url":"https://api.github.com/users/cube2222/gists{/gist_id}","starred_url":"https://api.github.com/users/cube2222/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cube2222/subscriptions","organizations_url":"https://api.github.com/users/cube2222/orgs","repos_url":"https://api.github.com/users/cube2222/repos","events_url":"https://api.github.com/users/cube2222/events{/privacy}","received_events_url":"https://api.github.com/users/cube2222/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-28T15:03:42Z","updated_at":"2016-07-28T17:28:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99f8b81da86fdaf5b19a4646c342af75d9209096","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-go/pulls/787/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-go/pulls/787/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-go/issues/787/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/9b2081cd39613bef19f7680900e51c428687e5ea","head":{"label":"cube2222:master","ref":"master","sha":"9b2081cd39613bef19f7680900e51c428687e5ea","user":{"login":"cube2222","id":7013055,"avatar_url":"https://avatars.githubusercontent.com/u/7013055?v=3","gravatar_id":"","url":"https://api.github.com/users/cube2222","html_url":"https://github.com/cube2222","followers_url":"https://api.github.com/users/cube2222/followers","following_url":"https://api.github.com/users/cube2222/following{/other_user}","gists_url":"https://api.github.com/users/cube2222/gists{/gist_id}","starred_url":"https://api.github.com/users/cube2222/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cube2222/subscriptions","organizations_url":"https://api.github.com/users/cube2222/orgs","repos_url":"https://api.github.com/users/cube2222/repos","events_url":"https://api.github.com/users/cube2222/events{/privacy}","received_events_url":"https://api.github.com/users/cube2222/received_events","type":"User","site_admin":false},"repo":{"id":64403658,"name":"grpc-go","full_name":"cube2222/grpc-go","owner":{"login":"cube2222","id":7013055,"avatar_url":"https://avatars.githubusercontent.com/u/7013055?v=3","gravatar_id":"","url":"https://api.github.com/users/cube2222","html_url":"https://github.com/cube2222","followers_url":"https://api.github.com/users/cube2222/followers","following_url":"https://api.github.com/users/cube2222/following{/other_user}","gists_url":"https://api.github.com/users/cube2222/gists{/gist_id}","starred_url":"https://api.github.com/users/cube2222/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cube2222/subscriptions","organizations_url":"https://api.github.com/users/cube2222/orgs","repos_url":"https://api.github.com/users/cube2222/repos","events_url":"https://api.github.com/users/cube2222/events{/privacy}","received_events_url":"https://api.github.com/users/cube2222/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cube2222/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/cube2222/grpc-go","forks_url":"https://api.github.com/repos/cube2222/grpc-go/forks","keys_url":"https://api.github.com/repos/cube2222/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cube2222/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cube2222/grpc-go/teams","hooks_url":"https://api.github.com/repos/cube2222/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/cube2222/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/cube2222/grpc-go/events","assignees_url":"https://api.github.com/repos/cube2222/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/cube2222/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/cube2222/grpc-go/tags","blobs_url":"https://api.github.com/repos/cube2222/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cube2222/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cube2222/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/cube2222/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cube2222/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/cube2222/grpc-go/languages","stargazers_url":"https://api.github.com/repos/cube2222/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/cube2222/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/cube2222/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/cube2222/grpc-go/subscription","commits_url":"https://api.github.com/repos/cube2222/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/cube2222/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/cube2222/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/cube2222/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/cube2222/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/cube2222/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cube2222/grpc-go/merges","archive_url":"https://api.github.com/repos/cube2222/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cube2222/grpc-go/downloads","issues_url":"https://api.github.com/repos/cube2222/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/cube2222/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/cube2222/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/cube2222/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cube2222/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/cube2222/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/cube2222/grpc-go/deployments","created_at":"2016-07-28T14:46:29Z","updated_at":"2016-07-28T14:46:30Z","pushed_at":"2016-07-28T15:01:46Z","git_url":"git://github.com/cube2222/grpc-go.git","ssh_url":"git@github.com:cube2222/grpc-go.git","clone_url":"https://github.com/cube2222/grpc-go.git","svn_url":"https://github.com/cube2222/grpc-go","homepage":"","size":2145,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"711a24cde281460b847b211686c2e4e8f4671131","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729907,"name":"grpc-go","full_name":"grpc/grpc-go","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-go","forks_url":"https://api.github.com/repos/grpc/grpc-go/forks","keys_url":"https://api.github.com/repos/grpc/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-go/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-go/events","assignees_url":"https://api.github.com/repos/grpc/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-go/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-go/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-go/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-go/merges","archive_url":"https://api.github.com/repos/grpc/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-go/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-go/deployments","created_at":"2014-12-08T18:59:34Z","updated_at":"2016-07-28T12:22:02Z","pushed_at":"2016-07-28T15:03:42Z","git_url":"git://github.com/grpc/grpc-go.git","ssh_url":"git@github.com:grpc/grpc-go.git","clone_url":"https://github.com/grpc/grpc-go.git","svn_url":"https://github.com/grpc/grpc-go","homepage":"","size":3108,"stargazers_count":1994,"watchers_count":1994,"language":"Go","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":311,"mirror_url":null,"open_issues_count":84,"forks":311,"open_issues":84,"watchers":1994,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/787"},"html":{"href":"https://github.com/grpc/grpc-go/pull/787"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/787"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/787/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/787/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/787/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-go/statuses/9b2081cd39613bef19f7680900e51c428687e5ea"}}}}
{"actor":{"display_login":"iamqizhao"}}