{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/5918","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/5918/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/5918/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/5918/events","html_url":"https://github.com/nodejs/node/pull/5918","id":143761862,"number":5918,"title":"configure: introduce --embedded","user":{"login":"indutny","id":238531,"avatar_url":"https://avatars.githubusercontent.com/u/238531?v=3","gravatar_id":"","url":"https://api.github.com/users/indutny","html_url":"https://github.com/indutny","followers_url":"https://api.github.com/users/indutny/followers","following_url":"https://api.github.com/users/indutny/following{/other_user}","gists_url":"https://api.github.com/users/indutny/gists{/gist_id}","starred_url":"https://api.github.com/users/indutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indutny/subscriptions","organizations_url":"https://api.github.com/users/indutny/orgs","repos_url":"https://api.github.com/users/indutny/repos","events_url":"https://api.github.com/users/indutny/events{/privacy}","received_events_url":"https://api.github.com/users/indutny/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/build","name":"build","color":"eb6420"},{"url":"https://api.github.com/repos/nodejs/node/labels/c++","name":"c++","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":20,"created_at":"2016-03-27T00:20:13Z","updated_at":"2016-05-16T22:35:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/5918","html_url":"https://github.com/nodejs/node/pull/5918","diff_url":"https://github.com/nodejs/node/pull/5918.diff","patch_url":"https://github.com/nodejs/node/pull/5918.patch"},"body":"### Pull Request check-list\r\n\r\n_Please make sure to review and check all of these items:_\r\n\r\n- [x] Does `make -j8 test` (UNIX) or `vcbuild test nosign` (Windows) pass with\r\n  this change (including linting)?\r\n- [x] Is the commit message formatted according to [CONTRIBUTING.md][0]?\r\n- [x] If this change fixes a bug (or a performance problem), is a regression\r\n  test (or a benchmark) included?\r\n- [x] Is a documentation update included (if this change modifies\r\n  existing APIs, or introduces new ones)?\r\n\r\n_NOTE: these things are not required to open a PR and can be done\r\nafterwards / while the PR is open._\r\n\r\n### Affected core subsystem(s)\r\n\r\n_node_\r\n\r\n[0]: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit\r\n\r\n### Description of change\r\n\r\nAdd configure flag for building shared library that could be used to\r\nembed node.js in some application (like Electron). This commit is\r\nesentially a merged and refined version of:\r\n\r\n* atom/node@289649a919d557182ff951589fc9859778206e4c\r\n* atom/node@f76669ffdcb8613133dc9c3764fb21c10207582e\r\n* atom/node@0828dfa193038209b7b337ba5479c3373f7cf87f"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/219569077","html_url":"https://github.com/nodejs/node/pull/5918#issuecomment-219569077","issue_url":"https://api.github.com/repos/nodejs/node/issues/5918","id":219569077,"user":{"login":"stefanmb","id":1356314,"avatar_url":"https://avatars.githubusercontent.com/u/1356314?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanmb","html_url":"https://github.com/stefanmb","followers_url":"https://api.github.com/users/stefanmb/followers","following_url":"https://api.github.com/users/stefanmb/following{/other_user}","gists_url":"https://api.github.com/users/stefanmb/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanmb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanmb/subscriptions","organizations_url":"https://api.github.com/users/stefanmb/orgs","repos_url":"https://api.github.com/users/stefanmb/repos","events_url":"https://api.github.com/users/stefanmb/events{/privacy}","received_events_url":"https://api.github.com/users/stefanmb/received_events","type":"User","site_admin":false},"created_at":"2016-05-16T22:35:42Z","updated_at":"2016-05-16T22:35:42Z","body":"I haven't had a chance to fully address all the issues but here is my work in progress: https://github.com/stefanmb/node/compare/stefanmb:cc0985b...stefanmb:v4.x-shared\r\n\r\nNote that I'm doing this against LTS first, but the changes for master are similar. The highlights are:\r\n\r\n1. Make the --shared version of Node compile-able outside of the Electron build system.\r\n2. Link with the MS C Runtime dynamically.\r\n\r\nThere are still many leftover issues:\r\n\r\na) Add some options to make it easier for Electron to embed (however, this is a political question as well - should we officially support a build process that replaces upstream dependencies)?\r\nb) Write a driver to initialize Node from the shared library and run all the tests against it.\r\nc) Make sure that addons still work correctly.\r\nd) Everything I'm forgetting. :)\r\n\r\nI hope to make more progress on this in the coming days, time allowing."}}