{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/comments/78250667","id":78250667,"diff_hunk":"@@ -199,6 +209,77 @@ func (c Cluster) Config() (*Config, error) {\n \t\tconfig.VPCRef = fmt.Sprintf(\"%q\", config.VPCID)\n \t}\n \n+\tconfig.EtcdInstances = make([]etcdInstance, config.EtcdCount)\n+\tvar etcdEndpoints, etcdInitialCluster bytes.Buffer\n+\tfor etcdIndex := 0; etcdIndex < config.EtcdCount; etcdIndex++ {\n+\n+\t\t//Round-robbin etcd instances across all available subnets\n+\t\tsubnetIndex := etcdIndex % len(config.Subnets)\n+\t\tsubnet := config.Subnets[subnetIndex]\n+\n+\t\t_, subnetCIDR, err := net.ParseCIDR(subnet.InstanceCIDR)\n+\t\tif err != nil {\n+\t\t\treturn nil, fmt.Errorf(\"error parsing subnet instance cidr %s: %v\", subnet.InstanceCIDR, err)\n+\t\t}\n+\n+\t\tif subnet.lastAllocatedAddr == nil {\n+\t\t\tip := subnetCIDR.IP\n+\t\t\t//TODO:(chom) this is sloppy, but \"soon-ish\" etcd with be self-hosted so we'll leave this be\n+\t\t\tfor i := 0; i < 3; i++ {\n+\t\t\t\tip = incrementIP(ip)","path":"multi-node/aws/pkg/config/config.go","position":83,"original_position":83,"commit_id":"bbe383ef0c0a0eef2d0abdb4cd234d32044c9dd3","original_commit_id":"bbe383ef0c0a0eef2d0abdb4cd234d32044c9dd3","user":{"login":"colhom","id":1075028,"avatar_url":"https://avatars.githubusercontent.com/u/1075028?v=3","gravatar_id":"","url":"https://api.github.com/users/colhom","html_url":"https://github.com/colhom","followers_url":"https://api.github.com/users/colhom/followers","following_url":"https://api.github.com/users/colhom/following{/other_user}","gists_url":"https://api.github.com/users/colhom/gists{/gist_id}","starred_url":"https://api.github.com/users/colhom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colhom/subscriptions","organizations_url":"https://api.github.com/users/colhom/orgs","repos_url":"https://api.github.com/users/colhom/repos","events_url":"https://api.github.com/users/colhom/events{/privacy}","received_events_url":"https://api.github.com/users/colhom/received_events","type":"User","site_admin":false},"body":"Not really- needed to pick a small offset, so 3 seemed like a good one.","created_at":"2016-09-09T21:18:16Z","updated_at":"2016-09-09T21:18:16Z","html_url":"https://github.com/coreos/coreos-kubernetes/pull/544#discussion_r78250667","pull_request_url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/544","_links":{"self":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/comments/78250667"},"html":{"href":"https://github.com/coreos/coreos-kubernetes/pull/544#discussion_r78250667"},"pull_request":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/544"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/544","id":73605499,"html_url":"https://github.com/coreos/coreos-kubernetes/pull/544","diff_url":"https://github.com/coreos/coreos-kubernetes/pull/544.diff","patch_url":"https://github.com/coreos/coreos-kubernetes/pull/544.patch","issue_url":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/544","number":544,"state":"open","locked":false,"title":"Discrete etcd cluster","user":{"login":"colhom","id":1075028,"avatar_url":"https://avatars.githubusercontent.com/u/1075028?v=3","gravatar_id":"","url":"https://api.github.com/users/colhom","html_url":"https://github.com/colhom","followers_url":"https://api.github.com/users/colhom/followers","following_url":"https://api.github.com/users/colhom/following{/other_user}","gists_url":"https://api.github.com/users/colhom/gists{/gist_id}","starred_url":"https://api.github.com/users/colhom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colhom/subscriptions","organizations_url":"https://api.github.com/users/colhom/orgs","repos_url":"https://api.github.com/users/colhom/repos","events_url":"https://api.github.com/users/colhom/events{/privacy}","received_events_url":"https://api.github.com/users/colhom/received_events","type":"User","site_admin":false},"body":"Work in progress- no review necessary yet (unless you're bored ;)","created_at":"2016-06-13T16:34:35Z","updated_at":"2016-09-09T21:18:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7f68ecefb368f0c7af4b7710503006cdea35f94","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/544/commits","review_comments_url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/544/comments","review_comment_url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/544/comments","statuses_url":"https://api.github.com/repos/coreos/coreos-kubernetes/statuses/bbe383ef0c0a0eef2d0abdb4cd234d32044c9dd3","head":{"label":"colhom:discrete-etcd-cluster","ref":"discrete-etcd-cluster","sha":"bbe383ef0c0a0eef2d0abdb4cd234d32044c9dd3","user":{"login":"colhom","id":1075028,"avatar_url":"https://avatars.githubusercontent.com/u/1075028?v=3","gravatar_id":"","url":"https://api.github.com/users/colhom","html_url":"https://github.com/colhom","followers_url":"https://api.github.com/users/colhom/followers","following_url":"https://api.github.com/users/colhom/following{/other_user}","gists_url":"https://api.github.com/users/colhom/gists{/gist_id}","starred_url":"https://api.github.com/users/colhom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colhom/subscriptions","organizations_url":"https://api.github.com/users/colhom/orgs","repos_url":"https://api.github.com/users/colhom/repos","events_url":"https://api.github.com/users/colhom/events{/privacy}","received_events_url":"https://api.github.com/users/colhom/received_events","type":"User","site_admin":false},"repo":{"id":43779482,"name":"coreos-kubernetes","full_name":"colhom/coreos-kubernetes","owner":{"login":"colhom","id":1075028,"avatar_url":"https://avatars.githubusercontent.com/u/1075028?v=3","gravatar_id":"","url":"https://api.github.com/users/colhom","html_url":"https://github.com/colhom","followers_url":"https://api.github.com/users/colhom/followers","following_url":"https://api.github.com/users/colhom/following{/other_user}","gists_url":"https://api.github.com/users/colhom/gists{/gist_id}","starred_url":"https://api.github.com/users/colhom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colhom/subscriptions","organizations_url":"https://api.github.com/users/colhom/orgs","repos_url":"https://api.github.com/users/colhom/repos","events_url":"https://api.github.com/users/colhom/events{/privacy}","received_events_url":"https://api.github.com/users/colhom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/colhom/coreos-kubernetes","description":"CoreOS+Kubernetes documentation, Vagrant & AWS installers","fork":true,"url":"https://api.github.com/repos/colhom/coreos-kubernetes","forks_url":"https://api.github.com/repos/colhom/coreos-kubernetes/forks","keys_url":"https://api.github.com/repos/colhom/coreos-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/colhom/coreos-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/colhom/coreos-kubernetes/teams","hooks_url":"https://api.github.com/repos/colhom/coreos-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/colhom/coreos-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/colhom/coreos-kubernetes/events","assignees_url":"https://api.github.com/repos/colhom/coreos-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/colhom/coreos-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/colhom/coreos-kubernetes/tags","blobs_url":"https://api.github.com/repos/colhom/coreos-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/colhom/coreos-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/colhom/coreos-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/colhom/coreos-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/colhom/coreos-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/colhom/coreos-kubernetes/languages","stargazers_url":"https://api.github.com/repos/colhom/coreos-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/colhom/coreos-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/colhom/coreos-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/colhom/coreos-kubernetes/subscription","commits_url":"https://api.github.com/repos/colhom/coreos-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/colhom/coreos-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/colhom/coreos-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/colhom/coreos-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/colhom/coreos-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/colhom/coreos-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/colhom/coreos-kubernetes/merges","archive_url":"https://api.github.com/repos/colhom/coreos-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/colhom/coreos-kubernetes/downloads","issues_url":"https://api.github.com/repos/colhom/coreos-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/colhom/coreos-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/colhom/coreos-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/colhom/coreos-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/colhom/coreos-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/colhom/coreos-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/colhom/coreos-kubernetes/deployments","created_at":"2015-10-06T21:21:15Z","updated_at":"2016-02-23T08:59:19Z","pushed_at":"2016-09-09T20:12:20Z","git_url":"git://github.com/colhom/coreos-kubernetes.git","ssh_url":"git@github.com:colhom/coreos-kubernetes.git","clone_url":"https://github.com/colhom/coreos-kubernetes.git","svn_url":"https://github.com/colhom/coreos-kubernetes","homepage":"https://coreos.com/kubernetes/docs/latest/","size":28385,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"de727bc27ef2d65b8af556f7f76c122220019bf5","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":41458519,"name":"coreos-kubernetes","full_name":"coreos/coreos-kubernetes","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/coreos-kubernetes","description":"CoreOS+Kubernetes documentation, Vagrant & AWS installers","fork":false,"url":"https://api.github.com/repos/coreos/coreos-kubernetes","forks_url":"https://api.github.com/repos/coreos/coreos-kubernetes/forks","keys_url":"https://api.github.com/repos/coreos/coreos-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/coreos-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/coreos-kubernetes/teams","hooks_url":"https://api.github.com/repos/coreos/coreos-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/coreos-kubernetes/events","assignees_url":"https://api.github.com/repos/coreos/coreos-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/coreos-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/coreos-kubernetes/tags","blobs_url":"https://api.github.com/repos/coreos/coreos-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/coreos-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/coreos-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/coreos-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/coreos-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/coreos-kubernetes/languages","stargazers_url":"https://api.github.com/repos/coreos/coreos-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/coreos/coreos-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/coreos/coreos-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/coreos/coreos-kubernetes/subscription","commits_url":"https://api.github.com/repos/coreos/coreos-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/coreos-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/coreos-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/coreos-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/coreos-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/coreos-kubernetes/merges","archive_url":"https://api.github.com/repos/coreos/coreos-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/coreos-kubernetes/downloads","issues_url":"https://api.github.com/repos/coreos/coreos-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/coreos-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/coreos-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/coreos-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/coreos/coreos-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/coreos-kubernetes/deployments","created_at":"2015-08-27T01:25:24Z","updated_at":"2016-09-08T17:40:18Z","pushed_at":"2016-09-09T20:16:40Z","git_url":"git://github.com/coreos/coreos-kubernetes.git","ssh_url":"git@github.com:coreos/coreos-kubernetes.git","clone_url":"https://github.com/coreos/coreos-kubernetes.git","svn_url":"https://github.com/coreos/coreos-kubernetes","homepage":"https://coreos.com/kubernetes/docs/latest/","size":52130,"stargazers_count":559,"watchers_count":559,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":266,"mirror_url":null,"open_issues_count":105,"forks":266,"open_issues":105,"watchers":559,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/544"},"html":{"href":"https://github.com/coreos/coreos-kubernetes/pull/544"},"issue":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/544"},"comments":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/544/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/544/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/544/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/statuses/bbe383ef0c0a0eef2d0abdb4cd234d32044c9dd3"}}}}
{"actor":{"display_login":"colhom"}}