{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/19591","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/19591/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/19591/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/19591/events","html_url":"https://github.com/NixOS/nixpkgs/pull/19591","id":183255079,"number":19591,"title":"matrix-synapse: Pass required --report-stats opt","user":{"login":"eqyiel","id":3422442,"avatar_url":"https://avatars.githubusercontent.com/u/3422442?v=3","gravatar_id":"","url":"https://api.github.com/users/eqyiel","html_url":"https://github.com/eqyiel","followers_url":"https://api.github.com/users/eqyiel/followers","following_url":"https://api.github.com/users/eqyiel/following{/other_user}","gists_url":"https://api.github.com/users/eqyiel/gists{/gist_id}","starred_url":"https://api.github.com/users/eqyiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eqyiel/subscriptions","organizations_url":"https://api.github.com/users/eqyiel/orgs","repos_url":"https://api.github.com/users/eqyiel/repos","events_url":"https://api.github.com/users/eqyiel/events{/privacy}","received_events_url":"https://api.github.com/users/eqyiel/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-10-16T08:10:41Z","updated_at":"2016-10-18T23:26:43Z","closed_at":"2016-10-16T13:31:07Z","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19591","html_url":"https://github.com/NixOS/nixpkgs/pull/19591","diff_url":"https://github.com/NixOS/nixpkgs/pull/19591.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/19591.patch"},"body":"###### Motivation for this change\r\n\r\nThe script `matrix-synapse-pre-start` was failing because `synapse` [expects] (https://github.com/matrix-org/synapse/blob/9bba6ebaa903a81cd94fada114aa71e20b685adb/synapse/config/_base.py#L238-L242) the `--report-stats` option to be passed on the command line (even if it exists in the configuration file).\r\n\r\nHope this is OK.\r\n\r\n###### Things done\r\n\r\n- [ ] Tested using sandboxing\r\n  ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,\r\n    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] OS X\r\n   - [ ] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/254668285","html_url":"https://github.com/NixOS/nixpkgs/pull/19591#issuecomment-254668285","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/19591","id":254668285,"user":{"login":"grahamc","id":76716,"avatar_url":"https://avatars.githubusercontent.com/u/76716?v=3","gravatar_id":"","url":"https://api.github.com/users/grahamc","html_url":"https://github.com/grahamc","followers_url":"https://api.github.com/users/grahamc/followers","following_url":"https://api.github.com/users/grahamc/following{/other_user}","gists_url":"https://api.github.com/users/grahamc/gists{/gist_id}","starred_url":"https://api.github.com/users/grahamc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grahamc/subscriptions","organizations_url":"https://api.github.com/users/grahamc/orgs","repos_url":"https://api.github.com/users/grahamc/repos","events_url":"https://api.github.com/users/grahamc/events{/privacy}","received_events_url":"https://api.github.com/users/grahamc/received_events","type":"User","site_admin":false},"created_at":"2016-10-18T23:26:43Z","updated_at":"2016-10-18T23:26:43Z","body":"@Ralith should I merge that revert?"}}
{"actor":{"display_login":"grahamc"}}