{"action":"created","comment":{"url":"https://api.github.com/repos/Automattic/jetpack/pulls/comments/80329766","id":80329766,"diff_hunk":"@@ -271,6 +271,7 @@ static function is_whitelisted_option( $option ) {\n \tstatic $default_sync_wait_threshold = 5; // only wait before next send if the current send took more than X seconds\n \tstatic $default_max_queue_size = 1000;\n \tstatic $default_max_queue_lag = 900; // 15 minutes\n+\tstatic $default_max_dequeue_time = 15; // 15 seconds","path":"sync/class.jetpack-sync-defaults.php","position":null,"original_position":4,"commit_id":"f75bf90951ee66f77f5ba54b8d0efb4a64637d5d","original_commit_id":"44c675c18edf386cef803f14323fe9eac3ab58f6","user":{"login":"gravityrail","id":51896,"avatar_url":"https://avatars.githubusercontent.com/u/51896?v=3","gravatar_id":"","url":"https://api.github.com/users/gravityrail","html_url":"https://github.com/gravityrail","followers_url":"https://api.github.com/users/gravityrail/followers","following_url":"https://api.github.com/users/gravityrail/following{/other_user}","gists_url":"https://api.github.com/users/gravityrail/gists{/gist_id}","starred_url":"https://api.github.com/users/gravityrail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravityrail/subscriptions","organizations_url":"https://api.github.com/users/gravityrail/orgs","repos_url":"https://api.github.com/users/gravityrail/repos","events_url":"https://api.github.com/users/gravityrail/events{/privacy}","received_events_url":"https://api.github.com/users/gravityrail/received_events","type":"User","site_admin":false},"body":"As discussed, I added this change and tweaked it a bit (since defining `static` vars at runtime is not allowed in PHP, and also because this value could be _highly_ dynamic within the context of a single application, between web vs cron vs shell vs other environments.\r\n","created_at":"2016-09-23T21:24:59Z","updated_at":"2016-09-23T21:24:59Z","html_url":"https://github.com/Automattic/jetpack/pull/5194#discussion_r80329766","pull_request_url":"https://api.github.com/repos/Automattic/jetpack/pulls/5194","_links":{"self":{"href":"https://api.github.com/repos/Automattic/jetpack/pulls/comments/80329766"},"html":{"href":"https://github.com/Automattic/jetpack/pull/5194#discussion_r80329766"},"pull_request":{"href":"https://api.github.com/repos/Automattic/jetpack/pulls/5194"}}},"pull_request":{"url":"https://api.github.com/repos/Automattic/jetpack/pulls/5194","id":86559786,"html_url":"https://github.com/Automattic/jetpack/pull/5194","diff_url":"https://github.com/Automattic/jetpack/pull/5194.diff","patch_url":"https://github.com/Automattic/jetpack/pull/5194.patch","issue_url":"https://api.github.com/repos/Automattic/jetpack/issues/5194","number":5194,"state":"open","locked":false,"title":"Limit dequeue time to 15 seconds to avoid going over PHP execution timeout","user":{"login":"gravityrail","id":51896,"avatar_url":"https://avatars.githubusercontent.com/u/51896?v=3","gravatar_id":"","url":"https://api.github.com/users/gravityrail","html_url":"https://github.com/gravityrail","followers_url":"https://api.github.com/users/gravityrail/followers","following_url":"https://api.github.com/users/gravityrail/following{/other_user}","gists_url":"https://api.github.com/users/gravityrail/gists{/gist_id}","starred_url":"https://api.github.com/users/gravityrail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravityrail/subscriptions","organizations_url":"https://api.github.com/users/gravityrail/orgs","repos_url":"https://api.github.com/users/gravityrail/repos","events_url":"https://api.github.com/users/gravityrail/events{/privacy}","received_events_url":"https://api.github.com/users/gravityrail/received_events","type":"User","site_admin":false},"body":"Often PHP has a max execution time of 30 seconds. \r\n\r\nIn most cases, the default number and data size of items being dequeued by sync can be processed in less than 30 seconds, but on some sites (particularly those that make RPC calls while rendering content) it can take longer, and in some of those cases it results in sync being permanently stuck.\r\n\r\nThis PR tries to fix the issue by checking the elapsed time after each queue item has been preprocessed (the most time-consuming part for these broken sites, in our testing) and skips to sending the data if more than 15 seconds has passed.\r\n\r\nIn addition, it adds a settings item, `max_dequeue_time`, which can be remotely configured if a site is still misbehaving.\r\n\r\ncc @ebinnion ","created_at":"2016-09-23T18:31:41Z","updated_at":"2016-09-23T21:24:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4c3578fa0ea757528140f4bb49448813ff3a12c","assignee":{"login":"gravityrail","id":51896,"avatar_url":"https://avatars.githubusercontent.com/u/51896?v=3","gravatar_id":"","url":"https://api.github.com/users/gravityrail","html_url":"https://github.com/gravityrail","followers_url":"https://api.github.com/users/gravityrail/followers","following_url":"https://api.github.com/users/gravityrail/following{/other_user}","gists_url":"https://api.github.com/users/gravityrail/gists{/gist_id}","starred_url":"https://api.github.com/users/gravityrail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravityrail/subscriptions","organizations_url":"https://api.github.com/users/gravityrail/orgs","repos_url":"https://api.github.com/users/gravityrail/repos","events_url":"https://api.github.com/users/gravityrail/events{/privacy}","received_events_url":"https://api.github.com/users/gravityrail/received_events","type":"User","site_admin":false},"assignees":[{"login":"gravityrail","id":51896,"avatar_url":"https://avatars.githubusercontent.com/u/51896?v=3","gravatar_id":"","url":"https://api.github.com/users/gravityrail","html_url":"https://github.com/gravityrail","followers_url":"https://api.github.com/users/gravityrail/followers","following_url":"https://api.github.com/users/gravityrail/following{/other_user}","gists_url":"https://api.github.com/users/gravityrail/gists{/gist_id}","starred_url":"https://api.github.com/users/gravityrail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravityrail/subscriptions","organizations_url":"https://api.github.com/users/gravityrail/orgs","repos_url":"https://api.github.com/users/gravityrail/repos","events_url":"https://api.github.com/users/gravityrail/events{/privacy}","received_events_url":"https://api.github.com/users/gravityrail/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Automattic/jetpack/milestones/62","html_url":"https://github.com/Automattic/jetpack/milestones/4.3.2","labels_url":"https://api.github.com/repos/Automattic/jetpack/milestones/62/labels","id":1986968,"number":62,"title":"4.3.2","description":"","creator":{"login":"dereksmart","id":7129409,"avatar_url":"https://avatars.githubusercontent.com/u/7129409?v=3","gravatar_id":"","url":"https://api.github.com/users/dereksmart","html_url":"https://github.com/dereksmart","followers_url":"https://api.github.com/users/dereksmart/followers","following_url":"https://api.github.com/users/dereksmart/following{/other_user}","gists_url":"https://api.github.com/users/dereksmart/gists{/gist_id}","starred_url":"https://api.github.com/users/dereksmart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dereksmart/subscriptions","organizations_url":"https://api.github.com/users/dereksmart/orgs","repos_url":"https://api.github.com/users/dereksmart/repos","events_url":"https://api.github.com/users/dereksmart/events{/privacy}","received_events_url":"https://api.github.com/users/dereksmart/received_events","type":"User","site_admin":false},"open_issues":97,"closed_issues":17,"state":"open","created_at":"2016-09-06T18:36:07Z","updated_at":"2016-09-23T19:07:53Z","due_on":"2016-09-13T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/Automattic/jetpack/pulls/5194/commits","review_comments_url":"https://api.github.com/repos/Automattic/jetpack/pulls/5194/comments","review_comment_url":"https://api.github.com/repos/Automattic/jetpack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/jetpack/issues/5194/comments","statuses_url":"https://api.github.com/repos/Automattic/jetpack/statuses/f75bf90951ee66f77f5ba54b8d0efb4a64637d5d","head":{"label":"Automattic:fix/time-limit-sync-queue-processing","ref":"fix/time-limit-sync-queue-processing","sha":"f75bf90951ee66f77f5ba54b8d0efb4a64637d5d","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":15231212,"name":"jetpack","full_name":"Automattic/jetpack","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/jetpack","description":"Increase your traffic, view your stats, speed up your site, and protect yourself from hackers with Jetpack.","fork":false,"url":"https://api.github.com/repos/Automattic/jetpack","forks_url":"https://api.github.com/repos/Automattic/jetpack/forks","keys_url":"https://api.github.com/repos/Automattic/jetpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/jetpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/jetpack/teams","hooks_url":"https://api.github.com/repos/Automattic/jetpack/hooks","issue_events_url":"https://api.github.com/repos/Automattic/jetpack/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/jetpack/events","assignees_url":"https://api.github.com/repos/Automattic/jetpack/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/jetpack/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/jetpack/tags","blobs_url":"https://api.github.com/repos/Automattic/jetpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/jetpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/jetpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/jetpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/jetpack/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/jetpack/languages","stargazers_url":"https://api.github.com/repos/Automattic/jetpack/stargazers","contributors_url":"https://api.github.com/repos/Automattic/jetpack/contributors","subscribers_url":"https://api.github.com/repos/Automattic/jetpack/subscribers","subscription_url":"https://api.github.com/repos/Automattic/jetpack/subscription","commits_url":"https://api.github.com/repos/Automattic/jetpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/jetpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/jetpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/jetpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/jetpack/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/jetpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/jetpack/merges","archive_url":"https://api.github.com/repos/Automattic/jetpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/jetpack/downloads","issues_url":"https://api.github.com/repos/Automattic/jetpack/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/jetpack/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/jetpack/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/jetpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/jetpack/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/jetpack/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/jetpack/deployments","created_at":"2013-12-16T16:43:01Z","updated_at":"2016-09-22T16:37:20Z","pushed_at":"2016-09-23T21:22:28Z","git_url":"git://github.com/Automattic/jetpack.git","ssh_url":"git@github.com:Automattic/jetpack.git","clone_url":"https://github.com/Automattic/jetpack.git","svn_url":"https://github.com/Automattic/jetpack","homepage":"http://jetpack.com","size":304058,"stargazers_count":574,"watchers_count":574,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":350,"mirror_url":null,"open_issues_count":810,"forks":350,"open_issues":810,"watchers":574,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"8db010a50627b06a826fe68cd631ee37e8701b70","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":15231212,"name":"jetpack","full_name":"Automattic/jetpack","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/jetpack","description":"Increase your traffic, view your stats, speed up your site, and protect yourself from hackers with Jetpack.","fork":false,"url":"https://api.github.com/repos/Automattic/jetpack","forks_url":"https://api.github.com/repos/Automattic/jetpack/forks","keys_url":"https://api.github.com/repos/Automattic/jetpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/jetpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/jetpack/teams","hooks_url":"https://api.github.com/repos/Automattic/jetpack/hooks","issue_events_url":"https://api.github.com/repos/Automattic/jetpack/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/jetpack/events","assignees_url":"https://api.github.com/repos/Automattic/jetpack/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/jetpack/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/jetpack/tags","blobs_url":"https://api.github.com/repos/Automattic/jetpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/jetpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/jetpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/jetpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/jetpack/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/jetpack/languages","stargazers_url":"https://api.github.com/repos/Automattic/jetpack/stargazers","contributors_url":"https://api.github.com/repos/Automattic/jetpack/contributors","subscribers_url":"https://api.github.com/repos/Automattic/jetpack/subscribers","subscription_url":"https://api.github.com/repos/Automattic/jetpack/subscription","commits_url":"https://api.github.com/repos/Automattic/jetpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/jetpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/jetpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/jetpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/jetpack/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/jetpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/jetpack/merges","archive_url":"https://api.github.com/repos/Automattic/jetpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/jetpack/downloads","issues_url":"https://api.github.com/repos/Automattic/jetpack/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/jetpack/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/jetpack/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/jetpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/jetpack/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/jetpack/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/jetpack/deployments","created_at":"2013-12-16T16:43:01Z","updated_at":"2016-09-22T16:37:20Z","pushed_at":"2016-09-23T21:22:28Z","git_url":"git://github.com/Automattic/jetpack.git","ssh_url":"git@github.com:Automattic/jetpack.git","clone_url":"https://github.com/Automattic/jetpack.git","svn_url":"https://github.com/Automattic/jetpack","homepage":"http://jetpack.com","size":304058,"stargazers_count":574,"watchers_count":574,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":350,"mirror_url":null,"open_issues_count":810,"forks":350,"open_issues":810,"watchers":574,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/jetpack/pulls/5194"},"html":{"href":"https://github.com/Automattic/jetpack/pull/5194"},"issue":{"href":"https://api.github.com/repos/Automattic/jetpack/issues/5194"},"comments":{"href":"https://api.github.com/repos/Automattic/jetpack/issues/5194/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/jetpack/pulls/5194/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/jetpack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/jetpack/pulls/5194/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/jetpack/statuses/f75bf90951ee66f77f5ba54b8d0efb4a64637d5d"}}}}
{"actor":{"display_login":"gravityrail"}}