{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/9361","repository_url":"https://api.github.com/repos/facebook/react-native","labels_url":"https://api.github.com/repos/facebook/react-native/issues/9361/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/9361/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/9361/events","html_url":"https://github.com/facebook/react-native/pull/9361","id":170755954,"number":9361,"title":"[Android] Fix bug in timer clean up","user":{"login":"rigdern","id":199935,"avatar_url":"https://avatars.githubusercontent.com/u/199935?v=3","gravatar_id":"","url":"https://api.github.com/users/rigdern","html_url":"https://github.com/rigdern","followers_url":"https://api.github.com/users/rigdern/followers","following_url":"https://api.github.com/users/rigdern/following{/other_user}","gists_url":"https://api.github.com/users/rigdern/gists{/gist_id}","starred_url":"https://api.github.com/users/rigdern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigdern/subscriptions","organizations_url":"https://api.github.com/users/rigdern/orgs","repos_url":"https://api.github.com/users/rigdern/repos","events_url":"https://api.github.com/users/rigdern/events{/privacy}","received_events_url":"https://api.github.com/users/rigdern/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7"},{"url":"https://api.github.com/repos/facebook/react-native/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-11T21:50:18Z","updated_at":"2016-08-30T01:19:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/9361","html_url":"https://github.com/facebook/react-native/pull/9361","diff_url":"https://github.com/facebook/react-native/pull/9361.diff","patch_url":"https://github.com/facebook/react-native/pull/9361.patch"},"body":"One of the impacts of this bug is that Java is firing timer\r\ncompletion events into JavaScript for timers that should have\r\nbeen deleted. JavaScript filters these out so it doesn't impact\r\nthe app developer. However, Java is completing more timers\r\nthan necessary.\r\n\r\nWhen cleaning up a timer, we were accidentally deleting the\r\nwhole set of timers for that context. Instead, we should\r\njust delete that timer from its context.\r\n\r\nAdam Comella\r\nMicrosoft Corp."},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/243305678","html_url":"https://github.com/facebook/react-native/pull/9361#issuecomment-243305678","issue_url":"https://api.github.com/repos/facebook/react-native/issues/9361","id":243305678,"user":{"login":"janicduplessis","id":2677334,"avatar_url":"https://avatars.githubusercontent.com/u/2677334?v=3","gravatar_id":"","url":"https://api.github.com/users/janicduplessis","html_url":"https://github.com/janicduplessis","followers_url":"https://api.github.com/users/janicduplessis/followers","following_url":"https://api.github.com/users/janicduplessis/following{/other_user}","gists_url":"https://api.github.com/users/janicduplessis/gists{/gist_id}","starred_url":"https://api.github.com/users/janicduplessis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janicduplessis/subscriptions","organizations_url":"https://api.github.com/users/janicduplessis/orgs","repos_url":"https://api.github.com/users/janicduplessis/repos","events_url":"https://api.github.com/users/janicduplessis/events{/privacy}","received_events_url":"https://api.github.com/users/janicduplessis/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T01:19:50Z","updated_at":"2016-08-30T01:19:50Z","body":"@rigdern Should we remove the context from `mTimerIdsToTimers` when it doesn't contain anymore timers?\r\n\r\nI don't get how this causes Java to fire more timer than necessary, aren't we removing more timers than we should causing timers to not be fired?"}}
{"actor":{"display_login":"janicduplessis"}}