{"action":"created","comment":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/comments/49016784","id":49016784,"diff_hunk":"@@ -97,8 +96,23 @@ public void heartbeat() {\n     }\n \n     for (PersistFile persistFile : command.getCommandOptions().getPersistOptions().persistFiles) {\n+      long fileId = persistFile.fileId;\n+      if (mFileDataManager.isFilePersisting(fileId) || mFileDataManager.isFilePersisted(fileId)) {","path":"servers/src/main/java/tachyon/worker/file/FileWorkerMasterSyncExecutor.java","position":19,"original_position":19,"commit_id":"ca4170d0f32b4ccc64083874ee76931a18c5dd10","original_commit_id":"ca4170d0f32b4ccc64083874ee76931a18c5dd10","user":{"login":"yupeng9","id":13425258,"avatar_url":"https://avatars.githubusercontent.com/u/13425258?v=3","gravatar_id":"","url":"https://api.github.com/users/yupeng9","html_url":"https://github.com/yupeng9","followers_url":"https://api.github.com/users/yupeng9/followers","following_url":"https://api.github.com/users/yupeng9/following{/other_user}","gists_url":"https://api.github.com/users/yupeng9/gists{/gist_id}","starred_url":"https://api.github.com/users/yupeng9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yupeng9/subscriptions","organizations_url":"https://api.github.com/users/yupeng9/orgs","repos_url":"https://api.github.com/users/yupeng9/repos","events_url":"https://api.github.com/users/yupeng9/events{/privacy}","received_events_url":"https://api.github.com/users/yupeng9/received_events","type":"User","site_admin":false},"body":"sgtm","created_at":"2016-01-06T22:09:27Z","updated_at":"2016-01-06T22:09:27Z","html_url":"https://github.com/amplab/tachyon/pull/2366#discussion_r49016784","pull_request_url":"https://api.github.com/repos/amplab/tachyon/pulls/2366","_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments/49016784"},"html":{"href":"https://github.com/amplab/tachyon/pull/2366#discussion_r49016784"},"pull_request":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2366"}}},"pull_request":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/2366","id":54767073,"html_url":"https://github.com/amplab/tachyon/pull/2366","diff_url":"https://github.com/amplab/tachyon/pull/2366.diff","patch_url":"https://github.com/amplab/tachyon/pull/2366.patch","issue_url":"https://api.github.com/repos/amplab/tachyon/issues/2366","number":2366,"state":"open","locked":false,"title":"[TACHYON-1456] Add fault-tolerance support to async persistence","user":{"login":"yupeng9","id":13425258,"avatar_url":"https://avatars.githubusercontent.com/u/13425258?v=3","gravatar_id":"","url":"https://api.github.com/users/yupeng9","html_url":"https://github.com/yupeng9","followers_url":"https://api.github.com/users/yupeng9/followers","following_url":"https://api.github.com/users/yupeng9/following{/other_user}","gists_url":"https://api.github.com/users/yupeng9/gists{/gist_id}","starred_url":"https://api.github.com/users/yupeng9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yupeng9/subscriptions","organizations_url":"https://api.github.com/users/yupeng9/orgs","repos_url":"https://api.github.com/users/yupeng9/repos","events_url":"https://api.github.com/users/yupeng9/events{/privacy}","received_events_url":"https://api.github.com/users/yupeng9/received_events","type":"User","site_admin":false},"body":"https://tachyon.atlassian.net/browse/TACHYON-1456\r\n\r\nThis PR addresses the fault-tolerance support to async persistence with the followings:\r\n* Journal the scheduling of the async persist. When the master restarts after crash, it replays the scheduling, and sends again the persist command to worker\r\n* Make the persist command between worker and master idempotent, so that the worker checks if the file is being persisted or already persisted, before it persists the file.\r\n* Add a lost file detector, so that the master updates the persistent state to LOST, if the worker crashes before the file is persisted. And the user can query master for the `FileInfo` to track the persistent state.","created_at":"2015-12-29T23:30:32Z","updated_at":"2016-01-06T22:09:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"243da7984fe80c1843e3f7fbde29e15c6e5158e3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/amplab/tachyon/pulls/2366/commits","review_comments_url":"https://api.github.com/repos/amplab/tachyon/pulls/2366/comments","review_comment_url":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amplab/tachyon/issues/2366/comments","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/ca4170d0f32b4ccc64083874ee76931a18c5dd10","head":{"label":"yupeng9:faultTolerant","ref":"faultTolerant","sha":"ca4170d0f32b4ccc64083874ee76931a18c5dd10","user":{"login":"yupeng9","id":13425258,"avatar_url":"https://avatars.githubusercontent.com/u/13425258?v=3","gravatar_id":"","url":"https://api.github.com/users/yupeng9","html_url":"https://github.com/yupeng9","followers_url":"https://api.github.com/users/yupeng9/followers","following_url":"https://api.github.com/users/yupeng9/following{/other_user}","gists_url":"https://api.github.com/users/yupeng9/gists{/gist_id}","starred_url":"https://api.github.com/users/yupeng9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yupeng9/subscriptions","organizations_url":"https://api.github.com/users/yupeng9/orgs","repos_url":"https://api.github.com/users/yupeng9/repos","events_url":"https://api.github.com/users/yupeng9/events{/privacy}","received_events_url":"https://api.github.com/users/yupeng9/received_events","type":"User","site_admin":false},"repo":{"id":39411244,"name":"tachyon","full_name":"yupeng9/tachyon","owner":{"login":"yupeng9","id":13425258,"avatar_url":"https://avatars.githubusercontent.com/u/13425258?v=3","gravatar_id":"","url":"https://api.github.com/users/yupeng9","html_url":"https://github.com/yupeng9","followers_url":"https://api.github.com/users/yupeng9/followers","following_url":"https://api.github.com/users/yupeng9/following{/other_user}","gists_url":"https://api.github.com/users/yupeng9/gists{/gist_id}","starred_url":"https://api.github.com/users/yupeng9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yupeng9/subscriptions","organizations_url":"https://api.github.com/users/yupeng9/orgs","repos_url":"https://api.github.com/users/yupeng9/repos","events_url":"https://api.github.com/users/yupeng9/events{/privacy}","received_events_url":"https://api.github.com/users/yupeng9/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yupeng9/tachyon","description":" A Reliable Memory Centric Distributed Storage System","fork":true,"url":"https://api.github.com/repos/yupeng9/tachyon","forks_url":"https://api.github.com/repos/yupeng9/tachyon/forks","keys_url":"https://api.github.com/repos/yupeng9/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yupeng9/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yupeng9/tachyon/teams","hooks_url":"https://api.github.com/repos/yupeng9/tachyon/hooks","issue_events_url":"https://api.github.com/repos/yupeng9/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/yupeng9/tachyon/events","assignees_url":"https://api.github.com/repos/yupeng9/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/yupeng9/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/yupeng9/tachyon/tags","blobs_url":"https://api.github.com/repos/yupeng9/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yupeng9/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yupeng9/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/yupeng9/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yupeng9/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/yupeng9/tachyon/languages","stargazers_url":"https://api.github.com/repos/yupeng9/tachyon/stargazers","contributors_url":"https://api.github.com/repos/yupeng9/tachyon/contributors","subscribers_url":"https://api.github.com/repos/yupeng9/tachyon/subscribers","subscription_url":"https://api.github.com/repos/yupeng9/tachyon/subscription","commits_url":"https://api.github.com/repos/yupeng9/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/yupeng9/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/yupeng9/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/yupeng9/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/yupeng9/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/yupeng9/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yupeng9/tachyon/merges","archive_url":"https://api.github.com/repos/yupeng9/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yupeng9/tachyon/downloads","issues_url":"https://api.github.com/repos/yupeng9/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/yupeng9/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/yupeng9/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/yupeng9/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yupeng9/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/yupeng9/tachyon/releases{/id}","created_at":"2015-07-20T22:20:20Z","updated_at":"2015-07-20T22:20:22Z","pushed_at":"2016-01-06T21:07:20Z","git_url":"git://github.com/yupeng9/tachyon.git","ssh_url":"git@github.com:yupeng9/tachyon.git","clone_url":"https://github.com/yupeng9/tachyon.git","svn_url":"https://github.com/yupeng9/tachyon","homepage":"http://tachyon-project.org","size":35185,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"amplab:master","ref":"master","sha":"7f57cf7296723aee8131ce4a8b0c943b14087946","user":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"tachyon","full_name":"amplab/tachyon","owner":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amplab/tachyon","description":"Memory Centric Reliable Distributed Storage","fork":false,"url":"https://api.github.com/repos/amplab/tachyon","forks_url":"https://api.github.com/repos/amplab/tachyon/forks","keys_url":"https://api.github.com/repos/amplab/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amplab/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amplab/tachyon/teams","hooks_url":"https://api.github.com/repos/amplab/tachyon/hooks","issue_events_url":"https://api.github.com/repos/amplab/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/amplab/tachyon/events","assignees_url":"https://api.github.com/repos/amplab/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/amplab/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/amplab/tachyon/tags","blobs_url":"https://api.github.com/repos/amplab/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amplab/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amplab/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/amplab/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/amplab/tachyon/languages","stargazers_url":"https://api.github.com/repos/amplab/tachyon/stargazers","contributors_url":"https://api.github.com/repos/amplab/tachyon/contributors","subscribers_url":"https://api.github.com/repos/amplab/tachyon/subscribers","subscription_url":"https://api.github.com/repos/amplab/tachyon/subscription","commits_url":"https://api.github.com/repos/amplab/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/amplab/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/amplab/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/amplab/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/amplab/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/amplab/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amplab/tachyon/merges","archive_url":"https://api.github.com/repos/amplab/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amplab/tachyon/downloads","issues_url":"https://api.github.com/repos/amplab/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/amplab/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/amplab/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/amplab/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amplab/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/amplab/tachyon/releases{/id}","created_at":"2012-12-21T17:43:46Z","updated_at":"2016-01-06T03:32:03Z","pushed_at":"2016-01-06T22:04:47Z","git_url":"git://github.com/amplab/tachyon.git","ssh_url":"git@github.com:amplab/tachyon.git","clone_url":"https://github.com/amplab/tachyon.git","svn_url":"https://github.com/amplab/tachyon","homepage":"http://tachyon-project.org","size":43247,"stargazers_count":1853,"watchers_count":1853,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":733,"mirror_url":null,"open_issues_count":25,"forks":733,"open_issues":25,"watchers":1853,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2366"},"html":{"href":"https://github.com/amplab/tachyon/pull/2366"},"issue":{"href":"https://api.github.com/repos/amplab/tachyon/issues/2366"},"comments":{"href":"https://api.github.com/repos/amplab/tachyon/issues/2366/comments"},"review_comments":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2366/comments"},"review_comment":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2366/commits"},"statuses":{"href":"https://api.github.com/repos/amplab/tachyon/statuses/ca4170d0f32b4ccc64083874ee76931a18c5dd10"}}}}