{"action":"created","comment":{"url":"https://api.github.com/repos/rpm-software-management/dnf/pulls/comments/90822862","pull_request_review_id":11337177,"id":90822862,"diff_hunk":"@@ -64,10 +64,19 @@ def __init__(self):\n         self._add_option('timeout', SecondsOption(30))\n         self._add_option('metadata_expire', SecondsOption(60 * 60 * 6))  # 6 hours\n         self._add_option('best', BoolOption(True))\n-        self._add_option('skip_broken', not self._get_option(\"best\"))\n         self._add_option('clean_requirements_on_remove', BoolOption(False))\n \n     def _add_inherited_option(self, parent, options):\n         for option_name in options:\n             self._add_option(option_name,\n                              inherit(parent._get_option(option_name)))\n+\n+    def _adjust_conf_options(self):","path":"dnf/yum/config.py","position":21,"original_position":21,"commit_id":"44c615e0a1722f8235094912d831448aaa2ffbb9","original_commit_id":"44c615e0a1722f8235094912d831448aaa2ffbb9","user":{"login":"mhatina","id":7964232,"avatar_url":"https://avatars.githubusercontent.com/u/7964232?v=3","gravatar_id":"","url":"https://api.github.com/users/mhatina","html_url":"https://github.com/mhatina","followers_url":"https://api.github.com/users/mhatina/followers","following_url":"https://api.github.com/users/mhatina/following{/other_user}","gists_url":"https://api.github.com/users/mhatina/gists{/gist_id}","starred_url":"https://api.github.com/users/mhatina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhatina/subscriptions","organizations_url":"https://api.github.com/users/mhatina/orgs","repos_url":"https://api.github.com/users/mhatina/repos","events_url":"https://api.github.com/users/mhatina/events{/privacy}","received_events_url":"https://api.github.com/users/mhatina/received_events","type":"User","site_admin":false},"body":"I don't think this is necessary.","created_at":"2016-12-05T08:59:13Z","updated_at":"2016-12-05T09:03:21Z","html_url":"https://github.com/rpm-software-management/dnf/pull/663#discussion_r90822862","pull_request_url":"https://api.github.com/repos/rpm-software-management/dnf/pulls/663","_links":{"self":{"href":"https://api.github.com/repos/rpm-software-management/dnf/pulls/comments/90822862"},"html":{"href":"https://github.com/rpm-software-management/dnf/pull/663#discussion_r90822862"},"pull_request":{"href":"https://api.github.com/repos/rpm-software-management/dnf/pulls/663"}}},"pull_request":{"url":"https://api.github.com/repos/rpm-software-management/dnf/pulls/663","id":95329403,"html_url":"https://github.com/rpm-software-management/dnf/pull/663","diff_url":"https://github.com/rpm-software-management/dnf/pull/663.diff","patch_url":"https://github.com/rpm-software-management/dnf/pull/663.patch","issue_url":"https://api.github.com/repos/rpm-software-management/dnf/issues/663","number":663,"state":"open","locked":false,"title":"Transform skip-broken into strict=false (RhBug:1329373)","user":{"login":"j-mracek","id":12737303,"avatar_url":"https://avatars.githubusercontent.com/u/12737303?v=3","gravatar_id":"","url":"https://api.github.com/users/j-mracek","html_url":"https://github.com/j-mracek","followers_url":"https://api.github.com/users/j-mracek/followers","following_url":"https://api.github.com/users/j-mracek/following{/other_user}","gists_url":"https://api.github.com/users/j-mracek/gists{/gist_id}","starred_url":"https://api.github.com/users/j-mracek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-mracek/subscriptions","organizations_url":"https://api.github.com/users/j-mracek/orgs","repos_url":"https://api.github.com/users/j-mracek/repos","events_url":"https://api.github.com/users/j-mracek/events{/privacy}","received_events_url":"https://api.github.com/users/j-mracek/received_events","type":"User","site_admin":false},"body":"It reflects better yum behavior for install command","created_at":"2016-11-25T16:41:41Z","updated_at":"2016-12-05T09:03:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ac732d2fd71bdf23929157e10910bd3e5f48313","assignee":{"login":"mhatina","id":7964232,"avatar_url":"https://avatars.githubusercontent.com/u/7964232?v=3","gravatar_id":"","url":"https://api.github.com/users/mhatina","html_url":"https://github.com/mhatina","followers_url":"https://api.github.com/users/mhatina/followers","following_url":"https://api.github.com/users/mhatina/following{/other_user}","gists_url":"https://api.github.com/users/mhatina/gists{/gist_id}","starred_url":"https://api.github.com/users/mhatina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhatina/subscriptions","organizations_url":"https://api.github.com/users/mhatina/orgs","repos_url":"https://api.github.com/users/mhatina/repos","events_url":"https://api.github.com/users/mhatina/events{/privacy}","received_events_url":"https://api.github.com/users/mhatina/received_events","type":"User","site_admin":false},"assignees":[{"login":"mhatina","id":7964232,"avatar_url":"https://avatars.githubusercontent.com/u/7964232?v=3","gravatar_id":"","url":"https://api.github.com/users/mhatina","html_url":"https://github.com/mhatina","followers_url":"https://api.github.com/users/mhatina/followers","following_url":"https://api.github.com/users/mhatina/following{/other_user}","gists_url":"https://api.github.com/users/mhatina/gists{/gist_id}","starred_url":"https://api.github.com/users/mhatina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhatina/subscriptions","organizations_url":"https://api.github.com/users/mhatina/orgs","repos_url":"https://api.github.com/users/mhatina/repos","events_url":"https://api.github.com/users/mhatina/events{/privacy}","received_events_url":"https://api.github.com/users/mhatina/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rpm-software-management/dnf/pulls/663/commits","review_comments_url":"https://api.github.com/repos/rpm-software-management/dnf/pulls/663/comments","review_comment_url":"https://api.github.com/repos/rpm-software-management/dnf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rpm-software-management/dnf/issues/663/comments","statuses_url":"https://api.github.com/repos/rpm-software-management/dnf/statuses/44c615e0a1722f8235094912d831448aaa2ffbb9","head":{"label":"j-mracek:skip-broken","ref":"skip-broken","sha":"44c615e0a1722f8235094912d831448aaa2ffbb9","user":{"login":"j-mracek","id":12737303,"avatar_url":"https://avatars.githubusercontent.com/u/12737303?v=3","gravatar_id":"","url":"https://api.github.com/users/j-mracek","html_url":"https://github.com/j-mracek","followers_url":"https://api.github.com/users/j-mracek/followers","following_url":"https://api.github.com/users/j-mracek/following{/other_user}","gists_url":"https://api.github.com/users/j-mracek/gists{/gist_id}","starred_url":"https://api.github.com/users/j-mracek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-mracek/subscriptions","organizations_url":"https://api.github.com/users/j-mracek/orgs","repos_url":"https://api.github.com/users/j-mracek/repos","events_url":"https://api.github.com/users/j-mracek/events{/privacy}","received_events_url":"https://api.github.com/users/j-mracek/received_events","type":"User","site_admin":false},"repo":{"id":42112476,"name":"dnf","full_name":"j-mracek/dnf","owner":{"login":"j-mracek","id":12737303,"avatar_url":"https://avatars.githubusercontent.com/u/12737303?v=3","gravatar_id":"","url":"https://api.github.com/users/j-mracek","html_url":"https://github.com/j-mracek","followers_url":"https://api.github.com/users/j-mracek/followers","following_url":"https://api.github.com/users/j-mracek/following{/other_user}","gists_url":"https://api.github.com/users/j-mracek/gists{/gist_id}","starred_url":"https://api.github.com/users/j-mracek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-mracek/subscriptions","organizations_url":"https://api.github.com/users/j-mracek/orgs","repos_url":"https://api.github.com/users/j-mracek/repos","events_url":"https://api.github.com/users/j-mracek/events{/privacy}","received_events_url":"https://api.github.com/users/j-mracek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/j-mracek/dnf","description":"dnf is a package manager based on yum and libsolv","fork":true,"url":"https://api.github.com/repos/j-mracek/dnf","forks_url":"https://api.github.com/repos/j-mracek/dnf/forks","keys_url":"https://api.github.com/repos/j-mracek/dnf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/j-mracek/dnf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/j-mracek/dnf/teams","hooks_url":"https://api.github.com/repos/j-mracek/dnf/hooks","issue_events_url":"https://api.github.com/repos/j-mracek/dnf/issues/events{/number}","events_url":"https://api.github.com/repos/j-mracek/dnf/events","assignees_url":"https://api.github.com/repos/j-mracek/dnf/assignees{/user}","branches_url":"https://api.github.com/repos/j-mracek/dnf/branches{/branch}","tags_url":"https://api.github.com/repos/j-mracek/dnf/tags","blobs_url":"https://api.github.com/repos/j-mracek/dnf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/j-mracek/dnf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/j-mracek/dnf/git/refs{/sha}","trees_url":"https://api.github.com/repos/j-mracek/dnf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/j-mracek/dnf/statuses/{sha}","languages_url":"https://api.github.com/repos/j-mracek/dnf/languages","stargazers_url":"https://api.github.com/repos/j-mracek/dnf/stargazers","contributors_url":"https://api.github.com/repos/j-mracek/dnf/contributors","subscribers_url":"https://api.github.com/repos/j-mracek/dnf/subscribers","subscription_url":"https://api.github.com/repos/j-mracek/dnf/subscription","commits_url":"https://api.github.com/repos/j-mracek/dnf/commits{/sha}","git_commits_url":"https://api.github.com/repos/j-mracek/dnf/git/commits{/sha}","comments_url":"https://api.github.com/repos/j-mracek/dnf/comments{/number}","issue_comment_url":"https://api.github.com/repos/j-mracek/dnf/issues/comments{/number}","contents_url":"https://api.github.com/repos/j-mracek/dnf/contents/{+path}","compare_url":"https://api.github.com/repos/j-mracek/dnf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/j-mracek/dnf/merges","archive_url":"https://api.github.com/repos/j-mracek/dnf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/j-mracek/dnf/downloads","issues_url":"https://api.github.com/repos/j-mracek/dnf/issues{/number}","pulls_url":"https://api.github.com/repos/j-mracek/dnf/pulls{/number}","milestones_url":"https://api.github.com/repos/j-mracek/dnf/milestones{/number}","notifications_url":"https://api.github.com/repos/j-mracek/dnf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/j-mracek/dnf/labels{/name}","releases_url":"https://api.github.com/repos/j-mracek/dnf/releases{/id}","deployments_url":"https://api.github.com/repos/j-mracek/dnf/deployments","created_at":"2015-09-08T13:03:38Z","updated_at":"2016-02-26T11:22:06Z","pushed_at":"2016-12-02T16:27:44Z","git_url":"git://github.com/j-mracek/dnf.git","ssh_url":"git@github.com:j-mracek/dnf.git","clone_url":"https://github.com/j-mracek/dnf.git","svn_url":"https://github.com/j-mracek/dnf","homepage":"","size":38640,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"rpm-software-management:master","ref":"master","sha":"988a4c2fc3677743b02284245a60710236c688a1","user":{"login":"rpm-software-management","id":8504469,"avatar_url":"https://avatars.githubusercontent.com/u/8504469?v=3","gravatar_id":"","url":"https://api.github.com/users/rpm-software-management","html_url":"https://github.com/rpm-software-management","followers_url":"https://api.github.com/users/rpm-software-management/followers","following_url":"https://api.github.com/users/rpm-software-management/following{/other_user}","gists_url":"https://api.github.com/users/rpm-software-management/gists{/gist_id}","starred_url":"https://api.github.com/users/rpm-software-management/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpm-software-management/subscriptions","organizations_url":"https://api.github.com/users/rpm-software-management/orgs","repos_url":"https://api.github.com/users/rpm-software-management/repos","events_url":"https://api.github.com/users/rpm-software-management/events{/privacy}","received_events_url":"https://api.github.com/users/rpm-software-management/received_events","type":"Organization","site_admin":false},"repo":{"id":3671909,"name":"dnf","full_name":"rpm-software-management/dnf","owner":{"login":"rpm-software-management","id":8504469,"avatar_url":"https://avatars.githubusercontent.com/u/8504469?v=3","gravatar_id":"","url":"https://api.github.com/users/rpm-software-management","html_url":"https://github.com/rpm-software-management","followers_url":"https://api.github.com/users/rpm-software-management/followers","following_url":"https://api.github.com/users/rpm-software-management/following{/other_user}","gists_url":"https://api.github.com/users/rpm-software-management/gists{/gist_id}","starred_url":"https://api.github.com/users/rpm-software-management/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpm-software-management/subscriptions","organizations_url":"https://api.github.com/users/rpm-software-management/orgs","repos_url":"https://api.github.com/users/rpm-software-management/repos","events_url":"https://api.github.com/users/rpm-software-management/events{/privacy}","received_events_url":"https://api.github.com/users/rpm-software-management/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rpm-software-management/dnf","description":"dnf is a package manager based on yum and libsolv","fork":false,"url":"https://api.github.com/repos/rpm-software-management/dnf","forks_url":"https://api.github.com/repos/rpm-software-management/dnf/forks","keys_url":"https://api.github.com/repos/rpm-software-management/dnf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rpm-software-management/dnf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rpm-software-management/dnf/teams","hooks_url":"https://api.github.com/repos/rpm-software-management/dnf/hooks","issue_events_url":"https://api.github.com/repos/rpm-software-management/dnf/issues/events{/number}","events_url":"https://api.github.com/repos/rpm-software-management/dnf/events","assignees_url":"https://api.github.com/repos/rpm-software-management/dnf/assignees{/user}","branches_url":"https://api.github.com/repos/rpm-software-management/dnf/branches{/branch}","tags_url":"https://api.github.com/repos/rpm-software-management/dnf/tags","blobs_url":"https://api.github.com/repos/rpm-software-management/dnf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rpm-software-management/dnf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rpm-software-management/dnf/git/refs{/sha}","trees_url":"https://api.github.com/repos/rpm-software-management/dnf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rpm-software-management/dnf/statuses/{sha}","languages_url":"https://api.github.com/repos/rpm-software-management/dnf/languages","stargazers_url":"https://api.github.com/repos/rpm-software-management/dnf/stargazers","contributors_url":"https://api.github.com/repos/rpm-software-management/dnf/contributors","subscribers_url":"https://api.github.com/repos/rpm-software-management/dnf/subscribers","subscription_url":"https://api.github.com/repos/rpm-software-management/dnf/subscription","commits_url":"https://api.github.com/repos/rpm-software-management/dnf/commits{/sha}","git_commits_url":"https://api.github.com/repos/rpm-software-management/dnf/git/commits{/sha}","comments_url":"https://api.github.com/repos/rpm-software-management/dnf/comments{/number}","issue_comment_url":"https://api.github.com/repos/rpm-software-management/dnf/issues/comments{/number}","contents_url":"https://api.github.com/repos/rpm-software-management/dnf/contents/{+path}","compare_url":"https://api.github.com/repos/rpm-software-management/dnf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rpm-software-management/dnf/merges","archive_url":"https://api.github.com/repos/rpm-software-management/dnf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rpm-software-management/dnf/downloads","issues_url":"https://api.github.com/repos/rpm-software-management/dnf/issues{/number}","pulls_url":"https://api.github.com/repos/rpm-software-management/dnf/pulls{/number}","milestones_url":"https://api.github.com/repos/rpm-software-management/dnf/milestones{/number}","notifications_url":"https://api.github.com/repos/rpm-software-management/dnf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rpm-software-management/dnf/labels{/name}","releases_url":"https://api.github.com/repos/rpm-software-management/dnf/releases{/id}","deployments_url":"https://api.github.com/repos/rpm-software-management/dnf/deployments","created_at":"2012-03-09T15:31:09Z","updated_at":"2016-12-04T11:44:29Z","pushed_at":"2016-12-05T08:28:17Z","git_url":"git://github.com/rpm-software-management/dnf.git","ssh_url":"git@github.com:rpm-software-management/dnf.git","clone_url":"https://github.com/rpm-software-management/dnf.git","svn_url":"https://github.com/rpm-software-management/dnf","homepage":"","size":43103,"stargazers_count":361,"watchers_count":361,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":138,"mirror_url":null,"open_issues_count":18,"forks":138,"open_issues":18,"watchers":361,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rpm-software-management/dnf/pulls/663"},"html":{"href":"https://github.com/rpm-software-management/dnf/pull/663"},"issue":{"href":"https://api.github.com/repos/rpm-software-management/dnf/issues/663"},"comments":{"href":"https://api.github.com/repos/rpm-software-management/dnf/issues/663/comments"},"review_comments":{"href":"https://api.github.com/repos/rpm-software-management/dnf/pulls/663/comments"},"review_comment":{"href":"https://api.github.com/repos/rpm-software-management/dnf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rpm-software-management/dnf/pulls/663/commits"},"statuses":{"href":"https://api.github.com/repos/rpm-software-management/dnf/statuses/44c615e0a1722f8235094912d831448aaa2ffbb9"}}}}
{"actor":{"display_login":"mhatina"}}