{"push_id":1436960205,"size":708,"distinct_size":708,"ref":"refs/heads/master","head":"6234a5dfa21a4ab078eb0e216165236cb31d8cd2","before":"016f47c7f5c1009a0340360ec0af92a14cae462f","commits":[{"sha":"f272f97df1d41d4fd60c642eef92f6114a118383","author":{"name":"Mike Grabowski","email":"97babb7adaf42d77e40f5469542cc28be6e7f46d@gmail.com"},"message":"Update outdated release schedule\n\nSummary:\nIt's been a while :)\nCloses https://github.com/facebook/react-native/pull/10330\n\nDifferential Revision: D3996478\n\nfbshipit-source-id: af280e1fef8a8d11ba42a43a85eea20a3bb024d1","distinct":true,"url":"https://api.github.com/repos/aaron-goshine/react-native/commits/f272f97df1d41d4fd60c642eef92f6114a118383"},{"sha":"fd554c31c7bcb2aae5c7d6a64e5bef9bedf56ebb","author":{"name":"Alex Kotliarskyi","email":"1040746ae9366ab18b414ffcc13be951ec9c2928@fb.com"},"message":"Fix devmenu on iPad\n\nSummary:\nThis fixes the following problem on iPad (happens when trying to show the devmenu ActionSheet):\n> Terminating app due to uncaught exception 'NSGenericException', reason: 'Your application has presented a UIAlertController () of style UIAlertControllerStyleActionSheet. The modalPresentationStyle of a UIAlertController with this style is UIModalPresentationPopover. You must provide location information for this popover through the alert controller's popoverPresentationController. You must provide either a sourceView and sourceRect or a barButtonItem. If this information is not known when you present the alert controller, you may provide it in the UIPopoverPresentationControllerDelegate method -prepareForPopoverPresentation.'\n\nI see 2 ways of fixing the issue: falling back to Alert (always displayed in the center) or adding a fake view somewhere on the screen to display the ActionSheet.\n\nReviewed By: mmmulani\n\nDifferential Revision: D3989672\n\nfbshipit-source-id: 59fabc50ec1aac3ae6ddd7ecf4d8e8e5b9586dba","distinct":true,"url":"https://api.github.com/repos/aaron-goshine/react-native/commits/fd554c31c7bcb2aae5c7d6a64e5bef9bedf56ebb"},{"sha":"a3551b081aeae8f2396d5dc26d3e034aaf7aefac","author":{"name":"Mike Lambert","email":"f27a17fc90c00d8c248d8510a1084221738b492b@jall.org"},"message":"Remove version from \"line to delete\" since we no longer use versions.\n\nSummary:\nIt seems everything pushes for \"com.facebook.react:react-native:+\" these days, so just updating the docs to match.\nCloses https://github.com/facebook/react-native/pull/9955\n\nDifferential Revision: D3997456\n\nPulled By: hramos\n\nfbshipit-source-id: 45b1b3437c6bcd9992ee000cb1353ae3c19c4d47","distinct":true,"url":"https://api.github.com/repos/aaron-goshine/react-native/commits/a3551b081aeae8f2396d5dc26d3e034aaf7aefac"},{"sha":"8e91843cc7da4a791e5fe78078998f1c30592863","author":{"name":"Andrew Y. Chen","email":"7a5ddba76dbbf97d9a685f55afdf38128b2188d4@fb.com"},"message":"Fix crash when resolveView fails to find a view\n\nReviewed By: yungsters\n\nDifferential Revision: D3997107\n\nfbshipit-source-id: 7bf03ff06a6b56d192bab7fa567a11a38148f076","distinct":true,"url":"https://api.github.com/repos/aaron-goshine/react-native/commits/8e91843cc7da4a791e5fe78078998f1c30592863"},{"sha":"2ae73ffa002221fde8011b012ea5e57e22979232","author":{"name":"Eric Vicenti","email":"60993fd2931bccf8b94630fa7735ef9356a373c3@fb.com"},"message":"Introduce Button Component\n\nSummary:\nButton is an important component to help the community get onboarded with RN quickly, so the first few minutes of a developer's experience is not spent formatting a simple button component.\n\nIn my opinion, `<Button />` should be seen as a \"lowest common demoniator\" component, rather than \"the one button to rule them all\". In other words, we should only support features in Button that will work on any platform. We should encourage people to fork Button if they need to add specific features to it, rather than trying to twist and bloat this component until it supports everything.\n\nThese platform imitations may not have the perfect constants just yet, but they are good enough to make a user feel at home in the app, without any modification. The community can help tweak the final formatting to make them look just right- PRs are welcome!\n\nReviewed By: frantic\n\nDifferential Revision: D3929041\n\nfbshipit-source-id: 3785fb67472a7614eeee0a9aef504c0bdf62ede7","distinct":true,"url":"https://api.github.com/repos/aaron-goshine/react-native/commits/2ae73ffa002221fde8011b012ea5e57e22979232"},{"sha":"33cd930d50169d9688a0cbc627129b0dae09288b","author":{"name":"Héctor Ramos","email":"4c668669ecbe6bbe31db28cbf68f243002f1c12d@gmail.com"},"message":"Link to unversioned showcase.\n\nSummary:\nThe showcase is not versioned. We need to link to `/react-native/showcase.html` to ensure the unversioned showcase is loaded instead of something like `react-native/releases/0.34/showcase.html` which does not exist.\nCloses https://github.com/facebook/react-native/pull/10324\n\nDifferential Revision: D3995139\n\nPulled By: bestander\n\nfbshipit-source-id: b361394e0f4edd182006b306a33f7417e69ce9af","distinct":true,"url":"https://api.github.com/repos/aaron-goshine/react-native/commits/33cd930d50169d9688a0cbc627129b0dae09288b"},{"sha":"176f96d7b6f752368efb12d5fbbdd5d7a92fdd4f","author":{"name":"leeight","email":"70c72fce7301f823d49168d2744b89216a1399d7@gmail.com"},"message":"Remove duplicated call from NavigatorSceneConfigs\n\nSummary:\nThanks for submitting a pull request! Please provide enough information so that others can review your pull request:\n\n> **Unless you are a React Native release maintainer and cherry-picking an *existing* commit into a current release, ensure your pull request is targeting the `master` React Native branch.**\n\nExplain the **motivation** for making this change. What existing problem does the pull request solve?\n\nPrefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.\n\n**Test plan (required)**\n\nDemonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.\n\nMake sure tests pass on both Travis and Circle CI.\n\n**Code formatting**\n\nLook around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide).\n\nFor more info, see\nCloses https://github.com/facebook/react-native/pull/10299\n\nDifferential Revision: D3997827\n\nPulled By: ericvicenti\n\nfbshipit-source-id: a98e112d95015842936a9d2bdc89553772ba49c2","distinct":true,"url":"https://api.github.com/repos/aaron-goshine/react-native/commits/176f96d7b6f752368efb12d5fbbdd5d7a92fdd4f"},{"sha":"de70a622aaddf613d0e8c00ed42a1825998015e8","author":{"name":"Jeff Thomas","email":"f8ef0ed9772448c6929739275d19b8e3a0ee2ddf@gmail.com"},"message":"Docs improvement\n\nSummary:\nIn the `Additional Scenes` section, the `TouchableHighlight` component is used, but is not present in the import statement.\n\nThis is confusing and results in a `Can't find variable: TouchableHighlight` error.\n\nThis PR attempts to correct this confusion.\nCloses https://github.com/facebook/react-native/pull/10276\n\nDifferential Revision: D3997058\n\nPulled By: hramos\n\nfbshipit-source-id: 22ebf39cd39d8a76427c89cecc774ff9aef2c3c8","distinct":true,"url":"https://api.github.com/repos/aaron-goshine/react-native/commits/de70a622aaddf613d0e8c00ed42a1825998015e8"},{"sha":"a5698f5cea1722810656cd880601d50d754d8560","author":{"name":"Jing Chen","email":"3a7f095c28abe1f64393ebc5fcf4dad65e261799@fb.com"},"message":"Override onContentSizeChange prop on ScrollView before rendering\n\nSummary:\nWe got a report that onContentSizeChange function was being called with an object instead of a number for width, sometimes. Upon debugging, it looked like the param being passed in was a native event wrapper. Tim eventually figured out that this is because there's a TextInput child, and the event bubbles: diffusion/FBS/browse/master/fbobjc/Libraries/FBReactKit/js/react-native-github/Libraries/Text/RCTTextViewManager.m;afbdef32df50$39\n\nBecause ScrollView just passes all its props down to the component it eventually renders (RCTScrollView on iOS), the TextInput event bubbles up and triggers the onContentSizeChange prop that was passed in directly, instead of going through the layer in ScrollView that normally unpacks width/height from the native event: diffusion/FBS/browse/master/fbobjc/Libraries/FBReactKit/js/react-native-github/Libraries/Components/ScrollView/ScrollView.js;247ddb2022151b68dd9f83a888b6e0ec9923737a$413-416\n\nOverriding the prop before passing down to RCTScrollView will break that chain, so that the event will continue to bubble but it won't find the incorrect prop from ScrollView.\n\nReviewed By: yungsters\n\nDifferential Revision: D3999689\n\nfbshipit-source-id: d6c3bf711969b3e1c6fc1e51fd44c6894910bc3d","distinct":true,"url":"https://api.github.com/repos/aaron-goshine/react-native/commits/a5698f5cea1722810656cd880601d50d754d8560"},{"sha":"08e715bc9c8346764b8bf025869ee4412de1ff43","author":{"name":"Emil Sjolander","email":"fd01956b6f7ea3f89c72dc9353cbe274f619cc70@fb.com"},"message":"Add finalizer to release any unreleased native memory\n\nReviewed By: lucasr\n\nDifferential Revision: D3992759\n\nfbshipit-source-id: f648b72ead5bdb7257a5197496b19795f71f3788","distinct":true,"url":"https://api.github.com/repos/aaron-goshine/react-native/commits/08e715bc9c8346764b8bf025869ee4412de1ff43"},{"sha":"3137ba993dbc3645832283ab683d18950c4246ed","author":{"name":"Pieter De Baets","email":"377831b9cd0f79984db1fb62440ca394156e97b4@fb.com"},"message":"Cleanup console and ErrorUtils\n\nReviewed By: davidaurelio\n\nDifferential Revision: D3981005\n\nfbshipit-source-id: 3c95e62177f78785c7f971dd632126dbfb83746b","distinct":true,"url":"https://api.github.com/repos/aaron-goshine/react-native/commits/3137ba993dbc3645832283ab683d18950c4246ed"},{"sha":"d99623fcdc662cd329477bf42ca8740ee4433fe7","author":{"name":"Pieter De Baets","email":"377831b9cd0f79984db1fb62440ca394156e97b4@fb.com"},"message":"Remove keyMirror usage in JSTimers\n\nReviewed By: davidaurelio\n\nDifferential Revision: D3981015\n\nfbshipit-source-id: 9ce7601038b7cdf8a7feb580380557ed84008397","distinct":true,"url":"https://api.github.com/repos/aaron-goshine/react-native/commits/d99623fcdc662cd329477bf42ca8740ee4433fe7"},{"sha":"606fc1148709357c3da9fb5bc45abaa251205378","author":{"name":"Pieter De Baets","email":"377831b9cd0f79984db1fb62440ca394156e97b4@fb.com"},"message":"Increase laziness in InitializeJavaScriptAppEngine\n\nReviewed By: davidaurelio\n\nDifferential Revision: D3981026\n\nfbshipit-source-id: fa7c0a0e98fb4ddccc61fffbb6644dd3d39b857c","distinct":true,"url":"https://api.github.com/repos/aaron-goshine/react-native/commits/606fc1148709357c3da9fb5bc45abaa251205378"},{"sha":"9ed9bca0bf2cc4131221bc9be05ad5d458a5750d","author":{"name":"Pieter De Baets","email":"377831b9cd0f79984db1fb62440ca394156e97b4@fb.com"},"message":"Lazily instantiate native modules\n\nSummary: Instead of sending a list of modules over to JS on startup (and actually blocking script execution) instead provide a proxy object that constructs each of these lazily.\n\nReviewed By: lexs\n\nDifferential Revision: D3936979\n\nfbshipit-source-id: 71bde822f01eb17a29f56c5e60e95e98e207d74d","distinct":true,"url":"https://api.github.com/repos/aaron-goshine/react-native/commits/9ed9bca0bf2cc4131221bc9be05ad5d458a5750d"},{"sha":"fa5ad85252be9e5e5a8f04d705463e7ba4cb85e3","author":{"name":"Satyajit Sahoo","email":"32b3f44ab726063f0091e2dc828fc031d53650f8@gmail.com"},"message":"Remove deprecated APIs and modules\n\nSummary:\nWe've deprecated these APIs for quite a few releases and we should be able to get rid of them now.\n\nRemove following deprecated modules/components\n - AppStateIOS\n - ActivityIndicatorIOS\n - IntentAndroid\n - SliderIOS\n - SwitchAndroid\n - SwitchIOS\n - LinkingIOS\n\nUpdate following modules to remove callback support\n - Clipboard\n - NetInfo\n\ncc bestander\nCloses https://github.com/facebook/react-native/pull/9891\n\nReviewed By: bestander\n\nDifferential Revision: D3974094\n\nPulled By: javache\n\nfbshipit-source-id: 9abe32716bd85d0cea9933894f4447d53bdd5ee7","distinct":true,"url":"https://api.github.com/repos/aaron-goshine/react-native/commits/fa5ad85252be9e5e5a8f04d705463e7ba4cb85e3"},{"sha":"0f3d24c7fbb3a53c3dfa38e08853f335e0eaa5ef","author":{"name":"Joshua May","email":"1fd5db6d9302a71028ee295f6843a69bdc87a02f@gmail.com"},"message":"Updates Swift @objc export for recent Swift versions\n\nSummary:\nAs of Swift 3, [Swift converts Objective-C API names based on parameters](https://github.com/apple/swift-evolution/blob/master/proposals/0005-objective-c-name-translation.md), so the docs should explicitly declare what the Objective-C API is (because it's also used in the JavaScript side too).\n\nAn alternative to this would be to update the Objective-C and JavaScript calls to be `addEventWithName:location:date:` / `addEventWithName()` based on the default Swift API, but I think the approach in the PR is most correct here.\nCloses https://github.com/facebook/react-native/pull/10176\n\nDifferential Revision: D4001604\n\nPulled By: hramos\n\nfbshipit-source-id: cd4143d19d2d375288a086b9d7995e75fe1e9170","distinct":true,"url":"https://api.github.com/repos/aaron-goshine/react-native/commits/0f3d24c7fbb3a53c3dfa38e08853f335e0eaa5ef"},{"sha":"9a8b5fcf6186e966185bb4b91ec2e0e758621648","author":{"name":"Connor McEwen","email":"3e13025917feec3c84fc55893f24253c1cbf2c27@gmail.com"},"message":"Add repeatInterval to PushNotificationIOS\n\nSummary:\nThis just cleans up the work done in #7219 by adamterlson based on grabbou's feedback\nCloses https://github.com/facebook/react-native/pull/10337\n\nDifferential Revision: D4001540\n\nPulled By: javache\n\nfbshipit-source-id: c73b5fef912fa71d1d988dae41094c9c46dc610b","distinct":true,"url":"https://api.github.com/repos/aaron-goshine/react-native/commits/9a8b5fcf6186e966185bb4b91ec2e0e758621648"},{"sha":"d1f8add4d0554d99954d1febb8386fbadb5d1eca","author":{"name":"Seph Soliman","email":"864da34f3b3a55648e9a92c4d3d0bd7295fceda7@gmail.com"},"message":"Documentation fix: dx vs. x0\n\nSummary:\n> What existing problem does the pull request solve?\n\nPurely a documentation/example error. Was misled/wasted time debugging because of this issue.\n\nDescription:\n`dx`/`dy` are zero in onPanResponderGrant, not `x0`/`y0`. `x0`/`y0` will be the coordinates relative to the granted element, which are rarely zero.\nCloses https://github.com/facebook/react-native/pull/9984\n\nDifferential Revision: D4001603\n\nPulled By: hramos\n\nfbshipit-source-id: 32580795f62394585ccfb8f9a2ae65b0b72add69","distinct":true,"url":"https://api.github.com/repos/aaron-goshine/react-native/commits/d1f8add4d0554d99954d1febb8386fbadb5d1eca"},{"sha":"292cc82d0ebc437a6f1cdd2e972b3917b7ee05a4","author":{"name":"Pieter De Baets","email":"377831b9cd0f79984db1fb62440ca394156e97b4@fb.com"},"message":"Reorganize core JS files\n\nReviewed By: lexs\n\nDifferential Revision: D3987463\n\nfbshipit-source-id: fa8f1d1bea7ed699120b9705ddc1c83767fcf8e4","distinct":true,"url":"https://api.github.com/repos/aaron-goshine/react-native/commits/292cc82d0ebc437a6f1cdd2e972b3917b7ee05a4"},{"sha":"c90bf303c1703640554a7145e0f6a4d1058ad744","author":{"name":"Pieter De Baets","email":"377831b9cd0f79984db1fb62440ca394156e97b4@fb.com"},"message":"Remove queryLayoutByID\n\nReviewed By: vjeux\n\nDifferential Revision: D3987495\n\nfbshipit-source-id: 43a3cc0fb9ea718064e59e988619c39a23cd0c38","distinct":true,"url":"https://api.github.com/repos/aaron-goshine/react-native/commits/c90bf303c1703640554a7145e0f6a4d1058ad744"}]}
{"actor":{"display_login":"aaron-goshine"}}