{"action":"created","comment":{"url":"https://api.github.com/repos/apereo/cas/pulls/comments/93688672","pull_request_review_id":14222053,"id":93688672,"diff_hunk":"@@ -84,7 +85,7 @@ public void verifyRegisteredServiceTrigger() throws Exception {\n         assertThat(strategy.resolve(VALID_PROVIDERS, null, mockService(MFA_PROVIDER_ID_2), null).orElse(null), is(MFA_PROVIDER_ID_2));\n \n         assertThat(strategy.resolve(VALID_PROVIDERS, null, mockService(MFA_INVALID, MFA_PROVIDER_ID_1, MFA_PROVIDER_ID_2), null).get(),\n-                is(MFA_PROVIDER_ID_1));\n+                anyOf(is(MFA_PROVIDER_ID_2), is(MFA_PROVIDER_1)));","path":"core/cas-server-core-services/src/test/java/org/apereo/cas/authentication/DefaultMultifactorTriggerSelectionStrategyTests.java","position":25,"original_position":25,"commit_id":"39f63dc042da1c89cd06ed56b7b8de5629534530","original_commit_id":"39f63dc042da1c89cd06ed56b7b8de5629534530","user":{"login":"mmoayyed","id":1205228,"avatar_url":"https://avatars.githubusercontent.com/u/1205228?v=3","gravatar_id":"","url":"https://api.github.com/users/mmoayyed","html_url":"https://github.com/mmoayyed","followers_url":"https://api.github.com/users/mmoayyed/followers","following_url":"https://api.github.com/users/mmoayyed/following{/other_user}","gists_url":"https://api.github.com/users/mmoayyed/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoayyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoayyed/subscriptions","organizations_url":"https://api.github.com/users/mmoayyed/orgs","repos_url":"https://api.github.com/users/mmoayyed/repos","events_url":"https://api.github.com/users/mmoayyed/events{/privacy}","received_events_url":"https://api.github.com/users/mmoayyed/received_events","type":"User","site_admin":false},"body":"This doesn't look right to me. The previous test specifically wants a match on MFA_PROVIDER_ID_1. So you probably should try to preserve order for the providers. Maybe use a LinkedHashSet? ","created_at":"2016-12-22T20:07:20Z","updated_at":"2016-12-22T20:07:20Z","html_url":"https://github.com/apereo/cas/pull/2254#discussion_r93688672","pull_request_url":"https://api.github.com/repos/apereo/cas/pulls/2254","_links":{"self":{"href":"https://api.github.com/repos/apereo/cas/pulls/comments/93688672"},"html":{"href":"https://github.com/apereo/cas/pull/2254#discussion_r93688672"},"pull_request":{"href":"https://api.github.com/repos/apereo/cas/pulls/2254"}}},"pull_request":{"url":"https://api.github.com/repos/apereo/cas/pulls/2254","id":99161650,"html_url":"https://github.com/apereo/cas/pull/2254","diff_url":"https://github.com/apereo/cas/pull/2254.diff","patch_url":"https://github.com/apereo/cas/pull/2254.patch","issue_url":"https://api.github.com/repos/apereo/cas/issues/2254","number":2254,"state":"open","locked":false,"title":"Replace Guava with Java collections","user":{"login":"DavidRG13","id":5788241,"avatar_url":"https://avatars.githubusercontent.com/u/5788241?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidRG13","html_url":"https://github.com/DavidRG13","followers_url":"https://api.github.com/users/DavidRG13/followers","following_url":"https://api.github.com/users/DavidRG13/following{/other_user}","gists_url":"https://api.github.com/users/DavidRG13/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidRG13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidRG13/subscriptions","organizations_url":"https://api.github.com/users/DavidRG13/orgs","repos_url":"https://api.github.com/users/DavidRG13/repos","events_url":"https://api.github.com/users/DavidRG13/events{/privacy}","received_events_url":"https://api.github.com/users/DavidRG13/received_events","type":"User","site_admin":false},"body":"Part of #2212","created_at":"2016-12-22T20:00:38Z","updated_at":"2016-12-22T20:07:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43f9b6b38dd77a1e74069f8bb53573cfb3f87d0c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apereo/cas/pulls/2254/commits","review_comments_url":"https://api.github.com/repos/apereo/cas/pulls/2254/comments","review_comment_url":"https://api.github.com/repos/apereo/cas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apereo/cas/issues/2254/comments","statuses_url":"https://api.github.com/repos/apereo/cas/statuses/39f63dc042da1c89cd06ed56b7b8de5629534530","head":{"label":"William-Hill-Online:CAS-2212-019","ref":"CAS-2212-019","sha":"39f63dc042da1c89cd06ed56b7b8de5629534530","user":{"login":"William-Hill-Online","id":16120005,"avatar_url":"https://avatars.githubusercontent.com/u/16120005?v=3","gravatar_id":"","url":"https://api.github.com/users/William-Hill-Online","html_url":"https://github.com/William-Hill-Online","followers_url":"https://api.github.com/users/William-Hill-Online/followers","following_url":"https://api.github.com/users/William-Hill-Online/following{/other_user}","gists_url":"https://api.github.com/users/William-Hill-Online/gists{/gist_id}","starred_url":"https://api.github.com/users/William-Hill-Online/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/William-Hill-Online/subscriptions","organizations_url":"https://api.github.com/users/William-Hill-Online/orgs","repos_url":"https://api.github.com/users/William-Hill-Online/repos","events_url":"https://api.github.com/users/William-Hill-Online/events{/privacy}","received_events_url":"https://api.github.com/users/William-Hill-Online/received_events","type":"Organization","site_admin":false},"repo":{"id":71229990,"name":"cas","full_name":"William-Hill-Online/cas","owner":{"login":"William-Hill-Online","id":16120005,"avatar_url":"https://avatars.githubusercontent.com/u/16120005?v=3","gravatar_id":"","url":"https://api.github.com/users/William-Hill-Online","html_url":"https://github.com/William-Hill-Online","followers_url":"https://api.github.com/users/William-Hill-Online/followers","following_url":"https://api.github.com/users/William-Hill-Online/following{/other_user}","gists_url":"https://api.github.com/users/William-Hill-Online/gists{/gist_id}","starred_url":"https://api.github.com/users/William-Hill-Online/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/William-Hill-Online/subscriptions","organizations_url":"https://api.github.com/users/William-Hill-Online/orgs","repos_url":"https://api.github.com/users/William-Hill-Online/repos","events_url":"https://api.github.com/users/William-Hill-Online/events{/privacy}","received_events_url":"https://api.github.com/users/William-Hill-Online/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/William-Hill-Online/cas","description":"Apereo CAS - Enterprise Single Sign On for all","fork":true,"url":"https://api.github.com/repos/William-Hill-Online/cas","forks_url":"https://api.github.com/repos/William-Hill-Online/cas/forks","keys_url":"https://api.github.com/repos/William-Hill-Online/cas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/William-Hill-Online/cas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/William-Hill-Online/cas/teams","hooks_url":"https://api.github.com/repos/William-Hill-Online/cas/hooks","issue_events_url":"https://api.github.com/repos/William-Hill-Online/cas/issues/events{/number}","events_url":"https://api.github.com/repos/William-Hill-Online/cas/events","assignees_url":"https://api.github.com/repos/William-Hill-Online/cas/assignees{/user}","branches_url":"https://api.github.com/repos/William-Hill-Online/cas/branches{/branch}","tags_url":"https://api.github.com/repos/William-Hill-Online/cas/tags","blobs_url":"https://api.github.com/repos/William-Hill-Online/cas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/William-Hill-Online/cas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/William-Hill-Online/cas/git/refs{/sha}","trees_url":"https://api.github.com/repos/William-Hill-Online/cas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/William-Hill-Online/cas/statuses/{sha}","languages_url":"https://api.github.com/repos/William-Hill-Online/cas/languages","stargazers_url":"https://api.github.com/repos/William-Hill-Online/cas/stargazers","contributors_url":"https://api.github.com/repos/William-Hill-Online/cas/contributors","subscribers_url":"https://api.github.com/repos/William-Hill-Online/cas/subscribers","subscription_url":"https://api.github.com/repos/William-Hill-Online/cas/subscription","commits_url":"https://api.github.com/repos/William-Hill-Online/cas/commits{/sha}","git_commits_url":"https://api.github.com/repos/William-Hill-Online/cas/git/commits{/sha}","comments_url":"https://api.github.com/repos/William-Hill-Online/cas/comments{/number}","issue_comment_url":"https://api.github.com/repos/William-Hill-Online/cas/issues/comments{/number}","contents_url":"https://api.github.com/repos/William-Hill-Online/cas/contents/{+path}","compare_url":"https://api.github.com/repos/William-Hill-Online/cas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/William-Hill-Online/cas/merges","archive_url":"https://api.github.com/repos/William-Hill-Online/cas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/William-Hill-Online/cas/downloads","issues_url":"https://api.github.com/repos/William-Hill-Online/cas/issues{/number}","pulls_url":"https://api.github.com/repos/William-Hill-Online/cas/pulls{/number}","milestones_url":"https://api.github.com/repos/William-Hill-Online/cas/milestones{/number}","notifications_url":"https://api.github.com/repos/William-Hill-Online/cas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/William-Hill-Online/cas/labels{/name}","releases_url":"https://api.github.com/repos/William-Hill-Online/cas/releases{/id}","deployments_url":"https://api.github.com/repos/William-Hill-Online/cas/deployments","created_at":"2016-10-18T09:10:14Z","updated_at":"2016-11-22T16:29:51Z","pushed_at":"2016-12-22T18:35:17Z","git_url":"git://github.com/William-Hill-Online/cas.git","ssh_url":"git@github.com:William-Hill-Online/cas.git","clone_url":"https://github.com/William-Hill-Online/cas.git","svn_url":"https://github.com/William-Hill-Online/cas","homepage":"https://apereo.github.io/cas/","size":1262867,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apereo:master","ref":"master","sha":"dc475f59d66075bc96e892a31c1adf58ba0f7037","user":{"login":"apereo","id":4679233,"avatar_url":"https://avatars.githubusercontent.com/u/4679233?v=3","gravatar_id":"","url":"https://api.github.com/users/apereo","html_url":"https://github.com/apereo","followers_url":"https://api.github.com/users/apereo/followers","following_url":"https://api.github.com/users/apereo/following{/other_user}","gists_url":"https://api.github.com/users/apereo/gists{/gist_id}","starred_url":"https://api.github.com/users/apereo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apereo/subscriptions","organizations_url":"https://api.github.com/users/apereo/orgs","repos_url":"https://api.github.com/users/apereo/repos","events_url":"https://api.github.com/users/apereo/events{/privacy}","received_events_url":"https://api.github.com/users/apereo/received_events","type":"Organization","site_admin":false},"repo":{"id":2352744,"name":"cas","full_name":"apereo/cas","owner":{"login":"apereo","id":4679233,"avatar_url":"https://avatars.githubusercontent.com/u/4679233?v=3","gravatar_id":"","url":"https://api.github.com/users/apereo","html_url":"https://github.com/apereo","followers_url":"https://api.github.com/users/apereo/followers","following_url":"https://api.github.com/users/apereo/following{/other_user}","gists_url":"https://api.github.com/users/apereo/gists{/gist_id}","starred_url":"https://api.github.com/users/apereo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apereo/subscriptions","organizations_url":"https://api.github.com/users/apereo/orgs","repos_url":"https://api.github.com/users/apereo/repos","events_url":"https://api.github.com/users/apereo/events{/privacy}","received_events_url":"https://api.github.com/users/apereo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apereo/cas","description":"Apereo CAS - Enterprise Single Sign On for all","fork":false,"url":"https://api.github.com/repos/apereo/cas","forks_url":"https://api.github.com/repos/apereo/cas/forks","keys_url":"https://api.github.com/repos/apereo/cas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apereo/cas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apereo/cas/teams","hooks_url":"https://api.github.com/repos/apereo/cas/hooks","issue_events_url":"https://api.github.com/repos/apereo/cas/issues/events{/number}","events_url":"https://api.github.com/repos/apereo/cas/events","assignees_url":"https://api.github.com/repos/apereo/cas/assignees{/user}","branches_url":"https://api.github.com/repos/apereo/cas/branches{/branch}","tags_url":"https://api.github.com/repos/apereo/cas/tags","blobs_url":"https://api.github.com/repos/apereo/cas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apereo/cas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apereo/cas/git/refs{/sha}","trees_url":"https://api.github.com/repos/apereo/cas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apereo/cas/statuses/{sha}","languages_url":"https://api.github.com/repos/apereo/cas/languages","stargazers_url":"https://api.github.com/repos/apereo/cas/stargazers","contributors_url":"https://api.github.com/repos/apereo/cas/contributors","subscribers_url":"https://api.github.com/repos/apereo/cas/subscribers","subscription_url":"https://api.github.com/repos/apereo/cas/subscription","commits_url":"https://api.github.com/repos/apereo/cas/commits{/sha}","git_commits_url":"https://api.github.com/repos/apereo/cas/git/commits{/sha}","comments_url":"https://api.github.com/repos/apereo/cas/comments{/number}","issue_comment_url":"https://api.github.com/repos/apereo/cas/issues/comments{/number}","contents_url":"https://api.github.com/repos/apereo/cas/contents/{+path}","compare_url":"https://api.github.com/repos/apereo/cas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apereo/cas/merges","archive_url":"https://api.github.com/repos/apereo/cas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apereo/cas/downloads","issues_url":"https://api.github.com/repos/apereo/cas/issues{/number}","pulls_url":"https://api.github.com/repos/apereo/cas/pulls{/number}","milestones_url":"https://api.github.com/repos/apereo/cas/milestones{/number}","notifications_url":"https://api.github.com/repos/apereo/cas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apereo/cas/labels{/name}","releases_url":"https://api.github.com/repos/apereo/cas/releases{/id}","deployments_url":"https://api.github.com/repos/apereo/cas/deployments","created_at":"2011-09-09T01:36:42Z","updated_at":"2016-12-22T12:30:43Z","pushed_at":"2016-12-22T20:00:39Z","git_url":"git://github.com/apereo/cas.git","ssh_url":"git@github.com:apereo/cas.git","clone_url":"https://github.com/apereo/cas.git","svn_url":"https://github.com/apereo/cas","homepage":"https://apereo.github.io/cas/","size":1291710,"stargazers_count":2079,"watchers_count":2079,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1317,"mirror_url":null,"open_issues_count":44,"forks":1317,"open_issues":44,"watchers":2079,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apereo/cas/pulls/2254"},"html":{"href":"https://github.com/apereo/cas/pull/2254"},"issue":{"href":"https://api.github.com/repos/apereo/cas/issues/2254"},"comments":{"href":"https://api.github.com/repos/apereo/cas/issues/2254/comments"},"review_comments":{"href":"https://api.github.com/repos/apereo/cas/pulls/2254/comments"},"review_comment":{"href":"https://api.github.com/repos/apereo/cas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apereo/cas/pulls/2254/commits"},"statuses":{"href":"https://api.github.com/repos/apereo/cas/statuses/39f63dc042da1c89cd06ed56b7b8de5629534530"}}}}
{"actor":{"display_login":"mmoayyed"}}