{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/16202","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16202/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16202/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16202/events","html_url":"https://github.com/cms-sw/cmssw/pull/16202","id":182764870,"number":16202,"title":"New seeding framework","user":{"login":"makortel","id":33993,"avatar_url":"https://avatars.githubusercontent.com/u/33993?v=3","gravatar_id":"","url":"https://api.github.com/users/makortel","html_url":"https://github.com/makortel","followers_url":"https://api.github.com/users/makortel/followers","following_url":"https://api.github.com/users/makortel/following{/other_user}","gists_url":"https://api.github.com/users/makortel/gists{/gist_id}","starred_url":"https://api.github.com/users/makortel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makortel/subscriptions","organizations_url":"https://api.github.com/users/makortel/orgs","repos_url":"https://api.github.com/users/makortel/repos","events_url":"https://api.github.com/users/makortel/events{/privacy}","received_events_url":"https://api.github.com/users/makortel/received_events","type":"User","site_admin":false},"labels":[{"id":88645479,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800","default":false},{"id":52882241,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/dqm-approved","name":"dqm-approved","color":"009800","default":false},{"id":52881628,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/fastsim-pending","name":"fastsim-pending","color":"fbca04","default":false},{"id":52822551,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/hlt-pending","name":"hlt-pending","color":"fbca04","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420","default":false},{"id":52820010,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":56131195,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":61,"closed_issues":1825,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-11-03T08:39:38Z","due_on":"2016-11-01T00:00:00Z","closed_at":null},"comments":26,"created_at":"2016-10-13T11:31:48Z","updated_at":"2016-11-03T10:00:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/16202","html_url":"https://github.com/cms-sw/cmssw/pull/16202","diff_url":"https://github.com/cms-sw/cmssw/pull/16202.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/16202.patch"},"body":"Despite of submitting this PR to 81X, this PR really targets (early) 90X (I'm submitting it now in the hope of gaining more time for the review in case L2s would have time to look already now).\n\nThis PR provides a new way to plug the seeding code to CMSSW. It takes the `TrackingRegion` creation, cluster number check, and doublet/triplet/quadruplet generation out of the seed generator, and makes each of them an EDProducer. The regions, decision of the cluster number check, and the hit doublets/triplets are delivered to subsequent components via `edm::Event`.\n\nThe implementation is fully backwards compatible, i.e. all existing configurations should work out of the box. Instances of `SeedGeneratorFromRegionHitsEDProducer` can be migrated one at a time. Here the offline iterative tracking is fully migrated (including, with minimal effort, knock-on effects in FastSim and HI), but nothing else (e.g. HLT) is not (yet).\n### Pros\n- Much more flexibility in interfaces (not more constrained by \"common denominator\")\n- `fillDescriptions` fully supported\n- For `PixelQuadrupletGenerator`, removes repetitive doublet generation of certain layer pairs\n- For `CAHit*Generator`\n  - Allows fast regional ntuplet finding\n    - No need to do everything per region, but fill CA from all doublets and find ntuplets for all regions simultaneously on one go\n  - Allows (easily) to put (e.g.) quadruplets and triplets, found simulateneously on one go, to `Event` as separate collections\n    - Can be exploited to reduce repetitive hit triplet generation between iterations\n- Allows \"medium-grained\" parallelization\n- Opens further optimization possibilities\n### Cons\n- Additional data structures to deliver information between modules\n- More modules to manage in configuration\n### Subsequent steps\n- Do similar transformation to `PixelTrackProducer`\n  - Additional complication from adding fillDescriptions support for fitter, filter, and cleaner\n- Migrate all seeding and pixel track modules in HLT (in `customizeHLTforCMSSW.py`)\n### Expected effect\n\nTested in CMSSW_8_1_X_2016-10-04-1100, no changes expected in monitored quantities. The expected speedup in 10224 (2017 ttbar+PU) seeding is ~2-3 %. The expected memory increase is ~10 MB (based on IgProf LIVE, `SimpleMemoryCheck` on 6 threads gives similar order of magnitude although across-event variations are larger).\n\n@rovere @VinInn @mtosi @felicepantaleo \n"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/258101985","html_url":"https://github.com/cms-sw/cmssw/pull/16202#issuecomment-258101985","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16202","id":258101985,"user":{"login":"makortel","id":33993,"avatar_url":"https://avatars.githubusercontent.com/u/33993?v=3","gravatar_id":"","url":"https://api.github.com/users/makortel","html_url":"https://github.com/makortel","followers_url":"https://api.github.com/users/makortel/followers","following_url":"https://api.github.com/users/makortel/following{/other_user}","gists_url":"https://api.github.com/users/makortel/gists{/gist_id}","starred_url":"https://api.github.com/users/makortel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makortel/subscriptions","organizations_url":"https://api.github.com/users/makortel/orgs","repos_url":"https://api.github.com/users/makortel/repos","events_url":"https://api.github.com/users/makortel/events{/privacy}","received_events_url":"https://api.github.com/users/makortel/received_events","type":"User","site_admin":false},"created_at":"2016-11-03T09:59:59Z","updated_at":"2016-11-03T09:59:59Z","body":"Notes to self:\r\n\r\n- [ ] need to adapt the highPU customize of #16219 (?)\r\n- [ ] need to migrate the `peripheralPbPb`-customized cluster multiplicity check and the `maxElement` s of #16405"}}
{"actor":{"display_login":"makortel"}}