{"action":"created","issue":{"url":"https://api.github.com/repos/CogRob/cogrob_ros/issues/1","repository_url":"https://api.github.com/repos/CogRob/cogrob_ros","labels_url":"https://api.github.com/repos/CogRob/cogrob_ros/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/CogRob/cogrob_ros/issues/1/comments","events_url":"https://api.github.com/repos/CogRob/cogrob_ros/issues/1/events","html_url":"https://github.com/CogRob/cogrob_ros/issues/1","id":186400635,"number":1,"title":"Add ```protobuf``` and ```grpc``` as catkin packages","user":{"login":"BillWSY","id":3462033,"avatar_url":"https://avatars.githubusercontent.com/u/3462033?v=3","gravatar_id":"","url":"https://api.github.com/users/BillWSY","html_url":"https://github.com/BillWSY","followers_url":"https://api.github.com/users/BillWSY/followers","following_url":"https://api.github.com/users/BillWSY/following{/other_user}","gists_url":"https://api.github.com/users/BillWSY/gists{/gist_id}","starred_url":"https://api.github.com/users/BillWSY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BillWSY/subscriptions","organizations_url":"https://api.github.com/users/BillWSY/orgs","repos_url":"https://api.github.com/users/BillWSY/repos","events_url":"https://api.github.com/users/BillWSY/events{/privacy}","received_events_url":"https://api.github.com/users/BillWSY/received_events","type":"User","site_admin":false},"labels":[{"id":472588447,"url":"https://api.github.com/repos/CogRob/cogrob_ros/labels/P2%20-%20NORMAL%20PRIORITY","name":"P2 - NORMAL PRIORITY","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"BillWSY","id":3462033,"avatar_url":"https://avatars.githubusercontent.com/u/3462033?v=3","gravatar_id":"","url":"https://api.github.com/users/BillWSY","html_url":"https://github.com/BillWSY","followers_url":"https://api.github.com/users/BillWSY/followers","following_url":"https://api.github.com/users/BillWSY/following{/other_user}","gists_url":"https://api.github.com/users/BillWSY/gists{/gist_id}","starred_url":"https://api.github.com/users/BillWSY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BillWSY/subscriptions","organizations_url":"https://api.github.com/users/BillWSY/orgs","repos_url":"https://api.github.com/users/BillWSY/repos","events_url":"https://api.github.com/users/BillWSY/events{/privacy}","received_events_url":"https://api.github.com/users/BillWSY/received_events","type":"User","site_admin":false},"assignees":[{"login":"BillWSY","id":3462033,"avatar_url":"https://avatars.githubusercontent.com/u/3462033?v=3","gravatar_id":"","url":"https://api.github.com/users/BillWSY","html_url":"https://github.com/BillWSY","followers_url":"https://api.github.com/users/BillWSY/followers","following_url":"https://api.github.com/users/BillWSY/following{/other_user}","gists_url":"https://api.github.com/users/BillWSY/gists{/gist_id}","starred_url":"https://api.github.com/users/BillWSY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BillWSY/subscriptions","organizations_url":"https://api.github.com/users/BillWSY/orgs","repos_url":"https://api.github.com/users/BillWSY/repos","events_url":"https://api.github.com/users/BillWSY/events{/privacy}","received_events_url":"https://api.github.com/users/BillWSY/received_events","type":"User","site_admin":false},{"login":"zephirefaith","id":9580531,"avatar_url":"https://avatars.githubusercontent.com/u/9580531?v=3","gravatar_id":"","url":"https://api.github.com/users/zephirefaith","html_url":"https://github.com/zephirefaith","followers_url":"https://api.github.com/users/zephirefaith/followers","following_url":"https://api.github.com/users/zephirefaith/following{/other_user}","gists_url":"https://api.github.com/users/zephirefaith/gists{/gist_id}","starred_url":"https://api.github.com/users/zephirefaith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephirefaith/subscriptions","organizations_url":"https://api.github.com/users/zephirefaith/orgs","repos_url":"https://api.github.com/users/zephirefaith/repos","events_url":"https://api.github.com/users/zephirefaith/events{/privacy}","received_events_url":"https://api.github.com/users/zephirefaith/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-10-31T21:20:13Z","updated_at":"2016-10-31T23:06:56Z","closed_at":null,"body":"We can add ```protobuf``` and ```grpc``` as catkin packages to this repo.\r\n\r\nThey could be placed inside \"third_party\", and tracked to their main repo using git submodules. We probably need to write some CMakelist file for them.\r\n\r\nIn this way, we don't need pollute system's ```libprotobuf```, since ROS is polluting it. But we can still static link them to C++ ```ros_portal```."},"comment":{"url":"https://api.github.com/repos/CogRob/cogrob_ros/issues/comments/257446363","html_url":"https://github.com/CogRob/cogrob_ros/issues/1#issuecomment-257446363","issue_url":"https://api.github.com/repos/CogRob/cogrob_ros/issues/1","id":257446363,"user":{"login":"BillWSY","id":3462033,"avatar_url":"https://avatars.githubusercontent.com/u/3462033?v=3","gravatar_id":"","url":"https://api.github.com/users/BillWSY","html_url":"https://github.com/BillWSY","followers_url":"https://api.github.com/users/BillWSY/followers","following_url":"https://api.github.com/users/BillWSY/following{/other_user}","gists_url":"https://api.github.com/users/BillWSY/gists{/gist_id}","starred_url":"https://api.github.com/users/BillWSY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BillWSY/subscriptions","organizations_url":"https://api.github.com/users/BillWSY/orgs","repos_url":"https://api.github.com/users/BillWSY/repos","events_url":"https://api.github.com/users/BillWSY/events{/privacy}","received_events_url":"https://api.github.com/users/BillWSY/received_events","type":"User","site_admin":false},"created_at":"2016-10-31T23:06:56Z","updated_at":"2016-10-31T23:06:56Z","body":"I have some progress.\r\n\r\nWe can create a ```google_grpc``` package with the following addition to the ```CMakelist``` file.\r\n```\r\ncatkin_package(INCLUDE_DIRS grpc/include)\r\nset(CMAKE_POSITION_INDEPENDENT_CODE ON)\r\nadd_subdirectory(grpc)\r\n```\r\n\r\nAnd add ```target_link_libraries(gpr m)``` to ```grpc/CMakelist.txt```. Also remove the target ```run_tests``` in ```boringssl/CMakelist.txt```.\r\n\r\nI am going to write an (ugly) script to do these hacks."}}
{"actor":{"display_login":"BillWSY"}}