{"action":"created","comment":{"url":"https://api.github.com/repos/heroku/spark-in-space/pulls/comments/76900416","id":76900416,"diff_hunk":"@@ -89,9 +92,9 @@ finish Installing Spark\n notice Configuring Spark\n rm -rf $build_dir/spark-home/lib/spark-examples-*\n rm -rf $build_dir/spark-home/yarn\n-cautious_build_overlay conf/spark-env.sh\n-cautious_build_overlay conf/log4j.properties.erb\n-cautious_build_overlay conf/spark-defaults.conf.erb\n+cautious_build_overlay conf/spark-env.sh            spark-home/\n+cautious_build_overlay conf/log4j.properties.erb    spark-home/\n+cautious_build_overlay conf/spark-defaults.conf.erb spark-home/","path":"bin/compile","position":32,"original_position":32,"commit_id":"947e6bdb4c547abb264afb11d462b7e9beefd13e","original_commit_id":"947e6bdb4c547abb264afb11d462b7e9beefd13e","user":{"login":"sclasen","id":523338,"avatar_url":"https://avatars.githubusercontent.com/u/523338?v=3","gravatar_id":"","url":"https://api.github.com/users/sclasen","html_url":"https://github.com/sclasen","followers_url":"https://api.github.com/users/sclasen/followers","following_url":"https://api.github.com/users/sclasen/following{/other_user}","gists_url":"https://api.github.com/users/sclasen/gists{/gist_id}","starred_url":"https://api.github.com/users/sclasen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sclasen/subscriptions","organizations_url":"https://api.github.com/users/sclasen/orgs","repos_url":"https://api.github.com/users/sclasen/repos","events_url":"https://api.github.com/users/sclasen/events{/privacy}","received_events_url":"https://api.github.com/users/sclasen/received_events","type":"User","site_admin":false},"body":"I think only spark-env.sh should go in spark-home, the other two should go in /app/conf since that is where they are evaluated from here https://github.com/heroku/spark-in-space/blob/master/bin/spark-master#L5-L6 and in other places?","created_at":"2016-08-30T23:42:21Z","updated_at":"2016-08-30T23:42:21Z","html_url":"https://github.com/heroku/spark-in-space/pull/11#discussion_r76900416","pull_request_url":"https://api.github.com/repos/heroku/spark-in-space/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/heroku/spark-in-space/pulls/comments/76900416"},"html":{"href":"https://github.com/heroku/spark-in-space/pull/11#discussion_r76900416"},"pull_request":{"href":"https://api.github.com/repos/heroku/spark-in-space/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/heroku/spark-in-space/pulls/11","id":83365090,"html_url":"https://github.com/heroku/spark-in-space/pull/11","diff_url":"https://github.com/heroku/spark-in-space/pull/11.diff","patch_url":"https://github.com/heroku/spark-in-space/pull/11.patch","issue_url":"https://api.github.com/repos/heroku/spark-in-space/issues/11","number":11,"state":"open","locked":false,"title":"Fix to place user-facing scripts in the top-level `bin/`","user":{"login":"mars","id":17164,"avatar_url":"https://avatars.githubusercontent.com/u/17164?v=3","gravatar_id":"","url":"https://api.github.com/users/mars","html_url":"https://github.com/mars","followers_url":"https://api.github.com/users/mars/followers","following_url":"https://api.github.com/users/mars/following{/other_user}","gists_url":"https://api.github.com/users/mars/gists{/gist_id}","starred_url":"https://api.github.com/users/mars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mars/subscriptions","organizations_url":"https://api.github.com/users/mars/orgs","repos_url":"https://api.github.com/users/mars/repos","events_url":"https://api.github.com/users/mars/events{/privacy}","received_events_url":"https://api.github.com/users/mars/received_events","type":"User","site_admin":false},"body":"Here's a \"refinement\" to the cautious overlay behavior, so that a target namespace/prefix can be specified for each overlay individually.\r\n\r\nI'm having trouble testing it, because when I use the spark-in-space buildpack on a branch, the jumbo buildpack behavior is lost and the slug is too big.\r\n\r\n@scott will you give it a thorough 🤓 logical look to make sure it's sane?","created_at":"2016-08-30T23:28:24Z","updated_at":"2016-08-30T23:42:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55284290b9fe366125f9f718a4ac0ee27769f9fd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/heroku/spark-in-space/pulls/11/commits","review_comments_url":"https://api.github.com/repos/heroku/spark-in-space/pulls/11/comments","review_comment_url":"https://api.github.com/repos/heroku/spark-in-space/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heroku/spark-in-space/issues/11/comments","statuses_url":"https://api.github.com/repos/heroku/spark-in-space/statuses/947e6bdb4c547abb264afb11d462b7e9beefd13e","head":{"label":"heroku:fix-cautious-overlay-destinations","ref":"fix-cautious-overlay-destinations","sha":"947e6bdb4c547abb264afb11d462b7e9beefd13e","user":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=3","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"repo":{"id":63359994,"name":"spark-in-space","full_name":"heroku/spark-in-space","owner":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=3","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heroku/spark-in-space","description":"Heroku Button Deploy of Apache Spark Clusters in private spaces + buildpack for deploying spark jobs ","fork":false,"url":"https://api.github.com/repos/heroku/spark-in-space","forks_url":"https://api.github.com/repos/heroku/spark-in-space/forks","keys_url":"https://api.github.com/repos/heroku/spark-in-space/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heroku/spark-in-space/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heroku/spark-in-space/teams","hooks_url":"https://api.github.com/repos/heroku/spark-in-space/hooks","issue_events_url":"https://api.github.com/repos/heroku/spark-in-space/issues/events{/number}","events_url":"https://api.github.com/repos/heroku/spark-in-space/events","assignees_url":"https://api.github.com/repos/heroku/spark-in-space/assignees{/user}","branches_url":"https://api.github.com/repos/heroku/spark-in-space/branches{/branch}","tags_url":"https://api.github.com/repos/heroku/spark-in-space/tags","blobs_url":"https://api.github.com/repos/heroku/spark-in-space/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heroku/spark-in-space/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heroku/spark-in-space/git/refs{/sha}","trees_url":"https://api.github.com/repos/heroku/spark-in-space/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heroku/spark-in-space/statuses/{sha}","languages_url":"https://api.github.com/repos/heroku/spark-in-space/languages","stargazers_url":"https://api.github.com/repos/heroku/spark-in-space/stargazers","contributors_url":"https://api.github.com/repos/heroku/spark-in-space/contributors","subscribers_url":"https://api.github.com/repos/heroku/spark-in-space/subscribers","subscription_url":"https://api.github.com/repos/heroku/spark-in-space/subscription","commits_url":"https://api.github.com/repos/heroku/spark-in-space/commits{/sha}","git_commits_url":"https://api.github.com/repos/heroku/spark-in-space/git/commits{/sha}","comments_url":"https://api.github.com/repos/heroku/spark-in-space/comments{/number}","issue_comment_url":"https://api.github.com/repos/heroku/spark-in-space/issues/comments{/number}","contents_url":"https://api.github.com/repos/heroku/spark-in-space/contents/{+path}","compare_url":"https://api.github.com/repos/heroku/spark-in-space/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heroku/spark-in-space/merges","archive_url":"https://api.github.com/repos/heroku/spark-in-space/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heroku/spark-in-space/downloads","issues_url":"https://api.github.com/repos/heroku/spark-in-space/issues{/number}","pulls_url":"https://api.github.com/repos/heroku/spark-in-space/pulls{/number}","milestones_url":"https://api.github.com/repos/heroku/spark-in-space/milestones{/number}","notifications_url":"https://api.github.com/repos/heroku/spark-in-space/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heroku/spark-in-space/labels{/name}","releases_url":"https://api.github.com/repos/heroku/spark-in-space/releases{/id}","deployments_url":"https://api.github.com/repos/heroku/spark-in-space/deployments","created_at":"2016-07-14T18:26:36Z","updated_at":"2016-08-15T21:28:41Z","pushed_at":"2016-08-30T23:28:24Z","git_url":"git://github.com/heroku/spark-in-space.git","ssh_url":"git@github.com:heroku/spark-in-space.git","clone_url":"https://github.com/heroku/spark-in-space.git","svn_url":"https://github.com/heroku/spark-in-space","homepage":"","size":67,"stargazers_count":3,"watchers_count":3,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"heroku:master","ref":"master","sha":"db53effd4411f23547eba13fda931760ebc07d85","user":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=3","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"repo":{"id":63359994,"name":"spark-in-space","full_name":"heroku/spark-in-space","owner":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=3","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heroku/spark-in-space","description":"Heroku Button Deploy of Apache Spark Clusters in private spaces + buildpack for deploying spark jobs ","fork":false,"url":"https://api.github.com/repos/heroku/spark-in-space","forks_url":"https://api.github.com/repos/heroku/spark-in-space/forks","keys_url":"https://api.github.com/repos/heroku/spark-in-space/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heroku/spark-in-space/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heroku/spark-in-space/teams","hooks_url":"https://api.github.com/repos/heroku/spark-in-space/hooks","issue_events_url":"https://api.github.com/repos/heroku/spark-in-space/issues/events{/number}","events_url":"https://api.github.com/repos/heroku/spark-in-space/events","assignees_url":"https://api.github.com/repos/heroku/spark-in-space/assignees{/user}","branches_url":"https://api.github.com/repos/heroku/spark-in-space/branches{/branch}","tags_url":"https://api.github.com/repos/heroku/spark-in-space/tags","blobs_url":"https://api.github.com/repos/heroku/spark-in-space/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heroku/spark-in-space/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heroku/spark-in-space/git/refs{/sha}","trees_url":"https://api.github.com/repos/heroku/spark-in-space/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heroku/spark-in-space/statuses/{sha}","languages_url":"https://api.github.com/repos/heroku/spark-in-space/languages","stargazers_url":"https://api.github.com/repos/heroku/spark-in-space/stargazers","contributors_url":"https://api.github.com/repos/heroku/spark-in-space/contributors","subscribers_url":"https://api.github.com/repos/heroku/spark-in-space/subscribers","subscription_url":"https://api.github.com/repos/heroku/spark-in-space/subscription","commits_url":"https://api.github.com/repos/heroku/spark-in-space/commits{/sha}","git_commits_url":"https://api.github.com/repos/heroku/spark-in-space/git/commits{/sha}","comments_url":"https://api.github.com/repos/heroku/spark-in-space/comments{/number}","issue_comment_url":"https://api.github.com/repos/heroku/spark-in-space/issues/comments{/number}","contents_url":"https://api.github.com/repos/heroku/spark-in-space/contents/{+path}","compare_url":"https://api.github.com/repos/heroku/spark-in-space/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heroku/spark-in-space/merges","archive_url":"https://api.github.com/repos/heroku/spark-in-space/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heroku/spark-in-space/downloads","issues_url":"https://api.github.com/repos/heroku/spark-in-space/issues{/number}","pulls_url":"https://api.github.com/repos/heroku/spark-in-space/pulls{/number}","milestones_url":"https://api.github.com/repos/heroku/spark-in-space/milestones{/number}","notifications_url":"https://api.github.com/repos/heroku/spark-in-space/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heroku/spark-in-space/labels{/name}","releases_url":"https://api.github.com/repos/heroku/spark-in-space/releases{/id}","deployments_url":"https://api.github.com/repos/heroku/spark-in-space/deployments","created_at":"2016-07-14T18:26:36Z","updated_at":"2016-08-15T21:28:41Z","pushed_at":"2016-08-30T23:28:24Z","git_url":"git://github.com/heroku/spark-in-space.git","ssh_url":"git@github.com:heroku/spark-in-space.git","clone_url":"https://github.com/heroku/spark-in-space.git","svn_url":"https://github.com/heroku/spark-in-space","homepage":"","size":67,"stargazers_count":3,"watchers_count":3,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heroku/spark-in-space/pulls/11"},"html":{"href":"https://github.com/heroku/spark-in-space/pull/11"},"issue":{"href":"https://api.github.com/repos/heroku/spark-in-space/issues/11"},"comments":{"href":"https://api.github.com/repos/heroku/spark-in-space/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/heroku/spark-in-space/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/heroku/spark-in-space/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heroku/spark-in-space/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/heroku/spark-in-space/statuses/947e6bdb4c547abb264afb11d462b7e9beefd13e"}}}}
{"actor":{"display_login":"sclasen"}}