{"action":"created","comment":{"url":"https://api.github.com/repos/Accenture/adop-docker-compose/pulls/comments/76240211","id":76240211,"diff_hunk":"@@ -181,13 +181,13 @@ sonar:\n   environment:\n     - \"dependency:container==sonar-mysql\"\n     - \"LDAP_URL=ldap://ldap:389\"","path":"docker-compose.yml","position":41,"original_position":41,"commit_id":"96ee22b24b25c1070064cd40d76fc45a1a70b519","original_commit_id":"96ee22b24b25c1070064cd40d76fc45a1a70b519","user":{"login":"anton-kasperovich","id":380055,"avatar_url":"https://avatars.githubusercontent.com/u/380055?v=3","gravatar_id":"","url":"https://api.github.com/users/anton-kasperovich","html_url":"https://github.com/anton-kasperovich","followers_url":"https://api.github.com/users/anton-kasperovich/followers","following_url":"https://api.github.com/users/anton-kasperovich/following{/other_user}","gists_url":"https://api.github.com/users/anton-kasperovich/gists{/gist_id}","starred_url":"https://api.github.com/users/anton-kasperovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anton-kasperovich/subscriptions","organizations_url":"https://api.github.com/users/anton-kasperovich/orgs","repos_url":"https://api.github.com/users/anton-kasperovich/repos","events_url":"https://api.github.com/users/anton-kasperovich/events{/privacy}","received_events_url":"https://api.github.com/users/anton-kasperovich/received_events","type":"User","site_admin":false},"body":"@mihail-dev Found this place where you could also use ${LDAP_SERVER} variable right?","created_at":"2016-08-25T13:18:10Z","updated_at":"2016-08-25T13:18:10Z","html_url":"https://github.com/Accenture/adop-docker-compose/pull/135#discussion_r76240211","pull_request_url":"https://api.github.com/repos/Accenture/adop-docker-compose/pulls/135","_links":{"self":{"href":"https://api.github.com/repos/Accenture/adop-docker-compose/pulls/comments/76240211"},"html":{"href":"https://github.com/Accenture/adop-docker-compose/pull/135#discussion_r76240211"},"pull_request":{"href":"https://api.github.com/repos/Accenture/adop-docker-compose/pulls/135"}}},"pull_request":{"url":"https://api.github.com/repos/Accenture/adop-docker-compose/pulls/135","id":82228161,"html_url":"https://github.com/Accenture/adop-docker-compose/pull/135","diff_url":"https://github.com/Accenture/adop-docker-compose/pull/135.diff","patch_url":"https://github.com/Accenture/adop-docker-compose/pull/135.patch","issue_url":"https://api.github.com/repos/Accenture/adop-docker-compose/issues/135","number":135,"state":"open","locked":false,"title":"Modifying LDAP parameters in docker-compose.yml to be read from env.config.sh","user":{"login":"mihail-dev","id":4163233,"avatar_url":"https://avatars.githubusercontent.com/u/4163233?v=3","gravatar_id":"","url":"https://api.github.com/users/mihail-dev","html_url":"https://github.com/mihail-dev","followers_url":"https://api.github.com/users/mihail-dev/followers","following_url":"https://api.github.com/users/mihail-dev/following{/other_user}","gists_url":"https://api.github.com/users/mihail-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/mihail-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mihail-dev/subscriptions","organizations_url":"https://api.github.com/users/mihail-dev/orgs","repos_url":"https://api.github.com/users/mihail-dev/repos","events_url":"https://api.github.com/users/mihail-dev/events{/privacy}","received_events_url":"https://api.github.com/users/mihail-dev/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nIn our case we are spinning up ADOP and configuring it to use our existing ldap instead of adop-ldap. We would like to keep our ldap configuration separately to the docker compose file in env.config.sh. This modification will be beneficial because:\r\n- It makes upgrading ADOP to a newer version easier in the future.\r\n- it is simpler and easier to maintain.\r\n\r\nI have tested the change on AWS and everything functions properly.\r\n\r\nThanks.","created_at":"2016-08-22T17:11:59Z","updated_at":"2016-08-25T13:18:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c03df5cdbea464a48c63c7bf3d19f7ae7b367c92","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Accenture/adop-docker-compose/pulls/135/commits","review_comments_url":"https://api.github.com/repos/Accenture/adop-docker-compose/pulls/135/comments","review_comment_url":"https://api.github.com/repos/Accenture/adop-docker-compose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Accenture/adop-docker-compose/issues/135/comments","statuses_url":"https://api.github.com/repos/Accenture/adop-docker-compose/statuses/96ee22b24b25c1070064cd40d76fc45a1a70b519","head":{"label":"mihail-dev:master","ref":"master","sha":"96ee22b24b25c1070064cd40d76fc45a1a70b519","user":{"login":"mihail-dev","id":4163233,"avatar_url":"https://avatars.githubusercontent.com/u/4163233?v=3","gravatar_id":"","url":"https://api.github.com/users/mihail-dev","html_url":"https://github.com/mihail-dev","followers_url":"https://api.github.com/users/mihail-dev/followers","following_url":"https://api.github.com/users/mihail-dev/following{/other_user}","gists_url":"https://api.github.com/users/mihail-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/mihail-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mihail-dev/subscriptions","organizations_url":"https://api.github.com/users/mihail-dev/orgs","repos_url":"https://api.github.com/users/mihail-dev/repos","events_url":"https://api.github.com/users/mihail-dev/events{/privacy}","received_events_url":"https://api.github.com/users/mihail-dev/received_events","type":"User","site_admin":false},"repo":{"id":66010738,"name":"adop-docker-compose","full_name":"mihail-dev/adop-docker-compose","owner":{"login":"mihail-dev","id":4163233,"avatar_url":"https://avatars.githubusercontent.com/u/4163233?v=3","gravatar_id":"","url":"https://api.github.com/users/mihail-dev","html_url":"https://github.com/mihail-dev","followers_url":"https://api.github.com/users/mihail-dev/followers","following_url":"https://api.github.com/users/mihail-dev/following{/other_user}","gists_url":"https://api.github.com/users/mihail-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/mihail-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mihail-dev/subscriptions","organizations_url":"https://api.github.com/users/mihail-dev/orgs","repos_url":"https://api.github.com/users/mihail-dev/repos","events_url":"https://api.github.com/users/mihail-dev/events{/privacy}","received_events_url":"https://api.github.com/users/mihail-dev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mihail-dev/adop-docker-compose","description":"Talk to us on Gitter: https://gitter.im/Accenture/ADOP","fork":true,"url":"https://api.github.com/repos/mihail-dev/adop-docker-compose","forks_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/forks","keys_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/teams","hooks_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/hooks","issue_events_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/issues/events{/number}","events_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/events","assignees_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/assignees{/user}","branches_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/branches{/branch}","tags_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/tags","blobs_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/git/refs{/sha}","trees_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/statuses/{sha}","languages_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/languages","stargazers_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/stargazers","contributors_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/contributors","subscribers_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/subscribers","subscription_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/subscription","commits_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/commits{/sha}","git_commits_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/git/commits{/sha}","comments_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/comments{/number}","issue_comment_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/issues/comments{/number}","contents_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/contents/{+path}","compare_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/merges","archive_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/downloads","issues_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/issues{/number}","pulls_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/pulls{/number}","milestones_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/milestones{/number}","notifications_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/labels{/name}","releases_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/releases{/id}","deployments_url":"https://api.github.com/repos/mihail-dev/adop-docker-compose/deployments","created_at":"2016-08-18T15:56:19Z","updated_at":"2016-08-18T15:56:20Z","pushed_at":"2016-08-25T11:04:43Z","git_url":"git://github.com/mihail-dev/adop-docker-compose.git","ssh_url":"git@github.com:mihail-dev/adop-docker-compose.git","clone_url":"https://github.com/mihail-dev/adop-docker-compose.git","svn_url":"https://github.com/mihail-dev/adop-docker-compose","homepage":"http://accenture.github.io/adop-docker-compose","size":359,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Accenture:master","ref":"master","sha":"3ae8855a7041ae89d369340f3c9883602ac3764c","user":{"login":"Accenture","id":10454368,"avatar_url":"https://avatars.githubusercontent.com/u/10454368?v=3","gravatar_id":"","url":"https://api.github.com/users/Accenture","html_url":"https://github.com/Accenture","followers_url":"https://api.github.com/users/Accenture/followers","following_url":"https://api.github.com/users/Accenture/following{/other_user}","gists_url":"https://api.github.com/users/Accenture/gists{/gist_id}","starred_url":"https://api.github.com/users/Accenture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Accenture/subscriptions","organizations_url":"https://api.github.com/users/Accenture/orgs","repos_url":"https://api.github.com/users/Accenture/repos","events_url":"https://api.github.com/users/Accenture/events{/privacy}","received_events_url":"https://api.github.com/users/Accenture/received_events","type":"Organization","site_admin":false},"repo":{"id":50841419,"name":"adop-docker-compose","full_name":"Accenture/adop-docker-compose","owner":{"login":"Accenture","id":10454368,"avatar_url":"https://avatars.githubusercontent.com/u/10454368?v=3","gravatar_id":"","url":"https://api.github.com/users/Accenture","html_url":"https://github.com/Accenture","followers_url":"https://api.github.com/users/Accenture/followers","following_url":"https://api.github.com/users/Accenture/following{/other_user}","gists_url":"https://api.github.com/users/Accenture/gists{/gist_id}","starred_url":"https://api.github.com/users/Accenture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Accenture/subscriptions","organizations_url":"https://api.github.com/users/Accenture/orgs","repos_url":"https://api.github.com/users/Accenture/repos","events_url":"https://api.github.com/users/Accenture/events{/privacy}","received_events_url":"https://api.github.com/users/Accenture/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Accenture/adop-docker-compose","description":"Talk to us on Gitter: https://gitter.im/Accenture/ADOP","fork":false,"url":"https://api.github.com/repos/Accenture/adop-docker-compose","forks_url":"https://api.github.com/repos/Accenture/adop-docker-compose/forks","keys_url":"https://api.github.com/repos/Accenture/adop-docker-compose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Accenture/adop-docker-compose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Accenture/adop-docker-compose/teams","hooks_url":"https://api.github.com/repos/Accenture/adop-docker-compose/hooks","issue_events_url":"https://api.github.com/repos/Accenture/adop-docker-compose/issues/events{/number}","events_url":"https://api.github.com/repos/Accenture/adop-docker-compose/events","assignees_url":"https://api.github.com/repos/Accenture/adop-docker-compose/assignees{/user}","branches_url":"https://api.github.com/repos/Accenture/adop-docker-compose/branches{/branch}","tags_url":"https://api.github.com/repos/Accenture/adop-docker-compose/tags","blobs_url":"https://api.github.com/repos/Accenture/adop-docker-compose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Accenture/adop-docker-compose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Accenture/adop-docker-compose/git/refs{/sha}","trees_url":"https://api.github.com/repos/Accenture/adop-docker-compose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Accenture/adop-docker-compose/statuses/{sha}","languages_url":"https://api.github.com/repos/Accenture/adop-docker-compose/languages","stargazers_url":"https://api.github.com/repos/Accenture/adop-docker-compose/stargazers","contributors_url":"https://api.github.com/repos/Accenture/adop-docker-compose/contributors","subscribers_url":"https://api.github.com/repos/Accenture/adop-docker-compose/subscribers","subscription_url":"https://api.github.com/repos/Accenture/adop-docker-compose/subscription","commits_url":"https://api.github.com/repos/Accenture/adop-docker-compose/commits{/sha}","git_commits_url":"https://api.github.com/repos/Accenture/adop-docker-compose/git/commits{/sha}","comments_url":"https://api.github.com/repos/Accenture/adop-docker-compose/comments{/number}","issue_comment_url":"https://api.github.com/repos/Accenture/adop-docker-compose/issues/comments{/number}","contents_url":"https://api.github.com/repos/Accenture/adop-docker-compose/contents/{+path}","compare_url":"https://api.github.com/repos/Accenture/adop-docker-compose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Accenture/adop-docker-compose/merges","archive_url":"https://api.github.com/repos/Accenture/adop-docker-compose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Accenture/adop-docker-compose/downloads","issues_url":"https://api.github.com/repos/Accenture/adop-docker-compose/issues{/number}","pulls_url":"https://api.github.com/repos/Accenture/adop-docker-compose/pulls{/number}","milestones_url":"https://api.github.com/repos/Accenture/adop-docker-compose/milestones{/number}","notifications_url":"https://api.github.com/repos/Accenture/adop-docker-compose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Accenture/adop-docker-compose/labels{/name}","releases_url":"https://api.github.com/repos/Accenture/adop-docker-compose/releases{/id}","deployments_url":"https://api.github.com/repos/Accenture/adop-docker-compose/deployments","created_at":"2016-02-01T13:33:49Z","updated_at":"2016-08-22T20:38:19Z","pushed_at":"2016-08-25T11:03:52Z","git_url":"git://github.com/Accenture/adop-docker-compose.git","ssh_url":"git@github.com:Accenture/adop-docker-compose.git","clone_url":"https://github.com/Accenture/adop-docker-compose.git","svn_url":"https://github.com/Accenture/adop-docker-compose","homepage":"http://accenture.github.io/adop-docker-compose","size":438,"stargazers_count":78,"watchers_count":78,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":76,"mirror_url":null,"open_issues_count":29,"forks":76,"open_issues":29,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Accenture/adop-docker-compose/pulls/135"},"html":{"href":"https://github.com/Accenture/adop-docker-compose/pull/135"},"issue":{"href":"https://api.github.com/repos/Accenture/adop-docker-compose/issues/135"},"comments":{"href":"https://api.github.com/repos/Accenture/adop-docker-compose/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/Accenture/adop-docker-compose/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/Accenture/adop-docker-compose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Accenture/adop-docker-compose/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/Accenture/adop-docker-compose/statuses/96ee22b24b25c1070064cd40d76fc45a1a70b519"}}}}
{"actor":{"display_login":"anton-kasperovich"}}