{"action":"created","issue":{"url":"https://api.github.com/repos/PrismLibrary/Prism/issues/516","repository_url":"https://api.github.com/repos/PrismLibrary/Prism","labels_url":"https://api.github.com/repos/PrismLibrary/Prism/issues/516/labels{/name}","comments_url":"https://api.github.com/repos/PrismLibrary/Prism/issues/516/comments","events_url":"https://api.github.com/repos/PrismLibrary/Prism/issues/516/events","html_url":"https://github.com/PrismLibrary/Prism/issues/516","id":143598693,"number":516,"title":"[XF] PrismApplication constructor protected and virtual member call","user":{"login":"joacar","id":439028,"avatar_url":"https://avatars.githubusercontent.com/u/439028?v=3","gravatar_id":"","url":"https://api.github.com/users/joacar","html_url":"https://github.com/joacar","followers_url":"https://api.github.com/users/joacar/followers","following_url":"https://api.github.com/users/joacar/following{/other_user}","gists_url":"https://api.github.com/users/joacar/gists{/gist_id}","starred_url":"https://api.github.com/users/joacar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joacar/subscriptions","organizations_url":"https://api.github.com/users/joacar/orgs","repos_url":"https://api.github.com/users/joacar/repos","events_url":"https://api.github.com/users/joacar/events{/privacy}","received_events_url":"https://api.github.com/users/joacar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-25T21:09:18Z","updated_at":"2016-03-25T21:32:06Z","closed_at":null,"body":"If I havn't missed out on something the constructor should be marked protected in `PrismApplication`\r\n\r\nAlso to avoid virtual member call during creation the initialize step should be moved to private method. \r\n\r\nHave a PR ready for this (fix?) if wanted!"},"comment":{"url":"https://api.github.com/repos/PrismLibrary/Prism/issues/comments/201519971","html_url":"https://github.com/PrismLibrary/Prism/issues/516#issuecomment-201519971","issue_url":"https://api.github.com/repos/PrismLibrary/Prism/issues/516","id":201519971,"user":{"login":"brianlagunas","id":835562,"avatar_url":"https://avatars.githubusercontent.com/u/835562?v=3","gravatar_id":"","url":"https://api.github.com/users/brianlagunas","html_url":"https://github.com/brianlagunas","followers_url":"https://api.github.com/users/brianlagunas/followers","following_url":"https://api.github.com/users/brianlagunas/following{/other_user}","gists_url":"https://api.github.com/users/brianlagunas/gists{/gist_id}","starred_url":"https://api.github.com/users/brianlagunas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianlagunas/subscriptions","organizations_url":"https://api.github.com/users/brianlagunas/orgs","repos_url":"https://api.github.com/users/brianlagunas/repos","events_url":"https://api.github.com/users/brianlagunas/events{/privacy}","received_events_url":"https://api.github.com/users/brianlagunas/received_events","type":"User","site_admin":false},"created_at":"2016-03-25T21:32:06Z","updated_at":"2016-03-25T21:32:06Z","body":"Initialize has to be public so that the DI container specific projects can override the implementation.  If this is made private, then the derived PrismApplications would be broken."}}