{"action":"created","issue":{"url":"https://api.github.com/repos/aframevr/aframe/issues/2105","repository_url":"https://api.github.com/repos/aframevr/aframe","labels_url":"https://api.github.com/repos/aframevr/aframe/issues/2105/labels{/name}","comments_url":"https://api.github.com/repos/aframevr/aframe/issues/2105/comments","events_url":"https://api.github.com/repos/aframevr/aframe/issues/2105/events","html_url":"https://github.com/aframevr/aframe/pull/2105","id":189610681,"number":2105,"title":"Add Matrix4 property type","user":{"login":"takahirox","id":7637832,"avatar_url":"https://avatars.githubusercontent.com/u/7637832?v=3","gravatar_id":"","url":"https://api.github.com/users/takahirox","html_url":"https://github.com/takahirox","followers_url":"https://api.github.com/users/takahirox/followers","following_url":"https://api.github.com/users/takahirox/following{/other_user}","gists_url":"https://api.github.com/users/takahirox/gists{/gist_id}","starred_url":"https://api.github.com/users/takahirox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takahirox/subscriptions","organizations_url":"https://api.github.com/users/takahirox/orgs","repos_url":"https://api.github.com/users/takahirox/repos","events_url":"https://api.github.com/users/takahirox/events{/privacy}","received_events_url":"https://api.github.com/users/takahirox/received_events","type":"User","site_admin":false},"labels":[{"id":263329860,"url":"https://api.github.com/repos/aframevr/aframe/labels/needs%20review","name":"needs review","color":"e1fd39","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-16T06:59:49Z","updated_at":"2016-11-17T11:14:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/aframevr/aframe/pulls/2105","html_url":"https://github.com/aframevr/aframe/pull/2105","diff_url":"https://github.com/aframevr/aframe/pull/2105.diff","patch_url":"https://github.com/aframevr/aframe/pull/2105.patch"},"body":"Hi, I added Matrix4 property type #2069\r\nWould you review the code because I'm still new to A-Frame.\r\nLMK if there's any issues.\r\n\r\n**Description:**\r\n\r\nAdd 'matrix4' property type.\r\n\r\nDefault value is\r\n[1, 0, 0, 0,\r\n 0, 1, 0, 0,\r\n 0, 0, 1, 0,\r\n 0, 0, 0, 1]\r\n\r\nInput value is assumed as space separated strings.\r\nex: '0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15'\r\n\r\nIf elements# is greater than 16, it'll be forced to be 16.\r\nIf elements# is less than 16, the shortage will be filled with default value.\r\n\r\n**Changes proposed:**\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/aframevr/aframe/issues/comments/261221067","html_url":"https://github.com/aframevr/aframe/pull/2105#issuecomment-261221067","issue_url":"https://api.github.com/repos/aframevr/aframe/issues/2105","id":261221067,"user":{"login":"fernandojsg","id":782511,"avatar_url":"https://avatars.githubusercontent.com/u/782511?v=3","gravatar_id":"","url":"https://api.github.com/users/fernandojsg","html_url":"https://github.com/fernandojsg","followers_url":"https://api.github.com/users/fernandojsg/followers","following_url":"https://api.github.com/users/fernandojsg/following{/other_user}","gists_url":"https://api.github.com/users/fernandojsg/gists{/gist_id}","starred_url":"https://api.github.com/users/fernandojsg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fernandojsg/subscriptions","organizations_url":"https://api.github.com/users/fernandojsg/orgs","repos_url":"https://api.github.com/users/fernandojsg/repos","events_url":"https://api.github.com/users/fernandojsg/events{/privacy}","received_events_url":"https://api.github.com/users/fernandojsg/received_events","type":"User","site_admin":false},"created_at":"2016-11-17T11:14:22Z","updated_at":"2016-11-17T11:14:22Z","body":"The rightmost column of affine 4x4 matrix is always [0,0,0,1] that's why some engines uses 4x3 matrices instead of 4x4, maybe we could simplify this one using just 4x3 (and then it will be parsed still to a THREE.Matrix4) but without explicitly define the latest column?"}}
{"actor":{"display_login":"fernandojsg"}}