{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-beam/scikit-beam/pulls/comments/80064918","id":80064918,"diff_hunk":"@@ -434,36 +458,26 @@ def __init__(self, rbins, phibins, rowsize, colsize,\n                 will be called on the values in each bin.  Empty bins will be\n                 represented by function([]), or NaN if this returns an error.\n         \"\"\"\n+        if origin is None:\n+            origin = shape[0]//2, shape[1]//2","path":"skbeam/core/accumulators/binned_statistic.py","position":163,"original_position":163,"commit_id":"1c27939932453049b969c5456eede61c98568325","original_commit_id":"1c27939932453049b969c5456eede61c98568325","user":{"login":"ericdill","id":6223243,"avatar_url":"https://avatars.githubusercontent.com/u/6223243?v=3","gravatar_id":"","url":"https://api.github.com/users/ericdill","html_url":"https://github.com/ericdill","followers_url":"https://api.github.com/users/ericdill/followers","following_url":"https://api.github.com/users/ericdill/following{/other_user}","gists_url":"https://api.github.com/users/ericdill/gists{/gist_id}","starred_url":"https://api.github.com/users/ericdill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericdill/subscriptions","organizations_url":"https://api.github.com/users/ericdill/orgs","repos_url":"https://api.github.com/users/ericdill/repos","events_url":"https://api.github.com/users/ericdill/events{/privacy}","received_events_url":"https://api.github.com/users/ericdill/received_events","type":"User","site_admin":false},"body":"I mean in general I don't have any issue with it.  I was mostly curious as to how frequently that issue would be hit.  \r\n\r\nnit: you don't need the `.` after the `2` since we are importing `division` from `__future__` which makes division with `/` always do float division","created_at":"2016-09-22T15:17:20Z","updated_at":"2016-09-22T15:17:20Z","html_url":"https://github.com/scikit-beam/scikit-beam/pull/466#discussion_r80064918","pull_request_url":"https://api.github.com/repos/scikit-beam/scikit-beam/pulls/466","_links":{"self":{"href":"https://api.github.com/repos/scikit-beam/scikit-beam/pulls/comments/80064918"},"html":{"href":"https://github.com/scikit-beam/scikit-beam/pull/466#discussion_r80064918"},"pull_request":{"href":"https://api.github.com/repos/scikit-beam/scikit-beam/pulls/466"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-beam/scikit-beam/pulls/466","id":84795041,"html_url":"https://github.com/scikit-beam/scikit-beam/pull/466","diff_url":"https://github.com/scikit-beam/scikit-beam/pull/466.diff","patch_url":"https://github.com/scikit-beam/scikit-beam/pull/466.patch","issue_url":"https://api.github.com/repos/scikit-beam/scikit-beam/issues/466","number":466,"state":"closed","locked":false,"title":"Generalize binning","user":{"login":"chrisvam","id":6949021,"avatar_url":"https://avatars.githubusercontent.com/u/6949021?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisvam","html_url":"https://github.com/chrisvam","followers_url":"https://api.github.com/users/chrisvam/followers","following_url":"https://api.github.com/users/chrisvam/following{/other_user}","gists_url":"https://api.github.com/users/chrisvam/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvam/subscriptions","organizations_url":"https://api.github.com/users/chrisvam/orgs","repos_url":"https://api.github.com/users/chrisvam/repos","events_url":"https://api.github.com/users/chrisvam/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvam/received_events","type":"User","site_admin":false},"body":"As I discussed previously with Tom, I realized that the binning specification in the RPhiBinnedStatistic and RadialBinnedStatistic was not as flexible as what was underneath in the scipy binned_statistic code.  This PR tries to address that.  Over the course of doing this, it became clear that my inheritance wasn't structured correctly, so I tried to fix that.\r\n\r\nThere are three things that seem non-ideal to me:\r\n\r\n- the way I implement masking (which is not available in scipy.binned_statistic) is imperfect, but it's the best I can see at the moment.  see comments in code\r\n- there are about 10 lines of code that are duplicated in both RPhiBinnedStatistic and RadialBinnedStatistic.  I might be able to fix this with some inheritance or fancy python tricks\r\n- I should test RPhiBinnedStatistic using scipy.binned_statistic_2d\r\n\r\nBut this PR improves the interface, which is important.\r\n\r\np.s. this time I started out with a fresh fork/clone and did the \"magic 4 commands\" that Tom sent me to create the feature-branch.  So hopefully there will not be git issues this time.  Learning.","created_at":"2016-09-11T19:13:30Z","updated_at":"2016-09-22T15:17:20Z","closed_at":"2016-09-21T14:23:14Z","merged_at":"2016-09-21T14:23:14Z","merge_commit_sha":"4e475034b608ffd2105e34d2e9828140ce3a4044","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scikit-beam/scikit-beam/pulls/466/commits","review_comments_url":"https://api.github.com/repos/scikit-beam/scikit-beam/pulls/466/comments","review_comment_url":"https://api.github.com/repos/scikit-beam/scikit-beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-beam/scikit-beam/issues/466/comments","statuses_url":"https://api.github.com/repos/scikit-beam/scikit-beam/statuses/1c27939932453049b969c5456eede61c98568325","head":{"label":"chrisvam:binstat_binfix","ref":"binstat_binfix","sha":"1c27939932453049b969c5456eede61c98568325","user":{"login":"chrisvam","id":6949021,"avatar_url":"https://avatars.githubusercontent.com/u/6949021?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisvam","html_url":"https://github.com/chrisvam","followers_url":"https://api.github.com/users/chrisvam/followers","following_url":"https://api.github.com/users/chrisvam/following{/other_user}","gists_url":"https://api.github.com/users/chrisvam/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvam/subscriptions","organizations_url":"https://api.github.com/users/chrisvam/orgs","repos_url":"https://api.github.com/users/chrisvam/repos","events_url":"https://api.github.com/users/chrisvam/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvam/received_events","type":"User","site_admin":false},"repo":{"id":67459069,"name":"scikit-beam","full_name":"chrisvam/scikit-beam","owner":{"login":"chrisvam","id":6949021,"avatar_url":"https://avatars.githubusercontent.com/u/6949021?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisvam","html_url":"https://github.com/chrisvam","followers_url":"https://api.github.com/users/chrisvam/followers","following_url":"https://api.github.com/users/chrisvam/following{/other_user}","gists_url":"https://api.github.com/users/chrisvam/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvam/subscriptions","organizations_url":"https://api.github.com/users/chrisvam/orgs","repos_url":"https://api.github.com/users/chrisvam/repos","events_url":"https://api.github.com/users/chrisvam/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrisvam/scikit-beam","description":"Data analysis tools for X-Ray, Neutron and Electron sciences","fork":true,"url":"https://api.github.com/repos/chrisvam/scikit-beam","forks_url":"https://api.github.com/repos/chrisvam/scikit-beam/forks","keys_url":"https://api.github.com/repos/chrisvam/scikit-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrisvam/scikit-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrisvam/scikit-beam/teams","hooks_url":"https://api.github.com/repos/chrisvam/scikit-beam/hooks","issue_events_url":"https://api.github.com/repos/chrisvam/scikit-beam/issues/events{/number}","events_url":"https://api.github.com/repos/chrisvam/scikit-beam/events","assignees_url":"https://api.github.com/repos/chrisvam/scikit-beam/assignees{/user}","branches_url":"https://api.github.com/repos/chrisvam/scikit-beam/branches{/branch}","tags_url":"https://api.github.com/repos/chrisvam/scikit-beam/tags","blobs_url":"https://api.github.com/repos/chrisvam/scikit-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrisvam/scikit-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrisvam/scikit-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrisvam/scikit-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrisvam/scikit-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/chrisvam/scikit-beam/languages","stargazers_url":"https://api.github.com/repos/chrisvam/scikit-beam/stargazers","contributors_url":"https://api.github.com/repos/chrisvam/scikit-beam/contributors","subscribers_url":"https://api.github.com/repos/chrisvam/scikit-beam/subscribers","subscription_url":"https://api.github.com/repos/chrisvam/scikit-beam/subscription","commits_url":"https://api.github.com/repos/chrisvam/scikit-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrisvam/scikit-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrisvam/scikit-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrisvam/scikit-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrisvam/scikit-beam/contents/{+path}","compare_url":"https://api.github.com/repos/chrisvam/scikit-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrisvam/scikit-beam/merges","archive_url":"https://api.github.com/repos/chrisvam/scikit-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrisvam/scikit-beam/downloads","issues_url":"https://api.github.com/repos/chrisvam/scikit-beam/issues{/number}","pulls_url":"https://api.github.com/repos/chrisvam/scikit-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/chrisvam/scikit-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/chrisvam/scikit-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrisvam/scikit-beam/labels{/name}","releases_url":"https://api.github.com/repos/chrisvam/scikit-beam/releases{/id}","deployments_url":"https://api.github.com/repos/chrisvam/scikit-beam/deployments","created_at":"2016-09-06T00:23:39Z","updated_at":"2016-09-06T00:23:42Z","pushed_at":"2016-09-22T03:25:12Z","git_url":"git://github.com/chrisvam/scikit-beam.git","ssh_url":"git@github.com:chrisvam/scikit-beam.git","clone_url":"https://github.com/chrisvam/scikit-beam.git","svn_url":"https://github.com/chrisvam/scikit-beam","homepage":"","size":3925,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-beam:master","ref":"master","sha":"403fda4f0b93344e58da5e54090ff796c8d7cbee","user":{"login":"scikit-beam","id":16195776,"avatar_url":"https://avatars.githubusercontent.com/u/16195776?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-beam","html_url":"https://github.com/scikit-beam","followers_url":"https://api.github.com/users/scikit-beam/followers","following_url":"https://api.github.com/users/scikit-beam/following{/other_user}","gists_url":"https://api.github.com/users/scikit-beam/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-beam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-beam/subscriptions","organizations_url":"https://api.github.com/users/scikit-beam/orgs","repos_url":"https://api.github.com/users/scikit-beam/repos","events_url":"https://api.github.com/users/scikit-beam/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-beam/received_events","type":"Organization","site_admin":false},"repo":{"id":21679569,"name":"scikit-beam","full_name":"scikit-beam/scikit-beam","owner":{"login":"scikit-beam","id":16195776,"avatar_url":"https://avatars.githubusercontent.com/u/16195776?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-beam","html_url":"https://github.com/scikit-beam","followers_url":"https://api.github.com/users/scikit-beam/followers","following_url":"https://api.github.com/users/scikit-beam/following{/other_user}","gists_url":"https://api.github.com/users/scikit-beam/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-beam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-beam/subscriptions","organizations_url":"https://api.github.com/users/scikit-beam/orgs","repos_url":"https://api.github.com/users/scikit-beam/repos","events_url":"https://api.github.com/users/scikit-beam/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-beam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-beam/scikit-beam","description":"Data analysis tools for X-Ray, Neutron and Electron sciences","fork":false,"url":"https://api.github.com/repos/scikit-beam/scikit-beam","forks_url":"https://api.github.com/repos/scikit-beam/scikit-beam/forks","keys_url":"https://api.github.com/repos/scikit-beam/scikit-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-beam/scikit-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-beam/scikit-beam/teams","hooks_url":"https://api.github.com/repos/scikit-beam/scikit-beam/hooks","issue_events_url":"https://api.github.com/repos/scikit-beam/scikit-beam/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-beam/scikit-beam/events","assignees_url":"https://api.github.com/repos/scikit-beam/scikit-beam/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-beam/scikit-beam/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-beam/scikit-beam/tags","blobs_url":"https://api.github.com/repos/scikit-beam/scikit-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-beam/scikit-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-beam/scikit-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-beam/scikit-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-beam/scikit-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-beam/scikit-beam/languages","stargazers_url":"https://api.github.com/repos/scikit-beam/scikit-beam/stargazers","contributors_url":"https://api.github.com/repos/scikit-beam/scikit-beam/contributors","subscribers_url":"https://api.github.com/repos/scikit-beam/scikit-beam/subscribers","subscription_url":"https://api.github.com/repos/scikit-beam/scikit-beam/subscription","commits_url":"https://api.github.com/repos/scikit-beam/scikit-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-beam/scikit-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-beam/scikit-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-beam/scikit-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-beam/scikit-beam/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-beam/scikit-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-beam/scikit-beam/merges","archive_url":"https://api.github.com/repos/scikit-beam/scikit-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-beam/scikit-beam/downloads","issues_url":"https://api.github.com/repos/scikit-beam/scikit-beam/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-beam/scikit-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-beam/scikit-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-beam/scikit-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-beam/scikit-beam/labels{/name}","releases_url":"https://api.github.com/repos/scikit-beam/scikit-beam/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-beam/scikit-beam/deployments","created_at":"2014-07-10T04:44:35Z","updated_at":"2016-09-15T21:25:24Z","pushed_at":"2016-09-22T12:50:34Z","git_url":"git://github.com/scikit-beam/scikit-beam.git","ssh_url":"git@github.com:scikit-beam/scikit-beam.git","clone_url":"https://github.com/scikit-beam/scikit-beam.git","svn_url":"https://github.com/scikit-beam/scikit-beam","homepage":"","size":49644,"stargazers_count":30,"watchers_count":30,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":43,"mirror_url":null,"open_issues_count":67,"forks":43,"open_issues":67,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-beam/scikit-beam/pulls/466"},"html":{"href":"https://github.com/scikit-beam/scikit-beam/pull/466"},"issue":{"href":"https://api.github.com/repos/scikit-beam/scikit-beam/issues/466"},"comments":{"href":"https://api.github.com/repos/scikit-beam/scikit-beam/issues/466/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-beam/scikit-beam/pulls/466/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-beam/scikit-beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-beam/scikit-beam/pulls/466/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-beam/scikit-beam/statuses/1c27939932453049b969c5456eede61c98568325"}}}}
{"actor":{"display_login":"ericdill"}}