{"action":"closed","number":672,"pull_request":{"url":"https://api.github.com/repos/tc39/test262/pulls/672","id":73578026,"html_url":"https://github.com/tc39/test262/pull/672","diff_url":"https://github.com/tc39/test262/pull/672.diff","patch_url":"https://github.com/tc39/test262/pull/672.patch","issue_url":"https://api.github.com/repos/tc39/test262/issues/672","number":672,"state":"closed","locked":false,"title":"Improve coverage for \"spread\" operator","user":{"login":"jugglinmike","id":677252,"avatar_url":"https://avatars.githubusercontent.com/u/677252?v=3","gravatar_id":"","url":"https://api.github.com/users/jugglinmike","html_url":"https://github.com/jugglinmike","followers_url":"https://api.github.com/users/jugglinmike/followers","following_url":"https://api.github.com/users/jugglinmike/following{/other_user}","gists_url":"https://api.github.com/users/jugglinmike/gists{/gist_id}","starred_url":"https://api.github.com/users/jugglinmike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jugglinmike/subscriptions","organizations_url":"https://api.github.com/users/jugglinmike/orgs","repos_url":"https://api.github.com/users/jugglinmike/repos","events_url":"https://api.github.com/users/jugglinmike/events{/privacy}","received_events_url":"https://api.github.com/users/jugglinmike/received_events","type":"User","site_admin":false},"body":"As reported in gh-671, Test262's coverage of the spread operator is lacking in\r\nthe following respects:\r\n\r\n- It does not include the use of the operator within array initializers\r\n- It does not include the application of the operator to expressions other than\r\n  Identifiers\r\n\r\nThis patch introduces coverage for both cases.\r\n\r\nExisting coverage of the operator is provided by the test generation tool, and\r\nI wanted to draw attention to that here. In order to re-use the same test\r\ncases, the formulation of these new tests is a little indirect. For instance:\r\n\r\n```js\r\n(function() {\r\n  assert.sameValue(arguments.length, 3);\r\n  assert.sameValue(arguments[0], 3);\r\n  assert.sameValue(arguments[1], 4);\r\n  assert.sameValue(arguments[2], 5);\r\n}.apply(null, [...[3, 4, 5]]));\r\n```\r\n\r\nReferencing the array instance would be more direct, but it would not\r\ngeneralize for re-use with the existing tests for MemberExpression,\r\nCallExpression, and SuperCall.\r\n\r\n","created_at":"2016-06-13T13:46:51Z","updated_at":"2016-06-14T13:47:35Z","closed_at":"2016-06-14T13:47:35Z","merged_at":"2016-06-14T13:47:35Z","merge_commit_sha":"88bc7fe7586f161201c5f14f55c9c489f82b1b67","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tc39/test262/pulls/672/commits","review_comments_url":"https://api.github.com/repos/tc39/test262/pulls/672/comments","review_comment_url":"https://api.github.com/repos/tc39/test262/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tc39/test262/issues/672/comments","statuses_url":"https://api.github.com/repos/tc39/test262/statuses/f91886421d12e4b074b2d83dffea76e37db604e1","head":{"label":"bocoup:spread-coverage","ref":"spread-coverage","sha":"f91886421d12e4b074b2d83dffea76e37db604e1","user":{"login":"bocoup","id":497466,"avatar_url":"https://avatars.githubusercontent.com/u/497466?v=3","gravatar_id":"","url":"https://api.github.com/users/bocoup","html_url":"https://github.com/bocoup","followers_url":"https://api.github.com/users/bocoup/followers","following_url":"https://api.github.com/users/bocoup/following{/other_user}","gists_url":"https://api.github.com/users/bocoup/gists{/gist_id}","starred_url":"https://api.github.com/users/bocoup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bocoup/subscriptions","organizations_url":"https://api.github.com/users/bocoup/orgs","repos_url":"https://api.github.com/users/bocoup/repos","events_url":"https://api.github.com/users/bocoup/events{/privacy}","received_events_url":"https://api.github.com/users/bocoup/received_events","type":"Organization","site_admin":false},"repo":{"id":30556261,"name":"test262","full_name":"bocoup/test262","owner":{"login":"bocoup","id":497466,"avatar_url":"https://avatars.githubusercontent.com/u/497466?v=3","gravatar_id":"","url":"https://api.github.com/users/bocoup","html_url":"https://github.com/bocoup","followers_url":"https://api.github.com/users/bocoup/followers","following_url":"https://api.github.com/users/bocoup/following{/other_user}","gists_url":"https://api.github.com/users/bocoup/gists{/gist_id}","starred_url":"https://api.github.com/users/bocoup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bocoup/subscriptions","organizations_url":"https://api.github.com/users/bocoup/orgs","repos_url":"https://api.github.com/users/bocoup/repos","events_url":"https://api.github.com/users/bocoup/events{/privacy}","received_events_url":"https://api.github.com/users/bocoup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bocoup/test262","description":"","fork":true,"url":"https://api.github.com/repos/bocoup/test262","forks_url":"https://api.github.com/repos/bocoup/test262/forks","keys_url":"https://api.github.com/repos/bocoup/test262/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bocoup/test262/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bocoup/test262/teams","hooks_url":"https://api.github.com/repos/bocoup/test262/hooks","issue_events_url":"https://api.github.com/repos/bocoup/test262/issues/events{/number}","events_url":"https://api.github.com/repos/bocoup/test262/events","assignees_url":"https://api.github.com/repos/bocoup/test262/assignees{/user}","branches_url":"https://api.github.com/repos/bocoup/test262/branches{/branch}","tags_url":"https://api.github.com/repos/bocoup/test262/tags","blobs_url":"https://api.github.com/repos/bocoup/test262/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bocoup/test262/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bocoup/test262/git/refs{/sha}","trees_url":"https://api.github.com/repos/bocoup/test262/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bocoup/test262/statuses/{sha}","languages_url":"https://api.github.com/repos/bocoup/test262/languages","stargazers_url":"https://api.github.com/repos/bocoup/test262/stargazers","contributors_url":"https://api.github.com/repos/bocoup/test262/contributors","subscribers_url":"https://api.github.com/repos/bocoup/test262/subscribers","subscription_url":"https://api.github.com/repos/bocoup/test262/subscription","commits_url":"https://api.github.com/repos/bocoup/test262/commits{/sha}","git_commits_url":"https://api.github.com/repos/bocoup/test262/git/commits{/sha}","comments_url":"https://api.github.com/repos/bocoup/test262/comments{/number}","issue_comment_url":"https://api.github.com/repos/bocoup/test262/issues/comments{/number}","contents_url":"https://api.github.com/repos/bocoup/test262/contents/{+path}","compare_url":"https://api.github.com/repos/bocoup/test262/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bocoup/test262/merges","archive_url":"https://api.github.com/repos/bocoup/test262/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bocoup/test262/downloads","issues_url":"https://api.github.com/repos/bocoup/test262/issues{/number}","pulls_url":"https://api.github.com/repos/bocoup/test262/pulls{/number}","milestones_url":"https://api.github.com/repos/bocoup/test262/milestones{/number}","notifications_url":"https://api.github.com/repos/bocoup/test262/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bocoup/test262/labels{/name}","releases_url":"https://api.github.com/repos/bocoup/test262/releases{/id}","deployments_url":"https://api.github.com/repos/bocoup/test262/deployments","created_at":"2015-02-09T20:17:23Z","updated_at":"2016-02-10T20:14:58Z","pushed_at":"2016-06-13T19:42:05Z","git_url":"git://github.com/bocoup/test262.git","ssh_url":"git@github.com:bocoup/test262.git","clone_url":"https://github.com/bocoup/test262.git","svn_url":"https://github.com/bocoup/test262","homepage":"http://test262.ecmascript.org","size":55944,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":64,"forks":0,"open_issues":64,"watchers":0,"default_branch":"master"}},"base":{"label":"tc39:master","ref":"master","sha":"dee1526ca75ad5ff7e14ef1096cbf55c8d3a0f4c","user":{"login":"tc39","id":1725583,"avatar_url":"https://avatars.githubusercontent.com/u/1725583?v=3","gravatar_id":"","url":"https://api.github.com/users/tc39","html_url":"https://github.com/tc39","followers_url":"https://api.github.com/users/tc39/followers","following_url":"https://api.github.com/users/tc39/following{/other_user}","gists_url":"https://api.github.com/users/tc39/gists{/gist_id}","starred_url":"https://api.github.com/users/tc39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tc39/subscriptions","organizations_url":"https://api.github.com/users/tc39/orgs","repos_url":"https://api.github.com/users/tc39/repos","events_url":"https://api.github.com/users/tc39/events{/privacy}","received_events_url":"https://api.github.com/users/tc39/received_events","type":"Organization","site_admin":false},"repo":{"id":16147933,"name":"test262","full_name":"tc39/test262","owner":{"login":"tc39","id":1725583,"avatar_url":"https://avatars.githubusercontent.com/u/1725583?v=3","gravatar_id":"","url":"https://api.github.com/users/tc39","html_url":"https://github.com/tc39","followers_url":"https://api.github.com/users/tc39/followers","following_url":"https://api.github.com/users/tc39/following{/other_user}","gists_url":"https://api.github.com/users/tc39/gists{/gist_id}","starred_url":"https://api.github.com/users/tc39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tc39/subscriptions","organizations_url":"https://api.github.com/users/tc39/orgs","repos_url":"https://api.github.com/users/tc39/repos","events_url":"https://api.github.com/users/tc39/events{/privacy}","received_events_url":"https://api.github.com/users/tc39/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tc39/test262","description":"Official ECMAScript Conformance Test Suite","fork":false,"url":"https://api.github.com/repos/tc39/test262","forks_url":"https://api.github.com/repos/tc39/test262/forks","keys_url":"https://api.github.com/repos/tc39/test262/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tc39/test262/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tc39/test262/teams","hooks_url":"https://api.github.com/repos/tc39/test262/hooks","issue_events_url":"https://api.github.com/repos/tc39/test262/issues/events{/number}","events_url":"https://api.github.com/repos/tc39/test262/events","assignees_url":"https://api.github.com/repos/tc39/test262/assignees{/user}","branches_url":"https://api.github.com/repos/tc39/test262/branches{/branch}","tags_url":"https://api.github.com/repos/tc39/test262/tags","blobs_url":"https://api.github.com/repos/tc39/test262/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tc39/test262/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tc39/test262/git/refs{/sha}","trees_url":"https://api.github.com/repos/tc39/test262/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tc39/test262/statuses/{sha}","languages_url":"https://api.github.com/repos/tc39/test262/languages","stargazers_url":"https://api.github.com/repos/tc39/test262/stargazers","contributors_url":"https://api.github.com/repos/tc39/test262/contributors","subscribers_url":"https://api.github.com/repos/tc39/test262/subscribers","subscription_url":"https://api.github.com/repos/tc39/test262/subscription","commits_url":"https://api.github.com/repos/tc39/test262/commits{/sha}","git_commits_url":"https://api.github.com/repos/tc39/test262/git/commits{/sha}","comments_url":"https://api.github.com/repos/tc39/test262/comments{/number}","issue_comment_url":"https://api.github.com/repos/tc39/test262/issues/comments{/number}","contents_url":"https://api.github.com/repos/tc39/test262/contents/{+path}","compare_url":"https://api.github.com/repos/tc39/test262/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tc39/test262/merges","archive_url":"https://api.github.com/repos/tc39/test262/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tc39/test262/downloads","issues_url":"https://api.github.com/repos/tc39/test262/issues{/number}","pulls_url":"https://api.github.com/repos/tc39/test262/pulls{/number}","milestones_url":"https://api.github.com/repos/tc39/test262/milestones{/number}","notifications_url":"https://api.github.com/repos/tc39/test262/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tc39/test262/labels{/name}","releases_url":"https://api.github.com/repos/tc39/test262/releases{/id}","deployments_url":"https://api.github.com/repos/tc39/test262/deployments","created_at":"2014-01-22T18:20:05Z","updated_at":"2016-06-09T13:55:49Z","pushed_at":"2016-06-14T13:47:35Z","git_url":"git://github.com/tc39/test262.git","ssh_url":"git@github.com:tc39/test262.git","clone_url":"https://github.com/tc39/test262.git","svn_url":"https://github.com/tc39/test262","homepage":"","size":57255,"stargazers_count":311,"watchers_count":311,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":100,"mirror_url":null,"open_issues_count":76,"forks":100,"open_issues":76,"watchers":311,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tc39/test262/pulls/672"},"html":{"href":"https://github.com/tc39/test262/pull/672"},"issue":{"href":"https://api.github.com/repos/tc39/test262/issues/672"},"comments":{"href":"https://api.github.com/repos/tc39/test262/issues/672/comments"},"review_comments":{"href":"https://api.github.com/repos/tc39/test262/pulls/672/comments"},"review_comment":{"href":"https://api.github.com/repos/tc39/test262/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tc39/test262/pulls/672/commits"},"statuses":{"href":"https://api.github.com/repos/tc39/test262/statuses/f91886421d12e4b074b2d83dffea76e37db604e1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"leobalter","id":301201,"avatar_url":"https://avatars.githubusercontent.com/u/301201?v=3","gravatar_id":"","url":"https://api.github.com/users/leobalter","html_url":"https://github.com/leobalter","followers_url":"https://api.github.com/users/leobalter/followers","following_url":"https://api.github.com/users/leobalter/following{/other_user}","gists_url":"https://api.github.com/users/leobalter/gists{/gist_id}","starred_url":"https://api.github.com/users/leobalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leobalter/subscriptions","organizations_url":"https://api.github.com/users/leobalter/orgs","repos_url":"https://api.github.com/users/leobalter/repos","events_url":"https://api.github.com/users/leobalter/events{/privacy}","received_events_url":"https://api.github.com/users/leobalter/received_events","type":"User","site_admin":false},"comments":1,"review_comments":1,"commits":3,"additions":1938,"deletions":0,"changed_files":40}}
{"actor":{"display_login":"leobalter"}}