{"action":"created","comment":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/comments/76958775","id":76958775,"diff_hunk":"@@ -0,0 +1,123 @@\n+# Copyright (C) 2016 Google Inc.\n+# Licensed under http://www.apache.org/licenses/LICENSE-2.0 <see LICENSE file>\n+\n+\"\"\"Handlers document entries.\"\"\"\n+\n+from flask import current_app\n+\n+from ggrc import models\n+from ggrc.login import get_current_user_id\n+from ggrc.converters.handlers import handlers\n+\n+\n+class RequestLinkHandler(handlers.ColumnHandler):\n+  \"\"\"Base class for request documents handlers.\"\"\"\n+\n+  def parse_item(self):\n+    \"\"\"Parse document link lines.\n+\n+    Returns:\n+      list of documents for all URLs and evidences.\n+    \"\"\"\n+    documents = []\n+    for line in self.raw_value.splitlines():\n+      link, title = line.split(None, 1) if \" \" in line else (line, line)\n+      documents.append(models.Document(\n+          link=link,\n+          title=title,\n+          modified_by_id=get_current_user_id(),\n+          context=self.row_converter.obj.context,\n+      ))\n+\n+    return documents\n+\n+  @staticmethod\n+  def _get_link_str(documents):\n+    \"\"\"Generate a new line separated string for all document links.\n+\n+    Returns:\n+      string containing all URLs and titles.\n+    \"\"\"\n+    lines = []\n+    for document in documents:\n+      lines.append(\"{} {}\".format(document.link, document.title))\n+    return \"\\n\".join(lines)\n+\n+  def set_obj_attr(self):\n+    self.value = self.parse_item()\n+\n+\n+class RequestEvidenceHandler(RequestLinkHandler):\n+  \"\"\"Handler for evidence field on request imports.\"\"\"\n+\n+  def get_value(self):\n+    return self._get_link_str(self.row_converter.obj.documents)\n+\n+  def insert_object(self):\n+    \"\"\"Update request evidence values\n+\n+    This function adds missing evidence and remove existing ones from requests.\n+    The existing evidence with new titles just change the title.\n+    \"\"\"\n+    if not self.value or self.row_converter.ignore:\n+      return\n+\n+    new_link_map = {doc.link: doc for doc in self.value}\n+    old_link_map = {doc.link: doc for doc in self.row_converter.obj.documents}\n+    for new_link, new_doc in new_link_map.items():","path":"src/ggrc/converters/handlers/document.py","position":67,"original_position":67,"commit_id":"92a036f69446fdbc88bd09f2ac6edff460656082","original_commit_id":"92a036f69446fdbc88bd09f2ac6edff460656082","user":{"login":"kr41","id":961059,"avatar_url":"https://avatars.githubusercontent.com/u/961059?v=3","gravatar_id":"","url":"https://api.github.com/users/kr41","html_url":"https://github.com/kr41","followers_url":"https://api.github.com/users/kr41/followers","following_url":"https://api.github.com/users/kr41/following{/other_user}","gists_url":"https://api.github.com/users/kr41/gists{/gist_id}","starred_url":"https://api.github.com/users/kr41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kr41/subscriptions","organizations_url":"https://api.github.com/users/kr41/orgs","repos_url":"https://api.github.com/users/kr41/repos","events_url":"https://api.github.com/users/kr41/events{/privacy}","received_events_url":"https://api.github.com/users/kr41/received_events","type":"User","site_admin":false},"body":"Since we're not using Python 3.x at all, it would be better to use `iteritems()`.","created_at":"2016-08-31T09:59:34Z","updated_at":"2016-08-31T09:59:34Z","html_url":"https://github.com/google/ggrc-core/pull/4328#discussion_r76958775","pull_request_url":"https://api.github.com/repos/google/ggrc-core/pulls/4328","_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments/76958775"},"html":{"href":"https://github.com/google/ggrc-core/pull/4328#discussion_r76958775"},"pull_request":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/4328"}}},"pull_request":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/4328","id":83372048,"html_url":"https://github.com/google/ggrc-core/pull/4328","diff_url":"https://github.com/google/ggrc-core/pull/4328.diff","patch_url":"https://github.com/google/ggrc-core/pull/4328.patch","issue_url":"https://api.github.com/repos/google/ggrc-core/issues/4328","number":4328,"state":"open","locked":false,"title":"QUICK-FIX Update request import","user":{"login":"zidarsk8","id":566311,"avatar_url":"https://avatars.githubusercontent.com/u/566311?v=3","gravatar_id":"","url":"https://api.github.com/users/zidarsk8","html_url":"https://github.com/zidarsk8","followers_url":"https://api.github.com/users/zidarsk8/followers","following_url":"https://api.github.com/users/zidarsk8/following{/other_user}","gists_url":"https://api.github.com/users/zidarsk8/gists{/gist_id}","starred_url":"https://api.github.com/users/zidarsk8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zidarsk8/subscriptions","organizations_url":"https://api.github.com/users/zidarsk8/orgs","repos_url":"https://api.github.com/users/zidarsk8/repos","events_url":"https://api.github.com/users/zidarsk8/events{/privacy}","received_events_url":"https://api.github.com/users/zidarsk8/received_events","type":"User","site_admin":false},"body":"This Pr fixes request imports to allow importing and exporting of request URLs and evidence.\r\n\r\nFor testing this PR I've used the following sheets:\r\nimport: https://docs.google.com/spreadsheets/d/1Jg8jum2eQfvR3kZNVYbVKizWIGZXvfqv3yQpo2rIiD8/edit#gid=704933240\r\nupdate: https://docs.google.com/spreadsheets/d/1Jg8jum2eQfvR3kZNVYbVKizWIGZXvfqv3yQpo2rIiD8/edit#gid=412878293","created_at":"2016-08-31T00:51:16Z","updated_at":"2016-08-31T09:59:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63c50b4aa89587282c898ab0020a197e49f10514","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/google/ggrc-core/milestones/21","html_url":"https://github.com/google/ggrc-core/milestones/0.9.7-Quince","labels_url":"https://api.github.com/repos/google/ggrc-core/milestones/21/labels","id":1845906,"number":21,"title":"0.9.7-Quince","description":"","creator":{"login":"Smotko","id":513444,"avatar_url":"https://avatars.githubusercontent.com/u/513444?v=3","gravatar_id":"","url":"https://api.github.com/users/Smotko","html_url":"https://github.com/Smotko","followers_url":"https://api.github.com/users/Smotko/followers","following_url":"https://api.github.com/users/Smotko/following{/other_user}","gists_url":"https://api.github.com/users/Smotko/gists{/gist_id}","starred_url":"https://api.github.com/users/Smotko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Smotko/subscriptions","organizations_url":"https://api.github.com/users/Smotko/orgs","repos_url":"https://api.github.com/users/Smotko/repos","events_url":"https://api.github.com/users/Smotko/events{/privacy}","received_events_url":"https://api.github.com/users/Smotko/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":253,"state":"open","created_at":"2016-06-23T17:56:25Z","updated_at":"2016-08-31T09:59:06Z","due_on":"2016-08-14T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/google/ggrc-core/pulls/4328/commits","review_comments_url":"https://api.github.com/repos/google/ggrc-core/pulls/4328/comments","review_comment_url":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/ggrc-core/issues/4328/comments","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/92a036f69446fdbc88bd09f2ac6edff460656082","head":{"label":"zidarsk8:request-import-update","ref":"request-import-update","sha":"92a036f69446fdbc88bd09f2ac6edff460656082","user":{"login":"zidarsk8","id":566311,"avatar_url":"https://avatars.githubusercontent.com/u/566311?v=3","gravatar_id":"","url":"https://api.github.com/users/zidarsk8","html_url":"https://github.com/zidarsk8","followers_url":"https://api.github.com/users/zidarsk8/followers","following_url":"https://api.github.com/users/zidarsk8/following{/other_user}","gists_url":"https://api.github.com/users/zidarsk8/gists{/gist_id}","starred_url":"https://api.github.com/users/zidarsk8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zidarsk8/subscriptions","organizations_url":"https://api.github.com/users/zidarsk8/orgs","repos_url":"https://api.github.com/users/zidarsk8/repos","events_url":"https://api.github.com/users/zidarsk8/events{/privacy}","received_events_url":"https://api.github.com/users/zidarsk8/received_events","type":"User","site_admin":false},"repo":{"id":27515613,"name":"ggrc-core","full_name":"zidarsk8/ggrc-core","owner":{"login":"zidarsk8","id":566311,"avatar_url":"https://avatars.githubusercontent.com/u/566311?v=3","gravatar_id":"","url":"https://api.github.com/users/zidarsk8","html_url":"https://github.com/zidarsk8","followers_url":"https://api.github.com/users/zidarsk8/followers","following_url":"https://api.github.com/users/zidarsk8/following{/other_user}","gists_url":"https://api.github.com/users/zidarsk8/gists{/gist_id}","starred_url":"https://api.github.com/users/zidarsk8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zidarsk8/subscriptions","organizations_url":"https://api.github.com/users/zidarsk8/orgs","repos_url":"https://api.github.com/users/zidarsk8/repos","events_url":"https://api.github.com/users/zidarsk8/events{/privacy}","received_events_url":"https://api.github.com/users/zidarsk8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zidarsk8/ggrc-core","description":"GGRC Core","fork":true,"url":"https://api.github.com/repos/zidarsk8/ggrc-core","forks_url":"https://api.github.com/repos/zidarsk8/ggrc-core/forks","keys_url":"https://api.github.com/repos/zidarsk8/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zidarsk8/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zidarsk8/ggrc-core/teams","hooks_url":"https://api.github.com/repos/zidarsk8/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/zidarsk8/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/zidarsk8/ggrc-core/events","assignees_url":"https://api.github.com/repos/zidarsk8/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/zidarsk8/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/zidarsk8/ggrc-core/tags","blobs_url":"https://api.github.com/repos/zidarsk8/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zidarsk8/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zidarsk8/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/zidarsk8/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zidarsk8/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/zidarsk8/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/zidarsk8/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/zidarsk8/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/zidarsk8/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/zidarsk8/ggrc-core/subscription","commits_url":"https://api.github.com/repos/zidarsk8/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/zidarsk8/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/zidarsk8/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/zidarsk8/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/zidarsk8/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/zidarsk8/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zidarsk8/ggrc-core/merges","archive_url":"https://api.github.com/repos/zidarsk8/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zidarsk8/ggrc-core/downloads","issues_url":"https://api.github.com/repos/zidarsk8/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/zidarsk8/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/zidarsk8/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/zidarsk8/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zidarsk8/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/zidarsk8/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/zidarsk8/ggrc-core/deployments","created_at":"2014-12-04T00:47:01Z","updated_at":"2016-01-11T15:13:48Z","pushed_at":"2016-08-31T08:34:28Z","git_url":"git://github.com/zidarsk8/ggrc-core.git","ssh_url":"git@github.com:zidarsk8/ggrc-core.git","clone_url":"https://github.com/zidarsk8/ggrc-core.git","svn_url":"https://github.com/zidarsk8/ggrc-core","homepage":null,"size":54302,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"google:develop","ref":"develop","sha":"106ab4cecea9d2b7569a914d7d0ca6fafb67a24d","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":9304637,"name":"ggrc-core","full_name":"google/ggrc-core","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/ggrc-core","description":"GGRC Core","fork":false,"url":"https://api.github.com/repos/google/ggrc-core","forks_url":"https://api.github.com/repos/google/ggrc-core/forks","keys_url":"https://api.github.com/repos/google/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/ggrc-core/teams","hooks_url":"https://api.github.com/repos/google/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/google/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/google/ggrc-core/events","assignees_url":"https://api.github.com/repos/google/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/google/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/google/ggrc-core/tags","blobs_url":"https://api.github.com/repos/google/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/google/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/google/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/google/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/google/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/google/ggrc-core/subscription","commits_url":"https://api.github.com/repos/google/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/google/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/ggrc-core/merges","archive_url":"https://api.github.com/repos/google/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/ggrc-core/downloads","issues_url":"https://api.github.com/repos/google/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/google/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/google/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/google/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/google/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/google/ggrc-core/deployments","created_at":"2013-04-08T19:16:28Z","updated_at":"2016-08-31T09:11:18Z","pushed_at":"2016-08-31T09:59:06Z","git_url":"git://github.com/google/ggrc-core.git","ssh_url":"git@github.com:google/ggrc-core.git","clone_url":"https://github.com/google/ggrc-core.git","svn_url":"https://github.com/google/ggrc-core","homepage":null,"size":64815,"stargazers_count":125,"watchers_count":125,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":95,"mirror_url":null,"open_issues_count":18,"forks":95,"open_issues":18,"watchers":125,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/4328"},"html":{"href":"https://github.com/google/ggrc-core/pull/4328"},"issue":{"href":"https://api.github.com/repos/google/ggrc-core/issues/4328"},"comments":{"href":"https://api.github.com/repos/google/ggrc-core/issues/4328/comments"},"review_comments":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/4328/comments"},"review_comment":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/4328/commits"},"statuses":{"href":"https://api.github.com/repos/google/ggrc-core/statuses/92a036f69446fdbc88bd09f2ac6edff460656082"}}}}
{"actor":{"display_login":"kr41"}}