{"action":"created","comment":{"url":"https://api.github.com/repos/saltstack/salt/pulls/comments/80868903","pull_request_review_id":1890988,"id":80868903,"diff_hunk":"@@ -1158,6 +1158,41 @@ def _handle_decoded_payload(self, data):\n         else:\n             self.win_proc.append(process)\n \n+\t\t\t\n+     def _check_moduleReadyness(self,function_name, minion_instance): ","path":"salt/minion.py","position":5,"original_position":5,"commit_id":"cf9e25c6e16316967b1b9e8b3519207f10cb56c1","original_commit_id":"cf9e25c6e16316967b1b9e8b3519207f10cb56c1","user":{"login":"s0undt3ch","id":300048,"avatar_url":"https://avatars.githubusercontent.com/u/300048?v=3","gravatar_id":"","url":"https://api.github.com/users/s0undt3ch","html_url":"https://github.com/s0undt3ch","followers_url":"https://api.github.com/users/s0undt3ch/followers","following_url":"https://api.github.com/users/s0undt3ch/following{/other_user}","gists_url":"https://api.github.com/users/s0undt3ch/gists{/gist_id}","starred_url":"https://api.github.com/users/s0undt3ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s0undt3ch/subscriptions","organizations_url":"https://api.github.com/users/s0undt3ch/orgs","repos_url":"https://api.github.com/users/s0undt3ch/repos","events_url":"https://api.github.com/users/s0undt3ch/events{/privacy}","received_events_url":"https://api.github.com/users/s0undt3ch/received_events","type":"User","site_admin":false},"body":"Please, no camel case, underscores to split words is preferable.","created_at":"2016-09-28T08:48:47Z","updated_at":"2016-09-28T08:50:42Z","html_url":"https://github.com/saltstack/salt/pull/36625#discussion_r80868903","pull_request_url":"https://api.github.com/repos/saltstack/salt/pulls/36625","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/80868903"},"html":{"href":"https://github.com/saltstack/salt/pull/36625#discussion_r80868903"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt/pulls/36625"}}},"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/36625","id":87050750,"html_url":"https://github.com/saltstack/salt/pull/36625","diff_url":"https://github.com/saltstack/salt/pull/36625.diff","patch_url":"https://github.com/saltstack/salt/pull/36625.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/36625","number":36625,"state":"open","locked":false,"title":"Automate module downloading from salt-master","user":{"login":"bllackeye","id":22462625,"avatar_url":"https://avatars.githubusercontent.com/u/22462625?v=3","gravatar_id":"","url":"https://api.github.com/users/bllackeye","html_url":"https://github.com/bllackeye","followers_url":"https://api.github.com/users/bllackeye/followers","following_url":"https://api.github.com/users/bllackeye/following{/other_user}","gists_url":"https://api.github.com/users/bllackeye/gists{/gist_id}","starred_url":"https://api.github.com/users/bllackeye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bllackeye/subscriptions","organizations_url":"https://api.github.com/users/bllackeye/orgs","repos_url":"https://api.github.com/users/bllackeye/repos","events_url":"https://api.github.com/users/bllackeye/events{/privacy}","received_events_url":"https://api.github.com/users/bllackeye/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n\r\nAutomate module downloading into salt-minion. \r\n\r\n### What issues does this PR fix or reference?\r\n\r\n### Previous Behavior\r\nIn order to distribute  custom modules to minions, users have to run saltutils.sync_modules to inform concerned minions to pull modules from salt-master.  \r\n\r\nIf the custom module to run is not synchronised to the minion and loaded into memory,  salt-minion throws exception. \r\n\r\n### New Behavior\r\nUpon receiving a message, the targeted salt minion will check the readiness of the module to run. If the concerned module is not ready, the targeted salt minion automatically tries to sync modules into the minion and loads them before trying to run the modules. \r\n\r\n\r\n\r\n### Tests written?\r\n\r\nNo\r\n\r\nPlease review [Salt's Contributing Guide](https://docs.saltstack.com/en/latest/topics/development/contributing.html) for best practices.\r\n\r\n1) before invoke a function, the minion check the readyness of the\r\nfunction.\r\n2) the minion will try to download modules and load the modules if the\r\nrequired module is not ready.","created_at":"2016-09-28T03:50:55Z","updated_at":"2016-09-28T08:50:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbeb36603636221ac0cca04ca2de0b3ae936d284","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/36625/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/36625/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/36625/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/cf9e25c6e16316967b1b9e8b3519207f10cb56c1","head":{"label":"bllackeye:2015.5","ref":"2015.5","sha":"cf9e25c6e16316967b1b9e8b3519207f10cb56c1","user":{"login":"bllackeye","id":22462625,"avatar_url":"https://avatars.githubusercontent.com/u/22462625?v=3","gravatar_id":"","url":"https://api.github.com/users/bllackeye","html_url":"https://github.com/bllackeye","followers_url":"https://api.github.com/users/bllackeye/followers","following_url":"https://api.github.com/users/bllackeye/following{/other_user}","gists_url":"https://api.github.com/users/bllackeye/gists{/gist_id}","starred_url":"https://api.github.com/users/bllackeye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bllackeye/subscriptions","organizations_url":"https://api.github.com/users/bllackeye/orgs","repos_url":"https://api.github.com/users/bllackeye/repos","events_url":"https://api.github.com/users/bllackeye/events{/privacy}","received_events_url":"https://api.github.com/users/bllackeye/received_events","type":"User","site_admin":false},"repo":{"id":69311300,"name":"salt","full_name":"bllackeye/salt","owner":{"login":"bllackeye","id":22462625,"avatar_url":"https://avatars.githubusercontent.com/u/22462625?v=3","gravatar_id":"","url":"https://api.github.com/users/bllackeye","html_url":"https://github.com/bllackeye","followers_url":"https://api.github.com/users/bllackeye/followers","following_url":"https://api.github.com/users/bllackeye/following{/other_user}","gists_url":"https://api.github.com/users/bllackeye/gists{/gist_id}","starred_url":"https://api.github.com/users/bllackeye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bllackeye/subscriptions","organizations_url":"https://api.github.com/users/bllackeye/orgs","repos_url":"https://api.github.com/users/bllackeye/repos","events_url":"https://api.github.com/users/bllackeye/events{/privacy}","received_events_url":"https://api.github.com/users/bllackeye/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bllackeye/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt Open software package repository here: ","fork":true,"url":"https://api.github.com/repos/bllackeye/salt","forks_url":"https://api.github.com/repos/bllackeye/salt/forks","keys_url":"https://api.github.com/repos/bllackeye/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bllackeye/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bllackeye/salt/teams","hooks_url":"https://api.github.com/repos/bllackeye/salt/hooks","issue_events_url":"https://api.github.com/repos/bllackeye/salt/issues/events{/number}","events_url":"https://api.github.com/repos/bllackeye/salt/events","assignees_url":"https://api.github.com/repos/bllackeye/salt/assignees{/user}","branches_url":"https://api.github.com/repos/bllackeye/salt/branches{/branch}","tags_url":"https://api.github.com/repos/bllackeye/salt/tags","blobs_url":"https://api.github.com/repos/bllackeye/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bllackeye/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bllackeye/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/bllackeye/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bllackeye/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/bllackeye/salt/languages","stargazers_url":"https://api.github.com/repos/bllackeye/salt/stargazers","contributors_url":"https://api.github.com/repos/bllackeye/salt/contributors","subscribers_url":"https://api.github.com/repos/bllackeye/salt/subscribers","subscription_url":"https://api.github.com/repos/bllackeye/salt/subscription","commits_url":"https://api.github.com/repos/bllackeye/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/bllackeye/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/bllackeye/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/bllackeye/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/bllackeye/salt/contents/{+path}","compare_url":"https://api.github.com/repos/bllackeye/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bllackeye/salt/merges","archive_url":"https://api.github.com/repos/bllackeye/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bllackeye/salt/downloads","issues_url":"https://api.github.com/repos/bllackeye/salt/issues{/number}","pulls_url":"https://api.github.com/repos/bllackeye/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/bllackeye/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/bllackeye/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bllackeye/salt/labels{/name}","releases_url":"https://api.github.com/repos/bllackeye/salt/releases{/id}","deployments_url":"https://api.github.com/repos/bllackeye/salt/deployments","created_at":"2016-09-27T02:24:09Z","updated_at":"2016-09-27T08:38:25Z","pushed_at":"2016-09-28T05:33:28Z","git_url":"git://github.com/bllackeye/salt.git","ssh_url":"git@github.com:bllackeye/salt.git","clone_url":"https://github.com/bllackeye/salt.git","svn_url":"https://github.com/bllackeye/salt","homepage":"https://repo.saltstack.com/","size":145443,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"saltstack:2015.5","ref":"2015.5","sha":"57df38e685f3b5015734e44a70aa09b28ee6ac37","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt Open software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2016-09-28T08:33:38Z","pushed_at":"2016-09-28T05:50:50Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":224067,"stargazers_count":6911,"watchers_count":6911,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3147,"mirror_url":null,"open_issues_count":3857,"forks":3147,"open_issues":3857,"watchers":6911,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/36625"},"html":{"href":"https://github.com/saltstack/salt/pull/36625"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/36625"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/36625/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/36625/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/36625/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/cf9e25c6e16316967b1b9e8b3519207f10cb56c1"}}}}
{"actor":{"display_login":"s0undt3ch"}}