{"action":"created","issue":{"url":"https://api.github.com/repos/hadley/dplyr/issues/1997","repository_url":"https://api.github.com/repos/hadley/dplyr","labels_url":"https://api.github.com/repos/hadley/dplyr/issues/1997/labels{/name}","comments_url":"https://api.github.com/repos/hadley/dplyr/issues/1997/comments","events_url":"https://api.github.com/repos/hadley/dplyr/issues/1997/events","html_url":"https://github.com/hadley/dplyr/pull/1997","id":163913263,"number":1997,"title":"make inner joins explicit to avoid using","user":{"login":"javierluraschi","id":3478847,"avatar_url":"https://avatars.githubusercontent.com/u/3478847?v=3","gravatar_id":"","url":"https://api.github.com/users/javierluraschi","html_url":"https://github.com/javierluraschi","followers_url":"https://api.github.com/users/javierluraschi/followers","following_url":"https://api.github.com/users/javierluraschi/following{/other_user}","gists_url":"https://api.github.com/users/javierluraschi/gists{/gist_id}","starred_url":"https://api.github.com/users/javierluraschi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierluraschi/subscriptions","organizations_url":"https://api.github.com/users/javierluraschi/orgs","repos_url":"https://api.github.com/users/javierluraschi/repos","events_url":"https://api.github.com/users/javierluraschi/events{/privacy}","received_events_url":"https://api.github.com/users/javierluraschi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-07-05T18:17:18Z","updated_at":"2016-10-03T07:21:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hadley/dplyr/pulls/1997","html_url":"https://github.com/hadley/dplyr/pull/1997","diff_url":"https://github.com/hadley/dplyr/pull/1997.diff","patch_url":"https://github.com/hadley/dplyr/pull/1997.patch"},"body":"@hadley Spark and SQL Server have issues with the `USING` statement and natural joins respectively. This change removes the use of `USING` by making joins explicit at all times. Feedback welcomed. Example follows:\r\n\r\n```\r\nlibrary(dplyr)\r\nsrc <- src_sqlite(tempfile(), create = TRUE)\r\ndata_frame(a = 1:3, b = letters[1:3]) %>% copy_to(src, ., \"df1\")\r\ndata_frame(b = letters[1:3], c = letters[24:26]) %>% copy_to(src, ., \"df2\")\r\n```\r\n\r\nWithout this PR: `left_join(tbl(src, \"df1\"), tbl(src, \"df2\"))`:\r\n\r\n```\r\n<SQL> SELECT * FROM 'df1'\r\n\r\nLEFT JOIN\r\n\r\n'df2'\r\n\r\nUSING ('b')\r\n```\r\n\r\nwith this PR: `left_join(tbl(src, \"df1\"), tbl(src, \"df2\"))`:\r\n\r\n```\r\nSELECT 'a', 'c', 'b.x' AS 'b'\r\nFROM (\r\n   SELECT * FROM \r\n      (SELECT 'a' AS 'a', 'b' AS 'b.x' FROM 'df1')\r\n   LEFT JOIN\r\n      (SELECT 'b' AS 'b.y', 'c' AS 'c' FROM 'df2')\r\n   ON ('b.x' = 'b.y')\r\n)\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/hadley/dplyr/issues/comments/251042075","html_url":"https://github.com/hadley/dplyr/pull/1997#issuecomment-251042075","issue_url":"https://api.github.com/repos/hadley/dplyr/issues/1997","id":251042075,"user":{"login":"imanuelcostigan","id":2107580,"avatar_url":"https://avatars.githubusercontent.com/u/2107580?v=3","gravatar_id":"","url":"https://api.github.com/users/imanuelcostigan","html_url":"https://github.com/imanuelcostigan","followers_url":"https://api.github.com/users/imanuelcostigan/followers","following_url":"https://api.github.com/users/imanuelcostigan/following{/other_user}","gists_url":"https://api.github.com/users/imanuelcostigan/gists{/gist_id}","starred_url":"https://api.github.com/users/imanuelcostigan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imanuelcostigan/subscriptions","organizations_url":"https://api.github.com/users/imanuelcostigan/orgs","repos_url":"https://api.github.com/users/imanuelcostigan/repos","events_url":"https://api.github.com/users/imanuelcostigan/events{/privacy}","received_events_url":"https://api.github.com/users/imanuelcostigan/received_events","type":"User","site_admin":false},"created_at":"2016-10-03T07:21:49Z","updated_at":"2016-10-03T07:21:49Z","body":"Ping again: @hadley when is this likely to be merged? Relying on this in next release of dplyr to submit update to RSQLServer. Looks like this is needed to solve a few other people's issues. "}}
{"actor":{"display_login":"imanuelcostigan"}}