{"action":"created","comment":{"url":"https://api.github.com/repos/collectd/collectd/pulls/comments/72894591","id":72894591,"diff_hunk":"@@ -426,3 +426,13 @@ void module_register (void)\n #endif\n \tplugin_register_read (\"interface\", interface_read);\n } /* void module_register */\n+\n+/*\n+ * Local variables:\n+ *  c-file-style: \"linux\"\n+ *  indent-tabs-mode: t\n+ *  c-indent-level: 4\n+ *  c-basic-offset: 4\n+ *  tab-width: 4\n+ * End:\n+ */","path":"src/interface.c","position":133,"original_position":13,"commit_id":"97ee626c2b4c68e24f030dec21ee652f61923d85","original_commit_id":"fc8f6e1bfd3b121c72ac30d1aa855d90f724b00b","user":{"login":"rubenk","id":47338,"avatar_url":"https://avatars.githubusercontent.com/u/47338?v=3","gravatar_id":"","url":"https://api.github.com/users/rubenk","html_url":"https://github.com/rubenk","followers_url":"https://api.github.com/users/rubenk/followers","following_url":"https://api.github.com/users/rubenk/following{/other_user}","gists_url":"https://api.github.com/users/rubenk/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenk/subscriptions","organizations_url":"https://api.github.com/users/rubenk/orgs","repos_url":"https://api.github.com/users/rubenk/repos","events_url":"https://api.github.com/users/rubenk/events{/privacy}","received_events_url":"https://api.github.com/users/rubenk/received_events","type":"User","site_admin":false},"body":"I know there's prior art all over the place in the code base, and please know that this is nothing personal, but I think these mode lines are distracting at least and don't help at all. Most editors should be able to set per-project settings these days.","created_at":"2016-07-30T21:38:38Z","updated_at":"2016-07-30T21:38:38Z","html_url":"https://github.com/collectd/collectd/pull/1791#discussion_r72894591","pull_request_url":"https://api.github.com/repos/collectd/collectd/pulls/1791","_links":{"self":{"href":"https://api.github.com/repos/collectd/collectd/pulls/comments/72894591"},"html":{"href":"https://github.com/collectd/collectd/pull/1791#discussion_r72894591"},"pull_request":{"href":"https://api.github.com/repos/collectd/collectd/pulls/1791"}}},"pull_request":{"url":"https://api.github.com/repos/collectd/collectd/pulls/1791","id":77286591,"html_url":"https://github.com/collectd/collectd/pull/1791","diff_url":"https://github.com/collectd/collectd/pull/1791.diff","patch_url":"https://github.com/collectd/collectd/pull/1791.patch","issue_url":"https://api.github.com/repos/collectd/collectd/issues/1791","number":1791,"state":"open","locked":false,"title":"add ActiveInterfaceOnly option to interface plugin","user":{"login":"rinigus","id":15706605,"avatar_url":"https://avatars.githubusercontent.com/u/15706605?v=3","gravatar_id":"","url":"https://api.github.com/users/rinigus","html_url":"https://github.com/rinigus","followers_url":"https://api.github.com/users/rinigus/followers","following_url":"https://api.github.com/users/rinigus/following{/other_user}","gists_url":"https://api.github.com/users/rinigus/gists{/gist_id}","starred_url":"https://api.github.com/users/rinigus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rinigus/subscriptions","organizations_url":"https://api.github.com/users/rinigus/orgs","repos_url":"https://api.github.com/users/rinigus/repos","events_url":"https://api.github.com/users/rinigus/events{/privacy}","received_events_url":"https://api.github.com/users/rinigus/received_events","type":"User","site_admin":false},"body":"This PR adds ActiveInterfaceOnly to interface plugin. \r\n\r\nRationale: In Sailfish devices there are very many network interfaces (28 in Nexus 4) out of which only 3 are actually used: one for cellular data, one for WIFI, and lo. Unfortunately, active interfaces on different devices could be different leading to inability to enable only the active ones using Interface option for all devices in default configuration. So, users would have to find out which interface is active for them and enable these interfaces manually.\r\n\r\nBy adding ActiveInterfaceOnly option, only interfaces with packet count larger than 0 would be reported. The implementation has been tested on Linux (Sailfish), but I hope that it works on other platforms as well.","created_at":"2016-07-13T13:17:08Z","updated_at":"2016-07-30T21:38:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b532f7591094d028ceeca304ef74627c41a5a8a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/collectd/collectd/pulls/1791/commits","review_comments_url":"https://api.github.com/repos/collectd/collectd/pulls/1791/comments","review_comment_url":"https://api.github.com/repos/collectd/collectd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/collectd/collectd/issues/1791/comments","statuses_url":"https://api.github.com/repos/collectd/collectd/statuses/97ee626c2b4c68e24f030dec21ee652f61923d85","head":{"label":"rinigus:interface_active","ref":"interface_active","sha":"97ee626c2b4c68e24f030dec21ee652f61923d85","user":{"login":"rinigus","id":15706605,"avatar_url":"https://avatars.githubusercontent.com/u/15706605?v=3","gravatar_id":"","url":"https://api.github.com/users/rinigus","html_url":"https://github.com/rinigus","followers_url":"https://api.github.com/users/rinigus/followers","following_url":"https://api.github.com/users/rinigus/following{/other_user}","gists_url":"https://api.github.com/users/rinigus/gists{/gist_id}","starred_url":"https://api.github.com/users/rinigus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rinigus/subscriptions","organizations_url":"https://api.github.com/users/rinigus/orgs","repos_url":"https://api.github.com/users/rinigus/repos","events_url":"https://api.github.com/users/rinigus/events{/privacy}","received_events_url":"https://api.github.com/users/rinigus/received_events","type":"User","site_admin":false},"repo":{"id":59648463,"name":"collectd","full_name":"rinigus/collectd","owner":{"login":"rinigus","id":15706605,"avatar_url":"https://avatars.githubusercontent.com/u/15706605?v=3","gravatar_id":"","url":"https://api.github.com/users/rinigus","html_url":"https://github.com/rinigus","followers_url":"https://api.github.com/users/rinigus/followers","following_url":"https://api.github.com/users/rinigus/following{/other_user}","gists_url":"https://api.github.com/users/rinigus/gists{/gist_id}","starred_url":"https://api.github.com/users/rinigus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rinigus/subscriptions","organizations_url":"https://api.github.com/users/rinigus/orgs","repos_url":"https://api.github.com/users/rinigus/repos","events_url":"https://api.github.com/users/rinigus/events{/privacy}","received_events_url":"https://api.github.com/users/rinigus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rinigus/collectd","description":"The system statistics collection daemon. Sailfish development","fork":true,"url":"https://api.github.com/repos/rinigus/collectd","forks_url":"https://api.github.com/repos/rinigus/collectd/forks","keys_url":"https://api.github.com/repos/rinigus/collectd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rinigus/collectd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rinigus/collectd/teams","hooks_url":"https://api.github.com/repos/rinigus/collectd/hooks","issue_events_url":"https://api.github.com/repos/rinigus/collectd/issues/events{/number}","events_url":"https://api.github.com/repos/rinigus/collectd/events","assignees_url":"https://api.github.com/repos/rinigus/collectd/assignees{/user}","branches_url":"https://api.github.com/repos/rinigus/collectd/branches{/branch}","tags_url":"https://api.github.com/repos/rinigus/collectd/tags","blobs_url":"https://api.github.com/repos/rinigus/collectd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rinigus/collectd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rinigus/collectd/git/refs{/sha}","trees_url":"https://api.github.com/repos/rinigus/collectd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rinigus/collectd/statuses/{sha}","languages_url":"https://api.github.com/repos/rinigus/collectd/languages","stargazers_url":"https://api.github.com/repos/rinigus/collectd/stargazers","contributors_url":"https://api.github.com/repos/rinigus/collectd/contributors","subscribers_url":"https://api.github.com/repos/rinigus/collectd/subscribers","subscription_url":"https://api.github.com/repos/rinigus/collectd/subscription","commits_url":"https://api.github.com/repos/rinigus/collectd/commits{/sha}","git_commits_url":"https://api.github.com/repos/rinigus/collectd/git/commits{/sha}","comments_url":"https://api.github.com/repos/rinigus/collectd/comments{/number}","issue_comment_url":"https://api.github.com/repos/rinigus/collectd/issues/comments{/number}","contents_url":"https://api.github.com/repos/rinigus/collectd/contents/{+path}","compare_url":"https://api.github.com/repos/rinigus/collectd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rinigus/collectd/merges","archive_url":"https://api.github.com/repos/rinigus/collectd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rinigus/collectd/downloads","issues_url":"https://api.github.com/repos/rinigus/collectd/issues{/number}","pulls_url":"https://api.github.com/repos/rinigus/collectd/pulls{/number}","milestones_url":"https://api.github.com/repos/rinigus/collectd/milestones{/number}","notifications_url":"https://api.github.com/repos/rinigus/collectd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rinigus/collectd/labels{/name}","releases_url":"https://api.github.com/repos/rinigus/collectd/releases{/id}","deployments_url":"https://api.github.com/repos/rinigus/collectd/deployments","created_at":"2016-05-25T09:08:40Z","updated_at":"2016-07-15T18:14:08Z","pushed_at":"2016-07-30T21:12:07Z","git_url":"git://github.com/rinigus/collectd.git","ssh_url":"git@github.com:rinigus/collectd.git","clone_url":"https://github.com/rinigus/collectd.git","svn_url":"https://github.com/rinigus/collectd","homepage":"http://collectd.org/","size":13957,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"sailfish"}},"base":{"label":"collectd:master","ref":"master","sha":"37fe166fd6124adeaa91bc26b0a5e34cbdf25114","user":{"login":"collectd","id":1027481,"avatar_url":"https://avatars.githubusercontent.com/u/1027481?v=3","gravatar_id":"","url":"https://api.github.com/users/collectd","html_url":"https://github.com/collectd","followers_url":"https://api.github.com/users/collectd/followers","following_url":"https://api.github.com/users/collectd/following{/other_user}","gists_url":"https://api.github.com/users/collectd/gists{/gist_id}","starred_url":"https://api.github.com/users/collectd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collectd/subscriptions","organizations_url":"https://api.github.com/users/collectd/orgs","repos_url":"https://api.github.com/users/collectd/repos","events_url":"https://api.github.com/users/collectd/events{/privacy}","received_events_url":"https://api.github.com/users/collectd/received_events","type":"Organization","site_admin":false},"repo":{"id":3208640,"name":"collectd","full_name":"collectd/collectd","owner":{"login":"collectd","id":1027481,"avatar_url":"https://avatars.githubusercontent.com/u/1027481?v=3","gravatar_id":"","url":"https://api.github.com/users/collectd","html_url":"https://github.com/collectd","followers_url":"https://api.github.com/users/collectd/followers","following_url":"https://api.github.com/users/collectd/following{/other_user}","gists_url":"https://api.github.com/users/collectd/gists{/gist_id}","starred_url":"https://api.github.com/users/collectd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collectd/subscriptions","organizations_url":"https://api.github.com/users/collectd/orgs","repos_url":"https://api.github.com/users/collectd/repos","events_url":"https://api.github.com/users/collectd/events{/privacy}","received_events_url":"https://api.github.com/users/collectd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/collectd/collectd","description":"The system statistics collection daemon. Mirror of the canonical repository (updated automatically). Please send Pull Requests here!","fork":false,"url":"https://api.github.com/repos/collectd/collectd","forks_url":"https://api.github.com/repos/collectd/collectd/forks","keys_url":"https://api.github.com/repos/collectd/collectd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/collectd/collectd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/collectd/collectd/teams","hooks_url":"https://api.github.com/repos/collectd/collectd/hooks","issue_events_url":"https://api.github.com/repos/collectd/collectd/issues/events{/number}","events_url":"https://api.github.com/repos/collectd/collectd/events","assignees_url":"https://api.github.com/repos/collectd/collectd/assignees{/user}","branches_url":"https://api.github.com/repos/collectd/collectd/branches{/branch}","tags_url":"https://api.github.com/repos/collectd/collectd/tags","blobs_url":"https://api.github.com/repos/collectd/collectd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/collectd/collectd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/collectd/collectd/git/refs{/sha}","trees_url":"https://api.github.com/repos/collectd/collectd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/collectd/collectd/statuses/{sha}","languages_url":"https://api.github.com/repos/collectd/collectd/languages","stargazers_url":"https://api.github.com/repos/collectd/collectd/stargazers","contributors_url":"https://api.github.com/repos/collectd/collectd/contributors","subscribers_url":"https://api.github.com/repos/collectd/collectd/subscribers","subscription_url":"https://api.github.com/repos/collectd/collectd/subscription","commits_url":"https://api.github.com/repos/collectd/collectd/commits{/sha}","git_commits_url":"https://api.github.com/repos/collectd/collectd/git/commits{/sha}","comments_url":"https://api.github.com/repos/collectd/collectd/comments{/number}","issue_comment_url":"https://api.github.com/repos/collectd/collectd/issues/comments{/number}","contents_url":"https://api.github.com/repos/collectd/collectd/contents/{+path}","compare_url":"https://api.github.com/repos/collectd/collectd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/collectd/collectd/merges","archive_url":"https://api.github.com/repos/collectd/collectd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/collectd/collectd/downloads","issues_url":"https://api.github.com/repos/collectd/collectd/issues{/number}","pulls_url":"https://api.github.com/repos/collectd/collectd/pulls{/number}","milestones_url":"https://api.github.com/repos/collectd/collectd/milestones{/number}","notifications_url":"https://api.github.com/repos/collectd/collectd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/collectd/collectd/labels{/name}","releases_url":"https://api.github.com/repos/collectd/collectd/releases{/id}","deployments_url":"https://api.github.com/repos/collectd/collectd/deployments","created_at":"2012-01-18T13:07:51Z","updated_at":"2016-07-29T04:49:45Z","pushed_at":"2016-07-30T21:12:08Z","git_url":"git://github.com/collectd/collectd.git","ssh_url":"git@github.com:collectd/collectd.git","clone_url":"https://github.com/collectd/collectd.git","svn_url":"https://github.com/collectd/collectd","homepage":"http://collectd.org/","size":26373,"stargazers_count":1207,"watchers_count":1207,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":688,"mirror_url":null,"open_issues_count":374,"forks":688,"open_issues":374,"watchers":1207,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/collectd/collectd/pulls/1791"},"html":{"href":"https://github.com/collectd/collectd/pull/1791"},"issue":{"href":"https://api.github.com/repos/collectd/collectd/issues/1791"},"comments":{"href":"https://api.github.com/repos/collectd/collectd/issues/1791/comments"},"review_comments":{"href":"https://api.github.com/repos/collectd/collectd/pulls/1791/comments"},"review_comment":{"href":"https://api.github.com/repos/collectd/collectd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/collectd/collectd/pulls/1791/commits"},"statuses":{"href":"https://api.github.com/repos/collectd/collectd/statuses/97ee626c2b4c68e24f030dec21ee652f61923d85"}}}}
{"actor":{"display_login":"rubenk"}}