{"action":"closed","number":20,"pull_request":{"url":"https://api.github.com/repos/nbluis/static-server/pulls/20","id":75649312,"html_url":"https://github.com/nbluis/static-server/pull/20","diff_url":"https://github.com/nbluis/static-server/pull/20.diff","patch_url":"https://github.com/nbluis/static-server/pull/20.patch","issue_url":"https://api.github.com/repos/nbluis/static-server/issues/20","number":20,"state":"closed","locked":false,"title":"Allow cors header to be set","user":{"login":"hulvei3","id":608498,"avatar_url":"https://avatars.githubusercontent.com/u/608498?v=3","gravatar_id":"","url":"https://api.github.com/users/hulvei3","html_url":"https://github.com/hulvei3","followers_url":"https://api.github.com/users/hulvei3/followers","following_url":"https://api.github.com/users/hulvei3/following{/other_user}","gists_url":"https://api.github.com/users/hulvei3/gists{/gist_id}","starred_url":"https://api.github.com/users/hulvei3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hulvei3/subscriptions","organizations_url":"https://api.github.com/users/hulvei3/orgs","repos_url":"https://api.github.com/users/hulvei3/repos","events_url":"https://api.github.com/users/hulvei3/events{/privacy}","received_events_url":"https://api.github.com/users/hulvei3/received_events","type":"User","site_admin":false},"body":"Basically I needed to set basic cors stuff to the headers. For now a simple `cors` option would be fine.\r\n\r\n```\r\n{\r\n   rootPath: '.',\r\n   cors: '*'\r\n}\r\n```\r\n\r\nThis will only add `Access-Control-Allow-Origin` with the value of the `cors` option. Given the nature of this package and the fact that is properly is used mainly for development purposes I think this is fair.\r\n\r\nTell me what you think...","created_at":"2016-06-29T13:38:37Z","updated_at":"2016-07-06T18:37:58Z","closed_at":"2016-07-06T18:37:58Z","merged_at":"2016-07-06T18:37:58Z","merge_commit_sha":"716d748e15b6ef730133aa6af8faa56e3b65472d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nbluis/static-server/pulls/20/commits","review_comments_url":"https://api.github.com/repos/nbluis/static-server/pulls/20/comments","review_comment_url":"https://api.github.com/repos/nbluis/static-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nbluis/static-server/issues/20/comments","statuses_url":"https://api.github.com/repos/nbluis/static-server/statuses/d0f6c988715cda03a58b37fc58421f82f0680f4b","head":{"label":"hulvei3:allow-cors","ref":"allow-cors","sha":"d0f6c988715cda03a58b37fc58421f82f0680f4b","user":{"login":"hulvei3","id":608498,"avatar_url":"https://avatars.githubusercontent.com/u/608498?v=3","gravatar_id":"","url":"https://api.github.com/users/hulvei3","html_url":"https://github.com/hulvei3","followers_url":"https://api.github.com/users/hulvei3/followers","following_url":"https://api.github.com/users/hulvei3/following{/other_user}","gists_url":"https://api.github.com/users/hulvei3/gists{/gist_id}","starred_url":"https://api.github.com/users/hulvei3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hulvei3/subscriptions","organizations_url":"https://api.github.com/users/hulvei3/orgs","repos_url":"https://api.github.com/users/hulvei3/repos","events_url":"https://api.github.com/users/hulvei3/events{/privacy}","received_events_url":"https://api.github.com/users/hulvei3/received_events","type":"User","site_admin":false},"repo":{"id":62225406,"name":"static-server","full_name":"hulvei3/static-server","owner":{"login":"hulvei3","id":608498,"avatar_url":"https://avatars.githubusercontent.com/u/608498?v=3","gravatar_id":"","url":"https://api.github.com/users/hulvei3","html_url":"https://github.com/hulvei3","followers_url":"https://api.github.com/users/hulvei3/followers","following_url":"https://api.github.com/users/hulvei3/following{/other_user}","gists_url":"https://api.github.com/users/hulvei3/gists{/gist_id}","starred_url":"https://api.github.com/users/hulvei3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hulvei3/subscriptions","organizations_url":"https://api.github.com/users/hulvei3/orgs","repos_url":"https://api.github.com/users/hulvei3/repos","events_url":"https://api.github.com/users/hulvei3/events{/privacy}","received_events_url":"https://api.github.com/users/hulvei3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hulvei3/static-server","description":"A simple static server written in node.js","fork":true,"url":"https://api.github.com/repos/hulvei3/static-server","forks_url":"https://api.github.com/repos/hulvei3/static-server/forks","keys_url":"https://api.github.com/repos/hulvei3/static-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hulvei3/static-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hulvei3/static-server/teams","hooks_url":"https://api.github.com/repos/hulvei3/static-server/hooks","issue_events_url":"https://api.github.com/repos/hulvei3/static-server/issues/events{/number}","events_url":"https://api.github.com/repos/hulvei3/static-server/events","assignees_url":"https://api.github.com/repos/hulvei3/static-server/assignees{/user}","branches_url":"https://api.github.com/repos/hulvei3/static-server/branches{/branch}","tags_url":"https://api.github.com/repos/hulvei3/static-server/tags","blobs_url":"https://api.github.com/repos/hulvei3/static-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hulvei3/static-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hulvei3/static-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/hulvei3/static-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hulvei3/static-server/statuses/{sha}","languages_url":"https://api.github.com/repos/hulvei3/static-server/languages","stargazers_url":"https://api.github.com/repos/hulvei3/static-server/stargazers","contributors_url":"https://api.github.com/repos/hulvei3/static-server/contributors","subscribers_url":"https://api.github.com/repos/hulvei3/static-server/subscribers","subscription_url":"https://api.github.com/repos/hulvei3/static-server/subscription","commits_url":"https://api.github.com/repos/hulvei3/static-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/hulvei3/static-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/hulvei3/static-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/hulvei3/static-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/hulvei3/static-server/contents/{+path}","compare_url":"https://api.github.com/repos/hulvei3/static-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hulvei3/static-server/merges","archive_url":"https://api.github.com/repos/hulvei3/static-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hulvei3/static-server/downloads","issues_url":"https://api.github.com/repos/hulvei3/static-server/issues{/number}","pulls_url":"https://api.github.com/repos/hulvei3/static-server/pulls{/number}","milestones_url":"https://api.github.com/repos/hulvei3/static-server/milestones{/number}","notifications_url":"https://api.github.com/repos/hulvei3/static-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hulvei3/static-server/labels{/name}","releases_url":"https://api.github.com/repos/hulvei3/static-server/releases{/id}","deployments_url":"https://api.github.com/repos/hulvei3/static-server/deployments","created_at":"2016-06-29T12:49:42Z","updated_at":"2016-06-29T12:49:43Z","pushed_at":"2016-06-29T13:34:19Z","git_url":"git://github.com/hulvei3/static-server.git","ssh_url":"git@github.com:hulvei3/static-server.git","clone_url":"https://github.com/hulvei3/static-server.git","svn_url":"https://github.com/hulvei3/static-server","homepage":"","size":48,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nbluis:master","ref":"master","sha":"12ce665c3d66d09a331b9a0e91155e54696b53f1","user":{"login":"nbluis","id":24320,"avatar_url":"https://avatars.githubusercontent.com/u/24320?v=3","gravatar_id":"","url":"https://api.github.com/users/nbluis","html_url":"https://github.com/nbluis","followers_url":"https://api.github.com/users/nbluis/followers","following_url":"https://api.github.com/users/nbluis/following{/other_user}","gists_url":"https://api.github.com/users/nbluis/gists{/gist_id}","starred_url":"https://api.github.com/users/nbluis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbluis/subscriptions","organizations_url":"https://api.github.com/users/nbluis/orgs","repos_url":"https://api.github.com/users/nbluis/repos","events_url":"https://api.github.com/users/nbluis/events{/privacy}","received_events_url":"https://api.github.com/users/nbluis/received_events","type":"User","site_admin":false},"repo":{"id":12784439,"name":"static-server","full_name":"nbluis/static-server","owner":{"login":"nbluis","id":24320,"avatar_url":"https://avatars.githubusercontent.com/u/24320?v=3","gravatar_id":"","url":"https://api.github.com/users/nbluis","html_url":"https://github.com/nbluis","followers_url":"https://api.github.com/users/nbluis/followers","following_url":"https://api.github.com/users/nbluis/following{/other_user}","gists_url":"https://api.github.com/users/nbluis/gists{/gist_id}","starred_url":"https://api.github.com/users/nbluis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbluis/subscriptions","organizations_url":"https://api.github.com/users/nbluis/orgs","repos_url":"https://api.github.com/users/nbluis/repos","events_url":"https://api.github.com/users/nbluis/events{/privacy}","received_events_url":"https://api.github.com/users/nbluis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nbluis/static-server","description":"A simple static server written in node.js","fork":false,"url":"https://api.github.com/repos/nbluis/static-server","forks_url":"https://api.github.com/repos/nbluis/static-server/forks","keys_url":"https://api.github.com/repos/nbluis/static-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nbluis/static-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nbluis/static-server/teams","hooks_url":"https://api.github.com/repos/nbluis/static-server/hooks","issue_events_url":"https://api.github.com/repos/nbluis/static-server/issues/events{/number}","events_url":"https://api.github.com/repos/nbluis/static-server/events","assignees_url":"https://api.github.com/repos/nbluis/static-server/assignees{/user}","branches_url":"https://api.github.com/repos/nbluis/static-server/branches{/branch}","tags_url":"https://api.github.com/repos/nbluis/static-server/tags","blobs_url":"https://api.github.com/repos/nbluis/static-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nbluis/static-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nbluis/static-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/nbluis/static-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nbluis/static-server/statuses/{sha}","languages_url":"https://api.github.com/repos/nbluis/static-server/languages","stargazers_url":"https://api.github.com/repos/nbluis/static-server/stargazers","contributors_url":"https://api.github.com/repos/nbluis/static-server/contributors","subscribers_url":"https://api.github.com/repos/nbluis/static-server/subscribers","subscription_url":"https://api.github.com/repos/nbluis/static-server/subscription","commits_url":"https://api.github.com/repos/nbluis/static-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/nbluis/static-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/nbluis/static-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/nbluis/static-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/nbluis/static-server/contents/{+path}","compare_url":"https://api.github.com/repos/nbluis/static-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nbluis/static-server/merges","archive_url":"https://api.github.com/repos/nbluis/static-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nbluis/static-server/downloads","issues_url":"https://api.github.com/repos/nbluis/static-server/issues{/number}","pulls_url":"https://api.github.com/repos/nbluis/static-server/pulls{/number}","milestones_url":"https://api.github.com/repos/nbluis/static-server/milestones{/number}","notifications_url":"https://api.github.com/repos/nbluis/static-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nbluis/static-server/labels{/name}","releases_url":"https://api.github.com/repos/nbluis/static-server/releases{/id}","deployments_url":"https://api.github.com/repos/nbluis/static-server/deployments","created_at":"2013-09-12T13:32:45Z","updated_at":"2016-07-01T20:40:49Z","pushed_at":"2016-07-06T18:37:58Z","git_url":"git://github.com/nbluis/static-server.git","ssh_url":"git@github.com:nbluis/static-server.git","clone_url":"https://github.com/nbluis/static-server.git","svn_url":"https://github.com/nbluis/static-server","homepage":"","size":78,"stargazers_count":24,"watchers_count":24,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":5,"forks":11,"open_issues":5,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nbluis/static-server/pulls/20"},"html":{"href":"https://github.com/nbluis/static-server/pull/20"},"issue":{"href":"https://api.github.com/repos/nbluis/static-server/issues/20"},"comments":{"href":"https://api.github.com/repos/nbluis/static-server/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/nbluis/static-server/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/nbluis/static-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nbluis/static-server/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/nbluis/static-server/statuses/d0f6c988715cda03a58b37fc58421f82f0680f4b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"nbluis","id":24320,"avatar_url":"https://avatars.githubusercontent.com/u/24320?v=3","gravatar_id":"","url":"https://api.github.com/users/nbluis","html_url":"https://github.com/nbluis","followers_url":"https://api.github.com/users/nbluis/followers","following_url":"https://api.github.com/users/nbluis/following{/other_user}","gists_url":"https://api.github.com/users/nbluis/gists{/gist_id}","starred_url":"https://api.github.com/users/nbluis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbluis/subscriptions","organizations_url":"https://api.github.com/users/nbluis/orgs","repos_url":"https://api.github.com/users/nbluis/repos","events_url":"https://api.github.com/users/nbluis/events{/privacy}","received_events_url":"https://api.github.com/users/nbluis/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":4,"additions":26,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"nbluis"}}