{"action":"created","issue":{"url":"https://api.github.com/repos/zendframework/zend-stratigility/issues/46","repository_url":"https://api.github.com/repos/zendframework/zend-stratigility","labels_url":"https://api.github.com/repos/zendframework/zend-stratigility/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/zendframework/zend-stratigility/issues/46/comments","events_url":"https://api.github.com/repos/zendframework/zend-stratigility/issues/46/events","html_url":"https://github.com/zendframework/zend-stratigility/pull/46","id":130858651,"number":46,"title":"Finalhandler production stacktrace fix","user":{"login":"michaelmoussa","id":183833,"avatar_url":"https://avatars.githubusercontent.com/u/183833?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelmoussa","html_url":"https://github.com/michaelmoussa","followers_url":"https://api.github.com/users/michaelmoussa/followers","following_url":"https://api.github.com/users/michaelmoussa/following{/other_user}","gists_url":"https://api.github.com/users/michaelmoussa/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelmoussa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelmoussa/subscriptions","organizations_url":"https://api.github.com/users/michaelmoussa/orgs","repos_url":"https://api.github.com/users/michaelmoussa/repos","events_url":"https://api.github.com/users/michaelmoussa/events{/privacy}","received_events_url":"https://api.github.com/users/michaelmoussa/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/zendframework/zend-stratigility/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/zendframework/zend-stratigility/milestones/7","html_url":"https://github.com/zendframework/zend-stratigility/milestones/1.2.0","labels_url":"https://api.github.com/repos/zendframework/zend-stratigility/milestones/7/labels","id":1651166,"number":7,"title":"1.2.0","description":null,"creator":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":2,"state":"open","created_at":"2016-03-17T14:29:20Z","updated_at":"2016-03-17T14:51:34Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-02-02T23:51:45Z","updated_at":"2016-03-17T14:53:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zendframework/zend-stratigility/pulls/46","html_url":"https://github.com/zendframework/zend-stratigility/pull/46","diff_url":"https://github.com/zendframework/zend-stratigility/pull/46.diff","patch_url":"https://github.com/zendframework/zend-stratigility/pull/46.patch"},"body":"@weierophinney this addresses #45 and makes it possible to create the `FinalHandler` in a factory and worry about the original response later.\r\n\r\nOne thing I wasn't sure about was whether error details should be in the case of `'env' !== 'production'` vs. `'env' === 'development'`. Production is surely \"NO\" and development is surely \"YES\", but other environments like staging, qa, etc. may depend on the implementor. Perhaps a boolean `display_error_details` option would be better than `env`? If so, what would you do with the original `env`? Remove it completely? Or automatically set `display_error_details` to `true` if `env != production` and `false` otherwise for BC?"},"comment":{"url":"https://api.github.com/repos/zendframework/zend-stratigility/issues/comments/197915847","html_url":"https://github.com/zendframework/zend-stratigility/pull/46#issuecomment-197915847","issue_url":"https://api.github.com/repos/zendframework/zend-stratigility/issues/46","id":197915847,"user":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"created_at":"2016-03-17T14:53:40Z","updated_at":"2016-03-17T14:53:40Z","body":"> I can make that change on merge.\r\n\r\nNever mind; that's how it already reads. :smile:"}}