{"action":"created","comment":{"url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/pulls/comments/83501311","pull_request_review_id":4344622,"id":83501311,"diff_hunk":"@@ -36,38 +36,41 @@ function initSocket() {\n \n global.socket = initSocket();\n \n-const component = (\n-  <Router render={(props) =>\n-        <ReduxAsyncConnect {...props} helpers={{client}} filter={item => !item.deferred} />\n-      } history={history}>\n-    {getRoutes(store)}\n-  </Router>\n-);\n-\n-ReactDOM.render(\n-  <Provider store={store} key=\"provider\">\n-    {component}\n-  </Provider>,\n-  dest\n-);\n-\n-if (process.env.NODE_ENV !== 'production') {\n-  window.React = React; // enable debugger\n-\n-  if (!dest || !dest.firstChild || !dest.firstChild.attributes || !dest.firstChild.attributes['data-react-checksum']) {\n-    console.error('Server-side React render was discarded. Make sure that your initial render does not contain any client-side code.');\n-  }\n-}\n+const routes = getRoutes(store);\n+match({ history, routes: routes }, () => {","path":"src/client.js","position":38,"original_position":38,"commit_id":"cefe602215da5ab1e897ffbe7170b9c26ae6b6b7","original_commit_id":"cefe602215da5ab1e897ffbe7170b9c26ae6b6b7","user":{"login":"bertho-zero","id":8525267,"avatar_url":"https://avatars.githubusercontent.com/u/8525267?v=3","gravatar_id":"","url":"https://api.github.com/users/bertho-zero","html_url":"https://github.com/bertho-zero","followers_url":"https://api.github.com/users/bertho-zero/followers","following_url":"https://api.github.com/users/bertho-zero/following{/other_user}","gists_url":"https://api.github.com/users/bertho-zero/gists{/gist_id}","starred_url":"https://api.github.com/users/bertho-zero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bertho-zero/subscriptions","organizations_url":"https://api.github.com/users/bertho-zero/orgs","repos_url":"https://api.github.com/users/bertho-zero/repos","events_url":"https://api.github.com/users/bertho-zero/events{/privacy}","received_events_url":"https://api.github.com/users/bertho-zero/received_events","type":"User","site_admin":false},"body":"match({ history, routes }, () => {","created_at":"2016-10-14T21:05:25Z","updated_at":"2016-10-14T21:05:26Z","html_url":"https://github.com/erikras/react-redux-universal-hot-example/pull/1298#discussion_r83501311","pull_request_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/pulls/1298","_links":{"self":{"href":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/pulls/comments/83501311"},"html":{"href":"https://github.com/erikras/react-redux-universal-hot-example/pull/1298#discussion_r83501311"},"pull_request":{"href":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/pulls/1298"}}},"pull_request":{"url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/pulls/1298","id":89355523,"html_url":"https://github.com/erikras/react-redux-universal-hot-example/pull/1298","diff_url":"https://github.com/erikras/react-redux-universal-hot-example/pull/1298.diff","patch_url":"https://github.com/erikras/react-redux-universal-hot-example/pull/1298.patch","issue_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/issues/1298","number":1298,"state":"open","locked":false,"title":"feat(routing): Code splitting, named routes, no SSR mismatch issues","user":{"login":"grgur","id":733074,"avatar_url":"https://avatars.githubusercontent.com/u/733074?v=3","gravatar_id":"","url":"https://api.github.com/users/grgur","html_url":"https://github.com/grgur","followers_url":"https://api.github.com/users/grgur/followers","following_url":"https://api.github.com/users/grgur/following{/other_user}","gists_url":"https://api.github.com/users/grgur/gists{/gist_id}","starred_url":"https://api.github.com/users/grgur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grgur/subscriptions","organizations_url":"https://api.github.com/users/grgur/orgs","repos_url":"https://api.github.com/users/grgur/repos","events_url":"https://api.github.com/users/grgur/events{/privacy}","received_events_url":"https://api.github.com/users/grgur/received_events","type":"User","site_admin":false},"body":"I reused @leifdalan's PR https://github.com/erikras/react-redux-universal-hot-example/pull/1216 to enable **code splitting** with additional features:\r\n- named chunks (use custom names instead of numbers for chunks)\r\n- proper matching in client's to avoid server-client rendering differences","created_at":"2016-10-14T09:53:15Z","updated_at":"2016-10-14T21:05:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a426f8777ba9791b7a6f4cdf9835bd5acb98121e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/pulls/1298/commits","review_comments_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/pulls/1298/comments","review_comment_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/pulls/comments{/number}","comments_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/issues/1298/comments","statuses_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/statuses/cefe602215da5ab1e897ffbe7170b9c26ae6b6b7","head":{"label":"grgur:pr/code-splitting","ref":"pr/code-splitting","sha":"cefe602215da5ab1e897ffbe7170b9c26ae6b6b7","user":{"login":"grgur","id":733074,"avatar_url":"https://avatars.githubusercontent.com/u/733074?v=3","gravatar_id":"","url":"https://api.github.com/users/grgur","html_url":"https://github.com/grgur","followers_url":"https://api.github.com/users/grgur/followers","following_url":"https://api.github.com/users/grgur/following{/other_user}","gists_url":"https://api.github.com/users/grgur/gists{/gist_id}","starred_url":"https://api.github.com/users/grgur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grgur/subscriptions","organizations_url":"https://api.github.com/users/grgur/orgs","repos_url":"https://api.github.com/users/grgur/repos","events_url":"https://api.github.com/users/grgur/events{/privacy}","received_events_url":"https://api.github.com/users/grgur/received_events","type":"User","site_admin":false},"repo":{"id":61400671,"name":"react-redux-universal-hot-example","full_name":"grgur/react-redux-universal-hot-example","owner":{"login":"grgur","id":733074,"avatar_url":"https://avatars.githubusercontent.com/u/733074?v=3","gravatar_id":"","url":"https://api.github.com/users/grgur","html_url":"https://github.com/grgur","followers_url":"https://api.github.com/users/grgur/followers","following_url":"https://api.github.com/users/grgur/following{/other_user}","gists_url":"https://api.github.com/users/grgur/gists{/gist_id}","starred_url":"https://api.github.com/users/grgur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grgur/subscriptions","organizations_url":"https://api.github.com/users/grgur/orgs","repos_url":"https://api.github.com/users/grgur/repos","events_url":"https://api.github.com/users/grgur/events{/privacy}","received_events_url":"https://api.github.com/users/grgur/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grgur/react-redux-universal-hot-example","description":"A starter boilerplate for a universal webapp using express, react, redux, webpack, and react-transform","fork":true,"url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example","forks_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/forks","keys_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/teams","hooks_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/hooks","issue_events_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/issues/events{/number}","events_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/events","assignees_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/assignees{/user}","branches_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/branches{/branch}","tags_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/tags","blobs_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/git/refs{/sha}","trees_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/statuses/{sha}","languages_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/languages","stargazers_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/stargazers","contributors_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/contributors","subscribers_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/subscribers","subscription_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/subscription","commits_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/commits{/sha}","git_commits_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/git/commits{/sha}","comments_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/comments{/number}","issue_comment_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/issues/comments{/number}","contents_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/contents/{+path}","compare_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/merges","archive_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/downloads","issues_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/issues{/number}","pulls_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/pulls{/number}","milestones_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/milestones{/number}","notifications_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/labels{/name}","releases_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/releases{/id}","deployments_url":"https://api.github.com/repos/grgur/react-redux-universal-hot-example/deployments","created_at":"2016-06-17T20:32:28Z","updated_at":"2016-06-17T20:32:29Z","pushed_at":"2016-10-14T10:15:41Z","git_url":"git://github.com/grgur/react-redux-universal-hot-example.git","ssh_url":"git@github.com:grgur/react-redux-universal-hot-example.git","clone_url":"https://github.com/grgur/react-redux-universal-hot-example.git","svn_url":"https://github.com/grgur/react-redux-universal-hot-example","homepage":"","size":7029,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"erikras:master","ref":"master","sha":"37202692fd2e8ba99bc1ad2f38378bebf361862c","user":{"login":"erikras","id":4396759,"avatar_url":"https://avatars.githubusercontent.com/u/4396759?v=3","gravatar_id":"","url":"https://api.github.com/users/erikras","html_url":"https://github.com/erikras","followers_url":"https://api.github.com/users/erikras/followers","following_url":"https://api.github.com/users/erikras/following{/other_user}","gists_url":"https://api.github.com/users/erikras/gists{/gist_id}","starred_url":"https://api.github.com/users/erikras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikras/subscriptions","organizations_url":"https://api.github.com/users/erikras/orgs","repos_url":"https://api.github.com/users/erikras/repos","events_url":"https://api.github.com/users/erikras/events{/privacy}","received_events_url":"https://api.github.com/users/erikras/received_events","type":"User","site_admin":false},"repo":{"id":37931301,"name":"react-redux-universal-hot-example","full_name":"erikras/react-redux-universal-hot-example","owner":{"login":"erikras","id":4396759,"avatar_url":"https://avatars.githubusercontent.com/u/4396759?v=3","gravatar_id":"","url":"https://api.github.com/users/erikras","html_url":"https://github.com/erikras","followers_url":"https://api.github.com/users/erikras/followers","following_url":"https://api.github.com/users/erikras/following{/other_user}","gists_url":"https://api.github.com/users/erikras/gists{/gist_id}","starred_url":"https://api.github.com/users/erikras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikras/subscriptions","organizations_url":"https://api.github.com/users/erikras/orgs","repos_url":"https://api.github.com/users/erikras/repos","events_url":"https://api.github.com/users/erikras/events{/privacy}","received_events_url":"https://api.github.com/users/erikras/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erikras/react-redux-universal-hot-example","description":"A starter boilerplate for a universal webapp using express, react, redux, webpack, and react-transform","fork":false,"url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example","forks_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/forks","keys_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/teams","hooks_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/hooks","issue_events_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/issues/events{/number}","events_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/events","assignees_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/assignees{/user}","branches_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/branches{/branch}","tags_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/tags","blobs_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/git/refs{/sha}","trees_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/statuses/{sha}","languages_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/languages","stargazers_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/stargazers","contributors_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/contributors","subscribers_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/subscribers","subscription_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/subscription","commits_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/commits{/sha}","git_commits_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/git/commits{/sha}","comments_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/comments{/number}","issue_comment_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/issues/comments{/number}","contents_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/contents/{+path}","compare_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/merges","archive_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/downloads","issues_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/issues{/number}","pulls_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/pulls{/number}","milestones_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/milestones{/number}","notifications_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/labels{/name}","releases_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/releases{/id}","deployments_url":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/deployments","created_at":"2015-06-23T16:39:21Z","updated_at":"2016-10-14T20:30:46Z","pushed_at":"2016-10-14T09:53:15Z","git_url":"git://github.com/erikras/react-redux-universal-hot-example.git","ssh_url":"git@github.com:erikras/react-redux-universal-hot-example.git","clone_url":"https://github.com/erikras/react-redux-universal-hot-example.git","svn_url":"https://github.com/erikras/react-redux-universal-hot-example","homepage":"","size":8685,"stargazers_count":7645,"watchers_count":7645,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1838,"mirror_url":null,"open_issues_count":380,"forks":1838,"open_issues":380,"watchers":7645,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/pulls/1298"},"html":{"href":"https://github.com/erikras/react-redux-universal-hot-example/pull/1298"},"issue":{"href":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/issues/1298"},"comments":{"href":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/issues/1298/comments"},"review_comments":{"href":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/pulls/1298/comments"},"review_comment":{"href":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/pulls/1298/commits"},"statuses":{"href":"https://api.github.com/repos/erikras/react-redux-universal-hot-example/statuses/cefe602215da5ab1e897ffbe7170b9c26ae6b6b7"}}}}
{"actor":{"display_login":"bertho-zero"}}