{"action":"created","comment":{"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/comments/74082894","id":74082894,"diff_hunk":"@@ -40,7 +40,3 @@ const routes: RouterConfig = [\n   {path: 'components/tooltip', component: NgbdTooltip},\n   {path: 'components/typeahead', component: NgbdTypeahead}\n ];","path":"demo/src/app/app.routes.ts","position":18,"original_position":18,"commit_id":"1d78da9df1764521550b1369b63f953f57483aed","original_commit_id":"1d78da9df1764521550b1369b63f953f57483aed","user":{"login":"Foxandxss","id":1087957,"avatar_url":"https://avatars.githubusercontent.com/u/1087957?v=3","gravatar_id":"","url":"https://api.github.com/users/Foxandxss","html_url":"https://github.com/Foxandxss","followers_url":"https://api.github.com/users/Foxandxss/followers","following_url":"https://api.github.com/users/Foxandxss/following{/other_user}","gists_url":"https://api.github.com/users/Foxandxss/gists{/gist_id}","starred_url":"https://api.github.com/users/Foxandxss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Foxandxss/subscriptions","organizations_url":"https://api.github.com/users/Foxandxss/orgs","repos_url":"https://api.github.com/users/Foxandxss/repos","events_url":"https://api.github.com/users/Foxandxss/events{/privacy}","received_events_url":"https://api.github.com/users/Foxandxss/received_events","type":"User","site_admin":false},"body":"Would you mind changing the file name to `app.routing.ts` and using the pattern used in [here](https://github.com/IdeaBlade/angular.io/blob/5eef567b46948dd674affda1ac1dab6172caa434/public/docs/_examples/ngmodule/ts/app/app.routing.ts)\r\n\r\nAlso notice that RouterConfig is deprecated.\r\n\r\nThanks.","created_at":"2016-08-09T15:34:51Z","updated_at":"2016-08-09T15:34:51Z","html_url":"https://github.com/ng-bootstrap/ng-bootstrap/pull/556#discussion_r74082894","pull_request_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/556","_links":{"self":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/comments/74082894"},"html":{"href":"https://github.com/ng-bootstrap/ng-bootstrap/pull/556#discussion_r74082894"},"pull_request":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/556"}}},"pull_request":{"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/556","id":80437680,"html_url":"https://github.com/ng-bootstrap/ng-bootstrap/pull/556","diff_url":"https://github.com/ng-bootstrap/ng-bootstrap/pull/556.diff","patch_url":"https://github.com/ng-bootstrap/ng-bootstrap/pull/556.patch","issue_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/556","number":556,"state":"open","locked":false,"title":"WIP: chore: update to angular rc.5 and @NgModule","user":{"login":"pkozlowski-opensource","id":973550,"avatar_url":"https://avatars.githubusercontent.com/u/973550?v=3","gravatar_id":"","url":"https://api.github.com/users/pkozlowski-opensource","html_url":"https://github.com/pkozlowski-opensource","followers_url":"https://api.github.com/users/pkozlowski-opensource/followers","following_url":"https://api.github.com/users/pkozlowski-opensource/following{/other_user}","gists_url":"https://api.github.com/users/pkozlowski-opensource/gists{/gist_id}","starred_url":"https://api.github.com/users/pkozlowski-opensource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkozlowski-opensource/subscriptions","organizations_url":"https://api.github.com/users/pkozlowski-opensource/orgs","repos_url":"https://api.github.com/users/pkozlowski-opensource/repos","events_url":"https://api.github.com/users/pkozlowski-opensource/events{/privacy}","received_events_url":"https://api.github.com/users/pkozlowski-opensource/received_events","type":"User","site_admin":false},"body":"WIP: do NOT merge! This is a PR with a work in progress to migrate to RC5 / `@NgModule`. The diff is kind of big but those are mostly mechanical changes.\r\n\r\nWe will have to do more module-related cleanup in demo and changes in tests post-RC5 but let's take care of those once dust settles. \r\n\r\nCloses #535","created_at":"2016-08-08T11:48:19Z","updated_at":"2016-08-09T15:34:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e77fcf17555fdffbe368f7e80b8fc8b758cc41a8","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/milestones/6","html_url":"https://github.com/ng-bootstrap/ng-bootstrap/milestones/alpha.2","labels_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/milestones/6/labels","id":1910026,"number":6,"title":"alpha.2","description":"","creator":{"login":"pkozlowski-opensource","id":973550,"avatar_url":"https://avatars.githubusercontent.com/u/973550?v=3","gravatar_id":"","url":"https://api.github.com/users/pkozlowski-opensource","html_url":"https://github.com/pkozlowski-opensource","followers_url":"https://api.github.com/users/pkozlowski-opensource/followers","following_url":"https://api.github.com/users/pkozlowski-opensource/following{/other_user}","gists_url":"https://api.github.com/users/pkozlowski-opensource/gists{/gist_id}","starred_url":"https://api.github.com/users/pkozlowski-opensource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkozlowski-opensource/subscriptions","organizations_url":"https://api.github.com/users/pkozlowski-opensource/orgs","repos_url":"https://api.github.com/users/pkozlowski-opensource/repos","events_url":"https://api.github.com/users/pkozlowski-opensource/events{/privacy}","received_events_url":"https://api.github.com/users/pkozlowski-opensource/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":12,"state":"open","created_at":"2016-07-28T17:11:28Z","updated_at":"2016-08-09T08:10:56Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/556/commits","review_comments_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/556/comments","review_comment_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/556/comments","statuses_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/statuses/1d78da9df1764521550b1369b63f953f57483aed","head":{"label":"pkozlowski-opensource:rc5","ref":"rc5","sha":"1d78da9df1764521550b1369b63f953f57483aed","user":{"login":"pkozlowski-opensource","id":973550,"avatar_url":"https://avatars.githubusercontent.com/u/973550?v=3","gravatar_id":"","url":"https://api.github.com/users/pkozlowski-opensource","html_url":"https://github.com/pkozlowski-opensource","followers_url":"https://api.github.com/users/pkozlowski-opensource/followers","following_url":"https://api.github.com/users/pkozlowski-opensource/following{/other_user}","gists_url":"https://api.github.com/users/pkozlowski-opensource/gists{/gist_id}","starred_url":"https://api.github.com/users/pkozlowski-opensource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkozlowski-opensource/subscriptions","organizations_url":"https://api.github.com/users/pkozlowski-opensource/orgs","repos_url":"https://api.github.com/users/pkozlowski-opensource/repos","events_url":"https://api.github.com/users/pkozlowski-opensource/events{/privacy}","received_events_url":"https://api.github.com/users/pkozlowski-opensource/received_events","type":"User","site_admin":false},"repo":{"id":45191264,"name":"core","full_name":"pkozlowski-opensource/core","owner":{"login":"pkozlowski-opensource","id":973550,"avatar_url":"https://avatars.githubusercontent.com/u/973550?v=3","gravatar_id":"","url":"https://api.github.com/users/pkozlowski-opensource","html_url":"https://github.com/pkozlowski-opensource","followers_url":"https://api.github.com/users/pkozlowski-opensource/followers","following_url":"https://api.github.com/users/pkozlowski-opensource/following{/other_user}","gists_url":"https://api.github.com/users/pkozlowski-opensource/gists{/gist_id}","starred_url":"https://api.github.com/users/pkozlowski-opensource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkozlowski-opensource/subscriptions","organizations_url":"https://api.github.com/users/pkozlowski-opensource/orgs","repos_url":"https://api.github.com/users/pkozlowski-opensource/repos","events_url":"https://api.github.com/users/pkozlowski-opensource/events{/privacy}","received_events_url":"https://api.github.com/users/pkozlowski-opensource/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pkozlowski-opensource/core","description":"Angular 2 powered Bootstrap","fork":true,"url":"https://api.github.com/repos/pkozlowski-opensource/core","forks_url":"https://api.github.com/repos/pkozlowski-opensource/core/forks","keys_url":"https://api.github.com/repos/pkozlowski-opensource/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pkozlowski-opensource/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pkozlowski-opensource/core/teams","hooks_url":"https://api.github.com/repos/pkozlowski-opensource/core/hooks","issue_events_url":"https://api.github.com/repos/pkozlowski-opensource/core/issues/events{/number}","events_url":"https://api.github.com/repos/pkozlowski-opensource/core/events","assignees_url":"https://api.github.com/repos/pkozlowski-opensource/core/assignees{/user}","branches_url":"https://api.github.com/repos/pkozlowski-opensource/core/branches{/branch}","tags_url":"https://api.github.com/repos/pkozlowski-opensource/core/tags","blobs_url":"https://api.github.com/repos/pkozlowski-opensource/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pkozlowski-opensource/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pkozlowski-opensource/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/pkozlowski-opensource/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pkozlowski-opensource/core/statuses/{sha}","languages_url":"https://api.github.com/repos/pkozlowski-opensource/core/languages","stargazers_url":"https://api.github.com/repos/pkozlowski-opensource/core/stargazers","contributors_url":"https://api.github.com/repos/pkozlowski-opensource/core/contributors","subscribers_url":"https://api.github.com/repos/pkozlowski-opensource/core/subscribers","subscription_url":"https://api.github.com/repos/pkozlowski-opensource/core/subscription","commits_url":"https://api.github.com/repos/pkozlowski-opensource/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/pkozlowski-opensource/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/pkozlowski-opensource/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/pkozlowski-opensource/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/pkozlowski-opensource/core/contents/{+path}","compare_url":"https://api.github.com/repos/pkozlowski-opensource/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pkozlowski-opensource/core/merges","archive_url":"https://api.github.com/repos/pkozlowski-opensource/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pkozlowski-opensource/core/downloads","issues_url":"https://api.github.com/repos/pkozlowski-opensource/core/issues{/number}","pulls_url":"https://api.github.com/repos/pkozlowski-opensource/core/pulls{/number}","milestones_url":"https://api.github.com/repos/pkozlowski-opensource/core/milestones{/number}","notifications_url":"https://api.github.com/repos/pkozlowski-opensource/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pkozlowski-opensource/core/labels{/name}","releases_url":"https://api.github.com/repos/pkozlowski-opensource/core/releases{/id}","deployments_url":"https://api.github.com/repos/pkozlowski-opensource/core/deployments","created_at":"2015-10-29T15:13:07Z","updated_at":"2016-04-26T11:58:20Z","pushed_at":"2016-08-09T08:22:33Z","git_url":"git://github.com/pkozlowski-opensource/core.git","ssh_url":"git@github.com:pkozlowski-opensource/core.git","clone_url":"https://github.com/pkozlowski-opensource/core.git","svn_url":"https://github.com/pkozlowski-opensource/core","homepage":null,"size":729,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ng-bootstrap:master","ref":"master","sha":"8b14a31db93b6992bbea4d6b2f8ef70193610dd1","user":{"login":"ng-bootstrap","id":14283866,"avatar_url":"https://avatars.githubusercontent.com/u/14283866?v=3","gravatar_id":"","url":"https://api.github.com/users/ng-bootstrap","html_url":"https://github.com/ng-bootstrap","followers_url":"https://api.github.com/users/ng-bootstrap/followers","following_url":"https://api.github.com/users/ng-bootstrap/following{/other_user}","gists_url":"https://api.github.com/users/ng-bootstrap/gists{/gist_id}","starred_url":"https://api.github.com/users/ng-bootstrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ng-bootstrap/subscriptions","organizations_url":"https://api.github.com/users/ng-bootstrap/orgs","repos_url":"https://api.github.com/users/ng-bootstrap/repos","events_url":"https://api.github.com/users/ng-bootstrap/events{/privacy}","received_events_url":"https://api.github.com/users/ng-bootstrap/received_events","type":"Organization","site_admin":false},"repo":{"id":42481664,"name":"ng-bootstrap","full_name":"ng-bootstrap/ng-bootstrap","owner":{"login":"ng-bootstrap","id":14283866,"avatar_url":"https://avatars.githubusercontent.com/u/14283866?v=3","gravatar_id":"","url":"https://api.github.com/users/ng-bootstrap","html_url":"https://github.com/ng-bootstrap","followers_url":"https://api.github.com/users/ng-bootstrap/followers","following_url":"https://api.github.com/users/ng-bootstrap/following{/other_user}","gists_url":"https://api.github.com/users/ng-bootstrap/gists{/gist_id}","starred_url":"https://api.github.com/users/ng-bootstrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ng-bootstrap/subscriptions","organizations_url":"https://api.github.com/users/ng-bootstrap/orgs","repos_url":"https://api.github.com/users/ng-bootstrap/repos","events_url":"https://api.github.com/users/ng-bootstrap/events{/privacy}","received_events_url":"https://api.github.com/users/ng-bootstrap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ng-bootstrap/ng-bootstrap","description":"Angular 2 powered Bootstrap","fork":false,"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap","forks_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/forks","keys_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/teams","hooks_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/hooks","issue_events_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/events","assignees_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/tags","blobs_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/languages","stargazers_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/stargazers","contributors_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/contributors","subscribers_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/subscribers","subscription_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/subscription","commits_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/merges","archive_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/downloads","issues_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/releases{/id}","deployments_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/deployments","created_at":"2015-09-14T22:55:53Z","updated_at":"2016-08-09T14:10:40Z","pushed_at":"2016-08-08T17:59:17Z","git_url":"git://github.com/ng-bootstrap/ng-bootstrap.git","ssh_url":"git@github.com:ng-bootstrap/ng-bootstrap.git","clone_url":"https://github.com/ng-bootstrap/ng-bootstrap.git","svn_url":"https://github.com/ng-bootstrap/ng-bootstrap","homepage":"https://ng-bootstrap.github.io","size":921,"stargazers_count":674,"watchers_count":674,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":97,"mirror_url":null,"open_issues_count":36,"forks":97,"open_issues":36,"watchers":674,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/556"},"html":{"href":"https://github.com/ng-bootstrap/ng-bootstrap/pull/556"},"issue":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/556"},"comments":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/556/comments"},"review_comments":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/556/comments"},"review_comment":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/556/commits"},"statuses":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/statuses/1d78da9df1764521550b1369b63f953f57483aed"}}}}
{"actor":{"display_login":"Foxandxss"}}