{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/8703","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/8703/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/8703/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/8703/events","html_url":"https://github.com/nodejs/node/pull/8703","id":178479202,"number":8703,"title":"test: fix test-cluster-worker-init.js flakyness","user":{"login":"imyller","id":1898870,"avatar_url":"https://avatars.githubusercontent.com/u/1898870?v=3","gravatar_id":"","url":"https://api.github.com/users/imyller","html_url":"https://github.com/imyller","followers_url":"https://api.github.com/users/imyller/followers","following_url":"https://api.github.com/users/imyller/following{/other_user}","gists_url":"https://api.github.com/users/imyller/gists{/gist_id}","starred_url":"https://api.github.com/users/imyller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imyller/subscriptions","organizations_url":"https://api.github.com/users/imyller/orgs","repos_url":"https://api.github.com/users/imyller/repos","events_url":"https://api.github.com/users/imyller/events{/privacy}","received_events_url":"https://api.github.com/users/imyller/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/cluster","name":"cluster","color":"f7c6c7"},{"url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-09-21T22:34:52Z","updated_at":"2016-09-22T05:12:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/8703","html_url":"https://github.com/nodejs/node/pull/8703","diff_url":"https://github.com/nodejs/node/pull/8703.diff","patch_url":"https://github.com/nodejs/node/pull/8703.patch"},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\n\r\ntest, cluster\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\n\r\nUpdate test to match current test guidelines and use common.mustCall\r\ninstead of unref'd timer.\r\n\r\nFixes: https://github.com/nodejs/node/issues/8700"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/248814484","html_url":"https://github.com/nodejs/node/pull/8703#issuecomment-248814484","issue_url":"https://api.github.com/repos/nodejs/node/issues/8703","id":248814484,"user":{"login":"Trott","id":718899,"avatar_url":"https://avatars.githubusercontent.com/u/718899?v=3","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"created_at":"2016-09-22T05:12:50Z","updated_at":"2016-09-22T05:12:50Z","body":"Stress test against master: https://ci.nodejs.org/job/node-stress-single-test-pi1-binary/15/label=pi1-raspbian-wheezy/console\r\n\r\nFailed 10 out of 100 runs with current master. So 328 successful runs with 0 failures using the code change in this PR seems pretty convincing."}}
{"actor":{"display_login":"Trott"}}