{"action":"created","comment":{"url":"https://api.github.com/repos/communityshare/communityshare/pulls/comments/83577910","pull_request_review_id":4412287,"id":83577910,"diff_hunk":"@@ -63,6 +63,10 @@ module.factory(\n \t\t};\n \n \t\tAuthenticator.authenticateFromCookie = function() {\n+\t\t\tif( !$cookies.id || !$cookies.apiKey) {","path":"static/js/services/authentication_services.js","position":4,"original_position":4,"commit_id":"1f55b47a58f6722b3bdac307ab8bb24146990e2c","original_commit_id":"1f55b47a58f6722b3bdac307ab8bb24146990e2c","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"There must be a space inside this paren  space-in-parens","created_at":"2016-10-17T04:59:42Z","updated_at":"2016-10-17T04:59:42Z","html_url":"https://github.com/communityshare/communityshare/pull/221#discussion_r83577910","pull_request_url":"https://api.github.com/repos/communityshare/communityshare/pulls/221","_links":{"self":{"href":"https://api.github.com/repos/communityshare/communityshare/pulls/comments/83577910"},"html":{"href":"https://github.com/communityshare/communityshare/pull/221#discussion_r83577910"},"pull_request":{"href":"https://api.github.com/repos/communityshare/communityshare/pulls/221"}}},"pull_request":{"url":"https://api.github.com/repos/communityshare/communityshare/pulls/221","id":89560910,"html_url":"https://github.com/communityshare/communityshare/pull/221","diff_url":"https://github.com/communityshare/communityshare/pull/221.diff","patch_url":"https://github.com/communityshare/communityshare/pull/221.patch","issue_url":"https://api.github.com/repos/communityshare/communityshare/issues/221","number":221,"state":"open","locked":false,"title":"Stop hitting /api/users when !$cookies.id","user":{"login":"seanastephens","id":5893305,"avatar_url":"https://avatars.githubusercontent.com/u/5893305?v=3","gravatar_id":"","url":"https://api.github.com/users/seanastephens","html_url":"https://github.com/seanastephens","followers_url":"https://api.github.com/users/seanastephens/followers","following_url":"https://api.github.com/users/seanastephens/following{/other_user}","gists_url":"https://api.github.com/users/seanastephens/gists{/gist_id}","starred_url":"https://api.github.com/users/seanastephens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanastephens/subscriptions","organizations_url":"https://api.github.com/users/seanastephens/orgs","repos_url":"https://api.github.com/users/seanastephens/repos","events_url":"https://api.github.com/users/seanastephens/events{/privacy}","received_events_url":"https://api.github.com/users/seanastephens/received_events","type":"User","site_admin":false},"body":"Hot fix!\r\n\r\nThis is the only place we load `$cookies.id`:\r\n\r\n```bash\r\nfind -type f | grep -v bundle | xargs grep '$cookies.id'\r\n./js/services/authentication_services.js:\t\t\tif( !$cookies.id || !$cookies.apiKey) {\r\n./js/services/authentication_services.js:\t\t\tUser.get( $cookies.id )\r\n./js/services/authentication_services.js:\t\t\t\t\t$cookies.id = userObj.id;\r\n./js/services/authentication_services.js:\t\t\t\t\t$cookies.id = user.id;\r\n```\r\n\r\nBy checking that it is defined, we avoid invoking the no-arg overload of `Item.makeUrl()`, which fetches the entire user list.","created_at":"2016-10-17T04:59:35Z","updated_at":"2016-10-17T04:59:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd83b18fa39646299ef84aa0f7b8c2405c9cf166","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/communityshare/communityshare/pulls/221/commits","review_comments_url":"https://api.github.com/repos/communityshare/communityshare/pulls/221/comments","review_comment_url":"https://api.github.com/repos/communityshare/communityshare/pulls/comments{/number}","comments_url":"https://api.github.com/repos/communityshare/communityshare/issues/221/comments","statuses_url":"https://api.github.com/repos/communityshare/communityshare/statuses/1f55b47a58f6722b3bdac307ab8bb24146990e2c","head":{"label":"communityshare:fix/user-loading","ref":"fix/user-loading","sha":"1f55b47a58f6722b3bdac307ab8bb24146990e2c","user":{"login":"communityshare","id":17582499,"avatar_url":"https://avatars.githubusercontent.com/u/17582499?v=3","gravatar_id":"","url":"https://api.github.com/users/communityshare","html_url":"https://github.com/communityshare","followers_url":"https://api.github.com/users/communityshare/followers","following_url":"https://api.github.com/users/communityshare/following{/other_user}","gists_url":"https://api.github.com/users/communityshare/gists{/gist_id}","starred_url":"https://api.github.com/users/communityshare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/communityshare/subscriptions","organizations_url":"https://api.github.com/users/communityshare/orgs","repos_url":"https://api.github.com/users/communityshare/repos","events_url":"https://api.github.com/users/communityshare/events{/privacy}","received_events_url":"https://api.github.com/users/communityshare/received_events","type":"Organization","site_admin":false},"repo":{"id":18902595,"name":"communityshare","full_name":"communityshare/communityshare","owner":{"login":"communityshare","id":17582499,"avatar_url":"https://avatars.githubusercontent.com/u/17582499?v=3","gravatar_id":"","url":"https://api.github.com/users/communityshare","html_url":"https://github.com/communityshare","followers_url":"https://api.github.com/users/communityshare/followers","following_url":"https://api.github.com/users/communityshare/following{/other_user}","gists_url":"https://api.github.com/users/communityshare/gists{/gist_id}","starred_url":"https://api.github.com/users/communityshare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/communityshare/subscriptions","organizations_url":"https://api.github.com/users/communityshare/orgs","repos_url":"https://api.github.com/users/communityshare/repos","events_url":"https://api.github.com/users/communityshare/events{/privacy}","received_events_url":"https://api.github.com/users/communityshare/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/communityshare/communityshare","description":"An online network connecting educators with community partners","fork":false,"url":"https://api.github.com/repos/communityshare/communityshare","forks_url":"https://api.github.com/repos/communityshare/communityshare/forks","keys_url":"https://api.github.com/repos/communityshare/communityshare/keys{/key_id}","collaborators_url":"https://api.github.com/repos/communityshare/communityshare/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/communityshare/communityshare/teams","hooks_url":"https://api.github.com/repos/communityshare/communityshare/hooks","issue_events_url":"https://api.github.com/repos/communityshare/communityshare/issues/events{/number}","events_url":"https://api.github.com/repos/communityshare/communityshare/events","assignees_url":"https://api.github.com/repos/communityshare/communityshare/assignees{/user}","branches_url":"https://api.github.com/repos/communityshare/communityshare/branches{/branch}","tags_url":"https://api.github.com/repos/communityshare/communityshare/tags","blobs_url":"https://api.github.com/repos/communityshare/communityshare/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/communityshare/communityshare/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/communityshare/communityshare/git/refs{/sha}","trees_url":"https://api.github.com/repos/communityshare/communityshare/git/trees{/sha}","statuses_url":"https://api.github.com/repos/communityshare/communityshare/statuses/{sha}","languages_url":"https://api.github.com/repos/communityshare/communityshare/languages","stargazers_url":"https://api.github.com/repos/communityshare/communityshare/stargazers","contributors_url":"https://api.github.com/repos/communityshare/communityshare/contributors","subscribers_url":"https://api.github.com/repos/communityshare/communityshare/subscribers","subscription_url":"https://api.github.com/repos/communityshare/communityshare/subscription","commits_url":"https://api.github.com/repos/communityshare/communityshare/commits{/sha}","git_commits_url":"https://api.github.com/repos/communityshare/communityshare/git/commits{/sha}","comments_url":"https://api.github.com/repos/communityshare/communityshare/comments{/number}","issue_comment_url":"https://api.github.com/repos/communityshare/communityshare/issues/comments{/number}","contents_url":"https://api.github.com/repos/communityshare/communityshare/contents/{+path}","compare_url":"https://api.github.com/repos/communityshare/communityshare/compare/{base}...{head}","merges_url":"https://api.github.com/repos/communityshare/communityshare/merges","archive_url":"https://api.github.com/repos/communityshare/communityshare/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/communityshare/communityshare/downloads","issues_url":"https://api.github.com/repos/communityshare/communityshare/issues{/number}","pulls_url":"https://api.github.com/repos/communityshare/communityshare/pulls{/number}","milestones_url":"https://api.github.com/repos/communityshare/communityshare/milestones{/number}","notifications_url":"https://api.github.com/repos/communityshare/communityshare/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/communityshare/communityshare/labels{/name}","releases_url":"https://api.github.com/repos/communityshare/communityshare/releases{/id}","deployments_url":"https://api.github.com/repos/communityshare/communityshare/deployments","created_at":"2014-04-18T04:31:09Z","updated_at":"2016-10-05T05:39:05Z","pushed_at":"2016-10-17T04:59:35Z","git_url":"git://github.com/communityshare/communityshare.git","ssh_url":"git@github.com:communityshare/communityshare.git","clone_url":"https://github.com/communityshare/communityshare.git","svn_url":"https://github.com/communityshare/communityshare","homepage":null,"size":4405,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":49,"forks":12,"open_issues":49,"watchers":6,"default_branch":"master"}},"base":{"label":"communityshare:master","ref":"master","sha":"e98e47fd830225be2a08402adee1923a775c73f4","user":{"login":"communityshare","id":17582499,"avatar_url":"https://avatars.githubusercontent.com/u/17582499?v=3","gravatar_id":"","url":"https://api.github.com/users/communityshare","html_url":"https://github.com/communityshare","followers_url":"https://api.github.com/users/communityshare/followers","following_url":"https://api.github.com/users/communityshare/following{/other_user}","gists_url":"https://api.github.com/users/communityshare/gists{/gist_id}","starred_url":"https://api.github.com/users/communityshare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/communityshare/subscriptions","organizations_url":"https://api.github.com/users/communityshare/orgs","repos_url":"https://api.github.com/users/communityshare/repos","events_url":"https://api.github.com/users/communityshare/events{/privacy}","received_events_url":"https://api.github.com/users/communityshare/received_events","type":"Organization","site_admin":false},"repo":{"id":18902595,"name":"communityshare","full_name":"communityshare/communityshare","owner":{"login":"communityshare","id":17582499,"avatar_url":"https://avatars.githubusercontent.com/u/17582499?v=3","gravatar_id":"","url":"https://api.github.com/users/communityshare","html_url":"https://github.com/communityshare","followers_url":"https://api.github.com/users/communityshare/followers","following_url":"https://api.github.com/users/communityshare/following{/other_user}","gists_url":"https://api.github.com/users/communityshare/gists{/gist_id}","starred_url":"https://api.github.com/users/communityshare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/communityshare/subscriptions","organizations_url":"https://api.github.com/users/communityshare/orgs","repos_url":"https://api.github.com/users/communityshare/repos","events_url":"https://api.github.com/users/communityshare/events{/privacy}","received_events_url":"https://api.github.com/users/communityshare/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/communityshare/communityshare","description":"An online network connecting educators with community partners","fork":false,"url":"https://api.github.com/repos/communityshare/communityshare","forks_url":"https://api.github.com/repos/communityshare/communityshare/forks","keys_url":"https://api.github.com/repos/communityshare/communityshare/keys{/key_id}","collaborators_url":"https://api.github.com/repos/communityshare/communityshare/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/communityshare/communityshare/teams","hooks_url":"https://api.github.com/repos/communityshare/communityshare/hooks","issue_events_url":"https://api.github.com/repos/communityshare/communityshare/issues/events{/number}","events_url":"https://api.github.com/repos/communityshare/communityshare/events","assignees_url":"https://api.github.com/repos/communityshare/communityshare/assignees{/user}","branches_url":"https://api.github.com/repos/communityshare/communityshare/branches{/branch}","tags_url":"https://api.github.com/repos/communityshare/communityshare/tags","blobs_url":"https://api.github.com/repos/communityshare/communityshare/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/communityshare/communityshare/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/communityshare/communityshare/git/refs{/sha}","trees_url":"https://api.github.com/repos/communityshare/communityshare/git/trees{/sha}","statuses_url":"https://api.github.com/repos/communityshare/communityshare/statuses/{sha}","languages_url":"https://api.github.com/repos/communityshare/communityshare/languages","stargazers_url":"https://api.github.com/repos/communityshare/communityshare/stargazers","contributors_url":"https://api.github.com/repos/communityshare/communityshare/contributors","subscribers_url":"https://api.github.com/repos/communityshare/communityshare/subscribers","subscription_url":"https://api.github.com/repos/communityshare/communityshare/subscription","commits_url":"https://api.github.com/repos/communityshare/communityshare/commits{/sha}","git_commits_url":"https://api.github.com/repos/communityshare/communityshare/git/commits{/sha}","comments_url":"https://api.github.com/repos/communityshare/communityshare/comments{/number}","issue_comment_url":"https://api.github.com/repos/communityshare/communityshare/issues/comments{/number}","contents_url":"https://api.github.com/repos/communityshare/communityshare/contents/{+path}","compare_url":"https://api.github.com/repos/communityshare/communityshare/compare/{base}...{head}","merges_url":"https://api.github.com/repos/communityshare/communityshare/merges","archive_url":"https://api.github.com/repos/communityshare/communityshare/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/communityshare/communityshare/downloads","issues_url":"https://api.github.com/repos/communityshare/communityshare/issues{/number}","pulls_url":"https://api.github.com/repos/communityshare/communityshare/pulls{/number}","milestones_url":"https://api.github.com/repos/communityshare/communityshare/milestones{/number}","notifications_url":"https://api.github.com/repos/communityshare/communityshare/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/communityshare/communityshare/labels{/name}","releases_url":"https://api.github.com/repos/communityshare/communityshare/releases{/id}","deployments_url":"https://api.github.com/repos/communityshare/communityshare/deployments","created_at":"2014-04-18T04:31:09Z","updated_at":"2016-10-05T05:39:05Z","pushed_at":"2016-10-17T04:59:35Z","git_url":"git://github.com/communityshare/communityshare.git","ssh_url":"git@github.com:communityshare/communityshare.git","clone_url":"https://github.com/communityshare/communityshare.git","svn_url":"https://github.com/communityshare/communityshare","homepage":null,"size":4405,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":49,"forks":12,"open_issues":49,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/communityshare/communityshare/pulls/221"},"html":{"href":"https://github.com/communityshare/communityshare/pull/221"},"issue":{"href":"https://api.github.com/repos/communityshare/communityshare/issues/221"},"comments":{"href":"https://api.github.com/repos/communityshare/communityshare/issues/221/comments"},"review_comments":{"href":"https://api.github.com/repos/communityshare/communityshare/pulls/221/comments"},"review_comment":{"href":"https://api.github.com/repos/communityshare/communityshare/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/communityshare/communityshare/pulls/221/commits"},"statuses":{"href":"https://api.github.com/repos/communityshare/communityshare/statuses/1f55b47a58f6722b3bdac307ab8bb24146990e2c"}}}}
{"actor":{"display_login":"houndci-bot"}}