{"action":"created","issue":{"url":"https://api.github.com/repos/fielded/angular-nav-login/issues/14","repository_url":"https://api.github.com/repos/fielded/angular-nav-login","labels_url":"https://api.github.com/repos/fielded/angular-nav-login/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/fielded/angular-nav-login/issues/14/comments","events_url":"https://api.github.com/repos/fielded/angular-nav-login/issues/14/events","html_url":"https://github.com/fielded/angular-nav-login/pull/14","id":181131743,"number":14,"title":"fix: use navigator online to grant offline login","user":{"login":"tlvince","id":323761,"avatar_url":"https://avatars.githubusercontent.com/u/323761?v=3","gravatar_id":"","url":"https://api.github.com/users/tlvince","html_url":"https://github.com/tlvince","followers_url":"https://api.github.com/users/tlvince/followers","following_url":"https://api.github.com/users/tlvince/following{/other_user}","gists_url":"https://api.github.com/users/tlvince/gists{/gist_id}","starred_url":"https://api.github.com/users/tlvince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlvince/subscriptions","organizations_url":"https://api.github.com/users/tlvince/orgs","repos_url":"https://api.github.com/users/tlvince/repos","events_url":"https://api.github.com/users/tlvince/events{/privacy}","received_events_url":"https://api.github.com/users/tlvince/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-05T11:48:50Z","updated_at":"2016-10-05T14:02:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fielded/angular-nav-login/pulls/14","html_url":"https://github.com/fielded/angular-nav-login/pull/14","diff_url":"https://github.com/fielded/angular-nav-login/pull/14.diff","patch_url":"https://github.com/fielded/angular-nav-login/pull/14.patch"},"body":"Sometimes seeing different response statuses here (e.g. 500, though I'm not sure\nwhy). Revert to using naive `navigator.onLine` instead for offline login.\n\nCloses #13."},"comment":{"url":"https://api.github.com/repos/fielded/angular-nav-login/issues/comments/251683582","html_url":"https://github.com/fielded/angular-nav-login/pull/14#issuecomment-251683582","issue_url":"https://api.github.com/repos/fielded/angular-nav-login/issues/14","id":251683582,"user":{"login":"tlvince","id":323761,"avatar_url":"https://avatars.githubusercontent.com/u/323761?v=3","gravatar_id":"","url":"https://api.github.com/users/tlvince","html_url":"https://github.com/tlvince","followers_url":"https://api.github.com/users/tlvince/followers","following_url":"https://api.github.com/users/tlvince/following{/other_user}","gists_url":"https://api.github.com/users/tlvince/gists{/gist_id}","starred_url":"https://api.github.com/users/tlvince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlvince/subscriptions","organizations_url":"https://api.github.com/users/tlvince/orgs","repos_url":"https://api.github.com/users/tlvince/repos","events_url":"https://api.github.com/users/tlvince/events{/privacy}","received_events_url":"https://api.github.com/users/tlvince/received_events","type":"User","site_admin":false},"created_at":"2016-10-05T14:02:09Z","updated_at":"2016-10-05T14:02:09Z","body":"> only weird thing is that if I try to open the app while offline using the `?username=x&token=x` query I see a login error toaster.\r\n\r\nYeah, that's to be expected. If the query params exist, it'll hit the main `login` routine (call CouchDB `_session`, otherwise the Lambda signup). Do we need to add a `navigator.onLine` check there as well?\r\n\r\n> When user open the app from the nav desktop app, would that contain the credentials on the query string?\r\n\r\nNo. In the training guide, we asked them to login through the NAV web client first and click the button to access our dashboard, *then* create the desktop shortcut. So assuming that was successful, they should have bookmarked the main `/nav/dashboard` route."}}
{"actor":{"display_login":"tlvince"}}