{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/2945","labels_url":"https://api.github.com/repos/dotnet/coreclr/issues/2945/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/2945/comments","events_url":"https://api.github.com/repos/dotnet/coreclr/issues/2945/events","html_url":"https://github.com/dotnet/coreclr/pull/2945","id":130214159,"number":2945,"title":"Adds String.Join overload to accept char separator","user":{"login":"jasonwilliams200OK","id":2031765,"avatar_url":"https://avatars.githubusercontent.com/u/2031765?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonwilliams200OK","html_url":"https://github.com/jasonwilliams200OK","followers_url":"https://api.github.com/users/jasonwilliams200OK/followers","following_url":"https://api.github.com/users/jasonwilliams200OK/following{/other_user}","gists_url":"https://api.github.com/users/jasonwilliams200OK/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonwilliams200OK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonwilliams200OK/subscriptions","organizations_url":"https://api.github.com/users/jasonwilliams200OK/orgs","repos_url":"https://api.github.com/users/jasonwilliams200OK/repos","events_url":"https://api.github.com/users/jasonwilliams200OK/events{/privacy}","received_events_url":"https://api.github.com/users/jasonwilliams200OK/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/coreclr/labels/api%20addition","name":"api addition","color":"207de5"},{"url":"https://api.github.com/repos/dotnet/coreclr/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"AlexGhiondea","id":8396979,"avatar_url":"https://avatars.githubusercontent.com/u/8396979?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexGhiondea","html_url":"https://github.com/AlexGhiondea","followers_url":"https://api.github.com/users/AlexGhiondea/followers","following_url":"https://api.github.com/users/AlexGhiondea/following{/other_user}","gists_url":"https://api.github.com/users/AlexGhiondea/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexGhiondea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexGhiondea/subscriptions","organizations_url":"https://api.github.com/users/AlexGhiondea/orgs","repos_url":"https://api.github.com/users/AlexGhiondea/repos","events_url":"https://api.github.com/users/AlexGhiondea/events{/privacy}","received_events_url":"https://api.github.com/users/AlexGhiondea/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/dotnet/coreclr/milestones/5","html_url":"https://github.com/dotnet/coreclr/milestones/Future","labels_url":"https://api.github.com/repos/dotnet/coreclr/milestones/5/labels","id":1328081,"number":5,"title":"Future","description":"Milestone tracking the issues that have been triaged for after 1.0.0-rtm","creator":{"login":"joshfree","id":1302850,"avatar_url":"https://avatars.githubusercontent.com/u/1302850?v=3","gravatar_id":"","url":"https://api.github.com/users/joshfree","html_url":"https://github.com/joshfree","followers_url":"https://api.github.com/users/joshfree/followers","following_url":"https://api.github.com/users/joshfree/following{/other_user}","gists_url":"https://api.github.com/users/joshfree/gists{/gist_id}","starred_url":"https://api.github.com/users/joshfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshfree/subscriptions","organizations_url":"https://api.github.com/users/joshfree/orgs","repos_url":"https://api.github.com/users/joshfree/repos","events_url":"https://api.github.com/users/joshfree/events{/privacy}","received_events_url":"https://api.github.com/users/joshfree/received_events","type":"User","site_admin":false},"open_issues":286,"closed_issues":17,"state":"open","created_at":"2015-09-29T00:26:07Z","updated_at":"2016-02-01T01:49:57Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2016-01-31T23:50:52Z","updated_at":"2016-02-01T16:56:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/2945","html_url":"https://github.com/dotnet/coreclr/pull/2945","diff_url":"https://github.com/dotnet/coreclr/pull/2945.diff","patch_url":"https://github.com/dotnet/coreclr/pull/2945.patch"},"body":"This adds five additional overload signatures for string.Join to accept\r\nchar separator.\r\nSince the implementation of:\r\n```c#\r\nJoin(String separator, String[] value, int startIndex, int count)\r\n```\r\nrelies on `UnSafeCharBuffer.AppendString(string)` (which is not exposed\r\nto user land), I have added a char substitute for same.\r\n\r\nAlso removed an additional check for `separator==null`, which wasn't\r\npresent in `Join(String separator, IEnumerable<String> values)` either.\r\n`StringBuilder.Append` and `UnSafeCharBuffer.AppendString` both handle\r\nthis case explicitly.\r\n\r\nFixes dotnet/corefx#5552."},"comment":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/comments/178066425","html_url":"https://github.com/dotnet/coreclr/pull/2945#issuecomment-178066425","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/2945","id":178066425,"user":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars.githubusercontent.com/u/6668460?v=3","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"created_at":"2016-02-01T16:56:33Z","updated_at":"2016-02-01T16:56:33Z","body":"These failures do not look related.\r\n\r\ncscbench is known to fail spuriously https://github.com/dotnet/coreclr/issues/2728 . @RussKeldorph could you please disable it from running in CI to avoid false alarms until the failure is understood? And b151440_static_object_static_object too since it seems to be another flaky test."}}