{"action":"created","comment":{"url":"https://api.github.com/repos/square/p2/pulls/comments/78035207","id":78035207,"diff_hunk":"@@ -157,3 +158,18 @@ func TestAddUnrecognizedHook(t *testing.T) {\n \terr := logger.AddHook(\"unrecognized_type\", \"some_destination\")\n \tAssert(t).IsNotNil(err, \"Expected an error for adding an unrecognized hook output type\")\n }\n+\n+func TestConcurrent(t *testing.T) {","path":"pkg/logging/logging_test.go","position":null,"original_position":13,"commit_id":"f2b3a665b548b1f5dfb78f267ffcc8f1c567493d","original_commit_id":"4b1395427b2cea07514d4bf9298a77cfd4e7a715","user":{"login":"bwester","id":1501338,"avatar_url":"https://avatars.githubusercontent.com/u/1501338?v=3","gravatar_id":"","url":"https://api.github.com/users/bwester","html_url":"https://github.com/bwester","followers_url":"https://api.github.com/users/bwester/followers","following_url":"https://api.github.com/users/bwester/following{/other_user}","gists_url":"https://api.github.com/users/bwester/gists{/gist_id}","starred_url":"https://api.github.com/users/bwester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwester/subscriptions","organizations_url":"https://api.github.com/users/bwester/orgs","repos_url":"https://api.github.com/users/bwester/repos","events_url":"https://api.github.com/users/bwester/events{/privacy}","received_events_url":"https://api.github.com/users/bwester/received_events","type":"User","site_admin":false},"body":"> without the attached code change, it will crash due to a concurrent write?\r\n\r\nThat's the idea. I've added a comment to make that clearer.","created_at":"2016-09-08T15:56:18Z","updated_at":"2016-09-08T15:56:18Z","html_url":"https://github.com/square/p2/pull/638#discussion_r78035207","pull_request_url":"https://api.github.com/repos/square/p2/pulls/638","_links":{"self":{"href":"https://api.github.com/repos/square/p2/pulls/comments/78035207"},"html":{"href":"https://github.com/square/p2/pull/638#discussion_r78035207"},"pull_request":{"href":"https://api.github.com/repos/square/p2/pulls/638"}}},"pull_request":{"url":"https://api.github.com/repos/square/p2/pulls/638","id":84373197,"html_url":"https://github.com/square/p2/pull/638","diff_url":"https://github.com/square/p2/pull/638.diff","patch_url":"https://github.com/square/p2/pull/638.patch","issue_url":"https://api.github.com/repos/square/p2/issues/638","number":638,"state":"open","locked":false,"title":"logging: Fix data race adding \"Counter\" to entries","user":{"login":"bwester","id":1501338,"avatar_url":"https://avatars.githubusercontent.com/u/1501338?v=3","gravatar_id":"","url":"https://api.github.com/users/bwester","html_url":"https://github.com/bwester","followers_url":"https://api.github.com/users/bwester/followers","following_url":"https://api.github.com/users/bwester/following{/other_user}","gists_url":"https://api.github.com/users/bwester/gists{/gist_id}","starred_url":"https://api.github.com/users/bwester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwester/subscriptions","organizations_url":"https://api.github.com/users/bwester/orgs","repos_url":"https://api.github.com/users/bwester/repos","events_url":"https://api.github.com/users/bwester/events{/privacy}","received_events_url":"https://api.github.com/users/bwester/received_events","type":"User","site_admin":false},"body":"ProcessCounter.Fire() contained a data race modifying the entry.Data map\r\nto add the \"Counter\" and \"PID\" fields. Logrus makes a copy of the Entry\r\nobject, but it is shallow, so multiple loggers could share the same map.\r\n\r\nThe bug is fixed by having Fire() update a copy of Data.","created_at":"2016-09-07T21:03:11Z","updated_at":"2016-09-08T15:56:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e4ef45496e99c1364445e5cf5484c6c4d6b4ef0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/square/p2/pulls/638/commits","review_comments_url":"https://api.github.com/repos/square/p2/pulls/638/comments","review_comment_url":"https://api.github.com/repos/square/p2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/square/p2/issues/638/comments","statuses_url":"https://api.github.com/repos/square/p2/statuses/f2b3a665b548b1f5dfb78f267ffcc8f1c567493d","head":{"label":"bwester:lograce","ref":"lograce","sha":"f2b3a665b548b1f5dfb78f267ffcc8f1c567493d","user":{"login":"bwester","id":1501338,"avatar_url":"https://avatars.githubusercontent.com/u/1501338?v=3","gravatar_id":"","url":"https://api.github.com/users/bwester","html_url":"https://github.com/bwester","followers_url":"https://api.github.com/users/bwester/followers","following_url":"https://api.github.com/users/bwester/following{/other_user}","gists_url":"https://api.github.com/users/bwester/gists{/gist_id}","starred_url":"https://api.github.com/users/bwester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwester/subscriptions","organizations_url":"https://api.github.com/users/bwester/orgs","repos_url":"https://api.github.com/users/bwester/repos","events_url":"https://api.github.com/users/bwester/events{/privacy}","received_events_url":"https://api.github.com/users/bwester/received_events","type":"User","site_admin":false},"repo":{"id":33944046,"name":"p2","full_name":"bwester/p2","owner":{"login":"bwester","id":1501338,"avatar_url":"https://avatars.githubusercontent.com/u/1501338?v=3","gravatar_id":"","url":"https://api.github.com/users/bwester","html_url":"https://github.com/bwester","followers_url":"https://api.github.com/users/bwester/followers","following_url":"https://api.github.com/users/bwester/following{/other_user}","gists_url":"https://api.github.com/users/bwester/gists{/gist_id}","starred_url":"https://api.github.com/users/bwester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwester/subscriptions","organizations_url":"https://api.github.com/users/bwester/orgs","repos_url":"https://api.github.com/users/bwester/repos","events_url":"https://api.github.com/users/bwester/events{/privacy}","received_events_url":"https://api.github.com/users/bwester/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bwester/p2","description":"Platypus Platform: Tools for Scalable Deployment","fork":true,"url":"https://api.github.com/repos/bwester/p2","forks_url":"https://api.github.com/repos/bwester/p2/forks","keys_url":"https://api.github.com/repos/bwester/p2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bwester/p2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bwester/p2/teams","hooks_url":"https://api.github.com/repos/bwester/p2/hooks","issue_events_url":"https://api.github.com/repos/bwester/p2/issues/events{/number}","events_url":"https://api.github.com/repos/bwester/p2/events","assignees_url":"https://api.github.com/repos/bwester/p2/assignees{/user}","branches_url":"https://api.github.com/repos/bwester/p2/branches{/branch}","tags_url":"https://api.github.com/repos/bwester/p2/tags","blobs_url":"https://api.github.com/repos/bwester/p2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bwester/p2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bwester/p2/git/refs{/sha}","trees_url":"https://api.github.com/repos/bwester/p2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bwester/p2/statuses/{sha}","languages_url":"https://api.github.com/repos/bwester/p2/languages","stargazers_url":"https://api.github.com/repos/bwester/p2/stargazers","contributors_url":"https://api.github.com/repos/bwester/p2/contributors","subscribers_url":"https://api.github.com/repos/bwester/p2/subscribers","subscription_url":"https://api.github.com/repos/bwester/p2/subscription","commits_url":"https://api.github.com/repos/bwester/p2/commits{/sha}","git_commits_url":"https://api.github.com/repos/bwester/p2/git/commits{/sha}","comments_url":"https://api.github.com/repos/bwester/p2/comments{/number}","issue_comment_url":"https://api.github.com/repos/bwester/p2/issues/comments{/number}","contents_url":"https://api.github.com/repos/bwester/p2/contents/{+path}","compare_url":"https://api.github.com/repos/bwester/p2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bwester/p2/merges","archive_url":"https://api.github.com/repos/bwester/p2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bwester/p2/downloads","issues_url":"https://api.github.com/repos/bwester/p2/issues{/number}","pulls_url":"https://api.github.com/repos/bwester/p2/pulls{/number}","milestones_url":"https://api.github.com/repos/bwester/p2/milestones{/number}","notifications_url":"https://api.github.com/repos/bwester/p2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bwester/p2/labels{/name}","releases_url":"https://api.github.com/repos/bwester/p2/releases{/id}","deployments_url":"https://api.github.com/repos/bwester/p2/deployments","created_at":"2015-04-14T16:40:53Z","updated_at":"2016-01-11T23:55:50Z","pushed_at":"2016-09-08T15:53:09Z","git_url":"git://github.com/bwester/p2.git","ssh_url":"git@github.com:bwester/p2.git","clone_url":"https://github.com/bwester/p2.git","svn_url":"https://github.com/bwester/p2","homepage":"","size":41048,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"square:master","ref":"master","sha":"331e7e85d9154355c72bbae706a7d5447210f01e","user":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"repo":{"id":25320424,"name":"p2","full_name":"square/p2","owner":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/square/p2","description":"Platypus Platform: Tools for Scalable Deployment","fork":false,"url":"https://api.github.com/repos/square/p2","forks_url":"https://api.github.com/repos/square/p2/forks","keys_url":"https://api.github.com/repos/square/p2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/square/p2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/square/p2/teams","hooks_url":"https://api.github.com/repos/square/p2/hooks","issue_events_url":"https://api.github.com/repos/square/p2/issues/events{/number}","events_url":"https://api.github.com/repos/square/p2/events","assignees_url":"https://api.github.com/repos/square/p2/assignees{/user}","branches_url":"https://api.github.com/repos/square/p2/branches{/branch}","tags_url":"https://api.github.com/repos/square/p2/tags","blobs_url":"https://api.github.com/repos/square/p2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/square/p2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/square/p2/git/refs{/sha}","trees_url":"https://api.github.com/repos/square/p2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/square/p2/statuses/{sha}","languages_url":"https://api.github.com/repos/square/p2/languages","stargazers_url":"https://api.github.com/repos/square/p2/stargazers","contributors_url":"https://api.github.com/repos/square/p2/contributors","subscribers_url":"https://api.github.com/repos/square/p2/subscribers","subscription_url":"https://api.github.com/repos/square/p2/subscription","commits_url":"https://api.github.com/repos/square/p2/commits{/sha}","git_commits_url":"https://api.github.com/repos/square/p2/git/commits{/sha}","comments_url":"https://api.github.com/repos/square/p2/comments{/number}","issue_comment_url":"https://api.github.com/repos/square/p2/issues/comments{/number}","contents_url":"https://api.github.com/repos/square/p2/contents/{+path}","compare_url":"https://api.github.com/repos/square/p2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/square/p2/merges","archive_url":"https://api.github.com/repos/square/p2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/square/p2/downloads","issues_url":"https://api.github.com/repos/square/p2/issues{/number}","pulls_url":"https://api.github.com/repos/square/p2/pulls{/number}","milestones_url":"https://api.github.com/repos/square/p2/milestones{/number}","notifications_url":"https://api.github.com/repos/square/p2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/square/p2/labels{/name}","releases_url":"https://api.github.com/repos/square/p2/releases{/id}","deployments_url":"https://api.github.com/repos/square/p2/deployments","created_at":"2014-10-16T20:31:12Z","updated_at":"2016-08-24T07:06:56Z","pushed_at":"2016-09-08T15:53:09Z","git_url":"git://github.com/square/p2.git","ssh_url":"git@github.com:square/p2.git","clone_url":"https://github.com/square/p2.git","svn_url":"https://github.com/square/p2","homepage":"","size":41476,"stargazers_count":122,"watchers_count":122,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":10,"forks":22,"open_issues":10,"watchers":122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/square/p2/pulls/638"},"html":{"href":"https://github.com/square/p2/pull/638"},"issue":{"href":"https://api.github.com/repos/square/p2/issues/638"},"comments":{"href":"https://api.github.com/repos/square/p2/issues/638/comments"},"review_comments":{"href":"https://api.github.com/repos/square/p2/pulls/638/comments"},"review_comment":{"href":"https://api.github.com/repos/square/p2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/square/p2/pulls/638/commits"},"statuses":{"href":"https://api.github.com/repos/square/p2/statuses/f2b3a665b548b1f5dfb78f267ffcc8f1c567493d"}}}}
{"actor":{"display_login":"bwester"}}