{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach-go/issues/18","repository_url":"https://api.github.com/repos/cockroachdb/cockroach-go","labels_url":"https://api.github.com/repos/cockroachdb/cockroach-go/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach-go/issues/18/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach-go/issues/18/events","html_url":"https://github.com/cockroachdb/cockroach-go/pull/18","id":177030568,"number":18,"title":"Move the client lib to use the standard lib/pq","user":{"login":"andreimatei","id":377201,"avatar_url":"https://avatars.githubusercontent.com/u/377201?v=3","gravatar_id":"","url":"https://api.github.com/users/andreimatei","html_url":"https://github.com/andreimatei","followers_url":"https://api.github.com/users/andreimatei/followers","following_url":"https://api.github.com/users/andreimatei/following{/other_user}","gists_url":"https://api.github.com/users/andreimatei/gists{/gist_id}","starred_url":"https://api.github.com/users/andreimatei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreimatei/subscriptions","organizations_url":"https://api.github.com/users/andreimatei/orgs","repos_url":"https://api.github.com/users/andreimatei/repos","events_url":"https://api.github.com/users/andreimatei/events{/privacy}","received_events_url":"https://api.github.com/users/andreimatei/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"spencerkimball","id":6147149,"avatar_url":"https://avatars.githubusercontent.com/u/6147149?v=3","gravatar_id":"","url":"https://api.github.com/users/spencerkimball","html_url":"https://github.com/spencerkimball","followers_url":"https://api.github.com/users/spencerkimball/followers","following_url":"https://api.github.com/users/spencerkimball/following{/other_user}","gists_url":"https://api.github.com/users/spencerkimball/gists{/gist_id}","starred_url":"https://api.github.com/users/spencerkimball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencerkimball/subscriptions","organizations_url":"https://api.github.com/users/spencerkimball/orgs","repos_url":"https://api.github.com/users/spencerkimball/repos","events_url":"https://api.github.com/users/spencerkimball/events{/privacy}","received_events_url":"https://api.github.com/users/spencerkimball/received_events","type":"User","site_admin":false},"assignees":[{"login":"spencerkimball","id":6147149,"avatar_url":"https://avatars.githubusercontent.com/u/6147149?v=3","gravatar_id":"","url":"https://api.github.com/users/spencerkimball","html_url":"https://github.com/spencerkimball","followers_url":"https://api.github.com/users/spencerkimball/followers","following_url":"https://api.github.com/users/spencerkimball/following{/other_user}","gists_url":"https://api.github.com/users/spencerkimball/gists{/gist_id}","starred_url":"https://api.github.com/users/spencerkimball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencerkimball/subscriptions","organizations_url":"https://api.github.com/users/spencerkimball/orgs","repos_url":"https://api.github.com/users/spencerkimball/repos","events_url":"https://api.github.com/users/spencerkimball/events{/privacy}","received_events_url":"https://api.github.com/users/spencerkimball/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-09-14T21:48:21Z","updated_at":"2016-09-15T01:15:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach-go/pulls/18","html_url":"https://github.com/cockroachdb/cockroach-go/pull/18","diff_url":"https://github.com/cockroachdb/cockroach-go/pull/18.diff","patch_url":"https://github.com/cockroachdb/cockroach-go/pull/18.patch"},"body":"... instead of our forked one. This will help people who are trying to\r\nlink in both crdb and lib/pq.\r\n\r\nThe test fix was necessary because our forked libpq has a different way\r\nof consuming results, making exhausting the `rows` cursor somehow not\r\nnecessary.\r\n\r\nFixes #17\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach-go/18)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach-go/issues/comments/247205292","html_url":"https://github.com/cockroachdb/cockroach-go/pull/18#issuecomment-247205292","issue_url":"https://api.github.com/repos/cockroachdb/cockroach-go/issues/18","id":247205292,"user":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"created_at":"2016-09-15T01:15:35Z","updated_at":"2016-09-15T01:15:35Z","body":"\n\n\n\nReview status: 0 of 2 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.\n\n---\n\n*[crdb/tx.go, line 24 at r1](https://reviewable.io:443/reviews/cockroachdb/cockroach-go/18#-KRfOpQc2A852G4ngzw4:-KRfOpQc2A852G4ngzw5:binsxlw) ([raw file](https://github.com/cockroachdb/cockroach-go/blob/c355fae646b95bd2a887080a2b6ea5b2a3a7c478/crdb/tx.go#L24)):*\n> ```Go\n> \t\"database/sql\"\n> \n> \t\"github.com/lib/pq\"\n> ```\n\nDoesn't this prevent us from using `github.com/cockroachdb/pq` with `cockroach-go`?  I think some of the code in `github.com/cockroachdb/examples-go` will break. And some code in the main cockroach repo which uses `cockroach-go`.\n\n---\n\n*[crdb/tx_test.go, line 25 at r1](https://reviewable.io:443/reviews/cockroachdb/cockroach-go/18#-KRfPK72NfhCPFg5ds89:-KRfPK72NfhCPFg5ds8A:b2s2ria) ([raw file](https://github.com/cockroachdb/cockroach-go/blob/c355fae646b95bd2a887080a2b6ea5b2a3a7c478/crdb/tx_test.go#L25)):*\n> ```Go\n> \t\"testing\"\n> \n> \t\"github.com/cockroach-go/testserver\"\n> ```\n\nWhat is this?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach-go/18)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"petermattis"}}