{"action":"created","issue":{"url":"https://api.github.com/repos/rwengine/openrw/issues/130","repository_url":"https://api.github.com/repos/rwengine/openrw","labels_url":"https://api.github.com/repos/rwengine/openrw/issues/130/labels{/name}","comments_url":"https://api.github.com/repos/rwengine/openrw/issues/130/comments","events_url":"https://api.github.com/repos/rwengine/openrw/issues/130/events","html_url":"https://github.com/rwengine/openrw/pull/130","id":158514809,"number":130,"title":"Make rwgame build and run on windows","user":{"login":"haphzd","id":19692811,"avatar_url":"https://avatars.githubusercontent.com/u/19692811?v=3","gravatar_id":"","url":"https://api.github.com/users/haphzd","html_url":"https://github.com/haphzd","followers_url":"https://api.github.com/users/haphzd/followers","following_url":"https://api.github.com/users/haphzd/following{/other_user}","gists_url":"https://api.github.com/users/haphzd/gists{/gist_id}","starred_url":"https://api.github.com/users/haphzd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haphzd/subscriptions","organizations_url":"https://api.github.com/users/haphzd/orgs","repos_url":"https://api.github.com/users/haphzd/repos","events_url":"https://api.github.com/users/haphzd/events{/privacy}","received_events_url":"https://api.github.com/users/haphzd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-04T17:27:52Z","updated_at":"2016-06-04T17:39:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rwengine/openrw/pulls/130","html_url":"https://github.com/rwengine/openrw/pull/130","diff_url":"https://github.com/rwengine/openrw/pull/130.diff","patch_url":"https://github.com/rwengine/openrw/pull/130.patch"},"body":"Hi. I'm kinda new at all of this, so there are couple things I am not sure about. \r\n1) Msdirent header (how to distribute it? where should it be in the project tree?) \r\n2) Some defines in the windows platform headers collide with enum identifiers and class fields/members names. My approach at solving this is questionable (a header with #undef macros), but it's the only one that worked for me.\r\nI haven't tried to build tools and tests, just rwgame/rwengine/rwlib."},"comment":{"url":"https://api.github.com/repos/rwengine/openrw/issues/comments/223768319","html_url":"https://github.com/rwengine/openrw/pull/130#issuecomment-223768319","issue_url":"https://api.github.com/repos/rwengine/openrw/issues/130","id":223768319,"user":{"login":"JayFoxRox","id":360330,"avatar_url":"https://avatars.githubusercontent.com/u/360330?v=3","gravatar_id":"","url":"https://api.github.com/users/JayFoxRox","html_url":"https://github.com/JayFoxRox","followers_url":"https://api.github.com/users/JayFoxRox/followers","following_url":"https://api.github.com/users/JayFoxRox/following{/other_user}","gists_url":"https://api.github.com/users/JayFoxRox/gists{/gist_id}","starred_url":"https://api.github.com/users/JayFoxRox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JayFoxRox/subscriptions","organizations_url":"https://api.github.com/users/JayFoxRox/orgs","repos_url":"https://api.github.com/users/JayFoxRox/repos","events_url":"https://api.github.com/users/JayFoxRox/events{/privacy}","received_events_url":"https://api.github.com/users/JayFoxRox/received_events","type":"User","site_admin":false},"created_at":"2016-06-04T17:39:10Z","updated_at":"2016-06-04T17:39:10Z","body":"1. I'd suggest https://github.com/tronkko/dirent as submodule (which seems to be the original author)\r\nAnother solution is to change respective code paths to use windows functions directly or to abstract the entire file-io in general.\r\n2. Where do these defines come from? Maybe MS have a way to disable them?\r\nI'd say keep `#undef` for now and later attempt to get platform specific includes out of the files where we have enums etc. so this couldn't happen in the first place.\r\n\r\nI'll probably review this too but I'm not sure when I'll find the time to do it."}}
{"actor":{"display_login":"JayFoxRox"}}