{"action":"created","comment":{"url":"https://api.github.com/repos/quantopian/zipline/pulls/comments/58201031","id":58201031,"diff_hunk":"@@ -37,10 +37,50 @@ def minute_value(ndarray[long_t, ndim=1] market_opens,\n     return market_opens[q] + r\n \n def find_position_of_minute(ndarray[long_t, ndim=1] market_opens,\n+                            ndarray[long_t, ndim=1] market_closes,","path":"zipline/data/_minute_bar_internal.pyx","position":4,"original_position":4,"commit_id":"e64cf5d6efe2ed6eb2f0642bf58b537ddeed9626","original_commit_id":"dbe1e68f49b43521feafc7fad7ec44630adc866a","user":{"login":"jbredeche","id":487622,"avatar_url":"https://avatars.githubusercontent.com/u/487622?v=3","gravatar_id":"","url":"https://api.github.com/users/jbredeche","html_url":"https://github.com/jbredeche","followers_url":"https://api.github.com/users/jbredeche/followers","following_url":"https://api.github.com/users/jbredeche/following{/other_user}","gists_url":"https://api.github.com/users/jbredeche/gists{/gist_id}","starred_url":"https://api.github.com/users/jbredeche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbredeche/subscriptions","organizations_url":"https://api.github.com/users/jbredeche/orgs","repos_url":"https://api.github.com/users/jbredeche/repos","events_url":"https://api.github.com/users/jbredeche/events{/privacy}","received_events_url":"https://api.github.com/users/jbredeche/received_events","type":"User","site_admin":false},"body":"this whole diff confused me until I realized you had simply renamed the original `find_position_of_minute ` method to `find_position_of_minute_half_day_unadjusted` and added some logic in there to be resilient against day barriers.  I was confused why you had been changing the `IntervalTree` logic elsewhere.\r\n\r\nI think it would be easier to parse if we kept `find_position_of_minute` with the same name (and add the small piece of new logic in there), and create a new method called `find_position_of_minute_with_halfdays` that is the totally new method.  I can do this later today if needed.","created_at":"2016-04-01T12:55:13Z","updated_at":"2016-04-01T12:55:13Z","html_url":"https://github.com/quantopian/zipline/pull/1101#discussion_r58201031","pull_request_url":"https://api.github.com/repos/quantopian/zipline/pulls/1101","_links":{"self":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/comments/58201031"},"html":{"href":"https://github.com/quantopian/zipline/pull/1101#discussion_r58201031"},"pull_request":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/1101"}}},"pull_request":{"url":"https://api.github.com/repos/quantopian/zipline/pulls/1101","id":64873041,"html_url":"https://github.com/quantopian/zipline/pull/1101","diff_url":"https://github.com/quantopian/zipline/pull/1101.diff","patch_url":"https://github.com/quantopian/zipline/pull/1101.patch","issue_url":"https://api.github.com/repos/quantopian/zipline/issues/1101","number":1101,"state":"open","locked":false,"title":"Fixes to context.portfolio and context.portfolio crashes","user":{"login":"lianga888","id":10404037,"avatar_url":"https://avatars.githubusercontent.com/u/10404037?v=3","gravatar_id":"","url":"https://api.github.com/users/lianga888","html_url":"https://github.com/lianga888","followers_url":"https://api.github.com/users/lianga888/followers","following_url":"https://api.github.com/users/lianga888/following{/other_user}","gists_url":"https://api.github.com/users/lianga888/gists{/gist_id}","starred_url":"https://api.github.com/users/lianga888/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lianga888/subscriptions","organizations_url":"https://api.github.com/users/lianga888/orgs","repos_url":"https://api.github.com/users/lianga888/repos","events_url":"https://api.github.com/users/lianga888/events{/privacy}","received_events_url":"https://api.github.com/users/lianga888/received_events","type":"User","site_admin":false},"body":"- Minute bar reader is now compatible with non trading minutes\r\n- Calls to context.portfolio and context.account in BTS should adjust for overnight splits\r\n\r\nIMPORTANT: Only the first commit passes right now. The second commit breaks tests for daily mode algos","created_at":"2016-03-31T23:02:49Z","updated_at":"2016-04-01T12:55:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86c6f838b91c789b69b295408399ea70c6ac5f53","assignee":{"login":"jbredeche","id":487622,"avatar_url":"https://avatars.githubusercontent.com/u/487622?v=3","gravatar_id":"","url":"https://api.github.com/users/jbredeche","html_url":"https://github.com/jbredeche","followers_url":"https://api.github.com/users/jbredeche/followers","following_url":"https://api.github.com/users/jbredeche/following{/other_user}","gists_url":"https://api.github.com/users/jbredeche/gists{/gist_id}","starred_url":"https://api.github.com/users/jbredeche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbredeche/subscriptions","organizations_url":"https://api.github.com/users/jbredeche/orgs","repos_url":"https://api.github.com/users/jbredeche/repos","events_url":"https://api.github.com/users/jbredeche/events{/privacy}","received_events_url":"https://api.github.com/users/jbredeche/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/quantopian/zipline/pulls/1101/commits","review_comments_url":"https://api.github.com/repos/quantopian/zipline/pulls/1101/comments","review_comment_url":"https://api.github.com/repos/quantopian/zipline/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quantopian/zipline/issues/1101/comments","statuses_url":"https://api.github.com/repos/quantopian/zipline/statuses/e64cf5d6efe2ed6eb2f0642bf58b537ddeed9626","head":{"label":"quantopian:bts_portfolio","ref":"bts_portfolio","sha":"e64cf5d6efe2ed6eb2f0642bf58b537ddeed9626","user":{"login":"quantopian","id":1393215,"avatar_url":"https://avatars.githubusercontent.com/u/1393215?v=3","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"repo":{"id":6297520,"name":"zipline","full_name":"quantopian/zipline","owner":{"login":"quantopian","id":1393215,"avatar_url":"https://avatars.githubusercontent.com/u/1393215?v=3","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quantopian/zipline","description":"Zipline, a Pythonic Algorithmic Trading Library","fork":false,"url":"https://api.github.com/repos/quantopian/zipline","forks_url":"https://api.github.com/repos/quantopian/zipline/forks","keys_url":"https://api.github.com/repos/quantopian/zipline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quantopian/zipline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quantopian/zipline/teams","hooks_url":"https://api.github.com/repos/quantopian/zipline/hooks","issue_events_url":"https://api.github.com/repos/quantopian/zipline/issues/events{/number}","events_url":"https://api.github.com/repos/quantopian/zipline/events","assignees_url":"https://api.github.com/repos/quantopian/zipline/assignees{/user}","branches_url":"https://api.github.com/repos/quantopian/zipline/branches{/branch}","tags_url":"https://api.github.com/repos/quantopian/zipline/tags","blobs_url":"https://api.github.com/repos/quantopian/zipline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quantopian/zipline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quantopian/zipline/git/refs{/sha}","trees_url":"https://api.github.com/repos/quantopian/zipline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quantopian/zipline/statuses/{sha}","languages_url":"https://api.github.com/repos/quantopian/zipline/languages","stargazers_url":"https://api.github.com/repos/quantopian/zipline/stargazers","contributors_url":"https://api.github.com/repos/quantopian/zipline/contributors","subscribers_url":"https://api.github.com/repos/quantopian/zipline/subscribers","subscription_url":"https://api.github.com/repos/quantopian/zipline/subscription","commits_url":"https://api.github.com/repos/quantopian/zipline/commits{/sha}","git_commits_url":"https://api.github.com/repos/quantopian/zipline/git/commits{/sha}","comments_url":"https://api.github.com/repos/quantopian/zipline/comments{/number}","issue_comment_url":"https://api.github.com/repos/quantopian/zipline/issues/comments{/number}","contents_url":"https://api.github.com/repos/quantopian/zipline/contents/{+path}","compare_url":"https://api.github.com/repos/quantopian/zipline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quantopian/zipline/merges","archive_url":"https://api.github.com/repos/quantopian/zipline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quantopian/zipline/downloads","issues_url":"https://api.github.com/repos/quantopian/zipline/issues{/number}","pulls_url":"https://api.github.com/repos/quantopian/zipline/pulls{/number}","milestones_url":"https://api.github.com/repos/quantopian/zipline/milestones{/number}","notifications_url":"https://api.github.com/repos/quantopian/zipline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quantopian/zipline/labels{/name}","releases_url":"https://api.github.com/repos/quantopian/zipline/releases{/id}","deployments_url":"https://api.github.com/repos/quantopian/zipline/deployments","created_at":"2012-10-19T15:50:29Z","updated_at":"2016-04-01T05:25:31Z","pushed_at":"2016-04-01T01:33:57Z","git_url":"git://github.com/quantopian/zipline.git","ssh_url":"git@github.com:quantopian/zipline.git","clone_url":"https://github.com/quantopian/zipline.git","svn_url":"https://github.com/quantopian/zipline","homepage":"","size":17201,"stargazers_count":3040,"watchers_count":3040,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":895,"mirror_url":null,"open_issues_count":156,"forks":895,"open_issues":156,"watchers":3040,"default_branch":"master"}},"base":{"label":"quantopian:lazy-mainline","ref":"lazy-mainline","sha":"a5beb8d76f89d20ac4506ebdbedbd6100d8d975c","user":{"login":"quantopian","id":1393215,"avatar_url":"https://avatars.githubusercontent.com/u/1393215?v=3","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"repo":{"id":6297520,"name":"zipline","full_name":"quantopian/zipline","owner":{"login":"quantopian","id":1393215,"avatar_url":"https://avatars.githubusercontent.com/u/1393215?v=3","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quantopian/zipline","description":"Zipline, a Pythonic Algorithmic Trading Library","fork":false,"url":"https://api.github.com/repos/quantopian/zipline","forks_url":"https://api.github.com/repos/quantopian/zipline/forks","keys_url":"https://api.github.com/repos/quantopian/zipline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quantopian/zipline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quantopian/zipline/teams","hooks_url":"https://api.github.com/repos/quantopian/zipline/hooks","issue_events_url":"https://api.github.com/repos/quantopian/zipline/issues/events{/number}","events_url":"https://api.github.com/repos/quantopian/zipline/events","assignees_url":"https://api.github.com/repos/quantopian/zipline/assignees{/user}","branches_url":"https://api.github.com/repos/quantopian/zipline/branches{/branch}","tags_url":"https://api.github.com/repos/quantopian/zipline/tags","blobs_url":"https://api.github.com/repos/quantopian/zipline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quantopian/zipline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quantopian/zipline/git/refs{/sha}","trees_url":"https://api.github.com/repos/quantopian/zipline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quantopian/zipline/statuses/{sha}","languages_url":"https://api.github.com/repos/quantopian/zipline/languages","stargazers_url":"https://api.github.com/repos/quantopian/zipline/stargazers","contributors_url":"https://api.github.com/repos/quantopian/zipline/contributors","subscribers_url":"https://api.github.com/repos/quantopian/zipline/subscribers","subscription_url":"https://api.github.com/repos/quantopian/zipline/subscription","commits_url":"https://api.github.com/repos/quantopian/zipline/commits{/sha}","git_commits_url":"https://api.github.com/repos/quantopian/zipline/git/commits{/sha}","comments_url":"https://api.github.com/repos/quantopian/zipline/comments{/number}","issue_comment_url":"https://api.github.com/repos/quantopian/zipline/issues/comments{/number}","contents_url":"https://api.github.com/repos/quantopian/zipline/contents/{+path}","compare_url":"https://api.github.com/repos/quantopian/zipline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quantopian/zipline/merges","archive_url":"https://api.github.com/repos/quantopian/zipline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quantopian/zipline/downloads","issues_url":"https://api.github.com/repos/quantopian/zipline/issues{/number}","pulls_url":"https://api.github.com/repos/quantopian/zipline/pulls{/number}","milestones_url":"https://api.github.com/repos/quantopian/zipline/milestones{/number}","notifications_url":"https://api.github.com/repos/quantopian/zipline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quantopian/zipline/labels{/name}","releases_url":"https://api.github.com/repos/quantopian/zipline/releases{/id}","deployments_url":"https://api.github.com/repos/quantopian/zipline/deployments","created_at":"2012-10-19T15:50:29Z","updated_at":"2016-04-01T05:25:31Z","pushed_at":"2016-04-01T01:33:57Z","git_url":"git://github.com/quantopian/zipline.git","ssh_url":"git@github.com:quantopian/zipline.git","clone_url":"https://github.com/quantopian/zipline.git","svn_url":"https://github.com/quantopian/zipline","homepage":"","size":17201,"stargazers_count":3040,"watchers_count":3040,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":895,"mirror_url":null,"open_issues_count":156,"forks":895,"open_issues":156,"watchers":3040,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/1101"},"html":{"href":"https://github.com/quantopian/zipline/pull/1101"},"issue":{"href":"https://api.github.com/repos/quantopian/zipline/issues/1101"},"comments":{"href":"https://api.github.com/repos/quantopian/zipline/issues/1101/comments"},"review_comments":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/1101/comments"},"review_comment":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quantopian/zipline/pulls/1101/commits"},"statuses":{"href":"https://api.github.com/repos/quantopian/zipline/statuses/e64cf5d6efe2ed6eb2f0642bf58b537ddeed9626"}}}}