{"action":"created","issue":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3456","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3456/labels{/name}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3456/comments","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3456/events","html_url":"https://github.com/dolphin-emu/dolphin/pull/3456","id":125164522,"number":3456,"title":"HiresTextures: Also look for directories with 3-character IDs","user":{"login":"JosJuice","id":6716818,"avatar_url":"https://avatars.githubusercontent.com/u/6716818?v=3","gravatar_id":"","url":"https://api.github.com/users/JosJuice","html_url":"https://github.com/JosJuice","followers_url":"https://api.github.com/users/JosJuice/followers","following_url":"https://api.github.com/users/JosJuice/following{/other_user}","gists_url":"https://api.github.com/users/JosJuice/gists{/gist_id}","starred_url":"https://api.github.com/users/JosJuice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosJuice/subscriptions","organizations_url":"https://api.github.com/users/JosJuice/orgs","repos_url":"https://api.github.com/users/JosJuice/repos","events_url":"https://api.github.com/users/JosJuice/events{/privacy}","received_events_url":"https://api.github.com/users/JosJuice/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-06T12:02:55Z","updated_at":"2016-01-06T12:58:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3456","html_url":"https://github.com/dolphin-emu/dolphin/pull/3456","diff_url":"https://github.com/dolphin-emu/dolphin/pull/3456.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/3456.patch"},"body":"People who make texture packs usually release them using a specific ID (for instance SX4E01). Users who have a different version of the game (like the PAL version SX4P01) then need to rename the custom texture folder to match. This is a lot simpler than renaming every texture file, as was required with the old texture format, but it's still something that users can forget to do. To make that unnecessary, this change makes it possible to use three-character region-free IDs for custom texture folders, similarly to how game INIs can use three-character IDs. Once most people have updated to Dolphin versions that include this change (hopefully 5.0!), those who make texture packs will be able to name them with three-character IDs, removing the need for users to rename anything."},"comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/169318076","html_url":"https://github.com/dolphin-emu/dolphin/pull/3456#issuecomment-169318076","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3456","id":169318076,"user":{"login":"JosJuice","id":6716818,"avatar_url":"https://avatars.githubusercontent.com/u/6716818?v=3","gravatar_id":"","url":"https://api.github.com/users/JosJuice","html_url":"https://github.com/JosJuice","followers_url":"https://api.github.com/users/JosJuice/followers","following_url":"https://api.github.com/users/JosJuice/following{/other_user}","gists_url":"https://api.github.com/users/JosJuice/gists{/gist_id}","starred_url":"https://api.github.com/users/JosJuice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosJuice/subscriptions","organizations_url":"https://api.github.com/users/JosJuice/orgs","repos_url":"https://api.github.com/users/JosJuice/repos","events_url":"https://api.github.com/users/JosJuice/events{/privacy}","received_events_url":"https://api.github.com/users/JosJuice/received_events","type":"User","site_admin":false},"created_at":"2016-01-06T12:58:47Z","updated_at":"2016-01-06T12:58:47Z","body":"I don't really see an advantage in putting textures that only are in specific versions in a separate folder. Textures that aren't used by the user's version of the game won't cause any problems (unless there's a hash collision, but that's rare, and the same problem applies to all other textures), and they are usually few enough that they won't have a noticeable impact on prefetching. Also, it would be more complicated to implement :P\r\n\r\nOn the other hand, not using the three-character folder at all when there's a longer one could be useful for Triforce games and unlicensed games that share their first three characters with licensed GC/Wii software that have a three-character texture folder. (Though this probably won't be much of a problem in reality, considering that there currently aren't any Triforce texture packs and most ID collisions are between very similar games like F-Zero GX and F-Zero AX...)"}}