{"action":"created","comment":{"url":"https://api.github.com/repos/nteract/hydrogen/pulls/comments/88091404","pull_request_review_id":8675369,"id":88091404,"diff_hunk":"@@ -1,262 +1,326 @@\n-_ = require 'lodash'\n-child_process = require 'child_process'\n-{launchSpec} = require 'spawnteract'\n-fs = require 'fs'\n-path = require 'path'\n+import _ from 'lodash';\n+import child_process from 'child_process';\n+import { launchSpec } from 'spawnteract';\n+import fs from 'fs';\n+import path from 'path';\n \n-Config = require './config'\n-WSKernel = require './ws-kernel'\n-ZMQKernel = require './zmq-kernel'\n-KernelPicker = require './kernel-picker'\n+import Config from './config';\n+import WSKernel from './ws-kernel';\n+import ZMQKernel from './zmq-kernel';\n+import KernelPicker from './kernel-picker';\n \n-module.exports =\n-class KernelManager\n-    constructor: ->\n-        @_runningKernels = {}\n-        @_kernelSpecs = @getKernelSpecsFromSettings()\n+export default class KernelManager {\n+    constructor() {\n+        this.getAllKernelSpecs = this.getAllKernelSpecs.bind(this);","path":"lib/kernel-manager.js","position":null,"original_position":28,"commit_id":"156c23a37015ce440f8356931c0fe337bd30db1b","original_commit_id":"c98faa472f05bb8c99afdeda35aebd4030c62210","user":{"login":"lgeiger","id":13285808,"avatar_url":"https://avatars.githubusercontent.com/u/13285808?v=3","gravatar_id":"","url":"https://api.github.com/users/lgeiger","html_url":"https://github.com/lgeiger","followers_url":"https://api.github.com/users/lgeiger/followers","following_url":"https://api.github.com/users/lgeiger/following{/other_user}","gists_url":"https://api.github.com/users/lgeiger/gists{/gist_id}","starred_url":"https://api.github.com/users/lgeiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgeiger/subscriptions","organizations_url":"https://api.github.com/users/lgeiger/orgs","repos_url":"https://api.github.com/users/lgeiger/repos","events_url":"https://api.github.com/users/lgeiger/events{/privacy}","received_events_url":"https://api.github.com/users/lgeiger/received_events","type":"User","site_admin":false},"body":"Hmm I actually have no idea.","created_at":"2016-11-15T19:16:37Z","updated_at":"2016-11-15T19:16:37Z","html_url":"https://github.com/nteract/hydrogen/pull/503#discussion_r88091404","pull_request_url":"https://api.github.com/repos/nteract/hydrogen/pulls/503","_links":{"self":{"href":"https://api.github.com/repos/nteract/hydrogen/pulls/comments/88091404"},"html":{"href":"https://github.com/nteract/hydrogen/pull/503#discussion_r88091404"},"pull_request":{"href":"https://api.github.com/repos/nteract/hydrogen/pulls/503"}}},"pull_request":{"url":"https://api.github.com/repos/nteract/hydrogen/pulls/503","id":93688949,"html_url":"https://github.com/nteract/hydrogen/pull/503","diff_url":"https://github.com/nteract/hydrogen/pull/503.diff","patch_url":"https://github.com/nteract/hydrogen/pull/503.patch","issue_url":"https://api.github.com/repos/nteract/hydrogen/issues/503","number":503,"state":"open","locked":false,"title":"[WIP] Move to ES6","user":{"login":"lgeiger","id":13285808,"avatar_url":"https://avatars.githubusercontent.com/u/13285808?v=3","gravatar_id":"","url":"https://api.github.com/users/lgeiger","html_url":"https://github.com/lgeiger","followers_url":"https://api.github.com/users/lgeiger/followers","following_url":"https://api.github.com/users/lgeiger/following{/other_user}","gists_url":"https://api.github.com/users/lgeiger/gists{/gist_id}","starred_url":"https://api.github.com/users/lgeiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgeiger/subscriptions","organizations_url":"https://api.github.com/users/lgeiger/orgs","repos_url":"https://api.github.com/users/lgeiger/repos","events_url":"https://api.github.com/users/lgeiger/events{/privacy}","received_events_url":"https://api.github.com/users/lgeiger/received_events","type":"User","site_admin":false},"body":"Fixes #494\r\n\r\nThis will port all coffeescript code to ES6. There will be probably a few bugs since I didn't test all functionality. ","created_at":"2016-11-15T02:21:54Z","updated_at":"2016-11-15T19:16:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27e9d2e856f9f9502bc1a8aab03a379f6225f19b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nteract/hydrogen/pulls/503/commits","review_comments_url":"https://api.github.com/repos/nteract/hydrogen/pulls/503/comments","review_comment_url":"https://api.github.com/repos/nteract/hydrogen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nteract/hydrogen/issues/503/comments","statuses_url":"https://api.github.com/repos/nteract/hydrogen/statuses/156c23a37015ce440f8356931c0fe337bd30db1b","head":{"label":"lgeiger:js","ref":"js","sha":"156c23a37015ce440f8356931c0fe337bd30db1b","user":{"login":"lgeiger","id":13285808,"avatar_url":"https://avatars.githubusercontent.com/u/13285808?v=3","gravatar_id":"","url":"https://api.github.com/users/lgeiger","html_url":"https://github.com/lgeiger","followers_url":"https://api.github.com/users/lgeiger/followers","following_url":"https://api.github.com/users/lgeiger/following{/other_user}","gists_url":"https://api.github.com/users/lgeiger/gists{/gist_id}","starred_url":"https://api.github.com/users/lgeiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgeiger/subscriptions","organizations_url":"https://api.github.com/users/lgeiger/orgs","repos_url":"https://api.github.com/users/lgeiger/repos","events_url":"https://api.github.com/users/lgeiger/events{/privacy}","received_events_url":"https://api.github.com/users/lgeiger/received_events","type":"User","site_admin":false},"repo":{"id":51795580,"name":"hydrogen","full_name":"lgeiger/hydrogen","owner":{"login":"lgeiger","id":13285808,"avatar_url":"https://avatars.githubusercontent.com/u/13285808?v=3","gravatar_id":"","url":"https://api.github.com/users/lgeiger","html_url":"https://github.com/lgeiger","followers_url":"https://api.github.com/users/lgeiger/followers","following_url":"https://api.github.com/users/lgeiger/following{/other_user}","gists_url":"https://api.github.com/users/lgeiger/gists{/gist_id}","starred_url":"https://api.github.com/users/lgeiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgeiger/subscriptions","organizations_url":"https://api.github.com/users/lgeiger/orgs","repos_url":"https://api.github.com/users/lgeiger/repos","events_url":"https://api.github.com/users/lgeiger/events{/privacy}","received_events_url":"https://api.github.com/users/lgeiger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lgeiger/hydrogen","description":":hash: Run code inline in Atom using Jupyter kernels","fork":true,"url":"https://api.github.com/repos/lgeiger/hydrogen","forks_url":"https://api.github.com/repos/lgeiger/hydrogen/forks","keys_url":"https://api.github.com/repos/lgeiger/hydrogen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lgeiger/hydrogen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lgeiger/hydrogen/teams","hooks_url":"https://api.github.com/repos/lgeiger/hydrogen/hooks","issue_events_url":"https://api.github.com/repos/lgeiger/hydrogen/issues/events{/number}","events_url":"https://api.github.com/repos/lgeiger/hydrogen/events","assignees_url":"https://api.github.com/repos/lgeiger/hydrogen/assignees{/user}","branches_url":"https://api.github.com/repos/lgeiger/hydrogen/branches{/branch}","tags_url":"https://api.github.com/repos/lgeiger/hydrogen/tags","blobs_url":"https://api.github.com/repos/lgeiger/hydrogen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lgeiger/hydrogen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lgeiger/hydrogen/git/refs{/sha}","trees_url":"https://api.github.com/repos/lgeiger/hydrogen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lgeiger/hydrogen/statuses/{sha}","languages_url":"https://api.github.com/repos/lgeiger/hydrogen/languages","stargazers_url":"https://api.github.com/repos/lgeiger/hydrogen/stargazers","contributors_url":"https://api.github.com/repos/lgeiger/hydrogen/contributors","subscribers_url":"https://api.github.com/repos/lgeiger/hydrogen/subscribers","subscription_url":"https://api.github.com/repos/lgeiger/hydrogen/subscription","commits_url":"https://api.github.com/repos/lgeiger/hydrogen/commits{/sha}","git_commits_url":"https://api.github.com/repos/lgeiger/hydrogen/git/commits{/sha}","comments_url":"https://api.github.com/repos/lgeiger/hydrogen/comments{/number}","issue_comment_url":"https://api.github.com/repos/lgeiger/hydrogen/issues/comments{/number}","contents_url":"https://api.github.com/repos/lgeiger/hydrogen/contents/{+path}","compare_url":"https://api.github.com/repos/lgeiger/hydrogen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lgeiger/hydrogen/merges","archive_url":"https://api.github.com/repos/lgeiger/hydrogen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lgeiger/hydrogen/downloads","issues_url":"https://api.github.com/repos/lgeiger/hydrogen/issues{/number}","pulls_url":"https://api.github.com/repos/lgeiger/hydrogen/pulls{/number}","milestones_url":"https://api.github.com/repos/lgeiger/hydrogen/milestones{/number}","notifications_url":"https://api.github.com/repos/lgeiger/hydrogen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lgeiger/hydrogen/labels{/name}","releases_url":"https://api.github.com/repos/lgeiger/hydrogen/releases{/id}","deployments_url":"https://api.github.com/repos/lgeiger/hydrogen/deployments","created_at":"2016-02-16T00:20:28Z","updated_at":"2016-02-16T00:20:29Z","pushed_at":"2016-11-15T18:52:01Z","git_url":"git://github.com/lgeiger/hydrogen.git","ssh_url":"git@github.com:lgeiger/hydrogen.git","clone_url":"https://github.com/lgeiger/hydrogen.git","svn_url":"https://github.com/lgeiger/hydrogen","homepage":"https://atom.io/packages/hydrogen","size":671,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nteract:master","ref":"master","sha":"df670c0c2bdeb957b370adaf4f69540dcffd8899","user":{"login":"nteract","id":12401040,"avatar_url":"https://avatars.githubusercontent.com/u/12401040?v=3","gravatar_id":"","url":"https://api.github.com/users/nteract","html_url":"https://github.com/nteract","followers_url":"https://api.github.com/users/nteract/followers","following_url":"https://api.github.com/users/nteract/following{/other_user}","gists_url":"https://api.github.com/users/nteract/gists{/gist_id}","starred_url":"https://api.github.com/users/nteract/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nteract/subscriptions","organizations_url":"https://api.github.com/users/nteract/orgs","repos_url":"https://api.github.com/users/nteract/repos","events_url":"https://api.github.com/users/nteract/events{/privacy}","received_events_url":"https://api.github.com/users/nteract/received_events","type":"Organization","site_admin":false},"repo":{"id":35395056,"name":"hydrogen","full_name":"nteract/hydrogen","owner":{"login":"nteract","id":12401040,"avatar_url":"https://avatars.githubusercontent.com/u/12401040?v=3","gravatar_id":"","url":"https://api.github.com/users/nteract","html_url":"https://github.com/nteract","followers_url":"https://api.github.com/users/nteract/followers","following_url":"https://api.github.com/users/nteract/following{/other_user}","gists_url":"https://api.github.com/users/nteract/gists{/gist_id}","starred_url":"https://api.github.com/users/nteract/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nteract/subscriptions","organizations_url":"https://api.github.com/users/nteract/orgs","repos_url":"https://api.github.com/users/nteract/repos","events_url":"https://api.github.com/users/nteract/events{/privacy}","received_events_url":"https://api.github.com/users/nteract/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nteract/hydrogen","description":":eight_spoked_asterisk: Run code inline in Atom using Jupyter kernels","fork":false,"url":"https://api.github.com/repos/nteract/hydrogen","forks_url":"https://api.github.com/repos/nteract/hydrogen/forks","keys_url":"https://api.github.com/repos/nteract/hydrogen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nteract/hydrogen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nteract/hydrogen/teams","hooks_url":"https://api.github.com/repos/nteract/hydrogen/hooks","issue_events_url":"https://api.github.com/repos/nteract/hydrogen/issues/events{/number}","events_url":"https://api.github.com/repos/nteract/hydrogen/events","assignees_url":"https://api.github.com/repos/nteract/hydrogen/assignees{/user}","branches_url":"https://api.github.com/repos/nteract/hydrogen/branches{/branch}","tags_url":"https://api.github.com/repos/nteract/hydrogen/tags","blobs_url":"https://api.github.com/repos/nteract/hydrogen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nteract/hydrogen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nteract/hydrogen/git/refs{/sha}","trees_url":"https://api.github.com/repos/nteract/hydrogen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nteract/hydrogen/statuses/{sha}","languages_url":"https://api.github.com/repos/nteract/hydrogen/languages","stargazers_url":"https://api.github.com/repos/nteract/hydrogen/stargazers","contributors_url":"https://api.github.com/repos/nteract/hydrogen/contributors","subscribers_url":"https://api.github.com/repos/nteract/hydrogen/subscribers","subscription_url":"https://api.github.com/repos/nteract/hydrogen/subscription","commits_url":"https://api.github.com/repos/nteract/hydrogen/commits{/sha}","git_commits_url":"https://api.github.com/repos/nteract/hydrogen/git/commits{/sha}","comments_url":"https://api.github.com/repos/nteract/hydrogen/comments{/number}","issue_comment_url":"https://api.github.com/repos/nteract/hydrogen/issues/comments{/number}","contents_url":"https://api.github.com/repos/nteract/hydrogen/contents/{+path}","compare_url":"https://api.github.com/repos/nteract/hydrogen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nteract/hydrogen/merges","archive_url":"https://api.github.com/repos/nteract/hydrogen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nteract/hydrogen/downloads","issues_url":"https://api.github.com/repos/nteract/hydrogen/issues{/number}","pulls_url":"https://api.github.com/repos/nteract/hydrogen/pulls{/number}","milestones_url":"https://api.github.com/repos/nteract/hydrogen/milestones{/number}","notifications_url":"https://api.github.com/repos/nteract/hydrogen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nteract/hydrogen/labels{/name}","releases_url":"https://api.github.com/repos/nteract/hydrogen/releases{/id}","deployments_url":"https://api.github.com/repos/nteract/hydrogen/deployments","created_at":"2015-05-11T01:16:55Z","updated_at":"2016-11-14T18:55:07Z","pushed_at":"2016-11-15T18:52:01Z","git_url":"git://github.com/nteract/hydrogen.git","ssh_url":"git@github.com:nteract/hydrogen.git","clone_url":"https://github.com/nteract/hydrogen.git","svn_url":"https://github.com/nteract/hydrogen","homepage":"https://atom.io/packages/hydrogen","size":732,"stargazers_count":1723,"watchers_count":1723,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":38,"forks":51,"open_issues":38,"watchers":1723,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nteract/hydrogen/pulls/503"},"html":{"href":"https://github.com/nteract/hydrogen/pull/503"},"issue":{"href":"https://api.github.com/repos/nteract/hydrogen/issues/503"},"comments":{"href":"https://api.github.com/repos/nteract/hydrogen/issues/503/comments"},"review_comments":{"href":"https://api.github.com/repos/nteract/hydrogen/pulls/503/comments"},"review_comment":{"href":"https://api.github.com/repos/nteract/hydrogen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nteract/hydrogen/pulls/503/commits"},"statuses":{"href":"https://api.github.com/repos/nteract/hydrogen/statuses/156c23a37015ce440f8356931c0fe337bd30db1b"}}}}
{"actor":{"display_login":"lgeiger"}}