{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17285","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17285/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17285/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17285/events","html_url":"https://github.com/NixOS/nixpkgs/pull/17285","id":167710265,"number":17285,"title":"Revert \"phpfpm service: restructured pool configuration\"","user":{"login":"bjornfor","id":133602,"avatar_url":"https://avatars.githubusercontent.com/u/133602?v=3","gravatar_id":"","url":"https://api.github.com/users/bjornfor","html_url":"https://github.com/bjornfor","followers_url":"https://api.github.com/users/bjornfor/followers","following_url":"https://api.github.com/users/bjornfor/following{/other_user}","gists_url":"https://api.github.com/users/bjornfor/gists{/gist_id}","starred_url":"https://api.github.com/users/bjornfor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjornfor/subscriptions","organizations_url":"https://api.github.com/users/bjornfor/orgs","repos_url":"https://api.github.com/users/bjornfor/repos","events_url":"https://api.github.com/users/bjornfor/events{/privacy}","received_events_url":"https://api.github.com/users/bjornfor/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20nixos","name":"6.topic: nixos","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-07-26T20:58:51Z","updated_at":"2016-07-27T21:47:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/17285","html_url":"https://github.com/NixOS/nixpkgs/pull/17285","diff_url":"https://github.com/NixOS/nixpkgs/pull/17285.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/17285.patch"},"body":"###### Motivation for this change\r\nThis reverts commit 6b3f5b5a421fe3422e9ef63a3fd690178c36163e because it\r\nintroduced a non-backwards compatible change in the phpfpm interface,\r\nwithout explaining why it's needed and/or better than what we have. I\r\nfeel reworking the interface needs more discussion, so in the mean time\r\nlet's keep the old interface.\r\n\r\nCommit 98e419c0e27dd21e9dee0b915876ea60 (\"tt-rss service: init at 16.3\")\r\ndepends on the new interface, so this commit updates the tt-rss service\r\nto work with the services.phpfpm.poolConfigs interface.\r\n\r\n###### Things done\r\n\r\n- [ ] Tested using sandboxing\r\n  ([nix.useChroot](http://nixos.org/nixos/manual/options.html#opt-nix.useChroot) on NixOS,\r\n    or option `build-use-chroot` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [ ] OS X\r\n   - [ ] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/235731655","html_url":"https://github.com/NixOS/nixpkgs/pull/17285#issuecomment-235731655","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17285","id":235731655,"user":{"login":"bjornfor","id":133602,"avatar_url":"https://avatars.githubusercontent.com/u/133602?v=3","gravatar_id":"","url":"https://api.github.com/users/bjornfor","html_url":"https://github.com/bjornfor","followers_url":"https://api.github.com/users/bjornfor/followers","following_url":"https://api.github.com/users/bjornfor/following{/other_user}","gists_url":"https://api.github.com/users/bjornfor/gists{/gist_id}","starred_url":"https://api.github.com/users/bjornfor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjornfor/subscriptions","organizations_url":"https://api.github.com/users/bjornfor/orgs","repos_url":"https://api.github.com/users/bjornfor/repos","events_url":"https://api.github.com/users/bjornfor/events{/privacy}","received_events_url":"https://api.github.com/users/bjornfor/received_events","type":"User","site_admin":false},"created_at":"2016-07-27T21:47:07Z","updated_at":"2016-07-27T21:47:07Z","body":"@zohl:\r\n\r\n> No, tt-rss should work normally unless the one will try to specify a non-standard phpfpm pool. But this is an exotic case, so let's ignore it for now.\r\n\r\nTo be nitpicky, you don't _have_ to change the phpfpm interface for that use case either (as shown in this PR), but I can understand its appeal. :-)\r\n\r\n> I guess it becomes a common pattern in nixpkgs, when the core parameters of a service are declared as options and the rest ones are specified in extraConfig or similar text variable.\r\n\r\nTrue. But several services also have the ```configText``` option which overrides the generated config from the other NixOS options. I like having both interfaces, because sometimes the structured options are incomplete.\r\n\r\nAnyway, I'll merge this then.\r\n"}}
{"actor":{"display_login":"bjornfor"}}