{"action":"created","issue":{"url":"https://api.github.com/repos/toranb/ember-redux/issues/63","repository_url":"https://api.github.com/repos/toranb/ember-redux","labels_url":"https://api.github.com/repos/toranb/ember-redux/issues/63/labels{/name}","comments_url":"https://api.github.com/repos/toranb/ember-redux/issues/63/comments","events_url":"https://api.github.com/repos/toranb/ember-redux/issues/63/events","html_url":"https://github.com/toranb/ember-redux/pull/63","id":195107728,"number":63,"title":"Use Ember shims for redux packages instead of ember-browserify","user":{"login":"sandersky","id":422902,"avatar_url":"https://avatars.githubusercontent.com/u/422902?v=3","gravatar_id":"","url":"https://api.github.com/users/sandersky","html_url":"https://github.com/sandersky","followers_url":"https://api.github.com/users/sandersky/followers","following_url":"https://api.github.com/users/sandersky/following{/other_user}","gists_url":"https://api.github.com/users/sandersky/gists{/gist_id}","starred_url":"https://api.github.com/users/sandersky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandersky/subscriptions","organizations_url":"https://api.github.com/users/sandersky/orgs","repos_url":"https://api.github.com/users/sandersky/repos","events_url":"https://api.github.com/users/sandersky/events{/privacy}","received_events_url":"https://api.github.com/users/sandersky/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-12-12T22:43:26Z","updated_at":"2016-12-14T03:49:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/toranb/ember-redux/pulls/63","html_url":"https://github.com/toranb/ember-redux/pull/63","diff_url":"https://github.com/toranb/ember-redux/pull/63.diff","patch_url":"https://github.com/toranb/ember-redux/pull/63.patch"},"body":"In an effort to remove the dependency of `ember-browserify` I've created three new shims for packages previously being included via `ember-browserify`:\r\n\r\n* [ember-redux-shim](https://github.com/ciena-blueplanet/ember-redux-shim)\r\n* [ember-redux-thunk](https://github.com/ciena-blueplanet/ember-redux-thunk)\r\n* [ember-redux-saga](https://github.com/ciena-blueplanet/ember-redux-saga)\r\n\r\nThis pull request is an alternative approach to what has been done in #57 "},"comment":{"url":"https://api.github.com/repos/toranb/ember-redux/issues/comments/266935486","html_url":"https://github.com/toranb/ember-redux/pull/63#issuecomment-266935486","issue_url":"https://api.github.com/repos/toranb/ember-redux/issues/63","id":266935486,"user":{"login":"MiguelMadero","id":47388,"avatar_url":"https://avatars.githubusercontent.com/u/47388?v=3","gravatar_id":"","url":"https://api.github.com/users/MiguelMadero","html_url":"https://github.com/MiguelMadero","followers_url":"https://api.github.com/users/MiguelMadero/followers","following_url":"https://api.github.com/users/MiguelMadero/following{/other_user}","gists_url":"https://api.github.com/users/MiguelMadero/gists{/gist_id}","starred_url":"https://api.github.com/users/MiguelMadero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiguelMadero/subscriptions","organizations_url":"https://api.github.com/users/MiguelMadero/orgs","repos_url":"https://api.github.com/users/MiguelMadero/repos","events_url":"https://api.github.com/users/MiguelMadero/events{/privacy}","received_events_url":"https://api.github.com/users/MiguelMadero/received_events","type":"User","site_admin":false},"created_at":"2016-12-14T03:49:48Z","updated_at":"2016-12-14T03:49:48Z","body":"When you asked about concerns with both approaches   bus factor was the main one I could think of for shims. \r\n\r\nThe shims seem well done and straight forward, @sandersky did a great job and I like the CI setup and deployment. If we can increase the bus factor Im :thumbsups: for this approach. \r\n\r\nIm afk, but would like to look at the compiled payload. Im not expecting surprises, but still would like to look at it. \r\n\r\nAnother smaller advantage here is that once/if we have tree-shaking in cli, it would just work here. If we imported and amd \"prebuilt\" package we would have to switch to src for tree shaking to work. "}}
{"actor":{"display_login":"MiguelMadero"}}