{"action":"created","comment":{"url":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments/71081182","id":71081182,"diff_hunk":"@@ -2181,11 +2168,8 @@ class ToElemVisitor : public Visitor {\n     llvm::BranchInst::Create(condend, p->scopebb());\n \n     p->scope() = IRScope(condend);\n-    if (retPtr) {\n+    if (retPtr)\n       result = new DSpecialRefValue(e->type, retPtr);\n-    } else {\n-      result = new DConstValue(e->type, getNullValue(DtoMemType(dtype)));\n-    }","path":"gen/toir.cpp","position":612,"original_position":184,"commit_id":"d6dcc7a4db5e931e6584f7b7fb3201c99b4a8266","original_commit_id":"d6dcc7a4db5e931e6584f7b7fb3201c99b4a8266","user":{"login":"kinke","id":1889215,"avatar_url":"https://avatars.githubusercontent.com/u/1889215?v=3","gravatar_id":"","url":"https://api.github.com/users/kinke","html_url":"https://github.com/kinke","followers_url":"https://api.github.com/users/kinke/followers","following_url":"https://api.github.com/users/kinke/following{/other_user}","gists_url":"https://api.github.com/users/kinke/gists{/gist_id}","starred_url":"https://api.github.com/users/kinke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinke/subscriptions","organizations_url":"https://api.github.com/users/kinke/orgs","repos_url":"https://api.github.com/users/kinke/repos","events_url":"https://api.github.com/users/kinke/events{/privacy}","received_events_url":"https://api.github.com/users/kinke/received_events","type":"User","site_admin":false},"body":"No more dummy value if `CondExp::type` is void.","created_at":"2016-07-17T11:54:28Z","updated_at":"2016-07-17T11:54:28Z","html_url":"https://github.com/ldc-developers/ldc/pull/1623#discussion_r71081182","pull_request_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/1623","_links":{"self":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments/71081182"},"html":{"href":"https://github.com/ldc-developers/ldc/pull/1623#discussion_r71081182"},"pull_request":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/1623"}}},"pull_request":{"url":"https://api.github.com/repos/ldc-developers/ldc/pulls/1623","id":77709721,"html_url":"https://github.com/ldc-developers/ldc/pull/1623","diff_url":"https://github.com/ldc-developers/ldc/pull/1623.diff","patch_url":"https://github.com/ldc-developers/ldc/pull/1623.patch","issue_url":"https://api.github.com/repos/ldc-developers/ldc/issues/1623","number":1623,"state":"open","locked":false,"title":"Fix evaluation order issues (continuation of #1620)","user":{"login":"kinke","id":1889215,"avatar_url":"https://avatars.githubusercontent.com/u/1889215?v=3","gravatar_id":"","url":"https://api.github.com/users/kinke","html_url":"https://github.com/kinke","followers_url":"https://api.github.com/users/kinke/followers","following_url":"https://api.github.com/users/kinke/following{/other_user}","gists_url":"https://api.github.com/users/kinke/gists{/gist_id}","starred_url":"https://api.github.com/users/kinke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinke/subscriptions","organizations_url":"https://api.github.com/users/kinke/orgs","repos_url":"https://api.github.com/users/kinke/repos","events_url":"https://api.github.com/users/kinke/events{/privacy}","received_events_url":"https://api.github.com/users/kinke/received_events","type":"User","site_admin":false},"body":"Refactorings only for now.","created_at":"2016-07-16T13:37:56Z","updated_at":"2016-07-17T11:54:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2baa9e3e672bb47a7d8cddeafe711215d4c9b290","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/1623/commits","review_comments_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/1623/comments","review_comment_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ldc-developers/ldc/issues/1623/comments","statuses_url":"https://api.github.com/repos/ldc-developers/ldc/statuses/d6dcc7a4db5e931e6584f7b7fb3201c99b4a8266","head":{"label":"kinke:evalorder","ref":"evalorder","sha":"d6dcc7a4db5e931e6584f7b7fb3201c99b4a8266","user":{"login":"kinke","id":1889215,"avatar_url":"https://avatars.githubusercontent.com/u/1889215?v=3","gravatar_id":"","url":"https://api.github.com/users/kinke","html_url":"https://github.com/kinke","followers_url":"https://api.github.com/users/kinke/followers","following_url":"https://api.github.com/users/kinke/following{/other_user}","gists_url":"https://api.github.com/users/kinke/gists{/gist_id}","starred_url":"https://api.github.com/users/kinke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinke/subscriptions","organizations_url":"https://api.github.com/users/kinke/orgs","repos_url":"https://api.github.com/users/kinke/repos","events_url":"https://api.github.com/users/kinke/events{/privacy}","received_events_url":"https://api.github.com/users/kinke/received_events","type":"User","site_admin":false},"repo":{"id":7853031,"name":"ldc","full_name":"kinke/ldc","owner":{"login":"kinke","id":1889215,"avatar_url":"https://avatars.githubusercontent.com/u/1889215?v=3","gravatar_id":"","url":"https://api.github.com/users/kinke","html_url":"https://github.com/kinke","followers_url":"https://api.github.com/users/kinke/followers","following_url":"https://api.github.com/users/kinke/following{/other_user}","gists_url":"https://api.github.com/users/kinke/gists{/gist_id}","starred_url":"https://api.github.com/users/kinke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinke/subscriptions","organizations_url":"https://api.github.com/users/kinke/orgs","repos_url":"https://api.github.com/users/kinke/repos","events_url":"https://api.github.com/users/kinke/events{/privacy}","received_events_url":"https://api.github.com/users/kinke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kinke/ldc","description":"The LLVM D compiler.","fork":true,"url":"https://api.github.com/repos/kinke/ldc","forks_url":"https://api.github.com/repos/kinke/ldc/forks","keys_url":"https://api.github.com/repos/kinke/ldc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kinke/ldc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kinke/ldc/teams","hooks_url":"https://api.github.com/repos/kinke/ldc/hooks","issue_events_url":"https://api.github.com/repos/kinke/ldc/issues/events{/number}","events_url":"https://api.github.com/repos/kinke/ldc/events","assignees_url":"https://api.github.com/repos/kinke/ldc/assignees{/user}","branches_url":"https://api.github.com/repos/kinke/ldc/branches{/branch}","tags_url":"https://api.github.com/repos/kinke/ldc/tags","blobs_url":"https://api.github.com/repos/kinke/ldc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kinke/ldc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kinke/ldc/git/refs{/sha}","trees_url":"https://api.github.com/repos/kinke/ldc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kinke/ldc/statuses/{sha}","languages_url":"https://api.github.com/repos/kinke/ldc/languages","stargazers_url":"https://api.github.com/repos/kinke/ldc/stargazers","contributors_url":"https://api.github.com/repos/kinke/ldc/contributors","subscribers_url":"https://api.github.com/repos/kinke/ldc/subscribers","subscription_url":"https://api.github.com/repos/kinke/ldc/subscription","commits_url":"https://api.github.com/repos/kinke/ldc/commits{/sha}","git_commits_url":"https://api.github.com/repos/kinke/ldc/git/commits{/sha}","comments_url":"https://api.github.com/repos/kinke/ldc/comments{/number}","issue_comment_url":"https://api.github.com/repos/kinke/ldc/issues/comments{/number}","contents_url":"https://api.github.com/repos/kinke/ldc/contents/{+path}","compare_url":"https://api.github.com/repos/kinke/ldc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kinke/ldc/merges","archive_url":"https://api.github.com/repos/kinke/ldc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kinke/ldc/downloads","issues_url":"https://api.github.com/repos/kinke/ldc/issues{/number}","pulls_url":"https://api.github.com/repos/kinke/ldc/pulls{/number}","milestones_url":"https://api.github.com/repos/kinke/ldc/milestones{/number}","notifications_url":"https://api.github.com/repos/kinke/ldc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kinke/ldc/labels{/name}","releases_url":"https://api.github.com/repos/kinke/ldc/releases{/id}","deployments_url":"https://api.github.com/repos/kinke/ldc/deployments","created_at":"2013-01-27T14:20:48Z","updated_at":"2015-08-08T16:02:35Z","pushed_at":"2016-07-17T04:23:12Z","git_url":"git://github.com/kinke/ldc.git","ssh_url":"git@github.com:kinke/ldc.git","clone_url":"https://github.com/kinke/ldc.git","svn_url":"https://github.com/kinke/ldc","homepage":"http://wiki.dlang.org/LDC","size":25105,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"win64"}},"base":{"label":"ldc-developers:master","ref":"master","sha":"cec61a4432190b08d7c620213f844cc482ba4ee8","user":{"login":"ldc-developers","id":960112,"avatar_url":"https://avatars.githubusercontent.com/u/960112?v=3","gravatar_id":"","url":"https://api.github.com/users/ldc-developers","html_url":"https://github.com/ldc-developers","followers_url":"https://api.github.com/users/ldc-developers/followers","following_url":"https://api.github.com/users/ldc-developers/following{/other_user}","gists_url":"https://api.github.com/users/ldc-developers/gists{/gist_id}","starred_url":"https://api.github.com/users/ldc-developers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldc-developers/subscriptions","organizations_url":"https://api.github.com/users/ldc-developers/orgs","repos_url":"https://api.github.com/users/ldc-developers/repos","events_url":"https://api.github.com/users/ldc-developers/events{/privacy}","received_events_url":"https://api.github.com/users/ldc-developers/received_events","type":"Organization","site_admin":false},"repo":{"id":2174666,"name":"ldc","full_name":"ldc-developers/ldc","owner":{"login":"ldc-developers","id":960112,"avatar_url":"https://avatars.githubusercontent.com/u/960112?v=3","gravatar_id":"","url":"https://api.github.com/users/ldc-developers","html_url":"https://github.com/ldc-developers","followers_url":"https://api.github.com/users/ldc-developers/followers","following_url":"https://api.github.com/users/ldc-developers/following{/other_user}","gists_url":"https://api.github.com/users/ldc-developers/gists{/gist_id}","starred_url":"https://api.github.com/users/ldc-developers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldc-developers/subscriptions","organizations_url":"https://api.github.com/users/ldc-developers/orgs","repos_url":"https://api.github.com/users/ldc-developers/repos","events_url":"https://api.github.com/users/ldc-developers/events{/privacy}","received_events_url":"https://api.github.com/users/ldc-developers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ldc-developers/ldc","description":"The LLVM-based D compiler.","fork":false,"url":"https://api.github.com/repos/ldc-developers/ldc","forks_url":"https://api.github.com/repos/ldc-developers/ldc/forks","keys_url":"https://api.github.com/repos/ldc-developers/ldc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ldc-developers/ldc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ldc-developers/ldc/teams","hooks_url":"https://api.github.com/repos/ldc-developers/ldc/hooks","issue_events_url":"https://api.github.com/repos/ldc-developers/ldc/issues/events{/number}","events_url":"https://api.github.com/repos/ldc-developers/ldc/events","assignees_url":"https://api.github.com/repos/ldc-developers/ldc/assignees{/user}","branches_url":"https://api.github.com/repos/ldc-developers/ldc/branches{/branch}","tags_url":"https://api.github.com/repos/ldc-developers/ldc/tags","blobs_url":"https://api.github.com/repos/ldc-developers/ldc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ldc-developers/ldc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ldc-developers/ldc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ldc-developers/ldc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ldc-developers/ldc/statuses/{sha}","languages_url":"https://api.github.com/repos/ldc-developers/ldc/languages","stargazers_url":"https://api.github.com/repos/ldc-developers/ldc/stargazers","contributors_url":"https://api.github.com/repos/ldc-developers/ldc/contributors","subscribers_url":"https://api.github.com/repos/ldc-developers/ldc/subscribers","subscription_url":"https://api.github.com/repos/ldc-developers/ldc/subscription","commits_url":"https://api.github.com/repos/ldc-developers/ldc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ldc-developers/ldc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ldc-developers/ldc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ldc-developers/ldc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ldc-developers/ldc/contents/{+path}","compare_url":"https://api.github.com/repos/ldc-developers/ldc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ldc-developers/ldc/merges","archive_url":"https://api.github.com/repos/ldc-developers/ldc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ldc-developers/ldc/downloads","issues_url":"https://api.github.com/repos/ldc-developers/ldc/issues{/number}","pulls_url":"https://api.github.com/repos/ldc-developers/ldc/pulls{/number}","milestones_url":"https://api.github.com/repos/ldc-developers/ldc/milestones{/number}","notifications_url":"https://api.github.com/repos/ldc-developers/ldc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ldc-developers/ldc/labels{/name}","releases_url":"https://api.github.com/repos/ldc-developers/ldc/releases{/id}","deployments_url":"https://api.github.com/repos/ldc-developers/ldc/deployments","created_at":"2011-08-08T17:10:27Z","updated_at":"2016-07-13T20:40:12Z","pushed_at":"2016-07-17T11:15:10Z","git_url":"git://github.com/ldc-developers/ldc.git","ssh_url":"git@github.com:ldc-developers/ldc.git","clone_url":"https://github.com/ldc-developers/ldc.git","svn_url":"https://github.com/ldc-developers/ldc","homepage":"http://wiki.dlang.org/LDC","size":29049,"stargazers_count":475,"watchers_count":475,"language":"D","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":99,"mirror_url":null,"open_issues_count":181,"forks":99,"open_issues":181,"watchers":475,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/1623"},"html":{"href":"https://github.com/ldc-developers/ldc/pull/1623"},"issue":{"href":"https://api.github.com/repos/ldc-developers/ldc/issues/1623"},"comments":{"href":"https://api.github.com/repos/ldc-developers/ldc/issues/1623/comments"},"review_comments":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/1623/comments"},"review_comment":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/1623/commits"},"statuses":{"href":"https://api.github.com/repos/ldc-developers/ldc/statuses/d6dcc7a4db5e931e6584f7b7fb3201c99b4a8266"}}}}
{"actor":{"display_login":"kinke"}}