{"action":"created","comment":{"url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/pulls/comments/84956420","pull_request_review_id":5701224,"id":84956420,"diff_hunk":"@@ -141,22 +151,28 @@ public function main()\n \t\t\t\t\t'announcement_timestamp'\t=> time(),\n \t\t\t\t));\n \n-\t\t\t\t// Set the board_announcements_status for all normal users\n-\t\t\t\t// to 1 when an announcement is created, or 0 when announcement is empty\n-\t\t\t\t$announcement_status = (!empty($data['announcement_text'])) ? 1 : 0;\n+\t\t\t\t$announcement_text = (!empty($data['announcement_text']));\n+\t\t\t\t$guests_only  = $allowed_users === self::GUESTS;","path":"acp/board_announcements_module.php","position":50,"original_position":50,"commit_id":"bcb92c1b7e112e6922a771f20c23038804607390","original_commit_id":"bcb92c1b7e112e6922a771f20c23038804607390","user":{"login":"michaelcullum","id":211740,"avatar_url":"https://avatars.githubusercontent.com/u/211740?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelcullum","html_url":"https://github.com/michaelcullum","followers_url":"https://api.github.com/users/michaelcullum/followers","following_url":"https://api.github.com/users/michaelcullum/following{/other_user}","gists_url":"https://api.github.com/users/michaelcullum/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelcullum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelcullum/subscriptions","organizations_url":"https://api.github.com/users/michaelcullum/orgs","repos_url":"https://api.github.com/users/michaelcullum/repos","events_url":"https://api.github.com/users/michaelcullum/events{/privacy}","received_events_url":"https://api.github.com/users/michaelcullum/received_events","type":"User","site_admin":false},"body":"The readability of this is hard, can we have brackets or a comment?","created_at":"2016-10-25T17:29:18Z","updated_at":"2016-10-25T17:35:36Z","html_url":"https://github.com/phpbb-extensions/boardannouncements/pull/106#discussion_r84956420","pull_request_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/pulls/106","_links":{"self":{"href":"https://api.github.com/repos/phpbb-extensions/boardannouncements/pulls/comments/84956420"},"html":{"href":"https://github.com/phpbb-extensions/boardannouncements/pull/106#discussion_r84956420"},"pull_request":{"href":"https://api.github.com/repos/phpbb-extensions/boardannouncements/pulls/106"}}},"pull_request":{"url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/pulls/106","id":90536602,"html_url":"https://github.com/phpbb-extensions/boardannouncements/pull/106","diff_url":"https://github.com/phpbb-extensions/boardannouncements/pull/106.diff","patch_url":"https://github.com/phpbb-extensions/boardannouncements/pull/106.patch","issue_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/issues/106","number":106,"state":"open","locked":false,"title":"Add option for guests only","user":{"login":"VSEphpbb","id":303711,"avatar_url":"https://avatars.githubusercontent.com/u/303711?v=3","gravatar_id":"","url":"https://api.github.com/users/VSEphpbb","html_url":"https://github.com/VSEphpbb","followers_url":"https://api.github.com/users/VSEphpbb/followers","following_url":"https://api.github.com/users/VSEphpbb/following{/other_user}","gists_url":"https://api.github.com/users/VSEphpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/VSEphpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VSEphpbb/subscriptions","organizations_url":"https://api.github.com/users/VSEphpbb/orgs","repos_url":"https://api.github.com/users/VSEphpbb/repos","events_url":"https://api.github.com/users/VSEphpbb/events{/privacy}","received_events_url":"https://api.github.com/users/VSEphpbb/received_events","type":"User","site_admin":false},"body":"Not sure how I feel about this one, but here it is.\r\n\r\nReplaced the Allow guests to view option with a pull down to allow: Everyone, Members only or Guests only to view the announcement.\r\n\r\nCloses #105 ","created_at":"2016-10-24T00:42:08Z","updated_at":"2016-10-25T17:35:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0def113681937195fd1bdfded65dc6769bfdc813","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/milestones/6","html_url":"https://github.com/phpbb-extensions/boardannouncements/milestones/Release%201.0.5","labels_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/milestones/6/labels","id":1325785,"number":6,"title":"Release 1.0.5","description":"","creator":{"login":"VSEphpbb","id":303711,"avatar_url":"https://avatars.githubusercontent.com/u/303711?v=3","gravatar_id":"","url":"https://api.github.com/users/VSEphpbb","html_url":"https://github.com/VSEphpbb","followers_url":"https://api.github.com/users/VSEphpbb/followers","following_url":"https://api.github.com/users/VSEphpbb/following{/other_user}","gists_url":"https://api.github.com/users/VSEphpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/VSEphpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VSEphpbb/subscriptions","organizations_url":"https://api.github.com/users/VSEphpbb/orgs","repos_url":"https://api.github.com/users/VSEphpbb/repos","events_url":"https://api.github.com/users/VSEphpbb/events{/privacy}","received_events_url":"https://api.github.com/users/VSEphpbb/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2015-09-27T17:47:27Z","updated_at":"2016-10-24T00:42:08Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/pulls/106/commits","review_comments_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/pulls/106/comments","review_comment_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/issues/106/comments","statuses_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/statuses/bcb92c1b7e112e6922a771f20c23038804607390","head":{"label":"VSEphpbb:issue/105","ref":"issue/105","sha":"bcb92c1b7e112e6922a771f20c23038804607390","user":{"login":"VSEphpbb","id":303711,"avatar_url":"https://avatars.githubusercontent.com/u/303711?v=3","gravatar_id":"","url":"https://api.github.com/users/VSEphpbb","html_url":"https://github.com/VSEphpbb","followers_url":"https://api.github.com/users/VSEphpbb/followers","following_url":"https://api.github.com/users/VSEphpbb/following{/other_user}","gists_url":"https://api.github.com/users/VSEphpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/VSEphpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VSEphpbb/subscriptions","organizations_url":"https://api.github.com/users/VSEphpbb/orgs","repos_url":"https://api.github.com/users/VSEphpbb/repos","events_url":"https://api.github.com/users/VSEphpbb/events{/privacy}","received_events_url":"https://api.github.com/users/VSEphpbb/received_events","type":"User","site_admin":false},"repo":{"id":20110820,"name":"boardannouncements","full_name":"VSEphpbb/boardannouncements","owner":{"login":"VSEphpbb","id":303711,"avatar_url":"https://avatars.githubusercontent.com/u/303711?v=3","gravatar_id":"","url":"https://api.github.com/users/VSEphpbb","html_url":"https://github.com/VSEphpbb","followers_url":"https://api.github.com/users/VSEphpbb/followers","following_url":"https://api.github.com/users/VSEphpbb/following{/other_user}","gists_url":"https://api.github.com/users/VSEphpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/VSEphpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VSEphpbb/subscriptions","organizations_url":"https://api.github.com/users/VSEphpbb/orgs","repos_url":"https://api.github.com/users/VSEphpbb/repos","events_url":"https://api.github.com/users/VSEphpbb/events{/privacy}","received_events_url":"https://api.github.com/users/VSEphpbb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VSEphpbb/boardannouncements","description":null,"fork":true,"url":"https://api.github.com/repos/VSEphpbb/boardannouncements","forks_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/forks","keys_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/teams","hooks_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/hooks","issue_events_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/issues/events{/number}","events_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/events","assignees_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/assignees{/user}","branches_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/branches{/branch}","tags_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/tags","blobs_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/git/refs{/sha}","trees_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/statuses/{sha}","languages_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/languages","stargazers_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/stargazers","contributors_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/contributors","subscribers_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/subscribers","subscription_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/subscription","commits_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/commits{/sha}","git_commits_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/git/commits{/sha}","comments_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/comments{/number}","issue_comment_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/issues/comments{/number}","contents_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/contents/{+path}","compare_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/merges","archive_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/downloads","issues_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/issues{/number}","pulls_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/pulls{/number}","milestones_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/milestones{/number}","notifications_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/labels{/name}","releases_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/releases{/id}","deployments_url":"https://api.github.com/repos/VSEphpbb/boardannouncements/deployments","created_at":"2014-05-23T19:02:54Z","updated_at":"2016-01-19T00:35:31Z","pushed_at":"2016-10-24T22:55:52Z","git_url":"git://github.com/VSEphpbb/boardannouncements.git","ssh_url":"git@github.com:VSEphpbb/boardannouncements.git","clone_url":"https://github.com/VSEphpbb/boardannouncements.git","svn_url":"https://github.com/VSEphpbb/boardannouncements","homepage":null,"size":283,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"phpbb-extensions:master","ref":"master","sha":"ffdb2c466d290d8967f7f46dfa6e7576f40b4a3a","user":{"login":"phpbb-extensions","id":5825776,"avatar_url":"https://avatars.githubusercontent.com/u/5825776?v=3","gravatar_id":"","url":"https://api.github.com/users/phpbb-extensions","html_url":"https://github.com/phpbb-extensions","followers_url":"https://api.github.com/users/phpbb-extensions/followers","following_url":"https://api.github.com/users/phpbb-extensions/following{/other_user}","gists_url":"https://api.github.com/users/phpbb-extensions/gists{/gist_id}","starred_url":"https://api.github.com/users/phpbb-extensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpbb-extensions/subscriptions","organizations_url":"https://api.github.com/users/phpbb-extensions/orgs","repos_url":"https://api.github.com/users/phpbb-extensions/repos","events_url":"https://api.github.com/users/phpbb-extensions/events{/privacy}","received_events_url":"https://api.github.com/users/phpbb-extensions/received_events","type":"Organization","site_admin":false},"repo":{"id":20110469,"name":"boardannouncements","full_name":"phpbb-extensions/boardannouncements","owner":{"login":"phpbb-extensions","id":5825776,"avatar_url":"https://avatars.githubusercontent.com/u/5825776?v=3","gravatar_id":"","url":"https://api.github.com/users/phpbb-extensions","html_url":"https://github.com/phpbb-extensions","followers_url":"https://api.github.com/users/phpbb-extensions/followers","following_url":"https://api.github.com/users/phpbb-extensions/following{/other_user}","gists_url":"https://api.github.com/users/phpbb-extensions/gists{/gist_id}","starred_url":"https://api.github.com/users/phpbb-extensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpbb-extensions/subscriptions","organizations_url":"https://api.github.com/users/phpbb-extensions/orgs","repos_url":"https://api.github.com/users/phpbb-extensions/repos","events_url":"https://api.github.com/users/phpbb-extensions/events{/privacy}","received_events_url":"https://api.github.com/users/phpbb-extensions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phpbb-extensions/boardannouncements","description":"Board Announcements extension for phpBB","fork":false,"url":"https://api.github.com/repos/phpbb-extensions/boardannouncements","forks_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/forks","keys_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/teams","hooks_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/hooks","issue_events_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/issues/events{/number}","events_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/events","assignees_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/assignees{/user}","branches_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/branches{/branch}","tags_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/tags","blobs_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/git/refs{/sha}","trees_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/statuses/{sha}","languages_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/languages","stargazers_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/stargazers","contributors_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/contributors","subscribers_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/subscribers","subscription_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/subscription","commits_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/commits{/sha}","git_commits_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/git/commits{/sha}","comments_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/comments{/number}","issue_comment_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/issues/comments{/number}","contents_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/contents/{+path}","compare_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/merges","archive_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/downloads","issues_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/issues{/number}","pulls_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/pulls{/number}","milestones_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/milestones{/number}","notifications_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/labels{/name}","releases_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/releases{/id}","deployments_url":"https://api.github.com/repos/phpbb-extensions/boardannouncements/deployments","created_at":"2014-05-23T18:52:41Z","updated_at":"2016-10-22T22:22:14Z","pushed_at":"2016-10-24T22:55:52Z","git_url":"git://github.com/phpbb-extensions/boardannouncements.git","ssh_url":"git@github.com:phpbb-extensions/boardannouncements.git","clone_url":"https://github.com/phpbb-extensions/boardannouncements.git","svn_url":"https://github.com/phpbb-extensions/boardannouncements","homepage":"https://www.phpbb.com/customise/db/extension/boardannouncements/","size":354,"stargazers_count":10,"watchers_count":10,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":4,"forks":20,"open_issues":4,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phpbb-extensions/boardannouncements/pulls/106"},"html":{"href":"https://github.com/phpbb-extensions/boardannouncements/pull/106"},"issue":{"href":"https://api.github.com/repos/phpbb-extensions/boardannouncements/issues/106"},"comments":{"href":"https://api.github.com/repos/phpbb-extensions/boardannouncements/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/phpbb-extensions/boardannouncements/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/phpbb-extensions/boardannouncements/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phpbb-extensions/boardannouncements/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/phpbb-extensions/boardannouncements/statuses/bcb92c1b7e112e6922a771f20c23038804607390"}}}}
{"actor":{"display_login":"michaelcullum"}}