{"action":"created","comment":{"url":"https://api.github.com/repos/ReactWindows/react-native-windows/pulls/comments/84543075","pull_request_review_id":5318196,"id":84543075,"diff_hunk":"@@ -47,19 +62,31 @@ public static bool IsRightToLeftForced\n         {\n             get\n             {\n+#if WINDOWS_UWP\n                 return (bool?)ApplicationData.Current.LocalSettings.Values[ForceRTL] ?? false;\n+#else\n+                return Boolean.Parse(ConfigurationManager.AppSettings[ForceRTL]);\n+#endif\n             }\n             set\n             {\n+#if WINDOWS_UWP\n                 ApplicationData.Current.LocalSettings.Values[ForceRTL] = value;\n+#else\n+                ConfigurationManager.AppSettings[AllowRTL] = value.ToString();\n+#endif\n             }\n         }\n \n         private static bool IsDeviceRightToLeft\n         {\n             get\n             {\n+#if WINDOWS_UWP\n                 return ResourceContext.GetForCurrentView().QualifierValues[\"LayoutDirection\"] == \"RTL\";\n+#else\n+                return CultureInfo.CurrentCulture.TextInfo.IsRightToLeft;\n+#endif","path":"ReactWindows/ReactNative.Shared/Modules/I18N/I18NUtil.cs","position":62,"original_position":62,"commit_id":"f196790f674c1e8e1d5f5cb0548b7d39a91ff732","original_commit_id":"f196790f674c1e8e1d5f5cb0548b7d39a91ff732","user":{"login":"rozele","id":1106239,"avatar_url":"https://avatars.githubusercontent.com/u/1106239?v=3","gravatar_id":"","url":"https://api.github.com/users/rozele","html_url":"https://github.com/rozele","followers_url":"https://api.github.com/users/rozele/followers","following_url":"https://api.github.com/users/rozele/following{/other_user}","gists_url":"https://api.github.com/users/rozele/gists{/gist_id}","starred_url":"https://api.github.com/users/rozele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rozele/subscriptions","organizations_url":"https://api.github.com/users/rozele/orgs","repos_url":"https://api.github.com/users/rozele/repos","events_url":"https://api.github.com/users/rozele/events{/privacy}","received_events_url":"https://api.github.com/users/rozele/received_events","type":"User","site_admin":false},"body":"Is this a x-plat solution (i.e., do you know if this would work for UWP as well)?","created_at":"2016-10-21T20:56:37Z","updated_at":"2016-10-21T20:56:38Z","html_url":"https://github.com/ReactWindows/react-native-windows/pull/804#discussion_r84543075","pull_request_url":"https://api.github.com/repos/ReactWindows/react-native-windows/pulls/804","_links":{"self":{"href":"https://api.github.com/repos/ReactWindows/react-native-windows/pulls/comments/84543075"},"html":{"href":"https://github.com/ReactWindows/react-native-windows/pull/804#discussion_r84543075"},"pull_request":{"href":"https://api.github.com/repos/ReactWindows/react-native-windows/pulls/804"}}},"pull_request":{"url":"https://api.github.com/repos/ReactWindows/react-native-windows/pulls/804","id":90124661,"html_url":"https://github.com/ReactWindows/react-native-windows/pull/804","diff_url":"https://github.com/ReactWindows/react-native-windows/pull/804.diff","patch_url":"https://github.com/ReactWindows/react-native-windows/pull/804.patch","issue_url":"https://api.github.com/repos/ReactWindows/react-native-windows/issues/804","number":804,"state":"open","locked":false,"title":"feat(Portable): Migrated Touch, UIManager, and I18N Module","user":{"login":"kevinvangelder","id":1771152,"avatar_url":"https://avatars.githubusercontent.com/u/1771152?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinvangelder","html_url":"https://github.com/kevinvangelder","followers_url":"https://api.github.com/users/kevinvangelder/followers","following_url":"https://api.github.com/users/kevinvangelder/following{/other_user}","gists_url":"https://api.github.com/users/kevinvangelder/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinvangelder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinvangelder/subscriptions","organizations_url":"https://api.github.com/users/kevinvangelder/orgs","repos_url":"https://api.github.com/users/kevinvangelder/repos","events_url":"https://api.github.com/users/kevinvangelder/events{/privacy}","received_events_url":"https://api.github.com/users/kevinvangelder/received_events","type":"User","site_admin":false},"body":"Also migrated UIManager tests and all but two pass. The two that fail return `Object reference not set to an instance of an object.` when trying to return the width and height of the application window. I'm probably just missing something in the test configuration.","created_at":"2016-10-20T02:46:24Z","updated_at":"2016-10-21T20:56:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f74ff4d49360836fb7254570d23e65af2919321","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ReactWindows/react-native-windows/pulls/804/commits","review_comments_url":"https://api.github.com/repos/ReactWindows/react-native-windows/pulls/804/comments","review_comment_url":"https://api.github.com/repos/ReactWindows/react-native-windows/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactWindows/react-native-windows/issues/804/comments","statuses_url":"https://api.github.com/repos/ReactWindows/react-native-windows/statuses/f196790f674c1e8e1d5f5cb0548b7d39a91ff732","head":{"label":"infinitered:shared-project-uimanager-c","ref":"shared-project-uimanager-c","sha":"f196790f674c1e8e1d5f5cb0548b7d39a91ff732","user":{"login":"infinitered","id":3902527,"avatar_url":"https://avatars.githubusercontent.com/u/3902527?v=3","gravatar_id":"","url":"https://api.github.com/users/infinitered","html_url":"https://github.com/infinitered","followers_url":"https://api.github.com/users/infinitered/followers","following_url":"https://api.github.com/users/infinitered/following{/other_user}","gists_url":"https://api.github.com/users/infinitered/gists{/gist_id}","starred_url":"https://api.github.com/users/infinitered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinitered/subscriptions","organizations_url":"https://api.github.com/users/infinitered/orgs","repos_url":"https://api.github.com/users/infinitered/repos","events_url":"https://api.github.com/users/infinitered/events{/privacy}","received_events_url":"https://api.github.com/users/infinitered/received_events","type":"Organization","site_admin":false},"repo":{"id":69399660,"name":"react-native-windows","full_name":"infinitered/react-native-windows","owner":{"login":"infinitered","id":3902527,"avatar_url":"https://avatars.githubusercontent.com/u/3902527?v=3","gravatar_id":"","url":"https://api.github.com/users/infinitered","html_url":"https://github.com/infinitered","followers_url":"https://api.github.com/users/infinitered/followers","following_url":"https://api.github.com/users/infinitered/following{/other_user}","gists_url":"https://api.github.com/users/infinitered/gists{/gist_id}","starred_url":"https://api.github.com/users/infinitered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinitered/subscriptions","organizations_url":"https://api.github.com/users/infinitered/orgs","repos_url":"https://api.github.com/users/infinitered/repos","events_url":"https://api.github.com/users/infinitered/events{/privacy}","received_events_url":"https://api.github.com/users/infinitered/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/infinitered/react-native-windows","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/infinitered/react-native-windows","forks_url":"https://api.github.com/repos/infinitered/react-native-windows/forks","keys_url":"https://api.github.com/repos/infinitered/react-native-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infinitered/react-native-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infinitered/react-native-windows/teams","hooks_url":"https://api.github.com/repos/infinitered/react-native-windows/hooks","issue_events_url":"https://api.github.com/repos/infinitered/react-native-windows/issues/events{/number}","events_url":"https://api.github.com/repos/infinitered/react-native-windows/events","assignees_url":"https://api.github.com/repos/infinitered/react-native-windows/assignees{/user}","branches_url":"https://api.github.com/repos/infinitered/react-native-windows/branches{/branch}","tags_url":"https://api.github.com/repos/infinitered/react-native-windows/tags","blobs_url":"https://api.github.com/repos/infinitered/react-native-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infinitered/react-native-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infinitered/react-native-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/infinitered/react-native-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infinitered/react-native-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/infinitered/react-native-windows/languages","stargazers_url":"https://api.github.com/repos/infinitered/react-native-windows/stargazers","contributors_url":"https://api.github.com/repos/infinitered/react-native-windows/contributors","subscribers_url":"https://api.github.com/repos/infinitered/react-native-windows/subscribers","subscription_url":"https://api.github.com/repos/infinitered/react-native-windows/subscription","commits_url":"https://api.github.com/repos/infinitered/react-native-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/infinitered/react-native-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/infinitered/react-native-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/infinitered/react-native-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/infinitered/react-native-windows/contents/{+path}","compare_url":"https://api.github.com/repos/infinitered/react-native-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infinitered/react-native-windows/merges","archive_url":"https://api.github.com/repos/infinitered/react-native-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infinitered/react-native-windows/downloads","issues_url":"https://api.github.com/repos/infinitered/react-native-windows/issues{/number}","pulls_url":"https://api.github.com/repos/infinitered/react-native-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/infinitered/react-native-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/infinitered/react-native-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infinitered/react-native-windows/labels{/name}","releases_url":"https://api.github.com/repos/infinitered/react-native-windows/releases{/id}","deployments_url":"https://api.github.com/repos/infinitered/react-native-windows/deployments","created_at":"2016-09-27T21:21:10Z","updated_at":"2016-09-27T21:21:13Z","pushed_at":"2016-10-21T18:53:34Z","git_url":"git://github.com/infinitered/react-native-windows.git","ssh_url":"git@github.com:infinitered/react-native-windows.git","clone_url":"https://github.com/infinitered/react-native-windows.git","svn_url":"https://github.com/infinitered/react-native-windows","homepage":"http://facebook.github.io/react-native/","size":144773,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ReactWindows:master","ref":"master","sha":"c08ac0664855a1e890ea9a922d4d7892f4263d29","user":{"login":"ReactWindows","id":18399765,"avatar_url":"https://avatars.githubusercontent.com/u/18399765?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactWindows","html_url":"https://github.com/ReactWindows","followers_url":"https://api.github.com/users/ReactWindows/followers","following_url":"https://api.github.com/users/ReactWindows/following{/other_user}","gists_url":"https://api.github.com/users/ReactWindows/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactWindows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactWindows/subscriptions","organizations_url":"https://api.github.com/users/ReactWindows/orgs","repos_url":"https://api.github.com/users/ReactWindows/repos","events_url":"https://api.github.com/users/ReactWindows/events{/privacy}","received_events_url":"https://api.github.com/users/ReactWindows/received_events","type":"Organization","site_admin":false},"repo":{"id":48009214,"name":"react-native-windows","full_name":"ReactWindows/react-native-windows","owner":{"login":"ReactWindows","id":18399765,"avatar_url":"https://avatars.githubusercontent.com/u/18399765?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactWindows","html_url":"https://github.com/ReactWindows","followers_url":"https://api.github.com/users/ReactWindows/followers","following_url":"https://api.github.com/users/ReactWindows/following{/other_user}","gists_url":"https://api.github.com/users/ReactWindows/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactWindows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactWindows/subscriptions","organizations_url":"https://api.github.com/users/ReactWindows/orgs","repos_url":"https://api.github.com/users/ReactWindows/repos","events_url":"https://api.github.com/users/ReactWindows/events{/privacy}","received_events_url":"https://api.github.com/users/ReactWindows/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactWindows/react-native-windows","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/ReactWindows/react-native-windows","forks_url":"https://api.github.com/repos/ReactWindows/react-native-windows/forks","keys_url":"https://api.github.com/repos/ReactWindows/react-native-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactWindows/react-native-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactWindows/react-native-windows/teams","hooks_url":"https://api.github.com/repos/ReactWindows/react-native-windows/hooks","issue_events_url":"https://api.github.com/repos/ReactWindows/react-native-windows/issues/events{/number}","events_url":"https://api.github.com/repos/ReactWindows/react-native-windows/events","assignees_url":"https://api.github.com/repos/ReactWindows/react-native-windows/assignees{/user}","branches_url":"https://api.github.com/repos/ReactWindows/react-native-windows/branches{/branch}","tags_url":"https://api.github.com/repos/ReactWindows/react-native-windows/tags","blobs_url":"https://api.github.com/repos/ReactWindows/react-native-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactWindows/react-native-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactWindows/react-native-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactWindows/react-native-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactWindows/react-native-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactWindows/react-native-windows/languages","stargazers_url":"https://api.github.com/repos/ReactWindows/react-native-windows/stargazers","contributors_url":"https://api.github.com/repos/ReactWindows/react-native-windows/contributors","subscribers_url":"https://api.github.com/repos/ReactWindows/react-native-windows/subscribers","subscription_url":"https://api.github.com/repos/ReactWindows/react-native-windows/subscription","commits_url":"https://api.github.com/repos/ReactWindows/react-native-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactWindows/react-native-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactWindows/react-native-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactWindows/react-native-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactWindows/react-native-windows/contents/{+path}","compare_url":"https://api.github.com/repos/ReactWindows/react-native-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactWindows/react-native-windows/merges","archive_url":"https://api.github.com/repos/ReactWindows/react-native-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactWindows/react-native-windows/downloads","issues_url":"https://api.github.com/repos/ReactWindows/react-native-windows/issues{/number}","pulls_url":"https://api.github.com/repos/ReactWindows/react-native-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactWindows/react-native-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactWindows/react-native-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactWindows/react-native-windows/labels{/name}","releases_url":"https://api.github.com/repos/ReactWindows/react-native-windows/releases{/id}","deployments_url":"https://api.github.com/repos/ReactWindows/react-native-windows/deployments","created_at":"2015-12-15T00:16:54Z","updated_at":"2016-10-21T14:04:59Z","pushed_at":"2016-10-21T01:00:07Z","git_url":"git://github.com/ReactWindows/react-native-windows.git","ssh_url":"git@github.com:ReactWindows/react-native-windows.git","clone_url":"https://github.com/ReactWindows/react-native-windows.git","svn_url":"https://github.com/ReactWindows/react-native-windows","homepage":"http://facebook.github.io/react-native/","size":170645,"stargazers_count":1100,"watchers_count":1100,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":85,"mirror_url":null,"open_issues_count":106,"forks":85,"open_issues":106,"watchers":1100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactWindows/react-native-windows/pulls/804"},"html":{"href":"https://github.com/ReactWindows/react-native-windows/pull/804"},"issue":{"href":"https://api.github.com/repos/ReactWindows/react-native-windows/issues/804"},"comments":{"href":"https://api.github.com/repos/ReactWindows/react-native-windows/issues/804/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactWindows/react-native-windows/pulls/804/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactWindows/react-native-windows/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactWindows/react-native-windows/pulls/804/commits"},"statuses":{"href":"https://api.github.com/repos/ReactWindows/react-native-windows/statuses/f196790f674c1e8e1d5f5cb0548b7d39a91ff732"}}}}
{"actor":{"display_login":"rozele"}}