{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/77427107","id":77427107,"diff_hunk":"@@ -1700,7 +1700,7 @@ if (!sourceList)\n \n         if((loadScriptFlag & LoadScriptFlag_isByteCodeBufferForLibrary) == LoadScriptFlag_isByteCodeBufferForLibrary)\n         {\n-            grfscr |= (fscrNoAsmJs | fscrNoPreJit);","path":"lib/Runtime/Base/ScriptContext.cpp","position":4,"original_position":4,"commit_id":"9d7d5a236337531d165130bebf9e2408d1065589","original_commit_id":"9d7d5a236337531d165130bebf9e2408d1065589","user":{"login":"tcare","id":707073,"avatar_url":"https://avatars.githubusercontent.com/u/707073?v=3","gravatar_id":"","url":"https://api.github.com/users/tcare","html_url":"https://github.com/tcare","followers_url":"https://api.github.com/users/tcare/followers","following_url":"https://api.github.com/users/tcare/following{/other_user}","gists_url":"https://api.github.com/users/tcare/gists{/gist_id}","starred_url":"https://api.github.com/users/tcare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcare/subscriptions","organizations_url":"https://api.github.com/users/tcare/orgs","repos_url":"https://api.github.com/users/tcare/repos","events_url":"https://api.github.com/users/tcare/events{/privacy}","received_events_url":"https://api.github.com/users/tcare/received_events","type":"User","site_admin":false},"body":"grfscr gets encoded into library bytecode as part of function body. We don't set it in JsHost, so we don't need to set it in ch either (checked with @MikeHolman)","created_at":"2016-09-03T00:14:30Z","updated_at":"2016-09-03T00:14:30Z","html_url":"https://github.com/Microsoft/ChakraCore/pull/1520#discussion_r77427107","pull_request_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1520","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/77427107"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/1520#discussion_r77427107"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1520"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1520","id":83536797,"html_url":"https://github.com/Microsoft/ChakraCore/pull/1520","diff_url":"https://github.com/Microsoft/ChakraCore/pull/1520.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/1520.patch","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1520","number":1520,"state":"open","locked":false,"title":"ChakraFull/ChakraCore Intl.js bytecode parity","user":{"login":"tcare","id":707073,"avatar_url":"https://avatars.githubusercontent.com/u/707073?v=3","gravatar_id":"","url":"https://api.github.com/users/tcare","html_url":"https://github.com/tcare","followers_url":"https://api.github.com/users/tcare/followers","following_url":"https://api.github.com/users/tcare/following{/other_user}","gists_url":"https://api.github.com/users/tcare/gists{/gist_id}","starred_url":"https://api.github.com/users/tcare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcare/subscriptions","organizations_url":"https://api.github.com/users/tcare/orgs","repos_url":"https://api.github.com/users/tcare/repos","events_url":"https://api.github.com/users/tcare/events{/privacy}","received_events_url":"https://api.github.com/users/tcare/received_events","type":"User","site_admin":false},"body":"This is a precursor to bytecode verification unit tests, which requires ChakraFull to produce the same library bytecode as ChakraCore for Intl.js.\n- Removed an implicit fscrNoAsmJs parser flag in ScriptContext when entering from JSRT. We don't need this flag on the initial entry, so it can be removed from the JSRT entrypoint for library bytecode generation.\n- Zero out bytecode version when generating library bytecode.\n","created_at":"2016-08-31T21:54:46Z","updated_at":"2016-09-03T00:14:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05bc8c4e33ddbc20cb26ac65a7e57121e1db6a07","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1520/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1520/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1520/comments","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/9d7d5a236337531d165130bebf9e2408d1065589","head":{"label":"tcare:bcser","ref":"bcser","sha":"9d7d5a236337531d165130bebf9e2408d1065589","user":{"login":"tcare","id":707073,"avatar_url":"https://avatars.githubusercontent.com/u/707073?v=3","gravatar_id":"","url":"https://api.github.com/users/tcare","html_url":"https://github.com/tcare","followers_url":"https://api.github.com/users/tcare/followers","following_url":"https://api.github.com/users/tcare/following{/other_user}","gists_url":"https://api.github.com/users/tcare/gists{/gist_id}","starred_url":"https://api.github.com/users/tcare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcare/subscriptions","organizations_url":"https://api.github.com/users/tcare/orgs","repos_url":"https://api.github.com/users/tcare/repos","events_url":"https://api.github.com/users/tcare/events{/privacy}","received_events_url":"https://api.github.com/users/tcare/received_events","type":"User","site_admin":false},"repo":{"id":49593370,"name":"ChakraCore","full_name":"tcare/ChakraCore","owner":{"login":"tcare","id":707073,"avatar_url":"https://avatars.githubusercontent.com/u/707073?v=3","gravatar_id":"","url":"https://api.github.com/users/tcare","html_url":"https://github.com/tcare","followers_url":"https://api.github.com/users/tcare/followers","following_url":"https://api.github.com/users/tcare/following{/other_user}","gists_url":"https://api.github.com/users/tcare/gists{/gist_id}","starred_url":"https://api.github.com/users/tcare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcare/subscriptions","organizations_url":"https://api.github.com/users/tcare/orgs","repos_url":"https://api.github.com/users/tcare/repos","events_url":"https://api.github.com/users/tcare/events{/privacy}","received_events_url":"https://api.github.com/users/tcare/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tcare/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":true,"url":"https://api.github.com/repos/tcare/ChakraCore","forks_url":"https://api.github.com/repos/tcare/ChakraCore/forks","keys_url":"https://api.github.com/repos/tcare/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tcare/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tcare/ChakraCore/teams","hooks_url":"https://api.github.com/repos/tcare/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/tcare/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/tcare/ChakraCore/events","assignees_url":"https://api.github.com/repos/tcare/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/tcare/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/tcare/ChakraCore/tags","blobs_url":"https://api.github.com/repos/tcare/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tcare/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tcare/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/tcare/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tcare/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/tcare/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/tcare/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/tcare/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/tcare/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/tcare/ChakraCore/subscription","commits_url":"https://api.github.com/repos/tcare/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/tcare/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/tcare/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/tcare/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/tcare/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/tcare/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tcare/ChakraCore/merges","archive_url":"https://api.github.com/repos/tcare/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tcare/ChakraCore/downloads","issues_url":"https://api.github.com/repos/tcare/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/tcare/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/tcare/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/tcare/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tcare/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/tcare/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/tcare/ChakraCore/deployments","created_at":"2016-01-13T18:31:37Z","updated_at":"2016-01-13T18:31:53Z","pushed_at":"2016-08-31T22:47:08Z","git_url":"git://github.com/tcare/ChakraCore.git","ssh_url":"git@github.com:tcare/ChakraCore.git","clone_url":"https://github.com/tcare/ChakraCore.git","svn_url":"https://github.com/tcare/ChakraCore","homepage":null,"size":35243,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"1e964f0e30110eb03d67df5f173f2fda46d2ac29","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":49086513,"name":"ChakraCore","full_name":"Microsoft/ChakraCore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":false,"url":"https://api.github.com/repos/Microsoft/ChakraCore","forks_url":"https://api.github.com/repos/Microsoft/ChakraCore/forks","keys_url":"https://api.github.com/repos/Microsoft/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/events","assignees_url":"https://api.github.com/repos/Microsoft/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ChakraCore/merges","archive_url":"https://api.github.com/repos/Microsoft/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ChakraCore/deployments","created_at":"2016-01-05T19:05:31Z","updated_at":"2016-09-02T08:59:27Z","pushed_at":"2016-09-03T00:13:44Z","git_url":"git://github.com/Microsoft/ChakraCore.git","ssh_url":"git@github.com:Microsoft/ChakraCore.git","clone_url":"https://github.com/Microsoft/ChakraCore.git","svn_url":"https://github.com/Microsoft/ChakraCore","homepage":null,"size":49272,"stargazers_count":5624,"watchers_count":5624,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":618,"mirror_url":null,"open_issues_count":159,"forks":618,"open_issues":159,"watchers":5624,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1520"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/1520"},"issue":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1520"},"comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1520/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1520/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1520/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/9d7d5a236337531d165130bebf9e2408d1065589"}}}}
{"actor":{"display_login":"tcare"}}