{"action":"created","issue":{"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/584","repository_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap","labels_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/584/labels{/name}","comments_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/584/comments","events_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/584/events","html_url":"https://github.com/ng-bootstrap/ng-bootstrap/issues/584","id":170701676,"number":584,"title":"Dropdown Missing Features","user":{"login":"scttcper","id":1400464,"avatar_url":"https://avatars.githubusercontent.com/u/1400464?v=3","gravatar_id":"","url":"https://api.github.com/users/scttcper","html_url":"https://github.com/scttcper","followers_url":"https://api.github.com/users/scttcper/followers","following_url":"https://api.github.com/users/scttcper/following{/other_user}","gists_url":"https://api.github.com/users/scttcper/gists{/gist_id}","starred_url":"https://api.github.com/users/scttcper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scttcper/subscriptions","organizations_url":"https://api.github.com/users/scttcper/orgs","repos_url":"https://api.github.com/users/scttcper/repos","events_url":"https://api.github.com/users/scttcper/events{/privacy}","received_events_url":"https://api.github.com/users/scttcper/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-11T17:33:49Z","updated_at":"2016-08-11T17:45:39Z","closed_at":null,"body":"Howdy,\r\n\r\nDropdown is missing some features from the jquery bootstrap library\r\n\r\n- [ ] Support input/textarea in dropdown (click without closing)\r\n- [ ] Arrow key navigation, ui-bootstrap handles this incorrectly and the page still scrolls when using arrows.\r\n- [ ] Not close when clicking a disabled dropdown element\r\n- [ ] Close on outside touch/tap (mobile). Current document:click is mouse only and IMO not a great option as it fires for every click for every dropdown active on your page. It also makes it more difficult to control what to auto close for as it loses track of where clicks are happening inside the dropdown vs outside.\r\n\r\nI've got some of these features on my own implementation that I no longer want to maintain and would rather use this project.\r\nhttps://scttcper.github.io/ng2-bs-dropdown\r\n\r\nI can make a pull request, but pretty much all of them require moving away from document:click towards another solution. I've placed a div with .dropdown-backdrop (like jquery bootstrap) that captures both taps and clicks when the dropdown is open, however this also catches the click and prevents clicks on lower levels from happening. So on \r\n```html\r\n<button>Outside</button><div ngbDropdown [open]=\"true\"></div>\r\n```\r\nthe button won't be clicked because the dropdown-backdrop captures its and so button requires two clicks to activate. It could be possible to show the backdrop only when a touchstart is detected that way it's only shown for mobile users.\r\n\r\nLet me know your thoughts."},"comment":{"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/comments/239236217","html_url":"https://github.com/ng-bootstrap/ng-bootstrap/issues/584#issuecomment-239236217","issue_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/584","id":239236217,"user":{"login":"pkozlowski-opensource","id":973550,"avatar_url":"https://avatars.githubusercontent.com/u/973550?v=3","gravatar_id":"","url":"https://api.github.com/users/pkozlowski-opensource","html_url":"https://github.com/pkozlowski-opensource","followers_url":"https://api.github.com/users/pkozlowski-opensource/followers","following_url":"https://api.github.com/users/pkozlowski-opensource/following{/other_user}","gists_url":"https://api.github.com/users/pkozlowski-opensource/gists{/gist_id}","starred_url":"https://api.github.com/users/pkozlowski-opensource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkozlowski-opensource/subscriptions","organizations_url":"https://api.github.com/users/pkozlowski-opensource/orgs","repos_url":"https://api.github.com/users/pkozlowski-opensource/repos","events_url":"https://api.github.com/users/pkozlowski-opensource/events{/privacy}","received_events_url":"https://api.github.com/users/pkozlowski-opensource/received_events","type":"User","site_admin":false},"created_at":"2016-08-11T17:45:39Z","updated_at":"2016-08-11T17:45:39Z","body":"@scttcper glad to hear that you are up to the contributing here, I think this is a win-win solution.\r\n\r\nNow, all the points you are raising are valid and I would be more than happy to work with you on addressing those. Making this directive more robust was on my TODO list anyway.\r\n\r\nAs for the technical solution - I didn't spend enough time on this directive to know what would work best. Maybe we should start iterating on small bits to get the ball rolling? For example I would be really curious what you propose for the `disabled` items as currently those are just `CSS` classes and pretty much user-driven.\r\n\r\nMy biggest worry is to make sure that this directive is flexible enough so users have full control over dropdown menu content.  "}}
{"actor":{"display_login":"pkozlowski-opensource"}}