{"action":"created","issue":{"url":"https://api.github.com/repos/getlantern/lantern/issues/4650","repository_url":"https://api.github.com/repos/getlantern/lantern","labels_url":"https://api.github.com/repos/getlantern/lantern/issues/4650/labels{/name}","comments_url":"https://api.github.com/repos/getlantern/lantern/issues/4650/comments","events_url":"https://api.github.com/repos/getlantern/lantern/issues/4650/events","html_url":"https://github.com/getlantern/lantern/pull/4650","id":159829612,"number":4650,"title":"[WIP] Using an explicit patch for Go","user":{"login":"xiam","id":385670,"avatar_url":"https://avatars.githubusercontent.com/u/385670?v=3","gravatar_id":"","url":"https://api.github.com/users/xiam","html_url":"https://github.com/xiam","followers_url":"https://api.github.com/users/xiam/followers","following_url":"https://api.github.com/users/xiam/following{/other_user}","gists_url":"https://api.github.com/users/xiam/gists{/gist_id}","starred_url":"https://api.github.com/users/xiam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiam/subscriptions","organizations_url":"https://api.github.com/users/xiam/orgs","repos_url":"https://api.github.com/users/xiam/repos","events_url":"https://api.github.com/users/xiam/events{/privacy}","received_events_url":"https://api.github.com/users/xiam/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-06-12T14:16:01Z","updated_at":"2016-06-15T15:05:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/getlantern/lantern/pulls/4650","html_url":"https://github.com/getlantern/lantern/pull/4650","diff_url":"https://github.com/getlantern/lantern/pull/4650.diff","patch_url":"https://github.com/getlantern/lantern/pull/4650.patch"},"body":"If you're not using the Lantern's Go fork and you try to build it without docker it will fail:\r\n\r\n* https://github.com/getlantern/lantern/issues/4638\r\n* https://github.com/getlantern/lantern/issues/4605#issuecomment-224985945\r\n* https://github.com/getlantern/lantern/issues/4692\r\n\r\nFor users there's no obvious indication of what happened. Some users could find out that our README changed a bit and that now we require a fork of Go but some others won't.\r\n\r\nWhat I propose here is that `setenv` checks for the proper environment values and suggests what to do in case that the environment is not adequate (e.g.: when the user does not have our Go fork).\r\n\r\n```\r\nmake linux\r\nLantern requires a special fork of Go, use 'make lantern-go'\r\nmake: *** [linux-386] Error 1\r\n```\r\n\r\n```\r\nmake lantern-go\r\n# wait several minutes\r\n```\r\n\r\n```\r\nmake linux\r\n# success!\r\n```\r\n\r\nThe included patch was generated with https://github.com/getlantern/go/pull/2"},"comment":{"url":"https://api.github.com/repos/getlantern/lantern/issues/comments/226216466","html_url":"https://github.com/getlantern/lantern/pull/4650#issuecomment-226216466","issue_url":"https://api.github.com/repos/getlantern/lantern/issues/4650","id":226216466,"user":{"login":"myleshorton","id":1143966,"avatar_url":"https://avatars.githubusercontent.com/u/1143966?v=3","gravatar_id":"","url":"https://api.github.com/users/myleshorton","html_url":"https://github.com/myleshorton","followers_url":"https://api.github.com/users/myleshorton/followers","following_url":"https://api.github.com/users/myleshorton/following{/other_user}","gists_url":"https://api.github.com/users/myleshorton/gists{/gist_id}","starred_url":"https://api.github.com/users/myleshorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myleshorton/subscriptions","organizations_url":"https://api.github.com/users/myleshorton/orgs","repos_url":"https://api.github.com/users/myleshorton/repos","events_url":"https://api.github.com/users/myleshorton/events{/privacy}","received_events_url":"https://api.github.com/users/myleshorton/received_events","type":"User","site_admin":false},"created_at":"2016-06-15T15:05:25Z","updated_at":"2016-06-15T15:05:25Z","body":"Yup I've been noticing this too @xiam -- I'll dig deeper into it."}}
{"actor":{"display_login":"myleshorton"}}