{"action":"created","comment":{"url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/pulls/comments/52778680","id":52778680,"diff_hunk":"@@ -372,29 +368,6 @@ def hints_path\n         Ohai::Config[:hints_path][0]\n       end\n \n-      def setup_ssh(server, state)\n-        if config[:key_name]\n-          info \"Using OpenStack keypair <#{config[:key_name]}>\"\n-        end\n-        info \"Using public SSH key <#{config[:public_key_path]}>\"\n-        info \"Using private SSH key <#{config[:private_key_path]}>\"\n-        state[:ssh_key] = config[:private_key_path]\n-        do_ssh_setup(state, config, server) unless config[:key_name]\n-      end\n-\n-      def do_ssh_setup(state, config, server)","path":"lib/kitchen/driver/openstack.rb","position":48,"original_position":48,"commit_id":"5ac1f0c3291e9e59931b01f8adb33fad5fa28311","original_commit_id":"5ac1f0c3291e9e59931b01f8adb33fad5fa28311","user":{"login":"adamleff","id":3221128,"avatar_url":"https://avatars.githubusercontent.com/u/3221128?v=3","gravatar_id":"","url":"https://api.github.com/users/adamleff","html_url":"https://github.com/adamleff","followers_url":"https://api.github.com/users/adamleff/followers","following_url":"https://api.github.com/users/adamleff/following{/other_user}","gists_url":"https://api.github.com/users/adamleff/gists{/gist_id}","starred_url":"https://api.github.com/users/adamleff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamleff/subscriptions","organizations_url":"https://api.github.com/users/adamleff/orgs","repos_url":"https://api.github.com/users/adamleff/repos","events_url":"https://api.github.com/users/adamleff/events{/privacy}","received_events_url":"https://api.github.com/users/adamleff/received_events","type":"User","site_admin":false},"body":"In your PR comments, you said that you're removing these methods because the transport does this for you, but I don't believe the transport actually pushes an SSH key out to an endpoint if it doesn't exist. ","created_at":"2016-02-12T18:29:33Z","updated_at":"2016-02-12T18:29:33Z","html_url":"https://github.com/test-kitchen/kitchen-openstack/pull/136#discussion_r52778680","pull_request_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/pulls/136","_links":{"self":{"href":"https://api.github.com/repos/test-kitchen/kitchen-openstack/pulls/comments/52778680"},"html":{"href":"https://github.com/test-kitchen/kitchen-openstack/pull/136#discussion_r52778680"},"pull_request":{"href":"https://api.github.com/repos/test-kitchen/kitchen-openstack/pulls/136"}}},"pull_request":{"url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/pulls/136","id":59208289,"html_url":"https://github.com/test-kitchen/kitchen-openstack/pull/136","diff_url":"https://github.com/test-kitchen/kitchen-openstack/pull/136.diff","patch_url":"https://github.com/test-kitchen/kitchen-openstack/pull/136.patch","issue_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/issues/136","number":136,"state":"open","locked":false,"title":"3.0.0 Release of kitchen-openstack","user":{"login":"jjasghar","id":810824,"avatar_url":"https://avatars.githubusercontent.com/u/810824?v=3","gravatar_id":"","url":"https://api.github.com/users/jjasghar","html_url":"https://github.com/jjasghar","followers_url":"https://api.github.com/users/jjasghar/followers","following_url":"https://api.github.com/users/jjasghar/following{/other_user}","gists_url":"https://api.github.com/users/jjasghar/gists{/gist_id}","starred_url":"https://api.github.com/users/jjasghar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjasghar/subscriptions","organizations_url":"https://api.github.com/users/jjasghar/orgs","repos_url":"https://api.github.com/users/jjasghar/repos","events_url":"https://api.github.com/users/jjasghar/events{/privacy}","received_events_url":"https://api.github.com/users/jjasghar/received_events","type":"User","site_admin":false},"body":"- Updated README\r\n- Removed the `:username` and `:password` options\r\n- Removed the `:winrm_wait` because it wasn't being used\r\n- Removed the `setup_ssh` because it was doubling up what transport was doing\r\n- Removed the old tests for the changes above\r\n- Pinned version of `rubocop` because I'm happy with 0.34.1.","created_at":"2016-02-12T17:59:01Z","updated_at":"2016-02-12T18:29:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/pulls/136/commits","review_comments_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/pulls/136/comments","review_comment_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/issues/136/comments","statuses_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/statuses/5ac1f0c3291e9e59931b01f8adb33fad5fa28311","head":{"label":"test-kitchen:3.0.0","ref":"3.0.0","sha":"5ac1f0c3291e9e59931b01f8adb33fad5fa28311","user":{"login":"test-kitchen","id":5924439,"avatar_url":"https://avatars.githubusercontent.com/u/5924439?v=3","gravatar_id":"","url":"https://api.github.com/users/test-kitchen","html_url":"https://github.com/test-kitchen","followers_url":"https://api.github.com/users/test-kitchen/followers","following_url":"https://api.github.com/users/test-kitchen/following{/other_user}","gists_url":"https://api.github.com/users/test-kitchen/gists{/gist_id}","starred_url":"https://api.github.com/users/test-kitchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/test-kitchen/subscriptions","organizations_url":"https://api.github.com/users/test-kitchen/orgs","repos_url":"https://api.github.com/users/test-kitchen/repos","events_url":"https://api.github.com/users/test-kitchen/events{/privacy}","received_events_url":"https://api.github.com/users/test-kitchen/received_events","type":"Organization","site_admin":false},"repo":{"id":8614070,"name":"kitchen-openstack","full_name":"test-kitchen/kitchen-openstack","owner":{"login":"test-kitchen","id":5924439,"avatar_url":"https://avatars.githubusercontent.com/u/5924439?v=3","gravatar_id":"","url":"https://api.github.com/users/test-kitchen","html_url":"https://github.com/test-kitchen","followers_url":"https://api.github.com/users/test-kitchen/followers","following_url":"https://api.github.com/users/test-kitchen/following{/other_user}","gists_url":"https://api.github.com/users/test-kitchen/gists{/gist_id}","starred_url":"https://api.github.com/users/test-kitchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/test-kitchen/subscriptions","organizations_url":"https://api.github.com/users/test-kitchen/orgs","repos_url":"https://api.github.com/users/test-kitchen/repos","events_url":"https://api.github.com/users/test-kitchen/events{/privacy}","received_events_url":"https://api.github.com/users/test-kitchen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/test-kitchen/kitchen-openstack","description":"An OpenStack Compute driver for Test Kitchen","fork":false,"url":"https://api.github.com/repos/test-kitchen/kitchen-openstack","forks_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/forks","keys_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/teams","hooks_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/hooks","issue_events_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/events","assignees_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/tags","blobs_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/languages","stargazers_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/stargazers","contributors_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/contributors","subscribers_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/subscribers","subscription_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/subscription","commits_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/merges","archive_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/downloads","issues_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/labels{/name}","releases_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/deployments","created_at":"2013-03-06T21:53:08Z","updated_at":"2016-02-12T01:51:06Z","pushed_at":"2016-02-12T18:16:06Z","git_url":"git://github.com/test-kitchen/kitchen-openstack.git","ssh_url":"git@github.com:test-kitchen/kitchen-openstack.git","clone_url":"https://github.com/test-kitchen/kitchen-openstack.git","svn_url":"https://github.com/test-kitchen/kitchen-openstack","homepage":"","size":1139,"stargazers_count":36,"watchers_count":36,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":5,"forks":51,"open_issues":5,"watchers":36,"default_branch":"master"}},"base":{"label":"test-kitchen:master","ref":"master","sha":"149a5d451360e35d057965ff688647c994379e68","user":{"login":"test-kitchen","id":5924439,"avatar_url":"https://avatars.githubusercontent.com/u/5924439?v=3","gravatar_id":"","url":"https://api.github.com/users/test-kitchen","html_url":"https://github.com/test-kitchen","followers_url":"https://api.github.com/users/test-kitchen/followers","following_url":"https://api.github.com/users/test-kitchen/following{/other_user}","gists_url":"https://api.github.com/users/test-kitchen/gists{/gist_id}","starred_url":"https://api.github.com/users/test-kitchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/test-kitchen/subscriptions","organizations_url":"https://api.github.com/users/test-kitchen/orgs","repos_url":"https://api.github.com/users/test-kitchen/repos","events_url":"https://api.github.com/users/test-kitchen/events{/privacy}","received_events_url":"https://api.github.com/users/test-kitchen/received_events","type":"Organization","site_admin":false},"repo":{"id":8614070,"name":"kitchen-openstack","full_name":"test-kitchen/kitchen-openstack","owner":{"login":"test-kitchen","id":5924439,"avatar_url":"https://avatars.githubusercontent.com/u/5924439?v=3","gravatar_id":"","url":"https://api.github.com/users/test-kitchen","html_url":"https://github.com/test-kitchen","followers_url":"https://api.github.com/users/test-kitchen/followers","following_url":"https://api.github.com/users/test-kitchen/following{/other_user}","gists_url":"https://api.github.com/users/test-kitchen/gists{/gist_id}","starred_url":"https://api.github.com/users/test-kitchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/test-kitchen/subscriptions","organizations_url":"https://api.github.com/users/test-kitchen/orgs","repos_url":"https://api.github.com/users/test-kitchen/repos","events_url":"https://api.github.com/users/test-kitchen/events{/privacy}","received_events_url":"https://api.github.com/users/test-kitchen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/test-kitchen/kitchen-openstack","description":"An OpenStack Compute driver for Test Kitchen","fork":false,"url":"https://api.github.com/repos/test-kitchen/kitchen-openstack","forks_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/forks","keys_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/teams","hooks_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/hooks","issue_events_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/events","assignees_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/tags","blobs_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/languages","stargazers_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/stargazers","contributors_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/contributors","subscribers_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/subscribers","subscription_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/subscription","commits_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/merges","archive_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/downloads","issues_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/labels{/name}","releases_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/test-kitchen/kitchen-openstack/deployments","created_at":"2013-03-06T21:53:08Z","updated_at":"2016-02-12T01:51:06Z","pushed_at":"2016-02-12T18:16:06Z","git_url":"git://github.com/test-kitchen/kitchen-openstack.git","ssh_url":"git@github.com:test-kitchen/kitchen-openstack.git","clone_url":"https://github.com/test-kitchen/kitchen-openstack.git","svn_url":"https://github.com/test-kitchen/kitchen-openstack","homepage":"","size":1139,"stargazers_count":36,"watchers_count":36,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":5,"forks":51,"open_issues":5,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/test-kitchen/kitchen-openstack/pulls/136"},"html":{"href":"https://github.com/test-kitchen/kitchen-openstack/pull/136"},"issue":{"href":"https://api.github.com/repos/test-kitchen/kitchen-openstack/issues/136"},"comments":{"href":"https://api.github.com/repos/test-kitchen/kitchen-openstack/issues/136/comments"},"review_comments":{"href":"https://api.github.com/repos/test-kitchen/kitchen-openstack/pulls/136/comments"},"review_comment":{"href":"https://api.github.com/repos/test-kitchen/kitchen-openstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/test-kitchen/kitchen-openstack/pulls/136/commits"},"statuses":{"href":"https://api.github.com/repos/test-kitchen/kitchen-openstack/statuses/5ac1f0c3291e9e59931b01f8adb33fad5fa28311"}}}}