{"action":"created","comment":{"url":"https://api.github.com/repos/mit-crpg/openmc/pulls/comments/83986057","pull_request_review_id":4793087,"id":83986057,"diff_hunk":"@@ -62,23 +61,6 @@ subroutine read_mgxs()\n     allocate(micro_xs(n_nuclides_total))\n !$omp end parallel\n \n-    ! Find out if we need fission & kappa fission","path":"src/mgxs_data.F90","position":43,"original_position":43,"commit_id":"f7c3f80504553bf5a0ce563d4fd3e5a74a1bc440","original_commit_id":"f7c3f80504553bf5a0ce563d4fd3e5a74a1bc440","user":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"body":"I removed the `get_kfiss` and `get_fiss` so that the all xs are initialized whether the user input them or not. If fission and kappa-fission are not set, they will be ZERO.","created_at":"2016-10-19T02:00:27Z","updated_at":"2016-10-19T02:00:27Z","html_url":"https://github.com/mit-crpg/openmc/pull/739#discussion_r83986057","pull_request_url":"https://api.github.com/repos/mit-crpg/openmc/pulls/739","_links":{"self":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/comments/83986057"},"html":{"href":"https://github.com/mit-crpg/openmc/pull/739#discussion_r83986057"},"pull_request":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/739"}}},"pull_request":{"url":"https://api.github.com/repos/mit-crpg/openmc/pulls/739","id":89265329,"html_url":"https://github.com/mit-crpg/openmc/pull/739","diff_url":"https://github.com/mit-crpg/openmc/pull/739.diff","patch_url":"https://github.com/mit-crpg/openmc/pull/739.patch","issue_url":"https://api.github.com/repos/mit-crpg/openmc/issues/739","number":739,"state":"open","locked":false,"title":"Treatment of delayed neutrons in multi-group mode","user":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"body":"This PR adds the explicit treatment of delayed neutrons to the multi-group mode. In order to achieve this functionality, several modifications and additions needed to be made:\r\n\r\n- **Global constant for the number of delayed groups**: Similar to the number of energy groups, a constant has been added to `global.F90` specifying the number of delayed groups of the input cross sections.\r\n- **`delayed_groups` attribute added to `XSdata` and `MGXSLibrary` objects** \r\n- **Cross sections for `chi-delayed`, `chi-prompt`, `delayed-nu-fission`, and `prompt-nu-fission`**: `chi` and `nu-fission` have been broken up into separate prompt and delayed components in order for the fission neutrons to be sampled as either prompt or delayed and the appropriate spectrum to be used in sampling fission neutrons. The user can input cross sections with or without separate prompt and delayed components.\r\n- **`beta` cross section added as `XSdata` attribute**: The delayed neutron fraction, beta, has been added. If `beta` and `nu-fission` are input, `beta` will break up `nu-fission` into separate prompt and delayed components.\r\n- **Physics treatment of delayed neutrons**: The `create_fission_sites(...)` subroutine in `physics_mg.F90` has been modified to match the procedure in `physics.F90` in treating prompt and delayed emissions separately.\r\n- **Tallies with energy out filters**: The separate mg and ce versions of the `score_fission_eout` subroutine in `tallies.F90` have been combined to reduce code redundancy.\r\n- **Treatment of which nu-fission/chi multi-group cross section types to use**: OpenMC allows the user to input chi and a nu-fission vector or a nu-fission matrix (which allows a chi matrix to be extracted). When adding delayed neutrons, this procedure got very complicated. Instead of having a bunch of different case, certain cross-section types just take precedence over others. For instance, if a user inputs a nu-fission matrix, any values input to chi will be overridden with chi contained in the nu-fission matrix. With regards to delayed neutrons, any prompt or delayed chi or nu-fission cross sections will override values input from chi and nu-fission. The process of inputting MG cross sections is still somewhat confusing so if more clarity is needed or if others have better ideas, I'm all ears.\r\n\r\nI'll also note that options for inputting a delayed-nu-fission or prompt-nu-fission matrix have been implemented, but in order to keep this PR as small as possible, that addition will be added in a future PR.\r\n\r\nThis PR builds on the great work by @nelsonag in PR #719 and will significantly reduce in size once that PR is merged.","created_at":"2016-10-13T19:22:21Z","updated_at":"2016-10-19T02:00:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00732643b5c8c654e8afbcf88b1ef8c9ff99f73c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mit-crpg/openmc/pulls/739/commits","review_comments_url":"https://api.github.com/repos/mit-crpg/openmc/pulls/739/comments","review_comment_url":"https://api.github.com/repos/mit-crpg/openmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mit-crpg/openmc/issues/739/comments","statuses_url":"https://api.github.com/repos/mit-crpg/openmc/statuses/f7c3f80504553bf5a0ce563d4fd3e5a74a1bc440","head":{"label":"samuelshaner:mg-mode-delayed","ref":"mg-mode-delayed","sha":"f7c3f80504553bf5a0ce563d4fd3e5a74a1bc440","user":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"repo":{"id":30840720,"name":"openmc","full_name":"samuelshaner/openmc","owner":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samuelshaner/openmc","description":"OpenMC Monte Carlo Code","fork":true,"url":"https://api.github.com/repos/samuelshaner/openmc","forks_url":"https://api.github.com/repos/samuelshaner/openmc/forks","keys_url":"https://api.github.com/repos/samuelshaner/openmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samuelshaner/openmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samuelshaner/openmc/teams","hooks_url":"https://api.github.com/repos/samuelshaner/openmc/hooks","issue_events_url":"https://api.github.com/repos/samuelshaner/openmc/issues/events{/number}","events_url":"https://api.github.com/repos/samuelshaner/openmc/events","assignees_url":"https://api.github.com/repos/samuelshaner/openmc/assignees{/user}","branches_url":"https://api.github.com/repos/samuelshaner/openmc/branches{/branch}","tags_url":"https://api.github.com/repos/samuelshaner/openmc/tags","blobs_url":"https://api.github.com/repos/samuelshaner/openmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samuelshaner/openmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samuelshaner/openmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/samuelshaner/openmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samuelshaner/openmc/statuses/{sha}","languages_url":"https://api.github.com/repos/samuelshaner/openmc/languages","stargazers_url":"https://api.github.com/repos/samuelshaner/openmc/stargazers","contributors_url":"https://api.github.com/repos/samuelshaner/openmc/contributors","subscribers_url":"https://api.github.com/repos/samuelshaner/openmc/subscribers","subscription_url":"https://api.github.com/repos/samuelshaner/openmc/subscription","commits_url":"https://api.github.com/repos/samuelshaner/openmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/samuelshaner/openmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/samuelshaner/openmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/samuelshaner/openmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/samuelshaner/openmc/contents/{+path}","compare_url":"https://api.github.com/repos/samuelshaner/openmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samuelshaner/openmc/merges","archive_url":"https://api.github.com/repos/samuelshaner/openmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samuelshaner/openmc/downloads","issues_url":"https://api.github.com/repos/samuelshaner/openmc/issues{/number}","pulls_url":"https://api.github.com/repos/samuelshaner/openmc/pulls{/number}","milestones_url":"https://api.github.com/repos/samuelshaner/openmc/milestones{/number}","notifications_url":"https://api.github.com/repos/samuelshaner/openmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samuelshaner/openmc/labels{/name}","releases_url":"https://api.github.com/repos/samuelshaner/openmc/releases{/id}","deployments_url":"https://api.github.com/repos/samuelshaner/openmc/deployments","created_at":"2015-02-15T20:23:50Z","updated_at":"2016-10-11T12:42:32Z","pushed_at":"2016-10-18T22:32:10Z","git_url":"git://github.com/samuelshaner/openmc.git","ssh_url":"git@github.com:samuelshaner/openmc.git","clone_url":"https://github.com/samuelshaner/openmc.git","svn_url":"https://github.com/samuelshaner/openmc","homepage":"http://mit-crpg.github.io/openmc/","size":33403,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"mit-crpg:develop","ref":"develop","sha":"c9c7ff497acd38f2ebc1e14db14f8065440852de","user":{"login":"mit-crpg","id":1247634,"avatar_url":"https://avatars.githubusercontent.com/u/1247634?v=3","gravatar_id":"","url":"https://api.github.com/users/mit-crpg","html_url":"https://github.com/mit-crpg","followers_url":"https://api.github.com/users/mit-crpg/followers","following_url":"https://api.github.com/users/mit-crpg/following{/other_user}","gists_url":"https://api.github.com/users/mit-crpg/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-crpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-crpg/subscriptions","organizations_url":"https://api.github.com/users/mit-crpg/orgs","repos_url":"https://api.github.com/users/mit-crpg/repos","events_url":"https://api.github.com/users/mit-crpg/events{/privacy}","received_events_url":"https://api.github.com/users/mit-crpg/received_events","type":"Organization","site_admin":false},"repo":{"id":2081118,"name":"openmc","full_name":"mit-crpg/openmc","owner":{"login":"mit-crpg","id":1247634,"avatar_url":"https://avatars.githubusercontent.com/u/1247634?v=3","gravatar_id":"","url":"https://api.github.com/users/mit-crpg","html_url":"https://github.com/mit-crpg","followers_url":"https://api.github.com/users/mit-crpg/followers","following_url":"https://api.github.com/users/mit-crpg/following{/other_user}","gists_url":"https://api.github.com/users/mit-crpg/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-crpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-crpg/subscriptions","organizations_url":"https://api.github.com/users/mit-crpg/orgs","repos_url":"https://api.github.com/users/mit-crpg/repos","events_url":"https://api.github.com/users/mit-crpg/events{/privacy}","received_events_url":"https://api.github.com/users/mit-crpg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mit-crpg/openmc","description":"OpenMC Monte Carlo Code","fork":false,"url":"https://api.github.com/repos/mit-crpg/openmc","forks_url":"https://api.github.com/repos/mit-crpg/openmc/forks","keys_url":"https://api.github.com/repos/mit-crpg/openmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mit-crpg/openmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mit-crpg/openmc/teams","hooks_url":"https://api.github.com/repos/mit-crpg/openmc/hooks","issue_events_url":"https://api.github.com/repos/mit-crpg/openmc/issues/events{/number}","events_url":"https://api.github.com/repos/mit-crpg/openmc/events","assignees_url":"https://api.github.com/repos/mit-crpg/openmc/assignees{/user}","branches_url":"https://api.github.com/repos/mit-crpg/openmc/branches{/branch}","tags_url":"https://api.github.com/repos/mit-crpg/openmc/tags","blobs_url":"https://api.github.com/repos/mit-crpg/openmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mit-crpg/openmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mit-crpg/openmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/mit-crpg/openmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mit-crpg/openmc/statuses/{sha}","languages_url":"https://api.github.com/repos/mit-crpg/openmc/languages","stargazers_url":"https://api.github.com/repos/mit-crpg/openmc/stargazers","contributors_url":"https://api.github.com/repos/mit-crpg/openmc/contributors","subscribers_url":"https://api.github.com/repos/mit-crpg/openmc/subscribers","subscription_url":"https://api.github.com/repos/mit-crpg/openmc/subscription","commits_url":"https://api.github.com/repos/mit-crpg/openmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/mit-crpg/openmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/mit-crpg/openmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/mit-crpg/openmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/mit-crpg/openmc/contents/{+path}","compare_url":"https://api.github.com/repos/mit-crpg/openmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mit-crpg/openmc/merges","archive_url":"https://api.github.com/repos/mit-crpg/openmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mit-crpg/openmc/downloads","issues_url":"https://api.github.com/repos/mit-crpg/openmc/issues{/number}","pulls_url":"https://api.github.com/repos/mit-crpg/openmc/pulls{/number}","milestones_url":"https://api.github.com/repos/mit-crpg/openmc/milestones{/number}","notifications_url":"https://api.github.com/repos/mit-crpg/openmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mit-crpg/openmc/labels{/name}","releases_url":"https://api.github.com/repos/mit-crpg/openmc/releases{/id}","deployments_url":"https://api.github.com/repos/mit-crpg/openmc/deployments","created_at":"2011-07-21T00:33:27Z","updated_at":"2016-10-11T18:38:26Z","pushed_at":"2016-10-18T23:21:37Z","git_url":"git://github.com/mit-crpg/openmc.git","ssh_url":"git@github.com:mit-crpg/openmc.git","clone_url":"https://github.com/mit-crpg/openmc.git","svn_url":"https://github.com/mit-crpg/openmc","homepage":"http://mit-crpg.github.io/openmc/","size":50108,"stargazers_count":88,"watchers_count":88,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":104,"mirror_url":null,"open_issues_count":52,"forks":104,"open_issues":52,"watchers":88,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/739"},"html":{"href":"https://github.com/mit-crpg/openmc/pull/739"},"issue":{"href":"https://api.github.com/repos/mit-crpg/openmc/issues/739"},"comments":{"href":"https://api.github.com/repos/mit-crpg/openmc/issues/739/comments"},"review_comments":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/739/comments"},"review_comment":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/739/commits"},"statuses":{"href":"https://api.github.com/repos/mit-crpg/openmc/statuses/f7c3f80504553bf5a0ce563d4fd3e5a74a1bc440"}}}}
{"actor":{"display_login":"samuelshaner"}}