{"action":"created","comment":{"url":"https://api.github.com/repos/sindresorhus/globby/pulls/comments/83558128","pull_request_review_id":4394916,"id":83558128,"diff_hunk":"@@ -43,11 +43,28 @@ function generateGlobTasks(patterns, opts) {\n \t\tvar ignore = patterns.slice(i).filter(isNegative).map(function (pattern) {\n \t\t\treturn pattern.slice(1);\n \t\t});\n+\t\tignore = opts.ignore.concat(ignore);\n+\n+\t\t// Convert negated ignores into positive patterns\n+\t\tignore.forEach(function(ign) {","path":"index.js","position":7,"original_position":7,"commit_id":"f1377353e1902b14d2ca7dff39dc2e81d2f2a372","original_commit_id":"f1377353e1902b14d2ca7dff39dc2e81d2f2a372","user":{"login":"schnittstabil","id":6059032,"avatar_url":"https://avatars.githubusercontent.com/u/6059032?v=3","gravatar_id":"","url":"https://api.github.com/users/schnittstabil","html_url":"https://github.com/schnittstabil","followers_url":"https://api.github.com/users/schnittstabil/followers","following_url":"https://api.github.com/users/schnittstabil/following{/other_user}","gists_url":"https://api.github.com/users/schnittstabil/gists{/gist_id}","starred_url":"https://api.github.com/users/schnittstabil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schnittstabil/subscriptions","organizations_url":"https://api.github.com/users/schnittstabil/orgs","repos_url":"https://api.github.com/users/schnittstabil/repos","events_url":"https://api.github.com/users/schnittstabil/events{/privacy}","received_events_url":"https://api.github.com/users/schnittstabil/received_events","type":"User","site_admin":false},"body":"```diff\r\n- function(ign)\r\n+ function (ign)\r\n```","created_at":"2016-10-16T19:23:02Z","updated_at":"2016-10-16T19:25:32Z","html_url":"https://github.com/sindresorhus/globby/pull/34#discussion_r83558128","pull_request_url":"https://api.github.com/repos/sindresorhus/globby/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/sindresorhus/globby/pulls/comments/83558128"},"html":{"href":"https://github.com/sindresorhus/globby/pull/34#discussion_r83558128"},"pull_request":{"href":"https://api.github.com/repos/sindresorhus/globby/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/sindresorhus/globby/pulls/34","id":89534316,"html_url":"https://github.com/sindresorhus/globby/pull/34","diff_url":"https://github.com/sindresorhus/globby/pull/34.diff","patch_url":"https://github.com/sindresorhus/globby/pull/34.patch","issue_url":"https://api.github.com/repos/sindresorhus/globby/issues/34","number":34,"state":"open","locked":false,"title":"Support negated ignores","user":{"login":"JonnyBurger","id":1629785,"avatar_url":"https://avatars.githubusercontent.com/u/1629785?v=3","gravatar_id":"","url":"https://api.github.com/users/JonnyBurger","html_url":"https://github.com/JonnyBurger","followers_url":"https://api.github.com/users/JonnyBurger/followers","following_url":"https://api.github.com/users/JonnyBurger/following{/other_user}","gists_url":"https://api.github.com/users/JonnyBurger/gists{/gist_id}","starred_url":"https://api.github.com/users/JonnyBurger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonnyBurger/subscriptions","organizations_url":"https://api.github.com/users/JonnyBurger/orgs","repos_url":"https://api.github.com/users/JonnyBurger/repos","events_url":"https://api.github.com/users/JonnyBurger/events{/privacy}","received_events_url":"https://api.github.com/users/JonnyBurger/received_events","type":"User","site_admin":false},"body":"This PR changes the behaviour so that entries in the `ignore` options that start with a `!` don't ignored. This is useful if you want to pass a list from `.gitignore` to the `ignore` option (as you do in `xo`).\r\n<hr>\r\nExample file structure:\r\n```\r\n├── a.js\r\n└─── b\r\n    ├── c.js\r\n    └── d.js\r\n```\r\nExample `.gitignore`\r\n```\r\nb/*\r\n!b/c.js\r\n```\r\nComputing which files would be added to Git:\r\n```js\r\nawait globby(`**/*`, {ignore: ['b/*', '!b/c.js']})\r\n// => before: []\r\n// => after: ['a.js', 'b/c.js']\r\n```\r\n\r\nRelated `xo` issue: https://github.com/sindresorhus/xo/issues/154","created_at":"2016-10-16T18:29:22Z","updated_at":"2016-10-16T19:25:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a34de6c4a71469ac82b906708b373e27c29555c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sindresorhus/globby/pulls/34/commits","review_comments_url":"https://api.github.com/repos/sindresorhus/globby/pulls/34/comments","review_comment_url":"https://api.github.com/repos/sindresorhus/globby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sindresorhus/globby/issues/34/comments","statuses_url":"https://api.github.com/repos/sindresorhus/globby/statuses/f1377353e1902b14d2ca7dff39dc2e81d2f2a372","head":{"label":"JonnyBurger:master","ref":"master","sha":"f1377353e1902b14d2ca7dff39dc2e81d2f2a372","user":{"login":"JonnyBurger","id":1629785,"avatar_url":"https://avatars.githubusercontent.com/u/1629785?v=3","gravatar_id":"","url":"https://api.github.com/users/JonnyBurger","html_url":"https://github.com/JonnyBurger","followers_url":"https://api.github.com/users/JonnyBurger/followers","following_url":"https://api.github.com/users/JonnyBurger/following{/other_user}","gists_url":"https://api.github.com/users/JonnyBurger/gists{/gist_id}","starred_url":"https://api.github.com/users/JonnyBurger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonnyBurger/subscriptions","organizations_url":"https://api.github.com/users/JonnyBurger/orgs","repos_url":"https://api.github.com/users/JonnyBurger/repos","events_url":"https://api.github.com/users/JonnyBurger/events{/privacy}","received_events_url":"https://api.github.com/users/JonnyBurger/received_events","type":"User","site_admin":false},"repo":{"id":71066846,"name":"globby","full_name":"JonnyBurger/globby","owner":{"login":"JonnyBurger","id":1629785,"avatar_url":"https://avatars.githubusercontent.com/u/1629785?v=3","gravatar_id":"","url":"https://api.github.com/users/JonnyBurger","html_url":"https://github.com/JonnyBurger","followers_url":"https://api.github.com/users/JonnyBurger/followers","following_url":"https://api.github.com/users/JonnyBurger/following{/other_user}","gists_url":"https://api.github.com/users/JonnyBurger/gists{/gist_id}","starred_url":"https://api.github.com/users/JonnyBurger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonnyBurger/subscriptions","organizations_url":"https://api.github.com/users/JonnyBurger/orgs","repos_url":"https://api.github.com/users/JonnyBurger/repos","events_url":"https://api.github.com/users/JonnyBurger/events{/privacy}","received_events_url":"https://api.github.com/users/JonnyBurger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JonnyBurger/globby","description":"Extends `glob` with support for multiple patterns","fork":true,"url":"https://api.github.com/repos/JonnyBurger/globby","forks_url":"https://api.github.com/repos/JonnyBurger/globby/forks","keys_url":"https://api.github.com/repos/JonnyBurger/globby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JonnyBurger/globby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JonnyBurger/globby/teams","hooks_url":"https://api.github.com/repos/JonnyBurger/globby/hooks","issue_events_url":"https://api.github.com/repos/JonnyBurger/globby/issues/events{/number}","events_url":"https://api.github.com/repos/JonnyBurger/globby/events","assignees_url":"https://api.github.com/repos/JonnyBurger/globby/assignees{/user}","branches_url":"https://api.github.com/repos/JonnyBurger/globby/branches{/branch}","tags_url":"https://api.github.com/repos/JonnyBurger/globby/tags","blobs_url":"https://api.github.com/repos/JonnyBurger/globby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JonnyBurger/globby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JonnyBurger/globby/git/refs{/sha}","trees_url":"https://api.github.com/repos/JonnyBurger/globby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JonnyBurger/globby/statuses/{sha}","languages_url":"https://api.github.com/repos/JonnyBurger/globby/languages","stargazers_url":"https://api.github.com/repos/JonnyBurger/globby/stargazers","contributors_url":"https://api.github.com/repos/JonnyBurger/globby/contributors","subscribers_url":"https://api.github.com/repos/JonnyBurger/globby/subscribers","subscription_url":"https://api.github.com/repos/JonnyBurger/globby/subscription","commits_url":"https://api.github.com/repos/JonnyBurger/globby/commits{/sha}","git_commits_url":"https://api.github.com/repos/JonnyBurger/globby/git/commits{/sha}","comments_url":"https://api.github.com/repos/JonnyBurger/globby/comments{/number}","issue_comment_url":"https://api.github.com/repos/JonnyBurger/globby/issues/comments{/number}","contents_url":"https://api.github.com/repos/JonnyBurger/globby/contents/{+path}","compare_url":"https://api.github.com/repos/JonnyBurger/globby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JonnyBurger/globby/merges","archive_url":"https://api.github.com/repos/JonnyBurger/globby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JonnyBurger/globby/downloads","issues_url":"https://api.github.com/repos/JonnyBurger/globby/issues{/number}","pulls_url":"https://api.github.com/repos/JonnyBurger/globby/pulls{/number}","milestones_url":"https://api.github.com/repos/JonnyBurger/globby/milestones{/number}","notifications_url":"https://api.github.com/repos/JonnyBurger/globby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JonnyBurger/globby/labels{/name}","releases_url":"https://api.github.com/repos/JonnyBurger/globby/releases{/id}","deployments_url":"https://api.github.com/repos/JonnyBurger/globby/deployments","created_at":"2016-10-16T17:47:23Z","updated_at":"2016-10-16T17:47:24Z","pushed_at":"2016-10-16T18:40:30Z","git_url":"git://github.com/JonnyBurger/globby.git","ssh_url":"git@github.com:JonnyBurger/globby.git","clone_url":"https://github.com/JonnyBurger/globby.git","svn_url":"https://github.com/JonnyBurger/globby","homepage":null,"size":38,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sindresorhus:master","ref":"master","sha":"f7fde2ecb6eaf773dea39e11a1dc704c3fc2dd38","user":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars.githubusercontent.com/u/170270?v=3","gravatar_id":"","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"repo":{"id":21069494,"name":"globby","full_name":"sindresorhus/globby","owner":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars.githubusercontent.com/u/170270?v=3","gravatar_id":"","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sindresorhus/globby","description":"Extends `glob` with support for multiple patterns","fork":false,"url":"https://api.github.com/repos/sindresorhus/globby","forks_url":"https://api.github.com/repos/sindresorhus/globby/forks","keys_url":"https://api.github.com/repos/sindresorhus/globby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sindresorhus/globby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sindresorhus/globby/teams","hooks_url":"https://api.github.com/repos/sindresorhus/globby/hooks","issue_events_url":"https://api.github.com/repos/sindresorhus/globby/issues/events{/number}","events_url":"https://api.github.com/repos/sindresorhus/globby/events","assignees_url":"https://api.github.com/repos/sindresorhus/globby/assignees{/user}","branches_url":"https://api.github.com/repos/sindresorhus/globby/branches{/branch}","tags_url":"https://api.github.com/repos/sindresorhus/globby/tags","blobs_url":"https://api.github.com/repos/sindresorhus/globby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sindresorhus/globby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sindresorhus/globby/git/refs{/sha}","trees_url":"https://api.github.com/repos/sindresorhus/globby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sindresorhus/globby/statuses/{sha}","languages_url":"https://api.github.com/repos/sindresorhus/globby/languages","stargazers_url":"https://api.github.com/repos/sindresorhus/globby/stargazers","contributors_url":"https://api.github.com/repos/sindresorhus/globby/contributors","subscribers_url":"https://api.github.com/repos/sindresorhus/globby/subscribers","subscription_url":"https://api.github.com/repos/sindresorhus/globby/subscription","commits_url":"https://api.github.com/repos/sindresorhus/globby/commits{/sha}","git_commits_url":"https://api.github.com/repos/sindresorhus/globby/git/commits{/sha}","comments_url":"https://api.github.com/repos/sindresorhus/globby/comments{/number}","issue_comment_url":"https://api.github.com/repos/sindresorhus/globby/issues/comments{/number}","contents_url":"https://api.github.com/repos/sindresorhus/globby/contents/{+path}","compare_url":"https://api.github.com/repos/sindresorhus/globby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sindresorhus/globby/merges","archive_url":"https://api.github.com/repos/sindresorhus/globby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sindresorhus/globby/downloads","issues_url":"https://api.github.com/repos/sindresorhus/globby/issues{/number}","pulls_url":"https://api.github.com/repos/sindresorhus/globby/pulls{/number}","milestones_url":"https://api.github.com/repos/sindresorhus/globby/milestones{/number}","notifications_url":"https://api.github.com/repos/sindresorhus/globby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sindresorhus/globby/labels{/name}","releases_url":"https://api.github.com/repos/sindresorhus/globby/releases{/id}","deployments_url":"https://api.github.com/repos/sindresorhus/globby/deployments","created_at":"2014-06-21T13:48:39Z","updated_at":"2016-10-14T08:09:40Z","pushed_at":"2016-10-16T18:40:30Z","git_url":"git://github.com/sindresorhus/globby.git","ssh_url":"git@github.com:sindresorhus/globby.git","clone_url":"https://github.com/sindresorhus/globby.git","svn_url":"https://github.com/sindresorhus/globby","homepage":null,"size":53,"stargazers_count":206,"watchers_count":206,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":3,"forks":15,"open_issues":3,"watchers":206,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sindresorhus/globby/pulls/34"},"html":{"href":"https://github.com/sindresorhus/globby/pull/34"},"issue":{"href":"https://api.github.com/repos/sindresorhus/globby/issues/34"},"comments":{"href":"https://api.github.com/repos/sindresorhus/globby/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/sindresorhus/globby/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/sindresorhus/globby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sindresorhus/globby/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/sindresorhus/globby/statuses/f1377353e1902b14d2ca7dff39dc2e81d2f2a372"}}}}
{"actor":{"display_login":"schnittstabil"}}