{"action":"created","comment":{"url":"https://api.github.com/repos/yopeso/Taylor/pulls/comments/86625336","pull_request_review_id":7262731,"id":86625336,"diff_hunk":"@@ -262,33 +262,81 @@ class OptionsProcessorTests: QuickSpec {\n                     \n                     it(\"should set default values only for keys that was not indicated\") {\n                         var dictionary = [ResultDictionaryTypeKey : [\"someType\"]]\n-                        optionsProcessor.setDefaultValuesToResultDictionary(&dictionary)\n-                        expect(dictionary).to(equal([ResultDictionaryPathKey : [currentPath], ResultDictionaryTypeKey : [\"someType\"]]))\n+                        optionsProcessor.setDefaultValuesToResultDictionary(dictionary: &dictionary)\n+                        expect(dictionary == [ResultDictionaryPathKey : [currentPath], ResultDictionaryTypeKey : [\"someType\"]]).to(beTrue())\n                     }\n                     \n                     it(\"should set default values for dictionary\") {\n                         var dictionary = Options()\n-                        optionsProcessor.setDefaultValuesToResultDictionary(&dictionary)\n-                        expect(dictionary).to(equal([ResultDictionaryPathKey : [currentPath], ResultDictionaryTypeKey : [DefaultExtensionType]]))\n+                        optionsProcessor.setDefaultValuesToResultDictionary(dictionary: &dictionary)\n+                        expect(dictionary == [ResultDictionaryPathKey : [currentPath], ResultDictionaryTypeKey : [DefaultExtensionType]]).to(beTrue())\n                     }\n                     \n                     it(\"should not change values if they are already setted\") {\n                         var dictionary = [ResultDictionaryPathKey : [\"SomePath\"], ResultDictionaryTypeKey : [\"SomeExtension\"]]\n-                        optionsProcessor.setDefaultValuesToResultDictionary(&dictionary)\n-                        expect(dictionary).to(equal([ResultDictionaryPathKey : [\"SomePath\"], ResultDictionaryTypeKey : [\"SomeExtension\"]]))\n+                        optionsProcessor.setDefaultValuesToResultDictionary(dictionary: &dictionary)\n+                        expect(dictionary == [ResultDictionaryPathKey : [\"SomePath\"], ResultDictionaryTypeKey : [\"SomeExtension\"]]).to(beTrue())\n                     }\n                     \n                     it(\"should set exclude paths from default excludesFile\") {\n                         let pathToExcludesFile = MockFileManager().testFile(\"excludes\", fileType: \"yml\")\n-                        let pathToExcludesFileRootFolder = pathToExcludesFile.stringByReplacingOccurrencesOfString(\"/excludes.yml\", withString: \"\")\n+                        let pathToExcludesFileRootFolder = pathToExcludesFile.replacingOccurrences(of: \"/excludes.yml\", with: \"\")\n                         var dictionary = [ResultDictionaryPathKey : [pathToExcludesFileRootFolder]]\n-                        optionsProcessor.setDefaultValuesToResultDictionary(&dictionary)\n+                        optionsProcessor.setDefaultValuesToResultDictionary(dictionary: &dictionary)\n                         let resultsArrayOfExcludes = [\"file.txt\".formattedExcludePath(pathToExcludesFileRootFolder), \"path/to/file.txt\".formattedExcludePath(pathToExcludesFileRootFolder), \"folder\".formattedExcludePath(pathToExcludesFileRootFolder), \"path/to/folder\".formattedExcludePath(pathToExcludesFileRootFolder)]\n-                        expect(dictionary).to(equal([ResultDictionaryPathKey : [pathToExcludesFileRootFolder], ResultDictionaryTypeKey : [DefaultExtensionType], ResultDictionaryExcludesKey : resultsArrayOfExcludes]))\n+                        expect(dictionary == [ResultDictionaryPathKey : [pathToExcludesFileRootFolder], ResultDictionaryTypeKey : [DefaultExtensionType], ResultDictionaryExcludesKey : resultsArrayOfExcludes]).to(beTrue())\n                     }\n                     \n                 }\n             }\n         }\n     }\n }\n+\n+\n+//TODO: Check if overload == operators are the best choice\n+func ==(lhs: [String: String], rhs: [String: String]) -> Bool {\n+    if lhs.count != rhs.count { return false }\n+    \n+    for (key, lhsub) in lhs {\n+        if let rhsub = rhs[key] {\n+            if lhsub != rhsub {\n+                return false\n+            }\n+        } else {\n+            return false\n+        }\n+    }\n+    \n+    return true\n+}\n+\n+func ==(lhs: [String: [String]], rhs: [String: [String]]) -> Bool {","path":"TaylorFrameworkTests/CapriceTests/Tests/OptionsProcessorTests.swift","position":183,"original_position":183,"commit_id":"f479c207950894356ad39770f892a8da335108a5","original_commit_id":"f479c207950894356ad39770f892a8da335108a5","user":{"login":"S2dentik","id":13215590,"avatar_url":"https://avatars.githubusercontent.com/u/13215590?v=3","gravatar_id":"","url":"https://api.github.com/users/S2dentik","html_url":"https://github.com/S2dentik","followers_url":"https://api.github.com/users/S2dentik/followers","following_url":"https://api.github.com/users/S2dentik/following{/other_user}","gists_url":"https://api.github.com/users/S2dentik/gists{/gist_id}","starred_url":"https://api.github.com/users/S2dentik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/S2dentik/subscriptions","organizations_url":"https://api.github.com/users/S2dentik/orgs","repos_url":"https://api.github.com/users/S2dentik/repos","events_url":"https://api.github.com/users/S2dentik/events{/privacy}","received_events_url":"https://api.github.com/users/S2dentik/received_events","type":"User","site_admin":false},"body":"Consider\r\n```\r\nfunc ==<U: Hashable, T: Sequence>(lhs: [U: T], rhs: [U: T]) -> Bool where T.Iterator.Element: Equatable {\r\n    guard lhs.count == rhs.count else { return false }\r\n    for (key, lValue) in lhs {\r\n        guard let rValue = rhs[key], Array(lValue) == Array(rValue) else {\r\n            return false\r\n        }\r\n    }\r\n    return true\r\n}\r\n```","created_at":"2016-11-04T20:20:50Z","updated_at":"2016-11-04T20:23:46Z","html_url":"https://github.com/yopeso/Taylor/pull/38#discussion_r86625336","pull_request_url":"https://api.github.com/repos/yopeso/Taylor/pulls/38","_links":{"self":{"href":"https://api.github.com/repos/yopeso/Taylor/pulls/comments/86625336"},"html":{"href":"https://github.com/yopeso/Taylor/pull/38#discussion_r86625336"},"pull_request":{"href":"https://api.github.com/repos/yopeso/Taylor/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/yopeso/Taylor/pulls/38","id":92374374,"html_url":"https://github.com/yopeso/Taylor/pull/38","diff_url":"https://github.com/yopeso/Taylor/pull/38.diff","patch_url":"https://github.com/yopeso/Taylor/pull/38.patch","issue_url":"https://api.github.com/repos/yopeso/Taylor/issues/38","number":38,"state":"open","locked":false,"title":"Migrate to Swift 3.0.1","user":{"login":"SunnyPRO","id":8161354,"avatar_url":"https://avatars.githubusercontent.com/u/8161354?v=3","gravatar_id":"","url":"https://api.github.com/users/SunnyPRO","html_url":"https://github.com/SunnyPRO","followers_url":"https://api.github.com/users/SunnyPRO/followers","following_url":"https://api.github.com/users/SunnyPRO/following{/other_user}","gists_url":"https://api.github.com/users/SunnyPRO/gists{/gist_id}","starred_url":"https://api.github.com/users/SunnyPRO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SunnyPRO/subscriptions","organizations_url":"https://api.github.com/users/SunnyPRO/orgs","repos_url":"https://api.github.com/users/SunnyPRO/repos","events_url":"https://api.github.com/users/SunnyPRO/events{/privacy}","received_events_url":"https://api.github.com/users/SunnyPRO/received_events","type":"User","site_admin":false},"body":"Migrated the codebase to Swift 3.0.0/3.0.1 specifications and changes. \r\nFixed some unit test and rebuilt SourceKitten.","created_at":"2016-11-04T16:38:39Z","updated_at":"2016-11-04T20:23:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b80676e6570966e6a78f72767a4323c5ab2bd69","assignee":{"login":"S2dentik","id":13215590,"avatar_url":"https://avatars.githubusercontent.com/u/13215590?v=3","gravatar_id":"","url":"https://api.github.com/users/S2dentik","html_url":"https://github.com/S2dentik","followers_url":"https://api.github.com/users/S2dentik/followers","following_url":"https://api.github.com/users/S2dentik/following{/other_user}","gists_url":"https://api.github.com/users/S2dentik/gists{/gist_id}","starred_url":"https://api.github.com/users/S2dentik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/S2dentik/subscriptions","organizations_url":"https://api.github.com/users/S2dentik/orgs","repos_url":"https://api.github.com/users/S2dentik/repos","events_url":"https://api.github.com/users/S2dentik/events{/privacy}","received_events_url":"https://api.github.com/users/S2dentik/received_events","type":"User","site_admin":false},"assignees":[{"login":"S2dentik","id":13215590,"avatar_url":"https://avatars.githubusercontent.com/u/13215590?v=3","gravatar_id":"","url":"https://api.github.com/users/S2dentik","html_url":"https://github.com/S2dentik","followers_url":"https://api.github.com/users/S2dentik/followers","following_url":"https://api.github.com/users/S2dentik/following{/other_user}","gists_url":"https://api.github.com/users/S2dentik/gists{/gist_id}","starred_url":"https://api.github.com/users/S2dentik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/S2dentik/subscriptions","organizations_url":"https://api.github.com/users/S2dentik/orgs","repos_url":"https://api.github.com/users/S2dentik/repos","events_url":"https://api.github.com/users/S2dentik/events{/privacy}","received_events_url":"https://api.github.com/users/S2dentik/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/yopeso/Taylor/pulls/38/commits","review_comments_url":"https://api.github.com/repos/yopeso/Taylor/pulls/38/comments","review_comment_url":"https://api.github.com/repos/yopeso/Taylor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yopeso/Taylor/issues/38/comments","statuses_url":"https://api.github.com/repos/yopeso/Taylor/statuses/f479c207950894356ad39770f892a8da335108a5","head":{"label":"SunnyPRO:master","ref":"master","sha":"f479c207950894356ad39770f892a8da335108a5","user":{"login":"SunnyPRO","id":8161354,"avatar_url":"https://avatars.githubusercontent.com/u/8161354?v=3","gravatar_id":"","url":"https://api.github.com/users/SunnyPRO","html_url":"https://github.com/SunnyPRO","followers_url":"https://api.github.com/users/SunnyPRO/followers","following_url":"https://api.github.com/users/SunnyPRO/following{/other_user}","gists_url":"https://api.github.com/users/SunnyPRO/gists{/gist_id}","starred_url":"https://api.github.com/users/SunnyPRO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SunnyPRO/subscriptions","organizations_url":"https://api.github.com/users/SunnyPRO/orgs","repos_url":"https://api.github.com/users/SunnyPRO/repos","events_url":"https://api.github.com/users/SunnyPRO/events{/privacy}","received_events_url":"https://api.github.com/users/SunnyPRO/received_events","type":"User","site_admin":false},"repo":{"id":71579643,"name":"Taylor","full_name":"SunnyPRO/Taylor","owner":{"login":"SunnyPRO","id":8161354,"avatar_url":"https://avatars.githubusercontent.com/u/8161354?v=3","gravatar_id":"","url":"https://api.github.com/users/SunnyPRO","html_url":"https://github.com/SunnyPRO","followers_url":"https://api.github.com/users/SunnyPRO/followers","following_url":"https://api.github.com/users/SunnyPRO/following{/other_user}","gists_url":"https://api.github.com/users/SunnyPRO/gists{/gist_id}","starred_url":"https://api.github.com/users/SunnyPRO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SunnyPRO/subscriptions","organizations_url":"https://api.github.com/users/SunnyPRO/orgs","repos_url":"https://api.github.com/users/SunnyPRO/repos","events_url":"https://api.github.com/users/SunnyPRO/events{/privacy}","received_events_url":"https://api.github.com/users/SunnyPRO/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SunnyPRO/Taylor","description":"Measure Swift code metrics and get reports in Xcode, Jenkins and other CI platforms.","fork":true,"url":"https://api.github.com/repos/SunnyPRO/Taylor","forks_url":"https://api.github.com/repos/SunnyPRO/Taylor/forks","keys_url":"https://api.github.com/repos/SunnyPRO/Taylor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SunnyPRO/Taylor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SunnyPRO/Taylor/teams","hooks_url":"https://api.github.com/repos/SunnyPRO/Taylor/hooks","issue_events_url":"https://api.github.com/repos/SunnyPRO/Taylor/issues/events{/number}","events_url":"https://api.github.com/repos/SunnyPRO/Taylor/events","assignees_url":"https://api.github.com/repos/SunnyPRO/Taylor/assignees{/user}","branches_url":"https://api.github.com/repos/SunnyPRO/Taylor/branches{/branch}","tags_url":"https://api.github.com/repos/SunnyPRO/Taylor/tags","blobs_url":"https://api.github.com/repos/SunnyPRO/Taylor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SunnyPRO/Taylor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SunnyPRO/Taylor/git/refs{/sha}","trees_url":"https://api.github.com/repos/SunnyPRO/Taylor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SunnyPRO/Taylor/statuses/{sha}","languages_url":"https://api.github.com/repos/SunnyPRO/Taylor/languages","stargazers_url":"https://api.github.com/repos/SunnyPRO/Taylor/stargazers","contributors_url":"https://api.github.com/repos/SunnyPRO/Taylor/contributors","subscribers_url":"https://api.github.com/repos/SunnyPRO/Taylor/subscribers","subscription_url":"https://api.github.com/repos/SunnyPRO/Taylor/subscription","commits_url":"https://api.github.com/repos/SunnyPRO/Taylor/commits{/sha}","git_commits_url":"https://api.github.com/repos/SunnyPRO/Taylor/git/commits{/sha}","comments_url":"https://api.github.com/repos/SunnyPRO/Taylor/comments{/number}","issue_comment_url":"https://api.github.com/repos/SunnyPRO/Taylor/issues/comments{/number}","contents_url":"https://api.github.com/repos/SunnyPRO/Taylor/contents/{+path}","compare_url":"https://api.github.com/repos/SunnyPRO/Taylor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SunnyPRO/Taylor/merges","archive_url":"https://api.github.com/repos/SunnyPRO/Taylor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SunnyPRO/Taylor/downloads","issues_url":"https://api.github.com/repos/SunnyPRO/Taylor/issues{/number}","pulls_url":"https://api.github.com/repos/SunnyPRO/Taylor/pulls{/number}","milestones_url":"https://api.github.com/repos/SunnyPRO/Taylor/milestones{/number}","notifications_url":"https://api.github.com/repos/SunnyPRO/Taylor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SunnyPRO/Taylor/labels{/name}","releases_url":"https://api.github.com/repos/SunnyPRO/Taylor/releases{/id}","deployments_url":"https://api.github.com/repos/SunnyPRO/Taylor/deployments","created_at":"2016-10-21T15:50:57Z","updated_at":"2016-10-21T15:51:00Z","pushed_at":"2016-11-04T16:46:02Z","git_url":"git://github.com/SunnyPRO/Taylor.git","ssh_url":"git@github.com:SunnyPRO/Taylor.git","clone_url":"https://github.com/SunnyPRO/Taylor.git","svn_url":"https://github.com/SunnyPRO/Taylor","homepage":null,"size":31229,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yopeso:master","ref":"master","sha":"8e7219312956f2c207f2f16a32a34f9dfcd059c3","user":{"login":"yopeso","id":15382353,"avatar_url":"https://avatars.githubusercontent.com/u/15382353?v=3","gravatar_id":"","url":"https://api.github.com/users/yopeso","html_url":"https://github.com/yopeso","followers_url":"https://api.github.com/users/yopeso/followers","following_url":"https://api.github.com/users/yopeso/following{/other_user}","gists_url":"https://api.github.com/users/yopeso/gists{/gist_id}","starred_url":"https://api.github.com/users/yopeso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yopeso/subscriptions","organizations_url":"https://api.github.com/users/yopeso/orgs","repos_url":"https://api.github.com/users/yopeso/repos","events_url":"https://api.github.com/users/yopeso/events{/privacy}","received_events_url":"https://api.github.com/users/yopeso/received_events","type":"Organization","site_admin":false},"repo":{"id":46943782,"name":"Taylor","full_name":"yopeso/Taylor","owner":{"login":"yopeso","id":15382353,"avatar_url":"https://avatars.githubusercontent.com/u/15382353?v=3","gravatar_id":"","url":"https://api.github.com/users/yopeso","html_url":"https://github.com/yopeso","followers_url":"https://api.github.com/users/yopeso/followers","following_url":"https://api.github.com/users/yopeso/following{/other_user}","gists_url":"https://api.github.com/users/yopeso/gists{/gist_id}","starred_url":"https://api.github.com/users/yopeso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yopeso/subscriptions","organizations_url":"https://api.github.com/users/yopeso/orgs","repos_url":"https://api.github.com/users/yopeso/repos","events_url":"https://api.github.com/users/yopeso/events{/privacy}","received_events_url":"https://api.github.com/users/yopeso/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yopeso/Taylor","description":"Measure Swift code metrics and get reports in Xcode, Jenkins and other CI platforms.","fork":false,"url":"https://api.github.com/repos/yopeso/Taylor","forks_url":"https://api.github.com/repos/yopeso/Taylor/forks","keys_url":"https://api.github.com/repos/yopeso/Taylor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yopeso/Taylor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yopeso/Taylor/teams","hooks_url":"https://api.github.com/repos/yopeso/Taylor/hooks","issue_events_url":"https://api.github.com/repos/yopeso/Taylor/issues/events{/number}","events_url":"https://api.github.com/repos/yopeso/Taylor/events","assignees_url":"https://api.github.com/repos/yopeso/Taylor/assignees{/user}","branches_url":"https://api.github.com/repos/yopeso/Taylor/branches{/branch}","tags_url":"https://api.github.com/repos/yopeso/Taylor/tags","blobs_url":"https://api.github.com/repos/yopeso/Taylor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yopeso/Taylor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yopeso/Taylor/git/refs{/sha}","trees_url":"https://api.github.com/repos/yopeso/Taylor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yopeso/Taylor/statuses/{sha}","languages_url":"https://api.github.com/repos/yopeso/Taylor/languages","stargazers_url":"https://api.github.com/repos/yopeso/Taylor/stargazers","contributors_url":"https://api.github.com/repos/yopeso/Taylor/contributors","subscribers_url":"https://api.github.com/repos/yopeso/Taylor/subscribers","subscription_url":"https://api.github.com/repos/yopeso/Taylor/subscription","commits_url":"https://api.github.com/repos/yopeso/Taylor/commits{/sha}","git_commits_url":"https://api.github.com/repos/yopeso/Taylor/git/commits{/sha}","comments_url":"https://api.github.com/repos/yopeso/Taylor/comments{/number}","issue_comment_url":"https://api.github.com/repos/yopeso/Taylor/issues/comments{/number}","contents_url":"https://api.github.com/repos/yopeso/Taylor/contents/{+path}","compare_url":"https://api.github.com/repos/yopeso/Taylor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yopeso/Taylor/merges","archive_url":"https://api.github.com/repos/yopeso/Taylor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yopeso/Taylor/downloads","issues_url":"https://api.github.com/repos/yopeso/Taylor/issues{/number}","pulls_url":"https://api.github.com/repos/yopeso/Taylor/pulls{/number}","milestones_url":"https://api.github.com/repos/yopeso/Taylor/milestones{/number}","notifications_url":"https://api.github.com/repos/yopeso/Taylor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yopeso/Taylor/labels{/name}","releases_url":"https://api.github.com/repos/yopeso/Taylor/releases{/id}","deployments_url":"https://api.github.com/repos/yopeso/Taylor/deployments","created_at":"2015-11-26T19:30:46Z","updated_at":"2016-11-01T10:22:06Z","pushed_at":"2016-11-04T16:46:02Z","git_url":"git://github.com/yopeso/Taylor.git","ssh_url":"git@github.com:yopeso/Taylor.git","clone_url":"https://github.com/yopeso/Taylor.git","svn_url":"https://github.com/yopeso/Taylor","homepage":null,"size":20043,"stargazers_count":126,"watchers_count":126,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":1,"forks":12,"open_issues":1,"watchers":126,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yopeso/Taylor/pulls/38"},"html":{"href":"https://github.com/yopeso/Taylor/pull/38"},"issue":{"href":"https://api.github.com/repos/yopeso/Taylor/issues/38"},"comments":{"href":"https://api.github.com/repos/yopeso/Taylor/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/yopeso/Taylor/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/yopeso/Taylor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yopeso/Taylor/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/yopeso/Taylor/statuses/f479c207950894356ad39770f892a8da335108a5"}}}}
{"actor":{"display_login":"S2dentik"}}