{"action":"created","comment":{"url":"https://api.github.com/repos/uberfire/uberfire/pulls/comments/93076130","pull_request_review_id":13597585,"id":93076130,"diff_hunk":"@@ -185,28 +141,48 @@ public HasWidgets getPerspectiveContainer() {\n         return perspectiveRootContainer;\n     }\n \n-    private void setHeaderContents( List<Header> headers ) {\n+    void setHeaderContents( List<IsHeader> headers ) {\n         headerPanel.clear();\n         root.remove( headerPanel );\n         if ( !headers.isEmpty() ) {\n-            for ( Header h : headers ) {\n-                headerPanel.add( h );\n+            for ( IsHeader h : headers ) {\n+                addHeader( h );\n             }\n             root.setHeaderWidget( headerPanel );\n         }\n     }\n \n-    private void setFooterContents( List<Footer> footers ) {\n+    private void addHeader( IsHeader h ) {\n+        if ( h instanceof HeaderElement ) {\n+            headerPanel.add( extractWidgetFrom( ( IsElement ) h ) );\n+        } else if ( h instanceof Header ) {\n+            headerPanel.add( ( IsWidget ) h );\n+        }\n+    }\n+\n+    void setFooterContents( List<IsFooter> footers ) {\n         footerPanel.clear();\n         root.remove( footerPanel );\n         if ( !footers.isEmpty() ) {\n-            for ( Footer f : footers ) {\n-                footerPanel.add( f );\n+            for ( IsFooter f : footers ) {\n+                addFooter( f );\n             }\n             root.setFooterWidget( footerPanel );\n         }\n     }\n \n+    private void addFooter( IsFooter f ) {\n+        if ( f instanceof FooterElement ) {\n+            footerPanel.add( extractWidgetFrom( ( IsElement ) f ) );\n+        } else if ( f instanceof Footer ) {\n+            footerPanel.add( ( IsWidget ) f );\n+        }\n+    }\n+\n+    ElementWrapperWidget<?> extractWidgetFrom( IsElement h ) {","path":"uberfire-workbench/uberfire-workbench-client/src/main/java/org/uberfire/client/workbench/WorkbenchLayoutImpl.java","position":205,"original_position":205,"commit_id":"6f4e8ebad03c40057bd1bbdfba42077ff346029a","original_commit_id":"6f4e8ebad03c40057bd1bbdfba42077ff346029a","user":{"login":"csadilek","id":472523,"avatar_url":"https://avatars.githubusercontent.com/u/472523?v=3","gravatar_id":"","url":"https://api.github.com/users/csadilek","html_url":"https://github.com/csadilek","followers_url":"https://api.github.com/users/csadilek/followers","following_url":"https://api.github.com/users/csadilek/following{/other_user}","gists_url":"https://api.github.com/users/csadilek/gists{/gist_id}","starred_url":"https://api.github.com/users/csadilek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csadilek/subscriptions","organizations_url":"https://api.github.com/users/csadilek/orgs","repos_url":"https://api.github.com/users/csadilek/repos","events_url":"https://api.github.com/users/csadilek/events{/privacy}","received_events_url":"https://api.github.com/users/csadilek/received_events","type":"User","site_admin":false},"body":"Better name would be createWidgetFrom/For or wrapElement...as nothing here gets extracted.","created_at":"2016-12-19T17:12:41Z","updated_at":"2016-12-19T17:16:12Z","html_url":"https://github.com/uberfire/uberfire/pull/573#discussion_r93076130","pull_request_url":"https://api.github.com/repos/uberfire/uberfire/pulls/573","_links":{"self":{"href":"https://api.github.com/repos/uberfire/uberfire/pulls/comments/93076130"},"html":{"href":"https://github.com/uberfire/uberfire/pull/573#discussion_r93076130"},"pull_request":{"href":"https://api.github.com/repos/uberfire/uberfire/pulls/573"}}},"pull_request":{"url":"https://api.github.com/repos/uberfire/uberfire/pulls/573","id":95755040,"html_url":"https://github.com/uberfire/uberfire/pull/573","diff_url":"https://github.com/uberfire/uberfire/pull/573.diff","patch_url":"https://github.com/uberfire/uberfire/pull/573.patch","issue_url":"https://api.github.com/repos/uberfire/uberfire/issues/573","number":573,"state":"open","locked":false,"title":"[UF-443] - Header and Footer should support Errai UI","user":{"login":"ederign","id":531351,"avatar_url":"https://avatars.githubusercontent.com/u/531351?v=3","gravatar_id":"","url":"https://api.github.com/users/ederign","html_url":"https://github.com/ederign","followers_url":"https://api.github.com/users/ederign/followers","following_url":"https://api.github.com/users/ederign/following{/other_user}","gists_url":"https://api.github.com/users/ederign/gists{/gist_id}","starred_url":"https://api.github.com/users/ederign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ederign/subscriptions","organizations_url":"https://api.github.com/users/ederign/orgs","repos_url":"https://api.github.com/users/ederign/repos","events_url":"https://api.github.com/users/ederign/events{/privacy}","received_events_url":"https://api.github.com/users/ederign/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-29T19:07:39Z","updated_at":"2016-12-19T17:16:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2496bf108dc0795286e87e194cb2ef6183e83d00","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/uberfire/uberfire/pulls/573/commits","review_comments_url":"https://api.github.com/repos/uberfire/uberfire/pulls/573/comments","review_comment_url":"https://api.github.com/repos/uberfire/uberfire/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uberfire/uberfire/issues/573/comments","statuses_url":"https://api.github.com/repos/uberfire/uberfire/statuses/6f4e8ebad03c40057bd1bbdfba42077ff346029a","head":{"label":"ederign:header-footer-errai-ui-support","ref":"header-footer-errai-ui-support","sha":"6f4e8ebad03c40057bd1bbdfba42077ff346029a","user":{"login":"ederign","id":531351,"avatar_url":"https://avatars.githubusercontent.com/u/531351?v=3","gravatar_id":"","url":"https://api.github.com/users/ederign","html_url":"https://github.com/ederign","followers_url":"https://api.github.com/users/ederign/followers","following_url":"https://api.github.com/users/ederign/following{/other_user}","gists_url":"https://api.github.com/users/ederign/gists{/gist_id}","starred_url":"https://api.github.com/users/ederign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ederign/subscriptions","organizations_url":"https://api.github.com/users/ederign/orgs","repos_url":"https://api.github.com/users/ederign/repos","events_url":"https://api.github.com/users/ederign/events{/privacy}","received_events_url":"https://api.github.com/users/ederign/received_events","type":"User","site_admin":false},"repo":{"id":71365079,"name":"uberfire","full_name":"ederign/uberfire","owner":{"login":"ederign","id":531351,"avatar_url":"https://avatars.githubusercontent.com/u/531351?v=3","gravatar_id":"","url":"https://api.github.com/users/ederign","html_url":"https://github.com/ederign","followers_url":"https://api.github.com/users/ederign/followers","following_url":"https://api.github.com/users/ederign/following{/other_user}","gists_url":"https://api.github.com/users/ederign/gists{/gist_id}","starred_url":"https://api.github.com/users/ederign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ederign/subscriptions","organizations_url":"https://api.github.com/users/ederign/orgs","repos_url":"https://api.github.com/users/ederign/repos","events_url":"https://api.github.com/users/ederign/events{/privacy}","received_events_url":"https://api.github.com/users/ederign/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ederign/uberfire","description":"Uberfire Framework","fork":true,"url":"https://api.github.com/repos/ederign/uberfire","forks_url":"https://api.github.com/repos/ederign/uberfire/forks","keys_url":"https://api.github.com/repos/ederign/uberfire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ederign/uberfire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ederign/uberfire/teams","hooks_url":"https://api.github.com/repos/ederign/uberfire/hooks","issue_events_url":"https://api.github.com/repos/ederign/uberfire/issues/events{/number}","events_url":"https://api.github.com/repos/ederign/uberfire/events","assignees_url":"https://api.github.com/repos/ederign/uberfire/assignees{/user}","branches_url":"https://api.github.com/repos/ederign/uberfire/branches{/branch}","tags_url":"https://api.github.com/repos/ederign/uberfire/tags","blobs_url":"https://api.github.com/repos/ederign/uberfire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ederign/uberfire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ederign/uberfire/git/refs{/sha}","trees_url":"https://api.github.com/repos/ederign/uberfire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ederign/uberfire/statuses/{sha}","languages_url":"https://api.github.com/repos/ederign/uberfire/languages","stargazers_url":"https://api.github.com/repos/ederign/uberfire/stargazers","contributors_url":"https://api.github.com/repos/ederign/uberfire/contributors","subscribers_url":"https://api.github.com/repos/ederign/uberfire/subscribers","subscription_url":"https://api.github.com/repos/ederign/uberfire/subscription","commits_url":"https://api.github.com/repos/ederign/uberfire/commits{/sha}","git_commits_url":"https://api.github.com/repos/ederign/uberfire/git/commits{/sha}","comments_url":"https://api.github.com/repos/ederign/uberfire/comments{/number}","issue_comment_url":"https://api.github.com/repos/ederign/uberfire/issues/comments{/number}","contents_url":"https://api.github.com/repos/ederign/uberfire/contents/{+path}","compare_url":"https://api.github.com/repos/ederign/uberfire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ederign/uberfire/merges","archive_url":"https://api.github.com/repos/ederign/uberfire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ederign/uberfire/downloads","issues_url":"https://api.github.com/repos/ederign/uberfire/issues{/number}","pulls_url":"https://api.github.com/repos/ederign/uberfire/pulls{/number}","milestones_url":"https://api.github.com/repos/ederign/uberfire/milestones{/number}","notifications_url":"https://api.github.com/repos/ederign/uberfire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ederign/uberfire/labels{/name}","releases_url":"https://api.github.com/repos/ederign/uberfire/releases{/id}","deployments_url":"https://api.github.com/repos/ederign/uberfire/deployments","created_at":"2016-10-19T14:21:23Z","updated_at":"2016-10-19T14:21:35Z","pushed_at":"2016-12-13T22:27:51Z","git_url":"git://github.com/ederign/uberfire.git","ssh_url":"git@github.com:ederign/uberfire.git","clone_url":"https://github.com/ederign/uberfire.git","svn_url":"https://github.com/ederign/uberfire","homepage":"http://www.uberfireframework.org","size":36916,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uberfire:master","ref":"master","sha":"52b53cb26c075705426415cd4be031a25cc20d83","user":{"login":"uberfire","id":5167699,"avatar_url":"https://avatars.githubusercontent.com/u/5167699?v=3","gravatar_id":"","url":"https://api.github.com/users/uberfire","html_url":"https://github.com/uberfire","followers_url":"https://api.github.com/users/uberfire/followers","following_url":"https://api.github.com/users/uberfire/following{/other_user}","gists_url":"https://api.github.com/users/uberfire/gists{/gist_id}","starred_url":"https://api.github.com/users/uberfire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uberfire/subscriptions","organizations_url":"https://api.github.com/users/uberfire/orgs","repos_url":"https://api.github.com/users/uberfire/repos","events_url":"https://api.github.com/users/uberfire/events{/privacy}","received_events_url":"https://api.github.com/users/uberfire/received_events","type":"Organization","site_admin":false},"repo":{"id":4335576,"name":"uberfire","full_name":"uberfire/uberfire","owner":{"login":"uberfire","id":5167699,"avatar_url":"https://avatars.githubusercontent.com/u/5167699?v=3","gravatar_id":"","url":"https://api.github.com/users/uberfire","html_url":"https://github.com/uberfire","followers_url":"https://api.github.com/users/uberfire/followers","following_url":"https://api.github.com/users/uberfire/following{/other_user}","gists_url":"https://api.github.com/users/uberfire/gists{/gist_id}","starred_url":"https://api.github.com/users/uberfire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uberfire/subscriptions","organizations_url":"https://api.github.com/users/uberfire/orgs","repos_url":"https://api.github.com/users/uberfire/repos","events_url":"https://api.github.com/users/uberfire/events{/privacy}","received_events_url":"https://api.github.com/users/uberfire/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uberfire/uberfire","description":"Uberfire Framework","fork":false,"url":"https://api.github.com/repos/uberfire/uberfire","forks_url":"https://api.github.com/repos/uberfire/uberfire/forks","keys_url":"https://api.github.com/repos/uberfire/uberfire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uberfire/uberfire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uberfire/uberfire/teams","hooks_url":"https://api.github.com/repos/uberfire/uberfire/hooks","issue_events_url":"https://api.github.com/repos/uberfire/uberfire/issues/events{/number}","events_url":"https://api.github.com/repos/uberfire/uberfire/events","assignees_url":"https://api.github.com/repos/uberfire/uberfire/assignees{/user}","branches_url":"https://api.github.com/repos/uberfire/uberfire/branches{/branch}","tags_url":"https://api.github.com/repos/uberfire/uberfire/tags","blobs_url":"https://api.github.com/repos/uberfire/uberfire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uberfire/uberfire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uberfire/uberfire/git/refs{/sha}","trees_url":"https://api.github.com/repos/uberfire/uberfire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uberfire/uberfire/statuses/{sha}","languages_url":"https://api.github.com/repos/uberfire/uberfire/languages","stargazers_url":"https://api.github.com/repos/uberfire/uberfire/stargazers","contributors_url":"https://api.github.com/repos/uberfire/uberfire/contributors","subscribers_url":"https://api.github.com/repos/uberfire/uberfire/subscribers","subscription_url":"https://api.github.com/repos/uberfire/uberfire/subscription","commits_url":"https://api.github.com/repos/uberfire/uberfire/commits{/sha}","git_commits_url":"https://api.github.com/repos/uberfire/uberfire/git/commits{/sha}","comments_url":"https://api.github.com/repos/uberfire/uberfire/comments{/number}","issue_comment_url":"https://api.github.com/repos/uberfire/uberfire/issues/comments{/number}","contents_url":"https://api.github.com/repos/uberfire/uberfire/contents/{+path}","compare_url":"https://api.github.com/repos/uberfire/uberfire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uberfire/uberfire/merges","archive_url":"https://api.github.com/repos/uberfire/uberfire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uberfire/uberfire/downloads","issues_url":"https://api.github.com/repos/uberfire/uberfire/issues{/number}","pulls_url":"https://api.github.com/repos/uberfire/uberfire/pulls{/number}","milestones_url":"https://api.github.com/repos/uberfire/uberfire/milestones{/number}","notifications_url":"https://api.github.com/repos/uberfire/uberfire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uberfire/uberfire/labels{/name}","releases_url":"https://api.github.com/repos/uberfire/uberfire/releases{/id}","deployments_url":"https://api.github.com/repos/uberfire/uberfire/deployments","created_at":"2012-05-15T12:40:55Z","updated_at":"2016-12-17T03:49:41Z","pushed_at":"2016-12-19T16:45:54Z","git_url":"git://github.com/uberfire/uberfire.git","ssh_url":"git@github.com:uberfire/uberfire.git","clone_url":"https://github.com/uberfire/uberfire.git","svn_url":"https://github.com/uberfire/uberfire","homepage":"http://www.uberfireframework.org","size":37057,"stargazers_count":72,"watchers_count":72,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":107,"mirror_url":null,"open_issues_count":4,"forks":107,"open_issues":4,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uberfire/uberfire/pulls/573"},"html":{"href":"https://github.com/uberfire/uberfire/pull/573"},"issue":{"href":"https://api.github.com/repos/uberfire/uberfire/issues/573"},"comments":{"href":"https://api.github.com/repos/uberfire/uberfire/issues/573/comments"},"review_comments":{"href":"https://api.github.com/repos/uberfire/uberfire/pulls/573/comments"},"review_comment":{"href":"https://api.github.com/repos/uberfire/uberfire/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uberfire/uberfire/pulls/573/commits"},"statuses":{"href":"https://api.github.com/repos/uberfire/uberfire/statuses/6f4e8ebad03c40057bd1bbdfba42077ff346029a"}}}}
{"actor":{"display_login":"csadilek"}}