{"action":"created","comment":{"url":"https://api.github.com/repos/docker/swarmkit/pulls/comments/75560892","id":75560892,"diff_hunk":"@@ -118,6 +107,19 @@ message TaskSpec {\n \t// LogDriver specifies the log driver to use for the task. Any runtime will\n \t// direct logs into the specified driver for the duration of the task.\n \tDriver log_driver = 6;\n+\n+\t// Networks specifies the list of network attachment\n+\t// configurations (which specify the network and per-network\n+\t// aliases) that this task spec is bound to.\n+\trepeated NetworkAttachmentConfig networks = 7;\n+}\n+\n+// NetworkAttachmentSpec specifies runtime parameters required to attach\n+// a container to a network.\n+message NetworkAttachmentSpec {\n+\t// ID spcifies a unique ID of the entity for which this\n+\t// attachment is for.\n+\tstring id = 1 [(gogoproto.customname) = \"ID\"];","path":"api/specs.proto","position":45,"original_position":45,"commit_id":"c450e2c11c7e49bcaebe6971f72779238da7ddbb","original_commit_id":"c450e2c11c7e49bcaebe6971f72779238da7ddbb","user":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars.githubusercontent.com/u/120601?v=3","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"body":"After come thought, it is probably clearer to call this `ContainerID`. We should probably also include an attachment id, if that is a thing.","created_at":"2016-08-19T22:33:33Z","updated_at":"2016-08-19T22:33:33Z","html_url":"https://github.com/docker/swarmkit/pull/1373#discussion_r75560892","pull_request_url":"https://api.github.com/repos/docker/swarmkit/pulls/1373","_links":{"self":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/comments/75560892"},"html":{"href":"https://github.com/docker/swarmkit/pull/1373#discussion_r75560892"},"pull_request":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/1373"}}},"pull_request":{"url":"https://api.github.com/repos/docker/swarmkit/pulls/1373","id":81349049,"html_url":"https://github.com/docker/swarmkit/pull/1373","diff_url":"https://github.com/docker/swarmkit/pull/1373.diff","patch_url":"https://github.com/docker/swarmkit/pull/1373.patch","issue_url":"https://api.github.com/repos/docker/swarmkit/issues/1373","number":1373,"state":"open","locked":false,"title":"Add resource allocator api","user":{"login":"mrjana","id":1693482,"avatar_url":"https://avatars.githubusercontent.com/u/1693482?v=3","gravatar_id":"","url":"https://api.github.com/users/mrjana","html_url":"https://github.com/mrjana","followers_url":"https://api.github.com/users/mrjana/followers","following_url":"https://api.github.com/users/mrjana/following{/other_user}","gists_url":"https://api.github.com/users/mrjana/gists{/gist_id}","starred_url":"https://api.github.com/users/mrjana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrjana/subscriptions","organizations_url":"https://api.github.com/users/mrjana/orgs","repos_url":"https://api.github.com/users/mrjana/repos","events_url":"https://api.github.com/users/mrjana/events{/privacy}","received_events_url":"https://api.github.com/users/mrjana/received_events","type":"User","site_admin":false},"body":"Added resource allocator api to help worker nodes to attach and detach\r\nto a swarm created network so that individual containers can be\r\nindependently attached to a swarm network and discover/access swarm\r\nservices directly.\r\n\r\nSigned-off-by: Jana Radhakrishnan <mrjana@docker.com>","created_at":"2016-08-15T17:59:32Z","updated_at":"2016-08-19T22:33:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86a1bdbc474e17d5dff7e53d3e5cacecaa75d27e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/swarmkit/pulls/1373/commits","review_comments_url":"https://api.github.com/repos/docker/swarmkit/pulls/1373/comments","review_comment_url":"https://api.github.com/repos/docker/swarmkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/swarmkit/issues/1373/comments","statuses_url":"https://api.github.com/repos/docker/swarmkit/statuses/c450e2c11c7e49bcaebe6971f72779238da7ddbb","head":{"label":"mrjana:drun","ref":"drun","sha":"c450e2c11c7e49bcaebe6971f72779238da7ddbb","user":{"login":"mrjana","id":1693482,"avatar_url":"https://avatars.githubusercontent.com/u/1693482?v=3","gravatar_id":"","url":"https://api.github.com/users/mrjana","html_url":"https://github.com/mrjana","followers_url":"https://api.github.com/users/mrjana/followers","following_url":"https://api.github.com/users/mrjana/following{/other_user}","gists_url":"https://api.github.com/users/mrjana/gists{/gist_id}","starred_url":"https://api.github.com/users/mrjana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrjana/subscriptions","organizations_url":"https://api.github.com/users/mrjana/orgs","repos_url":"https://api.github.com/users/mrjana/repos","events_url":"https://api.github.com/users/mrjana/events{/privacy}","received_events_url":"https://api.github.com/users/mrjana/received_events","type":"User","site_admin":false},"repo":{"id":60930975,"name":"swarmkit","full_name":"mrjana/swarmkit","owner":{"login":"mrjana","id":1693482,"avatar_url":"https://avatars.githubusercontent.com/u/1693482?v=3","gravatar_id":"","url":"https://api.github.com/users/mrjana","html_url":"https://github.com/mrjana","followers_url":"https://api.github.com/users/mrjana/followers","following_url":"https://api.github.com/users/mrjana/following{/other_user}","gists_url":"https://api.github.com/users/mrjana/gists{/gist_id}","starred_url":"https://api.github.com/users/mrjana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrjana/subscriptions","organizations_url":"https://api.github.com/users/mrjana/orgs","repos_url":"https://api.github.com/users/mrjana/repos","events_url":"https://api.github.com/users/mrjana/events{/privacy}","received_events_url":"https://api.github.com/users/mrjana/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrjana/swarmkit","description":"A toolkit for orchestrating distributed systems at any scale. It includes primitives for node discovery, raft-based consensus, task scheduling and more.","fork":true,"url":"https://api.github.com/repos/mrjana/swarmkit","forks_url":"https://api.github.com/repos/mrjana/swarmkit/forks","keys_url":"https://api.github.com/repos/mrjana/swarmkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrjana/swarmkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrjana/swarmkit/teams","hooks_url":"https://api.github.com/repos/mrjana/swarmkit/hooks","issue_events_url":"https://api.github.com/repos/mrjana/swarmkit/issues/events{/number}","events_url":"https://api.github.com/repos/mrjana/swarmkit/events","assignees_url":"https://api.github.com/repos/mrjana/swarmkit/assignees{/user}","branches_url":"https://api.github.com/repos/mrjana/swarmkit/branches{/branch}","tags_url":"https://api.github.com/repos/mrjana/swarmkit/tags","blobs_url":"https://api.github.com/repos/mrjana/swarmkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrjana/swarmkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrjana/swarmkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrjana/swarmkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrjana/swarmkit/statuses/{sha}","languages_url":"https://api.github.com/repos/mrjana/swarmkit/languages","stargazers_url":"https://api.github.com/repos/mrjana/swarmkit/stargazers","contributors_url":"https://api.github.com/repos/mrjana/swarmkit/contributors","subscribers_url":"https://api.github.com/repos/mrjana/swarmkit/subscribers","subscription_url":"https://api.github.com/repos/mrjana/swarmkit/subscription","commits_url":"https://api.github.com/repos/mrjana/swarmkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrjana/swarmkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrjana/swarmkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrjana/swarmkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrjana/swarmkit/contents/{+path}","compare_url":"https://api.github.com/repos/mrjana/swarmkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrjana/swarmkit/merges","archive_url":"https://api.github.com/repos/mrjana/swarmkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrjana/swarmkit/downloads","issues_url":"https://api.github.com/repos/mrjana/swarmkit/issues{/number}","pulls_url":"https://api.github.com/repos/mrjana/swarmkit/pulls{/number}","milestones_url":"https://api.github.com/repos/mrjana/swarmkit/milestones{/number}","notifications_url":"https://api.github.com/repos/mrjana/swarmkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrjana/swarmkit/labels{/name}","releases_url":"https://api.github.com/repos/mrjana/swarmkit/releases{/id}","deployments_url":"https://api.github.com/repos/mrjana/swarmkit/deployments","created_at":"2016-06-11T22:41:22Z","updated_at":"2016-06-11T22:41:23Z","pushed_at":"2016-08-18T03:44:08Z","git_url":"git://github.com/mrjana/swarmkit.git","ssh_url":"git@github.com:mrjana/swarmkit.git","clone_url":"https://github.com/mrjana/swarmkit.git","svn_url":"https://github.com/mrjana/swarmkit","homepage":"","size":9116,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"165b8869f71aac94c43a5de00bbc621b882e21de","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":51556828,"name":"swarmkit","full_name":"docker/swarmkit","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/swarmkit","description":"A toolkit for orchestrating distributed systems at any scale. It includes primitives for node discovery, raft-based consensus, task scheduling and more.","fork":false,"url":"https://api.github.com/repos/docker/swarmkit","forks_url":"https://api.github.com/repos/docker/swarmkit/forks","keys_url":"https://api.github.com/repos/docker/swarmkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/swarmkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/swarmkit/teams","hooks_url":"https://api.github.com/repos/docker/swarmkit/hooks","issue_events_url":"https://api.github.com/repos/docker/swarmkit/issues/events{/number}","events_url":"https://api.github.com/repos/docker/swarmkit/events","assignees_url":"https://api.github.com/repos/docker/swarmkit/assignees{/user}","branches_url":"https://api.github.com/repos/docker/swarmkit/branches{/branch}","tags_url":"https://api.github.com/repos/docker/swarmkit/tags","blobs_url":"https://api.github.com/repos/docker/swarmkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/swarmkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/swarmkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/swarmkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/swarmkit/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/swarmkit/languages","stargazers_url":"https://api.github.com/repos/docker/swarmkit/stargazers","contributors_url":"https://api.github.com/repos/docker/swarmkit/contributors","subscribers_url":"https://api.github.com/repos/docker/swarmkit/subscribers","subscription_url":"https://api.github.com/repos/docker/swarmkit/subscription","commits_url":"https://api.github.com/repos/docker/swarmkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/swarmkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/swarmkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/swarmkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/swarmkit/contents/{+path}","compare_url":"https://api.github.com/repos/docker/swarmkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/swarmkit/merges","archive_url":"https://api.github.com/repos/docker/swarmkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/swarmkit/downloads","issues_url":"https://api.github.com/repos/docker/swarmkit/issues{/number}","pulls_url":"https://api.github.com/repos/docker/swarmkit/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/swarmkit/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/swarmkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/swarmkit/labels{/name}","releases_url":"https://api.github.com/repos/docker/swarmkit/releases{/id}","deployments_url":"https://api.github.com/repos/docker/swarmkit/deployments","created_at":"2016-02-12T00:02:15Z","updated_at":"2016-08-19T19:35:35Z","pushed_at":"2016-08-19T21:59:36Z","git_url":"git://github.com/docker/swarmkit.git","ssh_url":"git@github.com:docker/swarmkit.git","clone_url":"https://github.com/docker/swarmkit.git","svn_url":"https://github.com/docker/swarmkit","homepage":"","size":20037,"stargazers_count":892,"watchers_count":892,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":161,"mirror_url":null,"open_issues_count":167,"forks":161,"open_issues":167,"watchers":892,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/1373"},"html":{"href":"https://github.com/docker/swarmkit/pull/1373"},"issue":{"href":"https://api.github.com/repos/docker/swarmkit/issues/1373"},"comments":{"href":"https://api.github.com/repos/docker/swarmkit/issues/1373/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/1373/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/1373/commits"},"statuses":{"href":"https://api.github.com/repos/docker/swarmkit/statuses/c450e2c11c7e49bcaebe6971f72779238da7ddbb"}}}}
{"actor":{"display_login":"stevvooe"}}