{"action":"created","issue":{"url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/83","repository_url":"https://api.github.com/repos/bazelbuild/rules_scala","labels_url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/83/labels{/name}","comments_url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/83/comments","events_url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/83/events","html_url":"https://github.com/bazelbuild/rules_scala/pull/83","id":168440683,"number":83,"title":"Fix for thrift rule issue that manifests with remote repos","user":{"login":"johnynek","id":67958,"avatar_url":"https://avatars.githubusercontent.com/u/67958?v=3","gravatar_id":"","url":"https://api.github.com/users/johnynek","html_url":"https://github.com/johnynek","followers_url":"https://api.github.com/users/johnynek/followers","following_url":"https://api.github.com/users/johnynek/following{/other_user}","gists_url":"https://api.github.com/users/johnynek/gists{/gist_id}","starred_url":"https://api.github.com/users/johnynek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnynek/subscriptions","organizations_url":"https://api.github.com/users/johnynek/orgs","repos_url":"https://api.github.com/users/johnynek/repos","events_url":"https://api.github.com/users/johnynek/events{/privacy}","received_events_url":"https://api.github.com/users/johnynek/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bazelbuild/rules_scala/labels/cla:%20yes","name":"cla: yes","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-30T01:12:59Z","updated_at":"2016-07-31T00:40:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bazelbuild/rules_scala/pulls/83","html_url":"https://github.com/bazelbuild/rules_scala/pull/83","diff_url":"https://github.com/bazelbuild/rules_scala/pull/83.diff","patch_url":"https://github.com/bazelbuild/rules_scala/pull/83.patch"},"body":"The problem is that the path is not the same when remote as local. The current fix:\r\n\r\n1. makes sure that a prefix, if given, is an actual substring of the common prefix.\r\n2. ignores anything *before* the prefix that matches. So it is like the regex `.*prefix(.*)$`.\r\n\r\nThe above two fixes make this rule usable in both local and remote contexts for me."},"comment":{"url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/comments/236399420","html_url":"https://github.com/bazelbuild/rules_scala/pull/83#issuecomment-236399420","issue_url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/83","id":236399420,"user":{"login":"ianoc","id":446652,"avatar_url":"https://avatars.githubusercontent.com/u/446652?v=3","gravatar_id":"","url":"https://api.github.com/users/ianoc","html_url":"https://github.com/ianoc","followers_url":"https://api.github.com/users/ianoc/followers","following_url":"https://api.github.com/users/ianoc/following{/other_user}","gists_url":"https://api.github.com/users/ianoc/gists{/gist_id}","starred_url":"https://api.github.com/users/ianoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianoc/subscriptions","organizations_url":"https://api.github.com/users/ianoc/orgs","repos_url":"https://api.github.com/users/ianoc/repos","events_url":"https://api.github.com/users/ianoc/events{/privacy}","received_events_url":"https://api.github.com/users/ianoc/received_events","type":"User","site_admin":false},"created_at":"2016-07-31T00:40:26Z","updated_at":"2016-07-31T00:40:26Z","body":"looks reasonable to me. Is it possible to add a test for the issue so it doesn't re-occur?"}}
{"actor":{"display_login":"ianoc"}}