{"action":"created","issue":{"url":"https://api.github.com/repos/php/php-src/issues/2057","repository_url":"https://api.github.com/repos/php/php-src","labels_url":"https://api.github.com/repos/php/php-src/issues/2057/labels{/name}","comments_url":"https://api.github.com/repos/php/php-src/issues/2057/comments","events_url":"https://api.github.com/repos/php/php-src/issues/2057/events","html_url":"https://github.com/php/php-src/pull/2057","id":169414435,"number":2057,"title":"Zend/zend_operators.h: disable x86 assembly on all newer GCC-4.x.","user":{"login":"orlitzky","id":1432135,"avatar_url":"https://avatars.githubusercontent.com/u/1432135?v=3","gravatar_id":"","url":"https://api.github.com/users/orlitzky","html_url":"https://github.com/orlitzky","followers_url":"https://api.github.com/users/orlitzky/followers","following_url":"https://api.github.com/users/orlitzky/following{/other_user}","gists_url":"https://api.github.com/users/orlitzky/gists{/gist_id}","starred_url":"https://api.github.com/users/orlitzky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlitzky/subscriptions","organizations_url":"https://api.github.com/users/orlitzky/orgs","repos_url":"https://api.github.com/users/orlitzky/repos","events_url":"https://api.github.com/users/orlitzky/events{/privacy}","received_events_url":"https://api.github.com/users/orlitzky/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/php/php-src/labels/Bugfix","name":"Bugfix","color":"f7c6c7"},{"url":"https://api.github.com/repos/php/php-src/labels/BuildSystem","name":"BuildSystem","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2016-08-04T16:17:00Z","updated_at":"2016-09-10T23:51:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/php/php-src/pulls/2057","html_url":"https://github.com/php/php-src/pull/2057","diff_url":"https://github.com/php/php-src/pull/2057.diff","patch_url":"https://github.com/php/php-src/pull/2057.patch"},"body":"In bug 69896, a fix was committed to work around a build error: 'asm'\r\noperand has impossible constraints, in zend_operators.h, on x86. At\r\nthe time, the problem was only visible with gcc-4.8, and the fix was\r\nto disable that chunk of assembly for gcc-4.8. With gcc-4.9, the\r\nproblem persists, so we now need to check for gcc-4.9 (at least) in\r\naddition to gcc-4.8.\r\n\r\nThis commit modifies the earlier conditional that checks for\r\ngcc-4.8. The existing check was for equality on the minor component of\r\nthe gcc version, namely 8. The == operator that performs the\r\ncomparison has been changed to <=, so that it catches any gcc-4.x with\r\nx >= 8. This has been tested and fixes the build on x86 hardware with\r\ngcc-4.9.\r\n\r\nPHP-Bug: 69896\r\nGentoo-Bug: 571658"},"comment":{"url":"https://api.github.com/repos/php/php-src/issues/comments/246152714","html_url":"https://github.com/php/php-src/pull/2057#issuecomment-246152714","issue_url":"https://api.github.com/repos/php/php-src/issues/2057","id":246152714,"user":{"login":"orlitzky","id":1432135,"avatar_url":"https://avatars.githubusercontent.com/u/1432135?v=3","gravatar_id":"","url":"https://api.github.com/users/orlitzky","html_url":"https://github.com/orlitzky","followers_url":"https://api.github.com/users/orlitzky/followers","following_url":"https://api.github.com/users/orlitzky/following{/other_user}","gists_url":"https://api.github.com/users/orlitzky/gists{/gist_id}","starred_url":"https://api.github.com/users/orlitzky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlitzky/subscriptions","organizations_url":"https://api.github.com/users/orlitzky/orgs","repos_url":"https://api.github.com/users/orlitzky/repos","events_url":"https://api.github.com/users/orlitzky/events{/privacy}","received_events_url":"https://api.github.com/users/orlitzky/received_events","type":"User","site_admin":false},"created_at":"2016-09-10T23:51:11Z","updated_at":"2016-09-10T23:51:11Z","body":"I just merged this branch with master and pushed the big ol' merge commit. Afterwards, I patched it up to\r\n\r\n1) Leave the original gcc-4.8 check in place, even though it may be pointless.\r\n2) Add a new gcc-4.9 check, but only when PIE or PIC is enabled.\r\n\r\nThat's the smallest change I could make to the code, conceptually. I would however be open to eliminating the gcc-4.8 check if people think the original reports may have been mistaken."}}
{"actor":{"display_login":"orlitzky"}}