{"action":"created","issue":{"url":"https://api.github.com/repos/QQuick/Transcrypt/issues/157","repository_url":"https://api.github.com/repos/QQuick/Transcrypt","labels_url":"https://api.github.com/repos/QQuick/Transcrypt/issues/157/labels{/name}","comments_url":"https://api.github.com/repos/QQuick/Transcrypt/issues/157/comments","events_url":"https://api.github.com/repos/QQuick/Transcrypt/issues/157/events","html_url":"https://github.com/QQuick/Transcrypt/pull/157","id":187523148,"number":157,"title":"removed diff marks","user":{"login":"AXGKl","id":9989548,"avatar_url":"https://avatars.githubusercontent.com/u/9989548?v=3","gravatar_id":"","url":"https://api.github.com/users/AXGKl","html_url":"https://github.com/AXGKl","followers_url":"https://api.github.com/users/AXGKl/followers","following_url":"https://api.github.com/users/AXGKl/following{/other_user}","gists_url":"https://api.github.com/users/AXGKl/gists{/gist_id}","starred_url":"https://api.github.com/users/AXGKl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AXGKl/subscriptions","organizations_url":"https://api.github.com/users/AXGKl/orgs","repos_url":"https://api.github.com/users/AXGKl/repos","events_url":"https://api.github.com/users/AXGKl/events{/privacy}","received_events_url":"https://api.github.com/users/AXGKl/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-05T21:06:15Z","updated_at":"2016-11-06T15:41:15Z","closed_at":"2016-11-06T13:48:26Z","pull_request":{"url":"https://api.github.com/repos/QQuick/Transcrypt/pulls/157","html_url":"https://github.com/QQuick/Transcrypt/pull/157","diff_url":"https://github.com/QQuick/Transcrypt/pull/157.diff","patch_url":"https://github.com/QQuick/Transcrypt/pull/157.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/QQuick/Transcrypt/issues/comments/258689013","html_url":"https://github.com/QQuick/Transcrypt/pull/157#issuecomment-258689013","issue_url":"https://api.github.com/repos/QQuick/Transcrypt/issues/157","id":258689013,"user":{"login":"JdeH","id":1730289,"avatar_url":"https://avatars.githubusercontent.com/u/1730289?v=3","gravatar_id":"","url":"https://api.github.com/users/JdeH","html_url":"https://github.com/JdeH","followers_url":"https://api.github.com/users/JdeH/followers","following_url":"https://api.github.com/users/JdeH/following{/other_user}","gists_url":"https://api.github.com/users/JdeH/gists{/gist_id}","starred_url":"https://api.github.com/users/JdeH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JdeH/subscriptions","organizations_url":"https://api.github.com/users/JdeH/orgs","repos_url":"https://api.github.com/users/JdeH/repos","events_url":"https://api.github.com/users/JdeH/events{/privacy}","received_events_url":"https://api.github.com/users/JdeH/received_events","type":"User","site_admin":false},"created_at":"2016-11-06T15:41:15Z","updated_at":"2016-11-06T15:41:15Z","body":"**Merge and pull seem to have gone fine and everything works. Looks like a good job to me!**\r\n\r\n***\r\n\r\nI have made some cosmetic mod's to the classes testlet:\r\n\r\nMade some names a bit longer since it took me some time before I understood what r, c etc. meant. Being a bit picky on that, since the testlets also serve as doc.\r\n\r\nFor the same reason I've put the complicated stuff at the bottom of the testlet (and added labels to the output). Want to prevent beginners thinking classes are something difficult.\r\n\r\n***\r\n\r\nAugmented function isinstance works fine in the autotest.  Now I want to attempt to make it more compact (if possible, no idea). Not sure it will work correctly for JS types after that, so I'd like get back to you for feedback on having broken something, if that's ok with you.\r\n\r\nMaybe we should have a test for it added to the manual (eyeballing) tests, since of course correct handling of native JS types cannot be back to back autotested with CPyton. If it can't be smaller it'll stay as is, since indeed being able to use instanceof on any object is a blessing.\r\n\r\n***\r\n\r\nTime module works fine on Windows now. Will also test on my problematic linux and maybe add a workaround, since other linux installs may suffer from the same. Think I can do that with almost no code. \r\n\r\n***\r\n\r\nI need some explatation on the README.md of the hello autotest with regard to \r\n\r\n\r\n> Thats why you have to add the current working directory to have `autotest.py`\r\n> find the testlets *outside* the Python runtime, not within, via `sys.path.insert`.\r\n> \r\n> On POSIX systems this is the standard way: `export PYTHONPATH=\".:$PYTHONPATH\"`\r\n> \r\n\r\n\"add the current working directory\" where exactly? I am missing the connection here.\r\n\r\n***\r\n\r\nFinally: Since your PR was commited, I'd expect you to be added to the contributers list automatically, but still this is not the case. Some time ago my own commits also weren't visible. The reason for that had something to do with different email addresses.\r\n\r\nI forgot the details, and no idea why this must be so complicated, but when I changed my email address known on GitHub to something I'd used earlier in conjuction with Git (sorry for being so vague, but I really have no idea of the magic behind this) all my commits became visible. Maybe a similar trick works for you as well.\r\n\r\nKR\r\nJ\r\n\r\n\r\n"}}
{"actor":{"display_login":"JdeH"}}