{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/7165","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/7165/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/7165/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/7165/events","html_url":"https://github.com/nodejs/node/pull/7165","id":158576374,"number":7165,"title":"fs: refactor \"options\" processing as a function","user":{"login":"thefourtheye","id":696611,"avatar_url":"https://avatars.githubusercontent.com/u/696611?v=3","gravatar_id":"","url":"https://api.github.com/users/thefourtheye","html_url":"https://github.com/thefourtheye","followers_url":"https://api.github.com/users/thefourtheye/followers","following_url":"https://api.github.com/users/thefourtheye/following{/other_user}","gists_url":"https://api.github.com/users/thefourtheye/gists{/gist_id}","starred_url":"https://api.github.com/users/thefourtheye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefourtheye/subscriptions","organizations_url":"https://api.github.com/users/thefourtheye/orgs","repos_url":"https://api.github.com/users/thefourtheye/repos","events_url":"https://api.github.com/users/thefourtheye/events{/privacy}","received_events_url":"https://api.github.com/users/thefourtheye/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/error-handling","name":"error-handling","color":"e11d21"},{"url":"https://api.github.com/repos/nodejs/node/labels/fs","name":"fs","color":"0052cc"},{"url":"https://api.github.com/repos/nodejs/node/labels/semver-major","name":"semver-major","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":24,"created_at":"2016-06-05T21:37:06Z","updated_at":"2016-08-27T10:57:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/7165","html_url":"https://github.com/nodejs/node/pull/7165","diff_url":"https://github.com/nodejs/node/pull/7165.diff","patch_url":"https://github.com/nodejs/node/pull/7165.patch"},"body":"##### Checklist\r\n\r\n- [x] tests and code linting passes\r\n- [x] the commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n\r\nfs\r\n\r\n##### Description of change\r\n\r\nAs it is the \"options\" processing is repeated in all the functions\r\nwhich need it. That introduces checks which are inconsistent with\r\nsimilar functions and produces slightly different error messages.\r\n\r\nThis patch moves the basic \"options\" validation and processing to a\r\nseparate function.\r\n\r\n---\r\n\r\ncc @nodejs/fs @nodejs/collaborators \r\n\r\nMarking this as major, as this might break some code in the wild."},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/242910606","html_url":"https://github.com/nodejs/node/pull/7165#issuecomment-242910606","issue_url":"https://api.github.com/repos/nodejs/node/issues/7165","id":242910606,"user":{"login":"thefourtheye","id":696611,"avatar_url":"https://avatars.githubusercontent.com/u/696611?v=3","gravatar_id":"","url":"https://api.github.com/users/thefourtheye","html_url":"https://github.com/thefourtheye","followers_url":"https://api.github.com/users/thefourtheye/followers","following_url":"https://api.github.com/users/thefourtheye/following{/other_user}","gists_url":"https://api.github.com/users/thefourtheye/gists{/gist_id}","starred_url":"https://api.github.com/users/thefourtheye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefourtheye/subscriptions","organizations_url":"https://api.github.com/users/thefourtheye/orgs","repos_url":"https://api.github.com/users/thefourtheye/repos","events_url":"https://api.github.com/users/thefourtheye/events{/privacy}","received_events_url":"https://api.github.com/users/thefourtheye/received_events","type":"User","site_admin":false},"created_at":"2016-08-27T10:57:06Z","updated_at":"2016-08-27T10:57:06Z","body":"Can somebody please confirm the vinyl-fs failure locally?"}}
{"actor":{"display_login":"thefourtheye"}}