{"action":"created","comment":{"url":"https://api.github.com/repos/dcos/dcos/pulls/comments/67203415","id":67203415,"diff_hunk":"@@ -1361,6 +1363,14 @@ def wait_for_endpoint():\n         'mesos-dns-service',\n         'mesos-master-service',\n         'signal-service']\n+\n+    ee_master_units = [","path":"test_util/integration_test.py","position":null,"original_position":23,"commit_id":"cd769a56fa7b3e6ed5254d393d01ca9ae09c7c9c","original_commit_id":"fe415547e59ccf59aa801da98469cc21aa4ea086","user":{"login":"spahl","id":40360,"avatar_url":"https://avatars.githubusercontent.com/u/40360?v=3","gravatar_id":"","url":"https://api.github.com/users/spahl","html_url":"https://github.com/spahl","followers_url":"https://api.github.com/users/spahl/followers","following_url":"https://api.github.com/users/spahl/following{/other_user}","gists_url":"https://api.github.com/users/spahl/gists{/gist_id}","starred_url":"https://api.github.com/users/spahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spahl/subscriptions","organizations_url":"https://api.github.com/users/spahl/orgs","repos_url":"https://api.github.com/users/spahl/repos","events_url":"https://api.github.com/users/spahl/events{/privacy}","received_events_url":"https://api.github.com/users/spahl/received_events","type":"User","site_admin":false},"body":"This should not be in open. Variants should have a clean separation and not bleed through like this.","created_at":"2016-06-15T17:08:32Z","updated_at":"2016-06-15T17:08:32Z","html_url":"https://github.com/dcos/dcos/pull/210#discussion_r67203415","pull_request_url":"https://api.github.com/repos/dcos/dcos/pulls/210","_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments/67203415"},"html":{"href":"https://github.com/dcos/dcos/pull/210#discussion_r67203415"},"pull_request":{"href":"https://api.github.com/repos/dcos/dcos/pulls/210"}}},"pull_request":{"url":"https://api.github.com/repos/dcos/dcos/pulls/210","id":73916900,"html_url":"https://github.com/dcos/dcos/pull/210","diff_url":"https://github.com/dcos/dcos/pull/210.diff","patch_url":"https://github.com/dcos/dcos/pull/210.patch","issue_url":"https://api.github.com/repos/dcos/dcos/issues/210","number":210,"state":"open","locked":false,"title":"Make signal service variant aware","user":{"login":"malnick","id":4028224,"avatar_url":"https://avatars.githubusercontent.com/u/4028224?v=3","gravatar_id":"","url":"https://api.github.com/users/malnick","html_url":"https://github.com/malnick","followers_url":"https://api.github.com/users/malnick/followers","following_url":"https://api.github.com/users/malnick/following{/other_user}","gists_url":"https://api.github.com/users/malnick/gists{/gist_id}","starred_url":"https://api.github.com/users/malnick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malnick/subscriptions","organizations_url":"https://api.github.com/users/malnick/orgs","repos_url":"https://api.github.com/users/malnick/repos","events_url":"https://api.github.com/users/malnick/events{/privacy}","received_events_url":"https://api.github.com/users/malnick/received_events","type":"User","site_admin":false},"body":"Depends on #169 ","created_at":"2016-06-15T14:02:00Z","updated_at":"2016-06-15T17:08:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27ea7ea0b9ca1e6727401fc1d6aee4ba82030c18","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos/pulls/210/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos/pulls/210/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos/issues/210/comments","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/cd769a56fa7b3e6ed5254d393d01ca9ae09c7c9c","head":{"label":"malnick:malnick/signal_ee_test","ref":"malnick/signal_ee_test","sha":"cd769a56fa7b3e6ed5254d393d01ca9ae09c7c9c","user":{"login":"malnick","id":4028224,"avatar_url":"https://avatars.githubusercontent.com/u/4028224?v=3","gravatar_id":"","url":"https://api.github.com/users/malnick","html_url":"https://github.com/malnick","followers_url":"https://api.github.com/users/malnick/followers","following_url":"https://api.github.com/users/malnick/following{/other_user}","gists_url":"https://api.github.com/users/malnick/gists{/gist_id}","starred_url":"https://api.github.com/users/malnick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malnick/subscriptions","organizations_url":"https://api.github.com/users/malnick/orgs","repos_url":"https://api.github.com/users/malnick/repos","events_url":"https://api.github.com/users/malnick/events{/privacy}","received_events_url":"https://api.github.com/users/malnick/received_events","type":"User","site_admin":false},"repo":{"id":56808788,"name":"dcos","full_name":"malnick/dcos","owner":{"login":"malnick","id":4028224,"avatar_url":"https://avatars.githubusercontent.com/u/4028224?v=3","gravatar_id":"","url":"https://api.github.com/users/malnick","html_url":"https://github.com/malnick","followers_url":"https://api.github.com/users/malnick/followers","following_url":"https://api.github.com/users/malnick/following{/other_user}","gists_url":"https://api.github.com/users/malnick/gists{/gist_id}","starred_url":"https://api.github.com/users/malnick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malnick/subscriptions","organizations_url":"https://api.github.com/users/malnick/orgs","repos_url":"https://api.github.com/users/malnick/repos","events_url":"https://api.github.com/users/malnick/events{/privacy}","received_events_url":"https://api.github.com/users/malnick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/malnick/dcos","description":"DC/OS Build and Release tools","fork":true,"url":"https://api.github.com/repos/malnick/dcos","forks_url":"https://api.github.com/repos/malnick/dcos/forks","keys_url":"https://api.github.com/repos/malnick/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/malnick/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/malnick/dcos/teams","hooks_url":"https://api.github.com/repos/malnick/dcos/hooks","issue_events_url":"https://api.github.com/repos/malnick/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/malnick/dcos/events","assignees_url":"https://api.github.com/repos/malnick/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/malnick/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/malnick/dcos/tags","blobs_url":"https://api.github.com/repos/malnick/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/malnick/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/malnick/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/malnick/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/malnick/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/malnick/dcos/languages","stargazers_url":"https://api.github.com/repos/malnick/dcos/stargazers","contributors_url":"https://api.github.com/repos/malnick/dcos/contributors","subscribers_url":"https://api.github.com/repos/malnick/dcos/subscribers","subscription_url":"https://api.github.com/repos/malnick/dcos/subscription","commits_url":"https://api.github.com/repos/malnick/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/malnick/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/malnick/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/malnick/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/malnick/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/malnick/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/malnick/dcos/merges","archive_url":"https://api.github.com/repos/malnick/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/malnick/dcos/downloads","issues_url":"https://api.github.com/repos/malnick/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/malnick/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/malnick/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/malnick/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/malnick/dcos/labels{/name}","releases_url":"https://api.github.com/repos/malnick/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/malnick/dcos/deployments","created_at":"2016-04-21T22:13:48Z","updated_at":"2016-04-21T22:13:49Z","pushed_at":"2016-06-15T14:55:13Z","git_url":"git://github.com/malnick/dcos.git","ssh_url":"git@github.com:malnick/dcos.git","clone_url":"https://github.com/malnick/dcos.git","svn_url":"https://github.com/malnick/dcos","homepage":"https://dcos.io","size":722,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dcos:master","ref":"master","sha":"aa48124db2a79b7a65c0910ba7f41d253697d790","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56184050,"name":"dcos","full_name":"dcos/dcos","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos","description":"DC/OS Build and Release tools","fork":false,"url":"https://api.github.com/repos/dcos/dcos","forks_url":"https://api.github.com/repos/dcos/dcos/forks","keys_url":"https://api.github.com/repos/dcos/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos/teams","hooks_url":"https://api.github.com/repos/dcos/dcos/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos/events","assignees_url":"https://api.github.com/repos/dcos/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos/tags","blobs_url":"https://api.github.com/repos/dcos/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos/subscription","commits_url":"https://api.github.com/repos/dcos/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos/merges","archive_url":"https://api.github.com/repos/dcos/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos/downloads","issues_url":"https://api.github.com/repos/dcos/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos/deployments","created_at":"2016-04-13T20:31:58Z","updated_at":"2016-06-15T17:02:44Z","pushed_at":"2016-06-15T15:13:37Z","git_url":"git://github.com/dcos/dcos.git","ssh_url":"git@github.com:dcos/dcos.git","clone_url":"https://github.com/dcos/dcos.git","svn_url":"https://github.com/dcos/dcos","homepage":"https://dcos.io","size":900,"stargazers_count":533,"watchers_count":533,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":73,"mirror_url":null,"open_issues_count":31,"forks":73,"open_issues":31,"watchers":533,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/210"},"html":{"href":"https://github.com/dcos/dcos/pull/210"},"issue":{"href":"https://api.github.com/repos/dcos/dcos/issues/210"},"comments":{"href":"https://api.github.com/repos/dcos/dcos/issues/210/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos/pulls/210/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos/pulls/210/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos/statuses/cd769a56fa7b3e6ed5254d393d01ca9ae09c7c9c"}}}}
{"actor":{"display_login":"spahl"}}