{"action":"created","issue":{"url":"https://api.github.com/repos/cucumber/aruba/issues/356","repository_url":"https://api.github.com/repos/cucumber/aruba","labels_url":"https://api.github.com/repos/cucumber/aruba/issues/356/labels{/name}","comments_url":"https://api.github.com/repos/cucumber/aruba/issues/356/comments","events_url":"https://api.github.com/repos/cucumber/aruba/issues/356/events","html_url":"https://github.com/cucumber/aruba/pull/356","id":144746002,"number":356,"title":"unset BSD_ECHO for Zsh features","user":{"login":"e2","id":150197,"avatar_url":"https://avatars.githubusercontent.com/u/150197?v=3","gravatar_id":"","url":"https://api.github.com/users/e2","html_url":"https://github.com/e2","followers_url":"https://api.github.com/users/e2/followers","following_url":"https://api.github.com/users/e2/following{/other_user}","gists_url":"https://api.github.com/users/e2/gists{/gist_id}","starred_url":"https://api.github.com/users/e2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e2/subscriptions","organizations_url":"https://api.github.com/users/e2/orgs","repos_url":"https://api.github.com/users/e2/repos","events_url":"https://api.github.com/users/e2/events{/privacy}","received_events_url":"https://api.github.com/users/e2/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-30T23:16:10Z","updated_at":"2016-03-31T16:59:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cucumber/aruba/pulls/356","html_url":"https://github.com/cucumber/aruba/pull/356","diff_url":"https://github.com/cucumber/aruba/pull/356.diff","patch_url":"https://github.com/cucumber/aruba/pull/356.patch"},"body":"## Summary\r\n\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\nMake Zsh shell scripts work regardless of local user Zsh configuration.\r\n\r\n## Details\r\n\r\nSome scenarios depend on echo allowing escape sequences.\r\n\r\nFrom the Zsh manual:\r\n\r\n```\r\nBSD_ECHO\r\nMake the echo builtin compatible with the BSD echo(1) command. This disables backslashed escape sequences in echo strings unless the `-e' option is specified.\r\n```\r\n\r\n## Motivation and Context\r\n\r\nHaving `setopt BSD_ECHO` in Zsh config files (like I did) causes shell-related scenarios to fail.\r\nMaking sure this option is unset allows tests to work locally, even if this is set.\r\n\r\n## How Has This Been Tested?\r\n\r\nLocal tests now work. Doesn't affect anything other than those few previously-failing cucumber scenarios.\r\n\r\n## Types of changes\r\n\r\n- [X] Bug fix (non-breaking change which fixes an issue)\r\n\r\n## Checklist:\r\n\r\n- [X] My code follows the code style of this project."},"comment":{"url":"https://api.github.com/repos/cucumber/aruba/issues/comments/204021050","html_url":"https://github.com/cucumber/aruba/pull/356#issuecomment-204021050","issue_url":"https://api.github.com/repos/cucumber/aruba/issues/356","id":204021050,"user":{"login":"e2","id":150197,"avatar_url":"https://avatars.githubusercontent.com/u/150197?v=3","gravatar_id":"","url":"https://api.github.com/users/e2","html_url":"https://github.com/e2","followers_url":"https://api.github.com/users/e2/followers","following_url":"https://api.github.com/users/e2/following{/other_user}","gists_url":"https://api.github.com/users/e2/gists{/gist_id}","starred_url":"https://api.github.com/users/e2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e2/subscriptions","organizations_url":"https://api.github.com/users/e2/orgs","repos_url":"https://api.github.com/users/e2/repos","events_url":"https://api.github.com/users/e2/events{/privacy}","received_events_url":"https://api.github.com/users/e2/received_events","type":"User","site_admin":false},"created_at":"2016-03-31T16:59:54Z","updated_at":"2016-03-31T16:59:54Z","body":"In short, I'd accept this PR for now, because tests are broken and this fixes it.\r\n\r\nSpending time to switch to paths doesn't make sense, because it's just using a different system resource - /tmp dir.\r\n(It doesn't change the fact that zsh is necessary - while it shouldn't be).\r\n\r\nThe \"best solution\" requires rewriting those whole Cucumber scenarios. I don't really have time for that. (And neither did I write those features in the first place).\r\n\r\nSo I shouldn't be \"punished\" with reworking those scenarios - just to stop the tests from failing on my setup (a bigger priority than \"combing\" a few scenarios that need to be rewritten shortly anyway - to drop dependency on those external binaries, and, to reduce the Docker container size/time).\r\n\r\nThere's no need for contributors of Aruba to install Zsh just to get 1-2 scenarios working. So there's no need to \"fix a zsh setup\" if Zsh will be removed soon anyway. (It's just a waste of precious time)."}}