{"action":"created","comment":{"url":"https://api.github.com/repos/johnbellone/consul-cookbook/pulls/comments/66552437","id":66552437,"diff_hunk":"@@ -20,10 +20,13 @@ class ConsulConfig < Chef::Resource\n       attribute(:path, kind_of: String, name_attribute: true)\n       # @!attribute owner\n       # @return [String]\n-      attribute(:owner, kind_of: String, default: 'consul')\n+      attribute(:owner, kind_of: String, default: lazy { node['consul']['config']['owner'] })","path":"libraries/consul_config.rb","position":null,"original_position":5,"commit_id":"ab8d631236fd8daa6198037d69c4dc92af3ece64","original_commit_id":"a5e2516354a5dc735999e761399efcdc1f314187","user":{"login":"kingpong","id":118347,"avatar_url":"https://avatars.githubusercontent.com/u/118347?v=3","gravatar_id":"","url":"https://api.github.com/users/kingpong","html_url":"https://github.com/kingpong","followers_url":"https://api.github.com/users/kingpong/followers","following_url":"https://api.github.com/users/kingpong/following{/other_user}","gists_url":"https://api.github.com/users/kingpong/gists{/gist_id}","starred_url":"https://api.github.com/users/kingpong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingpong/subscriptions","organizations_url":"https://api.github.com/users/kingpong/orgs","repos_url":"https://api.github.com/users/kingpong/repos","events_url":"https://api.github.com/users/kingpong/events{/privacy}","received_events_url":"https://api.github.com/users/kingpong/received_events","type":"User","site_admin":false},"body":"tl;dr: none at all. I've pushed a new commit to change it back and test a different way.\r\n\r\nIt took me a few minutes to understand why I did it this way. It's because I had already started updating [the Rspec](https://github.com/kingpong/consul-cookbook/blob/a5e2516354a5dc735999e761399efcdc1f314187/test/spec/libraries/consul_config_spec.rb#L16) based on my original suggestion in #322. I changed part of the implementation but forgot to change the other part since it didn't break the tests.  Anyway, it's reverted now and I'm testing the changes by using the resource property instead of an attribute.","created_at":"2016-06-10T02:07:33Z","updated_at":"2016-06-10T02:07:33Z","html_url":"https://github.com/johnbellone/consul-cookbook/pull/323#discussion_r66552437","pull_request_url":"https://api.github.com/repos/johnbellone/consul-cookbook/pulls/323","_links":{"self":{"href":"https://api.github.com/repos/johnbellone/consul-cookbook/pulls/comments/66552437"},"html":{"href":"https://github.com/johnbellone/consul-cookbook/pull/323#discussion_r66552437"},"pull_request":{"href":"https://api.github.com/repos/johnbellone/consul-cookbook/pulls/323"}}},"pull_request":{"url":"https://api.github.com/repos/johnbellone/consul-cookbook/pulls/323","id":72616170,"html_url":"https://github.com/johnbellone/consul-cookbook/pull/323","diff_url":"https://github.com/johnbellone/consul-cookbook/pull/323.diff","patch_url":"https://github.com/johnbellone/consul-cookbook/pull/323.patch","issue_url":"https://api.github.com/repos/johnbellone/consul-cookbook/issues/323","number":323,"state":"open","locked":false,"title":"Prevent consul from writing its own config","user":{"login":"kingpong","id":118347,"avatar_url":"https://avatars.githubusercontent.com/u/118347?v=3","gravatar_id":"","url":"https://api.github.com/users/kingpong","html_url":"https://github.com/kingpong","followers_url":"https://api.github.com/users/kingpong/followers","following_url":"https://api.github.com/users/kingpong/following{/other_user}","gists_url":"https://api.github.com/users/kingpong/gists{/gist_id}","starred_url":"https://api.github.com/users/kingpong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingpong/subscriptions","organizations_url":"https://api.github.com/users/kingpong/orgs","repos_url":"https://api.github.com/users/kingpong/repos","events_url":"https://api.github.com/users/kingpong/events{/privacy}","received_events_url":"https://api.github.com/users/kingpong/received_events","type":"User","site_admin":false},"body":"This fixes issue #322.\r\n\r\nThe consul cookbook makes the Consul config writable by the same user\r\nthat runs the service, which is unnecessary and could be an attack\r\nvector. This commit allows the user to specify a different set of\r\npermissions for the configuration directories (/etc/consul) than for the\r\nruntime data directory (/var/lib/consul).\r\n\r\nThe config owner still defaults to 'consul' since changing it to root is\r\na breaking change.","created_at":"2016-06-04T23:41:56Z","updated_at":"2016-06-10T02:07:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89c3483ac3c7a74a5d235cda7f8cd19227ab2ff0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/johnbellone/consul-cookbook/pulls/323/commits","review_comments_url":"https://api.github.com/repos/johnbellone/consul-cookbook/pulls/323/comments","review_comment_url":"https://api.github.com/repos/johnbellone/consul-cookbook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/johnbellone/consul-cookbook/issues/323/comments","statuses_url":"https://api.github.com/repos/johnbellone/consul-cookbook/statuses/ab8d631236fd8daa6198037d69c4dc92af3ece64","head":{"label":"kingpong:tighten-permissions","ref":"tighten-permissions","sha":"ab8d631236fd8daa6198037d69c4dc92af3ece64","user":{"login":"kingpong","id":118347,"avatar_url":"https://avatars.githubusercontent.com/u/118347?v=3","gravatar_id":"","url":"https://api.github.com/users/kingpong","html_url":"https://github.com/kingpong","followers_url":"https://api.github.com/users/kingpong/followers","following_url":"https://api.github.com/users/kingpong/following{/other_user}","gists_url":"https://api.github.com/users/kingpong/gists{/gist_id}","starred_url":"https://api.github.com/users/kingpong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingpong/subscriptions","organizations_url":"https://api.github.com/users/kingpong/orgs","repos_url":"https://api.github.com/users/kingpong/repos","events_url":"https://api.github.com/users/kingpong/events{/privacy}","received_events_url":"https://api.github.com/users/kingpong/received_events","type":"User","site_admin":false},"repo":{"id":60416140,"name":"consul-cookbook","full_name":"kingpong/consul-cookbook","owner":{"login":"kingpong","id":118347,"avatar_url":"https://avatars.githubusercontent.com/u/118347?v=3","gravatar_id":"","url":"https://api.github.com/users/kingpong","html_url":"https://github.com/kingpong","followers_url":"https://api.github.com/users/kingpong/followers","following_url":"https://api.github.com/users/kingpong/following{/other_user}","gists_url":"https://api.github.com/users/kingpong/gists{/gist_id}","starred_url":"https://api.github.com/users/kingpong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingpong/subscriptions","organizations_url":"https://api.github.com/users/kingpong/orgs","repos_url":"https://api.github.com/users/kingpong/repos","events_url":"https://api.github.com/users/kingpong/events{/privacy}","received_events_url":"https://api.github.com/users/kingpong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kingpong/consul-cookbook","description":"Application cookbook which installs and configures Consul.","fork":true,"url":"https://api.github.com/repos/kingpong/consul-cookbook","forks_url":"https://api.github.com/repos/kingpong/consul-cookbook/forks","keys_url":"https://api.github.com/repos/kingpong/consul-cookbook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kingpong/consul-cookbook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kingpong/consul-cookbook/teams","hooks_url":"https://api.github.com/repos/kingpong/consul-cookbook/hooks","issue_events_url":"https://api.github.com/repos/kingpong/consul-cookbook/issues/events{/number}","events_url":"https://api.github.com/repos/kingpong/consul-cookbook/events","assignees_url":"https://api.github.com/repos/kingpong/consul-cookbook/assignees{/user}","branches_url":"https://api.github.com/repos/kingpong/consul-cookbook/branches{/branch}","tags_url":"https://api.github.com/repos/kingpong/consul-cookbook/tags","blobs_url":"https://api.github.com/repos/kingpong/consul-cookbook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kingpong/consul-cookbook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kingpong/consul-cookbook/git/refs{/sha}","trees_url":"https://api.github.com/repos/kingpong/consul-cookbook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kingpong/consul-cookbook/statuses/{sha}","languages_url":"https://api.github.com/repos/kingpong/consul-cookbook/languages","stargazers_url":"https://api.github.com/repos/kingpong/consul-cookbook/stargazers","contributors_url":"https://api.github.com/repos/kingpong/consul-cookbook/contributors","subscribers_url":"https://api.github.com/repos/kingpong/consul-cookbook/subscribers","subscription_url":"https://api.github.com/repos/kingpong/consul-cookbook/subscription","commits_url":"https://api.github.com/repos/kingpong/consul-cookbook/commits{/sha}","git_commits_url":"https://api.github.com/repos/kingpong/consul-cookbook/git/commits{/sha}","comments_url":"https://api.github.com/repos/kingpong/consul-cookbook/comments{/number}","issue_comment_url":"https://api.github.com/repos/kingpong/consul-cookbook/issues/comments{/number}","contents_url":"https://api.github.com/repos/kingpong/consul-cookbook/contents/{+path}","compare_url":"https://api.github.com/repos/kingpong/consul-cookbook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kingpong/consul-cookbook/merges","archive_url":"https://api.github.com/repos/kingpong/consul-cookbook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kingpong/consul-cookbook/downloads","issues_url":"https://api.github.com/repos/kingpong/consul-cookbook/issues{/number}","pulls_url":"https://api.github.com/repos/kingpong/consul-cookbook/pulls{/number}","milestones_url":"https://api.github.com/repos/kingpong/consul-cookbook/milestones{/number}","notifications_url":"https://api.github.com/repos/kingpong/consul-cookbook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kingpong/consul-cookbook/labels{/name}","releases_url":"https://api.github.com/repos/kingpong/consul-cookbook/releases{/id}","deployments_url":"https://api.github.com/repos/kingpong/consul-cookbook/deployments","created_at":"2016-06-04T15:12:58Z","updated_at":"2016-06-04T15:12:59Z","pushed_at":"2016-06-10T02:07:15Z","git_url":"git://github.com/kingpong/consul-cookbook.git","ssh_url":"git@github.com:kingpong/consul-cookbook.git","clone_url":"https://github.com/kingpong/consul-cookbook.git","svn_url":"https://github.com/kingpong/consul-cookbook","homepage":"http://consul.io","size":677,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"johnbellone:master","ref":"master","sha":"e9bfef299982a941cfff487ce6a9253af55dbdf7","user":{"login":"johnbellone","id":241756,"avatar_url":"https://avatars.githubusercontent.com/u/241756?v=3","gravatar_id":"","url":"https://api.github.com/users/johnbellone","html_url":"https://github.com/johnbellone","followers_url":"https://api.github.com/users/johnbellone/followers","following_url":"https://api.github.com/users/johnbellone/following{/other_user}","gists_url":"https://api.github.com/users/johnbellone/gists{/gist_id}","starred_url":"https://api.github.com/users/johnbellone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnbellone/subscriptions","organizations_url":"https://api.github.com/users/johnbellone/orgs","repos_url":"https://api.github.com/users/johnbellone/repos","events_url":"https://api.github.com/users/johnbellone/events{/privacy}","received_events_url":"https://api.github.com/users/johnbellone/received_events","type":"User","site_admin":false},"repo":{"id":18902498,"name":"consul-cookbook","full_name":"johnbellone/consul-cookbook","owner":{"login":"johnbellone","id":241756,"avatar_url":"https://avatars.githubusercontent.com/u/241756?v=3","gravatar_id":"","url":"https://api.github.com/users/johnbellone","html_url":"https://github.com/johnbellone","followers_url":"https://api.github.com/users/johnbellone/followers","following_url":"https://api.github.com/users/johnbellone/following{/other_user}","gists_url":"https://api.github.com/users/johnbellone/gists{/gist_id}","starred_url":"https://api.github.com/users/johnbellone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnbellone/subscriptions","organizations_url":"https://api.github.com/users/johnbellone/orgs","repos_url":"https://api.github.com/users/johnbellone/repos","events_url":"https://api.github.com/users/johnbellone/events{/privacy}","received_events_url":"https://api.github.com/users/johnbellone/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnbellone/consul-cookbook","description":"Application cookbook which installs and configures Consul.","fork":false,"url":"https://api.github.com/repos/johnbellone/consul-cookbook","forks_url":"https://api.github.com/repos/johnbellone/consul-cookbook/forks","keys_url":"https://api.github.com/repos/johnbellone/consul-cookbook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnbellone/consul-cookbook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnbellone/consul-cookbook/teams","hooks_url":"https://api.github.com/repos/johnbellone/consul-cookbook/hooks","issue_events_url":"https://api.github.com/repos/johnbellone/consul-cookbook/issues/events{/number}","events_url":"https://api.github.com/repos/johnbellone/consul-cookbook/events","assignees_url":"https://api.github.com/repos/johnbellone/consul-cookbook/assignees{/user}","branches_url":"https://api.github.com/repos/johnbellone/consul-cookbook/branches{/branch}","tags_url":"https://api.github.com/repos/johnbellone/consul-cookbook/tags","blobs_url":"https://api.github.com/repos/johnbellone/consul-cookbook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnbellone/consul-cookbook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnbellone/consul-cookbook/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnbellone/consul-cookbook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnbellone/consul-cookbook/statuses/{sha}","languages_url":"https://api.github.com/repos/johnbellone/consul-cookbook/languages","stargazers_url":"https://api.github.com/repos/johnbellone/consul-cookbook/stargazers","contributors_url":"https://api.github.com/repos/johnbellone/consul-cookbook/contributors","subscribers_url":"https://api.github.com/repos/johnbellone/consul-cookbook/subscribers","subscription_url":"https://api.github.com/repos/johnbellone/consul-cookbook/subscription","commits_url":"https://api.github.com/repos/johnbellone/consul-cookbook/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnbellone/consul-cookbook/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnbellone/consul-cookbook/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnbellone/consul-cookbook/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnbellone/consul-cookbook/contents/{+path}","compare_url":"https://api.github.com/repos/johnbellone/consul-cookbook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnbellone/consul-cookbook/merges","archive_url":"https://api.github.com/repos/johnbellone/consul-cookbook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnbellone/consul-cookbook/downloads","issues_url":"https://api.github.com/repos/johnbellone/consul-cookbook/issues{/number}","pulls_url":"https://api.github.com/repos/johnbellone/consul-cookbook/pulls{/number}","milestones_url":"https://api.github.com/repos/johnbellone/consul-cookbook/milestones{/number}","notifications_url":"https://api.github.com/repos/johnbellone/consul-cookbook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnbellone/consul-cookbook/labels{/name}","releases_url":"https://api.github.com/repos/johnbellone/consul-cookbook/releases{/id}","deployments_url":"https://api.github.com/repos/johnbellone/consul-cookbook/deployments","created_at":"2014-04-18T04:26:51Z","updated_at":"2016-06-09T07:05:45Z","pushed_at":"2016-06-10T02:07:16Z","git_url":"git://github.com/johnbellone/consul-cookbook.git","ssh_url":"git@github.com:johnbellone/consul-cookbook.git","clone_url":"https://github.com/johnbellone/consul-cookbook.git","svn_url":"https://github.com/johnbellone/consul-cookbook","homepage":"http://consul.io","size":870,"stargazers_count":117,"watchers_count":117,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":164,"mirror_url":null,"open_issues_count":10,"forks":164,"open_issues":10,"watchers":117,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/johnbellone/consul-cookbook/pulls/323"},"html":{"href":"https://github.com/johnbellone/consul-cookbook/pull/323"},"issue":{"href":"https://api.github.com/repos/johnbellone/consul-cookbook/issues/323"},"comments":{"href":"https://api.github.com/repos/johnbellone/consul-cookbook/issues/323/comments"},"review_comments":{"href":"https://api.github.com/repos/johnbellone/consul-cookbook/pulls/323/comments"},"review_comment":{"href":"https://api.github.com/repos/johnbellone/consul-cookbook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/johnbellone/consul-cookbook/pulls/323/commits"},"statuses":{"href":"https://api.github.com/repos/johnbellone/consul-cookbook/statuses/ab8d631236fd8daa6198037d69c4dc92af3ece64"}}}}
{"actor":{"display_login":"kingpong"}}