{"action":"created","comment":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/comments/94048077","pull_request_review_id":14578356,"id":94048077,"diff_hunk":"@@ -166,14 +166,21 @@\n     }\n }\n \n+.float-media, .media_image {\n+    .respond-to-print( {\n+        width: 0;\n+        max-width: 0;\n+        display: none;\n+    } );\n+}\n \n /* topdoc\n   name: Responsive cropping\n   family: cfgov-misc\n   notes:\n     - \"A simple cropping pattern. We may need more advanced ones in the future.\"\n     - \"How it works: At smaller screens .rwd-crop is cropped to 75% of its\n-       original height and flexibily scales 100% of its parents width. At larger\n+       original height and flexib`ily scales 100% of its parents width. At larger","path":"cfgov/unprocessed/css/misc.less","position":19,"original_position":19,"commit_id":"3033e8005640b9765db100d7bf18b6574411a7cc","original_commit_id":"3033e8005640b9765db100d7bf18b6574411a7cc","user":{"login":"jimmynotjim","id":1280430,"avatar_url":"https://avatars.githubusercontent.com/u/1280430?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmynotjim","html_url":"https://github.com/jimmynotjim","followers_url":"https://api.github.com/users/jimmynotjim/followers","following_url":"https://api.github.com/users/jimmynotjim/following{/other_user}","gists_url":"https://api.github.com/users/jimmynotjim/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmynotjim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmynotjim/subscriptions","organizations_url":"https://api.github.com/users/jimmynotjim/orgs","repos_url":"https://api.github.com/users/jimmynotjim/repos","events_url":"https://api.github.com/users/jimmynotjim/events{/privacy}","received_events_url":"https://api.github.com/users/jimmynotjim/received_events","type":"User","site_admin":false},"body":"Looks like an errant back tick here","created_at":"2016-12-28T16:02:21Z","updated_at":"2016-12-28T16:05:53Z","html_url":"https://github.com/cfpb/cfgov-refresh/pull/2526#discussion_r94048077","pull_request_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/2526","_links":{"self":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/comments/94048077"},"html":{"href":"https://github.com/cfpb/cfgov-refresh/pull/2526#discussion_r94048077"},"pull_request":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/2526"}}},"pull_request":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/2526","id":93090276,"html_url":"https://github.com/cfpb/cfgov-refresh/pull/2526","diff_url":"https://github.com/cfpb/cfgov-refresh/pull/2526.diff","patch_url":"https://github.com/cfpb/cfgov-refresh/pull/2526.patch","issue_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2526","number":2526,"state":"open","locked":false,"title":"WIP: Desktop print styles","user":{"login":"virginiacc","id":778171,"avatar_url":"https://avatars.githubusercontent.com/u/778171?v=3","gravatar_id":"","url":"https://api.github.com/users/virginiacc","html_url":"https://github.com/virginiacc","followers_url":"https://api.github.com/users/virginiacc/followers","following_url":"https://api.github.com/users/virginiacc/following{/other_user}","gists_url":"https://api.github.com/users/virginiacc/gists{/gist_id}","starred_url":"https://api.github.com/users/virginiacc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virginiacc/subscriptions","organizations_url":"https://api.github.com/users/virginiacc/orgs","repos_url":"https://api.github.com/users/virginiacc/repos","events_url":"https://api.github.com/users/virginiacc/events{/privacy}","received_events_url":"https://api.github.com/users/virginiacc/received_events","type":"User","site_admin":false},"body":"- Some browsers (Chrome, Firefox, etc) use tablet styles when printing responsive layouts. This PR is an initial effort to apply desktop styles to printed output across browsers. \r\n- Firefox apparently only prints the first page of `inline-block` elements, which is an issue because we use `inline-block` to create two column layouts. This PR substitutes `display:table-cell` in a print media query so that Firefox will print the full text of pages with long `inline-block` elements.\r\n\r\n## Additions\r\n\r\n- Override `respond-to-min` mixin in `main.less` to add `print` to the media query it generates. This will cause the desktop styles to be used in printing across browsers.\r\n- Adds more styles needed for printing desktop layout in Firefox: page widths, font size bump, etc\r\n- Use `display:table-cell` instead of `inline-block` for columns in print media query\r\n- Add print style tweaks for homepage\r\n\r\n## Testing\r\n\r\n- Check out branch & run gulp styles\r\n- Check that pages print in desktop layout across browsers\r\n- Navigate to a blog page and verify that the full text prints in Firefox\r\n\r\n## Review\r\n\r\n- @Scotchester \r\n- @jimmynotjim \r\n\r\n## Screenshots\r\nBefore, print preview of blog page in Chrome:\r\n<img width=\"513\" alt=\"screen shot 2016-11-09 at 9 51 34 pm\" src=\"https://cloud.githubusercontent.com/assets/778171/20166032/e7b36c34-a6c6-11e6-8bbf-359096b708c7.png\">\r\n\r\n\r\nAfter, print preview of blog page in Chrome:\r\n\r\n<img width=\"507\" alt=\"screen shot 2016-11-09 at 9 51 48 pm\" src=\"https://cloud.githubusercontent.com/assets/778171/20166038/ee87dc0c-a6c6-11e6-9f64-6a009af28724.png\">\r\n\r\n\r\n## Notes\r\n\r\n- This is a work in progress/not ready to be merged. The basic print desktop layout seems to work across browsers, but there are tweaks & possibly design input needed for the different page types \r\n- Overriding the `respond-to-min` mixin seemed like the simplest approach to applying desktop styles to print, but cherry-picking the styles into a print media query is another option\r\n\r\n## Todos\r\n\r\n- On IE9, overriding `respond-to-min` seems to be breaking the header & footer. Need to figure out why this is happening\r\n\r\n## Checklist\r\n\r\n* [ ] Changes are limited to a single goal (no scope creep)\r\n* [ ] Code can be automatically merged (no conflicts)\r\n* [ ] Code follows the standards laid out in the [front end playbook](https://github.com/cfpb/front-end)\r\n* [ ] Passes all existing automated tests\r\n* [ ] New functions include new tests\r\n* [ ] New functions are documented (with a description, list of inputs, and expected output)\r\n* [ ] Placeholder code is flagged\r\n* [ ] Visually tested in supported browsers and devices\r\n* [ ] Project documentation has been updated (including the \"Unreleased\" section of the CHANGELOG)\r\n","created_at":"2016-11-10T05:43:09Z","updated_at":"2016-12-28T16:05:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed3d7fdd39755bf16b624ce91c36e68686b6d96d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/2526/commits","review_comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/2526/comments","review_comment_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2526/comments","statuses_url":"https://api.github.com/repos/cfpb/cfgov-refresh/statuses/3033e8005640b9765db100d7bf18b6574411a7cc","head":{"label":"cfpb:desktop-print-styles","ref":"desktop-print-styles","sha":"3033e8005640b9765db100d7bf18b6574411a7cc","user":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"repo":{"id":18852566,"name":"cfgov-refresh","full_name":"cfpb/cfgov-refresh","owner":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfpb/cfgov-refresh","description":"Django project that powers the redesigned consumerfinance.gov website.","fork":false,"url":"https://api.github.com/repos/cfpb/cfgov-refresh","forks_url":"https://api.github.com/repos/cfpb/cfgov-refresh/forks","keys_url":"https://api.github.com/repos/cfpb/cfgov-refresh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfpb/cfgov-refresh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfpb/cfgov-refresh/teams","hooks_url":"https://api.github.com/repos/cfpb/cfgov-refresh/hooks","issue_events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/events{/number}","events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/events","assignees_url":"https://api.github.com/repos/cfpb/cfgov-refresh/assignees{/user}","branches_url":"https://api.github.com/repos/cfpb/cfgov-refresh/branches{/branch}","tags_url":"https://api.github.com/repos/cfpb/cfgov-refresh/tags","blobs_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfpb/cfgov-refresh/statuses/{sha}","languages_url":"https://api.github.com/repos/cfpb/cfgov-refresh/languages","stargazers_url":"https://api.github.com/repos/cfpb/cfgov-refresh/stargazers","contributors_url":"https://api.github.com/repos/cfpb/cfgov-refresh/contributors","subscribers_url":"https://api.github.com/repos/cfpb/cfgov-refresh/subscribers","subscription_url":"https://api.github.com/repos/cfpb/cfgov-refresh/subscription","commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfpb/cfgov-refresh/contents/{+path}","compare_url":"https://api.github.com/repos/cfpb/cfgov-refresh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfpb/cfgov-refresh/merges","archive_url":"https://api.github.com/repos/cfpb/cfgov-refresh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfpb/cfgov-refresh/downloads","issues_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues{/number}","pulls_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls{/number}","milestones_url":"https://api.github.com/repos/cfpb/cfgov-refresh/milestones{/number}","notifications_url":"https://api.github.com/repos/cfpb/cfgov-refresh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfpb/cfgov-refresh/labels{/name}","releases_url":"https://api.github.com/repos/cfpb/cfgov-refresh/releases{/id}","deployments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/deployments","created_at":"2014-04-16T19:22:03Z","updated_at":"2016-12-02T14:19:03Z","pushed_at":"2016-12-28T15:40:28Z","git_url":"git://github.com/cfpb/cfgov-refresh.git","ssh_url":"git@github.com:cfpb/cfgov-refresh.git","clone_url":"https://github.com/cfpb/cfgov-refresh.git","svn_url":"https://github.com/cfpb/cfgov-refresh","homepage":"http://www.consumerfinance.gov/","size":63499,"stargazers_count":77,"watchers_count":77,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":42,"mirror_url":null,"open_issues_count":88,"forks":42,"open_issues":88,"watchers":77,"default_branch":"master"}},"base":{"label":"cfpb:master","ref":"master","sha":"5fc76cd8dd961fd4913ea8bf044b4311d215ed4d","user":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"repo":{"id":18852566,"name":"cfgov-refresh","full_name":"cfpb/cfgov-refresh","owner":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfpb/cfgov-refresh","description":"Django project that powers the redesigned consumerfinance.gov website.","fork":false,"url":"https://api.github.com/repos/cfpb/cfgov-refresh","forks_url":"https://api.github.com/repos/cfpb/cfgov-refresh/forks","keys_url":"https://api.github.com/repos/cfpb/cfgov-refresh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfpb/cfgov-refresh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfpb/cfgov-refresh/teams","hooks_url":"https://api.github.com/repos/cfpb/cfgov-refresh/hooks","issue_events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/events{/number}","events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/events","assignees_url":"https://api.github.com/repos/cfpb/cfgov-refresh/assignees{/user}","branches_url":"https://api.github.com/repos/cfpb/cfgov-refresh/branches{/branch}","tags_url":"https://api.github.com/repos/cfpb/cfgov-refresh/tags","blobs_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfpb/cfgov-refresh/statuses/{sha}","languages_url":"https://api.github.com/repos/cfpb/cfgov-refresh/languages","stargazers_url":"https://api.github.com/repos/cfpb/cfgov-refresh/stargazers","contributors_url":"https://api.github.com/repos/cfpb/cfgov-refresh/contributors","subscribers_url":"https://api.github.com/repos/cfpb/cfgov-refresh/subscribers","subscription_url":"https://api.github.com/repos/cfpb/cfgov-refresh/subscription","commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfpb/cfgov-refresh/contents/{+path}","compare_url":"https://api.github.com/repos/cfpb/cfgov-refresh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfpb/cfgov-refresh/merges","archive_url":"https://api.github.com/repos/cfpb/cfgov-refresh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfpb/cfgov-refresh/downloads","issues_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues{/number}","pulls_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls{/number}","milestones_url":"https://api.github.com/repos/cfpb/cfgov-refresh/milestones{/number}","notifications_url":"https://api.github.com/repos/cfpb/cfgov-refresh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfpb/cfgov-refresh/labels{/name}","releases_url":"https://api.github.com/repos/cfpb/cfgov-refresh/releases{/id}","deployments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/deployments","created_at":"2014-04-16T19:22:03Z","updated_at":"2016-12-02T14:19:03Z","pushed_at":"2016-12-28T15:40:28Z","git_url":"git://github.com/cfpb/cfgov-refresh.git","ssh_url":"git@github.com:cfpb/cfgov-refresh.git","clone_url":"https://github.com/cfpb/cfgov-refresh.git","svn_url":"https://github.com/cfpb/cfgov-refresh","homepage":"http://www.consumerfinance.gov/","size":63499,"stargazers_count":77,"watchers_count":77,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":42,"mirror_url":null,"open_issues_count":88,"forks":42,"open_issues":88,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/2526"},"html":{"href":"https://github.com/cfpb/cfgov-refresh/pull/2526"},"issue":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2526"},"comments":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2526/comments"},"review_comments":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/2526/comments"},"review_comment":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/2526/commits"},"statuses":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/statuses/3033e8005640b9765db100d7bf18b6574411a7cc"}}}}
{"actor":{"display_login":"jimmynotjim"}}