{"action":"created","comment":{"url":"https://api.github.com/repos/codecombat/codecombat/pulls/comments/73726364","id":73726364,"diff_hunk":"@@ -8,15 +8,16 @@ ConfirmModal = require 'views/editor/modal/ConfirmModal'\n algolia = require 'core/services/algolia'\n \n SIGNUP_REDIRECT = '/teachers'\n-NCES_KEYS = ['id', 'name', 'district', 'district_id', 'district_schools', 'district_students', 'students', 'phone']\n+DISTRICT_NCES_KEYS = ['district', 'district_id', 'district_schools', 'district_students', 'phone']\n+SCHOOL_NCES_KEYS = DISTRICT_NCES_KEYS.concat(['id', 'name', 'students'])\n \n module.exports = class RequestQuoteView extends RootView\n   id: 'request-quote-view'\n   template: require 'templates/teachers/request-quote-view'\n   logoutRedirectURL: null\n \n   events:\n-    'change #request-form': 'onChangeRequestForm'\n+    'change #request-form': 'onChangeForm'","path":"app/views/teachers/RequestQuoteView.coffee","position":15,"original_position":15,"commit_id":"8dd10d6fa26a0fd3a9265d75e69f85d1ea58a2b0","original_commit_id":"8dd10d6fa26a0fd3a9265d75e69f85d1ea58a2b0","user":{"login":"sderickson","id":204723,"avatar_url":"https://avatars.githubusercontent.com/u/204723?v=3","gravatar_id":"","url":"https://api.github.com/users/sderickson","html_url":"https://github.com/sderickson","followers_url":"https://api.github.com/users/sderickson/followers","following_url":"https://api.github.com/users/sderickson/following{/other_user}","gists_url":"https://api.github.com/users/sderickson/gists{/gist_id}","starred_url":"https://api.github.com/users/sderickson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sderickson/subscriptions","organizations_url":"https://api.github.com/users/sderickson/orgs","repos_url":"https://api.github.com/users/sderickson/repos","events_url":"https://api.github.com/users/sderickson/events{/privacy}","received_events_url":"https://api.github.com/users/sderickson/received_events","type":"User","site_admin":false},"body":"There are two forms in this view, a request form and a signup form, so it would be better to keep this specifically named.","created_at":"2016-08-05T17:08:46Z","updated_at":"2016-08-05T17:08:46Z","html_url":"https://github.com/codecombat/codecombat/pull/3818#discussion_r73726364","pull_request_url":"https://api.github.com/repos/codecombat/codecombat/pulls/3818","_links":{"self":{"href":"https://api.github.com/repos/codecombat/codecombat/pulls/comments/73726364"},"html":{"href":"https://github.com/codecombat/codecombat/pull/3818#discussion_r73726364"},"pull_request":{"href":"https://api.github.com/repos/codecombat/codecombat/pulls/3818"}}},"pull_request":{"url":"https://api.github.com/repos/codecombat/codecombat/pulls/3818","id":80268074,"html_url":"https://github.com/codecombat/codecombat/pull/3818","diff_url":"https://github.com/codecombat/codecombat/pull/3818.diff","patch_url":"https://github.com/codecombat/codecombat/pull/3818.patch","issue_url":"https://api.github.com/repos/codecombat/codecombat/issues/3818","number":3818,"state":"open","locked":false,"title":"Add required district field to teacher trial request forms","user":{"login":"differentmatt","id":2965172,"avatar_url":"https://avatars.githubusercontent.com/u/2965172?v=3","gravatar_id":"","url":"https://api.github.com/users/differentmatt","html_url":"https://github.com/differentmatt","followers_url":"https://api.github.com/users/differentmatt/followers","following_url":"https://api.github.com/users/differentmatt/following{/other_user}","gists_url":"https://api.github.com/users/differentmatt/gists{/gist_id}","starred_url":"https://api.github.com/users/differentmatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/differentmatt/subscriptions","organizations_url":"https://api.github.com/users/differentmatt/orgs","repos_url":"https://api.github.com/users/differentmatt/repos","events_url":"https://api.github.com/users/differentmatt/events{/privacy}","received_events_url":"https://api.github.com/users/differentmatt/received_events","type":"User","site_admin":false},"body":"School now optional\nN/A placeholder on district field and don't save it if it's n/a\nUpdating required field error UI a bit, and there is some larger\nrefactoring needed here later.\nNCES phone number for district only entries will currently be a child\nschool, will fix later.","created_at":"2016-08-05T16:08:55Z","updated_at":"2016-08-05T17:08:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4866358202d414afc3bd6335d65673e3434b992","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/codecombat/codecombat/pulls/3818/commits","review_comments_url":"https://api.github.com/repos/codecombat/codecombat/pulls/3818/comments","review_comment_url":"https://api.github.com/repos/codecombat/codecombat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codecombat/codecombat/issues/3818/comments","statuses_url":"https://api.github.com/repos/codecombat/codecombat/statuses/8dd10d6fa26a0fd3a9265d75e69f85d1ea58a2b0","head":{"label":"codecombat:district-field","ref":"district-field","sha":"8dd10d6fa26a0fd3a9265d75e69f85d1ea58a2b0","user":{"login":"codecombat","id":5795842,"avatar_url":"https://avatars.githubusercontent.com/u/5795842?v=3","gravatar_id":"","url":"https://api.github.com/users/codecombat","html_url":"https://github.com/codecombat","followers_url":"https://api.github.com/users/codecombat/followers","following_url":"https://api.github.com/users/codecombat/following{/other_user}","gists_url":"https://api.github.com/users/codecombat/gists{/gist_id}","starred_url":"https://api.github.com/users/codecombat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecombat/subscriptions","organizations_url":"https://api.github.com/users/codecombat/orgs","repos_url":"https://api.github.com/users/codecombat/repos","events_url":"https://api.github.com/users/codecombat/events{/privacy}","received_events_url":"https://api.github.com/users/codecombat/received_events","type":"Organization","site_admin":false},"repo":{"id":15193430,"name":"codecombat","full_name":"codecombat/codecombat","owner":{"login":"codecombat","id":5795842,"avatar_url":"https://avatars.githubusercontent.com/u/5795842?v=3","gravatar_id":"","url":"https://api.github.com/users/codecombat","html_url":"https://github.com/codecombat","followers_url":"https://api.github.com/users/codecombat/followers","following_url":"https://api.github.com/users/codecombat/following{/other_user}","gists_url":"https://api.github.com/users/codecombat/gists{/gist_id}","starred_url":"https://api.github.com/users/codecombat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecombat/subscriptions","organizations_url":"https://api.github.com/users/codecombat/orgs","repos_url":"https://api.github.com/users/codecombat/repos","events_url":"https://api.github.com/users/codecombat/events{/privacy}","received_events_url":"https://api.github.com/users/codecombat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codecombat/codecombat","description":"Game for learning how to code.","fork":false,"url":"https://api.github.com/repos/codecombat/codecombat","forks_url":"https://api.github.com/repos/codecombat/codecombat/forks","keys_url":"https://api.github.com/repos/codecombat/codecombat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codecombat/codecombat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codecombat/codecombat/teams","hooks_url":"https://api.github.com/repos/codecombat/codecombat/hooks","issue_events_url":"https://api.github.com/repos/codecombat/codecombat/issues/events{/number}","events_url":"https://api.github.com/repos/codecombat/codecombat/events","assignees_url":"https://api.github.com/repos/codecombat/codecombat/assignees{/user}","branches_url":"https://api.github.com/repos/codecombat/codecombat/branches{/branch}","tags_url":"https://api.github.com/repos/codecombat/codecombat/tags","blobs_url":"https://api.github.com/repos/codecombat/codecombat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codecombat/codecombat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codecombat/codecombat/git/refs{/sha}","trees_url":"https://api.github.com/repos/codecombat/codecombat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codecombat/codecombat/statuses/{sha}","languages_url":"https://api.github.com/repos/codecombat/codecombat/languages","stargazers_url":"https://api.github.com/repos/codecombat/codecombat/stargazers","contributors_url":"https://api.github.com/repos/codecombat/codecombat/contributors","subscribers_url":"https://api.github.com/repos/codecombat/codecombat/subscribers","subscription_url":"https://api.github.com/repos/codecombat/codecombat/subscription","commits_url":"https://api.github.com/repos/codecombat/codecombat/commits{/sha}","git_commits_url":"https://api.github.com/repos/codecombat/codecombat/git/commits{/sha}","comments_url":"https://api.github.com/repos/codecombat/codecombat/comments{/number}","issue_comment_url":"https://api.github.com/repos/codecombat/codecombat/issues/comments{/number}","contents_url":"https://api.github.com/repos/codecombat/codecombat/contents/{+path}","compare_url":"https://api.github.com/repos/codecombat/codecombat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codecombat/codecombat/merges","archive_url":"https://api.github.com/repos/codecombat/codecombat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codecombat/codecombat/downloads","issues_url":"https://api.github.com/repos/codecombat/codecombat/issues{/number}","pulls_url":"https://api.github.com/repos/codecombat/codecombat/pulls{/number}","milestones_url":"https://api.github.com/repos/codecombat/codecombat/milestones{/number}","notifications_url":"https://api.github.com/repos/codecombat/codecombat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codecombat/codecombat/labels{/name}","releases_url":"https://api.github.com/repos/codecombat/codecombat/releases{/id}","deployments_url":"https://api.github.com/repos/codecombat/codecombat/deployments","created_at":"2013-12-14T21:47:37Z","updated_at":"2016-08-05T16:42:56Z","pushed_at":"2016-08-05T16:21:42Z","git_url":"git://github.com/codecombat/codecombat.git","ssh_url":"git@github.com:codecombat/codecombat.git","clone_url":"https://github.com/codecombat/codecombat.git","svn_url":"https://github.com/codecombat/codecombat","homepage":"http://codecombat.com","size":147340,"stargazers_count":5175,"watchers_count":5175,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2491,"mirror_url":null,"open_issues_count":299,"forks":2491,"open_issues":299,"watchers":5175,"default_branch":"master"}},"base":{"label":"codecombat:master","ref":"master","sha":"246469bdde862b6e5ea5afbcc1e6825b34cc4734","user":{"login":"codecombat","id":5795842,"avatar_url":"https://avatars.githubusercontent.com/u/5795842?v=3","gravatar_id":"","url":"https://api.github.com/users/codecombat","html_url":"https://github.com/codecombat","followers_url":"https://api.github.com/users/codecombat/followers","following_url":"https://api.github.com/users/codecombat/following{/other_user}","gists_url":"https://api.github.com/users/codecombat/gists{/gist_id}","starred_url":"https://api.github.com/users/codecombat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecombat/subscriptions","organizations_url":"https://api.github.com/users/codecombat/orgs","repos_url":"https://api.github.com/users/codecombat/repos","events_url":"https://api.github.com/users/codecombat/events{/privacy}","received_events_url":"https://api.github.com/users/codecombat/received_events","type":"Organization","site_admin":false},"repo":{"id":15193430,"name":"codecombat","full_name":"codecombat/codecombat","owner":{"login":"codecombat","id":5795842,"avatar_url":"https://avatars.githubusercontent.com/u/5795842?v=3","gravatar_id":"","url":"https://api.github.com/users/codecombat","html_url":"https://github.com/codecombat","followers_url":"https://api.github.com/users/codecombat/followers","following_url":"https://api.github.com/users/codecombat/following{/other_user}","gists_url":"https://api.github.com/users/codecombat/gists{/gist_id}","starred_url":"https://api.github.com/users/codecombat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecombat/subscriptions","organizations_url":"https://api.github.com/users/codecombat/orgs","repos_url":"https://api.github.com/users/codecombat/repos","events_url":"https://api.github.com/users/codecombat/events{/privacy}","received_events_url":"https://api.github.com/users/codecombat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codecombat/codecombat","description":"Game for learning how to code.","fork":false,"url":"https://api.github.com/repos/codecombat/codecombat","forks_url":"https://api.github.com/repos/codecombat/codecombat/forks","keys_url":"https://api.github.com/repos/codecombat/codecombat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codecombat/codecombat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codecombat/codecombat/teams","hooks_url":"https://api.github.com/repos/codecombat/codecombat/hooks","issue_events_url":"https://api.github.com/repos/codecombat/codecombat/issues/events{/number}","events_url":"https://api.github.com/repos/codecombat/codecombat/events","assignees_url":"https://api.github.com/repos/codecombat/codecombat/assignees{/user}","branches_url":"https://api.github.com/repos/codecombat/codecombat/branches{/branch}","tags_url":"https://api.github.com/repos/codecombat/codecombat/tags","blobs_url":"https://api.github.com/repos/codecombat/codecombat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codecombat/codecombat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codecombat/codecombat/git/refs{/sha}","trees_url":"https://api.github.com/repos/codecombat/codecombat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codecombat/codecombat/statuses/{sha}","languages_url":"https://api.github.com/repos/codecombat/codecombat/languages","stargazers_url":"https://api.github.com/repos/codecombat/codecombat/stargazers","contributors_url":"https://api.github.com/repos/codecombat/codecombat/contributors","subscribers_url":"https://api.github.com/repos/codecombat/codecombat/subscribers","subscription_url":"https://api.github.com/repos/codecombat/codecombat/subscription","commits_url":"https://api.github.com/repos/codecombat/codecombat/commits{/sha}","git_commits_url":"https://api.github.com/repos/codecombat/codecombat/git/commits{/sha}","comments_url":"https://api.github.com/repos/codecombat/codecombat/comments{/number}","issue_comment_url":"https://api.github.com/repos/codecombat/codecombat/issues/comments{/number}","contents_url":"https://api.github.com/repos/codecombat/codecombat/contents/{+path}","compare_url":"https://api.github.com/repos/codecombat/codecombat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codecombat/codecombat/merges","archive_url":"https://api.github.com/repos/codecombat/codecombat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codecombat/codecombat/downloads","issues_url":"https://api.github.com/repos/codecombat/codecombat/issues{/number}","pulls_url":"https://api.github.com/repos/codecombat/codecombat/pulls{/number}","milestones_url":"https://api.github.com/repos/codecombat/codecombat/milestones{/number}","notifications_url":"https://api.github.com/repos/codecombat/codecombat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codecombat/codecombat/labels{/name}","releases_url":"https://api.github.com/repos/codecombat/codecombat/releases{/id}","deployments_url":"https://api.github.com/repos/codecombat/codecombat/deployments","created_at":"2013-12-14T21:47:37Z","updated_at":"2016-08-05T16:42:56Z","pushed_at":"2016-08-05T16:21:42Z","git_url":"git://github.com/codecombat/codecombat.git","ssh_url":"git@github.com:codecombat/codecombat.git","clone_url":"https://github.com/codecombat/codecombat.git","svn_url":"https://github.com/codecombat/codecombat","homepage":"http://codecombat.com","size":147340,"stargazers_count":5175,"watchers_count":5175,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2491,"mirror_url":null,"open_issues_count":299,"forks":2491,"open_issues":299,"watchers":5175,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codecombat/codecombat/pulls/3818"},"html":{"href":"https://github.com/codecombat/codecombat/pull/3818"},"issue":{"href":"https://api.github.com/repos/codecombat/codecombat/issues/3818"},"comments":{"href":"https://api.github.com/repos/codecombat/codecombat/issues/3818/comments"},"review_comments":{"href":"https://api.github.com/repos/codecombat/codecombat/pulls/3818/comments"},"review_comment":{"href":"https://api.github.com/repos/codecombat/codecombat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codecombat/codecombat/pulls/3818/commits"},"statuses":{"href":"https://api.github.com/repos/codecombat/codecombat/statuses/8dd10d6fa26a0fd3a9265d75e69f85d1ea58a2b0"}}}}
{"actor":{"display_login":"sderickson"}}