{"action":"created","comment":{"url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/pulls/comments/70794260","id":70794260,"diff_hunk":"@@ -34,33 +34,9 @@\n # under which the OpenSSL Project distributes the OpenSSL toolkit software,\n # as those licenses appear in the file LICENSE-OPENSSL.\n \n-MGMT_WHITELIST_DIR=/etc/clearwater-socket-factory/management.d\n-SIGNALING_WHITELIST_DIR=/etc/clearwater-socket-factory/signaling.d\n+WHITELIST_DIR=/etc/clearwater-socket-factory/management.d\n+NAMESPACE=management\n \n-get_daemon_args()\n-{\n-  . /etc/clearwater/config\n+. /usr/share/clearwater/bin/clearwater-socket-factory-common","path":"clearwater-socket-factory/clearwater-socket-factory-mgmt-service","position":20,"original_position":20,"commit_id":"d7edca916b4a9c38e2c256c96a1bdcf7d3f8113c","original_commit_id":"d7edca916b4a9c38e2c256c96a1bdcf7d3f8113c","user":{"login":"steelyvoid","id":8615257,"avatar_url":"https://avatars.githubusercontent.com/u/8615257?v=3","gravatar_id":"","url":"https://api.github.com/users/steelyvoid","html_url":"https://github.com/steelyvoid","followers_url":"https://api.github.com/users/steelyvoid/followers","following_url":"https://api.github.com/users/steelyvoid/following{/other_user}","gists_url":"https://api.github.com/users/steelyvoid/gists{/gist_id}","starred_url":"https://api.github.com/users/steelyvoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steelyvoid/subscriptions","organizations_url":"https://api.github.com/users/steelyvoid/orgs","repos_url":"https://api.github.com/users/steelyvoid/repos","events_url":"https://api.github.com/users/steelyvoid/events{/privacy}","received_events_url":"https://api.github.com/users/steelyvoid/received_events","type":"User","site_admin":false},"body":"OK.  Not sure what this will look like, so I'll discuss offline","created_at":"2016-07-14T12:14:30Z","updated_at":"2016-07-14T12:14:30Z","html_url":"https://github.com/Metaswitch/clearwater-infrastructure/pull/337#discussion_r70794260","pull_request_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/pulls/337","_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/pulls/comments/70794260"},"html":{"href":"https://github.com/Metaswitch/clearwater-infrastructure/pull/337#discussion_r70794260"},"pull_request":{"href":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/pulls/337"}}},"pull_request":{"url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/pulls/337","id":75096561,"html_url":"https://github.com/Metaswitch/clearwater-infrastructure/pull/337","diff_url":"https://github.com/Metaswitch/clearwater-infrastructure/pull/337.diff","patch_url":"https://github.com/Metaswitch/clearwater-infrastructure/pull/337.patch","issue_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/issues/337","number":337,"state":"open","locked":false,"title":"Split socket factory into one instance per namespace to avoid signaling DNS issues","user":{"login":"steelyvoid","id":8615257,"avatar_url":"https://avatars.githubusercontent.com/u/8615257?v=3","gravatar_id":"","url":"https://api.github.com/users/steelyvoid","html_url":"https://github.com/steelyvoid","followers_url":"https://api.github.com/users/steelyvoid/followers","following_url":"https://api.github.com/users/steelyvoid/following{/other_user}","gists_url":"https://api.github.com/users/steelyvoid/gists{/gist_id}","starred_url":"https://api.github.com/users/steelyvoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steelyvoid/subscriptions","organizations_url":"https://api.github.com/users/steelyvoid/orgs","repos_url":"https://api.github.com/users/steelyvoid/repos","events_url":"https://api.github.com/users/steelyvoid/events{/privacy}","received_events_url":"https://api.github.com/users/steelyvoid/received_events","type":"User","site_admin":false},"body":"This is the fix to split the socket factory into two upstart jobs (one per namespace) so that connections can be made to the signaling namespace by name (the existing, single socket factory, cannot do this, apparently because the process is stuck with the management namespace DNS servers, so lookups form the signaling namespace will fail, in general).\r\n\r\nThis has been tested on Ubuntu, but not CentOS (and the fix includes CentOS -specific changes.\r\n\r\nMatt, are you OK to schedule testing of a CentOS build and install from this branch to check that my changes below are good?  What we're looking for on the running system is ps output that looks like this\r\n\r\nclearwater@l3-cc3-hstead1:/usr/share/clearwater/bin$ ps -ef | grep socket_factory\r\nroot     20374 20110  0 10:30 ?        00:00:00 /usr/share/clearwater/bin/clearwater_socket_factory --allowed-hosts=sas.mydomain --namespace management\r\nroot     20375 20125  0 10:30 ?        00:00:00 /bin/bash /usr/share/clearwater/bin/run-in-signaling-namespace /usr/share/clearwater/bin/clearwater_socket_factory --namespace signaling\r\nroot     20379 20375  0 10:30 ?        00:00:00 /usr/share/clearwater/bin/clearwater_socket_factory --namespace signaling\r\n\r\nThanks","created_at":"2016-06-24T10:47:16Z","updated_at":"2016-07-14T12:14:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9cacfeb0ecc1abab98799ce0bb237c8c90d9a93","assignee":{"login":"steelyvoid","id":8615257,"avatar_url":"https://avatars.githubusercontent.com/u/8615257?v=3","gravatar_id":"","url":"https://api.github.com/users/steelyvoid","html_url":"https://github.com/steelyvoid","followers_url":"https://api.github.com/users/steelyvoid/followers","following_url":"https://api.github.com/users/steelyvoid/following{/other_user}","gists_url":"https://api.github.com/users/steelyvoid/gists{/gist_id}","starred_url":"https://api.github.com/users/steelyvoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steelyvoid/subscriptions","organizations_url":"https://api.github.com/users/steelyvoid/orgs","repos_url":"https://api.github.com/users/steelyvoid/repos","events_url":"https://api.github.com/users/steelyvoid/events{/privacy}","received_events_url":"https://api.github.com/users/steelyvoid/received_events","type":"User","site_admin":false},"assignees":[{"login":"steelyvoid","id":8615257,"avatar_url":"https://avatars.githubusercontent.com/u/8615257?v=3","gravatar_id":"","url":"https://api.github.com/users/steelyvoid","html_url":"https://github.com/steelyvoid","followers_url":"https://api.github.com/users/steelyvoid/followers","following_url":"https://api.github.com/users/steelyvoid/following{/other_user}","gists_url":"https://api.github.com/users/steelyvoid/gists{/gist_id}","starred_url":"https://api.github.com/users/steelyvoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steelyvoid/subscriptions","organizations_url":"https://api.github.com/users/steelyvoid/orgs","repos_url":"https://api.github.com/users/steelyvoid/repos","events_url":"https://api.github.com/users/steelyvoid/events{/privacy}","received_events_url":"https://api.github.com/users/steelyvoid/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/pulls/337/commits","review_comments_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/pulls/337/comments","review_comment_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/issues/337/comments","statuses_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/statuses/d7edca916b4a9c38e2c256c96a1bdcf7d3f8113c","head":{"label":"Metaswitch:separate_socket_factories_by_namespace","ref":"separate_socket_factories_by_namespace","sha":"d7edca916b4a9c38e2c256c96a1bdcf7d3f8113c","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":9885334,"name":"clearwater-infrastructure","full_name":"Metaswitch/clearwater-infrastructure","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/clearwater-infrastructure","description":"Clearwater infrastructure Debian packages","fork":false,"url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure","forks_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/forks","keys_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/teams","hooks_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/events","assignees_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/tags","blobs_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/subscription","commits_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/merges","archive_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/downloads","issues_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/releases{/id}","deployments_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/deployments","created_at":"2013-05-06T11:25:13Z","updated_at":"2016-02-03T12:23:02Z","pushed_at":"2016-07-12T12:52:47Z","git_url":"git://github.com/Metaswitch/clearwater-infrastructure.git","ssh_url":"git@github.com:Metaswitch/clearwater-infrastructure.git","clone_url":"https://github.com/Metaswitch/clearwater-infrastructure.git","svn_url":"https://github.com/Metaswitch/clearwater-infrastructure","homepage":null,"size":827,"stargazers_count":8,"watchers_count":8,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":18,"forks":8,"open_issues":18,"watchers":8,"default_branch":"master"}},"base":{"label":"Metaswitch:master","ref":"master","sha":"9f74117538024250674fb125665f1caf272cc9de","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":9885334,"name":"clearwater-infrastructure","full_name":"Metaswitch/clearwater-infrastructure","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/clearwater-infrastructure","description":"Clearwater infrastructure Debian packages","fork":false,"url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure","forks_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/forks","keys_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/teams","hooks_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/events","assignees_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/tags","blobs_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/subscription","commits_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/merges","archive_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/downloads","issues_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/releases{/id}","deployments_url":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/deployments","created_at":"2013-05-06T11:25:13Z","updated_at":"2016-02-03T12:23:02Z","pushed_at":"2016-07-12T12:52:47Z","git_url":"git://github.com/Metaswitch/clearwater-infrastructure.git","ssh_url":"git@github.com:Metaswitch/clearwater-infrastructure.git","clone_url":"https://github.com/Metaswitch/clearwater-infrastructure.git","svn_url":"https://github.com/Metaswitch/clearwater-infrastructure","homepage":null,"size":827,"stargazers_count":8,"watchers_count":8,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":18,"forks":8,"open_issues":18,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/pulls/337"},"html":{"href":"https://github.com/Metaswitch/clearwater-infrastructure/pull/337"},"issue":{"href":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/issues/337"},"comments":{"href":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/issues/337/comments"},"review_comments":{"href":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/pulls/337/comments"},"review_comment":{"href":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/pulls/337/commits"},"statuses":{"href":"https://api.github.com/repos/Metaswitch/clearwater-infrastructure/statuses/d7edca916b4a9c38e2c256c96a1bdcf7d3f8113c"}}}}
{"actor":{"display_login":"steelyvoid"}}