{"action":"created","comment":{"url":"https://api.github.com/repos/CUBRID/cubrid/pulls/comments/76031311","id":76031311,"diff_hunk":"@@ -2847,9 +2847,9 @@ vacuum_process_vacuum_data (THREAD_ENTRY * thread_p)\n   vacuum_finalize (thread_p);\n \n   vacuum_Data.is_vacuum_complete = true;\n-\n-  PERF_UTIME_TRACKER_TIME (thread_p, &perf_tracker, mnt_vac_master_time);\n #endif /* SA_MODE */\n+\n+  PERF_UTIME_TRACKER_TIME (thread_p, &perf_tracker, PSTAT_VAC_MASTER);","path":"src/query/vacuum.c","position":130,"original_position":131,"commit_id":"c61531307e8e9139672d50993378673e79ae6c31","original_commit_id":"bfa127cc2a731fac8c9290f7817e6b380acf5f4d","user":{"login":"asturzu","id":17125570,"avatar_url":"https://avatars.githubusercontent.com/u/17125570?v=3","gravatar_id":"","url":"https://api.github.com/users/asturzu","html_url":"https://github.com/asturzu","followers_url":"https://api.github.com/users/asturzu/followers","following_url":"https://api.github.com/users/asturzu/following{/other_user}","gists_url":"https://api.github.com/users/asturzu/gists{/gist_id}","starred_url":"https://api.github.com/users/asturzu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asturzu/subscriptions","organizations_url":"https://api.github.com/users/asturzu/orgs","repos_url":"https://api.github.com/users/asturzu/repos","events_url":"https://api.github.com/users/asturzu/events{/privacy}","received_events_url":"https://api.github.com/users/asturzu/received_events","type":"User","site_admin":false},"body":"I consulted with Remzi and it should be applied to both cases. I removed a\nredundant call that was made\nin if (!lf_circular_queue_produce (vacuum_Job_queue, &vacuum_job_entry)).\n\n       Antonio\n\nOn Tue, Aug 23, 2016 at 10:17 AM, ESeok Oh <notifications@github.com> wrote:\n\n> In src/query/vacuum.c\n> <https://github.com/CUBRID/cubrid/pull/176#discussion_r75813092>:\n>\n> >  #endif /* SA_MODE */\n> > +\n> > +  PERF_UTIME_TRACKER_TIME (thread_p, &perf_tracker, PSTAT_VAC_MASTER);\n>\n> @asturzu <https://github.com/asturzu> @ribram <https://github.com/ribram>\n>\n> I'm not sure this should also be applied to SERVER_MODE. I think the\n> existing code is correct.\n> Would you confirm it again?\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/CUBRID/cubrid/pull/176/files/bfa127cc2a731fac8c9290f7817e6b380acf5f4d#r75813092>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AQVQwrqM1by3-cZjA0w8umulZKOTqFhmks5qip5wgaJpZM4JYBXn>\n> .\n>\n","created_at":"2016-08-24T10:21:04Z","updated_at":"2016-08-24T10:21:04Z","html_url":"https://github.com/CUBRID/cubrid/pull/176#discussion_r76031311","pull_request_url":"https://api.github.com/repos/CUBRID/cubrid/pulls/176","_links":{"self":{"href":"https://api.github.com/repos/CUBRID/cubrid/pulls/comments/76031311"},"html":{"href":"https://github.com/CUBRID/cubrid/pull/176#discussion_r76031311"},"pull_request":{"href":"https://api.github.com/repos/CUBRID/cubrid/pulls/176"}}},"pull_request":{"url":"https://api.github.com/repos/CUBRID/cubrid/pulls/176","id":79330723,"html_url":"https://github.com/CUBRID/cubrid/pull/176","diff_url":"https://github.com/CUBRID/cubrid/pull/176.diff","patch_url":"https://github.com/CUBRID/cubrid/pull/176.patch","issue_url":"https://api.github.com/repos/CUBRID/cubrid/issues/176","number":176,"state":"open","locked":false,"title":"[CBRD-20145] Performance statistics refactoring and improvement","user":{"login":"asturzu","id":17125570,"avatar_url":"https://avatars.githubusercontent.com/u/17125570?v=3","gravatar_id":"","url":"https://api.github.com/users/asturzu","html_url":"https://github.com/asturzu","followers_url":"https://api.github.com/users/asturzu/followers","following_url":"https://api.github.com/users/asturzu/following{/other_user}","gists_url":"https://api.github.com/users/asturzu/gists{/gist_id}","starred_url":"https://api.github.com/users/asturzu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asturzu/subscriptions","organizations_url":"https://api.github.com/users/asturzu/orgs","repos_url":"https://api.github.com/users/asturzu/repos","events_url":"https://api.github.com/users/asturzu/events{/privacy}","received_events_url":"https://api.github.com/users/asturzu/received_events","type":"User","site_admin":false},"body":"http://jira.cubrid.org/browse/CBRD-20145","created_at":"2016-07-29T09:24:43Z","updated_at":"2016-08-24T10:21:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2db46680893ec71a32bfcd073e63dd99036ac137","assignee":{"login":"ribram","id":12672652,"avatar_url":"https://avatars.githubusercontent.com/u/12672652?v=3","gravatar_id":"","url":"https://api.github.com/users/ribram","html_url":"https://github.com/ribram","followers_url":"https://api.github.com/users/ribram/followers","following_url":"https://api.github.com/users/ribram/following{/other_user}","gists_url":"https://api.github.com/users/ribram/gists{/gist_id}","starred_url":"https://api.github.com/users/ribram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ribram/subscriptions","organizations_url":"https://api.github.com/users/ribram/orgs","repos_url":"https://api.github.com/users/ribram/repos","events_url":"https://api.github.com/users/ribram/events{/privacy}","received_events_url":"https://api.github.com/users/ribram/received_events","type":"User","site_admin":false},"assignees":[{"login":"ribram","id":12672652,"avatar_url":"https://avatars.githubusercontent.com/u/12672652?v=3","gravatar_id":"","url":"https://api.github.com/users/ribram","html_url":"https://github.com/ribram","followers_url":"https://api.github.com/users/ribram/followers","following_url":"https://api.github.com/users/ribram/following{/other_user}","gists_url":"https://api.github.com/users/ribram/gists{/gist_id}","starred_url":"https://api.github.com/users/ribram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ribram/subscriptions","organizations_url":"https://api.github.com/users/ribram/orgs","repos_url":"https://api.github.com/users/ribram/repos","events_url":"https://api.github.com/users/ribram/events{/privacy}","received_events_url":"https://api.github.com/users/ribram/received_events","type":"User","site_admin":false},{"login":"eseokoh","id":17467172,"avatar_url":"https://avatars.githubusercontent.com/u/17467172?v=3","gravatar_id":"","url":"https://api.github.com/users/eseokoh","html_url":"https://github.com/eseokoh","followers_url":"https://api.github.com/users/eseokoh/followers","following_url":"https://api.github.com/users/eseokoh/following{/other_user}","gists_url":"https://api.github.com/users/eseokoh/gists{/gist_id}","starred_url":"https://api.github.com/users/eseokoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eseokoh/subscriptions","organizations_url":"https://api.github.com/users/eseokoh/orgs","repos_url":"https://api.github.com/users/eseokoh/repos","events_url":"https://api.github.com/users/eseokoh/events{/privacy}","received_events_url":"https://api.github.com/users/eseokoh/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CUBRID/cubrid/pulls/176/commits","review_comments_url":"https://api.github.com/repos/CUBRID/cubrid/pulls/176/comments","review_comment_url":"https://api.github.com/repos/CUBRID/cubrid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CUBRID/cubrid/issues/176/comments","statuses_url":"https://api.github.com/repos/CUBRID/cubrid/statuses/c61531307e8e9139672d50993378673e79ae6c31","head":{"label":"asturzu:myperfmon","ref":"myperfmon","sha":"c61531307e8e9139672d50993378673e79ae6c31","user":{"login":"asturzu","id":17125570,"avatar_url":"https://avatars.githubusercontent.com/u/17125570?v=3","gravatar_id":"","url":"https://api.github.com/users/asturzu","html_url":"https://github.com/asturzu","followers_url":"https://api.github.com/users/asturzu/followers","following_url":"https://api.github.com/users/asturzu/following{/other_user}","gists_url":"https://api.github.com/users/asturzu/gists{/gist_id}","starred_url":"https://api.github.com/users/asturzu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asturzu/subscriptions","organizations_url":"https://api.github.com/users/asturzu/orgs","repos_url":"https://api.github.com/users/asturzu/repos","events_url":"https://api.github.com/users/asturzu/events{/privacy}","received_events_url":"https://api.github.com/users/asturzu/received_events","type":"User","site_admin":false},"repo":{"id":54496546,"name":"cubrid","full_name":"asturzu/cubrid","owner":{"login":"asturzu","id":17125570,"avatar_url":"https://avatars.githubusercontent.com/u/17125570?v=3","gravatar_id":"","url":"https://api.github.com/users/asturzu","html_url":"https://github.com/asturzu","followers_url":"https://api.github.com/users/asturzu/followers","following_url":"https://api.github.com/users/asturzu/following{/other_user}","gists_url":"https://api.github.com/users/asturzu/gists{/gist_id}","starred_url":"https://api.github.com/users/asturzu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asturzu/subscriptions","organizations_url":"https://api.github.com/users/asturzu/orgs","repos_url":"https://api.github.com/users/asturzu/repos","events_url":"https://api.github.com/users/asturzu/events{/privacy}","received_events_url":"https://api.github.com/users/asturzu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asturzu/cubrid","description":"CUBRID is a comprehensive open source relational database management system highly optimized for Web Applications.","fork":true,"url":"https://api.github.com/repos/asturzu/cubrid","forks_url":"https://api.github.com/repos/asturzu/cubrid/forks","keys_url":"https://api.github.com/repos/asturzu/cubrid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asturzu/cubrid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asturzu/cubrid/teams","hooks_url":"https://api.github.com/repos/asturzu/cubrid/hooks","issue_events_url":"https://api.github.com/repos/asturzu/cubrid/issues/events{/number}","events_url":"https://api.github.com/repos/asturzu/cubrid/events","assignees_url":"https://api.github.com/repos/asturzu/cubrid/assignees{/user}","branches_url":"https://api.github.com/repos/asturzu/cubrid/branches{/branch}","tags_url":"https://api.github.com/repos/asturzu/cubrid/tags","blobs_url":"https://api.github.com/repos/asturzu/cubrid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asturzu/cubrid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asturzu/cubrid/git/refs{/sha}","trees_url":"https://api.github.com/repos/asturzu/cubrid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asturzu/cubrid/statuses/{sha}","languages_url":"https://api.github.com/repos/asturzu/cubrid/languages","stargazers_url":"https://api.github.com/repos/asturzu/cubrid/stargazers","contributors_url":"https://api.github.com/repos/asturzu/cubrid/contributors","subscribers_url":"https://api.github.com/repos/asturzu/cubrid/subscribers","subscription_url":"https://api.github.com/repos/asturzu/cubrid/subscription","commits_url":"https://api.github.com/repos/asturzu/cubrid/commits{/sha}","git_commits_url":"https://api.github.com/repos/asturzu/cubrid/git/commits{/sha}","comments_url":"https://api.github.com/repos/asturzu/cubrid/comments{/number}","issue_comment_url":"https://api.github.com/repos/asturzu/cubrid/issues/comments{/number}","contents_url":"https://api.github.com/repos/asturzu/cubrid/contents/{+path}","compare_url":"https://api.github.com/repos/asturzu/cubrid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asturzu/cubrid/merges","archive_url":"https://api.github.com/repos/asturzu/cubrid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asturzu/cubrid/downloads","issues_url":"https://api.github.com/repos/asturzu/cubrid/issues{/number}","pulls_url":"https://api.github.com/repos/asturzu/cubrid/pulls{/number}","milestones_url":"https://api.github.com/repos/asturzu/cubrid/milestones{/number}","notifications_url":"https://api.github.com/repos/asturzu/cubrid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asturzu/cubrid/labels{/name}","releases_url":"https://api.github.com/repos/asturzu/cubrid/releases{/id}","deployments_url":"https://api.github.com/repos/asturzu/cubrid/deployments","created_at":"2016-03-22T17:47:41Z","updated_at":"2016-03-28T12:23:47Z","pushed_at":"2016-08-24T10:14:48Z","git_url":"git://github.com/asturzu/cubrid.git","ssh_url":"git@github.com:asturzu/cubrid.git","clone_url":"https://github.com/asturzu/cubrid.git","svn_url":"https://github.com/asturzu/cubrid","homepage":"http://www.cubrid.org","size":166245,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"CUBRID:develop","ref":"develop","sha":"f31fe3893186ed946b392ad3ba9265309c1461d4","user":{"login":"CUBRID","id":358322,"avatar_url":"https://avatars.githubusercontent.com/u/358322?v=3","gravatar_id":"","url":"https://api.github.com/users/CUBRID","html_url":"https://github.com/CUBRID","followers_url":"https://api.github.com/users/CUBRID/followers","following_url":"https://api.github.com/users/CUBRID/following{/other_user}","gists_url":"https://api.github.com/users/CUBRID/gists{/gist_id}","starred_url":"https://api.github.com/users/CUBRID/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CUBRID/subscriptions","organizations_url":"https://api.github.com/users/CUBRID/orgs","repos_url":"https://api.github.com/users/CUBRID/repos","events_url":"https://api.github.com/users/CUBRID/events{/privacy}","received_events_url":"https://api.github.com/users/CUBRID/received_events","type":"Organization","site_admin":false},"repo":{"id":52080367,"name":"cubrid","full_name":"CUBRID/cubrid","owner":{"login":"CUBRID","id":358322,"avatar_url":"https://avatars.githubusercontent.com/u/358322?v=3","gravatar_id":"","url":"https://api.github.com/users/CUBRID","html_url":"https://github.com/CUBRID","followers_url":"https://api.github.com/users/CUBRID/followers","following_url":"https://api.github.com/users/CUBRID/following{/other_user}","gists_url":"https://api.github.com/users/CUBRID/gists{/gist_id}","starred_url":"https://api.github.com/users/CUBRID/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CUBRID/subscriptions","organizations_url":"https://api.github.com/users/CUBRID/orgs","repos_url":"https://api.github.com/users/CUBRID/repos","events_url":"https://api.github.com/users/CUBRID/events{/privacy}","received_events_url":"https://api.github.com/users/CUBRID/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CUBRID/cubrid","description":"CUBRID is a comprehensive open source relational database management system highly optimized for Web Applications.","fork":false,"url":"https://api.github.com/repos/CUBRID/cubrid","forks_url":"https://api.github.com/repos/CUBRID/cubrid/forks","keys_url":"https://api.github.com/repos/CUBRID/cubrid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CUBRID/cubrid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CUBRID/cubrid/teams","hooks_url":"https://api.github.com/repos/CUBRID/cubrid/hooks","issue_events_url":"https://api.github.com/repos/CUBRID/cubrid/issues/events{/number}","events_url":"https://api.github.com/repos/CUBRID/cubrid/events","assignees_url":"https://api.github.com/repos/CUBRID/cubrid/assignees{/user}","branches_url":"https://api.github.com/repos/CUBRID/cubrid/branches{/branch}","tags_url":"https://api.github.com/repos/CUBRID/cubrid/tags","blobs_url":"https://api.github.com/repos/CUBRID/cubrid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CUBRID/cubrid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CUBRID/cubrid/git/refs{/sha}","trees_url":"https://api.github.com/repos/CUBRID/cubrid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CUBRID/cubrid/statuses/{sha}","languages_url":"https://api.github.com/repos/CUBRID/cubrid/languages","stargazers_url":"https://api.github.com/repos/CUBRID/cubrid/stargazers","contributors_url":"https://api.github.com/repos/CUBRID/cubrid/contributors","subscribers_url":"https://api.github.com/repos/CUBRID/cubrid/subscribers","subscription_url":"https://api.github.com/repos/CUBRID/cubrid/subscription","commits_url":"https://api.github.com/repos/CUBRID/cubrid/commits{/sha}","git_commits_url":"https://api.github.com/repos/CUBRID/cubrid/git/commits{/sha}","comments_url":"https://api.github.com/repos/CUBRID/cubrid/comments{/number}","issue_comment_url":"https://api.github.com/repos/CUBRID/cubrid/issues/comments{/number}","contents_url":"https://api.github.com/repos/CUBRID/cubrid/contents/{+path}","compare_url":"https://api.github.com/repos/CUBRID/cubrid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CUBRID/cubrid/merges","archive_url":"https://api.github.com/repos/CUBRID/cubrid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CUBRID/cubrid/downloads","issues_url":"https://api.github.com/repos/CUBRID/cubrid/issues{/number}","pulls_url":"https://api.github.com/repos/CUBRID/cubrid/pulls{/number}","milestones_url":"https://api.github.com/repos/CUBRID/cubrid/milestones{/number}","notifications_url":"https://api.github.com/repos/CUBRID/cubrid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CUBRID/cubrid/labels{/name}","releases_url":"https://api.github.com/repos/CUBRID/cubrid/releases{/id}","deployments_url":"https://api.github.com/repos/CUBRID/cubrid/deployments","created_at":"2016-02-19T10:25:32Z","updated_at":"2016-08-12T08:10:33Z","pushed_at":"2016-08-24T10:14:48Z","git_url":"git://github.com/CUBRID/cubrid.git","ssh_url":"git@github.com:CUBRID/cubrid.git","clone_url":"https://github.com/CUBRID/cubrid.git","svn_url":"https://github.com/CUBRID/cubrid","homepage":"http://www.cubrid.org","size":171063,"stargazers_count":17,"watchers_count":17,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":6,"forks":25,"open_issues":6,"watchers":17,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CUBRID/cubrid/pulls/176"},"html":{"href":"https://github.com/CUBRID/cubrid/pull/176"},"issue":{"href":"https://api.github.com/repos/CUBRID/cubrid/issues/176"},"comments":{"href":"https://api.github.com/repos/CUBRID/cubrid/issues/176/comments"},"review_comments":{"href":"https://api.github.com/repos/CUBRID/cubrid/pulls/176/comments"},"review_comment":{"href":"https://api.github.com/repos/CUBRID/cubrid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CUBRID/cubrid/pulls/176/commits"},"statuses":{"href":"https://api.github.com/repos/CUBRID/cubrid/statuses/c61531307e8e9139672d50993378673e79ae6c31"}}}}
{"actor":{"display_login":"asturzu"}}