{"action":"created","comment":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/comments/59148926","id":59148926,"diff_hunk":"@@ -180,7 +180,6 @@ void onewire_write(uint8_t pin, uint8_t v, uint8_t power /* = 0 */) {\n   if ( !power) {","path":"app/driver/onewire.c","position":1,"original_position":1,"commit_id":"48f193eb7958b35af99aa45aa4c6af2f4b3cc9c6","original_commit_id":"6fba242ddba3916685b472da1d2d19848440b5d0","user":{"login":"wuyuanyi135","id":11760870,"avatar_url":"https://avatars.githubusercontent.com/u/11760870?v=3","gravatar_id":"","url":"https://api.github.com/users/wuyuanyi135","html_url":"https://github.com/wuyuanyi135","followers_url":"https://api.github.com/users/wuyuanyi135/followers","following_url":"https://api.github.com/users/wuyuanyi135/following{/other_user}","gists_url":"https://api.github.com/users/wuyuanyi135/gists{/gist_id}","starred_url":"https://api.github.com/users/wuyuanyi135/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wuyuanyi135/subscriptions","organizations_url":"https://api.github.com/users/wuyuanyi135/orgs","repos_url":"https://api.github.com/users/wuyuanyi135/repos","events_url":"https://api.github.com/users/wuyuanyi135/events{/privacy}","received_events_url":"https://api.github.com/users/wuyuanyi135/received_events","type":"User","site_admin":false},"body":"Where can I read the sdk source like gpio_output_set? I am not sure whether the interruption is masked in some funcs","created_at":"2016-04-11T02:34:09Z","updated_at":"2016-04-11T02:34:09Z","html_url":"https://github.com/nodemcu/nodemcu-firmware/pull/1143#discussion_r59148926","pull_request_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/1143","_links":{"self":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/comments/59148926"},"html":{"href":"https://github.com/nodemcu/nodemcu-firmware/pull/1143#discussion_r59148926"},"pull_request":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/1143"}}},"pull_request":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/1143","id":62329937,"html_url":"https://github.com/nodemcu/nodemcu-firmware/pull/1143","diff_url":"https://github.com/nodemcu/nodemcu-firmware/pull/1143.diff","patch_url":"https://github.com/nodemcu/nodemcu-firmware/pull/1143.patch","issue_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/1143","number":1143,"state":"open","locked":false,"title":"onewire: fix unexpected low level after writing","user":{"login":"wuyuanyi135","id":11760870,"avatar_url":"https://avatars.githubusercontent.com/u/11760870?v=3","gravatar_id":"","url":"https://api.github.com/users/wuyuanyi135","html_url":"https://github.com/wuyuanyi135","followers_url":"https://api.github.com/users/wuyuanyi135/followers","following_url":"https://api.github.com/users/wuyuanyi135/following{/other_user}","gists_url":"https://api.github.com/users/wuyuanyi135/gists{/gist_id}","starred_url":"https://api.github.com/users/wuyuanyi135/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wuyuanyi135/subscriptions","organizations_url":"https://api.github.com/users/wuyuanyi135/orgs","repos_url":"https://api.github.com/users/wuyuanyi135/repos","events_url":"https://api.github.com/users/wuyuanyi135/events{/privacy}","received_events_url":"https://api.github.com/users/wuyuanyi135/received_events","type":"User","site_admin":false},"body":"first commit to fix issue #1130\r\n\r\nIf power = 0, after writing the bus is pulled down, and the slave will take it for a bit. One may have problem like the onewire device returning strange response, (for me, ds18b20 sometimes give temperature 4095.8125 degc). This commit will fix the unexpected situation. \r\n\r\nThe power argument is not removed. We believe some use this module without external pull up as the documentation specified. The direct push-pull should be able to drive the slave. In that case, we may not switch the pin to input mode for the push arm supplying the power.","created_at":"2016-03-10T02:22:40Z","updated_at":"2016-04-11T02:34:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67dd01f269d16b534ceeceba2538978dafb136dd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/1143/commits","review_comments_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/1143/comments","review_comment_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/1143/comments","statuses_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/statuses/48f193eb7958b35af99aa45aa4c6af2f4b3cc9c6","head":{"label":"wuyuanyi135:dev","ref":"dev","sha":"48f193eb7958b35af99aa45aa4c6af2f4b3cc9c6","user":{"login":"wuyuanyi135","id":11760870,"avatar_url":"https://avatars.githubusercontent.com/u/11760870?v=3","gravatar_id":"","url":"https://api.github.com/users/wuyuanyi135","html_url":"https://github.com/wuyuanyi135","followers_url":"https://api.github.com/users/wuyuanyi135/followers","following_url":"https://api.github.com/users/wuyuanyi135/following{/other_user}","gists_url":"https://api.github.com/users/wuyuanyi135/gists{/gist_id}","starred_url":"https://api.github.com/users/wuyuanyi135/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wuyuanyi135/subscriptions","organizations_url":"https://api.github.com/users/wuyuanyi135/orgs","repos_url":"https://api.github.com/users/wuyuanyi135/repos","events_url":"https://api.github.com/users/wuyuanyi135/events{/privacy}","received_events_url":"https://api.github.com/users/wuyuanyi135/received_events","type":"User","site_admin":false},"repo":{"id":53547295,"name":"nodemcu-firmware","full_name":"wuyuanyi135/nodemcu-firmware","owner":{"login":"wuyuanyi135","id":11760870,"avatar_url":"https://avatars.githubusercontent.com/u/11760870?v=3","gravatar_id":"","url":"https://api.github.com/users/wuyuanyi135","html_url":"https://github.com/wuyuanyi135","followers_url":"https://api.github.com/users/wuyuanyi135/followers","following_url":"https://api.github.com/users/wuyuanyi135/following{/other_user}","gists_url":"https://api.github.com/users/wuyuanyi135/gists{/gist_id}","starred_url":"https://api.github.com/users/wuyuanyi135/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wuyuanyi135/subscriptions","organizations_url":"https://api.github.com/users/wuyuanyi135/orgs","repos_url":"https://api.github.com/users/wuyuanyi135/repos","events_url":"https://api.github.com/users/wuyuanyi135/events{/privacy}","received_events_url":"https://api.github.com/users/wuyuanyi135/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wuyuanyi135/nodemcu-firmware","description":"lua based interactive firmware for mcu like esp8266","fork":true,"url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware","forks_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/forks","keys_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/teams","hooks_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/hooks","issue_events_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/events","assignees_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/tags","blobs_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/languages","stargazers_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/stargazers","contributors_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/contributors","subscribers_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/subscribers","subscription_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/subscription","commits_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/merges","archive_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/downloads","issues_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/labels{/name}","releases_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/wuyuanyi135/nodemcu-firmware/deployments","created_at":"2016-03-10T02:09:28Z","updated_at":"2016-03-10T02:09:31Z","pushed_at":"2016-04-10T04:28:19Z","git_url":"git://github.com/wuyuanyi135/nodemcu-firmware.git","ssh_url":"git@github.com:wuyuanyi135/nodemcu-firmware.git","clone_url":"https://github.com/wuyuanyi135/nodemcu-firmware.git","svn_url":"https://github.com/wuyuanyi135/nodemcu-firmware","homepage":"http://nodemcu.com","size":87773,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodemcu:dev","ref":"dev","sha":"7d576efed94092916e1a84bccba6319d62b9dedf","user":{"login":"nodemcu","id":9865736,"avatar_url":"https://avatars.githubusercontent.com/u/9865736?v=3","gravatar_id":"","url":"https://api.github.com/users/nodemcu","html_url":"https://github.com/nodemcu","followers_url":"https://api.github.com/users/nodemcu/followers","following_url":"https://api.github.com/users/nodemcu/following{/other_user}","gists_url":"https://api.github.com/users/nodemcu/gists{/gist_id}","starred_url":"https://api.github.com/users/nodemcu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodemcu/subscriptions","organizations_url":"https://api.github.com/users/nodemcu/orgs","repos_url":"https://api.github.com/users/nodemcu/repos","events_url":"https://api.github.com/users/nodemcu/events{/privacy}","received_events_url":"https://api.github.com/users/nodemcu/received_events","type":"User","site_admin":false},"repo":{"id":26917568,"name":"nodemcu-firmware","full_name":"nodemcu/nodemcu-firmware","owner":{"login":"nodemcu","id":9865736,"avatar_url":"https://avatars.githubusercontent.com/u/9865736?v=3","gravatar_id":"","url":"https://api.github.com/users/nodemcu","html_url":"https://github.com/nodemcu","followers_url":"https://api.github.com/users/nodemcu/followers","following_url":"https://api.github.com/users/nodemcu/following{/other_user}","gists_url":"https://api.github.com/users/nodemcu/gists{/gist_id}","starred_url":"https://api.github.com/users/nodemcu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodemcu/subscriptions","organizations_url":"https://api.github.com/users/nodemcu/orgs","repos_url":"https://api.github.com/users/nodemcu/repos","events_url":"https://api.github.com/users/nodemcu/events{/privacy}","received_events_url":"https://api.github.com/users/nodemcu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nodemcu/nodemcu-firmware","description":"lua based interactive firmware for mcu like esp8266","fork":false,"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware","forks_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/forks","keys_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/teams","hooks_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/hooks","issue_events_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/events","assignees_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/tags","blobs_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/languages","stargazers_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/stargazers","contributors_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/contributors","subscribers_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/subscribers","subscription_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/subscription","commits_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/merges","archive_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/downloads","issues_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/labels{/name}","releases_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/deployments","created_at":"2014-11-20T15:06:45Z","updated_at":"2016-04-10T21:25:43Z","pushed_at":"2016-04-10T19:43:10Z","git_url":"git://github.com/nodemcu/nodemcu-firmware.git","ssh_url":"git@github.com:nodemcu/nodemcu-firmware.git","clone_url":"https://github.com/nodemcu/nodemcu-firmware.git","svn_url":"https://github.com/nodemcu/nodemcu-firmware","homepage":"http://nodemcu.com","size":104376,"stargazers_count":2084,"watchers_count":2084,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":950,"mirror_url":null,"open_issues_count":106,"forks":950,"open_issues":106,"watchers":2084,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/1143"},"html":{"href":"https://github.com/nodemcu/nodemcu-firmware/pull/1143"},"issue":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/1143"},"comments":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/1143/comments"},"review_comments":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/1143/comments"},"review_comment":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/1143/commits"},"statuses":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/statuses/48f193eb7958b35af99aa45aa4c6af2f4b3cc9c6"}}}}