{"action":"created","issue":{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/1420","repository_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed","labels_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/1420/labels{/name}","comments_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/1420/comments","events_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/1420/events","html_url":"https://github.com/WikiWatershed/model-my-watershed/pull/1420","id":171198187,"number":1420,"title":"Adjust `NormalSys` values in pre-processor","user":{"login":"kellyi","id":4165523,"avatar_url":"https://avatars.githubusercontent.com/u/4165523?v=3","gravatar_id":"","url":"https://api.github.com/users/kellyi","html_url":"https://github.com/kellyi","followers_url":"https://api.github.com/users/kellyi/followers","following_url":"https://api.github.com/users/kellyi/following{/other_user}","gists_url":"https://api.github.com/users/kellyi/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyi/subscriptions","organizations_url":"https://api.github.com/users/kellyi/orgs","repos_url":"https://api.github.com/users/kellyi/repos","events_url":"https://api.github.com/users/kellyi/events{/privacy}","received_events_url":"https://api.github.com/users/kellyi/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"rajadain","id":1430060,"avatar_url":"https://avatars.githubusercontent.com/u/1430060?v=3","gravatar_id":"","url":"https://api.github.com/users/rajadain","html_url":"https://github.com/rajadain","followers_url":"https://api.github.com/users/rajadain/followers","following_url":"https://api.github.com/users/rajadain/following{/other_user}","gists_url":"https://api.github.com/users/rajadain/gists{/gist_id}","starred_url":"https://api.github.com/users/rajadain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajadain/subscriptions","organizations_url":"https://api.github.com/users/rajadain/orgs","repos_url":"https://api.github.com/users/rajadain/repos","events_url":"https://api.github.com/users/rajadain/events{/privacy}","received_events_url":"https://api.github.com/users/rajadain/received_events","type":"User","site_admin":false},"assignees":[{"login":"rajadain","id":1430060,"avatar_url":"https://avatars.githubusercontent.com/u/1430060?v=3","gravatar_id":"","url":"https://api.github.com/users/rajadain","html_url":"https://github.com/rajadain","followers_url":"https://api.github.com/users/rajadain/followers","following_url":"https://api.github.com/users/rajadain/following{/other_user}","gists_url":"https://api.github.com/users/rajadain/gists{/gist_id}","starred_url":"https://api.github.com/users/rajadain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajadain/subscriptions","organizations_url":"https://api.github.com/users/rajadain/orgs","repos_url":"https://api.github.com/users/rajadain/repos","events_url":"https://api.github.com/users/rajadain/events{/privacy}","received_events_url":"https://api.github.com/users/rajadain/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2016-08-15T15:48:14Z","updated_at":"2016-08-15T21:31:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/1420","html_url":"https://github.com/WikiWatershed/model-my-watershed/pull/1420","diff_url":"https://github.com/WikiWatershed/model-my-watershed/pull/1420.diff","patch_url":"https://github.com/WikiWatershed/model-my-watershed/pull/1420.patch"},"body":"This PR updates some of the code by which MMW creates its MapShed dictionary for GWLF-E by changing the names of `NormalSys` values to match GWLF-E's expected key -- `NumNormalSys`. It also changes the value of that key to an array of 12 ints, which is what GWLF-E expects to receive for calculating the \"Total Nitrogen\" value for Septic Systems.\r\n\r\n![screen shot 2016-08-15 at 11 40 37 am](https://cloud.githubusercontent.com/assets/4165523/17669816/28aa736e-62dd-11e6-8486-47aa8b9096d9.png)\r\n\r\nThe result so far only addresses the Total Nitrogen value: \"Sediment\" and \"Total Phosphorus\" remain 0 because we are using hard-coded 0 values for each.\r\n\r\nThe GWLF-E code returns a 0 for Septic/Sediment here: \r\nhttps://github.com/WikiWatershed/gwlf-e/blob/develop/gwlfe/WriteOutputFiles.py#L887\r\n\r\nMMW hard codes the values necessary to generate \"Total Phosphorus\" to an array of 12 zeroes here:\r\nhttps://github.com/WikiWatershed/model-my-watershed/blob/develop/src/mmw/mmw/settings/gwlfe_settings.py#L99\r\n\r\n**Testing**\r\n- grab this branch, `vagrant up`, `./scripts/bundle.sh` then visit `localhost:8000`\r\n- select an area of interest to analyze, then run the MapShed model\r\n- when modeling's done, select the \"Water Quality\" tab and scroll down to verify that there's a value for \"Total Nitrogen\"\r\n- create a new scenario, then export a gms file\r\n- from the command line run `cat <your-gms-file>.gms | sed '85,97!d'` and verify that position 1 at each of the lines after the first has a value\r\n\r\nConnects #1370 "},"comment":{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/comments/239935624","html_url":"https://github.com/WikiWatershed/model-my-watershed/pull/1420#issuecomment-239935624","issue_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/1420","id":239935624,"user":{"login":"kellyi","id":4165523,"avatar_url":"https://avatars.githubusercontent.com/u/4165523?v=3","gravatar_id":"","url":"https://api.github.com/users/kellyi","html_url":"https://github.com/kellyi","followers_url":"https://api.github.com/users/kellyi/followers","following_url":"https://api.github.com/users/kellyi/following{/other_user}","gists_url":"https://api.github.com/users/kellyi/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyi/subscriptions","organizations_url":"https://api.github.com/users/kellyi/orgs","repos_url":"https://api.github.com/users/kellyi/repos","events_url":"https://api.github.com/users/kellyi/events{/privacy}","received_events_url":"https://api.github.com/users/kellyi/received_events","type":"User","site_admin":false},"created_at":"2016-08-15T21:31:37Z","updated_at":"2016-08-15T21:31:37Z","body":"Oh! I was testing it out and trying to see if I was accidentally rounding down. However, that made me think that I should probably round the float up or down rather than just rounding it down to an int."}}
{"actor":{"display_login":"kellyi"}}