{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoinjs/bip39/issues/37","repository_url":"https://api.github.com/repos/bitcoinjs/bip39","labels_url":"https://api.github.com/repos/bitcoinjs/bip39/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/bitcoinjs/bip39/issues/37/comments","events_url":"https://api.github.com/repos/bitcoinjs/bip39/issues/37/events","html_url":"https://github.com/bitcoinjs/bip39/pull/37","id":181180978,"number":37,"title":"Sanity checks for entropy size","user":{"login":"rubensayshi","id":649160,"avatar_url":"https://avatars.githubusercontent.com/u/649160?v=3","gravatar_id":"","url":"https://api.github.com/users/rubensayshi","html_url":"https://github.com/rubensayshi","followers_url":"https://api.github.com/users/rubensayshi/followers","following_url":"https://api.github.com/users/rubensayshi/following{/other_user}","gists_url":"https://api.github.com/users/rubensayshi/gists{/gist_id}","starred_url":"https://api.github.com/users/rubensayshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubensayshi/subscriptions","organizations_url":"https://api.github.com/users/rubensayshi/orgs","repos_url":"https://api.github.com/users/rubensayshi/repos","events_url":"https://api.github.com/users/rubensayshi/events{/privacy}","received_events_url":"https://api.github.com/users/rubensayshi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-05T15:03:47Z","updated_at":"2016-10-05T15:08:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoinjs/bip39/pulls/37","html_url":"https://github.com/bitcoinjs/bip39/pull/37","diff_url":"https://github.com/bitcoinjs/bip39/pull/37.diff","patch_url":"https://github.com/bitcoinjs/bip39/pull/37.patch"},"body":"In https://github.com/bitcoinjs/bip39/pull/33 I tried coming up with a solution to deal witih odd sizes of entropy and the resulting checksum hell.\r\n\r\nInstead the only sane solution seems to be to do better sanity checks in the entropy;\r\n 1. It should always be a multitude of 4 bytes, that way it will always result in a multitude of 11 bits (including checksum) and no weird padding things will happen with the checksum.\r\n 2. It should not allow entropy above 1024 bytes, because at that point we've reached the max length of the checksum (sha256) and if we continue (without padding the checksum) the above rule won't hold\r\n\r\nThe only alternative for the max 1024 bytes would be to pad the checksum to keep the first rule in tact, but since the BIP39 spec doesn't mention anything like that it doesn't seem like a good choice."},"comment":{"url":"https://api.github.com/repos/bitcoinjs/bip39/issues/comments/251703112","html_url":"https://github.com/bitcoinjs/bip39/pull/37#issuecomment-251703112","issue_url":"https://api.github.com/repos/bitcoinjs/bip39/issues/37","id":251703112,"user":{"login":"rubensayshi","id":649160,"avatar_url":"https://avatars.githubusercontent.com/u/649160?v=3","gravatar_id":"","url":"https://api.github.com/users/rubensayshi","html_url":"https://github.com/rubensayshi","followers_url":"https://api.github.com/users/rubensayshi/followers","following_url":"https://api.github.com/users/rubensayshi/following{/other_user}","gists_url":"https://api.github.com/users/rubensayshi/gists{/gist_id}","starred_url":"https://api.github.com/users/rubensayshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubensayshi/subscriptions","organizations_url":"https://api.github.com/users/rubensayshi/orgs","repos_url":"https://api.github.com/users/rubensayshi/repos","events_url":"https://api.github.com/users/rubensayshi/events{/privacy}","received_events_url":"https://api.github.com/users/rubensayshi/received_events","type":"User","site_admin":false},"created_at":"2016-10-05T15:08:31Z","updated_at":"2016-10-05T15:08:31Z","body":"@dcousens I think the other PR should be reverted, are you gonna commit revert it or rollback history?\r\n\r\nI can rebase after"}}
{"actor":{"display_login":"rubensayshi"}}