{"action":"opened","number":68,"pull_request":{"url":"https://api.github.com/repos/btcsuite/btcutil/pulls/68","id":60786392,"html_url":"https://github.com/btcsuite/btcutil/pull/68","diff_url":"https://github.com/btcsuite/btcutil/pull/68.diff","patch_url":"https://github.com/btcsuite/btcutil/pull/68.patch","issue_url":"https://api.github.com/repos/btcsuite/btcutil/issues/68","number":68,"state":"open","locked":false,"title":"Fix range check in bloom filter false positive rate","user":{"login":"T909","id":3424974,"avatar_url":"https://avatars.githubusercontent.com/u/3424974?v=3","gravatar_id":"","url":"https://api.github.com/users/T909","html_url":"https://github.com/T909","followers_url":"https://api.github.com/users/T909/followers","following_url":"https://api.github.com/users/T909/following{/other_user}","gists_url":"https://api.github.com/users/T909/gists{/gist_id}","starred_url":"https://api.github.com/users/T909/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/T909/subscriptions","organizations_url":"https://api.github.com/users/T909/orgs","repos_url":"https://api.github.com/users/T909/repos","events_url":"https://api.github.com/users/T909/events{/privacy}","received_events_url":"https://api.github.com/users/T909/received_events","type":"User","site_admin":false},"body":"Tiny fix here.  If you gave an argument of 0 for the false positive rate in NewFilter(), it would make a 0-length filter, always matching.  That's really a false positive rate of 1 which seems like the opposite effect.  Interpreting a 0 as the lower limit of 1e-9 seems more intuitive behavior when receiving an out-of-bounds argument.","created_at":"2016-02-26T03:13:33Z","updated_at":"2016-02-26T03:13:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f45e13c60868f3dfaf34e3899567ccaef78f5b5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/btcsuite/btcutil/pulls/68/commits","review_comments_url":"https://api.github.com/repos/btcsuite/btcutil/pulls/68/comments","review_comment_url":"https://api.github.com/repos/btcsuite/btcutil/pulls/comments{/number}","comments_url":"https://api.github.com/repos/btcsuite/btcutil/issues/68/comments","statuses_url":"https://api.github.com/repos/btcsuite/btcutil/statuses/e0f1e8766ceffbc85a733b736244903348e5f01e","head":{"label":"T909:bloom","ref":"bloom","sha":"e0f1e8766ceffbc85a733b736244903348e5f01e","user":{"login":"T909","id":3424974,"avatar_url":"https://avatars.githubusercontent.com/u/3424974?v=3","gravatar_id":"","url":"https://api.github.com/users/T909","html_url":"https://github.com/T909","followers_url":"https://api.github.com/users/T909/followers","following_url":"https://api.github.com/users/T909/following{/other_user}","gists_url":"https://api.github.com/users/T909/gists{/gist_id}","starred_url":"https://api.github.com/users/T909/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/T909/subscriptions","organizations_url":"https://api.github.com/users/T909/orgs","repos_url":"https://api.github.com/users/T909/repos","events_url":"https://api.github.com/users/T909/events{/privacy}","received_events_url":"https://api.github.com/users/T909/received_events","type":"User","site_admin":false},"repo":{"id":44772167,"name":"btcutil","full_name":"T909/btcutil","owner":{"login":"T909","id":3424974,"avatar_url":"https://avatars.githubusercontent.com/u/3424974?v=3","gravatar_id":"","url":"https://api.github.com/users/T909","html_url":"https://github.com/T909","followers_url":"https://api.github.com/users/T909/followers","following_url":"https://api.github.com/users/T909/following{/other_user}","gists_url":"https://api.github.com/users/T909/gists{/gist_id}","starred_url":"https://api.github.com/users/T909/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/T909/subscriptions","organizations_url":"https://api.github.com/users/T909/orgs","repos_url":"https://api.github.com/users/T909/repos","events_url":"https://api.github.com/users/T909/events{/privacy}","received_events_url":"https://api.github.com/users/T909/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/T909/btcutil","description":"Provides bitcoin-specific convenience functions and types","fork":true,"url":"https://api.github.com/repos/T909/btcutil","forks_url":"https://api.github.com/repos/T909/btcutil/forks","keys_url":"https://api.github.com/repos/T909/btcutil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/T909/btcutil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/T909/btcutil/teams","hooks_url":"https://api.github.com/repos/T909/btcutil/hooks","issue_events_url":"https://api.github.com/repos/T909/btcutil/issues/events{/number}","events_url":"https://api.github.com/repos/T909/btcutil/events","assignees_url":"https://api.github.com/repos/T909/btcutil/assignees{/user}","branches_url":"https://api.github.com/repos/T909/btcutil/branches{/branch}","tags_url":"https://api.github.com/repos/T909/btcutil/tags","blobs_url":"https://api.github.com/repos/T909/btcutil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/T909/btcutil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/T909/btcutil/git/refs{/sha}","trees_url":"https://api.github.com/repos/T909/btcutil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/T909/btcutil/statuses/{sha}","languages_url":"https://api.github.com/repos/T909/btcutil/languages","stargazers_url":"https://api.github.com/repos/T909/btcutil/stargazers","contributors_url":"https://api.github.com/repos/T909/btcutil/contributors","subscribers_url":"https://api.github.com/repos/T909/btcutil/subscribers","subscription_url":"https://api.github.com/repos/T909/btcutil/subscription","commits_url":"https://api.github.com/repos/T909/btcutil/commits{/sha}","git_commits_url":"https://api.github.com/repos/T909/btcutil/git/commits{/sha}","comments_url":"https://api.github.com/repos/T909/btcutil/comments{/number}","issue_comment_url":"https://api.github.com/repos/T909/btcutil/issues/comments{/number}","contents_url":"https://api.github.com/repos/T909/btcutil/contents/{+path}","compare_url":"https://api.github.com/repos/T909/btcutil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/T909/btcutil/merges","archive_url":"https://api.github.com/repos/T909/btcutil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/T909/btcutil/downloads","issues_url":"https://api.github.com/repos/T909/btcutil/issues{/number}","pulls_url":"https://api.github.com/repos/T909/btcutil/pulls{/number}","milestones_url":"https://api.github.com/repos/T909/btcutil/milestones{/number}","notifications_url":"https://api.github.com/repos/T909/btcutil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/T909/btcutil/labels{/name}","releases_url":"https://api.github.com/repos/T909/btcutil/releases{/id}","deployments_url":"https://api.github.com/repos/T909/btcutil/deployments","created_at":"2015-10-22T20:43:04Z","updated_at":"2016-02-26T03:06:45Z","pushed_at":"2016-02-26T03:10:10Z","git_url":"git://github.com/T909/btcutil.git","ssh_url":"git@github.com:T909/btcutil.git","clone_url":"https://github.com/T909/btcutil.git","svn_url":"https://github.com/T909/btcutil","homepage":"","size":342,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"btcsuite:master","ref":"master","sha":"2d190f72ff5e227db5d76d33e86c30ac7e8c15a9","user":{"login":"btcsuite","id":10235229,"avatar_url":"https://avatars.githubusercontent.com/u/10235229?v=3","gravatar_id":"","url":"https://api.github.com/users/btcsuite","html_url":"https://github.com/btcsuite","followers_url":"https://api.github.com/users/btcsuite/followers","following_url":"https://api.github.com/users/btcsuite/following{/other_user}","gists_url":"https://api.github.com/users/btcsuite/gists{/gist_id}","starred_url":"https://api.github.com/users/btcsuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btcsuite/subscriptions","organizations_url":"https://api.github.com/users/btcsuite/orgs","repos_url":"https://api.github.com/users/btcsuite/repos","events_url":"https://api.github.com/users/btcsuite/events{/privacy}","received_events_url":"https://api.github.com/users/btcsuite/received_events","type":"Organization","site_admin":false},"repo":{"id":10347785,"name":"btcutil","full_name":"btcsuite/btcutil","owner":{"login":"btcsuite","id":10235229,"avatar_url":"https://avatars.githubusercontent.com/u/10235229?v=3","gravatar_id":"","url":"https://api.github.com/users/btcsuite","html_url":"https://github.com/btcsuite","followers_url":"https://api.github.com/users/btcsuite/followers","following_url":"https://api.github.com/users/btcsuite/following{/other_user}","gists_url":"https://api.github.com/users/btcsuite/gists{/gist_id}","starred_url":"https://api.github.com/users/btcsuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btcsuite/subscriptions","organizations_url":"https://api.github.com/users/btcsuite/orgs","repos_url":"https://api.github.com/users/btcsuite/repos","events_url":"https://api.github.com/users/btcsuite/events{/privacy}","received_events_url":"https://api.github.com/users/btcsuite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/btcsuite/btcutil","description":"Provides bitcoin-specific convenience functions and types","fork":false,"url":"https://api.github.com/repos/btcsuite/btcutil","forks_url":"https://api.github.com/repos/btcsuite/btcutil/forks","keys_url":"https://api.github.com/repos/btcsuite/btcutil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/btcsuite/btcutil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/btcsuite/btcutil/teams","hooks_url":"https://api.github.com/repos/btcsuite/btcutil/hooks","issue_events_url":"https://api.github.com/repos/btcsuite/btcutil/issues/events{/number}","events_url":"https://api.github.com/repos/btcsuite/btcutil/events","assignees_url":"https://api.github.com/repos/btcsuite/btcutil/assignees{/user}","branches_url":"https://api.github.com/repos/btcsuite/btcutil/branches{/branch}","tags_url":"https://api.github.com/repos/btcsuite/btcutil/tags","blobs_url":"https://api.github.com/repos/btcsuite/btcutil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/btcsuite/btcutil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/btcsuite/btcutil/git/refs{/sha}","trees_url":"https://api.github.com/repos/btcsuite/btcutil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/btcsuite/btcutil/statuses/{sha}","languages_url":"https://api.github.com/repos/btcsuite/btcutil/languages","stargazers_url":"https://api.github.com/repos/btcsuite/btcutil/stargazers","contributors_url":"https://api.github.com/repos/btcsuite/btcutil/contributors","subscribers_url":"https://api.github.com/repos/btcsuite/btcutil/subscribers","subscription_url":"https://api.github.com/repos/btcsuite/btcutil/subscription","commits_url":"https://api.github.com/repos/btcsuite/btcutil/commits{/sha}","git_commits_url":"https://api.github.com/repos/btcsuite/btcutil/git/commits{/sha}","comments_url":"https://api.github.com/repos/btcsuite/btcutil/comments{/number}","issue_comment_url":"https://api.github.com/repos/btcsuite/btcutil/issues/comments{/number}","contents_url":"https://api.github.com/repos/btcsuite/btcutil/contents/{+path}","compare_url":"https://api.github.com/repos/btcsuite/btcutil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/btcsuite/btcutil/merges","archive_url":"https://api.github.com/repos/btcsuite/btcutil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/btcsuite/btcutil/downloads","issues_url":"https://api.github.com/repos/btcsuite/btcutil/issues{/number}","pulls_url":"https://api.github.com/repos/btcsuite/btcutil/pulls{/number}","milestones_url":"https://api.github.com/repos/btcsuite/btcutil/milestones{/number}","notifications_url":"https://api.github.com/repos/btcsuite/btcutil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/btcsuite/btcutil/labels{/name}","releases_url":"https://api.github.com/repos/btcsuite/btcutil/releases{/id}","deployments_url":"https://api.github.com/repos/btcsuite/btcutil/deployments","created_at":"2013-05-28T23:25:26Z","updated_at":"2016-01-28T19:11:48Z","pushed_at":"2016-02-26T03:13:33Z","git_url":"git://github.com/btcsuite/btcutil.git","ssh_url":"git@github.com:btcsuite/btcutil.git","clone_url":"https://github.com/btcsuite/btcutil.git","svn_url":"https://github.com/btcsuite/btcutil","homepage":"","size":363,"stargazers_count":41,"watchers_count":41,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":3,"forks":45,"open_issues":3,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/btcsuite/btcutil/pulls/68"},"html":{"href":"https://github.com/btcsuite/btcutil/pull/68"},"issue":{"href":"https://api.github.com/repos/btcsuite/btcutil/issues/68"},"comments":{"href":"https://api.github.com/repos/btcsuite/btcutil/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/btcsuite/btcutil/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/btcsuite/btcutil/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/btcsuite/btcutil/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/btcsuite/btcutil/statuses/e0f1e8766ceffbc85a733b736244903348e5f01e"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}