{"action":"created","comment":{"url":"https://api.github.com/repos/osiam/osiam/pulls/comments/52898490","id":52898490,"diff_hunk":"@@ -0,0 +1,20 @@\n+package org.osiam.configuration;\n+\n+import com.fasterxml.jackson.core.Version;\n+import com.fasterxml.jackson.databind.Module;\n+import com.fasterxml.jackson.databind.module.SimpleModule;\n+import org.osiam.resources.helper.UserDeserializer;\n+import org.osiam.resources.scim.User;\n+import org.springframework.boot.autoconfigure.web.WebMvcAutoConfiguration;\n+import org.springframework.context.annotation.Bean;\n+import org.springframework.context.annotation.Configuration;\n+\n+@Configuration\n+public class JacksonConfig extends WebMvcAutoConfiguration {","path":"src/main/java/org/osiam/configuration/JacksonConfig.java","position":13,"original_position":13,"commit_id":"6f3333cfa360e425c6cdcbfe5167b8fab8041f1c","original_commit_id":"d74ff67f8aaf9df4dc1936b8e387b8a068b7857b","user":{"login":"tkrille","id":5213491,"avatar_url":"https://avatars.githubusercontent.com/u/5213491?v=3","gravatar_id":"","url":"https://api.github.com/users/tkrille","html_url":"https://github.com/tkrille","followers_url":"https://api.github.com/users/tkrille/followers","following_url":"https://api.github.com/users/tkrille/following{/other_user}","gists_url":"https://api.github.com/users/tkrille/gists{/gist_id}","starred_url":"https://api.github.com/users/tkrille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkrille/subscriptions","organizations_url":"https://api.github.com/users/tkrille/orgs","repos_url":"https://api.github.com/users/tkrille/repos","events_url":"https://api.github.com/users/tkrille/events{/privacy}","received_events_url":"https://api.github.com/users/tkrille/received_events","type":"User","site_admin":false},"body":"Unfortunately, I cannot test this assumptions. All I know is from the official docs and they don't say anything about such a restriction. Inheriting the auto configuration class just seems unnecessary.","created_at":"2016-02-15T13:32:55Z","updated_at":"2016-02-15T13:32:55Z","html_url":"https://github.com/osiam/osiam/pull/134#discussion_r52898490","pull_request_url":"https://api.github.com/repos/osiam/osiam/pulls/134","_links":{"self":{"href":"https://api.github.com/repos/osiam/osiam/pulls/comments/52898490"},"html":{"href":"https://github.com/osiam/osiam/pull/134#discussion_r52898490"},"pull_request":{"href":"https://api.github.com/repos/osiam/osiam/pulls/134"}}},"pull_request":{"url":"https://api.github.com/repos/osiam/osiam/pulls/134","id":59108812,"html_url":"https://github.com/osiam/osiam/pull/134","diff_url":"https://github.com/osiam/osiam/pull/134.diff","patch_url":"https://github.com/osiam/osiam/pull/134.patch","issue_url":"https://api.github.com/repos/osiam/osiam/issues/134","number":134,"state":"open","locked":false,"title":"Replace homemade validation with JSR303 validation","user":{"login":"wallner","id":563601,"avatar_url":"https://avatars.githubusercontent.com/u/563601?v=3","gravatar_id":"","url":"https://api.github.com/users/wallner","html_url":"https://github.com/wallner","followers_url":"https://api.github.com/users/wallner/followers","following_url":"https://api.github.com/users/wallner/following{/other_user}","gists_url":"https://api.github.com/users/wallner/gists{/gist_id}","starred_url":"https://api.github.com/users/wallner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallner/subscriptions","organizations_url":"https://api.github.com/users/wallner/orgs","repos_url":"https://api.github.com/users/wallner/repos","events_url":"https://api.github.com/users/wallner/events{/privacy}","received_events_url":"https://api.github.com/users/wallner/received_events","type":"User","site_admin":false},"body":"This commit replaces the homemade validation with Springs JSR303 bean\nvaldation. It also replaces all direkt manipulations of\nHttpServletRequest and HttpServletResponse objects with the saner Spring\nalternatives. It also introduces MocMVC tests. Closes #62","created_at":"2016-02-11T23:04:12Z","updated_at":"2016-02-15T13:32:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3e1ba1d093a9338473c0028930cb8272b095c5b","assignee":{"login":"tkrille","id":5213491,"avatar_url":"https://avatars.githubusercontent.com/u/5213491?v=3","gravatar_id":"","url":"https://api.github.com/users/tkrille","html_url":"https://github.com/tkrille","followers_url":"https://api.github.com/users/tkrille/followers","following_url":"https://api.github.com/users/tkrille/following{/other_user}","gists_url":"https://api.github.com/users/tkrille/gists{/gist_id}","starred_url":"https://api.github.com/users/tkrille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkrille/subscriptions","organizations_url":"https://api.github.com/users/tkrille/orgs","repos_url":"https://api.github.com/users/tkrille/repos","events_url":"https://api.github.com/users/tkrille/events{/privacy}","received_events_url":"https://api.github.com/users/tkrille/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/osiam/osiam/pulls/134/commits","review_comments_url":"https://api.github.com/repos/osiam/osiam/pulls/134/comments","review_comment_url":"https://api.github.com/repos/osiam/osiam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/osiam/osiam/issues/134/comments","statuses_url":"https://api.github.com/repos/osiam/osiam/statuses/6f3333cfa360e425c6cdcbfe5167b8fab8041f1c","head":{"label":"wallner:bean_validation","ref":"bean_validation","sha":"6f3333cfa360e425c6cdcbfe5167b8fab8041f1c","user":{"login":"wallner","id":563601,"avatar_url":"https://avatars.githubusercontent.com/u/563601?v=3","gravatar_id":"","url":"https://api.github.com/users/wallner","html_url":"https://github.com/wallner","followers_url":"https://api.github.com/users/wallner/followers","following_url":"https://api.github.com/users/wallner/following{/other_user}","gists_url":"https://api.github.com/users/wallner/gists{/gist_id}","starred_url":"https://api.github.com/users/wallner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallner/subscriptions","organizations_url":"https://api.github.com/users/wallner/orgs","repos_url":"https://api.github.com/users/wallner/repos","events_url":"https://api.github.com/users/wallner/events{/privacy}","received_events_url":"https://api.github.com/users/wallner/received_events","type":"User","site_admin":false},"repo":{"id":39103671,"name":"osiam","full_name":"wallner/osiam","owner":{"login":"wallner","id":563601,"avatar_url":"https://avatars.githubusercontent.com/u/563601?v=3","gravatar_id":"","url":"https://api.github.com/users/wallner","html_url":"https://github.com/wallner","followers_url":"https://api.github.com/users/wallner/followers","following_url":"https://api.github.com/users/wallner/following{/other_user}","gists_url":"https://api.github.com/users/wallner/gists{/gist_id}","starred_url":"https://api.github.com/users/wallner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallner/subscriptions","organizations_url":"https://api.github.com/users/wallner/orgs","repos_url":"https://api.github.com/users/wallner/repos","events_url":"https://api.github.com/users/wallner/events{/privacy}","received_events_url":"https://api.github.com/users/wallner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wallner/osiam","description":"MIT licensed Open Source Identity and Access Management implementing OAuth 2.0 and SCIMv2.","fork":true,"url":"https://api.github.com/repos/wallner/osiam","forks_url":"https://api.github.com/repos/wallner/osiam/forks","keys_url":"https://api.github.com/repos/wallner/osiam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wallner/osiam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wallner/osiam/teams","hooks_url":"https://api.github.com/repos/wallner/osiam/hooks","issue_events_url":"https://api.github.com/repos/wallner/osiam/issues/events{/number}","events_url":"https://api.github.com/repos/wallner/osiam/events","assignees_url":"https://api.github.com/repos/wallner/osiam/assignees{/user}","branches_url":"https://api.github.com/repos/wallner/osiam/branches{/branch}","tags_url":"https://api.github.com/repos/wallner/osiam/tags","blobs_url":"https://api.github.com/repos/wallner/osiam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wallner/osiam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wallner/osiam/git/refs{/sha}","trees_url":"https://api.github.com/repos/wallner/osiam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wallner/osiam/statuses/{sha}","languages_url":"https://api.github.com/repos/wallner/osiam/languages","stargazers_url":"https://api.github.com/repos/wallner/osiam/stargazers","contributors_url":"https://api.github.com/repos/wallner/osiam/contributors","subscribers_url":"https://api.github.com/repos/wallner/osiam/subscribers","subscription_url":"https://api.github.com/repos/wallner/osiam/subscription","commits_url":"https://api.github.com/repos/wallner/osiam/commits{/sha}","git_commits_url":"https://api.github.com/repos/wallner/osiam/git/commits{/sha}","comments_url":"https://api.github.com/repos/wallner/osiam/comments{/number}","issue_comment_url":"https://api.github.com/repos/wallner/osiam/issues/comments{/number}","contents_url":"https://api.github.com/repos/wallner/osiam/contents/{+path}","compare_url":"https://api.github.com/repos/wallner/osiam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wallner/osiam/merges","archive_url":"https://api.github.com/repos/wallner/osiam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wallner/osiam/downloads","issues_url":"https://api.github.com/repos/wallner/osiam/issues{/number}","pulls_url":"https://api.github.com/repos/wallner/osiam/pulls{/number}","milestones_url":"https://api.github.com/repos/wallner/osiam/milestones{/number}","notifications_url":"https://api.github.com/repos/wallner/osiam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wallner/osiam/labels{/name}","releases_url":"https://api.github.com/repos/wallner/osiam/releases{/id}","deployments_url":"https://api.github.com/repos/wallner/osiam/deployments","created_at":"2015-07-14T22:29:08Z","updated_at":"2015-06-22T16:38:13Z","pushed_at":"2016-02-15T11:53:23Z","git_url":"git://github.com/wallner/osiam.git","ssh_url":"git@github.com:wallner/osiam.git","clone_url":"https://github.com/wallner/osiam.git","svn_url":"https://github.com/wallner/osiam","homepage":"https://www.osiam.org","size":2946,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"osiam:master","ref":"master","sha":"dfe0b796ad918dc91f93180eec5ebf58702c80e7","user":{"login":"osiam","id":1918807,"avatar_url":"https://avatars.githubusercontent.com/u/1918807?v=3","gravatar_id":"","url":"https://api.github.com/users/osiam","html_url":"https://github.com/osiam","followers_url":"https://api.github.com/users/osiam/followers","following_url":"https://api.github.com/users/osiam/following{/other_user}","gists_url":"https://api.github.com/users/osiam/gists{/gist_id}","starred_url":"https://api.github.com/users/osiam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osiam/subscriptions","organizations_url":"https://api.github.com/users/osiam/orgs","repos_url":"https://api.github.com/users/osiam/repos","events_url":"https://api.github.com/users/osiam/events{/privacy}","received_events_url":"https://api.github.com/users/osiam/received_events","type":"Organization","site_admin":false},"repo":{"id":34720631,"name":"osiam","full_name":"osiam/osiam","owner":{"login":"osiam","id":1918807,"avatar_url":"https://avatars.githubusercontent.com/u/1918807?v=3","gravatar_id":"","url":"https://api.github.com/users/osiam","html_url":"https://github.com/osiam","followers_url":"https://api.github.com/users/osiam/followers","following_url":"https://api.github.com/users/osiam/following{/other_user}","gists_url":"https://api.github.com/users/osiam/gists{/gist_id}","starred_url":"https://api.github.com/users/osiam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osiam/subscriptions","organizations_url":"https://api.github.com/users/osiam/orgs","repos_url":"https://api.github.com/users/osiam/repos","events_url":"https://api.github.com/users/osiam/events{/privacy}","received_events_url":"https://api.github.com/users/osiam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/osiam/osiam","description":"MIT licensed Open Source Identity and Access Management implementing OAuth 2.0 and SCIMv2.","fork":false,"url":"https://api.github.com/repos/osiam/osiam","forks_url":"https://api.github.com/repos/osiam/osiam/forks","keys_url":"https://api.github.com/repos/osiam/osiam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osiam/osiam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osiam/osiam/teams","hooks_url":"https://api.github.com/repos/osiam/osiam/hooks","issue_events_url":"https://api.github.com/repos/osiam/osiam/issues/events{/number}","events_url":"https://api.github.com/repos/osiam/osiam/events","assignees_url":"https://api.github.com/repos/osiam/osiam/assignees{/user}","branches_url":"https://api.github.com/repos/osiam/osiam/branches{/branch}","tags_url":"https://api.github.com/repos/osiam/osiam/tags","blobs_url":"https://api.github.com/repos/osiam/osiam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osiam/osiam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osiam/osiam/git/refs{/sha}","trees_url":"https://api.github.com/repos/osiam/osiam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osiam/osiam/statuses/{sha}","languages_url":"https://api.github.com/repos/osiam/osiam/languages","stargazers_url":"https://api.github.com/repos/osiam/osiam/stargazers","contributors_url":"https://api.github.com/repos/osiam/osiam/contributors","subscribers_url":"https://api.github.com/repos/osiam/osiam/subscribers","subscription_url":"https://api.github.com/repos/osiam/osiam/subscription","commits_url":"https://api.github.com/repos/osiam/osiam/commits{/sha}","git_commits_url":"https://api.github.com/repos/osiam/osiam/git/commits{/sha}","comments_url":"https://api.github.com/repos/osiam/osiam/comments{/number}","issue_comment_url":"https://api.github.com/repos/osiam/osiam/issues/comments{/number}","contents_url":"https://api.github.com/repos/osiam/osiam/contents/{+path}","compare_url":"https://api.github.com/repos/osiam/osiam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osiam/osiam/merges","archive_url":"https://api.github.com/repos/osiam/osiam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osiam/osiam/downloads","issues_url":"https://api.github.com/repos/osiam/osiam/issues{/number}","pulls_url":"https://api.github.com/repos/osiam/osiam/pulls{/number}","milestones_url":"https://api.github.com/repos/osiam/osiam/milestones{/number}","notifications_url":"https://api.github.com/repos/osiam/osiam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osiam/osiam/labels{/name}","releases_url":"https://api.github.com/repos/osiam/osiam/releases{/id}","deployments_url":"https://api.github.com/repos/osiam/osiam/deployments","created_at":"2015-04-28T09:14:40Z","updated_at":"2016-01-21T07:16:21Z","pushed_at":"2016-02-15T11:53:23Z","git_url":"git://github.com/osiam/osiam.git","ssh_url":"git@github.com:osiam/osiam.git","clone_url":"https://github.com/osiam/osiam.git","svn_url":"https://github.com/osiam/osiam","homepage":"http://osiam.github.io/","size":2951,"stargazers_count":23,"watchers_count":23,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":55,"forks":8,"open_issues":55,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/osiam/osiam/pulls/134"},"html":{"href":"https://github.com/osiam/osiam/pull/134"},"issue":{"href":"https://api.github.com/repos/osiam/osiam/issues/134"},"comments":{"href":"https://api.github.com/repos/osiam/osiam/issues/134/comments"},"review_comments":{"href":"https://api.github.com/repos/osiam/osiam/pulls/134/comments"},"review_comment":{"href":"https://api.github.com/repos/osiam/osiam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/osiam/osiam/pulls/134/commits"},"statuses":{"href":"https://api.github.com/repos/osiam/osiam/statuses/6f3333cfa360e425c6cdcbfe5167b8fab8041f1c"}}}}