{"action":"closed","issue":{"url":"https://api.github.com/repos/electron/electron/issues/5925","repository_url":"https://api.github.com/repos/electron/electron","labels_url":"https://api.github.com/repos/electron/electron/issues/5925/labels{/name}","comments_url":"https://api.github.com/repos/electron/electron/issues/5925/comments","events_url":"https://api.github.com/repos/electron/electron/issues/5925/events","html_url":"https://github.com/electron/electron/issues/5925","id":159049576,"number":5925,"title":"Crash in Electron 1.2.1 when closing window (AskForOptions)","user":{"login":"bengotow","id":1037212,"avatar_url":"https://avatars.githubusercontent.com/u/1037212?v=3","gravatar_id":"","url":"https://api.github.com/users/bengotow","html_url":"https://github.com/bengotow","followers_url":"https://api.github.com/users/bengotow/followers","following_url":"https://api.github.com/users/bengotow/following{/other_user}","gists_url":"https://api.github.com/users/bengotow/gists{/gist_id}","starred_url":"https://api.github.com/users/bengotow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bengotow/subscriptions","organizations_url":"https://api.github.com/users/bengotow/orgs","repos_url":"https://api.github.com/users/bengotow/repos","events_url":"https://api.github.com/users/bengotow/events{/privacy}","received_events_url":"https://api.github.com/users/bengotow/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/electron/electron/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/electron/electron/labels/crash","name":"crash","color":"e11d21"},{"url":"https://api.github.com/repos/electron/electron/labels/osx","name":"osx","color":"c7def8"},{"url":"https://api.github.com/repos/electron/electron/labels/protocol","name":"protocol","color":"fad8c7"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-06-07T23:46:16Z","updated_at":"2016-06-09T08:04:58Z","closed_at":"2016-06-09T08:04:58Z","body":"I'm trying to narrow down the cause of this crash, but it happens about 50% of the time when users of N1 exit the \"welcome\" flow and the app tries to close one window and open two others. It seems to be failing deep within `atom::internal::AskForOptions`.\r\n\r\nWould love any input or advice to narrow this down.\r\n\r\nTwo (slightly different) logs so far:\r\n\r\n```\r\nThread 0 Crashed:: CrBrowserMain  Dispatch queue: com.apple.main-thread\r\n0   libsystem_platform.dylib      \t0x00007fff8f001551 _platform_memmove$VARIANT$Ivybridge + 49\r\n1   libc++.1.dylib                \t0x00007fff8a6ea225 std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::__init(char const*, unsigned long) + 91\r\n2   com.github.electron.framework \t0x00000001044d9222 0x1042c0000 + 2200098\r\n3   com.github.electron.framework \t0x00000001043a78de mate::Converter<net::URLRequest const*, void>::ToV8(v8::Isolate*, net::URLRequest const*) + 350\r\n4   com.github.electron.framework \t0x00000001042cdb6c v8::Local<v8::Value> mate::ConvertToV8<net::URLRequest const*>(v8::Isolate*, net::URLRequest const* const&) + 12\r\n5   com.github.electron.framework \t0x00000001042fd45c mate::internal::V8FunctionInvoker<void (net::URLRequest const*, v8::Local<v8::Value>)>::Go(v8::Isolate*, mate::internal::SafeV8Function const&, net::URLRequest const*, v8::Local<v8::Value>) + 172\r\n6   com.github.electron.framework \t0x00000001042fd6e9 void base::internal::RunnableAdapter<void (*)(v8::Isolate*, mate::internal::SafeV8Function const&, net::URLRequest const*, v8::Local<v8::Value>)>::Run<v8::Isolate* const&, mate::internal::SafeV8Function const&, net::URLRequest const*, v8::Local<v8::Value> >(v8::Isolate* const&&&, mate::internal::SafeV8Function const&&&, net::URLRequest const*&&, v8::Local<v8::Value>&&) + 25\r\n7   com.github.electron.framework \t0x00000001042fd6c5 void base::internal::InvokeHelper<false, void, base::internal::RunnableAdapter<void (*)(v8::Isolate*, mate::internal::SafeV8Function const&, net::URLRequest const*, v8::Local<v8::Value>)> >::MakeItSo<v8::Isolate* const&, mate::internal::SafeV8Function const&, net::URLRequest const*, v8::Local<v8::Value> >(base::internal::RunnableAdapter<void (*)(v8::Isolate*, mate::internal::SafeV8Function const&, net::URLRequest const*, v8::Local<v8::Value>)>, v8::Isolate* const&&&, mate::internal::SafeV8Function const&&&, net::URLRequest const*&&, v8::Local<v8::Value>&&) + 21\r\n8   com.github.electron.framework \t0x00000001042fd697 base::internal::Invoker<base::IndexSequence<0ul, 1ul>, base::internal::BindState<base::internal::RunnableAdapter<void (*)(v8::Isolate*, mate::internal::SafeV8Function const&, net::URLRequest const*, v8::Local<v8::Value>)>, void (v8::Isolate*, mate::internal::SafeV8Function const&, net::URLRequest const*, v8::Local<v8::Value>), v8::Isolate*&, mate::internal::SafeV8Function>, base::internal::InvokeHelper<false, void, base::internal::RunnableAdapter<void (*)(v8::Isolate*, mate::internal::SafeV8Function const&, net::URLRequest const*, v8::Local<v8::Value>)> >, void (net::URLRequest const*, v8::Local<v8::Value>)>::Run(base::internal::BindStateBase*, net::URLRequest const*&&, v8::Local<v8::Value>&&) + 71\r\n9   com.github.electron.framework \t0x00000001043659b7 base::Callback<void (net::URLRequest const*, v8::Local<v8::Value>), (base::internal::CopyMode)1>::Run(net::URLRequest const*, v8::Local<v8::Value>) const + 39\r\n10  com.github.electron.framework \t0x0000000104365951 atom::internal::AskForOptions(v8::Isolate*, base::Callback<void (net::URLRequest const*, v8::Local<v8::Value>), (base::internal::CopyMode)1> const&, net::URLRequest*, base::Callback<void (v8::Isolate*, v8::Local<v8::Value>), (base::internal::CopyMode)1> const&, base::Callback<void (bool, std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> >), (base::internal::CopyMode)1> const&) + 129\r\n11  com.github.electron.framework \t0x000000010436a3cb void base::internal::RunnableAdapter<void (*)(v8::Isolate*, base::Callback<void (net::URLRequest const*, v8::Local<v8::Value>), (base::internal::CopyMode)1> const&, net::URLRequest*, base::Callback<void (v8::Isolate*, v8::Local<v8::Value>), (base::internal::CopyMode)1> const&, base::Callback<void (bool, std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> >), (base::internal::CopyMode)1> const&)>::Run<v8::Isolate* const&, base::Callback<void (net::URLRequest const*, v8::Local<v8::Value>), (base::internal::CopyMode)1> const&, net::URLRequest* const&, base::Callback<void (v8::Isolate*, v8::Local<v8::Value>), (base::internal::CopyMode)1> const&, base::Callback<void (bool, std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> >), (base::internal::CopyMode)1> const&>(v8::Isolate* const&&&, base::Callback<void (net::URLRequest const*, v8::Local<v8::Value>), (base::internal::CopyMode)1> const&&&, net::URLRequest* const&&&, base::Callback<void (v8::Isolate*, v8::Local<v8::Value>), (base::internal::CopyMode)1> const&&&, base::Callback<void (bool, std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> >), (base::internal::CopyMode)1> const&&&) + 27\r\n12  com.github.electron.framework \t0x000000010436a375 void base::internal::InvokeHelper<false, void, base::internal::RunnableAdapter<void (*)(v8::Isolate*, base::Callback<void (net::URLRequest const*, v8::Local<v8::Value>), (base::internal::CopyMode)1> const&, net::URLRequest*, base::Callback<void (v8::Isolate*, v8::Local<v8::Value>), (base::internal::CopyMode)1> const&, base::Callback<void (bool, std::__1::unique_ptr<base::Value, \r\n```\r\n\r\n```\r\nThread 0 Crashed:: CrBrowserMain  Dispatch queue: com.apple.main-thread\r\n0   com.github.electron.framework \t0x000000010185da36 atom::GetUploadData(base::ListValue*, net::URLRequest const*) + 38\r\n1   com.github.electron.framework \t0x000000010185d906 mate::Converter<net::URLRequest const*, void>::ToV8(v8::Isolate*, net::URLRequest const*) + 390\r\n2   com.github.electron.framework \t0x0000000101783b6c v8::Local<v8::Value> mate::ConvertToV8<net::URLRequest const*>(v8::Isolate*, net::URLRequest const* const&) + 12\r\n3   com.github.electron.framework \t0x00000001017b345c mate::internal::V8FunctionInvoker<void (net::URLRequest const*, v8::Local<v8::Value>)>::Go(v8::Isolate*, mate::internal::SafeV8Function const&, net::URLRequest const*, v8::Local<v8::Value>) + 172\r\n4   com.github.electron.framework \t0x00000001017b36e9 void base::internal::RunnableAdapter<void (*)(v8::Isolate*, mate::internal::SafeV8Function const&, net::URLRequest const*, v8::Local<v8::Value>)>::Run<v8::Isolate* const&, mate::internal::SafeV8Function const&, net::URLRequest const*, v8::Local<v8::Value> >(v8::Isolate* const&&&, mate::internal::SafeV8Function const&&&, net::URLRequest const*&&, v8::Local<v8::Value>&&) + 25\r\n5   com.github.electron.framework \t0x00000001017b36c5 void base::internal::InvokeHelper<false, void, base::internal::RunnableAdapter<void (*)(v8::Isolate*, mate::internal::SafeV8Function const&, net::URLRequest const*, v8::Local<v8::Value>)> >::MakeItSo<v8::Isolate* const&, mate::internal::SafeV8Function const&, net::URLRequest const*, v8::Local<v8::Value> >(base::internal::RunnableAdapter<void (*)(v8::Isolate*, mate::internal::SafeV8Function const&, net::URLRequest const*, v8::Local<v8::Value>)>, v8::Isolate* const&&&, mate::internal::SafeV8Function const&&&, net::URLRequest const*&&, v8::Local<v8::Value>&&) + 21\r\n```"}}
{"actor":{"display_login":"zcbenz"}}