{"push_id":1146523466,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"5d6560393299780cdb38252c5e9803445166bd3f","before":"ce6c3007ee246da710db8e59c40eceb58a3d8362","commits":[{"sha":"5d6560393299780cdb38252c5e9803445166bd3f","author":{"name":"Peiyu Wang","email":"d174f8fb0d546c0de85a0b484162cd0c833dc038@gmail.com"},"message":"dep-usage: create edge only for those direct or transitive dependencies.\n\nDiscovered this while working on using dep-usage to clean up twitter internal\nbuild files, when a source file belongs to more than one target, say `:a` and\n`:b` both contain `A.java`, not uncommon when globs especially rglobs is used.\n`:d` depends on `A.java` implicitly through `:c`, which further depends on\n`:a`, in this case, only `:a` should be marked as undeclared dependency.\nMarking `:b` as undeclared dependency can potentially introduce circular\ndependency, in this example, say `:b` also depends on `:c`.\n\nThis review applies the smae check used by `JvmDependencyCheck` also in\n`JvmDependencyUsage`.\n\nTesting Done:\nhttps://travis-ci.org/peiyuwang/pants/builds/135720648 passed\n\nBugs closed: 3562\n\nReviewed at https://rbcommons.com/s/twitter/r/3978/","distinct":true,"url":"https://api.github.com/repos/pantsbuild/pants/commits/5d6560393299780cdb38252c5e9803445166bd3f"}]}
{"actor":{"display_login":"peiyuwang"}}