{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/9607","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9607/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9607/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9607/events","html_url":"https://github.com/joomla/joomla-cms/pull/9607","id":143726450,"number":9607,"title":"Fix form validation in com_users login view","user":{"login":"matrikular","id":1304616,"avatar_url":"https://avatars.githubusercontent.com/u/1304616?v=3","gravatar_id":"","url":"https://api.github.com/users/matrikular","html_url":"https://github.com/matrikular","followers_url":"https://api.github.com/users/matrikular/followers","following_url":"https://api.github.com/users/matrikular/following{/other_user}","gists_url":"https://api.github.com/users/matrikular/gists{/gist_id}","starred_url":"https://api.github.com/users/matrikular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrikular/subscriptions","organizations_url":"https://api.github.com/users/matrikular/orgs","repos_url":"https://api.github.com/users/matrikular/repos","events_url":"https://api.github.com/users/matrikular/events{/privacy}","received_events_url":"https://api.github.com/users/matrikular/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-26T16:26:33Z","updated_at":"2016-03-28T23:55:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/9607","html_url":"https://github.com/joomla/joomla-cms/pull/9607","diff_url":"https://github.com/joomla/joomla-cms/pull/9607.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/9607.patch"},"body":"#### Summary of Changes\r\nThe client side form validation messages in com_users login view, are actually generated by the browser, not by Joomla!. This is because the submit button is missing the \"validate\" CSS class. Furthermore, the layout does not load the required JavaScript files.\r\n\r\nThough most browsers interpret the required attribute and offer some form of client side validation / visualisation, custom registered validation handlers like \"validate-username\" assigned to the username field are not recognised.\r\n\r\n#### Testing Instructions\r\n1. Either go to: http(s)://domain.tld/index.php?option=com_users&view=login or create a menu item to the login form\r\n2. Hit the \"Log in\" button. Depending on your browser, you should see a message that indicates an invalid required field (e.g. Username).\r\n3. Install / Apply the patch and refresh the page. You should now see the standard validation behavior and messages."},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/202632053","html_url":"https://github.com/joomla/joomla-cms/pull/9607#issuecomment-202632053","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9607","id":202632053,"user":{"login":"brianteeman","id":1296369,"avatar_url":"https://avatars.githubusercontent.com/u/1296369?v=3","gravatar_id":"","url":"https://api.github.com/users/brianteeman","html_url":"https://github.com/brianteeman","followers_url":"https://api.github.com/users/brianteeman/followers","following_url":"https://api.github.com/users/brianteeman/following{/other_user}","gists_url":"https://api.github.com/users/brianteeman/gists{/gist_id}","starred_url":"https://api.github.com/users/brianteeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianteeman/subscriptions","organizations_url":"https://api.github.com/users/brianteeman/orgs","repos_url":"https://api.github.com/users/brianteeman/repos","events_url":"https://api.github.com/users/brianteeman/events{/privacy}","received_events_url":"https://api.github.com/users/brianteeman/received_events","type":"User","site_admin":false},"created_at":"2016-03-28T23:55:18Z","updated_at":"2016-03-28T23:55:18Z","body":"RTC<hr /><sub>This comment was created with the <a href=\"https://github.com/joomla/jissues\">J!Tracker Application</a> at <a href=\"https://issues.joomla.org/tracker/joomla-cms/9607\">issues.joomla.org/joomla-cms/9607</a>.</sub>"}}