{"action":"created","comment":{"url":"https://api.github.com/repos/asteris-llc/converge/pulls/comments/84725865","pull_request_review_id":5485255,"id":84725865,"diff_hunk":"@@ -1,13 +1,17 @@\n NAME = $(shell awk -F\\\" '/^const Name/ { print $$2 }' cmd/root.go)\n-VERSION = $(shell awk -F\\\" '/^const Version/ { print $$2 }' cmd/version.go)\n RPCLINT=$(shell find ./rpc -type f \\( -not -iname 'root.*.go' -iname '*.go' \\) )\n TOLINT = $(shell find . -type f \\( -not -ipath './vendor*'  -not -ipath './docs*' -not -ipath './rpc*' -not -iname 'main.go' -iname '*.go' \\) -exec dirname {} \\; | sort -u)\n TESTDIRS = $(shell find . -name '*_test.go' -exec dirname \\{\\} \\; | grep -v vendor | uniq)\n NONVENDOR = ${shell find . -name '*.go' | grep -v vendor}\n BENCHDIRS= $(shell find . -name '*_test.go' | grep -v vendor | xargs grep '*testing.B' | cut -d: -f1 | xargs -n1 dirname | uniq)\n BENCH = .\n \n-converge: $(shell find . -name '*.go') rpc/pb/root.pb.go rpc/pb/root.pb.gw.go\n+converge: $(shell find . -name '*.go' -not -name 'version_number.go') rpc/pb/root.pb.go rpc/pb/root.pb.gw.go\n+\t@echo \"package cmd\" > cmd/version_number.go","path":"Makefile","position":12,"original_position":12,"commit_id":"e002a1227694d75f8fd234c9d3124ec31bb7d07e","original_commit_id":"e002a1227694d75f8fd234c9d3124ec31bb7d07e","user":{"login":"rebeccaskinner","id":203691,"avatar_url":"https://avatars.githubusercontent.com/u/203691?v=3","gravatar_id":"","url":"https://api.github.com/users/rebeccaskinner","html_url":"https://github.com/rebeccaskinner","followers_url":"https://api.github.com/users/rebeccaskinner/followers","following_url":"https://api.github.com/users/rebeccaskinner/following{/other_user}","gists_url":"https://api.github.com/users/rebeccaskinner/gists{/gist_id}","starred_url":"https://api.github.com/users/rebeccaskinner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebeccaskinner/subscriptions","organizations_url":"https://api.github.com/users/rebeccaskinner/orgs","repos_url":"https://api.github.com/users/rebeccaskinner/repos","events_url":"https://api.github.com/users/rebeccaskinner/events{/privacy}","received_events_url":"https://api.github.com/users/rebeccaskinner/received_events","type":"User","site_admin":false},"body":"We could make this a phony target and depend on it for the converge target just to keep version number generation separate from building, but it's probably not that big of a deal.","created_at":"2016-10-24T16:22:13Z","updated_at":"2016-10-24T16:22:14Z","html_url":"https://github.com/asteris-llc/converge/pull/413#discussion_r84725865","pull_request_url":"https://api.github.com/repos/asteris-llc/converge/pulls/413","_links":{"self":{"href":"https://api.github.com/repos/asteris-llc/converge/pulls/comments/84725865"},"html":{"href":"https://github.com/asteris-llc/converge/pull/413#discussion_r84725865"},"pull_request":{"href":"https://api.github.com/repos/asteris-llc/converge/pulls/413"}}},"pull_request":{"url":"https://api.github.com/repos/asteris-llc/converge/pulls/413","id":90642423,"html_url":"https://github.com/asteris-llc/converge/pull/413","diff_url":"https://github.com/asteris-llc/converge/pull/413.diff","patch_url":"https://github.com/asteris-llc/converge/pull/413.patch","issue_url":"https://api.github.com/repos/asteris-llc/converge/issues/413","number":413,"state":"open","locked":false,"title":"Nightly/test builds","user":{"login":"BrianHicks","id":355401,"avatar_url":"https://avatars.githubusercontent.com/u/355401?v=3","gravatar_id":"","url":"https://api.github.com/users/BrianHicks","html_url":"https://github.com/BrianHicks","followers_url":"https://api.github.com/users/BrianHicks/followers","following_url":"https://api.github.com/users/BrianHicks/following{/other_user}","gists_url":"https://api.github.com/users/BrianHicks/gists{/gist_id}","starred_url":"https://api.github.com/users/BrianHicks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrianHicks/subscriptions","organizations_url":"https://api.github.com/users/BrianHicks/orgs","repos_url":"https://api.github.com/users/BrianHicks/repos","events_url":"https://api.github.com/users/BrianHicks/events{/privacy}","received_events_url":"https://api.github.com/users/BrianHicks/received_events","type":"User","site_admin":false},"body":"This configuration will:\r\n\r\n1. tag all releases made with `make converge` with the correct version metadata\r\n2. do the same, but for CI\r\n3. upload those releases to S3 when built on master (I've already added the pipeline steps in Wercker)","created_at":"2016-10-24T16:01:49Z","updated_at":"2016-10-24T16:22:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94359fb9d8428accf737d220a262fe7bc144b121","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/asteris-llc/converge/pulls/413/commits","review_comments_url":"https://api.github.com/repos/asteris-llc/converge/pulls/413/comments","review_comment_url":"https://api.github.com/repos/asteris-llc/converge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/asteris-llc/converge/issues/413/comments","statuses_url":"https://api.github.com/repos/asteris-llc/converge/statuses/e002a1227694d75f8fd234c9d3124ec31bb7d07e","head":{"label":"asteris-llc:feature/nightly-builds","ref":"feature/nightly-builds","sha":"e002a1227694d75f8fd234c9d3124ec31bb7d07e","user":{"login":"asteris-llc","id":6193478,"avatar_url":"https://avatars.githubusercontent.com/u/6193478?v=3","gravatar_id":"","url":"https://api.github.com/users/asteris-llc","html_url":"https://github.com/asteris-llc","followers_url":"https://api.github.com/users/asteris-llc/followers","following_url":"https://api.github.com/users/asteris-llc/following{/other_user}","gists_url":"https://api.github.com/users/asteris-llc/gists{/gist_id}","starred_url":"https://api.github.com/users/asteris-llc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asteris-llc/subscriptions","organizations_url":"https://api.github.com/users/asteris-llc/orgs","repos_url":"https://api.github.com/users/asteris-llc/repos","events_url":"https://api.github.com/users/asteris-llc/events{/privacy}","received_events_url":"https://api.github.com/users/asteris-llc/received_events","type":"Organization","site_admin":false},"repo":{"id":59234611,"name":"converge","full_name":"asteris-llc/converge","owner":{"login":"asteris-llc","id":6193478,"avatar_url":"https://avatars.githubusercontent.com/u/6193478?v=3","gravatar_id":"","url":"https://api.github.com/users/asteris-llc","html_url":"https://github.com/asteris-llc","followers_url":"https://api.github.com/users/asteris-llc/followers","following_url":"https://api.github.com/users/asteris-llc/following{/other_user}","gists_url":"https://api.github.com/users/asteris-llc/gists{/gist_id}","starred_url":"https://api.github.com/users/asteris-llc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asteris-llc/subscriptions","organizations_url":"https://api.github.com/users/asteris-llc/orgs","repos_url":"https://api.github.com/users/asteris-llc/repos","events_url":"https://api.github.com/users/asteris-llc/events{/privacy}","received_events_url":"https://api.github.com/users/asteris-llc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/asteris-llc/converge","description":"An easy and powerful configuration management system.","fork":false,"url":"https://api.github.com/repos/asteris-llc/converge","forks_url":"https://api.github.com/repos/asteris-llc/converge/forks","keys_url":"https://api.github.com/repos/asteris-llc/converge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asteris-llc/converge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asteris-llc/converge/teams","hooks_url":"https://api.github.com/repos/asteris-llc/converge/hooks","issue_events_url":"https://api.github.com/repos/asteris-llc/converge/issues/events{/number}","events_url":"https://api.github.com/repos/asteris-llc/converge/events","assignees_url":"https://api.github.com/repos/asteris-llc/converge/assignees{/user}","branches_url":"https://api.github.com/repos/asteris-llc/converge/branches{/branch}","tags_url":"https://api.github.com/repos/asteris-llc/converge/tags","blobs_url":"https://api.github.com/repos/asteris-llc/converge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asteris-llc/converge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asteris-llc/converge/git/refs{/sha}","trees_url":"https://api.github.com/repos/asteris-llc/converge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asteris-llc/converge/statuses/{sha}","languages_url":"https://api.github.com/repos/asteris-llc/converge/languages","stargazers_url":"https://api.github.com/repos/asteris-llc/converge/stargazers","contributors_url":"https://api.github.com/repos/asteris-llc/converge/contributors","subscribers_url":"https://api.github.com/repos/asteris-llc/converge/subscribers","subscription_url":"https://api.github.com/repos/asteris-llc/converge/subscription","commits_url":"https://api.github.com/repos/asteris-llc/converge/commits{/sha}","git_commits_url":"https://api.github.com/repos/asteris-llc/converge/git/commits{/sha}","comments_url":"https://api.github.com/repos/asteris-llc/converge/comments{/number}","issue_comment_url":"https://api.github.com/repos/asteris-llc/converge/issues/comments{/number}","contents_url":"https://api.github.com/repos/asteris-llc/converge/contents/{+path}","compare_url":"https://api.github.com/repos/asteris-llc/converge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asteris-llc/converge/merges","archive_url":"https://api.github.com/repos/asteris-llc/converge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asteris-llc/converge/downloads","issues_url":"https://api.github.com/repos/asteris-llc/converge/issues{/number}","pulls_url":"https://api.github.com/repos/asteris-llc/converge/pulls{/number}","milestones_url":"https://api.github.com/repos/asteris-llc/converge/milestones{/number}","notifications_url":"https://api.github.com/repos/asteris-llc/converge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asteris-llc/converge/labels{/name}","releases_url":"https://api.github.com/repos/asteris-llc/converge/releases{/id}","deployments_url":"https://api.github.com/repos/asteris-llc/converge/deployments","created_at":"2016-05-19T19:11:26Z","updated_at":"2016-10-22T23:22:48Z","pushed_at":"2016-10-24T16:01:49Z","git_url":"git://github.com/asteris-llc/converge.git","ssh_url":"git@github.com:asteris-llc/converge.git","clone_url":"https://github.com/asteris-llc/converge.git","svn_url":"https://github.com/asteris-llc/converge","homepage":"converge.aster.is","size":40683,"stargazers_count":12,"watchers_count":12,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":69,"forks":5,"open_issues":69,"watchers":12,"default_branch":"master"}},"base":{"label":"asteris-llc:master","ref":"master","sha":"148e436b43e3756eb18787e4d97ec2c38499e53e","user":{"login":"asteris-llc","id":6193478,"avatar_url":"https://avatars.githubusercontent.com/u/6193478?v=3","gravatar_id":"","url":"https://api.github.com/users/asteris-llc","html_url":"https://github.com/asteris-llc","followers_url":"https://api.github.com/users/asteris-llc/followers","following_url":"https://api.github.com/users/asteris-llc/following{/other_user}","gists_url":"https://api.github.com/users/asteris-llc/gists{/gist_id}","starred_url":"https://api.github.com/users/asteris-llc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asteris-llc/subscriptions","organizations_url":"https://api.github.com/users/asteris-llc/orgs","repos_url":"https://api.github.com/users/asteris-llc/repos","events_url":"https://api.github.com/users/asteris-llc/events{/privacy}","received_events_url":"https://api.github.com/users/asteris-llc/received_events","type":"Organization","site_admin":false},"repo":{"id":59234611,"name":"converge","full_name":"asteris-llc/converge","owner":{"login":"asteris-llc","id":6193478,"avatar_url":"https://avatars.githubusercontent.com/u/6193478?v=3","gravatar_id":"","url":"https://api.github.com/users/asteris-llc","html_url":"https://github.com/asteris-llc","followers_url":"https://api.github.com/users/asteris-llc/followers","following_url":"https://api.github.com/users/asteris-llc/following{/other_user}","gists_url":"https://api.github.com/users/asteris-llc/gists{/gist_id}","starred_url":"https://api.github.com/users/asteris-llc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asteris-llc/subscriptions","organizations_url":"https://api.github.com/users/asteris-llc/orgs","repos_url":"https://api.github.com/users/asteris-llc/repos","events_url":"https://api.github.com/users/asteris-llc/events{/privacy}","received_events_url":"https://api.github.com/users/asteris-llc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/asteris-llc/converge","description":"An easy and powerful configuration management system.","fork":false,"url":"https://api.github.com/repos/asteris-llc/converge","forks_url":"https://api.github.com/repos/asteris-llc/converge/forks","keys_url":"https://api.github.com/repos/asteris-llc/converge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asteris-llc/converge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asteris-llc/converge/teams","hooks_url":"https://api.github.com/repos/asteris-llc/converge/hooks","issue_events_url":"https://api.github.com/repos/asteris-llc/converge/issues/events{/number}","events_url":"https://api.github.com/repos/asteris-llc/converge/events","assignees_url":"https://api.github.com/repos/asteris-llc/converge/assignees{/user}","branches_url":"https://api.github.com/repos/asteris-llc/converge/branches{/branch}","tags_url":"https://api.github.com/repos/asteris-llc/converge/tags","blobs_url":"https://api.github.com/repos/asteris-llc/converge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asteris-llc/converge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asteris-llc/converge/git/refs{/sha}","trees_url":"https://api.github.com/repos/asteris-llc/converge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asteris-llc/converge/statuses/{sha}","languages_url":"https://api.github.com/repos/asteris-llc/converge/languages","stargazers_url":"https://api.github.com/repos/asteris-llc/converge/stargazers","contributors_url":"https://api.github.com/repos/asteris-llc/converge/contributors","subscribers_url":"https://api.github.com/repos/asteris-llc/converge/subscribers","subscription_url":"https://api.github.com/repos/asteris-llc/converge/subscription","commits_url":"https://api.github.com/repos/asteris-llc/converge/commits{/sha}","git_commits_url":"https://api.github.com/repos/asteris-llc/converge/git/commits{/sha}","comments_url":"https://api.github.com/repos/asteris-llc/converge/comments{/number}","issue_comment_url":"https://api.github.com/repos/asteris-llc/converge/issues/comments{/number}","contents_url":"https://api.github.com/repos/asteris-llc/converge/contents/{+path}","compare_url":"https://api.github.com/repos/asteris-llc/converge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asteris-llc/converge/merges","archive_url":"https://api.github.com/repos/asteris-llc/converge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asteris-llc/converge/downloads","issues_url":"https://api.github.com/repos/asteris-llc/converge/issues{/number}","pulls_url":"https://api.github.com/repos/asteris-llc/converge/pulls{/number}","milestones_url":"https://api.github.com/repos/asteris-llc/converge/milestones{/number}","notifications_url":"https://api.github.com/repos/asteris-llc/converge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asteris-llc/converge/labels{/name}","releases_url":"https://api.github.com/repos/asteris-llc/converge/releases{/id}","deployments_url":"https://api.github.com/repos/asteris-llc/converge/deployments","created_at":"2016-05-19T19:11:26Z","updated_at":"2016-10-22T23:22:48Z","pushed_at":"2016-10-24T16:01:49Z","git_url":"git://github.com/asteris-llc/converge.git","ssh_url":"git@github.com:asteris-llc/converge.git","clone_url":"https://github.com/asteris-llc/converge.git","svn_url":"https://github.com/asteris-llc/converge","homepage":"converge.aster.is","size":40683,"stargazers_count":12,"watchers_count":12,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":69,"forks":5,"open_issues":69,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/asteris-llc/converge/pulls/413"},"html":{"href":"https://github.com/asteris-llc/converge/pull/413"},"issue":{"href":"https://api.github.com/repos/asteris-llc/converge/issues/413"},"comments":{"href":"https://api.github.com/repos/asteris-llc/converge/issues/413/comments"},"review_comments":{"href":"https://api.github.com/repos/asteris-llc/converge/pulls/413/comments"},"review_comment":{"href":"https://api.github.com/repos/asteris-llc/converge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/asteris-llc/converge/pulls/413/commits"},"statuses":{"href":"https://api.github.com/repos/asteris-llc/converge/statuses/e002a1227694d75f8fd234c9d3124ec31bb7d07e"}}}}
{"actor":{"display_login":"rebeccaskinner"}}