{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23506","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23506/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23506/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23506/events","html_url":"https://github.com/kubernetes/kubernetes/pull/23506","id":143616454,"number":23506,"title":"Kubelet: Start using the official docker engine-api","user":{"login":"Random-Liu","id":5821883,"avatar_url":"https://avatars.githubusercontent.com/u/5821883?v=3","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/component/kubelet","name":"component/kubelet","color":"0052cc"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/dependency/docker","name":"dependency/docker","color":"fbfa04"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/enhancement","name":"kind/enhancement","color":"c7def8"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/team/node","name":"team/node","color":"d2b48c"}],"state":"open","locked":false,"assignee":{"login":"yujuhong","id":10524058,"avatar_url":"https://avatars.githubusercontent.com/u/10524058?v=3","gravatar_id":"","url":"https://api.github.com/users/yujuhong","html_url":"https://github.com/yujuhong","followers_url":"https://api.github.com/users/yujuhong/followers","following_url":"https://api.github.com/users/yujuhong/following{/other_user}","gists_url":"https://api.github.com/users/yujuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/yujuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yujuhong/subscriptions","organizations_url":"https://api.github.com/users/yujuhong/orgs","repos_url":"https://api.github.com/users/yujuhong/repos","events_url":"https://api.github.com/users/yujuhong/events{/privacy}","received_events_url":"https://api.github.com/users/yujuhong/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2016-03-25T22:29:43Z","updated_at":"2016-03-28T17:28:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23506","html_url":"https://github.com/kubernetes/kubernetes/pull/23506","diff_url":"https://github.com/kubernetes/kubernetes/pull/23506.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/23506.patch"},"body":"For #20895.\r\n\r\nThis is the **first step** in the roadmap of switching to docker [engine-api](https://github.com/docker/engine-api).\r\nIn this PR, I keep the old `DockerInterface` and implement it with the new engine-api.\r\nWith this approach, we could switch to engine-api with minimum change, so that we could:\r\n* Test the engine-api without huge refactoring.\r\n* Send following PRs to refactor functions in `DockerInterface` separately so as to avoid a huge change in one PR.\r\n\r\nI've tested this PR locally, it passed all the node conformance test:\r\n```\r\nmake test_e2e_node\r\n\r\nRan 19 of 19 Specs in 823.395 seconds\r\nSUCCESS! -- 19 Passed | 0 Failed | 0 Pending | 0 Skipped PASS\r\n\r\nGinkgo ran 1 suite in 13m49.429979585s\r\nTest Suite Passed\r\n```\r\nAnd it also passed the jenkins gce e2e test:\r\n```\r\ngo run hack/e2e.go -test -v --test_args=\"--ginkgo.skip=\\[Slow\\]|\\[Serial\\]|\\[Disruptive\\]|\\[Flaky\\]|\\[Feature:.+\\]\"\r\n\r\nRan 161 of 268 Specs in 4570.214 seconds\r\nSUCCESS! -- 161 Passed | 0 Failed | 0 Pending | 107 Skipped PASS\r\n\r\nGinkgo ran 1 suite in 1h16m16.325934558s\r\nTest Suite Passed\r\n2016/03/25 15:12:42 e2e.go:196: Step 'Ginkgo tests' finished in 1h16m18.918754301s\r\n```\r\n\r\nI'm writing the design document, and will post the switching roadmap in an umbrella issue soon.\r\n\r\n@kubernetes/sig-node "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/202497047","html_url":"https://github.com/kubernetes/kubernetes/pull/23506#issuecomment-202497047","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23506","id":202497047,"user":{"login":"ncdc","id":354,"avatar_url":"https://avatars.githubusercontent.com/u/354?v=3","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"created_at":"2016-03-28T17:28:39Z","updated_at":"2016-03-28T17:28:39Z","body":"cc @kubernetes/rh-cluster-infra "}}