{"action":"closed","issue":{"url":"https://api.github.com/repos/google/blockly/issues/623","repository_url":"https://api.github.com/repos/google/blockly","labels_url":"https://api.github.com/repos/google/blockly/issues/623/labels{/name}","comments_url":"https://api.github.com/repos/google/blockly/issues/623/comments","events_url":"https://api.github.com/repos/google/blockly/issues/623/events","html_url":"https://github.com/google/blockly/issues/623","id":176139920,"number":623,"title":"'this' in getTopLevelWorkspaceMetrics_ and setTopLevelWorkspaceMetrics_","user":{"login":"NeilFraser","id":250480,"avatar_url":"https://avatars.githubusercontent.com/u/250480?v=3","gravatar_id":"","url":"https://api.github.com/users/NeilFraser","html_url":"https://github.com/NeilFraser","followers_url":"https://api.github.com/users/NeilFraser/followers","following_url":"https://api.github.com/users/NeilFraser/following{/other_user}","gists_url":"https://api.github.com/users/NeilFraser/gists{/gist_id}","starred_url":"https://api.github.com/users/NeilFraser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NeilFraser/subscriptions","organizations_url":"https://api.github.com/users/NeilFraser/orgs","repos_url":"https://api.github.com/users/NeilFraser/repos","events_url":"https://api.github.com/users/NeilFraser/events{/privacy}","received_events_url":"https://api.github.com/users/NeilFraser/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"rachel-fenichel","id":13686399,"avatar_url":"https://avatars.githubusercontent.com/u/13686399?v=3","gravatar_id":"","url":"https://api.github.com/users/rachel-fenichel","html_url":"https://github.com/rachel-fenichel","followers_url":"https://api.github.com/users/rachel-fenichel/followers","following_url":"https://api.github.com/users/rachel-fenichel/following{/other_user}","gists_url":"https://api.github.com/users/rachel-fenichel/gists{/gist_id}","starred_url":"https://api.github.com/users/rachel-fenichel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rachel-fenichel/subscriptions","organizations_url":"https://api.github.com/users/rachel-fenichel/orgs","repos_url":"https://api.github.com/users/rachel-fenichel/repos","events_url":"https://api.github.com/users/rachel-fenichel/events{/privacy}","received_events_url":"https://api.github.com/users/rachel-fenichel/received_events","type":"User","site_admin":false},"assignees":[{"login":"rachel-fenichel","id":13686399,"avatar_url":"https://avatars.githubusercontent.com/u/13686399?v=3","gravatar_id":"","url":"https://api.github.com/users/rachel-fenichel","html_url":"https://github.com/rachel-fenichel","followers_url":"https://api.github.com/users/rachel-fenichel/followers","following_url":"https://api.github.com/users/rachel-fenichel/following{/other_user}","gists_url":"https://api.github.com/users/rachel-fenichel/gists{/gist_id}","starred_url":"https://api.github.com/users/rachel-fenichel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rachel-fenichel/subscriptions","organizations_url":"https://api.github.com/users/rachel-fenichel/orgs","repos_url":"https://api.github.com/users/rachel-fenichel/repos","events_url":"https://api.github.com/users/rachel-fenichel/events{/privacy}","received_events_url":"https://api.github.com/users/rachel-fenichel/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-09-10T00:02:13Z","updated_at":"2016-10-07T05:54:21Z","closed_at":"2016-10-07T05:54:21Z","body":"appengine/third-party/blockly/core/workspace_svg.js:1302: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n  var svgSize = Blockly.svgSize(this.getParentSvg());\r\n                                ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1303: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n  if (this.toolbox_) {\r\n      ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1304: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n    if (this.toolboxPosition == Blockly.TOOLBOX_AT_TOP ||\r\n        ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1305: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n        this.toolboxPosition == Blockly.TOOLBOX_AT_BOTTOM) {\r\n        ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1306: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n      svgSize.height -= this.toolbox_.getHeight();\r\n                        ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1307: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n    } else if (this.toolboxPosition == Blockly.TOOLBOX_AT_LEFT ||\r\n               ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1308: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n        this.toolboxPosition == Blockly.TOOLBOX_AT_RIGHT) {\r\n        ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1309: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n      svgSize.width -= this.toolbox_.getWidth();\r\n                       ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1317: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n  var blockBox = this.getBlocksBoundingBox();\r\n                 ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1320: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n  var contentWidth = blockBox.width * this.scale;\r\n                                      ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1321: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n  var contentHeight = blockBox.height * this.scale;\r\n                                        ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1322: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n  var contentX = blockBox.x * this.scale;\r\n                              ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1323: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n  var contentY = blockBox.y * this.scale;\r\n                              ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1324: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n  if (this.scrollbar) {\r\n      ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1342: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n  if (this.toolbox_ && this.toolboxPosition == Blockly.TOOLBOX_AT_LEFT) {\r\n      ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1342: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n  if (this.toolbox_ && this.toolboxPosition == Blockly.TOOLBOX_AT_LEFT) {\r\n                       ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1343: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n    absoluteLeft = this.toolbox_.getWidth();\r\n                   ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1346: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n  if (this.toolbox_ && this.toolboxPosition == Blockly.TOOLBOX_AT_TOP) {\r\n      ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1346: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n  if (this.toolbox_ && this.toolboxPosition == Blockly.TOOLBOX_AT_TOP) {\r\n                       ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1347: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n    absoluteTop = this.toolbox_.getHeight();\r\n                  ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1355: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n    viewTop: -this.scrollY,\r\n              ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1356: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n    viewLeft: -this.scrollX,\r\n               ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1361: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n    toolboxWidth: this.toolbox_ ? this.toolbox_.getWidth() : 0,\r\n                  ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1361: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n    toolboxWidth: this.toolbox_ ? this.toolbox_.getWidth() : 0,\r\n                                  ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1362: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n    toolboxHeight: this.toolbox_ ? this.toolbox_.getHeight() : 0,\r\n                   ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1362: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n    toolboxHeight: this.toolbox_ ? this.toolbox_.getHeight() : 0,\r\n                                   ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1363: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n    flyoutWidth: this.flyout_ ? this.flyout_.getWidth() : 0,\r\n                 ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1363: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n    flyoutWidth: this.flyout_ ? this.flyout_.getWidth() : 0,\r\n                                ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1364: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n    flyoutHeight: this.flyout_ ? this.flyout_.getHeight() : 0,\r\n                  ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1364: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n    flyoutHeight: this.flyout_ ? this.flyout_.getHeight() : 0,\r\n                                 ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1365: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.getTopLevelWorkspaceMetrics_\r\n    toolboxPosition: this.toolboxPosition\r\n                     ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1377: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.setTopLevelWorkspaceMetrics_\r\n  if (!this.scrollbar) {\r\n       ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1380: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.setTopLevelWorkspaceMetrics_\r\n  var metrics = this.getMetrics();\r\n                ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1382: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.setTopLevelWorkspaceMetrics_\r\n    this.scrollX = -metrics.contentWidth * xyRatio.x - metrics.contentLeft;\r\n    ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1385: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.setTopLevelWorkspaceMetrics_\r\n    this.scrollY = -metrics.contentHeight * xyRatio.y - metrics.contentTop;\r\n    ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1387: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.setTopLevelWorkspaceMetrics_\r\n  var x = this.scrollX + metrics.absoluteLeft;\r\n          ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1388: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.setTopLevelWorkspaceMetrics_\r\n  var y = this.scrollY + metrics.absoluteTop;\r\n          ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1389: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.setTopLevelWorkspaceMetrics_\r\n  this.translate(x, y);\r\n  ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1390: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.setTopLevelWorkspaceMetrics_\r\n  if (this.options.gridPattern) {\r\n      ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1391: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.setTopLevelWorkspaceMetrics_\r\n    this.options.gridPattern.setAttribute('x', x);\r\n    ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1392: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.setTopLevelWorkspaceMetrics_\r\n    this.options.gridPattern.setAttribute('y', y);\r\n    ^\r\n\r\nappengine/third-party/blockly/core/workspace_svg.js:1395: WARNING - dangerous use of this in static method Blockly.WorkspaceSvg.setTopLevelWorkspaceMetrics_\r\n      this.updateGridPattern_();\r\n      ^\r\n\r\n42 warning(s)"}}
{"actor":{"display_login":"NeilFraser"}}