{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/93334136","pull_request_review_id":13859722,"id":93334136,"diff_hunk":"@@ -0,0 +1,140 @@\n+# Kubernetes DNS-Based Service Discovery\n+\n+## About This Document\n+\n+This document describes a DNS schema for DNS-based Kubernetes service\n+discovery. While service discovery in Kubernetes may be provided via\n+other protocols and mechanisms, DNS is very commonly used and is a\n+highly recommended add-on. The actual DNS service itself though need not\n+be provided by the default Kube-DNS implementation, and so this document\n+is intended to provide a baseline for commonality between\n+implementations.\n+\n+## Schema Version\n+\n+This document describes version 1.0.0 of the schema.\n+\n+## Query Responses","path":"cmd/kube-dns/SPEC.md","position":17,"original_position":17,"commit_id":"3703460b9920c6681effca8170fc31df8e952464","original_commit_id":"3703460b9920c6681effca8170fc31df8e952464","user":{"login":"johnbelamaric","id":9468083,"avatar_url":"https://avatars.githubusercontent.com/u/9468083?v=3","gravatar_id":"","url":"https://api.github.com/users/johnbelamaric","html_url":"https://github.com/johnbelamaric","followers_url":"https://api.github.com/users/johnbelamaric/followers","following_url":"https://api.github.com/users/johnbelamaric/following{/other_user}","gists_url":"https://api.github.com/users/johnbelamaric/gists{/gist_id}","starred_url":"https://api.github.com/users/johnbelamaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnbelamaric/subscriptions","organizations_url":"https://api.github.com/users/johnbelamaric/orgs","repos_url":"https://api.github.com/users/johnbelamaric/repos","events_url":"https://api.github.com/users/johnbelamaric/events{/privacy}","received_events_url":"https://api.github.com/users/johnbelamaric/received_events","type":"User","site_admin":false},"body":"I can do this - it's almost ready. It does change the spec a bit. For example, querying for SRV without _port._proto will no longer return anything (at least, not according to the spec). Assuming we are OK with that sort of change, then I think this makes sense.","created_at":"2016-12-20T21:57:31Z","updated_at":"2016-12-20T21:57:31Z","html_url":"https://github.com/kubernetes/kubernetes/pull/38408#discussion_r93334136","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38408","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/93334136"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/38408#discussion_r93334136"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38408"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38408","id":97192179,"html_url":"https://github.com/kubernetes/kubernetes/pull/38408","diff_url":"https://github.com/kubernetes/kubernetes/pull/38408.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/38408.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/38408","number":38408,"state":"open","locked":false,"title":"Add DNS-schema Specification","user":{"login":"johnbelamaric","id":9468083,"avatar_url":"https://avatars.githubusercontent.com/u/9468083?v=3","gravatar_id":"","url":"https://api.github.com/users/johnbelamaric","html_url":"https://github.com/johnbelamaric","followers_url":"https://api.github.com/users/johnbelamaric/followers","following_url":"https://api.github.com/users/johnbelamaric/following{/other_user}","gists_url":"https://api.github.com/users/johnbelamaric/gists{/gist_id}","starred_url":"https://api.github.com/users/johnbelamaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnbelamaric/subscriptions","organizations_url":"https://api.github.com/users/johnbelamaric/orgs","repos_url":"https://api.github.com/users/johnbelamaric/repos","events_url":"https://api.github.com/users/johnbelamaric/events{/privacy}","received_events_url":"https://api.github.com/users/johnbelamaric/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md\r\n2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md\r\n3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nThis PR establishes an explicit baseline DNS schema for Kubernetes. Currently, this information is contained in a few places in the documentation. This PR gathers this into one place and adds additional, explicit detail to what the supported queries and expected responses are. The intention is to provide a common schema that different DNS service discovery implementations can implement.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: None\r\n\r\n**Special notes for your reviewer**:\r\nThis started life here https://docs.google.com/document/d/1B4ZA1HwprWMzyT7nUZLAZ93Fjwcdt9qs0aXfifKxpTs/edit# but this PR is the result. Currently kube-dns does not support this schema 100%. There are a few items in here that are not yet in kube-dns. I will add comments to them on the PR. This makes the spec more aspirational than current. We may want to note that directly in the spec until kube-dns fully meets it (or change the spec, of course).\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access) \r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. \r\n-->\r\n```NONE\r\n```","created_at":"2016-12-08T20:12:50Z","updated_at":"2016-12-20T21:57:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d4aa58535148b1d2f0539f9eb91b9ba3f59a142","assignee":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"assignees":[{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38408/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38408/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/38408/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/3703460b9920c6681effca8170fc31df8e952464","head":{"label":"johnbelamaric:dns-spec","ref":"dns-spec","sha":"3703460b9920c6681effca8170fc31df8e952464","user":{"login":"johnbelamaric","id":9468083,"avatar_url":"https://avatars.githubusercontent.com/u/9468083?v=3","gravatar_id":"","url":"https://api.github.com/users/johnbelamaric","html_url":"https://github.com/johnbelamaric","followers_url":"https://api.github.com/users/johnbelamaric/followers","following_url":"https://api.github.com/users/johnbelamaric/following{/other_user}","gists_url":"https://api.github.com/users/johnbelamaric/gists{/gist_id}","starred_url":"https://api.github.com/users/johnbelamaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnbelamaric/subscriptions","organizations_url":"https://api.github.com/users/johnbelamaric/orgs","repos_url":"https://api.github.com/users/johnbelamaric/repos","events_url":"https://api.github.com/users/johnbelamaric/events{/privacy}","received_events_url":"https://api.github.com/users/johnbelamaric/received_events","type":"User","site_admin":false},"repo":{"id":75958696,"name":"kubernetes","full_name":"johnbelamaric/kubernetes","owner":{"login":"johnbelamaric","id":9468083,"avatar_url":"https://avatars.githubusercontent.com/u/9468083?v=3","gravatar_id":"","url":"https://api.github.com/users/johnbelamaric","html_url":"https://github.com/johnbelamaric","followers_url":"https://api.github.com/users/johnbelamaric/followers","following_url":"https://api.github.com/users/johnbelamaric/following{/other_user}","gists_url":"https://api.github.com/users/johnbelamaric/gists{/gist_id}","starred_url":"https://api.github.com/users/johnbelamaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnbelamaric/subscriptions","organizations_url":"https://api.github.com/users/johnbelamaric/orgs","repos_url":"https://api.github.com/users/johnbelamaric/repos","events_url":"https://api.github.com/users/johnbelamaric/events{/privacy}","received_events_url":"https://api.github.com/users/johnbelamaric/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnbelamaric/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/johnbelamaric/kubernetes","forks_url":"https://api.github.com/repos/johnbelamaric/kubernetes/forks","keys_url":"https://api.github.com/repos/johnbelamaric/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnbelamaric/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnbelamaric/kubernetes/teams","hooks_url":"https://api.github.com/repos/johnbelamaric/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/johnbelamaric/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/johnbelamaric/kubernetes/events","assignees_url":"https://api.github.com/repos/johnbelamaric/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/johnbelamaric/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/johnbelamaric/kubernetes/tags","blobs_url":"https://api.github.com/repos/johnbelamaric/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnbelamaric/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnbelamaric/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnbelamaric/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnbelamaric/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/johnbelamaric/kubernetes/languages","stargazers_url":"https://api.github.com/repos/johnbelamaric/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/johnbelamaric/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/johnbelamaric/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/johnbelamaric/kubernetes/subscription","commits_url":"https://api.github.com/repos/johnbelamaric/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnbelamaric/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnbelamaric/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnbelamaric/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnbelamaric/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/johnbelamaric/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnbelamaric/kubernetes/merges","archive_url":"https://api.github.com/repos/johnbelamaric/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnbelamaric/kubernetes/downloads","issues_url":"https://api.github.com/repos/johnbelamaric/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/johnbelamaric/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/johnbelamaric/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/johnbelamaric/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnbelamaric/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/johnbelamaric/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/johnbelamaric/kubernetes/deployments","created_at":"2016-12-08T17:12:13Z","updated_at":"2016-12-08T17:12:53Z","pushed_at":"2016-12-14T20:32:32Z","git_url":"git://github.com/johnbelamaric/kubernetes.git","ssh_url":"git@github.com:johnbelamaric/kubernetes.git","clone_url":"https://github.com/johnbelamaric/kubernetes.git","svn_url":"https://github.com/johnbelamaric/kubernetes","homepage":"http://kubernetes.io","size":365179,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"407d8b7c190aef1e1774beb21fa1f5e67e13e40d","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-12-20T21:51:57Z","pushed_at":"2016-12-20T21:54:31Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":479331,"stargazers_count":19371,"watchers_count":19371,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6481,"mirror_url":null,"open_issues_count":5437,"forks":6481,"open_issues":5437,"watchers":19371,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38408"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/38408"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/38408"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/38408/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38408/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38408/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/3703460b9920c6681effca8170fc31df8e952464"}}}}
{"actor":{"display_login":"johnbelamaric"}}