{"action":"created","comment":{"url":"https://api.github.com/repos/sfackler/rust-openssl/pulls/comments/51638934","id":51638934,"diff_hunk":"@@ -104,7 +104,7 @@ pub enum Nid {\n     G,\n     S,\n     I,\n-    UID,\n+    uid, // uniqueIdentifier","path":"openssl/src/nid.rs","position":5,"original_position":5,"commit_id":"4940ca7e9292ab04f473ebb017272a50b0d79fbc","original_commit_id":"4940ca7e9292ab04f473ebb017272a50b0d79fbc","user":{"login":"sfackler","id":1455697,"avatar_url":"https://avatars.githubusercontent.com/u/1455697?v=3","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false},"body":"It might be better to rename this to `UniqueIdentifier`?","created_at":"2016-02-02T21:33:37Z","updated_at":"2016-02-02T21:33:37Z","html_url":"https://github.com/sfackler/rust-openssl/pull/349#discussion_r51638934","pull_request_url":"https://api.github.com/repos/sfackler/rust-openssl/pulls/349","_links":{"self":{"href":"https://api.github.com/repos/sfackler/rust-openssl/pulls/comments/51638934"},"html":{"href":"https://github.com/sfackler/rust-openssl/pull/349#discussion_r51638934"},"pull_request":{"href":"https://api.github.com/repos/sfackler/rust-openssl/pulls/349"}}},"pull_request":{"url":"https://api.github.com/repos/sfackler/rust-openssl/pulls/349","id":58021566,"html_url":"https://github.com/sfackler/rust-openssl/pull/349","diff_url":"https://github.com/sfackler/rust-openssl/pull/349.diff","patch_url":"https://github.com/sfackler/rust-openssl/pull/349.patch","issue_url":"https://api.github.com/repos/sfackler/rust-openssl/issues/349","number":349,"state":"open","locked":false,"title":"Fix Nid::UID value","user":{"login":"jwilm","id":4285147,"avatar_url":"https://avatars.githubusercontent.com/u/4285147?v=3","gravatar_id":"","url":"https://api.github.com/users/jwilm","html_url":"https://github.com/jwilm","followers_url":"https://api.github.com/users/jwilm/followers","following_url":"https://api.github.com/users/jwilm/following{/other_user}","gists_url":"https://api.github.com/users/jwilm/gists{/gist_id}","starred_url":"https://api.github.com/users/jwilm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwilm/subscriptions","organizations_url":"https://api.github.com/users/jwilm/orgs","repos_url":"https://api.github.com/users/jwilm/repos","events_url":"https://api.github.com/users/jwilm/events{/privacy}","received_events_url":"https://api.github.com/users/jwilm/received_events","type":"User","site_admin":false},"body":"`Nid::UID` (userId) previously held the value of `Nid::uid` (uniqueIdentifier).\r\n\r\nI think the NID values were potentially taken from the wrong list in openssl. There's an [old open PR](https://github.com/sfackler/rust-openssl/pull/84) on here that mentioned reading them from `include/openssl/objects.h`, but that list doesn't contain all nid values, and they conflict (mildly) with the list in `include/openssl/obj_mac.h`. This being the [second PR](https://github.com/sfackler/rust-openssl/pull/232) to correct some NID values seems to support this claim.","created_at":"2016-02-02T17:35:00Z","updated_at":"2016-02-02T21:33:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6063e49bbaaa48a9c55d3f2a5fe5bb81f24a4b0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sfackler/rust-openssl/pulls/349/commits","review_comments_url":"https://api.github.com/repos/sfackler/rust-openssl/pulls/349/comments","review_comment_url":"https://api.github.com/repos/sfackler/rust-openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sfackler/rust-openssl/issues/349/comments","statuses_url":"https://api.github.com/repos/sfackler/rust-openssl/statuses/4940ca7e9292ab04f473ebb017272a50b0d79fbc","head":{"label":"jwilm:fix-UID-nid-value","ref":"fix-UID-nid-value","sha":"4940ca7e9292ab04f473ebb017272a50b0d79fbc","user":{"login":"jwilm","id":4285147,"avatar_url":"https://avatars.githubusercontent.com/u/4285147?v=3","gravatar_id":"","url":"https://api.github.com/users/jwilm","html_url":"https://github.com/jwilm","followers_url":"https://api.github.com/users/jwilm/followers","following_url":"https://api.github.com/users/jwilm/following{/other_user}","gists_url":"https://api.github.com/users/jwilm/gists{/gist_id}","starred_url":"https://api.github.com/users/jwilm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwilm/subscriptions","organizations_url":"https://api.github.com/users/jwilm/orgs","repos_url":"https://api.github.com/users/jwilm/repos","events_url":"https://api.github.com/users/jwilm/events{/privacy}","received_events_url":"https://api.github.com/users/jwilm/received_events","type":"User","site_admin":false},"repo":{"id":50938196,"name":"rust-openssl","full_name":"jwilm/rust-openssl","owner":{"login":"jwilm","id":4285147,"avatar_url":"https://avatars.githubusercontent.com/u/4285147?v=3","gravatar_id":"","url":"https://api.github.com/users/jwilm","html_url":"https://github.com/jwilm","followers_url":"https://api.github.com/users/jwilm/followers","following_url":"https://api.github.com/users/jwilm/following{/other_user}","gists_url":"https://api.github.com/users/jwilm/gists{/gist_id}","starred_url":"https://api.github.com/users/jwilm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwilm/subscriptions","organizations_url":"https://api.github.com/users/jwilm/orgs","repos_url":"https://api.github.com/users/jwilm/repos","events_url":"https://api.github.com/users/jwilm/events{/privacy}","received_events_url":"https://api.github.com/users/jwilm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jwilm/rust-openssl","description":"OpenSSL bindings for Rust","fork":true,"url":"https://api.github.com/repos/jwilm/rust-openssl","forks_url":"https://api.github.com/repos/jwilm/rust-openssl/forks","keys_url":"https://api.github.com/repos/jwilm/rust-openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwilm/rust-openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwilm/rust-openssl/teams","hooks_url":"https://api.github.com/repos/jwilm/rust-openssl/hooks","issue_events_url":"https://api.github.com/repos/jwilm/rust-openssl/issues/events{/number}","events_url":"https://api.github.com/repos/jwilm/rust-openssl/events","assignees_url":"https://api.github.com/repos/jwilm/rust-openssl/assignees{/user}","branches_url":"https://api.github.com/repos/jwilm/rust-openssl/branches{/branch}","tags_url":"https://api.github.com/repos/jwilm/rust-openssl/tags","blobs_url":"https://api.github.com/repos/jwilm/rust-openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwilm/rust-openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwilm/rust-openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwilm/rust-openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwilm/rust-openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/jwilm/rust-openssl/languages","stargazers_url":"https://api.github.com/repos/jwilm/rust-openssl/stargazers","contributors_url":"https://api.github.com/repos/jwilm/rust-openssl/contributors","subscribers_url":"https://api.github.com/repos/jwilm/rust-openssl/subscribers","subscription_url":"https://api.github.com/repos/jwilm/rust-openssl/subscription","commits_url":"https://api.github.com/repos/jwilm/rust-openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwilm/rust-openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwilm/rust-openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwilm/rust-openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwilm/rust-openssl/contents/{+path}","compare_url":"https://api.github.com/repos/jwilm/rust-openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwilm/rust-openssl/merges","archive_url":"https://api.github.com/repos/jwilm/rust-openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwilm/rust-openssl/downloads","issues_url":"https://api.github.com/repos/jwilm/rust-openssl/issues{/number}","pulls_url":"https://api.github.com/repos/jwilm/rust-openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/jwilm/rust-openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/jwilm/rust-openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwilm/rust-openssl/labels{/name}","releases_url":"https://api.github.com/repos/jwilm/rust-openssl/releases{/id}","deployments_url":"https://api.github.com/repos/jwilm/rust-openssl/deployments","created_at":"2016-02-02T17:26:57Z","updated_at":"2016-02-02T17:26:58Z","pushed_at":"2016-02-02T17:27:17Z","git_url":"git://github.com/jwilm/rust-openssl.git","ssh_url":"git@github.com:jwilm/rust-openssl.git","clone_url":"https://github.com/jwilm/rust-openssl.git","svn_url":"https://github.com/jwilm/rust-openssl","homepage":"","size":8119,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sfackler:master","ref":"master","sha":"21b331a72e0380a36ffd399e8d5abc5d9e6ec128","user":{"login":"sfackler","id":1455697,"avatar_url":"https://avatars.githubusercontent.com/u/1455697?v=3","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false},"repo":{"id":15500883,"name":"rust-openssl","full_name":"sfackler/rust-openssl","owner":{"login":"sfackler","id":1455697,"avatar_url":"https://avatars.githubusercontent.com/u/1455697?v=3","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sfackler/rust-openssl","description":"OpenSSL bindings for Rust","fork":false,"url":"https://api.github.com/repos/sfackler/rust-openssl","forks_url":"https://api.github.com/repos/sfackler/rust-openssl/forks","keys_url":"https://api.github.com/repos/sfackler/rust-openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sfackler/rust-openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sfackler/rust-openssl/teams","hooks_url":"https://api.github.com/repos/sfackler/rust-openssl/hooks","issue_events_url":"https://api.github.com/repos/sfackler/rust-openssl/issues/events{/number}","events_url":"https://api.github.com/repos/sfackler/rust-openssl/events","assignees_url":"https://api.github.com/repos/sfackler/rust-openssl/assignees{/user}","branches_url":"https://api.github.com/repos/sfackler/rust-openssl/branches{/branch}","tags_url":"https://api.github.com/repos/sfackler/rust-openssl/tags","blobs_url":"https://api.github.com/repos/sfackler/rust-openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sfackler/rust-openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sfackler/rust-openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/sfackler/rust-openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sfackler/rust-openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/sfackler/rust-openssl/languages","stargazers_url":"https://api.github.com/repos/sfackler/rust-openssl/stargazers","contributors_url":"https://api.github.com/repos/sfackler/rust-openssl/contributors","subscribers_url":"https://api.github.com/repos/sfackler/rust-openssl/subscribers","subscription_url":"https://api.github.com/repos/sfackler/rust-openssl/subscription","commits_url":"https://api.github.com/repos/sfackler/rust-openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/sfackler/rust-openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/sfackler/rust-openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/sfackler/rust-openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/sfackler/rust-openssl/contents/{+path}","compare_url":"https://api.github.com/repos/sfackler/rust-openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sfackler/rust-openssl/merges","archive_url":"https://api.github.com/repos/sfackler/rust-openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sfackler/rust-openssl/downloads","issues_url":"https://api.github.com/repos/sfackler/rust-openssl/issues{/number}","pulls_url":"https://api.github.com/repos/sfackler/rust-openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/sfackler/rust-openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/sfackler/rust-openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sfackler/rust-openssl/labels{/name}","releases_url":"https://api.github.com/repos/sfackler/rust-openssl/releases{/id}","deployments_url":"https://api.github.com/repos/sfackler/rust-openssl/deployments","created_at":"2013-12-28T23:56:50Z","updated_at":"2016-02-02T07:36:04Z","pushed_at":"2016-02-02T17:35:01Z","git_url":"git://github.com/sfackler/rust-openssl.git","ssh_url":"git@github.com:sfackler/rust-openssl.git","clone_url":"https://github.com/sfackler/rust-openssl.git","svn_url":"https://github.com/sfackler/rust-openssl","homepage":"","size":8348,"stargazers_count":147,"watchers_count":147,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":112,"mirror_url":null,"open_issues_count":31,"forks":112,"open_issues":31,"watchers":147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sfackler/rust-openssl/pulls/349"},"html":{"href":"https://github.com/sfackler/rust-openssl/pull/349"},"issue":{"href":"https://api.github.com/repos/sfackler/rust-openssl/issues/349"},"comments":{"href":"https://api.github.com/repos/sfackler/rust-openssl/issues/349/comments"},"review_comments":{"href":"https://api.github.com/repos/sfackler/rust-openssl/pulls/349/comments"},"review_comment":{"href":"https://api.github.com/repos/sfackler/rust-openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sfackler/rust-openssl/pulls/349/commits"},"statuses":{"href":"https://api.github.com/repos/sfackler/rust-openssl/statuses/4940ca7e9292ab04f473ebb017272a50b0d79fbc"}}}}