{"action":"created","issue":{"url":"https://api.github.com/repos/usbong/UsbongKit/issues/16","repository_url":"https://api.github.com/repos/usbong/UsbongKit","labels_url":"https://api.github.com/repos/usbong/UsbongKit/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/usbong/UsbongKit/issues/16/comments","events_url":"https://api.github.com/repos/usbong/UsbongKit/issues/16/events","html_url":"https://github.com/usbong/UsbongKit/issues/16","id":187685115,"number":16,"title":"Font color of the words with hints makes the words themselves difficult to read","user":{"login":"masarapmabuhay","id":344066,"avatar_url":"https://avatars.githubusercontent.com/u/344066?v=3","gravatar_id":"","url":"https://api.github.com/users/masarapmabuhay","html_url":"https://github.com/masarapmabuhay","followers_url":"https://api.github.com/users/masarapmabuhay/followers","following_url":"https://api.github.com/users/masarapmabuhay/following{/other_user}","gists_url":"https://api.github.com/users/masarapmabuhay/gists{/gist_id}","starred_url":"https://api.github.com/users/masarapmabuhay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masarapmabuhay/subscriptions","organizations_url":"https://api.github.com/users/masarapmabuhay/orgs","repos_url":"https://api.github.com/users/masarapmabuhay/repos","events_url":"https://api.github.com/users/masarapmabuhay/events{/privacy}","received_events_url":"https://api.github.com/users/masarapmabuhay/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-07T11:14:48Z","updated_at":"2016-11-28T04:14:42Z","closed_at":null,"body":"Salut! I noticed that the font color of the words with hints makes the words themselves difficult to read.  However, this is not the case in PagTsing (iOS). Therefore, the code in UsbongKit seems not yet updated.\r\n\r\n1) UsbongKit\r\n![2016-11-07 11 38 37](https://cloud.githubusercontent.com/assets/344066/20055829/06165344-a51e-11e6-83a3-7af96d2ab1ee.png)\r\n\r\n2) PagTsing\r\n![2016-11-07 11 36 50](https://cloud.githubusercontent.com/assets/344066/20055834/0ff78630-a51e-11e6-9ef4-e9d371aa20cb.png)\r\n\r\nMerci beaucoup!\r\np.s. incidentally, the .utree of PagTsing (iOS) is not updated as well, because not all words have their definitions."},"comment":{"url":"https://api.github.com/repos/usbong/UsbongKit/issues/comments/263180024","html_url":"https://github.com/usbong/UsbongKit/issues/16#issuecomment-263180024","issue_url":"https://api.github.com/repos/usbong/UsbongKit/issues/16","id":263180024,"user":{"login":"chrisamanse","id":12277586,"avatar_url":"https://avatars.githubusercontent.com/u/12277586?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisamanse","html_url":"https://github.com/chrisamanse","followers_url":"https://api.github.com/users/chrisamanse/followers","following_url":"https://api.github.com/users/chrisamanse/following{/other_user}","gists_url":"https://api.github.com/users/chrisamanse/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisamanse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisamanse/subscriptions","organizations_url":"https://api.github.com/users/chrisamanse/orgs","repos_url":"https://api.github.com/users/chrisamanse/repos","events_url":"https://api.github.com/users/chrisamanse/events{/privacy}","received_events_url":"https://api.github.com/users/chrisamanse/received_events","type":"User","site_admin":false},"created_at":"2016-11-28T04:14:42Z","updated_at":"2016-11-28T04:14:42Z","body":"For PagTsing iOS, I manually set the property to dark grey color:\r\n\r\n```\r\nnodeView.hintsColor = .darkGrayColor()\r\n```\r\n\r\nThis is possible when creating a custom view controller, but this is proven to be too tedious, which is why I created the API to present a default view controller:\r\n\r\n```swift\r\npresentViewer(onViewController viewController: UIViewController, withUtreeURL url: NSURL, andData data: UsbongTreeData = UsbongTreeData()) {\r\n```\r\n\r\nUnfortunately, this leaves us with less customizability. I've thought of a solution to make this more customizable by having a data structure `UsbongViewer`, where we can set any property we want to customize:\r\n\r\n``` swift\r\nlet usbongViewer = UsbongViewer(url: treeURL)\r\n\r\n// Set properties\r\nusbongViewer.bundles = [] // Pass in In-App Purchase bundles\r\nusbongViewer.defaultBackgroundImage = myImage\r\nusbongViewer.hintsColor = .darkGrayColor()\r\n\r\nusbongViewer.present(on: self) // Present utree on top of current view controller\r\n```\r\n\r\nThis proposal is found in issue #6.\r\n"}}
{"actor":{"display_login":"chrisamanse"}}