{"action":"created","comment":{"url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments/89140900","pull_request_review_id":9686916,"id":89140900,"diff_hunk":"@@ -0,0 +1,198 @@\n+/**\n+ * Copyright (c) 2014-2016 by the respective copyright holders.\n+ *\n+ * All rights reserved. This program and the accompanying materials\n+ * are made available under the terms of the Eclipse Public License v1.0\n+ * which accompanies this distribution, and is available at\n+ * http://www.eclipse.org/legal/epl-v10.html\n+ */\n+\n+package org.openhab.binding.onkyo.handler;\n+\n+import java.util.HashMap;\n+import java.util.HashSet;\n+import java.util.Locale;\n+import java.util.Map;\n+import java.util.Set;\n+\n+import org.eclipse.smarthome.core.audio.AudioFormat;\n+import org.eclipse.smarthome.core.audio.AudioHTTPServer;\n+import org.eclipse.smarthome.core.audio.AudioSink;\n+import org.eclipse.smarthome.core.audio.AudioStream;\n+import org.eclipse.smarthome.core.audio.URLAudioStream;\n+import org.eclipse.smarthome.core.audio.UnsupportedAudioFormatException;\n+import org.eclipse.smarthome.core.library.types.StringType;\n+import org.eclipse.smarthome.core.thing.Thing;\n+import org.eclipse.smarthome.core.thing.binding.BaseThingHandler;\n+import org.eclipse.smarthome.core.types.Command;\n+import org.eclipse.smarthome.io.transport.upnp.UpnpIOParticipant;\n+import org.eclipse.smarthome.io.transport.upnp.UpnpIOService;\n+import org.openhab.binding.onkyo.OnkyoBindingConstants;\n+import org.slf4j.Logger;\n+import org.slf4j.LoggerFactory;\n+\n+public abstract class UpnpAudioSinkHandler extends BaseThingHandler implements AudioSink, UpnpIOParticipant {","path":"addons/binding/org.openhab.binding.onkyo/src/main/java/org/openhab/binding/onkyo/handler/UpnpAudioSinkHandler.java","position":34,"original_position":34,"commit_id":"bff60ce9f8966026f59a1d26b33336a89b98306c","original_commit_id":"bff60ce9f8966026f59a1d26b33336a89b98306c","user":{"login":"kaikreuzer","id":3244965,"avatar_url":"https://avatars.githubusercontent.com/u/3244965?v=3","gravatar_id":"","url":"https://api.github.com/users/kaikreuzer","html_url":"https://github.com/kaikreuzer","followers_url":"https://api.github.com/users/kaikreuzer/followers","following_url":"https://api.github.com/users/kaikreuzer/following{/other_user}","gists_url":"https://api.github.com/users/kaikreuzer/gists{/gist_id}","starred_url":"https://api.github.com/users/kaikreuzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaikreuzer/subscriptions","organizations_url":"https://api.github.com/users/kaikreuzer/orgs","repos_url":"https://api.github.com/users/kaikreuzer/repos","events_url":"https://api.github.com/users/kaikreuzer/events{/privacy}","received_events_url":"https://api.github.com/users/kaikreuzer/received_events","type":"User","site_admin":false},"body":"Please add some JavaDoc.\r\n\r\nThe name of the class seems to suggest that it is not at all Onkyo specific. Should we consider moving it somewhere to the framework, so that others can use it? See also the discussion at https://github.com/eclipse/smarthome/issues/2475.","created_at":"2016-11-22T15:33:45Z","updated_at":"2016-11-22T15:37:50Z","html_url":"https://github.com/openhab/openhab2-addons/pull/1431#discussion_r89140900","pull_request_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/1431","_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments/89140900"},"html":{"href":"https://github.com/openhab/openhab2-addons/pull/1431#discussion_r89140900"},"pull_request":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/1431"}}},"pull_request":{"url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/1431","id":94036426,"html_url":"https://github.com/openhab/openhab2-addons/pull/1431","diff_url":"https://github.com/openhab/openhab2-addons/pull/1431.diff","patch_url":"https://github.com/openhab/openhab2-addons/pull/1431.patch","issue_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/1431","number":1431,"state":"open","locked":false,"title":"[onkyo] Implement AudioSink for Onkyo Receivers","user":{"login":"pail23","id":13279715,"avatar_url":"https://avatars.githubusercontent.com/u/13279715?v=3","gravatar_id":"","url":"https://api.github.com/users/pail23","html_url":"https://github.com/pail23","followers_url":"https://api.github.com/users/pail23/followers","following_url":"https://api.github.com/users/pail23/following{/other_user}","gists_url":"https://api.github.com/users/pail23/gists{/gist_id}","starred_url":"https://api.github.com/users/pail23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pail23/subscriptions","organizations_url":"https://api.github.com/users/pail23/orgs","repos_url":"https://api.github.com/users/pail23/repos","events_url":"https://api.github.com/users/pail23/events{/privacy}","received_events_url":"https://api.github.com/users/pail23/received_events","type":"User","site_admin":false},"body":"Implements the AudioSink interface for Onkyo receivers. This allows to play Audio Files on the receiver by calling  e.g. playStream in rule.\r\n\r\nSigned-off-by: Paul Frank <pail@gmx.net>","created_at":"2016-11-16T19:47:01Z","updated_at":"2016-11-22T15:37:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b22c44ef9ee3da5d0b8ee450edeec3266518f2a6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/1431/commits","review_comments_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/1431/comments","review_comment_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/1431/comments","statuses_url":"https://api.github.com/repos/openhab/openhab2-addons/statuses/bff60ce9f8966026f59a1d26b33336a89b98306c","head":{"label":"pail23:onkyoaudiosink","ref":"onkyoaudiosink","sha":"bff60ce9f8966026f59a1d26b33336a89b98306c","user":{"login":"pail23","id":13279715,"avatar_url":"https://avatars.githubusercontent.com/u/13279715?v=3","gravatar_id":"","url":"https://api.github.com/users/pail23","html_url":"https://github.com/pail23","followers_url":"https://api.github.com/users/pail23/followers","following_url":"https://api.github.com/users/pail23/following{/other_user}","gists_url":"https://api.github.com/users/pail23/gists{/gist_id}","starred_url":"https://api.github.com/users/pail23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pail23/subscriptions","organizations_url":"https://api.github.com/users/pail23/orgs","repos_url":"https://api.github.com/users/pail23/repos","events_url":"https://api.github.com/users/pail23/events{/privacy}","received_events_url":"https://api.github.com/users/pail23/received_events","type":"User","site_admin":false},"repo":{"id":69283618,"name":"openhab2-addons","full_name":"pail23/openhab2-addons","owner":{"login":"pail23","id":13279715,"avatar_url":"https://avatars.githubusercontent.com/u/13279715?v=3","gravatar_id":"","url":"https://api.github.com/users/pail23","html_url":"https://github.com/pail23","followers_url":"https://api.github.com/users/pail23/followers","following_url":"https://api.github.com/users/pail23/following{/other_user}","gists_url":"https://api.github.com/users/pail23/gists{/gist_id}","starred_url":"https://api.github.com/users/pail23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pail23/subscriptions","organizations_url":"https://api.github.com/users/pail23/orgs","repos_url":"https://api.github.com/users/pail23/repos","events_url":"https://api.github.com/users/pail23/events{/privacy}","received_events_url":"https://api.github.com/users/pail23/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pail23/openhab2-addons","description":"The next-generation open Home Automation Bus (openHAB)","fork":true,"url":"https://api.github.com/repos/pail23/openhab2-addons","forks_url":"https://api.github.com/repos/pail23/openhab2-addons/forks","keys_url":"https://api.github.com/repos/pail23/openhab2-addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pail23/openhab2-addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pail23/openhab2-addons/teams","hooks_url":"https://api.github.com/repos/pail23/openhab2-addons/hooks","issue_events_url":"https://api.github.com/repos/pail23/openhab2-addons/issues/events{/number}","events_url":"https://api.github.com/repos/pail23/openhab2-addons/events","assignees_url":"https://api.github.com/repos/pail23/openhab2-addons/assignees{/user}","branches_url":"https://api.github.com/repos/pail23/openhab2-addons/branches{/branch}","tags_url":"https://api.github.com/repos/pail23/openhab2-addons/tags","blobs_url":"https://api.github.com/repos/pail23/openhab2-addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pail23/openhab2-addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pail23/openhab2-addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/pail23/openhab2-addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pail23/openhab2-addons/statuses/{sha}","languages_url":"https://api.github.com/repos/pail23/openhab2-addons/languages","stargazers_url":"https://api.github.com/repos/pail23/openhab2-addons/stargazers","contributors_url":"https://api.github.com/repos/pail23/openhab2-addons/contributors","subscribers_url":"https://api.github.com/repos/pail23/openhab2-addons/subscribers","subscription_url":"https://api.github.com/repos/pail23/openhab2-addons/subscription","commits_url":"https://api.github.com/repos/pail23/openhab2-addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/pail23/openhab2-addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/pail23/openhab2-addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/pail23/openhab2-addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/pail23/openhab2-addons/contents/{+path}","compare_url":"https://api.github.com/repos/pail23/openhab2-addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pail23/openhab2-addons/merges","archive_url":"https://api.github.com/repos/pail23/openhab2-addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pail23/openhab2-addons/downloads","issues_url":"https://api.github.com/repos/pail23/openhab2-addons/issues{/number}","pulls_url":"https://api.github.com/repos/pail23/openhab2-addons/pulls{/number}","milestones_url":"https://api.github.com/repos/pail23/openhab2-addons/milestones{/number}","notifications_url":"https://api.github.com/repos/pail23/openhab2-addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pail23/openhab2-addons/labels{/name}","releases_url":"https://api.github.com/repos/pail23/openhab2-addons/releases{/id}","deployments_url":"https://api.github.com/repos/pail23/openhab2-addons/deployments","created_at":"2016-09-26T19:07:56Z","updated_at":"2016-09-26T19:08:01Z","pushed_at":"2016-11-16T19:43:05Z","git_url":"git://github.com/pail23/openhab2-addons.git","ssh_url":"git@github.com:pail23/openhab2-addons.git","clone_url":"https://github.com/pail23/openhab2-addons.git","svn_url":"https://github.com/pail23/openhab2-addons","homepage":null,"size":52614,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openhab:master","ref":"master","sha":"f83ff68127a78b4dafb15dc792d9712b43b8c1f1","user":{"login":"openhab","id":1007353,"avatar_url":"https://avatars.githubusercontent.com/u/1007353?v=3","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"repo":{"id":19753195,"name":"openhab2-addons","full_name":"openhab/openhab2-addons","owner":{"login":"openhab","id":1007353,"avatar_url":"https://avatars.githubusercontent.com/u/1007353?v=3","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openhab/openhab2-addons","description":"The next-generation open Home Automation Bus (openHAB)","fork":false,"url":"https://api.github.com/repos/openhab/openhab2-addons","forks_url":"https://api.github.com/repos/openhab/openhab2-addons/forks","keys_url":"https://api.github.com/repos/openhab/openhab2-addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openhab/openhab2-addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openhab/openhab2-addons/teams","hooks_url":"https://api.github.com/repos/openhab/openhab2-addons/hooks","issue_events_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/events{/number}","events_url":"https://api.github.com/repos/openhab/openhab2-addons/events","assignees_url":"https://api.github.com/repos/openhab/openhab2-addons/assignees{/user}","branches_url":"https://api.github.com/repos/openhab/openhab2-addons/branches{/branch}","tags_url":"https://api.github.com/repos/openhab/openhab2-addons/tags","blobs_url":"https://api.github.com/repos/openhab/openhab2-addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openhab/openhab2-addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openhab/openhab2-addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/openhab/openhab2-addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openhab/openhab2-addons/statuses/{sha}","languages_url":"https://api.github.com/repos/openhab/openhab2-addons/languages","stargazers_url":"https://api.github.com/repos/openhab/openhab2-addons/stargazers","contributors_url":"https://api.github.com/repos/openhab/openhab2-addons/contributors","subscribers_url":"https://api.github.com/repos/openhab/openhab2-addons/subscribers","subscription_url":"https://api.github.com/repos/openhab/openhab2-addons/subscription","commits_url":"https://api.github.com/repos/openhab/openhab2-addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/openhab/openhab2-addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/openhab/openhab2-addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/openhab/openhab2-addons/contents/{+path}","compare_url":"https://api.github.com/repos/openhab/openhab2-addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openhab/openhab2-addons/merges","archive_url":"https://api.github.com/repos/openhab/openhab2-addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openhab/openhab2-addons/downloads","issues_url":"https://api.github.com/repos/openhab/openhab2-addons/issues{/number}","pulls_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls{/number}","milestones_url":"https://api.github.com/repos/openhab/openhab2-addons/milestones{/number}","notifications_url":"https://api.github.com/repos/openhab/openhab2-addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openhab/openhab2-addons/labels{/name}","releases_url":"https://api.github.com/repos/openhab/openhab2-addons/releases{/id}","deployments_url":"https://api.github.com/repos/openhab/openhab2-addons/deployments","created_at":"2014-05-13T19:41:58Z","updated_at":"2016-11-21T15:39:21Z","pushed_at":"2016-11-22T10:10:13Z","git_url":"git://github.com/openhab/openhab2-addons.git","ssh_url":"git@github.com:openhab/openhab2-addons.git","clone_url":"https://github.com/openhab/openhab2-addons.git","svn_url":"https://github.com/openhab/openhab2-addons","homepage":null,"size":198912,"stargazers_count":434,"watchers_count":434,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":696,"mirror_url":null,"open_issues_count":149,"forks":696,"open_issues":149,"watchers":434,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/1431"},"html":{"href":"https://github.com/openhab/openhab2-addons/pull/1431"},"issue":{"href":"https://api.github.com/repos/openhab/openhab2-addons/issues/1431"},"comments":{"href":"https://api.github.com/repos/openhab/openhab2-addons/issues/1431/comments"},"review_comments":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/1431/comments"},"review_comment":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/1431/commits"},"statuses":{"href":"https://api.github.com/repos/openhab/openhab2-addons/statuses/bff60ce9f8966026f59a1d26b33336a89b98306c"}}}}
{"actor":{"display_login":"kaikreuzer"}}