{"action":"created","comment":{"url":"https://api.github.com/repos/errbotio/errbot/pulls/comments/48905692","id":48905692,"diff_hunk":"@@ -33,12 +33,15 @@ def callback_connect(self):\n                     self.log.exception(\"Joining room %s failed\", repr(room))\n \n     def _join_room(self, room):\n-        room_name = compat_str(room)\n-        if room_name is not None:\n-            room, username, password = (room_name, self.bot_config.CHATROOM_FN, None)\n+        if isinstance(room, tuple):","path":"errbot/core_plugins/chatRoom.py","position":7,"original_position":7,"commit_id":"5a9798b366905da07045aad6e299e17fddb83bec","original_commit_id":"5a9798b366905da07045aad6e299e17fddb83bec","user":{"login":"mslehto","id":788086,"avatar_url":"https://avatars.githubusercontent.com/u/788086?v=3","gravatar_id":"","url":"https://api.github.com/users/mslehto","html_url":"https://github.com/mslehto","followers_url":"https://api.github.com/users/mslehto/followers","following_url":"https://api.github.com/users/mslehto/following{/other_user}","gists_url":"https://api.github.com/users/mslehto/gists{/gist_id}","starred_url":"https://api.github.com/users/mslehto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mslehto/subscriptions","organizations_url":"https://api.github.com/users/mslehto/orgs","repos_url":"https://api.github.com/users/mslehto/repos","events_url":"https://api.github.com/users/mslehto/events{/privacy}","received_events_url":"https://api.github.com/users/mslehto/received_events","type":"User","site_admin":false},"body":"Ah, ok. I saw only tuples in config template so that's what I thought can ever exist:\r\nhttps://github.com/errbotio/errbot/blob/master/errbot/config-template.py#L149","created_at":"2016-01-05T22:31:17Z","updated_at":"2016-01-05T22:31:17Z","html_url":"https://github.com/errbotio/errbot/pull/578#discussion_r48905692","pull_request_url":"https://api.github.com/repos/errbotio/errbot/pulls/578","_links":{"self":{"href":"https://api.github.com/repos/errbotio/errbot/pulls/comments/48905692"},"html":{"href":"https://github.com/errbotio/errbot/pull/578#discussion_r48905692"},"pull_request":{"href":"https://api.github.com/repos/errbotio/errbot/pulls/578"}}},"pull_request":{"url":"https://api.github.com/repos/errbotio/errbot/pulls/578","id":55135327,"html_url":"https://github.com/errbotio/errbot/pull/578","diff_url":"https://github.com/errbotio/errbot/pull/578.diff","patch_url":"https://github.com/errbotio/errbot/pull/578.patch","issue_url":"https://api.github.com/repos/errbotio/errbot/issues/578","number":578,"state":"open","locked":false,"title":"Fixes join when password is set for room.","user":{"login":"mslehto","id":788086,"avatar_url":"https://avatars.githubusercontent.com/u/788086?v=3","gravatar_id":"","url":"https://api.github.com/users/mslehto","html_url":"https://github.com/mslehto","followers_url":"https://api.github.com/users/mslehto/followers","following_url":"https://api.github.com/users/mslehto/following{/other_user}","gists_url":"https://api.github.com/users/mslehto/gists{/gist_id}","starred_url":"https://api.github.com/users/mslehto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mslehto/subscriptions","organizations_url":"https://api.github.com/users/mslehto/orgs","repos_url":"https://api.github.com/users/mslehto/repos","events_url":"https://api.github.com/users/mslehto/events{/privacy}","received_events_url":"https://api.github.com/users/mslehto/received_events","type":"User","site_admin":false},"body":"_join_room() was expecting compat_str() to bail out with None.\r\nThat is not the case anymore (commit 4ed92ff24bf3c7917c9f46b88d800a144aaaaf24).\r\nTherefore room JID was junk and password enabled XMPP MUC rooms could not be joined.","created_at":"2016-01-05T19:58:05Z","updated_at":"2016-01-05T22:31:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27e987b190e86530becb459f2efd36575812116a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/errbotio/errbot/pulls/578/commits","review_comments_url":"https://api.github.com/repos/errbotio/errbot/pulls/578/comments","review_comment_url":"https://api.github.com/repos/errbotio/errbot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/errbotio/errbot/issues/578/comments","statuses_url":"https://api.github.com/repos/errbotio/errbot/statuses/5a9798b366905da07045aad6e299e17fddb83bec","head":{"label":"mslehto:mucpassword","ref":"mucpassword","sha":"5a9798b366905da07045aad6e299e17fddb83bec","user":{"login":"mslehto","id":788086,"avatar_url":"https://avatars.githubusercontent.com/u/788086?v=3","gravatar_id":"","url":"https://api.github.com/users/mslehto","html_url":"https://github.com/mslehto","followers_url":"https://api.github.com/users/mslehto/followers","following_url":"https://api.github.com/users/mslehto/following{/other_user}","gists_url":"https://api.github.com/users/mslehto/gists{/gist_id}","starred_url":"https://api.github.com/users/mslehto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mslehto/subscriptions","organizations_url":"https://api.github.com/users/mslehto/orgs","repos_url":"https://api.github.com/users/mslehto/repos","events_url":"https://api.github.com/users/mslehto/events{/privacy}","received_events_url":"https://api.github.com/users/mslehto/received_events","type":"User","site_admin":false},"repo":{"id":49085378,"name":"errbot","full_name":"mslehto/errbot","owner":{"login":"mslehto","id":788086,"avatar_url":"https://avatars.githubusercontent.com/u/788086?v=3","gravatar_id":"","url":"https://api.github.com/users/mslehto","html_url":"https://github.com/mslehto","followers_url":"https://api.github.com/users/mslehto/followers","following_url":"https://api.github.com/users/mslehto/following{/other_user}","gists_url":"https://api.github.com/users/mslehto/gists{/gist_id}","starred_url":"https://api.github.com/users/mslehto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mslehto/subscriptions","organizations_url":"https://api.github.com/users/mslehto/orgs","repos_url":"https://api.github.com/users/mslehto/repos","events_url":"https://api.github.com/users/mslehto/events{/privacy}","received_events_url":"https://api.github.com/users/mslehto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mslehto/errbot","description":"Errbot is a chatbot, a daemon that connects to your favorite chat service and bring your tools and some fun into the conversation.","fork":true,"url":"https://api.github.com/repos/mslehto/errbot","forks_url":"https://api.github.com/repos/mslehto/errbot/forks","keys_url":"https://api.github.com/repos/mslehto/errbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mslehto/errbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mslehto/errbot/teams","hooks_url":"https://api.github.com/repos/mslehto/errbot/hooks","issue_events_url":"https://api.github.com/repos/mslehto/errbot/issues/events{/number}","events_url":"https://api.github.com/repos/mslehto/errbot/events","assignees_url":"https://api.github.com/repos/mslehto/errbot/assignees{/user}","branches_url":"https://api.github.com/repos/mslehto/errbot/branches{/branch}","tags_url":"https://api.github.com/repos/mslehto/errbot/tags","blobs_url":"https://api.github.com/repos/mslehto/errbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mslehto/errbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mslehto/errbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/mslehto/errbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mslehto/errbot/statuses/{sha}","languages_url":"https://api.github.com/repos/mslehto/errbot/languages","stargazers_url":"https://api.github.com/repos/mslehto/errbot/stargazers","contributors_url":"https://api.github.com/repos/mslehto/errbot/contributors","subscribers_url":"https://api.github.com/repos/mslehto/errbot/subscribers","subscription_url":"https://api.github.com/repos/mslehto/errbot/subscription","commits_url":"https://api.github.com/repos/mslehto/errbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/mslehto/errbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/mslehto/errbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/mslehto/errbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/mslehto/errbot/contents/{+path}","compare_url":"https://api.github.com/repos/mslehto/errbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mslehto/errbot/merges","archive_url":"https://api.github.com/repos/mslehto/errbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mslehto/errbot/downloads","issues_url":"https://api.github.com/repos/mslehto/errbot/issues{/number}","pulls_url":"https://api.github.com/repos/mslehto/errbot/pulls{/number}","milestones_url":"https://api.github.com/repos/mslehto/errbot/milestones{/number}","notifications_url":"https://api.github.com/repos/mslehto/errbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mslehto/errbot/labels{/name}","releases_url":"https://api.github.com/repos/mslehto/errbot/releases{/id}","created_at":"2016-01-05T18:45:39Z","updated_at":"2016-01-05T18:45:40Z","pushed_at":"2016-01-05T19:56:51Z","git_url":"git://github.com/mslehto/errbot.git","ssh_url":"git@github.com:mslehto/errbot.git","clone_url":"https://github.com/mslehto/errbot.git","svn_url":"https://github.com/mslehto/errbot","homepage":"http://errbot.io","size":8581,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"errbotio:master","ref":"master","sha":"1d3c4ccafd528fbff03a3476906c7558f1183197","user":{"login":"errbotio","id":15802630,"avatar_url":"https://avatars.githubusercontent.com/u/15802630?v=3","gravatar_id":"","url":"https://api.github.com/users/errbotio","html_url":"https://github.com/errbotio","followers_url":"https://api.github.com/users/errbotio/followers","following_url":"https://api.github.com/users/errbotio/following{/other_user}","gists_url":"https://api.github.com/users/errbotio/gists{/gist_id}","starred_url":"https://api.github.com/users/errbotio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/errbotio/subscriptions","organizations_url":"https://api.github.com/users/errbotio/orgs","repos_url":"https://api.github.com/users/errbotio/repos","events_url":"https://api.github.com/users/errbotio/events{/privacy}","received_events_url":"https://api.github.com/users/errbotio/received_events","type":"Organization","site_admin":false},"repo":{"id":4387547,"name":"errbot","full_name":"errbotio/errbot","owner":{"login":"errbotio","id":15802630,"avatar_url":"https://avatars.githubusercontent.com/u/15802630?v=3","gravatar_id":"","url":"https://api.github.com/users/errbotio","html_url":"https://github.com/errbotio","followers_url":"https://api.github.com/users/errbotio/followers","following_url":"https://api.github.com/users/errbotio/following{/other_user}","gists_url":"https://api.github.com/users/errbotio/gists{/gist_id}","starred_url":"https://api.github.com/users/errbotio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/errbotio/subscriptions","organizations_url":"https://api.github.com/users/errbotio/orgs","repos_url":"https://api.github.com/users/errbotio/repos","events_url":"https://api.github.com/users/errbotio/events{/privacy}","received_events_url":"https://api.github.com/users/errbotio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/errbotio/errbot","description":"Errbot is a chatbot, a daemon that connects to your favorite chat service and bring your tools and some fun into the conversation.","fork":false,"url":"https://api.github.com/repos/errbotio/errbot","forks_url":"https://api.github.com/repos/errbotio/errbot/forks","keys_url":"https://api.github.com/repos/errbotio/errbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/errbotio/errbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/errbotio/errbot/teams","hooks_url":"https://api.github.com/repos/errbotio/errbot/hooks","issue_events_url":"https://api.github.com/repos/errbotio/errbot/issues/events{/number}","events_url":"https://api.github.com/repos/errbotio/errbot/events","assignees_url":"https://api.github.com/repos/errbotio/errbot/assignees{/user}","branches_url":"https://api.github.com/repos/errbotio/errbot/branches{/branch}","tags_url":"https://api.github.com/repos/errbotio/errbot/tags","blobs_url":"https://api.github.com/repos/errbotio/errbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/errbotio/errbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/errbotio/errbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/errbotio/errbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/errbotio/errbot/statuses/{sha}","languages_url":"https://api.github.com/repos/errbotio/errbot/languages","stargazers_url":"https://api.github.com/repos/errbotio/errbot/stargazers","contributors_url":"https://api.github.com/repos/errbotio/errbot/contributors","subscribers_url":"https://api.github.com/repos/errbotio/errbot/subscribers","subscription_url":"https://api.github.com/repos/errbotio/errbot/subscription","commits_url":"https://api.github.com/repos/errbotio/errbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/errbotio/errbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/errbotio/errbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/errbotio/errbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/errbotio/errbot/contents/{+path}","compare_url":"https://api.github.com/repos/errbotio/errbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/errbotio/errbot/merges","archive_url":"https://api.github.com/repos/errbotio/errbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/errbotio/errbot/downloads","issues_url":"https://api.github.com/repos/errbotio/errbot/issues{/number}","pulls_url":"https://api.github.com/repos/errbotio/errbot/pulls{/number}","milestones_url":"https://api.github.com/repos/errbotio/errbot/milestones{/number}","notifications_url":"https://api.github.com/repos/errbotio/errbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/errbotio/errbot/labels{/name}","releases_url":"https://api.github.com/repos/errbotio/errbot/releases{/id}","created_at":"2012-05-20T21:13:41Z","updated_at":"2016-01-05T04:54:12Z","pushed_at":"2016-01-05T19:58:06Z","git_url":"git://github.com/errbotio/errbot.git","ssh_url":"git@github.com:errbotio/errbot.git","clone_url":"https://github.com/errbotio/errbot.git","svn_url":"https://github.com/errbotio/errbot","homepage":"http://errbot.io","size":8979,"stargazers_count":653,"watchers_count":653,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":136,"mirror_url":null,"open_issues_count":26,"forks":136,"open_issues":26,"watchers":653,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/errbotio/errbot/pulls/578"},"html":{"href":"https://github.com/errbotio/errbot/pull/578"},"issue":{"href":"https://api.github.com/repos/errbotio/errbot/issues/578"},"comments":{"href":"https://api.github.com/repos/errbotio/errbot/issues/578/comments"},"review_comments":{"href":"https://api.github.com/repos/errbotio/errbot/pulls/578/comments"},"review_comment":{"href":"https://api.github.com/repos/errbotio/errbot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/errbotio/errbot/pulls/578/commits"},"statuses":{"href":"https://api.github.com/repos/errbotio/errbot/statuses/5a9798b366905da07045aad6e299e17fddb83bec"}}}}