{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/92627363","pull_request_review_id":13146744,"id":92627363,"diff_hunk":"@@ -39,6 +43,9 @@ class AmpOoyalaPlayer extends AMP.BaseElement {\n \n     /** @private {?Function} */\n     this.playerReadyResolver_ = null;\n+\n+    const ampdoc = ampdocServiceFor(this.win).getAmpDoc();","path":"extensions/amp-ooyala-player/0.1/amp-ooyala-player.js","position":20,"original_position":20,"commit_id":"131f10169ab2c26eed21719d3b4fda5629fe3f6e","original_commit_id":"131f10169ab2c26eed21719d3b4fda5629fe3f6e","user":{"login":"aghassemi","id":2099009,"avatar_url":"https://avatars.githubusercontent.com/u/2099009?v=3","gravatar_id":"","url":"https://api.github.com/users/aghassemi","html_url":"https://github.com/aghassemi","followers_url":"https://api.github.com/users/aghassemi/followers","following_url":"https://api.github.com/users/aghassemi/following{/other_user}","gists_url":"https://api.github.com/users/aghassemi/gists{/gist_id}","starred_url":"https://api.github.com/users/aghassemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aghassemi/subscriptions","organizations_url":"https://api.github.com/users/aghassemi/orgs","repos_url":"https://api.github.com/users/aghassemi/repos","events_url":"https://api.github.com/users/aghassemi/events{/privacy}","received_events_url":"https://api.github.com/users/aghassemi/received_events","type":"User","site_admin":false},"body":"let's move this to buildCallback and keep constructor purely for declarations","created_at":"2016-12-15T15:12:37Z","updated_at":"2016-12-15T15:12:37Z","html_url":"https://github.com/ampproject/amphtml/pull/6686#discussion_r92627363","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/6686","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/92627363"},"html":{"href":"https://github.com/ampproject/amphtml/pull/6686#discussion_r92627363"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/6686"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/6686","id":98072461,"html_url":"https://github.com/ampproject/amphtml/pull/6686","diff_url":"https://github.com/ampproject/amphtml/pull/6686.diff","patch_url":"https://github.com/ampproject/amphtml/pull/6686.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/6686","number":6686,"state":"open","locked":false,"title":"Making amp-video an extension + backwards compatibility (the real one!) (used git mv here)","user":{"login":"chenshay","id":1397465,"avatar_url":"https://avatars.githubusercontent.com/u/1397465?v=3","gravatar_id":"","url":"https://api.github.com/users/chenshay","html_url":"https://github.com/chenshay","followers_url":"https://api.github.com/users/chenshay/followers","following_url":"https://api.github.com/users/chenshay/following{/other_user}","gists_url":"https://api.github.com/users/chenshay/gists{/gist_id}","starred_url":"https://api.github.com/users/chenshay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenshay/subscriptions","organizations_url":"https://api.github.com/users/chenshay/orgs","repos_url":"https://api.github.com/users/chenshay/repos","events_url":"https://api.github.com/users/chenshay/events{/privacy}","received_events_url":"https://api.github.com/users/chenshay/received_events","type":"User","site_admin":false},"body":"1. Moving all functionality to amp-video extension\r\n2. Backwards compatibility\r\n3. Create Video Manager only when you need it and only once","created_at":"2016-12-15T01:47:30Z","updated_at":"2016-12-15T15:23:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f71babde602e92a9b77cc2619ee7e3f7746c3018","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/6686/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/6686/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/6686/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/131f10169ab2c26eed21719d3b4fda5629fe3f6e","head":{"label":"chenshay:goodvideo","ref":"goodvideo","sha":"131f10169ab2c26eed21719d3b4fda5629fe3f6e","user":{"login":"chenshay","id":1397465,"avatar_url":"https://avatars.githubusercontent.com/u/1397465?v=3","gravatar_id":"","url":"https://api.github.com/users/chenshay","html_url":"https://github.com/chenshay","followers_url":"https://api.github.com/users/chenshay/followers","following_url":"https://api.github.com/users/chenshay/following{/other_user}","gists_url":"https://api.github.com/users/chenshay/gists{/gist_id}","starred_url":"https://api.github.com/users/chenshay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenshay/subscriptions","organizations_url":"https://api.github.com/users/chenshay/orgs","repos_url":"https://api.github.com/users/chenshay/repos","events_url":"https://api.github.com/users/chenshay/events{/privacy}","received_events_url":"https://api.github.com/users/chenshay/received_events","type":"User","site_admin":false},"repo":{"id":72464672,"name":"amphtml","full_name":"chenshay/amphtml","owner":{"login":"chenshay","id":1397465,"avatar_url":"https://avatars.githubusercontent.com/u/1397465?v=3","gravatar_id":"","url":"https://api.github.com/users/chenshay","html_url":"https://github.com/chenshay","followers_url":"https://api.github.com/users/chenshay/followers","following_url":"https://api.github.com/users/chenshay/following{/other_user}","gists_url":"https://api.github.com/users/chenshay/gists{/gist_id}","starred_url":"https://api.github.com/users/chenshay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenshay/subscriptions","organizations_url":"https://api.github.com/users/chenshay/orgs","repos_url":"https://api.github.com/users/chenshay/repos","events_url":"https://api.github.com/users/chenshay/events{/privacy}","received_events_url":"https://api.github.com/users/chenshay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chenshay/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/chenshay/amphtml","forks_url":"https://api.github.com/repos/chenshay/amphtml/forks","keys_url":"https://api.github.com/repos/chenshay/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chenshay/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chenshay/amphtml/teams","hooks_url":"https://api.github.com/repos/chenshay/amphtml/hooks","issue_events_url":"https://api.github.com/repos/chenshay/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/chenshay/amphtml/events","assignees_url":"https://api.github.com/repos/chenshay/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/chenshay/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/chenshay/amphtml/tags","blobs_url":"https://api.github.com/repos/chenshay/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chenshay/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chenshay/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/chenshay/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chenshay/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/chenshay/amphtml/languages","stargazers_url":"https://api.github.com/repos/chenshay/amphtml/stargazers","contributors_url":"https://api.github.com/repos/chenshay/amphtml/contributors","subscribers_url":"https://api.github.com/repos/chenshay/amphtml/subscribers","subscription_url":"https://api.github.com/repos/chenshay/amphtml/subscription","commits_url":"https://api.github.com/repos/chenshay/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/chenshay/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/chenshay/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/chenshay/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/chenshay/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/chenshay/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chenshay/amphtml/merges","archive_url":"https://api.github.com/repos/chenshay/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chenshay/amphtml/downloads","issues_url":"https://api.github.com/repos/chenshay/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/chenshay/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/chenshay/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/chenshay/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chenshay/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/chenshay/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/chenshay/amphtml/deployments","created_at":"2016-10-31T18:11:57Z","updated_at":"2016-10-31T18:12:02Z","pushed_at":"2016-12-15T01:46:22Z","git_url":"git://github.com/chenshay/amphtml.git","ssh_url":"git@github.com:chenshay/amphtml.git","clone_url":"https://github.com/chenshay/amphtml.git","svn_url":"https://github.com/chenshay/amphtml","homepage":"https://ampproject.org","size":220181,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"9e780855e4cf249a2f9e49f76c07f10c52e3eb5c","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2016-12-15T13:43:12Z","pushed_at":"2016-12-15T14:42:49Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://ampproject.org","size":220212,"stargazers_count":9222,"watchers_count":9222,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1442,"mirror_url":null,"open_issues_count":1038,"forks":1442,"open_issues":1038,"watchers":9222,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/6686"},"html":{"href":"https://github.com/ampproject/amphtml/pull/6686"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/6686"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/6686/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/6686/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/6686/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/131f10169ab2c26eed21719d3b4fda5629fe3f6e"}}}}
{"actor":{"display_login":"aghassemi"}}