{"action":"closed","issue":{"url":"https://api.github.com/repos/fluentscheduler/FluentScheduler/issues/100","repository_url":"https://api.github.com/repos/fluentscheduler/FluentScheduler","labels_url":"https://api.github.com/repos/fluentscheduler/FluentScheduler/issues/100/labels{/name}","comments_url":"https://api.github.com/repos/fluentscheduler/FluentScheduler/issues/100/comments","events_url":"https://api.github.com/repos/fluentscheduler/FluentScheduler/issues/100/events","html_url":"https://github.com/fluentscheduler/FluentScheduler/issues/100","id":174038405,"number":100,"title":"Suggestion for dependency injection","user":{"login":"richardsorensson","id":10539292,"avatar_url":"https://avatars.githubusercontent.com/u/10539292?v=3","gravatar_id":"","url":"https://api.github.com/users/richardsorensson","html_url":"https://github.com/richardsorensson","followers_url":"https://api.github.com/users/richardsorensson/followers","following_url":"https://api.github.com/users/richardsorensson/following{/other_user}","gists_url":"https://api.github.com/users/richardsorensson/gists{/gist_id}","starred_url":"https://api.github.com/users/richardsorensson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardsorensson/subscriptions","organizations_url":"https://api.github.com/users/richardsorensson/orgs","repos_url":"https://api.github.com/users/richardsorensson/repos","events_url":"https://api.github.com/users/richardsorensson/events{/privacy}","received_events_url":"https://api.github.com/users/richardsorensson/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-30T14:42:04Z","updated_at":"2016-08-31T17:27:42Z","closed_at":"2016-08-31T17:27:42Z","body":"Hi,\r\n\r\nThought about some minor feedback regarding DI, instead of doing this on the fly to a static JobManager.\r\n\r\nJobManager.JobFactory = new StructureMapJobFactory();\r\nJobManager.Initialize(new MyRegistry()); \r\n\r\nCouldn't the dependency injector handle how the JobManager is instanced and from a ctor one would then just have a param of IJobManager.\r\n\r\nI've also got a suggestion for the .Start() and .Stop(), as of now it seems as Start() is actually triggered when you call Initialize(). I'd be good if start wasn't triggered in initialize when doing DI as there might be cases where you explicitly want to start it at a certain time other then when creating the instance.\r\n\r\nAn idea could be to add a \"autoStart = true\" default parameter for backward compatibility.\r\n\r\nHope any ideas could be of interest."}}
{"actor":{"display_login":"tallesl"}}