{"action":"created","comment":{"url":"https://api.github.com/repos/pytest-dev/pytest/pulls/comments/74148893","id":74148893,"diff_hunk":"@@ -230,7 +230,8 @@ def pytest_runtest_makereport(item, call):\n     if hasattr(item, '_unexpectedsuccess') and rep.when == \"call\":\n         # we need to translate into how pytest encodes xpass\n         rep.wasxfail = \"reason: \" + repr(item._unexpectedsuccess)\n-        rep.outcome = \"failed\"\n+        # TODO: Do we need to check for strict xfail here as well?","path":"_pytest/skipping.py","position":5,"original_position":5,"commit_id":"4fc20d09feb39d31d6c13d48deae717c2d816cf3","original_commit_id":"4fc20d09feb39d31d6c13d48deae717c2d816cf3","user":{"login":"nicoddemus","id":1085180,"avatar_url":"https://avatars.githubusercontent.com/u/1085180?v=3","gravatar_id":"","url":"https://api.github.com/users/nicoddemus","html_url":"https://github.com/nicoddemus","followers_url":"https://api.github.com/users/nicoddemus/followers","following_url":"https://api.github.com/users/nicoddemus/following{/other_user}","gists_url":"https://api.github.com/users/nicoddemus/gists{/gist_id}","starred_url":"https://api.github.com/users/nicoddemus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicoddemus/subscriptions","organizations_url":"https://api.github.com/users/nicoddemus/orgs","repos_url":"https://api.github.com/users/nicoddemus/repos","events_url":"https://api.github.com/users/nicoddemus/events{/privacy}","received_events_url":"https://api.github.com/users/nicoddemus/received_events","type":"User","site_admin":false},"body":"I think you are right, this has to be:\r\n\r\n```python\r\nrep.outcome = \"failed\" if is_strict_xfail else \"passed\"\r\n```\r\n","created_at":"2016-08-09T21:33:41Z","updated_at":"2016-08-09T21:33:41Z","html_url":"https://github.com/pytest-dev/pytest/pull/1795#discussion_r74148893","pull_request_url":"https://api.github.com/repos/pytest-dev/pytest/pulls/1795","_links":{"self":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/comments/74148893"},"html":{"href":"https://github.com/pytest-dev/pytest/pull/1795#discussion_r74148893"},"pull_request":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/1795"}}},"pull_request":{"url":"https://api.github.com/repos/pytest-dev/pytest/pulls/1795","id":80287092,"html_url":"https://github.com/pytest-dev/pytest/pull/1795","diff_url":"https://github.com/pytest-dev/pytest/pull/1795.diff","patch_url":"https://github.com/pytest-dev/pytest/pull/1795.patch","issue_url":"https://api.github.com/repos/pytest-dev/pytest/issues/1795","number":1795,"state":"open","locked":false,"title":"WIP Change outcome to 'passed' for xfail unless it's strict","user":{"login":"hackebrot","id":6024445,"avatar_url":"https://avatars.githubusercontent.com/u/6024445?v=3","gravatar_id":"","url":"https://api.github.com/users/hackebrot","html_url":"https://github.com/hackebrot","followers_url":"https://api.github.com/users/hackebrot/followers","following_url":"https://api.github.com/users/hackebrot/following{/other_user}","gists_url":"https://api.github.com/users/hackebrot/gists{/gist_id}","starred_url":"https://api.github.com/users/hackebrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hackebrot/subscriptions","organizations_url":"https://api.github.com/users/hackebrot/orgs","repos_url":"https://api.github.com/users/hackebrot/repos","events_url":"https://api.github.com/users/hackebrot/events{/privacy}","received_events_url":"https://api.github.com/users/hackebrot/received_events","type":"User","site_admin":false},"body":"I am not entirely sure if this is the right way to do it.\r\n\r\nThis is very much **WIP** as the tests will be failing.\r\n\r\nCan anybody help me out with this one, please 😃 \r\n\r\nResolves #1546 \r\n","created_at":"2016-08-05T18:31:22Z","updated_at":"2016-08-09T21:33:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9a3e5e2f96bfba9fb17db8a9959a09cf18a5e02","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pytest-dev/pytest/pulls/1795/commits","review_comments_url":"https://api.github.com/repos/pytest-dev/pytest/pulls/1795/comments","review_comment_url":"https://api.github.com/repos/pytest-dev/pytest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytest-dev/pytest/issues/1795/comments","statuses_url":"https://api.github.com/repos/pytest-dev/pytest/statuses/4fc20d09feb39d31d6c13d48deae717c2d816cf3","head":{"label":"hackebrot:fix-report-outcome-for-xpass","ref":"fix-report-outcome-for-xpass","sha":"4fc20d09feb39d31d6c13d48deae717c2d816cf3","user":{"login":"hackebrot","id":6024445,"avatar_url":"https://avatars.githubusercontent.com/u/6024445?v=3","gravatar_id":"","url":"https://api.github.com/users/hackebrot","html_url":"https://github.com/hackebrot","followers_url":"https://api.github.com/users/hackebrot/followers","following_url":"https://api.github.com/users/hackebrot/following{/other_user}","gists_url":"https://api.github.com/users/hackebrot/gists{/gist_id}","starred_url":"https://api.github.com/users/hackebrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hackebrot/subscriptions","organizations_url":"https://api.github.com/users/hackebrot/orgs","repos_url":"https://api.github.com/users/hackebrot/repos","events_url":"https://api.github.com/users/hackebrot/events{/privacy}","received_events_url":"https://api.github.com/users/hackebrot/received_events","type":"User","site_admin":false},"repo":{"id":43445246,"name":"pytest","full_name":"hackebrot/pytest","owner":{"login":"hackebrot","id":6024445,"avatar_url":"https://avatars.githubusercontent.com/u/6024445?v=3","gravatar_id":"","url":"https://api.github.com/users/hackebrot","html_url":"https://github.com/hackebrot","followers_url":"https://api.github.com/users/hackebrot/followers","following_url":"https://api.github.com/users/hackebrot/following{/other_user}","gists_url":"https://api.github.com/users/hackebrot/gists{/gist_id}","starred_url":"https://api.github.com/users/hackebrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hackebrot/subscriptions","organizations_url":"https://api.github.com/users/hackebrot/orgs","repos_url":"https://api.github.com/users/hackebrot/repos","events_url":"https://api.github.com/users/hackebrot/events{/privacy}","received_events_url":"https://api.github.com/users/hackebrot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hackebrot/pytest","description":"The pytest testing tool makes it easy to write small tests, yet scales to support complex functional testing","fork":true,"url":"https://api.github.com/repos/hackebrot/pytest","forks_url":"https://api.github.com/repos/hackebrot/pytest/forks","keys_url":"https://api.github.com/repos/hackebrot/pytest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hackebrot/pytest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hackebrot/pytest/teams","hooks_url":"https://api.github.com/repos/hackebrot/pytest/hooks","issue_events_url":"https://api.github.com/repos/hackebrot/pytest/issues/events{/number}","events_url":"https://api.github.com/repos/hackebrot/pytest/events","assignees_url":"https://api.github.com/repos/hackebrot/pytest/assignees{/user}","branches_url":"https://api.github.com/repos/hackebrot/pytest/branches{/branch}","tags_url":"https://api.github.com/repos/hackebrot/pytest/tags","blobs_url":"https://api.github.com/repos/hackebrot/pytest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hackebrot/pytest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hackebrot/pytest/git/refs{/sha}","trees_url":"https://api.github.com/repos/hackebrot/pytest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hackebrot/pytest/statuses/{sha}","languages_url":"https://api.github.com/repos/hackebrot/pytest/languages","stargazers_url":"https://api.github.com/repos/hackebrot/pytest/stargazers","contributors_url":"https://api.github.com/repos/hackebrot/pytest/contributors","subscribers_url":"https://api.github.com/repos/hackebrot/pytest/subscribers","subscription_url":"https://api.github.com/repos/hackebrot/pytest/subscription","commits_url":"https://api.github.com/repos/hackebrot/pytest/commits{/sha}","git_commits_url":"https://api.github.com/repos/hackebrot/pytest/git/commits{/sha}","comments_url":"https://api.github.com/repos/hackebrot/pytest/comments{/number}","issue_comment_url":"https://api.github.com/repos/hackebrot/pytest/issues/comments{/number}","contents_url":"https://api.github.com/repos/hackebrot/pytest/contents/{+path}","compare_url":"https://api.github.com/repos/hackebrot/pytest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hackebrot/pytest/merges","archive_url":"https://api.github.com/repos/hackebrot/pytest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hackebrot/pytest/downloads","issues_url":"https://api.github.com/repos/hackebrot/pytest/issues{/number}","pulls_url":"https://api.github.com/repos/hackebrot/pytest/pulls{/number}","milestones_url":"https://api.github.com/repos/hackebrot/pytest/milestones{/number}","notifications_url":"https://api.github.com/repos/hackebrot/pytest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hackebrot/pytest/labels{/name}","releases_url":"https://api.github.com/repos/hackebrot/pytest/releases{/id}","deployments_url":"https://api.github.com/repos/hackebrot/pytest/deployments","created_at":"2015-09-30T16:42:04Z","updated_at":"2016-05-25T13:48:45Z","pushed_at":"2016-08-05T18:26:14Z","git_url":"git://github.com/hackebrot/pytest.git","ssh_url":"git@github.com:hackebrot/pytest.git","clone_url":"https://github.com/hackebrot/pytest.git","svn_url":"https://github.com/hackebrot/pytest","homepage":"http://pytest.org/","size":8675,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"pytest-dev:master","ref":"master","sha":"ffb583ae9140bfa14b28ff44245ec0b16ad760a7","user":{"login":"pytest-dev","id":8897583,"avatar_url":"https://avatars.githubusercontent.com/u/8897583?v=3","gravatar_id":"","url":"https://api.github.com/users/pytest-dev","html_url":"https://github.com/pytest-dev","followers_url":"https://api.github.com/users/pytest-dev/followers","following_url":"https://api.github.com/users/pytest-dev/following{/other_user}","gists_url":"https://api.github.com/users/pytest-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pytest-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytest-dev/subscriptions","organizations_url":"https://api.github.com/users/pytest-dev/orgs","repos_url":"https://api.github.com/users/pytest-dev/repos","events_url":"https://api.github.com/users/pytest-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pytest-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":37489525,"name":"pytest","full_name":"pytest-dev/pytest","owner":{"login":"pytest-dev","id":8897583,"avatar_url":"https://avatars.githubusercontent.com/u/8897583?v=3","gravatar_id":"","url":"https://api.github.com/users/pytest-dev","html_url":"https://github.com/pytest-dev","followers_url":"https://api.github.com/users/pytest-dev/followers","following_url":"https://api.github.com/users/pytest-dev/following{/other_user}","gists_url":"https://api.github.com/users/pytest-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pytest-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytest-dev/subscriptions","organizations_url":"https://api.github.com/users/pytest-dev/orgs","repos_url":"https://api.github.com/users/pytest-dev/repos","events_url":"https://api.github.com/users/pytest-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pytest-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytest-dev/pytest","description":"The pytest framework makes it easy to write small tests, yet scales to support complex functional testing","fork":false,"url":"https://api.github.com/repos/pytest-dev/pytest","forks_url":"https://api.github.com/repos/pytest-dev/pytest/forks","keys_url":"https://api.github.com/repos/pytest-dev/pytest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytest-dev/pytest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytest-dev/pytest/teams","hooks_url":"https://api.github.com/repos/pytest-dev/pytest/hooks","issue_events_url":"https://api.github.com/repos/pytest-dev/pytest/issues/events{/number}","events_url":"https://api.github.com/repos/pytest-dev/pytest/events","assignees_url":"https://api.github.com/repos/pytest-dev/pytest/assignees{/user}","branches_url":"https://api.github.com/repos/pytest-dev/pytest/branches{/branch}","tags_url":"https://api.github.com/repos/pytest-dev/pytest/tags","blobs_url":"https://api.github.com/repos/pytest-dev/pytest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytest-dev/pytest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytest-dev/pytest/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytest-dev/pytest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytest-dev/pytest/statuses/{sha}","languages_url":"https://api.github.com/repos/pytest-dev/pytest/languages","stargazers_url":"https://api.github.com/repos/pytest-dev/pytest/stargazers","contributors_url":"https://api.github.com/repos/pytest-dev/pytest/contributors","subscribers_url":"https://api.github.com/repos/pytest-dev/pytest/subscribers","subscription_url":"https://api.github.com/repos/pytest-dev/pytest/subscription","commits_url":"https://api.github.com/repos/pytest-dev/pytest/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytest-dev/pytest/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytest-dev/pytest/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytest-dev/pytest/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytest-dev/pytest/contents/{+path}","compare_url":"https://api.github.com/repos/pytest-dev/pytest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytest-dev/pytest/merges","archive_url":"https://api.github.com/repos/pytest-dev/pytest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytest-dev/pytest/downloads","issues_url":"https://api.github.com/repos/pytest-dev/pytest/issues{/number}","pulls_url":"https://api.github.com/repos/pytest-dev/pytest/pulls{/number}","milestones_url":"https://api.github.com/repos/pytest-dev/pytest/milestones{/number}","notifications_url":"https://api.github.com/repos/pytest-dev/pytest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytest-dev/pytest/labels{/name}","releases_url":"https://api.github.com/repos/pytest-dev/pytest/releases{/id}","deployments_url":"https://api.github.com/repos/pytest-dev/pytest/deployments","created_at":"2015-06-15T20:28:27Z","updated_at":"2016-08-08T02:21:00Z","pushed_at":"2016-08-08T13:43:38Z","git_url":"git://github.com/pytest-dev/pytest.git","ssh_url":"git@github.com:pytest-dev/pytest.git","clone_url":"https://github.com/pytest-dev/pytest.git","svn_url":"https://github.com/pytest-dev/pytest","homepage":"http://pytest.org/","size":10834,"stargazers_count":819,"watchers_count":819,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":227,"mirror_url":null,"open_issues_count":268,"forks":227,"open_issues":268,"watchers":819,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/1795"},"html":{"href":"https://github.com/pytest-dev/pytest/pull/1795"},"issue":{"href":"https://api.github.com/repos/pytest-dev/pytest/issues/1795"},"comments":{"href":"https://api.github.com/repos/pytest-dev/pytest/issues/1795/comments"},"review_comments":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/1795/comments"},"review_comment":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/1795/commits"},"statuses":{"href":"https://api.github.com/repos/pytest-dev/pytest/statuses/4fc20d09feb39d31d6c13d48deae717c2d816cf3"}}}}
{"actor":{"display_login":"nicoddemus"}}