{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/pulls/comments/68160047","id":68160047,"diff_hunk":"@@ -0,0 +1,52 @@\n+package org.bitcoins.core.util.testprotocol\n+\n+import spray.json._\n+\n+import scala.annotation.tailrec\n+\n+/**\n+  * Created by tom on 6/20/16.\n+  */\n+object Base58InvalidTestCaseProtocol extends DefaultJsonProtocol {\n+  implicit object Base58InvalidTestCaseFormatter extends RootJsonFormat[Seq[Base58InvalidTestCase]] {\n+    override def read(value: JsValue) : Seq[Base58InvalidTestCase] = {\n+      val jsArray : JsArray = value match {\n+        case array : JsArray => array\n+        case _ : JsValue => throw new RuntimeException(\"TestCase must be in format of jsArray\")\n+      }\n+      val elements : Vector[JsValue] = jsArray.elements\n+      parser(elements)\n+    }\n+    override def write (testCase : Seq[Base58InvalidTestCase]) : JsValue = ???\n+  }\n+\n+  /**\n+    * Function to parse the JSON values into a Seq[Base58InvalidTestCase]\n+    * @param elements\n+    * @return\n+    */\n+  def parser(elements : Seq[JsValue]) : Seq[Base58InvalidTestCase] = {","path":"src/test/scala/org/bitcoins/core/util/testprotocol/Base58InvalidTestCaseProtocol.scala","position":28,"original_position":28,"commit_id":"a8da08da236adb1a4d3b348a48989e4c2e11e946","original_commit_id":"a8da08da236adb1a4d3b348a48989e4c2e11e946","user":{"login":"Christewart","id":3514957,"avatar_url":"https://avatars.githubusercontent.com/u/3514957?v=3","gravatar_id":"","url":"https://api.github.com/users/Christewart","html_url":"https://github.com/Christewart","followers_url":"https://api.github.com/users/Christewart/followers","following_url":"https://api.github.com/users/Christewart/following{/other_user}","gists_url":"https://api.github.com/users/Christewart/gists{/gist_id}","starred_url":"https://api.github.com/users/Christewart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Christewart/subscriptions","organizations_url":"https://api.github.com/users/Christewart/orgs","repos_url":"https://api.github.com/users/Christewart/repos","events_url":"https://api.github.com/users/Christewart/events{/privacy}","received_events_url":"https://api.github.com/users/Christewart/received_events","type":"User","site_admin":false},"body":"Probably need a better name for this function, also can be it `private`","created_at":"2016-06-23T00:40:07Z","updated_at":"2016-06-23T00:40:07Z","html_url":"https://github.com/bitcoin-s/bitcoin-s-core/pull/16#discussion_r68160047","pull_request_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/pulls/comments/68160047"},"html":{"href":"https://github.com/bitcoin-s/bitcoin-s-core/pull/16#discussion_r68160047"},"pull_request":{"href":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/pulls/16","id":74844765,"html_url":"https://github.com/bitcoin-s/bitcoin-s-core/pull/16","diff_url":"https://github.com/bitcoin-s/bitcoin-s-core/pull/16.diff","patch_url":"https://github.com/bitcoin-s/bitcoin-s-core/pull/16.patch","issue_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/issues/16","number":16,"state":"open","locked":false,"title":"Base58 json tests","user":{"login":"TomMcCabe","id":12506365,"avatar_url":"https://avatars.githubusercontent.com/u/12506365?v=3","gravatar_id":"","url":"https://api.github.com/users/TomMcCabe","html_url":"https://github.com/TomMcCabe","followers_url":"https://api.github.com/users/TomMcCabe/followers","following_url":"https://api.github.com/users/TomMcCabe/following{/other_user}","gists_url":"https://api.github.com/users/TomMcCabe/gists{/gist_id}","starred_url":"https://api.github.com/users/TomMcCabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomMcCabe/subscriptions","organizations_url":"https://api.github.com/users/TomMcCabe/orgs","repos_url":"https://api.github.com/users/TomMcCabe/repos","events_url":"https://api.github.com/users/TomMcCabe/events{/privacy}","received_events_url":"https://api.github.com/users/TomMcCabe/received_events","type":"User","site_admin":false},"body":"This pull request includes tests for:\r\n\r\n- base58_keys_valid.json\r\n- base58_keys_invalid.json\r\n- base58_encode_decode.json\r\n\r\nSome improvements to Base58 as well:\r\n\r\n-  \"isValid\" function to determine whether or not a string is a valid Base58 string\r\n- Function to encode private keys into Wallet Import Format (WIF), which is Base58 encoded\r\n- Function to encode a Sha256Hash160Digest to a base58 address\r\n- Fix bug in \"encode\" function that didn't account for leading byte values of zero.","created_at":"2016-06-22T19:44:54Z","updated_at":"2016-06-23T00:40:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b60df5362b2c3dbc81f3f2d41cc7e6252421891","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/pulls/16/commits","review_comments_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/pulls/16/comments","review_comment_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/issues/16/comments","statuses_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/statuses/a8da08da236adb1a4d3b348a48989e4c2e11e946","head":{"label":"TomMcCabe:base58_json_tests","ref":"base58_json_tests","sha":"a8da08da236adb1a4d3b348a48989e4c2e11e946","user":{"login":"TomMcCabe","id":12506365,"avatar_url":"https://avatars.githubusercontent.com/u/12506365?v=3","gravatar_id":"","url":"https://api.github.com/users/TomMcCabe","html_url":"https://github.com/TomMcCabe","followers_url":"https://api.github.com/users/TomMcCabe/followers","following_url":"https://api.github.com/users/TomMcCabe/following{/other_user}","gists_url":"https://api.github.com/users/TomMcCabe/gists{/gist_id}","starred_url":"https://api.github.com/users/TomMcCabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomMcCabe/subscriptions","organizations_url":"https://api.github.com/users/TomMcCabe/orgs","repos_url":"https://api.github.com/users/TomMcCabe/repos","events_url":"https://api.github.com/users/TomMcCabe/events{/privacy}","received_events_url":"https://api.github.com/users/TomMcCabe/received_events","type":"User","site_admin":false},"repo":{"id":57337488,"name":"bitcoin-s-core","full_name":"TomMcCabe/bitcoin-s-core","owner":{"login":"TomMcCabe","id":12506365,"avatar_url":"https://avatars.githubusercontent.com/u/12506365?v=3","gravatar_id":"","url":"https://api.github.com/users/TomMcCabe","html_url":"https://github.com/TomMcCabe","followers_url":"https://api.github.com/users/TomMcCabe/followers","following_url":"https://api.github.com/users/TomMcCabe/following{/other_user}","gists_url":"https://api.github.com/users/TomMcCabe/gists{/gist_id}","starred_url":"https://api.github.com/users/TomMcCabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomMcCabe/subscriptions","organizations_url":"https://api.github.com/users/TomMcCabe/orgs","repos_url":"https://api.github.com/users/TomMcCabe/repos","events_url":"https://api.github.com/users/TomMcCabe/events{/privacy}","received_events_url":"https://api.github.com/users/TomMcCabe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TomMcCabe/bitcoin-s-core","description":"Bitcoin Implementation in Scala (core module)","fork":true,"url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core","forks_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/forks","keys_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/teams","hooks_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/hooks","issue_events_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/issues/events{/number}","events_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/events","assignees_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/assignees{/user}","branches_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/branches{/branch}","tags_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/tags","blobs_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/statuses/{sha}","languages_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/languages","stargazers_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/stargazers","contributors_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/contributors","subscribers_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/subscribers","subscription_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/subscription","commits_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/contents/{+path}","compare_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/merges","archive_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/downloads","issues_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/issues{/number}","pulls_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/pulls{/number}","milestones_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/milestones{/number}","notifications_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/labels{/name}","releases_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/releases{/id}","deployments_url":"https://api.github.com/repos/TomMcCabe/bitcoin-s-core/deployments","created_at":"2016-04-28T22:21:55Z","updated_at":"2016-04-28T22:21:57Z","pushed_at":"2016-06-22T19:26:48Z","git_url":"git://github.com/TomMcCabe/bitcoin-s-core.git","ssh_url":"git@github.com:TomMcCabe/bitcoin-s-core.git","clone_url":"https://github.com/TomMcCabe/bitcoin-s-core.git","svn_url":"https://github.com/TomMcCabe/bitcoin-s-core","homepage":null,"size":1758,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"bitcoin-s-core"}},"base":{"label":"bitcoin-s:master","ref":"master","sha":"5417be5f7ed663d9bd96d617d3c6055472ed3294","user":{"login":"bitcoin-s","id":16688471,"avatar_url":"https://avatars.githubusercontent.com/u/16688471?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin-s","html_url":"https://github.com/bitcoin-s","followers_url":"https://api.github.com/users/bitcoin-s/followers","following_url":"https://api.github.com/users/bitcoin-s/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin-s/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin-s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin-s/subscriptions","organizations_url":"https://api.github.com/users/bitcoin-s/orgs","repos_url":"https://api.github.com/users/bitcoin-s/repos","events_url":"https://api.github.com/users/bitcoin-s/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin-s/received_events","type":"Organization","site_admin":false},"repo":{"id":57332261,"name":"bitcoin-s-core","full_name":"bitcoin-s/bitcoin-s-core","owner":{"login":"bitcoin-s","id":16688471,"avatar_url":"https://avatars.githubusercontent.com/u/16688471?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin-s","html_url":"https://github.com/bitcoin-s","followers_url":"https://api.github.com/users/bitcoin-s/followers","following_url":"https://api.github.com/users/bitcoin-s/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin-s/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin-s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin-s/subscriptions","organizations_url":"https://api.github.com/users/bitcoin-s/orgs","repos_url":"https://api.github.com/users/bitcoin-s/repos","events_url":"https://api.github.com/users/bitcoin-s/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin-s/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin-s/bitcoin-s-core","description":"Bitcoin Implementation in Scala (core module)","fork":false,"url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core","forks_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/forks","keys_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/teams","hooks_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/hooks","issue_events_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/events","assignees_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/tags","blobs_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/languages","stargazers_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/stargazers","contributors_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/contributors","subscribers_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/subscribers","subscription_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/subscription","commits_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/merges","archive_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/downloads","issues_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/deployments","created_at":"2016-04-28T20:38:56Z","updated_at":"2016-05-31T14:39:14Z","pushed_at":"2016-06-22T19:44:54Z","git_url":"git://github.com/bitcoin-s/bitcoin-s-core.git","ssh_url":"git@github.com:bitcoin-s/bitcoin-s-core.git","clone_url":"https://github.com/bitcoin-s/bitcoin-s-core.git","svn_url":"https://github.com/bitcoin-s/bitcoin-s-core","homepage":null,"size":1692,"stargazers_count":8,"watchers_count":8,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/pulls/16"},"html":{"href":"https://github.com/bitcoin-s/bitcoin-s-core/pull/16"},"issue":{"href":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/issues/16"},"comments":{"href":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin-s/bitcoin-s-core/statuses/a8da08da236adb1a4d3b348a48989e4c2e11e946"}}}}
{"actor":{"display_login":"Christewart"}}