{"action":"created","issue":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/10474","repository_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/10474/labels{/name}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/10474/comments","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/10474/events","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/10474","id":169586507,"number":10474,"title":"Ember update to 2.7","user":{"login":"webbiesdk","id":868540,"avatar_url":"https://avatars.githubusercontent.com/u/868540?v=3","gravatar_id":"","url":"https://api.github.com/users/webbiesdk","html_url":"https://github.com/webbiesdk","followers_url":"https://api.github.com/users/webbiesdk/followers","following_url":"https://api.github.com/users/webbiesdk/following{/other_user}","gists_url":"https://api.github.com/users/webbiesdk/gists{/gist_id}","starred_url":"https://api.github.com/users/webbiesdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webbiesdk/subscriptions","organizations_url":"https://api.github.com/users/webbiesdk/orgs","repos_url":"https://api.github.com/users/webbiesdk/repos","events_url":"https://api.github.com/users/webbiesdk/events{/privacy}","received_events_url":"https://api.github.com/users/webbiesdk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-08-05T11:22:43Z","updated_at":"2016-08-05T22:18:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/10474","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/10474","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/10474.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/10474.patch"},"body":"I looked into updating ember from version 2.0 to version 2.7. \r\n\r\nFirst up i made a big change. Instead of having essentially 3 duplicates of the same declaration, i used the `typeof` operator and `export = Ember` to have just 1 copy of the declaration, that is then referenced twice. \r\nThis makes it so you cannot use the \"Em\" name for types, you have to use the Ember name. (The change has been made in the \r\nBut for code without type annotations, the `Em` object still works there. \r\n\r\nThis makes the declaration file significantly easier to maintain, as any changes to the Ember object does not have to be made in 3 places. \r\n\r\nThen i updated the declaration to better match the 2.7 implementation. \r\nI might not have gotten everything, but I think most of the changes has been included. \r\n\r\nI could have split it into 2 pull requests, but those 2 pull-requests would conflict, so I decided on just this one. "},"comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments/237979290","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/10474#issuecomment-237979290","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/10474","id":237979290,"user":{"login":"minestarks","id":16928427,"avatar_url":"https://avatars.githubusercontent.com/u/16928427?v=3","gravatar_id":"","url":"https://api.github.com/users/minestarks","html_url":"https://github.com/minestarks","followers_url":"https://api.github.com/users/minestarks/followers","following_url":"https://api.github.com/users/minestarks/following{/other_user}","gists_url":"https://api.github.com/users/minestarks/gists{/gist_id}","starred_url":"https://api.github.com/users/minestarks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minestarks/subscriptions","organizations_url":"https://api.github.com/users/minestarks/orgs","repos_url":"https://api.github.com/users/minestarks/repos","events_url":"https://api.github.com/users/minestarks/events{/privacy}","received_events_url":"https://api.github.com/users/minestarks/received_events","type":"User","site_admin":false},"created_at":"2016-08-05T22:18:37Z","updated_at":"2016-08-05T22:18:37Z","body":"Hmm sorry I didn't realize \"Em\" was there in the API. I think expecting it to work in type annotations as well is reasonable, as ugly as the duplication is. I'll leave this PR open for a while to see if there's more feedback."}}
{"actor":{"display_login":"minestarks"}}