{"action":"opened","number":271,"pull_request":{"url":"https://api.github.com/repos/js-platform/node-webrtc/pulls/271","id":69392808,"html_url":"https://github.com/js-platform/node-webrtc/pull/271","diff_url":"https://github.com/js-platform/node-webrtc/pull/271.diff","patch_url":"https://github.com/js-platform/node-webrtc/pull/271.patch","issue_url":"https://api.github.com/repos/js-platform/node-webrtc/issues/271","number":271,"state":"open","locked":false,"title":"Update nan to fix deprecation warnings","user":{"login":"caseywebdev","id":1181237,"avatar_url":"https://avatars.githubusercontent.com/u/1181237?v=3","gravatar_id":"","url":"https://api.github.com/users/caseywebdev","html_url":"https://github.com/caseywebdev","followers_url":"https://api.github.com/users/caseywebdev/followers","following_url":"https://api.github.com/users/caseywebdev/following{/other_user}","gists_url":"https://api.github.com/users/caseywebdev/gists{/gist_id}","starred_url":"https://api.github.com/users/caseywebdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseywebdev/subscriptions","organizations_url":"https://api.github.com/users/caseywebdev/orgs","repos_url":"https://api.github.com/users/caseywebdev/repos","events_url":"https://api.github.com/users/caseywebdev/events{/privacy}","received_events_url":"https://api.github.com/users/caseywebdev/received_events","type":"User","site_admin":false},"body":"Node 6 dumps a heap of deprecation warnings when this lib is included:\r\n\r\n```\r\n(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated\r\n(node) and will stop working in the next major release.\r\n==== JS stack trace =========================================\r\nSecurity context: 0x16917dac9fa9 <JS Object>#0#\r\n    1: .node [module.js:568] [pc=0x43fc98a3704] (this=0x206b7dfdf3e9 <an Object with map 0x31b8ee17609>#1#,module=0x34b4d60d4d59 <a Module with map 0x31b8ee17be1>#2#,filename=0x34b4d60d4d21 <String[61]: /code/build/wrtc/v0.0.59/Release/node-v48-linux-x64/wrtc.node>)\r\n...\r\n```\r\n\r\n[Another project with the same issue](https://github.com/Automattic/node-canvas/issues/758) narrowed it down to an outdated version of nan. It'd be great to be able to merge this and cut a release to fix those noisy warnings that are blowing up my app logs.","created_at":"2016-05-09T18:56:50Z","updated_at":"2016-05-09T18:56:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/js-platform/node-webrtc/pulls/271/commits","review_comments_url":"https://api.github.com/repos/js-platform/node-webrtc/pulls/271/comments","review_comment_url":"https://api.github.com/repos/js-platform/node-webrtc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/js-platform/node-webrtc/issues/271/comments","statuses_url":"https://api.github.com/repos/js-platform/node-webrtc/statuses/b04f8a7e07813eb70f1d3a250b14e58de29e4fbd","head":{"label":"caseywebdev:update-nan","ref":"update-nan","sha":"b04f8a7e07813eb70f1d3a250b14e58de29e4fbd","user":{"login":"caseywebdev","id":1181237,"avatar_url":"https://avatars.githubusercontent.com/u/1181237?v=3","gravatar_id":"","url":"https://api.github.com/users/caseywebdev","html_url":"https://github.com/caseywebdev","followers_url":"https://api.github.com/users/caseywebdev/followers","following_url":"https://api.github.com/users/caseywebdev/following{/other_user}","gists_url":"https://api.github.com/users/caseywebdev/gists{/gist_id}","starred_url":"https://api.github.com/users/caseywebdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseywebdev/subscriptions","organizations_url":"https://api.github.com/users/caseywebdev/orgs","repos_url":"https://api.github.com/users/caseywebdev/repos","events_url":"https://api.github.com/users/caseywebdev/events{/privacy}","received_events_url":"https://api.github.com/users/caseywebdev/received_events","type":"User","site_admin":false},"repo":{"id":44244239,"name":"node-webrtc","full_name":"caseywebdev/node-webrtc","owner":{"login":"caseywebdev","id":1181237,"avatar_url":"https://avatars.githubusercontent.com/u/1181237?v=3","gravatar_id":"","url":"https://api.github.com/users/caseywebdev","html_url":"https://github.com/caseywebdev","followers_url":"https://api.github.com/users/caseywebdev/followers","following_url":"https://api.github.com/users/caseywebdev/following{/other_user}","gists_url":"https://api.github.com/users/caseywebdev/gists{/gist_id}","starred_url":"https://api.github.com/users/caseywebdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseywebdev/subscriptions","organizations_url":"https://api.github.com/users/caseywebdev/orgs","repos_url":"https://api.github.com/users/caseywebdev/repos","events_url":"https://api.github.com/users/caseywebdev/events{/privacy}","received_events_url":"https://api.github.com/users/caseywebdev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/caseywebdev/node-webrtc","description":"WebRTC stack for node.js","fork":true,"url":"https://api.github.com/repos/caseywebdev/node-webrtc","forks_url":"https://api.github.com/repos/caseywebdev/node-webrtc/forks","keys_url":"https://api.github.com/repos/caseywebdev/node-webrtc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caseywebdev/node-webrtc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caseywebdev/node-webrtc/teams","hooks_url":"https://api.github.com/repos/caseywebdev/node-webrtc/hooks","issue_events_url":"https://api.github.com/repos/caseywebdev/node-webrtc/issues/events{/number}","events_url":"https://api.github.com/repos/caseywebdev/node-webrtc/events","assignees_url":"https://api.github.com/repos/caseywebdev/node-webrtc/assignees{/user}","branches_url":"https://api.github.com/repos/caseywebdev/node-webrtc/branches{/branch}","tags_url":"https://api.github.com/repos/caseywebdev/node-webrtc/tags","blobs_url":"https://api.github.com/repos/caseywebdev/node-webrtc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caseywebdev/node-webrtc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caseywebdev/node-webrtc/git/refs{/sha}","trees_url":"https://api.github.com/repos/caseywebdev/node-webrtc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caseywebdev/node-webrtc/statuses/{sha}","languages_url":"https://api.github.com/repos/caseywebdev/node-webrtc/languages","stargazers_url":"https://api.github.com/repos/caseywebdev/node-webrtc/stargazers","contributors_url":"https://api.github.com/repos/caseywebdev/node-webrtc/contributors","subscribers_url":"https://api.github.com/repos/caseywebdev/node-webrtc/subscribers","subscription_url":"https://api.github.com/repos/caseywebdev/node-webrtc/subscription","commits_url":"https://api.github.com/repos/caseywebdev/node-webrtc/commits{/sha}","git_commits_url":"https://api.github.com/repos/caseywebdev/node-webrtc/git/commits{/sha}","comments_url":"https://api.github.com/repos/caseywebdev/node-webrtc/comments{/number}","issue_comment_url":"https://api.github.com/repos/caseywebdev/node-webrtc/issues/comments{/number}","contents_url":"https://api.github.com/repos/caseywebdev/node-webrtc/contents/{+path}","compare_url":"https://api.github.com/repos/caseywebdev/node-webrtc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caseywebdev/node-webrtc/merges","archive_url":"https://api.github.com/repos/caseywebdev/node-webrtc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caseywebdev/node-webrtc/downloads","issues_url":"https://api.github.com/repos/caseywebdev/node-webrtc/issues{/number}","pulls_url":"https://api.github.com/repos/caseywebdev/node-webrtc/pulls{/number}","milestones_url":"https://api.github.com/repos/caseywebdev/node-webrtc/milestones{/number}","notifications_url":"https://api.github.com/repos/caseywebdev/node-webrtc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caseywebdev/node-webrtc/labels{/name}","releases_url":"https://api.github.com/repos/caseywebdev/node-webrtc/releases{/id}","deployments_url":"https://api.github.com/repos/caseywebdev/node-webrtc/deployments","created_at":"2015-10-14T11:47:55Z","updated_at":"2015-10-14T11:47:56Z","pushed_at":"2016-05-09T18:54:03Z","git_url":"git://github.com/caseywebdev/node-webrtc.git","ssh_url":"git@github.com:caseywebdev/node-webrtc.git","clone_url":"https://github.com/caseywebdev/node-webrtc.git","svn_url":"https://github.com/caseywebdev/node-webrtc","homepage":"js-platform.github.io/node-webrtc","size":604,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"js-platform:develop","ref":"develop","sha":"63f97a53b77e63b5c2f25e283b4a671d49ad5934","user":{"login":"js-platform","id":2854748,"avatar_url":"https://avatars.githubusercontent.com/u/2854748?v=3","gravatar_id":"","url":"https://api.github.com/users/js-platform","html_url":"https://github.com/js-platform","followers_url":"https://api.github.com/users/js-platform/followers","following_url":"https://api.github.com/users/js-platform/following{/other_user}","gists_url":"https://api.github.com/users/js-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/js-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/js-platform/subscriptions","organizations_url":"https://api.github.com/users/js-platform/orgs","repos_url":"https://api.github.com/users/js-platform/repos","events_url":"https://api.github.com/users/js-platform/events{/privacy}","received_events_url":"https://api.github.com/users/js-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":11131753,"name":"node-webrtc","full_name":"js-platform/node-webrtc","owner":{"login":"js-platform","id":2854748,"avatar_url":"https://avatars.githubusercontent.com/u/2854748?v=3","gravatar_id":"","url":"https://api.github.com/users/js-platform","html_url":"https://github.com/js-platform","followers_url":"https://api.github.com/users/js-platform/followers","following_url":"https://api.github.com/users/js-platform/following{/other_user}","gists_url":"https://api.github.com/users/js-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/js-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/js-platform/subscriptions","organizations_url":"https://api.github.com/users/js-platform/orgs","repos_url":"https://api.github.com/users/js-platform/repos","events_url":"https://api.github.com/users/js-platform/events{/privacy}","received_events_url":"https://api.github.com/users/js-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/js-platform/node-webrtc","description":"WebRTC stack for node.js","fork":false,"url":"https://api.github.com/repos/js-platform/node-webrtc","forks_url":"https://api.github.com/repos/js-platform/node-webrtc/forks","keys_url":"https://api.github.com/repos/js-platform/node-webrtc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/js-platform/node-webrtc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/js-platform/node-webrtc/teams","hooks_url":"https://api.github.com/repos/js-platform/node-webrtc/hooks","issue_events_url":"https://api.github.com/repos/js-platform/node-webrtc/issues/events{/number}","events_url":"https://api.github.com/repos/js-platform/node-webrtc/events","assignees_url":"https://api.github.com/repos/js-platform/node-webrtc/assignees{/user}","branches_url":"https://api.github.com/repos/js-platform/node-webrtc/branches{/branch}","tags_url":"https://api.github.com/repos/js-platform/node-webrtc/tags","blobs_url":"https://api.github.com/repos/js-platform/node-webrtc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/js-platform/node-webrtc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/js-platform/node-webrtc/git/refs{/sha}","trees_url":"https://api.github.com/repos/js-platform/node-webrtc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/js-platform/node-webrtc/statuses/{sha}","languages_url":"https://api.github.com/repos/js-platform/node-webrtc/languages","stargazers_url":"https://api.github.com/repos/js-platform/node-webrtc/stargazers","contributors_url":"https://api.github.com/repos/js-platform/node-webrtc/contributors","subscribers_url":"https://api.github.com/repos/js-platform/node-webrtc/subscribers","subscription_url":"https://api.github.com/repos/js-platform/node-webrtc/subscription","commits_url":"https://api.github.com/repos/js-platform/node-webrtc/commits{/sha}","git_commits_url":"https://api.github.com/repos/js-platform/node-webrtc/git/commits{/sha}","comments_url":"https://api.github.com/repos/js-platform/node-webrtc/comments{/number}","issue_comment_url":"https://api.github.com/repos/js-platform/node-webrtc/issues/comments{/number}","contents_url":"https://api.github.com/repos/js-platform/node-webrtc/contents/{+path}","compare_url":"https://api.github.com/repos/js-platform/node-webrtc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/js-platform/node-webrtc/merges","archive_url":"https://api.github.com/repos/js-platform/node-webrtc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/js-platform/node-webrtc/downloads","issues_url":"https://api.github.com/repos/js-platform/node-webrtc/issues{/number}","pulls_url":"https://api.github.com/repos/js-platform/node-webrtc/pulls{/number}","milestones_url":"https://api.github.com/repos/js-platform/node-webrtc/milestones{/number}","notifications_url":"https://api.github.com/repos/js-platform/node-webrtc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/js-platform/node-webrtc/labels{/name}","releases_url":"https://api.github.com/repos/js-platform/node-webrtc/releases{/id}","deployments_url":"https://api.github.com/repos/js-platform/node-webrtc/deployments","created_at":"2013-07-02T18:21:45Z","updated_at":"2016-05-06T06:55:00Z","pushed_at":"2016-05-06T21:32:53Z","git_url":"git://github.com/js-platform/node-webrtc.git","ssh_url":"git@github.com:js-platform/node-webrtc.git","clone_url":"https://github.com/js-platform/node-webrtc.git","svn_url":"https://github.com/js-platform/node-webrtc","homepage":"js-platform.github.io/node-webrtc","size":1064,"stargazers_count":577,"watchers_count":577,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":123,"mirror_url":null,"open_issues_count":64,"forks":123,"open_issues":64,"watchers":577,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/js-platform/node-webrtc/pulls/271"},"html":{"href":"https://github.com/js-platform/node-webrtc/pull/271"},"issue":{"href":"https://api.github.com/repos/js-platform/node-webrtc/issues/271"},"comments":{"href":"https://api.github.com/repos/js-platform/node-webrtc/issues/271/comments"},"review_comments":{"href":"https://api.github.com/repos/js-platform/node-webrtc/pulls/271/comments"},"review_comment":{"href":"https://api.github.com/repos/js-platform/node-webrtc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/js-platform/node-webrtc/pulls/271/commits"},"statuses":{"href":"https://api.github.com/repos/js-platform/node-webrtc/statuses/b04f8a7e07813eb70f1d3a250b14e58de29e4fbd"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}