{"action":"created","issue":{"url":"https://api.github.com/repos/libbi/RBi/issues/4","repository_url":"https://api.github.com/repos/libbi/RBi","labels_url":"https://api.github.com/repos/libbi/RBi/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/libbi/RBi/issues/4/comments","events_url":"https://api.github.com/repos/libbi/RBi/issues/4/events","html_url":"https://github.com/libbi/RBi/pull/4","id":180932049,"number":4,"title":"fixed config file for bi_generate_dataset","user":{"login":"tyler-abbot","id":11857704,"avatar_url":"https://avatars.githubusercontent.com/u/11857704?v=3","gravatar_id":"","url":"https://api.github.com/users/tyler-abbot","html_url":"https://github.com/tyler-abbot","followers_url":"https://api.github.com/users/tyler-abbot/followers","following_url":"https://api.github.com/users/tyler-abbot/following{/other_user}","gists_url":"https://api.github.com/users/tyler-abbot/gists{/gist_id}","starred_url":"https://api.github.com/users/tyler-abbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyler-abbot/subscriptions","organizations_url":"https://api.github.com/users/tyler-abbot/orgs","repos_url":"https://api.github.com/users/tyler-abbot/repos","events_url":"https://api.github.com/users/tyler-abbot/events{/privacy}","received_events_url":"https://api.github.com/users/tyler-abbot/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-04T15:49:18Z","updated_at":"2016-10-04T16:54:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/libbi/RBi/pulls/4","html_url":"https://github.com/libbi/RBi/pull/4","diff_url":"https://github.com/libbi/RBi/pull/4.diff","patch_url":"https://github.com/libbi/RBi/pull/4.patch"},"body":"Previously, including a config file was broken in `bi_generate_dataset`. The variable `endtime` dominated any parameters in the config file.\r\n\r\nNow if one supplies a config file the function recognizes this and does not set the `global_options`, but it is assumed that the config file contains the necessary variables. It might be nice to set this up so that `endtime` is also in the config file, but not necessary.\r\n\r\nI also made changes so that if one does provide a config file, the function checks if `working_folder` is also supplied, as if not this caused a problem with the temporary directory.  "},"comment":{"url":"https://api.github.com/repos/libbi/RBi/issues/comments/251446517","html_url":"https://github.com/libbi/RBi/pull/4#issuecomment-251446517","issue_url":"https://api.github.com/repos/libbi/RBi/issues/4","id":251446517,"user":{"login":"sbfnk","id":1156307,"avatar_url":"https://avatars.githubusercontent.com/u/1156307?v=3","gravatar_id":"","url":"https://api.github.com/users/sbfnk","html_url":"https://github.com/sbfnk","followers_url":"https://api.github.com/users/sbfnk/followers","following_url":"https://api.github.com/users/sbfnk/following{/other_user}","gists_url":"https://api.github.com/users/sbfnk/gists{/gist_id}","starred_url":"https://api.github.com/users/sbfnk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbfnk/subscriptions","organizations_url":"https://api.github.com/users/sbfnk/orgs","repos_url":"https://api.github.com/users/sbfnk/repos","events_url":"https://api.github.com/users/sbfnk/events{/privacy}","received_events_url":"https://api.github.com/users/sbfnk/received_events","type":"User","site_admin":false},"created_at":"2016-10-04T16:54:37Z","updated_at":"2016-10-04T16:54:37Z","body":"Thanks for the fix! I've tried to come up with a more general solution (https://github.com/libbi/RBi/commit/0d7464756cb0130027df6140563aa3775724b1db, https://github.com/libbi/RBi/commit/bc460131ede1fefd4c049f2b56134884beec985d and https://github.com/libbi/RBi/commit/9c3021db400f56e42fcd5144a0c8591165e3026c) that also allows \"end-time\" to be set in the config file when generating a data set. Options passed to `bi_generate_dataset` override the config file. Could you check and let me know if this works for you?"}}
{"actor":{"display_login":"sbfnk"}}