{"action":"created","issue":{"url":"https://api.github.com/repos/tailhook/dns-parser/issues/19","repository_url":"https://api.github.com/repos/tailhook/dns-parser","labels_url":"https://api.github.com/repos/tailhook/dns-parser/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/tailhook/dns-parser/issues/19/comments","events_url":"https://api.github.com/repos/tailhook/dns-parser/issues/19/events","html_url":"https://github.com/tailhook/dns-parser/pull/19","id":191847762,"number":19,"title":"Add a bunch of missing class codes","user":{"login":"dylanmckay","id":7722159,"avatar_url":"https://avatars.githubusercontent.com/u/7722159?v=3","gravatar_id":"","url":"https://api.github.com/users/dylanmckay","html_url":"https://github.com/dylanmckay","followers_url":"https://api.github.com/users/dylanmckay/followers","following_url":"https://api.github.com/users/dylanmckay/following{/other_user}","gists_url":"https://api.github.com/users/dylanmckay/gists{/gist_id}","starred_url":"https://api.github.com/users/dylanmckay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylanmckay/subscriptions","organizations_url":"https://api.github.com/users/dylanmckay/orgs","repos_url":"https://api.github.com/users/dylanmckay/repos","events_url":"https://api.github.com/users/dylanmckay/events{/privacy}","received_events_url":"https://api.github.com/users/dylanmckay/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-27T07:48:33Z","updated_at":"2016-11-27T10:43:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tailhook/dns-parser/pulls/19","html_url":"https://github.com/tailhook/dns-parser/pull/19","diff_url":"https://github.com/tailhook/dns-parser/pull/19.diff","patch_url":"https://github.com/tailhook/dns-parser/pull/19.patch"},"body":"Previously the class code parser only understood the four main class\r\ncodes.\r\n\r\nThis modified it so that it understands all class codes.\r\n\r\nAfter this, it is possible to parse mDNS records from a ChromeCast.\r\n\r\nThere is a table of possible values listed on this page\r\nhttp://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml\r\n\r\nAfter this is added, would you please be able to release a new version to crates.io :)"},"comment":{"url":"https://api.github.com/repos/tailhook/dns-parser/issues/comments/263114939","html_url":"https://github.com/tailhook/dns-parser/pull/19#issuecomment-263114939","issue_url":"https://api.github.com/repos/tailhook/dns-parser/issues/19","id":263114939,"user":{"login":"tailhook","id":321799,"avatar_url":"https://avatars.githubusercontent.com/u/321799?v=3","gravatar_id":"","url":"https://api.github.com/users/tailhook","html_url":"https://github.com/tailhook","followers_url":"https://api.github.com/users/tailhook/followers","following_url":"https://api.github.com/users/tailhook/following{/other_user}","gists_url":"https://api.github.com/users/tailhook/gists{/gist_id}","starred_url":"https://api.github.com/users/tailhook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tailhook/subscriptions","organizations_url":"https://api.github.com/users/tailhook/orgs","repos_url":"https://api.github.com/users/tailhook/repos","events_url":"https://api.github.com/users/tailhook/events{/privacy}","received_events_url":"https://api.github.com/users/tailhook/received_events","type":"User","site_admin":false},"created_at":"2016-11-27T10:43:25Z","updated_at":"2016-11-27T10:43:25Z","body":"> whereas as it currently stands it will just crash instead\r\n\r\nBy \"crash\" you mean it treats packet as invalid, right? If it panics it's definitely a bug.\r\n\r\n> Alongside that, the last addition to the 'class codes' was an RFC from 2013 (which is now almost 4 years ago). Before that, the last modification was in 1997.\r\n\r\nThis means we surely can keep up with the changes in the protocol :)\r\n----\r\nAnother question is: you've added `ANY` and `NONE` to Class but according to docs they are `QCLASS`, meaning that they can only be used in queries not in responses. We already have `Any` in `QueryClass` by the way. Was that intentional?"}}
{"actor":{"display_login":"tailhook"}}