{"action":"created","issue":{"url":"https://api.github.com/repos/dmwm/WMCore/issues/7442","repository_url":"https://api.github.com/repos/dmwm/WMCore","labels_url":"https://api.github.com/repos/dmwm/WMCore/issues/7442/labels{/name}","comments_url":"https://api.github.com/repos/dmwm/WMCore/issues/7442/comments","events_url":"https://api.github.com/repos/dmwm/WMCore/issues/7442/events","html_url":"https://github.com/dmwm/WMCore/pull/7442","id":193303410,"number":7442,"title":"fix aborted and force complete request not killing the jobs","user":{"login":"ticoann","id":1247993,"avatar_url":"https://avatars.githubusercontent.com/u/1247993?v=3","gravatar_id":"","url":"https://api.github.com/users/ticoann","html_url":"https://github.com/ticoann","followers_url":"https://api.github.com/users/ticoann/followers","following_url":"https://api.github.com/users/ticoann/following{/other_user}","gists_url":"https://api.github.com/users/ticoann/gists{/gist_id}","starred_url":"https://api.github.com/users/ticoann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ticoann/subscriptions","organizations_url":"https://api.github.com/users/ticoann/orgs","repos_url":"https://api.github.com/users/ticoann/repos","events_url":"https://api.github.com/users/ticoann/events{/privacy}","received_events_url":"https://api.github.com/users/ticoann/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ticoann","id":1247993,"avatar_url":"https://avatars.githubusercontent.com/u/1247993?v=3","gravatar_id":"","url":"https://api.github.com/users/ticoann","html_url":"https://github.com/ticoann","followers_url":"https://api.github.com/users/ticoann/followers","following_url":"https://api.github.com/users/ticoann/following{/other_user}","gists_url":"https://api.github.com/users/ticoann/gists{/gist_id}","starred_url":"https://api.github.com/users/ticoann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ticoann/subscriptions","organizations_url":"https://api.github.com/users/ticoann/orgs","repos_url":"https://api.github.com/users/ticoann/repos","events_url":"https://api.github.com/users/ticoann/events{/privacy}","received_events_url":"https://api.github.com/users/ticoann/received_events","type":"User","site_admin":false},"assignees":[{"login":"ticoann","id":1247993,"avatar_url":"https://avatars.githubusercontent.com/u/1247993?v=3","gravatar_id":"","url":"https://api.github.com/users/ticoann","html_url":"https://github.com/ticoann","followers_url":"https://api.github.com/users/ticoann/followers","following_url":"https://api.github.com/users/ticoann/following{/other_user}","gists_url":"https://api.github.com/users/ticoann/gists{/gist_id}","starred_url":"https://api.github.com/users/ticoann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ticoann/subscriptions","organizations_url":"https://api.github.com/users/ticoann/orgs","repos_url":"https://api.github.com/users/ticoann/repos","events_url":"https://api.github.com/users/ticoann/events{/privacy}","received_events_url":"https://api.github.com/users/ticoann/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dmwm/WMCore/milestones/131","html_url":"https://github.com/dmwm/WMCore/milestone/131","labels_url":"https://api.github.com/repos/dmwm/WMCore/milestones/131/labels","id":1687466,"number":131,"title":"WMAgent1612","description":"","creator":{"login":"ticoann","id":1247993,"avatar_url":"https://avatars.githubusercontent.com/u/1247993?v=3","gravatar_id":"","url":"https://api.github.com/users/ticoann","html_url":"https://github.com/ticoann","followers_url":"https://api.github.com/users/ticoann/followers","following_url":"https://api.github.com/users/ticoann/following{/other_user}","gists_url":"https://api.github.com/users/ticoann/gists{/gist_id}","starred_url":"https://api.github.com/users/ticoann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ticoann/subscriptions","organizations_url":"https://api.github.com/users/ticoann/orgs","repos_url":"https://api.github.com/users/ticoann/repos","events_url":"https://api.github.com/users/ticoann/events{/privacy}","received_events_url":"https://api.github.com/users/ticoann/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":5,"state":"open","created_at":"2016-04-06T14:43:14Z","updated_at":"2016-12-14T20:55:52Z","due_on":"2016-12-31T05:00:00Z","closed_at":null},"comments":32,"created_at":"2016-12-03T17:45:35Z","updated_at":"2016-12-15T05:22:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dmwm/WMCore/pulls/7442","html_url":"https://github.com/dmwm/WMCore/pull/7442","diff_url":"https://github.com/dmwm/WMCore/pull/7442.diff","patch_url":"https://github.com/dmwm/WMCore/pull/7442.patch"},"body":"This is not tested and still has some issues.\r\nHere is possible issues (might not be critical though).\r\n\r\n1. There is race condition if some workflow is not cleaned up by LQ but it moved to aborted-archived status. (This should be rare but need to be fixed by how we propagate aborted-completed and       *-archived status from multiple agent).\r\n2. Jobs still can be created and submitted between the time user aborted and killing job happens.\r\n    a. currently aborted workflow check is made for wmbs population to prevent further pulling down the work\r\n    b. But we can also add the check in JobCreator and JobSubmitter. (Not sure how much we will gain this - If we need to choose JobSubmitter check will be more effective)\r\n\r\n3. killWork can be called concurrently (but it should cause the deadlock on db)\r\n\r\n@amaltaro, Alan, don't need to review yet. I will update the code.  \r\n"},"comment":{"url":"https://api.github.com/repos/dmwm/WMCore/issues/comments/267241772","html_url":"https://github.com/dmwm/WMCore/pull/7442#issuecomment-267241772","issue_url":"https://api.github.com/repos/dmwm/WMCore/issues/7442","id":267241772,"user":{"login":"ticoann","id":1247993,"avatar_url":"https://avatars.githubusercontent.com/u/1247993?v=3","gravatar_id":"","url":"https://api.github.com/users/ticoann","html_url":"https://github.com/ticoann","followers_url":"https://api.github.com/users/ticoann/followers","following_url":"https://api.github.com/users/ticoann/following{/other_user}","gists_url":"https://api.github.com/users/ticoann/gists{/gist_id}","starred_url":"https://api.github.com/users/ticoann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ticoann/subscriptions","organizations_url":"https://api.github.com/users/ticoann/orgs","repos_url":"https://api.github.com/users/ticoann/repos","events_url":"https://api.github.com/users/ticoann/events{/privacy}","received_events_url":"https://api.github.com/users/ticoann/received_events","type":"User","site_admin":false},"created_at":"2016-12-15T05:22:27Z","updated_at":"2016-12-15T05:22:27Z","body":"@ericvaandering, Hi Eric, The report looks nice but one thing is missed compare to before is there is no stack trace where the failure occurs."}}
{"actor":{"display_login":"ticoann"}}