{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/12678","repository_url":"https://api.github.com/repos/edx/edx-platform","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/12678/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/12678/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/12678/events","html_url":"https://github.com/edx/edx-platform/pull/12678","id":158772781,"number":12678,"title":"Refactor out a new discussions Django app","user":{"login":"andy-armstrong","id":5985072,"avatar_url":"https://avatars.githubusercontent.com/u/5985072?v=3","gravatar_id":"","url":"https://api.github.com/users/andy-armstrong","html_url":"https://github.com/andy-armstrong","followers_url":"https://api.github.com/users/andy-armstrong/followers","following_url":"https://api.github.com/users/andy-armstrong/following{/other_user}","gists_url":"https://api.github.com/users/andy-armstrong/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-armstrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-armstrong/subscriptions","organizations_url":"https://api.github.com/users/andy-armstrong/orgs","repos_url":"https://api.github.com/users/andy-armstrong/repos","events_url":"https://api.github.com/users/andy-armstrong/events{/privacy}","received_events_url":"https://api.github.com/users/andy-armstrong/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-06-06T20:55:39Z","updated_at":"2016-06-08T20:44:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/12678","html_url":"https://github.com/edx/edx-platform/pull/12678","diff_url":"https://github.com/edx/edx-platform/pull/12678.diff","patch_url":"https://github.com/edx/edx-platform/pull/12678.patch"},"body":"### Description\r\n\r\n[TNL-4739](https://openedx.atlassian.net/browse/TNL-4739)\r\n\r\nThis change refactors the Discussion web application into its own Django app. Previously the app lived beneath the django_comment_client directory which doesn't make sense moving forward as we transition to using the new Discussion API. In addition, we needed a better location for the new JavaScript code to live as we start to build out the discussion app, because we don't want to continue using CoffeeScript.\r\n\r\nI then added factory files for both the discussion board and the user profile page, so that we can start to add new code to them. As part of this work I removed the old ``discussion/main.coffee`` file and moved the logic into the factories. For now, the remainder of the existing CoffeeScript code is loaded manually as it does not use RequireJS, which is the approach we took with the Teams UI. Note: moving everything over to RequireJS would be relatively straightforward except for the XModule. We'd need to do something similar to how the video player builds its assets, which isn't something I want to get into yet.\r\n\r\nI also created a content header for the discussion board and moved the \"Add a Post\" button into it. Eventually this will be a more dynamic header with breadcrumbs, but for now this is enough.\r\n\r\nAs part of this clean up, I also refactored the other two discussion pages to use the Pattern Library (these are the user profile page and the under maintenance page).\r\n\r\n### Sandbox\r\n\r\n - Discussion Board: https://andy-armstrong.sandbox.edx.org/courses/course-v1:edX+DemoX+Demo_Course/discussion/forum/\r\n - Inline Discussion: https://andy-armstrong.sandbox.edx.org/courses/course-v1:edX+DemoX+Demo_Course/courseware/social_integration/48ecb924d7fe4b66a230137626bfa93e/\r\n - Team Discussion: https://andy-armstrong.sandbox.edx.org/courses/course-v1:edX+DemoX+Demo_Course/teams/#teams/solar/power-of-the-sun-38242291c34e45acb35e8e6c45584898\r\n\r\n### Testing\r\n- [x] safecommit shows 0 violations\r\n- [ ] Unit, integration, acceptance tests as appropriate\r\n\r\n### Reviewers\r\nIf you've been tagged for review, please check your corresponding box once you've given the :+1:.\r\n- [x] Code review: @bjacobel \r\n- [ ] Code review: @dianakhuang \r\n- [ ] UX review: @chris-mike \r\n- [ ] Accessibility review: @clrux \r\n- [ ] Product review: @marcotuts \r\n\r\n### Post-review\r\n- [ ] Squash commits"},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/224721527","html_url":"https://github.com/edx/edx-platform/pull/12678#issuecomment-224721527","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/12678","id":224721527,"user":{"login":"marcotuts","id":2023680,"avatar_url":"https://avatars.githubusercontent.com/u/2023680?v=3","gravatar_id":"","url":"https://api.github.com/users/marcotuts","html_url":"https://github.com/marcotuts","followers_url":"https://api.github.com/users/marcotuts/followers","following_url":"https://api.github.com/users/marcotuts/following{/other_user}","gists_url":"https://api.github.com/users/marcotuts/gists{/gist_id}","starred_url":"https://api.github.com/users/marcotuts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcotuts/subscriptions","organizations_url":"https://api.github.com/users/marcotuts/orgs","repos_url":"https://api.github.com/users/marcotuts/repos","events_url":"https://api.github.com/users/marcotuts/events{/privacy}","received_events_url":"https://api.github.com/users/marcotuts/received_events","type":"User","site_admin":false},"created_at":"2016-06-08T20:44:29Z","updated_at":"2016-06-08T20:44:29Z","body":"Thanks for the update Andy! \r\n\r\nOne thing still in flux that I just noticed has also changed here in the sandbox are changes to the inside of posts / discussions that I was hoping to punt / exclude from this effort. In particular, @chris-mike and I were still reviewing these changes and iterating on them. I wasn't clear on this up front, so I'm sorry about that. We can follow up tomorrow with more details.\r\n\r\n"}}
{"actor":{"display_login":"marcotuts"}}