{"action":"created","comment":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments/71957522","id":71957522,"diff_hunk":"@@ -206,7 +265,7 @@ namespace FaultsManager {\n \t\t// na\n \n \t\t// SUBROUTINE LOCAL VARIABLE DECLARATIONS:\n-\t\tstatic bool RunMeOnceFlag( false );\n+\t\tstatic bool RunFaultMgrOnceFlag( false );","path":"src/EnergyPlus/FaultsManager.cc","position":null,"original_position":188,"commit_id":"8d52a5a89adf05c1d06170d555ff4a2247413d7c","original_commit_id":"75e240a25a035a4bd7349d42a0111a7f7eba8782","user":{"login":"rongpengzhang","id":7785946,"avatar_url":"https://avatars.githubusercontent.com/u/7785946?v=3","gravatar_id":"","url":"https://api.github.com/users/rongpengzhang","html_url":"https://github.com/rongpengzhang","followers_url":"https://api.github.com/users/rongpengzhang/followers","following_url":"https://api.github.com/users/rongpengzhang/following{/other_user}","gists_url":"https://api.github.com/users/rongpengzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/rongpengzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rongpengzhang/subscriptions","organizations_url":"https://api.github.com/users/rongpengzhang/orgs","repos_url":"https://api.github.com/users/rongpengzhang/repos","events_url":"https://api.github.com/users/rongpengzhang/events{/privacy}","received_events_url":"https://api.github.com/users/rongpengzhang/received_events","type":"User","site_admin":false},"body":"Addressed this for the FaultManager routine.","created_at":"2016-07-22T23:03:20Z","updated_at":"2016-07-22T23:03:20Z","html_url":"https://github.com/NREL/EnergyPlus/pull/5705#discussion_r71957522","pull_request_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5705","_links":{"self":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments/71957522"},"html":{"href":"https://github.com/NREL/EnergyPlus/pull/5705#discussion_r71957522"},"pull_request":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5705"}}},"pull_request":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5705","id":72417927,"html_url":"https://github.com/NREL/EnergyPlus/pull/5705","diff_url":"https://github.com/NREL/EnergyPlus/pull/5705.diff","patch_url":"https://github.com/NREL/EnergyPlus/pull/5705.patch","issue_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5705","number":5705,"state":"open","locked":false,"title":"Modeling HVAC Operational Faults – Chiller Supply Water Temperature Sensor Offset","user":{"login":"rongpengzhang","id":7785946,"avatar_url":"https://avatars.githubusercontent.com/u/7785946?v=3","gravatar_id":"","url":"https://api.github.com/users/rongpengzhang","html_url":"https://github.com/rongpengzhang","followers_url":"https://api.github.com/users/rongpengzhang/followers","following_url":"https://api.github.com/users/rongpengzhang/following{/other_user}","gists_url":"https://api.github.com/users/rongpengzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/rongpengzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rongpengzhang/subscriptions","organizations_url":"https://api.github.com/users/rongpengzhang/orgs","repos_url":"https://api.github.com/users/rongpengzhang/repos","events_url":"https://api.github.com/users/rongpengzhang/events{/privacy}","received_events_url":"https://api.github.com/users/rongpengzhang/received_events","type":"User","site_admin":false},"body":"Pull request overview\r\n---------------------\r\nThe fault modeling features aim to model the HVAC operational faults to improve the accuracy of building simulations and to support the building retrofitting. Compared with Phase I and II that focused on the faults related with air loop, Phase III will include the faults in the plant loop. Four new types of fault will be implemented in Phase III, namely:\r\n\r\n1.\tChiller Supply Water Temperature Sensor Offset\r\n2.\tCondenser Supply Water Temperature Sensor Offset\r\n3.\tCooling Tower Scaling\r\n4.\tCoil Supply Air Temperature Sensor Offset \r\n\r\nThis branch handles the 1st fault in the list. It also restructures the existing faults models by introducing  more OO features to the FaultsManager routine.\r\n\r\n### Work Checklist\r\nAdd to this list or remove from it as applicable.  This is a simple templated set of guidelines.\r\n - [x] Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)\r\n - [x] At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:\r\n   - Defect: This pull request repairs a github defect issue.  The github issue should be referenced in the PR description\r\n   - Refactoring: This pull request includes code changes that don't change the functionality of the program, just perform refactoring\r\n   - NewFeature: This pull request includes code to add a new feature to EnergyPlus\r\n   - Performance: This pull request includes code changes that are directed at improving the runtime performance of EnergyPlus\r\n   - DoNoPublish: This pull request includes changes that shouldn't be included in the changelog\r\n\r\n### Review Checklist\r\nThis will not be exhaustively relevant to every PR.\r\n - [ ] Code style (parentheses padding, variable names)\r\n - [ ] Functional code review (it has to work!)\r\n - [ ] If defect, results of running current develop vs this branch should exhibit the fix\r\n - [x] CI status: all green or justified\r\n - [x] Performance: CI Linux results include performance check -- verify this\r\n - [x] Unit Test(s)\r\n - C++ checks:\r\n   - [ ] Argument types\r\n   - [ ] If any virtual classes, ensure virtual destructor included, other things\r\n - IDD changes:\r\n   - [x] Verify naming conventions and styles, memos and notes and defaults\r\n   - [ ] Open windows IDF Editor with modified IDD to check for errors\r\n   - [x] If transition, add rules to spreadsheet\r\n   - [x] If transition, add transition source\r\n   - [x] If transition, update idfs\r\n - [ ] If new idf included, locally check the err file and other outputs\r\n - [x] Documentation changes in place\r\n - [x] ExpandObjects changes??\r\n - [x] If output changes, including tabular output structure, add to output rules file for interfaces\r\n\r\nCompared with Phase I and II that focused on the faults related with air\r\nloop, Phase III will include the faults in the plant loop. Four new\r\ntypes of fault will be implemented in Phase III, namely:\r\n\r\n1. Chiller Supply Water Temperature Sensor Offset\r\n2. Condenser Supply Water Temperature Sensor Offset\r\n3. Cooling Tower Scaling\r\n4. Coil Supply Air Temperature Sensor Offset","created_at":"2016-06-02T21:09:06Z","updated_at":"2016-07-22T23:03:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05ac4e3e352b86da1bbcdc9cc48a207eee33f118","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/4","html_url":"https://github.com/NREL/EnergyPlus/milestones/EnergyPlus%208.6.0","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/4/labels","id":1634827,"number":4,"title":"EnergyPlus 8.6.0","description":"The EnergyPlus 8.6.0 public release at the end of FY16Q4.","creator":{"login":"mjwitte","id":4991075,"avatar_url":"https://avatars.githubusercontent.com/u/4991075?v=3","gravatar_id":"","url":"https://api.github.com/users/mjwitte","html_url":"https://github.com/mjwitte","followers_url":"https://api.github.com/users/mjwitte/followers","following_url":"https://api.github.com/users/mjwitte/following{/other_user}","gists_url":"https://api.github.com/users/mjwitte/gists{/gist_id}","starred_url":"https://api.github.com/users/mjwitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjwitte/subscriptions","organizations_url":"https://api.github.com/users/mjwitte/orgs","repos_url":"https://api.github.com/users/mjwitte/repos","events_url":"https://api.github.com/users/mjwitte/events{/privacy}","received_events_url":"https://api.github.com/users/mjwitte/received_events","type":"User","site_admin":false},"open_issues":154,"closed_issues":55,"state":"open","created_at":"2016-03-09T17:04:23Z","updated_at":"2016-07-22T16:34:06Z","due_on":"2016-09-30T05:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5705/commits","review_comments_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5705/comments","review_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5705/comments","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/8d52a5a89adf05c1d06170d555ff4a2247413d7c","head":{"label":"NREL:120694307_Fault_ChillerSWTSensorOffset","ref":"120694307_Fault_ChillerSWTSensorOffset","sha":"8d52a5a89adf05c1d06170d555ff4a2247413d7c","user":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":14620185,"name":"EnergyPlus","full_name":"NREL/EnergyPlus","owner":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NREL/EnergyPlus","description":"EnergyPlus™ is a whole building energy simulation program that engineers, architects, and researchers use to model both energy consumption and water use in buildings.","fork":false,"url":"https://api.github.com/repos/NREL/EnergyPlus","forks_url":"https://api.github.com/repos/NREL/EnergyPlus/forks","keys_url":"https://api.github.com/repos/NREL/EnergyPlus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/EnergyPlus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/EnergyPlus/teams","hooks_url":"https://api.github.com/repos/NREL/EnergyPlus/hooks","issue_events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/EnergyPlus/events","assignees_url":"https://api.github.com/repos/NREL/EnergyPlus/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/EnergyPlus/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/EnergyPlus/tags","blobs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/EnergyPlus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/EnergyPlus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/EnergyPlus/languages","stargazers_url":"https://api.github.com/repos/NREL/EnergyPlus/stargazers","contributors_url":"https://api.github.com/repos/NREL/EnergyPlus/contributors","subscribers_url":"https://api.github.com/repos/NREL/EnergyPlus/subscribers","subscription_url":"https://api.github.com/repos/NREL/EnergyPlus/subscription","commits_url":"https://api.github.com/repos/NREL/EnergyPlus/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/EnergyPlus/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments{/number}","contents_url":"https://api.github.com/repos/NREL/EnergyPlus/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/EnergyPlus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/EnergyPlus/merges","archive_url":"https://api.github.com/repos/NREL/EnergyPlus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/EnergyPlus/downloads","issues_url":"https://api.github.com/repos/NREL/EnergyPlus/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/EnergyPlus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/labels{/name}","releases_url":"https://api.github.com/repos/NREL/EnergyPlus/releases{/id}","deployments_url":"https://api.github.com/repos/NREL/EnergyPlus/deployments","created_at":"2013-11-22T14:47:34Z","updated_at":"2016-07-18T21:36:29Z","pushed_at":"2016-07-22T23:00:53Z","git_url":"git://github.com/NREL/EnergyPlus.git","ssh_url":"git@github.com:NREL/EnergyPlus.git","clone_url":"https://github.com/NREL/EnergyPlus.git","svn_url":"https://github.com/NREL/EnergyPlus","homepage":"https://energyplus.net","size":346360,"stargazers_count":114,"watchers_count":114,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":70,"mirror_url":null,"open_issues_count":446,"forks":70,"open_issues":446,"watchers":114,"default_branch":"develop"}},"base":{"label":"NREL:develop","ref":"develop","sha":"fda97739c19776c601e842555a58f61af6d86fb8","user":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":14620185,"name":"EnergyPlus","full_name":"NREL/EnergyPlus","owner":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NREL/EnergyPlus","description":"EnergyPlus™ is a whole building energy simulation program that engineers, architects, and researchers use to model both energy consumption and water use in buildings.","fork":false,"url":"https://api.github.com/repos/NREL/EnergyPlus","forks_url":"https://api.github.com/repos/NREL/EnergyPlus/forks","keys_url":"https://api.github.com/repos/NREL/EnergyPlus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/EnergyPlus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/EnergyPlus/teams","hooks_url":"https://api.github.com/repos/NREL/EnergyPlus/hooks","issue_events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/EnergyPlus/events","assignees_url":"https://api.github.com/repos/NREL/EnergyPlus/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/EnergyPlus/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/EnergyPlus/tags","blobs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/EnergyPlus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/EnergyPlus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/EnergyPlus/languages","stargazers_url":"https://api.github.com/repos/NREL/EnergyPlus/stargazers","contributors_url":"https://api.github.com/repos/NREL/EnergyPlus/contributors","subscribers_url":"https://api.github.com/repos/NREL/EnergyPlus/subscribers","subscription_url":"https://api.github.com/repos/NREL/EnergyPlus/subscription","commits_url":"https://api.github.com/repos/NREL/EnergyPlus/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/EnergyPlus/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments{/number}","contents_url":"https://api.github.com/repos/NREL/EnergyPlus/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/EnergyPlus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/EnergyPlus/merges","archive_url":"https://api.github.com/repos/NREL/EnergyPlus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/EnergyPlus/downloads","issues_url":"https://api.github.com/repos/NREL/EnergyPlus/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/EnergyPlus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/labels{/name}","releases_url":"https://api.github.com/repos/NREL/EnergyPlus/releases{/id}","deployments_url":"https://api.github.com/repos/NREL/EnergyPlus/deployments","created_at":"2013-11-22T14:47:34Z","updated_at":"2016-07-18T21:36:29Z","pushed_at":"2016-07-22T23:00:53Z","git_url":"git://github.com/NREL/EnergyPlus.git","ssh_url":"git@github.com:NREL/EnergyPlus.git","clone_url":"https://github.com/NREL/EnergyPlus.git","svn_url":"https://github.com/NREL/EnergyPlus","homepage":"https://energyplus.net","size":346360,"stargazers_count":114,"watchers_count":114,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":70,"mirror_url":null,"open_issues_count":446,"forks":70,"open_issues":446,"watchers":114,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5705"},"html":{"href":"https://github.com/NREL/EnergyPlus/pull/5705"},"issue":{"href":"https://api.github.com/repos/NREL/EnergyPlus/issues/5705"},"comments":{"href":"https://api.github.com/repos/NREL/EnergyPlus/issues/5705/comments"},"review_comments":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5705/comments"},"review_comment":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5705/commits"},"statuses":{"href":"https://api.github.com/repos/NREL/EnergyPlus/statuses/8d52a5a89adf05c1d06170d555ff4a2247413d7c"}}}}
{"actor":{"display_login":"rongpengzhang"}}