{"action":"closed","issue":{"url":"https://api.github.com/repos/asteris-llc/converge/issues/395","repository_url":"https://api.github.com/repos/asteris-llc/converge","labels_url":"https://api.github.com/repos/asteris-llc/converge/issues/395/labels{/name}","comments_url":"https://api.github.com/repos/asteris-llc/converge/issues/395/comments","events_url":"https://api.github.com/repos/asteris-llc/converge/issues/395/events","html_url":"https://github.com/asteris-llc/converge/issues/395","id":183842154,"number":395,"title":"module dependencies now failing","user":{"login":"ryane","id":7346,"avatar_url":"https://avatars.githubusercontent.com/u/7346?v=3","gravatar_id":"","url":"https://api.github.com/users/ryane","html_url":"https://github.com/ryane","followers_url":"https://api.github.com/users/ryane/followers","following_url":"https://api.github.com/users/ryane/following{/other_user}","gists_url":"https://api.github.com/users/ryane/gists{/gist_id}","starred_url":"https://api.github.com/users/ryane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryane/subscriptions","organizations_url":"https://api.github.com/users/ryane/orgs","repos_url":"https://api.github.com/users/ryane/repos","events_url":"https://api.github.com/users/ryane/events{/privacy}","received_events_url":"https://api.github.com/users/ryane/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/asteris-llc/converge/labels/bug","name":"bug","color":"ee0701"}],"state":"closed","locked":false,"assignee":{"login":"rebeccaskinner","id":203691,"avatar_url":"https://avatars.githubusercontent.com/u/203691?v=3","gravatar_id":"","url":"https://api.github.com/users/rebeccaskinner","html_url":"https://github.com/rebeccaskinner","followers_url":"https://api.github.com/users/rebeccaskinner/followers","following_url":"https://api.github.com/users/rebeccaskinner/following{/other_user}","gists_url":"https://api.github.com/users/rebeccaskinner/gists{/gist_id}","starred_url":"https://api.github.com/users/rebeccaskinner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebeccaskinner/subscriptions","organizations_url":"https://api.github.com/users/rebeccaskinner/orgs","repos_url":"https://api.github.com/users/rebeccaskinner/repos","events_url":"https://api.github.com/users/rebeccaskinner/events{/privacy}","received_events_url":"https://api.github.com/users/rebeccaskinner/received_events","type":"User","site_admin":false},"assignees":[{"login":"rebeccaskinner","id":203691,"avatar_url":"https://avatars.githubusercontent.com/u/203691?v=3","gravatar_id":"","url":"https://api.github.com/users/rebeccaskinner","html_url":"https://github.com/rebeccaskinner","followers_url":"https://api.github.com/users/rebeccaskinner/followers","following_url":"https://api.github.com/users/rebeccaskinner/following{/other_user}","gists_url":"https://api.github.com/users/rebeccaskinner/gists{/gist_id}","starred_url":"https://api.github.com/users/rebeccaskinner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebeccaskinner/subscriptions","organizations_url":"https://api.github.com/users/rebeccaskinner/orgs","repos_url":"https://api.github.com/users/rebeccaskinner/repos","events_url":"https://api.github.com/users/rebeccaskinner/events{/privacy}","received_events_url":"https://api.github.com/users/rebeccaskinner/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-10-19T01:14:45Z","updated_at":"2016-10-19T13:01:21Z","closed_at":"2016-10-19T13:01:21Z","body":"At some point adding a dependency on a module has stopped working. On master, I noticed that the elk example was no longer working:\r\n\r\n```shell\r\n$ ./converge graph --local examples/elk/converge/elk.hcl\r\n2016-10-18T21:05:09-04:00 |INFO| serving        addr=:47740 component=rpc\r\n2016-10-18T21:05:09-04:00 |ERROR| could not load        component=rpc error=could not resolve dependencies: 4 error(s) occurred:\r\n\r\n* root/docker.image.elasticsearch-image: nonexistent vertices in edges: module.docker\r\n* root/task.filebeat-install: nonexistent vertices in edges: module.docker\r\n* root/module.docker: nonexistent vertices in edges: module.packages\r\n...\r\n```\r\n\r\nHere is a simple repro:\r\n\r\nmoduleTest.hcl:\r\n\r\n```hcl\r\nmodule \"submoduleTest.hcl\" \"submodule\" {}\r\n\r\ntask \"file\" {\r\n  check   = \"test -f file.txt\"\r\n  apply   = \"touch file.txt\"\r\n  depends = [\"module.submodule\"]\r\n}\r\n```\r\n\r\nsubmoduleTest.hcl:\r\n\r\n```hcl\r\ntask \"another-file\" {\r\n  check = \"test -f first-file.txt\"\r\n  apply = \"touch first-file.txt\"\r\n}\r\n```\r\n\r\n```shell\r\n$ ./converge graph --local samples/moduleTest.hcl\r\n2016-10-18T21:07:16-04:00 |INFO| serving        addr=:47740 component=rpc\r\n2016-10-18T21:07:16-04:00 |ERROR| could not load        component=rpc error=could not resolve dependencies: 1 error(s) occurred:\r\n\r\n* root/task.file: nonexistent vertices in edges: module.submodule location=samples/moduleTest.hcl runID=08008907-4a0d-4fd9-ae39-12cf403319f4\r\n2016-10-18T21:07:16-04:00 |ERROR| loading failed        component=rpc error=loading samples/moduleTest.hcl: could not resolve dependencies: 1 error(s) occurred:\r\n\r\n* root/task.file: nonexistent vertices in edges: module.submodule function=grapher.Graph runID=08008907-4a0d-4fd9-ae39-12cf403319f4\r\n2016-10-18T21:07:16-04:00 |FATAL| could not get graph   component=client error=error getting graph component: rpc error: code = 2 desc = loading failed: loading samples/moduleTest.hcl: could not resolve dependencies: 1 error(s) occurred:\r\n\r\n* root/task.file: nonexistent vertices in edges: module.submodule file=samples/moduleTest.hcl\r\n```\r\n\r\nThis hcl works with converge 0.2.0:\r\n\r\n```shell\r\n$ ./converge-0.2.0 graph --local samples/moduleTest.hcl\r\n2016-10-18T21:10:57-04:00 |INFO| serving        addr=:47740 component=rpc\r\ndigraph {\r\n\r\nsubgraph cluster_0 {\r\n\"root\" [ label=\"Module: /\" ];\r\n\"root/task.file\" [ shape=\"component\" , label=\"task.file\" ];\r\n}\r\nsubgraph cluster_1 {\r\n\"root/module.submodule\" [ label=\"Module: module.submodule\" ];\r\n\"root/module.submodule/task.another-file\" [ shape=\"component\" , label=\"module.submodule/task.another-file\" ];\r\n}\r\n\"root\" -> \"root/module.submodule\" [ label=\"\" ];\r\n\"root\" -> \"root/task.file\" [ label=\"\" ];\r\n\"root/module.submodule\" -> \"root/module.submodule/task.another-file\" [ label=\"\" ];\r\n\"root/task.file\" -> \"root/module.submodule\" [ label=\"\" ];\r\n}\r\n```\r\n\r\n"}}
{"actor":{"display_login":"ryane"}}