{"action":"created","issue":{"url":"https://api.github.com/repos/mediachain/mediachain-client/issues/46","repository_url":"https://api.github.com/repos/mediachain/mediachain-client","labels_url":"https://api.github.com/repos/mediachain/mediachain-client/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/mediachain/mediachain-client/issues/46/comments","events_url":"https://api.github.com/repos/mediachain/mediachain-client/issues/46/events","html_url":"https://github.com/mediachain/mediachain-client/pull/46","id":164181533,"number":46,"title":"git tag based versioning","user":{"login":"yusefnapora","id":678715,"avatar_url":"https://avatars.githubusercontent.com/u/678715?v=3","gravatar_id":"","url":"https://api.github.com/users/yusefnapora","html_url":"https://github.com/yusefnapora","followers_url":"https://api.github.com/users/yusefnapora/followers","following_url":"https://api.github.com/users/yusefnapora/following{/other_user}","gists_url":"https://api.github.com/users/yusefnapora/gists{/gist_id}","starred_url":"https://api.github.com/users/yusefnapora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yusefnapora/subscriptions","organizations_url":"https://api.github.com/users/yusefnapora/orgs","repos_url":"https://api.github.com/users/yusefnapora/repos","events_url":"https://api.github.com/users/yusefnapora/events{/privacy}","received_events_url":"https://api.github.com/users/yusefnapora/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-07-06T21:42:32Z","updated_at":"2016-07-06T21:59:22Z","closed_at":"2016-07-06T21:58:05Z","pull_request":{"url":"https://api.github.com/repos/mediachain/mediachain-client/pulls/46","html_url":"https://github.com/mediachain/mediachain-client/pull/46","diff_url":"https://github.com/mediachain/mediachain-client/pull/46.diff","patch_url":"https://github.com/mediachain/mediachain-client/pull/46.patch"},"body":"This adds some cruft to the repo from the [versioneer tool](https://github.com/warner/python-versioneer) - I'm not crazy about putting all of this in the repo.  But so far I haven't found a light-weight solution to tag-based versioning in python without rolling our own tool...\r\n\r\nAnyway, the basic gist is that setup.py calls out to the versioneer code, which determines the version number based on git tags.  If you're on a tag starting with `v`, it will use that as the version number (minus the `v` prefix).  If you're a few commits past the tag, it will produce a pep440 compatible \"local version\" string, e.g. `0.1.0+1.g988d850`  which is one commit past the `v0.1.0` tag, on sha `988d850`.\r\n\r\nThose local versions can't be uploaded to pypi, but we could potentially put them on our own package index (maybe [on s3](https://novemberfive.co/blog/opensource-pypi-package-repository-tutorial/)?) for our automated e2e testing scheme...\r\n\r\nI'm happy to park this if there are strong objections to cluttering up the repo like this; we can manually bump the version while we look for a less invasive tool."},"comment":{"url":"https://api.github.com/repos/mediachain/mediachain-client/issues/comments/230920125","html_url":"https://github.com/mediachain/mediachain-client/pull/46#issuecomment-230920125","issue_url":"https://api.github.com/repos/mediachain/mediachain-client/issues/46","id":230920125,"user":{"login":"parkan","id":204986,"avatar_url":"https://avatars.githubusercontent.com/u/204986?v=3","gravatar_id":"","url":"https://api.github.com/users/parkan","html_url":"https://github.com/parkan","followers_url":"https://api.github.com/users/parkan/followers","following_url":"https://api.github.com/users/parkan/following{/other_user}","gists_url":"https://api.github.com/users/parkan/gists{/gist_id}","starred_url":"https://api.github.com/users/parkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkan/subscriptions","organizations_url":"https://api.github.com/users/parkan/orgs","repos_url":"https://api.github.com/users/parkan/repos","events_url":"https://api.github.com/users/parkan/events{/privacy}","received_events_url":"https://api.github.com/users/parkan/received_events","type":"User","site_admin":false},"created_at":"2016-07-06T21:59:22Z","updated_at":"2016-07-06T21:59:22Z","body":"BTW here's the Official Python Way™ of versioning stuff, which is predictably a little wacky:\r\n\r\nhttps://www.python.org/dev/peps/pep-0386/#the-new-versioning-algorithm"}}
{"actor":{"display_login":"parkan"}}