{"action":"opened","issue":{"url":"https://api.github.com/repos/irvingmike/IRV-Project/issues/2","repository_url":"https://api.github.com/repos/irvingmike/IRV-Project","labels_url":"https://api.github.com/repos/irvingmike/IRV-Project/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/irvingmike/IRV-Project/issues/2/comments","events_url":"https://api.github.com/repos/irvingmike/IRV-Project/issues/2/events","html_url":"https://github.com/irvingmike/IRV-Project/issues/2","id":184323103,"number":2,"title":"Code Review 2 by TK","user":{"login":"tkinsman","id":10838249,"avatar_url":"https://avatars.githubusercontent.com/u/10838249?v=3","gravatar_id":"","url":"https://api.github.com/users/tkinsman","html_url":"https://github.com/tkinsman","followers_url":"https://api.github.com/users/tkinsman/followers","following_url":"https://api.github.com/users/tkinsman/following{/other_user}","gists_url":"https://api.github.com/users/tkinsman/gists{/gist_id}","starred_url":"https://api.github.com/users/tkinsman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkinsman/subscriptions","organizations_url":"https://api.github.com/users/tkinsman/orgs","repos_url":"https://api.github.com/users/tkinsman/repos","events_url":"https://api.github.com/users/tkinsman/events{/privacy}","received_events_url":"https://api.github.com/users/tkinsman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-10-20T19:47:06Z","updated_at":"2016-10-20T19:47:06Z","closed_at":null,"body":"# Design/Code Review 2\r\n\r\n## Project: Instant Run-off\r\n\r\n### Developer: Aaron Anderson\r\n\r\n#### Reviewer: Todd Kinsman\r\n\r\n|Category|Criteria|Analysis/Comments|\r\n|--------|---------|---------------|\r\n|**Running application**|| |\r\n||Describe the application functionality that has been built and is working.|An easy way to create a runoff election |\r\n||What is good?| Well thought out ui and style. A good amount of code is written with great security considerations |\r\n||What could be improved?| Keep at it. If the password security keeps delaying you then I would put it on the back burner; although, with the amount of progress you've made so far, it's not going to hurt you to work on it. |\r\n|**Unit Tests**|| |\r\n||What are the code coverage statistics?| | \r\n||Are @Before/@BeforeClass/@After/@AfterClass used to reduce redundant code?| Looks good so far | \r\n|**JSPs**|| |\r\n|| Is templating used to eliminate rundandant code(for example, header.jsp, footer.jsp, etc.)| Didn't go into detail on this. |\r\n||What is good?| Again, the style is amazing. Great user experience and the templating is a nice advantage for the developer  |\r\n||What could be improved?| |\r\n|**Code quality**|| |\r\n||Are methods single-purpose?| Yes. |\r\n||Are classes appropriately-sized classes (no monster classes)?| Yes. |\r\n||Are the same lines of code repeated at all?| Nope. | \r\n||Do any classes perform very similar functions that could be candidates for super/subclass relationships?| The generic dao helped with this. |\r\n||Are any values hard-coded that should be in a properties file?| Not that I noticed |\r\n||Are variable names descriptive?| Yes. |\r\n||Are there many branches or loops that could be simplified or broken up into smaller methods?| So far so good. |\r\n||Do the DAOs use Hibernate? No hard-coded sql!| Uses hibernate. Talked about updating the sqlQuery to be similar to setting password |\r\n||Has log4J been added?| Yes |\r\n||Are there logging statements in the code?| Yes |\r\n||Are appropriate logging levels used? Info, debug, error, for example.| Yes |\r\n||Are there any System.out.printlns in the code?| No. |\r\n||Other comments/notes?| Looks well thought out. |\r\n|**Web Service/API integration**|Which web service/api is being used? | Built his own. |\r\n||Is the integration built?| Working on it. |\r\n|| If so, evaluate the integration code. What is good? What could use improvement?\r\n|**Independent research topic**| What is the developer's independent research topic?| |\r\n||Has the topic been implemented in the project?| Yes, SASS. |\r\n||If so, evaluate the implementation. What is good? What could use improvement?| Organized well by using includes/partials |\r\n|**Key takeaways**|List at least 3 things you learned while reviewing this project that will help you in your own project.| Better way for queries in Hibernate. Aaron is a design all-star. Generic daos will be helpful for repetitive code. |"}}
{"actor":{"display_login":"tkinsman"}}