{"action":"created","comment":{"url":"https://api.github.com/repos/collectd/collectd/pulls/comments/90017771","pull_request_review_id":10543273,"id":90017771,"diff_hunk":"@@ -559,9 +581,9 @@ static int qos_filter_cb (const struct nlmsghdr *nlh, void *args)\n       return MNL_CB_ERROR;\n     }\n \n-    mnl_attr_parse_nested (attr, qos_attr_cb, &bs);\n+    mnl_attr_parse_nested (attr, qos_attr_cb, &q_stats);\n \n-    if (bs != NULL)\n+    if (bs != NULL || qs != NULL)","path":"src/netlink.c","position":70,"original_position":70,"commit_id":"f968d9c6dde0fcc45753227e98f66903f73407db","original_commit_id":"f968d9c6dde0fcc45753227e98f66903f73407db","user":{"login":"octo","id":116087,"avatar_url":"https://avatars.githubusercontent.com/u/116087?v=3","gravatar_id":"","url":"https://api.github.com/users/octo","html_url":"https://github.com/octo","followers_url":"https://api.github.com/users/octo/followers","following_url":"https://api.github.com/users/octo/following{/other_user}","gists_url":"https://api.github.com/users/octo/gists{/gist_id}","starred_url":"https://api.github.com/users/octo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octo/subscriptions","organizations_url":"https://api.github.com/users/octo/orgs","repos_url":"https://api.github.com/users/octo/repos","events_url":"https://api.github.com/users/octo/events{/privacy}","received_events_url":"https://api.github.com/users/octo/received_events","type":"User","site_admin":false},"body":"Both, `bs` and `qs` will *always* be `NULL`. You need to check `q_stats.bs` and `q_stats.qs` here. The `bs` and `qs` variables are unused and can be deleted.","created_at":"2016-11-29T14:24:39Z","updated_at":"2016-11-29T14:29:31Z","html_url":"https://github.com/collectd/collectd/pull/2053#discussion_r90017771","pull_request_url":"https://api.github.com/repos/collectd/collectd/pulls/2053","_links":{"self":{"href":"https://api.github.com/repos/collectd/collectd/pulls/comments/90017771"},"html":{"href":"https://github.com/collectd/collectd/pull/2053#discussion_r90017771"},"pull_request":{"href":"https://api.github.com/repos/collectd/collectd/pulls/2053"}}},"pull_request":{"url":"https://api.github.com/repos/collectd/collectd/pulls/2053","id":95103986,"html_url":"https://github.com/collectd/collectd/pull/2053","diff_url":"https://github.com/collectd/collectd/pull/2053.diff","patch_url":"https://github.com/collectd/collectd/pull/2053.patch","issue_url":"https://api.github.com/repos/collectd/collectd/issues/2053","number":2053,"state":"open","locked":false,"title":"netlink plugin: Adding support of drops value monitoring","user":{"login":"nuclearcat","id":1076310,"avatar_url":"https://avatars.githubusercontent.com/u/1076310?v=3","gravatar_id":"","url":"https://api.github.com/users/nuclearcat","html_url":"https://github.com/nuclearcat","followers_url":"https://api.github.com/users/nuclearcat/followers","following_url":"https://api.github.com/users/nuclearcat/following{/other_user}","gists_url":"https://api.github.com/users/nuclearcat/gists{/gist_id}","starred_url":"https://api.github.com/users/nuclearcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuclearcat/subscriptions","organizations_url":"https://api.github.com/users/nuclearcat/orgs","repos_url":"https://api.github.com/users/nuclearcat/repos","events_url":"https://api.github.com/users/nuclearcat/events{/privacy}","received_events_url":"https://api.github.com/users/nuclearcat/received_events","type":"User","site_admin":false},"body":"Monitoring drops is very handy to see drop rate of qdisc/class (to adjust length of queue and to estimate how much data are exceeding limit), and in some cases to limit interface drops that doesn't reach ethstat and other statistics.\r\n","created_at":"2016-11-24T01:23:05Z","updated_at":"2016-11-29T14:29:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f693c71d25e82a4f7c2bf93eea176d49efebea8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/collectd/collectd/pulls/2053/commits","review_comments_url":"https://api.github.com/repos/collectd/collectd/pulls/2053/comments","review_comment_url":"https://api.github.com/repos/collectd/collectd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/collectd/collectd/issues/2053/comments","statuses_url":"https://api.github.com/repos/collectd/collectd/statuses/f968d9c6dde0fcc45753227e98f66903f73407db","head":{"label":"nuclearcat:master","ref":"master","sha":"f968d9c6dde0fcc45753227e98f66903f73407db","user":{"login":"nuclearcat","id":1076310,"avatar_url":"https://avatars.githubusercontent.com/u/1076310?v=3","gravatar_id":"","url":"https://api.github.com/users/nuclearcat","html_url":"https://github.com/nuclearcat","followers_url":"https://api.github.com/users/nuclearcat/followers","following_url":"https://api.github.com/users/nuclearcat/following{/other_user}","gists_url":"https://api.github.com/users/nuclearcat/gists{/gist_id}","starred_url":"https://api.github.com/users/nuclearcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuclearcat/subscriptions","organizations_url":"https://api.github.com/users/nuclearcat/orgs","repos_url":"https://api.github.com/users/nuclearcat/repos","events_url":"https://api.github.com/users/nuclearcat/events{/privacy}","received_events_url":"https://api.github.com/users/nuclearcat/received_events","type":"User","site_admin":false},"repo":{"id":74626733,"name":"collectd","full_name":"nuclearcat/collectd","owner":{"login":"nuclearcat","id":1076310,"avatar_url":"https://avatars.githubusercontent.com/u/1076310?v=3","gravatar_id":"","url":"https://api.github.com/users/nuclearcat","html_url":"https://github.com/nuclearcat","followers_url":"https://api.github.com/users/nuclearcat/followers","following_url":"https://api.github.com/users/nuclearcat/following{/other_user}","gists_url":"https://api.github.com/users/nuclearcat/gists{/gist_id}","starred_url":"https://api.github.com/users/nuclearcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuclearcat/subscriptions","organizations_url":"https://api.github.com/users/nuclearcat/orgs","repos_url":"https://api.github.com/users/nuclearcat/repos","events_url":"https://api.github.com/users/nuclearcat/events{/privacy}","received_events_url":"https://api.github.com/users/nuclearcat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nuclearcat/collectd","description":"The system statistics collection daemon. Please send Pull Requests here!","fork":true,"url":"https://api.github.com/repos/nuclearcat/collectd","forks_url":"https://api.github.com/repos/nuclearcat/collectd/forks","keys_url":"https://api.github.com/repos/nuclearcat/collectd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nuclearcat/collectd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nuclearcat/collectd/teams","hooks_url":"https://api.github.com/repos/nuclearcat/collectd/hooks","issue_events_url":"https://api.github.com/repos/nuclearcat/collectd/issues/events{/number}","events_url":"https://api.github.com/repos/nuclearcat/collectd/events","assignees_url":"https://api.github.com/repos/nuclearcat/collectd/assignees{/user}","branches_url":"https://api.github.com/repos/nuclearcat/collectd/branches{/branch}","tags_url":"https://api.github.com/repos/nuclearcat/collectd/tags","blobs_url":"https://api.github.com/repos/nuclearcat/collectd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nuclearcat/collectd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nuclearcat/collectd/git/refs{/sha}","trees_url":"https://api.github.com/repos/nuclearcat/collectd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nuclearcat/collectd/statuses/{sha}","languages_url":"https://api.github.com/repos/nuclearcat/collectd/languages","stargazers_url":"https://api.github.com/repos/nuclearcat/collectd/stargazers","contributors_url":"https://api.github.com/repos/nuclearcat/collectd/contributors","subscribers_url":"https://api.github.com/repos/nuclearcat/collectd/subscribers","subscription_url":"https://api.github.com/repos/nuclearcat/collectd/subscription","commits_url":"https://api.github.com/repos/nuclearcat/collectd/commits{/sha}","git_commits_url":"https://api.github.com/repos/nuclearcat/collectd/git/commits{/sha}","comments_url":"https://api.github.com/repos/nuclearcat/collectd/comments{/number}","issue_comment_url":"https://api.github.com/repos/nuclearcat/collectd/issues/comments{/number}","contents_url":"https://api.github.com/repos/nuclearcat/collectd/contents/{+path}","compare_url":"https://api.github.com/repos/nuclearcat/collectd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nuclearcat/collectd/merges","archive_url":"https://api.github.com/repos/nuclearcat/collectd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nuclearcat/collectd/downloads","issues_url":"https://api.github.com/repos/nuclearcat/collectd/issues{/number}","pulls_url":"https://api.github.com/repos/nuclearcat/collectd/pulls{/number}","milestones_url":"https://api.github.com/repos/nuclearcat/collectd/milestones{/number}","notifications_url":"https://api.github.com/repos/nuclearcat/collectd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nuclearcat/collectd/labels{/name}","releases_url":"https://api.github.com/repos/nuclearcat/collectd/releases{/id}","deployments_url":"https://api.github.com/repos/nuclearcat/collectd/deployments","created_at":"2016-11-24T01:17:16Z","updated_at":"2016-11-24T01:17:20Z","pushed_at":"2016-11-29T00:28:49Z","git_url":"git://github.com/nuclearcat/collectd.git","ssh_url":"git@github.com:nuclearcat/collectd.git","clone_url":"https://github.com/nuclearcat/collectd.git","svn_url":"https://github.com/nuclearcat/collectd","homepage":"http://collectd.org/","size":15363,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"collectd:master","ref":"master","sha":"737f89c19e7e786aaeae1663a47e6fbddf394dcf","user":{"login":"collectd","id":1027481,"avatar_url":"https://avatars.githubusercontent.com/u/1027481?v=3","gravatar_id":"","url":"https://api.github.com/users/collectd","html_url":"https://github.com/collectd","followers_url":"https://api.github.com/users/collectd/followers","following_url":"https://api.github.com/users/collectd/following{/other_user}","gists_url":"https://api.github.com/users/collectd/gists{/gist_id}","starred_url":"https://api.github.com/users/collectd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collectd/subscriptions","organizations_url":"https://api.github.com/users/collectd/orgs","repos_url":"https://api.github.com/users/collectd/repos","events_url":"https://api.github.com/users/collectd/events{/privacy}","received_events_url":"https://api.github.com/users/collectd/received_events","type":"Organization","site_admin":false},"repo":{"id":3208640,"name":"collectd","full_name":"collectd/collectd","owner":{"login":"collectd","id":1027481,"avatar_url":"https://avatars.githubusercontent.com/u/1027481?v=3","gravatar_id":"","url":"https://api.github.com/users/collectd","html_url":"https://github.com/collectd","followers_url":"https://api.github.com/users/collectd/followers","following_url":"https://api.github.com/users/collectd/following{/other_user}","gists_url":"https://api.github.com/users/collectd/gists{/gist_id}","starred_url":"https://api.github.com/users/collectd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collectd/subscriptions","organizations_url":"https://api.github.com/users/collectd/orgs","repos_url":"https://api.github.com/users/collectd/repos","events_url":"https://api.github.com/users/collectd/events{/privacy}","received_events_url":"https://api.github.com/users/collectd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/collectd/collectd","description":"The system statistics collection daemon. Please send Pull Requests here!","fork":false,"url":"https://api.github.com/repos/collectd/collectd","forks_url":"https://api.github.com/repos/collectd/collectd/forks","keys_url":"https://api.github.com/repos/collectd/collectd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/collectd/collectd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/collectd/collectd/teams","hooks_url":"https://api.github.com/repos/collectd/collectd/hooks","issue_events_url":"https://api.github.com/repos/collectd/collectd/issues/events{/number}","events_url":"https://api.github.com/repos/collectd/collectd/events","assignees_url":"https://api.github.com/repos/collectd/collectd/assignees{/user}","branches_url":"https://api.github.com/repos/collectd/collectd/branches{/branch}","tags_url":"https://api.github.com/repos/collectd/collectd/tags","blobs_url":"https://api.github.com/repos/collectd/collectd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/collectd/collectd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/collectd/collectd/git/refs{/sha}","trees_url":"https://api.github.com/repos/collectd/collectd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/collectd/collectd/statuses/{sha}","languages_url":"https://api.github.com/repos/collectd/collectd/languages","stargazers_url":"https://api.github.com/repos/collectd/collectd/stargazers","contributors_url":"https://api.github.com/repos/collectd/collectd/contributors","subscribers_url":"https://api.github.com/repos/collectd/collectd/subscribers","subscription_url":"https://api.github.com/repos/collectd/collectd/subscription","commits_url":"https://api.github.com/repos/collectd/collectd/commits{/sha}","git_commits_url":"https://api.github.com/repos/collectd/collectd/git/commits{/sha}","comments_url":"https://api.github.com/repos/collectd/collectd/comments{/number}","issue_comment_url":"https://api.github.com/repos/collectd/collectd/issues/comments{/number}","contents_url":"https://api.github.com/repos/collectd/collectd/contents/{+path}","compare_url":"https://api.github.com/repos/collectd/collectd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/collectd/collectd/merges","archive_url":"https://api.github.com/repos/collectd/collectd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/collectd/collectd/downloads","issues_url":"https://api.github.com/repos/collectd/collectd/issues{/number}","pulls_url":"https://api.github.com/repos/collectd/collectd/pulls{/number}","milestones_url":"https://api.github.com/repos/collectd/collectd/milestones{/number}","notifications_url":"https://api.github.com/repos/collectd/collectd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/collectd/collectd/labels{/name}","releases_url":"https://api.github.com/repos/collectd/collectd/releases{/id}","deployments_url":"https://api.github.com/repos/collectd/collectd/deployments","created_at":"2012-01-18T13:07:51Z","updated_at":"2016-11-29T14:12:02Z","pushed_at":"2016-11-29T14:06:31Z","git_url":"git://github.com/collectd/collectd.git","ssh_url":"git@github.com:collectd/collectd.git","clone_url":"https://github.com/collectd/collectd.git","svn_url":"https://github.com/collectd/collectd","homepage":"http://collectd.org/","size":36476,"stargazers_count":1354,"watchers_count":1354,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":757,"mirror_url":null,"open_issues_count":313,"forks":757,"open_issues":313,"watchers":1354,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/collectd/collectd/pulls/2053"},"html":{"href":"https://github.com/collectd/collectd/pull/2053"},"issue":{"href":"https://api.github.com/repos/collectd/collectd/issues/2053"},"comments":{"href":"https://api.github.com/repos/collectd/collectd/issues/2053/comments"},"review_comments":{"href":"https://api.github.com/repos/collectd/collectd/pulls/2053/comments"},"review_comment":{"href":"https://api.github.com/repos/collectd/collectd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/collectd/collectd/pulls/2053/commits"},"statuses":{"href":"https://api.github.com/repos/collectd/collectd/statuses/f968d9c6dde0fcc45753227e98f66903f73407db"}}}}
{"actor":{"display_login":"octo"}}