{"action":"created","issue":{"url":"https://api.github.com/repos/inveniosoftware/invenio-deposit/issues/147","repository_url":"https://api.github.com/repos/inveniosoftware/invenio-deposit","labels_url":"https://api.github.com/repos/inveniosoftware/invenio-deposit/issues/147/labels{/name}","comments_url":"https://api.github.com/repos/inveniosoftware/invenio-deposit/issues/147/comments","events_url":"https://api.github.com/repos/inveniosoftware/invenio-deposit/issues/147/events","html_url":"https://github.com/inveniosoftware/invenio-deposit/issues/147","id":187062795,"number":147,"title":"global: Reenable dynamic JSON-Schemas.","user":{"login":"nharraud","id":5708796,"avatar_url":"https://avatars.githubusercontent.com/u/5708796?v=3","gravatar_id":"","url":"https://api.github.com/users/nharraud","html_url":"https://github.com/nharraud","followers_url":"https://api.github.com/users/nharraud/followers","following_url":"https://api.github.com/users/nharraud/following{/other_user}","gists_url":"https://api.github.com/users/nharraud/gists{/gist_id}","starred_url":"https://api.github.com/users/nharraud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nharraud/subscriptions","organizations_url":"https://api.github.com/users/nharraud/orgs","repos_url":"https://api.github.com/users/nharraud/repos","events_url":"https://api.github.com/users/nharraud/events{/privacy}","received_events_url":"https://api.github.com/users/nharraud/received_events","type":"User","site_admin":false},"labels":[{"id":473691029,"url":"https://api.github.com/repos/inveniosoftware/invenio-deposit/labels/Service:%20B2SHARE","name":"Service: B2SHARE","color":"207de5","default":false},{"id":414887305,"url":"https://api.github.com/repos/inveniosoftware/invenio-deposit/labels/Type:%20RFC","name":"Type: RFC","color":"ffaa00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/inveniosoftware/invenio-deposit/milestones/6","html_url":"https://github.com/inveniosoftware/invenio-deposit/milestones/v1.0.0","labels_url":"https://api.github.com/repos/inveniosoftware/invenio-deposit/milestones/6/labels","id":1681326,"number":6,"title":"v1.0.0","description":null,"creator":{"login":"jirikuncar","id":189798,"avatar_url":"https://avatars.githubusercontent.com/u/189798?v=3","gravatar_id":"","url":"https://api.github.com/users/jirikuncar","html_url":"https://github.com/jirikuncar","followers_url":"https://api.github.com/users/jirikuncar/followers","following_url":"https://api.github.com/users/jirikuncar/following{/other_user}","gists_url":"https://api.github.com/users/jirikuncar/gists{/gist_id}","starred_url":"https://api.github.com/users/jirikuncar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jirikuncar/subscriptions","organizations_url":"https://api.github.com/users/jirikuncar/orgs","repos_url":"https://api.github.com/users/jirikuncar/repos","events_url":"https://api.github.com/users/jirikuncar/events{/privacy}","received_events_url":"https://api.github.com/users/jirikuncar/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":30,"state":"open","created_at":"2016-04-04T08:48:59Z","updated_at":"2016-11-03T13:42:50Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-11-03T13:42:50Z","updated_at":"2016-11-03T14:00:44Z","closed_at":null,"body":"**Problem:**\r\nNot all services have their JSON Schemas coming from files or one JSON Schema per type of PID.\r\nHowever with [the last modification enabling \"multiple deposits per site\"](https://github.com/inveniosoftware/invenio-deposit/commit/d5e53c0d9e7976f4229063f3a57e7d499514a24b) we started tying together endpoints and JSON Schemas.\r\n\r\n**Who needs it:**\r\nB2Share as it has only one endpoint but multiple JSON Schemas, one per community. The last changes should not impact B2Share for now as it does not use the UI, but this is a dangerous direction for us."},"comment":{"url":"https://api.github.com/repos/inveniosoftware/invenio-deposit/issues/comments/258150126","html_url":"https://github.com/inveniosoftware/invenio-deposit/issues/147#issuecomment-258150126","issue_url":"https://api.github.com/repos/inveniosoftware/invenio-deposit/issues/147","id":258150126,"user":{"login":"nharraud","id":5708796,"avatar_url":"https://avatars.githubusercontent.com/u/5708796?v=3","gravatar_id":"","url":"https://api.github.com/users/nharraud","html_url":"https://github.com/nharraud","followers_url":"https://api.github.com/users/nharraud/followers","following_url":"https://api.github.com/users/nharraud/following{/other_user}","gists_url":"https://api.github.com/users/nharraud/gists{/gist_id}","starred_url":"https://api.github.com/users/nharraud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nharraud/subscriptions","organizations_url":"https://api.github.com/users/nharraud/orgs","repos_url":"https://api.github.com/users/nharraud/repos","events_url":"https://api.github.com/users/nharraud/events{/privacy}","received_events_url":"https://api.github.com/users/nharraud/received_events","type":"User","site_admin":false},"created_at":"2016-11-03T14:00:44Z","updated_at":"2016-11-03T14:00:44Z","body":"As we don't have specifications, code is the specifications.\r\nCurrent code says that [there is a deposit type and this type defines the JSON-Schemas](https://github.com/inveniosoftware/invenio-deposit/commit/d5e53c0d9e7976f4229063f3a57e7d499514a24b#diff-6ba763ae4d9076326366ad8f2a69ff8bR86).\r\n\r\nIf this is used in the REST API later, we can't derive the JSON-Schema from the provided metadata anymore. Thus it is not blocking us now as we don't use the UI, but it is a dangerous specification if extended to the REST API.\r\n\r\nMaybe we could provide functions instead which would be in charge of retrieving the JSON-Schema. They would retrieve `request.values.get('type')` themselves."}}
{"actor":{"display_login":"nharraud"}}