{"action":"created","comment":{"url":"https://api.github.com/repos/paparazzi/paparazzi/pulls/comments/67176519","id":67176519,"diff_hunk":"@@ -54,13 +57,22 @@ extern void tcas_init(void);\n extern void tcas_periodic_task_1Hz(void);\n extern void tcas_periodic_task_4Hz(void);\n \n-#define CallTCAS() { if (tcas_status == TCAS_RA) v_ctl_altitude_setpoint = tcas_alt_setpoint; }\n+extern void callTCAS(void);\n \n-#define ParseTcasResolve() { \\\n-    if (DL_TCAS_RESOLVE_ac_id(dl_buffer) == AC_ID) { \\\n-      uint8_t ac_id_conflict = DL_TCAS_RESOLVE_ac_id_conflict(dl_buffer); \\\n-      tcas_acs_status[the_acs_id[ac_id_conflict]].resolve = DL_TCAS_RESOLVE_resolve(dl_buffer); \\\n-    } \\\n+static inline void parseTcasResolve(void)","path":"sw/airborne/modules/multi/tcas.h","position":24,"original_position":24,"commit_id":"7174ad8543d1bdf594680adca5f0d6470b18d765","original_commit_id":"7174ad8543d1bdf594680adca5f0d6470b18d765","user":{"login":"flixr","id":104257,"avatar_url":"https://avatars.githubusercontent.com/u/104257?v=3","gravatar_id":"","url":"https://api.github.com/users/flixr","html_url":"https://github.com/flixr","followers_url":"https://api.github.com/users/flixr/followers","following_url":"https://api.github.com/users/flixr/following{/other_user}","gists_url":"https://api.github.com/users/flixr/gists{/gist_id}","starred_url":"https://api.github.com/users/flixr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flixr/subscriptions","organizations_url":"https://api.github.com/users/flixr/orgs","repos_url":"https://api.github.com/users/flixr/repos","events_url":"https://api.github.com/users/flixr/events{/privacy}","received_events_url":"https://api.github.com/users/flixr/received_events","type":"User","site_admin":false},"body":"IMHO it is nicer to make these real functions (they are not speed critical) and move them to the c file. That way we can also minimize the includes needed in the header (only includes that are needed for declarations of things used in the header should be there).\r\nThat way we get less coupling and recompilation is faster.","created_at":"2016-06-15T14:49:42Z","updated_at":"2016-06-15T14:49:42Z","html_url":"https://github.com/paparazzi/paparazzi/pull/1638#discussion_r67176519","pull_request_url":"https://api.github.com/repos/paparazzi/paparazzi/pulls/1638","_links":{"self":{"href":"https://api.github.com/repos/paparazzi/paparazzi/pulls/comments/67176519"},"html":{"href":"https://github.com/paparazzi/paparazzi/pull/1638#discussion_r67176519"},"pull_request":{"href":"https://api.github.com/repos/paparazzi/paparazzi/pulls/1638"}}},"pull_request":{"url":"https://api.github.com/repos/paparazzi/paparazzi/pulls/1638","id":67707511,"html_url":"https://github.com/paparazzi/paparazzi/pull/1638","diff_url":"https://github.com/paparazzi/paparazzi/pull/1638.diff","patch_url":"https://github.com/paparazzi/paparazzi/pull/1638.patch","issue_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/1638","number":1638,"state":"open","locked":false,"title":"[module][refactor] replace traffic_info subsystem with module","user":{"login":"kirkscheper","id":2835523,"avatar_url":"https://avatars.githubusercontent.com/u/2835523?v=3","gravatar_id":"","url":"https://api.github.com/users/kirkscheper","html_url":"https://github.com/kirkscheper","followers_url":"https://api.github.com/users/kirkscheper/followers","following_url":"https://api.github.com/users/kirkscheper/following{/other_user}","gists_url":"https://api.github.com/users/kirkscheper/gists{/gist_id}","starred_url":"https://api.github.com/users/kirkscheper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirkscheper/subscriptions","organizations_url":"https://api.github.com/users/kirkscheper/orgs","repos_url":"https://api.github.com/users/kirkscheper/repos","events_url":"https://api.github.com/users/kirkscheper/events{/privacy}","received_events_url":"https://api.github.com/users/kirkscheper/received_events","type":"User","site_admin":false},"body":"Splitting #1629. This pull request converts traffic info from subsystem to module and updates the functions that use traffic_info.\r\n\r\nIs there any documentation that I should add for this?","created_at":"2016-04-25T11:58:57Z","updated_at":"2016-06-15T14:49:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2956cdf339f202ea55dd5e99cdab13e80f030b8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/paparazzi/paparazzi/pulls/1638/commits","review_comments_url":"https://api.github.com/repos/paparazzi/paparazzi/pulls/1638/comments","review_comment_url":"https://api.github.com/repos/paparazzi/paparazzi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/1638/comments","statuses_url":"https://api.github.com/repos/paparazzi/paparazzi/statuses/7174ad8543d1bdf594680adca5f0d6470b18d765","head":{"label":"kirkscheper:traffic_refactor","ref":"traffic_refactor","sha":"7174ad8543d1bdf594680adca5f0d6470b18d765","user":{"login":"kirkscheper","id":2835523,"avatar_url":"https://avatars.githubusercontent.com/u/2835523?v=3","gravatar_id":"","url":"https://api.github.com/users/kirkscheper","html_url":"https://github.com/kirkscheper","followers_url":"https://api.github.com/users/kirkscheper/followers","following_url":"https://api.github.com/users/kirkscheper/following{/other_user}","gists_url":"https://api.github.com/users/kirkscheper/gists{/gist_id}","starred_url":"https://api.github.com/users/kirkscheper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirkscheper/subscriptions","organizations_url":"https://api.github.com/users/kirkscheper/orgs","repos_url":"https://api.github.com/users/kirkscheper/repos","events_url":"https://api.github.com/users/kirkscheper/events{/privacy}","received_events_url":"https://api.github.com/users/kirkscheper/received_events","type":"User","site_admin":false},"repo":{"id":27757069,"name":"paparazzi","full_name":"kirkscheper/paparazzi","owner":{"login":"kirkscheper","id":2835523,"avatar_url":"https://avatars.githubusercontent.com/u/2835523?v=3","gravatar_id":"","url":"https://api.github.com/users/kirkscheper","html_url":"https://github.com/kirkscheper","followers_url":"https://api.github.com/users/kirkscheper/followers","following_url":"https://api.github.com/users/kirkscheper/following{/other_user}","gists_url":"https://api.github.com/users/kirkscheper/gists{/gist_id}","starred_url":"https://api.github.com/users/kirkscheper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirkscheper/subscriptions","organizations_url":"https://api.github.com/users/kirkscheper/orgs","repos_url":"https://api.github.com/users/kirkscheper/repos","events_url":"https://api.github.com/users/kirkscheper/events{/privacy}","received_events_url":"https://api.github.com/users/kirkscheper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kirkscheper/paparazzi","description":"Paparazzi is a free and open-source hardware and software project for unmanned (air) vehicles. This is the main software repository.","fork":true,"url":"https://api.github.com/repos/kirkscheper/paparazzi","forks_url":"https://api.github.com/repos/kirkscheper/paparazzi/forks","keys_url":"https://api.github.com/repos/kirkscheper/paparazzi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kirkscheper/paparazzi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kirkscheper/paparazzi/teams","hooks_url":"https://api.github.com/repos/kirkscheper/paparazzi/hooks","issue_events_url":"https://api.github.com/repos/kirkscheper/paparazzi/issues/events{/number}","events_url":"https://api.github.com/repos/kirkscheper/paparazzi/events","assignees_url":"https://api.github.com/repos/kirkscheper/paparazzi/assignees{/user}","branches_url":"https://api.github.com/repos/kirkscheper/paparazzi/branches{/branch}","tags_url":"https://api.github.com/repos/kirkscheper/paparazzi/tags","blobs_url":"https://api.github.com/repos/kirkscheper/paparazzi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kirkscheper/paparazzi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kirkscheper/paparazzi/git/refs{/sha}","trees_url":"https://api.github.com/repos/kirkscheper/paparazzi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kirkscheper/paparazzi/statuses/{sha}","languages_url":"https://api.github.com/repos/kirkscheper/paparazzi/languages","stargazers_url":"https://api.github.com/repos/kirkscheper/paparazzi/stargazers","contributors_url":"https://api.github.com/repos/kirkscheper/paparazzi/contributors","subscribers_url":"https://api.github.com/repos/kirkscheper/paparazzi/subscribers","subscription_url":"https://api.github.com/repos/kirkscheper/paparazzi/subscription","commits_url":"https://api.github.com/repos/kirkscheper/paparazzi/commits{/sha}","git_commits_url":"https://api.github.com/repos/kirkscheper/paparazzi/git/commits{/sha}","comments_url":"https://api.github.com/repos/kirkscheper/paparazzi/comments{/number}","issue_comment_url":"https://api.github.com/repos/kirkscheper/paparazzi/issues/comments{/number}","contents_url":"https://api.github.com/repos/kirkscheper/paparazzi/contents/{+path}","compare_url":"https://api.github.com/repos/kirkscheper/paparazzi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kirkscheper/paparazzi/merges","archive_url":"https://api.github.com/repos/kirkscheper/paparazzi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kirkscheper/paparazzi/downloads","issues_url":"https://api.github.com/repos/kirkscheper/paparazzi/issues{/number}","pulls_url":"https://api.github.com/repos/kirkscheper/paparazzi/pulls{/number}","milestones_url":"https://api.github.com/repos/kirkscheper/paparazzi/milestones{/number}","notifications_url":"https://api.github.com/repos/kirkscheper/paparazzi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kirkscheper/paparazzi/labels{/name}","releases_url":"https://api.github.com/repos/kirkscheper/paparazzi/releases{/id}","deployments_url":"https://api.github.com/repos/kirkscheper/paparazzi/deployments","created_at":"2014-12-09T08:32:29Z","updated_at":"2016-01-14T09:24:30Z","pushed_at":"2016-06-15T13:59:36Z","git_url":"git://github.com/kirkscheper/paparazzi.git","ssh_url":"git@github.com:kirkscheper/paparazzi.git","clone_url":"https://github.com/kirkscheper/paparazzi.git","svn_url":"https://github.com/kirkscheper/paparazzi","homepage":"http://paparazziuav.org","size":87733,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"paparazzi:master","ref":"master","sha":"514a74be0a53ceab74e26e3cafa7d1f5fe797ef5","user":{"login":"paparazzi","id":318080,"avatar_url":"https://avatars.githubusercontent.com/u/318080?v=3","gravatar_id":"","url":"https://api.github.com/users/paparazzi","html_url":"https://github.com/paparazzi","followers_url":"https://api.github.com/users/paparazzi/followers","following_url":"https://api.github.com/users/paparazzi/following{/other_user}","gists_url":"https://api.github.com/users/paparazzi/gists{/gist_id}","starred_url":"https://api.github.com/users/paparazzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paparazzi/subscriptions","organizations_url":"https://api.github.com/users/paparazzi/orgs","repos_url":"https://api.github.com/users/paparazzi/repos","events_url":"https://api.github.com/users/paparazzi/events{/privacy}","received_events_url":"https://api.github.com/users/paparazzi/received_events","type":"Organization","site_admin":false},"repo":{"id":1068018,"name":"paparazzi","full_name":"paparazzi/paparazzi","owner":{"login":"paparazzi","id":318080,"avatar_url":"https://avatars.githubusercontent.com/u/318080?v=3","gravatar_id":"","url":"https://api.github.com/users/paparazzi","html_url":"https://github.com/paparazzi","followers_url":"https://api.github.com/users/paparazzi/followers","following_url":"https://api.github.com/users/paparazzi/following{/other_user}","gists_url":"https://api.github.com/users/paparazzi/gists{/gist_id}","starred_url":"https://api.github.com/users/paparazzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paparazzi/subscriptions","organizations_url":"https://api.github.com/users/paparazzi/orgs","repos_url":"https://api.github.com/users/paparazzi/repos","events_url":"https://api.github.com/users/paparazzi/events{/privacy}","received_events_url":"https://api.github.com/users/paparazzi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paparazzi/paparazzi","description":"Paparazzi is a free and open-source hardware and software project for unmanned (air) vehicles. This is the main software repository.","fork":false,"url":"https://api.github.com/repos/paparazzi/paparazzi","forks_url":"https://api.github.com/repos/paparazzi/paparazzi/forks","keys_url":"https://api.github.com/repos/paparazzi/paparazzi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paparazzi/paparazzi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paparazzi/paparazzi/teams","hooks_url":"https://api.github.com/repos/paparazzi/paparazzi/hooks","issue_events_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/events{/number}","events_url":"https://api.github.com/repos/paparazzi/paparazzi/events","assignees_url":"https://api.github.com/repos/paparazzi/paparazzi/assignees{/user}","branches_url":"https://api.github.com/repos/paparazzi/paparazzi/branches{/branch}","tags_url":"https://api.github.com/repos/paparazzi/paparazzi/tags","blobs_url":"https://api.github.com/repos/paparazzi/paparazzi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paparazzi/paparazzi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paparazzi/paparazzi/git/refs{/sha}","trees_url":"https://api.github.com/repos/paparazzi/paparazzi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paparazzi/paparazzi/statuses/{sha}","languages_url":"https://api.github.com/repos/paparazzi/paparazzi/languages","stargazers_url":"https://api.github.com/repos/paparazzi/paparazzi/stargazers","contributors_url":"https://api.github.com/repos/paparazzi/paparazzi/contributors","subscribers_url":"https://api.github.com/repos/paparazzi/paparazzi/subscribers","subscription_url":"https://api.github.com/repos/paparazzi/paparazzi/subscription","commits_url":"https://api.github.com/repos/paparazzi/paparazzi/commits{/sha}","git_commits_url":"https://api.github.com/repos/paparazzi/paparazzi/git/commits{/sha}","comments_url":"https://api.github.com/repos/paparazzi/paparazzi/comments{/number}","issue_comment_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/comments{/number}","contents_url":"https://api.github.com/repos/paparazzi/paparazzi/contents/{+path}","compare_url":"https://api.github.com/repos/paparazzi/paparazzi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paparazzi/paparazzi/merges","archive_url":"https://api.github.com/repos/paparazzi/paparazzi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paparazzi/paparazzi/downloads","issues_url":"https://api.github.com/repos/paparazzi/paparazzi/issues{/number}","pulls_url":"https://api.github.com/repos/paparazzi/paparazzi/pulls{/number}","milestones_url":"https://api.github.com/repos/paparazzi/paparazzi/milestones{/number}","notifications_url":"https://api.github.com/repos/paparazzi/paparazzi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paparazzi/paparazzi/labels{/name}","releases_url":"https://api.github.com/repos/paparazzi/paparazzi/releases{/id}","deployments_url":"https://api.github.com/repos/paparazzi/paparazzi/deployments","created_at":"2010-11-10T11:14:08Z","updated_at":"2016-06-15T07:31:13Z","pushed_at":"2016-06-15T14:43:29Z","git_url":"git://github.com/paparazzi/paparazzi.git","ssh_url":"git@github.com:paparazzi/paparazzi.git","clone_url":"https://github.com/paparazzi/paparazzi.git","svn_url":"https://github.com/paparazzi/paparazzi","homepage":"http://paparazziuav.org","size":99929,"stargazers_count":582,"watchers_count":582,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":605,"mirror_url":null,"open_issues_count":118,"forks":605,"open_issues":118,"watchers":582,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paparazzi/paparazzi/pulls/1638"},"html":{"href":"https://github.com/paparazzi/paparazzi/pull/1638"},"issue":{"href":"https://api.github.com/repos/paparazzi/paparazzi/issues/1638"},"comments":{"href":"https://api.github.com/repos/paparazzi/paparazzi/issues/1638/comments"},"review_comments":{"href":"https://api.github.com/repos/paparazzi/paparazzi/pulls/1638/comments"},"review_comment":{"href":"https://api.github.com/repos/paparazzi/paparazzi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paparazzi/paparazzi/pulls/1638/commits"},"statuses":{"href":"https://api.github.com/repos/paparazzi/paparazzi/statuses/7174ad8543d1bdf594680adca5f0d6470b18d765"}}}}
{"actor":{"display_login":"flixr"}}