{"action":"created","issue":{"url":"https://api.github.com/repos/Spegeli/PokemoGoBot-GottaCatchEmAll/issues/348","repository_url":"https://api.github.com/repos/Spegeli/PokemoGoBot-GottaCatchEmAll","labels_url":"https://api.github.com/repos/Spegeli/PokemoGoBot-GottaCatchEmAll/issues/348/labels{/name}","comments_url":"https://api.github.com/repos/Spegeli/PokemoGoBot-GottaCatchEmAll/issues/348/comments","events_url":"https://api.github.com/repos/Spegeli/PokemoGoBot-GottaCatchEmAll/issues/348/events","html_url":"https://github.com/Spegeli/PokemoGoBot-GottaCatchEmAll/issues/348","id":170299070,"number":348,"title":"Keep best pokemon, considering always IV and CP","user":{"login":"flaviorighi","id":16403175,"avatar_url":"https://avatars.githubusercontent.com/u/16403175?v=3","gravatar_id":"","url":"https://api.github.com/users/flaviorighi","html_url":"https://github.com/flaviorighi","followers_url":"https://api.github.com/users/flaviorighi/followers","following_url":"https://api.github.com/users/flaviorighi/following{/other_user}","gists_url":"https://api.github.com/users/flaviorighi/gists{/gist_id}","starred_url":"https://api.github.com/users/flaviorighi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flaviorighi/subscriptions","organizations_url":"https://api.github.com/users/flaviorighi/orgs","repos_url":"https://api.github.com/users/flaviorighi/repos","events_url":"https://api.github.com/users/flaviorighi/events{/privacy}","received_events_url":"https://api.github.com/users/flaviorighi/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Spegeli/PokemoGoBot-GottaCatchEmAll/labels/Current%20Feature%20Enhancement","name":"Current Feature Enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-09T23:59:49Z","updated_at":"2016-08-10T10:56:41Z","closed_at":null,"body":"I noticed that sometimes a catched pokemon with stats like: [ CP: 1500/1520 IV: 96.03% ] could be transferred to take a pokemon with: [ CP: 20/25 IV: 96.10% ].\r\nI think to avoid this case is better to take a look to CP when \"prioritizeIVOverCP = true\" too.\r\n\r\nMaybe you could implements a check like: \r\nif ((newCP - bestCP)/100 > ( newIV - bestIV)){\r\nkeepOld();\r\n} else {\r\n keepNew();\r\n}"},"comment":{"url":"https://api.github.com/repos/Spegeli/PokemoGoBot-GottaCatchEmAll/issues/comments/238833548","html_url":"https://github.com/Spegeli/PokemoGoBot-GottaCatchEmAll/issues/348#issuecomment-238833548","issue_url":"https://api.github.com/repos/Spegeli/PokemoGoBot-GottaCatchEmAll/issues/348","id":238833548,"user":{"login":"killercloud","id":894194,"avatar_url":"https://avatars.githubusercontent.com/u/894194?v=3","gravatar_id":"","url":"https://api.github.com/users/killercloud","html_url":"https://github.com/killercloud","followers_url":"https://api.github.com/users/killercloud/followers","following_url":"https://api.github.com/users/killercloud/following{/other_user}","gists_url":"https://api.github.com/users/killercloud/gists{/gist_id}","starred_url":"https://api.github.com/users/killercloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/killercloud/subscriptions","organizations_url":"https://api.github.com/users/killercloud/orgs","repos_url":"https://api.github.com/users/killercloud/repos","events_url":"https://api.github.com/users/killercloud/events{/privacy}","received_events_url":"https://api.github.com/users/killercloud/received_events","type":"User","site_admin":false},"created_at":"2016-08-10T10:56:41Z","updated_at":"2016-08-10T10:56:41Z","body":"Hi guys,\r\n\r\nI've implemented it with the next formula:\r\n                  CP^1.5 * IV\r\nI set this 1.5 factor because i want to give more importance to CP rather than IV.\r\nIt's working as i expected. For example, it had just replaced my old best Bellsprout [839CP - 72.39IV] with a new one with less CP but better IV [725CP - 94.75IV]\r\n\r\nHope it helps.\r\n\r\n"}}
{"actor":{"display_login":"killercloud"}}