{"action":"created","comment":{"url":"https://api.github.com/repos/OpenMods/OpenBlocks/pulls/comments/66709816","id":66709816,"diff_hunk":"@@ -1,20 +1,33 @@\n-[\n {\n-  \"modid\" : \"OpenBlocks\",\n-  \"name\" : \"OpenBlocks\",\n-  \"version\" : \"${version}\",\n-  \"url\" : \"http://www.openperipheral.info\",\n-  \"credits\" : \"\",\n-  \"authors\": [\n-    \"Mikee\",\n-    \"NeverCast\",\n-    \"boq\",\n-    \"Lyqyd\"\n-  ],\n-  \"description\": \"All the things you never thought you will ever need\",\n-  \"logoFile\" : \"\",\n-  \"updateUrl\" : \"\",\n-  \"parent\" : \"\",\n-  \"screenshots\": [\n+  \"modListVersion\": \"2\",\n+  \"modList\":\n+  [\n+    {\n+      \"modid\": \"OpenBlocks\",\n+      \"name\": \"OpenBlocks\",\n+      \"description\": \"All the things you never thought you will ever need\",\n+      \"version\": \"${version}\",\n+      \"mcversion\": \"${MCVersion}\",\n+      \"url\": \"http://openmods.info/\",\n+      \"updateUrl\": \"\",\n+      \"authorList\": [\n+        \"Mikee\",\n+        \"NeverCast\",\n+        \"boq\",\n+        \"Lyqyd\"\n+      ],\n+      \"credits\": \"\",\n+      \"logoFile\": \"\",\n+      \"screenshots\": [\n+      ],\n+      \"parent\": \"\",\n+      \"requiredMods\": [\n+      ],\n+      \"dependencies\": [\n+      ],\n+      \"dependants\": [\n+      ],\n+      \"useDependencyInformation\": \"false\"\n+    }\n   ]\n-}]\n+}","path":"src/main/resources/mcmod.info","position":51,"original_position":51,"commit_id":"c5382ef6faeccca96193eabd695e640c189bf69c","original_commit_id":"400e333c14aee4b7be4215c85523131f1fedf512","user":{"login":"boq","id":754542,"avatar_url":"https://avatars.githubusercontent.com/u/754542?v=3","gravatar_id":"","url":"https://api.github.com/users/boq","html_url":"https://github.com/boq","followers_url":"https://api.github.com/users/boq/followers","following_url":"https://api.github.com/users/boq/following{/other_user}","gists_url":"https://api.github.com/users/boq/gists{/gist_id}","starred_url":"https://api.github.com/users/boq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boq/subscriptions","organizations_url":"https://api.github.com/users/boq/orgs","repos_url":"https://api.github.com/users/boq/repos","events_url":"https://api.github.com/users/boq/events{/privacy}","received_events_url":"https://api.github.com/users/boq/received_events","type":"User","site_admin":false},"body":"Could be split to different PR.","created_at":"2016-06-11T18:27:10Z","updated_at":"2016-06-11T18:27:10Z","html_url":"https://github.com/OpenMods/OpenBlocks/pull/774#discussion_r66709816","pull_request_url":"https://api.github.com/repos/OpenMods/OpenBlocks/pulls/774","_links":{"self":{"href":"https://api.github.com/repos/OpenMods/OpenBlocks/pulls/comments/66709816"},"html":{"href":"https://github.com/OpenMods/OpenBlocks/pull/774#discussion_r66709816"},"pull_request":{"href":"https://api.github.com/repos/OpenMods/OpenBlocks/pulls/774"}}},"pull_request":{"url":"https://api.github.com/repos/OpenMods/OpenBlocks/pulls/774","id":69188535,"html_url":"https://github.com/OpenMods/OpenBlocks/pull/774","diff_url":"https://github.com/OpenMods/OpenBlocks/pull/774.diff","patch_url":"https://github.com/OpenMods/OpenBlocks/pull/774.patch","issue_url":"https://api.github.com/repos/OpenMods/OpenBlocks/issues/774","number":774,"state":"open","locked":false,"title":"Projector enhancements: more futuristic Look&Feel","user":{"login":"TheSilkMiner","id":11136677,"avatar_url":"https://avatars.githubusercontent.com/u/11136677?v=3","gravatar_id":"","url":"https://api.github.com/users/TheSilkMiner","html_url":"https://github.com/TheSilkMiner","followers_url":"https://api.github.com/users/TheSilkMiner/followers","following_url":"https://api.github.com/users/TheSilkMiner/following{/other_user}","gists_url":"https://api.github.com/users/TheSilkMiner/gists{/gist_id}","starred_url":"https://api.github.com/users/TheSilkMiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheSilkMiner/subscriptions","organizations_url":"https://api.github.com/users/TheSilkMiner/orgs","repos_url":"https://api.github.com/users/TheSilkMiner/repos","events_url":"https://api.github.com/users/TheSilkMiner/events{/privacy}","received_events_url":"https://api.github.com/users/TheSilkMiner/received_events","type":"User","site_admin":false},"body":"This PR makes the projector emit light and render a translucent cone when working.\r\n\r\n## Extended description\r\n**So, what should this PR do?**\r\nAs I previously said, the goal of this PR is giving the projector a more futuristic look, adding various elements commonly associated to holographic projectors.\r\n**Which elements?**\r\nFirst of all, the blue cone: every projector usually displays either a cone or a box where the object is then rendered. This behaviour is now applicable to the Height Map Projector. Another element is the luminance. Projecting machines usually emit light when displaying something: this is an indicator of their correct and working status. With this PR the same effect applies to OpenBlocks' one.\r\n**Wait a second: this allows the projector to emit light and the branch name is `lights-out`?**\r\nYep, that's right. Plus that name references [something](https://en.wikipedia.org/wiki/Lights_Out_%282016_film%29)...\r\n**Anyway, that seems nice, can you show me some pictures?**\r\nYes of course! [Here you are](http://i.imgur.com/oUvYaMf.png)!\r\nNote that the chat text isn't part of the changes.\r\n**I noticed that the cone doesn't show some lines. Usually holograms are rendered on a grid: why isn't it present?**\r\nI originally planned to add a grid to the rendering, but I ended up removing it and switching to the current texture because of Minecraft's `Tessellator` weird behaviour (lines were not straight).\r\n**The concept may be nice, but I don't like it. Can I turn it off?**\r\nOf course you can! In OpenBlocks' configuration file, under the `projector` category, you can find various options. The one you are looking for is `renderHolographicCone`. If you set it to `false`, then the cone won't render.\r\n**No no no, I mean the entire concept.**\r\nI'm sorry you don't like it, but that's why I added some more options. Setting `lightLevel` will increase or diminish the light level of the projector, while turning `lightUpWhenWorking` to `false` will disable the entire switching to the working status.\r\n**Wait, why can't I disable the entire block?**\r\nIf you want you can: the id is `projector.working`. Disabling the behaviour through the specified configuration options is much better, though. In fact, this will keep the working block state and switch to the previous one when updated, without issues. Deleting the block will erase all the data contained in it, removing all the Height Maps currently inserted.\r\n**I see. Wait a moment: why is the `mcmod.info` file changed?**\r\nA side thing: I noticed that in the mod list the authors didn't show up because of a 1.7.X change in the format. I thought that changing it to the style shown in [FML's wiki](https://github.com/MinecraftForge/FML/wiki/FML-mod-information-file#example) was a nice idea.\r\n**Just wondering: wouldn't this cause software rot issues?**\r\nEven if I am a bit new to that concept, I did some research and it shouldn't happen.\r\n**What about porting?**\r\nThe rendering code is almost the same as the one in the Height Map, so the changes shouldn't be major. The `Tessellator` calls should be replaceable with a call to a `WorldRenderer` object, while the `update` method should only switch to `IBlockState`s and `BlockPos`es. All of this is just speculation, though: I am not currently able to set up a proper 1.8 environment and test the changes.\r\n**Okay, that's it. Thank you for your explanation!**\r\nYou're welcome. And thanks for listening to me until this point.","created_at":"2016-05-06T18:10:12Z","updated_at":"2016-06-11T18:27:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cd510c90b772f1ab28410939d712501593c7595","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenMods/OpenBlocks/pulls/774/commits","review_comments_url":"https://api.github.com/repos/OpenMods/OpenBlocks/pulls/774/comments","review_comment_url":"https://api.github.com/repos/OpenMods/OpenBlocks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenMods/OpenBlocks/issues/774/comments","statuses_url":"https://api.github.com/repos/OpenMods/OpenBlocks/statuses/c5382ef6faeccca96193eabd695e640c189bf69c","head":{"label":"TheSilkMiner:feature/lights-out","ref":"feature/lights-out","sha":"c5382ef6faeccca96193eabd695e640c189bf69c","user":{"login":"TheSilkMiner","id":11136677,"avatar_url":"https://avatars.githubusercontent.com/u/11136677?v=3","gravatar_id":"","url":"https://api.github.com/users/TheSilkMiner","html_url":"https://github.com/TheSilkMiner","followers_url":"https://api.github.com/users/TheSilkMiner/followers","following_url":"https://api.github.com/users/TheSilkMiner/following{/other_user}","gists_url":"https://api.github.com/users/TheSilkMiner/gists{/gist_id}","starred_url":"https://api.github.com/users/TheSilkMiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheSilkMiner/subscriptions","organizations_url":"https://api.github.com/users/TheSilkMiner/orgs","repos_url":"https://api.github.com/users/TheSilkMiner/repos","events_url":"https://api.github.com/users/TheSilkMiner/events{/privacy}","received_events_url":"https://api.github.com/users/TheSilkMiner/received_events","type":"User","site_admin":false},"repo":{"id":41587855,"name":"OpenBlocks","full_name":"TheSilkMiner/OpenBlocks","owner":{"login":"TheSilkMiner","id":11136677,"avatar_url":"https://avatars.githubusercontent.com/u/11136677?v=3","gravatar_id":"","url":"https://api.github.com/users/TheSilkMiner","html_url":"https://github.com/TheSilkMiner","followers_url":"https://api.github.com/users/TheSilkMiner/followers","following_url":"https://api.github.com/users/TheSilkMiner/following{/other_user}","gists_url":"https://api.github.com/users/TheSilkMiner/gists{/gist_id}","starred_url":"https://api.github.com/users/TheSilkMiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheSilkMiner/subscriptions","organizations_url":"https://api.github.com/users/TheSilkMiner/orgs","repos_url":"https://api.github.com/users/TheSilkMiner/repos","events_url":"https://api.github.com/users/TheSilkMiner/events{/privacy}","received_events_url":"https://api.github.com/users/TheSilkMiner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TheSilkMiner/OpenBlocks","description":"Random collection of blocks","fork":true,"url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks","forks_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/forks","keys_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/teams","hooks_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/hooks","issue_events_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/issues/events{/number}","events_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/events","assignees_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/assignees{/user}","branches_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/branches{/branch}","tags_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/tags","blobs_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/statuses/{sha}","languages_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/languages","stargazers_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/stargazers","contributors_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/contributors","subscribers_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/subscribers","subscription_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/subscription","commits_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/contents/{+path}","compare_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/merges","archive_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/downloads","issues_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/issues{/number}","pulls_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/pulls{/number}","milestones_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/milestones{/number}","notifications_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/labels{/name}","releases_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/releases{/id}","deployments_url":"https://api.github.com/repos/TheSilkMiner/OpenBlocks/deployments","created_at":"2015-08-29T09:30:50Z","updated_at":"2016-01-31T16:53:06Z","pushed_at":"2016-06-02T06:18:36Z","git_url":"git://github.com/TheSilkMiner/OpenBlocks.git","ssh_url":"git@github.com:TheSilkMiner/OpenBlocks.git","clone_url":"https://github.com/TheSilkMiner/OpenBlocks.git","svn_url":"https://github.com/TheSilkMiner/OpenBlocks","homepage":null,"size":12332,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenMods:master","ref":"master","sha":"fd792289caecfab58dd476b30331f39b1e6dfc54","user":{"login":"OpenMods","id":4816305,"avatar_url":"https://avatars.githubusercontent.com/u/4816305?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenMods","html_url":"https://github.com/OpenMods","followers_url":"https://api.github.com/users/OpenMods/followers","following_url":"https://api.github.com/users/OpenMods/following{/other_user}","gists_url":"https://api.github.com/users/OpenMods/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMods/subscriptions","organizations_url":"https://api.github.com/users/OpenMods/orgs","repos_url":"https://api.github.com/users/OpenMods/repos","events_url":"https://api.github.com/users/OpenMods/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMods/received_events","type":"Organization","site_admin":false},"repo":{"id":11545371,"name":"OpenBlocks","full_name":"OpenMods/OpenBlocks","owner":{"login":"OpenMods","id":4816305,"avatar_url":"https://avatars.githubusercontent.com/u/4816305?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenMods","html_url":"https://github.com/OpenMods","followers_url":"https://api.github.com/users/OpenMods/followers","following_url":"https://api.github.com/users/OpenMods/following{/other_user}","gists_url":"https://api.github.com/users/OpenMods/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMods/subscriptions","organizations_url":"https://api.github.com/users/OpenMods/orgs","repos_url":"https://api.github.com/users/OpenMods/repos","events_url":"https://api.github.com/users/OpenMods/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMods/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenMods/OpenBlocks","description":"Random collection of blocks","fork":false,"url":"https://api.github.com/repos/OpenMods/OpenBlocks","forks_url":"https://api.github.com/repos/OpenMods/OpenBlocks/forks","keys_url":"https://api.github.com/repos/OpenMods/OpenBlocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenMods/OpenBlocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenMods/OpenBlocks/teams","hooks_url":"https://api.github.com/repos/OpenMods/OpenBlocks/hooks","issue_events_url":"https://api.github.com/repos/OpenMods/OpenBlocks/issues/events{/number}","events_url":"https://api.github.com/repos/OpenMods/OpenBlocks/events","assignees_url":"https://api.github.com/repos/OpenMods/OpenBlocks/assignees{/user}","branches_url":"https://api.github.com/repos/OpenMods/OpenBlocks/branches{/branch}","tags_url":"https://api.github.com/repos/OpenMods/OpenBlocks/tags","blobs_url":"https://api.github.com/repos/OpenMods/OpenBlocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenMods/OpenBlocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenMods/OpenBlocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenMods/OpenBlocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenMods/OpenBlocks/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenMods/OpenBlocks/languages","stargazers_url":"https://api.github.com/repos/OpenMods/OpenBlocks/stargazers","contributors_url":"https://api.github.com/repos/OpenMods/OpenBlocks/contributors","subscribers_url":"https://api.github.com/repos/OpenMods/OpenBlocks/subscribers","subscription_url":"https://api.github.com/repos/OpenMods/OpenBlocks/subscription","commits_url":"https://api.github.com/repos/OpenMods/OpenBlocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenMods/OpenBlocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenMods/OpenBlocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenMods/OpenBlocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenMods/OpenBlocks/contents/{+path}","compare_url":"https://api.github.com/repos/OpenMods/OpenBlocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenMods/OpenBlocks/merges","archive_url":"https://api.github.com/repos/OpenMods/OpenBlocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenMods/OpenBlocks/downloads","issues_url":"https://api.github.com/repos/OpenMods/OpenBlocks/issues{/number}","pulls_url":"https://api.github.com/repos/OpenMods/OpenBlocks/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenMods/OpenBlocks/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenMods/OpenBlocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenMods/OpenBlocks/labels{/name}","releases_url":"https://api.github.com/repos/OpenMods/OpenBlocks/releases{/id}","deployments_url":"https://api.github.com/repos/OpenMods/OpenBlocks/deployments","created_at":"2013-07-20T10:11:01Z","updated_at":"2016-06-04T20:00:29Z","pushed_at":"2016-06-11T17:58:32Z","git_url":"git://github.com/OpenMods/OpenBlocks.git","ssh_url":"git@github.com:OpenMods/OpenBlocks.git","clone_url":"https://github.com/OpenMods/OpenBlocks.git","svn_url":"https://github.com/OpenMods/OpenBlocks","homepage":null,"size":13798,"stargazers_count":231,"watchers_count":231,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":113,"mirror_url":null,"open_issues_count":83,"forks":113,"open_issues":83,"watchers":231,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenMods/OpenBlocks/pulls/774"},"html":{"href":"https://github.com/OpenMods/OpenBlocks/pull/774"},"issue":{"href":"https://api.github.com/repos/OpenMods/OpenBlocks/issues/774"},"comments":{"href":"https://api.github.com/repos/OpenMods/OpenBlocks/issues/774/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenMods/OpenBlocks/pulls/774/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenMods/OpenBlocks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenMods/OpenBlocks/pulls/774/commits"},"statuses":{"href":"https://api.github.com/repos/OpenMods/OpenBlocks/statuses/c5382ef6faeccca96193eabd695e640c189bf69c"}}}}
{"actor":{"display_login":"boq"}}