{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/12379","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/12379/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/12379/comments","events_url":"https://api.github.com/repos/apache/spark/issues/12379/events","html_url":"https://github.com/apache/spark/pull/12379","id":148226051,"number":12379,"title":"[SPARK-14620][SQL] Use/benchmark a better hash in VectorizedHashMap","user":{"login":"sameeragarwal","id":166454,"avatar_url":"https://avatars.githubusercontent.com/u/166454?v=3","gravatar_id":"","url":"https://api.github.com/users/sameeragarwal","html_url":"https://github.com/sameeragarwal","followers_url":"https://api.github.com/users/sameeragarwal/followers","following_url":"https://api.github.com/users/sameeragarwal/following{/other_user}","gists_url":"https://api.github.com/users/sameeragarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/sameeragarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sameeragarwal/subscriptions","organizations_url":"https://api.github.com/users/sameeragarwal/orgs","repos_url":"https://api.github.com/users/sameeragarwal/repos","events_url":"https://api.github.com/users/sameeragarwal/events{/privacy}","received_events_url":"https://api.github.com/users/sameeragarwal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-04-14T01:35:26Z","updated_at":"2016-04-15T22:49:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/12379","html_url":"https://github.com/apache/spark/pull/12379","diff_url":"https://github.com/apache/spark/pull/12379.diff","patch_url":"https://github.com/apache/spark/pull/12379.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\nThis PR uses a better hashing algorithm while probing the AggregateHashMap:\r\n\r\n```java\r\nlong h = 0\r\nh = (h ^ (0x9e3779b9)) + key_1 + (h << 6) + (h >>> 2);\r\nh = (h ^ (0x9e3779b9)) + key_2 + (h << 6) + (h >>> 2);\r\nh = (h ^ (0x9e3779b9)) + key_3 + (h << 6) + (h >>> 2);\r\n...\r\nh = (h ^ (0x9e3779b9)) + key_n + (h << 6) + (h >>> 2);\r\nreturn h\r\n```\r\n\r\nDepends on: https://github.com/apache/spark/pull/12345\r\n## How was this patch tested?\r\n\r\n    Java HotSpot(TM) 64-Bit Server VM 1.8.0_73-b02 on Mac OS X 10.11.4\r\n    Intel(R) Core(TM) i7-4960HQ CPU @ 2.60GHz\r\n    Aggregate w keys:                   Best/Avg Time(ms)    Rate(M/s)   Per Row(ns)   Relative\r\n    -------------------------------------------------------------------------------------------\r\n    codegen = F                              2417 / 2457          8.7         115.2       1.0X\r\n    codegen = T hashmap = F                  1554 / 1581         13.5          74.1       1.6X\r\n    codegen = T hashmap = T                   877 /  929         23.9          41.8       2.8X"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/210673678","html_url":"https://github.com/apache/spark/pull/12379#issuecomment-210673678","issue_url":"https://api.github.com/repos/apache/spark/issues/12379","id":210673678,"user":{"login":"SparkQA","id":8108735,"avatar_url":"https://avatars.githubusercontent.com/u/8108735?v=3","gravatar_id":"","url":"https://api.github.com/users/SparkQA","html_url":"https://github.com/SparkQA","followers_url":"https://api.github.com/users/SparkQA/followers","following_url":"https://api.github.com/users/SparkQA/following{/other_user}","gists_url":"https://api.github.com/users/SparkQA/gists{/gist_id}","starred_url":"https://api.github.com/users/SparkQA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparkQA/subscriptions","organizations_url":"https://api.github.com/users/SparkQA/orgs","repos_url":"https://api.github.com/users/SparkQA/repos","events_url":"https://api.github.com/users/SparkQA/events{/privacy}","received_events_url":"https://api.github.com/users/SparkQA/received_events","type":"User","site_admin":false},"created_at":"2016-04-15T22:49:04Z","updated_at":"2016-04-15T22:49:04Z","body":"**[Test build #55962 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55962/consoleFull)** for PR 12379 at commit [`1562d46`](https://github.com/apache/spark/commit/1562d46af39b8e78d8265f046f52f1753cb484a7).\n * This patch passes all tests.\n * This patch merges cleanly.\n * This patch adds no public classes."}}