{"action":"created","issue":{"url":"https://api.github.com/repos/phetsims/scenery/issues/581","repository_url":"https://api.github.com/repos/phetsims/scenery","labels_url":"https://api.github.com/repos/phetsims/scenery/issues/581/labels{/name}","comments_url":"https://api.github.com/repos/phetsims/scenery/issues/581/comments","events_url":"https://api.github.com/repos/phetsims/scenery/issues/581/events","html_url":"https://github.com/phetsims/scenery/issues/581","id":188891393,"number":581,"title":"How to handle generated function definitions","user":{"login":"jonathanolson","id":480878,"avatar_url":"https://avatars.githubusercontent.com/u/480878?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanolson","html_url":"https://github.com/jonathanolson","followers_url":"https://api.github.com/users/jonathanolson/followers","following_url":"https://api.github.com/users/jonathanolson/following{/other_user}","gists_url":"https://api.github.com/users/jonathanolson/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanolson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanolson/subscriptions","organizations_url":"https://api.github.com/users/jonathanolson/orgs","repos_url":"https://api.github.com/users/jonathanolson/repos","events_url":"https://api.github.com/users/jonathanolson/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanolson/received_events","type":"User","site_admin":false},"labels":[{"id":322178764,"url":"https://api.github.com/repos/phetsims/scenery/labels/meeting:developer","name":"meeting:developer","color":"000000","default":false}],"state":"open","locked":false,"assignee":{"login":"jonathanolson","id":480878,"avatar_url":"https://avatars.githubusercontent.com/u/480878?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanolson","html_url":"https://github.com/jonathanolson","followers_url":"https://api.github.com/users/jonathanolson/followers","following_url":"https://api.github.com/users/jonathanolson/following{/other_user}","gists_url":"https://api.github.com/users/jonathanolson/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanolson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanolson/subscriptions","organizations_url":"https://api.github.com/users/jonathanolson/orgs","repos_url":"https://api.github.com/users/jonathanolson/repos","events_url":"https://api.github.com/users/jonathanolson/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanolson/received_events","type":"User","site_admin":false},"assignees":[{"login":"jonathanolson","id":480878,"avatar_url":"https://avatars.githubusercontent.com/u/480878?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanolson","html_url":"https://github.com/jonathanolson","followers_url":"https://api.github.com/users/jonathanolson/followers","following_url":"https://api.github.com/users/jonathanolson/following{/other_user}","gists_url":"https://api.github.com/users/jonathanolson/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanolson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanolson/subscriptions","organizations_url":"https://api.github.com/users/jonathanolson/orgs","repos_url":"https://api.github.com/users/jonathanolson/repos","events_url":"https://api.github.com/users/jonathanolson/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanolson/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2016-11-12T04:21:10Z","updated_at":"2016-11-17T15:48:08Z","closed_at":null,"body":"Currently, there are a number of methods that are auto-generated (instead of being inside the inherit block). These may mess with editor auto-completion/inspections, and are generally harder to read and document.\r\n\r\n## Question:\r\n\r\nShould these be expanded to normal definitions in the inherit block?\r\n\r\n- Benefits: more readable (and easier to document), can navigate in editors, and performance may slightly increase\r\n- Drawbacks: increases file size, and potentially increases the (usually unlikely) modification/refactoring cost of changing all usages at once.\r\n\r\n## Current generated Scenery methods:\r\n\r\nNode:\r\n\r\n- leftTop\r\n- centerTop\r\n- rightTop\r\n- leftCenter\r\n- center\r\n- rightCenter\r\n- leftBottom\r\n- centerBottom\r\n- rightBottom\r\n\r\nLine:\r\n\r\n- x1\r\n- y1\r\n- x2\r\n- y2\r\n\r\nRectangle:\r\n\r\n- rectX\r\n- rectY\r\n- rectWidth\r\n- rectHeight\r\n- cornerXRadius\r\n- cornerYRadius\r\n\r\nText:\r\n\r\n- fontWeight\r\n- fontFamily\r\n- fontStretch\r\n- fontStyle\r\n- fontSize"},"comment":{"url":"https://api.github.com/repos/phetsims/scenery/issues/comments/261283015","html_url":"https://github.com/phetsims/scenery/issues/581#issuecomment-261283015","issue_url":"https://api.github.com/repos/phetsims/scenery/issues/581","id":261283015,"user":{"login":"pixelzoom","id":3046552,"avatar_url":"https://avatars.githubusercontent.com/u/3046552?v=3","gravatar_id":"","url":"https://api.github.com/users/pixelzoom","html_url":"https://github.com/pixelzoom","followers_url":"https://api.github.com/users/pixelzoom/followers","following_url":"https://api.github.com/users/pixelzoom/following{/other_user}","gists_url":"https://api.github.com/users/pixelzoom/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelzoom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelzoom/subscriptions","organizations_url":"https://api.github.com/users/pixelzoom/orgs","repos_url":"https://api.github.com/users/pixelzoom/repos","events_url":"https://api.github.com/users/pixelzoom/events{/privacy}","received_events_url":"https://api.github.com/users/pixelzoom/received_events","type":"User","site_admin":false},"created_at":"2016-11-17T15:48:08Z","updated_at":"2016-11-17T15:48:08Z","body":"The expanded functions (and especially their documentation) look nice in Node.  I think that ~0.4kB size increase is a negligible price to pay for this improvement."}}
{"actor":{"display_login":"pixelzoom"}}