{"action":"created","comment":{"url":"https://api.github.com/repos/kklis/proxy/pulls/comments/85584194","pull_request_review_id":6294164,"id":85584194,"diff_hunk":"@@ -184,13 +185,21 @@ void sigterm_handler(int signal) {\n     exit(0);\n }\n \n+int set_reuseaddr(int sock)","path":"proxy.c","position":47,"original_position":47,"commit_id":"9c0da3513e74efe205e248978d95dee890b6459b","original_commit_id":"9c0da3513e74efe205e248978d95dee890b6459b","user":{"login":"ticpu","id":1229687,"avatar_url":"https://avatars.githubusercontent.com/u/1229687?v=3","gravatar_id":"","url":"https://api.github.com/users/ticpu","html_url":"https://github.com/ticpu","followers_url":"https://api.github.com/users/ticpu/followers","following_url":"https://api.github.com/users/ticpu/following{/other_user}","gists_url":"https://api.github.com/users/ticpu/gists{/gist_id}","starred_url":"https://api.github.com/users/ticpu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ticpu/subscriptions","organizations_url":"https://api.github.com/users/ticpu/orgs","repos_url":"https://api.github.com/users/ticpu/repos","events_url":"https://api.github.com/users/ticpu/events{/privacy}","received_events_url":"https://api.github.com/users/ticpu/received_events","type":"User","site_admin":false},"body":"In this context you are right, I customized the proxy for my use in my own branch and had to re-use it so I made it a function.\r\n\r\nI'll just add =1 to optval for your branch.","created_at":"2016-10-28T18:22:57Z","updated_at":"2016-10-28T18:22:57Z","html_url":"https://github.com/kklis/proxy/pull/1#discussion_r85584194","pull_request_url":"https://api.github.com/repos/kklis/proxy/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/kklis/proxy/pulls/comments/85584194"},"html":{"href":"https://github.com/kklis/proxy/pull/1#discussion_r85584194"},"pull_request":{"href":"https://api.github.com/repos/kklis/proxy/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/kklis/proxy/pulls/1","id":91396816,"html_url":"https://github.com/kklis/proxy/pull/1","diff_url":"https://github.com/kklis/proxy/pull/1.diff","patch_url":"https://github.com/kklis/proxy/pull/1.patch","issue_url":"https://api.github.com/repos/kklis/proxy/issues/1","number":1,"state":"open","locked":false,"title":"Various fixes","user":{"login":"ticpu","id":1229687,"avatar_url":"https://avatars.githubusercontent.com/u/1229687?v=3","gravatar_id":"","url":"https://api.github.com/users/ticpu","html_url":"https://github.com/ticpu","followers_url":"https://api.github.com/users/ticpu/followers","following_url":"https://api.github.com/users/ticpu/following{/other_user}","gists_url":"https://api.github.com/users/ticpu/gists{/gist_id}","starred_url":"https://api.github.com/users/ticpu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ticpu/subscriptions","organizations_url":"https://api.github.com/users/ticpu/orgs","repos_url":"https://api.github.com/users/ticpu/repos","events_url":"https://api.github.com/users/ticpu/events{/privacy}","received_events_url":"https://api.github.com/users/ticpu/received_events","type":"User","site_admin":false},"body":"- SO_REUSEADDR wasn't set most of the time since it was depending on uninitialized optval.\r\n- BUF_SIZE was less than MTU resulting in sub-optimal performance.\r\n- Sockets weren't closed in the event of a failure to connect to remote.\r\n- Fixed some compiler warnings about invalid data types.","created_at":"2016-10-28T14:58:13Z","updated_at":"2016-10-28T18:22:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63753df4aab7f6cf2f082423126794cd0d38d202","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kklis/proxy/pulls/1/commits","review_comments_url":"https://api.github.com/repos/kklis/proxy/pulls/1/comments","review_comment_url":"https://api.github.com/repos/kklis/proxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kklis/proxy/issues/1/comments","statuses_url":"https://api.github.com/repos/kklis/proxy/statuses/9c0da3513e74efe205e248978d95dee890b6459b","head":{"label":"ticpu:various_fix","ref":"various_fix","sha":"9c0da3513e74efe205e248978d95dee890b6459b","user":{"login":"ticpu","id":1229687,"avatar_url":"https://avatars.githubusercontent.com/u/1229687?v=3","gravatar_id":"","url":"https://api.github.com/users/ticpu","html_url":"https://github.com/ticpu","followers_url":"https://api.github.com/users/ticpu/followers","following_url":"https://api.github.com/users/ticpu/following{/other_user}","gists_url":"https://api.github.com/users/ticpu/gists{/gist_id}","starred_url":"https://api.github.com/users/ticpu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ticpu/subscriptions","organizations_url":"https://api.github.com/users/ticpu/orgs","repos_url":"https://api.github.com/users/ticpu/repos","events_url":"https://api.github.com/users/ticpu/events{/privacy}","received_events_url":"https://api.github.com/users/ticpu/received_events","type":"User","site_admin":false},"repo":{"id":72214876,"name":"proxy","full_name":"ticpu/proxy","owner":{"login":"ticpu","id":1229687,"avatar_url":"https://avatars.githubusercontent.com/u/1229687?v=3","gravatar_id":"","url":"https://api.github.com/users/ticpu","html_url":"https://github.com/ticpu","followers_url":"https://api.github.com/users/ticpu/followers","following_url":"https://api.github.com/users/ticpu/following{/other_user}","gists_url":"https://api.github.com/users/ticpu/gists{/gist_id}","starred_url":"https://api.github.com/users/ticpu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ticpu/subscriptions","organizations_url":"https://api.github.com/users/ticpu/orgs","repos_url":"https://api.github.com/users/ticpu/repos","events_url":"https://api.github.com/users/ticpu/events{/privacy}","received_events_url":"https://api.github.com/users/ticpu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ticpu/proxy","description":"TCP proxy in ANSI C","fork":true,"url":"https://api.github.com/repos/ticpu/proxy","forks_url":"https://api.github.com/repos/ticpu/proxy/forks","keys_url":"https://api.github.com/repos/ticpu/proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ticpu/proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ticpu/proxy/teams","hooks_url":"https://api.github.com/repos/ticpu/proxy/hooks","issue_events_url":"https://api.github.com/repos/ticpu/proxy/issues/events{/number}","events_url":"https://api.github.com/repos/ticpu/proxy/events","assignees_url":"https://api.github.com/repos/ticpu/proxy/assignees{/user}","branches_url":"https://api.github.com/repos/ticpu/proxy/branches{/branch}","tags_url":"https://api.github.com/repos/ticpu/proxy/tags","blobs_url":"https://api.github.com/repos/ticpu/proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ticpu/proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ticpu/proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ticpu/proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ticpu/proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/ticpu/proxy/languages","stargazers_url":"https://api.github.com/repos/ticpu/proxy/stargazers","contributors_url":"https://api.github.com/repos/ticpu/proxy/contributors","subscribers_url":"https://api.github.com/repos/ticpu/proxy/subscribers","subscription_url":"https://api.github.com/repos/ticpu/proxy/subscription","commits_url":"https://api.github.com/repos/ticpu/proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ticpu/proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ticpu/proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ticpu/proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/ticpu/proxy/contents/{+path}","compare_url":"https://api.github.com/repos/ticpu/proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ticpu/proxy/merges","archive_url":"https://api.github.com/repos/ticpu/proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ticpu/proxy/downloads","issues_url":"https://api.github.com/repos/ticpu/proxy/issues{/number}","pulls_url":"https://api.github.com/repos/ticpu/proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/ticpu/proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/ticpu/proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ticpu/proxy/labels{/name}","releases_url":"https://api.github.com/repos/ticpu/proxy/releases{/id}","deployments_url":"https://api.github.com/repos/ticpu/proxy/deployments","created_at":"2016-10-28T14:33:59Z","updated_at":"2016-10-28T14:34:00Z","pushed_at":"2016-10-28T14:55:41Z","git_url":"git://github.com/ticpu/proxy.git","ssh_url":"git@github.com:ticpu/proxy.git","clone_url":"https://github.com/ticpu/proxy.git","svn_url":"https://github.com/ticpu/proxy","homepage":null,"size":21,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kklis:master","ref":"master","sha":"e0ee747c4ed7003da88a32c4bc8734a2bbe9754b","user":{"login":"kklis","id":174346,"avatar_url":"https://avatars.githubusercontent.com/u/174346?v=3","gravatar_id":"","url":"https://api.github.com/users/kklis","html_url":"https://github.com/kklis","followers_url":"https://api.github.com/users/kklis/followers","following_url":"https://api.github.com/users/kklis/following{/other_user}","gists_url":"https://api.github.com/users/kklis/gists{/gist_id}","starred_url":"https://api.github.com/users/kklis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kklis/subscriptions","organizations_url":"https://api.github.com/users/kklis/orgs","repos_url":"https://api.github.com/users/kklis/repos","events_url":"https://api.github.com/users/kklis/events{/privacy}","received_events_url":"https://api.github.com/users/kklis/received_events","type":"User","site_admin":false},"repo":{"id":4617884,"name":"proxy","full_name":"kklis/proxy","owner":{"login":"kklis","id":174346,"avatar_url":"https://avatars.githubusercontent.com/u/174346?v=3","gravatar_id":"","url":"https://api.github.com/users/kklis","html_url":"https://github.com/kklis","followers_url":"https://api.github.com/users/kklis/followers","following_url":"https://api.github.com/users/kklis/following{/other_user}","gists_url":"https://api.github.com/users/kklis/gists{/gist_id}","starred_url":"https://api.github.com/users/kklis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kklis/subscriptions","organizations_url":"https://api.github.com/users/kklis/orgs","repos_url":"https://api.github.com/users/kklis/repos","events_url":"https://api.github.com/users/kklis/events{/privacy}","received_events_url":"https://api.github.com/users/kklis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kklis/proxy","description":"TCP proxy in ANSI C","fork":false,"url":"https://api.github.com/repos/kklis/proxy","forks_url":"https://api.github.com/repos/kklis/proxy/forks","keys_url":"https://api.github.com/repos/kklis/proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kklis/proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kklis/proxy/teams","hooks_url":"https://api.github.com/repos/kklis/proxy/hooks","issue_events_url":"https://api.github.com/repos/kklis/proxy/issues/events{/number}","events_url":"https://api.github.com/repos/kklis/proxy/events","assignees_url":"https://api.github.com/repos/kklis/proxy/assignees{/user}","branches_url":"https://api.github.com/repos/kklis/proxy/branches{/branch}","tags_url":"https://api.github.com/repos/kklis/proxy/tags","blobs_url":"https://api.github.com/repos/kklis/proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kklis/proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kklis/proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/kklis/proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kklis/proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/kklis/proxy/languages","stargazers_url":"https://api.github.com/repos/kklis/proxy/stargazers","contributors_url":"https://api.github.com/repos/kklis/proxy/contributors","subscribers_url":"https://api.github.com/repos/kklis/proxy/subscribers","subscription_url":"https://api.github.com/repos/kklis/proxy/subscription","commits_url":"https://api.github.com/repos/kklis/proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/kklis/proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/kklis/proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/kklis/proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/kklis/proxy/contents/{+path}","compare_url":"https://api.github.com/repos/kklis/proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kklis/proxy/merges","archive_url":"https://api.github.com/repos/kklis/proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kklis/proxy/downloads","issues_url":"https://api.github.com/repos/kklis/proxy/issues{/number}","pulls_url":"https://api.github.com/repos/kklis/proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/kklis/proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/kklis/proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kklis/proxy/labels{/name}","releases_url":"https://api.github.com/repos/kklis/proxy/releases{/id}","deployments_url":"https://api.github.com/repos/kklis/proxy/deployments","created_at":"2012-06-10T19:57:34Z","updated_at":"2016-10-28T18:15:46Z","pushed_at":"2016-10-28T15:00:42Z","git_url":"git://github.com/kklis/proxy.git","ssh_url":"git@github.com:kklis/proxy.git","clone_url":"https://github.com/kklis/proxy.git","svn_url":"https://github.com/kklis/proxy","homepage":null,"size":24,"stargazers_count":82,"watchers_count":82,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":3,"forks":55,"open_issues":3,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kklis/proxy/pulls/1"},"html":{"href":"https://github.com/kklis/proxy/pull/1"},"issue":{"href":"https://api.github.com/repos/kklis/proxy/issues/1"},"comments":{"href":"https://api.github.com/repos/kklis/proxy/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/kklis/proxy/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/kklis/proxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kklis/proxy/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/kklis/proxy/statuses/9c0da3513e74efe205e248978d95dee890b6459b"}}}}
{"actor":{"display_login":"ticpu"}}