{"action":"created","comment":{"url":"https://api.github.com/repos/mlpack/mlpack/pulls/comments/66364472","id":66364472,"diff_hunk":"@@ -0,0 +1,304 @@\n+/**\n+ * @file genome.hpp\n+ * @author Bang Liu\n+ *\n+ * Definition of the Genome class.\n+ */\n+#ifndef MLPACK_METHODS_NE_GENOME_HPP\n+#define MLPACK_METHODS_NE_GENOME_HPP\n+\n+#include <cassert>\n+#include <map>\n+\n+#include <mlpack/core.hpp>\n+\n+#include \"gene.hpp\"\n+#include \"utils.hpp\"\n+\n+namespace mlpack {\n+namespace ne {\n+\n+/**\n+ * This class defines a genome.\n+ # A genome is consist of a group of genes.\n+ */\n+class Genome {\n+ public:\n+  // Default constructor.\n+  Genome() {}\n+  \n+  // Parametric constructor.\n+  Genome(unsigned int id,\n+  \t     std::vector<NeuronGene> neuronGenes,","path":"src/mlpack/methods/ne/genome.hpp","position":32,"original_position":32,"commit_id":"3c8aa62b951f029b3883e9baef1ea556ef5af2d3","original_commit_id":"3c8aa62b951f029b3883e9baef1ea556ef5af2d3","user":{"login":"zoq","id":4209744,"avatar_url":"https://avatars.githubusercontent.com/u/4209744?v=3","gravatar_id":"","url":"https://api.github.com/users/zoq","html_url":"https://github.com/zoq","followers_url":"https://api.github.com/users/zoq/followers","following_url":"https://api.github.com/users/zoq/following{/other_user}","gists_url":"https://api.github.com/users/zoq/gists{/gist_id}","starred_url":"https://api.github.com/users/zoq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoq/subscriptions","organizations_url":"https://api.github.com/users/zoq/orgs","repos_url":"https://api.github.com/users/zoq/repos","events_url":"https://api.github.com/users/zoq/events{/privacy}","received_events_url":"https://api.github.com/users/zoq/received_events","type":"User","site_admin":false},"body":"I think it would be a good idea to use a reference here to avoid copying the object:\r\n\r\n``\r\nGenome(unsigned int id, const std::vector<NeuronGene>& neuronGenes, ...)\r\n``","created_at":"2016-06-09T00:15:56Z","updated_at":"2016-06-09T00:15:56Z","html_url":"https://github.com/mlpack/mlpack/pull/686#discussion_r66364472","pull_request_url":"https://api.github.com/repos/mlpack/mlpack/pulls/686","_links":{"self":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/comments/66364472"},"html":{"href":"https://github.com/mlpack/mlpack/pull/686#discussion_r66364472"},"pull_request":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/686"}}},"pull_request":{"url":"https://api.github.com/repos/mlpack/mlpack/pulls/686","id":72912680,"html_url":"https://github.com/mlpack/mlpack/pull/686","diff_url":"https://github.com/mlpack/mlpack/pull/686.diff","patch_url":"https://github.com/mlpack/mlpack/pull/686.patch","issue_url":"https://api.github.com/repos/mlpack/mlpack/issues/686","number":686,"state":"open","locked":false,"title":"NeuralEvolution - implemented gene, genome","user":{"login":"BangLiu","id":4156705,"avatar_url":"https://avatars.githubusercontent.com/u/4156705?v=3","gravatar_id":"","url":"https://api.github.com/users/BangLiu","html_url":"https://github.com/BangLiu","followers_url":"https://api.github.com/users/BangLiu/followers","following_url":"https://api.github.com/users/BangLiu/following{/other_user}","gists_url":"https://api.github.com/users/BangLiu/gists{/gist_id}","starred_url":"https://api.github.com/users/BangLiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BangLiu/subscriptions","organizations_url":"https://api.github.com/users/BangLiu/orgs","repos_url":"https://api.github.com/users/BangLiu/repos","events_url":"https://api.github.com/users/BangLiu/events{/privacy}","received_events_url":"https://api.github.com/users/BangLiu/received_events","type":"User","site_admin":false},"body":"This PR implements the concepts in NE algorithms by classes.\r\nThe finished classes (for current CNE algorithm) includes:\r\nLinkGene\r\nNeuronGene\r\nGenome\r\n\r\nClasses in progress includes:\r\nPopulation\r\nCNE ","created_at":"2016-06-07T17:06:37Z","updated_at":"2016-06-09T00:15:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69d5187bcf3c1f61e0038f976a95f46c03ee4d3d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mlpack/mlpack/pulls/686/commits","review_comments_url":"https://api.github.com/repos/mlpack/mlpack/pulls/686/comments","review_comment_url":"https://api.github.com/repos/mlpack/mlpack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mlpack/mlpack/issues/686/comments","statuses_url":"https://api.github.com/repos/mlpack/mlpack/statuses/3c8aa62b951f029b3883e9baef1ea556ef5af2d3","head":{"label":"BangLiu:ne","ref":"ne","sha":"3c8aa62b951f029b3883e9baef1ea556ef5af2d3","user":{"login":"BangLiu","id":4156705,"avatar_url":"https://avatars.githubusercontent.com/u/4156705?v=3","gravatar_id":"","url":"https://api.github.com/users/BangLiu","html_url":"https://github.com/BangLiu","followers_url":"https://api.github.com/users/BangLiu/followers","following_url":"https://api.github.com/users/BangLiu/following{/other_user}","gists_url":"https://api.github.com/users/BangLiu/gists{/gist_id}","starred_url":"https://api.github.com/users/BangLiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BangLiu/subscriptions","organizations_url":"https://api.github.com/users/BangLiu/orgs","repos_url":"https://api.github.com/users/BangLiu/repos","events_url":"https://api.github.com/users/BangLiu/events{/privacy}","received_events_url":"https://api.github.com/users/BangLiu/received_events","type":"User","site_admin":false},"repo":{"id":58986089,"name":"mlpack","full_name":"BangLiu/mlpack","owner":{"login":"BangLiu","id":4156705,"avatar_url":"https://avatars.githubusercontent.com/u/4156705?v=3","gravatar_id":"","url":"https://api.github.com/users/BangLiu","html_url":"https://github.com/BangLiu","followers_url":"https://api.github.com/users/BangLiu/followers","following_url":"https://api.github.com/users/BangLiu/following{/other_user}","gists_url":"https://api.github.com/users/BangLiu/gists{/gist_id}","starred_url":"https://api.github.com/users/BangLiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BangLiu/subscriptions","organizations_url":"https://api.github.com/users/BangLiu/orgs","repos_url":"https://api.github.com/users/BangLiu/repos","events_url":"https://api.github.com/users/BangLiu/events{/privacy}","received_events_url":"https://api.github.com/users/BangLiu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BangLiu/mlpack","description":"mlpack: a scalable C++ machine learning library","fork":true,"url":"https://api.github.com/repos/BangLiu/mlpack","forks_url":"https://api.github.com/repos/BangLiu/mlpack/forks","keys_url":"https://api.github.com/repos/BangLiu/mlpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BangLiu/mlpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BangLiu/mlpack/teams","hooks_url":"https://api.github.com/repos/BangLiu/mlpack/hooks","issue_events_url":"https://api.github.com/repos/BangLiu/mlpack/issues/events{/number}","events_url":"https://api.github.com/repos/BangLiu/mlpack/events","assignees_url":"https://api.github.com/repos/BangLiu/mlpack/assignees{/user}","branches_url":"https://api.github.com/repos/BangLiu/mlpack/branches{/branch}","tags_url":"https://api.github.com/repos/BangLiu/mlpack/tags","blobs_url":"https://api.github.com/repos/BangLiu/mlpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BangLiu/mlpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BangLiu/mlpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/BangLiu/mlpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BangLiu/mlpack/statuses/{sha}","languages_url":"https://api.github.com/repos/BangLiu/mlpack/languages","stargazers_url":"https://api.github.com/repos/BangLiu/mlpack/stargazers","contributors_url":"https://api.github.com/repos/BangLiu/mlpack/contributors","subscribers_url":"https://api.github.com/repos/BangLiu/mlpack/subscribers","subscription_url":"https://api.github.com/repos/BangLiu/mlpack/subscription","commits_url":"https://api.github.com/repos/BangLiu/mlpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/BangLiu/mlpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/BangLiu/mlpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/BangLiu/mlpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/BangLiu/mlpack/contents/{+path}","compare_url":"https://api.github.com/repos/BangLiu/mlpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BangLiu/mlpack/merges","archive_url":"https://api.github.com/repos/BangLiu/mlpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BangLiu/mlpack/downloads","issues_url":"https://api.github.com/repos/BangLiu/mlpack/issues{/number}","pulls_url":"https://api.github.com/repos/BangLiu/mlpack/pulls{/number}","milestones_url":"https://api.github.com/repos/BangLiu/mlpack/milestones{/number}","notifications_url":"https://api.github.com/repos/BangLiu/mlpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BangLiu/mlpack/labels{/name}","releases_url":"https://api.github.com/repos/BangLiu/mlpack/releases{/id}","deployments_url":"https://api.github.com/repos/BangLiu/mlpack/deployments","created_at":"2016-05-17T03:04:31Z","updated_at":"2016-05-17T03:04:35Z","pushed_at":"2016-06-07T05:28:07Z","git_url":"git://github.com/BangLiu/mlpack.git","ssh_url":"git@github.com:BangLiu/mlpack.git","clone_url":"https://github.com/BangLiu/mlpack.git","svn_url":"https://github.com/BangLiu/mlpack","homepage":null,"size":145472,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mlpack:master","ref":"master","sha":"44883afb19a2f2dd0e1fe29d96c873bf97335521","user":{"login":"mlpack","id":10216045,"avatar_url":"https://avatars.githubusercontent.com/u/10216045?v=3","gravatar_id":"","url":"https://api.github.com/users/mlpack","html_url":"https://github.com/mlpack","followers_url":"https://api.github.com/users/mlpack/followers","following_url":"https://api.github.com/users/mlpack/following{/other_user}","gists_url":"https://api.github.com/users/mlpack/gists{/gist_id}","starred_url":"https://api.github.com/users/mlpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlpack/subscriptions","organizations_url":"https://api.github.com/users/mlpack/orgs","repos_url":"https://api.github.com/users/mlpack/repos","events_url":"https://api.github.com/users/mlpack/events{/privacy}","received_events_url":"https://api.github.com/users/mlpack/received_events","type":"Organization","site_admin":false},"repo":{"id":28149409,"name":"mlpack","full_name":"mlpack/mlpack","owner":{"login":"mlpack","id":10216045,"avatar_url":"https://avatars.githubusercontent.com/u/10216045?v=3","gravatar_id":"","url":"https://api.github.com/users/mlpack","html_url":"https://github.com/mlpack","followers_url":"https://api.github.com/users/mlpack/followers","following_url":"https://api.github.com/users/mlpack/following{/other_user}","gists_url":"https://api.github.com/users/mlpack/gists{/gist_id}","starred_url":"https://api.github.com/users/mlpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlpack/subscriptions","organizations_url":"https://api.github.com/users/mlpack/orgs","repos_url":"https://api.github.com/users/mlpack/repos","events_url":"https://api.github.com/users/mlpack/events{/privacy}","received_events_url":"https://api.github.com/users/mlpack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mlpack/mlpack","description":"mlpack: a scalable C++ machine learning library","fork":false,"url":"https://api.github.com/repos/mlpack/mlpack","forks_url":"https://api.github.com/repos/mlpack/mlpack/forks","keys_url":"https://api.github.com/repos/mlpack/mlpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlpack/mlpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlpack/mlpack/teams","hooks_url":"https://api.github.com/repos/mlpack/mlpack/hooks","issue_events_url":"https://api.github.com/repos/mlpack/mlpack/issues/events{/number}","events_url":"https://api.github.com/repos/mlpack/mlpack/events","assignees_url":"https://api.github.com/repos/mlpack/mlpack/assignees{/user}","branches_url":"https://api.github.com/repos/mlpack/mlpack/branches{/branch}","tags_url":"https://api.github.com/repos/mlpack/mlpack/tags","blobs_url":"https://api.github.com/repos/mlpack/mlpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlpack/mlpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlpack/mlpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlpack/mlpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlpack/mlpack/statuses/{sha}","languages_url":"https://api.github.com/repos/mlpack/mlpack/languages","stargazers_url":"https://api.github.com/repos/mlpack/mlpack/stargazers","contributors_url":"https://api.github.com/repos/mlpack/mlpack/contributors","subscribers_url":"https://api.github.com/repos/mlpack/mlpack/subscribers","subscription_url":"https://api.github.com/repos/mlpack/mlpack/subscription","commits_url":"https://api.github.com/repos/mlpack/mlpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlpack/mlpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlpack/mlpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlpack/mlpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlpack/mlpack/contents/{+path}","compare_url":"https://api.github.com/repos/mlpack/mlpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlpack/mlpack/merges","archive_url":"https://api.github.com/repos/mlpack/mlpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlpack/mlpack/downloads","issues_url":"https://api.github.com/repos/mlpack/mlpack/issues{/number}","pulls_url":"https://api.github.com/repos/mlpack/mlpack/pulls{/number}","milestones_url":"https://api.github.com/repos/mlpack/mlpack/milestones{/number}","notifications_url":"https://api.github.com/repos/mlpack/mlpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlpack/mlpack/labels{/name}","releases_url":"https://api.github.com/repos/mlpack/mlpack/releases{/id}","deployments_url":"https://api.github.com/repos/mlpack/mlpack/deployments","created_at":"2014-12-17T18:16:59Z","updated_at":"2016-06-07T08:46:26Z","pushed_at":"2016-06-08T21:47:18Z","git_url":"git://github.com/mlpack/mlpack.git","ssh_url":"git@github.com:mlpack/mlpack.git","clone_url":"https://github.com/mlpack/mlpack.git","svn_url":"https://github.com/mlpack/mlpack","homepage":null,"size":165207,"stargazers_count":863,"watchers_count":863,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":343,"mirror_url":null,"open_issues_count":72,"forks":343,"open_issues":72,"watchers":863,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/686"},"html":{"href":"https://github.com/mlpack/mlpack/pull/686"},"issue":{"href":"https://api.github.com/repos/mlpack/mlpack/issues/686"},"comments":{"href":"https://api.github.com/repos/mlpack/mlpack/issues/686/comments"},"review_comments":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/686/comments"},"review_comment":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/686/commits"},"statuses":{"href":"https://api.github.com/repos/mlpack/mlpack/statuses/3c8aa62b951f029b3883e9baef1ea556ef5af2d3"}}}}
{"actor":{"display_login":"zoq"}}