{"action":"closed","number":347,"pull_request":{"url":"https://api.github.com/repos/ceph/ceph-docker/pulls/347","id":78774220,"html_url":"https://github.com/ceph/ceph-docker/pull/347","diff_url":"https://github.com/ceph/ceph-docker/pull/347.diff","patch_url":"https://github.com/ceph/ceph-docker/pull/347.patch","issue_url":"https://api.github.com/repos/ceph/ceph-docker/issues/347","number":347,"state":"closed","locked":false,"title":"entrypoint: accept /dev/disk/by-x names for OSD_DEVICE","user":{"login":"immesys","id":4234131,"avatar_url":"https://avatars.githubusercontent.com/u/4234131?v=3","gravatar_id":"","url":"https://api.github.com/users/immesys","html_url":"https://github.com/immesys","followers_url":"https://api.github.com/users/immesys/followers","following_url":"https://api.github.com/users/immesys/following{/other_user}","gists_url":"https://api.github.com/users/immesys/gists{/gist_id}","starred_url":"https://api.github.com/users/immesys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/immesys/subscriptions","organizations_url":"https://api.github.com/users/immesys/orgs","repos_url":"https://api.github.com/users/immesys/repos","events_url":"https://api.github.com/users/immesys/events{/privacy}","received_events_url":"https://api.github.com/users/immesys/received_events","type":"User","site_admin":false},"body":"I was having some difficulty on some servers that would somewhat arbitrarily reorganize the /dev/sdx devices. I solved it on one server by fully specifying /dev/disk/by-x names for the OSD device and journal, but on some of the servers, I wanted to just specify OSD_DEVICE and let the journal selection be automatic. The process is essentially \r\n\r\n- find the actual device the symlink points to\r\n- form the requested partition of that device as a /dev/sdx name\r\n- find the symlink that is most similar to the original symlink that points to the partition we want\r\n\r\nThis allows you to use wwn or label or pci path or whatever symlink to specify your disk, and the automatic journal choice will be an equivalent symlink.\r\n\r\nThis is pretty easy to test, just source the functions into your shell and invoke dev_part a couple times. I also tested it in production.","created_at":"2016-07-26T00:27:08Z","updated_at":"2016-08-08T12:14:20Z","closed_at":"2016-08-08T12:14:20Z","merged_at":"2016-08-08T12:14:20Z","merge_commit_sha":"d00bca463759418ca80b52cb43de9e0ab7d6b900","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph-docker/pulls/347/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph-docker/pulls/347/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph-docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph-docker/issues/347/comments","statuses_url":"https://api.github.com/repos/ceph/ceph-docker/statuses/d5a7f2593f4916b8657f5e238ba324be2a3a1e47","head":{"label":"immesys:feature-support-symlinks","ref":"feature-support-symlinks","sha":"d5a7f2593f4916b8657f5e238ba324be2a3a1e47","user":{"login":"immesys","id":4234131,"avatar_url":"https://avatars.githubusercontent.com/u/4234131?v=3","gravatar_id":"","url":"https://api.github.com/users/immesys","html_url":"https://github.com/immesys","followers_url":"https://api.github.com/users/immesys/followers","following_url":"https://api.github.com/users/immesys/following{/other_user}","gists_url":"https://api.github.com/users/immesys/gists{/gist_id}","starred_url":"https://api.github.com/users/immesys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/immesys/subscriptions","organizations_url":"https://api.github.com/users/immesys/orgs","repos_url":"https://api.github.com/users/immesys/repos","events_url":"https://api.github.com/users/immesys/events{/privacy}","received_events_url":"https://api.github.com/users/immesys/received_events","type":"User","site_admin":false},"repo":{"id":61688341,"name":"ceph-docker","full_name":"immesys/ceph-docker","owner":{"login":"immesys","id":4234131,"avatar_url":"https://avatars.githubusercontent.com/u/4234131?v=3","gravatar_id":"","url":"https://api.github.com/users/immesys","html_url":"https://github.com/immesys","followers_url":"https://api.github.com/users/immesys/followers","following_url":"https://api.github.com/users/immesys/following{/other_user}","gists_url":"https://api.github.com/users/immesys/gists{/gist_id}","starred_url":"https://api.github.com/users/immesys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/immesys/subscriptions","organizations_url":"https://api.github.com/users/immesys/orgs","repos_url":"https://api.github.com/users/immesys/repos","events_url":"https://api.github.com/users/immesys/events{/privacy}","received_events_url":"https://api.github.com/users/immesys/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/immesys/ceph-docker","description":"Docker files and images to run Ceph in containers","fork":true,"url":"https://api.github.com/repos/immesys/ceph-docker","forks_url":"https://api.github.com/repos/immesys/ceph-docker/forks","keys_url":"https://api.github.com/repos/immesys/ceph-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/immesys/ceph-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/immesys/ceph-docker/teams","hooks_url":"https://api.github.com/repos/immesys/ceph-docker/hooks","issue_events_url":"https://api.github.com/repos/immesys/ceph-docker/issues/events{/number}","events_url":"https://api.github.com/repos/immesys/ceph-docker/events","assignees_url":"https://api.github.com/repos/immesys/ceph-docker/assignees{/user}","branches_url":"https://api.github.com/repos/immesys/ceph-docker/branches{/branch}","tags_url":"https://api.github.com/repos/immesys/ceph-docker/tags","blobs_url":"https://api.github.com/repos/immesys/ceph-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/immesys/ceph-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/immesys/ceph-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/immesys/ceph-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/immesys/ceph-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/immesys/ceph-docker/languages","stargazers_url":"https://api.github.com/repos/immesys/ceph-docker/stargazers","contributors_url":"https://api.github.com/repos/immesys/ceph-docker/contributors","subscribers_url":"https://api.github.com/repos/immesys/ceph-docker/subscribers","subscription_url":"https://api.github.com/repos/immesys/ceph-docker/subscription","commits_url":"https://api.github.com/repos/immesys/ceph-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/immesys/ceph-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/immesys/ceph-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/immesys/ceph-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/immesys/ceph-docker/contents/{+path}","compare_url":"https://api.github.com/repos/immesys/ceph-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/immesys/ceph-docker/merges","archive_url":"https://api.github.com/repos/immesys/ceph-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/immesys/ceph-docker/downloads","issues_url":"https://api.github.com/repos/immesys/ceph-docker/issues{/number}","pulls_url":"https://api.github.com/repos/immesys/ceph-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/immesys/ceph-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/immesys/ceph-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/immesys/ceph-docker/labels{/name}","releases_url":"https://api.github.com/repos/immesys/ceph-docker/releases{/id}","deployments_url":"https://api.github.com/repos/immesys/ceph-docker/deployments","created_at":"2016-06-22T04:15:30Z","updated_at":"2016-06-22T04:15:31Z","pushed_at":"2016-07-26T00:21:21Z","git_url":"git://github.com/immesys/ceph-docker.git","ssh_url":"git@github.com:immesys/ceph-docker.git","clone_url":"https://github.com/immesys/ceph-docker.git","svn_url":"https://github.com/immesys/ceph-docker","homepage":null,"size":6049,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"3970cdaef33aed7aaae19a826fcba195a09de429","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":29601598,"name":"ceph-docker","full_name":"ceph/ceph-docker","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph-docker","description":"Docker files and images to run Ceph in containers","fork":false,"url":"https://api.github.com/repos/ceph/ceph-docker","forks_url":"https://api.github.com/repos/ceph/ceph-docker/forks","keys_url":"https://api.github.com/repos/ceph/ceph-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph-docker/teams","hooks_url":"https://api.github.com/repos/ceph/ceph-docker/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph-docker/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph-docker/events","assignees_url":"https://api.github.com/repos/ceph/ceph-docker/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph-docker/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph-docker/tags","blobs_url":"https://api.github.com/repos/ceph/ceph-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph-docker/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph-docker/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph-docker/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph-docker/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph-docker/subscription","commits_url":"https://api.github.com/repos/ceph/ceph-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph-docker/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph-docker/merges","archive_url":"https://api.github.com/repos/ceph/ceph-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph-docker/downloads","issues_url":"https://api.github.com/repos/ceph/ceph-docker/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph-docker/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph-docker/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph-docker/deployments","created_at":"2015-01-21T17:22:51Z","updated_at":"2016-08-05T09:28:25Z","pushed_at":"2016-08-08T12:14:20Z","git_url":"git://github.com/ceph/ceph-docker.git","ssh_url":"git@github.com:ceph/ceph-docker.git","clone_url":"https://github.com/ceph/ceph-docker.git","svn_url":"https://github.com/ceph/ceph-docker","homepage":null,"size":6435,"stargazers_count":308,"watchers_count":308,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":142,"mirror_url":null,"open_issues_count":33,"forks":142,"open_issues":33,"watchers":308,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-docker/pulls/347"},"html":{"href":"https://github.com/ceph/ceph-docker/pull/347"},"issue":{"href":"https://api.github.com/repos/ceph/ceph-docker/issues/347"},"comments":{"href":"https://api.github.com/repos/ceph/ceph-docker/issues/347/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph-docker/pulls/347/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph-docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph-docker/pulls/347/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph-docker/statuses/d5a7f2593f4916b8657f5e238ba324be2a3a1e47"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"leseb","id":912735,"avatar_url":"https://avatars.githubusercontent.com/u/912735?v=3","gravatar_id":"","url":"https://api.github.com/users/leseb","html_url":"https://github.com/leseb","followers_url":"https://api.github.com/users/leseb/followers","following_url":"https://api.github.com/users/leseb/following{/other_user}","gists_url":"https://api.github.com/users/leseb/gists{/gist_id}","starred_url":"https://api.github.com/users/leseb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leseb/subscriptions","organizations_url":"https://api.github.com/users/leseb/orgs","repos_url":"https://api.github.com/users/leseb/repos","events_url":"https://api.github.com/users/leseb/events{/privacy}","received_events_url":"https://api.github.com/users/leseb/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":41,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"leseb"}}