{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30695","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30695/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30695/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30695/events","html_url":"https://github.com/kubernetes/kubernetes/pull/30695","id":171468865,"number":30695,"title":"Add support for managing ELB attributes with service annotations","user":{"login":"krancour","id":1821014,"avatar_url":"https://avatars.githubusercontent.com/u/1821014?v=3","gravatar_id":"","url":"https://api.github.com/users/krancour","html_url":"https://github.com/krancour","followers_url":"https://api.github.com/users/krancour/followers","following_url":"https://api.github.com/users/krancour/following{/other_user}","gists_url":"https://api.github.com/users/krancour/gists{/gist_id}","starred_url":"https://api.github.com/users/krancour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krancour/subscriptions","organizations_url":"https://api.github.com/users/krancour/orgs","repos_url":"https://api.github.com/users/krancour/repos","events_url":"https://api.github.com/users/krancour/events{/privacy}","received_events_url":"https://api.github.com/users/krancour/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-16T17:12:08Z","updated_at":"2016-08-16T17:12:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30695","html_url":"https://github.com/kubernetes/kubernetes/pull/30695","diff_url":"https://github.com/kubernetes/kubernetes/pull/30695.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/30695.patch"},"body":"Replaces #25015 and addresses all of @justinsb's feedback therein. This is a new PR because I was unable to reopen #25015 to amend it.\r\n\r\nI noticed recently that there is existing (but undocumented) precedent for the AWS cloud provider to manage ELB-specifc load balancer configuration based on service annotations.  In particular, one can _already_ designate an ELB as \"internal\" or enable PROXY protocol.\r\n\r\nThis PR extends this capability to the management of ELB attributes, which includes the following items:\r\n* Access logs:\r\n    * Enabled / disabled\r\n    * Emit interval\r\n    * S3 bucket name\r\n    * S3 bucket prefix\r\n* Connection draining:\r\n    * Enabled / disabled\r\n    * Timeout\r\n* Connection:\r\n    * Idle timeout\r\n* Cross-zone load balancing:\r\n    * Enabled / disabled\r\n\r\nSome of these are possibly more useful than others.  Use cases that immediately come to mind:\r\n\r\n* Enabling cross-zone load balancing is potentially useful for \"Ubernetes Light,\" or anyone otherwise attempting to spread worker nodes around multiple AZs.\r\n* Increasing idle timeout is useful for the benefit of anyone dealing with long-running requests. An example I personally care about would be git pushes to Deis' builder component.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30695)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/240170979","html_url":"https://github.com/kubernetes/kubernetes/pull/30695#issuecomment-240170979","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30695","id":240170979,"user":{"login":"k8s-bot","id":12551979,"avatar_url":"https://avatars.githubusercontent.com/u/12551979?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-bot","html_url":"https://github.com/k8s-bot","followers_url":"https://api.github.com/users/k8s-bot/followers","following_url":"https://api.github.com/users/k8s-bot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-bot/subscriptions","organizations_url":"https://api.github.com/users/k8s-bot/orgs","repos_url":"https://api.github.com/users/k8s-bot/repos","events_url":"https://api.github.com/users/k8s-bot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-bot/received_events","type":"User","site_admin":false},"created_at":"2016-08-16T17:12:47Z","updated_at":"2016-08-16T17:12:47Z","body":"Can one of the admins verify that this patch is reasonable to test? If so, please reply \"ok to test\".\n(Note: \"add to whitelist\" is no longer supported. Please update configurations in [kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull](https://github.com/kubernetes/test-infra/tree/master/jenkins/job-configs/kubernetes-jenkins-pull) instead.)\n\nThis message may repeat a few times in short succession due to https://github.com/jenkinsci/ghprb-plugin/issues/292. Sorry.\n\nOtherwise, if this message is too spammy, please complain to ixdy."}}
{"actor":{"display_login":"k8s-bot"}}