{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/73195534","id":73195534,"diff_hunk":"@@ -160,6 +160,11 @@\n         \"environment\": {\n             \"description\": \"The name of the environment that was used for the puppet run (e.g. \\\"production\\\").\",\n             \"type\":        \"string\"\n+        },\n+\n+        \"corrective_change\": {\n+            \"description\": \"True if this report suffered an unexpected change, and Puppet corrected it, or was intending to correct it if the resource or entire run was noop.\",","path":"api/schemas/report.json","position":7,"original_position":7,"commit_id":"5b277d899322e04a9d7b980ab2fe6c802573e9ec","original_commit_id":"5b277d899322e04a9d7b980ab2fe6c802573e9ec","user":{"login":"branan","id":37594,"avatar_url":"https://avatars.githubusercontent.com/u/37594?v=3","gravatar_id":"","url":"https://api.github.com/users/branan","html_url":"https://github.com/branan","followers_url":"https://api.github.com/users/branan/followers","following_url":"https://api.github.com/users/branan/following{/other_user}","gists_url":"https://api.github.com/users/branan/gists{/gist_id}","starred_url":"https://api.github.com/users/branan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/branan/subscriptions","organizations_url":"https://api.github.com/users/branan/orgs","repos_url":"https://api.github.com/users/branan/repos","events_url":"https://api.github.com/users/branan/events{/privacy}","received_events_url":"https://api.github.com/users/branan/received_events","type":"User","site_admin":false},"body":"How about \"True if a change or noop event was caused by an unexpected change to the system between Puppet runs\"?","created_at":"2016-08-02T17:03:52Z","updated_at":"2016-08-02T17:03:52Z","html_url":"https://github.com/puppetlabs/puppet/pull/5139#discussion_r73195534","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5139","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/73195534"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/5139#discussion_r73195534"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5139"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5139","id":78679959,"html_url":"https://github.com/puppetlabs/puppet/pull/5139","diff_url":"https://github.com/puppetlabs/puppet/pull/5139.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/5139.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5139","number":5139,"state":"open","locked":false,"title":"(PUP-6295) New corrective_change field","user":{"login":"kbarber","id":80595,"avatar_url":"https://avatars.githubusercontent.com/u/80595?v=3","gravatar_id":"","url":"https://api.github.com/users/kbarber","html_url":"https://github.com/kbarber","followers_url":"https://api.github.com/users/kbarber/followers","following_url":"https://api.github.com/users/kbarber/following{/other_user}","gists_url":"https://api.github.com/users/kbarber/gists{/gist_id}","starred_url":"https://api.github.com/users/kbarber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbarber/subscriptions","organizations_url":"https://api.github.com/users/kbarber/orgs","repos_url":"https://api.github.com/users/kbarber/repos","events_url":"https://api.github.com/users/kbarber/events{/privacy}","received_events_url":"https://api.github.com/users/kbarber/received_events","type":"User","site_admin":false},"body":"The corrective_change field in events marks an event that was presumed to be a\r\nmanual out-of-band change from Puppet, that Puppet then corrected. In the\r\ncontext of a noop or non-applying change, the same is true except that the\r\nchange was not corrected but is intended to be corrected once a real run is\r\napplied.\r\n\r\nThis patch introduces the work necessary to calculate this change, introducing a\r\ntransaction store that stores the last known best applied value so we can\r\ncalculate that a change was indeed unexpected.\r\n\r\nFor each report, we also mark the resource that had a corrective_change plus\r\nmark an overall report of this also so this information can be stored in\r\nbackends like PuppetDB for quick searching.\r\n\r\nSigned-off-by: Ken Barber <ken@bob.sh>","created_at":"2016-07-25T13:22:17Z","updated_at":"2016-08-02T17:03:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf46194311ba016f1cd96fe796156ea39524f2f3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5139/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5139/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5139/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/5b277d899322e04a9d7b980ab2fe6c802573e9ec","head":{"label":"kbarber:ticket/master/pup-6295","ref":"ticket/master/pup-6295","sha":"5b277d899322e04a9d7b980ab2fe6c802573e9ec","user":{"login":"kbarber","id":80595,"avatar_url":"https://avatars.githubusercontent.com/u/80595?v=3","gravatar_id":"","url":"https://api.github.com/users/kbarber","html_url":"https://github.com/kbarber","followers_url":"https://api.github.com/users/kbarber/followers","following_url":"https://api.github.com/users/kbarber/following{/other_user}","gists_url":"https://api.github.com/users/kbarber/gists{/gist_id}","starred_url":"https://api.github.com/users/kbarber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbarber/subscriptions","organizations_url":"https://api.github.com/users/kbarber/orgs","repos_url":"https://api.github.com/users/kbarber/repos","events_url":"https://api.github.com/users/kbarber/events{/privacy}","received_events_url":"https://api.github.com/users/kbarber/received_events","type":"User","site_admin":false},"repo":{"id":795695,"name":"puppet","full_name":"kbarber/puppet","owner":{"login":"kbarber","id":80595,"avatar_url":"https://avatars.githubusercontent.com/u/80595?v=3","gravatar_id":"","url":"https://api.github.com/users/kbarber","html_url":"https://github.com/kbarber","followers_url":"https://api.github.com/users/kbarber/followers","following_url":"https://api.github.com/users/kbarber/following{/other_user}","gists_url":"https://api.github.com/users/kbarber/gists{/gist_id}","starred_url":"https://api.github.com/users/kbarber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbarber/subscriptions","organizations_url":"https://api.github.com/users/kbarber/orgs","repos_url":"https://api.github.com/users/kbarber/repos","events_url":"https://api.github.com/users/kbarber/events{/privacy}","received_events_url":"https://api.github.com/users/kbarber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kbarber/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/kbarber/puppet","forks_url":"https://api.github.com/repos/kbarber/puppet/forks","keys_url":"https://api.github.com/repos/kbarber/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kbarber/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kbarber/puppet/teams","hooks_url":"https://api.github.com/repos/kbarber/puppet/hooks","issue_events_url":"https://api.github.com/repos/kbarber/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/kbarber/puppet/events","assignees_url":"https://api.github.com/repos/kbarber/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/kbarber/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/kbarber/puppet/tags","blobs_url":"https://api.github.com/repos/kbarber/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kbarber/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kbarber/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/kbarber/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kbarber/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/kbarber/puppet/languages","stargazers_url":"https://api.github.com/repos/kbarber/puppet/stargazers","contributors_url":"https://api.github.com/repos/kbarber/puppet/contributors","subscribers_url":"https://api.github.com/repos/kbarber/puppet/subscribers","subscription_url":"https://api.github.com/repos/kbarber/puppet/subscription","commits_url":"https://api.github.com/repos/kbarber/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/kbarber/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/kbarber/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/kbarber/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/kbarber/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/kbarber/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kbarber/puppet/merges","archive_url":"https://api.github.com/repos/kbarber/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kbarber/puppet/downloads","issues_url":"https://api.github.com/repos/kbarber/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/kbarber/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/kbarber/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/kbarber/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kbarber/puppet/labels{/name}","releases_url":"https://api.github.com/repos/kbarber/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/kbarber/puppet/deployments","created_at":"2010-07-24T22:07:38Z","updated_at":"2015-09-10T16:12:03Z","pushed_at":"2016-07-29T13:46:39Z","git_url":"git://github.com/kbarber/puppet.git","ssh_url":"git@github.com:kbarber/puppet.git","clone_url":"https://github.com/kbarber/puppet.git","svn_url":"https://github.com/kbarber/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":52729,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"f93e63bea93b10d8ae89f25f8b754ae3884c11bd","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppet/deployments","created_at":"2010-09-14T19:26:44Z","updated_at":"2016-08-02T02:29:58Z","pushed_at":"2016-08-02T15:26:17Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"https://puppet.com/puppet/what-is-puppet","size":80351,"stargazers_count":4079,"watchers_count":4079,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1690,"mirror_url":null,"open_issues_count":56,"forks":1690,"open_issues":56,"watchers":4079,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5139"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/5139"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/5139"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/5139/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5139/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5139/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/5b277d899322e04a9d7b980ab2fe6c802573e9ec"}}}}
{"actor":{"display_login":"branan"}}