{"action":"closed","number":11,"pull_request":{"url":"https://api.github.com/repos/cloudfoundry/bbs/pulls/11","id":87731799,"html_url":"https://github.com/cloudfoundry/bbs/pull/11","diff_url":"https://github.com/cloudfoundry/bbs/pull/11.diff","patch_url":"https://github.com/cloudfoundry/bbs/pull/11.patch","issue_url":"https://api.github.com/repos/cloudfoundry/bbs/issues/11","number":11,"state":"closed","locked":false,"title":"Make consulTTL value configurable","user":{"login":"mdelillo","id":6590106,"avatar_url":"https://avatars.githubusercontent.com/u/6590106?v=3","gravatar_id":"","url":"https://api.github.com/users/mdelillo","html_url":"https://github.com/mdelillo","followers_url":"https://api.github.com/users/mdelillo/followers","following_url":"https://api.github.com/users/mdelillo/following{/other_user}","gists_url":"https://api.github.com/users/mdelillo/gists{/gist_id}","starred_url":"https://api.github.com/users/mdelillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdelillo/subscriptions","organizations_url":"https://api.github.com/users/mdelillo/orgs","repos_url":"https://api.github.com/users/mdelillo/repos","events_url":"https://api.github.com/users/mdelillo/events{/privacy}","received_events_url":"https://api.github.com/users/mdelillo/received_events","type":"User","site_admin":false},"body":"- The default TTL value of 3 seconds results in a poll interval for 1.5 seconds for consul healthchecks.\n  with all the diego components behaving this way, the consul in PCF Dev gets overloaded and goes unresponsive.\n  PCF Dev needs this value to be increased/configurable.\n\nThis became necessary when these services switch from using `dns_health_check` to the TTL method. When the `dns_health_check` does not succeed within the TTL, consul will still respond to DNS queries for that service. Using the new TTL method, consul will unregister the service from it's DNS registry if it fails to update it's healthcheck status within the TTL.\n\nSigned-off-by: Anthony Emengo aemengo@pivotal.io\nSigned-off-by: Mark DeLillo mdelillo@pivotal.io\n","created_at":"2016-10-03T14:58:30Z","updated_at":"2016-12-07T15:11:33Z","closed_at":"2016-12-07T15:11:33Z","merged_at":null,"merge_commit_sha":"22c898c3871c3b4885ddc061a48155f64df7504f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudfoundry/bbs/pulls/11/commits","review_comments_url":"https://api.github.com/repos/cloudfoundry/bbs/pulls/11/comments","review_comment_url":"https://api.github.com/repos/cloudfoundry/bbs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudfoundry/bbs/issues/11/comments","statuses_url":"https://api.github.com/repos/cloudfoundry/bbs/statuses/89fdf45b058fdeb2853caa853a62fdaaa50240ee","head":{"label":"pcfdev-forks:make-consul-ttl-value-configurable","ref":"make-consul-ttl-value-configurable","sha":"89fdf45b058fdeb2853caa853a62fdaaa50240ee","user":{"login":"pcfdev-forks","id":18557471,"avatar_url":"https://avatars.githubusercontent.com/u/18557471?v=3","gravatar_id":"","url":"https://api.github.com/users/pcfdev-forks","html_url":"https://github.com/pcfdev-forks","followers_url":"https://api.github.com/users/pcfdev-forks/followers","following_url":"https://api.github.com/users/pcfdev-forks/following{/other_user}","gists_url":"https://api.github.com/users/pcfdev-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/pcfdev-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcfdev-forks/subscriptions","organizations_url":"https://api.github.com/users/pcfdev-forks/orgs","repos_url":"https://api.github.com/users/pcfdev-forks/repos","events_url":"https://api.github.com/users/pcfdev-forks/events{/privacy}","received_events_url":"https://api.github.com/users/pcfdev-forks/received_events","type":"Organization","site_admin":false},"repo":{"id":69881469,"name":"bbs","full_name":"pcfdev-forks/bbs","owner":{"login":"pcfdev-forks","id":18557471,"avatar_url":"https://avatars.githubusercontent.com/u/18557471?v=3","gravatar_id":"","url":"https://api.github.com/users/pcfdev-forks","html_url":"https://github.com/pcfdev-forks","followers_url":"https://api.github.com/users/pcfdev-forks/followers","following_url":"https://api.github.com/users/pcfdev-forks/following{/other_user}","gists_url":"https://api.github.com/users/pcfdev-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/pcfdev-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcfdev-forks/subscriptions","organizations_url":"https://api.github.com/users/pcfdev-forks/orgs","repos_url":"https://api.github.com/users/pcfdev-forks/repos","events_url":"https://api.github.com/users/pcfdev-forks/events{/privacy}","received_events_url":"https://api.github.com/users/pcfdev-forks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pcfdev-forks/bbs","description":"Internal API to access the database for Diego.","fork":true,"url":"https://api.github.com/repos/pcfdev-forks/bbs","forks_url":"https://api.github.com/repos/pcfdev-forks/bbs/forks","keys_url":"https://api.github.com/repos/pcfdev-forks/bbs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pcfdev-forks/bbs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pcfdev-forks/bbs/teams","hooks_url":"https://api.github.com/repos/pcfdev-forks/bbs/hooks","issue_events_url":"https://api.github.com/repos/pcfdev-forks/bbs/issues/events{/number}","events_url":"https://api.github.com/repos/pcfdev-forks/bbs/events","assignees_url":"https://api.github.com/repos/pcfdev-forks/bbs/assignees{/user}","branches_url":"https://api.github.com/repos/pcfdev-forks/bbs/branches{/branch}","tags_url":"https://api.github.com/repos/pcfdev-forks/bbs/tags","blobs_url":"https://api.github.com/repos/pcfdev-forks/bbs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pcfdev-forks/bbs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pcfdev-forks/bbs/git/refs{/sha}","trees_url":"https://api.github.com/repos/pcfdev-forks/bbs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pcfdev-forks/bbs/statuses/{sha}","languages_url":"https://api.github.com/repos/pcfdev-forks/bbs/languages","stargazers_url":"https://api.github.com/repos/pcfdev-forks/bbs/stargazers","contributors_url":"https://api.github.com/repos/pcfdev-forks/bbs/contributors","subscribers_url":"https://api.github.com/repos/pcfdev-forks/bbs/subscribers","subscription_url":"https://api.github.com/repos/pcfdev-forks/bbs/subscription","commits_url":"https://api.github.com/repos/pcfdev-forks/bbs/commits{/sha}","git_commits_url":"https://api.github.com/repos/pcfdev-forks/bbs/git/commits{/sha}","comments_url":"https://api.github.com/repos/pcfdev-forks/bbs/comments{/number}","issue_comment_url":"https://api.github.com/repos/pcfdev-forks/bbs/issues/comments{/number}","contents_url":"https://api.github.com/repos/pcfdev-forks/bbs/contents/{+path}","compare_url":"https://api.github.com/repos/pcfdev-forks/bbs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pcfdev-forks/bbs/merges","archive_url":"https://api.github.com/repos/pcfdev-forks/bbs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pcfdev-forks/bbs/downloads","issues_url":"https://api.github.com/repos/pcfdev-forks/bbs/issues{/number}","pulls_url":"https://api.github.com/repos/pcfdev-forks/bbs/pulls{/number}","milestones_url":"https://api.github.com/repos/pcfdev-forks/bbs/milestones{/number}","notifications_url":"https://api.github.com/repos/pcfdev-forks/bbs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pcfdev-forks/bbs/labels{/name}","releases_url":"https://api.github.com/repos/pcfdev-forks/bbs/releases{/id}","deployments_url":"https://api.github.com/repos/pcfdev-forks/bbs/deployments","created_at":"2016-10-03T14:57:58Z","updated_at":"2016-10-03T14:58:01Z","pushed_at":"2016-12-07T15:02:54Z","git_url":"git://github.com/pcfdev-forks/bbs.git","ssh_url":"git@github.com:pcfdev-forks/bbs.git","clone_url":"https://github.com/pcfdev-forks/bbs.git","svn_url":"https://github.com/pcfdev-forks/bbs","homepage":null,"size":11031,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudfoundry:master","ref":"master","sha":"956926cd551687866db9cbc689a9cbe8bf0132ab","user":{"login":"cloudfoundry","id":621746,"avatar_url":"https://avatars.githubusercontent.com/u/621746?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry","html_url":"https://github.com/cloudfoundry","followers_url":"https://api.github.com/users/cloudfoundry/followers","following_url":"https://api.github.com/users/cloudfoundry/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry/orgs","repos_url":"https://api.github.com/users/cloudfoundry/repos","events_url":"https://api.github.com/users/cloudfoundry/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry/received_events","type":"Organization","site_admin":false},"repo":{"id":38080473,"name":"bbs","full_name":"cloudfoundry/bbs","owner":{"login":"cloudfoundry","id":621746,"avatar_url":"https://avatars.githubusercontent.com/u/621746?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry","html_url":"https://github.com/cloudfoundry","followers_url":"https://api.github.com/users/cloudfoundry/followers","following_url":"https://api.github.com/users/cloudfoundry/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry/orgs","repos_url":"https://api.github.com/users/cloudfoundry/repos","events_url":"https://api.github.com/users/cloudfoundry/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudfoundry/bbs","description":"Internal API to access the database for Diego.","fork":false,"url":"https://api.github.com/repos/cloudfoundry/bbs","forks_url":"https://api.github.com/repos/cloudfoundry/bbs/forks","keys_url":"https://api.github.com/repos/cloudfoundry/bbs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudfoundry/bbs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudfoundry/bbs/teams","hooks_url":"https://api.github.com/repos/cloudfoundry/bbs/hooks","issue_events_url":"https://api.github.com/repos/cloudfoundry/bbs/issues/events{/number}","events_url":"https://api.github.com/repos/cloudfoundry/bbs/events","assignees_url":"https://api.github.com/repos/cloudfoundry/bbs/assignees{/user}","branches_url":"https://api.github.com/repos/cloudfoundry/bbs/branches{/branch}","tags_url":"https://api.github.com/repos/cloudfoundry/bbs/tags","blobs_url":"https://api.github.com/repos/cloudfoundry/bbs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudfoundry/bbs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudfoundry/bbs/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudfoundry/bbs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudfoundry/bbs/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudfoundry/bbs/languages","stargazers_url":"https://api.github.com/repos/cloudfoundry/bbs/stargazers","contributors_url":"https://api.github.com/repos/cloudfoundry/bbs/contributors","subscribers_url":"https://api.github.com/repos/cloudfoundry/bbs/subscribers","subscription_url":"https://api.github.com/repos/cloudfoundry/bbs/subscription","commits_url":"https://api.github.com/repos/cloudfoundry/bbs/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudfoundry/bbs/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudfoundry/bbs/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudfoundry/bbs/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudfoundry/bbs/contents/{+path}","compare_url":"https://api.github.com/repos/cloudfoundry/bbs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudfoundry/bbs/merges","archive_url":"https://api.github.com/repos/cloudfoundry/bbs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudfoundry/bbs/downloads","issues_url":"https://api.github.com/repos/cloudfoundry/bbs/issues{/number}","pulls_url":"https://api.github.com/repos/cloudfoundry/bbs/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudfoundry/bbs/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudfoundry/bbs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudfoundry/bbs/labels{/name}","releases_url":"https://api.github.com/repos/cloudfoundry/bbs/releases{/id}","deployments_url":"https://api.github.com/repos/cloudfoundry/bbs/deployments","created_at":"2015-06-25T23:50:58Z","updated_at":"2016-12-06T00:01:14Z","pushed_at":"2016-12-07T15:03:14Z","git_url":"git://github.com/cloudfoundry/bbs.git","ssh_url":"git@github.com:cloudfoundry/bbs.git","clone_url":"https://github.com/cloudfoundry/bbs.git","svn_url":"https://github.com/cloudfoundry/bbs","homepage":null,"size":11109,"stargazers_count":7,"watchers_count":7,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":1,"forks":12,"open_issues":1,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudfoundry/bbs/pulls/11"},"html":{"href":"https://github.com/cloudfoundry/bbs/pull/11"},"issue":{"href":"https://api.github.com/repos/cloudfoundry/bbs/issues/11"},"comments":{"href":"https://api.github.com/repos/cloudfoundry/bbs/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudfoundry/bbs/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudfoundry/bbs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudfoundry/bbs/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/cloudfoundry/bbs/statuses/89fdf45b058fdeb2853caa853a62fdaaa50240ee"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":7,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"mdelillo"}}