{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/50126973","id":50126973,"diff_hunk":"@@ -323,10 +325,10 @@ class KFold(_BaseKFold):\n     def __init__(self, n, n_folds=3, shuffle=False,\n                  random_state=None):\n         super(KFold, self).__init__(n, n_folds, shuffle, random_state)\n-        self.idxs = np.arange(n)\n+        self.mask_idxs = np.arange(n)","path":"sklearn/cross_validation.py","position":23,"original_position":23,"commit_id":"c7874dd6ea9b31bd33ad6e40f096de19c5165a36","original_commit_id":"c7874dd6ea9b31bd33ad6e40f096de19c5165a36","user":{"login":"maciejkula","id":2392579,"avatar_url":"https://avatars.githubusercontent.com/u/2392579?v=3","gravatar_id":"","url":"https://api.github.com/users/maciejkula","html_url":"https://github.com/maciejkula","followers_url":"https://api.github.com/users/maciejkula/followers","following_url":"https://api.github.com/users/maciejkula/following{/other_user}","gists_url":"https://api.github.com/users/maciejkula/gists{/gist_id}","starred_url":"https://api.github.com/users/maciejkula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maciejkula/subscriptions","organizations_url":"https://api.github.com/users/maciejkula/orgs","repos_url":"https://api.github.com/users/maciejkula/repos","events_url":"https://api.github.com/users/maciejkula/events{/privacy}","received_events_url":"https://api.github.com/users/maciejkula/received_events","type":"User","site_admin":false},"body":"Because it conflicts with a field with the same name used in another subclass of `_PartitionIterator`","created_at":"2016-01-19T15:36:30Z","updated_at":"2016-01-19T15:36:30Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/6188#discussion_r50126973","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6188","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/50126973"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/6188#discussion_r50126973"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6188"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6188","id":56458024,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/6188","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/6188.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/6188.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6188","number":6188,"state":"open","locked":false,"title":"Make sure that KFold indices are shuffled.","user":{"login":"maciejkula","id":2392579,"avatar_url":"https://avatars.githubusercontent.com/u/2392579?v=3","gravatar_id":"","url":"https://api.github.com/users/maciejkula","html_url":"https://github.com/maciejkula","followers_url":"https://api.github.com/users/maciejkula/followers","following_url":"https://api.github.com/users/maciejkula/following{/other_user}","gists_url":"https://api.github.com/users/maciejkula/gists{/gist_id}","starred_url":"https://api.github.com/users/maciejkula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maciejkula/subscriptions","organizations_url":"https://api.github.com/users/maciejkula/orgs","repos_url":"https://api.github.com/users/maciejkula/repos","events_url":"https://api.github.com/users/maciejkula/events{/privacy}","received_events_url":"https://api.github.com/users/maciejkula/received_events","type":"User","site_admin":false},"body":"At the moment, KFold returns indices sorted in ascending order ([0, 2, 4...]) regardless of the shuffle setting. This commit fixes this and adds a test.\r\n\r\nThis may break existing tests that rely on this behaviour.","created_at":"2016-01-19T12:14:53Z","updated_at":"2016-01-19T15:36:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ffd176baf79a9c6f79947af27a5c75d9362112f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6188/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6188/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6188/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/c7874dd6ea9b31bd33ad6e40f096de19c5165a36","head":{"label":"maciejkula:fix_kfold_shuffle","ref":"fix_kfold_shuffle","sha":"c7874dd6ea9b31bd33ad6e40f096de19c5165a36","user":{"login":"maciejkula","id":2392579,"avatar_url":"https://avatars.githubusercontent.com/u/2392579?v=3","gravatar_id":"","url":"https://api.github.com/users/maciejkula","html_url":"https://github.com/maciejkula","followers_url":"https://api.github.com/users/maciejkula/followers","following_url":"https://api.github.com/users/maciejkula/following{/other_user}","gists_url":"https://api.github.com/users/maciejkula/gists{/gist_id}","starred_url":"https://api.github.com/users/maciejkula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maciejkula/subscriptions","organizations_url":"https://api.github.com/users/maciejkula/orgs","repos_url":"https://api.github.com/users/maciejkula/repos","events_url":"https://api.github.com/users/maciejkula/events{/privacy}","received_events_url":"https://api.github.com/users/maciejkula/received_events","type":"User","site_admin":false},"repo":{"id":49948436,"name":"scikit-learn","full_name":"maciejkula/scikit-learn","owner":{"login":"maciejkula","id":2392579,"avatar_url":"https://avatars.githubusercontent.com/u/2392579?v=3","gravatar_id":"","url":"https://api.github.com/users/maciejkula","html_url":"https://github.com/maciejkula","followers_url":"https://api.github.com/users/maciejkula/followers","following_url":"https://api.github.com/users/maciejkula/following{/other_user}","gists_url":"https://api.github.com/users/maciejkula/gists{/gist_id}","starred_url":"https://api.github.com/users/maciejkula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maciejkula/subscriptions","organizations_url":"https://api.github.com/users/maciejkula/orgs","repos_url":"https://api.github.com/users/maciejkula/repos","events_url":"https://api.github.com/users/maciejkula/events{/privacy}","received_events_url":"https://api.github.com/users/maciejkula/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maciejkula/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/maciejkula/scikit-learn","forks_url":"https://api.github.com/repos/maciejkula/scikit-learn/forks","keys_url":"https://api.github.com/repos/maciejkula/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maciejkula/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maciejkula/scikit-learn/teams","hooks_url":"https://api.github.com/repos/maciejkula/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/maciejkula/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/maciejkula/scikit-learn/events","assignees_url":"https://api.github.com/repos/maciejkula/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/maciejkula/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/maciejkula/scikit-learn/tags","blobs_url":"https://api.github.com/repos/maciejkula/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maciejkula/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maciejkula/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/maciejkula/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maciejkula/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/maciejkula/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/maciejkula/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/maciejkula/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/maciejkula/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/maciejkula/scikit-learn/subscription","commits_url":"https://api.github.com/repos/maciejkula/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/maciejkula/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/maciejkula/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/maciejkula/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/maciejkula/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/maciejkula/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maciejkula/scikit-learn/merges","archive_url":"https://api.github.com/repos/maciejkula/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maciejkula/scikit-learn/downloads","issues_url":"https://api.github.com/repos/maciejkula/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/maciejkula/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/maciejkula/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/maciejkula/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maciejkula/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/maciejkula/scikit-learn/releases{/id}","created_at":"2016-01-19T11:32:12Z","updated_at":"2016-01-19T11:32:19Z","pushed_at":"2016-01-19T12:14:06Z","git_url":"git://github.com/maciejkula/scikit-learn.git","ssh_url":"git@github.com:maciejkula/scikit-learn.git","clone_url":"https://github.com/maciejkula/scikit-learn.git","svn_url":"https://github.com/maciejkula/scikit-learn","homepage":"http://scikit-learn.org","size":70951,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"4e4e6c3f4cf844c54f8544af36970c1917b2ef38","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","created_at":"2010-08-17T09:43:38Z","updated_at":"2016-01-19T14:41:23Z","pushed_at":"2016-01-19T15:05:15Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":105094,"stargazers_count":9322,"watchers_count":9322,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5483,"mirror_url":null,"open_issues_count":1003,"forks":5483,"open_issues":1003,"watchers":9322,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6188"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/6188"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6188"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6188/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6188/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6188/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/c7874dd6ea9b31bd33ad6e40f096de19c5165a36"}}}}