{"action":"closed","issue":{"url":"https://api.github.com/repos/dascandy/hippomocks/issues/46","repository_url":"https://api.github.com/repos/dascandy/hippomocks","labels_url":"https://api.github.com/repos/dascandy/hippomocks/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/dascandy/hippomocks/issues/46/comments","events_url":"https://api.github.com/repos/dascandy/hippomocks/issues/46/events","html_url":"https://github.com/dascandy/hippomocks/issues/46","id":120382487,"number":46,"title":"noexcep check is incorrect","user":{"login":"Gr8Escape","id":10497825,"avatar_url":"https://avatars.githubusercontent.com/u/10497825?v=3","gravatar_id":"","url":"https://api.github.com/users/Gr8Escape","html_url":"https://github.com/Gr8Escape","followers_url":"https://api.github.com/users/Gr8Escape/followers","following_url":"https://api.github.com/users/Gr8Escape/following{/other_user}","gists_url":"https://api.github.com/users/Gr8Escape/gists{/gist_id}","starred_url":"https://api.github.com/users/Gr8Escape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gr8Escape/subscriptions","organizations_url":"https://api.github.com/users/Gr8Escape/orgs","repos_url":"https://api.github.com/users/Gr8Escape/repos","events_url":"https://api.github.com/users/Gr8Escape/events{/privacy}","received_events_url":"https://api.github.com/users/Gr8Escape/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-12-04T11:25:37Z","updated_at":"2016-05-30T20:16:02Z","closed_at":"2016-05-30T20:16:02Z","body":"The ~MockRepository contains a check for noexcept support however that check is incorrect.\r\n#if __cplusplus >= 199711L && (!defined(_MSC_VER) || _MSC_VER > 1700)\r\nnoexcept(false)\r\n#endif\r\n\r\nIt should be:\r\n#if __cplusplus > 199711L || (defined(_MSC_VER) && _MSC_VER > 1700)\r\nnoexcept(false)\r\n#endif\r\n\r\nThe VC2015 compiler (and earlier versions) still define __cplusplus as 199711L\r\nSo to check for correct VC version, the _MSC_VER has to exist and be larger than 1700 (VC2012)"}}
{"actor":{"display_login":"dascandy"}}