{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/84383856","pull_request_review_id":5165324,"id":84383856,"diff_hunk":"@@ -170,7 +172,19 @@\n     // LDAP authorization settings\n     //-----------------------------------------------------\n \n-    @Description( \"Perform LDAP search for authorization info using a system account.\" )\n+    @Description( \"Perform LDAP search for authorization info using a system account or the user's own account.\\n\\n\" +\n+                  \"If this is set to `false` (default), the search for group membership will be performed \" +\n+                  \"directly after authentication using the ldap context bound with the user's own account. \" +\n+                  \"The mapped roles will be cached for the duration of `dbms.security.auth_cache_ttl`, \" +\n+                  \"and then expire, requiring re-authentication. To avoid frequently having to re-authenticate \" +\n+                  \"sessions you may want to set a relatively long auth cache expiration time together with this \" +\n+                  \"option. NOTE: This option will only work if the users are permitted to search for the \" +\n+                  \"group membership attributes on themselves in the directory.\\n\\n\" +","path":"enterprise/security/src/main/java/org/neo4j/server/security/enterprise/configuration/SecuritySettings.java","position":60,"original_position":60,"commit_id":"b74733cb4974314c8237f6d8b13d47fcbe265925","original_commit_id":"b74733cb4974314c8237f6d8b13d47fcbe265925","user":{"login":"jjaderberg","id":6028968,"avatar_url":"https://avatars.githubusercontent.com/u/6028968?v=3","gravatar_id":"","url":"https://api.github.com/users/jjaderberg","html_url":"https://github.com/jjaderberg","followers_url":"https://api.github.com/users/jjaderberg/followers","following_url":"https://api.github.com/users/jjaderberg/following{/other_user}","gists_url":"https://api.github.com/users/jjaderberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaderberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaderberg/subscriptions","organizations_url":"https://api.github.com/users/jjaderberg/orgs","repos_url":"https://api.github.com/users/jjaderberg/repos","events_url":"https://api.github.com/users/jjaderberg/events{/privacy}","received_events_url":"https://api.github.com/users/jjaderberg/received_events","type":"User","site_admin":false},"body":"\"for the group membership attributes on themselves\" => \"for their own group memberships\" or \"for group memberships for their own user\"","created_at":"2016-10-20T21:54:06Z","updated_at":"2016-10-20T22:04:36Z","html_url":"https://github.com/neo4j/neo4j/pull/8228#discussion_r84383856","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/8228","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/84383856"},"html":{"href":"https://github.com/neo4j/neo4j/pull/8228#discussion_r84383856"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/8228"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/8228","id":90168846,"html_url":"https://github.com/neo4j/neo4j/pull/8228","diff_url":"https://github.com/neo4j/neo4j/pull/8228.diff","patch_url":"https://github.com/neo4j/neo4j/pull/8228.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/8228","number":8228,"state":"open","locked":false,"title":"Update descriptions in `SecuritySettings`","user":{"login":"systay","id":402248,"avatar_url":"https://avatars.githubusercontent.com/u/402248?v=3","gravatar_id":"","url":"https://api.github.com/users/systay","html_url":"https://github.com/systay","followers_url":"https://api.github.com/users/systay/followers","following_url":"https://api.github.com/users/systay/following{/other_user}","gists_url":"https://api.github.com/users/systay/gists{/gist_id}","starred_url":"https://api.github.com/users/systay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systay/subscriptions","organizations_url":"https://api.github.com/users/systay/orgs","repos_url":"https://api.github.com/users/systay/repos","events_url":"https://api.github.com/users/systay/events{/privacy}","received_events_url":"https://api.github.com/users/systay/received_events","type":"User","site_admin":false},"body":"`neo4j.conf` received some updates earlier, this PR updates the source code descriptions to match.","created_at":"2016-10-20T10:01:43Z","updated_at":"2016-10-20T22:04:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0302e064460923fb32d246c78c8e0f3cfeb47858","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/8228/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/8228/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/8228/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/b74733cb4974314c8237f6d8b13d47fcbe265925","head":{"label":"systay:3.1-security-settings-docs","ref":"3.1-security-settings-docs","sha":"b74733cb4974314c8237f6d8b13d47fcbe265925","user":{"login":"systay","id":402248,"avatar_url":"https://avatars.githubusercontent.com/u/402248?v=3","gravatar_id":"","url":"https://api.github.com/users/systay","html_url":"https://github.com/systay","followers_url":"https://api.github.com/users/systay/followers","following_url":"https://api.github.com/users/systay/following{/other_user}","gists_url":"https://api.github.com/users/systay/gists{/gist_id}","starred_url":"https://api.github.com/users/systay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systay/subscriptions","organizations_url":"https://api.github.com/users/systay/orgs","repos_url":"https://api.github.com/users/systay/repos","events_url":"https://api.github.com/users/systay/events{/privacy}","received_events_url":"https://api.github.com/users/systay/received_events","type":"User","site_admin":false},"repo":{"id":6667347,"name":"neo4j","full_name":"systay/neo4j","owner":{"login":"systay","id":402248,"avatar_url":"https://avatars.githubusercontent.com/u/402248?v=3","gravatar_id":"","url":"https://api.github.com/users/systay","html_url":"https://github.com/systay","followers_url":"https://api.github.com/users/systay/followers","following_url":"https://api.github.com/users/systay/following{/other_user}","gists_url":"https://api.github.com/users/systay/gists{/gist_id}","starred_url":"https://api.github.com/users/systay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systay/subscriptions","organizations_url":"https://api.github.com/users/systay/orgs","repos_url":"https://api.github.com/users/systay/repos","events_url":"https://api.github.com/users/systay/events{/privacy}","received_events_url":"https://api.github.com/users/systay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/systay/neo4j","description":null,"fork":true,"url":"https://api.github.com/repos/systay/neo4j","forks_url":"https://api.github.com/repos/systay/neo4j/forks","keys_url":"https://api.github.com/repos/systay/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systay/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systay/neo4j/teams","hooks_url":"https://api.github.com/repos/systay/neo4j/hooks","issue_events_url":"https://api.github.com/repos/systay/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/systay/neo4j/events","assignees_url":"https://api.github.com/repos/systay/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/systay/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/systay/neo4j/tags","blobs_url":"https://api.github.com/repos/systay/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systay/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systay/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/systay/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systay/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/systay/neo4j/languages","stargazers_url":"https://api.github.com/repos/systay/neo4j/stargazers","contributors_url":"https://api.github.com/repos/systay/neo4j/contributors","subscribers_url":"https://api.github.com/repos/systay/neo4j/subscribers","subscription_url":"https://api.github.com/repos/systay/neo4j/subscription","commits_url":"https://api.github.com/repos/systay/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/systay/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/systay/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/systay/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/systay/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/systay/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systay/neo4j/merges","archive_url":"https://api.github.com/repos/systay/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systay/neo4j/downloads","issues_url":"https://api.github.com/repos/systay/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/systay/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/systay/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/systay/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systay/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/systay/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/systay/neo4j/deployments","created_at":"2012-11-13T08:05:14Z","updated_at":"2016-01-19T19:00:58Z","pushed_at":"2016-10-20T13:15:16Z","git_url":"git://github.com/systay/neo4j.git","ssh_url":"git@github.com:systay/neo4j.git","clone_url":"https://github.com/systay/neo4j.git","svn_url":"https://github.com/systay/neo4j","homepage":null,"size":312551,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":2,"default_branch":"loadcsv"}},"base":{"label":"neo4j:3.1","ref":"3.1","sha":"353e3f994ec59acedd1da62d3d1a3b68f3eae2b1","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j/deployments","created_at":"2012-11-12T08:46:15Z","updated_at":"2016-10-20T14:41:37Z","pushed_at":"2016-10-20T21:54:01Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":382087,"stargazers_count":3115,"watchers_count":3115,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1011,"mirror_url":null,"open_issues_count":406,"forks":1011,"open_issues":406,"watchers":3115,"default_branch":"3.1"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/8228"},"html":{"href":"https://github.com/neo4j/neo4j/pull/8228"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/8228"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/8228/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/8228/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/8228/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/b74733cb4974314c8237f6d8b13d47fcbe265925"}}}}
{"actor":{"display_login":"jjaderberg"}}