{"action":"created","comment":{"url":"https://api.github.com/repos/asciidoctor/asciidoctor/pulls/comments/84583974","pull_request_review_id":5355338,"id":84583974,"diff_hunk":"@@ -835,10 +835,9 @@ def preprocess_include raw_target, raw_attributes\n         warn %(asciidoctor: ERROR: #{line_info}: maximum include depth of #{@maxdepth[:rel]} exceeded)\n         return false\n       end\n-      if ::RUBY_ENGINE_OPAL\n+      if ::RUBY_ENGINE_OPAL && @document.attributes.has_key? 'env-browser'","path":"lib/asciidoctor/reader.rb","position":5,"original_position":5,"commit_id":"bf7e9dd556731e23b90857f41a442d1e722b8c2d","original_commit_id":"bf7e9dd556731e23b90857f41a442d1e722b8c2d","user":{"login":"Mogztter","id":333276,"avatar_url":"https://avatars.githubusercontent.com/u/333276?v=3","gravatar_id":"","url":"https://api.github.com/users/Mogztter","html_url":"https://github.com/Mogztter","followers_url":"https://api.github.com/users/Mogztter/followers","following_url":"https://api.github.com/users/Mogztter/following{/other_user}","gists_url":"https://api.github.com/users/Mogztter/gists{/gist_id}","starred_url":"https://api.github.com/users/Mogztter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mogztter/subscriptions","organizations_url":"https://api.github.com/users/Mogztter/orgs","repos_url":"https://api.github.com/users/Mogztter/repos","events_url":"https://api.github.com/users/Mogztter/events{/privacy}","received_events_url":"https://api.github.com/users/Mogztter/received_events","type":"User","site_admin":false},"body":"Could we also check if the global variable `JAVASCRIPT_PLATFORM` matches `browser` ? https://github.com/asciidoctor/asciidoctor.js/pull/248/files#diff-c3680ed68dbcf2cc0b36fa1af7000debR62\r\n\r\nBy default, I think Asciidoctor should choose the \"right way\" to process include files (and if it fails, users can always set the \"env-browser\" attribute). Wdyt ?","created_at":"2016-10-22T19:46:36Z","updated_at":"2016-10-22T19:46:36Z","html_url":"https://github.com/asciidoctor/asciidoctor/pull/1898#discussion_r84583974","pull_request_url":"https://api.github.com/repos/asciidoctor/asciidoctor/pulls/1898","_links":{"self":{"href":"https://api.github.com/repos/asciidoctor/asciidoctor/pulls/comments/84583974"},"html":{"href":"https://github.com/asciidoctor/asciidoctor/pull/1898#discussion_r84583974"},"pull_request":{"href":"https://api.github.com/repos/asciidoctor/asciidoctor/pulls/1898"}}},"pull_request":{"url":"https://api.github.com/repos/asciidoctor/asciidoctor/pulls/1898","id":90493093,"html_url":"https://github.com/asciidoctor/asciidoctor/pull/1898","diff_url":"https://github.com/asciidoctor/asciidoctor/pull/1898.diff","patch_url":"https://github.com/asciidoctor/asciidoctor/pull/1898.patch","issue_url":"https://api.github.com/repos/asciidoctor/asciidoctor/issues/1898","number":1898,"state":"open","locked":false,"title":"Use a special logic for include processing only on a browser environment","user":{"login":"Mogztter","id":333276,"avatar_url":"https://avatars.githubusercontent.com/u/333276?v=3","gravatar_id":"","url":"https://api.github.com/users/Mogztter","html_url":"https://github.com/Mogztter","followers_url":"https://api.github.com/users/Mogztter/followers","following_url":"https://api.github.com/users/Mogztter/following{/other_user}","gists_url":"https://api.github.com/users/Mogztter/gists{/gist_id}","starred_url":"https://api.github.com/users/Mogztter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mogztter/subscriptions","organizations_url":"https://api.github.com/users/Mogztter/orgs","repos_url":"https://api.github.com/users/Mogztter/repos","events_url":"https://api.github.com/users/Mogztter/events{/privacy}","received_events_url":"https://api.github.com/users/Mogztter/received_events","type":"User","site_admin":false},"body":"This special case is unnecessary (or at least not necessary anymore on Node).\r\n\r\nShould fix this issue: https://github.com/asciidoctor/atom-asciidoc-preview/issues/189","created_at":"2016-10-22T19:42:10Z","updated_at":"2016-10-22T19:46:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"778cc6efeb80e056ad7a001dca29435bee74d1d6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/asciidoctor/asciidoctor/pulls/1898/commits","review_comments_url":"https://api.github.com/repos/asciidoctor/asciidoctor/pulls/1898/comments","review_comment_url":"https://api.github.com/repos/asciidoctor/asciidoctor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/asciidoctor/asciidoctor/issues/1898/comments","statuses_url":"https://api.github.com/repos/asciidoctor/asciidoctor/statuses/bf7e9dd556731e23b90857f41a442d1e722b8c2d","head":{"label":"Mogztter:patch-2","ref":"patch-2","sha":"bf7e9dd556731e23b90857f41a442d1e722b8c2d","user":{"login":"Mogztter","id":333276,"avatar_url":"https://avatars.githubusercontent.com/u/333276?v=3","gravatar_id":"","url":"https://api.github.com/users/Mogztter","html_url":"https://github.com/Mogztter","followers_url":"https://api.github.com/users/Mogztter/followers","following_url":"https://api.github.com/users/Mogztter/following{/other_user}","gists_url":"https://api.github.com/users/Mogztter/gists{/gist_id}","starred_url":"https://api.github.com/users/Mogztter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mogztter/subscriptions","organizations_url":"https://api.github.com/users/Mogztter/orgs","repos_url":"https://api.github.com/users/Mogztter/repos","events_url":"https://api.github.com/users/Mogztter/events{/privacy}","received_events_url":"https://api.github.com/users/Mogztter/received_events","type":"User","site_admin":false},"repo":{"id":9997577,"name":"asciidoctor","full_name":"Mogztter/asciidoctor","owner":{"login":"Mogztter","id":333276,"avatar_url":"https://avatars.githubusercontent.com/u/333276?v=3","gravatar_id":"","url":"https://api.github.com/users/Mogztter","html_url":"https://github.com/Mogztter","followers_url":"https://api.github.com/users/Mogztter/followers","following_url":"https://api.github.com/users/Mogztter/following{/other_user}","gists_url":"https://api.github.com/users/Mogztter/gists{/gist_id}","starred_url":"https://api.github.com/users/Mogztter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mogztter/subscriptions","organizations_url":"https://api.github.com/users/Mogztter/orgs","repos_url":"https://api.github.com/users/Mogztter/repos","events_url":"https://api.github.com/users/Mogztter/events{/privacy}","received_events_url":"https://api.github.com/users/Mogztter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mogztter/asciidoctor","description":"An open source Ruby processor for converting AsciiDoc source files or strings into HTML 5, DocBook 4.5 and other formats.","fork":true,"url":"https://api.github.com/repos/Mogztter/asciidoctor","forks_url":"https://api.github.com/repos/Mogztter/asciidoctor/forks","keys_url":"https://api.github.com/repos/Mogztter/asciidoctor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mogztter/asciidoctor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mogztter/asciidoctor/teams","hooks_url":"https://api.github.com/repos/Mogztter/asciidoctor/hooks","issue_events_url":"https://api.github.com/repos/Mogztter/asciidoctor/issues/events{/number}","events_url":"https://api.github.com/repos/Mogztter/asciidoctor/events","assignees_url":"https://api.github.com/repos/Mogztter/asciidoctor/assignees{/user}","branches_url":"https://api.github.com/repos/Mogztter/asciidoctor/branches{/branch}","tags_url":"https://api.github.com/repos/Mogztter/asciidoctor/tags","blobs_url":"https://api.github.com/repos/Mogztter/asciidoctor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mogztter/asciidoctor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mogztter/asciidoctor/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mogztter/asciidoctor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mogztter/asciidoctor/statuses/{sha}","languages_url":"https://api.github.com/repos/Mogztter/asciidoctor/languages","stargazers_url":"https://api.github.com/repos/Mogztter/asciidoctor/stargazers","contributors_url":"https://api.github.com/repos/Mogztter/asciidoctor/contributors","subscribers_url":"https://api.github.com/repos/Mogztter/asciidoctor/subscribers","subscription_url":"https://api.github.com/repos/Mogztter/asciidoctor/subscription","commits_url":"https://api.github.com/repos/Mogztter/asciidoctor/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mogztter/asciidoctor/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mogztter/asciidoctor/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mogztter/asciidoctor/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mogztter/asciidoctor/contents/{+path}","compare_url":"https://api.github.com/repos/Mogztter/asciidoctor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mogztter/asciidoctor/merges","archive_url":"https://api.github.com/repos/Mogztter/asciidoctor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mogztter/asciidoctor/downloads","issues_url":"https://api.github.com/repos/Mogztter/asciidoctor/issues{/number}","pulls_url":"https://api.github.com/repos/Mogztter/asciidoctor/pulls{/number}","milestones_url":"https://api.github.com/repos/Mogztter/asciidoctor/milestones{/number}","notifications_url":"https://api.github.com/repos/Mogztter/asciidoctor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mogztter/asciidoctor/labels{/name}","releases_url":"https://api.github.com/repos/Mogztter/asciidoctor/releases{/id}","deployments_url":"https://api.github.com/repos/Mogztter/asciidoctor/deployments","created_at":"2013-05-11T09:31:51Z","updated_at":"2014-12-12T21:00:26Z","pushed_at":"2016-10-22T19:41:08Z","git_url":"git://github.com/Mogztter/asciidoctor.git","ssh_url":"git@github.com:Mogztter/asciidoctor.git","clone_url":"https://github.com/Mogztter/asciidoctor.git","svn_url":"https://github.com/Mogztter/asciidoctor","homepage":"http://asciidoctor.org","size":7433,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"asciidoctor:master","ref":"master","sha":"b3ff32e27ae88abbf6178f3b85543ccbd2f07c10","user":{"login":"asciidoctor","id":3137042,"avatar_url":"https://avatars.githubusercontent.com/u/3137042?v=3","gravatar_id":"","url":"https://api.github.com/users/asciidoctor","html_url":"https://github.com/asciidoctor","followers_url":"https://api.github.com/users/asciidoctor/followers","following_url":"https://api.github.com/users/asciidoctor/following{/other_user}","gists_url":"https://api.github.com/users/asciidoctor/gists{/gist_id}","starred_url":"https://api.github.com/users/asciidoctor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asciidoctor/subscriptions","organizations_url":"https://api.github.com/users/asciidoctor/orgs","repos_url":"https://api.github.com/users/asciidoctor/repos","events_url":"https://api.github.com/users/asciidoctor/events{/privacy}","received_events_url":"https://api.github.com/users/asciidoctor/received_events","type":"Organization","site_admin":false},"repo":{"id":4523235,"name":"asciidoctor","full_name":"asciidoctor/asciidoctor","owner":{"login":"asciidoctor","id":3137042,"avatar_url":"https://avatars.githubusercontent.com/u/3137042?v=3","gravatar_id":"","url":"https://api.github.com/users/asciidoctor","html_url":"https://github.com/asciidoctor","followers_url":"https://api.github.com/users/asciidoctor/followers","following_url":"https://api.github.com/users/asciidoctor/following{/other_user}","gists_url":"https://api.github.com/users/asciidoctor/gists{/gist_id}","starred_url":"https://api.github.com/users/asciidoctor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asciidoctor/subscriptions","organizations_url":"https://api.github.com/users/asciidoctor/orgs","repos_url":"https://api.github.com/users/asciidoctor/repos","events_url":"https://api.github.com/users/asciidoctor/events{/privacy}","received_events_url":"https://api.github.com/users/asciidoctor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/asciidoctor/asciidoctor","description":":gem: A fast, open source text processor and publishing toolchain, written in Ruby, for converting AsciiDoc content to HTML5, DocBook 5 (or 4.5) and other formats.","fork":false,"url":"https://api.github.com/repos/asciidoctor/asciidoctor","forks_url":"https://api.github.com/repos/asciidoctor/asciidoctor/forks","keys_url":"https://api.github.com/repos/asciidoctor/asciidoctor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asciidoctor/asciidoctor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asciidoctor/asciidoctor/teams","hooks_url":"https://api.github.com/repos/asciidoctor/asciidoctor/hooks","issue_events_url":"https://api.github.com/repos/asciidoctor/asciidoctor/issues/events{/number}","events_url":"https://api.github.com/repos/asciidoctor/asciidoctor/events","assignees_url":"https://api.github.com/repos/asciidoctor/asciidoctor/assignees{/user}","branches_url":"https://api.github.com/repos/asciidoctor/asciidoctor/branches{/branch}","tags_url":"https://api.github.com/repos/asciidoctor/asciidoctor/tags","blobs_url":"https://api.github.com/repos/asciidoctor/asciidoctor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asciidoctor/asciidoctor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asciidoctor/asciidoctor/git/refs{/sha}","trees_url":"https://api.github.com/repos/asciidoctor/asciidoctor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asciidoctor/asciidoctor/statuses/{sha}","languages_url":"https://api.github.com/repos/asciidoctor/asciidoctor/languages","stargazers_url":"https://api.github.com/repos/asciidoctor/asciidoctor/stargazers","contributors_url":"https://api.github.com/repos/asciidoctor/asciidoctor/contributors","subscribers_url":"https://api.github.com/repos/asciidoctor/asciidoctor/subscribers","subscription_url":"https://api.github.com/repos/asciidoctor/asciidoctor/subscription","commits_url":"https://api.github.com/repos/asciidoctor/asciidoctor/commits{/sha}","git_commits_url":"https://api.github.com/repos/asciidoctor/asciidoctor/git/commits{/sha}","comments_url":"https://api.github.com/repos/asciidoctor/asciidoctor/comments{/number}","issue_comment_url":"https://api.github.com/repos/asciidoctor/asciidoctor/issues/comments{/number}","contents_url":"https://api.github.com/repos/asciidoctor/asciidoctor/contents/{+path}","compare_url":"https://api.github.com/repos/asciidoctor/asciidoctor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asciidoctor/asciidoctor/merges","archive_url":"https://api.github.com/repos/asciidoctor/asciidoctor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asciidoctor/asciidoctor/downloads","issues_url":"https://api.github.com/repos/asciidoctor/asciidoctor/issues{/number}","pulls_url":"https://api.github.com/repos/asciidoctor/asciidoctor/pulls{/number}","milestones_url":"https://api.github.com/repos/asciidoctor/asciidoctor/milestones{/number}","notifications_url":"https://api.github.com/repos/asciidoctor/asciidoctor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asciidoctor/asciidoctor/labels{/name}","releases_url":"https://api.github.com/repos/asciidoctor/asciidoctor/releases{/id}","deployments_url":"https://api.github.com/repos/asciidoctor/asciidoctor/deployments","created_at":"2012-06-01T19:09:20Z","updated_at":"2016-10-22T18:19:37Z","pushed_at":"2016-10-22T19:42:10Z","git_url":"git://github.com/asciidoctor/asciidoctor.git","ssh_url":"git@github.com:asciidoctor/asciidoctor.git","clone_url":"https://github.com/asciidoctor/asciidoctor.git","svn_url":"https://github.com/asciidoctor/asciidoctor","homepage":"http://asciidoctor.org","size":8966,"stargazers_count":1123,"watchers_count":1123,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":245,"mirror_url":null,"open_issues_count":482,"forks":245,"open_issues":482,"watchers":1123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/asciidoctor/asciidoctor/pulls/1898"},"html":{"href":"https://github.com/asciidoctor/asciidoctor/pull/1898"},"issue":{"href":"https://api.github.com/repos/asciidoctor/asciidoctor/issues/1898"},"comments":{"href":"https://api.github.com/repos/asciidoctor/asciidoctor/issues/1898/comments"},"review_comments":{"href":"https://api.github.com/repos/asciidoctor/asciidoctor/pulls/1898/comments"},"review_comment":{"href":"https://api.github.com/repos/asciidoctor/asciidoctor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/asciidoctor/asciidoctor/pulls/1898/commits"},"statuses":{"href":"https://api.github.com/repos/asciidoctor/asciidoctor/statuses/bf7e9dd556731e23b90857f41a442d1e722b8c2d"}}}}
{"actor":{"display_login":"Mogztter"}}