{"action":"created","issue":{"url":"https://api.github.com/repos/abooij/sudbury/issues/5","repository_url":"https://api.github.com/repos/abooij/sudbury","labels_url":"https://api.github.com/repos/abooij/sudbury/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/abooij/sudbury/issues/5/comments","events_url":"https://api.github.com/repos/abooij/sudbury/issues/5/events","html_url":"https://github.com/abooij/sudbury/issues/5","id":145548673,"number":5,"title":"Weston sample clients don't run","user":{"login":"abooij","id":164426,"avatar_url":"https://avatars.githubusercontent.com/u/164426?v=3","gravatar_id":"","url":"https://api.github.com/users/abooij","html_url":"https://github.com/abooij","followers_url":"https://api.github.com/users/abooij/followers","following_url":"https://api.github.com/users/abooij/following{/other_user}","gists_url":"https://api.github.com/users/abooij/gists{/gist_id}","starred_url":"https://api.github.com/users/abooij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abooij/subscriptions","organizations_url":"https://api.github.com/users/abooij/orgs","repos_url":"https://api.github.com/users/abooij/repos","events_url":"https://api.github.com/users/abooij/events{/privacy}","received_events_url":"https://api.github.com/users/abooij/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"abooij","id":164426,"avatar_url":"https://avatars.githubusercontent.com/u/164426?v=3","gravatar_id":"","url":"https://api.github.com/users/abooij","html_url":"https://github.com/abooij","followers_url":"https://api.github.com/users/abooij/followers","following_url":"https://api.github.com/users/abooij/following{/other_user}","gists_url":"https://api.github.com/users/abooij/gists{/gist_id}","starred_url":"https://api.github.com/users/abooij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abooij/subscriptions","organizations_url":"https://api.github.com/users/abooij/orgs","repos_url":"https://api.github.com/users/abooij/repos","events_url":"https://api.github.com/users/abooij/events{/privacy}","received_events_url":"https://api.github.com/users/abooij/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2016-04-03T22:47:18Z","updated_at":"2016-04-06T15:02:47Z","closed_at":null,"body":"A number of sample clients included with the weston reference compositor do not run correctly when using sudbury client-side.\r\n- [x] `weston-simple-egl`\r\n```\r\nhas EGL_EXT_buffer_age and EGL_EXT_swap_buffers_with_damage\r\n[1]    6970 segmentation fault (core dumped)\r\n```\r\nThis might be caused by lack of dealing with null pointers in `cArgToWireArg` in `Crap.Client`.\r\n- [ ] `weston-simple-dmabuf-intel`\r\n```\r\nbuffer allocated w 250, h 250, stride 1024, size 262144\r\nbuffer allocated w 250, h 250, stride 1024, size 262144\r\nsudbury: IntMap.!: key 4278190080 is not an element of the map\r\n```\r\nWe probably made a mistake in handling new_ids that are part of an event (ie a message from the server), in other words we can't deal with the case where the server decides to create an object.\r\n- [x] `weston-flower`\r\n```\r\nsudbury: <<loop>>\r\n```\r\nI'm not sure where this originates, but I previously encountered such a loop via an STM deadlock. A number of clients have this error, and they all successfully open a window and then exit in this way. So they show a black rectangle on the screen for a split second.\r\n- [x] `weston-info`\r\n```\r\nweston-info: symbol lookup error: weston-info: undefined symbol: wl_list_init\r\n```\r\nThis is because we did not bake in support for `wl_list`. Should be an easy fix by just including some C code. (We are not planning to support `wl_list` on the Haskell side of things because it's not really necessary to do so: we can get away with just providing this C interface.)\r\n- [x] `weston-flower` again\r\n\r\nOn mouseover:\r\n```\r\nsudbury: Message parse failed: not enough input\r\n```\r\n- [ ] others?"},"comment":{"url":"https://api.github.com/repos/abooij/sudbury/issues/comments/206417262","html_url":"https://github.com/abooij/sudbury/issues/5#issuecomment-206417262","issue_url":"https://api.github.com/repos/abooij/sudbury/issues/5","id":206417262,"user":{"login":"abooij","id":164426,"avatar_url":"https://avatars.githubusercontent.com/u/164426?v=3","gravatar_id":"","url":"https://api.github.com/users/abooij","html_url":"https://github.com/abooij","followers_url":"https://api.github.com/users/abooij/followers","following_url":"https://api.github.com/users/abooij/following{/other_user}","gists_url":"https://api.github.com/users/abooij/gists{/gist_id}","starred_url":"https://api.github.com/users/abooij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abooij/subscriptions","organizations_url":"https://api.github.com/users/abooij/orgs","repos_url":"https://api.github.com/users/abooij/repos","events_url":"https://api.github.com/users/abooij/events{/privacy}","received_events_url":"https://api.github.com/users/abooij/received_events","type":"User","site_admin":false},"created_at":"2016-04-06T15:02:47Z","updated_at":"2016-04-06T15:02:47Z","body":"I re-generated `cbits/wayland-protocol.c` (from the libwayland code) and added it. This resolves the `weston-flower` issue. But it really is a workaround since we should have had version checks or something. Something ran that shouldn't.\r\n\r\nThe underlying issue was that `weston-flower` used some kind of message that was only in this newer version. But since we were using an older version without that message, it grabbed a random piece of memory, that eventually resulted in this error.\r\n\r\nIf we check protocol versions between the library and the user, this might be a problem we can catch earlier."}}