{"action":"created","issue":{"url":"https://api.github.com/repos/pandastrike/haiku9/issues/60","repository_url":"https://api.github.com/repos/pandastrike/haiku9","labels_url":"https://api.github.com/repos/pandastrike/haiku9/issues/60/labels{/name}","comments_url":"https://api.github.com/repos/pandastrike/haiku9/issues/60/comments","events_url":"https://api.github.com/repos/pandastrike/haiku9/issues/60/events","html_url":"https://github.com/pandastrike/haiku9/pull/60","id":166689020,"number":60,"title":"Broke tests apart and added fixtures","user":{"login":"diminish7","id":29417,"avatar_url":"https://avatars.githubusercontent.com/u/29417?v=3","gravatar_id":"","url":"https://api.github.com/users/diminish7","html_url":"https://github.com/diminish7","followers_url":"https://api.github.com/users/diminish7/followers","following_url":"https://api.github.com/users/diminish7/following{/other_user}","gists_url":"https://api.github.com/users/diminish7/gists{/gist_id}","starred_url":"https://api.github.com/users/diminish7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diminish7/subscriptions","organizations_url":"https://api.github.com/users/diminish7/orgs","repos_url":"https://api.github.com/users/diminish7/repos","events_url":"https://api.github.com/users/diminish7/events{/privacy}","received_events_url":"https://api.github.com/users/diminish7/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-20T21:41:18Z","updated_at":"2016-07-20T22:33:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pandastrike/haiku9/pulls/60","html_url":"https://github.com/pandastrike/haiku9/pull/60","diff_url":"https://github.com/pandastrike/haiku9/pull/60.diff","patch_url":"https://github.com/pandastrike/haiku9/pull/60.patch"},"body":"closes #56 \r\n\r\n1. Broke the main `build` test up into tests for individual asset types\r\n2. Added fixtures directory to house small apps for testing individual bits of functionality, rather than adding more and more to the main example app\r\n3. Added some helpers:\r\n   * Build helpers to run some common functions between each of the asset build tests\r\n   * Runners to run the `build` and `serve` tasks\r\n\r\n**Note** that the `build` and `serve` runner helpers are placed in their own file so that they can be launched in their own forked process. The problem with running them inline is that they need to be run from each fixture app's root directory, but their async nature makes it impossible to know which dir you're in when the task actually fires. By running them in their own process, we can `chdir` to the right directory, then fork the process, which stays in that directory no matter where the main process `chdir`s to next."},"comment":{"url":"https://api.github.com/repos/pandastrike/haiku9/issues/comments/234104664","html_url":"https://github.com/pandastrike/haiku9/pull/60#issuecomment-234104664","issue_url":"https://api.github.com/repos/pandastrike/haiku9/issues/60","id":234104664,"user":{"login":"f1337","id":92846,"avatar_url":"https://avatars.githubusercontent.com/u/92846?v=3","gravatar_id":"","url":"https://api.github.com/users/f1337","html_url":"https://github.com/f1337","followers_url":"https://api.github.com/users/f1337/followers","following_url":"https://api.github.com/users/f1337/following{/other_user}","gists_url":"https://api.github.com/users/f1337/gists{/gist_id}","starred_url":"https://api.github.com/users/f1337/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f1337/subscriptions","organizations_url":"https://api.github.com/users/f1337/orgs","repos_url":"https://api.github.com/users/f1337/repos","events_url":"https://api.github.com/users/f1337/events{/privacy}","received_events_url":"https://api.github.com/users/f1337/received_events","type":"User","site_admin":false},"created_at":"2016-07-20T22:33:40Z","updated_at":"2016-07-20T22:33:40Z","body":"While I gave my endorsement in the issue conversation (https://github.com/pandastrike/haiku9/issues/56#issuecomment-234040470), I'm now wondering whether the complexity introduced by building multiple fixture sites is worth the tradeoff?\r\n\r\n"}}
{"actor":{"display_login":"f1337"}}