{"action":"created","issue":{"url":"https://api.github.com/repos/docker/swarm/issues/2220","repository_url":"https://api.github.com/repos/docker/swarm","labels_url":"https://api.github.com/repos/docker/swarm/issues/2220/labels{/name}","comments_url":"https://api.github.com/repos/docker/swarm/issues/2220/comments","events_url":"https://api.github.com/repos/docker/swarm/issues/2220/events","html_url":"https://github.com/docker/swarm/pull/2220","id":153768952,"number":2220,"title":"remove Godep, add vendor.json and update CONTRIBUTING.md","user":{"login":"allencloud","id":9465626,"avatar_url":"https://avatars.githubusercontent.com/u/9465626?v=3","gravatar_id":"","url":"https://api.github.com/users/allencloud","html_url":"https://github.com/allencloud","followers_url":"https://api.github.com/users/allencloud/followers","following_url":"https://api.github.com/users/allencloud/following{/other_user}","gists_url":"https://api.github.com/users/allencloud/gists{/gist_id}","starred_url":"https://api.github.com/users/allencloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allencloud/subscriptions","organizations_url":"https://api.github.com/users/allencloud/orgs","repos_url":"https://api.github.com/users/allencloud/repos","events_url":"https://api.github.com/users/allencloud/events{/privacy}","received_events_url":"https://api.github.com/users/allencloud/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/swarm/labels/status/0-triage","name":"status/0-triage","color":"EEEEEE"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-09T12:50:39Z","updated_at":"2016-05-19T17:36:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/swarm/pulls/2220","html_url":"https://github.com/docker/swarm/pull/2220","diff_url":"https://github.com/docker/swarm/pull/2220.diff","patch_url":"https://github.com/docker/swarm/pull/2220.patch"},"body":"Actually, currently Swarm uses vendor to manage golang package dependencies, but not so completely.\r\nStill missing vendor.json in /verndor.\r\nAnd when running `go test -race ./...` to do the unit testing, there are still some packages missing in /vendor.\r\nWithout improving the vendor usage, no packages can be added to /vendor automatically.\r\n \r\nThis pr did;\r\n1.remove Godeps dir when useing `govendor migrate`;\r\n2.add vendor.json when using `govendor migrate`;\r\n3.update CONTRIBUTING.md to replace  godeps with govendor.\r\n4.change `go test ./...` to use the command in travis.yml.\r\n\r\nThis PR fixes #2221 .\r\n\r\nSigned-off-by: allencloud <allen.sun@daocloud.io>"},"comment":{"url":"https://api.github.com/repos/docker/swarm/issues/comments/220397418","html_url":"https://github.com/docker/swarm/pull/2220#issuecomment-220397418","issue_url":"https://api.github.com/repos/docker/swarm/issues/2220","id":220397418,"user":{"login":"vieux","id":1032519,"avatar_url":"https://avatars.githubusercontent.com/u/1032519?v=3","gravatar_id":"","url":"https://api.github.com/users/vieux","html_url":"https://github.com/vieux","followers_url":"https://api.github.com/users/vieux/followers","following_url":"https://api.github.com/users/vieux/following{/other_user}","gists_url":"https://api.github.com/users/vieux/gists{/gist_id}","starred_url":"https://api.github.com/users/vieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vieux/subscriptions","organizations_url":"https://api.github.com/users/vieux/orgs","repos_url":"https://api.github.com/users/vieux/repos","events_url":"https://api.github.com/users/vieux/events{/privacy}","received_events_url":"https://api.github.com/users/vieux/received_events","type":"User","site_admin":false},"created_at":"2016-05-19T17:36:26Z","updated_at":"2016-05-19T17:36:26Z","body":"NOT LGTM\r\n\r\nI'm not in favor of this change. Godeps might have some flaws but it's well know and well maintained.\r\nI don't know this govendor tool\r\n\r\nping @abronan "}}