{"action":"closed","number":1407,"pull_request":{"url":"https://api.github.com/repos/rs/SDWebImage/pulls/1407","id":54272836,"html_url":"https://github.com/rs/SDWebImage/pull/1407","diff_url":"https://github.com/rs/SDWebImage/pull/1407.diff","patch_url":"https://github.com/rs/SDWebImage/pull/1407.patch","issue_url":"https://api.github.com/repos/rs/SDWebImage/issues/1407","number":1407,"state":"closed","locked":false,"title":"fix cache location paths for init and initWithNameSpace:","user":{"login":"Uplink03","id":1977375,"avatar_url":"https://avatars.githubusercontent.com/u/1977375?v=3","gravatar_id":"","url":"https://api.github.com/users/Uplink03","html_url":"https://github.com/Uplink03","followers_url":"https://api.github.com/users/Uplink03/followers","following_url":"https://api.github.com/users/Uplink03/following{/other_user}","gists_url":"https://api.github.com/users/Uplink03/gists{/gist_id}","starred_url":"https://api.github.com/users/Uplink03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Uplink03/subscriptions","organizations_url":"https://api.github.com/users/Uplink03/orgs","repos_url":"https://api.github.com/users/Uplink03/repos","events_url":"https://api.github.com/users/Uplink03/events{/privacy}","received_events_url":"https://api.github.com/users/Uplink03/received_events","type":"User","site_admin":false},"body":"When calling init and initWithNameSpace: I believe it is expected that the cache will go in Library/Caches/<namespace>, while calling initWithNamespace:diskCacheDirectory: with directory not nil the user wants a different location for the namespaces, so they'll go to <directory>/<full_namespace>.\r\n\r\nWithout this change, the cache will end up in Library/Caches/<namespace>/<full_namespace>.","created_at":"2015-12-21T16:08:06Z","updated_at":"2016-05-30T04:21:52Z","closed_at":"2016-05-30T04:21:52Z","merged_at":null,"merge_commit_sha":"99654f08bf00d8ecc713cd303d6f4895b853eae7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rs/SDWebImage/pulls/1407/commits","review_comments_url":"https://api.github.com/repos/rs/SDWebImage/pulls/1407/comments","review_comment_url":"https://api.github.com/repos/rs/SDWebImage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rs/SDWebImage/issues/1407/comments","statuses_url":"https://api.github.com/repos/rs/SDWebImage/statuses/5b64ef41a7fae0bc9f3b09ceef141ff3a085cabf","head":{"label":"Uplink03:patch-1","ref":"patch-1","sha":"5b64ef41a7fae0bc9f3b09ceef141ff3a085cabf","user":{"login":"Uplink03","id":1977375,"avatar_url":"https://avatars.githubusercontent.com/u/1977375?v=3","gravatar_id":"","url":"https://api.github.com/users/Uplink03","html_url":"https://github.com/Uplink03","followers_url":"https://api.github.com/users/Uplink03/followers","following_url":"https://api.github.com/users/Uplink03/following{/other_user}","gists_url":"https://api.github.com/users/Uplink03/gists{/gist_id}","starred_url":"https://api.github.com/users/Uplink03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Uplink03/subscriptions","organizations_url":"https://api.github.com/users/Uplink03/orgs","repos_url":"https://api.github.com/users/Uplink03/repos","events_url":"https://api.github.com/users/Uplink03/events{/privacy}","received_events_url":"https://api.github.com/users/Uplink03/received_events","type":"User","site_admin":false},"repo":{"id":48375293,"name":"SDWebImage","full_name":"Uplink03/SDWebImage","owner":{"login":"Uplink03","id":1977375,"avatar_url":"https://avatars.githubusercontent.com/u/1977375?v=3","gravatar_id":"","url":"https://api.github.com/users/Uplink03","html_url":"https://github.com/Uplink03","followers_url":"https://api.github.com/users/Uplink03/followers","following_url":"https://api.github.com/users/Uplink03/following{/other_user}","gists_url":"https://api.github.com/users/Uplink03/gists{/gist_id}","starred_url":"https://api.github.com/users/Uplink03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Uplink03/subscriptions","organizations_url":"https://api.github.com/users/Uplink03/orgs","repos_url":"https://api.github.com/users/Uplink03/repos","events_url":"https://api.github.com/users/Uplink03/events{/privacy}","received_events_url":"https://api.github.com/users/Uplink03/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Uplink03/SDWebImage","description":"Asynchronous image downloader with cache support as a UIImageView category","fork":true,"url":"https://api.github.com/repos/Uplink03/SDWebImage","forks_url":"https://api.github.com/repos/Uplink03/SDWebImage/forks","keys_url":"https://api.github.com/repos/Uplink03/SDWebImage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Uplink03/SDWebImage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Uplink03/SDWebImage/teams","hooks_url":"https://api.github.com/repos/Uplink03/SDWebImage/hooks","issue_events_url":"https://api.github.com/repos/Uplink03/SDWebImage/issues/events{/number}","events_url":"https://api.github.com/repos/Uplink03/SDWebImage/events","assignees_url":"https://api.github.com/repos/Uplink03/SDWebImage/assignees{/user}","branches_url":"https://api.github.com/repos/Uplink03/SDWebImage/branches{/branch}","tags_url":"https://api.github.com/repos/Uplink03/SDWebImage/tags","blobs_url":"https://api.github.com/repos/Uplink03/SDWebImage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Uplink03/SDWebImage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Uplink03/SDWebImage/git/refs{/sha}","trees_url":"https://api.github.com/repos/Uplink03/SDWebImage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Uplink03/SDWebImage/statuses/{sha}","languages_url":"https://api.github.com/repos/Uplink03/SDWebImage/languages","stargazers_url":"https://api.github.com/repos/Uplink03/SDWebImage/stargazers","contributors_url":"https://api.github.com/repos/Uplink03/SDWebImage/contributors","subscribers_url":"https://api.github.com/repos/Uplink03/SDWebImage/subscribers","subscription_url":"https://api.github.com/repos/Uplink03/SDWebImage/subscription","commits_url":"https://api.github.com/repos/Uplink03/SDWebImage/commits{/sha}","git_commits_url":"https://api.github.com/repos/Uplink03/SDWebImage/git/commits{/sha}","comments_url":"https://api.github.com/repos/Uplink03/SDWebImage/comments{/number}","issue_comment_url":"https://api.github.com/repos/Uplink03/SDWebImage/issues/comments{/number}","contents_url":"https://api.github.com/repos/Uplink03/SDWebImage/contents/{+path}","compare_url":"https://api.github.com/repos/Uplink03/SDWebImage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Uplink03/SDWebImage/merges","archive_url":"https://api.github.com/repos/Uplink03/SDWebImage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Uplink03/SDWebImage/downloads","issues_url":"https://api.github.com/repos/Uplink03/SDWebImage/issues{/number}","pulls_url":"https://api.github.com/repos/Uplink03/SDWebImage/pulls{/number}","milestones_url":"https://api.github.com/repos/Uplink03/SDWebImage/milestones{/number}","notifications_url":"https://api.github.com/repos/Uplink03/SDWebImage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Uplink03/SDWebImage/labels{/name}","releases_url":"https://api.github.com/repos/Uplink03/SDWebImage/releases{/id}","deployments_url":"https://api.github.com/repos/Uplink03/SDWebImage/deployments","created_at":"2015-12-21T14:13:03Z","updated_at":"2015-12-21T14:13:06Z","pushed_at":"2015-12-21T16:06:38Z","git_url":"git://github.com/Uplink03/SDWebImage.git","ssh_url":"git@github.com:Uplink03/SDWebImage.git","clone_url":"https://github.com/Uplink03/SDWebImage.git","svn_url":"https://github.com/Uplink03/SDWebImage","homepage":"http://hackemist.com/SDWebImage/doc","size":3973,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rs:master","ref":"master","sha":"740cd7f0902b5e9eddf4a52ff76ec630fdf753bc","user":{"login":"rs","id":68232,"avatar_url":"https://avatars.githubusercontent.com/u/68232?v=3","gravatar_id":"","url":"https://api.github.com/users/rs","html_url":"https://github.com/rs","followers_url":"https://api.github.com/users/rs/followers","following_url":"https://api.github.com/users/rs/following{/other_user}","gists_url":"https://api.github.com/users/rs/gists{/gist_id}","starred_url":"https://api.github.com/users/rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rs/subscriptions","organizations_url":"https://api.github.com/users/rs/orgs","repos_url":"https://api.github.com/users/rs/repos","events_url":"https://api.github.com/users/rs/events{/privacy}","received_events_url":"https://api.github.com/users/rs/received_events","type":"User","site_admin":false},"repo":{"id":313419,"name":"SDWebImage","full_name":"rs/SDWebImage","owner":{"login":"rs","id":68232,"avatar_url":"https://avatars.githubusercontent.com/u/68232?v=3","gravatar_id":"","url":"https://api.github.com/users/rs","html_url":"https://github.com/rs","followers_url":"https://api.github.com/users/rs/followers","following_url":"https://api.github.com/users/rs/following{/other_user}","gists_url":"https://api.github.com/users/rs/gists{/gist_id}","starred_url":"https://api.github.com/users/rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rs/subscriptions","organizations_url":"https://api.github.com/users/rs/orgs","repos_url":"https://api.github.com/users/rs/repos","events_url":"https://api.github.com/users/rs/events{/privacy}","received_events_url":"https://api.github.com/users/rs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rs/SDWebImage","description":"Asynchronous image downloader with cache support as a UIImageView category","fork":false,"url":"https://api.github.com/repos/rs/SDWebImage","forks_url":"https://api.github.com/repos/rs/SDWebImage/forks","keys_url":"https://api.github.com/repos/rs/SDWebImage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rs/SDWebImage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rs/SDWebImage/teams","hooks_url":"https://api.github.com/repos/rs/SDWebImage/hooks","issue_events_url":"https://api.github.com/repos/rs/SDWebImage/issues/events{/number}","events_url":"https://api.github.com/repos/rs/SDWebImage/events","assignees_url":"https://api.github.com/repos/rs/SDWebImage/assignees{/user}","branches_url":"https://api.github.com/repos/rs/SDWebImage/branches{/branch}","tags_url":"https://api.github.com/repos/rs/SDWebImage/tags","blobs_url":"https://api.github.com/repos/rs/SDWebImage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rs/SDWebImage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rs/SDWebImage/git/refs{/sha}","trees_url":"https://api.github.com/repos/rs/SDWebImage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rs/SDWebImage/statuses/{sha}","languages_url":"https://api.github.com/repos/rs/SDWebImage/languages","stargazers_url":"https://api.github.com/repos/rs/SDWebImage/stargazers","contributors_url":"https://api.github.com/repos/rs/SDWebImage/contributors","subscribers_url":"https://api.github.com/repos/rs/SDWebImage/subscribers","subscription_url":"https://api.github.com/repos/rs/SDWebImage/subscription","commits_url":"https://api.github.com/repos/rs/SDWebImage/commits{/sha}","git_commits_url":"https://api.github.com/repos/rs/SDWebImage/git/commits{/sha}","comments_url":"https://api.github.com/repos/rs/SDWebImage/comments{/number}","issue_comment_url":"https://api.github.com/repos/rs/SDWebImage/issues/comments{/number}","contents_url":"https://api.github.com/repos/rs/SDWebImage/contents/{+path}","compare_url":"https://api.github.com/repos/rs/SDWebImage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rs/SDWebImage/merges","archive_url":"https://api.github.com/repos/rs/SDWebImage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rs/SDWebImage/downloads","issues_url":"https://api.github.com/repos/rs/SDWebImage/issues{/number}","pulls_url":"https://api.github.com/repos/rs/SDWebImage/pulls{/number}","milestones_url":"https://api.github.com/repos/rs/SDWebImage/milestones{/number}","notifications_url":"https://api.github.com/repos/rs/SDWebImage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rs/SDWebImage/labels{/name}","releases_url":"https://api.github.com/repos/rs/SDWebImage/releases{/id}","deployments_url":"https://api.github.com/repos/rs/SDWebImage/deployments","created_at":"2009-09-21T17:39:19Z","updated_at":"2016-05-30T04:20:11Z","pushed_at":"2016-05-30T03:53:08Z","git_url":"git://github.com/rs/SDWebImage.git","ssh_url":"git@github.com:rs/SDWebImage.git","clone_url":"https://github.com/rs/SDWebImage.git","svn_url":"https://github.com/rs/SDWebImage","homepage":"http://hackemist.com/SDWebImage/doc","size":6206,"stargazers_count":14500,"watchers_count":14500,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4122,"mirror_url":null,"open_issues_count":156,"forks":4122,"open_issues":156,"watchers":14500,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rs/SDWebImage/pulls/1407"},"html":{"href":"https://github.com/rs/SDWebImage/pull/1407"},"issue":{"href":"https://api.github.com/repos/rs/SDWebImage/issues/1407"},"comments":{"href":"https://api.github.com/repos/rs/SDWebImage/issues/1407/comments"},"review_comments":{"href":"https://api.github.com/repos/rs/SDWebImage/pulls/1407/comments"},"review_comment":{"href":"https://api.github.com/repos/rs/SDWebImage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rs/SDWebImage/pulls/1407/commits"},"statuses":{"href":"https://api.github.com/repos/rs/SDWebImage/statuses/5b64ef41a7fae0bc9f3b09ceef141ff3a085cabf"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"bpoplauschi"}}