{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/82656690","pull_request_review_id":3549430,"id":82656690,"diff_hunk":"@@ -295,10 +296,9 @@ impl Request {\n                 Some(s) => s,\n                 None => return Err(Error::Type(\"Method is not a valid UTF8\".to_string())),\n             };\n-            let normalized_method = normalize_method(method_string);\n+            let method = normalize_method(method_string);\n             // Step 25.3\n-            let hyper_method = normalized_method_to_typed_method(&normalized_method);\n-            *request.method.borrow_mut() = hyper_method;\n+            *request.method.borrow_mut() = method;","path":"components/script/dom/request.rs","position":17,"original_position":17,"commit_id":"61b363e330947b8074c13961a7276875e77b1a30","original_commit_id":"61b363e330947b8074c13961a7276875e77b1a30","user":{"login":"KiChjang","id":3248587,"avatar_url":"https://avatars.githubusercontent.com/u/3248587?v=3","gravatar_id":"","url":"https://api.github.com/users/KiChjang","html_url":"https://github.com/KiChjang","followers_url":"https://api.github.com/users/KiChjang/followers","following_url":"https://api.github.com/users/KiChjang/following{/other_user}","gists_url":"https://api.github.com/users/KiChjang/gists{/gist_id}","starred_url":"https://api.github.com/users/KiChjang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiChjang/subscriptions","organizations_url":"https://api.github.com/users/KiChjang/orgs","repos_url":"https://api.github.com/users/KiChjang/repos","events_url":"https://api.github.com/users/KiChjang/events{/privacy}","received_events_url":"https://api.github.com/users/KiChjang/received_events","type":"User","site_admin":false},"body":"Is `method` used anywhere else in this scope? If not, we can just make the above two lines into one.","created_at":"2016-10-10T18:20:20Z","updated_at":"2016-10-10T18:20:20Z","html_url":"https://github.com/servo/servo/pull/13679#discussion_r82656690","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/13679","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/82656690"},"html":{"href":"https://github.com/servo/servo/pull/13679#discussion_r82656690"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/13679"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/13679","id":88703267,"html_url":"https://github.com/servo/servo/pull/13679","diff_url":"https://github.com/servo/servo/pull/13679.diff","patch_url":"https://github.com/servo/servo/pull/13679.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/13679","number":13679,"state":"open","locked":false,"title":"Remove unnecessary `String` allocation.","user":{"login":"frewsxcv","id":416575,"avatar_url":"https://avatars.githubusercontent.com/u/416575?v=3","gravatar_id":"","url":"https://api.github.com/users/frewsxcv","html_url":"https://github.com/frewsxcv","followers_url":"https://api.github.com/users/frewsxcv/followers","following_url":"https://api.github.com/users/frewsxcv/following{/other_user}","gists_url":"https://api.github.com/users/frewsxcv/gists{/gist_id}","starred_url":"https://api.github.com/users/frewsxcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frewsxcv/subscriptions","organizations_url":"https://api.github.com/users/frewsxcv/orgs","repos_url":"https://api.github.com/users/frewsxcv/repos","events_url":"https://api.github.com/users/frewsxcv/events{/privacy}","received_events_url":"https://api.github.com/users/frewsxcv/received_events","type":"User","site_admin":false},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/13679)\n<!-- Reviewable:end -->\n","created_at":"2016-10-10T17:43:21Z","updated_at":"2016-10-10T18:20:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63299c009fa371ee96e5ffa45b818c4483784520","assignee":{"login":"Wafflespeanut","id":6691262,"avatar_url":"https://avatars.githubusercontent.com/u/6691262?v=3","gravatar_id":"","url":"https://api.github.com/users/Wafflespeanut","html_url":"https://github.com/Wafflespeanut","followers_url":"https://api.github.com/users/Wafflespeanut/followers","following_url":"https://api.github.com/users/Wafflespeanut/following{/other_user}","gists_url":"https://api.github.com/users/Wafflespeanut/gists{/gist_id}","starred_url":"https://api.github.com/users/Wafflespeanut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wafflespeanut/subscriptions","organizations_url":"https://api.github.com/users/Wafflespeanut/orgs","repos_url":"https://api.github.com/users/Wafflespeanut/repos","events_url":"https://api.github.com/users/Wafflespeanut/events{/privacy}","received_events_url":"https://api.github.com/users/Wafflespeanut/received_events","type":"User","site_admin":false},"assignees":[{"login":"Wafflespeanut","id":6691262,"avatar_url":"https://avatars.githubusercontent.com/u/6691262?v=3","gravatar_id":"","url":"https://api.github.com/users/Wafflespeanut","html_url":"https://github.com/Wafflespeanut","followers_url":"https://api.github.com/users/Wafflespeanut/followers","following_url":"https://api.github.com/users/Wafflespeanut/following{/other_user}","gists_url":"https://api.github.com/users/Wafflespeanut/gists{/gist_id}","starred_url":"https://api.github.com/users/Wafflespeanut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wafflespeanut/subscriptions","organizations_url":"https://api.github.com/users/Wafflespeanut/orgs","repos_url":"https://api.github.com/users/Wafflespeanut/repos","events_url":"https://api.github.com/users/Wafflespeanut/events{/privacy}","received_events_url":"https://api.github.com/users/Wafflespeanut/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/13679/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/13679/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/13679/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/61b363e330947b8074c13961a7276875e77b1a30","head":{"label":"frewsxcv:remove-str-alloc","ref":"remove-str-alloc","sha":"61b363e330947b8074c13961a7276875e77b1a30","user":{"login":"frewsxcv","id":416575,"avatar_url":"https://avatars.githubusercontent.com/u/416575?v=3","gravatar_id":"","url":"https://api.github.com/users/frewsxcv","html_url":"https://github.com/frewsxcv","followers_url":"https://api.github.com/users/frewsxcv/followers","following_url":"https://api.github.com/users/frewsxcv/following{/other_user}","gists_url":"https://api.github.com/users/frewsxcv/gists{/gist_id}","starred_url":"https://api.github.com/users/frewsxcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frewsxcv/subscriptions","organizations_url":"https://api.github.com/users/frewsxcv/orgs","repos_url":"https://api.github.com/users/frewsxcv/repos","events_url":"https://api.github.com/users/frewsxcv/events{/privacy}","received_events_url":"https://api.github.com/users/frewsxcv/received_events","type":"User","site_admin":false},"repo":{"id":27014207,"name":"servo","full_name":"frewsxcv/servo","owner":{"login":"frewsxcv","id":416575,"avatar_url":"https://avatars.githubusercontent.com/u/416575?v=3","gravatar_id":"","url":"https://api.github.com/users/frewsxcv","html_url":"https://github.com/frewsxcv","followers_url":"https://api.github.com/users/frewsxcv/followers","following_url":"https://api.github.com/users/frewsxcv/following{/other_user}","gists_url":"https://api.github.com/users/frewsxcv/gists{/gist_id}","starred_url":"https://api.github.com/users/frewsxcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frewsxcv/subscriptions","organizations_url":"https://api.github.com/users/frewsxcv/orgs","repos_url":"https://api.github.com/users/frewsxcv/repos","events_url":"https://api.github.com/users/frewsxcv/events{/privacy}","received_events_url":"https://api.github.com/users/frewsxcv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/frewsxcv/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/frewsxcv/servo","forks_url":"https://api.github.com/repos/frewsxcv/servo/forks","keys_url":"https://api.github.com/repos/frewsxcv/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frewsxcv/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frewsxcv/servo/teams","hooks_url":"https://api.github.com/repos/frewsxcv/servo/hooks","issue_events_url":"https://api.github.com/repos/frewsxcv/servo/issues/events{/number}","events_url":"https://api.github.com/repos/frewsxcv/servo/events","assignees_url":"https://api.github.com/repos/frewsxcv/servo/assignees{/user}","branches_url":"https://api.github.com/repos/frewsxcv/servo/branches{/branch}","tags_url":"https://api.github.com/repos/frewsxcv/servo/tags","blobs_url":"https://api.github.com/repos/frewsxcv/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frewsxcv/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frewsxcv/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/frewsxcv/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frewsxcv/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/frewsxcv/servo/languages","stargazers_url":"https://api.github.com/repos/frewsxcv/servo/stargazers","contributors_url":"https://api.github.com/repos/frewsxcv/servo/contributors","subscribers_url":"https://api.github.com/repos/frewsxcv/servo/subscribers","subscription_url":"https://api.github.com/repos/frewsxcv/servo/subscription","commits_url":"https://api.github.com/repos/frewsxcv/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/frewsxcv/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/frewsxcv/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/frewsxcv/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/frewsxcv/servo/contents/{+path}","compare_url":"https://api.github.com/repos/frewsxcv/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frewsxcv/servo/merges","archive_url":"https://api.github.com/repos/frewsxcv/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frewsxcv/servo/downloads","issues_url":"https://api.github.com/repos/frewsxcv/servo/issues{/number}","pulls_url":"https://api.github.com/repos/frewsxcv/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/frewsxcv/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/frewsxcv/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frewsxcv/servo/labels{/name}","releases_url":"https://api.github.com/repos/frewsxcv/servo/releases{/id}","deployments_url":"https://api.github.com/repos/frewsxcv/servo/deployments","created_at":"2014-11-22T22:10:35Z","updated_at":"2015-12-23T11:40:15Z","pushed_at":"2016-10-10T18:17:30Z","git_url":"git://github.com/frewsxcv/servo.git","ssh_url":"git@github.com:frewsxcv/servo.git","clone_url":"https://github.com/frewsxcv/servo.git","svn_url":"https://github.com/frewsxcv/servo","homepage":"","size":211647,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"ef7423bf0034a41b12ba50e623c9b3dba39a53bc","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2016-10-10T16:25:36Z","pushed_at":"2016-10-10T18:17:44Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":301046,"stargazers_count":8029,"watchers_count":8029,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1301,"mirror_url":null,"open_issues_count":1782,"forks":1301,"open_issues":1782,"watchers":8029,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/13679"},"html":{"href":"https://github.com/servo/servo/pull/13679"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/13679"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/13679/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/13679/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/13679/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/61b363e330947b8074c13961a7276875e77b1a30"}}}}
{"actor":{"display_login":"KiChjang"}}