{"action":"created","issue":{"url":"https://api.github.com/repos/almighty/almighty-core/issues/45","repository_url":"https://api.github.com/repos/almighty/almighty-core","labels_url":"https://api.github.com/repos/almighty/almighty-core/issues/45/labels{/name}","comments_url":"https://api.github.com/repos/almighty/almighty-core/issues/45/comments","events_url":"https://api.github.com/repos/almighty/almighty-core/issues/45/events","html_url":"https://github.com/almighty/almighty-core/pull/45","id":167688342,"number":45,"title":"WIP: Add 'make check' target for running goimports/golint verification","user":{"login":"aslakknutsen","id":132158,"avatar_url":"https://avatars.githubusercontent.com/u/132158?v=3","gravatar_id":"","url":"https://api.github.com/users/aslakknutsen","html_url":"https://github.com/aslakknutsen","followers_url":"https://api.github.com/users/aslakknutsen/followers","following_url":"https://api.github.com/users/aslakknutsen/following{/other_user}","gists_url":"https://api.github.com/users/aslakknutsen/gists{/gist_id}","starred_url":"https://api.github.com/users/aslakknutsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aslakknutsen/subscriptions","organizations_url":"https://api.github.com/users/aslakknutsen/orgs","repos_url":"https://api.github.com/users/aslakknutsen/repos","events_url":"https://api.github.com/users/aslakknutsen/events{/privacy}","received_events_url":"https://api.github.com/users/aslakknutsen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-26T19:17:07Z","updated_at":"2016-07-27T08:17:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/almighty/almighty-core/pulls/45","html_url":"https://github.com/almighty/almighty-core/pull/45","diff_url":"https://github.com/almighty/almighty-core/pull/45.diff","patch_url":"https://github.com/almighty/almighty-core/pull/45.patch"},"body":"fixes #44 \r\n\r\n* Not tested on Windows\r\n* Without a 'fix commit' this will fail all builds moving forward. A 'complete' fix up commit is required.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/almighty/almighty-core/45)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/almighty/almighty-core/issues/comments/235517669","html_url":"https://github.com/almighty/almighty-core/pull/45#issuecomment-235517669","issue_url":"https://api.github.com/repos/almighty/almighty-core/issues/45","id":235517669,"user":{"login":"kwk","id":193408,"avatar_url":"https://avatars.githubusercontent.com/u/193408?v=3","gravatar_id":"","url":"https://api.github.com/users/kwk","html_url":"https://github.com/kwk","followers_url":"https://api.github.com/users/kwk/followers","following_url":"https://api.github.com/users/kwk/following{/other_user}","gists_url":"https://api.github.com/users/kwk/gists{/gist_id}","starred_url":"https://api.github.com/users/kwk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwk/subscriptions","organizations_url":"https://api.github.com/users/kwk/orgs","repos_url":"https://api.github.com/users/kwk/repos","events_url":"https://api.github.com/users/kwk/events{/privacy}","received_events_url":"https://api.github.com/users/kwk/received_events","type":"User","site_admin":false},"created_at":"2016-07-27T08:17:08Z","updated_at":"2016-07-27T08:17:08Z","body":"\n\n\n\nReview status: 0 of 21 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.\n\n---\n\n*[glide.lock, line 6 \\[r2\\]](https://reviewable.io:443/reviews/almighty/almighty-core/45#-KNfN-QE9I1kzGZuQfAh:-KNfN-QE9I1kzGZuQfAi:-759836141) ([raw file](https://github.com/almighty/almighty-core/blob/ff072ccc137b6c817eb185f879961a667cca1236/glide.lock#L6)):*\n> ```\n> - name: bitbucket.org/pkg/inflect\n>   version: 8961c3750a47b8c0b3e118d52513b97adf85a7e8\n> - name: github.com/almighty/almighty-core\n> ```\n\nHow come, the project itself is suddenly a dependency of its own? :)\n\n---\n\n*[Makefile, line 12 \\[r2\\]](https://reviewable.io:443/reviews/almighty/almighty-core/45#-KNfNSO5QsJOnbM_fRDJ:-KNfNSO5QsJOnbM_fRDK:1775152032) ([raw file](https://github.com/almighty/almighty-core/blob/ff072ccc137b6c817eb185f879961a667cca1236/Makefile#L12)):*\n> ```Makefile\n> DESIGN_DIR=design\n> DESIGNS := $(shell find $(SOURCE_DIR)/$(DESIGN_DIR) -path $(SOURCE_DIR)/vendor -prune -o -name '*.go' -print)\n> DIRS=$(shell go list -f {{.Dir}} ./... | grep -v -E \"vendor|app|client|tool/cli\")\n> ```\n\nMaybe `DIRS` is too generic? `CHECK_DIRS` could work.\n\n---\n\n*[Makefile, line 113 \\[r2\\]](https://reviewable.io:443/reviews/almighty/almighty-core/45#-KNfOmq0QnT08RSnxxD6:-KNfOmq0QnT08RSnxxD7:-490100129) ([raw file](https://github.com/almighty/almighty-core/blob/ff072ccc137b6c817eb185f879961a667cca1236/Makefile#L113)):*\n> ```Makefile\n> \techo \"\" > check_error\n> \tfor d in $(DIRS) ; do \\\n> \t\tif [ \"`$(GOIMPORTS_BIN) -l $$d/*.go | grep -vEf .golint_exclude | tee -a check_error`\" ]; then \\\n> ```\n\nNice!\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/almighty/almighty-core/45)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"kwk"}}