{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/90045302","pull_request_review_id":10570797,"id":90045302,"diff_hunk":"@@ -748,19 +748,21 @@ cmake .. \\\n %endif\n %endif\n \n+# set PORTABLE=1 on aarch64 so rocksdb doesn't use -march=native\n+# http://tracker.ceph.com/issues/18065\n+%ifarch aarch64\n+PORTABLE=1 make %{?_smp_mflags}","path":"ceph.spec.in","position":7,"original_position":7,"commit_id":"baea7760a4bac3e79be0436375fd27c2261b3439","original_commit_id":"baea7760a4bac3e79be0436375fd27c2261b3439","user":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"body":"rocksdb's CMakeLists.txt does not understand `PORTABLE=1`, and the `-march=native` was dropped in https://github.com/facebook/rocksdb/commit/9c0bb7f1720415c15c057787cec641ac7814a86d. \r\n\r\ncould you try again using the latest master which includes the commit 4b2046eb686f5af9dfbff5712abf63b85c6ce1ca which fixes the cross-compiling ?","created_at":"2016-11-29T16:24:14Z","updated_at":"2016-11-29T16:24:14Z","html_url":"https://github.com/ceph/ceph/pull/12214#discussion_r90045302","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/12214","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/90045302"},"html":{"href":"https://github.com/ceph/ceph/pull/12214#discussion_r90045302"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/12214"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/12214","id":95699537,"html_url":"https://github.com/ceph/ceph/pull/12214","diff_url":"https://github.com/ceph/ceph/pull/12214.diff","patch_url":"https://github.com/ceph/ceph/pull/12214.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/12214","number":12214,"state":"open","locked":false,"title":"build/ops: run make with PORTABLE=1 on aarch64","user":{"login":"smithfarm","id":3974844,"avatar_url":"https://avatars.githubusercontent.com/u/3974844?v=3","gravatar_id":"","url":"https://api.github.com/users/smithfarm","html_url":"https://github.com/smithfarm","followers_url":"https://api.github.com/users/smithfarm/followers","following_url":"https://api.github.com/users/smithfarm/following{/other_user}","gists_url":"https://api.github.com/users/smithfarm/gists{/gist_id}","starred_url":"https://api.github.com/users/smithfarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smithfarm/subscriptions","organizations_url":"https://api.github.com/users/smithfarm/orgs","repos_url":"https://api.github.com/users/smithfarm/repos","events_url":"https://api.github.com/users/smithfarm/events{/privacy}","received_events_url":"https://api.github.com/users/smithfarm/received_events","type":"User","site_admin":false},"body":"rocksdb was refusing to build for aarch64 because the compiler we were using\r\ndid not support -march=native. The rocksdb documentation suggests that this can\r\nbe disabled by running make in this way.\r\n\r\nFixes: http://tracker.ceph.com/issues/18065\r\nSigned-off-by: smithfarm <ncutler@suse.com>","created_at":"2016-11-29T14:13:43Z","updated_at":"2016-11-29T16:24:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ea8734dd7dd3eeff7f0bd916f26c14cded9e26e","assignee":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"assignees":[{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},{"login":"ktdreyer","id":620295,"avatar_url":"https://avatars.githubusercontent.com/u/620295?v=3","gravatar_id":"","url":"https://api.github.com/users/ktdreyer","html_url":"https://github.com/ktdreyer","followers_url":"https://api.github.com/users/ktdreyer/followers","following_url":"https://api.github.com/users/ktdreyer/following{/other_user}","gists_url":"https://api.github.com/users/ktdreyer/gists{/gist_id}","starred_url":"https://api.github.com/users/ktdreyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktdreyer/subscriptions","organizations_url":"https://api.github.com/users/ktdreyer/orgs","repos_url":"https://api.github.com/users/ktdreyer/repos","events_url":"https://api.github.com/users/ktdreyer/events{/privacy}","received_events_url":"https://api.github.com/users/ktdreyer/received_events","type":"User","site_admin":false},{"login":"b-ranto","id":8439091,"avatar_url":"https://avatars.githubusercontent.com/u/8439091?v=3","gravatar_id":"","url":"https://api.github.com/users/b-ranto","html_url":"https://github.com/b-ranto","followers_url":"https://api.github.com/users/b-ranto/followers","following_url":"https://api.github.com/users/b-ranto/following{/other_user}","gists_url":"https://api.github.com/users/b-ranto/gists{/gist_id}","starred_url":"https://api.github.com/users/b-ranto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b-ranto/subscriptions","organizations_url":"https://api.github.com/users/b-ranto/orgs","repos_url":"https://api.github.com/users/b-ranto/repos","events_url":"https://api.github.com/users/b-ranto/events{/privacy}","received_events_url":"https://api.github.com/users/b-ranto/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/12214/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/12214/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/12214/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/baea7760a4bac3e79be0436375fd27c2261b3439","head":{"label":"SUSE:wip-18065-kraken","ref":"wip-18065-kraken","sha":"baea7760a4bac3e79be0436375fd27c2261b3439","user":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":20325897,"name":"ceph","full_name":"SUSE/ceph","owner":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/SUSE/ceph","forks_url":"https://api.github.com/repos/SUSE/ceph/forks","keys_url":"https://api.github.com/repos/SUSE/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/ceph/teams","hooks_url":"https://api.github.com/repos/SUSE/ceph/hooks","issue_events_url":"https://api.github.com/repos/SUSE/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/ceph/events","assignees_url":"https://api.github.com/repos/SUSE/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/ceph/tags","blobs_url":"https://api.github.com/repos/SUSE/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/ceph/languages","stargazers_url":"https://api.github.com/repos/SUSE/ceph/stargazers","contributors_url":"https://api.github.com/repos/SUSE/ceph/contributors","subscribers_url":"https://api.github.com/repos/SUSE/ceph/subscribers","subscription_url":"https://api.github.com/repos/SUSE/ceph/subscription","commits_url":"https://api.github.com/repos/SUSE/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/ceph/merges","archive_url":"https://api.github.com/repos/SUSE/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/ceph/downloads","issues_url":"https://api.github.com/repos/SUSE/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/ceph/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/SUSE/ceph/deployments","created_at":"2014-05-30T10:29:18Z","updated_at":"2016-11-13T23:43:21Z","pushed_at":"2016-11-29T16:04:53Z","git_url":"git://github.com/SUSE/ceph.git","ssh_url":"git@github.com:SUSE/ceph.git","clone_url":"https://github.com/SUSE/ceph.git","svn_url":"https://github.com/SUSE/ceph","homepage":"http://ceph.com","size":308082,"stargazers_count":9,"watchers_count":9,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":0,"forks":9,"open_issues":0,"watchers":9,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"bfa66be2b0e8f95cbd38699e3082db15b1156183","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-11-29T04:06:33Z","pushed_at":"2016-11-29T16:06:39Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":252118,"stargazers_count":2658,"watchers_count":2658,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1563,"mirror_url":null,"open_issues_count":330,"forks":1563,"open_issues":330,"watchers":2658,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/12214"},"html":{"href":"https://github.com/ceph/ceph/pull/12214"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/12214"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/12214/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/12214/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/12214/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/baea7760a4bac3e79be0436375fd27c2261b3439"}}}}
{"actor":{"display_login":"tchaikov"}}