{"action":"created","issue":{"url":"https://api.github.com/repos/JeffBezanson/FixedPointNumbers.jl/issues/32","repository_url":"https://api.github.com/repos/JeffBezanson/FixedPointNumbers.jl","labels_url":"https://api.github.com/repos/JeffBezanson/FixedPointNumbers.jl/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/JeffBezanson/FixedPointNumbers.jl/issues/32/comments","events_url":"https://api.github.com/repos/JeffBezanson/FixedPointNumbers.jl/issues/32/events","html_url":"https://github.com/JeffBezanson/FixedPointNumbers.jl/pull/32","id":111545808,"number":32,"title":"[RFC/WIP] unify the concepts of Fixed and UFixed","user":{"login":"vchuravy","id":145258,"avatar_url":"https://avatars.githubusercontent.com/u/145258?v=3","gravatar_id":"","url":"https://api.github.com/users/vchuravy","html_url":"https://github.com/vchuravy","followers_url":"https://api.github.com/users/vchuravy/followers","following_url":"https://api.github.com/users/vchuravy/following{/other_user}","gists_url":"https://api.github.com/users/vchuravy/gists{/gist_id}","starred_url":"https://api.github.com/users/vchuravy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vchuravy/subscriptions","organizations_url":"https://api.github.com/users/vchuravy/orgs","repos_url":"https://api.github.com/users/vchuravy/repos","events_url":"https://api.github.com/users/vchuravy/events{/privacy}","received_events_url":"https://api.github.com/users/vchuravy/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2015-10-15T05:08:03Z","updated_at":"2016-09-14T14:45:56Z","closed_at":"2016-09-14T14:45:56Z","pull_request":{"url":"https://api.github.com/repos/JeffBezanson/FixedPointNumbers.jl/pulls/32","html_url":"https://github.com/JeffBezanson/FixedPointNumbers.jl/pull/32","diff_url":"https://github.com/JeffBezanson/FixedPointNumbers.jl/pull/32.diff","patch_url":"https://github.com/JeffBezanson/FixedPointNumbers.jl/pull/32.patch"},"body":"After #27 UFixed and Fixed shared a lot of concepts and they do effectively the same thing, but sometimes a function is only implemented one way.\r\n\r\nThis is the current status of having only one type of FixedPoint and the underlying Type T defines  whether it is a Unsigned or Signed type.\r\n\r\nI added in comments the second implementation if the implementation is ambiguous and I haven't looked at the tests yet.\r\n\r\nMerging those two concepts simplifies the code immensely, but it also highlights the subtle differences that where  between Fixed and UFixed.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/JeffBezanson/FixedPointNumbers.jl/issues/comments/247036997","html_url":"https://github.com/JeffBezanson/FixedPointNumbers.jl/pull/32#issuecomment-247036997","issue_url":"https://api.github.com/repos/JeffBezanson/FixedPointNumbers.jl/issues/32","id":247036997,"user":{"login":"vchuravy","id":145258,"avatar_url":"https://avatars.githubusercontent.com/u/145258?v=3","gravatar_id":"","url":"https://api.github.com/users/vchuravy","html_url":"https://github.com/vchuravy","followers_url":"https://api.github.com/users/vchuravy/followers","following_url":"https://api.github.com/users/vchuravy/following{/other_user}","gists_url":"https://api.github.com/users/vchuravy/gists{/gist_id}","starred_url":"https://api.github.com/users/vchuravy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vchuravy/subscriptions","organizations_url":"https://api.github.com/users/vchuravy/orgs","repos_url":"https://api.github.com/users/vchuravy/repos","events_url":"https://api.github.com/users/vchuravy/events{/privacy}","received_events_url":"https://api.github.com/users/vchuravy/received_events","type":"User","site_admin":false},"created_at":"2016-09-14T14:45:56Z","updated_at":"2016-09-14T14:45:56Z","body":"I am still interested in renaming `UFixed` to `UNormed` or `UNorm`. But I don't think anymore that having `Fixed{Unsigned}` is really useful.\r\n"}}
{"actor":{"display_login":"vchuravy"}}