{"action":"created","issue":{"url":"https://api.github.com/repos/gmpl/FSharpPlus/issues/27","repository_url":"https://api.github.com/repos/gmpl/FSharpPlus","labels_url":"https://api.github.com/repos/gmpl/FSharpPlus/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/gmpl/FSharpPlus/issues/27/comments","events_url":"https://api.github.com/repos/gmpl/FSharpPlus/issues/27/events","html_url":"https://github.com/gmpl/FSharpPlus/pull/27","id":197401989,"number":27,"title":"Initial commit of rebuilt project","user":{"login":"dogwith1eye","id":6156330,"avatar_url":"https://avatars.githubusercontent.com/u/6156330?v=3","gravatar_id":"","url":"https://api.github.com/users/dogwith1eye","html_url":"https://github.com/dogwith1eye","followers_url":"https://api.github.com/users/dogwith1eye/followers","following_url":"https://api.github.com/users/dogwith1eye/following{/other_user}","gists_url":"https://api.github.com/users/dogwith1eye/gists{/gist_id}","starred_url":"https://api.github.com/users/dogwith1eye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dogwith1eye/subscriptions","organizations_url":"https://api.github.com/users/dogwith1eye/orgs","repos_url":"https://api.github.com/users/dogwith1eye/repos","events_url":"https://api.github.com/users/dogwith1eye/events{/privacy}","received_events_url":"https://api.github.com/users/dogwith1eye/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-12-23T17:11:04Z","updated_at":"2016-12-25T20:04:38Z","closed_at":"2016-12-23T17:58:22Z","pull_request":{"url":"https://api.github.com/repos/gmpl/FSharpPlus/pulls/27","html_url":"https://github.com/gmpl/FSharpPlus/pull/27","diff_url":"https://github.com/gmpl/FSharpPlus/pull/27.diff","patch_url":"https://github.com/gmpl/FSharpPlus/pull/27.patch"},"body":"Rebuild of project using [Project Scaffold](http://fsprojects.github.io/ProjectScaffold/)\r\n\r\n**Notes**\r\n\r\nI have left the `<OtherFlags>--warnon:1182</OtherFlags>` node in the fsproj file which results in a number of new warnings.\r\n\r\nBuilding the documentation results in a number of error messages seemingly related to tpetricek/FSharp.Formatting#364"},"comment":{"url":"https://api.github.com/repos/gmpl/FSharpPlus/issues/comments/269135620","html_url":"https://github.com/gmpl/FSharpPlus/pull/27#issuecomment-269135620","issue_url":"https://api.github.com/repos/gmpl/FSharpPlus/issues/27","id":269135620,"user":{"login":"gmpl","id":1261319,"avatar_url":"https://avatars.githubusercontent.com/u/1261319?v=3","gravatar_id":"","url":"https://api.github.com/users/gmpl","html_url":"https://github.com/gmpl","followers_url":"https://api.github.com/users/gmpl/followers","following_url":"https://api.github.com/users/gmpl/following{/other_user}","gists_url":"https://api.github.com/users/gmpl/gists{/gist_id}","starred_url":"https://api.github.com/users/gmpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmpl/subscriptions","organizations_url":"https://api.github.com/users/gmpl/orgs","repos_url":"https://api.github.com/users/gmpl/repos","events_url":"https://api.github.com/users/gmpl/events{/privacy}","received_events_url":"https://api.github.com/users/gmpl/received_events","type":"User","site_admin":false},"created_at":"2016-12-25T20:04:38Z","updated_at":"2016-12-25T20:04:38Z","body":"I think the integration of both projects is pretty much done.\r\nThe old samples from FsControl are now in a specific folder, but those more than sample files are rather like tests files, if something goes wrong they stop compiling. It would be interesting to make the build script to discover them and compile them but we can do that in another stage.\r\n\r\nSo now if you want to scaffold it you can submit another PR.\r\nI used ``git mv``all the time for the integration and github managed to track the file moves, [see this](https://github.com/gmpl/FSharpPlus/commit/1277304b94669cbb51829b454e56e555e5c36fa3).\r\n\r\nThe test project would have to be adapted to use NUnit, that's not very complicated but don't worry about it, I can do it afterwards.\r\n\r\nJust in case, note that the BaseLib is statically linked into the FSharpPlus dll.\r\n\r\nThanks for your valuable contribution."}}
{"actor":{"display_login":"gmpl"}}