{"action":"closed","number":16,"pull_request":{"url":"https://api.github.com/repos/ragingwind/devdogs/pulls/16","id":62647071,"html_url":"https://github.com/ragingwind/devdogs/pull/16","diff_url":"https://github.com/ragingwind/devdogs/pull/16.diff","patch_url":"https://github.com/ragingwind/devdogs/pull/16.patch","issue_url":"https://api.github.com/repos/ragingwind/devdogs/issues/16","number":16,"state":"closed","locked":false,"title":"Fixed app version for packaging in package.json","user":{"login":"de-luca","id":5390487,"avatar_url":"https://avatars.githubusercontent.com/u/5390487?v=3","gravatar_id":"","url":"https://api.github.com/users/de-luca","html_url":"https://github.com/de-luca","followers_url":"https://api.github.com/users/de-luca/followers","following_url":"https://api.github.com/users/de-luca/following{/other_user}","gists_url":"https://api.github.com/users/de-luca/gists{/gist_id}","starred_url":"https://api.github.com/users/de-luca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/de-luca/subscriptions","organizations_url":"https://api.github.com/users/de-luca/orgs","repos_url":"https://api.github.com/users/de-luca/repos","events_url":"https://api.github.com/users/de-luca/events{/privacy}","received_events_url":"https://api.github.com/users/de-luca/received_events","type":"User","site_admin":false},"body":"Using $npm_package_version in a config string can't resolve the version stated above and ended building the app without correct version.\r\n```xml\r\n<key>CFBundleShortVersionString</key>\r\n<string>$npm_package_version</string>\r\n<key>CFBundleVersion</key>\r\n<string>$npm_package_version</string>\r\n```\r\n\r\nBy moving it directly in the script it can be resolved and the app will have the correct version\r\n```xml\r\n<key>CFBundleShortVersionString</key>\r\n<string>0.1.11</string>\r\n<key>CFBundleVersion</key>\r\n<string>0.1.11</string>\r\n```","created_at":"2016-03-12T17:40:02Z","updated_at":"2016-03-13T22:46:00Z","closed_at":"2016-03-13T22:46:00Z","merged_at":"2016-03-13T22:46:00Z","merge_commit_sha":"d4029700cf172cab2e0b6265ebbd789c17df224c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ragingwind/devdogs/pulls/16/commits","review_comments_url":"https://api.github.com/repos/ragingwind/devdogs/pulls/16/comments","review_comment_url":"https://api.github.com/repos/ragingwind/devdogs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ragingwind/devdogs/issues/16/comments","statuses_url":"https://api.github.com/repos/ragingwind/devdogs/statuses/6db2b60d3f85f38b1c8db5e4f146914025f2f5f0","head":{"label":"de-luca:master","ref":"master","sha":"6db2b60d3f85f38b1c8db5e4f146914025f2f5f0","user":{"login":"de-luca","id":5390487,"avatar_url":"https://avatars.githubusercontent.com/u/5390487?v=3","gravatar_id":"","url":"https://api.github.com/users/de-luca","html_url":"https://github.com/de-luca","followers_url":"https://api.github.com/users/de-luca/followers","following_url":"https://api.github.com/users/de-luca/following{/other_user}","gists_url":"https://api.github.com/users/de-luca/gists{/gist_id}","starred_url":"https://api.github.com/users/de-luca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/de-luca/subscriptions","organizations_url":"https://api.github.com/users/de-luca/orgs","repos_url":"https://api.github.com/users/de-luca/repos","events_url":"https://api.github.com/users/de-luca/events{/privacy}","received_events_url":"https://api.github.com/users/de-luca/received_events","type":"User","site_admin":false},"repo":{"id":53744028,"name":"devdogs","full_name":"de-luca/devdogs","owner":{"login":"de-luca","id":5390487,"avatar_url":"https://avatars.githubusercontent.com/u/5390487?v=3","gravatar_id":"","url":"https://api.github.com/users/de-luca","html_url":"https://github.com/de-luca","followers_url":"https://api.github.com/users/de-luca/followers","following_url":"https://api.github.com/users/de-luca/following{/other_user}","gists_url":"https://api.github.com/users/de-luca/gists{/gist_id}","starred_url":"https://api.github.com/users/de-luca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/de-luca/subscriptions","organizations_url":"https://api.github.com/users/de-luca/orgs","repos_url":"https://api.github.com/users/de-luca/repos","events_url":"https://api.github.com/users/de-luca/events{/privacy}","received_events_url":"https://api.github.com/users/de-luca/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/de-luca/devdogs","description":"DevdoGs, Unofficial Devdocs app","fork":true,"url":"https://api.github.com/repos/de-luca/devdogs","forks_url":"https://api.github.com/repos/de-luca/devdogs/forks","keys_url":"https://api.github.com/repos/de-luca/devdogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/de-luca/devdogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/de-luca/devdogs/teams","hooks_url":"https://api.github.com/repos/de-luca/devdogs/hooks","issue_events_url":"https://api.github.com/repos/de-luca/devdogs/issues/events{/number}","events_url":"https://api.github.com/repos/de-luca/devdogs/events","assignees_url":"https://api.github.com/repos/de-luca/devdogs/assignees{/user}","branches_url":"https://api.github.com/repos/de-luca/devdogs/branches{/branch}","tags_url":"https://api.github.com/repos/de-luca/devdogs/tags","blobs_url":"https://api.github.com/repos/de-luca/devdogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/de-luca/devdogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/de-luca/devdogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/de-luca/devdogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/de-luca/devdogs/statuses/{sha}","languages_url":"https://api.github.com/repos/de-luca/devdogs/languages","stargazers_url":"https://api.github.com/repos/de-luca/devdogs/stargazers","contributors_url":"https://api.github.com/repos/de-luca/devdogs/contributors","subscribers_url":"https://api.github.com/repos/de-luca/devdogs/subscribers","subscription_url":"https://api.github.com/repos/de-luca/devdogs/subscription","commits_url":"https://api.github.com/repos/de-luca/devdogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/de-luca/devdogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/de-luca/devdogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/de-luca/devdogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/de-luca/devdogs/contents/{+path}","compare_url":"https://api.github.com/repos/de-luca/devdogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/de-luca/devdogs/merges","archive_url":"https://api.github.com/repos/de-luca/devdogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/de-luca/devdogs/downloads","issues_url":"https://api.github.com/repos/de-luca/devdogs/issues{/number}","pulls_url":"https://api.github.com/repos/de-luca/devdogs/pulls{/number}","milestones_url":"https://api.github.com/repos/de-luca/devdogs/milestones{/number}","notifications_url":"https://api.github.com/repos/de-luca/devdogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/de-luca/devdogs/labels{/name}","releases_url":"https://api.github.com/repos/de-luca/devdogs/releases{/id}","deployments_url":"https://api.github.com/repos/de-luca/devdogs/deployments","created_at":"2016-03-12T17:25:26Z","updated_at":"2016-03-12T17:25:27Z","pushed_at":"2016-03-12T17:36:16Z","git_url":"git://github.com/de-luca/devdogs.git","ssh_url":"git@github.com:de-luca/devdogs.git","clone_url":"https://github.com/de-luca/devdogs.git","svn_url":"https://github.com/de-luca/devdogs","homepage":"","size":217,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ragingwind:master","ref":"master","sha":"541a9b05a075bb551d734d79139c9c38f29fe525","user":{"login":"ragingwind","id":124117,"avatar_url":"https://avatars.githubusercontent.com/u/124117?v=3","gravatar_id":"","url":"https://api.github.com/users/ragingwind","html_url":"https://github.com/ragingwind","followers_url":"https://api.github.com/users/ragingwind/followers","following_url":"https://api.github.com/users/ragingwind/following{/other_user}","gists_url":"https://api.github.com/users/ragingwind/gists{/gist_id}","starred_url":"https://api.github.com/users/ragingwind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ragingwind/subscriptions","organizations_url":"https://api.github.com/users/ragingwind/orgs","repos_url":"https://api.github.com/users/ragingwind/repos","events_url":"https://api.github.com/users/ragingwind/events{/privacy}","received_events_url":"https://api.github.com/users/ragingwind/received_events","type":"User","site_admin":false},"repo":{"id":38926606,"name":"devdogs","full_name":"ragingwind/devdogs","owner":{"login":"ragingwind","id":124117,"avatar_url":"https://avatars.githubusercontent.com/u/124117?v=3","gravatar_id":"","url":"https://api.github.com/users/ragingwind","html_url":"https://github.com/ragingwind","followers_url":"https://api.github.com/users/ragingwind/followers","following_url":"https://api.github.com/users/ragingwind/following{/other_user}","gists_url":"https://api.github.com/users/ragingwind/gists{/gist_id}","starred_url":"https://api.github.com/users/ragingwind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ragingwind/subscriptions","organizations_url":"https://api.github.com/users/ragingwind/orgs","repos_url":"https://api.github.com/users/ragingwind/repos","events_url":"https://api.github.com/users/ragingwind/events{/privacy}","received_events_url":"https://api.github.com/users/ragingwind/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ragingwind/devdogs","description":"DevdoGs, Unofficial Devdocs app","fork":false,"url":"https://api.github.com/repos/ragingwind/devdogs","forks_url":"https://api.github.com/repos/ragingwind/devdogs/forks","keys_url":"https://api.github.com/repos/ragingwind/devdogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ragingwind/devdogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ragingwind/devdogs/teams","hooks_url":"https://api.github.com/repos/ragingwind/devdogs/hooks","issue_events_url":"https://api.github.com/repos/ragingwind/devdogs/issues/events{/number}","events_url":"https://api.github.com/repos/ragingwind/devdogs/events","assignees_url":"https://api.github.com/repos/ragingwind/devdogs/assignees{/user}","branches_url":"https://api.github.com/repos/ragingwind/devdogs/branches{/branch}","tags_url":"https://api.github.com/repos/ragingwind/devdogs/tags","blobs_url":"https://api.github.com/repos/ragingwind/devdogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ragingwind/devdogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ragingwind/devdogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ragingwind/devdogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ragingwind/devdogs/statuses/{sha}","languages_url":"https://api.github.com/repos/ragingwind/devdogs/languages","stargazers_url":"https://api.github.com/repos/ragingwind/devdogs/stargazers","contributors_url":"https://api.github.com/repos/ragingwind/devdogs/contributors","subscribers_url":"https://api.github.com/repos/ragingwind/devdogs/subscribers","subscription_url":"https://api.github.com/repos/ragingwind/devdogs/subscription","commits_url":"https://api.github.com/repos/ragingwind/devdogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ragingwind/devdogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ragingwind/devdogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ragingwind/devdogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ragingwind/devdogs/contents/{+path}","compare_url":"https://api.github.com/repos/ragingwind/devdogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ragingwind/devdogs/merges","archive_url":"https://api.github.com/repos/ragingwind/devdogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ragingwind/devdogs/downloads","issues_url":"https://api.github.com/repos/ragingwind/devdogs/issues{/number}","pulls_url":"https://api.github.com/repos/ragingwind/devdogs/pulls{/number}","milestones_url":"https://api.github.com/repos/ragingwind/devdogs/milestones{/number}","notifications_url":"https://api.github.com/repos/ragingwind/devdogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ragingwind/devdogs/labels{/name}","releases_url":"https://api.github.com/repos/ragingwind/devdogs/releases{/id}","deployments_url":"https://api.github.com/repos/ragingwind/devdogs/deployments","created_at":"2015-07-11T13:28:46Z","updated_at":"2016-03-11T13:52:16Z","pushed_at":"2016-03-13T22:46:00Z","git_url":"git://github.com/ragingwind/devdogs.git","ssh_url":"git@github.com:ragingwind/devdogs.git","clone_url":"https://github.com/ragingwind/devdogs.git","svn_url":"https://github.com/ragingwind/devdogs","homepage":"","size":230,"stargazers_count":106,"watchers_count":106,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":3,"forks":10,"open_issues":3,"watchers":106,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ragingwind/devdogs/pulls/16"},"html":{"href":"https://github.com/ragingwind/devdogs/pull/16"},"issue":{"href":"https://api.github.com/repos/ragingwind/devdogs/issues/16"},"comments":{"href":"https://api.github.com/repos/ragingwind/devdogs/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/ragingwind/devdogs/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/ragingwind/devdogs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ragingwind/devdogs/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/ragingwind/devdogs/statuses/6db2b60d3f85f38b1c8db5e4f146914025f2f5f0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ragingwind","id":124117,"avatar_url":"https://avatars.githubusercontent.com/u/124117?v=3","gravatar_id":"","url":"https://api.github.com/users/ragingwind","html_url":"https://github.com/ragingwind","followers_url":"https://api.github.com/users/ragingwind/followers","following_url":"https://api.github.com/users/ragingwind/following{/other_user}","gists_url":"https://api.github.com/users/ragingwind/gists{/gist_id}","starred_url":"https://api.github.com/users/ragingwind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ragingwind/subscriptions","organizations_url":"https://api.github.com/users/ragingwind/orgs","repos_url":"https://api.github.com/users/ragingwind/repos","events_url":"https://api.github.com/users/ragingwind/events{/privacy}","received_events_url":"https://api.github.com/users/ragingwind/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}