{"push_id":1281666357,"size":11,"distinct_size":11,"ref":"refs/heads/develop","head":"54f8afb566d45429542c5e1edfe8f33709ca0ff1","before":"c762f9f8c4cca81c5d56993a76db04958b273e14","commits":[{"sha":"0cc1eb4d779d6219c2c27087c5d311489107ac87","author":{"name":"Antoine Tollenaere","email":"d0d320b48be126da8978969c773c49f21b13a31f@twitter.com"},"message":"finagle-core: move InetResolver into its own file\n\nProblem\n--\n\n`InetResolver` is implemented in Resolver.scala. It makes it difficult\nto find and read.\n\nSolution\n--\n\nMove InetResolver into the InetResolver.scala\n\nRB_ID=867171","distinct":true,"url":"https://api.github.com/repos/twitter/finagle/commits/0cc1eb4d779d6219c2c27087c5d311489107ac87"},{"sha":"813caf312b6f3bcabd37069ad388a3ca017da09d","author":{"name":"Bryce Anderson","email":"8c3473ac7364c5ba1a6fb9c24a1c89be7f35042e@twitter.com"},"message":"finagle-mux: Increase verbosity of mux decoding error message\n\nProblem\n\nThe error message returned by the mux Message.decode function could be\nmore useful by including more information about the remaining message.\n\nSolution\n\nInclude information about the payload size and print the first 16 bytes\nof the payload in the exception message.\n\nRB_ID=867156","distinct":true,"url":"https://api.github.com/repos/twitter/finagle/commits/813caf312b6f3bcabd37069ad388a3ca017da09d"},{"sha":"91979e89eb16924ee3010384a1e8cd8ae442c5dd","author":{"name":"Ken Kawamoto","email":"c08767b4e5daea667ed6572d7987e4493193080f@twitter.com"},"message":"finagle-stats: fix CommonsStats formatter to convert gc related stats correctly\n\nRB_ID=866422","distinct":true,"url":"https://api.github.com/repos/twitter/finagle/commits/91979e89eb16924ee3010384a1e8cd8ae442c5dd"},{"sha":"a8db4b3d10b250000e06a4f921a94d7d360bcf10","author":{"name":"Moses Nakamura","email":"027e942e2a8d9c3b29816dfa40893330d419351a@twitter.com"},"message":"finagle-http: Make StreamingTest generic and provide a netty4 implementation\n\nProblem\n\nWe have nice end to end streaming tests, but they're only for netty3\nfor now.\n\nSolution\n\nMake them abstract so that they can be used with other implementations.\n\nResult\n\nWe now have a solid streaming test suite for netty4 http, which\nhelps us be more confident in our netty4 http implementation.  Once\nwe add support for using http2 without the handshake works, we'll\nbe able to use the abstract test suite for that too.\n\nRB_ID=867121","distinct":true,"url":"https://api.github.com/repos/twitter/finagle/commits/a8db4b3d10b250000e06a4f921a94d7d360bcf10"},{"sha":"9b3ae5ce84ab248a483a89af875247119efa1ef7","author":{"name":"Kevin Oliver","email":"42f0c465f9d28c5edb4e65e73bb0815be7cdcaf5@twitter.com"},"message":"finagle-toggle: Add optional source to ToggleMap.newMutable\n\nProblem / Solution\n\nThere are times when the `toString` output of `ToggleMap.newMutable`\nis not as informative as you'd like. This change introduces an\noptional String field that allows it to be customized.\n\nRB_ID=867107","distinct":true,"url":"https://api.github.com/repos/twitter/finagle/commits/9b3ae5ce84ab248a483a89af875247119efa1ef7"},{"sha":"be405415caeb29c7bc0dbb4ebcb1e62c83ab4bcd","author":{"name":"Jillian Crossley","email":"fd125a3f42048646810c0f929f29edd9f84d7bfe@twitter.com"},"message":"finagle/finagle-thriftmux: Remove gauges in ThriftEmulator\n\nProblem\n\nWe create gauges per-connection in ThriftEmulator\non the hotpath. Gauge creation can be slow if gauge cleanup\nis happening on another thread, which stalls the connection.\n\nSolution\n\nRemove the gauges in ThriftEmulator, because it already contains\ncounters for the same stats. If, later, we decide that these gauges\nare useful, they will need to be moved to the ListeningServer and\nreferences passed into ThriftEmulator. This way, the gauges are tied\nto the lifecycle of the ListeningServer, and not created per-connection\nin ThriftEmulator.\n\nRB_ID=867459","distinct":true,"url":"https://api.github.com/repos/twitter/finagle/commits/be405415caeb29c7bc0dbb4ebcb1e62c83ab4bcd"},{"sha":"6df34c39548bf43e0849aa8a6dffc8339dd803e0","author":{"name":"Ruben Oanta","email":"c94276d708b9dc19eede0c00f129c2a4f2e440a2@twitter.com"},"message":"finagle-netty4: Fix I/O thread leak\n\nProblem\n\nrb/865672 introduced a bug by scaling the number of I/O workers\nwith clients and servers. Each `NioEventLoopGroup` will create\na fixed amount of threads and we create one instance per client\nand server.\n\nSolution\n\nChange the `WorkerPool` param to create the `EventLoopGroup`. This\nleaks netty4 types, but it's in the finagle-netty4 package so it\nseems legitimate.\n\nRB_ID=867862","distinct":true,"url":"https://api.github.com/repos/twitter/finagle/commits/6df34c39548bf43e0849aa8a6dffc8339dd803e0"},{"sha":"cdcd946ab7c26387be1b79b0a1f1c4d9abfa1ad2","author":{"name":"Daniel Schobel","email":"67662df2ffee7debcd16f68b05f1a09e938277a6@twitter.com"},"message":"finagle-mux: more dissector fixes + add missing field to mux spec for tdiscard\n\nProblem(s)\n\n1. Marker messages (tlease and tdiscard) aren't dissected because\n   the plugin sets a minimum tag of 1 while marker messages have tag 0.\n2. Tdiscard's `why` field is ignored.\n3. The old (but used) encoding type of tdiscard is missing.\n4. The mux spec's description of tdiscard omits the encoding of the\n   tag to be discarded.\n\nSolution(s)\n\nFixes for 1-4 should be self-explanatory. This patch also introduces\na special case in the dissector for the magic `can tinit` packet\nso that it doesn't appear as a normal RErr message in traces.\n\nRB_ID=865991","distinct":true,"url":"https://api.github.com/repos/twitter/finagle/commits/cdcd946ab7c26387be1b79b0a1f1c4d9abfa1ad2"},{"sha":"60ce332ea71f384deae4e053dfd85e62332249ed","author":{"name":"Daniel Schobel","email":"67662df2ffee7debcd16f68b05f1a09e938277a6@twitter.com"},"message":"finagle/*, util/*, csl/* - replace c.t.io.Charset usage with java StandardCharsets\n\nProblem / Solution\n\ns/c.t.io.Charset/java.nio.charset.StandardCharsets/ to remove deprecation warnings.\n\nRB_ID=867497","distinct":true,"url":"https://api.github.com/repos/twitter/finagle/commits/60ce332ea71f384deae4e053dfd85e62332249ed"},{"sha":"c729ef456a6a8c34a2962e4eccce1f2ab9230452","author":{"name":"Jordan Parker","email":"ff25df415f3e1b9e54a0e157328f2de52c16a688@twitter.com"},"message":"finagle-http: Expand HttpNackFilter to also handle non-retryable nacks\n\nProblem\n\nAll Nacks are treated as Restartable from finagle-http's point of view, but it\nis sometimes desirable to signal that a Nack should not be retried.\n\nSolution\n\nExpand HttpNackFilter to handle non-retryable Nacks\n\nResult\n\nThe \"finagle-http-nonretryable-nack\" header is used to transmit this information\nover HTTP. Clients and servers now support & handle this header.\n\nRB_ID=865468","distinct":true,"url":"https://api.github.com/repos/twitter/finagle/commits/c729ef456a6a8c34a2962e4eccce1f2ab9230452"},{"sha":"54f8afb566d45429542c5e1edfe8f33709ca0ff1","author":{"name":"Christopher Coco","email":"73f81dcde656bf14f3aba707425184e601614d53@twitter.com"},"message":"twitter-oss: Use sbt 0.13.9 and update Travis CI configuration\n\nProblem\n\nSome of our oss libraries say they use sbt 0.13.9 in the\nproject/build.properties but still download the sbt-launch for\n0.13.8 in their respective sbt scripts. Additionally we'd like\nto disable sbt colorized output and reduce logging verbosity\nin our TravisCI builds.\n\nSolution\n\nUpdate the necessary sbt scripts to specify an sbt version of\n0.13.9.\n\nMake the necessary changes to the .travis.yml files.\n\nResult\n\nLess logging and easier to read logs in TravisCI. Actual use\nof the specified sbt version.\n\nRB_ID=868087\nTBR=true","distinct":true,"url":"https://api.github.com/repos/twitter/finagle/commits/54f8afb566d45429542c5e1edfe8f33709ca0ff1"}]}
{"actor":{"display_login":"finaglehelper"}}