{"action":"created","issue":{"url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/issues/746","repository_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2","labels_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/issues/746/labels{/name}","comments_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/issues/746/comments","events_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/issues/746/events","html_url":"https://github.com/nus-cs2103-AY1617S1/addressbook-level2/pull/746","id":174905294,"number":746,"title":"[T4A7][W10-B4]Wang Xien Dong","user":{"login":"xdrawks","id":11458867,"avatar_url":"https://avatars.githubusercontent.com/u/11458867?v=3","gravatar_id":"","url":"https://api.github.com/users/xdrawks","html_url":"https://github.com/xdrawks","followers_url":"https://api.github.com/users/xdrawks/followers","following_url":"https://api.github.com/users/xdrawks/following{/other_user}","gists_url":"https://api.github.com/users/xdrawks/gists{/gist_id}","starred_url":"https://api.github.com/users/xdrawks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xdrawks/subscriptions","organizations_url":"https://api.github.com/users/xdrawks/orgs","repos_url":"https://api.github.com/users/xdrawks/repos","events_url":"https://api.github.com/users/xdrawks/events{/privacy}","received_events_url":"https://api.github.com/users/xdrawks/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"damithc","id":1673303,"avatar_url":"https://avatars.githubusercontent.com/u/1673303?v=3","gravatar_id":"","url":"https://api.github.com/users/damithc","html_url":"https://github.com/damithc","followers_url":"https://api.github.com/users/damithc/followers","following_url":"https://api.github.com/users/damithc/following{/other_user}","gists_url":"https://api.github.com/users/damithc/gists{/gist_id}","starred_url":"https://api.github.com/users/damithc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damithc/subscriptions","organizations_url":"https://api.github.com/users/damithc/orgs","repos_url":"https://api.github.com/users/damithc/repos","events_url":"https://api.github.com/users/damithc/events{/privacy}","received_events_url":"https://api.github.com/users/damithc/received_events","type":"User","site_admin":false},"assignees":[{"login":"damithc","id":1673303,"avatar_url":"https://avatars.githubusercontent.com/u/1673303?v=3","gravatar_id":"","url":"https://api.github.com/users/damithc","html_url":"https://github.com/damithc","followers_url":"https://api.github.com/users/damithc/followers","following_url":"https://api.github.com/users/damithc/following{/other_user}","gists_url":"https://api.github.com/users/damithc/gists{/gist_id}","starred_url":"https://api.github.com/users/damithc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damithc/subscriptions","organizations_url":"https://api.github.com/users/damithc/orgs","repos_url":"https://api.github.com/users/damithc/repos","events_url":"https://api.github.com/users/damithc/events{/privacy}","received_events_url":"https://api.github.com/users/damithc/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-09-03T16:48:38Z","updated_at":"2016-09-10T11:41:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/pulls/746","html_url":"https://github.com/nus-cs2103-AY1617S1/addressbook-level2/pull/746","diff_url":"https://github.com/nus-cs2103-AY1617S1/addressbook-level2/pull/746.diff","patch_url":"https://github.com/nus-cs2103-AY1617S1/addressbook-level2/pull/746.patch"},"body":"Ready to commit"},"comment":{"url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/issues/comments/246107314","html_url":"https://github.com/nus-cs2103-AY1617S1/addressbook-level2/pull/746#issuecomment-246107314","issue_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/issues/746","id":246107314,"user":{"login":"damithc","id":1673303,"avatar_url":"https://avatars.githubusercontent.com/u/1673303?v=3","gravatar_id":"","url":"https://api.github.com/users/damithc","html_url":"https://github.com/damithc","followers_url":"https://api.github.com/users/damithc/followers","following_url":"https://api.github.com/users/damithc/following{/other_user}","gists_url":"https://api.github.com/users/damithc/gists{/gist_id}","starred_url":"https://api.github.com/users/damithc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damithc/subscriptions","organizations_url":"https://api.github.com/users/damithc/orgs","repos_url":"https://api.github.com/users/damithc/repos","events_url":"https://api.github.com/users/damithc/events{/privacy}","received_events_url":"https://api.github.com/users/damithc/received_events","type":"User","site_admin":false},"created_at":"2016-09-10T11:41:57Z","updated_at":"2016-09-10T11:41:57Z","body":"Good try, but you are a bit off from TDD. For example, a TDD session starts by adding a failing test, not by adding an empty method. Also, you TDD adds bit of test code and bit of functional code in tandem (you were supposed to commit after each step), not all add tests first. Please take a look at the course handouts and suggested readings given in the assignment description to get a good understanding of TDD.\r\nThe convention is to name the test class based on the class being tested. e.g. `PersonTest`\r\nPlease close the PR after reading comments."}}
{"actor":{"display_login":"damithc"}}