{"action":"created","comment":{"url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/pulls/comments/71718133","id":71718133,"diff_hunk":"@@ -890,6 +891,79 @@ public void filterByUnknownReferenceIdIsUnsuccessful() throws Exception {\n                 .andExpect(totalNumOfResults(0));\n     }\n \n+\n+    //----- Tests for GeneProductType ---------------------//\n+\n+    @Test\n+    public void filterByGeneProductTypeReturnsMatchingDocuments() throws Exception {\n+\n+        ResultActions response = mockMvc.perform(get(RESOURCE_URL + \"/search\").param(GENE_PRODUCT_TYPE_PARAM,\n+                \"protein\"));\n+\n+        //Gene Product type is indexed but not stored, so it will not be returned as part of annotation","path":"annotation-rest/src/test/java/uk/ac/ebi/quickgo/annotation/controller/AnnotationControllerIT.java","position":24,"original_position":24,"commit_id":"b4a5679abdf6ef98829cfd63879357a3bedbe25b","original_commit_id":"b4a5679abdf6ef98829cfd63879357a3bedbe25b","user":{"login":"rantunesboreas","id":15346245,"avatar_url":"https://avatars.githubusercontent.com/u/15346245?v=3","gravatar_id":"","url":"https://api.github.com/users/rantunesboreas","html_url":"https://github.com/rantunesboreas","followers_url":"https://api.github.com/users/rantunesboreas/followers","following_url":"https://api.github.com/users/rantunesboreas/following{/other_user}","gists_url":"https://api.github.com/users/rantunesboreas/gists{/gist_id}","starred_url":"https://api.github.com/users/rantunesboreas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rantunesboreas/subscriptions","organizations_url":"https://api.github.com/users/rantunesboreas/orgs","repos_url":"https://api.github.com/users/rantunesboreas/repos","events_url":"https://api.github.com/users/rantunesboreas/events{/privacy}","received_events_url":"https://api.github.com/users/rantunesboreas/received_events","type":"User","site_admin":false},"body":"This comment is unnecessary, it does not help explain something within the test itself.","created_at":"2016-07-21T14:40:43Z","updated_at":"2016-07-21T14:40:43Z","html_url":"https://github.com/ebi-uniprot/QuickGOBE/pull/29#discussion_r71718133","pull_request_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/pulls/29","_links":{"self":{"href":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/pulls/comments/71718133"},"html":{"href":"https://github.com/ebi-uniprot/QuickGOBE/pull/29#discussion_r71718133"},"pull_request":{"href":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/pulls/29","id":77637488,"html_url":"https://github.com/ebi-uniprot/QuickGOBE/pull/29","diff_url":"https://github.com/ebi-uniprot/QuickGOBE/pull/29.diff","patch_url":"https://github.com/ebi-uniprot/QuickGOBE/pull/29.patch","issue_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/issues/29","number":29,"state":"open","locked":false,"title":"Goa 1997 filter annotation by gene product type","user":{"login":"TonyWardell","id":8235630,"avatar_url":"https://avatars.githubusercontent.com/u/8235630?v=3","gravatar_id":"","url":"https://api.github.com/users/TonyWardell","html_url":"https://github.com/TonyWardell","followers_url":"https://api.github.com/users/TonyWardell/followers","following_url":"https://api.github.com/users/TonyWardell/following{/other_user}","gists_url":"https://api.github.com/users/TonyWardell/gists{/gist_id}","starred_url":"https://api.github.com/users/TonyWardell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TonyWardell/subscriptions","organizations_url":"https://api.github.com/users/TonyWardell/orgs","repos_url":"https://api.github.com/users/TonyWardell/repos","events_url":"https://api.github.com/users/TonyWardell/events{/privacy}","received_events_url":"https://api.github.com/users/TonyWardell/received_events","type":"User","site_admin":false},"body":"As a QuickGO user\r\nI would like to be able to filter annotations using a specific group to which a set of gene products belong to\r\nSo that I can see annotations that are associated to that/those particular gene product(s)\r\nAcceptance criteria:\r\nIf the gene product subset does not match any of the ids on the annotation list, then the result should be empty\r\nIf the subset matches at least one of the subsets of a gene product in the list of annotations, then the result should only show the affected annotations\r\nThe user can input more than one subset, when this is the case then the ids should be ORed.\r\nThis filter criteria can be used in conjunction with other non-related filter criteria\r\nThe filter should be case-insensitive","created_at":"2016-07-15T15:52:35Z","updated_at":"2016-07-21T14:40:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"888c7da95a65f16f6db1955c5903a44892a82dea","assignee":{"login":"rantunesboreas","id":15346245,"avatar_url":"https://avatars.githubusercontent.com/u/15346245?v=3","gravatar_id":"","url":"https://api.github.com/users/rantunesboreas","html_url":"https://github.com/rantunesboreas","followers_url":"https://api.github.com/users/rantunesboreas/followers","following_url":"https://api.github.com/users/rantunesboreas/following{/other_user}","gists_url":"https://api.github.com/users/rantunesboreas/gists{/gist_id}","starred_url":"https://api.github.com/users/rantunesboreas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rantunesboreas/subscriptions","organizations_url":"https://api.github.com/users/rantunesboreas/orgs","repos_url":"https://api.github.com/users/rantunesboreas/repos","events_url":"https://api.github.com/users/rantunesboreas/events{/privacy}","received_events_url":"https://api.github.com/users/rantunesboreas/received_events","type":"User","site_admin":false},"assignees":[{"login":"rantunesboreas","id":15346245,"avatar_url":"https://avatars.githubusercontent.com/u/15346245?v=3","gravatar_id":"","url":"https://api.github.com/users/rantunesboreas","html_url":"https://github.com/rantunesboreas","followers_url":"https://api.github.com/users/rantunesboreas/followers","following_url":"https://api.github.com/users/rantunesboreas/following{/other_user}","gists_url":"https://api.github.com/users/rantunesboreas/gists{/gist_id}","starred_url":"https://api.github.com/users/rantunesboreas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rantunesboreas/subscriptions","organizations_url":"https://api.github.com/users/rantunesboreas/orgs","repos_url":"https://api.github.com/users/rantunesboreas/repos","events_url":"https://api.github.com/users/rantunesboreas/events{/privacy}","received_events_url":"https://api.github.com/users/rantunesboreas/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/pulls/29/commits","review_comments_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/pulls/29/comments","review_comment_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/issues/29/comments","statuses_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/statuses/b4a5679abdf6ef98829cfd63879357a3bedbe25b","head":{"label":"ebi-uniprot:GOA-1997-Filter-Annotation-By-Gene-Product-Type","ref":"GOA-1997-Filter-Annotation-By-Gene-Product-Type","sha":"b4a5679abdf6ef98829cfd63879357a3bedbe25b","user":{"login":"ebi-uniprot","id":9991058,"avatar_url":"https://avatars.githubusercontent.com/u/9991058?v=3","gravatar_id":"","url":"https://api.github.com/users/ebi-uniprot","html_url":"https://github.com/ebi-uniprot","followers_url":"https://api.github.com/users/ebi-uniprot/followers","following_url":"https://api.github.com/users/ebi-uniprot/following{/other_user}","gists_url":"https://api.github.com/users/ebi-uniprot/gists{/gist_id}","starred_url":"https://api.github.com/users/ebi-uniprot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebi-uniprot/subscriptions","organizations_url":"https://api.github.com/users/ebi-uniprot/orgs","repos_url":"https://api.github.com/users/ebi-uniprot/repos","events_url":"https://api.github.com/users/ebi-uniprot/events{/privacy}","received_events_url":"https://api.github.com/users/ebi-uniprot/received_events","type":"Organization","site_admin":false},"repo":{"id":55400531,"name":"QuickGOBE","full_name":"ebi-uniprot/QuickGOBE","owner":{"login":"ebi-uniprot","id":9991058,"avatar_url":"https://avatars.githubusercontent.com/u/9991058?v=3","gravatar_id":"","url":"https://api.github.com/users/ebi-uniprot","html_url":"https://github.com/ebi-uniprot","followers_url":"https://api.github.com/users/ebi-uniprot/followers","following_url":"https://api.github.com/users/ebi-uniprot/following{/other_user}","gists_url":"https://api.github.com/users/ebi-uniprot/gists{/gist_id}","starred_url":"https://api.github.com/users/ebi-uniprot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebi-uniprot/subscriptions","organizations_url":"https://api.github.com/users/ebi-uniprot/orgs","repos_url":"https://api.github.com/users/ebi-uniprot/repos","events_url":"https://api.github.com/users/ebi-uniprot/events{/privacy}","received_events_url":"https://api.github.com/users/ebi-uniprot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ebi-uniprot/QuickGOBE","description":"Repository containing the back-end logic for QuickGO","fork":false,"url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE","forks_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/forks","keys_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/teams","hooks_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/hooks","issue_events_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/issues/events{/number}","events_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/events","assignees_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/assignees{/user}","branches_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/branches{/branch}","tags_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/tags","blobs_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/git/refs{/sha}","trees_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/statuses/{sha}","languages_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/languages","stargazers_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/stargazers","contributors_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/contributors","subscribers_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/subscribers","subscription_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/subscription","commits_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/commits{/sha}","git_commits_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/git/commits{/sha}","comments_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/comments{/number}","issue_comment_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/issues/comments{/number}","contents_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/contents/{+path}","compare_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/merges","archive_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/downloads","issues_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/issues{/number}","pulls_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/pulls{/number}","milestones_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/milestones{/number}","notifications_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/labels{/name}","releases_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/releases{/id}","deployments_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/deployments","created_at":"2016-04-04T09:51:06Z","updated_at":"2016-04-15T17:33:42Z","pushed_at":"2016-07-21T11:16:48Z","git_url":"git://github.com/ebi-uniprot/QuickGOBE.git","ssh_url":"git@github.com:ebi-uniprot/QuickGOBE.git","clone_url":"https://github.com/ebi-uniprot/QuickGOBE.git","svn_url":"https://github.com/ebi-uniprot/QuickGOBE","homepage":null,"size":8668,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"ebi-uniprot:master","ref":"master","sha":"797bd47011e144d2d7229344912cc39a8315b361","user":{"login":"ebi-uniprot","id":9991058,"avatar_url":"https://avatars.githubusercontent.com/u/9991058?v=3","gravatar_id":"","url":"https://api.github.com/users/ebi-uniprot","html_url":"https://github.com/ebi-uniprot","followers_url":"https://api.github.com/users/ebi-uniprot/followers","following_url":"https://api.github.com/users/ebi-uniprot/following{/other_user}","gists_url":"https://api.github.com/users/ebi-uniprot/gists{/gist_id}","starred_url":"https://api.github.com/users/ebi-uniprot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebi-uniprot/subscriptions","organizations_url":"https://api.github.com/users/ebi-uniprot/orgs","repos_url":"https://api.github.com/users/ebi-uniprot/repos","events_url":"https://api.github.com/users/ebi-uniprot/events{/privacy}","received_events_url":"https://api.github.com/users/ebi-uniprot/received_events","type":"Organization","site_admin":false},"repo":{"id":55400531,"name":"QuickGOBE","full_name":"ebi-uniprot/QuickGOBE","owner":{"login":"ebi-uniprot","id":9991058,"avatar_url":"https://avatars.githubusercontent.com/u/9991058?v=3","gravatar_id":"","url":"https://api.github.com/users/ebi-uniprot","html_url":"https://github.com/ebi-uniprot","followers_url":"https://api.github.com/users/ebi-uniprot/followers","following_url":"https://api.github.com/users/ebi-uniprot/following{/other_user}","gists_url":"https://api.github.com/users/ebi-uniprot/gists{/gist_id}","starred_url":"https://api.github.com/users/ebi-uniprot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebi-uniprot/subscriptions","organizations_url":"https://api.github.com/users/ebi-uniprot/orgs","repos_url":"https://api.github.com/users/ebi-uniprot/repos","events_url":"https://api.github.com/users/ebi-uniprot/events{/privacy}","received_events_url":"https://api.github.com/users/ebi-uniprot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ebi-uniprot/QuickGOBE","description":"Repository containing the back-end logic for QuickGO","fork":false,"url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE","forks_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/forks","keys_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/teams","hooks_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/hooks","issue_events_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/issues/events{/number}","events_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/events","assignees_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/assignees{/user}","branches_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/branches{/branch}","tags_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/tags","blobs_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/git/refs{/sha}","trees_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/statuses/{sha}","languages_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/languages","stargazers_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/stargazers","contributors_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/contributors","subscribers_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/subscribers","subscription_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/subscription","commits_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/commits{/sha}","git_commits_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/git/commits{/sha}","comments_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/comments{/number}","issue_comment_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/issues/comments{/number}","contents_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/contents/{+path}","compare_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/merges","archive_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/downloads","issues_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/issues{/number}","pulls_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/pulls{/number}","milestones_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/milestones{/number}","notifications_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/labels{/name}","releases_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/releases{/id}","deployments_url":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/deployments","created_at":"2016-04-04T09:51:06Z","updated_at":"2016-04-15T17:33:42Z","pushed_at":"2016-07-21T11:16:48Z","git_url":"git://github.com/ebi-uniprot/QuickGOBE.git","ssh_url":"git@github.com:ebi-uniprot/QuickGOBE.git","clone_url":"https://github.com/ebi-uniprot/QuickGOBE.git","svn_url":"https://github.com/ebi-uniprot/QuickGOBE","homepage":null,"size":8668,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/pulls/29"},"html":{"href":"https://github.com/ebi-uniprot/QuickGOBE/pull/29"},"issue":{"href":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/issues/29"},"comments":{"href":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/ebi-uniprot/QuickGOBE/statuses/b4a5679abdf6ef98829cfd63879357a3bedbe25b"}}}}
{"actor":{"display_login":"rantunesboreas"}}