{"action":"created","comment":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/73945250","id":73945250,"diff_hunk":"@@ -397,16 +407,17 @@ WantedBy=default.target\n         m.execute(\"systemctl start hourly_timer.timer\")\n         b.wait_present(svc_sel('hourly_timer.timer'))\n         b.wait_in_text(svc_sel('hourly_timer.timer'), \"Hourly timer\")\n+        wait_systemctl_timer(\"Fri 2020-04-10 03:05\")\n         self.assertIn(\"Fri 2020-04-10 03:05\", m.execute(\"LC_ALL=C systemctl list-timers\"))\n         m.execute(\"timedatectl set-time '2020-04-10 03:07:00'\")\n-        b.wait_present(svc_sel('hourly_timer.timer'))\n+        wait_systemctl_timer(\"Fri 2020-04-10 03:26\")\n         self.assertIn(\"Fri 2020-04-10 03:26\", m.execute(\"LC_ALL=C systemctl list-timers\"))\n         m.execute(\"timedatectl set-time '2020-04-10 04:00:00'\")\n-        b.wait_present(svc_sel('hourly_timer.timer'))\n+        wait_systemctl_timer(\"Fri 2020-04-10 04:05\")\n         # checks if timer runs on next hour at 5 min and 26 min\n         self.assertIn(\"Fri 2020-04-10 04:05\", m.execute(\"LC_ALL=C systemctl list-timers\"))\n         m.execute(\"timedatectl set-time '2020-04-10 04:10:00'\")\n-        b.wait_present(svc_sel('hourly_timer.timer'))\n+        wait_systemctl_timer(\"Fri 2020-04-10 04:26\")","path":"test/verify/check-services","position":null,"original_position":116,"commit_id":"2093964ddc91abfc44d3b45a22e98c3147465f8f","original_commit_id":"2093964ddc91abfc44d3b45a22e98c3147465f8f","user":{"login":"harishanand95","id":7456909,"avatar_url":"https://avatars.githubusercontent.com/u/7456909?v=3","gravatar_id":"","url":"https://api.github.com/users/harishanand95","html_url":"https://github.com/harishanand95","followers_url":"https://api.github.com/users/harishanand95/followers","following_url":"https://api.github.com/users/harishanand95/following{/other_user}","gists_url":"https://api.github.com/users/harishanand95/gists{/gist_id}","starred_url":"https://api.github.com/users/harishanand95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harishanand95/subscriptions","organizations_url":"https://api.github.com/users/harishanand95/orgs","repos_url":"https://api.github.com/users/harishanand95/repos","events_url":"https://api.github.com/users/harishanand95/events{/privacy}","received_events_url":"https://api.github.com/users/harishanand95/received_events","type":"User","site_admin":false},"body":"_b.wait_present(svc_sel('hourly_timer.timer'))_ was removed because I thought they would solve the race issue here. Since they didn't, I'm removing all such checks we had.\r\n\r\nReason why _b.wait_present(svc_sel('hourly_timer.timer'))_ could solve race was based on the idea that cockpit timer page refreshes after changing time using timedatectl. ","created_at":"2016-08-08T20:13:24Z","updated_at":"2016-08-08T20:13:24Z","html_url":"https://github.com/cockpit-project/cockpit/pull/4645#discussion_r73945250","pull_request_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/4645","_links":{"self":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/73945250"},"html":{"href":"https://github.com/cockpit-project/cockpit/pull/4645#discussion_r73945250"},"pull_request":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/4645"}}},"pull_request":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/4645","id":75428936,"html_url":"https://github.com/cockpit-project/cockpit/pull/4645","diff_url":"https://github.com/cockpit-project/cockpit/pull/4645.diff","patch_url":"https://github.com/cockpit-project/cockpit/pull/4645.patch","issue_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/4645","number":4645,"state":"open","locked":false,"title":"WIP systemd create timer option","user":{"login":"harishanand95","id":7456909,"avatar_url":"https://avatars.githubusercontent.com/u/7456909?v=3","gravatar_id":"","url":"https://api.github.com/users/harishanand95","html_url":"https://github.com/harishanand95","followers_url":"https://api.github.com/users/harishanand95/followers","following_url":"https://api.github.com/users/harishanand95/following{/other_user}","gists_url":"https://api.github.com/users/harishanand95/gists{/gist_id}","starred_url":"https://api.github.com/users/harishanand95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harishanand95/subscriptions","organizations_url":"https://api.github.com/users/harishanand95/orgs","repos_url":"https://api.github.com/users/harishanand95/repos","events_url":"https://api.github.com/users/harishanand95/events{/privacy}","received_events_url":"https://api.github.com/users/harishanand95/received_events","type":"User","site_admin":false},"body":"Work left to complete :\r\n- [x] Invalid input message shown for inputs.\r\n- [x] Repeat Hourly, Daily, Weekly, Monthly, Yearly and dont repeat option works.\r\n- [x] Tests cases\r\n\r\nFixes left:\r\n- [x] Create Timer button shown in all services tab than just timer (will be fixed when #4503 merges).\r\n- [x] Repeat Yearly's datepicker is positioned incorrectly.\r\n- [x] “Invalid input” message causes change of position of boot timer’s elements.","created_at":"2016-06-28T07:17:46Z","updated_at":"2016-08-08T20:13:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"459b2d924e190f0f9b9661aa83a78a767c9b5fbe","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/4645/commits","review_comments_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/4645/comments","review_comment_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/4645/comments","statuses_url":"https://api.github.com/repos/cockpit-project/cockpit/statuses/2093964ddc91abfc44d3b45a22e98c3147465f8f","head":{"label":"harishanand95:systemd-timers","ref":"systemd-timers","sha":"2093964ddc91abfc44d3b45a22e98c3147465f8f","user":{"login":"harishanand95","id":7456909,"avatar_url":"https://avatars.githubusercontent.com/u/7456909?v=3","gravatar_id":"","url":"https://api.github.com/users/harishanand95","html_url":"https://github.com/harishanand95","followers_url":"https://api.github.com/users/harishanand95/followers","following_url":"https://api.github.com/users/harishanand95/following{/other_user}","gists_url":"https://api.github.com/users/harishanand95/gists{/gist_id}","starred_url":"https://api.github.com/users/harishanand95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harishanand95/subscriptions","organizations_url":"https://api.github.com/users/harishanand95/orgs","repos_url":"https://api.github.com/users/harishanand95/repos","events_url":"https://api.github.com/users/harishanand95/events{/privacy}","received_events_url":"https://api.github.com/users/harishanand95/received_events","type":"User","site_admin":false},"repo":{"id":54409453,"name":"cockpit","full_name":"harishanand95/cockpit","owner":{"login":"harishanand95","id":7456909,"avatar_url":"https://avatars.githubusercontent.com/u/7456909?v=3","gravatar_id":"","url":"https://api.github.com/users/harishanand95","html_url":"https://github.com/harishanand95","followers_url":"https://api.github.com/users/harishanand95/followers","following_url":"https://api.github.com/users/harishanand95/following{/other_user}","gists_url":"https://api.github.com/users/harishanand95/gists{/gist_id}","starred_url":"https://api.github.com/users/harishanand95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harishanand95/subscriptions","organizations_url":"https://api.github.com/users/harishanand95/orgs","repos_url":"https://api.github.com/users/harishanand95/repos","events_url":"https://api.github.com/users/harishanand95/events{/privacy}","received_events_url":"https://api.github.com/users/harishanand95/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/harishanand95/cockpit","description":"Cockpit, a user interface for Linux servers","fork":true,"url":"https://api.github.com/repos/harishanand95/cockpit","forks_url":"https://api.github.com/repos/harishanand95/cockpit/forks","keys_url":"https://api.github.com/repos/harishanand95/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harishanand95/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harishanand95/cockpit/teams","hooks_url":"https://api.github.com/repos/harishanand95/cockpit/hooks","issue_events_url":"https://api.github.com/repos/harishanand95/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/harishanand95/cockpit/events","assignees_url":"https://api.github.com/repos/harishanand95/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/harishanand95/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/harishanand95/cockpit/tags","blobs_url":"https://api.github.com/repos/harishanand95/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harishanand95/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harishanand95/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/harishanand95/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harishanand95/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/harishanand95/cockpit/languages","stargazers_url":"https://api.github.com/repos/harishanand95/cockpit/stargazers","contributors_url":"https://api.github.com/repos/harishanand95/cockpit/contributors","subscribers_url":"https://api.github.com/repos/harishanand95/cockpit/subscribers","subscription_url":"https://api.github.com/repos/harishanand95/cockpit/subscription","commits_url":"https://api.github.com/repos/harishanand95/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/harishanand95/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/harishanand95/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/harishanand95/cockpit/issues/comments{/number}","contents_url":"https://api.github.com/repos/harishanand95/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/harishanand95/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harishanand95/cockpit/merges","archive_url":"https://api.github.com/repos/harishanand95/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harishanand95/cockpit/downloads","issues_url":"https://api.github.com/repos/harishanand95/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/harishanand95/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/harishanand95/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/harishanand95/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harishanand95/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/harishanand95/cockpit/releases{/id}","deployments_url":"https://api.github.com/repos/harishanand95/cockpit/deployments","created_at":"2016-03-21T17:34:50Z","updated_at":"2016-06-28T07:27:13Z","pushed_at":"2016-08-08T19:59:31Z","git_url":"git://github.com/harishanand95/cockpit.git","ssh_url":"git@github.com:harishanand95/cockpit.git","clone_url":"https://github.com/harishanand95/cockpit.git","svn_url":"https://github.com/harishanand95/cockpit","homepage":"http://www.cockpit-project.org/","size":25999,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"cockpit-project:master","ref":"master","sha":"ce83dc7103c79a569663e8903e80ca6c1d97ab6c","user":{"login":"cockpit-project","id":5765104,"avatar_url":"https://avatars.githubusercontent.com/u/5765104?v=3","gravatar_id":"","url":"https://api.github.com/users/cockpit-project","html_url":"https://github.com/cockpit-project","followers_url":"https://api.github.com/users/cockpit-project/followers","following_url":"https://api.github.com/users/cockpit-project/following{/other_user}","gists_url":"https://api.github.com/users/cockpit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cockpit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockpit-project/subscriptions","organizations_url":"https://api.github.com/users/cockpit-project/orgs","repos_url":"https://api.github.com/users/cockpit-project/repos","events_url":"https://api.github.com/users/cockpit-project/events{/privacy}","received_events_url":"https://api.github.com/users/cockpit-project/received_events","type":"Organization","site_admin":false},"repo":{"id":14049216,"name":"cockpit","full_name":"cockpit-project/cockpit","owner":{"login":"cockpit-project","id":5765104,"avatar_url":"https://avatars.githubusercontent.com/u/5765104?v=3","gravatar_id":"","url":"https://api.github.com/users/cockpit-project","html_url":"https://github.com/cockpit-project","followers_url":"https://api.github.com/users/cockpit-project/followers","following_url":"https://api.github.com/users/cockpit-project/following{/other_user}","gists_url":"https://api.github.com/users/cockpit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cockpit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockpit-project/subscriptions","organizations_url":"https://api.github.com/users/cockpit-project/orgs","repos_url":"https://api.github.com/users/cockpit-project/repos","events_url":"https://api.github.com/users/cockpit-project/events{/privacy}","received_events_url":"https://api.github.com/users/cockpit-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockpit-project/cockpit","description":"Cockpit, a user interface for Linux servers","fork":false,"url":"https://api.github.com/repos/cockpit-project/cockpit","forks_url":"https://api.github.com/repos/cockpit-project/cockpit/forks","keys_url":"https://api.github.com/repos/cockpit-project/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockpit-project/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockpit-project/cockpit/teams","hooks_url":"https://api.github.com/repos/cockpit-project/cockpit/hooks","issue_events_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/cockpit-project/cockpit/events","assignees_url":"https://api.github.com/repos/cockpit-project/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/cockpit-project/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/cockpit-project/cockpit/tags","blobs_url":"https://api.github.com/repos/cockpit-project/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockpit-project/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockpit-project/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockpit-project/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockpit-project/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/cockpit-project/cockpit/languages","stargazers_url":"https://api.github.com/repos/cockpit-project/cockpit/stargazers","contributors_url":"https://api.github.com/repos/cockpit-project/cockpit/contributors","subscribers_url":"https://api.github.com/repos/cockpit-project/cockpit/subscribers","subscription_url":"https://api.github.com/repos/cockpit-project/cockpit/subscription","commits_url":"https://api.github.com/repos/cockpit-project/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockpit-project/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockpit-project/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/cockpit-project/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockpit-project/cockpit/merges","archive_url":"https://api.github.com/repos/cockpit-project/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockpit-project/cockpit/downloads","issues_url":"https://api.github.com/repos/cockpit-project/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/cockpit-project/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/cockpit-project/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockpit-project/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/cockpit-project/cockpit/releases{/id}","deployments_url":"https://api.github.com/repos/cockpit-project/cockpit/deployments","created_at":"2013-11-01T17:36:46Z","updated_at":"2016-08-02T22:36:39Z","pushed_at":"2016-08-08T19:59:31Z","git_url":"git://github.com/cockpit-project/cockpit.git","ssh_url":"git@github.com:cockpit-project/cockpit.git","clone_url":"https://github.com/cockpit-project/cockpit.git","svn_url":"https://github.com/cockpit-project/cockpit","homepage":"http://www.cockpit-project.org/","size":37472,"stargazers_count":1673,"watchers_count":1673,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":221,"mirror_url":null,"open_issues_count":422,"forks":221,"open_issues":422,"watchers":1673,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/4645"},"html":{"href":"https://github.com/cockpit-project/cockpit/pull/4645"},"issue":{"href":"https://api.github.com/repos/cockpit-project/cockpit/issues/4645"},"comments":{"href":"https://api.github.com/repos/cockpit-project/cockpit/issues/4645/comments"},"review_comments":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/4645/comments"},"review_comment":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/4645/commits"},"statuses":{"href":"https://api.github.com/repos/cockpit-project/cockpit/statuses/2093964ddc91abfc44d3b45a22e98c3147465f8f"}}}}
{"actor":{"display_login":"harishanand95"}}