{"push_id":1296936364,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"a4cc23ffe544de238731526438ab9e89620107a9","before":"b64cc3e02989b2f2763de995c431c6fb114159c9","commits":[{"sha":"fc55256f76c00edd35a24e41b4df82046e286ec8","author":{"name":"Matt Tracy","email":"31e7b35f7f9f5d76c1e2ef239c79b97264b2f6d0@cockroachlabs.com"},"message":"storage: Fix flake in TestStoreMetrics\n\nTestStoreMetrics had become flaky at some point due to a change in the way\nintents are resolved. The change to resolution did not introduce the issue, it\nsimply exacerbated an existing problem in the test.\n\nThe issue occurred because intent resolution is asynchronous for \"remote\"\nintents (not on the same range as the transaction record). This test does create\na few such intents; this test also stops stores before verifying metrics. With\nthe new resolution strategy, stopping a store was likely to create an unresolved\nintent, meaning the intent count was 1.\n\nThis was incompatible with an existing \"sanity check\" that the intent count was\nzero, a regression check for #4624. In order to keep the sanity check, I have\nmoved it into a succeedsSoon block *before* the stores are stopped.\n\nThis fixes #8437; however, the test now appears to be broken due to the same\nunderlying issue as #9204 (an infinite retry in distSender that prevents servers\nfrom stopping). The test remains skipped, but the skip message has been\nmodified.","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/fc55256f76c00edd35a24e41b4df82046e286ec8"},{"sha":"a4cc23ffe544de238731526438ab9e89620107a9","author":{"name":"mrtracy","email":"31e7b35f7f9f5d76c1e2ef239c79b97264b2f6d0@cockroachlabs.com"},"message":"Merge pull request #9311 from mrtracy/mtracy/fix_teststoremetrics\n\nstorage: Fix flake in TestStoreMetrics","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/a4cc23ffe544de238731526438ab9e89620107a9"}]}
{"actor":{"display_login":"mrtracy"}}