{"push_id":1452164675,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"d8c9645c260d163679b4193661566df87cfa9515","before":"53e93e8b053674b1a260d01156c92165438f8d36","commits":[{"sha":"d8c9645c260d163679b4193661566df87cfa9515","author":{"name":"Mike Fairhurst","email":"620b951ad40ee16ec5559ed5e00914c4555ea1fb@google.com"},"message":"Reorganize InheritedRefenenceContributor to serve angular completion\n\nTake the parts that I would have simply copied and pasted them into my\nown code, and create new public & private methods to serve the new\norganization.\n\nAdd an option to get the current class's accessors/methods along with\nthe inherited ones, because that's what I want.\n\nMake opType a public member of DartCompletionRequest\n\nIts used so heavily by so many of the autocomplete targets, it really\ndoesn't need to be hidden on the Impl.\n\nBesides, I want to use InheritedReferenceContributor, which upcasts the\nDartCompletionRequest into the Impl in order to grab this field -- but\nfor a large number of reasons I can't really use\nDartCompletionRequestImpl. Therefore I need my own class to implement\nDartCompletionRequest and therefore my code will only work with\nInheritedReferenceContributor if it doesn't have to look outside the\ninterface for this information.\n\nChange to enable the angular analysis project to do autocomplete\n\nWe don't have CompilationUnits, but we do have dart ASTs, and we want to\nfind the completion target with the same algorithm. The CompletionTarget\nclass's functionality doesn't depend on its member compilationUnit not\nbeing null, so that isn't a problem for us. However, in `forOffset()`,\nwe cannot pass in a null unit, even though its only used to set the\n`compilationUnit` member and otherwise only used as an `AstNode` which\nwe have.\n\nSo rather than using `compilationUnit` as the entry point of the\nalgorithm, add a new `AstNode` parameter to represent the entry point,\nand when its null simply use the value of `compilationUnit`.\n\nBUG=\nR=brianwilkerson@google.com\n\nReview-Url: https://codereview.chromium.org/2565633002 .","distinct":true,"url":"https://api.github.com/repos/dart-lang/sdk/commits/d8c9645c260d163679b4193661566df87cfa9515"}]}
{"actor":{"display_login":"MichaelRFairhurst"}}