{"push_id":1040025198,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"40fec9f0c5b71092e52d10412f79bda8c27c9c33","before":"82adbb1bcbcc36b4627301d7f5979788816fec3f","commits":[{"sha":"963b9abaafc5283e060502eb71e073bfb23b7d19","author":{"email":"b25b72a65195e46aa49449589ffbea257ff840a3@gmail.com","name":"Peter Mattis"},"message":"storage/engine/rocksdb: fix misuse of WBWIIterator.Entry()\n\nThe documentation for WBWIIterator.Entry() states that the returned\nWriteEntry is only valid until the next mutation of the associated\nWriteBatchWithIndex. We were previously violating this by returning\nWBWIIterator.Entry().key for the iterator's key() method. This memory\nwas then cached in rocksDBIterator.key. The underlying data was pointing\ninto the write batch buffer (a string) and was usually ok. But a\nmutation to the write batch could cause the string to be reallocated\nleaving the underlying data either invalid (causing a crash) or\nchanged (causing corruption). Yikes!\n\nFixes #5585.","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/963b9abaafc5283e060502eb71e073bfb23b7d19"},{"sha":"40fec9f0c5b71092e52d10412f79bda8c27c9c33","author":{"email":"4b8373d016f277527198385ba72fda0feb5da015@cockroachlabs.com","name":"Peter Mattis"},"message":"Merge pull request #5634 from petermattis/pmattis/rocksdb-mem-corruption\n\nstorage/engine/rocksdb: fix misuse of WBWIIterator.Entry()","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/40fec9f0c5b71092e52d10412f79bda8c27c9c33"}]}