{"action":"created","comment":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/comments/61475576","id":61475576,"diff_hunk":"@@ -352,6 +352,15 @@ extern bool axis_homed[3]; // axis[n].is_homed\n   extern int meas_delay_cm; //delay distance\n #endif\n \n+#if ENABLED(FILAMENT_CHANGE_ENABLE)\n+  enum FilamentChangeMenuResponse {","path":"Marlin/Marlin.h","position":16,"original_position":16,"commit_id":"1952c01d305c2d9178bb80a31cf9e3591edaef23","original_commit_id":"1952c01d305c2d9178bb80a31cf9e3591edaef23","user":{"login":"jbrazio","id":264365,"avatar_url":"https://avatars.githubusercontent.com/u/264365?v=3","gravatar_id":"","url":"https://api.github.com/users/jbrazio","html_url":"https://github.com/jbrazio","followers_url":"https://api.github.com/users/jbrazio/followers","following_url":"https://api.github.com/users/jbrazio/following{/other_user}","gists_url":"https://api.github.com/users/jbrazio/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrazio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrazio/subscriptions","organizations_url":"https://api.github.com/users/jbrazio/orgs","repos_url":"https://api.github.com/users/jbrazio/repos","events_url":"https://api.github.com/users/jbrazio/events{/privacy}","received_events_url":"https://api.github.com/users/jbrazio/received_events","type":"User","site_admin":false},"body":"I would suggest to remove the attributions:\r\n\r\n```cpp\r\nenum FilamentChangeMenuResponse {\r\n  FILAMENT_CHANGE_RESPONSE_WAIT_FOR,\r\n  FILAMENT_CHANGE_RESPONSE_EXTRUDE_MORE,\r\n  FILAMENT_CHANGE_RESPONSE_RESUME_PRINT\r\n};\r\n```","created_at":"2016-04-28T18:12:20Z","updated_at":"2016-04-28T18:12:20Z","html_url":"https://github.com/MarlinFirmware/Marlin/pull/3638#discussion_r61475576","pull_request_url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/3638","_links":{"self":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/comments/61475576"},"html":{"href":"https://github.com/MarlinFirmware/Marlin/pull/3638#discussion_r61475576"},"pull_request":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/3638"}}},"pull_request":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/3638","id":68263311,"html_url":"https://github.com/MarlinFirmware/Marlin/pull/3638","diff_url":"https://github.com/MarlinFirmware/Marlin/pull/3638.diff","patch_url":"https://github.com/MarlinFirmware/Marlin/pull/3638.patch","issue_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/3638","number":3638,"state":"open","locked":false,"title":"Auto Filament Change Reworked: finally working","user":{"login":"clexpert","id":11002072,"avatar_url":"https://avatars.githubusercontent.com/u/11002072?v=3","gravatar_id":"","url":"https://api.github.com/users/clexpert","html_url":"https://github.com/clexpert","followers_url":"https://api.github.com/users/clexpert/followers","following_url":"https://api.github.com/users/clexpert/following{/other_user}","gists_url":"https://api.github.com/users/clexpert/gists{/gist_id}","starred_url":"https://api.github.com/users/clexpert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clexpert/subscriptions","organizations_url":"https://api.github.com/users/clexpert/orgs","repos_url":"https://api.github.com/users/clexpert/repos","events_url":"https://api.github.com/users/clexpert/events{/privacy}","received_events_url":"https://api.github.com/users/clexpert/received_events","type":"User","site_admin":false},"body":"_(Don't mix up with Manual filament change #3605)_\r\n\r\n# Background\r\nMonths ago, someone suggested reworking (or at leats make existing function work) Auto filament change in #2926 and #2933. This function is working (as mentioned there) in Prusa's firmware and many other closed-source 3D printer. But neither of them is sufficient to be publicated for community of most used 3D firmware, with variety of printers, extruders and displays. So we started working on complete rewrite of filament change function, to make it work for us and then make it open to everyone here on GitHub.\r\n\r\n# Functions\r\nThis change rewrites Auto Filament Change controlled by G-Code M600.\r\nThe procedure of change is:\r\n* Retract a bit and move axis to position set by Configuration or by G-Code parameters\r\n* Unload filament\r\n* Keep beeping and wait for user to insert filament and click on button (encoder)\r\n* Load filament through bowden (see Configuration for details)\r\n* Extrude some filament and ask user either to extrude more or to resume print\r\n* Move axis back and continue printing\r\nEvery step is clearly documented with information messages displayed on the display. As suggested by others, KEEP_ALIVE is also used. Simple working procedure makes it easy to change filament for everyone.\r\n\r\n# TODO list for community\r\n- [ ] Check behaviour on DELTA printers\r\n- [ ] Choose load and extrude distances for all example printers\r\n- [ ] Translate messages\r\n","created_at":"2016-04-28T17:58:12Z","updated_at":"2016-04-28T18:12:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bcff850fc6210fd619d511f3dc190733252886ae","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/3638/commits","review_comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/3638/comments","review_comment_url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/3638/comments","statuses_url":"https://api.github.com/repos/MarlinFirmware/Marlin/statuses/1952c01d305c2d9178bb80a31cf9e3591edaef23","head":{"label":"clexpert:RCBugFix","ref":"RCBugFix","sha":"1952c01d305c2d9178bb80a31cf9e3591edaef23","user":{"login":"clexpert","id":11002072,"avatar_url":"https://avatars.githubusercontent.com/u/11002072?v=3","gravatar_id":"","url":"https://api.github.com/users/clexpert","html_url":"https://github.com/clexpert","followers_url":"https://api.github.com/users/clexpert/followers","following_url":"https://api.github.com/users/clexpert/following{/other_user}","gists_url":"https://api.github.com/users/clexpert/gists{/gist_id}","starred_url":"https://api.github.com/users/clexpert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clexpert/subscriptions","organizations_url":"https://api.github.com/users/clexpert/orgs","repos_url":"https://api.github.com/users/clexpert/repos","events_url":"https://api.github.com/users/clexpert/events{/privacy}","received_events_url":"https://api.github.com/users/clexpert/received_events","type":"User","site_admin":false},"repo":{"id":57318280,"name":"Marlin","full_name":"clexpert/Marlin","owner":{"login":"clexpert","id":11002072,"avatar_url":"https://avatars.githubusercontent.com/u/11002072?v=3","gravatar_id":"","url":"https://api.github.com/users/clexpert","html_url":"https://github.com/clexpert","followers_url":"https://api.github.com/users/clexpert/followers","following_url":"https://api.github.com/users/clexpert/following{/other_user}","gists_url":"https://api.github.com/users/clexpert/gists{/gist_id}","starred_url":"https://api.github.com/users/clexpert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clexpert/subscriptions","organizations_url":"https://api.github.com/users/clexpert/orgs","repos_url":"https://api.github.com/users/clexpert/repos","events_url":"https://api.github.com/users/clexpert/events{/privacy}","received_events_url":"https://api.github.com/users/clexpert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/clexpert/Marlin","description":"Reprap FW with look ahead. SDcard and LCD support. It works on Gen6, Ultimaker, RAMPS and Sanguinololu","fork":true,"url":"https://api.github.com/repos/clexpert/Marlin","forks_url":"https://api.github.com/repos/clexpert/Marlin/forks","keys_url":"https://api.github.com/repos/clexpert/Marlin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clexpert/Marlin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clexpert/Marlin/teams","hooks_url":"https://api.github.com/repos/clexpert/Marlin/hooks","issue_events_url":"https://api.github.com/repos/clexpert/Marlin/issues/events{/number}","events_url":"https://api.github.com/repos/clexpert/Marlin/events","assignees_url":"https://api.github.com/repos/clexpert/Marlin/assignees{/user}","branches_url":"https://api.github.com/repos/clexpert/Marlin/branches{/branch}","tags_url":"https://api.github.com/repos/clexpert/Marlin/tags","blobs_url":"https://api.github.com/repos/clexpert/Marlin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clexpert/Marlin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clexpert/Marlin/git/refs{/sha}","trees_url":"https://api.github.com/repos/clexpert/Marlin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clexpert/Marlin/statuses/{sha}","languages_url":"https://api.github.com/repos/clexpert/Marlin/languages","stargazers_url":"https://api.github.com/repos/clexpert/Marlin/stargazers","contributors_url":"https://api.github.com/repos/clexpert/Marlin/contributors","subscribers_url":"https://api.github.com/repos/clexpert/Marlin/subscribers","subscription_url":"https://api.github.com/repos/clexpert/Marlin/subscription","commits_url":"https://api.github.com/repos/clexpert/Marlin/commits{/sha}","git_commits_url":"https://api.github.com/repos/clexpert/Marlin/git/commits{/sha}","comments_url":"https://api.github.com/repos/clexpert/Marlin/comments{/number}","issue_comment_url":"https://api.github.com/repos/clexpert/Marlin/issues/comments{/number}","contents_url":"https://api.github.com/repos/clexpert/Marlin/contents/{+path}","compare_url":"https://api.github.com/repos/clexpert/Marlin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clexpert/Marlin/merges","archive_url":"https://api.github.com/repos/clexpert/Marlin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clexpert/Marlin/downloads","issues_url":"https://api.github.com/repos/clexpert/Marlin/issues{/number}","pulls_url":"https://api.github.com/repos/clexpert/Marlin/pulls{/number}","milestones_url":"https://api.github.com/repos/clexpert/Marlin/milestones{/number}","notifications_url":"https://api.github.com/repos/clexpert/Marlin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clexpert/Marlin/labels{/name}","releases_url":"https://api.github.com/repos/clexpert/Marlin/releases{/id}","deployments_url":"https://api.github.com/repos/clexpert/Marlin/deployments","created_at":"2016-04-28T16:38:28Z","updated_at":"2016-04-28T16:38:35Z","pushed_at":"2016-04-28T17:50:29Z","git_url":"git://github.com/clexpert/Marlin.git","ssh_url":"git@github.com:clexpert/Marlin.git","clone_url":"https://github.com/clexpert/Marlin.git","svn_url":"https://github.com/clexpert/Marlin","homepage":"","size":28775,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"RC"}},"base":{"label":"MarlinFirmware:RCBugFix","ref":"RCBugFix","sha":"2142d5a62e0fd5bed2e39ea05f6125ad657f99a5","user":{"login":"MarlinFirmware","id":10418365,"avatar_url":"https://avatars.githubusercontent.com/u/10418365?v=3","gravatar_id":"","url":"https://api.github.com/users/MarlinFirmware","html_url":"https://github.com/MarlinFirmware","followers_url":"https://api.github.com/users/MarlinFirmware/followers","following_url":"https://api.github.com/users/MarlinFirmware/following{/other_user}","gists_url":"https://api.github.com/users/MarlinFirmware/gists{/gist_id}","starred_url":"https://api.github.com/users/MarlinFirmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarlinFirmware/subscriptions","organizations_url":"https://api.github.com/users/MarlinFirmware/orgs","repos_url":"https://api.github.com/users/MarlinFirmware/repos","events_url":"https://api.github.com/users/MarlinFirmware/events{/privacy}","received_events_url":"https://api.github.com/users/MarlinFirmware/received_events","type":"Organization","site_admin":false},"repo":{"id":2200856,"name":"Marlin","full_name":"MarlinFirmware/Marlin","owner":{"login":"MarlinFirmware","id":10418365,"avatar_url":"https://avatars.githubusercontent.com/u/10418365?v=3","gravatar_id":"","url":"https://api.github.com/users/MarlinFirmware","html_url":"https://github.com/MarlinFirmware","followers_url":"https://api.github.com/users/MarlinFirmware/followers","following_url":"https://api.github.com/users/MarlinFirmware/following{/other_user}","gists_url":"https://api.github.com/users/MarlinFirmware/gists{/gist_id}","starred_url":"https://api.github.com/users/MarlinFirmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarlinFirmware/subscriptions","organizations_url":"https://api.github.com/users/MarlinFirmware/orgs","repos_url":"https://api.github.com/users/MarlinFirmware/repos","events_url":"https://api.github.com/users/MarlinFirmware/events{/privacy}","received_events_url":"https://api.github.com/users/MarlinFirmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MarlinFirmware/Marlin","description":"Reprap FW with look ahead. SDcard and LCD support. It works on Gen6, Ultimaker, RAMPS and Sanguinololu","fork":false,"url":"https://api.github.com/repos/MarlinFirmware/Marlin","forks_url":"https://api.github.com/repos/MarlinFirmware/Marlin/forks","keys_url":"https://api.github.com/repos/MarlinFirmware/Marlin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarlinFirmware/Marlin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarlinFirmware/Marlin/teams","hooks_url":"https://api.github.com/repos/MarlinFirmware/Marlin/hooks","issue_events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/events{/number}","events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/events","assignees_url":"https://api.github.com/repos/MarlinFirmware/Marlin/assignees{/user}","branches_url":"https://api.github.com/repos/MarlinFirmware/Marlin/branches{/branch}","tags_url":"https://api.github.com/repos/MarlinFirmware/Marlin/tags","blobs_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarlinFirmware/Marlin/statuses/{sha}","languages_url":"https://api.github.com/repos/MarlinFirmware/Marlin/languages","stargazers_url":"https://api.github.com/repos/MarlinFirmware/Marlin/stargazers","contributors_url":"https://api.github.com/repos/MarlinFirmware/Marlin/contributors","subscribers_url":"https://api.github.com/repos/MarlinFirmware/Marlin/subscribers","subscription_url":"https://api.github.com/repos/MarlinFirmware/Marlin/subscription","commits_url":"https://api.github.com/repos/MarlinFirmware/Marlin/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarlinFirmware/Marlin/contents/{+path}","compare_url":"https://api.github.com/repos/MarlinFirmware/Marlin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarlinFirmware/Marlin/merges","archive_url":"https://api.github.com/repos/MarlinFirmware/Marlin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarlinFirmware/Marlin/downloads","issues_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues{/number}","pulls_url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls{/number}","milestones_url":"https://api.github.com/repos/MarlinFirmware/Marlin/milestones{/number}","notifications_url":"https://api.github.com/repos/MarlinFirmware/Marlin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels{/name}","releases_url":"https://api.github.com/repos/MarlinFirmware/Marlin/releases{/id}","deployments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/deployments","created_at":"2011-08-13T08:07:20Z","updated_at":"2016-04-28T14:16:50Z","pushed_at":"2016-04-28T17:58:13Z","git_url":"git://github.com/MarlinFirmware/Marlin.git","ssh_url":"git@github.com:MarlinFirmware/Marlin.git","clone_url":"https://github.com/MarlinFirmware/Marlin.git","svn_url":"https://github.com/MarlinFirmware/Marlin","homepage":"","size":51364,"stargazers_count":1688,"watchers_count":1688,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2966,"mirror_url":null,"open_issues_count":173,"forks":2966,"open_issues":173,"watchers":1688,"default_branch":"RC"}},"_links":{"self":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/3638"},"html":{"href":"https://github.com/MarlinFirmware/Marlin/pull/3638"},"issue":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/3638"},"comments":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/3638/comments"},"review_comments":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/3638/comments"},"review_comment":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/3638/commits"},"statuses":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/statuses/1952c01d305c2d9178bb80a31cf9e3591edaef23"}}}}