{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/blueprint/pulls/comments/90695803","pull_request_review_id":11215859,"id":90695803,"diff_hunk":"@@ -320,4 +321,36 @@ export class DateInput extends AbstractComponent<IDateInputProps, IDateInputStat\n     private setInputRef = (el: HTMLElement) => {\n         this.inputRef = el;\n     }\n+\n+    /**\n+     * Translate a moment into a Date object, adjusting the moment timezone into the local one.","path":"packages/datetime/src/dateInput.tsx","position":80,"original_position":80,"commit_id":"a2d8018d08f086577b074e9991365cbdd70b50e8","original_commit_id":"a2d8018d08f086577b074e9991365cbdd70b50e8","user":{"login":"giladgray","id":464822,"avatar_url":"https://avatars.githubusercontent.com/u/464822?v=3","gravatar_id":"","url":"https://api.github.com/users/giladgray","html_url":"https://github.com/giladgray","followers_url":"https://api.github.com/users/giladgray/followers","following_url":"https://api.github.com/users/giladgray/following{/other_user}","gists_url":"https://api.github.com/users/giladgray/gists{/gist_id}","starred_url":"https://api.github.com/users/giladgray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giladgray/subscriptions","organizations_url":"https://api.github.com/users/giladgray/orgs","repos_url":"https://api.github.com/users/giladgray/repos","events_url":"https://api.github.com/users/giladgray/events{/privacy}","received_events_url":"https://api.github.com/users/giladgray/received_events","type":"User","site_admin":false},"body":"where does the adjustment happen? i'm assuming it's _inside_ moment but it's not obvious _why_ this works.","created_at":"2016-12-02T18:39:14Z","updated_at":"2016-12-02T18:39:14Z","html_url":"https://github.com/palantir/blueprint/pull/297#discussion_r90695803","pull_request_url":"https://api.github.com/repos/palantir/blueprint/pulls/297","_links":{"self":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/comments/90695803"},"html":{"href":"https://github.com/palantir/blueprint/pull/297#discussion_r90695803"},"pull_request":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/297"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/blueprint/pulls/297","id":96317722,"html_url":"https://github.com/palantir/blueprint/pull/297","diff_url":"https://github.com/palantir/blueprint/pull/297.diff","patch_url":"https://github.com/palantir/blueprint/pull/297.patch","issue_url":"https://api.github.com/repos/palantir/blueprint/issues/297","number":297,"state":"open","locked":false,"title":"moment-timezone compatability for DateInput","user":{"login":"mfedderly","id":24275386,"avatar_url":"https://avatars.githubusercontent.com/u/24275386?v=3","gravatar_id":"","url":"https://api.github.com/users/mfedderly","html_url":"https://github.com/mfedderly","followers_url":"https://api.github.com/users/mfedderly/followers","following_url":"https://api.github.com/users/mfedderly/following{/other_user}","gists_url":"https://api.github.com/users/mfedderly/gists{/gist_id}","starred_url":"https://api.github.com/users/mfedderly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfedderly/subscriptions","organizations_url":"https://api.github.com/users/mfedderly/orgs","repos_url":"https://api.github.com/users/mfedderly/repos","events_url":"https://api.github.com/users/mfedderly/events{/privacy}","received_events_url":"https://api.github.com/users/mfedderly/received_events","type":"User","site_admin":false},"body":"#### Fixes #280 \r\n\r\n#### Changes proposed in this pull request:\r\n\r\n- Properly handle moment-timezone's setDefault\r\n- DateInput accepts dates in the local timezone\r\n- DateInput onChange returns dates in the local timezone\r\n\r\n#### Reviewers should focus on:\r\n\r\n- DateInput.handleDateChange method \r\n- Making sure this works in multiple timezones\r\n- Making sure this works with and without moment-timezone\r\n\r\n","created_at":"2016-12-02T17:12:44Z","updated_at":"2016-12-02T18:39:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a9be1bc50bfaa68d8168e28a7420bdca4b64c8d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/blueprint/pulls/297/commits","review_comments_url":"https://api.github.com/repos/palantir/blueprint/pulls/297/comments","review_comment_url":"https://api.github.com/repos/palantir/blueprint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/blueprint/issues/297/comments","statuses_url":"https://api.github.com/repos/palantir/blueprint/statuses/a2d8018d08f086577b074e9991365cbdd70b50e8","head":{"label":"mfedderly:mf/dateinput-moment-timezone","ref":"mf/dateinput-moment-timezone","sha":"a2d8018d08f086577b074e9991365cbdd70b50e8","user":{"login":"mfedderly","id":24275386,"avatar_url":"https://avatars.githubusercontent.com/u/24275386?v=3","gravatar_id":"","url":"https://api.github.com/users/mfedderly","html_url":"https://github.com/mfedderly","followers_url":"https://api.github.com/users/mfedderly/followers","following_url":"https://api.github.com/users/mfedderly/following{/other_user}","gists_url":"https://api.github.com/users/mfedderly/gists{/gist_id}","starred_url":"https://api.github.com/users/mfedderly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfedderly/subscriptions","organizations_url":"https://api.github.com/users/mfedderly/orgs","repos_url":"https://api.github.com/users/mfedderly/repos","events_url":"https://api.github.com/users/mfedderly/events{/privacy}","received_events_url":"https://api.github.com/users/mfedderly/received_events","type":"User","site_admin":false},"repo":{"id":75404944,"name":"blueprint","full_name":"mfedderly/blueprint","owner":{"login":"mfedderly","id":24275386,"avatar_url":"https://avatars.githubusercontent.com/u/24275386?v=3","gravatar_id":"","url":"https://api.github.com/users/mfedderly","html_url":"https://github.com/mfedderly","followers_url":"https://api.github.com/users/mfedderly/followers","following_url":"https://api.github.com/users/mfedderly/following{/other_user}","gists_url":"https://api.github.com/users/mfedderly/gists{/gist_id}","starred_url":"https://api.github.com/users/mfedderly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfedderly/subscriptions","organizations_url":"https://api.github.com/users/mfedderly/orgs","repos_url":"https://api.github.com/users/mfedderly/repos","events_url":"https://api.github.com/users/mfedderly/events{/privacy}","received_events_url":"https://api.github.com/users/mfedderly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mfedderly/blueprint","description":"A React UI toolkit for the web","fork":true,"url":"https://api.github.com/repos/mfedderly/blueprint","forks_url":"https://api.github.com/repos/mfedderly/blueprint/forks","keys_url":"https://api.github.com/repos/mfedderly/blueprint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mfedderly/blueprint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mfedderly/blueprint/teams","hooks_url":"https://api.github.com/repos/mfedderly/blueprint/hooks","issue_events_url":"https://api.github.com/repos/mfedderly/blueprint/issues/events{/number}","events_url":"https://api.github.com/repos/mfedderly/blueprint/events","assignees_url":"https://api.github.com/repos/mfedderly/blueprint/assignees{/user}","branches_url":"https://api.github.com/repos/mfedderly/blueprint/branches{/branch}","tags_url":"https://api.github.com/repos/mfedderly/blueprint/tags","blobs_url":"https://api.github.com/repos/mfedderly/blueprint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mfedderly/blueprint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mfedderly/blueprint/git/refs{/sha}","trees_url":"https://api.github.com/repos/mfedderly/blueprint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mfedderly/blueprint/statuses/{sha}","languages_url":"https://api.github.com/repos/mfedderly/blueprint/languages","stargazers_url":"https://api.github.com/repos/mfedderly/blueprint/stargazers","contributors_url":"https://api.github.com/repos/mfedderly/blueprint/contributors","subscribers_url":"https://api.github.com/repos/mfedderly/blueprint/subscribers","subscription_url":"https://api.github.com/repos/mfedderly/blueprint/subscription","commits_url":"https://api.github.com/repos/mfedderly/blueprint/commits{/sha}","git_commits_url":"https://api.github.com/repos/mfedderly/blueprint/git/commits{/sha}","comments_url":"https://api.github.com/repos/mfedderly/blueprint/comments{/number}","issue_comment_url":"https://api.github.com/repos/mfedderly/blueprint/issues/comments{/number}","contents_url":"https://api.github.com/repos/mfedderly/blueprint/contents/{+path}","compare_url":"https://api.github.com/repos/mfedderly/blueprint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mfedderly/blueprint/merges","archive_url":"https://api.github.com/repos/mfedderly/blueprint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mfedderly/blueprint/downloads","issues_url":"https://api.github.com/repos/mfedderly/blueprint/issues{/number}","pulls_url":"https://api.github.com/repos/mfedderly/blueprint/pulls{/number}","milestones_url":"https://api.github.com/repos/mfedderly/blueprint/milestones{/number}","notifications_url":"https://api.github.com/repos/mfedderly/blueprint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mfedderly/blueprint/labels{/name}","releases_url":"https://api.github.com/repos/mfedderly/blueprint/releases{/id}","deployments_url":"https://api.github.com/repos/mfedderly/blueprint/deployments","created_at":"2016-12-02T14:58:45Z","updated_at":"2016-12-02T14:58:48Z","pushed_at":"2016-12-02T17:11:56Z","git_url":"git://github.com/mfedderly/blueprint.git","ssh_url":"git@github.com:mfedderly/blueprint.git","clone_url":"https://github.com/mfedderly/blueprint.git","svn_url":"https://github.com/mfedderly/blueprint","homepage":"http://blueprintjs.com/","size":4492,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"palantir:master","ref":"master","sha":"2ac65d76b6539a3ffb54f8969978c83e9663dd43","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":71939872,"name":"blueprint","full_name":"palantir/blueprint","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/blueprint","description":"A React UI toolkit for the web","fork":false,"url":"https://api.github.com/repos/palantir/blueprint","forks_url":"https://api.github.com/repos/palantir/blueprint/forks","keys_url":"https://api.github.com/repos/palantir/blueprint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/blueprint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/blueprint/teams","hooks_url":"https://api.github.com/repos/palantir/blueprint/hooks","issue_events_url":"https://api.github.com/repos/palantir/blueprint/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/blueprint/events","assignees_url":"https://api.github.com/repos/palantir/blueprint/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/blueprint/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/blueprint/tags","blobs_url":"https://api.github.com/repos/palantir/blueprint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/blueprint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/blueprint/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/blueprint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/blueprint/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/blueprint/languages","stargazers_url":"https://api.github.com/repos/palantir/blueprint/stargazers","contributors_url":"https://api.github.com/repos/palantir/blueprint/contributors","subscribers_url":"https://api.github.com/repos/palantir/blueprint/subscribers","subscription_url":"https://api.github.com/repos/palantir/blueprint/subscription","commits_url":"https://api.github.com/repos/palantir/blueprint/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/blueprint/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/blueprint/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/blueprint/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/blueprint/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/blueprint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/blueprint/merges","archive_url":"https://api.github.com/repos/palantir/blueprint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/blueprint/downloads","issues_url":"https://api.github.com/repos/palantir/blueprint/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/blueprint/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/blueprint/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/blueprint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/blueprint/labels{/name}","releases_url":"https://api.github.com/repos/palantir/blueprint/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/blueprint/deployments","created_at":"2016-10-25T21:17:50Z","updated_at":"2016-12-02T18:23:27Z","pushed_at":"2016-12-02T18:36:25Z","git_url":"git://github.com/palantir/blueprint.git","ssh_url":"git@github.com:palantir/blueprint.git","clone_url":"https://github.com/palantir/blueprint.git","svn_url":"https://github.com/palantir/blueprint","homepage":"http://blueprintjs.com/","size":5424,"stargazers_count":4729,"watchers_count":4729,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":148,"mirror_url":null,"open_issues_count":75,"forks":148,"open_issues":75,"watchers":4729,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/297"},"html":{"href":"https://github.com/palantir/blueprint/pull/297"},"issue":{"href":"https://api.github.com/repos/palantir/blueprint/issues/297"},"comments":{"href":"https://api.github.com/repos/palantir/blueprint/issues/297/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/297/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/297/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/blueprint/statuses/a2d8018d08f086577b074e9991365cbdd70b50e8"}}}}
{"actor":{"display_login":"giladgray"}}