{"action":"created","comment":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/comments/66636491","id":66636491,"diff_hunk":"@@ -85,7 +85,7 @@ docs/*/pdfreactor-fonts.html\n #################\n *.egg-info\n .installed.cfg\n-static/\n+/static/","path":".gitignore","position":5,"original_position":5,"commit_id":"1c248a67ff4ba47cf3957097dc46c096384fb9e6","original_commit_id":"1c248a67ff4ba47cf3957097dc46c096384fb9e6","user":{"login":"vccabral","id":515096,"avatar_url":"https://avatars.githubusercontent.com/u/515096?v=3","gravatar_id":"","url":"https://api.github.com/users/vccabral","html_url":"https://github.com/vccabral","followers_url":"https://api.github.com/users/vccabral/followers","following_url":"https://api.github.com/users/vccabral/following{/other_user}","gists_url":"https://api.github.com/users/vccabral/gists{/gist_id}","starred_url":"https://api.github.com/users/vccabral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vccabral/subscriptions","organizations_url":"https://api.github.com/users/vccabral/orgs","repos_url":"https://api.github.com/users/vccabral/repos","events_url":"https://api.github.com/users/vccabral/events{/privacy}","received_events_url":"https://api.github.com/users/vccabral/received_events","type":"User","site_admin":false},"body":"why is static in ignore? I don't understand the specifics of how cfgov's static assets are setup but why would we want to not checkin the static dir? Is this the collect static dir?","created_at":"2016-06-10T15:49:49Z","updated_at":"2016-06-10T15:49:49Z","html_url":"https://github.com/cfpb/cfgov-refresh/pull/2156#discussion_r66636491","pull_request_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/2156","_links":{"self":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/comments/66636491"},"html":{"href":"https://github.com/cfpb/cfgov-refresh/pull/2156#discussion_r66636491"},"pull_request":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/2156"}}},"pull_request":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/2156","id":72022954,"html_url":"https://github.com/cfpb/cfgov-refresh/pull/2156","diff_url":"https://github.com/cfpb/cfgov-refresh/pull/2156.diff","patch_url":"https://github.com/cfpb/cfgov-refresh/pull/2156.patch","issue_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2156","number":2156,"state":"open","locked":false,"title":"Move assets from cfpb_nemo to this repo, make nonresponsive JS updates","user":{"login":"rosskarchner","id":235397,"avatar_url":"https://avatars.githubusercontent.com/u/235397?v=3","gravatar_id":"","url":"https://api.github.com/users/rosskarchner","html_url":"https://github.com/rosskarchner","followers_url":"https://api.github.com/users/rosskarchner/followers","following_url":"https://api.github.com/users/rosskarchner/following{/other_user}","gists_url":"https://api.github.com/users/rosskarchner/gists{/gist_id}","starred_url":"https://api.github.com/users/rosskarchner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosskarchner/subscriptions","organizations_url":"https://api.github.com/users/rosskarchner/orgs","repos_url":"https://api.github.com/users/rosskarchner/repos","events_url":"https://api.github.com/users/rosskarchner/events{/privacy}","received_events_url":"https://api.github.com/users/rosskarchner/received_events","type":"User","site_admin":false},"body":"This makes the world better in a few ways. Right now, if you need to tweak a Django app that depends on the nonresponsive header, you need to change:\r\n\r\n- your app (maybe)\r\n- this repo (maybe)\r\n- our wordpress theme (what?)\r\n\r\nThis *at least* removes that last step. I've also made some requested changes to the nonresponsive header JS.\r\n\r\nSomeone (FEWD) should:\r\n\r\n- [ ] Make the CSS changes necessary to correct the issue in the screenshot bellow\r\n- [ ] Convert Nemo's grunt tasks to our gulpfile\r\n\r\nThat can either happen in a subsequent PR, or just commit to this branch.\r\n\r\n<img width=\"751\" alt=\"screen shot 2016-05-26 at 1 41 53 pm\" src=\"https://cloud.githubusercontent.com/assets/235397/15676540/9dd0f712-2714-11e6-91a4-566226eb7940.png\">\r\n\r\nIn chat, @anselmbradford said:\r\n```\r\n/v1-nonresponsive-header.css needs a manual update likely :-\\\r\n\r\nNeeds the styles from https://github.com/cfpb/cfgov-refresh/blob/flapjack/cfgov/unprocessed/css/on-demand/header.less with all the responsive bits deleted\r\n```\r\n\r\nI also embraced scope creep a little, and fixed a few annoying-but-not-user-facing bugs with static files. These are mostly things that generate emails and errors when we're being security scanned, or caused ugly-looking python errors when running locally in debug mode.\r\n\r\n## Additions\r\n\r\n- a whole bunch of files\r\n\r\n## Testing\r\n\r\n- As long as pages like http://localhost:8000/jobs/supervision/ don't look busted, we should be fine\r\n\r\n## Review\r\n\r\n- @anselmbradford @richaagarwal @KimberlyMunoz @sebworks \r\n\r\n## Screenshots\r\n\r\n\r\n## Notes\r\n\r\n-\r\n\r\n## Todos\r\n\r\n- [ ] Adapt cfpb_nemo to point to assets in /static/nemo\r\n\r\n## Checklist\r\n\r\n* [ ] Changes are limited to a single goal (no scope creep)\r\n* [ ] Code can be automatically merged (no conflicts)\r\n* [ ] Code follows the standards laid out in the [front end playbook](https://github.com/cfpb/front-end)\r\n* [ ] Passes all existing automated tests\r\n* [ ] New functions include new tests\r\n* [ ] New functions are documented (with a description, list of inputs, and expected output)\r\n* [ ] Placeholder code is flagged\r\n* [ ] Visually tested in supported browsers and devices\r\n* [ ] Project documentation has been updated (including the \"Unreleased\" section of the CHANGELOG)","created_at":"2016-05-31T14:14:09Z","updated_at":"2016-06-10T15:49:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ff5b32ca9957d447893c010f93a974357cab88b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/2156/commits","review_comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/2156/comments","review_comment_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2156/comments","statuses_url":"https://api.github.com/repos/cfpb/cfgov-refresh/statuses/1c248a67ff4ba47cf3957097dc46c096384fb9e6","head":{"label":"cfpb:can-nemo-come-over","ref":"can-nemo-come-over","sha":"1c248a67ff4ba47cf3957097dc46c096384fb9e6","user":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"repo":{"id":18852566,"name":"cfgov-refresh","full_name":"cfpb/cfgov-refresh","owner":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfpb/cfgov-refresh","description":"Django project that powers the redesigned consumerfinance.gov website.","fork":false,"url":"https://api.github.com/repos/cfpb/cfgov-refresh","forks_url":"https://api.github.com/repos/cfpb/cfgov-refresh/forks","keys_url":"https://api.github.com/repos/cfpb/cfgov-refresh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfpb/cfgov-refresh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfpb/cfgov-refresh/teams","hooks_url":"https://api.github.com/repos/cfpb/cfgov-refresh/hooks","issue_events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/events{/number}","events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/events","assignees_url":"https://api.github.com/repos/cfpb/cfgov-refresh/assignees{/user}","branches_url":"https://api.github.com/repos/cfpb/cfgov-refresh/branches{/branch}","tags_url":"https://api.github.com/repos/cfpb/cfgov-refresh/tags","blobs_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfpb/cfgov-refresh/statuses/{sha}","languages_url":"https://api.github.com/repos/cfpb/cfgov-refresh/languages","stargazers_url":"https://api.github.com/repos/cfpb/cfgov-refresh/stargazers","contributors_url":"https://api.github.com/repos/cfpb/cfgov-refresh/contributors","subscribers_url":"https://api.github.com/repos/cfpb/cfgov-refresh/subscribers","subscription_url":"https://api.github.com/repos/cfpb/cfgov-refresh/subscription","commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfpb/cfgov-refresh/contents/{+path}","compare_url":"https://api.github.com/repos/cfpb/cfgov-refresh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfpb/cfgov-refresh/merges","archive_url":"https://api.github.com/repos/cfpb/cfgov-refresh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfpb/cfgov-refresh/downloads","issues_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues{/number}","pulls_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls{/number}","milestones_url":"https://api.github.com/repos/cfpb/cfgov-refresh/milestones{/number}","notifications_url":"https://api.github.com/repos/cfpb/cfgov-refresh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfpb/cfgov-refresh/labels{/name}","releases_url":"https://api.github.com/repos/cfpb/cfgov-refresh/releases{/id}","deployments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/deployments","created_at":"2014-04-16T19:22:03Z","updated_at":"2016-06-02T13:00:34Z","pushed_at":"2016-06-10T15:26:57Z","git_url":"git://github.com/cfpb/cfgov-refresh.git","ssh_url":"git@github.com:cfpb/cfgov-refresh.git","clone_url":"https://github.com/cfpb/cfgov-refresh.git","svn_url":"https://github.com/cfpb/cfgov-refresh","homepage":"http://www.consumerfinance.gov/","size":126337,"stargazers_count":65,"watchers_count":65,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":31,"mirror_url":null,"open_issues_count":94,"forks":31,"open_issues":94,"watchers":65,"default_branch":"flapjack"}},"base":{"label":"cfpb:flapjack","ref":"flapjack","sha":"77c217855d74b505267f6a9c75dcd9c5a4fe7d4a","user":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"repo":{"id":18852566,"name":"cfgov-refresh","full_name":"cfpb/cfgov-refresh","owner":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfpb/cfgov-refresh","description":"Django project that powers the redesigned consumerfinance.gov website.","fork":false,"url":"https://api.github.com/repos/cfpb/cfgov-refresh","forks_url":"https://api.github.com/repos/cfpb/cfgov-refresh/forks","keys_url":"https://api.github.com/repos/cfpb/cfgov-refresh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfpb/cfgov-refresh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfpb/cfgov-refresh/teams","hooks_url":"https://api.github.com/repos/cfpb/cfgov-refresh/hooks","issue_events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/events{/number}","events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/events","assignees_url":"https://api.github.com/repos/cfpb/cfgov-refresh/assignees{/user}","branches_url":"https://api.github.com/repos/cfpb/cfgov-refresh/branches{/branch}","tags_url":"https://api.github.com/repos/cfpb/cfgov-refresh/tags","blobs_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfpb/cfgov-refresh/statuses/{sha}","languages_url":"https://api.github.com/repos/cfpb/cfgov-refresh/languages","stargazers_url":"https://api.github.com/repos/cfpb/cfgov-refresh/stargazers","contributors_url":"https://api.github.com/repos/cfpb/cfgov-refresh/contributors","subscribers_url":"https://api.github.com/repos/cfpb/cfgov-refresh/subscribers","subscription_url":"https://api.github.com/repos/cfpb/cfgov-refresh/subscription","commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfpb/cfgov-refresh/contents/{+path}","compare_url":"https://api.github.com/repos/cfpb/cfgov-refresh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfpb/cfgov-refresh/merges","archive_url":"https://api.github.com/repos/cfpb/cfgov-refresh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfpb/cfgov-refresh/downloads","issues_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues{/number}","pulls_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls{/number}","milestones_url":"https://api.github.com/repos/cfpb/cfgov-refresh/milestones{/number}","notifications_url":"https://api.github.com/repos/cfpb/cfgov-refresh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfpb/cfgov-refresh/labels{/name}","releases_url":"https://api.github.com/repos/cfpb/cfgov-refresh/releases{/id}","deployments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/deployments","created_at":"2014-04-16T19:22:03Z","updated_at":"2016-06-02T13:00:34Z","pushed_at":"2016-06-10T15:26:57Z","git_url":"git://github.com/cfpb/cfgov-refresh.git","ssh_url":"git@github.com:cfpb/cfgov-refresh.git","clone_url":"https://github.com/cfpb/cfgov-refresh.git","svn_url":"https://github.com/cfpb/cfgov-refresh","homepage":"http://www.consumerfinance.gov/","size":126337,"stargazers_count":65,"watchers_count":65,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":31,"mirror_url":null,"open_issues_count":94,"forks":31,"open_issues":94,"watchers":65,"default_branch":"flapjack"}},"_links":{"self":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/2156"},"html":{"href":"https://github.com/cfpb/cfgov-refresh/pull/2156"},"issue":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2156"},"comments":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2156/comments"},"review_comments":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/2156/comments"},"review_comment":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/2156/commits"},"statuses":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/statuses/1c248a67ff4ba47cf3957097dc46c096384fb9e6"}}}}
{"actor":{"display_login":"vccabral"}}