{"action":"closed","number":4616,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/4616","id":58024443,"html_url":"https://github.com/puppetlabs/puppet/pull/4616","diff_url":"https://github.com/puppetlabs/puppet/pull/4616.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/4616.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/4616","number":4616,"state":"closed","locked":false,"title":"(PUP-5802) Make the Yum package provider correctly parse epochs","user":{"login":"mveytsman","id":34720,"avatar_url":"https://avatars.githubusercontent.com/u/34720?v=3","gravatar_id":"","url":"https://api.github.com/users/mveytsman","html_url":"https://github.com/mveytsman","followers_url":"https://api.github.com/users/mveytsman/followers","following_url":"https://api.github.com/users/mveytsman/following{/other_user}","gists_url":"https://api.github.com/users/mveytsman/gists{/gist_id}","starred_url":"https://api.github.com/users/mveytsman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mveytsman/subscriptions","organizations_url":"https://api.github.com/users/mveytsman/orgs","repos_url":"https://api.github.com/users/mveytsman/repos","events_url":"https://api.github.com/users/mveytsman/events{/privacy}","received_events_url":"https://api.github.com/users/mveytsman/received_events","type":"User","site_admin":false},"body":"Without this patch applied, the Yum package provider assumes all version\r\nepochs are \"0\", i.e. a package with version \"1:1.2.3-4.el5\" will be\r\ninterpreted as having epoch \"0\" not \"1\". This causes version comparisons\r\nmade by puppet to be incorrect when comparing packages of different\r\nepoch's.\r\n\r\nThis bug is caused by the line:\r\n\r\n```\r\ne = String(Bignum(e)) rescue '0'\r\n```\r\nBignum is not a function, so the line always throws an exception and the\r\nrescue is always invoked.\r\n\r\nThis patch uses Integer instead of Bignum, rescues the specific\r\nexception needed (this is so that an epoch like \"foo\" is coerced into\r\n\"0\"), and provides a test for non-zero epochs","created_at":"2016-02-02T17:55:04Z","updated_at":"2016-02-16T19:30:26Z","closed_at":"2016-02-16T19:30:25Z","merged_at":"2016-02-16T19:30:25Z","merge_commit_sha":"53f4677a841593de48dbf3ab38412c06628070e8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/4616/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/4616/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/4616/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/f147025d3d99e8589ca4d7a2f13caea7b3a1cfe8","head":{"label":"mveytsman:fix/master/yumepochparsing","ref":"fix/master/yumepochparsing","sha":"f147025d3d99e8589ca4d7a2f13caea7b3a1cfe8","user":{"login":"mveytsman","id":34720,"avatar_url":"https://avatars.githubusercontent.com/u/34720?v=3","gravatar_id":"","url":"https://api.github.com/users/mveytsman","html_url":"https://github.com/mveytsman","followers_url":"https://api.github.com/users/mveytsman/followers","following_url":"https://api.github.com/users/mveytsman/following{/other_user}","gists_url":"https://api.github.com/users/mveytsman/gists{/gist_id}","starred_url":"https://api.github.com/users/mveytsman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mveytsman/subscriptions","organizations_url":"https://api.github.com/users/mveytsman/orgs","repos_url":"https://api.github.com/users/mveytsman/repos","events_url":"https://api.github.com/users/mveytsman/events{/privacy}","received_events_url":"https://api.github.com/users/mveytsman/received_events","type":"User","site_admin":false},"repo":{"id":50938008,"name":"puppet","full_name":"mveytsman/puppet","owner":{"login":"mveytsman","id":34720,"avatar_url":"https://avatars.githubusercontent.com/u/34720?v=3","gravatar_id":"","url":"https://api.github.com/users/mveytsman","html_url":"https://github.com/mveytsman","followers_url":"https://api.github.com/users/mveytsman/followers","following_url":"https://api.github.com/users/mveytsman/following{/other_user}","gists_url":"https://api.github.com/users/mveytsman/gists{/gist_id}","starred_url":"https://api.github.com/users/mveytsman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mveytsman/subscriptions","organizations_url":"https://api.github.com/users/mveytsman/orgs","repos_url":"https://api.github.com/users/mveytsman/repos","events_url":"https://api.github.com/users/mveytsman/events{/privacy}","received_events_url":"https://api.github.com/users/mveytsman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mveytsman/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/mveytsman/puppet","forks_url":"https://api.github.com/repos/mveytsman/puppet/forks","keys_url":"https://api.github.com/repos/mveytsman/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mveytsman/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mveytsman/puppet/teams","hooks_url":"https://api.github.com/repos/mveytsman/puppet/hooks","issue_events_url":"https://api.github.com/repos/mveytsman/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/mveytsman/puppet/events","assignees_url":"https://api.github.com/repos/mveytsman/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/mveytsman/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/mveytsman/puppet/tags","blobs_url":"https://api.github.com/repos/mveytsman/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mveytsman/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mveytsman/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/mveytsman/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mveytsman/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/mveytsman/puppet/languages","stargazers_url":"https://api.github.com/repos/mveytsman/puppet/stargazers","contributors_url":"https://api.github.com/repos/mveytsman/puppet/contributors","subscribers_url":"https://api.github.com/repos/mveytsman/puppet/subscribers","subscription_url":"https://api.github.com/repos/mveytsman/puppet/subscription","commits_url":"https://api.github.com/repos/mveytsman/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/mveytsman/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/mveytsman/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/mveytsman/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/mveytsman/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/mveytsman/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mveytsman/puppet/merges","archive_url":"https://api.github.com/repos/mveytsman/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mveytsman/puppet/downloads","issues_url":"https://api.github.com/repos/mveytsman/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/mveytsman/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/mveytsman/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/mveytsman/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mveytsman/puppet/labels{/name}","releases_url":"https://api.github.com/repos/mveytsman/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/mveytsman/puppet/deployments","created_at":"2016-02-02T17:23:17Z","updated_at":"2016-02-02T17:23:26Z","pushed_at":"2016-02-02T17:53:33Z","git_url":"git://github.com/mveytsman/puppet.git","ssh_url":"git@github.com:mveytsman/puppet.git","clone_url":"https://github.com/mveytsman/puppet.git","svn_url":"https://github.com/mveytsman/puppet","homepage":"https://puppetlabs.com/puppet/what-is-puppet","size":49657,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"635b5bab43dd13036f3ee87f9de8a8439237c472","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppet/deployments","created_at":"2010-09-14T19:26:44Z","updated_at":"2016-02-16T14:24:33Z","pushed_at":"2016-02-16T19:30:26Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"https://puppetlabs.com/puppet/what-is-puppet","size":78819,"stargazers_count":3815,"watchers_count":3815,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1576,"mirror_url":null,"open_issues_count":26,"forks":1576,"open_issues":26,"watchers":3815,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/4616"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/4616"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/4616"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/4616/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/4616/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/4616/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/f147025d3d99e8589ca4d7a2f13caea7b3a1cfe8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"commits":1,"additions":14,"deletions":2,"changed_files":2}}