{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/rkt/pulls/comments/71218989","id":71218989,"diff_hunk":"@@ -305,76 +325,190 @@ func getNetworks(p *pod) []*v1alpha.Network {\n \treturn networks\n }\n \n-// getBasicPod returns *v1alpha.Pod with basic pod information.\n-func getBasicPod(p *pod) *v1alpha.Pod {\n+type aggregate []error\n+\n+// Error is part of the error interface.\n+func (agg aggregate) Error() string {\n+\tif len(agg) == 0 {\n+\t\t// This should never happen, really.\n+\t\treturn \"\"\n+\t}\n+\tif len(agg) == 1 {\n+\t\treturn agg[0].Error()\n+\t}\n+\tresult := fmt.Sprintf(\"[%s\", agg[0].Error())\n+\tfor i := 1; i < len(agg); i++ {\n+\t\tresult += fmt.Sprintf(\", %s\", agg[i].Error())\n+\t}\n+\tresult += \"]\"\n+\treturn result\n+}\n+\n+func fillStaticAppInfo(store *store.Store, p *pod, v1pod *v1alpha.Pod) error {\n+\tvar errlist []error","path":"rkt/api_service.go","position":96,"original_position":96,"commit_id":"46869a97654fb3f0bf1e2c8d6209ed14aae42eb2","original_commit_id":"c34633d5ca98512504ac5d1e9b10499675dbc664","user":{"login":"yifan-gu","id":3278588,"avatar_url":"https://avatars.githubusercontent.com/u/3278588?v=3","gravatar_id":"","url":"https://api.github.com/users/yifan-gu","html_url":"https://github.com/yifan-gu","followers_url":"https://api.github.com/users/yifan-gu/followers","following_url":"https://api.github.com/users/yifan-gu/following{/other_user}","gists_url":"https://api.github.com/users/yifan-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/yifan-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifan-gu/subscriptions","organizations_url":"https://api.github.com/users/yifan-gu/orgs","repos_url":"https://api.github.com/users/yifan-gu/repos","events_url":"https://api.github.com/users/yifan-gu/events{/privacy}","received_events_url":"https://api.github.com/users/yifan-gu/received_events","type":"User","site_admin":false},"body":"@euank errwrap doesn't seem to handle a list of errors.","created_at":"2016-07-18T20:05:58Z","updated_at":"2016-07-18T20:05:58Z","html_url":"https://github.com/coreos/rkt/pull/2891#discussion_r71218989","pull_request_url":"https://api.github.com/repos/coreos/rkt/pulls/2891","_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments/71218989"},"html":{"href":"https://github.com/coreos/rkt/pull/2891#discussion_r71218989"},"pull_request":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2891"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/2891","id":76811248,"html_url":"https://github.com/coreos/rkt/pull/2891","diff_url":"https://github.com/coreos/rkt/pull/2891.diff","patch_url":"https://github.com/coreos/rkt/pull/2891.patch","issue_url":"https://api.github.com/repos/coreos/rkt/issues/2891","number":2891,"state":"open","locked":false,"title":"api_service: Cache pod manifest","user":{"login":"yifan-gu","id":3278588,"avatar_url":"https://avatars.githubusercontent.com/u/3278588?v=3","gravatar_id":"","url":"https://api.github.com/users/yifan-gu","html_url":"https://github.com/yifan-gu","followers_url":"https://api.github.com/users/yifan-gu/followers","following_url":"https://api.github.com/users/yifan-gu/following{/other_user}","gists_url":"https://api.github.com/users/yifan-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/yifan-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifan-gu/subscriptions","organizations_url":"https://api.github.com/users/yifan-gu/orgs","repos_url":"https://api.github.com/users/yifan-gu/repos","events_url":"https://api.github.com/users/yifan-gu/events{/privacy}","received_events_url":"https://api.github.com/users/yifan-gu/received_events","type":"User","site_admin":false},"body":"This PR enables rkt api service to cache pod manifest so that it will not read the disk unless:\r\n- There is a cache miss.\r\n- The pod manifest is modified on disk.\r\n\r\nRef #2877 ","created_at":"2016-07-08T20:41:04Z","updated_at":"2016-07-18T20:05:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5fcb6fb17f467fac4664c2f7be8823ea6101f6ba","assignee":{"login":"lucab","id":98086,"avatar_url":"https://avatars.githubusercontent.com/u/98086?v=3","gravatar_id":"","url":"https://api.github.com/users/lucab","html_url":"https://github.com/lucab","followers_url":"https://api.github.com/users/lucab/followers","following_url":"https://api.github.com/users/lucab/following{/other_user}","gists_url":"https://api.github.com/users/lucab/gists{/gist_id}","starred_url":"https://api.github.com/users/lucab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucab/subscriptions","organizations_url":"https://api.github.com/users/lucab/orgs","repos_url":"https://api.github.com/users/lucab/repos","events_url":"https://api.github.com/users/lucab/events{/privacy}","received_events_url":"https://api.github.com/users/lucab/received_events","type":"User","site_admin":false},"assignees":[{"login":"lucab","id":98086,"avatar_url":"https://avatars.githubusercontent.com/u/98086?v=3","gravatar_id":"","url":"https://api.github.com/users/lucab","html_url":"https://github.com/lucab","followers_url":"https://api.github.com/users/lucab/followers","following_url":"https://api.github.com/users/lucab/following{/other_user}","gists_url":"https://api.github.com/users/lucab/gists{/gist_id}","starred_url":"https://api.github.com/users/lucab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucab/subscriptions","organizations_url":"https://api.github.com/users/lucab/orgs","repos_url":"https://api.github.com/users/lucab/repos","events_url":"https://api.github.com/users/lucab/events{/privacy}","received_events_url":"https://api.github.com/users/lucab/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/coreos/rkt/milestones/43","html_url":"https://github.com/coreos/rkt/milestones/v1.11.0","labels_url":"https://api.github.com/repos/coreos/rkt/milestones/43/labels","id":1815915,"number":43,"title":"v1.11.0","description":"","creator":{"login":"lucab","id":98086,"avatar_url":"https://avatars.githubusercontent.com/u/98086?v=3","gravatar_id":"","url":"https://api.github.com/users/lucab","html_url":"https://github.com/lucab","followers_url":"https://api.github.com/users/lucab/followers","following_url":"https://api.github.com/users/lucab/following{/other_user}","gists_url":"https://api.github.com/users/lucab/gists{/gist_id}","starred_url":"https://api.github.com/users/lucab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucab/subscriptions","organizations_url":"https://api.github.com/users/lucab/orgs","repos_url":"https://api.github.com/users/lucab/repos","events_url":"https://api.github.com/users/lucab/events{/privacy}","received_events_url":"https://api.github.com/users/lucab/received_events","type":"User","site_admin":false},"open_issues":40,"closed_issues":32,"state":"open","created_at":"2016-06-08T15:21:51Z","updated_at":"2016-07-18T15:07:05Z","due_on":"2016-07-20T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/coreos/rkt/pulls/2891/commits","review_comments_url":"https://api.github.com/repos/coreos/rkt/pulls/2891/comments","review_comment_url":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/2891/comments","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/46869a97654fb3f0bf1e2c8d6209ed14aae42eb2","head":{"label":"yifan-gu:cache_manifest","ref":"cache_manifest","sha":"46869a97654fb3f0bf1e2c8d6209ed14aae42eb2","user":{"login":"yifan-gu","id":3278588,"avatar_url":"https://avatars.githubusercontent.com/u/3278588?v=3","gravatar_id":"","url":"https://api.github.com/users/yifan-gu","html_url":"https://github.com/yifan-gu","followers_url":"https://api.github.com/users/yifan-gu/followers","following_url":"https://api.github.com/users/yifan-gu/following{/other_user}","gists_url":"https://api.github.com/users/yifan-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/yifan-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifan-gu/subscriptions","organizations_url":"https://api.github.com/users/yifan-gu/orgs","repos_url":"https://api.github.com/users/yifan-gu/repos","events_url":"https://api.github.com/users/yifan-gu/events{/privacy}","received_events_url":"https://api.github.com/users/yifan-gu/received_events","type":"User","site_admin":false},"repo":{"id":31437138,"name":"rkt","full_name":"yifan-gu/rkt","owner":{"login":"yifan-gu","id":3278588,"avatar_url":"https://avatars.githubusercontent.com/u/3278588?v=3","gravatar_id":"","url":"https://api.github.com/users/yifan-gu","html_url":"https://github.com/yifan-gu","followers_url":"https://api.github.com/users/yifan-gu/followers","following_url":"https://api.github.com/users/yifan-gu/following{/other_user}","gists_url":"https://api.github.com/users/yifan-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/yifan-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifan-gu/subscriptions","organizations_url":"https://api.github.com/users/yifan-gu/orgs","repos_url":"https://api.github.com/users/yifan-gu/repos","events_url":"https://api.github.com/users/yifan-gu/events{/privacy}","received_events_url":"https://api.github.com/users/yifan-gu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yifan-gu/rkt","description":"App Container runtime","fork":true,"url":"https://api.github.com/repos/yifan-gu/rkt","forks_url":"https://api.github.com/repos/yifan-gu/rkt/forks","keys_url":"https://api.github.com/repos/yifan-gu/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yifan-gu/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yifan-gu/rkt/teams","hooks_url":"https://api.github.com/repos/yifan-gu/rkt/hooks","issue_events_url":"https://api.github.com/repos/yifan-gu/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/yifan-gu/rkt/events","assignees_url":"https://api.github.com/repos/yifan-gu/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/yifan-gu/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/yifan-gu/rkt/tags","blobs_url":"https://api.github.com/repos/yifan-gu/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yifan-gu/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yifan-gu/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/yifan-gu/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yifan-gu/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/yifan-gu/rkt/languages","stargazers_url":"https://api.github.com/repos/yifan-gu/rkt/stargazers","contributors_url":"https://api.github.com/repos/yifan-gu/rkt/contributors","subscribers_url":"https://api.github.com/repos/yifan-gu/rkt/subscribers","subscription_url":"https://api.github.com/repos/yifan-gu/rkt/subscription","commits_url":"https://api.github.com/repos/yifan-gu/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/yifan-gu/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/yifan-gu/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/yifan-gu/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/yifan-gu/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/yifan-gu/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yifan-gu/rkt/merges","archive_url":"https://api.github.com/repos/yifan-gu/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yifan-gu/rkt/downloads","issues_url":"https://api.github.com/repos/yifan-gu/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/yifan-gu/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/yifan-gu/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/yifan-gu/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yifan-gu/rkt/labels{/name}","releases_url":"https://api.github.com/repos/yifan-gu/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/yifan-gu/rkt/deployments","created_at":"2015-02-27T20:12:42Z","updated_at":"2016-04-26T23:18:30Z","pushed_at":"2016-07-18T18:36:27Z","git_url":"git://github.com/yifan-gu/rkt.git","ssh_url":"git@github.com:yifan-gu/rkt.git","clone_url":"https://github.com/yifan-gu/rkt.git","svn_url":"https://github.com/yifan-gu/rkt","homepage":"","size":24222,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"b3a9e95b688b2ec0780314b8bd627fe27008b467","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rkt","full_name":"coreos/rkt","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rkt","description":"rkt is an App Container runtime for Linux","fork":false,"url":"https://api.github.com/repos/coreos/rkt","forks_url":"https://api.github.com/repos/coreos/rkt/forks","keys_url":"https://api.github.com/repos/coreos/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rkt/teams","hooks_url":"https://api.github.com/repos/coreos/rkt/hooks","issue_events_url":"https://api.github.com/repos/coreos/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rkt/events","assignees_url":"https://api.github.com/repos/coreos/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rkt/tags","blobs_url":"https://api.github.com/repos/coreos/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rkt/languages","stargazers_url":"https://api.github.com/repos/coreos/rkt/stargazers","contributors_url":"https://api.github.com/repos/coreos/rkt/contributors","subscribers_url":"https://api.github.com/repos/coreos/rkt/subscribers","subscription_url":"https://api.github.com/repos/coreos/rkt/subscription","commits_url":"https://api.github.com/repos/coreos/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rkt/merges","archive_url":"https://api.github.com/repos/coreos/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rkt/downloads","issues_url":"https://api.github.com/repos/coreos/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rkt/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/rkt/deployments","created_at":"2014-11-11T23:13:18Z","updated_at":"2016-07-18T11:30:39Z","pushed_at":"2016-07-18T19:51:34Z","git_url":"git://github.com/coreos/rkt.git","ssh_url":"git@github.com:coreos/rkt.git","clone_url":"https://github.com/coreos/rkt.git","svn_url":"https://github.com/coreos/rkt","homepage":"","size":28965,"stargazers_count":5716,"watchers_count":5716,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":548,"mirror_url":null,"open_issues_count":344,"forks":548,"open_issues":344,"watchers":5716,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2891"},"html":{"href":"https://github.com/coreos/rkt/pull/2891"},"issue":{"href":"https://api.github.com/repos/coreos/rkt/issues/2891"},"comments":{"href":"https://api.github.com/repos/coreos/rkt/issues/2891/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2891/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2891/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rkt/statuses/46869a97654fb3f0bf1e2c8d6209ed14aae42eb2"}}}}
{"actor":{"display_login":"yifan-gu"}}