{"action":"created","comment":{"url":"https://api.github.com/repos/jquery/qunit/pulls/comments/50135217","id":50135217,"diff_hunk":"@@ -56,11 +58,14 @@ extend( QUnit, {\n \t\t\tvar module = {\n \t\t\t\tname: moduleName,\n \t\t\t\tparentModule: parentModule,\n-\t\t\t\ttests: []\n+\t\t\t\ttests: [],\n+\t\t\t\ttestsRun: 0","path":"src/core.js","position":18,"original_position":18,"commit_id":"64b93ea8e6ee59011e39e9813e5963be8e62f907","original_commit_id":"64b93ea8e6ee59011e39e9813e5963be8e62f907","user":{"login":"trentmwillis","id":3526753,"avatar_url":"https://avatars.githubusercontent.com/u/3526753?v=3","gravatar_id":"","url":"https://api.github.com/users/trentmwillis","html_url":"https://github.com/trentmwillis","followers_url":"https://api.github.com/users/trentmwillis/followers","following_url":"https://api.github.com/users/trentmwillis/following{/other_user}","gists_url":"https://api.github.com/users/trentmwillis/gists{/gist_id}","starred_url":"https://api.github.com/users/trentmwillis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trentmwillis/subscriptions","organizations_url":"https://api.github.com/users/trentmwillis/orgs","repos_url":"https://api.github.com/users/trentmwillis/repos","events_url":"https://api.github.com/users/trentmwillis/events{/privacy}","received_events_url":"https://api.github.com/users/trentmwillis/received_events","type":"User","site_admin":false},"body":"In the interim, should we proceed with this current implementation? (After I clean up the style issues, of course.)","created_at":"2016-01-19T16:27:31Z","updated_at":"2016-01-19T16:27:31Z","html_url":"https://github.com/jquery/qunit/pull/919#discussion_r50135217","pull_request_url":"https://api.github.com/repos/jquery/qunit/pulls/919","_links":{"self":{"href":"https://api.github.com/repos/jquery/qunit/pulls/comments/50135217"},"html":{"href":"https://github.com/jquery/qunit/pull/919#discussion_r50135217"},"pull_request":{"href":"https://api.github.com/repos/jquery/qunit/pulls/919"}}},"pull_request":{"url":"https://api.github.com/repos/jquery/qunit/pulls/919","id":55809293,"html_url":"https://github.com/jquery/qunit/pull/919","diff_url":"https://github.com/jquery/qunit/pull/919.diff","patch_url":"https://github.com/jquery/qunit/pull/919.patch","issue_url":"https://api.github.com/repos/jquery/qunit/issues/919","number":919,"state":"open","locked":false,"title":"[WIP] Core: Introduce before/after hooks for modules","user":{"login":"trentmwillis","id":3526753,"avatar_url":"https://avatars.githubusercontent.com/u/3526753?v=3","gravatar_id":"","url":"https://api.github.com/users/trentmwillis","html_url":"https://github.com/trentmwillis","followers_url":"https://api.github.com/users/trentmwillis/followers","following_url":"https://api.github.com/users/trentmwillis/following{/other_user}","gists_url":"https://api.github.com/users/trentmwillis/gists{/gist_id}","starred_url":"https://api.github.com/users/trentmwillis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trentmwillis/subscriptions","organizations_url":"https://api.github.com/users/trentmwillis/orgs","repos_url":"https://api.github.com/users/trentmwillis/repos","events_url":"https://api.github.com/users/trentmwillis/events{/privacy}","received_events_url":"https://api.github.com/users/trentmwillis/received_events","type":"User","site_admin":false},"body":"As discussed in #893. Included tests for the following in support of this feature:\r\n\r\n- [x] `before` runs before `beforeEach`\r\n- [x] `after` runs after `afterEach`\r\n- [x] `after` only runs after last test in module\r\n- [x] `before` only runs before first test in module\r\n- [x] first test supports `before` with a promise\r\n- [x] last test supports `after` with a promise\r\n- [x] first test supports `before` with an assert.async\r\n- [x] last test supports `after` with an assert.async\r\n- [x] support nested module `before` hooks\r\n- [x] support nested module `after` hooks\r\n- [x] context changes made in `before` are applied to all tests","created_at":"2016-01-12T20:04:24Z","updated_at":"2016-01-19T16:27:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"405ecfeda72a314b0838b9cf62b3a18bf8bc914f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jquery/qunit/pulls/919/commits","review_comments_url":"https://api.github.com/repos/jquery/qunit/pulls/919/comments","review_comment_url":"https://api.github.com/repos/jquery/qunit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jquery/qunit/issues/919/comments","statuses_url":"https://api.github.com/repos/jquery/qunit/statuses/64b93ea8e6ee59011e39e9813e5963be8e62f907","head":{"label":"trentmwillis:before-after","ref":"before-after","sha":"64b93ea8e6ee59011e39e9813e5963be8e62f907","user":{"login":"trentmwillis","id":3526753,"avatar_url":"https://avatars.githubusercontent.com/u/3526753?v=3","gravatar_id":"","url":"https://api.github.com/users/trentmwillis","html_url":"https://github.com/trentmwillis","followers_url":"https://api.github.com/users/trentmwillis/followers","following_url":"https://api.github.com/users/trentmwillis/following{/other_user}","gists_url":"https://api.github.com/users/trentmwillis/gists{/gist_id}","starred_url":"https://api.github.com/users/trentmwillis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trentmwillis/subscriptions","organizations_url":"https://api.github.com/users/trentmwillis/orgs","repos_url":"https://api.github.com/users/trentmwillis/repos","events_url":"https://api.github.com/users/trentmwillis/events{/privacy}","received_events_url":"https://api.github.com/users/trentmwillis/received_events","type":"User","site_admin":false},"repo":{"id":48075616,"name":"qunit","full_name":"trentmwillis/qunit","owner":{"login":"trentmwillis","id":3526753,"avatar_url":"https://avatars.githubusercontent.com/u/3526753?v=3","gravatar_id":"","url":"https://api.github.com/users/trentmwillis","html_url":"https://github.com/trentmwillis","followers_url":"https://api.github.com/users/trentmwillis/followers","following_url":"https://api.github.com/users/trentmwillis/following{/other_user}","gists_url":"https://api.github.com/users/trentmwillis/gists{/gist_id}","starred_url":"https://api.github.com/users/trentmwillis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trentmwillis/subscriptions","organizations_url":"https://api.github.com/users/trentmwillis/orgs","repos_url":"https://api.github.com/users/trentmwillis/repos","events_url":"https://api.github.com/users/trentmwillis/events{/privacy}","received_events_url":"https://api.github.com/users/trentmwillis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trentmwillis/qunit","description":"An easy-to-use JavaScript Unit Testing framework.","fork":true,"url":"https://api.github.com/repos/trentmwillis/qunit","forks_url":"https://api.github.com/repos/trentmwillis/qunit/forks","keys_url":"https://api.github.com/repos/trentmwillis/qunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trentmwillis/qunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trentmwillis/qunit/teams","hooks_url":"https://api.github.com/repos/trentmwillis/qunit/hooks","issue_events_url":"https://api.github.com/repos/trentmwillis/qunit/issues/events{/number}","events_url":"https://api.github.com/repos/trentmwillis/qunit/events","assignees_url":"https://api.github.com/repos/trentmwillis/qunit/assignees{/user}","branches_url":"https://api.github.com/repos/trentmwillis/qunit/branches{/branch}","tags_url":"https://api.github.com/repos/trentmwillis/qunit/tags","blobs_url":"https://api.github.com/repos/trentmwillis/qunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trentmwillis/qunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trentmwillis/qunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/trentmwillis/qunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trentmwillis/qunit/statuses/{sha}","languages_url":"https://api.github.com/repos/trentmwillis/qunit/languages","stargazers_url":"https://api.github.com/repos/trentmwillis/qunit/stargazers","contributors_url":"https://api.github.com/repos/trentmwillis/qunit/contributors","subscribers_url":"https://api.github.com/repos/trentmwillis/qunit/subscribers","subscription_url":"https://api.github.com/repos/trentmwillis/qunit/subscription","commits_url":"https://api.github.com/repos/trentmwillis/qunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/trentmwillis/qunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/trentmwillis/qunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/trentmwillis/qunit/issues/comments{/number}","contents_url":"https://api.github.com/repos/trentmwillis/qunit/contents/{+path}","compare_url":"https://api.github.com/repos/trentmwillis/qunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trentmwillis/qunit/merges","archive_url":"https://api.github.com/repos/trentmwillis/qunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trentmwillis/qunit/downloads","issues_url":"https://api.github.com/repos/trentmwillis/qunit/issues{/number}","pulls_url":"https://api.github.com/repos/trentmwillis/qunit/pulls{/number}","milestones_url":"https://api.github.com/repos/trentmwillis/qunit/milestones{/number}","notifications_url":"https://api.github.com/repos/trentmwillis/qunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trentmwillis/qunit/labels{/name}","releases_url":"https://api.github.com/repos/trentmwillis/qunit/releases{/id}","created_at":"2015-12-15T23:48:01Z","updated_at":"2016-01-12T05:11:14Z","pushed_at":"2016-01-15T22:05:49Z","git_url":"git://github.com/trentmwillis/qunit.git","ssh_url":"git@github.com:trentmwillis/qunit.git","clone_url":"https://github.com/trentmwillis/qunit.git","svn_url":"https://github.com/trentmwillis/qunit","homepage":"http://qunitjs.com","size":1460,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jquery:master","ref":"master","sha":"7c94f6f323e090e3c8174832670189d57255b69b","user":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"repo":{"id":259691,"name":"qunit","full_name":"jquery/qunit","owner":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jquery/qunit","description":"An easy-to-use JavaScript Unit Testing framework.","fork":false,"url":"https://api.github.com/repos/jquery/qunit","forks_url":"https://api.github.com/repos/jquery/qunit/forks","keys_url":"https://api.github.com/repos/jquery/qunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquery/qunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquery/qunit/teams","hooks_url":"https://api.github.com/repos/jquery/qunit/hooks","issue_events_url":"https://api.github.com/repos/jquery/qunit/issues/events{/number}","events_url":"https://api.github.com/repos/jquery/qunit/events","assignees_url":"https://api.github.com/repos/jquery/qunit/assignees{/user}","branches_url":"https://api.github.com/repos/jquery/qunit/branches{/branch}","tags_url":"https://api.github.com/repos/jquery/qunit/tags","blobs_url":"https://api.github.com/repos/jquery/qunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquery/qunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquery/qunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquery/qunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquery/qunit/statuses/{sha}","languages_url":"https://api.github.com/repos/jquery/qunit/languages","stargazers_url":"https://api.github.com/repos/jquery/qunit/stargazers","contributors_url":"https://api.github.com/repos/jquery/qunit/contributors","subscribers_url":"https://api.github.com/repos/jquery/qunit/subscribers","subscription_url":"https://api.github.com/repos/jquery/qunit/subscription","commits_url":"https://api.github.com/repos/jquery/qunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquery/qunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquery/qunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquery/qunit/issues/comments{/number}","contents_url":"https://api.github.com/repos/jquery/qunit/contents/{+path}","compare_url":"https://api.github.com/repos/jquery/qunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquery/qunit/merges","archive_url":"https://api.github.com/repos/jquery/qunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquery/qunit/downloads","issues_url":"https://api.github.com/repos/jquery/qunit/issues{/number}","pulls_url":"https://api.github.com/repos/jquery/qunit/pulls{/number}","milestones_url":"https://api.github.com/repos/jquery/qunit/milestones{/number}","notifications_url":"https://api.github.com/repos/jquery/qunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquery/qunit/labels{/name}","releases_url":"https://api.github.com/repos/jquery/qunit/releases{/id}","created_at":"2009-07-24T16:26:23Z","updated_at":"2016-01-16T15:39:01Z","pushed_at":"2016-01-19T04:37:12Z","git_url":"git://github.com/jquery/qunit.git","ssh_url":"git@github.com:jquery/qunit.git","clone_url":"https://github.com/jquery/qunit.git","svn_url":"https://github.com/jquery/qunit","homepage":"http://qunitjs.com","size":5945,"stargazers_count":3363,"watchers_count":3363,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":692,"mirror_url":null,"open_issues_count":49,"forks":692,"open_issues":49,"watchers":3363,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jquery/qunit/pulls/919"},"html":{"href":"https://github.com/jquery/qunit/pull/919"},"issue":{"href":"https://api.github.com/repos/jquery/qunit/issues/919"},"comments":{"href":"https://api.github.com/repos/jquery/qunit/issues/919/comments"},"review_comments":{"href":"https://api.github.com/repos/jquery/qunit/pulls/919/comments"},"review_comment":{"href":"https://api.github.com/repos/jquery/qunit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jquery/qunit/pulls/919/commits"},"statuses":{"href":"https://api.github.com/repos/jquery/qunit/statuses/64b93ea8e6ee59011e39e9813e5963be8e62f907"}}}}