{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/22566","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/22566/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/22566/comments","events_url":"https://api.github.com/repos/docker/docker/issues/22566/events","html_url":"https://github.com/docker/docker/pull/22566","id":153565553,"number":22566,"title":"Add config parameter to change per-container stop timeout during daemon shutdown","user":{"login":"yongtang","id":6932348,"avatar_url":"https://avatars.githubusercontent.com/u/6932348?v=3","gravatar_id":"","url":"https://api.github.com/users/yongtang","html_url":"https://github.com/yongtang","followers_url":"https://api.github.com/users/yongtang/followers","following_url":"https://api.github.com/users/yongtang/following{/other_user}","gists_url":"https://api.github.com/users/yongtang/gists{/gist_id}","starred_url":"https://api.github.com/users/yongtang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yongtang/subscriptions","organizations_url":"https://api.github.com/users/yongtang/orgs","repos_url":"https://api.github.com/users/yongtang/repos","events_url":"https://api.github.com/users/yongtang/events{/privacy}","received_events_url":"https://api.github.com/users/yongtang/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/impact/api","name":"impact/api","color":"bfe5bf"},{"url":"https://api.github.com/repos/docker/docker/labels/impact/changelog","name":"impact/changelog","color":"bfe5bf"},{"url":"https://api.github.com/repos/docker/docker/labels/impact/cli","name":"impact/cli","color":"bfe5bf"},{"url":"https://api.github.com/repos/docker/docker/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/56","html_url":"https://github.com/docker/docker/milestones/1.13.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/56/labels","id":1839404,"number":56,"title":"1.13.0","description":"","creator":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"open_issues":62,"closed_issues":29,"state":"open","created_at":"2016-06-20T22:51:25Z","updated_at":"2016-07-29T12:04:54Z","due_on":null,"closed_at":null},"comments":41,"created_at":"2016-05-07T01:29:03Z","updated_at":"2016-07-29T14:21:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/22566","html_url":"https://github.com/docker/docker/pull/22566","diff_url":"https://github.com/docker/docker/pull/22566.diff","patch_url":"https://github.com/docker/docker/pull/22566.patch"},"body":"**- What I did**\r\n\r\nThis fix tries to add a flag `--stop-timeout` to specify the timeout value (in seconds) for the container to stop before SIGKILL is issued. If stop timeout is not specified then the default timeout (10s) is used.\r\n\r\n**- How I did it**\r\n\r\nThe `--stop-timeout` has been added to `docker create` and `docker run`.\r\n\r\n**- How to verify it**\r\n\r\nAdditional test cases have been added to cover the change.\r\n\r\n**- Description for the changelog**\r\n\r\nAdded a lag `--stop-timeout` to specify the timeout value (in seconds) for the container to stop.\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n\r\nThis fix is related to #22471.\r\n\r\n**NOTE: Pull requests have been created in engine-api:**\r\nhttps://github.com/docker/engine-api/pull/256\r\nhttps://github.com/docker/engine-api/pull/271\r\n\r\n**NOTE: Another pull request (#23036) has been opened to add `--shutdown-timeout` to daemon**\r\n\r\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/236193494","html_url":"https://github.com/docker/docker/pull/22566#issuecomment-236193494","issue_url":"https://api.github.com/repos/docker/docker/issues/22566","id":236193494,"user":{"login":"yongtang","id":6932348,"avatar_url":"https://avatars.githubusercontent.com/u/6932348?v=3","gravatar_id":"","url":"https://api.github.com/users/yongtang","html_url":"https://github.com/yongtang","followers_url":"https://api.github.com/users/yongtang/followers","following_url":"https://api.github.com/users/yongtang/following{/other_user}","gists_url":"https://api.github.com/users/yongtang/gists{/gist_id}","starred_url":"https://api.github.com/users/yongtang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yongtang/subscriptions","organizations_url":"https://api.github.com/users/yongtang/orgs","repos_url":"https://api.github.com/users/yongtang/repos","events_url":"https://api.github.com/users/yongtang/events{/privacy}","received_events_url":"https://api.github.com/users/yongtang/received_events","type":"User","site_admin":false},"created_at":"2016-07-29T14:21:57Z","updated_at":"2016-07-29T14:21:57Z","body":"Thanks @thaJeztah, rebased :smiley:."}}
{"actor":{"display_login":"yongtang"}}