{"action":"created","comment":{"url":"https://api.github.com/repos/facebookincubator/create-react-app/pulls/comments/79833848","id":79833848,"diff_hunk":"@@ -0,0 +1,25 @@\n+# eslint-config-react-app\n+\n+This package includes the shareable ESLint configuration used by [Create React App](https://github.com/facebookincubator/create-react-app).\n+\n+## Installation\n+\n+*The easiest way to use this configuration is with [Create React App](https://github.com/facebookincubator/create-react-app), which includes it by default – you* **don't need to install it separately in Create React App projects.**\n+\n+If you want to use this ESLint configuration in a project not built with Create React App, you can install it with following steps.\n+\n+1. Install this package, ESLint and the necessary plugins:\n+\n+  ```\n+  npm install eslint-config-react-app babel-eslint@6.1.2 eslint@3.5.0 eslint-plugin-flowtype@2.18.1 eslint-plugin-import@1.12.0 eslint-plugin-jsx-a11y@2.2.2 eslint-plugin-react@5.2.2 --save-dev","path":"packages/eslint-config-react-app/README.md","position":null,"original_position":14,"commit_id":"5c4458c0ea8075bf2dda208c671624cb428e8568","original_commit_id":"cfa6880523e4b000871debcdfe8c1cee8f4b745a","user":{"login":"fson","id":497214,"avatar_url":"https://avatars.githubusercontent.com/u/497214?v=3","gravatar_id":"","url":"https://api.github.com/users/fson","html_url":"https://github.com/fson","followers_url":"https://api.github.com/users/fson/followers","following_url":"https://api.github.com/users/fson/following{/other_user}","gists_url":"https://api.github.com/users/fson/gists{/gist_id}","starred_url":"https://api.github.com/users/fson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fson/subscriptions","organizations_url":"https://api.github.com/users/fson/orgs","repos_url":"https://api.github.com/users/fson/repos","events_url":"https://api.github.com/users/fson/events{/privacy}","received_events_url":"https://api.github.com/users/fson/received_events","type":"User","site_admin":false},"body":"I think having the command that you can copy paste to your console here is better than that trick, as long as we keep the version numbers up-to-date. It's a bit more work for us, but easier for the users.","created_at":"2016-09-21T13:35:11Z","updated_at":"2016-09-21T13:35:11Z","html_url":"https://github.com/facebookincubator/create-react-app/pull/689#discussion_r79833848","pull_request_url":"https://api.github.com/repos/facebookincubator/create-react-app/pulls/689","_links":{"self":{"href":"https://api.github.com/repos/facebookincubator/create-react-app/pulls/comments/79833848"},"html":{"href":"https://github.com/facebookincubator/create-react-app/pull/689#discussion_r79833848"},"pull_request":{"href":"https://api.github.com/repos/facebookincubator/create-react-app/pulls/689"}}},"pull_request":{"url":"https://api.github.com/repos/facebookincubator/create-react-app/pulls/689","id":86059562,"html_url":"https://github.com/facebookincubator/create-react-app/pull/689","diff_url":"https://github.com/facebookincubator/create-react-app/pull/689.diff","patch_url":"https://github.com/facebookincubator/create-react-app/pull/689.patch","issue_url":"https://api.github.com/repos/facebookincubator/create-react-app/issues/689","number":689,"state":"open","locked":false,"title":"Create a shareable ESLint configuration package","user":{"login":"fson","id":497214,"avatar_url":"https://avatars.githubusercontent.com/u/497214?v=3","gravatar_id":"","url":"https://api.github.com/users/fson","html_url":"https://github.com/fson","followers_url":"https://api.github.com/users/fson/followers","following_url":"https://api.github.com/users/fson/following{/other_user}","gists_url":"https://api.github.com/users/fson/gists{/gist_id}","starred_url":"https://api.github.com/users/fson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fson/subscriptions","organizations_url":"https://api.github.com/users/fson/orgs","repos_url":"https://api.github.com/users/fson/repos","events_url":"https://api.github.com/users/fson/events{/privacy}","received_events_url":"https://api.github.com/users/fson/received_events","type":"User","site_admin":false},"body":"Move the ESLint configuration to a separate package `eslint-config-react-app`. This allows using the same configuration in projects not using CRA. It also makes the amount of configuration in an ejected project smaller: the starter ESLint config of an ejected the project will be just `{\"extends\": \"react-app\"}`.\r\n\r\nTest plan:\r\n[x] Check that linting errors are shown correctly when running `npm start`.\r\n[x] Check that it also works end to end. (Tested with a local npm server.)\r\n\r\n(NB: the e2e test will break at the moment because the package hasn't been published yet, and it tries to install it from npm. However, I tested by publishing it to a local npm registry with sinopia, and it worked. I think we might want to come up with a way to end-to-end test all the packages together without having to manually pack all of them in the test script. But for now pulling the linter config from npm is probably good enough?)","created_at":"2016-09-20T21:26:51Z","updated_at":"2016-09-21T13:35:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fda779862d91d7530356ccb7625bc5a1605cf183","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/facebookincubator/create-react-app/milestones/11","html_url":"https://github.com/facebookincubator/create-react-app/milestones/0.5.0","labels_url":"https://api.github.com/repos/facebookincubator/create-react-app/milestones/11/labels","id":1985811,"number":11,"title":"0.5.0","description":"","creator":{"login":"gaearon","id":810438,"avatar_url":"https://avatars.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":2,"state":"open","created_at":"2016-09-06T10:04:55Z","updated_at":"2016-09-21T13:06:07Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/facebookincubator/create-react-app/pulls/689/commits","review_comments_url":"https://api.github.com/repos/facebookincubator/create-react-app/pulls/689/comments","review_comment_url":"https://api.github.com/repos/facebookincubator/create-react-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebookincubator/create-react-app/issues/689/comments","statuses_url":"https://api.github.com/repos/facebookincubator/create-react-app/statuses/5c4458c0ea8075bf2dda208c671624cb428e8568","head":{"label":"fson:eslint-config-react-app","ref":"eslint-config-react-app","sha":"5c4458c0ea8075bf2dda208c671624cb428e8568","user":{"login":"fson","id":497214,"avatar_url":"https://avatars.githubusercontent.com/u/497214?v=3","gravatar_id":"","url":"https://api.github.com/users/fson","html_url":"https://github.com/fson","followers_url":"https://api.github.com/users/fson/followers","following_url":"https://api.github.com/users/fson/following{/other_user}","gists_url":"https://api.github.com/users/fson/gists{/gist_id}","starred_url":"https://api.github.com/users/fson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fson/subscriptions","organizations_url":"https://api.github.com/users/fson/orgs","repos_url":"https://api.github.com/users/fson/repos","events_url":"https://api.github.com/users/fson/events{/privacy}","received_events_url":"https://api.github.com/users/fson/received_events","type":"User","site_admin":false},"repo":{"id":64783960,"name":"create-react-app","full_name":"fson/create-react-app","owner":{"login":"fson","id":497214,"avatar_url":"https://avatars.githubusercontent.com/u/497214?v=3","gravatar_id":"","url":"https://api.github.com/users/fson","html_url":"https://github.com/fson","followers_url":"https://api.github.com/users/fson/followers","following_url":"https://api.github.com/users/fson/following{/other_user}","gists_url":"https://api.github.com/users/fson/gists{/gist_id}","starred_url":"https://api.github.com/users/fson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fson/subscriptions","organizations_url":"https://api.github.com/users/fson/orgs","repos_url":"https://api.github.com/users/fson/repos","events_url":"https://api.github.com/users/fson/events{/privacy}","received_events_url":"https://api.github.com/users/fson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fson/create-react-app","description":"Create React apps with no build configuration.","fork":true,"url":"https://api.github.com/repos/fson/create-react-app","forks_url":"https://api.github.com/repos/fson/create-react-app/forks","keys_url":"https://api.github.com/repos/fson/create-react-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fson/create-react-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fson/create-react-app/teams","hooks_url":"https://api.github.com/repos/fson/create-react-app/hooks","issue_events_url":"https://api.github.com/repos/fson/create-react-app/issues/events{/number}","events_url":"https://api.github.com/repos/fson/create-react-app/events","assignees_url":"https://api.github.com/repos/fson/create-react-app/assignees{/user}","branches_url":"https://api.github.com/repos/fson/create-react-app/branches{/branch}","tags_url":"https://api.github.com/repos/fson/create-react-app/tags","blobs_url":"https://api.github.com/repos/fson/create-react-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fson/create-react-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fson/create-react-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/fson/create-react-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fson/create-react-app/statuses/{sha}","languages_url":"https://api.github.com/repos/fson/create-react-app/languages","stargazers_url":"https://api.github.com/repos/fson/create-react-app/stargazers","contributors_url":"https://api.github.com/repos/fson/create-react-app/contributors","subscribers_url":"https://api.github.com/repos/fson/create-react-app/subscribers","subscription_url":"https://api.github.com/repos/fson/create-react-app/subscription","commits_url":"https://api.github.com/repos/fson/create-react-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/fson/create-react-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/fson/create-react-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/fson/create-react-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/fson/create-react-app/contents/{+path}","compare_url":"https://api.github.com/repos/fson/create-react-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fson/create-react-app/merges","archive_url":"https://api.github.com/repos/fson/create-react-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fson/create-react-app/downloads","issues_url":"https://api.github.com/repos/fson/create-react-app/issues{/number}","pulls_url":"https://api.github.com/repos/fson/create-react-app/pulls{/number}","milestones_url":"https://api.github.com/repos/fson/create-react-app/milestones{/number}","notifications_url":"https://api.github.com/repos/fson/create-react-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fson/create-react-app/labels{/name}","releases_url":"https://api.github.com/repos/fson/create-react-app/releases{/id}","deployments_url":"https://api.github.com/repos/fson/create-react-app/deployments","created_at":"2016-08-02T18:55:19Z","updated_at":"2016-08-02T18:55:21Z","pushed_at":"2016-09-21T13:16:23Z","git_url":"git://github.com/fson/create-react-app.git","ssh_url":"git@github.com:fson/create-react-app.git","clone_url":"https://github.com/fson/create-react-app.git","svn_url":"https://github.com/fson/create-react-app","homepage":null,"size":836,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebookincubator:master","ref":"master","sha":"07623e2f8463277731f9a00d5808079a18990492","user":{"login":"facebookincubator","id":19538647,"avatar_url":"https://avatars.githubusercontent.com/u/19538647?v=3","gravatar_id":"","url":"https://api.github.com/users/facebookincubator","html_url":"https://github.com/facebookincubator","followers_url":"https://api.github.com/users/facebookincubator/followers","following_url":"https://api.github.com/users/facebookincubator/following{/other_user}","gists_url":"https://api.github.com/users/facebookincubator/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookincubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookincubator/subscriptions","organizations_url":"https://api.github.com/users/facebookincubator/orgs","repos_url":"https://api.github.com/users/facebookincubator/repos","events_url":"https://api.github.com/users/facebookincubator/events{/privacy}","received_events_url":"https://api.github.com/users/facebookincubator/received_events","type":"Organization","site_admin":false},"repo":{"id":63537249,"name":"create-react-app","full_name":"facebookincubator/create-react-app","owner":{"login":"facebookincubator","id":19538647,"avatar_url":"https://avatars.githubusercontent.com/u/19538647?v=3","gravatar_id":"","url":"https://api.github.com/users/facebookincubator","html_url":"https://github.com/facebookincubator","followers_url":"https://api.github.com/users/facebookincubator/followers","following_url":"https://api.github.com/users/facebookincubator/following{/other_user}","gists_url":"https://api.github.com/users/facebookincubator/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookincubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookincubator/subscriptions","organizations_url":"https://api.github.com/users/facebookincubator/orgs","repos_url":"https://api.github.com/users/facebookincubator/repos","events_url":"https://api.github.com/users/facebookincubator/events{/privacy}","received_events_url":"https://api.github.com/users/facebookincubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebookincubator/create-react-app","description":"Create React apps with no build configuration.","fork":false,"url":"https://api.github.com/repos/facebookincubator/create-react-app","forks_url":"https://api.github.com/repos/facebookincubator/create-react-app/forks","keys_url":"https://api.github.com/repos/facebookincubator/create-react-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebookincubator/create-react-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebookincubator/create-react-app/teams","hooks_url":"https://api.github.com/repos/facebookincubator/create-react-app/hooks","issue_events_url":"https://api.github.com/repos/facebookincubator/create-react-app/issues/events{/number}","events_url":"https://api.github.com/repos/facebookincubator/create-react-app/events","assignees_url":"https://api.github.com/repos/facebookincubator/create-react-app/assignees{/user}","branches_url":"https://api.github.com/repos/facebookincubator/create-react-app/branches{/branch}","tags_url":"https://api.github.com/repos/facebookincubator/create-react-app/tags","blobs_url":"https://api.github.com/repos/facebookincubator/create-react-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebookincubator/create-react-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebookincubator/create-react-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebookincubator/create-react-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebookincubator/create-react-app/statuses/{sha}","languages_url":"https://api.github.com/repos/facebookincubator/create-react-app/languages","stargazers_url":"https://api.github.com/repos/facebookincubator/create-react-app/stargazers","contributors_url":"https://api.github.com/repos/facebookincubator/create-react-app/contributors","subscribers_url":"https://api.github.com/repos/facebookincubator/create-react-app/subscribers","subscription_url":"https://api.github.com/repos/facebookincubator/create-react-app/subscription","commits_url":"https://api.github.com/repos/facebookincubator/create-react-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebookincubator/create-react-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebookincubator/create-react-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebookincubator/create-react-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebookincubator/create-react-app/contents/{+path}","compare_url":"https://api.github.com/repos/facebookincubator/create-react-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebookincubator/create-react-app/merges","archive_url":"https://api.github.com/repos/facebookincubator/create-react-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebookincubator/create-react-app/downloads","issues_url":"https://api.github.com/repos/facebookincubator/create-react-app/issues{/number}","pulls_url":"https://api.github.com/repos/facebookincubator/create-react-app/pulls{/number}","milestones_url":"https://api.github.com/repos/facebookincubator/create-react-app/milestones{/number}","notifications_url":"https://api.github.com/repos/facebookincubator/create-react-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebookincubator/create-react-app/labels{/name}","releases_url":"https://api.github.com/repos/facebookincubator/create-react-app/releases{/id}","deployments_url":"https://api.github.com/repos/facebookincubator/create-react-app/deployments","created_at":"2016-07-17T14:55:11Z","updated_at":"2016-09-21T13:33:53Z","pushed_at":"2016-09-21T13:16:24Z","git_url":"git://github.com/facebookincubator/create-react-app.git","ssh_url":"git@github.com:facebookincubator/create-react-app.git","clone_url":"https://github.com/facebookincubator/create-react-app.git","svn_url":"https://github.com/facebookincubator/create-react-app","homepage":null,"size":1981,"stargazers_count":11190,"watchers_count":11190,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":814,"mirror_url":null,"open_issues_count":100,"forks":814,"open_issues":100,"watchers":11190,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebookincubator/create-react-app/pulls/689"},"html":{"href":"https://github.com/facebookincubator/create-react-app/pull/689"},"issue":{"href":"https://api.github.com/repos/facebookincubator/create-react-app/issues/689"},"comments":{"href":"https://api.github.com/repos/facebookincubator/create-react-app/issues/689/comments"},"review_comments":{"href":"https://api.github.com/repos/facebookincubator/create-react-app/pulls/689/comments"},"review_comment":{"href":"https://api.github.com/repos/facebookincubator/create-react-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebookincubator/create-react-app/pulls/689/commits"},"statuses":{"href":"https://api.github.com/repos/facebookincubator/create-react-app/statuses/5c4458c0ea8075bf2dda208c671624cb428e8568"}}}}
{"actor":{"display_login":"fson"}}