{"comment":{"url":"https://api.github.com/repos/niksu/pax/comments/18311605","html_url":"https://github.com/niksu/pax/commit/89b70e202a0898d977b8ea763d949784c1476a48#commitcomment-18311605","id":18311605,"user":{"login":"niksu","id":1102670,"avatar_url":"https://avatars.githubusercontent.com/u/1102670?v=3","gravatar_id":"","url":"https://api.github.com/users/niksu","html_url":"https://github.com/niksu","followers_url":"https://api.github.com/users/niksu/followers","following_url":"https://api.github.com/users/niksu/following{/other_user}","gists_url":"https://api.github.com/users/niksu/gists{/gist_id}","starred_url":"https://api.github.com/users/niksu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niksu/subscriptions","organizations_url":"https://api.github.com/users/niksu/orgs","repos_url":"https://api.github.com/users/niksu/repos","events_url":"https://api.github.com/users/niksu/events{/privacy}","received_events_url":"https://api.github.com/users/niksu/received_events","type":"User","site_admin":false},"position":124,"line":153,"path":"examples/nat_scapy_tests.py","commit_id":"89b70e202a0898d977b8ea763d949784c1476a48","created_at":"2016-07-20T07:47:31Z","updated_at":"2016-07-20T07:47:31Z","body":"Have you considered having a variable in the Python variable called `tcp_time_wait_duration`, with a comment saying that it's supposed to be associated with a variable appearing in the configuration of the NAT, and then replacing the literal 5s instances with references to this variable?\r\nThat is, using the variable in the comment, in the print statement, and as an argument to `time.sleep(-)`.\r\nThis would make it easier to change the script to work with tests of different durations, and having the other bits (e.g., printed statement) stay in synch.\r\n\r\nAlso, since the print statement and the comment preceding it seem to say the same thing, I'd fuse the contents of the comment into the print statement."}}
{"actor":{"display_login":"niksu"}}