{"action":"opened","number":1285,"pull_request":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/1285","id":89221867,"html_url":"https://github.com/Homebrew/brew/pull/1285","diff_url":"https://github.com/Homebrew/brew/pull/1285.diff","patch_url":"https://github.com/Homebrew/brew/pull/1285.patch","issue_url":"https://api.github.com/repos/Homebrew/brew/issues/1285","number":1285,"state":"open","locked":false,"title":"brew doctor: warn about SSL_CERT_FILE (#1284)","user":{"login":"Blaisorblade","id":289960,"avatar_url":"https://avatars.githubusercontent.com/u/289960?v=3","gravatar_id":"","url":"https://api.github.com/users/Blaisorblade","html_url":"https://github.com/Blaisorblade","followers_url":"https://api.github.com/users/Blaisorblade/followers","following_url":"https://api.github.com/users/Blaisorblade/following{/other_user}","gists_url":"https://api.github.com/users/Blaisorblade/gists{/gist_id}","starred_url":"https://api.github.com/users/Blaisorblade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blaisorblade/subscriptions","organizations_url":"https://api.github.com/users/Blaisorblade/orgs","repos_url":"https://api.github.com/users/Blaisorblade/repos","events_url":"https://api.github.com/users/Blaisorblade/events{/privacy}","received_events_url":"https://api.github.com/users/Blaisorblade/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/brew/blob/master/CONTRIBUTING.md) document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/brew/pulls) for the same change?\r\n- [x] Have you added an explanation of what your changes do and why you'd like us to include them?\r\n- [ ] Have you written new tests for your changes? [Here's an example](https://github.com/Homebrew/homebrew/pull/49031).\r\n- [x] Have you successfully run `brew tests` with your changes locally? (Got some warnings about skipped tests).\r\n\r\n-----\r\n\r\nMultiple issues have been filed about this environment variable, hence\r\ngive a warning. #932 might make this unnecessary when merged, but\r\nhopefully this warning can be merged quickly.\r\n\r\nWarnings:\r\n- I'm no expert rubyist so the code might be more convoluted than needed (do I really need to assign to `message` before returning it, can't I just return `<<-EOS.undent...` somehow?)\r\n- my local testing is `SSL_CERT_FILE=a brew doctor` and `brew doctor` (with `SSL_CERT_FILE` unset). If you want a unit test for that I'm happy to.\r\n- My explanation on system curl's behavior might be too much, I'm happy to drop it. It's based on the comment in https://github.com/NixOS/nix/issues/921#issuecomment-241675652 and on the pointed to blog post (https://docwhat.org/el-capitan-and-the-evils-of-openssl/).","created_at":"2016-10-13T15:09:24Z","updated_at":"2016-10-13T15:09:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5be8a4152d48c0c1cb3d26b3a29041503b02de1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/brew/pulls/1285/commits","review_comments_url":"https://api.github.com/repos/Homebrew/brew/pulls/1285/comments","review_comment_url":"https://api.github.com/repos/Homebrew/brew/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/brew/issues/1285/comments","statuses_url":"https://api.github.com/repos/Homebrew/brew/statuses/9420cf1735fb1085c85d173254eecf69ba2f0ada","head":{"label":"Blaisorblade:doctor-ssl-env","ref":"doctor-ssl-env","sha":"9420cf1735fb1085c85d173254eecf69ba2f0ada","user":{"login":"Blaisorblade","id":289960,"avatar_url":"https://avatars.githubusercontent.com/u/289960?v=3","gravatar_id":"","url":"https://api.github.com/users/Blaisorblade","html_url":"https://github.com/Blaisorblade","followers_url":"https://api.github.com/users/Blaisorblade/followers","following_url":"https://api.github.com/users/Blaisorblade/following{/other_user}","gists_url":"https://api.github.com/users/Blaisorblade/gists{/gist_id}","starred_url":"https://api.github.com/users/Blaisorblade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blaisorblade/subscriptions","organizations_url":"https://api.github.com/users/Blaisorblade/orgs","repos_url":"https://api.github.com/users/Blaisorblade/repos","events_url":"https://api.github.com/users/Blaisorblade/events{/privacy}","received_events_url":"https://api.github.com/users/Blaisorblade/received_events","type":"User","site_admin":false},"repo":{"id":58770106,"name":"brew","full_name":"Blaisorblade/brew","owner":{"login":"Blaisorblade","id":289960,"avatar_url":"https://avatars.githubusercontent.com/u/289960?v=3","gravatar_id":"","url":"https://api.github.com/users/Blaisorblade","html_url":"https://github.com/Blaisorblade","followers_url":"https://api.github.com/users/Blaisorblade/followers","following_url":"https://api.github.com/users/Blaisorblade/following{/other_user}","gists_url":"https://api.github.com/users/Blaisorblade/gists{/gist_id}","starred_url":"https://api.github.com/users/Blaisorblade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blaisorblade/subscriptions","organizations_url":"https://api.github.com/users/Blaisorblade/orgs","repos_url":"https://api.github.com/users/Blaisorblade/repos","events_url":"https://api.github.com/users/Blaisorblade/events{/privacy}","received_events_url":"https://api.github.com/users/Blaisorblade/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Blaisorblade/brew","description":":beer: The missing package manager for OS X","fork":true,"url":"https://api.github.com/repos/Blaisorblade/brew","forks_url":"https://api.github.com/repos/Blaisorblade/brew/forks","keys_url":"https://api.github.com/repos/Blaisorblade/brew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Blaisorblade/brew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Blaisorblade/brew/teams","hooks_url":"https://api.github.com/repos/Blaisorblade/brew/hooks","issue_events_url":"https://api.github.com/repos/Blaisorblade/brew/issues/events{/number}","events_url":"https://api.github.com/repos/Blaisorblade/brew/events","assignees_url":"https://api.github.com/repos/Blaisorblade/brew/assignees{/user}","branches_url":"https://api.github.com/repos/Blaisorblade/brew/branches{/branch}","tags_url":"https://api.github.com/repos/Blaisorblade/brew/tags","blobs_url":"https://api.github.com/repos/Blaisorblade/brew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Blaisorblade/brew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Blaisorblade/brew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Blaisorblade/brew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Blaisorblade/brew/statuses/{sha}","languages_url":"https://api.github.com/repos/Blaisorblade/brew/languages","stargazers_url":"https://api.github.com/repos/Blaisorblade/brew/stargazers","contributors_url":"https://api.github.com/repos/Blaisorblade/brew/contributors","subscribers_url":"https://api.github.com/repos/Blaisorblade/brew/subscribers","subscription_url":"https://api.github.com/repos/Blaisorblade/brew/subscription","commits_url":"https://api.github.com/repos/Blaisorblade/brew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Blaisorblade/brew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Blaisorblade/brew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Blaisorblade/brew/issues/comments{/number}","contents_url":"https://api.github.com/repos/Blaisorblade/brew/contents/{+path}","compare_url":"https://api.github.com/repos/Blaisorblade/brew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Blaisorblade/brew/merges","archive_url":"https://api.github.com/repos/Blaisorblade/brew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Blaisorblade/brew/downloads","issues_url":"https://api.github.com/repos/Blaisorblade/brew/issues{/number}","pulls_url":"https://api.github.com/repos/Blaisorblade/brew/pulls{/number}","milestones_url":"https://api.github.com/repos/Blaisorblade/brew/milestones{/number}","notifications_url":"https://api.github.com/repos/Blaisorblade/brew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Blaisorblade/brew/labels{/name}","releases_url":"https://api.github.com/repos/Blaisorblade/brew/releases{/id}","deployments_url":"https://api.github.com/repos/Blaisorblade/brew/deployments","created_at":"2016-05-13T20:24:03Z","updated_at":"2016-05-13T20:24:05Z","pushed_at":"2016-10-13T14:39:55Z","git_url":"git://github.com/Blaisorblade/brew.git","ssh_url":"git@github.com:Blaisorblade/brew.git","clone_url":"https://github.com/Blaisorblade/brew.git","svn_url":"https://github.com/Blaisorblade/brew","homepage":"http://brew.sh","size":9751,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"8d6921d7f3bfc7be5770cfe2a30791e9a35d9cc2","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":53238813,"name":"brew","full_name":"Homebrew/brew","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/brew","description":":beer: The missing package manager for macOS","fork":false,"url":"https://api.github.com/repos/Homebrew/brew","forks_url":"https://api.github.com/repos/Homebrew/brew/forks","keys_url":"https://api.github.com/repos/Homebrew/brew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/brew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/brew/teams","hooks_url":"https://api.github.com/repos/Homebrew/brew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/brew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/brew/events","assignees_url":"https://api.github.com/repos/Homebrew/brew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/brew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/brew/tags","blobs_url":"https://api.github.com/repos/Homebrew/brew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/brew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/brew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/brew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/brew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/brew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/brew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/brew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/brew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/brew/subscription","commits_url":"https://api.github.com/repos/Homebrew/brew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/brew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/brew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/brew/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/brew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/brew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/brew/merges","archive_url":"https://api.github.com/repos/Homebrew/brew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/brew/downloads","issues_url":"https://api.github.com/repos/Homebrew/brew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/brew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/brew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/brew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/brew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/brew/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/brew/deployments","created_at":"2016-03-06T05:08:38Z","updated_at":"2016-10-13T15:08:48Z","pushed_at":"2016-10-13T15:09:24Z","git_url":"git://github.com/Homebrew/brew.git","ssh_url":"git@github.com:Homebrew/brew.git","clone_url":"https://github.com/Homebrew/brew.git","svn_url":"https://github.com/Homebrew/brew","homepage":"http://brew.sh","size":18065,"stargazers_count":4009,"watchers_count":4009,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1100,"mirror_url":null,"open_issues_count":40,"forks":1100,"open_issues":40,"watchers":4009,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/1285"},"html":{"href":"https://github.com/Homebrew/brew/pull/1285"},"issue":{"href":"https://api.github.com/repos/Homebrew/brew/issues/1285"},"comments":{"href":"https://api.github.com/repos/Homebrew/brew/issues/1285/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/1285/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/1285/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/brew/statuses/9420cf1735fb1085c85d173254eecf69ba2f0ada"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":12,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"Blaisorblade"}}