{"action":"closed","number":4110,"pull_request":{"url":"https://api.github.com/repos/haskell/cabal/pulls/4110","id":93497723,"html_url":"https://github.com/haskell/cabal/pull/4110","diff_url":"https://github.com/haskell/cabal/pull/4110.diff","patch_url":"https://github.com/haskell/cabal/pull/4110.patch","issue_url":"https://api.github.com/repos/haskell/cabal/issues/4110","number":4110,"state":"closed","locked":false,"title":"Solver: Fix space leak in 'addlinking' (issue #2899).","user":{"login":"grayjay","id":4276753,"avatar_url":"https://avatars.githubusercontent.com/u/4276753?v=3","gravatar_id":"","url":"https://api.github.com/users/grayjay","html_url":"https://github.com/grayjay","followers_url":"https://api.github.com/users/grayjay/followers","following_url":"https://api.github.com/users/grayjay/following{/other_user}","gists_url":"https://api.github.com/users/grayjay/gists{/gist_id}","starred_url":"https://api.github.com/users/grayjay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grayjay/subscriptions","organizations_url":"https://api.github.com/users/grayjay/orgs","repos_url":"https://api.github.com/users/grayjay/repos","events_url":"https://api.github.com/users/grayjay/events{/privacy}","received_events_url":"https://api.github.com/users/grayjay/received_events","type":"User","site_admin":false},"body":"The solver creates linked nodes by copying existing unlinked nodes. Previously,\r\nthe subtrees shared data, which caused a space leak. This commit combines the\r\n\"build\" and \"addLinking\" tree traversals so that the nodes are copied before\r\nthey are expanded into full trees.\r\n\r\nThis should prevent sharing more reliably than my previous PR, #3530.\r\n\r\nI'd like to add a regression test, but I'm not sure how to do it without significantly lengthening the build.  I wrote a test with the solver DSL (https://github.com/grayjay/cabal/commit/1f1b95d7b4d836ac79a60f943bb36e0ac6ef41e8) that fails when I limit the heap size.  Do you think we should add another test suite that we run with a limited heap?  I can't add the test to the existing unit test suite, because some of the quickcheck tests already cause spikes in memory usage.\r\n\r\nEDIT: The diff for the main commit isn't aligned well, so here is a diff with different options: https://rawgit.com/grayjay/9d842a8c8c1b04b1a1f0d8eca4a8a2ad/raw/467ffdf7b523272a5a7118f940af9e7f2634a0eb/cabal-pr-4110.html","created_at":"2016-11-14T01:51:03Z","updated_at":"2016-12-01T12:14:56Z","closed_at":"2016-12-01T12:14:56Z","merged_at":"2016-12-01T12:14:56Z","merge_commit_sha":"93d8e10af734166cffe68e9b668c95a87db4e999","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/haskell/cabal/pulls/4110/commits","review_comments_url":"https://api.github.com/repos/haskell/cabal/pulls/4110/comments","review_comment_url":"https://api.github.com/repos/haskell/cabal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haskell/cabal/issues/4110/comments","statuses_url":"https://api.github.com/repos/haskell/cabal/statuses/0f6dbce99987d647bc8dad17596fc7eb1d2c360e","head":{"label":"grayjay:issue-2899-2","ref":"issue-2899-2","sha":"0f6dbce99987d647bc8dad17596fc7eb1d2c360e","user":{"login":"grayjay","id":4276753,"avatar_url":"https://avatars.githubusercontent.com/u/4276753?v=3","gravatar_id":"","url":"https://api.github.com/users/grayjay","html_url":"https://github.com/grayjay","followers_url":"https://api.github.com/users/grayjay/followers","following_url":"https://api.github.com/users/grayjay/following{/other_user}","gists_url":"https://api.github.com/users/grayjay/gists{/gist_id}","starred_url":"https://api.github.com/users/grayjay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grayjay/subscriptions","organizations_url":"https://api.github.com/users/grayjay/orgs","repos_url":"https://api.github.com/users/grayjay/repos","events_url":"https://api.github.com/users/grayjay/events{/privacy}","received_events_url":"https://api.github.com/users/grayjay/received_events","type":"User","site_admin":false},"repo":{"id":37628967,"name":"cabal","full_name":"grayjay/cabal","owner":{"login":"grayjay","id":4276753,"avatar_url":"https://avatars.githubusercontent.com/u/4276753?v=3","gravatar_id":"","url":"https://api.github.com/users/grayjay","html_url":"https://github.com/grayjay","followers_url":"https://api.github.com/users/grayjay/followers","following_url":"https://api.github.com/users/grayjay/following{/other_user}","gists_url":"https://api.github.com/users/grayjay/gists{/gist_id}","starred_url":"https://api.github.com/users/grayjay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grayjay/subscriptions","organizations_url":"https://api.github.com/users/grayjay/orgs","repos_url":"https://api.github.com/users/grayjay/repos","events_url":"https://api.github.com/users/grayjay/events{/privacy}","received_events_url":"https://api.github.com/users/grayjay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grayjay/cabal","description":"Official upstream development repository for Cabal and cabal-install","fork":true,"url":"https://api.github.com/repos/grayjay/cabal","forks_url":"https://api.github.com/repos/grayjay/cabal/forks","keys_url":"https://api.github.com/repos/grayjay/cabal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grayjay/cabal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grayjay/cabal/teams","hooks_url":"https://api.github.com/repos/grayjay/cabal/hooks","issue_events_url":"https://api.github.com/repos/grayjay/cabal/issues/events{/number}","events_url":"https://api.github.com/repos/grayjay/cabal/events","assignees_url":"https://api.github.com/repos/grayjay/cabal/assignees{/user}","branches_url":"https://api.github.com/repos/grayjay/cabal/branches{/branch}","tags_url":"https://api.github.com/repos/grayjay/cabal/tags","blobs_url":"https://api.github.com/repos/grayjay/cabal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grayjay/cabal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grayjay/cabal/git/refs{/sha}","trees_url":"https://api.github.com/repos/grayjay/cabal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grayjay/cabal/statuses/{sha}","languages_url":"https://api.github.com/repos/grayjay/cabal/languages","stargazers_url":"https://api.github.com/repos/grayjay/cabal/stargazers","contributors_url":"https://api.github.com/repos/grayjay/cabal/contributors","subscribers_url":"https://api.github.com/repos/grayjay/cabal/subscribers","subscription_url":"https://api.github.com/repos/grayjay/cabal/subscription","commits_url":"https://api.github.com/repos/grayjay/cabal/commits{/sha}","git_commits_url":"https://api.github.com/repos/grayjay/cabal/git/commits{/sha}","comments_url":"https://api.github.com/repos/grayjay/cabal/comments{/number}","issue_comment_url":"https://api.github.com/repos/grayjay/cabal/issues/comments{/number}","contents_url":"https://api.github.com/repos/grayjay/cabal/contents/{+path}","compare_url":"https://api.github.com/repos/grayjay/cabal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grayjay/cabal/merges","archive_url":"https://api.github.com/repos/grayjay/cabal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grayjay/cabal/downloads","issues_url":"https://api.github.com/repos/grayjay/cabal/issues{/number}","pulls_url":"https://api.github.com/repos/grayjay/cabal/pulls{/number}","milestones_url":"https://api.github.com/repos/grayjay/cabal/milestones{/number}","notifications_url":"https://api.github.com/repos/grayjay/cabal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grayjay/cabal/labels{/name}","releases_url":"https://api.github.com/repos/grayjay/cabal/releases{/id}","deployments_url":"https://api.github.com/repos/grayjay/cabal/deployments","created_at":"2015-06-18T00:45:24Z","updated_at":"2016-02-09T01:06:51Z","pushed_at":"2016-12-01T06:00:57Z","git_url":"git://github.com/grayjay/cabal.git","ssh_url":"git@github.com:grayjay/cabal.git","clone_url":"https://github.com/grayjay/cabal.git","svn_url":"https://github.com/grayjay/cabal","homepage":"http://haskell.org/cabal","size":25158,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"haskell:master","ref":"master","sha":"2146ea148fc52ee97549b89c1e9bb18c90610670","user":{"login":"haskell","id":450574,"avatar_url":"https://avatars.githubusercontent.com/u/450574?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"repo":{"id":3728161,"name":"cabal","full_name":"haskell/cabal","owner":{"login":"haskell","id":450574,"avatar_url":"https://avatars.githubusercontent.com/u/450574?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haskell/cabal","description":"Official upstream development repository for Cabal and cabal-install","fork":false,"url":"https://api.github.com/repos/haskell/cabal","forks_url":"https://api.github.com/repos/haskell/cabal/forks","keys_url":"https://api.github.com/repos/haskell/cabal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haskell/cabal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haskell/cabal/teams","hooks_url":"https://api.github.com/repos/haskell/cabal/hooks","issue_events_url":"https://api.github.com/repos/haskell/cabal/issues/events{/number}","events_url":"https://api.github.com/repos/haskell/cabal/events","assignees_url":"https://api.github.com/repos/haskell/cabal/assignees{/user}","branches_url":"https://api.github.com/repos/haskell/cabal/branches{/branch}","tags_url":"https://api.github.com/repos/haskell/cabal/tags","blobs_url":"https://api.github.com/repos/haskell/cabal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haskell/cabal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haskell/cabal/git/refs{/sha}","trees_url":"https://api.github.com/repos/haskell/cabal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haskell/cabal/statuses/{sha}","languages_url":"https://api.github.com/repos/haskell/cabal/languages","stargazers_url":"https://api.github.com/repos/haskell/cabal/stargazers","contributors_url":"https://api.github.com/repos/haskell/cabal/contributors","subscribers_url":"https://api.github.com/repos/haskell/cabal/subscribers","subscription_url":"https://api.github.com/repos/haskell/cabal/subscription","commits_url":"https://api.github.com/repos/haskell/cabal/commits{/sha}","git_commits_url":"https://api.github.com/repos/haskell/cabal/git/commits{/sha}","comments_url":"https://api.github.com/repos/haskell/cabal/comments{/number}","issue_comment_url":"https://api.github.com/repos/haskell/cabal/issues/comments{/number}","contents_url":"https://api.github.com/repos/haskell/cabal/contents/{+path}","compare_url":"https://api.github.com/repos/haskell/cabal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haskell/cabal/merges","archive_url":"https://api.github.com/repos/haskell/cabal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haskell/cabal/downloads","issues_url":"https://api.github.com/repos/haskell/cabal/issues{/number}","pulls_url":"https://api.github.com/repos/haskell/cabal/pulls{/number}","milestones_url":"https://api.github.com/repos/haskell/cabal/milestones{/number}","notifications_url":"https://api.github.com/repos/haskell/cabal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haskell/cabal/labels{/name}","releases_url":"https://api.github.com/repos/haskell/cabal/releases{/id}","deployments_url":"https://api.github.com/repos/haskell/cabal/deployments","created_at":"2012-03-15T12:53:38Z","updated_at":"2016-11-27T04:09:00Z","pushed_at":"2016-12-01T12:14:56Z","git_url":"git://github.com/haskell/cabal.git","ssh_url":"git@github.com:haskell/cabal.git","clone_url":"https://github.com/haskell/cabal.git","svn_url":"https://github.com/haskell/cabal","homepage":"http://haskell.org/cabal","size":34950,"stargazers_count":661,"watchers_count":661,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":359,"mirror_url":null,"open_issues_count":776,"forks":359,"open_issues":776,"watchers":661,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haskell/cabal/pulls/4110"},"html":{"href":"https://github.com/haskell/cabal/pull/4110"},"issue":{"href":"https://api.github.com/repos/haskell/cabal/issues/4110"},"comments":{"href":"https://api.github.com/repos/haskell/cabal/issues/4110/comments"},"review_comments":{"href":"https://api.github.com/repos/haskell/cabal/pulls/4110/comments"},"review_comment":{"href":"https://api.github.com/repos/haskell/cabal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haskell/cabal/pulls/4110/commits"},"statuses":{"href":"https://api.github.com/repos/haskell/cabal/statuses/0f6dbce99987d647bc8dad17596fc7eb1d2c360e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"23Skidoo","id":47439,"avatar_url":"https://avatars.githubusercontent.com/u/47439?v=3","gravatar_id":"","url":"https://api.github.com/users/23Skidoo","html_url":"https://github.com/23Skidoo","followers_url":"https://api.github.com/users/23Skidoo/followers","following_url":"https://api.github.com/users/23Skidoo/following{/other_user}","gists_url":"https://api.github.com/users/23Skidoo/gists{/gist_id}","starred_url":"https://api.github.com/users/23Skidoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/23Skidoo/subscriptions","organizations_url":"https://api.github.com/users/23Skidoo/orgs","repos_url":"https://api.github.com/users/23Skidoo/repos","events_url":"https://api.github.com/users/23Skidoo/events{/privacy}","received_events_url":"https://api.github.com/users/23Skidoo/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"commits":3,"additions":191,"deletions":139,"changed_files":4}}
{"actor":{"display_login":"23Skidoo"}}