{"action":"created","issue":{"url":"https://api.github.com/repos/tmm1/stackprof/issues/74","repository_url":"https://api.github.com/repos/tmm1/stackprof","labels_url":"https://api.github.com/repos/tmm1/stackprof/issues/74/labels{/name}","comments_url":"https://api.github.com/repos/tmm1/stackprof/issues/74/comments","events_url":"https://api.github.com/repos/tmm1/stackprof/issues/74/events","html_url":"https://github.com/tmm1/stackprof/pull/74","id":184046641,"number":74,"title":"Rewrite flamegraph viewer using canvas","user":{"login":"aroben","id":917945,"avatar_url":"https://avatars.githubusercontent.com/u/917945?v=3","gravatar_id":"","url":"https://api.github.com/users/aroben","html_url":"https://github.com/aroben","followers_url":"https://api.github.com/users/aroben/followers","following_url":"https://api.github.com/users/aroben/following{/other_user}","gists_url":"https://api.github.com/users/aroben/gists{/gist_id}","starred_url":"https://api.github.com/users/aroben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aroben/subscriptions","organizations_url":"https://api.github.com/users/aroben/orgs","repos_url":"https://api.github.com/users/aroben/repos","events_url":"https://api.github.com/users/aroben/events{/privacy}","received_events_url":"https://api.github.com/users/aroben/received_events","type":"User","site_admin":true},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2016-10-19T19:01:17Z","updated_at":"2016-10-21T08:52:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tmm1/stackprof/pulls/74","html_url":"https://github.com/tmm1/stackprof/pull/74","diff_url":"https://github.com/tmm1/stackprof/pull/74.diff","patch_url":"https://github.com/tmm1/stackprof/pull/74.patch"},"body":"Large profiles were generating so many SVG nodes that the browser was\r\nbogging down. Using canvas keeps the DOM very simple, and repainting it\r\nseems to be pretty fast. It also lets us drop the D3 and jQuery\r\ndependencies for a smaller page load.\r\n\r\nThe viewer has been flipped vertically: the small overview graph is on\r\nthe top, and stacks grow top down instead of bottom up. This matches\r\nChrome's devtools timeline and many other timeline/flamegraph tools I've\r\nseen.\r\n\r\nControls are:\r\n\r\n - drag: pan/scroll\r\n - scrollwheel: pan/scroll\r\n - Shift-scrollwheel: zoom\r\n\r\nClick-and-drag to select a region in the small overview graph isn't\r\ncurrently supported, nor is dragging the selected region to pan/scroll.\r\nThat would be nice to add back eventually, though I've found that\r\nzoom/scroll performance is good enough that I haven't really missed\r\nthose features.\r\n\r\nThis should be compatible with IE 10 and newer, though I've only tested\r\nin Safari, Firefox, and Chrome.\r\n\r\n/cc #73 @waiting-for-dev @tmm1 @kdaigle "},"comment":{"url":"https://api.github.com/repos/tmm1/stackprof/issues/comments/255328835","html_url":"https://github.com/tmm1/stackprof/pull/74#issuecomment-255328835","issue_url":"https://api.github.com/repos/tmm1/stackprof/issues/74","id":255328835,"user":{"login":"waiting-for-dev","id":52650,"avatar_url":"https://avatars.githubusercontent.com/u/52650?v=3","gravatar_id":"","url":"https://api.github.com/users/waiting-for-dev","html_url":"https://github.com/waiting-for-dev","followers_url":"https://api.github.com/users/waiting-for-dev/followers","following_url":"https://api.github.com/users/waiting-for-dev/following{/other_user}","gists_url":"https://api.github.com/users/waiting-for-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/waiting-for-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waiting-for-dev/subscriptions","organizations_url":"https://api.github.com/users/waiting-for-dev/orgs","repos_url":"https://api.github.com/users/waiting-for-dev/repos","events_url":"https://api.github.com/users/waiting-for-dev/events{/privacy}","received_events_url":"https://api.github.com/users/waiting-for-dev/received_events","type":"User","site_admin":false},"created_at":"2016-10-21T08:52:31Z","updated_at":"2016-10-21T08:52:31Z","body":"Thanks for your work on this @aroben .\r\n\r\n> @waiting-for-dev I don't see anything obviously wrong with that screenshot. To me it just looks like you need to zoom in (Shift-mousewheel) so you can see what's going on in those lower regions. Have you tried that?\r\n\r\nYou are right. I can zoom in. I had tried with Firefox and, there, now I see the zoom works in the opposite way I feel natural: I need to move the mousewheel backwards. In Chrome it works \"well\"; forwards. I don't know if it is just some browser default behavior or something.\r\n\r\n> If you can provide me with your stackprof profile I can try to figure out how to speed it up.\r\n\r\nNow I see that, in Chrome, scrolling and zooming have an acceptable speed. However, in Firefox is quite slow, making it not very handy to work with large files. In a minute, I'm going to send to your private email account (the one in your Github profile) a link to download a real example."}}
{"actor":{"display_login":"waiting-for-dev"}}