{"action":"created","comment":{"url":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments/69606566","id":69606566,"diff_hunk":"@@ -0,0 +1,269 @@\n+import subprocess\n+import json\n+import unittest\n+\n+from test_helper import ApiTestCase, is_auth\n+\n+@unittest.skipIf(not is_auth(), \"Not applicable\")\n+class Cryptokeys(ApiTestCase):\n+    zone = \"cryptokeyzone\"\n+    def setUp(self):\n+        super(Cryptokeys, self).setUp()\n+        try:\n+            subprocess.check_output([\"../pdns/pdnsutil\", \"--config-dir=.\", \"create-zone\", Cryptokeys.zone])","path":"regression-tests.api/test_cryptokeys.py","position":13,"original_position":13,"commit_id":"1920f9569490c12c1de6d83e28ec86c6d42ed5c6","original_commit_id":"1920f9569490c12c1de6d83e28ec86c6d42ed5c6","user":{"login":"zeha","id":26175,"avatar_url":"https://avatars.githubusercontent.com/u/26175?v=3","gravatar_id":"","url":"https://api.github.com/users/zeha","html_url":"https://github.com/zeha","followers_url":"https://api.github.com/users/zeha/followers","following_url":"https://api.github.com/users/zeha/following{/other_user}","gists_url":"https://api.github.com/users/zeha/gists{/gist_id}","starred_url":"https://api.github.com/users/zeha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeha/subscriptions","organizations_url":"https://api.github.com/users/zeha/orgs","repos_url":"https://api.github.com/users/zeha/repos","events_url":"https://api.github.com/users/zeha/events{/privacy}","received_events_url":"https://api.github.com/users/zeha/received_events","type":"User","site_admin":false},"body":"do that using the API instead?","created_at":"2016-07-05T17:44:47Z","updated_at":"2016-07-05T17:44:47Z","html_url":"https://github.com/PowerDNS/pdns/pull/4106#discussion_r69606566","pull_request_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/4106","_links":{"self":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments/69606566"},"html":{"href":"https://github.com/PowerDNS/pdns/pull/4106#discussion_r69606566"},"pull_request":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/4106"}}},"pull_request":{"url":"https://api.github.com/repos/PowerDNS/pdns/pulls/4106","id":76259723,"html_url":"https://github.com/PowerDNS/pdns/pull/4106","diff_url":"https://github.com/PowerDNS/pdns/pull/4106.diff","patch_url":"https://github.com/PowerDNS/pdns/pull/4106.patch","issue_url":"https://api.github.com/repos/PowerDNS/pdns/issues/4106","number":4106,"state":"open","locked":false,"title":"Implementation of the cryptokeys REST-API (PUT, POST, DELETE)","user":{"login":"benj-zen","id":5678345,"avatar_url":"https://avatars.githubusercontent.com/u/5678345?v=3","gravatar_id":"","url":"https://api.github.com/users/benj-zen","html_url":"https://github.com/benj-zen","followers_url":"https://api.github.com/users/benj-zen/followers","following_url":"https://api.github.com/users/benj-zen/following{/other_user}","gists_url":"https://api.github.com/users/benj-zen/gists{/gist_id}","starred_url":"https://api.github.com/users/benj-zen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benj-zen/subscriptions","organizations_url":"https://api.github.com/users/benj-zen/orgs","repos_url":"https://api.github.com/users/benj-zen/repos","events_url":"https://api.github.com/users/benj-zen/events{/privacy}","received_events_url":"https://api.github.com/users/benj-zen/received_events","type":"User","site_admin":false},"body":"We are a group of students at the Freie Universität Berlin. Our team consists of @zervnet, @MrM0nkey, @taudor and @benj-zen.\r\n\r\nWe implemented the Rest-Api methods for the cryptokeys module. While doing that we realized we need to fix #706, so we can return the id of the added key e.g. using POST. As proposed in #706 pdnsutil prints the added key-id to stdout.\r\n\r\nAs suggested in the discussion in the IRC channel, we only implemented the (return-id-)functionality for the major backend-modules (gmysql, gpgsql, gsqlite3, godbc, bind).\r\n\r\nDocumentation and tests are included.","created_at":"2016-07-05T11:41:11Z","updated_at":"2016-07-05T17:44:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2e1441b0ae4dd7d8071681ad8029d0dbe9292e0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/4106/commits","review_comments_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/4106/comments","review_comment_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PowerDNS/pdns/issues/4106/comments","statuses_url":"https://api.github.com/repos/PowerDNS/pdns/statuses/1920f9569490c12c1de6d83e28ec86c6d42ed5c6","head":{"label":"zervnet:feature_rest_api_pull_request","ref":"feature_rest_api_pull_request","sha":"1920f9569490c12c1de6d83e28ec86c6d42ed5c6","user":{"login":"zervnet","id":734854,"avatar_url":"https://avatars.githubusercontent.com/u/734854?v=3","gravatar_id":"","url":"https://api.github.com/users/zervnet","html_url":"https://github.com/zervnet","followers_url":"https://api.github.com/users/zervnet/followers","following_url":"https://api.github.com/users/zervnet/following{/other_user}","gists_url":"https://api.github.com/users/zervnet/gists{/gist_id}","starred_url":"https://api.github.com/users/zervnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zervnet/subscriptions","organizations_url":"https://api.github.com/users/zervnet/orgs","repos_url":"https://api.github.com/users/zervnet/repos","events_url":"https://api.github.com/users/zervnet/events{/privacy}","received_events_url":"https://api.github.com/users/zervnet/received_events","type":"User","site_admin":false},"repo":{"id":56636504,"name":"pdns","full_name":"zervnet/pdns","owner":{"login":"zervnet","id":734854,"avatar_url":"https://avatars.githubusercontent.com/u/734854?v=3","gravatar_id":"","url":"https://api.github.com/users/zervnet","html_url":"https://github.com/zervnet","followers_url":"https://api.github.com/users/zervnet/followers","following_url":"https://api.github.com/users/zervnet/following{/other_user}","gists_url":"https://api.github.com/users/zervnet/gists{/gist_id}","starred_url":"https://api.github.com/users/zervnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zervnet/subscriptions","organizations_url":"https://api.github.com/users/zervnet/orgs","repos_url":"https://api.github.com/users/zervnet/repos","events_url":"https://api.github.com/users/zervnet/events{/privacy}","received_events_url":"https://api.github.com/users/zervnet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zervnet/pdns","description":"PowerDNS","fork":true,"url":"https://api.github.com/repos/zervnet/pdns","forks_url":"https://api.github.com/repos/zervnet/pdns/forks","keys_url":"https://api.github.com/repos/zervnet/pdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zervnet/pdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zervnet/pdns/teams","hooks_url":"https://api.github.com/repos/zervnet/pdns/hooks","issue_events_url":"https://api.github.com/repos/zervnet/pdns/issues/events{/number}","events_url":"https://api.github.com/repos/zervnet/pdns/events","assignees_url":"https://api.github.com/repos/zervnet/pdns/assignees{/user}","branches_url":"https://api.github.com/repos/zervnet/pdns/branches{/branch}","tags_url":"https://api.github.com/repos/zervnet/pdns/tags","blobs_url":"https://api.github.com/repos/zervnet/pdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zervnet/pdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zervnet/pdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/zervnet/pdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zervnet/pdns/statuses/{sha}","languages_url":"https://api.github.com/repos/zervnet/pdns/languages","stargazers_url":"https://api.github.com/repos/zervnet/pdns/stargazers","contributors_url":"https://api.github.com/repos/zervnet/pdns/contributors","subscribers_url":"https://api.github.com/repos/zervnet/pdns/subscribers","subscription_url":"https://api.github.com/repos/zervnet/pdns/subscription","commits_url":"https://api.github.com/repos/zervnet/pdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/zervnet/pdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/zervnet/pdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/zervnet/pdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/zervnet/pdns/contents/{+path}","compare_url":"https://api.github.com/repos/zervnet/pdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zervnet/pdns/merges","archive_url":"https://api.github.com/repos/zervnet/pdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zervnet/pdns/downloads","issues_url":"https://api.github.com/repos/zervnet/pdns/issues{/number}","pulls_url":"https://api.github.com/repos/zervnet/pdns/pulls{/number}","milestones_url":"https://api.github.com/repos/zervnet/pdns/milestones{/number}","notifications_url":"https://api.github.com/repos/zervnet/pdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zervnet/pdns/labels{/name}","releases_url":"https://api.github.com/repos/zervnet/pdns/releases{/id}","deployments_url":"https://api.github.com/repos/zervnet/pdns/deployments","created_at":"2016-04-19T22:23:21Z","updated_at":"2016-04-25T11:51:31Z","pushed_at":"2016-07-05T10:22:47Z","git_url":"git://github.com/zervnet/pdns.git","ssh_url":"git@github.com:zervnet/pdns.git","clone_url":"https://github.com/zervnet/pdns.git","svn_url":"https://github.com/zervnet/pdns","homepage":null,"size":32003,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"PowerDNS:master","ref":"master","sha":"5d1629d943b42b50c274ef24b3ec05f139bfa43b","user":{"login":"PowerDNS","id":1282630,"avatar_url":"https://avatars.githubusercontent.com/u/1282630?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerDNS","html_url":"https://github.com/PowerDNS","followers_url":"https://api.github.com/users/PowerDNS/followers","following_url":"https://api.github.com/users/PowerDNS/following{/other_user}","gists_url":"https://api.github.com/users/PowerDNS/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerDNS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerDNS/subscriptions","organizations_url":"https://api.github.com/users/PowerDNS/orgs","repos_url":"https://api.github.com/users/PowerDNS/repos","events_url":"https://api.github.com/users/PowerDNS/events{/privacy}","received_events_url":"https://api.github.com/users/PowerDNS/received_events","type":"Organization","site_admin":false},"repo":{"id":9693534,"name":"pdns","full_name":"PowerDNS/pdns","owner":{"login":"PowerDNS","id":1282630,"avatar_url":"https://avatars.githubusercontent.com/u/1282630?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerDNS","html_url":"https://github.com/PowerDNS","followers_url":"https://api.github.com/users/PowerDNS/followers","following_url":"https://api.github.com/users/PowerDNS/following{/other_user}","gists_url":"https://api.github.com/users/PowerDNS/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerDNS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerDNS/subscriptions","organizations_url":"https://api.github.com/users/PowerDNS/orgs","repos_url":"https://api.github.com/users/PowerDNS/repos","events_url":"https://api.github.com/users/PowerDNS/events{/privacy}","received_events_url":"https://api.github.com/users/PowerDNS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PowerDNS/pdns","description":"PowerDNS","fork":false,"url":"https://api.github.com/repos/PowerDNS/pdns","forks_url":"https://api.github.com/repos/PowerDNS/pdns/forks","keys_url":"https://api.github.com/repos/PowerDNS/pdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerDNS/pdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerDNS/pdns/teams","hooks_url":"https://api.github.com/repos/PowerDNS/pdns/hooks","issue_events_url":"https://api.github.com/repos/PowerDNS/pdns/issues/events{/number}","events_url":"https://api.github.com/repos/PowerDNS/pdns/events","assignees_url":"https://api.github.com/repos/PowerDNS/pdns/assignees{/user}","branches_url":"https://api.github.com/repos/PowerDNS/pdns/branches{/branch}","tags_url":"https://api.github.com/repos/PowerDNS/pdns/tags","blobs_url":"https://api.github.com/repos/PowerDNS/pdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerDNS/pdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerDNS/pdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerDNS/pdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerDNS/pdns/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerDNS/pdns/languages","stargazers_url":"https://api.github.com/repos/PowerDNS/pdns/stargazers","contributors_url":"https://api.github.com/repos/PowerDNS/pdns/contributors","subscribers_url":"https://api.github.com/repos/PowerDNS/pdns/subscribers","subscription_url":"https://api.github.com/repos/PowerDNS/pdns/subscription","commits_url":"https://api.github.com/repos/PowerDNS/pdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerDNS/pdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerDNS/pdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerDNS/pdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerDNS/pdns/contents/{+path}","compare_url":"https://api.github.com/repos/PowerDNS/pdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerDNS/pdns/merges","archive_url":"https://api.github.com/repos/PowerDNS/pdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerDNS/pdns/downloads","issues_url":"https://api.github.com/repos/PowerDNS/pdns/issues{/number}","pulls_url":"https://api.github.com/repos/PowerDNS/pdns/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerDNS/pdns/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerDNS/pdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerDNS/pdns/labels{/name}","releases_url":"https://api.github.com/repos/PowerDNS/pdns/releases{/id}","deployments_url":"https://api.github.com/repos/PowerDNS/pdns/deployments","created_at":"2013-04-26T11:16:49Z","updated_at":"2016-07-05T01:49:34Z","pushed_at":"2016-07-05T16:41:37Z","git_url":"git://github.com/PowerDNS/pdns.git","ssh_url":"git@github.com:PowerDNS/pdns.git","clone_url":"https://github.com/PowerDNS/pdns.git","svn_url":"https://github.com/PowerDNS/pdns","homepage":null,"size":40899,"stargazers_count":620,"watchers_count":620,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":245,"mirror_url":null,"open_issues_count":385,"forks":245,"open_issues":385,"watchers":620,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/4106"},"html":{"href":"https://github.com/PowerDNS/pdns/pull/4106"},"issue":{"href":"https://api.github.com/repos/PowerDNS/pdns/issues/4106"},"comments":{"href":"https://api.github.com/repos/PowerDNS/pdns/issues/4106/comments"},"review_comments":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/4106/comments"},"review_comment":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/4106/commits"},"statuses":{"href":"https://api.github.com/repos/PowerDNS/pdns/statuses/1920f9569490c12c1de6d83e28ec86c6d42ed5c6"}}}}
{"actor":{"display_login":"zeha"}}