{"action":"created","comment":{"url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/pulls/comments/92509733","pull_request_review_id":13025686,"id":92509733,"diff_hunk":"@@ -421,6 +425,96 @@ namespace ToolCore\n \n     }\n \n+    /// handle the results of a recoompile, and auto play the project if successful\n+    void NETProjectSystem::HandleNETBuildPlay(StringHash eventType, VariantMap& eventData)\n+    {\n+        using namespace NETBuildResult;\n+        \n+        if (eventData[P_SUCCESS].GetBool())\n+        {\n+            ATOMIC_LOGINFOF(\"NETBuild Success for project, now playing.\");\n+            VariantMap shortcutData;  // encode a shortcut even to send a play\n+            shortcutData[UIShortcut::P_KEY] = KEY_P;\n+            shortcutData[UIShortcut::P_QUALIFIERS] = QUAL_CTRL;\n+            SendEvent(E_UISHORTCUT, shortcutData);\n+        }\n+        else\n+        {\n+            const String& errorText = eventData[P_ERRORTEXT].GetString();\n+\n+            ATOMIC_LOGERRORF(\"\\n%s\\n\", errorText.CString());\n+            ATOMIC_LOGERRORF(\"NETBuild Error for project, will not play.\");","path":"Source/ToolCore/NETTools/NETProjectSystem.cpp","position":40,"original_position":40,"commit_id":"91d1363f09434a5f95ea6c9edb6c0f595933b6f3","original_commit_id":"91d1363f09434a5f95ea6c9edb6c0f595933b6f3","user":{"login":"JoshEngebretson","id":376203,"avatar_url":"https://avatars.githubusercontent.com/u/376203?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshEngebretson","html_url":"https://github.com/JoshEngebretson","followers_url":"https://api.github.com/users/JoshEngebretson/followers","following_url":"https://api.github.com/users/JoshEngebretson/following{/other_user}","gists_url":"https://api.github.com/users/JoshEngebretson/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshEngebretson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshEngebretson/subscriptions","organizations_url":"https://api.github.com/users/JoshEngebretson/orgs","repos_url":"https://api.github.com/users/JoshEngebretson/repos","events_url":"https://api.github.com/users/JoshEngebretson/events{/privacy}","received_events_url":"https://api.github.com/users/JoshEngebretson/received_events","type":"User","site_admin":false},"body":"It would be good to output an error modal with this info, should be pretty easy","created_at":"2016-12-14T22:57:55Z","updated_at":"2016-12-14T23:03:07Z","html_url":"https://github.com/AtomicGameEngine/AtomicGameEngine/pull/1281#discussion_r92509733","pull_request_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/pulls/1281","_links":{"self":{"href":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/pulls/comments/92509733"},"html":{"href":"https://github.com/AtomicGameEngine/AtomicGameEngine/pull/1281#discussion_r92509733"},"pull_request":{"href":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/pulls/1281"}}},"pull_request":{"url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/pulls/1281","id":98048707,"html_url":"https://github.com/AtomicGameEngine/AtomicGameEngine/pull/1281","diff_url":"https://github.com/AtomicGameEngine/AtomicGameEngine/pull/1281.diff","patch_url":"https://github.com/AtomicGameEngine/AtomicGameEngine/pull/1281.patch","issue_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/issues/1281","number":1281,"state":"open","locked":false,"title":"C# code changes require manual recompilation in AtomicEditor #1236","user":{"login":"JimMarlowe","id":19511757,"avatar_url":"https://avatars.githubusercontent.com/u/19511757?v=3","gravatar_id":"","url":"https://api.github.com/users/JimMarlowe","html_url":"https://github.com/JimMarlowe","followers_url":"https://api.github.com/users/JimMarlowe/followers","following_url":"https://api.github.com/users/JimMarlowe/following{/other_user}","gists_url":"https://api.github.com/users/JimMarlowe/gists{/gist_id}","starred_url":"https://api.github.com/users/JimMarlowe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JimMarlowe/subscriptions","organizations_url":"https://api.github.com/users/JimMarlowe/orgs","repos_url":"https://api.github.com/users/JimMarlowe/repos","events_url":"https://api.github.com/users/JimMarlowe/events{/privacy}","received_events_url":"https://api.github.com/users/JimMarlowe/received_events","type":"User","site_admin":false},"body":"This PR fixes the Play button for a C# project to always be up to date with the latest saved source files.  There is a check added to the play event handler, which looks to see if the current project is c#, then does a check for out of date sources. If the sources are ok, then no further action is needed, it simply plays the project. If the sources are out of date, then the BuildAndPlay processing starts and it returns out of the play event handler.  The BuildAndPlay function then compiles the project, and in the compile completed event handler, if successful, issues a Play event and the project is played after a short pause. If the compilation fails, only an error is put in the console, and the project is not played. Because of the fine work someone did when c# is compiling, the play button greys out while this compile happens also, giving the user an indication something is happening.\r\n","created_at":"2016-12-14T22:23:54Z","updated_at":"2016-12-14T23:03:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"12906f2c49d2e27b98904f88b855f759afc39bed","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/pulls/1281/commits","review_comments_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/pulls/1281/comments","review_comment_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/issues/1281/comments","statuses_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/statuses/91d1363f09434a5f95ea6c9edb6c0f595933b6f3","head":{"label":"JimMarlowe:JM-COMPILE-1236","ref":"JM-COMPILE-1236","sha":"91d1363f09434a5f95ea6c9edb6c0f595933b6f3","user":{"login":"JimMarlowe","id":19511757,"avatar_url":"https://avatars.githubusercontent.com/u/19511757?v=3","gravatar_id":"","url":"https://api.github.com/users/JimMarlowe","html_url":"https://github.com/JimMarlowe","followers_url":"https://api.github.com/users/JimMarlowe/followers","following_url":"https://api.github.com/users/JimMarlowe/following{/other_user}","gists_url":"https://api.github.com/users/JimMarlowe/gists{/gist_id}","starred_url":"https://api.github.com/users/JimMarlowe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JimMarlowe/subscriptions","organizations_url":"https://api.github.com/users/JimMarlowe/orgs","repos_url":"https://api.github.com/users/JimMarlowe/repos","events_url":"https://api.github.com/users/JimMarlowe/events{/privacy}","received_events_url":"https://api.github.com/users/JimMarlowe/received_events","type":"User","site_admin":false},"repo":{"id":60563347,"name":"AtomicGameEngine","full_name":"JimMarlowe/AtomicGameEngine","owner":{"login":"JimMarlowe","id":19511757,"avatar_url":"https://avatars.githubusercontent.com/u/19511757?v=3","gravatar_id":"","url":"https://api.github.com/users/JimMarlowe","html_url":"https://github.com/JimMarlowe","followers_url":"https://api.github.com/users/JimMarlowe/followers","following_url":"https://api.github.com/users/JimMarlowe/following{/other_user}","gists_url":"https://api.github.com/users/JimMarlowe/gists{/gist_id}","starred_url":"https://api.github.com/users/JimMarlowe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JimMarlowe/subscriptions","organizations_url":"https://api.github.com/users/JimMarlowe/orgs","repos_url":"https://api.github.com/users/JimMarlowe/repos","events_url":"https://api.github.com/users/JimMarlowe/events{/privacy}","received_events_url":"https://api.github.com/users/JimMarlowe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JimMarlowe/AtomicGameEngine","description":"The Atomic Game Engine: http://www.AtomicGameEngine.com","fork":true,"url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine","forks_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/forks","keys_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/teams","hooks_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/hooks","issue_events_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/issues/events{/number}","events_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/events","assignees_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/assignees{/user}","branches_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/branches{/branch}","tags_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/tags","blobs_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/git/refs{/sha}","trees_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/statuses/{sha}","languages_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/languages","stargazers_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/stargazers","contributors_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/contributors","subscribers_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/subscribers","subscription_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/subscription","commits_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/commits{/sha}","git_commits_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/git/commits{/sha}","comments_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/comments{/number}","issue_comment_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/issues/comments{/number}","contents_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/contents/{+path}","compare_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/merges","archive_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/downloads","issues_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/issues{/number}","pulls_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/pulls{/number}","milestones_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/milestones{/number}","notifications_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/labels{/name}","releases_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/releases{/id}","deployments_url":"https://api.github.com/repos/JimMarlowe/AtomicGameEngine/deployments","created_at":"2016-06-06T21:53:01Z","updated_at":"2016-06-06T21:53:31Z","pushed_at":"2016-12-14T22:19:35Z","git_url":"git://github.com/JimMarlowe/AtomicGameEngine.git","ssh_url":"git@github.com:JimMarlowe/AtomicGameEngine.git","clone_url":"https://github.com/JimMarlowe/AtomicGameEngine.git","svn_url":"https://github.com/JimMarlowe/AtomicGameEngine","homepage":"","size":103104,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AtomicGameEngine:master","ref":"master","sha":"a819386032604978875188e540688f392920c73c","user":{"login":"AtomicGameEngine","id":9641691,"avatar_url":"https://avatars.githubusercontent.com/u/9641691?v=3","gravatar_id":"","url":"https://api.github.com/users/AtomicGameEngine","html_url":"https://github.com/AtomicGameEngine","followers_url":"https://api.github.com/users/AtomicGameEngine/followers","following_url":"https://api.github.com/users/AtomicGameEngine/following{/other_user}","gists_url":"https://api.github.com/users/AtomicGameEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/AtomicGameEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtomicGameEngine/subscriptions","organizations_url":"https://api.github.com/users/AtomicGameEngine/orgs","repos_url":"https://api.github.com/users/AtomicGameEngine/repos","events_url":"https://api.github.com/users/AtomicGameEngine/events{/privacy}","received_events_url":"https://api.github.com/users/AtomicGameEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":29790707,"name":"AtomicGameEngine","full_name":"AtomicGameEngine/AtomicGameEngine","owner":{"login":"AtomicGameEngine","id":9641691,"avatar_url":"https://avatars.githubusercontent.com/u/9641691?v=3","gravatar_id":"","url":"https://api.github.com/users/AtomicGameEngine","html_url":"https://github.com/AtomicGameEngine","followers_url":"https://api.github.com/users/AtomicGameEngine/followers","following_url":"https://api.github.com/users/AtomicGameEngine/following{/other_user}","gists_url":"https://api.github.com/users/AtomicGameEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/AtomicGameEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtomicGameEngine/subscriptions","organizations_url":"https://api.github.com/users/AtomicGameEngine/orgs","repos_url":"https://api.github.com/users/AtomicGameEngine/repos","events_url":"https://api.github.com/users/AtomicGameEngine/events{/privacy}","received_events_url":"https://api.github.com/users/AtomicGameEngine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AtomicGameEngine/AtomicGameEngine","description":"The Atomic Game Engine is a multi-platform 2D and 3D engine with a consistent API in C#, JavaScript, TypeScript, and C++ (http://www.AtomicGameEngine.com)","fork":false,"url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine","forks_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/forks","keys_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/teams","hooks_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/hooks","issue_events_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/issues/events{/number}","events_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/events","assignees_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/assignees{/user}","branches_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/branches{/branch}","tags_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/tags","blobs_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/git/refs{/sha}","trees_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/statuses/{sha}","languages_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/languages","stargazers_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/stargazers","contributors_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/contributors","subscribers_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/subscribers","subscription_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/subscription","commits_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/commits{/sha}","git_commits_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/git/commits{/sha}","comments_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/comments{/number}","issue_comment_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/issues/comments{/number}","contents_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/contents/{+path}","compare_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/merges","archive_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/downloads","issues_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/issues{/number}","pulls_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/pulls{/number}","milestones_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/milestones{/number}","notifications_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/labels{/name}","releases_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/releases{/id}","deployments_url":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/deployments","created_at":"2015-01-24T20:35:25Z","updated_at":"2016-12-14T23:00:15Z","pushed_at":"2016-12-14T22:46:32Z","git_url":"git://github.com/AtomicGameEngine/AtomicGameEngine.git","ssh_url":"git@github.com:AtomicGameEngine/AtomicGameEngine.git","clone_url":"https://github.com/AtomicGameEngine/AtomicGameEngine.git","svn_url":"https://github.com/AtomicGameEngine/AtomicGameEngine","homepage":"","size":103367,"stargazers_count":1156,"watchers_count":1156,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":228,"mirror_url":null,"open_issues_count":280,"forks":228,"open_issues":280,"watchers":1156,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/pulls/1281"},"html":{"href":"https://github.com/AtomicGameEngine/AtomicGameEngine/pull/1281"},"issue":{"href":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/issues/1281"},"comments":{"href":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/issues/1281/comments"},"review_comments":{"href":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/pulls/1281/comments"},"review_comment":{"href":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/pulls/1281/commits"},"statuses":{"href":"https://api.github.com/repos/AtomicGameEngine/AtomicGameEngine/statuses/91d1363f09434a5f95ea6c9edb6c0f595933b6f3"}}}}
{"actor":{"display_login":"JoshEngebretson"}}