{"action":"created","comment":{"url":"https://api.github.com/repos/natsys/mariadb_10.2/pulls/comments/86851127","pull_request_review_id":7488236,"id":86851127,"diff_hunk":"@@ -2536,6 +2536,25 @@ void Item_field::set_field(Field *field_par)\n   fixed= 1;\n   if (field->table->s->tmp_table == SYSTEM_TMP_TABLE)\n     any_privileges= 0;\n+\n+  if (field && context && context->select_lex &&\n+      field->is_versioning_disabled() &&\n+      context->select_lex->vers_conditions.type != FOR_SYSTEM_TIME_UNSPECIFIED)\n+  {\n+    field->force_null= true;\n+    if (context->select_lex->parent_lex && context->select_lex->parent_lex->thd)\n+    {\n+      THD *thd= context->select_lex->parent_lex->thd;\n+      if (!context->select_lex->optimized_in_versioned)","path":"sql/item.cc","position":13,"original_position":13,"commit_id":"f37ff98024c2dca5ffd5722c2213e2a38787ca87","original_commit_id":"f37ff98024c2dca5ffd5722c2213e2a38787ca87","user":{"login":"midenok","id":3307037,"avatar_url":"https://avatars.githubusercontent.com/u/3307037?v=3","gravatar_id":"","url":"https://api.github.com/users/midenok","html_url":"https://github.com/midenok","followers_url":"https://api.github.com/users/midenok/followers","following_url":"https://api.github.com/users/midenok/following{/other_user}","gists_url":"https://api.github.com/users/midenok/gists{/gist_id}","starred_url":"https://api.github.com/users/midenok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/midenok/subscriptions","organizations_url":"https://api.github.com/users/midenok/orgs","repos_url":"https://api.github.com/users/midenok/repos","events_url":"https://api.github.com/users/midenok/events{/privacy}","received_events_url":"https://api.github.com/users/midenok/received_events","type":"User","site_admin":false},"body":"Extra `if` instead of `&&`.","created_at":"2016-11-07T19:37:05Z","updated_at":"2016-11-07T19:37:05Z","html_url":"https://github.com/natsys/mariadb_10.2/pull/70#discussion_r86851127","pull_request_url":"https://api.github.com/repos/natsys/mariadb_10.2/pulls/70","_links":{"self":{"href":"https://api.github.com/repos/natsys/mariadb_10.2/pulls/comments/86851127"},"html":{"href":"https://github.com/natsys/mariadb_10.2/pull/70#discussion_r86851127"},"pull_request":{"href":"https://api.github.com/repos/natsys/mariadb_10.2/pulls/70"}}},"pull_request":{"url":"https://api.github.com/repos/natsys/mariadb_10.2/pulls/70","id":92284141,"html_url":"https://github.com/natsys/mariadb_10.2/pull/70","diff_url":"https://github.com/natsys/mariadb_10.2/pull/70.diff","patch_url":"https://github.com/natsys/mariadb_10.2/pull/70.patch","issue_url":"https://api.github.com/repos/natsys/mariadb_10.2/issues/70","number":70,"state":"open","locked":false,"title":"ek/optimized select","user":{"login":"kevgs","id":2688122,"avatar_url":"https://avatars.githubusercontent.com/u/2688122?v=3","gravatar_id":"","url":"https://api.github.com/users/kevgs","html_url":"https://github.com/kevgs","followers_url":"https://api.github.com/users/kevgs/followers","following_url":"https://api.github.com/users/kevgs/following{/other_user}","gists_url":"https://api.github.com/users/kevgs/gists{/gist_id}","starred_url":"https://api.github.com/users/kevgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevgs/subscriptions","organizations_url":"https://api.github.com/users/kevgs/orgs","repos_url":"https://api.github.com/users/kevgs/repos","events_url":"https://api.github.com/users/kevgs/events{/privacy}","received_events_url":"https://api.github.com/users/kevgs/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-04T04:54:53Z","updated_at":"2016-11-07T19:37:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91c954e57f3c2ab5d886bfabc0037ca9b4f2b28f","assignee":{"login":"midenok","id":3307037,"avatar_url":"https://avatars.githubusercontent.com/u/3307037?v=3","gravatar_id":"","url":"https://api.github.com/users/midenok","html_url":"https://github.com/midenok","followers_url":"https://api.github.com/users/midenok/followers","following_url":"https://api.github.com/users/midenok/following{/other_user}","gists_url":"https://api.github.com/users/midenok/gists{/gist_id}","starred_url":"https://api.github.com/users/midenok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/midenok/subscriptions","organizations_url":"https://api.github.com/users/midenok/orgs","repos_url":"https://api.github.com/users/midenok/repos","events_url":"https://api.github.com/users/midenok/events{/privacy}","received_events_url":"https://api.github.com/users/midenok/received_events","type":"User","site_admin":false},"assignees":[{"login":"midenok","id":3307037,"avatar_url":"https://avatars.githubusercontent.com/u/3307037?v=3","gravatar_id":"","url":"https://api.github.com/users/midenok","html_url":"https://github.com/midenok","followers_url":"https://api.github.com/users/midenok/followers","following_url":"https://api.github.com/users/midenok/following{/other_user}","gists_url":"https://api.github.com/users/midenok/gists{/gist_id}","starred_url":"https://api.github.com/users/midenok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/midenok/subscriptions","organizations_url":"https://api.github.com/users/midenok/orgs","repos_url":"https://api.github.com/users/midenok/repos","events_url":"https://api.github.com/users/midenok/events{/privacy}","received_events_url":"https://api.github.com/users/midenok/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/natsys/mariadb_10.2/milestones/4","html_url":"https://github.com/natsys/mariadb_10.2/milestones/0.4%20AS%20OF%20TRX_ID%20(directly%20specify%20transaction%20id%20in%20AS%20OF)","labels_url":"https://api.github.com/repos/natsys/mariadb_10.2/milestones/4/labels","id":2034820,"number":4,"title":"0.4 AS OF TRX_ID (directly specify transaction id in AS OF)","description":"AS OF TRX_ID (directly specify transaction id in AS OF)\r\n    * Conditional on having audit plugin logging transaction boundaries\r\n    * Table `versioning_transaction_query` must be used to take transaction\r\n      visibility into account (what changes were visible at the start of\r\n      the transaction).\r\n    * TRX_ID are visible to the user.\r\n","creator":{"login":"krizhanovsky","id":884694,"avatar_url":"https://avatars.githubusercontent.com/u/884694?v=3","gravatar_id":"","url":"https://api.github.com/users/krizhanovsky","html_url":"https://github.com/krizhanovsky","followers_url":"https://api.github.com/users/krizhanovsky/followers","following_url":"https://api.github.com/users/krizhanovsky/following{/other_user}","gists_url":"https://api.github.com/users/krizhanovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/krizhanovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krizhanovsky/subscriptions","organizations_url":"https://api.github.com/users/krizhanovsky/orgs","repos_url":"https://api.github.com/users/krizhanovsky/repos","events_url":"https://api.github.com/users/krizhanovsky/events{/privacy}","received_events_url":"https://api.github.com/users/krizhanovsky/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":12,"state":"open","created_at":"2016-09-28T14:10:21Z","updated_at":"2016-11-04T05:50:55Z","due_on":"2016-11-15T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/natsys/mariadb_10.2/pulls/70/commits","review_comments_url":"https://api.github.com/repos/natsys/mariadb_10.2/pulls/70/comments","review_comment_url":"https://api.github.com/repos/natsys/mariadb_10.2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/natsys/mariadb_10.2/issues/70/comments","statuses_url":"https://api.github.com/repos/natsys/mariadb_10.2/statuses/f37ff98024c2dca5ffd5722c2213e2a38787ca87","head":{"label":"natsys:ek/optimized_select","ref":"ek/optimized_select","sha":"f37ff98024c2dca5ffd5722c2213e2a38787ca87","user":{"login":"natsys","id":8489938,"avatar_url":"https://avatars.githubusercontent.com/u/8489938?v=3","gravatar_id":"","url":"https://api.github.com/users/natsys","html_url":"https://github.com/natsys","followers_url":"https://api.github.com/users/natsys/followers","following_url":"https://api.github.com/users/natsys/following{/other_user}","gists_url":"https://api.github.com/users/natsys/gists{/gist_id}","starred_url":"https://api.github.com/users/natsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natsys/subscriptions","organizations_url":"https://api.github.com/users/natsys/orgs","repos_url":"https://api.github.com/users/natsys/repos","events_url":"https://api.github.com/users/natsys/events{/privacy}","received_events_url":"https://api.github.com/users/natsys/received_events","type":"Organization","site_admin":false},"repo":{"id":60608307,"name":"mariadb_10.2","full_name":"natsys/mariadb_10.2","owner":{"login":"natsys","id":8489938,"avatar_url":"https://avatars.githubusercontent.com/u/8489938?v=3","gravatar_id":"","url":"https://api.github.com/users/natsys","html_url":"https://github.com/natsys","followers_url":"https://api.github.com/users/natsys/followers","following_url":"https://api.github.com/users/natsys/following{/other_user}","gists_url":"https://api.github.com/users/natsys/gists{/gist_id}","starred_url":"https://api.github.com/users/natsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natsys/subscriptions","organizations_url":"https://api.github.com/users/natsys/orgs","repos_url":"https://api.github.com/users/natsys/repos","events_url":"https://api.github.com/users/natsys/events{/privacy}","received_events_url":"https://api.github.com/users/natsys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/natsys/mariadb_10.2","description":"MariaDB Flashback (System Versioning)","fork":true,"url":"https://api.github.com/repos/natsys/mariadb_10.2","forks_url":"https://api.github.com/repos/natsys/mariadb_10.2/forks","keys_url":"https://api.github.com/repos/natsys/mariadb_10.2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/natsys/mariadb_10.2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/natsys/mariadb_10.2/teams","hooks_url":"https://api.github.com/repos/natsys/mariadb_10.2/hooks","issue_events_url":"https://api.github.com/repos/natsys/mariadb_10.2/issues/events{/number}","events_url":"https://api.github.com/repos/natsys/mariadb_10.2/events","assignees_url":"https://api.github.com/repos/natsys/mariadb_10.2/assignees{/user}","branches_url":"https://api.github.com/repos/natsys/mariadb_10.2/branches{/branch}","tags_url":"https://api.github.com/repos/natsys/mariadb_10.2/tags","blobs_url":"https://api.github.com/repos/natsys/mariadb_10.2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/natsys/mariadb_10.2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/natsys/mariadb_10.2/git/refs{/sha}","trees_url":"https://api.github.com/repos/natsys/mariadb_10.2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/natsys/mariadb_10.2/statuses/{sha}","languages_url":"https://api.github.com/repos/natsys/mariadb_10.2/languages","stargazers_url":"https://api.github.com/repos/natsys/mariadb_10.2/stargazers","contributors_url":"https://api.github.com/repos/natsys/mariadb_10.2/contributors","subscribers_url":"https://api.github.com/repos/natsys/mariadb_10.2/subscribers","subscription_url":"https://api.github.com/repos/natsys/mariadb_10.2/subscription","commits_url":"https://api.github.com/repos/natsys/mariadb_10.2/commits{/sha}","git_commits_url":"https://api.github.com/repos/natsys/mariadb_10.2/git/commits{/sha}","comments_url":"https://api.github.com/repos/natsys/mariadb_10.2/comments{/number}","issue_comment_url":"https://api.github.com/repos/natsys/mariadb_10.2/issues/comments{/number}","contents_url":"https://api.github.com/repos/natsys/mariadb_10.2/contents/{+path}","compare_url":"https://api.github.com/repos/natsys/mariadb_10.2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/natsys/mariadb_10.2/merges","archive_url":"https://api.github.com/repos/natsys/mariadb_10.2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/natsys/mariadb_10.2/downloads","issues_url":"https://api.github.com/repos/natsys/mariadb_10.2/issues{/number}","pulls_url":"https://api.github.com/repos/natsys/mariadb_10.2/pulls{/number}","milestones_url":"https://api.github.com/repos/natsys/mariadb_10.2/milestones{/number}","notifications_url":"https://api.github.com/repos/natsys/mariadb_10.2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/natsys/mariadb_10.2/labels{/name}","releases_url":"https://api.github.com/repos/natsys/mariadb_10.2/releases{/id}","deployments_url":"https://api.github.com/repos/natsys/mariadb_10.2/deployments","created_at":"2016-06-07T11:33:56Z","updated_at":"2016-10-22T13:03:53Z","pushed_at":"2016-11-07T19:01:54Z","git_url":"git://github.com/natsys/mariadb_10.2.git","ssh_url":"git@github.com:natsys/mariadb_10.2.git","clone_url":"https://github.com/natsys/mariadb_10.2.git","svn_url":"https://github.com/natsys/mariadb_10.2","homepage":"","size":465152,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":10,"forks":3,"open_issues":10,"watchers":2,"default_branch":"natsys/trunk"}},"base":{"label":"natsys:natsys/trunk","ref":"natsys/trunk","sha":"748af787994ff2a3c3a7334ba6306d476f0c9c04","user":{"login":"natsys","id":8489938,"avatar_url":"https://avatars.githubusercontent.com/u/8489938?v=3","gravatar_id":"","url":"https://api.github.com/users/natsys","html_url":"https://github.com/natsys","followers_url":"https://api.github.com/users/natsys/followers","following_url":"https://api.github.com/users/natsys/following{/other_user}","gists_url":"https://api.github.com/users/natsys/gists{/gist_id}","starred_url":"https://api.github.com/users/natsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natsys/subscriptions","organizations_url":"https://api.github.com/users/natsys/orgs","repos_url":"https://api.github.com/users/natsys/repos","events_url":"https://api.github.com/users/natsys/events{/privacy}","received_events_url":"https://api.github.com/users/natsys/received_events","type":"Organization","site_admin":false},"repo":{"id":60608307,"name":"mariadb_10.2","full_name":"natsys/mariadb_10.2","owner":{"login":"natsys","id":8489938,"avatar_url":"https://avatars.githubusercontent.com/u/8489938?v=3","gravatar_id":"","url":"https://api.github.com/users/natsys","html_url":"https://github.com/natsys","followers_url":"https://api.github.com/users/natsys/followers","following_url":"https://api.github.com/users/natsys/following{/other_user}","gists_url":"https://api.github.com/users/natsys/gists{/gist_id}","starred_url":"https://api.github.com/users/natsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natsys/subscriptions","organizations_url":"https://api.github.com/users/natsys/orgs","repos_url":"https://api.github.com/users/natsys/repos","events_url":"https://api.github.com/users/natsys/events{/privacy}","received_events_url":"https://api.github.com/users/natsys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/natsys/mariadb_10.2","description":"MariaDB Flashback (System Versioning)","fork":true,"url":"https://api.github.com/repos/natsys/mariadb_10.2","forks_url":"https://api.github.com/repos/natsys/mariadb_10.2/forks","keys_url":"https://api.github.com/repos/natsys/mariadb_10.2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/natsys/mariadb_10.2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/natsys/mariadb_10.2/teams","hooks_url":"https://api.github.com/repos/natsys/mariadb_10.2/hooks","issue_events_url":"https://api.github.com/repos/natsys/mariadb_10.2/issues/events{/number}","events_url":"https://api.github.com/repos/natsys/mariadb_10.2/events","assignees_url":"https://api.github.com/repos/natsys/mariadb_10.2/assignees{/user}","branches_url":"https://api.github.com/repos/natsys/mariadb_10.2/branches{/branch}","tags_url":"https://api.github.com/repos/natsys/mariadb_10.2/tags","blobs_url":"https://api.github.com/repos/natsys/mariadb_10.2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/natsys/mariadb_10.2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/natsys/mariadb_10.2/git/refs{/sha}","trees_url":"https://api.github.com/repos/natsys/mariadb_10.2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/natsys/mariadb_10.2/statuses/{sha}","languages_url":"https://api.github.com/repos/natsys/mariadb_10.2/languages","stargazers_url":"https://api.github.com/repos/natsys/mariadb_10.2/stargazers","contributors_url":"https://api.github.com/repos/natsys/mariadb_10.2/contributors","subscribers_url":"https://api.github.com/repos/natsys/mariadb_10.2/subscribers","subscription_url":"https://api.github.com/repos/natsys/mariadb_10.2/subscription","commits_url":"https://api.github.com/repos/natsys/mariadb_10.2/commits{/sha}","git_commits_url":"https://api.github.com/repos/natsys/mariadb_10.2/git/commits{/sha}","comments_url":"https://api.github.com/repos/natsys/mariadb_10.2/comments{/number}","issue_comment_url":"https://api.github.com/repos/natsys/mariadb_10.2/issues/comments{/number}","contents_url":"https://api.github.com/repos/natsys/mariadb_10.2/contents/{+path}","compare_url":"https://api.github.com/repos/natsys/mariadb_10.2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/natsys/mariadb_10.2/merges","archive_url":"https://api.github.com/repos/natsys/mariadb_10.2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/natsys/mariadb_10.2/downloads","issues_url":"https://api.github.com/repos/natsys/mariadb_10.2/issues{/number}","pulls_url":"https://api.github.com/repos/natsys/mariadb_10.2/pulls{/number}","milestones_url":"https://api.github.com/repos/natsys/mariadb_10.2/milestones{/number}","notifications_url":"https://api.github.com/repos/natsys/mariadb_10.2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/natsys/mariadb_10.2/labels{/name}","releases_url":"https://api.github.com/repos/natsys/mariadb_10.2/releases{/id}","deployments_url":"https://api.github.com/repos/natsys/mariadb_10.2/deployments","created_at":"2016-06-07T11:33:56Z","updated_at":"2016-10-22T13:03:53Z","pushed_at":"2016-11-07T19:01:54Z","git_url":"git://github.com/natsys/mariadb_10.2.git","ssh_url":"git@github.com:natsys/mariadb_10.2.git","clone_url":"https://github.com/natsys/mariadb_10.2.git","svn_url":"https://github.com/natsys/mariadb_10.2","homepage":"","size":465152,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":10,"forks":3,"open_issues":10,"watchers":2,"default_branch":"natsys/trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/natsys/mariadb_10.2/pulls/70"},"html":{"href":"https://github.com/natsys/mariadb_10.2/pull/70"},"issue":{"href":"https://api.github.com/repos/natsys/mariadb_10.2/issues/70"},"comments":{"href":"https://api.github.com/repos/natsys/mariadb_10.2/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/natsys/mariadb_10.2/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/natsys/mariadb_10.2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/natsys/mariadb_10.2/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/natsys/mariadb_10.2/statuses/f37ff98024c2dca5ffd5722c2213e2a38787ca87"}}}}
{"actor":{"display_login":"midenok"}}