{"action":"created","issue":{"url":"https://api.github.com/repos/shakacode/react-validation-layer/issues/1","repository_url":"https://api.github.com/repos/shakacode/react-validation-layer","labels_url":"https://api.github.com/repos/shakacode/react-validation-layer/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/shakacode/react-validation-layer/issues/1/comments","events_url":"https://api.github.com/repos/shakacode/react-validation-layer/issues/1/events","html_url":"https://github.com/shakacode/react-validation-layer/pull/1","id":139370693,"number":1,"title":"Initial release","user":{"login":"alexfedoseev","id":4244251,"avatar_url":"https://avatars.githubusercontent.com/u/4244251?v=3","gravatar_id":"","url":"https://api.github.com/users/alexfedoseev","html_url":"https://github.com/alexfedoseev","followers_url":"https://api.github.com/users/alexfedoseev/followers","following_url":"https://api.github.com/users/alexfedoseev/following{/other_user}","gists_url":"https://api.github.com/users/alexfedoseev/gists{/gist_id}","starred_url":"https://api.github.com/users/alexfedoseev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexfedoseev/subscriptions","organizations_url":"https://api.github.com/users/alexfedoseev/orgs","repos_url":"https://api.github.com/users/alexfedoseev/repos","events_url":"https://api.github.com/users/alexfedoseev/events{/privacy}","received_events_url":"https://api.github.com/users/alexfedoseev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-03-08T19:26:53Z","updated_at":"2016-11-01T12:58:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/shakacode/react-validation-layer/pulls/1","html_url":"https://github.com/shakacode/react-validation-layer/pull/1","diff_url":"https://github.com/shakacode/react-validation-layer/pull/1.diff","patch_url":"https://github.com/shakacode/react-validation-layer/pull/1.patch"},"body":"<!-- Reviewable:start -->\n\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/shakacode/react-validation-layer/1)\n\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/shakacode/react-validation-layer/issues/comments/257559998","html_url":"https://github.com/shakacode/react-validation-layer/pull/1#issuecomment-257559998","issue_url":"https://api.github.com/repos/shakacode/react-validation-layer/issues/1","id":257559998,"user":{"login":"alexfedoseev","id":4244251,"avatar_url":"https://avatars.githubusercontent.com/u/4244251?v=3","gravatar_id":"","url":"https://api.github.com/users/alexfedoseev","html_url":"https://github.com/alexfedoseev","followers_url":"https://api.github.com/users/alexfedoseev/followers","following_url":"https://api.github.com/users/alexfedoseev/following{/other_user}","gists_url":"https://api.github.com/users/alexfedoseev/gists{/gist_id}","starred_url":"https://api.github.com/users/alexfedoseev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexfedoseev/subscriptions","organizations_url":"https://api.github.com/users/alexfedoseev/orgs","repos_url":"https://api.github.com/users/alexfedoseev/repos","events_url":"https://api.github.com/users/alexfedoseev/events{/privacy}","received_events_url":"https://api.github.com/users/alexfedoseev/received_events","type":"User","site_admin":false},"created_at":"2016-11-01T12:58:05Z","updated_at":"2016-11-01T12:58:05Z","body":"\n\n\n\nReview status: 25 of 86 files reviewed at latest revision, 15 unresolved discussions, some commit checks broke.\n\n---\n\n*[README.md, line 39 at r4](https://reviewable.io:443/reviews/shakacode/react-validation-layer/1#-KVRuQx7hOypb_c7DqgD:-KVUwwbGqstGpC3_DFK7:b-x2otqw) ([raw file](https://github.com/shakacode/react-validation-layer/blob/45bb391ae6ddc5dd9fd948bf8d8bff8157ff7c6d/README.md#L39)):*\n<details><summary><i>Previously, alexfedoseev (Alex Fedoseev) wrote…</i></summary>\n> > You'd rather do it this way (composition with a function) than just a HOC?\n> \n> Yep, injection of props is less transparent and has requirement to hold ValidationLayer and its form in separate modules. Children as function is better in every way.\n> \n> > What do you thinking about giving up some flexibility to make it even simpler? We could make it so you pass a data object, and then you pass a fields object that has to have the same key names? That way there's less to consider. Then the layer object has keys that equal those names as well:\n> \n> I'm still considering this part of api, I started mocking the object way at first, but got back to array b/c of nested data case, eg\n> \n> ```js\n> post {\n>   title\n>   content\n> \n>   coverPhoto { // <= here it's not clear is this object w/ coverPhoto field params or nested object w/ coverPhoto's fields/attributes\n>     title\n>     url\n>   }\n> }\n> ```\n> \n> If there're better ideas how to handle this—I'm all ears.\n> \n> P.S. Also there are collections in the list, haven't done any mocks for this case in this iteration.\n</details>\nTho I can check the type of the value in the `data` object at this key path and decide what this thing is (if it's object, then it's nested set of fields). It will require some additional work to normalize fields, but I guess it should work w/o significant overhead.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/shakacode/react-validation-layer/1)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"alexfedoseev"}}