{"action":"created","issue":{"url":"https://api.github.com/repos/libgit2/libgit2/issues/3436","repository_url":"https://api.github.com/repos/libgit2/libgit2","labels_url":"https://api.github.com/repos/libgit2/libgit2/issues/3436/labels{/name}","comments_url":"https://api.github.com/repos/libgit2/libgit2/issues/3436/comments","events_url":"https://api.github.com/repos/libgit2/libgit2/issues/3436/events","html_url":"https://github.com/libgit2/libgit2/pull/3436","id":107893535,"number":3436,"title":"Worktree implementation","user":{"login":"pks-t","id":4056630,"avatar_url":"https://avatars.githubusercontent.com/u/4056630?v=3","gravatar_id":"","url":"https://api.github.com/users/pks-t","html_url":"https://github.com/pks-t","followers_url":"https://api.github.com/users/pks-t/followers","following_url":"https://api.github.com/users/pks-t/following{/other_user}","gists_url":"https://api.github.com/users/pks-t/gists{/gist_id}","starred_url":"https://api.github.com/users/pks-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pks-t/subscriptions","organizations_url":"https://api.github.com/users/pks-t/orgs","repos_url":"https://api.github.com/users/pks-t/repos","events_url":"https://api.github.com/users/pks-t/events{/privacy}","received_events_url":"https://api.github.com/users/pks-t/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":40,"created_at":"2015-09-23T10:45:06Z","updated_at":"2016-11-10T21:48:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/libgit2/libgit2/pulls/3436","html_url":"https://github.com/libgit2/libgit2/pull/3436","diff_url":"https://github.com/libgit2/libgit2/pull/3436.diff","patch_url":"https://github.com/libgit2/libgit2/pull/3436.patch"},"body":"These patches introduce initial support for work trees, which have been introduced with git v.2.5.\n\nCriticism and proposals welcome.\n\nThings that need to be tackled in order to work with $COMMONDIR:\n- [x] ref lookup\n- [x] loose lookup\n- [x] packed lookup\n- [x] config\n- [x] logs/\n\nThe following directories are not really used by us but would require to be made aware of $COMMONDIR:\n- [ ] shallow/\n- [ ] info/\n- [ ] remotes/  (legacy)\n- [ ] branches/ directory (legacy)\n- [ ] hooks/\n\nAdditional things that need to be cared about:\n- [x] creating new working trees\n- [x] restrictions on ability to check out refs that are being linked to\n- [x] restrictions on ability to delete refs that are being linked to (only enforced for `git_branch_delete` function)\n- [x] pruning (abandoned) working trees\n- [ ] renaming references?\n"},"comment":{"url":"https://api.github.com/repos/libgit2/libgit2/issues/comments/259817299","html_url":"https://github.com/libgit2/libgit2/pull/3436#issuecomment-259817299","issue_url":"https://api.github.com/repos/libgit2/libgit2/issues/3436","id":259817299,"user":{"login":"max630","id":381560,"avatar_url":"https://avatars.githubusercontent.com/u/381560?v=3","gravatar_id":"","url":"https://api.github.com/users/max630","html_url":"https://github.com/max630","followers_url":"https://api.github.com/users/max630/followers","following_url":"https://api.github.com/users/max630/following{/other_user}","gists_url":"https://api.github.com/users/max630/gists{/gist_id}","starred_url":"https://api.github.com/users/max630/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/max630/subscriptions","organizations_url":"https://api.github.com/users/max630/orgs","repos_url":"https://api.github.com/users/max630/repos","events_url":"https://api.github.com/users/max630/events{/privacy}","received_events_url":"https://api.github.com/users/max630/received_events","type":"User","site_admin":false},"created_at":"2016-11-10T21:48:32Z","updated_at":"2016-11-10T21:48:32Z","body":"In function `git_blob_create_fromstream()`, path to object directory is [counted](https://github.com/libgit2/libgit2/blob/debc31e1716c7580566dc63d2af253eebb272198/src/blob.c#L330) with repository path, should be commondir. Probably not the only place. In the git project they made a refactoring replacing all string concatenations with function like path(repo, subpath), which encapsulated all knowledge about what is common and what is private in one place.\r\n\r\nFixing this, and https://github.com/libgit2/libgit2/issues/3994 , and making sure there is no drive letter path issue, I managed to make GitDiffMargin work. Maybe a bit later I could try to check also the official TFS/Git, though I suspect it might be harder."}}
{"actor":{"display_login":"max630"}}