{"push_id":1400474867,"size":22,"distinct_size":22,"ref":"refs/heads/master","head":"ee2bfe300bfd6f3617ef95cb2d2e357326802430","before":"9619f47e75c29f2ed02ff0cb5bf635523b049bf1","commits":[{"sha":"18fbe719ef8a9addc9b810dd6c7961c64b0b122e","author":{"name":"K. Shankari","email":"8df60ce8d21ba0b217aacda6d3c2977f8128b8cb@eecs.berkeley.edu"},"message":"Change the log calls to use the new promisified interface as well\n\nWorks now!","distinct":true,"url":"https://api.github.com/repos/grossman11/e-mission-phone/commits/18fbe719ef8a9addc9b810dd6c7961c64b0b122e"},{"sha":"92df971fef565415e8122e45fc1d7c03b096a638","author":{"name":"K. Shankari","email":"8df60ce8d21ba0b217aacda6d3c2977f8128b8cb@eecs.berkeley.edu"},"message":"Remove the app preferences plugin since we use local storage for all user stuff\n\nAnd have a direct method to check/set consent for the native code.","distinct":true,"url":"https://api.github.com/repos/grossman11/e-mission-phone/commits/92df971fef565415e8122e45fc1d7c03b096a638"},{"sha":"e5d9a87e591fe2b0967c97fe0a335bc04ccfbb47","author":{"name":"K. Shankari","email":"8df60ce8d21ba0b217aacda6d3c2977f8128b8cb@eecs.berkeley.edu"},"message":"Clear all storage\n\nIn addition to clearing the usercache, also clear all local storage.\nThis makes the actual behavior more consistent with something that says \"Nuke\nall buffers and cache\".","distinct":true,"url":"https://api.github.com/repos/grossman11/e-mission-phone/commits/e5d9a87e591fe2b0967c97fe0a335bc04ccfbb47"},{"sha":"c9dfd56940271922223cf52d4a0c9cea112975b7","author":{"name":"K. Shankari","email":"8df60ce8d21ba0b217aacda6d3c2977f8128b8cb@eecs.berkeley.edu"},"message":"Fix the recent tab\n\nI know that nobody cares about this tab but me, but I like to keep my\nfunctionality working without regression. And the recent tab is actually\nuseful!\n\nIn order to match\n https://github.com/e-mission/cordova-usercache/pull/25/commits/9ccd387b8be8b2a81b713bcdc4615c3b87002cb4 from\nhttps://github.com/e-mission/cordova-usercache/pull/25\nensure that we pass in the withMetadata argument for each usercache get\nfunction","distinct":true,"url":"https://api.github.com/repos/grossman11/e-mission-phone/commits/c9dfd56940271922223cf52d4a0c9cea112975b7"},{"sha":"716621eaac1d7407a334c8b54325c9da0f2324d6","author":{"name":"K. Shankari","email":"8df60ce8d21ba0b217aacda6d3c2977f8128b8cb@eecs.berkeley.edu"},"message":"Now that we have merged the client stats with the usercache\n\nwe can delete that plugin, and also delete the sqlite plugin, since we don't\nwant to have any native + sqlite code any more.","distinct":true,"url":"https://api.github.com/repos/grossman11/e-mission-phone/commits/716621eaac1d7407a334c8b54325c9da0f2324d6"},{"sha":"58adfe4c3b58073cd6d2c6ca4ee416275d88b9a2","author":{"name":"K. Shankari","email":"8df60ce8d21ba0b217aacda6d3c2977f8128b8cb@eecs.berkeley.edu"},"message":"Handle the case where the common data is undefined because it takes too long to load\n\nThis fixes #111.\nWe were already checking for the result of trip2Common, but this didn't work if there was an error in trip2Common...","distinct":true,"url":"https://api.github.com/repos/grossman11/e-mission-phone/commits/58adfe4c3b58073cd6d2c6ca4ee416275d88b9a2"},{"sha":"667aa722276b9480cffb0e95304f83d7cbbe85ec","author":{"name":"K. Shankari","email":"8df60ce8d21ba0b217aacda6d3c2977f8128b8cb@eecs.berkeley.edu"},"message":"Remove the statusbar plugin\n\nWe don't use it, and it takes ~ 100ms to load.\nAlso comment out the one use of it in the code.","distinct":true,"url":"https://api.github.com/repos/grossman11/e-mission-phone/commits/667aa722276b9480cffb0e95304f83d7cbbe85ec"},{"sha":"5ee2f9df8f60f960a3e8d28371407eb0c036a9c5","author":{"name":"K. Shankari","email":"8df60ce8d21ba0b217aacda6d3c2977f8128b8cb@eecs.berkeley.edu"},"message":"Fallback to isNaN if Number.isFinite is not defined\n\nIt looks like Number.isFinite is not available in version 8.4.\nI wonder if this is why Joan was getting the error in the dashboard.\nLet's fall back to isNaN in that case.","distinct":true,"url":"https://api.github.com/repos/grossman11/e-mission-phone/commits/5ee2f9df8f60f960a3e8d28371407eb0c036a9c5"},{"sha":"621bcc68af525328610101380e0ebc42922d5441","author":{"name":"K. Shankari","email":"8df60ce8d21ba0b217aacda6d3c2977f8128b8cb@eecs.berkeley.edu"},"message":"Use the correct reference to createEmpty()\n\nIf there was no common doc, `createEmpty()` was called.\nBut now that we are a factory and not a service, we need to preface the method\nname with the variable name.","distinct":true,"url":"https://api.github.com/repos/grossman11/e-mission-phone/commits/621bcc68af525328610101380e0ebc42922d5441"},{"sha":"58b0d6320ab2ac4bad7379a8eb6dacaef6b7f386","author":{"name":"K. Shankari","email":"8df60ce8d21ba0b217aacda6d3c2977f8128b8cb@eecs.berkeley.edu"},"message":"Client stats factory and usage\n\n- Add a new factory for the client stats\n- Use it to define client time, event and error methods\n- Log a stat every time we switch tabs (example of client_time)\n- Log errors in the tab switching (example of client_error)\n- Log when we forced sync (example of client_nav_event)\n- Add the new factory to index.html!\n\nRelated usercache code is\nhttps://github.com/e-mission/cordova-usercache/commit/67ae0c9d8d6fe454d3dfded1a46d95b262f75aac\nserver code is\nhttps://github.com/e-mission/e-mission-server/commit/7487c82578e8933f4da8f9d3fa3522c102906c81","distinct":true,"url":"https://api.github.com/repos/grossman11/e-mission-phone/commits/58b0d6320ab2ac4bad7379a8eb6dacaef6b7f386"},{"sha":"ae55d66d494ed288767ad36ad86345e79eab0bd8","author":{"name":"shankari","email":"8df60ce8d21ba0b217aacda6d3c2977f8128b8cb@eecs.berkeley.edu"},"message":"Merge pull request #179 from shankari/remove_unncessary_plugins\n\nRemove unncessary plugins","distinct":true,"url":"https://api.github.com/repos/grossman11/e-mission-phone/commits/ae55d66d494ed288767ad36ad86345e79eab0bd8"},{"sha":"bed2d72762e6e6c430995a12070f3f47dda40850","author":{"name":"K. Shankari","email":"8df60ce8d21ba0b217aacda6d3c2977f8128b8cb@eecs.berkeley.edu"},"message":"Added a few more test users to be ignored to the list","distinct":true,"url":"https://api.github.com/repos/grossman11/e-mission-phone/commits/bed2d72762e6e6c430995a12070f3f47dda40850"},{"sha":"a8b172707f69a5cecff67688b45eee466b4321e4","author":{"name":"K. Shankari","email":"8df60ce8d21ba0b217aacda6d3c2977f8128b8cb@eecs.berkeley.edu"},"message":"Bump up version number to 1.3.0","distinct":true,"url":"https://api.github.com/repos/grossman11/e-mission-phone/commits/a8b172707f69a5cecff67688b45eee466b4321e4"},{"sha":"775afd04d939283c733911c49db24e3deba9b6c2","author":{"name":"K. Shankari","email":"8df60ce8d21ba0b217aacda6d3c2977f8128b8cb@eecs.berkeley.edu"},"message":"Bump up the version number\n\nThis was bumped up twice by mistake because I wanted to test\nhttps://github.com/e-mission/e-mission-data-collection/issues/141\nbut didn't end up bumping back down.\n\nOh well, there are a lot of changes in this release... :)","distinct":true,"url":"https://api.github.com/repos/grossman11/e-mission-phone/commits/775afd04d939283c733911c49db24e3deba9b6c2"},{"sha":"88a0a58c5887825607f663951c0165902043cc17","author":{"name":"shankari","email":"8df60ce8d21ba0b217aacda6d3c2977f8128b8cb@eecs.berkeley.edu"},"message":"Merge pull request #180 from shankari/release_v130\n\nAdd more test users + bump up version number","distinct":true,"url":"https://api.github.com/repos/grossman11/e-mission-phone/commits/88a0a58c5887825607f663951c0165902043cc17"},{"sha":"5e11018e5b6f9e581cfa9f85f3584b4ee91ebe36","author":{"name":"K. Shankari","email":"8df60ce8d21ba0b217aacda6d3c2977f8128b8cb@eecs.berkeley.edu"},"message":"Really fix the trip diary load\n\nThe prior fix 58adfe4c3b58073cd6d2c6ca4ee416275d88b9a2 did not actually fix\neverything because when the data is loaded from the cache, commonGraph is\ndefined, and commonGraph.data is defined, but commonGraph.data.trip2CommonMap\nis not defined.\n\nThis additional check finally fixes #111.\n\nVerified by pulling today's data into the cache and then navigating to the diary.\n\nWithout this fix, got a blank screen.\nWith this fix, got the diary.","distinct":true,"url":"https://api.github.com/repos/grossman11/e-mission-phone/commits/5e11018e5b6f9e581cfa9f85f3584b4ee91ebe36"},{"sha":"bb51bcbc48786304904938d0a5617de79b16435c","author":{"name":"K. Shankari","email":"8df60ce8d21ba0b217aacda6d3c2977f8128b8cb@eecs.berkeley.edu"},"message":"Improve consent display and testing\n\nThis includes several minor changes to make it easier to handle and test\nconsent.\n\nIn particular:\n- If the user has not consented, allow her to reconsent without re-logging in\n- Improve the displayed message if the user *has* consented\n- change the nukeCache function to allow us to nuke only the local storage or\n  only the native storage, or both. This makes it easier to reproduce the test\n  condition and verify our solution.\n- Move the checkNativeConsent function to StartPrefs from ControlHelper, since\n  that's where all the consent stuff is, and promisify it properly\n- Add a callback at startup, once the native code is ready, to check the native\n  consent.\n\nNow we just need to figure out what to do in there.\nDocumentation on that choice is at https://github.com/e-mission/e-mission-phone/issues/181","distinct":true,"url":"https://api.github.com/repos/grossman11/e-mission-phone/commits/bb51bcbc48786304904938d0a5617de79b16435c"},{"sha":"2ea0f2e5a4eecf2c25cd40d322af1365b0946724","author":{"name":"K. Shankari","email":"8df60ce8d21ba0b217aacda6d3c2977f8128b8cb@eecs.berkeley.edu"},"message":"Handle the local: present, native: missing case by writing to native\n\nThis is a fix for part (2) of https://github.com/e-mission/e-mission-phone/issues/181.\nIf localStorage stores consent but native does not, we set the value in the\nnative and let the user know. This is consistent with\nhttps://github.com/e-mission/e-mission-phone/issues/181#issuecomment-258757700\n\nWe still need to test and fix part (1) - i.e. why did the popup not show up?","distinct":true,"url":"https://api.github.com/repos/grossman11/e-mission-phone/commits/2ea0f2e5a4eecf2c25cd40d322af1365b0946724"},{"sha":"ebe1161b41a0f21d6a93a378351fa1a21d458c36","author":{"name":"shankari","email":"8df60ce8d21ba0b217aacda6d3c2977f8128b8cb@eecs.berkeley.edu"},"message":"Merge pull request #182 from shankari/minor_fandf_fixes\n\nReally fix the trip diary load","distinct":true,"url":"https://api.github.com/repos/grossman11/e-mission-phone/commits/ebe1161b41a0f21d6a93a378351fa1a21d458c36"},{"sha":"b993772e510d8b8ec19c3cc4cfd22e918d3223a5","author":{"name":"K. Shankari","email":"8df60ce8d21ba0b217aacda6d3c2977f8128b8cb@eecs.berkeley.edu"},"message":"Merge branch 'master' of https://github.com/e-mission/e-mission-phone into fix_consent_forever","distinct":true,"url":"https://api.github.com/repos/grossman11/e-mission-phone/commits/b993772e510d8b8ec19c3cc4cfd22e918d3223a5"}]}
{"actor":{"display_login":"grossman11"}}