{"action":"created","comment":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments/59990280","id":59990280,"diff_hunk":"@@ -146,6 +145,13 @@ public static boolean canHarvestBlock(Block block, EntityPlayer player, IBlockAc\n         return toolLevel >= block.getHarvestLevel(state);\n     }\n \n+    public static boolean canHarvestBlock(Block block, EntityPlayer player, IBlockAccess world, BlockPos pos)\n+    {\n+        IBlockState state = world.getBlockState(pos);\n+        state = state.getBlock().getActualState(state, world, pos);\n+        return canHarvestBlock(block, player, state);","path":"src/main/java/net/minecraftforge/common/ForgeHooks.java","position":27,"original_position":27,"commit_id":"c09e6cf7d979d75fd23c6986c58f595d5f7d836a","original_commit_id":"c09e6cf7d979d75fd23c6986c58f595d5f7d836a","user":{"login":"squeek502","id":2389051,"avatar_url":"https://avatars.githubusercontent.com/u/2389051?v=3","gravatar_id":"","url":"https://api.github.com/users/squeek502","html_url":"https://github.com/squeek502","followers_url":"https://api.github.com/users/squeek502/followers","following_url":"https://api.github.com/users/squeek502/following{/other_user}","gists_url":"https://api.github.com/users/squeek502/gists{/gist_id}","starred_url":"https://api.github.com/users/squeek502/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squeek502/subscriptions","organizations_url":"https://api.github.com/users/squeek502/orgs","repos_url":"https://api.github.com/users/squeek502/repos","events_url":"https://api.github.com/users/squeek502/events{/privacy}","received_events_url":"https://api.github.com/users/squeek502/received_events","type":"User","site_admin":false},"body":"Yup, I'm a dummy. Thanks for catching that.","created_at":"2016-04-17T18:58:24Z","updated_at":"2016-04-17T18:58:24Z","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2769#discussion_r59990280","pull_request_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2769","_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments/59990280"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/2769#discussion_r59990280"},"pull_request":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2769"}}},"pull_request":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2769","id":66724712,"html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2769","diff_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2769.diff","patch_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2769.patch","issue_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2769","number":2769,"state":"open","locked":false,"title":"Add position-agnostic ForgeHooks.canHarvestBlock method","user":{"login":"squeek502","id":2389051,"avatar_url":"https://avatars.githubusercontent.com/u/2389051?v=3","gravatar_id":"","url":"https://api.github.com/users/squeek502","html_url":"https://github.com/squeek502","followers_url":"https://api.github.com/users/squeek502/followers","following_url":"https://api.github.com/users/squeek502/following{/other_user}","gists_url":"https://api.github.com/users/squeek502/gists{/gist_id}","starred_url":"https://api.github.com/users/squeek502/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squeek502/subscriptions","organizations_url":"https://api.github.com/users/squeek502/orgs","repos_url":"https://api.github.com/users/squeek502/repos","events_url":"https://api.github.com/users/squeek502/events{/privacy}","received_events_url":"https://api.github.com/users/squeek502/received_events","type":"User","site_admin":false},"body":" - The only use for world/position that the existing canHarvestBlock has is to get the block state\r\n - IBlockState as the third param matches better with previous versions of ForgeHooks.canHarvestBlock (it was `int meta` in 1.7)\r\n - Getting the harvestability of a block without the position can be useful for getting the harvestability of a block that is disguised as a different block\r\n\r\nSpecific use-case: https://github.com/squeek502/WailaHarvestability/issues/45","created_at":"2016-04-16T02:12:37Z","updated_at":"2016-04-17T18:58:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3151c1685790cda02aabf1b94fb9fed62e6a4bec","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2769/commits","review_comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2769/comments","review_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2769/comments","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/c09e6cf7d979d75fd23c6986c58f595d5f7d836a","head":{"label":"squeek502:can-harvest-block","ref":"can-harvest-block","sha":"c09e6cf7d979d75fd23c6986c58f595d5f7d836a","user":{"login":"squeek502","id":2389051,"avatar_url":"https://avatars.githubusercontent.com/u/2389051?v=3","gravatar_id":"","url":"https://api.github.com/users/squeek502","html_url":"https://github.com/squeek502","followers_url":"https://api.github.com/users/squeek502/followers","following_url":"https://api.github.com/users/squeek502/following{/other_user}","gists_url":"https://api.github.com/users/squeek502/gists{/gist_id}","starred_url":"https://api.github.com/users/squeek502/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squeek502/subscriptions","organizations_url":"https://api.github.com/users/squeek502/orgs","repos_url":"https://api.github.com/users/squeek502/repos","events_url":"https://api.github.com/users/squeek502/events{/privacy}","received_events_url":"https://api.github.com/users/squeek502/received_events","type":"User","site_admin":false},"repo":{"id":23057519,"name":"MinecraftForge","full_name":"squeek502/MinecraftForge","owner":{"login":"squeek502","id":2389051,"avatar_url":"https://avatars.githubusercontent.com/u/2389051?v=3","gravatar_id":"","url":"https://api.github.com/users/squeek502","html_url":"https://github.com/squeek502","followers_url":"https://api.github.com/users/squeek502/followers","following_url":"https://api.github.com/users/squeek502/following{/other_user}","gists_url":"https://api.github.com/users/squeek502/gists{/gist_id}","starred_url":"https://api.github.com/users/squeek502/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squeek502/subscriptions","organizations_url":"https://api.github.com/users/squeek502/orgs","repos_url":"https://api.github.com/users/squeek502/repos","events_url":"https://api.github.com/users/squeek502/events{/privacy}","received_events_url":"https://api.github.com/users/squeek502/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/squeek502/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":true,"url":"https://api.github.com/repos/squeek502/MinecraftForge","forks_url":"https://api.github.com/repos/squeek502/MinecraftForge/forks","keys_url":"https://api.github.com/repos/squeek502/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/squeek502/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/squeek502/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/squeek502/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/squeek502/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/squeek502/MinecraftForge/events","assignees_url":"https://api.github.com/repos/squeek502/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/squeek502/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/squeek502/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/squeek502/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/squeek502/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/squeek502/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/squeek502/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/squeek502/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/squeek502/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/squeek502/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/squeek502/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/squeek502/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/squeek502/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/squeek502/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/squeek502/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/squeek502/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/squeek502/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/squeek502/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/squeek502/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/squeek502/MinecraftForge/merges","archive_url":"https://api.github.com/repos/squeek502/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/squeek502/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/squeek502/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/squeek502/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/squeek502/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/squeek502/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/squeek502/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/squeek502/MinecraftForge/releases{/id}","deployments_url":"https://api.github.com/repos/squeek502/MinecraftForge/deployments","created_at":"2014-08-18T03:33:32Z","updated_at":"2014-08-18T03:34:45Z","pushed_at":"2016-04-17T05:12:18Z","git_url":"git://github.com/squeek502/MinecraftForge.git","ssh_url":"git@github.com:squeek502/MinecraftForge.git","clone_url":"https://github.com/squeek502/MinecraftForge.git","svn_url":"https://github.com/squeek502/MinecraftForge","homepage":"","size":83525,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MinecraftForge:master","ref":"master","sha":"d31cf8ddbc52c9d5d9792762fd7d06a756848ff3","user":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars.githubusercontent.com/u/1390178?v=3","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"repo":{"id":3301400,"name":"MinecraftForge","full_name":"MinecraftForge/MinecraftForge","owner":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars.githubusercontent.com/u/1390178?v=3","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MinecraftForge/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":false,"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge","forks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/forks","keys_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/events","assignees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/merges","archive_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/releases{/id}","deployments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/deployments","created_at":"2012-01-30T01:35:01Z","updated_at":"2016-04-17T14:36:39Z","pushed_at":"2016-04-17T05:12:19Z","git_url":"git://github.com/MinecraftForge/MinecraftForge.git","ssh_url":"git@github.com:MinecraftForge/MinecraftForge.git","clone_url":"https://github.com/MinecraftForge/MinecraftForge.git","svn_url":"https://github.com/MinecraftForge/MinecraftForge","homepage":"","size":144315,"stargazers_count":1328,"watchers_count":1328,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":743,"mirror_url":null,"open_issues_count":268,"forks":743,"open_issues":268,"watchers":1328,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2769"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/2769"},"issue":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2769"},"comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2769/comments"},"review_comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2769/comments"},"review_comment":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2769/commits"},"statuses":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/c09e6cf7d979d75fd23c6986c58f595d5f7d836a"}}}}