{"action":"created","comment":{"url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/comments/91297753","pull_request_review_id":11805444,"id":91297753,"diff_hunk":"@@ -1,2 +1,37 @@\n-class TestBaseConsensusRules(object):\n-    pass\n+from bigchaindb.consensus import BaseConsensusRules","path":"tests/test_consensus.py","position":3,"original_position":3,"commit_id":"c9a297a4f7d01fbeca99d60b8e14bf7f80f480ab","original_commit_id":"c9a297a4f7d01fbeca99d60b8e14bf7f80f480ab","user":{"login":"r-marques","id":1793187,"avatar_url":"https://avatars.githubusercontent.com/u/1793187?v=3","gravatar_id":"","url":"https://api.github.com/users/r-marques","html_url":"https://github.com/r-marques","followers_url":"https://api.github.com/users/r-marques/followers","following_url":"https://api.github.com/users/r-marques/following{/other_user}","gists_url":"https://api.github.com/users/r-marques/gists{/gist_id}","starred_url":"https://api.github.com/users/r-marques/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r-marques/subscriptions","organizations_url":"https://api.github.com/users/r-marques/orgs","repos_url":"https://api.github.com/users/r-marques/repos","events_url":"https://api.github.com/users/r-marques/events{/privacy}","received_events_url":"https://api.github.com/users/r-marques/received_events","type":"User","site_admin":false},"body":"I don't know if this was agreed by the team but we have been following the pattern in which we import test dependencies inside the tests instead of at the the top of the file.\r\n\r\nhttp://docs.pylonsproject.org/en/latest/community/testing.html#rule-never-import-the-module-under-test-at-test-module-scope","created_at":"2016-12-07T14:01:21Z","updated_at":"2016-12-07T14:01:21Z","html_url":"https://github.com/bigchaindb/bigchaindb/pull/865#discussion_r91297753","pull_request_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/865","_links":{"self":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/comments/91297753"},"html":{"href":"https://github.com/bigchaindb/bigchaindb/pull/865#discussion_r91297753"},"pull_request":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/865"}}},"pull_request":{"url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/865","id":95201986,"html_url":"https://github.com/bigchaindb/bigchaindb/pull/865","diff_url":"https://github.com/bigchaindb/bigchaindb/pull/865.diff","patch_url":"https://github.com/bigchaindb/bigchaindb/pull/865.patch","issue_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/865","number":865,"state":"open","locked":false,"title":"Vote schema","user":{"login":"libscott","id":125019,"avatar_url":"https://avatars.githubusercontent.com/u/125019?v=3","gravatar_id":"","url":"https://api.github.com/users/libscott","html_url":"https://github.com/libscott","followers_url":"https://api.github.com/users/libscott/followers","following_url":"https://api.github.com/users/libscott/following{/other_user}","gists_url":"https://api.github.com/users/libscott/gists{/gist_id}","starred_url":"https://api.github.com/users/libscott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libscott/subscriptions","organizations_url":"https://api.github.com/users/libscott/orgs","repos_url":"https://api.github.com/users/libscott/repos","events_url":"https://api.github.com/users/libscott/events{/privacy}","received_events_url":"https://api.github.com/users/libscott/received_events","type":"User","site_admin":false},"body":"Fixes #447.\r\n\r\n- [x] Complete vote schema .yaml file\r\n- [x] Validate votes in during `BigchainDB.block_election_status`\r\n- [x] Logs validation failures during block election\r\n- [x] Generate schema reference documentation\r\n- [x] Fix all broken tests\r\n- [x] New tests for valid and invalid vote\r\n- [x] Test .yaml sanity (via `additionalProperties`)\r\n- [x] Remove descriptions from yaml schemas loaded for validation to shorten error messages\r\n\r\n![screenshot from 2016-11-24 16-58-08](https://cloud.githubusercontent.com/assets/125019/20604558/4185c058-b267-11e6-8266-88b5b85b5c18.png)","created_at":"2016-11-24T16:01:55Z","updated_at":"2016-12-07T14:01:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fcdcbd736f4ec374ae132c3598e2316609abcdf5","assignee":{"login":"r-marques","id":1793187,"avatar_url":"https://avatars.githubusercontent.com/u/1793187?v=3","gravatar_id":"","url":"https://api.github.com/users/r-marques","html_url":"https://github.com/r-marques","followers_url":"https://api.github.com/users/r-marques/followers","following_url":"https://api.github.com/users/r-marques/following{/other_user}","gists_url":"https://api.github.com/users/r-marques/gists{/gist_id}","starred_url":"https://api.github.com/users/r-marques/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r-marques/subscriptions","organizations_url":"https://api.github.com/users/r-marques/orgs","repos_url":"https://api.github.com/users/r-marques/repos","events_url":"https://api.github.com/users/r-marques/events{/privacy}","received_events_url":"https://api.github.com/users/r-marques/received_events","type":"User","site_admin":false},"assignees":[{"login":"r-marques","id":1793187,"avatar_url":"https://avatars.githubusercontent.com/u/1793187?v=3","gravatar_id":"","url":"https://api.github.com/users/r-marques","html_url":"https://github.com/r-marques","followers_url":"https://api.github.com/users/r-marques/followers","following_url":"https://api.github.com/users/r-marques/following{/other_user}","gists_url":"https://api.github.com/users/r-marques/gists{/gist_id}","starred_url":"https://api.github.com/users/r-marques/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r-marques/subscriptions","organizations_url":"https://api.github.com/users/r-marques/orgs","repos_url":"https://api.github.com/users/r-marques/repos","events_url":"https://api.github.com/users/r-marques/events{/privacy}","received_events_url":"https://api.github.com/users/r-marques/received_events","type":"User","site_admin":false},{"login":"sohkai","id":4166642,"avatar_url":"https://avatars.githubusercontent.com/u/4166642?v=3","gravatar_id":"","url":"https://api.github.com/users/sohkai","html_url":"https://github.com/sohkai","followers_url":"https://api.github.com/users/sohkai/followers","following_url":"https://api.github.com/users/sohkai/following{/other_user}","gists_url":"https://api.github.com/users/sohkai/gists{/gist_id}","starred_url":"https://api.github.com/users/sohkai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sohkai/subscriptions","organizations_url":"https://api.github.com/users/sohkai/orgs","repos_url":"https://api.github.com/users/sohkai/repos","events_url":"https://api.github.com/users/sohkai/events{/privacy}","received_events_url":"https://api.github.com/users/sohkai/received_events","type":"User","site_admin":false},{"login":"diminator","id":6178597,"avatar_url":"https://avatars.githubusercontent.com/u/6178597?v=3","gravatar_id":"","url":"https://api.github.com/users/diminator","html_url":"https://github.com/diminator","followers_url":"https://api.github.com/users/diminator/followers","following_url":"https://api.github.com/users/diminator/following{/other_user}","gists_url":"https://api.github.com/users/diminator/gists{/gist_id}","starred_url":"https://api.github.com/users/diminator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diminator/subscriptions","organizations_url":"https://api.github.com/users/diminator/orgs","repos_url":"https://api.github.com/users/diminator/repos","events_url":"https://api.github.com/users/diminator/events{/privacy}","received_events_url":"https://api.github.com/users/diminator/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/865/commits","review_comments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/865/comments","review_comment_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/865/comments","statuses_url":"https://api.github.com/repos/bigchaindb/bigchaindb/statuses/c9a297a4f7d01fbeca99d60b8e14bf7f80f480ab","head":{"label":"bigchaindb:vote-schema","ref":"vote-schema","sha":"c9a297a4f7d01fbeca99d60b8e14bf7f80f480ab","user":{"login":"bigchaindb","id":17097586,"avatar_url":"https://avatars.githubusercontent.com/u/17097586?v=3","gravatar_id":"","url":"https://api.github.com/users/bigchaindb","html_url":"https://github.com/bigchaindb","followers_url":"https://api.github.com/users/bigchaindb/followers","following_url":"https://api.github.com/users/bigchaindb/following{/other_user}","gists_url":"https://api.github.com/users/bigchaindb/gists{/gist_id}","starred_url":"https://api.github.com/users/bigchaindb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigchaindb/subscriptions","organizations_url":"https://api.github.com/users/bigchaindb/orgs","repos_url":"https://api.github.com/users/bigchaindb/repos","events_url":"https://api.github.com/users/bigchaindb/events{/privacy}","received_events_url":"https://api.github.com/users/bigchaindb/received_events","type":"Organization","site_admin":false},"repo":{"id":51290852,"name":"bigchaindb","full_name":"bigchaindb/bigchaindb","owner":{"login":"bigchaindb","id":17097586,"avatar_url":"https://avatars.githubusercontent.com/u/17097586?v=3","gravatar_id":"","url":"https://api.github.com/users/bigchaindb","html_url":"https://github.com/bigchaindb","followers_url":"https://api.github.com/users/bigchaindb/followers","following_url":"https://api.github.com/users/bigchaindb/following{/other_user}","gists_url":"https://api.github.com/users/bigchaindb/gists{/gist_id}","starred_url":"https://api.github.com/users/bigchaindb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigchaindb/subscriptions","organizations_url":"https://api.github.com/users/bigchaindb/orgs","repos_url":"https://api.github.com/users/bigchaindb/repos","events_url":"https://api.github.com/users/bigchaindb/events{/privacy}","received_events_url":"https://api.github.com/users/bigchaindb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigchaindb/bigchaindb","description":"BigchainDB is a scalable blockchain database","fork":false,"url":"https://api.github.com/repos/bigchaindb/bigchaindb","forks_url":"https://api.github.com/repos/bigchaindb/bigchaindb/forks","keys_url":"https://api.github.com/repos/bigchaindb/bigchaindb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigchaindb/bigchaindb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigchaindb/bigchaindb/teams","hooks_url":"https://api.github.com/repos/bigchaindb/bigchaindb/hooks","issue_events_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/events{/number}","events_url":"https://api.github.com/repos/bigchaindb/bigchaindb/events","assignees_url":"https://api.github.com/repos/bigchaindb/bigchaindb/assignees{/user}","branches_url":"https://api.github.com/repos/bigchaindb/bigchaindb/branches{/branch}","tags_url":"https://api.github.com/repos/bigchaindb/bigchaindb/tags","blobs_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigchaindb/bigchaindb/statuses/{sha}","languages_url":"https://api.github.com/repos/bigchaindb/bigchaindb/languages","stargazers_url":"https://api.github.com/repos/bigchaindb/bigchaindb/stargazers","contributors_url":"https://api.github.com/repos/bigchaindb/bigchaindb/contributors","subscribers_url":"https://api.github.com/repos/bigchaindb/bigchaindb/subscribers","subscription_url":"https://api.github.com/repos/bigchaindb/bigchaindb/subscription","commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigchaindb/bigchaindb/contents/{+path}","compare_url":"https://api.github.com/repos/bigchaindb/bigchaindb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigchaindb/bigchaindb/merges","archive_url":"https://api.github.com/repos/bigchaindb/bigchaindb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigchaindb/bigchaindb/downloads","issues_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues{/number}","pulls_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls{/number}","milestones_url":"https://api.github.com/repos/bigchaindb/bigchaindb/milestones{/number}","notifications_url":"https://api.github.com/repos/bigchaindb/bigchaindb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigchaindb/bigchaindb/labels{/name}","releases_url":"https://api.github.com/repos/bigchaindb/bigchaindb/releases{/id}","deployments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/deployments","created_at":"2016-02-08T10:12:58Z","updated_at":"2016-12-07T12:36:59Z","pushed_at":"2016-12-07T10:59:04Z","git_url":"git://github.com/bigchaindb/bigchaindb.git","ssh_url":"git@github.com:bigchaindb/bigchaindb.git","clone_url":"https://github.com/bigchaindb/bigchaindb.git","svn_url":"https://github.com/bigchaindb/bigchaindb","homepage":"https://www.bigchaindb.com/","size":6415,"stargazers_count":834,"watchers_count":834,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":161,"mirror_url":null,"open_issues_count":177,"forks":161,"open_issues":177,"watchers":834,"default_branch":"master"}},"base":{"label":"bigchaindb:master","ref":"master","sha":"97ff0efd8b3baf78d03cdf54cff0c9293003aea5","user":{"login":"bigchaindb","id":17097586,"avatar_url":"https://avatars.githubusercontent.com/u/17097586?v=3","gravatar_id":"","url":"https://api.github.com/users/bigchaindb","html_url":"https://github.com/bigchaindb","followers_url":"https://api.github.com/users/bigchaindb/followers","following_url":"https://api.github.com/users/bigchaindb/following{/other_user}","gists_url":"https://api.github.com/users/bigchaindb/gists{/gist_id}","starred_url":"https://api.github.com/users/bigchaindb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigchaindb/subscriptions","organizations_url":"https://api.github.com/users/bigchaindb/orgs","repos_url":"https://api.github.com/users/bigchaindb/repos","events_url":"https://api.github.com/users/bigchaindb/events{/privacy}","received_events_url":"https://api.github.com/users/bigchaindb/received_events","type":"Organization","site_admin":false},"repo":{"id":51290852,"name":"bigchaindb","full_name":"bigchaindb/bigchaindb","owner":{"login":"bigchaindb","id":17097586,"avatar_url":"https://avatars.githubusercontent.com/u/17097586?v=3","gravatar_id":"","url":"https://api.github.com/users/bigchaindb","html_url":"https://github.com/bigchaindb","followers_url":"https://api.github.com/users/bigchaindb/followers","following_url":"https://api.github.com/users/bigchaindb/following{/other_user}","gists_url":"https://api.github.com/users/bigchaindb/gists{/gist_id}","starred_url":"https://api.github.com/users/bigchaindb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigchaindb/subscriptions","organizations_url":"https://api.github.com/users/bigchaindb/orgs","repos_url":"https://api.github.com/users/bigchaindb/repos","events_url":"https://api.github.com/users/bigchaindb/events{/privacy}","received_events_url":"https://api.github.com/users/bigchaindb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigchaindb/bigchaindb","description":"BigchainDB is a scalable blockchain database","fork":false,"url":"https://api.github.com/repos/bigchaindb/bigchaindb","forks_url":"https://api.github.com/repos/bigchaindb/bigchaindb/forks","keys_url":"https://api.github.com/repos/bigchaindb/bigchaindb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigchaindb/bigchaindb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigchaindb/bigchaindb/teams","hooks_url":"https://api.github.com/repos/bigchaindb/bigchaindb/hooks","issue_events_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/events{/number}","events_url":"https://api.github.com/repos/bigchaindb/bigchaindb/events","assignees_url":"https://api.github.com/repos/bigchaindb/bigchaindb/assignees{/user}","branches_url":"https://api.github.com/repos/bigchaindb/bigchaindb/branches{/branch}","tags_url":"https://api.github.com/repos/bigchaindb/bigchaindb/tags","blobs_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigchaindb/bigchaindb/statuses/{sha}","languages_url":"https://api.github.com/repos/bigchaindb/bigchaindb/languages","stargazers_url":"https://api.github.com/repos/bigchaindb/bigchaindb/stargazers","contributors_url":"https://api.github.com/repos/bigchaindb/bigchaindb/contributors","subscribers_url":"https://api.github.com/repos/bigchaindb/bigchaindb/subscribers","subscription_url":"https://api.github.com/repos/bigchaindb/bigchaindb/subscription","commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigchaindb/bigchaindb/contents/{+path}","compare_url":"https://api.github.com/repos/bigchaindb/bigchaindb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigchaindb/bigchaindb/merges","archive_url":"https://api.github.com/repos/bigchaindb/bigchaindb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigchaindb/bigchaindb/downloads","issues_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues{/number}","pulls_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls{/number}","milestones_url":"https://api.github.com/repos/bigchaindb/bigchaindb/milestones{/number}","notifications_url":"https://api.github.com/repos/bigchaindb/bigchaindb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigchaindb/bigchaindb/labels{/name}","releases_url":"https://api.github.com/repos/bigchaindb/bigchaindb/releases{/id}","deployments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/deployments","created_at":"2016-02-08T10:12:58Z","updated_at":"2016-12-07T12:36:59Z","pushed_at":"2016-12-07T10:59:04Z","git_url":"git://github.com/bigchaindb/bigchaindb.git","ssh_url":"git@github.com:bigchaindb/bigchaindb.git","clone_url":"https://github.com/bigchaindb/bigchaindb.git","svn_url":"https://github.com/bigchaindb/bigchaindb","homepage":"https://www.bigchaindb.com/","size":6415,"stargazers_count":834,"watchers_count":834,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":161,"mirror_url":null,"open_issues_count":177,"forks":161,"open_issues":177,"watchers":834,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/865"},"html":{"href":"https://github.com/bigchaindb/bigchaindb/pull/865"},"issue":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/865"},"comments":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/865/comments"},"review_comments":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/865/comments"},"review_comment":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/865/commits"},"statuses":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/statuses/c9a297a4f7d01fbeca99d60b8e14bf7f80f480ab"}}}}
{"actor":{"display_login":"r-marques"}}