{"action":"created","comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/pulls/comments/91318866","pull_request_review_id":11827026,"id":91318866,"diff_hunk":"@@ -46,6 +47,45 @@ public function getCMSFields()\n                     _t('EditableTextField.PLACEHOLDER', 'Placeholder')\n                 )\n             );\n+\n+            $fields->addFieldToTab(\n+                'Root.Main',\n+                DropdownField::create(\n+                    'Autocomplete',\n+                    'HTML5 Autocomplete value',\n+                    array(\n+                      'off' => 'Off',\n+                      'on' => 'On',","path":"code/model/editableformfields/EditableTextField.php","position":22,"original_position":22,"commit_id":"df7a8b1c073c9b8e42cb83663c2bf5e5fb5447f7","original_commit_id":"df7a8b1c073c9b8e42cb83663c2bf5e5fb5447f7","user":{"login":"dhensby","id":563596,"avatar_url":"https://avatars.githubusercontent.com/u/563596?v=3","gravatar_id":"","url":"https://api.github.com/users/dhensby","html_url":"https://github.com/dhensby","followers_url":"https://api.github.com/users/dhensby/followers","following_url":"https://api.github.com/users/dhensby/following{/other_user}","gists_url":"https://api.github.com/users/dhensby/gists{/gist_id}","starred_url":"https://api.github.com/users/dhensby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhensby/subscriptions","organizations_url":"https://api.github.com/users/dhensby/orgs","repos_url":"https://api.github.com/users/dhensby/repos","events_url":"https://api.github.com/users/dhensby/events{/privacy}","received_events_url":"https://api.github.com/users/dhensby/received_events","type":"User","site_admin":false},"body":"Aren't `on` and `off` the only valid values for the `autocomplete` attribute?","created_at":"2016-12-07T15:40:27Z","updated_at":"2016-12-07T15:40:31Z","html_url":"https://github.com/silverstripe/silverstripe-userforms/pull/527#discussion_r91318866","pull_request_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/pulls/527","_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-userforms/pulls/comments/91318866"},"html":{"href":"https://github.com/silverstripe/silverstripe-userforms/pull/527#discussion_r91318866"},"pull_request":{"href":"https://api.github.com/repos/silverstripe/silverstripe-userforms/pulls/527"}}},"pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/pulls/527","id":96908576,"html_url":"https://github.com/silverstripe/silverstripe-userforms/pull/527","diff_url":"https://github.com/silverstripe/silverstripe-userforms/pull/527.diff","patch_url":"https://github.com/silverstripe/silverstripe-userforms/pull/527.patch","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/issues/527","number":527,"state":"open","locked":false,"title":"Fixes #526 (autocomplete attributes)","user":{"login":"atomicjam","id":5812359,"avatar_url":"https://avatars.githubusercontent.com/u/5812359?v=3","gravatar_id":"","url":"https://api.github.com/users/atomicjam","html_url":"https://github.com/atomicjam","followers_url":"https://api.github.com/users/atomicjam/followers","following_url":"https://api.github.com/users/atomicjam/following{/other_user}","gists_url":"https://api.github.com/users/atomicjam/gists{/gist_id}","starred_url":"https://api.github.com/users/atomicjam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomicjam/subscriptions","organizations_url":"https://api.github.com/users/atomicjam/orgs","repos_url":"https://api.github.com/users/atomicjam/repos","events_url":"https://api.github.com/users/atomicjam/events{/privacy}","received_events_url":"https://api.github.com/users/atomicjam/received_events","type":"User","site_admin":false},"body":"adds ability for text fields to store additional html5 autocomplete\nattributes, attributes are per text field and populated from a dropdown\nlist from the html5 specification. (Credit card and password\nautocomplete values omitted as should user defined forms be used to\ncollect this information?)","created_at":"2016-12-07T11:48:38Z","updated_at":"2016-12-07T15:40:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce7e2c6de27783a9500f86e7e05eab99c5db92c2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/pulls/527/commits","review_comments_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/pulls/527/comments","review_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/issues/527/comments","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/statuses/df7a8b1c073c9b8e42cb83663c2bf5e5fb5447f7","head":{"label":"atomicjam:master","ref":"master","sha":"df7a8b1c073c9b8e42cb83663c2bf5e5fb5447f7","user":{"login":"atomicjam","id":5812359,"avatar_url":"https://avatars.githubusercontent.com/u/5812359?v=3","gravatar_id":"","url":"https://api.github.com/users/atomicjam","html_url":"https://github.com/atomicjam","followers_url":"https://api.github.com/users/atomicjam/followers","following_url":"https://api.github.com/users/atomicjam/following{/other_user}","gists_url":"https://api.github.com/users/atomicjam/gists{/gist_id}","starred_url":"https://api.github.com/users/atomicjam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomicjam/subscriptions","organizations_url":"https://api.github.com/users/atomicjam/orgs","repos_url":"https://api.github.com/users/atomicjam/repos","events_url":"https://api.github.com/users/atomicjam/events{/privacy}","received_events_url":"https://api.github.com/users/atomicjam/received_events","type":"User","site_admin":false},"repo":{"id":75830622,"name":"silverstripe-userforms","full_name":"atomicjam/silverstripe-userforms","owner":{"login":"atomicjam","id":5812359,"avatar_url":"https://avatars.githubusercontent.com/u/5812359?v=3","gravatar_id":"","url":"https://api.github.com/users/atomicjam","html_url":"https://github.com/atomicjam","followers_url":"https://api.github.com/users/atomicjam/followers","following_url":"https://api.github.com/users/atomicjam/following{/other_user}","gists_url":"https://api.github.com/users/atomicjam/gists{/gist_id}","starred_url":"https://api.github.com/users/atomicjam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomicjam/subscriptions","organizations_url":"https://api.github.com/users/atomicjam/orgs","repos_url":"https://api.github.com/users/atomicjam/repos","events_url":"https://api.github.com/users/atomicjam/events{/privacy}","received_events_url":"https://api.github.com/users/atomicjam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/atomicjam/silverstripe-userforms","description":"UserForms module provides a visual form builder for the SilverStripe CMS. No coding required to build forms such as contact pages.","fork":true,"url":"https://api.github.com/repos/atomicjam/silverstripe-userforms","forks_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/forks","keys_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/teams","hooks_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/hooks","issue_events_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/issues/events{/number}","events_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/events","assignees_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/assignees{/user}","branches_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/branches{/branch}","tags_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/tags","blobs_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/git/refs{/sha}","trees_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/statuses/{sha}","languages_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/languages","stargazers_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/stargazers","contributors_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/contributors","subscribers_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/subscribers","subscription_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/subscription","commits_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/commits{/sha}","git_commits_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/git/commits{/sha}","comments_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/comments{/number}","issue_comment_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/issues/comments{/number}","contents_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/contents/{+path}","compare_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/merges","archive_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/downloads","issues_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/issues{/number}","pulls_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/pulls{/number}","milestones_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/milestones{/number}","notifications_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/labels{/name}","releases_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/releases{/id}","deployments_url":"https://api.github.com/repos/atomicjam/silverstripe-userforms/deployments","created_at":"2016-12-07T11:42:39Z","updated_at":"2016-12-07T11:42:40Z","pushed_at":"2016-12-07T11:48:15Z","git_url":"git://github.com/atomicjam/silverstripe-userforms.git","ssh_url":"git@github.com:atomicjam/silverstripe-userforms.git","clone_url":"https://github.com/atomicjam/silverstripe-userforms.git","svn_url":"https://github.com/atomicjam/silverstripe-userforms","homepage":"","size":7739,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"silverstripe:master","ref":"master","sha":"1a74f45992aec9e5f7529cda69a3217fa84ef60e","user":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"repo":{"id":1247754,"name":"silverstripe-userforms","full_name":"silverstripe/silverstripe-userforms","owner":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/silverstripe/silverstripe-userforms","description":"UserForms module provides a visual form builder for the SilverStripe CMS. No coding required to build forms such as contact pages.","fork":false,"url":"https://api.github.com/repos/silverstripe/silverstripe-userforms","forks_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/forks","keys_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/teams","hooks_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/hooks","issue_events_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/issues/events{/number}","events_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/events","assignees_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/assignees{/user}","branches_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/branches{/branch}","tags_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/tags","blobs_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/statuses/{sha}","languages_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/languages","stargazers_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/stargazers","contributors_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/contributors","subscribers_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/subscribers","subscription_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/subscription","commits_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/issues/comments{/number}","contents_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/contents/{+path}","compare_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/merges","archive_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/downloads","issues_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/issues{/number}","pulls_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/pulls{/number}","milestones_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/milestones{/number}","notifications_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/labels{/name}","releases_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/releases{/id}","deployments_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/deployments","created_at":"2011-01-12T20:46:46Z","updated_at":"2016-11-30T14:57:06Z","pushed_at":"2016-12-07T11:48:38Z","git_url":"git://github.com/silverstripe/silverstripe-userforms.git","ssh_url":"git@github.com:silverstripe/silverstripe-userforms.git","clone_url":"https://github.com/silverstripe/silverstripe-userforms.git","svn_url":"https://github.com/silverstripe/silverstripe-userforms","homepage":"","size":8787,"stargazers_count":123,"watchers_count":123,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":160,"mirror_url":null,"open_issues_count":74,"forks":160,"open_issues":74,"watchers":123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-userforms/pulls/527"},"html":{"href":"https://github.com/silverstripe/silverstripe-userforms/pull/527"},"issue":{"href":"https://api.github.com/repos/silverstripe/silverstripe-userforms/issues/527"},"comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-userforms/issues/527/comments"},"review_comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-userforms/pulls/527/comments"},"review_comment":{"href":"https://api.github.com/repos/silverstripe/silverstripe-userforms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/silverstripe/silverstripe-userforms/pulls/527/commits"},"statuses":{"href":"https://api.github.com/repos/silverstripe/silverstripe-userforms/statuses/df7a8b1c073c9b8e42cb83663c2bf5e5fb5447f7"}}}}
{"actor":{"display_login":"dhensby"}}