{"action":"closed","issue":{"url":"https://api.github.com/repos/babel/babel/issues/4710","repository_url":"https://api.github.com/repos/babel/babel","labels_url":"https://api.github.com/repos/babel/babel/issues/4710/labels{/name}","comments_url":"https://api.github.com/repos/babel/babel/issues/4710/comments","events_url":"https://api.github.com/repos/babel/babel/issues/4710/events","html_url":"https://github.com/babel/babel/issues/4710","id":182359598,"number":4710,"title":"Run flow on latest version of node in CI","user":{"login":"hzoo","id":588473,"avatar_url":"https://avatars.githubusercontent.com/u/588473?v=3","gravatar_id":"","url":"https://api.github.com/users/hzoo","html_url":"https://github.com/hzoo","followers_url":"https://api.github.com/users/hzoo/followers","following_url":"https://api.github.com/users/hzoo/following{/other_user}","gists_url":"https://api.github.com/users/hzoo/gists{/gist_id}","starred_url":"https://api.github.com/users/hzoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzoo/subscriptions","organizations_url":"https://api.github.com/users/hzoo/orgs","repos_url":"https://api.github.com/users/hzoo/repos","events_url":"https://api.github.com/users/hzoo/events{/privacy}","received_events_url":"https://api.github.com/users/hzoo/received_events","type":"User","site_admin":false},"labels":[{"id":464921506,"url":"https://api.github.com/repos/babel/babel/labels/Hacktoberfest","name":"Hacktoberfest","color":"d93f0b","default":false},{"id":441915610,"url":"https://api.github.com/repos/babel/babel/labels/help%20wanted","name":"help wanted","color":"e99695","default":true},{"id":311566316,"url":"https://api.github.com/repos/babel/babel/labels/tag:%20internal","name":"tag: internal","color":"bfe5bf","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-11T20:01:07Z","updated_at":"2016-11-06T23:15:45Z","closed_at":"2016-11-06T23:15:45Z","body":"Basically the same as the eslint issue: https://github.com/babel/babel/issues/4638 and PR https://github.com/babel/babel/pull/4680\n\nWe should remove the comment https://github.com/gyandeeps/babel/blob/46615605a07fa92b926dd0ef35a52b7dda0e9fb4/Makefile#L49 too when it works.\n\nso I would make a new env variable like `FLOW` and run `./node_modules/.bin/flow check` instead of eslint for LINT\n\n```\nscript: \n  - 'if [ -n \"${LINT-}\" ]; then make lint ; fi'\n  - 'if [ -z \"${LINT-}\" ]; then make test-ci ; fi'\n\nmatrix:\n  fast_finish: true\n  include:\n    - node_js: \"node\"\n      env: LINT=true\n```\n"}}
{"actor":{"display_login":"hzoo"}}