{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/51064300","id":51064300,"diff_hunk":"@@ -3,12 +3,15 @@\n // Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.\n //-------------------------------------------------------------------------------------------------------\n #include \"CommonCommonPch.h\"\n-#include \"Common\\Int64Math.h\"\n-#include <intrin.h>\n+#include \"common/Int64Math.h\"\n+#include <stdint.h>\n \n+#if _WIN32 || _WIN64","path":"lib/common/common/Int64Math.cpp","position":9,"original_position":9,"commit_id":"eb5d8912eec17a8132f21b714fd1daeed0d626a6","original_commit_id":"eb5d8912eec17a8132f21b714fd1daeed0d626a6","user":{"login":"jianchun","id":11861955,"avatar_url":"https://avatars.githubusercontent.com/u/11861955?v=3","gravatar_id":"","url":"https://api.github.com/users/jianchun","html_url":"https://github.com/jianchun","followers_url":"https://api.github.com/users/jianchun/followers","following_url":"https://api.github.com/users/jianchun/following{/other_user}","gists_url":"https://api.github.com/users/jianchun/gists{/gist_id}","starred_url":"https://api.github.com/users/jianchun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jianchun/subscriptions","organizations_url":"https://api.github.com/users/jianchun/orgs","repos_url":"https://api.github.com/users/jianchun/repos","events_url":"https://api.github.com/users/jianchun/events{/privacy}","received_events_url":"https://api.github.com/users/jianchun/received_events","type":"User","site_admin":false},"body":"```#ifdef _WIN32``` suffices ([see msdn](https://msdn.microsoft.com/en-us/library/b0084kay.aspx))","created_at":"2016-01-27T22:55:50Z","updated_at":"2016-01-27T22:55:50Z","html_url":"https://github.com/Microsoft/ChakraCore/pull/206#discussion_r51064300","pull_request_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/206","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/51064300"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/206#discussion_r51064300"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/206"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/206","id":57347151,"html_url":"https://github.com/Microsoft/ChakraCore/pull/206","diff_url":"https://github.com/Microsoft/ChakraCore/pull/206.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/206.patch","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/206","number":206,"state":"open","locked":false,"title":"Int64common","user":{"login":"xanlpz","id":12952861,"avatar_url":"https://avatars.githubusercontent.com/u/12952861?v=3","gravatar_id":"","url":"https://api.github.com/users/xanlpz","html_url":"https://github.com/xanlpz","followers_url":"https://api.github.com/users/xanlpz/followers","following_url":"https://api.github.com/users/xanlpz/following{/other_user}","gists_url":"https://api.github.com/users/xanlpz/gists{/gist_id}","starred_url":"https://api.github.com/users/xanlpz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xanlpz/subscriptions","organizations_url":"https://api.github.com/users/xanlpz/orgs","repos_url":"https://api.github.com/users/xanlpz/repos","events_url":"https://api.github.com/users/xanlpz/events{/privacy}","received_events_url":"https://api.github.com/users/xanlpz/received_events","type":"User","site_admin":false},"body":"Per previous reviews:\r\n\r\n- Just use the stdint.h int64 min value everywhere.\r\n- Fallback to the !_mul128 implementation on !windows, this seems simpler for now.","created_at":"2016-01-27T11:31:10Z","updated_at":"2016-01-27T22:55:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fb99fcf4f70211839899afd35e2851a04a544e7","assignee":{"login":"jianchun","id":11861955,"avatar_url":"https://avatars.githubusercontent.com/u/11861955?v=3","gravatar_id":"","url":"https://api.github.com/users/jianchun","html_url":"https://github.com/jianchun","followers_url":"https://api.github.com/users/jianchun/followers","following_url":"https://api.github.com/users/jianchun/following{/other_user}","gists_url":"https://api.github.com/users/jianchun/gists{/gist_id}","starred_url":"https://api.github.com/users/jianchun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jianchun/subscriptions","organizations_url":"https://api.github.com/users/jianchun/orgs","repos_url":"https://api.github.com/users/jianchun/repos","events_url":"https://api.github.com/users/jianchun/events{/privacy}","received_events_url":"https://api.github.com/users/jianchun/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/206/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/206/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/206/comments","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/eb5d8912eec17a8132f21b714fd1daeed0d626a6","head":{"label":"xanlpz:int64common","ref":"int64common","sha":"eb5d8912eec17a8132f21b714fd1daeed0d626a6","user":{"login":"xanlpz","id":12952861,"avatar_url":"https://avatars.githubusercontent.com/u/12952861?v=3","gravatar_id":"","url":"https://api.github.com/users/xanlpz","html_url":"https://github.com/xanlpz","followers_url":"https://api.github.com/users/xanlpz/followers","following_url":"https://api.github.com/users/xanlpz/following{/other_user}","gists_url":"https://api.github.com/users/xanlpz/gists{/gist_id}","starred_url":"https://api.github.com/users/xanlpz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xanlpz/subscriptions","organizations_url":"https://api.github.com/users/xanlpz/orgs","repos_url":"https://api.github.com/users/xanlpz/repos","events_url":"https://api.github.com/users/xanlpz/events{/privacy}","received_events_url":"https://api.github.com/users/xanlpz/received_events","type":"User","site_admin":false},"repo":{"id":50435498,"name":"ChakraCore","full_name":"xanlpz/ChakraCore","owner":{"login":"xanlpz","id":12952861,"avatar_url":"https://avatars.githubusercontent.com/u/12952861?v=3","gravatar_id":"","url":"https://api.github.com/users/xanlpz","html_url":"https://github.com/xanlpz","followers_url":"https://api.github.com/users/xanlpz/followers","following_url":"https://api.github.com/users/xanlpz/following{/other_user}","gists_url":"https://api.github.com/users/xanlpz/gists{/gist_id}","starred_url":"https://api.github.com/users/xanlpz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xanlpz/subscriptions","organizations_url":"https://api.github.com/users/xanlpz/orgs","repos_url":"https://api.github.com/users/xanlpz/repos","events_url":"https://api.github.com/users/xanlpz/events{/privacy}","received_events_url":"https://api.github.com/users/xanlpz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xanlpz/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":true,"url":"https://api.github.com/repos/xanlpz/ChakraCore","forks_url":"https://api.github.com/repos/xanlpz/ChakraCore/forks","keys_url":"https://api.github.com/repos/xanlpz/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xanlpz/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xanlpz/ChakraCore/teams","hooks_url":"https://api.github.com/repos/xanlpz/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/xanlpz/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/xanlpz/ChakraCore/events","assignees_url":"https://api.github.com/repos/xanlpz/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/xanlpz/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/xanlpz/ChakraCore/tags","blobs_url":"https://api.github.com/repos/xanlpz/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xanlpz/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xanlpz/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/xanlpz/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xanlpz/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/xanlpz/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/xanlpz/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/xanlpz/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/xanlpz/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/xanlpz/ChakraCore/subscription","commits_url":"https://api.github.com/repos/xanlpz/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/xanlpz/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/xanlpz/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/xanlpz/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/xanlpz/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/xanlpz/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xanlpz/ChakraCore/merges","archive_url":"https://api.github.com/repos/xanlpz/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xanlpz/ChakraCore/downloads","issues_url":"https://api.github.com/repos/xanlpz/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/xanlpz/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/xanlpz/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/xanlpz/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xanlpz/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/xanlpz/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/xanlpz/ChakraCore/deployments","created_at":"2016-01-26T14:52:25Z","updated_at":"2016-01-26T14:52:41Z","pushed_at":"2016-01-27T11:28:44Z","git_url":"git://github.com/xanlpz/ChakraCore.git","ssh_url":"git@github.com:xanlpz/ChakraCore.git","clone_url":"https://github.com/xanlpz/ChakraCore.git","svn_url":"https://github.com/xanlpz/ChakraCore","homepage":null,"size":16775,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:linux","ref":"linux","sha":"3296b3897c4b0bc4a32dfc32f6c39c575d250579","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":49086513,"name":"ChakraCore","full_name":"Microsoft/ChakraCore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":false,"url":"https://api.github.com/repos/Microsoft/ChakraCore","forks_url":"https://api.github.com/repos/Microsoft/ChakraCore/forks","keys_url":"https://api.github.com/repos/Microsoft/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/events","assignees_url":"https://api.github.com/repos/Microsoft/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ChakraCore/merges","archive_url":"https://api.github.com/repos/Microsoft/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ChakraCore/deployments","created_at":"2016-01-05T19:05:31Z","updated_at":"2016-01-27T22:37:03Z","pushed_at":"2016-01-27T22:39:04Z","git_url":"git://github.com/Microsoft/ChakraCore.git","ssh_url":"git@github.com:Microsoft/ChakraCore.git","clone_url":"https://github.com/Microsoft/ChakraCore.git","svn_url":"https://github.com/Microsoft/ChakraCore","homepage":null,"size":17294,"stargazers_count":4678,"watchers_count":4678,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":447,"mirror_url":null,"open_issues_count":68,"forks":447,"open_issues":68,"watchers":4678,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/206"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/206"},"issue":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/206"},"comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/206/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/206/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/206/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/eb5d8912eec17a8132f21b714fd1daeed0d626a6"}}}}