{"action":"created","comment":{"url":"https://api.github.com/repos/dashpay/dash/pulls/comments/75846308","id":75846308,"diff_hunk":"@@ -1741,36 +1740,45 @@ NOTE:   unlike bitcoin we are using PREVIOUS block height here,\n */\n CAmount GetBlockSubsidy(int nPrevBits, int nPrevHeight, const Consensus::Params& consensusParams, bool fSuperblockPartOnly)\n {\n-    double dDiff = (double)0x0000ffff / (double)(nPrevBits & 0x00ffffff);\n-\n-    /* fixed bug caused diff to not be correctly calculated */\n-    if(nPrevHeight > 4500 || Params().NetworkIDString() != CBaseChainParams::MAIN) dDiff = ConvertBitsToDouble(nPrevBits);","path":"src/main.cpp","position":17,"original_position":17,"commit_id":"2339409ac0e518ee7124d0a26b3f4d80bc7bf682","original_commit_id":"2339409ac0e518ee7124d0a26b3f4d80bc7bf682","user":{"login":"schinzelh","id":636669,"avatar_url":"https://avatars.githubusercontent.com/u/636669?v=3","gravatar_id":"","url":"https://api.github.com/users/schinzelh","html_url":"https://github.com/schinzelh","followers_url":"https://api.github.com/users/schinzelh/followers","following_url":"https://api.github.com/users/schinzelh/following{/other_user}","gists_url":"https://api.github.com/users/schinzelh/gists{/gist_id}","starred_url":"https://api.github.com/users/schinzelh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schinzelh/subscriptions","organizations_url":"https://api.github.com/users/schinzelh/orgs","repos_url":"https://api.github.com/users/schinzelh/repos","events_url":"https://api.github.com/users/schinzelh/events{/privacy}","received_events_url":"https://api.github.com/users/schinzelh/received_events","type":"User","site_admin":false},"body":"Boolean logic: \r\n\r\n( A > 0 || B != C )\r\n\r\nequals\r\n\r\n(  !(A <= 0) || B != C)\r\n\r\nequals\r\n\r\n(  (A <= 0) && B = C)\r\n\r\n:+1: ","created_at":"2016-08-23T11:22:04Z","updated_at":"2016-08-23T11:22:04Z","html_url":"https://github.com/dashpay/dash/pull/953#discussion_r75846308","pull_request_url":"https://api.github.com/repos/dashpay/dash/pulls/953","_links":{"self":{"href":"https://api.github.com/repos/dashpay/dash/pulls/comments/75846308"},"html":{"href":"https://github.com/dashpay/dash/pull/953#discussion_r75846308"},"pull_request":{"href":"https://api.github.com/repos/dashpay/dash/pulls/953"}}},"pull_request":{"url":"https://api.github.com/repos/dashpay/dash/pulls/953","id":82086055,"html_url":"https://github.com/dashpay/dash/pull/953","diff_url":"https://github.com/dashpay/dash/pull/953.diff","patch_url":"https://github.com/dashpay/dash/pull/953.patch","issue_url":"https://api.github.com/repos/dashpay/dash/issues/953","number":953,"state":"open","locked":false,"title":"Streamline GetBlockSubsidy / fix coin cap comment","user":{"login":"UdjinM6","id":1935069,"avatar_url":"https://avatars.githubusercontent.com/u/1935069?v=3","gravatar_id":"","url":"https://api.github.com/users/UdjinM6","html_url":"https://github.com/UdjinM6","followers_url":"https://api.github.com/users/UdjinM6/followers","following_url":"https://api.github.com/users/UdjinM6/following{/other_user}","gists_url":"https://api.github.com/users/UdjinM6/gists{/gist_id}","starred_url":"https://api.github.com/users/UdjinM6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UdjinM6/subscriptions","organizations_url":"https://api.github.com/users/UdjinM6/orgs","repos_url":"https://api.github.com/users/UdjinM6/repos","events_url":"https://api.github.com/users/UdjinM6/events{/privacy}","received_events_url":"https://api.github.com/users/UdjinM6/received_events","type":"User","site_admin":false},"body":"GetBlockSubsidy() can be streamlined a bit. Also fixing a comment about projected coin cap.","created_at":"2016-08-20T18:36:47Z","updated_at":"2016-08-23T11:22:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ede53bb9998ec032ae2d1d022ec82fc3c00baa7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dashpay/dash/pulls/953/commits","review_comments_url":"https://api.github.com/repos/dashpay/dash/pulls/953/comments","review_comment_url":"https://api.github.com/repos/dashpay/dash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dashpay/dash/issues/953/comments","statuses_url":"https://api.github.com/repos/dashpay/dash/statuses/2339409ac0e518ee7124d0a26b3f4d80bc7bf682","head":{"label":"UdjinM6:streamlineGetBlockSubsidy","ref":"streamlineGetBlockSubsidy","sha":"2339409ac0e518ee7124d0a26b3f4d80bc7bf682","user":{"login":"UdjinM6","id":1935069,"avatar_url":"https://avatars.githubusercontent.com/u/1935069?v=3","gravatar_id":"","url":"https://api.github.com/users/UdjinM6","html_url":"https://github.com/UdjinM6","followers_url":"https://api.github.com/users/UdjinM6/followers","following_url":"https://api.github.com/users/UdjinM6/following{/other_user}","gists_url":"https://api.github.com/users/UdjinM6/gists{/gist_id}","starred_url":"https://api.github.com/users/UdjinM6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UdjinM6/subscriptions","organizations_url":"https://api.github.com/users/UdjinM6/orgs","repos_url":"https://api.github.com/users/UdjinM6/repos","events_url":"https://api.github.com/users/UdjinM6/events{/privacy}","received_events_url":"https://api.github.com/users/UdjinM6/received_events","type":"User","site_admin":false},"repo":{"id":26767942,"name":"dash","full_name":"UdjinM6/dash","owner":{"login":"UdjinM6","id":1935069,"avatar_url":"https://avatars.githubusercontent.com/u/1935069?v=3","gravatar_id":"","url":"https://api.github.com/users/UdjinM6","html_url":"https://github.com/UdjinM6","followers_url":"https://api.github.com/users/UdjinM6/followers","following_url":"https://api.github.com/users/UdjinM6/following{/other_user}","gists_url":"https://api.github.com/users/UdjinM6/gists{/gist_id}","starred_url":"https://api.github.com/users/UdjinM6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UdjinM6/subscriptions","organizations_url":"https://api.github.com/users/UdjinM6/orgs","repos_url":"https://api.github.com/users/UdjinM6/repos","events_url":"https://api.github.com/users/UdjinM6/events{/privacy}","received_events_url":"https://api.github.com/users/UdjinM6/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/UdjinM6/dash","description":"Dash - Reinventing Cryptocurrency","fork":true,"url":"https://api.github.com/repos/UdjinM6/dash","forks_url":"https://api.github.com/repos/UdjinM6/dash/forks","keys_url":"https://api.github.com/repos/UdjinM6/dash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UdjinM6/dash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UdjinM6/dash/teams","hooks_url":"https://api.github.com/repos/UdjinM6/dash/hooks","issue_events_url":"https://api.github.com/repos/UdjinM6/dash/issues/events{/number}","events_url":"https://api.github.com/repos/UdjinM6/dash/events","assignees_url":"https://api.github.com/repos/UdjinM6/dash/assignees{/user}","branches_url":"https://api.github.com/repos/UdjinM6/dash/branches{/branch}","tags_url":"https://api.github.com/repos/UdjinM6/dash/tags","blobs_url":"https://api.github.com/repos/UdjinM6/dash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UdjinM6/dash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UdjinM6/dash/git/refs{/sha}","trees_url":"https://api.github.com/repos/UdjinM6/dash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UdjinM6/dash/statuses/{sha}","languages_url":"https://api.github.com/repos/UdjinM6/dash/languages","stargazers_url":"https://api.github.com/repos/UdjinM6/dash/stargazers","contributors_url":"https://api.github.com/repos/UdjinM6/dash/contributors","subscribers_url":"https://api.github.com/repos/UdjinM6/dash/subscribers","subscription_url":"https://api.github.com/repos/UdjinM6/dash/subscription","commits_url":"https://api.github.com/repos/UdjinM6/dash/commits{/sha}","git_commits_url":"https://api.github.com/repos/UdjinM6/dash/git/commits{/sha}","comments_url":"https://api.github.com/repos/UdjinM6/dash/comments{/number}","issue_comment_url":"https://api.github.com/repos/UdjinM6/dash/issues/comments{/number}","contents_url":"https://api.github.com/repos/UdjinM6/dash/contents/{+path}","compare_url":"https://api.github.com/repos/UdjinM6/dash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UdjinM6/dash/merges","archive_url":"https://api.github.com/repos/UdjinM6/dash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UdjinM6/dash/downloads","issues_url":"https://api.github.com/repos/UdjinM6/dash/issues{/number}","pulls_url":"https://api.github.com/repos/UdjinM6/dash/pulls{/number}","milestones_url":"https://api.github.com/repos/UdjinM6/dash/milestones{/number}","notifications_url":"https://api.github.com/repos/UdjinM6/dash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UdjinM6/dash/labels{/name}","releases_url":"https://api.github.com/repos/UdjinM6/dash/releases{/id}","deployments_url":"https://api.github.com/repos/UdjinM6/dash/deployments","created_at":"2014-11-17T17:21:16Z","updated_at":"2016-06-02T12:33:04Z","pushed_at":"2016-08-23T10:44:12Z","git_url":"git://github.com/UdjinM6/dash.git","ssh_url":"git@github.com:UdjinM6/dash.git","clone_url":"https://github.com/UdjinM6/dash.git","svn_url":"https://github.com/UdjinM6/dash","homepage":"https://www.dash.org","size":137250,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"dashpay:v0.12.1.x","ref":"v0.12.1.x","sha":"3b606b0c63f0d48cb796ef7d796488d605a33d3c","user":{"login":"dashpay","id":11511719,"avatar_url":"https://avatars.githubusercontent.com/u/11511719?v=3","gravatar_id":"","url":"https://api.github.com/users/dashpay","html_url":"https://github.com/dashpay","followers_url":"https://api.github.com/users/dashpay/followers","following_url":"https://api.github.com/users/dashpay/following{/other_user}","gists_url":"https://api.github.com/users/dashpay/gists{/gist_id}","starred_url":"https://api.github.com/users/dashpay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashpay/subscriptions","organizations_url":"https://api.github.com/users/dashpay/orgs","repos_url":"https://api.github.com/users/dashpay/repos","events_url":"https://api.github.com/users/dashpay/events{/privacy}","received_events_url":"https://api.github.com/users/dashpay/received_events","type":"Organization","site_admin":false},"repo":{"id":19352450,"name":"dash","full_name":"dashpay/dash","owner":{"login":"dashpay","id":11511719,"avatar_url":"https://avatars.githubusercontent.com/u/11511719?v=3","gravatar_id":"","url":"https://api.github.com/users/dashpay","html_url":"https://github.com/dashpay","followers_url":"https://api.github.com/users/dashpay/followers","following_url":"https://api.github.com/users/dashpay/following{/other_user}","gists_url":"https://api.github.com/users/dashpay/gists{/gist_id}","starred_url":"https://api.github.com/users/dashpay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashpay/subscriptions","organizations_url":"https://api.github.com/users/dashpay/orgs","repos_url":"https://api.github.com/users/dashpay/repos","events_url":"https://api.github.com/users/dashpay/events{/privacy}","received_events_url":"https://api.github.com/users/dashpay/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dashpay/dash","description":"Dash - Reinventing Cryptocurrency","fork":true,"url":"https://api.github.com/repos/dashpay/dash","forks_url":"https://api.github.com/repos/dashpay/dash/forks","keys_url":"https://api.github.com/repos/dashpay/dash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dashpay/dash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dashpay/dash/teams","hooks_url":"https://api.github.com/repos/dashpay/dash/hooks","issue_events_url":"https://api.github.com/repos/dashpay/dash/issues/events{/number}","events_url":"https://api.github.com/repos/dashpay/dash/events","assignees_url":"https://api.github.com/repos/dashpay/dash/assignees{/user}","branches_url":"https://api.github.com/repos/dashpay/dash/branches{/branch}","tags_url":"https://api.github.com/repos/dashpay/dash/tags","blobs_url":"https://api.github.com/repos/dashpay/dash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dashpay/dash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dashpay/dash/git/refs{/sha}","trees_url":"https://api.github.com/repos/dashpay/dash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dashpay/dash/statuses/{sha}","languages_url":"https://api.github.com/repos/dashpay/dash/languages","stargazers_url":"https://api.github.com/repos/dashpay/dash/stargazers","contributors_url":"https://api.github.com/repos/dashpay/dash/contributors","subscribers_url":"https://api.github.com/repos/dashpay/dash/subscribers","subscription_url":"https://api.github.com/repos/dashpay/dash/subscription","commits_url":"https://api.github.com/repos/dashpay/dash/commits{/sha}","git_commits_url":"https://api.github.com/repos/dashpay/dash/git/commits{/sha}","comments_url":"https://api.github.com/repos/dashpay/dash/comments{/number}","issue_comment_url":"https://api.github.com/repos/dashpay/dash/issues/comments{/number}","contents_url":"https://api.github.com/repos/dashpay/dash/contents/{+path}","compare_url":"https://api.github.com/repos/dashpay/dash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dashpay/dash/merges","archive_url":"https://api.github.com/repos/dashpay/dash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dashpay/dash/downloads","issues_url":"https://api.github.com/repos/dashpay/dash/issues{/number}","pulls_url":"https://api.github.com/repos/dashpay/dash/pulls{/number}","milestones_url":"https://api.github.com/repos/dashpay/dash/milestones{/number}","notifications_url":"https://api.github.com/repos/dashpay/dash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dashpay/dash/labels{/name}","releases_url":"https://api.github.com/repos/dashpay/dash/releases{/id}","deployments_url":"https://api.github.com/repos/dashpay/dash/deployments","created_at":"2014-05-01T17:45:34Z","updated_at":"2016-08-23T09:15:02Z","pushed_at":"2016-08-23T11:18:21Z","git_url":"git://github.com/dashpay/dash.git","ssh_url":"git@github.com:dashpay/dash.git","clone_url":"https://github.com/dashpay/dash.git","svn_url":"https://github.com/dashpay/dash","homepage":"https://www.dash.org","size":115026,"stargazers_count":298,"watchers_count":298,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":165,"mirror_url":null,"open_issues_count":36,"forks":165,"open_issues":36,"watchers":298,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dashpay/dash/pulls/953"},"html":{"href":"https://github.com/dashpay/dash/pull/953"},"issue":{"href":"https://api.github.com/repos/dashpay/dash/issues/953"},"comments":{"href":"https://api.github.com/repos/dashpay/dash/issues/953/comments"},"review_comments":{"href":"https://api.github.com/repos/dashpay/dash/pulls/953/comments"},"review_comment":{"href":"https://api.github.com/repos/dashpay/dash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dashpay/dash/pulls/953/commits"},"statuses":{"href":"https://api.github.com/repos/dashpay/dash/statuses/2339409ac0e518ee7124d0a26b3f4d80bc7bf682"}}}}
{"actor":{"display_login":"schinzelh"}}