{"action":"created","comment":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/71064090","id":71064090,"diff_hunk":"@@ -51,7 +54,7 @@ def renderLogin(self, request):\n                 details.update(infos)\n             request.getSession().user_info = details\n             state = request.args.get(\"state\", [\"\"])[0]\n-            print repr(state)\n+            log.msg(repr(state))","path":"master/buildbot/www/oauth2.py","position":20,"original_position":20,"commit_id":"65e3397b1278c26cb2474d905bda2f3714791221","original_commit_id":"65e3397b1278c26cb2474d905bda2f3714791221","user":{"login":"tardyp","id":109859,"avatar_url":"https://avatars.githubusercontent.com/u/109859?v=3","gravatar_id":"","url":"https://api.github.com/users/tardyp","html_url":"https://github.com/tardyp","followers_url":"https://api.github.com/users/tardyp/followers","following_url":"https://api.github.com/users/tardyp/following{/other_user}","gists_url":"https://api.github.com/users/tardyp/gists{/gist_id}","starred_url":"https://api.github.com/users/tardyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tardyp/subscriptions","organizations_url":"https://api.github.com/users/tardyp/orgs","repos_url":"https://api.github.com/users/tardyp/repos","events_url":"https://api.github.com/users/tardyp/events{/privacy}","received_events_url":"https://api.github.com/users/tardyp/received_events","type":"User","site_admin":false},"body":"I think that one is a left-over debug print.","created_at":"2016-07-16T10:04:30Z","updated_at":"2016-07-16T10:04:30Z","html_url":"https://github.com/buildbot/buildbot/pull/2321#discussion_r71064090","pull_request_url":"https://api.github.com/repos/buildbot/buildbot/pulls/2321","_links":{"self":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/71064090"},"html":{"href":"https://github.com/buildbot/buildbot/pull/2321#discussion_r71064090"},"pull_request":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2321"}}},"pull_request":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/2321","id":77705368,"html_url":"https://github.com/buildbot/buildbot/pull/2321","diff_url":"https://github.com/buildbot/buildbot/pull/2321.diff","patch_url":"https://github.com/buildbot/buildbot/pull/2321.patch","issue_url":"https://api.github.com/repos/buildbot/buildbot/issues/2321","number":2321,"state":"open","locked":false,"title":"few Python 3 related fixes","user":{"login":"sa2ajj","id":447092,"avatar_url":"https://avatars.githubusercontent.com/u/447092?v=3","gravatar_id":"","url":"https://api.github.com/users/sa2ajj","html_url":"https://github.com/sa2ajj","followers_url":"https://api.github.com/users/sa2ajj/followers","following_url":"https://api.github.com/users/sa2ajj/following{/other_user}","gists_url":"https://api.github.com/users/sa2ajj/gists{/gist_id}","starred_url":"https://api.github.com/users/sa2ajj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sa2ajj/subscriptions","organizations_url":"https://api.github.com/users/sa2ajj/orgs","repos_url":"https://api.github.com/users/sa2ajj/repos","events_url":"https://api.github.com/users/sa2ajj/events{/privacy}","received_events_url":"https://api.github.com/users/sa2ajj/received_events","type":"User","site_admin":false},"body":"* do not use 'print' use 'twisted.python.log'\r\n* use 'except ... as ...' instead of 'except ..., ...'","created_at":"2016-07-16T09:32:08Z","updated_at":"2016-07-16T10:04:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6bcde5a22a878c67123a8ade356be7d05f046f7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/buildbot/buildbot/pulls/2321/commits","review_comments_url":"https://api.github.com/repos/buildbot/buildbot/pulls/2321/comments","review_comment_url":"https://api.github.com/repos/buildbot/buildbot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/buildbot/buildbot/issues/2321/comments","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/65e3397b1278c26cb2474d905bda2f3714791221","head":{"label":"sa2ajj:python-3-fixes","ref":"python-3-fixes","sha":"65e3397b1278c26cb2474d905bda2f3714791221","user":{"login":"sa2ajj","id":447092,"avatar_url":"https://avatars.githubusercontent.com/u/447092?v=3","gravatar_id":"","url":"https://api.github.com/users/sa2ajj","html_url":"https://github.com/sa2ajj","followers_url":"https://api.github.com/users/sa2ajj/followers","following_url":"https://api.github.com/users/sa2ajj/following{/other_user}","gists_url":"https://api.github.com/users/sa2ajj/gists{/gist_id}","starred_url":"https://api.github.com/users/sa2ajj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sa2ajj/subscriptions","organizations_url":"https://api.github.com/users/sa2ajj/orgs","repos_url":"https://api.github.com/users/sa2ajj/repos","events_url":"https://api.github.com/users/sa2ajj/events{/privacy}","received_events_url":"https://api.github.com/users/sa2ajj/received_events","type":"User","site_admin":false},"repo":{"id":21306128,"name":"buildbot","full_name":"sa2ajj/buildbot","owner":{"login":"sa2ajj","id":447092,"avatar_url":"https://avatars.githubusercontent.com/u/447092?v=3","gravatar_id":"","url":"https://api.github.com/users/sa2ajj","html_url":"https://github.com/sa2ajj","followers_url":"https://api.github.com/users/sa2ajj/followers","following_url":"https://api.github.com/users/sa2ajj/following{/other_user}","gists_url":"https://api.github.com/users/sa2ajj/gists{/gist_id}","starred_url":"https://api.github.com/users/sa2ajj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sa2ajj/subscriptions","organizations_url":"https://api.github.com/users/sa2ajj/orgs","repos_url":"https://api.github.com/users/sa2ajj/repos","events_url":"https://api.github.com/users/sa2ajj/events{/privacy}","received_events_url":"https://api.github.com/users/sa2ajj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sa2ajj/buildbot","description":"Python-based continuous integration testing framework; send pull requests for your patches!","fork":true,"url":"https://api.github.com/repos/sa2ajj/buildbot","forks_url":"https://api.github.com/repos/sa2ajj/buildbot/forks","keys_url":"https://api.github.com/repos/sa2ajj/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sa2ajj/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sa2ajj/buildbot/teams","hooks_url":"https://api.github.com/repos/sa2ajj/buildbot/hooks","issue_events_url":"https://api.github.com/repos/sa2ajj/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/sa2ajj/buildbot/events","assignees_url":"https://api.github.com/repos/sa2ajj/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/sa2ajj/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/sa2ajj/buildbot/tags","blobs_url":"https://api.github.com/repos/sa2ajj/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sa2ajj/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sa2ajj/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/sa2ajj/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sa2ajj/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/sa2ajj/buildbot/languages","stargazers_url":"https://api.github.com/repos/sa2ajj/buildbot/stargazers","contributors_url":"https://api.github.com/repos/sa2ajj/buildbot/contributors","subscribers_url":"https://api.github.com/repos/sa2ajj/buildbot/subscribers","subscription_url":"https://api.github.com/repos/sa2ajj/buildbot/subscription","commits_url":"https://api.github.com/repos/sa2ajj/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/sa2ajj/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/sa2ajj/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/sa2ajj/buildbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/sa2ajj/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/sa2ajj/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sa2ajj/buildbot/merges","archive_url":"https://api.github.com/repos/sa2ajj/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sa2ajj/buildbot/downloads","issues_url":"https://api.github.com/repos/sa2ajj/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/sa2ajj/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/sa2ajj/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/sa2ajj/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sa2ajj/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/sa2ajj/buildbot/releases{/id}","deployments_url":"https://api.github.com/repos/sa2ajj/buildbot/deployments","created_at":"2014-06-28T15:55:46Z","updated_at":"2016-03-20T07:03:36Z","pushed_at":"2016-07-16T09:59:49Z","git_url":"git://github.com/sa2ajj/buildbot.git","ssh_url":"git@github.com:sa2ajj/buildbot.git","clone_url":"https://github.com/sa2ajj/buildbot.git","svn_url":"https://github.com/sa2ajj/buildbot","homepage":"http://buildbot.net","size":42020,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"upstream"}},"base":{"label":"buildbot:master","ref":"master","sha":"2319fb820fcb29e435dcfd37bb2be016d0081e52","user":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"repo":{"id":760165,"name":"buildbot","full_name":"buildbot/buildbot","owner":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buildbot/buildbot","description":"Python-based continuous integration testing framework; your pull requests are more than welcome!","fork":false,"url":"https://api.github.com/repos/buildbot/buildbot","forks_url":"https://api.github.com/repos/buildbot/buildbot/forks","keys_url":"https://api.github.com/repos/buildbot/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buildbot/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buildbot/buildbot/teams","hooks_url":"https://api.github.com/repos/buildbot/buildbot/hooks","issue_events_url":"https://api.github.com/repos/buildbot/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/buildbot/buildbot/events","assignees_url":"https://api.github.com/repos/buildbot/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/buildbot/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/buildbot/buildbot/tags","blobs_url":"https://api.github.com/repos/buildbot/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buildbot/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buildbot/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/buildbot/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/buildbot/buildbot/languages","stargazers_url":"https://api.github.com/repos/buildbot/buildbot/stargazers","contributors_url":"https://api.github.com/repos/buildbot/buildbot/contributors","subscribers_url":"https://api.github.com/repos/buildbot/buildbot/subscribers","subscription_url":"https://api.github.com/repos/buildbot/buildbot/subscription","commits_url":"https://api.github.com/repos/buildbot/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/buildbot/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/buildbot/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/buildbot/buildbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/buildbot/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/buildbot/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buildbot/buildbot/merges","archive_url":"https://api.github.com/repos/buildbot/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buildbot/buildbot/downloads","issues_url":"https://api.github.com/repos/buildbot/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/buildbot/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/buildbot/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/buildbot/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buildbot/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/buildbot/buildbot/releases{/id}","deployments_url":"https://api.github.com/repos/buildbot/buildbot/deployments","created_at":"2010-07-06T17:56:53Z","updated_at":"2016-07-15T21:25:06Z","pushed_at":"2016-07-16T09:59:51Z","git_url":"git://github.com/buildbot/buildbot.git","ssh_url":"git@github.com:buildbot/buildbot.git","clone_url":"https://github.com/buildbot/buildbot.git","svn_url":"https://github.com/buildbot/buildbot","homepage":"http://buildbot.net","size":93153,"stargazers_count":2238,"watchers_count":2238,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":923,"mirror_url":null,"open_issues_count":12,"forks":923,"open_issues":12,"watchers":2238,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2321"},"html":{"href":"https://github.com/buildbot/buildbot/pull/2321"},"issue":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/2321"},"comments":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/2321/comments"},"review_comments":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2321/comments"},"review_comment":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2321/commits"},"statuses":{"href":"https://api.github.com/repos/buildbot/buildbot/statuses/65e3397b1278c26cb2474d905bda2f3714791221"}}}}
{"actor":{"display_login":"tardyp"}}