{"action":"created","issue":{"url":"https://api.github.com/repos/ExLibrisGroup/primo-explore-package/issues/1","repository_url":"https://api.github.com/repos/ExLibrisGroup/primo-explore-package","labels_url":"https://api.github.com/repos/ExLibrisGroup/primo-explore-package/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/ExLibrisGroup/primo-explore-package/issues/1/comments","events_url":"https://api.github.com/repos/ExLibrisGroup/primo-explore-package/issues/1/events","html_url":"https://github.com/ExLibrisGroup/primo-explore-package/issues/1","id":187131545,"number":1,"title":"Overriding HTML files doesn't work","user":{"login":"kelunik","id":2743004,"avatar_url":"https://avatars.githubusercontent.com/u/2743004?v=3","gravatar_id":"","url":"https://api.github.com/users/kelunik","html_url":"https://github.com/kelunik","followers_url":"https://api.github.com/users/kelunik/followers","following_url":"https://api.github.com/users/kelunik/following{/other_user}","gists_url":"https://api.github.com/users/kelunik/gists{/gist_id}","starred_url":"https://api.github.com/users/kelunik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelunik/subscriptions","organizations_url":"https://api.github.com/users/kelunik/orgs","repos_url":"https://api.github.com/users/kelunik/repos","events_url":"https://api.github.com/users/kelunik/events{/privacy}","received_events_url":"https://api.github.com/users/kelunik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-03T17:07:08Z","updated_at":"2016-11-21T19:44:08Z","closed_at":null,"body":"I have a working [`devenv`](https://github.com/ExLibrisGroup/primo-explore-devenv), editing the CSS works fine. But replacing the HTML files doesn't work.\r\n\r\n```\r\nprimo-explore/custom/KIT/\r\n├── css\r\n│   ├── custom1.css\r\n│   └── README.md\r\n├── html\r\n│   ├── homepage\r\n│   │   └── homepage_en_US.html\r\n│   └── README.md\r\n├── img\r\n│   └── README.md\r\n├── js\r\n│   ├── custom.js\r\n│   └── README.md\r\n├── README.md\r\n└── showDirectives.txt\r\n```\r\n\r\nMoving `homepage_en_US.html` to a `homepage` directory makes at least the logged JSON seem to be right:\r\n\r\n```yml\r\n{ viewJs: [ 'custom/KIT/js/custom.js' ],\r\n  viewCss: [ 'custom/KIT/css/custom1.css' ],\r\n  centralCss: '',\r\n  favIcon: [],\r\n  libraryLogo: undefined,\r\n  resourceIcons: {},\r\n  homepageHtml: '',\r\n  staticHtml: \r\n   { homepage: \r\n      { en_US: 'custom/KIT/html/homepage/homepage_en_US.html',\r\n        default: 'custom/KIT/html/homepage/homepage_en_US.html' } } }\r\n```\r\n\r\nWithout the move, it looks like that:\r\n\r\n```yml\r\n{ viewJs: [ 'custom/KIT/js/custom.js' ],\r\n  viewCss: [ 'custom/KIT/css/custom1.css' ],\r\n  centralCss: '',\r\n  favIcon: [],\r\n  libraryLogo: undefined,\r\n  resourceIcons: {},\r\n  homepageHtml: '',\r\n  staticHtml: \r\n   { 'custom/KIT/html/homepage': \r\n      { en_US: 'custom/KIT/html/custom/KIT/html/homepage/custom/KIT/html/homepage_en_US.html',\r\n        default: 'custom/KIT/html/custom/KIT/html/homepage/custom/KIT/html/homepage_en_US.html' } } }\r\n```\r\n\r\nWhat we really want to replace is the following HTML file: `search/fullView/details/service-details.html`. How does the required folder structure look like?\r\n\r\nI found an example at https://github.com/noamamit92/primo-explore-altmetrics-widget, but that doesn't replace the HTML files."},"comment":{"url":"https://api.github.com/repos/ExLibrisGroup/primo-explore-package/issues/comments/262045563","html_url":"https://github.com/ExLibrisGroup/primo-explore-package/issues/1#issuecomment-262045563","issue_url":"https://api.github.com/repos/ExLibrisGroup/primo-explore-package/issues/1","id":262045563,"user":{"login":"noamamit92","id":8035487,"avatar_url":"https://avatars.githubusercontent.com/u/8035487?v=3","gravatar_id":"","url":"https://api.github.com/users/noamamit92","html_url":"https://github.com/noamamit92","followers_url":"https://api.github.com/users/noamamit92/followers","following_url":"https://api.github.com/users/noamamit92/following{/other_user}","gists_url":"https://api.github.com/users/noamamit92/gists{/gist_id}","starred_url":"https://api.github.com/users/noamamit92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noamamit92/subscriptions","organizations_url":"https://api.github.com/users/noamamit92/orgs","repos_url":"https://api.github.com/users/noamamit92/repos","events_url":"https://api.github.com/users/noamamit92/events{/privacy}","received_events_url":"https://api.github.com/users/noamamit92/received_events","type":"User","site_admin":false},"created_at":"2016-11-21T19:44:07Z","updated_at":"2016-11-21T19:44:07Z","body":"Hi, I committed a fix for the homepage file, I think it shoul solve your\nproblems if you update the primoProxy.js file\n\n\nOn Mon, 21 Nov 2016 at 18:35 Niklas Keller <notifications@github.com> wrote:\n\n> @noamamit92 <https://github.com/noamamit92> ping.\n>\n> —\n> You are receiving this because you were mentioned.\n>\n>\n> Reply to this email directly, view it on GitHub\n> <https://github.com/ExLibrisGroup/primo-explore-package/issues/1#issuecomment-261990907>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AHqcnxftxRYNOqsjSQ-imxPKft6hicS2ks5rAcg4gaJpZM4KoqXE>\n> .\n>\n"}}
{"actor":{"display_login":"noamamit92"}}