{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/5812","repository_url":"https://api.github.com/repos/apple/swift","labels_url":"https://api.github.com/repos/apple/swift/issues/5812/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/5812/comments","events_url":"https://api.github.com/repos/apple/swift/issues/5812/events","html_url":"https://github.com/apple/swift/pull/5812","id":189545914,"number":5812,"title":"[QoI] Improve diagnostics for type member names shadowing top-level functions","user":{"login":"xedin","id":21240,"avatar_url":"https://avatars.githubusercontent.com/u/21240?v=3","gravatar_id":"","url":"https://api.github.com/users/xedin","html_url":"https://github.com/xedin","followers_url":"https://api.github.com/users/xedin/followers","following_url":"https://api.github.com/users/xedin/following{/other_user}","gists_url":"https://api.github.com/users/xedin/gists{/gist_id}","starred_url":"https://api.github.com/users/xedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xedin/subscriptions","organizations_url":"https://api.github.com/users/xedin/orgs","repos_url":"https://api.github.com/users/xedin/repos","events_url":"https://api.github.com/users/xedin/events{/privacy}","received_events_url":"https://api.github.com/users/xedin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"rudkx","id":162784,"avatar_url":"https://avatars.githubusercontent.com/u/162784?v=3","gravatar_id":"","url":"https://api.github.com/users/rudkx","html_url":"https://github.com/rudkx","followers_url":"https://api.github.com/users/rudkx/followers","following_url":"https://api.github.com/users/rudkx/following{/other_user}","gists_url":"https://api.github.com/users/rudkx/gists{/gist_id}","starred_url":"https://api.github.com/users/rudkx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudkx/subscriptions","organizations_url":"https://api.github.com/users/rudkx/orgs","repos_url":"https://api.github.com/users/rudkx/repos","events_url":"https://api.github.com/users/rudkx/events{/privacy}","received_events_url":"https://api.github.com/users/rudkx/received_events","type":"User","site_admin":false},"assignees":[{"login":"rudkx","id":162784,"avatar_url":"https://avatars.githubusercontent.com/u/162784?v=3","gravatar_id":"","url":"https://api.github.com/users/rudkx","html_url":"https://github.com/rudkx","followers_url":"https://api.github.com/users/rudkx/followers","following_url":"https://api.github.com/users/rudkx/following{/other_user}","gists_url":"https://api.github.com/users/rudkx/gists{/gist_id}","starred_url":"https://api.github.com/users/rudkx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudkx/subscriptions","organizations_url":"https://api.github.com/users/rudkx/orgs","repos_url":"https://api.github.com/users/rudkx/repos","events_url":"https://api.github.com/users/rudkx/events{/privacy}","received_events_url":"https://api.github.com/users/rudkx/received_events","type":"User","site_admin":false}],"milestone":null,"comments":14,"created_at":"2016-11-16T00:15:05Z","updated_at":"2016-11-20T20:36:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/5812","html_url":"https://github.com/apple/swift/pull/5812","diff_url":"https://github.com/apple/swift/pull/5812.diff","patch_url":"https://github.com/apple/swift/pull/5812.patch"},"body":"Consider expression with an implicit 'self.' reference:\r\n```swift\r\nextension Sequence {\r\n  func test() -> Int {\r\n    return max(1, 2)\r\n  }\r\n}\r\n```\r\nWe currently shadow names that appear in nested scopes, so the\r\ntop-level two-argument min()/max() functions are shadowed by the\r\nversions of min()/max() in Sequence (which don’t take the same\r\nnumber of arguments). This patch aims to improve situation on this\r\nfront and produce better diagnostics when that happens, hinting\r\nthe user about what went wrong and where matching function is\r\ndeclared.\r\n\r\nResolves <rdar://problem/25341015>.\r\n<!--\r\nBefore merging this pull request, you must run the Swift continuous integration tests.\r\nFor information about triggering CI builds via @swift-ci, see:\r\nhttps://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci\r\n\r\nThank you for your contribution to Swift!\r\n-->"},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/261803706","html_url":"https://github.com/apple/swift/pull/5812#issuecomment-261803706","issue_url":"https://api.github.com/repos/apple/swift/issues/5812","id":261803706,"user":{"login":"xedin","id":21240,"avatar_url":"https://avatars.githubusercontent.com/u/21240?v=3","gravatar_id":"","url":"https://api.github.com/users/xedin","html_url":"https://github.com/xedin","followers_url":"https://api.github.com/users/xedin/followers","following_url":"https://api.github.com/users/xedin/following{/other_user}","gists_url":"https://api.github.com/users/xedin/gists{/gist_id}","starred_url":"https://api.github.com/users/xedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xedin/subscriptions","organizations_url":"https://api.github.com/users/xedin/orgs","repos_url":"https://api.github.com/users/xedin/repos","events_url":"https://api.github.com/users/xedin/events{/privacy}","received_events_url":"https://api.github.com/users/xedin/received_events","type":"User","site_admin":false},"created_at":"2016-11-20T20:36:19Z","updated_at":"2016-11-20T20:36:19Z","body":"@modocache Thanks, that's really helpful!"}}
{"actor":{"display_login":"xedin"}}