{"action":"created","issue":{"url":"https://api.github.com/repos/dlang/phobos/issues/4475","repository_url":"https://api.github.com/repos/dlang/phobos","labels_url":"https://api.github.com/repos/dlang/phobos/issues/4475/labels{/name}","comments_url":"https://api.github.com/repos/dlang/phobos/issues/4475/comments","events_url":"https://api.github.com/repos/dlang/phobos/issues/4475/events","html_url":"https://github.com/dlang/phobos/pull/4475","id":162307086,"number":4475,"title":"make @safe to digest strings whose element encoding type is char","user":{"login":"BBasile","id":16154339,"avatar_url":"https://avatars.githubusercontent.com/u/16154339?v=3","gravatar_id":"","url":"https://api.github.com/users/BBasile","html_url":"https://github.com/BBasile","followers_url":"https://api.github.com/users/BBasile/followers","following_url":"https://api.github.com/users/BBasile/following{/other_user}","gists_url":"https://api.github.com/users/BBasile/gists{/gist_id}","starred_url":"https://api.github.com/users/BBasile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BBasile/subscriptions","organizations_url":"https://api.github.com/users/BBasile/orgs","repos_url":"https://api.github.com/users/BBasile/repos","events_url":"https://api.github.com/users/BBasile/events{/privacy}","received_events_url":"https://api.github.com/users/BBasile/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2016-06-26T01:04:10Z","updated_at":"2016-07-08T20:45:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dlang/phobos/pulls/4475","html_url":"https://github.com/dlang/phobos/pull/4475","diff_url":"https://github.com/dlang/phobos/pull/4475.diff","patch_url":"https://github.com/dlang/phobos/pull/4475.patch"},"body":"because in this context the code points don't matter, put can take char[] and process it as ubyte[].\r\n\r\nHashing strings is very common. In the current state, so that strings can be hashed, a cast is necessary and this forces the users who want to write safe code to annotate with `@trusted`. This PR simplify this. Strings will be hashable in `@safe` code without extra work for the user.\r\n\r\nAnother part of the digest API could be safe if the toHexString function is `@safe` but this relies on assumeUnique so this is for a possible other PR."},"comment":{"url":"https://api.github.com/repos/dlang/phobos/issues/comments/231468288","html_url":"https://github.com/dlang/phobos/pull/4475#issuecomment-231468288","issue_url":"https://api.github.com/repos/dlang/phobos/issues/4475","id":231468288,"user":{"login":"schveiguy","id":580778,"avatar_url":"https://avatars.githubusercontent.com/u/580778?v=3","gravatar_id":"","url":"https://api.github.com/users/schveiguy","html_url":"https://github.com/schveiguy","followers_url":"https://api.github.com/users/schveiguy/followers","following_url":"https://api.github.com/users/schveiguy/following{/other_user}","gists_url":"https://api.github.com/users/schveiguy/gists{/gist_id}","starred_url":"https://api.github.com/users/schveiguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schveiguy/subscriptions","organizations_url":"https://api.github.com/users/schveiguy/orgs","repos_url":"https://api.github.com/users/schveiguy/repos","events_url":"https://api.github.com/users/schveiguy/events{/privacy}","received_events_url":"https://api.github.com/users/schveiguy/received_events","type":"User","site_admin":false},"created_at":"2016-07-08T20:45:56Z","updated_at":"2016-07-08T20:45:56Z","body":"LGTM. Thanks."}}
{"actor":{"display_login":"schveiguy"}}