{"action":"created","issue":{"url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/issues/2","repository_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios","labels_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/issues/2/comments","events_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/issues/2/events","html_url":"https://github.com/Wolox/wolmo-authentication-ios/pull/2","id":142396541,"number":2,"title":"Login view layout","user":{"login":"danielaRiesgo","id":12351004,"avatar_url":"https://avatars.githubusercontent.com/u/12351004?v=3","gravatar_id":"","url":"https://api.github.com/users/danielaRiesgo","html_url":"https://github.com/danielaRiesgo","followers_url":"https://api.github.com/users/danielaRiesgo/followers","following_url":"https://api.github.com/users/danielaRiesgo/following{/other_user}","gists_url":"https://api.github.com/users/danielaRiesgo/gists{/gist_id}","starred_url":"https://api.github.com/users/danielaRiesgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielaRiesgo/subscriptions","organizations_url":"https://api.github.com/users/danielaRiesgo/orgs","repos_url":"https://api.github.com/users/danielaRiesgo/repos","events_url":"https://api.github.com/users/danielaRiesgo/events{/privacy}","received_events_url":"https://api.github.com/users/danielaRiesgo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"danielaRiesgo","id":12351004,"avatar_url":"https://avatars.githubusercontent.com/u/12351004?v=3","gravatar_id":"","url":"https://api.github.com/users/danielaRiesgo","html_url":"https://github.com/danielaRiesgo","followers_url":"https://api.github.com/users/danielaRiesgo/followers","following_url":"https://api.github.com/users/danielaRiesgo/following{/other_user}","gists_url":"https://api.github.com/users/danielaRiesgo/gists{/gist_id}","starred_url":"https://api.github.com/users/danielaRiesgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielaRiesgo/subscriptions","organizations_url":"https://api.github.com/users/danielaRiesgo/orgs","repos_url":"https://api.github.com/users/danielaRiesgo/repos","events_url":"https://api.github.com/users/danielaRiesgo/events{/privacy}","received_events_url":"https://api.github.com/users/danielaRiesgo/received_events","type":"User","site_admin":false},"milestone":null,"comments":8,"created_at":"2016-03-21T16:11:03Z","updated_at":"2016-03-23T13:44:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/pulls/2","html_url":"https://github.com/Wolox/wolmo-authentication-ios/pull/2","diff_url":"https://github.com/Wolox/wolmo-authentication-ios/pull/2.diff","patch_url":"https://github.com/Wolox/wolmo-authentication-ios/pull/2.patch"},"body":"## Sumary ##\r\n**Trello card**: https://trello.com/c/mHc2j1xc/4-vista-log-in\r\n\r\nAdded the default login view (xib file) and added to the logic the elements of the view that weren't binded yet.\r\nAdded a demo example of how to use the Authentication Boostrapper and be able to manually test the login process.\r\n\r\n## Test Plan ##\r\n\r\n(Don't click on \"forgot password ?\" and/or \"Register\"!)\r\n\r\n  * Open the app\r\n  * The only email-password combination that works is \"example@mail.com\" and \"password\".\r\n  * Tryout validation errors and login errors.\r\n\r\n## Screenshots ##\r\n\r\n### iPhone 4s\r\nInitial screen\r\n![4s vacio](https://cloud.githubusercontent.com/assets/12351004/13924647/e3ad3f36-ef63-11e5-874b-eb739ec21a01.png)\r\nValidation Errors\r\n![4s errores](https://cloud.githubusercontent.com/assets/12351004/13924652/e7236492-ef63-11e5-9cc7-76ff941676b7.png)\r\nBad login\r\n![4s mal login](https://cloud.githubusercontent.com/assets/12351004/13924657/ea0e3b00-ef63-11e5-86d0-c6dd88cd74ec.png)\r\nKeyboard showing\r\n![4s teclado](https://cloud.githubusercontent.com/assets/12351004/13924659/eb4b91d4-ef63-11e5-9796-177258c9e972.png)\r\n\r\n\r\n### iPhone 5c/5/5s\r\n\r\nInitial screen\r\n![5 vacio](https://cloud.githubusercontent.com/assets/12351004/13924709/15110486-ef64-11e5-95d7-db61a929e6e8.png)\r\nValidation Errors\r\n![5 errores](https://cloud.githubusercontent.com/assets/12351004/13924719/1d40c614-ef64-11e5-8a44-ada9b56f0e66.png)\r\nBad login\r\n![5 mal login](https://cloud.githubusercontent.com/assets/12351004/13924731/247e6332-ef64-11e5-837f-3ed2cf094380.png)\r\nKeyboard showing\r\n![5 teclado](https://cloud.githubusercontent.com/assets/12351004/13924736/28695b46-ef64-11e5-86b0-271b4f79edb7.png)\r\n\r\n### iPhone 6\r\n\r\nInitial screen\r\n![6 vacio](https://cloud.githubusercontent.com/assets/12351004/13924852/b42da45c-ef64-11e5-95cc-ece45e1c0a71.png)\r\nValidation Errors\r\n![6 errores](https://cloud.githubusercontent.com/assets/12351004/13924854/b6b07aa6-ef64-11e5-9d44-7daae9a676c5.png)\r\nBad login\r\n![6 mal login](https://cloud.githubusercontent.com/assets/12351004/13924857/b914f574-ef64-11e5-861e-c8b27c8eb977.png)\r\nKeyboard Showing\r\n![6 teclado](https://cloud.githubusercontent.com/assets/12351004/13924859/bb662302-ef64-11e5-934a-1d402786d30d.png)\r\n\r\n### iPhone 6s+\r\n\r\nInitial screen\r\n![6s plus vacio](https://cloud.githubusercontent.com/assets/12351004/13924770/4fea8ac8-ef64-11e5-88eb-6146844ce99b.png)\r\nValidation Errors\r\n![6s plus errores](https://cloud.githubusercontent.com/assets/12351004/13924778/5721db8e-ef64-11e5-9d2a-50235d104b40.png)\r\nBad login\r\n![6s plus mal login](https://cloud.githubusercontent.com/assets/12351004/13924782/5b4167de-ef64-11e5-9522-c90e0e2717ff.png)\r\nKeyboard Showing\r\n![6s plus teclado](https://cloud.githubusercontent.com/assets/12351004/13924784/5e112508-ef64-11e5-8afa-985596202e11.png)\r\n\r\n\r\n## Known issues ##\r\n\r\n1. Frame display when keyboard is showing looks good on iphone 6 and 6s plus but not in 4 and 5. (**Trello card**: https://trello.com/c/AlZ61WAX/21-arreglar-display-al-mostrar-el-teclado )\r\n2. In the password textfield and button, the textfield border is visible against the button although very dim. (**Trello card**: https://trello.com/c/MPUsMM3F/20-corregir-el-borde-del-textfield-para-la-contrasena-en-la-vista-de-login )\r\n3. When the security option is set on the password text field and the following actions happen, the already written password erases and starts writting again:\r\n    Write in password text field.\r\n    Change to email textield or click any other element OR touch show and hide again.\r\n    Click again in password text field to continue writing.\r\n(**Trello card**: https://trello.com/c/B3D4IKhw/22-bug-al-reescribir-contrasena-en-security-mode )\r\n4. When the user selects to show password, the font and size is not what expected. (**Trello card**: https://trello.com/c/WD4SbyMV/24-mostrar-contrasena-cambia-la-font-de-forma-no-deseada )\r\n5. Strings files still have to be associated with the app manually. (**Trello card**: https://trello.com/c/bQyWymgh/23-lograr-string-localization-automatica )\r\n6. Colours can't be customized yet. (**Trello card**: https://trello.com/c/7WPRPJEH/19-configurar-la-paleta-de-colores-en-el-log-in )"},"comment":{"url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/issues/comments/200349246","html_url":"https://github.com/Wolox/wolmo-authentication-ios/pull/2#issuecomment-200349246","issue_url":"https://api.github.com/repos/Wolox/wolmo-authentication-ios/issues/2","id":200349246,"user":{"login":"danielaRiesgo","id":12351004,"avatar_url":"https://avatars.githubusercontent.com/u/12351004?v=3","gravatar_id":"","url":"https://api.github.com/users/danielaRiesgo","html_url":"https://github.com/danielaRiesgo","followers_url":"https://api.github.com/users/danielaRiesgo/followers","following_url":"https://api.github.com/users/danielaRiesgo/following{/other_user}","gists_url":"https://api.github.com/users/danielaRiesgo/gists{/gist_id}","starred_url":"https://api.github.com/users/danielaRiesgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielaRiesgo/subscriptions","organizations_url":"https://api.github.com/users/danielaRiesgo/orgs","repos_url":"https://api.github.com/users/danielaRiesgo/repos","events_url":"https://api.github.com/users/danielaRiesgo/events{/privacy}","received_events_url":"https://api.github.com/users/danielaRiesgo/received_events","type":"User","site_admin":false},"created_at":"2016-03-23T13:44:26Z","updated_at":"2016-03-23T13:44:26Z","body":"About the configuration setup.\r\nI like more the first option, because it not only minimizes the arguments in the loginController but it also gives more structure and \"entry points\" with clear responsabilities for the user.\r\nBut at the same time, I was thinking that you are right, transitions are the least of the problems. I don't think anyone would use any other option than presenting or changing the root view controller (at least for 95% of times I think). So if they are changing the transitions, they are most probably changing other things and already inheriting from AuthenticationBootstrapper.\r\nSo maybe were overworking or overthinking, and the last option is quicker and still enables configuration. Although I would prefer having the LoginControllerActionDelegate (or TransitionDelegate) to separate responsabilities (without the AuthenticationConfiguration)."}}