{"action":"opened","issue":{"url":"https://api.github.com/repos/caskroom/homebrew-cask/issues/19813","repository_url":"https://api.github.com/repos/caskroom/homebrew-cask","labels_url":"https://api.github.com/repos/caskroom/homebrew-cask/issues/19813/labels{/name}","comments_url":"https://api.github.com/repos/caskroom/homebrew-cask/issues/19813/comments","events_url":"https://api.github.com/repos/caskroom/homebrew-cask/issues/19813/events","html_url":"https://github.com/caskroom/homebrew-cask/issues/19813","id":140783915,"number":19813,"title":"suspicious-package: Why a qlplugin stanza pointing to plugin inside app bundle?","user":{"login":"rsaldinger","id":4185702,"avatar_url":"https://avatars.githubusercontent.com/u/4185702?v=3","gravatar_id":"","url":"https://api.github.com/users/rsaldinger","html_url":"https://github.com/rsaldinger","followers_url":"https://api.github.com/users/rsaldinger/followers","following_url":"https://api.github.com/users/rsaldinger/following{/other_user}","gists_url":"https://api.github.com/users/rsaldinger/gists{/gist_id}","starred_url":"https://api.github.com/users/rsaldinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsaldinger/subscriptions","organizations_url":"https://api.github.com/users/rsaldinger/orgs","repos_url":"https://api.github.com/users/rsaldinger/repos","events_url":"https://api.github.com/users/rsaldinger/events{/privacy}","received_events_url":"https://api.github.com/users/rsaldinger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-03-14T20:08:06Z","updated_at":"2016-03-14T20:08:06Z","closed_at":null,"body":"In #19558, suspicious-package.rb was updated to reference the new app, but the qlplugin stanza was changed to reference the Quick Look plugin within the app bundle:\r\n\r\n    qlplugin 'Suspicious Package.app/Contents/Library/QuickLook/Suspicious Package.qlgenerator'\r\n\r\nThe resulting symlink in ~/Library/QuickLook is redundant (quicklookd will find the plugin embedded in the app bundle, as is standard). More importantly, it causes Suspicious Package.app to generate a confusing alert about cleaning up an old version of the standalone plugin. (Since Suspicious Package was changed from a standalone plugin to an app, it tries to be helpful and offer to clean up the old plugin, since the bundled one is newer and will be used by QL anyway. However, it doesn't expect to find a symlink pointing back at its own bundle, so doesn't handle this situation properly. As a result, it tells the user that the \"old\" version is the same as the new version, and \"cleanup\" just trashes the symlink -- not fatal but confusing.)\r\n\r\nYes, Suspicious Package should be smarter about this, but what purpose does this separate symlink even serve? [Sorry if this is a dumb question; I am not a big Cask user myself, but am the developer of Suspicious Package...]"}}