{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/51354515","id":51354515,"diff_hunk":"@@ -587,9 +589,10 @@ func TestNodeAddresses(t *testing.T) {\n \t// (we test that this produces an error)\n \tvar instance0 ec2.Instance\n \tvar instance1 ec2.Instance\n+\tvar instance2 ec2.Instance\n \n \t//0\n-\tinstance0.InstanceId = aws.String(\"instance-same\")\n+\tinstance0.InstanceId = aws.String(\"i-self\")","path":"pkg/cloudprovider/providers/aws/aws_test.go","position":17,"original_position":17,"commit_id":"cb88f54b90affe9ddb78205cec34549c69c322e3","original_commit_id":"cb88f54b90affe9ddb78205cec34549c69c322e3","user":{"login":"jtblin","id":1388974,"avatar_url":"https://avatars.githubusercontent.com/u/1388974?v=3","gravatar_id":"","url":"https://api.github.com/users/jtblin","html_url":"https://github.com/jtblin","followers_url":"https://api.github.com/users/jtblin/followers","following_url":"https://api.github.com/users/jtblin/following{/other_user}","gists_url":"https://api.github.com/users/jtblin/gists{/gist_id}","starred_url":"https://api.github.com/users/jtblin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtblin/subscriptions","organizations_url":"https://api.github.com/users/jtblin/orgs","repos_url":"https://api.github.com/users/jtblin/repos","events_url":"https://api.github.com/users/jtblin/events{/privacy}","received_events_url":"https://api.github.com/users/jtblin/received_events","type":"User","site_admin":false},"body":"Have to use this instance id so that it matches in the test fake DescribeInstances call and `getSelfAWSInstance` doesn't return an error.","created_at":"2016-01-31T03:09:21Z","updated_at":"2016-01-31T03:09:21Z","html_url":"https://github.com/kubernetes/kubernetes/pull/20378#discussion_r51354515","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20378","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/51354515"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/20378#discussion_r51354515"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20378"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20378","id":57758146,"html_url":"https://github.com/kubernetes/kubernetes/pull/20378","diff_url":"https://github.com/kubernetes/kubernetes/pull/20378.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/20378.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/20378","number":20378,"state":"open","locked":false,"title":"Fix #11543 - use DescribeInstances API to retrieve the correct private DNS name","user":{"login":"jtblin","id":1388974,"avatar_url":"https://avatars.githubusercontent.com/u/1388974?v=3","gravatar_id":"","url":"https://api.github.com/users/jtblin","html_url":"https://github.com/jtblin","followers_url":"https://api.github.com/users/jtblin/followers","following_url":"https://api.github.com/users/jtblin/following{/other_user}","gists_url":"https://api.github.com/users/jtblin/gists{/gist_id}","starred_url":"https://api.github.com/users/jtblin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtblin/subscriptions","organizations_url":"https://api.github.com/users/jtblin/orgs","repos_url":"https://api.github.com/users/jtblin/repos","events_url":"https://api.github.com/users/jtblin/events{/privacy}","received_events_url":"https://api.github.com/users/jtblin/received_events","type":"User","site_admin":false},"body":"Following discussion on #17643, now retrieving the private DNS name via the `DescribeInstances` API as the one retrieved from the ec2 metadata can be incorrect in the case of private zones.\r\n\r\ncc @justinsb ","created_at":"2016-01-31T03:07:13Z","updated_at":"2016-01-31T03:09:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6400c090d484dce17d96879cef040041d5b4f93f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20378/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20378/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/20378/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/cb88f54b90affe9ddb78205cec34549c69c322e3","head":{"label":"jtblin:jtblin/11543-aws-cloud-provider-private-hosted-dns-zone-via-api","ref":"jtblin/11543-aws-cloud-provider-private-hosted-dns-zone-via-api","sha":"cb88f54b90affe9ddb78205cec34549c69c322e3","user":{"login":"jtblin","id":1388974,"avatar_url":"https://avatars.githubusercontent.com/u/1388974?v=3","gravatar_id":"","url":"https://api.github.com/users/jtblin","html_url":"https://github.com/jtblin","followers_url":"https://api.github.com/users/jtblin/followers","following_url":"https://api.github.com/users/jtblin/following{/other_user}","gists_url":"https://api.github.com/users/jtblin/gists{/gist_id}","starred_url":"https://api.github.com/users/jtblin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtblin/subscriptions","organizations_url":"https://api.github.com/users/jtblin/orgs","repos_url":"https://api.github.com/users/jtblin/repos","events_url":"https://api.github.com/users/jtblin/events{/privacy}","received_events_url":"https://api.github.com/users/jtblin/received_events","type":"User","site_admin":false},"repo":{"id":45000730,"name":"kubernetes","full_name":"jtblin/kubernetes","owner":{"login":"jtblin","id":1388974,"avatar_url":"https://avatars.githubusercontent.com/u/1388974?v=3","gravatar_id":"","url":"https://api.github.com/users/jtblin","html_url":"https://github.com/jtblin","followers_url":"https://api.github.com/users/jtblin/followers","following_url":"https://api.github.com/users/jtblin/following{/other_user}","gists_url":"https://api.github.com/users/jtblin/gists{/gist_id}","starred_url":"https://api.github.com/users/jtblin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtblin/subscriptions","organizations_url":"https://api.github.com/users/jtblin/orgs","repos_url":"https://api.github.com/users/jtblin/repos","events_url":"https://api.github.com/users/jtblin/events{/privacy}","received_events_url":"https://api.github.com/users/jtblin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jtblin/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/jtblin/kubernetes","forks_url":"https://api.github.com/repos/jtblin/kubernetes/forks","keys_url":"https://api.github.com/repos/jtblin/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jtblin/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jtblin/kubernetes/teams","hooks_url":"https://api.github.com/repos/jtblin/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/jtblin/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/jtblin/kubernetes/events","assignees_url":"https://api.github.com/repos/jtblin/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/jtblin/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/jtblin/kubernetes/tags","blobs_url":"https://api.github.com/repos/jtblin/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jtblin/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jtblin/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/jtblin/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jtblin/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/jtblin/kubernetes/languages","stargazers_url":"https://api.github.com/repos/jtblin/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/jtblin/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/jtblin/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/jtblin/kubernetes/subscription","commits_url":"https://api.github.com/repos/jtblin/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/jtblin/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/jtblin/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/jtblin/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/jtblin/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/jtblin/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jtblin/kubernetes/merges","archive_url":"https://api.github.com/repos/jtblin/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jtblin/kubernetes/downloads","issues_url":"https://api.github.com/repos/jtblin/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/jtblin/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/jtblin/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/jtblin/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jtblin/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/jtblin/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/jtblin/kubernetes/deployments","created_at":"2015-10-26T22:15:44Z","updated_at":"2016-01-25T11:33:03Z","pushed_at":"2016-01-31T02:21:08Z","git_url":"git://github.com/jtblin/kubernetes.git","ssh_url":"git@github.com:jtblin/kubernetes.git","clone_url":"https://github.com/jtblin/kubernetes.git","svn_url":"https://github.com/jtblin/kubernetes","homepage":"http://kubernetes.io","size":156298,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"3db1a6c3cec63788d860a39b7552b6ad613cfae4","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-01-31T02:53:39Z","pushed_at":"2016-01-31T03:07:14Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":313552,"stargazers_count":12434,"watchers_count":12434,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3521,"mirror_url":null,"open_issues_count":2796,"forks":3521,"open_issues":2796,"watchers":12434,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20378"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/20378"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/20378"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/20378/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20378/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20378/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/cb88f54b90affe9ddb78205cec34549c69c322e3"}}}}