{"action":"created","issue":{"url":"https://api.github.com/repos/zendesk/samson/issues/1148","repository_url":"https://api.github.com/repos/zendesk/samson","labels_url":"https://api.github.com/repos/zendesk/samson/issues/1148/labels{/name}","comments_url":"https://api.github.com/repos/zendesk/samson/issues/1148/comments","events_url":"https://api.github.com/repos/zendesk/samson/issues/1148/events","html_url":"https://github.com/zendesk/samson/pull/1148","id":167107312,"number":1148,"title":"Additional checks for a valid pull request","user":{"login":"anthonywoo","id":1566114,"avatar_url":"https://avatars.githubusercontent.com/u/1566114?v=3","gravatar_id":"","url":"https://api.github.com/users/anthonywoo","html_url":"https://github.com/anthonywoo","followers_url":"https://api.github.com/users/anthonywoo/followers","following_url":"https://api.github.com/users/anthonywoo/following{/other_user}","gists_url":"https://api.github.com/users/anthonywoo/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonywoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonywoo/subscriptions","organizations_url":"https://api.github.com/users/anthonywoo/orgs","repos_url":"https://api.github.com/users/anthonywoo/repos","events_url":"https://api.github.com/users/anthonywoo/events{/privacy}","received_events_url":"https://api.github.com/users/anthonywoo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-22T18:43:39Z","updated_at":"2016-07-25T22:59:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zendesk/samson/pulls/1148","html_url":"https://github.com/zendesk/samson/pull/1148","diff_url":"https://github.com/zendesk/samson/pull/1148.diff","patch_url":"https://github.com/zendesk/samson/pull/1148.patch"},"body":"When using [samson review] - we're inspecting github `pull_request` events. However - we would sometimes get multiple deploys with the same `sha`.\r\n\r\n<img width=\"287\" alt=\"screen shot 2016-07-22 at 11 39 59 am\" src=\"https://cloud.githubusercontent.com/assets/1566114/17067525/eeb90772-5000-11e6-8557-c6ab439138dc.png\">\r\n\r\nThis happens because github will send a pull request event to samson if the pr description gets updated, if someone adds a label, and much more. \r\n\r\nWe only want samson to trigger a deploy when there is a new code push, or if someone explicitly adds the text [samson review]. To achieve this - the only events we will now consider are:  `opened`, `edited` or `synchronized`. In addition, if it's an edit event - we'll make sure the previous description did not have `[samson review]` in the description.\r\n\r\n\r\n/cc @zendesk/samson @mwerner \r\n\r\n### Tasks\r\n - [ ] :+1: from team\r\n\r\n\r\n### Risks\r\n- Level: Low. Samson could potentially not deploy the pull requests we expect\r\n"},"comment":{"url":"https://api.github.com/repos/zendesk/samson/issues/comments/235112128","html_url":"https://github.com/zendesk/samson/pull/1148#issuecomment-235112128","issue_url":"https://api.github.com/repos/zendesk/samson/issues/1148","id":235112128,"user":{"login":"mwerner","id":50568,"avatar_url":"https://avatars.githubusercontent.com/u/50568?v=3","gravatar_id":"","url":"https://api.github.com/users/mwerner","html_url":"https://github.com/mwerner","followers_url":"https://api.github.com/users/mwerner/followers","following_url":"https://api.github.com/users/mwerner/following{/other_user}","gists_url":"https://api.github.com/users/mwerner/gists{/gist_id}","starred_url":"https://api.github.com/users/mwerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwerner/subscriptions","organizations_url":"https://api.github.com/users/mwerner/orgs","repos_url":"https://api.github.com/users/mwerner/repos","events_url":"https://api.github.com/users/mwerner/events{/privacy}","received_events_url":"https://api.github.com/users/mwerner/received_events","type":"User","site_admin":false},"created_at":"2016-07-25T22:59:35Z","updated_at":"2016-07-25T22:59:35Z","body":"+1"}}
{"actor":{"display_login":"mwerner"}}