{"action":"created","issue":{"url":"https://api.github.com/repos/timo/json_fast/issues/17","repository_url":"https://api.github.com/repos/timo/json_fast","labels_url":"https://api.github.com/repos/timo/json_fast/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/timo/json_fast/issues/17/comments","events_url":"https://api.github.com/repos/timo/json_fast/issues/17/events","html_url":"https://github.com/timo/json_fast/pull/17","id":196392765,"number":17,"title":"Convert null byte to \\u0000, make to-json 2.9x faster","user":{"login":"samcv","id":20145557,"avatar_url":"https://avatars.githubusercontent.com/u/20145557?v=3","gravatar_id":"","url":"https://api.github.com/users/samcv","html_url":"https://github.com/samcv","followers_url":"https://api.github.com/users/samcv/followers","following_url":"https://api.github.com/users/samcv/following{/other_user}","gists_url":"https://api.github.com/users/samcv/gists{/gist_id}","starred_url":"https://api.github.com/users/samcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samcv/subscriptions","organizations_url":"https://api.github.com/users/samcv/orgs","repos_url":"https://api.github.com/users/samcv/repos","events_url":"https://api.github.com/users/samcv/events{/privacy}","received_events_url":"https://api.github.com/users/samcv/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-19T11:35:49Z","updated_at":"2016-12-21T15:05:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/timo/json_fast/pulls/17","html_url":"https://github.com/timo/json_fast/pull/17","diff_url":"https://github.com/timo/json_fast/pull/17.diff","patch_url":"https://github.com/timo/json_fast/pull/17.patch"},"body":"Although we need to make sure all control characters are converted\r\nto be JSON compliant, the null byte is the worst possible character\r\nto accidently put into a JSON file. Let's at least cover this case.\r\n\r\nThere was some discussion here:\r\nhttps://irclog.perlgeek.de/perl6/2016-12-14#i_13737067\r\n\r\nHad to switch Whateverable to use JSON::Tiny instead, but would be\r\nnice if this was fixed in JSON::Fast\r\n\r\n* Use strings with subst instead of regex for 2.9x faster `to-json`\r\n* Also, use #!/usr/bin/env perl6 shebang so that running `prove` will properly run perl6.\r\n* Make sure to `use lib 'lib'`, otherwise if we have JSON::Fast installed already, it will use that version instead of the one in the folder we're running it in.\r\n* Add a test to make sure the null byte is escaped properly"},"comment":{"url":"https://api.github.com/repos/timo/json_fast/issues/comments/268544687","html_url":"https://github.com/timo/json_fast/pull/17#issuecomment-268544687","issue_url":"https://api.github.com/repos/timo/json_fast/issues/17","id":268544687,"user":{"login":"timo","id":25167,"avatar_url":"https://avatars.githubusercontent.com/u/25167?v=3","gravatar_id":"","url":"https://api.github.com/users/timo","html_url":"https://github.com/timo","followers_url":"https://api.github.com/users/timo/followers","following_url":"https://api.github.com/users/timo/following{/other_user}","gists_url":"https://api.github.com/users/timo/gists{/gist_id}","starred_url":"https://api.github.com/users/timo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timo/subscriptions","organizations_url":"https://api.github.com/users/timo/orgs","repos_url":"https://api.github.com/users/timo/repos","events_url":"https://api.github.com/users/timo/events{/privacy}","received_events_url":"https://api.github.com/users/timo/received_events","type":"User","site_admin":false},"created_at":"2016-12-21T15:05:01Z","updated_at":"2016-12-21T15:05:01Z","body":"i don't think \"use lib 'lib'\" is correct; isn't it supposed to be relative to the script being run? also, \"panda install\" (and probably also \"zef install\") will run prove with the proper -Ilib flag already. what's your take on that?"}}
{"actor":{"display_login":"timo"}}