{"action":"closed","issue":{"url":"https://api.github.com/repos/BranchMetrics/titanium-branch-deep-linking/issues/83","repository_url":"https://api.github.com/repos/BranchMetrics/titanium-branch-deep-linking","labels_url":"https://api.github.com/repos/BranchMetrics/titanium-branch-deep-linking/issues/83/labels{/name}","comments_url":"https://api.github.com/repos/BranchMetrics/titanium-branch-deep-linking/issues/83/comments","events_url":"https://api.github.com/repos/BranchMetrics/titanium-branch-deep-linking/issues/83/events","html_url":"https://github.com/BranchMetrics/titanium-branch-deep-linking/issues/83","id":196371733,"number":83,"title":"[iOS] Session will not start if the app is fully closed","user":{"login":"AndreaVitale","id":2265079,"avatar_url":"https://avatars.githubusercontent.com/u/2265079?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreaVitale","html_url":"https://github.com/AndreaVitale","followers_url":"https://api.github.com/users/AndreaVitale/followers","following_url":"https://api.github.com/users/AndreaVitale/following{/other_user}","gists_url":"https://api.github.com/users/AndreaVitale/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreaVitale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreaVitale/subscriptions","organizations_url":"https://api.github.com/users/AndreaVitale/orgs","repos_url":"https://api.github.com/users/AndreaVitale/repos","events_url":"https://api.github.com/users/AndreaVitale/events{/privacy}","received_events_url":"https://api.github.com/users/AndreaVitale/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-19T09:52:22Z","updated_at":"2016-12-21T16:24:38Z","closed_at":"2016-12-21T16:24:38Z","body":"Use case precondition: the app is fully closed.\r\n- First attempt: I click on a branch.io link, my app will be opened and the `bio:initSession` event is fired with an **empty** payload (no custom data will be forwarded and _clicked_branch_link_ is set to false.)\r\n- Second attempt: after the first attempt, I close my app also from the background, I click on a branch.io link and my app will be opened correctly but **NO** `bio:initSession` event is fired.\r\n- Third attempt: as the second one and so on.\r\n\r\nI also tested the pull request #82 but I have the same error.\r\n\r\nEDIT:\r\nLooking at the source code I found that the issue is caused by `shouldWaitForInit` set to `YES` [here](https://github.com/BranchMetrics/ios-branch-deep-linking/blob/master/Branch-SDK/Branch-SDK/Branch.m#L358).\r\nIndeed, setting it to `NO` there are no problems and the session is correctly initialized.\r\n\r\nHaving a look also on iOS branch SDK I found a [committed patch](https://github.com/BranchMetrics/ios-branch-deep-linking/commit/09c1e9cf706d0a099e6cb4541da17e93ca3c33b0) that solves this issue. Why there is a terrible discrepancy between iOS Branch SDK and the Titanium SDK? It is since 3 months that the commits are totally not consistent with the main iOS Branch SDK!"}}
{"actor":{"display_login":"aaustin"}}