{"action":"opened","number":688,"pull_request":{"url":"https://api.github.com/repos/BorderTech/wcomponents/pulls/688","id":74006804,"html_url":"https://github.com/BorderTech/wcomponents/pull/688","diff_url":"https://github.com/BorderTech/wcomponents/pull/688.diff","patch_url":"https://github.com/BorderTech/wcomponents/pull/688.patch","issue_url":"https://api.github.com/repos/BorderTech/wcomponents/issues/688","number":688,"state":"open","locked":false,"title":"Fix rem sizes #685, class names #651, bug fixes","user":{"login":"marksreeves","id":11661938,"avatar_url":"https://avatars.githubusercontent.com/u/11661938?v=3","gravatar_id":"","url":"https://api.github.com/users/marksreeves","html_url":"https://github.com/marksreeves","followers_url":"https://api.github.com/users/marksreeves/followers","following_url":"https://api.github.com/users/marksreeves/following{/other_user}","gists_url":"https://api.github.com/users/marksreeves/gists{/gist_id}","starred_url":"https://api.github.com/users/marksreeves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marksreeves/subscriptions","organizations_url":"https://api.github.com/users/marksreeves/orgs","repos_url":"https://api.github.com/users/marksreeves/repos","events_url":"https://api.github.com/users/marksreeves/events{/privacy}","received_events_url":"https://api.github.com/users/marksreeves/received_events","type":"User","site_admin":false},"body":"* Moved all rem sizes to variables fixes #685.\n* Ensured all class names follow wc- or wc_ naming convention fixes #651\n* As an extension to the previous two points all non-calculation Sass vars have been moved to _common.scss and the color vars files and any extraneous vars files have been deleted. Any component specific vars files which contain over-rideable mixins have been retained but re-named to the mixin convention. This has been combined with ensuring that all over-rideable vars are marked default. This _should_ ease the burden of overriding vars in themes. Also rationalised the sectioning content header sizes as part of the rem fix and moved these to a var. These have shown to be problematic in practice and had resulted in inconsistent header sizes and excessively complex over-rides in current consuming themes.\n* As part of #651 and for future enhancement I changed the following class names for common helper classes to move them from the “private” convention to the “public” convention:\n  * `wc_off` for out of viewport to `wc-off`\n  * `wc_invite` to turn on over/focus effects to `wc-invite`\n  * `wc_btn_nada` for a button with no button-like appearance to `wc-nobutton`\n  * `wc_btn_link` for a button with a link-like appearance to `wc-linkbutton`\n* Fixed a bug in GridLayout caused by a class-name clash. This rationalisation of class names and variables _should_ help reduce the incidence of this in future but we still have no consistent pattern for classes in the “private” convention so more work will need to be done.\n* Updated snapshot version in all poms.","created_at":"2016-06-16T00:41:49Z","updated_at":"2016-06-16T00:41:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/BorderTech/wcomponents/pulls/688/commits","review_comments_url":"https://api.github.com/repos/BorderTech/wcomponents/pulls/688/comments","review_comment_url":"https://api.github.com/repos/BorderTech/wcomponents/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BorderTech/wcomponents/issues/688/comments","statuses_url":"https://api.github.com/repos/BorderTech/wcomponents/statuses/8693b8c47239372efd6219e1c61b479f8cf8457e","head":{"label":"marksreeves:fix-rem-sizes-#685","ref":"fix-rem-sizes-#685","sha":"8693b8c47239372efd6219e1c61b479f8cf8457e","user":{"login":"marksreeves","id":11661938,"avatar_url":"https://avatars.githubusercontent.com/u/11661938?v=3","gravatar_id":"","url":"https://api.github.com/users/marksreeves","html_url":"https://github.com/marksreeves","followers_url":"https://api.github.com/users/marksreeves/followers","following_url":"https://api.github.com/users/marksreeves/following{/other_user}","gists_url":"https://api.github.com/users/marksreeves/gists{/gist_id}","starred_url":"https://api.github.com/users/marksreeves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marksreeves/subscriptions","organizations_url":"https://api.github.com/users/marksreeves/orgs","repos_url":"https://api.github.com/users/marksreeves/repos","events_url":"https://api.github.com/users/marksreeves/events{/privacy}","received_events_url":"https://api.github.com/users/marksreeves/received_events","type":"User","site_admin":false},"repo":{"id":42565451,"name":"wcomponents","full_name":"marksreeves/wcomponents","owner":{"login":"marksreeves","id":11661938,"avatar_url":"https://avatars.githubusercontent.com/u/11661938?v=3","gravatar_id":"","url":"https://api.github.com/users/marksreeves","html_url":"https://github.com/marksreeves","followers_url":"https://api.github.com/users/marksreeves/followers","following_url":"https://api.github.com/users/marksreeves/following{/other_user}","gists_url":"https://api.github.com/users/marksreeves/gists{/gist_id}","starred_url":"https://api.github.com/users/marksreeves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marksreeves/subscriptions","organizations_url":"https://api.github.com/users/marksreeves/orgs","repos_url":"https://api.github.com/users/marksreeves/repos","events_url":"https://api.github.com/users/marksreeves/events{/privacy}","received_events_url":"https://api.github.com/users/marksreeves/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marksreeves/wcomponents","description":"Accessible Web UI Framework for Enterprise","fork":true,"url":"https://api.github.com/repos/marksreeves/wcomponents","forks_url":"https://api.github.com/repos/marksreeves/wcomponents/forks","keys_url":"https://api.github.com/repos/marksreeves/wcomponents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marksreeves/wcomponents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marksreeves/wcomponents/teams","hooks_url":"https://api.github.com/repos/marksreeves/wcomponents/hooks","issue_events_url":"https://api.github.com/repos/marksreeves/wcomponents/issues/events{/number}","events_url":"https://api.github.com/repos/marksreeves/wcomponents/events","assignees_url":"https://api.github.com/repos/marksreeves/wcomponents/assignees{/user}","branches_url":"https://api.github.com/repos/marksreeves/wcomponents/branches{/branch}","tags_url":"https://api.github.com/repos/marksreeves/wcomponents/tags","blobs_url":"https://api.github.com/repos/marksreeves/wcomponents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marksreeves/wcomponents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marksreeves/wcomponents/git/refs{/sha}","trees_url":"https://api.github.com/repos/marksreeves/wcomponents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marksreeves/wcomponents/statuses/{sha}","languages_url":"https://api.github.com/repos/marksreeves/wcomponents/languages","stargazers_url":"https://api.github.com/repos/marksreeves/wcomponents/stargazers","contributors_url":"https://api.github.com/repos/marksreeves/wcomponents/contributors","subscribers_url":"https://api.github.com/repos/marksreeves/wcomponents/subscribers","subscription_url":"https://api.github.com/repos/marksreeves/wcomponents/subscription","commits_url":"https://api.github.com/repos/marksreeves/wcomponents/commits{/sha}","git_commits_url":"https://api.github.com/repos/marksreeves/wcomponents/git/commits{/sha}","comments_url":"https://api.github.com/repos/marksreeves/wcomponents/comments{/number}","issue_comment_url":"https://api.github.com/repos/marksreeves/wcomponents/issues/comments{/number}","contents_url":"https://api.github.com/repos/marksreeves/wcomponents/contents/{+path}","compare_url":"https://api.github.com/repos/marksreeves/wcomponents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marksreeves/wcomponents/merges","archive_url":"https://api.github.com/repos/marksreeves/wcomponents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marksreeves/wcomponents/downloads","issues_url":"https://api.github.com/repos/marksreeves/wcomponents/issues{/number}","pulls_url":"https://api.github.com/repos/marksreeves/wcomponents/pulls{/number}","milestones_url":"https://api.github.com/repos/marksreeves/wcomponents/milestones{/number}","notifications_url":"https://api.github.com/repos/marksreeves/wcomponents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marksreeves/wcomponents/labels{/name}","releases_url":"https://api.github.com/repos/marksreeves/wcomponents/releases{/id}","deployments_url":"https://api.github.com/repos/marksreeves/wcomponents/deployments","created_at":"2015-09-16T04:57:13Z","updated_at":"2016-01-12T00:05:51Z","pushed_at":"2016-06-16T00:41:47Z","git_url":"git://github.com/marksreeves/wcomponents.git","ssh_url":"git@github.com:marksreeves/wcomponents.git","clone_url":"https://github.com/marksreeves/wcomponents.git","svn_url":"https://github.com/marksreeves/wcomponents","homepage":"","size":72425,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"version-d"}},"base":{"label":"BorderTech:danni","ref":"danni","sha":"1df31e697d77cb08fbc20c66065e6b7027d87dd6","user":{"login":"BorderTech","id":11400614,"avatar_url":"https://avatars.githubusercontent.com/u/11400614?v=3","gravatar_id":"","url":"https://api.github.com/users/BorderTech","html_url":"https://github.com/BorderTech","followers_url":"https://api.github.com/users/BorderTech/followers","following_url":"https://api.github.com/users/BorderTech/following{/other_user}","gists_url":"https://api.github.com/users/BorderTech/gists{/gist_id}","starred_url":"https://api.github.com/users/BorderTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BorderTech/subscriptions","organizations_url":"https://api.github.com/users/BorderTech/orgs","repos_url":"https://api.github.com/users/BorderTech/repos","events_url":"https://api.github.com/users/BorderTech/events{/privacy}","received_events_url":"https://api.github.com/users/BorderTech/received_events","type":"Organization","site_admin":false},"repo":{"id":31935307,"name":"wcomponents","full_name":"BorderTech/wcomponents","owner":{"login":"BorderTech","id":11400614,"avatar_url":"https://avatars.githubusercontent.com/u/11400614?v=3","gravatar_id":"","url":"https://api.github.com/users/BorderTech","html_url":"https://github.com/BorderTech","followers_url":"https://api.github.com/users/BorderTech/followers","following_url":"https://api.github.com/users/BorderTech/following{/other_user}","gists_url":"https://api.github.com/users/BorderTech/gists{/gist_id}","starred_url":"https://api.github.com/users/BorderTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BorderTech/subscriptions","organizations_url":"https://api.github.com/users/BorderTech/orgs","repos_url":"https://api.github.com/users/BorderTech/repos","events_url":"https://api.github.com/users/BorderTech/events{/privacy}","received_events_url":"https://api.github.com/users/BorderTech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BorderTech/wcomponents","description":"Accessible Web UI Framework for Enterprise","fork":false,"url":"https://api.github.com/repos/BorderTech/wcomponents","forks_url":"https://api.github.com/repos/BorderTech/wcomponents/forks","keys_url":"https://api.github.com/repos/BorderTech/wcomponents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BorderTech/wcomponents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BorderTech/wcomponents/teams","hooks_url":"https://api.github.com/repos/BorderTech/wcomponents/hooks","issue_events_url":"https://api.github.com/repos/BorderTech/wcomponents/issues/events{/number}","events_url":"https://api.github.com/repos/BorderTech/wcomponents/events","assignees_url":"https://api.github.com/repos/BorderTech/wcomponents/assignees{/user}","branches_url":"https://api.github.com/repos/BorderTech/wcomponents/branches{/branch}","tags_url":"https://api.github.com/repos/BorderTech/wcomponents/tags","blobs_url":"https://api.github.com/repos/BorderTech/wcomponents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BorderTech/wcomponents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BorderTech/wcomponents/git/refs{/sha}","trees_url":"https://api.github.com/repos/BorderTech/wcomponents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BorderTech/wcomponents/statuses/{sha}","languages_url":"https://api.github.com/repos/BorderTech/wcomponents/languages","stargazers_url":"https://api.github.com/repos/BorderTech/wcomponents/stargazers","contributors_url":"https://api.github.com/repos/BorderTech/wcomponents/contributors","subscribers_url":"https://api.github.com/repos/BorderTech/wcomponents/subscribers","subscription_url":"https://api.github.com/repos/BorderTech/wcomponents/subscription","commits_url":"https://api.github.com/repos/BorderTech/wcomponents/commits{/sha}","git_commits_url":"https://api.github.com/repos/BorderTech/wcomponents/git/commits{/sha}","comments_url":"https://api.github.com/repos/BorderTech/wcomponents/comments{/number}","issue_comment_url":"https://api.github.com/repos/BorderTech/wcomponents/issues/comments{/number}","contents_url":"https://api.github.com/repos/BorderTech/wcomponents/contents/{+path}","compare_url":"https://api.github.com/repos/BorderTech/wcomponents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BorderTech/wcomponents/merges","archive_url":"https://api.github.com/repos/BorderTech/wcomponents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BorderTech/wcomponents/downloads","issues_url":"https://api.github.com/repos/BorderTech/wcomponents/issues{/number}","pulls_url":"https://api.github.com/repos/BorderTech/wcomponents/pulls{/number}","milestones_url":"https://api.github.com/repos/BorderTech/wcomponents/milestones{/number}","notifications_url":"https://api.github.com/repos/BorderTech/wcomponents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BorderTech/wcomponents/labels{/name}","releases_url":"https://api.github.com/repos/BorderTech/wcomponents/releases{/id}","deployments_url":"https://api.github.com/repos/BorderTech/wcomponents/deployments","created_at":"2015-03-10T02:59:08Z","updated_at":"2016-04-13T00:27:38Z","pushed_at":"2016-06-15T03:53:14Z","git_url":"git://github.com/BorderTech/wcomponents.git","ssh_url":"git@github.com:BorderTech/wcomponents.git","clone_url":"https://github.com/BorderTech/wcomponents.git","svn_url":"https://github.com/BorderTech/wcomponents","homepage":"","size":74850,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":62,"forks":9,"open_issues":62,"watchers":11,"default_branch":"danni"}},"_links":{"self":{"href":"https://api.github.com/repos/BorderTech/wcomponents/pulls/688"},"html":{"href":"https://github.com/BorderTech/wcomponents/pull/688"},"issue":{"href":"https://api.github.com/repos/BorderTech/wcomponents/issues/688"},"comments":{"href":"https://api.github.com/repos/BorderTech/wcomponents/issues/688/comments"},"review_comments":{"href":"https://api.github.com/repos/BorderTech/wcomponents/pulls/688/comments"},"review_comment":{"href":"https://api.github.com/repos/BorderTech/wcomponents/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BorderTech/wcomponents/pulls/688/commits"},"statuses":{"href":"https://api.github.com/repos/BorderTech/wcomponents/statuses/8693b8c47239372efd6219e1c61b479f8cf8457e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":530,"deletions":523,"changed_files":157}}
{"actor":{"display_login":"marksreeves"}}