{"action":"created","issue":{"url":"https://api.github.com/repos/jedireza/drywall/issues/359","repository_url":"https://api.github.com/repos/jedireza/drywall","labels_url":"https://api.github.com/repos/jedireza/drywall/issues/359/labels{/name}","comments_url":"https://api.github.com/repos/jedireza/drywall/issues/359/comments","events_url":"https://api.github.com/repos/jedireza/drywall/issues/359/events","html_url":"https://github.com/jedireza/drywall/issues/359","id":146006490,"number":359,"title":"Favicon override","user":{"login":"scottmont","id":15675210,"avatar_url":"https://avatars.githubusercontent.com/u/15675210?v=3","gravatar_id":"","url":"https://api.github.com/users/scottmont","html_url":"https://github.com/scottmont","followers_url":"https://api.github.com/users/scottmont/followers","following_url":"https://api.github.com/users/scottmont/following{/other_user}","gists_url":"https://api.github.com/users/scottmont/gists{/gist_id}","starred_url":"https://api.github.com/users/scottmont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottmont/subscriptions","organizations_url":"https://api.github.com/users/scottmont/orgs","repos_url":"https://api.github.com/users/scottmont/repos","events_url":"https://api.github.com/users/scottmont/events{/privacy}","received_events_url":"https://api.github.com/users/scottmont/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jedireza/drywall/labels/question","name":"question","color":"cc317c"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-05T14:28:05Z","updated_at":"2016-04-05T19:45:31Z","closed_at":"2016-04-05T19:45:31Z","body":"Hi,\r\n\r\nI have been trying to override the favicon using serve-favicon and then defining my favicon.  I have search the project but can see where you are defining it.\r\n\r\nMy code\r\n\r\n```js\r\n    app.use(function(req, res, next) {\r\n      if (req.get('Host').indexOf(\"id.carp.ca\") > -1 ) {\r\n        app.use(favicon(__dirname + '/public/media/carp/favicon.ico'));\r\n          next();\r\n      } else {\r\n        app.use(favicon(__dirname + '/public/media/favicon.ico'));\r\n        next();\r\n      }\r\n    });\r\n```"},"comment":{"url":"https://api.github.com/repos/jedireza/drywall/issues/comments/205963932","html_url":"https://github.com/jedireza/drywall/issues/359#issuecomment-205963932","issue_url":"https://api.github.com/repos/jedireza/drywall/issues/359","id":205963932,"user":{"login":"jedireza","id":979929,"avatar_url":"https://avatars.githubusercontent.com/u/979929?v=3","gravatar_id":"","url":"https://api.github.com/users/jedireza","html_url":"https://github.com/jedireza","followers_url":"https://api.github.com/users/jedireza/followers","following_url":"https://api.github.com/users/jedireza/following{/other_user}","gists_url":"https://api.github.com/users/jedireza/gists{/gist_id}","starred_url":"https://api.github.com/users/jedireza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedireza/subscriptions","organizations_url":"https://api.github.com/users/jedireza/orgs","repos_url":"https://api.github.com/users/jedireza/repos","events_url":"https://api.github.com/users/jedireza/events{/privacy}","received_events_url":"https://api.github.com/users/jedireza/received_events","type":"User","site_admin":false},"created_at":"2016-04-05T19:45:31Z","updated_at":"2016-04-05T19:45:31Z","body":"Thanks for opening an issue.\r\n\r\nThe `favicon.ico` file is located in the `./public/` directory. You could replace that file and not need `serve-favicon`. Or you could delete the `./public/favicon.ico` file and use that module.\r\n\r\nThe `./public` folder is being exposed using [`serve-static`](https://github.com/expressjs/serve-static) here: https://github.com/jedireza/drywall/blob/520444296dd60e42702f793c181a53d2de15d98c/app.js#L45"}}