{"action":"created","comment":{"url":"https://api.github.com/repos/Mellanox/sockperf/pulls/comments/73123656","id":73123656,"diff_hunk":"@@ -1564,11 +1568,11 @@ static int proc_mode_server( int id, int argc, const char **argv )\n \t\tprintf(\"\\n\");\n \t\tprintf(\"Usage: \" MODULE_NAME \" %s [options] [args]...\\n\", sockperf_modes[id].name);\n \t\tprintf(\" \" MODULE_NAME \" %s\\n\", sockperf_modes[id].name);\n-\t\tprintf(\" \" MODULE_NAME \" %s [-i ip] [-p port] [--rx-mc-if ip] [--tx-mc-if ip]\\n\", sockperf_modes[id].name);\n+\t\tprintf(\" \" MODULE_NAME \" %s [-i ip] [-p port] [--rx-mc-if ip] [--tx-mc-if ip] [--mc-source-ip]\\n\", sockperf_modes[id].name);\n #ifndef WIN32\n-\t\tprintf(\" \" MODULE_NAME \" %s -f file [-F s/p/e] [--rx-mc-if ip] [--tx-mc-if ip]\\n\", sockperf_modes[id].name);\n+\t\tprintf(\" \" MODULE_NAME \" %s -f file [-F s/p/e] [--rx-mc-if ip] [--tx-mc-if ip] [--mc-source-ip]\\n\", sockperf_modes[id].name);\n #else\n-\t\tprintf(\" \" MODULE_NAME \" %s -f file [-F s] [--rx-mc-if ip] [--tx-mc-if ip]\\n\", sockperf_modes[id].name);\n+\t\tprintf(\" \" MODULE_NAME \" %s -f file [-F s] [--rx-mc-if ip] [--tx-mc-if ip] [--mc-source-ip]\\n\", sockperf_modes[id].name);\n #endif","path":"src/SockPerf.cpp","position":23,"original_position":23,"commit_id":"0663b35853a70c465ef2d58db19fa9a792ea8561","original_commit_id":"0663b35853a70c465ef2d58db19fa9a792ea8561","user":{"login":"avnerbh","id":3755468,"avatar_url":"https://avatars.githubusercontent.com/u/3755468?v=3","gravatar_id":"","url":"https://api.github.com/users/avnerbh","html_url":"https://github.com/avnerbh","followers_url":"https://api.github.com/users/avnerbh/followers","following_url":"https://api.github.com/users/avnerbh/following{/other_user}","gists_url":"https://api.github.com/users/avnerbh/gists{/gist_id}","starred_url":"https://api.github.com/users/avnerbh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avnerbh/subscriptions","organizations_url":"https://api.github.com/users/avnerbh/orgs","repos_url":"https://api.github.com/users/avnerbh/repos","events_url":"https://api.github.com/users/avnerbh/events{/privacy}","received_events_url":"https://api.github.com/users/avnerbh/received_events","type":"User","site_admin":false},"body":"wouldn't it be better to have the new name **[--mc-source-ip]**\r\nin the format of the old names **[--rx-mc-if ip] [--tx-mc-if ip]** ","created_at":"2016-08-02T09:34:04Z","updated_at":"2016-08-02T09:34:04Z","html_url":"https://github.com/Mellanox/sockperf/pull/74#discussion_r73123656","pull_request_url":"https://api.github.com/repos/Mellanox/sockperf/pulls/74","_links":{"self":{"href":"https://api.github.com/repos/Mellanox/sockperf/pulls/comments/73123656"},"html":{"href":"https://github.com/Mellanox/sockperf/pull/74#discussion_r73123656"},"pull_request":{"href":"https://api.github.com/repos/Mellanox/sockperf/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/Mellanox/sockperf/pulls/74","id":79697049,"html_url":"https://github.com/Mellanox/sockperf/pull/74","diff_url":"https://github.com/Mellanox/sockperf/pull/74.diff","patch_url":"https://github.com/Mellanox/sockperf/pull/74.patch","issue_url":"https://api.github.com/repos/Mellanox/sockperf/issues/74","number":74,"state":"open","locked":false,"title":"Support multicat source filtering","user":{"login":"ashanably","id":11044938,"avatar_url":"https://avatars.githubusercontent.com/u/11044938?v=3","gravatar_id":"","url":"https://api.github.com/users/ashanably","html_url":"https://github.com/ashanably","followers_url":"https://api.github.com/users/ashanably/followers","following_url":"https://api.github.com/users/ashanably/following{/other_user}","gists_url":"https://api.github.com/users/ashanably/gists{/gist_id}","starred_url":"https://api.github.com/users/ashanably/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashanably/subscriptions","organizations_url":"https://api.github.com/users/ashanably/orgs","repos_url":"https://api.github.com/users/ashanably/repos","events_url":"https://api.github.com/users/ashanably/events{/privacy}","received_events_url":"https://api.github.com/users/ashanably/received_events","type":"User","site_admin":false},"body":"Signed-off-by: ashanably <ashanably@asaltech.com>","created_at":"2016-08-02T08:45:59Z","updated_at":"2016-08-02T09:34:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c75ab2ab402114fb4cf64574f52c52f0680a6b4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Mellanox/sockperf/pulls/74/commits","review_comments_url":"https://api.github.com/repos/Mellanox/sockperf/pulls/74/comments","review_comment_url":"https://api.github.com/repos/Mellanox/sockperf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Mellanox/sockperf/issues/74/comments","statuses_url":"https://api.github.com/repos/Mellanox/sockperf/statuses/0663b35853a70c465ef2d58db19fa9a792ea8561","head":{"label":"ashanably:multicast_source_filter","ref":"multicast_source_filter","sha":"0663b35853a70c465ef2d58db19fa9a792ea8561","user":{"login":"ashanably","id":11044938,"avatar_url":"https://avatars.githubusercontent.com/u/11044938?v=3","gravatar_id":"","url":"https://api.github.com/users/ashanably","html_url":"https://github.com/ashanably","followers_url":"https://api.github.com/users/ashanably/followers","following_url":"https://api.github.com/users/ashanably/following{/other_user}","gists_url":"https://api.github.com/users/ashanably/gists{/gist_id}","starred_url":"https://api.github.com/users/ashanably/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashanably/subscriptions","organizations_url":"https://api.github.com/users/ashanably/orgs","repos_url":"https://api.github.com/users/ashanably/repos","events_url":"https://api.github.com/users/ashanably/events{/privacy}","received_events_url":"https://api.github.com/users/ashanably/received_events","type":"User","site_admin":false},"repo":{"id":64739529,"name":"sockperf","full_name":"ashanably/sockperf","owner":{"login":"ashanably","id":11044938,"avatar_url":"https://avatars.githubusercontent.com/u/11044938?v=3","gravatar_id":"","url":"https://api.github.com/users/ashanably","html_url":"https://github.com/ashanably","followers_url":"https://api.github.com/users/ashanably/followers","following_url":"https://api.github.com/users/ashanably/following{/other_user}","gists_url":"https://api.github.com/users/ashanably/gists{/gist_id}","starred_url":"https://api.github.com/users/ashanably/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashanably/subscriptions","organizations_url":"https://api.github.com/users/ashanably/orgs","repos_url":"https://api.github.com/users/ashanably/repos","events_url":"https://api.github.com/users/ashanably/events{/privacy}","received_events_url":"https://api.github.com/users/ashanably/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ashanably/sockperf","description":"Network Benchmarking Utility (exported from code.google.com/p/sockperf)","fork":true,"url":"https://api.github.com/repos/ashanably/sockperf","forks_url":"https://api.github.com/repos/ashanably/sockperf/forks","keys_url":"https://api.github.com/repos/ashanably/sockperf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashanably/sockperf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashanably/sockperf/teams","hooks_url":"https://api.github.com/repos/ashanably/sockperf/hooks","issue_events_url":"https://api.github.com/repos/ashanably/sockperf/issues/events{/number}","events_url":"https://api.github.com/repos/ashanably/sockperf/events","assignees_url":"https://api.github.com/repos/ashanably/sockperf/assignees{/user}","branches_url":"https://api.github.com/repos/ashanably/sockperf/branches{/branch}","tags_url":"https://api.github.com/repos/ashanably/sockperf/tags","blobs_url":"https://api.github.com/repos/ashanably/sockperf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashanably/sockperf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashanably/sockperf/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashanably/sockperf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashanably/sockperf/statuses/{sha}","languages_url":"https://api.github.com/repos/ashanably/sockperf/languages","stargazers_url":"https://api.github.com/repos/ashanably/sockperf/stargazers","contributors_url":"https://api.github.com/repos/ashanably/sockperf/contributors","subscribers_url":"https://api.github.com/repos/ashanably/sockperf/subscribers","subscription_url":"https://api.github.com/repos/ashanably/sockperf/subscription","commits_url":"https://api.github.com/repos/ashanably/sockperf/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashanably/sockperf/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashanably/sockperf/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashanably/sockperf/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashanably/sockperf/contents/{+path}","compare_url":"https://api.github.com/repos/ashanably/sockperf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashanably/sockperf/merges","archive_url":"https://api.github.com/repos/ashanably/sockperf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashanably/sockperf/downloads","issues_url":"https://api.github.com/repos/ashanably/sockperf/issues{/number}","pulls_url":"https://api.github.com/repos/ashanably/sockperf/pulls{/number}","milestones_url":"https://api.github.com/repos/ashanably/sockperf/milestones{/number}","notifications_url":"https://api.github.com/repos/ashanably/sockperf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashanably/sockperf/labels{/name}","releases_url":"https://api.github.com/repos/ashanably/sockperf/releases{/id}","deployments_url":"https://api.github.com/repos/ashanably/sockperf/deployments","created_at":"2016-08-02T08:35:33Z","updated_at":"2016-08-02T08:35:35Z","pushed_at":"2016-08-02T08:42:09Z","git_url":"git://github.com/ashanably/sockperf.git","ssh_url":"git@github.com:ashanably/sockperf.git","clone_url":"https://github.com/ashanably/sockperf.git","svn_url":"https://github.com/ashanably/sockperf","homepage":"","size":776,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"sockperf_v2"}},"base":{"label":"Mellanox:sockperf_v2","ref":"sockperf_v2","sha":"56d78c8ab93abe4721c84d535abaf31e777384b7","user":{"login":"Mellanox","id":5813145,"avatar_url":"https://avatars.githubusercontent.com/u/5813145?v=3","gravatar_id":"","url":"https://api.github.com/users/Mellanox","html_url":"https://github.com/Mellanox","followers_url":"https://api.github.com/users/Mellanox/followers","following_url":"https://api.github.com/users/Mellanox/following{/other_user}","gists_url":"https://api.github.com/users/Mellanox/gists{/gist_id}","starred_url":"https://api.github.com/users/Mellanox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mellanox/subscriptions","organizations_url":"https://api.github.com/users/Mellanox/orgs","repos_url":"https://api.github.com/users/Mellanox/repos","events_url":"https://api.github.com/users/Mellanox/events{/privacy}","received_events_url":"https://api.github.com/users/Mellanox/received_events","type":"Organization","site_admin":false},"repo":{"id":34728735,"name":"sockperf","full_name":"Mellanox/sockperf","owner":{"login":"Mellanox","id":5813145,"avatar_url":"https://avatars.githubusercontent.com/u/5813145?v=3","gravatar_id":"","url":"https://api.github.com/users/Mellanox","html_url":"https://github.com/Mellanox","followers_url":"https://api.github.com/users/Mellanox/followers","following_url":"https://api.github.com/users/Mellanox/following{/other_user}","gists_url":"https://api.github.com/users/Mellanox/gists{/gist_id}","starred_url":"https://api.github.com/users/Mellanox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mellanox/subscriptions","organizations_url":"https://api.github.com/users/Mellanox/orgs","repos_url":"https://api.github.com/users/Mellanox/repos","events_url":"https://api.github.com/users/Mellanox/events{/privacy}","received_events_url":"https://api.github.com/users/Mellanox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Mellanox/sockperf","description":"Network Benchmarking Utility (exported from code.google.com/p/sockperf)","fork":false,"url":"https://api.github.com/repos/Mellanox/sockperf","forks_url":"https://api.github.com/repos/Mellanox/sockperf/forks","keys_url":"https://api.github.com/repos/Mellanox/sockperf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mellanox/sockperf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mellanox/sockperf/teams","hooks_url":"https://api.github.com/repos/Mellanox/sockperf/hooks","issue_events_url":"https://api.github.com/repos/Mellanox/sockperf/issues/events{/number}","events_url":"https://api.github.com/repos/Mellanox/sockperf/events","assignees_url":"https://api.github.com/repos/Mellanox/sockperf/assignees{/user}","branches_url":"https://api.github.com/repos/Mellanox/sockperf/branches{/branch}","tags_url":"https://api.github.com/repos/Mellanox/sockperf/tags","blobs_url":"https://api.github.com/repos/Mellanox/sockperf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mellanox/sockperf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mellanox/sockperf/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mellanox/sockperf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mellanox/sockperf/statuses/{sha}","languages_url":"https://api.github.com/repos/Mellanox/sockperf/languages","stargazers_url":"https://api.github.com/repos/Mellanox/sockperf/stargazers","contributors_url":"https://api.github.com/repos/Mellanox/sockperf/contributors","subscribers_url":"https://api.github.com/repos/Mellanox/sockperf/subscribers","subscription_url":"https://api.github.com/repos/Mellanox/sockperf/subscription","commits_url":"https://api.github.com/repos/Mellanox/sockperf/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mellanox/sockperf/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mellanox/sockperf/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mellanox/sockperf/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mellanox/sockperf/contents/{+path}","compare_url":"https://api.github.com/repos/Mellanox/sockperf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mellanox/sockperf/merges","archive_url":"https://api.github.com/repos/Mellanox/sockperf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mellanox/sockperf/downloads","issues_url":"https://api.github.com/repos/Mellanox/sockperf/issues{/number}","pulls_url":"https://api.github.com/repos/Mellanox/sockperf/pulls{/number}","milestones_url":"https://api.github.com/repos/Mellanox/sockperf/milestones{/number}","notifications_url":"https://api.github.com/repos/Mellanox/sockperf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mellanox/sockperf/labels{/name}","releases_url":"https://api.github.com/repos/Mellanox/sockperf/releases{/id}","deployments_url":"https://api.github.com/repos/Mellanox/sockperf/deployments","created_at":"2015-04-28T12:20:10Z","updated_at":"2016-07-01T23:25:35Z","pushed_at":"2016-08-02T08:45:59Z","git_url":"git://github.com/Mellanox/sockperf.git","ssh_url":"git@github.com:Mellanox/sockperf.git","clone_url":"https://github.com/Mellanox/sockperf.git","svn_url":"https://github.com/Mellanox/sockperf","homepage":"","size":776,"stargazers_count":43,"watchers_count":43,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":21,"forks":16,"open_issues":21,"watchers":43,"default_branch":"sockperf_v2"}},"_links":{"self":{"href":"https://api.github.com/repos/Mellanox/sockperf/pulls/74"},"html":{"href":"https://github.com/Mellanox/sockperf/pull/74"},"issue":{"href":"https://api.github.com/repos/Mellanox/sockperf/issues/74"},"comments":{"href":"https://api.github.com/repos/Mellanox/sockperf/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/Mellanox/sockperf/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/Mellanox/sockperf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Mellanox/sockperf/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/Mellanox/sockperf/statuses/0663b35853a70c465ef2d58db19fa9a792ea8561"}}}}
{"actor":{"display_login":"avnerbh"}}