{"action":"created","issue":{"url":"https://api.github.com/repos/scala/scala/issues/5415","repository_url":"https://api.github.com/repos/scala/scala","labels_url":"https://api.github.com/repos/scala/scala/issues/5415/labels{/name}","comments_url":"https://api.github.com/repos/scala/scala/issues/5415/comments","events_url":"https://api.github.com/repos/scala/scala/issues/5415/events","html_url":"https://github.com/scala/scala/pull/5415","id":178604447,"number":5415,"title":"WIP: SD-228 eliminate static super accessors in traits","user":{"login":"lrytz","id":119636,"avatar_url":"https://avatars.githubusercontent.com/u/119636?v=3","gravatar_id":"","url":"https://api.github.com/users/lrytz","html_url":"https://github.com/lrytz","followers_url":"https://api.github.com/users/lrytz/followers","following_url":"https://api.github.com/users/lrytz/following{/other_user}","gists_url":"https://api.github.com/users/lrytz/gists{/gist_id}","starred_url":"https://api.github.com/users/lrytz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrytz/subscriptions","organizations_url":"https://api.github.com/users/lrytz/orgs","repos_url":"https://api.github.com/users/lrytz/repos","events_url":"https://api.github.com/users/lrytz/events{/privacy}","received_events_url":"https://api.github.com/users/lrytz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/scala/scala/milestones/57","html_url":"https://github.com/scala/scala/milestones/2.12.0-RC2","labels_url":"https://api.github.com/repos/scala/scala/milestones/57/labels","id":1987178,"number":57,"title":"2.12.0-RC2","description":"Merge to 2.12.0","creator":{"login":"SethTisue","id":161079,"avatar_url":"https://avatars.githubusercontent.com/u/161079?v=3","gravatar_id":"","url":"https://api.github.com/users/SethTisue","html_url":"https://github.com/SethTisue","followers_url":"https://api.github.com/users/SethTisue/followers","following_url":"https://api.github.com/users/SethTisue/following{/other_user}","gists_url":"https://api.github.com/users/SethTisue/gists{/gist_id}","starred_url":"https://api.github.com/users/SethTisue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SethTisue/subscriptions","organizations_url":"https://api.github.com/users/SethTisue/orgs","repos_url":"https://api.github.com/users/SethTisue/repos","events_url":"https://api.github.com/users/SethTisue/events{/privacy}","received_events_url":"https://api.github.com/users/SethTisue/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":7,"state":"open","created_at":"2016-09-06T20:05:00Z","updated_at":"2016-09-22T13:04:50Z","due_on":"2016-09-26T00:00:00Z","closed_at":null},"comments":10,"created_at":"2016-09-22T13:04:49Z","updated_at":"2016-09-24T21:42:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scala/scala/pulls/5415","html_url":"https://github.com/scala/scala/pull/5415","diff_url":"https://github.com/scala/scala/pull/5415.diff","patch_url":"https://github.com/scala/scala/pull/5415.patch"},"body":"WIP, don't merge: the first commit updates starr to a version on scala-release-temp that corresponds to the tip of this PR. This way I can find out if all commits in this PR pass CI validation.\r\n\r\nThe temporary starr is build from this branch: https://github.com/lrytz/scala/tree/traitSuperAccessorsTmp\r\nIt's the same as this PR, but without the starr update in the first commit. The bootstrap job that built it passed all tests (https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-bootstrap/593/)\r\n\r\nFor submission, the right procedure is probably to keep the current starr, have CI fail on the commits, and then re-starr right after merging it."},"comment":{"url":"https://api.github.com/repos/scala/scala/issues/comments/249389285","html_url":"https://github.com/scala/scala/pull/5415#issuecomment-249389285","issue_url":"https://api.github.com/repos/scala/scala/issues/5415","id":249389285,"user":{"login":"sjrd","id":535934,"avatar_url":"https://avatars.githubusercontent.com/u/535934?v=3","gravatar_id":"","url":"https://api.github.com/users/sjrd","html_url":"https://github.com/sjrd","followers_url":"https://api.github.com/users/sjrd/followers","following_url":"https://api.github.com/users/sjrd/following{/other_user}","gists_url":"https://api.github.com/users/sjrd/gists{/gist_id}","starred_url":"https://api.github.com/users/sjrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjrd/subscriptions","organizations_url":"https://api.github.com/users/sjrd/orgs","repos_url":"https://api.github.com/users/sjrd/repos","events_url":"https://api.github.com/users/sjrd/events{/privacy}","received_events_url":"https://api.github.com/users/sjrd/received_events","type":"User","site_admin":false},"created_at":"2016-09-24T21:42:19Z","updated_at":"2016-09-24T21:42:19Z","body":"Thanks @SethTisue, I manage to get it from the artifacts published by the build you mentioned.\r\n\r\nI think the necessary changes are those in https://github.com/scala-js/scala-js/compare/master...sjrd:static-trait-init-rc2\r\nHowever, I get a very strange error when compiling the helloworld with this branch (`> helloworld/compile`). After compiling the library and eventually arriving at the helloworld, I get:\r\n```\r\n[error] error while loading package, class file 'C:\\Users\\Sepi\\Documents\\Projets\\scalajs\\library\\target\\scala-2.12.0-315\r\n05fe-SNAPSHOT\\scalajs-library_2.12.0-31505fe-SNAPSHOT-0.6.13-SNAPSHOT.jar(scala/scalajs/js/package.class)' is broken\r\n[error] (class java.lang.NullPointerException/null)\r\n[error] error while loading JSApp, class file 'C:\\Users\\Sepi\\Documents\\Projets\\scalajs\\library\\target\\scala-2.12.0-31505\r\nfe-SNAPSHOT\\scalajs-library_2.12.0-31505fe-SNAPSHOT-0.6.13-SNAPSHOT.jar(scala/scalajs/js/JSApp.class)' is broken\r\n[error] (class java.lang.NullPointerException/null)\r\n[error] C:\\Users\\Sepi\\Documents\\Projets\\scalajs\\examples\\helloworld\\HelloWorld.scala:14: illegal inheritance;\r\n[error]  self-type helloworld.HelloWorld.type does not conform to scala.scalajs.js.JSApp's selftype scala.scalajs.js.JSA\r\npp\r\n[error] object HelloWorld extends js.JSApp {\r\n[error]                              ^\r\n[error] three errors found\r\n[error] (helloworld/compile:compileIncremental) Compilation failed\r\n```\r\nNote that this is about *class* files being broken.\r\n\r\nIf I revert the change at declaration site of the `$init$` method, i.e., at https://github.com/scala-js/scala-js/compare/master...sjrd:static-trait-init-rc2#diff-c9a195a739d51194e79f0655bc93bd61R1322 (not at call site), and I rebuild everything (so after a full `clean`), then I can successfully compile the hello world (although not link it, obviously, since the call site and definition site don't match at the IR level).\r\n\r\nIf I revert the change when compiling the library (`library/package`), and then enable the change when compiling the hello world (`helloworld/compile`), compilation succeeds. So this seems to indicate that the issue happens when building the class files for the library, not when loading them.\r\n\r\nOnly *accessing* `sym.isStaticMember` without using its value in the test is not sufficient to trigger the compile error, so it doesn't seem to be an issue caused by forcing. Yet somehow the presence of this test causes the class files to be broken or not.\r\n\r\nI'm a bit lost right now. I think I'll let it rest until Monday, unless you guys have a hint for me.\r\n\r\nFTR, I'm on Windows atm."}}
{"actor":{"display_login":"sjrd"}}