{"action":"created","issue":{"url":"https://api.github.com/repos/ottogroup/palladium/issues/20","repository_url":"https://api.github.com/repos/ottogroup/palladium","labels_url":"https://api.github.com/repos/ottogroup/palladium/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/ottogroup/palladium/issues/20/comments","events_url":"https://api.github.com/repos/ottogroup/palladium/issues/20/events","html_url":"https://github.com/ottogroup/palladium/pull/20","id":164561852,"number":20,"title":"Add a pluggable decorator around palladium.dataset.SQL","user":{"login":"dnouri","id":56370,"avatar_url":"https://avatars.githubusercontent.com/u/56370?v=3","gravatar_id":"","url":"https://api.github.com/users/dnouri","html_url":"https://github.com/dnouri","followers_url":"https://api.github.com/users/dnouri/followers","following_url":"https://api.github.com/users/dnouri/following{/other_user}","gists_url":"https://api.github.com/users/dnouri/gists{/gist_id}","starred_url":"https://api.github.com/users/dnouri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnouri/subscriptions","organizations_url":"https://api.github.com/users/dnouri/orgs","repos_url":"https://api.github.com/users/dnouri/repos","events_url":"https://api.github.com/users/dnouri/events{/privacy}","received_events_url":"https://api.github.com/users/dnouri/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-08T15:57:53Z","updated_at":"2016-07-08T16:22:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ottogroup/palladium/pulls/20","html_url":"https://github.com/ottogroup/palladium/pull/20","diff_url":"https://github.com/ottogroup/palladium/pull/20.diff","patch_url":"https://github.com/ottogroup/palladium/pull/20.patch"},"body":"This allows me to do:\r\n\r\n```\r\n    'load_data_decorators': [\r\n        {\r\n            '__factory__': 'palladium.cache.diskcache',\r\n            'filename_tmpl': 'cache/dataset-{key}',\r\n            'compute_key': {\r\n                '__factory__': 'palladium.cache.compute_key_attrs',\r\n                'attrs': ['engine', 'sql', 'target_column'],\r\n            },\r\n        },\r\n    ],\r\n```\r\n\r\nProbably want to add a mention of this in the docs?\r\n\r\nSupersedes #19"},"comment":{"url":"https://api.github.com/repos/ottogroup/palladium/issues/comments/231404584","html_url":"https://github.com/ottogroup/palladium/pull/20#issuecomment-231404584","issue_url":"https://api.github.com/repos/ottogroup/palladium/issues/20","id":231404584,"user":{"login":"dnouri","id":56370,"avatar_url":"https://avatars.githubusercontent.com/u/56370?v=3","gravatar_id":"","url":"https://api.github.com/users/dnouri","html_url":"https://github.com/dnouri","followers_url":"https://api.github.com/users/dnouri/followers","following_url":"https://api.github.com/users/dnouri/following{/other_user}","gists_url":"https://api.github.com/users/dnouri/gists{/gist_id}","starred_url":"https://api.github.com/users/dnouri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnouri/subscriptions","organizations_url":"https://api.github.com/users/dnouri/orgs","repos_url":"https://api.github.com/users/dnouri/repos","events_url":"https://api.github.com/users/dnouri/events{/privacy}","received_events_url":"https://api.github.com/users/dnouri/received_events","type":"User","site_admin":false},"created_at":"2016-07-08T16:22:16Z","updated_at":"2016-07-08T16:22:16Z","body":"Also we should probably put this decorator around every dataset loader.  I'm just finding out that this is useful for other stuff as well.  :-)\r\n\r\nIt's a little annoying though that every new implementation will have to do this by hand though."}}
{"actor":{"display_login":"dnouri"}}