{"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/android/pulls/comments/69533594","id":69533594,"diff_hunk":"@@ -129,9 +129,9 @@\n             android:name=\".providers.FileContentProvider\"\n             android:authorities=\"@string/authority\"\n             android:enabled=\"true\"\n-            android:exported=\"true\"\n+            android:exported=\"false\"","path":"AndroidManifest.xml","position":5,"original_position":5,"commit_id":"bab67cea30f8b58e454c1b91d9439037af03cb0a","original_commit_id":"bab67cea30f8b58e454c1b91d9439037af03cb0a","user":{"login":"davivel","id":2225614,"avatar_url":"https://avatars.githubusercontent.com/u/2225614?v=3","gravatar_id":"","url":"https://api.github.com/users/davivel","html_url":"https://github.com/davivel","followers_url":"https://api.github.com/users/davivel/followers","following_url":"https://api.github.com/users/davivel/following{/other_user}","gists_url":"https://api.github.com/users/davivel/gists{/gist_id}","starred_url":"https://api.github.com/users/davivel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davivel/subscriptions","organizations_url":"https://api.github.com/users/davivel/orgs","repos_url":"https://api.github.com/users/davivel/repos","events_url":"https://api.github.com/users/davivel/events{/privacy}","received_events_url":"https://api.github.com/users/davivel/received_events","type":"User","site_admin":false},"body":"Self-note: this was set to true with addition of Document Provider.","created_at":"2016-07-05T09:36:45Z","updated_at":"2016-07-05T09:36:45Z","html_url":"https://github.com/owncloud/android/pull/1599#discussion_r69533594","pull_request_url":"https://api.github.com/repos/owncloud/android/pulls/1599","_links":{"self":{"href":"https://api.github.com/repos/owncloud/android/pulls/comments/69533594"},"html":{"href":"https://github.com/owncloud/android/pull/1599#discussion_r69533594"},"pull_request":{"href":"https://api.github.com/repos/owncloud/android/pulls/1599"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/android/pulls/1599","id":65890757,"html_url":"https://github.com/owncloud/android/pull/1599","diff_url":"https://github.com/owncloud/android/pull/1599.diff","patch_url":"https://github.com/owncloud/android/pull/1599.patch","issue_url":"https://api.github.com/repos/owncloud/android/issues/1599","number":1599,"state":"open","locked":false,"title":"Resized images","user":{"login":"tobiasKaminsky","id":5836855,"avatar_url":"https://avatars.githubusercontent.com/u/5836855?v=3","gravatar_id":"","url":"https://api.github.com/users/tobiasKaminsky","html_url":"https://github.com/tobiasKaminsky","followers_url":"https://api.github.com/users/tobiasKaminsky/followers","following_url":"https://api.github.com/users/tobiasKaminsky/following{/other_user}","gists_url":"https://api.github.com/users/tobiasKaminsky/gists{/gist_id}","starred_url":"https://api.github.com/users/tobiasKaminsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobiasKaminsky/subscriptions","organizations_url":"https://api.github.com/users/tobiasKaminsky/orgs","repos_url":"https://api.github.com/users/tobiasKaminsky/repos","events_url":"https://api.github.com/users/tobiasKaminsky/events{/privacy}","received_events_url":"https://api.github.com/users/tobiasKaminsky/received_events","type":"User","site_admin":false},"body":"--------- edited by @jabarros\r\nTASKs:\r\n- [X] Changes after CR @jabarros\r\n- [X] [QA] Create 'resizedImages' branch in QA Repo  @jesmrec\r\n- [X] [QA] Merge 'resizedImages' branch in QA Repo\r\n- [X] [QA] Create test plan @jesmrec \r\n- [ ] [QA] Validate test plan @jesmrec [WIP]\r\n\r\nbugs and improvements:\r\n\r\n- [ ] Unsupported image formats https://github.com/owncloud/android/pull/1599#issuecomment-229400874\r\n- [ ] Bad preview of landscape images https://github.com/owncloud/android/pull/1599#issuecomment-229406324 @davivel [WIP]\r\n\r\n----------\r\n\r\nThis PR is now against master.\r\n\r\nAs this PR introduces a rather complex feature I will summarize it here.\r\n\r\n- Clicking on an image loads a reduced version to the cache.\r\n- The width and height is determinated by the screen.\r\n- the benefit is a very small, but yet usable preview of the image.\r\n- it can be used to send via whatsapp, or as a file to another app (like k9) with the correct filename.\r\n- resized images are not treated as downloaded files. If the user wants to have the real file, he has to long-click and select download.\r\n- clicking on an image shows first a square thumbnail (if available) until the resized image is loaded\r\n\r\n**ToDo**\r\n- Zooming a resized image with at least 2x (which can get blurry)\r\n - show snackbar \"automatically download full image on zoom: yes\"\r\n  - Clicking \"yes\" after second time will offer option \"always\" to prevent showing the question. \r\n  - time out the snackbar the second time by just waiting will show \"never download full image\" -> \"yes\".\r\n  - after both show second snackbar without action \"default behaviour can be changed in settings\"\r\n- In setting: new entry \"click on image downloads ...\"\r\n - full image to storage\r\n - resized image to cache\r\n\r\n\r\n\r\nRemaining problem:\r\nhttps://github.com/owncloud/core/issues/16250","created_at":"2016-04-09T19:55:41Z","updated_at":"2016-07-05T09:36:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bcb963ab9f96691dd28131d0851f2d8b97a2ab9a","assignee":{"login":"davivel","id":2225614,"avatar_url":"https://avatars.githubusercontent.com/u/2225614?v=3","gravatar_id":"","url":"https://api.github.com/users/davivel","html_url":"https://github.com/davivel","followers_url":"https://api.github.com/users/davivel/followers","following_url":"https://api.github.com/users/davivel/following{/other_user}","gists_url":"https://api.github.com/users/davivel/gists{/gist_id}","starred_url":"https://api.github.com/users/davivel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davivel/subscriptions","organizations_url":"https://api.github.com/users/davivel/orgs","repos_url":"https://api.github.com/users/davivel/repos","events_url":"https://api.github.com/users/davivel/events{/privacy}","received_events_url":"https://api.github.com/users/davivel/received_events","type":"User","site_admin":false},"assignees":[{"login":"davivel","id":2225614,"avatar_url":"https://avatars.githubusercontent.com/u/2225614?v=3","gravatar_id":"","url":"https://api.github.com/users/davivel","html_url":"https://github.com/davivel","followers_url":"https://api.github.com/users/davivel/followers","following_url":"https://api.github.com/users/davivel/following{/other_user}","gists_url":"https://api.github.com/users/davivel/gists{/gist_id}","starred_url":"https://api.github.com/users/davivel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davivel/subscriptions","organizations_url":"https://api.github.com/users/davivel/orgs","repos_url":"https://api.github.com/users/davivel/repos","events_url":"https://api.github.com/users/davivel/events{/privacy}","received_events_url":"https://api.github.com/users/davivel/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/owncloud/android/pulls/1599/commits","review_comments_url":"https://api.github.com/repos/owncloud/android/pulls/1599/comments","review_comment_url":"https://api.github.com/repos/owncloud/android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/android/issues/1599/comments","statuses_url":"https://api.github.com/repos/owncloud/android/statuses/bab67cea30f8b58e454c1b91d9439037af03cb0a","head":{"label":"owncloud:resizedImages","ref":"resizedImages","sha":"bab67cea30f8b58e454c1b91d9439037af03cb0a","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550567,"name":"android","full_name":"owncloud/android","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/android","description":":phone: The ownCloud Android App","fork":false,"url":"https://api.github.com/repos/owncloud/android","forks_url":"https://api.github.com/repos/owncloud/android/forks","keys_url":"https://api.github.com/repos/owncloud/android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/android/teams","hooks_url":"https://api.github.com/repos/owncloud/android/hooks","issue_events_url":"https://api.github.com/repos/owncloud/android/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/android/events","assignees_url":"https://api.github.com/repos/owncloud/android/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/android/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/android/tags","blobs_url":"https://api.github.com/repos/owncloud/android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/android/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/android/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/android/languages","stargazers_url":"https://api.github.com/repos/owncloud/android/stargazers","contributors_url":"https://api.github.com/repos/owncloud/android/contributors","subscribers_url":"https://api.github.com/repos/owncloud/android/subscribers","subscription_url":"https://api.github.com/repos/owncloud/android/subscription","commits_url":"https://api.github.com/repos/owncloud/android/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/android/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/android/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/android/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/android/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/android/merges","archive_url":"https://api.github.com/repos/owncloud/android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/android/downloads","issues_url":"https://api.github.com/repos/owncloud/android/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/android/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/android/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/android/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/android/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/android/deployments","created_at":"2012-08-25T10:35:56Z","updated_at":"2016-07-04T09:13:44Z","pushed_at":"2016-07-05T09:35:54Z","git_url":"git://github.com/owncloud/android.git","ssh_url":"git@github.com:owncloud/android.git","clone_url":"https://github.com/owncloud/android.git","svn_url":"https://github.com/owncloud/android","homepage":"","size":186408,"stargazers_count":1629,"watchers_count":1629,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1891,"mirror_url":null,"open_issues_count":366,"forks":1891,"open_issues":366,"watchers":1629,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"f126c68bf7d6517736a4b4d601cc857d40f020db","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550567,"name":"android","full_name":"owncloud/android","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/android","description":":phone: The ownCloud Android App","fork":false,"url":"https://api.github.com/repos/owncloud/android","forks_url":"https://api.github.com/repos/owncloud/android/forks","keys_url":"https://api.github.com/repos/owncloud/android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/android/teams","hooks_url":"https://api.github.com/repos/owncloud/android/hooks","issue_events_url":"https://api.github.com/repos/owncloud/android/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/android/events","assignees_url":"https://api.github.com/repos/owncloud/android/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/android/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/android/tags","blobs_url":"https://api.github.com/repos/owncloud/android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/android/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/android/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/android/languages","stargazers_url":"https://api.github.com/repos/owncloud/android/stargazers","contributors_url":"https://api.github.com/repos/owncloud/android/contributors","subscribers_url":"https://api.github.com/repos/owncloud/android/subscribers","subscription_url":"https://api.github.com/repos/owncloud/android/subscription","commits_url":"https://api.github.com/repos/owncloud/android/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/android/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/android/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/android/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/android/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/android/merges","archive_url":"https://api.github.com/repos/owncloud/android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/android/downloads","issues_url":"https://api.github.com/repos/owncloud/android/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/android/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/android/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/android/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/android/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/android/deployments","created_at":"2012-08-25T10:35:56Z","updated_at":"2016-07-04T09:13:44Z","pushed_at":"2016-07-05T09:35:54Z","git_url":"git://github.com/owncloud/android.git","ssh_url":"git@github.com:owncloud/android.git","clone_url":"https://github.com/owncloud/android.git","svn_url":"https://github.com/owncloud/android","homepage":"","size":186408,"stargazers_count":1629,"watchers_count":1629,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1891,"mirror_url":null,"open_issues_count":366,"forks":1891,"open_issues":366,"watchers":1629,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/android/pulls/1599"},"html":{"href":"https://github.com/owncloud/android/pull/1599"},"issue":{"href":"https://api.github.com/repos/owncloud/android/issues/1599"},"comments":{"href":"https://api.github.com/repos/owncloud/android/issues/1599/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/android/pulls/1599/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/android/pulls/1599/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/android/statuses/bab67cea30f8b58e454c1b91d9439037af03cb0a"}}}}
{"actor":{"display_login":"davivel"}}