{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/79498368","id":79498368,"diff_hunk":"@@ -10,29 +10,18 @@\n     <ProjectGuid>{81A05E2E-E3AE-4246-B4E6-DD5F31FB71F9}</ProjectGuid>\n     <OutputType>Library</OutputType>\n     <AssemblyName>System.Security.Cryptography.Algorithms</AssemblyName>\n-    <AssemblyVersion Condition=\"'$(TargetGroup)'=='net46'\">4.0.0.0</AssemblyVersion>\n-    <ContractProject Condition=\"'$(AssemblyVersion)' == '4.0.0.0'\">..\\ref\\4.0\\System.Security.Cryptography.Algorithms.depproj</ContractProject>\n-    <AssemblyVersion Condition=\"'$(TargetGroup)'=='net461' or '$(TargetGroup)' == 'netcore50'\">4.1.0.0</AssemblyVersion>\n-    <ContractProject Condition=\"'$(AssemblyVersion)' == '4.1.0.0'\">..\\ref\\4.1\\System.Security.Cryptography.Algorithms.depproj</ContractProject>\n-    <AssemblyVersion Condition=\"'$(TargetGroup)' == 'netstandard1.6'\">4.2.0.0</AssemblyVersion>\n-    <ContractProject Condition=\"'$(AssemblyVersion)' == '4.2.0.0'\">..\\ref\\4.2\\System.Security.Cryptography.Algorithms.depproj</ContractProject>\n-    <IsPartialFacadeAssembly Condition=\"'$(TargetGroup)'=='net46' OR '$(TargetGroup)'=='net461' OR '$(TargetGroup)'=='net463'\">true</IsPartialFacadeAssembly>\n+    <IsPartialFacadeAssembly Condition=\"'$(TargetGroup)'=='net463'\">true</IsPartialFacadeAssembly>\n     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>\n     <DefineConstants>INTERNAL_ASYMMETRIC_IMPLEMENTATIONS</DefineConstants>\n     <NuGetTargetMoniker Condition=\"'$(TargetGroup)' == ''\">.NETStandard,Version=v1.7</NuGetTargetMoniker>\n-    <GenFacadesArgs Condition=\"'$(TargetGroup)'=='net463' OR '$(TargetGroup)'=='netstandard1.6' OR '$(TargetGroup)'=='netstandard1.7'\">$(GenFacadesArgs) -ignoreMissingTypes</GenFacadesArgs>\n+    <GenFacadesArgs Condition=\"'$(TargetGroup)'=='net463'\">$(GenFacadesArgs) -ignoreMissingTypes</GenFacadesArgs>\n   </PropertyGroup>\n   <PropertyGroup Condition=\"'$(Configuration)|$(Platform)' == 'OSX_Debug|AnyCPU'\" />\n   <PropertyGroup Condition=\"'$(Configuration)|$(Platform)' == 'OSX_Release|AnyCPU'\" />\n   <PropertyGroup Condition=\"'$(Configuration)|$(Platform)' == 'Unix_Debug|AnyCPU'\" />\n   <PropertyGroup Condition=\"'$(Configuration)|$(Platform)' == 'Unix_Release|AnyCPU'\" />\n   <PropertyGroup Condition=\"'$(Configuration)|$(Platform)' == 'Windows_Debug|AnyCPU'\" />\n   <PropertyGroup Condition=\"'$(Configuration)|$(Platform)' == 'Windows_Release|AnyCPU'\" />\n-  <PropertyGroup Condition=\"'$(Configuration)|$(Platform)' == 'net46_Debug|AnyCPU'\" />\n-  <PropertyGroup Condition=\"'$(Configuration)|$(Platform)' == 'net46_Release|AnyCPU'\" />","path":"src/System.Security.Cryptography.Algorithms/src/System.Security.Cryptography.Algorithms.csproj","position":25,"original_position":25,"commit_id":"580d6b02ecf89a4cc3d8c01fb9c5a8c81941d7c1","original_commit_id":"580d6b02ecf89a4cc3d8c01fb9c5a8c81941d7c1","user":{"login":"steveharter","id":6986755,"avatar_url":"https://avatars.githubusercontent.com/u/6986755?v=3","gravatar_id":"","url":"https://api.github.com/users/steveharter","html_url":"https://github.com/steveharter","followers_url":"https://api.github.com/users/steveharter/followers","following_url":"https://api.github.com/users/steveharter/following{/other_user}","gists_url":"https://api.github.com/users/steveharter/gists{/gist_id}","starred_url":"https://api.github.com/users/steveharter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveharter/subscriptions","organizations_url":"https://api.github.com/users/steveharter/orgs","repos_url":"https://api.github.com/users/steveharter/repos","events_url":"https://api.github.com/users/steveharter/events{/privacy}","received_events_url":"https://api.github.com/users/steveharter/received_events","type":"User","site_admin":false},"body":"These seemed to have gotten stale over time, as net462, net463, etc were never added plus no support for specifying variables such as TargetGroup etc so I decided to remove them. If someone in VS wants to use them, they probably want to define the TargetGroup etc variables before launching VS and then just use the Windows_ configuration IMO. If there is more to it then this, I can add them back easily enough","created_at":"2016-09-19T21:55:43Z","updated_at":"2016-09-19T21:55:43Z","html_url":"https://github.com/dotnet/corefx/pull/11761#discussion_r79498368","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/11761","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/79498368"},"html":{"href":"https://github.com/dotnet/corefx/pull/11761#discussion_r79498368"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/11761"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/11761","id":85473177,"html_url":"https://github.com/dotnet/corefx/pull/11761","diff_url":"https://github.com/dotnet/corefx/pull/11761.diff","patch_url":"https://github.com/dotnet/corefx/pull/11761.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/11761","number":11761,"state":"open","locked":false,"title":"Clean up Algorithms, Cng and OpenSsl projects","user":{"login":"steveharter","id":6986755,"avatar_url":"https://avatars.githubusercontent.com/u/6986755?v=3","gravatar_id":"","url":"https://api.github.com/users/steveharter","html_url":"https://github.com/steveharter","followers_url":"https://api.github.com/users/steveharter/followers","following_url":"https://api.github.com/users/steveharter/following{/other_user}","gists_url":"https://api.github.com/users/steveharter/gists{/gist_id}","starred_url":"https://api.github.com/users/steveharter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveharter/subscriptions","organizations_url":"https://api.github.com/users/steveharter/orgs","repos_url":"https://api.github.com/users/steveharter/repos","events_url":"https://api.github.com/users/steveharter/events{/privacy}","received_events_url":"https://api.github.com/users/steveharter/received_events","type":"User","site_admin":false},"body":"Primarily removed unnecessary refs and build targets\r\n\r\n@joperezr @bartonjs ","created_at":"2016-09-15T20:21:02Z","updated_at":"2016-09-19T21:55:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed71f25f17062d397c55f2de87afc1097e6da653","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/11761/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/11761/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/11761/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/580d6b02ecf89a4cc3d8c01fb9c5a8c81941d7c1","head":{"label":"steveharter:CleanupCryptoProjectsMaster3","ref":"CleanupCryptoProjectsMaster3","sha":"580d6b02ecf89a4cc3d8c01fb9c5a8c81941d7c1","user":{"login":"steveharter","id":6986755,"avatar_url":"https://avatars.githubusercontent.com/u/6986755?v=3","gravatar_id":"","url":"https://api.github.com/users/steveharter","html_url":"https://github.com/steveharter","followers_url":"https://api.github.com/users/steveharter/followers","following_url":"https://api.github.com/users/steveharter/following{/other_user}","gists_url":"https://api.github.com/users/steveharter/gists{/gist_id}","starred_url":"https://api.github.com/users/steveharter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveharter/subscriptions","organizations_url":"https://api.github.com/users/steveharter/orgs","repos_url":"https://api.github.com/users/steveharter/repos","events_url":"https://api.github.com/users/steveharter/events{/privacy}","received_events_url":"https://api.github.com/users/steveharter/received_events","type":"User","site_admin":false},"repo":{"id":39029448,"name":"dotnet_corefx","full_name":"steveharter/dotnet_corefx","owner":{"login":"steveharter","id":6986755,"avatar_url":"https://avatars.githubusercontent.com/u/6986755?v=3","gravatar_id":"","url":"https://api.github.com/users/steveharter","html_url":"https://github.com/steveharter","followers_url":"https://api.github.com/users/steveharter/followers","following_url":"https://api.github.com/users/steveharter/following{/other_user}","gists_url":"https://api.github.com/users/steveharter/gists{/gist_id}","starred_url":"https://api.github.com/users/steveharter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveharter/subscriptions","organizations_url":"https://api.github.com/users/steveharter/orgs","repos_url":"https://api.github.com/users/steveharter/repos","events_url":"https://api.github.com/users/steveharter/events{/privacy}","received_events_url":"https://api.github.com/users/steveharter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/steveharter/dotnet_corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/steveharter/dotnet_corefx","forks_url":"https://api.github.com/repos/steveharter/dotnet_corefx/forks","keys_url":"https://api.github.com/repos/steveharter/dotnet_corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steveharter/dotnet_corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steveharter/dotnet_corefx/teams","hooks_url":"https://api.github.com/repos/steveharter/dotnet_corefx/hooks","issue_events_url":"https://api.github.com/repos/steveharter/dotnet_corefx/issues/events{/number}","events_url":"https://api.github.com/repos/steveharter/dotnet_corefx/events","assignees_url":"https://api.github.com/repos/steveharter/dotnet_corefx/assignees{/user}","branches_url":"https://api.github.com/repos/steveharter/dotnet_corefx/branches{/branch}","tags_url":"https://api.github.com/repos/steveharter/dotnet_corefx/tags","blobs_url":"https://api.github.com/repos/steveharter/dotnet_corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steveharter/dotnet_corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steveharter/dotnet_corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/steveharter/dotnet_corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steveharter/dotnet_corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/steveharter/dotnet_corefx/languages","stargazers_url":"https://api.github.com/repos/steveharter/dotnet_corefx/stargazers","contributors_url":"https://api.github.com/repos/steveharter/dotnet_corefx/contributors","subscribers_url":"https://api.github.com/repos/steveharter/dotnet_corefx/subscribers","subscription_url":"https://api.github.com/repos/steveharter/dotnet_corefx/subscription","commits_url":"https://api.github.com/repos/steveharter/dotnet_corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/steveharter/dotnet_corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/steveharter/dotnet_corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/steveharter/dotnet_corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/steveharter/dotnet_corefx/contents/{+path}","compare_url":"https://api.github.com/repos/steveharter/dotnet_corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steveharter/dotnet_corefx/merges","archive_url":"https://api.github.com/repos/steveharter/dotnet_corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steveharter/dotnet_corefx/downloads","issues_url":"https://api.github.com/repos/steveharter/dotnet_corefx/issues{/number}","pulls_url":"https://api.github.com/repos/steveharter/dotnet_corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/steveharter/dotnet_corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/steveharter/dotnet_corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steveharter/dotnet_corefx/labels{/name}","releases_url":"https://api.github.com/repos/steveharter/dotnet_corefx/releases{/id}","deployments_url":"https://api.github.com/repos/steveharter/dotnet_corefx/deployments","created_at":"2015-07-13T18:20:31Z","updated_at":"2016-01-13T22:53:29Z","pushed_at":"2016-09-19T18:11:51Z","git_url":"git://github.com/steveharter/dotnet_corefx.git","ssh_url":"git@github.com:steveharter/dotnet_corefx.git","clone_url":"https://github.com/steveharter/dotnet_corefx.git","svn_url":"https://github.com/steveharter/dotnet_corefx","homepage":"http://dotnet.github.io/core/","size":97586,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"00a25e166fd3c93db261099cf14e70a0e4fb82a4","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-09-19T20:57:18Z","pushed_at":"2016-09-19T21:49:32Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":142159,"stargazers_count":10530,"watchers_count":10530,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2615,"mirror_url":null,"open_issues_count":1523,"forks":2615,"open_issues":1523,"watchers":10530,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/11761"},"html":{"href":"https://github.com/dotnet/corefx/pull/11761"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/11761"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/11761/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/11761/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/11761/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/580d6b02ecf89a4cc3d8c01fb9c5a8c81941d7c1"}}}}
{"actor":{"display_login":"steveharter"}}