{"action":"created","comment":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments/90948922","pull_request_review_id":11462506,"id":90948922,"diff_hunk":"@@ -22,8 +22,8 @@ def get():\n             return 'system'\n     if osx:\n         if val == 'libunwind':\n-            raise ValueError(\"Using CHPL_UNWIND=libunwind is not supported\"+\n-                            \" on Mac OS X. Use CHPL_UNWIND=system instead.\")\n+            error(\"Using CHPL_UNWIND=libunwind is not supported\"+","path":"util/chplenv/chpl_unwind.py","position":15,"original_position":15,"commit_id":"3e5b2bee40657d83ccc85ae2dfe4c63e7c45abe9","original_commit_id":"3e5b2bee40657d83ccc85ae2dfe4c63e7c45abe9","user":{"login":"ronawho","id":1588337,"avatar_url":"https://avatars.githubusercontent.com/u/1588337?v=3","gravatar_id":"","url":"https://api.github.com/users/ronawho","html_url":"https://github.com/ronawho","followers_url":"https://api.github.com/users/ronawho/followers","following_url":"https://api.github.com/users/ronawho/following{/other_user}","gists_url":"https://api.github.com/users/ronawho/gists{/gist_id}","starred_url":"https://api.github.com/users/ronawho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronawho/subscriptions","organizations_url":"https://api.github.com/users/ronawho/orgs","repos_url":"https://api.github.com/users/ronawho/repos","events_url":"https://api.github.com/users/ronawho/events{/privacy}","received_events_url":"https://api.github.com/users/ronawho/received_events","type":"User","site_admin":false},"body":"Oh.. I guess we were using a `+` here too. Can you get rid of this too (or am I super wrong about how often we use `+` just to join strings together","created_at":"2016-12-05T20:30:24Z","updated_at":"2016-12-05T20:30:24Z","html_url":"https://github.com/chapel-lang/chapel/pull/4943#discussion_r90948922","pull_request_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/4943","_links":{"self":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments/90948922"},"html":{"href":"https://github.com/chapel-lang/chapel/pull/4943#discussion_r90948922"},"pull_request":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/4943"}}},"pull_request":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/4943","id":96601366,"html_url":"https://github.com/chapel-lang/chapel/pull/4943","diff_url":"https://github.com/chapel-lang/chapel/pull/4943.diff","patch_url":"https://github.com/chapel-lang/chapel/pull/4943.patch","issue_url":"https://api.github.com/repos/chapel-lang/chapel/issues/4943","number":4943,"state":"open","locked":false,"title":"Better error messages for chplenv scripts","user":{"login":"ben-albrecht","id":3595449,"avatar_url":"https://avatars.githubusercontent.com/u/3595449?v=3","gravatar_id":"","url":"https://api.github.com/users/ben-albrecht","html_url":"https://github.com/ben-albrecht","followers_url":"https://api.github.com/users/ben-albrecht/followers","following_url":"https://api.github.com/users/ben-albrecht/following{/other_user}","gists_url":"https://api.github.com/users/ben-albrecht/gists{/gist_id}","starred_url":"https://api.github.com/users/ben-albrecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ben-albrecht/subscriptions","organizations_url":"https://api.github.com/users/ben-albrecht/orgs","repos_url":"https://api.github.com/users/ben-albrecht/repos","events_url":"https://api.github.com/users/ben-albrecht/events{/privacy}","received_events_url":"https://api.github.com/users/ben-albrecht/received_events","type":"User","site_admin":false},"body":"This PR does 2 things:\r\n\r\n0. Improved some documentation\r\n1. Wraps `run_command` in a try-except statement\r\n    - This was motivated by a user trying to install Chapel on windows, where no backend C compiler was found, resulting in a not-too-helpful `OSError` & traceback.\r\n2. Provides an error-handling wrapper function that differentiates error output based on `CHPL_DEVELOPER` being set:\r\n    - In user-mode (`CHPL_DEVELOPER` unset), the error is formatted as `Error: {error_msg}`\r\n    - In developer-mode (`CHPL_DEVELOPER` set), an exception is raised as `raise Exception(error_msg)`\r\n        - This results in a full traceback\r\n\r\nWith this addition, we may assert that users should never encounter raised exceptions, and if they do, it is an exception we are not catching properly.","created_at":"2016-12-05T20:17:28Z","updated_at":"2016-12-05T20:30:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aabe29bb92e3fea9307591389dba7232c63a58c7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/4943/commits","review_comments_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/4943/comments","review_comment_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/issues/4943/comments","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/3e5b2bee40657d83ccc85ae2dfe4c63e7c45abe9","head":{"label":"ben-albrecht:chplenv-error-handling","ref":"chplenv-error-handling","sha":"3e5b2bee40657d83ccc85ae2dfe4c63e7c45abe9","user":{"login":"ben-albrecht","id":3595449,"avatar_url":"https://avatars.githubusercontent.com/u/3595449?v=3","gravatar_id":"","url":"https://api.github.com/users/ben-albrecht","html_url":"https://github.com/ben-albrecht","followers_url":"https://api.github.com/users/ben-albrecht/followers","following_url":"https://api.github.com/users/ben-albrecht/following{/other_user}","gists_url":"https://api.github.com/users/ben-albrecht/gists{/gist_id}","starred_url":"https://api.github.com/users/ben-albrecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ben-albrecht/subscriptions","organizations_url":"https://api.github.com/users/ben-albrecht/orgs","repos_url":"https://api.github.com/users/ben-albrecht/repos","events_url":"https://api.github.com/users/ben-albrecht/events{/privacy}","received_events_url":"https://api.github.com/users/ben-albrecht/received_events","type":"User","site_admin":false},"repo":{"id":42141319,"name":"chapel","full_name":"ben-albrecht/chapel","owner":{"login":"ben-albrecht","id":3595449,"avatar_url":"https://avatars.githubusercontent.com/u/3595449?v=3","gravatar_id":"","url":"https://api.github.com/users/ben-albrecht","html_url":"https://github.com/ben-albrecht","followers_url":"https://api.github.com/users/ben-albrecht/followers","following_url":"https://api.github.com/users/ben-albrecht/following{/other_user}","gists_url":"https://api.github.com/users/ben-albrecht/gists{/gist_id}","starred_url":"https://api.github.com/users/ben-albrecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ben-albrecht/subscriptions","organizations_url":"https://api.github.com/users/ben-albrecht/orgs","repos_url":"https://api.github.com/users/ben-albrecht/repos","events_url":"https://api.github.com/users/ben-albrecht/events{/privacy}","received_events_url":"https://api.github.com/users/ben-albrecht/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ben-albrecht/chapel","description":"a Productive Parallel Programming Language","fork":true,"url":"https://api.github.com/repos/ben-albrecht/chapel","forks_url":"https://api.github.com/repos/ben-albrecht/chapel/forks","keys_url":"https://api.github.com/repos/ben-albrecht/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ben-albrecht/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ben-albrecht/chapel/teams","hooks_url":"https://api.github.com/repos/ben-albrecht/chapel/hooks","issue_events_url":"https://api.github.com/repos/ben-albrecht/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/ben-albrecht/chapel/events","assignees_url":"https://api.github.com/repos/ben-albrecht/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/ben-albrecht/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/ben-albrecht/chapel/tags","blobs_url":"https://api.github.com/repos/ben-albrecht/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ben-albrecht/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ben-albrecht/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/ben-albrecht/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ben-albrecht/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/ben-albrecht/chapel/languages","stargazers_url":"https://api.github.com/repos/ben-albrecht/chapel/stargazers","contributors_url":"https://api.github.com/repos/ben-albrecht/chapel/contributors","subscribers_url":"https://api.github.com/repos/ben-albrecht/chapel/subscribers","subscription_url":"https://api.github.com/repos/ben-albrecht/chapel/subscription","commits_url":"https://api.github.com/repos/ben-albrecht/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/ben-albrecht/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/ben-albrecht/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/ben-albrecht/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/ben-albrecht/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/ben-albrecht/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ben-albrecht/chapel/merges","archive_url":"https://api.github.com/repos/ben-albrecht/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ben-albrecht/chapel/downloads","issues_url":"https://api.github.com/repos/ben-albrecht/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/ben-albrecht/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/ben-albrecht/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/ben-albrecht/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ben-albrecht/chapel/labels{/name}","releases_url":"https://api.github.com/repos/ben-albrecht/chapel/releases{/id}","deployments_url":"https://api.github.com/repos/ben-albrecht/chapel/deployments","created_at":"2015-09-08T21:59:50Z","updated_at":"2016-10-26T20:37:40Z","pushed_at":"2016-12-05T20:07:19Z","git_url":"git://github.com/ben-albrecht/chapel.git","ssh_url":"git@github.com:ben-albrecht/chapel.git","clone_url":"https://github.com/ben-albrecht/chapel.git","svn_url":"https://github.com/ben-albrecht/chapel","homepage":"http://chapel.cray.com/","size":387964,"stargazers_count":1,"watchers_count":1,"language":"Chapel","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"chapel-lang:master","ref":"master","sha":"e15aca1fade2c9c3a694c8ce51e42ab456a143a6","user":{"login":"chapel-lang","id":7597261,"avatar_url":"https://avatars.githubusercontent.com/u/7597261?v=3","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":21663285,"name":"chapel","full_name":"chapel-lang/chapel","owner":{"login":"chapel-lang","id":7597261,"avatar_url":"https://avatars.githubusercontent.com/u/7597261?v=3","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chapel-lang/chapel","description":"a Productive Parallel Programming Language","fork":false,"url":"https://api.github.com/repos/chapel-lang/chapel","forks_url":"https://api.github.com/repos/chapel-lang/chapel/forks","keys_url":"https://api.github.com/repos/chapel-lang/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chapel-lang/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chapel-lang/chapel/teams","hooks_url":"https://api.github.com/repos/chapel-lang/chapel/hooks","issue_events_url":"https://api.github.com/repos/chapel-lang/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/chapel-lang/chapel/events","assignees_url":"https://api.github.com/repos/chapel-lang/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/chapel-lang/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/chapel-lang/chapel/tags","blobs_url":"https://api.github.com/repos/chapel-lang/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chapel-lang/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chapel-lang/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/chapel-lang/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/chapel-lang/chapel/languages","stargazers_url":"https://api.github.com/repos/chapel-lang/chapel/stargazers","contributors_url":"https://api.github.com/repos/chapel-lang/chapel/contributors","subscribers_url":"https://api.github.com/repos/chapel-lang/chapel/subscribers","subscription_url":"https://api.github.com/repos/chapel-lang/chapel/subscription","commits_url":"https://api.github.com/repos/chapel-lang/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/chapel-lang/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/chapel-lang/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/chapel-lang/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/chapel-lang/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chapel-lang/chapel/merges","archive_url":"https://api.github.com/repos/chapel-lang/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chapel-lang/chapel/downloads","issues_url":"https://api.github.com/repos/chapel-lang/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/chapel-lang/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/chapel-lang/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/chapel-lang/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chapel-lang/chapel/labels{/name}","releases_url":"https://api.github.com/repos/chapel-lang/chapel/releases{/id}","deployments_url":"https://api.github.com/repos/chapel-lang/chapel/deployments","created_at":"2014-07-09T18:15:54Z","updated_at":"2016-12-05T18:14:37Z","pushed_at":"2016-12-05T20:17:28Z","git_url":"git://github.com/chapel-lang/chapel.git","ssh_url":"git@github.com:chapel-lang/chapel.git","clone_url":"https://github.com/chapel-lang/chapel.git","svn_url":"https://github.com/chapel-lang/chapel","homepage":"http://chapel.cray.com/","size":518906,"stargazers_count":342,"watchers_count":342,"language":"Chapel","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":110,"mirror_url":null,"open_issues_count":13,"forks":110,"open_issues":13,"watchers":342,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/4943"},"html":{"href":"https://github.com/chapel-lang/chapel/pull/4943"},"issue":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/4943"},"comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/4943/comments"},"review_comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/4943/comments"},"review_comment":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/4943/commits"},"statuses":{"href":"https://api.github.com/repos/chapel-lang/chapel/statuses/3e5b2bee40657d83ccc85ae2dfe4c63e7c45abe9"}}}}
{"actor":{"display_login":"ronawho"}}