{"action":"created","comment":{"url":"https://api.github.com/repos/pydata/xarray/pulls/comments/85572596","pull_request_review_id":6283245,"id":85572596,"diff_hunk":"@@ -2268,3 +2268,35 @@ def test_dot(self):\n             da.dot(dm.values)\n         with self.assertRaisesRegexp(ValueError, 'no shared dimensions'):\n             da.dot(DataArray(1))\n+\n+    def test_binary_op_join_setting(self):\n+        \"\"\"\n+        A test method to verify the ability to set binary operation join kwarg","path":"xarray/test/test_dataarray.py","position":7,"original_position":7,"commit_id":"43df4d0c8318c489627c14ffd85caa7c821a00ec","original_commit_id":"43df4d0c8318c489627c14ffd85caa7c821a00ec","user":{"login":"chunweiyuan","id":5572303,"avatar_url":"https://avatars.githubusercontent.com/u/5572303?v=3","gravatar_id":"","url":"https://api.github.com/users/chunweiyuan","html_url":"https://github.com/chunweiyuan","followers_url":"https://api.github.com/users/chunweiyuan/followers","following_url":"https://api.github.com/users/chunweiyuan/following{/other_user}","gists_url":"https://api.github.com/users/chunweiyuan/gists{/gist_id}","starred_url":"https://api.github.com/users/chunweiyuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chunweiyuan/subscriptions","organizations_url":"https://api.github.com/users/chunweiyuan/orgs","repos_url":"https://api.github.com/users/chunweiyuan/repos","events_url":"https://api.github.com/users/chunweiyuan/events{/privacy}","received_events_url":"https://api.github.com/users/chunweiyuan/received_events","type":"User","site_admin":false},"body":"Cool.  Will remove.","created_at":"2016-10-28T17:17:11Z","updated_at":"2016-10-28T17:17:12Z","html_url":"https://github.com/pydata/xarray/pull/1065#discussion_r85572596","pull_request_url":"https://api.github.com/repos/pydata/xarray/pulls/1065","_links":{"self":{"href":"https://api.github.com/repos/pydata/xarray/pulls/comments/85572596"},"html":{"href":"https://github.com/pydata/xarray/pull/1065#discussion_r85572596"},"pull_request":{"href":"https://api.github.com/repos/pydata/xarray/pulls/1065"}}},"pull_request":{"url":"https://api.github.com/repos/pydata/xarray/pulls/1065","id":91290933,"html_url":"https://github.com/pydata/xarray/pull/1065","diff_url":"https://github.com/pydata/xarray/pull/1065.diff","patch_url":"https://github.com/pydata/xarray/pull/1065.patch","issue_url":"https://api.github.com/repos/pydata/xarray/issues/1065","number":1065,"state":"open","locked":false,"title":"Options to binary ops kwargs","user":{"login":"chunweiyuan","id":5572303,"avatar_url":"https://avatars.githubusercontent.com/u/5572303?v=3","gravatar_id":"","url":"https://api.github.com/users/chunweiyuan","html_url":"https://github.com/chunweiyuan","followers_url":"https://api.github.com/users/chunweiyuan/followers","following_url":"https://api.github.com/users/chunweiyuan/following{/other_user}","gists_url":"https://api.github.com/users/chunweiyuan/gists{/gist_id}","starred_url":"https://api.github.com/users/chunweiyuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chunweiyuan/subscriptions","organizations_url":"https://api.github.com/users/chunweiyuan/orgs","repos_url":"https://api.github.com/users/chunweiyuan/repos","events_url":"https://api.github.com/users/chunweiyuan/events{/privacy}","received_events_url":"https://api.github.com/users/chunweiyuan/received_events","type":"User","site_admin":false},"body":"Currently the default is join=\"inner\". However, there can be applications where the majority of binary operations require join=\"outer\", not \"inner\".\r\n\r\nAddresses https://github.com/pydata/xarray/issues/1059\r\n\r\nThe solution we come up with is adding a default key/value to OPTIONS, and dynamically access/update it in code (_binary_op in both dataarray.py and dataset.py)\r\n\r\nWe've also added test modules in test_dataarray.py and test_dataset.py.  All tests passed.","created_at":"2016-10-27T22:17:16Z","updated_at":"2016-10-28T17:17:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e53542aa1bc499b76444124e20a53be9c0bb31a1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pydata/xarray/pulls/1065/commits","review_comments_url":"https://api.github.com/repos/pydata/xarray/pulls/1065/comments","review_comment_url":"https://api.github.com/repos/pydata/xarray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pydata/xarray/issues/1065/comments","statuses_url":"https://api.github.com/repos/pydata/xarray/statuses/43df4d0c8318c489627c14ffd85caa7c821a00ec","head":{"label":"chunweiyuan:options_to_binary_ops_kwargs","ref":"options_to_binary_ops_kwargs","sha":"43df4d0c8318c489627c14ffd85caa7c821a00ec","user":{"login":"chunweiyuan","id":5572303,"avatar_url":"https://avatars.githubusercontent.com/u/5572303?v=3","gravatar_id":"","url":"https://api.github.com/users/chunweiyuan","html_url":"https://github.com/chunweiyuan","followers_url":"https://api.github.com/users/chunweiyuan/followers","following_url":"https://api.github.com/users/chunweiyuan/following{/other_user}","gists_url":"https://api.github.com/users/chunweiyuan/gists{/gist_id}","starred_url":"https://api.github.com/users/chunweiyuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chunweiyuan/subscriptions","organizations_url":"https://api.github.com/users/chunweiyuan/orgs","repos_url":"https://api.github.com/users/chunweiyuan/repos","events_url":"https://api.github.com/users/chunweiyuan/events{/privacy}","received_events_url":"https://api.github.com/users/chunweiyuan/received_events","type":"User","site_admin":false},"repo":{"id":71937788,"name":"xarray","full_name":"chunweiyuan/xarray","owner":{"login":"chunweiyuan","id":5572303,"avatar_url":"https://avatars.githubusercontent.com/u/5572303?v=3","gravatar_id":"","url":"https://api.github.com/users/chunweiyuan","html_url":"https://github.com/chunweiyuan","followers_url":"https://api.github.com/users/chunweiyuan/followers","following_url":"https://api.github.com/users/chunweiyuan/following{/other_user}","gists_url":"https://api.github.com/users/chunweiyuan/gists{/gist_id}","starred_url":"https://api.github.com/users/chunweiyuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chunweiyuan/subscriptions","organizations_url":"https://api.github.com/users/chunweiyuan/orgs","repos_url":"https://api.github.com/users/chunweiyuan/repos","events_url":"https://api.github.com/users/chunweiyuan/events{/privacy}","received_events_url":"https://api.github.com/users/chunweiyuan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chunweiyuan/xarray","description":"N-D labeled arrays and datasets in Python","fork":true,"url":"https://api.github.com/repos/chunweiyuan/xarray","forks_url":"https://api.github.com/repos/chunweiyuan/xarray/forks","keys_url":"https://api.github.com/repos/chunweiyuan/xarray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chunweiyuan/xarray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chunweiyuan/xarray/teams","hooks_url":"https://api.github.com/repos/chunweiyuan/xarray/hooks","issue_events_url":"https://api.github.com/repos/chunweiyuan/xarray/issues/events{/number}","events_url":"https://api.github.com/repos/chunweiyuan/xarray/events","assignees_url":"https://api.github.com/repos/chunweiyuan/xarray/assignees{/user}","branches_url":"https://api.github.com/repos/chunweiyuan/xarray/branches{/branch}","tags_url":"https://api.github.com/repos/chunweiyuan/xarray/tags","blobs_url":"https://api.github.com/repos/chunweiyuan/xarray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chunweiyuan/xarray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chunweiyuan/xarray/git/refs{/sha}","trees_url":"https://api.github.com/repos/chunweiyuan/xarray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chunweiyuan/xarray/statuses/{sha}","languages_url":"https://api.github.com/repos/chunweiyuan/xarray/languages","stargazers_url":"https://api.github.com/repos/chunweiyuan/xarray/stargazers","contributors_url":"https://api.github.com/repos/chunweiyuan/xarray/contributors","subscribers_url":"https://api.github.com/repos/chunweiyuan/xarray/subscribers","subscription_url":"https://api.github.com/repos/chunweiyuan/xarray/subscription","commits_url":"https://api.github.com/repos/chunweiyuan/xarray/commits{/sha}","git_commits_url":"https://api.github.com/repos/chunweiyuan/xarray/git/commits{/sha}","comments_url":"https://api.github.com/repos/chunweiyuan/xarray/comments{/number}","issue_comment_url":"https://api.github.com/repos/chunweiyuan/xarray/issues/comments{/number}","contents_url":"https://api.github.com/repos/chunweiyuan/xarray/contents/{+path}","compare_url":"https://api.github.com/repos/chunweiyuan/xarray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chunweiyuan/xarray/merges","archive_url":"https://api.github.com/repos/chunweiyuan/xarray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chunweiyuan/xarray/downloads","issues_url":"https://api.github.com/repos/chunweiyuan/xarray/issues{/number}","pulls_url":"https://api.github.com/repos/chunweiyuan/xarray/pulls{/number}","milestones_url":"https://api.github.com/repos/chunweiyuan/xarray/milestones{/number}","notifications_url":"https://api.github.com/repos/chunweiyuan/xarray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chunweiyuan/xarray/labels{/name}","releases_url":"https://api.github.com/repos/chunweiyuan/xarray/releases{/id}","deployments_url":"https://api.github.com/repos/chunweiyuan/xarray/deployments","created_at":"2016-10-25T20:48:05Z","updated_at":"2016-10-25T20:48:08Z","pushed_at":"2016-10-27T22:10:20Z","git_url":"git://github.com/chunweiyuan/xarray.git","ssh_url":"git@github.com:chunweiyuan/xarray.git","clone_url":"https://github.com/chunweiyuan/xarray.git","svn_url":"https://github.com/chunweiyuan/xarray","homepage":"http://xarray.pydata.org","size":8116,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pydata:master","ref":"master","sha":"90c854fd0ad20a35935319eb5b45a827d3269e81","user":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"repo":{"id":13221727,"name":"xarray","full_name":"pydata/xarray","owner":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pydata/xarray","description":"N-D labeled arrays and datasets in Python","fork":false,"url":"https://api.github.com/repos/pydata/xarray","forks_url":"https://api.github.com/repos/pydata/xarray/forks","keys_url":"https://api.github.com/repos/pydata/xarray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pydata/xarray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pydata/xarray/teams","hooks_url":"https://api.github.com/repos/pydata/xarray/hooks","issue_events_url":"https://api.github.com/repos/pydata/xarray/issues/events{/number}","events_url":"https://api.github.com/repos/pydata/xarray/events","assignees_url":"https://api.github.com/repos/pydata/xarray/assignees{/user}","branches_url":"https://api.github.com/repos/pydata/xarray/branches{/branch}","tags_url":"https://api.github.com/repos/pydata/xarray/tags","blobs_url":"https://api.github.com/repos/pydata/xarray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pydata/xarray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pydata/xarray/git/refs{/sha}","trees_url":"https://api.github.com/repos/pydata/xarray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pydata/xarray/statuses/{sha}","languages_url":"https://api.github.com/repos/pydata/xarray/languages","stargazers_url":"https://api.github.com/repos/pydata/xarray/stargazers","contributors_url":"https://api.github.com/repos/pydata/xarray/contributors","subscribers_url":"https://api.github.com/repos/pydata/xarray/subscribers","subscription_url":"https://api.github.com/repos/pydata/xarray/subscription","commits_url":"https://api.github.com/repos/pydata/xarray/commits{/sha}","git_commits_url":"https://api.github.com/repos/pydata/xarray/git/commits{/sha}","comments_url":"https://api.github.com/repos/pydata/xarray/comments{/number}","issue_comment_url":"https://api.github.com/repos/pydata/xarray/issues/comments{/number}","contents_url":"https://api.github.com/repos/pydata/xarray/contents/{+path}","compare_url":"https://api.github.com/repos/pydata/xarray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pydata/xarray/merges","archive_url":"https://api.github.com/repos/pydata/xarray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pydata/xarray/downloads","issues_url":"https://api.github.com/repos/pydata/xarray/issues{/number}","pulls_url":"https://api.github.com/repos/pydata/xarray/pulls{/number}","milestones_url":"https://api.github.com/repos/pydata/xarray/milestones{/number}","notifications_url":"https://api.github.com/repos/pydata/xarray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pydata/xarray/labels{/name}","releases_url":"https://api.github.com/repos/pydata/xarray/releases{/id}","deployments_url":"https://api.github.com/repos/pydata/xarray/deployments","created_at":"2013-09-30T17:21:10Z","updated_at":"2016-10-28T15:39:13Z","pushed_at":"2016-10-27T22:17:17Z","git_url":"git://github.com/pydata/xarray.git","ssh_url":"git@github.com:pydata/xarray.git","clone_url":"https://github.com/pydata/xarray.git","svn_url":"https://github.com/pydata/xarray","homepage":"http://xarray.pydata.org","size":8794,"stargazers_count":443,"watchers_count":443,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":132,"mirror_url":null,"open_issues_count":207,"forks":132,"open_issues":207,"watchers":443,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pydata/xarray/pulls/1065"},"html":{"href":"https://github.com/pydata/xarray/pull/1065"},"issue":{"href":"https://api.github.com/repos/pydata/xarray/issues/1065"},"comments":{"href":"https://api.github.com/repos/pydata/xarray/issues/1065/comments"},"review_comments":{"href":"https://api.github.com/repos/pydata/xarray/pulls/1065/comments"},"review_comment":{"href":"https://api.github.com/repos/pydata/xarray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pydata/xarray/pulls/1065/commits"},"statuses":{"href":"https://api.github.com/repos/pydata/xarray/statuses/43df4d0c8318c489627c14ffd85caa7c821a00ec"}}}}
{"actor":{"display_login":"chunweiyuan"}}