{"action":"closed","issue":{"url":"https://api.github.com/repos/react-toolbox/react-toolbox/issues/957","repository_url":"https://api.github.com/repos/react-toolbox/react-toolbox","labels_url":"https://api.github.com/repos/react-toolbox/react-toolbox/issues/957/labels{/name}","comments_url":"https://api.github.com/repos/react-toolbox/react-toolbox/issues/957/comments","events_url":"https://api.github.com/repos/react-toolbox/react-toolbox/issues/957/events","html_url":"https://github.com/react-toolbox/react-toolbox/issues/957","id":188886056,"number":957,"title":"Wrapped / composed TableRows do not get rendered by Table (v2)","user":{"login":"motevets","id":777773,"avatar_url":"https://avatars.githubusercontent.com/u/777773?v=3","gravatar_id":"","url":"https://api.github.com/users/motevets","html_url":"https://github.com/motevets","followers_url":"https://api.github.com/users/motevets/followers","following_url":"https://api.github.com/users/motevets/following{/other_user}","gists_url":"https://api.github.com/users/motevets/gists{/gist_id}","starred_url":"https://api.github.com/users/motevets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/motevets/subscriptions","organizations_url":"https://api.github.com/users/motevets/orgs","repos_url":"https://api.github.com/users/motevets/repos","events_url":"https://api.github.com/users/motevets/events{/privacy}","received_events_url":"https://api.github.com/users/motevets/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-12T02:07:15Z","updated_at":"2016-11-22T16:20:23Z","closed_at":"2016-11-22T16:20:23Z","body":"Hey, thanks for all your work on react-toolbox.  We are trying out the `css-next` branch and really enjoying it.  One issue that were having with the new table is wrapping TableRow in another component to be rendered in a table. E.g.\r\n\r\n```\r\n<Table selectable={false}>\r\n  <TableHead>\r\n    <TableCell>Widget</TableCell>\r\n    <TableCell>Price</TableCell>\r\n    <TableCell>Color</TableCell>\r\n  </TableHead>\r\n  { this.props.wigets.map((widget, i) => (\r\n    <WidgetRow key={i} widget={widget} />\r\n  ))}\r\n</Table>\r\n```\r\n\r\nWhere WidgetRow renders something like:\r\n```\r\n<TableRow>\r\n  <TableCell>{this.props.widget.name}</TableCell>\r\n  <TableCell>\r\n    <Input\r\n      type=\"text\"\r\n      value={this.state.price}\r\n      onChange={this.handlePriceChange}\r\n      onBlur={this.savePriceChange}\r\n    />\r\n  </TableCell>\r\n  <TableCell>\r\n    <Input\r\n      type=\"text\"\r\n      value={this.state.color}\r\n      onChange={this.handleColorChange}\r\n      onBlur={this.saveColorChange}\r\n    />\r\n  </TableCell>\r\n</TableRow>\r\n```\r\n\r\nWe thought it would be good to extract table rows into their own component so that we wouldn't have to maintain a multi-dimensional array of states for each widget/attribute.  Is this a use-case you would like to support for the new react-toolbox tables?  Is there another prefered method to accomplish this?  Would you be open to a pull request to allow for components to wrap TableRow in a Table?.\r\n\r\n"}}
{"actor":{"display_login":"javivelasco"}}