{"action":"created","comment":{"url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/pulls/comments/85489668","pull_request_review_id":6202940,"id":85489668,"diff_hunk":"@@ -59,11 +60,11 @@ public void enableReportingOnDevice(final Iec61850Client iec61850Client, final D\n      * When using the {@link Iec61850ClearReportCommand} the 'sequence number'\n      * will always be reset to 0.\n      *\n-     * @throws NodeException\n-     *             In case writing or reading of data-attributes fails.\n+     * @throws NodeWriteException\n+     *             In case writing of data-attributes fails.\n      */\n     public void enableReportingOnDeviceWithoutUsingSequenceNumber(final Iec61850Client iec61850Client,","path":"osgp-protocol-adapter-iec61850/src/main/java/com/alliander/osgp/adapter/protocol/iec61850/infra/networking/services/commands/Iec61850EnableReportingCommand.java","position":17,"original_position":17,"commit_id":"479bbc2592da4e6b0fcbf9be524a1ebae6b1c273","original_commit_id":"479bbc2592da4e6b0fcbf9be524a1ebae6b1c273","user":{"login":"jenkins-ip-10-4-24-184","id":12208121,"avatar_url":"https://avatars.githubusercontent.com/u/12208121?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkins-ip-10-4-24-184","html_url":"https://github.com/jenkins-ip-10-4-24-184","followers_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/followers","following_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/following{/other_user}","gists_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/subscriptions","organizations_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/orgs","repos_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/repos","events_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/events{/privacy}","received_events_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/received_events","type":"User","site_admin":false},"body":"![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) Remove this unused method parameter \"iec61850Client\". [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://54.77.62.182/sonarqube/coding_rules#rule_key=squid%3AS1172)\n","created_at":"2016-10-28T08:22:28Z","updated_at":"2016-10-28T08:22:28Z","html_url":"https://github.com/OSGP/Protocol-Adapter-IEC61850/pull/57#discussion_r85489668","pull_request_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/pulls/57","_links":{"self":{"href":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/pulls/comments/85489668"},"html":{"href":"https://github.com/OSGP/Protocol-Adapter-IEC61850/pull/57#discussion_r85489668"},"pull_request":{"href":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/pulls/57"}}},"pull_request":{"url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/pulls/57","id":91340138,"html_url":"https://github.com/OSGP/Protocol-Adapter-IEC61850/pull/57","diff_url":"https://github.com/OSGP/Protocol-Adapter-IEC61850/pull/57.diff","patch_url":"https://github.com/OSGP/Protocol-Adapter-IEC61850/pull/57.patch","issue_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/issues/57","number":57,"state":"open","locked":false,"title":"FLEX-2318 ~ Feat improve ioexception handling","user":{"login":"kevinsmeets","id":11557950,"avatar_url":"https://avatars.githubusercontent.com/u/11557950?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinsmeets","html_url":"https://github.com/kevinsmeets","followers_url":"https://api.github.com/users/kevinsmeets/followers","following_url":"https://api.github.com/users/kevinsmeets/following{/other_user}","gists_url":"https://api.github.com/users/kevinsmeets/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinsmeets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinsmeets/subscriptions","organizations_url":"https://api.github.com/users/kevinsmeets/orgs","repos_url":"https://api.github.com/users/kevinsmeets/repos","events_url":"https://api.github.com/users/kevinsmeets/events{/privacy}","received_events_url":"https://api.github.com/users/kevinsmeets/received_events","type":"User","site_admin":false},"body":"- removes usage of connection-cache for SSLD connections\r\n- adds logging of duration per function, see FLEX-2355\r\n- implements SessionAwareMessageListener in order to execute reties/redeliveries when JMSExceptions are thrown\r\n- uses JMSXDeliveryCount to determine if the last redelivery has been executed in order to sent a ProtocolResponseMessage\r\n- replaces deprecated code when constructing ProtocolResponseMesssages\r\n- logs number of retries when NodeReadException/NodeWriteException occurs\r\n- improves error handling for switchLightRelay() used by setLight() and runSelfTest()","created_at":"2016-10-28T08:19:52Z","updated_at":"2016-10-28T08:22:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c45c137fa947b09de13632b7af730e08c2bf789b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/pulls/57/commits","review_comments_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/pulls/57/comments","review_comment_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/issues/57/comments","statuses_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/statuses/479bbc2592da4e6b0fcbf9be524a1ebae6b1c273","head":{"label":"OSGP:feat-improve-ioexception-handling","ref":"feat-improve-ioexception-handling","sha":"479bbc2592da4e6b0fcbf9be524a1ebae6b1c273","user":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"repo":{"id":52597910,"name":"Protocol-Adapter-IEC61850","full_name":"OSGP/Protocol-Adapter-IEC61850","owner":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OSGP/Protocol-Adapter-IEC61850","description":"Protocol adapter and device simulator for IEC61850 Protocol.","fork":false,"url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850","forks_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/forks","keys_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/teams","hooks_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/hooks","issue_events_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/issues/events{/number}","events_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/events","assignees_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/assignees{/user}","branches_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/branches{/branch}","tags_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/tags","blobs_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/git/refs{/sha}","trees_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/statuses/{sha}","languages_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/languages","stargazers_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/stargazers","contributors_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/contributors","subscribers_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/subscribers","subscription_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/subscription","commits_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/commits{/sha}","git_commits_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/git/commits{/sha}","comments_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/comments{/number}","issue_comment_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/issues/comments{/number}","contents_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/contents/{+path}","compare_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/merges","archive_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/downloads","issues_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/issues{/number}","pulls_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/pulls{/number}","milestones_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/milestones{/number}","notifications_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/labels{/name}","releases_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/releases{/id}","deployments_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/deployments","created_at":"2016-02-26T10:43:19Z","updated_at":"2016-10-26T07:14:51Z","pushed_at":"2016-10-28T08:19:52Z","git_url":"git://github.com/OSGP/Protocol-Adapter-IEC61850.git","ssh_url":"git@github.com:OSGP/Protocol-Adapter-IEC61850.git","clone_url":"https://github.com/OSGP/Protocol-Adapter-IEC61850.git","svn_url":"https://github.com/OSGP/Protocol-Adapter-IEC61850","homepage":"http://www.opensmartgridplatform.org/","size":11173,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"development"}},"base":{"label":"OSGP:development","ref":"development","sha":"d553d247e96422dc52386726cfa52b32f77c912a","user":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"repo":{"id":52597910,"name":"Protocol-Adapter-IEC61850","full_name":"OSGP/Protocol-Adapter-IEC61850","owner":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OSGP/Protocol-Adapter-IEC61850","description":"Protocol adapter and device simulator for IEC61850 Protocol.","fork":false,"url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850","forks_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/forks","keys_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/teams","hooks_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/hooks","issue_events_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/issues/events{/number}","events_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/events","assignees_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/assignees{/user}","branches_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/branches{/branch}","tags_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/tags","blobs_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/git/refs{/sha}","trees_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/statuses/{sha}","languages_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/languages","stargazers_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/stargazers","contributors_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/contributors","subscribers_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/subscribers","subscription_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/subscription","commits_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/commits{/sha}","git_commits_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/git/commits{/sha}","comments_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/comments{/number}","issue_comment_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/issues/comments{/number}","contents_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/contents/{+path}","compare_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/merges","archive_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/downloads","issues_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/issues{/number}","pulls_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/pulls{/number}","milestones_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/milestones{/number}","notifications_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/labels{/name}","releases_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/releases{/id}","deployments_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/deployments","created_at":"2016-02-26T10:43:19Z","updated_at":"2016-10-26T07:14:51Z","pushed_at":"2016-10-28T08:19:52Z","git_url":"git://github.com/OSGP/Protocol-Adapter-IEC61850.git","ssh_url":"git@github.com:OSGP/Protocol-Adapter-IEC61850.git","clone_url":"https://github.com/OSGP/Protocol-Adapter-IEC61850.git","svn_url":"https://github.com/OSGP/Protocol-Adapter-IEC61850","homepage":"http://www.opensmartgridplatform.org/","size":11173,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/pulls/57"},"html":{"href":"https://github.com/OSGP/Protocol-Adapter-IEC61850/pull/57"},"issue":{"href":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/issues/57"},"comments":{"href":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/OSGP/Protocol-Adapter-IEC61850/statuses/479bbc2592da4e6b0fcbf9be524a1ebae6b1c273"}}}}
{"actor":{"display_login":"jenkins-ip-10-4-24-184"}}