{"action":"created","comment":{"url":"https://api.github.com/repos/apache/phoenix/pulls/comments/77291213","id":77291213,"diff_hunk":"@@ -517,8 +518,13 @@ public Expression visitLeave(LikeParseNode node, List<Expression> children) thro\n                       return new ComparisonExpression(Arrays.asList(lhs,rhs), op);\n                   }\n                 }\n-            } else if (index == 0 && pattern.length() == 1) {\n-                return IsNullExpression.create(lhs, true, context.getTempPtr());\n+            } else {\n+                byte[] nullExpressionString = new byte[pattern.length()];\n+                byte[] wildcard = {StringUtil.MULTI_CHAR_LIKE};\n+                StringUtil.fill(nullExpressionString, 0, pattern.length(), wildcard, 0, 1, false);\n+                if (pattern.equals(new String (nullExpressionString))) {","path":"phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java","position":18,"original_position":18,"commit_id":"9e8caef11b1ca1971e320beb19a6212a1b653a0c","original_commit_id":"9e8caef11b1ca1971e320beb19a6212a1b653a0c","user":{"login":"twdsilva","id":5653678,"avatar_url":"https://avatars.githubusercontent.com/u/5653678?v=3","gravatar_id":"","url":"https://api.github.com/users/twdsilva","html_url":"https://github.com/twdsilva","followers_url":"https://api.github.com/users/twdsilva/followers","following_url":"https://api.github.com/users/twdsilva/following{/other_user}","gists_url":"https://api.github.com/users/twdsilva/gists{/gist_id}","starred_url":"https://api.github.com/users/twdsilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twdsilva/subscriptions","organizations_url":"https://api.github.com/users/twdsilva/orgs","repos_url":"https://api.github.com/users/twdsilva/repos","events_url":"https://api.github.com/users/twdsilva/events{/privacy}","received_events_url":"https://api.github.com/users/twdsilva/received_events","type":"User","site_admin":false},"body":"Can we just check if pattern equals StringUtil.MULTI_CHAR_LIKE here ?","created_at":"2016-09-02T04:16:50Z","updated_at":"2016-09-02T04:16:50Z","html_url":"https://github.com/apache/phoenix/pull/200#discussion_r77291213","pull_request_url":"https://api.github.com/repos/apache/phoenix/pulls/200","_links":{"self":{"href":"https://api.github.com/repos/apache/phoenix/pulls/comments/77291213"},"html":{"href":"https://github.com/apache/phoenix/pull/200#discussion_r77291213"},"pull_request":{"href":"https://api.github.com/repos/apache/phoenix/pulls/200"}}},"pull_request":{"url":"https://api.github.com/repos/apache/phoenix/pulls/200","id":82934812,"html_url":"https://github.com/apache/phoenix/pull/200","diff_url":"https://github.com/apache/phoenix/pull/200.diff","patch_url":"https://github.com/apache/phoenix/pull/200.patch","issue_url":"https://api.github.com/repos/apache/phoenix/issues/200","number":200,"state":"open","locked":false,"title":"PHOENIX-2641 Implicit wildcard in LIKE predicate search pattern","user":{"login":"kliewkliew","id":14844940,"avatar_url":"https://avatars.githubusercontent.com/u/14844940?v=3","gravatar_id":"","url":"https://api.github.com/users/kliewkliew","html_url":"https://github.com/kliewkliew","followers_url":"https://api.github.com/users/kliewkliew/followers","following_url":"https://api.github.com/users/kliewkliew/following{/other_user}","gists_url":"https://api.github.com/users/kliewkliew/gists{/gist_id}","starred_url":"https://api.github.com/users/kliewkliew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kliewkliew/subscriptions","organizations_url":"https://api.github.com/users/kliewkliew/orgs","repos_url":"https://api.github.com/users/kliewkliew/repos","events_url":"https://api.github.com/users/kliewkliew/events{/privacy}","received_events_url":"https://api.github.com/users/kliewkliew/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-26T18:44:07Z","updated_at":"2016-09-02T04:16:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5534150e6afd92ee49f08f795488105bf973318","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/phoenix/pulls/200/commits","review_comments_url":"https://api.github.com/repos/apache/phoenix/pulls/200/comments","review_comment_url":"https://api.github.com/repos/apache/phoenix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/phoenix/issues/200/comments","statuses_url":"https://api.github.com/repos/apache/phoenix/statuses/9e8caef11b1ca1971e320beb19a6212a1b653a0c","head":{"label":"kliewkliew:PHOENIX-2641","ref":"PHOENIX-2641","sha":"9e8caef11b1ca1971e320beb19a6212a1b653a0c","user":{"login":"kliewkliew","id":14844940,"avatar_url":"https://avatars.githubusercontent.com/u/14844940?v=3","gravatar_id":"","url":"https://api.github.com/users/kliewkliew","html_url":"https://github.com/kliewkliew","followers_url":"https://api.github.com/users/kliewkliew/followers","following_url":"https://api.github.com/users/kliewkliew/following{/other_user}","gists_url":"https://api.github.com/users/kliewkliew/gists{/gist_id}","starred_url":"https://api.github.com/users/kliewkliew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kliewkliew/subscriptions","organizations_url":"https://api.github.com/users/kliewkliew/orgs","repos_url":"https://api.github.com/users/kliewkliew/repos","events_url":"https://api.github.com/users/kliewkliew/events{/privacy}","received_events_url":"https://api.github.com/users/kliewkliew/received_events","type":"User","site_admin":false},"repo":{"id":66582709,"name":"phoenix","full_name":"kliewkliew/phoenix","owner":{"login":"kliewkliew","id":14844940,"avatar_url":"https://avatars.githubusercontent.com/u/14844940?v=3","gravatar_id":"","url":"https://api.github.com/users/kliewkliew","html_url":"https://github.com/kliewkliew","followers_url":"https://api.github.com/users/kliewkliew/followers","following_url":"https://api.github.com/users/kliewkliew/following{/other_user}","gists_url":"https://api.github.com/users/kliewkliew/gists{/gist_id}","starred_url":"https://api.github.com/users/kliewkliew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kliewkliew/subscriptions","organizations_url":"https://api.github.com/users/kliewkliew/orgs","repos_url":"https://api.github.com/users/kliewkliew/repos","events_url":"https://api.github.com/users/kliewkliew/events{/privacy}","received_events_url":"https://api.github.com/users/kliewkliew/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kliewkliew/phoenix","description":"Mirror of Apache Phoenix","fork":true,"url":"https://api.github.com/repos/kliewkliew/phoenix","forks_url":"https://api.github.com/repos/kliewkliew/phoenix/forks","keys_url":"https://api.github.com/repos/kliewkliew/phoenix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kliewkliew/phoenix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kliewkliew/phoenix/teams","hooks_url":"https://api.github.com/repos/kliewkliew/phoenix/hooks","issue_events_url":"https://api.github.com/repos/kliewkliew/phoenix/issues/events{/number}","events_url":"https://api.github.com/repos/kliewkliew/phoenix/events","assignees_url":"https://api.github.com/repos/kliewkliew/phoenix/assignees{/user}","branches_url":"https://api.github.com/repos/kliewkliew/phoenix/branches{/branch}","tags_url":"https://api.github.com/repos/kliewkliew/phoenix/tags","blobs_url":"https://api.github.com/repos/kliewkliew/phoenix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kliewkliew/phoenix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kliewkliew/phoenix/git/refs{/sha}","trees_url":"https://api.github.com/repos/kliewkliew/phoenix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kliewkliew/phoenix/statuses/{sha}","languages_url":"https://api.github.com/repos/kliewkliew/phoenix/languages","stargazers_url":"https://api.github.com/repos/kliewkliew/phoenix/stargazers","contributors_url":"https://api.github.com/repos/kliewkliew/phoenix/contributors","subscribers_url":"https://api.github.com/repos/kliewkliew/phoenix/subscribers","subscription_url":"https://api.github.com/repos/kliewkliew/phoenix/subscription","commits_url":"https://api.github.com/repos/kliewkliew/phoenix/commits{/sha}","git_commits_url":"https://api.github.com/repos/kliewkliew/phoenix/git/commits{/sha}","comments_url":"https://api.github.com/repos/kliewkliew/phoenix/comments{/number}","issue_comment_url":"https://api.github.com/repos/kliewkliew/phoenix/issues/comments{/number}","contents_url":"https://api.github.com/repos/kliewkliew/phoenix/contents/{+path}","compare_url":"https://api.github.com/repos/kliewkliew/phoenix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kliewkliew/phoenix/merges","archive_url":"https://api.github.com/repos/kliewkliew/phoenix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kliewkliew/phoenix/downloads","issues_url":"https://api.github.com/repos/kliewkliew/phoenix/issues{/number}","pulls_url":"https://api.github.com/repos/kliewkliew/phoenix/pulls{/number}","milestones_url":"https://api.github.com/repos/kliewkliew/phoenix/milestones{/number}","notifications_url":"https://api.github.com/repos/kliewkliew/phoenix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kliewkliew/phoenix/labels{/name}","releases_url":"https://api.github.com/repos/kliewkliew/phoenix/releases{/id}","deployments_url":"https://api.github.com/repos/kliewkliew/phoenix/deployments","created_at":"2016-08-25T18:23:03Z","updated_at":"2016-08-29T07:37:53Z","pushed_at":"2016-09-01T20:26:56Z","git_url":"git://github.com/kliewkliew/phoenix.git","ssh_url":"git@github.com:kliewkliew/phoenix.git","clone_url":"https://github.com/kliewkliew/phoenix.git","svn_url":"https://github.com/kliewkliew/phoenix","homepage":"","size":27833,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"9cc77c8104245a138a62ba251e926e14a74d8c11","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20473418,"name":"phoenix","full_name":"apache/phoenix","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/phoenix","description":"Mirror of Apache Phoenix","fork":false,"url":"https://api.github.com/repos/apache/phoenix","forks_url":"https://api.github.com/repos/apache/phoenix/forks","keys_url":"https://api.github.com/repos/apache/phoenix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/phoenix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/phoenix/teams","hooks_url":"https://api.github.com/repos/apache/phoenix/hooks","issue_events_url":"https://api.github.com/repos/apache/phoenix/issues/events{/number}","events_url":"https://api.github.com/repos/apache/phoenix/events","assignees_url":"https://api.github.com/repos/apache/phoenix/assignees{/user}","branches_url":"https://api.github.com/repos/apache/phoenix/branches{/branch}","tags_url":"https://api.github.com/repos/apache/phoenix/tags","blobs_url":"https://api.github.com/repos/apache/phoenix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/phoenix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/phoenix/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/phoenix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/phoenix/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/phoenix/languages","stargazers_url":"https://api.github.com/repos/apache/phoenix/stargazers","contributors_url":"https://api.github.com/repos/apache/phoenix/contributors","subscribers_url":"https://api.github.com/repos/apache/phoenix/subscribers","subscription_url":"https://api.github.com/repos/apache/phoenix/subscription","commits_url":"https://api.github.com/repos/apache/phoenix/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/phoenix/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/phoenix/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/phoenix/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/phoenix/contents/{+path}","compare_url":"https://api.github.com/repos/apache/phoenix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/phoenix/merges","archive_url":"https://api.github.com/repos/apache/phoenix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/phoenix/downloads","issues_url":"https://api.github.com/repos/apache/phoenix/issues{/number}","pulls_url":"https://api.github.com/repos/apache/phoenix/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/phoenix/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/phoenix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/phoenix/labels{/name}","releases_url":"https://api.github.com/repos/apache/phoenix/releases{/id}","deployments_url":"https://api.github.com/repos/apache/phoenix/deployments","created_at":"2014-06-04T07:00:08Z","updated_at":"2016-08-30T03:30:14Z","pushed_at":"2016-09-01T22:33:01Z","git_url":"git://github.com/apache/phoenix.git","ssh_url":"git@github.com:apache/phoenix.git","clone_url":"https://github.com/apache/phoenix.git","svn_url":"https://github.com/apache/phoenix","homepage":null,"size":36079,"stargazers_count":246,"watchers_count":246,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":321,"mirror_url":"git://git.apache.org/phoenix.git","open_issues_count":107,"forks":321,"open_issues":107,"watchers":246,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/phoenix/pulls/200"},"html":{"href":"https://github.com/apache/phoenix/pull/200"},"issue":{"href":"https://api.github.com/repos/apache/phoenix/issues/200"},"comments":{"href":"https://api.github.com/repos/apache/phoenix/issues/200/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/phoenix/pulls/200/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/phoenix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/phoenix/pulls/200/commits"},"statuses":{"href":"https://api.github.com/repos/apache/phoenix/statuses/9e8caef11b1ca1971e320beb19a6212a1b653a0c"}}}}
{"actor":{"display_login":"twdsilva"}}