{"action":"created","comment":{"url":"https://api.github.com/repos/coniks-sys/coniks-go/pulls/comments/87858814","pull_request_review_id":8445349,"id":87858814,"diff_hunk":"@@ -275,34 +292,15 @@ func (cc *ConsistencyChecks) verifyFulfilledPromise(uname string,\n //\n // \tIf the request is a key lookup, and\n // \t- the request is successful, then the directory should return a promise for the lookup binding.\n-func (cc *ConsistencyChecks) verifyReturnedPromise(requestType int,\n-\tresponseCode ErrorCode, df *DirectoryProof,\n+// These above checks should be performed before calling this method.\n+func (cc *ConsistencyChecks) verifyReturnedPromise(df *DirectoryProof,","path":"protocol/consistencychecks.go","position":null,"original_position":417,"commit_id":"fec6cfff02c235b88eacf8d5f2edced78a5e038f","original_commit_id":"fec6cfff02c235b88eacf8d5f2edced78a5e038f","user":{"login":"masomel","id":2728978,"avatar_url":"https://avatars.githubusercontent.com/u/2728978?v=3","gravatar_id":"","url":"https://api.github.com/users/masomel","html_url":"https://github.com/masomel","followers_url":"https://api.github.com/users/masomel/followers","following_url":"https://api.github.com/users/masomel/following{/other_user}","gists_url":"https://api.github.com/users/masomel/gists{/gist_id}","starred_url":"https://api.github.com/users/masomel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masomel/subscriptions","organizations_url":"https://api.github.com/users/masomel/orgs","repos_url":"https://api.github.com/users/masomel/repos","events_url":"https://api.github.com/users/masomel/events{/privacy}","received_events_url":"https://api.github.com/users/masomel/received_events","type":"User","site_admin":false},"body":"Update the comment: https://github.com/coniks-sys/coniks-go/blob/cgo-client/protocol/consistencychecks.go#L286 states that `verifyReturnedPromise()` operates based on the request type, which no longer is true.","created_at":"2016-11-14T18:13:46Z","updated_at":"2016-11-14T18:35:00Z","html_url":"https://github.com/coniks-sys/coniks-go/pull/74#discussion_r87858814","pull_request_url":"https://api.github.com/repos/coniks-sys/coniks-go/pulls/74","_links":{"self":{"href":"https://api.github.com/repos/coniks-sys/coniks-go/pulls/comments/87858814"},"html":{"href":"https://github.com/coniks-sys/coniks-go/pull/74#discussion_r87858814"},"pull_request":{"href":"https://api.github.com/repos/coniks-sys/coniks-go/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/coniks-sys/coniks-go/pulls/74","id":81865653,"html_url":"https://github.com/coniks-sys/coniks-go/pull/74","diff_url":"https://github.com/coniks-sys/coniks-go/pull/74.diff","patch_url":"https://github.com/coniks-sys/coniks-go/pull/74.patch","issue_url":"https://api.github.com/repos/coniks-sys/coniks-go/issues/74","number":74,"state":"open","locked":false,"title":"Add verification methods","user":{"login":"c633","id":5112602,"avatar_url":"https://avatars.githubusercontent.com/u/5112602?v=3","gravatar_id":"","url":"https://api.github.com/users/c633","html_url":"https://github.com/c633","followers_url":"https://api.github.com/users/c633/followers","following_url":"https://api.github.com/users/c633/following{/other_user}","gists_url":"https://api.github.com/users/c633/gists{/gist_id}","starred_url":"https://api.github.com/users/c633/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c633/subscriptions","organizations_url":"https://api.github.com/users/c633/orgs","repos_url":"https://api.github.com/users/c633/repos","events_url":"https://api.github.com/users/c633/events{/privacy}","received_events_url":"https://api.github.com/users/c633/received_events","type":"User","site_admin":false},"body":"To be paired w/ #86 \n- Temporarily ignore the cgo client library until we have a complete `protocol/client` library.\n","created_at":"2016-08-18T18:36:07Z","updated_at":"2016-11-14T18:35:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01c40431241670c913f098cdcc48a20aa5c6b99c","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/coniks-sys/coniks-go/milestones/1","html_url":"https://github.com/coniks-sys/coniks-go/milestones/0.1.0","labels_url":"https://api.github.com/repos/coniks-sys/coniks-go/milestones/1/labels","id":1978647,"number":1,"title":"0.1.0","description":"Initial release","creator":{"login":"masomel","id":2728978,"avatar_url":"https://avatars.githubusercontent.com/u/2728978?v=3","gravatar_id":"","url":"https://api.github.com/users/masomel","html_url":"https://github.com/masomel","followers_url":"https://api.github.com/users/masomel/followers","following_url":"https://api.github.com/users/masomel/following{/other_user}","gists_url":"https://api.github.com/users/masomel/gists{/gist_id}","starred_url":"https://api.github.com/users/masomel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masomel/subscriptions","organizations_url":"https://api.github.com/users/masomel/orgs","repos_url":"https://api.github.com/users/masomel/repos","events_url":"https://api.github.com/users/masomel/events{/privacy}","received_events_url":"https://api.github.com/users/masomel/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":14,"state":"open","created_at":"2016-09-01T20:25:40Z","updated_at":"2016-11-10T22:59:21Z","due_on":"2016-10-31T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/coniks-sys/coniks-go/pulls/74/commits","review_comments_url":"https://api.github.com/repos/coniks-sys/coniks-go/pulls/74/comments","review_comment_url":"https://api.github.com/repos/coniks-sys/coniks-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coniks-sys/coniks-go/issues/74/comments","statuses_url":"https://api.github.com/repos/coniks-sys/coniks-go/statuses/fec6cfff02c235b88eacf8d5f2edced78a5e038f","head":{"label":"coniks-sys:cgo-client","ref":"cgo-client","sha":"fec6cfff02c235b88eacf8d5f2edced78a5e038f","user":{"login":"coniks-sys","id":11236504,"avatar_url":"https://avatars.githubusercontent.com/u/11236504?v=3","gravatar_id":"","url":"https://api.github.com/users/coniks-sys","html_url":"https://github.com/coniks-sys","followers_url":"https://api.github.com/users/coniks-sys/followers","following_url":"https://api.github.com/users/coniks-sys/following{/other_user}","gists_url":"https://api.github.com/users/coniks-sys/gists{/gist_id}","starred_url":"https://api.github.com/users/coniks-sys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coniks-sys/subscriptions","organizations_url":"https://api.github.com/users/coniks-sys/orgs","repos_url":"https://api.github.com/users/coniks-sys/repos","events_url":"https://api.github.com/users/coniks-sys/events{/privacy}","received_events_url":"https://api.github.com/users/coniks-sys/received_events","type":"Organization","site_admin":false},"repo":{"id":60117979,"name":"coniks-go","full_name":"coniks-sys/coniks-go","owner":{"login":"coniks-sys","id":11236504,"avatar_url":"https://avatars.githubusercontent.com/u/11236504?v=3","gravatar_id":"","url":"https://api.github.com/users/coniks-sys","html_url":"https://github.com/coniks-sys","followers_url":"https://api.github.com/users/coniks-sys/followers","following_url":"https://api.github.com/users/coniks-sys/following{/other_user}","gists_url":"https://api.github.com/users/coniks-sys/gists{/gist_id}","starred_url":"https://api.github.com/users/coniks-sys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coniks-sys/subscriptions","organizations_url":"https://api.github.com/users/coniks-sys/orgs","repos_url":"https://api.github.com/users/coniks-sys/repos","events_url":"https://api.github.com/users/coniks-sys/events{/privacy}","received_events_url":"https://api.github.com/users/coniks-sys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coniks-sys/coniks-go","description":"A CONIKS implementation in Golang","fork":false,"url":"https://api.github.com/repos/coniks-sys/coniks-go","forks_url":"https://api.github.com/repos/coniks-sys/coniks-go/forks","keys_url":"https://api.github.com/repos/coniks-sys/coniks-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coniks-sys/coniks-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coniks-sys/coniks-go/teams","hooks_url":"https://api.github.com/repos/coniks-sys/coniks-go/hooks","issue_events_url":"https://api.github.com/repos/coniks-sys/coniks-go/issues/events{/number}","events_url":"https://api.github.com/repos/coniks-sys/coniks-go/events","assignees_url":"https://api.github.com/repos/coniks-sys/coniks-go/assignees{/user}","branches_url":"https://api.github.com/repos/coniks-sys/coniks-go/branches{/branch}","tags_url":"https://api.github.com/repos/coniks-sys/coniks-go/tags","blobs_url":"https://api.github.com/repos/coniks-sys/coniks-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coniks-sys/coniks-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coniks-sys/coniks-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/coniks-sys/coniks-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coniks-sys/coniks-go/statuses/{sha}","languages_url":"https://api.github.com/repos/coniks-sys/coniks-go/languages","stargazers_url":"https://api.github.com/repos/coniks-sys/coniks-go/stargazers","contributors_url":"https://api.github.com/repos/coniks-sys/coniks-go/contributors","subscribers_url":"https://api.github.com/repos/coniks-sys/coniks-go/subscribers","subscription_url":"https://api.github.com/repos/coniks-sys/coniks-go/subscription","commits_url":"https://api.github.com/repos/coniks-sys/coniks-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/coniks-sys/coniks-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/coniks-sys/coniks-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/coniks-sys/coniks-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/coniks-sys/coniks-go/contents/{+path}","compare_url":"https://api.github.com/repos/coniks-sys/coniks-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coniks-sys/coniks-go/merges","archive_url":"https://api.github.com/repos/coniks-sys/coniks-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coniks-sys/coniks-go/downloads","issues_url":"https://api.github.com/repos/coniks-sys/coniks-go/issues{/number}","pulls_url":"https://api.github.com/repos/coniks-sys/coniks-go/pulls{/number}","milestones_url":"https://api.github.com/repos/coniks-sys/coniks-go/milestones{/number}","notifications_url":"https://api.github.com/repos/coniks-sys/coniks-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coniks-sys/coniks-go/labels{/name}","releases_url":"https://api.github.com/repos/coniks-sys/coniks-go/releases{/id}","deployments_url":"https://api.github.com/repos/coniks-sys/coniks-go/deployments","created_at":"2016-05-31T19:37:35Z","updated_at":"2016-10-28T02:13:13Z","pushed_at":"2016-11-14T11:28:42Z","git_url":"git://github.com/coniks-sys/coniks-go.git","ssh_url":"git@github.com:coniks-sys/coniks-go.git","clone_url":"https://github.com/coniks-sys/coniks-go.git","svn_url":"https://github.com/coniks-sys/coniks-go","homepage":"http://coniks.org","size":560,"stargazers_count":14,"watchers_count":14,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":40,"forks":0,"open_issues":40,"watchers":14,"default_branch":"master"}},"base":{"label":"coniks-sys:master","ref":"master","sha":"9baff09e86d827881f167d1296c481a241581915","user":{"login":"coniks-sys","id":11236504,"avatar_url":"https://avatars.githubusercontent.com/u/11236504?v=3","gravatar_id":"","url":"https://api.github.com/users/coniks-sys","html_url":"https://github.com/coniks-sys","followers_url":"https://api.github.com/users/coniks-sys/followers","following_url":"https://api.github.com/users/coniks-sys/following{/other_user}","gists_url":"https://api.github.com/users/coniks-sys/gists{/gist_id}","starred_url":"https://api.github.com/users/coniks-sys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coniks-sys/subscriptions","organizations_url":"https://api.github.com/users/coniks-sys/orgs","repos_url":"https://api.github.com/users/coniks-sys/repos","events_url":"https://api.github.com/users/coniks-sys/events{/privacy}","received_events_url":"https://api.github.com/users/coniks-sys/received_events","type":"Organization","site_admin":false},"repo":{"id":60117979,"name":"coniks-go","full_name":"coniks-sys/coniks-go","owner":{"login":"coniks-sys","id":11236504,"avatar_url":"https://avatars.githubusercontent.com/u/11236504?v=3","gravatar_id":"","url":"https://api.github.com/users/coniks-sys","html_url":"https://github.com/coniks-sys","followers_url":"https://api.github.com/users/coniks-sys/followers","following_url":"https://api.github.com/users/coniks-sys/following{/other_user}","gists_url":"https://api.github.com/users/coniks-sys/gists{/gist_id}","starred_url":"https://api.github.com/users/coniks-sys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coniks-sys/subscriptions","organizations_url":"https://api.github.com/users/coniks-sys/orgs","repos_url":"https://api.github.com/users/coniks-sys/repos","events_url":"https://api.github.com/users/coniks-sys/events{/privacy}","received_events_url":"https://api.github.com/users/coniks-sys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coniks-sys/coniks-go","description":"A CONIKS implementation in Golang","fork":false,"url":"https://api.github.com/repos/coniks-sys/coniks-go","forks_url":"https://api.github.com/repos/coniks-sys/coniks-go/forks","keys_url":"https://api.github.com/repos/coniks-sys/coniks-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coniks-sys/coniks-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coniks-sys/coniks-go/teams","hooks_url":"https://api.github.com/repos/coniks-sys/coniks-go/hooks","issue_events_url":"https://api.github.com/repos/coniks-sys/coniks-go/issues/events{/number}","events_url":"https://api.github.com/repos/coniks-sys/coniks-go/events","assignees_url":"https://api.github.com/repos/coniks-sys/coniks-go/assignees{/user}","branches_url":"https://api.github.com/repos/coniks-sys/coniks-go/branches{/branch}","tags_url":"https://api.github.com/repos/coniks-sys/coniks-go/tags","blobs_url":"https://api.github.com/repos/coniks-sys/coniks-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coniks-sys/coniks-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coniks-sys/coniks-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/coniks-sys/coniks-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coniks-sys/coniks-go/statuses/{sha}","languages_url":"https://api.github.com/repos/coniks-sys/coniks-go/languages","stargazers_url":"https://api.github.com/repos/coniks-sys/coniks-go/stargazers","contributors_url":"https://api.github.com/repos/coniks-sys/coniks-go/contributors","subscribers_url":"https://api.github.com/repos/coniks-sys/coniks-go/subscribers","subscription_url":"https://api.github.com/repos/coniks-sys/coniks-go/subscription","commits_url":"https://api.github.com/repos/coniks-sys/coniks-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/coniks-sys/coniks-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/coniks-sys/coniks-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/coniks-sys/coniks-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/coniks-sys/coniks-go/contents/{+path}","compare_url":"https://api.github.com/repos/coniks-sys/coniks-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coniks-sys/coniks-go/merges","archive_url":"https://api.github.com/repos/coniks-sys/coniks-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coniks-sys/coniks-go/downloads","issues_url":"https://api.github.com/repos/coniks-sys/coniks-go/issues{/number}","pulls_url":"https://api.github.com/repos/coniks-sys/coniks-go/pulls{/number}","milestones_url":"https://api.github.com/repos/coniks-sys/coniks-go/milestones{/number}","notifications_url":"https://api.github.com/repos/coniks-sys/coniks-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coniks-sys/coniks-go/labels{/name}","releases_url":"https://api.github.com/repos/coniks-sys/coniks-go/releases{/id}","deployments_url":"https://api.github.com/repos/coniks-sys/coniks-go/deployments","created_at":"2016-05-31T19:37:35Z","updated_at":"2016-10-28T02:13:13Z","pushed_at":"2016-11-14T11:28:42Z","git_url":"git://github.com/coniks-sys/coniks-go.git","ssh_url":"git@github.com:coniks-sys/coniks-go.git","clone_url":"https://github.com/coniks-sys/coniks-go.git","svn_url":"https://github.com/coniks-sys/coniks-go","homepage":"http://coniks.org","size":560,"stargazers_count":14,"watchers_count":14,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":40,"forks":0,"open_issues":40,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coniks-sys/coniks-go/pulls/74"},"html":{"href":"https://github.com/coniks-sys/coniks-go/pull/74"},"issue":{"href":"https://api.github.com/repos/coniks-sys/coniks-go/issues/74"},"comments":{"href":"https://api.github.com/repos/coniks-sys/coniks-go/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/coniks-sys/coniks-go/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/coniks-sys/coniks-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coniks-sys/coniks-go/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/coniks-sys/coniks-go/statuses/fec6cfff02c235b88eacf8d5f2edced78a5e038f"}}}}
{"actor":{"display_login":"masomel"}}