{"action":"created","issue":{"url":"https://api.github.com/repos/gridcoin/Gridcoin-Research/issues/162","repository_url":"https://api.github.com/repos/gridcoin/Gridcoin-Research","labels_url":"https://api.github.com/repos/gridcoin/Gridcoin-Research/issues/162/labels{/name}","comments_url":"https://api.github.com/repos/gridcoin/Gridcoin-Research/issues/162/comments","events_url":"https://api.github.com/repos/gridcoin/Gridcoin-Research/issues/162/events","html_url":"https://github.com/gridcoin/Gridcoin-Research/pull/162","id":193307131,"number":162,"title":"Reduce GCC6/C++11 warnings and use distro LevelDB.","user":{"login":"Techbert08","id":22575168,"avatar_url":"https://avatars.githubusercontent.com/u/22575168?v=3","gravatar_id":"","url":"https://api.github.com/users/Techbert08","html_url":"https://github.com/Techbert08","followers_url":"https://api.github.com/users/Techbert08/followers","following_url":"https://api.github.com/users/Techbert08/following{/other_user}","gists_url":"https://api.github.com/users/Techbert08/gists{/gist_id}","starred_url":"https://api.github.com/users/Techbert08/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Techbert08/subscriptions","organizations_url":"https://api.github.com/users/Techbert08/orgs","repos_url":"https://api.github.com/users/Techbert08/repos","events_url":"https://api.github.com/users/Techbert08/events{/privacy}","received_events_url":"https://api.github.com/users/Techbert08/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-12-03T18:59:09Z","updated_at":"2016-12-25T08:07:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gridcoin/Gridcoin-Research/pulls/162","html_url":"https://github.com/gridcoin/Gridcoin-Research/pull/162","diff_url":"https://github.com/gridcoin/Gridcoin-Research/pull/162.diff","patch_url":"https://github.com/gridcoin/Gridcoin-Research/pull/162.patch"},"body":"I was troubleshooting a build problem and ended up fixing a lot of small C++11 issues and GCC6 warnings along the way.  I can cut this into pieces if you only want part of it.\r\n\r\n1. Updated build instructions and Unix Makefile to use the distro's LevelDB.  This works on Ubuntu 16.04LTS.\r\n2. Switched auto_ptr to boost:shared_ptr because the former is deprecated in C++11.\r\n3. Got rid of unused variables and functions caught by GCC.\r\n4. Eliminated all -Wmisleading-indentation warnings with the exception of cpid.cpp. This highlighted the very different tab/space styles throughout the code, but I attempted to match the style of the immediate context.  cpid.cpp looks like it needs an autoformatter.\r\n5. Fixed -Wliteral-suffix warnings around the 64-bit printfs so it will work with C++11.\r\n\r\nAfter doing this I noticed that my editor had made line endings consistent in main.cpp.  They were previously a mix of Windows and Unix, which confused the Git diffs.  I think the files are correct, but the diff view is funny.\r\n\r\nMy editor also stripped trailing whitespace, but I couldn't filter it because of point 5 above.  On one hand I like the improved consistency, but it makes this change unwieldy."},"comment":{"url":"https://api.github.com/repos/gridcoin/Gridcoin-Research/issues/comments/269113809","html_url":"https://github.com/gridcoin/Gridcoin-Research/pull/162#issuecomment-269113809","issue_url":"https://api.github.com/repos/gridcoin/Gridcoin-Research/issues/162","id":269113809,"user":{"login":"denravonska","id":135439,"avatar_url":"https://avatars.githubusercontent.com/u/135439?v=3","gravatar_id":"","url":"https://api.github.com/users/denravonska","html_url":"https://github.com/denravonska","followers_url":"https://api.github.com/users/denravonska/followers","following_url":"https://api.github.com/users/denravonska/following{/other_user}","gists_url":"https://api.github.com/users/denravonska/gists{/gist_id}","starred_url":"https://api.github.com/users/denravonska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denravonska/subscriptions","organizations_url":"https://api.github.com/users/denravonska/orgs","repos_url":"https://api.github.com/users/denravonska/repos","events_url":"https://api.github.com/users/denravonska/events{/privacy}","received_events_url":"https://api.github.com/users/denravonska/received_events","type":"User","site_admin":false},"created_at":"2016-12-25T08:07:14Z","updated_at":"2016-12-25T08:07:14Z","body":"What's the status of this PR?"}}
{"actor":{"display_login":"denravonska"}}