{"action":"created","issue":{"url":"https://api.github.com/repos/zlacelle/nagios_check_zfs_linux/issues/2","repository_url":"https://api.github.com/repos/zlacelle/nagios_check_zfs_linux","labels_url":"https://api.github.com/repos/zlacelle/nagios_check_zfs_linux/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/zlacelle/nagios_check_zfs_linux/issues/2/comments","events_url":"https://api.github.com/repos/zlacelle/nagios_check_zfs_linux/issues/2/events","html_url":"https://github.com/zlacelle/nagios_check_zfs_linux/issues/2","id":149806424,"number":2,"title":"Two minor issues","user":{"login":"ahinrichs","id":1071469,"avatar_url":"https://avatars.githubusercontent.com/u/1071469?v=3","gravatar_id":"","url":"https://api.github.com/users/ahinrichs","html_url":"https://github.com/ahinrichs","followers_url":"https://api.github.com/users/ahinrichs/followers","following_url":"https://api.github.com/users/ahinrichs/following{/other_user}","gists_url":"https://api.github.com/users/ahinrichs/gists{/gist_id}","starred_url":"https://api.github.com/users/ahinrichs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahinrichs/subscriptions","organizations_url":"https://api.github.com/users/ahinrichs/orgs","repos_url":"https://api.github.com/users/ahinrichs/repos","events_url":"https://api.github.com/users/ahinrichs/events{/privacy}","received_events_url":"https://api.github.com/users/ahinrichs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-04-20T15:38:46Z","updated_at":"2016-05-02T15:51:38Z","closed_at":null,"body":"Looks good so far.\r\n\r\nTwo minor issues:\r\n\r\n1. error message if sudo is missing. If sudo is not installed the script fails with \"invalid pool\"\r\n2. better locale support. The script fails if run with LANG=de_DE (e.g. comma as decimal delimiter) the script fails to parse some numbers:\r\n    \r\n```python\r\nTraceback (most recent call last):\r\n  File \"./check_zfs.py\", line 260, in <module>\r\n    sizeGB = ConvertToGB(size)\r\n  File \"./check_zfs.py\", line 74, in ConvertToGB\r\n    gigs=float(value)*1024\r\nValueError: invalid literal for float(): 8,12\r\n```"},"comment":{"url":"https://api.github.com/repos/zlacelle/nagios_check_zfs_linux/issues/comments/216274416","html_url":"https://github.com/zlacelle/nagios_check_zfs_linux/issues/2#issuecomment-216274416","issue_url":"https://api.github.com/repos/zlacelle/nagios_check_zfs_linux/issues/2","id":216274416,"user":{"login":"zlacelle","id":595543,"avatar_url":"https://avatars.githubusercontent.com/u/595543?v=3","gravatar_id":"","url":"https://api.github.com/users/zlacelle","html_url":"https://github.com/zlacelle","followers_url":"https://api.github.com/users/zlacelle/followers","following_url":"https://api.github.com/users/zlacelle/following{/other_user}","gists_url":"https://api.github.com/users/zlacelle/gists{/gist_id}","starred_url":"https://api.github.com/users/zlacelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zlacelle/subscriptions","organizations_url":"https://api.github.com/users/zlacelle/orgs","repos_url":"https://api.github.com/users/zlacelle/repos","events_url":"https://api.github.com/users/zlacelle/events{/privacy}","received_events_url":"https://api.github.com/users/zlacelle/received_events","type":"User","site_admin":false},"created_at":"2016-05-02T15:51:38Z","updated_at":"2016-05-02T15:51:38Z","body":"Actually, I rolled back this change.  I like setting specific permissions for executable sudo access in visudo (i.e. NOPASSWD:/sbin/zfs), but your euid isn't then 0 when you run check_zfs.py.  I'm not sure what the better way to solve this is."}}