{"action":"created","issue":{"url":"https://api.github.com/repos/ESMCI/cime/issues/689","repository_url":"https://api.github.com/repos/ESMCI/cime","labels_url":"https://api.github.com/repos/ESMCI/cime/issues/689/labels{/name}","comments_url":"https://api.github.com/repos/ESMCI/cime/issues/689/comments","events_url":"https://api.github.com/repos/ESMCI/cime/issues/689/events","html_url":"https://github.com/ESMCI/cime/pull/689","id":183828709,"number":689,"title":"Major refactor to handling of namelists","user":{"login":"jgfouca","id":7292036,"avatar_url":"https://avatars.githubusercontent.com/u/7292036?v=3","gravatar_id":"","url":"https://api.github.com/users/jgfouca","html_url":"https://github.com/jgfouca","followers_url":"https://api.github.com/users/jgfouca/followers","following_url":"https://api.github.com/users/jgfouca/following{/other_user}","gists_url":"https://api.github.com/users/jgfouca/gists{/gist_id}","starred_url":"https://api.github.com/users/jgfouca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgfouca/subscriptions","organizations_url":"https://api.github.com/users/jgfouca/orgs","repos_url":"https://api.github.com/users/jgfouca/repos","events_url":"https://api.github.com/users/jgfouca/events{/privacy}","received_events_url":"https://api.github.com/users/jgfouca/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ESMCI/cime/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/ESMCI/cime/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"gold2718","id":1588651,"avatar_url":"https://avatars.githubusercontent.com/u/1588651?v=3","gravatar_id":"","url":"https://api.github.com/users/gold2718","html_url":"https://github.com/gold2718","followers_url":"https://api.github.com/users/gold2718/followers","following_url":"https://api.github.com/users/gold2718/following{/other_user}","gists_url":"https://api.github.com/users/gold2718/gists{/gist_id}","starred_url":"https://api.github.com/users/gold2718/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gold2718/subscriptions","organizations_url":"https://api.github.com/users/gold2718/orgs","repos_url":"https://api.github.com/users/gold2718/repos","events_url":"https://api.github.com/users/gold2718/events{/privacy}","received_events_url":"https://api.github.com/users/gold2718/received_events","type":"User","site_admin":false},"assignees":[{"login":"gold2718","id":1588651,"avatar_url":"https://avatars.githubusercontent.com/u/1588651?v=3","gravatar_id":"","url":"https://api.github.com/users/gold2718","html_url":"https://github.com/gold2718","followers_url":"https://api.github.com/users/gold2718/followers","following_url":"https://api.github.com/users/gold2718/following{/other_user}","gists_url":"https://api.github.com/users/gold2718/gists{/gist_id}","starred_url":"https://api.github.com/users/gold2718/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gold2718/subscriptions","organizations_url":"https://api.github.com/users/gold2718/orgs","repos_url":"https://api.github.com/users/gold2718/repos","events_url":"https://api.github.com/users/gold2718/events{/privacy}","received_events_url":"https://api.github.com/users/gold2718/received_events","type":"User","site_admin":false},{"login":"jedwards4b","id":6126104,"avatar_url":"https://avatars.githubusercontent.com/u/6126104?v=3","gravatar_id":"","url":"https://api.github.com/users/jedwards4b","html_url":"https://github.com/jedwards4b","followers_url":"https://api.github.com/users/jedwards4b/followers","following_url":"https://api.github.com/users/jedwards4b/following{/other_user}","gists_url":"https://api.github.com/users/jedwards4b/gists{/gist_id}","starred_url":"https://api.github.com/users/jedwards4b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedwards4b/subscriptions","organizations_url":"https://api.github.com/users/jedwards4b/orgs","repos_url":"https://api.github.com/users/jedwards4b/repos","events_url":"https://api.github.com/users/jedwards4b/events{/privacy}","received_events_url":"https://api.github.com/users/jedwards4b/received_events","type":"User","site_admin":false},{"login":"billsacks","id":6266741,"avatar_url":"https://avatars.githubusercontent.com/u/6266741?v=3","gravatar_id":"","url":"https://api.github.com/users/billsacks","html_url":"https://github.com/billsacks","followers_url":"https://api.github.com/users/billsacks/followers","following_url":"https://api.github.com/users/billsacks/following{/other_user}","gists_url":"https://api.github.com/users/billsacks/gists{/gist_id}","starred_url":"https://api.github.com/users/billsacks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billsacks/subscriptions","organizations_url":"https://api.github.com/users/billsacks/orgs","repos_url":"https://api.github.com/users/billsacks/repos","events_url":"https://api.github.com/users/billsacks/events{/privacy}","received_events_url":"https://api.github.com/users/billsacks/received_events","type":"User","site_admin":false}],"milestone":null,"comments":18,"created_at":"2016-10-18T23:25:06Z","updated_at":"2016-10-19T20:33:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ESMCI/cime/pulls/689","html_url":"https://github.com/ESMCI/cime/pull/689","diff_url":"https://github.com/ESMCI/cime/pull/689.diff","patch_url":"https://github.com/ESMCI/cime/pull/689.patch"},"body":"1) Removes namelist creation from setup and build phases!\r\n 1.a) This reduces case.setup time on this machine from 12s to 1.5s\r\n 1.b) Reduces the number of expensive namelist creations from 4 to 2 (case.submit, case.run) for an average test case\r\n2) Split out namephase phase from test_scheduler.\r\n 2.a) Allows user to invoke this phase from command line like all the other major phases\r\n   2.a.i) New executable is case.do_namelists\r\n 2.b) Namelist phase is now done during case.submit\r\n3) Split preview_namelists into two pieces, one for directory setup (inexpensive), one to create namelists (very expensive)\r\n 3.a) dir setup needs to be done early in case.setup phase\r\n4) Remove --dryrun option from preview_namelists; it was broken and clearly not being used\r\n5) Make it easier to load environment for case by adding API to case\r\n 5.a) Also, no need to do anything if env is already loaded\r\n6) Signficant refactor to compare_namelists implementation using OrderedDicts to preserve order\r\n7) Don't use hardcoded model list in create_namelists\r\n8) Remove namelist-related complexity from test_scheduler.py\r\n9) Add some simple case.do_namelists tests to N_TestCreateTest\r\n\r\nTest suite: scripts_regression_tests\r\nTest baseline: \r\nTest namelist changes: \r\nTest status: bit for bit\r\n\r\nFixes #650\r\n\r\nUser interface changes?: Yes, new case.do_namelists tool\r\n\r\nCode review: jedwards, billsacks, gold2718\r\n"},"comment":{"url":"https://api.github.com/repos/ESMCI/cime/issues/comments/254932112","html_url":"https://github.com/ESMCI/cime/pull/689#issuecomment-254932112","issue_url":"https://api.github.com/repos/ESMCI/cime/issues/689","id":254932112,"user":{"login":"billsacks","id":6266741,"avatar_url":"https://avatars.githubusercontent.com/u/6266741?v=3","gravatar_id":"","url":"https://api.github.com/users/billsacks","html_url":"https://github.com/billsacks","followers_url":"https://api.github.com/users/billsacks/followers","following_url":"https://api.github.com/users/billsacks/following{/other_user}","gists_url":"https://api.github.com/users/billsacks/gists{/gist_id}","starred_url":"https://api.github.com/users/billsacks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billsacks/subscriptions","organizations_url":"https://api.github.com/users/billsacks/orgs","repos_url":"https://api.github.com/users/billsacks/repos","events_url":"https://api.github.com/users/billsacks/events{/privacy}","received_events_url":"https://api.github.com/users/billsacks/received_events","type":"User","site_admin":false},"created_at":"2016-10-19T20:33:16Z","updated_at":"2016-10-19T20:33:16Z","body":"> I've resolved all of @billsacks requests except for 5 since he retracted that one later.\r\n\r\nThank you; looks good. But did I really retract 5? I thought that still stands: Ideally, case.cmpgen_namelists should only appear in tests, so as to avoid confusion.\r\n\r\nOther than that, my only outstanding issue is the big one: I still feel that this should get some broader discussion. Unfortunately, that probably needs to wait a few weeks until @mvertens is back in the office; are you comfortable with this remaining open until then?"}}
{"actor":{"display_login":"billsacks"}}