{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/powerbi-models/pulls/comments/76337073","id":76337073,"diff_hunk":"@@ -297,3 +304,33 @@ export class AdvancedFilter extends Filter {\n     return filter;\n   }\n }\n+\n+export interface IDataReference {\n+  target: IFilterTarget;\n+}\n+\n+export interface IEqualsDataReference extends IDataReference {\n+  equals: string | boolean | number;\n+}\n+\n+export interface IBetweenDataReference extends IDataReference {\n+  between: (string | boolean | number)[];\n+}\n+\n+export interface IValueDataReference extends IDataReference {\n+  value: string | boolean | number;","path":"src/models.ts","position":39,"original_position":39,"commit_id":"a3b503149ca28d163df7e0bf707442092775d410","original_commit_id":"a3b503149ca28d163df7e0bf707442092775d410","user":{"login":"mattmazzola","id":2856501,"avatar_url":"https://avatars.githubusercontent.com/u/2856501?v=3","gravatar_id":"","url":"https://api.github.com/users/mattmazzola","html_url":"https://github.com/mattmazzola","followers_url":"https://api.github.com/users/mattmazzola/followers","following_url":"https://api.github.com/users/mattmazzola/following{/other_user}","gists_url":"https://api.github.com/users/mattmazzola/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmazzola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmazzola/subscriptions","organizations_url":"https://api.github.com/users/mattmazzola/orgs","repos_url":"https://api.github.com/users/mattmazzola/repos","events_url":"https://api.github.com/users/mattmazzola/events{/privacy}","received_events_url":"https://api.github.com/users/mattmazzola/received_events","type":"User","site_admin":false},"body":"I was thinking about that too.  I assume the product code which will construct this object will do something like this:\r\n\r\n```typescript\r\nconst x: IValueDataReference = {\r\n  target: {\r\n    table: \"x\",\r\n    column: \"y\"\r\n  },\r\n  value: undefined\r\n};\r\n```\r\n\r\nIf we make it optional using `value?: ....` then change it to required later it would be a breaking change and I thought it would not hurt to include it now.\r\n\r\nAre you worried it would be confusing to have it defined with undefined value?\r\n\r\n","created_at":"2016-08-25T22:30:56Z","updated_at":"2016-08-25T22:30:56Z","html_url":"https://github.com/Microsoft/powerbi-models/pull/10#discussion_r76337073","pull_request_url":"https://api.github.com/repos/Microsoft/powerbi-models/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/powerbi-models/pulls/comments/76337073"},"html":{"href":"https://github.com/Microsoft/powerbi-models/pull/10#discussion_r76337073"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/powerbi-models/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/powerbi-models/pulls/10","id":82796935,"html_url":"https://github.com/Microsoft/powerbi-models/pull/10","diff_url":"https://github.com/Microsoft/powerbi-models/pull/10.diff","patch_url":"https://github.com/Microsoft/powerbi-models/pull/10.patch","issue_url":"https://api.github.com/repos/Microsoft/powerbi-models/issues/10","number":10,"state":"open","locked":false,"title":"Add interfaces to support building object representing selection which can include dataPoints and/or regions.","user":{"login":"mattmazzola","id":2856501,"avatar_url":"https://avatars.githubusercontent.com/u/2856501?v=3","gravatar_id":"","url":"https://api.github.com/users/mattmazzola","html_url":"https://github.com/mattmazzola","followers_url":"https://api.github.com/users/mattmazzola/followers","following_url":"https://api.github.com/users/mattmazzola/following{/other_user}","gists_url":"https://api.github.com/users/mattmazzola/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmazzola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmazzola/subscriptions","organizations_url":"https://api.github.com/users/mattmazzola/orgs","repos_url":"https://api.github.com/users/mattmazzola/repos","events_url":"https://api.github.com/users/mattmazzola/events{/privacy}","received_events_url":"https://api.github.com/users/mattmazzola/received_events","type":"User","site_admin":false},"body":"Added interfaces based on latest specs from OneNote and email conversations.\r\n\r\nThis assumes there will be single event raised for both data and region selection and also supports the case where dataPoints and regions are defined in the same event.\r\n\r\n@pkwiecien Mentioned including helper classes similar to the `BasicFilter` and `AdvancedFilter` but I did not include any constructor classes yet as I'm not sure how they would offer any help to the developer over simply creating an object using the interface.  The basic and advanced filter helpers were needed because they automatically included the schema url and outputted formatted JSON.  However, these objects don't have any implicit transformations I can see.\r\n\r\n\r\n\r\n","created_at":"2016-08-25T21:31:29Z","updated_at":"2016-08-25T22:30:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0c86ca4517c12c12b0178f8bfd67ca5baac7ca5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/powerbi-models/pulls/10/commits","review_comments_url":"https://api.github.com/repos/Microsoft/powerbi-models/pulls/10/comments","review_comment_url":"https://api.github.com/repos/Microsoft/powerbi-models/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/powerbi-models/issues/10/comments","statuses_url":"https://api.github.com/repos/Microsoft/powerbi-models/statuses/a3b503149ca28d163df7e0bf707442092775d410","head":{"label":"Microsoft:dataselection","ref":"dataselection","sha":"a3b503149ca28d163df7e0bf707442092775d410","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":61827494,"name":"powerbi-models","full_name":"Microsoft/powerbi-models","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/powerbi-models","description":"Contains JavaScript & TypeScript object models for Microsoft Power BI JavaScript SDK","fork":false,"url":"https://api.github.com/repos/Microsoft/powerbi-models","forks_url":"https://api.github.com/repos/Microsoft/powerbi-models/forks","keys_url":"https://api.github.com/repos/Microsoft/powerbi-models/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/powerbi-models/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/powerbi-models/teams","hooks_url":"https://api.github.com/repos/Microsoft/powerbi-models/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/powerbi-models/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/powerbi-models/events","assignees_url":"https://api.github.com/repos/Microsoft/powerbi-models/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/powerbi-models/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/powerbi-models/tags","blobs_url":"https://api.github.com/repos/Microsoft/powerbi-models/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/powerbi-models/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/powerbi-models/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/powerbi-models/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/powerbi-models/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/powerbi-models/languages","stargazers_url":"https://api.github.com/repos/Microsoft/powerbi-models/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/powerbi-models/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/powerbi-models/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/powerbi-models/subscription","commits_url":"https://api.github.com/repos/Microsoft/powerbi-models/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/powerbi-models/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/powerbi-models/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/powerbi-models/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/powerbi-models/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/powerbi-models/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/powerbi-models/merges","archive_url":"https://api.github.com/repos/Microsoft/powerbi-models/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/powerbi-models/downloads","issues_url":"https://api.github.com/repos/Microsoft/powerbi-models/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/powerbi-models/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/powerbi-models/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/powerbi-models/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/powerbi-models/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/powerbi-models/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/powerbi-models/deployments","created_at":"2016-06-23T18:25:47Z","updated_at":"2016-07-13T21:59:14Z","pushed_at":"2016-08-25T21:31:29Z","git_url":"git://github.com/Microsoft/powerbi-models.git","ssh_url":"git@github.com:Microsoft/powerbi-models.git","clone_url":"https://github.com/Microsoft/powerbi-models.git","svn_url":"https://github.com/Microsoft/powerbi-models","homepage":"https://microsoft.github.io/powerbi-models/","size":230,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:dev","ref":"dev","sha":"e86026c26a7bddad3f879104d329e4d8ad3ef73c","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":61827494,"name":"powerbi-models","full_name":"Microsoft/powerbi-models","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/powerbi-models","description":"Contains JavaScript & TypeScript object models for Microsoft Power BI JavaScript SDK","fork":false,"url":"https://api.github.com/repos/Microsoft/powerbi-models","forks_url":"https://api.github.com/repos/Microsoft/powerbi-models/forks","keys_url":"https://api.github.com/repos/Microsoft/powerbi-models/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/powerbi-models/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/powerbi-models/teams","hooks_url":"https://api.github.com/repos/Microsoft/powerbi-models/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/powerbi-models/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/powerbi-models/events","assignees_url":"https://api.github.com/repos/Microsoft/powerbi-models/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/powerbi-models/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/powerbi-models/tags","blobs_url":"https://api.github.com/repos/Microsoft/powerbi-models/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/powerbi-models/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/powerbi-models/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/powerbi-models/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/powerbi-models/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/powerbi-models/languages","stargazers_url":"https://api.github.com/repos/Microsoft/powerbi-models/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/powerbi-models/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/powerbi-models/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/powerbi-models/subscription","commits_url":"https://api.github.com/repos/Microsoft/powerbi-models/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/powerbi-models/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/powerbi-models/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/powerbi-models/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/powerbi-models/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/powerbi-models/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/powerbi-models/merges","archive_url":"https://api.github.com/repos/Microsoft/powerbi-models/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/powerbi-models/downloads","issues_url":"https://api.github.com/repos/Microsoft/powerbi-models/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/powerbi-models/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/powerbi-models/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/powerbi-models/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/powerbi-models/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/powerbi-models/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/powerbi-models/deployments","created_at":"2016-06-23T18:25:47Z","updated_at":"2016-07-13T21:59:14Z","pushed_at":"2016-08-25T21:31:29Z","git_url":"git://github.com/Microsoft/powerbi-models.git","ssh_url":"git@github.com:Microsoft/powerbi-models.git","clone_url":"https://github.com/Microsoft/powerbi-models.git","svn_url":"https://github.com/Microsoft/powerbi-models","homepage":"https://microsoft.github.io/powerbi-models/","size":230,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/powerbi-models/pulls/10"},"html":{"href":"https://github.com/Microsoft/powerbi-models/pull/10"},"issue":{"href":"https://api.github.com/repos/Microsoft/powerbi-models/issues/10"},"comments":{"href":"https://api.github.com/repos/Microsoft/powerbi-models/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/powerbi-models/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/powerbi-models/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/powerbi-models/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/powerbi-models/statuses/a3b503149ca28d163df7e0bf707442092775d410"}}}}
{"actor":{"display_login":"mattmazzola"}}