{"action":"created","issue":{"url":"https://api.github.com/repos/hercules-390/hyperion/issues/150","repository_url":"https://api.github.com/repos/hercules-390/hyperion","labels_url":"https://api.github.com/repos/hercules-390/hyperion/issues/150/labels{/name}","comments_url":"https://api.github.com/repos/hercules-390/hyperion/issues/150/comments","events_url":"https://api.github.com/repos/hercules-390/hyperion/issues/150/events","html_url":"https://github.com/hercules-390/hyperion/issues/150","id":173797693,"number":150,"title":"\"extgui\" not declared in logmsg.c","user":{"login":"PeterCoghlan","id":11341184,"avatar_url":"https://avatars.githubusercontent.com/u/11341184?v=3","gravatar_id":"","url":"https://api.github.com/users/PeterCoghlan","html_url":"https://github.com/PeterCoghlan","followers_url":"https://api.github.com/users/PeterCoghlan/followers","following_url":"https://api.github.com/users/PeterCoghlan/following{/other_user}","gists_url":"https://api.github.com/users/PeterCoghlan/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterCoghlan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterCoghlan/subscriptions","organizations_url":"https://api.github.com/users/PeterCoghlan/orgs","repos_url":"https://api.github.com/users/PeterCoghlan/repos","events_url":"https://api.github.com/users/PeterCoghlan/events{/privacy}","received_events_url":"https://api.github.com/users/PeterCoghlan/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/hercules-390/hyperion/labels/BUG","name":"BUG","color":"FF3300"},{"url":"https://api.github.com/repos/hercules-390/hyperion/labels/Question","name":"Question","color":"00B85C"},{"url":"https://api.github.com/repos/hercules-390/hyperion/labels/Researching...","name":"Researching...","color":"FFCC99"}],"state":"open","locked":false,"assignee":{"login":"Fish-Git","id":1486786,"avatar_url":"https://avatars.githubusercontent.com/u/1486786?v=3","gravatar_id":"","url":"https://api.github.com/users/Fish-Git","html_url":"https://github.com/Fish-Git","followers_url":"https://api.github.com/users/Fish-Git/followers","following_url":"https://api.github.com/users/Fish-Git/following{/other_user}","gists_url":"https://api.github.com/users/Fish-Git/gists{/gist_id}","starred_url":"https://api.github.com/users/Fish-Git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fish-Git/subscriptions","organizations_url":"https://api.github.com/users/Fish-Git/orgs","repos_url":"https://api.github.com/users/Fish-Git/repos","events_url":"https://api.github.com/users/Fish-Git/events{/privacy}","received_events_url":"https://api.github.com/users/Fish-Git/received_events","type":"User","site_admin":false},"assignees":[{"login":"Fish-Git","id":1486786,"avatar_url":"https://avatars.githubusercontent.com/u/1486786?v=3","gravatar_id":"","url":"https://api.github.com/users/Fish-Git","html_url":"https://github.com/Fish-Git","followers_url":"https://api.github.com/users/Fish-Git/followers","following_url":"https://api.github.com/users/Fish-Git/following{/other_user}","gists_url":"https://api.github.com/users/Fish-Git/gists{/gist_id}","starred_url":"https://api.github.com/users/Fish-Git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fish-Git/subscriptions","organizations_url":"https://api.github.com/users/Fish-Git/orgs","repos_url":"https://api.github.com/users/Fish-Git/repos","events_url":"https://api.github.com/users/Fish-Git/events{/privacy}","received_events_url":"https://api.github.com/users/Fish-Git/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-08-29T15:11:13Z","updated_at":"2016-09-02T14:42:35Z","closed_at":null,"body":"I get the following error when compiling logmsg.c without EXTERNALGUI being defined:\r\n\r\n       if (sysblk.shutdown && !extgui)\r\n................................^\r\n%CC-E-UNDECLARED, In this statement, \"extgui\" is not declared at line number 464 in file logmsg.c\r\n\r\nextgui appears in lots of other code without any issues.  It appears that use of it should be protected by #ifdef EXTERNALGUI or similar.\r\n"},"comment":{"url":"https://api.github.com/repos/hercules-390/hyperion/issues/comments/244394504","html_url":"https://github.com/hercules-390/hyperion/issues/150#issuecomment-244394504","issue_url":"https://api.github.com/repos/hercules-390/hyperion/issues/150","id":244394504,"user":{"login":"PeterCoghlan","id":11341184,"avatar_url":"https://avatars.githubusercontent.com/u/11341184?v=3","gravatar_id":"","url":"https://api.github.com/users/PeterCoghlan","html_url":"https://github.com/PeterCoghlan","followers_url":"https://api.github.com/users/PeterCoghlan/followers","following_url":"https://api.github.com/users/PeterCoghlan/following{/other_user}","gists_url":"https://api.github.com/users/PeterCoghlan/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterCoghlan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterCoghlan/subscriptions","organizations_url":"https://api.github.com/users/PeterCoghlan/orgs","repos_url":"https://api.github.com/users/PeterCoghlan/repos","events_url":"https://api.github.com/users/PeterCoghlan/events{/privacy}","received_events_url":"https://api.github.com/users/PeterCoghlan/received_events","type":"User","site_admin":false},"created_at":"2016-09-02T14:42:35Z","updated_at":"2016-09-02T14:42:35Z","body":"I can confirm that the problem I reported goes away when I compile with EXTERNALGUI defined.  I've looked briefly through the code that gets excluded when EXTERNALGUI is not defined and I didn't spot anything likely to cause difficulties if it is included all the time.  I guess any lurking problems would have been found by now anyway as everyone else has been compiling that way for some time."}}
{"actor":{"display_login":"PeterCoghlan"}}