{"action":"created","issue":{"url":"https://api.github.com/repos/google/material-design-lite/issues/4312","repository_url":"https://api.github.com/repos/google/material-design-lite","labels_url":"https://api.github.com/repos/google/material-design-lite/issues/4312/labels{/name}","comments_url":"https://api.github.com/repos/google/material-design-lite/issues/4312/comments","events_url":"https://api.github.com/repos/google/material-design-lite/issues/4312/events","html_url":"https://github.com/google/material-design-lite/issues/4312","id":151693707,"number":4312,"title":"mdl-layout__drawer-button","user":{"login":"neechange","id":1192911,"avatar_url":"https://avatars.githubusercontent.com/u/1192911?v=3","gravatar_id":"","url":"https://api.github.com/users/neechange","html_url":"https://github.com/neechange","followers_url":"https://api.github.com/users/neechange/followers","following_url":"https://api.github.com/users/neechange/following{/other_user}","gists_url":"https://api.github.com/users/neechange/gists{/gist_id}","starred_url":"https://api.github.com/users/neechange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neechange/subscriptions","organizations_url":"https://api.github.com/users/neechange/orgs","repos_url":"https://api.github.com/users/neechange/repos","events_url":"https://api.github.com/users/neechange/events{/privacy}","received_events_url":"https://api.github.com/users/neechange/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-04-28T17:01:25Z","updated_at":"2016-04-29T06:05:34Z","closed_at":null,"body":"button位置偏上？\r\nline-height:50px\r\n? 56px\r\n 48px||56px||64px\r\n\r\n\r\nmargin:10px 12px;\r\n48+10+10=68  header 64px\r\nmargin:10px ?\r\n8px"},"comment":{"url":"https://api.github.com/repos/google/material-design-lite/issues/comments/215633573","html_url":"https://github.com/google/material-design-lite/issues/4312#issuecomment-215633573","issue_url":"https://api.github.com/repos/google/material-design-lite/issues/4312","id":215633573,"user":{"login":"rejhgadellaa","id":4703109,"avatar_url":"https://avatars.githubusercontent.com/u/4703109?v=3","gravatar_id":"","url":"https://api.github.com/users/rejhgadellaa","html_url":"https://github.com/rejhgadellaa","followers_url":"https://api.github.com/users/rejhgadellaa/followers","following_url":"https://api.github.com/users/rejhgadellaa/following{/other_user}","gists_url":"https://api.github.com/users/rejhgadellaa/gists{/gist_id}","starred_url":"https://api.github.com/users/rejhgadellaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rejhgadellaa/subscriptions","organizations_url":"https://api.github.com/users/rejhgadellaa/orgs","repos_url":"https://api.github.com/users/rejhgadellaa/repos","events_url":"https://api.github.com/users/rejhgadellaa/events{/privacy}","received_events_url":"https://api.github.com/users/rejhgadellaa/received_events","type":"User","site_admin":false},"created_at":"2016-04-29T06:05:34Z","updated_at":"2016-04-29T06:05:34Z","body":"Is he referring to the same issue as described in #2017 ?\r\n\r\nI think he's saying (with only calculations :P) that the height of the 'mdl-layout__drawer-button' is exceeding that of the toolbar (64px) because top/bottom margins is 10 instead of 8:\r\n\r\nRight now it's \r\n`margin: 10px 12px 10px 12px;`\r\n`width:48px; height:48px;`\r\n\r\n10px + 48px + 10px = 68px height\r\n\r\nIt should be:\r\n`margin: 8px 12px 8px 12px;`\r\n`width:48px; height:48px;`\r\n\r\n8px + 48px + 8px = 64px height - which it should be.\r\n\r\nBUT, and that's where the above mentioned issue comes into play, this will cause the menu icon to move up and be misaligned. This happens on mobile size (`margin:4px;`, so on all sides). \r\n\r\nOn a side note: the 'mdl-layout__drawer-button' (or its icon) also misses :hover and :active highlights like the (mdl-button) action icons do. It's a button so it should behave like one, right?\r\n\r\nShort story: the 'mdl-layout__drawer-button' is a bit messed up and needs fixing :)"}}