{"action":"closed","number":4285,"pull_request":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/4285","id":60504886,"html_url":"https://github.com/Sylius/Sylius/pull/4285","diff_url":"https://github.com/Sylius/Sylius/pull/4285.diff","patch_url":"https://github.com/Sylius/Sylius/pull/4285.patch","issue_url":"https://api.github.com/repos/Sylius/Sylius/issues/4285","number":4285,"state":"closed","locked":false,"title":"[Core][ProductAccessor] Use option code instead of name","user":{"login":"okwinza","id":108925,"avatar_url":"https://avatars.githubusercontent.com/u/108925?v=3","gravatar_id":"","url":"https://api.github.com/users/okwinza","html_url":"https://github.com/okwinza","followers_url":"https://api.github.com/users/okwinza/followers","following_url":"https://api.github.com/users/okwinza/following{/other_user}","gists_url":"https://api.github.com/users/okwinza/gists{/gist_id}","starred_url":"https://api.github.com/users/okwinza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okwinza/subscriptions","organizations_url":"https://api.github.com/users/okwinza/orgs","repos_url":"https://api.github.com/users/okwinza/repos","events_url":"https://api.github.com/users/okwinza/events{/privacy}","received_events_url":"https://api.github.com/users/okwinza/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | yes\r\n| New feature?  | no|yes\r\n| BC breaks?    | no|yes\r\n| Deprecations? | no|yes\r\n| License       | MIT\r\n\r\nAt this moment this class only used in SearchBundle and it is wrong to match option by presentation since it might contain non-latin characters that cannot be used in YAML. \r\n\r\nIt is better to use code field in this case.\r\n\r\nThis PR is based on #4237","created_at":"2016-02-24T12:59:16Z","updated_at":"2016-03-01T14:12:20Z","closed_at":"2016-03-01T14:12:20Z","merged_at":null,"merge_commit_sha":"94c7ced931b723f76b32e4afe5723e37bbf653e7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Sylius/Sylius/pulls/4285/commits","review_comments_url":"https://api.github.com/repos/Sylius/Sylius/pulls/4285/comments","review_comment_url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sylius/Sylius/issues/4285/comments","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/10a1acd307569041e08a57c1fcd5fced08153379","head":{"label":"okwinza:fix-product-accessor","ref":"fix-product-accessor","sha":"10a1acd307569041e08a57c1fcd5fced08153379","user":{"login":"okwinza","id":108925,"avatar_url":"https://avatars.githubusercontent.com/u/108925?v=3","gravatar_id":"","url":"https://api.github.com/users/okwinza","html_url":"https://github.com/okwinza","followers_url":"https://api.github.com/users/okwinza/followers","following_url":"https://api.github.com/users/okwinza/following{/other_user}","gists_url":"https://api.github.com/users/okwinza/gists{/gist_id}","starred_url":"https://api.github.com/users/okwinza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okwinza/subscriptions","organizations_url":"https://api.github.com/users/okwinza/orgs","repos_url":"https://api.github.com/users/okwinza/repos","events_url":"https://api.github.com/users/okwinza/events{/privacy}","received_events_url":"https://api.github.com/users/okwinza/received_events","type":"User","site_admin":false},"repo":{"id":50344222,"name":"Sylius","full_name":"okwinza/Sylius","owner":{"login":"okwinza","id":108925,"avatar_url":"https://avatars.githubusercontent.com/u/108925?v=3","gravatar_id":"","url":"https://api.github.com/users/okwinza","html_url":"https://github.com/okwinza","followers_url":"https://api.github.com/users/okwinza/followers","following_url":"https://api.github.com/users/okwinza/following{/other_user}","gists_url":"https://api.github.com/users/okwinza/gists{/gist_id}","starred_url":"https://api.github.com/users/okwinza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okwinza/subscriptions","organizations_url":"https://api.github.com/users/okwinza/orgs","repos_url":"https://api.github.com/users/okwinza/repos","events_url":"https://api.github.com/users/okwinza/events{/privacy}","received_events_url":"https://api.github.com/users/okwinza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/okwinza/Sylius","description":"Component-based and format-agnostic (JSON/XML/HTML) eCommerce framework on top of Symfony.","fork":true,"url":"https://api.github.com/repos/okwinza/Sylius","forks_url":"https://api.github.com/repos/okwinza/Sylius/forks","keys_url":"https://api.github.com/repos/okwinza/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/okwinza/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/okwinza/Sylius/teams","hooks_url":"https://api.github.com/repos/okwinza/Sylius/hooks","issue_events_url":"https://api.github.com/repos/okwinza/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/okwinza/Sylius/events","assignees_url":"https://api.github.com/repos/okwinza/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/okwinza/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/okwinza/Sylius/tags","blobs_url":"https://api.github.com/repos/okwinza/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/okwinza/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/okwinza/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/okwinza/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/okwinza/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/okwinza/Sylius/languages","stargazers_url":"https://api.github.com/repos/okwinza/Sylius/stargazers","contributors_url":"https://api.github.com/repos/okwinza/Sylius/contributors","subscribers_url":"https://api.github.com/repos/okwinza/Sylius/subscribers","subscription_url":"https://api.github.com/repos/okwinza/Sylius/subscription","commits_url":"https://api.github.com/repos/okwinza/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/okwinza/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/okwinza/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/okwinza/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/okwinza/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/okwinza/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/okwinza/Sylius/merges","archive_url":"https://api.github.com/repos/okwinza/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/okwinza/Sylius/downloads","issues_url":"https://api.github.com/repos/okwinza/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/okwinza/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/okwinza/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/okwinza/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/okwinza/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/okwinza/Sylius/releases{/id}","deployments_url":"https://api.github.com/repos/okwinza/Sylius/deployments","created_at":"2016-01-25T10:44:52Z","updated_at":"2016-01-25T10:44:59Z","pushed_at":"2016-02-29T22:21:59Z","git_url":"git://github.com/okwinza/Sylius.git","ssh_url":"git@github.com:okwinza/Sylius.git","clone_url":"https://github.com/okwinza/Sylius.git","svn_url":"https://github.com/okwinza/Sylius","homepage":"http://Sylius.org","size":26701,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Sylius:master","ref":"master","sha":"081bd3719c7bd6e7f9d70bfbf58b9396f71aaa13","user":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"repo":{"id":2717549,"name":"Sylius","full_name":"Sylius/Sylius","owner":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sylius/Sylius","description":"eCommerce PHP framework built on top of Symfony with component-based architecture and format-agnostic rendering. (HTML/JSON/XML)","fork":false,"url":"https://api.github.com/repos/Sylius/Sylius","forks_url":"https://api.github.com/repos/Sylius/Sylius/forks","keys_url":"https://api.github.com/repos/Sylius/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sylius/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sylius/Sylius/teams","hooks_url":"https://api.github.com/repos/Sylius/Sylius/hooks","issue_events_url":"https://api.github.com/repos/Sylius/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/Sylius/Sylius/events","assignees_url":"https://api.github.com/repos/Sylius/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/Sylius/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/Sylius/Sylius/tags","blobs_url":"https://api.github.com/repos/Sylius/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sylius/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sylius/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sylius/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/Sylius/Sylius/languages","stargazers_url":"https://api.github.com/repos/Sylius/Sylius/stargazers","contributors_url":"https://api.github.com/repos/Sylius/Sylius/contributors","subscribers_url":"https://api.github.com/repos/Sylius/Sylius/subscribers","subscription_url":"https://api.github.com/repos/Sylius/Sylius/subscription","commits_url":"https://api.github.com/repos/Sylius/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sylius/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sylius/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sylius/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sylius/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/Sylius/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sylius/Sylius/merges","archive_url":"https://api.github.com/repos/Sylius/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sylius/Sylius/downloads","issues_url":"https://api.github.com/repos/Sylius/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/Sylius/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/Sylius/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/Sylius/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sylius/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/Sylius/Sylius/releases{/id}","deployments_url":"https://api.github.com/repos/Sylius/Sylius/deployments","created_at":"2011-11-05T22:05:52Z","updated_at":"2016-02-29T04:01:46Z","pushed_at":"2016-03-01T14:12:07Z","git_url":"git://github.com/Sylius/Sylius.git","ssh_url":"git@github.com:Sylius/Sylius.git","clone_url":"https://github.com/Sylius/Sylius.git","svn_url":"https://github.com/Sylius/Sylius","homepage":"http://Sylius.org","size":58865,"stargazers_count":2190,"watchers_count":2190,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":797,"mirror_url":null,"open_issues_count":565,"forks":797,"open_issues":565,"watchers":2190,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/4285"},"html":{"href":"https://github.com/Sylius/Sylius/pull/4285"},"issue":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/4285"},"comments":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/4285/comments"},"review_comments":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/4285/comments"},"review_comment":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/4285/commits"},"statuses":{"href":"https://api.github.com/repos/Sylius/Sylius/statuses/10a1acd307569041e08a57c1fcd5fced08153379"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}