{"action":"created","comment":{"url":"https://api.github.com/repos/ros-planning/moveit/pulls/comments/80069333","id":80069333,"diff_hunk":"@@ -404,6 +399,10 @@ void RobotStateDisplay::onDisable()\n void RobotStateDisplay::update(float wall_dt, float ros_dt)\n {\n   Display::update(wall_dt, ros_dt);\n+\n+  if (load_robot_model_)\n+    loadRobotModel();\n+","path":"moveit_ros/visualization/robot_state_rviz_plugin/src/robot_state_display.cpp","position":65,"original_position":65,"commit_id":"c1e70210feffb5ae61a623f32b926a8e9081a2fb","original_commit_id":"c1e70210feffb5ae61a623f32b926a8e9081a2fb","user":{"login":"davetcoleman","id":561060,"avatar_url":"https://avatars.githubusercontent.com/u/561060?v=3","gravatar_id":"","url":"https://api.github.com/users/davetcoleman","html_url":"https://github.com/davetcoleman","followers_url":"https://api.github.com/users/davetcoleman/followers","following_url":"https://api.github.com/users/davetcoleman/following{/other_user}","gists_url":"https://api.github.com/users/davetcoleman/gists{/gist_id}","starred_url":"https://api.github.com/users/davetcoleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davetcoleman/subscriptions","organizations_url":"https://api.github.com/users/davetcoleman/orgs","repos_url":"https://api.github.com/users/davetcoleman/repos","events_url":"https://api.github.com/users/davetcoleman/events{/privacy}","received_events_url":"https://api.github.com/users/davetcoleman/received_events","type":"User","site_admin":false},"body":"+1, I have an Rviz config file that loads **11** URDFs for different displays, and its quite slow showing the GUI","created_at":"2016-09-22T15:35:03Z","updated_at":"2016-09-22T15:36:33Z","html_url":"https://github.com/ros-planning/moveit/pull/239#discussion_r80069333","pull_request_url":"https://api.github.com/repos/ros-planning/moveit/pulls/239","_links":{"self":{"href":"https://api.github.com/repos/ros-planning/moveit/pulls/comments/80069333"},"html":{"href":"https://github.com/ros-planning/moveit/pull/239#discussion_r80069333"},"pull_request":{"href":"https://api.github.com/repos/ros-planning/moveit/pulls/239"}}},"pull_request":{"url":"https://api.github.com/repos/ros-planning/moveit/pulls/239","id":86291573,"html_url":"https://github.com/ros-planning/moveit/pull/239","diff_url":"https://github.com/ros-planning/moveit/pull/239.diff","patch_url":"https://github.com/ros-planning/moveit/pull/239.patch","issue_url":"https://api.github.com/repos/ros-planning/moveit/issues/239","number":239,"state":"open","locked":false,"title":"fix error feedback on undefined robot model in rviz","user":{"login":"rhaschke","id":5376030,"avatar_url":"https://avatars.githubusercontent.com/u/5376030?v=3","gravatar_id":"","url":"https://api.github.com/users/rhaschke","html_url":"https://github.com/rhaschke","followers_url":"https://api.github.com/users/rhaschke/followers","following_url":"https://api.github.com/users/rhaschke/following{/other_user}","gists_url":"https://api.github.com/users/rhaschke/gists{/gist_id}","starred_url":"https://api.github.com/users/rhaschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhaschke/subscriptions","organizations_url":"https://api.github.com/users/rhaschke/orgs","repos_url":"https://api.github.com/users/rhaschke/repos","events_url":"https://api.github.com/users/rhaschke/events{/privacy}","received_events_url":"https://api.github.com/users/rhaschke/received_events","type":"User","site_admin":false},"body":"This is an alternative attempt for  #234, not relying on a certain number of `Display::onEnable()` calls, but relying on the fact that `Display::update()` is first called after loading of all rviz properties. In any case, this is not ABI-compatible as well, because it introduces a new class variable. Hence, I propose not to back-port.\r\nFixed the issue for both, `RobotStateDisplay` and `TrajectoryDisplay`. Added rviz error feedback for `TrajectoryDisplay`.\r\n\r\nAlso fixed a seg-fault in `TrajectoryDisplay`, when switching from undefined to defined robot_description.\r\nIn that case, due to multiple attempts to load (and reset) the robot model, there were pending Qt events carrying pointers to already destroyed objects...","created_at":"2016-09-22T07:45:38Z","updated_at":"2016-09-22T15:36:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"066620350f192cd976ca7ca8c764199943047de6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ros-planning/moveit/pulls/239/commits","review_comments_url":"https://api.github.com/repos/ros-planning/moveit/pulls/239/comments","review_comment_url":"https://api.github.com/repos/ros-planning/moveit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros-planning/moveit/issues/239/comments","statuses_url":"https://api.github.com/repos/ros-planning/moveit/statuses/c1e70210feffb5ae61a623f32b926a8e9081a2fb","head":{"label":"rhaschke:fix-warning-feedback","ref":"fix-warning-feedback","sha":"c1e70210feffb5ae61a623f32b926a8e9081a2fb","user":{"login":"rhaschke","id":5376030,"avatar_url":"https://avatars.githubusercontent.com/u/5376030?v=3","gravatar_id":"","url":"https://api.github.com/users/rhaschke","html_url":"https://github.com/rhaschke","followers_url":"https://api.github.com/users/rhaschke/followers","following_url":"https://api.github.com/users/rhaschke/following{/other_user}","gists_url":"https://api.github.com/users/rhaschke/gists{/gist_id}","starred_url":"https://api.github.com/users/rhaschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhaschke/subscriptions","organizations_url":"https://api.github.com/users/rhaschke/orgs","repos_url":"https://api.github.com/users/rhaschke/repos","events_url":"https://api.github.com/users/rhaschke/events{/privacy}","received_events_url":"https://api.github.com/users/rhaschke/received_events","type":"User","site_admin":false},"repo":{"id":65847299,"name":"moveit","full_name":"rhaschke/moveit","owner":{"login":"rhaschke","id":5376030,"avatar_url":"https://avatars.githubusercontent.com/u/5376030?v=3","gravatar_id":"","url":"https://api.github.com/users/rhaschke","html_url":"https://github.com/rhaschke","followers_url":"https://api.github.com/users/rhaschke/followers","following_url":"https://api.github.com/users/rhaschke/following{/other_user}","gists_url":"https://api.github.com/users/rhaschke/gists{/gist_id}","starred_url":"https://api.github.com/users/rhaschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhaschke/subscriptions","organizations_url":"https://api.github.com/users/rhaschke/orgs","repos_url":"https://api.github.com/users/rhaschke/repos","events_url":"https://api.github.com/users/rhaschke/events{/privacy}","received_events_url":"https://api.github.com/users/rhaschke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhaschke/moveit","description":"The MoveIt! motion planning framework","fork":true,"url":"https://api.github.com/repos/rhaschke/moveit","forks_url":"https://api.github.com/repos/rhaschke/moveit/forks","keys_url":"https://api.github.com/repos/rhaschke/moveit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhaschke/moveit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhaschke/moveit/teams","hooks_url":"https://api.github.com/repos/rhaschke/moveit/hooks","issue_events_url":"https://api.github.com/repos/rhaschke/moveit/issues/events{/number}","events_url":"https://api.github.com/repos/rhaschke/moveit/events","assignees_url":"https://api.github.com/repos/rhaschke/moveit/assignees{/user}","branches_url":"https://api.github.com/repos/rhaschke/moveit/branches{/branch}","tags_url":"https://api.github.com/repos/rhaschke/moveit/tags","blobs_url":"https://api.github.com/repos/rhaschke/moveit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhaschke/moveit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhaschke/moveit/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhaschke/moveit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhaschke/moveit/statuses/{sha}","languages_url":"https://api.github.com/repos/rhaschke/moveit/languages","stargazers_url":"https://api.github.com/repos/rhaschke/moveit/stargazers","contributors_url":"https://api.github.com/repos/rhaschke/moveit/contributors","subscribers_url":"https://api.github.com/repos/rhaschke/moveit/subscribers","subscription_url":"https://api.github.com/repos/rhaschke/moveit/subscription","commits_url":"https://api.github.com/repos/rhaschke/moveit/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhaschke/moveit/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhaschke/moveit/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhaschke/moveit/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhaschke/moveit/contents/{+path}","compare_url":"https://api.github.com/repos/rhaschke/moveit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhaschke/moveit/merges","archive_url":"https://api.github.com/repos/rhaschke/moveit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhaschke/moveit/downloads","issues_url":"https://api.github.com/repos/rhaschke/moveit/issues{/number}","pulls_url":"https://api.github.com/repos/rhaschke/moveit/pulls{/number}","milestones_url":"https://api.github.com/repos/rhaschke/moveit/milestones{/number}","notifications_url":"https://api.github.com/repos/rhaschke/moveit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhaschke/moveit/labels{/name}","releases_url":"https://api.github.com/repos/rhaschke/moveit/releases{/id}","deployments_url":"https://api.github.com/repos/rhaschke/moveit/deployments","created_at":"2016-08-16T19:22:03Z","updated_at":"2016-08-16T19:22:07Z","pushed_at":"2016-09-22T10:26:39Z","git_url":"git://github.com/rhaschke/moveit.git","ssh_url":"git@github.com:rhaschke/moveit.git","clone_url":"https://github.com/rhaschke/moveit.git","svn_url":"https://github.com/rhaschke/moveit","homepage":"http://moveit.ros.org/","size":51132,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"kinetic-devel"}},"base":{"label":"ros-planning:kinetic-devel","ref":"kinetic-devel","sha":"fd5073d524a868855a306a03b4761396a9a3a6be","user":{"login":"ros-planning","id":2328631,"avatar_url":"https://avatars.githubusercontent.com/u/2328631?v=3","gravatar_id":"","url":"https://api.github.com/users/ros-planning","html_url":"https://github.com/ros-planning","followers_url":"https://api.github.com/users/ros-planning/followers","following_url":"https://api.github.com/users/ros-planning/following{/other_user}","gists_url":"https://api.github.com/users/ros-planning/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-planning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-planning/subscriptions","organizations_url":"https://api.github.com/users/ros-planning/orgs","repos_url":"https://api.github.com/users/ros-planning/repos","events_url":"https://api.github.com/users/ros-planning/events{/privacy}","received_events_url":"https://api.github.com/users/ros-planning/received_events","type":"Organization","site_admin":false},"repo":{"id":64340188,"name":"moveit","full_name":"ros-planning/moveit","owner":{"login":"ros-planning","id":2328631,"avatar_url":"https://avatars.githubusercontent.com/u/2328631?v=3","gravatar_id":"","url":"https://api.github.com/users/ros-planning","html_url":"https://github.com/ros-planning","followers_url":"https://api.github.com/users/ros-planning/followers","following_url":"https://api.github.com/users/ros-planning/following{/other_user}","gists_url":"https://api.github.com/users/ros-planning/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-planning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-planning/subscriptions","organizations_url":"https://api.github.com/users/ros-planning/orgs","repos_url":"https://api.github.com/users/ros-planning/repos","events_url":"https://api.github.com/users/ros-planning/events{/privacy}","received_events_url":"https://api.github.com/users/ros-planning/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros-planning/moveit","description":"The MoveIt! motion planning framework","fork":false,"url":"https://api.github.com/repos/ros-planning/moveit","forks_url":"https://api.github.com/repos/ros-planning/moveit/forks","keys_url":"https://api.github.com/repos/ros-planning/moveit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros-planning/moveit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros-planning/moveit/teams","hooks_url":"https://api.github.com/repos/ros-planning/moveit/hooks","issue_events_url":"https://api.github.com/repos/ros-planning/moveit/issues/events{/number}","events_url":"https://api.github.com/repos/ros-planning/moveit/events","assignees_url":"https://api.github.com/repos/ros-planning/moveit/assignees{/user}","branches_url":"https://api.github.com/repos/ros-planning/moveit/branches{/branch}","tags_url":"https://api.github.com/repos/ros-planning/moveit/tags","blobs_url":"https://api.github.com/repos/ros-planning/moveit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros-planning/moveit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros-planning/moveit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros-planning/moveit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros-planning/moveit/statuses/{sha}","languages_url":"https://api.github.com/repos/ros-planning/moveit/languages","stargazers_url":"https://api.github.com/repos/ros-planning/moveit/stargazers","contributors_url":"https://api.github.com/repos/ros-planning/moveit/contributors","subscribers_url":"https://api.github.com/repos/ros-planning/moveit/subscribers","subscription_url":"https://api.github.com/repos/ros-planning/moveit/subscription","commits_url":"https://api.github.com/repos/ros-planning/moveit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros-planning/moveit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros-planning/moveit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros-planning/moveit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros-planning/moveit/contents/{+path}","compare_url":"https://api.github.com/repos/ros-planning/moveit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros-planning/moveit/merges","archive_url":"https://api.github.com/repos/ros-planning/moveit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros-planning/moveit/downloads","issues_url":"https://api.github.com/repos/ros-planning/moveit/issues{/number}","pulls_url":"https://api.github.com/repos/ros-planning/moveit/pulls{/number}","milestones_url":"https://api.github.com/repos/ros-planning/moveit/milestones{/number}","notifications_url":"https://api.github.com/repos/ros-planning/moveit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros-planning/moveit/labels{/name}","releases_url":"https://api.github.com/repos/ros-planning/moveit/releases{/id}","deployments_url":"https://api.github.com/repos/ros-planning/moveit/deployments","created_at":"2016-07-27T20:38:09Z","updated_at":"2016-09-21T00:46:15Z","pushed_at":"2016-09-22T13:58:46Z","git_url":"git://github.com/ros-planning/moveit.git","ssh_url":"git@github.com:ros-planning/moveit.git","clone_url":"https://github.com/ros-planning/moveit.git","svn_url":"https://github.com/ros-planning/moveit","homepage":"http://moveit.ros.org/","size":54335,"stargazers_count":23,"watchers_count":23,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":79,"forks":33,"open_issues":79,"watchers":23,"default_branch":"kinetic-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ros-planning/moveit/pulls/239"},"html":{"href":"https://github.com/ros-planning/moveit/pull/239"},"issue":{"href":"https://api.github.com/repos/ros-planning/moveit/issues/239"},"comments":{"href":"https://api.github.com/repos/ros-planning/moveit/issues/239/comments"},"review_comments":{"href":"https://api.github.com/repos/ros-planning/moveit/pulls/239/comments"},"review_comment":{"href":"https://api.github.com/repos/ros-planning/moveit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros-planning/moveit/pulls/239/commits"},"statuses":{"href":"https://api.github.com/repos/ros-planning/moveit/statuses/c1e70210feffb5ae61a623f32b926a8e9081a2fb"}}}}
{"actor":{"display_login":"davetcoleman"}}