{"action":"created","comment":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/comments/82483564","pull_request_review_id":3391710,"id":82483564,"diff_hunk":"@@ -19,6 +19,8 @@ class Price < Spree::Base\n     validates :country, presence: true, unless: -> { for_any_country? }\n \n     scope :currently_valid, -> { order(\"country_iso IS NULL, updated_at DESC\") }\n+    scope :for_master, -> { joins(:variant).where(:spree_variants => {:is_master => true }) }\n+    scope :for_variant, -> { joins(:variant).where(:spree_variants => {:is_master => !true }) }","path":"core/app/models/spree/price.rb","position":5,"original_position":5,"commit_id":"db966e7f09735b4ce530e53db7c97ace832c8f32","original_commit_id":"db966e7f09735b4ce530e53db7c97ace832c8f32","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Use the new Ruby 1.9 hash syntax.<br>Space inside { missing.","created_at":"2016-10-07T22:58:04Z","updated_at":"2016-10-07T22:58:04Z","html_url":"https://github.com/solidusio/solidus/pull/1510#discussion_r82483564","pull_request_url":"https://api.github.com/repos/solidusio/solidus/pulls/1510","_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments/82483564"},"html":{"href":"https://github.com/solidusio/solidus/pull/1510#discussion_r82483564"},"pull_request":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/1510"}}},"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/1510","id":88520386,"html_url":"https://github.com/solidusio/solidus/pull/1510","diff_url":"https://github.com/solidusio/solidus/pull/1510.diff","patch_url":"https://github.com/solidusio/solidus/pull/1510.patch","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/1510","number":1510,"state":"open","locked":false,"title":"Admin pricing view","user":{"login":"omnistegan","id":12424770,"avatar_url":"https://avatars.githubusercontent.com/u/12424770?v=3","gravatar_id":"","url":"https://api.github.com/users/omnistegan","html_url":"https://github.com/omnistegan","followers_url":"https://api.github.com/users/omnistegan/followers","following_url":"https://api.github.com/users/omnistegan/following{/other_user}","gists_url":"https://api.github.com/users/omnistegan/gists{/gist_id}","starred_url":"https://api.github.com/users/omnistegan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omnistegan/subscriptions","organizations_url":"https://api.github.com/users/omnistegan/orgs","repos_url":"https://api.github.com/users/omnistegan/repos","events_url":"https://api.github.com/users/omnistegan/events{/privacy}","received_events_url":"https://api.github.com/users/omnistegan/received_events","type":"User","site_admin":false},"body":"This PR expands on the Admin Prices view to clarify master/variant pricing. See #1167 \r\n\r\nMaster and Variant related prices have been separated into their own tables utilising new scopes on the Price model. Additionally, Option Types and Option Values are shown in a table as a reference for the user. As recommended by @Mandily Tooltips are shown in the Master Variant and Options tables to clarify their content.\r\n\r\nTests regarding assigns in this context have been updated to reflect these changes.\r\n\r\nHere is a screenshot for reference:\r\n![tooltip](https://cloud.githubusercontent.com/assets/12424770/19207491/5c5e05ac-8ca6-11e6-978a-828454bc88e9.png)","created_at":"2016-10-07T22:57:54Z","updated_at":"2016-10-07T22:58:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03dea1fac1af83ac5028c6fdfa3bd1e82722e1d2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/solidusio/solidus/pulls/1510/commits","review_comments_url":"https://api.github.com/repos/solidusio/solidus/pulls/1510/comments","review_comment_url":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/1510/comments","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/db966e7f09735b4ce530e53db7c97ace832c8f32","head":{"label":"omnistegan:admin_pricing_view","ref":"admin_pricing_view","sha":"db966e7f09735b4ce530e53db7c97ace832c8f32","user":{"login":"omnistegan","id":12424770,"avatar_url":"https://avatars.githubusercontent.com/u/12424770?v=3","gravatar_id":"","url":"https://api.github.com/users/omnistegan","html_url":"https://github.com/omnistegan","followers_url":"https://api.github.com/users/omnistegan/followers","following_url":"https://api.github.com/users/omnistegan/following{/other_user}","gists_url":"https://api.github.com/users/omnistegan/gists{/gist_id}","starred_url":"https://api.github.com/users/omnistegan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omnistegan/subscriptions","organizations_url":"https://api.github.com/users/omnistegan/orgs","repos_url":"https://api.github.com/users/omnistegan/repos","events_url":"https://api.github.com/users/omnistegan/events{/privacy}","received_events_url":"https://api.github.com/users/omnistegan/received_events","type":"User","site_admin":false},"repo":{"id":69305097,"name":"solidus","full_name":"omnistegan/solidus","owner":{"login":"omnistegan","id":12424770,"avatar_url":"https://avatars.githubusercontent.com/u/12424770?v=3","gravatar_id":"","url":"https://api.github.com/users/omnistegan","html_url":"https://github.com/omnistegan","followers_url":"https://api.github.com/users/omnistegan/followers","following_url":"https://api.github.com/users/omnistegan/following{/other_user}","gists_url":"https://api.github.com/users/omnistegan/gists{/gist_id}","starred_url":"https://api.github.com/users/omnistegan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omnistegan/subscriptions","organizations_url":"https://api.github.com/users/omnistegan/orgs","repos_url":"https://api.github.com/users/omnistegan/repos","events_url":"https://api.github.com/users/omnistegan/events{/privacy}","received_events_url":"https://api.github.com/users/omnistegan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/omnistegan/solidus","description":"Solidus, Rails eCommerce System","fork":true,"url":"https://api.github.com/repos/omnistegan/solidus","forks_url":"https://api.github.com/repos/omnistegan/solidus/forks","keys_url":"https://api.github.com/repos/omnistegan/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omnistegan/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omnistegan/solidus/teams","hooks_url":"https://api.github.com/repos/omnistegan/solidus/hooks","issue_events_url":"https://api.github.com/repos/omnistegan/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/omnistegan/solidus/events","assignees_url":"https://api.github.com/repos/omnistegan/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/omnistegan/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/omnistegan/solidus/tags","blobs_url":"https://api.github.com/repos/omnistegan/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omnistegan/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omnistegan/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/omnistegan/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omnistegan/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/omnistegan/solidus/languages","stargazers_url":"https://api.github.com/repos/omnistegan/solidus/stargazers","contributors_url":"https://api.github.com/repos/omnistegan/solidus/contributors","subscribers_url":"https://api.github.com/repos/omnistegan/solidus/subscribers","subscription_url":"https://api.github.com/repos/omnistegan/solidus/subscription","commits_url":"https://api.github.com/repos/omnistegan/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/omnistegan/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/omnistegan/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/omnistegan/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/omnistegan/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/omnistegan/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omnistegan/solidus/merges","archive_url":"https://api.github.com/repos/omnistegan/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omnistegan/solidus/downloads","issues_url":"https://api.github.com/repos/omnistegan/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/omnistegan/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/omnistegan/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/omnistegan/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omnistegan/solidus/labels{/name}","releases_url":"https://api.github.com/repos/omnistegan/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/omnistegan/solidus/deployments","created_at":"2016-09-27T00:46:53Z","updated_at":"2016-09-27T00:46:56Z","pushed_at":"2016-10-07T22:52:26Z","git_url":"git://github.com/omnistegan/solidus.git","ssh_url":"git@github.com:omnistegan/solidus.git","clone_url":"https://github.com/omnistegan/solidus.git","svn_url":"https://github.com/omnistegan/solidus","homepage":"http://solidus.io/","size":64773,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solidusio:master","ref":"master","sha":"9cbc08ab276d4f564d5b40860cd3f1844ab62b3b","user":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars.githubusercontent.com/u/11045486?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"repo":{"id":30985840,"name":"solidus","full_name":"solidusio/solidus","owner":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars.githubusercontent.com/u/11045486?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/solidusio/solidus","description":"Solidus, Rails eCommerce System","fork":false,"url":"https://api.github.com/repos/solidusio/solidus","forks_url":"https://api.github.com/repos/solidusio/solidus/forks","keys_url":"https://api.github.com/repos/solidusio/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solidusio/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solidusio/solidus/teams","hooks_url":"https://api.github.com/repos/solidusio/solidus/hooks","issue_events_url":"https://api.github.com/repos/solidusio/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/solidusio/solidus/events","assignees_url":"https://api.github.com/repos/solidusio/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/solidusio/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/solidusio/solidus/tags","blobs_url":"https://api.github.com/repos/solidusio/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solidusio/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solidusio/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/solidusio/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/solidusio/solidus/languages","stargazers_url":"https://api.github.com/repos/solidusio/solidus/stargazers","contributors_url":"https://api.github.com/repos/solidusio/solidus/contributors","subscribers_url":"https://api.github.com/repos/solidusio/solidus/subscribers","subscription_url":"https://api.github.com/repos/solidusio/solidus/subscription","commits_url":"https://api.github.com/repos/solidusio/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/solidusio/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/solidusio/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/solidusio/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/solidusio/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/solidusio/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solidusio/solidus/merges","archive_url":"https://api.github.com/repos/solidusio/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solidusio/solidus/downloads","issues_url":"https://api.github.com/repos/solidusio/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/solidusio/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/solidusio/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/solidusio/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solidusio/solidus/labels{/name}","releases_url":"https://api.github.com/repos/solidusio/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/solidusio/solidus/deployments","created_at":"2015-02-18T20:41:58Z","updated_at":"2016-10-07T11:19:45Z","pushed_at":"2016-10-07T22:57:54Z","git_url":"git://github.com/solidusio/solidus.git","ssh_url":"git@github.com:solidusio/solidus.git","clone_url":"https://github.com/solidusio/solidus.git","svn_url":"https://github.com/solidusio/solidus","homepage":"https://solidus.io/","size":71129,"stargazers_count":1108,"watchers_count":1108,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":338,"mirror_url":null,"open_issues_count":172,"forks":338,"open_issues":172,"watchers":1108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/1510"},"html":{"href":"https://github.com/solidusio/solidus/pull/1510"},"issue":{"href":"https://api.github.com/repos/solidusio/solidus/issues/1510"},"comments":{"href":"https://api.github.com/repos/solidusio/solidus/issues/1510/comments"},"review_comments":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/1510/comments"},"review_comment":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/1510/commits"},"statuses":{"href":"https://api.github.com/repos/solidusio/solidus/statuses/db966e7f09735b4ce530e53db7c97ace832c8f32"}}}}
{"actor":{"display_login":"houndci-bot"}}