{"action":"closed","number":1013,"pull_request":{"url":"https://api.github.com/repos/Ultimaker/Cura/pulls/1013","id":86306327,"html_url":"https://github.com/Ultimaker/Cura/pull/1013","diff_url":"https://github.com/Ultimaker/Cura/pull/1013.diff","patch_url":"https://github.com/Ultimaker/Cura/pull/1013.patch","issue_url":"https://api.github.com/repos/Ultimaker/Cura/issues/1013","number":1013,"state":"closed","locked":false,"title":"SliceInfo: Defining container_serialized as empty, before trying to s…","user":{"login":"thopiekar","id":1847437,"avatar_url":"https://avatars.githubusercontent.com/u/1847437?v=3","gravatar_id":"","url":"https://api.github.com/users/thopiekar","html_url":"https://github.com/thopiekar","followers_url":"https://api.github.com/users/thopiekar/followers","following_url":"https://api.github.com/users/thopiekar/following{/other_user}","gists_url":"https://api.github.com/users/thopiekar/gists{/gist_id}","starred_url":"https://api.github.com/users/thopiekar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thopiekar/subscriptions","organizations_url":"https://api.github.com/users/thopiekar/orgs","repos_url":"https://api.github.com/users/thopiekar/repos","events_url":"https://api.github.com/users/thopiekar/events{/privacy}","received_events_url":"https://api.github.com/users/thopiekar/received_events","type":"User","site_admin":false},"body":"…erialize\r\n\r\nWhile discussing with Jordy about the code I just found a problematic case where sending slice info could fail.\r\n(This shouldn't happen, but..) If the first container is not serializable, then the for-loop will crash because container_serialized is not set for the if clause.\r\nAdditionally the if-clause is at the moment useless, because it is always true, because the content of container_serialized gets never resetted.\r\n\r\nContributes to CURA-1445","created_at":"2016-09-22T09:43:35Z","updated_at":"2016-09-27T13:39:05Z","closed_at":"2016-09-27T13:39:05Z","merged_at":null,"merge_commit_sha":"d6281500e9a3ab0089dd8cc2ebee8dfaa2c2dc59","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ultimaker/Cura/pulls/1013/commits","review_comments_url":"https://api.github.com/repos/Ultimaker/Cura/pulls/1013/comments","review_comment_url":"https://api.github.com/repos/Ultimaker/Cura/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ultimaker/Cura/issues/1013/comments","statuses_url":"https://api.github.com/repos/Ultimaker/Cura/statuses/1fd169c6697f268588733e7a6d65e80d587b51ab","head":{"label":"Ultimaker:thopiekar-sliceinfo-hotfix","ref":"thopiekar-sliceinfo-hotfix","sha":"1fd169c6697f268588733e7a6d65e80d587b51ab","user":{"login":"Ultimaker","id":499557,"avatar_url":"https://avatars.githubusercontent.com/u/499557?v=3","gravatar_id":"","url":"https://api.github.com/users/Ultimaker","html_url":"https://github.com/Ultimaker","followers_url":"https://api.github.com/users/Ultimaker/followers","following_url":"https://api.github.com/users/Ultimaker/following{/other_user}","gists_url":"https://api.github.com/users/Ultimaker/gists{/gist_id}","starred_url":"https://api.github.com/users/Ultimaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ultimaker/subscriptions","organizations_url":"https://api.github.com/users/Ultimaker/orgs","repos_url":"https://api.github.com/users/Ultimaker/repos","events_url":"https://api.github.com/users/Ultimaker/events{/privacy}","received_events_url":"https://api.github.com/users/Ultimaker/received_events","type":"Organization","site_admin":false},"repo":{"id":20884782,"name":"Cura","full_name":"Ultimaker/Cura","owner":{"login":"Ultimaker","id":499557,"avatar_url":"https://avatars.githubusercontent.com/u/499557?v=3","gravatar_id":"","url":"https://api.github.com/users/Ultimaker","html_url":"https://github.com/Ultimaker","followers_url":"https://api.github.com/users/Ultimaker/followers","following_url":"https://api.github.com/users/Ultimaker/following{/other_user}","gists_url":"https://api.github.com/users/Ultimaker/gists{/gist_id}","starred_url":"https://api.github.com/users/Ultimaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ultimaker/subscriptions","organizations_url":"https://api.github.com/users/Ultimaker/orgs","repos_url":"https://api.github.com/users/Ultimaker/repos","events_url":"https://api.github.com/users/Ultimaker/events{/privacy}","received_events_url":"https://api.github.com/users/Ultimaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Ultimaker/Cura","description":"3D printer / slicing GUI built on top of the Uranium framework","fork":false,"url":"https://api.github.com/repos/Ultimaker/Cura","forks_url":"https://api.github.com/repos/Ultimaker/Cura/forks","keys_url":"https://api.github.com/repos/Ultimaker/Cura/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ultimaker/Cura/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ultimaker/Cura/teams","hooks_url":"https://api.github.com/repos/Ultimaker/Cura/hooks","issue_events_url":"https://api.github.com/repos/Ultimaker/Cura/issues/events{/number}","events_url":"https://api.github.com/repos/Ultimaker/Cura/events","assignees_url":"https://api.github.com/repos/Ultimaker/Cura/assignees{/user}","branches_url":"https://api.github.com/repos/Ultimaker/Cura/branches{/branch}","tags_url":"https://api.github.com/repos/Ultimaker/Cura/tags","blobs_url":"https://api.github.com/repos/Ultimaker/Cura/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ultimaker/Cura/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ultimaker/Cura/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ultimaker/Cura/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ultimaker/Cura/statuses/{sha}","languages_url":"https://api.github.com/repos/Ultimaker/Cura/languages","stargazers_url":"https://api.github.com/repos/Ultimaker/Cura/stargazers","contributors_url":"https://api.github.com/repos/Ultimaker/Cura/contributors","subscribers_url":"https://api.github.com/repos/Ultimaker/Cura/subscribers","subscription_url":"https://api.github.com/repos/Ultimaker/Cura/subscription","commits_url":"https://api.github.com/repos/Ultimaker/Cura/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ultimaker/Cura/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ultimaker/Cura/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ultimaker/Cura/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ultimaker/Cura/contents/{+path}","compare_url":"https://api.github.com/repos/Ultimaker/Cura/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ultimaker/Cura/merges","archive_url":"https://api.github.com/repos/Ultimaker/Cura/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ultimaker/Cura/downloads","issues_url":"https://api.github.com/repos/Ultimaker/Cura/issues{/number}","pulls_url":"https://api.github.com/repos/Ultimaker/Cura/pulls{/number}","milestones_url":"https://api.github.com/repos/Ultimaker/Cura/milestones{/number}","notifications_url":"https://api.github.com/repos/Ultimaker/Cura/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ultimaker/Cura/labels{/name}","releases_url":"https://api.github.com/repos/Ultimaker/Cura/releases{/id}","deployments_url":"https://api.github.com/repos/Ultimaker/Cura/deployments","created_at":"2014-06-16T12:55:31Z","updated_at":"2016-09-25T18:35:23Z","pushed_at":"2016-09-27T13:25:01Z","git_url":"git://github.com/Ultimaker/Cura.git","ssh_url":"git@github.com:Ultimaker/Cura.git","clone_url":"https://github.com/Ultimaker/Cura.git","svn_url":"https://github.com/Ultimaker/Cura","homepage":"","size":42771,"stargazers_count":221,"watchers_count":221,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":147,"mirror_url":null,"open_issues_count":205,"forks":147,"open_issues":205,"watchers":221,"default_branch":"master"}},"base":{"label":"Ultimaker:master","ref":"master","sha":"89c78fa2dac2fbb84e034a850ef5ec36cc87fd93","user":{"login":"Ultimaker","id":499557,"avatar_url":"https://avatars.githubusercontent.com/u/499557?v=3","gravatar_id":"","url":"https://api.github.com/users/Ultimaker","html_url":"https://github.com/Ultimaker","followers_url":"https://api.github.com/users/Ultimaker/followers","following_url":"https://api.github.com/users/Ultimaker/following{/other_user}","gists_url":"https://api.github.com/users/Ultimaker/gists{/gist_id}","starred_url":"https://api.github.com/users/Ultimaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ultimaker/subscriptions","organizations_url":"https://api.github.com/users/Ultimaker/orgs","repos_url":"https://api.github.com/users/Ultimaker/repos","events_url":"https://api.github.com/users/Ultimaker/events{/privacy}","received_events_url":"https://api.github.com/users/Ultimaker/received_events","type":"Organization","site_admin":false},"repo":{"id":20884782,"name":"Cura","full_name":"Ultimaker/Cura","owner":{"login":"Ultimaker","id":499557,"avatar_url":"https://avatars.githubusercontent.com/u/499557?v=3","gravatar_id":"","url":"https://api.github.com/users/Ultimaker","html_url":"https://github.com/Ultimaker","followers_url":"https://api.github.com/users/Ultimaker/followers","following_url":"https://api.github.com/users/Ultimaker/following{/other_user}","gists_url":"https://api.github.com/users/Ultimaker/gists{/gist_id}","starred_url":"https://api.github.com/users/Ultimaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ultimaker/subscriptions","organizations_url":"https://api.github.com/users/Ultimaker/orgs","repos_url":"https://api.github.com/users/Ultimaker/repos","events_url":"https://api.github.com/users/Ultimaker/events{/privacy}","received_events_url":"https://api.github.com/users/Ultimaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Ultimaker/Cura","description":"3D printer / slicing GUI built on top of the Uranium framework","fork":false,"url":"https://api.github.com/repos/Ultimaker/Cura","forks_url":"https://api.github.com/repos/Ultimaker/Cura/forks","keys_url":"https://api.github.com/repos/Ultimaker/Cura/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ultimaker/Cura/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ultimaker/Cura/teams","hooks_url":"https://api.github.com/repos/Ultimaker/Cura/hooks","issue_events_url":"https://api.github.com/repos/Ultimaker/Cura/issues/events{/number}","events_url":"https://api.github.com/repos/Ultimaker/Cura/events","assignees_url":"https://api.github.com/repos/Ultimaker/Cura/assignees{/user}","branches_url":"https://api.github.com/repos/Ultimaker/Cura/branches{/branch}","tags_url":"https://api.github.com/repos/Ultimaker/Cura/tags","blobs_url":"https://api.github.com/repos/Ultimaker/Cura/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ultimaker/Cura/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ultimaker/Cura/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ultimaker/Cura/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ultimaker/Cura/statuses/{sha}","languages_url":"https://api.github.com/repos/Ultimaker/Cura/languages","stargazers_url":"https://api.github.com/repos/Ultimaker/Cura/stargazers","contributors_url":"https://api.github.com/repos/Ultimaker/Cura/contributors","subscribers_url":"https://api.github.com/repos/Ultimaker/Cura/subscribers","subscription_url":"https://api.github.com/repos/Ultimaker/Cura/subscription","commits_url":"https://api.github.com/repos/Ultimaker/Cura/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ultimaker/Cura/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ultimaker/Cura/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ultimaker/Cura/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ultimaker/Cura/contents/{+path}","compare_url":"https://api.github.com/repos/Ultimaker/Cura/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ultimaker/Cura/merges","archive_url":"https://api.github.com/repos/Ultimaker/Cura/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ultimaker/Cura/downloads","issues_url":"https://api.github.com/repos/Ultimaker/Cura/issues{/number}","pulls_url":"https://api.github.com/repos/Ultimaker/Cura/pulls{/number}","milestones_url":"https://api.github.com/repos/Ultimaker/Cura/milestones{/number}","notifications_url":"https://api.github.com/repos/Ultimaker/Cura/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ultimaker/Cura/labels{/name}","releases_url":"https://api.github.com/repos/Ultimaker/Cura/releases{/id}","deployments_url":"https://api.github.com/repos/Ultimaker/Cura/deployments","created_at":"2014-06-16T12:55:31Z","updated_at":"2016-09-25T18:35:23Z","pushed_at":"2016-09-27T13:25:01Z","git_url":"git://github.com/Ultimaker/Cura.git","ssh_url":"git@github.com:Ultimaker/Cura.git","clone_url":"https://github.com/Ultimaker/Cura.git","svn_url":"https://github.com/Ultimaker/Cura","homepage":"","size":42771,"stargazers_count":221,"watchers_count":221,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":147,"mirror_url":null,"open_issues_count":205,"forks":147,"open_issues":205,"watchers":221,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ultimaker/Cura/pulls/1013"},"html":{"href":"https://github.com/Ultimaker/Cura/pull/1013"},"issue":{"href":"https://api.github.com/repos/Ultimaker/Cura/issues/1013"},"comments":{"href":"https://api.github.com/repos/Ultimaker/Cura/issues/1013/comments"},"review_comments":{"href":"https://api.github.com/repos/Ultimaker/Cura/pulls/1013/comments"},"review_comment":{"href":"https://api.github.com/repos/Ultimaker/Cura/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ultimaker/Cura/pulls/1013/commits"},"statuses":{"href":"https://api.github.com/repos/Ultimaker/Cura/statuses/1fd169c6697f268588733e7a6d65e80d587b51ab"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":6,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"thopiekar"}}