{"action":"opened","issue":{"url":"https://api.github.com/repos/torch/cutorch/issues/579","repository_url":"https://api.github.com/repos/torch/cutorch","labels_url":"https://api.github.com/repos/torch/cutorch/issues/579/labels{/name}","comments_url":"https://api.github.com/repos/torch/cutorch/issues/579/comments","events_url":"https://api.github.com/repos/torch/cutorch/issues/579/events","html_url":"https://github.com/torch/cutorch/issues/579","id":186664055,"number":579,"title":"Minor inconsistency between CPU and CUDA potrf and potrs interfaces","user":{"login":"bamos","id":707462,"avatar_url":"https://avatars.githubusercontent.com/u/707462?v=3","gravatar_id":"","url":"https://api.github.com/users/bamos","html_url":"https://github.com/bamos","followers_url":"https://api.github.com/users/bamos/followers","following_url":"https://api.github.com/users/bamos/following{/other_user}","gists_url":"https://api.github.com/users/bamos/gists{/gist_id}","starred_url":"https://api.github.com/users/bamos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bamos/subscriptions","organizations_url":"https://api.github.com/users/bamos/orgs","repos_url":"https://api.github.com/users/bamos/repos","events_url":"https://api.github.com/users/bamos/events{/privacy}","received_events_url":"https://api.github.com/users/bamos/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-11-01T22:22:00Z","updated_at":"2016-11-01T22:22:00Z","closed_at":null,"body":"The CPU interface has a lower/upper triangular argument ([ref](https://github.com/torch/torch7/blob/04e1d1dce0f02aea82dc433c4f39e42650c4390f/TensorMath.lua#L1358)), but the CUDA interface doesn't ([ref](https://github.com/torch/cutorch/blob/0b33e2cadb731c10df7cb94d87717536fa83c913/TensorMath.lua#L1783)).\r\n\r\n## CPU\r\n\r\n```Lua\r\n      interface:wrap(\"potrf\",\r\n                     cname(\"potrf\"),\r\n                     {{name=Tensor, returned=true},\r\n                      {name=Tensor},\r\n                      {name='charoption', values={'U', 'L'}, default='U'}}, -- uplo\r\n                     cname(\"potrf\"),\r\n                     {{name=Tensor, default=true, returned=true, invisible=true},\r\n                      {name=Tensor},\r\n                      {name='charoption', values={'U', 'L'}, default='U'}}\r\n                  )\r\n      interface:wrap(\"potrs\",\r\n                     cname(\"potrs\"),\r\n                     {{name=Tensor, returned=true},\r\n                      {name=Tensor},\r\n                      {name=Tensor},\r\n                      {name='charoption', values={'U', 'L'}, default='U'}}, -- uplo\r\n                     cname(\"potrs\"),\r\n                     {{name=Tensor, default=true, returned=true, invisible=true},\r\n                      {name=Tensor},\r\n                      {name=Tensor},\r\n                      {name='charoption', values={'U', 'L'}, default='U'}}\r\n                  )\r\n```\r\n\r\n## CUDA\r\n\r\n```Python\r\nwrap(\"potrf\",\r\n     cname(\"potrf\"),\r\n     {{name=Tensor, returned=true},\r\n      {name=Tensor}},\r\n     cname(\"potrf\"),\r\n     {{name=Tensor, default=true, returned=true, invisible=true},\r\n      {name=Tensor}})\r\n\r\nwrap(\"potrs\",\r\n     cname(\"potrs\"),\r\n     {{name=Tensor, returned=true},\r\n      {name=Tensor},\r\n      {name=Tensor}},\r\n     cname(\"potrs\"),\r\n     {{name=Tensor, default=true, returned=true, invisible=true},\r\n      {name=Tensor},\r\n      {name=Tensor}})\r\n```"}}
{"actor":{"display_login":"bamos"}}