{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/rocksdb/issues/1721","repository_url":"https://api.github.com/repos/facebook/rocksdb","labels_url":"https://api.github.com/repos/facebook/rocksdb/issues/1721/labels{/name}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/1721/comments","events_url":"https://api.github.com/repos/facebook/rocksdb/issues/1721/events","html_url":"https://github.com/facebook/rocksdb/pull/1721","id":197626751,"number":1721,"title":"Make Checkpoint work with 2PC","user":{"login":"yoshinorim","id":253614,"avatar_url":"https://avatars.githubusercontent.com/u/253614?v=3","gravatar_id":"","url":"https://api.github.com/users/yoshinorim","html_url":"https://github.com/yoshinorim","followers_url":"https://api.github.com/users/yoshinorim/followers","following_url":"https://api.github.com/users/yoshinorim/following{/other_user}","gists_url":"https://api.github.com/users/yoshinorim/gists{/gist_id}","starred_url":"https://api.github.com/users/yoshinorim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoshinorim/subscriptions","organizations_url":"https://api.github.com/users/yoshinorim/orgs","repos_url":"https://api.github.com/users/yoshinorim/repos","events_url":"https://api.github.com/users/yoshinorim/events{/privacy}","received_events_url":"https://api.github.com/users/yoshinorim/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-12-26T23:28:14Z","updated_at":"2016-12-27T17:39:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/1721","html_url":"https://github.com/facebook/rocksdb/pull/1721","diff_url":"https://github.com/facebook/rocksdb/pull/1721.diff","patch_url":"https://github.com/facebook/rocksdb/pull/1721.patch"},"body":"Summary: There was a bug that Checkpoint might have skipped\r\ncopying necessary WAL files that included \"prepare\" entries.\r\nThis meant restored database from checkpoint might have lost\r\nsome transactions with 2PC enabled.\r\nThis diff changes Checkpoint behavior when 2PC is enabled\r\n-- simply copying all live WAL files. This diff prevents\r\ndata loss on snapshot, but has a big side effect that copy\r\nvolume of WAL files may increase hugely (up to max WAL file size).\r\nTo prevent burst writes, this diff also changes CopyFile function\r\nto optionally call fsync() after copy.\r\n\r\nTest Plan: CurrentFileModifiedWhileCheckpointing2PC"},"comment":{"url":"https://api.github.com/repos/facebook/rocksdb/issues/comments/269357681","html_url":"https://github.com/facebook/rocksdb/pull/1721#issuecomment-269357681","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/1721","id":269357681,"user":{"login":"siying","id":5334567,"avatar_url":"https://avatars.githubusercontent.com/u/5334567?v=3","gravatar_id":"","url":"https://api.github.com/users/siying","html_url":"https://github.com/siying","followers_url":"https://api.github.com/users/siying/followers","following_url":"https://api.github.com/users/siying/following{/other_user}","gists_url":"https://api.github.com/users/siying/gists{/gist_id}","starred_url":"https://api.github.com/users/siying/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siying/subscriptions","organizations_url":"https://api.github.com/users/siying/orgs","repos_url":"https://api.github.com/users/siying/repos","events_url":"https://api.github.com/users/siying/events{/privacy}","received_events_url":"https://api.github.com/users/siying/received_events","type":"User","site_admin":false},"created_at":"2016-12-27T17:39:30Z","updated_at":"2016-12-27T17:39:30Z","body":"@yoshinorim all but the last log file should be hard-linked. Do you know why you saw a copy instead?"}}
{"actor":{"display_login":"siying"}}