{"action":"created","issue":{"url":"https://api.github.com/repos/solidusio/solidus/issues/1638","repository_url":"https://api.github.com/repos/solidusio/solidus","labels_url":"https://api.github.com/repos/solidusio/solidus/issues/1638/labels{/name}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/1638/comments","events_url":"https://api.github.com/repos/solidusio/solidus/issues/1638/events","html_url":"https://github.com/solidusio/solidus/pull/1638","id":193435849,"number":1638,"title":"Fix for duplicate prices","user":{"login":"fschwahn","id":57876,"avatar_url":"https://avatars.githubusercontent.com/u/57876?v=3","gravatar_id":"","url":"https://api.github.com/users/fschwahn","html_url":"https://github.com/fschwahn","followers_url":"https://api.github.com/users/fschwahn/followers","following_url":"https://api.github.com/users/fschwahn/following{/other_user}","gists_url":"https://api.github.com/users/fschwahn/gists{/gist_id}","starred_url":"https://api.github.com/users/fschwahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fschwahn/subscriptions","organizations_url":"https://api.github.com/users/fschwahn/orgs","repos_url":"https://api.github.com/users/fschwahn/repos","events_url":"https://api.github.com/users/fschwahn/events{/privacy}","received_events_url":"https://api.github.com/users/fschwahn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-12-05T08:19:15Z","updated_at":"2016-12-05T11:12:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/1638","html_url":"https://github.com/solidusio/solidus/pull/1638","diff_url":"https://github.com/solidusio/solidus/pull/1638.diff","patch_url":"https://github.com/solidusio/solidus/pull/1638.patch"},"body":"This is a failing spec, and a solution for `Variant#build_vat_prices` running several times for variants and subsequently creating duplicate prices (see #1634).\r\n\r\nAs mentioned in the issue I'm not sure the solution is right (eg. what happens if validations are run several times on purpose while changing tax categories?), but it was the easiest to implement."},"comment":{"url":"https://api.github.com/repos/solidusio/solidus/issues/comments/264827712","html_url":"https://github.com/solidusio/solidus/pull/1638#issuecomment-264827712","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/1638","id":264827712,"user":{"login":"mamhoff","id":703401,"avatar_url":"https://avatars.githubusercontent.com/u/703401?v=3","gravatar_id":"","url":"https://api.github.com/users/mamhoff","html_url":"https://github.com/mamhoff","followers_url":"https://api.github.com/users/mamhoff/followers","following_url":"https://api.github.com/users/mamhoff/following{/other_user}","gists_url":"https://api.github.com/users/mamhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/mamhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mamhoff/subscriptions","organizations_url":"https://api.github.com/users/mamhoff/orgs","repos_url":"https://api.github.com/users/mamhoff/repos","events_url":"https://api.github.com/users/mamhoff/events{/privacy}","received_events_url":"https://api.github.com/users/mamhoff/received_events","type":"User","site_admin":false},"created_at":"2016-12-05T11:12:28Z","updated_at":"2016-12-05T11:12:28Z","body":"@fschwahn FYI we have a policy of not merging approved PRs for at least 24 hours. While this has a good chance of being merged, it might take a couple of days. This is to allow community feedback. "}}
{"actor":{"display_login":"mamhoff"}}