{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/66497873","id":66497873,"diff_hunk":"@@ -0,0 +1,341 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements.  See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership.  The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License.  You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.apache.beam.sdk.io;\n+\n+import static org.apache.beam.sdk.util.StringUtils.approximateSimpleName;\n+\n+import org.apache.beam.sdk.Pipeline;\n+import org.apache.beam.sdk.coders.Coder;\n+import org.apache.beam.sdk.coders.CoderException;\n+import org.apache.beam.sdk.coders.ListCoder;\n+import org.apache.beam.sdk.coders.SerializableCoder;\n+import org.apache.beam.sdk.coders.StandardCoder;\n+import org.apache.beam.sdk.io.BoundedSource.BoundedReader;\n+import org.apache.beam.sdk.options.PipelineOptions;\n+import org.apache.beam.sdk.transforms.PTransform;\n+import org.apache.beam.sdk.transforms.display.DisplayData;\n+import org.apache.beam.sdk.transforms.windowing.BoundedWindow;\n+import org.apache.beam.sdk.util.PropertyNames;\n+import org.apache.beam.sdk.values.PCollection;\n+import org.apache.beam.sdk.values.PInput;\n+import org.apache.beam.sdk.values.TimestampedValue;\n+\n+import com.google.api.client.util.Lists;\n+import com.google.api.client.util.Preconditions;\n+import com.google.common.annotations.VisibleForTesting;\n+\n+import com.fasterxml.jackson.annotation.JsonCreator;\n+import com.fasterxml.jackson.annotation.JsonProperty;\n+\n+import org.joda.time.Instant;\n+\n+import java.io.IOException;\n+import java.io.InputStream;\n+import java.io.OutputStream;\n+import java.util.Arrays;\n+import java.util.List;\n+import java.util.NoSuchElementException;\n+\n+import javax.annotation.Nullable;\n+\n+/**\n+ * {@link PTransform} that performs a unbounded read from an {@link BoundedSource}.\n+ *\n+ * <p>Created by {@link Read}.\n+ */\n+public class UnboundedReadFromBoundedSource<T> extends PTransform<PInput, PCollection<T>> {","path":"sdks/java/core/src/main/java/org/apache/beam/sdk/io/UnboundedReadFromBoundedSource.java","position":61,"original_position":61,"commit_id":"8588f6dbc79ec324645679dbe63667ee1b4286d1","original_commit_id":"94b77cced20c9a5163058e4939eb3292c6ccc76e","user":{"login":"dhalperi","id":526415,"avatar_url":"https://avatars.githubusercontent.com/u/526415?v=3","gravatar_id":"","url":"https://api.github.com/users/dhalperi","html_url":"https://github.com/dhalperi","followers_url":"https://api.github.com/users/dhalperi/followers","following_url":"https://api.github.com/users/dhalperi/following{/other_user}","gists_url":"https://api.github.com/users/dhalperi/gists{/gist_id}","starred_url":"https://api.github.com/users/dhalperi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhalperi/subscriptions","organizations_url":"https://api.github.com/users/dhalperi/orgs","repos_url":"https://api.github.com/users/dhalperi/repos","events_url":"https://api.github.com/users/dhalperi/events{/privacy}","received_events_url":"https://api.github.com/users/dhalperi/received_events","type":"User","site_admin":false},"body":"@kennknowles opinion on this? Should these adapters live in `runner-core`?\r\n\r\nI'd say \"no\" if only for structural parallelism -- `BoundedReadFromUnboundedSource` is here in `io` (and should be, as it is used in PTransform definitions).","created_at":"2016-06-09T18:39:52Z","updated_at":"2016-06-09T18:39:52Z","html_url":"https://github.com/apache/incubator-beam/pull/339#discussion_r66497873","pull_request_url":"https://api.github.com/repos/apache/incubator-beam/pulls/339","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/66497873"},"html":{"href":"https://github.com/apache/incubator-beam/pull/339#discussion_r66497873"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/339"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/339","id":70247600,"html_url":"https://github.com/apache/incubator-beam/pull/339","diff_url":"https://github.com/apache/incubator-beam/pull/339.diff","patch_url":"https://github.com/apache/incubator-beam/pull/339.patch","issue_url":"https://api.github.com/repos/apache/incubator-beam/issues/339","number":339,"state":"open","locked":false,"title":"Add UnboundedReadFromBoundedSource, and use it in Dataflow runner","user":{"login":"peihe","id":10201797,"avatar_url":"https://avatars.githubusercontent.com/u/10201797?v=3","gravatar_id":"","url":"https://api.github.com/users/peihe","html_url":"https://github.com/peihe","followers_url":"https://api.github.com/users/peihe/followers","following_url":"https://api.github.com/users/peihe/following{/other_user}","gists_url":"https://api.github.com/users/peihe/gists{/gist_id}","starred_url":"https://api.github.com/users/peihe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peihe/subscriptions","organizations_url":"https://api.github.com/users/peihe/orgs","repos_url":"https://api.github.com/users/peihe/repos","events_url":"https://api.github.com/users/peihe/events{/privacy}","received_events_url":"https://api.github.com/users/peihe/received_events","type":"User","site_admin":false},"body":"This PR will make Dataflow streaming runner work with BoundedSources, such as TextIO and AvroIO.","created_at":"2016-05-16T19:30:44Z","updated_at":"2016-06-09T18:39:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60ca2626bee6356fb4076d45db48a24bbf7015f5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-beam/pulls/339/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-beam/pulls/339/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-beam/issues/339/comments","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/8588f6dbc79ec324645679dbe63667ee1b4286d1","head":{"label":"peihe:unbounded-read","ref":"unbounded-read","sha":"8588f6dbc79ec324645679dbe63667ee1b4286d1","user":{"login":"peihe","id":10201797,"avatar_url":"https://avatars.githubusercontent.com/u/10201797?v=3","gravatar_id":"","url":"https://api.github.com/users/peihe","html_url":"https://github.com/peihe","followers_url":"https://api.github.com/users/peihe/followers","following_url":"https://api.github.com/users/peihe/following{/other_user}","gists_url":"https://api.github.com/users/peihe/gists{/gist_id}","starred_url":"https://api.github.com/users/peihe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peihe/subscriptions","organizations_url":"https://api.github.com/users/peihe/orgs","repos_url":"https://api.github.com/users/peihe/repos","events_url":"https://api.github.com/users/peihe/events{/privacy}","received_events_url":"https://api.github.com/users/peihe/received_events","type":"User","site_admin":false},"repo":{"id":52831526,"name":"incubator-beam","full_name":"peihe/incubator-beam","owner":{"login":"peihe","id":10201797,"avatar_url":"https://avatars.githubusercontent.com/u/10201797?v=3","gravatar_id":"","url":"https://api.github.com/users/peihe","html_url":"https://github.com/peihe","followers_url":"https://api.github.com/users/peihe/followers","following_url":"https://api.github.com/users/peihe/following{/other_user}","gists_url":"https://api.github.com/users/peihe/gists{/gist_id}","starred_url":"https://api.github.com/users/peihe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peihe/subscriptions","organizations_url":"https://api.github.com/users/peihe/orgs","repos_url":"https://api.github.com/users/peihe/repos","events_url":"https://api.github.com/users/peihe/events{/privacy}","received_events_url":"https://api.github.com/users/peihe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peihe/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/peihe/incubator-beam","forks_url":"https://api.github.com/repos/peihe/incubator-beam/forks","keys_url":"https://api.github.com/repos/peihe/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peihe/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peihe/incubator-beam/teams","hooks_url":"https://api.github.com/repos/peihe/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/peihe/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/peihe/incubator-beam/events","assignees_url":"https://api.github.com/repos/peihe/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/peihe/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/peihe/incubator-beam/tags","blobs_url":"https://api.github.com/repos/peihe/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peihe/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peihe/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/peihe/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peihe/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/peihe/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/peihe/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/peihe/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/peihe/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/peihe/incubator-beam/subscription","commits_url":"https://api.github.com/repos/peihe/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/peihe/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/peihe/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/peihe/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/peihe/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/peihe/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peihe/incubator-beam/merges","archive_url":"https://api.github.com/repos/peihe/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peihe/incubator-beam/downloads","issues_url":"https://api.github.com/repos/peihe/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/peihe/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/peihe/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/peihe/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peihe/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/peihe/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/peihe/incubator-beam/deployments","created_at":"2016-02-29T23:06:11Z","updated_at":"2016-02-29T23:06:15Z","pushed_at":"2016-06-09T00:47:11Z","git_url":"git://github.com/peihe/incubator-beam.git","ssh_url":"git@github.com:peihe/incubator-beam.git","clone_url":"https://github.com/peihe/incubator-beam.git","svn_url":"https://github.com/peihe/incubator-beam","homepage":null,"size":14607,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"af8f5935ca1866012ceb102b9472c8b1ef102d73","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"incubator-beam","full_name":"apache/incubator-beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-beam","forks_url":"https://api.github.com/repos/apache/incubator-beam/forks","keys_url":"https://api.github.com/repos/apache/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-beam/teams","hooks_url":"https://api.github.com/repos/apache/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-beam/events","assignees_url":"https://api.github.com/repos/apache/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-beam/tags","blobs_url":"https://api.github.com/repos/apache/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-beam/subscription","commits_url":"https://api.github.com/repos/apache/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-beam/merges","archive_url":"https://api.github.com/repos/apache/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-beam/downloads","issues_url":"https://api.github.com/repos/apache/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2016-06-08T00:41:30Z","pushed_at":"2016-06-09T18:33:00Z","git_url":"git://github.com/apache/incubator-beam.git","ssh_url":"git@github.com:apache/incubator-beam.git","clone_url":"https://github.com/apache/incubator-beam.git","svn_url":"https://github.com/apache/incubator-beam","homepage":null,"size":17691,"stargazers_count":214,"watchers_count":214,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":114,"mirror_url":"git://git.apache.org/incubator-beam.git","open_issues_count":32,"forks":114,"open_issues":32,"watchers":214,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/339"},"html":{"href":"https://github.com/apache/incubator-beam/pull/339"},"issue":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/339"},"comments":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/339/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/339/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/339/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-beam/statuses/8588f6dbc79ec324645679dbe63667ee1b4286d1"}}}}
{"actor":{"display_login":"dhalperi"}}