{"action":"created","comment":{"url":"https://api.github.com/repos/LLNL/spack/pulls/comments/69746065","id":69746065,"diff_hunk":"@@ -78,10 +81,13 @@ def install(self, spec, prefix):\n             ])\n \n         # BLAS arguments require path to libraries\n-        # FIXME : (blas / lapack always provide libblas and liblapack as aliases)\n-        make_args.extend([\n-            'BLAS=-lblas',\n-            'LAPACK=-llapack'\n-        ])\n+        # FIXME: (blas/lapack always provide libblas and liblapack as aliases)\n+        if '@4.5.1' in spec:","path":"var/spack/repos/builtin/packages/suite-sparse/package.py","position":66,"original_position":66,"commit_id":"0b0ade14be10819098697dde2dc5c36bf76ed19c","original_commit_id":"0b0ade14be10819098697dde2dc5c36bf76ed19c","user":{"login":"lee218llnl","id":3641995,"avatar_url":"https://avatars.githubusercontent.com/u/3641995?v=3","gravatar_id":"","url":"https://api.github.com/users/lee218llnl","html_url":"https://github.com/lee218llnl","followers_url":"https://api.github.com/users/lee218llnl/followers","following_url":"https://api.github.com/users/lee218llnl/following{/other_user}","gists_url":"https://api.github.com/users/lee218llnl/gists{/gist_id}","starred_url":"https://api.github.com/users/lee218llnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lee218llnl/subscriptions","organizations_url":"https://api.github.com/users/lee218llnl/orgs","repos_url":"https://api.github.com/users/lee218llnl/repos","events_url":"https://api.github.com/users/lee218llnl/events{/privacy}","received_events_url":"https://api.github.com/users/lee218llnl/received_events","type":"User","site_admin":false},"body":"the make_args.extend was in the original suite-sparse package for version 4.5.1, so I'm not sure if we want to change that and risk breaking previous users. I'm also not confident that the suite-sparse build system will obey the to_link_flags. The 4.5.3 version does not require these flags (I think they fixed their makefile).","created_at":"2016-07-06T14:54:20Z","updated_at":"2016-07-06T14:54:20Z","html_url":"https://github.com/LLNL/spack/pull/1174#discussion_r69746065","pull_request_url":"https://api.github.com/repos/LLNL/spack/pulls/1174","_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments/69746065"},"html":{"href":"https://github.com/LLNL/spack/pull/1174#discussion_r69746065"},"pull_request":{"href":"https://api.github.com/repos/LLNL/spack/pulls/1174"}}},"pull_request":{"url":"https://api.github.com/repos/LLNL/spack/pulls/1174","id":76340547,"html_url":"https://github.com/LLNL/spack/pull/1174","diff_url":"https://github.com/LLNL/spack/pull/1174.diff","patch_url":"https://github.com/LLNL/spack/pull/1174.patch","issue_url":"https://api.github.com/repos/LLNL/spack/issues/1174","number":1174,"state":"open","locked":false,"title":"Bugfix/GitHub 1172 suite sparse","user":{"login":"lee218llnl","id":3641995,"avatar_url":"https://avatars.githubusercontent.com/u/3641995?v=3","gravatar_id":"","url":"https://api.github.com/users/lee218llnl","html_url":"https://github.com/lee218llnl","followers_url":"https://api.github.com/users/lee218llnl/followers","following_url":"https://api.github.com/users/lee218llnl/following{/other_user}","gists_url":"https://api.github.com/users/lee218llnl/gists{/gist_id}","starred_url":"https://api.github.com/users/lee218llnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lee218llnl/subscriptions","organizations_url":"https://api.github.com/users/lee218llnl/orgs","repos_url":"https://api.github.com/users/lee218llnl/repos","events_url":"https://api.github.com/users/lee218llnl/events{/privacy}","received_events_url":"https://api.github.com/users/lee218llnl/received_events","type":"User","site_admin":false},"body":"Proposed fix for #1172 ","created_at":"2016-07-05T20:49:56Z","updated_at":"2016-07-06T14:54:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4393a88782d21d6bbbf1b186fd16924380281e17","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/LLNL/spack/pulls/1174/commits","review_comments_url":"https://api.github.com/repos/LLNL/spack/pulls/1174/comments","review_comment_url":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LLNL/spack/issues/1174/comments","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/0b0ade14be10819098697dde2dc5c36bf76ed19c","head":{"label":"LLNL:bugfix/github-1172-suite-sparse","ref":"bugfix/github-1172-suite-sparse","sha":"0b0ade14be10819098697dde2dc5c36bf76ed19c","user":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"repo":{"id":15730865,"name":"spack","full_name":"LLNL/spack","owner":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LLNL/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":false,"url":"https://api.github.com/repos/LLNL/spack","forks_url":"https://api.github.com/repos/LLNL/spack/forks","keys_url":"https://api.github.com/repos/LLNL/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLNL/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLNL/spack/teams","hooks_url":"https://api.github.com/repos/LLNL/spack/hooks","issue_events_url":"https://api.github.com/repos/LLNL/spack/issues/events{/number}","events_url":"https://api.github.com/repos/LLNL/spack/events","assignees_url":"https://api.github.com/repos/LLNL/spack/assignees{/user}","branches_url":"https://api.github.com/repos/LLNL/spack/branches{/branch}","tags_url":"https://api.github.com/repos/LLNL/spack/tags","blobs_url":"https://api.github.com/repos/LLNL/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLNL/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLNL/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLNL/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/LLNL/spack/languages","stargazers_url":"https://api.github.com/repos/LLNL/spack/stargazers","contributors_url":"https://api.github.com/repos/LLNL/spack/contributors","subscribers_url":"https://api.github.com/repos/LLNL/spack/subscribers","subscription_url":"https://api.github.com/repos/LLNL/spack/subscription","commits_url":"https://api.github.com/repos/LLNL/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLNL/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLNL/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLNL/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLNL/spack/contents/{+path}","compare_url":"https://api.github.com/repos/LLNL/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLNL/spack/merges","archive_url":"https://api.github.com/repos/LLNL/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLNL/spack/downloads","issues_url":"https://api.github.com/repos/LLNL/spack/issues{/number}","pulls_url":"https://api.github.com/repos/LLNL/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/LLNL/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/LLNL/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLNL/spack/labels{/name}","releases_url":"https://api.github.com/repos/LLNL/spack/releases{/id}","deployments_url":"https://api.github.com/repos/LLNL/spack/deployments","created_at":"2014-01-08T09:22:12Z","updated_at":"2016-07-04T08:49:53Z","pushed_at":"2016-07-06T11:43:22Z","git_url":"git://github.com/LLNL/spack.git","ssh_url":"git@github.com:LLNL/spack.git","clone_url":"https://github.com/LLNL/spack.git","svn_url":"https://github.com/LLNL/spack","homepage":"http://software.llnl.gov/spack","size":15505,"stargazers_count":128,"watchers_count":128,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":117,"mirror_url":null,"open_issues_count":189,"forks":117,"open_issues":189,"watchers":128,"default_branch":"develop"}},"base":{"label":"LLNL:develop","ref":"develop","sha":"cb9c4ac8665254eadebb00644a6243f879dbea7b","user":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"repo":{"id":15730865,"name":"spack","full_name":"LLNL/spack","owner":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LLNL/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":false,"url":"https://api.github.com/repos/LLNL/spack","forks_url":"https://api.github.com/repos/LLNL/spack/forks","keys_url":"https://api.github.com/repos/LLNL/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLNL/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLNL/spack/teams","hooks_url":"https://api.github.com/repos/LLNL/spack/hooks","issue_events_url":"https://api.github.com/repos/LLNL/spack/issues/events{/number}","events_url":"https://api.github.com/repos/LLNL/spack/events","assignees_url":"https://api.github.com/repos/LLNL/spack/assignees{/user}","branches_url":"https://api.github.com/repos/LLNL/spack/branches{/branch}","tags_url":"https://api.github.com/repos/LLNL/spack/tags","blobs_url":"https://api.github.com/repos/LLNL/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLNL/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLNL/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLNL/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/LLNL/spack/languages","stargazers_url":"https://api.github.com/repos/LLNL/spack/stargazers","contributors_url":"https://api.github.com/repos/LLNL/spack/contributors","subscribers_url":"https://api.github.com/repos/LLNL/spack/subscribers","subscription_url":"https://api.github.com/repos/LLNL/spack/subscription","commits_url":"https://api.github.com/repos/LLNL/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLNL/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLNL/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLNL/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLNL/spack/contents/{+path}","compare_url":"https://api.github.com/repos/LLNL/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLNL/spack/merges","archive_url":"https://api.github.com/repos/LLNL/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLNL/spack/downloads","issues_url":"https://api.github.com/repos/LLNL/spack/issues{/number}","pulls_url":"https://api.github.com/repos/LLNL/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/LLNL/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/LLNL/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLNL/spack/labels{/name}","releases_url":"https://api.github.com/repos/LLNL/spack/releases{/id}","deployments_url":"https://api.github.com/repos/LLNL/spack/deployments","created_at":"2014-01-08T09:22:12Z","updated_at":"2016-07-04T08:49:53Z","pushed_at":"2016-07-06T11:43:22Z","git_url":"git://github.com/LLNL/spack.git","ssh_url":"git@github.com:LLNL/spack.git","clone_url":"https://github.com/LLNL/spack.git","svn_url":"https://github.com/LLNL/spack","homepage":"http://software.llnl.gov/spack","size":15505,"stargazers_count":128,"watchers_count":128,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":117,"mirror_url":null,"open_issues_count":189,"forks":117,"open_issues":189,"watchers":128,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/1174"},"html":{"href":"https://github.com/LLNL/spack/pull/1174"},"issue":{"href":"https://api.github.com/repos/LLNL/spack/issues/1174"},"comments":{"href":"https://api.github.com/repos/LLNL/spack/issues/1174/comments"},"review_comments":{"href":"https://api.github.com/repos/LLNL/spack/pulls/1174/comments"},"review_comment":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LLNL/spack/pulls/1174/commits"},"statuses":{"href":"https://api.github.com/repos/LLNL/spack/statuses/0b0ade14be10819098697dde2dc5c36bf76ed19c"}}}}
{"actor":{"display_login":"lee218llnl"}}