{"action":"created","issue":{"url":"https://api.github.com/repos/Wikidata-lib/PropertySuggester/issues/184","repository_url":"https://api.github.com/repos/Wikidata-lib/PropertySuggester","labels_url":"https://api.github.com/repos/Wikidata-lib/PropertySuggester/issues/184/labels{/name}","comments_url":"https://api.github.com/repos/Wikidata-lib/PropertySuggester/issues/184/comments","events_url":"https://api.github.com/repos/Wikidata-lib/PropertySuggester/issues/184/events","html_url":"https://github.com/Wikidata-lib/PropertySuggester/pull/184","id":193205162,"number":184,"title":"Fix all jslint errors","user":{"login":"mdew192837","id":6820349,"avatar_url":"https://avatars.githubusercontent.com/u/6820349?v=3","gravatar_id":"","url":"https://api.github.com/users/mdew192837","html_url":"https://github.com/mdew192837","followers_url":"https://api.github.com/users/mdew192837/followers","following_url":"https://api.github.com/users/mdew192837/following{/other_user}","gists_url":"https://api.github.com/users/mdew192837/gists{/gist_id}","starred_url":"https://api.github.com/users/mdew192837/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdew192837/subscriptions","organizations_url":"https://api.github.com/users/mdew192837/orgs","repos_url":"https://api.github.com/users/mdew192837/repos","events_url":"https://api.github.com/users/mdew192837/events{/privacy}","received_events_url":"https://api.github.com/users/mdew192837/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-12-02T20:01:57Z","updated_at":"2016-12-05T09:44:49Z","closed_at":"2016-12-03T17:36:09Z","pull_request":{"url":"https://api.github.com/repos/Wikidata-lib/PropertySuggester/pulls/184","html_url":"https://github.com/Wikidata-lib/PropertySuggester/pull/184","diff_url":"https://github.com/Wikidata-lib/PropertySuggester/pull/184.diff","patch_url":"https://github.com/Wikidata-lib/PropertySuggester/pull/184.patch"},"body":"This fixes all jslint errors. However, I have decided to go with the multiline option in 35-37 while a single line option in the tertiary operators for readability. Let me know if something needs changing. @addshore "},"comment":{"url":"https://api.github.com/repos/Wikidata-lib/PropertySuggester/issues/comments/264808911","html_url":"https://github.com/Wikidata-lib/PropertySuggester/pull/184#issuecomment-264808911","issue_url":"https://api.github.com/repos/Wikidata-lib/PropertySuggester/issues/184","id":264808911,"user":{"login":"manicki","id":3524114,"avatar_url":"https://avatars.githubusercontent.com/u/3524114?v=3","gravatar_id":"","url":"https://api.github.com/users/manicki","html_url":"https://github.com/manicki","followers_url":"https://api.github.com/users/manicki/followers","following_url":"https://api.github.com/users/manicki/following{/other_user}","gists_url":"https://api.github.com/users/manicki/gists{/gist_id}","starred_url":"https://api.github.com/users/manicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manicki/subscriptions","organizations_url":"https://api.github.com/users/manicki/orgs","repos_url":"https://api.github.com/users/manicki/repos","events_url":"https://api.github.com/users/manicki/events{/privacy}","received_events_url":"https://api.github.com/users/manicki/received_events","type":"User","site_admin":false},"created_at":"2016-12-05T09:44:49Z","updated_at":"2016-12-05T09:44:49Z","body":"I believe what would be valuable is to add jscs and/or jshint (or maybe go for the future and use eslint) rule files to this repo. That way we would be able to ensure new code is also sticking to the code style, and the code style would then be explicitly visible.\r\n\r\nFixing the existing code is very helpful too (thanks @mdew192837) but I agree with @thiemowmde that we could go even further and specify the code style etc explicitly.\r\n\r\nOh, there is already https://github.com/Wikidata-lib/PropertySuggester/pull/156 related to this."}}
{"actor":{"display_login":"manicki"}}