{"action":"created","comment":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/54848366","id":54848366,"diff_hunk":"@@ -163,6 +169,48 @@ void XWalkRunner::OnRenderProcessWillLaunch(content::RenderProcessHost* host) {\n       std::move(runtime_variables));\n }\n \n+void XWalkRunner::InitializeEnvironmentVariablesForGoogleAPIs(\n+    content::RenderProcessHost* host) {\n+#if defined (OS_WIN)","path":"runtime/browser/xwalk_runner.cc","position":26,"original_position":26,"commit_id":"46c4f4ae562e12f77f020a10e18a076a66325394","original_commit_id":"46c4f4ae562e12f77f020a10e18a076a66325394","user":{"login":"pozdnyakov","id":998253,"avatar_url":"https://avatars.githubusercontent.com/u/998253?v=3","gravatar_id":"","url":"https://api.github.com/users/pozdnyakov","html_url":"https://github.com/pozdnyakov","followers_url":"https://api.github.com/users/pozdnyakov/followers","following_url":"https://api.github.com/users/pozdnyakov/following{/other_user}","gists_url":"https://api.github.com/users/pozdnyakov/gists{/gist_id}","starred_url":"https://api.github.com/users/pozdnyakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pozdnyakov/subscriptions","organizations_url":"https://api.github.com/users/pozdnyakov/orgs","repos_url":"https://api.github.com/users/pozdnyakov/repos","events_url":"https://api.github.com/users/pozdnyakov/events{/privacy}","received_events_url":"https://api.github.com/users/pozdnyakov/received_events","type":"User","site_admin":false},"body":"Please create XWalkRunnerWin, let's not multiply ifdefs","created_at":"2016-03-03T08:25:06Z","updated_at":"2016-03-03T08:25:06Z","html_url":"https://github.com/crosswalk-project/crosswalk/pull/3585#discussion_r54848366","pull_request_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3585","_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/54848366"},"html":{"href":"https://github.com/crosswalk-project/crosswalk/pull/3585#discussion_r54848366"},"pull_request":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3585"}}},"pull_request":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3585","id":61447118,"html_url":"https://github.com/crosswalk-project/crosswalk/pull/3585","diff_url":"https://github.com/crosswalk-project/crosswalk/pull/3585.diff","patch_url":"https://github.com/crosswalk-project/crosswalk/pull/3585.patch","issue_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3585","number":3585,"state":"open","locked":false,"title":"[Windows] Read the Google API keys from the registry to set","user":{"login":"darktears","id":739895,"avatar_url":"https://avatars.githubusercontent.com/u/739895?v=3","gravatar_id":"","url":"https://api.github.com/users/darktears","html_url":"https://github.com/darktears","followers_url":"https://api.github.com/users/darktears/followers","following_url":"https://api.github.com/users/darktears/following{/other_user}","gists_url":"https://api.github.com/users/darktears/gists{/gist_id}","starred_url":"https://api.github.com/users/darktears/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darktears/subscriptions","organizations_url":"https://api.github.com/users/darktears/orgs","repos_url":"https://api.github.com/users/darktears/repos","events_url":"https://api.github.com/users/darktears/events{/privacy}","received_events_url":"https://api.github.com/users/darktears/received_events","type":"User","site_admin":false},"body":"them as environment variables.\r\n\r\nWhen packing a crosswalk app with app-tools and a developer provided\r\ntheir keys to access the Google APIs they are going to be added\r\nin the registry. Make sure to fetch them in Crosswalk and set them\r\nas env variables so they can be used later on during requests (such\r\nas geolocation.)","created_at":"2016-03-02T18:46:03Z","updated_at":"2016-03-03T08:25:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56209a9ff286c5e582535c2ac77ce89a1284d2be","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3585/commits","review_comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3585/comments","review_comment_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3585/comments","statuses_url":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/46c4f4ae562e12f77f020a10e18a076a66325394","head":{"label":"darktears:set-env-variables-google","ref":"set-env-variables-google","sha":"46c4f4ae562e12f77f020a10e18a076a66325394","user":{"login":"darktears","id":739895,"avatar_url":"https://avatars.githubusercontent.com/u/739895?v=3","gravatar_id":"","url":"https://api.github.com/users/darktears","html_url":"https://github.com/darktears","followers_url":"https://api.github.com/users/darktears/followers","following_url":"https://api.github.com/users/darktears/following{/other_user}","gists_url":"https://api.github.com/users/darktears/gists{/gist_id}","starred_url":"https://api.github.com/users/darktears/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darktears/subscriptions","organizations_url":"https://api.github.com/users/darktears/orgs","repos_url":"https://api.github.com/users/darktears/repos","events_url":"https://api.github.com/users/darktears/events{/privacy}","received_events_url":"https://api.github.com/users/darktears/received_events","type":"User","site_admin":false},"repo":{"id":11104701,"name":"crosswalk","full_name":"darktears/crosswalk","owner":{"login":"darktears","id":739895,"avatar_url":"https://avatars.githubusercontent.com/u/739895?v=3","gravatar_id":"","url":"https://api.github.com/users/darktears","html_url":"https://github.com/darktears","followers_url":"https://api.github.com/users/darktears/followers","following_url":"https://api.github.com/users/darktears/following{/other_user}","gists_url":"https://api.github.com/users/darktears/gists{/gist_id}","starred_url":"https://api.github.com/users/darktears/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darktears/subscriptions","organizations_url":"https://api.github.com/users/darktears/orgs","repos_url":"https://api.github.com/users/darktears/repos","events_url":"https://api.github.com/users/darktears/events{/privacy}","received_events_url":"https://api.github.com/users/darktears/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/darktears/crosswalk","description":"","fork":true,"url":"https://api.github.com/repos/darktears/crosswalk","forks_url":"https://api.github.com/repos/darktears/crosswalk/forks","keys_url":"https://api.github.com/repos/darktears/crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darktears/crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darktears/crosswalk/teams","hooks_url":"https://api.github.com/repos/darktears/crosswalk/hooks","issue_events_url":"https://api.github.com/repos/darktears/crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/darktears/crosswalk/events","assignees_url":"https://api.github.com/repos/darktears/crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/darktears/crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/darktears/crosswalk/tags","blobs_url":"https://api.github.com/repos/darktears/crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darktears/crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darktears/crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/darktears/crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darktears/crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/darktears/crosswalk/languages","stargazers_url":"https://api.github.com/repos/darktears/crosswalk/stargazers","contributors_url":"https://api.github.com/repos/darktears/crosswalk/contributors","subscribers_url":"https://api.github.com/repos/darktears/crosswalk/subscribers","subscription_url":"https://api.github.com/repos/darktears/crosswalk/subscription","commits_url":"https://api.github.com/repos/darktears/crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/darktears/crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/darktears/crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/darktears/crosswalk/issues/comments{/number}","contents_url":"https://api.github.com/repos/darktears/crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/darktears/crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darktears/crosswalk/merges","archive_url":"https://api.github.com/repos/darktears/crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darktears/crosswalk/downloads","issues_url":"https://api.github.com/repos/darktears/crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/darktears/crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/darktears/crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/darktears/crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darktears/crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/darktears/crosswalk/releases{/id}","deployments_url":"https://api.github.com/repos/darktears/crosswalk/deployments","created_at":"2013-07-01T19:28:47Z","updated_at":"2015-03-27T19:28:40Z","pushed_at":"2016-03-02T18:45:23Z","git_url":"git://github.com/darktears/crosswalk.git","ssh_url":"git@github.com:darktears/crosswalk.git","clone_url":"https://github.com/darktears/crosswalk.git","svn_url":"https://github.com/darktears/crosswalk","homepage":"","size":15228,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crosswalk-project:master","ref":"master","sha":"7cbe3739c8217edd99a568daf6e3de23fa9c70eb","user":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=3","gravatar_id":"","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"repo":{"id":9207280,"name":"crosswalk","full_name":"crosswalk-project/crosswalk","owner":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=3","gravatar_id":"","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crosswalk-project/crosswalk","description":"","fork":false,"url":"https://api.github.com/repos/crosswalk-project/crosswalk","forks_url":"https://api.github.com/repos/crosswalk-project/crosswalk/forks","keys_url":"https://api.github.com/repos/crosswalk-project/crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crosswalk-project/crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crosswalk-project/crosswalk/teams","hooks_url":"https://api.github.com/repos/crosswalk-project/crosswalk/hooks","issue_events_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/crosswalk-project/crosswalk/events","assignees_url":"https://api.github.com/repos/crosswalk-project/crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/crosswalk-project/crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/crosswalk-project/crosswalk/tags","blobs_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/crosswalk-project/crosswalk/languages","stargazers_url":"https://api.github.com/repos/crosswalk-project/crosswalk/stargazers","contributors_url":"https://api.github.com/repos/crosswalk-project/crosswalk/contributors","subscribers_url":"https://api.github.com/repos/crosswalk-project/crosswalk/subscribers","subscription_url":"https://api.github.com/repos/crosswalk-project/crosswalk/subscription","commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/comments{/number}","contents_url":"https://api.github.com/repos/crosswalk-project/crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/crosswalk-project/crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crosswalk-project/crosswalk/merges","archive_url":"https://api.github.com/repos/crosswalk-project/crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crosswalk-project/crosswalk/downloads","issues_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/crosswalk-project/crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/crosswalk-project/crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crosswalk-project/crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/crosswalk-project/crosswalk/releases{/id}","deployments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/deployments","created_at":"2013-04-03T23:30:12Z","updated_at":"2016-03-02T07:17:44Z","pushed_at":"2016-03-02T18:46:04Z","git_url":"git://github.com/crosswalk-project/crosswalk.git","ssh_url":"git@github.com:crosswalk-project/crosswalk.git","clone_url":"https://github.com/crosswalk-project/crosswalk.git","svn_url":"https://github.com/crosswalk-project/crosswalk","homepage":"https://crosswalk-project.org/","size":117707,"stargazers_count":1291,"watchers_count":1291,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":344,"mirror_url":null,"open_issues_count":109,"forks":344,"open_issues":109,"watchers":1291,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3585"},"html":{"href":"https://github.com/crosswalk-project/crosswalk/pull/3585"},"issue":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3585"},"comments":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3585/comments"},"review_comments":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3585/comments"},"review_comment":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3585/commits"},"statuses":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/46c4f4ae562e12f77f020a10e18a076a66325394"}}}}