{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/72214070","id":72214070,"diff_hunk":"@@ -564,6 +564,14 @@ ifneq (,$(filter random,$(USEMODULE)))\n         USEMODULE += prng_tinymt32\n     endif\n \n+    ifneq (,$(filter prng_fortuna,$(USEMODULE)))\n+        USEMODULE += fortuna\n+        USEMODULE += hashes\n+        USEMODULE += crypto\n+        USEMODULE += xtimer\n+        CFLAGS += -DCRYPTO_AES ","path":"Makefile.dep","position":9,"original_position":9,"commit_id":"cdf55d6d83c25102acaaf2ed985ffdb9855f75fb","original_commit_id":"cdf55d6d83c25102acaaf2ed985ffdb9855f75fb","user":{"login":"BytesGalore","id":3903215,"avatar_url":"https://avatars.githubusercontent.com/u/3903215?v=3","gravatar_id":"","url":"https://api.github.com/users/BytesGalore","html_url":"https://github.com/BytesGalore","followers_url":"https://api.github.com/users/BytesGalore/followers","following_url":"https://api.github.com/users/BytesGalore/following{/other_user}","gists_url":"https://api.github.com/users/BytesGalore/gists{/gist_id}","starred_url":"https://api.github.com/users/BytesGalore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BytesGalore/subscriptions","organizations_url":"https://api.github.com/users/BytesGalore/orgs","repos_url":"https://api.github.com/users/BytesGalore/repos","events_url":"https://api.github.com/users/BytesGalore/events{/privacy}","received_events_url":"https://api.github.com/users/BytesGalore/received_events","type":"User","site_admin":false},"body":"I wonder if it would be more intuitive to set the CFLAG in `sys/random/Makefile`,\r\nsince here we only handle dependencies.\r\nBeside, please remove the extra whitespace behind the flag.\r\n","created_at":"2016-07-26T09:15:13Z","updated_at":"2016-07-26T09:15:13Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/5675#discussion_r72214070","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/5675","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/72214070"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/5675#discussion_r72214070"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/5675"}}},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/5675","id":78388327,"html_url":"https://github.com/RIOT-OS/RIOT/pull/5675","diff_url":"https://github.com/RIOT-OS/RIOT/pull/5675.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/5675.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/5675","number":5675,"state":"open","locked":false,"title":"sys: random: fortuna csprng","user":{"login":"basilfx","id":815976,"avatar_url":"https://avatars.githubusercontent.com/u/815976?v=3","gravatar_id":"","url":"https://api.github.com/users/basilfx","html_url":"https://github.com/basilfx","followers_url":"https://api.github.com/users/basilfx/followers","following_url":"https://api.github.com/users/basilfx/following{/other_user}","gists_url":"https://api.github.com/users/basilfx/gists{/gist_id}","starred_url":"https://api.github.com/users/basilfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basilfx/subscriptions","organizations_url":"https://api.github.com/users/basilfx/orgs","repos_url":"https://api.github.com/users/basilfx/repos","events_url":"https://api.github.com/users/basilfx/events{/privacy}","received_events_url":"https://api.github.com/users/basilfx/received_events","type":"User","site_admin":false},"body":"This PR adds support for the [Fortuna Computationally Secure PRNG](https://www.schneier.com/academic/paperfiles/fortuna.pdf). I had been working on this because of [this application note](https://www.silabs.com/Support%20Documents/TechnicalDocs/AN0806.pdf). I have based this on [this code](https://github.com/blin00/os/blob/master/src/random.c), but fully refactored it for RIOT-OS, while comparing it to the textbook implementation.\r\n\r\nThis is not your daily PRNG, as it is memory hungry. The internal state requires N * `sha256_context_t`, where N is typically >= 16, or >= 2.5KB RAM. I wasn't sure to PR this, but after the summit I thought: why not? After all, it fits perfectly in the discussion of #5659. \r\n\r\nIt is a WIP, because the reference implementation needs AES-256 (#4798, #5429). Now it uses AES-128, which works fine. Furthermore, initialization of the PRNG requires a seed >> 32 bits, so I cheat a bit. #4294 would help.\r\n\r\nI'm planning to do some offline testing, eventually.","created_at":"2016-07-21T21:12:24Z","updated_at":"2016-07-26T09:15:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bee375b233dc4545e59e4107c55ed11b7088e6fd","assignee":{"login":"kaspar030","id":4679640,"avatar_url":"https://avatars.githubusercontent.com/u/4679640?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspar030","html_url":"https://github.com/kaspar030","followers_url":"https://api.github.com/users/kaspar030/followers","following_url":"https://api.github.com/users/kaspar030/following{/other_user}","gists_url":"https://api.github.com/users/kaspar030/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspar030/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspar030/subscriptions","organizations_url":"https://api.github.com/users/kaspar030/orgs","repos_url":"https://api.github.com/users/kaspar030/repos","events_url":"https://api.github.com/users/kaspar030/events{/privacy}","received_events_url":"https://api.github.com/users/kaspar030/received_events","type":"User","site_admin":false},"assignees":[{"login":"kaspar030","id":4679640,"avatar_url":"https://avatars.githubusercontent.com/u/4679640?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspar030","html_url":"https://github.com/kaspar030","followers_url":"https://api.github.com/users/kaspar030/followers","following_url":"https://api.github.com/users/kaspar030/following{/other_user}","gists_url":"https://api.github.com/users/kaspar030/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspar030/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspar030/subscriptions","organizations_url":"https://api.github.com/users/kaspar030/orgs","repos_url":"https://api.github.com/users/kaspar030/repos","events_url":"https://api.github.com/users/kaspar030/events{/privacy}","received_events_url":"https://api.github.com/users/kaspar030/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/5675/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/5675/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/5675/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/cdf55d6d83c25102acaaf2ed985ffdb9855f75fb","head":{"label":"basilfx:feature/prng_fortuna","ref":"feature/prng_fortuna","sha":"cdf55d6d83c25102acaaf2ed985ffdb9855f75fb","user":{"login":"basilfx","id":815976,"avatar_url":"https://avatars.githubusercontent.com/u/815976?v=3","gravatar_id":"","url":"https://api.github.com/users/basilfx","html_url":"https://github.com/basilfx","followers_url":"https://api.github.com/users/basilfx/followers","following_url":"https://api.github.com/users/basilfx/following{/other_user}","gists_url":"https://api.github.com/users/basilfx/gists{/gist_id}","starred_url":"https://api.github.com/users/basilfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basilfx/subscriptions","organizations_url":"https://api.github.com/users/basilfx/orgs","repos_url":"https://api.github.com/users/basilfx/repos","events_url":"https://api.github.com/users/basilfx/events{/privacy}","received_events_url":"https://api.github.com/users/basilfx/received_events","type":"User","site_admin":false},"repo":{"id":45756594,"name":"RIOT","full_name":"basilfx/RIOT","owner":{"login":"basilfx","id":815976,"avatar_url":"https://avatars.githubusercontent.com/u/815976?v=3","gravatar_id":"","url":"https://api.github.com/users/basilfx","html_url":"https://github.com/basilfx","followers_url":"https://api.github.com/users/basilfx/followers","following_url":"https://api.github.com/users/basilfx/following{/other_user}","gists_url":"https://api.github.com/users/basilfx/gists{/gist_id}","starred_url":"https://api.github.com/users/basilfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basilfx/subscriptions","organizations_url":"https://api.github.com/users/basilfx/orgs","repos_url":"https://api.github.com/users/basilfx/repos","events_url":"https://api.github.com/users/basilfx/events{/privacy}","received_events_url":"https://api.github.com/users/basilfx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/basilfx/RIOT","description":"RIOT -  The friendly OS for IoT","fork":true,"url":"https://api.github.com/repos/basilfx/RIOT","forks_url":"https://api.github.com/repos/basilfx/RIOT/forks","keys_url":"https://api.github.com/repos/basilfx/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basilfx/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basilfx/RIOT/teams","hooks_url":"https://api.github.com/repos/basilfx/RIOT/hooks","issue_events_url":"https://api.github.com/repos/basilfx/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/basilfx/RIOT/events","assignees_url":"https://api.github.com/repos/basilfx/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/basilfx/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/basilfx/RIOT/tags","blobs_url":"https://api.github.com/repos/basilfx/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basilfx/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basilfx/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/basilfx/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basilfx/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/basilfx/RIOT/languages","stargazers_url":"https://api.github.com/repos/basilfx/RIOT/stargazers","contributors_url":"https://api.github.com/repos/basilfx/RIOT/contributors","subscribers_url":"https://api.github.com/repos/basilfx/RIOT/subscribers","subscription_url":"https://api.github.com/repos/basilfx/RIOT/subscription","commits_url":"https://api.github.com/repos/basilfx/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/basilfx/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/basilfx/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/basilfx/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/basilfx/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/basilfx/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basilfx/RIOT/merges","archive_url":"https://api.github.com/repos/basilfx/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basilfx/RIOT/downloads","issues_url":"https://api.github.com/repos/basilfx/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/basilfx/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/basilfx/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/basilfx/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basilfx/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/basilfx/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/basilfx/RIOT/deployments","created_at":"2015-11-07T22:01:27Z","updated_at":"2016-01-31T00:01:26Z","pushed_at":"2016-07-22T16:22:54Z","git_url":"git://github.com/basilfx/RIOT.git","ssh_url":"git@github.com:basilfx/RIOT.git","clone_url":"https://github.com/basilfx/RIOT.git","svn_url":"https://github.com/basilfx/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":29114,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"3e0bac7acb60714f28d76559aa25cd8c60e01fbf","user":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/RIOT-OS/RIOT/deployments","created_at":"2012-12-29T20:38:40Z","updated_at":"2016-07-25T23:37:22Z","pushed_at":"2016-07-26T08:19:00Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":95776,"stargazers_count":851,"watchers_count":851,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":586,"mirror_url":null,"open_issues_count":520,"forks":586,"open_issues":520,"watchers":851,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/5675"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/5675"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/5675"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/5675/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/5675/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/5675/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/cdf55d6d83c25102acaaf2ed985ffdb9855f75fb"}}}}
{"actor":{"display_login":"BytesGalore"}}