{"action":"created","issue":{"url":"https://api.github.com/repos/varnishcache/varnish-cache/issues/1961","repository_url":"https://api.github.com/repos/varnishcache/varnish-cache","labels_url":"https://api.github.com/repos/varnishcache/varnish-cache/issues/1961/labels{/name}","comments_url":"https://api.github.com/repos/varnishcache/varnish-cache/issues/1961/comments","events_url":"https://api.github.com/repos/varnishcache/varnish-cache/issues/1961/events","html_url":"https://github.com/varnishcache/varnish-cache/pull/1961","id":156520739,"number":1961,"title":"Don't allow partial allocation of stevedore memory for ESI","user":{"login":"hermunn","id":17638537,"avatar_url":"https://avatars.githubusercontent.com/u/17638537?v=3","gravatar_id":"","url":"https://api.github.com/users/hermunn","html_url":"https://github.com/hermunn","followers_url":"https://api.github.com/users/hermunn/followers","following_url":"https://api.github.com/users/hermunn/following{/other_user}","gists_url":"https://api.github.com/users/hermunn/gists{/gist_id}","starred_url":"https://api.github.com/users/hermunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hermunn/subscriptions","organizations_url":"https://api.github.com/users/hermunn/orgs","repos_url":"https://api.github.com/users/hermunn/repos","events_url":"https://api.github.com/users/hermunn/events{/privacy}","received_events_url":"https://api.github.com/users/hermunn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-24T14:21:28Z","updated_at":"2016-05-24T14:35:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/varnishcache/varnish-cache/pulls/1961","html_url":"https://github.com/varnishcache/varnish-cache/pull/1961","diff_url":"https://github.com/varnishcache/varnish-cache/pull/1961.diff","patch_url":"https://github.com/varnishcache/varnish-cache/pull/1961.patch"},"body":"When allocating ESI memory through `objallocwithnuke`, tell the sevedore\r\nin `storage_simple.c` that getting less than all is not interesting. At\r\nthe same time, eliminate the possibility of getting less memory than\r\nrequested in `sml_trimstore`.\r\n\r\nThere is a competing pull request, #1946, that solves the same problem in a different way.\r\n\r\nA different flag, MORE_MEM_ALLOCATED_IS_OK (similar to LESS_MEM_ALLOCED_IS_OK), signaling that getting more memory the requested is OK, has been proposed. However, I think this is artificial for the simple stevedores.\r\n\r\nFixes #1941"},"comment":{"url":"https://api.github.com/repos/varnishcache/varnish-cache/issues/comments/221291042","html_url":"https://github.com/varnishcache/varnish-cache/pull/1961#issuecomment-221291042","issue_url":"https://api.github.com/repos/varnishcache/varnish-cache/issues/1961","id":221291042,"user":{"login":"fgsch","id":241785,"avatar_url":"https://avatars.githubusercontent.com/u/241785?v=3","gravatar_id":"","url":"https://api.github.com/users/fgsch","html_url":"https://github.com/fgsch","followers_url":"https://api.github.com/users/fgsch/followers","following_url":"https://api.github.com/users/fgsch/following{/other_user}","gists_url":"https://api.github.com/users/fgsch/gists{/gist_id}","starred_url":"https://api.github.com/users/fgsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgsch/subscriptions","organizations_url":"https://api.github.com/users/fgsch/orgs","repos_url":"https://api.github.com/users/fgsch/repos","events_url":"https://api.github.com/users/fgsch/events{/privacy}","received_events_url":"https://api.github.com/users/fgsch/received_events","type":"User","site_admin":false},"created_at":"2016-05-24T14:35:34Z","updated_at":"2016-05-24T14:35:34Z","body":"nitpick: don't forget the () around the returned values (aka keep the style)."}}
{"actor":{"display_login":"fgsch"}}