{"action":"created","comment":{"url":"https://api.github.com/repos/clojure-emacs/cider/pulls/comments/59844637","id":59844637,"diff_hunk":"@@ -1,33 +1,55 @@\n+(require 'buttercup)\n (require 'cider)\n (require 'cider-stacktrace)\n-(require 'ert)\n \n ;;; cider-stacktrace tests\n \n ;;; Internal/Middleware error suppression\n-(ert-deftest test-cider-stacktrace-some-suppressed-errors-p ()\n-  (let ((cider-stacktrace-suppressed-errors '()))\n-    (should-not (cider-stacktrace-some-suppressed-errors-p '(\"a\")))\n-    (should-not (cider-stacktrace-some-suppressed-errors-p '())))\n-\n-  (let ((cider-stacktrace-suppressed-errors '(\"a\" \"b\" \"c\" \"d\")))\n-    (should (equal '(\"a\") (cider-stacktrace-some-suppressed-errors-p '(\"a\"))))\n-    (should (equal '(\"a\" \"c\") (cider-stacktrace-some-suppressed-errors-p '(\"a\" \"c\" \"e\"))))\n-    (should-not (cider-stacktrace-some-suppressed-errors-p '(\"g\" \"f\" \"e\")))))\n-\n-(ert-deftest test-cider-stacktrace-suppress-error ()\n-  (let ((cider-stacktrace-suppressed-errors '(\"a\" \"b\" \"c\")))\n-    (should-not (cl-set-exclusive-or '(\"a\" \"b\" \"z\" \"c\") (cider-stacktrace-suppress-error \"z\") :test 'equal))))\n-\n-(ert-deftest test-cider-stacktrace-promote-error ()\n-  (let ((cider-stacktrace-suppressed-errors '(\"a\" \"b\" \"x\" \"c\")))\n-    (should-not (cl-set-exclusive-or '(\"a\" \"b\" \"c\") (cider-stacktrace-promote-error \"x\")\n-                                     :test 'equal))))\n-\n-(ert-deftest test-cider-stacktrace-suppressed-error-p ()\n-  (let ((cider-stacktrace-suppressed-errors '(\"a\" \"b\" \"g\" \"j\")))\n-    (should (cider-stacktrace-suppressed-error-p \"a\"))\n-    (should (cider-stacktrace-suppressed-error-p \"b\"))\n-    (should (cider-stacktrace-suppressed-error-p \"g\"))\n-    (should (cider-stacktrace-suppressed-error-p \"j\"))\n-    (should-not (cider-stacktrace-suppressed-error-p \"c\"))))\n+(describe \"cider-stacktrace-some-suppressed-errors-p\"\n+  :var (cider-stacktrace-suppressed-errors)\n+\n+  (describe \"identifies errors associated with supressed errors\"","path":"test/cider-stacktrace-tests.el","position":null,"original_position":38,"commit_id":"2021718e48e2fd69afc7258bc489e58182c0e446","original_commit_id":"d3e2b111140037914e4efbecdaf3b5a03e6c1b16","user":{"login":"cskksc","id":5201497,"avatar_url":"https://avatars.githubusercontent.com/u/5201497?v=3","gravatar_id":"","url":"https://api.github.com/users/cskksc","html_url":"https://github.com/cskksc","followers_url":"https://api.github.com/users/cskksc/followers","following_url":"https://api.github.com/users/cskksc/following{/other_user}","gists_url":"https://api.github.com/users/cskksc/gists{/gist_id}","starred_url":"https://api.github.com/users/cskksc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cskksc/subscriptions","organizations_url":"https://api.github.com/users/cskksc/orgs","repos_url":"https://api.github.com/users/cskksc/repos","events_url":"https://api.github.com/users/cskksc/events{/privacy}","received_events_url":"https://api.github.com/users/cskksc/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2016-04-15T08:49:12Z","updated_at":"2016-04-15T08:49:12Z","html_url":"https://github.com/clojure-emacs/cider/pull/1676#discussion_r59844637","pull_request_url":"https://api.github.com/repos/clojure-emacs/cider/pulls/1676","_links":{"self":{"href":"https://api.github.com/repos/clojure-emacs/cider/pulls/comments/59844637"},"html":{"href":"https://github.com/clojure-emacs/cider/pull/1676#discussion_r59844637"},"pull_request":{"href":"https://api.github.com/repos/clojure-emacs/cider/pulls/1676"}}},"pull_request":{"url":"https://api.github.com/repos/clojure-emacs/cider/pulls/1676","id":66520136,"html_url":"https://github.com/clojure-emacs/cider/pull/1676","diff_url":"https://github.com/clojure-emacs/cider/pull/1676.diff","patch_url":"https://github.com/clojure-emacs/cider/pull/1676.patch","issue_url":"https://api.github.com/repos/clojure-emacs/cider/issues/1676","number":1676,"state":"open","locked":false,"title":"Migrate some tests to buttercup.","user":{"login":"cskksc","id":5201497,"avatar_url":"https://avatars.githubusercontent.com/u/5201497?v=3","gravatar_id":"","url":"https://api.github.com/users/cskksc","html_url":"https://github.com/cskksc","followers_url":"https://api.github.com/users/cskksc/followers","following_url":"https://api.github.com/users/cskksc/following{/other_user}","gists_url":"https://api.github.com/users/cskksc/gists{/gist_id}","starred_url":"https://api.github.com/users/cskksc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cskksc/subscriptions","organizations_url":"https://api.github.com/users/cskksc/orgs","repos_url":"https://api.github.com/users/cskksc/repos","events_url":"https://api.github.com/users/cskksc/events{/privacy}","received_events_url":"https://api.github.com/users/cskksc/received_events","type":"User","site_admin":false},"body":"Before submitting a PR make sure the following things have been done (and denote this\r\nby checking the relevant checkboxes):\r\n\r\n- [ ] The commits are consistent with our [contribution guidelines](CONTRIBUTING.md)\r\n- [ ] You've added tests (if possible) to cover your change(s)\r\n- [x] All tests are passing (`make test`)\r\n- [ ] The new code is not generating bytecode or `M-x checkdoc` warnings\r\n- [ ] You've updated the changelog (if adding/changing user-visible functionality)\r\n- [ ] You've updated the readme (if adding/changing user-visible functionality)\r\n- [ ] You've updated the refcard (if you made changes to the commands listed there)\r\n\r\nThanks!","created_at":"2016-04-14T17:09:06Z","updated_at":"2016-04-15T08:49:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e67b869fc1ddf9992b0cf19991fd1ab4104669be","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/clojure-emacs/cider/pulls/1676/commits","review_comments_url":"https://api.github.com/repos/clojure-emacs/cider/pulls/1676/comments","review_comment_url":"https://api.github.com/repos/clojure-emacs/cider/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clojure-emacs/cider/issues/1676/comments","statuses_url":"https://api.github.com/repos/clojure-emacs/cider/statuses/2021718e48e2fd69afc7258bc489e58182c0e446","head":{"label":"cskksc:feature/buttercup","ref":"feature/buttercup","sha":"2021718e48e2fd69afc7258bc489e58182c0e446","user":{"login":"cskksc","id":5201497,"avatar_url":"https://avatars.githubusercontent.com/u/5201497?v=3","gravatar_id":"","url":"https://api.github.com/users/cskksc","html_url":"https://github.com/cskksc","followers_url":"https://api.github.com/users/cskksc/followers","following_url":"https://api.github.com/users/cskksc/following{/other_user}","gists_url":"https://api.github.com/users/cskksc/gists{/gist_id}","starred_url":"https://api.github.com/users/cskksc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cskksc/subscriptions","organizations_url":"https://api.github.com/users/cskksc/orgs","repos_url":"https://api.github.com/users/cskksc/repos","events_url":"https://api.github.com/users/cskksc/events{/privacy}","received_events_url":"https://api.github.com/users/cskksc/received_events","type":"User","site_admin":false},"repo":{"id":54762226,"name":"cider","full_name":"cskksc/cider","owner":{"login":"cskksc","id":5201497,"avatar_url":"https://avatars.githubusercontent.com/u/5201497?v=3","gravatar_id":"","url":"https://api.github.com/users/cskksc","html_url":"https://github.com/cskksc","followers_url":"https://api.github.com/users/cskksc/followers","following_url":"https://api.github.com/users/cskksc/following{/other_user}","gists_url":"https://api.github.com/users/cskksc/gists{/gist_id}","starred_url":"https://api.github.com/users/cskksc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cskksc/subscriptions","organizations_url":"https://api.github.com/users/cskksc/orgs","repos_url":"https://api.github.com/users/cskksc/repos","events_url":"https://api.github.com/users/cskksc/events{/privacy}","received_events_url":"https://api.github.com/users/cskksc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cskksc/cider","description":"The Clojure Interactive Development Environment that Rocks for Emacs","fork":true,"url":"https://api.github.com/repos/cskksc/cider","forks_url":"https://api.github.com/repos/cskksc/cider/forks","keys_url":"https://api.github.com/repos/cskksc/cider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cskksc/cider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cskksc/cider/teams","hooks_url":"https://api.github.com/repos/cskksc/cider/hooks","issue_events_url":"https://api.github.com/repos/cskksc/cider/issues/events{/number}","events_url":"https://api.github.com/repos/cskksc/cider/events","assignees_url":"https://api.github.com/repos/cskksc/cider/assignees{/user}","branches_url":"https://api.github.com/repos/cskksc/cider/branches{/branch}","tags_url":"https://api.github.com/repos/cskksc/cider/tags","blobs_url":"https://api.github.com/repos/cskksc/cider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cskksc/cider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cskksc/cider/git/refs{/sha}","trees_url":"https://api.github.com/repos/cskksc/cider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cskksc/cider/statuses/{sha}","languages_url":"https://api.github.com/repos/cskksc/cider/languages","stargazers_url":"https://api.github.com/repos/cskksc/cider/stargazers","contributors_url":"https://api.github.com/repos/cskksc/cider/contributors","subscribers_url":"https://api.github.com/repos/cskksc/cider/subscribers","subscription_url":"https://api.github.com/repos/cskksc/cider/subscription","commits_url":"https://api.github.com/repos/cskksc/cider/commits{/sha}","git_commits_url":"https://api.github.com/repos/cskksc/cider/git/commits{/sha}","comments_url":"https://api.github.com/repos/cskksc/cider/comments{/number}","issue_comment_url":"https://api.github.com/repos/cskksc/cider/issues/comments{/number}","contents_url":"https://api.github.com/repos/cskksc/cider/contents/{+path}","compare_url":"https://api.github.com/repos/cskksc/cider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cskksc/cider/merges","archive_url":"https://api.github.com/repos/cskksc/cider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cskksc/cider/downloads","issues_url":"https://api.github.com/repos/cskksc/cider/issues{/number}","pulls_url":"https://api.github.com/repos/cskksc/cider/pulls{/number}","milestones_url":"https://api.github.com/repos/cskksc/cider/milestones{/number}","notifications_url":"https://api.github.com/repos/cskksc/cider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cskksc/cider/labels{/name}","releases_url":"https://api.github.com/repos/cskksc/cider/releases{/id}","deployments_url":"https://api.github.com/repos/cskksc/cider/deployments","created_at":"2016-03-26T04:17:18Z","updated_at":"2016-03-26T04:17:19Z","pushed_at":"2016-04-15T08:45:27Z","git_url":"git://github.com/cskksc/cider.git","ssh_url":"git@github.com:cskksc/cider.git","clone_url":"https://github.com/cskksc/cider.git","svn_url":"https://github.com/cskksc/cider","homepage":"","size":8630,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"clojure-emacs:master","ref":"master","sha":"855a7f456baf57d47fdd9b67428c7331b4e9b6b5","user":{"login":"clojure-emacs","id":5080083,"avatar_url":"https://avatars.githubusercontent.com/u/5080083?v=3","gravatar_id":"","url":"https://api.github.com/users/clojure-emacs","html_url":"https://github.com/clojure-emacs","followers_url":"https://api.github.com/users/clojure-emacs/followers","following_url":"https://api.github.com/users/clojure-emacs/following{/other_user}","gists_url":"https://api.github.com/users/clojure-emacs/gists{/gist_id}","starred_url":"https://api.github.com/users/clojure-emacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clojure-emacs/subscriptions","organizations_url":"https://api.github.com/users/clojure-emacs/orgs","repos_url":"https://api.github.com/users/clojure-emacs/repos","events_url":"https://api.github.com/users/clojure-emacs/events{/privacy}","received_events_url":"https://api.github.com/users/clojure-emacs/received_events","type":"Organization","site_admin":false},"repo":{"id":4118920,"name":"cider","full_name":"clojure-emacs/cider","owner":{"login":"clojure-emacs","id":5080083,"avatar_url":"https://avatars.githubusercontent.com/u/5080083?v=3","gravatar_id":"","url":"https://api.github.com/users/clojure-emacs","html_url":"https://github.com/clojure-emacs","followers_url":"https://api.github.com/users/clojure-emacs/followers","following_url":"https://api.github.com/users/clojure-emacs/following{/other_user}","gists_url":"https://api.github.com/users/clojure-emacs/gists{/gist_id}","starred_url":"https://api.github.com/users/clojure-emacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clojure-emacs/subscriptions","organizations_url":"https://api.github.com/users/clojure-emacs/orgs","repos_url":"https://api.github.com/users/clojure-emacs/repos","events_url":"https://api.github.com/users/clojure-emacs/events{/privacy}","received_events_url":"https://api.github.com/users/clojure-emacs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clojure-emacs/cider","description":"The Clojure Interactive Development Environment that Rocks for Emacs","fork":false,"url":"https://api.github.com/repos/clojure-emacs/cider","forks_url":"https://api.github.com/repos/clojure-emacs/cider/forks","keys_url":"https://api.github.com/repos/clojure-emacs/cider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clojure-emacs/cider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clojure-emacs/cider/teams","hooks_url":"https://api.github.com/repos/clojure-emacs/cider/hooks","issue_events_url":"https://api.github.com/repos/clojure-emacs/cider/issues/events{/number}","events_url":"https://api.github.com/repos/clojure-emacs/cider/events","assignees_url":"https://api.github.com/repos/clojure-emacs/cider/assignees{/user}","branches_url":"https://api.github.com/repos/clojure-emacs/cider/branches{/branch}","tags_url":"https://api.github.com/repos/clojure-emacs/cider/tags","blobs_url":"https://api.github.com/repos/clojure-emacs/cider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clojure-emacs/cider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clojure-emacs/cider/git/refs{/sha}","trees_url":"https://api.github.com/repos/clojure-emacs/cider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clojure-emacs/cider/statuses/{sha}","languages_url":"https://api.github.com/repos/clojure-emacs/cider/languages","stargazers_url":"https://api.github.com/repos/clojure-emacs/cider/stargazers","contributors_url":"https://api.github.com/repos/clojure-emacs/cider/contributors","subscribers_url":"https://api.github.com/repos/clojure-emacs/cider/subscribers","subscription_url":"https://api.github.com/repos/clojure-emacs/cider/subscription","commits_url":"https://api.github.com/repos/clojure-emacs/cider/commits{/sha}","git_commits_url":"https://api.github.com/repos/clojure-emacs/cider/git/commits{/sha}","comments_url":"https://api.github.com/repos/clojure-emacs/cider/comments{/number}","issue_comment_url":"https://api.github.com/repos/clojure-emacs/cider/issues/comments{/number}","contents_url":"https://api.github.com/repos/clojure-emacs/cider/contents/{+path}","compare_url":"https://api.github.com/repos/clojure-emacs/cider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clojure-emacs/cider/merges","archive_url":"https://api.github.com/repos/clojure-emacs/cider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clojure-emacs/cider/downloads","issues_url":"https://api.github.com/repos/clojure-emacs/cider/issues{/number}","pulls_url":"https://api.github.com/repos/clojure-emacs/cider/pulls{/number}","milestones_url":"https://api.github.com/repos/clojure-emacs/cider/milestones{/number}","notifications_url":"https://api.github.com/repos/clojure-emacs/cider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clojure-emacs/cider/labels{/name}","releases_url":"https://api.github.com/repos/clojure-emacs/cider/releases{/id}","deployments_url":"https://api.github.com/repos/clojure-emacs/cider/deployments","created_at":"2012-04-23T22:53:44Z","updated_at":"2016-04-14T22:58:09Z","pushed_at":"2016-04-15T08:45:27Z","git_url":"git://github.com/clojure-emacs/cider.git","ssh_url":"git@github.com:clojure-emacs/cider.git","clone_url":"https://github.com/clojure-emacs/cider.git","svn_url":"https://github.com/clojure-emacs/cider","homepage":"https://cider.readthedocs.org","size":9530,"stargazers_count":1740,"watchers_count":1740,"language":"Emacs Lisp","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":310,"mirror_url":null,"open_issues_count":81,"forks":310,"open_issues":81,"watchers":1740,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clojure-emacs/cider/pulls/1676"},"html":{"href":"https://github.com/clojure-emacs/cider/pull/1676"},"issue":{"href":"https://api.github.com/repos/clojure-emacs/cider/issues/1676"},"comments":{"href":"https://api.github.com/repos/clojure-emacs/cider/issues/1676/comments"},"review_comments":{"href":"https://api.github.com/repos/clojure-emacs/cider/pulls/1676/comments"},"review_comment":{"href":"https://api.github.com/repos/clojure-emacs/cider/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clojure-emacs/cider/pulls/1676/commits"},"statuses":{"href":"https://api.github.com/repos/clojure-emacs/cider/statuses/2021718e48e2fd69afc7258bc489e58182c0e446"}}}}