{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/85452958","pull_request_review_id":6169563,"id":85452958,"diff_hunk":"@@ -1414,8 +1412,13 @@ type Toleration struct {\n \t// Effect indicates the taint effect to match. Empty means match all taint effects.\n \t// When specified, allowed values are NoSchedule and PreferNoSchedule.\n \tEffect TaintEffect `json:\"effect,omitempty\"`\n-\t// TODO: For forgiveness (#1574), we'd eventually add at least a grace period\n-\t// here, and possibly an occurrence threshold and period.\n+\t// ForgivenessSeconds Represents the period of time the toleration tolerates the taint.","path":"pkg/api/types.go","position":21,"original_position":21,"commit_id":"d6b78a7293bfe2fee45d3fb0115f34c5a4d08e65","original_commit_id":"d6b78a7293bfe2fee45d3fb0115f34c5a4d08e65","user":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"body":"For the record, I don't want to unnecessarily introduce a new distinct concept. It should just be a property of the toleration.\r\n\r\nAlso, AFAIK, we currently don't have any fields containing the substring \"duration\". Let's also not introduce another time-related noun if at all possible.\r\n\r\nFWIW, though it's not very relevant, we are planning to represent all disruptions as taints, and may introduce a frequency bound in the future. An example where frequency would be useful: it may be ok for my pod to tolerate a 30-minute disruption once a day, but not every 45 minutes.\r\n","created_at":"2016-10-28T00:09:50Z","updated_at":"2016-10-28T00:09:50Z","html_url":"https://github.com/kubernetes/kubernetes/pull/30191#discussion_r85452958","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30191","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/85452958"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/30191#discussion_r85452958"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30191"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30191","id":80357458,"html_url":"https://github.com/kubernetes/kubernetes/pull/30191","diff_url":"https://github.com/kubernetes/kubernetes/pull/30191.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/30191.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30191","number":30191,"state":"closed","locked":false,"title":"Implement forgiveness","user":{"login":"Dingshujie","id":13744637,"avatar_url":"https://avatars.githubusercontent.com/u/13744637?v=3","gravatar_id":"","url":"https://api.github.com/users/Dingshujie","html_url":"https://github.com/Dingshujie","followers_url":"https://api.github.com/users/Dingshujie/followers","following_url":"https://api.github.com/users/Dingshujie/following{/other_user}","gists_url":"https://api.github.com/users/Dingshujie/gists{/gist_id}","starred_url":"https://api.github.com/users/Dingshujie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dingshujie/subscriptions","organizations_url":"https://api.github.com/users/Dingshujie/orgs","repos_url":"https://api.github.com/users/Dingshujie/repos","events_url":"https://api.github.com/users/Dingshujie/events{/privacy}","received_events_url":"https://api.github.com/users/Dingshujie/received_events","type":"User","site_admin":false},"body":" e2e test will not be included in this PR\r\n@kevin-wangzefeng @davidopp\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30191)\n<!-- Reviewable:end -->\n","created_at":"2016-08-07T03:48:01Z","updated_at":"2016-10-28T00:09:50Z","closed_at":"2016-10-27T17:52:22Z","merged_at":null,"merge_commit_sha":null,"assignee":{"login":"davidopp","id":8264113,"avatar_url":"https://avatars.githubusercontent.com/u/8264113?v=3","gravatar_id":"","url":"https://api.github.com/users/davidopp","html_url":"https://github.com/davidopp","followers_url":"https://api.github.com/users/davidopp/followers","following_url":"https://api.github.com/users/davidopp/following{/other_user}","gists_url":"https://api.github.com/users/davidopp/gists{/gist_id}","starred_url":"https://api.github.com/users/davidopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidopp/subscriptions","organizations_url":"https://api.github.com/users/davidopp/orgs","repos_url":"https://api.github.com/users/davidopp/repos","events_url":"https://api.github.com/users/davidopp/events{/privacy}","received_events_url":"https://api.github.com/users/davidopp/received_events","type":"User","site_admin":false},"assignees":[{"login":"davidopp","id":8264113,"avatar_url":"https://avatars.githubusercontent.com/u/8264113?v=3","gravatar_id":"","url":"https://api.github.com/users/davidopp","html_url":"https://github.com/davidopp","followers_url":"https://api.github.com/users/davidopp/followers","following_url":"https://api.github.com/users/davidopp/following{/other_user}","gists_url":"https://api.github.com/users/davidopp/gists{/gist_id}","starred_url":"https://api.github.com/users/davidopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidopp/subscriptions","organizations_url":"https://api.github.com/users/davidopp/orgs","repos_url":"https://api.github.com/users/davidopp/repos","events_url":"https://api.github.com/users/davidopp/events{/privacy}","received_events_url":"https://api.github.com/users/davidopp/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30191/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30191/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30191/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/d6b78a7293bfe2fee45d3fb0115f34c5a4d08e65","head":{"label":"Dingshujie:forgiveness","ref":"forgiveness","sha":"d6b78a7293bfe2fee45d3fb0115f34c5a4d08e65","user":{"login":"Dingshujie","id":13744637,"avatar_url":"https://avatars.githubusercontent.com/u/13744637?v=3","gravatar_id":"","url":"https://api.github.com/users/Dingshujie","html_url":"https://github.com/Dingshujie","followers_url":"https://api.github.com/users/Dingshujie/followers","following_url":"https://api.github.com/users/Dingshujie/following{/other_user}","gists_url":"https://api.github.com/users/Dingshujie/gists{/gist_id}","starred_url":"https://api.github.com/users/Dingshujie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dingshujie/subscriptions","organizations_url":"https://api.github.com/users/Dingshujie/orgs","repos_url":"https://api.github.com/users/Dingshujie/repos","events_url":"https://api.github.com/users/Dingshujie/events{/privacy}","received_events_url":"https://api.github.com/users/Dingshujie/received_events","type":"User","site_admin":false},"repo":{"id":52413546,"name":"kubernetes","full_name":"Dingshujie/kubernetes","owner":{"login":"Dingshujie","id":13744637,"avatar_url":"https://avatars.githubusercontent.com/u/13744637?v=3","gravatar_id":"","url":"https://api.github.com/users/Dingshujie","html_url":"https://github.com/Dingshujie","followers_url":"https://api.github.com/users/Dingshujie/followers","following_url":"https://api.github.com/users/Dingshujie/following{/other_user}","gists_url":"https://api.github.com/users/Dingshujie/gists{/gist_id}","starred_url":"https://api.github.com/users/Dingshujie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dingshujie/subscriptions","organizations_url":"https://api.github.com/users/Dingshujie/orgs","repos_url":"https://api.github.com/users/Dingshujie/repos","events_url":"https://api.github.com/users/Dingshujie/events{/privacy}","received_events_url":"https://api.github.com/users/Dingshujie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Dingshujie/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/Dingshujie/kubernetes","forks_url":"https://api.github.com/repos/Dingshujie/kubernetes/forks","keys_url":"https://api.github.com/repos/Dingshujie/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dingshujie/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dingshujie/kubernetes/teams","hooks_url":"https://api.github.com/repos/Dingshujie/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/Dingshujie/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/Dingshujie/kubernetes/events","assignees_url":"https://api.github.com/repos/Dingshujie/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/Dingshujie/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/Dingshujie/kubernetes/tags","blobs_url":"https://api.github.com/repos/Dingshujie/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dingshujie/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dingshujie/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dingshujie/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dingshujie/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/Dingshujie/kubernetes/languages","stargazers_url":"https://api.github.com/repos/Dingshujie/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/Dingshujie/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/Dingshujie/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/Dingshujie/kubernetes/subscription","commits_url":"https://api.github.com/repos/Dingshujie/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dingshujie/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dingshujie/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dingshujie/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dingshujie/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/Dingshujie/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dingshujie/kubernetes/merges","archive_url":"https://api.github.com/repos/Dingshujie/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dingshujie/kubernetes/downloads","issues_url":"https://api.github.com/repos/Dingshujie/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/Dingshujie/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/Dingshujie/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/Dingshujie/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dingshujie/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/Dingshujie/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/Dingshujie/kubernetes/deployments","created_at":"2016-02-24T04:11:40Z","updated_at":"2016-02-24T04:11:52Z","pushed_at":"2016-08-06T13:51:02Z","git_url":"git://github.com/Dingshujie/kubernetes.git","ssh_url":"git@github.com:Dingshujie/kubernetes.git","clone_url":"https://github.com/Dingshujie/kubernetes.git","svn_url":"https://github.com/Dingshujie/kubernetes","homepage":"http://kubernetes.io","size":299036,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"b5ce23c48d26b78886f7d83e8efd5a8d104441fc","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-10-27T22:49:03Z","pushed_at":"2016-10-28T00:05:01Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":607046,"stargazers_count":17977,"watchers_count":17977,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5852,"mirror_url":null,"open_issues_count":5151,"forks":5852,"open_issues":5151,"watchers":17977,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30191"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/30191"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/30191"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/30191/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30191/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30191/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/d6b78a7293bfe2fee45d3fb0115f34c5a4d08e65"}}}}
{"actor":{"display_login":"bgrant0607"}}