{"action":"closed","number":997,"pull_request":{"url":"https://api.github.com/repos/remind101/empire/pulls/997","id":86656207,"html_url":"https://github.com/remind101/empire/pull/997","diff_url":"https://github.com/remind101/empire/pull/997.diff","patch_url":"https://github.com/remind101/empire/pull/997.patch","issue_url":"https://api.github.com/repos/remind101/empire/issues/997","number":997,"state":"closed","locked":false,"title":"Update documentation for cert-attach","user":{"login":"jesushernandez","id":1518273,"avatar_url":"https://avatars.githubusercontent.com/u/1518273?v=3","gravatar_id":"","url":"https://api.github.com/users/jesushernandez","html_url":"https://github.com/jesushernandez","followers_url":"https://api.github.com/users/jesushernandez/followers","following_url":"https://api.github.com/users/jesushernandez/following{/other_user}","gists_url":"https://api.github.com/users/jesushernandez/gists{/gist_id}","starred_url":"https://api.github.com/users/jesushernandez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesushernandez/subscriptions","organizations_url":"https://api.github.com/users/jesushernandez/orgs","repos_url":"https://api.github.com/users/jesushernandez/repos","events_url":"https://api.github.com/users/jesushernandez/events{/privacy}","received_events_url":"https://api.github.com/users/jesushernandez/received_events","type":"User","site_admin":false},"body":"Since the schedulers (cloudformation and the old one) rely on the `SSLCertificateId` property, which accepts both a IAM server certificate ARN and a ACM certificate ARN, `emp cert-attach` is valid for both types of certificates.\r\n\r\nI have tested this and it works (attaching an ACM cert to the external ELB).\r\n\r\nAs a side question: at the moment you cannot attach a certificate once an application has been already created and deployed. Is this a feature? If it is, should we mention it in the docs?\r\n\r\nThanks.","created_at":"2016-09-25T17:18:43Z","updated_at":"2016-09-27T01:57:31Z","closed_at":"2016-09-27T01:57:30Z","merged_at":"2016-09-27T01:57:30Z","merge_commit_sha":"2ad9359e8719351401d1c756e08f5f7af0260dab","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/remind101/empire/pulls/997/commits","review_comments_url":"https://api.github.com/repos/remind101/empire/pulls/997/comments","review_comment_url":"https://api.github.com/repos/remind101/empire/pulls/comments{/number}","comments_url":"https://api.github.com/repos/remind101/empire/issues/997/comments","statuses_url":"https://api.github.com/repos/remind101/empire/statuses/55f5bd918242a4946c6df280aefb16c818042c74","head":{"label":"jesushernandez:certificates-docs","ref":"certificates-docs","sha":"55f5bd918242a4946c6df280aefb16c818042c74","user":{"login":"jesushernandez","id":1518273,"avatar_url":"https://avatars.githubusercontent.com/u/1518273?v=3","gravatar_id":"","url":"https://api.github.com/users/jesushernandez","html_url":"https://github.com/jesushernandez","followers_url":"https://api.github.com/users/jesushernandez/followers","following_url":"https://api.github.com/users/jesushernandez/following{/other_user}","gists_url":"https://api.github.com/users/jesushernandez/gists{/gist_id}","starred_url":"https://api.github.com/users/jesushernandez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesushernandez/subscriptions","organizations_url":"https://api.github.com/users/jesushernandez/orgs","repos_url":"https://api.github.com/users/jesushernandez/repos","events_url":"https://api.github.com/users/jesushernandez/events{/privacy}","received_events_url":"https://api.github.com/users/jesushernandez/received_events","type":"User","site_admin":false},"repo":{"id":69177795,"name":"empire","full_name":"jesushernandez/empire","owner":{"login":"jesushernandez","id":1518273,"avatar_url":"https://avatars.githubusercontent.com/u/1518273?v=3","gravatar_id":"","url":"https://api.github.com/users/jesushernandez","html_url":"https://github.com/jesushernandez","followers_url":"https://api.github.com/users/jesushernandez/followers","following_url":"https://api.github.com/users/jesushernandez/following{/other_user}","gists_url":"https://api.github.com/users/jesushernandez/gists{/gist_id}","starred_url":"https://api.github.com/users/jesushernandez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesushernandez/subscriptions","organizations_url":"https://api.github.com/users/jesushernandez/orgs","repos_url":"https://api.github.com/users/jesushernandez/repos","events_url":"https://api.github.com/users/jesushernandez/events{/privacy}","received_events_url":"https://api.github.com/users/jesushernandez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jesushernandez/empire","description":"A PaaS built on top of Amazon EC2 Container Service (ECS)","fork":true,"url":"https://api.github.com/repos/jesushernandez/empire","forks_url":"https://api.github.com/repos/jesushernandez/empire/forks","keys_url":"https://api.github.com/repos/jesushernandez/empire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jesushernandez/empire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jesushernandez/empire/teams","hooks_url":"https://api.github.com/repos/jesushernandez/empire/hooks","issue_events_url":"https://api.github.com/repos/jesushernandez/empire/issues/events{/number}","events_url":"https://api.github.com/repos/jesushernandez/empire/events","assignees_url":"https://api.github.com/repos/jesushernandez/empire/assignees{/user}","branches_url":"https://api.github.com/repos/jesushernandez/empire/branches{/branch}","tags_url":"https://api.github.com/repos/jesushernandez/empire/tags","blobs_url":"https://api.github.com/repos/jesushernandez/empire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jesushernandez/empire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jesushernandez/empire/git/refs{/sha}","trees_url":"https://api.github.com/repos/jesushernandez/empire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jesushernandez/empire/statuses/{sha}","languages_url":"https://api.github.com/repos/jesushernandez/empire/languages","stargazers_url":"https://api.github.com/repos/jesushernandez/empire/stargazers","contributors_url":"https://api.github.com/repos/jesushernandez/empire/contributors","subscribers_url":"https://api.github.com/repos/jesushernandez/empire/subscribers","subscription_url":"https://api.github.com/repos/jesushernandez/empire/subscription","commits_url":"https://api.github.com/repos/jesushernandez/empire/commits{/sha}","git_commits_url":"https://api.github.com/repos/jesushernandez/empire/git/commits{/sha}","comments_url":"https://api.github.com/repos/jesushernandez/empire/comments{/number}","issue_comment_url":"https://api.github.com/repos/jesushernandez/empire/issues/comments{/number}","contents_url":"https://api.github.com/repos/jesushernandez/empire/contents/{+path}","compare_url":"https://api.github.com/repos/jesushernandez/empire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jesushernandez/empire/merges","archive_url":"https://api.github.com/repos/jesushernandez/empire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jesushernandez/empire/downloads","issues_url":"https://api.github.com/repos/jesushernandez/empire/issues{/number}","pulls_url":"https://api.github.com/repos/jesushernandez/empire/pulls{/number}","milestones_url":"https://api.github.com/repos/jesushernandez/empire/milestones{/number}","notifications_url":"https://api.github.com/repos/jesushernandez/empire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jesushernandez/empire/labels{/name}","releases_url":"https://api.github.com/repos/jesushernandez/empire/releases{/id}","deployments_url":"https://api.github.com/repos/jesushernandez/empire/deployments","created_at":"2016-09-25T16:56:40Z","updated_at":"2016-09-25T16:56:43Z","pushed_at":"2016-09-25T17:12:52Z","git_url":"git://github.com/jesushernandez/empire.git","ssh_url":"git@github.com:jesushernandez/empire.git","clone_url":"https://github.com/jesushernandez/empire.git","svn_url":"https://github.com/jesushernandez/empire","homepage":"","size":20938,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"remind101:master","ref":"master","sha":"2ee4752f5fc44deb3a3c1b75fdf8c2e71fbdae7e","user":{"login":"remind101","id":376343,"avatar_url":"https://avatars.githubusercontent.com/u/376343?v=3","gravatar_id":"","url":"https://api.github.com/users/remind101","html_url":"https://github.com/remind101","followers_url":"https://api.github.com/users/remind101/followers","following_url":"https://api.github.com/users/remind101/following{/other_user}","gists_url":"https://api.github.com/users/remind101/gists{/gist_id}","starred_url":"https://api.github.com/users/remind101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remind101/subscriptions","organizations_url":"https://api.github.com/users/remind101/orgs","repos_url":"https://api.github.com/users/remind101/repos","events_url":"https://api.github.com/users/remind101/events{/privacy}","received_events_url":"https://api.github.com/users/remind101/received_events","type":"Organization","site_admin":false},"repo":{"id":30091667,"name":"empire","full_name":"remind101/empire","owner":{"login":"remind101","id":376343,"avatar_url":"https://avatars.githubusercontent.com/u/376343?v=3","gravatar_id":"","url":"https://api.github.com/users/remind101","html_url":"https://github.com/remind101","followers_url":"https://api.github.com/users/remind101/followers","following_url":"https://api.github.com/users/remind101/following{/other_user}","gists_url":"https://api.github.com/users/remind101/gists{/gist_id}","starred_url":"https://api.github.com/users/remind101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remind101/subscriptions","organizations_url":"https://api.github.com/users/remind101/orgs","repos_url":"https://api.github.com/users/remind101/repos","events_url":"https://api.github.com/users/remind101/events{/privacy}","received_events_url":"https://api.github.com/users/remind101/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/remind101/empire","description":"A PaaS built on top of Amazon EC2 Container Service (ECS)","fork":false,"url":"https://api.github.com/repos/remind101/empire","forks_url":"https://api.github.com/repos/remind101/empire/forks","keys_url":"https://api.github.com/repos/remind101/empire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/remind101/empire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/remind101/empire/teams","hooks_url":"https://api.github.com/repos/remind101/empire/hooks","issue_events_url":"https://api.github.com/repos/remind101/empire/issues/events{/number}","events_url":"https://api.github.com/repos/remind101/empire/events","assignees_url":"https://api.github.com/repos/remind101/empire/assignees{/user}","branches_url":"https://api.github.com/repos/remind101/empire/branches{/branch}","tags_url":"https://api.github.com/repos/remind101/empire/tags","blobs_url":"https://api.github.com/repos/remind101/empire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/remind101/empire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/remind101/empire/git/refs{/sha}","trees_url":"https://api.github.com/repos/remind101/empire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/remind101/empire/statuses/{sha}","languages_url":"https://api.github.com/repos/remind101/empire/languages","stargazers_url":"https://api.github.com/repos/remind101/empire/stargazers","contributors_url":"https://api.github.com/repos/remind101/empire/contributors","subscribers_url":"https://api.github.com/repos/remind101/empire/subscribers","subscription_url":"https://api.github.com/repos/remind101/empire/subscription","commits_url":"https://api.github.com/repos/remind101/empire/commits{/sha}","git_commits_url":"https://api.github.com/repos/remind101/empire/git/commits{/sha}","comments_url":"https://api.github.com/repos/remind101/empire/comments{/number}","issue_comment_url":"https://api.github.com/repos/remind101/empire/issues/comments{/number}","contents_url":"https://api.github.com/repos/remind101/empire/contents/{+path}","compare_url":"https://api.github.com/repos/remind101/empire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/remind101/empire/merges","archive_url":"https://api.github.com/repos/remind101/empire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/remind101/empire/downloads","issues_url":"https://api.github.com/repos/remind101/empire/issues{/number}","pulls_url":"https://api.github.com/repos/remind101/empire/pulls{/number}","milestones_url":"https://api.github.com/repos/remind101/empire/milestones{/number}","notifications_url":"https://api.github.com/repos/remind101/empire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/remind101/empire/labels{/name}","releases_url":"https://api.github.com/repos/remind101/empire/releases{/id}","deployments_url":"https://api.github.com/repos/remind101/empire/deployments","created_at":"2015-01-30T21:32:09Z","updated_at":"2016-09-24T17:29:34Z","pushed_at":"2016-09-27T01:57:30Z","git_url":"git://github.com/remind101/empire.git","ssh_url":"git@github.com:remind101/empire.git","clone_url":"https://github.com/remind101/empire.git","svn_url":"https://github.com/remind101/empire","homepage":"","size":25985,"stargazers_count":1913,"watchers_count":1913,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":96,"mirror_url":null,"open_issues_count":54,"forks":96,"open_issues":54,"watchers":1913,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/remind101/empire/pulls/997"},"html":{"href":"https://github.com/remind101/empire/pull/997"},"issue":{"href":"https://api.github.com/repos/remind101/empire/issues/997"},"comments":{"href":"https://api.github.com/repos/remind101/empire/issues/997/comments"},"review_comments":{"href":"https://api.github.com/repos/remind101/empire/pulls/997/comments"},"review_comment":{"href":"https://api.github.com/repos/remind101/empire/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/remind101/empire/pulls/997/commits"},"statuses":{"href":"https://api.github.com/repos/remind101/empire/statuses/55f5bd918242a4946c6df280aefb16c818042c74"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ejholmes","id":95166,"avatar_url":"https://avatars.githubusercontent.com/u/95166?v=3","gravatar_id":"","url":"https://api.github.com/users/ejholmes","html_url":"https://github.com/ejholmes","followers_url":"https://api.github.com/users/ejholmes/followers","following_url":"https://api.github.com/users/ejholmes/following{/other_user}","gists_url":"https://api.github.com/users/ejholmes/gists{/gist_id}","starred_url":"https://api.github.com/users/ejholmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejholmes/subscriptions","organizations_url":"https://api.github.com/users/ejholmes/orgs","repos_url":"https://api.github.com/users/ejholmes/repos","events_url":"https://api.github.com/users/ejholmes/events{/privacy}","received_events_url":"https://api.github.com/users/ejholmes/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":21,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"ejholmes"}}