{"action":"created","issue":{"url":"https://api.github.com/repos/JetBrains/intellij-community/issues/358","repository_url":"https://api.github.com/repos/JetBrains/intellij-community","labels_url":"https://api.github.com/repos/JetBrains/intellij-community/issues/358/labels{/name}","comments_url":"https://api.github.com/repos/JetBrains/intellij-community/issues/358/comments","events_url":"https://api.github.com/repos/JetBrains/intellij-community/issues/358/events","html_url":"https://github.com/JetBrains/intellij-community/pull/358","id":134951342,"number":358,"title":"Show commits in git log history (IDEA-134161)","user":{"login":"klassm","id":498976,"avatar_url":"https://avatars.githubusercontent.com/u/498976?v=3","gravatar_id":"","url":"https://api.github.com/users/klassm","html_url":"https://github.com/klassm","followers_url":"https://api.github.com/users/klassm/followers","following_url":"https://api.github.com/users/klassm/following{/other_user}","gists_url":"https://api.github.com/users/klassm/gists{/gist_id}","starred_url":"https://api.github.com/users/klassm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klassm/subscriptions","organizations_url":"https://api.github.com/users/klassm/orgs","repos_url":"https://api.github.com/users/klassm/repos","events_url":"https://api.github.com/users/klassm/events{/privacy}","received_events_url":"https://api.github.com/users/klassm/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-02-19T19:23:04Z","updated_at":"2016-02-26T08:48:43Z","closed_at":"2016-02-20T15:34:56Z","pull_request":{"url":"https://api.github.com/repos/JetBrains/intellij-community/pulls/358","html_url":"https://github.com/JetBrains/intellij-community/pull/358","diff_url":"https://github.com/JetBrains/intellij-community/pull/358.diff","patch_url":"https://github.com/JetBrains/intellij-community/pull/358.patch"},"body":"This is a bit of a hack, as I did not want to midfy VcsFileRevision, which is shared for multiple VCS implementations. That's why I just added those git notes to the commit message. \r\nThe null check in GitLogParserTest is to make sure, that the test conforms to the acutal behavior. If not adding the check, the test would get \"null\" as String, which is wrong. When executing IDEA, GitLogParser returns null for unset git notes.\r\n\r\nIf the pull request is ok, a backport to IDEA 15 would be great.\r\n\r\nReferencing issue: https://youtrack.jetbrains.com/issue/IDEA-134161\r\n\r\nJust as a side note: I did already submit the developer agreement.\r\n\r\nBTW: How do you handle those code style issues and warnings within your code? In my pull requests, I did not want to resolve anything but the issue itself. However, there are loads of lines that do not conform to your codestyle and huge amounts of warnings, i.e. for unnecessary generics. Is it ok to resolve those in pull requests?"},"comment":{"url":"https://api.github.com/repos/JetBrains/intellij-community/issues/comments/189167028","html_url":"https://github.com/JetBrains/intellij-community/pull/358#issuecomment-189167028","issue_url":"https://api.github.com/repos/JetBrains/intellij-community/issues/358","id":189167028,"user":{"login":"klassm","id":498976,"avatar_url":"https://avatars.githubusercontent.com/u/498976?v=3","gravatar_id":"","url":"https://api.github.com/users/klassm","html_url":"https://github.com/klassm","followers_url":"https://api.github.com/users/klassm/followers","following_url":"https://api.github.com/users/klassm/following{/other_user}","gists_url":"https://api.github.com/users/klassm/gists{/gist_id}","starred_url":"https://api.github.com/users/klassm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klassm/subscriptions","organizations_url":"https://api.github.com/users/klassm/orgs","repos_url":"https://api.github.com/users/klassm/repos","events_url":"https://api.github.com/users/klassm/events{/privacy}","received_events_url":"https://api.github.com/users/klassm/received_events","type":"User","site_admin":false},"created_at":"2016-02-26T08:48:42Z","updated_at":"2016-02-26T08:48:42Z","body":"Hm this seems to be a bigger change. I suppose it is better if you discuss the change with your colleagues and implement it later on the way you want it."}}