{"action":"created","issue":{"url":"https://api.github.com/repos/qgis/QGIS/issues/2974","repository_url":"https://api.github.com/repos/qgis/QGIS","labels_url":"https://api.github.com/repos/qgis/QGIS/issues/2974/labels{/name}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/2974/comments","events_url":"https://api.github.com/repos/qgis/QGIS/issues/2974/events","html_url":"https://github.com/qgis/QGIS/pull/2974","id":145876880,"number":2974,"title":"[diagram] add unit type setting for outlines (fixes #14614)","user":{"login":"nirvn","id":1728657,"avatar_url":"https://avatars.githubusercontent.com/u/1728657?v=3","gravatar_id":"","url":"https://api.github.com/users/nirvn","html_url":"https://github.com/nirvn","followers_url":"https://api.github.com/users/nirvn/followers","following_url":"https://api.github.com/users/nirvn/following{/other_user}","gists_url":"https://api.github.com/users/nirvn/gists{/gist_id}","starred_url":"https://api.github.com/users/nirvn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirvn/subscriptions","organizations_url":"https://api.github.com/users/nirvn/orgs","repos_url":"https://api.github.com/users/nirvn/repos","events_url":"https://api.github.com/users/nirvn/events{/privacy}","received_events_url":"https://api.github.com/users/nirvn/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-04-05T03:38:29Z","updated_at":"2016-04-05T12:08:05Z","closed_at":"2016-04-05T11:56:50Z","pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/2974","html_url":"https://github.com/qgis/QGIS/pull/2974","diff_url":"https://github.com/qgis/QGIS/pull/2974.diff","patch_url":"https://github.com/qgis/QGIS/pull/2974.patch"},"body":"This PR adds a line unit type setting to allow for mm outlines when diagrams' size unit is set to map units.\r\n\r\nBefore, line size was in map unit:\r\n![error](https://cloud.githubusercontent.com/assets/1728657/14270649/621dda62-fb1a-11e5-9e8b-04408c984d83.png)\r\n\r\nWith this PR applied, things look much better:\r\n![fixed](https://cloud.githubusercontent.com/assets/1728657/14270659/7a97272e-fb1a-11e5-8bc4-e2525f5842cb.png)\r\n"},"comment":{"url":"https://api.github.com/repos/qgis/QGIS/issues/comments/205771788","html_url":"https://github.com/qgis/QGIS/pull/2974#issuecomment-205771788","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/2974","id":205771788,"user":{"login":"nyalldawson","id":1829991,"avatar_url":"https://avatars.githubusercontent.com/u/1829991?v=3","gravatar_id":"","url":"https://api.github.com/users/nyalldawson","html_url":"https://github.com/nyalldawson","followers_url":"https://api.github.com/users/nyalldawson/followers","following_url":"https://api.github.com/users/nyalldawson/following{/other_user}","gists_url":"https://api.github.com/users/nyalldawson/gists{/gist_id}","starred_url":"https://api.github.com/users/nyalldawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyalldawson/subscriptions","organizations_url":"https://api.github.com/users/nyalldawson/orgs","repos_url":"https://api.github.com/users/nyalldawson/repos","events_url":"https://api.github.com/users/nyalldawson/events{/privacy}","received_events_url":"https://api.github.com/users/nyalldawson/received_events","type":"User","site_admin":false},"created_at":"2016-04-05T12:08:04Z","updated_at":"2016-04-05T12:08:04Z","body":"@nirvn one thing i realised we've missed - QgsDiagramRendererV2::sizeMapUnits needs to be updated so that if the unit is MapUnits then the min/max scale and min/max mm size is respected. Otherwise the correct diagram size won't be used for the placement algorithm."}}