{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/52549918","id":52549918,"diff_hunk":"@@ -336,4 +334,18 @@ static void addPermGenSizeOpt(List<String> cmd) {\n     cmd.add(\"-XX:MaxPermSize=256m\");\n   }\n \n+  /**\n+   * Get the major version of the java.version string supplied.\n+   */\n+  static int javaMajorVersion(String javaVersion) {\n+    String[] version = javaVersion.split(\"[+.\\\\-]+\");","path":"launcher/src/main/java/org/apache/spark/launcher/CommandBuilderUtils.java","position":21,"original_position":21,"commit_id":"0da18a66a1278cf8cceefaa53f0cd97a7c75899d","original_commit_id":"0da18a66a1278cf8cceefaa53f0cd97a7c75899d","user":{"login":"zsxwing","id":1000778,"avatar_url":"https://avatars.githubusercontent.com/u/1000778?v=3","gravatar_id":"","url":"https://api.github.com/users/zsxwing","html_url":"https://github.com/zsxwing","followers_url":"https://api.github.com/users/zsxwing/followers","following_url":"https://api.github.com/users/zsxwing/following{/other_user}","gists_url":"https://api.github.com/users/zsxwing/gists{/gist_id}","starred_url":"https://api.github.com/users/zsxwing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zsxwing/subscriptions","organizations_url":"https://api.github.com/users/zsxwing/orgs","repos_url":"https://api.github.com/users/zsxwing/repos","events_url":"https://api.github.com/users/zsxwing/events{/privacy}","received_events_url":"https://api.github.com/users/zsxwing/received_events","type":"User","site_admin":false},"body":"I meant `Integer.parseInt(\"9-ea\")` will throw `NumberFormatException`.","created_at":"2016-02-11T00:27:00Z","updated_at":"2016-02-11T00:27:00Z","html_url":"https://github.com/apache/spark/pull/11160#discussion_r52549918","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/11160","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/52549918"},"html":{"href":"https://github.com/apache/spark/pull/11160#discussion_r52549918"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/11160"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/11160","id":58966732,"html_url":"https://github.com/apache/spark/pull/11160","diff_url":"https://github.com/apache/spark/pull/11160.diff","patch_url":"https://github.com/apache/spark/pull/11160.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/11160","number":11160,"state":"open","locked":false,"title":"[SPARK-13278][CORE] Launcher fails to start with JDK 9 EA","user":{"login":"cl4es","id":204640,"avatar_url":"https://avatars.githubusercontent.com/u/204640?v=3","gravatar_id":"","url":"https://api.github.com/users/cl4es","html_url":"https://github.com/cl4es","followers_url":"https://api.github.com/users/cl4es/followers","following_url":"https://api.github.com/users/cl4es/following{/other_user}","gists_url":"https://api.github.com/users/cl4es/gists{/gist_id}","starred_url":"https://api.github.com/users/cl4es/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cl4es/subscriptions","organizations_url":"https://api.github.com/users/cl4es/orgs","repos_url":"https://api.github.com/users/cl4es/repos","events_url":"https://api.github.com/users/cl4es/events{/privacy}","received_events_url":"https://api.github.com/users/cl4es/received_events","type":"User","site_admin":false},"body":"See http://openjdk.java.net/jeps/223 for more information about the JDK 9 version string scheme.","created_at":"2016-02-10T22:45:52Z","updated_at":"2016-02-11T00:27:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"088aacdd21d14ea01cd8957ee7222f43c1d6c173","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/11160/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/11160/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/11160/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/0da18a66a1278cf8cceefaa53f0cd97a7c75899d","head":{"label":"cl4es:master","ref":"master","sha":"0da18a66a1278cf8cceefaa53f0cd97a7c75899d","user":{"login":"cl4es","id":204640,"avatar_url":"https://avatars.githubusercontent.com/u/204640?v=3","gravatar_id":"","url":"https://api.github.com/users/cl4es","html_url":"https://github.com/cl4es","followers_url":"https://api.github.com/users/cl4es/followers","following_url":"https://api.github.com/users/cl4es/following{/other_user}","gists_url":"https://api.github.com/users/cl4es/gists{/gist_id}","starred_url":"https://api.github.com/users/cl4es/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cl4es/subscriptions","organizations_url":"https://api.github.com/users/cl4es/orgs","repos_url":"https://api.github.com/users/cl4es/repos","events_url":"https://api.github.com/users/cl4es/events{/privacy}","received_events_url":"https://api.github.com/users/cl4es/received_events","type":"User","site_admin":false},"repo":{"id":51477135,"name":"spark","full_name":"cl4es/spark","owner":{"login":"cl4es","id":204640,"avatar_url":"https://avatars.githubusercontent.com/u/204640?v=3","gravatar_id":"","url":"https://api.github.com/users/cl4es","html_url":"https://github.com/cl4es","followers_url":"https://api.github.com/users/cl4es/followers","following_url":"https://api.github.com/users/cl4es/following{/other_user}","gists_url":"https://api.github.com/users/cl4es/gists{/gist_id}","starred_url":"https://api.github.com/users/cl4es/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cl4es/subscriptions","organizations_url":"https://api.github.com/users/cl4es/orgs","repos_url":"https://api.github.com/users/cl4es/repos","events_url":"https://api.github.com/users/cl4es/events{/privacy}","received_events_url":"https://api.github.com/users/cl4es/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cl4es/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/cl4es/spark","forks_url":"https://api.github.com/repos/cl4es/spark/forks","keys_url":"https://api.github.com/repos/cl4es/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cl4es/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cl4es/spark/teams","hooks_url":"https://api.github.com/repos/cl4es/spark/hooks","issue_events_url":"https://api.github.com/repos/cl4es/spark/issues/events{/number}","events_url":"https://api.github.com/repos/cl4es/spark/events","assignees_url":"https://api.github.com/repos/cl4es/spark/assignees{/user}","branches_url":"https://api.github.com/repos/cl4es/spark/branches{/branch}","tags_url":"https://api.github.com/repos/cl4es/spark/tags","blobs_url":"https://api.github.com/repos/cl4es/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cl4es/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cl4es/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/cl4es/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cl4es/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/cl4es/spark/languages","stargazers_url":"https://api.github.com/repos/cl4es/spark/stargazers","contributors_url":"https://api.github.com/repos/cl4es/spark/contributors","subscribers_url":"https://api.github.com/repos/cl4es/spark/subscribers","subscription_url":"https://api.github.com/repos/cl4es/spark/subscription","commits_url":"https://api.github.com/repos/cl4es/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/cl4es/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/cl4es/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/cl4es/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/cl4es/spark/contents/{+path}","compare_url":"https://api.github.com/repos/cl4es/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cl4es/spark/merges","archive_url":"https://api.github.com/repos/cl4es/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cl4es/spark/downloads","issues_url":"https://api.github.com/repos/cl4es/spark/issues{/number}","pulls_url":"https://api.github.com/repos/cl4es/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/cl4es/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/cl4es/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cl4es/spark/labels{/name}","releases_url":"https://api.github.com/repos/cl4es/spark/releases{/id}","deployments_url":"https://api.github.com/repos/cl4es/spark/deployments","created_at":"2016-02-10T22:26:03Z","updated_at":"2016-02-10T22:26:29Z","pushed_at":"2016-02-10T22:43:00Z","git_url":"git://github.com/cl4es/spark.git","ssh_url":"git@github.com:cl4es/spark.git","clone_url":"https://github.com/cl4es/spark.git","svn_url":"https://github.com/cl4es/spark","homepage":null,"size":147453,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"5947fa8fa1f95d8fc1537c1e37bc16bae8fe7988","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-02-10T21:45:39Z","pushed_at":"2016-02-10T23:56:37Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":411789,"stargazers_count":7400,"watchers_count":7400,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6733,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":383,"forks":6733,"open_issues":383,"watchers":7400,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/11160"},"html":{"href":"https://github.com/apache/spark/pull/11160"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/11160"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/11160/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/11160/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/11160/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/0da18a66a1278cf8cceefaa53f0cd97a7c75899d"}}}}