{"action":"created","issue":{"url":"https://api.github.com/repos/mate-desktop/caja/issues/690","repository_url":"https://api.github.com/repos/mate-desktop/caja","labels_url":"https://api.github.com/repos/mate-desktop/caja/issues/690/labels{/name}","comments_url":"https://api.github.com/repos/mate-desktop/caja/issues/690/comments","events_url":"https://api.github.com/repos/mate-desktop/caja/issues/690/events","html_url":"https://github.com/mate-desktop/caja/pull/690","id":193266781,"number":690,"title":"rename labels: follow theme if available, else sane default","user":{"login":"lukefromdc","id":14036792,"avatar_url":"https://avatars.githubusercontent.com/u/14036792?v=3","gravatar_id":"","url":"https://api.github.com/users/lukefromdc","html_url":"https://github.com/lukefromdc","followers_url":"https://api.github.com/users/lukefromdc/followers","following_url":"https://api.github.com/users/lukefromdc/following{/other_user}","gists_url":"https://api.github.com/users/lukefromdc/gists{/gist_id}","starred_url":"https://api.github.com/users/lukefromdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukefromdc/subscriptions","organizations_url":"https://api.github.com/users/lukefromdc/orgs","repos_url":"https://api.github.com/users/lukefromdc/repos","events_url":"https://api.github.com/users/lukefromdc/events{/privacy}","received_events_url":"https://api.github.com/users/lukefromdc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-03T05:19:26Z","updated_at":"2016-12-04T09:04:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mate-desktop/caja/pulls/690","html_url":"https://github.com/mate-desktop/caja/pull/690","diff_url":"https://github.com/mate-desktop/caja/pull/690.diff","patch_url":"https://github.com/mate-desktop/caja/pull/690.patch"},"body":"Split caja.css. Most of it can load with GTK_STYLE_PROVIDER_PRIORITY_THEME to allow themes that support Caja to set their own style. CSS required for the desktop background to show and to keep the white text suitable for most backgrounds needs GTK_STYLE_PROVIDER_PRIORITY_APPLICATION so it is loaded separately from new file caja-desktop.css\r\n\r\nNote that BlackMATE requires reverting https://github.com/mate-desktop/mate-themes/commit/1147914097234d4d6fda9aff0353d7e698fd7667 and an adjustment is needed to ContrastHighInverse so the styles they provide are usable when fully applied. Tested with GTK 3.22 in every MATE theme plus Adwaita and Raleigh."},"comment":{"url":"https://api.github.com/repos/mate-desktop/caja/issues/comments/264692428","html_url":"https://github.com/mate-desktop/caja/pull/690#issuecomment-264692428","issue_url":"https://api.github.com/repos/mate-desktop/caja/issues/690","id":264692428,"user":{"login":"raveit65","id":961604,"avatar_url":"https://avatars.githubusercontent.com/u/961604?v=3","gravatar_id":"","url":"https://api.github.com/users/raveit65","html_url":"https://github.com/raveit65","followers_url":"https://api.github.com/users/raveit65/followers","following_url":"https://api.github.com/users/raveit65/following{/other_user}","gists_url":"https://api.github.com/users/raveit65/gists{/gist_id}","starred_url":"https://api.github.com/users/raveit65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raveit65/subscriptions","organizations_url":"https://api.github.com/users/raveit65/orgs","repos_url":"https://api.github.com/users/raveit65/repos","events_url":"https://api.github.com/users/raveit65/events{/privacy}","received_events_url":"https://api.github.com/users/raveit65/received_events","type":"User","site_admin":false},"created_at":"2016-12-04T09:04:48Z","updated_at":"2016-12-04T09:04:48Z","body":"Nice idea, i am fine with it but it needs to be improved.\r\n```\r\n.caja-desktop.caja-canvas-item:selected,\r\n.caja-desktop.caja-canvas-item:active,\r\n.caja-desktop.caja-canvas-item:hover {\r\n    text-shadow: none;\r\n}\r\n```\r\n1. This needs to be moved to caja-desktop.css too, otherwise the selected desktop icon use a text-shadow which isn't nice.\r\n2. Imo all settings which are in caja-desktop.css can be removed from caja.css.\r\n\r\n3. BlackMate has an issue with renaming an icon in desktop/navigation mode (EditableLabel). \r\nHere the font color is dark on dark gradient bg which makes it hard to read. The color for the selected text is fine.\r\nThis is the result that BlackMate use now his own gradient bg.\r\nProposal: setting theme_fg_color as font color\r\n```\r\n/*caja file renaming  (eel-editable-label)*/\r\n\r\n.caja-desktop .entry,\r\n.caja-navigation-window .view .entry{\r\n\tborder-radius: 4px;\t\r\n\tbackground-image: linear-gradient(to bottom,\r\n\t                                  shade(@less_dark_color, 0.2),\r\n\t                                  shade(@less_dark_color, 0.5) 10%,\r\n\t                                  @less_dark_color 50%,\r\n\t                                  shade(@less_dark_color, 1.5));\r\n\tcolor: @theme_fg_color;\r\n}\r\n```\r\nin mate-application.css fixes this issue.\r\n\r\nGnome themes like Adwaita or ContrastHigh are fine here with the concern above.\r\nOf course our other themes too ;-)\r\n\r\nNote, i am not sure about using a gradient bg for Editablelabel with BlackMate in navigation mode.\r\nFor me the contrast between the bg of the IconView and the Editabllabel is too low.\r\nOn the otherside using a dark bg is nice here.\r\nMaybe this can be improved with using another border-color.\r\nBut you're the maintainer and i agree with your decision in this point ;-)\r\n"}}
{"actor":{"display_login":"raveit65"}}