{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/24143","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/24143/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/24143/comments","events_url":"https://api.github.com/repos/docker/docker/issues/24143/events","html_url":"https://github.com/docker/docker/issues/24143","id":163017661,"number":24143,"title":"Swarm update does not allow both workers and managers to be auto-accepted","user":{"login":"johnharris85","id":746221,"avatar_url":"https://avatars.githubusercontent.com/u/746221?v=3","gravatar_id":"","url":"https://api.github.com/users/johnharris85","html_url":"https://github.com/johnharris85","followers_url":"https://api.github.com/users/johnharris85/followers","following_url":"https://api.github.com/users/johnharris85/following{/other_user}","gists_url":"https://api.github.com/users/johnharris85/gists{/gist_id}","starred_url":"https://api.github.com/users/johnharris85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnharris85/subscriptions","organizations_url":"https://api.github.com/users/johnharris85/orgs","repos_url":"https://api.github.com/users/johnharris85/repos","events_url":"https://api.github.com/users/johnharris85/events{/privacy}","received_events_url":"https://api.github.com/users/johnharris85/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/area/swarm","name":"area/swarm","color":"fbca04"},{"url":"https://api.github.com/repos/docker/docker/labels/priority/P1","name":"priority/P1","color":"eb6420"},{"url":"https://api.github.com/repos/docker/docker/labels/version/1.12","name":"version/1.12","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/53","html_url":"https://github.com/docker/docker/milestones/1.12.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/53/labels","id":1657301,"number":53,"title":"1.12.0","description":"feature/code freeze: June 14th, 2016","creator":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"open_issues":115,"closed_issues":496,"state":"open","created_at":"2016-03-21T13:47:53Z","updated_at":"2016-07-06T01:18:20Z","due_on":null,"closed_at":null},"comments":10,"created_at":"2016-06-29T20:22:21Z","updated_at":"2016-07-06T03:38:47Z","closed_at":null,"body":"**Output of `docker version`:**\r\n\r\n```\r\nClient:\r\n Version:      1.12.0-rc2\r\n API version:  1.24\r\n Go version:   go1.6.2\r\n Git commit:   906eacd\r\n Built:        Fri Jun 17 20:35:33 2016\r\n OS/Arch:      linux/amd64\r\n Experimental: true\r\n\r\nServer:\r\n Version:      1.12.0-rc2\r\n API version:  1.24\r\n Go version:   go1.6.2\r\n Git commit:   906eacd\r\n Built:        Fri Jun 17 20:35:33 2016\r\n OS/Arch:      linux/amd64\r\n Experimental: true\r\n\r\n```\r\n**Output of `docker info`:**\r\n\r\n```\r\nClient:\r\n Version:      1.12.0-rc2\r\n API version:  1.24\r\n Go version:   go1.6.2\r\n Git commit:   906eacd\r\n Built:        Fri Jun 17 20:35:33 2016\r\n OS/Arch:      linux/amd64\r\n Experimental: true\r\n\r\nServer:\r\n Version:      1.12.0-rc2\r\n API version:  1.24\r\n Go version:   go1.6.2\r\n Git commit:   906eacd\r\n Built:        Fri Jun 17 20:35:33 2016\r\n OS/Arch:      linux/amd64\r\n Experimental: true\r\njohn@j-think:~/workspace/docker$ docker info\r\nContainers: 8\r\n Running: 8\r\n Paused: 0\r\n Stopped: 0\r\nImages: 228\r\nServer Version: 1.12.0-rc2\r\nStorage Driver: aufs\r\n Root Dir: /var/lib/docker/aufs\r\n Backing Filesystem: extfs\r\n Dirs: 761\r\n Dirperm1 Supported: true\r\nLogging Driver: json-file\r\nCgroup Driver: cgroupfs\r\nPlugins:\r\n Volume: local\r\n Network: host bridge null overlay\r\nSwarm: active\r\n NodeID: b8436t7uvxuhjbs1v0krssw7h\r\n IsManager: Yes\r\n Managers: 1\r\n Nodes: 1\r\n CACertHash: sha256:091758bd45885b71ffbcd8ae21cea1b55f4c1d48dc1b17a55683dce16412800c\r\nRuntimes: default\r\nDefault Runtime: default\r\nSecurity Options: apparmor seccomp\r\nKernel Version: 3.16.0-73-generic\r\nOperating System: Ubuntu 14.04.4 LTS\r\nOSType: linux\r\nArchitecture: x86_64\r\nCPUs: 8\r\nTotal Memory: 31.06 GiB\r\nName: j-think\r\nID: OCMX:LCWD:ZLEO:SGYW:ZWUQ:YLI3:TPPY:4ZLH:GBXC:PKJ2:FNNF:TOOL\r\nDocker Root Dir: /var/lib/docker\r\nDebug Mode (client): false\r\nDebug Mode (server): false\r\nUsername: johnharris85\r\nRegistry: https://index.docker.io/v1/\r\nWARNING: No swap limit support\r\nExperimental: true\r\nInsecure Registries:\r\n 127.0.0.0/8\r\n```\r\n\r\n**Steps to reproduce the issue:**\r\n1. `docker swarm init`\r\n2. `docker swarm update --auto-accept manager`\r\n3. `docker swarm update --auto-accept worker`\r\n\r\n\r\n**Describe the results you received:**\r\nOnly the worker is set to auto-accept.\r\n\r\n**Describe the results you expected:**\r\nBoth worker and manager should be set to auto-accept.\r\n\r\n**Additional information you deem important (e.g. issue happens only occasionally):**\r\nCode (`api/client/swarm/opts.go#98`) only allows one or the other to be marked as auto-accept.\r\n\r\nShould add a `ALL` option (`docker swarm update --auto-accept all`)."},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/230663655","html_url":"https://github.com/docker/docker/issues/24143#issuecomment-230663655","issue_url":"https://api.github.com/repos/docker/docker/issues/24143","id":230663655,"user":{"login":"dnephin","id":442180,"avatar_url":"https://avatars.githubusercontent.com/u/442180?v=3","gravatar_id":"","url":"https://api.github.com/users/dnephin","html_url":"https://github.com/dnephin","followers_url":"https://api.github.com/users/dnephin/followers","following_url":"https://api.github.com/users/dnephin/following{/other_user}","gists_url":"https://api.github.com/users/dnephin/gists{/gist_id}","starred_url":"https://api.github.com/users/dnephin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnephin/subscriptions","organizations_url":"https://api.github.com/users/dnephin/orgs","repos_url":"https://api.github.com/users/dnephin/repos","events_url":"https://api.github.com/users/dnephin/events{/privacy}","received_events_url":"https://api.github.com/users/dnephin/received_events","type":"User","site_admin":false},"created_at":"2016-07-06T03:38:46Z","updated_at":"2016-07-06T03:38:46Z","body":"What happens when you add the third type? `all` doesn't work for the \"two of three\" case any more. I think we're better off accepting a list of values instead of `all`.\r\n\r\nIf `--auto-accept worker --auto-accept manager` isn't clear we could support `--auto-accept worker,manager`. That would actually be easier to parse."}}
{"actor":{"display_login":"dnephin"}}