{"action":"created","comment":{"url":"https://api.github.com/repos/cappuccino/cappuccino/pulls/comments/85940661","pull_request_review_id":6624787,"id":85940661,"diff_hunk":"@@ -162,14 +162,19 @@ CPLog.debug(_cmd + \"context stack =\" + _CPAnimationContextStack);\n     var completionFunction = function()\n     {\n         if (needsFrameTimer)\n+        {\n             [self stopFrameUpdaterWithIdentifier:objectId];\n+            [anObject _setForceDOMUpdates:YES];","path":"AppKit/CoreAnimation/CPAnimationContext.j","position":17,"original_position":17,"commit_id":"bdc3d00fe2a8d420861e8d80ca16df7e18968334","original_commit_id":"bdc3d00fe2a8d420861e8d80ca16df7e18968334","user":{"login":"didierkorthoudt","id":2394110,"avatar_url":"https://avatars.githubusercontent.com/u/2394110?v=3","gravatar_id":"","url":"https://api.github.com/users/didierkorthoudt","html_url":"https://github.com/didierkorthoudt","followers_url":"https://api.github.com/users/didierkorthoudt/followers","following_url":"https://api.github.com/users/didierkorthoudt/following{/other_user}","gists_url":"https://api.github.com/users/didierkorthoudt/gists{/gist_id}","starred_url":"https://api.github.com/users/didierkorthoudt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/didierkorthoudt/subscriptions","organizations_url":"https://api.github.com/users/didierkorthoudt/orgs","repos_url":"https://api.github.com/users/didierkorthoudt/repos","events_url":"https://api.github.com/users/didierkorthoudt/events{/privacy}","received_events_url":"https://api.github.com/users/didierkorthoudt/received_events","type":"User","site_admin":false},"body":"Sorry but I don't understand where else you want me to force updates. This should only be set when the animation used \"live\" setFrameXXX with _inhibitDOMUpdates set as frame rect is, at the end of the animation, set to the final value but without having impacted the DOM (so, simply calling setFrameXXX has no effect as each method begins with ```if (CGRectEqualToRect(_frame, aFrame))``` (or similar for other methods). Maybe I'm missing something somewhere...  ;-)  Do you have any clue for me ?","created_at":"2016-11-01T14:36:32Z","updated_at":"2016-11-01T14:36:32Z","html_url":"https://github.com/cappuccino/cappuccino/pull/2502#discussion_r85940661","pull_request_url":"https://api.github.com/repos/cappuccino/cappuccino/pulls/2502","_links":{"self":{"href":"https://api.github.com/repos/cappuccino/cappuccino/pulls/comments/85940661"},"html":{"href":"https://github.com/cappuccino/cappuccino/pull/2502#discussion_r85940661"},"pull_request":{"href":"https://api.github.com/repos/cappuccino/cappuccino/pulls/2502"}}},"pull_request":{"url":"https://api.github.com/repos/cappuccino/cappuccino/pulls/2502","id":91632288,"html_url":"https://github.com/cappuccino/cappuccino/pull/2502","diff_url":"https://github.com/cappuccino/cappuccino/pull/2502.diff","patch_url":"https://github.com/cappuccino/cappuccino/pull/2502.patch","issue_url":"https://api.github.com/repos/cappuccino/cappuccino/issues/2502","number":2502,"state":"open","locked":false,"title":"Fixed: CPViewAnimator was not giving correct frame information","user":{"login":"didierkorthoudt","id":2394110,"avatar_url":"https://avatars.githubusercontent.com/u/2394110?v=3","gravatar_id":"","url":"https://api.github.com/users/didierkorthoudt","html_url":"https://github.com/didierkorthoudt","followers_url":"https://api.github.com/users/didierkorthoudt/followers","following_url":"https://api.github.com/users/didierkorthoudt/following{/other_user}","gists_url":"https://api.github.com/users/didierkorthoudt/gists{/gist_id}","starred_url":"https://api.github.com/users/didierkorthoudt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/didierkorthoudt/subscriptions","organizations_url":"https://api.github.com/users/didierkorthoudt/orgs","repos_url":"https://api.github.com/users/didierkorthoudt/repos","events_url":"https://api.github.com/users/didierkorthoudt/events{/privacy}","received_events_url":"https://api.github.com/users/didierkorthoudt/received_events","type":"User","site_admin":false},"body":"Replaces #2500.\r\n\r\nWith this PR, correct frame/frameSize/frameOrigin are available when animating a view.\r\n\r\nIf your animated view doesn’t implement a custom layoutSubviews or drawRect, simply set the new flag : ```[[aView animator] setWantPeriodicFrameUpdates:YES]``` (this is automatically done for you if you have at least one of the 2 custom methods implemented).\r\n\r\nThis will call setFrame / setFrameOrigin / setFrameSize accordingly to the property you're animating.","created_at":"2016-10-31T15:39:18Z","updated_at":"2016-11-01T14:36:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d86ee706dbfce6bed376dc7bdeaeca941178bc4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cappuccino/cappuccino/pulls/2502/commits","review_comments_url":"https://api.github.com/repos/cappuccino/cappuccino/pulls/2502/comments","review_comment_url":"https://api.github.com/repos/cappuccino/cappuccino/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cappuccino/cappuccino/issues/2502/comments","statuses_url":"https://api.github.com/repos/cappuccino/cappuccino/statuses/bdc3d00fe2a8d420861e8d80ca16df7e18968334","head":{"label":"didierkorthoudt:CPViewAnimation-correct-live-info","ref":"CPViewAnimation-correct-live-info","sha":"bdc3d00fe2a8d420861e8d80ca16df7e18968334","user":{"login":"didierkorthoudt","id":2394110,"avatar_url":"https://avatars.githubusercontent.com/u/2394110?v=3","gravatar_id":"","url":"https://api.github.com/users/didierkorthoudt","html_url":"https://github.com/didierkorthoudt","followers_url":"https://api.github.com/users/didierkorthoudt/followers","following_url":"https://api.github.com/users/didierkorthoudt/following{/other_user}","gists_url":"https://api.github.com/users/didierkorthoudt/gists{/gist_id}","starred_url":"https://api.github.com/users/didierkorthoudt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/didierkorthoudt/subscriptions","organizations_url":"https://api.github.com/users/didierkorthoudt/orgs","repos_url":"https://api.github.com/users/didierkorthoudt/repos","events_url":"https://api.github.com/users/didierkorthoudt/events{/privacy}","received_events_url":"https://api.github.com/users/didierkorthoudt/received_events","type":"User","site_admin":false},"repo":{"id":45237623,"name":"cappuccino","full_name":"didierkorthoudt/cappuccino","owner":{"login":"didierkorthoudt","id":2394110,"avatar_url":"https://avatars.githubusercontent.com/u/2394110?v=3","gravatar_id":"","url":"https://api.github.com/users/didierkorthoudt","html_url":"https://github.com/didierkorthoudt","followers_url":"https://api.github.com/users/didierkorthoudt/followers","following_url":"https://api.github.com/users/didierkorthoudt/following{/other_user}","gists_url":"https://api.github.com/users/didierkorthoudt/gists{/gist_id}","starred_url":"https://api.github.com/users/didierkorthoudt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/didierkorthoudt/subscriptions","organizations_url":"https://api.github.com/users/didierkorthoudt/orgs","repos_url":"https://api.github.com/users/didierkorthoudt/repos","events_url":"https://api.github.com/users/didierkorthoudt/events{/privacy}","received_events_url":"https://api.github.com/users/didierkorthoudt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/didierkorthoudt/cappuccino","description":"Web Application Framework in JavaScript and Objective-J","fork":true,"url":"https://api.github.com/repos/didierkorthoudt/cappuccino","forks_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/forks","keys_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/keys{/key_id}","collaborators_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/teams","hooks_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/hooks","issue_events_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/issues/events{/number}","events_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/events","assignees_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/assignees{/user}","branches_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/branches{/branch}","tags_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/tags","blobs_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/git/refs{/sha}","trees_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/git/trees{/sha}","statuses_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/statuses/{sha}","languages_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/languages","stargazers_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/stargazers","contributors_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/contributors","subscribers_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/subscribers","subscription_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/subscription","commits_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/commits{/sha}","git_commits_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/git/commits{/sha}","comments_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/comments{/number}","issue_comment_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/issues/comments{/number}","contents_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/contents/{+path}","compare_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/compare/{base}...{head}","merges_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/merges","archive_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/downloads","issues_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/issues{/number}","pulls_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/pulls{/number}","milestones_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/milestones{/number}","notifications_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/labels{/name}","releases_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/releases{/id}","deployments_url":"https://api.github.com/repos/didierkorthoudt/cappuccino/deployments","created_at":"2015-10-30T08:13:29Z","updated_at":"2016-01-16T17:22:17Z","pushed_at":"2016-10-31T15:35:42Z","git_url":"git://github.com/didierkorthoudt/cappuccino.git","ssh_url":"git@github.com:didierkorthoudt/cappuccino.git","clone_url":"https://github.com/didierkorthoudt/cappuccino.git","svn_url":"https://github.com/didierkorthoudt/cappuccino","homepage":"http://cappuccino-project.org","size":51182,"stargazers_count":0,"watchers_count":0,"language":"Objective-J","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cappuccino:master","ref":"master","sha":"ef1d6c78ac7fcc3f2b027e00a4fc20073003e497","user":{"login":"cappuccino","id":16595,"avatar_url":"https://avatars.githubusercontent.com/u/16595?v=3","gravatar_id":"","url":"https://api.github.com/users/cappuccino","html_url":"https://github.com/cappuccino","followers_url":"https://api.github.com/users/cappuccino/followers","following_url":"https://api.github.com/users/cappuccino/following{/other_user}","gists_url":"https://api.github.com/users/cappuccino/gists{/gist_id}","starred_url":"https://api.github.com/users/cappuccino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cappuccino/subscriptions","organizations_url":"https://api.github.com/users/cappuccino/orgs","repos_url":"https://api.github.com/users/cappuccino/repos","events_url":"https://api.github.com/users/cappuccino/events{/privacy}","received_events_url":"https://api.github.com/users/cappuccino/received_events","type":"Organization","site_admin":false},"repo":{"id":49107,"name":"cappuccino","full_name":"cappuccino/cappuccino","owner":{"login":"cappuccino","id":16595,"avatar_url":"https://avatars.githubusercontent.com/u/16595?v=3","gravatar_id":"","url":"https://api.github.com/users/cappuccino","html_url":"https://github.com/cappuccino","followers_url":"https://api.github.com/users/cappuccino/followers","following_url":"https://api.github.com/users/cappuccino/following{/other_user}","gists_url":"https://api.github.com/users/cappuccino/gists{/gist_id}","starred_url":"https://api.github.com/users/cappuccino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cappuccino/subscriptions","organizations_url":"https://api.github.com/users/cappuccino/orgs","repos_url":"https://api.github.com/users/cappuccino/repos","events_url":"https://api.github.com/users/cappuccino/events{/privacy}","received_events_url":"https://api.github.com/users/cappuccino/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cappuccino/cappuccino","description":"Web Application Framework in JavaScript and Objective-J","fork":false,"url":"https://api.github.com/repos/cappuccino/cappuccino","forks_url":"https://api.github.com/repos/cappuccino/cappuccino/forks","keys_url":"https://api.github.com/repos/cappuccino/cappuccino/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cappuccino/cappuccino/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cappuccino/cappuccino/teams","hooks_url":"https://api.github.com/repos/cappuccino/cappuccino/hooks","issue_events_url":"https://api.github.com/repos/cappuccino/cappuccino/issues/events{/number}","events_url":"https://api.github.com/repos/cappuccino/cappuccino/events","assignees_url":"https://api.github.com/repos/cappuccino/cappuccino/assignees{/user}","branches_url":"https://api.github.com/repos/cappuccino/cappuccino/branches{/branch}","tags_url":"https://api.github.com/repos/cappuccino/cappuccino/tags","blobs_url":"https://api.github.com/repos/cappuccino/cappuccino/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cappuccino/cappuccino/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cappuccino/cappuccino/git/refs{/sha}","trees_url":"https://api.github.com/repos/cappuccino/cappuccino/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cappuccino/cappuccino/statuses/{sha}","languages_url":"https://api.github.com/repos/cappuccino/cappuccino/languages","stargazers_url":"https://api.github.com/repos/cappuccino/cappuccino/stargazers","contributors_url":"https://api.github.com/repos/cappuccino/cappuccino/contributors","subscribers_url":"https://api.github.com/repos/cappuccino/cappuccino/subscribers","subscription_url":"https://api.github.com/repos/cappuccino/cappuccino/subscription","commits_url":"https://api.github.com/repos/cappuccino/cappuccino/commits{/sha}","git_commits_url":"https://api.github.com/repos/cappuccino/cappuccino/git/commits{/sha}","comments_url":"https://api.github.com/repos/cappuccino/cappuccino/comments{/number}","issue_comment_url":"https://api.github.com/repos/cappuccino/cappuccino/issues/comments{/number}","contents_url":"https://api.github.com/repos/cappuccino/cappuccino/contents/{+path}","compare_url":"https://api.github.com/repos/cappuccino/cappuccino/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cappuccino/cappuccino/merges","archive_url":"https://api.github.com/repos/cappuccino/cappuccino/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cappuccino/cappuccino/downloads","issues_url":"https://api.github.com/repos/cappuccino/cappuccino/issues{/number}","pulls_url":"https://api.github.com/repos/cappuccino/cappuccino/pulls{/number}","milestones_url":"https://api.github.com/repos/cappuccino/cappuccino/milestones{/number}","notifications_url":"https://api.github.com/repos/cappuccino/cappuccino/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cappuccino/cappuccino/labels{/name}","releases_url":"https://api.github.com/repos/cappuccino/cappuccino/releases{/id}","deployments_url":"https://api.github.com/repos/cappuccino/cappuccino/deployments","created_at":"2008-09-04T10:43:35Z","updated_at":"2016-10-28T11:12:25Z","pushed_at":"2016-10-31T22:23:14Z","git_url":"git://github.com/cappuccino/cappuccino.git","ssh_url":"git@github.com:cappuccino/cappuccino.git","clone_url":"https://github.com/cappuccino/cappuccino.git","svn_url":"https://github.com/cappuccino/cappuccino","homepage":"http://cappuccino-project.org","size":57228,"stargazers_count":2122,"watchers_count":2122,"language":"Objective-J","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":349,"mirror_url":null,"open_issues_count":106,"forks":349,"open_issues":106,"watchers":2122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cappuccino/cappuccino/pulls/2502"},"html":{"href":"https://github.com/cappuccino/cappuccino/pull/2502"},"issue":{"href":"https://api.github.com/repos/cappuccino/cappuccino/issues/2502"},"comments":{"href":"https://api.github.com/repos/cappuccino/cappuccino/issues/2502/comments"},"review_comments":{"href":"https://api.github.com/repos/cappuccino/cappuccino/pulls/2502/comments"},"review_comment":{"href":"https://api.github.com/repos/cappuccino/cappuccino/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cappuccino/cappuccino/pulls/2502/commits"},"statuses":{"href":"https://api.github.com/repos/cappuccino/cappuccino/statuses/bdc3d00fe2a8d420861e8d80ca16df7e18968334"}}}}
{"actor":{"display_login":"didierkorthoudt"}}