{"action":"closed","number":14,"pull_request":{"url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/pulls/14","id":58879494,"html_url":"https://github.com/mozilla-services/pyramid_multiauth/pull/14","diff_url":"https://github.com/mozilla-services/pyramid_multiauth/pull/14.diff","patch_url":"https://github.com/mozilla-services/pyramid_multiauth/pull/14.patch","issue_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/issues/14","number":14,"state":"closed","locked":false,"title":"Always trigger event and provide userid","user":{"login":"leplatrem","id":546692,"avatar_url":"https://avatars.githubusercontent.com/u/546692?v=3","gravatar_id":"","url":"https://api.github.com/users/leplatrem","html_url":"https://github.com/leplatrem","followers_url":"https://api.github.com/users/leplatrem/followers","following_url":"https://api.github.com/users/leplatrem/following{/other_user}","gists_url":"https://api.github.com/users/leplatrem/gists{/gist_id}","starred_url":"https://api.github.com/users/leplatrem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leplatrem/subscriptions","organizations_url":"https://api.github.com/users/leplatrem/orgs","repos_url":"https://api.github.com/users/leplatrem/repos","events_url":"https://api.github.com/users/leplatrem/events{/privacy}","received_events_url":"https://api.github.com/users/leplatrem/received_events","type":"User","site_admin":false},"body":"When the selected policy event is notified, it is very useful to have the authenticated userid at hand.\r\nThis PR provides it.\r\n\r\nAlso, this PR fixes a *«bug»* about the event not being always triggered.\r\nIndeed, for the permissions Pyramid calls `effective_principals()` which also calls `authenticated_userid()` of every contained policy. Whereas the event was sent when `authenticated_userid()` was called explicitly, it wasn't sent when only `effective_principals()` was called.\r\n\r\n@almet @rfk r?\r\n\r\n","created_at":"2016-02-10T11:44:01Z","updated_at":"2016-02-11T13:41:38Z","closed_at":"2016-02-11T13:41:37Z","merged_at":"2016-02-11T13:41:37Z","merge_commit_sha":"378889ea3e5402e3e7656abee9333481a68f3475","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/pulls/14/commits","review_comments_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/pulls/14/comments","review_comment_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/issues/14/comments","statuses_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/statuses/e95d33979f4bc590e35d83bc9820a6058f7dc56b","head":{"label":"mozilla-services:provide-userid-event","ref":"provide-userid-event","sha":"e95d33979f4bc590e35d83bc9820a6058f7dc56b","user":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"repo":{"id":2618039,"name":"pyramid_multiauth","full_name":"mozilla-services/pyramid_multiauth","owner":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-services/pyramid_multiauth","description":"stacked authentication policies for pyramid","fork":false,"url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth","forks_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/forks","keys_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/teams","hooks_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/hooks","issue_events_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/events","assignees_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/tags","blobs_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/languages","stargazers_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/stargazers","contributors_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/contributors","subscribers_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/subscribers","subscription_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/subscription","commits_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/merges","archive_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/downloads","issues_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/deployments","created_at":"2011-10-21T04:06:46Z","updated_at":"2016-02-09T16:10:42Z","pushed_at":"2016-02-11T13:41:37Z","git_url":"git://github.com/mozilla-services/pyramid_multiauth.git","ssh_url":"git@github.com:mozilla-services/pyramid_multiauth.git","clone_url":"https://github.com/mozilla-services/pyramid_multiauth.git","svn_url":"https://github.com/mozilla-services/pyramid_multiauth","homepage":"","size":57,"stargazers_count":24,"watchers_count":24,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":24,"default_branch":"master"}},"base":{"label":"mozilla-services:master","ref":"master","sha":"3ff9372f02be1b569be40a4ea06f612683276432","user":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"repo":{"id":2618039,"name":"pyramid_multiauth","full_name":"mozilla-services/pyramid_multiauth","owner":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-services/pyramid_multiauth","description":"stacked authentication policies for pyramid","fork":false,"url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth","forks_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/forks","keys_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/teams","hooks_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/hooks","issue_events_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/events","assignees_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/tags","blobs_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/languages","stargazers_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/stargazers","contributors_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/contributors","subscribers_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/subscribers","subscription_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/subscription","commits_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/merges","archive_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/downloads","issues_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/deployments","created_at":"2011-10-21T04:06:46Z","updated_at":"2016-02-09T16:10:42Z","pushed_at":"2016-02-11T13:41:37Z","git_url":"git://github.com/mozilla-services/pyramid_multiauth.git","ssh_url":"git@github.com:mozilla-services/pyramid_multiauth.git","clone_url":"https://github.com/mozilla-services/pyramid_multiauth.git","svn_url":"https://github.com/mozilla-services/pyramid_multiauth","homepage":"","size":57,"stargazers_count":24,"watchers_count":24,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/pulls/14"},"html":{"href":"https://github.com/mozilla-services/pyramid_multiauth/pull/14"},"issue":{"href":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/issues/14"},"comments":{"href":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-services/pyramid_multiauth/statuses/e95d33979f4bc590e35d83bc9820a6058f7dc56b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"leplatrem","id":546692,"avatar_url":"https://avatars.githubusercontent.com/u/546692?v=3","gravatar_id":"","url":"https://api.github.com/users/leplatrem","html_url":"https://github.com/leplatrem","followers_url":"https://api.github.com/users/leplatrem/followers","following_url":"https://api.github.com/users/leplatrem/following{/other_user}","gists_url":"https://api.github.com/users/leplatrem/gists{/gist_id}","starred_url":"https://api.github.com/users/leplatrem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leplatrem/subscriptions","organizations_url":"https://api.github.com/users/leplatrem/orgs","repos_url":"https://api.github.com/users/leplatrem/repos","events_url":"https://api.github.com/users/leplatrem/events{/privacy}","received_events_url":"https://api.github.com/users/leplatrem/received_events","type":"User","site_admin":false},"comments":3,"review_comments":2,"commits":3,"additions":19,"deletions":5,"changed_files":3}}