{"action":"created","comment":{"url":"https://api.github.com/repos/datacleaner/DataCleaner/pulls/comments/73325231","id":73325231,"diff_hunk":"@@ -132,12 +133,12 @@ public Query optimizeQuery(Query q, NullCheckCategory category) {\n                 }\n                 q.where(column, OperatorType.DIFFERENT_FROM, null);\n                 if (considerEmptyStringAsNull && col.getDataType() == String.class) {\n-                    q.where(column, OperatorType.DIFFERENT_FROM, \"\");\n+                    q.having(FunctionType.TO_BOOLEAN, column, OperatorType.EQUALS_TO, \"TRUE\");","path":"components/basic-filters/src/main/java/org/datacleaner/beans/filter/NullCheckFilter.java","position":null,"original_position":50,"commit_id":"76b92362a5d5dee1811d83d215515d9b2fb97c8d","original_commit_id":"dafb7eff82cda684493d7e61bf2bf925bc92bb91","user":{"login":"jhorcicka","id":13213915,"avatar_url":"https://avatars.githubusercontent.com/u/13213915?v=3","gravatar_id":"","url":"https://api.github.com/users/jhorcicka","html_url":"https://github.com/jhorcicka","followers_url":"https://api.github.com/users/jhorcicka/followers","following_url":"https://api.github.com/users/jhorcicka/following{/other_user}","gists_url":"https://api.github.com/users/jhorcicka/gists{/gist_id}","starred_url":"https://api.github.com/users/jhorcicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhorcicka/subscriptions","organizations_url":"https://api.github.com/users/jhorcicka/orgs","repos_url":"https://api.github.com/users/jhorcicka/repos","events_url":"https://api.github.com/users/jhorcicka/events{/privacy}","received_events_url":"https://api.github.com/users/jhorcicka/received_events","type":"User","site_admin":false},"body":"You are right. It does not work. Now it even gives me an exception when run against oracle db. I don't know what I tested yesterday that it worked. ","created_at":"2016-08-03T11:51:39Z","updated_at":"2016-08-03T11:51:39Z","html_url":"https://github.com/datacleaner/DataCleaner/pull/1426#discussion_r73325231","pull_request_url":"https://api.github.com/repos/datacleaner/DataCleaner/pulls/1426","_links":{"self":{"href":"https://api.github.com/repos/datacleaner/DataCleaner/pulls/comments/73325231"},"html":{"href":"https://github.com/datacleaner/DataCleaner/pull/1426#discussion_r73325231"},"pull_request":{"href":"https://api.github.com/repos/datacleaner/DataCleaner/pulls/1426"}}},"pull_request":{"url":"https://api.github.com/repos/datacleaner/DataCleaner/pulls/1426","id":76554696,"html_url":"https://github.com/datacleaner/DataCleaner/pull/1426","diff_url":"https://github.com/datacleaner/DataCleaner/pull/1426.diff","patch_url":"https://github.com/datacleaner/DataCleaner/pull/1426.patch","issue_url":"https://api.github.com/repos/datacleaner/DataCleaner/issues/1426","number":1426,"state":"open","locked":false,"title":"Bug/1424 null check filter considers empty strings as null","user":{"login":"jhorcicka","id":13213915,"avatar_url":"https://avatars.githubusercontent.com/u/13213915?v=3","gravatar_id":"","url":"https://api.github.com/users/jhorcicka","html_url":"https://github.com/jhorcicka","followers_url":"https://api.github.com/users/jhorcicka/followers","following_url":"https://api.github.com/users/jhorcicka/following{/other_user}","gists_url":"https://api.github.com/users/jhorcicka/gists{/gist_id}","starred_url":"https://api.github.com/users/jhorcicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhorcicka/subscriptions","organizations_url":"https://api.github.com/users/jhorcicka/orgs","repos_url":"https://api.github.com/users/jhorcicka/repos","events_url":"https://api.github.com/users/jhorcicka/events{/privacy}","received_events_url":"https://api.github.com/users/jhorcicka/received_events","type":"User","site_admin":false},"body":"Fixes #1424. \r\n\r\nProblem with \"optimized sql condition\" in NullCheckFilter with \"Consider empty strings as null\" checked. \r\n\r\nCondition ```<Operator.DIFFERENT_FROM, \"\">``` was replaced by ```<Operator.LIKE, \"%\">```. \r\n","created_at":"2016-07-07T08:11:06Z","updated_at":"2016-08-03T11:51:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fcb538e81dfc895277eab62b5a70cfc4b61cff19","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/datacleaner/DataCleaner/pulls/1426/commits","review_comments_url":"https://api.github.com/repos/datacleaner/DataCleaner/pulls/1426/comments","review_comment_url":"https://api.github.com/repos/datacleaner/DataCleaner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/datacleaner/DataCleaner/issues/1426/comments","statuses_url":"https://api.github.com/repos/datacleaner/DataCleaner/statuses/76b92362a5d5dee1811d83d215515d9b2fb97c8d","head":{"label":"datacleaner:bug/1424-null-check-filter-consider-empty-strings-as-null","ref":"bug/1424-null-check-filter-consider-empty-strings-as-null","sha":"76b92362a5d5dee1811d83d215515d9b2fb97c8d","user":{"login":"datacleaner","id":1665195,"avatar_url":"https://avatars.githubusercontent.com/u/1665195?v=3","gravatar_id":"","url":"https://api.github.com/users/datacleaner","html_url":"https://github.com/datacleaner","followers_url":"https://api.github.com/users/datacleaner/followers","following_url":"https://api.github.com/users/datacleaner/following{/other_user}","gists_url":"https://api.github.com/users/datacleaner/gists{/gist_id}","starred_url":"https://api.github.com/users/datacleaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datacleaner/subscriptions","organizations_url":"https://api.github.com/users/datacleaner/orgs","repos_url":"https://api.github.com/users/datacleaner/repos","events_url":"https://api.github.com/users/datacleaner/events{/privacy}","received_events_url":"https://api.github.com/users/datacleaner/received_events","type":"Organization","site_admin":false},"repo":{"id":17034809,"name":"DataCleaner","full_name":"datacleaner/DataCleaner","owner":{"login":"datacleaner","id":1665195,"avatar_url":"https://avatars.githubusercontent.com/u/1665195?v=3","gravatar_id":"","url":"https://api.github.com/users/datacleaner","html_url":"https://github.com/datacleaner","followers_url":"https://api.github.com/users/datacleaner/followers","following_url":"https://api.github.com/users/datacleaner/following{/other_user}","gists_url":"https://api.github.com/users/datacleaner/gists{/gist_id}","starred_url":"https://api.github.com/users/datacleaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datacleaner/subscriptions","organizations_url":"https://api.github.com/users/datacleaner/orgs","repos_url":"https://api.github.com/users/datacleaner/repos","events_url":"https://api.github.com/users/datacleaner/events{/privacy}","received_events_url":"https://api.github.com/users/datacleaner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datacleaner/DataCleaner","description":"The premier open source Data Quality solution","fork":false,"url":"https://api.github.com/repos/datacleaner/DataCleaner","forks_url":"https://api.github.com/repos/datacleaner/DataCleaner/forks","keys_url":"https://api.github.com/repos/datacleaner/DataCleaner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datacleaner/DataCleaner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datacleaner/DataCleaner/teams","hooks_url":"https://api.github.com/repos/datacleaner/DataCleaner/hooks","issue_events_url":"https://api.github.com/repos/datacleaner/DataCleaner/issues/events{/number}","events_url":"https://api.github.com/repos/datacleaner/DataCleaner/events","assignees_url":"https://api.github.com/repos/datacleaner/DataCleaner/assignees{/user}","branches_url":"https://api.github.com/repos/datacleaner/DataCleaner/branches{/branch}","tags_url":"https://api.github.com/repos/datacleaner/DataCleaner/tags","blobs_url":"https://api.github.com/repos/datacleaner/DataCleaner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datacleaner/DataCleaner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datacleaner/DataCleaner/git/refs{/sha}","trees_url":"https://api.github.com/repos/datacleaner/DataCleaner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datacleaner/DataCleaner/statuses/{sha}","languages_url":"https://api.github.com/repos/datacleaner/DataCleaner/languages","stargazers_url":"https://api.github.com/repos/datacleaner/DataCleaner/stargazers","contributors_url":"https://api.github.com/repos/datacleaner/DataCleaner/contributors","subscribers_url":"https://api.github.com/repos/datacleaner/DataCleaner/subscribers","subscription_url":"https://api.github.com/repos/datacleaner/DataCleaner/subscription","commits_url":"https://api.github.com/repos/datacleaner/DataCleaner/commits{/sha}","git_commits_url":"https://api.github.com/repos/datacleaner/DataCleaner/git/commits{/sha}","comments_url":"https://api.github.com/repos/datacleaner/DataCleaner/comments{/number}","issue_comment_url":"https://api.github.com/repos/datacleaner/DataCleaner/issues/comments{/number}","contents_url":"https://api.github.com/repos/datacleaner/DataCleaner/contents/{+path}","compare_url":"https://api.github.com/repos/datacleaner/DataCleaner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datacleaner/DataCleaner/merges","archive_url":"https://api.github.com/repos/datacleaner/DataCleaner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datacleaner/DataCleaner/downloads","issues_url":"https://api.github.com/repos/datacleaner/DataCleaner/issues{/number}","pulls_url":"https://api.github.com/repos/datacleaner/DataCleaner/pulls{/number}","milestones_url":"https://api.github.com/repos/datacleaner/DataCleaner/milestones{/number}","notifications_url":"https://api.github.com/repos/datacleaner/DataCleaner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datacleaner/DataCleaner/labels{/name}","releases_url":"https://api.github.com/repos/datacleaner/DataCleaner/releases{/id}","deployments_url":"https://api.github.com/repos/datacleaner/DataCleaner/deployments","created_at":"2014-02-20T20:37:25Z","updated_at":"2016-07-20T02:58:24Z","pushed_at":"2016-08-03T11:49:51Z","git_url":"git://github.com/datacleaner/DataCleaner.git","ssh_url":"git@github.com:datacleaner/DataCleaner.git","clone_url":"https://github.com/datacleaner/DataCleaner.git","svn_url":"https://github.com/datacleaner/DataCleaner","homepage":null,"size":171128,"stargazers_count":70,"watchers_count":70,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":209,"forks":42,"open_issues":209,"watchers":70,"default_branch":"master"}},"base":{"label":"datacleaner:master","ref":"master","sha":"558bd59b76a4d43b06a4cfb09a7b926e540d0bf0","user":{"login":"datacleaner","id":1665195,"avatar_url":"https://avatars.githubusercontent.com/u/1665195?v=3","gravatar_id":"","url":"https://api.github.com/users/datacleaner","html_url":"https://github.com/datacleaner","followers_url":"https://api.github.com/users/datacleaner/followers","following_url":"https://api.github.com/users/datacleaner/following{/other_user}","gists_url":"https://api.github.com/users/datacleaner/gists{/gist_id}","starred_url":"https://api.github.com/users/datacleaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datacleaner/subscriptions","organizations_url":"https://api.github.com/users/datacleaner/orgs","repos_url":"https://api.github.com/users/datacleaner/repos","events_url":"https://api.github.com/users/datacleaner/events{/privacy}","received_events_url":"https://api.github.com/users/datacleaner/received_events","type":"Organization","site_admin":false},"repo":{"id":17034809,"name":"DataCleaner","full_name":"datacleaner/DataCleaner","owner":{"login":"datacleaner","id":1665195,"avatar_url":"https://avatars.githubusercontent.com/u/1665195?v=3","gravatar_id":"","url":"https://api.github.com/users/datacleaner","html_url":"https://github.com/datacleaner","followers_url":"https://api.github.com/users/datacleaner/followers","following_url":"https://api.github.com/users/datacleaner/following{/other_user}","gists_url":"https://api.github.com/users/datacleaner/gists{/gist_id}","starred_url":"https://api.github.com/users/datacleaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datacleaner/subscriptions","organizations_url":"https://api.github.com/users/datacleaner/orgs","repos_url":"https://api.github.com/users/datacleaner/repos","events_url":"https://api.github.com/users/datacleaner/events{/privacy}","received_events_url":"https://api.github.com/users/datacleaner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datacleaner/DataCleaner","description":"The premier open source Data Quality solution","fork":false,"url":"https://api.github.com/repos/datacleaner/DataCleaner","forks_url":"https://api.github.com/repos/datacleaner/DataCleaner/forks","keys_url":"https://api.github.com/repos/datacleaner/DataCleaner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datacleaner/DataCleaner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datacleaner/DataCleaner/teams","hooks_url":"https://api.github.com/repos/datacleaner/DataCleaner/hooks","issue_events_url":"https://api.github.com/repos/datacleaner/DataCleaner/issues/events{/number}","events_url":"https://api.github.com/repos/datacleaner/DataCleaner/events","assignees_url":"https://api.github.com/repos/datacleaner/DataCleaner/assignees{/user}","branches_url":"https://api.github.com/repos/datacleaner/DataCleaner/branches{/branch}","tags_url":"https://api.github.com/repos/datacleaner/DataCleaner/tags","blobs_url":"https://api.github.com/repos/datacleaner/DataCleaner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datacleaner/DataCleaner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datacleaner/DataCleaner/git/refs{/sha}","trees_url":"https://api.github.com/repos/datacleaner/DataCleaner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datacleaner/DataCleaner/statuses/{sha}","languages_url":"https://api.github.com/repos/datacleaner/DataCleaner/languages","stargazers_url":"https://api.github.com/repos/datacleaner/DataCleaner/stargazers","contributors_url":"https://api.github.com/repos/datacleaner/DataCleaner/contributors","subscribers_url":"https://api.github.com/repos/datacleaner/DataCleaner/subscribers","subscription_url":"https://api.github.com/repos/datacleaner/DataCleaner/subscription","commits_url":"https://api.github.com/repos/datacleaner/DataCleaner/commits{/sha}","git_commits_url":"https://api.github.com/repos/datacleaner/DataCleaner/git/commits{/sha}","comments_url":"https://api.github.com/repos/datacleaner/DataCleaner/comments{/number}","issue_comment_url":"https://api.github.com/repos/datacleaner/DataCleaner/issues/comments{/number}","contents_url":"https://api.github.com/repos/datacleaner/DataCleaner/contents/{+path}","compare_url":"https://api.github.com/repos/datacleaner/DataCleaner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datacleaner/DataCleaner/merges","archive_url":"https://api.github.com/repos/datacleaner/DataCleaner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datacleaner/DataCleaner/downloads","issues_url":"https://api.github.com/repos/datacleaner/DataCleaner/issues{/number}","pulls_url":"https://api.github.com/repos/datacleaner/DataCleaner/pulls{/number}","milestones_url":"https://api.github.com/repos/datacleaner/DataCleaner/milestones{/number}","notifications_url":"https://api.github.com/repos/datacleaner/DataCleaner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datacleaner/DataCleaner/labels{/name}","releases_url":"https://api.github.com/repos/datacleaner/DataCleaner/releases{/id}","deployments_url":"https://api.github.com/repos/datacleaner/DataCleaner/deployments","created_at":"2014-02-20T20:37:25Z","updated_at":"2016-07-20T02:58:24Z","pushed_at":"2016-08-03T11:49:51Z","git_url":"git://github.com/datacleaner/DataCleaner.git","ssh_url":"git@github.com:datacleaner/DataCleaner.git","clone_url":"https://github.com/datacleaner/DataCleaner.git","svn_url":"https://github.com/datacleaner/DataCleaner","homepage":null,"size":171128,"stargazers_count":70,"watchers_count":70,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":209,"forks":42,"open_issues":209,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/datacleaner/DataCleaner/pulls/1426"},"html":{"href":"https://github.com/datacleaner/DataCleaner/pull/1426"},"issue":{"href":"https://api.github.com/repos/datacleaner/DataCleaner/issues/1426"},"comments":{"href":"https://api.github.com/repos/datacleaner/DataCleaner/issues/1426/comments"},"review_comments":{"href":"https://api.github.com/repos/datacleaner/DataCleaner/pulls/1426/comments"},"review_comment":{"href":"https://api.github.com/repos/datacleaner/DataCleaner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/datacleaner/DataCleaner/pulls/1426/commits"},"statuses":{"href":"https://api.github.com/repos/datacleaner/DataCleaner/statuses/76b92362a5d5dee1811d83d215515d9b2fb97c8d"}}}}
{"actor":{"display_login":"jhorcicka"}}