{"action":"created","comment":{"url":"https://api.github.com/repos/ecosoft-odoo/cft/pulls/comments/92147344","pull_request_review_id":12655479,"id":92147344,"diff_hunk":"@@ -61,11 +61,8 @@ def _check_partner_name(self):\n     @api.constrains('vat', 'taxbranch')\n     def _check_vat_taxbranch_unique(self):\n         if self.vat or self.taxbranch:\n-            count = self.search_count(\n-                ['|', ('parent_id', '=', False),\n-                 ('is_company', '=', True),\n-                 ('vat', '=', self.vat),\n-                 ('taxbranch', '=', self.taxbranch)])\n+            count = self.search_count([('vat', '=', self.vat),\n+                                       ('taxbranch', '=', self.taxbranch)])","path":"l10n_th_fields/models/partner.py","position":10,"original_position":10,"commit_id":"b9fc9adbead1cf68c1485473c501f1685e7f0dae","original_commit_id":"857f39dd59f8bd89e02de9804d0313b288f9ee15","user":{"login":"yostashiro","id":7766939,"avatar_url":"https://avatars.githubusercontent.com/u/7766939?v=3","gravatar_id":"","url":"https://api.github.com/users/yostashiro","html_url":"https://github.com/yostashiro","followers_url":"https://api.github.com/users/yostashiro/followers","following_url":"https://api.github.com/users/yostashiro/following{/other_user}","gists_url":"https://api.github.com/users/yostashiro/gists{/gist_id}","starred_url":"https://api.github.com/users/yostashiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yostashiro/subscriptions","organizations_url":"https://api.github.com/users/yostashiro/orgs","repos_url":"https://api.github.com/users/yostashiro/repos","events_url":"https://api.github.com/users/yostashiro/events{/privacy}","received_events_url":"https://api.github.com/users/yostashiro/received_events","type":"User","site_admin":false},"body":"> Can you tell me what is it for?\r\n\r\nWe had a discussion in mid August and agreed with this change.  Please find the email thread titled \"Re: CFT - constraint on Tax ID and Tax Branch ID\".\r\n\r\n> Note: I was having problem when I pull the lastest cft code last week. Got warning saving a customer, even it has unique vat + taxbranch.\r\n\r\nAre you sure that vat + tax branch was unique?  I get the error in my test env now after pulling your branch because there are customers with parent (company) - child (contact) relationship and they share the same vat (when you create a contact for a company, by default vat is inherited from the parent, which is Odoo's standard design).  So, the whole point of my above adjustment is to bypass these cases in checking.","created_at":"2016-12-13T11:15:22Z","updated_at":"2016-12-13T11:17:19Z","html_url":"https://github.com/ecosoft-odoo/cft/pull/70#discussion_r92147344","pull_request_url":"https://api.github.com/repos/ecosoft-odoo/cft/pulls/70","_links":{"self":{"href":"https://api.github.com/repos/ecosoft-odoo/cft/pulls/comments/92147344"},"html":{"href":"https://github.com/ecosoft-odoo/cft/pull/70#discussion_r92147344"},"pull_request":{"href":"https://api.github.com/repos/ecosoft-odoo/cft/pulls/70"}}},"pull_request":{"url":"https://api.github.com/repos/ecosoft-odoo/cft/pulls/70","id":97462133,"html_url":"https://github.com/ecosoft-odoo/cft/pull/70","diff_url":"https://github.com/ecosoft-odoo/cft/pull/70.diff","patch_url":"https://github.com/ecosoft-odoo/cft/pull/70.patch","issue_url":"https://api.github.com/repos/ecosoft-odoo/cft/issues/70","number":70,"state":"open","locked":false,"title":"Update module related to new Thai VAT Report","user":{"login":"kittiu","id":1973598,"avatar_url":"https://avatars.githubusercontent.com/u/1973598?v=3","gravatar_id":"","url":"https://api.github.com/users/kittiu","html_url":"https://github.com/kittiu","followers_url":"https://api.github.com/users/kittiu/followers","following_url":"https://api.github.com/users/kittiu/following{/other_user}","gists_url":"https://api.github.com/users/kittiu/gists{/gist_id}","starred_url":"https://api.github.com/users/kittiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kittiu/subscriptions","organizations_url":"https://api.github.com/users/kittiu/orgs","repos_url":"https://api.github.com/users/kittiu/repos","events_url":"https://api.github.com/users/kittiu/events{/privacy}","received_events_url":"https://api.github.com/users/kittiu/received_events","type":"User","site_admin":false},"body":"- l10n_th_account\r\n- l10n_th_account_tax_detail\r\n- l10n_th_fields\r\n- l10n_th_tax_report","created_at":"2016-12-11T15:26:44Z","updated_at":"2016-12-13T11:17:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de82ce0572f2b1f4f0ff34559731285bde0fc76d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ecosoft-odoo/cft/pulls/70/commits","review_comments_url":"https://api.github.com/repos/ecosoft-odoo/cft/pulls/70/comments","review_comment_url":"https://api.github.com/repos/ecosoft-odoo/cft/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ecosoft-odoo/cft/issues/70/comments","statuses_url":"https://api.github.com/repos/ecosoft-odoo/cft/statuses/b9fc9adbead1cf68c1485473c501f1685e7f0dae","head":{"label":"ecosoft-odoo:kittiu-tax_report","ref":"kittiu-tax_report","sha":"b9fc9adbead1cf68c1485473c501f1685e7f0dae","user":{"login":"ecosoft-odoo","id":13600991,"avatar_url":"https://avatars.githubusercontent.com/u/13600991?v=3","gravatar_id":"","url":"https://api.github.com/users/ecosoft-odoo","html_url":"https://github.com/ecosoft-odoo","followers_url":"https://api.github.com/users/ecosoft-odoo/followers","following_url":"https://api.github.com/users/ecosoft-odoo/following{/other_user}","gists_url":"https://api.github.com/users/ecosoft-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/ecosoft-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecosoft-odoo/subscriptions","organizations_url":"https://api.github.com/users/ecosoft-odoo/orgs","repos_url":"https://api.github.com/users/ecosoft-odoo/repos","events_url":"https://api.github.com/users/ecosoft-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/ecosoft-odoo/received_events","type":"User","site_admin":false},"repo":{"id":64775161,"name":"cft","full_name":"ecosoft-odoo/cft","owner":{"login":"ecosoft-odoo","id":13600991,"avatar_url":"https://avatars.githubusercontent.com/u/13600991?v=3","gravatar_id":"","url":"https://api.github.com/users/ecosoft-odoo","html_url":"https://github.com/ecosoft-odoo","followers_url":"https://api.github.com/users/ecosoft-odoo/followers","following_url":"https://api.github.com/users/ecosoft-odoo/following{/other_user}","gists_url":"https://api.github.com/users/ecosoft-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/ecosoft-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecosoft-odoo/subscriptions","organizations_url":"https://api.github.com/users/ecosoft-odoo/orgs","repos_url":"https://api.github.com/users/ecosoft-odoo/repos","events_url":"https://api.github.com/users/ecosoft-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/ecosoft-odoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ecosoft-odoo/cft","description":null,"fork":false,"url":"https://api.github.com/repos/ecosoft-odoo/cft","forks_url":"https://api.github.com/repos/ecosoft-odoo/cft/forks","keys_url":"https://api.github.com/repos/ecosoft-odoo/cft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ecosoft-odoo/cft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ecosoft-odoo/cft/teams","hooks_url":"https://api.github.com/repos/ecosoft-odoo/cft/hooks","issue_events_url":"https://api.github.com/repos/ecosoft-odoo/cft/issues/events{/number}","events_url":"https://api.github.com/repos/ecosoft-odoo/cft/events","assignees_url":"https://api.github.com/repos/ecosoft-odoo/cft/assignees{/user}","branches_url":"https://api.github.com/repos/ecosoft-odoo/cft/branches{/branch}","tags_url":"https://api.github.com/repos/ecosoft-odoo/cft/tags","blobs_url":"https://api.github.com/repos/ecosoft-odoo/cft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ecosoft-odoo/cft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ecosoft-odoo/cft/git/refs{/sha}","trees_url":"https://api.github.com/repos/ecosoft-odoo/cft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ecosoft-odoo/cft/statuses/{sha}","languages_url":"https://api.github.com/repos/ecosoft-odoo/cft/languages","stargazers_url":"https://api.github.com/repos/ecosoft-odoo/cft/stargazers","contributors_url":"https://api.github.com/repos/ecosoft-odoo/cft/contributors","subscribers_url":"https://api.github.com/repos/ecosoft-odoo/cft/subscribers","subscription_url":"https://api.github.com/repos/ecosoft-odoo/cft/subscription","commits_url":"https://api.github.com/repos/ecosoft-odoo/cft/commits{/sha}","git_commits_url":"https://api.github.com/repos/ecosoft-odoo/cft/git/commits{/sha}","comments_url":"https://api.github.com/repos/ecosoft-odoo/cft/comments{/number}","issue_comment_url":"https://api.github.com/repos/ecosoft-odoo/cft/issues/comments{/number}","contents_url":"https://api.github.com/repos/ecosoft-odoo/cft/contents/{+path}","compare_url":"https://api.github.com/repos/ecosoft-odoo/cft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ecosoft-odoo/cft/merges","archive_url":"https://api.github.com/repos/ecosoft-odoo/cft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ecosoft-odoo/cft/downloads","issues_url":"https://api.github.com/repos/ecosoft-odoo/cft/issues{/number}","pulls_url":"https://api.github.com/repos/ecosoft-odoo/cft/pulls{/number}","milestones_url":"https://api.github.com/repos/ecosoft-odoo/cft/milestones{/number}","notifications_url":"https://api.github.com/repos/ecosoft-odoo/cft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ecosoft-odoo/cft/labels{/name}","releases_url":"https://api.github.com/repos/ecosoft-odoo/cft/releases{/id}","deployments_url":"https://api.github.com/repos/ecosoft-odoo/cft/deployments","created_at":"2016-08-02T16:51:33Z","updated_at":"2016-08-09T02:33:11Z","pushed_at":"2016-12-13T10:23:54Z","git_url":"git://github.com/ecosoft-odoo/cft.git","ssh_url":"git@github.com:ecosoft-odoo/cft.git","clone_url":"https://github.com/ecosoft-odoo/cft.git","svn_url":"https://github.com/ecosoft-odoo/cft","homepage":null,"size":50181,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":5,"forks":4,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"ecosoft-odoo:master","ref":"master","sha":"af99943521f45bd3e49d235fd96193be56d676fa","user":{"login":"ecosoft-odoo","id":13600991,"avatar_url":"https://avatars.githubusercontent.com/u/13600991?v=3","gravatar_id":"","url":"https://api.github.com/users/ecosoft-odoo","html_url":"https://github.com/ecosoft-odoo","followers_url":"https://api.github.com/users/ecosoft-odoo/followers","following_url":"https://api.github.com/users/ecosoft-odoo/following{/other_user}","gists_url":"https://api.github.com/users/ecosoft-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/ecosoft-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecosoft-odoo/subscriptions","organizations_url":"https://api.github.com/users/ecosoft-odoo/orgs","repos_url":"https://api.github.com/users/ecosoft-odoo/repos","events_url":"https://api.github.com/users/ecosoft-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/ecosoft-odoo/received_events","type":"User","site_admin":false},"repo":{"id":64775161,"name":"cft","full_name":"ecosoft-odoo/cft","owner":{"login":"ecosoft-odoo","id":13600991,"avatar_url":"https://avatars.githubusercontent.com/u/13600991?v=3","gravatar_id":"","url":"https://api.github.com/users/ecosoft-odoo","html_url":"https://github.com/ecosoft-odoo","followers_url":"https://api.github.com/users/ecosoft-odoo/followers","following_url":"https://api.github.com/users/ecosoft-odoo/following{/other_user}","gists_url":"https://api.github.com/users/ecosoft-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/ecosoft-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecosoft-odoo/subscriptions","organizations_url":"https://api.github.com/users/ecosoft-odoo/orgs","repos_url":"https://api.github.com/users/ecosoft-odoo/repos","events_url":"https://api.github.com/users/ecosoft-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/ecosoft-odoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ecosoft-odoo/cft","description":null,"fork":false,"url":"https://api.github.com/repos/ecosoft-odoo/cft","forks_url":"https://api.github.com/repos/ecosoft-odoo/cft/forks","keys_url":"https://api.github.com/repos/ecosoft-odoo/cft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ecosoft-odoo/cft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ecosoft-odoo/cft/teams","hooks_url":"https://api.github.com/repos/ecosoft-odoo/cft/hooks","issue_events_url":"https://api.github.com/repos/ecosoft-odoo/cft/issues/events{/number}","events_url":"https://api.github.com/repos/ecosoft-odoo/cft/events","assignees_url":"https://api.github.com/repos/ecosoft-odoo/cft/assignees{/user}","branches_url":"https://api.github.com/repos/ecosoft-odoo/cft/branches{/branch}","tags_url":"https://api.github.com/repos/ecosoft-odoo/cft/tags","blobs_url":"https://api.github.com/repos/ecosoft-odoo/cft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ecosoft-odoo/cft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ecosoft-odoo/cft/git/refs{/sha}","trees_url":"https://api.github.com/repos/ecosoft-odoo/cft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ecosoft-odoo/cft/statuses/{sha}","languages_url":"https://api.github.com/repos/ecosoft-odoo/cft/languages","stargazers_url":"https://api.github.com/repos/ecosoft-odoo/cft/stargazers","contributors_url":"https://api.github.com/repos/ecosoft-odoo/cft/contributors","subscribers_url":"https://api.github.com/repos/ecosoft-odoo/cft/subscribers","subscription_url":"https://api.github.com/repos/ecosoft-odoo/cft/subscription","commits_url":"https://api.github.com/repos/ecosoft-odoo/cft/commits{/sha}","git_commits_url":"https://api.github.com/repos/ecosoft-odoo/cft/git/commits{/sha}","comments_url":"https://api.github.com/repos/ecosoft-odoo/cft/comments{/number}","issue_comment_url":"https://api.github.com/repos/ecosoft-odoo/cft/issues/comments{/number}","contents_url":"https://api.github.com/repos/ecosoft-odoo/cft/contents/{+path}","compare_url":"https://api.github.com/repos/ecosoft-odoo/cft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ecosoft-odoo/cft/merges","archive_url":"https://api.github.com/repos/ecosoft-odoo/cft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ecosoft-odoo/cft/downloads","issues_url":"https://api.github.com/repos/ecosoft-odoo/cft/issues{/number}","pulls_url":"https://api.github.com/repos/ecosoft-odoo/cft/pulls{/number}","milestones_url":"https://api.github.com/repos/ecosoft-odoo/cft/milestones{/number}","notifications_url":"https://api.github.com/repos/ecosoft-odoo/cft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ecosoft-odoo/cft/labels{/name}","releases_url":"https://api.github.com/repos/ecosoft-odoo/cft/releases{/id}","deployments_url":"https://api.github.com/repos/ecosoft-odoo/cft/deployments","created_at":"2016-08-02T16:51:33Z","updated_at":"2016-08-09T02:33:11Z","pushed_at":"2016-12-13T10:23:54Z","git_url":"git://github.com/ecosoft-odoo/cft.git","ssh_url":"git@github.com:ecosoft-odoo/cft.git","clone_url":"https://github.com/ecosoft-odoo/cft.git","svn_url":"https://github.com/ecosoft-odoo/cft","homepage":null,"size":50181,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":5,"forks":4,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ecosoft-odoo/cft/pulls/70"},"html":{"href":"https://github.com/ecosoft-odoo/cft/pull/70"},"issue":{"href":"https://api.github.com/repos/ecosoft-odoo/cft/issues/70"},"comments":{"href":"https://api.github.com/repos/ecosoft-odoo/cft/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/ecosoft-odoo/cft/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/ecosoft-odoo/cft/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ecosoft-odoo/cft/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/ecosoft-odoo/cft/statuses/b9fc9adbead1cf68c1485473c501f1685e7f0dae"}}}}
{"actor":{"display_login":"yostashiro"}}