{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/10665","repository_url":"https://api.github.com/repos/facebook/react-native","labels_url":"https://api.github.com/repos/facebook/react-native/issues/10665/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/10665/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/10665/events","html_url":"https://github.com/facebook/react-native/pull/10665","id":186437582,"number":10665,"title":"[TextInput] Implements 'onKeyPress' for Android","user":{"login":"petergarnaes","id":1044051,"avatar_url":"https://avatars.githubusercontent.com/u/1044051?v=3","gravatar_id":"","url":"https://api.github.com/users/petergarnaes","html_url":"https://github.com/petergarnaes","followers_url":"https://api.github.com/users/petergarnaes/followers","following_url":"https://api.github.com/users/petergarnaes/following{/other_user}","gists_url":"https://api.github.com/users/petergarnaes/gists{/gist_id}","starred_url":"https://api.github.com/users/petergarnaes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petergarnaes/subscriptions","organizations_url":"https://api.github.com/users/petergarnaes/orgs","repos_url":"https://api.github.com/users/petergarnaes/repos","events_url":"https://api.github.com/users/petergarnaes/events{/privacy}","received_events_url":"https://api.github.com/users/petergarnaes/received_events","type":"User","site_admin":false},"labels":[{"id":172176599,"url":"https://api.github.com/repos/facebook/react-native/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-01T00:42:29Z","updated_at":"2016-11-01T00:43:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/10665","html_url":"https://github.com/facebook/react-native/pull/10665","diff_url":"https://github.com/facebook/react-native/pull/10665.diff","patch_url":"https://github.com/facebook/react-native/pull/10665.patch"},"body":"An attempt at the Android implementation. Attempted to mirror the iOS implementation by supporting 'Enter' and 'Backspace'.\r\n\r\nThe implementation utilises the TextWatcher, because the [documentation](https://developer.android.com/reference/android/view/View.OnKeyListener.html#onKey(android.view.View, int, android.view.KeyEvent)) for OnKeyListener->onKey states:\r\n\r\n> Key presses in software keyboards will generally NOT trigger this method, although some may elect to do so in some situations. Do not assume a software input method has to be key-based; even if it is, it may use key presses in a different way than you expect, **so there is no way to reliably catch soft input key presses.**\r\n\r\nBecause of this, in my implementation pressing backspace in an empty text field will not trigger onKeyPress. Using cut on selected text and pasting a single character will be interpreted as key presses."},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/257462546","html_url":"https://github.com/facebook/react-native/pull/10665#issuecomment-257462546","issue_url":"https://api.github.com/repos/facebook/react-native/issues/10665","id":257462546,"user":{"login":"facebook-github-bot","id":6422482,"avatar_url":"https://avatars.githubusercontent.com/u/6422482?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook-github-bot","html_url":"https://github.com/facebook-github-bot","followers_url":"https://api.github.com/users/facebook-github-bot/followers","following_url":"https://api.github.com/users/facebook-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/facebook-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook-github-bot/subscriptions","organizations_url":"https://api.github.com/users/facebook-github-bot/orgs","repos_url":"https://api.github.com/users/facebook-github-bot/repos","events_url":"https://api.github.com/users/facebook-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/facebook-github-bot/received_events","type":"User","site_admin":false},"created_at":"2016-11-01T00:43:09Z","updated_at":"2016-11-01T00:43:09Z","body":"Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired.\n\nBefore we can review or merge your code, **we need you to email cla@fb.com** with your details so we can update your status."}}
{"actor":{"display_login":"facebook-github-bot"}}