{"action":"created","comment":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/57386372","id":57386372,"diff_hunk":"@@ -106,34 +107,38 @@ def upgradeDatabase(config, master_cfg):\n \n \n @in_reactor\n-@defer.inlineCallbacks\n def upgradeMaster(config, _noMonkey=False):\n     if not _noMonkey:  # pragma: no cover\n         monkeypatches.patch_all()\n \n     if not base.checkBasedir(config):\n-        defer.returnValue(1)\n-        return\n+        return defer.succeed(1)","path":"master/buildbot/scripts/upgrade_master.py","position":20,"original_position":20,"commit_id":"ba1505ebd3e8e271d1b1f6e4fca814665e2d5bdb","original_commit_id":"ba1505ebd3e8e271d1b1f6e4fca814665e2d5bdb","user":{"login":"rutsky","id":46573,"avatar_url":"https://avatars.githubusercontent.com/u/46573?v=3","gravatar_id":"","url":"https://api.github.com/users/rutsky","html_url":"https://github.com/rutsky","followers_url":"https://api.github.com/users/rutsky/followers","following_url":"https://api.github.com/users/rutsky/following{/other_user}","gists_url":"https://api.github.com/users/rutsky/gists{/gist_id}","starred_url":"https://api.github.com/users/rutsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rutsky/subscriptions","organizations_url":"https://api.github.com/users/rutsky/orgs","repos_url":"https://api.github.com/users/rutsky/repos","events_url":"https://api.github.com/users/rutsky/events{/privacy}","received_events_url":"https://api.github.com/users/rutsky/received_events","type":"User","site_admin":false},"body":"AFAIK `defer.returnValue` raises exception, so no, `return` will not be executed. But in this way it's obvious even for non-Twisted developer (or static analysis tool), that function will return here, so I don't this this is a problem.\r\n\r\n@tardyp ah, sorry, I missed that you *removed* inlineCallbacks, it's all OK!","created_at":"2016-03-24T20:56:48Z","updated_at":"2016-03-24T20:56:48Z","html_url":"https://github.com/buildbot/buildbot/pull/2068#discussion_r57386372","pull_request_url":"https://api.github.com/repos/buildbot/buildbot/pulls/2068","_links":{"self":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/57386372"},"html":{"href":"https://github.com/buildbot/buildbot/pull/2068#discussion_r57386372"},"pull_request":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2068"}}},"pull_request":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/2068","id":63897474,"html_url":"https://github.com/buildbot/buildbot/pull/2068","diff_url":"https://github.com/buildbot/buildbot/pull/2068.diff","patch_url":"https://github.com/buildbot/buildbot/pull/2068.patch","issue_url":"https://api.github.com/repos/buildbot/buildbot/issues/2068","number":2068,"state":"open","locked":false,"title":"report errors in the master-upgrade command line","user":{"login":"tardyp","id":109859,"avatar_url":"https://avatars.githubusercontent.com/u/109859?v=3","gravatar_id":"","url":"https://api.github.com/users/tardyp","html_url":"https://github.com/tardyp","followers_url":"https://api.github.com/users/tardyp/followers","following_url":"https://api.github.com/users/tardyp/following{/other_user}","gists_url":"https://api.github.com/users/tardyp/gists{/gist_id}","starred_url":"https://api.github.com/users/tardyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tardyp/subscriptions","organizations_url":"https://api.github.com/users/tardyp/orgs","repos_url":"https://api.github.com/users/tardyp/repos","events_url":"https://api.github.com/users/tardyp/events{/privacy}","received_events_url":"https://api.github.com/users/tardyp/received_events","type":"User","site_admin":false},"body":"fix for http://trac.buildbot.net/ticket/3499 \r\n\r\n* [x] tests\r\n","created_at":"2016-03-23T15:09:17Z","updated_at":"2016-03-24T20:56:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f12e2fa5c042d2a8d83499957f4fe48cc4839770","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/buildbot/buildbot/pulls/2068/commits","review_comments_url":"https://api.github.com/repos/buildbot/buildbot/pulls/2068/comments","review_comment_url":"https://api.github.com/repos/buildbot/buildbot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/buildbot/buildbot/issues/2068/comments","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/ba1505ebd3e8e271d1b1f6e4fca814665e2d5bdb","head":{"label":"tardyp:upgrademaster","ref":"upgrademaster","sha":"ba1505ebd3e8e271d1b1f6e4fca814665e2d5bdb","user":{"login":"tardyp","id":109859,"avatar_url":"https://avatars.githubusercontent.com/u/109859?v=3","gravatar_id":"","url":"https://api.github.com/users/tardyp","html_url":"https://github.com/tardyp","followers_url":"https://api.github.com/users/tardyp/followers","following_url":"https://api.github.com/users/tardyp/following{/other_user}","gists_url":"https://api.github.com/users/tardyp/gists{/gist_id}","starred_url":"https://api.github.com/users/tardyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tardyp/subscriptions","organizations_url":"https://api.github.com/users/tardyp/orgs","repos_url":"https://api.github.com/users/tardyp/repos","events_url":"https://api.github.com/users/tardyp/events{/privacy}","received_events_url":"https://api.github.com/users/tardyp/received_events","type":"User","site_admin":false},"repo":{"id":930175,"name":"buildbot","full_name":"tardyp/buildbot","owner":{"login":"tardyp","id":109859,"avatar_url":"https://avatars.githubusercontent.com/u/109859?v=3","gravatar_id":"","url":"https://api.github.com/users/tardyp","html_url":"https://github.com/tardyp","followers_url":"https://api.github.com/users/tardyp/followers","following_url":"https://api.github.com/users/tardyp/following{/other_user}","gists_url":"https://api.github.com/users/tardyp/gists{/gist_id}","starred_url":"https://api.github.com/users/tardyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tardyp/subscriptions","organizations_url":"https://api.github.com/users/tardyp/orgs","repos_url":"https://api.github.com/users/tardyp/repos","events_url":"https://api.github.com/users/tardyp/events{/privacy}","received_events_url":"https://api.github.com/users/tardyp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tardyp/buildbot","description":"Python-based continuous integration testing framework; send pull requests for your patches!","fork":true,"url":"https://api.github.com/repos/tardyp/buildbot","forks_url":"https://api.github.com/repos/tardyp/buildbot/forks","keys_url":"https://api.github.com/repos/tardyp/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tardyp/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tardyp/buildbot/teams","hooks_url":"https://api.github.com/repos/tardyp/buildbot/hooks","issue_events_url":"https://api.github.com/repos/tardyp/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/tardyp/buildbot/events","assignees_url":"https://api.github.com/repos/tardyp/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/tardyp/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/tardyp/buildbot/tags","blobs_url":"https://api.github.com/repos/tardyp/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tardyp/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tardyp/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/tardyp/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tardyp/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/tardyp/buildbot/languages","stargazers_url":"https://api.github.com/repos/tardyp/buildbot/stargazers","contributors_url":"https://api.github.com/repos/tardyp/buildbot/contributors","subscribers_url":"https://api.github.com/repos/tardyp/buildbot/subscribers","subscription_url":"https://api.github.com/repos/tardyp/buildbot/subscription","commits_url":"https://api.github.com/repos/tardyp/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/tardyp/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/tardyp/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/tardyp/buildbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/tardyp/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/tardyp/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tardyp/buildbot/merges","archive_url":"https://api.github.com/repos/tardyp/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tardyp/buildbot/downloads","issues_url":"https://api.github.com/repos/tardyp/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/tardyp/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/tardyp/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/tardyp/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tardyp/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/tardyp/buildbot/releases{/id}","deployments_url":"https://api.github.com/repos/tardyp/buildbot/deployments","created_at":"2010-09-22T09:33:50Z","updated_at":"2014-06-24T21:37:41Z","pushed_at":"2016-03-23T16:26:48Z","git_url":"git://github.com/tardyp/buildbot.git","ssh_url":"git@github.com:tardyp/buildbot.git","clone_url":"https://github.com/tardyp/buildbot.git","svn_url":"https://github.com/tardyp/buildbot","homepage":"http://buildbot.net","size":40852,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":4,"default_branch":"nine"}},"base":{"label":"buildbot:master","ref":"master","sha":"738588c16c7c21792dcd7ad73aadb46c1078cdc3","user":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"repo":{"id":760165,"name":"buildbot","full_name":"buildbot/buildbot","owner":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buildbot/buildbot","description":"Python-based continuous integration testing framework; your pull requests are more than welcome!","fork":false,"url":"https://api.github.com/repos/buildbot/buildbot","forks_url":"https://api.github.com/repos/buildbot/buildbot/forks","keys_url":"https://api.github.com/repos/buildbot/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buildbot/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buildbot/buildbot/teams","hooks_url":"https://api.github.com/repos/buildbot/buildbot/hooks","issue_events_url":"https://api.github.com/repos/buildbot/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/buildbot/buildbot/events","assignees_url":"https://api.github.com/repos/buildbot/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/buildbot/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/buildbot/buildbot/tags","blobs_url":"https://api.github.com/repos/buildbot/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buildbot/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buildbot/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/buildbot/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/buildbot/buildbot/languages","stargazers_url":"https://api.github.com/repos/buildbot/buildbot/stargazers","contributors_url":"https://api.github.com/repos/buildbot/buildbot/contributors","subscribers_url":"https://api.github.com/repos/buildbot/buildbot/subscribers","subscription_url":"https://api.github.com/repos/buildbot/buildbot/subscription","commits_url":"https://api.github.com/repos/buildbot/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/buildbot/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/buildbot/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/buildbot/buildbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/buildbot/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/buildbot/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buildbot/buildbot/merges","archive_url":"https://api.github.com/repos/buildbot/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buildbot/buildbot/downloads","issues_url":"https://api.github.com/repos/buildbot/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/buildbot/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/buildbot/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/buildbot/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buildbot/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/buildbot/buildbot/releases{/id}","deployments_url":"https://api.github.com/repos/buildbot/buildbot/deployments","created_at":"2010-07-06T17:56:53Z","updated_at":"2016-03-24T15:48:41Z","pushed_at":"2016-03-24T18:03:32Z","git_url":"git://github.com/buildbot/buildbot.git","ssh_url":"git@github.com:buildbot/buildbot.git","clone_url":"https://github.com/buildbot/buildbot.git","svn_url":"https://github.com/buildbot/buildbot","homepage":"http://buildbot.net","size":91116,"stargazers_count":2074,"watchers_count":2074,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":859,"mirror_url":null,"open_issues_count":30,"forks":859,"open_issues":30,"watchers":2074,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2068"},"html":{"href":"https://github.com/buildbot/buildbot/pull/2068"},"issue":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/2068"},"comments":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/2068/comments"},"review_comments":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2068/comments"},"review_comment":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2068/commits"},"statuses":{"href":"https://api.github.com/repos/buildbot/buildbot/statuses/ba1505ebd3e8e271d1b1f6e4fca814665e2d5bdb"}}}}