{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/91624755","pull_request_review_id":12135505,"id":91624755,"diff_hunk":"@@ -11,11 +11,17 @@ var tls = require('tls');\n var fs = require('fs');\n var path = require('path');\n \n-var key = fs.readFileSync(path.join(common.fixturesDir, 'pass-key.pem'));\n+var passKey = fs.readFileSync(path.join(common.fixturesDir, 'pass-key.pem'));","path":"test/parallel/test-tls-passphrase.js","position":5,"original_position":5,"commit_id":"3c1b2e5f299ea82ad1d3654fdf23c2b366a9c440","original_commit_id":"3c1b2e5f299ea82ad1d3654fdf23c2b366a9c440","user":{"login":"Trott","id":718899,"avatar_url":"https://avatars.githubusercontent.com/u/718899?v=3","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"body":"Nit: While in here anyway, maybe take an opportunity to var->const some stuff? Up to you.","created_at":"2016-12-08T22:45:11Z","updated_at":"2016-12-08T22:45:11Z","html_url":"https://github.com/nodejs/node/pull/9800#discussion_r91624755","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/9800","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/91624755"},"html":{"href":"https://github.com/nodejs/node/pull/9800#discussion_r91624755"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/9800"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/9800","id":95346030,"html_url":"https://github.com/nodejs/node/pull/9800","diff_url":"https://github.com/nodejs/node/pull/9800.diff","patch_url":"https://github.com/nodejs/node/pull/9800.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/9800","number":9800,"state":"open","locked":false,"title":"Improvements to tls API documentation, batch 1","user":{"login":"sam-github","id":17607,"avatar_url":"https://avatars.githubusercontent.com/u/17607?v=3","gravatar_id":"","url":"https://api.github.com/users/sam-github","html_url":"https://github.com/sam-github","followers_url":"https://api.github.com/users/sam-github/followers","following_url":"https://api.github.com/users/sam-github/following{/other_user}","gists_url":"https://api.github.com/users/sam-github/gists{/gist_id}","starred_url":"https://api.github.com/users/sam-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sam-github/subscriptions","organizations_url":"https://api.github.com/users/sam-github/orgs","repos_url":"https://api.github.com/users/sam-github/repos","events_url":"https://api.github.com/users/sam-github/events{/privacy}","received_events_url":"https://api.github.com/users/sam-github/received_events","type":"User","site_admin":false},"body":"##### Checklist\r\n\r\n- [x] `make -j8 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n\r\ndoc,tls\r\n\r\n##### Description of change\r\n\r\nImprovements to tls API documentation.","created_at":"2016-11-25T20:38:23Z","updated_at":"2016-12-08T22:45:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5333c63fbd2584ef39dddb57e62343802f2b2ead","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/9800/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/9800/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/9800/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/3c1b2e5f299ea82ad1d3654fdf23c2b366a9c440","head":{"label":"sam-github:notes-tls","ref":"notes-tls","sha":"3c1b2e5f299ea82ad1d3654fdf23c2b366a9c440","user":{"login":"sam-github","id":17607,"avatar_url":"https://avatars.githubusercontent.com/u/17607?v=3","gravatar_id":"","url":"https://api.github.com/users/sam-github","html_url":"https://github.com/sam-github","followers_url":"https://api.github.com/users/sam-github/followers","following_url":"https://api.github.com/users/sam-github/following{/other_user}","gists_url":"https://api.github.com/users/sam-github/gists{/gist_id}","starred_url":"https://api.github.com/users/sam-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sam-github/subscriptions","organizations_url":"https://api.github.com/users/sam-github/orgs","repos_url":"https://api.github.com/users/sam-github/repos","events_url":"https://api.github.com/users/sam-github/events{/privacy}","received_events_url":"https://api.github.com/users/sam-github/received_events","type":"User","site_admin":false},"repo":{"id":28619971,"name":"node","full_name":"sam-github/node","owner":{"login":"sam-github","id":17607,"avatar_url":"https://avatars.githubusercontent.com/u/17607?v=3","gravatar_id":"","url":"https://api.github.com/users/sam-github","html_url":"https://github.com/sam-github","followers_url":"https://api.github.com/users/sam-github/followers","following_url":"https://api.github.com/users/sam-github/following{/other_user}","gists_url":"https://api.github.com/users/sam-github/gists{/gist_id}","starred_url":"https://api.github.com/users/sam-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sam-github/subscriptions","organizations_url":"https://api.github.com/users/sam-github/orgs","repos_url":"https://api.github.com/users/sam-github/repos","events_url":"https://api.github.com/users/sam-github/events{/privacy}","received_events_url":"https://api.github.com/users/sam-github/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sam-github/node","description":"Evented IO for V8 JavaScript","fork":true,"url":"https://api.github.com/repos/sam-github/node","forks_url":"https://api.github.com/repos/sam-github/node/forks","keys_url":"https://api.github.com/repos/sam-github/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sam-github/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sam-github/node/teams","hooks_url":"https://api.github.com/repos/sam-github/node/hooks","issue_events_url":"https://api.github.com/repos/sam-github/node/issues/events{/number}","events_url":"https://api.github.com/repos/sam-github/node/events","assignees_url":"https://api.github.com/repos/sam-github/node/assignees{/user}","branches_url":"https://api.github.com/repos/sam-github/node/branches{/branch}","tags_url":"https://api.github.com/repos/sam-github/node/tags","blobs_url":"https://api.github.com/repos/sam-github/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sam-github/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sam-github/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/sam-github/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sam-github/node/statuses/{sha}","languages_url":"https://api.github.com/repos/sam-github/node/languages","stargazers_url":"https://api.github.com/repos/sam-github/node/stargazers","contributors_url":"https://api.github.com/repos/sam-github/node/contributors","subscribers_url":"https://api.github.com/repos/sam-github/node/subscribers","subscription_url":"https://api.github.com/repos/sam-github/node/subscription","commits_url":"https://api.github.com/repos/sam-github/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/sam-github/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/sam-github/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/sam-github/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/sam-github/node/contents/{+path}","compare_url":"https://api.github.com/repos/sam-github/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sam-github/node/merges","archive_url":"https://api.github.com/repos/sam-github/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sam-github/node/downloads","issues_url":"https://api.github.com/repos/sam-github/node/issues{/number}","pulls_url":"https://api.github.com/repos/sam-github/node/pulls{/number}","milestones_url":"https://api.github.com/repos/sam-github/node/milestones{/number}","notifications_url":"https://api.github.com/repos/sam-github/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sam-github/node/labels{/name}","releases_url":"https://api.github.com/repos/sam-github/node/releases{/id}","deployments_url":"https://api.github.com/repos/sam-github/node/deployments","created_at":"2014-12-30T06:15:39Z","updated_at":"2016-10-24T15:57:21Z","pushed_at":"2016-12-08T22:01:24Z","git_url":"git://github.com/sam-github/node.git","ssh_url":"git@github.com:sam-github/node.git","clone_url":"https://github.com/sam-github/node.git","svn_url":"https://github.com/sam-github/node","homepage":null,"size":236784,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"444b907e92f98df794da3ef97e7dda3572cc6ff8","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-12-08T22:43:26Z","pushed_at":"2016-12-08T22:10:08Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":378622,"stargazers_count":29672,"watchers_count":29672,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5299,"mirror_url":null,"open_issues_count":1026,"forks":5299,"open_issues":1026,"watchers":29672,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/9800"},"html":{"href":"https://github.com/nodejs/node/pull/9800"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/9800"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/9800/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/9800/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/9800/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/3c1b2e5f299ea82ad1d3654fdf23c2b366a9c440"}}}}
{"actor":{"display_login":"Trott"}}