{"action":"created","comment":{"url":"https://api.github.com/repos/icgc-dcc/dcc-portal/pulls/comments/72509409","id":72509409,"diff_hunk":"@@ -129,8 +124,14 @@\n       // Fetch display names for entity lists\n       $scope.entityIdMap = {};\n \n-      if ($scope.activeEntityIds.length > 0) {\n-        SetService.getMetaData ($scope.activeEntityIds).then (function (results) {\n+      // Find any entity set ids among the entity ids in order to query for their names\n+      var setIds = _($scope.activeEntityIds)\n+        .filter(function(id) { return id.indexOf(Extensions.ENTITY_PREFIX) === 0;})\n+        .map(function(id) { return id.substring(3);})","path":"dcc-portal-ui/app/scripts/facets/js/tags.js","position":64,"original_position":64,"commit_id":"9316973d838187e01bc00c83b82c474d864ef865","original_commit_id":"c0559494ee42e79497f21a94e9421c053f18344b","user":{"login":"btiernay","id":2717578,"avatar_url":"https://avatars.githubusercontent.com/u/2717578?v=3","gravatar_id":"","url":"https://api.github.com/users/btiernay","html_url":"https://github.com/btiernay","followers_url":"https://api.github.com/users/btiernay/followers","following_url":"https://api.github.com/users/btiernay/following{/other_user}","gists_url":"https://api.github.com/users/btiernay/gists{/gist_id}","starred_url":"https://api.github.com/users/btiernay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btiernay/subscriptions","organizations_url":"https://api.github.com/users/btiernay/orgs","repos_url":"https://api.github.com/users/btiernay/repos","events_url":"https://api.github.com/users/btiernay/events{/privacy}","received_events_url":"https://api.github.com/users/btiernay/received_events","type":"User","site_admin":false},"body":"Magical","created_at":"2016-07-27T19:46:00Z","updated_at":"2016-07-27T19:46:00Z","html_url":"https://github.com/icgc-dcc/dcc-portal/pull/54#discussion_r72509409","pull_request_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/pulls/54","_links":{"self":{"href":"https://api.github.com/repos/icgc-dcc/dcc-portal/pulls/comments/72509409"},"html":{"href":"https://github.com/icgc-dcc/dcc-portal/pull/54#discussion_r72509409"},"pull_request":{"href":"https://api.github.com/repos/icgc-dcc/dcc-portal/pulls/54"}}},"pull_request":{"url":"https://api.github.com/repos/icgc-dcc/dcc-portal/pulls/54","id":78880982,"html_url":"https://github.com/icgc-dcc/dcc-portal/pull/54","diff_url":"https://github.com/icgc-dcc/dcc-portal/pull/54.diff","patch_url":"https://github.com/icgc-dcc/dcc-portal/pull/54.patch","issue_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/issues/54","number":54,"state":"open","locked":false,"title":"FileRepository - PQL support and EntitySet/Termslookup fix","user":{"login":"andricDu","id":6350043,"avatar_url":"https://avatars.githubusercontent.com/u/6350043?v=3","gravatar_id":"","url":"https://api.github.com/users/andricDu","html_url":"https://github.com/andricDu","followers_url":"https://api.github.com/users/andricDu/followers","following_url":"https://api.github.com/users/andricDu/following{/other_user}","gists_url":"https://api.github.com/users/andricDu/gists{/gist_id}","starred_url":"https://api.github.com/users/andricDu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andricDu/subscriptions","organizations_url":"https://api.github.com/users/andricDu/orgs","repos_url":"https://api.github.com/users/andricDu/repos","events_url":"https://api.github.com/users/andricDu/events{/privacy}","received_events_url":"https://api.github.com/users/andricDu/received_events","type":"User","site_admin":false},"body":"# Issues\r\n* DCC-4988\r\n* DCC-4860\r\n* DCC-4730\r\n* DCC-5037\r\n* DCC-5050\r\n* DCC-5049\r\n\r\n## FileRepository and associated functionality\r\n* `repoFilter` has been removed and now the file repository uses the PQL infrastructure to generate its elastic search queries. \r\n* FileTypeModel has been extended\r\n* ManifestMapper updated to parse from source instead of fields.\r\n* Fixture for unit test fixed (study was not an array)\r\n\r\n## UI\r\n* `entitySetId` node in JQL is no longer to be used\r\n* Started stripping out now deprecated `entitySetId` logic. \r\n* Fixing UI logic to look for donorId in JQL path for `ES:` prefix. \r\n* Logic for tags facet (entity ids) has been simplified. No need to keep track of entity set ids separately. \r\n\r\n## Misc\r\n* No longer using `@UtilityClass` annotation. \r\n\r\n## TODO\r\n* ~~Why 5000?~~ Was used for paging in a scroll query. \r\n* ~~Ensure consistency in UI~~ behaviour is now consistent for entities. \r\n* ~~Enable links in set list for File Sets now that entity set / pql issue has been resolved~~ enabled\r\n* Strip out any orphaned functions and unused functionality for the deprecated `entitySetId` logic. \r\n","created_at":"2016-07-26T16:14:18Z","updated_at":"2016-07-27T19:46:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37088c8bacee391cd72582ebaecef9683ff21655","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/pulls/54/commits","review_comments_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/pulls/54/comments","review_comment_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/issues/54/comments","statuses_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/statuses/9316973d838187e01bc00c83b82c474d864ef865","head":{"label":"icgc-dcc:feature/repo-entity-sets","ref":"feature/repo-entity-sets","sha":"9316973d838187e01bc00c83b82c474d864ef865","user":{"login":"icgc-dcc","id":1508638,"avatar_url":"https://avatars.githubusercontent.com/u/1508638?v=3","gravatar_id":"","url":"https://api.github.com/users/icgc-dcc","html_url":"https://github.com/icgc-dcc","followers_url":"https://api.github.com/users/icgc-dcc/followers","following_url":"https://api.github.com/users/icgc-dcc/following{/other_user}","gists_url":"https://api.github.com/users/icgc-dcc/gists{/gist_id}","starred_url":"https://api.github.com/users/icgc-dcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icgc-dcc/subscriptions","organizations_url":"https://api.github.com/users/icgc-dcc/orgs","repos_url":"https://api.github.com/users/icgc-dcc/repos","events_url":"https://api.github.com/users/icgc-dcc/events{/privacy}","received_events_url":"https://api.github.com/users/icgc-dcc/received_events","type":"Organization","site_admin":false},"repo":{"id":62242110,"name":"dcc-portal","full_name":"icgc-dcc/dcc-portal","owner":{"login":"icgc-dcc","id":1508638,"avatar_url":"https://avatars.githubusercontent.com/u/1508638?v=3","gravatar_id":"","url":"https://api.github.com/users/icgc-dcc","html_url":"https://github.com/icgc-dcc","followers_url":"https://api.github.com/users/icgc-dcc/followers","following_url":"https://api.github.com/users/icgc-dcc/following{/other_user}","gists_url":"https://api.github.com/users/icgc-dcc/gists{/gist_id}","starred_url":"https://api.github.com/users/icgc-dcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icgc-dcc/subscriptions","organizations_url":"https://api.github.com/users/icgc-dcc/orgs","repos_url":"https://api.github.com/users/icgc-dcc/repos","events_url":"https://api.github.com/users/icgc-dcc/events{/privacy}","received_events_url":"https://api.github.com/users/icgc-dcc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/icgc-dcc/dcc-portal","description":"Data portal for exploring and accessing data","fork":false,"url":"https://api.github.com/repos/icgc-dcc/dcc-portal","forks_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/forks","keys_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/teams","hooks_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/hooks","issue_events_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/issues/events{/number}","events_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/events","assignees_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/assignees{/user}","branches_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/branches{/branch}","tags_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/tags","blobs_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/languages","stargazers_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/stargazers","contributors_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/contributors","subscribers_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/subscribers","subscription_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/subscription","commits_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/contents/{+path}","compare_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/merges","archive_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/downloads","issues_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/issues{/number}","pulls_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/labels{/name}","releases_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/releases{/id}","deployments_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/deployments","created_at":"2016-06-29T16:44:10Z","updated_at":"2016-07-18T13:55:22Z","pushed_at":"2016-07-27T19:39:09Z","git_url":"git://github.com/icgc-dcc/dcc-portal.git","ssh_url":"git@github.com:icgc-dcc/dcc-portal.git","clone_url":"https://github.com/icgc-dcc/dcc-portal.git","svn_url":"https://github.com/icgc-dcc/dcc-portal","homepage":"https://dcc.icgc.org/","size":11720,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":3,"default_branch":"develop"}},"base":{"label":"icgc-dcc:develop","ref":"develop","sha":"7c743069854366a917c157684128a97c970ca1ab","user":{"login":"icgc-dcc","id":1508638,"avatar_url":"https://avatars.githubusercontent.com/u/1508638?v=3","gravatar_id":"","url":"https://api.github.com/users/icgc-dcc","html_url":"https://github.com/icgc-dcc","followers_url":"https://api.github.com/users/icgc-dcc/followers","following_url":"https://api.github.com/users/icgc-dcc/following{/other_user}","gists_url":"https://api.github.com/users/icgc-dcc/gists{/gist_id}","starred_url":"https://api.github.com/users/icgc-dcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icgc-dcc/subscriptions","organizations_url":"https://api.github.com/users/icgc-dcc/orgs","repos_url":"https://api.github.com/users/icgc-dcc/repos","events_url":"https://api.github.com/users/icgc-dcc/events{/privacy}","received_events_url":"https://api.github.com/users/icgc-dcc/received_events","type":"Organization","site_admin":false},"repo":{"id":62242110,"name":"dcc-portal","full_name":"icgc-dcc/dcc-portal","owner":{"login":"icgc-dcc","id":1508638,"avatar_url":"https://avatars.githubusercontent.com/u/1508638?v=3","gravatar_id":"","url":"https://api.github.com/users/icgc-dcc","html_url":"https://github.com/icgc-dcc","followers_url":"https://api.github.com/users/icgc-dcc/followers","following_url":"https://api.github.com/users/icgc-dcc/following{/other_user}","gists_url":"https://api.github.com/users/icgc-dcc/gists{/gist_id}","starred_url":"https://api.github.com/users/icgc-dcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icgc-dcc/subscriptions","organizations_url":"https://api.github.com/users/icgc-dcc/orgs","repos_url":"https://api.github.com/users/icgc-dcc/repos","events_url":"https://api.github.com/users/icgc-dcc/events{/privacy}","received_events_url":"https://api.github.com/users/icgc-dcc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/icgc-dcc/dcc-portal","description":"Data portal for exploring and accessing data","fork":false,"url":"https://api.github.com/repos/icgc-dcc/dcc-portal","forks_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/forks","keys_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/teams","hooks_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/hooks","issue_events_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/issues/events{/number}","events_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/events","assignees_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/assignees{/user}","branches_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/branches{/branch}","tags_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/tags","blobs_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/languages","stargazers_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/stargazers","contributors_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/contributors","subscribers_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/subscribers","subscription_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/subscription","commits_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/contents/{+path}","compare_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/merges","archive_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/downloads","issues_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/issues{/number}","pulls_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/labels{/name}","releases_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/releases{/id}","deployments_url":"https://api.github.com/repos/icgc-dcc/dcc-portal/deployments","created_at":"2016-06-29T16:44:10Z","updated_at":"2016-07-18T13:55:22Z","pushed_at":"2016-07-27T19:39:09Z","git_url":"git://github.com/icgc-dcc/dcc-portal.git","ssh_url":"git@github.com:icgc-dcc/dcc-portal.git","clone_url":"https://github.com/icgc-dcc/dcc-portal.git","svn_url":"https://github.com/icgc-dcc/dcc-portal","homepage":"https://dcc.icgc.org/","size":11720,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/icgc-dcc/dcc-portal/pulls/54"},"html":{"href":"https://github.com/icgc-dcc/dcc-portal/pull/54"},"issue":{"href":"https://api.github.com/repos/icgc-dcc/dcc-portal/issues/54"},"comments":{"href":"https://api.github.com/repos/icgc-dcc/dcc-portal/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/icgc-dcc/dcc-portal/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/icgc-dcc/dcc-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/icgc-dcc/dcc-portal/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/icgc-dcc/dcc-portal/statuses/9316973d838187e01bc00c83b82c474d864ef865"}}}}
{"actor":{"display_login":"btiernay"}}