{"action":"created","comment":{"url":"https://api.github.com/repos/mitodl/mongodb-formula/pulls/comments/63923886","id":63923886,"diff_hunk":"@@ -1,14 +1,19 @@\n {% set mongodb = salt['grains.filter_by']({\n     'default': {\n-        'pkg': 'mongodb',\n-        'service': 'mongodb',\n-        'conf_file': '/etc/mongodb/mongodb.conf',\n-        'config': {\n-            'key': 'value',\n-        },\n+      'key': '7F0CEB10',\n+      'keyserver': 'keyserver.ubuntu.com',\n+      'pkgs': [\n+        {'mongodb-10gen': '*'},\n+      ],\n+      'cluster_key_file': '/etc/mongodb_key',\n+      'bind_ip': '127.0.0.1',\n+      'port': 12017,\n+      'enable_journal': True,","path":"mongodb/map.jinja","position":17,"original_position":17,"commit_id":"e531178e99dac638ec179c75fba9a0a924369336","original_commit_id":"9c64fd58b23c74b2403f43e588051a739086db85","user":{"login":"bdero","id":919017,"avatar_url":"https://avatars.githubusercontent.com/u/919017?v=3","gravatar_id":"","url":"https://api.github.com/users/bdero","html_url":"https://github.com/bdero","followers_url":"https://api.github.com/users/bdero/followers","following_url":"https://api.github.com/users/bdero/following{/other_user}","gists_url":"https://api.github.com/users/bdero/gists{/gist_id}","starred_url":"https://api.github.com/users/bdero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdero/subscriptions","organizations_url":"https://api.github.com/users/bdero/orgs","repos_url":"https://api.github.com/users/bdero/repos","events_url":"https://api.github.com/users/bdero/events{/privacy}","received_events_url":"https://api.github.com/users/bdero/received_events","type":"User","site_admin":false},"body":"Not with the way it's currently being used.\r\n\r\n```\r\n{% if mongodb.enable_journal %}\r\njournal = true\r\n{% else %}\r\njournal = false\r\nnojournal = true\r\n{% endif %}\r\n```\r\n\r\nI also wrote a note in the comment addressing why I chose to keep the conditional instead of the more declarative alternative.","created_at":"2016-05-19T17:48:41Z","updated_at":"2016-05-19T17:48:41Z","html_url":"https://github.com/mitodl/mongodb-formula/pull/2#discussion_r63923886","pull_request_url":"https://api.github.com/repos/mitodl/mongodb-formula/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/mitodl/mongodb-formula/pulls/comments/63923886"},"html":{"href":"https://github.com/mitodl/mongodb-formula/pull/2#discussion_r63923886"},"pull_request":{"href":"https://api.github.com/repos/mitodl/mongodb-formula/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/mitodl/mongodb-formula/pulls/2","id":70575221,"html_url":"https://github.com/mitodl/mongodb-formula/pull/2","diff_url":"https://github.com/mitodl/mongodb-formula/pull/2.diff","patch_url":"https://github.com/mitodl/mongodb-formula/pull/2.patch","issue_url":"https://api.github.com/repos/mitodl/mongodb-formula/issues/2","number":2,"state":"open","locked":false,"title":"Setup MongoDB replica set","user":{"login":"bdero","id":919017,"avatar_url":"https://avatars.githubusercontent.com/u/919017?v=3","gravatar_id":"","url":"https://api.github.com/users/bdero","html_url":"https://github.com/bdero","followers_url":"https://api.github.com/users/bdero/followers","following_url":"https://api.github.com/users/bdero/following{/other_user}","gists_url":"https://api.github.com/users/bdero/gists{/gist_id}","starred_url":"https://api.github.com/users/bdero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdero/subscriptions","organizations_url":"https://api.github.com/users/bdero/orgs","repos_url":"https://api.github.com/users/bdero/repos","events_url":"https://api.github.com/users/bdero/events{/privacy}","received_events_url":"https://api.github.com/users/bdero/received_events","type":"User","site_admin":false},"body":"Launch a mongo replica set. @blarghmatey","created_at":"2016-05-18T18:19:46Z","updated_at":"2016-05-19T17:48:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df7395eafc1f53435c7856a82018c18ad9e4e0d2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mitodl/mongodb-formula/pulls/2/commits","review_comments_url":"https://api.github.com/repos/mitodl/mongodb-formula/pulls/2/comments","review_comment_url":"https://api.github.com/repos/mitodl/mongodb-formula/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mitodl/mongodb-formula/issues/2/comments","statuses_url":"https://api.github.com/repos/mitodl/mongodb-formula/statuses/e531178e99dac638ec179c75fba9a0a924369336","head":{"label":"mitodl:bdero/mongodb","ref":"bdero/mongodb","sha":"e531178e99dac638ec179c75fba9a0a924369336","user":{"login":"mitodl","id":7918516,"avatar_url":"https://avatars.githubusercontent.com/u/7918516?v=3","gravatar_id":"","url":"https://api.github.com/users/mitodl","html_url":"https://github.com/mitodl","followers_url":"https://api.github.com/users/mitodl/followers","following_url":"https://api.github.com/users/mitodl/following{/other_user}","gists_url":"https://api.github.com/users/mitodl/gists{/gist_id}","starred_url":"https://api.github.com/users/mitodl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitodl/subscriptions","organizations_url":"https://api.github.com/users/mitodl/orgs","repos_url":"https://api.github.com/users/mitodl/repos","events_url":"https://api.github.com/users/mitodl/events{/privacy}","received_events_url":"https://api.github.com/users/mitodl/received_events","type":"Organization","site_admin":false},"repo":{"id":57043010,"name":"mongodb-formula","full_name":"mitodl/mongodb-formula","owner":{"login":"mitodl","id":7918516,"avatar_url":"https://avatars.githubusercontent.com/u/7918516?v=3","gravatar_id":"","url":"https://api.github.com/users/mitodl","html_url":"https://github.com/mitodl","followers_url":"https://api.github.com/users/mitodl/followers","following_url":"https://api.github.com/users/mitodl/following{/other_user}","gists_url":"https://api.github.com/users/mitodl/gists{/gist_id}","starred_url":"https://api.github.com/users/mitodl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitodl/subscriptions","organizations_url":"https://api.github.com/users/mitodl/orgs","repos_url":"https://api.github.com/users/mitodl/repos","events_url":"https://api.github.com/users/mitodl/events{/privacy}","received_events_url":"https://api.github.com/users/mitodl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mitodl/mongodb-formula","description":"  SaltStack formula for building a MongoDB replica set with access controls.","fork":false,"url":"https://api.github.com/repos/mitodl/mongodb-formula","forks_url":"https://api.github.com/repos/mitodl/mongodb-formula/forks","keys_url":"https://api.github.com/repos/mitodl/mongodb-formula/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitodl/mongodb-formula/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitodl/mongodb-formula/teams","hooks_url":"https://api.github.com/repos/mitodl/mongodb-formula/hooks","issue_events_url":"https://api.github.com/repos/mitodl/mongodb-formula/issues/events{/number}","events_url":"https://api.github.com/repos/mitodl/mongodb-formula/events","assignees_url":"https://api.github.com/repos/mitodl/mongodb-formula/assignees{/user}","branches_url":"https://api.github.com/repos/mitodl/mongodb-formula/branches{/branch}","tags_url":"https://api.github.com/repos/mitodl/mongodb-formula/tags","blobs_url":"https://api.github.com/repos/mitodl/mongodb-formula/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitodl/mongodb-formula/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitodl/mongodb-formula/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitodl/mongodb-formula/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitodl/mongodb-formula/statuses/{sha}","languages_url":"https://api.github.com/repos/mitodl/mongodb-formula/languages","stargazers_url":"https://api.github.com/repos/mitodl/mongodb-formula/stargazers","contributors_url":"https://api.github.com/repos/mitodl/mongodb-formula/contributors","subscribers_url":"https://api.github.com/repos/mitodl/mongodb-formula/subscribers","subscription_url":"https://api.github.com/repos/mitodl/mongodb-formula/subscription","commits_url":"https://api.github.com/repos/mitodl/mongodb-formula/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitodl/mongodb-formula/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitodl/mongodb-formula/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitodl/mongodb-formula/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitodl/mongodb-formula/contents/{+path}","compare_url":"https://api.github.com/repos/mitodl/mongodb-formula/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitodl/mongodb-formula/merges","archive_url":"https://api.github.com/repos/mitodl/mongodb-formula/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitodl/mongodb-formula/downloads","issues_url":"https://api.github.com/repos/mitodl/mongodb-formula/issues{/number}","pulls_url":"https://api.github.com/repos/mitodl/mongodb-formula/pulls{/number}","milestones_url":"https://api.github.com/repos/mitodl/mongodb-formula/milestones{/number}","notifications_url":"https://api.github.com/repos/mitodl/mongodb-formula/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitodl/mongodb-formula/labels{/name}","releases_url":"https://api.github.com/repos/mitodl/mongodb-formula/releases{/id}","deployments_url":"https://api.github.com/repos/mitodl/mongodb-formula/deployments","created_at":"2016-04-25T13:16:55Z","updated_at":"2016-04-25T13:19:05Z","pushed_at":"2016-05-19T17:17:06Z","git_url":"git://github.com/mitodl/mongodb-formula.git","ssh_url":"git@github.com:mitodl/mongodb-formula.git","clone_url":"https://github.com/mitodl/mongodb-formula.git","svn_url":"https://github.com/mitodl/mongodb-formula","homepage":"","size":52,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"mitodl:master","ref":"master","sha":"577808d53fb6e93eef054406f0ae7f10961c863a","user":{"login":"mitodl","id":7918516,"avatar_url":"https://avatars.githubusercontent.com/u/7918516?v=3","gravatar_id":"","url":"https://api.github.com/users/mitodl","html_url":"https://github.com/mitodl","followers_url":"https://api.github.com/users/mitodl/followers","following_url":"https://api.github.com/users/mitodl/following{/other_user}","gists_url":"https://api.github.com/users/mitodl/gists{/gist_id}","starred_url":"https://api.github.com/users/mitodl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitodl/subscriptions","organizations_url":"https://api.github.com/users/mitodl/orgs","repos_url":"https://api.github.com/users/mitodl/repos","events_url":"https://api.github.com/users/mitodl/events{/privacy}","received_events_url":"https://api.github.com/users/mitodl/received_events","type":"Organization","site_admin":false},"repo":{"id":57043010,"name":"mongodb-formula","full_name":"mitodl/mongodb-formula","owner":{"login":"mitodl","id":7918516,"avatar_url":"https://avatars.githubusercontent.com/u/7918516?v=3","gravatar_id":"","url":"https://api.github.com/users/mitodl","html_url":"https://github.com/mitodl","followers_url":"https://api.github.com/users/mitodl/followers","following_url":"https://api.github.com/users/mitodl/following{/other_user}","gists_url":"https://api.github.com/users/mitodl/gists{/gist_id}","starred_url":"https://api.github.com/users/mitodl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitodl/subscriptions","organizations_url":"https://api.github.com/users/mitodl/orgs","repos_url":"https://api.github.com/users/mitodl/repos","events_url":"https://api.github.com/users/mitodl/events{/privacy}","received_events_url":"https://api.github.com/users/mitodl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mitodl/mongodb-formula","description":"  SaltStack formula for building a MongoDB replica set with access controls.","fork":false,"url":"https://api.github.com/repos/mitodl/mongodb-formula","forks_url":"https://api.github.com/repos/mitodl/mongodb-formula/forks","keys_url":"https://api.github.com/repos/mitodl/mongodb-formula/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitodl/mongodb-formula/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitodl/mongodb-formula/teams","hooks_url":"https://api.github.com/repos/mitodl/mongodb-formula/hooks","issue_events_url":"https://api.github.com/repos/mitodl/mongodb-formula/issues/events{/number}","events_url":"https://api.github.com/repos/mitodl/mongodb-formula/events","assignees_url":"https://api.github.com/repos/mitodl/mongodb-formula/assignees{/user}","branches_url":"https://api.github.com/repos/mitodl/mongodb-formula/branches{/branch}","tags_url":"https://api.github.com/repos/mitodl/mongodb-formula/tags","blobs_url":"https://api.github.com/repos/mitodl/mongodb-formula/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitodl/mongodb-formula/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitodl/mongodb-formula/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitodl/mongodb-formula/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitodl/mongodb-formula/statuses/{sha}","languages_url":"https://api.github.com/repos/mitodl/mongodb-formula/languages","stargazers_url":"https://api.github.com/repos/mitodl/mongodb-formula/stargazers","contributors_url":"https://api.github.com/repos/mitodl/mongodb-formula/contributors","subscribers_url":"https://api.github.com/repos/mitodl/mongodb-formula/subscribers","subscription_url":"https://api.github.com/repos/mitodl/mongodb-formula/subscription","commits_url":"https://api.github.com/repos/mitodl/mongodb-formula/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitodl/mongodb-formula/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitodl/mongodb-formula/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitodl/mongodb-formula/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitodl/mongodb-formula/contents/{+path}","compare_url":"https://api.github.com/repos/mitodl/mongodb-formula/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitodl/mongodb-formula/merges","archive_url":"https://api.github.com/repos/mitodl/mongodb-formula/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitodl/mongodb-formula/downloads","issues_url":"https://api.github.com/repos/mitodl/mongodb-formula/issues{/number}","pulls_url":"https://api.github.com/repos/mitodl/mongodb-formula/pulls{/number}","milestones_url":"https://api.github.com/repos/mitodl/mongodb-formula/milestones{/number}","notifications_url":"https://api.github.com/repos/mitodl/mongodb-formula/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitodl/mongodb-formula/labels{/name}","releases_url":"https://api.github.com/repos/mitodl/mongodb-formula/releases{/id}","deployments_url":"https://api.github.com/repos/mitodl/mongodb-formula/deployments","created_at":"2016-04-25T13:16:55Z","updated_at":"2016-04-25T13:19:05Z","pushed_at":"2016-05-19T17:17:06Z","git_url":"git://github.com/mitodl/mongodb-formula.git","ssh_url":"git@github.com:mitodl/mongodb-formula.git","clone_url":"https://github.com/mitodl/mongodb-formula.git","svn_url":"https://github.com/mitodl/mongodb-formula","homepage":"","size":52,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mitodl/mongodb-formula/pulls/2"},"html":{"href":"https://github.com/mitodl/mongodb-formula/pull/2"},"issue":{"href":"https://api.github.com/repos/mitodl/mongodb-formula/issues/2"},"comments":{"href":"https://api.github.com/repos/mitodl/mongodb-formula/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/mitodl/mongodb-formula/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/mitodl/mongodb-formula/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mitodl/mongodb-formula/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/mitodl/mongodb-formula/statuses/e531178e99dac638ec179c75fba9a0a924369336"}}}}