{"action":"created","issue":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/6930","labels_url":"https://api.github.com/repos/highfidelity/hifi/issues/6930/labels{/name}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/6930/comments","events_url":"https://api.github.com/repos/highfidelity/hifi/issues/6930/events","html_url":"https://github.com/highfidelity/hifi/pull/6930","id":128672150,"number":6930,"title":"Bubble up render settings from CPP to JS/QML","user":{"login":"zzmp","id":5403956,"avatar_url":"https://avatars.githubusercontent.com/u/5403956?v=3","gravatar_id":"","url":"https://api.github.com/users/zzmp","html_url":"https://github.com/zzmp","followers_url":"https://api.github.com/users/zzmp/followers","following_url":"https://api.github.com/users/zzmp/following{/other_user}","gists_url":"https://api.github.com/users/zzmp/gists{/gist_id}","starred_url":"https://api.github.com/users/zzmp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zzmp/subscriptions","organizations_url":"https://api.github.com/users/zzmp/orgs","repos_url":"https://api.github.com/users/zzmp/repos","events_url":"https://api.github.com/users/zzmp/events{/privacy}","received_events_url":"https://api.github.com/users/zzmp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"samcake","id":2230265,"avatar_url":"https://avatars.githubusercontent.com/u/2230265?v=3","gravatar_id":"","url":"https://api.github.com/users/samcake","html_url":"https://github.com/samcake","followers_url":"https://api.github.com/users/samcake/followers","following_url":"https://api.github.com/users/samcake/following{/other_user}","gists_url":"https://api.github.com/users/samcake/gists{/gist_id}","starred_url":"https://api.github.com/users/samcake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samcake/subscriptions","organizations_url":"https://api.github.com/users/samcake/orgs","repos_url":"https://api.github.com/users/samcake/repos","events_url":"https://api.github.com/users/samcake/events{/privacy}","received_events_url":"https://api.github.com/users/samcake/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2016-01-25T23:22:04Z","updated_at":"2016-01-26T22:03:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/6930","html_url":"https://github.com/highfidelity/hifi/pull/6930","diff_url":"https://github.com/highfidelity/hifi/pull/6930.diff","patch_url":"https://github.com/highfidelity/hifi/pull/6930.patch"},"body":"- Consolidates a lot of code in the rendering engine, allowing settings to be populated in JS/QML more easily.\r\n- Removes old Render-engine-specific menu items.\r\n- Adds AO/Antialiasing/Shadow toggles to general preferences menu.\r\n\r\nIn its current state, this breaks renderEngineDebug.js. I am working on updating that, and will then re-review this PR."},"comment":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/comments/175252828","html_url":"https://github.com/highfidelity/hifi/pull/6930#issuecomment-175252828","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/6930","id":175252828,"user":{"login":"zzmp","id":5403956,"avatar_url":"https://avatars.githubusercontent.com/u/5403956?v=3","gravatar_id":"","url":"https://api.github.com/users/zzmp","html_url":"https://github.com/zzmp","followers_url":"https://api.github.com/users/zzmp/followers","following_url":"https://api.github.com/users/zzmp/following{/other_user}","gists_url":"https://api.github.com/users/zzmp/gists{/gist_id}","starred_url":"https://api.github.com/users/zzmp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zzmp/subscriptions","organizations_url":"https://api.github.com/users/zzmp/orgs","repos_url":"https://api.github.com/users/zzmp/repos","events_url":"https://api.github.com/users/zzmp/events{/privacy}","received_events_url":"https://api.github.com/users/zzmp/received_events","type":"User","site_admin":false},"created_at":"2016-01-26T22:03:08Z","updated_at":"2016-01-26T22:03:08Z","body":"@samcake - some notes/ideas for future PRs.\r\n- PhysicsShowOwned was removed from the Physics menu - should it be added back somewhere? It pertains to `DrawStatus`. It is accessible from JS/QML.\r\n- The name is stored in both the Job and its Config. This could be improved.\r\n- Most Job::run methods assert(args). This could be moved to the templated jobRun functions.\r\n- The Task::run methods are similar for tasks (not the Engine). This could be moved to a virtual method.\r\n- The Config getter can be made better for nested Jobs, probably in another PR. See comment above."}}