{"action":"created","comment":{"url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/comments/51318103","id":51318103,"diff_hunk":"@@ -506,16 +531,18 @@ class MountServiceSpec extends Specification with ScalaCheck with Http4s {\n         }\n       }\n \n-      \"be 400 with missing X-File-Name header\" ! prop { (parent: ADir, fsDir: RDir) =>\n-        runTest { service =>\n-          for {\n-            resp <- service(Request(\n-                      method = POST,\n-                      uri = pathUri(parent))\n-                    .withBody(\"\"\"{ \"stub\": { \"connectionUri\": \"foo\" } }\"\"\").run)\n-          } yield {\n-            resp.as[Json].run must_== Json(\"error\" := \"The 'X-File-Name' header must be specified\")\n-            resp.status must_== Status.BadRequest\n+      \"be 400 with missing X-File-Name header\" ! prop { (parent: ADir) =>","path":"web/src/test/scala/quasar/api/services/MountServiceSpec.scala","position":404,"original_position":404,"commit_id":"f6b37d7a0559e9ef65ace7ff5439df6cff450e2a","original_commit_id":"f6b37d7a0559e9ef65ace7ff5439df6cff450e2a","user":{"login":"jedesah","id":1780116,"avatar_url":"https://avatars.githubusercontent.com/u/1780116?v=3","gravatar_id":"","url":"https://api.github.com/users/jedesah","html_url":"https://github.com/jedesah","followers_url":"https://api.github.com/users/jedesah/followers","following_url":"https://api.github.com/users/jedesah/following{/other_user}","gists_url":"https://api.github.com/users/jedesah/gists{/gist_id}","starred_url":"https://api.github.com/users/jedesah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedesah/subscriptions","organizations_url":"https://api.github.com/users/jedesah/orgs","repos_url":"https://api.github.com/users/jedesah/repos","events_url":"https://api.github.com/users/jedesah/events{/privacy}","received_events_url":"https://api.github.com/users/jedesah/received_events","type":"User","site_admin":false},"body":"huh, nice catch on getting rid of pointless `fsDir`.","created_at":"2016-01-29T21:27:47Z","updated_at":"2016-01-29T21:27:47Z","html_url":"https://github.com/quasar-analytics/quasar/pull/1071#discussion_r51318103","pull_request_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1071","_links":{"self":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/comments/51318103"},"html":{"href":"https://github.com/quasar-analytics/quasar/pull/1071#discussion_r51318103"},"pull_request":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1071"}}},"pull_request":{"url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1071","id":57698447,"html_url":"https://github.com/quasar-analytics/quasar/pull/1071","diff_url":"https://github.com/quasar-analytics/quasar/pull/1071.diff","patch_url":"https://github.com/quasar-analytics/quasar/pull/1071.patch","issue_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/1071","number":1071,"state":"open","locked":false,"title":"Path encoding/escaping issues","user":{"login":"mossprescott","id":6147371,"avatar_url":"https://avatars.githubusercontent.com/u/6147371?v=3","gravatar_id":"","url":"https://api.github.com/users/mossprescott","html_url":"https://github.com/mossprescott","followers_url":"https://api.github.com/users/mossprescott/followers","following_url":"https://api.github.com/users/mossprescott/following{/other_user}","gists_url":"https://api.github.com/users/mossprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/mossprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossprescott/subscriptions","organizations_url":"https://api.github.com/users/mossprescott/orgs","repos_url":"https://api.github.com/users/mossprescott/repos","events_url":"https://api.github.com/users/mossprescott/events{/privacy}","received_events_url":"https://api.github.com/users/mossprescott/received_events","type":"User","site_admin":false},"body":"Really not happy about all the silly filtering this requires in the tests but didn't want to make this wait for a fix in pathy. On the other hand, switching the escape char for DB's has hardly any fallout.\r\n\r\nWith this in place, I can add folders at the DB-level, through the API, with names like `Untitled Folder.slam` and `foo/bar.slam`:\r\n```\r\n> show databases\r\n...\r\nUntitled+Folder~slam  0.078GB\r\nadmin                 0.078GB\r\nfoo%divbar~slam       0.078GB\r\nquasar-test           0.453GB\r\n```","created_at":"2016-01-29T20:28:41Z","updated_at":"2016-01-29T21:27:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc4015d946fc069e83b6cfb8065ba16b8ae876de","assignee":{"login":"jedesah","id":1780116,"avatar_url":"https://avatars.githubusercontent.com/u/1780116?v=3","gravatar_id":"","url":"https://api.github.com/users/jedesah","html_url":"https://github.com/jedesah","followers_url":"https://api.github.com/users/jedesah/followers","following_url":"https://api.github.com/users/jedesah/following{/other_user}","gists_url":"https://api.github.com/users/jedesah/gists{/gist_id}","starred_url":"https://api.github.com/users/jedesah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedesah/subscriptions","organizations_url":"https://api.github.com/users/jedesah/orgs","repos_url":"https://api.github.com/users/jedesah/repos","events_url":"https://api.github.com/users/jedesah/events{/privacy}","received_events_url":"https://api.github.com/users/jedesah/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1071/commits","review_comments_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1071/comments","review_comment_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/1071/comments","statuses_url":"https://api.github.com/repos/quasar-analytics/quasar/statuses/f6b37d7a0559e9ef65ace7ff5439df6cff450e2a","head":{"label":"mossprescott:wip/pathy-URL-decoding","ref":"wip/pathy-URL-decoding","sha":"f6b37d7a0559e9ef65ace7ff5439df6cff450e2a","user":{"login":"mossprescott","id":6147371,"avatar_url":"https://avatars.githubusercontent.com/u/6147371?v=3","gravatar_id":"","url":"https://api.github.com/users/mossprescott","html_url":"https://github.com/mossprescott","followers_url":"https://api.github.com/users/mossprescott/followers","following_url":"https://api.github.com/users/mossprescott/following{/other_user}","gists_url":"https://api.github.com/users/mossprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/mossprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossprescott/subscriptions","organizations_url":"https://api.github.com/users/mossprescott/orgs","repos_url":"https://api.github.com/users/mossprescott/repos","events_url":"https://api.github.com/users/mossprescott/events{/privacy}","received_events_url":"https://api.github.com/users/mossprescott/received_events","type":"User","site_admin":false},"repo":{"id":21178367,"name":"quasar","full_name":"mossprescott/quasar","owner":{"login":"mossprescott","id":6147371,"avatar_url":"https://avatars.githubusercontent.com/u/6147371?v=3","gravatar_id":"","url":"https://api.github.com/users/mossprescott","html_url":"https://github.com/mossprescott","followers_url":"https://api.github.com/users/mossprescott/followers","following_url":"https://api.github.com/users/mossprescott/following{/other_user}","gists_url":"https://api.github.com/users/mossprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/mossprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossprescott/subscriptions","organizations_url":"https://api.github.com/users/mossprescott/orgs","repos_url":"https://api.github.com/users/mossprescott/repos","events_url":"https://api.github.com/users/mossprescott/events{/privacy}","received_events_url":"https://api.github.com/users/mossprescott/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mossprescott/quasar","description":"The engine for SlamData","fork":true,"url":"https://api.github.com/repos/mossprescott/quasar","forks_url":"https://api.github.com/repos/mossprescott/quasar/forks","keys_url":"https://api.github.com/repos/mossprescott/quasar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mossprescott/quasar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mossprescott/quasar/teams","hooks_url":"https://api.github.com/repos/mossprescott/quasar/hooks","issue_events_url":"https://api.github.com/repos/mossprescott/quasar/issues/events{/number}","events_url":"https://api.github.com/repos/mossprescott/quasar/events","assignees_url":"https://api.github.com/repos/mossprescott/quasar/assignees{/user}","branches_url":"https://api.github.com/repos/mossprescott/quasar/branches{/branch}","tags_url":"https://api.github.com/repos/mossprescott/quasar/tags","blobs_url":"https://api.github.com/repos/mossprescott/quasar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mossprescott/quasar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mossprescott/quasar/git/refs{/sha}","trees_url":"https://api.github.com/repos/mossprescott/quasar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mossprescott/quasar/statuses/{sha}","languages_url":"https://api.github.com/repos/mossprescott/quasar/languages","stargazers_url":"https://api.github.com/repos/mossprescott/quasar/stargazers","contributors_url":"https://api.github.com/repos/mossprescott/quasar/contributors","subscribers_url":"https://api.github.com/repos/mossprescott/quasar/subscribers","subscription_url":"https://api.github.com/repos/mossprescott/quasar/subscription","commits_url":"https://api.github.com/repos/mossprescott/quasar/commits{/sha}","git_commits_url":"https://api.github.com/repos/mossprescott/quasar/git/commits{/sha}","comments_url":"https://api.github.com/repos/mossprescott/quasar/comments{/number}","issue_comment_url":"https://api.github.com/repos/mossprescott/quasar/issues/comments{/number}","contents_url":"https://api.github.com/repos/mossprescott/quasar/contents/{+path}","compare_url":"https://api.github.com/repos/mossprescott/quasar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mossprescott/quasar/merges","archive_url":"https://api.github.com/repos/mossprescott/quasar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mossprescott/quasar/downloads","issues_url":"https://api.github.com/repos/mossprescott/quasar/issues{/number}","pulls_url":"https://api.github.com/repos/mossprescott/quasar/pulls{/number}","milestones_url":"https://api.github.com/repos/mossprescott/quasar/milestones{/number}","notifications_url":"https://api.github.com/repos/mossprescott/quasar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mossprescott/quasar/labels{/name}","releases_url":"https://api.github.com/repos/mossprescott/quasar/releases{/id}","deployments_url":"https://api.github.com/repos/mossprescott/quasar/deployments","created_at":"2014-06-24T19:43:22Z","updated_at":"2015-09-14T21:35:18Z","pushed_at":"2016-01-29T20:18:31Z","git_url":"git://github.com/mossprescott/quasar.git","ssh_url":"git@github.com:mossprescott/quasar.git","clone_url":"https://github.com/mossprescott/quasar.git","svn_url":"https://github.com/mossprescott/quasar","homepage":null,"size":8954,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CHECK-UPSTREAM-REPO"}},"base":{"label":"quasar-analytics:feature/translate_web_api_for_free","ref":"feature/translate_web_api_for_free","sha":"ef78fbe87fafa2ed4ba99d4a7cc202cbec32be9a","user":{"login":"quasar-analytics","id":15095906,"avatar_url":"https://avatars.githubusercontent.com/u/15095906?v=3","gravatar_id":"","url":"https://api.github.com/users/quasar-analytics","html_url":"https://github.com/quasar-analytics","followers_url":"https://api.github.com/users/quasar-analytics/followers","following_url":"https://api.github.com/users/quasar-analytics/following{/other_user}","gists_url":"https://api.github.com/users/quasar-analytics/gists{/gist_id}","starred_url":"https://api.github.com/users/quasar-analytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quasar-analytics/subscriptions","organizations_url":"https://api.github.com/users/quasar-analytics/orgs","repos_url":"https://api.github.com/users/quasar-analytics/repos","events_url":"https://api.github.com/users/quasar-analytics/events{/privacy}","received_events_url":"https://api.github.com/users/quasar-analytics/received_events","type":"Organization","site_admin":false},"repo":{"id":16515058,"name":"quasar","full_name":"quasar-analytics/quasar","owner":{"login":"quasar-analytics","id":15095906,"avatar_url":"https://avatars.githubusercontent.com/u/15095906?v=3","gravatar_id":"","url":"https://api.github.com/users/quasar-analytics","html_url":"https://github.com/quasar-analytics","followers_url":"https://api.github.com/users/quasar-analytics/followers","following_url":"https://api.github.com/users/quasar-analytics/following{/other_user}","gists_url":"https://api.github.com/users/quasar-analytics/gists{/gist_id}","starred_url":"https://api.github.com/users/quasar-analytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quasar-analytics/subscriptions","organizations_url":"https://api.github.com/users/quasar-analytics/orgs","repos_url":"https://api.github.com/users/quasar-analytics/repos","events_url":"https://api.github.com/users/quasar-analytics/events{/privacy}","received_events_url":"https://api.github.com/users/quasar-analytics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quasar-analytics/quasar","description":"A NoSQL analytics engine that embraces post-relational analytics and pushes computation to the data.","fork":false,"url":"https://api.github.com/repos/quasar-analytics/quasar","forks_url":"https://api.github.com/repos/quasar-analytics/quasar/forks","keys_url":"https://api.github.com/repos/quasar-analytics/quasar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quasar-analytics/quasar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quasar-analytics/quasar/teams","hooks_url":"https://api.github.com/repos/quasar-analytics/quasar/hooks","issue_events_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/events{/number}","events_url":"https://api.github.com/repos/quasar-analytics/quasar/events","assignees_url":"https://api.github.com/repos/quasar-analytics/quasar/assignees{/user}","branches_url":"https://api.github.com/repos/quasar-analytics/quasar/branches{/branch}","tags_url":"https://api.github.com/repos/quasar-analytics/quasar/tags","blobs_url":"https://api.github.com/repos/quasar-analytics/quasar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quasar-analytics/quasar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quasar-analytics/quasar/git/refs{/sha}","trees_url":"https://api.github.com/repos/quasar-analytics/quasar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quasar-analytics/quasar/statuses/{sha}","languages_url":"https://api.github.com/repos/quasar-analytics/quasar/languages","stargazers_url":"https://api.github.com/repos/quasar-analytics/quasar/stargazers","contributors_url":"https://api.github.com/repos/quasar-analytics/quasar/contributors","subscribers_url":"https://api.github.com/repos/quasar-analytics/quasar/subscribers","subscription_url":"https://api.github.com/repos/quasar-analytics/quasar/subscription","commits_url":"https://api.github.com/repos/quasar-analytics/quasar/commits{/sha}","git_commits_url":"https://api.github.com/repos/quasar-analytics/quasar/git/commits{/sha}","comments_url":"https://api.github.com/repos/quasar-analytics/quasar/comments{/number}","issue_comment_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/comments{/number}","contents_url":"https://api.github.com/repos/quasar-analytics/quasar/contents/{+path}","compare_url":"https://api.github.com/repos/quasar-analytics/quasar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quasar-analytics/quasar/merges","archive_url":"https://api.github.com/repos/quasar-analytics/quasar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quasar-analytics/quasar/downloads","issues_url":"https://api.github.com/repos/quasar-analytics/quasar/issues{/number}","pulls_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls{/number}","milestones_url":"https://api.github.com/repos/quasar-analytics/quasar/milestones{/number}","notifications_url":"https://api.github.com/repos/quasar-analytics/quasar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quasar-analytics/quasar/labels{/name}","releases_url":"https://api.github.com/repos/quasar-analytics/quasar/releases{/id}","deployments_url":"https://api.github.com/repos/quasar-analytics/quasar/deployments","created_at":"2014-02-04T15:01:27Z","updated_at":"2016-01-22T14:41:21Z","pushed_at":"2016-01-29T20:28:41Z","git_url":"git://github.com/quasar-analytics/quasar.git","ssh_url":"git@github.com:quasar-analytics/quasar.git","clone_url":"https://github.com/quasar-analytics/quasar.git","svn_url":"https://github.com/quasar-analytics/quasar","homepage":"","size":9175,"stargazers_count":206,"watchers_count":206,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":4,"forks":35,"open_issues":4,"watchers":206,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1071"},"html":{"href":"https://github.com/quasar-analytics/quasar/pull/1071"},"issue":{"href":"https://api.github.com/repos/quasar-analytics/quasar/issues/1071"},"comments":{"href":"https://api.github.com/repos/quasar-analytics/quasar/issues/1071/comments"},"review_comments":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1071/comments"},"review_comment":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1071/commits"},"statuses":{"href":"https://api.github.com/repos/quasar-analytics/quasar/statuses/f6b37d7a0559e9ef65ace7ff5439df6cff450e2a"}}}}