{"action":"created","issue":{"url":"https://api.github.com/repos/att/rcloud/issues/2261","repository_url":"https://api.github.com/repos/att/rcloud","labels_url":"https://api.github.com/repos/att/rcloud/issues/2261/labels{/name}","comments_url":"https://api.github.com/repos/att/rcloud/issues/2261/comments","events_url":"https://api.github.com/repos/att/rcloud/issues/2261/events","html_url":"https://github.com/att/rcloud/pull/2261","id":175756880,"number":2261,"title":"Modifier click + target shortcut support","user":{"login":"shaneporter","id":2493614,"avatar_url":"https://avatars.githubusercontent.com/u/2493614?v=3","gravatar_id":"","url":"https://api.github.com/users/shaneporter","html_url":"https://github.com/shaneporter","followers_url":"https://api.github.com/users/shaneporter/followers","following_url":"https://api.github.com/users/shaneporter/following{/other_user}","gists_url":"https://api.github.com/users/shaneporter/gists{/gist_id}","starred_url":"https://api.github.com/users/shaneporter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaneporter/subscriptions","organizations_url":"https://api.github.com/users/shaneporter/orgs","repos_url":"https://api.github.com/users/shaneporter/repos","events_url":"https://api.github.com/users/shaneporter/events{/privacy}","received_events_url":"https://api.github.com/users/shaneporter/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/att/rcloud/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/att/rcloud/milestones/30","html_url":"https://github.com/att/rcloud/milestones/1.6.2","labels_url":"https://api.github.com/repos/att/rcloud/milestones/30/labels","id":1930094,"number":30,"title":"1.6.2","description":"more small fixes and improvments","creator":{"login":"gordonwoodhull","id":1366709,"avatar_url":"https://avatars.githubusercontent.com/u/1366709?v=3","gravatar_id":"","url":"https://api.github.com/users/gordonwoodhull","html_url":"https://github.com/gordonwoodhull","followers_url":"https://api.github.com/users/gordonwoodhull/followers","following_url":"https://api.github.com/users/gordonwoodhull/following{/other_user}","gists_url":"https://api.github.com/users/gordonwoodhull/gists{/gist_id}","starred_url":"https://api.github.com/users/gordonwoodhull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gordonwoodhull/subscriptions","organizations_url":"https://api.github.com/users/gordonwoodhull/orgs","repos_url":"https://api.github.com/users/gordonwoodhull/repos","events_url":"https://api.github.com/users/gordonwoodhull/events{/privacy}","received_events_url":"https://api.github.com/users/gordonwoodhull/received_events","type":"User","site_admin":false},"open_issues":22,"closed_issues":11,"state":"open","created_at":"2016-08-08T17:20:16Z","updated_at":"2016-09-16T18:20:06Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2016-09-08T13:42:24Z","updated_at":"2016-09-16T18:20:06Z","closed_at":"2016-09-16T18:20:06Z","pull_request":{"url":"https://api.github.com/repos/att/rcloud/pulls/2261","html_url":"https://github.com/att/rcloud/pull/2261","diff_url":"https://github.com/att/rcloud/pull/2261.diff","patch_url":"https://github.com/att/rcloud/pull/2261.patch"},"body":"Intended to be a 'documentation style' shortcut, the new `click_keys` shortcut property enables the following type of shortcut:\r\n\r\n'Shift click on the play button'\r\n\r\nThe object structure is like this:\r\n\r\n````javascript\r\nclick_keys: {\r\n    target: 'Play button',\r\n    win_mac: [\r\n        ['shift']\r\n    ]\r\n}\r\n````\r\n\r\nThe `win_mac` property is optional, and follows the pattern of existing shortcuts, which has one of `win`, `mac` or `win_mac` properties set.\r\n\r\nI have added an example into `init.js` (see below). \r\n\r\nOne aspect I'm not entirely happy with is the display of the shortcut in the shortcut dialog:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/2493614/18351456/267dc93a-75d2-11e6-922c-e7ce083add1e.png)\r\n\r\nThe 'shift' + 'key(s)' and 'target' parts are enclosed in a `kbd` element, but I think this can be better.\r\n\r\nThis won't be a big change of course."},"comment":{"url":"https://api.github.com/repos/att/rcloud/issues/comments/247671440","html_url":"https://github.com/att/rcloud/pull/2261#issuecomment-247671440","issue_url":"https://api.github.com/repos/att/rcloud/issues/2261","id":247671440,"user":{"login":"gordonwoodhull","id":1366709,"avatar_url":"https://avatars.githubusercontent.com/u/1366709?v=3","gravatar_id":"","url":"https://api.github.com/users/gordonwoodhull","html_url":"https://github.com/gordonwoodhull","followers_url":"https://api.github.com/users/gordonwoodhull/followers","following_url":"https://api.github.com/users/gordonwoodhull/following{/other_user}","gists_url":"https://api.github.com/users/gordonwoodhull/gists{/gist_id}","starred_url":"https://api.github.com/users/gordonwoodhull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gordonwoodhull/subscriptions","organizations_url":"https://api.github.com/users/gordonwoodhull/orgs","repos_url":"https://api.github.com/users/gordonwoodhull/repos","events_url":"https://api.github.com/users/gordonwoodhull/events{/privacy}","received_events_url":"https://api.github.com/users/gordonwoodhull/received_events","type":"User","site_admin":false},"created_at":"2016-09-16T18:20:06Z","updated_at":"2016-09-16T18:20:06Z","body":"added a few in the linked commits. it's a start!\r\n\r\nRebased and merged. Thanks @shaneporter!\r\n"}}
{"actor":{"display_login":"gordonwoodhull"}}