{"action":"created","issue":{"url":"https://api.github.com/repos/broadinstitute/rawls/issues/421","repository_url":"https://api.github.com/repos/broadinstitute/rawls","labels_url":"https://api.github.com/repos/broadinstitute/rawls/issues/421/labels{/name}","comments_url":"https://api.github.com/repos/broadinstitute/rawls/issues/421/comments","events_url":"https://api.github.com/repos/broadinstitute/rawls/issues/421/events","html_url":"https://github.com/broadinstitute/rawls/pull/421","id":154553956,"number":421,"title":"GAWB-678: persist timestamps for submission/workflow status changes","user":{"login":"davidangb","id":6041577,"avatar_url":"https://avatars.githubusercontent.com/u/6041577?v=3","gravatar_id":"","url":"https://api.github.com/users/davidangb","html_url":"https://github.com/davidangb","followers_url":"https://api.github.com/users/davidangb/followers","following_url":"https://api.github.com/users/davidangb/following{/other_user}","gists_url":"https://api.github.com/users/davidangb/gists{/gist_id}","starred_url":"https://api.github.com/users/davidangb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidangb/subscriptions","organizations_url":"https://api.github.com/users/davidangb/orgs","repos_url":"https://api.github.com/users/davidangb/repos","events_url":"https://api.github.com/users/davidangb/events{/privacy}","received_events_url":"https://api.github.com/users/davidangb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"davidangb","id":6041577,"avatar_url":"https://avatars.githubusercontent.com/u/6041577?v=3","gravatar_id":"","url":"https://api.github.com/users/davidangb","html_url":"https://github.com/davidangb","followers_url":"https://api.github.com/users/davidangb/followers","following_url":"https://api.github.com/users/davidangb/following{/other_user}","gists_url":"https://api.github.com/users/davidangb/gists{/gist_id}","starred_url":"https://api.github.com/users/davidangb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidangb/subscriptions","organizations_url":"https://api.github.com/users/davidangb/orgs","repos_url":"https://api.github.com/users/davidangb/repos","events_url":"https://api.github.com/users/davidangb/events{/privacy}","received_events_url":"https://api.github.com/users/davidangb/received_events","type":"User","site_admin":false},"milestone":null,"comments":8,"created_at":"2016-05-12T18:47:23Z","updated_at":"2016-05-13T19:54:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/broadinstitute/rawls/pulls/421","html_url":"https://github.com/broadinstitute/rawls/pull/421","diff_url":"https://github.com/broadinstitute/rawls/pull/421.diff","patch_url":"https://github.com/broadinstitute/rawls/pull/421.patch"},"body":"Create new tables to record status changes and timestamps for workflows and submissions.\r\n\r\nI've done this using database triggers, as opposed to Scala code ... keeps things simple, at the potential cost of splitting our implementation logic into multiple locations.\r\n\r\n- [x] **Submitter**: Rebase to develop. DO NOT SQUASH\r\n- [x] **Submitter**: Make sure Swagger is updated if API changes\r\n- [x] **Submitter**: Make sure documentation for code is complete\r\n- [x] **Submitter**: Make sure liquibase is updated if appropriate\r\n- [x] **Submitter**: Review code comments; remove done TODOs, create stories for remaining TODOs\r\n- [x] **Submitter**: Include the JIRA issue number in the PR description\r\n- [x] **Submitter**: Add description or comments on the PR explaining the hows/whys (if not obvious)\r\n- [x] Tell ![](http://i.imgur.com/9dLzbPd.png) that the PR exists if he wants to look at it **(apply requires_doge label)**\r\n- [x] Anoint a lead reviewer (LR). **Assign PR to LR**\r\n- [x] **LR**: Initial review by LR and others.\r\n- [x] Comment / review / update cycle:\r\n  * Rest of team may comments on PR at will\r\n  * **LR assigns to submitter** for feedback fixes\r\n  * Submitter updates documentation as needed\r\n  * Submitter rebases to develop again if necessary\r\n  * Submitter makes further commits. DO NOT SQUASH. **Reassign to LR** for further feedback\r\n- [x] ![](http://i.imgur.com/9dLzbPd.png) sign off\r\n- [x] **LR** sign off\r\n- [ ] **Assign to submitter** to finalize\r\n- [ ] **Submitter**: Squash commits, rebase if necessary\r\n- [ ] **Submitter**: Verify all tests go green, including CI tests\r\n- [ ] **Submitter**: Merge to develop \r\n- [ ] **Submitter**: Delete branch after merge\r\n- [ ] **Submitter**: Check configuration files in Jenkins in case they need changes\r\n- [ ] **Submitter**: **Test this change works on dev environment after deployment**. YOU own getting it fixed if dev isn't working for ANY reason!\r\n- [ ] **Submitter**: Verify swagger UI on dev environment still works after deployment\r\n- [ ] **Submitter**: Inform other teams of any API changes via hipchat and/or email\r\n- [ ] **Submitter**: Mark JIRA issue as resolved once this checklist is completed\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/broadinstitute/rawls/issues/comments/219143358","html_url":"https://github.com/broadinstitute/rawls/pull/421#issuecomment-219143358","issue_url":"https://api.github.com/repos/broadinstitute/rawls/issues/421","id":219143358,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-05-13T19:54:02Z","updated_at":"2016-05-13T19:54:02Z","body":"\n[![Coverage Status](https://coveralls.io/builds/6175567/badge)](https://coveralls.io/builds/6175567)\n\nCoverage remained the same at 78.139% when pulling **05a75a98cf4dd753df7bfdafc0e784164cd5afd1 on da_GAWB-678_statusChangeLogging** into **1bac55e106cee5021851608164e02b0e9b57a8c5 on develop**.\n"}}