{"action":"created","issue":{"url":"https://api.github.com/repos/kripken/emscripten-fastcomp/issues/137","repository_url":"https://api.github.com/repos/kripken/emscripten-fastcomp","labels_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/issues/137/labels{/name}","comments_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/issues/137/comments","events_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/issues/137/events","html_url":"https://github.com/kripken/emscripten-fastcomp/issues/137","id":133725085,"number":137,"title":"Update the NaCl code?","user":{"login":"tomaka","id":1412254,"avatar_url":"https://avatars.githubusercontent.com/u/1412254?v=3","gravatar_id":"","url":"https://api.github.com/users/tomaka","html_url":"https://github.com/tomaka","followers_url":"https://api.github.com/users/tomaka/followers","following_url":"https://api.github.com/users/tomaka/following{/other_user}","gists_url":"https://api.github.com/users/tomaka/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaka/subscriptions","organizations_url":"https://api.github.com/users/tomaka/orgs","repos_url":"https://api.github.com/users/tomaka/repos","events_url":"https://api.github.com/users/tomaka/events{/privacy}","received_events_url":"https://api.github.com/users/tomaka/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2016-02-15T14:25:16Z","updated_at":"2016-02-16T10:15:32Z","closed_at":null,"body":"I just ran into a very nasty bug with the `NaCl/SimplifyStructRegSignatures` pass that didn't remove the `pure` attribute (its real name is `readnone` I think) from functions after changing their signatures to not be pure anymore. This ended up causing a lot of test failures in the Rust tests suite.\r\n\r\nIt turns out this bug is already fixed in [the PNaCl repository](https://chromium.googlesource.com/native_client/pnacl-llvm/+/master/lib/Transforms/NaCl/SimplifyStructRegSignatures.cpp).\r\n\r\nIt would be nice to eventually update the emscripten code to be up-to-date with NaCl. I'm not familiar enough with how all this works to do this myself (I received a lot of help from folks on IRC just to diagnose the problem).\r\n"},"comment":{"url":"https://api.github.com/repos/kripken/emscripten-fastcomp/issues/comments/184609689","html_url":"https://github.com/kripken/emscripten-fastcomp/issues/137#issuecomment-184609689","issue_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/issues/137","id":184609689,"user":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"created_at":"2016-02-16T10:15:32Z","updated_at":"2016-02-16T10:15:32Z","body":"The `*0,0*` output could be changed, though, to anything you want (they're two stores of `0` in the IR)."}}