{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37346","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37346/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37346/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37346/events","html_url":"https://github.com/kubernetes/kubernetes/pull/37346","id":191197909,"number":37346,"title":"support more than one manifest headers","user":{"login":"chentao1596","id":22974967,"avatar_url":"https://avatars.githubusercontent.com/u/22974967?v=3","gravatar_id":"","url":"https://api.github.com/users/chentao1596","html_url":"https://github.com/chentao1596","followers_url":"https://api.github.com/users/chentao1596/followers","following_url":"https://api.github.com/users/chentao1596/following{/other_user}","gists_url":"https://api.github.com/users/chentao1596/gists{/gist_id}","starred_url":"https://api.github.com/users/chentao1596/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chentao1596/subscriptions","organizations_url":"https://api.github.com/users/chentao1596/orgs","repos_url":"https://api.github.com/users/chentao1596/repos","events_url":"https://api.github.com/users/chentao1596/events{/privacy}","received_events_url":"https://api.github.com/users/chentao1596/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":261005360,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/api-change","name":"kind/api-change","color":"c7def8","default":false},{"id":349530192,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-label-needed","name":"release-note-label-needed","color":"db5a64","default":false},{"id":253450895,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"assignees":[{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-11-23T06:36:37Z","updated_at":"2016-11-23T06:40:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37346","html_url":"https://github.com/kubernetes/kubernetes/pull/37346","diff_url":"https://github.com/kubernetes/kubernetes/pull/37346.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/37346.patch"},"body":"why we need it:\r\n    Only support one header parameter when getting pod from HTTP source, it's not work very well when server need multi header parameters.\r\n\r\nWhat this PR does:\r\n    1) Change the meaning of the parameter \"manifest-url-header\": from one to multi headers\r\n    2) Change the describe of the parameter \"manifest-url-header\":\r\n         2.1) In the past, the parameter shouled be like \"key:value\"\r\n         2.2) Now, it can be \"key1:value1,key2:value2,key3:value3\" if more than one header exist \r\n    3) Change the process of parsing parameter kubeCfg.ManifestURLHeader following 2.2)\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/37346)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/262443591","html_url":"https://github.com/kubernetes/kubernetes/pull/37346#issuecomment-262443591","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37346","id":262443591,"user":{"login":"k8s-merge-robot","id":13653959,"avatar_url":"https://avatars.githubusercontent.com/u/13653959?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-merge-robot","html_url":"https://github.com/k8s-merge-robot","followers_url":"https://api.github.com/users/k8s-merge-robot/followers","following_url":"https://api.github.com/users/k8s-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-merge-robot/orgs","repos_url":"https://api.github.com/users/k8s-merge-robot/repos","events_url":"https://api.github.com/users/k8s-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-merge-robot/received_events","type":"User","site_admin":false},"created_at":"2016-11-23T06:40:55Z","updated_at":"2016-11-23T06:40:55Z","body":"Labelling this PR as size/S"}}
{"actor":{"display_login":"k8s-merge-robot"}}