{"action":"created","comment":{"url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/pulls/comments/77898838","id":77898838,"diff_hunk":"@@ -203,7 +205,9 @@ func (sc *SmartCollector) CollectMetrics(mts []plugin.MetricType) ([]plugin.Metr\n \t\t\tfor _, dev := range devices {\n \t\t\t\tcollected, result, err := sc.DiskMetrics(ns, t, dev, attribute_path, buffered_results, errs)\n \t\t\t\tif err != nil {\n-\t\t\t\t\tsc.logger.Error(fmt.Sprintf(\"Error collecting SMART %s data on %s disk: %#+v\", attribute_path, dev, err))\n+\t\t\t\t\teStr := fmt.Sprintf(\"Error collecting SMART %s data on %s disk: %#+v\", attribute_path, dev, err)","path":"smart/plugin.go","position":16,"original_position":16,"commit_id":"2f518a21baab1138463c2ab21bea831c7b67d220","original_commit_id":"2f518a21baab1138463c2ab21bea831c7b67d220","user":{"login":"candysmurf","id":13841563,"avatar_url":"https://avatars.githubusercontent.com/u/13841563?v=3","gravatar_id":"","url":"https://api.github.com/users/candysmurf","html_url":"https://github.com/candysmurf","followers_url":"https://api.github.com/users/candysmurf/followers","following_url":"https://api.github.com/users/candysmurf/following{/other_user}","gists_url":"https://api.github.com/users/candysmurf/gists{/gist_id}","starred_url":"https://api.github.com/users/candysmurf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candysmurf/subscriptions","organizations_url":"https://api.github.com/users/candysmurf/orgs","repos_url":"https://api.github.com/users/candysmurf/repos","events_url":"https://api.github.com/users/candysmurf/events{/privacy}","received_events_url":"https://api.github.com/users/candysmurf/received_events","type":"User","site_admin":false},"body":"Same as the comment below. It seems that it logs single error then append to log all errors together. We only need one way to log errors. I think. If the single error is more readable, stick to that.","created_at":"2016-09-07T20:37:25Z","updated_at":"2016-09-07T20:37:25Z","html_url":"https://github.com/intelsdi-x/snap-plugin-collector-smart/pull/28#discussion_r77898838","pull_request_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/pulls/comments/77898838"},"html":{"href":"https://github.com/intelsdi-x/snap-plugin-collector-smart/pull/28#discussion_r77898838"},"pull_request":{"href":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/pulls/28","id":84329021,"html_url":"https://github.com/intelsdi-x/snap-plugin-collector-smart/pull/28","diff_url":"https://github.com/intelsdi-x/snap-plugin-collector-smart/pull/28.diff","patch_url":"https://github.com/intelsdi-x/snap-plugin-collector-smart/pull/28.patch","issue_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/issues/28","number":28,"state":"open","locked":false,"title":"Fix for issue #27: smart plugin returns error if nothing is collected","user":{"login":"obourdon","id":1381878,"avatar_url":"https://avatars.githubusercontent.com/u/1381878?v=3","gravatar_id":"","url":"https://api.github.com/users/obourdon","html_url":"https://github.com/obourdon","followers_url":"https://api.github.com/users/obourdon/followers","following_url":"https://api.github.com/users/obourdon/following{/other_user}","gists_url":"https://api.github.com/users/obourdon/gists{/gist_id}","starred_url":"https://api.github.com/users/obourdon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obourdon/subscriptions","organizations_url":"https://api.github.com/users/obourdon/orgs","repos_url":"https://api.github.com/users/obourdon/repos","events_url":"https://api.github.com/users/obourdon/events{/privacy}","received_events_url":"https://api.github.com/users/obourdon/received_events","type":"User","site_admin":false},"body":"Subject says it all\r\n\r\nwill wait for TravisCI to run tests before potentially submitting new revision as tests execution is system dependant","created_at":"2016-09-07T16:04:02Z","updated_at":"2016-09-07T20:37:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f980191ee381deb6b7df354474fc7a1ab9037fa3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/pulls/28/commits","review_comments_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/pulls/28/comments","review_comment_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/pulls/comments{/number}","comments_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/issues/28/comments","statuses_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/statuses/2f518a21baab1138463c2ab21bea831c7b67d220","head":{"label":"obourdon:fix_4_issue_27","ref":"fix_4_issue_27","sha":"2f518a21baab1138463c2ab21bea831c7b67d220","user":{"login":"obourdon","id":1381878,"avatar_url":"https://avatars.githubusercontent.com/u/1381878?v=3","gravatar_id":"","url":"https://api.github.com/users/obourdon","html_url":"https://github.com/obourdon","followers_url":"https://api.github.com/users/obourdon/followers","following_url":"https://api.github.com/users/obourdon/following{/other_user}","gists_url":"https://api.github.com/users/obourdon/gists{/gist_id}","starred_url":"https://api.github.com/users/obourdon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obourdon/subscriptions","organizations_url":"https://api.github.com/users/obourdon/orgs","repos_url":"https://api.github.com/users/obourdon/repos","events_url":"https://api.github.com/users/obourdon/events{/privacy}","received_events_url":"https://api.github.com/users/obourdon/received_events","type":"User","site_admin":false},"repo":{"id":59589899,"name":"snap-plugin-collector-smart","full_name":"obourdon/snap-plugin-collector-smart","owner":{"login":"obourdon","id":1381878,"avatar_url":"https://avatars.githubusercontent.com/u/1381878?v=3","gravatar_id":"","url":"https://api.github.com/users/obourdon","html_url":"https://github.com/obourdon","followers_url":"https://api.github.com/users/obourdon/followers","following_url":"https://api.github.com/users/obourdon/following{/other_user}","gists_url":"https://api.github.com/users/obourdon/gists{/gist_id}","starred_url":"https://api.github.com/users/obourdon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obourdon/subscriptions","organizations_url":"https://api.github.com/users/obourdon/orgs","repos_url":"https://api.github.com/users/obourdon/repos","events_url":"https://api.github.com/users/obourdon/events{/privacy}","received_events_url":"https://api.github.com/users/obourdon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/obourdon/snap-plugin-collector-smart","description":"snap plugin for collecting S.M.A.R.T. metrics from Intel SSDs","fork":true,"url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart","forks_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/forks","keys_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/teams","hooks_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/hooks","issue_events_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/issues/events{/number}","events_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/events","assignees_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/assignees{/user}","branches_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/branches{/branch}","tags_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/tags","blobs_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/git/refs{/sha}","trees_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/statuses/{sha}","languages_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/languages","stargazers_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/stargazers","contributors_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/contributors","subscribers_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/subscribers","subscription_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/subscription","commits_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/commits{/sha}","git_commits_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/git/commits{/sha}","comments_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/comments{/number}","issue_comment_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/issues/comments{/number}","contents_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/contents/{+path}","compare_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/merges","archive_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/downloads","issues_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/issues{/number}","pulls_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/pulls{/number}","milestones_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/milestones{/number}","notifications_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/labels{/name}","releases_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/releases{/id}","deployments_url":"https://api.github.com/repos/obourdon/snap-plugin-collector-smart/deployments","created_at":"2016-05-24T16:28:31Z","updated_at":"2016-05-24T16:28:32Z","pushed_at":"2016-09-07T17:56:48Z","git_url":"git://github.com/obourdon/snap-plugin-collector-smart.git","ssh_url":"git@github.com:obourdon/snap-plugin-collector-smart.git","clone_url":"https://github.com/obourdon/snap-plugin-collector-smart.git","svn_url":"https://github.com/obourdon/snap-plugin-collector-smart","homepage":"","size":62,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"intelsdi-x:master","ref":"master","sha":"5f06ea6af9da44cd46cf675a984d1a94f608249f","user":{"login":"intelsdi-x","id":8398747,"avatar_url":"https://avatars.githubusercontent.com/u/8398747?v=3","gravatar_id":"","url":"https://api.github.com/users/intelsdi-x","html_url":"https://github.com/intelsdi-x","followers_url":"https://api.github.com/users/intelsdi-x/followers","following_url":"https://api.github.com/users/intelsdi-x/following{/other_user}","gists_url":"https://api.github.com/users/intelsdi-x/gists{/gist_id}","starred_url":"https://api.github.com/users/intelsdi-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intelsdi-x/subscriptions","organizations_url":"https://api.github.com/users/intelsdi-x/orgs","repos_url":"https://api.github.com/users/intelsdi-x/repos","events_url":"https://api.github.com/users/intelsdi-x/events{/privacy}","received_events_url":"https://api.github.com/users/intelsdi-x/received_events","type":"Organization","site_admin":false},"repo":{"id":44132970,"name":"snap-plugin-collector-smart","full_name":"intelsdi-x/snap-plugin-collector-smart","owner":{"login":"intelsdi-x","id":8398747,"avatar_url":"https://avatars.githubusercontent.com/u/8398747?v=3","gravatar_id":"","url":"https://api.github.com/users/intelsdi-x","html_url":"https://github.com/intelsdi-x","followers_url":"https://api.github.com/users/intelsdi-x/followers","following_url":"https://api.github.com/users/intelsdi-x/following{/other_user}","gists_url":"https://api.github.com/users/intelsdi-x/gists{/gist_id}","starred_url":"https://api.github.com/users/intelsdi-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intelsdi-x/subscriptions","organizations_url":"https://api.github.com/users/intelsdi-x/orgs","repos_url":"https://api.github.com/users/intelsdi-x/repos","events_url":"https://api.github.com/users/intelsdi-x/events{/privacy}","received_events_url":"https://api.github.com/users/intelsdi-x/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intelsdi-x/snap-plugin-collector-smart","description":"Collects Intel SSDs S.M.A.R.T. metrics","fork":false,"url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart","forks_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/forks","keys_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/teams","hooks_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/hooks","issue_events_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/issues/events{/number}","events_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/events","assignees_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/assignees{/user}","branches_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/branches{/branch}","tags_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/tags","blobs_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/git/refs{/sha}","trees_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/statuses/{sha}","languages_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/languages","stargazers_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/stargazers","contributors_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/contributors","subscribers_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/subscribers","subscription_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/subscription","commits_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/commits{/sha}","git_commits_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/git/commits{/sha}","comments_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/comments{/number}","issue_comment_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/issues/comments{/number}","contents_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/contents/{+path}","compare_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/merges","archive_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/downloads","issues_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/issues{/number}","pulls_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/pulls{/number}","milestones_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/milestones{/number}","notifications_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/labels{/name}","releases_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/releases{/id}","deployments_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/deployments","created_at":"2015-10-12T20:40:10Z","updated_at":"2016-07-15T21:43:55Z","pushed_at":"2016-09-07T17:56:48Z","git_url":"git://github.com/intelsdi-x/snap-plugin-collector-smart.git","ssh_url":"git@github.com:intelsdi-x/snap-plugin-collector-smart.git","clone_url":"https://github.com/intelsdi-x/snap-plugin-collector-smart.git","svn_url":"https://github.com/intelsdi-x/snap-plugin-collector-smart","homepage":"http://snap-telemetry.io/","size":57,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":6,"forks":9,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/pulls/28"},"html":{"href":"https://github.com/intelsdi-x/snap-plugin-collector-smart/pull/28"},"issue":{"href":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/issues/28"},"comments":{"href":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-smart/statuses/2f518a21baab1138463c2ab21bea831c7b67d220"}}}}
{"actor":{"display_login":"candysmurf"}}