{"action":"created","issue":{"url":"https://api.github.com/repos/lxc/lxd/issues/1486","labels_url":"https://api.github.com/repos/lxc/lxd/issues/1486/labels{/name}","comments_url":"https://api.github.com/repos/lxc/lxd/issues/1486/comments","events_url":"https://api.github.com/repos/lxc/lxd/issues/1486/events","html_url":"https://github.com/lxc/lxd/pull/1486","id":125614935,"number":1486,"title":"Added choosable formatting filesystem for LVs","user":{"login":"mickydelfavero","id":1653230,"avatar_url":"https://avatars.githubusercontent.com/u/1653230?v=3","gravatar_id":"","url":"https://api.github.com/users/mickydelfavero","html_url":"https://github.com/mickydelfavero","followers_url":"https://api.github.com/users/mickydelfavero/followers","following_url":"https://api.github.com/users/mickydelfavero/following{/other_user}","gists_url":"https://api.github.com/users/mickydelfavero/gists{/gist_id}","starred_url":"https://api.github.com/users/mickydelfavero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickydelfavero/subscriptions","organizations_url":"https://api.github.com/users/mickydelfavero/orgs","repos_url":"https://api.github.com/users/mickydelfavero/repos","events_url":"https://api.github.com/users/mickydelfavero/events{/privacy}","received_events_url":"https://api.github.com/users/mickydelfavero/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-08T13:39:45Z","updated_at":"2016-01-08T15:07:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lxc/lxd/pulls/1486","html_url":"https://github.com/lxc/lxd/pull/1486","diff_url":"https://github.com/lxc/lxd/pull/1486.diff","patch_url":"https://github.com/lxc/lxd/pull/1486.patch"},"body":"LXD has hardcoded ext4 as the filesystem to be used when LVM storage backend is choosed, I don't like very much ext* filesystems and prefer xfs over them so I've done a little patch to be able to use it with LXD.\r\n\r\nTo be able to choose preferred filesystem a key was added to the configuration parameter of LXD: storage.lvm_fstype, for now it's value can be only ext4 (default, so I don't break anything) and xfs, but it's trivial to add other filesystems.\r\n\r\nFor now the filesystem has to be choosen at LXD installation time, in the future I think it will be better to let the users to choose filesystem at container creation time so it'll be possible to have different filesystem for different container and so migrating a container from one host to another will be possible even if they have different default filesystem."},"comment":{"url":"https://api.github.com/repos/lxc/lxd/issues/comments/170026571","html_url":"https://github.com/lxc/lxd/pull/1486#issuecomment-170026571","issue_url":"https://api.github.com/repos/lxc/lxd/issues/1486","id":170026571,"user":{"login":"stgraber","id":2230599,"avatar_url":"https://avatars.githubusercontent.com/u/2230599?v=3","gravatar_id":"","url":"https://api.github.com/users/stgraber","html_url":"https://github.com/stgraber","followers_url":"https://api.github.com/users/stgraber/followers","following_url":"https://api.github.com/users/stgraber/following{/other_user}","gists_url":"https://api.github.com/users/stgraber/gists{/gist_id}","starred_url":"https://api.github.com/users/stgraber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stgraber/subscriptions","organizations_url":"https://api.github.com/users/stgraber/orgs","repos_url":"https://api.github.com/users/stgraber/repos","events_url":"https://api.github.com/users/stgraber/events{/privacy}","received_events_url":"https://api.github.com/users/stgraber/received_events","type":"User","site_admin":false},"created_at":"2016-01-08T15:07:00Z","updated_at":"2016-01-08T15:07:00Z","body":"Hi, \r\n\r\nCan you sign-off your commit? (see CONTRIBUTING.md)\r\n\r\nAlso, why is it necessary to call xfs_admin all the time for that uuid? isn't that done for you at mount time? \r\nIf it is, then you could use the generic mounting function from lxd/devices which detects the filesystem type for you. "}}