{"action":"created","comment":{"url":"https://api.github.com/repos/SmartSparrow/simcapi-js/pulls/comments/91638089","pull_request_review_id":12148984,"id":91638089,"diff_hunk":"@@ -606,6 +634,31 @@ define(function(require) {\n             self.sendMessage(message);\n         };\n \n+        var handleLocalDataChange = function(message) {\n+            if (self.localDataChangedCallbacks[message.values.simId] && self.localDataChangedCallbacks[message.values.simId][message.values.key]) {\n+                self.localDataChangedCallbacks[message.values.simId][message.values.key](message.values.value);\n+            }\n+        };\n+\n+        /*\n+         * Register the sim to be notified when local data changes","path":"app/scripts/api/snapshot/Transporter.js","position":164,"original_position":164,"commit_id":"746cf1d7a618ca5775680a1a9114618a46ac80b8","original_commit_id":"746cf1d7a618ca5775680a1a9114618a46ac80b8","user":{"login":"kiahn-johnston","id":13057077,"avatar_url":"https://avatars.githubusercontent.com/u/13057077?v=3","gravatar_id":"","url":"https://api.github.com/users/kiahn-johnston","html_url":"https://github.com/kiahn-johnston","followers_url":"https://api.github.com/users/kiahn-johnston/followers","following_url":"https://api.github.com/users/kiahn-johnston/following{/other_user}","gists_url":"https://api.github.com/users/kiahn-johnston/gists{/gist_id}","starred_url":"https://api.github.com/users/kiahn-johnston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiahn-johnston/subscriptions","organizations_url":"https://api.github.com/users/kiahn-johnston/orgs","repos_url":"https://api.github.com/users/kiahn-johnston/repos","events_url":"https://api.github.com/users/kiahn-johnston/events{/privacy}","received_events_url":"https://api.github.com/users/kiahn-johnston/received_events","type":"User","site_admin":false},"body":"can we add a bit to say something like 'which is only when the sim you are listening to makes a set request` ?","created_at":"2016-12-09T00:28:27Z","updated_at":"2016-12-09T00:28:27Z","html_url":"https://github.com/SmartSparrow/simcapi-js/pull/3#discussion_r91638089","pull_request_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/SmartSparrow/simcapi-js/pulls/comments/91638089"},"html":{"href":"https://github.com/SmartSparrow/simcapi-js/pull/3#discussion_r91638089"},"pull_request":{"href":"https://api.github.com/repos/SmartSparrow/simcapi-js/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/SmartSparrow/simcapi-js/pulls/3","id":96653037,"html_url":"https://github.com/SmartSparrow/simcapi-js/pull/3","diff_url":"https://github.com/SmartSparrow/simcapi-js/pull/3.diff","patch_url":"https://github.com/SmartSparrow/simcapi-js/pull/3.patch","issue_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/issues/3","number":3,"state":"open","locked":false,"title":"Client side sim to sim data syncing, queuing for getSetData","user":{"login":"lerice","id":4397215,"avatar_url":"https://avatars.githubusercontent.com/u/4397215?v=3","gravatar_id":"","url":"https://api.github.com/users/lerice","html_url":"https://github.com/lerice","followers_url":"https://api.github.com/users/lerice/followers","following_url":"https://api.github.com/users/lerice/following{/other_user}","gists_url":"https://api.github.com/users/lerice/gists{/gist_id}","starred_url":"https://api.github.com/users/lerice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lerice/subscriptions","organizations_url":"https://api.github.com/users/lerice/orgs","repos_url":"https://api.github.com/users/lerice/repos","events_url":"https://api.github.com/users/lerice/events{/privacy}","received_events_url":"https://api.github.com/users/lerice/received_events","type":"User","site_admin":false},"body":"* Allow sims to 'register' in the viewer for notifications of when a simId + key pair value changes\r\n* Additional 'options' parameter passed to `setDataRequest`, with expected `syncWithLocal: true` key to allow other registered sims (including itself) to be notified of the change. `options` will default to an empty object for all SimCapiMessages\r\n* Queuing behaviour for `getData` and `setData` requests, if a request is currently being made. Additional queued requests will overwrite the 'latest pending' request.\r\n* Remove try-catch block surrounding success/error callbacks on capi message receives to provide better error handling (BREAKING CHANGE)\r\n\r\nCode is ready for review, marked as WIP pending the latest 'control' message for initial config properties to be implemented","created_at":"2016-12-06T03:07:17Z","updated_at":"2016-12-09T00:28:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5f5ec04e4524f63aa7a7b216c663b23df76dd22","assignee":{"login":"jennifermckenzie","id":1262347,"avatar_url":"https://avatars.githubusercontent.com/u/1262347?v=3","gravatar_id":"","url":"https://api.github.com/users/jennifermckenzie","html_url":"https://github.com/jennifermckenzie","followers_url":"https://api.github.com/users/jennifermckenzie/followers","following_url":"https://api.github.com/users/jennifermckenzie/following{/other_user}","gists_url":"https://api.github.com/users/jennifermckenzie/gists{/gist_id}","starred_url":"https://api.github.com/users/jennifermckenzie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jennifermckenzie/subscriptions","organizations_url":"https://api.github.com/users/jennifermckenzie/orgs","repos_url":"https://api.github.com/users/jennifermckenzie/repos","events_url":"https://api.github.com/users/jennifermckenzie/events{/privacy}","received_events_url":"https://api.github.com/users/jennifermckenzie/received_events","type":"User","site_admin":false},"assignees":[{"login":"jennifermckenzie","id":1262347,"avatar_url":"https://avatars.githubusercontent.com/u/1262347?v=3","gravatar_id":"","url":"https://api.github.com/users/jennifermckenzie","html_url":"https://github.com/jennifermckenzie","followers_url":"https://api.github.com/users/jennifermckenzie/followers","following_url":"https://api.github.com/users/jennifermckenzie/following{/other_user}","gists_url":"https://api.github.com/users/jennifermckenzie/gists{/gist_id}","starred_url":"https://api.github.com/users/jennifermckenzie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jennifermckenzie/subscriptions","organizations_url":"https://api.github.com/users/jennifermckenzie/orgs","repos_url":"https://api.github.com/users/jennifermckenzie/repos","events_url":"https://api.github.com/users/jennifermckenzie/events{/privacy}","received_events_url":"https://api.github.com/users/jennifermckenzie/received_events","type":"User","site_admin":false},{"login":"benbarefield","id":2515890,"avatar_url":"https://avatars.githubusercontent.com/u/2515890?v=3","gravatar_id":"","url":"https://api.github.com/users/benbarefield","html_url":"https://github.com/benbarefield","followers_url":"https://api.github.com/users/benbarefield/followers","following_url":"https://api.github.com/users/benbarefield/following{/other_user}","gists_url":"https://api.github.com/users/benbarefield/gists{/gist_id}","starred_url":"https://api.github.com/users/benbarefield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbarefield/subscriptions","organizations_url":"https://api.github.com/users/benbarefield/orgs","repos_url":"https://api.github.com/users/benbarefield/repos","events_url":"https://api.github.com/users/benbarefield/events{/privacy}","received_events_url":"https://api.github.com/users/benbarefield/received_events","type":"User","site_admin":false},{"login":"eliasem","id":6036992,"avatar_url":"https://avatars.githubusercontent.com/u/6036992?v=3","gravatar_id":"","url":"https://api.github.com/users/eliasem","html_url":"https://github.com/eliasem","followers_url":"https://api.github.com/users/eliasem/followers","following_url":"https://api.github.com/users/eliasem/following{/other_user}","gists_url":"https://api.github.com/users/eliasem/gists{/gist_id}","starred_url":"https://api.github.com/users/eliasem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliasem/subscriptions","organizations_url":"https://api.github.com/users/eliasem/orgs","repos_url":"https://api.github.com/users/eliasem/repos","events_url":"https://api.github.com/users/eliasem/events{/privacy}","received_events_url":"https://api.github.com/users/eliasem/received_events","type":"User","site_admin":false},{"login":"kiahn-johnston","id":13057077,"avatar_url":"https://avatars.githubusercontent.com/u/13057077?v=3","gravatar_id":"","url":"https://api.github.com/users/kiahn-johnston","html_url":"https://github.com/kiahn-johnston","followers_url":"https://api.github.com/users/kiahn-johnston/followers","following_url":"https://api.github.com/users/kiahn-johnston/following{/other_user}","gists_url":"https://api.github.com/users/kiahn-johnston/gists{/gist_id}","starred_url":"https://api.github.com/users/kiahn-johnston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiahn-johnston/subscriptions","organizations_url":"https://api.github.com/users/kiahn-johnston/orgs","repos_url":"https://api.github.com/users/kiahn-johnston/repos","events_url":"https://api.github.com/users/kiahn-johnston/events{/privacy}","received_events_url":"https://api.github.com/users/kiahn-johnston/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/pulls/3/commits","review_comments_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/pulls/3/comments","review_comment_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/issues/3/comments","statuses_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/statuses/746cf1d7a618ca5775680a1a9114618a46ac80b8","head":{"label":"SmartSparrow:LDS-5778","ref":"LDS-5778","sha":"746cf1d7a618ca5775680a1a9114618a46ac80b8","user":{"login":"SmartSparrow","id":5109539,"avatar_url":"https://avatars.githubusercontent.com/u/5109539?v=3","gravatar_id":"","url":"https://api.github.com/users/SmartSparrow","html_url":"https://github.com/SmartSparrow","followers_url":"https://api.github.com/users/SmartSparrow/followers","following_url":"https://api.github.com/users/SmartSparrow/following{/other_user}","gists_url":"https://api.github.com/users/SmartSparrow/gists{/gist_id}","starred_url":"https://api.github.com/users/SmartSparrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmartSparrow/subscriptions","organizations_url":"https://api.github.com/users/SmartSparrow/orgs","repos_url":"https://api.github.com/users/SmartSparrow/repos","events_url":"https://api.github.com/users/SmartSparrow/events{/privacy}","received_events_url":"https://api.github.com/users/SmartSparrow/received_events","type":"Organization","site_admin":false},"repo":{"id":69424987,"name":"simcapi-js","full_name":"SmartSparrow/simcapi-js","owner":{"login":"SmartSparrow","id":5109539,"avatar_url":"https://avatars.githubusercontent.com/u/5109539?v=3","gravatar_id":"","url":"https://api.github.com/users/SmartSparrow","html_url":"https://github.com/SmartSparrow","followers_url":"https://api.github.com/users/SmartSparrow/followers","following_url":"https://api.github.com/users/SmartSparrow/following{/other_user}","gists_url":"https://api.github.com/users/SmartSparrow/gists{/gist_id}","starred_url":"https://api.github.com/users/SmartSparrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmartSparrow/subscriptions","organizations_url":"https://api.github.com/users/SmartSparrow/orgs","repos_url":"https://api.github.com/users/SmartSparrow/repos","events_url":"https://api.github.com/users/SmartSparrow/events{/privacy}","received_events_url":"https://api.github.com/users/SmartSparrow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SmartSparrow/simcapi-js","description":"Simulation Control API","fork":false,"url":"https://api.github.com/repos/SmartSparrow/simcapi-js","forks_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/forks","keys_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/teams","hooks_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/hooks","issue_events_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/issues/events{/number}","events_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/events","assignees_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/assignees{/user}","branches_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/branches{/branch}","tags_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/tags","blobs_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/statuses/{sha}","languages_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/languages","stargazers_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/stargazers","contributors_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/contributors","subscribers_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/subscribers","subscription_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/subscription","commits_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/contents/{+path}","compare_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/merges","archive_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/downloads","issues_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/issues{/number}","pulls_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/pulls{/number}","milestones_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/milestones{/number}","notifications_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/labels{/name}","releases_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/releases{/id}","deployments_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/deployments","created_at":"2016-09-28T04:18:06Z","updated_at":"2016-10-25T02:06:38Z","pushed_at":"2016-12-08T23:43:56Z","git_url":"git://github.com/SmartSparrow/simcapi-js.git","ssh_url":"git@github.com:SmartSparrow/simcapi-js.git","clone_url":"https://github.com/SmartSparrow/simcapi-js.git","svn_url":"https://github.com/SmartSparrow/simcapi-js","homepage":"https://www.smartsparrow.com/","size":9317,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"SmartSparrow:master","ref":"master","sha":"2343c58526ff540cffb16ccc6333ca910fb2e3a5","user":{"login":"SmartSparrow","id":5109539,"avatar_url":"https://avatars.githubusercontent.com/u/5109539?v=3","gravatar_id":"","url":"https://api.github.com/users/SmartSparrow","html_url":"https://github.com/SmartSparrow","followers_url":"https://api.github.com/users/SmartSparrow/followers","following_url":"https://api.github.com/users/SmartSparrow/following{/other_user}","gists_url":"https://api.github.com/users/SmartSparrow/gists{/gist_id}","starred_url":"https://api.github.com/users/SmartSparrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmartSparrow/subscriptions","organizations_url":"https://api.github.com/users/SmartSparrow/orgs","repos_url":"https://api.github.com/users/SmartSparrow/repos","events_url":"https://api.github.com/users/SmartSparrow/events{/privacy}","received_events_url":"https://api.github.com/users/SmartSparrow/received_events","type":"Organization","site_admin":false},"repo":{"id":69424987,"name":"simcapi-js","full_name":"SmartSparrow/simcapi-js","owner":{"login":"SmartSparrow","id":5109539,"avatar_url":"https://avatars.githubusercontent.com/u/5109539?v=3","gravatar_id":"","url":"https://api.github.com/users/SmartSparrow","html_url":"https://github.com/SmartSparrow","followers_url":"https://api.github.com/users/SmartSparrow/followers","following_url":"https://api.github.com/users/SmartSparrow/following{/other_user}","gists_url":"https://api.github.com/users/SmartSparrow/gists{/gist_id}","starred_url":"https://api.github.com/users/SmartSparrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmartSparrow/subscriptions","organizations_url":"https://api.github.com/users/SmartSparrow/orgs","repos_url":"https://api.github.com/users/SmartSparrow/repos","events_url":"https://api.github.com/users/SmartSparrow/events{/privacy}","received_events_url":"https://api.github.com/users/SmartSparrow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SmartSparrow/simcapi-js","description":"Simulation Control API","fork":false,"url":"https://api.github.com/repos/SmartSparrow/simcapi-js","forks_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/forks","keys_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/teams","hooks_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/hooks","issue_events_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/issues/events{/number}","events_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/events","assignees_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/assignees{/user}","branches_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/branches{/branch}","tags_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/tags","blobs_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/statuses/{sha}","languages_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/languages","stargazers_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/stargazers","contributors_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/contributors","subscribers_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/subscribers","subscription_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/subscription","commits_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/contents/{+path}","compare_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/merges","archive_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/downloads","issues_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/issues{/number}","pulls_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/pulls{/number}","milestones_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/milestones{/number}","notifications_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/labels{/name}","releases_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/releases{/id}","deployments_url":"https://api.github.com/repos/SmartSparrow/simcapi-js/deployments","created_at":"2016-09-28T04:18:06Z","updated_at":"2016-10-25T02:06:38Z","pushed_at":"2016-12-08T23:43:56Z","git_url":"git://github.com/SmartSparrow/simcapi-js.git","ssh_url":"git@github.com:SmartSparrow/simcapi-js.git","clone_url":"https://github.com/SmartSparrow/simcapi-js.git","svn_url":"https://github.com/SmartSparrow/simcapi-js","homepage":"https://www.smartsparrow.com/","size":9317,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SmartSparrow/simcapi-js/pulls/3"},"html":{"href":"https://github.com/SmartSparrow/simcapi-js/pull/3"},"issue":{"href":"https://api.github.com/repos/SmartSparrow/simcapi-js/issues/3"},"comments":{"href":"https://api.github.com/repos/SmartSparrow/simcapi-js/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/SmartSparrow/simcapi-js/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/SmartSparrow/simcapi-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SmartSparrow/simcapi-js/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/SmartSparrow/simcapi-js/statuses/746cf1d7a618ca5775680a1a9114618a46ac80b8"}}}}
{"actor":{"display_login":"kiahn-johnston"}}