{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/73623045","id":73623045,"diff_hunk":"@@ -700,7 +700,7 @@ impl<'blk, 'tcx> Drop for OwnedBuilder<'blk, 'tcx> {\n }\n \n pub struct BlockAndBuilder<'blk, 'tcx: 'blk> {\n-    bcx: Block<'blk, 'tcx>,\n+    pub bcx: Block<'blk, 'tcx>,","path":"src/librustc_trans/common.rs","position":5,"original_position":5,"commit_id":"c0ada182adac3d57644c7fe64ff3ba3d9b51dbdb","original_commit_id":"c0ada182adac3d57644c7fe64ff3ba3d9b51dbdb","user":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"body":"This should be done via the `with_bcx` method.","created_at":"2016-08-04T23:54:52Z","updated_at":"2016-08-04T23:54:52Z","html_url":"https://github.com/rust-lang/rust/pull/35348#discussion_r73623045","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/35348","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/73623045"},"html":{"href":"https://github.com/rust-lang/rust/pull/35348#discussion_r73623045"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/35348"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/35348","id":80168688,"html_url":"https://github.com/rust-lang/rust/pull/35348","diff_url":"https://github.com/rust-lang/rust/pull/35348.diff","patch_url":"https://github.com/rust-lang/rust/pull/35348.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/35348","number":35348,"state":"open","locked":false,"title":"[MIR] Add explicit SetDiscriminant StatementKind for deaggregating enums","user":{"login":"scottcarr","id":472477,"avatar_url":"https://avatars.githubusercontent.com/u/472477?v=3","gravatar_id":"","url":"https://api.github.com/users/scottcarr","html_url":"https://github.com/scottcarr","followers_url":"https://api.github.com/users/scottcarr/followers","following_url":"https://api.github.com/users/scottcarr/following{/other_user}","gists_url":"https://api.github.com/users/scottcarr/gists{/gist_id}","starred_url":"https://api.github.com/users/scottcarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottcarr/subscriptions","organizations_url":"https://api.github.com/users/scottcarr/orgs","repos_url":"https://api.github.com/users/scottcarr/repos","events_url":"https://api.github.com/users/scottcarr/events{/privacy}","received_events_url":"https://api.github.com/users/scottcarr/received_events","type":"User","site_admin":false},"body":"cc #35186\r\n\r\nTo deaggregate enums, we need to be able to explicitly set the discriminant.  This PR implements a new StatementKind that does that.  \r\n\r\nI think someone the places that have `panics!` now could maybe do something smarter.","created_at":"2016-08-04T23:52:41Z","updated_at":"2016-08-04T23:54:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a90a876af6725968bf473ccc6a6a3582e50eecfe","assignee":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/35348/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/35348/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/35348/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/c0ada182adac3d57644c7fe64ff3ba3d9b51dbdb","head":{"label":"scottcarr:discriminant2","ref":"discriminant2","sha":"c0ada182adac3d57644c7fe64ff3ba3d9b51dbdb","user":{"login":"scottcarr","id":472477,"avatar_url":"https://avatars.githubusercontent.com/u/472477?v=3","gravatar_id":"","url":"https://api.github.com/users/scottcarr","html_url":"https://github.com/scottcarr","followers_url":"https://api.github.com/users/scottcarr/followers","following_url":"https://api.github.com/users/scottcarr/following{/other_user}","gists_url":"https://api.github.com/users/scottcarr/gists{/gist_id}","starred_url":"https://api.github.com/users/scottcarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottcarr/subscriptions","organizations_url":"https://api.github.com/users/scottcarr/orgs","repos_url":"https://api.github.com/users/scottcarr/repos","events_url":"https://api.github.com/users/scottcarr/events{/privacy}","received_events_url":"https://api.github.com/users/scottcarr/received_events","type":"User","site_admin":false},"repo":{"id":60100914,"name":"rust","full_name":"scottcarr/rust","owner":{"login":"scottcarr","id":472477,"avatar_url":"https://avatars.githubusercontent.com/u/472477?v=3","gravatar_id":"","url":"https://api.github.com/users/scottcarr","html_url":"https://github.com/scottcarr","followers_url":"https://api.github.com/users/scottcarr/followers","following_url":"https://api.github.com/users/scottcarr/following{/other_user}","gists_url":"https://api.github.com/users/scottcarr/gists{/gist_id}","starred_url":"https://api.github.com/users/scottcarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottcarr/subscriptions","organizations_url":"https://api.github.com/users/scottcarr/orgs","repos_url":"https://api.github.com/users/scottcarr/repos","events_url":"https://api.github.com/users/scottcarr/events{/privacy}","received_events_url":"https://api.github.com/users/scottcarr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scottcarr/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/scottcarr/rust","forks_url":"https://api.github.com/repos/scottcarr/rust/forks","keys_url":"https://api.github.com/repos/scottcarr/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scottcarr/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scottcarr/rust/teams","hooks_url":"https://api.github.com/repos/scottcarr/rust/hooks","issue_events_url":"https://api.github.com/repos/scottcarr/rust/issues/events{/number}","events_url":"https://api.github.com/repos/scottcarr/rust/events","assignees_url":"https://api.github.com/repos/scottcarr/rust/assignees{/user}","branches_url":"https://api.github.com/repos/scottcarr/rust/branches{/branch}","tags_url":"https://api.github.com/repos/scottcarr/rust/tags","blobs_url":"https://api.github.com/repos/scottcarr/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scottcarr/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scottcarr/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/scottcarr/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scottcarr/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/scottcarr/rust/languages","stargazers_url":"https://api.github.com/repos/scottcarr/rust/stargazers","contributors_url":"https://api.github.com/repos/scottcarr/rust/contributors","subscribers_url":"https://api.github.com/repos/scottcarr/rust/subscribers","subscription_url":"https://api.github.com/repos/scottcarr/rust/subscription","commits_url":"https://api.github.com/repos/scottcarr/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/scottcarr/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/scottcarr/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/scottcarr/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/scottcarr/rust/contents/{+path}","compare_url":"https://api.github.com/repos/scottcarr/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scottcarr/rust/merges","archive_url":"https://api.github.com/repos/scottcarr/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scottcarr/rust/downloads","issues_url":"https://api.github.com/repos/scottcarr/rust/issues{/number}","pulls_url":"https://api.github.com/repos/scottcarr/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/scottcarr/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/scottcarr/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scottcarr/rust/labels{/name}","releases_url":"https://api.github.com/repos/scottcarr/rust/releases{/id}","deployments_url":"https://api.github.com/repos/scottcarr/rust/deployments","created_at":"2016-05-31T15:21:42Z","updated_at":"2016-05-31T15:22:00Z","pushed_at":"2016-08-04T23:54:11Z","git_url":"git://github.com/scottcarr/rust.git","ssh_url":"git@github.com:scottcarr/rust.git","clone_url":"https://github.com/scottcarr/rust.git","svn_url":"https://github.com/scottcarr/rust","homepage":"https://www.rust-lang.org","size":295682,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"545a3a94fcbdd68c4eeb60848c8eae2118c639c7","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2016-08-04T21:59:37Z","pushed_at":"2016-08-04T23:54:13Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":512971,"stargazers_count":17760,"watchers_count":17760,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3401,"mirror_url":null,"open_issues_count":2723,"forks":3401,"open_issues":2723,"watchers":17760,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/35348"},"html":{"href":"https://github.com/rust-lang/rust/pull/35348"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/35348"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/35348/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/35348/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/35348/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/c0ada182adac3d57644c7fe64ff3ba3d9b51dbdb"}}}}
{"actor":{"display_login":"eddyb"}}