{"action":"opened","number":636,"pull_request":{"url":"https://api.github.com/repos/FrDH/jQuery.mmenu/pulls/636","id":89015983,"html_url":"https://github.com/FrDH/jQuery.mmenu/pull/636","diff_url":"https://github.com/FrDH/jQuery.mmenu/pull/636.diff","patch_url":"https://github.com/FrDH/jQuery.mmenu/pull/636.patch","issue_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/issues/636","number":636,"state":"open","locked":false,"title":"Screen reader +++","user":{"login":"ffoodd","id":2890570,"avatar_url":"https://avatars.githubusercontent.com/u/2890570?v=3","gravatar_id":"","url":"https://api.github.com/users/ffoodd","html_url":"https://github.com/ffoodd","followers_url":"https://api.github.com/users/ffoodd/followers","following_url":"https://api.github.com/users/ffoodd/following{/other_user}","gists_url":"https://api.github.com/users/ffoodd/gists{/gist_id}","starred_url":"https://api.github.com/users/ffoodd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ffoodd/subscriptions","organizations_url":"https://api.github.com/users/ffoodd/orgs","repos_url":"https://api.github.com/users/ffoodd/repos","events_url":"https://api.github.com/users/ffoodd/events{/privacy}","received_events_url":"https://api.github.com/users/ffoodd/received_events","type":"User","site_admin":false},"body":"I first resetted my fork to match the original repo, so this PRs only changes the screenReader add-on.\r\n\r\nTo be accurate:\r\n* first things first, any tag may have `aria-hidden` without being in `display: none`: that's our case here, since the visible text (in `<span>`) should not be read aloud by screen readers;\r\n* instead, we'll \"copy\" its text **inside** the anchor (which allows it to expose an accessible name to assistive technologies such as screen readers) and wrap it inside another `<span>` with the `.mm-sronly` class: it'll be read aloud by screen readers as an anchor link, but won't trouble the visual appearance of the existing menu.\r\n\r\nThis way, the DOM and look doesn't break (nothing to change in the core's CSS nor JS), anchors are now fully accessible thanks to their accessible name, and everyone got the exactly same text for anchors.\r\n\r\nI hope I'm clear enough, please ask me anything if not.\r\n\r\nAs a complement, please take a look at [WCAG criterion about accessible names, roles and values](https://www.w3.org/TR/UNDERSTANDING-WCAG20/ensure-compat-rsv.html). This might be clearer than I am.\r\n\r\nI also improved the `.mm-sronly` class with [Yahoo!'s way](https://developer.yahoo.com/blogs/ydn/clip-hidden-content-better-accessibility-53456.html), and a small fix from me. It ensures that visually hidden things won't ever appear, even in RTL mode or when `clip` would be unsupported.\r\n\r\nI hope it helped, and many thanks for reviewing this!\r\n\r\n","created_at":"2016-10-12T13:29:45Z","updated_at":"2016-10-12T13:29:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06434a89bf6d38962647b0a2a30f799063ecf595","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/pulls/636/commits","review_comments_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/pulls/636/comments","review_comment_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/issues/636/comments","statuses_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/statuses/d0376b0665bbacf5c1875e70234b40c845579b1f","head":{"label":"ffoodd:screenReader+++","ref":"screenReader+++","sha":"d0376b0665bbacf5c1875e70234b40c845579b1f","user":{"login":"ffoodd","id":2890570,"avatar_url":"https://avatars.githubusercontent.com/u/2890570?v=3","gravatar_id":"","url":"https://api.github.com/users/ffoodd","html_url":"https://github.com/ffoodd","followers_url":"https://api.github.com/users/ffoodd/followers","following_url":"https://api.github.com/users/ffoodd/following{/other_user}","gists_url":"https://api.github.com/users/ffoodd/gists{/gist_id}","starred_url":"https://api.github.com/users/ffoodd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ffoodd/subscriptions","organizations_url":"https://api.github.com/users/ffoodd/orgs","repos_url":"https://api.github.com/users/ffoodd/repos","events_url":"https://api.github.com/users/ffoodd/events{/privacy}","received_events_url":"https://api.github.com/users/ffoodd/received_events","type":"User","site_admin":false},"repo":{"id":70601957,"name":"jQuery.mmenu","full_name":"ffoodd/jQuery.mmenu","owner":{"login":"ffoodd","id":2890570,"avatar_url":"https://avatars.githubusercontent.com/u/2890570?v=3","gravatar_id":"","url":"https://api.github.com/users/ffoodd","html_url":"https://github.com/ffoodd","followers_url":"https://api.github.com/users/ffoodd/followers","following_url":"https://api.github.com/users/ffoodd/following{/other_user}","gists_url":"https://api.github.com/users/ffoodd/gists{/gist_id}","starred_url":"https://api.github.com/users/ffoodd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ffoodd/subscriptions","organizations_url":"https://api.github.com/users/ffoodd/orgs","repos_url":"https://api.github.com/users/ffoodd/repos","events_url":"https://api.github.com/users/ffoodd/events{/privacy}","received_events_url":"https://api.github.com/users/ffoodd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ffoodd/jQuery.mmenu","description":"Trying to get this plugin more accessible. WIP.","fork":true,"url":"https://api.github.com/repos/ffoodd/jQuery.mmenu","forks_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/forks","keys_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/teams","hooks_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/hooks","issue_events_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/issues/events{/number}","events_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/events","assignees_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/assignees{/user}","branches_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/branches{/branch}","tags_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/tags","blobs_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/git/refs{/sha}","trees_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/statuses/{sha}","languages_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/languages","stargazers_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/stargazers","contributors_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/contributors","subscribers_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/subscribers","subscription_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/subscription","commits_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/commits{/sha}","git_commits_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/git/commits{/sha}","comments_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/comments{/number}","issue_comment_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/issues/comments{/number}","contents_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/contents/{+path}","compare_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/merges","archive_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/downloads","issues_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/issues{/number}","pulls_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/pulls{/number}","milestones_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/milestones{/number}","notifications_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/labels{/name}","releases_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/releases{/id}","deployments_url":"https://api.github.com/repos/ffoodd/jQuery.mmenu/deployments","created_at":"2016-10-11T14:28:26Z","updated_at":"2016-10-11T14:51:27Z","pushed_at":"2016-10-12T13:12:40Z","git_url":"git://github.com/ffoodd/jQuery.mmenu.git","ssh_url":"git@github.com:ffoodd/jQuery.mmenu.git","clone_url":"https://github.com/ffoodd/jQuery.mmenu.git","svn_url":"https://github.com/ffoodd/jQuery.mmenu","homepage":"","size":1558,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FrDH:master","ref":"master","sha":"e12d92e83100913a4d74751a083d23730b7647ed","user":{"login":"FrDH","id":1387163,"avatar_url":"https://avatars.githubusercontent.com/u/1387163?v=3","gravatar_id":"","url":"https://api.github.com/users/FrDH","html_url":"https://github.com/FrDH","followers_url":"https://api.github.com/users/FrDH/followers","following_url":"https://api.github.com/users/FrDH/following{/other_user}","gists_url":"https://api.github.com/users/FrDH/gists{/gist_id}","starred_url":"https://api.github.com/users/FrDH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrDH/subscriptions","organizations_url":"https://api.github.com/users/FrDH/orgs","repos_url":"https://api.github.com/users/FrDH/repos","events_url":"https://api.github.com/users/FrDH/events{/privacy}","received_events_url":"https://api.github.com/users/FrDH/received_events","type":"User","site_admin":false},"repo":{"id":13765233,"name":"jQuery.mmenu","full_name":"FrDH/jQuery.mmenu","owner":{"login":"FrDH","id":1387163,"avatar_url":"https://avatars.githubusercontent.com/u/1387163?v=3","gravatar_id":"","url":"https://api.github.com/users/FrDH","html_url":"https://github.com/FrDH","followers_url":"https://api.github.com/users/FrDH/followers","following_url":"https://api.github.com/users/FrDH/following{/other_user}","gists_url":"https://api.github.com/users/FrDH/gists{/gist_id}","starred_url":"https://api.github.com/users/FrDH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrDH/subscriptions","organizations_url":"https://api.github.com/users/FrDH/orgs","repos_url":"https://api.github.com/users/FrDH/repos","events_url":"https://api.github.com/users/FrDH/events{/privacy}","received_events_url":"https://api.github.com/users/FrDH/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FrDH/jQuery.mmenu","description":"The best jQuery plugin for app look-alike on- and off-canvas menus with sliding submenus for your website and webapp.","fork":false,"url":"https://api.github.com/repos/FrDH/jQuery.mmenu","forks_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/forks","keys_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/teams","hooks_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/hooks","issue_events_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/issues/events{/number}","events_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/events","assignees_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/assignees{/user}","branches_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/branches{/branch}","tags_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/tags","blobs_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/git/refs{/sha}","trees_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/statuses/{sha}","languages_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/languages","stargazers_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/stargazers","contributors_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/contributors","subscribers_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/subscribers","subscription_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/subscription","commits_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/commits{/sha}","git_commits_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/git/commits{/sha}","comments_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/comments{/number}","issue_comment_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/issues/comments{/number}","contents_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/contents/{+path}","compare_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/merges","archive_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/downloads","issues_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/issues{/number}","pulls_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/pulls{/number}","milestones_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/milestones{/number}","notifications_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/labels{/name}","releases_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/releases{/id}","deployments_url":"https://api.github.com/repos/FrDH/jQuery.mmenu/deployments","created_at":"2013-10-22T06:49:48Z","updated_at":"2016-10-12T08:47:10Z","pushed_at":"2016-10-12T13:29:45Z","git_url":"git://github.com/FrDH/jQuery.mmenu.git","ssh_url":"git@github.com:FrDH/jQuery.mmenu.git","clone_url":"https://github.com/FrDH/jQuery.mmenu.git","svn_url":"https://github.com/FrDH/jQuery.mmenu","homepage":"http://mmenu.frebsite.nl/","size":1725,"stargazers_count":1816,"watchers_count":1816,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":468,"mirror_url":null,"open_issues_count":11,"forks":468,"open_issues":11,"watchers":1816,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FrDH/jQuery.mmenu/pulls/636"},"html":{"href":"https://github.com/FrDH/jQuery.mmenu/pull/636"},"issue":{"href":"https://api.github.com/repos/FrDH/jQuery.mmenu/issues/636"},"comments":{"href":"https://api.github.com/repos/FrDH/jQuery.mmenu/issues/636/comments"},"review_comments":{"href":"https://api.github.com/repos/FrDH/jQuery.mmenu/pulls/636/comments"},"review_comment":{"href":"https://api.github.com/repos/FrDH/jQuery.mmenu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FrDH/jQuery.mmenu/pulls/636/commits"},"statuses":{"href":"https://api.github.com/repos/FrDH/jQuery.mmenu/statuses/d0376b0665bbacf5c1875e70234b40c845579b1f"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":28,"deletions":11,"changed_files":2}}
{"actor":{"display_login":"ffoodd"}}