{"action":"created","issue":{"url":"https://api.github.com/repos/dakrone/lein-bikeshed/issues/30","repository_url":"https://api.github.com/repos/dakrone/lein-bikeshed","labels_url":"https://api.github.com/repos/dakrone/lein-bikeshed/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/dakrone/lein-bikeshed/issues/30/comments","events_url":"https://api.github.com/repos/dakrone/lein-bikeshed/issues/30/events","html_url":"https://github.com/dakrone/lein-bikeshed/issues/30","id":189463106,"number":30,"title":"Line length and ending blank line checks no longer work in 0.4.0","user":{"login":"robert914","id":214286,"avatar_url":"https://avatars.githubusercontent.com/u/214286?v=3","gravatar_id":"","url":"https://api.github.com/users/robert914","html_url":"https://github.com/robert914","followers_url":"https://api.github.com/users/robert914/followers","following_url":"https://api.github.com/users/robert914/following{/other_user}","gists_url":"https://api.github.com/users/robert914/gists{/gist_id}","starred_url":"https://api.github.com/users/robert914/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robert914/subscriptions","organizations_url":"https://api.github.com/users/robert914/orgs","repos_url":"https://api.github.com/users/robert914/repos","events_url":"https://api.github.com/users/robert914/events{/privacy}","received_events_url":"https://api.github.com/users/robert914/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2016-11-15T18:00:07Z","updated_at":"2016-11-17T22:48:48Z","closed_at":null,"body":"After updating my project from 0.3.0 of Bikeshed to 0.4.0, it no longer seems to correctly check the line length rules (80 char default) and the EOF blank line check.\r\n\r\nSample output from 0.3.0:\r\n```\r\nChecking for lines longer than 80 characters.\r\nBadly formatted files:\r\n/Users/robert/Downloads/hellworld/src/hellworld/core.clj:7:  (println \"This line is too long and should fail 80 character limit but no longer does in 0.4.0 of Bikeshed\")\r\n\r\nChecking for lines with trailing whitespace.\r\nNo lines found.\r\n\r\nChecking for files ending in blank lines.\r\nBadly formatted files:\r\n/Users/robert/Downloads/hellworld/src/hellworld/core.clj\r\n\r\nChecking for redefined var roots in source directories.\r\nNo with-redefs found.\r\n\r\nChecking whether you keep up with your docstrings.\r\n0/1 [0.00%] namespaces have docstrings.\r\n1/1 [100.00%] functions have docstrings.\r\nUse -v to list namespaces/functions without docstrings\r\n\r\nChecking for arguments colliding with clojure.core functions.\r\nSubprocess failed\r\n```\r\n\r\nSample output on same project in 0.4.0:\r\n\r\n```\r\nChecking for lines longer than 80 characters.\r\nNo lines found.\r\n\r\nChecking for lines with trailing whitespace.\r\nNo lines found.\r\n\r\nChecking for files ending in blank lines.\r\nNo files found.\r\n\r\nChecking for redefined var roots in source directories.\r\nNo with-redefs found.\r\n\r\nChecking whether you keep up with your docstrings.\r\n0/1 [0.00%] namespaces have docstrings.\r\n1/1 [100.00%] functions have docstrings.\r\nUse -v to list namespaces/functions without docstrings\r\n\r\nChecking for arguments colliding with clojure.core functions.\r\n```\r\n\r\nTo reproduce, all you need to do is:\r\n\r\n```\r\nlein new app helloworld\r\n# edit src/helloworld/core.clj\r\n# add this line:\r\n  (println \"This line is too long and should fail 80 character limit but no longer does in 0.4.0 of Bikeshed\")\r\n# add a blank line to the end of the file\r\n```\r\n\r\nPlease look into this, thanks!"},"comment":{"url":"https://api.github.com/repos/dakrone/lein-bikeshed/issues/comments/261394820","html_url":"https://github.com/dakrone/lein-bikeshed/issues/30#issuecomment-261394820","issue_url":"https://api.github.com/repos/dakrone/lein-bikeshed/issues/30","id":261394820,"user":{"login":"robert914","id":214286,"avatar_url":"https://avatars.githubusercontent.com/u/214286?v=3","gravatar_id":"","url":"https://api.github.com/users/robert914","html_url":"https://github.com/robert914","followers_url":"https://api.github.com/users/robert914/followers","following_url":"https://api.github.com/users/robert914/following{/other_user}","gists_url":"https://api.github.com/users/robert914/gists{/gist_id}","starred_url":"https://api.github.com/users/robert914/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robert914/subscriptions","organizations_url":"https://api.github.com/users/robert914/orgs","repos_url":"https://api.github.com/users/robert914/repos","events_url":"https://api.github.com/users/robert914/events{/privacy}","received_events_url":"https://api.github.com/users/robert914/received_events","type":"User","site_admin":false},"created_at":"2016-11-17T22:48:48Z","updated_at":"2016-11-17T22:48:48Z","body":"Or, if you use the \"-E\" to use extended regex in BSD find:\r\n\r\n```\r\n$ bash -c \"/usr/bin/find -E src -regex '.*\\\\.clj[scx]?' | xargs egrep -H -n '^.{80,}$'\"\r\nsrc/hellworld/core.clj:7:  (println \"This line is too long and should fail 80 character limit but no longer does in 0.4.0 of Bikeshed\")\r\n```"}}
{"actor":{"display_login":"robert914"}}