{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/nodejstools/issues/1186","repository_url":"https://api.github.com/repos/Microsoft/nodejstools","labels_url":"https://api.github.com/repos/Microsoft/nodejstools/issues/1186/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/nodejstools/issues/1186/comments","events_url":"https://api.github.com/repos/Microsoft/nodejstools/issues/1186/events","html_url":"https://github.com/Microsoft/nodejstools/issues/1186","id":168538977,"number":1186,"title":"Typings should have optional source control / project integration","user":{"login":"benquarmby","id":1434816,"avatar_url":"https://avatars.githubusercontent.com/u/1434816?v=3","gravatar_id":"","url":"https://api.github.com/users/benquarmby","html_url":"https://github.com/benquarmby","followers_url":"https://api.github.com/users/benquarmby/followers","following_url":"https://api.github.com/users/benquarmby/following{/other_user}","gists_url":"https://api.github.com/users/benquarmby/gists{/gist_id}","starred_url":"https://api.github.com/users/benquarmby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benquarmby/subscriptions","organizations_url":"https://api.github.com/users/benquarmby/orgs","repos_url":"https://api.github.com/users/benquarmby/repos","events_url":"https://api.github.com/users/benquarmby/events{/privacy}","received_events_url":"https://api.github.com/users/benquarmby/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-31T21:21:47Z","updated_at":"2016-08-04T17:19:08Z","closed_at":"2016-08-04T17:19:08Z","body":"Like many teams, we exclude the NPM `node_modules` directory (and Bower `bower_components` and NuGet `packages`) from source control. Currently the contents of the NTVS `typings` directory are added to the `.njsproj` project file and source control by default (excluding `typings.json` files for some reason).\r\n\r\nIt would be great if the NTVS `typings` directory integration with source control and projects could be made optional. For us it would be ideal if it were treated as an invisible, transient folder that can be rebuilt just-in-time, and only for those folks who use NTVS.\r\n\r\nP.S. Adding `typings/` to a dot-ignore file will omit the files from source control, but keep the empty project nodes which is in many ways worse."},"comment":{"url":"https://api.github.com/repos/Microsoft/nodejstools/issues/comments/237621217","html_url":"https://github.com/Microsoft/nodejstools/issues/1186#issuecomment-237621217","issue_url":"https://api.github.com/repos/Microsoft/nodejstools/issues/1186","id":237621217,"user":{"login":"mjbvz","id":12821956,"avatar_url":"https://avatars.githubusercontent.com/u/12821956?v=3","gravatar_id":"","url":"https://api.github.com/users/mjbvz","html_url":"https://github.com/mjbvz","followers_url":"https://api.github.com/users/mjbvz/followers","following_url":"https://api.github.com/users/mjbvz/following{/other_user}","gists_url":"https://api.github.com/users/mjbvz/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbvz/subscriptions","organizations_url":"https://api.github.com/users/mjbvz/orgs","repos_url":"https://api.github.com/users/mjbvz/repos","events_url":"https://api.github.com/users/mjbvz/events{/privacy}","received_events_url":"https://api.github.com/users/mjbvz/received_events","type":"User","site_admin":false},"created_at":"2016-08-04T17:19:08Z","updated_at":"2016-08-04T17:19:08Z","body":"Thanks for the suggestion.\r\n\r\nAutomatic typings acquisition is a short-term workaround to enable better intellisense in VS2015. We plan on getting out of the typings management business altogether with VS15 (or rather, all the typings logic will be handled transparently, behind the scenes by the Typescript team, much like the ideal solution you suggest).\r\n\r\nExcluding the typings directories from source control would be great for most cases, but this is not something we want to handle in code. There are simply too many edge cases to consider, and a very real risk that any cleverness around source control could end up annoying users even more than adding the extra typings files in the first place.\r\n\r\nMy current suggestion: add the `typings` directory to the `.gitignore` for regular JavaScript projects, don't worry about the proj file changes, and ensure all VS users on your team are on NTVS 1.2+. This way, developers who are not using visual studio don't end up with the extra typings files and you don't have to worry about managing the typings files with source control. Developers using VS would initially see the typings files missing from their solution, but with NTVS 1.2+, these will be recreated shortly after the project loads\r\n\r\nNot great, but this allows us to bring a modern intellisense experience to users on VS2015. We are working on making this better with VS15, and you can try this out with one of our [VS15 NTVS dev builds](https://github.com/Microsoft/nodejstools/releases/tag/v1.2.Dev-7.24.2016)."}}
{"actor":{"display_login":"mjbvz"}}