{"action":"created","comment":{"url":"https://api.github.com/repos/zulip/zulip/pulls/comments/65786077","id":65786077,"diff_hunk":"@@ -101,14 +111,17 @@ def check_variable_type(allowed_type_funcs):\n     types for this variable.\n     \"\"\"\n     def enumerated_type_check(var_name, val):\n+","path":"zerver/lib/validator.py","position":68,"original_position":68,"commit_id":"1ce0bd56b329a95f48682d0caecb7523c603083a","original_commit_id":"b2dee0a88956af0c4abfc3eca65b3ccdd72c2b71","user":{"login":"timabbott","id":2746074,"avatar_url":"https://avatars.githubusercontent.com/u/2746074?v=3","gravatar_id":"","url":"https://api.github.com/users/timabbott","html_url":"https://github.com/timabbott","followers_url":"https://api.github.com/users/timabbott/followers","following_url":"https://api.github.com/users/timabbott/following{/other_user}","gists_url":"https://api.github.com/users/timabbott/gists{/gist_id}","starred_url":"https://api.github.com/users/timabbott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timabbott/subscriptions","organizations_url":"https://api.github.com/users/timabbott/orgs","repos_url":"https://api.github.com/users/timabbott/repos","events_url":"https://api.github.com/users/timabbott/events{/privacy}","received_events_url":"https://api.github.com/users/timabbott/received_events","type":"User","site_admin":false},"body":"can you delete this added newline?","created_at":"2016-06-03T22:41:35Z","updated_at":"2016-06-03T22:41:35Z","html_url":"https://github.com/zulip/zulip/pull/893#discussion_r65786077","pull_request_url":"https://api.github.com/repos/zulip/zulip/pulls/893","_links":{"self":{"href":"https://api.github.com/repos/zulip/zulip/pulls/comments/65786077"},"html":{"href":"https://github.com/zulip/zulip/pull/893#discussion_r65786077"},"pull_request":{"href":"https://api.github.com/repos/zulip/zulip/pulls/893"}}},"pull_request":{"url":"https://api.github.com/repos/zulip/zulip/pulls/893","id":72577056,"html_url":"https://github.com/zulip/zulip/pull/893","diff_url":"https://github.com/zulip/zulip/pull/893.diff","patch_url":"https://github.com/zulip/zulip/pull/893.patch","issue_url":"https://api.github.com/repos/zulip/zulip/issues/893","number":893,"state":"open","locked":false,"title":"Add type annotations to zerver/lib/validator and zerver/lib/rest","user":{"login":"neruson","id":1280949,"avatar_url":"https://avatars.githubusercontent.com/u/1280949?v=3","gravatar_id":"","url":"https://api.github.com/users/neruson","html_url":"https://github.com/neruson","followers_url":"https://api.github.com/users/neruson/followers","following_url":"https://api.github.com/users/neruson/following{/other_user}","gists_url":"https://api.github.com/users/neruson/gists{/gist_id}","starred_url":"https://api.github.com/users/neruson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neruson/subscriptions","organizations_url":"https://api.github.com/users/neruson/orgs","repos_url":"https://api.github.com/users/neruson/repos","events_url":"https://api.github.com/users/neruson/events{/privacy}","received_events_url":"https://api.github.com/users/neruson/received_events","type":"User","site_admin":false},"body":"Adding type annotations for two more files.\r\n\r\nThere are a few changes that aren't type annotations. For `check_dict`, there was code calling it with lists despite a comment saying to pass in tuples. I made the type annotation match the comment, and changed the code to match the annotation.","created_at":"2016-06-03T22:10:11Z","updated_at":"2016-06-03T22:41:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b3efa672732afad9d293406a93c0094379097ae","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zulip/zulip/pulls/893/commits","review_comments_url":"https://api.github.com/repos/zulip/zulip/pulls/893/comments","review_comment_url":"https://api.github.com/repos/zulip/zulip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zulip/zulip/issues/893/comments","statuses_url":"https://api.github.com/repos/zulip/zulip/statuses/1ce0bd56b329a95f48682d0caecb7523c603083a","head":{"label":"neruson:mypy_validator_rest","ref":"mypy_validator_rest","sha":"1ce0bd56b329a95f48682d0caecb7523c603083a","user":{"login":"neruson","id":1280949,"avatar_url":"https://avatars.githubusercontent.com/u/1280949?v=3","gravatar_id":"","url":"https://api.github.com/users/neruson","html_url":"https://github.com/neruson","followers_url":"https://api.github.com/users/neruson/followers","following_url":"https://api.github.com/users/neruson/following{/other_user}","gists_url":"https://api.github.com/users/neruson/gists{/gist_id}","starred_url":"https://api.github.com/users/neruson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neruson/subscriptions","organizations_url":"https://api.github.com/users/neruson/orgs","repos_url":"https://api.github.com/users/neruson/repos","events_url":"https://api.github.com/users/neruson/events{/privacy}","received_events_url":"https://api.github.com/users/neruson/received_events","type":"User","site_admin":false},"repo":{"id":60233194,"name":"zulip","full_name":"neruson/zulip","owner":{"login":"neruson","id":1280949,"avatar_url":"https://avatars.githubusercontent.com/u/1280949?v=3","gravatar_id":"","url":"https://api.github.com/users/neruson","html_url":"https://github.com/neruson","followers_url":"https://api.github.com/users/neruson/followers","following_url":"https://api.github.com/users/neruson/following{/other_user}","gists_url":"https://api.github.com/users/neruson/gists{/gist_id}","starred_url":"https://api.github.com/users/neruson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neruson/subscriptions","organizations_url":"https://api.github.com/users/neruson/orgs","repos_url":"https://api.github.com/users/neruson/repos","events_url":"https://api.github.com/users/neruson/events{/privacy}","received_events_url":"https://api.github.com/users/neruson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/neruson/zulip","description":"Zulip server - powerful open source group chat","fork":true,"url":"https://api.github.com/repos/neruson/zulip","forks_url":"https://api.github.com/repos/neruson/zulip/forks","keys_url":"https://api.github.com/repos/neruson/zulip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neruson/zulip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neruson/zulip/teams","hooks_url":"https://api.github.com/repos/neruson/zulip/hooks","issue_events_url":"https://api.github.com/repos/neruson/zulip/issues/events{/number}","events_url":"https://api.github.com/repos/neruson/zulip/events","assignees_url":"https://api.github.com/repos/neruson/zulip/assignees{/user}","branches_url":"https://api.github.com/repos/neruson/zulip/branches{/branch}","tags_url":"https://api.github.com/repos/neruson/zulip/tags","blobs_url":"https://api.github.com/repos/neruson/zulip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neruson/zulip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neruson/zulip/git/refs{/sha}","trees_url":"https://api.github.com/repos/neruson/zulip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neruson/zulip/statuses/{sha}","languages_url":"https://api.github.com/repos/neruson/zulip/languages","stargazers_url":"https://api.github.com/repos/neruson/zulip/stargazers","contributors_url":"https://api.github.com/repos/neruson/zulip/contributors","subscribers_url":"https://api.github.com/repos/neruson/zulip/subscribers","subscription_url":"https://api.github.com/repos/neruson/zulip/subscription","commits_url":"https://api.github.com/repos/neruson/zulip/commits{/sha}","git_commits_url":"https://api.github.com/repos/neruson/zulip/git/commits{/sha}","comments_url":"https://api.github.com/repos/neruson/zulip/comments{/number}","issue_comment_url":"https://api.github.com/repos/neruson/zulip/issues/comments{/number}","contents_url":"https://api.github.com/repos/neruson/zulip/contents/{+path}","compare_url":"https://api.github.com/repos/neruson/zulip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neruson/zulip/merges","archive_url":"https://api.github.com/repos/neruson/zulip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neruson/zulip/downloads","issues_url":"https://api.github.com/repos/neruson/zulip/issues{/number}","pulls_url":"https://api.github.com/repos/neruson/zulip/pulls{/number}","milestones_url":"https://api.github.com/repos/neruson/zulip/milestones{/number}","notifications_url":"https://api.github.com/repos/neruson/zulip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neruson/zulip/labels{/name}","releases_url":"https://api.github.com/repos/neruson/zulip/releases{/id}","deployments_url":"https://api.github.com/repos/neruson/zulip/deployments","created_at":"2016-06-02T04:42:39Z","updated_at":"2016-06-02T04:42:47Z","pushed_at":"2016-06-03T22:00:14Z","git_url":"git://github.com/neruson/zulip.git","ssh_url":"git@github.com:neruson/zulip.git","clone_url":"https://github.com/neruson/zulip.git","svn_url":"https://github.com/neruson/zulip","homepage":"","size":108536,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zulip:master","ref":"master","sha":"8c2382deeb3b089d38f148265d0576c50ce81c73","user":{"login":"zulip","id":4921959,"avatar_url":"https://avatars.githubusercontent.com/u/4921959?v=3","gravatar_id":"","url":"https://api.github.com/users/zulip","html_url":"https://github.com/zulip","followers_url":"https://api.github.com/users/zulip/followers","following_url":"https://api.github.com/users/zulip/following{/other_user}","gists_url":"https://api.github.com/users/zulip/gists{/gist_id}","starred_url":"https://api.github.com/users/zulip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulip/subscriptions","organizations_url":"https://api.github.com/users/zulip/orgs","repos_url":"https://api.github.com/users/zulip/repos","events_url":"https://api.github.com/users/zulip/events{/privacy}","received_events_url":"https://api.github.com/users/zulip/received_events","type":"Organization","site_admin":false},"repo":{"id":43160685,"name":"zulip","full_name":"zulip/zulip","owner":{"login":"zulip","id":4921959,"avatar_url":"https://avatars.githubusercontent.com/u/4921959?v=3","gravatar_id":"","url":"https://api.github.com/users/zulip","html_url":"https://github.com/zulip","followers_url":"https://api.github.com/users/zulip/followers","following_url":"https://api.github.com/users/zulip/following{/other_user}","gists_url":"https://api.github.com/users/zulip/gists{/gist_id}","starred_url":"https://api.github.com/users/zulip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulip/subscriptions","organizations_url":"https://api.github.com/users/zulip/orgs","repos_url":"https://api.github.com/users/zulip/repos","events_url":"https://api.github.com/users/zulip/events{/privacy}","received_events_url":"https://api.github.com/users/zulip/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zulip/zulip","description":"Zulip server - powerful open source group chat","fork":false,"url":"https://api.github.com/repos/zulip/zulip","forks_url":"https://api.github.com/repos/zulip/zulip/forks","keys_url":"https://api.github.com/repos/zulip/zulip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zulip/zulip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zulip/zulip/teams","hooks_url":"https://api.github.com/repos/zulip/zulip/hooks","issue_events_url":"https://api.github.com/repos/zulip/zulip/issues/events{/number}","events_url":"https://api.github.com/repos/zulip/zulip/events","assignees_url":"https://api.github.com/repos/zulip/zulip/assignees{/user}","branches_url":"https://api.github.com/repos/zulip/zulip/branches{/branch}","tags_url":"https://api.github.com/repos/zulip/zulip/tags","blobs_url":"https://api.github.com/repos/zulip/zulip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zulip/zulip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zulip/zulip/git/refs{/sha}","trees_url":"https://api.github.com/repos/zulip/zulip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zulip/zulip/statuses/{sha}","languages_url":"https://api.github.com/repos/zulip/zulip/languages","stargazers_url":"https://api.github.com/repos/zulip/zulip/stargazers","contributors_url":"https://api.github.com/repos/zulip/zulip/contributors","subscribers_url":"https://api.github.com/repos/zulip/zulip/subscribers","subscription_url":"https://api.github.com/repos/zulip/zulip/subscription","commits_url":"https://api.github.com/repos/zulip/zulip/commits{/sha}","git_commits_url":"https://api.github.com/repos/zulip/zulip/git/commits{/sha}","comments_url":"https://api.github.com/repos/zulip/zulip/comments{/number}","issue_comment_url":"https://api.github.com/repos/zulip/zulip/issues/comments{/number}","contents_url":"https://api.github.com/repos/zulip/zulip/contents/{+path}","compare_url":"https://api.github.com/repos/zulip/zulip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zulip/zulip/merges","archive_url":"https://api.github.com/repos/zulip/zulip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zulip/zulip/downloads","issues_url":"https://api.github.com/repos/zulip/zulip/issues{/number}","pulls_url":"https://api.github.com/repos/zulip/zulip/pulls{/number}","milestones_url":"https://api.github.com/repos/zulip/zulip/milestones{/number}","notifications_url":"https://api.github.com/repos/zulip/zulip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zulip/zulip/labels{/name}","releases_url":"https://api.github.com/repos/zulip/zulip/releases{/id}","deployments_url":"https://api.github.com/repos/zulip/zulip/deployments","created_at":"2015-09-25T16:37:25Z","updated_at":"2016-06-03T16:14:13Z","pushed_at":"2016-06-03T22:36:59Z","git_url":"git://github.com/zulip/zulip.git","ssh_url":"git@github.com:zulip/zulip.git","clone_url":"https://github.com/zulip/zulip.git","svn_url":"https://github.com/zulip/zulip","homepage":"","size":116821,"stargazers_count":3876,"watchers_count":3876,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":572,"mirror_url":null,"open_issues_count":318,"forks":572,"open_issues":318,"watchers":3876,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zulip/zulip/pulls/893"},"html":{"href":"https://github.com/zulip/zulip/pull/893"},"issue":{"href":"https://api.github.com/repos/zulip/zulip/issues/893"},"comments":{"href":"https://api.github.com/repos/zulip/zulip/issues/893/comments"},"review_comments":{"href":"https://api.github.com/repos/zulip/zulip/pulls/893/comments"},"review_comment":{"href":"https://api.github.com/repos/zulip/zulip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zulip/zulip/pulls/893/commits"},"statuses":{"href":"https://api.github.com/repos/zulip/zulip/statuses/1ce0bd56b329a95f48682d0caecb7523c603083a"}}}}
{"actor":{"display_login":"timabbott"}}