{"action":"created","comment":{"url":"https://api.github.com/repos/TNG/JGiven/pulls/comments/93740645","pull_request_review_id":14274240,"id":93740645,"diff_hunk":"@@ -42,57 +43,65 @@ public void validateFields( Object object ) {\n \n         Map<Object, Field> resolvedFields = Maps.newHashMap();\n \n-        for( Field field : getScenarioFields( object ) ) {\n-            field.setAccessible( true );\n-            Resolution resolution = getResolution( field );\n+        for( ScenarioStateField field : getScenarioFields( object ) ) {","path":"jgiven-core/src/main/java/com/tngtech/jgiven/impl/inject/ValueInjector.java","position":31,"original_position":31,"commit_id":"8829e758af17750124d8f26710aa7ebc8108f9e3","original_commit_id":"8829e758af17750124d8f26710aa7ebc8108f9e3","user":{"login":"Airblader","id":2392216,"avatar_url":"https://avatars.githubusercontent.com/u/2392216?v=3","gravatar_id":"","url":"https://api.github.com/users/Airblader","html_url":"https://github.com/Airblader","followers_url":"https://api.github.com/users/Airblader/followers","following_url":"https://api.github.com/users/Airblader/following{/other_user}","gists_url":"https://api.github.com/users/Airblader/gists{/gist_id}","starred_url":"https://api.github.com/users/Airblader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Airblader/subscriptions","organizations_url":"https://api.github.com/users/Airblader/orgs","repos_url":"https://api.github.com/users/Airblader/repos","events_url":"https://api.github.com/users/Airblader/events{/privacy}","received_events_url":"https://api.github.com/users/Airblader/received_events","type":"User","site_admin":false},"body":"Now we go through annotations each time `getScenarioFields` is called, which still happens multiple times even within one method. I think refactoring this would deserve its own PR, though, in particular since this has been existng behavior.","created_at":"2016-12-23T08:41:13Z","updated_at":"2016-12-23T08:42:08Z","html_url":"https://github.com/TNG/JGiven/pull/264#discussion_r93740645","pull_request_url":"https://api.github.com/repos/TNG/JGiven/pulls/264","_links":{"self":{"href":"https://api.github.com/repos/TNG/JGiven/pulls/comments/93740645"},"html":{"href":"https://github.com/TNG/JGiven/pull/264#discussion_r93740645"},"pull_request":{"href":"https://api.github.com/repos/TNG/JGiven/pulls/264"}}},"pull_request":{"url":"https://api.github.com/repos/TNG/JGiven/pulls/264","id":98993152,"html_url":"https://github.com/TNG/JGiven/pull/264","diff_url":"https://github.com/TNG/JGiven/pull/264.diff","patch_url":"https://github.com/TNG/JGiven/pull/264.patch","issue_url":"https://api.github.com/repos/TNG/JGiven/issues/264","number":264,"state":"open","locked":false,"title":"Added required attribute to ScenarioState.","user":{"login":"Airblader","id":2392216,"avatar_url":"https://avatars.githubusercontent.com/u/2392216?v=3","gravatar_id":"","url":"https://api.github.com/users/Airblader","html_url":"https://github.com/Airblader","followers_url":"https://api.github.com/users/Airblader/followers","following_url":"https://api.github.com/users/Airblader/following{/other_user}","gists_url":"https://api.github.com/users/Airblader/gists{/gist_id}","starred_url":"https://api.github.com/users/Airblader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Airblader/subscriptions","organizations_url":"https://api.github.com/users/Airblader/orgs","repos_url":"https://api.github.com/users/Airblader/repos","events_url":"https://api.github.com/users/Airblader/events{/privacy}","received_events_url":"https://api.github.com/users/Airblader/received_events","type":"User","site_admin":false},"body":"This commit adds a new boolean attribute \"required\" to both\r\nScenarioState and ExpectedScenarioState. If set to true on a\r\nfield within a stage, corresponding tests will fail automatically\r\nif the state hasn't been provided.\r\n\r\nfixes #255","created_at":"2016-12-21T19:45:19Z","updated_at":"2016-12-23T08:42:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"38a8fe92d9eb2c203f874641978d91eea0601545","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TNG/JGiven/pulls/264/commits","review_comments_url":"https://api.github.com/repos/TNG/JGiven/pulls/264/comments","review_comment_url":"https://api.github.com/repos/TNG/JGiven/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TNG/JGiven/issues/264/comments","statuses_url":"https://api.github.com/repos/TNG/JGiven/statuses/8829e758af17750124d8f26710aa7ebc8108f9e3","head":{"label":"Airblader:feature-255","ref":"feature-255","sha":"8829e758af17750124d8f26710aa7ebc8108f9e3","user":{"login":"Airblader","id":2392216,"avatar_url":"https://avatars.githubusercontent.com/u/2392216?v=3","gravatar_id":"","url":"https://api.github.com/users/Airblader","html_url":"https://github.com/Airblader","followers_url":"https://api.github.com/users/Airblader/followers","following_url":"https://api.github.com/users/Airblader/following{/other_user}","gists_url":"https://api.github.com/users/Airblader/gists{/gist_id}","starred_url":"https://api.github.com/users/Airblader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Airblader/subscriptions","organizations_url":"https://api.github.com/users/Airblader/orgs","repos_url":"https://api.github.com/users/Airblader/repos","events_url":"https://api.github.com/users/Airblader/events{/privacy}","received_events_url":"https://api.github.com/users/Airblader/received_events","type":"User","site_admin":false},"repo":{"id":61454582,"name":"JGiven","full_name":"Airblader/JGiven","owner":{"login":"Airblader","id":2392216,"avatar_url":"https://avatars.githubusercontent.com/u/2392216?v=3","gravatar_id":"","url":"https://api.github.com/users/Airblader","html_url":"https://github.com/Airblader","followers_url":"https://api.github.com/users/Airblader/followers","following_url":"https://api.github.com/users/Airblader/following{/other_user}","gists_url":"https://api.github.com/users/Airblader/gists{/gist_id}","starred_url":"https://api.github.com/users/Airblader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Airblader/subscriptions","organizations_url":"https://api.github.com/users/Airblader/orgs","repos_url":"https://api.github.com/users/Airblader/repos","events_url":"https://api.github.com/users/Airblader/events{/privacy}","received_events_url":"https://api.github.com/users/Airblader/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Airblader/JGiven","description":"Behavior-Driven Development in plain Java","fork":true,"url":"https://api.github.com/repos/Airblader/JGiven","forks_url":"https://api.github.com/repos/Airblader/JGiven/forks","keys_url":"https://api.github.com/repos/Airblader/JGiven/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Airblader/JGiven/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Airblader/JGiven/teams","hooks_url":"https://api.github.com/repos/Airblader/JGiven/hooks","issue_events_url":"https://api.github.com/repos/Airblader/JGiven/issues/events{/number}","events_url":"https://api.github.com/repos/Airblader/JGiven/events","assignees_url":"https://api.github.com/repos/Airblader/JGiven/assignees{/user}","branches_url":"https://api.github.com/repos/Airblader/JGiven/branches{/branch}","tags_url":"https://api.github.com/repos/Airblader/JGiven/tags","blobs_url":"https://api.github.com/repos/Airblader/JGiven/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Airblader/JGiven/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Airblader/JGiven/git/refs{/sha}","trees_url":"https://api.github.com/repos/Airblader/JGiven/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Airblader/JGiven/statuses/{sha}","languages_url":"https://api.github.com/repos/Airblader/JGiven/languages","stargazers_url":"https://api.github.com/repos/Airblader/JGiven/stargazers","contributors_url":"https://api.github.com/repos/Airblader/JGiven/contributors","subscribers_url":"https://api.github.com/repos/Airblader/JGiven/subscribers","subscription_url":"https://api.github.com/repos/Airblader/JGiven/subscription","commits_url":"https://api.github.com/repos/Airblader/JGiven/commits{/sha}","git_commits_url":"https://api.github.com/repos/Airblader/JGiven/git/commits{/sha}","comments_url":"https://api.github.com/repos/Airblader/JGiven/comments{/number}","issue_comment_url":"https://api.github.com/repos/Airblader/JGiven/issues/comments{/number}","contents_url":"https://api.github.com/repos/Airblader/JGiven/contents/{+path}","compare_url":"https://api.github.com/repos/Airblader/JGiven/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Airblader/JGiven/merges","archive_url":"https://api.github.com/repos/Airblader/JGiven/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Airblader/JGiven/downloads","issues_url":"https://api.github.com/repos/Airblader/JGiven/issues{/number}","pulls_url":"https://api.github.com/repos/Airblader/JGiven/pulls{/number}","milestones_url":"https://api.github.com/repos/Airblader/JGiven/milestones{/number}","notifications_url":"https://api.github.com/repos/Airblader/JGiven/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Airblader/JGiven/labels{/name}","releases_url":"https://api.github.com/repos/Airblader/JGiven/releases{/id}","deployments_url":"https://api.github.com/repos/Airblader/JGiven/deployments","created_at":"2016-06-18T22:14:09Z","updated_at":"2016-06-18T22:14:11Z","pushed_at":"2016-12-23T08:37:17Z","git_url":"git://github.com/Airblader/JGiven.git","ssh_url":"git@github.com:Airblader/JGiven.git","clone_url":"https://github.com/Airblader/JGiven.git","svn_url":"https://github.com/Airblader/JGiven","homepage":"http://jgiven.org","size":14096,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TNG:master","ref":"master","sha":"c2214e7c4580b6b55858141dc15ea60e19bbc2b3","user":{"login":"TNG","id":432256,"avatar_url":"https://avatars.githubusercontent.com/u/432256?v=3","gravatar_id":"","url":"https://api.github.com/users/TNG","html_url":"https://github.com/TNG","followers_url":"https://api.github.com/users/TNG/followers","following_url":"https://api.github.com/users/TNG/following{/other_user}","gists_url":"https://api.github.com/users/TNG/gists{/gist_id}","starred_url":"https://api.github.com/users/TNG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TNG/subscriptions","organizations_url":"https://api.github.com/users/TNG/orgs","repos_url":"https://api.github.com/users/TNG/repos","events_url":"https://api.github.com/users/TNG/events{/privacy}","received_events_url":"https://api.github.com/users/TNG/received_events","type":"Organization","site_admin":false},"repo":{"id":18664242,"name":"JGiven","full_name":"TNG/JGiven","owner":{"login":"TNG","id":432256,"avatar_url":"https://avatars.githubusercontent.com/u/432256?v=3","gravatar_id":"","url":"https://api.github.com/users/TNG","html_url":"https://github.com/TNG","followers_url":"https://api.github.com/users/TNG/followers","following_url":"https://api.github.com/users/TNG/following{/other_user}","gists_url":"https://api.github.com/users/TNG/gists{/gist_id}","starred_url":"https://api.github.com/users/TNG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TNG/subscriptions","organizations_url":"https://api.github.com/users/TNG/orgs","repos_url":"https://api.github.com/users/TNG/repos","events_url":"https://api.github.com/users/TNG/events{/privacy}","received_events_url":"https://api.github.com/users/TNG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TNG/JGiven","description":"Behavior-Driven Development in plain Java","fork":false,"url":"https://api.github.com/repos/TNG/JGiven","forks_url":"https://api.github.com/repos/TNG/JGiven/forks","keys_url":"https://api.github.com/repos/TNG/JGiven/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TNG/JGiven/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TNG/JGiven/teams","hooks_url":"https://api.github.com/repos/TNG/JGiven/hooks","issue_events_url":"https://api.github.com/repos/TNG/JGiven/issues/events{/number}","events_url":"https://api.github.com/repos/TNG/JGiven/events","assignees_url":"https://api.github.com/repos/TNG/JGiven/assignees{/user}","branches_url":"https://api.github.com/repos/TNG/JGiven/branches{/branch}","tags_url":"https://api.github.com/repos/TNG/JGiven/tags","blobs_url":"https://api.github.com/repos/TNG/JGiven/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TNG/JGiven/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TNG/JGiven/git/refs{/sha}","trees_url":"https://api.github.com/repos/TNG/JGiven/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TNG/JGiven/statuses/{sha}","languages_url":"https://api.github.com/repos/TNG/JGiven/languages","stargazers_url":"https://api.github.com/repos/TNG/JGiven/stargazers","contributors_url":"https://api.github.com/repos/TNG/JGiven/contributors","subscribers_url":"https://api.github.com/repos/TNG/JGiven/subscribers","subscription_url":"https://api.github.com/repos/TNG/JGiven/subscription","commits_url":"https://api.github.com/repos/TNG/JGiven/commits{/sha}","git_commits_url":"https://api.github.com/repos/TNG/JGiven/git/commits{/sha}","comments_url":"https://api.github.com/repos/TNG/JGiven/comments{/number}","issue_comment_url":"https://api.github.com/repos/TNG/JGiven/issues/comments{/number}","contents_url":"https://api.github.com/repos/TNG/JGiven/contents/{+path}","compare_url":"https://api.github.com/repos/TNG/JGiven/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TNG/JGiven/merges","archive_url":"https://api.github.com/repos/TNG/JGiven/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TNG/JGiven/downloads","issues_url":"https://api.github.com/repos/TNG/JGiven/issues{/number}","pulls_url":"https://api.github.com/repos/TNG/JGiven/pulls{/number}","milestones_url":"https://api.github.com/repos/TNG/JGiven/milestones{/number}","notifications_url":"https://api.github.com/repos/TNG/JGiven/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TNG/JGiven/labels{/name}","releases_url":"https://api.github.com/repos/TNG/JGiven/releases{/id}","deployments_url":"https://api.github.com/repos/TNG/JGiven/deployments","created_at":"2014-04-11T06:10:24Z","updated_at":"2016-12-20T20:30:07Z","pushed_at":"2016-12-23T08:37:19Z","git_url":"git://github.com/TNG/JGiven.git","ssh_url":"git@github.com:TNG/JGiven.git","clone_url":"https://github.com/TNG/JGiven.git","svn_url":"https://github.com/TNG/JGiven","homepage":"http://jgiven.org","size":14759,"stargazers_count":129,"watchers_count":129,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":36,"mirror_url":null,"open_issues_count":29,"forks":36,"open_issues":29,"watchers":129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TNG/JGiven/pulls/264"},"html":{"href":"https://github.com/TNG/JGiven/pull/264"},"issue":{"href":"https://api.github.com/repos/TNG/JGiven/issues/264"},"comments":{"href":"https://api.github.com/repos/TNG/JGiven/issues/264/comments"},"review_comments":{"href":"https://api.github.com/repos/TNG/JGiven/pulls/264/comments"},"review_comment":{"href":"https://api.github.com/repos/TNG/JGiven/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TNG/JGiven/pulls/264/commits"},"statuses":{"href":"https://api.github.com/repos/TNG/JGiven/statuses/8829e758af17750124d8f26710aa7ebc8108f9e3"}}}}
{"actor":{"display_login":"Airblader"}}