{"action":"created","comment":{"url":"https://api.github.com/repos/playframework/playframework/pulls/comments/59286035","id":59286035,"diff_hunk":"@@ -113,6 +113,9 @@ play.filters {\n \n     # The Content-Security-Policy header. If null, the header is not set.\n     contentSecurityPolicy = \"default-src 'self'\"\n+\n+    # Allow one or more of the above security headers to be overridden using .withHeaders\n+    allowPageSpecificOverrides = false","path":"framework/src/play-filters-helpers/src/main/resources/reference.conf","position":6,"original_position":6,"commit_id":"7cdf181234177b1e43ab6e60645792bbb7986fcf","original_commit_id":"7cdf181234177b1e43ab6e60645792bbb7986fcf","user":{"login":"marcospereira","id":4576,"avatar_url":"https://avatars.githubusercontent.com/u/4576?v=3","gravatar_id":"","url":"https://api.github.com/users/marcospereira","html_url":"https://github.com/marcospereira","followers_url":"https://api.github.com/users/marcospereira/followers","following_url":"https://api.github.com/users/marcospereira/following{/other_user}","gists_url":"https://api.github.com/users/marcospereira/gists{/gist_id}","starred_url":"https://api.github.com/users/marcospereira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcospereira/subscriptions","organizations_url":"https://api.github.com/users/marcospereira/orgs","repos_url":"https://api.github.com/users/marcospereira/repos","events_url":"https://api.github.com/users/marcospereira/events{/privacy}","received_events_url":"https://api.github.com/users/marcospereira/received_events","type":"User","site_admin":false},"body":"Maybe a better name would be `allowActionSpecificOverrides` since the overrides happens at action level.","created_at":"2016-04-11T21:36:26Z","updated_at":"2016-04-11T21:36:26Z","html_url":"https://github.com/playframework/playframework/pull/6019#discussion_r59286035","pull_request_url":"https://api.github.com/repos/playframework/playframework/pulls/6019","_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments/59286035"},"html":{"href":"https://github.com/playframework/playframework/pull/6019#discussion_r59286035"},"pull_request":{"href":"https://api.github.com/repos/playframework/playframework/pulls/6019"}}},"pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/6019","id":66053743,"html_url":"https://github.com/playframework/playframework/pull/6019","diff_url":"https://github.com/playframework/playframework/pull/6019.diff","patch_url":"https://github.com/playframework/playframework/pull/6019.patch","issue_url":"https://api.github.com/repos/playframework/playframework/issues/6019","number":6019,"state":"open","locked":false,"title":"Allow page-specific overrides to the security headers provided by Sec…","user":{"login":"bwbecker","id":1038662,"avatar_url":"https://avatars.githubusercontent.com/u/1038662?v=3","gravatar_id":"","url":"https://api.github.com/users/bwbecker","html_url":"https://github.com/bwbecker","followers_url":"https://api.github.com/users/bwbecker/followers","following_url":"https://api.github.com/users/bwbecker/following{/other_user}","gists_url":"https://api.github.com/users/bwbecker/gists{/gist_id}","starred_url":"https://api.github.com/users/bwbecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwbecker/subscriptions","organizations_url":"https://api.github.com/users/bwbecker/orgs","repos_url":"https://api.github.com/users/bwbecker/repos","events_url":"https://api.github.com/users/bwbecker/events{/privacy}","received_events_url":"https://api.github.com/users/bwbecker/received_events","type":"User","site_admin":false},"body":"## Fixes\r\n\r\nFixes #6011\r\n\r\n## Purpose\r\n\r\nAllow security headers such as CONTENT_SECURITY_POLICY_HEADER to be overridden on specific pages.  \r\n\r\n## Background Context\r\n\r\nThe current implementation of `SecurityHeadersFilter` overwrites any security headers set with `.withHeaders`.  This pull request modifies `SecurityHeadersFilter` avoid that, provided `play.filters.headers.allowPageSpecificOverrides` has been set to true.\r\n\r\nThe basic approach is a collaborative effort between myself and @gmethvin at #6011.\r\n\r\n","created_at":"2016-04-11T20:06:34Z","updated_at":"2016-04-11T21:36:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c84bb079fd53b5989d5dae6df4f062791aa572b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/playframework/playframework/pulls/6019/commits","review_comments_url":"https://api.github.com/repos/playframework/playframework/pulls/6019/comments","review_comment_url":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/6019/comments","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/7cdf181234177b1e43ab6e60645792bbb7986fcf","head":{"label":"bwbecker:page-specific-CSP-overrides","ref":"page-specific-CSP-overrides","sha":"7cdf181234177b1e43ab6e60645792bbb7986fcf","user":{"login":"bwbecker","id":1038662,"avatar_url":"https://avatars.githubusercontent.com/u/1038662?v=3","gravatar_id":"","url":"https://api.github.com/users/bwbecker","html_url":"https://github.com/bwbecker","followers_url":"https://api.github.com/users/bwbecker/followers","following_url":"https://api.github.com/users/bwbecker/following{/other_user}","gists_url":"https://api.github.com/users/bwbecker/gists{/gist_id}","starred_url":"https://api.github.com/users/bwbecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwbecker/subscriptions","organizations_url":"https://api.github.com/users/bwbecker/orgs","repos_url":"https://api.github.com/users/bwbecker/repos","events_url":"https://api.github.com/users/bwbecker/events{/privacy}","received_events_url":"https://api.github.com/users/bwbecker/received_events","type":"User","site_admin":false},"repo":{"id":55994025,"name":"playframework","full_name":"bwbecker/playframework","owner":{"login":"bwbecker","id":1038662,"avatar_url":"https://avatars.githubusercontent.com/u/1038662?v=3","gravatar_id":"","url":"https://api.github.com/users/bwbecker","html_url":"https://github.com/bwbecker","followers_url":"https://api.github.com/users/bwbecker/followers","following_url":"https://api.github.com/users/bwbecker/following{/other_user}","gists_url":"https://api.github.com/users/bwbecker/gists{/gist_id}","starred_url":"https://api.github.com/users/bwbecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwbecker/subscriptions","organizations_url":"https://api.github.com/users/bwbecker/orgs","repos_url":"https://api.github.com/users/bwbecker/repos","events_url":"https://api.github.com/users/bwbecker/events{/privacy}","received_events_url":"https://api.github.com/users/bwbecker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bwbecker/playframework","description":"Play Framework","fork":true,"url":"https://api.github.com/repos/bwbecker/playframework","forks_url":"https://api.github.com/repos/bwbecker/playframework/forks","keys_url":"https://api.github.com/repos/bwbecker/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bwbecker/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bwbecker/playframework/teams","hooks_url":"https://api.github.com/repos/bwbecker/playframework/hooks","issue_events_url":"https://api.github.com/repos/bwbecker/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/bwbecker/playframework/events","assignees_url":"https://api.github.com/repos/bwbecker/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/bwbecker/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/bwbecker/playframework/tags","blobs_url":"https://api.github.com/repos/bwbecker/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bwbecker/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bwbecker/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/bwbecker/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bwbecker/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/bwbecker/playframework/languages","stargazers_url":"https://api.github.com/repos/bwbecker/playframework/stargazers","contributors_url":"https://api.github.com/repos/bwbecker/playframework/contributors","subscribers_url":"https://api.github.com/repos/bwbecker/playframework/subscribers","subscription_url":"https://api.github.com/repos/bwbecker/playframework/subscription","commits_url":"https://api.github.com/repos/bwbecker/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/bwbecker/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/bwbecker/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/bwbecker/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/bwbecker/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/bwbecker/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bwbecker/playframework/merges","archive_url":"https://api.github.com/repos/bwbecker/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bwbecker/playframework/downloads","issues_url":"https://api.github.com/repos/bwbecker/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/bwbecker/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/bwbecker/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/bwbecker/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bwbecker/playframework/labels{/name}","releases_url":"https://api.github.com/repos/bwbecker/playframework/releases{/id}","deployments_url":"https://api.github.com/repos/bwbecker/playframework/deployments","created_at":"2016-04-11T17:45:42Z","updated_at":"2016-04-11T17:45:51Z","pushed_at":"2016-04-11T19:51:11Z","git_url":"git://github.com/bwbecker/playframework.git","ssh_url":"git@github.com:bwbecker/playframework.git","clone_url":"https://github.com/bwbecker/playframework.git","svn_url":"https://github.com/bwbecker/playframework","homepage":"http://www.playframework.com/","size":82339,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"playframework:master","ref":"master","sha":"c0f1270c8584e90d512474eb9b2b87af754a89f8","user":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"repo":{"id":2340549,"name":"playframework","full_name":"playframework/playframework","owner":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/playframework/playframework","description":"Play Framework","fork":false,"url":"https://api.github.com/repos/playframework/playframework","forks_url":"https://api.github.com/repos/playframework/playframework/forks","keys_url":"https://api.github.com/repos/playframework/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/playframework/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/playframework/playframework/teams","hooks_url":"https://api.github.com/repos/playframework/playframework/hooks","issue_events_url":"https://api.github.com/repos/playframework/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/playframework/playframework/events","assignees_url":"https://api.github.com/repos/playframework/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/playframework/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/playframework/playframework/tags","blobs_url":"https://api.github.com/repos/playframework/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/playframework/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/playframework/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/playframework/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/playframework/playframework/languages","stargazers_url":"https://api.github.com/repos/playframework/playframework/stargazers","contributors_url":"https://api.github.com/repos/playframework/playframework/contributors","subscribers_url":"https://api.github.com/repos/playframework/playframework/subscribers","subscription_url":"https://api.github.com/repos/playframework/playframework/subscription","commits_url":"https://api.github.com/repos/playframework/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/playframework/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/playframework/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/playframework/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/playframework/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/playframework/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/playframework/playframework/merges","archive_url":"https://api.github.com/repos/playframework/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/playframework/playframework/downloads","issues_url":"https://api.github.com/repos/playframework/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/playframework/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/playframework/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/playframework/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/playframework/playframework/labels{/name}","releases_url":"https://api.github.com/repos/playframework/playframework/releases{/id}","deployments_url":"https://api.github.com/repos/playframework/playframework/deployments","created_at":"2011-09-07T09:24:08Z","updated_at":"2016-04-11T19:42:13Z","pushed_at":"2016-04-11T20:06:34Z","git_url":"git://github.com/playframework/playframework.git","ssh_url":"git@github.com:playframework/playframework.git","clone_url":"https://github.com/playframework/playframework.git","svn_url":"https://github.com/playframework/playframework","homepage":"http://www.playframework.com/","size":93451,"stargazers_count":7707,"watchers_count":7707,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2681,"mirror_url":null,"open_issues_count":253,"forks":2681,"open_issues":253,"watchers":7707,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/6019"},"html":{"href":"https://github.com/playframework/playframework/pull/6019"},"issue":{"href":"https://api.github.com/repos/playframework/playframework/issues/6019"},"comments":{"href":"https://api.github.com/repos/playframework/playframework/issues/6019/comments"},"review_comments":{"href":"https://api.github.com/repos/playframework/playframework/pulls/6019/comments"},"review_comment":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/playframework/playframework/pulls/6019/commits"},"statuses":{"href":"https://api.github.com/repos/playframework/playframework/statuses/7cdf181234177b1e43ab6e60645792bbb7986fcf"}}}}