{"action":"created","comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/80239462","id":80239462,"diff_hunk":"@@ -1984,138 +2119,245 @@ NumarkMixtrack3.PitchBendPlusButton = function(channel, control, value, status,\n     }\n };\n \n+\n NumarkMixtrack3.BeatKnob = function(channel, control, value, status, group) {\n     var decknum = NumarkMixtrack3.deckFromGroup(group);\n     var deck = NumarkMixtrack3.decks[\"D\" + decknum];\n     var gainIncrement;\n     var gainValue = [];\n     var i,j;\n     var knobValue;\n+        \n     \n-    if (!BeatKnobAsSamplerVolume) {\n-        // Default configuration option, use knob for Beatgrid only\n+    if (deck.PADMode === false) {\n+\n+        // Default mode, direct interaction with knob, without any button combination\n+        for (i = 1; i <= 3; i++) {\n+            \n+            if (deck.TapDown) {\n+                gainValue[i-1] = engine.getParameter(\"[EffectRack1_EffectUnit\" + [i] + \"_Effect1]\", \"parameter2\"); ","path":"res/controllers/Numark-Mixtrack-3-scripts.js","position":568,"original_position":568,"commit_id":"17209bd7046fbf231fade8c54dec6d8ac8b60649","original_commit_id":"17209bd7046fbf231fade8c54dec6d8ac8b60649","user":{"login":"Be-ing","id":9455094,"avatar_url":"https://avatars.githubusercontent.com/u/9455094?v=3","gravatar_id":"","url":"https://api.github.com/users/Be-ing","html_url":"https://github.com/Be-ing","followers_url":"https://api.github.com/users/Be-ing/followers","following_url":"https://api.github.com/users/Be-ing/following{/other_user}","gists_url":"https://api.github.com/users/Be-ing/gists{/gist_id}","starred_url":"https://api.github.com/users/Be-ing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Be-ing/subscriptions","organizations_url":"https://api.github.com/users/Be-ing/orgs","repos_url":"https://api.github.com/users/Be-ing/repos","events_url":"https://api.github.com/users/Be-ing/events{/privacy}","received_events_url":"https://api.github.com/users/Be-ing/received_events","type":"User","site_admin":false},"body":"Why is `i` in brackets?","created_at":"2016-09-23T13:02:31Z","updated_at":"2016-09-23T13:03:15Z","html_url":"https://github.com/mixxxdj/mixxx/pull/1014#discussion_r80239462","pull_request_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1014","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/80239462"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/1014#discussion_r80239462"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1014"}}},"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1014","id":85661039,"html_url":"https://github.com/mixxxdj/mixxx/pull/1014","diff_url":"https://github.com/mixxxdj/mixxx/pull/1014.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/1014.patch","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1014","number":1014,"state":"open","locked":false,"title":"Numark Mixtrack (Pro) 3 FX mapping change (V1.7)","user":{"login":"djsteph","id":16829129,"avatar_url":"https://avatars.githubusercontent.com/u/16829129?v=3","gravatar_id":"","url":"https://api.github.com/users/djsteph","html_url":"https://github.com/djsteph","followers_url":"https://api.github.com/users/djsteph/followers","following_url":"https://api.github.com/users/djsteph/following{/other_user}","gists_url":"https://api.github.com/users/djsteph/gists{/gist_id}","starred_url":"https://api.github.com/users/djsteph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djsteph/subscriptions","organizations_url":"https://api.github.com/users/djsteph/orgs","repos_url":"https://api.github.com/users/djsteph/repos","events_url":"https://api.github.com/users/djsteph/events{/privacy}","received_events_url":"https://api.github.com/users/djsteph/received_events","type":"User","site_admin":false},"body":"Code changes have been validated with JSHint.com\r\n\r\n**Bug fixes**\r\nTouch platter + wheel touch speeds up/slows down song when wheel not enabled \r\nCorrected Tap button mapping\r\nCorrect Tap button led behavior when shift lock is active\r\nMissing callback function for smartPFL to work properly if track is loaded directly on UI\r\nAdjusted mapping of AutoLoop to be identical to Numark user manual, Serato and Virtual DJ, \r\n(1, 2, 4, 8) instead of 2, 4, 8, 16 if not shifted and 0.125, 0.25, 0.5, 16 if shifted\r\n\r\n**FX section Mapping changes**\r\nAdded InstantFx feature: FX are added to InstantFx by holding Tap and FX button. InstantFx are enabled/disabled directly with the Strip.\r\n\r\nTap + FX button: Enables / Disables InstantFx.\r\n\r\nStrip: Super effect. If Instant FX is activated for an FX, also enables / disables that FX\r\nShift + Strip: Fast Seek (already mapped)\r\nTap button + Strip FX paramerer 1 - Effects 1, 2 and 3\r\n\r\nBeat knob: Mix/ratio\r\nTAP + Beat knob = parameter 2 of FX 1, 2 and 3\r\nShift + Beat knob: Beat grid move\r\nPad Mode + Beat knob: Sampler volumes (deck 1= 1-4; deck 2 = (5-8)\r\n\r\nTap Button: well.. Tap button.\r\n\r\n**Deck 1:** \r\nSHIFT + Treble Knob = FX paramerer 1 - Effect 1\r\nSHIFT + Medium Knob = FX parameter 2 - Effect 1\r\nSHIFT + Bass Knob = Fx parameter 3 - Effect 1\r\nSHIFT + Filter Knob = Fx parameter 4 - Effect 1\r\n\r\n**Deck 2:** \r\nSHIFT + Treble Knob = FX paramerer 1 - Effect 2\r\nSHIFT + Medium Knob = FX parameter 2 - Effect 2\r\nSHIFT + Bass Knob = Fx parameter 3 - Effect 2\r\nSHIFT + Filter Knob = Fx parameter 4 - Effect 2\r\n\r\n**Deck 1:** \r\nPad Mode + Treble Knob = FX paramerer 1 - Effect 3\r\nPad Mode + Medium Knob = FX parameter 2 - Effect 3\r\nPad Mode + Bass Knob = Fx parameter 3 - Effect 3\r\nPad Mode + Filter Knob = Fx parameter 4 - Effect 3\r\n\r\n**Deck 2:** \r\nPad Mode + Treble Knob = FX paramerer 1 - Effect 4\r\nPad Mode + Medium Knob = FX parameter 2 - Effect 4\r\nPad Mode + Bass Knob = Fx parameter 3 - Effect 4\r\nPad Mode + Filter Knob = Fx parameter 4 - Effect 4\r\n\r\n**Other changes**\r\nConnected controls for FX enabled \r\nRemoved soft takeover for Super FX knob (accessed by strip)\r\nRemoved Callback function for FX Loaded to prevent all parameters from being automatically linked to Super Knob\r\nRemoved configuration option BeatKnobAsSamplerVolume\r\nIncluded Parameter soft taker over function\r\n\r\n","created_at":"2016-09-17T02:24:16Z","updated_at":"2016-09-23T13:03:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb61fef5933a51ac59c91089c9bde8e5867911de","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1014/commits","review_comments_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1014/comments","review_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1014/comments","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/17209bd7046fbf231fade8c54dec6d8ac8b60649","head":{"label":"djsteph:Mixtrack-Pro-3-mapping-v1.6","ref":"Mixtrack-Pro-3-mapping-v1.6","sha":"17209bd7046fbf231fade8c54dec6d8ac8b60649","user":{"login":"djsteph","id":16829129,"avatar_url":"https://avatars.githubusercontent.com/u/16829129?v=3","gravatar_id":"","url":"https://api.github.com/users/djsteph","html_url":"https://github.com/djsteph","followers_url":"https://api.github.com/users/djsteph/followers","following_url":"https://api.github.com/users/djsteph/following{/other_user}","gists_url":"https://api.github.com/users/djsteph/gists{/gist_id}","starred_url":"https://api.github.com/users/djsteph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djsteph/subscriptions","organizations_url":"https://api.github.com/users/djsteph/orgs","repos_url":"https://api.github.com/users/djsteph/repos","events_url":"https://api.github.com/users/djsteph/events{/privacy}","received_events_url":"https://api.github.com/users/djsteph/received_events","type":"User","site_admin":false},"repo":{"id":67561775,"name":"mixxx","full_name":"djsteph/mixxx","owner":{"login":"djsteph","id":16829129,"avatar_url":"https://avatars.githubusercontent.com/u/16829129?v=3","gravatar_id":"","url":"https://api.github.com/users/djsteph","html_url":"https://github.com/djsteph","followers_url":"https://api.github.com/users/djsteph/followers","following_url":"https://api.github.com/users/djsteph/following{/other_user}","gists_url":"https://api.github.com/users/djsteph/gists{/gist_id}","starred_url":"https://api.github.com/users/djsteph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djsteph/subscriptions","organizations_url":"https://api.github.com/users/djsteph/orgs","repos_url":"https://api.github.com/users/djsteph/repos","events_url":"https://api.github.com/users/djsteph/events{/privacy}","received_events_url":"https://api.github.com/users/djsteph/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/djsteph/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":true,"url":"https://api.github.com/repos/djsteph/mixxx","forks_url":"https://api.github.com/repos/djsteph/mixxx/forks","keys_url":"https://api.github.com/repos/djsteph/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/djsteph/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/djsteph/mixxx/teams","hooks_url":"https://api.github.com/repos/djsteph/mixxx/hooks","issue_events_url":"https://api.github.com/repos/djsteph/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/djsteph/mixxx/events","assignees_url":"https://api.github.com/repos/djsteph/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/djsteph/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/djsteph/mixxx/tags","blobs_url":"https://api.github.com/repos/djsteph/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/djsteph/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/djsteph/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/djsteph/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/djsteph/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/djsteph/mixxx/languages","stargazers_url":"https://api.github.com/repos/djsteph/mixxx/stargazers","contributors_url":"https://api.github.com/repos/djsteph/mixxx/contributors","subscribers_url":"https://api.github.com/repos/djsteph/mixxx/subscribers","subscription_url":"https://api.github.com/repos/djsteph/mixxx/subscription","commits_url":"https://api.github.com/repos/djsteph/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/djsteph/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/djsteph/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/djsteph/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/djsteph/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/djsteph/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/djsteph/mixxx/merges","archive_url":"https://api.github.com/repos/djsteph/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/djsteph/mixxx/downloads","issues_url":"https://api.github.com/repos/djsteph/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/djsteph/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/djsteph/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/djsteph/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/djsteph/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/djsteph/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/djsteph/mixxx/deployments","created_at":"2016-09-07T01:48:13Z","updated_at":"2016-09-17T02:19:19Z","pushed_at":"2016-09-23T01:15:30Z","git_url":"git://github.com/djsteph/mixxx.git","ssh_url":"git@github.com:djsteph/mixxx.git","clone_url":"https://github.com/djsteph/mixxx.git","svn_url":"https://github.com/djsteph/mixxx","homepage":"http://mixxx.org","size":259547,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mixxxdj:master","ref":"master","sha":"19ea942bbb230ca3b39e66f0465e5f0b787ee65c","user":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"repo":{"id":10126031,"name":"mixxx","full_name":"mixxxdj/mixxx","owner":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixxxdj/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":false,"url":"https://api.github.com/repos/mixxxdj/mixxx","forks_url":"https://api.github.com/repos/mixxxdj/mixxx/forks","keys_url":"https://api.github.com/repos/mixxxdj/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixxxdj/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixxxdj/mixxx/teams","hooks_url":"https://api.github.com/repos/mixxxdj/mixxx/hooks","issue_events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/mixxxdj/mixxx/events","assignees_url":"https://api.github.com/repos/mixxxdj/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/mixxxdj/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/mixxxdj/mixxx/tags","blobs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixxxdj/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixxxdj/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/mixxxdj/mixxx/languages","stargazers_url":"https://api.github.com/repos/mixxxdj/mixxx/stargazers","contributors_url":"https://api.github.com/repos/mixxxdj/mixxx/contributors","subscribers_url":"https://api.github.com/repos/mixxxdj/mixxx/subscribers","subscription_url":"https://api.github.com/repos/mixxxdj/mixxx/subscription","commits_url":"https://api.github.com/repos/mixxxdj/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixxxdj/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixxxdj/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/mixxxdj/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixxxdj/mixxx/merges","archive_url":"https://api.github.com/repos/mixxxdj/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixxxdj/mixxx/downloads","issues_url":"https://api.github.com/repos/mixxxdj/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/mixxxdj/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/mixxxdj/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/mixxxdj/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/mixxxdj/mixxx/deployments","created_at":"2013-05-17T15:14:38Z","updated_at":"2016-09-22T21:54:20Z","pushed_at":"2016-09-23T01:15:31Z","git_url":"git://github.com/mixxxdj/mixxx.git","ssh_url":"git@github.com:mixxxdj/mixxx.git","clone_url":"https://github.com/mixxxdj/mixxx.git","svn_url":"https://github.com/mixxxdj/mixxx","homepage":"http://mixxx.org","size":276790,"stargazers_count":590,"watchers_count":590,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":351,"mirror_url":null,"open_issues_count":70,"forks":351,"open_issues":70,"watchers":590,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1014"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/1014"},"issue":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/1014"},"comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/1014/comments"},"review_comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1014/comments"},"review_comment":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1014/commits"},"statuses":{"href":"https://api.github.com/repos/mixxxdj/mixxx/statuses/17209bd7046fbf231fade8c54dec6d8ac8b60649"}}}}
{"actor":{"display_login":"Be-ing"}}