{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/74298629","id":74298629,"diff_hunk":"@@ -3,229 +3,227 @@\n // Definitions by: Peter Snider <https://github.com/psnider/>\n // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped/seneca\n \n+declare function SNS(options?: SNS.Options): SNS.Instance;","path":"seneca/seneca.d.ts","position":4,"original_position":4,"commit_id":"d667c03c0741bfa3f793a4c599785638a84ab5fe","original_commit_id":"d667c03c0741bfa3f793a4c599785638a84ab5fe","user":{"login":"sandersn","id":293473,"avatar_url":"https://avatars.githubusercontent.com/u/293473?v=3","gravatar_id":"","url":"https://api.github.com/users/sandersn","html_url":"https://github.com/sandersn","followers_url":"https://api.github.com/users/sandersn/followers","following_url":"https://api.github.com/users/sandersn/following{/other_user}","gists_url":"https://api.github.com/users/sandersn/gists{/gist_id}","starred_url":"https://api.github.com/users/sandersn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandersn/subscriptions","organizations_url":"https://api.github.com/users/sandersn/orgs","repos_url":"https://api.github.com/users/sandersn/repos","events_url":"https://api.github.com/users/sandersn/events{/privacy}","received_events_url":"https://api.github.com/users/sandersn/received_events","type":"User","site_admin":false},"body":"It's fine to add a merged `function`/`namespace`, but you should leave them inside `declare module \"seneca\"` so that you don't pollute the global namespace. (As long as seneca is a Node-only library; is that correct?)","created_at":"2016-08-10T18:09:13Z","updated_at":"2016-08-10T18:09:13Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/10496#discussion_r74298629","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/10496","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/74298629"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/10496#discussion_r74298629"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/10496"}}},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/10496","id":80347261,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/10496","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/10496.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/10496.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/10496","number":10496,"state":"open","locked":false,"title":"seneca: added namespace to expose interfaces","user":{"login":"psnider","id":940931,"avatar_url":"https://avatars.githubusercontent.com/u/940931?v=3","gravatar_id":"","url":"https://api.github.com/users/psnider","html_url":"https://github.com/psnider","followers_url":"https://api.github.com/users/psnider/followers","following_url":"https://api.github.com/users/psnider/following{/other_user}","gists_url":"https://api.github.com/users/psnider/gists{/gist_id}","starred_url":"https://api.github.com/users/psnider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psnider/subscriptions","organizations_url":"https://api.github.com/users/psnider/orgs","repos_url":"https://api.github.com/users/psnider/repos","events_url":"https://api.github.com/users/psnider/events{/privacy}","received_events_url":"https://api.github.com/users/psnider/received_events","type":"User","site_admin":false},"body":"No types added, only made module and namespace changes.\r\n- [x] checked compilation succeeds with `--target es6` and `--noImplicitAny` options.\r\n- [x] has correct [naming convention](http://definitelytyped.org/guides/contributing.html#naming-the-file)\r\n- [x] has a [test file](http://definitelytyped.org/guides/contributing.html#tests) with the suffix of  `-tests.ts` or `-tests.tsx`.\r\n\r\n","created_at":"2016-08-06T18:27:45Z","updated_at":"2016-08-10T18:09:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25da6140638ad187a24b188ff28e5dc5e86337d2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/10496/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/10496/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/10496/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/d667c03c0741bfa3f793a4c599785638a84ab5fe","head":{"label":"psnider:seneca","ref":"seneca","sha":"d667c03c0741bfa3f793a4c599785638a84ab5fe","user":{"login":"psnider","id":940931,"avatar_url":"https://avatars.githubusercontent.com/u/940931?v=3","gravatar_id":"","url":"https://api.github.com/users/psnider","html_url":"https://github.com/psnider","followers_url":"https://api.github.com/users/psnider/followers","following_url":"https://api.github.com/users/psnider/following{/other_user}","gists_url":"https://api.github.com/users/psnider/gists{/gist_id}","starred_url":"https://api.github.com/users/psnider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psnider/subscriptions","organizations_url":"https://api.github.com/users/psnider/orgs","repos_url":"https://api.github.com/users/psnider/repos","events_url":"https://api.github.com/users/psnider/events{/privacy}","received_events_url":"https://api.github.com/users/psnider/received_events","type":"User","site_admin":false},"repo":{"id":65095682,"name":"DefinitelyTyped","full_name":"psnider/DefinitelyTyped","owner":{"login":"psnider","id":940931,"avatar_url":"https://avatars.githubusercontent.com/u/940931?v=3","gravatar_id":"","url":"https://api.github.com/users/psnider","html_url":"https://github.com/psnider","followers_url":"https://api.github.com/users/psnider/followers","following_url":"https://api.github.com/users/psnider/following{/other_user}","gists_url":"https://api.github.com/users/psnider/gists{/gist_id}","starred_url":"https://api.github.com/users/psnider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psnider/subscriptions","organizations_url":"https://api.github.com/users/psnider/orgs","repos_url":"https://api.github.com/users/psnider/repos","events_url":"https://api.github.com/users/psnider/events{/privacy}","received_events_url":"https://api.github.com/users/psnider/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/psnider/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/psnider/DefinitelyTyped","forks_url":"https://api.github.com/repos/psnider/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/psnider/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/psnider/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/psnider/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/psnider/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/psnider/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/psnider/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/psnider/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/psnider/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/psnider/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/psnider/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/psnider/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/psnider/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/psnider/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/psnider/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/psnider/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/psnider/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/psnider/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/psnider/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/psnider/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/psnider/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/psnider/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/psnider/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/psnider/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/psnider/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/psnider/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/psnider/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/psnider/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/psnider/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/psnider/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/psnider/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/psnider/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/psnider/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/psnider/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/psnider/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/psnider/DefinitelyTyped/deployments","created_at":"2016-08-06T18:11:55Z","updated_at":"2016-08-06T18:12:03Z","pushed_at":"2016-08-07T01:19:19Z","git_url":"git://github.com/psnider/DefinitelyTyped.git","ssh_url":"git@github.com:psnider/DefinitelyTyped.git","clone_url":"https://github.com/psnider/DefinitelyTyped.git","svn_url":"https://github.com/psnider/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":119455,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"bc38caf4c4781b8a9b13785a0529fcd47fd1bfb4","user":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars.githubusercontent.com/u/3637556?v=3","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","owner":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars.githubusercontent.com/u/3637556?v=3","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2016-08-10T17:42:59Z","pushed_at":"2016-08-10T17:59:38Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":156921,"stargazers_count":7921,"watchers_count":7921,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5947,"mirror_url":null,"open_issues_count":886,"forks":5947,"open_issues":886,"watchers":7921,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/10496"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/10496"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/10496"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/10496/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/10496/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/10496/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/d667c03c0741bfa3f793a4c599785638a84ab5fe"}}}}
{"actor":{"display_login":"sandersn"}}