{"push_id":928730378,"size":20,"distinct_size":0,"ref":"refs/heads/delete_microposts","head":"16e2525ac06fe822dfd34193e4d01c56a77c25be","before":"703d42074735f56ef6edd863c476166a2df43cf7","commits":[{"sha":"5cf359c49c72fa21a44a30449b57597fad36ad31","author":{"email":"44f3c67ac454b1769e9432a3b6a909e1bdfddbd3@gmail.com","name":"Michael D. Hoyle"},"message":"Add a test + stubs for micropost delete","distinct":false,"url":"https://api.github.com/repos/hoylemd/sample_app/commits/5cf359c49c72fa21a44a30449b57597fad36ad31"},{"sha":"19ab7fe054c859ec9311c92c7315821282a00e42","author":{"email":"44f3c67ac454b1769e9432a3b6a909e1bdfddbd3@gmail.com","name":"Michael D. Hoyle"},"message":"Implement destroy action ACL\n\nDon't want the wrong people deleting things!","distinct":false,"url":"https://api.github.com/repos/hoylemd/sample_app/commits/19ab7fe054c859ec9311c92c7315821282a00e42"},{"sha":"43606b23b521713ee5b4646c4fb2cd4a83712185","author":{"email":"44f3c67ac454b1769e9432a3b6a909e1bdfddbd3@gmail.com","name":"Michael D. Hoyle"},"message":"Add acl helper classes and tests\n\nI want to move my ACL logic into a single module so it can be reused\neverywhere, and keep behaviour consistent","distinct":false,"url":"https://api.github.com/repos/hoylemd/sample_app/commits/43606b23b521713ee5b4646c4fb2cd4a83712185"},{"sha":"da569ab9003c0f48c03f5864eab5f57280436b5d","author":{"email":"44f3c67ac454b1769e9432a3b6a909e1bdfddbd3@gmail.com","name":"Michael D. Hoyle"},"message":"Add a positive test case for logged_in_user\n\nmore coverage!","distinct":false,"url":"https://api.github.com/repos/hoylemd/sample_app/commits/da569ab9003c0f48c03f5864eab5f57280436b5d"},{"sha":"75532084d73ddd4e309766d346a670ea8d1ce61c","author":{"email":"44f3c67ac454b1769e9432a3b6a909e1bdfddbd3@gmail.com","name":"Michael D. Hoyle"},"message":"Add some stubs for correct_user_or_go_home\n\nI dont have a way to actually test it yet so I need to use it somewhere\nfirst","distinct":false,"url":"https://api.github.com/repos/hoylemd/sample_app/commits/75532084d73ddd4e309766d346a670ea8d1ce61c"},{"sha":"ad101733c7e7b399a203b3c932dfe41cee272498","author":{"email":"44f3c67ac454b1769e9432a3b6a909e1bdfddbd3@gmail.com","name":"Michael D. Hoyle"},"message":"add a todo","distinct":false,"url":"https://api.github.com/repos/hoylemd/sample_app/commits/ad101733c7e7b399a203b3c932dfe41cee272498"},{"sha":"cd2ae301fc6f2ee756a33fd5261a491d38b0c239","author":{"email":"44f3c67ac454b1769e9432a3b6a909e1bdfddbd3@gmail.com","name":"Michael D. Hoyle"},"message":"Add controller tests to guard rule for acl helper\n\nIt affects them quite a bit, so they need to run when I muck with it.","distinct":false,"url":"https://api.github.com/repos/hoylemd/sample_app/commits/cd2ae301fc6f2ee756a33fd5261a491d38b0c239"},{"sha":"d6ef6477004f49eae4f4e1c61cfdfc3f79303b52","author":{"email":"44f3c67ac454b1769e9432a3b6a909e1bdfddbd3@gmail.com","name":"Michael D. Hoyle"},"message":"Use `correct_user_or_go_home` on micropost destroy\n\nThis also allows me to test it!","distinct":false,"url":"https://api.github.com/repos/hoylemd/sample_app/commits/d6ef6477004f49eae4f4e1c61cfdfc3f79303b52"},{"sha":"79a535ce284503212d90d9208a7937b2f850d697","author":{"email":"44f3c67ac454b1769e9432a3b6a909e1bdfddbd3@gmail.com","name":"Michael D. Hoyle"},"message":"Add an unauth test for correct_user_or_go_home\n\nIt redirects to login because it might be the right user making the\nrequest, but their session may have gone away.  This is perhaps\ncounterintuitive to the function name though. Maybe I'll change it\nlater","distinct":false,"url":"https://api.github.com/repos/hoylemd/sample_app/commits/79a535ce284503212d90d9208a7937b2f850d697"},{"sha":"702b74c2a6eff38f7ae0f2d2b62271d01b21e056","author":{"email":"44f3c67ac454b1769e9432a3b6a909e1bdfddbd3@gmail.com","name":"Michael D. Hoyle"},"message":"simplified the `correct_user_or_go_home` helper\n\nNow it just redirects to home if the wrong user is logged in.  Much\nsimpler, and more semantically named.\n\nI also removed the 'not logged in' test case.  While technically, this\nconstitutes a gap in test coverage, this particular case is a) hard to\ntest, and b) handled just fine anyway.  The app will never have an\naction protected by `correct_user_or_go_home` but NOT `logged_in_user`\n(or at least that would be very weird if it did), so this case is\nhandled by `logged_in_user` anyways.  In addition, were that to occur,\nit would still redirect to home saying 'permission denied' - the only\n'bug' would be that it doesnt render the login page right away.  Hardly\na serious problem, in my opinion.","distinct":false,"url":"https://api.github.com/repos/hoylemd/sample_app/commits/702b74c2a6eff38f7ae0f2d2b62271d01b21e056"},{"sha":"40fbcbd613089cefbdbfda6db527fd1f8abade15","author":{"email":"44f3c67ac454b1769e9432a3b6a909e1bdfddbd3@gmail.com","name":"Michael D. Hoyle"},"message":"Add unauthorized assertions\n\nI check the same things all over the place for ACL catches, so using a\nhelper this way will really help out.","distinct":false,"url":"https://api.github.com/repos/hoylemd/sample_app/commits/40fbcbd613089cefbdbfda6db527fd1f8abade15"},{"sha":"97474dffd6771a2c21e8afb17e3eebdc7065b3ab","author":{"email":"44f3c67ac454b1769e9432a3b6a909e1bdfddbd3@gmail.com","name":"Michael D. Hoyle"},"message":"`assert_permission_denied' in mp controller test\n\nRolling this out","distinct":false,"url":"https://api.github.com/repos/hoylemd/sample_app/commits/97474dffd6771a2c21e8afb17e3eebdc7065b3ab"},{"sha":"b76303f3ec35cf6137e42971e52009720552e9c1","author":{"email":"44f3c67ac454b1769e9432a3b6a909e1bdfddbd3@gmail.com","name":"Michael D. Hoyle"},"message":"`assert_401_not_logged_in` in acl and mp ITs\n\nmore rolling out, to ACL and micropost integration tests","distinct":false,"url":"https://api.github.com/repos/hoylemd/sample_app/commits/b76303f3ec35cf6137e42971e52009720552e9c1"},{"sha":"ca75133c3c88dec3bc7fb876e4456a9c9bb57ee4","author":{"email":"44f3c67ac454b1769e9432a3b6a909e1bdfddbd3@gmail.com","name":"Michael D. Hoyle"},"message":"Add todo for new assertions to `users_index_test`","distinct":false,"url":"https://api.github.com/repos/hoylemd/sample_app/commits/ca75133c3c88dec3bc7fb876e4456a9c9bb57ee4"},{"sha":"fd5f688186e356e814658078f664e2b5e8b7c4c5","author":{"email":"44f3c67ac454b1769e9432a3b6a909e1bdfddbd3@gmail.com","name":"Michael D. Hoyle"},"message":"Roll out new helpers to user controller tests\n\nAlso, made the helpers themselves more similar","distinct":false,"url":"https://api.github.com/repos/hoylemd/sample_app/commits/fd5f688186e356e814658078f664e2b5e8b7c4c5"},{"sha":"5a3e6f6a3f3059e5da0f894097b2a64731c6e09b","author":{"email":"44f3c67ac454b1769e9432a3b6a909e1bdfddbd3@gmail.com","name":"Michael D. Hoyle"},"message":"complete helpers in existing mp controller tests\n\nmissed a couple","distinct":false,"url":"https://api.github.com/repos/hoylemd/sample_app/commits/5a3e6f6a3f3059e5da0f894097b2a64731c6e09b"},{"sha":"6b6d8d966e306cc5b6e5ead1f4386328414870c6","author":{"email":"44f3c67ac454b1769e9432a3b6a909e1bdfddbd3@gmail.com","name":"Michael D. Hoyle"},"message":"Refactor the session controller tests a bit\n\nmake them nicer, and I also added a stub for a happy-path test for\nsession/new","distinct":false,"url":"https://api.github.com/repos/hoylemd/sample_app/commits/6b6d8d966e306cc5b6e5ead1f4386328414870c6"},{"sha":"22498337126ff1ac5cf9d20cb8a94fc58a9ce376","author":{"email":"44f3c67ac454b1769e9432a3b6a909e1bdfddbd3@gmail.com","name":"Michael D. Hoyle"},"message":"Add some assert messages to static pages tests\n\nThese should also check that they layout have what they should but that\ncan happen later.","distinct":false,"url":"https://api.github.com/repos/hoylemd/sample_app/commits/22498337126ff1ac5cf9d20cb8a94fc58a9ce376"},{"sha":"05d256daaf71981668865c8f2c0bc621a5dd68c8","author":{"email":"44f3c67ac454b1769e9432a3b6a909e1bdfddbd3@gmail.com","name":"Michael D. Hoyle"},"message":"Add an assert message to user controller test","distinct":false,"url":"https://api.github.com/repos/hoylemd/sample_app/commits/05d256daaf71981668865c8f2c0bc621a5dd68c8"},{"sha":"16e2525ac06fe822dfd34193e4d01c56a77c25be","author":{"email":"44f3c67ac454b1769e9432a3b6a909e1bdfddbd3@gmail.com","name":"Michael D. Hoyle"},"message":"Add test acl helpers and a reminder on microposts","distinct":false,"url":"https://api.github.com/repos/hoylemd/sample_app/commits/16e2525ac06fe822dfd34193e4d01c56a77c25be"}]}