{"action":"opened","number":7,"pull_request":{"url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/pulls/7","id":75238418,"html_url":"https://github.com/Metaswitch/clearwater-net-snmp/pull/7","diff_url":"https://github.com/Metaswitch/clearwater-net-snmp/pull/7.diff","patch_url":"https://github.com/Metaswitch/clearwater-net-snmp/pull/7.patch","issue_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/issues/7","number":7,"state":"open","locked":false,"title":"[Reviewer: Graeme] Simplify building with changes/added logging","user":{"login":"rkd-msw","id":4363492,"avatar_url":"https://avatars.githubusercontent.com/u/4363492?v=3","gravatar_id":"","url":"https://api.github.com/users/rkd-msw","html_url":"https://github.com/rkd-msw","followers_url":"https://api.github.com/users/rkd-msw/followers","following_url":"https://api.github.com/users/rkd-msw/following{/other_user}","gists_url":"https://api.github.com/users/rkd-msw/gists{/gist_id}","starred_url":"https://api.github.com/users/rkd-msw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkd-msw/subscriptions","organizations_url":"https://api.github.com/users/rkd-msw/orgs","repos_url":"https://api.github.com/users/rkd-msw/repos","events_url":"https://api.github.com/users/rkd-msw/events{/privacy}","received_events_url":"https://api.github.com/users/rkd-msw/received_events","type":"User","site_admin":false},"body":"We've spent a chunk of time over the last week trying to get net-snmp building with added temporary diagnostics, which has been pretty hard. This makes me nervous - we're doing more and more with SNMP and need to be able to debug it.\r\n\r\nI had a think about how to make it better, and realised that a lot of the packaging infrastructure (the debian/patches files and the git-buildpackage stuff) was just getting in the way. This infrastructure is to make it easy for projects like Debian to maintain their own set of patches and apply those patches to new upstream versions they take - but net-snmp's last release was in 2014, so adding overheads to our build process to make it easy to take new versions feels like the wrong tradeoff.\r\n\r\nThis PR:\r\n\r\n* applies all the patches from debian/patches to the source tree, as git commits, so that the source you check out is actually the source you build\r\n* documents how to do the \"add a log and rebuild\" workflow (`make` then `debuild --no-lintian -uc -us -b -nc`)\r\n\r\nThe best thing for you to do is probably to confirm that you also think this is a problem worth solving,  check you agree with the general approach, and review README-clearwater.md.\r\n\r\nTagging @bossmc in case he has views on this approach.","created_at":"2016-06-26T19:35:14Z","updated_at":"2016-06-26T19:35:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"graemerobertson","id":5907876,"avatar_url":"https://avatars.githubusercontent.com/u/5907876?v=3","gravatar_id":"","url":"https://api.github.com/users/graemerobertson","html_url":"https://github.com/graemerobertson","followers_url":"https://api.github.com/users/graemerobertson/followers","following_url":"https://api.github.com/users/graemerobertson/following{/other_user}","gists_url":"https://api.github.com/users/graemerobertson/gists{/gist_id}","starred_url":"https://api.github.com/users/graemerobertson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graemerobertson/subscriptions","organizations_url":"https://api.github.com/users/graemerobertson/orgs","repos_url":"https://api.github.com/users/graemerobertson/repos","events_url":"https://api.github.com/users/graemerobertson/events{/privacy}","received_events_url":"https://api.github.com/users/graemerobertson/received_events","type":"User","site_admin":false},"assignees":[{"login":"graemerobertson","id":5907876,"avatar_url":"https://avatars.githubusercontent.com/u/5907876?v=3","gravatar_id":"","url":"https://api.github.com/users/graemerobertson","html_url":"https://github.com/graemerobertson","followers_url":"https://api.github.com/users/graemerobertson/followers","following_url":"https://api.github.com/users/graemerobertson/following{/other_user}","gists_url":"https://api.github.com/users/graemerobertson/gists{/gist_id}","starred_url":"https://api.github.com/users/graemerobertson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graemerobertson/subscriptions","organizations_url":"https://api.github.com/users/graemerobertson/orgs","repos_url":"https://api.github.com/users/graemerobertson/repos","events_url":"https://api.github.com/users/graemerobertson/events{/privacy}","received_events_url":"https://api.github.com/users/graemerobertson/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/pulls/7/commits","review_comments_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/pulls/7/comments","review_comment_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/issues/7/comments","statuses_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/statuses/9bf89d9b4d5426996b2e3137d3d0194c3ecfbe7f","head":{"label":"Metaswitch:new_master","ref":"new_master","sha":"9bf89d9b4d5426996b2e3137d3d0194c3ecfbe7f","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":43830261,"name":"clearwater-net-snmp","full_name":"Metaswitch/clearwater-net-snmp","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/clearwater-net-snmp","description":"Custom builds of net-snmp for Project Clearwater","fork":false,"url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp","forks_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/forks","keys_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/teams","hooks_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/events","assignees_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/tags","blobs_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/subscription","commits_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/merges","archive_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/downloads","issues_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/releases{/id}","deployments_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/deployments","created_at":"2015-10-07T16:46:05Z","updated_at":"2016-03-18T20:20:15Z","pushed_at":"2016-06-26T18:40:55Z","git_url":"git://github.com/Metaswitch/clearwater-net-snmp.git","ssh_url":"git@github.com:Metaswitch/clearwater-net-snmp.git","clone_url":"https://github.com/Metaswitch/clearwater-net-snmp.git","svn_url":"https://github.com/Metaswitch/clearwater-net-snmp","homepage":null,"size":5752,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"Metaswitch:master","ref":"master","sha":"6ae4aba469917af154bf032884d5efd4a77f9247","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":43830261,"name":"clearwater-net-snmp","full_name":"Metaswitch/clearwater-net-snmp","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/clearwater-net-snmp","description":"Custom builds of net-snmp for Project Clearwater","fork":false,"url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp","forks_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/forks","keys_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/teams","hooks_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/events","assignees_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/tags","blobs_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/subscription","commits_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/merges","archive_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/downloads","issues_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/releases{/id}","deployments_url":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/deployments","created_at":"2015-10-07T16:46:05Z","updated_at":"2016-03-18T20:20:15Z","pushed_at":"2016-06-26T18:40:55Z","git_url":"git://github.com/Metaswitch/clearwater-net-snmp.git","ssh_url":"git@github.com:Metaswitch/clearwater-net-snmp.git","clone_url":"https://github.com/Metaswitch/clearwater-net-snmp.git","svn_url":"https://github.com/Metaswitch/clearwater-net-snmp","homepage":null,"size":5752,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/pulls/7"},"html":{"href":"https://github.com/Metaswitch/clearwater-net-snmp/pull/7"},"issue":{"href":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/issues/7"},"comments":{"href":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/Metaswitch/clearwater-net-snmp/statuses/9bf89d9b4d5426996b2e3137d3d0194c3ecfbe7f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":31,"additions":750,"deletions":3354,"changed_files":91}}
{"actor":{"display_login":"rkd-msw"}}