{"action":"created","issue":{"url":"https://api.github.com/repos/vert-x3/vertx-web/issues/287","labels_url":"https://api.github.com/repos/vert-x3/vertx-web/issues/287/labels{/name}","comments_url":"https://api.github.com/repos/vert-x3/vertx-web/issues/287/comments","events_url":"https://api.github.com/repos/vert-x3/vertx-web/issues/287/events","html_url":"https://github.com/vert-x3/vertx-web/pull/287","id":125496029,"number":287,"title":"Tests for getBodyAsJson and getBodyAsJsonArray","user":{"login":"slayful","id":1950206,"avatar_url":"https://avatars.githubusercontent.com/u/1950206?v=3","gravatar_id":"","url":"https://api.github.com/users/slayful","html_url":"https://github.com/slayful","followers_url":"https://api.github.com/users/slayful/followers","following_url":"https://api.github.com/users/slayful/following{/other_user}","gists_url":"https://api.github.com/users/slayful/gists{/gist_id}","starred_url":"https://api.github.com/users/slayful/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slayful/subscriptions","organizations_url":"https://api.github.com/users/slayful/orgs","repos_url":"https://api.github.com/users/slayful/repos","events_url":"https://api.github.com/users/slayful/events{/privacy}","received_events_url":"https://api.github.com/users/slayful/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/vert-x3/vertx-web/labels/to%20review","name":"to review","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-07T22:09:58Z","updated_at":"2016-01-08T10:37:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vert-x3/vertx-web/pulls/287","html_url":"https://github.com/vert-x3/vertx-web/pull/287","diff_url":"https://github.com/vert-x3/vertx-web/pull/287.diff","patch_url":"https://github.com/vert-x3/vertx-web/pull/287.patch"},"body":"As suggested by Arnaud Esteve https://github.com/vert-x3/vertx-web/pull/281#issuecomment-166308585\r\n\r\nI wanted to avoid adding a mocking dependency but if we could do that we could simplify this and further tests greatly.\r\n\r\nThe pull request also includes the isSSL implementation in HttpServerRequestWrapper as HttpServerRequest has changed in vert.x core."},"comment":{"url":"https://api.github.com/repos/vert-x3/vertx-web/issues/comments/169958583","html_url":"https://github.com/vert-x3/vertx-web/pull/287#issuecomment-169958583","issue_url":"https://api.github.com/repos/vert-x3/vertx-web/issues/287","id":169958583,"user":{"login":"pmlopes","id":849467,"avatar_url":"https://avatars.githubusercontent.com/u/849467?v=3","gravatar_id":"","url":"https://api.github.com/users/pmlopes","html_url":"https://github.com/pmlopes","followers_url":"https://api.github.com/users/pmlopes/followers","following_url":"https://api.github.com/users/pmlopes/following{/other_user}","gists_url":"https://api.github.com/users/pmlopes/gists{/gist_id}","starred_url":"https://api.github.com/users/pmlopes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmlopes/subscriptions","organizations_url":"https://api.github.com/users/pmlopes/orgs","repos_url":"https://api.github.com/users/pmlopes/repos","events_url":"https://api.github.com/users/pmlopes/events{/privacy}","received_events_url":"https://api.github.com/users/pmlopes/received_events","type":"User","site_admin":false},"created_at":"2016-01-08T10:37:10Z","updated_at":"2016-01-08T10:37:10Z","body":"other test use a real server and a httpclient to test the API i think it would be easier that way no?"}}