{"action":"created","comment":{"url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/comments/81187167","pull_request_review_id":2185972,"id":81187167,"diff_hunk":"@@ -209,6 +209,28 @@ def timer_bestpath_limit_set\n     @bgp_vrf.timer_bestpath_limit_set(limit, always)\n   end\n \n+  def image_older_version\n+    fd = Facter.value('cisco')\n+    image = fd['images']['system_image']\n+    pid = fd['inventory']['chassis']['pid']\n+    image[/7.0.3.I2|I3|I4/] || pid[/N(5|6|7|8)/]","path":"lib/puppet/provider/cisco_bgp/cisco.rb","position":null,"original_position":8,"commit_id":"33c065a5750ccf6dc5ba42d24f7d843ef0010293","original_commit_id":"2c8913c2e891c8e0bd36b3788a740140a37e86b3","user":{"login":"saichint","id":15788941,"avatar_url":"https://avatars.githubusercontent.com/u/15788941?v=3","gravatar_id":"","url":"https://api.github.com/users/saichint","html_url":"https://github.com/saichint","followers_url":"https://api.github.com/users/saichint/followers","following_url":"https://api.github.com/users/saichint/following{/other_user}","gists_url":"https://api.github.com/users/saichint/gists{/gist_id}","starred_url":"https://api.github.com/users/saichint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saichint/subscriptions","organizations_url":"https://api.github.com/users/saichint/orgs","repos_url":"https://api.github.com/users/saichint/repos","events_url":"https://api.github.com/users/saichint/events{/privacy}","received_events_url":"https://api.github.com/users/saichint/received_events","type":"User","site_admin":false},"body":"not doing it as we discussed","created_at":"2016-09-29T17:14:44Z","updated_at":"2016-09-29T17:14:45Z","html_url":"https://github.com/cisco/cisco-network-puppet-module/pull/395#discussion_r81187167","pull_request_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/395","_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/comments/81187167"},"html":{"href":"https://github.com/cisco/cisco-network-puppet-module/pull/395#discussion_r81187167"},"pull_request":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/395"}}},"pull_request":{"url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/395","id":87166051,"html_url":"https://github.com/cisco/cisco-network-puppet-module/pull/395","diff_url":"https://github.com/cisco/cisco-network-puppet-module/pull/395.diff","patch_url":"https://github.com/cisco/cisco-network-puppet-module/pull/395.patch","issue_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/395","number":395,"state":"open","locked":false,"title":"event_history_periodic changes for bgp","user":{"login":"saichint","id":15788941,"avatar_url":"https://avatars.githubusercontent.com/u/15788941?v=3","gravatar_id":"","url":"https://api.github.com/users/saichint","html_url":"https://github.com/saichint","followers_url":"https://api.github.com/users/saichint/followers","following_url":"https://api.github.com/users/saichint/following{/other_user}","gists_url":"https://api.github.com/users/saichint/gists{/gist_id}","starred_url":"https://api.github.com/users/saichint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saichint/subscriptions","organizations_url":"https://api.github.com/users/saichint/orgs","repos_url":"https://api.github.com/users/saichint/repos","events_url":"https://api.github.com/users/saichint/events{/privacy}","received_events_url":"https://api.github.com/users/saichint/received_events","type":"User","site_admin":false},"body":"This PR is for fixing event_history_periodic property of bgp as the defaults is changed in I5 image. The new default is 'false' whereas the earlier images it is 'size_small'. The changes are backward compatible with older releases. Also all event_history properties will now accept size in bytes. The CLIs were accepting th size in bytes in the older releases as well using hidden commands but now they are not hidden, so the changes are transparent for all releases. ","created_at":"2016-09-28T17:39:49Z","updated_at":"2016-09-29T17:14:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba46460b66ed053c308d58b9c65fa952b72bc849","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/395/commits","review_comments_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/395/comments","review_comment_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/395/comments","statuses_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/statuses/33c065a5750ccf6dc5ba42d24f7d843ef0010293","head":{"label":"saichint:hsrp","ref":"hsrp","sha":"33c065a5750ccf6dc5ba42d24f7d843ef0010293","user":{"login":"saichint","id":15788941,"avatar_url":"https://avatars.githubusercontent.com/u/15788941?v=3","gravatar_id":"","url":"https://api.github.com/users/saichint","html_url":"https://github.com/saichint","followers_url":"https://api.github.com/users/saichint/followers","following_url":"https://api.github.com/users/saichint/following{/other_user}","gists_url":"https://api.github.com/users/saichint/gists{/gist_id}","starred_url":"https://api.github.com/users/saichint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saichint/subscriptions","organizations_url":"https://api.github.com/users/saichint/orgs","repos_url":"https://api.github.com/users/saichint/repos","events_url":"https://api.github.com/users/saichint/events{/privacy}","received_events_url":"https://api.github.com/users/saichint/received_events","type":"User","site_admin":false},"repo":{"id":56001084,"name":"cisco-network-puppet-module","full_name":"saichint/cisco-network-puppet-module","owner":{"login":"saichint","id":15788941,"avatar_url":"https://avatars.githubusercontent.com/u/15788941?v=3","gravatar_id":"","url":"https://api.github.com/users/saichint","html_url":"https://github.com/saichint","followers_url":"https://api.github.com/users/saichint/followers","following_url":"https://api.github.com/users/saichint/following{/other_user}","gists_url":"https://api.github.com/users/saichint/gists{/gist_id}","starred_url":"https://api.github.com/users/saichint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saichint/subscriptions","organizations_url":"https://api.github.com/users/saichint/orgs","repos_url":"https://api.github.com/users/saichint/repos","events_url":"https://api.github.com/users/saichint/events{/privacy}","received_events_url":"https://api.github.com/users/saichint/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saichint/cisco-network-puppet-module","description":"","fork":true,"url":"https://api.github.com/repos/saichint/cisco-network-puppet-module","forks_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/forks","keys_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/teams","hooks_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/hooks","issue_events_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/issues/events{/number}","events_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/events","assignees_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/assignees{/user}","branches_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/branches{/branch}","tags_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/tags","blobs_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/statuses/{sha}","languages_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/languages","stargazers_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/stargazers","contributors_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/contributors","subscribers_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/subscribers","subscription_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/subscription","commits_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/contents/{+path}","compare_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/merges","archive_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/downloads","issues_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/issues{/number}","pulls_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/pulls{/number}","milestones_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/milestones{/number}","notifications_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/labels{/name}","releases_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/releases{/id}","deployments_url":"https://api.github.com/repos/saichint/cisco-network-puppet-module/deployments","created_at":"2016-04-11T19:27:26Z","updated_at":"2016-04-11T19:27:27Z","pushed_at":"2016-09-29T17:14:20Z","git_url":"git://github.com/saichint/cisco-network-puppet-module.git","ssh_url":"git@github.com:saichint/cisco-network-puppet-module.git","clone_url":"https://github.com/saichint/cisco-network-puppet-module.git","svn_url":"https://github.com/saichint/cisco-network-puppet-module","homepage":null,"size":4372,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"cisco:develop","ref":"develop","sha":"2f1d60e358b7009bfedcf6175357603c9e115831","user":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"repo":{"id":39565139,"name":"cisco-network-puppet-module","full_name":"cisco/cisco-network-puppet-module","owner":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cisco/cisco-network-puppet-module","description":"","fork":false,"url":"https://api.github.com/repos/cisco/cisco-network-puppet-module","forks_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/forks","keys_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/teams","hooks_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/hooks","issue_events_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/events{/number}","events_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/events","assignees_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/assignees{/user}","branches_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/branches{/branch}","tags_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/tags","blobs_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/statuses/{sha}","languages_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/languages","stargazers_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/stargazers","contributors_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/contributors","subscribers_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/subscribers","subscription_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/subscription","commits_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/contents/{+path}","compare_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/merges","archive_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/downloads","issues_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues{/number}","pulls_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls{/number}","milestones_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/milestones{/number}","notifications_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/labels{/name}","releases_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/releases{/id}","deployments_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/deployments","created_at":"2015-07-23T12:06:48Z","updated_at":"2016-08-26T01:35:40Z","pushed_at":"2016-09-29T17:14:20Z","git_url":"git://github.com/cisco/cisco-network-puppet-module.git","ssh_url":"git@github.com:cisco/cisco-network-puppet-module.git","clone_url":"https://github.com/cisco/cisco-network-puppet-module.git","svn_url":"https://github.com/cisco/cisco-network-puppet-module","homepage":null,"size":5136,"stargazers_count":21,"watchers_count":21,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":2,"forks":38,"open_issues":2,"watchers":21,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/395"},"html":{"href":"https://github.com/cisco/cisco-network-puppet-module/pull/395"},"issue":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/395"},"comments":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/395/comments"},"review_comments":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/395/comments"},"review_comment":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/395/commits"},"statuses":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/statuses/33c065a5750ccf6dc5ba42d24f7d843ef0010293"}}}}
{"actor":{"display_login":"saichint"}}