{"action":"created","issue":{"url":"https://api.github.com/repos/broadinstitute/rawls/issues/308","repository_url":"https://api.github.com/repos/broadinstitute/rawls","labels_url":"https://api.github.com/repos/broadinstitute/rawls/issues/308/labels{/name}","comments_url":"https://api.github.com/repos/broadinstitute/rawls/issues/308/comments","events_url":"https://api.github.com/repos/broadinstitute/rawls/issues/308/events","html_url":"https://github.com/broadinstitute/rawls/pull/308","id":135569138,"number":308,"title":"Add realm to the workspace api.","user":{"login":"rushtong","id":116679,"avatar_url":"https://avatars.githubusercontent.com/u/116679?v=3","gravatar_id":"","url":"https://api.github.com/users/rushtong","html_url":"https://github.com/rushtong","followers_url":"https://api.github.com/users/rushtong/followers","following_url":"https://api.github.com/users/rushtong/following{/other_user}","gists_url":"https://api.github.com/users/rushtong/gists{/gist_id}","starred_url":"https://api.github.com/users/rushtong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rushtong/subscriptions","organizations_url":"https://api.github.com/users/rushtong/orgs","repos_url":"https://api.github.com/users/rushtong/repos","events_url":"https://api.github.com/users/rushtong/events{/privacy}","received_events_url":"https://api.github.com/users/rushtong/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-22T22:44:49Z","updated_at":"2016-02-22T22:51:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/broadinstitute/rawls/pulls/308","html_url":"https://github.com/broadinstitute/rawls/pull/308","diff_url":"https://github.com/broadinstitute/rawls/pull/308.diff","patch_url":"https://github.com/broadinstitute/rawls/pull/308.patch"},"body":"This PR for GAWB-285 merely adds a realm to the API and persists it. \r\nImplementation of the realm semantics with respect to ACLs is for GAWB-289. \r\nThis task is necessary for UI work to proceed without causing errors.\r\nOriginally submitted against develop, but we are now working off of a separate feature branch for this epic.\r\n\r\n- [x] **Submitter**: Rebase to develop. DO NOT SQUASH\r\n- [x] **Submitter**: Make sure Swagger is updated if API changes\r\n- [x] **Submitter**: Make sure documentation for code is complete\r\n- [x] **Submitter**: Review code comments; remove done TODOs, create stories for remaining TODOs\r\n- [x] **Submitter**: Include the JIRA issue number in the PR description\r\n- [x] **Submitter**: Add description or comments on the PR explaining the hows/whys (if not obvious)\r\n- [x] Tell ![](http://i.imgur.com/9dLzbPd.png) that the PR exists if he wants to look at it\r\n- [x] Anoint a lead reviewer (LR). **Assign PR to LR**\r\n- [x] **LR**: Initial review by LR and others.\r\n- [x] Comment / review / update cycle:\r\n  * Rest of team may comments on PR at will\r\n  * **LR assigns to submitter** for feedback fixes\r\n  * Submitter updates documentation as needed\r\n  * Submitter rebases to develop again if necessary\r\n  * Submitter makes further commits. DO NOT SQUASH. **Reassign to LR** for further feedback\r\n- [x] ![](http://i.imgur.com/9dLzbPd.png) sign off\r\n- [x] **LR** sign off\r\n- [x] **Assign to submitter** to finalize\r\n- [x] **Submitter**: Squash commits, rebase if necessary\r\n- [x] **Submitter**: Verify all tests go green, including CI tests\r\n- [ ] **Submitter**: Merge to realm \r\n- [ ] **Submitter**: Delete branch after merge\r\n- [x] **Submitter**: Check configuration files in Jenkins in case they need changes\r\n- [ ] **Submitter**: Verify swagger UI on dev server still works after deployment\r\n- [ ] **Submitter**: Inform other teams of any API changes via hipchat and/or email\r\n- [ ] **Submitter**: Mark JIRA issue as resolved once this checklist is completed"},"comment":{"url":"https://api.github.com/repos/broadinstitute/rawls/issues/comments/187424402","html_url":"https://github.com/broadinstitute/rawls/pull/308#issuecomment-187424402","issue_url":"https://api.github.com/repos/broadinstitute/rawls/issues/308","id":187424402,"user":{"login":"jmthibault79","id":2701406,"avatar_url":"https://avatars.githubusercontent.com/u/2701406?v=3","gravatar_id":"","url":"https://api.github.com/users/jmthibault79","html_url":"https://github.com/jmthibault79","followers_url":"https://api.github.com/users/jmthibault79/followers","following_url":"https://api.github.com/users/jmthibault79/following{/other_user}","gists_url":"https://api.github.com/users/jmthibault79/gists{/gist_id}","starred_url":"https://api.github.com/users/jmthibault79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmthibault79/subscriptions","organizations_url":"https://api.github.com/users/jmthibault79/orgs","repos_url":"https://api.github.com/users/jmthibault79/repos","events_url":"https://api.github.com/users/jmthibault79/events{/privacy}","received_events_url":"https://api.github.com/users/jmthibault79/received_events","type":"User","site_admin":false},"created_at":"2016-02-22T22:51:02Z","updated_at":"2016-02-22T22:51:02Z","body":"Can simplify the test but looks good otherwise."}}