{"action":"created","comment":{"url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/pulls/comments/54887884","id":54887884,"diff_hunk":"@@ -121,28 +133,27 @@ IrcBridge.prototype.run = Promise.coroutine(function*(port) {\n                 \"FATAL: Registration file is missing a sender_localpart and/or AS token.\"\n             );\n         }\n+        this.domain = this.config.homeserver.domain;\n+        this.appServiceUserId = (\n+            \"@\" + this.registration.getSenderLocalpart() + \":\" +\n+            this.config.homeserver.domain","path":"lib/bridge/instance.js","position":78,"original_position":78,"commit_id":"f897b7876501b642bc78ebf6d68fce10917de23d","original_commit_id":"f897b7876501b642bc78ebf6d68fce10917de23d","user":{"login":"Kegsay","id":7190048,"avatar_url":"https://avatars.githubusercontent.com/u/7190048?v=3","gravatar_id":"","url":"https://api.github.com/users/Kegsay","html_url":"https://github.com/Kegsay","followers_url":"https://api.github.com/users/Kegsay/followers","following_url":"https://api.github.com/users/Kegsay/following{/other_user}","gists_url":"https://api.github.com/users/Kegsay/gists{/gist_id}","starred_url":"https://api.github.com/users/Kegsay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kegsay/subscriptions","organizations_url":"https://api.github.com/users/Kegsay/orgs","repos_url":"https://api.github.com/users/Kegsay/repos","events_url":"https://api.github.com/users/Kegsay/events{/privacy}","received_events_url":"https://api.github.com/users/Kegsay/received_events","type":"User","site_admin":false},"body":"done","created_at":"2016-03-03T14:41:21Z","updated_at":"2016-03-03T14:41:21Z","html_url":"https://github.com/matrix-org/matrix-appservice-irc/pull/24#discussion_r54887884","pull_request_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/pulls/comments/54887884"},"html":{"href":"https://github.com/matrix-org/matrix-appservice-irc/pull/24#discussion_r54887884"},"pull_request":{"href":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/pulls/24","id":61564454,"html_url":"https://github.com/matrix-org/matrix-appservice-irc/pull/24","diff_url":"https://github.com/matrix-org/matrix-appservice-irc/pull/24.diff","patch_url":"https://github.com/matrix-org/matrix-appservice-irc/pull/24.patch","issue_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/issues/24","number":24,"state":"open","locked":false,"title":"Remove mxlib (Phase 1)","user":{"login":"Kegsay","id":7190048,"avatar_url":"https://avatars.githubusercontent.com/u/7190048?v=3","gravatar_id":"","url":"https://api.github.com/users/Kegsay","html_url":"https://github.com/Kegsay","followers_url":"https://api.github.com/users/Kegsay/followers","following_url":"https://api.github.com/users/Kegsay/following{/other_user}","gists_url":"https://api.github.com/users/Kegsay/gists{/gist_id}","starred_url":"https://api.github.com/users/Kegsay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kegsay/subscriptions","organizations_url":"https://api.github.com/users/Kegsay/orgs","repos_url":"https://api.github.com/users/Kegsay/repos","events_url":"https://api.github.com/users/Kegsay/events{/privacy}","received_events_url":"https://api.github.com/users/Kegsay/received_events","type":"User","site_admin":false},"body":"This is the first stage to removing `mxlib` entirely. Some functions have been removed. M->I and I->M logic is now instantiated and aren't singletons. The bridge now relies on `Intent` from the bridge lib.","created_at":"2016-03-03T14:15:08Z","updated_at":"2016-03-03T14:41:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c53e6c342c8e92d396de1ab5ec2bcd5bb95880b3","assignee":{"login":"illicitonion","id":1131704,"avatar_url":"https://avatars.githubusercontent.com/u/1131704?v=3","gravatar_id":"","url":"https://api.github.com/users/illicitonion","html_url":"https://github.com/illicitonion","followers_url":"https://api.github.com/users/illicitonion/followers","following_url":"https://api.github.com/users/illicitonion/following{/other_user}","gists_url":"https://api.github.com/users/illicitonion/gists{/gist_id}","starred_url":"https://api.github.com/users/illicitonion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/illicitonion/subscriptions","organizations_url":"https://api.github.com/users/illicitonion/orgs","repos_url":"https://api.github.com/users/illicitonion/repos","events_url":"https://api.github.com/users/illicitonion/events{/privacy}","received_events_url":"https://api.github.com/users/illicitonion/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/pulls/24/commits","review_comments_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/pulls/24/comments","review_comment_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/issues/24/comments","statuses_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/statuses/f897b7876501b642bc78ebf6d68fce10917de23d","head":{"label":"matrix-org:kegan/remove-mxlib","ref":"kegan/remove-mxlib","sha":"f897b7876501b642bc78ebf6d68fce10917de23d","user":{"login":"matrix-org","id":8418310,"avatar_url":"https://avatars.githubusercontent.com/u/8418310?v=3","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"repo":{"id":31962644,"name":"matrix-appservice-irc","full_name":"matrix-org/matrix-appservice-irc","owner":{"login":"matrix-org","id":8418310,"avatar_url":"https://avatars.githubusercontent.com/u/8418310?v=3","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matrix-org/matrix-appservice-irc","description":"Node.js IRC bridge for Matrix","fork":false,"url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc","forks_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/forks","keys_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/teams","hooks_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/hooks","issue_events_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/issues/events{/number}","events_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/events","assignees_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/assignees{/user}","branches_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/branches{/branch}","tags_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/tags","blobs_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/git/refs{/sha}","trees_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/statuses/{sha}","languages_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/languages","stargazers_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/stargazers","contributors_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/contributors","subscribers_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/subscribers","subscription_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/subscription","commits_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/commits{/sha}","git_commits_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/git/commits{/sha}","comments_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/comments{/number}","issue_comment_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/issues/comments{/number}","contents_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/contents/{+path}","compare_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/merges","archive_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/downloads","issues_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/issues{/number}","pulls_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/pulls{/number}","milestones_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/milestones{/number}","notifications_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/labels{/name}","releases_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/releases{/id}","deployments_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/deployments","created_at":"2015-03-10T14:42:06Z","updated_at":"2016-02-26T08:01:29Z","pushed_at":"2016-03-03T14:15:08Z","git_url":"git://github.com/matrix-org/matrix-appservice-irc.git","ssh_url":"git@github.com:matrix-org/matrix-appservice-irc.git","clone_url":"https://github.com/matrix-org/matrix-appservice-irc.git","svn_url":"https://github.com/matrix-org/matrix-appservice-irc","homepage":null,"size":914,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":16,"default_branch":"master"}},"base":{"label":"matrix-org:develop","ref":"develop","sha":"6a54a5bd2d5413dae980452dce8f5da5761c8181","user":{"login":"matrix-org","id":8418310,"avatar_url":"https://avatars.githubusercontent.com/u/8418310?v=3","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"repo":{"id":31962644,"name":"matrix-appservice-irc","full_name":"matrix-org/matrix-appservice-irc","owner":{"login":"matrix-org","id":8418310,"avatar_url":"https://avatars.githubusercontent.com/u/8418310?v=3","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matrix-org/matrix-appservice-irc","description":"Node.js IRC bridge for Matrix","fork":false,"url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc","forks_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/forks","keys_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/teams","hooks_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/hooks","issue_events_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/issues/events{/number}","events_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/events","assignees_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/assignees{/user}","branches_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/branches{/branch}","tags_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/tags","blobs_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/git/refs{/sha}","trees_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/statuses/{sha}","languages_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/languages","stargazers_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/stargazers","contributors_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/contributors","subscribers_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/subscribers","subscription_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/subscription","commits_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/commits{/sha}","git_commits_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/git/commits{/sha}","comments_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/comments{/number}","issue_comment_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/issues/comments{/number}","contents_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/contents/{+path}","compare_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/merges","archive_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/downloads","issues_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/issues{/number}","pulls_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/pulls{/number}","milestones_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/milestones{/number}","notifications_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/labels{/name}","releases_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/releases{/id}","deployments_url":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/deployments","created_at":"2015-03-10T14:42:06Z","updated_at":"2016-02-26T08:01:29Z","pushed_at":"2016-03-03T14:15:08Z","git_url":"git://github.com/matrix-org/matrix-appservice-irc.git","ssh_url":"git@github.com:matrix-org/matrix-appservice-irc.git","clone_url":"https://github.com/matrix-org/matrix-appservice-irc.git","svn_url":"https://github.com/matrix-org/matrix-appservice-irc","homepage":null,"size":914,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/pulls/24"},"html":{"href":"https://github.com/matrix-org/matrix-appservice-irc/pull/24"},"issue":{"href":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/issues/24"},"comments":{"href":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/matrix-org/matrix-appservice-irc/statuses/f897b7876501b642bc78ebf6d68fce10917de23d"}}}}