{"action":"created","comment":{"url":"https://api.github.com/repos/dcos/dcos-ui/pulls/comments/93473489","pull_request_review_id":14001926,"id":93473489,"diff_hunk":"@@ -1,11 +1,21 @@\n-xdescribe('Service Search Filters', function () {\n+describe('Service Search Filters', function () {\n+\n   context('Filters services table', function () {\n+\n+    function getSearchParameter(hash) {","path":"tests/pages/services/ServiceSearchFilter-cy.js","position":6,"original_position":6,"commit_id":"2406a7fc3d39624b099add7a17f2ada73f702a4e","original_commit_id":"2406a7fc3d39624b099add7a17f2ada73f702a4e","user":{"login":"orlandohohmeier","id":647035,"avatar_url":"https://avatars.githubusercontent.com/u/647035?v=3","gravatar_id":"","url":"https://api.github.com/users/orlandohohmeier","html_url":"https://github.com/orlandohohmeier","followers_url":"https://api.github.com/users/orlandohohmeier/followers","following_url":"https://api.github.com/users/orlandohohmeier/following{/other_user}","gists_url":"https://api.github.com/users/orlandohohmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/orlandohohmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlandohohmeier/subscriptions","organizations_url":"https://api.github.com/users/orlandohohmeier/orgs","repos_url":"https://api.github.com/users/orlandohohmeier/repos","events_url":"https://api.github.com/users/orlandohohmeier/events{/privacy}","received_events_url":"https://api.github.com/users/orlandohohmeier/received_events","type":"User","site_admin":false},"body":"Let's move this into our test utils and add a few unit test to verify that is actually finds the search parameter.","created_at":"2016-12-21T16:39:10Z","updated_at":"2016-12-21T16:39:49Z","html_url":"https://github.com/dcos/dcos-ui/pull/1645#discussion_r93473489","pull_request_url":"https://api.github.com/repos/dcos/dcos-ui/pulls/1645","_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/comments/93473489"},"html":{"href":"https://github.com/dcos/dcos-ui/pull/1645#discussion_r93473489"},"pull_request":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/1645"}}},"pull_request":{"url":"https://api.github.com/repos/dcos/dcos-ui/pulls/1645","id":98664550,"html_url":"https://github.com/dcos/dcos-ui/pull/1645","diff_url":"https://github.com/dcos/dcos-ui/pull/1645.diff","patch_url":"https://github.com/dcos/dcos-ui/pull/1645.patch","issue_url":"https://api.github.com/repos/dcos/dcos-ui/issues/1645","number":1645,"state":"open","locked":false,"title":"Fix integration tests for ServiceSearchFilter","user":{"login":"MatApple","id":465022,"avatar_url":"https://avatars.githubusercontent.com/u/465022?v=3","gravatar_id":"","url":"https://api.github.com/users/MatApple","html_url":"https://github.com/MatApple","followers_url":"https://api.github.com/users/MatApple/followers","following_url":"https://api.github.com/users/MatApple/following{/other_user}","gists_url":"https://api.github.com/users/MatApple/gists{/gist_id}","starred_url":"https://api.github.com/users/MatApple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatApple/subscriptions","organizations_url":"https://api.github.com/users/MatApple/orgs","repos_url":"https://api.github.com/users/MatApple/repos","events_url":"https://api.github.com/users/MatApple/events{/privacy}","received_events_url":"https://api.github.com/users/MatApple/received_events","type":"User","site_admin":false},"body":"![](https://cl.ly/2e1h3R2v0f1t/Image%202016-12-19%20at%204.10.16%20PM.png)","created_at":"2016-12-20T00:15:17Z","updated_at":"2016-12-21T16:44:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4167494f7769d0e6dc126459403431ca31e3d6f8","assignee":{"login":"rcorral","id":843202,"avatar_url":"https://avatars.githubusercontent.com/u/843202?v=3","gravatar_id":"","url":"https://api.github.com/users/rcorral","html_url":"https://github.com/rcorral","followers_url":"https://api.github.com/users/rcorral/followers","following_url":"https://api.github.com/users/rcorral/following{/other_user}","gists_url":"https://api.github.com/users/rcorral/gists{/gist_id}","starred_url":"https://api.github.com/users/rcorral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcorral/subscriptions","organizations_url":"https://api.github.com/users/rcorral/orgs","repos_url":"https://api.github.com/users/rcorral/repos","events_url":"https://api.github.com/users/rcorral/events{/privacy}","received_events_url":"https://api.github.com/users/rcorral/received_events","type":"User","site_admin":false},"assignees":[{"login":"rcorral","id":843202,"avatar_url":"https://avatars.githubusercontent.com/u/843202?v=3","gravatar_id":"","url":"https://api.github.com/users/rcorral","html_url":"https://github.com/rcorral","followers_url":"https://api.github.com/users/rcorral/followers","following_url":"https://api.github.com/users/rcorral/following{/other_user}","gists_url":"https://api.github.com/users/rcorral/gists{/gist_id}","starred_url":"https://api.github.com/users/rcorral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcorral/subscriptions","organizations_url":"https://api.github.com/users/rcorral/orgs","repos_url":"https://api.github.com/users/rcorral/repos","events_url":"https://api.github.com/users/rcorral/events{/privacy}","received_events_url":"https://api.github.com/users/rcorral/received_events","type":"User","site_admin":false},{"login":"mlunoe","id":1097941,"avatar_url":"https://avatars.githubusercontent.com/u/1097941?v=3","gravatar_id":"","url":"https://api.github.com/users/mlunoe","html_url":"https://github.com/mlunoe","followers_url":"https://api.github.com/users/mlunoe/followers","following_url":"https://api.github.com/users/mlunoe/following{/other_user}","gists_url":"https://api.github.com/users/mlunoe/gists{/gist_id}","starred_url":"https://api.github.com/users/mlunoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlunoe/subscriptions","organizations_url":"https://api.github.com/users/mlunoe/orgs","repos_url":"https://api.github.com/users/mlunoe/repos","events_url":"https://api.github.com/users/mlunoe/events{/privacy}","received_events_url":"https://api.github.com/users/mlunoe/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos-ui/pulls/1645/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos-ui/pulls/1645/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos-ui/issues/1645/comments","statuses_url":"https://api.github.com/repos/dcos/dcos-ui/statuses/2406a7fc3d39624b099add7a17f2ada73f702a4e","head":{"label":"dcos:mat/tests/ServiceSearchFilter","ref":"mat/tests/ServiceSearchFilter","sha":"2406a7fc3d39624b099add7a17f2ada73f702a4e","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56547504,"name":"dcos-ui","full_name":"dcos/dcos-ui","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos-ui","description":"The UI for The Datacenter Operating System","fork":false,"url":"https://api.github.com/repos/dcos/dcos-ui","forks_url":"https://api.github.com/repos/dcos/dcos-ui/forks","keys_url":"https://api.github.com/repos/dcos/dcos-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos-ui/teams","hooks_url":"https://api.github.com/repos/dcos/dcos-ui/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos-ui/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos-ui/events","assignees_url":"https://api.github.com/repos/dcos/dcos-ui/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos-ui/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos-ui/tags","blobs_url":"https://api.github.com/repos/dcos/dcos-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos-ui/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos-ui/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos-ui/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos-ui/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos-ui/subscription","commits_url":"https://api.github.com/repos/dcos/dcos-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos-ui/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos-ui/merges","archive_url":"https://api.github.com/repos/dcos/dcos-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos-ui/downloads","issues_url":"https://api.github.com/repos/dcos/dcos-ui/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos-ui/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos-ui/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos-ui/deployments","created_at":"2016-04-18T22:48:06Z","updated_at":"2016-12-16T15:53:31Z","pushed_at":"2016-12-21T16:38:52Z","git_url":"git://github.com/dcos/dcos-ui.git","ssh_url":"git@github.com:dcos/dcos-ui.git","clone_url":"https://github.com/dcos/dcos-ui.git","svn_url":"https://github.com/dcos/dcos-ui","homepage":null,"size":23096,"stargazers_count":114,"watchers_count":114,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":47,"forks":32,"open_issues":47,"watchers":114,"default_branch":"master"}},"base":{"label":"dcos:master","ref":"master","sha":"224913cd1188d1a0eef9f29619a5997c17476009","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56547504,"name":"dcos-ui","full_name":"dcos/dcos-ui","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos-ui","description":"The UI for The Datacenter Operating System","fork":false,"url":"https://api.github.com/repos/dcos/dcos-ui","forks_url":"https://api.github.com/repos/dcos/dcos-ui/forks","keys_url":"https://api.github.com/repos/dcos/dcos-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos-ui/teams","hooks_url":"https://api.github.com/repos/dcos/dcos-ui/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos-ui/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos-ui/events","assignees_url":"https://api.github.com/repos/dcos/dcos-ui/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos-ui/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos-ui/tags","blobs_url":"https://api.github.com/repos/dcos/dcos-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos-ui/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos-ui/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos-ui/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos-ui/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos-ui/subscription","commits_url":"https://api.github.com/repos/dcos/dcos-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos-ui/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos-ui/merges","archive_url":"https://api.github.com/repos/dcos/dcos-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos-ui/downloads","issues_url":"https://api.github.com/repos/dcos/dcos-ui/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos-ui/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos-ui/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos-ui/deployments","created_at":"2016-04-18T22:48:06Z","updated_at":"2016-12-16T15:53:31Z","pushed_at":"2016-12-21T16:38:52Z","git_url":"git://github.com/dcos/dcos-ui.git","ssh_url":"git@github.com:dcos/dcos-ui.git","clone_url":"https://github.com/dcos/dcos-ui.git","svn_url":"https://github.com/dcos/dcos-ui","homepage":null,"size":23096,"stargazers_count":114,"watchers_count":114,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":47,"forks":32,"open_issues":47,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/1645"},"html":{"href":"https://github.com/dcos/dcos-ui/pull/1645"},"issue":{"href":"https://api.github.com/repos/dcos/dcos-ui/issues/1645"},"comments":{"href":"https://api.github.com/repos/dcos/dcos-ui/issues/1645/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/1645/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/1645/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos-ui/statuses/2406a7fc3d39624b099add7a17f2ada73f702a4e"}}}}
{"actor":{"display_login":"orlandohohmeier"}}