{"action":"created","comment":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/comments/84240849","pull_request_review_id":5029528,"id":84240849,"diff_hunk":"@@ -45,7 +45,12 @@ public function validateConstraints($constraints)\n             switch ($name) {\n                 case 'minIntegerValue':\n                 case 'maxIntegerValue':\n-                    if ($value !== false && !is_integer($value)) {\n+                    // @deprecated false constraint value, see https://jira.ez.no/browse/EZP-26382","path":"eZ/Publish/Core/FieldType/Validator/IntegerValueValidator.php","position":25,"original_position":25,"commit_id":"227ee3c40e9b44786c9b62ae67877c320d7370bd","original_commit_id":"227ee3c40e9b44786c9b62ae67877c320d7370bd","user":{"login":"andrerom","id":289757,"avatar_url":"https://avatars.githubusercontent.com/u/289757?v=3","gravatar_id":"","url":"https://api.github.com/users/andrerom","html_url":"https://github.com/andrerom","followers_url":"https://api.github.com/users/andrerom/followers","following_url":"https://api.github.com/users/andrerom/following{/other_user}","gists_url":"https://api.github.com/users/andrerom/gists{/gist_id}","starred_url":"https://api.github.com/users/andrerom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrerom/subscriptions","organizations_url":"https://api.github.com/users/andrerom/orgs","repos_url":"https://api.github.com/users/andrerom/repos","events_url":"https://api.github.com/users/andrerom/events{/privacy}","received_events_url":"https://api.github.com/users/andrerom/received_events","type":"User","site_admin":false},"body":"@joaoinacio specifically @bdunogier is asking for something like:\r\nhttps://github.com/ezsystems/ezpublish-kernel/pull/1801/files#diff-e762cd40d2f3fd134400dd83c5032de5R45","created_at":"2016-10-20T09:09:56Z","updated_at":"2016-10-20T09:09:56Z","html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1808#discussion_r84240849","pull_request_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1808","_links":{"self":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/comments/84240849"},"html":{"href":"https://github.com/ezsystems/ezpublish-kernel/pull/1808#discussion_r84240849"},"pull_request":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1808"}}},"pull_request":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1808","id":90003100,"html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1808","diff_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1808.diff","patch_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1808.patch","issue_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1808","number":1808,"state":"open","locked":false,"title":"Fix EZP-26382: ContentType Draft sets IntegerValueValidator min/max to 0","user":{"login":"joaoinacio","id":1168342,"avatar_url":"https://avatars.githubusercontent.com/u/1168342?v=3","gravatar_id":"","url":"https://api.github.com/users/joaoinacio","html_url":"https://github.com/joaoinacio","followers_url":"https://api.github.com/users/joaoinacio/followers","following_url":"https://api.github.com/users/joaoinacio/following{/other_user}","gists_url":"https://api.github.com/users/joaoinacio/gists{/gist_id}","starred_url":"https://api.github.com/users/joaoinacio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaoinacio/subscriptions","organizations_url":"https://api.github.com/users/joaoinacio/orgs","repos_url":"https://api.github.com/users/joaoinacio/repos","events_url":"https://api.github.com/users/joaoinacio/events{/privacy}","received_events_url":"https://api.github.com/users/joaoinacio/received_events","type":"User","site_admin":false},"body":"JIRA: https://jira.ez.no/browse/EZP-26382\r\n\r\nReplaces #1792\r\n\r\nThis changes the `Integer` Field Type validator default from `false` to `null`, using the same logic as was done in eb5bbcdac288e3e1 for Float, but still allowing deprecated `false` value to be used.\r\nNo change to `Core/FieldType/Integer/Type.php` is needed as it was already done in cfd038a5991f7366","created_at":"2016-10-19T12:53:37Z","updated_at":"2016-10-20T09:09:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"732557c9a0b40f0fd9a8505eea3fc6ca47d9e7c6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1808/commits","review_comments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1808/comments","review_comment_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1808/comments","statuses_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/statuses/227ee3c40e9b44786c9b62ae67877c320d7370bd","head":{"label":"joaoinacio:ezp26382_int_ft_validator","ref":"ezp26382_int_ft_validator","sha":"227ee3c40e9b44786c9b62ae67877c320d7370bd","user":{"login":"joaoinacio","id":1168342,"avatar_url":"https://avatars.githubusercontent.com/u/1168342?v=3","gravatar_id":"","url":"https://api.github.com/users/joaoinacio","html_url":"https://github.com/joaoinacio","followers_url":"https://api.github.com/users/joaoinacio/followers","following_url":"https://api.github.com/users/joaoinacio/following{/other_user}","gists_url":"https://api.github.com/users/joaoinacio/gists{/gist_id}","starred_url":"https://api.github.com/users/joaoinacio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaoinacio/subscriptions","organizations_url":"https://api.github.com/users/joaoinacio/orgs","repos_url":"https://api.github.com/users/joaoinacio/repos","events_url":"https://api.github.com/users/joaoinacio/events{/privacy}","received_events_url":"https://api.github.com/users/joaoinacio/received_events","type":"User","site_admin":false},"repo":{"id":6478972,"name":"ezpublish-kernel","full_name":"joaoinacio/ezpublish-kernel","owner":{"login":"joaoinacio","id":1168342,"avatar_url":"https://avatars.githubusercontent.com/u/1168342?v=3","gravatar_id":"","url":"https://api.github.com/users/joaoinacio","html_url":"https://github.com/joaoinacio","followers_url":"https://api.github.com/users/joaoinacio/followers","following_url":"https://api.github.com/users/joaoinacio/following{/other_user}","gists_url":"https://api.github.com/users/joaoinacio/gists{/gist_id}","starred_url":"https://api.github.com/users/joaoinacio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaoinacio/subscriptions","organizations_url":"https://api.github.com/users/joaoinacio/orgs","repos_url":"https://api.github.com/users/joaoinacio/repos","events_url":"https://api.github.com/users/joaoinacio/events{/privacy}","received_events_url":"https://api.github.com/users/joaoinacio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joaoinacio/ezpublish-kernel","description":null,"fork":true,"url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel","forks_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/forks","keys_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/teams","hooks_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/hooks","issue_events_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/issues/events{/number}","events_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/events","assignees_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/assignees{/user}","branches_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/branches{/branch}","tags_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/tags","blobs_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/languages","stargazers_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/stargazers","contributors_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/contributors","subscribers_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/subscribers","subscription_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/subscription","commits_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/issues/comments{/number}","contents_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/contents/{+path}","compare_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/merges","archive_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/downloads","issues_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/issues{/number}","pulls_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/labels{/name}","releases_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/releases{/id}","deployments_url":"https://api.github.com/repos/joaoinacio/ezpublish-kernel/deployments","created_at":"2012-10-31T18:46:04Z","updated_at":"2015-04-14T15:52:18Z","pushed_at":"2016-10-19T12:48:54Z","git_url":"git://github.com/joaoinacio/ezpublish-kernel.git","ssh_url":"git@github.com:joaoinacio/ezpublish-kernel.git","clone_url":"https://github.com/joaoinacio/ezpublish-kernel.git","svn_url":"https://github.com/joaoinacio/ezpublish-kernel","homepage":"","size":46667,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ezsystems:6.5","ref":"6.5","sha":"d17ce1d404637fae21a74969746b094a65276fb4","user":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"repo":{"id":1663890,"name":"ezpublish-kernel","full_name":"ezsystems/ezpublish-kernel","owner":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezsystems/ezpublish-kernel","description":"Kernel (Repository, MVC layer, REST) for eZ Platform","fork":false,"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel","forks_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/forks","keys_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/teams","hooks_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/hooks","issue_events_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/events{/number}","events_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/events","assignees_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/assignees{/user}","branches_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/branches{/branch}","tags_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/tags","blobs_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/languages","stargazers_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/stargazers","contributors_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/contributors","subscribers_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/subscribers","subscription_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/subscription","commits_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/contents/{+path}","compare_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/merges","archive_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/downloads","issues_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues{/number}","pulls_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/labels{/name}","releases_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/releases{/id}","deployments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/deployments","created_at":"2011-04-26T08:54:24Z","updated_at":"2016-10-13T11:08:00Z","pushed_at":"2016-10-20T08:54:27Z","git_url":"git://github.com/ezsystems/ezpublish-kernel.git","ssh_url":"git@github.com:ezsystems/ezpublish-kernel.git","clone_url":"https://github.com/ezsystems/ezpublish-kernel.git","svn_url":"https://github.com/ezsystems/ezpublish-kernel","homepage":"http://ezplatform.com/","size":51594,"stargazers_count":116,"watchers_count":116,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":165,"mirror_url":null,"open_issues_count":70,"forks":165,"open_issues":70,"watchers":116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1808"},"html":{"href":"https://github.com/ezsystems/ezpublish-kernel/pull/1808"},"issue":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1808"},"comments":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1808/comments"},"review_comments":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1808/comments"},"review_comment":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1808/commits"},"statuses":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/statuses/227ee3c40e9b44786c9b62ae67877c320d7370bd"}}}}
{"actor":{"display_login":"andrerom"}}