{"action":"created","comment":{"url":"https://api.github.com/repos/cclib/cclib/pulls/comments/76528040","id":76528040,"diff_hunk":"@@ -59,266 +59,107 @@ def generate_repr(self):\n             cjson_dict['formula'] = self.pbmol.formula\n         # Incorporate Unit Cell into the chemical JSON\n \n-        # Helpers functions which use properties provided by cclib\n-        self.generate_properties(cjson_dict)\n-        self.generate_atoms(cjson_dict)\n-        self.generate_optimization(cjson_dict)\n-        self.generate_vibrations(cjson_dict)\n-        self.generate_bonds(cjson_dict)\n-        self.generate_transitions(cjson_dict)\n-        self.generate_fragments(cjson_dict)\n+        # Iterate through the attribute list present in ccData. Depending on the","path":"src/cclib/io/cjsonwriter.py","position":12,"original_position":12,"commit_id":"7ac50b4413e57145756d2b47da77ec45ee22b47e","original_commit_id":"7ac50b4413e57145756d2b47da77ec45ee22b47e","user":{"login":"langner","id":743698,"avatar_url":"https://avatars.githubusercontent.com/u/743698?v=3","gravatar_id":"","url":"https://api.github.com/users/langner","html_url":"https://github.com/langner","followers_url":"https://api.github.com/users/langner/followers","following_url":"https://api.github.com/users/langner/following{/other_user}","gists_url":"https://api.github.com/users/langner/gists{/gist_id}","starred_url":"https://api.github.com/users/langner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/langner/subscriptions","organizations_url":"https://api.github.com/users/langner/orgs","repos_url":"https://api.github.com/users/langner/repos","events_url":"https://api.github.com/users/langner/events{/privacy}","received_events_url":"https://api.github.com/users/langner/received_events","type":"User","site_admin":false},"body":"nit: please use complete sentence (missing period at end).","created_at":"2016-08-28T08:17:04Z","updated_at":"2016-08-28T08:17:04Z","html_url":"https://github.com/cclib/cclib/pull/332#discussion_r76528040","pull_request_url":"https://api.github.com/repos/cclib/cclib/pulls/332","_links":{"self":{"href":"https://api.github.com/repos/cclib/cclib/pulls/comments/76528040"},"html":{"href":"https://github.com/cclib/cclib/pull/332#discussion_r76528040"},"pull_request":{"href":"https://api.github.com/repos/cclib/cclib/pulls/332"}}},"pull_request":{"url":"https://api.github.com/repos/cclib/cclib/pulls/332","id":82989540,"html_url":"https://github.com/cclib/cclib/pull/332","diff_url":"https://github.com/cclib/cclib/pull/332.diff","patch_url":"https://github.com/cclib/cclib/pull/332.patch","issue_url":"https://api.github.com/repos/cclib/cclib/issues/332","number":332,"state":"open","locked":false,"title":"Cjson writer refactor","user":{"login":"Schamnad","id":7796078,"avatar_url":"https://avatars.githubusercontent.com/u/7796078?v=3","gravatar_id":"","url":"https://api.github.com/users/Schamnad","html_url":"https://github.com/Schamnad","followers_url":"https://api.github.com/users/Schamnad/followers","following_url":"https://api.github.com/users/Schamnad/following{/other_user}","gists_url":"https://api.github.com/users/Schamnad/gists{/gist_id}","starred_url":"https://api.github.com/users/Schamnad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Schamnad/subscriptions","organizations_url":"https://api.github.com/users/Schamnad/orgs","repos_url":"https://api.github.com/users/Schamnad/repos","events_url":"https://api.github.com/users/Schamnad/events{/privacy}","received_events_url":"https://api.github.com/users/Schamnad/received_events","type":"User","site_admin":false},"body":"Instead of explicitly detailing the CJSON structure within the CJSON writer, this refactor uses the attribute 'levels' present in the ccData attributes dictionary.","created_at":"2016-08-27T14:39:36Z","updated_at":"2016-08-28T08:17:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a69dd028253fd8727707682533bf3a0bde3e788","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cclib/cclib/milestones/10","html_url":"https://github.com/cclib/cclib/milestones/v1.5.1","labels_url":"https://api.github.com/repos/cclib/cclib/milestones/10/labels","id":1951955,"number":10,"title":"v1.5.1","description":"Things that did not get into v1.5.","creator":{"login":"langner","id":743698,"avatar_url":"https://avatars.githubusercontent.com/u/743698?v=3","gravatar_id":"","url":"https://api.github.com/users/langner","html_url":"https://github.com/langner","followers_url":"https://api.github.com/users/langner/followers","following_url":"https://api.github.com/users/langner/following{/other_user}","gists_url":"https://api.github.com/users/langner/gists{/gist_id}","starred_url":"https://api.github.com/users/langner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/langner/subscriptions","organizations_url":"https://api.github.com/users/langner/orgs","repos_url":"https://api.github.com/users/langner/repos","events_url":"https://api.github.com/users/langner/events{/privacy}","received_events_url":"https://api.github.com/users/langner/received_events","type":"User","site_admin":false},"open_issues":39,"closed_issues":1,"state":"open","created_at":"2016-08-19T16:41:56Z","updated_at":"2016-08-28T08:16:08Z","due_on":"2016-09-24T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cclib/cclib/pulls/332/commits","review_comments_url":"https://api.github.com/repos/cclib/cclib/pulls/332/comments","review_comment_url":"https://api.github.com/repos/cclib/cclib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cclib/cclib/issues/332/comments","statuses_url":"https://api.github.com/repos/cclib/cclib/statuses/7ac50b4413e57145756d2b47da77ec45ee22b47e","head":{"label":"Schamnad:cjsonWriterRefactor","ref":"cjsonWriterRefactor","sha":"7ac50b4413e57145756d2b47da77ec45ee22b47e","user":{"login":"Schamnad","id":7796078,"avatar_url":"https://avatars.githubusercontent.com/u/7796078?v=3","gravatar_id":"","url":"https://api.github.com/users/Schamnad","html_url":"https://github.com/Schamnad","followers_url":"https://api.github.com/users/Schamnad/followers","following_url":"https://api.github.com/users/Schamnad/following{/other_user}","gists_url":"https://api.github.com/users/Schamnad/gists{/gist_id}","starred_url":"https://api.github.com/users/Schamnad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Schamnad/subscriptions","organizations_url":"https://api.github.com/users/Schamnad/orgs","repos_url":"https://api.github.com/users/Schamnad/repos","events_url":"https://api.github.com/users/Schamnad/events{/privacy}","received_events_url":"https://api.github.com/users/Schamnad/received_events","type":"User","site_admin":false},"repo":{"id":59502896,"name":"cclib","full_name":"Schamnad/cclib","owner":{"login":"Schamnad","id":7796078,"avatar_url":"https://avatars.githubusercontent.com/u/7796078?v=3","gravatar_id":"","url":"https://api.github.com/users/Schamnad","html_url":"https://github.com/Schamnad","followers_url":"https://api.github.com/users/Schamnad/followers","following_url":"https://api.github.com/users/Schamnad/following{/other_user}","gists_url":"https://api.github.com/users/Schamnad/gists{/gist_id}","starred_url":"https://api.github.com/users/Schamnad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Schamnad/subscriptions","organizations_url":"https://api.github.com/users/Schamnad/orgs","repos_url":"https://api.github.com/users/Schamnad/repos","events_url":"https://api.github.com/users/Schamnad/events{/privacy}","received_events_url":"https://api.github.com/users/Schamnad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Schamnad/cclib","description":"Parsers and algorithms for computational chemistry logfiles","fork":true,"url":"https://api.github.com/repos/Schamnad/cclib","forks_url":"https://api.github.com/repos/Schamnad/cclib/forks","keys_url":"https://api.github.com/repos/Schamnad/cclib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Schamnad/cclib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Schamnad/cclib/teams","hooks_url":"https://api.github.com/repos/Schamnad/cclib/hooks","issue_events_url":"https://api.github.com/repos/Schamnad/cclib/issues/events{/number}","events_url":"https://api.github.com/repos/Schamnad/cclib/events","assignees_url":"https://api.github.com/repos/Schamnad/cclib/assignees{/user}","branches_url":"https://api.github.com/repos/Schamnad/cclib/branches{/branch}","tags_url":"https://api.github.com/repos/Schamnad/cclib/tags","blobs_url":"https://api.github.com/repos/Schamnad/cclib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Schamnad/cclib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Schamnad/cclib/git/refs{/sha}","trees_url":"https://api.github.com/repos/Schamnad/cclib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Schamnad/cclib/statuses/{sha}","languages_url":"https://api.github.com/repos/Schamnad/cclib/languages","stargazers_url":"https://api.github.com/repos/Schamnad/cclib/stargazers","contributors_url":"https://api.github.com/repos/Schamnad/cclib/contributors","subscribers_url":"https://api.github.com/repos/Schamnad/cclib/subscribers","subscription_url":"https://api.github.com/repos/Schamnad/cclib/subscription","commits_url":"https://api.github.com/repos/Schamnad/cclib/commits{/sha}","git_commits_url":"https://api.github.com/repos/Schamnad/cclib/git/commits{/sha}","comments_url":"https://api.github.com/repos/Schamnad/cclib/comments{/number}","issue_comment_url":"https://api.github.com/repos/Schamnad/cclib/issues/comments{/number}","contents_url":"https://api.github.com/repos/Schamnad/cclib/contents/{+path}","compare_url":"https://api.github.com/repos/Schamnad/cclib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Schamnad/cclib/merges","archive_url":"https://api.github.com/repos/Schamnad/cclib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Schamnad/cclib/downloads","issues_url":"https://api.github.com/repos/Schamnad/cclib/issues{/number}","pulls_url":"https://api.github.com/repos/Schamnad/cclib/pulls{/number}","milestones_url":"https://api.github.com/repos/Schamnad/cclib/milestones{/number}","notifications_url":"https://api.github.com/repos/Schamnad/cclib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Schamnad/cclib/labels{/name}","releases_url":"https://api.github.com/repos/Schamnad/cclib/releases{/id}","deployments_url":"https://api.github.com/repos/Schamnad/cclib/deployments","created_at":"2016-05-23T17:13:16Z","updated_at":"2016-05-23T17:13:35Z","pushed_at":"2016-08-27T14:34:48Z","git_url":"git://github.com/Schamnad/cclib.git","ssh_url":"git@github.com:Schamnad/cclib.git","clone_url":"https://github.com/Schamnad/cclib.git","svn_url":"https://github.com/Schamnad/cclib","homepage":"cclib.github.io","size":24980,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cclib:master","ref":"master","sha":"a4468167d34fbe5bb68776673e746914d1788fcd","user":{"login":"cclib","id":6282673,"avatar_url":"https://avatars.githubusercontent.com/u/6282673?v=3","gravatar_id":"","url":"https://api.github.com/users/cclib","html_url":"https://github.com/cclib","followers_url":"https://api.github.com/users/cclib/followers","following_url":"https://api.github.com/users/cclib/following{/other_user}","gists_url":"https://api.github.com/users/cclib/gists{/gist_id}","starred_url":"https://api.github.com/users/cclib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cclib/subscriptions","organizations_url":"https://api.github.com/users/cclib/orgs","repos_url":"https://api.github.com/users/cclib/repos","events_url":"https://api.github.com/users/cclib/events{/privacy}","received_events_url":"https://api.github.com/users/cclib/received_events","type":"Organization","site_admin":false},"repo":{"id":15514912,"name":"cclib","full_name":"cclib/cclib","owner":{"login":"cclib","id":6282673,"avatar_url":"https://avatars.githubusercontent.com/u/6282673?v=3","gravatar_id":"","url":"https://api.github.com/users/cclib","html_url":"https://github.com/cclib","followers_url":"https://api.github.com/users/cclib/followers","following_url":"https://api.github.com/users/cclib/following{/other_user}","gists_url":"https://api.github.com/users/cclib/gists{/gist_id}","starred_url":"https://api.github.com/users/cclib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cclib/subscriptions","organizations_url":"https://api.github.com/users/cclib/orgs","repos_url":"https://api.github.com/users/cclib/repos","events_url":"https://api.github.com/users/cclib/events{/privacy}","received_events_url":"https://api.github.com/users/cclib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cclib/cclib","description":"Parsers and algorithms for computational chemistry logfiles","fork":false,"url":"https://api.github.com/repos/cclib/cclib","forks_url":"https://api.github.com/repos/cclib/cclib/forks","keys_url":"https://api.github.com/repos/cclib/cclib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cclib/cclib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cclib/cclib/teams","hooks_url":"https://api.github.com/repos/cclib/cclib/hooks","issue_events_url":"https://api.github.com/repos/cclib/cclib/issues/events{/number}","events_url":"https://api.github.com/repos/cclib/cclib/events","assignees_url":"https://api.github.com/repos/cclib/cclib/assignees{/user}","branches_url":"https://api.github.com/repos/cclib/cclib/branches{/branch}","tags_url":"https://api.github.com/repos/cclib/cclib/tags","blobs_url":"https://api.github.com/repos/cclib/cclib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cclib/cclib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cclib/cclib/git/refs{/sha}","trees_url":"https://api.github.com/repos/cclib/cclib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cclib/cclib/statuses/{sha}","languages_url":"https://api.github.com/repos/cclib/cclib/languages","stargazers_url":"https://api.github.com/repos/cclib/cclib/stargazers","contributors_url":"https://api.github.com/repos/cclib/cclib/contributors","subscribers_url":"https://api.github.com/repos/cclib/cclib/subscribers","subscription_url":"https://api.github.com/repos/cclib/cclib/subscription","commits_url":"https://api.github.com/repos/cclib/cclib/commits{/sha}","git_commits_url":"https://api.github.com/repos/cclib/cclib/git/commits{/sha}","comments_url":"https://api.github.com/repos/cclib/cclib/comments{/number}","issue_comment_url":"https://api.github.com/repos/cclib/cclib/issues/comments{/number}","contents_url":"https://api.github.com/repos/cclib/cclib/contents/{+path}","compare_url":"https://api.github.com/repos/cclib/cclib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cclib/cclib/merges","archive_url":"https://api.github.com/repos/cclib/cclib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cclib/cclib/downloads","issues_url":"https://api.github.com/repos/cclib/cclib/issues{/number}","pulls_url":"https://api.github.com/repos/cclib/cclib/pulls{/number}","milestones_url":"https://api.github.com/repos/cclib/cclib/milestones{/number}","notifications_url":"https://api.github.com/repos/cclib/cclib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cclib/cclib/labels{/name}","releases_url":"https://api.github.com/repos/cclib/cclib/releases{/id}","deployments_url":"https://api.github.com/repos/cclib/cclib/deployments","created_at":"2013-12-29T20:59:14Z","updated_at":"2016-08-23T23:17:48Z","pushed_at":"2016-08-27T14:39:36Z","git_url":"git://github.com/cclib/cclib.git","ssh_url":"git@github.com:cclib/cclib.git","clone_url":"https://github.com/cclib/cclib.git","svn_url":"https://github.com/cclib/cclib","homepage":"cclib.github.io","size":31403,"stargazers_count":46,"watchers_count":46,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":61,"forks":39,"open_issues":61,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cclib/cclib/pulls/332"},"html":{"href":"https://github.com/cclib/cclib/pull/332"},"issue":{"href":"https://api.github.com/repos/cclib/cclib/issues/332"},"comments":{"href":"https://api.github.com/repos/cclib/cclib/issues/332/comments"},"review_comments":{"href":"https://api.github.com/repos/cclib/cclib/pulls/332/comments"},"review_comment":{"href":"https://api.github.com/repos/cclib/cclib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cclib/cclib/pulls/332/commits"},"statuses":{"href":"https://api.github.com/repos/cclib/cclib/statuses/7ac50b4413e57145756d2b47da77ec45ee22b47e"}}}}
{"actor":{"display_login":"langner"}}