{"action":"created","issue":{"url":"https://api.github.com/repos/catapult-project/catapult/issues/2953","repository_url":"https://api.github.com/repos/catapult-project/catapult","labels_url":"https://api.github.com/repos/catapult-project/catapult/issues/2953/labels{/name}","comments_url":"https://api.github.com/repos/catapult-project/catapult/issues/2953/comments","events_url":"https://api.github.com/repos/catapult-project/catapult/issues/2953/events","html_url":"https://github.com/catapult-project/catapult/issues/2953","id":184811400,"number":2953,"title":"Telemetry test does DNS lookups on the host against the live nework","user":{"login":"primiano","id":7137473,"avatar_url":"https://avatars.githubusercontent.com/u/7137473?v=3","gravatar_id":"","url":"https://api.github.com/users/primiano","html_url":"https://github.com/primiano","followers_url":"https://api.github.com/users/primiano/followers","following_url":"https://api.github.com/users/primiano/following{/other_user}","gists_url":"https://api.github.com/users/primiano/gists{/gist_id}","starred_url":"https://api.github.com/users/primiano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/primiano/subscriptions","organizations_url":"https://api.github.com/users/primiano/orgs","repos_url":"https://api.github.com/users/primiano/repos","events_url":"https://api.github.com/users/primiano/events{/privacy}","received_events_url":"https://api.github.com/users/primiano/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/catapult-project/catapult/labels/Bug","name":"Bug","color":"fc2929"},{"url":"https://api.github.com/repos/catapult-project/catapult/labels/Code%20Health","name":"Code Health","color":"fbca04"},{"url":"https://api.github.com/repos/catapult-project/catapult/labels/P1","name":"P1","color":"eb6420"},{"url":"https://api.github.com/repos/catapult-project/catapult/labels/Telemetry","name":"Telemetry","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2016-10-24T11:08:41Z","updated_at":"2016-10-27T13:05:16Z","closed_at":null,"body":"Background: [chromium-dev] telemetry_perf_unittests (Twitter) failing, stalling CQ. Caused by DNS DOS attack?\r\n\r\ntelemetry tests are flaky. @chromy (Hector) and I looked to this.\r\nOur telemetry pipeline looks like this:\r\n1) chrome on Android runs with --proxy-server=socks://localhost:NNN THe device has WiFi disabled. There is no way it can access the live network\r\n2) NNN is forwarded via the our forwarder magic to the host\r\n3) on the Host it hits TSProxy\r\n4) TSProxy does the traffic shaping and in turn fowards it to WebPageReplay\r\n5) WPR serves the data without hitting the network.\r\n\r\nThe problem here is that 4) (TSProxy) does hit the live network on the host.\r\nHector and I tcpdump'd it (`sudo tcpdump -i en1 -A -n udp port 53`) and we can see the DNS requests going live.\r\nAlso we managed to repro. while tsproxy is running, just do a curl --socks5 127.0.0.1:NNN http://aaaaaaaaaaaa.com and you will see tcpdump sending out a DNS request for http://aaaaaaaaaaaa.com.\r\n\r\nThe final effect seems to be that TSProxy actually introduces jitter and overall flakiness depending on the state of the network. which is bad. Our tests should be fully hermetic.\r\nRight now twitter is under DDoS and our tests are timing out.\r\n\r\n@nedn @anniesullie "},"comment":{"url":"https://api.github.com/repos/catapult-project/catapult/issues/comments/256634867","html_url":"https://github.com/catapult-project/catapult/issues/2953#issuecomment-256634867","issue_url":"https://api.github.com/repos/catapult-project/catapult/issues/2953","id":256634867,"user":{"login":"primiano","id":7137473,"avatar_url":"https://avatars.githubusercontent.com/u/7137473?v=3","gravatar_id":"","url":"https://api.github.com/users/primiano","html_url":"https://github.com/primiano","followers_url":"https://api.github.com/users/primiano/followers","following_url":"https://api.github.com/users/primiano/following{/other_user}","gists_url":"https://api.github.com/users/primiano/gists{/gist_id}","starred_url":"https://api.github.com/users/primiano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/primiano/subscriptions","organizations_url":"https://api.github.com/users/primiano/orgs","repos_url":"https://api.github.com/users/primiano/repos","events_url":"https://api.github.com/users/primiano/events{/privacy}","received_events_url":"https://api.github.com/users/primiano/received_events","type":"User","site_admin":false},"created_at":"2016-10-27T13:05:16Z","updated_at":"2016-10-27T13:05:16Z","body":"Ohh I see, thanks a lot for finding the culprit.\r\nAbout --ignore-certificate-errors, I think we did that in the past, and the we switched over. I don't remember the reason why we switched, but there might have been a reason.\r\nFrom \"https://codereview.chromium.org/1903773002\"\r\n\r\n>     Before on Linux, Chrome was opened with the --ignore-certificate-errors\r\n>    command line argument to ignore HTTPS certificate failure and still load\r\n>    the web page. But the HTTPS resources were not getting cached by design,\r\n>    unabling sandwich to run on Linux.\r\n\r\nI wonder if that caching thing would affect our benchmarks"}}
{"actor":{"display_login":"primiano"}}