{"action":"opened","number":2901,"pull_request":{"url":"https://api.github.com/repos/cuberite/cuberite/pulls/2901","id":56765323,"html_url":"https://github.com/cuberite/cuberite/pull/2901","diff_url":"https://github.com/cuberite/cuberite/pull/2901.diff","patch_url":"https://github.com/cuberite/cuberite/pull/2901.patch","issue_url":"https://api.github.com/repos/cuberite/cuberite/issues/2901","number":2901,"state":"open","locked":false,"title":"Fix running as a service.","user":{"login":"birkett","id":6772981,"avatar_url":"https://avatars.githubusercontent.com/u/6772981?v=3","gravatar_id":"","url":"https://api.github.com/users/birkett","html_url":"https://github.com/birkett","followers_url":"https://api.github.com/users/birkett/followers","following_url":"https://api.github.com/users/birkett/following{/other_user}","gists_url":"https://api.github.com/users/birkett/gists{/gist_id}","starred_url":"https://api.github.com/users/birkett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birkett/subscriptions","organizations_url":"https://api.github.com/users/birkett/orgs","repos_url":"https://api.github.com/users/birkett/repos","events_url":"https://api.github.com/users/birkett/events{/privacy}","received_events_url":"https://api.github.com/users/birkett/received_events","type":"User","site_admin":false},"body":"Two problems identified, both traced to commit 4315a11\r\nFixes #2900 \r\n\r\n(main.cpp) ParseArguments() was no longer being called before checking cRoot::m_RunAsService.\r\nThis led to m_RunAsService never being set (we use -d on the command line to instigate a service start).\r\n\r\n(Root.cpp) Terminate events were being ignored when running as a service.\r\nWe only need to ignore the cin.good() call, not terminate events as a whole.","created_at":"2016-01-21T15:35:32Z","updated_at":"2016-01-21T15:35:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cuberite/cuberite/pulls/2901/commits","review_comments_url":"https://api.github.com/repos/cuberite/cuberite/pulls/2901/comments","review_comment_url":"https://api.github.com/repos/cuberite/cuberite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cuberite/cuberite/issues/2901/comments","statuses_url":"https://api.github.com/repos/cuberite/cuberite/statuses/1ea289d1d594b6dc00c0df35cacf67606e1c416d","head":{"label":"birkett:servicefix","ref":"servicefix","sha":"1ea289d1d594b6dc00c0df35cacf67606e1c416d","user":{"login":"birkett","id":6772981,"avatar_url":"https://avatars.githubusercontent.com/u/6772981?v=3","gravatar_id":"","url":"https://api.github.com/users/birkett","html_url":"https://github.com/birkett","followers_url":"https://api.github.com/users/birkett/followers","following_url":"https://api.github.com/users/birkett/following{/other_user}","gists_url":"https://api.github.com/users/birkett/gists{/gist_id}","starred_url":"https://api.github.com/users/birkett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birkett/subscriptions","organizations_url":"https://api.github.com/users/birkett/orgs","repos_url":"https://api.github.com/users/birkett/repos","events_url":"https://api.github.com/users/birkett/events{/privacy}","received_events_url":"https://api.github.com/users/birkett/received_events","type":"User","site_admin":false},"repo":{"id":33180750,"name":"cuberite","full_name":"birkett/cuberite","owner":{"login":"birkett","id":6772981,"avatar_url":"https://avatars.githubusercontent.com/u/6772981?v=3","gravatar_id":"","url":"https://api.github.com/users/birkett","html_url":"https://github.com/birkett","followers_url":"https://api.github.com/users/birkett/followers","following_url":"https://api.github.com/users/birkett/following{/other_user}","gists_url":"https://api.github.com/users/birkett/gists{/gist_id}","starred_url":"https://api.github.com/users/birkett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birkett/subscriptions","organizations_url":"https://api.github.com/users/birkett/orgs","repos_url":"https://api.github.com/users/birkett/repos","events_url":"https://api.github.com/users/birkett/events{/privacy}","received_events_url":"https://api.github.com/users/birkett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/birkett/cuberite","description":"A performant C++ Minecraft Server","fork":true,"url":"https://api.github.com/repos/birkett/cuberite","forks_url":"https://api.github.com/repos/birkett/cuberite/forks","keys_url":"https://api.github.com/repos/birkett/cuberite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/birkett/cuberite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/birkett/cuberite/teams","hooks_url":"https://api.github.com/repos/birkett/cuberite/hooks","issue_events_url":"https://api.github.com/repos/birkett/cuberite/issues/events{/number}","events_url":"https://api.github.com/repos/birkett/cuberite/events","assignees_url":"https://api.github.com/repos/birkett/cuberite/assignees{/user}","branches_url":"https://api.github.com/repos/birkett/cuberite/branches{/branch}","tags_url":"https://api.github.com/repos/birkett/cuberite/tags","blobs_url":"https://api.github.com/repos/birkett/cuberite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/birkett/cuberite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/birkett/cuberite/git/refs{/sha}","trees_url":"https://api.github.com/repos/birkett/cuberite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/birkett/cuberite/statuses/{sha}","languages_url":"https://api.github.com/repos/birkett/cuberite/languages","stargazers_url":"https://api.github.com/repos/birkett/cuberite/stargazers","contributors_url":"https://api.github.com/repos/birkett/cuberite/contributors","subscribers_url":"https://api.github.com/repos/birkett/cuberite/subscribers","subscription_url":"https://api.github.com/repos/birkett/cuberite/subscription","commits_url":"https://api.github.com/repos/birkett/cuberite/commits{/sha}","git_commits_url":"https://api.github.com/repos/birkett/cuberite/git/commits{/sha}","comments_url":"https://api.github.com/repos/birkett/cuberite/comments{/number}","issue_comment_url":"https://api.github.com/repos/birkett/cuberite/issues/comments{/number}","contents_url":"https://api.github.com/repos/birkett/cuberite/contents/{+path}","compare_url":"https://api.github.com/repos/birkett/cuberite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/birkett/cuberite/merges","archive_url":"https://api.github.com/repos/birkett/cuberite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/birkett/cuberite/downloads","issues_url":"https://api.github.com/repos/birkett/cuberite/issues{/number}","pulls_url":"https://api.github.com/repos/birkett/cuberite/pulls{/number}","milestones_url":"https://api.github.com/repos/birkett/cuberite/milestones{/number}","notifications_url":"https://api.github.com/repos/birkett/cuberite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/birkett/cuberite/labels{/name}","releases_url":"https://api.github.com/repos/birkett/cuberite/releases{/id}","created_at":"2015-03-31T11:02:27Z","updated_at":"2016-01-21T13:17:50Z","pushed_at":"2016-01-21T15:22:59Z","git_url":"git://github.com/birkett/cuberite.git","ssh_url":"git@github.com:birkett/cuberite.git","clone_url":"https://github.com/birkett/cuberite.git","svn_url":"https://github.com/birkett/cuberite","homepage":"mc-server.org","size":78558,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cuberite:master","ref":"master","sha":"85e534b745c96985d9132fc6f05b2e0fa67048fd","user":{"login":"cuberite","id":8973961,"avatar_url":"https://avatars.githubusercontent.com/u/8973961?v=3","gravatar_id":"","url":"https://api.github.com/users/cuberite","html_url":"https://github.com/cuberite","followers_url":"https://api.github.com/users/cuberite/followers","following_url":"https://api.github.com/users/cuberite/following{/other_user}","gists_url":"https://api.github.com/users/cuberite/gists{/gist_id}","starred_url":"https://api.github.com/users/cuberite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuberite/subscriptions","organizations_url":"https://api.github.com/users/cuberite/orgs","repos_url":"https://api.github.com/users/cuberite/repos","events_url":"https://api.github.com/users/cuberite/events{/privacy}","received_events_url":"https://api.github.com/users/cuberite/received_events","type":"Organization","site_admin":false},"repo":{"id":11693709,"name":"cuberite","full_name":"cuberite/cuberite","owner":{"login":"cuberite","id":8973961,"avatar_url":"https://avatars.githubusercontent.com/u/8973961?v=3","gravatar_id":"","url":"https://api.github.com/users/cuberite","html_url":"https://github.com/cuberite","followers_url":"https://api.github.com/users/cuberite/followers","following_url":"https://api.github.com/users/cuberite/following{/other_user}","gists_url":"https://api.github.com/users/cuberite/gists{/gist_id}","starred_url":"https://api.github.com/users/cuberite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuberite/subscriptions","organizations_url":"https://api.github.com/users/cuberite/orgs","repos_url":"https://api.github.com/users/cuberite/repos","events_url":"https://api.github.com/users/cuberite/events{/privacy}","received_events_url":"https://api.github.com/users/cuberite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cuberite/cuberite","description":"A performant C++ Minecraft compatible game server","fork":false,"url":"https://api.github.com/repos/cuberite/cuberite","forks_url":"https://api.github.com/repos/cuberite/cuberite/forks","keys_url":"https://api.github.com/repos/cuberite/cuberite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cuberite/cuberite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cuberite/cuberite/teams","hooks_url":"https://api.github.com/repos/cuberite/cuberite/hooks","issue_events_url":"https://api.github.com/repos/cuberite/cuberite/issues/events{/number}","events_url":"https://api.github.com/repos/cuberite/cuberite/events","assignees_url":"https://api.github.com/repos/cuberite/cuberite/assignees{/user}","branches_url":"https://api.github.com/repos/cuberite/cuberite/branches{/branch}","tags_url":"https://api.github.com/repos/cuberite/cuberite/tags","blobs_url":"https://api.github.com/repos/cuberite/cuberite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cuberite/cuberite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cuberite/cuberite/git/refs{/sha}","trees_url":"https://api.github.com/repos/cuberite/cuberite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cuberite/cuberite/statuses/{sha}","languages_url":"https://api.github.com/repos/cuberite/cuberite/languages","stargazers_url":"https://api.github.com/repos/cuberite/cuberite/stargazers","contributors_url":"https://api.github.com/repos/cuberite/cuberite/contributors","subscribers_url":"https://api.github.com/repos/cuberite/cuberite/subscribers","subscription_url":"https://api.github.com/repos/cuberite/cuberite/subscription","commits_url":"https://api.github.com/repos/cuberite/cuberite/commits{/sha}","git_commits_url":"https://api.github.com/repos/cuberite/cuberite/git/commits{/sha}","comments_url":"https://api.github.com/repos/cuberite/cuberite/comments{/number}","issue_comment_url":"https://api.github.com/repos/cuberite/cuberite/issues/comments{/number}","contents_url":"https://api.github.com/repos/cuberite/cuberite/contents/{+path}","compare_url":"https://api.github.com/repos/cuberite/cuberite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cuberite/cuberite/merges","archive_url":"https://api.github.com/repos/cuberite/cuberite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cuberite/cuberite/downloads","issues_url":"https://api.github.com/repos/cuberite/cuberite/issues{/number}","pulls_url":"https://api.github.com/repos/cuberite/cuberite/pulls{/number}","milestones_url":"https://api.github.com/repos/cuberite/cuberite/milestones{/number}","notifications_url":"https://api.github.com/repos/cuberite/cuberite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cuberite/cuberite/labels{/name}","releases_url":"https://api.github.com/repos/cuberite/cuberite/releases{/id}","created_at":"2013-07-26T19:56:59Z","updated_at":"2016-01-21T08:06:58Z","pushed_at":"2016-01-21T06:21:41Z","git_url":"git://github.com/cuberite/cuberite.git","ssh_url":"git@github.com:cuberite/cuberite.git","clone_url":"https://github.com/cuberite/cuberite.git","svn_url":"https://github.com/cuberite/cuberite","homepage":"http://cuberite.org","size":147751,"stargazers_count":1079,"watchers_count":1079,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":270,"mirror_url":null,"open_issues_count":439,"forks":270,"open_issues":439,"watchers":1079,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cuberite/cuberite/pulls/2901"},"html":{"href":"https://github.com/cuberite/cuberite/pull/2901"},"issue":{"href":"https://api.github.com/repos/cuberite/cuberite/issues/2901"},"comments":{"href":"https://api.github.com/repos/cuberite/cuberite/issues/2901/comments"},"review_comments":{"href":"https://api.github.com/repos/cuberite/cuberite/pulls/2901/comments"},"review_comment":{"href":"https://api.github.com/repos/cuberite/cuberite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cuberite/cuberite/pulls/2901/commits"},"statuses":{"href":"https://api.github.com/repos/cuberite/cuberite/statuses/1ea289d1d594b6dc00c0df35cacf67606e1c416d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":10,"deletions":10,"changed_files":2}}