{"action":"created","comment":{"url":"https://api.github.com/repos/lytics/ember-components/pulls/comments/53990707","id":53990707,"diff_hunk":"@@ -167,38 +167,38 @@ test(\"there must be exactly two option components\", function() {\n   }, /The 'lio-toggle' component must contain at exactly two 'lio-option' components./);\n });\n \n-test(\"transition classes are added when toggling\", function() {\n-  mockGlobalPath('$.support.transition', { end: 'testEvent' }, this, function() {\n-    var component = this.subject({\n-      value: true,\n-      layout: template1\n-    });\n-\n-    this.$();\n-\n-    var triggerTransitionEnd = function() {\n-      component.componentsForType('option').invoke('trigger', 'transitionDidEnd');\n-    };\n-\n-    Ember.run(component, 'send', 'toggle');\n-    ok(this.$().find('lio-option:nth-of-type(1)').hasClass('deactivating'), \"the first option has the 'deactivating' class\");\n-    ok(this.$().find('lio-option:nth-of-type(2)').hasClass('activating'), \"the second option has the 'activating' class\");\n-    ok(this.$().find('lio-option:nth-of-type(1)').hasClass('active'), \"the first option has the 'active' class\");\n-    ok(!this.$().find('lio-option:nth-of-type(2)').hasClass('active'), \"the second option does not have the 'active' class\");\n-    Ember.run(triggerTransitionEnd);\n-    ok(!this.$().find('lio-option:nth-of-type(1)').hasClass('deactivating'), \"the first option does not have the 'deactivating' class\");\n-    ok(!this.$().find('lio-option:nth-of-type(2)').hasClass('activating'), \"the second option does not have the 'activating' class\");\n-    ok(!this.$().find('lio-option:nth-of-type(1)').hasClass('active'), \"the first option does not have the 'active' class\");\n-    ok(this.$().find('lio-option:nth-of-type(2)').hasClass('active'), \"the second option has the 'active' class\");\n-    Ember.run(component, 'send', 'toggle');\n-    ok(this.$().find('lio-option:nth-of-type(1)').hasClass('activating'), \"the first option has the 'activating' class\");\n-    ok(this.$().find('lio-option:nth-of-type(2)').hasClass('deactivating'), \"the second option has the 'deactivating' class\");\n-    ok(!this.$().find('lio-option:nth-of-type(1)').hasClass('active'), \"the first option does not have the 'active' class\");\n-    ok(this.$().find('lio-option:nth-of-type(2)').hasClass('active'), \"the second option has the 'active' class\");\n-    Ember.run(triggerTransitionEnd);\n-    ok(!this.$().find('lio-option:nth-of-type(1)').hasClass('activating'), \"the first option does not have the 'activating' class\");\n-    ok(!this.$().find('lio-option:nth-of-type(2)').hasClass('deactivating'), \"the second option does not have the 'deactivating' class\");\n-    ok(this.$().find('lio-option:nth-of-type(1)').hasClass('active'), \"the first option has the 'active' class\");\n-    ok(!this.$().find('lio-option:nth-of-type(2)').hasClass('active'), \"the second option does not have the 'active' class\");\n-  });\n-});\n+// test(\"transition classes are added when toggling\", function() {\n+//   mockGlobalPath('$.support.transition', { end: 'testEvent' }, this, function() {\n+//     var component = this.subject({\n+//       value: true,\n+//       layout: template1\n+//     });\n+\n+//     this.$();\n+\n+//     var triggerTransitionEnd = function() {\n+//       component.componentsForType('option').invoke('trigger', 'transitionDidEnd');\n+//     };\n+\n+//     Ember.run(component, 'send', 'toggle');\n+//     ok(this.$().find('lio-option:nth-of-type(1)').hasClass('deactivating'), \"the first option has the 'deactivating' class\");\n+//     ok(this.$().find('lio-option:nth-of-type(2)').hasClass('activating'), \"the second option has the 'activating' class\");\n+//     ok(this.$().find('lio-option:nth-of-type(1)').hasClass('active'), \"the first option has the 'active' class\");\n+//     ok(!this.$().find('lio-option:nth-of-type(2)').hasClass('active'), \"the second option does not have the 'active' class\");\n+//     Ember.run(triggerTransitionEnd);\n+//     ok(!this.$().find('lio-option:nth-of-type(1)').hasClass('deactivating'), \"the first option does not have the 'deactivating' class\");\n+//     ok(!this.$().find('lio-option:nth-of-type(2)').hasClass('activating'), \"the second option does not have the 'activating' class\");\n+//     ok(!this.$().find('lio-option:nth-of-type(1)').hasClass('active'), \"the first option does not have the 'active' class\");\n+//     ok(this.$().find('lio-option:nth-of-type(2)').hasClass('active'), \"the second option has the 'active' class\");\n+//     Ember.run(component, 'send', 'toggle');\n+//     ok(this.$().find('lio-option:nth-of-type(1)').hasClass('activating'), \"the first option has the 'activating' class\");\n+//     ok(this.$().find('lio-option:nth-of-type(2)').hasClass('deactivating'), \"the second option has the 'deactivating' class\");\n+//     ok(!this.$().find('lio-option:nth-of-type(1)').hasClass('active'), \"the first option does not have the 'active' class\");\n+//     ok(this.$().find('lio-option:nth-of-type(2)').hasClass('active'), \"the second option has the 'active' class\");\n+//     Ember.run(triggerTransitionEnd);\n+//     ok(!this.$().find('lio-option:nth-of-type(1)').hasClass('activating'), \"the first option does not have the 'activating' class\");\n+//     ok(!this.$().find('lio-option:nth-of-type(2)').hasClass('deactivating'), \"the second option does not have the 'deactivating' class\");\n+//     ok(this.$().find('lio-option:nth-of-type(1)').hasClass('active'), \"the first option has the 'active' class\");\n+//     ok(!this.$().find('lio-option:nth-of-type(2)').hasClass('active'), \"the second option does not have the 'active' class\");\n+//   });\n+// });","path":"tests/unit/components/lio-toggle-test.js","position":73,"original_position":73,"commit_id":"fcf2c159d893588688eb179651bcb92ffc27ee98","original_commit_id":"fcf2c159d893588688eb179651bcb92ffc27ee98","user":{"login":"DingoEatingFuzz","id":174740,"avatar_url":"https://avatars.githubusercontent.com/u/174740?v=3","gravatar_id":"","url":"https://api.github.com/users/DingoEatingFuzz","html_url":"https://github.com/DingoEatingFuzz","followers_url":"https://api.github.com/users/DingoEatingFuzz/followers","following_url":"https://api.github.com/users/DingoEatingFuzz/following{/other_user}","gists_url":"https://api.github.com/users/DingoEatingFuzz/gists{/gist_id}","starred_url":"https://api.github.com/users/DingoEatingFuzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DingoEatingFuzz/subscriptions","organizations_url":"https://api.github.com/users/DingoEatingFuzz/orgs","repos_url":"https://api.github.com/users/DingoEatingFuzz/repos","events_url":"https://api.github.com/users/DingoEatingFuzz/events{/privacy}","received_events_url":"https://api.github.com/users/DingoEatingFuzz/received_events","type":"User","site_admin":false},"body":"Also, when skipping tests, can you add a TODO comment explaining why these tests are being skipped?","created_at":"2016-02-24T19:16:27Z","updated_at":"2016-02-24T19:16:27Z","html_url":"https://github.com/lytics/ember-components/pull/30#discussion_r53990707","pull_request_url":"https://api.github.com/repos/lytics/ember-components/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/lytics/ember-components/pulls/comments/53990707"},"html":{"href":"https://github.com/lytics/ember-components/pull/30#discussion_r53990707"},"pull_request":{"href":"https://api.github.com/repos/lytics/ember-components/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/lytics/ember-components/pulls/30","id":60218502,"html_url":"https://github.com/lytics/ember-components/pull/30","diff_url":"https://github.com/lytics/ember-components/pull/30.diff","patch_url":"https://github.com/lytics/ember-components/pull/30.patch","issue_url":"https://api.github.com/repos/lytics/ember-components/issues/30","number":30,"state":"open","locked":false,"title":"1589 popover bugs","user":{"login":"BordRGal32","id":6750498,"avatar_url":"https://avatars.githubusercontent.com/u/6750498?v=3","gravatar_id":"","url":"https://api.github.com/users/BordRGal32","html_url":"https://github.com/BordRGal32","followers_url":"https://api.github.com/users/BordRGal32/followers","following_url":"https://api.github.com/users/BordRGal32/following{/other_user}","gists_url":"https://api.github.com/users/BordRGal32/gists{/gist_id}","starred_url":"https://api.github.com/users/BordRGal32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BordRGal32/subscriptions","organizations_url":"https://api.github.com/users/BordRGal32/orgs","repos_url":"https://api.github.com/users/BordRGal32/repos","events_url":"https://api.github.com/users/BordRGal32/events{/privacy}","received_events_url":"https://api.github.com/users/BordRGal32/received_events","type":"User","site_admin":false},"body":"Compare with #28. \r\n\r\nThis PR addresses several bugs with the lio-popover. \r\n\r\n1. Triggers CSS transition before calling into the Transition mixin. Before we were waiting to trigger the transition until support.transition.did.end was called for that transition - aka we were waiting on a transition that had not been started. \r\n\r\n2. Accounts for arrow width when we force the arrow position to be over the anchor. \r\n\r\n3. Updates some CSS.\r\n\r\n4. Repositions the popover when the popover is active on init. ","created_at":"2016-02-22T18:32:16Z","updated_at":"2016-02-24T19:16:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4d2fdb27a40ac64148c3bbfae4b01412a4abe98","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lytics/ember-components/pulls/30/commits","review_comments_url":"https://api.github.com/repos/lytics/ember-components/pulls/30/comments","review_comment_url":"https://api.github.com/repos/lytics/ember-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lytics/ember-components/issues/30/comments","statuses_url":"https://api.github.com/repos/lytics/ember-components/statuses/fcf2c159d893588688eb179651bcb92ffc27ee98","head":{"label":"lytics:1589-popover-bugs","ref":"1589-popover-bugs","sha":"fcf2c159d893588688eb179651bcb92ffc27ee98","user":{"login":"lytics","id":1951824,"avatar_url":"https://avatars.githubusercontent.com/u/1951824?v=3","gravatar_id":"","url":"https://api.github.com/users/lytics","html_url":"https://github.com/lytics","followers_url":"https://api.github.com/users/lytics/followers","following_url":"https://api.github.com/users/lytics/following{/other_user}","gists_url":"https://api.github.com/users/lytics/gists{/gist_id}","starred_url":"https://api.github.com/users/lytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lytics/subscriptions","organizations_url":"https://api.github.com/users/lytics/orgs","repos_url":"https://api.github.com/users/lytics/repos","events_url":"https://api.github.com/users/lytics/events{/privacy}","received_events_url":"https://api.github.com/users/lytics/received_events","type":"Organization","site_admin":false},"repo":{"id":18898313,"name":"ember-components","full_name":"lytics/ember-components","owner":{"login":"lytics","id":1951824,"avatar_url":"https://avatars.githubusercontent.com/u/1951824?v=3","gravatar_id":"","url":"https://api.github.com/users/lytics","html_url":"https://github.com/lytics","followers_url":"https://api.github.com/users/lytics/followers","following_url":"https://api.github.com/users/lytics/following{/other_user}","gists_url":"https://api.github.com/users/lytics/gists{/gist_id}","starred_url":"https://api.github.com/users/lytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lytics/subscriptions","organizations_url":"https://api.github.com/users/lytics/orgs","repos_url":"https://api.github.com/users/lytics/repos","events_url":"https://api.github.com/users/lytics/events{/privacy}","received_events_url":"https://api.github.com/users/lytics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lytics/ember-components","description":"Ember-Components","fork":false,"url":"https://api.github.com/repos/lytics/ember-components","forks_url":"https://api.github.com/repos/lytics/ember-components/forks","keys_url":"https://api.github.com/repos/lytics/ember-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lytics/ember-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lytics/ember-components/teams","hooks_url":"https://api.github.com/repos/lytics/ember-components/hooks","issue_events_url":"https://api.github.com/repos/lytics/ember-components/issues/events{/number}","events_url":"https://api.github.com/repos/lytics/ember-components/events","assignees_url":"https://api.github.com/repos/lytics/ember-components/assignees{/user}","branches_url":"https://api.github.com/repos/lytics/ember-components/branches{/branch}","tags_url":"https://api.github.com/repos/lytics/ember-components/tags","blobs_url":"https://api.github.com/repos/lytics/ember-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lytics/ember-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lytics/ember-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/lytics/ember-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lytics/ember-components/statuses/{sha}","languages_url":"https://api.github.com/repos/lytics/ember-components/languages","stargazers_url":"https://api.github.com/repos/lytics/ember-components/stargazers","contributors_url":"https://api.github.com/repos/lytics/ember-components/contributors","subscribers_url":"https://api.github.com/repos/lytics/ember-components/subscribers","subscription_url":"https://api.github.com/repos/lytics/ember-components/subscription","commits_url":"https://api.github.com/repos/lytics/ember-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/lytics/ember-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/lytics/ember-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/lytics/ember-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/lytics/ember-components/contents/{+path}","compare_url":"https://api.github.com/repos/lytics/ember-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lytics/ember-components/merges","archive_url":"https://api.github.com/repos/lytics/ember-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lytics/ember-components/downloads","issues_url":"https://api.github.com/repos/lytics/ember-components/issues{/number}","pulls_url":"https://api.github.com/repos/lytics/ember-components/pulls{/number}","milestones_url":"https://api.github.com/repos/lytics/ember-components/milestones{/number}","notifications_url":"https://api.github.com/repos/lytics/ember-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lytics/ember-components/labels{/name}","releases_url":"https://api.github.com/repos/lytics/ember-components/releases{/id}","deployments_url":"https://api.github.com/repos/lytics/ember-components/deployments","created_at":"2014-04-18T00:57:47Z","updated_at":"2016-02-24T17:16:10Z","pushed_at":"2016-02-24T17:20:41Z","git_url":"git://github.com/lytics/ember-components.git","ssh_url":"git@github.com:lytics/ember-components.git","clone_url":"https://github.com/lytics/ember-components.git","svn_url":"https://github.com/lytics/ember-components","homepage":null,"size":269,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"lytics:master","ref":"master","sha":"8f294e1dcff3337d0c697302037594995ad43d26","user":{"login":"lytics","id":1951824,"avatar_url":"https://avatars.githubusercontent.com/u/1951824?v=3","gravatar_id":"","url":"https://api.github.com/users/lytics","html_url":"https://github.com/lytics","followers_url":"https://api.github.com/users/lytics/followers","following_url":"https://api.github.com/users/lytics/following{/other_user}","gists_url":"https://api.github.com/users/lytics/gists{/gist_id}","starred_url":"https://api.github.com/users/lytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lytics/subscriptions","organizations_url":"https://api.github.com/users/lytics/orgs","repos_url":"https://api.github.com/users/lytics/repos","events_url":"https://api.github.com/users/lytics/events{/privacy}","received_events_url":"https://api.github.com/users/lytics/received_events","type":"Organization","site_admin":false},"repo":{"id":18898313,"name":"ember-components","full_name":"lytics/ember-components","owner":{"login":"lytics","id":1951824,"avatar_url":"https://avatars.githubusercontent.com/u/1951824?v=3","gravatar_id":"","url":"https://api.github.com/users/lytics","html_url":"https://github.com/lytics","followers_url":"https://api.github.com/users/lytics/followers","following_url":"https://api.github.com/users/lytics/following{/other_user}","gists_url":"https://api.github.com/users/lytics/gists{/gist_id}","starred_url":"https://api.github.com/users/lytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lytics/subscriptions","organizations_url":"https://api.github.com/users/lytics/orgs","repos_url":"https://api.github.com/users/lytics/repos","events_url":"https://api.github.com/users/lytics/events{/privacy}","received_events_url":"https://api.github.com/users/lytics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lytics/ember-components","description":"Ember-Components","fork":false,"url":"https://api.github.com/repos/lytics/ember-components","forks_url":"https://api.github.com/repos/lytics/ember-components/forks","keys_url":"https://api.github.com/repos/lytics/ember-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lytics/ember-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lytics/ember-components/teams","hooks_url":"https://api.github.com/repos/lytics/ember-components/hooks","issue_events_url":"https://api.github.com/repos/lytics/ember-components/issues/events{/number}","events_url":"https://api.github.com/repos/lytics/ember-components/events","assignees_url":"https://api.github.com/repos/lytics/ember-components/assignees{/user}","branches_url":"https://api.github.com/repos/lytics/ember-components/branches{/branch}","tags_url":"https://api.github.com/repos/lytics/ember-components/tags","blobs_url":"https://api.github.com/repos/lytics/ember-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lytics/ember-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lytics/ember-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/lytics/ember-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lytics/ember-components/statuses/{sha}","languages_url":"https://api.github.com/repos/lytics/ember-components/languages","stargazers_url":"https://api.github.com/repos/lytics/ember-components/stargazers","contributors_url":"https://api.github.com/repos/lytics/ember-components/contributors","subscribers_url":"https://api.github.com/repos/lytics/ember-components/subscribers","subscription_url":"https://api.github.com/repos/lytics/ember-components/subscription","commits_url":"https://api.github.com/repos/lytics/ember-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/lytics/ember-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/lytics/ember-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/lytics/ember-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/lytics/ember-components/contents/{+path}","compare_url":"https://api.github.com/repos/lytics/ember-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lytics/ember-components/merges","archive_url":"https://api.github.com/repos/lytics/ember-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lytics/ember-components/downloads","issues_url":"https://api.github.com/repos/lytics/ember-components/issues{/number}","pulls_url":"https://api.github.com/repos/lytics/ember-components/pulls{/number}","milestones_url":"https://api.github.com/repos/lytics/ember-components/milestones{/number}","notifications_url":"https://api.github.com/repos/lytics/ember-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lytics/ember-components/labels{/name}","releases_url":"https://api.github.com/repos/lytics/ember-components/releases{/id}","deployments_url":"https://api.github.com/repos/lytics/ember-components/deployments","created_at":"2014-04-18T00:57:47Z","updated_at":"2016-02-24T17:16:10Z","pushed_at":"2016-02-24T17:20:41Z","git_url":"git://github.com/lytics/ember-components.git","ssh_url":"git@github.com:lytics/ember-components.git","clone_url":"https://github.com/lytics/ember-components.git","svn_url":"https://github.com/lytics/ember-components","homepage":null,"size":269,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lytics/ember-components/pulls/30"},"html":{"href":"https://github.com/lytics/ember-components/pull/30"},"issue":{"href":"https://api.github.com/repos/lytics/ember-components/issues/30"},"comments":{"href":"https://api.github.com/repos/lytics/ember-components/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/lytics/ember-components/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/lytics/ember-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lytics/ember-components/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/lytics/ember-components/statuses/fcf2c159d893588688eb179651bcb92ffc27ee98"}}}}