{"action":"created","comment":{"url":"https://api.github.com/repos/evansde77/cirrus/pulls/comments/74497207","id":74497207,"diff_hunk":"@@ -148,9 +176,78 @@ def _docker_build(path, tag, base_tag):\n     LOGGER.info(stdout)\n     image = find_image_id(base_tag)\n     LOGGER.info(\"Image ID: {}\".format(image))\n+\n+    if not is_docker_version_installed('1.17.0'):","path":"src/cirrus/docker.py","position":65,"original_position":65,"commit_id":"a42f2fbfe2a685e9acea86b4240301114e062ccd","original_commit_id":"a42f2fbfe2a685e9acea86b4240301114e062ccd","user":{"login":"evansde77","id":342380,"avatar_url":"https://avatars.githubusercontent.com/u/342380?v=3","gravatar_id":"","url":"https://api.github.com/users/evansde77","html_url":"https://github.com/evansde77","followers_url":"https://api.github.com/users/evansde77/followers","following_url":"https://api.github.com/users/evansde77/following{/other_user}","gists_url":"https://api.github.com/users/evansde77/gists{/gist_id}","starred_url":"https://api.github.com/users/evansde77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evansde77/subscriptions","organizations_url":"https://api.github.com/users/evansde77/orgs","repos_url":"https://api.github.com/users/evansde77/repos","events_url":"https://api.github.com/users/evansde77/events{/privacy}","received_events_url":"https://api.github.com/users/evansde77/received_events","type":"User","site_admin":false},"body":"suggest making this version a BIG_OBVIOUS_CONSTANT at the top of the module with a brief desc of what it is controlling","created_at":"2016-08-11T20:31:26Z","updated_at":"2016-08-11T20:31:26Z","html_url":"https://github.com/evansde77/cirrus/pull/140#discussion_r74497207","pull_request_url":"https://api.github.com/repos/evansde77/cirrus/pulls/140","_links":{"self":{"href":"https://api.github.com/repos/evansde77/cirrus/pulls/comments/74497207"},"html":{"href":"https://github.com/evansde77/cirrus/pull/140#discussion_r74497207"},"pull_request":{"href":"https://api.github.com/repos/evansde77/cirrus/pulls/140"}}},"pull_request":{"url":"https://api.github.com/repos/evansde77/cirrus/pulls/140","id":81022515,"html_url":"https://github.com/evansde77/cirrus/pull/140","diff_url":"https://github.com/evansde77/cirrus/pull/140.diff","patch_url":"https://github.com/evansde77/cirrus/pull/140.patch","issue_url":"https://api.github.com/repos/evansde77/cirrus/issues/140","number":140,"state":"open","locked":false,"title":"Fixes docker-image issues around the deprecation of \"docker tag -f\"","user":{"login":"shudgston","id":1087548,"avatar_url":"https://avatars.githubusercontent.com/u/1087548?v=3","gravatar_id":"","url":"https://api.github.com/users/shudgston","html_url":"https://github.com/shudgston","followers_url":"https://api.github.com/users/shudgston/followers","following_url":"https://api.github.com/users/shudgston/following{/other_user}","gists_url":"https://api.github.com/users/shudgston/gists{/gist_id}","starred_url":"https://api.github.com/users/shudgston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shudgston/subscriptions","organizations_url":"https://api.github.com/users/shudgston/orgs","repos_url":"https://api.github.com/users/shudgston/repos","events_url":"https://api.github.com/users/shudgston/events{/privacy}","received_events_url":"https://api.github.com/users/shudgston/received_events","type":"User","site_admin":false},"body":"- Issue #136\r\n- Since we cannot rely on docker tag -f being available, we now supply\r\n  tag names to the \"docker build\" step with multiple -t arguments.\r\n- For that to work, we need to make sure docker 1.10.0 or greater is\r\n  locally installed.  Otherwise images will only be tagged by their\r\n  explicit version number rather than the version and \"latest\". A\r\n  version check and warning message was added to handle this.\r\n- docker.py functions related to \"docker tag\" commands were removed\r\n  because all tagging takes place in the build step and they are no\r\n  longer needed.\r\n- Added test coverage for new code.","created_at":"2016-08-11T20:11:50Z","updated_at":"2016-08-11T20:31:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"841b8a82959d915b0b21c0e5b1d0f846492cc1e1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/evansde77/cirrus/pulls/140/commits","review_comments_url":"https://api.github.com/repos/evansde77/cirrus/pulls/140/comments","review_comment_url":"https://api.github.com/repos/evansde77/cirrus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/evansde77/cirrus/issues/140/comments","statuses_url":"https://api.github.com/repos/evansde77/cirrus/statuses/a42f2fbfe2a685e9acea86b4240301114e062ccd","head":{"label":"evansde77:bug/136-docker-image-tagging","ref":"bug/136-docker-image-tagging","sha":"a42f2fbfe2a685e9acea86b4240301114e062ccd","user":{"login":"evansde77","id":342380,"avatar_url":"https://avatars.githubusercontent.com/u/342380?v=3","gravatar_id":"","url":"https://api.github.com/users/evansde77","html_url":"https://github.com/evansde77","followers_url":"https://api.github.com/users/evansde77/followers","following_url":"https://api.github.com/users/evansde77/following{/other_user}","gists_url":"https://api.github.com/users/evansde77/gists{/gist_id}","starred_url":"https://api.github.com/users/evansde77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evansde77/subscriptions","organizations_url":"https://api.github.com/users/evansde77/orgs","repos_url":"https://api.github.com/users/evansde77/repos","events_url":"https://api.github.com/users/evansde77/events{/privacy}","received_events_url":"https://api.github.com/users/evansde77/received_events","type":"User","site_admin":false},"repo":{"id":17570751,"name":"cirrus","full_name":"evansde77/cirrus","owner":{"login":"evansde77","id":342380,"avatar_url":"https://avatars.githubusercontent.com/u/342380?v=3","gravatar_id":"","url":"https://api.github.com/users/evansde77","html_url":"https://github.com/evansde77","followers_url":"https://api.github.com/users/evansde77/followers","following_url":"https://api.github.com/users/evansde77/following{/other_user}","gists_url":"https://api.github.com/users/evansde77/gists{/gist_id}","starred_url":"https://api.github.com/users/evansde77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evansde77/subscriptions","organizations_url":"https://api.github.com/users/evansde77/orgs","repos_url":"https://api.github.com/users/evansde77/repos","events_url":"https://api.github.com/users/evansde77/events{/privacy}","received_events_url":"https://api.github.com/users/evansde77/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evansde77/cirrus","description":"python library build, test and devop like things assistant","fork":false,"url":"https://api.github.com/repos/evansde77/cirrus","forks_url":"https://api.github.com/repos/evansde77/cirrus/forks","keys_url":"https://api.github.com/repos/evansde77/cirrus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evansde77/cirrus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evansde77/cirrus/teams","hooks_url":"https://api.github.com/repos/evansde77/cirrus/hooks","issue_events_url":"https://api.github.com/repos/evansde77/cirrus/issues/events{/number}","events_url":"https://api.github.com/repos/evansde77/cirrus/events","assignees_url":"https://api.github.com/repos/evansde77/cirrus/assignees{/user}","branches_url":"https://api.github.com/repos/evansde77/cirrus/branches{/branch}","tags_url":"https://api.github.com/repos/evansde77/cirrus/tags","blobs_url":"https://api.github.com/repos/evansde77/cirrus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evansde77/cirrus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evansde77/cirrus/git/refs{/sha}","trees_url":"https://api.github.com/repos/evansde77/cirrus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evansde77/cirrus/statuses/{sha}","languages_url":"https://api.github.com/repos/evansde77/cirrus/languages","stargazers_url":"https://api.github.com/repos/evansde77/cirrus/stargazers","contributors_url":"https://api.github.com/repos/evansde77/cirrus/contributors","subscribers_url":"https://api.github.com/repos/evansde77/cirrus/subscribers","subscription_url":"https://api.github.com/repos/evansde77/cirrus/subscription","commits_url":"https://api.github.com/repos/evansde77/cirrus/commits{/sha}","git_commits_url":"https://api.github.com/repos/evansde77/cirrus/git/commits{/sha}","comments_url":"https://api.github.com/repos/evansde77/cirrus/comments{/number}","issue_comment_url":"https://api.github.com/repos/evansde77/cirrus/issues/comments{/number}","contents_url":"https://api.github.com/repos/evansde77/cirrus/contents/{+path}","compare_url":"https://api.github.com/repos/evansde77/cirrus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evansde77/cirrus/merges","archive_url":"https://api.github.com/repos/evansde77/cirrus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evansde77/cirrus/downloads","issues_url":"https://api.github.com/repos/evansde77/cirrus/issues{/number}","pulls_url":"https://api.github.com/repos/evansde77/cirrus/pulls{/number}","milestones_url":"https://api.github.com/repos/evansde77/cirrus/milestones{/number}","notifications_url":"https://api.github.com/repos/evansde77/cirrus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evansde77/cirrus/labels{/name}","releases_url":"https://api.github.com/repos/evansde77/cirrus/releases{/id}","deployments_url":"https://api.github.com/repos/evansde77/cirrus/deployments","created_at":"2014-03-09T18:35:33Z","updated_at":"2016-05-03T12:35:28Z","pushed_at":"2016-08-11T20:11:50Z","git_url":"git://github.com/evansde77/cirrus.git","ssh_url":"git@github.com:evansde77/cirrus.git","clone_url":"https://github.com/evansde77/cirrus.git","svn_url":"https://github.com/evansde77/cirrus","homepage":null,"size":3424,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":15,"forks":0,"open_issues":15,"watchers":3,"default_branch":"develop"}},"base":{"label":"evansde77:develop","ref":"develop","sha":"c8aa90ac174b3583595d1d299cf7f2bbeca6227d","user":{"login":"evansde77","id":342380,"avatar_url":"https://avatars.githubusercontent.com/u/342380?v=3","gravatar_id":"","url":"https://api.github.com/users/evansde77","html_url":"https://github.com/evansde77","followers_url":"https://api.github.com/users/evansde77/followers","following_url":"https://api.github.com/users/evansde77/following{/other_user}","gists_url":"https://api.github.com/users/evansde77/gists{/gist_id}","starred_url":"https://api.github.com/users/evansde77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evansde77/subscriptions","organizations_url":"https://api.github.com/users/evansde77/orgs","repos_url":"https://api.github.com/users/evansde77/repos","events_url":"https://api.github.com/users/evansde77/events{/privacy}","received_events_url":"https://api.github.com/users/evansde77/received_events","type":"User","site_admin":false},"repo":{"id":17570751,"name":"cirrus","full_name":"evansde77/cirrus","owner":{"login":"evansde77","id":342380,"avatar_url":"https://avatars.githubusercontent.com/u/342380?v=3","gravatar_id":"","url":"https://api.github.com/users/evansde77","html_url":"https://github.com/evansde77","followers_url":"https://api.github.com/users/evansde77/followers","following_url":"https://api.github.com/users/evansde77/following{/other_user}","gists_url":"https://api.github.com/users/evansde77/gists{/gist_id}","starred_url":"https://api.github.com/users/evansde77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evansde77/subscriptions","organizations_url":"https://api.github.com/users/evansde77/orgs","repos_url":"https://api.github.com/users/evansde77/repos","events_url":"https://api.github.com/users/evansde77/events{/privacy}","received_events_url":"https://api.github.com/users/evansde77/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evansde77/cirrus","description":"python library build, test and devop like things assistant","fork":false,"url":"https://api.github.com/repos/evansde77/cirrus","forks_url":"https://api.github.com/repos/evansde77/cirrus/forks","keys_url":"https://api.github.com/repos/evansde77/cirrus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evansde77/cirrus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evansde77/cirrus/teams","hooks_url":"https://api.github.com/repos/evansde77/cirrus/hooks","issue_events_url":"https://api.github.com/repos/evansde77/cirrus/issues/events{/number}","events_url":"https://api.github.com/repos/evansde77/cirrus/events","assignees_url":"https://api.github.com/repos/evansde77/cirrus/assignees{/user}","branches_url":"https://api.github.com/repos/evansde77/cirrus/branches{/branch}","tags_url":"https://api.github.com/repos/evansde77/cirrus/tags","blobs_url":"https://api.github.com/repos/evansde77/cirrus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evansde77/cirrus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evansde77/cirrus/git/refs{/sha}","trees_url":"https://api.github.com/repos/evansde77/cirrus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evansde77/cirrus/statuses/{sha}","languages_url":"https://api.github.com/repos/evansde77/cirrus/languages","stargazers_url":"https://api.github.com/repos/evansde77/cirrus/stargazers","contributors_url":"https://api.github.com/repos/evansde77/cirrus/contributors","subscribers_url":"https://api.github.com/repos/evansde77/cirrus/subscribers","subscription_url":"https://api.github.com/repos/evansde77/cirrus/subscription","commits_url":"https://api.github.com/repos/evansde77/cirrus/commits{/sha}","git_commits_url":"https://api.github.com/repos/evansde77/cirrus/git/commits{/sha}","comments_url":"https://api.github.com/repos/evansde77/cirrus/comments{/number}","issue_comment_url":"https://api.github.com/repos/evansde77/cirrus/issues/comments{/number}","contents_url":"https://api.github.com/repos/evansde77/cirrus/contents/{+path}","compare_url":"https://api.github.com/repos/evansde77/cirrus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evansde77/cirrus/merges","archive_url":"https://api.github.com/repos/evansde77/cirrus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evansde77/cirrus/downloads","issues_url":"https://api.github.com/repos/evansde77/cirrus/issues{/number}","pulls_url":"https://api.github.com/repos/evansde77/cirrus/pulls{/number}","milestones_url":"https://api.github.com/repos/evansde77/cirrus/milestones{/number}","notifications_url":"https://api.github.com/repos/evansde77/cirrus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evansde77/cirrus/labels{/name}","releases_url":"https://api.github.com/repos/evansde77/cirrus/releases{/id}","deployments_url":"https://api.github.com/repos/evansde77/cirrus/deployments","created_at":"2014-03-09T18:35:33Z","updated_at":"2016-05-03T12:35:28Z","pushed_at":"2016-08-11T20:11:50Z","git_url":"git://github.com/evansde77/cirrus.git","ssh_url":"git@github.com:evansde77/cirrus.git","clone_url":"https://github.com/evansde77/cirrus.git","svn_url":"https://github.com/evansde77/cirrus","homepage":null,"size":3424,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":15,"forks":0,"open_issues":15,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/evansde77/cirrus/pulls/140"},"html":{"href":"https://github.com/evansde77/cirrus/pull/140"},"issue":{"href":"https://api.github.com/repos/evansde77/cirrus/issues/140"},"comments":{"href":"https://api.github.com/repos/evansde77/cirrus/issues/140/comments"},"review_comments":{"href":"https://api.github.com/repos/evansde77/cirrus/pulls/140/comments"},"review_comment":{"href":"https://api.github.com/repos/evansde77/cirrus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/evansde77/cirrus/pulls/140/commits"},"statuses":{"href":"https://api.github.com/repos/evansde77/cirrus/statuses/a42f2fbfe2a685e9acea86b4240301114e062ccd"}}}}
{"actor":{"display_login":"evansde77"}}