{"action":"created","comment":{"url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/comments/74127601","id":74127601,"diff_hunk":"@@ -14,25 +14,27 @@ public static class EncryptionUtility\n \n         public static string EncryptString(string value)\n         {\n-#if IS_CORECLR\n-            throw new NotSupportedException();\n-#else\n+            if (!RuntimeEnvironmentHelper.IsWindows)\n+            {\n+                throw new NotSupportedException(\"Encryption is not supported on non-Windows platforms\");","path":"src/NuGet.Core/NuGet.Configuration/Utility/EncryptionUtility.cs","position":9,"original_position":9,"commit_id":"896508d9872f0bb2bbd85f7bc4dbb2ac33344825","original_commit_id":"896508d9872f0bb2bbd85f7bc4dbb2ac33344825","user":{"login":"emgarten","id":6381138,"avatar_url":"https://avatars.githubusercontent.com/u/6381138?v=3","gravatar_id":"","url":"https://api.github.com/users/emgarten","html_url":"https://github.com/emgarten","followers_url":"https://api.github.com/users/emgarten/followers","following_url":"https://api.github.com/users/emgarten/following{/other_user}","gists_url":"https://api.github.com/users/emgarten/gists{/gist_id}","starred_url":"https://api.github.com/users/emgarten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emgarten/subscriptions","organizations_url":"https://api.github.com/users/emgarten/orgs","repos_url":"https://api.github.com/users/emgarten/repos","events_url":"https://api.github.com/users/emgarten/events{/privacy}","received_events_url":"https://api.github.com/users/emgarten/received_events","type":"User","site_admin":false},"body":"I would expect this to be a resource string.","created_at":"2016-08-09T19:24:49Z","updated_at":"2016-08-09T19:24:49Z","html_url":"https://github.com/NuGet/NuGet.Client/pull/813#discussion_r74127601","pull_request_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/813","_links":{"self":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/comments/74127601"},"html":{"href":"https://github.com/NuGet/NuGet.Client/pull/813#discussion_r74127601"},"pull_request":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/813"}}},"pull_request":{"url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/813","id":80646901,"html_url":"https://github.com/NuGet/NuGet.Client/pull/813","diff_url":"https://github.com/NuGet/NuGet.Client/pull/813.diff","patch_url":"https://github.com/NuGet/NuGet.Client/pull/813.patch","issue_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/813","number":813,"state":"open","locked":false,"title":"Enabled password encryption on .NET Core/Windows","user":{"login":"alpaix","id":8239356,"avatar_url":"https://avatars.githubusercontent.com/u/8239356?v=3","gravatar_id":"","url":"https://api.github.com/users/alpaix","html_url":"https://github.com/alpaix","followers_url":"https://api.github.com/users/alpaix/followers","following_url":"https://api.github.com/users/alpaix/following{/other_user}","gists_url":"https://api.github.com/users/alpaix/gists{/gist_id}","starred_url":"https://api.github.com/users/alpaix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alpaix/subscriptions","organizations_url":"https://api.github.com/users/alpaix/orgs","repos_url":"https://api.github.com/users/alpaix/repos","events_url":"https://api.github.com/users/alpaix/events{/privacy}","received_events_url":"https://api.github.com/users/alpaix/received_events","type":"User","site_admin":false},"body":"Fixes NuGet/Home#1851\r\n\r\nEnabled password encryption of source and proxy credentials on all Windows\r\nframeworks by replacing `#if !IS_CORECLR` with `RuntimeEnvironmentHelper.IsWindows`\r\n\r\nUpdated tests.\r\n\r\nAlso fixes Nuget/Home#2065\r\n\r\nIntroduced `Platform` xUnit trait to be able running OS specific tests.\r\n\r\nOn Windows:\r\n```\r\nxunit <test-project> -notrait Platform=Linux -notrait Platform=Darwin\r\n```\r\n\r\nOn Linux\r\n```\r\nxunit <test-project> -notrait Platform=Windows\r\n```\r\n\r\n//cc @emgarten @joelverhagen @rrelyea @rohit21agrawal @drewgil @jainaashish ","created_at":"2016-08-09T15:57:30Z","updated_at":"2016-08-09T19:24:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e523e5f51e3d7c5bfed8cd0785be45a0314b6e7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/813/commits","review_comments_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/813/comments","review_comment_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/813/comments","statuses_url":"https://api.github.com/repos/NuGet/NuGet.Client/statuses/896508d9872f0bb2bbd85f7bc4dbb2ac33344825","head":{"label":"alpaix:alpanov/encryption","ref":"alpanov/encryption","sha":"896508d9872f0bb2bbd85f7bc4dbb2ac33344825","user":{"login":"alpaix","id":8239356,"avatar_url":"https://avatars.githubusercontent.com/u/8239356?v=3","gravatar_id":"","url":"https://api.github.com/users/alpaix","html_url":"https://github.com/alpaix","followers_url":"https://api.github.com/users/alpaix/followers","following_url":"https://api.github.com/users/alpaix/following{/other_user}","gists_url":"https://api.github.com/users/alpaix/gists{/gist_id}","starred_url":"https://api.github.com/users/alpaix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alpaix/subscriptions","organizations_url":"https://api.github.com/users/alpaix/orgs","repos_url":"https://api.github.com/users/alpaix/repos","events_url":"https://api.github.com/users/alpaix/events{/privacy}","received_events_url":"https://api.github.com/users/alpaix/received_events","type":"User","site_admin":false},"repo":{"id":50218763,"name":"NuGet.Client","full_name":"alpaix/NuGet.Client","owner":{"login":"alpaix","id":8239356,"avatar_url":"https://avatars.githubusercontent.com/u/8239356?v=3","gravatar_id":"","url":"https://api.github.com/users/alpaix","html_url":"https://github.com/alpaix","followers_url":"https://api.github.com/users/alpaix/followers","following_url":"https://api.github.com/users/alpaix/following{/other_user}","gists_url":"https://api.github.com/users/alpaix/gists{/gist_id}","starred_url":"https://api.github.com/users/alpaix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alpaix/subscriptions","organizations_url":"https://api.github.com/users/alpaix/orgs","repos_url":"https://api.github.com/users/alpaix/repos","events_url":"https://api.github.com/users/alpaix/events{/privacy}","received_events_url":"https://api.github.com/users/alpaix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alpaix/NuGet.Client","description":"Core client libraries for NuGet Services","fork":true,"url":"https://api.github.com/repos/alpaix/NuGet.Client","forks_url":"https://api.github.com/repos/alpaix/NuGet.Client/forks","keys_url":"https://api.github.com/repos/alpaix/NuGet.Client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alpaix/NuGet.Client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alpaix/NuGet.Client/teams","hooks_url":"https://api.github.com/repos/alpaix/NuGet.Client/hooks","issue_events_url":"https://api.github.com/repos/alpaix/NuGet.Client/issues/events{/number}","events_url":"https://api.github.com/repos/alpaix/NuGet.Client/events","assignees_url":"https://api.github.com/repos/alpaix/NuGet.Client/assignees{/user}","branches_url":"https://api.github.com/repos/alpaix/NuGet.Client/branches{/branch}","tags_url":"https://api.github.com/repos/alpaix/NuGet.Client/tags","blobs_url":"https://api.github.com/repos/alpaix/NuGet.Client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alpaix/NuGet.Client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alpaix/NuGet.Client/git/refs{/sha}","trees_url":"https://api.github.com/repos/alpaix/NuGet.Client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alpaix/NuGet.Client/statuses/{sha}","languages_url":"https://api.github.com/repos/alpaix/NuGet.Client/languages","stargazers_url":"https://api.github.com/repos/alpaix/NuGet.Client/stargazers","contributors_url":"https://api.github.com/repos/alpaix/NuGet.Client/contributors","subscribers_url":"https://api.github.com/repos/alpaix/NuGet.Client/subscribers","subscription_url":"https://api.github.com/repos/alpaix/NuGet.Client/subscription","commits_url":"https://api.github.com/repos/alpaix/NuGet.Client/commits{/sha}","git_commits_url":"https://api.github.com/repos/alpaix/NuGet.Client/git/commits{/sha}","comments_url":"https://api.github.com/repos/alpaix/NuGet.Client/comments{/number}","issue_comment_url":"https://api.github.com/repos/alpaix/NuGet.Client/issues/comments{/number}","contents_url":"https://api.github.com/repos/alpaix/NuGet.Client/contents/{+path}","compare_url":"https://api.github.com/repos/alpaix/NuGet.Client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alpaix/NuGet.Client/merges","archive_url":"https://api.github.com/repos/alpaix/NuGet.Client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alpaix/NuGet.Client/downloads","issues_url":"https://api.github.com/repos/alpaix/NuGet.Client/issues{/number}","pulls_url":"https://api.github.com/repos/alpaix/NuGet.Client/pulls{/number}","milestones_url":"https://api.github.com/repos/alpaix/NuGet.Client/milestones{/number}","notifications_url":"https://api.github.com/repos/alpaix/NuGet.Client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alpaix/NuGet.Client/labels{/name}","releases_url":"https://api.github.com/repos/alpaix/NuGet.Client/releases{/id}","deployments_url":"https://api.github.com/repos/alpaix/NuGet.Client/deployments","created_at":"2016-01-23T02:00:36Z","updated_at":"2016-02-18T19:56:23Z","pushed_at":"2016-08-09T15:55:54Z","git_url":"git://github.com/alpaix/NuGet.Client.git","ssh_url":"git@github.com:alpaix/NuGet.Client.git","clone_url":"https://github.com/alpaix/NuGet.Client.git","svn_url":"https://github.com/alpaix/NuGet.Client","homepage":null,"size":20183,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"dev"}},"base":{"label":"NuGet:dev","ref":"dev","sha":"c019d11ccc2b12fffa25c466c4c05181f16f7f6f","user":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"repo":{"id":19330736,"name":"NuGet.Client","full_name":"NuGet/NuGet.Client","owner":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NuGet/NuGet.Client","description":"Core client libraries for NuGet Services","fork":false,"url":"https://api.github.com/repos/NuGet/NuGet.Client","forks_url":"https://api.github.com/repos/NuGet/NuGet.Client/forks","keys_url":"https://api.github.com/repos/NuGet/NuGet.Client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NuGet/NuGet.Client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NuGet/NuGet.Client/teams","hooks_url":"https://api.github.com/repos/NuGet/NuGet.Client/hooks","issue_events_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/events{/number}","events_url":"https://api.github.com/repos/NuGet/NuGet.Client/events","assignees_url":"https://api.github.com/repos/NuGet/NuGet.Client/assignees{/user}","branches_url":"https://api.github.com/repos/NuGet/NuGet.Client/branches{/branch}","tags_url":"https://api.github.com/repos/NuGet/NuGet.Client/tags","blobs_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/refs{/sha}","trees_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NuGet/NuGet.Client/statuses/{sha}","languages_url":"https://api.github.com/repos/NuGet/NuGet.Client/languages","stargazers_url":"https://api.github.com/repos/NuGet/NuGet.Client/stargazers","contributors_url":"https://api.github.com/repos/NuGet/NuGet.Client/contributors","subscribers_url":"https://api.github.com/repos/NuGet/NuGet.Client/subscribers","subscription_url":"https://api.github.com/repos/NuGet/NuGet.Client/subscription","commits_url":"https://api.github.com/repos/NuGet/NuGet.Client/commits{/sha}","git_commits_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/commits{/sha}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Client/comments{/number}","issue_comment_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/comments{/number}","contents_url":"https://api.github.com/repos/NuGet/NuGet.Client/contents/{+path}","compare_url":"https://api.github.com/repos/NuGet/NuGet.Client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NuGet/NuGet.Client/merges","archive_url":"https://api.github.com/repos/NuGet/NuGet.Client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NuGet/NuGet.Client/downloads","issues_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues{/number}","pulls_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls{/number}","milestones_url":"https://api.github.com/repos/NuGet/NuGet.Client/milestones{/number}","notifications_url":"https://api.github.com/repos/NuGet/NuGet.Client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NuGet/NuGet.Client/labels{/name}","releases_url":"https://api.github.com/repos/NuGet/NuGet.Client/releases{/id}","deployments_url":"https://api.github.com/repos/NuGet/NuGet.Client/deployments","created_at":"2014-04-30T23:46:11Z","updated_at":"2016-07-29T03:50:37Z","pushed_at":"2016-08-09T19:07:13Z","git_url":"git://github.com/NuGet/NuGet.Client.git","ssh_url":"git@github.com:NuGet/NuGet.Client.git","clone_url":"https://github.com/NuGet/NuGet.Client.git","svn_url":"https://github.com/NuGet/NuGet.Client","homepage":null,"size":27255,"stargazers_count":87,"watchers_count":87,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":120,"mirror_url":null,"open_issues_count":16,"forks":120,"open_issues":16,"watchers":87,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/813"},"html":{"href":"https://github.com/NuGet/NuGet.Client/pull/813"},"issue":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/issues/813"},"comments":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/issues/813/comments"},"review_comments":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/813/comments"},"review_comment":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/813/commits"},"statuses":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/statuses/896508d9872f0bb2bbd85f7bc4dbb2ac33344825"}}}}
{"actor":{"display_login":"emgarten"}}