{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph/issues/7463","labels_url":"https://api.github.com/repos/ceph/ceph/issues/7463/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/7463/comments","events_url":"https://api.github.com/repos/ceph/ceph/issues/7463/events","html_url":"https://github.com/ceph/ceph/pull/7463","id":130319295,"number":7463,"title":"global: do not start two daemons with a single pid-file (part 2)","user":{"login":"dachary","id":433594,"avatar_url":"https://avatars.githubusercontent.com/u/433594?v=3","gravatar_id":"","url":"https://api.github.com/users/dachary","html_url":"https://github.com/dachary","followers_url":"https://api.github.com/users/dachary/followers","following_url":"https://api.github.com/users/dachary/following{/other_user}","gists_url":"https://api.github.com/users/dachary/gists{/gist_id}","starred_url":"https://api.github.com/users/dachary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dachary/subscriptions","organizations_url":"https://api.github.com/users/dachary/orgs","repos_url":"https://api.github.com/users/dachary/repos","events_url":"https://api.github.com/users/dachary/events{/privacy}","received_events_url":"https://api.github.com/users/dachary/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ceph/ceph/labels/bug%20fix","name":"bug fix","color":"e11d21"},{"url":"https://api.github.com/repos/ceph/ceph/labels/common","name":"common","color":"006b75"},{"url":"https://api.github.com/repos/ceph/ceph/labels/needs-qa","name":"needs-qa","color":"fad8c7"},{"url":"https://api.github.com/repos/ceph/ceph/labels/wip-sage-testing2","name":"wip-sage-testing2","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"milestone":null,"comments":10,"created_at":"2016-02-01T10:18:13Z","updated_at":"2016-02-02T07:06:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/7463","html_url":"https://github.com/ceph/ceph/pull/7463","diff_url":"https://github.com/ceph/ceph/pull/7463.diff","patch_url":"https://github.com/ceph/ceph/pull/7463.patch"},"body":"* In theory atexit(pidfile_remove_void) is called before pidfh\r\n  destructor. But valgrind probably changes this order. Move\r\n  the call to pidfile_remove into the pidfh destructor instead,\r\n  it is simpler.\r\n\r\n* Do not fail if pidfile_open fails. Tests scripts and maybe others\r\n  rely on that behavior. It has no negative side effect as the pidfile\r\n  is not created and pidfile_remove & pidfile_write will be a noop.\r\n\r\nhttp://tracker.ceph.com/issues/13422 Fixes: #13422\r\n\r\nSigned-off-by: Loic Dachary <loic@dachary.org>"},"comment":{"url":"https://api.github.com/repos/ceph/ceph/issues/comments/178414256","html_url":"https://github.com/ceph/ceph/pull/7463#issuecomment-178414256","issue_url":"https://api.github.com/repos/ceph/ceph/issues/7463","id":178414256,"user":{"login":"shun-s","id":15278321,"avatar_url":"https://avatars.githubusercontent.com/u/15278321?v=3","gravatar_id":"","url":"https://api.github.com/users/shun-s","html_url":"https://github.com/shun-s","followers_url":"https://api.github.com/users/shun-s/followers","following_url":"https://api.github.com/users/shun-s/following{/other_user}","gists_url":"https://api.github.com/users/shun-s/gists{/gist_id}","starred_url":"https://api.github.com/users/shun-s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shun-s/subscriptions","organizations_url":"https://api.github.com/users/shun-s/orgs","repos_url":"https://api.github.com/users/shun-s/repos","events_url":"https://api.github.com/users/shun-s/events{/privacy}","received_events_url":"https://api.github.com/users/shun-s/received_events","type":"User","site_admin":false},"created_at":"2016-02-02T07:06:58Z","updated_at":"2016-02-02T07:06:58Z","body":"@tchaikov @dachary hooray!"}}