{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/73263095","id":73263095,"diff_hunk":"@@ -455,17 +452,55 @@ private boolean shouldShutdown() {\n      * add more work from root nodes that may have additional work. This ensures that if a pipeline\n      * has elements available from the root nodes it will add those elements when necessary.\n      */\n-    private void addWorkIfNecessary(boolean firedTimers) {\n+    private void addWorkIfNecessary() {\n       // If any timers have fired, they will add more work; We don't need to add more\n-      if (firedTimers) {\n-        return;\n-      }\n-      // All current TransformExecutors are blocked; add more work from the roots.\n-      for (AppliedPTransform<?, ?, ?> root : rootNodes) {\n-        if (!evaluationContext.isDone(root)) {\n-          scheduleConsumption(root, null, defaultCompletionCallback);\n+      if (state.get() == ExecutorState.QUIESCENT) {\n+        // All current TransformExecutors are blocked; add more work from the roots.\n+        for (AppliedPTransform<?, ?, ?> root : rootNodes) {\n+          if (!evaluationContext.isDone(root)) {\n+            scheduleConsumption(root, null, defaultCompletionCallback);\n+            state.set(ExecutorState.ACTIVE);\n+          }\n         }\n       }\n     }\n   }\n+\n+\n+  /**\n+   * The state of the executor. The state of the executor determines the behavior of the\n+   * {@link MonitorRunnable} when it runs.\n+   */\n+  private enum ExecutorState {\n+    /**\n+     * The Executor has new work available to it. All pending, including potentially blocked work,\n+     * should be evaluated.\n+     *\n+     * <p>The executor becomes active whenever a timer fires, a {@link PCollectionView} is updated,\n+     * or output is produced by the evaluation of a {@link TransformExecutor}.\n+     */\n+    ACTIVE,\n+    /**\n+     * The Executor does not have any new work available to it, but work is in progress. New work\n+     * should not be added until the Executor becomes active or no work is pending.","path":"runners/direct-java/src/main/java/org/apache/beam/runners/direct/ExecutorServiceParallelExecutor.java","position":249,"original_position":237,"commit_id":"000127cd57e3fb580db23e61e2b4b86855f5e0ca","original_commit_id":"3a8e2f10728b15b8b5b1a12f67385671fbc84ca8","user":{"login":"tgroh","id":429866,"avatar_url":"https://avatars.githubusercontent.com/u/429866?v=3","gravatar_id":"","url":"https://api.github.com/users/tgroh","html_url":"https://github.com/tgroh","followers_url":"https://api.github.com/users/tgroh/followers","following_url":"https://api.github.com/users/tgroh/following{/other_user}","gists_url":"https://api.github.com/users/tgroh/gists{/gist_id}","starred_url":"https://api.github.com/users/tgroh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgroh/subscriptions","organizations_url":"https://api.github.com/users/tgroh/orgs","repos_url":"https://api.github.com/users/tgroh/repos","events_url":"https://api.github.com/users/tgroh/events{/privacy}","received_events_url":"https://api.github.com/users/tgroh/received_events","type":"User","site_admin":false},"body":"`DRAINING` -> `PROCESSING`\r\n\r\nWork is in progress but there is no new work, and the pipeline has not yet started to quiesce.","created_at":"2016-08-03T00:30:05Z","updated_at":"2016-08-03T00:30:05Z","html_url":"https://github.com/apache/incubator-beam/pull/754#discussion_r73263095","pull_request_url":"https://api.github.com/repos/apache/incubator-beam/pulls/754","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/73263095"},"html":{"href":"https://github.com/apache/incubator-beam/pull/754#discussion_r73263095"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/754"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/754","id":79290821,"html_url":"https://github.com/apache/incubator-beam/pull/754","diff_url":"https://github.com/apache/incubator-beam/pull/754.diff","patch_url":"https://github.com/apache/incubator-beam/pull/754.patch","issue_url":"https://api.github.com/repos/apache/incubator-beam/issues/754","number":754,"state":"open","locked":false,"title":"[BEAM-156] Use Quiescence to Drive the DirectRunner","user":{"login":"tgroh","id":429866,"avatar_url":"https://avatars.githubusercontent.com/u/429866?v=3","gravatar_id":"","url":"https://api.github.com/users/tgroh","html_url":"https://github.com/tgroh","followers_url":"https://api.github.com/users/tgroh/followers","following_url":"https://api.github.com/users/tgroh/following{/other_user}","gists_url":"https://api.github.com/users/tgroh/gists{/gist_id}","starred_url":"https://api.github.com/users/tgroh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgroh/subscriptions","organizations_url":"https://api.github.com/users/tgroh/orgs","repos_url":"https://api.github.com/users/tgroh/repos","events_url":"https://api.github.com/users/tgroh/events{/privacy}","received_events_url":"https://api.github.com/users/tgroh/received_events","type":"User","site_admin":false},"body":"Be sure to do all of the following to help us incorporate your contribution\r\nquickly and easily:\r\n\r\n - [x] Make sure the PR title is formatted like:\r\n   `[BEAM-<Jira issue #>] Description of pull request`\r\n - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable\r\n       Travis-CI on your fork and ensure the whole test matrix passes).\r\n - [x] Replace `<Jira issue #>` in the title with the actual Jira issue\r\n       number, if there is one.\r\n - [x] If this contribution is large, please file an Apache\r\n       [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).\r\n\r\n---\r\nThe Executor should add work whenever it becomes Quiescent.\r\n\r\nTrack the amount of outstanding work in the executor, and\r\nmodify the state appropriately whenever work is scheduled or completes.","created_at":"2016-07-29T00:36:09Z","updated_at":"2016-08-03T00:30:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc80b0d799e8eb516a591d945be57b391ee128f0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-beam/pulls/754/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-beam/pulls/754/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-beam/issues/754/comments","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/000127cd57e3fb580db23e61e2b4b86855f5e0ca","head":{"label":"tgroh:quiescence_driver","ref":"quiescence_driver","sha":"000127cd57e3fb580db23e61e2b4b86855f5e0ca","user":{"login":"tgroh","id":429866,"avatar_url":"https://avatars.githubusercontent.com/u/429866?v=3","gravatar_id":"","url":"https://api.github.com/users/tgroh","html_url":"https://github.com/tgroh","followers_url":"https://api.github.com/users/tgroh/followers","following_url":"https://api.github.com/users/tgroh/following{/other_user}","gists_url":"https://api.github.com/users/tgroh/gists{/gist_id}","starred_url":"https://api.github.com/users/tgroh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgroh/subscriptions","organizations_url":"https://api.github.com/users/tgroh/orgs","repos_url":"https://api.github.com/users/tgroh/repos","events_url":"https://api.github.com/users/tgroh/events{/privacy}","received_events_url":"https://api.github.com/users/tgroh/received_events","type":"User","site_admin":false},"repo":{"id":52644388,"name":"incubator-beam","full_name":"tgroh/incubator-beam","owner":{"login":"tgroh","id":429866,"avatar_url":"https://avatars.githubusercontent.com/u/429866?v=3","gravatar_id":"","url":"https://api.github.com/users/tgroh","html_url":"https://github.com/tgroh","followers_url":"https://api.github.com/users/tgroh/followers","following_url":"https://api.github.com/users/tgroh/following{/other_user}","gists_url":"https://api.github.com/users/tgroh/gists{/gist_id}","starred_url":"https://api.github.com/users/tgroh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgroh/subscriptions","organizations_url":"https://api.github.com/users/tgroh/orgs","repos_url":"https://api.github.com/users/tgroh/repos","events_url":"https://api.github.com/users/tgroh/events{/privacy}","received_events_url":"https://api.github.com/users/tgroh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tgroh/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/tgroh/incubator-beam","forks_url":"https://api.github.com/repos/tgroh/incubator-beam/forks","keys_url":"https://api.github.com/repos/tgroh/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgroh/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgroh/incubator-beam/teams","hooks_url":"https://api.github.com/repos/tgroh/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/tgroh/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/tgroh/incubator-beam/events","assignees_url":"https://api.github.com/repos/tgroh/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/tgroh/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/tgroh/incubator-beam/tags","blobs_url":"https://api.github.com/repos/tgroh/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgroh/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgroh/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgroh/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgroh/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/tgroh/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/tgroh/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/tgroh/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/tgroh/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/tgroh/incubator-beam/subscription","commits_url":"https://api.github.com/repos/tgroh/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgroh/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgroh/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgroh/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgroh/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/tgroh/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgroh/incubator-beam/merges","archive_url":"https://api.github.com/repos/tgroh/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgroh/incubator-beam/downloads","issues_url":"https://api.github.com/repos/tgroh/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/tgroh/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/tgroh/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/tgroh/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgroh/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/tgroh/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/tgroh/incubator-beam/deployments","created_at":"2016-02-27T01:43:32Z","updated_at":"2016-02-27T01:43:35Z","pushed_at":"2016-08-03T00:29:58Z","git_url":"git://github.com/tgroh/incubator-beam.git","ssh_url":"git@github.com:tgroh/incubator-beam.git","clone_url":"https://github.com/tgroh/incubator-beam.git","svn_url":"https://github.com/tgroh/incubator-beam","homepage":null,"size":17256,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"8b1e64a668489297e11926124c4eee6c8f69a3a7","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"incubator-beam","full_name":"apache/incubator-beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-beam","forks_url":"https://api.github.com/repos/apache/incubator-beam/forks","keys_url":"https://api.github.com/repos/apache/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-beam/teams","hooks_url":"https://api.github.com/repos/apache/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-beam/events","assignees_url":"https://api.github.com/repos/apache/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-beam/tags","blobs_url":"https://api.github.com/repos/apache/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-beam/subscription","commits_url":"https://api.github.com/repos/apache/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-beam/merges","archive_url":"https://api.github.com/repos/apache/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-beam/downloads","issues_url":"https://api.github.com/repos/apache/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2016-08-02T22:01:48Z","pushed_at":"2016-08-03T00:29:59Z","git_url":"git://github.com/apache/incubator-beam.git","ssh_url":"git@github.com:apache/incubator-beam.git","clone_url":"https://github.com/apache/incubator-beam.git","svn_url":"https://github.com/apache/incubator-beam","homepage":null,"size":25763,"stargazers_count":279,"watchers_count":279,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":175,"mirror_url":"git://git.apache.org/incubator-beam.git","open_issues_count":46,"forks":175,"open_issues":46,"watchers":279,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/754"},"html":{"href":"https://github.com/apache/incubator-beam/pull/754"},"issue":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/754"},"comments":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/754/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/754/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/754/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-beam/statuses/000127cd57e3fb580db23e61e2b4b86855f5e0ca"}}}}
{"actor":{"display_login":"tgroh"}}