{"push_id":1295836256,"size":6,"distinct_size":0,"ref":"refs/heads/master","head":"f428ff8ad4c08891c205b896308c75c635b16741","before":"94e2be842411b9f8ec9165c8d25c93716c1b30ca","commits":[{"sha":"0276015325a746f2cd26ef0fddfc682cf641423f","author":{"name":"Laine Stump","email":"5116b02f16c03abd1615869c9ce1568cbda149e8@laine.org"},"message":"qemu: fix improper initialization of cgroupControllers bitmap\n\nvirQEMUDriverConfigNew() always initializes the bitmap in its\ncgroupControllers member to -1 (i.e. all 1's).\n\nPrior to commit a9331394, if qemu.conf had a line with\n\"cgroup_controllers\", cgroupControllers would get reset to 0 before\ngoing through a loop setting a bit for each named cgroup controller.\ncommit a9331394 left out the \"reset to 0\" part, so cgroupControllers\nwould always be -1; if you didn't want a controller included, there\nwas no longer a way to make that happen.\n\nThis was discovered by users who were using qemu commandline\npassthrough to use the \"input-linux\" method of directing\nkeyboard/mouse input to a virtual machine:\n\n https://www.redhat.com/archives/vfio-users/2016-April/msg00105.html\n\nHere's the first report I found of the problem encountered after\nupgrading libvirt beyond v2.0.0:\n\n https://www.redhat.com/archives/vfio-users/2016-August/msg00053.html\n\nThanks to sL1pKn07 SpinFlo <sl1pkn07@gmail.com> for bringing the\nproblem up in IRC, and then taking the time to do a git bisect and\nfind the patch that started the problem.","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/0276015325a746f2cd26ef0fddfc682cf641423f"},{"sha":"b87703cf79559157404667628802d7fe8f9f19a6","author":{"name":"Laine Stump","email":"5116b02f16c03abd1615869c9ce1568cbda149e8@laine.org"},"message":"conf: allow hotplugging \"legacy PCI\" device to manually addressed PCIe slot\n\nIn a full domain config, libvirt allows overriding the normal PCI\nvs. PCI Express rules when a device address is explicitly provided\n(so, e.g., you can force a legacy PCI device to plug into a PCIe port,\nalthough libvirt would never do that on its own). However, due to a\nbug libvirt doesn't give this same leeway when hotplugging devices. On\ntop of that, current libvirt assumes that *all* devices are legacy\nPCI. The result of all this is that it's impossible to hotplug a\ndevice into a PCIe port, even if you manually add the PCI address.\n\nThis can all be traced to the function\nvirDomainPCIAddressEnsureAddr(), and the fact that it calls\nvirDomainPCIaddressReserveSlot() for manually set addresses, and that\nfunction hardcodes the argument \"fromConfig\" to false (meaning \"this\naddress was auto-assigned, so it should be subject to stricter\nvalidation\").\n\nSince virDomainPCIAddressReserveSlot() is just a one line simple\nwrapper around virDomainPCIAddressReserveAddr() (adding in a hardcoded\nreserveEntireSlot = true and fromConfig = false), all that's needed to\nsolve the problem with no unwanted side effects is to replace that\ncall for virDomainPCIAddressReserveSlot() with a direct call to\nvirDomainPCIAddressReserveAddr(), but with reserveEntireSlot = true,\nfromConfig = true. That's what this patch does.\n\nResolves: https://bugzilla.redhat.com/show_bug.cgi?id=1337490","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/b87703cf79559157404667628802d7fe8f9f19a6"},{"sha":"bdf83c011d816cb463ed9ba45150e0528a8adc3b","author":{"name":"Nikolay Shirokovskiy","email":"04631ef0ee7d55d1ced6f402d646c6b5f91011f3@virtuozzo.com"},"message":"api: add VIR_DOMAIN_UNDEFINE_KEEP_NVRAM flag\n\nThis flags specifies to keep nvram file if it is existed for inactive\ndomains.\n\nSigned-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/bdf83c011d816cb463ed9ba45150e0528a8adc3b"},{"sha":"048e5c64f7673c3de299e199fd9fd53ba8bd28ce","author":{"name":"Nikolay Shirokovskiy","email":"04631ef0ee7d55d1ced6f402d646c6b5f91011f3@virtuozzo.com"},"message":"qemu: add VIR_DOMAIN_UNDEFINE_KEEP_NVRAM support\n\nSigned-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/048e5c64f7673c3de299e199fd9fd53ba8bd28ce"},{"sha":"34a6e847488630514a27ac8c17d94a148e92a247","author":{"name":"Nikolay Shirokovskiy","email":"04631ef0ee7d55d1ced6f402d646c6b5f91011f3@virtuozzo.com"},"message":"virsh: add --keep-nvram option to undefine command\n\nSigned-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/34a6e847488630514a27ac8c17d94a148e92a247"},{"sha":"f428ff8ad4c08891c205b896308c75c635b16741","author":{"name":"Peter Krempa","email":"ad550f3a498f24c1804da389934cf0cf16278373@redhat.com"},"message":"qemu: Add missing 'p' to qemuCgrouEmulatorAllNodesRestore","distinct":false,"url":"https://api.github.com/repos/nertpinx/libvirt/commits/f428ff8ad4c08891c205b896308c75c635b16741"}]}
{"actor":{"display_login":"nertpinx"}}