{"action":"created","comment":{"url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/pulls/comments/75537977","id":75537977,"diff_hunk":"@@ -2,34 +2,37 @@\n \n // Copyright 2016 Endless Mobile, Inc.\n \n+const HistoryStore = imports.app.historyStore;\n const Module = imports.app.interfaces.module;\n const QueryObject = imports.search.queryObject;\n-const SetObjectModel = imports.search.setObjectModel;\n const Xapian = imports.app.modules.selection.xapian;\n \n const SubsetsForSet = new Module.Class({\n     Name: 'Selection.SubsetsForSet',\n     Extends: Xapian.Xapian,\n \n-    // Selection.Xapian implementation\n-    on_history_changed: function (history) {\n-        if (!this.global)\n-            return;\n-        let item = history.get_current_item();\n-        if (item.model instanceof SetObjectModel.SetObjectModel &&\n-            item.model !== this.model) {\n-            this.model = item.model;\n-            this._set_needs_refresh(true);\n+    _init: function (props={}) {\n+        this.parent(props);\n+        if (this.global) {\n+            HistoryStore.get_default().connect('notify::current-set', () => {\n+                this._set_needs_refresh(true);\n+            });\n         }\n     },\n \n     construct_query_object: function (limit, query_index) {\n         if (query_index > 0)\n             return null;\n \n+        let model = this.model;","path":"js/app/modules/selection/subsetsForSet.js","position":36,"original_position":36,"commit_id":"1b07eecd39d8b6be72caaacdda97313c50622a8e","original_commit_id":"1b07eecd39d8b6be72caaacdda97313c50622a8e","user":{"login":"rmacqueen","id":1205705,"avatar_url":"https://avatars.githubusercontent.com/u/1205705?v=3","gravatar_id":"","url":"https://api.github.com/users/rmacqueen","html_url":"https://github.com/rmacqueen","followers_url":"https://api.github.com/users/rmacqueen/followers","following_url":"https://api.github.com/users/rmacqueen/following{/other_user}","gists_url":"https://api.github.com/users/rmacqueen/gists{/gist_id}","starred_url":"https://api.github.com/users/rmacqueen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmacqueen/subscriptions","organizations_url":"https://api.github.com/users/rmacqueen/orgs","repos_url":"https://api.github.com/users/rmacqueen/repos","events_url":"https://api.github.com/users/rmacqueen/events{/privacy}","received_events_url":"https://api.github.com/users/rmacqueen/received_events","type":"User","site_admin":false},"body":"ditto re `this.model`","created_at":"2016-08-19T19:20:56Z","updated_at":"2016-08-19T19:20:56Z","html_url":"https://github.com/endlessm/eos-knowledge-lib/pull/1153#discussion_r75537977","pull_request_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/pulls/1153","_links":{"self":{"href":"https://api.github.com/repos/endlessm/eos-knowledge-lib/pulls/comments/75537977"},"html":{"href":"https://github.com/endlessm/eos-knowledge-lib/pull/1153#discussion_r75537977"},"pull_request":{"href":"https://api.github.com/repos/endlessm/eos-knowledge-lib/pulls/1153"}}},"pull_request":{"url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/pulls/1153","id":81761439,"html_url":"https://github.com/endlessm/eos-knowledge-lib/pull/1153","diff_url":"https://github.com/endlessm/eos-knowledge-lib/pull/1153.diff","patch_url":"https://github.com/endlessm/eos-knowledge-lib/pull/1153.patch","issue_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/issues/1153","number":1153,"state":"open","locked":false,"title":"T12846","user":{"login":"mattdangerw","id":1389937,"avatar_url":"https://avatars.githubusercontent.com/u/1389937?v=3","gravatar_id":"","url":"https://api.github.com/users/mattdangerw","html_url":"https://github.com/mattdangerw","followers_url":"https://api.github.com/users/mattdangerw/followers","following_url":"https://api.github.com/users/mattdangerw/following{/other_user}","gists_url":"https://api.github.com/users/mattdangerw/gists{/gist_id}","starred_url":"https://api.github.com/users/mattdangerw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattdangerw/subscriptions","organizations_url":"https://api.github.com/users/mattdangerw/orgs","repos_url":"https://api.github.com/users/mattdangerw/repos","events_url":"https://api.github.com/users/mattdangerw/events{/privacy}","received_events_url":"https://api.github.com/users/mattdangerw/received_events","type":"User","site_admin":false},"body":"https://phabricator.endlessm.com/T12846","created_at":"2016-08-18T06:08:31Z","updated_at":"2016-08-19T19:20:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52ed5a4064300677b65d25c2ffc702909ebac43b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/pulls/1153/commits","review_comments_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/pulls/1153/comments","review_comment_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/issues/1153/comments","statuses_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/statuses/1b07eecd39d8b6be72caaacdda97313c50622a8e","head":{"label":"endlessm:T12846","ref":"T12846","sha":"1b07eecd39d8b6be72caaacdda97313c50622a8e","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":18152801,"name":"eos-knowledge-lib","full_name":"endlessm/eos-knowledge-lib","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/eos-knowledge-lib","description":"GUI library for knowledge apps","fork":false,"url":"https://api.github.com/repos/endlessm/eos-knowledge-lib","forks_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/forks","keys_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/teams","hooks_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/hooks","issue_events_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/events","assignees_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/tags","blobs_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/languages","stargazers_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/stargazers","contributors_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/contributors","subscribers_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/subscribers","subscription_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/subscription","commits_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/merges","archive_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/downloads","issues_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/deployments","created_at":"2014-03-26T20:28:39Z","updated_at":"2016-08-18T14:20:13Z","pushed_at":"2016-08-19T03:01:55Z","git_url":"git://github.com/endlessm/eos-knowledge-lib.git","ssh_url":"git@github.com:endlessm/eos-knowledge-lib.git","clone_url":"https://github.com/endlessm/eos-knowledge-lib.git","svn_url":"https://github.com/endlessm/eos-knowledge-lib","homepage":null,"size":24559,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":11,"forks":0,"open_issues":11,"watchers":2,"default_branch":"master"}},"base":{"label":"endlessm:master","ref":"master","sha":"23f4c66b68ff2f86c1535e577e588ca6c35ace88","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":18152801,"name":"eos-knowledge-lib","full_name":"endlessm/eos-knowledge-lib","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/eos-knowledge-lib","description":"GUI library for knowledge apps","fork":false,"url":"https://api.github.com/repos/endlessm/eos-knowledge-lib","forks_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/forks","keys_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/teams","hooks_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/hooks","issue_events_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/events","assignees_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/tags","blobs_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/languages","stargazers_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/stargazers","contributors_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/contributors","subscribers_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/subscribers","subscription_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/subscription","commits_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/merges","archive_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/downloads","issues_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/deployments","created_at":"2014-03-26T20:28:39Z","updated_at":"2016-08-18T14:20:13Z","pushed_at":"2016-08-19T03:01:55Z","git_url":"git://github.com/endlessm/eos-knowledge-lib.git","ssh_url":"git@github.com:endlessm/eos-knowledge-lib.git","clone_url":"https://github.com/endlessm/eos-knowledge-lib.git","svn_url":"https://github.com/endlessm/eos-knowledge-lib","homepage":null,"size":24559,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":11,"forks":0,"open_issues":11,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endlessm/eos-knowledge-lib/pulls/1153"},"html":{"href":"https://github.com/endlessm/eos-knowledge-lib/pull/1153"},"issue":{"href":"https://api.github.com/repos/endlessm/eos-knowledge-lib/issues/1153"},"comments":{"href":"https://api.github.com/repos/endlessm/eos-knowledge-lib/issues/1153/comments"},"review_comments":{"href":"https://api.github.com/repos/endlessm/eos-knowledge-lib/pulls/1153/comments"},"review_comment":{"href":"https://api.github.com/repos/endlessm/eos-knowledge-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endlessm/eos-knowledge-lib/pulls/1153/commits"},"statuses":{"href":"https://api.github.com/repos/endlessm/eos-knowledge-lib/statuses/1b07eecd39d8b6be72caaacdda97313c50622a8e"}}}}
{"actor":{"display_login":"rmacqueen"}}