{"action":"created","comment":{"url":"https://api.github.com/repos/osiam/connector4java/pulls/comments/51351141","id":51351141,"diff_hunk":"@@ -54,51 +66,51 @@ public void setUp() throws Exception {\n     @Test(expected = IllegalArgumentException.class)\n     public void id_is_null_by_getting_single_user_raises_exception() throws Exception {\n         service.getUser(null, accessToken);\n-\n-        fail(\"Exception expected\");\n     }\n \n     @Test(expected = NullPointerException.class)\n     public void access_token_is_null_by_getting_single_user_raises_exception() throws Exception {\n         service.getUser(searchedID, null);\n-\n-        fail(\"Exception expected\");\n     }\n \n     @Test(expected = NullPointerException.class)\n     public void access_token_is_null_by_getting_all_group_raises_exception() throws Exception {\n         service.getAllUsers(null);\n-\n-        fail(\"Exception expected\");\n     }\n \n     @Test(expected = NullPointerException.class)\n     public void create_null_user_raises_exception() {\n         service.createUser(null, accessToken);\n-\n-        fail(\"Exception excpected\");\n     }\n \n     @Test(expected = NullPointerException.class)\n     public void create_user_with_null_access_token_raises_exception() {\n         User newUser = new User.Builder(\"irrelevant\").build();\n-\n         service.createUser(newUser, null);\n+    }\n \n-        fail(\"Exception excpected\");\n+    @Test(expected = BadRequestException.class)\n+    public void invalid_filter_generates_bad_request() {","path":"src/test/java/org/osiam/client/OsiamUserServiceTest.java","position":76,"original_position":76,"commit_id":"709cdefd116ebf4bff798f58ec006021ca1edf2f","original_commit_id":"709cdefd116ebf4bff798f58ec006021ca1edf2f","user":{"login":"tkrille","id":5213491,"avatar_url":"https://avatars.githubusercontent.com/u/5213491?v=3","gravatar_id":"","url":"https://api.github.com/users/tkrille","html_url":"https://github.com/tkrille","followers_url":"https://api.github.com/users/tkrille/followers","following_url":"https://api.github.com/users/tkrille/following{/other_user}","gists_url":"https://api.github.com/users/tkrille/gists{/gist_id}","starred_url":"https://api.github.com/users/tkrille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkrille/subscriptions","organizations_url":"https://api.github.com/users/tkrille/orgs","repos_url":"https://api.github.com/users/tkrille/repos","events_url":"https://api.github.com/users/tkrille/events{/privacy}","received_events_url":"https://api.github.com/users/tkrille/received_events","type":"User","site_admin":false},"body":"Ooops, It's green now. Hooray!","created_at":"2016-01-30T21:20:09Z","updated_at":"2016-01-30T21:20:09Z","html_url":"https://github.com/osiam/connector4java/pull/185#discussion_r51351141","pull_request_url":"https://api.github.com/repos/osiam/connector4java/pulls/185","_links":{"self":{"href":"https://api.github.com/repos/osiam/connector4java/pulls/comments/51351141"},"html":{"href":"https://github.com/osiam/connector4java/pull/185#discussion_r51351141"},"pull_request":{"href":"https://api.github.com/repos/osiam/connector4java/pulls/185"}}},"pull_request":{"url":"https://api.github.com/repos/osiam/connector4java/pulls/185","id":57727282,"html_url":"https://github.com/osiam/connector4java/pull/185","diff_url":"https://github.com/osiam/connector4java/pull/185.diff","patch_url":"https://github.com/osiam/connector4java/pull/185.patch","issue_url":"https://api.github.com/repos/osiam/connector4java/issues/185","number":185,"state":"open","locked":false,"title":"Handle a 400 BAD REQUEST correctly","user":{"login":"wallner","id":563601,"avatar_url":"https://avatars.githubusercontent.com/u/563601?v=3","gravatar_id":"","url":"https://api.github.com/users/wallner","html_url":"https://github.com/wallner","followers_url":"https://api.github.com/users/wallner/followers","following_url":"https://api.github.com/users/wallner/following{/other_user}","gists_url":"https://api.github.com/users/wallner/gists{/gist_id}","starred_url":"https://api.github.com/users/wallner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallner/subscriptions","organizations_url":"https://api.github.com/users/wallner/orgs","repos_url":"https://api.github.com/users/wallner/repos","events_url":"https://api.github.com/users/wallner/events{/privacy}","received_events_url":"https://api.github.com/users/wallner/received_events","type":"User","site_admin":false},"body":"Fix a bug that turned a 400 BAD REQUEST response code into a\nConflictException instead of the appropriate BadRequestException.\n\nThis pull introduces (MockServer)[http://www.mock-server.com]\nas a utility to write more and better tests.","created_at":"2016-01-30T02:29:27Z","updated_at":"2016-01-30T21:20:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff2098b94000593827d4758d8903098887e6cd37","assignee":{"login":"tkrille","id":5213491,"avatar_url":"https://avatars.githubusercontent.com/u/5213491?v=3","gravatar_id":"","url":"https://api.github.com/users/tkrille","html_url":"https://github.com/tkrille","followers_url":"https://api.github.com/users/tkrille/followers","following_url":"https://api.github.com/users/tkrille/following{/other_user}","gists_url":"https://api.github.com/users/tkrille/gists{/gist_id}","starred_url":"https://api.github.com/users/tkrille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkrille/subscriptions","organizations_url":"https://api.github.com/users/tkrille/orgs","repos_url":"https://api.github.com/users/tkrille/repos","events_url":"https://api.github.com/users/tkrille/events{/privacy}","received_events_url":"https://api.github.com/users/tkrille/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/osiam/connector4java/milestones/7","html_url":"https://github.com/osiam/connector4java/milestones/v1.9","labels_url":"https://api.github.com/repos/osiam/connector4java/milestones/7/labels","id":1553121,"number":7,"title":"v1.9","description":"","creator":{"login":"tkrille","id":5213491,"avatar_url":"https://avatars.githubusercontent.com/u/5213491?v=3","gravatar_id":"","url":"https://api.github.com/users/tkrille","html_url":"https://github.com/tkrille","followers_url":"https://api.github.com/users/tkrille/followers","following_url":"https://api.github.com/users/tkrille/following{/other_user}","gists_url":"https://api.github.com/users/tkrille/gists{/gist_id}","starred_url":"https://api.github.com/users/tkrille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkrille/subscriptions","organizations_url":"https://api.github.com/users/tkrille/orgs","repos_url":"https://api.github.com/users/tkrille/repos","events_url":"https://api.github.com/users/tkrille/events{/privacy}","received_events_url":"https://api.github.com/users/tkrille/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2016-01-30T21:13:09Z","updated_at":"2016-01-30T21:13:34Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/osiam/connector4java/pulls/185/commits","review_comments_url":"https://api.github.com/repos/osiam/connector4java/pulls/185/comments","review_comment_url":"https://api.github.com/repos/osiam/connector4java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/osiam/connector4java/issues/185/comments","statuses_url":"https://api.github.com/repos/osiam/connector4java/statuses/709cdefd116ebf4bff798f58ec006021ca1edf2f","head":{"label":"wallner:bugfix/bad_request","ref":"bugfix/bad_request","sha":"709cdefd116ebf4bff798f58ec006021ca1edf2f","user":{"login":"wallner","id":563601,"avatar_url":"https://avatars.githubusercontent.com/u/563601?v=3","gravatar_id":"","url":"https://api.github.com/users/wallner","html_url":"https://github.com/wallner","followers_url":"https://api.github.com/users/wallner/followers","following_url":"https://api.github.com/users/wallner/following{/other_user}","gists_url":"https://api.github.com/users/wallner/gists{/gist_id}","starred_url":"https://api.github.com/users/wallner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallner/subscriptions","organizations_url":"https://api.github.com/users/wallner/orgs","repos_url":"https://api.github.com/users/wallner/repos","events_url":"https://api.github.com/users/wallner/events{/privacy}","received_events_url":"https://api.github.com/users/wallner/received_events","type":"User","site_admin":false},"repo":{"id":12137416,"name":"connector4java","full_name":"wallner/connector4java","owner":{"login":"wallner","id":563601,"avatar_url":"https://avatars.githubusercontent.com/u/563601?v=3","gravatar_id":"","url":"https://api.github.com/users/wallner","html_url":"https://github.com/wallner","followers_url":"https://api.github.com/users/wallner/followers","following_url":"https://api.github.com/users/wallner/following{/other_user}","gists_url":"https://api.github.com/users/wallner/gists{/gist_id}","starred_url":"https://api.github.com/users/wallner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallner/subscriptions","organizations_url":"https://api.github.com/users/wallner/orgs","repos_url":"https://api.github.com/users/wallner/repos","events_url":"https://api.github.com/users/wallner/events{/privacy}","received_events_url":"https://api.github.com/users/wallner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wallner/connector4java","description":"Native Java API to connect to the REST based OSIAM services","fork":true,"url":"https://api.github.com/repos/wallner/connector4java","forks_url":"https://api.github.com/repos/wallner/connector4java/forks","keys_url":"https://api.github.com/repos/wallner/connector4java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wallner/connector4java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wallner/connector4java/teams","hooks_url":"https://api.github.com/repos/wallner/connector4java/hooks","issue_events_url":"https://api.github.com/repos/wallner/connector4java/issues/events{/number}","events_url":"https://api.github.com/repos/wallner/connector4java/events","assignees_url":"https://api.github.com/repos/wallner/connector4java/assignees{/user}","branches_url":"https://api.github.com/repos/wallner/connector4java/branches{/branch}","tags_url":"https://api.github.com/repos/wallner/connector4java/tags","blobs_url":"https://api.github.com/repos/wallner/connector4java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wallner/connector4java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wallner/connector4java/git/refs{/sha}","trees_url":"https://api.github.com/repos/wallner/connector4java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wallner/connector4java/statuses/{sha}","languages_url":"https://api.github.com/repos/wallner/connector4java/languages","stargazers_url":"https://api.github.com/repos/wallner/connector4java/stargazers","contributors_url":"https://api.github.com/repos/wallner/connector4java/contributors","subscribers_url":"https://api.github.com/repos/wallner/connector4java/subscribers","subscription_url":"https://api.github.com/repos/wallner/connector4java/subscription","commits_url":"https://api.github.com/repos/wallner/connector4java/commits{/sha}","git_commits_url":"https://api.github.com/repos/wallner/connector4java/git/commits{/sha}","comments_url":"https://api.github.com/repos/wallner/connector4java/comments{/number}","issue_comment_url":"https://api.github.com/repos/wallner/connector4java/issues/comments{/number}","contents_url":"https://api.github.com/repos/wallner/connector4java/contents/{+path}","compare_url":"https://api.github.com/repos/wallner/connector4java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wallner/connector4java/merges","archive_url":"https://api.github.com/repos/wallner/connector4java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wallner/connector4java/downloads","issues_url":"https://api.github.com/repos/wallner/connector4java/issues{/number}","pulls_url":"https://api.github.com/repos/wallner/connector4java/pulls{/number}","milestones_url":"https://api.github.com/repos/wallner/connector4java/milestones{/number}","notifications_url":"https://api.github.com/repos/wallner/connector4java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wallner/connector4java/labels{/name}","releases_url":"https://api.github.com/repos/wallner/connector4java/releases{/id}","deployments_url":"https://api.github.com/repos/wallner/connector4java/deployments","created_at":"2013-08-15T15:18:00Z","updated_at":"2014-06-15T11:25:11Z","pushed_at":"2016-01-30T14:18:57Z","git_url":"git://github.com/wallner/connector4java.git","ssh_url":"git@github.com:wallner/connector4java.git","clone_url":"https://github.com/wallner/connector4java.git","svn_url":"https://github.com/wallner/connector4java","homepage":"https://www.osiam.org","size":1271,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"osiam:master","ref":"master","sha":"00a4361816f984e140f7960f7c8a83ae1583d956","user":{"login":"osiam","id":1918807,"avatar_url":"https://avatars.githubusercontent.com/u/1918807?v=3","gravatar_id":"","url":"https://api.github.com/users/osiam","html_url":"https://github.com/osiam","followers_url":"https://api.github.com/users/osiam/followers","following_url":"https://api.github.com/users/osiam/following{/other_user}","gists_url":"https://api.github.com/users/osiam/gists{/gist_id}","starred_url":"https://api.github.com/users/osiam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osiam/subscriptions","organizations_url":"https://api.github.com/users/osiam/orgs","repos_url":"https://api.github.com/users/osiam/repos","events_url":"https://api.github.com/users/osiam/events{/privacy}","received_events_url":"https://api.github.com/users/osiam/received_events","type":"Organization","site_admin":false},"repo":{"id":11176360,"name":"connector4java","full_name":"osiam/connector4java","owner":{"login":"osiam","id":1918807,"avatar_url":"https://avatars.githubusercontent.com/u/1918807?v=3","gravatar_id":"","url":"https://api.github.com/users/osiam","html_url":"https://github.com/osiam","followers_url":"https://api.github.com/users/osiam/followers","following_url":"https://api.github.com/users/osiam/following{/other_user}","gists_url":"https://api.github.com/users/osiam/gists{/gist_id}","starred_url":"https://api.github.com/users/osiam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osiam/subscriptions","organizations_url":"https://api.github.com/users/osiam/orgs","repos_url":"https://api.github.com/users/osiam/repos","events_url":"https://api.github.com/users/osiam/events{/privacy}","received_events_url":"https://api.github.com/users/osiam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/osiam/connector4java","description":"Native Java API to connect to the REST based OSIAM services","fork":false,"url":"https://api.github.com/repos/osiam/connector4java","forks_url":"https://api.github.com/repos/osiam/connector4java/forks","keys_url":"https://api.github.com/repos/osiam/connector4java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osiam/connector4java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osiam/connector4java/teams","hooks_url":"https://api.github.com/repos/osiam/connector4java/hooks","issue_events_url":"https://api.github.com/repos/osiam/connector4java/issues/events{/number}","events_url":"https://api.github.com/repos/osiam/connector4java/events","assignees_url":"https://api.github.com/repos/osiam/connector4java/assignees{/user}","branches_url":"https://api.github.com/repos/osiam/connector4java/branches{/branch}","tags_url":"https://api.github.com/repos/osiam/connector4java/tags","blobs_url":"https://api.github.com/repos/osiam/connector4java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osiam/connector4java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osiam/connector4java/git/refs{/sha}","trees_url":"https://api.github.com/repos/osiam/connector4java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osiam/connector4java/statuses/{sha}","languages_url":"https://api.github.com/repos/osiam/connector4java/languages","stargazers_url":"https://api.github.com/repos/osiam/connector4java/stargazers","contributors_url":"https://api.github.com/repos/osiam/connector4java/contributors","subscribers_url":"https://api.github.com/repos/osiam/connector4java/subscribers","subscription_url":"https://api.github.com/repos/osiam/connector4java/subscription","commits_url":"https://api.github.com/repos/osiam/connector4java/commits{/sha}","git_commits_url":"https://api.github.com/repos/osiam/connector4java/git/commits{/sha}","comments_url":"https://api.github.com/repos/osiam/connector4java/comments{/number}","issue_comment_url":"https://api.github.com/repos/osiam/connector4java/issues/comments{/number}","contents_url":"https://api.github.com/repos/osiam/connector4java/contents/{+path}","compare_url":"https://api.github.com/repos/osiam/connector4java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osiam/connector4java/merges","archive_url":"https://api.github.com/repos/osiam/connector4java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osiam/connector4java/downloads","issues_url":"https://api.github.com/repos/osiam/connector4java/issues{/number}","pulls_url":"https://api.github.com/repos/osiam/connector4java/pulls{/number}","milestones_url":"https://api.github.com/repos/osiam/connector4java/milestones{/number}","notifications_url":"https://api.github.com/repos/osiam/connector4java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osiam/connector4java/labels{/name}","releases_url":"https://api.github.com/repos/osiam/connector4java/releases{/id}","deployments_url":"https://api.github.com/repos/osiam/connector4java/deployments","created_at":"2013-07-04T12:34:05Z","updated_at":"2016-01-25T15:21:36Z","pushed_at":"2016-01-30T14:18:57Z","git_url":"git://github.com/osiam/connector4java.git","ssh_url":"git@github.com:osiam/connector4java.git","clone_url":"https://github.com/osiam/connector4java.git","svn_url":"https://github.com/osiam/connector4java","homepage":"https://www.osiam.org","size":1330,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":6,"forks":13,"open_issues":6,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/osiam/connector4java/pulls/185"},"html":{"href":"https://github.com/osiam/connector4java/pull/185"},"issue":{"href":"https://api.github.com/repos/osiam/connector4java/issues/185"},"comments":{"href":"https://api.github.com/repos/osiam/connector4java/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/osiam/connector4java/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/osiam/connector4java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/osiam/connector4java/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/osiam/connector4java/statuses/709cdefd116ebf4bff798f58ec006021ca1edf2f"}}}}