{"action":"created","issue":{"url":"https://api.github.com/repos/ReactiveX/rxjs/issues/2121","repository_url":"https://api.github.com/repos/ReactiveX/rxjs","labels_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/2121/labels{/name}","comments_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/2121/comments","events_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/2121/events","html_url":"https://github.com/ReactiveX/rxjs/pull/2121","id":188199996,"number":2121,"title":"chore(build): Inject tslib functions","user":{"login":"imcotton","id":149541,"avatar_url":"https://avatars.githubusercontent.com/u/149541?v=3","gravatar_id":"","url":"https://api.github.com/users/imcotton","html_url":"https://github.com/imcotton","followers_url":"https://api.github.com/users/imcotton/followers","following_url":"https://api.github.com/users/imcotton/following{/other_user}","gists_url":"https://api.github.com/users/imcotton/gists{/gist_id}","starred_url":"https://api.github.com/users/imcotton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imcotton/subscriptions","organizations_url":"https://api.github.com/users/imcotton/orgs","repos_url":"https://api.github.com/users/imcotton/repos","events_url":"https://api.github.com/users/imcotton/events{/privacy}","received_events_url":"https://api.github.com/users/imcotton/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-09T09:26:00Z","updated_at":"2016-11-15T11:22:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/2121","html_url":"https://github.com/ReactiveX/rxjs/pull/2121","diff_url":"https://github.com/ReactiveX/rxjs/pull/2121.diff","patch_url":"https://github.com/ReactiveX/rxjs/pull/2121.patch"},"body":"To avoid prepend **tslib** globally."},"comment":{"url":"https://api.github.com/repos/ReactiveX/rxjs/issues/comments/260616205","html_url":"https://github.com/ReactiveX/rxjs/pull/2121#issuecomment-260616205","issue_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/2121","id":260616205,"user":{"login":"imcotton","id":149541,"avatar_url":"https://avatars.githubusercontent.com/u/149541?v=3","gravatar_id":"","url":"https://api.github.com/users/imcotton","html_url":"https://github.com/imcotton","followers_url":"https://api.github.com/users/imcotton/followers","following_url":"https://api.github.com/users/imcotton/following{/other_user}","gists_url":"https://api.github.com/users/imcotton/gists{/gist_id}","starred_url":"https://api.github.com/users/imcotton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imcotton/subscriptions","organizations_url":"https://api.github.com/users/imcotton/orgs","repos_url":"https://api.github.com/users/imcotton/repos","events_url":"https://api.github.com/users/imcotton/events{/privacy}","received_events_url":"https://api.github.com/users/imcotton/received_events","type":"User","site_admin":false},"created_at":"2016-11-15T11:22:31Z","updated_at":"2016-11-15T11:22:31Z","body":"This PR is the first step toward to its ultimate goal, which depends on two another up coming developments:\r\n\r\n  0. Set `--importHelpers` when targeting to TS v2.1\r\n  0. `tslib` module provides full ES6 outputs (Microsoft/tslib#5)\r\n  \r\n\r\nWhere No.1 lands then below changes will no longer required:\r\n\r\n```javascript\r\nrollupInject({\r\n  exclude: 'node_modules/**',\r\n  modules: _.mapValues(tslib, function (value, key) {\r\n    return ['tslib', key];\r\n  }),\r\n})\r\n```\r\n\r\n\r\nWhere No.2 lands then below changes will no longer required:\r\n\r\n```javascript\r\nrollupCommonJS({\r\n  namedExports: {\r\n    tslib: Object.keys(tslib),\r\n  },\r\n})\r\n```\r\n\r\n\r\nThe final result will let `Rollup` being able to tree-shakes every helper functions in `tslib` module, but right now this is as near as it gets.\r\n\r\nTo the test matter that I couldn't figure out yet, would be great to have any suggestion.\r\n"}}
{"actor":{"display_login":"imcotton"}}