{"action":"created","issue":{"url":"https://api.github.com/repos/DoSomething/phoenix/issues/7130","repository_url":"https://api.github.com/repos/DoSomething/phoenix","labels_url":"https://api.github.com/repos/DoSomething/phoenix/issues/7130/labels{/name}","comments_url":"https://api.github.com/repos/DoSomething/phoenix/issues/7130/comments","events_url":"https://api.github.com/repos/DoSomething/phoenix/issues/7130/events","html_url":"https://github.com/DoSomething/phoenix/pull/7130","id":183765033,"number":7130,"title":"don't require caption on RB update","user":{"login":"katiecrane","id":4240292,"avatar_url":"https://avatars.githubusercontent.com/u/4240292?v=3","gravatar_id":"","url":"https://api.github.com/users/katiecrane","html_url":"https://github.com/katiecrane","followers_url":"https://api.github.com/users/katiecrane/followers","following_url":"https://api.github.com/users/katiecrane/following{/other_user}","gists_url":"https://api.github.com/users/katiecrane/gists{/gist_id}","starred_url":"https://api.github.com/users/katiecrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katiecrane/subscriptions","organizations_url":"https://api.github.com/users/katiecrane/orgs","repos_url":"https://api.github.com/users/katiecrane/repos","events_url":"https://api.github.com/users/katiecrane/events{/privacy}","received_events_url":"https://api.github.com/users/katiecrane/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"angaither","id":645205,"avatar_url":"https://avatars.githubusercontent.com/u/645205?v=3","gravatar_id":"","url":"https://api.github.com/users/angaither","html_url":"https://github.com/angaither","followers_url":"https://api.github.com/users/angaither/followers","following_url":"https://api.github.com/users/angaither/following{/other_user}","gists_url":"https://api.github.com/users/angaither/gists{/gist_id}","starred_url":"https://api.github.com/users/angaither/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angaither/subscriptions","organizations_url":"https://api.github.com/users/angaither/orgs","repos_url":"https://api.github.com/users/angaither/repos","events_url":"https://api.github.com/users/angaither/events{/privacy}","received_events_url":"https://api.github.com/users/angaither/received_events","type":"User","site_admin":false},"assignees":[{"login":"angaither","id":645205,"avatar_url":"https://avatars.githubusercontent.com/u/645205?v=3","gravatar_id":"","url":"https://api.github.com/users/angaither","html_url":"https://github.com/angaither","followers_url":"https://api.github.com/users/angaither/followers","following_url":"https://api.github.com/users/angaither/following{/other_user}","gists_url":"https://api.github.com/users/angaither/gists{/gist_id}","starred_url":"https://api.github.com/users/angaither/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angaither/subscriptions","organizations_url":"https://api.github.com/users/angaither/orgs","repos_url":"https://api.github.com/users/angaither/repos","events_url":"https://api.github.com/users/angaither/events{/privacy}","received_events_url":"https://api.github.com/users/angaither/received_events","type":"User","site_admin":false},{"login":"sbsmith86","id":1700409,"avatar_url":"https://avatars.githubusercontent.com/u/1700409?v=3","gravatar_id":"","url":"https://api.github.com/users/sbsmith86","html_url":"https://github.com/sbsmith86","followers_url":"https://api.github.com/users/sbsmith86/followers","following_url":"https://api.github.com/users/sbsmith86/following{/other_user}","gists_url":"https://api.github.com/users/sbsmith86/gists{/gist_id}","starred_url":"https://api.github.com/users/sbsmith86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbsmith86/subscriptions","organizations_url":"https://api.github.com/users/sbsmith86/orgs","repos_url":"https://api.github.com/users/sbsmith86/repos","events_url":"https://api.github.com/users/sbsmith86/events{/privacy}","received_events_url":"https://api.github.com/users/sbsmith86/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-10-18T18:23:10Z","updated_at":"2016-10-18T20:30:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DoSomething/phoenix/pulls/7130","html_url":"https://github.com/DoSomething/phoenix/pull/7130","diff_url":"https://github.com/DoSomething/phoenix/pull/7130.diff","patch_url":"https://github.com/DoSomething/phoenix/pull/7130.patch"},"body":"#### What's this PR do?\r\nUnset `['#attributes']['data-validate']` and `['#required']` on the reportback caption if it is an update to a reportback. Members may submit reportback updates without images, so it doesn't make sense to always require captions.\r\n\r\n#### How should this be reviewed?\r\nSubmit a reportback. Make sure it won't let you submit a reportback without an image OR an image without a caption. Make sure you hit the permalink page.\r\nUpdate your reportback, either the why or the quantity or both! Make sure you hit the permalink page.\r\nTry to update your reportback with an image but no caption. It shouldn't let you.\r\n\r\n#### Any background context you want to provide?\r\nThe caption validation doesn't seem to be anything new, weird that this ever worked. Shoutout to @weerd and @DFurnes for spelunking with me at the end of the day yesterday!\r\n\r\n#### Relevant tickets\r\nFixes #7128\r\n\r\n#### Checklist\r\n- [ ] Tested on staging.\r\n- [ ] Pinged a PM if this is a larger PR that would benefit from some additional testing love (cc: @ngjo)\r\n"},"comment":{"url":"https://api.github.com/repos/DoSomething/phoenix/issues/comments/254630044","html_url":"https://github.com/DoSomething/phoenix/pull/7130#issuecomment-254630044","issue_url":"https://api.github.com/repos/DoSomething/phoenix/issues/7130","id":254630044,"user":{"login":"sbsmith86","id":1700409,"avatar_url":"https://avatars.githubusercontent.com/u/1700409?v=3","gravatar_id":"","url":"https://api.github.com/users/sbsmith86","html_url":"https://github.com/sbsmith86","followers_url":"https://api.github.com/users/sbsmith86/followers","following_url":"https://api.github.com/users/sbsmith86/following{/other_user}","gists_url":"https://api.github.com/users/sbsmith86/gists{/gist_id}","starred_url":"https://api.github.com/users/sbsmith86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbsmith86/subscriptions","organizations_url":"https://api.github.com/users/sbsmith86/orgs","repos_url":"https://api.github.com/users/sbsmith86/repos","events_url":"https://api.github.com/users/sbsmith86/events{/privacy}","received_events_url":"https://api.github.com/users/sbsmith86/received_events","type":"User","site_admin":false},"created_at":"2016-10-18T20:30:37Z","updated_at":"2016-10-18T20:30:37Z","body":"looks fine to me. Did it work before because we were pre populating the form with values from the last submission?"}}
{"actor":{"display_login":"sbsmith86"}}