{"action":"created","issue":{"url":"https://api.github.com/repos/richardforth/apache2buddy/issues/29","repository_url":"https://api.github.com/repos/richardforth/apache2buddy","labels_url":"https://api.github.com/repos/richardforth/apache2buddy/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/richardforth/apache2buddy/issues/29/comments","events_url":"https://api.github.com/repos/richardforth/apache2buddy/issues/29/events","html_url":"https://github.com/richardforth/apache2buddy/issues/29","id":195782250,"number":29,"title":"Fails if vhosts contains more directories","user":{"login":"varyen","id":125340,"avatar_url":"https://avatars.githubusercontent.com/u/125340?v=3","gravatar_id":"","url":"https://api.github.com/users/varyen","html_url":"https://github.com/varyen","followers_url":"https://api.github.com/users/varyen/followers","following_url":"https://api.github.com/users/varyen/following{/other_user}","gists_url":"https://api.github.com/users/varyen/gists{/gist_id}","starred_url":"https://api.github.com/users/varyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varyen/subscriptions","organizations_url":"https://api.github.com/users/varyen/orgs","repos_url":"https://api.github.com/users/varyen/repos","events_url":"https://api.github.com/users/varyen/events{/privacy}","received_events_url":"https://api.github.com/users/varyen/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2016-12-15T11:29:43Z","updated_at":"2016-12-15T15:51:04Z","closed_at":"2016-12-15T14:59:11Z","body":"Hi, I have following structure of my vhost files:\r\n```\r\n/etc/apache2/vhosts/user1/family.user1.com\r\n/etc/apache2/vhosts/user1/thai.user1.com\r\n/etc/apache2/vhosts/user1/valery.user1.com\r\n/etc/apache2/vhosts/user2/user2.ru\r\n```\r\nin `expand_included_files` you use following command to find files in directory:\r\n```\r\n# ls /etc/apache2/vhosts/* 2> /dev/null\r\n/etc/apache2/vhosts/user1:\r\nfamily.user1.com  thai.user1.com  valery.user1.com\r\n\r\n/etc/apache2/vhosts/user2:\r\nuser2.ru\r\n```\r\n\r\nLook's like it should be `**/*` to work as intended\r\n```\r\n# ls /etc/apache2/vhosts/**/*\r\n/etc/apache2/vhosts/user1/family.user1.com  /etc/apache2/vhosts/user1/valery.user1.com  /etc/apache2/vhosts/user2/user2.ru\r\n/etc/apache2/vhosts/user1/thai.user1.com\r\n```\r\n\r\nI'm running Ubuntu 16.04.1 LTS."},"comment":{"url":"https://api.github.com/repos/richardforth/apache2buddy/issues/comments/267362077","html_url":"https://github.com/richardforth/apache2buddy/issues/29#issuecomment-267362077","issue_url":"https://api.github.com/repos/richardforth/apache2buddy/issues/29","id":267362077,"user":{"login":"varyen","id":125340,"avatar_url":"https://avatars.githubusercontent.com/u/125340?v=3","gravatar_id":"","url":"https://api.github.com/users/varyen","html_url":"https://github.com/varyen","followers_url":"https://api.github.com/users/varyen/followers","following_url":"https://api.github.com/users/varyen/following{/other_user}","gists_url":"https://api.github.com/users/varyen/gists{/gist_id}","starred_url":"https://api.github.com/users/varyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varyen/subscriptions","organizations_url":"https://api.github.com/users/varyen/orgs","repos_url":"https://api.github.com/users/varyen/repos","events_url":"https://api.github.com/users/varyen/events{/privacy}","received_events_url":"https://api.github.com/users/varyen/received_events","type":"User","site_admin":false},"created_at":"2016-12-15T15:51:04Z","updated_at":"2016-12-15T15:51:04Z","body":"Still, it's possible, it's documented and it's used that way in many cases.\r\n\r\nI understand that for some reason this bug have never been discovered (submitted?) for all project time being. So it's your decision whether to consider this case or not. All this long code with globs with `dir/*` (not `dir/*.conf` as recommended) could just be `find dir/`, it's universal solution.\r\nYou you just don't have time I can prepare and send you PR with this change. Is it worth it?"}}
{"actor":{"display_login":"varyen"}}