{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/fleet/pulls/comments/53939077","id":53939077,"diff_hunk":"@@ -0,0 +1,148 @@\n+// Copyright 2014 CoreOS, Inc.\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//     http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+package main\n+\n+import (\n+\t\"fmt\"\n+\t\"sync\"\n+\t\"testing\"\n+\t\"time\"\n+\n+\t\"github.com/coreos/fleet/client\"\n+\t\"github.com/coreos/fleet/job\"\n+\t\"github.com/coreos/fleet/machine\"\n+\t\"github.com/coreos/fleet/registry\"\n+\t\"github.com/coreos/fleet/unit\"\n+)\n+\n+type UnloadTestResults struct {\n+\tDescription  string\n+\tUnits        []string\n+\tExpectedExit int\n+}\n+\n+func newFakeRegistryForUnload(prefix string, unitCnt int) client.API {","path":"fleetctl/unload_test.go","position":36,"original_position":36,"commit_id":"c69dfe8572e7875f9f0a8f4a50673cddbaa26e46","original_commit_id":"c69dfe8572e7875f9f0a8f4a50673cddbaa26e46","user":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?v=3","gravatar_id":"","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"body":"naming consistency: unitCnt -> unitCount - everywhere else you're spelling out words","created_at":"2016-02-24T13:42:36Z","updated_at":"2016-02-24T13:42:36Z","html_url":"https://github.com/coreos/fleet/pull/1439#discussion_r53939077","pull_request_url":"https://api.github.com/repos/coreos/fleet/pulls/1439","_links":{"self":{"href":"https://api.github.com/repos/coreos/fleet/pulls/comments/53939077"},"html":{"href":"https://github.com/coreos/fleet/pull/1439#discussion_r53939077"},"pull_request":{"href":"https://api.github.com/repos/coreos/fleet/pulls/1439"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/fleet/pulls/1439","id":60496127,"html_url":"https://github.com/coreos/fleet/pull/1439","diff_url":"https://github.com/coreos/fleet/pull/1439.diff","patch_url":"https://github.com/coreos/fleet/pull/1439.patch","issue_url":"https://api.github.com/repos/coreos/fleet/issues/1439","number":1439,"state":"open","locked":false,"title":"fleetctl: destroy fix and more tests","user":{"login":"tixxdz","id":1549291,"avatar_url":"https://avatars.githubusercontent.com/u/1549291?v=3","gravatar_id":"","url":"https://api.github.com/users/tixxdz","html_url":"https://github.com/tixxdz","followers_url":"https://api.github.com/users/tixxdz/followers","following_url":"https://api.github.com/users/tixxdz/following{/other_user}","gists_url":"https://api.github.com/users/tixxdz/gists{/gist_id}","starred_url":"https://api.github.com/users/tixxdz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tixxdz/subscriptions","organizations_url":"https://api.github.com/users/tixxdz/orgs","repos_url":"https://api.github.com/users/tixxdz/repos","events_url":"https://api.github.com/users/tixxdz/events{/privacy}","received_events_url":"https://api.github.com/users/tixxdz/received_events","type":"User","site_admin":false},"body":"fleetctl destroy fix and more tests. It contains a follow up fix for the race condition that was discussed in this merged PR: https://github.com/coreos/fleet/pull/1417","created_at":"2016-02-24T11:43:35Z","updated_at":"2016-02-24T13:42:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"336be6f3c467387261727bce7f5f9c4561ca3b31","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coreos/fleet/pulls/1439/commits","review_comments_url":"https://api.github.com/repos/coreos/fleet/pulls/1439/comments","review_comment_url":"https://api.github.com/repos/coreos/fleet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/fleet/issues/1439/comments","statuses_url":"https://api.github.com/repos/coreos/fleet/statuses/c69dfe8572e7875f9f0a8f4a50673cddbaa26e46","head":{"label":"endocode:tixxdz/fleet-destroy-and-tests-v1","ref":"tixxdz/fleet-destroy-and-tests-v1","sha":"c69dfe8572e7875f9f0a8f4a50673cddbaa26e46","user":{"login":"endocode","id":4068543,"avatar_url":"https://avatars.githubusercontent.com/u/4068543?v=3","gravatar_id":"","url":"https://api.github.com/users/endocode","html_url":"https://github.com/endocode","followers_url":"https://api.github.com/users/endocode/followers","following_url":"https://api.github.com/users/endocode/following{/other_user}","gists_url":"https://api.github.com/users/endocode/gists{/gist_id}","starred_url":"https://api.github.com/users/endocode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endocode/subscriptions","organizations_url":"https://api.github.com/users/endocode/orgs","repos_url":"https://api.github.com/users/endocode/repos","events_url":"https://api.github.com/users/endocode/events{/privacy}","received_events_url":"https://api.github.com/users/endocode/received_events","type":"Organization","site_admin":false},"repo":{"id":34001513,"name":"fleet","full_name":"endocode/fleet","owner":{"login":"endocode","id":4068543,"avatar_url":"https://avatars.githubusercontent.com/u/4068543?v=3","gravatar_id":"","url":"https://api.github.com/users/endocode","html_url":"https://github.com/endocode","followers_url":"https://api.github.com/users/endocode/followers","following_url":"https://api.github.com/users/endocode/following{/other_user}","gists_url":"https://api.github.com/users/endocode/gists{/gist_id}","starred_url":"https://api.github.com/users/endocode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endocode/subscriptions","organizations_url":"https://api.github.com/users/endocode/orgs","repos_url":"https://api.github.com/users/endocode/repos","events_url":"https://api.github.com/users/endocode/events{/privacy}","received_events_url":"https://api.github.com/users/endocode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endocode/fleet","description":"A Distributed init System","fork":true,"url":"https://api.github.com/repos/endocode/fleet","forks_url":"https://api.github.com/repos/endocode/fleet/forks","keys_url":"https://api.github.com/repos/endocode/fleet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endocode/fleet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endocode/fleet/teams","hooks_url":"https://api.github.com/repos/endocode/fleet/hooks","issue_events_url":"https://api.github.com/repos/endocode/fleet/issues/events{/number}","events_url":"https://api.github.com/repos/endocode/fleet/events","assignees_url":"https://api.github.com/repos/endocode/fleet/assignees{/user}","branches_url":"https://api.github.com/repos/endocode/fleet/branches{/branch}","tags_url":"https://api.github.com/repos/endocode/fleet/tags","blobs_url":"https://api.github.com/repos/endocode/fleet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endocode/fleet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endocode/fleet/git/refs{/sha}","trees_url":"https://api.github.com/repos/endocode/fleet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endocode/fleet/statuses/{sha}","languages_url":"https://api.github.com/repos/endocode/fleet/languages","stargazers_url":"https://api.github.com/repos/endocode/fleet/stargazers","contributors_url":"https://api.github.com/repos/endocode/fleet/contributors","subscribers_url":"https://api.github.com/repos/endocode/fleet/subscribers","subscription_url":"https://api.github.com/repos/endocode/fleet/subscription","commits_url":"https://api.github.com/repos/endocode/fleet/commits{/sha}","git_commits_url":"https://api.github.com/repos/endocode/fleet/git/commits{/sha}","comments_url":"https://api.github.com/repos/endocode/fleet/comments{/number}","issue_comment_url":"https://api.github.com/repos/endocode/fleet/issues/comments{/number}","contents_url":"https://api.github.com/repos/endocode/fleet/contents/{+path}","compare_url":"https://api.github.com/repos/endocode/fleet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endocode/fleet/merges","archive_url":"https://api.github.com/repos/endocode/fleet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endocode/fleet/downloads","issues_url":"https://api.github.com/repos/endocode/fleet/issues{/number}","pulls_url":"https://api.github.com/repos/endocode/fleet/pulls{/number}","milestones_url":"https://api.github.com/repos/endocode/fleet/milestones{/number}","notifications_url":"https://api.github.com/repos/endocode/fleet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endocode/fleet/labels{/name}","releases_url":"https://api.github.com/repos/endocode/fleet/releases{/id}","deployments_url":"https://api.github.com/repos/endocode/fleet/deployments","created_at":"2015-04-15T15:16:33Z","updated_at":"2016-01-27T08:29:06Z","pushed_at":"2016-02-24T12:14:59Z","git_url":"git://github.com/endocode/fleet.git","ssh_url":"git@github.com:endocode/fleet.git","clone_url":"https://github.com/endocode/fleet.git","svn_url":"https://github.com/endocode/fleet","homepage":"","size":6665,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"9b6658df6089ce3225ed9d3385154ad4367a2de1","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":13512328,"name":"fleet","full_name":"coreos/fleet","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/fleet","description":"A Distributed init System","fork":false,"url":"https://api.github.com/repos/coreos/fleet","forks_url":"https://api.github.com/repos/coreos/fleet/forks","keys_url":"https://api.github.com/repos/coreos/fleet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/fleet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/fleet/teams","hooks_url":"https://api.github.com/repos/coreos/fleet/hooks","issue_events_url":"https://api.github.com/repos/coreos/fleet/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/fleet/events","assignees_url":"https://api.github.com/repos/coreos/fleet/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/fleet/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/fleet/tags","blobs_url":"https://api.github.com/repos/coreos/fleet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/fleet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/fleet/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/fleet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/fleet/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/fleet/languages","stargazers_url":"https://api.github.com/repos/coreos/fleet/stargazers","contributors_url":"https://api.github.com/repos/coreos/fleet/contributors","subscribers_url":"https://api.github.com/repos/coreos/fleet/subscribers","subscription_url":"https://api.github.com/repos/coreos/fleet/subscription","commits_url":"https://api.github.com/repos/coreos/fleet/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/fleet/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/fleet/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/fleet/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/fleet/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/fleet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/fleet/merges","archive_url":"https://api.github.com/repos/coreos/fleet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/fleet/downloads","issues_url":"https://api.github.com/repos/coreos/fleet/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/fleet/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/fleet/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/fleet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/fleet/labels{/name}","releases_url":"https://api.github.com/repos/coreos/fleet/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/fleet/deployments","created_at":"2013-10-11T23:56:38Z","updated_at":"2016-02-24T03:01:16Z","pushed_at":"2016-02-24T11:43:35Z","git_url":"git://github.com/coreos/fleet.git","ssh_url":"git@github.com:coreos/fleet.git","clone_url":"https://github.com/coreos/fleet.git","svn_url":"https://github.com/coreos/fleet","homepage":"","size":7816,"stargazers_count":2092,"watchers_count":2092,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":252,"mirror_url":null,"open_issues_count":159,"forks":252,"open_issues":159,"watchers":2092,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/fleet/pulls/1439"},"html":{"href":"https://github.com/coreos/fleet/pull/1439"},"issue":{"href":"https://api.github.com/repos/coreos/fleet/issues/1439"},"comments":{"href":"https://api.github.com/repos/coreos/fleet/issues/1439/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/fleet/pulls/1439/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/fleet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/fleet/pulls/1439/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/fleet/statuses/c69dfe8572e7875f9f0a8f4a50673cddbaa26e46"}}}}