{"action":"created","comment":{"url":"https://api.github.com/repos/cozy/cozy-proxy/pulls/comments/81750387","pull_request_review_id":2706131,"id":81750387,"diff_hunk":"@@ -0,0 +1,111 @@\n+# Local class Step\n+class Step","path":"client/app/lib/onboarding.coffee","position":2,"original_position":2,"commit_id":"e4c67bd8b778a8ef4f1c56e7f41dc6e9499d0337","original_commit_id":"fafcf96be4b5506f32350ae3130d2d960a7c3891","user":{"login":"gregorylegarec","id":776764,"avatar_url":"https://avatars.githubusercontent.com/u/776764?v=3","gravatar_id":"","url":"https://api.github.com/users/gregorylegarec","html_url":"https://github.com/gregorylegarec","followers_url":"https://api.github.com/users/gregorylegarec/followers","following_url":"https://api.github.com/users/gregorylegarec/following{/other_user}","gists_url":"https://api.github.com/users/gregorylegarec/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorylegarec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorylegarec/subscriptions","organizations_url":"https://api.github.com/users/gregorylegarec/orgs","repos_url":"https://api.github.com/users/gregorylegarec/repos","events_url":"https://api.github.com/users/gregorylegarec/events{/privacy}","received_events_url":"https://api.github.com/users/gregorylegarec/received_events","type":"User","site_admin":false},"body":"My opinion is that Step is strongly linked to Onboarding, and almost exclusively used by it. It is almost an internal class.\r\n\r\nFurthermore, onboarding cannot be required without Step with this pattern.\r\n\r\nBut if you prefer I may externalize it.","created_at":"2016-10-04T13:01:55Z","updated_at":"2016-10-04T13:01:55Z","html_url":"https://github.com/cozy/cozy-proxy/pull/303#discussion_r81750387","pull_request_url":"https://api.github.com/repos/cozy/cozy-proxy/pulls/303","_links":{"self":{"href":"https://api.github.com/repos/cozy/cozy-proxy/pulls/comments/81750387"},"html":{"href":"https://github.com/cozy/cozy-proxy/pull/303#discussion_r81750387"},"pull_request":{"href":"https://api.github.com/repos/cozy/cozy-proxy/pulls/303"}}},"pull_request":{"url":"https://api.github.com/repos/cozy/cozy-proxy/pulls/303","id":87673952,"html_url":"https://github.com/cozy/cozy-proxy/pull/303","diff_url":"https://github.com/cozy/cozy-proxy/pull/303.diff","patch_url":"https://github.com/cozy/cozy-proxy/pull/303.patch","issue_url":"https://api.github.com/repos/cozy/cozy-proxy/issues/303","number":303,"state":"open","locked":false,"title":"Add onboarding component","user":{"login":"gregorylegarec","id":776764,"avatar_url":"https://avatars.githubusercontent.com/u/776764?v=3","gravatar_id":"","url":"https://api.github.com/users/gregorylegarec","html_url":"https://github.com/gregorylegarec","followers_url":"https://api.github.com/users/gregorylegarec/followers","following_url":"https://api.github.com/users/gregorylegarec/following{/other_user}","gists_url":"https://api.github.com/users/gregorylegarec/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorylegarec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorylegarec/subscriptions","organizations_url":"https://api.github.com/users/gregorylegarec/orgs","repos_url":"https://api.github.com/users/gregorylegarec/repos","events_url":"https://api.github.com/users/gregorylegarec/events{/privacy}","received_events_url":"https://api.github.com/users/gregorylegarec/received_events","type":"User","site_admin":false},"body":"Contains class, test, and doc. Integration will follow.","created_at":"2016-10-03T07:39:15Z","updated_at":"2016-10-04T13:01:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2825042ada9614739ebbc42888b2c89e34805baa","assignee":{"login":"CPatchane","id":10224453,"avatar_url":"https://avatars.githubusercontent.com/u/10224453?v=3","gravatar_id":"","url":"https://api.github.com/users/CPatchane","html_url":"https://github.com/CPatchane","followers_url":"https://api.github.com/users/CPatchane/followers","following_url":"https://api.github.com/users/CPatchane/following{/other_user}","gists_url":"https://api.github.com/users/CPatchane/gists{/gist_id}","starred_url":"https://api.github.com/users/CPatchane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CPatchane/subscriptions","organizations_url":"https://api.github.com/users/CPatchane/orgs","repos_url":"https://api.github.com/users/CPatchane/repos","events_url":"https://api.github.com/users/CPatchane/events{/privacy}","received_events_url":"https://api.github.com/users/CPatchane/received_events","type":"User","site_admin":false},"assignees":[{"login":"CPatchane","id":10224453,"avatar_url":"https://avatars.githubusercontent.com/u/10224453?v=3","gravatar_id":"","url":"https://api.github.com/users/CPatchane","html_url":"https://github.com/CPatchane","followers_url":"https://api.github.com/users/CPatchane/followers","following_url":"https://api.github.com/users/CPatchane/following{/other_user}","gists_url":"https://api.github.com/users/CPatchane/gists{/gist_id}","starred_url":"https://api.github.com/users/CPatchane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CPatchane/subscriptions","organizations_url":"https://api.github.com/users/CPatchane/orgs","repos_url":"https://api.github.com/users/CPatchane/repos","events_url":"https://api.github.com/users/CPatchane/events{/privacy}","received_events_url":"https://api.github.com/users/CPatchane/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cozy/cozy-proxy/pulls/303/commits","review_comments_url":"https://api.github.com/repos/cozy/cozy-proxy/pulls/303/comments","review_comment_url":"https://api.github.com/repos/cozy/cozy-proxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cozy/cozy-proxy/issues/303/comments","statuses_url":"https://api.github.com/repos/cozy/cozy-proxy/statuses/e4c67bd8b778a8ef4f1c56e7f41dc6e9499d0337","head":{"label":"gregorylegarec:enhancement/onboarding","ref":"enhancement/onboarding","sha":"e4c67bd8b778a8ef4f1c56e7f41dc6e9499d0337","user":{"login":"gregorylegarec","id":776764,"avatar_url":"https://avatars.githubusercontent.com/u/776764?v=3","gravatar_id":"","url":"https://api.github.com/users/gregorylegarec","html_url":"https://github.com/gregorylegarec","followers_url":"https://api.github.com/users/gregorylegarec/followers","following_url":"https://api.github.com/users/gregorylegarec/following{/other_user}","gists_url":"https://api.github.com/users/gregorylegarec/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorylegarec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorylegarec/subscriptions","organizations_url":"https://api.github.com/users/gregorylegarec/orgs","repos_url":"https://api.github.com/users/gregorylegarec/repos","events_url":"https://api.github.com/users/gregorylegarec/events{/privacy}","received_events_url":"https://api.github.com/users/gregorylegarec/received_events","type":"User","site_admin":false},"repo":{"id":69475341,"name":"cozy-proxy","full_name":"gregorylegarec/cozy-proxy","owner":{"login":"gregorylegarec","id":776764,"avatar_url":"https://avatars.githubusercontent.com/u/776764?v=3","gravatar_id":"","url":"https://api.github.com/users/gregorylegarec","html_url":"https://github.com/gregorylegarec","followers_url":"https://api.github.com/users/gregorylegarec/followers","following_url":"https://api.github.com/users/gregorylegarec/following{/other_user}","gists_url":"https://api.github.com/users/gregorylegarec/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorylegarec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorylegarec/subscriptions","organizations_url":"https://api.github.com/users/gregorylegarec/orgs","repos_url":"https://api.github.com/users/gregorylegarec/repos","events_url":"https://api.github.com/users/gregorylegarec/events{/privacy}","received_events_url":"https://api.github.com/users/gregorylegarec/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gregorylegarec/cozy-proxy","description":"Cozy authentication and routing layer","fork":true,"url":"https://api.github.com/repos/gregorylegarec/cozy-proxy","forks_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/forks","keys_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/teams","hooks_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/hooks","issue_events_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/events","assignees_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/tags","blobs_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/languages","stargazers_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/stargazers","contributors_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/contributors","subscribers_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/subscribers","subscription_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/subscription","commits_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/merges","archive_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/downloads","issues_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/labels{/name}","releases_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/releases{/id}","deployments_url":"https://api.github.com/repos/gregorylegarec/cozy-proxy/deployments","created_at":"2016-09-28T15:08:16Z","updated_at":"2016-09-28T15:08:17Z","pushed_at":"2016-10-04T07:58:28Z","git_url":"git://github.com/gregorylegarec/cozy-proxy.git","ssh_url":"git@github.com:gregorylegarec/cozy-proxy.git","clone_url":"https://github.com/gregorylegarec/cozy-proxy.git","svn_url":"https://github.com/gregorylegarec/cozy-proxy","homepage":"https://cozy.io","size":7079,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cozy:development","ref":"development","sha":"29a7b1f17697be8c92e0811a2eec10aef7c0c212","user":{"login":"cozy","id":7690525,"avatar_url":"https://avatars.githubusercontent.com/u/7690525?v=3","gravatar_id":"","url":"https://api.github.com/users/cozy","html_url":"https://github.com/cozy","followers_url":"https://api.github.com/users/cozy/followers","following_url":"https://api.github.com/users/cozy/following{/other_user}","gists_url":"https://api.github.com/users/cozy/gists{/gist_id}","starred_url":"https://api.github.com/users/cozy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cozy/subscriptions","organizations_url":"https://api.github.com/users/cozy/orgs","repos_url":"https://api.github.com/users/cozy/repos","events_url":"https://api.github.com/users/cozy/events{/privacy}","received_events_url":"https://api.github.com/users/cozy/received_events","type":"Organization","site_admin":false},"repo":{"id":3812481,"name":"cozy-proxy","full_name":"cozy/cozy-proxy","owner":{"login":"cozy","id":7690525,"avatar_url":"https://avatars.githubusercontent.com/u/7690525?v=3","gravatar_id":"","url":"https://api.github.com/users/cozy","html_url":"https://github.com/cozy","followers_url":"https://api.github.com/users/cozy/followers","following_url":"https://api.github.com/users/cozy/following{/other_user}","gists_url":"https://api.github.com/users/cozy/gists{/gist_id}","starred_url":"https://api.github.com/users/cozy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cozy/subscriptions","organizations_url":"https://api.github.com/users/cozy/orgs","repos_url":"https://api.github.com/users/cozy/repos","events_url":"https://api.github.com/users/cozy/events{/privacy}","received_events_url":"https://api.github.com/users/cozy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cozy/cozy-proxy","description":"Cozy authentication and routing layer","fork":false,"url":"https://api.github.com/repos/cozy/cozy-proxy","forks_url":"https://api.github.com/repos/cozy/cozy-proxy/forks","keys_url":"https://api.github.com/repos/cozy/cozy-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cozy/cozy-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cozy/cozy-proxy/teams","hooks_url":"https://api.github.com/repos/cozy/cozy-proxy/hooks","issue_events_url":"https://api.github.com/repos/cozy/cozy-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/cozy/cozy-proxy/events","assignees_url":"https://api.github.com/repos/cozy/cozy-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/cozy/cozy-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/cozy/cozy-proxy/tags","blobs_url":"https://api.github.com/repos/cozy/cozy-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cozy/cozy-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cozy/cozy-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/cozy/cozy-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cozy/cozy-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/cozy/cozy-proxy/languages","stargazers_url":"https://api.github.com/repos/cozy/cozy-proxy/stargazers","contributors_url":"https://api.github.com/repos/cozy/cozy-proxy/contributors","subscribers_url":"https://api.github.com/repos/cozy/cozy-proxy/subscribers","subscription_url":"https://api.github.com/repos/cozy/cozy-proxy/subscription","commits_url":"https://api.github.com/repos/cozy/cozy-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/cozy/cozy-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/cozy/cozy-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/cozy/cozy-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/cozy/cozy-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/cozy/cozy-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cozy/cozy-proxy/merges","archive_url":"https://api.github.com/repos/cozy/cozy-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cozy/cozy-proxy/downloads","issues_url":"https://api.github.com/repos/cozy/cozy-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/cozy/cozy-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/cozy/cozy-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/cozy/cozy-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cozy/cozy-proxy/labels{/name}","releases_url":"https://api.github.com/repos/cozy/cozy-proxy/releases{/id}","deployments_url":"https://api.github.com/repos/cozy/cozy-proxy/deployments","created_at":"2012-03-23T20:53:26Z","updated_at":"2016-10-03T14:31:10Z","pushed_at":"2016-10-04T08:00:07Z","git_url":"git://github.com/cozy/cozy-proxy.git","ssh_url":"git@github.com:cozy/cozy-proxy.git","clone_url":"https://github.com/cozy/cozy-proxy.git","svn_url":"https://github.com/cozy/cozy-proxy","homepage":"https://cozy.io","size":7160,"stargazers_count":29,"watchers_count":29,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":32,"forks":35,"open_issues":32,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cozy/cozy-proxy/pulls/303"},"html":{"href":"https://github.com/cozy/cozy-proxy/pull/303"},"issue":{"href":"https://api.github.com/repos/cozy/cozy-proxy/issues/303"},"comments":{"href":"https://api.github.com/repos/cozy/cozy-proxy/issues/303/comments"},"review_comments":{"href":"https://api.github.com/repos/cozy/cozy-proxy/pulls/303/comments"},"review_comment":{"href":"https://api.github.com/repos/cozy/cozy-proxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cozy/cozy-proxy/pulls/303/commits"},"statuses":{"href":"https://api.github.com/repos/cozy/cozy-proxy/statuses/e4c67bd8b778a8ef4f1c56e7f41dc6e9499d0337"}}}}
{"actor":{"display_login":"gregorylegarec"}}