{"action":"created","issue":{"url":"https://api.github.com/repos/Rise-Vision/rise-launcher-electron/issues/178","repository_url":"https://api.github.com/repos/Rise-Vision/rise-launcher-electron","labels_url":"https://api.github.com/repos/Rise-Vision/rise-launcher-electron/issues/178/labels{/name}","comments_url":"https://api.github.com/repos/Rise-Vision/rise-launcher-electron/issues/178/comments","events_url":"https://api.github.com/repos/Rise-Vision/rise-launcher-electron/issues/178/events","html_url":"https://github.com/Rise-Vision/rise-launcher-electron/pull/178","id":133130268,"number":178,"title":"Set logging's main window receiver to null before closing it","user":{"login":"fjvallarino","id":6565497,"avatar_url":"https://avatars.githubusercontent.com/u/6565497?v=3","gravatar_id":"","url":"https://api.github.com/users/fjvallarino","html_url":"https://github.com/fjvallarino","followers_url":"https://api.github.com/users/fjvallarino/followers","following_url":"https://api.github.com/users/fjvallarino/following{/other_user}","gists_url":"https://api.github.com/users/fjvallarino/gists{/gist_id}","starred_url":"https://api.github.com/users/fjvallarino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjvallarino/subscriptions","organizations_url":"https://api.github.com/users/fjvallarino/orgs","repos_url":"https://api.github.com/users/fjvallarino/repos","events_url":"https://api.github.com/users/fjvallarino/events{/privacy}","received_events_url":"https://api.github.com/users/fjvallarino/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-02-12T00:53:02Z","updated_at":"2016-02-12T21:35:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Rise-Vision/rise-launcher-electron/pulls/178","html_url":"https://github.com/Rise-Vision/rise-launcher-electron/pull/178","diff_url":"https://github.com/Rise-Vision/rise-launcher-electron/pull/178.diff","patch_url":"https://github.com/Rise-Vision/rise-launcher-electron/pull/178.patch"},"body":"Set logging's main window receiver to null before closing it, otherwise \"send\" messages from log.progress crash the main process on Windows\r\n\r\nWe already were on v0.36.7 which includes the fix for https://github.com/atom/electron/issues/4279\r\n\r\n@tejohnso @ahmedalsudani please review\r\n"},"comment":{"url":"https://api.github.com/repos/Rise-Vision/rise-launcher-electron/issues/comments/183496586","html_url":"https://github.com/Rise-Vision/rise-launcher-electron/pull/178#issuecomment-183496586","issue_url":"https://api.github.com/repos/Rise-Vision/rise-launcher-electron/issues/178","id":183496586,"user":{"login":"fjvallarino","id":6565497,"avatar_url":"https://avatars.githubusercontent.com/u/6565497?v=3","gravatar_id":"","url":"https://api.github.com/users/fjvallarino","html_url":"https://github.com/fjvallarino","followers_url":"https://api.github.com/users/fjvallarino/followers","following_url":"https://api.github.com/users/fjvallarino/following{/other_user}","gists_url":"https://api.github.com/users/fjvallarino/gists{/gist_id}","starred_url":"https://api.github.com/users/fjvallarino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjvallarino/subscriptions","organizations_url":"https://api.github.com/users/fjvallarino/orgs","repos_url":"https://api.github.com/users/fjvallarino/repos","events_url":"https://api.github.com/users/fjvallarino/events{/privacy}","received_events_url":"https://api.github.com/users/fjvallarino/received_events","type":"User","site_admin":false},"created_at":"2016-02-12T21:35:15Z","updated_at":"2016-02-12T21:35:15Z","body":"@tejohnso My concern in doing that is the MainWndow object could have been deleted and the event not called immediately, allowing for failures on a running download/extraction/etc background process. I also thought about adding a custom close() method to controller.js' mainWindow object, but it means having that module know about log's setMainWindow method. "}}