{"action":"created","issue":{"url":"https://api.github.com/repos/hammerlab/cohorts/issues/75","repository_url":"https://api.github.com/repos/hammerlab/cohorts","labels_url":"https://api.github.com/repos/hammerlab/cohorts/issues/75/labels{/name}","comments_url":"https://api.github.com/repos/hammerlab/cohorts/issues/75/comments","events_url":"https://api.github.com/repos/hammerlab/cohorts/issues/75/events","html_url":"https://github.com/hammerlab/cohorts/pull/75","id":164724936,"number":75,"title":"Add responder_pfs_equals_os options","user":{"login":"tavinathanson","id":322932,"avatar_url":"https://avatars.githubusercontent.com/u/322932?v=3","gravatar_id":"","url":"https://api.github.com/users/tavinathanson","html_url":"https://github.com/tavinathanson","followers_url":"https://api.github.com/users/tavinathanson/followers","following_url":"https://api.github.com/users/tavinathanson/following{/other_user}","gists_url":"https://api.github.com/users/tavinathanson/gists{/gist_id}","starred_url":"https://api.github.com/users/tavinathanson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tavinathanson/subscriptions","organizations_url":"https://api.github.com/users/tavinathanson/orgs","repos_url":"https://api.github.com/users/tavinathanson/repos","events_url":"https://api.github.com/users/tavinathanson/events{/privacy}","received_events_url":"https://api.github.com/users/tavinathanson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"arahuja","id":455755,"avatar_url":"https://avatars.githubusercontent.com/u/455755?v=3","gravatar_id":"","url":"https://api.github.com/users/arahuja","html_url":"https://github.com/arahuja","followers_url":"https://api.github.com/users/arahuja/followers","following_url":"https://api.github.com/users/arahuja/following{/other_user}","gists_url":"https://api.github.com/users/arahuja/gists{/gist_id}","starred_url":"https://api.github.com/users/arahuja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arahuja/subscriptions","organizations_url":"https://api.github.com/users/arahuja/orgs","repos_url":"https://api.github.com/users/arahuja/repos","events_url":"https://api.github.com/users/arahuja/events{/privacy}","received_events_url":"https://api.github.com/users/arahuja/received_events","type":"User","site_admin":false},"assignees":[{"login":"arahuja","id":455755,"avatar_url":"https://avatars.githubusercontent.com/u/455755?v=3","gravatar_id":"","url":"https://api.github.com/users/arahuja","html_url":"https://github.com/arahuja","followers_url":"https://api.github.com/users/arahuja/followers","following_url":"https://api.github.com/users/arahuja/following{/other_user}","gists_url":"https://api.github.com/users/arahuja/gists{/gist_id}","starred_url":"https://api.github.com/users/arahuja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arahuja/subscriptions","organizations_url":"https://api.github.com/users/arahuja/orgs","repos_url":"https://api.github.com/users/arahuja/repos","events_url":"https://api.github.com/users/arahuja/events{/privacy}","received_events_url":"https://api.github.com/users/arahuja/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-07-10T17:18:26Z","updated_at":"2016-07-11T12:08:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hammerlab/cohorts/pulls/75","html_url":"https://github.com/hammerlab/cohorts/pull/75","diff_url":"https://github.com/hammerlab/cohorts/pull/75.diff","patch_url":"https://github.com/hammerlab/cohorts/pull/75.patch"},"body":"Sometimes we can't rely on the fact that a non-responder has PFS < OS and a responder has PFS == OS, so make this assumption optional.\r\n\r\nRelevant discussion (sorry to link to a private repo): https://github.com/hammerlab/bladder-analyses/issues/82#issuecomment-231598825\r\n\r\n@arahuja "},"comment":{"url":"https://api.github.com/repos/hammerlab/cohorts/issues/comments/231716150","html_url":"https://github.com/hammerlab/cohorts/pull/75#issuecomment-231716150","issue_url":"https://api.github.com/repos/hammerlab/cohorts/issues/75","id":231716150,"user":{"login":"tavinathanson","id":322932,"avatar_url":"https://avatars.githubusercontent.com/u/322932?v=3","gravatar_id":"","url":"https://api.github.com/users/tavinathanson","html_url":"https://github.com/tavinathanson","followers_url":"https://api.github.com/users/tavinathanson/followers","following_url":"https://api.github.com/users/tavinathanson/following{/other_user}","gists_url":"https://api.github.com/users/tavinathanson/gists{/gist_id}","starred_url":"https://api.github.com/users/tavinathanson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tavinathanson/subscriptions","organizations_url":"https://api.github.com/users/tavinathanson/orgs","repos_url":"https://api.github.com/users/tavinathanson/repos","events_url":"https://api.github.com/users/tavinathanson/events{/privacy}","received_events_url":"https://api.github.com/users/tavinathanson/received_events","type":"User","site_admin":false},"created_at":"2016-07-11T12:08:22Z","updated_at":"2016-07-11T12:08:22Z","body":"@arahuja I'm okay with defaulting to `False`, though have you specifically run into this constraint or also https://github.com/hammerlab/cohorts/pull/75/files#diff-481facac58e4fae6c10b3d93a889284eR260? I thought mostly you ran into not having PFS and OS values? Maybe another constraint called `require_pfs_and_os` that defaults to `False`, while this one can remain defaulted to `True`?"}}
{"actor":{"display_login":"tavinathanson"}}