{"action":"created","issue":{"url":"https://api.github.com/repos/mesonbuild/meson/issues/639","repository_url":"https://api.github.com/repos/mesonbuild/meson","labels_url":"https://api.github.com/repos/mesonbuild/meson/issues/639/labels{/name}","comments_url":"https://api.github.com/repos/mesonbuild/meson/issues/639/comments","events_url":"https://api.github.com/repos/mesonbuild/meson/issues/639/events","html_url":"https://github.com/mesonbuild/meson/pull/639","id":165414079,"number":639,"title":"tests: Don't fail wxwidgets test if wxwidgets is not installed","user":{"login":"nirbheek","id":75801,"avatar_url":"https://avatars.githubusercontent.com/u/75801?v=3","gravatar_id":"","url":"https://api.github.com/users/nirbheek","html_url":"https://github.com/nirbheek","followers_url":"https://api.github.com/users/nirbheek/followers","following_url":"https://api.github.com/users/nirbheek/following{/other_user}","gists_url":"https://api.github.com/users/nirbheek/gists{/gist_id}","starred_url":"https://api.github.com/users/nirbheek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirbheek/subscriptions","organizations_url":"https://api.github.com/users/nirbheek/orgs","repos_url":"https://api.github.com/users/nirbheek/repos","events_url":"https://api.github.com/users/nirbheek/events{/privacy}","received_events_url":"https://api.github.com/users/nirbheek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-13T20:29:27Z","updated_at":"2016-07-15T10:24:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mesonbuild/meson/pulls/639","html_url":"https://github.com/mesonbuild/meson/pull/639","diff_url":"https://github.com/mesonbuild/meson/pull/639.diff","patch_url":"https://github.com/mesonbuild/meson/pull/639.patch"},"body":"The widgets pull in lots of deprecated libraries, so don't require it"},"comment":{"url":"https://api.github.com/repos/mesonbuild/meson/issues/comments/232916924","html_url":"https://github.com/mesonbuild/meson/pull/639#issuecomment-232916924","issue_url":"https://api.github.com/repos/mesonbuild/meson/issues/639","id":232916924,"user":{"login":"jpakkane","id":4079821,"avatar_url":"https://avatars.githubusercontent.com/u/4079821?v=3","gravatar_id":"","url":"https://api.github.com/users/jpakkane","html_url":"https://github.com/jpakkane","followers_url":"https://api.github.com/users/jpakkane/followers","following_url":"https://api.github.com/users/jpakkane/following{/other_user}","gists_url":"https://api.github.com/users/jpakkane/gists{/gist_id}","starred_url":"https://api.github.com/users/jpakkane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpakkane/subscriptions","organizations_url":"https://api.github.com/users/jpakkane/orgs","repos_url":"https://api.github.com/users/jpakkane/repos","events_url":"https://api.github.com/users/jpakkane/events{/privacy}","received_events_url":"https://api.github.com/users/jpakkane/received_events","type":"User","site_admin":false},"created_at":"2016-07-15T10:24:30Z","updated_at":"2016-07-15T10:24:30Z","body":"The framework tests were originally written to test difficult and uncommon build steps with real world dependencies. As an example Qt needs moc and GTest and GMock need to work both as library and source only dependencies. When I started doing wxwidgets I seem to recall thinking that it required some preprocessing step but the current code at least does not seem to.\r\n\r\nSince this is now a straightforward dep + build, this test is probably not needed. However if there is some preprocessing step needed for some wxwidgets code then we should augment the test to do that.\r\n\r\nSimply disabling tests is a bit tricky because it is easy to accidentally miss the dependency and therefore have the test be inoperative without noticing. We could perhaps update the testing framework so that in this case the build def needs to do something like `message('MESON-TEST-SKIP')` and then the test framework would tag the test skipped rather than passed."}}
{"actor":{"display_login":"jpakkane"}}