{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/65678733","id":65678733,"diff_hunk":"@@ -0,0 +1,105 @@\n+package api\n+\n+import (\n+\tkapi \"k8s.io/kubernetes/pkg/api\"\n+\t\"k8s.io/kubernetes/pkg/api/unversioned\"\n+)\n+\n+// PodSecurityPolicySubjectReview checks whether a particular user/SA tuple can create the PodSpec.\n+type PodSecurityPolicySubjectReview struct {\n+\tunversioned.TypeMeta\n+\n+\t// Spec defines specification for the PodSecurityPolicySubjectReview.\n+\tSpec PodSecurityPolicySubjectReviewSpec\n+\n+\t// Status represents the current information/status for the PodSecurityPolicySubjectReview.\n+\tStatus PodSecurityPolicySubjectReviewStatus\n+}\n+\n+// PodSecurityPolicySubjectReviewSpec defines specification for PodSecurityPolicySubjectReview\n+type PodSecurityPolicySubjectReviewSpec struct {\n+\t// PodSpec is the PodSpec to check. If PodSpec.ServiceAccountName is empty it will not be defaulted.\n+\t// If its non-empty, it will be checked.\n+\tPodSpec kapi.PodSpec\n+\n+\t// User is the user you're testing for.\n+\t// If you specify \"User\" but not \"Group\", then is it interpreted as \"What if User were not a member of any groups.\n+\t// If User and Groups are empty, then the check is performed using *only* the ServiceAccountName in the PodSpec.\n+\tUser string\n+\n+\t// Groups is the groups you're testing for.\n+\tGroups []string\n+}\n+\n+// PodSecurityPolicySubjectReviewStatus contains information/status for PodSecurityPolicySubjectReview.\n+type PodSecurityPolicySubjectReviewStatus struct {\n+\t// AllowedBy is a reference to the rule that allows the PodSpec.\n+\t// A rule can be a SecurityContextConstraint or a PodSecurityPolicy\n+\t// A `nil`, indicates that it was denied.\n+\tAllowedBy *kapi.ObjectReference\n+\n+\t// A machine-readable description of why this operation is in the\n+\t// \"Failure\" status. If this value is empty there\n+\t// is no information available.\n+\tReason string\n+\n+\t// PodSpec is the PodSpec after the defaulting is applied.\n+\tPodSpec kapi.PodSpec\n+}\n+\n+// PodSecurityPolicySelfSubjectReview checks whether this user/SA tuple can create the PodSpec.\n+type PodSecurityPolicySelfSubjectReview struct {\n+\tunversioned.TypeMeta\n+\n+\t// Spec defines specification the PodSecurityPolicySelfSubjectReview.\n+\tSpec PodSecurityPolicySelfSubjectReviewSpec\n+\n+\t// Status represents the current information/status for the PodSecurityPolicySelfSubjectReview.\n+\tStatus PodSecurityPolicySubjectReviewStatus\n+}\n+\n+// PodSecurityPolicySelfSubjectReviewSpec contains specification for PodSecurityPolicySelfSubjectReview.\n+type PodSecurityPolicySelfSubjectReviewSpec struct {\n+\t// PodSpec is the PodSpec to check.\n+\tPodSpec kapi.PodSpec\n+}\n+\n+// PodSecurityPolicyReview checks which service accounts (not users, since that would be cluster-wide) can create the `PodSpec` in question.\n+type PodSecurityPolicyReview struct {\n+\tunversioned.TypeMeta\n+\n+\t// Spec is the PodSecurityPolicy to check.\n+\tSpec PodSecurityPolicyReviewSpec\n+\n+\t// Status represents the current information/status for the PodSecurityPolicyReview.\n+\tStatus PodSecurityPolicyReviewStatus\n+}\n+\n+// PodSecurityPolicyReviewSpec defines specification for PodSecurityPolicyReview\n+type PodSecurityPolicyReviewSpec struct {\n+\t// PodSpec is the PodSpec to check. The PodSpec.ServiceAccountName field is used\n+\t// if ServiceAccountNames is empty, unless the PodSpec.ServiceAccountName is empty,\n+\t// in which case \"default\" is used.\n+\t// If ServiceAccountNames is specified, PodSpec.ServiceAccountName is ignored.\n+\tPodSpec kapi.PodSpec\n+\n+\t// ServiceAccountNames is an optional set of ServiceAccounts to run the check with.\n+\t// If ServiceAccountNames is empty, the PodSpec ServiceAccountName is used,\n+\t// unless it's empty, in which case \"default\" is used instead.","path":"pkg/security/api/types.go","position":88,"original_position":88,"commit_id":"10ebc9a27abe275fcf5bfde4a289796f121362ed","original_commit_id":"10ebc9a27abe275fcf5bfde4a289796f121362ed","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"body":"this comment doesn't make a lot of sense","created_at":"2016-06-03T09:17:55Z","updated_at":"2016-06-03T09:17:55Z","html_url":"https://github.com/openshift/origin/pull/8941#discussion_r65678733","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/8941","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/65678733"},"html":{"href":"https://github.com/openshift/origin/pull/8941#discussion_r65678733"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/8941"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/8941","id":70698180,"html_url":"https://github.com/openshift/origin/pull/8941","diff_url":"https://github.com/openshift/origin/pull/8941.diff","patch_url":"https://github.com/openshift/origin/pull/8941.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/8941","number":8941,"state":"open","locked":false,"title":"Scc check only api","user":{"login":"sdminonne","id":9527409,"avatar_url":"https://avatars.githubusercontent.com/u/9527409?v=3","gravatar_id":"","url":"https://api.github.com/users/sdminonne","html_url":"https://github.com/sdminonne","followers_url":"https://api.github.com/users/sdminonne/followers","following_url":"https://api.github.com/users/sdminonne/following{/other_user}","gists_url":"https://api.github.com/users/sdminonne/gists{/gist_id}","starred_url":"https://api.github.com/users/sdminonne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdminonne/subscriptions","organizations_url":"https://api.github.com/users/sdminonne/orgs","repos_url":"https://api.github.com/users/sdminonne/repos","events_url":"https://api.github.com/users/sdminonne/events{/privacy}","received_events_url":"https://api.github.com/users/sdminonne/received_events","type":"User","site_admin":false},"body":"@deads2k  ref #8199 and #8776\r\nAs discussed [here](https://github.com/openshift/origin/pull/8776#issuecomment-219822316) this PR contains API/types only. Thanks to have a look\r\n\r\nMain stuff:\r\n- internal types json tags removed\r\n- removed v1beta3\r\n- Added validation for new types and unit tests, and registered","created_at":"2016-05-19T13:55:12Z","updated_at":"2016-06-03T09:17:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03935785e9247648ba73ab26fa0b18401b18a75e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/8941/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/8941/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/8941/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/10ebc9a27abe275fcf5bfde4a289796f121362ed","head":{"label":"sdminonne:SCC_check_only_API","ref":"SCC_check_only_API","sha":"10ebc9a27abe275fcf5bfde4a289796f121362ed","user":{"login":"sdminonne","id":9527409,"avatar_url":"https://avatars.githubusercontent.com/u/9527409?v=3","gravatar_id":"","url":"https://api.github.com/users/sdminonne","html_url":"https://github.com/sdminonne","followers_url":"https://api.github.com/users/sdminonne/followers","following_url":"https://api.github.com/users/sdminonne/following{/other_user}","gists_url":"https://api.github.com/users/sdminonne/gists{/gist_id}","starred_url":"https://api.github.com/users/sdminonne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdminonne/subscriptions","organizations_url":"https://api.github.com/users/sdminonne/orgs","repos_url":"https://api.github.com/users/sdminonne/repos","events_url":"https://api.github.com/users/sdminonne/events{/privacy}","received_events_url":"https://api.github.com/users/sdminonne/received_events","type":"User","site_admin":false},"repo":{"id":26127471,"name":"origin","full_name":"sdminonne/origin","owner":{"login":"sdminonne","id":9527409,"avatar_url":"https://avatars.githubusercontent.com/u/9527409?v=3","gravatar_id":"","url":"https://api.github.com/users/sdminonne","html_url":"https://github.com/sdminonne","followers_url":"https://api.github.com/users/sdminonne/followers","following_url":"https://api.github.com/users/sdminonne/following{/other_user}","gists_url":"https://api.github.com/users/sdminonne/gists{/gist_id}","starred_url":"https://api.github.com/users/sdminonne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdminonne/subscriptions","organizations_url":"https://api.github.com/users/sdminonne/orgs","repos_url":"https://api.github.com/users/sdminonne/repos","events_url":"https://api.github.com/users/sdminonne/events{/privacy}","received_events_url":"https://api.github.com/users/sdminonne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sdminonne/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/sdminonne/origin","forks_url":"https://api.github.com/repos/sdminonne/origin/forks","keys_url":"https://api.github.com/repos/sdminonne/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdminonne/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdminonne/origin/teams","hooks_url":"https://api.github.com/repos/sdminonne/origin/hooks","issue_events_url":"https://api.github.com/repos/sdminonne/origin/issues/events{/number}","events_url":"https://api.github.com/repos/sdminonne/origin/events","assignees_url":"https://api.github.com/repos/sdminonne/origin/assignees{/user}","branches_url":"https://api.github.com/repos/sdminonne/origin/branches{/branch}","tags_url":"https://api.github.com/repos/sdminonne/origin/tags","blobs_url":"https://api.github.com/repos/sdminonne/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdminonne/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdminonne/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdminonne/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdminonne/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/sdminonne/origin/languages","stargazers_url":"https://api.github.com/repos/sdminonne/origin/stargazers","contributors_url":"https://api.github.com/repos/sdminonne/origin/contributors","subscribers_url":"https://api.github.com/repos/sdminonne/origin/subscribers","subscription_url":"https://api.github.com/repos/sdminonne/origin/subscription","commits_url":"https://api.github.com/repos/sdminonne/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdminonne/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdminonne/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdminonne/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdminonne/origin/contents/{+path}","compare_url":"https://api.github.com/repos/sdminonne/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdminonne/origin/merges","archive_url":"https://api.github.com/repos/sdminonne/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdminonne/origin/downloads","issues_url":"https://api.github.com/repos/sdminonne/origin/issues{/number}","pulls_url":"https://api.github.com/repos/sdminonne/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/sdminonne/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/sdminonne/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdminonne/origin/labels{/name}","releases_url":"https://api.github.com/repos/sdminonne/origin/releases{/id}","deployments_url":"https://api.github.com/repos/sdminonne/origin/deployments","created_at":"2014-11-03T16:25:35Z","updated_at":"2016-02-10T14:21:44Z","pushed_at":"2016-06-03T08:52:00Z","git_url":"git://github.com/sdminonne/origin.git","ssh_url":"git@github.com:sdminonne/origin.git","clone_url":"https://github.com/sdminonne/origin.git","svn_url":"https://github.com/sdminonne/origin","homepage":"https://openshift.github.io","size":264895,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"dc90f2284084c920d3d014e237ca6e1a0164097d","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift - Build, deploy, and manage cloud-native and legacy applications with Kubernetes and Docker","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-06-02T20:07:44Z","pushed_at":"2016-06-03T08:52:01Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":509877,"stargazers_count":1332,"watchers_count":1332,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":801,"mirror_url":null,"open_issues_count":1052,"forks":801,"open_issues":1052,"watchers":1332,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/8941"},"html":{"href":"https://github.com/openshift/origin/pull/8941"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/8941"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/8941/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/8941/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/8941/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/10ebc9a27abe275fcf5bfde4a289796f121362ed"}}}}
{"actor":{"display_login":"kargakis"}}