{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/buildtools/pulls/comments/65420424","id":65420424,"diff_hunk":"@@ -85,9 +85,9 @@\n     <!-- gather the test archives for upload -->\n     <ItemGroup>\n       <ForUpload Include=\"$(TestArchivesRoot)**/*.zip\" />\n-      <ForUpload Include=\"$(AnyOSTestArchivesRoot)*.zip\" />","path":"src/Microsoft.DotNet.Build.CloudTestTasks/PackageFiles/CloudTest.targets","position":4,"original_position":4,"commit_id":"8cafb83594a36177f01affb49e5da43643fa7e2a","original_commit_id":"8cafb83594a36177f01affb49e5da43643fa7e2a","user":{"login":"karajas","id":15918264,"avatar_url":"https://avatars.githubusercontent.com/u/15918264?v=3","gravatar_id":"","url":"https://api.github.com/users/karajas","html_url":"https://github.com/karajas","followers_url":"https://api.github.com/users/karajas/followers","following_url":"https://api.github.com/users/karajas/following{/other_user}","gists_url":"https://api.github.com/users/karajas/gists{/gist_id}","starred_url":"https://api.github.com/users/karajas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karajas/subscriptions","organizations_url":"https://api.github.com/users/karajas/orgs","repos_url":"https://api.github.com/users/karajas/repos","events_url":"https://api.github.com/users/karajas/events{/privacy}","received_events_url":"https://api.github.com/users/karajas/received_events","type":"User","site_admin":false},"body":"Since this change simply includes all files under the test archive dir, it should be alright.","created_at":"2016-06-01T18:50:27Z","updated_at":"2016-06-01T18:50:27Z","html_url":"https://github.com/dotnet/buildtools/pull/770#discussion_r65420424","pull_request_url":"https://api.github.com/repos/dotnet/buildtools/pulls/770","_links":{"self":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/comments/65420424"},"html":{"href":"https://github.com/dotnet/buildtools/pull/770#discussion_r65420424"},"pull_request":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/770"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/buildtools/pulls/770","id":72228184,"html_url":"https://github.com/dotnet/buildtools/pull/770","diff_url":"https://github.com/dotnet/buildtools/pull/770.diff","patch_url":"https://github.com/dotnet/buildtools/pull/770.patch","issue_url":"https://api.github.com/repos/dotnet/buildtools/issues/770","number":770,"state":"open","locked":false,"title":"Resolve correct test assets for netstandard","user":{"login":"karajas","id":15918264,"avatar_url":"https://avatars.githubusercontent.com/u/15918264?v=3","gravatar_id":"","url":"https://api.github.com/users/karajas","html_url":"https://github.com/karajas","followers_url":"https://api.github.com/users/karajas/followers","following_url":"https://api.github.com/users/karajas/following{/other_user}","gists_url":"https://api.github.com/users/karajas/gists{/gist_id}","starred_url":"https://api.github.com/users/karajas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karajas/subscriptions","organizations_url":"https://api.github.com/users/karajas/orgs","repos_url":"https://api.github.com/users/karajas/repos","events_url":"https://api.github.com/users/karajas/events{/privacy}","received_events_url":"https://api.github.com/users/karajas/received_events","type":"User","site_admin":false},"body":"This change will introduce 3 changes to buildtools. \r\n\r\n1. It allows for the restoration of xunit packages to the netstandard framework moniker. It introduces a new Microsoft.DotNet.BuildTools.TestSuite package which will be the metapackage brought down in test-runtime for all xunit dependencies. This is a set of repackaged xunit dependencies until official xunit  packages update to rc2. This package also contains the runtime.json which specifies the supported (Target Framework Moniker X Runtime Identifier) combination which will be used by test project.jsons to list their supported platforms.\r\n\r\n2. GetApplicableAssetsFromPackages will now error out instead of falling back onto older generations during resolution of compile/runtime assets. (Change done by @ericstj )\r\n\r\n3. This change introduces the TestTFM property, which will allow the selection of test assets for a given framework moniker. Currently this only supports netstandard1.3 supported monikers. The idea is that a test will compile in corefx for a netstandard version(currently netstandard1.3 or higher) then utilize this property to pull in the corresponding runtime assets.\r\n\r\n/cc @tarekgh @weshaggard ","created_at":"2016-06-01T18:20:23Z","updated_at":"2016-06-01T18:50:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86caf9f05b4890358a5c6cc486bd39f02a9f8c9f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/buildtools/pulls/770/commits","review_comments_url":"https://api.github.com/repos/dotnet/buildtools/pulls/770/comments","review_comment_url":"https://api.github.com/repos/dotnet/buildtools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/buildtools/issues/770/comments","statuses_url":"https://api.github.com/repos/dotnet/buildtools/statuses/8cafb83594a36177f01affb49e5da43643fa7e2a","head":{"label":"karajas:CompileForNetStandard","ref":"CompileForNetStandard","sha":"8cafb83594a36177f01affb49e5da43643fa7e2a","user":{"login":"karajas","id":15918264,"avatar_url":"https://avatars.githubusercontent.com/u/15918264?v=3","gravatar_id":"","url":"https://api.github.com/users/karajas","html_url":"https://github.com/karajas","followers_url":"https://api.github.com/users/karajas/followers","following_url":"https://api.github.com/users/karajas/following{/other_user}","gists_url":"https://api.github.com/users/karajas/gists{/gist_id}","starred_url":"https://api.github.com/users/karajas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karajas/subscriptions","organizations_url":"https://api.github.com/users/karajas/orgs","repos_url":"https://api.github.com/users/karajas/repos","events_url":"https://api.github.com/users/karajas/events{/privacy}","received_events_url":"https://api.github.com/users/karajas/received_events","type":"User","site_admin":false},"repo":{"id":46463283,"name":"buildtools","full_name":"karajas/buildtools","owner":{"login":"karajas","id":15918264,"avatar_url":"https://avatars.githubusercontent.com/u/15918264?v=3","gravatar_id":"","url":"https://api.github.com/users/karajas","html_url":"https://github.com/karajas","followers_url":"https://api.github.com/users/karajas/followers","following_url":"https://api.github.com/users/karajas/following{/other_user}","gists_url":"https://api.github.com/users/karajas/gists{/gist_id}","starred_url":"https://api.github.com/users/karajas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karajas/subscriptions","organizations_url":"https://api.github.com/users/karajas/orgs","repos_url":"https://api.github.com/users/karajas/repos","events_url":"https://api.github.com/users/karajas/events{/privacy}","received_events_url":"https://api.github.com/users/karajas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/karajas/buildtools","description":"Build tools that are necessary for building the .NET Core projects","fork":true,"url":"https://api.github.com/repos/karajas/buildtools","forks_url":"https://api.github.com/repos/karajas/buildtools/forks","keys_url":"https://api.github.com/repos/karajas/buildtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karajas/buildtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karajas/buildtools/teams","hooks_url":"https://api.github.com/repos/karajas/buildtools/hooks","issue_events_url":"https://api.github.com/repos/karajas/buildtools/issues/events{/number}","events_url":"https://api.github.com/repos/karajas/buildtools/events","assignees_url":"https://api.github.com/repos/karajas/buildtools/assignees{/user}","branches_url":"https://api.github.com/repos/karajas/buildtools/branches{/branch}","tags_url":"https://api.github.com/repos/karajas/buildtools/tags","blobs_url":"https://api.github.com/repos/karajas/buildtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karajas/buildtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karajas/buildtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/karajas/buildtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karajas/buildtools/statuses/{sha}","languages_url":"https://api.github.com/repos/karajas/buildtools/languages","stargazers_url":"https://api.github.com/repos/karajas/buildtools/stargazers","contributors_url":"https://api.github.com/repos/karajas/buildtools/contributors","subscribers_url":"https://api.github.com/repos/karajas/buildtools/subscribers","subscription_url":"https://api.github.com/repos/karajas/buildtools/subscription","commits_url":"https://api.github.com/repos/karajas/buildtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/karajas/buildtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/karajas/buildtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/karajas/buildtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/karajas/buildtools/contents/{+path}","compare_url":"https://api.github.com/repos/karajas/buildtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karajas/buildtools/merges","archive_url":"https://api.github.com/repos/karajas/buildtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karajas/buildtools/downloads","issues_url":"https://api.github.com/repos/karajas/buildtools/issues{/number}","pulls_url":"https://api.github.com/repos/karajas/buildtools/pulls{/number}","milestones_url":"https://api.github.com/repos/karajas/buildtools/milestones{/number}","notifications_url":"https://api.github.com/repos/karajas/buildtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karajas/buildtools/labels{/name}","releases_url":"https://api.github.com/repos/karajas/buildtools/releases{/id}","deployments_url":"https://api.github.com/repos/karajas/buildtools/deployments","created_at":"2015-11-19T02:53:47Z","updated_at":"2016-03-24T10:11:08Z","pushed_at":"2016-06-01T18:08:16Z","git_url":"git://github.com/karajas/buildtools.git","ssh_url":"git@github.com:karajas/buildtools.git","clone_url":"https://github.com/karajas/buildtools.git","svn_url":"https://github.com/karajas/buildtools","homepage":"","size":19772,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"ecfd83e05f1c539a949c02a1075e48ed979dab55","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295349,"name":"buildtools","full_name":"dotnet/buildtools","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/buildtools","description":"Build tools that are necessary for building the .NET Core projects","fork":false,"url":"https://api.github.com/repos/dotnet/buildtools","forks_url":"https://api.github.com/repos/dotnet/buildtools/forks","keys_url":"https://api.github.com/repos/dotnet/buildtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/buildtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/buildtools/teams","hooks_url":"https://api.github.com/repos/dotnet/buildtools/hooks","issue_events_url":"https://api.github.com/repos/dotnet/buildtools/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/buildtools/events","assignees_url":"https://api.github.com/repos/dotnet/buildtools/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/buildtools/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/buildtools/tags","blobs_url":"https://api.github.com/repos/dotnet/buildtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/buildtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/buildtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/buildtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/buildtools/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/buildtools/languages","stargazers_url":"https://api.github.com/repos/dotnet/buildtools/stargazers","contributors_url":"https://api.github.com/repos/dotnet/buildtools/contributors","subscribers_url":"https://api.github.com/repos/dotnet/buildtools/subscribers","subscription_url":"https://api.github.com/repos/dotnet/buildtools/subscription","commits_url":"https://api.github.com/repos/dotnet/buildtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/buildtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/buildtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/buildtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/buildtools/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/buildtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/buildtools/merges","archive_url":"https://api.github.com/repos/dotnet/buildtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/buildtools/downloads","issues_url":"https://api.github.com/repos/dotnet/buildtools/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/buildtools/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/buildtools/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/buildtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/buildtools/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/buildtools/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/buildtools/deployments","created_at":"2014-11-06T23:43:05Z","updated_at":"2016-05-24T07:11:42Z","pushed_at":"2016-06-01T18:20:24Z","git_url":"git://github.com/dotnet/buildtools.git","ssh_url":"git@github.com:dotnet/buildtools.git","clone_url":"https://github.com/dotnet/buildtools.git","svn_url":"https://github.com/dotnet/buildtools","homepage":"","size":3913,"stargazers_count":405,"watchers_count":405,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":184,"mirror_url":null,"open_issues_count":69,"forks":184,"open_issues":69,"watchers":405,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/770"},"html":{"href":"https://github.com/dotnet/buildtools/pull/770"},"issue":{"href":"https://api.github.com/repos/dotnet/buildtools/issues/770"},"comments":{"href":"https://api.github.com/repos/dotnet/buildtools/issues/770/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/770/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/770/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/buildtools/statuses/8cafb83594a36177f01affb49e5da43643fa7e2a"}}}}
{"actor":{"display_login":"karajas"}}