{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/frontend/pulls/comments/89795153","pull_request_review_id":10328943,"id":89795153,"diff_hunk":"@@ -36,32 +40,47 @@\n \n   # Simple Smart Answer pages\n   get \":slug/y(/*responses)\" => \"simple_smart_answers#flow\", :as => :smart_answer_flow\n-  get \":slug\", to: \"simple_smart_answers#show\", constraints: FormatRoutingConstraint.new('simple_smart_answer')\n+  constraints FormatRoutingConstraint.new('simple_smart_answer') do\n+    get \":slug\", to: \"simple_smart_answers#show\"\n+    get \":slug/:part\", to: redirect('/%{slug}') # Support for simple smart answers that were once a format with parts\n+  end\n \n-  # Help pages\n-  get \"/help\", to: \"help#index\"\n-  get \"/tour\", to: \"help#tour\"\n-  get \"*slug\", slug: %r{help/.+}, to: \"help#show\", constraints: FormatRoutingConstraint.new('help_page')\n+  # Campaign pages.\n+  get \"/ukwelcomes\", to: \"campaign#uk_welcomes\" # This is a hardcoded page in Frontend and does not have an associated artefact\n+  constraints FormatRoutingConstraint.new('campaign') do\n+    get \":slug\", to: \"campaign#show\"\n+    get \":slug/:part\", to: redirect('/%{slug}') # Support for campaigns that were once a format with parts","path":"config/routes.rb","position":35,"original_position":35,"commit_id":"4e1d180f16d5dade44414a0c4c27621dcbe2c22c","original_commit_id":"4e1d180f16d5dade44414a0c4c27621dcbe2c22c","user":{"login":"davidbasalla","id":5112255,"avatar_url":"https://avatars.githubusercontent.com/u/5112255?v=3","gravatar_id":"","url":"https://api.github.com/users/davidbasalla","html_url":"https://github.com/davidbasalla","followers_url":"https://api.github.com/users/davidbasalla/followers","following_url":"https://api.github.com/users/davidbasalla/following{/other_user}","gists_url":"https://api.github.com/users/davidbasalla/gists{/gist_id}","starred_url":"https://api.github.com/users/davidbasalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidbasalla/subscriptions","organizations_url":"https://api.github.com/users/davidbasalla/orgs","repos_url":"https://api.github.com/users/davidbasalla/repos","events_url":"https://api.github.com/users/davidbasalla/events{/privacy}","received_events_url":"https://api.github.com/users/davidbasalla/received_events","type":"User","site_admin":false},"body":"Ah good find! So that means we don't have to worry about doing the 'part' redirect for Transactions, Campaigns and Help Pages...","created_at":"2016-11-28T14:53:11Z","updated_at":"2016-11-28T14:53:11Z","html_url":"https://github.com/alphagov/frontend/pull/1062#discussion_r89795153","pull_request_url":"https://api.github.com/repos/alphagov/frontend/pulls/1062","_links":{"self":{"href":"https://api.github.com/repos/alphagov/frontend/pulls/comments/89795153"},"html":{"href":"https://github.com/alphagov/frontend/pull/1062#discussion_r89795153"},"pull_request":{"href":"https://api.github.com/repos/alphagov/frontend/pulls/1062"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/frontend/pulls/1062","id":95220620,"html_url":"https://github.com/alphagov/frontend/pull/1062","diff_url":"https://github.com/alphagov/frontend/pull/1062.diff","patch_url":"https://github.com/alphagov/frontend/pull/1062.patch","issue_url":"https://api.github.com/repos/alphagov/frontend/issues/1062","number":1062,"state":"open","locked":false,"title":"Fix error handling for unsupported routes","user":{"login":"davidbasalla","id":5112255,"avatar_url":"https://avatars.githubusercontent.com/u/5112255?v=3","gravatar_id":"","url":"https://api.github.com/users/davidbasalla","html_url":"https://github.com/davidbasalla","followers_url":"https://api.github.com/users/davidbasalla/followers","following_url":"https://api.github.com/users/davidbasalla/following{/other_user}","gists_url":"https://api.github.com/users/davidbasalla/gists{/gist_id}","starred_url":"https://api.github.com/users/davidbasalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidbasalla/subscriptions","organizations_url":"https://api.github.com/users/davidbasalla/orgs","repos_url":"https://api.github.com/users/davidbasalla/repos","events_url":"https://api.github.com/users/davidbasalla/events{/privacy}","received_events_url":"https://api.github.com/users/davidbasalla/received_events","type":"User","site_admin":false},"body":"This PR aims to fix the following issues:\r\n- more comprehensive test coverage for 'parts' for Guides and Programmes\r\n- avoid ['refactored' formats](https://trello.com/c/phpe3PAO/546-refactor-frontend-overview-card-5) accidentally being handled by RootController \r\n- 500 errors for POST requests that actually 'GET' content ([as seen in Errbit](https://errbit.publishing.service.gov.uk/apps/53611a4b0da1151271001055/problems/583454d5657863164c0d0000))\r\n- update RootController tests to no longer use refactored formats as test date","created_at":"2016-11-24T19:09:32Z","updated_at":"2016-11-28T14:53:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fac00d7a802c3feb0646c39690562a1ad622dbfa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/frontend/pulls/1062/commits","review_comments_url":"https://api.github.com/repos/alphagov/frontend/pulls/1062/comments","review_comment_url":"https://api.github.com/repos/alphagov/frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/frontend/issues/1062/comments","statuses_url":"https://api.github.com/repos/alphagov/frontend/statuses/4e1d180f16d5dade44414a0c4c27621dcbe2c22c","head":{"label":"alphagov:fix-error-handling-for-unsupported-routes","ref":"fix-error-handling-for-unsupported-routes","sha":"4e1d180f16d5dade44414a0c4c27621dcbe2c22c","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":2331534,"name":"frontend","full_name":"alphagov/frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/frontend","description":"Serves mainstream formats, the homepage, and search on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/frontend","forks_url":"https://api.github.com/repos/alphagov/frontend/forks","keys_url":"https://api.github.com/repos/alphagov/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/frontend/events","assignees_url":"https://api.github.com/repos/alphagov/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/frontend/merges","archive_url":"https://api.github.com/repos/alphagov/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/frontend/deployments","created_at":"2011-09-06T00:16:08Z","updated_at":"2016-11-11T12:06:27Z","pushed_at":"2016-11-28T14:51:26Z","git_url":"git://github.com/alphagov/frontend.git","ssh_url":"git@github.com:alphagov/frontend.git","clone_url":"https://github.com/alphagov/frontend.git","svn_url":"https://github.com/alphagov/frontend","homepage":"https://www.gov.uk/","size":28863,"stargazers_count":210,"watchers_count":210,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":10,"forks":47,"open_issues":10,"watchers":210,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"4953109151d1228153981783d28fd80b7e75df33","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":2331534,"name":"frontend","full_name":"alphagov/frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/frontend","description":"Serves mainstream formats, the homepage, and search on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/frontend","forks_url":"https://api.github.com/repos/alphagov/frontend/forks","keys_url":"https://api.github.com/repos/alphagov/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/frontend/events","assignees_url":"https://api.github.com/repos/alphagov/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/frontend/merges","archive_url":"https://api.github.com/repos/alphagov/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/frontend/deployments","created_at":"2011-09-06T00:16:08Z","updated_at":"2016-11-11T12:06:27Z","pushed_at":"2016-11-28T14:51:26Z","git_url":"git://github.com/alphagov/frontend.git","ssh_url":"git@github.com:alphagov/frontend.git","clone_url":"https://github.com/alphagov/frontend.git","svn_url":"https://github.com/alphagov/frontend","homepage":"https://www.gov.uk/","size":28863,"stargazers_count":210,"watchers_count":210,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":10,"forks":47,"open_issues":10,"watchers":210,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/frontend/pulls/1062"},"html":{"href":"https://github.com/alphagov/frontend/pull/1062"},"issue":{"href":"https://api.github.com/repos/alphagov/frontend/issues/1062"},"comments":{"href":"https://api.github.com/repos/alphagov/frontend/issues/1062/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/frontend/pulls/1062/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/frontend/pulls/1062/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/frontend/statuses/4e1d180f16d5dade44414a0c4c27621dcbe2c22c"}}}}
{"actor":{"display_login":"davidbasalla"}}