{"action":"created","issue":{"url":"https://api.github.com/repos/chef/mixlib-log/issues/13","repository_url":"https://api.github.com/repos/chef/mixlib-log","labels_url":"https://api.github.com/repos/chef/mixlib-log/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/chef/mixlib-log/issues/13/comments","events_url":"https://api.github.com/repos/chef/mixlib-log/issues/13/events","html_url":"https://github.com/chef/mixlib-log/pull/13","id":126283909,"number":13,"title":"File log devices opened by mixlib-log should be closed.","user":{"login":"mhorbul","id":2446,"avatar_url":"https://avatars.githubusercontent.com/u/2446?v=3","gravatar_id":"","url":"https://api.github.com/users/mhorbul","html_url":"https://github.com/mhorbul","followers_url":"https://api.github.com/users/mhorbul/followers","following_url":"https://api.github.com/users/mhorbul/following{/other_user}","gists_url":"https://api.github.com/users/mhorbul/gists{/gist_id}","starred_url":"https://api.github.com/users/mhorbul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhorbul/subscriptions","organizations_url":"https://api.github.com/users/mhorbul/orgs","repos_url":"https://api.github.com/users/mhorbul/repos","events_url":"https://api.github.com/users/mhorbul/events{/privacy}","received_events_url":"https://api.github.com/users/mhorbul/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-01-12T21:44:30Z","updated_at":"2016-05-31T07:06:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/chef/mixlib-log/pulls/13","html_url":"https://github.com/chef/mixlib-log/pull/13","diff_url":"https://github.com/chef/mixlib-log/pull/13.diff","patch_url":"https://github.com/chef/mixlib-log/pull/13.patch"},"body":"Ruby does not have a destructor concept so the opened files should be closed explicitly. \r\nThe Ruby Logger which is used as a default logger here does not close log devices it opened until #close method is called. When #rest! happens the logger instance gets destroyed but the #close method\r\nis not triggered.\r\nThis patch should help to solve the problem described here: https://github.com/chef/chef/issues/3435"},"comment":{"url":"https://api.github.com/repos/chef/mixlib-log/issues/comments/222608458","html_url":"https://github.com/chef/mixlib-log/pull/13#issuecomment-222608458","issue_url":"https://api.github.com/repos/chef/mixlib-log/issues/13","id":222608458,"user":{"login":"thommay","id":8500,"avatar_url":"https://avatars.githubusercontent.com/u/8500?v=3","gravatar_id":"","url":"https://api.github.com/users/thommay","html_url":"https://github.com/thommay","followers_url":"https://api.github.com/users/thommay/followers","following_url":"https://api.github.com/users/thommay/following{/other_user}","gists_url":"https://api.github.com/users/thommay/gists{/gist_id}","starred_url":"https://api.github.com/users/thommay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thommay/subscriptions","organizations_url":"https://api.github.com/users/thommay/orgs","repos_url":"https://api.github.com/users/thommay/repos","events_url":"https://api.github.com/users/thommay/events{/privacy}","received_events_url":"https://api.github.com/users/thommay/received_events","type":"User","site_admin":false},"created_at":"2016-05-31T07:06:37Z","updated_at":"2016-05-31T07:06:37Z","body":"Seems like a reasonable thing to do. @chef/client-core review?"}}
{"actor":{"display_login":"thommay"}}