{"action":"created","comment":{"url":"https://api.github.com/repos/Teradata/presto/pulls/comments/68292329","id":68292329,"diff_hunk":"@@ -0,0 +1,46 @@\n+======\n+REVOKE\n+======\n+\n+Synopsis\n+--------\n+\n+.. code-block:: none\n+\n+    REVOKE [ GRANT OPTION FOR ]\n+    (privilege [, ...] | ALL PRIVILEGES)\n+    ON TABLE? table_name FROM grantee\n+\n+Description\n+-----------\n+\n+Revokes the specified privileges from the specified grantee.\n+\n+Specifying ``ALL PRIVILEGES`` revokes ``DELETE, INSERT`` and ``SELECT`` privileges.\n+\n+Specifying ``PUBLIC`` revokes privileges from all grantees.\n+\n+The optional ``GRANT OPTION FOR`` clause also revokes the privileges to grant the specified privileges.\n+\n+Grant command succeeds provided the grantor possesses the specified privileges as well as the `GRANT OPTION` for those privileges.\n+\n+Examples\n+--------\n+\n+Revoke ``INSERT`` and ``SELECT`` privileges on the table ``orders`` from user ``alice``::\n+\n+    GRANT\n+    INSERT, SELECT\n+    ON orders FROM alice;\n+\n+Revoke ``SELECT`` privilege on the table ``nation`` from all the users, additionally revoking the privilege to grant ``SELECT`` privilege::","path":"presto-docs/src/main/sphinx/sql/revoke.rst","position":36,"original_position":36,"commit_id":"5e892897c9bba46d48ea0af4cfed0ce342c31542","original_commit_id":"5e892897c9bba46d48ea0af4cfed0ce342c31542","user":{"login":"amrutagokhale","id":9261099,"avatar_url":"https://avatars.githubusercontent.com/u/9261099?v=3","gravatar_id":"","url":"https://api.github.com/users/amrutagokhale","html_url":"https://github.com/amrutagokhale","followers_url":"https://api.github.com/users/amrutagokhale/followers","following_url":"https://api.github.com/users/amrutagokhale/following{/other_user}","gists_url":"https://api.github.com/users/amrutagokhale/gists{/gist_id}","starred_url":"https://api.github.com/users/amrutagokhale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amrutagokhale/subscriptions","organizations_url":"https://api.github.com/users/amrutagokhale/orgs","repos_url":"https://api.github.com/users/amrutagokhale/repos","events_url":"https://api.github.com/users/amrutagokhale/events{/privacy}","received_events_url":"https://api.github.com/users/amrutagokhale/received_events","type":"User","site_admin":false},"body":"Yes, that's right. You will have to execute the two commands.","created_at":"2016-06-23T18:45:30Z","updated_at":"2016-06-23T18:45:30Z","html_url":"https://github.com/Teradata/presto/pull/232#discussion_r68292329","pull_request_url":"https://api.github.com/repos/Teradata/presto/pulls/232","_links":{"self":{"href":"https://api.github.com/repos/Teradata/presto/pulls/comments/68292329"},"html":{"href":"https://github.com/Teradata/presto/pull/232#discussion_r68292329"},"pull_request":{"href":"https://api.github.com/repos/Teradata/presto/pulls/232"}}},"pull_request":{"url":"https://api.github.com/repos/Teradata/presto/pulls/232","id":74958474,"html_url":"https://github.com/Teradata/presto/pull/232","diff_url":"https://github.com/Teradata/presto/pull/232.diff","patch_url":"https://github.com/Teradata/presto/pull/232.patch","issue_url":"https://api.github.com/repos/Teradata/presto/issues/232","number":232,"state":"open","locked":false,"title":"Add documentation for GRANT and REVOKE","user":{"login":"amrutagokhale","id":9261099,"avatar_url":"https://avatars.githubusercontent.com/u/9261099?v=3","gravatar_id":"","url":"https://api.github.com/users/amrutagokhale","html_url":"https://github.com/amrutagokhale","followers_url":"https://api.github.com/users/amrutagokhale/followers","following_url":"https://api.github.com/users/amrutagokhale/following{/other_user}","gists_url":"https://api.github.com/users/amrutagokhale/gists{/gist_id}","starred_url":"https://api.github.com/users/amrutagokhale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amrutagokhale/subscriptions","organizations_url":"https://api.github.com/users/amrutagokhale/orgs","repos_url":"https://api.github.com/users/amrutagokhale/repos","events_url":"https://api.github.com/users/amrutagokhale/events{/privacy}","received_events_url":"https://api.github.com/users/amrutagokhale/received_events","type":"User","site_admin":false},"body":"@petroav can you please take a look?\r\n\r\nA note about grant/revoke limitation: At present, the grant and revoke commands are only supported for hive connector. There are two places where I can mention this limitation: \r\n(1) On the “Grant” and “Revoke” pages, which will describe the respective syntax, and will go under “SQL Statement Syntax” in here https://prestodb.io/docs/current/sql.html \r\n(2) On individual connector pages, there is a section called \"<Connector Name> Limitations”. For ex., for MySQL connector, if you scroll all the way to the bottom on this page https://prestodb.io/docs/current/connector/mysql.html, there is a section called \"MySQL Connector Limitations” which lists the SQL statements not yet supported for MySQL. I can similarly list grant/revoke as a limitation for every connector except hive. \r\nI am leaning towards approach (1), since I think, not explicitly mentioning it on the syntax page would be misleading. But the current Presto documentation seems to follow (2).\r\n\r\nLet me know what you think.","created_at":"2016-06-23T13:52:00Z","updated_at":"2016-06-23T18:45:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa8beeee6d9c6450df3fe99f4bfff93915f6c5bd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Teradata/presto/pulls/232/commits","review_comments_url":"https://api.github.com/repos/Teradata/presto/pulls/232/comments","review_comment_url":"https://api.github.com/repos/Teradata/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Teradata/presto/issues/232/comments","statuses_url":"https://api.github.com/repos/Teradata/presto/statuses/5e892897c9bba46d48ea0af4cfed0ce342c31542","head":{"label":"Teradata:grant_revoke_doc","ref":"grant_revoke_doc","sha":"5e892897c9bba46d48ea0af4cfed0ce342c31542","user":{"login":"Teradata","id":1615979,"avatar_url":"https://avatars.githubusercontent.com/u/1615979?v=3","gravatar_id":"","url":"https://api.github.com/users/Teradata","html_url":"https://github.com/Teradata","followers_url":"https://api.github.com/users/Teradata/followers","following_url":"https://api.github.com/users/Teradata/following{/other_user}","gists_url":"https://api.github.com/users/Teradata/gists{/gist_id}","starred_url":"https://api.github.com/users/Teradata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teradata/subscriptions","organizations_url":"https://api.github.com/users/Teradata/orgs","repos_url":"https://api.github.com/users/Teradata/repos","events_url":"https://api.github.com/users/Teradata/events{/privacy}","received_events_url":"https://api.github.com/users/Teradata/received_events","type":"Organization","site_admin":false},"repo":{"id":36903368,"name":"presto","full_name":"Teradata/presto","owner":{"login":"Teradata","id":1615979,"avatar_url":"https://avatars.githubusercontent.com/u/1615979?v=3","gravatar_id":"","url":"https://api.github.com/users/Teradata","html_url":"https://github.com/Teradata","followers_url":"https://api.github.com/users/Teradata/followers","following_url":"https://api.github.com/users/Teradata/following{/other_user}","gists_url":"https://api.github.com/users/Teradata/gists{/gist_id}","starred_url":"https://api.github.com/users/Teradata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teradata/subscriptions","organizations_url":"https://api.github.com/users/Teradata/orgs","repos_url":"https://api.github.com/users/Teradata/repos","events_url":"https://api.github.com/users/Teradata/events{/privacy}","received_events_url":"https://api.github.com/users/Teradata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Teradata/presto","description":"Teradata's Certified Version of Presto -- A Distributed SQL Query Engine for Big Data","fork":true,"url":"https://api.github.com/repos/Teradata/presto","forks_url":"https://api.github.com/repos/Teradata/presto/forks","keys_url":"https://api.github.com/repos/Teradata/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Teradata/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Teradata/presto/teams","hooks_url":"https://api.github.com/repos/Teradata/presto/hooks","issue_events_url":"https://api.github.com/repos/Teradata/presto/issues/events{/number}","events_url":"https://api.github.com/repos/Teradata/presto/events","assignees_url":"https://api.github.com/repos/Teradata/presto/assignees{/user}","branches_url":"https://api.github.com/repos/Teradata/presto/branches{/branch}","tags_url":"https://api.github.com/repos/Teradata/presto/tags","blobs_url":"https://api.github.com/repos/Teradata/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Teradata/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Teradata/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/Teradata/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Teradata/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/Teradata/presto/languages","stargazers_url":"https://api.github.com/repos/Teradata/presto/stargazers","contributors_url":"https://api.github.com/repos/Teradata/presto/contributors","subscribers_url":"https://api.github.com/repos/Teradata/presto/subscribers","subscription_url":"https://api.github.com/repos/Teradata/presto/subscription","commits_url":"https://api.github.com/repos/Teradata/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/Teradata/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/Teradata/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/Teradata/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/Teradata/presto/contents/{+path}","compare_url":"https://api.github.com/repos/Teradata/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Teradata/presto/merges","archive_url":"https://api.github.com/repos/Teradata/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Teradata/presto/downloads","issues_url":"https://api.github.com/repos/Teradata/presto/issues{/number}","pulls_url":"https://api.github.com/repos/Teradata/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/Teradata/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/Teradata/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Teradata/presto/labels{/name}","releases_url":"https://api.github.com/repos/Teradata/presto/releases{/id}","deployments_url":"https://api.github.com/repos/Teradata/presto/deployments","created_at":"2015-06-05T00:38:37Z","updated_at":"2016-06-14T07:29:49Z","pushed_at":"2016-06-23T18:13:24Z","git_url":"git://github.com/Teradata/presto.git","ssh_url":"git@github.com:Teradata/presto.git","clone_url":"https://github.com/Teradata/presto.git","svn_url":"https://github.com/Teradata/presto","homepage":"http://www.teradata.com/presto","size":143886,"stargazers_count":51,"watchers_count":51,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":13,"forks":8,"open_issues":13,"watchers":51,"default_branch":"master"}},"base":{"label":"Teradata:sprint-33","ref":"sprint-33","sha":"5a8bfe7cce095e17b6060af2ee016e222dea4358","user":{"login":"Teradata","id":1615979,"avatar_url":"https://avatars.githubusercontent.com/u/1615979?v=3","gravatar_id":"","url":"https://api.github.com/users/Teradata","html_url":"https://github.com/Teradata","followers_url":"https://api.github.com/users/Teradata/followers","following_url":"https://api.github.com/users/Teradata/following{/other_user}","gists_url":"https://api.github.com/users/Teradata/gists{/gist_id}","starred_url":"https://api.github.com/users/Teradata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teradata/subscriptions","organizations_url":"https://api.github.com/users/Teradata/orgs","repos_url":"https://api.github.com/users/Teradata/repos","events_url":"https://api.github.com/users/Teradata/events{/privacy}","received_events_url":"https://api.github.com/users/Teradata/received_events","type":"Organization","site_admin":false},"repo":{"id":36903368,"name":"presto","full_name":"Teradata/presto","owner":{"login":"Teradata","id":1615979,"avatar_url":"https://avatars.githubusercontent.com/u/1615979?v=3","gravatar_id":"","url":"https://api.github.com/users/Teradata","html_url":"https://github.com/Teradata","followers_url":"https://api.github.com/users/Teradata/followers","following_url":"https://api.github.com/users/Teradata/following{/other_user}","gists_url":"https://api.github.com/users/Teradata/gists{/gist_id}","starred_url":"https://api.github.com/users/Teradata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teradata/subscriptions","organizations_url":"https://api.github.com/users/Teradata/orgs","repos_url":"https://api.github.com/users/Teradata/repos","events_url":"https://api.github.com/users/Teradata/events{/privacy}","received_events_url":"https://api.github.com/users/Teradata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Teradata/presto","description":"Teradata's Certified Version of Presto -- A Distributed SQL Query Engine for Big Data","fork":true,"url":"https://api.github.com/repos/Teradata/presto","forks_url":"https://api.github.com/repos/Teradata/presto/forks","keys_url":"https://api.github.com/repos/Teradata/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Teradata/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Teradata/presto/teams","hooks_url":"https://api.github.com/repos/Teradata/presto/hooks","issue_events_url":"https://api.github.com/repos/Teradata/presto/issues/events{/number}","events_url":"https://api.github.com/repos/Teradata/presto/events","assignees_url":"https://api.github.com/repos/Teradata/presto/assignees{/user}","branches_url":"https://api.github.com/repos/Teradata/presto/branches{/branch}","tags_url":"https://api.github.com/repos/Teradata/presto/tags","blobs_url":"https://api.github.com/repos/Teradata/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Teradata/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Teradata/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/Teradata/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Teradata/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/Teradata/presto/languages","stargazers_url":"https://api.github.com/repos/Teradata/presto/stargazers","contributors_url":"https://api.github.com/repos/Teradata/presto/contributors","subscribers_url":"https://api.github.com/repos/Teradata/presto/subscribers","subscription_url":"https://api.github.com/repos/Teradata/presto/subscription","commits_url":"https://api.github.com/repos/Teradata/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/Teradata/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/Teradata/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/Teradata/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/Teradata/presto/contents/{+path}","compare_url":"https://api.github.com/repos/Teradata/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Teradata/presto/merges","archive_url":"https://api.github.com/repos/Teradata/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Teradata/presto/downloads","issues_url":"https://api.github.com/repos/Teradata/presto/issues{/number}","pulls_url":"https://api.github.com/repos/Teradata/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/Teradata/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/Teradata/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Teradata/presto/labels{/name}","releases_url":"https://api.github.com/repos/Teradata/presto/releases{/id}","deployments_url":"https://api.github.com/repos/Teradata/presto/deployments","created_at":"2015-06-05T00:38:37Z","updated_at":"2016-06-14T07:29:49Z","pushed_at":"2016-06-23T18:13:24Z","git_url":"git://github.com/Teradata/presto.git","ssh_url":"git@github.com:Teradata/presto.git","clone_url":"https://github.com/Teradata/presto.git","svn_url":"https://github.com/Teradata/presto","homepage":"http://www.teradata.com/presto","size":143886,"stargazers_count":51,"watchers_count":51,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":13,"forks":8,"open_issues":13,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Teradata/presto/pulls/232"},"html":{"href":"https://github.com/Teradata/presto/pull/232"},"issue":{"href":"https://api.github.com/repos/Teradata/presto/issues/232"},"comments":{"href":"https://api.github.com/repos/Teradata/presto/issues/232/comments"},"review_comments":{"href":"https://api.github.com/repos/Teradata/presto/pulls/232/comments"},"review_comment":{"href":"https://api.github.com/repos/Teradata/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Teradata/presto/pulls/232/commits"},"statuses":{"href":"https://api.github.com/repos/Teradata/presto/statuses/5e892897c9bba46d48ea0af4cfed0ce342c31542"}}}}
{"actor":{"display_login":"amrutagokhale"}}