{"action":"created","comment":{"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments/62558737","id":62558737,"diff_hunk":"@@ -11,10 +11,45 @@ angular.module('calcentral.controllers').controller('UserOverviewController', fu\n     isLoading: true,\n     excludeLinksToRegistrar: true\n   };\n+  $scope.holds = {};\n+  $scope.holdsInfo = {\n+    isLoading: true\n+  };\n+  $scope.regblocks = {};\n+  $scope.residency = {\n+    isLoading: true\n+  };\n+  $scope.statusHoldsBlocks = {};\n+  $scope.studentInfo = {\n+    isLoading: true\n+  };\n   $scope.targetUser = {\n     isLoading: true\n   };\n \n+  $scope.$watchGroup(['studentInfo.regStatus.code', 'api.user.profile.features.csHolds'], function(newValues) {\n+    var enabledSections = [];\n+\n+    if (newValues[0] !== null) {\n+      enabledSections.push('Status');\n+    }\n+\n+    if (newValues[1]) {\n+      enabledSections.push('Holds');\n+    }\n+\n+    enabledSections.push('Blocks');\n+","path":"src/assets/javascripts/angular/controllers/pages/userOverviewController.js","position":32,"original_position":32,"commit_id":"7f2e79af042a26e35bdf33aff9b598f886b6817d","original_commit_id":"7f2e79af042a26e35bdf33aff9b598f886b6817d","user":{"login":"johncrossman","id":7606442,"avatar_url":"https://avatars.githubusercontent.com/u/7606442?v=3","gravatar_id":"","url":"https://api.github.com/users/johncrossman","html_url":"https://github.com/johncrossman","followers_url":"https://api.github.com/users/johncrossman/followers","following_url":"https://api.github.com/users/johncrossman/following{/other_user}","gists_url":"https://api.github.com/users/johncrossman/gists{/gist_id}","starred_url":"https://api.github.com/users/johncrossman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johncrossman/subscriptions","organizations_url":"https://api.github.com/users/johncrossman/orgs","repos_url":"https://api.github.com/users/johncrossman/repos","events_url":"https://api.github.com/users/johncrossman/events{/privacy}","received_events_url":"https://api.github.com/users/johncrossman/received_events","type":"User","site_admin":false},"body":"@davidlimcheng Minor request: please remove a few of these extra line breaks.","created_at":"2016-05-09T19:34:41Z","updated_at":"2016-05-09T19:34:41Z","html_url":"https://github.com/ets-berkeley-edu/calcentral/pull/5363#discussion_r62558737","pull_request_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/5363","_links":{"self":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments/62558737"},"html":{"href":"https://github.com/ets-berkeley-edu/calcentral/pull/5363#discussion_r62558737"},"pull_request":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/5363"}}},"pull_request":{"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/5363","id":69393115,"html_url":"https://github.com/ets-berkeley-edu/calcentral/pull/5363","diff_url":"https://github.com/ets-berkeley-edu/calcentral/pull/5363.diff","patch_url":"https://github.com/ets-berkeley-edu/calcentral/pull/5363.patch","issue_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/5363","number":5363,"state":"open","locked":false,"title":"SISRP-18000 - 5.4 - Student Overview - Status, Blocks and Holds (GL change request 5.4 to 5.6)","user":{"login":"davidlimcheng","id":12127480,"avatar_url":"https://avatars.githubusercontent.com/u/12127480?v=3","gravatar_id":"","url":"https://api.github.com/users/davidlimcheng","html_url":"https://github.com/davidlimcheng","followers_url":"https://api.github.com/users/davidlimcheng/followers","following_url":"https://api.github.com/users/davidlimcheng/following{/other_user}","gists_url":"https://api.github.com/users/davidlimcheng/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlimcheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlimcheng/subscriptions","organizations_url":"https://api.github.com/users/davidlimcheng/orgs","repos_url":"https://api.github.com/users/davidlimcheng/repos","events_url":"https://api.github.com/users/davidlimcheng/events{/privacy}","received_events_url":"https://api.github.com/users/davidlimcheng/received_events","type":"User","site_admin":false},"body":"https://jira.berkeley.edu/browse/SISRP-18000\r\n\r\nCurrently, the experience for this card feels kind of fragmented due to the stitching together of different sources leading to the absence of one spinner for all three sections (Status, Holds, Blocks).  I'm not sure if we want one spinner or three spinners, but in any case, right now we have 1 spinner (for Holds), and Status and Blocks sections that do not have spinners but loads data dynamically.  I assume this is due to the implementations of those sections before the spinner directive was created.\r\n\r\nI think it'd be a good idea to go back and clean up the spinner behavior for each respective section - created [SISRP-18950](https://jira.berkeley.edu/browse/SISRP-18950) for that purpose.  I didn't include it in this PR because I think it just would have made this that much larger than it already is - and it would be touching on a card that is shown in many different places.","created_at":"2016-05-09T18:58:56Z","updated_at":"2016-05-09T19:34:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"774a0912124822e593313f854046e1156a683a04","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/5363/commits","review_comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/5363/comments","review_comment_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/5363/comments","statuses_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/7f2e79af042a26e35bdf33aff9b598f886b6817d","head":{"label":"davidlimcheng:SISRP-18000","ref":"SISRP-18000","sha":"7f2e79af042a26e35bdf33aff9b598f886b6817d","user":{"login":"davidlimcheng","id":12127480,"avatar_url":"https://avatars.githubusercontent.com/u/12127480?v=3","gravatar_id":"","url":"https://api.github.com/users/davidlimcheng","html_url":"https://github.com/davidlimcheng","followers_url":"https://api.github.com/users/davidlimcheng/followers","following_url":"https://api.github.com/users/davidlimcheng/following{/other_user}","gists_url":"https://api.github.com/users/davidlimcheng/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlimcheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlimcheng/subscriptions","organizations_url":"https://api.github.com/users/davidlimcheng/orgs","repos_url":"https://api.github.com/users/davidlimcheng/repos","events_url":"https://api.github.com/users/davidlimcheng/events{/privacy}","received_events_url":"https://api.github.com/users/davidlimcheng/received_events","type":"User","site_admin":false},"repo":{"id":34630716,"name":"calcentral","full_name":"davidlimcheng/calcentral","owner":{"login":"davidlimcheng","id":12127480,"avatar_url":"https://avatars.githubusercontent.com/u/12127480?v=3","gravatar_id":"","url":"https://api.github.com/users/davidlimcheng","html_url":"https://github.com/davidlimcheng","followers_url":"https://api.github.com/users/davidlimcheng/followers","following_url":"https://api.github.com/users/davidlimcheng/following{/other_user}","gists_url":"https://api.github.com/users/davidlimcheng/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlimcheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlimcheng/subscriptions","organizations_url":"https://api.github.com/users/davidlimcheng/orgs","repos_url":"https://api.github.com/users/davidlimcheng/repos","events_url":"https://api.github.com/users/davidlimcheng/events{/privacy}","received_events_url":"https://api.github.com/users/davidlimcheng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidlimcheng/calcentral","description":"","fork":true,"url":"https://api.github.com/repos/davidlimcheng/calcentral","forks_url":"https://api.github.com/repos/davidlimcheng/calcentral/forks","keys_url":"https://api.github.com/repos/davidlimcheng/calcentral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidlimcheng/calcentral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidlimcheng/calcentral/teams","hooks_url":"https://api.github.com/repos/davidlimcheng/calcentral/hooks","issue_events_url":"https://api.github.com/repos/davidlimcheng/calcentral/issues/events{/number}","events_url":"https://api.github.com/repos/davidlimcheng/calcentral/events","assignees_url":"https://api.github.com/repos/davidlimcheng/calcentral/assignees{/user}","branches_url":"https://api.github.com/repos/davidlimcheng/calcentral/branches{/branch}","tags_url":"https://api.github.com/repos/davidlimcheng/calcentral/tags","blobs_url":"https://api.github.com/repos/davidlimcheng/calcentral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidlimcheng/calcentral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidlimcheng/calcentral/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidlimcheng/calcentral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidlimcheng/calcentral/statuses/{sha}","languages_url":"https://api.github.com/repos/davidlimcheng/calcentral/languages","stargazers_url":"https://api.github.com/repos/davidlimcheng/calcentral/stargazers","contributors_url":"https://api.github.com/repos/davidlimcheng/calcentral/contributors","subscribers_url":"https://api.github.com/repos/davidlimcheng/calcentral/subscribers","subscription_url":"https://api.github.com/repos/davidlimcheng/calcentral/subscription","commits_url":"https://api.github.com/repos/davidlimcheng/calcentral/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidlimcheng/calcentral/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidlimcheng/calcentral/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidlimcheng/calcentral/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidlimcheng/calcentral/contents/{+path}","compare_url":"https://api.github.com/repos/davidlimcheng/calcentral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidlimcheng/calcentral/merges","archive_url":"https://api.github.com/repos/davidlimcheng/calcentral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidlimcheng/calcentral/downloads","issues_url":"https://api.github.com/repos/davidlimcheng/calcentral/issues{/number}","pulls_url":"https://api.github.com/repos/davidlimcheng/calcentral/pulls{/number}","milestones_url":"https://api.github.com/repos/davidlimcheng/calcentral/milestones{/number}","notifications_url":"https://api.github.com/repos/davidlimcheng/calcentral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidlimcheng/calcentral/labels{/name}","releases_url":"https://api.github.com/repos/davidlimcheng/calcentral/releases{/id}","deployments_url":"https://api.github.com/repos/davidlimcheng/calcentral/deployments","created_at":"2015-04-26T20:47:36Z","updated_at":"2015-04-26T20:47:39Z","pushed_at":"2016-05-09T18:52:35Z","git_url":"git://github.com/davidlimcheng/calcentral.git","ssh_url":"git@github.com:davidlimcheng/calcentral.git","clone_url":"https://github.com/davidlimcheng/calcentral.git","svn_url":"https://github.com/davidlimcheng/calcentral","homepage":"https://calcentral.berkeley.edu","size":24519,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ets-berkeley-edu:master","ref":"master","sha":"4dbfefc95071d33f1355b53e6302c3d56dd3ae0f","user":{"login":"ets-berkeley-edu","id":283538,"avatar_url":"https://avatars.githubusercontent.com/u/283538?v=3","gravatar_id":"","url":"https://api.github.com/users/ets-berkeley-edu","html_url":"https://github.com/ets-berkeley-edu","followers_url":"https://api.github.com/users/ets-berkeley-edu/followers","following_url":"https://api.github.com/users/ets-berkeley-edu/following{/other_user}","gists_url":"https://api.github.com/users/ets-berkeley-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/ets-berkeley-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ets-berkeley-edu/subscriptions","organizations_url":"https://api.github.com/users/ets-berkeley-edu/orgs","repos_url":"https://api.github.com/users/ets-berkeley-edu/repos","events_url":"https://api.github.com/users/ets-berkeley-edu/events{/privacy}","received_events_url":"https://api.github.com/users/ets-berkeley-edu/received_events","type":"Organization","site_admin":false},"repo":{"id":5483921,"name":"calcentral","full_name":"ets-berkeley-edu/calcentral","owner":{"login":"ets-berkeley-edu","id":283538,"avatar_url":"https://avatars.githubusercontent.com/u/283538?v=3","gravatar_id":"","url":"https://api.github.com/users/ets-berkeley-edu","html_url":"https://github.com/ets-berkeley-edu","followers_url":"https://api.github.com/users/ets-berkeley-edu/followers","following_url":"https://api.github.com/users/ets-berkeley-edu/following{/other_user}","gists_url":"https://api.github.com/users/ets-berkeley-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/ets-berkeley-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ets-berkeley-edu/subscriptions","organizations_url":"https://api.github.com/users/ets-berkeley-edu/orgs","repos_url":"https://api.github.com/users/ets-berkeley-edu/repos","events_url":"https://api.github.com/users/ets-berkeley-edu/events{/privacy}","received_events_url":"https://api.github.com/users/ets-berkeley-edu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ets-berkeley-edu/calcentral","description":"","fork":false,"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral","forks_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/forks","keys_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/teams","hooks_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/hooks","issue_events_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/events{/number}","events_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/events","assignees_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/assignees{/user}","branches_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/branches{/branch}","tags_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/tags","blobs_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/refs{/sha}","trees_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/{sha}","languages_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/languages","stargazers_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/stargazers","contributors_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/contributors","subscribers_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/subscribers","subscription_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/subscription","commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/commits{/sha}","git_commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/commits{/sha}","comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/comments{/number}","issue_comment_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/comments{/number}","contents_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/contents/{+path}","compare_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/merges","archive_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/downloads","issues_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues{/number}","pulls_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls{/number}","milestones_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/milestones{/number}","notifications_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/labels{/name}","releases_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/releases{/id}","deployments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/deployments","created_at":"2012-08-20T16:45:39Z","updated_at":"2016-04-14T13:59:38Z","pushed_at":"2016-05-09T18:58:56Z","git_url":"git://github.com/ets-berkeley-edu/calcentral.git","ssh_url":"git@github.com:ets-berkeley-edu/calcentral.git","clone_url":"https://github.com/ets-berkeley-edu/calcentral.git","svn_url":"https://github.com/ets-berkeley-edu/calcentral","homepage":"https://calcentral.berkeley.edu","size":28221,"stargazers_count":58,"watchers_count":58,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":1,"forks":58,"open_issues":1,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/5363"},"html":{"href":"https://github.com/ets-berkeley-edu/calcentral/pull/5363"},"issue":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/5363"},"comments":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/5363/comments"},"review_comments":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/5363/comments"},"review_comment":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/5363/commits"},"statuses":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/7f2e79af042a26e35bdf33aff9b598f886b6817d"}}}}