{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/63293536","id":63293536,"diff_hunk":"@@ -0,0 +1,73 @@\n+'use strict';\n+\n+const Buffer = require('buffer').Buffer;\n+const Stream = require('stream').Stream;\n+const fs = require('fs');\n+\n+function assertEncoding(encoding) {\n+  if (encoding && !Buffer.isEncoding(encoding)) {\n+    throw new Error('Unknown encoding: ' + encoding);\n+  }\n+}\n+\n+// Temporary hack for process.stdout and process.stderr when piped to files.\n+class SyncWriteStream extends Stream {\n+  constructor(fd, options) {\n+    super();\n+    options = options || {};\n+    this.fd = fd;\n+    this.writable = true;\n+    this.readable = false;\n+    this.autoClose = options.autoClose === undefined ? true : options.autoClose;\n+  }\n+\n+  write(data, arg1, arg2) {\n+    var encoding, cb;\n+\n+    // parse arguments\n+    if (arg1) {\n+      if (typeof arg1 === 'string') {\n+        encoding = arg1;\n+        cb = arg2;\n+      } else if (typeof arg1 === 'function') {\n+        cb = arg1;\n+      } else {\n+        throw new Error('Bad arguments');\n+      }\n+    }\n+    assertEncoding(encoding);\n+\n+    // Change strings to buffers. SLOW\n+    if (typeof data === 'string') {\n+      data = Buffer.from(data, encoding);\n+    }\n+\n+    fs.writeSync(this.fd, data, 0, data.length);\n+\n+    if (cb) {\n+      process.nextTick(cb);\n+    }\n+\n+    return true;\n+  }\n+\n+  end(data, arg1, arg2) {\n+    if (data) {\n+      this.write(data, arg1, arg2);\n+    }\n+    this.destroy();\n+  }\n+\n+  destroy() {\n+    if (this.autoClose)\n+      fs.closeSync(this.fd);\n+    this.fd = null;\n+    this.emit('close');\n+    return true;\n+  }\n+}\n+\n+// Alias destroySoon -> destroy\n+SyncWriteStream.prototype.destroySoon = SyncWriteStream.prototype.destroy;","path":"lib/internal/fs.js","position":71,"original_position":71,"commit_id":"90508a06f22a56ded752db0318b97b8f6dcaeda8","original_commit_id":"1173d733a455187d47f4e4eb61a815138e2abfe0","user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"body":"It likely would but given that it's part of the existing API, it makes no\nsense to remove it yet. Once the public facing API goes through the\ndeprecation cycle we can look at removing it\nOn May 15, 2016 8:16 AM, \"Jeremiah Senkpiel\" <notifications@github.com>\nwrote:\n\n> In lib/internal/fs.js\n> <https://github.com/nodejs/node/pull/6749#discussion_r63293257>:\n>\n> > +      this.write(data, arg1, arg2);\n> > +    }\n> > +    this.destroy();\n> > +  }\n> > +\n> > +  destroy() {\n> > +    if (this.autoClose)\n> > +      fs.closeSync(this.fd);\n> > +    this.fd = null;\n> > +    this.emit('close');\n> > +    return true;\n> > +  }\n> > +}\n> > +\n> > +// Alias destroySoon -> destroy\n> > +SyncWriteStream.prototype.destroySoon = SyncWriteStream.prototype.destroy;\n>\n> ... Does it appear to work without it?\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly or view it on GitHub\n> <https://github.com/nodejs/node/pull/6749/files/1173d733a455187d47f4e4eb61a815138e2abfe0#r63293257>\n>\n","created_at":"2016-05-15T15:37:25Z","updated_at":"2016-05-15T15:37:25Z","html_url":"https://github.com/nodejs/node/pull/6749#discussion_r63293536","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/6749","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/63293536"},"html":{"href":"https://github.com/nodejs/node/pull/6749#discussion_r63293536"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/6749"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/6749","id":70067238,"html_url":"https://github.com/nodejs/node/pull/6749","diff_url":"https://github.com/nodejs/node/pull/6749.diff","patch_url":"https://github.com/nodejs/node/pull/6749.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/6749","number":6749,"state":"open","locked":false,"title":"fs: move SyncWriteStream to internal/fs","user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"body":"##### Checklist\r\n\r\n- [ ] tests and code linting passes\r\n- [ ] documentation is changed or added\r\n- [ ] the commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n\r\nfs\r\n\r\n##### Description of change\r\n\r\nMove the internal SyncWriteStream class to internal/fs. This pulls it off require('fs') without a deprecation. It was always intended to be private, says that it's private in the source and tells people not to use it.\r\n\r\nUpdate the impl a bit while we're at it to use class instead of util.extends","created_at":"2016-05-13T22:29:10Z","updated_at":"2016-05-15T15:37:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"989b6290b6b1a17446d8c22f551f617fb6d80f62","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/6749/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/6749/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/6749/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/90508a06f22a56ded752db0318b97b8f6dcaeda8","head":{"label":"jasnell:internal-syncwritestream","ref":"internal-syncwritestream","sha":"90508a06f22a56ded752db0318b97b8f6dcaeda8","user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"repo":{"id":37868459,"name":"node","full_name":"jasnell/node","owner":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jasnell/node","description":"Future Node.js releases will be based on io.js","fork":true,"url":"https://api.github.com/repos/jasnell/node","forks_url":"https://api.github.com/repos/jasnell/node/forks","keys_url":"https://api.github.com/repos/jasnell/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasnell/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasnell/node/teams","hooks_url":"https://api.github.com/repos/jasnell/node/hooks","issue_events_url":"https://api.github.com/repos/jasnell/node/issues/events{/number}","events_url":"https://api.github.com/repos/jasnell/node/events","assignees_url":"https://api.github.com/repos/jasnell/node/assignees{/user}","branches_url":"https://api.github.com/repos/jasnell/node/branches{/branch}","tags_url":"https://api.github.com/repos/jasnell/node/tags","blobs_url":"https://api.github.com/repos/jasnell/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasnell/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasnell/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasnell/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasnell/node/statuses/{sha}","languages_url":"https://api.github.com/repos/jasnell/node/languages","stargazers_url":"https://api.github.com/repos/jasnell/node/stargazers","contributors_url":"https://api.github.com/repos/jasnell/node/contributors","subscribers_url":"https://api.github.com/repos/jasnell/node/subscribers","subscription_url":"https://api.github.com/repos/jasnell/node/subscription","commits_url":"https://api.github.com/repos/jasnell/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasnell/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasnell/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasnell/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasnell/node/contents/{+path}","compare_url":"https://api.github.com/repos/jasnell/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasnell/node/merges","archive_url":"https://api.github.com/repos/jasnell/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasnell/node/downloads","issues_url":"https://api.github.com/repos/jasnell/node/issues{/number}","pulls_url":"https://api.github.com/repos/jasnell/node/pulls{/number}","milestones_url":"https://api.github.com/repos/jasnell/node/milestones{/number}","notifications_url":"https://api.github.com/repos/jasnell/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasnell/node/labels{/name}","releases_url":"https://api.github.com/repos/jasnell/node/releases{/id}","deployments_url":"https://api.github.com/repos/jasnell/node/deployments","created_at":"2015-06-22T17:01:18Z","updated_at":"2016-01-11T18:47:43Z","pushed_at":"2016-05-15T14:25:56Z","git_url":"git://github.com/jasnell/node.git","ssh_url":"git@github.com:jasnell/node.git","clone_url":"https://github.com/jasnell/node.git","svn_url":"https://github.com/jasnell/node","homepage":"https://iojs.org","size":197923,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"bef1ec086d7ed010937b197ef42554a6d0ecaf67","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-05-15T15:32:21Z","pushed_at":"2016-05-15T14:25:57Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":264381,"stargazers_count":23181,"watchers_count":23181,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3282,"mirror_url":null,"open_issues_count":664,"forks":3282,"open_issues":664,"watchers":23181,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/6749"},"html":{"href":"https://github.com/nodejs/node/pull/6749"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/6749"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/6749/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/6749/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/6749/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/90508a06f22a56ded752db0318b97b8f6dcaeda8"}}}}