{"action":"created","issue":{"url":"https://api.github.com/repos/mfikes/planck/issues/330","repository_url":"https://api.github.com/repos/mfikes/planck","labels_url":"https://api.github.com/repos/mfikes/planck/issues/330/labels{/name}","comments_url":"https://api.github.com/repos/mfikes/planck/issues/330/comments","events_url":"https://api.github.com/repos/mfikes/planck/issues/330/events","html_url":"https://github.com/mfikes/planck/issues/330","id":161869579,"number":330,"title":"`planck.shell/sh` fails when user supplies `:dir` ","user":{"login":"slipset","id":5894926,"avatar_url":"https://avatars.githubusercontent.com/u/5894926?v=3","gravatar_id":"","url":"https://api.github.com/users/slipset","html_url":"https://github.com/slipset","followers_url":"https://api.github.com/users/slipset/followers","following_url":"https://api.github.com/users/slipset/following{/other_user}","gists_url":"https://api.github.com/users/slipset/gists{/gist_id}","starred_url":"https://api.github.com/users/slipset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slipset/subscriptions","organizations_url":"https://api.github.com/users/slipset/orgs","repos_url":"https://api.github.com/users/slipset/repos","events_url":"https://api.github.com/users/slipset/events{/privacy}","received_events_url":"https://api.github.com/users/slipset/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-23T08:42:44Z","updated_at":"2016-06-23T12:52:58Z","closed_at":"2016-06-23T12:38:20Z","body":"```\r\ncljs.user=> (planck.shell/sh \"0\" :env {\"zblahbb\" \"blahzz\" \"abc\" \"def\"} :dir \"/Users/jonathan\")\r\nNo protocol method Coercions.as-file defined for type cljs.core/PersistentVector: [:string \"/Users/jonathan\"]\r\n    cljs.core/missing-protocol (cljs/core.cljs:266:4)\r\n    planck.io/as-file (planck/io.cljs:259:33)\r\n    planck.shell/sh (planck/shell.cljs:49:60)\r\n```"},"comment":{"url":"https://api.github.com/repos/mfikes/planck/issues/comments/228040401","html_url":"https://github.com/mfikes/planck/issues/330#issuecomment-228040401","issue_url":"https://api.github.com/repos/mfikes/planck/issues/330","id":228040401,"user":{"login":"mfikes","id":1723464,"avatar_url":"https://avatars.githubusercontent.com/u/1723464?v=3","gravatar_id":"","url":"https://api.github.com/users/mfikes","html_url":"https://github.com/mfikes","followers_url":"https://api.github.com/users/mfikes/followers","following_url":"https://api.github.com/users/mfikes/following{/other_user}","gists_url":"https://api.github.com/users/mfikes/gists{/gist_id}","starred_url":"https://api.github.com/users/mfikes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfikes/subscriptions","organizations_url":"https://api.github.com/users/mfikes/orgs","repos_url":"https://api.github.com/users/mfikes/repos","events_url":"https://api.github.com/users/mfikes/events{/privacy}","received_events_url":"https://api.github.com/users/mfikes/received_events","type":"User","site_admin":false},"created_at":"2016-06-23T12:52:58Z","updated_at":"2016-06-23T12:52:58Z","body":"Confirmed that this works properly for the two accepted forms of `:dir`:\r\n\r\n```\r\n(planck.shell/sh \"ls\" :dir \"/tmp\")\r\n(planck.shell/sh \"ls\" :dir (planck.io/as-file \"/tmp\"))\r\n```\r\n\r\nand that it produces a meaningful error otherwise:\r\n\r\n```\r\ncljs.user=> (planck.shell/sh \"ls\" :dir :not-file)\r\nIn: [2] val: :not-file fails spec: :planck.io/coercible-file? at: [:opts :dir :val :string] predicate: string?\r\nIn: [2] val: :not-file fails spec: :planck.io/coercible-file? at: [:opts :dir :val :file] predicate: (instance? File %)\r\nERROR\r\n```"}}
{"actor":{"display_login":"mfikes"}}