{"action":"created","comment":{"url":"https://api.github.com/repos/retentionscience/react/pulls/comments/66121854","id":66121854,"diff_hunk":"@@ -234,6 +256,54 @@ const title = `${name} of ${source}`;\n // good\n <Brontosaurus className=\"thunder-lizard\" period=\"Jurassic\" />\n ```\n+* For multi-line JSX tags, put each attribute on its own indented line.","path":"README.md","position":73,"original_position":73,"commit_id":"52340cd566a0a082333910e13ec6caceb4cdff55","original_commit_id":"52340cd566a0a082333910e13ec6caceb4cdff55","user":{"login":"rs-ajax","id":17011818,"avatar_url":"https://avatars.githubusercontent.com/u/17011818?v=3","gravatar_id":"","url":"https://api.github.com/users/rs-ajax","html_url":"https://github.com/rs-ajax","followers_url":"https://api.github.com/users/rs-ajax/followers","following_url":"https://api.github.com/users/rs-ajax/following{/other_user}","gists_url":"https://api.github.com/users/rs-ajax/gists{/gist_id}","starred_url":"https://api.github.com/users/rs-ajax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rs-ajax/subscriptions","organizations_url":"https://api.github.com/users/rs-ajax/orgs","repos_url":"https://api.github.com/users/rs-ajax/repos","events_url":"https://api.github.com/users/rs-ajax/events{/privacy}","received_events_url":"https://api.github.com/users/rs-ajax/received_events","type":"User","site_admin":false},"body":"No changes to this bullet point, just moved it.","created_at":"2016-06-07T18:02:56Z","updated_at":"2016-06-07T18:02:56Z","html_url":"https://github.com/retentionscience/react/pull/2#discussion_r66121854","pull_request_url":"https://api.github.com/repos/retentionscience/react/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/retentionscience/react/pulls/comments/66121854"},"html":{"href":"https://github.com/retentionscience/react/pull/2#discussion_r66121854"},"pull_request":{"href":"https://api.github.com/repos/retentionscience/react/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/retentionscience/react/pulls/2","id":72791356,"html_url":"https://github.com/retentionscience/react/pull/2","diff_url":"https://github.com/retentionscience/react/pull/2.diff","patch_url":"https://github.com/retentionscience/react/pull/2.patch","issue_url":"https://api.github.com/repos/retentionscience/react/issues/2","number":2,"state":"open","locked":false,"title":"Set arrow function and event handler conventions","user":{"login":"rs-ajax","id":17011818,"avatar_url":"https://avatars.githubusercontent.com/u/17011818?v=3","gravatar_id":"","url":"https://api.github.com/users/rs-ajax","html_url":"https://github.com/rs-ajax","followers_url":"https://api.github.com/users/rs-ajax/followers","following_url":"https://api.github.com/users/rs-ajax/following{/other_user}","gists_url":"https://api.github.com/users/rs-ajax/gists{/gist_id}","starred_url":"https://api.github.com/users/rs-ajax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rs-ajax/subscriptions","organizations_url":"https://api.github.com/users/rs-ajax/orgs","repos_url":"https://api.github.com/users/rs-ajax/repos","events_url":"https://api.github.com/users/rs-ajax/events{/privacy}","received_events_url":"https://api.github.com/users/rs-ajax/received_events","type":"User","site_admin":false},"body":"Rules for arrow functions:\r\n\r\n1. Single-line (\"concise\") preferred to multi-line (\"block\") in general case\r\n2. Block preferred for JSX\r\n\r\nRules for event handlers:\r\n\r\n1. Use `e` as event variable\r\n2. Use arrow functions for callbacks that need additional parameters\r\n\r\n@rs-eytan @rs-longsheng Lmk what you think of these, they've come up in the last few days and it'll be good to establish something consistent for them.\r\n\r\n\r\n\r\n","created_at":"2016-06-06T22:53:53Z","updated_at":"2016-06-07T18:02:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3dba655bbf618cf17b20e15bc3844d03ebd734f2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/retentionscience/react/pulls/2/commits","review_comments_url":"https://api.github.com/repos/retentionscience/react/pulls/2/comments","review_comment_url":"https://api.github.com/repos/retentionscience/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/retentionscience/react/issues/2/comments","statuses_url":"https://api.github.com/repos/retentionscience/react/statuses/52340cd566a0a082333910e13ec6caceb4cdff55","head":{"label":"retentionscience:ajax/arrow-functions","ref":"ajax/arrow-functions","sha":"52340cd566a0a082333910e13ec6caceb4cdff55","user":{"login":"retentionscience","id":12838546,"avatar_url":"https://avatars.githubusercontent.com/u/12838546?v=3","gravatar_id":"","url":"https://api.github.com/users/retentionscience","html_url":"https://github.com/retentionscience","followers_url":"https://api.github.com/users/retentionscience/followers","following_url":"https://api.github.com/users/retentionscience/following{/other_user}","gists_url":"https://api.github.com/users/retentionscience/gists{/gist_id}","starred_url":"https://api.github.com/users/retentionscience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/retentionscience/subscriptions","organizations_url":"https://api.github.com/users/retentionscience/orgs","repos_url":"https://api.github.com/users/retentionscience/repos","events_url":"https://api.github.com/users/retentionscience/events{/privacy}","received_events_url":"https://api.github.com/users/retentionscience/received_events","type":"Organization","site_admin":false},"repo":{"id":59525338,"name":"react","full_name":"retentionscience/react","owner":{"login":"retentionscience","id":12838546,"avatar_url":"https://avatars.githubusercontent.com/u/12838546?v=3","gravatar_id":"","url":"https://api.github.com/users/retentionscience","html_url":"https://github.com/retentionscience","followers_url":"https://api.github.com/users/retentionscience/followers","following_url":"https://api.github.com/users/retentionscience/following{/other_user}","gists_url":"https://api.github.com/users/retentionscience/gists{/gist_id}","starred_url":"https://api.github.com/users/retentionscience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/retentionscience/subscriptions","organizations_url":"https://api.github.com/users/retentionscience/orgs","repos_url":"https://api.github.com/users/retentionscience/repos","events_url":"https://api.github.com/users/retentionscience/events{/privacy}","received_events_url":"https://api.github.com/users/retentionscience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/retentionscience/react","description":"ReSci's React Style Guide","fork":false,"url":"https://api.github.com/repos/retentionscience/react","forks_url":"https://api.github.com/repos/retentionscience/react/forks","keys_url":"https://api.github.com/repos/retentionscience/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/retentionscience/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/retentionscience/react/teams","hooks_url":"https://api.github.com/repos/retentionscience/react/hooks","issue_events_url":"https://api.github.com/repos/retentionscience/react/issues/events{/number}","events_url":"https://api.github.com/repos/retentionscience/react/events","assignees_url":"https://api.github.com/repos/retentionscience/react/assignees{/user}","branches_url":"https://api.github.com/repos/retentionscience/react/branches{/branch}","tags_url":"https://api.github.com/repos/retentionscience/react/tags","blobs_url":"https://api.github.com/repos/retentionscience/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/retentionscience/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/retentionscience/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/retentionscience/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/retentionscience/react/statuses/{sha}","languages_url":"https://api.github.com/repos/retentionscience/react/languages","stargazers_url":"https://api.github.com/repos/retentionscience/react/stargazers","contributors_url":"https://api.github.com/repos/retentionscience/react/contributors","subscribers_url":"https://api.github.com/repos/retentionscience/react/subscribers","subscription_url":"https://api.github.com/repos/retentionscience/react/subscription","commits_url":"https://api.github.com/repos/retentionscience/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/retentionscience/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/retentionscience/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/retentionscience/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/retentionscience/react/contents/{+path}","compare_url":"https://api.github.com/repos/retentionscience/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/retentionscience/react/merges","archive_url":"https://api.github.com/repos/retentionscience/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/retentionscience/react/downloads","issues_url":"https://api.github.com/repos/retentionscience/react/issues{/number}","pulls_url":"https://api.github.com/repos/retentionscience/react/pulls{/number}","milestones_url":"https://api.github.com/repos/retentionscience/react/milestones{/number}","notifications_url":"https://api.github.com/repos/retentionscience/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/retentionscience/react/labels{/name}","releases_url":"https://api.github.com/repos/retentionscience/react/releases{/id}","deployments_url":"https://api.github.com/repos/retentionscience/react/deployments","created_at":"2016-05-23T23:29:46Z","updated_at":"2016-06-02T01:58:41Z","pushed_at":"2016-06-06T22:53:53Z","git_url":"git://github.com/retentionscience/react.git","ssh_url":"git@github.com:retentionscience/react.git","clone_url":"https://github.com/retentionscience/react.git","svn_url":"https://github.com/retentionscience/react","homepage":"","size":14,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"retentionscience:master","ref":"master","sha":"896b25778880f866495fb9091290a84b58102b16","user":{"login":"retentionscience","id":12838546,"avatar_url":"https://avatars.githubusercontent.com/u/12838546?v=3","gravatar_id":"","url":"https://api.github.com/users/retentionscience","html_url":"https://github.com/retentionscience","followers_url":"https://api.github.com/users/retentionscience/followers","following_url":"https://api.github.com/users/retentionscience/following{/other_user}","gists_url":"https://api.github.com/users/retentionscience/gists{/gist_id}","starred_url":"https://api.github.com/users/retentionscience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/retentionscience/subscriptions","organizations_url":"https://api.github.com/users/retentionscience/orgs","repos_url":"https://api.github.com/users/retentionscience/repos","events_url":"https://api.github.com/users/retentionscience/events{/privacy}","received_events_url":"https://api.github.com/users/retentionscience/received_events","type":"Organization","site_admin":false},"repo":{"id":59525338,"name":"react","full_name":"retentionscience/react","owner":{"login":"retentionscience","id":12838546,"avatar_url":"https://avatars.githubusercontent.com/u/12838546?v=3","gravatar_id":"","url":"https://api.github.com/users/retentionscience","html_url":"https://github.com/retentionscience","followers_url":"https://api.github.com/users/retentionscience/followers","following_url":"https://api.github.com/users/retentionscience/following{/other_user}","gists_url":"https://api.github.com/users/retentionscience/gists{/gist_id}","starred_url":"https://api.github.com/users/retentionscience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/retentionscience/subscriptions","organizations_url":"https://api.github.com/users/retentionscience/orgs","repos_url":"https://api.github.com/users/retentionscience/repos","events_url":"https://api.github.com/users/retentionscience/events{/privacy}","received_events_url":"https://api.github.com/users/retentionscience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/retentionscience/react","description":"ReSci's React Style Guide","fork":false,"url":"https://api.github.com/repos/retentionscience/react","forks_url":"https://api.github.com/repos/retentionscience/react/forks","keys_url":"https://api.github.com/repos/retentionscience/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/retentionscience/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/retentionscience/react/teams","hooks_url":"https://api.github.com/repos/retentionscience/react/hooks","issue_events_url":"https://api.github.com/repos/retentionscience/react/issues/events{/number}","events_url":"https://api.github.com/repos/retentionscience/react/events","assignees_url":"https://api.github.com/repos/retentionscience/react/assignees{/user}","branches_url":"https://api.github.com/repos/retentionscience/react/branches{/branch}","tags_url":"https://api.github.com/repos/retentionscience/react/tags","blobs_url":"https://api.github.com/repos/retentionscience/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/retentionscience/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/retentionscience/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/retentionscience/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/retentionscience/react/statuses/{sha}","languages_url":"https://api.github.com/repos/retentionscience/react/languages","stargazers_url":"https://api.github.com/repos/retentionscience/react/stargazers","contributors_url":"https://api.github.com/repos/retentionscience/react/contributors","subscribers_url":"https://api.github.com/repos/retentionscience/react/subscribers","subscription_url":"https://api.github.com/repos/retentionscience/react/subscription","commits_url":"https://api.github.com/repos/retentionscience/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/retentionscience/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/retentionscience/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/retentionscience/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/retentionscience/react/contents/{+path}","compare_url":"https://api.github.com/repos/retentionscience/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/retentionscience/react/merges","archive_url":"https://api.github.com/repos/retentionscience/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/retentionscience/react/downloads","issues_url":"https://api.github.com/repos/retentionscience/react/issues{/number}","pulls_url":"https://api.github.com/repos/retentionscience/react/pulls{/number}","milestones_url":"https://api.github.com/repos/retentionscience/react/milestones{/number}","notifications_url":"https://api.github.com/repos/retentionscience/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/retentionscience/react/labels{/name}","releases_url":"https://api.github.com/repos/retentionscience/react/releases{/id}","deployments_url":"https://api.github.com/repos/retentionscience/react/deployments","created_at":"2016-05-23T23:29:46Z","updated_at":"2016-06-02T01:58:41Z","pushed_at":"2016-06-06T22:53:53Z","git_url":"git://github.com/retentionscience/react.git","ssh_url":"git@github.com:retentionscience/react.git","clone_url":"https://github.com/retentionscience/react.git","svn_url":"https://github.com/retentionscience/react","homepage":"","size":14,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/retentionscience/react/pulls/2"},"html":{"href":"https://github.com/retentionscience/react/pull/2"},"issue":{"href":"https://api.github.com/repos/retentionscience/react/issues/2"},"comments":{"href":"https://api.github.com/repos/retentionscience/react/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/retentionscience/react/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/retentionscience/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/retentionscience/react/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/retentionscience/react/statuses/52340cd566a0a082333910e13ec6caceb4cdff55"}}}}
{"actor":{"display_login":"rs-ajax"}}