{"action":"created","issue":{"url":"https://api.github.com/repos/cucumber/gherkin/issues/215","repository_url":"https://api.github.com/repos/cucumber/gherkin","labels_url":"https://api.github.com/repos/cucumber/gherkin/issues/215/labels{/name}","comments_url":"https://api.github.com/repos/cucumber/gherkin/issues/215/comments","events_url":"https://api.github.com/repos/cucumber/gherkin/issues/215/events","html_url":"https://github.com/cucumber/gherkin/pull/215","id":158756245,"number":215,"title":"[WIP] Migrate dotnet-Parser to .Net Core","user":{"login":"SabotageAndi","id":859801,"avatar_url":"https://avatars.githubusercontent.com/u/859801?v=3","gravatar_id":"","url":"https://api.github.com/users/SabotageAndi","html_url":"https://github.com/SabotageAndi","followers_url":"https://api.github.com/users/SabotageAndi/followers","following_url":"https://api.github.com/users/SabotageAndi/following{/other_user}","gists_url":"https://api.github.com/users/SabotageAndi/gists{/gist_id}","starred_url":"https://api.github.com/users/SabotageAndi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SabotageAndi/subscriptions","organizations_url":"https://api.github.com/users/SabotageAndi/orgs","repos_url":"https://api.github.com/users/SabotageAndi/repos","events_url":"https://api.github.com/users/SabotageAndi/events{/privacy}","received_events_url":"https://api.github.com/users/SabotageAndi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-06-06T19:34:30Z","updated_at":"2016-11-18T15:29:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cucumber/gherkin/pulls/215","html_url":"https://github.com/cucumber/gherkin/pull/215","diff_url":"https://github.com/cucumber/gherkin/pull/215.diff","patch_url":"https://github.com/cucumber/gherkin/pull/215.patch"},"body":"This PR migrates the existing dotnet parser, which is csproj based, to .NET Core rc2.\nAdditionally to the .NET 4.5 library, it now also compiles it for netstandard1.5 (https://github.com/dotnet/corefx/blob/master/Documentation/architecture/net-platform-standard.md#mapping-the-net-platform-standard-to-platforms)\n\nAll tests are executed for the .NET 4.5 and .Netstandard1.5 version and are green.\nAlso I upgraded SpecFlow with a NuGet from this and there everything is also working.\n\nStill open:\n- ~~Travis-CI/AppVeyor changes that the parser gets build on it~~\n- probably updating some now outdated documentation\n\nKnown problems:\n- code signing: looks like it does not work on Mac OS X. I had to build on Windows to get a version that work in SpecFlow.\n\nI created this not yet complete finished pull request \n- so that people do not make the work again\n- review of the Makefile (I am not the best at make, it is working, but I think there are better solutions than mine)\n- general feedback\n\nI suggest that when the PR is complete, it is only merged after the .Net Core RTM Release (planed for late June).\n"},"comment":{"url":"https://api.github.com/repos/cucumber/gherkin/issues/comments/261559515","html_url":"https://github.com/cucumber/gherkin/pull/215#issuecomment-261559515","issue_url":"https://api.github.com/repos/cucumber/gherkin/issues/215","id":261559515,"user":{"login":"jmezach","id":1225489,"avatar_url":"https://avatars.githubusercontent.com/u/1225489?v=3","gravatar_id":"","url":"https://api.github.com/users/jmezach","html_url":"https://github.com/jmezach","followers_url":"https://api.github.com/users/jmezach/followers","following_url":"https://api.github.com/users/jmezach/following{/other_user}","gists_url":"https://api.github.com/users/jmezach/gists{/gist_id}","starred_url":"https://api.github.com/users/jmezach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmezach/subscriptions","organizations_url":"https://api.github.com/users/jmezach/orgs","repos_url":"https://api.github.com/users/jmezach/repos","events_url":"https://api.github.com/users/jmezach/events{/privacy}","received_events_url":"https://api.github.com/users/jmezach/received_events","type":"User","site_admin":false},"created_at":"2016-11-18T15:29:34Z","updated_at":"2016-11-18T15:29:34Z","body":"@SabotageAndi Ah, I see. I just ran dotnet pack in my local clone after running the build through make and from what I can see all the necessary metadata is there.\r\n\r\nAs for the end of the project.json that is certainly something to consider. That said, migrating to the new format should be simple once the tools are final. And from what I can tell from the [announcement](https://blogs.msdn.microsoft.com/dotnet/2016/11/16/announcing-net-core-tools-msbuild-alpha/) post dotnet pack should work the same, except that it uses MSBuild to do the magic."}}
{"actor":{"display_login":"jmezach"}}