{"action":"closed","number":2273,"pull_request":{"url":"https://api.github.com/repos/kangax/fabric.js/pulls/2273","id":37348767,"html_url":"https://github.com/kangax/fabric.js/pull/2273","diff_url":"https://github.com/kangax/fabric.js/pull/2273.diff","patch_url":"https://github.com/kangax/fabric.js/pull/2273.patch","issue_url":"https://api.github.com/repos/kangax/fabric.js/issues/2273","number":2273,"state":"closed","locked":false,"title":"Differing sizes for control points on Object","user":{"login":"jasond-s","id":4137207,"avatar_url":"https://avatars.githubusercontent.com/u/4137207?v=3","gravatar_id":"","url":"https://api.github.com/users/jasond-s","html_url":"https://github.com/jasond-s","followers_url":"https://api.github.com/users/jasond-s/followers","following_url":"https://api.github.com/users/jasond-s/following{/other_user}","gists_url":"https://api.github.com/users/jasond-s/gists{/gist_id}","starred_url":"https://api.github.com/users/jasond-s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasond-s/subscriptions","organizations_url":"https://api.github.com/users/jasond-s/orgs","repos_url":"https://api.github.com/users/jasond-s/repos","events_url":"https://api.github.com/users/jasond-s/events{/privacy}","received_events_url":"https://api.github.com/users/jasond-s/received_events","type":"User","site_admin":false},"body":"I have completed a preliminary feature addition for this in the related branch. I want to use the pull as a platform for conversation as much as review.\r\n\r\nI have a need for changing the sizes independantly for the control points on an active object. \r\n\r\nThere are obviously some ways I could have done this externally to the library, but on my inspection it seemed quite easy to implement the feature in the mixin for the controls itself.\r\n\r\nTo achieve this I have:\r\n\r\n1. Added a `cornerSizeOverrides` property to `Object`.\r\n2. Where the `cornerSize` is used we now have to look for overrides.\r\n3. Removed all assuptions that the corner bounding box hypotenuse internal angle is 45deg.\r\n4. Removed all assumptions that the width and height of each point are always equal.\r\n\r\nThis has effected:\r\n- The private `_drawControl` function. \r\n- The private `_setCornerCoords` function.\r\n\r\nObviously this is a non trivial change and I have tried to maintain exisiting optimisations where they were present. Adding a new property to `Object` I also accept is quite a big change. But it does seem like the most succinct way of achieving my requirement.\r\n\r\nPlease let me know your thoughts. If this is not acceptable then I will need to implement this another way asap. The code detailed is 'working for me', but I might need some more insight as this is the first time I have really delved into the source code.\r\n\r\nThanks.","created_at":"2015-06-10T11:30:02Z","updated_at":"2016-08-20T16:26:48Z","closed_at":"2016-08-20T16:26:48Z","merged_at":null,"merge_commit_sha":"3554773acf7fe75559086c1e31da01f916622fc1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kangax/fabric.js/pulls/2273/commits","review_comments_url":"https://api.github.com/repos/kangax/fabric.js/pulls/2273/comments","review_comment_url":"https://api.github.com/repos/kangax/fabric.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kangax/fabric.js/issues/2273/comments","statuses_url":"https://api.github.com/repos/kangax/fabric.js/statuses/7424279a8dbed7038424dba0a3d0ccd108050877","head":{"label":"jasond-s:CornerSizeOverrides","ref":"CornerSizeOverrides","sha":"7424279a8dbed7038424dba0a3d0ccd108050877","user":{"login":"jasond-s","id":4137207,"avatar_url":"https://avatars.githubusercontent.com/u/4137207?v=3","gravatar_id":"","url":"https://api.github.com/users/jasond-s","html_url":"https://github.com/jasond-s","followers_url":"https://api.github.com/users/jasond-s/followers","following_url":"https://api.github.com/users/jasond-s/following{/other_user}","gists_url":"https://api.github.com/users/jasond-s/gists{/gist_id}","starred_url":"https://api.github.com/users/jasond-s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasond-s/subscriptions","organizations_url":"https://api.github.com/users/jasond-s/orgs","repos_url":"https://api.github.com/users/jasond-s/repos","events_url":"https://api.github.com/users/jasond-s/events{/privacy}","received_events_url":"https://api.github.com/users/jasond-s/received_events","type":"User","site_admin":false},"repo":{"id":37188019,"name":"fabric.js","full_name":"jasond-s/fabric.js","owner":{"login":"jasond-s","id":4137207,"avatar_url":"https://avatars.githubusercontent.com/u/4137207?v=3","gravatar_id":"","url":"https://api.github.com/users/jasond-s","html_url":"https://github.com/jasond-s","followers_url":"https://api.github.com/users/jasond-s/followers","following_url":"https://api.github.com/users/jasond-s/following{/other_user}","gists_url":"https://api.github.com/users/jasond-s/gists{/gist_id}","starred_url":"https://api.github.com/users/jasond-s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasond-s/subscriptions","organizations_url":"https://api.github.com/users/jasond-s/orgs","repos_url":"https://api.github.com/users/jasond-s/repos","events_url":"https://api.github.com/users/jasond-s/events{/privacy}","received_events_url":"https://api.github.com/users/jasond-s/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jasond-s/fabric.js","description":"Javascript Canvas Library, SVG-to-Canvas (& canvas-to-SVG) Parser","fork":true,"url":"https://api.github.com/repos/jasond-s/fabric.js","forks_url":"https://api.github.com/repos/jasond-s/fabric.js/forks","keys_url":"https://api.github.com/repos/jasond-s/fabric.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasond-s/fabric.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasond-s/fabric.js/teams","hooks_url":"https://api.github.com/repos/jasond-s/fabric.js/hooks","issue_events_url":"https://api.github.com/repos/jasond-s/fabric.js/issues/events{/number}","events_url":"https://api.github.com/repos/jasond-s/fabric.js/events","assignees_url":"https://api.github.com/repos/jasond-s/fabric.js/assignees{/user}","branches_url":"https://api.github.com/repos/jasond-s/fabric.js/branches{/branch}","tags_url":"https://api.github.com/repos/jasond-s/fabric.js/tags","blobs_url":"https://api.github.com/repos/jasond-s/fabric.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasond-s/fabric.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasond-s/fabric.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasond-s/fabric.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasond-s/fabric.js/statuses/{sha}","languages_url":"https://api.github.com/repos/jasond-s/fabric.js/languages","stargazers_url":"https://api.github.com/repos/jasond-s/fabric.js/stargazers","contributors_url":"https://api.github.com/repos/jasond-s/fabric.js/contributors","subscribers_url":"https://api.github.com/repos/jasond-s/fabric.js/subscribers","subscription_url":"https://api.github.com/repos/jasond-s/fabric.js/subscription","commits_url":"https://api.github.com/repos/jasond-s/fabric.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasond-s/fabric.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasond-s/fabric.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasond-s/fabric.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasond-s/fabric.js/contents/{+path}","compare_url":"https://api.github.com/repos/jasond-s/fabric.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasond-s/fabric.js/merges","archive_url":"https://api.github.com/repos/jasond-s/fabric.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasond-s/fabric.js/downloads","issues_url":"https://api.github.com/repos/jasond-s/fabric.js/issues{/number}","pulls_url":"https://api.github.com/repos/jasond-s/fabric.js/pulls{/number}","milestones_url":"https://api.github.com/repos/jasond-s/fabric.js/milestones{/number}","notifications_url":"https://api.github.com/repos/jasond-s/fabric.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasond-s/fabric.js/labels{/name}","releases_url":"https://api.github.com/repos/jasond-s/fabric.js/releases{/id}","deployments_url":"https://api.github.com/repos/jasond-s/fabric.js/deployments","created_at":"2015-06-10T09:32:12Z","updated_at":"2015-06-10T09:32:13Z","pushed_at":"2015-06-10T12:46:07Z","git_url":"git://github.com/jasond-s/fabric.js.git","ssh_url":"git@github.com:jasond-s/fabric.js.git","clone_url":"https://github.com/jasond-s/fabric.js.git","svn_url":"https://github.com/jasond-s/fabric.js","homepage":"http://fabricjs.com","size":94655,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kangax:master","ref":"master","sha":"2d38f9eb22de519d302187013104af896cc76ad2","user":{"login":"kangax","id":383,"avatar_url":"https://avatars.githubusercontent.com/u/383?v=3","gravatar_id":"","url":"https://api.github.com/users/kangax","html_url":"https://github.com/kangax","followers_url":"https://api.github.com/users/kangax/followers","following_url":"https://api.github.com/users/kangax/following{/other_user}","gists_url":"https://api.github.com/users/kangax/gists{/gist_id}","starred_url":"https://api.github.com/users/kangax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kangax/subscriptions","organizations_url":"https://api.github.com/users/kangax/orgs","repos_url":"https://api.github.com/users/kangax/repos","events_url":"https://api.github.com/users/kangax/events{/privacy}","received_events_url":"https://api.github.com/users/kangax/received_events","type":"User","site_admin":false},"repo":{"id":712530,"name":"fabric.js","full_name":"kangax/fabric.js","owner":{"login":"kangax","id":383,"avatar_url":"https://avatars.githubusercontent.com/u/383?v=3","gravatar_id":"","url":"https://api.github.com/users/kangax","html_url":"https://github.com/kangax","followers_url":"https://api.github.com/users/kangax/followers","following_url":"https://api.github.com/users/kangax/following{/other_user}","gists_url":"https://api.github.com/users/kangax/gists{/gist_id}","starred_url":"https://api.github.com/users/kangax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kangax/subscriptions","organizations_url":"https://api.github.com/users/kangax/orgs","repos_url":"https://api.github.com/users/kangax/repos","events_url":"https://api.github.com/users/kangax/events{/privacy}","received_events_url":"https://api.github.com/users/kangax/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kangax/fabric.js","description":"Javascript Canvas Library, SVG-to-Canvas (& canvas-to-SVG) Parser","fork":false,"url":"https://api.github.com/repos/kangax/fabric.js","forks_url":"https://api.github.com/repos/kangax/fabric.js/forks","keys_url":"https://api.github.com/repos/kangax/fabric.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kangax/fabric.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kangax/fabric.js/teams","hooks_url":"https://api.github.com/repos/kangax/fabric.js/hooks","issue_events_url":"https://api.github.com/repos/kangax/fabric.js/issues/events{/number}","events_url":"https://api.github.com/repos/kangax/fabric.js/events","assignees_url":"https://api.github.com/repos/kangax/fabric.js/assignees{/user}","branches_url":"https://api.github.com/repos/kangax/fabric.js/branches{/branch}","tags_url":"https://api.github.com/repos/kangax/fabric.js/tags","blobs_url":"https://api.github.com/repos/kangax/fabric.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kangax/fabric.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kangax/fabric.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/kangax/fabric.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kangax/fabric.js/statuses/{sha}","languages_url":"https://api.github.com/repos/kangax/fabric.js/languages","stargazers_url":"https://api.github.com/repos/kangax/fabric.js/stargazers","contributors_url":"https://api.github.com/repos/kangax/fabric.js/contributors","subscribers_url":"https://api.github.com/repos/kangax/fabric.js/subscribers","subscription_url":"https://api.github.com/repos/kangax/fabric.js/subscription","commits_url":"https://api.github.com/repos/kangax/fabric.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/kangax/fabric.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/kangax/fabric.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/kangax/fabric.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/kangax/fabric.js/contents/{+path}","compare_url":"https://api.github.com/repos/kangax/fabric.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kangax/fabric.js/merges","archive_url":"https://api.github.com/repos/kangax/fabric.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kangax/fabric.js/downloads","issues_url":"https://api.github.com/repos/kangax/fabric.js/issues{/number}","pulls_url":"https://api.github.com/repos/kangax/fabric.js/pulls{/number}","milestones_url":"https://api.github.com/repos/kangax/fabric.js/milestones{/number}","notifications_url":"https://api.github.com/repos/kangax/fabric.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kangax/fabric.js/labels{/name}","releases_url":"https://api.github.com/repos/kangax/fabric.js/releases{/id}","deployments_url":"https://api.github.com/repos/kangax/fabric.js/deployments","created_at":"2010-06-09T22:24:38Z","updated_at":"2016-08-20T15:26:22Z","pushed_at":"2016-08-20T15:58:16Z","git_url":"git://github.com/kangax/fabric.js.git","ssh_url":"git@github.com:kangax/fabric.js.git","clone_url":"https://github.com/kangax/fabric.js.git","svn_url":"https://github.com/kangax/fabric.js","homepage":"http://fabricjs.com","size":117076,"stargazers_count":6401,"watchers_count":6401,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1133,"mirror_url":null,"open_issues_count":220,"forks":1133,"open_issues":220,"watchers":6401,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kangax/fabric.js/pulls/2273"},"html":{"href":"https://github.com/kangax/fabric.js/pull/2273"},"issue":{"href":"https://api.github.com/repos/kangax/fabric.js/issues/2273"},"comments":{"href":"https://api.github.com/repos/kangax/fabric.js/issues/2273/comments"},"review_comments":{"href":"https://api.github.com/repos/kangax/fabric.js/pulls/2273/comments"},"review_comment":{"href":"https://api.github.com/repos/kangax/fabric.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kangax/fabric.js/pulls/2273/commits"},"statuses":{"href":"https://api.github.com/repos/kangax/fabric.js/statuses/7424279a8dbed7038424dba0a3d0ccd108050877"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":5,"review_comments":0,"commits":1,"additions":41,"deletions":11,"changed_files":2}}
{"actor":{"display_login":"asturur"}}