{"action":"opened","number":10,"pull_request":{"url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/pulls/10","id":75033332,"html_url":"https://github.com/YannMoisan/hands-on-scalaz/pull/10","diff_url":"https://github.com/YannMoisan/hands-on-scalaz/pull/10.diff","patch_url":"https://github.com/YannMoisan/hands-on-scalaz/pull/10.patch","issue_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/issues/10","number":10,"state":"open","locked":false,"title":"Renaming to Ex_... for easier imports","user":{"login":"timo-schmid","id":1415715,"avatar_url":"https://avatars.githubusercontent.com/u/1415715?v=3","gravatar_id":"","url":"https://api.github.com/users/timo-schmid","html_url":"https://github.com/timo-schmid","followers_url":"https://api.github.com/users/timo-schmid/followers","following_url":"https://api.github.com/users/timo-schmid/following{/other_user}","gists_url":"https://api.github.com/users/timo-schmid/gists{/gist_id}","starred_url":"https://api.github.com/users/timo-schmid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timo-schmid/subscriptions","organizations_url":"https://api.github.com/users/timo-schmid/orgs","repos_url":"https://api.github.com/users/timo-schmid/repos","events_url":"https://api.github.com/users/timo-schmid/events{/privacy}","received_events_url":"https://api.github.com/users/timo-schmid/received_events","type":"User","site_admin":false},"body":"So I had a really hard time merging... I noticed compile errors (especially Sequence was hard to merge).\r\nIt seems to me, in your solution in the cats example scalaz's sequence was used (I might be wrong, correct me if so).\r\n\r\nI moved the imports into the inner `scalaz` and `cats` objects:\r\n\r\n```\r\nobject cats {\r\n  import _root_.cats.implicits._\r\n\r\n  // ...\r\n}\r\n```\r\n\r\nHowever, I think it's not a good idea to name the implementations like the imports (scalaz, cats). I'll raise a bug, if you agree.\r\n\r\nI can fix that over the next week, if you want - I suggest renaming the objects to `impl_scalaz` and `impl_cats` if you're ok with that.","created_at":"2016-06-23T21:48:53Z","updated_at":"2016-06-23T21:48:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/pulls/10/commits","review_comments_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/pulls/10/comments","review_comment_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/issues/10/comments","statuses_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/statuses/5695cf2e8178fcc8c45a9c1c12a9a41422efa4e9","head":{"label":"timo-schmid:solutions","ref":"solutions","sha":"5695cf2e8178fcc8c45a9c1c12a9a41422efa4e9","user":{"login":"timo-schmid","id":1415715,"avatar_url":"https://avatars.githubusercontent.com/u/1415715?v=3","gravatar_id":"","url":"https://api.github.com/users/timo-schmid","html_url":"https://github.com/timo-schmid","followers_url":"https://api.github.com/users/timo-schmid/followers","following_url":"https://api.github.com/users/timo-schmid/following{/other_user}","gists_url":"https://api.github.com/users/timo-schmid/gists{/gist_id}","starred_url":"https://api.github.com/users/timo-schmid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timo-schmid/subscriptions","organizations_url":"https://api.github.com/users/timo-schmid/orgs","repos_url":"https://api.github.com/users/timo-schmid/repos","events_url":"https://api.github.com/users/timo-schmid/events{/privacy}","received_events_url":"https://api.github.com/users/timo-schmid/received_events","type":"User","site_admin":false},"repo":{"id":61832908,"name":"hands-on-scalaz","full_name":"timo-schmid/hands-on-scalaz","owner":{"login":"timo-schmid","id":1415715,"avatar_url":"https://avatars.githubusercontent.com/u/1415715?v=3","gravatar_id":"","url":"https://api.github.com/users/timo-schmid","html_url":"https://github.com/timo-schmid","followers_url":"https://api.github.com/users/timo-schmid/followers","following_url":"https://api.github.com/users/timo-schmid/following{/other_user}","gists_url":"https://api.github.com/users/timo-schmid/gists{/gist_id}","starred_url":"https://api.github.com/users/timo-schmid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timo-schmid/subscriptions","organizations_url":"https://api.github.com/users/timo-schmid/orgs","repos_url":"https://api.github.com/users/timo-schmid/repos","events_url":"https://api.github.com/users/timo-schmid/events{/privacy}","received_events_url":"https://api.github.com/users/timo-schmid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timo-schmid/hands-on-scalaz","description":"Discover scalaz in a practical way","fork":true,"url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz","forks_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/forks","keys_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/teams","hooks_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/hooks","issue_events_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/issues/events{/number}","events_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/events","assignees_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/assignees{/user}","branches_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/branches{/branch}","tags_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/tags","blobs_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/git/refs{/sha}","trees_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/statuses/{sha}","languages_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/languages","stargazers_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/stargazers","contributors_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/contributors","subscribers_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/subscribers","subscription_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/subscription","commits_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/commits{/sha}","git_commits_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/git/commits{/sha}","comments_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/comments{/number}","issue_comment_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/issues/comments{/number}","contents_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/contents/{+path}","compare_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/merges","archive_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/downloads","issues_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/issues{/number}","pulls_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/pulls{/number}","milestones_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/milestones{/number}","notifications_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/labels{/name}","releases_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/releases{/id}","deployments_url":"https://api.github.com/repos/timo-schmid/hands-on-scalaz/deployments","created_at":"2016-06-23T19:58:49Z","updated_at":"2016-06-23T19:58:50Z","pushed_at":"2016-06-23T21:38:52Z","git_url":"git://github.com/timo-schmid/hands-on-scalaz.git","ssh_url":"git@github.com:timo-schmid/hands-on-scalaz.git","clone_url":"https://github.com/timo-schmid/hands-on-scalaz.git","svn_url":"https://github.com/timo-schmid/hands-on-scalaz","homepage":null,"size":38,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"YannMoisan:solutions","ref":"solutions","sha":"a0233ae626adb55307b44b26734dd694be0a85c8","user":{"login":"YannMoisan","id":681743,"avatar_url":"https://avatars.githubusercontent.com/u/681743?v=3","gravatar_id":"","url":"https://api.github.com/users/YannMoisan","html_url":"https://github.com/YannMoisan","followers_url":"https://api.github.com/users/YannMoisan/followers","following_url":"https://api.github.com/users/YannMoisan/following{/other_user}","gists_url":"https://api.github.com/users/YannMoisan/gists{/gist_id}","starred_url":"https://api.github.com/users/YannMoisan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YannMoisan/subscriptions","organizations_url":"https://api.github.com/users/YannMoisan/orgs","repos_url":"https://api.github.com/users/YannMoisan/repos","events_url":"https://api.github.com/users/YannMoisan/events{/privacy}","received_events_url":"https://api.github.com/users/YannMoisan/received_events","type":"User","site_admin":false},"repo":{"id":60156376,"name":"hands-on-scalaz","full_name":"YannMoisan/hands-on-scalaz","owner":{"login":"YannMoisan","id":681743,"avatar_url":"https://avatars.githubusercontent.com/u/681743?v=3","gravatar_id":"","url":"https://api.github.com/users/YannMoisan","html_url":"https://github.com/YannMoisan","followers_url":"https://api.github.com/users/YannMoisan/followers","following_url":"https://api.github.com/users/YannMoisan/following{/other_user}","gists_url":"https://api.github.com/users/YannMoisan/gists{/gist_id}","starred_url":"https://api.github.com/users/YannMoisan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YannMoisan/subscriptions","organizations_url":"https://api.github.com/users/YannMoisan/orgs","repos_url":"https://api.github.com/users/YannMoisan/repos","events_url":"https://api.github.com/users/YannMoisan/events{/privacy}","received_events_url":"https://api.github.com/users/YannMoisan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/YannMoisan/hands-on-scalaz","description":"Discover scalaz in a practical way","fork":false,"url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz","forks_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/forks","keys_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/teams","hooks_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/hooks","issue_events_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/issues/events{/number}","events_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/events","assignees_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/assignees{/user}","branches_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/branches{/branch}","tags_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/tags","blobs_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/git/refs{/sha}","trees_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/statuses/{sha}","languages_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/languages","stargazers_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/stargazers","contributors_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/contributors","subscribers_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/subscribers","subscription_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/subscription","commits_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/commits{/sha}","git_commits_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/git/commits{/sha}","comments_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/comments{/number}","issue_comment_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/issues/comments{/number}","contents_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/contents/{+path}","compare_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/merges","archive_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/downloads","issues_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/issues{/number}","pulls_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/pulls{/number}","milestones_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/milestones{/number}","notifications_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/labels{/name}","releases_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/releases{/id}","deployments_url":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/deployments","created_at":"2016-06-01T07:49:28Z","updated_at":"2016-06-23T21:48:36Z","pushed_at":"2016-06-23T21:45:20Z","git_url":"git://github.com/YannMoisan/hands-on-scalaz.git","ssh_url":"git@github.com:YannMoisan/hands-on-scalaz.git","clone_url":"https://github.com/YannMoisan/hands-on-scalaz.git","svn_url":"https://github.com/YannMoisan/hands-on-scalaz","homepage":null,"size":38,"stargazers_count":58,"watchers_count":58,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":2,"forks":7,"open_issues":2,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/pulls/10"},"html":{"href":"https://github.com/YannMoisan/hands-on-scalaz/pull/10"},"issue":{"href":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/issues/10"},"comments":{"href":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/YannMoisan/hands-on-scalaz/statuses/5695cf2e8178fcc8c45a9c1c12a9a41422efa4e9"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":166,"deletions":164,"changed_files":17}}
{"actor":{"display_login":"timo-schmid"}}