{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/pulls/comments/63643077","id":63643077,"diff_hunk":"@@ -972,3 +972,8 @@ bin/libfreebl_32int64_3.so\n \n @RESPATH@/components/simpleServices.js\n @RESPATH@/components/utils.manifest\n+\n+#ifdef MOZ_B2G_REMOTECONTROLSERVICE\n+[remotecontrol]\n+@RESPATH@/res/remotecontrol/*","path":"b2g/installer/package-manifest.in","position":7,"original_position":7,"commit_id":"e052683e69be5ae94707574bf184f09818967f29","original_commit_id":"e052683e69be5ae94707574bf184f09818967f29","user":{"login":"schien","id":1792048,"avatar_url":"https://avatars.githubusercontent.com/u/1792048?v=3","gravatar_id":"","url":"https://api.github.com/users/schien","html_url":"https://github.com/schien","followers_url":"https://api.github.com/users/schien/followers","following_url":"https://api.github.com/users/schien/following{/other_user}","gists_url":"https://api.github.com/users/schien/gists{/gist_id}","starred_url":"https://api.github.com/users/schien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schien/subscriptions","organizations_url":"https://api.github.com/users/schien/orgs","repos_url":"https://api.github.com/users/schien/repos","events_url":"https://api.github.com/users/schien/events{/privacy}","received_events_url":"https://api.github.com/users/schien/received_events","type":"User","site_admin":false},"body":"Putting JS file in `/res` looks weird to me.\r\n\r\nHere is my suggestion if there is only one such JS file for remote control:\r\n\r\n- move `b2g/remotecontrol/command.js` to `b2g/chrome/content/remotecontrol.js`\r\n- add `content/remotecontrol.js                     (content/remotecontrol.js)` in `b2g/chrome/jar.mn` with compile option wrapped.\r\n- use `chrome://b2g/content/remotecontrol.js` as the URL for loading this JS file.","created_at":"2016-05-18T04:19:12Z","updated_at":"2016-05-18T04:19:12Z","html_url":"https://github.com/mozilla-b2g/gecko-b2g/pull/5#discussion_r63643077","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/pulls/comments/63643077"},"html":{"href":"https://github.com/mozilla-b2g/gecko-b2g/pull/5#discussion_r63643077"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/pulls/5","id":70312951,"html_url":"https://github.com/mozilla-b2g/gecko-b2g/pull/5","diff_url":"https://github.com/mozilla-b2g/gecko-b2g/pull/5.diff","patch_url":"https://github.com/mozilla-b2g/gecko-b2g/pull/5.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/issues/5","number":5,"state":"open","locked":false,"title":"Bug 1197751 - Add event shutter of RemoteControlService","user":{"login":"MDTsai","id":5763237,"avatar_url":"https://avatars.githubusercontent.com/u/5763237?v=3","gravatar_id":"","url":"https://api.github.com/users/MDTsai","html_url":"https://github.com/MDTsai","followers_url":"https://api.github.com/users/MDTsai/followers","following_url":"https://api.github.com/users/MDTsai/following{/other_user}","gists_url":"https://api.github.com/users/MDTsai/gists{/gist_id}","starred_url":"https://api.github.com/users/MDTsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MDTsai/subscriptions","organizations_url":"https://api.github.com/users/MDTsai/orgs","repos_url":"https://api.github.com/users/MDTsai/repos","events_url":"https://api.github.com/users/MDTsai/events{/privacy}","received_events_url":"https://api.github.com/users/MDTsai/received_events","type":"User","site_admin":false},"body":"command.js is an event shutter, handle event and convert to\r\nkey, mouse, string input and other events, pass to Gecko or SystemApp.\r\nRemoteControlService creates sandbox, evaulates command.js then\r\nhandle command event inside sandbox.","created_at":"2016-05-17T07:48:13Z","updated_at":"2016-05-18T04:19:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86f5fb8e5809af74257161e5bf6345d6ce148c6e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/pulls/5/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/pulls/5/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/issues/5/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/statuses/e052683e69be5ae94707574bf184f09818967f29","head":{"label":"MDTsai:2.6_Bug_1197751","ref":"2.6_Bug_1197751","sha":"e052683e69be5ae94707574bf184f09818967f29","user":{"login":"MDTsai","id":5763237,"avatar_url":"https://avatars.githubusercontent.com/u/5763237?v=3","gravatar_id":"","url":"https://api.github.com/users/MDTsai","html_url":"https://github.com/MDTsai","followers_url":"https://api.github.com/users/MDTsai/followers","following_url":"https://api.github.com/users/MDTsai/following{/other_user}","gists_url":"https://api.github.com/users/MDTsai/gists{/gist_id}","starred_url":"https://api.github.com/users/MDTsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MDTsai/subscriptions","organizations_url":"https://api.github.com/users/MDTsai/orgs","repos_url":"https://api.github.com/users/MDTsai/repos","events_url":"https://api.github.com/users/MDTsai/events{/privacy}","received_events_url":"https://api.github.com/users/MDTsai/received_events","type":"User","site_admin":false},"repo":{"id":43104148,"name":"gecko-dev","full_name":"MDTsai/gecko-dev","owner":{"login":"MDTsai","id":5763237,"avatar_url":"https://avatars.githubusercontent.com/u/5763237?v=3","gravatar_id":"","url":"https://api.github.com/users/MDTsai","html_url":"https://github.com/MDTsai","followers_url":"https://api.github.com/users/MDTsai/followers","following_url":"https://api.github.com/users/MDTsai/following{/other_user}","gists_url":"https://api.github.com/users/MDTsai/gists{/gist_id}","starred_url":"https://api.github.com/users/MDTsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MDTsai/subscriptions","organizations_url":"https://api.github.com/users/MDTsai/orgs","repos_url":"https://api.github.com/users/MDTsai/repos","events_url":"https://api.github.com/users/MDTsai/events{/privacy}","received_events_url":"https://api.github.com/users/MDTsai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MDTsai/gecko-dev","description":"Read-only Git mirror of the Mercurial gecko repositories at https://hg.mozilla.org. Please don't submit PRs, see: https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#I%27m_all_used_to_git.2C_but_how_can_I_provide_Mercurial-ready_patches_.3F","fork":true,"url":"https://api.github.com/repos/MDTsai/gecko-dev","forks_url":"https://api.github.com/repos/MDTsai/gecko-dev/forks","keys_url":"https://api.github.com/repos/MDTsai/gecko-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MDTsai/gecko-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MDTsai/gecko-dev/teams","hooks_url":"https://api.github.com/repos/MDTsai/gecko-dev/hooks","issue_events_url":"https://api.github.com/repos/MDTsai/gecko-dev/issues/events{/number}","events_url":"https://api.github.com/repos/MDTsai/gecko-dev/events","assignees_url":"https://api.github.com/repos/MDTsai/gecko-dev/assignees{/user}","branches_url":"https://api.github.com/repos/MDTsai/gecko-dev/branches{/branch}","tags_url":"https://api.github.com/repos/MDTsai/gecko-dev/tags","blobs_url":"https://api.github.com/repos/MDTsai/gecko-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MDTsai/gecko-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MDTsai/gecko-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/MDTsai/gecko-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MDTsai/gecko-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/MDTsai/gecko-dev/languages","stargazers_url":"https://api.github.com/repos/MDTsai/gecko-dev/stargazers","contributors_url":"https://api.github.com/repos/MDTsai/gecko-dev/contributors","subscribers_url":"https://api.github.com/repos/MDTsai/gecko-dev/subscribers","subscription_url":"https://api.github.com/repos/MDTsai/gecko-dev/subscription","commits_url":"https://api.github.com/repos/MDTsai/gecko-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/MDTsai/gecko-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/MDTsai/gecko-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/MDTsai/gecko-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/MDTsai/gecko-dev/contents/{+path}","compare_url":"https://api.github.com/repos/MDTsai/gecko-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MDTsai/gecko-dev/merges","archive_url":"https://api.github.com/repos/MDTsai/gecko-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MDTsai/gecko-dev/downloads","issues_url":"https://api.github.com/repos/MDTsai/gecko-dev/issues{/number}","pulls_url":"https://api.github.com/repos/MDTsai/gecko-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/MDTsai/gecko-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/MDTsai/gecko-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MDTsai/gecko-dev/labels{/name}","releases_url":"https://api.github.com/repos/MDTsai/gecko-dev/releases{/id}","deployments_url":"https://api.github.com/repos/MDTsai/gecko-dev/deployments","created_at":"2015-09-25T02:10:46Z","updated_at":"2015-09-25T02:20:08Z","pushed_at":"2016-05-17T07:46:10Z","git_url":"git://github.com/MDTsai/gecko-dev.git","ssh_url":"git@github.com:MDTsai/gecko-dev.git","clone_url":"https://github.com/MDTsai/gecko-dev.git","svn_url":"https://github.com/MDTsai/gecko-dev","homepage":"https://developer.mozilla.org/docs/Introduction","size":2692099,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:b2g48_v2_6","ref":"b2g48_v2_6","sha":"425aaa9763aef80ec1f7e78079e410ee1ccc9e32","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":57910513,"name":"gecko-b2g","full_name":"mozilla-b2g/gecko-b2g","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gecko-b2g","description":"For use of TV team - Commits to b2g48_v2_6 done here","fork":true,"url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g","forks_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/deployments","created_at":"2016-05-02T18:14:06Z","updated_at":"2016-05-02T18:19:40Z","pushed_at":"2016-05-17T07:48:14Z","git_url":"git://github.com/mozilla-b2g/gecko-b2g.git","ssh_url":"git@github.com:mozilla-b2g/gecko-b2g.git","clone_url":"https://github.com/mozilla-b2g/gecko-b2g.git","svn_url":"https://github.com/mozilla-b2g/gecko-b2g","homepage":"https://wiki.mozilla.org/TV_2.6","size":2703648,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":0,"default_branch":"b2g48_v2_6"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/pulls/5"},"html":{"href":"https://github.com/mozilla-b2g/gecko-b2g/pull/5"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/issues/5"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gecko-b2g/statuses/e052683e69be5ae94707574bf184f09818967f29"}}}}