{"action":"created","issue":{"url":"https://api.github.com/repos/texane/stlink/issues/444","repository_url":"https://api.github.com/repos/texane/stlink","labels_url":"https://api.github.com/repos/texane/stlink/issues/444/labels{/name}","comments_url":"https://api.github.com/repos/texane/stlink/issues/444/comments","events_url":"https://api.github.com/repos/texane/stlink/issues/444/events","html_url":"https://github.com/texane/stlink/pull/444","id":164686919,"number":444,"title":"RFC: Build libstlink shared library, add debian packaging","user":{"login":"nekromant","id":380480,"avatar_url":"https://avatars.githubusercontent.com/u/380480?v=3","gravatar_id":"","url":"https://api.github.com/users/nekromant","html_url":"https://github.com/nekromant","followers_url":"https://api.github.com/users/nekromant/followers","following_url":"https://api.github.com/users/nekromant/following{/other_user}","gists_url":"https://api.github.com/users/nekromant/gists{/gist_id}","starred_url":"https://api.github.com/users/nekromant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nekromant/subscriptions","organizations_url":"https://api.github.com/users/nekromant/orgs","repos_url":"https://api.github.com/users/nekromant/repos","events_url":"https://api.github.com/users/nekromant/events{/privacy}","received_events_url":"https://api.github.com/users/nekromant/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/texane/stlink/milestones/1","html_url":"https://github.com/texane/stlink/milestones/v2.0.0","labels_url":"https://api.github.com/repos/texane/stlink/milestones/1/labels","id":1766208,"number":1,"title":"v2.0.0","description":"This milestone will break v1.x.x commandline arguments style and library interfaces\r\n\r\n- [X] Reorganize directories and files\r\n- [X] Move chip identification structure list into implementation with a decent library interface (chipid.h/chipid.c)\r\n- [X] Use semantic version scheme [semver.org](http://semver.org)\r\n- [X] Deprecate autotools (autoconf, automake) and only use CMake (See #431)\r\n- [ ] Create generic return codes enumeration (`enum stlink_ret`)\r\n- [ ] Add license notice to all source files\r\n- [ ] Create documentation project with Read The Docs using Markdown format\r\n- [ ] Generalize commandline options parsing (See #378)\r\n- [X] Fix all compiler warnings (See #402, #409)\r\n- [ ] Write generic `hexstr2bin`,`bin2hexstr`\r\n- [ ] Rewrite logging facility using `va_args` (visual studio is unable to compile the current vardiac macros)\r\n- [ ] Introduce contribution guidelines and enforced codestyle\r\n- [ ] Introduce unit testing with Unity\r\n- [ ] Create binary releases for Debian 8, Windows and Mac OS X.","creator":{"login":"xor-gate","id":1050166,"avatar_url":"https://avatars.githubusercontent.com/u/1050166?v=3","gravatar_id":"","url":"https://api.github.com/users/xor-gate","html_url":"https://github.com/xor-gate","followers_url":"https://api.github.com/users/xor-gate/followers","following_url":"https://api.github.com/users/xor-gate/following{/other_user}","gists_url":"https://api.github.com/users/xor-gate/gists{/gist_id}","starred_url":"https://api.github.com/users/xor-gate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xor-gate/subscriptions","organizations_url":"https://api.github.com/users/xor-gate/orgs","repos_url":"https://api.github.com/users/xor-gate/repos","events_url":"https://api.github.com/users/xor-gate/events{/privacy}","received_events_url":"https://api.github.com/users/xor-gate/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":7,"state":"open","created_at":"2016-05-14T15:35:03Z","updated_at":"2016-08-07T12:51:35Z","due_on":null,"closed_at":null},"comments":24,"created_at":"2016-07-09T21:40:30Z","updated_at":"2016-08-29T17:36:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/texane/stlink/pulls/444","html_url":"https://github.com/texane/stlink/pull/444","diff_url":"https://github.com/texane/stlink/pull/444.diff","patch_url":"https://github.com/texane/stlink/pull/444.patch"},"body":"PLEASE DO NOT MERGE YET!\r\n\r\nWell, basically sometimes one may need to use stlink in his own app. This patchset does the following: \r\n\r\n1. Adds a shared library target and links all binaries against it, including proper SOVERSION stuff\r\n2. Installs all the relevant headers to their respective locations\r\n3. Teaches CMakeLists.txt to properly handle ${CMAKE_LIBRARY_PATH} and play nicely with debian multiarch\r\n3. Teaches CMakeLists.txt to generate and install a proper pkg-config file\r\n4. Add initial debian packaging stuff to debian/ directory\r\n\r\nAs of debian packaging, I've split the package into three:\r\nlibstlink - the shared library\r\nlibstlink-dev - pkg-config file, static library and headers\r\nstlink-tools - all the binaries\r\n\r\nPlease don't yet merge, since there are a few things I haven't yet tested out/firgured.  \r\n\r\n1. I've added a few CMake variables that set .so version. I've set API version as 1 and library version an 1.2.1 (for the current git master). Correct me if I'm wrong here.\r\n2. I'm no big autotools expert, so I've done nothing so far with autotools stuff. \r\n3. I've only tested building under linux, so my changes to CMakeLists.txt MAY have broken windows/mac builds. \r\n"},"comment":{"url":"https://api.github.com/repos/texane/stlink/issues/comments/243195611","html_url":"https://github.com/texane/stlink/pull/444#issuecomment-243195611","issue_url":"https://api.github.com/repos/texane/stlink/issues/444","id":243195611,"user":{"login":"xor-gate","id":1050166,"avatar_url":"https://avatars.githubusercontent.com/u/1050166?v=3","gravatar_id":"","url":"https://api.github.com/users/xor-gate","html_url":"https://github.com/xor-gate","followers_url":"https://api.github.com/users/xor-gate/followers","following_url":"https://api.github.com/users/xor-gate/following{/other_user}","gists_url":"https://api.github.com/users/xor-gate/gists{/gist_id}","starred_url":"https://api.github.com/users/xor-gate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xor-gate/subscriptions","organizations_url":"https://api.github.com/users/xor-gate/orgs","repos_url":"https://api.github.com/users/xor-gate/repos","events_url":"https://api.github.com/users/xor-gate/events{/privacy}","received_events_url":"https://api.github.com/users/xor-gate/received_events","type":"User","site_admin":false},"created_at":"2016-08-29T17:36:55Z","updated_at":"2016-08-29T17:36:55Z","body":"You should replace all occurences of `${PROJECT_NAME}-static` target with:\r\n\r\n`${STLINK_LIB_STATIC}`\r\n\r\nand should be set once in the main CMakeLists.txt:\r\n\r\n`set(STLINK_LIB_STATIC ${PROJECT_NAME}-static)`"}}
{"actor":{"display_login":"xor-gate"}}