{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/krp312/bequick_words_test/pulls/1","id":58067465,"html_url":"https://github.com/krp312/bequick_words_test/pull/1","diff_url":"https://github.com/krp312/bequick_words_test/pull/1.diff","patch_url":"https://github.com/krp312/bequick_words_test/pull/1.patch","issue_url":"https://api.github.com/repos/krp312/bequick_words_test/issues/1","number":1,"state":"closed","locked":false,"title":"Instance variable refactor","user":{"login":"c0nspiracy","id":71886,"avatar_url":"https://avatars.githubusercontent.com/u/71886?v=3","gravatar_id":"","url":"https://api.github.com/users/c0nspiracy","html_url":"https://github.com/c0nspiracy","followers_url":"https://api.github.com/users/c0nspiracy/followers","following_url":"https://api.github.com/users/c0nspiracy/following{/other_user}","gists_url":"https://api.github.com/users/c0nspiracy/gists{/gist_id}","starred_url":"https://api.github.com/users/c0nspiracy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c0nspiracy/subscriptions","organizations_url":"https://api.github.com/users/c0nspiracy/orgs","repos_url":"https://api.github.com/users/c0nspiracy/repos","events_url":"https://api.github.com/users/c0nspiracy/events{/privacy}","received_events_url":"https://api.github.com/users/c0nspiracy/received_events","type":"User","site_admin":false},"body":"This removes most of the instance variables in favor of changing the `create_sequence_word_pairs`, `select_unique_sequences`, and `alphabetize_pairs_by_sequence` methods to take an input and return an output.\r\n`create_list` has been changed to take the output of each method and pass it in to the next part of the process.\r\n\r\nThis helps to clearly identify the purpose of each individual method, and will also help with testing because it is now possible to call a method without relying on or affecting the value of an instance variable, eg. repeated calls to `create_sequence_word_pairs` with the same input will always return the same output, whereas before these changes, calling it more than once would have resulted in duplicate values being put in `@pairs_hash`.","created_at":"2016-02-02T23:24:33Z","updated_at":"2016-02-02T23:41:58Z","closed_at":"2016-02-02T23:41:58Z","merged_at":null,"merge_commit_sha":"4aa508bea818953178508efcebf9d8c3aa58c391","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/krp312/bequick_words_test/pulls/1/commits","review_comments_url":"https://api.github.com/repos/krp312/bequick_words_test/pulls/1/comments","review_comment_url":"https://api.github.com/repos/krp312/bequick_words_test/pulls/comments{/number}","comments_url":"https://api.github.com/repos/krp312/bequick_words_test/issues/1/comments","statuses_url":"https://api.github.com/repos/krp312/bequick_words_test/statuses/27954b62bc272418fb57f5b4e70f0ff6b2181e8f","head":{"label":"c0nspiracy:instance-variable-refactor","ref":"instance-variable-refactor","sha":"27954b62bc272418fb57f5b4e70f0ff6b2181e8f","user":{"login":"c0nspiracy","id":71886,"avatar_url":"https://avatars.githubusercontent.com/u/71886?v=3","gravatar_id":"","url":"https://api.github.com/users/c0nspiracy","html_url":"https://github.com/c0nspiracy","followers_url":"https://api.github.com/users/c0nspiracy/followers","following_url":"https://api.github.com/users/c0nspiracy/following{/other_user}","gists_url":"https://api.github.com/users/c0nspiracy/gists{/gist_id}","starred_url":"https://api.github.com/users/c0nspiracy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c0nspiracy/subscriptions","organizations_url":"https://api.github.com/users/c0nspiracy/orgs","repos_url":"https://api.github.com/users/c0nspiracy/repos","events_url":"https://api.github.com/users/c0nspiracy/events{/privacy}","received_events_url":"https://api.github.com/users/c0nspiracy/received_events","type":"User","site_admin":false},"repo":{"id":50540631,"name":"bequick_words_test","full_name":"c0nspiracy/bequick_words_test","owner":{"login":"c0nspiracy","id":71886,"avatar_url":"https://avatars.githubusercontent.com/u/71886?v=3","gravatar_id":"","url":"https://api.github.com/users/c0nspiracy","html_url":"https://github.com/c0nspiracy","followers_url":"https://api.github.com/users/c0nspiracy/followers","following_url":"https://api.github.com/users/c0nspiracy/following{/other_user}","gists_url":"https://api.github.com/users/c0nspiracy/gists{/gist_id}","starred_url":"https://api.github.com/users/c0nspiracy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c0nspiracy/subscriptions","organizations_url":"https://api.github.com/users/c0nspiracy/orgs","repos_url":"https://api.github.com/users/c0nspiracy/repos","events_url":"https://api.github.com/users/c0nspiracy/events{/privacy}","received_events_url":"https://api.github.com/users/c0nspiracy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/c0nspiracy/bequick_words_test","description":"4-letter sequence extractions from words","fork":true,"url":"https://api.github.com/repos/c0nspiracy/bequick_words_test","forks_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/forks","keys_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/teams","hooks_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/hooks","issue_events_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/issues/events{/number}","events_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/events","assignees_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/assignees{/user}","branches_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/branches{/branch}","tags_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/tags","blobs_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/git/refs{/sha}","trees_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/statuses/{sha}","languages_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/languages","stargazers_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/stargazers","contributors_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/contributors","subscribers_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/subscribers","subscription_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/subscription","commits_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/commits{/sha}","git_commits_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/git/commits{/sha}","comments_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/comments{/number}","issue_comment_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/issues/comments{/number}","contents_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/contents/{+path}","compare_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/merges","archive_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/downloads","issues_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/issues{/number}","pulls_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/pulls{/number}","milestones_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/milestones{/number}","notifications_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/labels{/name}","releases_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/releases{/id}","deployments_url":"https://api.github.com/repos/c0nspiracy/bequick_words_test/deployments","created_at":"2016-01-27T21:55:35Z","updated_at":"2016-01-27T21:55:35Z","pushed_at":"2016-02-02T23:41:46Z","git_url":"git://github.com/c0nspiracy/bequick_words_test.git","ssh_url":"git@github.com:c0nspiracy/bequick_words_test.git","clone_url":"https://github.com/c0nspiracy/bequick_words_test.git","svn_url":"https://github.com/c0nspiracy/bequick_words_test","homepage":"","size":854,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"krp312:master","ref":"master","sha":"a7546660df5b5e158b69e7b46a20114f11f40337","user":{"login":"krp312","id":16083866,"avatar_url":"https://avatars.githubusercontent.com/u/16083866?v=3","gravatar_id":"","url":"https://api.github.com/users/krp312","html_url":"https://github.com/krp312","followers_url":"https://api.github.com/users/krp312/followers","following_url":"https://api.github.com/users/krp312/following{/other_user}","gists_url":"https://api.github.com/users/krp312/gists{/gist_id}","starred_url":"https://api.github.com/users/krp312/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krp312/subscriptions","organizations_url":"https://api.github.com/users/krp312/orgs","repos_url":"https://api.github.com/users/krp312/repos","events_url":"https://api.github.com/users/krp312/events{/privacy}","received_events_url":"https://api.github.com/users/krp312/received_events","type":"User","site_admin":false},"repo":{"id":47132037,"name":"bequick_words_test","full_name":"krp312/bequick_words_test","owner":{"login":"krp312","id":16083866,"avatar_url":"https://avatars.githubusercontent.com/u/16083866?v=3","gravatar_id":"","url":"https://api.github.com/users/krp312","html_url":"https://github.com/krp312","followers_url":"https://api.github.com/users/krp312/followers","following_url":"https://api.github.com/users/krp312/following{/other_user}","gists_url":"https://api.github.com/users/krp312/gists{/gist_id}","starred_url":"https://api.github.com/users/krp312/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krp312/subscriptions","organizations_url":"https://api.github.com/users/krp312/orgs","repos_url":"https://api.github.com/users/krp312/repos","events_url":"https://api.github.com/users/krp312/events{/privacy}","received_events_url":"https://api.github.com/users/krp312/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krp312/bequick_words_test","description":"4-letter sequence extractions from words","fork":false,"url":"https://api.github.com/repos/krp312/bequick_words_test","forks_url":"https://api.github.com/repos/krp312/bequick_words_test/forks","keys_url":"https://api.github.com/repos/krp312/bequick_words_test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krp312/bequick_words_test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krp312/bequick_words_test/teams","hooks_url":"https://api.github.com/repos/krp312/bequick_words_test/hooks","issue_events_url":"https://api.github.com/repos/krp312/bequick_words_test/issues/events{/number}","events_url":"https://api.github.com/repos/krp312/bequick_words_test/events","assignees_url":"https://api.github.com/repos/krp312/bequick_words_test/assignees{/user}","branches_url":"https://api.github.com/repos/krp312/bequick_words_test/branches{/branch}","tags_url":"https://api.github.com/repos/krp312/bequick_words_test/tags","blobs_url":"https://api.github.com/repos/krp312/bequick_words_test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krp312/bequick_words_test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krp312/bequick_words_test/git/refs{/sha}","trees_url":"https://api.github.com/repos/krp312/bequick_words_test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krp312/bequick_words_test/statuses/{sha}","languages_url":"https://api.github.com/repos/krp312/bequick_words_test/languages","stargazers_url":"https://api.github.com/repos/krp312/bequick_words_test/stargazers","contributors_url":"https://api.github.com/repos/krp312/bequick_words_test/contributors","subscribers_url":"https://api.github.com/repos/krp312/bequick_words_test/subscribers","subscription_url":"https://api.github.com/repos/krp312/bequick_words_test/subscription","commits_url":"https://api.github.com/repos/krp312/bequick_words_test/commits{/sha}","git_commits_url":"https://api.github.com/repos/krp312/bequick_words_test/git/commits{/sha}","comments_url":"https://api.github.com/repos/krp312/bequick_words_test/comments{/number}","issue_comment_url":"https://api.github.com/repos/krp312/bequick_words_test/issues/comments{/number}","contents_url":"https://api.github.com/repos/krp312/bequick_words_test/contents/{+path}","compare_url":"https://api.github.com/repos/krp312/bequick_words_test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krp312/bequick_words_test/merges","archive_url":"https://api.github.com/repos/krp312/bequick_words_test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krp312/bequick_words_test/downloads","issues_url":"https://api.github.com/repos/krp312/bequick_words_test/issues{/number}","pulls_url":"https://api.github.com/repos/krp312/bequick_words_test/pulls{/number}","milestones_url":"https://api.github.com/repos/krp312/bequick_words_test/milestones{/number}","notifications_url":"https://api.github.com/repos/krp312/bequick_words_test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krp312/bequick_words_test/labels{/name}","releases_url":"https://api.github.com/repos/krp312/bequick_words_test/releases{/id}","deployments_url":"https://api.github.com/repos/krp312/bequick_words_test/deployments","created_at":"2015-11-30T16:39:53Z","updated_at":"2016-01-27T16:40:54Z","pushed_at":"2016-02-02T23:24:34Z","git_url":"git://github.com/krp312/bequick_words_test.git","ssh_url":"git@github.com:krp312/bequick_words_test.git","clone_url":"https://github.com/krp312/bequick_words_test.git","svn_url":"https://github.com/krp312/bequick_words_test","homepage":"","size":801,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/krp312/bequick_words_test/pulls/1"},"html":{"href":"https://github.com/krp312/bequick_words_test/pull/1"},"issue":{"href":"https://api.github.com/repos/krp312/bequick_words_test/issues/1"},"comments":{"href":"https://api.github.com/repos/krp312/bequick_words_test/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/krp312/bequick_words_test/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/krp312/bequick_words_test/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/krp312/bequick_words_test/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/krp312/bequick_words_test/statuses/27954b62bc272418fb57f5b4e70f0ff6b2181e8f"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":5,"additions":15,"deletions":15,"changed_files":1}}