{"action":"created","comment":{"url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/pulls/comments/48743769","id":48743769,"diff_hunk":"@@ -124,11 +128,14 @@ protected ModelAndView onSubmit(HttpServletRequest request, HttpServletResponse\n \t\t\t\t\tContext.removeProxyPrivilege(PrivilegeConstants.GET_USERS);\n \t\t\t\t}\n \t\t\t\t\n-\t\t\t\tif (user == null /*|| StringUtils.isEmpty(user.getSecretQuestion())*/) {\n+\t\t\t\tif (user == null) {\n+\t\t\t\t\thttpSession.setAttribute(WebConstants.OPENMRS_ERROR_ATTR, \"auth.question.fill\");\n+\t\t\t\t\trequest.setAttribute(\"secretQuestion\", getRandomFakeSecretQuestion(username));","path":"omod/src/main/java/org/openmrs/web/controller/ForgotPasswordFormController.java","position":26,"original_position":26,"commit_id":"e0009a54f7691a871677afd61f881d1b6b7e3bb4","original_commit_id":"e0009a54f7691a871677afd61f881d1b6b7e3bb4","user":{"login":"wluyima","id":1395907,"avatar_url":"https://avatars.githubusercontent.com/u/1395907?v=3","gravatar_id":"","url":"https://api.github.com/users/wluyima","html_url":"https://github.com/wluyima","followers_url":"https://api.github.com/users/wluyima/followers","following_url":"https://api.github.com/users/wluyima/following{/other_user}","gists_url":"https://api.github.com/users/wluyima/gists{/gist_id}","starred_url":"https://api.github.com/users/wluyima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wluyima/subscriptions","organizations_url":"https://api.github.com/users/wluyima/orgs","repos_url":"https://api.github.com/users/wluyima/repos","events_url":"https://api.github.com/users/wluyima/events{/privacy}","received_events_url":"https://api.github.com/users/wluyima/received_events","type":"User","site_admin":false},"body":"Ok","created_at":"2016-01-04T15:50:37Z","updated_at":"2016-01-04T15:50:37Z","html_url":"https://github.com/openmrs/openmrs-module-legacyui/pull/20#discussion_r48743769","pull_request_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/pulls/comments/48743769"},"html":{"href":"https://github.com/openmrs/openmrs-module-legacyui/pull/20#discussion_r48743769"},"pull_request":{"href":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/pulls/20","id":54930619,"html_url":"https://github.com/openmrs/openmrs-module-legacyui/pull/20","diff_url":"https://github.com/openmrs/openmrs-module-legacyui/pull/20.diff","patch_url":"https://github.com/openmrs/openmrs-module-legacyui/pull/20.patch","issue_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/issues/20","number":20,"state":"open","locked":false,"title":"Fix for: Forgotten Password Form Leaks Valid Usernames [TRUNK-3933]","user":{"login":"bholagabbar","id":11693595,"avatar_url":"https://avatars.githubusercontent.com/u/11693595?v=3","gravatar_id":"","url":"https://api.github.com/users/bholagabbar","html_url":"https://github.com/bholagabbar","followers_url":"https://api.github.com/users/bholagabbar/followers","following_url":"https://api.github.com/users/bholagabbar/following{/other_user}","gists_url":"https://api.github.com/users/bholagabbar/gists{/gist_id}","starred_url":"https://api.github.com/users/bholagabbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bholagabbar/subscriptions","organizations_url":"https://api.github.com/users/bholagabbar/orgs","repos_url":"https://api.github.com/users/bholagabbar/repos","events_url":"https://api.github.com/users/bholagabbar/events{/privacy}","received_events_url":"https://api.github.com/users/bholagabbar/received_events","type":"User","site_admin":false},"body":"Fixed the leakage of usernames in the legacy UI. If the user enters an invalid username, he will be assigned a random fake question on the basis of the hash-value of his username whose answer will always be false. The issue of no secret question/answer prompts an error. ","created_at":"2016-01-03T19:29:54Z","updated_at":"2016-01-04T15:50:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8a7d04e755fa05375a01eb2d4c0443129ed0681","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/pulls/20/commits","review_comments_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/pulls/20/comments","review_comment_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/issues/20/comments","statuses_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/statuses/e0009a54f7691a871677afd61f881d1b6b7e3bb4","head":{"label":"bholagabbar:master","ref":"master","sha":"e0009a54f7691a871677afd61f881d1b6b7e3bb4","user":{"login":"bholagabbar","id":11693595,"avatar_url":"https://avatars.githubusercontent.com/u/11693595?v=3","gravatar_id":"","url":"https://api.github.com/users/bholagabbar","html_url":"https://github.com/bholagabbar","followers_url":"https://api.github.com/users/bholagabbar/followers","following_url":"https://api.github.com/users/bholagabbar/following{/other_user}","gists_url":"https://api.github.com/users/bholagabbar/gists{/gist_id}","starred_url":"https://api.github.com/users/bholagabbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bholagabbar/subscriptions","organizations_url":"https://api.github.com/users/bholagabbar/orgs","repos_url":"https://api.github.com/users/bholagabbar/repos","events_url":"https://api.github.com/users/bholagabbar/events{/privacy}","received_events_url":"https://api.github.com/users/bholagabbar/received_events","type":"User","site_admin":false},"repo":{"id":48922960,"name":"openmrs-module-legacyui","full_name":"bholagabbar/openmrs-module-legacyui","owner":{"login":"bholagabbar","id":11693595,"avatar_url":"https://avatars.githubusercontent.com/u/11693595?v=3","gravatar_id":"","url":"https://api.github.com/users/bholagabbar","html_url":"https://github.com/bholagabbar","followers_url":"https://api.github.com/users/bholagabbar/followers","following_url":"https://api.github.com/users/bholagabbar/following{/other_user}","gists_url":"https://api.github.com/users/bholagabbar/gists{/gist_id}","starred_url":"https://api.github.com/users/bholagabbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bholagabbar/subscriptions","organizations_url":"https://api.github.com/users/bholagabbar/orgs","repos_url":"https://api.github.com/users/bholagabbar/repos","events_url":"https://api.github.com/users/bholagabbar/events{/privacy}","received_events_url":"https://api.github.com/users/bholagabbar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bholagabbar/openmrs-module-legacyui","description":"The legacy user interface for OpenMRS 1.9 is chiefly comprised of administrative functions and the patient dashboard. Apparently, a new and more contemporary UI has been introduced via a UI framework and the legacy UI is kept around for administrative functions that are not yet implemented in the new UI. To retire the Legacy UI as planned, it is required to move the implementations and modules that still rely on it in order to maintain backwards compatibility. The main idea behind this project is to move legacy UI functions into an OpenMRS module that these implementations can install until they are able to migrate away from it, since most of the implementations of OpenMRS around the world are running OpenMRS 1.9.","fork":true,"url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui","forks_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/forks","keys_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/teams","hooks_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/hooks","issue_events_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/issues/events{/number}","events_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/events","assignees_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/assignees{/user}","branches_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/branches{/branch}","tags_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/tags","blobs_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/git/refs{/sha}","trees_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/statuses/{sha}","languages_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/languages","stargazers_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/stargazers","contributors_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/contributors","subscribers_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/subscribers","subscription_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/subscription","commits_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/commits{/sha}","git_commits_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/git/commits{/sha}","comments_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/comments{/number}","issue_comment_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/issues/comments{/number}","contents_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/contents/{+path}","compare_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/merges","archive_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/downloads","issues_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/issues{/number}","pulls_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/pulls{/number}","milestones_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/milestones{/number}","notifications_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/labels{/name}","releases_url":"https://api.github.com/repos/bholagabbar/openmrs-module-legacyui/releases{/id}","created_at":"2016-01-02T20:32:01Z","updated_at":"2016-01-02T20:32:05Z","pushed_at":"2016-01-03T19:25:40Z","git_url":"git://github.com/bholagabbar/openmrs-module-legacyui.git","ssh_url":"git@github.com:bholagabbar/openmrs-module-legacyui.git","clone_url":"https://github.com/bholagabbar/openmrs-module-legacyui.git","svn_url":"https://github.com/bholagabbar/openmrs-module-legacyui","homepage":"","size":1673,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openmrs:master","ref":"master","sha":"6beedcc2309c2621344cf605b90cd97f5a918ff3","user":{"login":"openmrs","id":860776,"avatar_url":"https://avatars.githubusercontent.com/u/860776?v=3","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"repo":{"id":35045181,"name":"openmrs-module-legacyui","full_name":"openmrs/openmrs-module-legacyui","owner":{"login":"openmrs","id":860776,"avatar_url":"https://avatars.githubusercontent.com/u/860776?v=3","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openmrs/openmrs-module-legacyui","description":"The legacy user interface for OpenMRS 1.9 is chiefly comprised of administrative functions and the patient dashboard. Apparently, a new and more contemporary UI has been introduced via a UI framework and the legacy UI is kept around for administrative functions that are not yet implemented in the new UI. To retire the Legacy UI as planned, it is required to move the implementations and modules that still rely on it in order to maintain backwards compatibility. The main idea behind this project is to move legacy UI functions into an OpenMRS module that these implementations can install until they are able to migrate away from it, since most of the implementations of OpenMRS around the world are running OpenMRS 1.9.","fork":false,"url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui","forks_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/forks","keys_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/teams","hooks_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/hooks","issue_events_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/issues/events{/number}","events_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/events","assignees_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/assignees{/user}","branches_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/branches{/branch}","tags_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/tags","blobs_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/git/refs{/sha}","trees_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/statuses/{sha}","languages_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/languages","stargazers_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/stargazers","contributors_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/contributors","subscribers_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/subscribers","subscription_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/subscription","commits_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/commits{/sha}","git_commits_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/git/commits{/sha}","comments_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/comments{/number}","issue_comment_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/issues/comments{/number}","contents_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/contents/{+path}","compare_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/merges","archive_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/downloads","issues_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/issues{/number}","pulls_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/pulls{/number}","milestones_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/milestones{/number}","notifications_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/labels{/name}","releases_url":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/releases{/id}","created_at":"2015-05-04T16:12:32Z","updated_at":"2015-12-27T20:45:37Z","pushed_at":"2016-01-04T15:41:31Z","git_url":"git://github.com/openmrs/openmrs-module-legacyui.git","ssh_url":"git@github.com:openmrs/openmrs-module-legacyui.git","clone_url":"https://github.com/openmrs/openmrs-module-legacyui.git","svn_url":"https://github.com/openmrs/openmrs-module-legacyui","homepage":"","size":1705,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":1,"forks":19,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/pulls/20"},"html":{"href":"https://github.com/openmrs/openmrs-module-legacyui/pull/20"},"issue":{"href":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/issues/20"},"comments":{"href":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/openmrs/openmrs-module-legacyui/statuses/e0009a54f7691a871677afd61f881d1b6b7e3bb4"}}}}