{"action":"created","comment":{"url":"https://api.github.com/repos/open-eid/libdigidocpp/pulls/comments/83381609","pull_request_review_id":4229571,"id":83381609,"diff_hunk":"@@ -490,6 +490,10 @@ void BDoc::parseManifestAndLoadFiles(const ZipSerialize &z, const vector<string>\n     {\n         THROW(\"Failed to parse manifest XML: %s (xsd path: %s)\", e.what(), Conf::instance()->xsdPath().c_str());\n     }\n+    catch (...)","path":"src/BDoc.cpp","position":4,"original_position":4,"commit_id":"9039e621704b1fa83b93dbc2a4d172f442a8c1f5","original_commit_id":"9039e621704b1fa83b93dbc2a4d172f442a8c1f5","user":{"login":"metsma","id":5708849,"avatar_url":"https://avatars.githubusercontent.com/u/5708849?v=3","gravatar_id":"","url":"https://api.github.com/users/metsma","html_url":"https://github.com/metsma","followers_url":"https://api.github.com/users/metsma/followers","following_url":"https://api.github.com/users/metsma/following{/other_user}","gists_url":"https://api.github.com/users/metsma/gists{/gist_id}","starred_url":"https://api.github.com/users/metsma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metsma/subscriptions","organizations_url":"https://api.github.com/users/metsma/orgs","repos_url":"https://api.github.com/users/metsma/repos","events_url":"https://api.github.com/users/metsma/events{/privacy}","received_events_url":"https://api.github.com/users/metsma/received_events","type":"User","site_admin":false},"body":"If i remember correctly, throw in catch block without exception is rethrow? And the exception should be OutOfMemoryException","created_at":"2016-10-14T08:52:23Z","updated_at":"2016-10-14T08:52:24Z","html_url":"https://github.com/open-eid/libdigidocpp/pull/44#discussion_r83381609","pull_request_url":"https://api.github.com/repos/open-eid/libdigidocpp/pulls/44","_links":{"self":{"href":"https://api.github.com/repos/open-eid/libdigidocpp/pulls/comments/83381609"},"html":{"href":"https://github.com/open-eid/libdigidocpp/pull/44#discussion_r83381609"},"pull_request":{"href":"https://api.github.com/repos/open-eid/libdigidocpp/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/open-eid/libdigidocpp/pulls/44","id":88864813,"html_url":"https://github.com/open-eid/libdigidocpp/pull/44","diff_url":"https://github.com/open-eid/libdigidocpp/pull/44.diff","patch_url":"https://github.com/open-eid/libdigidocpp/pull/44.patch","issue_url":"https://api.github.com/repos/open-eid/libdigidocpp/issues/44","number":44,"state":"open","locked":false,"title":"IB-3793 double click on ZIP-bomb BDOC should not crash","user":{"login":"olegprokofjev","id":22339519,"avatar_url":"https://avatars.githubusercontent.com/u/22339519?v=3","gravatar_id":"","url":"https://api.github.com/users/olegprokofjev","html_url":"https://github.com/olegprokofjev","followers_url":"https://api.github.com/users/olegprokofjev/followers","following_url":"https://api.github.com/users/olegprokofjev/following{/other_user}","gists_url":"https://api.github.com/users/olegprokofjev/gists{/gist_id}","starred_url":"https://api.github.com/users/olegprokofjev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olegprokofjev/subscriptions","organizations_url":"https://api.github.com/users/olegprokofjev/orgs","repos_url":"https://api.github.com/users/olegprokofjev/repos","events_url":"https://api.github.com/users/olegprokofjev/events{/privacy}","received_events_url":"https://api.github.com/users/olegprokofjev/received_events","type":"User","site_admin":false},"body":"If file can not be loaded to memory the error is returned:\r\n  Failed to write file ... data to stream. Stream size: ...\r\n\r\nMETA-INF/manifest.xml file size is not limited. It could be as big as\r\napplication/system can handle.\r\n\r\nSigned-off-by: Oleg Prokofjev <oleg@aktors.ee>","created_at":"2016-10-11T16:21:27Z","updated_at":"2016-10-14T08:52:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"314e18dd726388d8db5de47890a7f71feeb64d91","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/open-eid/libdigidocpp/pulls/44/commits","review_comments_url":"https://api.github.com/repos/open-eid/libdigidocpp/pulls/44/comments","review_comment_url":"https://api.github.com/repos/open-eid/libdigidocpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-eid/libdigidocpp/issues/44/comments","statuses_url":"https://api.github.com/repos/open-eid/libdigidocpp/statuses/9039e621704b1fa83b93dbc2a4d172f442a8c1f5","head":{"label":"open-eid:IB-3793","ref":"IB-3793","sha":"9039e621704b1fa83b93dbc2a4d172f442a8c1f5","user":{"login":"open-eid","id":7879948,"avatar_url":"https://avatars.githubusercontent.com/u/7879948?v=3","gravatar_id":"","url":"https://api.github.com/users/open-eid","html_url":"https://github.com/open-eid","followers_url":"https://api.github.com/users/open-eid/followers","following_url":"https://api.github.com/users/open-eid/following{/other_user}","gists_url":"https://api.github.com/users/open-eid/gists{/gist_id}","starred_url":"https://api.github.com/users/open-eid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-eid/subscriptions","organizations_url":"https://api.github.com/users/open-eid/orgs","repos_url":"https://api.github.com/users/open-eid/repos","events_url":"https://api.github.com/users/open-eid/events{/privacy}","received_events_url":"https://api.github.com/users/open-eid/received_events","type":"Organization","site_admin":false},"repo":{"id":25913720,"name":"libdigidocpp","full_name":"open-eid/libdigidocpp","owner":{"login":"open-eid","id":7879948,"avatar_url":"https://avatars.githubusercontent.com/u/7879948?v=3","gravatar_id":"","url":"https://api.github.com/users/open-eid","html_url":"https://github.com/open-eid","followers_url":"https://api.github.com/users/open-eid/followers","following_url":"https://api.github.com/users/open-eid/following{/other_user}","gists_url":"https://api.github.com/users/open-eid/gists{/gist_id}","starred_url":"https://api.github.com/users/open-eid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-eid/subscriptions","organizations_url":"https://api.github.com/users/open-eid/orgs","repos_url":"https://api.github.com/users/open-eid/repos","events_url":"https://api.github.com/users/open-eid/events{/privacy}","received_events_url":"https://api.github.com/users/open-eid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-eid/libdigidocpp","description":"Libdigidocpp library offers creating, signing and verification of digitally signed documents, according to XAdES and XML-DSIG standards. Documentation http://open-eid.github.io/libdigidocpp","fork":false,"url":"https://api.github.com/repos/open-eid/libdigidocpp","forks_url":"https://api.github.com/repos/open-eid/libdigidocpp/forks","keys_url":"https://api.github.com/repos/open-eid/libdigidocpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-eid/libdigidocpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-eid/libdigidocpp/teams","hooks_url":"https://api.github.com/repos/open-eid/libdigidocpp/hooks","issue_events_url":"https://api.github.com/repos/open-eid/libdigidocpp/issues/events{/number}","events_url":"https://api.github.com/repos/open-eid/libdigidocpp/events","assignees_url":"https://api.github.com/repos/open-eid/libdigidocpp/assignees{/user}","branches_url":"https://api.github.com/repos/open-eid/libdigidocpp/branches{/branch}","tags_url":"https://api.github.com/repos/open-eid/libdigidocpp/tags","blobs_url":"https://api.github.com/repos/open-eid/libdigidocpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-eid/libdigidocpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-eid/libdigidocpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-eid/libdigidocpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-eid/libdigidocpp/statuses/{sha}","languages_url":"https://api.github.com/repos/open-eid/libdigidocpp/languages","stargazers_url":"https://api.github.com/repos/open-eid/libdigidocpp/stargazers","contributors_url":"https://api.github.com/repos/open-eid/libdigidocpp/contributors","subscribers_url":"https://api.github.com/repos/open-eid/libdigidocpp/subscribers","subscription_url":"https://api.github.com/repos/open-eid/libdigidocpp/subscription","commits_url":"https://api.github.com/repos/open-eid/libdigidocpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-eid/libdigidocpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-eid/libdigidocpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-eid/libdigidocpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-eid/libdigidocpp/contents/{+path}","compare_url":"https://api.github.com/repos/open-eid/libdigidocpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-eid/libdigidocpp/merges","archive_url":"https://api.github.com/repos/open-eid/libdigidocpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-eid/libdigidocpp/downloads","issues_url":"https://api.github.com/repos/open-eid/libdigidocpp/issues{/number}","pulls_url":"https://api.github.com/repos/open-eid/libdigidocpp/pulls{/number}","milestones_url":"https://api.github.com/repos/open-eid/libdigidocpp/milestones{/number}","notifications_url":"https://api.github.com/repos/open-eid/libdigidocpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-eid/libdigidocpp/labels{/name}","releases_url":"https://api.github.com/repos/open-eid/libdigidocpp/releases{/id}","deployments_url":"https://api.github.com/repos/open-eid/libdigidocpp/deployments","created_at":"2014-10-29T09:33:09Z","updated_at":"2016-10-07T07:34:53Z","pushed_at":"2016-10-13T15:09:17Z","git_url":"git://github.com/open-eid/libdigidocpp.git","ssh_url":"git@github.com:open-eid/libdigidocpp.git","clone_url":"https://github.com/open-eid/libdigidocpp.git","svn_url":"https://github.com/open-eid/libdigidocpp","homepage":"","size":26064,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":8,"forks":5,"open_issues":8,"watchers":8,"default_branch":"master"}},"base":{"label":"open-eid:master","ref":"master","sha":"dbaf228d206140ed7938103a9737689c33fb1a6b","user":{"login":"open-eid","id":7879948,"avatar_url":"https://avatars.githubusercontent.com/u/7879948?v=3","gravatar_id":"","url":"https://api.github.com/users/open-eid","html_url":"https://github.com/open-eid","followers_url":"https://api.github.com/users/open-eid/followers","following_url":"https://api.github.com/users/open-eid/following{/other_user}","gists_url":"https://api.github.com/users/open-eid/gists{/gist_id}","starred_url":"https://api.github.com/users/open-eid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-eid/subscriptions","organizations_url":"https://api.github.com/users/open-eid/orgs","repos_url":"https://api.github.com/users/open-eid/repos","events_url":"https://api.github.com/users/open-eid/events{/privacy}","received_events_url":"https://api.github.com/users/open-eid/received_events","type":"Organization","site_admin":false},"repo":{"id":25913720,"name":"libdigidocpp","full_name":"open-eid/libdigidocpp","owner":{"login":"open-eid","id":7879948,"avatar_url":"https://avatars.githubusercontent.com/u/7879948?v=3","gravatar_id":"","url":"https://api.github.com/users/open-eid","html_url":"https://github.com/open-eid","followers_url":"https://api.github.com/users/open-eid/followers","following_url":"https://api.github.com/users/open-eid/following{/other_user}","gists_url":"https://api.github.com/users/open-eid/gists{/gist_id}","starred_url":"https://api.github.com/users/open-eid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-eid/subscriptions","organizations_url":"https://api.github.com/users/open-eid/orgs","repos_url":"https://api.github.com/users/open-eid/repos","events_url":"https://api.github.com/users/open-eid/events{/privacy}","received_events_url":"https://api.github.com/users/open-eid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-eid/libdigidocpp","description":"Libdigidocpp library offers creating, signing and verification of digitally signed documents, according to XAdES and XML-DSIG standards. Documentation http://open-eid.github.io/libdigidocpp","fork":false,"url":"https://api.github.com/repos/open-eid/libdigidocpp","forks_url":"https://api.github.com/repos/open-eid/libdigidocpp/forks","keys_url":"https://api.github.com/repos/open-eid/libdigidocpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-eid/libdigidocpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-eid/libdigidocpp/teams","hooks_url":"https://api.github.com/repos/open-eid/libdigidocpp/hooks","issue_events_url":"https://api.github.com/repos/open-eid/libdigidocpp/issues/events{/number}","events_url":"https://api.github.com/repos/open-eid/libdigidocpp/events","assignees_url":"https://api.github.com/repos/open-eid/libdigidocpp/assignees{/user}","branches_url":"https://api.github.com/repos/open-eid/libdigidocpp/branches{/branch}","tags_url":"https://api.github.com/repos/open-eid/libdigidocpp/tags","blobs_url":"https://api.github.com/repos/open-eid/libdigidocpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-eid/libdigidocpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-eid/libdigidocpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-eid/libdigidocpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-eid/libdigidocpp/statuses/{sha}","languages_url":"https://api.github.com/repos/open-eid/libdigidocpp/languages","stargazers_url":"https://api.github.com/repos/open-eid/libdigidocpp/stargazers","contributors_url":"https://api.github.com/repos/open-eid/libdigidocpp/contributors","subscribers_url":"https://api.github.com/repos/open-eid/libdigidocpp/subscribers","subscription_url":"https://api.github.com/repos/open-eid/libdigidocpp/subscription","commits_url":"https://api.github.com/repos/open-eid/libdigidocpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-eid/libdigidocpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-eid/libdigidocpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-eid/libdigidocpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-eid/libdigidocpp/contents/{+path}","compare_url":"https://api.github.com/repos/open-eid/libdigidocpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-eid/libdigidocpp/merges","archive_url":"https://api.github.com/repos/open-eid/libdigidocpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-eid/libdigidocpp/downloads","issues_url":"https://api.github.com/repos/open-eid/libdigidocpp/issues{/number}","pulls_url":"https://api.github.com/repos/open-eid/libdigidocpp/pulls{/number}","milestones_url":"https://api.github.com/repos/open-eid/libdigidocpp/milestones{/number}","notifications_url":"https://api.github.com/repos/open-eid/libdigidocpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-eid/libdigidocpp/labels{/name}","releases_url":"https://api.github.com/repos/open-eid/libdigidocpp/releases{/id}","deployments_url":"https://api.github.com/repos/open-eid/libdigidocpp/deployments","created_at":"2014-10-29T09:33:09Z","updated_at":"2016-10-07T07:34:53Z","pushed_at":"2016-10-13T15:09:17Z","git_url":"git://github.com/open-eid/libdigidocpp.git","ssh_url":"git@github.com:open-eid/libdigidocpp.git","clone_url":"https://github.com/open-eid/libdigidocpp.git","svn_url":"https://github.com/open-eid/libdigidocpp","homepage":"","size":26064,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":8,"forks":5,"open_issues":8,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-eid/libdigidocpp/pulls/44"},"html":{"href":"https://github.com/open-eid/libdigidocpp/pull/44"},"issue":{"href":"https://api.github.com/repos/open-eid/libdigidocpp/issues/44"},"comments":{"href":"https://api.github.com/repos/open-eid/libdigidocpp/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/open-eid/libdigidocpp/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/open-eid/libdigidocpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-eid/libdigidocpp/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/open-eid/libdigidocpp/statuses/9039e621704b1fa83b93dbc2a4d172f442a8c1f5"}}}}
{"actor":{"display_login":"metsma"}}