{"action":"closed","issue":{"url":"https://api.github.com/repos/Seitanas/kvm-vdi/issues/61","repository_url":"https://api.github.com/repos/Seitanas/kvm-vdi","labels_url":"https://api.github.com/repos/Seitanas/kvm-vdi/issues/61/labels{/name}","comments_url":"https://api.github.com/repos/Seitanas/kvm-vdi/issues/61/comments","events_url":"https://api.github.com/repos/Seitanas/kvm-vdi/issues/61/events","html_url":"https://github.com/Seitanas/kvm-vdi/issues/61","id":177769012,"number":61,"title":"Possible SQL Injection attacks (character set dependent) ","user":{"login":"johnp","id":314391,"avatar_url":"https://avatars.githubusercontent.com/u/314391?v=3","gravatar_id":"","url":"https://api.github.com/users/johnp","html_url":"https://github.com/johnp","followers_url":"https://api.github.com/users/johnp/followers","following_url":"https://api.github.com/users/johnp/following{/other_user}","gists_url":"https://api.github.com/users/johnp/gists{/gist_id}","starred_url":"https://api.github.com/users/johnp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnp/subscriptions","organizations_url":"https://api.github.com/users/johnp/orgs","repos_url":"https://api.github.com/users/johnp/repos","events_url":"https://api.github.com/users/johnp/events{/privacy}","received_events_url":"https://api.github.com/users/johnp/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Seitanas/kvm-vdi/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-19T12:14:42Z","updated_at":"2016-10-18T05:51:40Z","closed_at":"2016-10-18T05:51:40Z","body":"Trying to clean user input via [`addslashes`](https://secure.php.net/manual/en/function.addslashes.php) does not prevent SQL Injection attacks. Therefore, [`login.php`](https://github.com/Seitanas/kvm-vdi/blob/master/login.php#L7) can be exploited to achieve SQL Injection if a character set that has multi-byte characters ending in `0x5c` is used. \r\n\r\nRelevant links:\r\n\r\n[http://howto.hackallthethings.com/2016/06/using-multi-byte-characters-to-nullify.html](http://howto.hackallthethings.com/2016/06/using-multi-byte-characters-to-nullify.html)\r\n[https://stackoverflow.com/questions/24595181/sql-injection-and-addslashes#24595207](https://stackoverflow.com/questions/24595181/sql-injection-and-addslashes#24595207)\r\n[http://shiflett.org/blog/2006/jan/addslashes-versus-mysql-real-escape-string](http://shiflett.org/blog/2006/jan/addslashes-versus-mysql-real-escape-string)\r\n\r\nVulnerable character sets:\r\n\r\n- Big5  \r\n     Used in Taiwan, Hong Kong, and Macau for \"Traditional Chinese\"\r\n- HKSCS  \r\n    Hong Kong's Big5 Supplementary Character Set\r\n- CP932  \r\n     Windows-31J (Japanese)\r\n- CP950  \r\n     Microsoft's implementation of Big5\r\n- GB18030  \r\n     Chinese National Character Set\r\n- GBK  \r\n     Simplified Chinese\r\n- JOHAB  \r\n    Korean Legacy Encoding\r\n- SHIFT_JIS  \r\n     Shift Japanese Industrial Standards "}}
{"actor":{"display_login":"Seitanas"}}