{"action":"created","issue":{"url":"https://api.github.com/repos/codecombat/codecombat/issues/3760","repository_url":"https://api.github.com/repos/codecombat/codecombat","labels_url":"https://api.github.com/repos/codecombat/codecombat/issues/3760/labels{/name}","comments_url":"https://api.github.com/repos/codecombat/codecombat/issues/3760/comments","events_url":"https://api.github.com/repos/codecombat/codecombat/issues/3760/events","html_url":"https://github.com/codecombat/codecombat/pull/3760","id":162222852,"number":3760,"title":"Multi thang select","user":{"login":"sderickson","id":204723,"avatar_url":"https://avatars.githubusercontent.com/u/204723?v=3","gravatar_id":"","url":"https://api.github.com/users/sderickson","html_url":"https://github.com/sderickson","followers_url":"https://api.github.com/users/sderickson/followers","following_url":"https://api.github.com/users/sderickson/following{/other_user}","gists_url":"https://api.github.com/users/sderickson/gists{/gist_id}","starred_url":"https://api.github.com/users/sderickson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sderickson/subscriptions","organizations_url":"https://api.github.com/users/sderickson/orgs","repos_url":"https://api.github.com/users/sderickson/repos","events_url":"https://api.github.com/users/sderickson/events{/privacy}","received_events_url":"https://api.github.com/users/sderickson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-06-24T20:15:57Z","updated_at":"2016-06-24T23:52:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/codecombat/codecombat/pulls/3760","html_url":"https://github.com/codecombat/codecombat/pull/3760","diff_url":"https://github.com/codecombat/codecombat/pull/3760.diff","patch_url":"https://github.com/codecombat/codecombat/pull/3760.patch"},"body":"* Command click to select/unselect individual thangs and move them around\r\n* Click to navigate disabled, drag to navigate works everywhere now\r\n* Keyboard shortcuts also work for all selected\r\n* Can select multiple by selecting them through the treema\r\n* Undo/redo does not group multi-thang changes like you'd expect cause time\r\n\r\nAs part of the process, I refactored mouse event handling to ThangsTabView. Much of the old logic scattered around in Surface and its components is still there, as other systems still use it. If we like this structure of code, then the rest will be refactored to match eventually.\r\n\r\nAlso tried moving selection to an array. Would like eventually to this to be a collection of thangs, such that the parent controlling GameUIState need not work with \"Lanks\" or any other Surface internals."},"comment":{"url":"https://api.github.com/repos/codecombat/codecombat/issues/comments/228491528","html_url":"https://github.com/codecombat/codecombat/pull/3760#issuecomment-228491528","issue_url":"https://api.github.com/repos/codecombat/codecombat/issues/3760","id":228491528,"user":{"login":"nwinter","id":99704,"avatar_url":"https://avatars.githubusercontent.com/u/99704?v=3","gravatar_id":"","url":"https://api.github.com/users/nwinter","html_url":"https://github.com/nwinter","followers_url":"https://api.github.com/users/nwinter/followers","following_url":"https://api.github.com/users/nwinter/following{/other_user}","gists_url":"https://api.github.com/users/nwinter/gists{/gist_id}","starred_url":"https://api.github.com/users/nwinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwinter/subscriptions","organizations_url":"https://api.github.com/users/nwinter/orgs","repos_url":"https://api.github.com/users/nwinter/repos","events_url":"https://api.github.com/users/nwinter/events{/privacy}","received_events_url":"https://api.github.com/users/nwinter/received_events","type":"User","site_admin":false},"created_at":"2016-06-24T23:52:11Z","updated_at":"2016-06-24T23:52:11Z","body":"Client tests need updating maybe? Not sure what this means: \r\n<img width=\"1010\" alt=\"screenshot 2016-06-24 16 49 15\" src=\"https://cloud.githubusercontent.com/assets/99704/16353201/c830db92-3a2b-11e6-9e24-ea79d5ab2de8.png\">\r\n\r\nI checked because I think removing configurable `angle` and `hFOV` for the Camera will break the camera specs. I don't ever anticipate actually updating those values now, so we can get rid of the specs which test different configurations."}}
{"actor":{"display_login":"nwinter"}}