{"action":"opened","number":32334,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/32334","id":65194179,"html_url":"https://github.com/saltstack/salt/pull/32334","diff_url":"https://github.com/saltstack/salt/pull/32334.diff","patch_url":"https://github.com/saltstack/salt/pull/32334.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/32334","number":32334,"state":"open","locked":false,"title":"Deleted win_servermanger_test.py","user":{"login":"jtand","id":12056331,"avatar_url":"https://avatars.githubusercontent.com/u/12056331?v=3","gravatar_id":"","url":"https://api.github.com/users/jtand","html_url":"https://github.com/jtand","followers_url":"https://api.github.com/users/jtand/followers","following_url":"https://api.github.com/users/jtand/following{/other_user}","gists_url":"https://api.github.com/users/jtand/gists{/gist_id}","starred_url":"https://api.github.com/users/jtand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtand/subscriptions","organizations_url":"https://api.github.com/users/jtand/orgs","repos_url":"https://api.github.com/users/jtand/repos","events_url":"https://api.github.com/users/jtand/events{/privacy}","received_events_url":"https://api.github.com/users/jtand/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\nThe win_servermanger_test.py wasn't actually testing anything. \r\n\r\n### What issues does this PR fix or reference?\r\nThe mock in _m_run() made it so any time the [_pshell](https://github.com/saltstack/salt/blob/develop/salt/modules/win_servermanager.py#L50) function was used it returned an empty string. These should only be run on windows, so will need to be rewritten at some point to correctly test the win_servermanager functionality. \r\n\r\n### Previous Behavior\r\nbad test was failing\r\n\r\n### New Behavior\r\nThe tests were bad and are being removed. \r\n\r\n### Tests written?\r\n\r\nNo\r\n\r\n","created_at":"2016-04-04T18:52:06Z","updated_at":"2016-04-04T18:52:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/32334/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/32334/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/32334/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/73118d014951e142fbad3af2fa09cf5b197acb1d","head":{"label":"jtand:delete_win_servermanager_test","ref":"delete_win_servermanager_test","sha":"73118d014951e142fbad3af2fa09cf5b197acb1d","user":{"login":"jtand","id":12056331,"avatar_url":"https://avatars.githubusercontent.com/u/12056331?v=3","gravatar_id":"","url":"https://api.github.com/users/jtand","html_url":"https://github.com/jtand","followers_url":"https://api.github.com/users/jtand/followers","following_url":"https://api.github.com/users/jtand/following{/other_user}","gists_url":"https://api.github.com/users/jtand/gists{/gist_id}","starred_url":"https://api.github.com/users/jtand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtand/subscriptions","organizations_url":"https://api.github.com/users/jtand/orgs","repos_url":"https://api.github.com/users/jtand/repos","events_url":"https://api.github.com/users/jtand/events{/privacy}","received_events_url":"https://api.github.com/users/jtand/received_events","type":"User","site_admin":false},"repo":{"id":34813246,"name":"salt","full_name":"jtand/salt","owner":{"login":"jtand","id":12056331,"avatar_url":"https://avatars.githubusercontent.com/u/12056331?v=3","gravatar_id":"","url":"https://api.github.com/users/jtand","html_url":"https://github.com/jtand","followers_url":"https://api.github.com/users/jtand/followers","following_url":"https://api.github.com/users/jtand/following{/other_user}","gists_url":"https://api.github.com/users/jtand/gists{/gist_id}","starred_url":"https://api.github.com/users/jtand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtand/subscriptions","organizations_url":"https://api.github.com/users/jtand/orgs","repos_url":"https://api.github.com/users/jtand/repos","events_url":"https://api.github.com/users/jtand/events{/privacy}","received_events_url":"https://api.github.com/users/jtand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jtand/salt","description":"Infrastructure automation and management system","fork":true,"url":"https://api.github.com/repos/jtand/salt","forks_url":"https://api.github.com/repos/jtand/salt/forks","keys_url":"https://api.github.com/repos/jtand/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jtand/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jtand/salt/teams","hooks_url":"https://api.github.com/repos/jtand/salt/hooks","issue_events_url":"https://api.github.com/repos/jtand/salt/issues/events{/number}","events_url":"https://api.github.com/repos/jtand/salt/events","assignees_url":"https://api.github.com/repos/jtand/salt/assignees{/user}","branches_url":"https://api.github.com/repos/jtand/salt/branches{/branch}","tags_url":"https://api.github.com/repos/jtand/salt/tags","blobs_url":"https://api.github.com/repos/jtand/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jtand/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jtand/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/jtand/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jtand/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/jtand/salt/languages","stargazers_url":"https://api.github.com/repos/jtand/salt/stargazers","contributors_url":"https://api.github.com/repos/jtand/salt/contributors","subscribers_url":"https://api.github.com/repos/jtand/salt/subscribers","subscription_url":"https://api.github.com/repos/jtand/salt/subscription","commits_url":"https://api.github.com/repos/jtand/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/jtand/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/jtand/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/jtand/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/jtand/salt/contents/{+path}","compare_url":"https://api.github.com/repos/jtand/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jtand/salt/merges","archive_url":"https://api.github.com/repos/jtand/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jtand/salt/downloads","issues_url":"https://api.github.com/repos/jtand/salt/issues{/number}","pulls_url":"https://api.github.com/repos/jtand/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/jtand/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/jtand/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jtand/salt/labels{/name}","releases_url":"https://api.github.com/repos/jtand/salt/releases{/id}","deployments_url":"https://api.github.com/repos/jtand/salt/deployments","created_at":"2015-04-29T19:14:16Z","updated_at":"2016-01-11T16:35:44Z","pushed_at":"2016-04-04T18:48:14Z","git_url":"git://github.com/jtand/salt.git","ssh_url":"git@github.com:jtand/salt.git","clone_url":"https://github.com/jtand/salt.git","svn_url":"https://github.com/jtand/salt","homepage":"saltstack.com","size":157470,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"05c62e914dba92dbdfb0c90bd1d0f4f478d92ff3","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt Open software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2016-04-04T18:37:02Z","pushed_at":"2016-04-04T18:42:04Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":171923,"stargazers_count":6388,"watchers_count":6388,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2812,"mirror_url":null,"open_issues_count":3461,"forks":2812,"open_issues":3461,"watchers":6388,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/32334"},"html":{"href":"https://github.com/saltstack/salt/pull/32334"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/32334"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/32334/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/32334/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/32334/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/73118d014951e142fbad3af2fa09cf5b197acb1d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":0,"deletions":84,"changed_files":1}}