{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/89045711","pull_request_review_id":9596976,"id":89045711,"diff_hunk":"@@ -166,7 +166,9 @@ pub struct Formatter<'a> {\n // NB. Argument is essentially an optimized partially applied formatting function,\n // equivalent to `exists T.(&T, fn(&T, &mut Formatter) -> Result`.\n \n-enum Void {}\n+struct Void {\n+    _private: (),\n+}","path":"src/libcore/fmt/mod.rs","position":7,"original_position":7,"commit_id":"d756f61a5a7ab84d58fdaa9d53d84f6dad29f8db","original_commit_id":"890c169b762a82eb34f62779b893803d2bac1420","user":{"login":"canndrew","id":5555066,"avatar_url":"https://avatars.githubusercontent.com/u/5555066?v=3","gravatar_id":"","url":"https://api.github.com/users/canndrew","html_url":"https://github.com/canndrew","followers_url":"https://api.github.com/users/canndrew/followers","following_url":"https://api.github.com/users/canndrew/following{/other_user}","gists_url":"https://api.github.com/users/canndrew/gists{/gist_id}","starred_url":"https://api.github.com/users/canndrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canndrew/subscriptions","organizations_url":"https://api.github.com/users/canndrew/orgs","repos_url":"https://api.github.com/users/canndrew/repos","events_url":"https://api.github.com/users/canndrew/events{/privacy}","received_events_url":"https://api.github.com/users/canndrew/received_events","type":"User","site_admin":false},"body":"First conceptually, then practically when tests fail.","created_at":"2016-11-22T05:30:28Z","updated_at":"2016-11-22T05:30:28Z","html_url":"https://github.com/rust-lang/rust/pull/36449#discussion_r89045711","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/36449","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/89045711"},"html":{"href":"https://github.com/rust-lang/rust/pull/36449#discussion_r89045711"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/36449"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/36449","id":85038874,"html_url":"https://github.com/rust-lang/rust/pull/36449","diff_url":"https://github.com/rust-lang/rust/pull/36449.diff","patch_url":"https://github.com/rust-lang/rust/pull/36449.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/36449","number":36449,"state":"open","locked":false,"title":"Expand is_uninhabited","user":{"login":"canndrew","id":5555066,"avatar_url":"https://avatars.githubusercontent.com/u/5555066?v=3","gravatar_id":"","url":"https://api.github.com/users/canndrew","html_url":"https://github.com/canndrew","followers_url":"https://api.github.com/users/canndrew/followers","following_url":"https://api.github.com/users/canndrew/following{/other_user}","gists_url":"https://api.github.com/users/canndrew/gists{/gist_id}","starred_url":"https://api.github.com/users/canndrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canndrew/subscriptions","organizations_url":"https://api.github.com/users/canndrew/orgs","repos_url":"https://api.github.com/users/canndrew/repos","events_url":"https://api.github.com/users/canndrew/events{/privacy}","received_events_url":"https://api.github.com/users/canndrew/received_events","type":"User","site_admin":false},"body":"This allows code such as this to compile:\n\n``` rust\nlet x: ! = ...;\nmatch x {};\n\nlet y: (u32, !) = ...;\nmatch y {};\n```\n\n@eddyb You were worried about making this change. Do you have any idea about what could break? Are there any special tests that need to be written for it?\n","created_at":"2016-09-13T12:29:59Z","updated_at":"2016-11-22T05:30:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"effd2b4e0d594374518868aded9408cc3e83fc0a","assignee":{"login":"arielb1","id":1830974,"avatar_url":"https://avatars.githubusercontent.com/u/1830974?v=3","gravatar_id":"","url":"https://api.github.com/users/arielb1","html_url":"https://github.com/arielb1","followers_url":"https://api.github.com/users/arielb1/followers","following_url":"https://api.github.com/users/arielb1/following{/other_user}","gists_url":"https://api.github.com/users/arielb1/gists{/gist_id}","starred_url":"https://api.github.com/users/arielb1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arielb1/subscriptions","organizations_url":"https://api.github.com/users/arielb1/orgs","repos_url":"https://api.github.com/users/arielb1/repos","events_url":"https://api.github.com/users/arielb1/events{/privacy}","received_events_url":"https://api.github.com/users/arielb1/received_events","type":"User","site_admin":false},"assignees":[{"login":"arielb1","id":1830974,"avatar_url":"https://avatars.githubusercontent.com/u/1830974?v=3","gravatar_id":"","url":"https://api.github.com/users/arielb1","html_url":"https://github.com/arielb1","followers_url":"https://api.github.com/users/arielb1/followers","following_url":"https://api.github.com/users/arielb1/following{/other_user}","gists_url":"https://api.github.com/users/arielb1/gists{/gist_id}","starred_url":"https://api.github.com/users/arielb1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arielb1/subscriptions","organizations_url":"https://api.github.com/users/arielb1/orgs","repos_url":"https://api.github.com/users/arielb1/repos","events_url":"https://api.github.com/users/arielb1/events{/privacy}","received_events_url":"https://api.github.com/users/arielb1/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/36449/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/36449/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/36449/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/d756f61a5a7ab84d58fdaa9d53d84f6dad29f8db","head":{"label":"canndrew:expand_is_uninhabited","ref":"expand_is_uninhabited","sha":"d756f61a5a7ab84d58fdaa9d53d84f6dad29f8db","user":{"login":"canndrew","id":5555066,"avatar_url":"https://avatars.githubusercontent.com/u/5555066?v=3","gravatar_id":"","url":"https://api.github.com/users/canndrew","html_url":"https://github.com/canndrew","followers_url":"https://api.github.com/users/canndrew/followers","following_url":"https://api.github.com/users/canndrew/following{/other_user}","gists_url":"https://api.github.com/users/canndrew/gists{/gist_id}","starred_url":"https://api.github.com/users/canndrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canndrew/subscriptions","organizations_url":"https://api.github.com/users/canndrew/orgs","repos_url":"https://api.github.com/users/canndrew/repos","events_url":"https://api.github.com/users/canndrew/events{/privacy}","received_events_url":"https://api.github.com/users/canndrew/received_events","type":"User","site_admin":false},"repo":{"id":19778924,"name":"rust","full_name":"canndrew/rust","owner":{"login":"canndrew","id":5555066,"avatar_url":"https://avatars.githubusercontent.com/u/5555066?v=3","gravatar_id":"","url":"https://api.github.com/users/canndrew","html_url":"https://github.com/canndrew","followers_url":"https://api.github.com/users/canndrew/followers","following_url":"https://api.github.com/users/canndrew/following{/other_user}","gists_url":"https://api.github.com/users/canndrew/gists{/gist_id}","starred_url":"https://api.github.com/users/canndrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canndrew/subscriptions","organizations_url":"https://api.github.com/users/canndrew/orgs","repos_url":"https://api.github.com/users/canndrew/repos","events_url":"https://api.github.com/users/canndrew/events{/privacy}","received_events_url":"https://api.github.com/users/canndrew/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/canndrew/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/canndrew/rust","forks_url":"https://api.github.com/repos/canndrew/rust/forks","keys_url":"https://api.github.com/repos/canndrew/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canndrew/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canndrew/rust/teams","hooks_url":"https://api.github.com/repos/canndrew/rust/hooks","issue_events_url":"https://api.github.com/repos/canndrew/rust/issues/events{/number}","events_url":"https://api.github.com/repos/canndrew/rust/events","assignees_url":"https://api.github.com/repos/canndrew/rust/assignees{/user}","branches_url":"https://api.github.com/repos/canndrew/rust/branches{/branch}","tags_url":"https://api.github.com/repos/canndrew/rust/tags","blobs_url":"https://api.github.com/repos/canndrew/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canndrew/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canndrew/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/canndrew/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canndrew/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/canndrew/rust/languages","stargazers_url":"https://api.github.com/repos/canndrew/rust/stargazers","contributors_url":"https://api.github.com/repos/canndrew/rust/contributors","subscribers_url":"https://api.github.com/repos/canndrew/rust/subscribers","subscription_url":"https://api.github.com/repos/canndrew/rust/subscription","commits_url":"https://api.github.com/repos/canndrew/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/canndrew/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/canndrew/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/canndrew/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/canndrew/rust/contents/{+path}","compare_url":"https://api.github.com/repos/canndrew/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canndrew/rust/merges","archive_url":"https://api.github.com/repos/canndrew/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canndrew/rust/downloads","issues_url":"https://api.github.com/repos/canndrew/rust/issues{/number}","pulls_url":"https://api.github.com/repos/canndrew/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/canndrew/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/canndrew/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canndrew/rust/labels{/name}","releases_url":"https://api.github.com/repos/canndrew/rust/releases{/id}","deployments_url":"https://api.github.com/repos/canndrew/rust/deployments","created_at":"2014-05-14T12:40:55Z","updated_at":"2016-05-09T13:16:41Z","pushed_at":"2016-11-22T05:28:12Z","git_url":"git://github.com/canndrew/rust.git","ssh_url":"git@github.com:canndrew/rust.git","clone_url":"https://github.com/canndrew/rust.git","svn_url":"https://github.com/canndrew/rust","homepage":"http://www.rust-lang.org","size":306303,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"82d8833a456a408fe8b761a3b5e88475b65066c8","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2016-11-22T04:26:48Z","pushed_at":"2016-11-22T05:27:58Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":526097,"stargazers_count":19071,"watchers_count":19071,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3662,"mirror_url":null,"open_issues_count":2888,"forks":3662,"open_issues":2888,"watchers":19071,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/36449"},"html":{"href":"https://github.com/rust-lang/rust/pull/36449"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/36449"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/36449/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/36449/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/36449/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/d756f61a5a7ab84d58fdaa9d53d84f6dad29f8db"}}}}
{"actor":{"display_login":"canndrew"}}