{"action":"created","issue":{"url":"https://api.github.com/repos/PixarAnimationStudios/USD/issues/5","repository_url":"https://api.github.com/repos/PixarAnimationStudios/USD","labels_url":"https://api.github.com/repos/PixarAnimationStudios/USD/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/PixarAnimationStudios/USD/issues/5/comments","events_url":"https://api.github.com/repos/PixarAnimationStudios/USD/issues/5/events","html_url":"https://github.com/PixarAnimationStudios/USD/issues/5","id":167899834,"number":5,"title":"reserved identifier violation","user":{"login":"elfring","id":660477,"avatar_url":"https://avatars.githubusercontent.com/u/660477?v=3","gravatar_id":"","url":"https://api.github.com/users/elfring","html_url":"https://github.com/elfring","followers_url":"https://api.github.com/users/elfring/followers","following_url":"https://api.github.com/users/elfring/following{/other_user}","gists_url":"https://api.github.com/users/elfring/gists{/gist_id}","starred_url":"https://api.github.com/users/elfring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfring/subscriptions","organizations_url":"https://api.github.com/users/elfring/orgs","repos_url":"https://api.github.com/users/elfring/repos","events_url":"https://api.github.com/users/elfring/events{/privacy}","received_events_url":"https://api.github.com/users/elfring/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-27T16:36:08Z","updated_at":"2016-08-02T21:28:58Z","closed_at":null,"body":"I would like to point out that identifiers like \"[`_DrawTargetPerContextMap`](https://github.com/PixarAnimationStudios/USD/blob/2eb01f5cd4c2dae4e1ef9912ca27a93083bb6ef4/pxr/usdImaging/lib/usdImaging/engine.h#L297)\" and \"[`_HasKind`](https://github.com/PixarAnimationStudios/USD/blob/2eb01f5cd4c2dae4e1ef9912ca27a93083bb6ef4/pxr/usd/lib/kind/registry.h#L102)\" [do eventually not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 \"Do not use identifiers that are reserved for the compiler implementation.\") to the expected naming convention of the C++ language standard.\r\nWould you like to adjust your selection for unique names?"},"comment":{"url":"https://api.github.com/repos/PixarAnimationStudios/USD/issues/comments/237050120","html_url":"https://github.com/PixarAnimationStudios/USD/issues/5#issuecomment-237050120","issue_url":"https://api.github.com/repos/PixarAnimationStudios/USD/issues/5","id":237050120,"user":{"login":"c64kernal","id":11595402,"avatar_url":"https://avatars.githubusercontent.com/u/11595402?v=3","gravatar_id":"","url":"https://api.github.com/users/c64kernal","html_url":"https://github.com/c64kernal","followers_url":"https://api.github.com/users/c64kernal/followers","following_url":"https://api.github.com/users/c64kernal/following{/other_user}","gists_url":"https://api.github.com/users/c64kernal/gists{/gist_id}","starred_url":"https://api.github.com/users/c64kernal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c64kernal/subscriptions","organizations_url":"https://api.github.com/users/c64kernal/orgs","repos_url":"https://api.github.com/users/c64kernal/repos","events_url":"https://api.github.com/users/c64kernal/events{/privacy}","received_events_url":"https://api.github.com/users/c64kernal/received_events","type":"User","site_admin":false},"created_at":"2016-08-02T21:28:58Z","updated_at":"2016-08-02T21:28:58Z","body":"Thanks for pointing this out, you're completely right of course.  Our coding conventions come from an old code base that is quite large.  We'd like to eventually move away from this one, but unfortunately it will take us some time.  Thanks again for reporting!"}}
{"actor":{"display_login":"c64kernal"}}