{"action":"created","issue":{"url":"https://api.github.com/repos/paperjs/paper.js/issues/1073","repository_url":"https://api.github.com/repos/paperjs/paper.js","labels_url":"https://api.github.com/repos/paperjs/paper.js/issues/1073/labels{/name}","comments_url":"https://api.github.com/repos/paperjs/paper.js/issues/1073/comments","events_url":"https://api.github.com/repos/paperjs/paper.js/issues/1073/events","html_url":"https://github.com/paperjs/paper.js/issues/1073","id":159769122,"number":1073,"title":"Optimize propagateWinding() ","user":{"login":"lehni","id":213275,"avatar_url":"https://avatars.githubusercontent.com/u/213275?v=3","gravatar_id":"","url":"https://api.github.com/users/lehni","html_url":"https://github.com/lehni","followers_url":"https://api.github.com/users/lehni/followers","following_url":"https://api.github.com/users/lehni/following{/other_user}","gists_url":"https://api.github.com/users/lehni/gists{/gist_id}","starred_url":"https://api.github.com/users/lehni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lehni/subscriptions","organizations_url":"https://api.github.com/users/lehni/orgs","repos_url":"https://api.github.com/users/lehni/repos","events_url":"https://api.github.com/users/lehni/events{/privacy}","received_events_url":"https://api.github.com/users/lehni/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/paperjs/paper.js/labels/cat:%20boolean-operations","name":"cat: boolean-operations","color":"c7def8"},{"url":"https://api.github.com/repos/paperjs/paper.js/labels/type:%20feature","name":"type: feature","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-11T11:23:09Z","updated_at":"2016-06-11T11:25:50Z","closed_at":null,"body":"@iconexperience I think we should devote an issue to the attempt to reduce the amount of winding \"sampling\" per curve. At the moment, it checks three evenly distributed locations along a chain, and then takes the average winding. This is weird and probably also a bit slow due to the call to `getWinding()`, but has worked well so far for us.\r\n\r\nIf I reduce the amount of samples to just one in the middle of the chain, I get only one failing test. But if I increase the samples to 4 or more, I get the exact same test failing. Even with 10 samples, it's the only test that fails. This has me thinking that using a value of 3 is actually hiding another issue in this one test, and we may be better off finding out what that is?\r\n "},"comment":{"url":"https://api.github.com/repos/paperjs/paper.js/issues/comments/225354329","html_url":"https://github.com/paperjs/paper.js/issues/1073#issuecomment-225354329","issue_url":"https://api.github.com/repos/paperjs/paper.js/issues/1073","id":225354329,"user":{"login":"lehni","id":213275,"avatar_url":"https://avatars.githubusercontent.com/u/213275?v=3","gravatar_id":"","url":"https://api.github.com/users/lehni","html_url":"https://github.com/lehni","followers_url":"https://api.github.com/users/lehni/followers","following_url":"https://api.github.com/users/lehni/following{/other_user}","gists_url":"https://api.github.com/users/lehni/gists{/gist_id}","starred_url":"https://api.github.com/users/lehni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lehni/subscriptions","organizations_url":"https://api.github.com/users/lehni/orgs","repos_url":"https://api.github.com/users/lehni/repos","events_url":"https://api.github.com/users/lehni/events{/privacy}","received_events_url":"https://api.github.com/users/lehni/received_events","type":"User","site_admin":false},"created_at":"2016-06-11T11:25:50Z","updated_at":"2016-06-11T11:25:50Z","body":"I've created the https://github.com/paperjs/paper.js/tree/propagate-winding branch for easier testing."}}
{"actor":{"display_login":"lehni"}}