{"action":"created","issue":{"url":"https://api.github.com/repos/Alamofire/Alamofire/issues/1488","repository_url":"https://api.github.com/repos/Alamofire/Alamofire","labels_url":"https://api.github.com/repos/Alamofire/Alamofire/issues/1488/labels{/name}","comments_url":"https://api.github.com/repos/Alamofire/Alamofire/issues/1488/comments","events_url":"https://api.github.com/repos/Alamofire/Alamofire/issues/1488/events","html_url":"https://github.com/Alamofire/Alamofire/pull/1488","id":175834047,"number":1488,"title":"better update for request","user":{"login":"tremblay","id":1121057,"avatar_url":"https://avatars.githubusercontent.com/u/1121057?v=3","gravatar_id":"","url":"https://api.github.com/users/tremblay","html_url":"https://github.com/tremblay","followers_url":"https://api.github.com/users/tremblay/followers","following_url":"https://api.github.com/users/tremblay/following{/other_user}","gists_url":"https://api.github.com/users/tremblay/gists{/gist_id}","starred_url":"https://api.github.com/users/tremblay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tremblay/subscriptions","organizations_url":"https://api.github.com/users/tremblay/orgs","repos_url":"https://api.github.com/users/tremblay/repos","events_url":"https://api.github.com/users/tremblay/events{/privacy}","received_events_url":"https://api.github.com/users/tremblay/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-08T18:55:16Z","updated_at":"2016-09-09T02:59:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Alamofire/Alamofire/pulls/1488","html_url":"https://github.com/Alamofire/Alamofire/pull/1488","diff_url":"https://github.com/Alamofire/Alamofire/pull/1488.diff","patch_url":"https://github.com/Alamofire/Alamofire/pull/1488.patch"},"body":"using `_` causes any existing code that called `request(urlRequest)` to\r\ncompile but potentially fail. because it needs to be updated to\r\n`request(resource: request)` but this is not caught by the compiler\r\nbecause `URLRequest` apparently conforms to `URLStringConvertible`.\r\n\r\nThis issue is evident in some of the tests, which compiled and actually\r\npassed, but were in fact calling the wrong `request`. \r\n\r\nI added a test that would fail if the wrong `request` is called to\r\nillustrate this point."},"comment":{"url":"https://api.github.com/repos/Alamofire/Alamofire/issues/comments/245805499","html_url":"https://github.com/Alamofire/Alamofire/pull/1488#issuecomment-245805499","issue_url":"https://api.github.com/repos/Alamofire/Alamofire/issues/1488","id":245805499,"user":{"login":"cnoon","id":169110,"avatar_url":"https://avatars.githubusercontent.com/u/169110?v=3","gravatar_id":"","url":"https://api.github.com/users/cnoon","html_url":"https://github.com/cnoon","followers_url":"https://api.github.com/users/cnoon/followers","following_url":"https://api.github.com/users/cnoon/following{/other_user}","gists_url":"https://api.github.com/users/cnoon/gists{/gist_id}","starred_url":"https://api.github.com/users/cnoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnoon/subscriptions","organizations_url":"https://api.github.com/users/cnoon/orgs","repos_url":"https://api.github.com/users/cnoon/repos","events_url":"https://api.github.com/users/cnoon/events{/privacy}","received_events_url":"https://api.github.com/users/cnoon/received_events","type":"User","site_admin":false},"created_at":"2016-09-09T02:59:58Z","updated_at":"2016-09-09T02:59:58Z","body":"Man, great catch @tremblay! I just put together #1491 that takes a different approach to solving the same problem. I'd love to get your thoughts there. We spent forever (literally hours) trying to get the public APIs just right and to be consistent across different request types. I think #1491 accomplishes this nicely by simply removing conformance where it isn't necessary."}}
{"actor":{"display_login":"cnoon"}}