{"action":"created","issue":{"url":"https://api.github.com/repos/ably/ably-dotnet/issues/81","repository_url":"https://api.github.com/repos/ably/ably-dotnet","labels_url":"https://api.github.com/repos/ably/ably-dotnet/issues/81/labels{/name}","comments_url":"https://api.github.com/repos/ably/ably-dotnet/issues/81/comments","events_url":"https://api.github.com/repos/ably/ably-dotnet/issues/81/events","html_url":"https://github.com/ably/ably-dotnet/issues/81","id":168551590,"number":81,"title":"Various inconsistencies following review of documentation","user":{"login":"mattheworiordan","id":43789,"avatar_url":"https://avatars.githubusercontent.com/u/43789?v=3","gravatar_id":"","url":"https://api.github.com/users/mattheworiordan","html_url":"https://github.com/mattheworiordan","followers_url":"https://api.github.com/users/mattheworiordan/followers","following_url":"https://api.github.com/users/mattheworiordan/following{/other_user}","gists_url":"https://api.github.com/users/mattheworiordan/gists{/gist_id}","starred_url":"https://api.github.com/users/mattheworiordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattheworiordan/subscriptions","organizations_url":"https://api.github.com/users/mattheworiordan/orgs","repos_url":"https://api.github.com/users/mattheworiordan/repos","events_url":"https://api.github.com/users/mattheworiordan/events{/privacy}","received_events_url":"https://api.github.com/users/mattheworiordan/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ably/ably-dotnet/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/ably/ably-dotnet/milestones/4","html_url":"https://github.com/ably/ably-dotnet/milestones/0.8.4","labels_url":"https://api.github.com/repos/ably/ably-dotnet/milestones/4/labels","id":1850419,"number":4,"title":"0.8.4","description":null,"creator":{"login":"marto83","id":150508,"avatar_url":"https://avatars.githubusercontent.com/u/150508?v=3","gravatar_id":"","url":"https://api.github.com/users/marto83","html_url":"https://github.com/marto83","followers_url":"https://api.github.com/users/marto83/followers","following_url":"https://api.github.com/users/marto83/following{/other_user}","gists_url":"https://api.github.com/users/marto83/gists{/gist_id}","starred_url":"https://api.github.com/users/marto83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marto83/subscriptions","organizations_url":"https://api.github.com/users/marto83/orgs","repos_url":"https://api.github.com/users/marto83/repos","events_url":"https://api.github.com/users/marto83/events{/privacy}","received_events_url":"https://api.github.com/users/marto83/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2016-06-27T13:09:59Z","updated_at":"2016-08-03T20:29:56Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2016-08-01T01:47:00Z","updated_at":"2016-08-08T08:25:55Z","closed_at":null,"body":"@marto83 please see the .NET docs you worked on and the commits I added on top at https://github.com/ably/docs/pull/138.  I have merged that in now and am about to deploy to the main website.\r\n\r\nWhilst working through the docs, I wrote down various notes in regards to inconsistencies in the .NET lib from the spec / other libraries.\r\n\r\n* [x] Having the public methods capitalised in C# and not in any other languages is a pain, but I don't suggest we change it.  It's more idiomatic this way, and we'll likely encounter this in other langs down the line anyway.\r\n* [ ] I noticed in a few cases such as `Presence.get` you opted for method arguments as opposed to an object or Hash params. The problem with this is it makes it hard to introduce a new argument that is frequently used unless C# supports named arguments.  For example, if the def is `get(foo1, foo2, foo3)` and later we want to add `foo4` which is a frequently specified arg, I believe you'd have to call it as `get(null, null, null, 'foo4val')`.  If we used an object type instead, then `get(new GetOptions { foo4 = 'foo4val' })` works better I think.  Do you know why we veered from this standard in some areas?\r\n* [x] connection state change type, why is this named differently from the spec?\r\n* [x] StatsDataRequest and DataRequest should be named `StatsQueryParams` and `HistoryQueryParams` to be more consistent with the other libs and also to make more sense.  That class is not a request, it's params for a request\r\n* [ ] We use upper case for all public methods / attributes, yet we don't for: https://github.com/ably/ably-dotnet/blob/master/src/IO.Ably.Shared/Types/ErrorInfo.cs. https://github.com/ably/ably-dotnet/blob/master/src/IO.Ably.Shared/Types/Message.cs  and https://github.com/ably/ably-dotnet/blob/master/src/IO.Ably.Shared/Types/PresenceMessage.cs.  We should fix that.\r\n* [x] Paginated result, `IsLast()` missing\r\n* [x] `Capability` class has only been defined in CSharp, yet there is no documentation for it.  I need you to provide some simple examples on how to use it and I can write some docs for usage.\r\n* [ ] Why does a `TokenRequest` have a string `Ttl` property instead of an `Integer` or `TimeSpan`?  Same issue applies to `Timestamp`, it's a `string`?  I understand the need for a `TokenDetails` capability to be a `string`, but the other fields don't make sense as `string`s\r\n* [x] `StatsINtervalGranularity` should be renamed to `StatsIntervalGranularity`\r\n* [ ] Can you confirm, is `PaginatedResult.HasNext` an attribute or a method, looks like a method to me.  Same question for `Presence.SyncComplete`, documented as an attribute but I think it's a lambda method?\r\n* [ ] `https://github.com/ably/ably-dotnet/blob/master/src/IO.Ably.Shared/DataRequestQuery.cs` - `By` should be `Unit` for specifying stats interval\r\n* [ ] `ConnectionState` `event` args should be called `state` for consistency with all other lib implementations\r\n* [ ] Why does `Unsubscribe` return a bool for action or event specific calls and then not for Unsubscribe for all on channels?  Unless there is a good reason to return a bool, we should make it consistent and return nothing\r\n* [ ] Why does `Attach` & `Detach` have a timespan in the lambda expression callback?\r\n* [ ] `Enter`/`Leave`/`Update`* methods need to be overloaded so that the data argument can be omitted\r\n* [ ] Why does `GetAsync(bool waitForSync = true, string clientId = \"\", string connectionId = \"\")` default to \"\" instead of Null.  I see a few examples in the code like this\r\n* [ ] The history attribute is `untilAttach`, not `untilAttached`\r\n"},"comment":{"url":"https://api.github.com/repos/ably/ably-dotnet/issues/comments/238172329","html_url":"https://github.com/ably/ably-dotnet/issues/81#issuecomment-238172329","issue_url":"https://api.github.com/repos/ably/ably-dotnet/issues/81","id":238172329,"user":{"login":"marto83","id":150508,"avatar_url":"https://avatars.githubusercontent.com/u/150508?v=3","gravatar_id":"","url":"https://api.github.com/users/marto83","html_url":"https://github.com/marto83","followers_url":"https://api.github.com/users/marto83/followers","following_url":"https://api.github.com/users/marto83/following{/other_user}","gists_url":"https://api.github.com/users/marto83/gists{/gist_id}","starred_url":"https://api.github.com/users/marto83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marto83/subscriptions","organizations_url":"https://api.github.com/users/marto83/orgs","repos_url":"https://api.github.com/users/marto83/repos","events_url":"https://api.github.com/users/marto83/events{/privacy}","received_events_url":"https://api.github.com/users/marto83/received_events","type":"User","site_admin":false},"created_at":"2016-08-08T08:25:55Z","updated_at":"2016-08-08T08:25:55Z","body":"I renamed StatsIntervalGranularity -> StatsGranularity. Should I keep it like that or change it back. "}}
{"actor":{"display_login":"marto83"}}