{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls/comments/89164753","pull_request_review_id":9713336,"id":89164753,"diff_hunk":"@@ -0,0 +1,118 @@\n+/*\n+ * Copyright 2016 Google Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package com.google.cloud.tools.eclipse.util;\n+\n+import com.google.cloud.tools.eclipse.util.status.StatusUtil;\n+import java.io.File;\n+import java.io.FileInputStream;\n+import java.io.IOException;\n+import java.io.InputStream;\n+import javax.xml.parsers.DocumentBuilderFactory;\n+import javax.xml.parsers.ParserConfigurationException;\n+import org.eclipse.core.runtime.CoreException;","path":"plugins/com.google.cloud.tools.eclipse.util/src/com/google/cloud/tools/eclipse/util/AppEngineDescriptor.java","position":26,"original_position":26,"commit_id":"0e4a8b99968dad4eceb02ffacc399ed8bb0f495a","original_commit_id":"0e4a8b99968dad4eceb02ffacc399ed8bb0f495a","user":{"login":"briandealwis","id":202851,"avatar_url":"https://avatars.githubusercontent.com/u/202851?v=3","gravatar_id":"","url":"https://api.github.com/users/briandealwis","html_url":"https://github.com/briandealwis","followers_url":"https://api.github.com/users/briandealwis/followers","following_url":"https://api.github.com/users/briandealwis/following{/other_user}","gists_url":"https://api.github.com/users/briandealwis/gists{/gist_id}","starred_url":"https://api.github.com/users/briandealwis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briandealwis/subscriptions","organizations_url":"https://api.github.com/users/briandealwis/orgs","repos_url":"https://api.github.com/users/briandealwis/repos","events_url":"https://api.github.com/users/briandealwis/events{/privacy}","received_events_url":"https://api.github.com/users/briandealwis/received_events","type":"User","site_admin":false},"body":"Agreed.  Will propose upwards.","created_at":"2016-11-22T17:11:56Z","updated_at":"2016-11-22T17:11:56Z","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse/pull/1001#discussion_r89164753","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls/1001","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls/comments/89164753"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse/pull/1001#discussion_r89164753"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls/1001"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls/1001","id":94745591,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse/pull/1001","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse/pull/1001.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse/pull/1001.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues/1001","number":1001,"state":"open","locked":false,"title":"Ensure projects added to local server have unique Service IDs","user":{"login":"briandealwis","id":202851,"avatar_url":"https://avatars.githubusercontent.com/u/202851?v=3","gravatar_id":"","url":"https://api.github.com/users/briandealwis","html_url":"https://github.com/briandealwis","followers_url":"https://api.github.com/users/briandealwis/followers","following_url":"https://api.github.com/users/briandealwis/following{/other_user}","gists_url":"https://api.github.com/users/briandealwis/gists{/gist_id}","starred_url":"https://api.github.com/users/briandealwis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briandealwis/subscriptions","organizations_url":"https://api.github.com/users/briandealwis/orgs","repos_url":"https://api.github.com/users/briandealwis/repos","events_url":"https://api.github.com/users/briandealwis/events{/privacy}","received_events_url":"https://api.github.com/users/briandealwis/received_events","type":"User","site_admin":false},"body":"- split LocalAppEngineServerDelegate#canModify() into separate methods\r\n  to simplify testing\r\n- extract utility class for obtaining the Service ID for a WTP IModule\r\n- extract utility class for resolving web module locations files within a\r\n  IProject\r\n- resurrect AppEngineDeployInfo as AppEngineDescriptor for parsing and\r\n  extracting information from an appengine-web.xml; left <project>\r\n  and <version> accessors as they will be useful for warnings\r\n\r\nFixes #926 ","created_at":"2016-11-22T04:16:48Z","updated_at":"2016-11-22T17:11:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f715d0911ac5f1549eec4867e30cbca06bacce8e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls/1001/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls/1001/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues/1001/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/statuses/0e4a8b99968dad4eceb02ffacc399ed8bb0f495a","head":{"label":"GoogleCloudPlatform:i926","ref":"i926","sha":"0e4a8b99968dad4eceb02ffacc399ed8bb0f495a","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":53369484,"name":"google-cloud-eclipse","full_name":"GoogleCloudPlatform/google-cloud-eclipse","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse","description":"Google Cloud Platform plugin for Eclipse","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/deployments","created_at":"2016-03-08T00:30:03Z","updated_at":"2016-11-20T02:57:23Z","pushed_at":"2016-11-22T14:56:20Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-eclipse.git","ssh_url":"git@github.com:GoogleCloudPlatform/google-cloud-eclipse.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse","homepage":"","size":7671,"stargazers_count":15,"watchers_count":15,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":177,"forks":8,"open_issues":177,"watchers":15,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"d918d591ee59e5182f58ca0a4942eddfa2a97215","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":53369484,"name":"google-cloud-eclipse","full_name":"GoogleCloudPlatform/google-cloud-eclipse","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse","description":"Google Cloud Platform plugin for Eclipse","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/deployments","created_at":"2016-03-08T00:30:03Z","updated_at":"2016-11-20T02:57:23Z","pushed_at":"2016-11-22T14:56:20Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-eclipse.git","ssh_url":"git@github.com:GoogleCloudPlatform/google-cloud-eclipse.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse","homepage":"","size":7671,"stargazers_count":15,"watchers_count":15,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":177,"forks":8,"open_issues":177,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls/1001"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse/pull/1001"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues/1001"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues/1001/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls/1001/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls/1001/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/statuses/0e4a8b99968dad4eceb02ffacc399ed8bb0f495a"}}}}
{"actor":{"display_login":"briandealwis"}}