{"action":"created","comment":{"url":"https://api.github.com/repos/getsentry/raven-php/pulls/comments/51046451","id":51046451,"diff_hunk":"@@ -155,10 +158,13 @@ public function registerExceptionHandler($call_existing_exception_handler = true\n         $this->call_existing_exception_handler = $call_existing_exception_handler;\n     }\n \n-    public function registerErrorHandler($call_existing_error_handler = true, $error_types = -1)\n+    public function registerErrorHandler($call_existing_error_handler = true, $error_types = null)\n     {\n+        if ($error_types == null) {\n+            $error_type = error_reporting();\n+        }\n         $this->error_types = $error_types;\n-        $this->old_error_handler = set_error_handler(array($this, 'handleError'), error_reporting());\n+        $this->old_error_handler = set_error_handler(array($this, 'handleError'), -1);","path":"lib/Raven/ErrorHandler.php","position":60,"original_position":60,"commit_id":"e93cad62e1d9390b36af92a8c0cad76283a0a8bf","original_commit_id":"e93cad62e1d9390b36af92a8c0cad76283a0a8bf","user":{"login":"dcramer","id":23610,"avatar_url":"https://avatars.githubusercontent.com/u/23610?v=3","gravatar_id":"","url":"https://api.github.com/users/dcramer","html_url":"https://github.com/dcramer","followers_url":"https://api.github.com/users/dcramer/followers","following_url":"https://api.github.com/users/dcramer/following{/other_user}","gists_url":"https://api.github.com/users/dcramer/gists{/gist_id}","starred_url":"https://api.github.com/users/dcramer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcramer/subscriptions","organizations_url":"https://api.github.com/users/dcramer/orgs","repos_url":"https://api.github.com/users/dcramer/repos","events_url":"https://api.github.com/users/dcramer/events{/privacy}","received_events_url":"https://api.github.com/users/dcramer/received_events","type":"User","site_admin":false},"body":"we're basically changing the logic to say \"always call our error handler, we'll determine later if we care about the event\"","created_at":"2016-01-27T20:40:25Z","updated_at":"2016-01-27T20:40:25Z","html_url":"https://github.com/getsentry/raven-php/pull/258#discussion_r51046451","pull_request_url":"https://api.github.com/repos/getsentry/raven-php/pulls/258","_links":{"self":{"href":"https://api.github.com/repos/getsentry/raven-php/pulls/comments/51046451"},"html":{"href":"https://github.com/getsentry/raven-php/pull/258#discussion_r51046451"},"pull_request":{"href":"https://api.github.com/repos/getsentry/raven-php/pulls/258"}}},"pull_request":{"url":"https://api.github.com/repos/getsentry/raven-php/pulls/258","id":57419112,"html_url":"https://github.com/getsentry/raven-php/pull/258","diff_url":"https://github.com/getsentry/raven-php/pull/258.diff","patch_url":"https://github.com/getsentry/raven-php/pull/258.patch","issue_url":"https://api.github.com/repos/getsentry/raven-php/issues/258","number":258,"state":"open","locked":false,"title":"Ensure error_types are handled correctly","user":{"login":"dcramer","id":23610,"avatar_url":"https://avatars.githubusercontent.com/u/23610?v=3","gravatar_id":"","url":"https://api.github.com/users/dcramer","html_url":"https://github.com/dcramer","followers_url":"https://api.github.com/users/dcramer/followers","following_url":"https://api.github.com/users/dcramer/following{/other_user}","gists_url":"https://api.github.com/users/dcramer/gists{/gist_id}","starred_url":"https://api.github.com/users/dcramer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcramer/subscriptions","organizations_url":"https://api.github.com/users/dcramer/orgs","repos_url":"https://api.github.com/users/dcramer/repos","events_url":"https://api.github.com/users/dcramer/events{/privacy}","received_events_url":"https://api.github.com/users/dcramer/received_events","type":"User","site_admin":false},"body":"This corrects behavior that would allow you to specify which error_types are handled by the SDK, but would simply ignore it if they were also not included in error_reporting. ","created_at":"2016-01-27T20:39:33Z","updated_at":"2016-01-27T20:40:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7eb92d9933914a0c16d08d2bef5eabab93ecbdf6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/getsentry/raven-php/pulls/258/commits","review_comments_url":"https://api.github.com/repos/getsentry/raven-php/pulls/258/comments","review_comment_url":"https://api.github.com/repos/getsentry/raven-php/pulls/comments{/number}","comments_url":"https://api.github.com/repos/getsentry/raven-php/issues/258/comments","statuses_url":"https://api.github.com/repos/getsentry/raven-php/statuses/e93cad62e1d9390b36af92a8c0cad76283a0a8bf","head":{"label":"getsentry:better-error-types","ref":"better-error-types","sha":"e93cad62e1d9390b36af92a8c0cad76283a0a8bf","user":{"login":"getsentry","id":1396951,"avatar_url":"https://avatars.githubusercontent.com/u/1396951?v=3","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"repo":{"id":3244931,"name":"raven-php","full_name":"getsentry/raven-php","owner":{"login":"getsentry","id":1396951,"avatar_url":"https://avatars.githubusercontent.com/u/1396951?v=3","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getsentry/raven-php","description":"Raven is a PHP client for Sentry (getsentry.com)","fork":false,"url":"https://api.github.com/repos/getsentry/raven-php","forks_url":"https://api.github.com/repos/getsentry/raven-php/forks","keys_url":"https://api.github.com/repos/getsentry/raven-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getsentry/raven-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getsentry/raven-php/teams","hooks_url":"https://api.github.com/repos/getsentry/raven-php/hooks","issue_events_url":"https://api.github.com/repos/getsentry/raven-php/issues/events{/number}","events_url":"https://api.github.com/repos/getsentry/raven-php/events","assignees_url":"https://api.github.com/repos/getsentry/raven-php/assignees{/user}","branches_url":"https://api.github.com/repos/getsentry/raven-php/branches{/branch}","tags_url":"https://api.github.com/repos/getsentry/raven-php/tags","blobs_url":"https://api.github.com/repos/getsentry/raven-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getsentry/raven-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getsentry/raven-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/getsentry/raven-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getsentry/raven-php/statuses/{sha}","languages_url":"https://api.github.com/repos/getsentry/raven-php/languages","stargazers_url":"https://api.github.com/repos/getsentry/raven-php/stargazers","contributors_url":"https://api.github.com/repos/getsentry/raven-php/contributors","subscribers_url":"https://api.github.com/repos/getsentry/raven-php/subscribers","subscription_url":"https://api.github.com/repos/getsentry/raven-php/subscription","commits_url":"https://api.github.com/repos/getsentry/raven-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/getsentry/raven-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/getsentry/raven-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/getsentry/raven-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/getsentry/raven-php/contents/{+path}","compare_url":"https://api.github.com/repos/getsentry/raven-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getsentry/raven-php/merges","archive_url":"https://api.github.com/repos/getsentry/raven-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getsentry/raven-php/downloads","issues_url":"https://api.github.com/repos/getsentry/raven-php/issues{/number}","pulls_url":"https://api.github.com/repos/getsentry/raven-php/pulls{/number}","milestones_url":"https://api.github.com/repos/getsentry/raven-php/milestones{/number}","notifications_url":"https://api.github.com/repos/getsentry/raven-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getsentry/raven-php/labels{/name}","releases_url":"https://api.github.com/repos/getsentry/raven-php/releases{/id}","deployments_url":"https://api.github.com/repos/getsentry/raven-php/deployments","created_at":"2012-01-23T07:34:48Z","updated_at":"2016-01-25T04:01:54Z","pushed_at":"2016-01-27T20:39:33Z","git_url":"git://github.com/getsentry/raven-php.git","ssh_url":"git@github.com:getsentry/raven-php.git","clone_url":"https://github.com/getsentry/raven-php.git","svn_url":"https://github.com/getsentry/raven-php","homepage":"https://getsentry.com","size":1011,"stargazers_count":365,"watchers_count":365,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":153,"mirror_url":null,"open_issues_count":44,"forks":153,"open_issues":44,"watchers":365,"default_branch":"master"}},"base":{"label":"getsentry:master","ref":"master","sha":"51d1647007c37f5d1cdc222b74aa09f395be3dac","user":{"login":"getsentry","id":1396951,"avatar_url":"https://avatars.githubusercontent.com/u/1396951?v=3","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"repo":{"id":3244931,"name":"raven-php","full_name":"getsentry/raven-php","owner":{"login":"getsentry","id":1396951,"avatar_url":"https://avatars.githubusercontent.com/u/1396951?v=3","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getsentry/raven-php","description":"Raven is a PHP client for Sentry (getsentry.com)","fork":false,"url":"https://api.github.com/repos/getsentry/raven-php","forks_url":"https://api.github.com/repos/getsentry/raven-php/forks","keys_url":"https://api.github.com/repos/getsentry/raven-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getsentry/raven-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getsentry/raven-php/teams","hooks_url":"https://api.github.com/repos/getsentry/raven-php/hooks","issue_events_url":"https://api.github.com/repos/getsentry/raven-php/issues/events{/number}","events_url":"https://api.github.com/repos/getsentry/raven-php/events","assignees_url":"https://api.github.com/repos/getsentry/raven-php/assignees{/user}","branches_url":"https://api.github.com/repos/getsentry/raven-php/branches{/branch}","tags_url":"https://api.github.com/repos/getsentry/raven-php/tags","blobs_url":"https://api.github.com/repos/getsentry/raven-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getsentry/raven-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getsentry/raven-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/getsentry/raven-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getsentry/raven-php/statuses/{sha}","languages_url":"https://api.github.com/repos/getsentry/raven-php/languages","stargazers_url":"https://api.github.com/repos/getsentry/raven-php/stargazers","contributors_url":"https://api.github.com/repos/getsentry/raven-php/contributors","subscribers_url":"https://api.github.com/repos/getsentry/raven-php/subscribers","subscription_url":"https://api.github.com/repos/getsentry/raven-php/subscription","commits_url":"https://api.github.com/repos/getsentry/raven-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/getsentry/raven-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/getsentry/raven-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/getsentry/raven-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/getsentry/raven-php/contents/{+path}","compare_url":"https://api.github.com/repos/getsentry/raven-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getsentry/raven-php/merges","archive_url":"https://api.github.com/repos/getsentry/raven-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getsentry/raven-php/downloads","issues_url":"https://api.github.com/repos/getsentry/raven-php/issues{/number}","pulls_url":"https://api.github.com/repos/getsentry/raven-php/pulls{/number}","milestones_url":"https://api.github.com/repos/getsentry/raven-php/milestones{/number}","notifications_url":"https://api.github.com/repos/getsentry/raven-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getsentry/raven-php/labels{/name}","releases_url":"https://api.github.com/repos/getsentry/raven-php/releases{/id}","deployments_url":"https://api.github.com/repos/getsentry/raven-php/deployments","created_at":"2012-01-23T07:34:48Z","updated_at":"2016-01-25T04:01:54Z","pushed_at":"2016-01-27T20:39:33Z","git_url":"git://github.com/getsentry/raven-php.git","ssh_url":"git@github.com:getsentry/raven-php.git","clone_url":"https://github.com/getsentry/raven-php.git","svn_url":"https://github.com/getsentry/raven-php","homepage":"https://getsentry.com","size":1011,"stargazers_count":365,"watchers_count":365,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":153,"mirror_url":null,"open_issues_count":44,"forks":153,"open_issues":44,"watchers":365,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/getsentry/raven-php/pulls/258"},"html":{"href":"https://github.com/getsentry/raven-php/pull/258"},"issue":{"href":"https://api.github.com/repos/getsentry/raven-php/issues/258"},"comments":{"href":"https://api.github.com/repos/getsentry/raven-php/issues/258/comments"},"review_comments":{"href":"https://api.github.com/repos/getsentry/raven-php/pulls/258/comments"},"review_comment":{"href":"https://api.github.com/repos/getsentry/raven-php/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/getsentry/raven-php/pulls/258/commits"},"statuses":{"href":"https://api.github.com/repos/getsentry/raven-php/statuses/e93cad62e1d9390b36af92a8c0cad76283a0a8bf"}}}}