{"action":"created","comment":{"url":"https://api.github.com/repos/aodn/thredds/pulls/comments/78889418","id":78889418,"diff_hunk":"@@ -98,6 +108,41 @@ public ObjectListing listObjects(S3URI s3uri) {\n         return objectListing.orNull();\n     }\n \n+    @Override\n+    public ThreddsS3Metadata getMetadata(S3URI s3uri) {\n+        Optional<ThreddsS3Metadata> metadata = metadataCache.getIfPresent(s3uri);\n+        if (metadata == null) {","path":"cdm/src/main/java/thredds/crawlabledataset/s3/CachingThreddsS3Client.java","position":31,"original_position":31,"commit_id":"ef596e67f08f0238deea0c65e48505e1b65df310","original_commit_id":"ef596e67f08f0238deea0c65e48505e1b65df310","user":{"login":"jonescc","id":1860215,"avatar_url":"https://avatars.githubusercontent.com/u/1860215?v=3","gravatar_id":"","url":"https://api.github.com/users/jonescc","html_url":"https://github.com/jonescc","followers_url":"https://api.github.com/users/jonescc/followers","following_url":"https://api.github.com/users/jonescc/following{/other_user}","gists_url":"https://api.github.com/users/jonescc/gists{/gist_id}","starred_url":"https://api.github.com/users/jonescc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonescc/subscriptions","organizations_url":"https://api.github.com/users/jonescc/orgs","repos_url":"https://api.github.com/users/jonescc/repos","events_url":"https://api.github.com/users/jonescc/events{/privacy}","received_events_url":"https://api.github.com/users/jonescc/received_events","type":"User","site_admin":false},"body":"Served a purpose here.","created_at":"2016-09-15T04:48:28Z","updated_at":"2016-09-15T04:48:28Z","html_url":"https://github.com/aodn/thredds/pull/5#discussion_r78889418","pull_request_url":"https://api.github.com/repos/aodn/thredds/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/aodn/thredds/pulls/comments/78889418"},"html":{"href":"https://github.com/aodn/thredds/pull/5#discussion_r78889418"},"pull_request":{"href":"https://api.github.com/repos/aodn/thredds/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/aodn/thredds/pulls/5","id":84990131,"html_url":"https://github.com/aodn/thredds/pull/5","diff_url":"https://github.com/aodn/thredds/pull/5.diff","patch_url":"https://github.com/aodn/thredds/pull/5.patch","issue_url":"https://api.github.com/repos/aodn/thredds/issues/5","number":5,"state":"open","locked":false,"title":"Support s3 virtual directories with more than 1000 entries","user":{"login":"jonescc","id":1860215,"avatar_url":"https://avatars.githubusercontent.com/u/1860215?v=3","gravatar_id":"","url":"https://api.github.com/users/jonescc","html_url":"https://github.com/jonescc","followers_url":"https://api.github.com/users/jonescc/followers","following_url":"https://api.github.com/users/jonescc/following{/other_user}","gists_url":"https://api.github.com/users/jonescc/gists{/gist_id}","starred_url":"https://api.github.com/users/jonescc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonescc/subscriptions","organizations_url":"https://api.github.com/users/jonescc/orgs","repos_url":"https://api.github.com/users/jonescc/repos","events_url":"https://api.github.com/users/jonescc/events{/privacy}","received_events_url":"https://api.github.com/users/jonescc/received_events","type":"User","site_admin":false},"body":"Fix performance problems with s3 hierarchy traversal in core code\r\n\r\n","created_at":"2016-09-13T06:07:49Z","updated_at":"2016-09-15T04:48:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85b59c0b610159c6f3b69293fc073a4464100d03","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aodn/thredds/pulls/5/commits","review_comments_url":"https://api.github.com/repos/aodn/thredds/pulls/5/comments","review_comment_url":"https://api.github.com/repos/aodn/thredds/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aodn/thredds/issues/5/comments","statuses_url":"https://api.github.com/repos/aodn/thredds/statuses/ef596e67f08f0238deea0c65e48505e1b65df310","head":{"label":"aodn:v4.6.6-s3-paging","ref":"v4.6.6-s3-paging","sha":"ef596e67f08f0238deea0c65e48505e1b65df310","user":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"repo":{"id":23298661,"name":"thredds","full_name":"aodn/thredds","owner":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aodn/thredds","description":"Thredds and netCDF-Java (CDM)","fork":true,"url":"https://api.github.com/repos/aodn/thredds","forks_url":"https://api.github.com/repos/aodn/thredds/forks","keys_url":"https://api.github.com/repos/aodn/thredds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aodn/thredds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aodn/thredds/teams","hooks_url":"https://api.github.com/repos/aodn/thredds/hooks","issue_events_url":"https://api.github.com/repos/aodn/thredds/issues/events{/number}","events_url":"https://api.github.com/repos/aodn/thredds/events","assignees_url":"https://api.github.com/repos/aodn/thredds/assignees{/user}","branches_url":"https://api.github.com/repos/aodn/thredds/branches{/branch}","tags_url":"https://api.github.com/repos/aodn/thredds/tags","blobs_url":"https://api.github.com/repos/aodn/thredds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aodn/thredds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aodn/thredds/git/refs{/sha}","trees_url":"https://api.github.com/repos/aodn/thredds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aodn/thredds/statuses/{sha}","languages_url":"https://api.github.com/repos/aodn/thredds/languages","stargazers_url":"https://api.github.com/repos/aodn/thredds/stargazers","contributors_url":"https://api.github.com/repos/aodn/thredds/contributors","subscribers_url":"https://api.github.com/repos/aodn/thredds/subscribers","subscription_url":"https://api.github.com/repos/aodn/thredds/subscription","commits_url":"https://api.github.com/repos/aodn/thredds/commits{/sha}","git_commits_url":"https://api.github.com/repos/aodn/thredds/git/commits{/sha}","comments_url":"https://api.github.com/repos/aodn/thredds/comments{/number}","issue_comment_url":"https://api.github.com/repos/aodn/thredds/issues/comments{/number}","contents_url":"https://api.github.com/repos/aodn/thredds/contents/{+path}","compare_url":"https://api.github.com/repos/aodn/thredds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aodn/thredds/merges","archive_url":"https://api.github.com/repos/aodn/thredds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aodn/thredds/downloads","issues_url":"https://api.github.com/repos/aodn/thredds/issues{/number}","pulls_url":"https://api.github.com/repos/aodn/thredds/pulls{/number}","milestones_url":"https://api.github.com/repos/aodn/thredds/milestones{/number}","notifications_url":"https://api.github.com/repos/aodn/thredds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aodn/thredds/labels{/name}","releases_url":"https://api.github.com/repos/aodn/thredds/releases{/id}","deployments_url":"https://api.github.com/repos/aodn/thredds/deployments","created_at":"2014-08-25T02:01:52Z","updated_at":"2015-09-09T06:23:32Z","pushed_at":"2016-09-13T06:07:50Z","git_url":"git://github.com/aodn/thredds.git","ssh_url":"git@github.com:aodn/thredds.git","clone_url":"https://github.com/aodn/thredds.git","svn_url":"https://github.com/aodn/thredds","homepage":"http://www.unidata.ucar.edu/software/netcdf-java/documentation.htm","size":876480,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"v4.3.17-imos"}},"base":{"label":"aodn:v4.6.6-imos","ref":"v4.6.6-imos","sha":"9382fbe9782364f7eb07cba018a577f8927e486b","user":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"repo":{"id":23298661,"name":"thredds","full_name":"aodn/thredds","owner":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aodn/thredds","description":"Thredds and netCDF-Java (CDM)","fork":true,"url":"https://api.github.com/repos/aodn/thredds","forks_url":"https://api.github.com/repos/aodn/thredds/forks","keys_url":"https://api.github.com/repos/aodn/thredds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aodn/thredds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aodn/thredds/teams","hooks_url":"https://api.github.com/repos/aodn/thredds/hooks","issue_events_url":"https://api.github.com/repos/aodn/thredds/issues/events{/number}","events_url":"https://api.github.com/repos/aodn/thredds/events","assignees_url":"https://api.github.com/repos/aodn/thredds/assignees{/user}","branches_url":"https://api.github.com/repos/aodn/thredds/branches{/branch}","tags_url":"https://api.github.com/repos/aodn/thredds/tags","blobs_url":"https://api.github.com/repos/aodn/thredds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aodn/thredds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aodn/thredds/git/refs{/sha}","trees_url":"https://api.github.com/repos/aodn/thredds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aodn/thredds/statuses/{sha}","languages_url":"https://api.github.com/repos/aodn/thredds/languages","stargazers_url":"https://api.github.com/repos/aodn/thredds/stargazers","contributors_url":"https://api.github.com/repos/aodn/thredds/contributors","subscribers_url":"https://api.github.com/repos/aodn/thredds/subscribers","subscription_url":"https://api.github.com/repos/aodn/thredds/subscription","commits_url":"https://api.github.com/repos/aodn/thredds/commits{/sha}","git_commits_url":"https://api.github.com/repos/aodn/thredds/git/commits{/sha}","comments_url":"https://api.github.com/repos/aodn/thredds/comments{/number}","issue_comment_url":"https://api.github.com/repos/aodn/thredds/issues/comments{/number}","contents_url":"https://api.github.com/repos/aodn/thredds/contents/{+path}","compare_url":"https://api.github.com/repos/aodn/thredds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aodn/thredds/merges","archive_url":"https://api.github.com/repos/aodn/thredds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aodn/thredds/downloads","issues_url":"https://api.github.com/repos/aodn/thredds/issues{/number}","pulls_url":"https://api.github.com/repos/aodn/thredds/pulls{/number}","milestones_url":"https://api.github.com/repos/aodn/thredds/milestones{/number}","notifications_url":"https://api.github.com/repos/aodn/thredds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aodn/thredds/labels{/name}","releases_url":"https://api.github.com/repos/aodn/thredds/releases{/id}","deployments_url":"https://api.github.com/repos/aodn/thredds/deployments","created_at":"2014-08-25T02:01:52Z","updated_at":"2015-09-09T06:23:32Z","pushed_at":"2016-09-13T06:07:50Z","git_url":"git://github.com/aodn/thredds.git","ssh_url":"git@github.com:aodn/thredds.git","clone_url":"https://github.com/aodn/thredds.git","svn_url":"https://github.com/aodn/thredds","homepage":"http://www.unidata.ucar.edu/software/netcdf-java/documentation.htm","size":876480,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"v4.3.17-imos"}},"_links":{"self":{"href":"https://api.github.com/repos/aodn/thredds/pulls/5"},"html":{"href":"https://github.com/aodn/thredds/pull/5"},"issue":{"href":"https://api.github.com/repos/aodn/thredds/issues/5"},"comments":{"href":"https://api.github.com/repos/aodn/thredds/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/aodn/thredds/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/aodn/thredds/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aodn/thredds/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/aodn/thredds/statuses/ef596e67f08f0238deea0c65e48505e1b65df310"}}}}
{"actor":{"display_login":"jonescc"}}