{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/69045758","id":69045758,"diff_hunk":"@@ -408,7 +427,9 @@ func writePreferences(configAccess ConfigAccess, newPrefs clientcmdapi.Preferenc\n func GetConfigFromFileOrDie(filename string) *clientcmdapi.Config {\n \tconfig, err := LoadFromFile(filename)\n \tif err != nil && !os.IsNotExist(err) {\n-\t\tglog.FatalDepth(1, err)\n+\t\tglog.ErrorDepth(1, err)","path":"pkg/client/unversioned/clientcmd/config.go","position":null,"original_position":38,"commit_id":"00576278b520ee1c1fb5e86d4ba14501956fd633","original_commit_id":"c4e477c8fc128f06701fc2c6a32717015f3a6438","user":{"login":"cjcullen","id":7154008,"avatar_url":"https://avatars.githubusercontent.com/u/7154008?v=3","gravatar_id":"","url":"https://api.github.com/users/cjcullen","html_url":"https://github.com/cjcullen","followers_url":"https://api.github.com/users/cjcullen/followers","following_url":"https://api.github.com/users/cjcullen/following{/other_user}","gists_url":"https://api.github.com/users/cjcullen/gists{/gist_id}","starred_url":"https://api.github.com/users/cjcullen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjcullen/subscriptions","organizations_url":"https://api.github.com/users/cjcullen/orgs","repos_url":"https://api.github.com/users/cjcullen/repos","events_url":"https://api.github.com/users/cjcullen/events{/privacy}","received_events_url":"https://api.github.com/users/cjcullen/received_events","type":"User","site_admin":false},"body":"Done. `GetConfigFromFileOrDie` should be unchanged. `ModifyConfig` now uses the new `getConfigFromFile` and handles its errors.","created_at":"2016-06-29T23:18:50Z","updated_at":"2016-06-29T23:18:50Z","html_url":"https://github.com/kubernetes/kubernetes/pull/28232#discussion_r69045758","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28232","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/69045758"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/28232#discussion_r69045758"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28232"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28232","id":75698174,"html_url":"https://github.com/kubernetes/kubernetes/pull/28232","diff_url":"https://github.com/kubernetes/kubernetes/pull/28232.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/28232.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28232","number":28232,"state":"open","locked":false,"title":"Lock all possible kubecfg files at the beginning of ModifyConfig.","user":{"login":"cjcullen","id":7154008,"avatar_url":"https://avatars.githubusercontent.com/u/7154008?v=3","gravatar_id":"","url":"https://api.github.com/users/cjcullen","html_url":"https://github.com/cjcullen","followers_url":"https://api.github.com/users/cjcullen/followers","following_url":"https://api.github.com/users/cjcullen/following{/other_user}","gists_url":"https://api.github.com/users/cjcullen/gists{/gist_id}","starred_url":"https://api.github.com/users/cjcullen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjcullen/subscriptions","organizations_url":"https://api.github.com/users/cjcullen/orgs","repos_url":"https://api.github.com/users/cjcullen/repos","events_url":"https://api.github.com/users/cjcullen/events{/privacy}","received_events_url":"https://api.github.com/users/cjcullen/received_events","type":"User","site_admin":false},"body":"Prevent concurrent calls to ModifyConfig on the same (or overlapping) kubeconfig files.","created_at":"2016-06-29T18:31:02Z","updated_at":"2016-06-29T23:18:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4da4d3e5b91c77e16d550b644b1295b9788402f1","assignee":{"login":"krousey","id":157083,"avatar_url":"https://avatars.githubusercontent.com/u/157083?v=3","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},"assignees":[{"login":"krousey","id":157083,"avatar_url":"https://avatars.githubusercontent.com/u/157083?v=3","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28232/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28232/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28232/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/00576278b520ee1c1fb5e86d4ba14501956fd633","head":{"label":"cjcullen:webhook2","ref":"webhook2","sha":"00576278b520ee1c1fb5e86d4ba14501956fd633","user":{"login":"cjcullen","id":7154008,"avatar_url":"https://avatars.githubusercontent.com/u/7154008?v=3","gravatar_id":"","url":"https://api.github.com/users/cjcullen","html_url":"https://github.com/cjcullen","followers_url":"https://api.github.com/users/cjcullen/followers","following_url":"https://api.github.com/users/cjcullen/following{/other_user}","gists_url":"https://api.github.com/users/cjcullen/gists{/gist_id}","starred_url":"https://api.github.com/users/cjcullen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjcullen/subscriptions","organizations_url":"https://api.github.com/users/cjcullen/orgs","repos_url":"https://api.github.com/users/cjcullen/repos","events_url":"https://api.github.com/users/cjcullen/events{/privacy}","received_events_url":"https://api.github.com/users/cjcullen/received_events","type":"User","site_admin":false},"repo":{"id":22969428,"name":"kubernetes","full_name":"cjcullen/kubernetes","owner":{"login":"cjcullen","id":7154008,"avatar_url":"https://avatars.githubusercontent.com/u/7154008?v=3","gravatar_id":"","url":"https://api.github.com/users/cjcullen","html_url":"https://github.com/cjcullen","followers_url":"https://api.github.com/users/cjcullen/followers","following_url":"https://api.github.com/users/cjcullen/following{/other_user}","gists_url":"https://api.github.com/users/cjcullen/gists{/gist_id}","starred_url":"https://api.github.com/users/cjcullen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjcullen/subscriptions","organizations_url":"https://api.github.com/users/cjcullen/orgs","repos_url":"https://api.github.com/users/cjcullen/repos","events_url":"https://api.github.com/users/cjcullen/events{/privacy}","received_events_url":"https://api.github.com/users/cjcullen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cjcullen/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/cjcullen/kubernetes","forks_url":"https://api.github.com/repos/cjcullen/kubernetes/forks","keys_url":"https://api.github.com/repos/cjcullen/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cjcullen/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cjcullen/kubernetes/teams","hooks_url":"https://api.github.com/repos/cjcullen/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/cjcullen/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/cjcullen/kubernetes/events","assignees_url":"https://api.github.com/repos/cjcullen/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/cjcullen/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/cjcullen/kubernetes/tags","blobs_url":"https://api.github.com/repos/cjcullen/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cjcullen/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cjcullen/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/cjcullen/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cjcullen/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/cjcullen/kubernetes/languages","stargazers_url":"https://api.github.com/repos/cjcullen/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/cjcullen/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/cjcullen/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/cjcullen/kubernetes/subscription","commits_url":"https://api.github.com/repos/cjcullen/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/cjcullen/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/cjcullen/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/cjcullen/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/cjcullen/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/cjcullen/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cjcullen/kubernetes/merges","archive_url":"https://api.github.com/repos/cjcullen/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cjcullen/kubernetes/downloads","issues_url":"https://api.github.com/repos/cjcullen/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/cjcullen/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/cjcullen/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/cjcullen/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cjcullen/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/cjcullen/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/cjcullen/kubernetes/deployments","created_at":"2014-08-14T21:36:31Z","updated_at":"2016-01-15T19:52:38Z","pushed_at":"2016-06-29T23:17:13Z","git_url":"git://github.com/cjcullen/kubernetes.git","ssh_url":"git@github.com:cjcullen/kubernetes.git","clone_url":"https://github.com/cjcullen/kubernetes.git","svn_url":"https://github.com/cjcullen/kubernetes","homepage":null,"size":266724,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"8621326a7a542605cb958a61c37b27fa80f6d12c","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-06-29T22:49:11Z","pushed_at":"2016-06-29T23:17:15Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":482797,"stargazers_count":15157,"watchers_count":15157,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4736,"mirror_url":null,"open_issues_count":3763,"forks":4736,"open_issues":3763,"watchers":15157,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28232"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/28232"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/28232"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/28232/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28232/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28232/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/00576278b520ee1c1fb5e86d4ba14501956fd633"}}}}
{"actor":{"display_login":"cjcullen"}}