{"action":"created","issue":{"url":"https://api.github.com/repos/evernote/serge/issues/17","repository_url":"https://api.github.com/repos/evernote/serge","labels_url":"https://api.github.com/repos/evernote/serge/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/evernote/serge/issues/17/comments","events_url":"https://api.github.com/repos/evernote/serge/issues/17/events","html_url":"https://github.com/evernote/serge/issues/17","id":159502996,"number":17,"title":"Serge::Engine::Plugin::parse_yaml errors","user":{"login":"erikogan","id":60583,"avatar_url":"https://avatars.githubusercontent.com/u/60583?v=3","gravatar_id":"","url":"https://api.github.com/users/erikogan","html_url":"https://github.com/erikogan","followers_url":"https://api.github.com/users/erikogan/followers","following_url":"https://api.github.com/users/erikogan/following{/other_user}","gists_url":"https://api.github.com/users/erikogan/gists{/gist_id}","starred_url":"https://api.github.com/users/erikogan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikogan/subscriptions","organizations_url":"https://api.github.com/users/erikogan/orgs","repos_url":"https://api.github.com/users/erikogan/repos","events_url":"https://api.github.com/users/erikogan/events{/privacy}","received_events_url":"https://api.github.com/users/erikogan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-06-09T20:41:05Z","updated_at":"2016-06-10T03:21:40Z","closed_at":null,"body":"Attempting to use `parse_yaml` results in errors: \r\n\r\n```\r\nERROR: Parser plugin didn't provide a key value in a callback. Importing translations with this plugin is not possible.\r\n```\r\n\r\nI believe this is because it is passing arguments to the callback in the wrong order. In particular it is passing the key path as the third argument, and `Serge::Importer::parse_source_file_callback` uses that argument as the hint. \r\n\r\n`parse_yaml` is also only passing 5 arguments to the callback, which suggests to me it was written for a different version of the parser API."},"comment":{"url":"https://api.github.com/repos/evernote/serge/issues/comments/225084465","html_url":"https://github.com/evernote/serge/issues/17#issuecomment-225084465","issue_url":"https://api.github.com/repos/evernote/serge/issues/17","id":225084465,"user":{"login":"iafan","id":1728158,"avatar_url":"https://avatars.githubusercontent.com/u/1728158?v=3","gravatar_id":"","url":"https://api.github.com/users/iafan","html_url":"https://github.com/iafan","followers_url":"https://api.github.com/users/iafan/followers","following_url":"https://api.github.com/users/iafan/following{/other_user}","gists_url":"https://api.github.com/users/iafan/gists{/gist_id}","starred_url":"https://api.github.com/users/iafan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iafan/subscriptions","organizations_url":"https://api.github.com/users/iafan/orgs","repos_url":"https://api.github.com/users/iafan/repos","events_url":"https://api.github.com/users/iafan/events{/privacy}","received_events_url":"https://api.github.com/users/iafan/received_events","type":"User","site_admin":false},"created_at":"2016-06-10T03:21:40Z","updated_at":"2016-06-10T03:21:40Z","body":"> unique key for each file\r\n\r\nA unique key for each string within any given file, to be more precise.\r\n\r\nThis key value is only used for source<=>translation alignment during import, and technically can be any string. Ideally a key value would be tolerant to the order in which strings appear in the file. For YAML, constructed path is a nice candidate for such key values, provided the path stays the same for both source and localized copy of the file (so in case of Ruby-ob-Rails localization file format style where top node is the name of the language, we need to address #19 to make sure paths can be used for string alignment)."}}
{"actor":{"display_login":"iafan"}}