{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/52430333","id":52430333,"diff_hunk":"@@ -8,9 +8,79 @@\n // option. This file may not be copied, modified, or distributed\n // except according to those terms.\n \n-use mir::repr::Mir;\n+use mir::repr::{Mir, BasicBlockData, BasicBlock};\n+use mir::mir_map::MirMap;\n use middle::ty::ctxt;\n \n-pub trait MirPass {\n-    fn run_on_mir<'tcx>(&mut self, mir: &mut Mir<'tcx>, tcx: &ctxt<'tcx>);\n+/// Contains various metadata about the pass.\n+pub trait Pass {\n+    /// Ordering of the pass. Lower value runs the pass earlier.\n+    fn priority(&self) -> usize;\n+    // Possibly also `fn name()` and `fn should_run(Session)` etc.\n+}\n+\n+/// Pass which inspects the whole MirMap.\n+pub trait MirMapPass: Pass {\n+    fn run_pass<'tcx>(&mut self, tcx: &ctxt<'tcx>, map: &mut MirMap<'tcx>);\n+}\n+\n+/// Pass which only inspects MIR of distinct functions.\n+pub trait MirPass: Pass {\n+    fn run_pass<'tcx>(&mut self, tcx: &ctxt<'tcx>, mir: &mut Mir<'tcx>);\n+}\n+\n+/// Pass which only inspects basic blocks in MIR.\n+///\n+/// Invariant: The blocks are considered to be fully self-contained for the purposes of this pass –","path":"src/librustc/mir/transform.rs","position":30,"original_position":30,"commit_id":"b1d9e8892533eb94281517d2729d194ba5e5084f","original_commit_id":"b1d9e8892533eb94281517d2729d194ba5e5084f","user":{"login":"oli-obk","id":332036,"avatar_url":"https://avatars.githubusercontent.com/u/332036?v=3","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false},"body":"Why do we need this invariant? For the `MirPass` implementor it's irrelevant, as it's the same as making sure that the visitor and the `run_pass` method don't modify the `Mir` object. For the compiler there's no advantage to knowing this as I see it.","created_at":"2016-02-10T09:03:05Z","updated_at":"2016-02-10T09:03:05Z","html_url":"https://github.com/rust-lang/rust/pull/31448#discussion_r52430333","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/31448","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/52430333"},"html":{"href":"https://github.com/rust-lang/rust/pull/31448#discussion_r52430333"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/31448"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/31448","id":58519498,"html_url":"https://github.com/rust-lang/rust/pull/31448","diff_url":"https://github.com/rust-lang/rust/pull/31448.diff","patch_url":"https://github.com/rust-lang/rust/pull/31448.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/31448","number":31448,"state":"open","locked":false,"title":"[MIR] Add a pass manager","user":{"login":"nagisa","id":679122,"avatar_url":"https://avatars.githubusercontent.com/u/679122?v=3","gravatar_id":"","url":"https://api.github.com/users/nagisa","html_url":"https://github.com/nagisa","followers_url":"https://api.github.com/users/nagisa/followers","following_url":"https://api.github.com/users/nagisa/following{/other_user}","gists_url":"https://api.github.com/users/nagisa/gists{/gist_id}","starred_url":"https://api.github.com/users/nagisa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nagisa/subscriptions","organizations_url":"https://api.github.com/users/nagisa/orgs","repos_url":"https://api.github.com/users/nagisa/repos","events_url":"https://api.github.com/users/nagisa/events{/privacy}","received_events_url":"https://api.github.com/users/nagisa/received_events","type":"User","site_admin":false},"body":"Previously we would run MIR passes in a very ad-hoc way by calling passses directly everywhere across the compiler. This PR adds a proper pass manager which will run all the passes in some order (decided by the `priority` method in `Pass`) right after the MIR is constructed. I believe the pass manager should be general enough to be able to accommodate passes as complex as MIR-based borrowck.\r\n\r\nThe next step here would be to add something like `-Z mir-opt-level=[0..]` defaulting to `1 + -C opt-level` and a `fn should_run(&Session)` so the passes could decide whether they want to run under a given optimisation level or not.\r\n\r\nDepends on https://github.com/rust-lang/rust/pull/31425 landing first.\r\n\r\nr? @nikomatsakis","created_at":"2016-02-06T12:46:13Z","updated_at":"2016-02-10T09:03:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07562a32ab1ee5e762236684613e08cd08ab3179","assignee":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/31448/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/31448/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/31448/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/b1d9e8892533eb94281517d2729d194ba5e5084f","head":{"label":"nagisa:mir-tiered-passes","ref":"mir-tiered-passes","sha":"b1d9e8892533eb94281517d2729d194ba5e5084f","user":{"login":"nagisa","id":679122,"avatar_url":"https://avatars.githubusercontent.com/u/679122?v=3","gravatar_id":"","url":"https://api.github.com/users/nagisa","html_url":"https://github.com/nagisa","followers_url":"https://api.github.com/users/nagisa/followers","following_url":"https://api.github.com/users/nagisa/following{/other_user}","gists_url":"https://api.github.com/users/nagisa/gists{/gist_id}","starred_url":"https://api.github.com/users/nagisa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nagisa/subscriptions","organizations_url":"https://api.github.com/users/nagisa/orgs","repos_url":"https://api.github.com/users/nagisa/repos","events_url":"https://api.github.com/users/nagisa/events{/privacy}","received_events_url":"https://api.github.com/users/nagisa/received_events","type":"User","site_admin":false},"repo":{"id":28332501,"name":"rust","full_name":"nagisa/rust","owner":{"login":"nagisa","id":679122,"avatar_url":"https://avatars.githubusercontent.com/u/679122?v=3","gravatar_id":"","url":"https://api.github.com/users/nagisa","html_url":"https://github.com/nagisa","followers_url":"https://api.github.com/users/nagisa/followers","following_url":"https://api.github.com/users/nagisa/following{/other_user}","gists_url":"https://api.github.com/users/nagisa/gists{/gist_id}","starred_url":"https://api.github.com/users/nagisa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nagisa/subscriptions","organizations_url":"https://api.github.com/users/nagisa/orgs","repos_url":"https://api.github.com/users/nagisa/repos","events_url":"https://api.github.com/users/nagisa/events{/privacy}","received_events_url":"https://api.github.com/users/nagisa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nagisa/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/nagisa/rust","forks_url":"https://api.github.com/repos/nagisa/rust/forks","keys_url":"https://api.github.com/repos/nagisa/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nagisa/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nagisa/rust/teams","hooks_url":"https://api.github.com/repos/nagisa/rust/hooks","issue_events_url":"https://api.github.com/repos/nagisa/rust/issues/events{/number}","events_url":"https://api.github.com/repos/nagisa/rust/events","assignees_url":"https://api.github.com/repos/nagisa/rust/assignees{/user}","branches_url":"https://api.github.com/repos/nagisa/rust/branches{/branch}","tags_url":"https://api.github.com/repos/nagisa/rust/tags","blobs_url":"https://api.github.com/repos/nagisa/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nagisa/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nagisa/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/nagisa/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nagisa/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/nagisa/rust/languages","stargazers_url":"https://api.github.com/repos/nagisa/rust/stargazers","contributors_url":"https://api.github.com/repos/nagisa/rust/contributors","subscribers_url":"https://api.github.com/repos/nagisa/rust/subscribers","subscription_url":"https://api.github.com/repos/nagisa/rust/subscription","commits_url":"https://api.github.com/repos/nagisa/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/nagisa/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/nagisa/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/nagisa/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/nagisa/rust/contents/{+path}","compare_url":"https://api.github.com/repos/nagisa/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nagisa/rust/merges","archive_url":"https://api.github.com/repos/nagisa/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nagisa/rust/downloads","issues_url":"https://api.github.com/repos/nagisa/rust/issues{/number}","pulls_url":"https://api.github.com/repos/nagisa/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/nagisa/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/nagisa/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nagisa/rust/labels{/name}","releases_url":"https://api.github.com/repos/nagisa/rust/releases{/id}","deployments_url":"https://api.github.com/repos/nagisa/rust/deployments","created_at":"2014-12-22T09:30:51Z","updated_at":"2015-01-13T13:18:02Z","pushed_at":"2016-02-09T23:16:31Z","git_url":"git://github.com/nagisa/rust.git","ssh_url":"git@github.com:nagisa/rust.git","clone_url":"https://github.com/nagisa/rust.git","svn_url":"https://github.com/nagisa/rust","homepage":"http://www.rust-lang.org","size":278084,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"096dbf84c7acc78283adfa46eecd41d7355f6f3e","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2016-02-10T08:57:10Z","pushed_at":"2016-02-10T08:08:23Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":470119,"stargazers_count":15280,"watchers_count":15280,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2972,"mirror_url":null,"open_issues_count":2316,"forks":2972,"open_issues":2316,"watchers":15280,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/31448"},"html":{"href":"https://github.com/rust-lang/rust/pull/31448"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/31448"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/31448/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/31448/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/31448/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/b1d9e8892533eb94281517d2729d194ba5e5084f"}}}}