{"action":"created","comment":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments/50962155","id":50962155,"diff_hunk":"@@ -302,6 +305,92 @@ DWORD WLog_GetLogLevel(wLog* log)\n \t}\n }\n \n+BOOL WLog_SetStringLogLevel(wLog* log, LPCSTR level)\n+{\n+\tint lvl;\n+\tif (!log || !level)\n+\t\treturn FALSE;\n+\n+\tlvl = WLog_ParseLogLevel(level);\n+\tif (lvl < 0)\n+\t\treturn FALSE;\n+\n+\treturn WLog_SetLogLevel(log, lvl);\n+}\n+\n+BOOL WLog_AddStringLogFilters(LPCSTR filter)\n+{\n+\tDWORD pos;\n+\tDWORD size;\n+\tDWORD count;\n+\tDWORD status;\n+\tLPSTR p;\n+\tLPSTR s;\n+\tLPSTR cp;\n+\twLogFilter* tmp;\n+\n+\tif (!filter)\n+\t\treturn FALSE;\n+\n+\tcount = 1;\n+\tp = (LPSTR)filter;\n+\n+\twhile ((p = strchr(p, ',')) != NULL)\n+\t{\n+\t\tcount++;\n+\t\tp++;\n+\t}\n+\n+\tpos = g_FilterCount;\n+\tsize = g_FilterCount + count;\n+\ttmp = (wLogFilter*) realloc(g_Filters, size * sizeof(wLogFilter));\n+\n+\tif (!tmp)\n+\t{\n+\t\tfree (g_Filters);","path":"winpr/libwinpr/utils/wlog/wlog.c","position":74,"original_position":74,"commit_id":"46a079fcb6e06f94dbf97e718019a301b6cfd60b","original_commit_id":"46a079fcb6e06f94dbf97e718019a301b6cfd60b","user":{"login":"hardening","id":3237998,"avatar_url":"https://avatars.githubusercontent.com/u/3237998?v=3","gravatar_id":"","url":"https://api.github.com/users/hardening","html_url":"https://github.com/hardening","followers_url":"https://api.github.com/users/hardening/followers","following_url":"https://api.github.com/users/hardening/following{/other_user}","gists_url":"https://api.github.com/users/hardening/gists{/gist_id}","starred_url":"https://api.github.com/users/hardening/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hardening/subscriptions","organizations_url":"https://api.github.com/users/hardening/orgs","repos_url":"https://api.github.com/users/hardening/repos","events_url":"https://api.github.com/users/hardening/events{/privacy}","received_events_url":"https://api.github.com/users/hardening/received_events","type":"User","site_admin":false},"body":"Do we need to free g_Filters ?","created_at":"2016-01-27T10:00:56Z","updated_at":"2016-01-27T10:00:56Z","html_url":"https://github.com/FreeRDP/FreeRDP/pull/3078#discussion_r50962155","pull_request_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/3078","_links":{"self":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments/50962155"},"html":{"href":"https://github.com/FreeRDP/FreeRDP/pull/3078#discussion_r50962155"},"pull_request":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/3078"}}},"pull_request":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/3078","id":56977176,"html_url":"https://github.com/FreeRDP/FreeRDP/pull/3078","diff_url":"https://github.com/FreeRDP/FreeRDP/pull/3078.diff","patch_url":"https://github.com/FreeRDP/FreeRDP/pull/3078.patch","issue_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/3078","number":3078,"state":"open","locked":false,"title":"Added new command line options for logger.","user":{"login":"akallabeth","id":3472254,"avatar_url":"https://avatars.githubusercontent.com/u/3472254?v=3","gravatar_id":"","url":"https://api.github.com/users/akallabeth","html_url":"https://github.com/akallabeth","followers_url":"https://api.github.com/users/akallabeth/followers","following_url":"https://api.github.com/users/akallabeth/following{/other_user}","gists_url":"https://api.github.com/users/akallabeth/gists{/gist_id}","starred_url":"https://api.github.com/users/akallabeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akallabeth/subscriptions","organizations_url":"https://api.github.com/users/akallabeth/orgs","repos_url":"https://api.github.com/users/akallabeth/repos","events_url":"https://api.github.com/users/akallabeth/events{/privacy}","received_events_url":"https://api.github.com/users/akallabeth/received_events","type":"User","site_admin":false},"body":"The new command line options /log-level:<level> and\r\n/log-filters:<filter>:<level> allow setting default log\r\nlevel and log module filter to be set.","created_at":"2016-01-23T14:18:54Z","updated_at":"2016-01-27T10:00:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77f9cac9d2ce4481eaa6d1cc2787ec251234573c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/3078/commits","review_comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/3078/comments","review_comment_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/3078/comments","statuses_url":"https://api.github.com/repos/FreeRDP/FreeRDP/statuses/46a079fcb6e06f94dbf97e718019a301b6cfd60b","head":{"label":"akallabeth:wlog_cmd_options","ref":"wlog_cmd_options","sha":"46a079fcb6e06f94dbf97e718019a301b6cfd60b","user":{"login":"akallabeth","id":3472254,"avatar_url":"https://avatars.githubusercontent.com/u/3472254?v=3","gravatar_id":"","url":"https://api.github.com/users/akallabeth","html_url":"https://github.com/akallabeth","followers_url":"https://api.github.com/users/akallabeth/followers","following_url":"https://api.github.com/users/akallabeth/following{/other_user}","gists_url":"https://api.github.com/users/akallabeth/gists{/gist_id}","starred_url":"https://api.github.com/users/akallabeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akallabeth/subscriptions","organizations_url":"https://api.github.com/users/akallabeth/orgs","repos_url":"https://api.github.com/users/akallabeth/repos","events_url":"https://api.github.com/users/akallabeth/events{/privacy}","received_events_url":"https://api.github.com/users/akallabeth/received_events","type":"User","site_admin":false},"repo":{"id":11418147,"name":"FreeRDP","full_name":"akallabeth/FreeRDP","owner":{"login":"akallabeth","id":3472254,"avatar_url":"https://avatars.githubusercontent.com/u/3472254?v=3","gravatar_id":"","url":"https://api.github.com/users/akallabeth","html_url":"https://github.com/akallabeth","followers_url":"https://api.github.com/users/akallabeth/followers","following_url":"https://api.github.com/users/akallabeth/following{/other_user}","gists_url":"https://api.github.com/users/akallabeth/gists{/gist_id}","starred_url":"https://api.github.com/users/akallabeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akallabeth/subscriptions","organizations_url":"https://api.github.com/users/akallabeth/orgs","repos_url":"https://api.github.com/users/akallabeth/repos","events_url":"https://api.github.com/users/akallabeth/events{/privacy}","received_events_url":"https://api.github.com/users/akallabeth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akallabeth/FreeRDP","description":"FreeRDP is a free remote desktop protocol client","fork":true,"url":"https://api.github.com/repos/akallabeth/FreeRDP","forks_url":"https://api.github.com/repos/akallabeth/FreeRDP/forks","keys_url":"https://api.github.com/repos/akallabeth/FreeRDP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akallabeth/FreeRDP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akallabeth/FreeRDP/teams","hooks_url":"https://api.github.com/repos/akallabeth/FreeRDP/hooks","issue_events_url":"https://api.github.com/repos/akallabeth/FreeRDP/issues/events{/number}","events_url":"https://api.github.com/repos/akallabeth/FreeRDP/events","assignees_url":"https://api.github.com/repos/akallabeth/FreeRDP/assignees{/user}","branches_url":"https://api.github.com/repos/akallabeth/FreeRDP/branches{/branch}","tags_url":"https://api.github.com/repos/akallabeth/FreeRDP/tags","blobs_url":"https://api.github.com/repos/akallabeth/FreeRDP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akallabeth/FreeRDP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akallabeth/FreeRDP/git/refs{/sha}","trees_url":"https://api.github.com/repos/akallabeth/FreeRDP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akallabeth/FreeRDP/statuses/{sha}","languages_url":"https://api.github.com/repos/akallabeth/FreeRDP/languages","stargazers_url":"https://api.github.com/repos/akallabeth/FreeRDP/stargazers","contributors_url":"https://api.github.com/repos/akallabeth/FreeRDP/contributors","subscribers_url":"https://api.github.com/repos/akallabeth/FreeRDP/subscribers","subscription_url":"https://api.github.com/repos/akallabeth/FreeRDP/subscription","commits_url":"https://api.github.com/repos/akallabeth/FreeRDP/commits{/sha}","git_commits_url":"https://api.github.com/repos/akallabeth/FreeRDP/git/commits{/sha}","comments_url":"https://api.github.com/repos/akallabeth/FreeRDP/comments{/number}","issue_comment_url":"https://api.github.com/repos/akallabeth/FreeRDP/issues/comments{/number}","contents_url":"https://api.github.com/repos/akallabeth/FreeRDP/contents/{+path}","compare_url":"https://api.github.com/repos/akallabeth/FreeRDP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akallabeth/FreeRDP/merges","archive_url":"https://api.github.com/repos/akallabeth/FreeRDP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akallabeth/FreeRDP/downloads","issues_url":"https://api.github.com/repos/akallabeth/FreeRDP/issues{/number}","pulls_url":"https://api.github.com/repos/akallabeth/FreeRDP/pulls{/number}","milestones_url":"https://api.github.com/repos/akallabeth/FreeRDP/milestones{/number}","notifications_url":"https://api.github.com/repos/akallabeth/FreeRDP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akallabeth/FreeRDP/labels{/name}","releases_url":"https://api.github.com/repos/akallabeth/FreeRDP/releases{/id}","deployments_url":"https://api.github.com/repos/akallabeth/FreeRDP/deployments","created_at":"2013-07-15T08:16:31Z","updated_at":"2015-01-26T06:50:05Z","pushed_at":"2016-01-27T09:34:11Z","git_url":"git://github.com/akallabeth/FreeRDP.git","ssh_url":"git@github.com:akallabeth/FreeRDP.git","clone_url":"https://github.com/akallabeth/FreeRDP.git","svn_url":"https://github.com/akallabeth/FreeRDP","homepage":"http://www.freerdp.com/","size":31844,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FreeRDP:master","ref":"master","sha":"507fba0252c5a8b3d0ee94b1bbc4506b135a327b","user":{"login":"FreeRDP","id":663376,"avatar_url":"https://avatars.githubusercontent.com/u/663376?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeRDP","html_url":"https://github.com/FreeRDP","followers_url":"https://api.github.com/users/FreeRDP/followers","following_url":"https://api.github.com/users/FreeRDP/following{/other_user}","gists_url":"https://api.github.com/users/FreeRDP/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeRDP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeRDP/subscriptions","organizations_url":"https://api.github.com/users/FreeRDP/orgs","repos_url":"https://api.github.com/users/FreeRDP/repos","events_url":"https://api.github.com/users/FreeRDP/events{/privacy}","received_events_url":"https://api.github.com/users/FreeRDP/received_events","type":"Organization","site_admin":false},"repo":{"id":1979797,"name":"FreeRDP","full_name":"FreeRDP/FreeRDP","owner":{"login":"FreeRDP","id":663376,"avatar_url":"https://avatars.githubusercontent.com/u/663376?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeRDP","html_url":"https://github.com/FreeRDP","followers_url":"https://api.github.com/users/FreeRDP/followers","following_url":"https://api.github.com/users/FreeRDP/following{/other_user}","gists_url":"https://api.github.com/users/FreeRDP/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeRDP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeRDP/subscriptions","organizations_url":"https://api.github.com/users/FreeRDP/orgs","repos_url":"https://api.github.com/users/FreeRDP/repos","events_url":"https://api.github.com/users/FreeRDP/events{/privacy}","received_events_url":"https://api.github.com/users/FreeRDP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FreeRDP/FreeRDP","description":"FreeRDP is a free remote desktop protocol client","fork":false,"url":"https://api.github.com/repos/FreeRDP/FreeRDP","forks_url":"https://api.github.com/repos/FreeRDP/FreeRDP/forks","keys_url":"https://api.github.com/repos/FreeRDP/FreeRDP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreeRDP/FreeRDP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreeRDP/FreeRDP/teams","hooks_url":"https://api.github.com/repos/FreeRDP/FreeRDP/hooks","issue_events_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/events{/number}","events_url":"https://api.github.com/repos/FreeRDP/FreeRDP/events","assignees_url":"https://api.github.com/repos/FreeRDP/FreeRDP/assignees{/user}","branches_url":"https://api.github.com/repos/FreeRDP/FreeRDP/branches{/branch}","tags_url":"https://api.github.com/repos/FreeRDP/FreeRDP/tags","blobs_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreeRDP/FreeRDP/statuses/{sha}","languages_url":"https://api.github.com/repos/FreeRDP/FreeRDP/languages","stargazers_url":"https://api.github.com/repos/FreeRDP/FreeRDP/stargazers","contributors_url":"https://api.github.com/repos/FreeRDP/FreeRDP/contributors","subscribers_url":"https://api.github.com/repos/FreeRDP/FreeRDP/subscribers","subscription_url":"https://api.github.com/repos/FreeRDP/FreeRDP/subscription","commits_url":"https://api.github.com/repos/FreeRDP/FreeRDP/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/comments{/number}","contents_url":"https://api.github.com/repos/FreeRDP/FreeRDP/contents/{+path}","compare_url":"https://api.github.com/repos/FreeRDP/FreeRDP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreeRDP/FreeRDP/merges","archive_url":"https://api.github.com/repos/FreeRDP/FreeRDP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreeRDP/FreeRDP/downloads","issues_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues{/number}","pulls_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls{/number}","milestones_url":"https://api.github.com/repos/FreeRDP/FreeRDP/milestones{/number}","notifications_url":"https://api.github.com/repos/FreeRDP/FreeRDP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreeRDP/FreeRDP/labels{/name}","releases_url":"https://api.github.com/repos/FreeRDP/FreeRDP/releases{/id}","deployments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/deployments","created_at":"2011-06-30T19:14:15Z","updated_at":"2016-01-27T08:23:33Z","pushed_at":"2016-01-27T09:50:39Z","git_url":"git://github.com/FreeRDP/FreeRDP.git","ssh_url":"git@github.com:FreeRDP/FreeRDP.git","clone_url":"https://github.com/FreeRDP/FreeRDP.git","svn_url":"https://github.com/FreeRDP/FreeRDP","homepage":"http://www.freerdp.com/","size":33395,"stargazers_count":1179,"watchers_count":1179,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":744,"mirror_url":null,"open_issues_count":647,"forks":744,"open_issues":647,"watchers":1179,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/3078"},"html":{"href":"https://github.com/FreeRDP/FreeRDP/pull/3078"},"issue":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/3078"},"comments":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/3078/comments"},"review_comments":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/3078/comments"},"review_comment":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/3078/commits"},"statuses":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/statuses/46a079fcb6e06f94dbf97e718019a301b6cfd60b"}}}}