{"action":"created","comment":{"url":"https://api.github.com/repos/contiv/volplugin/pulls/comments/74130145","id":74130145,"diff_hunk":"@@ -0,0 +1,10 @@\n+#!/bin/bash\n+docker build -t contiv/volplugin .\n+\n+# Ensure that docker is running with MountFlags=shared\n+sudo sed -i 's/MountFlags=slave/MountFlags=shared/g' /usr/lib/systemd/system/docker.service\n+sleep 1","path":"build/scripts/build-volplugin-containers.sh","position":6,"original_position":6,"commit_id":"632881bae8ac8a024516392ae451b1dc109c49a4","original_commit_id":"632881bae8ac8a024516392ae451b1dc109c49a4","user":{"login":"dseevr","id":97581,"avatar_url":"https://avatars.githubusercontent.com/u/97581?v=3","gravatar_id":"","url":"https://api.github.com/users/dseevr","html_url":"https://github.com/dseevr","followers_url":"https://api.github.com/users/dseevr/followers","following_url":"https://api.github.com/users/dseevr/following{/other_user}","gists_url":"https://api.github.com/users/dseevr/gists{/gist_id}","starred_url":"https://api.github.com/users/dseevr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dseevr/subscriptions","organizations_url":"https://api.github.com/users/dseevr/orgs","repos_url":"https://api.github.com/users/dseevr/repos","events_url":"https://api.github.com/users/dseevr/events{/privacy}","received_events_url":"https://api.github.com/users/dseevr/received_events","type":"User","site_admin":false},"body":"Is this 1 second sleep necessary?  `systemctl daemon-reload` won't run before `sed` is finished, so I don't think there's any possible race condition here...","created_at":"2016-08-09T19:40:46Z","updated_at":"2016-08-09T19:40:47Z","html_url":"https://github.com/contiv/volplugin/pull/394#discussion_r74130145","pull_request_url":"https://api.github.com/repos/contiv/volplugin/pulls/394","_links":{"self":{"href":"https://api.github.com/repos/contiv/volplugin/pulls/comments/74130145"},"html":{"href":"https://github.com/contiv/volplugin/pull/394#discussion_r74130145"},"pull_request":{"href":"https://api.github.com/repos/contiv/volplugin/pulls/394"}}},"pull_request":{"url":"https://api.github.com/repos/contiv/volplugin/pulls/394","id":80566483,"html_url":"https://github.com/contiv/volplugin/pull/394","diff_url":"https://github.com/contiv/volplugin/pull/394.diff","patch_url":"https://github.com/contiv/volplugin/pull/394.patch","issue_url":"https://api.github.com/repos/contiv/volplugin/issues/394","number":394,"state":"open","locked":false,"title":"Support for volplugin, volsupervisor, apiserver in containers.","user":{"login":"vvb","id":4341190,"avatar_url":"https://avatars.githubusercontent.com/u/4341190?v=3","gravatar_id":"","url":"https://api.github.com/users/vvb","html_url":"https://github.com/vvb","followers_url":"https://api.github.com/users/vvb/followers","following_url":"https://api.github.com/users/vvb/following{/other_user}","gists_url":"https://api.github.com/users/vvb/gists{/gist_id}","starred_url":"https://api.github.com/users/vvb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvb/subscriptions","organizations_url":"https://api.github.com/users/vvb/orgs","repos_url":"https://api.github.com/users/vvb/repos","events_url":"https://api.github.com/users/vvb/events{/privacy}","received_events_url":"https://api.github.com/users/vvb/received_events","type":"User","site_admin":false},"body":"- Making volplugin, volsupervisor, apiserver systemd services.\r\n    - volplugin.service which uses /usr/bin/volplugin.sh\r\n    - volsupervisor.service which uses /usr/bin/volsupervisor.sh\r\n    - apiserver.service which uses /usr/bin/apiserver.sh\r\n\r\n- volplugin.sh, volsupervisor.sh, apiserver.sh use\r\n        /usr/bin/contiv-vol-run.sh to start respective containers.\r\n\r\n/usr/bin/contiv-vol-run.sh has all the relevant docker run commands\r\n\r\n- Changes to make sure that the system-tests use these containers instead.\r\n- Verified that all unit-tests and system-tests are working\r\n\r\nSigned-off-by: Vikrant Balyan <vijayvikrant84@gmail.com>","created_at":"2016-08-09T06:12:42Z","updated_at":"2016-08-09T19:40:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d023101fa85f520ef08070a12a565044f22c5df","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/contiv/volplugin/pulls/394/commits","review_comments_url":"https://api.github.com/repos/contiv/volplugin/pulls/394/comments","review_comment_url":"https://api.github.com/repos/contiv/volplugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/contiv/volplugin/issues/394/comments","statuses_url":"https://api.github.com/repos/contiv/volplugin/statuses/632881bae8ac8a024516392ae451b1dc109c49a4","head":{"label":"vvb:vol_containers","ref":"vol_containers","sha":"632881bae8ac8a024516392ae451b1dc109c49a4","user":{"login":"vvb","id":4341190,"avatar_url":"https://avatars.githubusercontent.com/u/4341190?v=3","gravatar_id":"","url":"https://api.github.com/users/vvb","html_url":"https://github.com/vvb","followers_url":"https://api.github.com/users/vvb/followers","following_url":"https://api.github.com/users/vvb/following{/other_user}","gists_url":"https://api.github.com/users/vvb/gists{/gist_id}","starred_url":"https://api.github.com/users/vvb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvb/subscriptions","organizations_url":"https://api.github.com/users/vvb/orgs","repos_url":"https://api.github.com/users/vvb/repos","events_url":"https://api.github.com/users/vvb/events{/privacy}","received_events_url":"https://api.github.com/users/vvb/received_events","type":"User","site_admin":false},"repo":{"id":63432130,"name":"volplugin","full_name":"vvb/volplugin","owner":{"login":"vvb","id":4341190,"avatar_url":"https://avatars.githubusercontent.com/u/4341190?v=3","gravatar_id":"","url":"https://api.github.com/users/vvb","html_url":"https://github.com/vvb","followers_url":"https://api.github.com/users/vvb/followers","following_url":"https://api.github.com/users/vvb/following{/other_user}","gists_url":"https://api.github.com/users/vvb/gists{/gist_id}","starred_url":"https://api.github.com/users/vvb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvb/subscriptions","organizations_url":"https://api.github.com/users/vvb/orgs","repos_url":"https://api.github.com/users/vvb/repos","events_url":"https://api.github.com/users/vvb/events{/privacy}","received_events_url":"https://api.github.com/users/vvb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vvb/volplugin","description":"Contiv Storage: Policy backed Clustered Storage (via Ceph or NFS) for Docker","fork":true,"url":"https://api.github.com/repos/vvb/volplugin","forks_url":"https://api.github.com/repos/vvb/volplugin/forks","keys_url":"https://api.github.com/repos/vvb/volplugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vvb/volplugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vvb/volplugin/teams","hooks_url":"https://api.github.com/repos/vvb/volplugin/hooks","issue_events_url":"https://api.github.com/repos/vvb/volplugin/issues/events{/number}","events_url":"https://api.github.com/repos/vvb/volplugin/events","assignees_url":"https://api.github.com/repos/vvb/volplugin/assignees{/user}","branches_url":"https://api.github.com/repos/vvb/volplugin/branches{/branch}","tags_url":"https://api.github.com/repos/vvb/volplugin/tags","blobs_url":"https://api.github.com/repos/vvb/volplugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vvb/volplugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vvb/volplugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/vvb/volplugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vvb/volplugin/statuses/{sha}","languages_url":"https://api.github.com/repos/vvb/volplugin/languages","stargazers_url":"https://api.github.com/repos/vvb/volplugin/stargazers","contributors_url":"https://api.github.com/repos/vvb/volplugin/contributors","subscribers_url":"https://api.github.com/repos/vvb/volplugin/subscribers","subscription_url":"https://api.github.com/repos/vvb/volplugin/subscription","commits_url":"https://api.github.com/repos/vvb/volplugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/vvb/volplugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/vvb/volplugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/vvb/volplugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/vvb/volplugin/contents/{+path}","compare_url":"https://api.github.com/repos/vvb/volplugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vvb/volplugin/merges","archive_url":"https://api.github.com/repos/vvb/volplugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vvb/volplugin/downloads","issues_url":"https://api.github.com/repos/vvb/volplugin/issues{/number}","pulls_url":"https://api.github.com/repos/vvb/volplugin/pulls{/number}","milestones_url":"https://api.github.com/repos/vvb/volplugin/milestones{/number}","notifications_url":"https://api.github.com/repos/vvb/volplugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vvb/volplugin/labels{/name}","releases_url":"https://api.github.com/repos/vvb/volplugin/releases{/id}","deployments_url":"https://api.github.com/repos/vvb/volplugin/deployments","created_at":"2016-07-15T15:28:31Z","updated_at":"2016-07-15T15:28:33Z","pushed_at":"2016-08-09T12:38:57Z","git_url":"git://github.com/vvb/volplugin.git","ssh_url":"git@github.com:vvb/volplugin.git","clone_url":"https://github.com/vvb/volplugin.git","svn_url":"https://github.com/vvb/volplugin","homepage":"http://contiv.github.io","size":3388,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"contiv:master","ref":"master","sha":"e9e8a6f3dbdbfa0ff3c7f0e424fc8d215cb846d4","user":{"login":"contiv","id":10272443,"avatar_url":"https://avatars.githubusercontent.com/u/10272443?v=3","gravatar_id":"","url":"https://api.github.com/users/contiv","html_url":"https://github.com/contiv","followers_url":"https://api.github.com/users/contiv/followers","following_url":"https://api.github.com/users/contiv/following{/other_user}","gists_url":"https://api.github.com/users/contiv/gists{/gist_id}","starred_url":"https://api.github.com/users/contiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiv/subscriptions","organizations_url":"https://api.github.com/users/contiv/orgs","repos_url":"https://api.github.com/users/contiv/repos","events_url":"https://api.github.com/users/contiv/events{/privacy}","received_events_url":"https://api.github.com/users/contiv/received_events","type":"Organization","site_admin":false},"repo":{"id":38460040,"name":"volplugin","full_name":"contiv/volplugin","owner":{"login":"contiv","id":10272443,"avatar_url":"https://avatars.githubusercontent.com/u/10272443?v=3","gravatar_id":"","url":"https://api.github.com/users/contiv","html_url":"https://github.com/contiv","followers_url":"https://api.github.com/users/contiv/followers","following_url":"https://api.github.com/users/contiv/following{/other_user}","gists_url":"https://api.github.com/users/contiv/gists{/gist_id}","starred_url":"https://api.github.com/users/contiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiv/subscriptions","organizations_url":"https://api.github.com/users/contiv/orgs","repos_url":"https://api.github.com/users/contiv/repos","events_url":"https://api.github.com/users/contiv/events{/privacy}","received_events_url":"https://api.github.com/users/contiv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/contiv/volplugin","description":"Contiv Storage: Policy backed Clustered Storage (via Ceph or NFS) for Docker","fork":false,"url":"https://api.github.com/repos/contiv/volplugin","forks_url":"https://api.github.com/repos/contiv/volplugin/forks","keys_url":"https://api.github.com/repos/contiv/volplugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contiv/volplugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contiv/volplugin/teams","hooks_url":"https://api.github.com/repos/contiv/volplugin/hooks","issue_events_url":"https://api.github.com/repos/contiv/volplugin/issues/events{/number}","events_url":"https://api.github.com/repos/contiv/volplugin/events","assignees_url":"https://api.github.com/repos/contiv/volplugin/assignees{/user}","branches_url":"https://api.github.com/repos/contiv/volplugin/branches{/branch}","tags_url":"https://api.github.com/repos/contiv/volplugin/tags","blobs_url":"https://api.github.com/repos/contiv/volplugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contiv/volplugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contiv/volplugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/contiv/volplugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contiv/volplugin/statuses/{sha}","languages_url":"https://api.github.com/repos/contiv/volplugin/languages","stargazers_url":"https://api.github.com/repos/contiv/volplugin/stargazers","contributors_url":"https://api.github.com/repos/contiv/volplugin/contributors","subscribers_url":"https://api.github.com/repos/contiv/volplugin/subscribers","subscription_url":"https://api.github.com/repos/contiv/volplugin/subscription","commits_url":"https://api.github.com/repos/contiv/volplugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/contiv/volplugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/contiv/volplugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/contiv/volplugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/contiv/volplugin/contents/{+path}","compare_url":"https://api.github.com/repos/contiv/volplugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contiv/volplugin/merges","archive_url":"https://api.github.com/repos/contiv/volplugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contiv/volplugin/downloads","issues_url":"https://api.github.com/repos/contiv/volplugin/issues{/number}","pulls_url":"https://api.github.com/repos/contiv/volplugin/pulls{/number}","milestones_url":"https://api.github.com/repos/contiv/volplugin/milestones{/number}","notifications_url":"https://api.github.com/repos/contiv/volplugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contiv/volplugin/labels{/name}","releases_url":"https://api.github.com/repos/contiv/volplugin/releases{/id}","deployments_url":"https://api.github.com/repos/contiv/volplugin/deployments","created_at":"2015-07-02T22:31:53Z","updated_at":"2016-08-06T00:23:47Z","pushed_at":"2016-08-09T19:28:57Z","git_url":"git://github.com/contiv/volplugin.git","ssh_url":"git@github.com:contiv/volplugin.git","clone_url":"https://github.com/contiv/volplugin.git","svn_url":"https://github.com/contiv/volplugin","homepage":"http://contiv.github.io","size":3400,"stargazers_count":133,"watchers_count":133,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":34,"forks":24,"open_issues":34,"watchers":133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/contiv/volplugin/pulls/394"},"html":{"href":"https://github.com/contiv/volplugin/pull/394"},"issue":{"href":"https://api.github.com/repos/contiv/volplugin/issues/394"},"comments":{"href":"https://api.github.com/repos/contiv/volplugin/issues/394/comments"},"review_comments":{"href":"https://api.github.com/repos/contiv/volplugin/pulls/394/comments"},"review_comment":{"href":"https://api.github.com/repos/contiv/volplugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/contiv/volplugin/pulls/394/commits"},"statuses":{"href":"https://api.github.com/repos/contiv/volplugin/statuses/632881bae8ac8a024516392ae451b1dc109c49a4"}}}}
{"actor":{"display_login":"dseevr"}}