{"action":"created","comment":{"url":"https://api.github.com/repos/playframework/playframework/pulls/comments/93801641","pull_request_review_id":14338680,"id":93801641,"diff_hunk":"@@ -22,23 +22,23 @@ class AssetsDateParsingSpec extends Specification {\n       }\n     }\n \n-    \"parse date from RFC2616\" in {\n+    \"parse date from RFC2616\" in withApplication {","path":"framework/src/play/src/test/scala/play/api/controllers/AssetsDateParsingSpec.scala","position":15,"original_position":15,"commit_id":"d73492904ca930dac1f95dd78332047fb03b25c5","original_commit_id":"0a9f0e809f24b2a67f89e349ba107dec4cfa11fa","user":{"login":"marcospereira","id":4576,"avatar_url":"https://avatars.githubusercontent.com/u/4576?v=3","gravatar_id":"","url":"https://api.github.com/users/marcospereira","html_url":"https://github.com/marcospereira","followers_url":"https://api.github.com/users/marcospereira/followers","following_url":"https://api.github.com/users/marcospereira/following{/other_user}","gists_url":"https://api.github.com/users/marcospereira/gists{/gist_id}","starred_url":"https://api.github.com/users/marcospereira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcospereira/subscriptions","organizations_url":"https://api.github.com/users/marcospereira/orgs","repos_url":"https://api.github.com/users/marcospereira/repos","events_url":"https://api.github.com/users/marcospereira/events{/privacy}","received_events_url":"https://api.github.com/users/marcospereira/received_events","type":"User","site_admin":false},"body":"By the way, +1 to avoid the use of `withApplication` as much as we can.\r\n\r\nBut, at this case, I don't see how to achieve that without removing the global state of Assets first.","created_at":"2016-12-23T20:59:07Z","updated_at":"2016-12-23T20:59:07Z","html_url":"https://github.com/playframework/playframework/pull/6816#discussion_r93801641","pull_request_url":"https://api.github.com/repos/playframework/playframework/pulls/6816","_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments/93801641"},"html":{"href":"https://github.com/playframework/playframework/pull/6816#discussion_r93801641"},"pull_request":{"href":"https://api.github.com/repos/playframework/playframework/pulls/6816"}}},"pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/6816","id":98761437,"html_url":"https://github.com/playframework/playframework/pull/6816","diff_url":"https://github.com/playframework/playframework/pull/6816.diff","patch_url":"https://github.com/playframework/playframework/pull/6816.patch","issue_url":"https://api.github.com/repos/playframework/playframework/issues/6816","number":6816,"state":"open","locked":false,"title":"Remove Crypto.cookieSigner from Flash and Session","user":{"login":"marcospereira","id":4576,"avatar_url":"https://avatars.githubusercontent.com/u/4576?v=3","gravatar_id":"","url":"https://api.github.com/users/marcospereira","html_url":"https://github.com/marcospereira","followers_url":"https://api.github.com/users/marcospereira/followers","following_url":"https://api.github.com/users/marcospereira/following{/other_user}","gists_url":"https://api.github.com/users/marcospereira/gists{/gist_id}","starred_url":"https://api.github.com/users/marcospereira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcospereira/subscriptions","organizations_url":"https://api.github.com/users/marcospereira/orgs","repos_url":"https://api.github.com/users/marcospereira/repos","events_url":"https://api.github.com/users/marcospereira/events{/privacy}","received_events_url":"https://api.github.com/users/marcospereira/received_events","type":"User","site_admin":false},"body":"## Status\r\n\r\nReady to review and merge.\r\n\r\n* [X] Have you squashed your commits?\r\n* [X] Have you updated the documentation for both Scala and Java sections?\r\n* [X] Review tests related to parsing secret configuration\r\n* [X] Update migration guide to document new/deprecated configurations\r\n\r\n## Purpose\r\n\r\nThis removes last `Crypto` related classes in favor of `HttpConfiguration.secret`. The main point is to remove `Crypto.cookieSigner` usages because of global state.","created_at":"2016-12-20T14:46:41Z","updated_at":"2016-12-23T20:59:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8aa9a9e3b6d12b6a809ae3159446923ad53983bc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/playframework/playframework/pulls/6816/commits","review_comments_url":"https://api.github.com/repos/playframework/playframework/pulls/6816/comments","review_comment_url":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/6816/comments","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/d73492904ca930dac1f95dd78332047fb03b25c5","head":{"label":"marcospereira:remove-crypto-from-flash","ref":"remove-crypto-from-flash","sha":"d73492904ca930dac1f95dd78332047fb03b25c5","user":{"login":"marcospereira","id":4576,"avatar_url":"https://avatars.githubusercontent.com/u/4576?v=3","gravatar_id":"","url":"https://api.github.com/users/marcospereira","html_url":"https://github.com/marcospereira","followers_url":"https://api.github.com/users/marcospereira/followers","following_url":"https://api.github.com/users/marcospereira/following{/other_user}","gists_url":"https://api.github.com/users/marcospereira/gists{/gist_id}","starred_url":"https://api.github.com/users/marcospereira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcospereira/subscriptions","organizations_url":"https://api.github.com/users/marcospereira/orgs","repos_url":"https://api.github.com/users/marcospereira/repos","events_url":"https://api.github.com/users/marcospereira/events{/privacy}","received_events_url":"https://api.github.com/users/marcospereira/received_events","type":"User","site_admin":false},"repo":{"id":34361186,"name":"playframework","full_name":"marcospereira/playframework","owner":{"login":"marcospereira","id":4576,"avatar_url":"https://avatars.githubusercontent.com/u/4576?v=3","gravatar_id":"","url":"https://api.github.com/users/marcospereira","html_url":"https://github.com/marcospereira","followers_url":"https://api.github.com/users/marcospereira/followers","following_url":"https://api.github.com/users/marcospereira/following{/other_user}","gists_url":"https://api.github.com/users/marcospereira/gists{/gist_id}","starred_url":"https://api.github.com/users/marcospereira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcospereira/subscriptions","organizations_url":"https://api.github.com/users/marcospereira/orgs","repos_url":"https://api.github.com/users/marcospereira/repos","events_url":"https://api.github.com/users/marcospereira/events{/privacy}","received_events_url":"https://api.github.com/users/marcospereira/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marcospereira/playframework","description":"Play Framework","fork":true,"url":"https://api.github.com/repos/marcospereira/playframework","forks_url":"https://api.github.com/repos/marcospereira/playframework/forks","keys_url":"https://api.github.com/repos/marcospereira/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcospereira/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcospereira/playframework/teams","hooks_url":"https://api.github.com/repos/marcospereira/playframework/hooks","issue_events_url":"https://api.github.com/repos/marcospereira/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/marcospereira/playframework/events","assignees_url":"https://api.github.com/repos/marcospereira/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/marcospereira/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/marcospereira/playframework/tags","blobs_url":"https://api.github.com/repos/marcospereira/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcospereira/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcospereira/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcospereira/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcospereira/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/marcospereira/playframework/languages","stargazers_url":"https://api.github.com/repos/marcospereira/playframework/stargazers","contributors_url":"https://api.github.com/repos/marcospereira/playframework/contributors","subscribers_url":"https://api.github.com/repos/marcospereira/playframework/subscribers","subscription_url":"https://api.github.com/repos/marcospereira/playframework/subscription","commits_url":"https://api.github.com/repos/marcospereira/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcospereira/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcospereira/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcospereira/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcospereira/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/marcospereira/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcospereira/playframework/merges","archive_url":"https://api.github.com/repos/marcospereira/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcospereira/playframework/downloads","issues_url":"https://api.github.com/repos/marcospereira/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/marcospereira/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/marcospereira/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/marcospereira/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcospereira/playframework/labels{/name}","releases_url":"https://api.github.com/repos/marcospereira/playframework/releases{/id}","deployments_url":"https://api.github.com/repos/marcospereira/playframework/deployments","created_at":"2015-04-22T01:20:04Z","updated_at":"2016-12-11T04:08:41Z","pushed_at":"2016-12-23T20:29:14Z","git_url":"git://github.com/marcospereira/playframework.git","ssh_url":"git@github.com:marcospereira/playframework.git","clone_url":"https://github.com/marcospereira/playframework.git","svn_url":"https://github.com/marcospereira/playframework","homepage":"http://www.playframework.com/","size":83985,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"playframework:master","ref":"master","sha":"e3017efe41cfbfadbbf732a47ccf397ab0a5d83f","user":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"repo":{"id":2340549,"name":"playframework","full_name":"playframework/playframework","owner":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/playframework/playframework","description":"Play Framework","fork":false,"url":"https://api.github.com/repos/playframework/playframework","forks_url":"https://api.github.com/repos/playframework/playframework/forks","keys_url":"https://api.github.com/repos/playframework/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/playframework/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/playframework/playframework/teams","hooks_url":"https://api.github.com/repos/playframework/playframework/hooks","issue_events_url":"https://api.github.com/repos/playframework/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/playframework/playframework/events","assignees_url":"https://api.github.com/repos/playframework/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/playframework/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/playframework/playframework/tags","blobs_url":"https://api.github.com/repos/playframework/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/playframework/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/playframework/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/playframework/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/playframework/playframework/languages","stargazers_url":"https://api.github.com/repos/playframework/playframework/stargazers","contributors_url":"https://api.github.com/repos/playframework/playframework/contributors","subscribers_url":"https://api.github.com/repos/playframework/playframework/subscribers","subscription_url":"https://api.github.com/repos/playframework/playframework/subscription","commits_url":"https://api.github.com/repos/playframework/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/playframework/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/playframework/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/playframework/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/playframework/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/playframework/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/playframework/playframework/merges","archive_url":"https://api.github.com/repos/playframework/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/playframework/playframework/downloads","issues_url":"https://api.github.com/repos/playframework/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/playframework/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/playframework/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/playframework/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/playframework/playframework/labels{/name}","releases_url":"https://api.github.com/repos/playframework/playframework/releases{/id}","deployments_url":"https://api.github.com/repos/playframework/playframework/deployments","created_at":"2011-09-07T09:24:08Z","updated_at":"2016-12-23T19:35:16Z","pushed_at":"2016-12-23T20:33:04Z","git_url":"git://github.com/playframework/playframework.git","ssh_url":"git@github.com:playframework/playframework.git","clone_url":"https://github.com/playframework/playframework.git","svn_url":"https://github.com/playframework/playframework","homepage":"http://www.playframework.com/","size":84861,"stargazers_count":8748,"watchers_count":8748,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3033,"mirror_url":null,"open_issues_count":268,"forks":3033,"open_issues":268,"watchers":8748,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/6816"},"html":{"href":"https://github.com/playframework/playframework/pull/6816"},"issue":{"href":"https://api.github.com/repos/playframework/playframework/issues/6816"},"comments":{"href":"https://api.github.com/repos/playframework/playframework/issues/6816/comments"},"review_comments":{"href":"https://api.github.com/repos/playframework/playframework/pulls/6816/comments"},"review_comment":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/playframework/playframework/pulls/6816/commits"},"statuses":{"href":"https://api.github.com/repos/playframework/playframework/statuses/d73492904ca930dac1f95dd78332047fb03b25c5"}}}}
{"actor":{"display_login":"marcospereira"}}