{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/pulls/comments/85442383","pull_request_review_id":6159072,"id":85442383,"diff_hunk":"@@ -0,0 +1,291 @@\n+﻿namespace Microsoft.ApplicationInsights.Extensibility.PerfCounterCollector.Implementation\n+{\n+    using System;\n+    using System.Collections.Generic;\n+    using System.Diagnostics;\n+    using System.Globalization;\n+    using System.Linq;\n+    using DataContracts;\n+    using System.Text.RegularExpressions;\n+\n+    internal class WebAppPerformanceCollector : IPerformanceCollector\n+    {\n+        private readonly List<PerformanceCounterData> performanceCounters = new List<PerformanceCounterData>();\n+\n+        private static readonly Regex DisallowedCharsInReportAsRegex = new Regex(","path":"Src/PerformanceCollector/Shared/Implementation/WebAppPerformanceCollector/WebAppPerformanceCollector.cs","position":15,"original_position":15,"commit_id":"f6c5d3ddb8553edd21be9ea30721cd27a90abcf7","original_commit_id":"f6c5d3ddb8553edd21be9ea30721cd27a90abcf7","user":{"login":"SergeyKanzhelev","id":9950081,"avatar_url":"https://avatars.githubusercontent.com/u/9950081?v=3","gravatar_id":"","url":"https://api.github.com/users/SergeyKanzhelev","html_url":"https://github.com/SergeyKanzhelev","followers_url":"https://api.github.com/users/SergeyKanzhelev/followers","following_url":"https://api.github.com/users/SergeyKanzhelev/following{/other_user}","gists_url":"https://api.github.com/users/SergeyKanzhelev/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeyKanzhelev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeyKanzhelev/subscriptions","organizations_url":"https://api.github.com/users/SergeyKanzhelev/orgs","repos_url":"https://api.github.com/users/SergeyKanzhelev/repos","events_url":"https://api.github.com/users/SergeyKanzhelev/events{/privacy}","received_events_url":"https://api.github.com/users/SergeyKanzhelev/received_events","type":"User","site_admin":false},"body":"share this logic with the performance counters collector","created_at":"2016-10-27T22:39:35Z","updated_at":"2016-10-27T22:40:41Z","html_url":"https://github.com/Microsoft/ApplicationInsights-dotnet-server/pull/190#discussion_r85442383","pull_request_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/pulls/190","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/pulls/comments/85442383"},"html":{"href":"https://github.com/Microsoft/ApplicationInsights-dotnet-server/pull/190#discussion_r85442383"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/pulls/190"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/pulls/190","id":91274965,"html_url":"https://github.com/Microsoft/ApplicationInsights-dotnet-server/pull/190","diff_url":"https://github.com/Microsoft/ApplicationInsights-dotnet-server/pull/190.diff","patch_url":"https://github.com/Microsoft/ApplicationInsights-dotnet-server/pull/190.patch","issue_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/issues/190","number":190,"state":"open","locked":false,"title":"Enabling Performance Counter Collection for Web Apps","user":{"login":"kartang","id":12818796,"avatar_url":"https://avatars.githubusercontent.com/u/12818796?v=3","gravatar_id":"","url":"https://api.github.com/users/kartang","html_url":"https://github.com/kartang","followers_url":"https://api.github.com/users/kartang/followers","following_url":"https://api.github.com/users/kartang/following{/other_user}","gists_url":"https://api.github.com/users/kartang/gists{/gist_id}","starred_url":"https://api.github.com/users/kartang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kartang/subscriptions","organizations_url":"https://api.github.com/users/kartang/orgs","repos_url":"https://api.github.com/users/kartang/repos","events_url":"https://api.github.com/users/kartang/events{/privacy}","received_events_url":"https://api.github.com/users/kartang/received_events","type":"User","site_admin":false},"body":"First iteration to add web app performance counter collection to dotnet server","created_at":"2016-10-27T20:31:29Z","updated_at":"2016-10-27T22:40:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11a0b0bfed3689336259688a4c4bff53db03e2df","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/pulls/190/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/pulls/190/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/issues/190/comments","statuses_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/statuses/f6c5d3ddb8553edd21be9ea30721cd27a90abcf7","head":{"label":"Microsoft:kartang/perf-webapp-migration2","ref":"kartang/perf-webapp-migration2","sha":"f6c5d3ddb8553edd21be9ea30721cd27a90abcf7","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":44223665,"name":"ApplicationInsights-dotnet-server","full_name":"Microsoft/ApplicationInsights-dotnet-server","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ApplicationInsights-dotnet-server","description":"Microsoft Application Insights for .NET Web Applications","fork":false,"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server","forks_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/forks","keys_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/teams","hooks_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/events","assignees_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/tags","blobs_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/subscription","commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/merges","archive_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/downloads","issues_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/deployments","created_at":"2015-10-14T04:20:22Z","updated_at":"2016-10-23T23:57:51Z","pushed_at":"2016-10-27T21:33:50Z","git_url":"git://github.com/Microsoft/ApplicationInsights-dotnet-server.git","ssh_url":"git@github.com:Microsoft/ApplicationInsights-dotnet-server.git","clone_url":"https://github.com/Microsoft/ApplicationInsights-dotnet-server.git","svn_url":"https://github.com/Microsoft/ApplicationInsights-dotnet-server","homepage":"https://azure.microsoft.com/en-us/services/application-insights/","size":4266,"stargazers_count":24,"watchers_count":24,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":33,"forks":16,"open_issues":33,"watchers":24,"default_branch":"master"}},"base":{"label":"Microsoft:kartang/perf-webapp-migration","ref":"kartang/perf-webapp-migration","sha":"b3afe708aab0744dcb08fdafd4251a1295187e1d","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":44223665,"name":"ApplicationInsights-dotnet-server","full_name":"Microsoft/ApplicationInsights-dotnet-server","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ApplicationInsights-dotnet-server","description":"Microsoft Application Insights for .NET Web Applications","fork":false,"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server","forks_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/forks","keys_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/teams","hooks_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/events","assignees_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/tags","blobs_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/subscription","commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/merges","archive_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/downloads","issues_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/deployments","created_at":"2015-10-14T04:20:22Z","updated_at":"2016-10-23T23:57:51Z","pushed_at":"2016-10-27T21:33:50Z","git_url":"git://github.com/Microsoft/ApplicationInsights-dotnet-server.git","ssh_url":"git@github.com:Microsoft/ApplicationInsights-dotnet-server.git","clone_url":"https://github.com/Microsoft/ApplicationInsights-dotnet-server.git","svn_url":"https://github.com/Microsoft/ApplicationInsights-dotnet-server","homepage":"https://azure.microsoft.com/en-us/services/application-insights/","size":4266,"stargazers_count":24,"watchers_count":24,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":33,"forks":16,"open_issues":33,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/pulls/190"},"html":{"href":"https://github.com/Microsoft/ApplicationInsights-dotnet-server/pull/190"},"issue":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/issues/190"},"comments":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/issues/190/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/pulls/190/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/pulls/190/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/statuses/f6c5d3ddb8553edd21be9ea30721cd27a90abcf7"}}}}
{"actor":{"display_login":"SergeyKanzhelev"}}