{"action":"created","comment":{"url":"https://api.github.com/repos/zalando-incubator/senza-base-template/pulls/comments/78926926","id":78926926,"diff_hunk":"@@ -19,7 +20,8 @@\n POSTGRES_PORT = 5432\n HEALTHCHECK_PORT = 8008\n SPILO_IMAGE_ADDRESS = \"registry.opensource.zalan.do/acid/spilo-9.5\"\n-ODD_SG_NAME = 'Odd (SSH Bastion Host)'\n+ODD_SG_GROUP_NAME_REGEX = 'Odd.*'","path":"acid/senza/templates/base.py","position":13,"original_position":13,"commit_id":"b3bc9c85f5b3ce46e2d3fe3f9caf31f96c9af1bf","original_commit_id":"b3bc9c85f5b3ce46e2d3fe3f9caf31f96c9af1bf","user":{"login":"avaczi","id":5435660,"avatar_url":"https://avatars.githubusercontent.com/u/5435660?v=3","gravatar_id":"","url":"https://api.github.com/users/avaczi","html_url":"https://github.com/avaczi","followers_url":"https://api.github.com/users/avaczi/followers","following_url":"https://api.github.com/users/avaczi/following{/other_user}","gists_url":"https://api.github.com/users/avaczi/gists{/gist_id}","starred_url":"https://api.github.com/users/avaczi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avaczi/subscriptions","organizations_url":"https://api.github.com/users/avaczi/orgs","repos_url":"https://api.github.com/users/avaczi/repos","events_url":"https://api.github.com/users/avaczi/events{/privacy}","received_events_url":"https://api.github.com/users/avaczi/received_events","type":"User","site_admin":false},"body":"and then let's hope someone doesn't have the brilliant idea of naming an instance like this ;)","created_at":"2016-09-15T09:52:55Z","updated_at":"2016-09-15T09:55:31Z","html_url":"https://github.com/zalando-incubator/senza-base-template/pull/14#discussion_r78926926","pull_request_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/zalando-incubator/senza-base-template/pulls/comments/78926926"},"html":{"href":"https://github.com/zalando-incubator/senza-base-template/pull/14#discussion_r78926926"},"pull_request":{"href":"https://api.github.com/repos/zalando-incubator/senza-base-template/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/zalando-incubator/senza-base-template/pulls/14","id":85363415,"html_url":"https://github.com/zalando-incubator/senza-base-template/pull/14","diff_url":"https://github.com/zalando-incubator/senza-base-template/pull/14.diff","patch_url":"https://github.com/zalando-incubator/senza-base-template/pull/14.patch","issue_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/issues/14","number":14,"state":"open","locked":false,"title":"Detect security groups based on regex","user":{"login":"feikesteenbergen","id":8860819,"avatar_url":"https://avatars.githubusercontent.com/u/8860819?v=3","gravatar_id":"","url":"https://api.github.com/users/feikesteenbergen","html_url":"https://github.com/feikesteenbergen","followers_url":"https://api.github.com/users/feikesteenbergen/followers","following_url":"https://api.github.com/users/feikesteenbergen/following{/other_user}","gists_url":"https://api.github.com/users/feikesteenbergen/gists{/gist_id}","starred_url":"https://api.github.com/users/feikesteenbergen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feikesteenbergen/subscriptions","organizations_url":"https://api.github.com/users/feikesteenbergen/orgs","repos_url":"https://api.github.com/users/feikesteenbergen/repos","events_url":"https://api.github.com/users/feikesteenbergen/events{/privacy}","received_events_url":"https://api.github.com/users/feikesteenbergen/received_events","type":"User","site_admin":false},"body":"Recently, Odd changed it's security group, and also the Group Name of its security group.\r\nWe cannot now rely on fixed values anymore, therefore we use a regex to find the group.\r\n\r\nIt fixes the current behaviour, however it is probably not the optimal solution","created_at":"2016-09-15T08:30:05Z","updated_at":"2016-09-15T09:55:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b553b487f28b21a4f8d652a74d77f8132d352b2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/pulls/14/commits","review_comments_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/pulls/14/comments","review_comment_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/issues/14/comments","statuses_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/statuses/b3bc9c85f5b3ce46e2d3fe3f9caf31f96c9af1bf","head":{"label":"zalando-incubator:bugfix/determine_correct_odd_sg","ref":"bugfix/determine_correct_odd_sg","sha":"b3bc9c85f5b3ce46e2d3fe3f9caf31f96c9af1bf","user":{"login":"zalando-incubator","id":18533786,"avatar_url":"https://avatars.githubusercontent.com/u/18533786?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando-incubator","html_url":"https://github.com/zalando-incubator","followers_url":"https://api.github.com/users/zalando-incubator/followers","following_url":"https://api.github.com/users/zalando-incubator/following{/other_user}","gists_url":"https://api.github.com/users/zalando-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-incubator/subscriptions","organizations_url":"https://api.github.com/users/zalando-incubator/orgs","repos_url":"https://api.github.com/users/zalando-incubator/repos","events_url":"https://api.github.com/users/zalando-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":59003829,"name":"senza-base-template","full_name":"zalando-incubator/senza-base-template","owner":{"login":"zalando-incubator","id":18533786,"avatar_url":"https://avatars.githubusercontent.com/u/18533786?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando-incubator","html_url":"https://github.com/zalando-incubator","followers_url":"https://api.github.com/users/zalando-incubator/followers","following_url":"https://api.github.com/users/zalando-incubator/following{/other_user}","gists_url":"https://api.github.com/users/zalando-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-incubator/subscriptions","organizations_url":"https://api.github.com/users/zalando-incubator/orgs","repos_url":"https://api.github.com/users/zalando-incubator/repos","events_url":"https://api.github.com/users/zalando-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando-incubator/senza-base-template","description":"A senza template for automatic deployment of the PostgreSQL instances on AWS","fork":false,"url":"https://api.github.com/repos/zalando-incubator/senza-base-template","forks_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/forks","keys_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/teams","hooks_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/hooks","issue_events_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/issues/events{/number}","events_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/events","assignees_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/assignees{/user}","branches_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/branches{/branch}","tags_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/tags","blobs_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/languages","stargazers_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/stargazers","contributors_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/contributors","subscribers_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/subscribers","subscription_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/subscription","commits_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/contents/{+path}","compare_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/merges","archive_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/downloads","issues_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/issues{/number}","pulls_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/labels{/name}","releases_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/releases{/id}","deployments_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/deployments","created_at":"2016-05-17T08:21:32Z","updated_at":"2016-05-19T12:36:49Z","pushed_at":"2016-09-15T08:30:05Z","git_url":"git://github.com/zalando-incubator/senza-base-template.git","ssh_url":"git@github.com:zalando-incubator/senza-base-template.git","clone_url":"https://github.com/zalando-incubator/senza-base-template.git","svn_url":"https://github.com/zalando-incubator/senza-base-template","homepage":null,"size":28,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"zalando-incubator:master","ref":"master","sha":"2918e6363e41fc7736bf492ea3cb3895e17cfaa4","user":{"login":"zalando-incubator","id":18533786,"avatar_url":"https://avatars.githubusercontent.com/u/18533786?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando-incubator","html_url":"https://github.com/zalando-incubator","followers_url":"https://api.github.com/users/zalando-incubator/followers","following_url":"https://api.github.com/users/zalando-incubator/following{/other_user}","gists_url":"https://api.github.com/users/zalando-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-incubator/subscriptions","organizations_url":"https://api.github.com/users/zalando-incubator/orgs","repos_url":"https://api.github.com/users/zalando-incubator/repos","events_url":"https://api.github.com/users/zalando-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":59003829,"name":"senza-base-template","full_name":"zalando-incubator/senza-base-template","owner":{"login":"zalando-incubator","id":18533786,"avatar_url":"https://avatars.githubusercontent.com/u/18533786?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando-incubator","html_url":"https://github.com/zalando-incubator","followers_url":"https://api.github.com/users/zalando-incubator/followers","following_url":"https://api.github.com/users/zalando-incubator/following{/other_user}","gists_url":"https://api.github.com/users/zalando-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-incubator/subscriptions","organizations_url":"https://api.github.com/users/zalando-incubator/orgs","repos_url":"https://api.github.com/users/zalando-incubator/repos","events_url":"https://api.github.com/users/zalando-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando-incubator/senza-base-template","description":"A senza template for automatic deployment of the PostgreSQL instances on AWS","fork":false,"url":"https://api.github.com/repos/zalando-incubator/senza-base-template","forks_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/forks","keys_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/teams","hooks_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/hooks","issue_events_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/issues/events{/number}","events_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/events","assignees_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/assignees{/user}","branches_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/branches{/branch}","tags_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/tags","blobs_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/languages","stargazers_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/stargazers","contributors_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/contributors","subscribers_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/subscribers","subscription_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/subscription","commits_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/contents/{+path}","compare_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/merges","archive_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/downloads","issues_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/issues{/number}","pulls_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/labels{/name}","releases_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/releases{/id}","deployments_url":"https://api.github.com/repos/zalando-incubator/senza-base-template/deployments","created_at":"2016-05-17T08:21:32Z","updated_at":"2016-05-19T12:36:49Z","pushed_at":"2016-09-15T08:30:05Z","git_url":"git://github.com/zalando-incubator/senza-base-template.git","ssh_url":"git@github.com:zalando-incubator/senza-base-template.git","clone_url":"https://github.com/zalando-incubator/senza-base-template.git","svn_url":"https://github.com/zalando-incubator/senza-base-template","homepage":null,"size":28,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zalando-incubator/senza-base-template/pulls/14"},"html":{"href":"https://github.com/zalando-incubator/senza-base-template/pull/14"},"issue":{"href":"https://api.github.com/repos/zalando-incubator/senza-base-template/issues/14"},"comments":{"href":"https://api.github.com/repos/zalando-incubator/senza-base-template/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/zalando-incubator/senza-base-template/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/zalando-incubator/senza-base-template/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zalando-incubator/senza-base-template/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/zalando-incubator/senza-base-template/statuses/b3bc9c85f5b3ce46e2d3fe3f9caf31f96c9af1bf"}}}}
{"actor":{"display_login":"avaczi"}}