{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/56724547","id":56724547,"diff_hunk":"@@ -11,8 +11,7 @@ class ApplicationController < ActionController::Base\n   include Vmdb::Logging\n \n   if Vmdb::Application.config.action_controller.allow_forgery_protection\n-    db = MiqDatabase.connected? ? MiqDatabase.first : nil\n-    protect_from_forgery :secret => db ? db.csrf_secret_token : SecureRandom.hex(64), :except => :csp_report, :with => :exception\n+    protect_from_forgery :secret => SecureRandom.hex(64), :except => :csp_report, :with => :exception","path":"app/controllers/application_controller.rb","position":6,"original_position":6,"commit_id":"5e488ecccfab4446f4a52ee538c91a080391c9a3","original_commit_id":"5e488ecccfab4446f4a52ee538c91a080391c9a3","user":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"body":"Let's enable the magical before_action, `verify_authenticity_token`, but provide a random secret token.\r\n\r\nWe'll reset the secret in the Rails::Server proceses via `MiqUiWorker.preload_for_worker_role`.  ","created_at":"2016-03-18T21:25:43Z","updated_at":"2016-03-18T21:25:43Z","html_url":"https://github.com/ManageIQ/manageiq/pull/7403#discussion_r56724547","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7403","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/56724547"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/7403#discussion_r56724547"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7403"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7403","id":63427551,"html_url":"https://github.com/ManageIQ/manageiq/pull/7403","diff_url":"https://github.com/ManageIQ/manageiq/pull/7403.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/7403.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7403","number":7403,"state":"open","locked":false,"title":"Lazily set csrf secret token","user":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"body":"**Seed MiqDatabase before preloading for the UI worker**\r\n\r\nMiqUiWorker.preload_for_worker_role will end up calling\r\nMiqDatabase.first.csrf_secret_token, so we need to seed first.\r\n\r\n\r\n**Lazily set the CSRF secret token in the Rails Server processes**\r\n\r\nWhy? Because rake tasks can load Rails and ApplicationController and we don't\r\nneed the CSRF secret token there.  Even worse, the existing code could end up\r\ntrying to look for the token in MiqDatabase.first.csrf_secret_token.\r\n\r\nNote: ApiController should skip verify_authenticity_token if it responds to this before_action.\r\n\r\nNote: config.action_controller.allow_forgery_protection=true in production enables the forgery protection but we need to call protect_from_forgery within the controller(s) we want to use this protection.\r\n\r\nTherefore, we call protect_from_forgery in ApplicationController with a random secret token by default.\r\n\r\nWe can then reset the secret token in Rails::Server based processes such as dev mode rails server and the forked UI Worker / Web Service Worker.\r\n\r\n[bin/rails server](https://github.com/ManageIQ/manageiq/blob/38ddfd08ff1aab6d32bb3281c1ddc185b65f8fcd/lib/vmdb/initializer.rb#L15)\r\n[UI/WS worker](https://github.com/ManageIQ/manageiq/blob/40f797a0d4d07496905f6c45e120ad0218037e05/app/models/mixins/miq_web_server_runner_mixin.rb#L29)\r\n\r\nBoth end up calling [configure_secret_token](https://github.com/ManageIQ/manageiq/blob/40f797a0d4d07496905f6c45e120ad0218037e05/app/models/mixins/miq_web_server_worker_mixin.rb#L25-L34)\r\nto set the secret_token.\r\n\r\nI hope this works. It worked locally.  :pray:\r\n\r\n","created_at":"2016-03-18T19:51:33Z","updated_at":"2016-03-18T21:25:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"820c5a4461cdfd15d455651e7993862240b1d307","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7403/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7403/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7403/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/5e488ecccfab4446f4a52ee538c91a080391c9a3","head":{"label":"jrafanie:lazily_set_csrf_secret_token","ref":"lazily_set_csrf_secret_token","sha":"5e488ecccfab4446f4a52ee538c91a080391c9a3","user":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"repo":{"id":20803842,"name":"manageiq","full_name":"jrafanie/manageiq","owner":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrafanie/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/jrafanie/manageiq","forks_url":"https://api.github.com/repos/jrafanie/manageiq/forks","keys_url":"https://api.github.com/repos/jrafanie/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrafanie/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrafanie/manageiq/teams","hooks_url":"https://api.github.com/repos/jrafanie/manageiq/hooks","issue_events_url":"https://api.github.com/repos/jrafanie/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/jrafanie/manageiq/events","assignees_url":"https://api.github.com/repos/jrafanie/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/jrafanie/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/jrafanie/manageiq/tags","blobs_url":"https://api.github.com/repos/jrafanie/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrafanie/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrafanie/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrafanie/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrafanie/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/jrafanie/manageiq/languages","stargazers_url":"https://api.github.com/repos/jrafanie/manageiq/stargazers","contributors_url":"https://api.github.com/repos/jrafanie/manageiq/contributors","subscribers_url":"https://api.github.com/repos/jrafanie/manageiq/subscribers","subscription_url":"https://api.github.com/repos/jrafanie/manageiq/subscription","commits_url":"https://api.github.com/repos/jrafanie/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrafanie/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrafanie/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrafanie/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrafanie/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/jrafanie/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrafanie/manageiq/merges","archive_url":"https://api.github.com/repos/jrafanie/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrafanie/manageiq/downloads","issues_url":"https://api.github.com/repos/jrafanie/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/jrafanie/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/jrafanie/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/jrafanie/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrafanie/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/jrafanie/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/jrafanie/manageiq/deployments","created_at":"2014-06-13T12:47:01Z","updated_at":"2016-03-11T17:09:40Z","pushed_at":"2016-03-18T21:05:29Z","git_url":"git://github.com/jrafanie/manageiq.git","ssh_url":"git@github.com:jrafanie/manageiq.git","clone_url":"https://github.com/jrafanie/manageiq.git","svn_url":"https://github.com/jrafanie/manageiq","homepage":null,"size":110411,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"25416e70e7a80e611896a95b066314bdce60f8ad","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-03-18T17:39:21Z","pushed_at":"2016-03-18T21:16:59Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":147942,"stargazers_count":238,"watchers_count":238,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":256,"mirror_url":null,"open_issues_count":614,"forks":256,"open_issues":614,"watchers":238,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7403"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/7403"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/7403"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/7403/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7403/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7403/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/5e488ecccfab4446f4a52ee538c91a080391c9a3"}}}}