{"action":"created","comment":{"url":"https://api.github.com/repos/expertiza/expertiza/pulls/comments/87937109","pull_request_review_id":8527025,"id":87937109,"diff_hunk":"@@ -60,11 +66,13 @@ def update_join_team_request(user, student)\n     end\n   end\n \n+  #auto complete user name","path":"app/controllers/invitation_controller.rb","position":79,"original_position":79,"commit_id":"40fb61c0772134b5032c639934f695de26853c9f","original_commit_id":"40fb61c0772134b5032c639934f695de26853c9f","user":{"login":"canhsiao","id":2680675,"avatar_url":"https://avatars.githubusercontent.com/u/2680675?v=3","gravatar_id":"","url":"https://api.github.com/users/canhsiao","html_url":"https://github.com/canhsiao","followers_url":"https://api.github.com/users/canhsiao/followers","following_url":"https://api.github.com/users/canhsiao/following{/other_user}","gists_url":"https://api.github.com/users/canhsiao/gists{/gist_id}","starred_url":"https://api.github.com/users/canhsiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canhsiao/subscriptions","organizations_url":"https://api.github.com/users/canhsiao/orgs","repos_url":"https://api.github.com/users/canhsiao/repos","events_url":"https://api.github.com/users/canhsiao/events{/privacy}","received_events_url":"https://api.github.com/users/canhsiao/received_events","type":"User","site_admin":false},"body":"we thought in the last function, line 51, when other possibilities are eliminated, this function could be implemented then.","created_at":"2016-11-15T02:21:42Z","updated_at":"2016-11-15T02:21:42Z","html_url":"https://github.com/expertiza/expertiza/pull/824#discussion_r87937109","pull_request_url":"https://api.github.com/repos/expertiza/expertiza/pulls/824","_links":{"self":{"href":"https://api.github.com/repos/expertiza/expertiza/pulls/comments/87937109"},"html":{"href":"https://github.com/expertiza/expertiza/pull/824#discussion_r87937109"},"pull_request":{"href":"https://api.github.com/repos/expertiza/expertiza/pulls/824"}}},"pull_request":{"url":"https://api.github.com/repos/expertiza/expertiza/pulls/824","id":91513375,"html_url":"https://github.com/expertiza/expertiza/pull/824","diff_url":"https://github.com/expertiza/expertiza/pull/824.diff","patch_url":"https://github.com/expertiza/expertiza/pull/824.patch","issue_url":"https://api.github.com/repos/expertiza/expertiza/issues/824","number":824,"state":"closed","locked":false,"title":"E1635. Refactor join_team_requests_controller.rb and invitation_controller.rb","user":{"login":"canhsiao","id":2680675,"avatar_url":"https://avatars.githubusercontent.com/u/2680675?v=3","gravatar_id":"","url":"https://api.github.com/users/canhsiao","html_url":"https://github.com/canhsiao","followers_url":"https://api.github.com/users/canhsiao/followers","following_url":"https://api.github.com/users/canhsiao/following{/other_user}","gists_url":"https://api.github.com/users/canhsiao/gists{/gist_id}","starred_url":"https://api.github.com/users/canhsiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canhsiao/subscriptions","organizations_url":"https://api.github.com/users/canhsiao/orgs","repos_url":"https://api.github.com/users/canhsiao/repos","events_url":"https://api.github.com/users/canhsiao/events{/privacy}","received_events_url":"https://api.github.com/users/canhsiao/received_events","type":"User","site_admin":false},"body":"## InvitationController\n- Rename to **invitations_controller.rb,** in accordance with current naming convention.\n- Convert if nested inside else to elsif.\n- Add comments explaining what each method does, and comments on how important variables are used.\n- Refactor create and accept methods. Shorten and clarify them by adding private methods (e.g. extract a ready_to_join? method and call it from accept method)\n- Change awkward flash messages.\n## JoinTeamRequestsController\n- Add comments on some important variables.\n- Convert if nested inside else to elsif\n- Remove duplicate code: Common code in index, show and new method are moved into a private method. \n- Create and update do not share any code. This raises the spectre of DRY problems. Make sure that all functionality used in creating a request is available when editing a request, and that no code is duplicated.\n- Fix wording of message:\n","created_at":"2016-10-30T07:05:17Z","updated_at":"2016-11-15T02:21:42Z","closed_at":"2016-11-10T21:10:26Z","merged_at":null,"merge_commit_sha":"ce9fa0a3877fae8d7445cdff89ea2c9e12cbb2fc","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/expertiza/expertiza/milestones/29","html_url":"https://github.com/expertiza/expertiza/milestones/CSC517%202016%20Fall%20OSS%20Projects","labels_url":"https://api.github.com/repos/expertiza/expertiza/milestones/29/labels","id":2123059,"number":29,"title":"CSC517 2016 Fall OSS Projects","description":"CSC517 2015 Fall OSS Projects","creator":{"login":"Winbobob","id":7702035,"avatar_url":"https://avatars.githubusercontent.com/u/7702035?v=3","gravatar_id":"","url":"https://api.github.com/users/Winbobob","html_url":"https://github.com/Winbobob","followers_url":"https://api.github.com/users/Winbobob/followers","following_url":"https://api.github.com/users/Winbobob/following{/other_user}","gists_url":"https://api.github.com/users/Winbobob/gists{/gist_id}","starred_url":"https://api.github.com/users/Winbobob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Winbobob/subscriptions","organizations_url":"https://api.github.com/users/Winbobob/orgs","repos_url":"https://api.github.com/users/Winbobob/repos","events_url":"https://api.github.com/users/Winbobob/events{/privacy}","received_events_url":"https://api.github.com/users/Winbobob/received_events","type":"User","site_admin":false},"open_issues":35,"closed_issues":19,"state":"open","created_at":"2016-11-08T20:06:20Z","updated_at":"2016-11-14T20:55:43Z","due_on":"2016-11-20T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/expertiza/expertiza/pulls/824/commits","review_comments_url":"https://api.github.com/repos/expertiza/expertiza/pulls/824/comments","review_comment_url":"https://api.github.com/repos/expertiza/expertiza/pulls/comments{/number}","comments_url":"https://api.github.com/repos/expertiza/expertiza/issues/824/comments","statuses_url":"https://api.github.com/repos/expertiza/expertiza/statuses/40fb61c0772134b5032c639934f695de26853c9f","head":{"label":"canhsiao:master","ref":"master","sha":"40fb61c0772134b5032c639934f695de26853c9f","user":{"login":"canhsiao","id":2680675,"avatar_url":"https://avatars.githubusercontent.com/u/2680675?v=3","gravatar_id":"","url":"https://api.github.com/users/canhsiao","html_url":"https://github.com/canhsiao","followers_url":"https://api.github.com/users/canhsiao/followers","following_url":"https://api.github.com/users/canhsiao/following{/other_user}","gists_url":"https://api.github.com/users/canhsiao/gists{/gist_id}","starred_url":"https://api.github.com/users/canhsiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canhsiao/subscriptions","organizations_url":"https://api.github.com/users/canhsiao/orgs","repos_url":"https://api.github.com/users/canhsiao/repos","events_url":"https://api.github.com/users/canhsiao/events{/privacy}","received_events_url":"https://api.github.com/users/canhsiao/received_events","type":"User","site_admin":false},"repo":{"id":69830802,"name":"expertiza","full_name":"canhsiao/expertiza","owner":{"login":"canhsiao","id":2680675,"avatar_url":"https://avatars.githubusercontent.com/u/2680675?v=3","gravatar_id":"","url":"https://api.github.com/users/canhsiao","html_url":"https://github.com/canhsiao","followers_url":"https://api.github.com/users/canhsiao/followers","following_url":"https://api.github.com/users/canhsiao/following{/other_user}","gists_url":"https://api.github.com/users/canhsiao/gists{/gist_id}","starred_url":"https://api.github.com/users/canhsiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canhsiao/subscriptions","organizations_url":"https://api.github.com/users/canhsiao/orgs","repos_url":"https://api.github.com/users/canhsiao/repos","events_url":"https://api.github.com/users/canhsiao/events{/privacy}","received_events_url":"https://api.github.com/users/canhsiao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/canhsiao/expertiza","description":"Expertiza is a web application where students can submit and peer-review learning objects (articles, code, web sites, etc).  The Expertiza project is supported by the National Science Foundation.","fork":true,"url":"https://api.github.com/repos/canhsiao/expertiza","forks_url":"https://api.github.com/repos/canhsiao/expertiza/forks","keys_url":"https://api.github.com/repos/canhsiao/expertiza/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canhsiao/expertiza/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canhsiao/expertiza/teams","hooks_url":"https://api.github.com/repos/canhsiao/expertiza/hooks","issue_events_url":"https://api.github.com/repos/canhsiao/expertiza/issues/events{/number}","events_url":"https://api.github.com/repos/canhsiao/expertiza/events","assignees_url":"https://api.github.com/repos/canhsiao/expertiza/assignees{/user}","branches_url":"https://api.github.com/repos/canhsiao/expertiza/branches{/branch}","tags_url":"https://api.github.com/repos/canhsiao/expertiza/tags","blobs_url":"https://api.github.com/repos/canhsiao/expertiza/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canhsiao/expertiza/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canhsiao/expertiza/git/refs{/sha}","trees_url":"https://api.github.com/repos/canhsiao/expertiza/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canhsiao/expertiza/statuses/{sha}","languages_url":"https://api.github.com/repos/canhsiao/expertiza/languages","stargazers_url":"https://api.github.com/repos/canhsiao/expertiza/stargazers","contributors_url":"https://api.github.com/repos/canhsiao/expertiza/contributors","subscribers_url":"https://api.github.com/repos/canhsiao/expertiza/subscribers","subscription_url":"https://api.github.com/repos/canhsiao/expertiza/subscription","commits_url":"https://api.github.com/repos/canhsiao/expertiza/commits{/sha}","git_commits_url":"https://api.github.com/repos/canhsiao/expertiza/git/commits{/sha}","comments_url":"https://api.github.com/repos/canhsiao/expertiza/comments{/number}","issue_comment_url":"https://api.github.com/repos/canhsiao/expertiza/issues/comments{/number}","contents_url":"https://api.github.com/repos/canhsiao/expertiza/contents/{+path}","compare_url":"https://api.github.com/repos/canhsiao/expertiza/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canhsiao/expertiza/merges","archive_url":"https://api.github.com/repos/canhsiao/expertiza/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canhsiao/expertiza/downloads","issues_url":"https://api.github.com/repos/canhsiao/expertiza/issues{/number}","pulls_url":"https://api.github.com/repos/canhsiao/expertiza/pulls{/number}","milestones_url":"https://api.github.com/repos/canhsiao/expertiza/milestones{/number}","notifications_url":"https://api.github.com/repos/canhsiao/expertiza/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canhsiao/expertiza/labels{/name}","releases_url":"https://api.github.com/repos/canhsiao/expertiza/releases{/id}","deployments_url":"https://api.github.com/repos/canhsiao/expertiza/deployments","created_at":"2016-10-03T00:40:18Z","updated_at":"2016-10-03T00:40:21Z","pushed_at":"2016-11-07T17:24:41Z","git_url":"git://github.com/canhsiao/expertiza.git","ssh_url":"git@github.com:canhsiao/expertiza.git","clone_url":"https://github.com/canhsiao/expertiza.git","svn_url":"https://github.com/canhsiao/expertiza","homepage":"http://wikis.lib.ncsu.edu/index.php/Expertiza","size":45699,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"expertiza:master","ref":"master","sha":"4bd5e9de1f74fa3593e28bdfa923f587b085d56a","user":{"login":"expertiza","id":427458,"avatar_url":"https://avatars.githubusercontent.com/u/427458?v=3","gravatar_id":"","url":"https://api.github.com/users/expertiza","html_url":"https://github.com/expertiza","followers_url":"https://api.github.com/users/expertiza/followers","following_url":"https://api.github.com/users/expertiza/following{/other_user}","gists_url":"https://api.github.com/users/expertiza/gists{/gist_id}","starred_url":"https://api.github.com/users/expertiza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/expertiza/subscriptions","organizations_url":"https://api.github.com/users/expertiza/orgs","repos_url":"https://api.github.com/users/expertiza/repos","events_url":"https://api.github.com/users/expertiza/events{/privacy}","received_events_url":"https://api.github.com/users/expertiza/received_events","type":"Organization","site_admin":false},"repo":{"id":962564,"name":"expertiza","full_name":"expertiza/expertiza","owner":{"login":"expertiza","id":427458,"avatar_url":"https://avatars.githubusercontent.com/u/427458?v=3","gravatar_id":"","url":"https://api.github.com/users/expertiza","html_url":"https://github.com/expertiza","followers_url":"https://api.github.com/users/expertiza/followers","following_url":"https://api.github.com/users/expertiza/following{/other_user}","gists_url":"https://api.github.com/users/expertiza/gists{/gist_id}","starred_url":"https://api.github.com/users/expertiza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/expertiza/subscriptions","organizations_url":"https://api.github.com/users/expertiza/orgs","repos_url":"https://api.github.com/users/expertiza/repos","events_url":"https://api.github.com/users/expertiza/events{/privacy}","received_events_url":"https://api.github.com/users/expertiza/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/expertiza/expertiza","description":"Expertiza is a web application where students can submit and peer-review learning objects (articles, code, web sites, etc).  The Expertiza project is supported by the National Science Foundation.","fork":false,"url":"https://api.github.com/repos/expertiza/expertiza","forks_url":"https://api.github.com/repos/expertiza/expertiza/forks","keys_url":"https://api.github.com/repos/expertiza/expertiza/keys{/key_id}","collaborators_url":"https://api.github.com/repos/expertiza/expertiza/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/expertiza/expertiza/teams","hooks_url":"https://api.github.com/repos/expertiza/expertiza/hooks","issue_events_url":"https://api.github.com/repos/expertiza/expertiza/issues/events{/number}","events_url":"https://api.github.com/repos/expertiza/expertiza/events","assignees_url":"https://api.github.com/repos/expertiza/expertiza/assignees{/user}","branches_url":"https://api.github.com/repos/expertiza/expertiza/branches{/branch}","tags_url":"https://api.github.com/repos/expertiza/expertiza/tags","blobs_url":"https://api.github.com/repos/expertiza/expertiza/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/expertiza/expertiza/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/expertiza/expertiza/git/refs{/sha}","trees_url":"https://api.github.com/repos/expertiza/expertiza/git/trees{/sha}","statuses_url":"https://api.github.com/repos/expertiza/expertiza/statuses/{sha}","languages_url":"https://api.github.com/repos/expertiza/expertiza/languages","stargazers_url":"https://api.github.com/repos/expertiza/expertiza/stargazers","contributors_url":"https://api.github.com/repos/expertiza/expertiza/contributors","subscribers_url":"https://api.github.com/repos/expertiza/expertiza/subscribers","subscription_url":"https://api.github.com/repos/expertiza/expertiza/subscription","commits_url":"https://api.github.com/repos/expertiza/expertiza/commits{/sha}","git_commits_url":"https://api.github.com/repos/expertiza/expertiza/git/commits{/sha}","comments_url":"https://api.github.com/repos/expertiza/expertiza/comments{/number}","issue_comment_url":"https://api.github.com/repos/expertiza/expertiza/issues/comments{/number}","contents_url":"https://api.github.com/repos/expertiza/expertiza/contents/{+path}","compare_url":"https://api.github.com/repos/expertiza/expertiza/compare/{base}...{head}","merges_url":"https://api.github.com/repos/expertiza/expertiza/merges","archive_url":"https://api.github.com/repos/expertiza/expertiza/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/expertiza/expertiza/downloads","issues_url":"https://api.github.com/repos/expertiza/expertiza/issues{/number}","pulls_url":"https://api.github.com/repos/expertiza/expertiza/pulls{/number}","milestones_url":"https://api.github.com/repos/expertiza/expertiza/milestones{/number}","notifications_url":"https://api.github.com/repos/expertiza/expertiza/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/expertiza/expertiza/labels{/name}","releases_url":"https://api.github.com/repos/expertiza/expertiza/releases{/id}","deployments_url":"https://api.github.com/repos/expertiza/expertiza/deployments","created_at":"2010-10-05T03:37:29Z","updated_at":"2016-11-05T14:02:44Z","pushed_at":"2016-11-15T01:47:29Z","git_url":"git://github.com/expertiza/expertiza.git","ssh_url":"git@github.com:expertiza/expertiza.git","clone_url":"https://github.com/expertiza/expertiza.git","svn_url":"https://github.com/expertiza/expertiza","homepage":"http://wikis.lib.ncsu.edu/index.php/Expertiza","size":73137,"stargazers_count":116,"watchers_count":116,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":508,"mirror_url":null,"open_issues_count":138,"forks":508,"open_issues":138,"watchers":116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/expertiza/expertiza/pulls/824"},"html":{"href":"https://github.com/expertiza/expertiza/pull/824"},"issue":{"href":"https://api.github.com/repos/expertiza/expertiza/issues/824"},"comments":{"href":"https://api.github.com/repos/expertiza/expertiza/issues/824/comments"},"review_comments":{"href":"https://api.github.com/repos/expertiza/expertiza/pulls/824/comments"},"review_comment":{"href":"https://api.github.com/repos/expertiza/expertiza/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/expertiza/expertiza/pulls/824/commits"},"statuses":{"href":"https://api.github.com/repos/expertiza/expertiza/statuses/40fb61c0772134b5032c639934f695de26853c9f"}}}}
{"actor":{"display_login":"canhsiao"}}