{"action":"created","issue":{"url":"https://api.github.com/repos/blei-lab/edward/issues/149","repository_url":"https://api.github.com/repos/blei-lab/edward","labels_url":"https://api.github.com/repos/blei-lab/edward/issues/149/labels{/name}","comments_url":"https://api.github.com/repos/blei-lab/edward/issues/149/comments","events_url":"https://api.github.com/repos/blei-lab/edward/issues/149/events","html_url":"https://github.com/blei-lab/edward/pull/149","id":163543877,"number":149,"title":"doc/website","user":{"login":"akucukelbir","id":329960,"avatar_url":"https://avatars.githubusercontent.com/u/329960?v=3","gravatar_id":"","url":"https://api.github.com/users/akucukelbir","html_url":"https://github.com/akucukelbir","followers_url":"https://api.github.com/users/akucukelbir/followers","following_url":"https://api.github.com/users/akucukelbir/following{/other_user}","gists_url":"https://api.github.com/users/akucukelbir/gists{/gist_id}","starred_url":"https://api.github.com/users/akucukelbir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akucukelbir/subscriptions","organizations_url":"https://api.github.com/users/akucukelbir/orgs","repos_url":"https://api.github.com/users/akucukelbir/repos","events_url":"https://api.github.com/users/akucukelbir/events{/privacy}","received_events_url":"https://api.github.com/users/akucukelbir/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":25,"created_at":"2016-07-03T02:25:28Z","updated_at":"2016-07-15T18:30:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/blei-lab/edward/pulls/149","html_url":"https://github.com/blei-lab/edward/pull/149","diff_url":"https://github.com/blei-lab/edward/pull/149.diff","patch_url":"https://github.com/blei-lab/edward/pull/149.patch"},"body":"#### Summary:\r\n\r\nThis PR does three things:\r\n\r\n1. it introduces a brand-new website to replace the current one (via a custom `pandoc` workflow).\r\n2. it introduces automatic API documentation (via `sphinx`).\r\n\r\nThere are a few remaining tasks before we can merge this:\r\n\r\n- [x] figure out what goes into `deploy.sh`\r\n- [x] finalize getting started / delving in / tutorials\r\n- [x] update `README.md` to match website and updated logo\r\n\r\n#### How to Verify:\r\n\r\nLook at the website and check for issues/typos.\r\n\r\nLook at docstrings and how they render via sphinx.\r\n\r\n#### Side Effects:\r\n\r\nThe old website is deleted.\r\n\r\n#### Documentation:\r\n\r\nThere is a new `README.md` under `/website` that documents the scripts that build and deploy the website\r\n"},"comment":{"url":"https://api.github.com/repos/blei-lab/edward/issues/comments/233031334","html_url":"https://github.com/blei-lab/edward/pull/149#issuecomment-233031334","issue_url":"https://api.github.com/repos/blei-lab/edward/issues/149","id":233031334,"user":{"login":"dustinvtran","id":2569867,"avatar_url":"https://avatars.githubusercontent.com/u/2569867?v=3","gravatar_id":"","url":"https://api.github.com/users/dustinvtran","html_url":"https://github.com/dustinvtran","followers_url":"https://api.github.com/users/dustinvtran/followers","following_url":"https://api.github.com/users/dustinvtran/following{/other_user}","gists_url":"https://api.github.com/users/dustinvtran/gists{/gist_id}","starred_url":"https://api.github.com/users/dustinvtran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dustinvtran/subscriptions","organizations_url":"https://api.github.com/users/dustinvtran/orgs","repos_url":"https://api.github.com/users/dustinvtran/repos","events_url":"https://api.github.com/users/dustinvtran/events{/privacy}","received_events_url":"https://api.github.com/users/dustinvtran/received_events","type":"User","site_admin":false},"created_at":"2016-07-15T18:30:38Z","updated_at":"2016-07-15T18:30:38Z","body":"@akucukelbir:\r\n+ README.md\r\n  + I propose changing image url to point to a github source storing the file\r\n  + Following Dave, I always use `__word__` instead of `**word**` and + instead of - for bullet points. I propose we not change this for now, and we can discuss it in another pull request focusing on formatting changes; this pull request can focus strictly on website changes.\r\n  + Where do we place backend features? I know the deep learning community for example would rarely touch probabilistic software because there is never support for GPUs or distributed training for truly scaling computation to massive data sets. And it's a massive distinguishing factor from other software, specifically other probabilistic programming libraries that don't often think about these issues.\r\n\r\n    I propose after the criticism list, we should add the following sentence:\r\n    ```Edward is built on top of [TensorFlow](https://www.tensorflow.org) as a backend, enabling features such as computational graphs, distributed training, CPU/GPU integration, automatic differentiation, and TensorBoard.```\r\n  + Somewhere we need a link to the website. I think I agree with you that much of the information in the README.md is unnecessary, especially for a first-time reader. I propose we follow what TensorFlow's README.md does.\r\n\r\n    That is, cut everything down from (and including) the __Authors__ section; then add\r\n    ```\r\n    ### Resources\r\n    + [Edward website](http://edwardlib.org)\r\n    ```\r\n    This bulleted list will eventually include the white paper, our own model zoo, and other things.\r\n+ examples/getting_started_example.py\r\n  + This needs to be edited following the other bayesian NN scripts. For example, new data API using a dictionary for the data, `n_vars` and `n_layers`, `self.weight_dims = list(zip(...)))` for Python 3 support. Maybe it's as easy and re-copying and pasting the BayesianNN class and `build_toy_dataset()` from the other scripts.\r\n+ getting-started.tex\r\n  + let's remove the x=y line in the plots, which can be distracting\r\n\r\n@mariru:\r\n+ inferences.py\r\n  + Trailing whitespace is the devil. Whenever pushing, let's make sure there is no trailing whitespace. There are ways to do this for each text editor.\r\n+ examples/latent_space_model.py\r\n  + add `#!/usr/bin/env python` to the top of the file. also add comments giving a brief explanation of the script; see the other example scripts as a reference\r\n  + Following PEP8, `class Latent_Space_Model():` -> `class LatentSpaceModel:`\r\n  + `self.num_vars` -> `self.n_vars`\r\n  + remove commented out code\r\n  + new data API\r\n  + Following PEP8, only top-level functions and class definitions should be separated with two emptylines; everything else should be separated by one emptyline.\r\n  + Let's push this into master now, along with `examples/data/celegans_brain.py`. In general, this pull request should not touch any files in the repo except for `docs/` and adding new directories.\r\n+ examples/matrix_factorization.py\r\n  + Same comments as above. Also, does this run? Or as you suggested, should we postpone adding this example until after this pull request?\r\n\r\n__re:Authorship list in authors section and citation.__\r\nI'm of the opinion that it should be sorted by order of joining, including only active developers, and with Dave second on the list. So at the moment, Dustin Tran, David M. Blei, Alp Kucukelbir, Adji Dieng, Maja Rudolph, and Dawen Liang. We can define an \"active developer\" in any way we want, e.g., loosely speaking, someone who has contributed to Edward in a big enough way and in the past year.  This encourages adding contributors not directly in our lab (it can be anyone), and it avoids the issue of Dave appended to a list of over 100 previous coauthors.\r\n\r\nBut I haven't thought carefully about all the issues around this. And while this is something we typically don't like to think about it, I think this is very important to address directly and transparently so we're all aware of the issues. Thoughts appreciated!\r\n\r\n__re:Any text from `docs/` that was not improved or edited upon, but simply deleted.__ Let's move them all into the `edward-misc/` repo for now, so that we have them somewhere. For example, the getting started with TensorFlow page. Is there anything else?\r\n"}}
{"actor":{"display_login":"dustinvtran"}}