{"action":"closed","issue":{"url":"https://api.github.com/repos/LinuxCNC/linuxcnc/issues/44","repository_url":"https://api.github.com/repos/LinuxCNC/linuxcnc","labels_url":"https://api.github.com/repos/LinuxCNC/linuxcnc/issues/44/labels{/name}","comments_url":"https://api.github.com/repos/LinuxCNC/linuxcnc/issues/44/comments","events_url":"https://api.github.com/repos/LinuxCNC/linuxcnc/issues/44/events","html_url":"https://github.com/LinuxCNC/linuxcnc/issues/44","id":139652797,"number":44,"title":"ja: motion's joint locking hal pins missing","user":{"login":"SebKuzminsky","id":400548,"avatar_url":"https://avatars.githubusercontent.com/u/400548?v=3","gravatar_id":"","url":"https://api.github.com/users/SebKuzminsky","html_url":"https://github.com/SebKuzminsky","followers_url":"https://api.github.com/users/SebKuzminsky/followers","following_url":"https://api.github.com/users/SebKuzminsky/following{/other_user}","gists_url":"https://api.github.com/users/SebKuzminsky/gists{/gist_id}","starred_url":"https://api.github.com/users/SebKuzminsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SebKuzminsky/subscriptions","organizations_url":"https://api.github.com/users/SebKuzminsky/orgs","repos_url":"https://api.github.com/users/SebKuzminsky/repos","events_url":"https://api.github.com/users/SebKuzminsky/events{/privacy}","received_events_url":"https://api.github.com/users/SebKuzminsky/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-03-09T17:53:10Z","updated_at":"2016-05-15T01:14:34Z","closed_at":"2016-05-15T01:14:34Z","body":"Skunkworks reports on IRC:  http://tom-itx.no-ip.biz:81/~tom-itx/irc/logs/%23linuxcnc-devel/2016-03-09.html\r\n\r\n## Here are the steps I follow to reproduce the issue:\r\n\r\n 1. Start with a pre-ja config with at least one [AXIS_n]LOCKING_INDEXER=1, auto-convert to a ja config with update_ini.\r\n 2. Note that the LOCKING_INDEXER setting got applied to the correct [JOINT_n] section.\r\n 3. Start linuxcnc with the converted config.\r\n 4. Linuxcnc does not create the requested joint.n.unlock and joint.n.is-unlocked HAL pins.\r\n\r\n## This is what I expected to happen:\r\nThe pins should be created.\r\n\r\n## This is what happened instead:\r\nThe pins were not created.\r\n\r\n## It worked properly before this:\r\nWorks in 2.7.4 (pre-ja), though in this version, Motion creates locking pins for all rotary axes, whether or not they asked for them in the ini.\r\n\r\nIn JA, Motion expects a new load-time argument of unlock_joints_mask, which is not created by update_ini.  Motion only creates locking pins for the joints enabled in that mask.\r\n\r\nPossible fixes would be to revert to the old system of creating locking pins for all rotary joints, or to ensure that unlock_joints_mask gets sent to Motion correctly at load time.\r\n"}}