{"action":"opened","number":57,"pull_request":{"url":"https://api.github.com/repos/npm/fstream/pulls/57","id":88634616,"html_url":"https://github.com/npm/fstream/pull/57","diff_url":"https://github.com/npm/fstream/pull/57.diff","patch_url":"https://github.com/npm/fstream/pull/57.patch","issue_url":"https://api.github.com/repos/npm/fstream/issues/57","number":57,"state":"open","locked":false,"title":"Reader does not work when read hardlink","user":{"login":"pauky","id":6583109,"avatar_url":"https://avatars.githubusercontent.com/u/6583109?v=3","gravatar_id":"","url":"https://api.github.com/users/pauky","html_url":"https://github.com/pauky","followers_url":"https://api.github.com/users/pauky/followers","following_url":"https://api.github.com/users/pauky/following{/other_user}","gists_url":"https://api.github.com/users/pauky/gists{/gist_id}","starred_url":"https://api.github.com/users/pauky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pauky/subscriptions","organizations_url":"https://api.github.com/users/pauky/orgs","repos_url":"https://api.github.com/users/pauky/repos","events_url":"https://api.github.com/users/pauky/events{/privacy}","received_events_url":"https://api.github.com/users/pauky/received_events","type":"User","site_admin":false},"body":"I think the following code must be deleted.\r\nBecause the hardlink will be read by LinkReader. But the hardlink is just file.Trust me!\r\n```\r\n   var handleHardlinks = props.hardlinks !== false\r\n\r\n    // special little thing for handling hardlinks.\r\n    if (handleHardlinks && type !== 'Directory' && props.nlink && props.nlink > 1) {\r\n      var k = props.dev + ':' + props.ino\r\n      // console.error(\"Reader has nlink\", self._path, k)\r\n      if (hardLinks[k] === self._path || !hardLinks[k]) {\r\n        hardLinks[k] = self._path\r\n      } else {\r\n        // switch into hardlink mode.\r\n        type = self.type = self.props.type = 'Link'\r\n        self.Link = self.props.Link = true\r\n        self.linkpath = self.props.linkpath = hardLinks[k]\r\n        // console.error(\"Hardlink detected, switching mode\", self._path, self.linkpath)\r\n        // Setting __proto__ would arguably be the \"correct\"\r\n        // approach here, but that just seems too wrong.\r\n        self._stat = self._read = LinkReader.prototype._read\r\n      }\r\n    }\r\n```","created_at":"2016-10-10T09:44:54Z","updated_at":"2016-10-10T09:44:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"399056de82349d2c69c06e4d4fb0368934aa6316","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/npm/fstream/pulls/57/commits","review_comments_url":"https://api.github.com/repos/npm/fstream/pulls/57/comments","review_comment_url":"https://api.github.com/repos/npm/fstream/pulls/comments{/number}","comments_url":"https://api.github.com/repos/npm/fstream/issues/57/comments","statuses_url":"https://api.github.com/repos/npm/fstream/statuses/5af0ec336091a788a90ffbc50b9a17e95df44e32","head":{"label":"pauky:patch-2","ref":"patch-2","sha":"5af0ec336091a788a90ffbc50b9a17e95df44e32","user":{"login":"pauky","id":6583109,"avatar_url":"https://avatars.githubusercontent.com/u/6583109?v=3","gravatar_id":"","url":"https://api.github.com/users/pauky","html_url":"https://github.com/pauky","followers_url":"https://api.github.com/users/pauky/followers","following_url":"https://api.github.com/users/pauky/following{/other_user}","gists_url":"https://api.github.com/users/pauky/gists{/gist_id}","starred_url":"https://api.github.com/users/pauky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pauky/subscriptions","organizations_url":"https://api.github.com/users/pauky/orgs","repos_url":"https://api.github.com/users/pauky/repos","events_url":"https://api.github.com/users/pauky/events{/privacy}","received_events_url":"https://api.github.com/users/pauky/received_events","type":"User","site_admin":false},"repo":{"id":70472147,"name":"fstream","full_name":"pauky/fstream","owner":{"login":"pauky","id":6583109,"avatar_url":"https://avatars.githubusercontent.com/u/6583109?v=3","gravatar_id":"","url":"https://api.github.com/users/pauky","html_url":"https://github.com/pauky","followers_url":"https://api.github.com/users/pauky/followers","following_url":"https://api.github.com/users/pauky/following{/other_user}","gists_url":"https://api.github.com/users/pauky/gists{/gist_id}","starred_url":"https://api.github.com/users/pauky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pauky/subscriptions","organizations_url":"https://api.github.com/users/pauky/orgs","repos_url":"https://api.github.com/users/pauky/repos","events_url":"https://api.github.com/users/pauky/events{/privacy}","received_events_url":"https://api.github.com/users/pauky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pauky/fstream","description":"Advanced FS Streaming for Node","fork":true,"url":"https://api.github.com/repos/pauky/fstream","forks_url":"https://api.github.com/repos/pauky/fstream/forks","keys_url":"https://api.github.com/repos/pauky/fstream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pauky/fstream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pauky/fstream/teams","hooks_url":"https://api.github.com/repos/pauky/fstream/hooks","issue_events_url":"https://api.github.com/repos/pauky/fstream/issues/events{/number}","events_url":"https://api.github.com/repos/pauky/fstream/events","assignees_url":"https://api.github.com/repos/pauky/fstream/assignees{/user}","branches_url":"https://api.github.com/repos/pauky/fstream/branches{/branch}","tags_url":"https://api.github.com/repos/pauky/fstream/tags","blobs_url":"https://api.github.com/repos/pauky/fstream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pauky/fstream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pauky/fstream/git/refs{/sha}","trees_url":"https://api.github.com/repos/pauky/fstream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pauky/fstream/statuses/{sha}","languages_url":"https://api.github.com/repos/pauky/fstream/languages","stargazers_url":"https://api.github.com/repos/pauky/fstream/stargazers","contributors_url":"https://api.github.com/repos/pauky/fstream/contributors","subscribers_url":"https://api.github.com/repos/pauky/fstream/subscribers","subscription_url":"https://api.github.com/repos/pauky/fstream/subscription","commits_url":"https://api.github.com/repos/pauky/fstream/commits{/sha}","git_commits_url":"https://api.github.com/repos/pauky/fstream/git/commits{/sha}","comments_url":"https://api.github.com/repos/pauky/fstream/comments{/number}","issue_comment_url":"https://api.github.com/repos/pauky/fstream/issues/comments{/number}","contents_url":"https://api.github.com/repos/pauky/fstream/contents/{+path}","compare_url":"https://api.github.com/repos/pauky/fstream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pauky/fstream/merges","archive_url":"https://api.github.com/repos/pauky/fstream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pauky/fstream/downloads","issues_url":"https://api.github.com/repos/pauky/fstream/issues{/number}","pulls_url":"https://api.github.com/repos/pauky/fstream/pulls{/number}","milestones_url":"https://api.github.com/repos/pauky/fstream/milestones{/number}","notifications_url":"https://api.github.com/repos/pauky/fstream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pauky/fstream/labels{/name}","releases_url":"https://api.github.com/repos/pauky/fstream/releases{/id}","deployments_url":"https://api.github.com/repos/pauky/fstream/deployments","created_at":"2016-10-10T09:19:08Z","updated_at":"2016-10-10T09:19:09Z","pushed_at":"2016-10-10T09:44:41Z","git_url":"git://github.com/pauky/fstream.git","ssh_url":"git@github.com:pauky/fstream.git","clone_url":"https://github.com/pauky/fstream.git","svn_url":"https://github.com/pauky/fstream","homepage":"","size":214,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"npm:master","ref":"master","sha":"24fabdec32e334dd3b130d77b38c010e3119b102","user":{"login":"npm","id":6078720,"avatar_url":"https://avatars.githubusercontent.com/u/6078720?v=3","gravatar_id":"","url":"https://api.github.com/users/npm","html_url":"https://github.com/npm","followers_url":"https://api.github.com/users/npm/followers","following_url":"https://api.github.com/users/npm/following{/other_user}","gists_url":"https://api.github.com/users/npm/gists{/gist_id}","starred_url":"https://api.github.com/users/npm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npm/subscriptions","organizations_url":"https://api.github.com/users/npm/orgs","repos_url":"https://api.github.com/users/npm/repos","events_url":"https://api.github.com/users/npm/events{/privacy}","received_events_url":"https://api.github.com/users/npm/received_events","type":"Organization","site_admin":false},"repo":{"id":2672652,"name":"fstream","full_name":"npm/fstream","owner":{"login":"npm","id":6078720,"avatar_url":"https://avatars.githubusercontent.com/u/6078720?v=3","gravatar_id":"","url":"https://api.github.com/users/npm","html_url":"https://github.com/npm","followers_url":"https://api.github.com/users/npm/followers","following_url":"https://api.github.com/users/npm/following{/other_user}","gists_url":"https://api.github.com/users/npm/gists{/gist_id}","starred_url":"https://api.github.com/users/npm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npm/subscriptions","organizations_url":"https://api.github.com/users/npm/orgs","repos_url":"https://api.github.com/users/npm/repos","events_url":"https://api.github.com/users/npm/events{/privacy}","received_events_url":"https://api.github.com/users/npm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/npm/fstream","description":"Advanced FS Streaming for Node","fork":false,"url":"https://api.github.com/repos/npm/fstream","forks_url":"https://api.github.com/repos/npm/fstream/forks","keys_url":"https://api.github.com/repos/npm/fstream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/npm/fstream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/npm/fstream/teams","hooks_url":"https://api.github.com/repos/npm/fstream/hooks","issue_events_url":"https://api.github.com/repos/npm/fstream/issues/events{/number}","events_url":"https://api.github.com/repos/npm/fstream/events","assignees_url":"https://api.github.com/repos/npm/fstream/assignees{/user}","branches_url":"https://api.github.com/repos/npm/fstream/branches{/branch}","tags_url":"https://api.github.com/repos/npm/fstream/tags","blobs_url":"https://api.github.com/repos/npm/fstream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/npm/fstream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/npm/fstream/git/refs{/sha}","trees_url":"https://api.github.com/repos/npm/fstream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/npm/fstream/statuses/{sha}","languages_url":"https://api.github.com/repos/npm/fstream/languages","stargazers_url":"https://api.github.com/repos/npm/fstream/stargazers","contributors_url":"https://api.github.com/repos/npm/fstream/contributors","subscribers_url":"https://api.github.com/repos/npm/fstream/subscribers","subscription_url":"https://api.github.com/repos/npm/fstream/subscription","commits_url":"https://api.github.com/repos/npm/fstream/commits{/sha}","git_commits_url":"https://api.github.com/repos/npm/fstream/git/commits{/sha}","comments_url":"https://api.github.com/repos/npm/fstream/comments{/number}","issue_comment_url":"https://api.github.com/repos/npm/fstream/issues/comments{/number}","contents_url":"https://api.github.com/repos/npm/fstream/contents/{+path}","compare_url":"https://api.github.com/repos/npm/fstream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/npm/fstream/merges","archive_url":"https://api.github.com/repos/npm/fstream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/npm/fstream/downloads","issues_url":"https://api.github.com/repos/npm/fstream/issues{/number}","pulls_url":"https://api.github.com/repos/npm/fstream/pulls{/number}","milestones_url":"https://api.github.com/repos/npm/fstream/milestones{/number}","notifications_url":"https://api.github.com/repos/npm/fstream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/npm/fstream/labels{/name}","releases_url":"https://api.github.com/repos/npm/fstream/releases{/id}","deployments_url":"https://api.github.com/repos/npm/fstream/deployments","created_at":"2011-10-29T21:36:05Z","updated_at":"2016-09-04T01:57:17Z","pushed_at":"2016-10-10T09:44:54Z","git_url":"git://github.com/npm/fstream.git","ssh_url":"git@github.com:npm/fstream.git","clone_url":"https://github.com/npm/fstream.git","svn_url":"https://github.com/npm/fstream","homepage":"","size":214,"stargazers_count":143,"watchers_count":143,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":25,"forks":34,"open_issues":25,"watchers":143,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/npm/fstream/pulls/57"},"html":{"href":"https://github.com/npm/fstream/pull/57"},"issue":{"href":"https://api.github.com/repos/npm/fstream/issues/57"},"comments":{"href":"https://api.github.com/repos/npm/fstream/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/npm/fstream/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/npm/fstream/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/npm/fstream/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/npm/fstream/statuses/5af0ec336091a788a90ffbc50b9a17e95df44e32"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":0,"deletions":19,"changed_files":1}}
{"actor":{"display_login":"pauky"}}