{"action":"created","comment":{"url":"https://api.github.com/repos/wireapp/wire-webapp/pulls/comments/93641403","pull_request_review_id":14172422,"id":93641403,"diff_hunk":"@@ -344,12 +344,13 @@ class z.SystemNotification.SystemNotificationRepository\n \n     throw new z.system_notification.SystemNotificationError z.system_notification.SystemNotificationError::TYPE.HIDE_NOTIFICATION if not notification_body?\n \n-    should_obfuscate = @_should_obfuscate_notification message_et\n+    should_obfuscate_message = @_should_obfuscate_notification_message message_et\n+    should_obfuscate_sender = @_should_obfuscate_notification_sender message_et\n \n     return {\n-      title: if should_obfuscate then @_create_title_obfuscated() else @_create_title conversation_et, message_et\n+      title: if should_obfuscate_sender then @_create_title_obfuscated() else @_create_title conversation_et, message_et","path":"app/script/system_notification/SystemNotificationRepository.coffee","position":10,"original_position":10,"commit_id":"124a354e48a98e27da0d520d16b5ba5ee61b71b2","original_commit_id":"124a354e48a98e27da0d520d16b5ba5ee61b71b2","user":{"login":"gregor","id":10243309,"avatar_url":"https://avatars.githubusercontent.com/u/10243309?v=3","gravatar_id":"","url":"https://api.github.com/users/gregor","html_url":"https://github.com/gregor","followers_url":"https://api.github.com/users/gregor/followers","following_url":"https://api.github.com/users/gregor/following{/other_user}","gists_url":"https://api.github.com/users/gregor/gists{/gist_id}","starred_url":"https://api.github.com/users/gregor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregor/subscriptions","organizations_url":"https://api.github.com/users/gregor/orgs","repos_url":"https://api.github.com/users/gregor/repos","events_url":"https://api.github.com/users/gregor/events{/privacy}","received_events_url":"https://api.github.com/users/gregor/received_events","type":"User","site_admin":false},"body":"`title: if @_should_obfuscate_notification_sender message_et then @_create_title_obfuscated() else @_create_title conversation_et, message_et`","created_at":"2016-12-22T15:23:35Z","updated_at":"2016-12-22T15:26:23Z","html_url":"https://github.com/wireapp/wire-webapp/pull/595#discussion_r93641403","pull_request_url":"https://api.github.com/repos/wireapp/wire-webapp/pulls/595","_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-webapp/pulls/comments/93641403"},"html":{"href":"https://github.com/wireapp/wire-webapp/pull/595#discussion_r93641403"},"pull_request":{"href":"https://api.github.com/repos/wireapp/wire-webapp/pulls/595"}}},"pull_request":{"url":"https://api.github.com/repos/wireapp/wire-webapp/pulls/595","id":98986327,"html_url":"https://github.com/wireapp/wire-webapp/pull/595","diff_url":"https://github.com/wireapp/wire-webapp/pull/595.diff","patch_url":"https://github.com/wireapp/wire-webapp/pull/595.patch","issue_url":"https://api.github.com/repos/wireapp/wire-webapp/issues/595","number":595,"state":"open","locked":false,"title":"Add an option to show only sender in notifications","user":{"login":"maximbaz","id":1177900,"avatar_url":"https://avatars.githubusercontent.com/u/1177900?v=3","gravatar_id":"","url":"https://api.github.com/users/maximbaz","html_url":"https://github.com/maximbaz","followers_url":"https://api.github.com/users/maximbaz/followers","following_url":"https://api.github.com/users/maximbaz/following{/other_user}","gists_url":"https://api.github.com/users/maximbaz/gists{/gist_id}","starred_url":"https://api.github.com/users/maximbaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximbaz/subscriptions","organizations_url":"https://api.github.com/users/maximbaz/orgs","repos_url":"https://api.github.com/users/maximbaz/repos","events_url":"https://api.github.com/users/maximbaz/events{/privacy}","received_events_url":"https://api.github.com/users/maximbaz/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nThis is the implementation for #586. Have a look at the screenshots below :wink: \r\n\r\n@gregor let me know what you think. \r\nI did not deal with translations, just left the placeholders so that we don't forget about them. \r\n\r\n## Screenshots\r\n\r\nText messages:\r\n![wire1_1](https://cloud.githubusercontent.com/assets/1177900/21401427/a0e6a442-c7b4-11e6-899a-2692664a3173.png)\r\n![wire1_2](https://cloud.githubusercontent.com/assets/1177900/21401426/a0e661ee-c7b4-11e6-8e70-98f1f4283a04.png)\r\n![wire1_3](https://cloud.githubusercontent.com/assets/1177900/21401425/a0e32a56-c7b4-11e6-809d-73ad53d032a3.png)\r\n\r\nPicture messages:\r\n![wire2_1](https://cloud.githubusercontent.com/assets/1177900/21401438/ab44a538-c7b4-11e6-8ea4-31fbfeed89cc.png)\r\n![wire2_2](https://cloud.githubusercontent.com/assets/1177900/21401437/ab44853a-c7b4-11e6-9987-d517fd9ba573.png)\r\n![wire2_3](https://cloud.githubusercontent.com/assets/1177900/21401439/ab488b58-c7b4-11e6-8a93-4051f54f3993.png)\r\n\r\n\r\n","created_at":"2016-12-21T18:58:20Z","updated_at":"2016-12-22T15:26:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9600af4768a015eccc66e445ce3463836a33c3ab","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wireapp/wire-webapp/pulls/595/commits","review_comments_url":"https://api.github.com/repos/wireapp/wire-webapp/pulls/595/comments","review_comment_url":"https://api.github.com/repos/wireapp/wire-webapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wireapp/wire-webapp/issues/595/comments","statuses_url":"https://api.github.com/repos/wireapp/wire-webapp/statuses/124a354e48a98e27da0d520d16b5ba5ee61b71b2","head":{"label":"maximbaz:notification-show-only-sender-name","ref":"notification-show-only-sender-name","sha":"124a354e48a98e27da0d520d16b5ba5ee61b71b2","user":{"login":"maximbaz","id":1177900,"avatar_url":"https://avatars.githubusercontent.com/u/1177900?v=3","gravatar_id":"","url":"https://api.github.com/users/maximbaz","html_url":"https://github.com/maximbaz","followers_url":"https://api.github.com/users/maximbaz/followers","following_url":"https://api.github.com/users/maximbaz/following{/other_user}","gists_url":"https://api.github.com/users/maximbaz/gists{/gist_id}","starred_url":"https://api.github.com/users/maximbaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximbaz/subscriptions","organizations_url":"https://api.github.com/users/maximbaz/orgs","repos_url":"https://api.github.com/users/maximbaz/repos","events_url":"https://api.github.com/users/maximbaz/events{/privacy}","received_events_url":"https://api.github.com/users/maximbaz/received_events","type":"User","site_admin":false},"repo":{"id":75985963,"name":"wire-webapp","full_name":"maximbaz/wire-webapp","owner":{"login":"maximbaz","id":1177900,"avatar_url":"https://avatars.githubusercontent.com/u/1177900?v=3","gravatar_id":"","url":"https://api.github.com/users/maximbaz","html_url":"https://github.com/maximbaz","followers_url":"https://api.github.com/users/maximbaz/followers","following_url":"https://api.github.com/users/maximbaz/following{/other_user}","gists_url":"https://api.github.com/users/maximbaz/gists{/gist_id}","starred_url":"https://api.github.com/users/maximbaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximbaz/subscriptions","organizations_url":"https://api.github.com/users/maximbaz/orgs","repos_url":"https://api.github.com/users/maximbaz/repos","events_url":"https://api.github.com/users/maximbaz/events{/privacy}","received_events_url":"https://api.github.com/users/maximbaz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maximbaz/wire-webapp","description":"👽 Wire for Web — Modern communication. Full privacy.","fork":true,"url":"https://api.github.com/repos/maximbaz/wire-webapp","forks_url":"https://api.github.com/repos/maximbaz/wire-webapp/forks","keys_url":"https://api.github.com/repos/maximbaz/wire-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maximbaz/wire-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maximbaz/wire-webapp/teams","hooks_url":"https://api.github.com/repos/maximbaz/wire-webapp/hooks","issue_events_url":"https://api.github.com/repos/maximbaz/wire-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/maximbaz/wire-webapp/events","assignees_url":"https://api.github.com/repos/maximbaz/wire-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/maximbaz/wire-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/maximbaz/wire-webapp/tags","blobs_url":"https://api.github.com/repos/maximbaz/wire-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maximbaz/wire-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maximbaz/wire-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/maximbaz/wire-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maximbaz/wire-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/maximbaz/wire-webapp/languages","stargazers_url":"https://api.github.com/repos/maximbaz/wire-webapp/stargazers","contributors_url":"https://api.github.com/repos/maximbaz/wire-webapp/contributors","subscribers_url":"https://api.github.com/repos/maximbaz/wire-webapp/subscribers","subscription_url":"https://api.github.com/repos/maximbaz/wire-webapp/subscription","commits_url":"https://api.github.com/repos/maximbaz/wire-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/maximbaz/wire-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/maximbaz/wire-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/maximbaz/wire-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/maximbaz/wire-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/maximbaz/wire-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maximbaz/wire-webapp/merges","archive_url":"https://api.github.com/repos/maximbaz/wire-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maximbaz/wire-webapp/downloads","issues_url":"https://api.github.com/repos/maximbaz/wire-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/maximbaz/wire-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/maximbaz/wire-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/maximbaz/wire-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maximbaz/wire-webapp/labels{/name}","releases_url":"https://api.github.com/repos/maximbaz/wire-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/maximbaz/wire-webapp/deployments","created_at":"2016-12-09T00:14:33Z","updated_at":"2016-12-09T00:14:35Z","pushed_at":"2016-12-21T22:40:47Z","git_url":"git://github.com/maximbaz/wire-webapp.git","ssh_url":"git@github.com:maximbaz/wire-webapp.git","clone_url":"https://github.com/maximbaz/wire-webapp.git","svn_url":"https://github.com/maximbaz/wire-webapp","homepage":"https://app.wire.com","size":11224,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"wireapp:dev","ref":"dev","sha":"6f9fd57f59658bc3f83e7de0eafc736b57bfdbc6","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":63881328,"name":"wire-webapp","full_name":"wireapp/wire-webapp","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-webapp","description":"👽 Wire for Web — Modern communication. Full privacy.","fork":false,"url":"https://api.github.com/repos/wireapp/wire-webapp","forks_url":"https://api.github.com/repos/wireapp/wire-webapp/forks","keys_url":"https://api.github.com/repos/wireapp/wire-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-webapp/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-webapp/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-webapp/events","assignees_url":"https://api.github.com/repos/wireapp/wire-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-webapp/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-webapp/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-webapp/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-webapp/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-webapp/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-webapp/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-webapp/merges","archive_url":"https://api.github.com/repos/wireapp/wire-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-webapp/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-webapp/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-webapp/deployments","created_at":"2016-07-21T15:34:05Z","updated_at":"2016-12-21T14:18:56Z","pushed_at":"2016-12-22T15:11:33Z","git_url":"git://github.com/wireapp/wire-webapp.git","ssh_url":"git@github.com:wireapp/wire-webapp.git","clone_url":"https://github.com/wireapp/wire-webapp.git","svn_url":"https://github.com/wireapp/wire-webapp","homepage":"https://app.wire.com","size":11271,"stargazers_count":535,"watchers_count":535,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":85,"mirror_url":null,"open_issues_count":57,"forks":85,"open_issues":57,"watchers":535,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-webapp/pulls/595"},"html":{"href":"https://github.com/wireapp/wire-webapp/pull/595"},"issue":{"href":"https://api.github.com/repos/wireapp/wire-webapp/issues/595"},"comments":{"href":"https://api.github.com/repos/wireapp/wire-webapp/issues/595/comments"},"review_comments":{"href":"https://api.github.com/repos/wireapp/wire-webapp/pulls/595/comments"},"review_comment":{"href":"https://api.github.com/repos/wireapp/wire-webapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wireapp/wire-webapp/pulls/595/commits"},"statuses":{"href":"https://api.github.com/repos/wireapp/wire-webapp/statuses/124a354e48a98e27da0d520d16b5ba5ee61b71b2"}}}}
{"actor":{"display_login":"gregor"}}