{"action":"created","comment":{"url":"https://api.github.com/repos/ufz/ogs/pulls/comments/86379366","pull_request_review_id":7040844,"id":86379366,"diff_hunk":"@@ -29,6 +32,10 @@ EigenOption::SolverType EigenOption::getSolverType(const std::string &solver_nam\n         return SolverType::BiCGSTAB;\n     if (solver_name == \"SparseLU\")\n         return SolverType::SparseLU;\n+#ifdef USE_EIGEN_UNSUPPORTED\n+    if (solver_name == \"GMRES\")\n+        return SolverType::GMRES;","path":"MathLib/LinAlg/Eigen/EigenOption.cpp","position":16,"original_position":16,"commit_id":"9db688cca3fc833c19c1cca2d787b314c954c355","original_commit_id":"9db688cca3fc833c19c1cca2d787b314c954c355","user":{"login":"chleh","id":10530151,"avatar_url":"https://avatars.githubusercontent.com/u/10530151?v=3","gravatar_id":"","url":"https://api.github.com/users/chleh","html_url":"https://github.com/chleh","followers_url":"https://api.github.com/users/chleh/followers","following_url":"https://api.github.com/users/chleh/following{/other_user}","gists_url":"https://api.github.com/users/chleh/gists{/gist_id}","starred_url":"https://api.github.com/users/chleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chleh/subscriptions","organizations_url":"https://api.github.com/users/chleh/orgs","repos_url":"https://api.github.com/users/chleh/repos","events_url":"https://api.github.com/users/chleh/events{/privacy}","received_events_url":"https://api.github.com/users/chleh/received_events","type":"User","site_admin":false},"body":"Just curious: Is there a specific reason why you don't use LIS' Gmres?","created_at":"2016-11-03T16:03:21Z","updated_at":"2016-11-03T16:03:38Z","html_url":"https://github.com/ufz/ogs/pull/1509#discussion_r86379366","pull_request_url":"https://api.github.com/repos/ufz/ogs/pulls/1509","_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments/86379366"},"html":{"href":"https://github.com/ufz/ogs/pull/1509#discussion_r86379366"},"pull_request":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1509"}}},"pull_request":{"url":"https://api.github.com/repos/ufz/ogs/pulls/1509","id":91967734,"html_url":"https://github.com/ufz/ogs/pull/1509","diff_url":"https://github.com/ufz/ogs/pull/1509.diff","patch_url":"https://github.com/ufz/ogs/pull/1509.patch","issue_url":"https://api.github.com/repos/ufz/ogs/issues/1509","number":1509,"state":"open","locked":false,"title":"support scaling and GMRES in Eigen linear solvers","user":{"login":"norihiro-w","id":800408,"avatar_url":"https://avatars.githubusercontent.com/u/800408?v=3","gravatar_id":"","url":"https://api.github.com/users/norihiro-w","html_url":"https://github.com/norihiro-w","followers_url":"https://api.github.com/users/norihiro-w/followers","following_url":"https://api.github.com/users/norihiro-w/following{/other_user}","gists_url":"https://api.github.com/users/norihiro-w/gists{/gist_id}","starred_url":"https://api.github.com/users/norihiro-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norihiro-w/subscriptions","organizations_url":"https://api.github.com/users/norihiro-w/orgs","repos_url":"https://api.github.com/users/norihiro-w/repos","events_url":"https://api.github.com/users/norihiro-w/events{/privacy}","received_events_url":"https://api.github.com/users/norihiro-w/received_events","type":"User","site_admin":false},"body":"This PR introduces\r\n- add `OGS_USE_EIGEN_UNSUPPORTED` CMake option (default is ON) to support unsupported modules in Eigen. If this option is ON, the followings become available:\r\n- support scaling of a linear system before solve. `<scaling>1</scaling>` should be specified under `<eigen>` tag in a config file.\r\n- support GMRES solver type","created_at":"2016-11-02T13:19:12Z","updated_at":"2016-11-03T16:03:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e75be4b78061082c0a6f3421618d4aab54b9257a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ufz/ogs/pulls/1509/commits","review_comments_url":"https://api.github.com/repos/ufz/ogs/pulls/1509/comments","review_comment_url":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ufz/ogs/issues/1509/comments","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/9db688cca3fc833c19c1cca2d787b314c954c355","head":{"label":"norihiro-w:eigen-unsupported","ref":"eigen-unsupported","sha":"9db688cca3fc833c19c1cca2d787b314c954c355","user":{"login":"norihiro-w","id":800408,"avatar_url":"https://avatars.githubusercontent.com/u/800408?v=3","gravatar_id":"","url":"https://api.github.com/users/norihiro-w","html_url":"https://github.com/norihiro-w","followers_url":"https://api.github.com/users/norihiro-w/followers","following_url":"https://api.github.com/users/norihiro-w/following{/other_user}","gists_url":"https://api.github.com/users/norihiro-w/gists{/gist_id}","starred_url":"https://api.github.com/users/norihiro-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norihiro-w/subscriptions","organizations_url":"https://api.github.com/users/norihiro-w/orgs","repos_url":"https://api.github.com/users/norihiro-w/repos","events_url":"https://api.github.com/users/norihiro-w/events{/privacy}","received_events_url":"https://api.github.com/users/norihiro-w/received_events","type":"User","site_admin":false},"repo":{"id":2612310,"name":"ogs","full_name":"norihiro-w/ogs","owner":{"login":"norihiro-w","id":800408,"avatar_url":"https://avatars.githubusercontent.com/u/800408?v=3","gravatar_id":"","url":"https://api.github.com/users/norihiro-w","html_url":"https://github.com/norihiro-w","followers_url":"https://api.github.com/users/norihiro-w/followers","following_url":"https://api.github.com/users/norihiro-w/following{/other_user}","gists_url":"https://api.github.com/users/norihiro-w/gists{/gist_id}","starred_url":"https://api.github.com/users/norihiro-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norihiro-w/subscriptions","organizations_url":"https://api.github.com/users/norihiro-w/orgs","repos_url":"https://api.github.com/users/norihiro-w/repos","events_url":"https://api.github.com/users/norihiro-w/events{/privacy}","received_events_url":"https://api.github.com/users/norihiro-w/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/norihiro-w/ogs","description":"OGS source code","fork":true,"url":"https://api.github.com/repos/norihiro-w/ogs","forks_url":"https://api.github.com/repos/norihiro-w/ogs/forks","keys_url":"https://api.github.com/repos/norihiro-w/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/norihiro-w/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/norihiro-w/ogs/teams","hooks_url":"https://api.github.com/repos/norihiro-w/ogs/hooks","issue_events_url":"https://api.github.com/repos/norihiro-w/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/norihiro-w/ogs/events","assignees_url":"https://api.github.com/repos/norihiro-w/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/norihiro-w/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/norihiro-w/ogs/tags","blobs_url":"https://api.github.com/repos/norihiro-w/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/norihiro-w/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/norihiro-w/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/norihiro-w/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/norihiro-w/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/norihiro-w/ogs/languages","stargazers_url":"https://api.github.com/repos/norihiro-w/ogs/stargazers","contributors_url":"https://api.github.com/repos/norihiro-w/ogs/contributors","subscribers_url":"https://api.github.com/repos/norihiro-w/ogs/subscribers","subscription_url":"https://api.github.com/repos/norihiro-w/ogs/subscription","commits_url":"https://api.github.com/repos/norihiro-w/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/norihiro-w/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/norihiro-w/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/norihiro-w/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/norihiro-w/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/norihiro-w/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/norihiro-w/ogs/merges","archive_url":"https://api.github.com/repos/norihiro-w/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/norihiro-w/ogs/downloads","issues_url":"https://api.github.com/repos/norihiro-w/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/norihiro-w/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/norihiro-w/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/norihiro-w/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/norihiro-w/ogs/labels{/name}","releases_url":"https://api.github.com/repos/norihiro-w/ogs/releases{/id}","deployments_url":"https://api.github.com/repos/norihiro-w/ogs/deployments","created_at":"2011-10-20T10:16:18Z","updated_at":"2015-03-17T09:09:07Z","pushed_at":"2016-11-03T13:22:53Z","git_url":"git://github.com/norihiro-w/ogs.git","ssh_url":"git@github.com:norihiro-w/ogs.git","clone_url":"https://github.com/norihiro-w/ogs.git","svn_url":"https://github.com/norihiro-w/ogs","homepage":"www.opengeosys.org","size":37337,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"ufz:master","ref":"master","sha":"a75e48a612583ba12c9515900f583d8e17e4a8d6","user":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"repo":{"id":1701384,"name":"ogs","full_name":"ufz/ogs","owner":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ufz/ogs","description":"Experimental OGS-6 source code","fork":false,"url":"https://api.github.com/repos/ufz/ogs","forks_url":"https://api.github.com/repos/ufz/ogs/forks","keys_url":"https://api.github.com/repos/ufz/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ufz/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ufz/ogs/teams","hooks_url":"https://api.github.com/repos/ufz/ogs/hooks","issue_events_url":"https://api.github.com/repos/ufz/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/ufz/ogs/events","assignees_url":"https://api.github.com/repos/ufz/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/ufz/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/ufz/ogs/tags","blobs_url":"https://api.github.com/repos/ufz/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ufz/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ufz/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ufz/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/ufz/ogs/languages","stargazers_url":"https://api.github.com/repos/ufz/ogs/stargazers","contributors_url":"https://api.github.com/repos/ufz/ogs/contributors","subscribers_url":"https://api.github.com/repos/ufz/ogs/subscribers","subscription_url":"https://api.github.com/repos/ufz/ogs/subscription","commits_url":"https://api.github.com/repos/ufz/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ufz/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ufz/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ufz/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ufz/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/ufz/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ufz/ogs/merges","archive_url":"https://api.github.com/repos/ufz/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ufz/ogs/downloads","issues_url":"https://api.github.com/repos/ufz/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/ufz/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/ufz/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/ufz/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ufz/ogs/labels{/name}","releases_url":"https://api.github.com/repos/ufz/ogs/releases{/id}","deployments_url":"https://api.github.com/repos/ufz/ogs/deployments","created_at":"2011-05-04T14:09:57Z","updated_at":"2016-10-24T08:18:46Z","pushed_at":"2016-11-03T16:02:41Z","git_url":"git://github.com/ufz/ogs.git","ssh_url":"git@github.com:ufz/ogs.git","clone_url":"https://github.com/ufz/ogs.git","svn_url":"https://github.com/ufz/ogs","homepage":"www.opengeosys.org","size":20409,"stargazers_count":21,"watchers_count":21,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":101,"forks":54,"open_issues":101,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1509"},"html":{"href":"https://github.com/ufz/ogs/pull/1509"},"issue":{"href":"https://api.github.com/repos/ufz/ogs/issues/1509"},"comments":{"href":"https://api.github.com/repos/ufz/ogs/issues/1509/comments"},"review_comments":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1509/comments"},"review_comment":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1509/commits"},"statuses":{"href":"https://api.github.com/repos/ufz/ogs/statuses/9db688cca3fc833c19c1cca2d787b314c954c355"}}}}
{"actor":{"display_login":"chleh"}}