{"action":"created","comment":{"url":"https://api.github.com/repos/weecology/retriever/pulls/comments/65808997","id":65808997,"diff_hunk":"@@ -426,12 +419,12 @@ def download_files_from_archive(self, url, filenames, filetype=\"zip\",\n \n                 if filetype == 'zip':\n                     archive = zipfile.ZipFile(archivename)\n-                    open_archive_file = archive.open(filename)\n+                    open_archive_file = archive.open(filename, 'rU')","path":"lib/engine.py","position":28,"original_position":28,"commit_id":"282e6c80a5965c9f2f384bd199d45c317cb1b53a","original_commit_id":"282e6c80a5965c9f2f384bd199d45c317cb1b53a","user":{"login":"henrykironde","id":5192965,"avatar_url":"https://avatars.githubusercontent.com/u/5192965?v=3","gravatar_id":"","url":"https://api.github.com/users/henrykironde","html_url":"https://github.com/henrykironde","followers_url":"https://api.github.com/users/henrykironde/followers","following_url":"https://api.github.com/users/henrykironde/following{/other_user}","gists_url":"https://api.github.com/users/henrykironde/gists{/gist_id}","starred_url":"https://api.github.com/users/henrykironde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrykironde/subscriptions","organizations_url":"https://api.github.com/users/henrykironde/orgs","repos_url":"https://api.github.com/users/henrykironde/repos","events_url":"https://api.github.com/users/henrykironde/events{/privacy}","received_events_url":"https://api.github.com/users/henrykironde/received_events","type":"User","site_admin":false},"body":"This looks fine to me. but before changing this. i would recommend dealing with `def download_file(self, url, filename, clean_line_endings=True):`","created_at":"2016-06-04T23:14:18Z","updated_at":"2016-06-04T23:14:18Z","html_url":"https://github.com/weecology/retriever/pull/502#discussion_r65808997","pull_request_url":"https://api.github.com/repos/weecology/retriever/pulls/502","_links":{"self":{"href":"https://api.github.com/repos/weecology/retriever/pulls/comments/65808997"},"html":{"href":"https://github.com/weecology/retriever/pull/502#discussion_r65808997"},"pull_request":{"href":"https://api.github.com/repos/weecology/retriever/pulls/502"}}},"pull_request":{"url":"https://api.github.com/repos/weecology/retriever/pulls/502","id":72599461,"html_url":"https://github.com/weecology/retriever/pull/502","diff_url":"https://github.com/weecology/retriever/pull/502.diff","patch_url":"https://github.com/weecology/retriever/pull/502.patch","issue_url":"https://api.github.com/repos/weecology/retriever/issues/502","number":502,"state":"open","locked":false,"title":"Issue 290: Out of memory error when downloading large dataset","user":{"login":"Deborah-Digges","id":3866405,"avatar_url":"https://avatars.githubusercontent.com/u/3866405?v=3","gravatar_id":"","url":"https://api.github.com/users/Deborah-Digges","html_url":"https://github.com/Deborah-Digges","followers_url":"https://api.github.com/users/Deborah-Digges/followers","following_url":"https://api.github.com/users/Deborah-Digges/following{/other_user}","gists_url":"https://api.github.com/users/Deborah-Digges/gists{/gist_id}","starred_url":"https://api.github.com/users/Deborah-Digges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Deborah-Digges/subscriptions","organizations_url":"https://api.github.com/users/Deborah-Digges/orgs","repos_url":"https://api.github.com/users/Deborah-Digges/repos","events_url":"https://api.github.com/users/Deborah-Digges/events{/privacy}","received_events_url":"https://api.github.com/users/Deborah-Digges/received_events","type":"User","site_admin":false},"body":"I've removed the part where the entire file is being read into memory to clean line endings and have opened the file in 'rU' mode instead.\r\n\r\nHowever, the tests for md5 comparisons for csv, mysql and postgres are all failing with this change.","created_at":"2016-06-04T10:37:06Z","updated_at":"2016-06-04T23:14:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cfbf184554c120f37256195b671d93dd055ae475","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/weecology/retriever/pulls/502/commits","review_comments_url":"https://api.github.com/repos/weecology/retriever/pulls/502/comments","review_comment_url":"https://api.github.com/repos/weecology/retriever/pulls/comments{/number}","comments_url":"https://api.github.com/repos/weecology/retriever/issues/502/comments","statuses_url":"https://api.github.com/repos/weecology/retriever/statuses/282e6c80a5965c9f2f384bd199d45c317cb1b53a","head":{"label":"Deborah-Digges:issue-290","ref":"issue-290","sha":"282e6c80a5965c9f2f384bd199d45c317cb1b53a","user":{"login":"Deborah-Digges","id":3866405,"avatar_url":"https://avatars.githubusercontent.com/u/3866405?v=3","gravatar_id":"","url":"https://api.github.com/users/Deborah-Digges","html_url":"https://github.com/Deborah-Digges","followers_url":"https://api.github.com/users/Deborah-Digges/followers","following_url":"https://api.github.com/users/Deborah-Digges/following{/other_user}","gists_url":"https://api.github.com/users/Deborah-Digges/gists{/gist_id}","starred_url":"https://api.github.com/users/Deborah-Digges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Deborah-Digges/subscriptions","organizations_url":"https://api.github.com/users/Deborah-Digges/orgs","repos_url":"https://api.github.com/users/Deborah-Digges/repos","events_url":"https://api.github.com/users/Deborah-Digges/events{/privacy}","received_events_url":"https://api.github.com/users/Deborah-Digges/received_events","type":"User","site_admin":false},"repo":{"id":59504471,"name":"retriever","full_name":"Deborah-Digges/retriever","owner":{"login":"Deborah-Digges","id":3866405,"avatar_url":"https://avatars.githubusercontent.com/u/3866405?v=3","gravatar_id":"","url":"https://api.github.com/users/Deborah-Digges","html_url":"https://github.com/Deborah-Digges","followers_url":"https://api.github.com/users/Deborah-Digges/followers","following_url":"https://api.github.com/users/Deborah-Digges/following{/other_user}","gists_url":"https://api.github.com/users/Deborah-Digges/gists{/gist_id}","starred_url":"https://api.github.com/users/Deborah-Digges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Deborah-Digges/subscriptions","organizations_url":"https://api.github.com/users/Deborah-Digges/orgs","repos_url":"https://api.github.com/users/Deborah-Digges/repos","events_url":"https://api.github.com/users/Deborah-Digges/events{/privacy}","received_events_url":"https://api.github.com/users/Deborah-Digges/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Deborah-Digges/retriever","description":"Quickly download, clean up, and install ecological datasets into a database management system","fork":true,"url":"https://api.github.com/repos/Deborah-Digges/retriever","forks_url":"https://api.github.com/repos/Deborah-Digges/retriever/forks","keys_url":"https://api.github.com/repos/Deborah-Digges/retriever/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Deborah-Digges/retriever/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Deborah-Digges/retriever/teams","hooks_url":"https://api.github.com/repos/Deborah-Digges/retriever/hooks","issue_events_url":"https://api.github.com/repos/Deborah-Digges/retriever/issues/events{/number}","events_url":"https://api.github.com/repos/Deborah-Digges/retriever/events","assignees_url":"https://api.github.com/repos/Deborah-Digges/retriever/assignees{/user}","branches_url":"https://api.github.com/repos/Deborah-Digges/retriever/branches{/branch}","tags_url":"https://api.github.com/repos/Deborah-Digges/retriever/tags","blobs_url":"https://api.github.com/repos/Deborah-Digges/retriever/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Deborah-Digges/retriever/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Deborah-Digges/retriever/git/refs{/sha}","trees_url":"https://api.github.com/repos/Deborah-Digges/retriever/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Deborah-Digges/retriever/statuses/{sha}","languages_url":"https://api.github.com/repos/Deborah-Digges/retriever/languages","stargazers_url":"https://api.github.com/repos/Deborah-Digges/retriever/stargazers","contributors_url":"https://api.github.com/repos/Deborah-Digges/retriever/contributors","subscribers_url":"https://api.github.com/repos/Deborah-Digges/retriever/subscribers","subscription_url":"https://api.github.com/repos/Deborah-Digges/retriever/subscription","commits_url":"https://api.github.com/repos/Deborah-Digges/retriever/commits{/sha}","git_commits_url":"https://api.github.com/repos/Deborah-Digges/retriever/git/commits{/sha}","comments_url":"https://api.github.com/repos/Deborah-Digges/retriever/comments{/number}","issue_comment_url":"https://api.github.com/repos/Deborah-Digges/retriever/issues/comments{/number}","contents_url":"https://api.github.com/repos/Deborah-Digges/retriever/contents/{+path}","compare_url":"https://api.github.com/repos/Deborah-Digges/retriever/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Deborah-Digges/retriever/merges","archive_url":"https://api.github.com/repos/Deborah-Digges/retriever/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Deborah-Digges/retriever/downloads","issues_url":"https://api.github.com/repos/Deborah-Digges/retriever/issues{/number}","pulls_url":"https://api.github.com/repos/Deborah-Digges/retriever/pulls{/number}","milestones_url":"https://api.github.com/repos/Deborah-Digges/retriever/milestones{/number}","notifications_url":"https://api.github.com/repos/Deborah-Digges/retriever/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Deborah-Digges/retriever/labels{/name}","releases_url":"https://api.github.com/repos/Deborah-Digges/retriever/releases{/id}","deployments_url":"https://api.github.com/repos/Deborah-Digges/retriever/deployments","created_at":"2016-05-23T17:33:16Z","updated_at":"2016-05-23T17:35:02Z","pushed_at":"2016-06-04T10:30:50Z","git_url":"git://github.com/Deborah-Digges/retriever.git","ssh_url":"git@github.com:Deborah-Digges/retriever.git","clone_url":"https://github.com/Deborah-Digges/retriever.git","svn_url":"https://github.com/Deborah-Digges/retriever","homepage":"http://ecodataretriever.org","size":2385,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"weecology:master","ref":"master","sha":"177c4d7cd599c14993a3c0dde30a65abe2e166ad","user":{"login":"weecology","id":1156696,"avatar_url":"https://avatars.githubusercontent.com/u/1156696?v=3","gravatar_id":"","url":"https://api.github.com/users/weecology","html_url":"https://github.com/weecology","followers_url":"https://api.github.com/users/weecology/followers","following_url":"https://api.github.com/users/weecology/following{/other_user}","gists_url":"https://api.github.com/users/weecology/gists{/gist_id}","starred_url":"https://api.github.com/users/weecology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weecology/subscriptions","organizations_url":"https://api.github.com/users/weecology/orgs","repos_url":"https://api.github.com/users/weecology/repos","events_url":"https://api.github.com/users/weecology/events{/privacy}","received_events_url":"https://api.github.com/users/weecology/received_events","type":"Organization","site_admin":false},"repo":{"id":1968190,"name":"retriever","full_name":"weecology/retriever","owner":{"login":"weecology","id":1156696,"avatar_url":"https://avatars.githubusercontent.com/u/1156696?v=3","gravatar_id":"","url":"https://api.github.com/users/weecology","html_url":"https://github.com/weecology","followers_url":"https://api.github.com/users/weecology/followers","following_url":"https://api.github.com/users/weecology/following{/other_user}","gists_url":"https://api.github.com/users/weecology/gists{/gist_id}","starred_url":"https://api.github.com/users/weecology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weecology/subscriptions","organizations_url":"https://api.github.com/users/weecology/orgs","repos_url":"https://api.github.com/users/weecology/repos","events_url":"https://api.github.com/users/weecology/events{/privacy}","received_events_url":"https://api.github.com/users/weecology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/weecology/retriever","description":"Quickly download, clean up, and install ecological datasets into a database management system","fork":false,"url":"https://api.github.com/repos/weecology/retriever","forks_url":"https://api.github.com/repos/weecology/retriever/forks","keys_url":"https://api.github.com/repos/weecology/retriever/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weecology/retriever/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weecology/retriever/teams","hooks_url":"https://api.github.com/repos/weecology/retriever/hooks","issue_events_url":"https://api.github.com/repos/weecology/retriever/issues/events{/number}","events_url":"https://api.github.com/repos/weecology/retriever/events","assignees_url":"https://api.github.com/repos/weecology/retriever/assignees{/user}","branches_url":"https://api.github.com/repos/weecology/retriever/branches{/branch}","tags_url":"https://api.github.com/repos/weecology/retriever/tags","blobs_url":"https://api.github.com/repos/weecology/retriever/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weecology/retriever/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weecology/retriever/git/refs{/sha}","trees_url":"https://api.github.com/repos/weecology/retriever/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weecology/retriever/statuses/{sha}","languages_url":"https://api.github.com/repos/weecology/retriever/languages","stargazers_url":"https://api.github.com/repos/weecology/retriever/stargazers","contributors_url":"https://api.github.com/repos/weecology/retriever/contributors","subscribers_url":"https://api.github.com/repos/weecology/retriever/subscribers","subscription_url":"https://api.github.com/repos/weecology/retriever/subscription","commits_url":"https://api.github.com/repos/weecology/retriever/commits{/sha}","git_commits_url":"https://api.github.com/repos/weecology/retriever/git/commits{/sha}","comments_url":"https://api.github.com/repos/weecology/retriever/comments{/number}","issue_comment_url":"https://api.github.com/repos/weecology/retriever/issues/comments{/number}","contents_url":"https://api.github.com/repos/weecology/retriever/contents/{+path}","compare_url":"https://api.github.com/repos/weecology/retriever/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weecology/retriever/merges","archive_url":"https://api.github.com/repos/weecology/retriever/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weecology/retriever/downloads","issues_url":"https://api.github.com/repos/weecology/retriever/issues{/number}","pulls_url":"https://api.github.com/repos/weecology/retriever/pulls{/number}","milestones_url":"https://api.github.com/repos/weecology/retriever/milestones{/number}","notifications_url":"https://api.github.com/repos/weecology/retriever/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weecology/retriever/labels{/name}","releases_url":"https://api.github.com/repos/weecology/retriever/releases{/id}","deployments_url":"https://api.github.com/repos/weecology/retriever/deployments","created_at":"2011-06-28T19:01:15Z","updated_at":"2016-05-23T12:43:15Z","pushed_at":"2016-06-04T21:39:19Z","git_url":"git://github.com/weecology/retriever.git","ssh_url":"git@github.com:weecology/retriever.git","clone_url":"https://github.com/weecology/retriever.git","svn_url":"https://github.com/weecology/retriever","homepage":"http://ecodataretriever.org","size":47899,"stargazers_count":66,"watchers_count":66,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":33,"mirror_url":null,"open_issues_count":69,"forks":33,"open_issues":69,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/weecology/retriever/pulls/502"},"html":{"href":"https://github.com/weecology/retriever/pull/502"},"issue":{"href":"https://api.github.com/repos/weecology/retriever/issues/502"},"comments":{"href":"https://api.github.com/repos/weecology/retriever/issues/502/comments"},"review_comments":{"href":"https://api.github.com/repos/weecology/retriever/pulls/502/comments"},"review_comment":{"href":"https://api.github.com/repos/weecology/retriever/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/weecology/retriever/pulls/502/commits"},"statuses":{"href":"https://api.github.com/repos/weecology/retriever/statuses/282e6c80a5965c9f2f384bd199d45c317cb1b53a"}}}}
{"actor":{"display_login":"henrykironde"}}