{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/comments/58793166","id":58793166,"diff_hunk":"@@ -1745,31 +1745,36 @@ VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkAcquireNextImageKHR(VkDevice de\n     if ((semaphore == VK_NULL_HANDLE) && (fence == VK_NULL_HANDLE)) {\n         skipCall |= LOG_ERROR(VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, device, \"VkDevice\", SWAPCHAIN_NO_SYNC_FOR_ACQUIRE,\n                               \"%s() called with both the semaphore and fence parameters set to \"\n-                              \"VK_NULL_HANDLE (at least one should be used).\", __FUNCTION__);\n+                              \"VK_NULL_HANDLE (at least one should be used)\\n.\", __FUNCTION__);\n     }\n     SwpSwapchain *pSwapchain = &my_data->swapchainMap[swapchain];\n-    if (pSwapchain) {\n-        // Look to see if the application is trying to own too many images at\n-        // the same time (i.e. not leave any to display):\n-        uint32_t imagesOwnedByApp = 0;\n+    SwpPhysicalDevice *pPhysicalDevice = pDevice->pPhysicalDevice;\n+    if (pSwapchain && pPhysicalDevice && pPhysicalDevice->gotSurfaceCapabilities) {\n+        // Look to see if the application has already acquired the maximum\n+        // number of images, and this will push it past the spec-defined\n+        // limits:\n+        uint32_t minImageCount = pPhysicalDevice->surfaceCapabilities.minImageCount;\n+        uint32_t imagesAcquiredByApp = 0;\n         for (uint32_t i = 0; i < pSwapchain->imageCount; i++) {\n             if (pSwapchain->images[i].ownedByApp) {","path":"layers/swapchain.cpp","position":20,"original_position":20,"commit_id":"628aaaf1a4ab92c4196636e5d71cb12172e81d31","original_commit_id":"628aaaf1a4ab92c4196636e5d71cb12172e81d31","user":{"login":"courtney-g","id":851793,"avatar_url":"https://avatars.githubusercontent.com/u/851793?v=3","gravatar_id":"","url":"https://api.github.com/users/courtney-g","html_url":"https://github.com/courtney-g","followers_url":"https://api.github.com/users/courtney-g/followers","following_url":"https://api.github.com/users/courtney-g/following{/other_user}","gists_url":"https://api.github.com/users/courtney-g/gists{/gist_id}","starred_url":"https://api.github.com/users/courtney-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/courtney-g/subscriptions","organizations_url":"https://api.github.com/users/courtney-g/orgs","repos_url":"https://api.github.com/users/courtney-g/repos","events_url":"https://api.github.com/users/courtney-g/events{/privacy}","received_events_url":"https://api.github.com/users/courtney-g/received_events","type":"User","site_admin":false},"body":"Want to change the structure field as well? ownedByApp => acquiredByApp","created_at":"2016-04-06T22:27:59Z","updated_at":"2016-04-06T22:27:59Z","html_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/289#discussion_r58793166","pull_request_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/289","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/comments/58793166"},"html":{"href":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/289#discussion_r58793166"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/289"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/289","id":65544300,"html_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/289","diff_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/289.diff","patch_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/289.patch","issue_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/289","number":289,"state":"open","locked":false,"title":"layers: Change the test about \"too many images\".","user":{"login":"ianelliottus","id":16325331,"avatar_url":"https://avatars.githubusercontent.com/u/16325331?v=3","gravatar_id":"","url":"https://api.github.com/users/ianelliottus","html_url":"https://github.com/ianelliottus","followers_url":"https://api.github.com/users/ianelliottus/followers","following_url":"https://api.github.com/users/ianelliottus/following{/other_user}","gists_url":"https://api.github.com/users/ianelliottus/gists{/gist_id}","starred_url":"https://api.github.com/users/ianelliottus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianelliottus/subscriptions","organizations_url":"https://api.github.com/users/ianelliottus/orgs","repos_url":"https://api.github.com/users/ianelliottus/repos","events_url":"https://api.github.com/users/ianelliottus/events{/privacy}","received_events_url":"https://api.github.com/users/ianelliottus/received_events","type":"User","site_admin":false},"body":"Given new spec language coming out in early April (clarifying various aspects\r\nof acquiring presentable images), a change was needed to the WSI-swapchain\r\nvalidation layer.  The new validate-layer test will work for \"BlitModel\"\r\ndrivers that advertise a minImageCount of 1.  Failing the test now results in\r\nan error instead of a performance warning.","created_at":"2016-04-06T22:06:22Z","updated_at":"2016-04-06T22:27:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c303ae394a8711fa150774bbc23af955ffbd1f49","assignee":{"login":"ianelliottus","id":16325331,"avatar_url":"https://avatars.githubusercontent.com/u/16325331?v=3","gravatar_id":"","url":"https://api.github.com/users/ianelliottus","html_url":"https://github.com/ianelliottus","followers_url":"https://api.github.com/users/ianelliottus/followers","following_url":"https://api.github.com/users/ianelliottus/following{/other_user}","gists_url":"https://api.github.com/users/ianelliottus/gists{/gist_id}","starred_url":"https://api.github.com/users/ianelliottus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianelliottus/subscriptions","organizations_url":"https://api.github.com/users/ianelliottus/orgs","repos_url":"https://api.github.com/users/ianelliottus/repos","events_url":"https://api.github.com/users/ianelliottus/events{/privacy}","received_events_url":"https://api.github.com/users/ianelliottus/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/289/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/289/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/289/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/statuses/628aaaf1a4ab92c4196636e5d71cb12172e81d31","head":{"label":"KhronosGroup:ian_160406_SpecMR1247","ref":"ian_160406_SpecMR1247","sha":"628aaaf1a4ab92c4196636e5d71cb12172e81d31","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":51507157,"name":"Vulkan-LoaderAndValidationLayers","full_name":"KhronosGroup/Vulkan-LoaderAndValidationLayers","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers","description":"Vulkan loader and validation layers","fork":false,"url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers","forks_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/forks","keys_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/events","assignees_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/merges","archive_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/deployments","created_at":"2016-02-11T10:16:16Z","updated_at":"2016-04-06T18:28:27Z","pushed_at":"2016-04-06T22:06:22Z","git_url":"git://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers.git","ssh_url":"git@github.com:KhronosGroup/Vulkan-LoaderAndValidationLayers.git","clone_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers.git","svn_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers","homepage":null,"size":45605,"stargazers_count":160,"watchers_count":160,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":55,"forks":42,"open_issues":55,"watchers":160,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"b5d4c1684e41455cb2da487c808fd72070b564d2","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":51507157,"name":"Vulkan-LoaderAndValidationLayers","full_name":"KhronosGroup/Vulkan-LoaderAndValidationLayers","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers","description":"Vulkan loader and validation layers","fork":false,"url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers","forks_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/forks","keys_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/events","assignees_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/merges","archive_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/deployments","created_at":"2016-02-11T10:16:16Z","updated_at":"2016-04-06T18:28:27Z","pushed_at":"2016-04-06T22:06:22Z","git_url":"git://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers.git","ssh_url":"git@github.com:KhronosGroup/Vulkan-LoaderAndValidationLayers.git","clone_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers.git","svn_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers","homepage":null,"size":45605,"stargazers_count":160,"watchers_count":160,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":55,"forks":42,"open_issues":55,"watchers":160,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/289"},"html":{"href":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/289"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/289"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/289/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/289/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/289/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/statuses/628aaaf1a4ab92c4196636e5d71cb12172e81d31"}}}}