{"action":"closed","number":1082,"pull_request":{"url":"https://api.github.com/repos/apache/storm/pulls/1082","id":58394499,"html_url":"https://github.com/apache/storm/pull/1082","diff_url":"https://github.com/apache/storm/pull/1082.diff","patch_url":"https://github.com/apache/storm/pull/1082.patch","issue_url":"https://api.github.com/repos/apache/storm/issues/1082","number":1082,"state":"closed","locked":false,"title":"STORM-1492 With nimbus.seeds set to default, a nimbus for localhost may appear \"Offline\"","user":{"login":"HeartSaVioR","id":1317309,"avatar_url":"https://avatars.githubusercontent.com/u/1317309?v=3","gravatar_id":"","url":"https://api.github.com/users/HeartSaVioR","html_url":"https://github.com/HeartSaVioR","followers_url":"https://api.github.com/users/HeartSaVioR/followers","following_url":"https://api.github.com/users/HeartSaVioR/following{/other_user}","gists_url":"https://api.github.com/users/HeartSaVioR/gists{/gist_id}","starred_url":"https://api.github.com/users/HeartSaVioR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeartSaVioR/subscriptions","organizations_url":"https://api.github.com/users/HeartSaVioR/orgs","repos_url":"https://api.github.com/users/HeartSaVioR/repos","events_url":"https://api.github.com/users/HeartSaVioR/events{/privacy}","received_events_url":"https://api.github.com/users/HeartSaVioR/received_events","type":"User","site_admin":false},"body":"First of all, AFAIK, it's just an issue of API output, and it doesn't hurt functionality although we don't fix it.\r\n\r\n* when determining nimbus addresses from nimbus.seeds, filter out localhost addresses\r\n  * localhost address: 127.0.0.1, localhost, 0:0:0:0:0:0:0:1\r\n* there may be a chance that nimbus (localhost) is not reachable so we can't get info from alive-nimbuses\r\n  * but it means ui process itself can't reach nimbus so we can ignore this case\r\n* there may be another change that user writes nimbus.seeds both unreachable localhost address and other reachable nimbuses fqdn\r\n  * ui process can reach other nimbus and localhost itself is lost\r\n  * but I think we can treat it as configuration error","created_at":"2016-02-05T06:55:21Z","updated_at":"2016-02-05T07:22:01Z","closed_at":"2016-02-05T07:22:01Z","merged_at":null,"merge_commit_sha":"c854cc26114c52d89e4e5b7ecfbd80746661b0aa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/storm/pulls/1082/commits","review_comments_url":"https://api.github.com/repos/apache/storm/pulls/1082/comments","review_comment_url":"https://api.github.com/repos/apache/storm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/storm/issues/1082/comments","statuses_url":"https://api.github.com/repos/apache/storm/statuses/125fd47a7c428e5747ca2cb11fe31ad129311aa3","head":{"label":"HeartSaVioR:STORM-1492","ref":"STORM-1492","sha":"125fd47a7c428e5747ca2cb11fe31ad129311aa3","user":{"login":"HeartSaVioR","id":1317309,"avatar_url":"https://avatars.githubusercontent.com/u/1317309?v=3","gravatar_id":"","url":"https://api.github.com/users/HeartSaVioR","html_url":"https://github.com/HeartSaVioR","followers_url":"https://api.github.com/users/HeartSaVioR/followers","following_url":"https://api.github.com/users/HeartSaVioR/following{/other_user}","gists_url":"https://api.github.com/users/HeartSaVioR/gists{/gist_id}","starred_url":"https://api.github.com/users/HeartSaVioR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeartSaVioR/subscriptions","organizations_url":"https://api.github.com/users/HeartSaVioR/orgs","repos_url":"https://api.github.com/users/HeartSaVioR/repos","events_url":"https://api.github.com/users/HeartSaVioR/events{/privacy}","received_events_url":"https://api.github.com/users/HeartSaVioR/received_events","type":"User","site_admin":false},"repo":{"id":24730103,"name":"storm","full_name":"HeartSaVioR/storm","owner":{"login":"HeartSaVioR","id":1317309,"avatar_url":"https://avatars.githubusercontent.com/u/1317309?v=3","gravatar_id":"","url":"https://api.github.com/users/HeartSaVioR","html_url":"https://github.com/HeartSaVioR","followers_url":"https://api.github.com/users/HeartSaVioR/followers","following_url":"https://api.github.com/users/HeartSaVioR/following{/other_user}","gists_url":"https://api.github.com/users/HeartSaVioR/gists{/gist_id}","starred_url":"https://api.github.com/users/HeartSaVioR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeartSaVioR/subscriptions","organizations_url":"https://api.github.com/users/HeartSaVioR/orgs","repos_url":"https://api.github.com/users/HeartSaVioR/repos","events_url":"https://api.github.com/users/HeartSaVioR/events{/privacy}","received_events_url":"https://api.github.com/users/HeartSaVioR/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HeartSaVioR/storm","description":"Mirror of Apache Storm","fork":true,"url":"https://api.github.com/repos/HeartSaVioR/storm","forks_url":"https://api.github.com/repos/HeartSaVioR/storm/forks","keys_url":"https://api.github.com/repos/HeartSaVioR/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HeartSaVioR/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HeartSaVioR/storm/teams","hooks_url":"https://api.github.com/repos/HeartSaVioR/storm/hooks","issue_events_url":"https://api.github.com/repos/HeartSaVioR/storm/issues/events{/number}","events_url":"https://api.github.com/repos/HeartSaVioR/storm/events","assignees_url":"https://api.github.com/repos/HeartSaVioR/storm/assignees{/user}","branches_url":"https://api.github.com/repos/HeartSaVioR/storm/branches{/branch}","tags_url":"https://api.github.com/repos/HeartSaVioR/storm/tags","blobs_url":"https://api.github.com/repos/HeartSaVioR/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HeartSaVioR/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HeartSaVioR/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/HeartSaVioR/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HeartSaVioR/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/HeartSaVioR/storm/languages","stargazers_url":"https://api.github.com/repos/HeartSaVioR/storm/stargazers","contributors_url":"https://api.github.com/repos/HeartSaVioR/storm/contributors","subscribers_url":"https://api.github.com/repos/HeartSaVioR/storm/subscribers","subscription_url":"https://api.github.com/repos/HeartSaVioR/storm/subscription","commits_url":"https://api.github.com/repos/HeartSaVioR/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/HeartSaVioR/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/HeartSaVioR/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/HeartSaVioR/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/HeartSaVioR/storm/contents/{+path}","compare_url":"https://api.github.com/repos/HeartSaVioR/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HeartSaVioR/storm/merges","archive_url":"https://api.github.com/repos/HeartSaVioR/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HeartSaVioR/storm/downloads","issues_url":"https://api.github.com/repos/HeartSaVioR/storm/issues{/number}","pulls_url":"https://api.github.com/repos/HeartSaVioR/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/HeartSaVioR/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/HeartSaVioR/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HeartSaVioR/storm/labels{/name}","releases_url":"https://api.github.com/repos/HeartSaVioR/storm/releases{/id}","deployments_url":"https://api.github.com/repos/HeartSaVioR/storm/deployments","created_at":"2014-10-02T18:00:01Z","updated_at":"2016-01-13T23:55:58Z","pushed_at":"2016-02-05T06:51:53Z","git_url":"git://github.com/HeartSaVioR/storm.git","ssh_url":"git@github.com:HeartSaVioR/storm.git","clone_url":"https://github.com/HeartSaVioR/storm.git","svn_url":"https://github.com/HeartSaVioR/storm","homepage":null,"size":101478,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"cd2f2028b16f978b7e4eb07956a9cb573a5f2d07","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":14135470,"name":"storm","full_name":"apache/storm","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/storm","description":"Mirror of Apache Storm","fork":false,"url":"https://api.github.com/repos/apache/storm","forks_url":"https://api.github.com/repos/apache/storm/forks","keys_url":"https://api.github.com/repos/apache/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/storm/teams","hooks_url":"https://api.github.com/repos/apache/storm/hooks","issue_events_url":"https://api.github.com/repos/apache/storm/issues/events{/number}","events_url":"https://api.github.com/repos/apache/storm/events","assignees_url":"https://api.github.com/repos/apache/storm/assignees{/user}","branches_url":"https://api.github.com/repos/apache/storm/branches{/branch}","tags_url":"https://api.github.com/repos/apache/storm/tags","blobs_url":"https://api.github.com/repos/apache/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/storm/languages","stargazers_url":"https://api.github.com/repos/apache/storm/stargazers","contributors_url":"https://api.github.com/repos/apache/storm/contributors","subscribers_url":"https://api.github.com/repos/apache/storm/subscribers","subscription_url":"https://api.github.com/repos/apache/storm/subscription","commits_url":"https://api.github.com/repos/apache/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/storm/contents/{+path}","compare_url":"https://api.github.com/repos/apache/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/storm/merges","archive_url":"https://api.github.com/repos/apache/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/storm/downloads","issues_url":"https://api.github.com/repos/apache/storm/issues{/number}","pulls_url":"https://api.github.com/repos/apache/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/storm/labels{/name}","releases_url":"https://api.github.com/repos/apache/storm/releases{/id}","deployments_url":"https://api.github.com/repos/apache/storm/deployments","created_at":"2013-11-05T08:00:14Z","updated_at":"2016-02-05T04:43:55Z","pushed_at":"2016-02-05T06:55:22Z","git_url":"git://github.com/apache/storm.git","ssh_url":"git@github.com:apache/storm.git","clone_url":"https://github.com/apache/storm.git","svn_url":"https://github.com/apache/storm","homepage":null,"size":158338,"stargazers_count":2825,"watchers_count":2825,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2109,"mirror_url":"git://git.apache.org/storm.git","open_issues_count":79,"forks":2109,"open_issues":79,"watchers":2825,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/1082"},"html":{"href":"https://github.com/apache/storm/pull/1082"},"issue":{"href":"https://api.github.com/repos/apache/storm/issues/1082"},"comments":{"href":"https://api.github.com/repos/apache/storm/issues/1082/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/storm/pulls/1082/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/storm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/storm/pulls/1082/commits"},"statuses":{"href":"https://api.github.com/repos/apache/storm/statuses/125fd47a7c428e5747ca2cb11fe31ad129311aa3"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":7,"deletions":4,"changed_files":2}}