{"action":"closed","number":13124,"pull_request":{"url":"https://api.github.com/repos/modxcms/revolution/pulls/13124","id":84783863,"html_url":"https://github.com/modxcms/revolution/pull/13124","diff_url":"https://github.com/modxcms/revolution/pull/13124.diff","patch_url":"https://github.com/modxcms/revolution/pull/13124.patch","issue_url":"https://api.github.com/repos/modxcms/revolution/issues/13124","number":13124,"state":"closed","locked":false,"title":"Fixed addEventListener function","user":{"login":"sergant210","id":4679725,"avatar_url":"https://avatars.githubusercontent.com/u/4679725?v=3","gravatar_id":"","url":"https://api.github.com/users/sergant210","html_url":"https://github.com/sergant210","followers_url":"https://api.github.com/users/sergant210/followers","following_url":"https://api.github.com/users/sergant210/following{/other_user}","gists_url":"https://api.github.com/users/sergant210/gists{/gist_id}","starred_url":"https://api.github.com/users/sergant210/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergant210/subscriptions","organizations_url":"https://api.github.com/users/sergant210/orgs","repos_url":"https://api.github.com/users/sergant210/repos","events_url":"https://api.github.com/users/sergant210/events{/privacy}","received_events_url":"https://api.github.com/users/sergant210/received_events","type":"User","site_admin":false},"body":"### What does it do?\r\nAdded the plugin ID to the plugin map as an array key.\r\n\r\n### Why is it needed?\r\nNow this function added plugin to the plugin map without any key - \r\n```$this->eventMap[$event][]= $pluginId;```\r\nBut the \"InvokeEvent\" function uses array key to get the plugin object - \r\n```\r\nforeach ($this->eventMap[$eventName] as $pluginId => $pluginPropset) {\r\n    ...\r\n    $plugin= $this->getObject('modPlugin', array ('id' => intval($pluginId), 'disabled' => '0'), true);\r\n    ...\r\n}\r\n```\r\nSo the plugin added via the \"addEventListener\" functoin will not run.\r\n\r\n### Related issue(s)/PR(s)\r\nNone.\r\n\r\n","created_at":"2016-09-11T11:25:53Z","updated_at":"2016-09-28T13:20:33Z","closed_at":"2016-09-28T13:20:32Z","merged_at":"2016-09-28T13:20:32Z","merge_commit_sha":"c42cf59dd7c2c8e07c5229db5e0d0cec1927c94f","assignee":{"login":"rtripault","id":300920,"avatar_url":"https://avatars.githubusercontent.com/u/300920?v=3","gravatar_id":"","url":"https://api.github.com/users/rtripault","html_url":"https://github.com/rtripault","followers_url":"https://api.github.com/users/rtripault/followers","following_url":"https://api.github.com/users/rtripault/following{/other_user}","gists_url":"https://api.github.com/users/rtripault/gists{/gist_id}","starred_url":"https://api.github.com/users/rtripault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtripault/subscriptions","organizations_url":"https://api.github.com/users/rtripault/orgs","repos_url":"https://api.github.com/users/rtripault/repos","events_url":"https://api.github.com/users/rtripault/events{/privacy}","received_events_url":"https://api.github.com/users/rtripault/received_events","type":"User","site_admin":false},"assignees":[{"login":"rtripault","id":300920,"avatar_url":"https://avatars.githubusercontent.com/u/300920?v=3","gravatar_id":"","url":"https://api.github.com/users/rtripault","html_url":"https://github.com/rtripault","followers_url":"https://api.github.com/users/rtripault/followers","following_url":"https://api.github.com/users/rtripault/following{/other_user}","gists_url":"https://api.github.com/users/rtripault/gists{/gist_id}","starred_url":"https://api.github.com/users/rtripault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtripault/subscriptions","organizations_url":"https://api.github.com/users/rtripault/orgs","repos_url":"https://api.github.com/users/rtripault/repos","events_url":"https://api.github.com/users/rtripault/events{/privacy}","received_events_url":"https://api.github.com/users/rtripault/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/modxcms/revolution/milestones/71","html_url":"https://github.com/modxcms/revolution/milestones/v2.5.2","labels_url":"https://api.github.com/repos/modxcms/revolution/milestones/71/labels","id":1956534,"number":71,"title":"v2.5.2","description":null,"creator":{"login":"Jako","id":148371,"avatar_url":"https://avatars.githubusercontent.com/u/148371?v=3","gravatar_id":"","url":"https://api.github.com/users/Jako","html_url":"https://github.com/Jako","followers_url":"https://api.github.com/users/Jako/followers","following_url":"https://api.github.com/users/Jako/following{/other_user}","gists_url":"https://api.github.com/users/Jako/gists{/gist_id}","starred_url":"https://api.github.com/users/Jako/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jako/subscriptions","organizations_url":"https://api.github.com/users/Jako/orgs","repos_url":"https://api.github.com/users/Jako/repos","events_url":"https://api.github.com/users/Jako/events{/privacy}","received_events_url":"https://api.github.com/users/Jako/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":12,"state":"open","created_at":"2016-08-22T22:17:52Z","updated_at":"2016-09-28T13:20:33Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/modxcms/revolution/pulls/13124/commits","review_comments_url":"https://api.github.com/repos/modxcms/revolution/pulls/13124/comments","review_comment_url":"https://api.github.com/repos/modxcms/revolution/pulls/comments{/number}","comments_url":"https://api.github.com/repos/modxcms/revolution/issues/13124/comments","statuses_url":"https://api.github.com/repos/modxcms/revolution/statuses/c42cf59dd7c2c8e07c5229db5e0d0cec1927c94f","head":{"label":"sergant210:patch-7","ref":"patch-7","sha":"c42cf59dd7c2c8e07c5229db5e0d0cec1927c94f","user":{"login":"sergant210","id":4679725,"avatar_url":"https://avatars.githubusercontent.com/u/4679725?v=3","gravatar_id":"","url":"https://api.github.com/users/sergant210","html_url":"https://github.com/sergant210","followers_url":"https://api.github.com/users/sergant210/followers","following_url":"https://api.github.com/users/sergant210/following{/other_user}","gists_url":"https://api.github.com/users/sergant210/gists{/gist_id}","starred_url":"https://api.github.com/users/sergant210/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergant210/subscriptions","organizations_url":"https://api.github.com/users/sergant210/orgs","repos_url":"https://api.github.com/users/sergant210/repos","events_url":"https://api.github.com/users/sergant210/events{/privacy}","received_events_url":"https://api.github.com/users/sergant210/received_events","type":"User","site_admin":false},"repo":{"id":43078377,"name":"revolution","full_name":"sergant210/revolution","owner":{"login":"sergant210","id":4679725,"avatar_url":"https://avatars.githubusercontent.com/u/4679725?v=3","gravatar_id":"","url":"https://api.github.com/users/sergant210","html_url":"https://github.com/sergant210","followers_url":"https://api.github.com/users/sergant210/followers","following_url":"https://api.github.com/users/sergant210/following{/other_user}","gists_url":"https://api.github.com/users/sergant210/gists{/gist_id}","starred_url":"https://api.github.com/users/sergant210/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergant210/subscriptions","organizations_url":"https://api.github.com/users/sergant210/orgs","repos_url":"https://api.github.com/users/sergant210/repos","events_url":"https://api.github.com/users/sergant210/events{/privacy}","received_events_url":"https://api.github.com/users/sergant210/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sergant210/revolution","description":"MODX Revolution - Content Application Platform","fork":true,"url":"https://api.github.com/repos/sergant210/revolution","forks_url":"https://api.github.com/repos/sergant210/revolution/forks","keys_url":"https://api.github.com/repos/sergant210/revolution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sergant210/revolution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sergant210/revolution/teams","hooks_url":"https://api.github.com/repos/sergant210/revolution/hooks","issue_events_url":"https://api.github.com/repos/sergant210/revolution/issues/events{/number}","events_url":"https://api.github.com/repos/sergant210/revolution/events","assignees_url":"https://api.github.com/repos/sergant210/revolution/assignees{/user}","branches_url":"https://api.github.com/repos/sergant210/revolution/branches{/branch}","tags_url":"https://api.github.com/repos/sergant210/revolution/tags","blobs_url":"https://api.github.com/repos/sergant210/revolution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sergant210/revolution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sergant210/revolution/git/refs{/sha}","trees_url":"https://api.github.com/repos/sergant210/revolution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sergant210/revolution/statuses/{sha}","languages_url":"https://api.github.com/repos/sergant210/revolution/languages","stargazers_url":"https://api.github.com/repos/sergant210/revolution/stargazers","contributors_url":"https://api.github.com/repos/sergant210/revolution/contributors","subscribers_url":"https://api.github.com/repos/sergant210/revolution/subscribers","subscription_url":"https://api.github.com/repos/sergant210/revolution/subscription","commits_url":"https://api.github.com/repos/sergant210/revolution/commits{/sha}","git_commits_url":"https://api.github.com/repos/sergant210/revolution/git/commits{/sha}","comments_url":"https://api.github.com/repos/sergant210/revolution/comments{/number}","issue_comment_url":"https://api.github.com/repos/sergant210/revolution/issues/comments{/number}","contents_url":"https://api.github.com/repos/sergant210/revolution/contents/{+path}","compare_url":"https://api.github.com/repos/sergant210/revolution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sergant210/revolution/merges","archive_url":"https://api.github.com/repos/sergant210/revolution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sergant210/revolution/downloads","issues_url":"https://api.github.com/repos/sergant210/revolution/issues{/number}","pulls_url":"https://api.github.com/repos/sergant210/revolution/pulls{/number}","milestones_url":"https://api.github.com/repos/sergant210/revolution/milestones{/number}","notifications_url":"https://api.github.com/repos/sergant210/revolution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sergant210/revolution/labels{/name}","releases_url":"https://api.github.com/repos/sergant210/revolution/releases{/id}","deployments_url":"https://api.github.com/repos/sergant210/revolution/deployments","created_at":"2015-09-24T16:18:33Z","updated_at":"2015-09-24T16:18:48Z","pushed_at":"2016-09-27T21:14:11Z","git_url":"git://github.com/sergant210/revolution.git","ssh_url":"git@github.com:sergant210/revolution.git","clone_url":"https://github.com/sergant210/revolution.git","svn_url":"https://github.com/sergant210/revolution","homepage":"http://rtfm.modx.com/revolution/2.x/","size":51079,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.x"}},"base":{"label":"modxcms:2.x","ref":"2.x","sha":"fbf126690f6ce903faeaeb9f1d958211fc2203c9","user":{"login":"modxcms","id":232723,"avatar_url":"https://avatars.githubusercontent.com/u/232723?v=3","gravatar_id":"","url":"https://api.github.com/users/modxcms","html_url":"https://github.com/modxcms","followers_url":"https://api.github.com/users/modxcms/followers","following_url":"https://api.github.com/users/modxcms/following{/other_user}","gists_url":"https://api.github.com/users/modxcms/gists{/gist_id}","starred_url":"https://api.github.com/users/modxcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modxcms/subscriptions","organizations_url":"https://api.github.com/users/modxcms/orgs","repos_url":"https://api.github.com/users/modxcms/repos","events_url":"https://api.github.com/users/modxcms/events{/privacy}","received_events_url":"https://api.github.com/users/modxcms/received_events","type":"Organization","site_admin":false},"repo":{"id":806201,"name":"revolution","full_name":"modxcms/revolution","owner":{"login":"modxcms","id":232723,"avatar_url":"https://avatars.githubusercontent.com/u/232723?v=3","gravatar_id":"","url":"https://api.github.com/users/modxcms","html_url":"https://github.com/modxcms","followers_url":"https://api.github.com/users/modxcms/followers","following_url":"https://api.github.com/users/modxcms/following{/other_user}","gists_url":"https://api.github.com/users/modxcms/gists{/gist_id}","starred_url":"https://api.github.com/users/modxcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modxcms/subscriptions","organizations_url":"https://api.github.com/users/modxcms/orgs","repos_url":"https://api.github.com/users/modxcms/repos","events_url":"https://api.github.com/users/modxcms/events{/privacy}","received_events_url":"https://api.github.com/users/modxcms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/modxcms/revolution","description":"MODX Revolution - Content Management Framework","fork":false,"url":"https://api.github.com/repos/modxcms/revolution","forks_url":"https://api.github.com/repos/modxcms/revolution/forks","keys_url":"https://api.github.com/repos/modxcms/revolution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/modxcms/revolution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/modxcms/revolution/teams","hooks_url":"https://api.github.com/repos/modxcms/revolution/hooks","issue_events_url":"https://api.github.com/repos/modxcms/revolution/issues/events{/number}","events_url":"https://api.github.com/repos/modxcms/revolution/events","assignees_url":"https://api.github.com/repos/modxcms/revolution/assignees{/user}","branches_url":"https://api.github.com/repos/modxcms/revolution/branches{/branch}","tags_url":"https://api.github.com/repos/modxcms/revolution/tags","blobs_url":"https://api.github.com/repos/modxcms/revolution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/modxcms/revolution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/modxcms/revolution/git/refs{/sha}","trees_url":"https://api.github.com/repos/modxcms/revolution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/modxcms/revolution/statuses/{sha}","languages_url":"https://api.github.com/repos/modxcms/revolution/languages","stargazers_url":"https://api.github.com/repos/modxcms/revolution/stargazers","contributors_url":"https://api.github.com/repos/modxcms/revolution/contributors","subscribers_url":"https://api.github.com/repos/modxcms/revolution/subscribers","subscription_url":"https://api.github.com/repos/modxcms/revolution/subscription","commits_url":"https://api.github.com/repos/modxcms/revolution/commits{/sha}","git_commits_url":"https://api.github.com/repos/modxcms/revolution/git/commits{/sha}","comments_url":"https://api.github.com/repos/modxcms/revolution/comments{/number}","issue_comment_url":"https://api.github.com/repos/modxcms/revolution/issues/comments{/number}","contents_url":"https://api.github.com/repos/modxcms/revolution/contents/{+path}","compare_url":"https://api.github.com/repos/modxcms/revolution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/modxcms/revolution/merges","archive_url":"https://api.github.com/repos/modxcms/revolution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/modxcms/revolution/downloads","issues_url":"https://api.github.com/repos/modxcms/revolution/issues{/number}","pulls_url":"https://api.github.com/repos/modxcms/revolution/pulls{/number}","milestones_url":"https://api.github.com/repos/modxcms/revolution/milestones{/number}","notifications_url":"https://api.github.com/repos/modxcms/revolution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/modxcms/revolution/labels{/name}","releases_url":"https://api.github.com/repos/modxcms/revolution/releases{/id}","deployments_url":"https://api.github.com/repos/modxcms/revolution/deployments","created_at":"2010-07-29T21:03:57Z","updated_at":"2016-09-27T12:17:48Z","pushed_at":"2016-09-28T13:20:30Z","git_url":"git://github.com/modxcms/revolution.git","ssh_url":"git@github.com:modxcms/revolution.git","clone_url":"https://github.com/modxcms/revolution.git","svn_url":"https://github.com/modxcms/revolution","homepage":"https://modx.com/","size":69863,"stargazers_count":784,"watchers_count":784,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":416,"mirror_url":null,"open_issues_count":896,"forks":416,"open_issues":896,"watchers":784,"default_branch":"2.x"}},"_links":{"self":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/13124"},"html":{"href":"https://github.com/modxcms/revolution/pull/13124"},"issue":{"href":"https://api.github.com/repos/modxcms/revolution/issues/13124"},"comments":{"href":"https://api.github.com/repos/modxcms/revolution/issues/13124/comments"},"review_comments":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/13124/comments"},"review_comment":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/13124/commits"},"statuses":{"href":"https://api.github.com/repos/modxcms/revolution/statuses/c42cf59dd7c2c8e07c5229db5e0d0cec1927c94f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rtripault","id":300920,"avatar_url":"https://avatars.githubusercontent.com/u/300920?v=3","gravatar_id":"","url":"https://api.github.com/users/rtripault","html_url":"https://github.com/rtripault","followers_url":"https://api.github.com/users/rtripault/followers","following_url":"https://api.github.com/users/rtripault/following{/other_user}","gists_url":"https://api.github.com/users/rtripault/gists{/gist_id}","starred_url":"https://api.github.com/users/rtripault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtripault/subscriptions","organizations_url":"https://api.github.com/users/rtripault/orgs","repos_url":"https://api.github.com/users/rtripault/repos","events_url":"https://api.github.com/users/rtripault/events{/privacy}","received_events_url":"https://api.github.com/users/rtripault/received_events","type":"User","site_admin":false},"comments":11,"review_comments":4,"commits":4,"additions":5,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"rtripault"}}