{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/1938","repository_url":"https://api.github.com/repos/ansible/ansible-modules-extras","labels_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/1938/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/1938/comments","events_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/1938/events","html_url":"https://github.com/ansible/ansible-modules-extras/pull/1938","id":145056633,"number":1938,"title":"Updating ELB facts module to boto3, adding support for tag filtering.","user":{"login":"shousper","id":1144345,"avatar_url":"https://avatars.githubusercontent.com/u/1144345?v=3","gravatar_id":"","url":"https://api.github.com/users/shousper","html_url":"https://github.com/shousper","followers_url":"https://api.github.com/users/shousper/followers","following_url":"https://api.github.com/users/shousper/following{/other_user}","gists_url":"https://api.github.com/users/shousper/gists{/gist_id}","starred_url":"https://api.github.com/users/shousper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shousper/subscriptions","organizations_url":"https://api.github.com/users/shousper/orgs","repos_url":"https://api.github.com/users/shousper/repos","events_url":"https://api.github.com/users/shousper/events{/privacy}","received_events_url":"https://api.github.com/users/shousper/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels/cloud","name":"cloud","color":"c7def8"},{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels/community_review","name":"community_review","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-01T00:51:50Z","updated_at":"2016-04-10T15:29:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/1938","html_url":"https://github.com/ansible/ansible-modules-extras/pull/1938","diff_url":"https://github.com/ansible/ansible-modules-extras/pull/1938.diff","patch_url":"https://github.com/ansible/ansible-modules-extras/pull/1938.patch"},"body":"##### ISSUE TYPE\r\n - Feature Pull Request\r\n\r\n##### COMPONENT NAME\r\nec2_elb_facts\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.0.1.0\r\n  config file = /etc/ansible/ansible.cfg\r\n  configured module search path = Default w/o overrides\r\n```\r\n\r\n##### SUMMARY\r\nAdds support for filtering by tags on ELBs and built-in boto3 parameters for paging, etc.\r\n\r\nDoesn't include policy information obtained via `describe_load_balancer_policies` as that didn't seem useful at this point. It probably belongs in a separate facts module OR perhaps implemented in conjunction with a boolean flag or two (likewise for policy type information).\r\n\r\n*tl;dr: Essentially stitches together `describe_load_balancers`, `describe_instance_health`, `describe_load_balancer_attributes`, and `describe_tags` from boto3 `elb`.*"},"comment":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/comments/207999433","html_url":"https://github.com/ansible/ansible-modules-extras/pull/1938#issuecomment-207999433","issue_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/1938","id":207999433,"user":{"login":"mjschultz","id":90788,"avatar_url":"https://avatars.githubusercontent.com/u/90788?v=3","gravatar_id":"","url":"https://api.github.com/users/mjschultz","html_url":"https://github.com/mjschultz","followers_url":"https://api.github.com/users/mjschultz/followers","following_url":"https://api.github.com/users/mjschultz/following{/other_user}","gists_url":"https://api.github.com/users/mjschultz/gists{/gist_id}","starred_url":"https://api.github.com/users/mjschultz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjschultz/subscriptions","organizations_url":"https://api.github.com/users/mjschultz/orgs","repos_url":"https://api.github.com/users/mjschultz/repos","events_url":"https://api.github.com/users/mjschultz/events{/privacy}","received_events_url":"https://api.github.com/users/mjschultz/received_events","type":"User","site_admin":false},"created_at":"2016-04-10T15:29:03Z","updated_at":"2016-04-10T15:29:03Z","body":"According to the [Ansible Amazon module guidelines](https://github.com/ansible/ansible-modules-extras/blob/84f2aa6167f2b8e537990067169929ca8823fb31/cloud/amazon/GUIDELINES.md#getting-started):\r\n\r\n> Backward compatibility of older modules must be maintained.\r\n\r\nIt doesn't look like this maintains backward compatibility right now.\r\n\r\nAs far as the new feature, I think the Ansible form would be something like:\r\n\r\n```\r\nfilters:\r\n  tag:\r\n    Role: nginx\r\n    Environment: qa\r\n```\r\n\r\nIt looks like their are some [Helper functions](https://github.com/ansible/ansible-modules-extras/blob/84f2aa6167f2b8e537990067169929ca8823fb31/cloud/amazon/GUIDELINES.md#helper-functions) for this as well. (I might be mistaken about the format.) It might be even better to have a higher level parameter that is just:\r\n```\r\ntags:\r\n  - Role: nginx\r\n  - Environment: qa\r\n```\r\n\r\nSo, this is under needs_revision for now I think."}}