{"action":"closed","number":9297,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/9297","id":91051309,"html_url":"https://github.com/nodejs/node/pull/9297","diff_url":"https://github.com/nodejs/node/pull/9297.diff","patch_url":"https://github.com/nodejs/node/pull/9297.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/9297","number":9297,"state":"closed","locked":false,"title":"test: use 'strictEqual' instead of 'equal'","user":{"login":"gerges-beshay","id":5034465,"avatar_url":"https://avatars.githubusercontent.com/u/5034465?v=3","gravatar_id":"","url":"https://api.github.com/users/gerges-beshay","html_url":"https://github.com/gerges-beshay","followers_url":"https://api.github.com/users/gerges-beshay/followers","following_url":"https://api.github.com/users/gerges-beshay/following{/other_user}","gists_url":"https://api.github.com/users/gerges-beshay/gists{/gist_id}","starred_url":"https://api.github.com/users/gerges-beshay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerges-beshay/subscriptions","organizations_url":"https://api.github.com/users/gerges-beshay/orgs","repos_url":"https://api.github.com/users/gerges-beshay/repos","events_url":"https://api.github.com/users/gerges-beshay/events{/privacy}","received_events_url":"https://api.github.com/users/gerges-beshay/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j8 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Description of change\r\nUse 'strictEqual' instead of 'equal' in 'test-async-wrap-check-providers'.\r\n\r\n","created_at":"2016-10-26T17:31:56Z","updated_at":"2016-10-28T17:38:49Z","closed_at":"2016-10-28T17:38:49Z","merged_at":null,"merge_commit_sha":"f218174c51ed57c7e8cd8baaa6de0440a5546d19","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/9297/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/9297/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/9297/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/45ecf275e951429442236b0f695b3fae7dfc1a6c","head":{"label":"gerges-beshay:test","ref":"test","sha":"45ecf275e951429442236b0f695b3fae7dfc1a6c","user":{"login":"gerges-beshay","id":5034465,"avatar_url":"https://avatars.githubusercontent.com/u/5034465?v=3","gravatar_id":"","url":"https://api.github.com/users/gerges-beshay","html_url":"https://github.com/gerges-beshay","followers_url":"https://api.github.com/users/gerges-beshay/followers","following_url":"https://api.github.com/users/gerges-beshay/following{/other_user}","gists_url":"https://api.github.com/users/gerges-beshay/gists{/gist_id}","starred_url":"https://api.github.com/users/gerges-beshay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerges-beshay/subscriptions","organizations_url":"https://api.github.com/users/gerges-beshay/orgs","repos_url":"https://api.github.com/users/gerges-beshay/repos","events_url":"https://api.github.com/users/gerges-beshay/events{/privacy}","received_events_url":"https://api.github.com/users/gerges-beshay/received_events","type":"User","site_admin":false},"repo":{"id":71385083,"name":"node","full_name":"gerges-beshay/node","owner":{"login":"gerges-beshay","id":5034465,"avatar_url":"https://avatars.githubusercontent.com/u/5034465?v=3","gravatar_id":"","url":"https://api.github.com/users/gerges-beshay","html_url":"https://github.com/gerges-beshay","followers_url":"https://api.github.com/users/gerges-beshay/followers","following_url":"https://api.github.com/users/gerges-beshay/following{/other_user}","gists_url":"https://api.github.com/users/gerges-beshay/gists{/gist_id}","starred_url":"https://api.github.com/users/gerges-beshay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerges-beshay/subscriptions","organizations_url":"https://api.github.com/users/gerges-beshay/orgs","repos_url":"https://api.github.com/users/gerges-beshay/repos","events_url":"https://api.github.com/users/gerges-beshay/events{/privacy}","received_events_url":"https://api.github.com/users/gerges-beshay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gerges-beshay/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/gerges-beshay/node","forks_url":"https://api.github.com/repos/gerges-beshay/node/forks","keys_url":"https://api.github.com/repos/gerges-beshay/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gerges-beshay/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gerges-beshay/node/teams","hooks_url":"https://api.github.com/repos/gerges-beshay/node/hooks","issue_events_url":"https://api.github.com/repos/gerges-beshay/node/issues/events{/number}","events_url":"https://api.github.com/repos/gerges-beshay/node/events","assignees_url":"https://api.github.com/repos/gerges-beshay/node/assignees{/user}","branches_url":"https://api.github.com/repos/gerges-beshay/node/branches{/branch}","tags_url":"https://api.github.com/repos/gerges-beshay/node/tags","blobs_url":"https://api.github.com/repos/gerges-beshay/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gerges-beshay/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gerges-beshay/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/gerges-beshay/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gerges-beshay/node/statuses/{sha}","languages_url":"https://api.github.com/repos/gerges-beshay/node/languages","stargazers_url":"https://api.github.com/repos/gerges-beshay/node/stargazers","contributors_url":"https://api.github.com/repos/gerges-beshay/node/contributors","subscribers_url":"https://api.github.com/repos/gerges-beshay/node/subscribers","subscription_url":"https://api.github.com/repos/gerges-beshay/node/subscription","commits_url":"https://api.github.com/repos/gerges-beshay/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/gerges-beshay/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/gerges-beshay/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/gerges-beshay/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/gerges-beshay/node/contents/{+path}","compare_url":"https://api.github.com/repos/gerges-beshay/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gerges-beshay/node/merges","archive_url":"https://api.github.com/repos/gerges-beshay/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gerges-beshay/node/downloads","issues_url":"https://api.github.com/repos/gerges-beshay/node/issues{/number}","pulls_url":"https://api.github.com/repos/gerges-beshay/node/pulls{/number}","milestones_url":"https://api.github.com/repos/gerges-beshay/node/milestones{/number}","notifications_url":"https://api.github.com/repos/gerges-beshay/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gerges-beshay/node/labels{/name}","releases_url":"https://api.github.com/repos/gerges-beshay/node/releases{/id}","deployments_url":"https://api.github.com/repos/gerges-beshay/node/deployments","created_at":"2016-10-19T18:00:22Z","updated_at":"2016-10-19T18:00:50Z","pushed_at":"2016-10-26T20:36:22Z","git_url":"git://github.com/gerges-beshay/node.git","ssh_url":"git@github.com:gerges-beshay/node.git","clone_url":"https://github.com/gerges-beshay/node.git","svn_url":"https://github.com/gerges-beshay/node","homepage":"https://nodejs.org","size":237081,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"8f00455c5194154ce909ddac6488ae2e42976a4c","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-10-28T17:37:50Z","pushed_at":"2016-10-28T17:38:29Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":354195,"stargazers_count":28323,"watchers_count":28323,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4705,"mirror_url":null,"open_issues_count":847,"forks":4705,"open_issues":847,"watchers":28323,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/9297"},"html":{"href":"https://github.com/nodejs/node/pull/9297"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/9297"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/9297/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/9297/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/9297/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/45ecf275e951429442236b0f695b3fae7dfc1a6c"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":6,"review_comments":0,"commits":2,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"Trott"}}