{"action":"created","issue":{"url":"https://api.github.com/repos/commercetools/nodejs/issues/2","repository_url":"https://api.github.com/repos/commercetools/nodejs","labels_url":"https://api.github.com/repos/commercetools/nodejs/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/commercetools/nodejs/issues/2/comments","events_url":"https://api.github.com/repos/commercetools/nodejs/issues/2/events","html_url":"https://github.com/commercetools/nodejs/pull/2","id":194088163,"number":2,"title":"Build setup improvements + (WIP) node-sdk packages","user":{"login":"emmenko","id":1110551,"avatar_url":"https://avatars.githubusercontent.com/u/1110551?v=3","gravatar_id":"","url":"https://api.github.com/users/emmenko","html_url":"https://github.com/emmenko","followers_url":"https://api.github.com/users/emmenko/followers","following_url":"https://api.github.com/users/emmenko/following{/other_user}","gists_url":"https://api.github.com/users/emmenko/gists{/gist_id}","starred_url":"https://api.github.com/users/emmenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmenko/subscriptions","organizations_url":"https://api.github.com/users/emmenko/orgs","repos_url":"https://api.github.com/users/emmenko/repos","events_url":"https://api.github.com/users/emmenko/events{/privacy}","received_events_url":"https://api.github.com/users/emmenko/received_events","type":"User","site_admin":false},"labels":[{"id":458563457,"url":"https://api.github.com/repos/commercetools/nodejs/labels/Status:%20In%20Progress","name":"Status: In Progress","color":"cccccc","default":false},{"id":458563455,"url":"https://api.github.com/repos/commercetools/nodejs/labels/Status:%20Review","name":"Status: Review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"Siilwyn","id":5701149,"avatar_url":"https://avatars.githubusercontent.com/u/5701149?v=3","gravatar_id":"","url":"https://api.github.com/users/Siilwyn","html_url":"https://github.com/Siilwyn","followers_url":"https://api.github.com/users/Siilwyn/followers","following_url":"https://api.github.com/users/Siilwyn/following{/other_user}","gists_url":"https://api.github.com/users/Siilwyn/gists{/gist_id}","starred_url":"https://api.github.com/users/Siilwyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Siilwyn/subscriptions","organizations_url":"https://api.github.com/users/Siilwyn/orgs","repos_url":"https://api.github.com/users/Siilwyn/repos","events_url":"https://api.github.com/users/Siilwyn/events{/privacy}","received_events_url":"https://api.github.com/users/Siilwyn/received_events","type":"User","site_admin":false},"assignees":[{"login":"Siilwyn","id":5701149,"avatar_url":"https://avatars.githubusercontent.com/u/5701149?v=3","gravatar_id":"","url":"https://api.github.com/users/Siilwyn","html_url":"https://github.com/Siilwyn","followers_url":"https://api.github.com/users/Siilwyn/followers","following_url":"https://api.github.com/users/Siilwyn/following{/other_user}","gists_url":"https://api.github.com/users/Siilwyn/gists{/gist_id}","starred_url":"https://api.github.com/users/Siilwyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Siilwyn/subscriptions","organizations_url":"https://api.github.com/users/Siilwyn/orgs","repos_url":"https://api.github.com/users/Siilwyn/repos","events_url":"https://api.github.com/users/Siilwyn/events{/privacy}","received_events_url":"https://api.github.com/users/Siilwyn/received_events","type":"User","site_admin":false},{"login":"PhilippSpo","id":8394418,"avatar_url":"https://avatars.githubusercontent.com/u/8394418?v=3","gravatar_id":"","url":"https://api.github.com/users/PhilippSpo","html_url":"https://github.com/PhilippSpo","followers_url":"https://api.github.com/users/PhilippSpo/followers","following_url":"https://api.github.com/users/PhilippSpo/following{/other_user}","gists_url":"https://api.github.com/users/PhilippSpo/gists{/gist_id}","starred_url":"https://api.github.com/users/PhilippSpo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhilippSpo/subscriptions","organizations_url":"https://api.github.com/users/PhilippSpo/orgs","repos_url":"https://api.github.com/users/PhilippSpo/repos","events_url":"https://api.github.com/users/PhilippSpo/events{/privacy}","received_events_url":"https://api.github.com/users/PhilippSpo/received_events","type":"User","site_admin":false},{"login":"hisabimbola","id":9654923,"avatar_url":"https://avatars.githubusercontent.com/u/9654923?v=3","gravatar_id":"","url":"https://api.github.com/users/hisabimbola","html_url":"https://github.com/hisabimbola","followers_url":"https://api.github.com/users/hisabimbola/followers","following_url":"https://api.github.com/users/hisabimbola/following{/other_user}","gists_url":"https://api.github.com/users/hisabimbola/gists{/gist_id}","starred_url":"https://api.github.com/users/hisabimbola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hisabimbola/subscriptions","organizations_url":"https://api.github.com/users/hisabimbola/orgs","repos_url":"https://api.github.com/users/hisabimbola/repos","events_url":"https://api.github.com/users/hisabimbola/events{/privacy}","received_events_url":"https://api.github.com/users/hisabimbola/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-12-07T15:56:47Z","updated_at":"2016-12-09T10:22:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/commercetools/nodejs/pulls/2","html_url":"https://github.com/commercetools/nodejs/pull/2","diff_url":"https://github.com/commercetools/nodejs/pull/2.diff","patch_url":"https://github.com/commercetools/nodejs/pull/2.patch"},"body":"#### Summary\r\nI finally took some time to continue work on the new sdk. Since I want to have it split into different packages, what better chance to start doing it in our new monorepo ;)\r\n\r\n> Please **don't bother much** reviewing the `packages/*` stuff, it's still very much in progress. It's just there as a starting point, and **to test the different script commands** for packages usage.\r\n\r\nSo **focus on the setup changes** if you are reviewing this PR 😉 .\r\nI'll add some inline comments to explain some of the changes. Note that some stuff got removed / refactored because it didn't really work as expected with the packages, since we didn't really have proper packages to test it yet.\r\n\r\n> My plan is to merge this, to set the basic necessary setup, and continue working on the packages in separate PRs\r\n\r\nTODO:\r\n- [x] fix travis build"},"comment":{"url":"https://api.github.com/repos/commercetools/nodejs/issues/comments/265980929","html_url":"https://github.com/commercetools/nodejs/pull/2#issuecomment-265980929","issue_url":"https://api.github.com/repos/commercetools/nodejs/issues/2","id":265980929,"user":{"login":"Siilwyn","id":5701149,"avatar_url":"https://avatars.githubusercontent.com/u/5701149?v=3","gravatar_id":"","url":"https://api.github.com/users/Siilwyn","html_url":"https://github.com/Siilwyn","followers_url":"https://api.github.com/users/Siilwyn/followers","following_url":"https://api.github.com/users/Siilwyn/following{/other_user}","gists_url":"https://api.github.com/users/Siilwyn/gists{/gist_id}","starred_url":"https://api.github.com/users/Siilwyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Siilwyn/subscriptions","organizations_url":"https://api.github.com/users/Siilwyn/orgs","repos_url":"https://api.github.com/users/Siilwyn/repos","events_url":"https://api.github.com/users/Siilwyn/events{/privacy}","received_events_url":"https://api.github.com/users/Siilwyn/received_events","type":"User","site_admin":false},"created_at":"2016-12-09T10:22:25Z","updated_at":"2016-12-09T10:22:25Z","body":"Well the extension would make it more clear it's a script file, but since one of them is a JS file maybe not. Though they're all located in the 'scripts' directory. So no strong opinion on it either, I guess it's a bit of personal preference, I like always having file extensions so that the OS can easily detect what kind of file it is.\r\n\r\nThat said the shebang is way more important to do right."}}
{"actor":{"display_login":"Siilwyn"}}