{"action":"created","issue":{"url":"https://api.github.com/repos/hechoendrupal/DrupalConsole/issues/2109","repository_url":"https://api.github.com/repos/hechoendrupal/DrupalConsole","labels_url":"https://api.github.com/repos/hechoendrupal/DrupalConsole/issues/2109/labels{/name}","comments_url":"https://api.github.com/repos/hechoendrupal/DrupalConsole/issues/2109/comments","events_url":"https://api.github.com/repos/hechoendrupal/DrupalConsole/issues/2109/events","html_url":"https://github.com/hechoendrupal/DrupalConsole/pull/2109","id":146683985,"number":2109,"title":"Novia713 generate:doc:cheatsheet","user":{"login":"novia713","id":423279,"avatar_url":"https://avatars.githubusercontent.com/u/423279?v=3","gravatar_id":"","url":"https://api.github.com/users/novia713","html_url":"https://github.com/novia713","followers_url":"https://api.github.com/users/novia713/followers","following_url":"https://api.github.com/users/novia713/following{/other_user}","gists_url":"https://api.github.com/users/novia713/gists{/gist_id}","starred_url":"https://api.github.com/users/novia713/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novia713/subscriptions","organizations_url":"https://api.github.com/users/novia713/orgs","repos_url":"https://api.github.com/users/novia713/repos","events_url":"https://api.github.com/users/novia713/events{/privacy}","received_events_url":"https://api.github.com/users/novia713/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-07T16:57:49Z","updated_at":"2016-04-07T18:39:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hechoendrupal/DrupalConsole/pulls/2109","html_url":"https://github.com/hechoendrupal/DrupalConsole/pull/2109","diff_url":"https://github.com/hechoendrupal/DrupalConsole/pull/2109.diff","patch_url":"https://github.com/hechoendrupal/DrupalConsole/pull/2109.patch"},"body":"Right now i think as first aproximation as code contributor this PR is enough.\r\nIt's is working, it generates a PDF. The only fault i see is that it's not using Twig.\r\nI create the HTML (wkhtmltopdf generates the PDF over a HTML file) programatically. I think other people can contribute doing a twig file and rendering it ...\r\n¿Did you see the code? ¿What do you think? :smile: \r\n\r\nThe only mandatory argument is «path» in order the command to know where to generate the PDF.\r\nOnce twig were integrated in the future, a --format argument can be given, for getting a HTML output as option.\r\nThere is another argument --wkhtmltopdf to say the command where the wkhtmltopdf binary lives. If not given, \"/usr/bin/wkhtmltopdf\" is guessed.\r\n\r\nI think a new key as _description-for-cheatsheet_ for every command is not necessary, I'm printing right now the command description and it's fine.\r\n\r\nFurther in time, perhaps we can do a .yml config file for selecting which commands to print and which not. Even, giving the user this choice. This should be easy, given I'm iterating already a list of arbitrary commands (all except yaml & translation).\r\n\r\nPlease keep an eye on the code, I'm expecting your considerations :smile: \r\n\r\n\r\n--\r\n\r\nIn other terms, I'm really interested in doing tests. Many classes are still without them, for example, _PHPUnit_ says _GeneratorPluginBlockCommandTest_ has tests not implemented yet. \r\nI would do it, but i don't know which file is missing .....\r\nSo a little explanation on the testing process would be a great help for me.\r\n\r\n\r\nRegards.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/hechoendrupal/DrupalConsole/issues/comments/207042797","html_url":"https://github.com/hechoendrupal/DrupalConsole/pull/2109#issuecomment-207042797","issue_url":"https://api.github.com/repos/hechoendrupal/DrupalConsole/issues/2109","id":207042797,"user":{"login":"novia713","id":423279,"avatar_url":"https://avatars.githubusercontent.com/u/423279?v=3","gravatar_id":"","url":"https://api.github.com/users/novia713","html_url":"https://github.com/novia713","followers_url":"https://api.github.com/users/novia713/followers","following_url":"https://api.github.com/users/novia713/following{/other_user}","gists_url":"https://api.github.com/users/novia713/gists{/gist_id}","starred_url":"https://api.github.com/users/novia713/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novia713/subscriptions","organizations_url":"https://api.github.com/users/novia713/orgs","repos_url":"https://api.github.com/users/novia713/repos","events_url":"https://api.github.com/users/novia713/events{/privacy}","received_events_url":"https://api.github.com/users/novia713/received_events","type":"User","site_admin":false},"created_at":"2016-04-07T18:39:06Z","updated_at":"2016-04-07T18:39:06Z","body":"merged! :smile: \r\n\r\n:skull: ¡ IMPORTANT ! :skull: \r\nI reverted the composer.json & composer.lock to master version.\r\nin order my code to work it needs ```composer require knplabs/knp-snappy``` to be done!\r\notherwise this code won't work! :skull: \r\n\r\ni've tried to require it, but composer blindly updates all the packages and i don't know the comsequences of that! so fearing to broke something, i left unmodified the composer files ..."}}