{"action":"created","issue":{"url":"https://api.github.com/repos/NeXTs/Clusterize.js/issues/80","repository_url":"https://api.github.com/repos/NeXTs/Clusterize.js","labels_url":"https://api.github.com/repos/NeXTs/Clusterize.js/issues/80/labels{/name}","comments_url":"https://api.github.com/repos/NeXTs/Clusterize.js/issues/80/comments","events_url":"https://api.github.com/repos/NeXTs/Clusterize.js/issues/80/events","html_url":"https://github.com/NeXTs/Clusterize.js/pull/80","id":174904762,"number":80,"title":"Using DOM Nodes instead of strings","user":{"login":"STRd6","id":18894,"avatar_url":"https://avatars.githubusercontent.com/u/18894?v=3","gravatar_id":"","url":"https://api.github.com/users/STRd6","html_url":"https://github.com/STRd6","followers_url":"https://api.github.com/users/STRd6/followers","following_url":"https://api.github.com/users/STRd6/following{/other_user}","gists_url":"https://api.github.com/users/STRd6/gists{/gist_id}","starred_url":"https://api.github.com/users/STRd6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STRd6/subscriptions","organizations_url":"https://api.github.com/users/STRd6/orgs","repos_url":"https://api.github.com/users/STRd6/repos","events_url":"https://api.github.com/users/STRd6/events{/privacy}","received_events_url":"https://api.github.com/users/STRd6/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-09-03T16:37:48Z","updated_at":"2016-09-03T21:12:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NeXTs/Clusterize.js/pulls/80","html_url":"https://github.com/NeXTs/Clusterize.js/pull/80","diff_url":"https://github.com/NeXTs/Clusterize.js/pull/80.diff","patch_url":"https://github.com/NeXTs/Clusterize.js/pull/80.patch"},"body":"I'm making a spreadsheet app and rendering input elements inside table rows. The input values and event listeners were getting clobbered by being converted to strings and back.\r\n\r\nIn this PR I'm caching the real nodes and inserting/removing them. It works great for my purposes and may be of use to others but I understand if there may be reasons why the strings approach was taken.\r\n\r\nIt seems to work well in my limited test, but there's still an issue with the change on line 174 where we compute the height... I'm assuming the first three rows exist.\r\n\r\nAnyway, thought I'd put up these changes in case you found them of interest!"},"comment":{"url":"https://api.github.com/repos/NeXTs/Clusterize.js/issues/comments/244570023","html_url":"https://github.com/NeXTs/Clusterize.js/pull/80#issuecomment-244570023","issue_url":"https://api.github.com/repos/NeXTs/Clusterize.js/issues/80","id":244570023,"user":{"login":"STRd6","id":18894,"avatar_url":"https://avatars.githubusercontent.com/u/18894?v=3","gravatar_id":"","url":"https://api.github.com/users/STRd6","html_url":"https://github.com/STRd6","followers_url":"https://api.github.com/users/STRd6/followers","following_url":"https://api.github.com/users/STRd6/following{/other_user}","gists_url":"https://api.github.com/users/STRd6/gists{/gist_id}","starred_url":"https://api.github.com/users/STRd6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STRd6/subscriptions","organizations_url":"https://api.github.com/users/STRd6/orgs","repos_url":"https://api.github.com/users/STRd6/repos","events_url":"https://api.github.com/users/STRd6/events{/privacy}","received_events_url":"https://api.github.com/users/STRd6/received_events","type":"User","site_admin":false},"created_at":"2016-09-03T21:12:34Z","updated_at":"2016-09-03T21:12:34Z","body":"Using the same node `rows[0]` will only insert it once rather than three copies, another fix would be to check `if (rows.length < 3) return;` or however many is needed to accurately guess the sizes."}}
{"actor":{"display_login":"STRd6"}}