{"action":"created","comment":{"url":"https://api.github.com/repos/google/trillian/pulls/comments/87588078","pull_request_review_id":8196366,"id":87588078,"diff_hunk":"@@ -22,6 +23,11 @@ type Sequencer struct {\n \ttimeSource util.TimeSource\n \tlogStorage storage.LogStorage\n \tkeyManager crypto.KeyManager\n+\n+\t// These parameters can be safely adjusted during operation","path":"log/sequencer.go","position":13,"original_position":13,"commit_id":"05e4215630be25bf9c4e12f61035a9bb2f2e73a3","original_commit_id":"05e4215630be25bf9c4e12f61035a9bb2f2e73a3","user":{"login":"daviddrysdale","id":457208,"avatar_url":"https://avatars.githubusercontent.com/u/457208?v=3","gravatar_id":"","url":"https://api.github.com/users/daviddrysdale","html_url":"https://github.com/daviddrysdale","followers_url":"https://api.github.com/users/daviddrysdale/followers","following_url":"https://api.github.com/users/daviddrysdale/following{/other_user}","gists_url":"https://api.github.com/users/daviddrysdale/gists{/gist_id}","starred_url":"https://api.github.com/users/daviddrysdale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daviddrysdale/subscriptions","organizations_url":"https://api.github.com/users/daviddrysdale/orgs","repos_url":"https://api.github.com/users/daviddrysdale/repos","events_url":"https://api.github.com/users/daviddrysdale/events{/privacy}","received_events_url":"https://api.github.com/users/daviddrysdale/received_events","type":"User","site_admin":false},"body":"Maybe \"The following parameters...\".\r\n\r\nDo the mutable parameters need to be protected by a `sync.RWMutex` if they can potentially be written by different threads than are reading them? ","created_at":"2016-11-11T13:33:58Z","updated_at":"2016-11-11T13:54:08Z","html_url":"https://github.com/google/trillian/pull/220#discussion_r87588078","pull_request_url":"https://api.github.com/repos/google/trillian/pulls/220","_links":{"self":{"href":"https://api.github.com/repos/google/trillian/pulls/comments/87588078"},"html":{"href":"https://github.com/google/trillian/pull/220#discussion_r87588078"},"pull_request":{"href":"https://api.github.com/repos/google/trillian/pulls/220"}}},"pull_request":{"url":"https://api.github.com/repos/google/trillian/pulls/220","id":93320834,"html_url":"https://github.com/google/trillian/pull/220","diff_url":"https://github.com/google/trillian/pull/220.diff","patch_url":"https://github.com/google/trillian/pull/220.patch","issue_url":"https://api.github.com/repos/google/trillian/issues/220","number":220,"state":"open","locked":false,"title":"Refactoring to make queue timestamp not provided by database.","user":{"login":"Martin2112","id":13366863,"avatar_url":"https://avatars.githubusercontent.com/u/13366863?v=3","gravatar_id":"","url":"https://api.github.com/users/Martin2112","html_url":"https://github.com/Martin2112","followers_url":"https://api.github.com/users/Martin2112/followers","following_url":"https://api.github.com/users/Martin2112/following{/other_user}","gists_url":"https://api.github.com/users/Martin2112/gists{/gist_id}","starred_url":"https://api.github.com/users/Martin2112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Martin2112/subscriptions","organizations_url":"https://api.github.com/users/Martin2112/orgs","repos_url":"https://api.github.com/users/Martin2112/repos","events_url":"https://api.github.com/users/Martin2112/events{/privacy}","received_events_url":"https://api.github.com/users/Martin2112/received_events","type":"User","site_admin":false},"body":"And implement log sequencing guard window. It was very hard to do it\r\nwithout making the API change. This keeps storage free of knowledge\r\nabout times, it just passes through what it's given by higher layers.\r\n\r\nSorry it's a bit big but a lot of it is mechanical changes to test parameters.","created_at":"2016-11-11T11:55:00Z","updated_at":"2016-11-11T13:54:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"844514ee3ad3df36fee663d2a875a25fdd1048c0","assignee":{"login":"daviddrysdale","id":457208,"avatar_url":"https://avatars.githubusercontent.com/u/457208?v=3","gravatar_id":"","url":"https://api.github.com/users/daviddrysdale","html_url":"https://github.com/daviddrysdale","followers_url":"https://api.github.com/users/daviddrysdale/followers","following_url":"https://api.github.com/users/daviddrysdale/following{/other_user}","gists_url":"https://api.github.com/users/daviddrysdale/gists{/gist_id}","starred_url":"https://api.github.com/users/daviddrysdale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daviddrysdale/subscriptions","organizations_url":"https://api.github.com/users/daviddrysdale/orgs","repos_url":"https://api.github.com/users/daviddrysdale/repos","events_url":"https://api.github.com/users/daviddrysdale/events{/privacy}","received_events_url":"https://api.github.com/users/daviddrysdale/received_events","type":"User","site_admin":false},"assignees":[{"login":"daviddrysdale","id":457208,"avatar_url":"https://avatars.githubusercontent.com/u/457208?v=3","gravatar_id":"","url":"https://api.github.com/users/daviddrysdale","html_url":"https://github.com/daviddrysdale","followers_url":"https://api.github.com/users/daviddrysdale/followers","following_url":"https://api.github.com/users/daviddrysdale/following{/other_user}","gists_url":"https://api.github.com/users/daviddrysdale/gists{/gist_id}","starred_url":"https://api.github.com/users/daviddrysdale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daviddrysdale/subscriptions","organizations_url":"https://api.github.com/users/daviddrysdale/orgs","repos_url":"https://api.github.com/users/daviddrysdale/repos","events_url":"https://api.github.com/users/daviddrysdale/events{/privacy}","received_events_url":"https://api.github.com/users/daviddrysdale/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/google/trillian/milestones/8","html_url":"https://github.com/google/trillian/milestones/Log%20M5","labels_url":"https://api.github.com/repos/google/trillian/milestones/8/labels","id":2121972,"number":8,"title":"Log M5","description":"More unit and integration tests for proofs. Separate leaf / Merkle hashes in client API.","creator":{"login":"Martin2112","id":13366863,"avatar_url":"https://avatars.githubusercontent.com/u/13366863?v=3","gravatar_id":"","url":"https://api.github.com/users/Martin2112","html_url":"https://github.com/Martin2112","followers_url":"https://api.github.com/users/Martin2112/followers","following_url":"https://api.github.com/users/Martin2112/following{/other_user}","gists_url":"https://api.github.com/users/Martin2112/gists{/gist_id}","starred_url":"https://api.github.com/users/Martin2112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Martin2112/subscriptions","organizations_url":"https://api.github.com/users/Martin2112/orgs","repos_url":"https://api.github.com/users/Martin2112/repos","events_url":"https://api.github.com/users/Martin2112/events{/privacy}","received_events_url":"https://api.github.com/users/Martin2112/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":2,"state":"open","created_at":"2016-11-08T14:14:51Z","updated_at":"2016-11-11T11:55:12Z","due_on":"2016-11-30T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/google/trillian/pulls/220/commits","review_comments_url":"https://api.github.com/repos/google/trillian/pulls/220/comments","review_comment_url":"https://api.github.com/repos/google/trillian/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/trillian/issues/220/comments","statuses_url":"https://api.github.com/repos/google/trillian/statuses/05e4215630be25bf9c4e12f61035a9bb2f2e73a3","head":{"label":"Martin2112:sequencer_guard","ref":"sequencer_guard","sha":"05e4215630be25bf9c4e12f61035a9bb2f2e73a3","user":{"login":"Martin2112","id":13366863,"avatar_url":"https://avatars.githubusercontent.com/u/13366863?v=3","gravatar_id":"","url":"https://api.github.com/users/Martin2112","html_url":"https://github.com/Martin2112","followers_url":"https://api.github.com/users/Martin2112/followers","following_url":"https://api.github.com/users/Martin2112/following{/other_user}","gists_url":"https://api.github.com/users/Martin2112/gists{/gist_id}","starred_url":"https://api.github.com/users/Martin2112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Martin2112/subscriptions","organizations_url":"https://api.github.com/users/Martin2112/orgs","repos_url":"https://api.github.com/users/Martin2112/repos","events_url":"https://api.github.com/users/Martin2112/events{/privacy}","received_events_url":"https://api.github.com/users/Martin2112/received_events","type":"User","site_admin":false},"repo":{"id":60082567,"name":"trillian","full_name":"Martin2112/trillian","owner":{"login":"Martin2112","id":13366863,"avatar_url":"https://avatars.githubusercontent.com/u/13366863?v=3","gravatar_id":"","url":"https://api.github.com/users/Martin2112","html_url":"https://github.com/Martin2112","followers_url":"https://api.github.com/users/Martin2112/followers","following_url":"https://api.github.com/users/Martin2112/following{/other_user}","gists_url":"https://api.github.com/users/Martin2112/gists{/gist_id}","starred_url":"https://api.github.com/users/Martin2112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Martin2112/subscriptions","organizations_url":"https://api.github.com/users/Martin2112/orgs","repos_url":"https://api.github.com/users/Martin2112/repos","events_url":"https://api.github.com/users/Martin2112/events{/privacy}","received_events_url":"https://api.github.com/users/Martin2112/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Martin2112/trillian","description":null,"fork":true,"url":"https://api.github.com/repos/Martin2112/trillian","forks_url":"https://api.github.com/repos/Martin2112/trillian/forks","keys_url":"https://api.github.com/repos/Martin2112/trillian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Martin2112/trillian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Martin2112/trillian/teams","hooks_url":"https://api.github.com/repos/Martin2112/trillian/hooks","issue_events_url":"https://api.github.com/repos/Martin2112/trillian/issues/events{/number}","events_url":"https://api.github.com/repos/Martin2112/trillian/events","assignees_url":"https://api.github.com/repos/Martin2112/trillian/assignees{/user}","branches_url":"https://api.github.com/repos/Martin2112/trillian/branches{/branch}","tags_url":"https://api.github.com/repos/Martin2112/trillian/tags","blobs_url":"https://api.github.com/repos/Martin2112/trillian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Martin2112/trillian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Martin2112/trillian/git/refs{/sha}","trees_url":"https://api.github.com/repos/Martin2112/trillian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Martin2112/trillian/statuses/{sha}","languages_url":"https://api.github.com/repos/Martin2112/trillian/languages","stargazers_url":"https://api.github.com/repos/Martin2112/trillian/stargazers","contributors_url":"https://api.github.com/repos/Martin2112/trillian/contributors","subscribers_url":"https://api.github.com/repos/Martin2112/trillian/subscribers","subscription_url":"https://api.github.com/repos/Martin2112/trillian/subscription","commits_url":"https://api.github.com/repos/Martin2112/trillian/commits{/sha}","git_commits_url":"https://api.github.com/repos/Martin2112/trillian/git/commits{/sha}","comments_url":"https://api.github.com/repos/Martin2112/trillian/comments{/number}","issue_comment_url":"https://api.github.com/repos/Martin2112/trillian/issues/comments{/number}","contents_url":"https://api.github.com/repos/Martin2112/trillian/contents/{+path}","compare_url":"https://api.github.com/repos/Martin2112/trillian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Martin2112/trillian/merges","archive_url":"https://api.github.com/repos/Martin2112/trillian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Martin2112/trillian/downloads","issues_url":"https://api.github.com/repos/Martin2112/trillian/issues{/number}","pulls_url":"https://api.github.com/repos/Martin2112/trillian/pulls{/number}","milestones_url":"https://api.github.com/repos/Martin2112/trillian/milestones{/number}","notifications_url":"https://api.github.com/repos/Martin2112/trillian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Martin2112/trillian/labels{/name}","releases_url":"https://api.github.com/repos/Martin2112/trillian/releases{/id}","deployments_url":"https://api.github.com/repos/Martin2112/trillian/deployments","created_at":"2016-05-31T11:07:09Z","updated_at":"2016-05-31T11:07:10Z","pushed_at":"2016-11-11T12:05:05Z","git_url":"git://github.com/Martin2112/trillian.git","ssh_url":"git@github.com:Martin2112/trillian.git","clone_url":"https://github.com/Martin2112/trillian.git","svn_url":"https://github.com/Martin2112/trillian","homepage":null,"size":1328,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"0b9610a8c869654f04b8b88b3bfb2a1b0d43d2bd","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":58654489,"name":"trillian","full_name":"google/trillian","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/trillian","description":null,"fork":false,"url":"https://api.github.com/repos/google/trillian","forks_url":"https://api.github.com/repos/google/trillian/forks","keys_url":"https://api.github.com/repos/google/trillian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/trillian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/trillian/teams","hooks_url":"https://api.github.com/repos/google/trillian/hooks","issue_events_url":"https://api.github.com/repos/google/trillian/issues/events{/number}","events_url":"https://api.github.com/repos/google/trillian/events","assignees_url":"https://api.github.com/repos/google/trillian/assignees{/user}","branches_url":"https://api.github.com/repos/google/trillian/branches{/branch}","tags_url":"https://api.github.com/repos/google/trillian/tags","blobs_url":"https://api.github.com/repos/google/trillian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/trillian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/trillian/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/trillian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/trillian/statuses/{sha}","languages_url":"https://api.github.com/repos/google/trillian/languages","stargazers_url":"https://api.github.com/repos/google/trillian/stargazers","contributors_url":"https://api.github.com/repos/google/trillian/contributors","subscribers_url":"https://api.github.com/repos/google/trillian/subscribers","subscription_url":"https://api.github.com/repos/google/trillian/subscription","commits_url":"https://api.github.com/repos/google/trillian/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/trillian/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/trillian/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/trillian/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/trillian/contents/{+path}","compare_url":"https://api.github.com/repos/google/trillian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/trillian/merges","archive_url":"https://api.github.com/repos/google/trillian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/trillian/downloads","issues_url":"https://api.github.com/repos/google/trillian/issues{/number}","pulls_url":"https://api.github.com/repos/google/trillian/pulls{/number}","milestones_url":"https://api.github.com/repos/google/trillian/milestones{/number}","notifications_url":"https://api.github.com/repos/google/trillian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/trillian/labels{/name}","releases_url":"https://api.github.com/repos/google/trillian/releases{/id}","deployments_url":"https://api.github.com/repos/google/trillian/deployments","created_at":"2016-05-12T15:37:35Z","updated_at":"2016-11-10T13:59:23Z","pushed_at":"2016-11-11T12:05:05Z","git_url":"git://github.com/google/trillian.git","ssh_url":"git@github.com:google/trillian.git","clone_url":"https://github.com/google/trillian.git","svn_url":"https://github.com/google/trillian","homepage":null,"size":1640,"stargazers_count":98,"watchers_count":98,"language":"Go","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":16,"forks":14,"open_issues":16,"watchers":98,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/trillian/pulls/220"},"html":{"href":"https://github.com/google/trillian/pull/220"},"issue":{"href":"https://api.github.com/repos/google/trillian/issues/220"},"comments":{"href":"https://api.github.com/repos/google/trillian/issues/220/comments"},"review_comments":{"href":"https://api.github.com/repos/google/trillian/pulls/220/comments"},"review_comment":{"href":"https://api.github.com/repos/google/trillian/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/trillian/pulls/220/commits"},"statuses":{"href":"https://api.github.com/repos/google/trillian/statuses/05e4215630be25bf9c4e12f61035a9bb2f2e73a3"}}}}
{"actor":{"display_login":"daviddrysdale"}}