{"action":"created","comment":{"url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/comments/88093387","pull_request_review_id":8677261,"id":88093387,"diff_hunk":"@@ -14,16 +14,7 @@ public static bool ReferencesFakeItEasy(this Assembly assembly)\n         {\r\n             Guard.AgainstNull(assembly, nameof(assembly));\r\n \r\n-#if FEATURE_REFLECTION_GETASSEMBLIES\r\n             return assembly.GetReferencedAssemblies().Any(r => r.FullName == TypeCatalogue.FakeItEasyAssembly.FullName);\r\n-#else\r\n-            var fakeItEasyLibraryName = TypeCatalogue.FakeItEasyAssembly.GetName().Name;\r\n-            var context = Microsoft.Extensions.DependencyModel.DependencyContext.Default;\r\n-\r\n-            var runtimeLib = context.RuntimeLibraries\r\n-                .SingleOrDefault(library => string.Equals(library.Name, assembly.Name(), System.StringComparison.Ordinal));\r\n-            return runtimeLib != null && runtimeLib.Dependencies.Any(dependency => string.Equals(dependency.Name, fakeItEasyLibraryName, System.StringComparison.Ordinal));\r","path":"src/FakeItEasy/Core/AssemblyExtensions.cs","position":12,"original_position":12,"commit_id":"e180e736a76f504980b11b47573c22baeda0db61","original_commit_id":"63a9d894306b17d0989f69a48d58a5e6ee2ea452","user":{"login":"adamralph","id":677704,"avatar_url":"https://avatars.githubusercontent.com/u/677704?v=3","gravatar_id":"","url":"https://api.github.com/users/adamralph","html_url":"https://github.com/adamralph","followers_url":"https://api.github.com/users/adamralph/followers","following_url":"https://api.github.com/users/adamralph/following{/other_user}","gists_url":"https://api.github.com/users/adamralph/gists{/gist_id}","starred_url":"https://api.github.com/users/adamralph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamralph/subscriptions","organizations_url":"https://api.github.com/users/adamralph/orgs","repos_url":"https://api.github.com/users/adamralph/repos","events_url":"https://api.github.com/users/adamralph/events{/privacy}","received_events_url":"https://api.github.com/users/adamralph/received_events","type":"User","site_admin":false},"body":"Thanks for the info @jeremymeng ","created_at":"2016-11-15T19:26:22Z","updated_at":"2016-11-15T19:36:49Z","html_url":"https://github.com/FakeItEasy/FakeItEasy/pull/898#discussion_r88093387","pull_request_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/898","_links":{"self":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/comments/88093387"},"html":{"href":"https://github.com/FakeItEasy/FakeItEasy/pull/898#discussion_r88093387"},"pull_request":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/898"}}},"pull_request":{"url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/898","id":92317591,"html_url":"https://github.com/FakeItEasy/FakeItEasy/pull/898","diff_url":"https://github.com/FakeItEasy/FakeItEasy/pull/898.diff","patch_url":"https://github.com/FakeItEasy/FakeItEasy/pull/898.patch","issue_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/898","number":898,"state":"open","locked":false,"title":"Integration tests for .NET Standard build","user":{"login":"blairconrad","id":3275797,"avatar_url":"https://avatars.githubusercontent.com/u/3275797?v=3","gravatar_id":"","url":"https://api.github.com/users/blairconrad","html_url":"https://github.com/blairconrad","followers_url":"https://api.github.com/users/blairconrad/followers","following_url":"https://api.github.com/users/blairconrad/following{/other_user}","gists_url":"https://api.github.com/users/blairconrad/gists{/gist_id}","starred_url":"https://api.github.com/users/blairconrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blairconrad/subscriptions","organizations_url":"https://api.github.com/users/blairconrad/orgs","repos_url":"https://api.github.com/users/blairconrad/repos","events_url":"https://api.github.com/users/blairconrad/events{/privacy}","received_events_url":"https://api.github.com/users/blairconrad/received_events","type":"User","site_admin":false},"body":"Connects to #531.\r\nWas finally able to clear (IMO) the last couple hurdles after @jeremymeng's work to add integration tests to the .NET Standard build.\r\nIn the end I'd probably squash the whole bit, but I wanted you to be able to see the first commit, which @jermeymeng gets credit for (I tweaked slightly so we could rebase), and the others, which I get blame for.\r\n\r\nThe most interesting thing is that when loading assemblies from files, the .NET Standard loader does not error out if you load the same assembly from different paths. Hence the skipping of `Should_warn_of_duplicate_input_assemblies_with_different_paths`.\r\n\r\nOh! And our original method of telling whether an assembly reference FakeItEasy did not work for assemblies explicitly loaded from files (the so-called \"external\" assemblies). Turns out we can simplify a lot. ","created_at":"2016-11-04T10:44:33Z","updated_at":"2016-11-15T19:36:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5e43527a28e5dae1c9b875af11b3b7ac7e29925","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/898/commits","review_comments_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/898/comments","review_comment_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/898/comments","statuses_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/statuses/e180e736a76f504980b11b47573c22baeda0db61","head":{"label":"blairconrad:integration-tests","ref":"integration-tests","sha":"e180e736a76f504980b11b47573c22baeda0db61","user":{"login":"blairconrad","id":3275797,"avatar_url":"https://avatars.githubusercontent.com/u/3275797?v=3","gravatar_id":"","url":"https://api.github.com/users/blairconrad","html_url":"https://github.com/blairconrad","followers_url":"https://api.github.com/users/blairconrad/followers","following_url":"https://api.github.com/users/blairconrad/following{/other_user}","gists_url":"https://api.github.com/users/blairconrad/gists{/gist_id}","starred_url":"https://api.github.com/users/blairconrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blairconrad/subscriptions","organizations_url":"https://api.github.com/users/blairconrad/orgs","repos_url":"https://api.github.com/users/blairconrad/repos","events_url":"https://api.github.com/users/blairconrad/events{/privacy}","received_events_url":"https://api.github.com/users/blairconrad/received_events","type":"User","site_admin":false},"repo":{"id":7626243,"name":"FakeItEasy","full_name":"blairconrad/FakeItEasy","owner":{"login":"blairconrad","id":3275797,"avatar_url":"https://avatars.githubusercontent.com/u/3275797?v=3","gravatar_id":"","url":"https://api.github.com/users/blairconrad","html_url":"https://github.com/blairconrad","followers_url":"https://api.github.com/users/blairconrad/followers","following_url":"https://api.github.com/users/blairconrad/following{/other_user}","gists_url":"https://api.github.com/users/blairconrad/gists{/gist_id}","starred_url":"https://api.github.com/users/blairconrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blairconrad/subscriptions","organizations_url":"https://api.github.com/users/blairconrad/orgs","repos_url":"https://api.github.com/users/blairconrad/repos","events_url":"https://api.github.com/users/blairconrad/events{/privacy}","received_events_url":"https://api.github.com/users/blairconrad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blairconrad/FakeItEasy","description":"The easy mocking library for .Net","fork":true,"url":"https://api.github.com/repos/blairconrad/FakeItEasy","forks_url":"https://api.github.com/repos/blairconrad/FakeItEasy/forks","keys_url":"https://api.github.com/repos/blairconrad/FakeItEasy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blairconrad/FakeItEasy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blairconrad/FakeItEasy/teams","hooks_url":"https://api.github.com/repos/blairconrad/FakeItEasy/hooks","issue_events_url":"https://api.github.com/repos/blairconrad/FakeItEasy/issues/events{/number}","events_url":"https://api.github.com/repos/blairconrad/FakeItEasy/events","assignees_url":"https://api.github.com/repos/blairconrad/FakeItEasy/assignees{/user}","branches_url":"https://api.github.com/repos/blairconrad/FakeItEasy/branches{/branch}","tags_url":"https://api.github.com/repos/blairconrad/FakeItEasy/tags","blobs_url":"https://api.github.com/repos/blairconrad/FakeItEasy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blairconrad/FakeItEasy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blairconrad/FakeItEasy/git/refs{/sha}","trees_url":"https://api.github.com/repos/blairconrad/FakeItEasy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blairconrad/FakeItEasy/statuses/{sha}","languages_url":"https://api.github.com/repos/blairconrad/FakeItEasy/languages","stargazers_url":"https://api.github.com/repos/blairconrad/FakeItEasy/stargazers","contributors_url":"https://api.github.com/repos/blairconrad/FakeItEasy/contributors","subscribers_url":"https://api.github.com/repos/blairconrad/FakeItEasy/subscribers","subscription_url":"https://api.github.com/repos/blairconrad/FakeItEasy/subscription","commits_url":"https://api.github.com/repos/blairconrad/FakeItEasy/commits{/sha}","git_commits_url":"https://api.github.com/repos/blairconrad/FakeItEasy/git/commits{/sha}","comments_url":"https://api.github.com/repos/blairconrad/FakeItEasy/comments{/number}","issue_comment_url":"https://api.github.com/repos/blairconrad/FakeItEasy/issues/comments{/number}","contents_url":"https://api.github.com/repos/blairconrad/FakeItEasy/contents/{+path}","compare_url":"https://api.github.com/repos/blairconrad/FakeItEasy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blairconrad/FakeItEasy/merges","archive_url":"https://api.github.com/repos/blairconrad/FakeItEasy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blairconrad/FakeItEasy/downloads","issues_url":"https://api.github.com/repos/blairconrad/FakeItEasy/issues{/number}","pulls_url":"https://api.github.com/repos/blairconrad/FakeItEasy/pulls{/number}","milestones_url":"https://api.github.com/repos/blairconrad/FakeItEasy/milestones{/number}","notifications_url":"https://api.github.com/repos/blairconrad/FakeItEasy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blairconrad/FakeItEasy/labels{/name}","releases_url":"https://api.github.com/repos/blairconrad/FakeItEasy/releases{/id}","deployments_url":"https://api.github.com/repos/blairconrad/FakeItEasy/deployments","created_at":"2013-01-15T14:25:28Z","updated_at":"2016-11-15T13:55:02Z","pushed_at":"2016-11-15T19:13:39Z","git_url":"git://github.com/blairconrad/FakeItEasy.git","ssh_url":"git@github.com:blairconrad/FakeItEasy.git","clone_url":"https://github.com/blairconrad/FakeItEasy.git","svn_url":"https://github.com/blairconrad/FakeItEasy","homepage":"","size":20692,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"FakeItEasy:master","ref":"master","sha":"e2ee58a4e7894e341874d23f7b7a09e3e0142e66","user":{"login":"FakeItEasy","id":1713521,"avatar_url":"https://avatars.githubusercontent.com/u/1713521?v=3","gravatar_id":"","url":"https://api.github.com/users/FakeItEasy","html_url":"https://github.com/FakeItEasy","followers_url":"https://api.github.com/users/FakeItEasy/followers","following_url":"https://api.github.com/users/FakeItEasy/following{/other_user}","gists_url":"https://api.github.com/users/FakeItEasy/gists{/gist_id}","starred_url":"https://api.github.com/users/FakeItEasy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FakeItEasy/subscriptions","organizations_url":"https://api.github.com/users/FakeItEasy/orgs","repos_url":"https://api.github.com/users/FakeItEasy/repos","events_url":"https://api.github.com/users/FakeItEasy/events{/privacy}","received_events_url":"https://api.github.com/users/FakeItEasy/received_events","type":"Organization","site_admin":false},"repo":{"id":1920133,"name":"FakeItEasy","full_name":"FakeItEasy/FakeItEasy","owner":{"login":"FakeItEasy","id":1713521,"avatar_url":"https://avatars.githubusercontent.com/u/1713521?v=3","gravatar_id":"","url":"https://api.github.com/users/FakeItEasy","html_url":"https://github.com/FakeItEasy","followers_url":"https://api.github.com/users/FakeItEasy/followers","following_url":"https://api.github.com/users/FakeItEasy/following{/other_user}","gists_url":"https://api.github.com/users/FakeItEasy/gists{/gist_id}","starred_url":"https://api.github.com/users/FakeItEasy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FakeItEasy/subscriptions","organizations_url":"https://api.github.com/users/FakeItEasy/orgs","repos_url":"https://api.github.com/users/FakeItEasy/repos","events_url":"https://api.github.com/users/FakeItEasy/events{/privacy}","received_events_url":"https://api.github.com/users/FakeItEasy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FakeItEasy/FakeItEasy","description":"The easy mocking library for .NET","fork":false,"url":"https://api.github.com/repos/FakeItEasy/FakeItEasy","forks_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/forks","keys_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/teams","hooks_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/hooks","issue_events_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/events{/number}","events_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/events","assignees_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/assignees{/user}","branches_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/branches{/branch}","tags_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/tags","blobs_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/git/refs{/sha}","trees_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/statuses/{sha}","languages_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/languages","stargazers_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/stargazers","contributors_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/contributors","subscribers_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/subscribers","subscription_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/subscription","commits_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/commits{/sha}","git_commits_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/git/commits{/sha}","comments_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/comments{/number}","issue_comment_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/comments{/number}","contents_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/contents/{+path}","compare_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/merges","archive_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/downloads","issues_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues{/number}","pulls_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls{/number}","milestones_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/milestones{/number}","notifications_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/labels{/name}","releases_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/releases{/id}","deployments_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/deployments","created_at":"2011-06-19T17:56:01Z","updated_at":"2016-11-14T20:32:34Z","pushed_at":"2016-11-15T19:13:10Z","git_url":"git://github.com/FakeItEasy/FakeItEasy.git","ssh_url":"git@github.com:FakeItEasy/FakeItEasy.git","clone_url":"https://github.com/FakeItEasy/FakeItEasy.git","svn_url":"https://github.com/FakeItEasy/FakeItEasy","homepage":"fakeiteasy.github.io","size":23036,"stargazers_count":602,"watchers_count":602,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":118,"mirror_url":null,"open_issues_count":43,"forks":118,"open_issues":43,"watchers":602,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/898"},"html":{"href":"https://github.com/FakeItEasy/FakeItEasy/pull/898"},"issue":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/898"},"comments":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/898/comments"},"review_comments":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/898/comments"},"review_comment":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/898/commits"},"statuses":{"href":"https://api.github.com/repos/FakeItEasy/FakeItEasy/statuses/e180e736a76f504980b11b47573c22baeda0db61"}}}}
{"actor":{"display_login":"adamralph"}}