{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/75368988","id":75368988,"diff_hunk":"@@ -12377,13 +12377,10 @@ void Compiler::impImportBlockCode(BasicBlock* block)\n                 {\n                     if ((prefixFlags & PREFIX_TAILCALL_EXPLICIT) != 0)\n                     {\n-#ifdef DEBUG\n-                        if (verbose)\n-                        {\n-                            printf(\"\\n\\nIgnoring the tail call prefix in the inlinee %s\\n\", info.compFullName);\n-                        }\n-#endif\n-                        prefixFlags &= ~PREFIX_TAILCALL_EXPLICIT;\n+                        // TODO: We can inline some callees with explicit tail calls if we can guarantee that the calls\n+                        // can be dispatched as tail calls from the caller.\n+                        compInlineResult->NoteFatal(InlineObservation::CALLEE_EXPLICIT_TAIL_PREFIX);","path":"src/jit/importer.cpp","position":13,"original_position":13,"commit_id":"eb5b51f6854f8a90309c0f4a8529b2901184a2f9","original_commit_id":"eb5b51f6854f8a90309c0f4a8529b2901184a2f9","user":{"login":"erozenfeld","id":10624223,"avatar_url":"https://avatars.githubusercontent.com/u/10624223?v=3","gravatar_id":"","url":"https://api.github.com/users/erozenfeld","html_url":"https://github.com/erozenfeld","followers_url":"https://api.github.com/users/erozenfeld/followers","following_url":"https://api.github.com/users/erozenfeld/following{/other_user}","gists_url":"https://api.github.com/users/erozenfeld/gists{/gist_id}","starred_url":"https://api.github.com/users/erozenfeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erozenfeld/subscriptions","organizations_url":"https://api.github.com/users/erozenfeld/orgs","repos_url":"https://api.github.com/users/erozenfeld/repos","events_url":"https://api.github.com/users/erozenfeld/events{/privacy}","received_events_url":"https://api.github.com/users/erozenfeld/received_events","type":"User","site_admin":false},"body":"fgMakeBasicBlocks doesn't note any inlining observations and is not set up to stop importing an inlinee after a fatal observation.","created_at":"2016-08-18T19:02:30Z","updated_at":"2016-08-18T19:02:30Z","html_url":"https://github.com/dotnet/coreclr/pull/6793#discussion_r75368988","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6793","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/75368988"},"html":{"href":"https://github.com/dotnet/coreclr/pull/6793#discussion_r75368988"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6793"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/6793","id":81856116,"html_url":"https://github.com/dotnet/coreclr/pull/6793","diff_url":"https://github.com/dotnet/coreclr/pull/6793.diff","patch_url":"https://github.com/dotnet/coreclr/pull/6793.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/6793","number":6793,"state":"open","locked":false,"title":"Don't inline methods that have tail-prefixed calls.","user":{"login":"erozenfeld","id":10624223,"avatar_url":"https://avatars.githubusercontent.com/u/10624223?v=3","gravatar_id":"","url":"https://api.github.com/users/erozenfeld","html_url":"https://github.com/erozenfeld","followers_url":"https://api.github.com/users/erozenfeld/followers","following_url":"https://api.github.com/users/erozenfeld/following{/other_user}","gists_url":"https://api.github.com/users/erozenfeld/gists{/gist_id}","starred_url":"https://api.github.com/users/erozenfeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erozenfeld/subscriptions","organizations_url":"https://api.github.com/users/erozenfeld/orgs","repos_url":"https://api.github.com/users/erozenfeld/repos","events_url":"https://api.github.com/users/erozenfeld/events{/privacy}","received_events_url":"https://api.github.com/users/erozenfeld/received_events","type":"User","site_admin":false},"body":"This commit changes the inlining behavior when the callee has tail-prefixed calls.\r\nThe jit was turning tail-prefixed calls in inlinees into normal calls. That means that\r\nin some cases tail prefix wasn't honored. I changed the code to not inline such callees.\r\nThis matches the behavior of the legacy x64 jit. A possible improvement would be to allow\r\ninlining when the tail-prefixed calls in the inlinee could still be dispatched as tail calls from the caller.\r\n\r\nI enabled TailcallVerifyWithPrefix set of tests. They were disabled because Condition8.Test1, Condition8.Test2,\r\nand Condition8.Test3 used varargs calling convention. I commented out code that was calling those tests.\r\nI didn't delete them in case CoreCLR will support varargs in the future.\r\n\r\nI also turned on Condition21.Test1, Condition21.Test2, Condition21.Test3, Condition21.Test6, and Condition21.Test7.\r\nCondition21.Test3 is the test that was failing because the jit was inlining calees with tail-prefixed calls.\r\nThe other Condition21 tests above were passing and just weren't called.\r\n\r\n@BruceForstall @kyulee1 @dotnet/jit-contrib PTAL","created_at":"2016-08-18T17:32:22Z","updated_at":"2016-08-18T19:02:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4a6ed7b3445f0e7d0b4361bad74c9619081b92c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6793/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6793/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/6793/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/eb5b51f6854f8a90309c0f4a8529b2901184a2f9","head":{"label":"erozenfeld:TailCallInCalleeInlining","ref":"TailCallInCalleeInlining","sha":"eb5b51f6854f8a90309c0f4a8529b2901184a2f9","user":{"login":"erozenfeld","id":10624223,"avatar_url":"https://avatars.githubusercontent.com/u/10624223?v=3","gravatar_id":"","url":"https://api.github.com/users/erozenfeld","html_url":"https://github.com/erozenfeld","followers_url":"https://api.github.com/users/erozenfeld/followers","following_url":"https://api.github.com/users/erozenfeld/following{/other_user}","gists_url":"https://api.github.com/users/erozenfeld/gists{/gist_id}","starred_url":"https://api.github.com/users/erozenfeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erozenfeld/subscriptions","organizations_url":"https://api.github.com/users/erozenfeld/orgs","repos_url":"https://api.github.com/users/erozenfeld/repos","events_url":"https://api.github.com/users/erozenfeld/events{/privacy}","received_events_url":"https://api.github.com/users/erozenfeld/received_events","type":"User","site_admin":false},"repo":{"id":37150968,"name":"coreclr","full_name":"erozenfeld/coreclr","owner":{"login":"erozenfeld","id":10624223,"avatar_url":"https://avatars.githubusercontent.com/u/10624223?v=3","gravatar_id":"","url":"https://api.github.com/users/erozenfeld","html_url":"https://github.com/erozenfeld","followers_url":"https://api.github.com/users/erozenfeld/followers","following_url":"https://api.github.com/users/erozenfeld/following{/other_user}","gists_url":"https://api.github.com/users/erozenfeld/gists{/gist_id}","starred_url":"https://api.github.com/users/erozenfeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erozenfeld/subscriptions","organizations_url":"https://api.github.com/users/erozenfeld/orgs","repos_url":"https://api.github.com/users/erozenfeld/repos","events_url":"https://api.github.com/users/erozenfeld/events{/privacy}","received_events_url":"https://api.github.com/users/erozenfeld/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erozenfeld/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/erozenfeld/coreclr","forks_url":"https://api.github.com/repos/erozenfeld/coreclr/forks","keys_url":"https://api.github.com/repos/erozenfeld/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erozenfeld/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erozenfeld/coreclr/teams","hooks_url":"https://api.github.com/repos/erozenfeld/coreclr/hooks","issue_events_url":"https://api.github.com/repos/erozenfeld/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/erozenfeld/coreclr/events","assignees_url":"https://api.github.com/repos/erozenfeld/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/erozenfeld/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/erozenfeld/coreclr/tags","blobs_url":"https://api.github.com/repos/erozenfeld/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erozenfeld/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erozenfeld/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/erozenfeld/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erozenfeld/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/erozenfeld/coreclr/languages","stargazers_url":"https://api.github.com/repos/erozenfeld/coreclr/stargazers","contributors_url":"https://api.github.com/repos/erozenfeld/coreclr/contributors","subscribers_url":"https://api.github.com/repos/erozenfeld/coreclr/subscribers","subscription_url":"https://api.github.com/repos/erozenfeld/coreclr/subscription","commits_url":"https://api.github.com/repos/erozenfeld/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/erozenfeld/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/erozenfeld/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/erozenfeld/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/erozenfeld/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/erozenfeld/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erozenfeld/coreclr/merges","archive_url":"https://api.github.com/repos/erozenfeld/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erozenfeld/coreclr/downloads","issues_url":"https://api.github.com/repos/erozenfeld/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/erozenfeld/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/erozenfeld/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/erozenfeld/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erozenfeld/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/erozenfeld/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/erozenfeld/coreclr/deployments","created_at":"2015-06-09T18:39:42Z","updated_at":"2016-06-02T01:04:42Z","pushed_at":"2016-08-18T17:29:25Z","git_url":"git://github.com/erozenfeld/coreclr.git","ssh_url":"git@github.com:erozenfeld/coreclr.git","clone_url":"https://github.com/erozenfeld/coreclr.git","svn_url":"https://github.com/erozenfeld/coreclr","homepage":"","size":104274,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"03765d17c5a678403ab7410eb7c8dc14d488d352","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-08-18T18:13:05Z","pushed_at":"2016-08-18T18:56:31Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://docs.microsoft.com/dotnet/","size":117023,"stargazers_count":6788,"watchers_count":6788,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1604,"mirror_url":null,"open_issues_count":937,"forks":1604,"open_issues":937,"watchers":6788,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6793"},"html":{"href":"https://github.com/dotnet/coreclr/pull/6793"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/6793"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/6793/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6793/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6793/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/eb5b51f6854f8a90309c0f4a8529b2901184a2f9"}}}}
{"actor":{"display_login":"erozenfeld"}}