{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/77297178","id":77297178,"diff_hunk":"@@ -3,9 +3,21 @@\n  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */\n \n use bindings::{Gecko_ResetStyleCoord, Gecko_SetStyleCoordCalcValue, Gecko_AddRefCalcArbitraryThread};\n+use std::mem;\n use structs::{nsStyleCoord_Calc, nsStyleUnit, nsStyleUnion, nsStyleCoord, nsStyleSides, nsStyleCorners};\n use structs::{nsStyleCoord_CalcValue, nscoord};\n \n+impl nsStyleCoord {\n+    #[inline]\n+    pub fn null() -> Self {\n+        // can't construct directly because it has private\n+        // fields\n+        let mut coord: Self = unsafe { mem::zeroed() };","path":"ports/geckolib/gecko_bindings/sugar/ns_style_coord.rs","position":13,"original_position":13,"commit_id":"9c3fe5b44f3fdd6a14d19540bc89fef0122acfe0","original_commit_id":"9c3fe5b44f3fdd6a14d19540bc89fef0122acfe0","user":{"login":"emilio","id":1323194,"avatar_url":"https://avatars.githubusercontent.com/u/1323194?v=3","gravatar_id":"","url":"https://api.github.com/users/emilio","html_url":"https://github.com/emilio","followers_url":"https://api.github.com/users/emilio/followers","following_url":"https://api.github.com/users/emilio/following{/other_user}","gists_url":"https://api.github.com/users/emilio/gists{/gist_id}","starred_url":"https://api.github.com/users/emilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilio/subscriptions","organizations_url":"https://api.github.com/users/emilio/orgs","repos_url":"https://api.github.com/users/emilio/repos","events_url":"https://api.github.com/users/emilio/events{/privacy}","received_events_url":"https://api.github.com/users/emilio/received_events","type":"User","site_admin":false},"body":"/me *mutters something about accessors...*\r\n\r\nIs the wrapping of the comment intentionally at ~65 chars?\r\n\r\nr=me when it's ready, ideally with the proper wrapping and capitalization in the comment","created_at":"2016-09-02T06:02:38Z","updated_at":"2016-09-02T06:02:38Z","html_url":"https://github.com/servo/servo/pull/13148#discussion_r77297178","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/13148","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/77297178"},"html":{"href":"https://github.com/servo/servo/pull/13148#discussion_r77297178"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/13148"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/13148","id":83565380,"html_url":"https://github.com/servo/servo/pull/13148","diff_url":"https://github.com/servo/servo/pull/13148.diff","patch_url":"https://github.com/servo/servo/pull/13148.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/13148","number":13148,"state":"open","locked":false,"title":"Don't use mem::uninitialized() for making calc values","user":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"body":"We had code relying on `nsStyleCoord::set()` being leaky (like it was\nbefore we patched up the calc bindings). Added `nsStyleCoord::null()` for\nthis use case since it's not possible to construct directly anymore.\n\nr? @emilio\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/13148)\n<!-- Reviewable:end -->\n","created_at":"2016-09-01T03:33:58Z","updated_at":"2016-09-02T06:02:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e73b46fa856ecf565fd3344c18d837883e9f214","assignee":{"login":"emilio","id":1323194,"avatar_url":"https://avatars.githubusercontent.com/u/1323194?v=3","gravatar_id":"","url":"https://api.github.com/users/emilio","html_url":"https://github.com/emilio","followers_url":"https://api.github.com/users/emilio/followers","following_url":"https://api.github.com/users/emilio/following{/other_user}","gists_url":"https://api.github.com/users/emilio/gists{/gist_id}","starred_url":"https://api.github.com/users/emilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilio/subscriptions","organizations_url":"https://api.github.com/users/emilio/orgs","repos_url":"https://api.github.com/users/emilio/repos","events_url":"https://api.github.com/users/emilio/events{/privacy}","received_events_url":"https://api.github.com/users/emilio/received_events","type":"User","site_admin":false},"assignees":[{"login":"emilio","id":1323194,"avatar_url":"https://avatars.githubusercontent.com/u/1323194?v=3","gravatar_id":"","url":"https://api.github.com/users/emilio","html_url":"https://github.com/emilio","followers_url":"https://api.github.com/users/emilio/followers","following_url":"https://api.github.com/users/emilio/following{/other_user}","gists_url":"https://api.github.com/users/emilio/gists{/gist_id}","starred_url":"https://api.github.com/users/emilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilio/subscriptions","organizations_url":"https://api.github.com/users/emilio/orgs","repos_url":"https://api.github.com/users/emilio/repos","events_url":"https://api.github.com/users/emilio/events{/privacy}","received_events_url":"https://api.github.com/users/emilio/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/13148/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/13148/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/13148/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/9c3fe5b44f3fdd6a14d19540bc89fef0122acfe0","head":{"label":"Manishearth:calc-null","ref":"calc-null","sha":"9c3fe5b44f3fdd6a14d19540bc89fef0122acfe0","user":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"repo":{"id":17138296,"name":"servo","full_name":"Manishearth/servo","owner":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Manishearth/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/Manishearth/servo","forks_url":"https://api.github.com/repos/Manishearth/servo/forks","keys_url":"https://api.github.com/repos/Manishearth/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Manishearth/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Manishearth/servo/teams","hooks_url":"https://api.github.com/repos/Manishearth/servo/hooks","issue_events_url":"https://api.github.com/repos/Manishearth/servo/issues/events{/number}","events_url":"https://api.github.com/repos/Manishearth/servo/events","assignees_url":"https://api.github.com/repos/Manishearth/servo/assignees{/user}","branches_url":"https://api.github.com/repos/Manishearth/servo/branches{/branch}","tags_url":"https://api.github.com/repos/Manishearth/servo/tags","blobs_url":"https://api.github.com/repos/Manishearth/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Manishearth/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Manishearth/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/Manishearth/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Manishearth/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/Manishearth/servo/languages","stargazers_url":"https://api.github.com/repos/Manishearth/servo/stargazers","contributors_url":"https://api.github.com/repos/Manishearth/servo/contributors","subscribers_url":"https://api.github.com/repos/Manishearth/servo/subscribers","subscription_url":"https://api.github.com/repos/Manishearth/servo/subscription","commits_url":"https://api.github.com/repos/Manishearth/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/Manishearth/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/Manishearth/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/Manishearth/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/Manishearth/servo/contents/{+path}","compare_url":"https://api.github.com/repos/Manishearth/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Manishearth/servo/merges","archive_url":"https://api.github.com/repos/Manishearth/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Manishearth/servo/downloads","issues_url":"https://api.github.com/repos/Manishearth/servo/issues{/number}","pulls_url":"https://api.github.com/repos/Manishearth/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/Manishearth/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/Manishearth/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Manishearth/servo/labels{/name}","releases_url":"https://api.github.com/repos/Manishearth/servo/releases{/id}","deployments_url":"https://api.github.com/repos/Manishearth/servo/deployments","created_at":"2014-02-24T14:18:00Z","updated_at":"2015-10-18T11:13:31Z","pushed_at":"2016-09-02T03:25:43Z","git_url":"git://github.com/Manishearth/servo.git","ssh_url":"git@github.com:Manishearth/servo.git","clone_url":"https://github.com/Manishearth/servo.git","svn_url":"https://github.com/Manishearth/servo","homepage":"","size":203652,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"78baf21c54c954e5ebdea23aff5aa62198709027","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2016-09-02T03:50:53Z","pushed_at":"2016-09-02T03:51:39Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":293174,"stargazers_count":7842,"watchers_count":7842,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1267,"mirror_url":null,"open_issues_count":1732,"forks":1267,"open_issues":1732,"watchers":7842,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/13148"},"html":{"href":"https://github.com/servo/servo/pull/13148"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/13148"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/13148/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/13148/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/13148/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/9c3fe5b44f3fdd6a14d19540bc89fef0122acfe0"}}}}
{"actor":{"display_login":"emilio"}}