{"action":"created","comment":{"url":"https://api.github.com/repos/caelum/vraptor-simplemail/pulls/comments/54353950","id":54353950,"diff_hunk":"@@ -35,9 +35,6 @@ public Mailer getInstance() {\n \t}\n \n \tprivate Mailer grabInstance() {\n-\t\tif (env.getName().equals(\"development\")) {\n-\t\t\treturn new MockMailer();\n-\t\t}","path":"src/main/java/br/com/caelum/vraptor/simplemail/MailerFactory.java","position":6,"original_position":6,"commit_id":"e803d24a7b2f080b9d0afcf67acf8acb0449f887","original_commit_id":"e803d24a7b2f080b9d0afcf67acf8acb0449f887","user":{"login":"xdarklight","id":5102713,"avatar_url":"https://avatars.githubusercontent.com/u/5102713?v=3","gravatar_id":"","url":"https://api.github.com/users/xdarklight","html_url":"https://github.com/xdarklight","followers_url":"https://api.github.com/users/xdarklight/followers","following_url":"https://api.github.com/users/xdarklight/following{/other_user}","gists_url":"https://api.github.com/users/xdarklight/gists{/gist_id}","starred_url":"https://api.github.com/users/xdarklight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xdarklight/subscriptions","organizations_url":"https://api.github.com/users/xdarklight/orgs","repos_url":"https://api.github.com/users/xdarklight/repos","events_url":"https://api.github.com/users/xdarklight/events{/privacy}","received_events_url":"https://api.github.com/users/xdarklight/received_events","type":"User","site_admin":false},"body":"I don't think that this is a problem @Turini \r\nOld behavior: MockMailer was used regardless of the \"mailer.implementation\" configuration.\r\nNew behavior: MockMailer is used if \"mailer.implementation\" is not configured, otherwise the impl from \"mailer.implementation\" is used.\r\n\r\nThe VRaptor3 version behaves exactly the same as the \"new behavior\" if I read the code correctly.\r\nThere was also a VRaptor3 commit (31970efa6ce701f1fb873448616898574d03f2f6) which enabled emails in the development env - exactly what this patch does.\r\n\r\nSo in **my** humble opinion, no new toggle is required.","created_at":"2016-02-28T18:27:30Z","updated_at":"2016-02-28T18:27:30Z","html_url":"https://github.com/caelum/vraptor-simplemail/pull/28#discussion_r54353950","pull_request_url":"https://api.github.com/repos/caelum/vraptor-simplemail/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/caelum/vraptor-simplemail/pulls/comments/54353950"},"html":{"href":"https://github.com/caelum/vraptor-simplemail/pull/28#discussion_r54353950"},"pull_request":{"href":"https://api.github.com/repos/caelum/vraptor-simplemail/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/caelum/vraptor-simplemail/pulls/28","id":56325410,"html_url":"https://github.com/caelum/vraptor-simplemail/pull/28","diff_url":"https://github.com/caelum/vraptor-simplemail/pull/28.diff","patch_url":"https://github.com/caelum/vraptor-simplemail/pull/28.patch","issue_url":"https://api.github.com/repos/caelum/vraptor-simplemail/issues/28","number":28,"state":"closed","locked":false,"title":"added SSL option","user":{"login":"JamesSullivan","id":1272400,"avatar_url":"https://avatars.githubusercontent.com/u/1272400?v=3","gravatar_id":"","url":"https://api.github.com/users/JamesSullivan","html_url":"https://github.com/JamesSullivan","followers_url":"https://api.github.com/users/JamesSullivan/followers","following_url":"https://api.github.com/users/JamesSullivan/following{/other_user}","gists_url":"https://api.github.com/users/JamesSullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/JamesSullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamesSullivan/subscriptions","organizations_url":"https://api.github.com/users/JamesSullivan/orgs","repos_url":"https://api.github.com/users/JamesSullivan/repos","events_url":"https://api.github.com/users/JamesSullivan/events{/privacy}","received_events_url":"https://api.github.com/users/JamesSullivan/received_events","type":"User","site_admin":false},"body":"This is necessary to use many E-mail services.","created_at":"2016-01-18T10:35:33Z","updated_at":"2016-02-28T18:27:30Z","closed_at":"2016-02-26T17:54:13Z","merged_at":"2016-02-26T17:54:13Z","merge_commit_sha":"ef97780252eb3ab323cd815cdf46d0f6c8a9110d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/caelum/vraptor-simplemail/pulls/28/commits","review_comments_url":"https://api.github.com/repos/caelum/vraptor-simplemail/pulls/28/comments","review_comment_url":"https://api.github.com/repos/caelum/vraptor-simplemail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caelum/vraptor-simplemail/issues/28/comments","statuses_url":"https://api.github.com/repos/caelum/vraptor-simplemail/statuses/e803d24a7b2f080b9d0afcf67acf8acb0449f887","head":{"label":"JamesSullivan:VRaptor4Version","ref":"VRaptor4Version","sha":"e803d24a7b2f080b9d0afcf67acf8acb0449f887","user":{"login":"JamesSullivan","id":1272400,"avatar_url":"https://avatars.githubusercontent.com/u/1272400?v=3","gravatar_id":"","url":"https://api.github.com/users/JamesSullivan","html_url":"https://github.com/JamesSullivan","followers_url":"https://api.github.com/users/JamesSullivan/followers","following_url":"https://api.github.com/users/JamesSullivan/following{/other_user}","gists_url":"https://api.github.com/users/JamesSullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/JamesSullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamesSullivan/subscriptions","organizations_url":"https://api.github.com/users/JamesSullivan/orgs","repos_url":"https://api.github.com/users/JamesSullivan/repos","events_url":"https://api.github.com/users/JamesSullivan/events{/privacy}","received_events_url":"https://api.github.com/users/JamesSullivan/received_events","type":"User","site_admin":false},"repo":{"id":49865509,"name":"vraptor-simplemail","full_name":"JamesSullivan/vraptor-simplemail","owner":{"login":"JamesSullivan","id":1272400,"avatar_url":"https://avatars.githubusercontent.com/u/1272400?v=3","gravatar_id":"","url":"https://api.github.com/users/JamesSullivan","html_url":"https://github.com/JamesSullivan","followers_url":"https://api.github.com/users/JamesSullivan/followers","following_url":"https://api.github.com/users/JamesSullivan/following{/other_user}","gists_url":"https://api.github.com/users/JamesSullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/JamesSullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamesSullivan/subscriptions","organizations_url":"https://api.github.com/users/JamesSullivan/orgs","repos_url":"https://api.github.com/users/JamesSullivan/repos","events_url":"https://api.github.com/users/JamesSullivan/events{/privacy}","received_events_url":"https://api.github.com/users/JamesSullivan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JamesSullivan/vraptor-simplemail","description":"Simple mailer for vraptor","fork":true,"url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail","forks_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/forks","keys_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/teams","hooks_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/hooks","issue_events_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/issues/events{/number}","events_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/events","assignees_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/assignees{/user}","branches_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/branches{/branch}","tags_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/tags","blobs_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/git/refs{/sha}","trees_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/statuses/{sha}","languages_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/languages","stargazers_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/stargazers","contributors_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/contributors","subscribers_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/subscribers","subscription_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/subscription","commits_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/commits{/sha}","git_commits_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/git/commits{/sha}","comments_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/comments{/number}","issue_comment_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/issues/comments{/number}","contents_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/contents/{+path}","compare_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/merges","archive_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/downloads","issues_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/issues{/number}","pulls_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/pulls{/number}","milestones_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/milestones{/number}","notifications_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/labels{/name}","releases_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/releases{/id}","deployments_url":"https://api.github.com/repos/JamesSullivan/vraptor-simplemail/deployments","created_at":"2016-01-18T09:17:51Z","updated_at":"2016-01-18T09:17:52Z","pushed_at":"2016-01-20T01:28:38Z","git_url":"git://github.com/JamesSullivan/vraptor-simplemail.git","ssh_url":"git@github.com:JamesSullivan/vraptor-simplemail.git","clone_url":"https://github.com/JamesSullivan/vraptor-simplemail.git","svn_url":"https://github.com/JamesSullivan/vraptor-simplemail","homepage":"","size":141,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"caelum:VRaptor4Version","ref":"VRaptor4Version","sha":"596e5a1f1ef7ae26d8530a0b0c3ffc761a709b3f","user":{"login":"caelum","id":65012,"avatar_url":"https://avatars.githubusercontent.com/u/65012?v=3","gravatar_id":"","url":"https://api.github.com/users/caelum","html_url":"https://github.com/caelum","followers_url":"https://api.github.com/users/caelum/followers","following_url":"https://api.github.com/users/caelum/following{/other_user}","gists_url":"https://api.github.com/users/caelum/gists{/gist_id}","starred_url":"https://api.github.com/users/caelum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caelum/subscriptions","organizations_url":"https://api.github.com/users/caelum/orgs","repos_url":"https://api.github.com/users/caelum/repos","events_url":"https://api.github.com/users/caelum/events{/privacy}","received_events_url":"https://api.github.com/users/caelum/received_events","type":"Organization","site_admin":false},"repo":{"id":1557318,"name":"vraptor-simplemail","full_name":"caelum/vraptor-simplemail","owner":{"login":"caelum","id":65012,"avatar_url":"https://avatars.githubusercontent.com/u/65012?v=3","gravatar_id":"","url":"https://api.github.com/users/caelum","html_url":"https://github.com/caelum","followers_url":"https://api.github.com/users/caelum/followers","following_url":"https://api.github.com/users/caelum/following{/other_user}","gists_url":"https://api.github.com/users/caelum/gists{/gist_id}","starred_url":"https://api.github.com/users/caelum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caelum/subscriptions","organizations_url":"https://api.github.com/users/caelum/orgs","repos_url":"https://api.github.com/users/caelum/repos","events_url":"https://api.github.com/users/caelum/events{/privacy}","received_events_url":"https://api.github.com/users/caelum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caelum/vraptor-simplemail","description":"Simple mailer for vraptor","fork":false,"url":"https://api.github.com/repos/caelum/vraptor-simplemail","forks_url":"https://api.github.com/repos/caelum/vraptor-simplemail/forks","keys_url":"https://api.github.com/repos/caelum/vraptor-simplemail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caelum/vraptor-simplemail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caelum/vraptor-simplemail/teams","hooks_url":"https://api.github.com/repos/caelum/vraptor-simplemail/hooks","issue_events_url":"https://api.github.com/repos/caelum/vraptor-simplemail/issues/events{/number}","events_url":"https://api.github.com/repos/caelum/vraptor-simplemail/events","assignees_url":"https://api.github.com/repos/caelum/vraptor-simplemail/assignees{/user}","branches_url":"https://api.github.com/repos/caelum/vraptor-simplemail/branches{/branch}","tags_url":"https://api.github.com/repos/caelum/vraptor-simplemail/tags","blobs_url":"https://api.github.com/repos/caelum/vraptor-simplemail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caelum/vraptor-simplemail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caelum/vraptor-simplemail/git/refs{/sha}","trees_url":"https://api.github.com/repos/caelum/vraptor-simplemail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caelum/vraptor-simplemail/statuses/{sha}","languages_url":"https://api.github.com/repos/caelum/vraptor-simplemail/languages","stargazers_url":"https://api.github.com/repos/caelum/vraptor-simplemail/stargazers","contributors_url":"https://api.github.com/repos/caelum/vraptor-simplemail/contributors","subscribers_url":"https://api.github.com/repos/caelum/vraptor-simplemail/subscribers","subscription_url":"https://api.github.com/repos/caelum/vraptor-simplemail/subscription","commits_url":"https://api.github.com/repos/caelum/vraptor-simplemail/commits{/sha}","git_commits_url":"https://api.github.com/repos/caelum/vraptor-simplemail/git/commits{/sha}","comments_url":"https://api.github.com/repos/caelum/vraptor-simplemail/comments{/number}","issue_comment_url":"https://api.github.com/repos/caelum/vraptor-simplemail/issues/comments{/number}","contents_url":"https://api.github.com/repos/caelum/vraptor-simplemail/contents/{+path}","compare_url":"https://api.github.com/repos/caelum/vraptor-simplemail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caelum/vraptor-simplemail/merges","archive_url":"https://api.github.com/repos/caelum/vraptor-simplemail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caelum/vraptor-simplemail/downloads","issues_url":"https://api.github.com/repos/caelum/vraptor-simplemail/issues{/number}","pulls_url":"https://api.github.com/repos/caelum/vraptor-simplemail/pulls{/number}","milestones_url":"https://api.github.com/repos/caelum/vraptor-simplemail/milestones{/number}","notifications_url":"https://api.github.com/repos/caelum/vraptor-simplemail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caelum/vraptor-simplemail/labels{/name}","releases_url":"https://api.github.com/repos/caelum/vraptor-simplemail/releases{/id}","deployments_url":"https://api.github.com/repos/caelum/vraptor-simplemail/deployments","created_at":"2011-04-01T20:45:51Z","updated_at":"2016-02-24T19:53:31Z","pushed_at":"2016-02-26T17:54:13Z","git_url":"git://github.com/caelum/vraptor-simplemail.git","ssh_url":"git@github.com:caelum/vraptor-simplemail.git","clone_url":"https://github.com/caelum/vraptor-simplemail.git","svn_url":"https://github.com/caelum/vraptor-simplemail","homepage":"","size":149,"stargazers_count":17,"watchers_count":17,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":9,"forks":18,"open_issues":9,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/caelum/vraptor-simplemail/pulls/28"},"html":{"href":"https://github.com/caelum/vraptor-simplemail/pull/28"},"issue":{"href":"https://api.github.com/repos/caelum/vraptor-simplemail/issues/28"},"comments":{"href":"https://api.github.com/repos/caelum/vraptor-simplemail/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/caelum/vraptor-simplemail/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/caelum/vraptor-simplemail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caelum/vraptor-simplemail/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/caelum/vraptor-simplemail/statuses/e803d24a7b2f080b9d0afcf67acf8acb0449f887"}}}}