{"action":"created","comment":{"url":"https://api.github.com/repos/Jasig/NotificationPortlet/pulls/comments/93973354","pull_request_review_id":14503161,"id":93973354,"diff_hunk":"@@ -114,16 +115,19 @@ public void setName(String name) {\n      */\n     public void setRecipients(Set<JpaRecipient> recipients) {\n         this.recipients.clear();\n-        for (JpaRecipient recip : recipients) {\n-            addRecipient(recip);\n-        }\n+        this.recipients.addAll(recipients);\n     }\n \n     /**\n      * Adds the specified recipient to the current collection.\n      */\n     public void addRecipient(JpaRecipient recipient) {\n         recipients.add(recipient);\n-        recipient.setAddresseeId(getId());\n     }\n+\n+    @Override\n+    public String toString() {\n+        return \"JpaAddressee [id=\" + id + \", name=\" + name + \", type=\" + type + \", recipients=\" + recipients + \"]\";","path":"notification-portlet-webapp/src/main/java/org/jasig/portlet/notice/service/jpa/JpaAddressee.java","position":65,"original_position":65,"commit_id":"c74c65b9403287e384da5a53147aeec0795efc49","original_commit_id":"c74c65b9403287e384da5a53147aeec0795efc49","user":{"login":"ChristianMurphy","id":3107513,"avatar_url":"https://avatars.githubusercontent.com/u/3107513?v=3","gravatar_id":"","url":"https://api.github.com/users/ChristianMurphy","html_url":"https://github.com/ChristianMurphy","followers_url":"https://api.github.com/users/ChristianMurphy/followers","following_url":"https://api.github.com/users/ChristianMurphy/following{/other_user}","gists_url":"https://api.github.com/users/ChristianMurphy/gists{/gist_id}","starred_url":"https://api.github.com/users/ChristianMurphy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChristianMurphy/subscriptions","organizations_url":"https://api.github.com/users/ChristianMurphy/orgs","repos_url":"https://api.github.com/users/ChristianMurphy/repos","events_url":"https://api.github.com/users/ChristianMurphy/events{/privacy}","received_events_url":"https://api.github.com/users/ChristianMurphy/received_events","type":"User","site_admin":false},"body":"would [`org.apache.commons.lang3.builder.ToStringBuilder`](https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/builder/ToStringBuilder.html) be a more effective way to generate this string?","created_at":"2016-12-27T21:43:36Z","updated_at":"2016-12-27T21:46:15Z","html_url":"https://github.com/Jasig/NotificationPortlet/pull/41#discussion_r93973354","pull_request_url":"https://api.github.com/repos/Jasig/NotificationPortlet/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/Jasig/NotificationPortlet/pulls/comments/93973354"},"html":{"href":"https://github.com/Jasig/NotificationPortlet/pull/41#discussion_r93973354"},"pull_request":{"href":"https://api.github.com/repos/Jasig/NotificationPortlet/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/Jasig/NotificationPortlet/pulls/41","id":99177782,"html_url":"https://github.com/Jasig/NotificationPortlet/pull/41","diff_url":"https://github.com/Jasig/NotificationPortlet/pull/41.diff","patch_url":"https://github.com/Jasig/NotificationPortlet/pull/41.patch","issue_url":"https://api.github.com/repos/Jasig/NotificationPortlet/issues/41","number":41,"state":"open","locked":false,"title":"NOTIFPLT-80:  Refactor HideNotificationServiceDecorator to use JPA (d…","user":{"login":"drewwills","id":1127174,"avatar_url":"https://avatars.githubusercontent.com/u/1127174?v=3","gravatar_id":"","url":"https://api.github.com/users/drewwills","html_url":"https://github.com/drewwills","followers_url":"https://api.github.com/users/drewwills/followers","following_url":"https://api.github.com/users/drewwills/following{/other_user}","gists_url":"https://api.github.com/users/drewwills/gists{/gist_id}","starred_url":"https://api.github.com/users/drewwills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewwills/subscriptions","organizations_url":"https://api.github.com/users/drewwills/orgs","repos_url":"https://api.github.com/users/drewwills/repos","events_url":"https://api.github.com/users/drewwills/events{/privacy}","received_events_url":"https://api.github.com/users/drewwills/received_events","type":"User","site_admin":false},"body":"…atabase tables) to track hidden notifications instead of Portlet Preferences\r\n\r\nhttps://issues.jasig.org/browse/NOTIFPLT-80\r\n\r\nCurrently the HideNotificationServiceDecorator uses portlet preferences to track which notices are hidden.  This approach causes problems because each portlet has it's own set of preferences -- e.g. the main 'notification' portlet and the 'notification-icon' portlet.\r\n\r\nIn other words, when you hide (snooze) a notice in the main portlet it vanishes (for the snooze duration), but the badge number in the notification-icon portlet still includes it (it should decrement by one).\r\n\r\n_ALSO_ it would be great, while we're at it, to allow notifications to specify their own snooze duration.","created_at":"2016-12-22T22:11:42Z","updated_at":"2016-12-27T21:46:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a65df6b2f471999476db5f5f2b5f48053b3f63f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Jasig/NotificationPortlet/pulls/41/commits","review_comments_url":"https://api.github.com/repos/Jasig/NotificationPortlet/pulls/41/comments","review_comment_url":"https://api.github.com/repos/Jasig/NotificationPortlet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Jasig/NotificationPortlet/issues/41/comments","statuses_url":"https://api.github.com/repos/Jasig/NotificationPortlet/statuses/c74c65b9403287e384da5a53147aeec0795efc49","head":{"label":"drewwills:NOTIFPLT-80","ref":"NOTIFPLT-80","sha":"c74c65b9403287e384da5a53147aeec0795efc49","user":{"login":"drewwills","id":1127174,"avatar_url":"https://avatars.githubusercontent.com/u/1127174?v=3","gravatar_id":"","url":"https://api.github.com/users/drewwills","html_url":"https://github.com/drewwills","followers_url":"https://api.github.com/users/drewwills/followers","following_url":"https://api.github.com/users/drewwills/following{/other_user}","gists_url":"https://api.github.com/users/drewwills/gists{/gist_id}","starred_url":"https://api.github.com/users/drewwills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewwills/subscriptions","organizations_url":"https://api.github.com/users/drewwills/orgs","repos_url":"https://api.github.com/users/drewwills/repos","events_url":"https://api.github.com/users/drewwills/events{/privacy}","received_events_url":"https://api.github.com/users/drewwills/received_events","type":"User","site_admin":false},"repo":{"id":25313215,"name":"NotificationPortlet","full_name":"drewwills/NotificationPortlet","owner":{"login":"drewwills","id":1127174,"avatar_url":"https://avatars.githubusercontent.com/u/1127174?v=3","gravatar_id":"","url":"https://api.github.com/users/drewwills","html_url":"https://github.com/drewwills","followers_url":"https://api.github.com/users/drewwills/followers","following_url":"https://api.github.com/users/drewwills/following{/other_user}","gists_url":"https://api.github.com/users/drewwills/gists{/gist_id}","starred_url":"https://api.github.com/users/drewwills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewwills/subscriptions","organizations_url":"https://api.github.com/users/drewwills/orgs","repos_url":"https://api.github.com/users/drewwills/repos","events_url":"https://api.github.com/users/drewwills/events{/privacy}","received_events_url":"https://api.github.com/users/drewwills/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drewwills/NotificationPortlet","description":null,"fork":true,"url":"https://api.github.com/repos/drewwills/NotificationPortlet","forks_url":"https://api.github.com/repos/drewwills/NotificationPortlet/forks","keys_url":"https://api.github.com/repos/drewwills/NotificationPortlet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drewwills/NotificationPortlet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drewwills/NotificationPortlet/teams","hooks_url":"https://api.github.com/repos/drewwills/NotificationPortlet/hooks","issue_events_url":"https://api.github.com/repos/drewwills/NotificationPortlet/issues/events{/number}","events_url":"https://api.github.com/repos/drewwills/NotificationPortlet/events","assignees_url":"https://api.github.com/repos/drewwills/NotificationPortlet/assignees{/user}","branches_url":"https://api.github.com/repos/drewwills/NotificationPortlet/branches{/branch}","tags_url":"https://api.github.com/repos/drewwills/NotificationPortlet/tags","blobs_url":"https://api.github.com/repos/drewwills/NotificationPortlet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drewwills/NotificationPortlet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drewwills/NotificationPortlet/git/refs{/sha}","trees_url":"https://api.github.com/repos/drewwills/NotificationPortlet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drewwills/NotificationPortlet/statuses/{sha}","languages_url":"https://api.github.com/repos/drewwills/NotificationPortlet/languages","stargazers_url":"https://api.github.com/repos/drewwills/NotificationPortlet/stargazers","contributors_url":"https://api.github.com/repos/drewwills/NotificationPortlet/contributors","subscribers_url":"https://api.github.com/repos/drewwills/NotificationPortlet/subscribers","subscription_url":"https://api.github.com/repos/drewwills/NotificationPortlet/subscription","commits_url":"https://api.github.com/repos/drewwills/NotificationPortlet/commits{/sha}","git_commits_url":"https://api.github.com/repos/drewwills/NotificationPortlet/git/commits{/sha}","comments_url":"https://api.github.com/repos/drewwills/NotificationPortlet/comments{/number}","issue_comment_url":"https://api.github.com/repos/drewwills/NotificationPortlet/issues/comments{/number}","contents_url":"https://api.github.com/repos/drewwills/NotificationPortlet/contents/{+path}","compare_url":"https://api.github.com/repos/drewwills/NotificationPortlet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drewwills/NotificationPortlet/merges","archive_url":"https://api.github.com/repos/drewwills/NotificationPortlet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drewwills/NotificationPortlet/downloads","issues_url":"https://api.github.com/repos/drewwills/NotificationPortlet/issues{/number}","pulls_url":"https://api.github.com/repos/drewwills/NotificationPortlet/pulls{/number}","milestones_url":"https://api.github.com/repos/drewwills/NotificationPortlet/milestones{/number}","notifications_url":"https://api.github.com/repos/drewwills/NotificationPortlet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drewwills/NotificationPortlet/labels{/name}","releases_url":"https://api.github.com/repos/drewwills/NotificationPortlet/releases{/id}","deployments_url":"https://api.github.com/repos/drewwills/NotificationPortlet/deployments","created_at":"2014-10-16T17:23:04Z","updated_at":"2014-09-11T22:35:27Z","pushed_at":"2016-12-22T22:52:44Z","git_url":"git://github.com/drewwills/NotificationPortlet.git","ssh_url":"git@github.com:drewwills/NotificationPortlet.git","clone_url":"https://github.com/drewwills/NotificationPortlet.git","svn_url":"https://github.com/drewwills/NotificationPortlet","homepage":"","size":1090,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Jasig:master","ref":"master","sha":"0357083e4215ca434bb3249a13394535812545f4","user":{"login":"Jasig","id":884285,"avatar_url":"https://avatars.githubusercontent.com/u/884285?v=3","gravatar_id":"","url":"https://api.github.com/users/Jasig","html_url":"https://github.com/Jasig","followers_url":"https://api.github.com/users/Jasig/followers","following_url":"https://api.github.com/users/Jasig/following{/other_user}","gists_url":"https://api.github.com/users/Jasig/gists{/gist_id}","starred_url":"https://api.github.com/users/Jasig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jasig/subscriptions","organizations_url":"https://api.github.com/users/Jasig/orgs","repos_url":"https://api.github.com/users/Jasig/repos","events_url":"https://api.github.com/users/Jasig/events{/privacy}","received_events_url":"https://api.github.com/users/Jasig/received_events","type":"Organization","site_admin":false},"repo":{"id":3722299,"name":"NotificationPortlet","full_name":"Jasig/NotificationPortlet","owner":{"login":"Jasig","id":884285,"avatar_url":"https://avatars.githubusercontent.com/u/884285?v=3","gravatar_id":"","url":"https://api.github.com/users/Jasig","html_url":"https://github.com/Jasig","followers_url":"https://api.github.com/users/Jasig/followers","following_url":"https://api.github.com/users/Jasig/following{/other_user}","gists_url":"https://api.github.com/users/Jasig/gists{/gist_id}","starred_url":"https://api.github.com/users/Jasig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jasig/subscriptions","organizations_url":"https://api.github.com/users/Jasig/orgs","repos_url":"https://api.github.com/users/Jasig/repos","events_url":"https://api.github.com/users/Jasig/events{/privacy}","received_events_url":"https://api.github.com/users/Jasig/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Jasig/NotificationPortlet","description":"JSR-286 portlet implementing notifications in uPortal.","fork":false,"url":"https://api.github.com/repos/Jasig/NotificationPortlet","forks_url":"https://api.github.com/repos/Jasig/NotificationPortlet/forks","keys_url":"https://api.github.com/repos/Jasig/NotificationPortlet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jasig/NotificationPortlet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jasig/NotificationPortlet/teams","hooks_url":"https://api.github.com/repos/Jasig/NotificationPortlet/hooks","issue_events_url":"https://api.github.com/repos/Jasig/NotificationPortlet/issues/events{/number}","events_url":"https://api.github.com/repos/Jasig/NotificationPortlet/events","assignees_url":"https://api.github.com/repos/Jasig/NotificationPortlet/assignees{/user}","branches_url":"https://api.github.com/repos/Jasig/NotificationPortlet/branches{/branch}","tags_url":"https://api.github.com/repos/Jasig/NotificationPortlet/tags","blobs_url":"https://api.github.com/repos/Jasig/NotificationPortlet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jasig/NotificationPortlet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jasig/NotificationPortlet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jasig/NotificationPortlet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jasig/NotificationPortlet/statuses/{sha}","languages_url":"https://api.github.com/repos/Jasig/NotificationPortlet/languages","stargazers_url":"https://api.github.com/repos/Jasig/NotificationPortlet/stargazers","contributors_url":"https://api.github.com/repos/Jasig/NotificationPortlet/contributors","subscribers_url":"https://api.github.com/repos/Jasig/NotificationPortlet/subscribers","subscription_url":"https://api.github.com/repos/Jasig/NotificationPortlet/subscription","commits_url":"https://api.github.com/repos/Jasig/NotificationPortlet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jasig/NotificationPortlet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jasig/NotificationPortlet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jasig/NotificationPortlet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jasig/NotificationPortlet/contents/{+path}","compare_url":"https://api.github.com/repos/Jasig/NotificationPortlet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jasig/NotificationPortlet/merges","archive_url":"https://api.github.com/repos/Jasig/NotificationPortlet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jasig/NotificationPortlet/downloads","issues_url":"https://api.github.com/repos/Jasig/NotificationPortlet/issues{/number}","pulls_url":"https://api.github.com/repos/Jasig/NotificationPortlet/pulls{/number}","milestones_url":"https://api.github.com/repos/Jasig/NotificationPortlet/milestones{/number}","notifications_url":"https://api.github.com/repos/Jasig/NotificationPortlet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jasig/NotificationPortlet/labels{/name}","releases_url":"https://api.github.com/repos/Jasig/NotificationPortlet/releases{/id}","deployments_url":"https://api.github.com/repos/Jasig/NotificationPortlet/deployments","created_at":"2012-03-14T21:02:19Z","updated_at":"2016-12-20T16:58:11Z","pushed_at":"2016-12-22T22:52:46Z","git_url":"git://github.com/Jasig/NotificationPortlet.git","ssh_url":"git@github.com:Jasig/NotificationPortlet.git","clone_url":"https://github.com/Jasig/NotificationPortlet.git","svn_url":"https://github.com/Jasig/NotificationPortlet","homepage":"https://wiki.jasig.org/pages/viewpage.action?pageId=47875986","size":1068,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":4,"forks":19,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Jasig/NotificationPortlet/pulls/41"},"html":{"href":"https://github.com/Jasig/NotificationPortlet/pull/41"},"issue":{"href":"https://api.github.com/repos/Jasig/NotificationPortlet/issues/41"},"comments":{"href":"https://api.github.com/repos/Jasig/NotificationPortlet/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/Jasig/NotificationPortlet/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/Jasig/NotificationPortlet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Jasig/NotificationPortlet/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/Jasig/NotificationPortlet/statuses/c74c65b9403287e384da5a53147aeec0795efc49"}}}}
{"actor":{"display_login":"ChristianMurphy"}}