{"action":"created","issue":{"url":"https://api.github.com/repos/DamonOehlman/addressit/issues/17","repository_url":"https://api.github.com/repos/DamonOehlman/addressit","labels_url":"https://api.github.com/repos/DamonOehlman/addressit/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/DamonOehlman/addressit/issues/17/comments","events_url":"https://api.github.com/repos/DamonOehlman/addressit/issues/17/events","html_url":"https://github.com/DamonOehlman/addressit/pull/17","id":158190171,"number":17,"title":"Fix for Numerical Split Streets","user":{"login":"awmichel","id":228378,"avatar_url":"https://avatars.githubusercontent.com/u/228378?v=3","gravatar_id":"","url":"https://api.github.com/users/awmichel","html_url":"https://github.com/awmichel","followers_url":"https://api.github.com/users/awmichel/followers","following_url":"https://api.github.com/users/awmichel/following{/other_user}","gists_url":"https://api.github.com/users/awmichel/gists{/gist_id}","starred_url":"https://api.github.com/users/awmichel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awmichel/subscriptions","organizations_url":"https://api.github.com/users/awmichel/orgs","repos_url":"https://api.github.com/users/awmichel/repos","events_url":"https://api.github.com/users/awmichel/events{/privacy}","received_events_url":"https://api.github.com/users/awmichel/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-06-02T16:57:49Z","updated_at":"2016-06-14T02:41:14Z","closed_at":"2016-06-14T02:31:51Z","pull_request":{"url":"https://api.github.com/repos/DamonOehlman/addressit/pulls/17","html_url":"https://github.com/DamonOehlman/addressit/pull/17","diff_url":"https://github.com/DamonOehlman/addressit/pull/17.diff","patch_url":"https://github.com/DamonOehlman/addressit/pull/17.patch"},"body":"Example: `601 21st Ave N, Myrtle Beach, SC 29577`\r\n\r\nCurrent Output:\r\n```json\r\n{\r\n  \"number\": \"601/21st\",\r\n  \"street\": \"Ave N\",\r\n  \"state\": \"SC\",\r\n  \"regions\": [\"Myrtle Beach\"],\r\n  \"postalcode\": \"29577\"\r\n}\r\n```\r\n\r\nExpected Output:\r\n```json\r\n{\r\n  \"number\": \"601\",\r\n  \"street\": \"21st Ave N\",\r\n  \"state\": \"SC\",\r\n  \"regions\": [\"Myrtle Beach\"],\r\n  \"postalcode\": \"29577\"\r\n}\r\n```\r\n\r\nThere are a couple addresses I have found which are split N,S,E,W, but also on a numbered avenue. In the existing `_extractStreetParts` implementation, the `21st` part is identified as a numberPart since it is numeric and the expected number of street parts is 2. By letting the function know we are dealing with a split street (as identified in `extractStreet`) we can increase the number of expected street parts to 3 and capture the `21st` part of the street name.\r\n\r\nI added a couple of known split street tests to ensure this functions correctly now and in the future."},"comment":{"url":"https://api.github.com/repos/DamonOehlman/addressit/issues/comments/225765161","html_url":"https://github.com/DamonOehlman/addressit/pull/17#issuecomment-225765161","issue_url":"https://api.github.com/repos/DamonOehlman/addressit/issues/17","id":225765161,"user":{"login":"DamonOehlman","id":609693,"avatar_url":"https://avatars.githubusercontent.com/u/609693?v=3","gravatar_id":"","url":"https://api.github.com/users/DamonOehlman","html_url":"https://github.com/DamonOehlman","followers_url":"https://api.github.com/users/DamonOehlman/followers","following_url":"https://api.github.com/users/DamonOehlman/following{/other_user}","gists_url":"https://api.github.com/users/DamonOehlman/gists{/gist_id}","starred_url":"https://api.github.com/users/DamonOehlman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DamonOehlman/subscriptions","organizations_url":"https://api.github.com/users/DamonOehlman/orgs","repos_url":"https://api.github.com/users/DamonOehlman/repos","events_url":"https://api.github.com/users/DamonOehlman/events{/privacy}","received_events_url":"https://api.github.com/users/DamonOehlman/received_events","type":"User","site_admin":false},"created_at":"2016-06-14T02:41:13Z","updated_at":"2016-06-14T02:41:13Z","body":"@awmichel published at `1.3.1`"}}
{"actor":{"display_login":"DamonOehlman"}}