{"action":"created","issue":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5784","repository_url":"https://api.github.com/repos/NREL/EnergyPlus","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5784/labels{/name}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5784/comments","events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5784/events","html_url":"https://github.com/NREL/EnergyPlus/pull/5784","id":166599810,"number":5784,"title":"Create live url links for all URLs in documents.","user":{"login":"michael-okeefe","id":1099583,"avatar_url":"https://avatars.githubusercontent.com/u/1099583?v=3","gravatar_id":"","url":"https://api.github.com/users/michael-okeefe","html_url":"https://github.com/michael-okeefe","followers_url":"https://api.github.com/users/michael-okeefe/followers","following_url":"https://api.github.com/users/michael-okeefe/following{/other_user}","gists_url":"https://api.github.com/users/michael-okeefe/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-okeefe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-okeefe/subscriptions","organizations_url":"https://api.github.com/users/michael-okeefe/orgs","repos_url":"https://api.github.com/users/michael-okeefe/repos","events_url":"https://api.github.com/users/michael-okeefe/events{/privacy}","received_events_url":"https://api.github.com/users/michael-okeefe/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/NREL/EnergyPlus/labels/Defect","name":"Defect","color":"e11d21"},{"url":"https://api.github.com/repos/NREL/EnergyPlus/labels/Documentation%20Sources","name":"Documentation Sources","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-20T14:46:45Z","updated_at":"2016-08-07T01:39:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5784","html_url":"https://github.com/NREL/EnergyPlus/pull/5784","diff_url":"https://github.com/NREL/EnergyPlus/pull/5784.diff","patch_url":"https://github.com/NREL/EnergyPlus/pull/5784.patch"},"body":"Pull request overview\r\n---------------------\r\nThis pull request wraps all URLs in the document in a \\url{} or \\href{}{} wrapper such that the generated PDFs (or HTML) will use live, click-able links. This also makes it somewhat easier to identify URLs in the document should we want to automatically check to see if they still work and such. This pull request has not evaluated the given URLs for relevancy or whether they still work, etc.\r\n\r\n### Work Checklist\r\nAdd to this list or remove from it as applicable.  This is a simple templated set of guidelines.\r\n - [X] Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)\r\n - [ ] At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:\r\n   - Defect: This pull request repairs a github defect issue.  The github issue should be referenced in the PR description\r\n   - Refactoring: This pull request includes code changes that don't change the functionality of the program, just perform refactoring\r\n   - NewFeature: This pull request includes code to add a new feature to EnergyPlus\r\n   - Performance: This pull request includes code changes that are directed at improving the runtime performance of EnergyPlus\r\n   - DoNoPublish: This pull request includes changes that shouldn't be included in the changelog\r\n\r\n### Review Checklist\r\nThis will not be exhaustively relevant to every PR.\r\n - [ ] Code style (parentheses padding, variable names)\r\n - [ ] Functional code review (it has to work!)\r\n - [ ] If defect, results of running current develop vs this branch should exhibit the fix\r\n - [ ] CI status: all green or justified\r\n - [ ] Performance: CI Linux results include performance check -- verify this\r\n - [ ] Unit Test(s)\r\n - C++ checks:\r\n   - [ ] Argument types\r\n   - [ ] If any virtual classes, ensure virtual destructor included, other things\r\n - IDD changes:\r\n   - [ ] Verify naming conventions and styles, memos and notes and defaults\r\n   - [ ] Open windows IDF Editor with modified IDD to check for errors\r\n   - [ ] If transition, add rules to spreadsheet\r\n   - [ ] If transition, add transition source\r\n   - [ ] If transition, update idfs\r\n - [ ] If new idf included, locally check the err file and other outputs\r\n - [ ] Documentation changes in place\r\n - [ ] ExpandObjects changes??\r\n - [ ] If output changes, including tabular output structure, add to output rules file for interfaces\r\n\r\nNote: this will make it easier to scrub and test URLs in the future."},"comment":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments/238058108","html_url":"https://github.com/NREL/EnergyPlus/pull/5784#issuecomment-238058108","issue_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5784","id":238058108,"user":{"login":"nrel-bot-3","id":15201607,"avatar_url":"https://avatars.githubusercontent.com/u/15201607?v=3","gravatar_id":"","url":"https://api.github.com/users/nrel-bot-3","html_url":"https://github.com/nrel-bot-3","followers_url":"https://api.github.com/users/nrel-bot-3/followers","following_url":"https://api.github.com/users/nrel-bot-3/following{/other_user}","gists_url":"https://api.github.com/users/nrel-bot-3/gists{/gist_id}","starred_url":"https://api.github.com/users/nrel-bot-3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrel-bot-3/subscriptions","organizations_url":"https://api.github.com/users/nrel-bot-3/orgs","repos_url":"https://api.github.com/users/nrel-bot-3/repos","events_url":"https://api.github.com/users/nrel-bot-3/events{/privacy}","received_events_url":"https://api.github.com/users/nrel-bot-3/received_events","type":"User","site_admin":false},"created_at":"2016-08-07T01:39:45Z","updated_at":"2016-08-07T01:39:45Z","body":"@michael-okeefe @lgentile it has been 16 days since this pull request was last updated."}}
{"actor":{"display_login":"nrel-bot-3"}}