{"action":"created","issue":{"url":"https://api.github.com/repos/timber/timber/issues/1032","repository_url":"https://api.github.com/repos/timber/timber","labels_url":"https://api.github.com/repos/timber/timber/issues/1032/labels{/name}","comments_url":"https://api.github.com/repos/timber/timber/issues/1032/comments","events_url":"https://api.github.com/repos/timber/timber/issues/1032/events","html_url":"https://github.com/timber/timber/pull/1032","id":157298019,"number":1032,"title":"Adding count property to queryiterator","user":{"login":"connorjburton","id":10538031,"avatar_url":"https://avatars.githubusercontent.com/u/10538031?v=3","gravatar_id":"","url":"https://api.github.com/users/connorjburton","html_url":"https://github.com/connorjburton","followers_url":"https://api.github.com/users/connorjburton/followers","following_url":"https://api.github.com/users/connorjburton/following{/other_user}","gists_url":"https://api.github.com/users/connorjburton/gists{/gist_id}","starred_url":"https://api.github.com/users/connorjburton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connorjburton/subscriptions","organizations_url":"https://api.github.com/users/connorjburton/orgs","repos_url":"https://api.github.com/users/connorjburton/repos","events_url":"https://api.github.com/users/connorjburton/events{/privacy}","received_events_url":"https://api.github.com/users/connorjburton/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"lggorman","id":5794405,"avatar_url":"https://avatars.githubusercontent.com/u/5794405?v=3","gravatar_id":"","url":"https://api.github.com/users/lggorman","html_url":"https://github.com/lggorman","followers_url":"https://api.github.com/users/lggorman/followers","following_url":"https://api.github.com/users/lggorman/following{/other_user}","gists_url":"https://api.github.com/users/lggorman/gists{/gist_id}","starred_url":"https://api.github.com/users/lggorman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lggorman/subscriptions","organizations_url":"https://api.github.com/users/lggorman/orgs","repos_url":"https://api.github.com/users/lggorman/repos","events_url":"https://api.github.com/users/lggorman/events{/privacy}","received_events_url":"https://api.github.com/users/lggorman/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/timber/timber/milestones/4","html_url":"https://github.com/timber/timber/milestones/v1.0.4","labels_url":"https://api.github.com/repos/timber/timber/milestones/4/labels","id":1764170,"number":4,"title":"v1.0.4","description":"","creator":{"login":"connorjburton","id":10538031,"avatar_url":"https://avatars.githubusercontent.com/u/10538031?v=3","gravatar_id":"","url":"https://api.github.com/users/connorjburton","html_url":"https://github.com/connorjburton","followers_url":"https://api.github.com/users/connorjburton/followers","following_url":"https://api.github.com/users/connorjburton/following{/other_user}","gists_url":"https://api.github.com/users/connorjburton/gists{/gist_id}","starred_url":"https://api.github.com/users/connorjburton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connorjburton/subscriptions","organizations_url":"https://api.github.com/users/connorjburton/orgs","repos_url":"https://api.github.com/users/connorjburton/repos","events_url":"https://api.github.com/users/connorjburton/events{/privacy}","received_events_url":"https://api.github.com/users/connorjburton/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":5,"state":"open","created_at":"2016-05-13T09:17:21Z","updated_at":"2016-06-01T01:11:25Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2016-05-27T22:00:13Z","updated_at":"2016-06-01T15:12:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/timber/timber/pulls/1032","html_url":"https://github.com/timber/timber/pull/1032","diff_url":"https://github.com/timber/timber/pull/1032.diff","patch_url":"https://github.com/timber/timber/pull/1032.patch"},"body":"**Ticket**: #837\r\n**Reviewer**: @jarednova \r\n\r\n#### Issue\r\n<!-- Description of the problem that this code change is solving -->\r\nIf you have a `Timber\\QueryIterator` object, there is no way to get the total posts returned, for example of a search results page with the default `posts` object in context.\r\n\r\n#### Solution\r\n<!-- Description of the solution that this code changes are introducing to the application. -->\r\nAdd a method to return the private `_query.post_count` property\r\n\r\n#### Impact\r\n<!-- What impact will this have on the current codebase, performance, backwards compatability? -->\r\nNo impact\r\n\r\n#### Usage\r\n<!-- Are there are any usage changes, or are there new usage that we need to know about? -->\r\n` {{ QueryIteratorObject.post_count }}`\r\n\r\n#### Considerations\r\n<!-- As we do not live in an ideal world it's worth to share your thought on how we could make the solution even better. -->\r\nThere may be other properties that would be useful to expose. Also I am not sure on the reason behind returning a `QueryIterator` rather than a collection of `Timber\\Post`s, you could then do `{{ posts | length }}` to get the total posts\r\n\r\n#### Testing\r\n<!-- Are unit tests included? If they need to be written, please provide pseudo code for a scenario that fails without your code, but succeeds with it -->\r\nNone\r\n"},"comment":{"url":"https://api.github.com/repos/timber/timber/issues/comments/223024393","html_url":"https://github.com/timber/timber/pull/1032#issuecomment-223024393","issue_url":"https://api.github.com/repos/timber/timber/issues/1032","id":223024393,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-06-01T15:12:00Z","updated_at":"2016-06-01T15:12:00Z","body":"\n[![Coverage Status](https://coveralls.io/builds/6418529/badge)](https://coveralls.io/builds/6418529)\n\nCoverage increased (+0.004%) to 88.223% when pulling **29dca3f56d515aaaa0df29ae07aada20ec7fe18e on cjb-iterator-count** into **0d218854642d243b8121843e78e51aba4dd645f4 on master**.\n"}}
{"actor":{"display_login":"coveralls"}}