{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/71623834","id":71623834,"diff_hunk":"@@ -169,7 +170,13 @@ func (p *v2Pusher) pushV2Tag(ctx context.Context, ref reference.NamedTagged, ima\n \n \tputOptions := []distribution.ManifestServiceOption{distribution.WithTag(ref.Tag())}\n \tif _, err = manSvc.Put(ctx, manifest, putOptions...); err != nil {\n-\t\tlogrus.Warnf(\"failed to upload schema2 manifest: %v - falling back to schema1\", err)\n+\t\tlogrus.Warnf(\"failed to upload schema2 manifest: %v\", err)\n+\n+\t\tif runtime.GOOS == \"windows\" {\n+\t\t\treturn err\n+\t\t}","path":"distribution/push_v2.go","position":null,"original_position":17,"commit_id":"adee28458c23581ac9afb163b7cce8c6bb1d2dee","original_commit_id":"e71e2f5fff4ead7ad582ccaa6f2c0cada4196695","user":{"login":"swernli","id":10567287,"avatar_url":"https://avatars.githubusercontent.com/u/10567287?v=3","gravatar_id":"","url":"https://api.github.com/users/swernli","html_url":"https://github.com/swernli","followers_url":"https://api.github.com/users/swernli/followers","following_url":"https://api.github.com/users/swernli/following{/other_user}","gists_url":"https://api.github.com/users/swernli/gists{/gist_id}","starred_url":"https://api.github.com/users/swernli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swernli/subscriptions","organizations_url":"https://api.github.com/users/swernli/orgs","repos_url":"https://api.github.com/users/swernli/repos","events_url":"https://api.github.com/users/swernli/events{/privacy}","received_events_url":"https://api.github.com/users/swernli/received_events","type":"User","site_admin":false},"body":"We don't expect to be compatible with older registries at all, since they won't support the correct handling of base layers for Windows images.","created_at":"2016-07-20T23:16:15Z","updated_at":"2016-07-20T23:16:15Z","html_url":"https://github.com/docker/docker/pull/24822#discussion_r71623834","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/24822","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/71623834"},"html":{"href":"https://github.com/docker/docker/pull/24822#discussion_r71623834"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/24822"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/24822","id":78068998,"html_url":"https://github.com/docker/docker/pull/24822","diff_url":"https://github.com/docker/docker/pull/24822.diff","patch_url":"https://github.com/docker/docker/pull/24822.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/24822","number":24822,"state":"open","locked":false,"title":"Fixing v2 registry restriction for non-linux platforms.","user":{"login":"swernli","id":10567287,"avatar_url":"https://avatars.githubusercontent.com/u/10567287?v=3","gravatar_id":"","url":"https://api.github.com/users/swernli","html_url":"https://github.com/swernli","followers_url":"https://api.github.com/users/swernli/followers","following_url":"https://api.github.com/users/swernli/following{/other_user}","gists_url":"https://api.github.com/users/swernli/gists{/gist_id}","starred_url":"https://api.github.com/users/swernli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swernli/subscriptions","organizations_url":"https://api.github.com/users/swernli/orgs","repos_url":"https://api.github.com/users/swernli/repos","events_url":"https://api.github.com/users/swernli/events{/privacy}","received_events_url":"https://api.github.com/users/swernli/received_events","type":"User","site_admin":false},"body":"@jstarks @jhowardmsft \r\nThis fixes the hard coded restriction for non-linux platforms to v2 registries.  Previously, the check was above the flag parsing, which would overwrite the hard coded value and prevent correct operation.  This change also removes the related daemon flag from Windows to avoid confusion, as it has no meaning when the value is going to always be hard coded to true.\r\n\r\nThe change also introduces a restriction to the schema fallback logic to avoid fallback to v1 schema if v2 fails, since Windows images have no history and would fail a v1 schema.\r\n\r\nSigned-off-by: Stefan J. Wernli <swernli@microsoft.com>","created_at":"2016-07-19T23:57:47Z","updated_at":"2016-07-20T23:16:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e515a8bead6d7f2b981610f2c686c695d1d57ee2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/24822/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/24822/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/24822/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/adee28458c23581ac9afb163b7cce8c6bb1d2dee","head":{"label":"swernli:skipV1push","ref":"skipV1push","sha":"adee28458c23581ac9afb163b7cce8c6bb1d2dee","user":{"login":"swernli","id":10567287,"avatar_url":"https://avatars.githubusercontent.com/u/10567287?v=3","gravatar_id":"","url":"https://api.github.com/users/swernli","html_url":"https://github.com/swernli","followers_url":"https://api.github.com/users/swernli/followers","following_url":"https://api.github.com/users/swernli/following{/other_user}","gists_url":"https://api.github.com/users/swernli/gists{/gist_id}","starred_url":"https://api.github.com/users/swernli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swernli/subscriptions","organizations_url":"https://api.github.com/users/swernli/orgs","repos_url":"https://api.github.com/users/swernli/repos","events_url":"https://api.github.com/users/swernli/events{/privacy}","received_events_url":"https://api.github.com/users/swernli/received_events","type":"User","site_admin":false},"repo":{"id":61147238,"name":"docker","full_name":"swernli/docker","owner":{"login":"swernli","id":10567287,"avatar_url":"https://avatars.githubusercontent.com/u/10567287?v=3","gravatar_id":"","url":"https://api.github.com/users/swernli","html_url":"https://github.com/swernli","followers_url":"https://api.github.com/users/swernli/followers","following_url":"https://api.github.com/users/swernli/following{/other_user}","gists_url":"https://api.github.com/users/swernli/gists{/gist_id}","starred_url":"https://api.github.com/users/swernli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swernli/subscriptions","organizations_url":"https://api.github.com/users/swernli/orgs","repos_url":"https://api.github.com/users/swernli/repos","events_url":"https://api.github.com/users/swernli/events{/privacy}","received_events_url":"https://api.github.com/users/swernli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/swernli/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/swernli/docker","forks_url":"https://api.github.com/repos/swernli/docker/forks","keys_url":"https://api.github.com/repos/swernli/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swernli/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swernli/docker/teams","hooks_url":"https://api.github.com/repos/swernli/docker/hooks","issue_events_url":"https://api.github.com/repos/swernli/docker/issues/events{/number}","events_url":"https://api.github.com/repos/swernli/docker/events","assignees_url":"https://api.github.com/repos/swernli/docker/assignees{/user}","branches_url":"https://api.github.com/repos/swernli/docker/branches{/branch}","tags_url":"https://api.github.com/repos/swernli/docker/tags","blobs_url":"https://api.github.com/repos/swernli/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swernli/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swernli/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/swernli/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swernli/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/swernli/docker/languages","stargazers_url":"https://api.github.com/repos/swernli/docker/stargazers","contributors_url":"https://api.github.com/repos/swernli/docker/contributors","subscribers_url":"https://api.github.com/repos/swernli/docker/subscribers","subscription_url":"https://api.github.com/repos/swernli/docker/subscription","commits_url":"https://api.github.com/repos/swernli/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/swernli/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/swernli/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/swernli/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/swernli/docker/contents/{+path}","compare_url":"https://api.github.com/repos/swernli/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swernli/docker/merges","archive_url":"https://api.github.com/repos/swernli/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swernli/docker/downloads","issues_url":"https://api.github.com/repos/swernli/docker/issues{/number}","pulls_url":"https://api.github.com/repos/swernli/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/swernli/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/swernli/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swernli/docker/labels{/name}","releases_url":"https://api.github.com/repos/swernli/docker/releases{/id}","deployments_url":"https://api.github.com/repos/swernli/docker/deployments","created_at":"2016-06-14T18:42:25Z","updated_at":"2016-06-14T18:42:39Z","pushed_at":"2016-07-20T23:14:48Z","git_url":"git://github.com/swernli/docker.git","ssh_url":"git@github.com:swernli/docker.git","clone_url":"https://github.com/swernli/docker.git","svn_url":"https://github.com/swernli/docker","homepage":"http://www.docker.com","size":98588,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"ea59668046e1c842b311732fc280701da1056ace","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2016-07-20T21:50:29Z","pushed_at":"2016-07-20T23:14:50Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":205303,"stargazers_count":33200,"watchers_count":33200,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9626,"mirror_url":null,"open_issues_count":2021,"forks":9626,"open_issues":2021,"watchers":33200,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/24822"},"html":{"href":"https://github.com/docker/docker/pull/24822"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/24822"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/24822/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/24822/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/24822/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/adee28458c23581ac9afb163b7cce8c6bb1d2dee"}}}}
{"actor":{"display_login":"swernli"}}