{"action":"created","issue":{"url":"https://api.github.com/repos/OpenMS/OpenMS/issues/2066","repository_url":"https://api.github.com/repos/OpenMS/OpenMS","labels_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/2066/labels{/name}","comments_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/2066/comments","events_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/2066/events","html_url":"https://github.com/OpenMS/OpenMS/pull/2066","id":167037757,"number":2066,"title":"Java fix","user":{"login":"cbielow","id":6008722,"avatar_url":"https://avatars.githubusercontent.com/u/6008722?v=3","gravatar_id":"","url":"https://api.github.com/users/cbielow","html_url":"https://github.com/cbielow","followers_url":"https://api.github.com/users/cbielow/followers","following_url":"https://api.github.com/users/cbielow/following{/other_user}","gists_url":"https://api.github.com/users/cbielow/gists{/gist_id}","starred_url":"https://api.github.com/users/cbielow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbielow/subscriptions","organizations_url":"https://api.github.com/users/cbielow/orgs","repos_url":"https://api.github.com/users/cbielow/repos","events_url":"https://api.github.com/users/cbielow/events{/privacy}","received_events_url":"https://api.github.com/users/cbielow/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-22T12:46:13Z","updated_at":"2016-07-22T14:19:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OpenMS/OpenMS/pulls/2066","html_url":"https://github.com/OpenMS/OpenMS/pull/2066","diff_url":"https://github.com/OpenMS/OpenMS/pull/2066.diff","patch_url":"https://github.com/OpenMS/OpenMS/pull/2066.patch"},"body":"We are constantly running into issues that TOPP tools cannot find Java, usually because App-bundles on MacOSX mess up the PATH, such that a simple call to 'java' fails.\r\nThis affects all TOPP tools internally calling Java, i.e. MSGF+ and Luciphor\r\n\r\nThis PR fixes this by:\r\n - allow path to Java to be specified explicitly\r\n - better Java checking and error messages\r\n\r\nreplaces #1941"},"comment":{"url":"https://api.github.com/repos/OpenMS/OpenMS/issues/comments/234556272","html_url":"https://github.com/OpenMS/OpenMS/pull/2066#issuecomment-234556272","issue_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/2066","id":234556272,"user":{"login":"jpfeuffer","id":8102638,"avatar_url":"https://avatars.githubusercontent.com/u/8102638?v=3","gravatar_id":"","url":"https://api.github.com/users/jpfeuffer","html_url":"https://github.com/jpfeuffer","followers_url":"https://api.github.com/users/jpfeuffer/followers","following_url":"https://api.github.com/users/jpfeuffer/following{/other_user}","gists_url":"https://api.github.com/users/jpfeuffer/gists{/gist_id}","starred_url":"https://api.github.com/users/jpfeuffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpfeuffer/subscriptions","organizations_url":"https://api.github.com/users/jpfeuffer/orgs","repos_url":"https://api.github.com/users/jpfeuffer/repos","events_url":"https://api.github.com/users/jpfeuffer/events{/privacy}","received_events_url":"https://api.github.com/users/jpfeuffer/received_events","type":"User","site_admin":false},"created_at":"2016-07-22T14:19:03Z","updated_at":"2016-07-22T14:19:03Z","body":"Should we remove these additional parameters for KNIME, since it will choose its own Java Runtime?\r\nSee\r\nhttps://github.com/OpenMS/OpenMS/blob/develop/cmake/knime_package_support.cmake#L130"}}
{"actor":{"display_login":"jpfeuffer"}}