{"action":"created","comment":{"url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/pulls/comments/81006611","pull_request_review_id":2017720,"id":81006611,"diff_hunk":"@@ -0,0 +1,50 @@\n+package com.stormpath.sdk.impl.oauth;\n+\n+import com.stormpath.sdk.impl.ds.InternalDataStore;\n+import com.stormpath.sdk.impl.resource.AbstractResource;\n+import com.stormpath.sdk.impl.resource.Property;\n+import com.stormpath.sdk.impl.resource.StringProperty;\n+\n+import java.util.Map;\n+\n+/**\n+ * @since 1.1.0\n+ */\n+public class DefaultOAuthStormpathTokenGrantAuthenticationAttempt extends AbstractResource implements OAuthStormpathTokenGrantAuthenticationAttempt {\n+\n+    static final StringProperty GRANT_TYPE = new StringProperty(\"grant_type\");\n+    static final StringProperty TOKEN = new StringProperty(\"token\");\n+\n+    private static final Map<String, Property> PROPERTY_DESCRIPTORS = createPropertyDescriptorMap(GRANT_TYPE, TOKEN);\n+\n+    public DefaultOAuthStormpathTokenGrantAuthenticationAttempt(InternalDataStore dataStore) {\n+        super(dataStore);\n+    }\n+\n+    public DefaultOAuthStormpathTokenGrantAuthenticationAttempt(InternalDataStore dataStore, Map<String, Object> properties) {\n+        super(dataStore, properties);\n+    }\n+\n+    @Override\n+    public void setGrantType(String grantType) {\n+        setProperty(GRANT_TYPE, grantType);","path":"impl/src/main/java/com/stormpath/sdk/impl/oauth/DefaultOAuthStormpathTokenGrantAuthenticationAttempt.java","position":45,"original_position":30,"commit_id":"1704d75c1f9a74729fcef2c47fd69efd412f54b2","original_commit_id":"3e65337cd2a6156d69d851788558738633762e43","user":{"login":"mrioan","id":717498,"avatar_url":"https://avatars.githubusercontent.com/u/717498?v=3","gravatar_id":"","url":"https://api.github.com/users/mrioan","html_url":"https://github.com/mrioan","followers_url":"https://api.github.com/users/mrioan/followers","following_url":"https://api.github.com/users/mrioan/following{/other_user}","gists_url":"https://api.github.com/users/mrioan/gists{/gist_id}","starred_url":"https://api.github.com/users/mrioan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrioan/subscriptions","organizations_url":"https://api.github.com/users/mrioan/orgs","repos_url":"https://api.github.com/users/mrioan/repos","events_url":"https://api.github.com/users/mrioan/events{/privacy}","received_events_url":"https://api.github.com/users/mrioan/received_events","type":"User","site_admin":false},"body":"I was referring to `grantType`: `grant_type=stormpath_token`. Anyways, this method should be removed from the interface as requested in upper comments. I am not sure if you can remove it from the implementation class as well but if you can just hard-code this value and remove this method it would be great.","created_at":"2016-09-28T20:13:02Z","updated_at":"2016-09-28T20:18:14Z","html_url":"https://github.com/stormpath/stormpath-sdk-java/pull/970#discussion_r81006611","pull_request_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/pulls/970","_links":{"self":{"href":"https://api.github.com/repos/stormpath/stormpath-sdk-java/pulls/comments/81006611"},"html":{"href":"https://github.com/stormpath/stormpath-sdk-java/pull/970#discussion_r81006611"},"pull_request":{"href":"https://api.github.com/repos/stormpath/stormpath-sdk-java/pulls/970"}}},"pull_request":{"url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/pulls/970","id":84674851,"html_url":"https://github.com/stormpath/stormpath-sdk-java/pull/970","diff_url":"https://github.com/stormpath/stormpath-sdk-java/pull/970.diff","patch_url":"https://github.com/stormpath/stormpath-sdk-java/pull/970.patch","issue_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/issues/970","number":970,"state":"open","locked":false,"title":"Add support for stormpath_token grant type","user":{"login":"mraible","id":17892,"avatar_url":"https://avatars.githubusercontent.com/u/17892?v=3","gravatar_id":"","url":"https://api.github.com/users/mraible","html_url":"https://github.com/mraible","followers_url":"https://api.github.com/users/mraible/followers","following_url":"https://api.github.com/users/mraible/following{/other_user}","gists_url":"https://api.github.com/users/mraible/gists{/gist_id}","starred_url":"https://api.github.com/users/mraible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mraible/subscriptions","organizations_url":"https://api.github.com/users/mraible/orgs","repos_url":"https://api.github.com/users/mraible/repos","events_url":"https://api.github.com/users/mraible/events{/privacy}","received_events_url":"https://api.github.com/users/mraible/received_events","type":"User","site_admin":false},"body":"Fixes #957.\r\n\r\nNOTE: This PR does not have any integration tests. I tried adding them to the TCK, but after talking with @lhazlewood, I learned the TCK does not cover ID Site. I also briefly looked into adding an IT (with RestAssured) to the SDK, but it seemed like a lot of work.\r\n\r\nAlso, I did not add any authenticators due to lack of time.","created_at":"2016-09-09T15:55:15Z","updated_at":"2016-09-28T20:18:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9cb2dba43c3f1e931e0131a068cecfce1f59a87","assignee":{"login":"mrioan","id":717498,"avatar_url":"https://avatars.githubusercontent.com/u/717498?v=3","gravatar_id":"","url":"https://api.github.com/users/mrioan","html_url":"https://github.com/mrioan","followers_url":"https://api.github.com/users/mrioan/followers","following_url":"https://api.github.com/users/mrioan/following{/other_user}","gists_url":"https://api.github.com/users/mrioan/gists{/gist_id}","starred_url":"https://api.github.com/users/mrioan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrioan/subscriptions","organizations_url":"https://api.github.com/users/mrioan/orgs","repos_url":"https://api.github.com/users/mrioan/repos","events_url":"https://api.github.com/users/mrioan/events{/privacy}","received_events_url":"https://api.github.com/users/mrioan/received_events","type":"User","site_admin":false},"assignees":[{"login":"mrioan","id":717498,"avatar_url":"https://avatars.githubusercontent.com/u/717498?v=3","gravatar_id":"","url":"https://api.github.com/users/mrioan","html_url":"https://github.com/mrioan","followers_url":"https://api.github.com/users/mrioan/followers","following_url":"https://api.github.com/users/mrioan/following{/other_user}","gists_url":"https://api.github.com/users/mrioan/gists{/gist_id}","starred_url":"https://api.github.com/users/mrioan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrioan/subscriptions","organizations_url":"https://api.github.com/users/mrioan/orgs","repos_url":"https://api.github.com/users/mrioan/repos","events_url":"https://api.github.com/users/mrioan/events{/privacy}","received_events_url":"https://api.github.com/users/mrioan/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/milestones/52","html_url":"https://github.com/stormpath/stormpath-sdk-java/milestones/1.1.0","labels_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/milestones/52/labels","id":1919396,"number":52,"title":"1.1.0","description":"","creator":{"login":"lhazlewood","id":121180,"avatar_url":"https://avatars.githubusercontent.com/u/121180?v=3","gravatar_id":"","url":"https://api.github.com/users/lhazlewood","html_url":"https://github.com/lhazlewood","followers_url":"https://api.github.com/users/lhazlewood/followers","following_url":"https://api.github.com/users/lhazlewood/following{/other_user}","gists_url":"https://api.github.com/users/lhazlewood/gists{/gist_id}","starred_url":"https://api.github.com/users/lhazlewood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhazlewood/subscriptions","organizations_url":"https://api.github.com/users/lhazlewood/orgs","repos_url":"https://api.github.com/users/lhazlewood/repos","events_url":"https://api.github.com/users/lhazlewood/events{/privacy}","received_events_url":"https://api.github.com/users/lhazlewood/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":29,"state":"open","created_at":"2016-08-02T21:30:57Z","updated_at":"2016-09-28T16:24:59Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/pulls/970/commits","review_comments_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/pulls/970/comments","review_comment_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/issues/970/comments","statuses_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/statuses/1704d75c1f9a74729fcef2c47fd69efd412f54b2","head":{"label":"stormpath:957-stormpath-token-grant-type","ref":"957-stormpath-token-grant-type","sha":"1704d75c1f9a74729fcef2c47fd69efd412f54b2","user":{"login":"stormpath","id":1377453,"avatar_url":"https://avatars.githubusercontent.com/u/1377453?v=3","gravatar_id":"","url":"https://api.github.com/users/stormpath","html_url":"https://github.com/stormpath","followers_url":"https://api.github.com/users/stormpath/followers","following_url":"https://api.github.com/users/stormpath/following{/other_user}","gists_url":"https://api.github.com/users/stormpath/gists{/gist_id}","starred_url":"https://api.github.com/users/stormpath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stormpath/subscriptions","organizations_url":"https://api.github.com/users/stormpath/orgs","repos_url":"https://api.github.com/users/stormpath/repos","events_url":"https://api.github.com/users/stormpath/events{/privacy}","received_events_url":"https://api.github.com/users/stormpath/received_events","type":"Organization","site_admin":false},"repo":{"id":3913468,"name":"stormpath-sdk-java","full_name":"stormpath/stormpath-sdk-java","owner":{"login":"stormpath","id":1377453,"avatar_url":"https://avatars.githubusercontent.com/u/1377453?v=3","gravatar_id":"","url":"https://api.github.com/users/stormpath","html_url":"https://github.com/stormpath","followers_url":"https://api.github.com/users/stormpath/followers","following_url":"https://api.github.com/users/stormpath/following{/other_user}","gists_url":"https://api.github.com/users/stormpath/gists{/gist_id}","starred_url":"https://api.github.com/users/stormpath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stormpath/subscriptions","organizations_url":"https://api.github.com/users/stormpath/orgs","repos_url":"https://api.github.com/users/stormpath/repos","events_url":"https://api.github.com/users/stormpath/events{/privacy}","received_events_url":"https://api.github.com/users/stormpath/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stormpath/stormpath-sdk-java","description":"Official Java SDK for the Stormpath User Management REST API","fork":false,"url":"https://api.github.com/repos/stormpath/stormpath-sdk-java","forks_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/forks","keys_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/teams","hooks_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/hooks","issue_events_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/issues/events{/number}","events_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/events","assignees_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/assignees{/user}","branches_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/branches{/branch}","tags_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/tags","blobs_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/statuses/{sha}","languages_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/languages","stargazers_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/stargazers","contributors_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/contributors","subscribers_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/subscribers","subscription_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/subscription","commits_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/contents/{+path}","compare_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/merges","archive_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/downloads","issues_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/issues{/number}","pulls_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/pulls{/number}","milestones_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/milestones{/number}","notifications_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/labels{/name}","releases_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/releases{/id}","deployments_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/deployments","created_at":"2012-04-03T01:22:09Z","updated_at":"2016-09-28T07:36:27Z","pushed_at":"2016-09-28T19:29:44Z","git_url":"git://github.com/stormpath/stormpath-sdk-java.git","ssh_url":"git@github.com:stormpath/stormpath-sdk-java.git","clone_url":"https://github.com/stormpath/stormpath-sdk-java.git","svn_url":"https://github.com/stormpath/stormpath-sdk-java","homepage":"","size":26561,"stargazers_count":127,"watchers_count":127,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":104,"mirror_url":null,"open_issues_count":108,"forks":104,"open_issues":108,"watchers":127,"default_branch":"master"}},"base":{"label":"stormpath:master","ref":"master","sha":"8d82a17b1830ee121d59e02eda2447415faa7a1d","user":{"login":"stormpath","id":1377453,"avatar_url":"https://avatars.githubusercontent.com/u/1377453?v=3","gravatar_id":"","url":"https://api.github.com/users/stormpath","html_url":"https://github.com/stormpath","followers_url":"https://api.github.com/users/stormpath/followers","following_url":"https://api.github.com/users/stormpath/following{/other_user}","gists_url":"https://api.github.com/users/stormpath/gists{/gist_id}","starred_url":"https://api.github.com/users/stormpath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stormpath/subscriptions","organizations_url":"https://api.github.com/users/stormpath/orgs","repos_url":"https://api.github.com/users/stormpath/repos","events_url":"https://api.github.com/users/stormpath/events{/privacy}","received_events_url":"https://api.github.com/users/stormpath/received_events","type":"Organization","site_admin":false},"repo":{"id":3913468,"name":"stormpath-sdk-java","full_name":"stormpath/stormpath-sdk-java","owner":{"login":"stormpath","id":1377453,"avatar_url":"https://avatars.githubusercontent.com/u/1377453?v=3","gravatar_id":"","url":"https://api.github.com/users/stormpath","html_url":"https://github.com/stormpath","followers_url":"https://api.github.com/users/stormpath/followers","following_url":"https://api.github.com/users/stormpath/following{/other_user}","gists_url":"https://api.github.com/users/stormpath/gists{/gist_id}","starred_url":"https://api.github.com/users/stormpath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stormpath/subscriptions","organizations_url":"https://api.github.com/users/stormpath/orgs","repos_url":"https://api.github.com/users/stormpath/repos","events_url":"https://api.github.com/users/stormpath/events{/privacy}","received_events_url":"https://api.github.com/users/stormpath/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stormpath/stormpath-sdk-java","description":"Official Java SDK for the Stormpath User Management REST API","fork":false,"url":"https://api.github.com/repos/stormpath/stormpath-sdk-java","forks_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/forks","keys_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/teams","hooks_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/hooks","issue_events_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/issues/events{/number}","events_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/events","assignees_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/assignees{/user}","branches_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/branches{/branch}","tags_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/tags","blobs_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/statuses/{sha}","languages_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/languages","stargazers_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/stargazers","contributors_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/contributors","subscribers_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/subscribers","subscription_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/subscription","commits_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/contents/{+path}","compare_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/merges","archive_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/downloads","issues_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/issues{/number}","pulls_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/pulls{/number}","milestones_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/milestones{/number}","notifications_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/labels{/name}","releases_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/releases{/id}","deployments_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/deployments","created_at":"2012-04-03T01:22:09Z","updated_at":"2016-09-28T07:36:27Z","pushed_at":"2016-09-28T19:29:44Z","git_url":"git://github.com/stormpath/stormpath-sdk-java.git","ssh_url":"git@github.com:stormpath/stormpath-sdk-java.git","clone_url":"https://github.com/stormpath/stormpath-sdk-java.git","svn_url":"https://github.com/stormpath/stormpath-sdk-java","homepage":"","size":26561,"stargazers_count":127,"watchers_count":127,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":104,"mirror_url":null,"open_issues_count":108,"forks":104,"open_issues":108,"watchers":127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stormpath/stormpath-sdk-java/pulls/970"},"html":{"href":"https://github.com/stormpath/stormpath-sdk-java/pull/970"},"issue":{"href":"https://api.github.com/repos/stormpath/stormpath-sdk-java/issues/970"},"comments":{"href":"https://api.github.com/repos/stormpath/stormpath-sdk-java/issues/970/comments"},"review_comments":{"href":"https://api.github.com/repos/stormpath/stormpath-sdk-java/pulls/970/comments"},"review_comment":{"href":"https://api.github.com/repos/stormpath/stormpath-sdk-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stormpath/stormpath-sdk-java/pulls/970/commits"},"statuses":{"href":"https://api.github.com/repos/stormpath/stormpath-sdk-java/statuses/1704d75c1f9a74729fcef2c47fd69efd412f54b2"}}}}
{"actor":{"display_login":"mrioan"}}