{"action":"created","comment":{"url":"https://api.github.com/repos/ubuntu/snappy-playpen/pulls/comments/74027576","id":74027576,"diff_hunk":"@@ -28,6 +28,9 @@ parts:\n         build-packages:\n             - gcc\n             - g++\n+        snap:\n+            - -include","path":"cuberite/snapcraft.yaml","position":null,"original_position":14,"commit_id":"0580bedbd3e69b4f1384d066e8f592b2b3039422","original_commit_id":"8ab95c7c3db59ddcc7e627a3a527c255afcadf4b","user":{"login":"jamestait","id":1237300,"avatar_url":"https://avatars.githubusercontent.com/u/1237300?v=3","gravatar_id":"","url":"https://api.github.com/users/jamestait","html_url":"https://github.com/jamestait","followers_url":"https://api.github.com/users/jamestait/followers","following_url":"https://api.github.com/users/jamestait/following{/other_user}","gists_url":"https://api.github.com/users/jamestait/gists{/gist_id}","starred_url":"https://api.github.com/users/jamestait/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamestait/subscriptions","organizations_url":"https://api.github.com/users/jamestait/orgs","repos_url":"https://api.github.com/users/jamestait/repos","events_url":"https://api.github.com/users/jamestait/events{/privacy}","received_events_url":"https://api.github.com/users/jamestait/received_events","type":"User","site_admin":false},"body":"These are the libjsoncpp headers, which are the only thing that gets installed through `make install`. So they shouldn't be shipped as part of the package.","created_at":"2016-08-09T09:38:59Z","updated_at":"2016-08-09T09:38:59Z","html_url":"https://github.com/ubuntu/snappy-playpen/pull/203#discussion_r74027576","pull_request_url":"https://api.github.com/repos/ubuntu/snappy-playpen/pulls/203","_links":{"self":{"href":"https://api.github.com/repos/ubuntu/snappy-playpen/pulls/comments/74027576"},"html":{"href":"https://github.com/ubuntu/snappy-playpen/pull/203#discussion_r74027576"},"pull_request":{"href":"https://api.github.com/repos/ubuntu/snappy-playpen/pulls/203"}}},"pull_request":{"url":"https://api.github.com/repos/ubuntu/snappy-playpen/pulls/203","id":80252958,"html_url":"https://github.com/ubuntu/snappy-playpen/pull/203","diff_url":"https://github.com/ubuntu/snappy-playpen/pull/203.diff","patch_url":"https://github.com/ubuntu/snappy-playpen/pull/203.patch","issue_url":"https://api.github.com/repos/ubuntu/snappy-playpen/issues/203","number":203,"state":"open","locked":false,"title":"Add Cuberite - A performant Mincraft server written in C++","user":{"login":"jamestait","id":1237300,"avatar_url":"https://avatars.githubusercontent.com/u/1237300?v=3","gravatar_id":"","url":"https://api.github.com/users/jamestait","html_url":"https://github.com/jamestait","followers_url":"https://api.github.com/users/jamestait/followers","following_url":"https://api.github.com/users/jamestait/following{/other_user}","gists_url":"https://api.github.com/users/jamestait/gists{/gist_id}","starred_url":"https://api.github.com/users/jamestait/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamestait/subscriptions","organizations_url":"https://api.github.com/users/jamestait/orgs","repos_url":"https://api.github.com/users/jamestait/repos","events_url":"https://api.github.com/users/jamestait/events{/privacy}","received_events_url":"https://api.github.com/users/jamestait/received_events","type":"User","site_admin":false},"body":"This branch adds Cuberite as a subproject.  Cuberite is a Minecraft server written in C++ and released under the terms of the Apache 2.0 license.\r\n\r\nThis recipe builds Cuberite from git HEAD and adds a wrapper to set up the working directory before spawning the server. Cuberite is relocatable and uses the current working directory for its data, so multiple instances can be run on the same server. A possible improvement to the packaging would be to enable this via the system start-up scripts, something akin to the old `network-interface` or `lxc-instance` upstart scripts, or the current `lxc-containers` systemd unit\r\n\r\nCurrently requires devmode due to a call to `fchown` in the statically-linked sqlite: when running confined the process gets killed and I end up with `Cuberite <defunct>` in the process list, and Cuberite will not TCP ACK incoming TCP SYN packets.\r\n<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/ubuntu/snappy-playpen/pull/203%23issuecomment-238158124%22%2C%20%22https%3A//github.com/ubuntu/snappy-playpen/pull/203%23issuecomment-238411210%22%5D%2C%20%22comments%22%3A%20%7B%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ubuntu/snappy-playpen/pull/203%23issuecomment-238158124%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Nice%20work%2C%20do%20you%20you%20think%20you%20can%20update%20%60README.md%60%20in%20the%20top-level%20directory%20and%20add%20a%20README.md%20in%20this%20directory%20based%20on%20%60./snap-template/README.md%60%3F%22%2C%20%22created_at%22%3A%20%222016-08-08T07%3A11%3A26Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1346979%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dholbach%22%7D%7D%2C%20%7B%22body%22%3A%20%22Done%20and%20done.%20Also%20stripped%20out%20a%20couple%20of%20unnecessary%20directories.%22%2C%20%22created_at%22%3A%20%222016-08-08T23%3A42%3A41Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1237300%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/jamestait%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%7D%7D'></a>\r\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\r\n- [ ] <a href='#crh-comment-General Comment'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ubuntu/snappy-playpen/pull/203#issuecomment-238158124'>General Comment</a></b>\r\n- <a href='https://github.com/dholbach'><img border=0 src='https://avatars.githubusercontent.com/u/1346979?v=3' height=16 width=16'></a> Nice work, do you you think you can update `README.md` in the top-level directory and add a README.md in this directory based on `./snap-template/README.md`?\r\n- <a href='https://github.com/jamestait'><img border=0 src='https://avatars.githubusercontent.com/u/1237300?v=3' height=16 width=16'></a> Done and done. Also stripped out a couple of unnecessary directories.\r\n\r\n\r\n<a href='https://www.codereviewhub.com/ubuntu/snappy-playpen/pull/203?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/ubuntu/snappy-playpen/pull/203?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/ubuntu/snappy-playpen/pull/203'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\r\n<a href='#crh-end'></a>","created_at":"2016-08-05T14:33:05Z","updated_at":"2016-08-09T09:38:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"708b895e783c549cd0e95621c9bb2f67e38379bb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ubuntu/snappy-playpen/pulls/203/commits","review_comments_url":"https://api.github.com/repos/ubuntu/snappy-playpen/pulls/203/comments","review_comment_url":"https://api.github.com/repos/ubuntu/snappy-playpen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ubuntu/snappy-playpen/issues/203/comments","statuses_url":"https://api.github.com/repos/ubuntu/snappy-playpen/statuses/0580bedbd3e69b4f1384d066e8f592b2b3039422","head":{"label":"jamestait:cuberite","ref":"cuberite","sha":"0580bedbd3e69b4f1384d066e8f592b2b3039422","user":{"login":"jamestait","id":1237300,"avatar_url":"https://avatars.githubusercontent.com/u/1237300?v=3","gravatar_id":"","url":"https://api.github.com/users/jamestait","html_url":"https://github.com/jamestait","followers_url":"https://api.github.com/users/jamestait/followers","following_url":"https://api.github.com/users/jamestait/following{/other_user}","gists_url":"https://api.github.com/users/jamestait/gists{/gist_id}","starred_url":"https://api.github.com/users/jamestait/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamestait/subscriptions","organizations_url":"https://api.github.com/users/jamestait/orgs","repos_url":"https://api.github.com/users/jamestait/repos","events_url":"https://api.github.com/users/jamestait/events{/privacy}","received_events_url":"https://api.github.com/users/jamestait/received_events","type":"User","site_admin":false},"repo":{"id":60338948,"name":"snappy-playpen","full_name":"jamestait/snappy-playpen","owner":{"login":"jamestait","id":1237300,"avatar_url":"https://avatars.githubusercontent.com/u/1237300?v=3","gravatar_id":"","url":"https://api.github.com/users/jamestait","html_url":"https://github.com/jamestait","followers_url":"https://api.github.com/users/jamestait/followers","following_url":"https://api.github.com/users/jamestait/following{/other_user}","gists_url":"https://api.github.com/users/jamestait/gists{/gist_id}","starred_url":"https://api.github.com/users/jamestait/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamestait/subscriptions","organizations_url":"https://api.github.com/users/jamestait/orgs","repos_url":"https://api.github.com/users/jamestait/repos","events_url":"https://api.github.com/users/jamestait/events{/privacy}","received_events_url":"https://api.github.com/users/jamestait/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jamestait/snappy-playpen","description":"A place to test, learn creating snaps and share best practices.","fork":true,"url":"https://api.github.com/repos/jamestait/snappy-playpen","forks_url":"https://api.github.com/repos/jamestait/snappy-playpen/forks","keys_url":"https://api.github.com/repos/jamestait/snappy-playpen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jamestait/snappy-playpen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jamestait/snappy-playpen/teams","hooks_url":"https://api.github.com/repos/jamestait/snappy-playpen/hooks","issue_events_url":"https://api.github.com/repos/jamestait/snappy-playpen/issues/events{/number}","events_url":"https://api.github.com/repos/jamestait/snappy-playpen/events","assignees_url":"https://api.github.com/repos/jamestait/snappy-playpen/assignees{/user}","branches_url":"https://api.github.com/repos/jamestait/snappy-playpen/branches{/branch}","tags_url":"https://api.github.com/repos/jamestait/snappy-playpen/tags","blobs_url":"https://api.github.com/repos/jamestait/snappy-playpen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jamestait/snappy-playpen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jamestait/snappy-playpen/git/refs{/sha}","trees_url":"https://api.github.com/repos/jamestait/snappy-playpen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jamestait/snappy-playpen/statuses/{sha}","languages_url":"https://api.github.com/repos/jamestait/snappy-playpen/languages","stargazers_url":"https://api.github.com/repos/jamestait/snappy-playpen/stargazers","contributors_url":"https://api.github.com/repos/jamestait/snappy-playpen/contributors","subscribers_url":"https://api.github.com/repos/jamestait/snappy-playpen/subscribers","subscription_url":"https://api.github.com/repos/jamestait/snappy-playpen/subscription","commits_url":"https://api.github.com/repos/jamestait/snappy-playpen/commits{/sha}","git_commits_url":"https://api.github.com/repos/jamestait/snappy-playpen/git/commits{/sha}","comments_url":"https://api.github.com/repos/jamestait/snappy-playpen/comments{/number}","issue_comment_url":"https://api.github.com/repos/jamestait/snappy-playpen/issues/comments{/number}","contents_url":"https://api.github.com/repos/jamestait/snappy-playpen/contents/{+path}","compare_url":"https://api.github.com/repos/jamestait/snappy-playpen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jamestait/snappy-playpen/merges","archive_url":"https://api.github.com/repos/jamestait/snappy-playpen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jamestait/snappy-playpen/downloads","issues_url":"https://api.github.com/repos/jamestait/snappy-playpen/issues{/number}","pulls_url":"https://api.github.com/repos/jamestait/snappy-playpen/pulls{/number}","milestones_url":"https://api.github.com/repos/jamestait/snappy-playpen/milestones{/number}","notifications_url":"https://api.github.com/repos/jamestait/snappy-playpen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jamestait/snappy-playpen/labels{/name}","releases_url":"https://api.github.com/repos/jamestait/snappy-playpen/releases{/id}","deployments_url":"https://api.github.com/repos/jamestait/snappy-playpen/deployments","created_at":"2016-06-03T10:12:48Z","updated_at":"2016-07-29T16:20:24Z","pushed_at":"2016-08-09T09:25:49Z","git_url":"git://github.com/jamestait/snappy-playpen.git","ssh_url":"git@github.com:jamestait/snappy-playpen.git","clone_url":"https://github.com/jamestait/snappy-playpen.git","svn_url":"https://github.com/jamestait/snappy-playpen","homepage":"http://developer.ubuntu.com/desktop","size":4799,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ubuntu:master","ref":"master","sha":"f16bd58d5a44cf2066dfce5c98fa3801f14f2c9f","user":{"login":"ubuntu","id":4604537,"avatar_url":"https://avatars.githubusercontent.com/u/4604537?v=3","gravatar_id":"","url":"https://api.github.com/users/ubuntu","html_url":"https://github.com/ubuntu","followers_url":"https://api.github.com/users/ubuntu/followers","following_url":"https://api.github.com/users/ubuntu/following{/other_user}","gists_url":"https://api.github.com/users/ubuntu/gists{/gist_id}","starred_url":"https://api.github.com/users/ubuntu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubuntu/subscriptions","organizations_url":"https://api.github.com/users/ubuntu/orgs","repos_url":"https://api.github.com/users/ubuntu/repos","events_url":"https://api.github.com/users/ubuntu/events{/privacy}","received_events_url":"https://api.github.com/users/ubuntu/received_events","type":"Organization","site_admin":false},"repo":{"id":59051763,"name":"snappy-playpen","full_name":"ubuntu/snappy-playpen","owner":{"login":"ubuntu","id":4604537,"avatar_url":"https://avatars.githubusercontent.com/u/4604537?v=3","gravatar_id":"","url":"https://api.github.com/users/ubuntu","html_url":"https://github.com/ubuntu","followers_url":"https://api.github.com/users/ubuntu/followers","following_url":"https://api.github.com/users/ubuntu/following{/other_user}","gists_url":"https://api.github.com/users/ubuntu/gists{/gist_id}","starred_url":"https://api.github.com/users/ubuntu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubuntu/subscriptions","organizations_url":"https://api.github.com/users/ubuntu/orgs","repos_url":"https://api.github.com/users/ubuntu/repos","events_url":"https://api.github.com/users/ubuntu/events{/privacy}","received_events_url":"https://api.github.com/users/ubuntu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ubuntu/snappy-playpen","description":"A place to test, learn creating snaps and share best practices.","fork":false,"url":"https://api.github.com/repos/ubuntu/snappy-playpen","forks_url":"https://api.github.com/repos/ubuntu/snappy-playpen/forks","keys_url":"https://api.github.com/repos/ubuntu/snappy-playpen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ubuntu/snappy-playpen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ubuntu/snappy-playpen/teams","hooks_url":"https://api.github.com/repos/ubuntu/snappy-playpen/hooks","issue_events_url":"https://api.github.com/repos/ubuntu/snappy-playpen/issues/events{/number}","events_url":"https://api.github.com/repos/ubuntu/snappy-playpen/events","assignees_url":"https://api.github.com/repos/ubuntu/snappy-playpen/assignees{/user}","branches_url":"https://api.github.com/repos/ubuntu/snappy-playpen/branches{/branch}","tags_url":"https://api.github.com/repos/ubuntu/snappy-playpen/tags","blobs_url":"https://api.github.com/repos/ubuntu/snappy-playpen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ubuntu/snappy-playpen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ubuntu/snappy-playpen/git/refs{/sha}","trees_url":"https://api.github.com/repos/ubuntu/snappy-playpen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ubuntu/snappy-playpen/statuses/{sha}","languages_url":"https://api.github.com/repos/ubuntu/snappy-playpen/languages","stargazers_url":"https://api.github.com/repos/ubuntu/snappy-playpen/stargazers","contributors_url":"https://api.github.com/repos/ubuntu/snappy-playpen/contributors","subscribers_url":"https://api.github.com/repos/ubuntu/snappy-playpen/subscribers","subscription_url":"https://api.github.com/repos/ubuntu/snappy-playpen/subscription","commits_url":"https://api.github.com/repos/ubuntu/snappy-playpen/commits{/sha}","git_commits_url":"https://api.github.com/repos/ubuntu/snappy-playpen/git/commits{/sha}","comments_url":"https://api.github.com/repos/ubuntu/snappy-playpen/comments{/number}","issue_comment_url":"https://api.github.com/repos/ubuntu/snappy-playpen/issues/comments{/number}","contents_url":"https://api.github.com/repos/ubuntu/snappy-playpen/contents/{+path}","compare_url":"https://api.github.com/repos/ubuntu/snappy-playpen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ubuntu/snappy-playpen/merges","archive_url":"https://api.github.com/repos/ubuntu/snappy-playpen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ubuntu/snappy-playpen/downloads","issues_url":"https://api.github.com/repos/ubuntu/snappy-playpen/issues{/number}","pulls_url":"https://api.github.com/repos/ubuntu/snappy-playpen/pulls{/number}","milestones_url":"https://api.github.com/repos/ubuntu/snappy-playpen/milestones{/number}","notifications_url":"https://api.github.com/repos/ubuntu/snappy-playpen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ubuntu/snappy-playpen/labels{/name}","releases_url":"https://api.github.com/repos/ubuntu/snappy-playpen/releases{/id}","deployments_url":"https://api.github.com/repos/ubuntu/snappy-playpen/deployments","created_at":"2016-05-17T19:18:59Z","updated_at":"2016-08-06T15:07:27Z","pushed_at":"2016-08-09T09:25:50Z","git_url":"git://github.com/ubuntu/snappy-playpen.git","ssh_url":"git@github.com:ubuntu/snappy-playpen.git","clone_url":"https://github.com/ubuntu/snappy-playpen.git","svn_url":"https://github.com/ubuntu/snappy-playpen","homepage":"http://developer.ubuntu.com/desktop","size":265126,"stargazers_count":100,"watchers_count":100,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":39,"forks":46,"open_issues":39,"watchers":100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ubuntu/snappy-playpen/pulls/203"},"html":{"href":"https://github.com/ubuntu/snappy-playpen/pull/203"},"issue":{"href":"https://api.github.com/repos/ubuntu/snappy-playpen/issues/203"},"comments":{"href":"https://api.github.com/repos/ubuntu/snappy-playpen/issues/203/comments"},"review_comments":{"href":"https://api.github.com/repos/ubuntu/snappy-playpen/pulls/203/comments"},"review_comment":{"href":"https://api.github.com/repos/ubuntu/snappy-playpen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ubuntu/snappy-playpen/pulls/203/commits"},"statuses":{"href":"https://api.github.com/repos/ubuntu/snappy-playpen/statuses/0580bedbd3e69b4f1384d066e8f592b2b3039422"}}}}
{"actor":{"display_login":"jamestait"}}