{"action":"created","issue":{"url":"https://api.github.com/repos/cyclus/cyclus/issues/1266","repository_url":"https://api.github.com/repos/cyclus/cyclus","labels_url":"https://api.github.com/repos/cyclus/cyclus/issues/1266/labels{/name}","comments_url":"https://api.github.com/repos/cyclus/cyclus/issues/1266/comments","events_url":"https://api.github.com/repos/cyclus/cyclus/issues/1266/events","html_url":"https://github.com/cyclus/cyclus/pull/1266","id":168232114,"number":1266,"title":"Conda Build Test Fixes","user":{"login":"scopatz","id":320553,"avatar_url":"https://avatars.githubusercontent.com/u/320553?v=3","gravatar_id":"","url":"https://api.github.com/users/scopatz","html_url":"https://github.com/scopatz","followers_url":"https://api.github.com/users/scopatz/followers","following_url":"https://api.github.com/users/scopatz/following{/other_user}","gists_url":"https://api.github.com/users/scopatz/gists{/gist_id}","starred_url":"https://api.github.com/users/scopatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scopatz/subscriptions","organizations_url":"https://api.github.com/users/scopatz/orgs","repos_url":"https://api.github.com/users/scopatz/repos","events_url":"https://api.github.com/users/scopatz/events{/privacy}","received_events_url":"https://api.github.com/users/scopatz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cyclus/cyclus/labels/Testing","name":"Testing","color":"6d8a33"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cyclus/cyclus/milestones/32","html_url":"https://github.com/cyclus/cyclus/milestones/v1.4","labels_url":"https://api.github.com/repos/cyclus/cyclus/milestones/32/labels","id":1082340,"number":32,"title":"v1.4","description":"Tentatively set to be due the week before ANS","creator":{"login":"gidden","id":1392657,"avatar_url":"https://avatars.githubusercontent.com/u/1392657?v=3","gravatar_id":"","url":"https://api.github.com/users/gidden","html_url":"https://github.com/gidden","followers_url":"https://api.github.com/users/gidden/followers","following_url":"https://api.github.com/users/gidden/following{/other_user}","gists_url":"https://api.github.com/users/gidden/gists{/gist_id}","starred_url":"https://api.github.com/users/gidden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gidden/subscriptions","organizations_url":"https://api.github.com/users/gidden/orgs","repos_url":"https://api.github.com/users/gidden/repos","events_url":"https://api.github.com/users/gidden/events{/privacy}","received_events_url":"https://api.github.com/users/gidden/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":72,"state":"open","created_at":"2015-04-24T14:11:32Z","updated_at":"2016-07-30T04:11:44Z","due_on":"2015-06-01T05:00:00Z","closed_at":null},"comments":4,"created_at":"2016-07-29T01:27:34Z","updated_at":"2016-07-30T04:11:58Z","closed_at":"2016-07-30T04:11:44Z","pull_request":{"url":"https://api.github.com/repos/cyclus/cyclus/pulls/1266","html_url":"https://github.com/cyclus/cyclus/pull/1266","diff_url":"https://github.com/cyclus/cyclus/pull/1266.diff","patch_url":"https://github.com/cyclus/cyclus/pull/1266.patch"},"body":"This PR fixes a wide variety of issues that are seemingly only triggered by `conda build`, though they are outstanding issues in cyclus. The major ones are that:\r\n\r\n1. if the cyclus install or build paths somehow contain more than one trailing NULL byte, the dlopen() call will fail because we convert a C++ std::string to a c_str(), which will truncate it early.\r\n2. boosts `recursive_directory_iterator` will infinitely walk down directories that don't exist now because [as of 1.56](http://www.boost.org/doc/libs/1_60_0/libs/filesystem/doc/release_history.html) the increment() member function will now append the first element at whatever level it failed at.  Looking up agents on the `$CYCLUS_PATH` would thus yield an infinite search over recursive `bin/` subdirs. For example:\r\n\r\n```\r\nLooking up $CYCLUS_PATH/lib/cyclus\r\nLooking up $CYCLUS_PATH/lib/cyclus/bin\r\nLooking up $CYCLUS_PATH/lib/cyclus/bin/bin\r\nLooking up $CYCLUS_PATH/lib/cyclus/bin/bin/bin\r\netc.\r\n```\r\n\r\nEventually file system would fail (at around 2024 levels for me), where it would cycle and just try that dir over and over.  The fix is to make sure that the dir is a regular file before descending into as a dir or trying to use it as a shared object library.\r\n\r\nThere is also some other clean up with respect to using boost::filesystems ridiculously awful API, where you can't just call `if (fs::exists(path))` safely.\r\n\r\n@FlanFlanagan - maybe you can take a look at this.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/cyclus/cyclus/issues/comments/236340326","html_url":"https://github.com/cyclus/cyclus/pull/1266#issuecomment-236340326","issue_url":"https://api.github.com/repos/cyclus/cyclus/issues/1266","id":236340326,"user":{"login":"gonuke","id":764326,"avatar_url":"https://avatars.githubusercontent.com/u/764326?v=3","gravatar_id":"","url":"https://api.github.com/users/gonuke","html_url":"https://github.com/gonuke","followers_url":"https://api.github.com/users/gonuke/followers","following_url":"https://api.github.com/users/gonuke/following{/other_user}","gists_url":"https://api.github.com/users/gonuke/gists{/gist_id}","starred_url":"https://api.github.com/users/gonuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonuke/subscriptions","organizations_url":"https://api.github.com/users/gonuke/orgs","repos_url":"https://api.github.com/users/gonuke/repos","events_url":"https://api.github.com/users/gonuke/events{/privacy}","received_events_url":"https://api.github.com/users/gonuke/received_events","type":"User","site_admin":false},"created_at":"2016-07-30T04:11:58Z","updated_at":"2016-07-30T04:11:58Z","body":"Thanks @scopatz - this was some really arcane stuff here."}}
{"actor":{"display_login":"gonuke"}}