{"action":"created","comment":{"url":"https://api.github.com/repos/opencomputeproject/SAI/pulls/comments/85305892","pull_request_review_id":6028172,"id":85305892,"diff_hunk":"@@ -58,37 +58,43 @@ typedef struct _sai_object_key_t\n /**","path":"inc/saiobject.h","position":1,"original_position":1,"commit_id":"8fbdee552fc8e87bdb54e4b296a53b443e81bd4d","original_commit_id":"8fbdee552fc8e87bdb54e4b296a53b443e81bd4d","user":{"login":"AshokDaparthi","id":10464085,"avatar_url":"https://avatars.githubusercontent.com/u/10464085?v=3","gravatar_id":"","url":"https://api.github.com/users/AshokDaparthi","html_url":"https://github.com/AshokDaparthi","followers_url":"https://api.github.com/users/AshokDaparthi/followers","following_url":"https://api.github.com/users/AshokDaparthi/following{/other_user}","gists_url":"https://api.github.com/users/AshokDaparthi/gists{/gist_id}","starred_url":"https://api.github.com/users/AshokDaparthi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AshokDaparthi/subscriptions","organizations_url":"https://api.github.com/users/AshokDaparthi/orgs","repos_url":"https://api.github.com/users/AshokDaparthi/repos","events_url":"https://api.github.com/users/AshokDaparthi/events{/privacy}","received_events_url":"https://api.github.com/users/AshokDaparthi/received_events","type":"User","site_admin":false},"body":"yes, your understanding is correct. This file is defined to get the objects from SAI. switch id for other than create derived internally in SAI, in this bluk get cases,  caller can not know switch id by looking object id,\r\nsince this is implementation specific. \r\nbulk api's get(defined for warmboot),  it is good to know from which NPU they are getting bulk objects.  ","created_at":"2016-10-27T10:07:09Z","updated_at":"2016-10-27T10:07:09Z","html_url":"https://github.com/opencomputeproject/SAI/pull/250#discussion_r85305892","pull_request_url":"https://api.github.com/repos/opencomputeproject/SAI/pulls/250","_links":{"self":{"href":"https://api.github.com/repos/opencomputeproject/SAI/pulls/comments/85305892"},"html":{"href":"https://github.com/opencomputeproject/SAI/pull/250#discussion_r85305892"},"pull_request":{"href":"https://api.github.com/repos/opencomputeproject/SAI/pulls/250"}}},"pull_request":{"url":"https://api.github.com/repos/opencomputeproject/SAI/pulls/250","id":87690678,"html_url":"https://github.com/opencomputeproject/SAI/pull/250","diff_url":"https://github.com/opencomputeproject/SAI/pull/250.diff","patch_url":"https://github.com/opencomputeproject/SAI/pull/250.patch","issue_url":"https://api.github.com/repos/opencomputeproject/SAI/issues/250","number":250,"state":"open","locked":false,"title":"Multi NPU Switch id addition to API's","user":{"login":"AshokDaparthi","id":10464085,"avatar_url":"https://avatars.githubusercontent.com/u/10464085?v=3","gravatar_id":"","url":"https://api.github.com/users/AshokDaparthi","html_url":"https://github.com/AshokDaparthi","followers_url":"https://api.github.com/users/AshokDaparthi/followers","following_url":"https://api.github.com/users/AshokDaparthi/following{/other_user}","gists_url":"https://api.github.com/users/AshokDaparthi/gists{/gist_id}","starred_url":"https://api.github.com/users/AshokDaparthi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AshokDaparthi/subscriptions","organizations_url":"https://api.github.com/users/AshokDaparthi/orgs","repos_url":"https://api.github.com/users/AshokDaparthi/repos","events_url":"https://api.github.com/users/AshokDaparthi/events{/privacy}","received_events_url":"https://api.github.com/users/AshokDaparthi/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-03T10:03:31Z","updated_at":"2016-10-27T10:07:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ee08820976850edcfd100d27d6995eb9f33b73a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/opencomputeproject/SAI/pulls/250/commits","review_comments_url":"https://api.github.com/repos/opencomputeproject/SAI/pulls/250/comments","review_comment_url":"https://api.github.com/repos/opencomputeproject/SAI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencomputeproject/SAI/issues/250/comments","statuses_url":"https://api.github.com/repos/opencomputeproject/SAI/statuses/8fbdee552fc8e87bdb54e4b296a53b443e81bd4d","head":{"label":"AshokDaparthi:switchid-multi-npu","ref":"switchid-multi-npu","sha":"8fbdee552fc8e87bdb54e4b296a53b443e81bd4d","user":{"login":"AshokDaparthi","id":10464085,"avatar_url":"https://avatars.githubusercontent.com/u/10464085?v=3","gravatar_id":"","url":"https://api.github.com/users/AshokDaparthi","html_url":"https://github.com/AshokDaparthi","followers_url":"https://api.github.com/users/AshokDaparthi/followers","following_url":"https://api.github.com/users/AshokDaparthi/following{/other_user}","gists_url":"https://api.github.com/users/AshokDaparthi/gists{/gist_id}","starred_url":"https://api.github.com/users/AshokDaparthi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AshokDaparthi/subscriptions","organizations_url":"https://api.github.com/users/AshokDaparthi/orgs","repos_url":"https://api.github.com/users/AshokDaparthi/repos","events_url":"https://api.github.com/users/AshokDaparthi/events{/privacy}","received_events_url":"https://api.github.com/users/AshokDaparthi/received_events","type":"User","site_admin":false},"repo":{"id":43795400,"name":"SAI","full_name":"AshokDaparthi/SAI","owner":{"login":"AshokDaparthi","id":10464085,"avatar_url":"https://avatars.githubusercontent.com/u/10464085?v=3","gravatar_id":"","url":"https://api.github.com/users/AshokDaparthi","html_url":"https://github.com/AshokDaparthi","followers_url":"https://api.github.com/users/AshokDaparthi/followers","following_url":"https://api.github.com/users/AshokDaparthi/following{/other_user}","gists_url":"https://api.github.com/users/AshokDaparthi/gists{/gist_id}","starred_url":"https://api.github.com/users/AshokDaparthi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AshokDaparthi/subscriptions","organizations_url":"https://api.github.com/users/AshokDaparthi/orgs","repos_url":"https://api.github.com/users/AshokDaparthi/repos","events_url":"https://api.github.com/users/AshokDaparthi/events{/privacy}","received_events_url":"https://api.github.com/users/AshokDaparthi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AshokDaparthi/SAI","description":"Switch Abstraction Interface","fork":true,"url":"https://api.github.com/repos/AshokDaparthi/SAI","forks_url":"https://api.github.com/repos/AshokDaparthi/SAI/forks","keys_url":"https://api.github.com/repos/AshokDaparthi/SAI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AshokDaparthi/SAI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AshokDaparthi/SAI/teams","hooks_url":"https://api.github.com/repos/AshokDaparthi/SAI/hooks","issue_events_url":"https://api.github.com/repos/AshokDaparthi/SAI/issues/events{/number}","events_url":"https://api.github.com/repos/AshokDaparthi/SAI/events","assignees_url":"https://api.github.com/repos/AshokDaparthi/SAI/assignees{/user}","branches_url":"https://api.github.com/repos/AshokDaparthi/SAI/branches{/branch}","tags_url":"https://api.github.com/repos/AshokDaparthi/SAI/tags","blobs_url":"https://api.github.com/repos/AshokDaparthi/SAI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AshokDaparthi/SAI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AshokDaparthi/SAI/git/refs{/sha}","trees_url":"https://api.github.com/repos/AshokDaparthi/SAI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AshokDaparthi/SAI/statuses/{sha}","languages_url":"https://api.github.com/repos/AshokDaparthi/SAI/languages","stargazers_url":"https://api.github.com/repos/AshokDaparthi/SAI/stargazers","contributors_url":"https://api.github.com/repos/AshokDaparthi/SAI/contributors","subscribers_url":"https://api.github.com/repos/AshokDaparthi/SAI/subscribers","subscription_url":"https://api.github.com/repos/AshokDaparthi/SAI/subscription","commits_url":"https://api.github.com/repos/AshokDaparthi/SAI/commits{/sha}","git_commits_url":"https://api.github.com/repos/AshokDaparthi/SAI/git/commits{/sha}","comments_url":"https://api.github.com/repos/AshokDaparthi/SAI/comments{/number}","issue_comment_url":"https://api.github.com/repos/AshokDaparthi/SAI/issues/comments{/number}","contents_url":"https://api.github.com/repos/AshokDaparthi/SAI/contents/{+path}","compare_url":"https://api.github.com/repos/AshokDaparthi/SAI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AshokDaparthi/SAI/merges","archive_url":"https://api.github.com/repos/AshokDaparthi/SAI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AshokDaparthi/SAI/downloads","issues_url":"https://api.github.com/repos/AshokDaparthi/SAI/issues{/number}","pulls_url":"https://api.github.com/repos/AshokDaparthi/SAI/pulls{/number}","milestones_url":"https://api.github.com/repos/AshokDaparthi/SAI/milestones{/number}","notifications_url":"https://api.github.com/repos/AshokDaparthi/SAI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AshokDaparthi/SAI/labels{/name}","releases_url":"https://api.github.com/repos/AshokDaparthi/SAI/releases{/id}","deployments_url":"https://api.github.com/repos/AshokDaparthi/SAI/deployments","created_at":"2015-10-07T04:38:47Z","updated_at":"2016-01-12T03:24:47Z","pushed_at":"2016-10-25T07:14:18Z","git_url":"git://github.com/AshokDaparthi/SAI.git","ssh_url":"git@github.com:AshokDaparthi/SAI.git","clone_url":"https://github.com/AshokDaparthi/SAI.git","svn_url":"https://github.com/AshokDaparthi/SAI","homepage":null,"size":31286,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"switchid-multi-npu"}},"base":{"label":"opencomputeproject:master","ref":"master","sha":"4f537fe819351437513986d8531a883b547a08b1","user":{"login":"opencomputeproject","id":16659405,"avatar_url":"https://avatars.githubusercontent.com/u/16659405?v=3","gravatar_id":"","url":"https://api.github.com/users/opencomputeproject","html_url":"https://github.com/opencomputeproject","followers_url":"https://api.github.com/users/opencomputeproject/followers","following_url":"https://api.github.com/users/opencomputeproject/following{/other_user}","gists_url":"https://api.github.com/users/opencomputeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/opencomputeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencomputeproject/subscriptions","organizations_url":"https://api.github.com/users/opencomputeproject/orgs","repos_url":"https://api.github.com/users/opencomputeproject/repos","events_url":"https://api.github.com/users/opencomputeproject/events{/privacy}","received_events_url":"https://api.github.com/users/opencomputeproject/received_events","type":"Organization","site_admin":false},"repo":{"id":43159385,"name":"SAI","full_name":"opencomputeproject/SAI","owner":{"login":"opencomputeproject","id":16659405,"avatar_url":"https://avatars.githubusercontent.com/u/16659405?v=3","gravatar_id":"","url":"https://api.github.com/users/opencomputeproject","html_url":"https://github.com/opencomputeproject","followers_url":"https://api.github.com/users/opencomputeproject/followers","following_url":"https://api.github.com/users/opencomputeproject/following{/other_user}","gists_url":"https://api.github.com/users/opencomputeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/opencomputeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencomputeproject/subscriptions","organizations_url":"https://api.github.com/users/opencomputeproject/orgs","repos_url":"https://api.github.com/users/opencomputeproject/repos","events_url":"https://api.github.com/users/opencomputeproject/events{/privacy}","received_events_url":"https://api.github.com/users/opencomputeproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencomputeproject/SAI","description":"Switch Abstraction Interface","fork":false,"url":"https://api.github.com/repos/opencomputeproject/SAI","forks_url":"https://api.github.com/repos/opencomputeproject/SAI/forks","keys_url":"https://api.github.com/repos/opencomputeproject/SAI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencomputeproject/SAI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencomputeproject/SAI/teams","hooks_url":"https://api.github.com/repos/opencomputeproject/SAI/hooks","issue_events_url":"https://api.github.com/repos/opencomputeproject/SAI/issues/events{/number}","events_url":"https://api.github.com/repos/opencomputeproject/SAI/events","assignees_url":"https://api.github.com/repos/opencomputeproject/SAI/assignees{/user}","branches_url":"https://api.github.com/repos/opencomputeproject/SAI/branches{/branch}","tags_url":"https://api.github.com/repos/opencomputeproject/SAI/tags","blobs_url":"https://api.github.com/repos/opencomputeproject/SAI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencomputeproject/SAI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencomputeproject/SAI/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencomputeproject/SAI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencomputeproject/SAI/statuses/{sha}","languages_url":"https://api.github.com/repos/opencomputeproject/SAI/languages","stargazers_url":"https://api.github.com/repos/opencomputeproject/SAI/stargazers","contributors_url":"https://api.github.com/repos/opencomputeproject/SAI/contributors","subscribers_url":"https://api.github.com/repos/opencomputeproject/SAI/subscribers","subscription_url":"https://api.github.com/repos/opencomputeproject/SAI/subscription","commits_url":"https://api.github.com/repos/opencomputeproject/SAI/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencomputeproject/SAI/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencomputeproject/SAI/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencomputeproject/SAI/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencomputeproject/SAI/contents/{+path}","compare_url":"https://api.github.com/repos/opencomputeproject/SAI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencomputeproject/SAI/merges","archive_url":"https://api.github.com/repos/opencomputeproject/SAI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencomputeproject/SAI/downloads","issues_url":"https://api.github.com/repos/opencomputeproject/SAI/issues{/number}","pulls_url":"https://api.github.com/repos/opencomputeproject/SAI/pulls{/number}","milestones_url":"https://api.github.com/repos/opencomputeproject/SAI/milestones{/number}","notifications_url":"https://api.github.com/repos/opencomputeproject/SAI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencomputeproject/SAI/labels{/name}","releases_url":"https://api.github.com/repos/opencomputeproject/SAI/releases{/id}","deployments_url":"https://api.github.com/repos/opencomputeproject/SAI/deployments","created_at":"2015-09-25T16:19:31Z","updated_at":"2016-10-24T20:21:11Z","pushed_at":"2016-10-27T05:52:43Z","git_url":"git://github.com/opencomputeproject/SAI.git","ssh_url":"git@github.com:opencomputeproject/SAI.git","clone_url":"https://github.com/opencomputeproject/SAI.git","svn_url":"https://github.com/opencomputeproject/SAI","homepage":null,"size":67417,"stargazers_count":51,"watchers_count":51,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":49,"forks":63,"open_issues":49,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencomputeproject/SAI/pulls/250"},"html":{"href":"https://github.com/opencomputeproject/SAI/pull/250"},"issue":{"href":"https://api.github.com/repos/opencomputeproject/SAI/issues/250"},"comments":{"href":"https://api.github.com/repos/opencomputeproject/SAI/issues/250/comments"},"review_comments":{"href":"https://api.github.com/repos/opencomputeproject/SAI/pulls/250/comments"},"review_comment":{"href":"https://api.github.com/repos/opencomputeproject/SAI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencomputeproject/SAI/pulls/250/commits"},"statuses":{"href":"https://api.github.com/repos/opencomputeproject/SAI/statuses/8fbdee552fc8e87bdb54e4b296a53b443e81bd4d"}}}}
{"actor":{"display_login":"AshokDaparthi"}}