{"action":"closed","number":28,"pull_request":{"url":"https://api.github.com/repos/kokke/tiny-AES128-C/pulls/28","id":47227497,"html_url":"https://github.com/kokke/tiny-AES128-C/pull/28","diff_url":"https://github.com/kokke/tiny-AES128-C/pull/28.diff","patch_url":"https://github.com/kokke/tiny-AES128-C/pull/28.patch","issue_url":"https://api.github.com/repos/kokke/tiny-AES128-C/issues/28","number":28,"state":"closed","locked":false,"title":"Update aes.c","user":{"login":"andrewtong","id":10404525,"avatar_url":"https://avatars.githubusercontent.com/u/10404525?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewtong","html_url":"https://github.com/andrewtong","followers_url":"https://api.github.com/users/andrewtong/followers","following_url":"https://api.github.com/users/andrewtong/following{/other_user}","gists_url":"https://api.github.com/users/andrewtong/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewtong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewtong/subscriptions","organizations_url":"https://api.github.com/users/andrewtong/orgs","repos_url":"https://api.github.com/users/andrewtong/repos","events_url":"https://api.github.com/users/andrewtong/events{/privacy}","received_events_url":"https://api.github.com/users/andrewtong/received_events","type":"User","site_admin":false},"body":"I noticed that the inverse mix column function was very complex and wanted to simplify it while tailoring the new function towards the constraints of the project, which is to keep it as condensed as possible.  The benefits of the new Multiply function I have suggested are that it is significantly easier for a user to understand how the finite field multiplication works, it eliminates the need for the xtime() function, and that it operates under close to identical speeds as the original Multiply function.\r\n\r\nFrom my observation, the Inverse Mix Columns function is the most complex function in AES and is not particularly well documented online.  A simpler function may be beneficial towards those who may want to contribute toward Tiny-AES but may\r\nnot be all too familiar with the operations.","created_at":"2015-10-09T02:06:41Z","updated_at":"2016-06-15T18:50:54Z","closed_at":"2016-06-15T18:50:54Z","merged_at":null,"merge_commit_sha":"1a9b8f8992547c40ac008a500a750961ff956900","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kokke/tiny-AES128-C/pulls/28/commits","review_comments_url":"https://api.github.com/repos/kokke/tiny-AES128-C/pulls/28/comments","review_comment_url":"https://api.github.com/repos/kokke/tiny-AES128-C/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kokke/tiny-AES128-C/issues/28/comments","statuses_url":"https://api.github.com/repos/kokke/tiny-AES128-C/statuses/b9a239bcadf8023e6fc1a660126c6ab6db61b2ff","head":{"label":"andrewtong:patch-1","ref":"patch-1","sha":"b9a239bcadf8023e6fc1a660126c6ab6db61b2ff","user":{"login":"andrewtong","id":10404525,"avatar_url":"https://avatars.githubusercontent.com/u/10404525?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewtong","html_url":"https://github.com/andrewtong","followers_url":"https://api.github.com/users/andrewtong/followers","following_url":"https://api.github.com/users/andrewtong/following{/other_user}","gists_url":"https://api.github.com/users/andrewtong/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewtong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewtong/subscriptions","organizations_url":"https://api.github.com/users/andrewtong/orgs","repos_url":"https://api.github.com/users/andrewtong/repos","events_url":"https://api.github.com/users/andrewtong/events{/privacy}","received_events_url":"https://api.github.com/users/andrewtong/received_events","type":"User","site_admin":false},"repo":{"id":43926238,"name":"tiny-AES128-C","full_name":"andrewtong/tiny-AES128-C","owner":{"login":"andrewtong","id":10404525,"avatar_url":"https://avatars.githubusercontent.com/u/10404525?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewtong","html_url":"https://github.com/andrewtong","followers_url":"https://api.github.com/users/andrewtong/followers","following_url":"https://api.github.com/users/andrewtong/following{/other_user}","gists_url":"https://api.github.com/users/andrewtong/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewtong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewtong/subscriptions","organizations_url":"https://api.github.com/users/andrewtong/orgs","repos_url":"https://api.github.com/users/andrewtong/repos","events_url":"https://api.github.com/users/andrewtong/events{/privacy}","received_events_url":"https://api.github.com/users/andrewtong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewtong/tiny-AES128-C","description":"Small portable AES128 in C","fork":true,"url":"https://api.github.com/repos/andrewtong/tiny-AES128-C","forks_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/forks","keys_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/teams","hooks_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/hooks","issue_events_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/issues/events{/number}","events_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/events","assignees_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/assignees{/user}","branches_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/branches{/branch}","tags_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/tags","blobs_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/languages","stargazers_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/stargazers","contributors_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/contributors","subscribers_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/subscribers","subscription_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/subscription","commits_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/contents/{+path}","compare_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/merges","archive_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/downloads","issues_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/issues{/number}","pulls_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/labels{/name}","releases_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/releases{/id}","deployments_url":"https://api.github.com/repos/andrewtong/tiny-AES128-C/deployments","created_at":"2015-10-09T01:39:56Z","updated_at":"2015-10-09T01:39:57Z","pushed_at":"2015-10-09T02:05:31Z","git_url":"git://github.com/andrewtong/tiny-AES128-C.git","ssh_url":"git@github.com:andrewtong/tiny-AES128-C.git","clone_url":"https://github.com/andrewtong/tiny-AES128-C.git","svn_url":"https://github.com/andrewtong/tiny-AES128-C","homepage":"","size":137,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kokke:master","ref":"master","sha":"7c959460a188611c26aa45c54c6e8b96b7ac163a","user":{"login":"kokke","id":1774646,"avatar_url":"https://avatars.githubusercontent.com/u/1774646?v=3","gravatar_id":"","url":"https://api.github.com/users/kokke","html_url":"https://github.com/kokke","followers_url":"https://api.github.com/users/kokke/followers","following_url":"https://api.github.com/users/kokke/following{/other_user}","gists_url":"https://api.github.com/users/kokke/gists{/gist_id}","starred_url":"https://api.github.com/users/kokke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kokke/subscriptions","organizations_url":"https://api.github.com/users/kokke/orgs","repos_url":"https://api.github.com/users/kokke/repos","events_url":"https://api.github.com/users/kokke/events{/privacy}","received_events_url":"https://api.github.com/users/kokke/received_events","type":"User","site_admin":false},"repo":{"id":4434428,"name":"tiny-AES128-C","full_name":"kokke/tiny-AES128-C","owner":{"login":"kokke","id":1774646,"avatar_url":"https://avatars.githubusercontent.com/u/1774646?v=3","gravatar_id":"","url":"https://api.github.com/users/kokke","html_url":"https://github.com/kokke","followers_url":"https://api.github.com/users/kokke/followers","following_url":"https://api.github.com/users/kokke/following{/other_user}","gists_url":"https://api.github.com/users/kokke/gists{/gist_id}","starred_url":"https://api.github.com/users/kokke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kokke/subscriptions","organizations_url":"https://api.github.com/users/kokke/orgs","repos_url":"https://api.github.com/users/kokke/repos","events_url":"https://api.github.com/users/kokke/events{/privacy}","received_events_url":"https://api.github.com/users/kokke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kokke/tiny-AES128-C","description":"Small portable AES128 in C","fork":false,"url":"https://api.github.com/repos/kokke/tiny-AES128-C","forks_url":"https://api.github.com/repos/kokke/tiny-AES128-C/forks","keys_url":"https://api.github.com/repos/kokke/tiny-AES128-C/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kokke/tiny-AES128-C/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kokke/tiny-AES128-C/teams","hooks_url":"https://api.github.com/repos/kokke/tiny-AES128-C/hooks","issue_events_url":"https://api.github.com/repos/kokke/tiny-AES128-C/issues/events{/number}","events_url":"https://api.github.com/repos/kokke/tiny-AES128-C/events","assignees_url":"https://api.github.com/repos/kokke/tiny-AES128-C/assignees{/user}","branches_url":"https://api.github.com/repos/kokke/tiny-AES128-C/branches{/branch}","tags_url":"https://api.github.com/repos/kokke/tiny-AES128-C/tags","blobs_url":"https://api.github.com/repos/kokke/tiny-AES128-C/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kokke/tiny-AES128-C/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kokke/tiny-AES128-C/git/refs{/sha}","trees_url":"https://api.github.com/repos/kokke/tiny-AES128-C/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kokke/tiny-AES128-C/statuses/{sha}","languages_url":"https://api.github.com/repos/kokke/tiny-AES128-C/languages","stargazers_url":"https://api.github.com/repos/kokke/tiny-AES128-C/stargazers","contributors_url":"https://api.github.com/repos/kokke/tiny-AES128-C/contributors","subscribers_url":"https://api.github.com/repos/kokke/tiny-AES128-C/subscribers","subscription_url":"https://api.github.com/repos/kokke/tiny-AES128-C/subscription","commits_url":"https://api.github.com/repos/kokke/tiny-AES128-C/commits{/sha}","git_commits_url":"https://api.github.com/repos/kokke/tiny-AES128-C/git/commits{/sha}","comments_url":"https://api.github.com/repos/kokke/tiny-AES128-C/comments{/number}","issue_comment_url":"https://api.github.com/repos/kokke/tiny-AES128-C/issues/comments{/number}","contents_url":"https://api.github.com/repos/kokke/tiny-AES128-C/contents/{+path}","compare_url":"https://api.github.com/repos/kokke/tiny-AES128-C/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kokke/tiny-AES128-C/merges","archive_url":"https://api.github.com/repos/kokke/tiny-AES128-C/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kokke/tiny-AES128-C/downloads","issues_url":"https://api.github.com/repos/kokke/tiny-AES128-C/issues{/number}","pulls_url":"https://api.github.com/repos/kokke/tiny-AES128-C/pulls{/number}","milestones_url":"https://api.github.com/repos/kokke/tiny-AES128-C/milestones{/number}","notifications_url":"https://api.github.com/repos/kokke/tiny-AES128-C/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kokke/tiny-AES128-C/labels{/name}","releases_url":"https://api.github.com/repos/kokke/tiny-AES128-C/releases{/id}","deployments_url":"https://api.github.com/repos/kokke/tiny-AES128-C/deployments","created_at":"2012-05-24T15:27:24Z","updated_at":"2016-06-15T07:41:10Z","pushed_at":"2016-06-15T18:09:57Z","git_url":"git://github.com/kokke/tiny-AES128-C.git","ssh_url":"git@github.com:kokke/tiny-AES128-C.git","clone_url":"https://github.com/kokke/tiny-AES128-C.git","svn_url":"https://github.com/kokke/tiny-AES128-C","homepage":"","size":125,"stargazers_count":298,"watchers_count":298,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":165,"mirror_url":null,"open_issues_count":17,"forks":165,"open_issues":17,"watchers":298,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kokke/tiny-AES128-C/pulls/28"},"html":{"href":"https://github.com/kokke/tiny-AES128-C/pull/28"},"issue":{"href":"https://api.github.com/repos/kokke/tiny-AES128-C/issues/28"},"comments":{"href":"https://api.github.com/repos/kokke/tiny-AES128-C/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/kokke/tiny-AES128-C/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/kokke/tiny-AES128-C/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kokke/tiny-AES128-C/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/kokke/tiny-AES128-C/statuses/b9a239bcadf8023e6fc1a660126c6ab6db61b2ff"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":19,"deletions":17,"changed_files":1}}
{"actor":{"display_login":"kokke"}}