{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/21742","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/21742/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/21742/comments","events_url":"https://api.github.com/repos/docker/docker/issues/21742/events","html_url":"https://github.com/docker/docker/pull/21742","id":145662541,"number":21742,"title":"[1.11-rc3] contrib: init: systemd: remove incorrect systemd options","user":{"login":"cyphar","id":2888411,"avatar_url":"https://avatars.githubusercontent.com/u/2888411?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-04-04T11:54:52Z","updated_at":"2016-04-13T18:27:21Z","closed_at":"2016-04-13T18:27:20Z","pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/21742","html_url":"https://github.com/docker/docker/pull/21742","diff_url":"https://github.com/docker/docker/pull/21742.diff","patch_url":"https://github.com/docker/docker/pull/21742.patch"},"body":"MountFlags=slave causes Docker to not operate with containerd if it was\r\nstarted as a service, separately from Docker. Since containerd as a\r\nservice is in a separate mount namepsace from Docker (in contrast with\r\nwhen Docker starts containerd by itself) this results in containerd not\r\nbeing able to use the rootfs mounted by Docker.\r\n\r\nRemove this outdated option from the service file.\r\n\r\nSince Docker no longer manages any containers (it's all done by\r\ncontainerd), Delegate=yes no longer makes any sense. Remove it because\r\nit's just clutter.\r\n\r\n![lazer kitteh](https://c3.staticflickr.com/3/2455/3566421306_edb4ec86d3_n.jpg)\r\n\r\nSigned-off-by: Aleksa Sarai <asarai@suse.de>\r\n\r\n\r\nThis **must** be merged for 1.11, because it affects how distributions will package containerd with Docker. At SUSE, we're planning on packaging containerd as a separate service so this is a real issue for us.\r\n\r\n/cc @lsm5 @philips @jfrazelle"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/209581315","html_url":"https://github.com/docker/docker/pull/21742#issuecomment-209581315","issue_url":"https://api.github.com/repos/docker/docker/issues/21742","id":209581315,"user":{"login":"calavera","id":1050,"avatar_url":"https://avatars.githubusercontent.com/u/1050?v=3","gravatar_id":"","url":"https://api.github.com/users/calavera","html_url":"https://github.com/calavera","followers_url":"https://api.github.com/users/calavera/followers","following_url":"https://api.github.com/users/calavera/following{/other_user}","gists_url":"https://api.github.com/users/calavera/gists{/gist_id}","starred_url":"https://api.github.com/users/calavera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calavera/subscriptions","organizations_url":"https://api.github.com/users/calavera/orgs","repos_url":"https://api.github.com/users/calavera/repos","events_url":"https://api.github.com/users/calavera/events{/privacy}","received_events_url":"https://api.github.com/users/calavera/received_events","type":"User","site_admin":false},"created_at":"2016-04-13T18:27:20Z","updated_at":"2016-04-13T18:27:20Z","body":"Agree with other maintainers. We do not want to do this. We can revisit if we make docker to not start containerd. Thanks for the suggestion, but I'm going to close it."}}