{"action":"created","issue":{"url":"https://api.github.com/repos/zanata/zanata-scripts/issues/7","repository_url":"https://api.github.com/repos/zanata/zanata-scripts","labels_url":"https://api.github.com/repos/zanata/zanata-scripts/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/zanata/zanata-scripts/issues/7/comments","events_url":"https://api.github.com/repos/zanata/zanata-scripts/issues/7/events","html_url":"https://github.com/zanata/zanata-scripts/pull/7","id":165266517,"number":7,"title":"feat(ZNTA-1165): Script to upload files to GitHub release","user":{"login":"definite","id":28877,"avatar_url":"https://avatars.githubusercontent.com/u/28877?v=3","gravatar_id":"","url":"https://api.github.com/users/definite","html_url":"https://github.com/definite","followers_url":"https://api.github.com/users/definite/followers","following_url":"https://api.github.com/users/definite/following{/other_user}","gists_url":"https://api.github.com/users/definite/gists{/gist_id}","starred_url":"https://api.github.com/users/definite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/definite/subscriptions","organizations_url":"https://api.github.com/users/definite/orgs","repos_url":"https://api.github.com/users/definite/repos","events_url":"https://api.github.com/users/definite/events{/privacy}","received_events_url":"https://api.github.com/users/definite/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/zanata/zanata-scripts/labels/Awaiting%20review","name":"Awaiting review","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-13T08:36:15Z","updated_at":"2016-08-05T01:28:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zanata/zanata-scripts/pulls/7","html_url":"https://github.com/zanata/zanata-scripts/pull/7","diff_url":"https://github.com/zanata/zanata-scripts/pull/7.diff","patch_url":"https://github.com/zanata/zanata-scripts/pull/7.patch"},"body":"Brief usage:\r\n\r\n* zanata-github-upload -h\r\n       Show detailed help\r\n\r\n* zanata-github-upload -dv server-3.9.1 &lt;PATH&gt;/zanata-war-3.9.1.war\r\n       `-d`: Draft release, `-v`:Verbose mode that prints debug message like HTTP response\r\n       It will create a 'draft' server-3.9.1 release,  upload &lt;PATH&gt;/zanata-war-3.9.1.war,\r\n      and show debug message.\r\n\r\n* zanata-github-upload server-3.9.1 &lt;PATH&gt;/zanata-war-3.9.1.war\r\n       It will create the 'real' server-3.9.1 release (if not already exists), then upload &lt;PATH&gt;/zanata-war-3.9.1.war to server-3.9.1\r\n\r\nSetup:\r\n     You need to create ~/.config/zanata-scripts.ini and put your github username and token (NOT YOUR PASSWORD). Detail should be explained in FILE section in `zanata-github-upload -h`\r\n\r\nTest tip:\r\n Find the tags that do not have release, e.g. tag before server-3.6.0. `zanata-github-upload` does not check what file it upload.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/zanata/zanata-scripts/7)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/zanata/zanata-scripts/issues/comments/237732771","html_url":"https://github.com/zanata/zanata-scripts/pull/7#issuecomment-237732771","issue_url":"https://api.github.com/repos/zanata/zanata-scripts/issues/7","id":237732771,"user":{"login":"davidmason","id":482026,"avatar_url":"https://avatars.githubusercontent.com/u/482026?v=3","gravatar_id":"","url":"https://api.github.com/users/davidmason","html_url":"https://github.com/davidmason","followers_url":"https://api.github.com/users/davidmason/followers","following_url":"https://api.github.com/users/davidmason/following{/other_user}","gists_url":"https://api.github.com/users/davidmason/gists{/gist_id}","starred_url":"https://api.github.com/users/davidmason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidmason/subscriptions","organizations_url":"https://api.github.com/users/davidmason/orgs","repos_url":"https://api.github.com/users/davidmason/repos","events_url":"https://api.github.com/users/davidmason/events{/privacy}","received_events_url":"https://api.github.com/users/davidmason/received_events","type":"User","site_admin":false},"created_at":"2016-08-05T01:28:48Z","updated_at":"2016-08-05T01:28:48Z","body":"\n\n\n\nReviewed 3 of 3 files at r2.\nReview status: all files reviewed at latest revision, 4 unresolved discussions.\n\n---\n\n*[zanata-github-upload, line 13 \\[r1\\]](https://reviewable.io:443/reviews/zanata/zanata-scripts/7#-KOISExX9eH5zs9qSxX7:-KON0cGhTwUyM3lv-6A4:-1870851610) ([raw file](https://github.com/zanata/zanata-scripts/blob/89d10a930bc74a60a3f42977919623057607d43f/zanata-github-upload#L13)):*\n<details><summary><i>Previously, definite (Ding-Yi Chen) wrote…</i></summary>\n> What you say is for web page presentation. \n> However,  [Pod:Usage](http://perldoc.perl.org/Pod/Usage.html#pod2usage%28%29) uses  `=head1` for section header.\n</details>\nI thought it might be something like that.\n\n---\n\n*[zanata-github-upload, line 119 \\[r1\\]](https://reviewable.io:443/reviews/zanata/zanata-scripts/7#-KOIen9ut2rXVIfsqm39:-KONInL8RAy2ypMp2Tka:-566839224) ([raw file](https://github.com/zanata/zanata-scripts/blob/89d10a930bc74a60a3f42977919623057607d43f/zanata-github-upload#L119)):*\n<details><summary><i>Previously, definite (Ding-Yi Chen) wrote…</i></summary>\n> Not in this part, it only convert something like `server` to `zanata-server` or `zanata-parent` to `zanata-parent`, so less typing in command line.\n</details>\nValue of `$module` would be `-` if it doesn't match, right? It could check that and exit with an error if it finds that value since we know it wouldn't be able to create a release, right?\n\n---\n\n*[zanata-github-upload, line 39 \\[r2\\]](https://reviewable.io:443/reviews/zanata/zanata-scripts/7#-KON1DUEAkHa0RXZqIan:-KON1DUEAkHa0RXZqIao:392969894) ([raw file](https://github.com/zanata/zanata-scripts/blob/9d48ff4a813c665c568378a61a59c6550ff94a1b/zanata-github-upload#L39)):*\n> ```\n> Create a new draft GitHub release.\n> This program does not find existing draft release,\n> so run this program multiple times creates multiple draft releases.\n> ```\n\n(grammar) `... so running this ...`\n\n---\n\n*[zanata-package-fedora, line 203 \\[r2\\]](https://reviewable.io:443/reviews/zanata/zanata-scripts/7#-KONH__kp9buBo1VqA65:-KONH__kp9buBo1VqA66:-667974768) ([raw file](https://github.com/zanata/zanata-scripts/blob/9d48ff4a813c665c568378a61a59c6550ff94a1b/zanata-package-fedora#L203)):*\n> ```\n>     print_status -t \"Buildroot Override\" -s \"Start\"\n>     for bodhiBranch in $(cmake-fedora-koji bodhi-branch fedora | xargs );do\n> \tbodhi --buildroot-override $Module-$Version-$SpecRelease.$bodhiBranch\n> ```\n\nThere is a tab indent here, but the rest are spaces.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/zanata/zanata-scripts/7)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"davidmason"}}