{"action":"created","issue":{"url":"https://api.github.com/repos/hilbert/hilbert-cli/issues/27","repository_url":"https://api.github.com/repos/hilbert/hilbert-cli","labels_url":"https://api.github.com/repos/hilbert/hilbert-cli/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/hilbert/hilbert-cli/issues/27/comments","events_url":"https://api.github.com/repos/hilbert/hilbert-cli/issues/27/events","html_url":"https://github.com/hilbert/hilbert-cli/issues/27","id":184320567,"number":27,"title":"Danger of silent overrides due to YAML","user":{"login":"malex984","id":391009,"avatar_url":"https://avatars.githubusercontent.com/u/391009?v=3","gravatar_id":"","url":"https://api.github.com/users/malex984","html_url":"https://github.com/malex984","followers_url":"https://api.github.com/users/malex984/followers","following_url":"https://api.github.com/users/malex984/following{/other_user}","gists_url":"https://api.github.com/users/malex984/gists{/gist_id}","starred_url":"https://api.github.com/users/malex984/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malex984/subscriptions","organizations_url":"https://api.github.com/users/malex984/orgs","repos_url":"https://api.github.com/users/malex984/repos","events_url":"https://api.github.com/users/malex984/events{/privacy}","received_events_url":"https://api.github.com/users/malex984/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/hilbert/hilbert-cli/milestones/1","html_url":"https://github.com/hilbert/hilbert-cli/milestones/Configuration%20design","labels_url":"https://api.github.com/repos/hilbert/hilbert-cli/milestones/1/labels","id":2082308,"number":1,"title":"Configuration design","description":null,"creator":{"login":"elondaits","id":6472073,"avatar_url":"https://avatars.githubusercontent.com/u/6472073?v=3","gravatar_id":"","url":"https://api.github.com/users/elondaits","html_url":"https://github.com/elondaits","followers_url":"https://api.github.com/users/elondaits/followers","following_url":"https://api.github.com/users/elondaits/following{/other_user}","gists_url":"https://api.github.com/users/elondaits/gists{/gist_id}","starred_url":"https://api.github.com/users/elondaits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elondaits/subscriptions","organizations_url":"https://api.github.com/users/elondaits/orgs","repos_url":"https://api.github.com/users/elondaits/repos","events_url":"https://api.github.com/users/elondaits/events{/privacy}","received_events_url":"https://api.github.com/users/elondaits/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":1,"state":"open","created_at":"2016-10-20T11:39:41Z","updated_at":"2016-10-20T19:53:48Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2016-10-20T19:35:21Z","updated_at":"2016-10-20T21:07:37Z","closed_at":null,"body":"Consider the following YAML: \n\n```\nglobal: # will be hidden\n  something: c\n\nglobal:  # silently hides the whole previously defined `global`\n  local: a # will be hidden\n  other: b\n  local: A # silently overrides the whole previously defined `global :: local`\n```\n\nThe above [results](http://yaml-online-parser.appspot.com/?yaml=global%3A%20%23%20will%20be%20hidden%0A%20%20something%3A%20c%0A%0Aglobal%3A%20%20%23%20silently%20hides%20the%20whole%20previously%20defined%20%60global%60%0A%20%20local%3A%20a%20%23%20will%20be%20hidden%0A%20%20other%3A%20b%0A%20%20local%3A%20A%20%23%20silently%20overrides%20the%20whole%20previously%20defined%20%60global%20%3A%3A%20local%60%0A&type=canonical_yaml) in: \n```\nglobal:\n  other: b\n  local: A\n```\n\n@porst17 @elondaits : IMO we should at least warn users about such overrides!"},"comment":{"url":"https://api.github.com/repos/hilbert/hilbert-cli/issues/comments/255228618","html_url":"https://github.com/hilbert/hilbert-cli/issues/27#issuecomment-255228618","issue_url":"https://api.github.com/repos/hilbert/hilbert-cli/issues/27","id":255228618,"user":{"login":"malex984","id":391009,"avatar_url":"https://avatars.githubusercontent.com/u/391009?v=3","gravatar_id":"","url":"https://api.github.com/users/malex984","html_url":"https://github.com/malex984","followers_url":"https://api.github.com/users/malex984/followers","following_url":"https://api.github.com/users/malex984/following{/other_user}","gists_url":"https://api.github.com/users/malex984/gists{/gist_id}","starred_url":"https://api.github.com/users/malex984/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malex984/subscriptions","organizations_url":"https://api.github.com/users/malex984/orgs","repos_url":"https://api.github.com/users/malex984/repos","events_url":"https://api.github.com/users/malex984/events{/privacy}","received_events_url":"https://api.github.com/users/malex984/received_events","type":"User","site_admin":false},"created_at":"2016-10-20T21:07:37Z","updated_at":"2016-10-20T21:07:37Z","body":"This \"feature\" is very dangerous in the view to general config file structure as described at \r\n https://github.com/hilbert/hilbert-cli/issues/17#issuecomment-255210272\r\n\r\nI mean - users may erroneously introduce new objects with old IDs simply by forgetting to change objectID during addition of a new object via copy/paste.\r\n\r\nNOTE: with `ruamel.yaml` one can prevent re-definition of mapping keys by extending YAML loader, e.g. following: http://stackoverflow.com/a/34363871  (i have fixed that code sample to work).\r\n"}}
{"actor":{"display_login":"malex984"}}