{"push_id":1254567897,"size":31,"distinct_size":31,"ref":"refs/heads/master","head":"a99a51e58d49ab191fe888791422e6210720b657","before":"c2f1734c68d54fd8a20a293e9a69fd4fc76ebe5b","commits":[{"sha":"017f66415860de27b5407ee99e487e6503b2a861","author":{"name":"Philippe Hausler","email":"b21fe5eceabde85a667506885bb766a1db9b491c@apple.com"},"message":"[Foundation] Ensure _SwiftNSCharacterSet overrides all abstract methods on NSCharacterSet via @objc\n\nThe override methods were not marked with @objc which incorrectly funneled to the abstract base class methods. In the method isSuperset(of:) it would incorrectly hit a requirement of a subclass implementation. This exposed a flaw with NSCharacterSet in which that method cannot recieve subclasses to the other CharacterSet being passed. This is being tracked via rdar://problem/27768939 which will need to be accounted for by CoreFoundation. Until such a time that can be addressed the workaround by using CFCharacterSetIsSupersetOfSet must be used with a copy passed as the other set.\n\nThis resolves:\nhttps://bugs.swift.org/browse/SR-2307","distinct":true,"url":"https://api.github.com/repos/bob-wilson/swift/commits/017f66415860de27b5407ee99e487e6503b2a861"},{"sha":"2e0bb9676d70c9df21743623c4b2022da217c2f2","author":{"name":"David Grove","email":"f1568e645e89803703cf655c7f1de78465d6e598@us.ibm.com"},"message":"ClangImporter: enable -fblocks on non-Darwin platforms\n\nWe need to enable blocks support in the ClangImporter on\nnon-Darwin platforms for libdispatch (and transitively foundation).\nThe simplest way to do this is to just enable blocks unconditionally.\n\nAlso enable two Linux tests that are no longer XFAILS","distinct":true,"url":"https://api.github.com/repos/bob-wilson/swift/commits/2e0bb9676d70c9df21743623c4b2022da217c2f2"},{"sha":"ccf44d8f98518ef50f8a7277fdd1b652b4e0eb38","author":{"name":"practicalswift","email":"7bc8dfe66114fb97ee9aed052bc05e17800b570f@users.noreply.github.com"},"message":"[swiftc (49 vs. 5156)] Add crasher in swift::SILModule::constructSIL(...)\n\nAdd test case for crash triggered in `swift::SILModule::constructSIL(...)`.\n\nCurrent number of unresolved compiler crashers: 49 (5156 resolved)\n\nAssertion failure in [`lib/SILGen/SILGenApply.cpp (line 1114)`](https://github.com/apple/swift/blob/master/lib/SILGen/SILGenApply.cpp#L1114):\n\n```\nAssertion `vd->isLet() && \"Direct reference to vardecl that isn't a let?\"' failed.\n\nWhen executing: void (anonymous namespace)::SILGenApply::visitDeclRefExpr(swift::DeclRefExpr *)\n```\n\nAssertion context:\n\n```\n\n    // If this is a direct reference to a vardecl, it must be a let constant\n    // (which doesn't need to be loaded).  Just emit its value directly.\n    if (auto *vd = dyn_cast<VarDecl>(e->getDecl())) {\n      (void)vd;\n      assert(vd->isLet() && \"Direct reference to vardecl that isn't a let?\");\n      visitExpr(e);\n      return;\n    }\n\n    SILDeclRef constant(e->getDecl(),\n```\nStack trace:\n\n```\nswift: /path/to/swift/lib/SILGen/SILGenApply.cpp:1114: void (anonymous namespace)::SILGenApply::visitDeclRefExpr(swift::DeclRefExpr *): Assertion `vd->isLet() && \"Direct reference to vardecl that isn't a let?\"' failed.\n37 swift           0x000000000093f4c2 swift::SILModule::constructSIL(swift::ModuleDecl*, swift::SILOptions&, swift::FileUnit*, llvm::Optional<unsigned int>, bool, bool) + 498\n38 swift           0x000000000093fa36 swift::performSILGeneration(swift::FileUnit&, swift::SILOptions&, llvm::Optional<unsigned int>, bool) + 118\n40 swift           0x00000000007db487 swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) + 2887\n41 swift           0x00000000007a72b8 main + 2872\nStack dump:\n0.\tProgram arguments: /path/to/swift/bin/swift -frontend -c -primary-file validation-test/compiler_crashers/28396-swift-lowering-silgenfunction-emitclosurevalue.swift -target x86_64-unknown-linux-gnu -disable-objc-interop -module-name main -o /tmp/28396-swift-lowering-silgenfunction-emitclosurevalue-c63b87.o\n1.\tWhile emitting SIL for 'a' at validation-test/compiler_crashers/28396-swift-lowering-silgenfunction-emitclosurevalue.swift:10:1\n2.\tWhile emitting SIL for getter for b at validation-test/compiler_crashers/28396-swift-lowering-silgenfunction-emitclosurevalue.swift:10:22\n3.\tWhile silgen closureexpr SIL function @_TFFF4main1aFT_T_gL_1bFT_T_U_FT_T_ for expression at [validation-test/compiler_crashers/28396-swift-lowering-silgenfunction-emitclosurevalue.swift:10:29 - line:10:33] RangeText=\"{b()}\"\n<unknown>:0: error: unable to execute command: Aborted\n<unknown>:0: error: compile command failed due to signal (use -v to see invocation)\n```","distinct":true,"url":"https://api.github.com/repos/bob-wilson/swift/commits/ccf44d8f98518ef50f8a7277fdd1b652b4e0eb38"},{"sha":"063bcbe021414169eecfaf3f63aca072288120ae","author":{"name":"Brian Gesiak","email":"0c09f9ac95ab928573a6428d24847856289273b0@gmail.com"},"message":"[stdlib] Fix extraneous parameters\n\nFix \"extraneous duplicate parameter name\" warnings in the stdlib.","distinct":true,"url":"https://api.github.com/repos/bob-wilson/swift/commits/063bcbe021414169eecfaf3f63aca072288120ae"},{"sha":"5369988c518d923e6d64eca479bbec185d224349","author":{"name":"Arnold Schwaighofer","email":"ec16931005caca57236702eaf0d9fa848ebc9bbc@apple.com"},"message":"IRGen: Bind archetype access paths in emitFieldTypeAccessor\n\nSR-1951\nrdar://27718494","distinct":true,"url":"https://api.github.com/repos/bob-wilson/swift/commits/5369988c518d923e6d64eca479bbec185d224349"},{"sha":"5307a79b828f9e6e81f1689a2ef4ad94fe2fbb4c","author":{"name":"Mark Lacey","email":"9739346be89682b559148778f688e06e502b740c@apple.com"},"message":"Add known type checker crashers.\n\nAdd minimized tests for:\n    rdar://problem/27261929\n    rdar://problem/27329076","distinct":true,"url":"https://api.github.com/repos/bob-wilson/swift/commits/5307a79b828f9e6e81f1689a2ef4ad94fe2fbb4c"},{"sha":"8141363e323a7e1c84060a06f93cd1342eca7112","author":{"name":"Jordan Rose","email":"92520b00b4dfdc269f73534aec3bca632e7dd331@apple.com"},"message":"Optional swift_newtype types are @objc if the raw type would be @objc.\n\nThis was causing issues where the compiler rejected overrides of\nimported members as being non-ObjC-compatible, even though the type\nwas exactly the same as what the Clang importer was using.\n\nhttps://bugs.swift.org/browse/SR-2344","distinct":true,"url":"https://api.github.com/repos/bob-wilson/swift/commits/8141363e323a7e1c84060a06f93cd1342eca7112"},{"sha":"2e78e625afc14f42854c0adf1e3b20616d12899b","author":{"name":"Jordan Rose","email":"92520b00b4dfdc269f73534aec3bca632e7dd331@apple.com"},"message":"Merge pull request #4337 from jrose-apple/optional-newtype\n\nOptional swift_newtype types are @objc if the raw type would be @objc.","distinct":true,"url":"https://api.github.com/repos/bob-wilson/swift/commits/2e78e625afc14f42854c0adf1e3b20616d12899b"},{"sha":"0be294f5f747c4c40238c350bd587f1d12b915ea","author":{"name":"Jordan Rose","email":"92520b00b4dfdc269f73534aec3bca632e7dd331@apple.com"},"message":"[docs] Add \"LGTM\" to the Lexicon.","distinct":true,"url":"https://api.github.com/repos/bob-wilson/swift/commits/0be294f5f747c4c40238c350bd587f1d12b915ea"},{"sha":"91daa5c0b2403f5289c2215e34b1c759dc01b2b6","author":{"name":"Jordan Rose","email":"92520b00b4dfdc269f73534aec3bca632e7dd331@apple.com"},"message":"[docs] LibraryEvolution: Update for 'open' and 'Never'.","distinct":true,"url":"https://api.github.com/repos/bob-wilson/swift/commits/91daa5c0b2403f5289c2215e34b1c759dc01b2b6"},{"sha":"be5636ad8d41c4491d4973206ddf4c16a9f32271","author":{"name":"Mark Lacey","email":"4e491ababd06390b95e27f7793130f9a5518267c@users.noreply.github.com"},"message":"Merge pull request #4341 from rudkx/crashers\n\nAdd known type checker crashers.","distinct":true,"url":"https://api.github.com/repos/bob-wilson/swift/commits/be5636ad8d41c4491d4973206ddf4c16a9f32271"},{"sha":"5e1a3c38d36563c5be573b2adf1369ac0d100652","author":{"name":"Jordan Rose","email":"92520b00b4dfdc269f73534aec3bca632e7dd331@apple.com"},"message":"[docs] Note that LibraryEvolution uses Sphinx-specific features.","distinct":true,"url":"https://api.github.com/repos/bob-wilson/swift/commits/5e1a3c38d36563c5be573b2adf1369ac0d100652"},{"sha":"48da44e366b7f3de1758aa865468a36afbb585a1","author":{"name":"Jordan Rose","email":"92520b00b4dfdc269f73534aec3bca632e7dd331@apple.com"},"message":"Merge pull request #4343 from jrose-apple/doc-updates\n\n[docs] Update LibraryEvolution and Lexicon","distinct":true,"url":"https://api.github.com/repos/bob-wilson/swift/commits/48da44e366b7f3de1758aa865468a36afbb585a1"},{"sha":"394094f732f3c8b0a78236e43b8ac2a28e4f547e","author":{"name":"Doug Gregor","email":"251fda27d0a603ec7038aeb3aa510e8fbf5b9bc1@apple.com"},"message":"[Foundation overlay] Drop redundant 'Error' in the CocoaError code names.\n\nNote: we leave all of the old names in as deprecated (with a rename),\nso that we don't actually break any existing source code. Fixes\nrdar://problem/27778189.","distinct":true,"url":"https://api.github.com/repos/bob-wilson/swift/commits/394094f732f3c8b0a78236e43b8ac2a28e4f547e"},{"sha":"e360d7f2b020c992e2aab8bcccd3b7d57eecb73d","author":{"name":"John McCall","email":"c8773ae2de18f76a4f98bb913a3256b77114c46c@apple.com"},"message":"Fix the open-existential remover to not die on the OVEs in collection upcasts.","distinct":true,"url":"https://api.github.com/repos/bob-wilson/swift/commits/e360d7f2b020c992e2aab8bcccd3b7d57eecb73d"},{"sha":"10c9d632160cee0c174e29ff176f8c6e249ff286","author":{"name":"swift-ci","email":"ba4463bdeeb747bfa14a6c06d0b8d74a99982bde@users.noreply.github.com"},"message":"Merge pull request #4344 from DougGregor/cocoa-error-redundancy-rdar27778189","distinct":true,"url":"https://api.github.com/repos/bob-wilson/swift/commits/10c9d632160cee0c174e29ff176f8c6e249ff286"},{"sha":"9d266d78053b94192ebf403251a64b086b64beec","author":{"name":"Dmitri Gribenko","email":"1d361ada365e4964f49a61228b2eb80f416328e4@gmail.com"},"message":"Merge pull request #4317 from modocache/stdlib-warnings-arglabels\n\n[stdlib] Fix extraneous parameters","distinct":true,"url":"https://api.github.com/repos/bob-wilson/swift/commits/9d266d78053b94192ebf403251a64b086b64beec"},{"sha":"fc001e9a85ae20bc5781966af55d341b6199f1f9","author":{"name":"Dmitri Gribenko","email":"1d361ada365e4964f49a61228b2eb80f416328e4@gmail.com"},"message":"Merge pull request #4316 from practicalswift/swiftc-28396-swift-lowering-silgenfunction-emitclosurevalue\n\n[swiftc (49 vs. 5156)] Add crasher in swift::SILModule::constructSIL(...)","distinct":true,"url":"https://api.github.com/repos/bob-wilson/swift/commits/fc001e9a85ae20bc5781966af55d341b6199f1f9"},{"sha":"740721ab2f147147f9532372b17decce21de9b7a","author":{"name":"Robert Widmann","email":"8d9dbc76a6f28af262d9ada6aa64c8464e94ce54@gmail.com"},"message":"Address Dmitri's comments on #3600","distinct":true,"url":"https://api.github.com/repos/bob-wilson/swift/commits/740721ab2f147147f9532372b17decce21de9b7a"},{"sha":"3814b7a23db9f2331aba52eb0e5c1685a575075f","author":{"name":"Robert Widmann","email":"8d9dbc76a6f28af262d9ada6aa64c8464e94ce54@gmail.com"},"message":"Update the changelog","distinct":true,"url":"https://api.github.com/repos/bob-wilson/swift/commits/3814b7a23db9f2331aba52eb0e5c1685a575075f"}]}
{"actor":{"display_login":"bob-wilson"}}