{"action":"created","issue":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4010","repository_url":"https://api.github.com/repos/dolphin-emu/dolphin","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4010/labels{/name}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4010/comments","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4010/events","html_url":"https://github.com/dolphin-emu/dolphin/pull/4010","id":165645988,"number":4010,"title":"Add relative input for the Wiimote IR","user":{"login":"leoetlino","id":4209061,"avatar_url":"https://avatars.githubusercontent.com/u/4209061?v=3","gravatar_id":"","url":"https://api.github.com/users/leoetlino","html_url":"https://github.com/leoetlino","followers_url":"https://api.github.com/users/leoetlino/followers","following_url":"https://api.github.com/users/leoetlino/following{/other_user}","gists_url":"https://api.github.com/users/leoetlino/gists{/gist_id}","starred_url":"https://api.github.com/users/leoetlino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoetlino/subscriptions","organizations_url":"https://api.github.com/users/leoetlino/orgs","repos_url":"https://api.github.com/users/leoetlino/repos","events_url":"https://api.github.com/users/leoetlino/events{/privacy}","received_events_url":"https://api.github.com/users/leoetlino/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-14T20:01:13Z","updated_at":"2016-07-14T20:33:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4010","html_url":"https://github.com/dolphin-emu/dolphin/pull/4010","diff_url":"https://github.com/dolphin-emu/dolphin/pull/4010.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/4010.patch"},"body":"This adds an option to enable relative input for the Wiimote IR as described in [issue 9014](https://bugs.dolphin-emu.org/issues/9014).\r\n\r\nEnabling it will result in the pointer not going back to the centre and the inputs will control the direction, not the absolute position.\r\n\r\nAlso adds a Dead Zone setting which is really needed when relative input is enabled to prevent the cursor from slowly drifting on most controllers. (Note: the Deadzone setting has no effect when relative input is disabled, so the field is disabled when relative input is disabled)\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/dolphin-emu/dolphin/4010)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/232783862","html_url":"https://github.com/dolphin-emu/dolphin/pull/4010#issuecomment-232783862","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4010","id":232783862,"user":{"login":"lioncash","id":712067,"avatar_url":"https://avatars.githubusercontent.com/u/712067?v=3","gravatar_id":"","url":"https://api.github.com/users/lioncash","html_url":"https://github.com/lioncash","followers_url":"https://api.github.com/users/lioncash/followers","following_url":"https://api.github.com/users/lioncash/following{/other_user}","gists_url":"https://api.github.com/users/lioncash/gists{/gist_id}","starred_url":"https://api.github.com/users/lioncash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lioncash/subscriptions","organizations_url":"https://api.github.com/users/lioncash/orgs","repos_url":"https://api.github.com/users/lioncash/repos","events_url":"https://api.github.com/users/lioncash/events{/privacy}","received_events_url":"https://api.github.com/users/lioncash/received_events","type":"User","site_admin":false},"created_at":"2016-07-14T20:33:26Z","updated_at":"2016-07-14T20:33:26Z","body":"\n\n\n\nReview status: 0 of 4 files reviewed at latest revision, 3 unresolved discussions.\n\n---\n\n*[Source/Core/DolphinWX/InputConfigDiag.cpp, line 114 \\[r1\\]](https://reviewable.io:443/reviews/dolphin-emu/dolphin/4010#-KMf5IPhSenzPcoRRUC_:-KMf5IPipxkNBdMqLQPD:-771405745) ([raw file](https://github.com/dolphin-emu/dolphin/blob/fc29b02378b41330a1cb23f0e26ec84eb85b5130/Source/Core/DolphinWX/InputConfigDiag.cpp#L114)):*\n> ```cpp\n>   ((wxCheckBox*)wxcontrol)->SetValue(setting->GetValue());\n>   // Force WX to trigger an event after updating the value\n>   auto* const event = new wxCommandEvent(wxEVT_CHECKBOX);\n> ```\n\nThis doesn't need to be allocated with new, you can just declare it as a value type variable.\n\nWhat is this trying to accomplish, by the way?\n\n---\n\n*[Source/Core/InputCommon/ControllerEmu.h, line 378 \\[r1\\]](https://reviewable.io:443/reviews/dolphin-emu/dolphin/4010#-KMf-V_joH4W9EMSlvyH:-KMf-V_kjUyDBWMKfM5v:1681387078) ([raw file](https://github.com/dolphin-emu/dolphin/blob/fc29b02378b41330a1cb23f0e26ec84eb85b5130/Source/Core/InputCommon/ControllerEmu.h#L378)):*\n> ```objc\n>     // This is used to reduce the cursor speed for relative input\n>     // to something that makes sense with the default range.\n>     static constexpr double SPEED_MULTIPLIER = 0.02;\n> ```\n\nThis probably shouldn't be publicly exposed, since it's only used within this class.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/dolphin-emu/dolphin/4010)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"lioncash"}}