{"action":"created","issue":{"url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL/issues/2636","repository_url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL","labels_url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL/issues/2636/labels{/name}","comments_url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL/issues/2636/comments","events_url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL/issues/2636/events","html_url":"https://github.com/LoneGazebo/Community-Patch-DLL/issues/2636","id":182852589,"number":2636,"title":"Sort of Cool...","user":{"login":"Iamblichos","id":14372214,"avatar_url":"https://avatars.githubusercontent.com/u/14372214?v=3","gravatar_id":"","url":"https://api.github.com/users/Iamblichos","html_url":"https://github.com/Iamblichos","followers_url":"https://api.github.com/users/Iamblichos/followers","following_url":"https://api.github.com/users/Iamblichos/following{/other_user}","gists_url":"https://api.github.com/users/Iamblichos/gists{/gist_id}","starred_url":"https://api.github.com/users/Iamblichos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iamblichos/subscriptions","organizations_url":"https://api.github.com/users/Iamblichos/orgs","repos_url":"https://api.github.com/users/Iamblichos/repos","events_url":"https://api.github.com/users/Iamblichos/events{/privacy}","received_events_url":"https://api.github.com/users/Iamblichos/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-10-13T17:34:42Z","updated_at":"2016-10-14T07:45:08Z","closed_at":null,"body":"It has often struck me that UnitCombatTypes aren't a variable, and therefore not changeable in CvUnit.cpp on the fly (it has no variable). What if you had a Hero Unit (i.e. a Great General that was a Combat Unit) that started as a Mounted Unit and then became a Tank once it progressed to the appropriate era? So I made it a variable. Note the combat modifers for the barbarian units (my values are a little different from the CBP):\r\n\r\n![20161013122754_1](https://cloud.githubusercontent.com/assets/14372214/19359715/feec9c0e-9140-11e6-8f05-a3061095ffa2.jpg)\r\n\r\nthen I immediately advanced myself to the modern era which triggered the unit in the DLL to have new database read values, barbarian no longer has bonus vs. mounted:\r\n\r\n![20161013122907_1](https://cloud.githubusercontent.com/assets/14372214/19359740/1e06ee1e-9141-11e6-9ac3-7099abd664c2.jpg)\r\n\r\n...but anti-Tank applies:\r\n\r\n![20161013122914_1](https://cloud.githubusercontent.com/assets/14372214/19359753/2e4226d6-9141-11e6-8bb6-5d897b84946d.jpg)\r\n\r\nJust to show that the variable is setting the CombatClass correctly for regular units:\r\n\r\n![20161013122954_1](https://cloud.githubusercontent.com/assets/14372214/19359800/57cb1a80-9141-11e6-8f27-5017675b9cea.jpg)\r\n"},"comment":{"url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL/issues/comments/253731910","html_url":"https://github.com/LoneGazebo/Community-Patch-DLL/issues/2636#issuecomment-253731910","issue_url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL/issues/2636","id":253731910,"user":{"login":"matlajs","id":21192402,"avatar_url":"https://avatars.githubusercontent.com/u/21192402?v=3","gravatar_id":"","url":"https://api.github.com/users/matlajs","html_url":"https://github.com/matlajs","followers_url":"https://api.github.com/users/matlajs/followers","following_url":"https://api.github.com/users/matlajs/following{/other_user}","gists_url":"https://api.github.com/users/matlajs/gists{/gist_id}","starred_url":"https://api.github.com/users/matlajs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matlajs/subscriptions","organizations_url":"https://api.github.com/users/matlajs/orgs","repos_url":"https://api.github.com/users/matlajs/repos","events_url":"https://api.github.com/users/matlajs/events{/privacy}","received_events_url":"https://api.github.com/users/matlajs/received_events","type":"User","site_admin":false},"created_at":"2016-10-14T07:45:08Z","updated_at":"2016-10-14T07:45:08Z","body":"what are those general/admiral points right now? that is some kind of special yields? can those be changed for GG/GA to something maybe faith related for them being rather purchasable than born when you filled pool."}}
{"actor":{"display_login":"matlajs"}}