{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/54500466","id":54500466,"diff_hunk":"@@ -2671,6 +2665,9 @@ let\n       pushover\n     ];\n \n+    # Tests exist, but seem to clash with the firewall.\n+    doCheck = false;\n+\n     buildFlagsArray = ''\n       -ldflags=\n           -X main.buildVersion=${rev}","path":"pkgs/top-level/go-packages.nix","position":32,"original_position":32,"commit_id":"02147fd15ba6785acb047aa57afa6e05f764b1fd","original_commit_id":"02147fd15ba6785acb047aa57afa6e05f764b1fd","user":{"login":"benley","id":1432730,"avatar_url":"https://avatars.githubusercontent.com/u/1432730?v=3","gravatar_id":"","url":"https://api.github.com/users/benley","html_url":"https://github.com/benley","followers_url":"https://api.github.com/users/benley/followers","following_url":"https://api.github.com/users/benley/following{/other_user}","gists_url":"https://api.github.com/users/benley/gists{/gist_id}","starred_url":"https://api.github.com/users/benley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benley/subscriptions","organizations_url":"https://api.github.com/users/benley/orgs","repos_url":"https://api.github.com/users/benley/repos","events_url":"https://api.github.com/users/benley/events{/privacy}","received_events_url":"https://api.github.com/users/benley/received_events","type":"User","site_admin":false},"body":"It looks like the metadata ldflags used in the alertmanager build have changed in the rewrite: https://github.com/prometheus/alertmanager/blob/master/scripts/build.sh#L31\r\n\r\nThose are just used on the status page I believe, but it's nice to have some useful data in there.","created_at":"2016-02-29T23:48:42Z","updated_at":"2016-02-29T23:48:42Z","html_url":"https://github.com/NixOS/nixpkgs/pull/13578#discussion_r54500466","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13578","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/54500466"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/13578#discussion_r54500466"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13578"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13578","id":61122543,"html_url":"https://github.com/NixOS/nixpkgs/pull/13578","diff_url":"https://github.com/NixOS/nixpkgs/pull/13578.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/13578.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/13578","number":13578,"state":"open","locked":false,"title":"Prometheus: Misc updates","user":{"login":"Baughn","id":45811,"avatar_url":"https://avatars.githubusercontent.com/u/45811?v=3","gravatar_id":"","url":"https://api.github.com/users/Baughn","html_url":"https://github.com/Baughn","followers_url":"https://api.github.com/users/Baughn/followers","following_url":"https://api.github.com/users/Baughn/following{/other_user}","gists_url":"https://api.github.com/users/Baughn/gists{/gist_id}","starred_url":"https://api.github.com/users/Baughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baughn/subscriptions","organizations_url":"https://api.github.com/users/Baughn/orgs","repos_url":"https://api.github.com/users/Baughn/repos","events_url":"https://api.github.com/users/Baughn/events{/privacy}","received_events_url":"https://api.github.com/users/Baughn/received_events","type":"User","site_admin":false},"body":"###### Things done:\r\n\r\n- [X] Tested using sandboxing (`nix-build --option build-use-chroot true` or [nix.useChroot](http://nixos.org/nixos/manual/options.html#opt-nix.useChroot) on NixOS)\r\n- [X] Built on platform(s): NixOS\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [X] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n###### More\r\n\r\ncc @benley \r\n\r\nThis bumps Prometheus past the recent API change to Alertmanager. 0.17.0 is still a release candidate, but it's been solid in my experience, and the changes are relevant to my plans for integrating it with NixOS. (I don't want to write alertmanager integration twice.)","created_at":"2016-02-29T18:33:55Z","updated_at":"2016-02-29T23:48:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f99bc793c671712079b52ebad9dbf2132b3f9c7","assignee":{"login":"benley","id":1432730,"avatar_url":"https://avatars.githubusercontent.com/u/1432730?v=3","gravatar_id":"","url":"https://api.github.com/users/benley","html_url":"https://github.com/benley","followers_url":"https://api.github.com/users/benley/followers","following_url":"https://api.github.com/users/benley/following{/other_user}","gists_url":"https://api.github.com/users/benley/gists{/gist_id}","starred_url":"https://api.github.com/users/benley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benley/subscriptions","organizations_url":"https://api.github.com/users/benley/orgs","repos_url":"https://api.github.com/users/benley/repos","events_url":"https://api.github.com/users/benley/events{/privacy}","received_events_url":"https://api.github.com/users/benley/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13578/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13578/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/13578/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/02147fd15ba6785acb047aa57afa6e05f764b1fd","head":{"label":"Baughn:prometheus","ref":"prometheus","sha":"02147fd15ba6785acb047aa57afa6e05f764b1fd","user":{"login":"Baughn","id":45811,"avatar_url":"https://avatars.githubusercontent.com/u/45811?v=3","gravatar_id":"","url":"https://api.github.com/users/Baughn","html_url":"https://github.com/Baughn","followers_url":"https://api.github.com/users/Baughn/followers","following_url":"https://api.github.com/users/Baughn/following{/other_user}","gists_url":"https://api.github.com/users/Baughn/gists{/gist_id}","starred_url":"https://api.github.com/users/Baughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baughn/subscriptions","organizations_url":"https://api.github.com/users/Baughn/orgs","repos_url":"https://api.github.com/users/Baughn/repos","events_url":"https://api.github.com/users/Baughn/events{/privacy}","received_events_url":"https://api.github.com/users/Baughn/received_events","type":"User","site_admin":false},"repo":{"id":31373544,"name":"nixpkgs","full_name":"Baughn/nixpkgs","owner":{"login":"Baughn","id":45811,"avatar_url":"https://avatars.githubusercontent.com/u/45811?v=3","gravatar_id":"","url":"https://api.github.com/users/Baughn","html_url":"https://github.com/Baughn","followers_url":"https://api.github.com/users/Baughn/followers","following_url":"https://api.github.com/users/Baughn/following{/other_user}","gists_url":"https://api.github.com/users/Baughn/gists{/gist_id}","starred_url":"https://api.github.com/users/Baughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baughn/subscriptions","organizations_url":"https://api.github.com/users/Baughn/orgs","repos_url":"https://api.github.com/users/Baughn/repos","events_url":"https://api.github.com/users/Baughn/events{/privacy}","received_events_url":"https://api.github.com/users/Baughn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Baughn/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/Baughn/nixpkgs","forks_url":"https://api.github.com/repos/Baughn/nixpkgs/forks","keys_url":"https://api.github.com/repos/Baughn/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Baughn/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Baughn/nixpkgs/teams","hooks_url":"https://api.github.com/repos/Baughn/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/Baughn/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/Baughn/nixpkgs/events","assignees_url":"https://api.github.com/repos/Baughn/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/Baughn/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/Baughn/nixpkgs/tags","blobs_url":"https://api.github.com/repos/Baughn/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Baughn/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Baughn/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Baughn/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Baughn/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/Baughn/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/Baughn/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/Baughn/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/Baughn/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/Baughn/nixpkgs/subscription","commits_url":"https://api.github.com/repos/Baughn/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Baughn/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Baughn/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Baughn/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Baughn/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/Baughn/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Baughn/nixpkgs/merges","archive_url":"https://api.github.com/repos/Baughn/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Baughn/nixpkgs/downloads","issues_url":"https://api.github.com/repos/Baughn/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/Baughn/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/Baughn/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/Baughn/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Baughn/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/Baughn/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/Baughn/nixpkgs/deployments","created_at":"2015-02-26T15:26:34Z","updated_at":"2016-01-14T13:57:31Z","pushed_at":"2016-02-29T18:29:59Z","git_url":"git://github.com/Baughn/nixpkgs.git","ssh_url":"git@github.com:Baughn/nixpkgs.git","clone_url":"https://github.com/Baughn/nixpkgs.git","svn_url":"https://github.com/Baughn/nixpkgs","homepage":null,"size":314614,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"9af50a2e7d735b4a024cb91e2bf720341675031f","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2016-02-29T19:17:15Z","pushed_at":"2016-02-29T23:39:54Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":354113,"stargazers_count":966,"watchers_count":966,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1292,"mirror_url":null,"open_issues_count":1348,"forks":1292,"open_issues":1348,"watchers":966,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13578"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/13578"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/13578"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/13578/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13578/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13578/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/02147fd15ba6785acb047aa57afa6e05f764b1fd"}}}}