{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/engine/pulls/comments/84984472","pull_request_review_id":5727811,"id":84984472,"diff_hunk":"@@ -127,18 +131,80 @@ void Engine::OnViewportMetricsChanged(sky::ViewportMetricsPtr metrics) {\n     runtime_->SetViewportMetrics(viewport_metrics_);\n }\n \n-void Engine::OnLocaleChanged(const mojo::String& language_code,\n-                             const mojo::String& country_code) {\n-  language_code_ = language_code;\n-  country_code_ = country_code;\n-  if (runtime_)\n-    runtime_->SetLocale(language_code_, country_code_);\n+void Engine::DispatchPlatformMessage(\n+    ftl::RefPtr<blink::PlatformMessage> message) {\n+  if (message->channel() == kLifecycleChannel) {\n+    if (HandleLifecyclePlatformMessage(message.get()))\n+      return;\n+  } else if (message->channel() == kLocalizationChannel) {\n+    if (HandleNavigationPlatformMessage(std::move(message)))","path":"shell/common/engine.cc","position":35,"original_position":35,"commit_id":"ea3112dbb7a4372f248c434949df93d90c346719","original_commit_id":"ea3112dbb7a4372f248c434949df93d90c346719","user":{"login":"Hixie","id":551196,"avatar_url":"https://avatars.githubusercontent.com/u/551196?v=3","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"body":"I assume you meant to call HandleLocalizationPlatformMessage","created_at":"2016-10-25T19:42:47Z","updated_at":"2016-10-25T19:42:47Z","html_url":"https://github.com/flutter/engine/pull/3172#discussion_r84984472","pull_request_url":"https://api.github.com/repos/flutter/engine/pulls/3172","_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments/84984472"},"html":{"href":"https://github.com/flutter/engine/pull/3172#discussion_r84984472"},"pull_request":{"href":"https://api.github.com/repos/flutter/engine/pulls/3172"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/engine/pulls/3172","id":90875592,"html_url":"https://github.com/flutter/engine/pull/3172","diff_url":"https://github.com/flutter/engine/pull/3172.diff","patch_url":"https://github.com/flutter/engine/pull/3172.patch","issue_url":"https://api.github.com/repos/flutter/engine/issues/3172","number":3172,"state":"open","locked":false,"title":"Move lifecycle, navigation, and localization to platform messages","user":{"login":"abarth","id":112007,"avatar_url":"https://avatars.githubusercontent.com/u/112007?v=3","gravatar_id":"","url":"https://api.github.com/users/abarth","html_url":"https://github.com/abarth","followers_url":"https://api.github.com/users/abarth/followers","following_url":"https://api.github.com/users/abarth/following{/other_user}","gists_url":"https://api.github.com/users/abarth/gists{/gist_id}","starred_url":"https://api.github.com/users/abarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abarth/subscriptions","organizations_url":"https://api.github.com/users/abarth/orgs","repos_url":"https://api.github.com/users/abarth/repos","events_url":"https://api.github.com/users/abarth/events{/privacy}","received_events_url":"https://api.github.com/users/abarth/received_events","type":"User","site_admin":false},"body":"Previously, these signals were sent over Mojo. Now we send them through\nplatform messages.","created_at":"2016-10-25T19:31:14Z","updated_at":"2016-10-25T19:42:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bca379a0626a1e593417853f3335cde28c1e9dc9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/engine/pulls/3172/commits","review_comments_url":"https://api.github.com/repos/flutter/engine/pulls/3172/comments","review_comment_url":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/engine/issues/3172/comments","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/ea3112dbb7a4372f248c434949df93d90c346719","head":{"label":"abarth:rm_moar","ref":"rm_moar","sha":"ea3112dbb7a4372f248c434949df93d90c346719","user":{"login":"abarth","id":112007,"avatar_url":"https://avatars.githubusercontent.com/u/112007?v=3","gravatar_id":"","url":"https://api.github.com/users/abarth","html_url":"https://github.com/abarth","followers_url":"https://api.github.com/users/abarth/followers","following_url":"https://api.github.com/users/abarth/following{/other_user}","gists_url":"https://api.github.com/users/abarth/gists{/gist_id}","starred_url":"https://api.github.com/users/abarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abarth/subscriptions","organizations_url":"https://api.github.com/users/abarth/orgs","repos_url":"https://api.github.com/users/abarth/repos","events_url":"https://api.github.com/users/abarth/events{/privacy}","received_events_url":"https://api.github.com/users/abarth/received_events","type":"User","site_admin":false},"repo":{"id":39215675,"name":"engine","full_name":"abarth/engine","owner":{"login":"abarth","id":112007,"avatar_url":"https://avatars.githubusercontent.com/u/112007?v=3","gravatar_id":"","url":"https://api.github.com/users/abarth","html_url":"https://github.com/abarth","followers_url":"https://api.github.com/users/abarth/followers","following_url":"https://api.github.com/users/abarth/following{/other_user}","gists_url":"https://api.github.com/users/abarth/gists{/gist_id}","starred_url":"https://api.github.com/users/abarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abarth/subscriptions","organizations_url":"https://api.github.com/users/abarth/orgs","repos_url":"https://api.github.com/users/abarth/repos","events_url":"https://api.github.com/users/abarth/events{/privacy}","received_events_url":"https://api.github.com/users/abarth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abarth/engine","description":"The Flutter engine","fork":true,"url":"https://api.github.com/repos/abarth/engine","forks_url":"https://api.github.com/repos/abarth/engine/forks","keys_url":"https://api.github.com/repos/abarth/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abarth/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abarth/engine/teams","hooks_url":"https://api.github.com/repos/abarth/engine/hooks","issue_events_url":"https://api.github.com/repos/abarth/engine/issues/events{/number}","events_url":"https://api.github.com/repos/abarth/engine/events","assignees_url":"https://api.github.com/repos/abarth/engine/assignees{/user}","branches_url":"https://api.github.com/repos/abarth/engine/branches{/branch}","tags_url":"https://api.github.com/repos/abarth/engine/tags","blobs_url":"https://api.github.com/repos/abarth/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abarth/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abarth/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/abarth/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abarth/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/abarth/engine/languages","stargazers_url":"https://api.github.com/repos/abarth/engine/stargazers","contributors_url":"https://api.github.com/repos/abarth/engine/contributors","subscribers_url":"https://api.github.com/repos/abarth/engine/subscribers","subscription_url":"https://api.github.com/repos/abarth/engine/subscription","commits_url":"https://api.github.com/repos/abarth/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/abarth/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/abarth/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/abarth/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/abarth/engine/contents/{+path}","compare_url":"https://api.github.com/repos/abarth/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abarth/engine/merges","archive_url":"https://api.github.com/repos/abarth/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abarth/engine/downloads","issues_url":"https://api.github.com/repos/abarth/engine/issues{/number}","pulls_url":"https://api.github.com/repos/abarth/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/abarth/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/abarth/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abarth/engine/labels{/name}","releases_url":"https://api.github.com/repos/abarth/engine/releases{/id}","deployments_url":"https://api.github.com/repos/abarth/engine/deployments","created_at":"2015-07-16T19:18:24Z","updated_at":"2016-05-31T16:04:21Z","pushed_at":"2016-10-25T19:35:49Z","git_url":"git://github.com/abarth/engine.git","ssh_url":"git@github.com:abarth/engine.git","clone_url":"https://github.com/abarth/engine.git","svn_url":"https://github.com/abarth/engine","homepage":"http://flutter.io","size":86949,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"9f65114e2061aa2964cc0d2baec8046fc7361ef7","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":39211337,"name":"engine","full_name":"flutter/engine","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/engine","description":"The Flutter engine","fork":false,"url":"https://api.github.com/repos/flutter/engine","forks_url":"https://api.github.com/repos/flutter/engine/forks","keys_url":"https://api.github.com/repos/flutter/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/engine/teams","hooks_url":"https://api.github.com/repos/flutter/engine/hooks","issue_events_url":"https://api.github.com/repos/flutter/engine/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/engine/events","assignees_url":"https://api.github.com/repos/flutter/engine/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/engine/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/engine/tags","blobs_url":"https://api.github.com/repos/flutter/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/engine/languages","stargazers_url":"https://api.github.com/repos/flutter/engine/stargazers","contributors_url":"https://api.github.com/repos/flutter/engine/contributors","subscribers_url":"https://api.github.com/repos/flutter/engine/subscribers","subscription_url":"https://api.github.com/repos/flutter/engine/subscription","commits_url":"https://api.github.com/repos/flutter/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/engine/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/engine/merges","archive_url":"https://api.github.com/repos/flutter/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/engine/downloads","issues_url":"https://api.github.com/repos/flutter/engine/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/engine/labels{/name}","releases_url":"https://api.github.com/repos/flutter/engine/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/engine/deployments","created_at":"2015-07-16T17:39:56Z","updated_at":"2016-10-24T19:32:12Z","pushed_at":"2016-10-25T19:35:50Z","git_url":"git://github.com/flutter/engine.git","ssh_url":"git@github.com:flutter/engine.git","clone_url":"https://github.com/flutter/engine.git","svn_url":"https://github.com/flutter/engine","homepage":"http://flutter.io","size":107454,"stargazers_count":919,"watchers_count":919,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":159,"mirror_url":null,"open_issues_count":2,"forks":159,"open_issues":2,"watchers":919,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/3172"},"html":{"href":"https://github.com/flutter/engine/pull/3172"},"issue":{"href":"https://api.github.com/repos/flutter/engine/issues/3172"},"comments":{"href":"https://api.github.com/repos/flutter/engine/issues/3172/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/engine/pulls/3172/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/engine/pulls/3172/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/engine/statuses/ea3112dbb7a4372f248c434949df93d90c346719"}}}}
{"actor":{"display_login":"Hixie"}}