{"action":"created","issue":{"url":"https://api.github.com/repos/qtile/qtile/issues/969","repository_url":"https://api.github.com/repos/qtile/qtile","labels_url":"https://api.github.com/repos/qtile/qtile/issues/969/labels{/name}","comments_url":"https://api.github.com/repos/qtile/qtile/issues/969/comments","events_url":"https://api.github.com/repos/qtile/qtile/issues/969/events","html_url":"https://github.com/qtile/qtile/pull/969","id":184698121,"number":969,"title":"allow to use uvloop","user":{"login":"gawel","id":118673,"avatar_url":"https://avatars.githubusercontent.com/u/118673?v=3","gravatar_id":"","url":"https://api.github.com/users/gawel","html_url":"https://github.com/gawel","followers_url":"https://api.github.com/users/gawel/followers","following_url":"https://api.github.com/users/gawel/following{/other_user}","gists_url":"https://api.github.com/users/gawel/gists{/gist_id}","starred_url":"https://api.github.com/users/gawel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gawel/subscriptions","organizations_url":"https://api.github.com/users/gawel/orgs","repos_url":"https://api.github.com/users/gawel/repos","events_url":"https://api.github.com/users/gawel/events{/privacy}","received_events_url":"https://api.github.com/users/gawel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-10-23T15:59:52Z","updated_at":"2016-10-28T16:56:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/qtile/qtile/pulls/969","html_url":"https://github.com/qtile/qtile/pull/969","diff_url":"https://github.com/qtile/qtile/pull/969.diff","patch_url":"https://github.com/qtile/qtile/pull/969.patch"},"body":"Quick PR after testing that qtile works fine with uvloop which is faster than asyncio's default event loop"},"comment":{"url":"https://api.github.com/repos/qtile/qtile/issues/comments/256972474","html_url":"https://github.com/qtile/qtile/pull/969#issuecomment-256972474","issue_url":"https://api.github.com/repos/qtile/qtile/issues/969","id":256972474,"user":{"login":"gawel","id":118673,"avatar_url":"https://avatars.githubusercontent.com/u/118673?v=3","gravatar_id":"","url":"https://api.github.com/users/gawel","html_url":"https://github.com/gawel","followers_url":"https://api.github.com/users/gawel/followers","following_url":"https://api.github.com/users/gawel/following{/other_user}","gists_url":"https://api.github.com/users/gawel/gists{/gist_id}","starred_url":"https://api.github.com/users/gawel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gawel/subscriptions","organizations_url":"https://api.github.com/users/gawel/orgs","repos_url":"https://api.github.com/users/gawel/repos","events_url":"https://api.github.com/users/gawel/events{/privacy}","received_events_url":"https://api.github.com/users/gawel/received_events","type":"User","site_admin":false},"created_at":"2016-10-28T16:56:30Z","updated_at":"2016-10-28T16:56:30Z","body":"Found this: https://github.com/qtile/qtile/pull/489#issuecomment-54077028\r\n\r\nSeems that the only reason is that you think it will slow everything. I'm not sure about that. \r\nFor my irc client I've made some benches: https://github.com/gawel/irc3/blob/master/examples/benches.py\r\nGot 1 server and 1000 clients flooding the server all in the same event loop. Works fine.\r\nAlso I don't know how the GIL will affect performances when using more than one event loop in the same thread\r\n\r\nI'm currently using a single event loop in qtile without problems, for now. \r\n\r\nBut. As I can see, the client implementation is using loop.run_until_complete(). And more than one time. I thought that this was not possible since it stop the loop. \r\n\r\nBasically it run_forever:\r\nhttps://github.com/python/cpython/blob/a3ac6202ceeeb02b2cb1127d4f438e57e3db80c3/Lib/asyncio/base_events.py#L436\r\n\r\nAnd stop the loop:\r\nhttps://github.com/python/cpython/blob/a3ac6202ceeeb02b2cb1127d4f438e57e3db80c3/Lib/asyncio/base_events.py#L171\r\n\r\nSo... I don't get it."}}
{"actor":{"display_login":"gawel"}}