{"action":"created","comment":{"url":"https://api.github.com/repos/codice/ddf/pulls/comments/70716391","id":70716391,"diff_hunk":"@@ -102,6 +102,8 @@\n \n     public static final String CACHED = \"cached\";\n \n+    private static final String INTERNAL_LOCAL_RESOURCE = \"internal.local-resource\";","path":"catalog/ui/search-ui/search-endpoint/src/main/java/org/codice/ddf/ui/searchui/query/model/Search.java","position":4,"original_position":4,"commit_id":"1b0222bcc639f3fe75aa79104337c0e51ad6b5e0","original_commit_id":"1b0222bcc639f3fe75aa79104337c0e51ad6b5e0","user":{"login":"lessarderic","id":11377558,"avatar_url":"https://avatars.githubusercontent.com/u/11377558?v=3","gravatar_id":"","url":"https://api.github.com/users/lessarderic","html_url":"https://github.com/lessarderic","followers_url":"https://api.github.com/users/lessarderic/followers","following_url":"https://api.github.com/users/lessarderic/following{/other_user}","gists_url":"https://api.github.com/users/lessarderic/gists{/gist_id}","starred_url":"https://api.github.com/users/lessarderic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lessarderic/subscriptions","organizations_url":"https://api.github.com/users/lessarderic/orgs","repos_url":"https://api.github.com/users/lessarderic/repos","events_url":"https://api.github.com/users/lessarderic/events{/privacy}","received_events_url":"https://api.github.com/users/lessarderic/received_events","type":"User","site_admin":false},"body":"I'm confused. How can this endpoint know when to set the \"cached\" property in the response without looking up that specific attribute in the metacard?","created_at":"2016-07-13T21:56:28Z","updated_at":"2016-07-13T21:56:28Z","html_url":"https://github.com/codice/ddf/pull/1003#discussion_r70716391","pull_request_url":"https://api.github.com/repos/codice/ddf/pulls/1003","_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments/70716391"},"html":{"href":"https://github.com/codice/ddf/pull/1003#discussion_r70716391"},"pull_request":{"href":"https://api.github.com/repos/codice/ddf/pulls/1003"}}},"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/1003","id":77352156,"html_url":"https://github.com/codice/ddf/pull/1003","diff_url":"https://github.com/codice/ddf/pull/1003.diff","patch_url":"https://github.com/codice/ddf/pull/1003.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/1003","number":1003,"state":"open","locked":false,"title":"DDF-2293: Invalid caching status reported to user due to resource cac…","user":{"login":"figliold","id":4838043,"avatar_url":"https://avatars.githubusercontent.com/u/4838043?v=3","gravatar_id":"","url":"https://api.github.com/users/figliold","html_url":"https://github.com/figliold","followers_url":"https://api.github.com/users/figliold/followers","following_url":"https://api.github.com/users/figliold/following{/other_user}","gists_url":"https://api.github.com/users/figliold/gists{/gist_id}","starred_url":"https://api.github.com/users/figliold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/figliold/subscriptions","organizations_url":"https://api.github.com/users/figliold/orgs","repos_url":"https://api.github.com/users/figliold/repos","events_url":"https://api.github.com/users/figliold/events{/privacy}","received_events_url":"https://api.github.com/users/figliold/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nRemoves the `resource.cached` attribute from the `Metacard` interface. A new attribute `internal.local-resource` is added to each metacard in the `MetacardResourceStatus` `PostQueryPlugin` which reflects the cache status of resources associated with metacards.\r\n#### Who is reviewing it (please choose AT LEAST two reviewers that need to approve the PR before it can get merged; if a component team is listed, at least one of its members needs to approve)?\r\n@brendan-hofmann \r\n@oconnormi\r\n@lessarderic \r\n#### Choose 2 committers to review/merge the PR (please choose ONLY two committers from below, delete the rest).\r\n@coyotesqrl \r\n@pklinef \r\n#### How should this be tested?\r\nHero build. Manually testing will require two DDFs.\r\n1) Setup DDF1 with an opensearch federated source pointing to DDF2.\r\n2) Upload image2 to DDF2.\r\n3) Perform a query on DDF2 and download the resource (image2).  \r\n4) Capture the cometd query response on DDF2 and verify that the internal.local-resource attribute is set to true for the metacard associated with image2.\r\n5) Perform an enterprise query on DDF1.\r\n6) Capture the cometd query response on DDF1 and verify that the internal.local-resource attribute is set to false for the metacard associated with image2.\r\n#### Any background context you want to provide?\r\n#### What are the relevant tickets?\r\nDDF-2293\r\n#### Screenshots (if appropriate)\r\n#### Checklist:\r\n- [x] Documentation Updated\r\n- [ ] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\n…hing flag being set as a basic type metacard attribute","created_at":"2016-07-13T20:03:00Z","updated_at":"2016-07-13T21:56:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c6b162deb5ddb377efeed4b3d8e42b56eb3410e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/1003/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/1003/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/1003/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/1b0222bcc639f3fe75aa79104337c0e51ad6b5e0","head":{"label":"figliold:DDF-2293","ref":"DDF-2293","sha":"1b0222bcc639f3fe75aa79104337c0e51ad6b5e0","user":{"login":"figliold","id":4838043,"avatar_url":"https://avatars.githubusercontent.com/u/4838043?v=3","gravatar_id":"","url":"https://api.github.com/users/figliold","html_url":"https://github.com/figliold","followers_url":"https://api.github.com/users/figliold/followers","following_url":"https://api.github.com/users/figliold/following{/other_user}","gists_url":"https://api.github.com/users/figliold/gists{/gist_id}","starred_url":"https://api.github.com/users/figliold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/figliold/subscriptions","organizations_url":"https://api.github.com/users/figliold/orgs","repos_url":"https://api.github.com/users/figliold/repos","events_url":"https://api.github.com/users/figliold/events{/privacy}","received_events_url":"https://api.github.com/users/figliold/received_events","type":"User","site_admin":false},"repo":{"id":34751793,"name":"ddf","full_name":"figliold/ddf","owner":{"login":"figliold","id":4838043,"avatar_url":"https://avatars.githubusercontent.com/u/4838043?v=3","gravatar_id":"","url":"https://api.github.com/users/figliold","html_url":"https://github.com/figliold","followers_url":"https://api.github.com/users/figliold/followers","following_url":"https://api.github.com/users/figliold/following{/other_user}","gists_url":"https://api.github.com/users/figliold/gists{/gist_id}","starred_url":"https://api.github.com/users/figliold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/figliold/subscriptions","organizations_url":"https://api.github.com/users/figliold/orgs","repos_url":"https://api.github.com/users/figliold/repos","events_url":"https://api.github.com/users/figliold/events{/privacy}","received_events_url":"https://api.github.com/users/figliold/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/figliold/ddf","description":"The Distributed Data Framework - Distribution, SDK, and Test","fork":true,"url":"https://api.github.com/repos/figliold/ddf","forks_url":"https://api.github.com/repos/figliold/ddf/forks","keys_url":"https://api.github.com/repos/figliold/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/figliold/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/figliold/ddf/teams","hooks_url":"https://api.github.com/repos/figliold/ddf/hooks","issue_events_url":"https://api.github.com/repos/figliold/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/figliold/ddf/events","assignees_url":"https://api.github.com/repos/figliold/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/figliold/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/figliold/ddf/tags","blobs_url":"https://api.github.com/repos/figliold/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/figliold/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/figliold/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/figliold/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/figliold/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/figliold/ddf/languages","stargazers_url":"https://api.github.com/repos/figliold/ddf/stargazers","contributors_url":"https://api.github.com/repos/figliold/ddf/contributors","subscribers_url":"https://api.github.com/repos/figliold/ddf/subscribers","subscription_url":"https://api.github.com/repos/figliold/ddf/subscription","commits_url":"https://api.github.com/repos/figliold/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/figliold/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/figliold/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/figliold/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/figliold/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/figliold/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/figliold/ddf/merges","archive_url":"https://api.github.com/repos/figliold/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/figliold/ddf/downloads","issues_url":"https://api.github.com/repos/figliold/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/figliold/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/figliold/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/figliold/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/figliold/ddf/labels{/name}","releases_url":"https://api.github.com/repos/figliold/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/figliold/ddf/deployments","created_at":"2015-04-28T19:40:41Z","updated_at":"2015-04-28T19:40:42Z","pushed_at":"2016-07-13T19:41:27Z","git_url":"git://github.com/figliold/ddf.git","ssh_url":"git@github.com:figliold/ddf.git","clone_url":"https://github.com/figliold/ddf.git","svn_url":"https://github.com/figliold/ddf","homepage":"","size":145082,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"365885b15406c48de928a87ef125ce5817d0c2e3","user":{"login":"codice","id":2386734,"avatar_url":"https://avatars.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"name":"ddf","full_name":"codice/ddf","owner":{"login":"codice","id":2386734,"avatar_url":"https://avatars.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codice/ddf","description":"Distributed Data Framework - an open source, modular integration framework.","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf/deployments","created_at":"2013-12-13T20:38:28Z","updated_at":"2016-07-11T23:07:09Z","pushed_at":"2016-07-13T21:52:58Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"git@github.com:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"http://ddf.codice.org","size":279197,"stargazers_count":38,"watchers_count":38,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":81,"mirror_url":null,"open_issues_count":26,"forks":81,"open_issues":26,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/1003"},"html":{"href":"https://github.com/codice/ddf/pull/1003"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/1003"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/1003/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/1003/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/1003/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/1b0222bcc639f3fe75aa79104337c0e51ad6b5e0"}}}}
{"actor":{"display_login":"lessarderic"}}