{"action":"closed","number":1670,"pull_request":{"url":"https://api.github.com/repos/elixir-ecto/ecto/pulls/1670","id":84038165,"html_url":"https://github.com/elixir-ecto/ecto/pull/1670","diff_url":"https://github.com/elixir-ecto/ecto/pull/1670.diff","patch_url":"https://github.com/elixir-ecto/ecto/pull/1670.patch","issue_url":"https://api.github.com/repos/elixir-ecto/ecto/issues/1670","number":1670,"state":"closed","locked":false,"title":"Disable lexical tracker for association modules","user":{"login":"michalmuskala","id":477062,"avatar_url":"https://avatars.githubusercontent.com/u/477062?v=3","gravatar_id":"","url":"https://api.github.com/users/michalmuskala","html_url":"https://github.com/michalmuskala","followers_url":"https://api.github.com/users/michalmuskala/followers","following_url":"https://api.github.com/users/michalmuskala/following{/other_user}","gists_url":"https://api.github.com/users/michalmuskala/gists{/gist_id}","starred_url":"https://api.github.com/users/michalmuskala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalmuskala/subscriptions","organizations_url":"https://api.github.com/users/michalmuskala/orgs","repos_url":"https://api.github.com/users/michalmuskala/repos","events_url":"https://api.github.com/users/michalmuskala/events{/privacy}","received_events_url":"https://api.github.com/users/michalmuskala/received_events","type":"User","site_admin":false},"body":"This will prevent the compiler from creating a compile-time dependency\r\non the association module. It's safe to do, since in that place we\r\ndon't call any functions on the association module.\r\n\r\nThis solves an issue of excessive recompilation in Ecto projects with\r\nheavy use of the associations.\r\n\r\nCloses #1610\r\n\r\n---\r\n\r\nI verified on a sample project with `xref` that the dependency is indeed not created.\r\n\r\nThis is an alternative to https://github.com/elixir-ecto/ecto/pull/1637 that is significantly less intrusive and will allow older projects to benefit from it as well.\r\n\r\nhttps://github.com/elixir-ecto/ecto/pull/1668 conflicts with those changes, it doesn't matter which one is merged first.\r\n\r\n\\cc @josevalim ","created_at":"2016-09-05T20:41:12Z","updated_at":"2016-09-05T22:55:13Z","closed_at":"2016-09-05T22:55:13Z","merged_at":"2016-09-05T22:55:13Z","merge_commit_sha":"d7a54eeef70230fcfe5a3c6cf1de59e99943d241","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/elixir-ecto/ecto/pulls/1670/commits","review_comments_url":"https://api.github.com/repos/elixir-ecto/ecto/pulls/1670/comments","review_comment_url":"https://api.github.com/repos/elixir-ecto/ecto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elixir-ecto/ecto/issues/1670/comments","statuses_url":"https://api.github.com/repos/elixir-ecto/ecto/statuses/011779db47f451d17b5f1e9792759d4e5c835211","head":{"label":"elixir-ecto:mm/module-refs","ref":"mm/module-refs","sha":"011779db47f451d17b5f1e9792759d4e5c835211","user":{"login":"elixir-ecto","id":19973437,"avatar_url":"https://avatars.githubusercontent.com/u/19973437?v=3","gravatar_id":"","url":"https://api.github.com/users/elixir-ecto","html_url":"https://github.com/elixir-ecto","followers_url":"https://api.github.com/users/elixir-ecto/followers","following_url":"https://api.github.com/users/elixir-ecto/following{/other_user}","gists_url":"https://api.github.com/users/elixir-ecto/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-ecto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-ecto/subscriptions","organizations_url":"https://api.github.com/users/elixir-ecto/orgs","repos_url":"https://api.github.com/users/elixir-ecto/repos","events_url":"https://api.github.com/users/elixir-ecto/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-ecto/received_events","type":"Organization","site_admin":false},"repo":{"id":10649374,"name":"ecto","full_name":"elixir-ecto/ecto","owner":{"login":"elixir-ecto","id":19973437,"avatar_url":"https://avatars.githubusercontent.com/u/19973437?v=3","gravatar_id":"","url":"https://api.github.com/users/elixir-ecto","html_url":"https://github.com/elixir-ecto","followers_url":"https://api.github.com/users/elixir-ecto/followers","following_url":"https://api.github.com/users/elixir-ecto/following{/other_user}","gists_url":"https://api.github.com/users/elixir-ecto/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-ecto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-ecto/subscriptions","organizations_url":"https://api.github.com/users/elixir-ecto/orgs","repos_url":"https://api.github.com/users/elixir-ecto/repos","events_url":"https://api.github.com/users/elixir-ecto/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-ecto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elixir-ecto/ecto","description":"A database wrapper and language integrated query for Elixir","fork":false,"url":"https://api.github.com/repos/elixir-ecto/ecto","forks_url":"https://api.github.com/repos/elixir-ecto/ecto/forks","keys_url":"https://api.github.com/repos/elixir-ecto/ecto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elixir-ecto/ecto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elixir-ecto/ecto/teams","hooks_url":"https://api.github.com/repos/elixir-ecto/ecto/hooks","issue_events_url":"https://api.github.com/repos/elixir-ecto/ecto/issues/events{/number}","events_url":"https://api.github.com/repos/elixir-ecto/ecto/events","assignees_url":"https://api.github.com/repos/elixir-ecto/ecto/assignees{/user}","branches_url":"https://api.github.com/repos/elixir-ecto/ecto/branches{/branch}","tags_url":"https://api.github.com/repos/elixir-ecto/ecto/tags","blobs_url":"https://api.github.com/repos/elixir-ecto/ecto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elixir-ecto/ecto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elixir-ecto/ecto/git/refs{/sha}","trees_url":"https://api.github.com/repos/elixir-ecto/ecto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elixir-ecto/ecto/statuses/{sha}","languages_url":"https://api.github.com/repos/elixir-ecto/ecto/languages","stargazers_url":"https://api.github.com/repos/elixir-ecto/ecto/stargazers","contributors_url":"https://api.github.com/repos/elixir-ecto/ecto/contributors","subscribers_url":"https://api.github.com/repos/elixir-ecto/ecto/subscribers","subscription_url":"https://api.github.com/repos/elixir-ecto/ecto/subscription","commits_url":"https://api.github.com/repos/elixir-ecto/ecto/commits{/sha}","git_commits_url":"https://api.github.com/repos/elixir-ecto/ecto/git/commits{/sha}","comments_url":"https://api.github.com/repos/elixir-ecto/ecto/comments{/number}","issue_comment_url":"https://api.github.com/repos/elixir-ecto/ecto/issues/comments{/number}","contents_url":"https://api.github.com/repos/elixir-ecto/ecto/contents/{+path}","compare_url":"https://api.github.com/repos/elixir-ecto/ecto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elixir-ecto/ecto/merges","archive_url":"https://api.github.com/repos/elixir-ecto/ecto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elixir-ecto/ecto/downloads","issues_url":"https://api.github.com/repos/elixir-ecto/ecto/issues{/number}","pulls_url":"https://api.github.com/repos/elixir-ecto/ecto/pulls{/number}","milestones_url":"https://api.github.com/repos/elixir-ecto/ecto/milestones{/number}","notifications_url":"https://api.github.com/repos/elixir-ecto/ecto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elixir-ecto/ecto/labels{/name}","releases_url":"https://api.github.com/repos/elixir-ecto/ecto/releases{/id}","deployments_url":"https://api.github.com/repos/elixir-ecto/ecto/deployments","created_at":"2013-06-12T18:42:06Z","updated_at":"2016-09-05T18:54:23Z","pushed_at":"2016-09-05T22:55:13Z","git_url":"git://github.com/elixir-ecto/ecto.git","ssh_url":"git@github.com:elixir-ecto/ecto.git","clone_url":"https://github.com/elixir-ecto/ecto.git","svn_url":"https://github.com/elixir-ecto/ecto","homepage":"https://hexdocs.pm/ecto","size":9155,"stargazers_count":2084,"watchers_count":2084,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":482,"mirror_url":null,"open_issues_count":29,"forks":482,"open_issues":29,"watchers":2084,"default_branch":"master"}},"base":{"label":"elixir-ecto:master","ref":"master","sha":"042aa92c62883572917477b2acaad3297590775c","user":{"login":"elixir-ecto","id":19973437,"avatar_url":"https://avatars.githubusercontent.com/u/19973437?v=3","gravatar_id":"","url":"https://api.github.com/users/elixir-ecto","html_url":"https://github.com/elixir-ecto","followers_url":"https://api.github.com/users/elixir-ecto/followers","following_url":"https://api.github.com/users/elixir-ecto/following{/other_user}","gists_url":"https://api.github.com/users/elixir-ecto/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-ecto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-ecto/subscriptions","organizations_url":"https://api.github.com/users/elixir-ecto/orgs","repos_url":"https://api.github.com/users/elixir-ecto/repos","events_url":"https://api.github.com/users/elixir-ecto/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-ecto/received_events","type":"Organization","site_admin":false},"repo":{"id":10649374,"name":"ecto","full_name":"elixir-ecto/ecto","owner":{"login":"elixir-ecto","id":19973437,"avatar_url":"https://avatars.githubusercontent.com/u/19973437?v=3","gravatar_id":"","url":"https://api.github.com/users/elixir-ecto","html_url":"https://github.com/elixir-ecto","followers_url":"https://api.github.com/users/elixir-ecto/followers","following_url":"https://api.github.com/users/elixir-ecto/following{/other_user}","gists_url":"https://api.github.com/users/elixir-ecto/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-ecto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-ecto/subscriptions","organizations_url":"https://api.github.com/users/elixir-ecto/orgs","repos_url":"https://api.github.com/users/elixir-ecto/repos","events_url":"https://api.github.com/users/elixir-ecto/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-ecto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elixir-ecto/ecto","description":"A database wrapper and language integrated query for Elixir","fork":false,"url":"https://api.github.com/repos/elixir-ecto/ecto","forks_url":"https://api.github.com/repos/elixir-ecto/ecto/forks","keys_url":"https://api.github.com/repos/elixir-ecto/ecto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elixir-ecto/ecto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elixir-ecto/ecto/teams","hooks_url":"https://api.github.com/repos/elixir-ecto/ecto/hooks","issue_events_url":"https://api.github.com/repos/elixir-ecto/ecto/issues/events{/number}","events_url":"https://api.github.com/repos/elixir-ecto/ecto/events","assignees_url":"https://api.github.com/repos/elixir-ecto/ecto/assignees{/user}","branches_url":"https://api.github.com/repos/elixir-ecto/ecto/branches{/branch}","tags_url":"https://api.github.com/repos/elixir-ecto/ecto/tags","blobs_url":"https://api.github.com/repos/elixir-ecto/ecto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elixir-ecto/ecto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elixir-ecto/ecto/git/refs{/sha}","trees_url":"https://api.github.com/repos/elixir-ecto/ecto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elixir-ecto/ecto/statuses/{sha}","languages_url":"https://api.github.com/repos/elixir-ecto/ecto/languages","stargazers_url":"https://api.github.com/repos/elixir-ecto/ecto/stargazers","contributors_url":"https://api.github.com/repos/elixir-ecto/ecto/contributors","subscribers_url":"https://api.github.com/repos/elixir-ecto/ecto/subscribers","subscription_url":"https://api.github.com/repos/elixir-ecto/ecto/subscription","commits_url":"https://api.github.com/repos/elixir-ecto/ecto/commits{/sha}","git_commits_url":"https://api.github.com/repos/elixir-ecto/ecto/git/commits{/sha}","comments_url":"https://api.github.com/repos/elixir-ecto/ecto/comments{/number}","issue_comment_url":"https://api.github.com/repos/elixir-ecto/ecto/issues/comments{/number}","contents_url":"https://api.github.com/repos/elixir-ecto/ecto/contents/{+path}","compare_url":"https://api.github.com/repos/elixir-ecto/ecto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elixir-ecto/ecto/merges","archive_url":"https://api.github.com/repos/elixir-ecto/ecto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elixir-ecto/ecto/downloads","issues_url":"https://api.github.com/repos/elixir-ecto/ecto/issues{/number}","pulls_url":"https://api.github.com/repos/elixir-ecto/ecto/pulls{/number}","milestones_url":"https://api.github.com/repos/elixir-ecto/ecto/milestones{/number}","notifications_url":"https://api.github.com/repos/elixir-ecto/ecto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elixir-ecto/ecto/labels{/name}","releases_url":"https://api.github.com/repos/elixir-ecto/ecto/releases{/id}","deployments_url":"https://api.github.com/repos/elixir-ecto/ecto/deployments","created_at":"2013-06-12T18:42:06Z","updated_at":"2016-09-05T18:54:23Z","pushed_at":"2016-09-05T22:55:13Z","git_url":"git://github.com/elixir-ecto/ecto.git","ssh_url":"git@github.com:elixir-ecto/ecto.git","clone_url":"https://github.com/elixir-ecto/ecto.git","svn_url":"https://github.com/elixir-ecto/ecto","homepage":"https://hexdocs.pm/ecto","size":9155,"stargazers_count":2084,"watchers_count":2084,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":482,"mirror_url":null,"open_issues_count":29,"forks":482,"open_issues":29,"watchers":2084,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elixir-ecto/ecto/pulls/1670"},"html":{"href":"https://github.com/elixir-ecto/ecto/pull/1670"},"issue":{"href":"https://api.github.com/repos/elixir-ecto/ecto/issues/1670"},"comments":{"href":"https://api.github.com/repos/elixir-ecto/ecto/issues/1670/comments"},"review_comments":{"href":"https://api.github.com/repos/elixir-ecto/ecto/pulls/1670/comments"},"review_comment":{"href":"https://api.github.com/repos/elixir-ecto/ecto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elixir-ecto/ecto/pulls/1670/commits"},"statuses":{"href":"https://api.github.com/repos/elixir-ecto/ecto/statuses/011779db47f451d17b5f1e9792759d4e5c835211"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"josevalim","id":9582,"avatar_url":"https://avatars.githubusercontent.com/u/9582?v=3","gravatar_id":"","url":"https://api.github.com/users/josevalim","html_url":"https://github.com/josevalim","followers_url":"https://api.github.com/users/josevalim/followers","following_url":"https://api.github.com/users/josevalim/following{/other_user}","gists_url":"https://api.github.com/users/josevalim/gists{/gist_id}","starred_url":"https://api.github.com/users/josevalim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josevalim/subscriptions","organizations_url":"https://api.github.com/users/josevalim/orgs","repos_url":"https://api.github.com/users/josevalim/repos","events_url":"https://api.github.com/users/josevalim/events{/privacy}","received_events_url":"https://api.github.com/users/josevalim/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"commits":1,"additions":10,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"josevalim"}}