{"action":"created","issue":{"url":"https://api.github.com/repos/ember-cli/loader.js/issues/79","repository_url":"https://api.github.com/repos/ember-cli/loader.js","labels_url":"https://api.github.com/repos/ember-cli/loader.js/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/ember-cli/loader.js/issues/79/comments","events_url":"https://api.github.com/repos/ember-cli/loader.js/issues/79/events","html_url":"https://github.com/ember-cli/loader.js/pull/79","id":153518483,"number":79,"title":"Do not reify dependencies everytime the same module is looked up","user":{"login":"kratiahuja","id":4064295,"avatar_url":"https://avatars.githubusercontent.com/u/4064295?v=3","gravatar_id":"","url":"https://api.github.com/users/kratiahuja","html_url":"https://github.com/kratiahuja","followers_url":"https://api.github.com/users/kratiahuja/followers","following_url":"https://api.github.com/users/kratiahuja/following{/other_user}","gists_url":"https://api.github.com/users/kratiahuja/gists{/gist_id}","starred_url":"https://api.github.com/users/kratiahuja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kratiahuja/subscriptions","organizations_url":"https://api.github.com/users/kratiahuja/orgs","repos_url":"https://api.github.com/users/kratiahuja/repos","events_url":"https://api.github.com/users/kratiahuja/events{/privacy}","received_events_url":"https://api.github.com/users/kratiahuja/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-05-06T19:09:21Z","updated_at":"2016-05-07T06:06:28Z","closed_at":"2016-05-07T05:07:55Z","pull_request":{"url":"https://api.github.com/repos/ember-cli/loader.js/pulls/79","html_url":"https://github.com/ember-cli/loader.js/pull/79","diff_url":"https://github.com/ember-cli/loader.js/pull/79.diff","patch_url":"https://github.com/ember-cli/loader.js/pull/79.patch"},"body":"We ideally only need to reify the dependencies of a module once for the first time it is looked up. Thereafter, we can reuse the store reified values. This PR fixes that. Earlier it was reifiying the dependencies of a module and evaluating the sub tree irrespective of if the dependencies were already resolved.\r\n\r\ncc: @chadhietala "},"comment":{"url":"https://api.github.com/repos/ember-cli/loader.js/issues/comments/217610369","html_url":"https://github.com/ember-cli/loader.js/pull/79#issuecomment-217610369","issue_url":"https://api.github.com/repos/ember-cli/loader.js/issues/79","id":217610369,"user":{"login":"stefanpenner","id":1377,"avatar_url":"https://avatars.githubusercontent.com/u/1377?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanpenner","html_url":"https://github.com/stefanpenner","followers_url":"https://api.github.com/users/stefanpenner/followers","following_url":"https://api.github.com/users/stefanpenner/following{/other_user}","gists_url":"https://api.github.com/users/stefanpenner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanpenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanpenner/subscriptions","organizations_url":"https://api.github.com/users/stefanpenner/orgs","repos_url":"https://api.github.com/users/stefanpenner/repos","events_url":"https://api.github.com/users/stefanpenner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanpenner/received_events","type":"User","site_admin":false},"created_at":"2016-05-07T06:06:28Z","updated_at":"2016-05-07T06:06:28Z","body":"I may have missed a scenario, if this commit covers such a case we should add it. I'll try to look closely tomorrow, but if you can provide an example that this fixes but the other does not please share."}}