{"action":"created","comment":{"url":"https://api.github.com/repos/niksu/pax/pulls/comments/70703596","id":70703596,"diff_hunk":"@@ -0,0 +1,231 @@\n+#!/usr/bin/python\n+# coding: latin-1\n+","path":"examples/nat_scapy_tests.py","position":3,"original_position":3,"commit_id":"1d5f6ad6216a5e631915ee6bbbda119454cf2705","original_commit_id":"7f29135a9261e8b25f7b9c3ec6cc9f4b3b0add3a","user":{"login":"niksu","id":1102670,"avatar_url":"https://avatars.githubusercontent.com/u/1102670?v=3","gravatar_id":"","url":"https://api.github.com/users/niksu","html_url":"https://github.com/niksu","followers_url":"https://api.github.com/users/niksu/followers","following_url":"https://api.github.com/users/niksu/following{/other_user}","gists_url":"https://api.github.com/users/niksu/gists{/gist_id}","starred_url":"https://api.github.com/users/niksu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niksu/subscriptions","organizations_url":"https://api.github.com/users/niksu/orgs","repos_url":"https://api.github.com/users/niksu/repos","events_url":"https://api.github.com/users/niksu/events{/privacy}","received_events_url":"https://api.github.com/users/niksu/received_events","type":"User","site_admin":false},"body":"This is very cool, and using a packet generator adds useful flexibility over using the OS's network stack, as you pointer out.\r\nCould you add a header that gives a high-level view of the script's function and structure?\r\nAlso could add the usual copyright+license info, as I had added here:\r\nhttps://github.com/niksu/pax/blob/master/examples/nat_topo.py#L6","created_at":"2016-07-13T20:37:30Z","updated_at":"2016-07-13T20:37:30Z","html_url":"https://github.com/niksu/pax/pull/9#discussion_r70703596","pull_request_url":"https://api.github.com/repos/niksu/pax/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/niksu/pax/pulls/comments/70703596"},"html":{"href":"https://github.com/niksu/pax/pull/9#discussion_r70703596"},"pull_request":{"href":"https://api.github.com/repos/niksu/pax/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/niksu/pax/pulls/9","id":77279932,"html_url":"https://github.com/niksu/pax/pull/9","diff_url":"https://github.com/niksu/pax/pull/9.diff","patch_url":"https://github.com/niksu/pax/pull/9.patch","issue_url":"https://api.github.com/repos/niksu/pax/issues/9","number":9,"state":"open","locked":false,"title":"Refactor and extend NAT with UDP support","user":{"login":"TMVector","id":4268638,"avatar_url":"https://avatars.githubusercontent.com/u/4268638?v=3","gravatar_id":"","url":"https://api.github.com/users/TMVector","html_url":"https://github.com/TMVector","followers_url":"https://api.github.com/users/TMVector/followers","following_url":"https://api.github.com/users/TMVector/following{/other_user}","gists_url":"https://api.github.com/users/TMVector/gists{/gist_id}","starred_url":"https://api.github.com/users/TMVector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TMVector/subscriptions","organizations_url":"https://api.github.com/users/TMVector/orgs","repos_url":"https://api.github.com/users/TMVector/repos","events_url":"https://api.github.com/users/TMVector/events{/privacy}","received_events_url":"https://api.github.com/users/TMVector/received_events","type":"User","site_admin":false},"body":"Refactor the NAT to reflect the approach of an applications software engineer. Also add support for UDP, timeouts, TCP state, and TIME_WAIT.\r\n","created_at":"2016-07-13T12:29:43Z","updated_at":"2016-07-13T20:37:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"548b069b062b59d7fdd048a72fe6f898e8422258","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/niksu/pax/pulls/9/commits","review_comments_url":"https://api.github.com/repos/niksu/pax/pulls/9/comments","review_comment_url":"https://api.github.com/repos/niksu/pax/pulls/comments{/number}","comments_url":"https://api.github.com/repos/niksu/pax/issues/9/comments","statuses_url":"https://api.github.com/repos/niksu/pax/statuses/1d5f6ad6216a5e631915ee6bbbda119454cf2705","head":{"label":"TMVector:extend-nat","ref":"extend-nat","sha":"1d5f6ad6216a5e631915ee6bbbda119454cf2705","user":{"login":"TMVector","id":4268638,"avatar_url":"https://avatars.githubusercontent.com/u/4268638?v=3","gravatar_id":"","url":"https://api.github.com/users/TMVector","html_url":"https://github.com/TMVector","followers_url":"https://api.github.com/users/TMVector/followers","following_url":"https://api.github.com/users/TMVector/following{/other_user}","gists_url":"https://api.github.com/users/TMVector/gists{/gist_id}","starred_url":"https://api.github.com/users/TMVector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TMVector/subscriptions","organizations_url":"https://api.github.com/users/TMVector/orgs","repos_url":"https://api.github.com/users/TMVector/repos","events_url":"https://api.github.com/users/TMVector/events{/privacy}","received_events_url":"https://api.github.com/users/TMVector/received_events","type":"User","site_admin":false},"repo":{"id":61544345,"name":"pax","full_name":"TMVector/pax","owner":{"login":"TMVector","id":4268638,"avatar_url":"https://avatars.githubusercontent.com/u/4268638?v=3","gravatar_id":"","url":"https://api.github.com/users/TMVector","html_url":"https://github.com/TMVector","followers_url":"https://api.github.com/users/TMVector/followers","following_url":"https://api.github.com/users/TMVector/following{/other_user}","gists_url":"https://api.github.com/users/TMVector/gists{/gist_id}","starred_url":"https://api.github.com/users/TMVector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TMVector/subscriptions","organizations_url":"https://api.github.com/users/TMVector/orgs","repos_url":"https://api.github.com/users/TMVector/repos","events_url":"https://api.github.com/users/TMVector/events{/privacy}","received_events_url":"https://api.github.com/users/TMVector/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TMVector/pax","description":"","fork":true,"url":"https://api.github.com/repos/TMVector/pax","forks_url":"https://api.github.com/repos/TMVector/pax/forks","keys_url":"https://api.github.com/repos/TMVector/pax/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TMVector/pax/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TMVector/pax/teams","hooks_url":"https://api.github.com/repos/TMVector/pax/hooks","issue_events_url":"https://api.github.com/repos/TMVector/pax/issues/events{/number}","events_url":"https://api.github.com/repos/TMVector/pax/events","assignees_url":"https://api.github.com/repos/TMVector/pax/assignees{/user}","branches_url":"https://api.github.com/repos/TMVector/pax/branches{/branch}","tags_url":"https://api.github.com/repos/TMVector/pax/tags","blobs_url":"https://api.github.com/repos/TMVector/pax/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TMVector/pax/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TMVector/pax/git/refs{/sha}","trees_url":"https://api.github.com/repos/TMVector/pax/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TMVector/pax/statuses/{sha}","languages_url":"https://api.github.com/repos/TMVector/pax/languages","stargazers_url":"https://api.github.com/repos/TMVector/pax/stargazers","contributors_url":"https://api.github.com/repos/TMVector/pax/contributors","subscribers_url":"https://api.github.com/repos/TMVector/pax/subscribers","subscription_url":"https://api.github.com/repos/TMVector/pax/subscription","commits_url":"https://api.github.com/repos/TMVector/pax/commits{/sha}","git_commits_url":"https://api.github.com/repos/TMVector/pax/git/commits{/sha}","comments_url":"https://api.github.com/repos/TMVector/pax/comments{/number}","issue_comment_url":"https://api.github.com/repos/TMVector/pax/issues/comments{/number}","contents_url":"https://api.github.com/repos/TMVector/pax/contents/{+path}","compare_url":"https://api.github.com/repos/TMVector/pax/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TMVector/pax/merges","archive_url":"https://api.github.com/repos/TMVector/pax/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TMVector/pax/downloads","issues_url":"https://api.github.com/repos/TMVector/pax/issues{/number}","pulls_url":"https://api.github.com/repos/TMVector/pax/pulls{/number}","milestones_url":"https://api.github.com/repos/TMVector/pax/milestones{/number}","notifications_url":"https://api.github.com/repos/TMVector/pax/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TMVector/pax/labels{/name}","releases_url":"https://api.github.com/repos/TMVector/pax/releases{/id}","deployments_url":"https://api.github.com/repos/TMVector/pax/deployments","created_at":"2016-06-20T11:58:19Z","updated_at":"2016-06-28T19:38:38Z","pushed_at":"2016-07-13T18:53:58Z","git_url":"git://github.com/TMVector/pax.git","ssh_url":"git@github.com:TMVector/pax.git","clone_url":"https://github.com/TMVector/pax.git","svn_url":"https://github.com/TMVector/pax","homepage":null,"size":223,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"niksu:master","ref":"master","sha":"127108813c188c11f01b5cd05a13b412790a5fc5","user":{"login":"niksu","id":1102670,"avatar_url":"https://avatars.githubusercontent.com/u/1102670?v=3","gravatar_id":"","url":"https://api.github.com/users/niksu","html_url":"https://github.com/niksu","followers_url":"https://api.github.com/users/niksu/followers","following_url":"https://api.github.com/users/niksu/following{/other_user}","gists_url":"https://api.github.com/users/niksu/gists{/gist_id}","starred_url":"https://api.github.com/users/niksu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niksu/subscriptions","organizations_url":"https://api.github.com/users/niksu/orgs","repos_url":"https://api.github.com/users/niksu/repos","events_url":"https://api.github.com/users/niksu/events{/privacy}","received_events_url":"https://api.github.com/users/niksu/received_events","type":"User","site_admin":false},"repo":{"id":61248237,"name":"pax","full_name":"niksu/pax","owner":{"login":"niksu","id":1102670,"avatar_url":"https://avatars.githubusercontent.com/u/1102670?v=3","gravatar_id":"","url":"https://api.github.com/users/niksu","html_url":"https://github.com/niksu","followers_url":"https://api.github.com/users/niksu/followers","following_url":"https://api.github.com/users/niksu/following{/other_user}","gists_url":"https://api.github.com/users/niksu/gists{/gist_id}","starred_url":"https://api.github.com/users/niksu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niksu/subscriptions","organizations_url":"https://api.github.com/users/niksu/orgs","repos_url":"https://api.github.com/users/niksu/repos","events_url":"https://api.github.com/users/niksu/events{/privacy}","received_events_url":"https://api.github.com/users/niksu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/niksu/pax","description":"Framework for prototyping network elements","fork":false,"url":"https://api.github.com/repos/niksu/pax","forks_url":"https://api.github.com/repos/niksu/pax/forks","keys_url":"https://api.github.com/repos/niksu/pax/keys{/key_id}","collaborators_url":"https://api.github.com/repos/niksu/pax/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/niksu/pax/teams","hooks_url":"https://api.github.com/repos/niksu/pax/hooks","issue_events_url":"https://api.github.com/repos/niksu/pax/issues/events{/number}","events_url":"https://api.github.com/repos/niksu/pax/events","assignees_url":"https://api.github.com/repos/niksu/pax/assignees{/user}","branches_url":"https://api.github.com/repos/niksu/pax/branches{/branch}","tags_url":"https://api.github.com/repos/niksu/pax/tags","blobs_url":"https://api.github.com/repos/niksu/pax/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/niksu/pax/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/niksu/pax/git/refs{/sha}","trees_url":"https://api.github.com/repos/niksu/pax/git/trees{/sha}","statuses_url":"https://api.github.com/repos/niksu/pax/statuses/{sha}","languages_url":"https://api.github.com/repos/niksu/pax/languages","stargazers_url":"https://api.github.com/repos/niksu/pax/stargazers","contributors_url":"https://api.github.com/repos/niksu/pax/contributors","subscribers_url":"https://api.github.com/repos/niksu/pax/subscribers","subscription_url":"https://api.github.com/repos/niksu/pax/subscription","commits_url":"https://api.github.com/repos/niksu/pax/commits{/sha}","git_commits_url":"https://api.github.com/repos/niksu/pax/git/commits{/sha}","comments_url":"https://api.github.com/repos/niksu/pax/comments{/number}","issue_comment_url":"https://api.github.com/repos/niksu/pax/issues/comments{/number}","contents_url":"https://api.github.com/repos/niksu/pax/contents/{+path}","compare_url":"https://api.github.com/repos/niksu/pax/compare/{base}...{head}","merges_url":"https://api.github.com/repos/niksu/pax/merges","archive_url":"https://api.github.com/repos/niksu/pax/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/niksu/pax/downloads","issues_url":"https://api.github.com/repos/niksu/pax/issues{/number}","pulls_url":"https://api.github.com/repos/niksu/pax/pulls{/number}","milestones_url":"https://api.github.com/repos/niksu/pax/milestones{/number}","notifications_url":"https://api.github.com/repos/niksu/pax/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/niksu/pax/labels{/name}","releases_url":"https://api.github.com/repos/niksu/pax/releases{/id}","deployments_url":"https://api.github.com/repos/niksu/pax/deployments","created_at":"2016-06-15T23:43:36Z","updated_at":"2016-06-27T05:34:46Z","pushed_at":"2016-07-13T18:53:58Z","git_url":"git://github.com/niksu/pax.git","ssh_url":"git@github.com:niksu/pax.git","clone_url":"https://github.com/niksu/pax.git","svn_url":"https://github.com/niksu/pax","homepage":"","size":225,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/niksu/pax/pulls/9"},"html":{"href":"https://github.com/niksu/pax/pull/9"},"issue":{"href":"https://api.github.com/repos/niksu/pax/issues/9"},"comments":{"href":"https://api.github.com/repos/niksu/pax/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/niksu/pax/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/niksu/pax/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/niksu/pax/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/niksu/pax/statuses/1d5f6ad6216a5e631915ee6bbbda119454cf2705"}}}}
{"actor":{"display_login":"niksu"}}