{"action":"created","comment":{"url":"https://api.github.com/repos/metabase/metabase/pulls/comments/68666876","id":68666876,"diff_hunk":"@@ -398,8 +398,10 @@\n \n (defn render-pulse-card\n   \"Render a single CARD for a `Pulse`. DATA is the `:data` from QP results (I think).\"\n-  [card data]\n+  [card result]\n   (try\n+    (if (:error result) (throw (Exception. \"Card has errors\")))\n+    (let [data (:data result)]\n     [:a {:href   (card-href card)","path":"src/metabase/pulse/render.clj","position":9,"original_position":9,"commit_id":"72da119e9c4752b644741211376c458864837a06","original_commit_id":"72da119e9c4752b644741211376c458864837a06","user":{"login":"lewisl9029","id":6934200,"avatar_url":"https://avatars.githubusercontent.com/u/6934200?v=3","gravatar_id":"","url":"https://api.github.com/users/lewisl9029","html_url":"https://github.com/lewisl9029","followers_url":"https://api.github.com/users/lewisl9029/followers","following_url":"https://api.github.com/users/lewisl9029/following{/other_user}","gists_url":"https://api.github.com/users/lewisl9029/gists{/gist_id}","starred_url":"https://api.github.com/users/lewisl9029/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lewisl9029/subscriptions","organizations_url":"https://api.github.com/users/lewisl9029/orgs","repos_url":"https://api.github.com/users/lewisl9029/repos","events_url":"https://api.github.com/users/lewisl9029/events{/privacy}","received_events_url":"https://api.github.com/users/lewisl9029/received_events","type":"User","site_admin":false},"body":"Got it.","created_at":"2016-06-27T22:18:03Z","updated_at":"2016-06-27T22:18:03Z","html_url":"https://github.com/metabase/metabase/pull/2841#discussion_r68666876","pull_request_url":"https://api.github.com/repos/metabase/metabase/pulls/2841","_links":{"self":{"href":"https://api.github.com/repos/metabase/metabase/pulls/comments/68666876"},"html":{"href":"https://github.com/metabase/metabase/pull/2841#discussion_r68666876"},"pull_request":{"href":"https://api.github.com/repos/metabase/metabase/pulls/2841"}}},"pull_request":{"url":"https://api.github.com/repos/metabase/metabase/pulls/2841","id":75388989,"html_url":"https://github.com/metabase/metabase/pull/2841","diff_url":"https://github.com/metabase/metabase/pull/2841.diff","patch_url":"https://github.com/metabase/metabase/pull/2841.patch","issue_url":"https://api.github.com/repos/metabase/metabase/issues/2841","number":2841,"state":"open","locked":false,"title":"Retain title on pulse cards with errors [WIP]","user":{"login":"lewisl9029","id":6934200,"avatar_url":"https://avatars.githubusercontent.com/u/6934200?v=3","gravatar_id":"","url":"https://api.github.com/users/lewisl9029","html_url":"https://github.com/lewisl9029","followers_url":"https://api.github.com/users/lewisl9029/followers","following_url":"https://api.github.com/users/lewisl9029/following{/other_user}","gists_url":"https://api.github.com/users/lewisl9029/gists{/gist_id}","starred_url":"https://api.github.com/users/lewisl9029/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lewisl9029/subscriptions","organizations_url":"https://api.github.com/users/lewisl9029/orgs","repos_url":"https://api.github.com/users/lewisl9029/repos","events_url":"https://api.github.com/users/lewisl9029/events{/privacy}","received_events_url":"https://api.github.com/users/lewisl9029/received_events","type":"User","site_admin":false},"body":" Resolves #2148 \r\nAlso addresses an issue where cards with errors display as empty on the pulse/preview_cards endpoint.\r\n","created_at":"2016-06-27T22:14:10Z","updated_at":"2016-06-27T22:18:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"daa640f2bbebb5c2d1fcc3a4fa2313dfa28efac8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/metabase/metabase/pulls/2841/commits","review_comments_url":"https://api.github.com/repos/metabase/metabase/pulls/2841/comments","review_comment_url":"https://api.github.com/repos/metabase/metabase/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metabase/metabase/issues/2841/comments","statuses_url":"https://api.github.com/repos/metabase/metabase/statuses/72da119e9c4752b644741211376c458864837a06","head":{"label":"metabase:pulse-errors-retain-title","ref":"pulse-errors-retain-title","sha":"72da119e9c4752b644741211376c458864837a06","user":{"login":"metabase","id":10520629,"avatar_url":"https://avatars.githubusercontent.com/u/10520629?v=3","gravatar_id":"","url":"https://api.github.com/users/metabase","html_url":"https://github.com/metabase","followers_url":"https://api.github.com/users/metabase/followers","following_url":"https://api.github.com/users/metabase/following{/other_user}","gists_url":"https://api.github.com/users/metabase/gists{/gist_id}","starred_url":"https://api.github.com/users/metabase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabase/subscriptions","organizations_url":"https://api.github.com/users/metabase/orgs","repos_url":"https://api.github.com/users/metabase/repos","events_url":"https://api.github.com/users/metabase/events{/privacy}","received_events_url":"https://api.github.com/users/metabase/received_events","type":"Organization","site_admin":false},"repo":{"id":30203935,"name":"metabase","full_name":"metabase/metabase","owner":{"login":"metabase","id":10520629,"avatar_url":"https://avatars.githubusercontent.com/u/10520629?v=3","gravatar_id":"","url":"https://api.github.com/users/metabase","html_url":"https://github.com/metabase","followers_url":"https://api.github.com/users/metabase/followers","following_url":"https://api.github.com/users/metabase/following{/other_user}","gists_url":"https://api.github.com/users/metabase/gists{/gist_id}","starred_url":"https://api.github.com/users/metabase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabase/subscriptions","organizations_url":"https://api.github.com/users/metabase/orgs","repos_url":"https://api.github.com/users/metabase/repos","events_url":"https://api.github.com/users/metabase/events{/privacy}","received_events_url":"https://api.github.com/users/metabase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metabase/metabase","description":"The simplest, fastest way to get business intelligence and analytics  to everyone in your company :yum:","fork":false,"url":"https://api.github.com/repos/metabase/metabase","forks_url":"https://api.github.com/repos/metabase/metabase/forks","keys_url":"https://api.github.com/repos/metabase/metabase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metabase/metabase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metabase/metabase/teams","hooks_url":"https://api.github.com/repos/metabase/metabase/hooks","issue_events_url":"https://api.github.com/repos/metabase/metabase/issues/events{/number}","events_url":"https://api.github.com/repos/metabase/metabase/events","assignees_url":"https://api.github.com/repos/metabase/metabase/assignees{/user}","branches_url":"https://api.github.com/repos/metabase/metabase/branches{/branch}","tags_url":"https://api.github.com/repos/metabase/metabase/tags","blobs_url":"https://api.github.com/repos/metabase/metabase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metabase/metabase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metabase/metabase/git/refs{/sha}","trees_url":"https://api.github.com/repos/metabase/metabase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metabase/metabase/statuses/{sha}","languages_url":"https://api.github.com/repos/metabase/metabase/languages","stargazers_url":"https://api.github.com/repos/metabase/metabase/stargazers","contributors_url":"https://api.github.com/repos/metabase/metabase/contributors","subscribers_url":"https://api.github.com/repos/metabase/metabase/subscribers","subscription_url":"https://api.github.com/repos/metabase/metabase/subscription","commits_url":"https://api.github.com/repos/metabase/metabase/commits{/sha}","git_commits_url":"https://api.github.com/repos/metabase/metabase/git/commits{/sha}","comments_url":"https://api.github.com/repos/metabase/metabase/comments{/number}","issue_comment_url":"https://api.github.com/repos/metabase/metabase/issues/comments{/number}","contents_url":"https://api.github.com/repos/metabase/metabase/contents/{+path}","compare_url":"https://api.github.com/repos/metabase/metabase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metabase/metabase/merges","archive_url":"https://api.github.com/repos/metabase/metabase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metabase/metabase/downloads","issues_url":"https://api.github.com/repos/metabase/metabase/issues{/number}","pulls_url":"https://api.github.com/repos/metabase/metabase/pulls{/number}","milestones_url":"https://api.github.com/repos/metabase/metabase/milestones{/number}","notifications_url":"https://api.github.com/repos/metabase/metabase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metabase/metabase/labels{/name}","releases_url":"https://api.github.com/repos/metabase/metabase/releases{/id}","deployments_url":"https://api.github.com/repos/metabase/metabase/deployments","created_at":"2015-02-02T19:25:47Z","updated_at":"2016-06-27T12:25:57Z","pushed_at":"2016-06-27T22:14:10Z","git_url":"git://github.com/metabase/metabase.git","ssh_url":"git@github.com:metabase/metabase.git","clone_url":"https://github.com/metabase/metabase.git","svn_url":"https://github.com/metabase/metabase","homepage":"http://metabase.com","size":39485,"stargazers_count":2932,"watchers_count":2932,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":185,"mirror_url":null,"open_issues_count":398,"forks":185,"open_issues":398,"watchers":2932,"default_branch":"master"}},"base":{"label":"metabase:master","ref":"master","sha":"b6386e929f360cf54be81261461a0bdcea775e82","user":{"login":"metabase","id":10520629,"avatar_url":"https://avatars.githubusercontent.com/u/10520629?v=3","gravatar_id":"","url":"https://api.github.com/users/metabase","html_url":"https://github.com/metabase","followers_url":"https://api.github.com/users/metabase/followers","following_url":"https://api.github.com/users/metabase/following{/other_user}","gists_url":"https://api.github.com/users/metabase/gists{/gist_id}","starred_url":"https://api.github.com/users/metabase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabase/subscriptions","organizations_url":"https://api.github.com/users/metabase/orgs","repos_url":"https://api.github.com/users/metabase/repos","events_url":"https://api.github.com/users/metabase/events{/privacy}","received_events_url":"https://api.github.com/users/metabase/received_events","type":"Organization","site_admin":false},"repo":{"id":30203935,"name":"metabase","full_name":"metabase/metabase","owner":{"login":"metabase","id":10520629,"avatar_url":"https://avatars.githubusercontent.com/u/10520629?v=3","gravatar_id":"","url":"https://api.github.com/users/metabase","html_url":"https://github.com/metabase","followers_url":"https://api.github.com/users/metabase/followers","following_url":"https://api.github.com/users/metabase/following{/other_user}","gists_url":"https://api.github.com/users/metabase/gists{/gist_id}","starred_url":"https://api.github.com/users/metabase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabase/subscriptions","organizations_url":"https://api.github.com/users/metabase/orgs","repos_url":"https://api.github.com/users/metabase/repos","events_url":"https://api.github.com/users/metabase/events{/privacy}","received_events_url":"https://api.github.com/users/metabase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metabase/metabase","description":"The simplest, fastest way to get business intelligence and analytics  to everyone in your company :yum:","fork":false,"url":"https://api.github.com/repos/metabase/metabase","forks_url":"https://api.github.com/repos/metabase/metabase/forks","keys_url":"https://api.github.com/repos/metabase/metabase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metabase/metabase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metabase/metabase/teams","hooks_url":"https://api.github.com/repos/metabase/metabase/hooks","issue_events_url":"https://api.github.com/repos/metabase/metabase/issues/events{/number}","events_url":"https://api.github.com/repos/metabase/metabase/events","assignees_url":"https://api.github.com/repos/metabase/metabase/assignees{/user}","branches_url":"https://api.github.com/repos/metabase/metabase/branches{/branch}","tags_url":"https://api.github.com/repos/metabase/metabase/tags","blobs_url":"https://api.github.com/repos/metabase/metabase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metabase/metabase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metabase/metabase/git/refs{/sha}","trees_url":"https://api.github.com/repos/metabase/metabase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metabase/metabase/statuses/{sha}","languages_url":"https://api.github.com/repos/metabase/metabase/languages","stargazers_url":"https://api.github.com/repos/metabase/metabase/stargazers","contributors_url":"https://api.github.com/repos/metabase/metabase/contributors","subscribers_url":"https://api.github.com/repos/metabase/metabase/subscribers","subscription_url":"https://api.github.com/repos/metabase/metabase/subscription","commits_url":"https://api.github.com/repos/metabase/metabase/commits{/sha}","git_commits_url":"https://api.github.com/repos/metabase/metabase/git/commits{/sha}","comments_url":"https://api.github.com/repos/metabase/metabase/comments{/number}","issue_comment_url":"https://api.github.com/repos/metabase/metabase/issues/comments{/number}","contents_url":"https://api.github.com/repos/metabase/metabase/contents/{+path}","compare_url":"https://api.github.com/repos/metabase/metabase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metabase/metabase/merges","archive_url":"https://api.github.com/repos/metabase/metabase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metabase/metabase/downloads","issues_url":"https://api.github.com/repos/metabase/metabase/issues{/number}","pulls_url":"https://api.github.com/repos/metabase/metabase/pulls{/number}","milestones_url":"https://api.github.com/repos/metabase/metabase/milestones{/number}","notifications_url":"https://api.github.com/repos/metabase/metabase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metabase/metabase/labels{/name}","releases_url":"https://api.github.com/repos/metabase/metabase/releases{/id}","deployments_url":"https://api.github.com/repos/metabase/metabase/deployments","created_at":"2015-02-02T19:25:47Z","updated_at":"2016-06-27T12:25:57Z","pushed_at":"2016-06-27T22:14:10Z","git_url":"git://github.com/metabase/metabase.git","ssh_url":"git@github.com:metabase/metabase.git","clone_url":"https://github.com/metabase/metabase.git","svn_url":"https://github.com/metabase/metabase","homepage":"http://metabase.com","size":39485,"stargazers_count":2932,"watchers_count":2932,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":185,"mirror_url":null,"open_issues_count":398,"forks":185,"open_issues":398,"watchers":2932,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metabase/metabase/pulls/2841"},"html":{"href":"https://github.com/metabase/metabase/pull/2841"},"issue":{"href":"https://api.github.com/repos/metabase/metabase/issues/2841"},"comments":{"href":"https://api.github.com/repos/metabase/metabase/issues/2841/comments"},"review_comments":{"href":"https://api.github.com/repos/metabase/metabase/pulls/2841/comments"},"review_comment":{"href":"https://api.github.com/repos/metabase/metabase/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metabase/metabase/pulls/2841/commits"},"statuses":{"href":"https://api.github.com/repos/metabase/metabase/statuses/72da119e9c4752b644741211376c458864837a06"}}}}
{"actor":{"display_login":"lewisl9029"}}