{"action":"created","issue":{"url":"https://api.github.com/repos/mgedmin/check-manifest/issues/73","repository_url":"https://api.github.com/repos/mgedmin/check-manifest","labels_url":"https://api.github.com/repos/mgedmin/check-manifest/issues/73/labels{/name}","comments_url":"https://api.github.com/repos/mgedmin/check-manifest/issues/73/comments","events_url":"https://api.github.com/repos/mgedmin/check-manifest/issues/73/events","html_url":"https://github.com/mgedmin/check-manifest/pull/73","id":173554278,"number":73,"title":"Normalizes path for git and git submodules","user":{"login":"lorengordon","id":8457307,"avatar_url":"https://avatars.githubusercontent.com/u/8457307?v=3","gravatar_id":"","url":"https://api.github.com/users/lorengordon","html_url":"https://github.com/lorengordon","followers_url":"https://api.github.com/users/lorengordon/followers","following_url":"https://api.github.com/users/lorengordon/following{/other_user}","gists_url":"https://api.github.com/users/lorengordon/gists{/gist_id}","starred_url":"https://api.github.com/users/lorengordon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorengordon/subscriptions","organizations_url":"https://api.github.com/users/lorengordon/orgs","repos_url":"https://api.github.com/users/lorengordon/repos","events_url":"https://api.github.com/users/lorengordon/events{/privacy}","received_events_url":"https://api.github.com/users/lorengordon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-26T22:17:35Z","updated_at":"2016-08-29T12:29:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mgedmin/check-manifest/pulls/73","html_url":"https://github.com/mgedmin/check-manifest/pull/73","diff_url":"https://github.com/mgedmin/check-manifest/pull/73.diff","patch_url":"https://github.com/mgedmin/check-manifest/pull/73.patch"},"body":"`_git_ls_files()` returns file paths with forward slashes. For files\r\nin submodules, add_prefix_to_each() is called to prefix all the\r\nsubmodule files with the relative path to the project root. On Windows,\r\nthe relative path contains backslashes. Since not every file in the\r\nproject is in a submodule, the combined list of files ended up with\r\nsome files that use forward slashes and others that use backslashes.\r\n\r\nFor project structures where the submodules share a path segment with\r\nthe project source, this caused `add_directories()` to create duplicate\r\ndirectory entries in the list of files. The duplicate entries would\r\nresult in a traceback with a WindowsError when `os.mkdir()` was called\r\nto create the same directory a second time.\r\n\r\nSee #61 for more details.\r\n\r\nThis commit ensures the list of files contains only forward slashes\r\nbefore calling `add_directories()`, eliminating the duplicate directory\r\nentries."},"comment":{"url":"https://api.github.com/repos/mgedmin/check-manifest/issues/comments/243110198","html_url":"https://github.com/mgedmin/check-manifest/pull/73#issuecomment-243110198","issue_url":"https://api.github.com/repos/mgedmin/check-manifest/issues/73","id":243110198,"user":{"login":"lorengordon","id":8457307,"avatar_url":"https://avatars.githubusercontent.com/u/8457307?v=3","gravatar_id":"","url":"https://api.github.com/users/lorengordon","html_url":"https://github.com/lorengordon","followers_url":"https://api.github.com/users/lorengordon/followers","following_url":"https://api.github.com/users/lorengordon/following{/other_user}","gists_url":"https://api.github.com/users/lorengordon/gists{/gist_id}","starred_url":"https://api.github.com/users/lorengordon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorengordon/subscriptions","organizations_url":"https://api.github.com/users/lorengordon/orgs","repos_url":"https://api.github.com/users/lorengordon/repos","events_url":"https://api.github.com/users/lorengordon/events{/privacy}","received_events_url":"https://api.github.com/users/lorengordon/received_events","type":"User","site_admin":false},"created_at":"2016-08-29T12:29:28Z","updated_at":"2016-08-29T12:29:28Z","body":"That's some neat git- and ci-foo there. Will need to remember that trick."}}
{"actor":{"display_login":"lorengordon"}}