{"action":"created","comment":{"url":"https://api.github.com/repos/mxcube/mxcube3/pulls/comments/64737443","id":64737443,"diff_hunk":"@@ -24,12 +24,22 @@ def init_signals():\n             mxcube.diffractometer.connect(mxcube.diffractometer, signal, signals.task_event_callback)\n         else:\n             pass\n+    try:\n+        frontlight_hwobj = mxcube.diffractometer.getObjectByRole('frontlight')\n+        frontlight_hwobj.connect(frontlight_hwobj, 'positionChanged', signals.motor_event_callback)\n+        frontlightswitch_hwobj = mxcube.diffractometer.getObjectByRole('frontlightswitch')\n+        frontlightswitch_hwobj.connect(frontlightswitch_hwobj, 'actuatorStateChanged', signals.motor_event_callback)  \n+    except Exception:\n+        logging.getLogger('HWR').exception('[SAMPLEVIEW] front light hwobj error')\n+\n+    try:\n+        backlight_hwobj = mxcube.diffractometer.getObjectByRole('backlight')\n+        backlight_hwobj.connect(backlight_hwobj, 'positionChanged', signals.motor_event_callback)\n+        backlightswitch_hwobj = mxcube.diffractometer.getObjectByRole('backlightswitch')\n+        backlightswitch_hwobj.connect(backlightswitch_hwobj, 'actuatorStateChanged', signals.motor_event_callback)\n+    except Exception:\n+        logging.getLogger('HWR').exception('[SAMPLEVIEW] back light hwobj error')","path":"mxcube3/routes/SampleCentring.py","position":18,"original_position":18,"commit_id":"7db5952e44e239254ebeefd53c751c2698e75e4b","original_commit_id":"7db5952e44e239254ebeefd53c751c2698e75e4b","user":{"login":"mguijarr","id":2834952,"avatar_url":"https://avatars.githubusercontent.com/u/2834952?v=3","gravatar_id":"","url":"https://api.github.com/users/mguijarr","html_url":"https://github.com/mguijarr","followers_url":"https://api.github.com/users/mguijarr/followers","following_url":"https://api.github.com/users/mguijarr/following{/other_user}","gists_url":"https://api.github.com/users/mguijarr/gists{/gist_id}","starred_url":"https://api.github.com/users/mguijarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mguijarr/subscriptions","organizations_url":"https://api.github.com/users/mguijarr/orgs","repos_url":"https://api.github.com/users/mguijarr/repos","events_url":"https://api.github.com/users/mguijarr/events{/privacy}","received_events_url":"https://api.github.com/users/mguijarr/received_events","type":"User","site_admin":false},"body":"We need to do the same kind of trickery as in `Login.py`, `get_initial_state()` : we (at ESRF) do not have 2 separate objects for backlight and frontlight (I wonder why you separated them, by the way... ?). I can have a look and propose a change, if you want ? It's going to be something like what you proposed yesterday for the front/back light in `Login.py`.","created_at":"2016-05-26T12:37:22Z","updated_at":"2016-05-26T12:37:22Z","html_url":"https://github.com/mxcube/mxcube3/pull/214#discussion_r64737443","pull_request_url":"https://api.github.com/repos/mxcube/mxcube3/pulls/214","_links":{"self":{"href":"https://api.github.com/repos/mxcube/mxcube3/pulls/comments/64737443"},"html":{"href":"https://github.com/mxcube/mxcube3/pull/214#discussion_r64737443"},"pull_request":{"href":"https://api.github.com/repos/mxcube/mxcube3/pulls/214"}}},"pull_request":{"url":"https://api.github.com/repos/mxcube/mxcube3/pulls/214","id":71537511,"html_url":"https://github.com/mxcube/mxcube3/pull/214","diff_url":"https://github.com/mxcube/mxcube3/pull/214.diff","patch_url":"https://github.com/mxcube/mxcube3/pull/214.patch","issue_url":"https://api.github.com/repos/mxcube/mxcube3/issues/214","number":214,"state":"open","locked":false,"title":"Working with signals","user":{"login":"meguiraun","id":12758327,"avatar_url":"https://avatars.githubusercontent.com/u/12758327?v=3","gravatar_id":"","url":"https://api.github.com/users/meguiraun","html_url":"https://github.com/meguiraun","followers_url":"https://api.github.com/users/meguiraun/followers","following_url":"https://api.github.com/users/meguiraun/following{/other_user}","gists_url":"https://api.github.com/users/meguiraun/gists{/gist_id}","starred_url":"https://api.github.com/users/meguiraun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meguiraun/subscriptions","organizations_url":"https://api.github.com/users/meguiraun/orgs","repos_url":"https://api.github.com/users/meguiraun/repos","events_url":"https://api.github.com/users/meguiraun/events{/privacy}","received_events_url":"https://api.github.com/users/meguiraun/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-26T11:03:00Z","updated_at":"2016-05-26T12:37:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87a77861f8da22454aca97ffae016de63af4f79a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mxcube/mxcube3/pulls/214/commits","review_comments_url":"https://api.github.com/repos/mxcube/mxcube3/pulls/214/comments","review_comment_url":"https://api.github.com/repos/mxcube/mxcube3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mxcube/mxcube3/issues/214/comments","statuses_url":"https://api.github.com/repos/mxcube/mxcube3/statuses/7db5952e44e239254ebeefd53c751c2698e75e4b","head":{"label":"meguiraun:working_with_signals","ref":"working_with_signals","sha":"7db5952e44e239254ebeefd53c751c2698e75e4b","user":{"login":"meguiraun","id":12758327,"avatar_url":"https://avatars.githubusercontent.com/u/12758327?v=3","gravatar_id":"","url":"https://api.github.com/users/meguiraun","html_url":"https://github.com/meguiraun","followers_url":"https://api.github.com/users/meguiraun/followers","following_url":"https://api.github.com/users/meguiraun/following{/other_user}","gists_url":"https://api.github.com/users/meguiraun/gists{/gist_id}","starred_url":"https://api.github.com/users/meguiraun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meguiraun/subscriptions","organizations_url":"https://api.github.com/users/meguiraun/orgs","repos_url":"https://api.github.com/users/meguiraun/repos","events_url":"https://api.github.com/users/meguiraun/events{/privacy}","received_events_url":"https://api.github.com/users/meguiraun/received_events","type":"User","site_admin":false},"repo":{"id":47250838,"name":"mxcube3","full_name":"meguiraun/mxcube3","owner":{"login":"meguiraun","id":12758327,"avatar_url":"https://avatars.githubusercontent.com/u/12758327?v=3","gravatar_id":"","url":"https://api.github.com/users/meguiraun","html_url":"https://github.com/meguiraun","followers_url":"https://api.github.com/users/meguiraun/followers","following_url":"https://api.github.com/users/meguiraun/following{/other_user}","gists_url":"https://api.github.com/users/meguiraun/gists{/gist_id}","starred_url":"https://api.github.com/users/meguiraun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meguiraun/subscriptions","organizations_url":"https://api.github.com/users/meguiraun/orgs","repos_url":"https://api.github.com/users/meguiraun/repos","events_url":"https://api.github.com/users/meguiraun/events{/privacy}","received_events_url":"https://api.github.com/users/meguiraun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/meguiraun/mxcube3","description":"MXCuBE 3 (web)","fork":true,"url":"https://api.github.com/repos/meguiraun/mxcube3","forks_url":"https://api.github.com/repos/meguiraun/mxcube3/forks","keys_url":"https://api.github.com/repos/meguiraun/mxcube3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meguiraun/mxcube3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meguiraun/mxcube3/teams","hooks_url":"https://api.github.com/repos/meguiraun/mxcube3/hooks","issue_events_url":"https://api.github.com/repos/meguiraun/mxcube3/issues/events{/number}","events_url":"https://api.github.com/repos/meguiraun/mxcube3/events","assignees_url":"https://api.github.com/repos/meguiraun/mxcube3/assignees{/user}","branches_url":"https://api.github.com/repos/meguiraun/mxcube3/branches{/branch}","tags_url":"https://api.github.com/repos/meguiraun/mxcube3/tags","blobs_url":"https://api.github.com/repos/meguiraun/mxcube3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meguiraun/mxcube3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meguiraun/mxcube3/git/refs{/sha}","trees_url":"https://api.github.com/repos/meguiraun/mxcube3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meguiraun/mxcube3/statuses/{sha}","languages_url":"https://api.github.com/repos/meguiraun/mxcube3/languages","stargazers_url":"https://api.github.com/repos/meguiraun/mxcube3/stargazers","contributors_url":"https://api.github.com/repos/meguiraun/mxcube3/contributors","subscribers_url":"https://api.github.com/repos/meguiraun/mxcube3/subscribers","subscription_url":"https://api.github.com/repos/meguiraun/mxcube3/subscription","commits_url":"https://api.github.com/repos/meguiraun/mxcube3/commits{/sha}","git_commits_url":"https://api.github.com/repos/meguiraun/mxcube3/git/commits{/sha}","comments_url":"https://api.github.com/repos/meguiraun/mxcube3/comments{/number}","issue_comment_url":"https://api.github.com/repos/meguiraun/mxcube3/issues/comments{/number}","contents_url":"https://api.github.com/repos/meguiraun/mxcube3/contents/{+path}","compare_url":"https://api.github.com/repos/meguiraun/mxcube3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meguiraun/mxcube3/merges","archive_url":"https://api.github.com/repos/meguiraun/mxcube3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meguiraun/mxcube3/downloads","issues_url":"https://api.github.com/repos/meguiraun/mxcube3/issues{/number}","pulls_url":"https://api.github.com/repos/meguiraun/mxcube3/pulls{/number}","milestones_url":"https://api.github.com/repos/meguiraun/mxcube3/milestones{/number}","notifications_url":"https://api.github.com/repos/meguiraun/mxcube3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meguiraun/mxcube3/labels{/name}","releases_url":"https://api.github.com/repos/meguiraun/mxcube3/releases{/id}","deployments_url":"https://api.github.com/repos/meguiraun/mxcube3/deployments","created_at":"2015-12-02T09:30:42Z","updated_at":"2016-01-12T11:11:55Z","pushed_at":"2016-05-26T11:17:43Z","git_url":"git://github.com/meguiraun/mxcube3.git","ssh_url":"git@github.com:meguiraun/mxcube3.git","clone_url":"https://github.com/meguiraun/mxcube3.git","svn_url":"https://github.com/meguiraun/mxcube3","homepage":null,"size":2888,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mxcube:master","ref":"master","sha":"97c24a83fa2e1620f3dbef12ff5f17df5c376762","user":{"login":"mxcube","id":4322027,"avatar_url":"https://avatars.githubusercontent.com/u/4322027?v=3","gravatar_id":"","url":"https://api.github.com/users/mxcube","html_url":"https://github.com/mxcube","followers_url":"https://api.github.com/users/mxcube/followers","following_url":"https://api.github.com/users/mxcube/following{/other_user}","gists_url":"https://api.github.com/users/mxcube/gists{/gist_id}","starred_url":"https://api.github.com/users/mxcube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxcube/subscriptions","organizations_url":"https://api.github.com/users/mxcube/orgs","repos_url":"https://api.github.com/users/mxcube/repos","events_url":"https://api.github.com/users/mxcube/events{/privacy}","received_events_url":"https://api.github.com/users/mxcube/received_events","type":"Organization","site_admin":false},"repo":{"id":42655839,"name":"mxcube3","full_name":"mxcube/mxcube3","owner":{"login":"mxcube","id":4322027,"avatar_url":"https://avatars.githubusercontent.com/u/4322027?v=3","gravatar_id":"","url":"https://api.github.com/users/mxcube","html_url":"https://github.com/mxcube","followers_url":"https://api.github.com/users/mxcube/followers","following_url":"https://api.github.com/users/mxcube/following{/other_user}","gists_url":"https://api.github.com/users/mxcube/gists{/gist_id}","starred_url":"https://api.github.com/users/mxcube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxcube/subscriptions","organizations_url":"https://api.github.com/users/mxcube/orgs","repos_url":"https://api.github.com/users/mxcube/repos","events_url":"https://api.github.com/users/mxcube/events{/privacy}","received_events_url":"https://api.github.com/users/mxcube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mxcube/mxcube3","description":"MXCuBE 3 (web)","fork":false,"url":"https://api.github.com/repos/mxcube/mxcube3","forks_url":"https://api.github.com/repos/mxcube/mxcube3/forks","keys_url":"https://api.github.com/repos/mxcube/mxcube3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mxcube/mxcube3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mxcube/mxcube3/teams","hooks_url":"https://api.github.com/repos/mxcube/mxcube3/hooks","issue_events_url":"https://api.github.com/repos/mxcube/mxcube3/issues/events{/number}","events_url":"https://api.github.com/repos/mxcube/mxcube3/events","assignees_url":"https://api.github.com/repos/mxcube/mxcube3/assignees{/user}","branches_url":"https://api.github.com/repos/mxcube/mxcube3/branches{/branch}","tags_url":"https://api.github.com/repos/mxcube/mxcube3/tags","blobs_url":"https://api.github.com/repos/mxcube/mxcube3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mxcube/mxcube3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mxcube/mxcube3/git/refs{/sha}","trees_url":"https://api.github.com/repos/mxcube/mxcube3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mxcube/mxcube3/statuses/{sha}","languages_url":"https://api.github.com/repos/mxcube/mxcube3/languages","stargazers_url":"https://api.github.com/repos/mxcube/mxcube3/stargazers","contributors_url":"https://api.github.com/repos/mxcube/mxcube3/contributors","subscribers_url":"https://api.github.com/repos/mxcube/mxcube3/subscribers","subscription_url":"https://api.github.com/repos/mxcube/mxcube3/subscription","commits_url":"https://api.github.com/repos/mxcube/mxcube3/commits{/sha}","git_commits_url":"https://api.github.com/repos/mxcube/mxcube3/git/commits{/sha}","comments_url":"https://api.github.com/repos/mxcube/mxcube3/comments{/number}","issue_comment_url":"https://api.github.com/repos/mxcube/mxcube3/issues/comments{/number}","contents_url":"https://api.github.com/repos/mxcube/mxcube3/contents/{+path}","compare_url":"https://api.github.com/repos/mxcube/mxcube3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mxcube/mxcube3/merges","archive_url":"https://api.github.com/repos/mxcube/mxcube3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mxcube/mxcube3/downloads","issues_url":"https://api.github.com/repos/mxcube/mxcube3/issues{/number}","pulls_url":"https://api.github.com/repos/mxcube/mxcube3/pulls{/number}","milestones_url":"https://api.github.com/repos/mxcube/mxcube3/milestones{/number}","notifications_url":"https://api.github.com/repos/mxcube/mxcube3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mxcube/mxcube3/labels{/name}","releases_url":"https://api.github.com/repos/mxcube/mxcube3/releases{/id}","deployments_url":"https://api.github.com/repos/mxcube/mxcube3/deployments","created_at":"2015-09-17T12:47:34Z","updated_at":"2016-05-18T11:33:52Z","pushed_at":"2016-05-26T12:28:31Z","git_url":"git://github.com/mxcube/mxcube3.git","ssh_url":"git@github.com:mxcube/mxcube3.git","clone_url":"https://github.com/mxcube/mxcube3.git","svn_url":"https://github.com/mxcube/mxcube3","homepage":null,"size":2997,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":30,"forks":7,"open_issues":30,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mxcube/mxcube3/pulls/214"},"html":{"href":"https://github.com/mxcube/mxcube3/pull/214"},"issue":{"href":"https://api.github.com/repos/mxcube/mxcube3/issues/214"},"comments":{"href":"https://api.github.com/repos/mxcube/mxcube3/issues/214/comments"},"review_comments":{"href":"https://api.github.com/repos/mxcube/mxcube3/pulls/214/comments"},"review_comment":{"href":"https://api.github.com/repos/mxcube/mxcube3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mxcube/mxcube3/pulls/214/commits"},"statuses":{"href":"https://api.github.com/repos/mxcube/mxcube3/statuses/7db5952e44e239254ebeefd53c751c2698e75e4b"}}}}
{"actor":{"display_login":"mguijarr"}}