{"action":"closed","number":86,"pull_request":{"url":"https://api.github.com/repos/mobify/mobify-code-style/pulls/86","id":57287082,"html_url":"https://github.com/mobify/mobify-code-style/pull/86","diff_url":"https://github.com/mobify/mobify-code-style/pull/86.diff","patch_url":"https://github.com/mobify/mobify-code-style/pull/86.patch","issue_url":"https://api.github.com/repos/mobify/mobify-code-style/issues/86","number":86,"state":"closed","locked":false,"title":"Fix the point about function expression hoisting","user":{"login":"aaani","id":3347504,"avatar_url":"https://avatars.githubusercontent.com/u/3347504?v=3","gravatar_id":"","url":"https://api.github.com/users/aaani","html_url":"https://github.com/aaani","followers_url":"https://api.github.com/users/aaani/followers","following_url":"https://api.github.com/users/aaani/following{/other_user}","gists_url":"https://api.github.com/users/aaani/gists{/gist_id}","starred_url":"https://api.github.com/users/aaani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaani/subscriptions","organizations_url":"https://api.github.com/users/aaani/orgs","repos_url":"https://api.github.com/users/aaani/repos","events_url":"https://api.github.com/users/aaani/events{/privacy}","received_events_url":"https://api.github.com/users/aaani/received_events","type":"User","site_admin":false},"body":"# Fix the point about function expression hoisting\r\n\r\nStatus: **Up For Review**\r\n\r\nReviewers: @jansepar \r\n\r\n## Changes\r\n- In javascript, function expressions are not hoisted, but function declarations are. This doc said the exact opposite of that. I updated the doc with the correct info.\r\n\r\n## How to test-drive this PR\r\n- Read the section`Use function expressions over function declarations` and make sure it makes sense. \r\n\r\n## Research resources\r\n- [Function declaration hoisting](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/function#Function_declaration_hoisting)","created_at":"2016-01-26T22:59:01Z","updated_at":"2016-01-26T23:05:45Z","closed_at":"2016-01-26T23:05:45Z","merged_at":"2016-01-26T23:05:45Z","merge_commit_sha":"99cfde1ca8397e3f21673835cf72038499960fde","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mobify/mobify-code-style/pulls/86/commits","review_comments_url":"https://api.github.com/repos/mobify/mobify-code-style/pulls/86/comments","review_comment_url":"https://api.github.com/repos/mobify/mobify-code-style/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mobify/mobify-code-style/issues/86/comments","statuses_url":"https://api.github.com/repos/mobify/mobify-code-style/statuses/9708e404ec9f19f6db4a94cbcc73f653711203c1","head":{"label":"mobify:function-expression-hoisting","ref":"function-expression-hoisting","sha":"9708e404ec9f19f6db4a94cbcc73f653711203c1","user":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"repo":{"id":19261065,"name":"mobify-code-style","full_name":"mobify/mobify-code-style","owner":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobify/mobify-code-style","description":"Mobify's coding style and standards!","fork":false,"url":"https://api.github.com/repos/mobify/mobify-code-style","forks_url":"https://api.github.com/repos/mobify/mobify-code-style/forks","keys_url":"https://api.github.com/repos/mobify/mobify-code-style/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobify/mobify-code-style/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobify/mobify-code-style/teams","hooks_url":"https://api.github.com/repos/mobify/mobify-code-style/hooks","issue_events_url":"https://api.github.com/repos/mobify/mobify-code-style/issues/events{/number}","events_url":"https://api.github.com/repos/mobify/mobify-code-style/events","assignees_url":"https://api.github.com/repos/mobify/mobify-code-style/assignees{/user}","branches_url":"https://api.github.com/repos/mobify/mobify-code-style/branches{/branch}","tags_url":"https://api.github.com/repos/mobify/mobify-code-style/tags","blobs_url":"https://api.github.com/repos/mobify/mobify-code-style/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobify/mobify-code-style/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobify/mobify-code-style/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobify/mobify-code-style/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobify/mobify-code-style/statuses/{sha}","languages_url":"https://api.github.com/repos/mobify/mobify-code-style/languages","stargazers_url":"https://api.github.com/repos/mobify/mobify-code-style/stargazers","contributors_url":"https://api.github.com/repos/mobify/mobify-code-style/contributors","subscribers_url":"https://api.github.com/repos/mobify/mobify-code-style/subscribers","subscription_url":"https://api.github.com/repos/mobify/mobify-code-style/subscription","commits_url":"https://api.github.com/repos/mobify/mobify-code-style/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobify/mobify-code-style/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobify/mobify-code-style/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobify/mobify-code-style/issues/comments{/number}","contents_url":"https://api.github.com/repos/mobify/mobify-code-style/contents/{+path}","compare_url":"https://api.github.com/repos/mobify/mobify-code-style/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobify/mobify-code-style/merges","archive_url":"https://api.github.com/repos/mobify/mobify-code-style/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobify/mobify-code-style/downloads","issues_url":"https://api.github.com/repos/mobify/mobify-code-style/issues{/number}","pulls_url":"https://api.github.com/repos/mobify/mobify-code-style/pulls{/number}","milestones_url":"https://api.github.com/repos/mobify/mobify-code-style/milestones{/number}","notifications_url":"https://api.github.com/repos/mobify/mobify-code-style/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobify/mobify-code-style/labels{/name}","releases_url":"https://api.github.com/repos/mobify/mobify-code-style/releases{/id}","deployments_url":"https://api.github.com/repos/mobify/mobify-code-style/deployments","created_at":"2014-04-29T02:27:15Z","updated_at":"2016-01-25T12:05:31Z","pushed_at":"2016-01-26T23:05:44Z","git_url":"git://github.com/mobify/mobify-code-style.git","ssh_url":"git@github.com:mobify/mobify-code-style.git","clone_url":"https://github.com/mobify/mobify-code-style.git","svn_url":"https://github.com/mobify/mobify-code-style","homepage":"","size":304,"stargazers_count":56,"watchers_count":56,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":8,"forks":7,"open_issues":8,"watchers":56,"default_branch":"master"}},"base":{"label":"mobify:master","ref":"master","sha":"0812ad7e184f16c0df13113c25c4851df2f8a9ab","user":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"repo":{"id":19261065,"name":"mobify-code-style","full_name":"mobify/mobify-code-style","owner":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobify/mobify-code-style","description":"Mobify's coding style and standards!","fork":false,"url":"https://api.github.com/repos/mobify/mobify-code-style","forks_url":"https://api.github.com/repos/mobify/mobify-code-style/forks","keys_url":"https://api.github.com/repos/mobify/mobify-code-style/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobify/mobify-code-style/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobify/mobify-code-style/teams","hooks_url":"https://api.github.com/repos/mobify/mobify-code-style/hooks","issue_events_url":"https://api.github.com/repos/mobify/mobify-code-style/issues/events{/number}","events_url":"https://api.github.com/repos/mobify/mobify-code-style/events","assignees_url":"https://api.github.com/repos/mobify/mobify-code-style/assignees{/user}","branches_url":"https://api.github.com/repos/mobify/mobify-code-style/branches{/branch}","tags_url":"https://api.github.com/repos/mobify/mobify-code-style/tags","blobs_url":"https://api.github.com/repos/mobify/mobify-code-style/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobify/mobify-code-style/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobify/mobify-code-style/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobify/mobify-code-style/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobify/mobify-code-style/statuses/{sha}","languages_url":"https://api.github.com/repos/mobify/mobify-code-style/languages","stargazers_url":"https://api.github.com/repos/mobify/mobify-code-style/stargazers","contributors_url":"https://api.github.com/repos/mobify/mobify-code-style/contributors","subscribers_url":"https://api.github.com/repos/mobify/mobify-code-style/subscribers","subscription_url":"https://api.github.com/repos/mobify/mobify-code-style/subscription","commits_url":"https://api.github.com/repos/mobify/mobify-code-style/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobify/mobify-code-style/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobify/mobify-code-style/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobify/mobify-code-style/issues/comments{/number}","contents_url":"https://api.github.com/repos/mobify/mobify-code-style/contents/{+path}","compare_url":"https://api.github.com/repos/mobify/mobify-code-style/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobify/mobify-code-style/merges","archive_url":"https://api.github.com/repos/mobify/mobify-code-style/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobify/mobify-code-style/downloads","issues_url":"https://api.github.com/repos/mobify/mobify-code-style/issues{/number}","pulls_url":"https://api.github.com/repos/mobify/mobify-code-style/pulls{/number}","milestones_url":"https://api.github.com/repos/mobify/mobify-code-style/milestones{/number}","notifications_url":"https://api.github.com/repos/mobify/mobify-code-style/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobify/mobify-code-style/labels{/name}","releases_url":"https://api.github.com/repos/mobify/mobify-code-style/releases{/id}","deployments_url":"https://api.github.com/repos/mobify/mobify-code-style/deployments","created_at":"2014-04-29T02:27:15Z","updated_at":"2016-01-25T12:05:31Z","pushed_at":"2016-01-26T23:05:44Z","git_url":"git://github.com/mobify/mobify-code-style.git","ssh_url":"git@github.com:mobify/mobify-code-style.git","clone_url":"https://github.com/mobify/mobify-code-style.git","svn_url":"https://github.com/mobify/mobify-code-style","homepage":"","size":304,"stargazers_count":56,"watchers_count":56,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":8,"forks":7,"open_issues":8,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mobify/mobify-code-style/pulls/86"},"html":{"href":"https://github.com/mobify/mobify-code-style/pull/86"},"issue":{"href":"https://api.github.com/repos/mobify/mobify-code-style/issues/86"},"comments":{"href":"https://api.github.com/repos/mobify/mobify-code-style/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/mobify/mobify-code-style/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/mobify/mobify-code-style/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mobify/mobify-code-style/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/mobify/mobify-code-style/statuses/9708e404ec9f19f6db4a94cbcc73f653711203c1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"aaani","id":3347504,"avatar_url":"https://avatars.githubusercontent.com/u/3347504?v=3","gravatar_id":"","url":"https://api.github.com/users/aaani","html_url":"https://github.com/aaani","followers_url":"https://api.github.com/users/aaani/followers","following_url":"https://api.github.com/users/aaani/following{/other_user}","gists_url":"https://api.github.com/users/aaani/gists{/gist_id}","starred_url":"https://api.github.com/users/aaani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaani/subscriptions","organizations_url":"https://api.github.com/users/aaani/orgs","repos_url":"https://api.github.com/users/aaani/repos","events_url":"https://api.github.com/users/aaani/events{/privacy}","received_events_url":"https://api.github.com/users/aaani/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}