{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments/69817591","id":69817591,"diff_hunk":"@@ -1,115 +1,112 @@\n-/*\n-Original Author: Michael Ash on 11/9/08.\n-Copyright (c) 2008 Rogue Amoeba Software LLC\n-\n-Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated\n-documentation files (the \"Software\"), to deal in the Software without restriction, including without limitation the\n-rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit\n-persons to whom the Software is furnished to do so, subject to the following conditions:\n-\n-The above copyright notice and this permission notice shall be included in all copies or substantial portions of the\n-Software.\n-\n-THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE\n-WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR\n-COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR\n-OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.\n-\n-*/\n+//******************************************************************************\n+//\n+// Copyright (c) 2016 Microsoft Corporation. All rights reserved.\n+//\n+// This code is licensed under the MIT License (MIT).\n+//\n+// THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\n+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n+// THE SOFTWARE.\n+//\n+//******************************************************************************\n \n #include \"Starboard.h\"\n #include \"StubReturn.h\"\n #include \"Foundation/NSOperation.h\"\n-#include \"Foundation/NSString.h\"\n-#include \"Foundation/NSMutableArray.h\"\n-#include \"LoggingNative.h\"\n \n static const wchar_t* TAG = L\"NSOperation\";\n \n-#if __cplusplus\n-#include <pthread.h>\n-#include <string.h>\n-struct NSOperationPriv {\n-    NSOperationQueuePriority priority;\n-    id dependencies;\n-    void (^completionBlock)(void);\n+@implementation NSOperation {\n+    StrongId<NSMutableArray> _dependencies;\n+    void (^_completionBlock)(void);\n+    pthread_cond_t _finishCondition;\n+    pthread_mutex_t _finishLock;\n+    pthread_mutex_t _dependenciesLock;\n+    pthread_mutex_t _completionBlockLock;\n+}\n \n-    pthread_cond_t finishCondition;\n-    pthread_mutex_t finishLock;\n+@synthesize cancelled = _cancelled;\n+@synthesize executing = _executing;\n+@synthesize finished = _finished;","path":"Frameworks/Foundation/NSOperation.mm","position":null,"original_position":64,"commit_id":"dc5c3e708bd35afc719e3a7101e1b73f1ceae8fb","original_commit_id":"7e1cc5508c30eea81c4c9669bce4e9552fc805d8","user":{"login":"jofre-ms","id":15270533,"avatar_url":"https://avatars.githubusercontent.com/u/15270533?v=3","gravatar_id":"","url":"https://api.github.com/users/jofre-ms","html_url":"https://github.com/jofre-ms","followers_url":"https://api.github.com/users/jofre-ms/followers","following_url":"https://api.github.com/users/jofre-ms/following{/other_user}","gists_url":"https://api.github.com/users/jofre-ms/gists{/gist_id}","starred_url":"https://api.github.com/users/jofre-ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jofre-ms/subscriptions","organizations_url":"https://api.github.com/users/jofre-ms/orgs","repos_url":"https://api.github.com/users/jofre-ms/repos","events_url":"https://api.github.com/users/jofre-ms/events{/privacy}","received_events_url":"https://api.github.com/users/jofre-ms/received_events","type":"User","site_admin":false},"body":"The current implementation for queue priority, which is just auto-synthesized, is sufficiently interoperable\r\n\r\n---\r\nIn reply to: [69659816](https://github.com/Microsoft/WinObjC/pull/602#discussion_r69659816) [](ancestors = 69659816,69615276,69614305,69354091)","created_at":"2016-07-06T21:46:03Z","updated_at":"2016-07-06T21:46:04Z","html_url":"https://github.com/Microsoft/WinObjC/pull/602#discussion_r69817591","pull_request_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/602","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments/69817591"},"html":{"href":"https://github.com/Microsoft/WinObjC/pull/602#discussion_r69817591"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/602"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/602","id":76016045,"html_url":"https://github.com/Microsoft/WinObjC/pull/602","diff_url":"https://github.com/Microsoft/WinObjC/pull/602.diff","patch_url":"https://github.com/Microsoft/WinObjC/pull/602.patch","issue_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/602","number":602,"state":"open","locked":false,"title":"Fix #580, add support for concurrent NSOperation subclass","user":{"login":"jofre-ms","id":15270533,"avatar_url":"https://avatars.githubusercontent.com/u/15270533?v=3","gravatar_id":"","url":"https://api.github.com/users/jofre-ms","html_url":"https://github.com/jofre-ms","followers_url":"https://api.github.com/users/jofre-ms/followers","following_url":"https://api.github.com/users/jofre-ms/following{/other_user}","gists_url":"https://api.github.com/users/jofre-ms/gists{/gist_id}","starred_url":"https://api.github.com/users/jofre-ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jofre-ms/subscriptions","organizations_url":"https://api.github.com/users/jofre-ms/orgs","repos_url":"https://api.github.com/users/jofre-ms/repos","events_url":"https://api.github.com/users/jofre-ms/events{/privacy}","received_events_url":"https://api.github.com/users/jofre-ms/received_events","type":"User","site_admin":false},"body":"This change redesigns NSOperation for subclassability as documented for the reference platform, and adds a test to verify that the subclass no longer deadlocks in waitUntilFinished.","created_at":"2016-07-01T18:02:34Z","updated_at":"2016-07-06T21:46:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9dcec8609593c5f668178d18f896507e4af30a5e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/602/commits","review_comments_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/602/comments","review_comment_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/602/comments","statuses_url":"https://api.github.com/repos/Microsoft/WinObjC/statuses/dc5c3e708bd35afc719e3a7101e1b73f1ceae8fb","head":{"label":"jofre-ms:jofre/NSOperation","ref":"jofre/NSOperation","sha":"dc5c3e708bd35afc719e3a7101e1b73f1ceae8fb","user":{"login":"jofre-ms","id":15270533,"avatar_url":"https://avatars.githubusercontent.com/u/15270533?v=3","gravatar_id":"","url":"https://api.github.com/users/jofre-ms","html_url":"https://github.com/jofre-ms","followers_url":"https://api.github.com/users/jofre-ms/followers","following_url":"https://api.github.com/users/jofre-ms/following{/other_user}","gists_url":"https://api.github.com/users/jofre-ms/gists{/gist_id}","starred_url":"https://api.github.com/users/jofre-ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jofre-ms/subscriptions","organizations_url":"https://api.github.com/users/jofre-ms/orgs","repos_url":"https://api.github.com/users/jofre-ms/repos","events_url":"https://api.github.com/users/jofre-ms/events{/privacy}","received_events_url":"https://api.github.com/users/jofre-ms/received_events","type":"User","site_admin":false},"repo":{"id":62094153,"name":"WinObjC","full_name":"jofre-ms/WinObjC","owner":{"login":"jofre-ms","id":15270533,"avatar_url":"https://avatars.githubusercontent.com/u/15270533?v=3","gravatar_id":"","url":"https://api.github.com/users/jofre-ms","html_url":"https://github.com/jofre-ms","followers_url":"https://api.github.com/users/jofre-ms/followers","following_url":"https://api.github.com/users/jofre-ms/following{/other_user}","gists_url":"https://api.github.com/users/jofre-ms/gists{/gist_id}","starred_url":"https://api.github.com/users/jofre-ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jofre-ms/subscriptions","organizations_url":"https://api.github.com/users/jofre-ms/orgs","repos_url":"https://api.github.com/users/jofre-ms/repos","events_url":"https://api.github.com/users/jofre-ms/events{/privacy}","received_events_url":"https://api.github.com/users/jofre-ms/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jofre-ms/WinObjC","description":"Objective-C for Windows","fork":true,"url":"https://api.github.com/repos/jofre-ms/WinObjC","forks_url":"https://api.github.com/repos/jofre-ms/WinObjC/forks","keys_url":"https://api.github.com/repos/jofre-ms/WinObjC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jofre-ms/WinObjC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jofre-ms/WinObjC/teams","hooks_url":"https://api.github.com/repos/jofre-ms/WinObjC/hooks","issue_events_url":"https://api.github.com/repos/jofre-ms/WinObjC/issues/events{/number}","events_url":"https://api.github.com/repos/jofre-ms/WinObjC/events","assignees_url":"https://api.github.com/repos/jofre-ms/WinObjC/assignees{/user}","branches_url":"https://api.github.com/repos/jofre-ms/WinObjC/branches{/branch}","tags_url":"https://api.github.com/repos/jofre-ms/WinObjC/tags","blobs_url":"https://api.github.com/repos/jofre-ms/WinObjC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jofre-ms/WinObjC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jofre-ms/WinObjC/git/refs{/sha}","trees_url":"https://api.github.com/repos/jofre-ms/WinObjC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jofre-ms/WinObjC/statuses/{sha}","languages_url":"https://api.github.com/repos/jofre-ms/WinObjC/languages","stargazers_url":"https://api.github.com/repos/jofre-ms/WinObjC/stargazers","contributors_url":"https://api.github.com/repos/jofre-ms/WinObjC/contributors","subscribers_url":"https://api.github.com/repos/jofre-ms/WinObjC/subscribers","subscription_url":"https://api.github.com/repos/jofre-ms/WinObjC/subscription","commits_url":"https://api.github.com/repos/jofre-ms/WinObjC/commits{/sha}","git_commits_url":"https://api.github.com/repos/jofre-ms/WinObjC/git/commits{/sha}","comments_url":"https://api.github.com/repos/jofre-ms/WinObjC/comments{/number}","issue_comment_url":"https://api.github.com/repos/jofre-ms/WinObjC/issues/comments{/number}","contents_url":"https://api.github.com/repos/jofre-ms/WinObjC/contents/{+path}","compare_url":"https://api.github.com/repos/jofre-ms/WinObjC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jofre-ms/WinObjC/merges","archive_url":"https://api.github.com/repos/jofre-ms/WinObjC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jofre-ms/WinObjC/downloads","issues_url":"https://api.github.com/repos/jofre-ms/WinObjC/issues{/number}","pulls_url":"https://api.github.com/repos/jofre-ms/WinObjC/pulls{/number}","milestones_url":"https://api.github.com/repos/jofre-ms/WinObjC/milestones{/number}","notifications_url":"https://api.github.com/repos/jofre-ms/WinObjC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jofre-ms/WinObjC/labels{/name}","releases_url":"https://api.github.com/repos/jofre-ms/WinObjC/releases{/id}","deployments_url":"https://api.github.com/repos/jofre-ms/WinObjC/deployments","created_at":"2016-06-27T23:07:21Z","updated_at":"2016-06-27T23:07:36Z","pushed_at":"2016-07-06T18:29:21Z","git_url":"git://github.com/jofre-ms/WinObjC.git","ssh_url":"git@github.com:jofre-ms/WinObjC.git","clone_url":"https://github.com/jofre-ms/WinObjC.git","svn_url":"https://github.com/jofre-ms/WinObjC","homepage":"","size":326546,"stargazers_count":0,"watchers_count":0,"language":"Objective-C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:develop","ref":"develop","sha":"7576c01f47ab955f11a30a2955f44f61c6f4d44d","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":37950166,"name":"WinObjC","full_name":"Microsoft/WinObjC","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/WinObjC","description":"Objective-C for Windows","fork":false,"url":"https://api.github.com/repos/Microsoft/WinObjC","forks_url":"https://api.github.com/repos/Microsoft/WinObjC/forks","keys_url":"https://api.github.com/repos/Microsoft/WinObjC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/WinObjC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/WinObjC/teams","hooks_url":"https://api.github.com/repos/Microsoft/WinObjC/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/WinObjC/events","assignees_url":"https://api.github.com/repos/Microsoft/WinObjC/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/WinObjC/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/WinObjC/tags","blobs_url":"https://api.github.com/repos/Microsoft/WinObjC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/WinObjC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/WinObjC/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/WinObjC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/WinObjC/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/WinObjC/languages","stargazers_url":"https://api.github.com/repos/Microsoft/WinObjC/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/WinObjC/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/WinObjC/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/WinObjC/subscription","commits_url":"https://api.github.com/repos/Microsoft/WinObjC/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/WinObjC/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/WinObjC/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/WinObjC/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/WinObjC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/WinObjC/merges","archive_url":"https://api.github.com/repos/Microsoft/WinObjC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/WinObjC/downloads","issues_url":"https://api.github.com/repos/Microsoft/WinObjC/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/WinObjC/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/WinObjC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/WinObjC/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/WinObjC/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/WinObjC/deployments","created_at":"2015-06-23T23:14:58Z","updated_at":"2016-07-06T02:18:59Z","pushed_at":"2016-07-06T21:40:58Z","git_url":"git://github.com/Microsoft/WinObjC.git","ssh_url":"git@github.com:Microsoft/WinObjC.git","clone_url":"https://github.com/Microsoft/WinObjC.git","svn_url":"https://github.com/Microsoft/WinObjC","homepage":"","size":328881,"stargazers_count":5308,"watchers_count":5308,"language":"Objective-C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":665,"mirror_url":null,"open_issues_count":166,"forks":665,"open_issues":166,"watchers":5308,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/602"},"html":{"href":"https://github.com/Microsoft/WinObjC/pull/602"},"issue":{"href":"https://api.github.com/repos/Microsoft/WinObjC/issues/602"},"comments":{"href":"https://api.github.com/repos/Microsoft/WinObjC/issues/602/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/602/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/602/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/WinObjC/statuses/dc5c3e708bd35afc719e3a7101e1b73f1ceae8fb"}}}}
{"actor":{"display_login":"jofre-ms"}}