{"action":"created","comment":{"url":"https://api.github.com/repos/WebAssembly/spec/pulls/comments/63173383","id":63173383,"diff_hunk":"@@ -32,29 +37,48 @@ def _compareLog(self, fileName, logPath):\n     except IOError:\n       pass\n \n+  def _readHeaders(self, fileName):\n+    expected_exit_code = 0\n+\n+    with file(fileName) as f:\n+      headers = f.readline().split(' ')\n+\n+      if headers[0] == ';;;':\n+        for h in headers[1:]:\n+          if h.strip() == 'expected-fail':","path":"ml-proto/runtests.py","position":null,"original_position":30,"commit_id":"e5e2123bc9a19536289e85d044be587b65a13a8d","original_commit_id":"080aa4e6fe1e7a9d2cab81ae410af9702535c1ec","user":{"login":"bnjbvr","id":1180019,"avatar_url":"https://avatars.githubusercontent.com/u/1180019?v=3","gravatar_id":"","url":"https://api.github.com/users/bnjbvr","html_url":"https://github.com/bnjbvr","followers_url":"https://api.github.com/users/bnjbvr/followers","following_url":"https://api.github.com/users/bnjbvr/following{/other_user}","gists_url":"https://api.github.com/users/bnjbvr/gists{/gist_id}","starred_url":"https://api.github.com/users/bnjbvr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnjbvr/subscriptions","organizations_url":"https://api.github.com/users/bnjbvr/orgs","repos_url":"https://api.github.com/users/bnjbvr/repos","events_url":"https://api.github.com/users/bnjbvr/events{/privacy}","received_events_url":"https://api.github.com/users/bnjbvr/received_events","type":"User","site_admin":false},"body":"Yeah, good idea.","created_at":"2016-05-13T12:18:37Z","updated_at":"2016-05-13T12:18:37Z","html_url":"https://github.com/WebAssembly/spec/pull/284#discussion_r63173383","pull_request_url":"https://api.github.com/repos/WebAssembly/spec/pulls/284","_links":{"self":{"href":"https://api.github.com/repos/WebAssembly/spec/pulls/comments/63173383"},"html":{"href":"https://github.com/WebAssembly/spec/pull/284#discussion_r63173383"},"pull_request":{"href":"https://api.github.com/repos/WebAssembly/spec/pulls/284"}}},"pull_request":{"url":"https://api.github.com/repos/WebAssembly/spec/pulls/284","id":69535911,"html_url":"https://github.com/WebAssembly/spec/pull/284","diff_url":"https://github.com/WebAssembly/spec/pull/284.diff","patch_url":"https://github.com/WebAssembly/spec/pull/284.patch","issue_url":"https://api.github.com/repos/WebAssembly/spec/issues/284","number":284,"state":"open","locked":false,"title":"Add tests for if/then/else with indices + unknown label;","user":{"login":"bnjbvr","id":1180019,"avatar_url":"https://avatars.githubusercontent.com/u/1180019?v=3","gravatar_id":"","url":"https://api.github.com/users/bnjbvr","html_url":"https://github.com/bnjbvr","followers_url":"https://api.github.com/users/bnjbvr/followers","following_url":"https://api.github.com/users/bnjbvr/following{/other_user}","gists_url":"https://api.github.com/users/bnjbvr/gists{/gist_id}","starred_url":"https://api.github.com/users/bnjbvr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnjbvr/subscriptions","organizations_url":"https://api.github.com/users/bnjbvr/orgs","repos_url":"https://api.github.com/users/bnjbvr/repos","events_url":"https://api.github.com/users/bnjbvr/events{/privacy}","received_events_url":"https://api.github.com/users/bnjbvr/received_events","type":"User","site_admin":false},"body":"Hi! I'd like to add test cases we ran into in our implementation and which could be useful for others:\r\n\r\n- a test for if/then/else where the depths are not labels, but raw integer indices.\r\n- a test for if/then/else where the label target of a `br` in the `else` is the label of the `then` block.\r\n\r\nUnfortunately, the second test (at the end of the file) doesn't work: the parser complains that the label `$l` is unknown, which is exactly what we are testing here. The correct behavior would be to silently swallow the error and consider the test as passed. Am I missing something here?","created_at":"2016-05-10T16:24:00Z","updated_at":"2016-05-13T12:18:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"131f4217d2c144b5885713c096a193c4a4735a32","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/WebAssembly/spec/pulls/284/commits","review_comments_url":"https://api.github.com/repos/WebAssembly/spec/pulls/284/comments","review_comment_url":"https://api.github.com/repos/WebAssembly/spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WebAssembly/spec/issues/284/comments","statuses_url":"https://api.github.com/repos/WebAssembly/spec/statuses/e5e2123bc9a19536289e85d044be587b65a13a8d","head":{"label":"bnjbvr:add-test-label-not-found","ref":"add-test-label-not-found","sha":"e5e2123bc9a19536289e85d044be587b65a13a8d","user":{"login":"bnjbvr","id":1180019,"avatar_url":"https://avatars.githubusercontent.com/u/1180019?v=3","gravatar_id":"","url":"https://api.github.com/users/bnjbvr","html_url":"https://github.com/bnjbvr","followers_url":"https://api.github.com/users/bnjbvr/followers","following_url":"https://api.github.com/users/bnjbvr/following{/other_user}","gists_url":"https://api.github.com/users/bnjbvr/gists{/gist_id}","starred_url":"https://api.github.com/users/bnjbvr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnjbvr/subscriptions","organizations_url":"https://api.github.com/users/bnjbvr/orgs","repos_url":"https://api.github.com/users/bnjbvr/repos","events_url":"https://api.github.com/users/bnjbvr/events{/privacy}","received_events_url":"https://api.github.com/users/bnjbvr/received_events","type":"User","site_admin":false},"repo":{"id":58455713,"name":"webassembly-spec","full_name":"bnjbvr/webassembly-spec","owner":{"login":"bnjbvr","id":1180019,"avatar_url":"https://avatars.githubusercontent.com/u/1180019?v=3","gravatar_id":"","url":"https://api.github.com/users/bnjbvr","html_url":"https://github.com/bnjbvr","followers_url":"https://api.github.com/users/bnjbvr/followers","following_url":"https://api.github.com/users/bnjbvr/following{/other_user}","gists_url":"https://api.github.com/users/bnjbvr/gists{/gist_id}","starred_url":"https://api.github.com/users/bnjbvr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnjbvr/subscriptions","organizations_url":"https://api.github.com/users/bnjbvr/orgs","repos_url":"https://api.github.com/users/bnjbvr/repos","events_url":"https://api.github.com/users/bnjbvr/events{/privacy}","received_events_url":"https://api.github.com/users/bnjbvr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bnjbvr/webassembly-spec","description":"Staging ground for artifacts related to an MVP spec","fork":true,"url":"https://api.github.com/repos/bnjbvr/webassembly-spec","forks_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/forks","keys_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/teams","hooks_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/hooks","issue_events_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/issues/events{/number}","events_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/events","assignees_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/assignees{/user}","branches_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/branches{/branch}","tags_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/tags","blobs_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/languages","stargazers_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/stargazers","contributors_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/contributors","subscribers_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/subscribers","subscription_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/subscription","commits_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/contents/{+path}","compare_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/merges","archive_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/downloads","issues_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/issues{/number}","pulls_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/labels{/name}","releases_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/releases{/id}","deployments_url":"https://api.github.com/repos/bnjbvr/webassembly-spec/deployments","created_at":"2016-05-10T11:29:22Z","updated_at":"2016-05-10T11:29:53Z","pushed_at":"2016-05-13T12:18:27Z","git_url":"git://github.com/bnjbvr/webassembly-spec.git","ssh_url":"git@github.com:bnjbvr/webassembly-spec.git","clone_url":"https://github.com/bnjbvr/webassembly-spec.git","svn_url":"https://github.com/bnjbvr/webassembly-spec","homepage":"http://webassembly.github.io/","size":1050,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"WebAssembly:master","ref":"master","sha":"790b699e4953865dabe7b998d17a36631efa3091","user":{"login":"WebAssembly","id":11578470,"avatar_url":"https://avatars.githubusercontent.com/u/11578470?v=3","gravatar_id":"","url":"https://api.github.com/users/WebAssembly","html_url":"https://github.com/WebAssembly","followers_url":"https://api.github.com/users/WebAssembly/followers","following_url":"https://api.github.com/users/WebAssembly/following{/other_user}","gists_url":"https://api.github.com/users/WebAssembly/gists{/gist_id}","starred_url":"https://api.github.com/users/WebAssembly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebAssembly/subscriptions","organizations_url":"https://api.github.com/users/WebAssembly/orgs","repos_url":"https://api.github.com/users/WebAssembly/repos","events_url":"https://api.github.com/users/WebAssembly/events{/privacy}","received_events_url":"https://api.github.com/users/WebAssembly/received_events","type":"Organization","site_admin":false},"repo":{"id":40598815,"name":"spec","full_name":"WebAssembly/spec","owner":{"login":"WebAssembly","id":11578470,"avatar_url":"https://avatars.githubusercontent.com/u/11578470?v=3","gravatar_id":"","url":"https://api.github.com/users/WebAssembly","html_url":"https://github.com/WebAssembly","followers_url":"https://api.github.com/users/WebAssembly/followers","following_url":"https://api.github.com/users/WebAssembly/following{/other_user}","gists_url":"https://api.github.com/users/WebAssembly/gists{/gist_id}","starred_url":"https://api.github.com/users/WebAssembly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebAssembly/subscriptions","organizations_url":"https://api.github.com/users/WebAssembly/orgs","repos_url":"https://api.github.com/users/WebAssembly/repos","events_url":"https://api.github.com/users/WebAssembly/events{/privacy}","received_events_url":"https://api.github.com/users/WebAssembly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WebAssembly/spec","description":"Staging ground for artifacts related to an MVP spec","fork":false,"url":"https://api.github.com/repos/WebAssembly/spec","forks_url":"https://api.github.com/repos/WebAssembly/spec/forks","keys_url":"https://api.github.com/repos/WebAssembly/spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WebAssembly/spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WebAssembly/spec/teams","hooks_url":"https://api.github.com/repos/WebAssembly/spec/hooks","issue_events_url":"https://api.github.com/repos/WebAssembly/spec/issues/events{/number}","events_url":"https://api.github.com/repos/WebAssembly/spec/events","assignees_url":"https://api.github.com/repos/WebAssembly/spec/assignees{/user}","branches_url":"https://api.github.com/repos/WebAssembly/spec/branches{/branch}","tags_url":"https://api.github.com/repos/WebAssembly/spec/tags","blobs_url":"https://api.github.com/repos/WebAssembly/spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WebAssembly/spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WebAssembly/spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/WebAssembly/spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WebAssembly/spec/statuses/{sha}","languages_url":"https://api.github.com/repos/WebAssembly/spec/languages","stargazers_url":"https://api.github.com/repos/WebAssembly/spec/stargazers","contributors_url":"https://api.github.com/repos/WebAssembly/spec/contributors","subscribers_url":"https://api.github.com/repos/WebAssembly/spec/subscribers","subscription_url":"https://api.github.com/repos/WebAssembly/spec/subscription","commits_url":"https://api.github.com/repos/WebAssembly/spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/WebAssembly/spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/WebAssembly/spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/WebAssembly/spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/WebAssembly/spec/contents/{+path}","compare_url":"https://api.github.com/repos/WebAssembly/spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WebAssembly/spec/merges","archive_url":"https://api.github.com/repos/WebAssembly/spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WebAssembly/spec/downloads","issues_url":"https://api.github.com/repos/WebAssembly/spec/issues{/number}","pulls_url":"https://api.github.com/repos/WebAssembly/spec/pulls{/number}","milestones_url":"https://api.github.com/repos/WebAssembly/spec/milestones{/number}","notifications_url":"https://api.github.com/repos/WebAssembly/spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WebAssembly/spec/labels{/name}","releases_url":"https://api.github.com/repos/WebAssembly/spec/releases{/id}","deployments_url":"https://api.github.com/repos/WebAssembly/spec/deployments","created_at":"2015-08-12T12:15:16Z","updated_at":"2016-05-12T19:18:04Z","pushed_at":"2016-05-13T12:18:28Z","git_url":"git://github.com/WebAssembly/spec.git","ssh_url":"git@github.com:WebAssembly/spec.git","clone_url":"https://github.com/WebAssembly/spec.git","svn_url":"https://github.com/WebAssembly/spec","homepage":"http://webassembly.github.io/","size":1195,"stargazers_count":304,"watchers_count":304,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":15,"forks":43,"open_issues":15,"watchers":304,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WebAssembly/spec/pulls/284"},"html":{"href":"https://github.com/WebAssembly/spec/pull/284"},"issue":{"href":"https://api.github.com/repos/WebAssembly/spec/issues/284"},"comments":{"href":"https://api.github.com/repos/WebAssembly/spec/issues/284/comments"},"review_comments":{"href":"https://api.github.com/repos/WebAssembly/spec/pulls/284/comments"},"review_comment":{"href":"https://api.github.com/repos/WebAssembly/spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WebAssembly/spec/pulls/284/commits"},"statuses":{"href":"https://api.github.com/repos/WebAssembly/spec/statuses/e5e2123bc9a19536289e85d044be587b65a13a8d"}}}}