{"action":"created","comment":{"url":"https://api.github.com/repos/faunadb/faunadb-jvm/pulls/comments/65405724","id":65405724,"diff_hunk":"@@ -0,0 +1,69 @@\n+package com.faunadb.client.query;\n+\n+import com.fasterxml.jackson.annotation.JsonValue;\n+import com.faunadb.client.types.Value;\n+import com.google.common.collect.ImmutableMap;\n+\n+import java.util.Map;\n+\n+import static java.lang.String.format;\n+\n+class Fn extends Expr.Literal {","path":"faunadb-java/src/main/java/com/faunadb/client/query/Fn.java","position":11,"original_position":11,"commit_id":"df0f5b43ce4a02c73efd72a682c1c93c49227e1e","original_commit_id":"df0f5b43ce4a02c73efd72a682c1c93c49227e1e","user":{"login":"freels","id":1407,"avatar_url":"https://avatars.githubusercontent.com/u/1407?v=3","gravatar_id":"","url":"https://api.github.com/users/freels","html_url":"https://github.com/freels","followers_url":"https://api.github.com/users/freels/followers","following_url":"https://api.github.com/users/freels/following{/other_user}","gists_url":"https://api.github.com/users/freels/gists{/gist_id}","starred_url":"https://api.github.com/users/freels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freels/subscriptions","organizations_url":"https://api.github.com/users/freels/orgs","repos_url":"https://api.github.com/users/freels/repos","events_url":"https://api.github.com/users/freels/events{/privacy}","received_events_url":"https://api.github.com/users/freels/received_events","type":"User","site_admin":false},"body":"Functions are not Literals.","created_at":"2016-06-01T17:28:13Z","updated_at":"2016-06-01T17:28:13Z","html_url":"https://github.com/faunadb/faunadb-jvm/pull/35#discussion_r65405724","pull_request_url":"https://api.github.com/repos/faunadb/faunadb-jvm/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/faunadb/faunadb-jvm/pulls/comments/65405724"},"html":{"href":"https://github.com/faunadb/faunadb-jvm/pull/35#discussion_r65405724"},"pull_request":{"href":"https://api.github.com/repos/faunadb/faunadb-jvm/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/faunadb/faunadb-jvm/pulls/35","id":71915165,"html_url":"https://github.com/faunadb/faunadb-jvm/pull/35","diff_url":"https://github.com/faunadb/faunadb-jvm/pull/35.diff","patch_url":"https://github.com/faunadb/faunadb-jvm/pull/35.patch","issue_url":"https://api.github.com/repos/faunadb/faunadb-jvm/issues/35","number":35,"state":"open","locked":false,"title":"Reviewing query language semantics","user":{"login":"erickpintor","id":813042,"avatar_url":"https://avatars.githubusercontent.com/u/813042?v=3","gravatar_id":"","url":"https://api.github.com/users/erickpintor","html_url":"https://github.com/erickpintor","followers_url":"https://api.github.com/users/erickpintor/followers","following_url":"https://api.github.com/users/erickpintor/following{/other_user}","gists_url":"https://api.github.com/users/erickpintor/gists{/gist_id}","starred_url":"https://api.github.com/users/erickpintor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erickpintor/subscriptions","organizations_url":"https://api.github.com/users/erickpintor/orgs","repos_url":"https://api.github.com/users/erickpintor/repos","events_url":"https://api.github.com/users/erickpintor/events{/privacy}","received_events_url":"https://api.github.com/users/erickpintor/received_events","type":"User","site_admin":false},"body":"I think this branch is ready for a review. I am really sorry for the huge pull request. \r\nThis is a whole query language semantics review and I couldn't find a productive incremental process to follow.\r\n\r\n----\r\nMajor changes:\r\n- Makes FaunaClient implements AutoCloseable\r\n- Convert enumerations to Java Enums\r\n- Removing old representation classes. Everything is JSON now.\r\n- Refactoring tests\r\n\r\nImplementing expression based DSL, similar to Scala DSL:\r\n- Seamless coercion between expressions and values\r\n- Implementing pagination as an expression instead of a builder\r\n- Implementing overloads for primitive values when necessary\r\n- Implementing missing Query API functions\r\n- Accepting regular Java collections as parameters\r\n\r\nImproving Fauna values types:\r\n- Refactoring values abstract classes to simplify concrete implementations\r\n- Implementing methods to walk through objects and arrays\r\n- Failing coercion on type mismatch rather than returning null\r\n- Provide safe coercion methods with optional types\r\n- Refactoring values codecs\r\n\r\nImproving LazyValue coercion:\r\n- Caching converted value\r\n- Using Fauna types to convert values","created_at":"2016-05-30T15:23:17Z","updated_at":"2016-06-01T17:28:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b2f3c7ff7b46d1bcc3b0c98d1a153840efe277c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/faunadb/faunadb-jvm/pulls/35/commits","review_comments_url":"https://api.github.com/repos/faunadb/faunadb-jvm/pulls/35/comments","review_comment_url":"https://api.github.com/repos/faunadb/faunadb-jvm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/faunadb/faunadb-jvm/issues/35/comments","statuses_url":"https://api.github.com/repos/faunadb/faunadb-jvm/statuses/df0f5b43ce4a02c73efd72a682c1c93c49227e1e","head":{"label":"faunadb:jvm_syntax","ref":"jvm_syntax","sha":"df0f5b43ce4a02c73efd72a682c1c93c49227e1e","user":{"login":"faunadb","id":1477000,"avatar_url":"https://avatars.githubusercontent.com/u/1477000?v=3","gravatar_id":"","url":"https://api.github.com/users/faunadb","html_url":"https://github.com/faunadb","followers_url":"https://api.github.com/users/faunadb/followers","following_url":"https://api.github.com/users/faunadb/following{/other_user}","gists_url":"https://api.github.com/users/faunadb/gists{/gist_id}","starred_url":"https://api.github.com/users/faunadb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faunadb/subscriptions","organizations_url":"https://api.github.com/users/faunadb/orgs","repos_url":"https://api.github.com/users/faunadb/repos","events_url":"https://api.github.com/users/faunadb/events{/privacy}","received_events_url":"https://api.github.com/users/faunadb/received_events","type":"Organization","site_admin":false},"repo":{"id":27624737,"name":"faunadb-jvm","full_name":"faunadb/faunadb-jvm","owner":{"login":"faunadb","id":1477000,"avatar_url":"https://avatars.githubusercontent.com/u/1477000?v=3","gravatar_id":"","url":"https://api.github.com/users/faunadb","html_url":"https://github.com/faunadb","followers_url":"https://api.github.com/users/faunadb/followers","following_url":"https://api.github.com/users/faunadb/following{/other_user}","gists_url":"https://api.github.com/users/faunadb/gists{/gist_id}","starred_url":"https://api.github.com/users/faunadb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faunadb/subscriptions","organizations_url":"https://api.github.com/users/faunadb/orgs","repos_url":"https://api.github.com/users/faunadb/repos","events_url":"https://api.github.com/users/faunadb/events{/privacy}","received_events_url":"https://api.github.com/users/faunadb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/faunadb/faunadb-jvm","description":"Scala and Java client for FaunaDB","fork":false,"url":"https://api.github.com/repos/faunadb/faunadb-jvm","forks_url":"https://api.github.com/repos/faunadb/faunadb-jvm/forks","keys_url":"https://api.github.com/repos/faunadb/faunadb-jvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/faunadb/faunadb-jvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/faunadb/faunadb-jvm/teams","hooks_url":"https://api.github.com/repos/faunadb/faunadb-jvm/hooks","issue_events_url":"https://api.github.com/repos/faunadb/faunadb-jvm/issues/events{/number}","events_url":"https://api.github.com/repos/faunadb/faunadb-jvm/events","assignees_url":"https://api.github.com/repos/faunadb/faunadb-jvm/assignees{/user}","branches_url":"https://api.github.com/repos/faunadb/faunadb-jvm/branches{/branch}","tags_url":"https://api.github.com/repos/faunadb/faunadb-jvm/tags","blobs_url":"https://api.github.com/repos/faunadb/faunadb-jvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/faunadb/faunadb-jvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/faunadb/faunadb-jvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/faunadb/faunadb-jvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/faunadb/faunadb-jvm/statuses/{sha}","languages_url":"https://api.github.com/repos/faunadb/faunadb-jvm/languages","stargazers_url":"https://api.github.com/repos/faunadb/faunadb-jvm/stargazers","contributors_url":"https://api.github.com/repos/faunadb/faunadb-jvm/contributors","subscribers_url":"https://api.github.com/repos/faunadb/faunadb-jvm/subscribers","subscription_url":"https://api.github.com/repos/faunadb/faunadb-jvm/subscription","commits_url":"https://api.github.com/repos/faunadb/faunadb-jvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/faunadb/faunadb-jvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/faunadb/faunadb-jvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/faunadb/faunadb-jvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/faunadb/faunadb-jvm/contents/{+path}","compare_url":"https://api.github.com/repos/faunadb/faunadb-jvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/faunadb/faunadb-jvm/merges","archive_url":"https://api.github.com/repos/faunadb/faunadb-jvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/faunadb/faunadb-jvm/downloads","issues_url":"https://api.github.com/repos/faunadb/faunadb-jvm/issues{/number}","pulls_url":"https://api.github.com/repos/faunadb/faunadb-jvm/pulls{/number}","milestones_url":"https://api.github.com/repos/faunadb/faunadb-jvm/milestones{/number}","notifications_url":"https://api.github.com/repos/faunadb/faunadb-jvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/faunadb/faunadb-jvm/labels{/name}","releases_url":"https://api.github.com/repos/faunadb/faunadb-jvm/releases{/id}","deployments_url":"https://api.github.com/repos/faunadb/faunadb-jvm/deployments","created_at":"2014-12-06T06:23:42Z","updated_at":"2016-01-30T01:12:30Z","pushed_at":"2016-05-31T13:06:58Z","git_url":"git://github.com/faunadb/faunadb-jvm.git","ssh_url":"git@github.com:faunadb/faunadb-jvm.git","clone_url":"https://github.com/faunadb/faunadb-jvm.git","svn_url":"https://github.com/faunadb/faunadb-jvm","homepage":"https://faunadb.com","size":1214,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"faunadb:master","ref":"master","sha":"2525b04967aafc933c61b5b4317eebcb60611a69","user":{"login":"faunadb","id":1477000,"avatar_url":"https://avatars.githubusercontent.com/u/1477000?v=3","gravatar_id":"","url":"https://api.github.com/users/faunadb","html_url":"https://github.com/faunadb","followers_url":"https://api.github.com/users/faunadb/followers","following_url":"https://api.github.com/users/faunadb/following{/other_user}","gists_url":"https://api.github.com/users/faunadb/gists{/gist_id}","starred_url":"https://api.github.com/users/faunadb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faunadb/subscriptions","organizations_url":"https://api.github.com/users/faunadb/orgs","repos_url":"https://api.github.com/users/faunadb/repos","events_url":"https://api.github.com/users/faunadb/events{/privacy}","received_events_url":"https://api.github.com/users/faunadb/received_events","type":"Organization","site_admin":false},"repo":{"id":27624737,"name":"faunadb-jvm","full_name":"faunadb/faunadb-jvm","owner":{"login":"faunadb","id":1477000,"avatar_url":"https://avatars.githubusercontent.com/u/1477000?v=3","gravatar_id":"","url":"https://api.github.com/users/faunadb","html_url":"https://github.com/faunadb","followers_url":"https://api.github.com/users/faunadb/followers","following_url":"https://api.github.com/users/faunadb/following{/other_user}","gists_url":"https://api.github.com/users/faunadb/gists{/gist_id}","starred_url":"https://api.github.com/users/faunadb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faunadb/subscriptions","organizations_url":"https://api.github.com/users/faunadb/orgs","repos_url":"https://api.github.com/users/faunadb/repos","events_url":"https://api.github.com/users/faunadb/events{/privacy}","received_events_url":"https://api.github.com/users/faunadb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/faunadb/faunadb-jvm","description":"Scala and Java client for FaunaDB","fork":false,"url":"https://api.github.com/repos/faunadb/faunadb-jvm","forks_url":"https://api.github.com/repos/faunadb/faunadb-jvm/forks","keys_url":"https://api.github.com/repos/faunadb/faunadb-jvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/faunadb/faunadb-jvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/faunadb/faunadb-jvm/teams","hooks_url":"https://api.github.com/repos/faunadb/faunadb-jvm/hooks","issue_events_url":"https://api.github.com/repos/faunadb/faunadb-jvm/issues/events{/number}","events_url":"https://api.github.com/repos/faunadb/faunadb-jvm/events","assignees_url":"https://api.github.com/repos/faunadb/faunadb-jvm/assignees{/user}","branches_url":"https://api.github.com/repos/faunadb/faunadb-jvm/branches{/branch}","tags_url":"https://api.github.com/repos/faunadb/faunadb-jvm/tags","blobs_url":"https://api.github.com/repos/faunadb/faunadb-jvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/faunadb/faunadb-jvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/faunadb/faunadb-jvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/faunadb/faunadb-jvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/faunadb/faunadb-jvm/statuses/{sha}","languages_url":"https://api.github.com/repos/faunadb/faunadb-jvm/languages","stargazers_url":"https://api.github.com/repos/faunadb/faunadb-jvm/stargazers","contributors_url":"https://api.github.com/repos/faunadb/faunadb-jvm/contributors","subscribers_url":"https://api.github.com/repos/faunadb/faunadb-jvm/subscribers","subscription_url":"https://api.github.com/repos/faunadb/faunadb-jvm/subscription","commits_url":"https://api.github.com/repos/faunadb/faunadb-jvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/faunadb/faunadb-jvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/faunadb/faunadb-jvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/faunadb/faunadb-jvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/faunadb/faunadb-jvm/contents/{+path}","compare_url":"https://api.github.com/repos/faunadb/faunadb-jvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/faunadb/faunadb-jvm/merges","archive_url":"https://api.github.com/repos/faunadb/faunadb-jvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/faunadb/faunadb-jvm/downloads","issues_url":"https://api.github.com/repos/faunadb/faunadb-jvm/issues{/number}","pulls_url":"https://api.github.com/repos/faunadb/faunadb-jvm/pulls{/number}","milestones_url":"https://api.github.com/repos/faunadb/faunadb-jvm/milestones{/number}","notifications_url":"https://api.github.com/repos/faunadb/faunadb-jvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/faunadb/faunadb-jvm/labels{/name}","releases_url":"https://api.github.com/repos/faunadb/faunadb-jvm/releases{/id}","deployments_url":"https://api.github.com/repos/faunadb/faunadb-jvm/deployments","created_at":"2014-12-06T06:23:42Z","updated_at":"2016-01-30T01:12:30Z","pushed_at":"2016-05-31T13:06:58Z","git_url":"git://github.com/faunadb/faunadb-jvm.git","ssh_url":"git@github.com:faunadb/faunadb-jvm.git","clone_url":"https://github.com/faunadb/faunadb-jvm.git","svn_url":"https://github.com/faunadb/faunadb-jvm","homepage":"https://faunadb.com","size":1214,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/faunadb/faunadb-jvm/pulls/35"},"html":{"href":"https://github.com/faunadb/faunadb-jvm/pull/35"},"issue":{"href":"https://api.github.com/repos/faunadb/faunadb-jvm/issues/35"},"comments":{"href":"https://api.github.com/repos/faunadb/faunadb-jvm/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/faunadb/faunadb-jvm/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/faunadb/faunadb-jvm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/faunadb/faunadb-jvm/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/faunadb/faunadb-jvm/statuses/df0f5b43ce4a02c73efd72a682c1c93c49227e1e"}}}}
{"actor":{"display_login":"freels"}}