{"action":"opened","number":1543,"pull_request":{"url":"https://api.github.com/repos/hyperledger/fabric/pulls/1543","id":70918293,"html_url":"https://github.com/hyperledger/fabric/pull/1543","diff_url":"https://github.com/hyperledger/fabric/pull/1543.diff","patch_url":"https://github.com/hyperledger/fabric/pull/1543.patch","issue_url":"https://api.github.com/repos/hyperledger/fabric/issues/1543","number":1543,"state":"open","locked":false,"title":"Fixes 1509 address lint issues membersrvc/ca/tlsca.go","user":{"login":"JonathanLevi","id":1161321,"avatar_url":"https://avatars.githubusercontent.com/u/1161321?v=3","gravatar_id":"","url":"https://api.github.com/users/JonathanLevi","html_url":"https://github.com/JonathanLevi","followers_url":"https://api.github.com/users/JonathanLevi/followers","following_url":"https://api.github.com/users/JonathanLevi/following{/other_user}","gists_url":"https://api.github.com/users/JonathanLevi/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathanLevi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathanLevi/subscriptions","organizations_url":"https://api.github.com/users/JonathanLevi/orgs","repos_url":"https://api.github.com/users/JonathanLevi/repos","events_url":"https://api.github.com/users/JonathanLevi/events{/privacy}","received_events_url":"https://api.github.com/users/JonathanLevi/received_events","type":"User","site_admin":false},"body":"Address lint errors \r\n## Description\r\n- Addressing each lint issue in tlsca.go (listed out in #[1286](https://github.com/hyperledger/fabric/issues/1286))\r\n\r\n\r\n## Motivation and Context\r\n\r\nWe are \"joining forces\" to improve on a few key code quality measures - and lint warnings/errors is one of these measures.\r\n\r\nFixes  #[1509](https://github.com/hyperledger/fabric/issues/1509)\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- If this PR does not contain a new test case, explain why. -->\r\n`golint + make all\r\n`\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have added a [Signed-off-by](https://github.com/hyperledger/fabric/blob/master/CONTRIBUTING.md#legal-stuff)\r\n- [x] Either no new documentation is required by this change, OR I added new documentation\r\n- [x] Either no new tests are required by this change, OR I added new tests\r\n- [x] I have run [goimports](https://godoc.org/golang.org/x/tools/cmd/goimports), [go vet](https://golang.org/cmd/vet/), and [golint](https://github.com/golang/lint). I have cleaned up all valid errors and warnings in code I have added or modified. These tools may generate false positives. Don't be worried about ignoring some errors or warnings. The goal is clean, consistent, and readable code.\r\n\r\nSigned-off-by: JonathanLevi\r\n","created_at":"2016-05-20T21:14:47Z","updated_at":"2016-05-20T21:14:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/fabric/pulls/1543/commits","review_comments_url":"https://api.github.com/repos/hyperledger/fabric/pulls/1543/comments","review_comment_url":"https://api.github.com/repos/hyperledger/fabric/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/fabric/issues/1543/comments","statuses_url":"https://api.github.com/repos/hyperledger/fabric/statuses/fa8fb97f6920a8a5670497c5dbb7e2986dd61196","head":{"label":"JonathanLevi:tlsca_lint_issues","ref":"tlsca_lint_issues","sha":"fa8fb97f6920a8a5670497c5dbb7e2986dd61196","user":{"login":"JonathanLevi","id":1161321,"avatar_url":"https://avatars.githubusercontent.com/u/1161321?v=3","gravatar_id":"","url":"https://api.github.com/users/JonathanLevi","html_url":"https://github.com/JonathanLevi","followers_url":"https://api.github.com/users/JonathanLevi/followers","following_url":"https://api.github.com/users/JonathanLevi/following{/other_user}","gists_url":"https://api.github.com/users/JonathanLevi/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathanLevi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathanLevi/subscriptions","organizations_url":"https://api.github.com/users/JonathanLevi/orgs","repos_url":"https://api.github.com/users/JonathanLevi/repos","events_url":"https://api.github.com/users/JonathanLevi/events{/privacy}","received_events_url":"https://api.github.com/users/JonathanLevi/received_events","type":"User","site_admin":false},"repo":{"id":59249918,"name":"fabric","full_name":"JonathanLevi/fabric","owner":{"login":"JonathanLevi","id":1161321,"avatar_url":"https://avatars.githubusercontent.com/u/1161321?v=3","gravatar_id":"","url":"https://api.github.com/users/JonathanLevi","html_url":"https://github.com/JonathanLevi","followers_url":"https://api.github.com/users/JonathanLevi/followers","following_url":"https://api.github.com/users/JonathanLevi/following{/other_user}","gists_url":"https://api.github.com/users/JonathanLevi/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathanLevi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathanLevi/subscriptions","organizations_url":"https://api.github.com/users/JonathanLevi/orgs","repos_url":"https://api.github.com/users/JonathanLevi/repos","events_url":"https://api.github.com/users/JonathanLevi/events{/privacy}","received_events_url":"https://api.github.com/users/JonathanLevi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JonathanLevi/fabric","description":"Fabric is a blockchain project in Incubation proposed to the community and documented at https://goo.gl/RYQZ5N.  Information on what Incubation entails can be found in the Hyperledger Project Lifecycle document (https://goo.gl/4edNRc)","fork":true,"url":"https://api.github.com/repos/JonathanLevi/fabric","forks_url":"https://api.github.com/repos/JonathanLevi/fabric/forks","keys_url":"https://api.github.com/repos/JonathanLevi/fabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JonathanLevi/fabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JonathanLevi/fabric/teams","hooks_url":"https://api.github.com/repos/JonathanLevi/fabric/hooks","issue_events_url":"https://api.github.com/repos/JonathanLevi/fabric/issues/events{/number}","events_url":"https://api.github.com/repos/JonathanLevi/fabric/events","assignees_url":"https://api.github.com/repos/JonathanLevi/fabric/assignees{/user}","branches_url":"https://api.github.com/repos/JonathanLevi/fabric/branches{/branch}","tags_url":"https://api.github.com/repos/JonathanLevi/fabric/tags","blobs_url":"https://api.github.com/repos/JonathanLevi/fabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JonathanLevi/fabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JonathanLevi/fabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/JonathanLevi/fabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JonathanLevi/fabric/statuses/{sha}","languages_url":"https://api.github.com/repos/JonathanLevi/fabric/languages","stargazers_url":"https://api.github.com/repos/JonathanLevi/fabric/stargazers","contributors_url":"https://api.github.com/repos/JonathanLevi/fabric/contributors","subscribers_url":"https://api.github.com/repos/JonathanLevi/fabric/subscribers","subscription_url":"https://api.github.com/repos/JonathanLevi/fabric/subscription","commits_url":"https://api.github.com/repos/JonathanLevi/fabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/JonathanLevi/fabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/JonathanLevi/fabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/JonathanLevi/fabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/JonathanLevi/fabric/contents/{+path}","compare_url":"https://api.github.com/repos/JonathanLevi/fabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JonathanLevi/fabric/merges","archive_url":"https://api.github.com/repos/JonathanLevi/fabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JonathanLevi/fabric/downloads","issues_url":"https://api.github.com/repos/JonathanLevi/fabric/issues{/number}","pulls_url":"https://api.github.com/repos/JonathanLevi/fabric/pulls{/number}","milestones_url":"https://api.github.com/repos/JonathanLevi/fabric/milestones{/number}","notifications_url":"https://api.github.com/repos/JonathanLevi/fabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JonathanLevi/fabric/labels{/name}","releases_url":"https://api.github.com/repos/JonathanLevi/fabric/releases{/id}","deployments_url":"https://api.github.com/repos/JonathanLevi/fabric/deployments","created_at":"2016-05-19T23:24:37Z","updated_at":"2016-05-19T23:24:39Z","pushed_at":"2016-05-20T21:10:38Z","git_url":"git://github.com/JonathanLevi/fabric.git","ssh_url":"git@github.com:JonathanLevi/fabric.git","clone_url":"https://github.com/JonathanLevi/fabric.git","svn_url":"https://github.com/JonathanLevi/fabric","homepage":"","size":42146,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hyperledger:master","ref":"master","sha":"66ca505deb06f4df024f0540d18bfdecb04584fa","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars.githubusercontent.com/u/7657900?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":42975662,"name":"fabric","full_name":"hyperledger/fabric","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars.githubusercontent.com/u/7657900?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/fabric","description":"Fabric is a blockchain project in Incubation proposed to the community and documented at https://goo.gl/RYQZ5N.  Information on what Incubation entails can be found in the Hyperledger Project Lifecycle document (https://goo.gl/4edNRc)","fork":false,"url":"https://api.github.com/repos/hyperledger/fabric","forks_url":"https://api.github.com/repos/hyperledger/fabric/forks","keys_url":"https://api.github.com/repos/hyperledger/fabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/fabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/fabric/teams","hooks_url":"https://api.github.com/repos/hyperledger/fabric/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/fabric/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/fabric/events","assignees_url":"https://api.github.com/repos/hyperledger/fabric/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/fabric/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/fabric/tags","blobs_url":"https://api.github.com/repos/hyperledger/fabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/fabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/fabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/fabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/fabric/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/fabric/languages","stargazers_url":"https://api.github.com/repos/hyperledger/fabric/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/fabric/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/fabric/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/fabric/subscription","commits_url":"https://api.github.com/repos/hyperledger/fabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/fabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/fabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/fabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/fabric/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/fabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/fabric/merges","archive_url":"https://api.github.com/repos/hyperledger/fabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/fabric/downloads","issues_url":"https://api.github.com/repos/hyperledger/fabric/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/fabric/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/fabric/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/fabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/fabric/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/fabric/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/fabric/deployments","created_at":"2015-09-23T03:17:14Z","updated_at":"2016-05-20T19:35:56Z","pushed_at":"2016-05-20T20:19:41Z","git_url":"git://github.com/hyperledger/fabric.git","ssh_url":"git@github.com:hyperledger/fabric.git","clone_url":"https://github.com/hyperledger/fabric.git","svn_url":"https://github.com/hyperledger/fabric","homepage":"","size":73218,"stargazers_count":672,"watchers_count":672,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":520,"mirror_url":null,"open_issues_count":278,"forks":520,"open_issues":278,"watchers":672,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/fabric/pulls/1543"},"html":{"href":"https://github.com/hyperledger/fabric/pull/1543"},"issue":{"href":"https://api.github.com/repos/hyperledger/fabric/issues/1543"},"comments":{"href":"https://api.github.com/repos/hyperledger/fabric/issues/1543/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/fabric/pulls/1543/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/fabric/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/fabric/pulls/1543/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/fabric/statuses/fa8fb97f6920a8a5670497c5dbb7e2986dd61196"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":6,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"JonathanLevi"}}