{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/jest/pulls/comments/70226405","id":70226405,"diff_hunk":"@@ -10,27 +10,37 @@\n \n 'use strict';\n \n-import type {ThrowingMatcherFn, ExpectationResult} from '../types';\n+import type {\n+  Expect,\n+  ExpectationResult,\n+  ExpectationObject,\n+  MatchersObject,\n+  RawMatcherFn,\n+  ThrowingMatcherFn,\n+} from '../types';\n \n const matchers = require('./matchers');\n+const GLOBAL_MATCHERS_OBJECT_KEY = '_JEST_MATCHERS';\n+global[GLOBAL_MATCHERS_OBJECT_KEY] = {};","path":"packages/jest-matchers/src/index.js","position":16,"original_position":16,"commit_id":"4a8b525cdc7cddebc3fc072e33e2d1cdd254d220","original_commit_id":"4a8b525cdc7cddebc3fc072e33e2d1cdd254d220","user":{"login":"cpojer","id":13352,"avatar_url":"https://avatars.githubusercontent.com/u/13352?v=3","gravatar_id":"","url":"https://api.github.com/users/cpojer","html_url":"https://github.com/cpojer","followers_url":"https://api.github.com/users/cpojer/followers","following_url":"https://api.github.com/users/cpojer/following{/other_user}","gists_url":"https://api.github.com/users/cpojer/gists{/gist_id}","starred_url":"https://api.github.com/users/cpojer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpojer/subscriptions","organizations_url":"https://api.github.com/users/cpojer/orgs","repos_url":"https://api.github.com/users/cpojer/repos","events_url":"https://api.github.com/users/cpojer/events{/privacy}","received_events_url":"https://api.github.com/users/cpojer/received_events","type":"User","site_admin":false},"body":"I don't understand why we need this global object? Can it not just be a module-local variable?","created_at":"2016-07-11T09:27:20Z","updated_at":"2016-07-11T09:27:20Z","html_url":"https://github.com/facebook/jest/pull/1276#discussion_r70226405","pull_request_url":"https://api.github.com/repos/facebook/jest/pulls/1276","_links":{"self":{"href":"https://api.github.com/repos/facebook/jest/pulls/comments/70226405"},"html":{"href":"https://github.com/facebook/jest/pull/1276#discussion_r70226405"},"pull_request":{"href":"https://api.github.com/repos/facebook/jest/pulls/1276"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/jest/pulls/1276","id":76858763,"html_url":"https://github.com/facebook/jest/pull/1276","diff_url":"https://github.com/facebook/jest/pull/1276.diff","patch_url":"https://github.com/facebook/jest/pull/1276.patch","issue_url":"https://api.github.com/repos/facebook/jest/issues/1276","number":1276,"state":"open","locked":false,"title":"jest-matchers#addMatchers","user":{"login":"dmitriiabramov","id":940133,"avatar_url":"https://avatars.githubusercontent.com/u/940133?v=3","gravatar_id":"","url":"https://api.github.com/users/dmitriiabramov","html_url":"https://github.com/dmitriiabramov","followers_url":"https://api.github.com/users/dmitriiabramov/followers","following_url":"https://api.github.com/users/dmitriiabramov/following{/other_user}","gists_url":"https://api.github.com/users/dmitriiabramov/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitriiabramov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitriiabramov/subscriptions","organizations_url":"https://api.github.com/users/dmitriiabramov/orgs","repos_url":"https://api.github.com/users/dmitriiabramov/repos","events_url":"https://api.github.com/users/dmitriiabramov/events{/privacy}","received_events_url":"https://api.github.com/users/dmitriiabramov/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-09T22:29:24Z","updated_at":"2016-07-11T09:27:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd656eca97c8e66265c86b0e6715350bdc82cd5c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/jest/pulls/1276/commits","review_comments_url":"https://api.github.com/repos/facebook/jest/pulls/1276/comments","review_comment_url":"https://api.github.com/repos/facebook/jest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/jest/issues/1276/comments","statuses_url":"https://api.github.com/repos/facebook/jest/statuses/4a8b525cdc7cddebc3fc072e33e2d1cdd254d220","head":{"label":"dmitriiabramov:jest-matchers-add-matchers","ref":"jest-matchers-add-matchers","sha":"4a8b525cdc7cddebc3fc072e33e2d1cdd254d220","user":{"login":"dmitriiabramov","id":940133,"avatar_url":"https://avatars.githubusercontent.com/u/940133?v=3","gravatar_id":"","url":"https://api.github.com/users/dmitriiabramov","html_url":"https://github.com/dmitriiabramov","followers_url":"https://api.github.com/users/dmitriiabramov/followers","following_url":"https://api.github.com/users/dmitriiabramov/following{/other_user}","gists_url":"https://api.github.com/users/dmitriiabramov/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitriiabramov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitriiabramov/subscriptions","organizations_url":"https://api.github.com/users/dmitriiabramov/orgs","repos_url":"https://api.github.com/users/dmitriiabramov/repos","events_url":"https://api.github.com/users/dmitriiabramov/events{/privacy}","received_events_url":"https://api.github.com/users/dmitriiabramov/received_events","type":"User","site_admin":false},"repo":{"id":53916097,"name":"jest","full_name":"dmitriiabramov/jest","owner":{"login":"dmitriiabramov","id":940133,"avatar_url":"https://avatars.githubusercontent.com/u/940133?v=3","gravatar_id":"","url":"https://api.github.com/users/dmitriiabramov","html_url":"https://github.com/dmitriiabramov","followers_url":"https://api.github.com/users/dmitriiabramov/followers","following_url":"https://api.github.com/users/dmitriiabramov/following{/other_user}","gists_url":"https://api.github.com/users/dmitriiabramov/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitriiabramov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitriiabramov/subscriptions","organizations_url":"https://api.github.com/users/dmitriiabramov/orgs","repos_url":"https://api.github.com/users/dmitriiabramov/repos","events_url":"https://api.github.com/users/dmitriiabramov/events{/privacy}","received_events_url":"https://api.github.com/users/dmitriiabramov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmitriiabramov/jest","description":"Painless JavaScript Unit Testing.","fork":true,"url":"https://api.github.com/repos/dmitriiabramov/jest","forks_url":"https://api.github.com/repos/dmitriiabramov/jest/forks","keys_url":"https://api.github.com/repos/dmitriiabramov/jest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmitriiabramov/jest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmitriiabramov/jest/teams","hooks_url":"https://api.github.com/repos/dmitriiabramov/jest/hooks","issue_events_url":"https://api.github.com/repos/dmitriiabramov/jest/issues/events{/number}","events_url":"https://api.github.com/repos/dmitriiabramov/jest/events","assignees_url":"https://api.github.com/repos/dmitriiabramov/jest/assignees{/user}","branches_url":"https://api.github.com/repos/dmitriiabramov/jest/branches{/branch}","tags_url":"https://api.github.com/repos/dmitriiabramov/jest/tags","blobs_url":"https://api.github.com/repos/dmitriiabramov/jest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmitriiabramov/jest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmitriiabramov/jest/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmitriiabramov/jest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmitriiabramov/jest/statuses/{sha}","languages_url":"https://api.github.com/repos/dmitriiabramov/jest/languages","stargazers_url":"https://api.github.com/repos/dmitriiabramov/jest/stargazers","contributors_url":"https://api.github.com/repos/dmitriiabramov/jest/contributors","subscribers_url":"https://api.github.com/repos/dmitriiabramov/jest/subscribers","subscription_url":"https://api.github.com/repos/dmitriiabramov/jest/subscription","commits_url":"https://api.github.com/repos/dmitriiabramov/jest/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmitriiabramov/jest/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmitriiabramov/jest/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmitriiabramov/jest/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmitriiabramov/jest/contents/{+path}","compare_url":"https://api.github.com/repos/dmitriiabramov/jest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmitriiabramov/jest/merges","archive_url":"https://api.github.com/repos/dmitriiabramov/jest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmitriiabramov/jest/downloads","issues_url":"https://api.github.com/repos/dmitriiabramov/jest/issues{/number}","pulls_url":"https://api.github.com/repos/dmitriiabramov/jest/pulls{/number}","milestones_url":"https://api.github.com/repos/dmitriiabramov/jest/milestones{/number}","notifications_url":"https://api.github.com/repos/dmitriiabramov/jest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmitriiabramov/jest/labels{/name}","releases_url":"https://api.github.com/repos/dmitriiabramov/jest/releases{/id}","deployments_url":"https://api.github.com/repos/dmitriiabramov/jest/deployments","created_at":"2016-03-15T05:01:11Z","updated_at":"2016-03-15T05:01:12Z","pushed_at":"2016-07-09T22:32:36Z","git_url":"git://github.com/dmitriiabramov/jest.git","ssh_url":"git@github.com:dmitriiabramov/jest.git","clone_url":"https://github.com/dmitriiabramov/jest.git","svn_url":"https://github.com/dmitriiabramov/jest","homepage":"http://facebook.github.io/jest/","size":3497,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"404635e4869ce96f939d231ef155e98e3542dbe7","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":15062869,"name":"jest","full_name":"facebook/jest","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/jest","description":"Painless JavaScript Unit Testing.","fork":false,"url":"https://api.github.com/repos/facebook/jest","forks_url":"https://api.github.com/repos/facebook/jest/forks","keys_url":"https://api.github.com/repos/facebook/jest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/jest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/jest/teams","hooks_url":"https://api.github.com/repos/facebook/jest/hooks","issue_events_url":"https://api.github.com/repos/facebook/jest/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/jest/events","assignees_url":"https://api.github.com/repos/facebook/jest/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/jest/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/jest/tags","blobs_url":"https://api.github.com/repos/facebook/jest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/jest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/jest/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/jest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/jest/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/jest/languages","stargazers_url":"https://api.github.com/repos/facebook/jest/stargazers","contributors_url":"https://api.github.com/repos/facebook/jest/contributors","subscribers_url":"https://api.github.com/repos/facebook/jest/subscribers","subscription_url":"https://api.github.com/repos/facebook/jest/subscription","commits_url":"https://api.github.com/repos/facebook/jest/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/jest/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/jest/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/jest/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/jest/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/jest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/jest/merges","archive_url":"https://api.github.com/repos/facebook/jest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/jest/downloads","issues_url":"https://api.github.com/repos/facebook/jest/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/jest/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/jest/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/jest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/jest/labels{/name}","releases_url":"https://api.github.com/repos/facebook/jest/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/jest/deployments","created_at":"2013-12-10T00:18:04Z","updated_at":"2016-07-11T08:15:18Z","pushed_at":"2016-07-11T09:15:56Z","git_url":"git://github.com/facebook/jest.git","ssh_url":"git@github.com:facebook/jest.git","clone_url":"https://github.com/facebook/jest.git","svn_url":"https://github.com/facebook/jest","homepage":"http://facebook.github.io/jest/","size":5424,"stargazers_count":4272,"watchers_count":4272,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":538,"mirror_url":null,"open_issues_count":51,"forks":538,"open_issues":51,"watchers":4272,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/jest/pulls/1276"},"html":{"href":"https://github.com/facebook/jest/pull/1276"},"issue":{"href":"https://api.github.com/repos/facebook/jest/issues/1276"},"comments":{"href":"https://api.github.com/repos/facebook/jest/issues/1276/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/jest/pulls/1276/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/jest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/jest/pulls/1276/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/jest/statuses/4a8b525cdc7cddebc3fc072e33e2d1cdd254d220"}}}}
{"actor":{"display_login":"cpojer"}}