{"action":"opened","number":1604,"pull_request":{"url":"https://api.github.com/repos/eclipse/vert.x/pulls/1604","id":83895236,"html_url":"https://github.com/eclipse/vert.x/pull/1604","diff_url":"https://github.com/eclipse/vert.x/pull/1604.diff","patch_url":"https://github.com/eclipse/vert.x/pull/1604.patch","issue_url":"https://api.github.com/repos/eclipse/vert.x/issues/1604","number":1604,"state":"open","locked":false,"title":"fixes #1602: NetClient with SOCKS Proxy checks wrong hostname on upgradeToSsl()","user":{"login":"alexlehm","id":156144,"avatar_url":"https://avatars.githubusercontent.com/u/156144?v=3","gravatar_id":"","url":"https://api.github.com/users/alexlehm","html_url":"https://github.com/alexlehm","followers_url":"https://api.github.com/users/alexlehm/followers","following_url":"https://api.github.com/users/alexlehm/following{/other_user}","gists_url":"https://api.github.com/users/alexlehm/gists{/gist_id}","starred_url":"https://api.github.com/users/alexlehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexlehm/subscriptions","organizations_url":"https://api.github.com/users/alexlehm/orgs","repos_url":"https://api.github.com/users/alexlehm/repos","events_url":"https://api.github.com/users/alexlehm/events{/privacy}","received_events_url":"https://api.github.com/users/alexlehm/received_events","type":"User","site_admin":false},"body":"this is a rather unlikely usecase when connecting with a SOCKS proxy to a service that requires upgradeToSsl\r\ne.g. STARTTLS in SMTP, since the ssl helper is constructed with the target address of the tcp connection, the cert is checked against the proxy address (e.g. localhost) instead of the actual address (e.g. smtp.gmail.com)\r\n","created_at":"2016-09-03T13:04:57Z","updated_at":"2016-09-03T13:04:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd6305b060ee565bfa4443441de81ea18894cdbf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/vert.x/pulls/1604/commits","review_comments_url":"https://api.github.com/repos/eclipse/vert.x/pulls/1604/comments","review_comment_url":"https://api.github.com/repos/eclipse/vert.x/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/vert.x/issues/1604/comments","statuses_url":"https://api.github.com/repos/eclipse/vert.x/statuses/a861d5faefb4e5e9f02c535f1f42f2b2b316386c","head":{"label":"alexlehm:issues/#1602-socks-ssl","ref":"issues/#1602-socks-ssl","sha":"a861d5faefb4e5e9f02c535f1f42f2b2b316386c","user":{"login":"alexlehm","id":156144,"avatar_url":"https://avatars.githubusercontent.com/u/156144?v=3","gravatar_id":"","url":"https://api.github.com/users/alexlehm","html_url":"https://github.com/alexlehm","followers_url":"https://api.github.com/users/alexlehm/followers","following_url":"https://api.github.com/users/alexlehm/following{/other_user}","gists_url":"https://api.github.com/users/alexlehm/gists{/gist_id}","starred_url":"https://api.github.com/users/alexlehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexlehm/subscriptions","organizations_url":"https://api.github.com/users/alexlehm/orgs","repos_url":"https://api.github.com/users/alexlehm/repos","events_url":"https://api.github.com/users/alexlehm/events{/privacy}","received_events_url":"https://api.github.com/users/alexlehm/received_events","type":"User","site_admin":false},"repo":{"id":18156124,"name":"vert.x","full_name":"alexlehm/vert.x","owner":{"login":"alexlehm","id":156144,"avatar_url":"https://avatars.githubusercontent.com/u/156144?v=3","gravatar_id":"","url":"https://api.github.com/users/alexlehm","html_url":"https://github.com/alexlehm","followers_url":"https://api.github.com/users/alexlehm/followers","following_url":"https://api.github.com/users/alexlehm/following{/other_user}","gists_url":"https://api.github.com/users/alexlehm/gists{/gist_id}","starred_url":"https://api.github.com/users/alexlehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexlehm/subscriptions","organizations_url":"https://api.github.com/users/alexlehm/orgs","repos_url":"https://api.github.com/users/alexlehm/repos","events_url":"https://api.github.com/users/alexlehm/events{/privacy}","received_events_url":"https://api.github.com/users/alexlehm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexlehm/vert.x","description":"vert.x - The scalable polyglot application platform for the JVM","fork":true,"url":"https://api.github.com/repos/alexlehm/vert.x","forks_url":"https://api.github.com/repos/alexlehm/vert.x/forks","keys_url":"https://api.github.com/repos/alexlehm/vert.x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexlehm/vert.x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexlehm/vert.x/teams","hooks_url":"https://api.github.com/repos/alexlehm/vert.x/hooks","issue_events_url":"https://api.github.com/repos/alexlehm/vert.x/issues/events{/number}","events_url":"https://api.github.com/repos/alexlehm/vert.x/events","assignees_url":"https://api.github.com/repos/alexlehm/vert.x/assignees{/user}","branches_url":"https://api.github.com/repos/alexlehm/vert.x/branches{/branch}","tags_url":"https://api.github.com/repos/alexlehm/vert.x/tags","blobs_url":"https://api.github.com/repos/alexlehm/vert.x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexlehm/vert.x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexlehm/vert.x/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexlehm/vert.x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexlehm/vert.x/statuses/{sha}","languages_url":"https://api.github.com/repos/alexlehm/vert.x/languages","stargazers_url":"https://api.github.com/repos/alexlehm/vert.x/stargazers","contributors_url":"https://api.github.com/repos/alexlehm/vert.x/contributors","subscribers_url":"https://api.github.com/repos/alexlehm/vert.x/subscribers","subscription_url":"https://api.github.com/repos/alexlehm/vert.x/subscription","commits_url":"https://api.github.com/repos/alexlehm/vert.x/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexlehm/vert.x/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexlehm/vert.x/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexlehm/vert.x/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexlehm/vert.x/contents/{+path}","compare_url":"https://api.github.com/repos/alexlehm/vert.x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexlehm/vert.x/merges","archive_url":"https://api.github.com/repos/alexlehm/vert.x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexlehm/vert.x/downloads","issues_url":"https://api.github.com/repos/alexlehm/vert.x/issues{/number}","pulls_url":"https://api.github.com/repos/alexlehm/vert.x/pulls{/number}","milestones_url":"https://api.github.com/repos/alexlehm/vert.x/milestones{/number}","notifications_url":"https://api.github.com/repos/alexlehm/vert.x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexlehm/vert.x/labels{/name}","releases_url":"https://api.github.com/repos/alexlehm/vert.x/releases{/id}","deployments_url":"https://api.github.com/repos/alexlehm/vert.x/deployments","created_at":"2014-03-26T22:24:48Z","updated_at":"2016-04-17T15:56:48Z","pushed_at":"2016-09-03T12:26:22Z","git_url":"git://github.com/alexlehm/vert.x.git","ssh_url":"git@github.com:alexlehm/vert.x.git","clone_url":"https://github.com/alexlehm/vert.x.git","svn_url":"https://github.com/alexlehm/vert.x","homepage":"http://vertx.io","size":95675,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"1adf3f020e91bf4525f5b5fe0120d5e04f5c1d14","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":1911523,"name":"vert.x","full_name":"eclipse/vert.x","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/vert.x","description":"Vert.x is a tool-kit for building reactive applications on the JVM","fork":false,"url":"https://api.github.com/repos/eclipse/vert.x","forks_url":"https://api.github.com/repos/eclipse/vert.x/forks","keys_url":"https://api.github.com/repos/eclipse/vert.x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/vert.x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/vert.x/teams","hooks_url":"https://api.github.com/repos/eclipse/vert.x/hooks","issue_events_url":"https://api.github.com/repos/eclipse/vert.x/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/vert.x/events","assignees_url":"https://api.github.com/repos/eclipse/vert.x/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/vert.x/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/vert.x/tags","blobs_url":"https://api.github.com/repos/eclipse/vert.x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/vert.x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/vert.x/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/vert.x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/vert.x/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/vert.x/languages","stargazers_url":"https://api.github.com/repos/eclipse/vert.x/stargazers","contributors_url":"https://api.github.com/repos/eclipse/vert.x/contributors","subscribers_url":"https://api.github.com/repos/eclipse/vert.x/subscribers","subscription_url":"https://api.github.com/repos/eclipse/vert.x/subscription","commits_url":"https://api.github.com/repos/eclipse/vert.x/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/vert.x/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/vert.x/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/vert.x/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/vert.x/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/vert.x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/vert.x/merges","archive_url":"https://api.github.com/repos/eclipse/vert.x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/vert.x/downloads","issues_url":"https://api.github.com/repos/eclipse/vert.x/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/vert.x/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/vert.x/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/vert.x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/vert.x/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/vert.x/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/vert.x/deployments","created_at":"2011-06-17T14:54:55Z","updated_at":"2016-09-02T08:59:50Z","pushed_at":"2016-09-03T13:04:57Z","git_url":"git://github.com/eclipse/vert.x.git","ssh_url":"git@github.com:eclipse/vert.x.git","clone_url":"https://github.com/eclipse/vert.x.git","svn_url":"https://github.com/eclipse/vert.x","homepage":"http://vertx.io","size":366740,"stargazers_count":5158,"watchers_count":5158,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":989,"mirror_url":null,"open_issues_count":106,"forks":989,"open_issues":106,"watchers":5158,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/vert.x/pulls/1604"},"html":{"href":"https://github.com/eclipse/vert.x/pull/1604"},"issue":{"href":"https://api.github.com/repos/eclipse/vert.x/issues/1604"},"comments":{"href":"https://api.github.com/repos/eclipse/vert.x/issues/1604/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/vert.x/pulls/1604/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/vert.x/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/vert.x/pulls/1604/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/vert.x/statuses/a861d5faefb4e5e9f02c535f1f42f2b2b316386c"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":94,"deletions":40,"changed_files":3}}
{"actor":{"display_login":"alexlehm"}}