{"action":"created","comment":{"url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments/53085624","id":53085624,"diff_hunk":"@@ -27,6 +27,19 @@\n class Cmfd;\n \n /**\n+ * @enum ringifyType\n+ * @brief The method to use when subdividing cells into rings\n+ */\n+enum ringifyType{\n+\n+  /** Max ring radius chosen such that it has the same area as the total geometry */\n+  EQUIVALENT_AREA,\n+\n+  /** Max ring radius chosen to be the distance from the center to a corner of the geometry */","path":"src/Geometry.h","position":12,"original_position":12,"commit_id":"3d884bd268be445f6b1e868f6bf8397c8f8c0d39","original_commit_id":"3d884bd268be445f6b1e868f6bf8397c8f8c0d39","user":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"body":"ditto","created_at":"2016-02-16T21:55:10Z","updated_at":"2016-02-16T21:55:10Z","html_url":"https://github.com/mit-crpg/OpenMOC/pull/268#discussion_r53085624","pull_request_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/268","_links":{"self":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments/53085624"},"html":{"href":"https://github.com/mit-crpg/OpenMOC/pull/268#discussion_r53085624"},"pull_request":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/268"}}},"pull_request":{"url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/268","id":59516795,"html_url":"https://github.com/mit-crpg/OpenMOC/pull/268","diff_url":"https://github.com/mit-crpg/OpenMOC/pull/268.diff","patch_url":"https://github.com/mit-crpg/OpenMOC/pull/268.patch","issue_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/268","number":268,"state":"open","locked":false,"title":"Ring radius extension","user":{"login":"friedmud","id":870705,"avatar_url":"https://avatars.githubusercontent.com/u/870705?v=3","gravatar_id":"","url":"https://api.github.com/users/friedmud","html_url":"https://github.com/friedmud","followers_url":"https://api.github.com/users/friedmud/followers","following_url":"https://api.github.com/users/friedmud/following{/other_user}","gists_url":"https://api.github.com/users/friedmud/gists{/gist_id}","starred_url":"https://api.github.com/users/friedmud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friedmud/subscriptions","organizations_url":"https://api.github.com/users/friedmud/orgs","repos_url":"https://api.github.com/users/friedmud/repos","events_url":"https://api.github.com/users/friedmud/events{/privacy}","received_events_url":"https://api.github.com/users/friedmud/received_events","type":"User","site_admin":false},"body":"When using rings to subdivide the moderator the rings won't reach all the way to the outer corners like so:\r\n\r\n![pasted image at 2016_02_15 07_07 pm](https://cloud.githubusercontent.com/assets/870705/13082935/c6e3ba66-d4a0-11e5-8dc4-dd3f448985ee.png)\r\n\r\nI've modified the selection of the maximum ring radius to allow for reaching the corners like so:\r\n\r\n![flat-source-regions-z-0 0](https://cloud.githubusercontent.com/assets/870705/13083030/4217184a-d4a1-11e5-9bb1-0eb2e343702a.png)\r\n","created_at":"2016-02-16T16:35:02Z","updated_at":"2016-02-16T21:55:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"726d76fecdc119308f0cad08a2d9fc1439f3a16d","assignee":{"login":"geogunow","id":2420416,"avatar_url":"https://avatars.githubusercontent.com/u/2420416?v=3","gravatar_id":"","url":"https://api.github.com/users/geogunow","html_url":"https://github.com/geogunow","followers_url":"https://api.github.com/users/geogunow/followers","following_url":"https://api.github.com/users/geogunow/following{/other_user}","gists_url":"https://api.github.com/users/geogunow/gists{/gist_id}","starred_url":"https://api.github.com/users/geogunow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geogunow/subscriptions","organizations_url":"https://api.github.com/users/geogunow/orgs","repos_url":"https://api.github.com/users/geogunow/repos","events_url":"https://api.github.com/users/geogunow/events{/privacy}","received_events_url":"https://api.github.com/users/geogunow/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/268/commits","review_comments_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/268/comments","review_comment_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/268/comments","statuses_url":"https://api.github.com/repos/mit-crpg/OpenMOC/statuses/3d884bd268be445f6b1e868f6bf8397c8f8c0d39","head":{"label":"friedmud:ring_radius","ref":"ring_radius","sha":"3d884bd268be445f6b1e868f6bf8397c8f8c0d39","user":{"login":"friedmud","id":870705,"avatar_url":"https://avatars.githubusercontent.com/u/870705?v=3","gravatar_id":"","url":"https://api.github.com/users/friedmud","html_url":"https://github.com/friedmud","followers_url":"https://api.github.com/users/friedmud/followers","following_url":"https://api.github.com/users/friedmud/following{/other_user}","gists_url":"https://api.github.com/users/friedmud/gists{/gist_id}","starred_url":"https://api.github.com/users/friedmud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friedmud/subscriptions","organizations_url":"https://api.github.com/users/friedmud/orgs","repos_url":"https://api.github.com/users/friedmud/repos","events_url":"https://api.github.com/users/friedmud/events{/privacy}","received_events_url":"https://api.github.com/users/friedmud/received_events","type":"User","site_admin":false},"repo":{"id":51778398,"name":"OpenMOC","full_name":"friedmud/OpenMOC","owner":{"login":"friedmud","id":870705,"avatar_url":"https://avatars.githubusercontent.com/u/870705?v=3","gravatar_id":"","url":"https://api.github.com/users/friedmud","html_url":"https://github.com/friedmud","followers_url":"https://api.github.com/users/friedmud/followers","following_url":"https://api.github.com/users/friedmud/following{/other_user}","gists_url":"https://api.github.com/users/friedmud/gists{/gist_id}","starred_url":"https://api.github.com/users/friedmud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friedmud/subscriptions","organizations_url":"https://api.github.com/users/friedmud/orgs","repos_url":"https://api.github.com/users/friedmud/repos","events_url":"https://api.github.com/users/friedmud/events{/privacy}","received_events_url":"https://api.github.com/users/friedmud/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/friedmud/OpenMOC","description":"A method of characteristics code for nuclear reactor physics calculations.","fork":true,"url":"https://api.github.com/repos/friedmud/OpenMOC","forks_url":"https://api.github.com/repos/friedmud/OpenMOC/forks","keys_url":"https://api.github.com/repos/friedmud/OpenMOC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/friedmud/OpenMOC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/friedmud/OpenMOC/teams","hooks_url":"https://api.github.com/repos/friedmud/OpenMOC/hooks","issue_events_url":"https://api.github.com/repos/friedmud/OpenMOC/issues/events{/number}","events_url":"https://api.github.com/repos/friedmud/OpenMOC/events","assignees_url":"https://api.github.com/repos/friedmud/OpenMOC/assignees{/user}","branches_url":"https://api.github.com/repos/friedmud/OpenMOC/branches{/branch}","tags_url":"https://api.github.com/repos/friedmud/OpenMOC/tags","blobs_url":"https://api.github.com/repos/friedmud/OpenMOC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/friedmud/OpenMOC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/friedmud/OpenMOC/git/refs{/sha}","trees_url":"https://api.github.com/repos/friedmud/OpenMOC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/friedmud/OpenMOC/statuses/{sha}","languages_url":"https://api.github.com/repos/friedmud/OpenMOC/languages","stargazers_url":"https://api.github.com/repos/friedmud/OpenMOC/stargazers","contributors_url":"https://api.github.com/repos/friedmud/OpenMOC/contributors","subscribers_url":"https://api.github.com/repos/friedmud/OpenMOC/subscribers","subscription_url":"https://api.github.com/repos/friedmud/OpenMOC/subscription","commits_url":"https://api.github.com/repos/friedmud/OpenMOC/commits{/sha}","git_commits_url":"https://api.github.com/repos/friedmud/OpenMOC/git/commits{/sha}","comments_url":"https://api.github.com/repos/friedmud/OpenMOC/comments{/number}","issue_comment_url":"https://api.github.com/repos/friedmud/OpenMOC/issues/comments{/number}","contents_url":"https://api.github.com/repos/friedmud/OpenMOC/contents/{+path}","compare_url":"https://api.github.com/repos/friedmud/OpenMOC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/friedmud/OpenMOC/merges","archive_url":"https://api.github.com/repos/friedmud/OpenMOC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/friedmud/OpenMOC/downloads","issues_url":"https://api.github.com/repos/friedmud/OpenMOC/issues{/number}","pulls_url":"https://api.github.com/repos/friedmud/OpenMOC/pulls{/number}","milestones_url":"https://api.github.com/repos/friedmud/OpenMOC/milestones{/number}","notifications_url":"https://api.github.com/repos/friedmud/OpenMOC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/friedmud/OpenMOC/labels{/name}","releases_url":"https://api.github.com/repos/friedmud/OpenMOC/releases{/id}","deployments_url":"https://api.github.com/repos/friedmud/OpenMOC/deployments","created_at":"2016-02-15T19:06:22Z","updated_at":"2016-02-15T19:06:23Z","pushed_at":"2016-02-16T21:48:32Z","git_url":"git://github.com/friedmud/OpenMOC.git","ssh_url":"git@github.com:friedmud/OpenMOC.git","clone_url":"https://github.com/friedmud/OpenMOC.git","svn_url":"https://github.com/friedmud/OpenMOC","homepage":"https://mit-crpg.github.io/OpenMOC/","size":110374,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"mit-crpg:develop","ref":"develop","sha":"e2314893efe716552c145fbf58782c29f3e6c2d7","user":{"login":"mit-crpg","id":1247634,"avatar_url":"https://avatars.githubusercontent.com/u/1247634?v=3","gravatar_id":"","url":"https://api.github.com/users/mit-crpg","html_url":"https://github.com/mit-crpg","followers_url":"https://api.github.com/users/mit-crpg/followers","following_url":"https://api.github.com/users/mit-crpg/following{/other_user}","gists_url":"https://api.github.com/users/mit-crpg/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-crpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-crpg/subscriptions","organizations_url":"https://api.github.com/users/mit-crpg/orgs","repos_url":"https://api.github.com/users/mit-crpg/repos","events_url":"https://api.github.com/users/mit-crpg/events{/privacy}","received_events_url":"https://api.github.com/users/mit-crpg/received_events","type":"Organization","site_admin":false},"repo":{"id":8780988,"name":"OpenMOC","full_name":"mit-crpg/OpenMOC","owner":{"login":"mit-crpg","id":1247634,"avatar_url":"https://avatars.githubusercontent.com/u/1247634?v=3","gravatar_id":"","url":"https://api.github.com/users/mit-crpg","html_url":"https://github.com/mit-crpg","followers_url":"https://api.github.com/users/mit-crpg/followers","following_url":"https://api.github.com/users/mit-crpg/following{/other_user}","gists_url":"https://api.github.com/users/mit-crpg/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-crpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-crpg/subscriptions","organizations_url":"https://api.github.com/users/mit-crpg/orgs","repos_url":"https://api.github.com/users/mit-crpg/repos","events_url":"https://api.github.com/users/mit-crpg/events{/privacy}","received_events_url":"https://api.github.com/users/mit-crpg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mit-crpg/OpenMOC","description":"A method of characteristics code for nuclear reactor physics calculations.","fork":false,"url":"https://api.github.com/repos/mit-crpg/OpenMOC","forks_url":"https://api.github.com/repos/mit-crpg/OpenMOC/forks","keys_url":"https://api.github.com/repos/mit-crpg/OpenMOC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mit-crpg/OpenMOC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mit-crpg/OpenMOC/teams","hooks_url":"https://api.github.com/repos/mit-crpg/OpenMOC/hooks","issue_events_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/events{/number}","events_url":"https://api.github.com/repos/mit-crpg/OpenMOC/events","assignees_url":"https://api.github.com/repos/mit-crpg/OpenMOC/assignees{/user}","branches_url":"https://api.github.com/repos/mit-crpg/OpenMOC/branches{/branch}","tags_url":"https://api.github.com/repos/mit-crpg/OpenMOC/tags","blobs_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/refs{/sha}","trees_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mit-crpg/OpenMOC/statuses/{sha}","languages_url":"https://api.github.com/repos/mit-crpg/OpenMOC/languages","stargazers_url":"https://api.github.com/repos/mit-crpg/OpenMOC/stargazers","contributors_url":"https://api.github.com/repos/mit-crpg/OpenMOC/contributors","subscribers_url":"https://api.github.com/repos/mit-crpg/OpenMOC/subscribers","subscription_url":"https://api.github.com/repos/mit-crpg/OpenMOC/subscription","commits_url":"https://api.github.com/repos/mit-crpg/OpenMOC/commits{/sha}","git_commits_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/commits{/sha}","comments_url":"https://api.github.com/repos/mit-crpg/OpenMOC/comments{/number}","issue_comment_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/comments{/number}","contents_url":"https://api.github.com/repos/mit-crpg/OpenMOC/contents/{+path}","compare_url":"https://api.github.com/repos/mit-crpg/OpenMOC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mit-crpg/OpenMOC/merges","archive_url":"https://api.github.com/repos/mit-crpg/OpenMOC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mit-crpg/OpenMOC/downloads","issues_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues{/number}","pulls_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls{/number}","milestones_url":"https://api.github.com/repos/mit-crpg/OpenMOC/milestones{/number}","notifications_url":"https://api.github.com/repos/mit-crpg/OpenMOC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mit-crpg/OpenMOC/labels{/name}","releases_url":"https://api.github.com/repos/mit-crpg/OpenMOC/releases{/id}","deployments_url":"https://api.github.com/repos/mit-crpg/OpenMOC/deployments","created_at":"2013-03-14T17:19:26Z","updated_at":"2016-02-12T23:37:19Z","pushed_at":"2016-02-16T21:48:32Z","git_url":"git://github.com/mit-crpg/OpenMOC.git","ssh_url":"git@github.com:mit-crpg/OpenMOC.git","clone_url":"https://github.com/mit-crpg/OpenMOC.git","svn_url":"https://github.com/mit-crpg/OpenMOC","homepage":"https://mit-crpg.github.io/OpenMOC/","size":132710,"stargazers_count":20,"watchers_count":20,"language":"Jupyter Notebook","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":27,"mirror_url":null,"open_issues_count":21,"forks":27,"open_issues":21,"watchers":20,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/268"},"html":{"href":"https://github.com/mit-crpg/OpenMOC/pull/268"},"issue":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/268"},"comments":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/268/comments"},"review_comments":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/268/comments"},"review_comment":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/268/commits"},"statuses":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/statuses/3d884bd268be445f6b1e868f6bf8397c8f8c0d39"}}}}