{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/74869341","id":74869341,"diff_hunk":"@@ -20,9 +20,17 @@ def get_version():\n     try:\n         for line in open(os.path.join(dir, \"ceph_ver.h\")):\n             if \"CEPH_GIT_NICE_VER\" in line:\n-                return line.split()[2][1:-1]\n+                l=line.split()[2].strip('\"')\n+                if len(l) > 1 and l[0] == 'v': l = l[1:]\n+                a=l.split(\"-\",2)\n+                if len(a) > 2:\n+                    return \"{}.post{}+{}\".format( a[0], a[1], a[2] )","path":"src/pybind/rbd/setup.py","position":23,"original_position":9,"commit_id":"20dfd6b9d506e15b24e8bf02ca9ce143c1cd3cfe","original_commit_id":"20dfd6b9d506e15b24e8bf02ca9ce143c1cd3cfe","user":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"body":"i think we can just use git version, i.e. x.y.z for the extension's version. and iiuc, we are not using the post version,\r\n\r\nquote from https://www.python.org/dev/peps/pep-0440/#post-releases\r\n> Some projects use post-releases to address minor errors in a final release that do not affect the distributed software (for example, correcting an error in the release notes).\r\n\r\n so X.postY.Z does not apply to our project, right?","created_at":"2016-08-16T02:49:44Z","updated_at":"2016-08-16T02:49:44Z","html_url":"https://github.com/ceph/ceph/pull/10696#discussion_r74869341","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/10696","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/74869341"},"html":{"href":"https://github.com/ceph/ceph/pull/10696#discussion_r74869341"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10696"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/10696","id":81019082,"html_url":"https://github.com/ceph/ceph/pull/10696","diff_url":"https://github.com/ceph/ceph/pull/10696.diff","patch_url":"https://github.com/ceph/ceph/pull/10696.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/10696","number":10696,"state":"open","locked":false,"title":"Wip buildfix python out of tree","user":{"login":"mdw-at-linuxbox","id":5238902,"avatar_url":"https://avatars.githubusercontent.com/u/5238902?v=3","gravatar_id":"","url":"https://api.github.com/users/mdw-at-linuxbox","html_url":"https://github.com/mdw-at-linuxbox","followers_url":"https://api.github.com/users/mdw-at-linuxbox/followers","following_url":"https://api.github.com/users/mdw-at-linuxbox/following{/other_user}","gists_url":"https://api.github.com/users/mdw-at-linuxbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mdw-at-linuxbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdw-at-linuxbox/subscriptions","organizations_url":"https://api.github.com/users/mdw-at-linuxbox/orgs","repos_url":"https://api.github.com/users/mdw-at-linuxbox/repos","events_url":"https://api.github.com/users/mdw-at-linuxbox/events{/privacy}","received_events_url":"https://api.github.com/users/mdw-at-linuxbox/received_events","type":"User","site_admin":false},"body":"[ More build fixes from STS - but! changes upstream makes these mostly obsolete.  PR for the sake of making this visible to the people who care, but I expect they will have some other fix they'd rather do instead. ]\r\n\r\nOriginally, these were 2 things: \"out of tree\" fixes for autoconf/automake, and python fixes for out of tree and other behaviors.  The automake stuff probably longer matters.\r\n\r\nSo the python fixes: people have been changing the behavior of src/pybind/*/setup.py to get rid of referencing ceph_ver.h - but the the fixes aren't very systematic and src/pybind/rbd/ still uses this (it's the last such reference).  My fix does include \"pep440\" changes, which you want if you want to use the ceph version from ceph_ver.h.  Also note rados get_ceph_version() which isn't used (and goes away here.)  It would be good to see a proper systematic fix (probably one that doesn't use ceph_ver.h).","created_at":"2016-08-11T19:48:37Z","updated_at":"2016-08-16T02:49:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2581c2361ddcb6deaf079556afa4dea4c5ba347","assignee":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"assignees":[{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/10696/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/10696/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/10696/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/20dfd6b9d506e15b24e8bf02ca9ce143c1cd3cfe","head":{"label":"ceph:wip-buildfix-python-out-of-tree","ref":"wip-buildfix-python-out-of-tree","sha":"20dfd6b9d506e15b24e8bf02ca9ce143c1cd3cfe","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-08-15T11:02:16Z","pushed_at":"2016-08-16T01:52:37Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":235087,"stargazers_count":2370,"watchers_count":2370,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1413,"mirror_url":null,"open_issues_count":454,"forks":1413,"open_issues":454,"watchers":2370,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"ec8e11f7fbb858e302a6f6598455e357a1a7fe24","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-08-15T11:02:16Z","pushed_at":"2016-08-16T01:52:37Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":235087,"stargazers_count":2370,"watchers_count":2370,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1413,"mirror_url":null,"open_issues_count":454,"forks":1413,"open_issues":454,"watchers":2370,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10696"},"html":{"href":"https://github.com/ceph/ceph/pull/10696"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/10696"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/10696/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10696/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10696/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/20dfd6b9d506e15b24e8bf02ca9ce143c1cd3cfe"}}}}
{"actor":{"display_login":"tchaikov"}}