{"action":"created","comment":{"url":"https://api.github.com/repos/neovim/neovim/pulls/comments/50639760","id":50639760,"diff_hunk":"@@ -3338,6 +3346,16 @@ win_line (\n             char_attr = hl_combine_attr(spell_attr, char_attr);\n         }\n \n+        if (has_bufhl && v > 0) {\n+          bufhl_attr = bufhl_get_attr(&bufhl_info, (colnr_T)v);\n+          if( bufhl_attr != 0) {\n+            if (!attr_pri)\n+              char_attr = hl_combine_attr(char_attr, bufhl_attr);\n+            else\n+              char_attr = hl_combine_attr(bufhl_attr, char_attr);\n+          }\n+        }","path":"src/nvim/screen.c","position":34,"original_position":34,"commit_id":"4cf4d2f2af363980bb57df4f2330d31c7df8435d","original_commit_id":"4cf4d2f2af363980bb57df4f2330d31c7df8435d","user":{"login":"justinmk","id":1359421,"avatar_url":"https://avatars.githubusercontent.com/u/1359421?v=3","gravatar_id":"","url":"https://api.github.com/users/justinmk","html_url":"https://github.com/justinmk","followers_url":"https://api.github.com/users/justinmk/followers","following_url":"https://api.github.com/users/justinmk/following{/other_user}","gists_url":"https://api.github.com/users/justinmk/gists{/gist_id}","starred_url":"https://api.github.com/users/justinmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinmk/subscriptions","organizations_url":"https://api.github.com/users/justinmk/orgs","repos_url":"https://api.github.com/users/justinmk/repos","events_url":"https://api.github.com/users/justinmk/events{/privacy}","received_events_url":"https://api.github.com/users/justinmk/received_events","type":"User","site_admin":false},"body":"Would be ideal to have only a single fucntion call here, something like `handle_has_bufhl`. This will help a lot when merging upstream changes.","created_at":"2016-01-24T18:36:22Z","updated_at":"2016-01-24T18:36:22Z","html_url":"https://github.com/neovim/neovim/pull/1817#discussion_r50639760","pull_request_url":"https://api.github.com/repos/neovim/neovim/pulls/1817","_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/50639760"},"html":{"href":"https://github.com/neovim/neovim/pull/1817#discussion_r50639760"},"pull_request":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1817"}}},"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/1817","id":27382852,"html_url":"https://github.com/neovim/neovim/pull/1817","diff_url":"https://github.com/neovim/neovim/pull/1817.diff","patch_url":"https://github.com/neovim/neovim/pull/1817.patch","issue_url":"https://api.github.com/repos/neovim/neovim/issues/1817","number":1817,"state":"open","locked":false,"title":"[RFC] support buffer-persistent highlighting by plugins","user":{"login":"bfredl","id":1363104,"avatar_url":"https://avatars.githubusercontent.com/u/1363104?v=3","gravatar_id":"","url":"https://api.github.com/users/bfredl","html_url":"https://github.com/bfredl","followers_url":"https://api.github.com/users/bfredl/followers","following_url":"https://api.github.com/users/bfredl/following{/other_user}","gists_url":"https://api.github.com/users/bfredl/gists{/gist_id}","starred_url":"https://api.github.com/users/bfredl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfredl/subscriptions","organizations_url":"https://api.github.com/users/bfredl/orgs","repos_url":"https://api.github.com/users/bfredl/repos","events_url":"https://api.github.com/users/bfredl/events{/privacy}","received_events_url":"https://api.github.com/users/bfredl/received_events","type":"User","site_admin":false},"body":"As discussed in #1767, this aims to implement a variant of `matchaddpos`, but matches tied to a specific buffer and not the current window.\r\nNo actual code for the feature yet, just started with cleanup/refactor of the exisiting code.","created_at":"2015-01-14T20:58:25Z","updated_at":"2016-01-24T18:36:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24097be841181492950f5cc0a42d9aa2f1603263","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neovim/neovim/pulls/1817/commits","review_comments_url":"https://api.github.com/repos/neovim/neovim/pulls/1817/comments","review_comment_url":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/1817/comments","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/4cf4d2f2af363980bb57df4f2330d31c7df8435d","head":{"label":"bfredl:bufmatch","ref":"bufmatch","sha":"4cf4d2f2af363980bb57df4f2330d31c7df8435d","user":{"login":"bfredl","id":1363104,"avatar_url":"https://avatars.githubusercontent.com/u/1363104?v=3","gravatar_id":"","url":"https://api.github.com/users/bfredl","html_url":"https://github.com/bfredl","followers_url":"https://api.github.com/users/bfredl/followers","following_url":"https://api.github.com/users/bfredl/following{/other_user}","gists_url":"https://api.github.com/users/bfredl/gists{/gist_id}","starred_url":"https://api.github.com/users/bfredl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfredl/subscriptions","organizations_url":"https://api.github.com/users/bfredl/orgs","repos_url":"https://api.github.com/users/bfredl/repos","events_url":"https://api.github.com/users/bfredl/events{/privacy}","received_events_url":"https://api.github.com/users/bfredl/received_events","type":"User","site_admin":false},"repo":{"id":21050434,"name":"neovim","full_name":"bfredl/neovim","owner":{"login":"bfredl","id":1363104,"avatar_url":"https://avatars.githubusercontent.com/u/1363104?v=3","gravatar_id":"","url":"https://api.github.com/users/bfredl","html_url":"https://github.com/bfredl","followers_url":"https://api.github.com/users/bfredl/followers","following_url":"https://api.github.com/users/bfredl/following{/other_user}","gists_url":"https://api.github.com/users/bfredl/gists{/gist_id}","starred_url":"https://api.github.com/users/bfredl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfredl/subscriptions","organizations_url":"https://api.github.com/users/bfredl/orgs","repos_url":"https://api.github.com/users/bfredl/repos","events_url":"https://api.github.com/users/bfredl/events{/privacy}","received_events_url":"https://api.github.com/users/bfredl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bfredl/neovim","description":"vim's rebirth for the 21st century","fork":true,"url":"https://api.github.com/repos/bfredl/neovim","forks_url":"https://api.github.com/repos/bfredl/neovim/forks","keys_url":"https://api.github.com/repos/bfredl/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bfredl/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bfredl/neovim/teams","hooks_url":"https://api.github.com/repos/bfredl/neovim/hooks","issue_events_url":"https://api.github.com/repos/bfredl/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/bfredl/neovim/events","assignees_url":"https://api.github.com/repos/bfredl/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/bfredl/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/bfredl/neovim/tags","blobs_url":"https://api.github.com/repos/bfredl/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bfredl/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bfredl/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/bfredl/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bfredl/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/bfredl/neovim/languages","stargazers_url":"https://api.github.com/repos/bfredl/neovim/stargazers","contributors_url":"https://api.github.com/repos/bfredl/neovim/contributors","subscribers_url":"https://api.github.com/repos/bfredl/neovim/subscribers","subscription_url":"https://api.github.com/repos/bfredl/neovim/subscription","commits_url":"https://api.github.com/repos/bfredl/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/bfredl/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/bfredl/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/bfredl/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/bfredl/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/bfredl/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bfredl/neovim/merges","archive_url":"https://api.github.com/repos/bfredl/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bfredl/neovim/downloads","issues_url":"https://api.github.com/repos/bfredl/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/bfredl/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/bfredl/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/bfredl/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bfredl/neovim/labels{/name}","releases_url":"https://api.github.com/repos/bfredl/neovim/releases{/id}","deployments_url":"https://api.github.com/repos/bfredl/neovim/deployments","created_at":"2014-06-20T19:51:31Z","updated_at":"2014-06-20T19:51:31Z","pushed_at":"2016-01-24T17:17:52Z","git_url":"git://github.com/bfredl/neovim.git","ssh_url":"git@github.com:bfredl/neovim.git","clone_url":"https://github.com/bfredl/neovim.git","svn_url":"https://github.com/bfredl/neovim","homepage":"http://neovim.org/","size":36309,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neovim:master","ref":"master","sha":"a15cfb4d52c5d9098da98059592d8ca79e03c5d9","user":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"repo":{"id":16408992,"name":"neovim","full_name":"neovim/neovim","owner":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neovim/neovim","description":"Vim-fork focused on extensibility and agility. Consider helping sustain Neovim development! ","fork":false,"url":"https://api.github.com/repos/neovim/neovim","forks_url":"https://api.github.com/repos/neovim/neovim/forks","keys_url":"https://api.github.com/repos/neovim/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neovim/neovim/teams","hooks_url":"https://api.github.com/repos/neovim/neovim/hooks","issue_events_url":"https://api.github.com/repos/neovim/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/neovim/neovim/events","assignees_url":"https://api.github.com/repos/neovim/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/neovim/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/neovim/neovim/tags","blobs_url":"https://api.github.com/repos/neovim/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neovim/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neovim/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/neovim/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/neovim/neovim/languages","stargazers_url":"https://api.github.com/repos/neovim/neovim/stargazers","contributors_url":"https://api.github.com/repos/neovim/neovim/contributors","subscribers_url":"https://api.github.com/repos/neovim/neovim/subscribers","subscription_url":"https://api.github.com/repos/neovim/neovim/subscription","commits_url":"https://api.github.com/repos/neovim/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/neovim/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/neovim/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/neovim/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/neovim/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/neovim/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neovim/neovim/merges","archive_url":"https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neovim/neovim/downloads","issues_url":"https://api.github.com/repos/neovim/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/neovim/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/neovim/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neovim/neovim/labels{/name}","releases_url":"https://api.github.com/repos/neovim/neovim/releases{/id}","deployments_url":"https://api.github.com/repos/neovim/neovim/deployments","created_at":"2014-01-31T13:39:22Z","updated_at":"2016-01-24T18:08:19Z","pushed_at":"2016-01-24T17:17:52Z","git_url":"git://github.com/neovim/neovim.git","ssh_url":"git@github.com:neovim/neovim.git","clone_url":"https://github.com/neovim/neovim.git","svn_url":"https://github.com/neovim/neovim","homepage":"https://salt.bountysource.com/teams/neovim","size":57580,"stargazers_count":17004,"watchers_count":17004,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1202,"mirror_url":null,"open_issues_count":628,"forks":1202,"open_issues":628,"watchers":17004,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1817"},"html":{"href":"https://github.com/neovim/neovim/pull/1817"},"issue":{"href":"https://api.github.com/repos/neovim/neovim/issues/1817"},"comments":{"href":"https://api.github.com/repos/neovim/neovim/issues/1817/comments"},"review_comments":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1817/comments"},"review_comment":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1817/commits"},"statuses":{"href":"https://api.github.com/repos/neovim/neovim/statuses/4cf4d2f2af363980bb57df4f2330d31c7df8435d"}}}}