{"action":"closed","number":836,"pull_request":{"url":"https://api.github.com/repos/typetools/checker-framework/pulls/836","id":77210977,"html_url":"https://github.com/typetools/checker-framework/pull/836","diff_url":"https://github.com/typetools/checker-framework/pull/836.diff","patch_url":"https://github.com/typetools/checker-framework/pull/836.patch","issue_url":"https://api.github.com/repos/typetools/checker-framework/issues/836","number":836,"state":"closed","locked":false,"title":"Refactor AnnotatedTypeFactory: Use lazy initialization in getSupportedTypeQualifiers()","user":{"login":"CharlesZ-Chen","id":7701109,"avatar_url":"https://avatars.githubusercontent.com/u/7701109?v=3","gravatar_id":"","url":"https://api.github.com/users/CharlesZ-Chen","html_url":"https://github.com/CharlesZ-Chen","followers_url":"https://api.github.com/users/CharlesZ-Chen/followers","following_url":"https://api.github.com/users/CharlesZ-Chen/following{/other_user}","gists_url":"https://api.github.com/users/CharlesZ-Chen/gists{/gist_id}","starred_url":"https://api.github.com/users/CharlesZ-Chen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CharlesZ-Chen/subscriptions","organizations_url":"https://api.github.com/users/CharlesZ-Chen/orgs","repos_url":"https://api.github.com/users/CharlesZ-Chen/repos","events_url":"https://api.github.com/users/CharlesZ-Chen/events{/privacy}","received_events_url":"https://api.github.com/users/CharlesZ-Chen/received_events","type":"User","site_admin":false},"body":"`AnnotatedTypeFactory#createSupportedTypeQualifiers()` is an overridable method, and should avoid using it in constructor.\r\n\r\nCurrently using it in constructor would cause NullPointer Exception in `InferenceAnnotatedTypeFactory#createSupportedTypeQualifiers()` if `InferenceAnnotatedTypeFactory` doesn't use the deprecated method `InferenceMain#getRealTypeFactory()`.\r\n\r\nAs a solution, I change code to create supported type qualifiers by using lazy initialization, i.e. creating an empty set for `supportedQuals` during constructor, and creating the real supported qualifiers when `AnnotatedTypeFactory#getSupportedTypeQualifiers()` get called.","created_at":"2016-07-12T23:57:37Z","updated_at":"2016-07-13T03:38:09Z","closed_at":"2016-07-13T03:38:09Z","merged_at":null,"merge_commit_sha":"9a894976dda853502292371b30ed67b895bc518a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/typetools/checker-framework/pulls/836/commits","review_comments_url":"https://api.github.com/repos/typetools/checker-framework/pulls/836/comments","review_comment_url":"https://api.github.com/repos/typetools/checker-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/typetools/checker-framework/issues/836/comments","statuses_url":"https://api.github.com/repos/typetools/checker-framework/statuses/a65d68ad8efd33d14a1473cdd3aa365275773011","head":{"label":"opprop:master","ref":"master","sha":"a65d68ad8efd33d14a1473cdd3aa365275773011","user":{"login":"opprop","id":20308424,"avatar_url":"https://avatars.githubusercontent.com/u/20308424?v=3","gravatar_id":"","url":"https://api.github.com/users/opprop","html_url":"https://github.com/opprop","followers_url":"https://api.github.com/users/opprop/followers","following_url":"https://api.github.com/users/opprop/following{/other_user}","gists_url":"https://api.github.com/users/opprop/gists{/gist_id}","starred_url":"https://api.github.com/users/opprop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opprop/subscriptions","organizations_url":"https://api.github.com/users/opprop/orgs","repos_url":"https://api.github.com/users/opprop/repos","events_url":"https://api.github.com/users/opprop/events{/privacy}","received_events_url":"https://api.github.com/users/opprop/received_events","type":"Organization","site_admin":false},"repo":{"id":62672535,"name":"checker-framework","full_name":"opprop/checker-framework","owner":{"login":"opprop","id":20308424,"avatar_url":"https://avatars.githubusercontent.com/u/20308424?v=3","gravatar_id":"","url":"https://api.github.com/users/opprop","html_url":"https://github.com/opprop","followers_url":"https://api.github.com/users/opprop/followers","following_url":"https://api.github.com/users/opprop/following{/other_user}","gists_url":"https://api.github.com/users/opprop/gists{/gist_id}","starred_url":"https://api.github.com/users/opprop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opprop/subscriptions","organizations_url":"https://api.github.com/users/opprop/orgs","repos_url":"https://api.github.com/users/opprop/repos","events_url":"https://api.github.com/users/opprop/events{/privacy}","received_events_url":"https://api.github.com/users/opprop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opprop/checker-framework","description":"Pluggable type-checking for Java","fork":true,"url":"https://api.github.com/repos/opprop/checker-framework","forks_url":"https://api.github.com/repos/opprop/checker-framework/forks","keys_url":"https://api.github.com/repos/opprop/checker-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opprop/checker-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opprop/checker-framework/teams","hooks_url":"https://api.github.com/repos/opprop/checker-framework/hooks","issue_events_url":"https://api.github.com/repos/opprop/checker-framework/issues/events{/number}","events_url":"https://api.github.com/repos/opprop/checker-framework/events","assignees_url":"https://api.github.com/repos/opprop/checker-framework/assignees{/user}","branches_url":"https://api.github.com/repos/opprop/checker-framework/branches{/branch}","tags_url":"https://api.github.com/repos/opprop/checker-framework/tags","blobs_url":"https://api.github.com/repos/opprop/checker-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opprop/checker-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opprop/checker-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/opprop/checker-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opprop/checker-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/opprop/checker-framework/languages","stargazers_url":"https://api.github.com/repos/opprop/checker-framework/stargazers","contributors_url":"https://api.github.com/repos/opprop/checker-framework/contributors","subscribers_url":"https://api.github.com/repos/opprop/checker-framework/subscribers","subscription_url":"https://api.github.com/repos/opprop/checker-framework/subscription","commits_url":"https://api.github.com/repos/opprop/checker-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/opprop/checker-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/opprop/checker-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/opprop/checker-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/opprop/checker-framework/contents/{+path}","compare_url":"https://api.github.com/repos/opprop/checker-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opprop/checker-framework/merges","archive_url":"https://api.github.com/repos/opprop/checker-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opprop/checker-framework/downloads","issues_url":"https://api.github.com/repos/opprop/checker-framework/issues{/number}","pulls_url":"https://api.github.com/repos/opprop/checker-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/opprop/checker-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/opprop/checker-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opprop/checker-framework/labels{/name}","releases_url":"https://api.github.com/repos/opprop/checker-framework/releases{/id}","deployments_url":"https://api.github.com/repos/opprop/checker-framework/deployments","created_at":"2016-07-05T22:01:30Z","updated_at":"2016-07-05T22:01:36Z","pushed_at":"2016-07-12T22:17:23Z","git_url":"git://github.com/opprop/checker-framework.git","ssh_url":"git@github.com:opprop/checker-framework.git","clone_url":"https://github.com/opprop/checker-framework.git","svn_url":"https://github.com/opprop/checker-framework","homepage":"http://checkerframework.org/","size":191605,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"typetools:master","ref":"master","sha":"204666d05c81443e82724405a67c71cfe3eaa3cd","user":{"login":"typetools","id":12883499,"avatar_url":"https://avatars.githubusercontent.com/u/12883499?v=3","gravatar_id":"","url":"https://api.github.com/users/typetools","html_url":"https://github.com/typetools","followers_url":"https://api.github.com/users/typetools/followers","following_url":"https://api.github.com/users/typetools/following{/other_user}","gists_url":"https://api.github.com/users/typetools/gists{/gist_id}","starred_url":"https://api.github.com/users/typetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typetools/subscriptions","organizations_url":"https://api.github.com/users/typetools/orgs","repos_url":"https://api.github.com/users/typetools/repos","events_url":"https://api.github.com/users/typetools/events{/privacy}","received_events_url":"https://api.github.com/users/typetools/received_events","type":"Organization","site_admin":false},"repo":{"id":38488726,"name":"checker-framework","full_name":"typetools/checker-framework","owner":{"login":"typetools","id":12883499,"avatar_url":"https://avatars.githubusercontent.com/u/12883499?v=3","gravatar_id":"","url":"https://api.github.com/users/typetools","html_url":"https://github.com/typetools","followers_url":"https://api.github.com/users/typetools/followers","following_url":"https://api.github.com/users/typetools/following{/other_user}","gists_url":"https://api.github.com/users/typetools/gists{/gist_id}","starred_url":"https://api.github.com/users/typetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typetools/subscriptions","organizations_url":"https://api.github.com/users/typetools/orgs","repos_url":"https://api.github.com/users/typetools/repos","events_url":"https://api.github.com/users/typetools/events{/privacy}","received_events_url":"https://api.github.com/users/typetools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/typetools/checker-framework","description":"Pluggable type-checking for Java","fork":false,"url":"https://api.github.com/repos/typetools/checker-framework","forks_url":"https://api.github.com/repos/typetools/checker-framework/forks","keys_url":"https://api.github.com/repos/typetools/checker-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/typetools/checker-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/typetools/checker-framework/teams","hooks_url":"https://api.github.com/repos/typetools/checker-framework/hooks","issue_events_url":"https://api.github.com/repos/typetools/checker-framework/issues/events{/number}","events_url":"https://api.github.com/repos/typetools/checker-framework/events","assignees_url":"https://api.github.com/repos/typetools/checker-framework/assignees{/user}","branches_url":"https://api.github.com/repos/typetools/checker-framework/branches{/branch}","tags_url":"https://api.github.com/repos/typetools/checker-framework/tags","blobs_url":"https://api.github.com/repos/typetools/checker-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/typetools/checker-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/typetools/checker-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/typetools/checker-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/typetools/checker-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/typetools/checker-framework/languages","stargazers_url":"https://api.github.com/repos/typetools/checker-framework/stargazers","contributors_url":"https://api.github.com/repos/typetools/checker-framework/contributors","subscribers_url":"https://api.github.com/repos/typetools/checker-framework/subscribers","subscription_url":"https://api.github.com/repos/typetools/checker-framework/subscription","commits_url":"https://api.github.com/repos/typetools/checker-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/typetools/checker-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/typetools/checker-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/typetools/checker-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/typetools/checker-framework/contents/{+path}","compare_url":"https://api.github.com/repos/typetools/checker-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/typetools/checker-framework/merges","archive_url":"https://api.github.com/repos/typetools/checker-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/typetools/checker-framework/downloads","issues_url":"https://api.github.com/repos/typetools/checker-framework/issues{/number}","pulls_url":"https://api.github.com/repos/typetools/checker-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/typetools/checker-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/typetools/checker-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/typetools/checker-framework/labels{/name}","releases_url":"https://api.github.com/repos/typetools/checker-framework/releases{/id}","deployments_url":"https://api.github.com/repos/typetools/checker-framework/deployments","created_at":"2015-07-03T11:09:17Z","updated_at":"2016-07-04T03:58:55Z","pushed_at":"2016-07-13T01:08:56Z","git_url":"git://github.com/typetools/checker-framework.git","ssh_url":"git@github.com:typetools/checker-framework.git","clone_url":"https://github.com/typetools/checker-framework.git","svn_url":"https://github.com/typetools/checker-framework","homepage":"http://checkerframework.org/","size":194842,"stargazers_count":125,"watchers_count":125,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":181,"forks":42,"open_issues":181,"watchers":125,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/typetools/checker-framework/pulls/836"},"html":{"href":"https://github.com/typetools/checker-framework/pull/836"},"issue":{"href":"https://api.github.com/repos/typetools/checker-framework/issues/836"},"comments":{"href":"https://api.github.com/repos/typetools/checker-framework/issues/836/comments"},"review_comments":{"href":"https://api.github.com/repos/typetools/checker-framework/pulls/836/comments"},"review_comment":{"href":"https://api.github.com/repos/typetools/checker-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/typetools/checker-framework/pulls/836/commits"},"statuses":{"href":"https://api.github.com/repos/typetools/checker-framework/statuses/a65d68ad8efd33d14a1473cdd3aa365275773011"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":16,"commits":19,"additions":111,"deletions":136,"changed_files":22}}
{"actor":{"display_login":"wmdietl"}}