{"action":"created","issue":{"url":"https://api.github.com/repos/substack/node-browserify/issues/1602","repository_url":"https://api.github.com/repos/substack/node-browserify","labels_url":"https://api.github.com/repos/substack/node-browserify/issues/1602/labels{/name}","comments_url":"https://api.github.com/repos/substack/node-browserify/issues/1602/comments","events_url":"https://api.github.com/repos/substack/node-browserify/issues/1602/events","html_url":"https://github.com/substack/node-browserify/pull/1602","id":169564769,"number":1602,"title":"Update glob dependency","user":{"login":"BBosman","id":5115488,"avatar_url":"https://avatars.githubusercontent.com/u/5115488?v=3","gravatar_id":"","url":"https://api.github.com/users/BBosman","html_url":"https://github.com/BBosman","followers_url":"https://api.github.com/users/BBosman/followers","following_url":"https://api.github.com/users/BBosman/following{/other_user}","gists_url":"https://api.github.com/users/BBosman/gists{/gist_id}","starred_url":"https://api.github.com/users/BBosman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BBosman/subscriptions","organizations_url":"https://api.github.com/users/BBosman/orgs","repos_url":"https://api.github.com/users/BBosman/repos","events_url":"https://api.github.com/users/BBosman/events{/privacy}","received_events_url":"https://api.github.com/users/BBosman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-08-05T09:17:40Z","updated_at":"2016-09-29T09:26:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/substack/node-browserify/pulls/1602","html_url":"https://github.com/substack/node-browserify/pull/1602","diff_url":"https://github.com/substack/node-browserify/pull/1602.diff","patch_url":"https://github.com/substack/node-browserify/pull/1602.patch"},"body":"Currently installing `browserify` gives a warning:\r\n\r\n```\r\nnpm WARN deprecated minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue\r\n```\r\n\r\nThis PR updates the `glob` dependency to the most recent version which uses an updated `minimatch` version as well.\r\n\r\nI ran the tests after the change and they all still pass."},"comment":{"url":"https://api.github.com/repos/substack/node-browserify/issues/comments/250415945","html_url":"https://github.com/substack/node-browserify/pull/1602#issuecomment-250415945","issue_url":"https://api.github.com/repos/substack/node-browserify/issues/1602","id":250415945,"user":{"login":"elieobeid7","id":660142,"avatar_url":"https://avatars.githubusercontent.com/u/660142?v=3","gravatar_id":"","url":"https://api.github.com/users/elieobeid7","html_url":"https://github.com/elieobeid7","followers_url":"https://api.github.com/users/elieobeid7/followers","following_url":"https://api.github.com/users/elieobeid7/following{/other_user}","gists_url":"https://api.github.com/users/elieobeid7/gists{/gist_id}","starred_url":"https://api.github.com/users/elieobeid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elieobeid7/subscriptions","organizations_url":"https://api.github.com/users/elieobeid7/orgs","repos_url":"https://api.github.com/users/elieobeid7/repos","events_url":"https://api.github.com/users/elieobeid7/events{/privacy}","received_events_url":"https://api.github.com/users/elieobeid7/received_events","type":"User","site_admin":false},"created_at":"2016-09-29T09:26:47Z","updated_at":"2016-09-29T09:26:47Z","body":"would you please update glob and push to master?\r\n\r\nI have this issue with cordova\r\n\r\nhttp://stackoverflow.com/questions/39727130/npm-warn-deprecated-minimatch2-0-10-but-i-have-a-newer-version\r\n\r\nI asked Cordova team on Jira about it, I opened a bug report, it was labeled as critical and they said that bug is because of you guys,  browserify hasn't updated to glob-7\r\n \r\nThis fix is so old an not merged yet, so many projects depend on this library so please merge. If you don't merge soon, I'm going to fork, update dependency and convince Cordova team to use my fork.\r\n"}}
{"actor":{"display_login":"elieobeid7"}}