{"action":"created","comment":{"url":"https://api.github.com/repos/node-modules/hessian.js/pulls/comments/75991335","id":75991335,"diff_hunk":"@@ -416,9 +426,12 @@ proto.readObject = function (withType) {\n     label = this.byteBuffer.getChar();\n     // property name will auto transfer to a String type.\n     debug('read object prop: %j with type: %s', key, withType);\n-    if (!/^this\\$\\d+$/.test(key)) {\n+    if ((typeof key === 'string' || typeof key === 'number') && !/^this\\$\\d+$/.test(key)) {","path":"lib/v1/decoder.js","position":38,"original_position":38,"commit_id":"c2a345b6d73eaea341cc92e453f50735f171b632","original_commit_id":"c2a345b6d73eaea341cc92e453f50735f171b632","user":{"login":"fengmk2","id":156269,"avatar_url":"https://avatars.githubusercontent.com/u/156269?v=3","gravatar_id":"","url":"https://api.github.com/users/fengmk2","html_url":"https://github.com/fengmk2","followers_url":"https://api.github.com/users/fengmk2/followers","following_url":"https://api.github.com/users/fengmk2/following{/other_user}","gists_url":"https://api.github.com/users/fengmk2/gists{/gist_id}","starred_url":"https://api.github.com/users/fengmk2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fengmk2/subscriptions","organizations_url":"https://api.github.com/users/fengmk2/orgs","repos_url":"https://api.github.com/users/fengmk2/repos","events_url":"https://api.github.com/users/fengmk2/events{/privacy}","received_events_url":"https://api.github.com/users/fengmk2/received_events","type":"User","site_admin":false},"body":"考虑极限性能的话， typeof key 结果是不是可以保留下来。。","created_at":"2016-08-24T03:53:59Z","updated_at":"2016-08-24T03:53:59Z","html_url":"https://github.com/node-modules/hessian.js/pull/70#discussion_r75991335","pull_request_url":"https://api.github.com/repos/node-modules/hessian.js/pulls/70","_links":{"self":{"href":"https://api.github.com/repos/node-modules/hessian.js/pulls/comments/75991335"},"html":{"href":"https://github.com/node-modules/hessian.js/pull/70#discussion_r75991335"},"pull_request":{"href":"https://api.github.com/repos/node-modules/hessian.js/pulls/70"}}},"pull_request":{"url":"https://api.github.com/repos/node-modules/hessian.js/pulls/70","id":82471228,"html_url":"https://github.com/node-modules/hessian.js/pull/70","diff_url":"https://github.com/node-modules/hessian.js/pull/70.diff","patch_url":"https://github.com/node-modules/hessian.js/pull/70.patch","issue_url":"https://api.github.com/repos/node-modules/hessian.js/issues/70","number":70,"state":"open","locked":false,"title":"feat: support java.util.HashMap to es6 Map","user":{"login":"gxcsoccer","id":1207064,"avatar_url":"https://avatars.githubusercontent.com/u/1207064?v=3","gravatar_id":"","url":"https://api.github.com/users/gxcsoccer","html_url":"https://github.com/gxcsoccer","followers_url":"https://api.github.com/users/gxcsoccer/followers","following_url":"https://api.github.com/users/gxcsoccer/following{/other_user}","gists_url":"https://api.github.com/users/gxcsoccer/gists{/gist_id}","starred_url":"https://api.github.com/users/gxcsoccer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gxcsoccer/subscriptions","organizations_url":"https://api.github.com/users/gxcsoccer/orgs","repos_url":"https://api.github.com/users/gxcsoccer/repos","events_url":"https://api.github.com/users/gxcsoccer/events{/privacy}","received_events_url":"https://api.github.com/users/gxcsoccer/received_events","type":"User","site_admin":false},"body":"add $map property & set key, value into it while readHashMap","created_at":"2016-08-24T02:14:14Z","updated_at":"2016-08-24T03:53:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25f1039d228bc42158c0f6b53c68ecf7d1831fe9","assignee":{"login":"fengmk2","id":156269,"avatar_url":"https://avatars.githubusercontent.com/u/156269?v=3","gravatar_id":"","url":"https://api.github.com/users/fengmk2","html_url":"https://github.com/fengmk2","followers_url":"https://api.github.com/users/fengmk2/followers","following_url":"https://api.github.com/users/fengmk2/following{/other_user}","gists_url":"https://api.github.com/users/fengmk2/gists{/gist_id}","starred_url":"https://api.github.com/users/fengmk2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fengmk2/subscriptions","organizations_url":"https://api.github.com/users/fengmk2/orgs","repos_url":"https://api.github.com/users/fengmk2/repos","events_url":"https://api.github.com/users/fengmk2/events{/privacy}","received_events_url":"https://api.github.com/users/fengmk2/received_events","type":"User","site_admin":false},"assignees":[{"login":"fengmk2","id":156269,"avatar_url":"https://avatars.githubusercontent.com/u/156269?v=3","gravatar_id":"","url":"https://api.github.com/users/fengmk2","html_url":"https://github.com/fengmk2","followers_url":"https://api.github.com/users/fengmk2/followers","following_url":"https://api.github.com/users/fengmk2/following{/other_user}","gists_url":"https://api.github.com/users/fengmk2/gists{/gist_id}","starred_url":"https://api.github.com/users/fengmk2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fengmk2/subscriptions","organizations_url":"https://api.github.com/users/fengmk2/orgs","repos_url":"https://api.github.com/users/fengmk2/repos","events_url":"https://api.github.com/users/fengmk2/events{/privacy}","received_events_url":"https://api.github.com/users/fengmk2/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/node-modules/hessian.js/pulls/70/commits","review_comments_url":"https://api.github.com/repos/node-modules/hessian.js/pulls/70/comments","review_comment_url":"https://api.github.com/repos/node-modules/hessian.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/node-modules/hessian.js/issues/70/comments","statuses_url":"https://api.github.com/repos/node-modules/hessian.js/statuses/c2a345b6d73eaea341cc92e453f50735f171b632","head":{"label":"node-modules:support-map","ref":"support-map","sha":"c2a345b6d73eaea341cc92e453f50735f171b632","user":{"login":"node-modules","id":7125868,"avatar_url":"https://avatars.githubusercontent.com/u/7125868?v=3","gravatar_id":"","url":"https://api.github.com/users/node-modules","html_url":"https://github.com/node-modules","followers_url":"https://api.github.com/users/node-modules/followers","following_url":"https://api.github.com/users/node-modules/following{/other_user}","gists_url":"https://api.github.com/users/node-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/node-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/node-modules/subscriptions","organizations_url":"https://api.github.com/users/node-modules/orgs","repos_url":"https://api.github.com/users/node-modules/repos","events_url":"https://api.github.com/users/node-modules/events{/privacy}","received_events_url":"https://api.github.com/users/node-modules/received_events","type":"Organization","site_admin":false},"repo":{"id":15910516,"name":"hessian.js","full_name":"node-modules/hessian.js","owner":{"login":"node-modules","id":7125868,"avatar_url":"https://avatars.githubusercontent.com/u/7125868?v=3","gravatar_id":"","url":"https://api.github.com/users/node-modules","html_url":"https://github.com/node-modules","followers_url":"https://api.github.com/users/node-modules/followers","following_url":"https://api.github.com/users/node-modules/following{/other_user}","gists_url":"https://api.github.com/users/node-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/node-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/node-modules/subscriptions","organizations_url":"https://api.github.com/users/node-modules/orgs","repos_url":"https://api.github.com/users/node-modules/repos","events_url":"https://api.github.com/users/node-modules/events{/privacy}","received_events_url":"https://api.github.com/users/node-modules/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/node-modules/hessian.js","description":"js hessian binary web service protocol, support communicate with java","fork":false,"url":"https://api.github.com/repos/node-modules/hessian.js","forks_url":"https://api.github.com/repos/node-modules/hessian.js/forks","keys_url":"https://api.github.com/repos/node-modules/hessian.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/node-modules/hessian.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/node-modules/hessian.js/teams","hooks_url":"https://api.github.com/repos/node-modules/hessian.js/hooks","issue_events_url":"https://api.github.com/repos/node-modules/hessian.js/issues/events{/number}","events_url":"https://api.github.com/repos/node-modules/hessian.js/events","assignees_url":"https://api.github.com/repos/node-modules/hessian.js/assignees{/user}","branches_url":"https://api.github.com/repos/node-modules/hessian.js/branches{/branch}","tags_url":"https://api.github.com/repos/node-modules/hessian.js/tags","blobs_url":"https://api.github.com/repos/node-modules/hessian.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/node-modules/hessian.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/node-modules/hessian.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/node-modules/hessian.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/node-modules/hessian.js/statuses/{sha}","languages_url":"https://api.github.com/repos/node-modules/hessian.js/languages","stargazers_url":"https://api.github.com/repos/node-modules/hessian.js/stargazers","contributors_url":"https://api.github.com/repos/node-modules/hessian.js/contributors","subscribers_url":"https://api.github.com/repos/node-modules/hessian.js/subscribers","subscription_url":"https://api.github.com/repos/node-modules/hessian.js/subscription","commits_url":"https://api.github.com/repos/node-modules/hessian.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/node-modules/hessian.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/node-modules/hessian.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/node-modules/hessian.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/node-modules/hessian.js/contents/{+path}","compare_url":"https://api.github.com/repos/node-modules/hessian.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/node-modules/hessian.js/merges","archive_url":"https://api.github.com/repos/node-modules/hessian.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/node-modules/hessian.js/downloads","issues_url":"https://api.github.com/repos/node-modules/hessian.js/issues{/number}","pulls_url":"https://api.github.com/repos/node-modules/hessian.js/pulls{/number}","milestones_url":"https://api.github.com/repos/node-modules/hessian.js/milestones{/number}","notifications_url":"https://api.github.com/repos/node-modules/hessian.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/node-modules/hessian.js/labels{/name}","releases_url":"https://api.github.com/repos/node-modules/hessian.js/releases{/id}","deployments_url":"https://api.github.com/repos/node-modules/hessian.js/deployments","created_at":"2014-01-14T18:00:01Z","updated_at":"2016-08-18T08:10:45Z","pushed_at":"2016-08-24T03:33:36Z","git_url":"git://github.com/node-modules/hessian.js.git","ssh_url":"git@github.com:node-modules/hessian.js.git","clone_url":"https://github.com/node-modules/hessian.js.git","svn_url":"https://github.com/node-modules/hessian.js","homepage":"","size":773,"stargazers_count":35,"watchers_count":35,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":8,"forks":8,"open_issues":8,"watchers":35,"default_branch":"master"}},"base":{"label":"node-modules:master","ref":"master","sha":"2b53d13fd21f7eba6747c9acfcdad0bc1c003bee","user":{"login":"node-modules","id":7125868,"avatar_url":"https://avatars.githubusercontent.com/u/7125868?v=3","gravatar_id":"","url":"https://api.github.com/users/node-modules","html_url":"https://github.com/node-modules","followers_url":"https://api.github.com/users/node-modules/followers","following_url":"https://api.github.com/users/node-modules/following{/other_user}","gists_url":"https://api.github.com/users/node-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/node-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/node-modules/subscriptions","organizations_url":"https://api.github.com/users/node-modules/orgs","repos_url":"https://api.github.com/users/node-modules/repos","events_url":"https://api.github.com/users/node-modules/events{/privacy}","received_events_url":"https://api.github.com/users/node-modules/received_events","type":"Organization","site_admin":false},"repo":{"id":15910516,"name":"hessian.js","full_name":"node-modules/hessian.js","owner":{"login":"node-modules","id":7125868,"avatar_url":"https://avatars.githubusercontent.com/u/7125868?v=3","gravatar_id":"","url":"https://api.github.com/users/node-modules","html_url":"https://github.com/node-modules","followers_url":"https://api.github.com/users/node-modules/followers","following_url":"https://api.github.com/users/node-modules/following{/other_user}","gists_url":"https://api.github.com/users/node-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/node-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/node-modules/subscriptions","organizations_url":"https://api.github.com/users/node-modules/orgs","repos_url":"https://api.github.com/users/node-modules/repos","events_url":"https://api.github.com/users/node-modules/events{/privacy}","received_events_url":"https://api.github.com/users/node-modules/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/node-modules/hessian.js","description":"js hessian binary web service protocol, support communicate with java","fork":false,"url":"https://api.github.com/repos/node-modules/hessian.js","forks_url":"https://api.github.com/repos/node-modules/hessian.js/forks","keys_url":"https://api.github.com/repos/node-modules/hessian.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/node-modules/hessian.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/node-modules/hessian.js/teams","hooks_url":"https://api.github.com/repos/node-modules/hessian.js/hooks","issue_events_url":"https://api.github.com/repos/node-modules/hessian.js/issues/events{/number}","events_url":"https://api.github.com/repos/node-modules/hessian.js/events","assignees_url":"https://api.github.com/repos/node-modules/hessian.js/assignees{/user}","branches_url":"https://api.github.com/repos/node-modules/hessian.js/branches{/branch}","tags_url":"https://api.github.com/repos/node-modules/hessian.js/tags","blobs_url":"https://api.github.com/repos/node-modules/hessian.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/node-modules/hessian.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/node-modules/hessian.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/node-modules/hessian.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/node-modules/hessian.js/statuses/{sha}","languages_url":"https://api.github.com/repos/node-modules/hessian.js/languages","stargazers_url":"https://api.github.com/repos/node-modules/hessian.js/stargazers","contributors_url":"https://api.github.com/repos/node-modules/hessian.js/contributors","subscribers_url":"https://api.github.com/repos/node-modules/hessian.js/subscribers","subscription_url":"https://api.github.com/repos/node-modules/hessian.js/subscription","commits_url":"https://api.github.com/repos/node-modules/hessian.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/node-modules/hessian.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/node-modules/hessian.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/node-modules/hessian.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/node-modules/hessian.js/contents/{+path}","compare_url":"https://api.github.com/repos/node-modules/hessian.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/node-modules/hessian.js/merges","archive_url":"https://api.github.com/repos/node-modules/hessian.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/node-modules/hessian.js/downloads","issues_url":"https://api.github.com/repos/node-modules/hessian.js/issues{/number}","pulls_url":"https://api.github.com/repos/node-modules/hessian.js/pulls{/number}","milestones_url":"https://api.github.com/repos/node-modules/hessian.js/milestones{/number}","notifications_url":"https://api.github.com/repos/node-modules/hessian.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/node-modules/hessian.js/labels{/name}","releases_url":"https://api.github.com/repos/node-modules/hessian.js/releases{/id}","deployments_url":"https://api.github.com/repos/node-modules/hessian.js/deployments","created_at":"2014-01-14T18:00:01Z","updated_at":"2016-08-18T08:10:45Z","pushed_at":"2016-08-24T03:33:36Z","git_url":"git://github.com/node-modules/hessian.js.git","ssh_url":"git@github.com:node-modules/hessian.js.git","clone_url":"https://github.com/node-modules/hessian.js.git","svn_url":"https://github.com/node-modules/hessian.js","homepage":"","size":773,"stargazers_count":35,"watchers_count":35,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":8,"forks":8,"open_issues":8,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/node-modules/hessian.js/pulls/70"},"html":{"href":"https://github.com/node-modules/hessian.js/pull/70"},"issue":{"href":"https://api.github.com/repos/node-modules/hessian.js/issues/70"},"comments":{"href":"https://api.github.com/repos/node-modules/hessian.js/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/node-modules/hessian.js/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/node-modules/hessian.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/node-modules/hessian.js/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/node-modules/hessian.js/statuses/c2a345b6d73eaea341cc92e453f50735f171b632"}}}}
{"actor":{"display_login":"fengmk2"}}