{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/88720072","pull_request_review_id":9287547,"id":88720072,"diff_hunk":"@@ -529,6 +581,14 @@ public KafkaChannel channel(String id) {\n     }\n \n     /**\n+     * Return the channel with the specified id if it was disconnected, but not yet closed\n+     * since there are outstanding messages to be processed.\n+     */\n+    public KafkaChannel closingChannel(String id) {","path":"clients/src/main/java/org/apache/kafka/common/network/Selector.java","position":221,"original_position":221,"commit_id":"3dee90ab699aee120559951ccfba18ecc132429a","original_commit_id":"3dee90ab699aee120559951ccfba18ecc132429a","user":{"login":"rajinisivaram","id":13164074,"avatar_url":"https://avatars.githubusercontent.com/u/13164074?v=3","gravatar_id":"","url":"https://api.github.com/users/rajinisivaram","html_url":"https://github.com/rajinisivaram","followers_url":"https://api.github.com/users/rajinisivaram/followers","following_url":"https://api.github.com/users/rajinisivaram/following{/other_user}","gists_url":"https://api.github.com/users/rajinisivaram/gists{/gist_id}","starred_url":"https://api.github.com/users/rajinisivaram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajinisivaram/subscriptions","organizations_url":"https://api.github.com/users/rajinisivaram/orgs","repos_url":"https://api.github.com/users/rajinisivaram/repos","events_url":"https://api.github.com/users/rajinisivaram/events{/privacy}","received_events_url":"https://api.github.com/users/rajinisivaram/received_events","type":"User","site_admin":false},"body":"At the moment you can't get hold of `KafkaChannel` using the `Selectable` interface. If `closingChannel` is added to the interface, perhaps `channel(String id)` needs to be as well? Not sure if you would want one but not the other.","created_at":"2016-11-18T19:12:45Z","updated_at":"2016-11-18T19:12:46Z","html_url":"https://github.com/apache/kafka/pull/1836#discussion_r88720072","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/1836","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/88720072"},"html":{"href":"https://github.com/apache/kafka/pull/1836#discussion_r88720072"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/1836"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/1836","id":84549961,"html_url":"https://github.com/apache/kafka/pull/1836","diff_url":"https://github.com/apache/kafka/pull/1836.diff","patch_url":"https://github.com/apache/kafka/pull/1836.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/1836","number":1836,"state":"open","locked":false,"title":"KAFKA-3703: Graceful close for consumers and producer with acks=0","user":{"login":"rajinisivaram","id":13164074,"avatar_url":"https://avatars.githubusercontent.com/u/13164074?v=3","gravatar_id":"","url":"https://api.github.com/users/rajinisivaram","html_url":"https://github.com/rajinisivaram","followers_url":"https://api.github.com/users/rajinisivaram/followers","following_url":"https://api.github.com/users/rajinisivaram/following{/other_user}","gists_url":"https://api.github.com/users/rajinisivaram/gists{/gist_id}","starred_url":"https://api.github.com/users/rajinisivaram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajinisivaram/subscriptions","organizations_url":"https://api.github.com/users/rajinisivaram/orgs","repos_url":"https://api.github.com/users/rajinisivaram/repos","events_url":"https://api.github.com/users/rajinisivaram/events{/privacy}","received_events_url":"https://api.github.com/users/rajinisivaram/received_events","type":"User","site_admin":false},"body":"Process requests received from channels before they were closed. For consumers, wait for coordinator requests to complete before returning from close.\n","created_at":"2016-09-08T20:40:44Z","updated_at":"2016-11-18T19:12:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f44dc311aea360f7c2df56df4c5a9924ce1feea","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/1836/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/1836/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/1836/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/3dee90ab699aee120559951ccfba18ecc132429a","head":{"label":"rajinisivaram:KAFKA-3703","ref":"KAFKA-3703","sha":"3dee90ab699aee120559951ccfba18ecc132429a","user":{"login":"rajinisivaram","id":13164074,"avatar_url":"https://avatars.githubusercontent.com/u/13164074?v=3","gravatar_id":"","url":"https://api.github.com/users/rajinisivaram","html_url":"https://github.com/rajinisivaram","followers_url":"https://api.github.com/users/rajinisivaram/followers","following_url":"https://api.github.com/users/rajinisivaram/following{/other_user}","gists_url":"https://api.github.com/users/rajinisivaram/gists{/gist_id}","starred_url":"https://api.github.com/users/rajinisivaram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajinisivaram/subscriptions","organizations_url":"https://api.github.com/users/rajinisivaram/orgs","repos_url":"https://api.github.com/users/rajinisivaram/repos","events_url":"https://api.github.com/users/rajinisivaram/events{/privacy}","received_events_url":"https://api.github.com/users/rajinisivaram/received_events","type":"User","site_admin":false},"repo":{"id":42296329,"name":"kafka","full_name":"rajinisivaram/kafka","owner":{"login":"rajinisivaram","id":13164074,"avatar_url":"https://avatars.githubusercontent.com/u/13164074?v=3","gravatar_id":"","url":"https://api.github.com/users/rajinisivaram","html_url":"https://github.com/rajinisivaram","followers_url":"https://api.github.com/users/rajinisivaram/followers","following_url":"https://api.github.com/users/rajinisivaram/following{/other_user}","gists_url":"https://api.github.com/users/rajinisivaram/gists{/gist_id}","starred_url":"https://api.github.com/users/rajinisivaram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajinisivaram/subscriptions","organizations_url":"https://api.github.com/users/rajinisivaram/orgs","repos_url":"https://api.github.com/users/rajinisivaram/repos","events_url":"https://api.github.com/users/rajinisivaram/events{/privacy}","received_events_url":"https://api.github.com/users/rajinisivaram/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rajinisivaram/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/rajinisivaram/kafka","forks_url":"https://api.github.com/repos/rajinisivaram/kafka/forks","keys_url":"https://api.github.com/repos/rajinisivaram/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rajinisivaram/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rajinisivaram/kafka/teams","hooks_url":"https://api.github.com/repos/rajinisivaram/kafka/hooks","issue_events_url":"https://api.github.com/repos/rajinisivaram/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/rajinisivaram/kafka/events","assignees_url":"https://api.github.com/repos/rajinisivaram/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/rajinisivaram/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/rajinisivaram/kafka/tags","blobs_url":"https://api.github.com/repos/rajinisivaram/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rajinisivaram/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rajinisivaram/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/rajinisivaram/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rajinisivaram/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/rajinisivaram/kafka/languages","stargazers_url":"https://api.github.com/repos/rajinisivaram/kafka/stargazers","contributors_url":"https://api.github.com/repos/rajinisivaram/kafka/contributors","subscribers_url":"https://api.github.com/repos/rajinisivaram/kafka/subscribers","subscription_url":"https://api.github.com/repos/rajinisivaram/kafka/subscription","commits_url":"https://api.github.com/repos/rajinisivaram/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/rajinisivaram/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/rajinisivaram/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/rajinisivaram/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/rajinisivaram/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/rajinisivaram/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rajinisivaram/kafka/merges","archive_url":"https://api.github.com/repos/rajinisivaram/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rajinisivaram/kafka/downloads","issues_url":"https://api.github.com/repos/rajinisivaram/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/rajinisivaram/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/rajinisivaram/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/rajinisivaram/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rajinisivaram/kafka/labels{/name}","releases_url":"https://api.github.com/repos/rajinisivaram/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/rajinisivaram/kafka/deployments","created_at":"2015-09-11T08:16:17Z","updated_at":"2016-01-29T12:19:37Z","pushed_at":"2016-11-18T15:59:30Z","git_url":"git://github.com/rajinisivaram/kafka.git","ssh_url":"git@github.com:rajinisivaram/kafka.git","clone_url":"https://github.com/rajinisivaram/kafka.git","svn_url":"https://github.com/rajinisivaram/kafka","homepage":null,"size":35236,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"0e7ba70008fa8961ae55861a4dd3a5370d1d5a69","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2016-11-18T15:57:57Z","pushed_at":"2016-11-18T18:03:07Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":53369,"stargazers_count":4128,"watchers_count":4128,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2557,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":293,"forks":2557,"open_issues":293,"watchers":4128,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/1836"},"html":{"href":"https://github.com/apache/kafka/pull/1836"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/1836"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/1836/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/1836/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/1836/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/3dee90ab699aee120559951ccfba18ecc132429a"}}}}
{"actor":{"display_login":"rajinisivaram"}}