{"action":"created","issue":{"url":"https://api.github.com/repos/lucidworks/lucidworks-view/issues/39","repository_url":"https://api.github.com/repos/lucidworks/lucidworks-view","labels_url":"https://api.github.com/repos/lucidworks/lucidworks-view/issues/39/labels{/name}","comments_url":"https://api.github.com/repos/lucidworks/lucidworks-view/issues/39/comments","events_url":"https://api.github.com/repos/lucidworks/lucidworks-view/issues/39/events","html_url":"https://github.com/lucidworks/lucidworks-view/pull/39","id":158665839,"number":39,"title":"SignalsService.postClickSignal should pass in position information","user":{"login":"janezomgzomg","id":6275470,"avatar_url":"https://avatars.githubusercontent.com/u/6275470?v=3","gravatar_id":"","url":"https://api.github.com/users/janezomgzomg","html_url":"https://github.com/janezomgzomg","followers_url":"https://api.github.com/users/janezomgzomg/followers","following_url":"https://api.github.com/users/janezomgzomg/following{/other_user}","gists_url":"https://api.github.com/users/janezomgzomg/gists{/gist_id}","starred_url":"https://api.github.com/users/janezomgzomg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janezomgzomg/subscriptions","organizations_url":"https://api.github.com/users/janezomgzomg/orgs","repos_url":"https://api.github.com/users/janezomgzomg/repos","events_url":"https://api.github.com/users/janezomgzomg/events{/privacy}","received_events_url":"https://api.github.com/users/janezomgzomg/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/lucidworks/lucidworks-view/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"arijitdasgupta","id":1533635,"avatar_url":"https://avatars.githubusercontent.com/u/1533635?v=3","gravatar_id":"","url":"https://api.github.com/users/arijitdasgupta","html_url":"https://github.com/arijitdasgupta","followers_url":"https://api.github.com/users/arijitdasgupta/followers","following_url":"https://api.github.com/users/arijitdasgupta/following{/other_user}","gists_url":"https://api.github.com/users/arijitdasgupta/gists{/gist_id}","starred_url":"https://api.github.com/users/arijitdasgupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arijitdasgupta/subscriptions","organizations_url":"https://api.github.com/users/arijitdasgupta/orgs","repos_url":"https://api.github.com/users/arijitdasgupta/repos","events_url":"https://api.github.com/users/arijitdasgupta/events{/privacy}","received_events_url":"https://api.github.com/users/arijitdasgupta/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/lucidworks/lucidworks-view/milestones/3","html_url":"https://github.com/lucidworks/lucidworks-view/milestones/1.2","labels_url":"https://api.github.com/repos/lucidworks/lucidworks-view/milestones/3/labels","id":1763302,"number":3,"title":"1.2","description":null,"creator":{"login":"JoshEllinger","id":110059,"avatar_url":"https://avatars.githubusercontent.com/u/110059?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshEllinger","html_url":"https://github.com/JoshEllinger","followers_url":"https://api.github.com/users/JoshEllinger/followers","following_url":"https://api.github.com/users/JoshEllinger/following{/other_user}","gists_url":"https://api.github.com/users/JoshEllinger/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshEllinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshEllinger/subscriptions","organizations_url":"https://api.github.com/users/JoshEllinger/orgs","repos_url":"https://api.github.com/users/JoshEllinger/repos","events_url":"https://api.github.com/users/JoshEllinger/events{/privacy}","received_events_url":"https://api.github.com/users/JoshEllinger/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":3,"state":"open","created_at":"2016-05-12T21:08:08Z","updated_at":"2016-06-10T01:31:40Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-06-06T12:28:57Z","updated_at":"2016-06-10T11:38:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lucidworks/lucidworks-view/pulls/39","html_url":"https://github.com/lucidworks/lucidworks-view/pull/39","diff_url":"https://github.com/lucidworks/lucidworks-view/pull/39.diff","patch_url":"https://github.com/lucidworks/lucidworks-view/pull/39.patch"},"body":"* New fields that will be passed in:\r\n  * `lw_url`\r\n  * `position` - position\r\n  * `page`\r\n  * `head_field`\r\n  * `language`\r\n  * `platform`\r\n  * `user_agent`\r\n  * `user_name`\r\n* A scope variable `position` is passed down into the document directive from `document-list`. It returns the value of `getDocPosition` which returns the index of the document in the current document result list.\r\n* Params passed into `postSignal` function are `lw_url`, `position` and `page`. The get appended to `data.params` in `SignalsService.postClickSignal`.\r\n* added `getNormalizedCurrentPage` to `PaginateService`. The value of the current page number is normalized wrt 1.\r\n* Params that will be added to `SignalsService.postClickSignal` are:\r\n  * `head_field`\r\n  * `language`\r\n  * `platform`\r\n  * `user_agent`\r\n  * `user_name`\r\n* Added `ClientStatsService` with the following functions:\r\n  * `getBrowserLanguage` - returns language and locale of the browser\r\n  * `getBrowserPlatform` - returns browser platform\r\n  * `getBrowserUserAgent` - returns user agent\r\n* Tiny fix: `__signals_doc_id__` has been set with the value of `doc.id`\r\n\r\n**EDIT:**\r\n* some cleanup wrt postSignal in the controller of every doc type where the `doc` and `lw_url` will be passed in via the function call in the template\r\n* `position` and `page` will be added to the options obj in the controller\r\n* `SignalService.postClickSignal` will be called in the `postSignal` function in the controller with the required parameters\r\n* this will ensure that the `postSignal` call in the template is readable.\r\n  "},"comment":{"url":"https://api.github.com/repos/lucidworks/lucidworks-view/issues/comments/225160184","html_url":"https://github.com/lucidworks/lucidworks-view/pull/39#issuecomment-225160184","issue_url":"https://api.github.com/repos/lucidworks/lucidworks-view/issues/39","id":225160184,"user":{"login":"arijitdasgupta","id":1533635,"avatar_url":"https://avatars.githubusercontent.com/u/1533635?v=3","gravatar_id":"","url":"https://api.github.com/users/arijitdasgupta","html_url":"https://github.com/arijitdasgupta","followers_url":"https://api.github.com/users/arijitdasgupta/followers","following_url":"https://api.github.com/users/arijitdasgupta/following{/other_user}","gists_url":"https://api.github.com/users/arijitdasgupta/gists{/gist_id}","starred_url":"https://api.github.com/users/arijitdasgupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arijitdasgupta/subscriptions","organizations_url":"https://api.github.com/users/arijitdasgupta/orgs","repos_url":"https://api.github.com/users/arijitdasgupta/repos","events_url":"https://api.github.com/users/arijitdasgupta/events{/privacy}","received_events_url":"https://api.github.com/users/arijitdasgupta/received_events","type":"User","site_admin":false},"created_at":"2016-06-10T11:38:08Z","updated_at":"2016-06-10T11:38:08Z","body":"Looks great. Works nicely. \r\n\r\nOther my previous comment on code about `postSignal` function implementation, this is ready to go. 👍 "}}
{"actor":{"display_login":"arijitdasgupta"}}