{"action":"created","comment":{"url":"https://api.github.com/repos/mldbai/mldb/pulls/comments/84098581","pull_request_review_id":4897407,"id":84098581,"diff_hunk":"@@ -525,6 +527,58 @@ struct EmbeddingDataset::Itl\n         return result;\n     }\n \n+    virtual std::vector<CellValue>\n+    getColumnDense(const ColumnPath & column) const override\n+    {\n+        auto repr = committed();\n+        if (!repr->initialized())\n+            throw HttpReturnException(400, \"Can't get unknown column\");","path":"plugins/embedding.cc","position":18,"original_position":18,"commit_id":"5e36586f44297a4058683821d7ddd8e721af9b1f","original_commit_id":"8ea3d691d896e206ed41def57cdee3b0dc9c2da4","user":{"login":"jeremybarnes","id":112556,"avatar_url":"https://avatars.githubusercontent.com/u/112556?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremybarnes","html_url":"https://github.com/jeremybarnes","followers_url":"https://api.github.com/users/jeremybarnes/followers","following_url":"https://api.github.com/users/jeremybarnes/following{/other_user}","gists_url":"https://api.github.com/users/jeremybarnes/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremybarnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremybarnes/subscriptions","organizations_url":"https://api.github.com/users/jeremybarnes/orgs","repos_url":"https://api.github.com/users/jeremybarnes/repos","events_url":"https://api.github.com/users/jeremybarnes/events{/privacy}","received_events_url":"https://api.github.com/users/jeremybarnes/received_events","type":"User","site_admin":false},"body":"It's hard to tell.  But assuming no MLDB bugs, it would normally be a user error.","created_at":"2016-10-19T15:33:27Z","updated_at":"2016-10-19T15:33:27Z","html_url":"https://github.com/mldbai/mldb/pull/724#discussion_r84098581","pull_request_url":"https://api.github.com/repos/mldbai/mldb/pulls/724","_links":{"self":{"href":"https://api.github.com/repos/mldbai/mldb/pulls/comments/84098581"},"html":{"href":"https://github.com/mldbai/mldb/pull/724#discussion_r84098581"},"pull_request":{"href":"https://api.github.com/repos/mldbai/mldb/pulls/724"}}},"pull_request":{"url":"https://api.github.com/repos/mldbai/mldb/pulls/724","id":90021453,"html_url":"https://github.com/mldbai/mldb/pull/724","diff_url":"https://github.com/mldbai/mldb/pull/724.diff","patch_url":"https://github.com/mldbai/mldb/pull/724.patch","issue_url":"https://api.github.com/repos/mldbai/mldb/issues/724","number":724,"state":"open","locked":false,"title":"MLDB-1940 jetson tx1 cuda & raspberry pi & RF speed improvements","user":{"login":"jeremybarnes","id":112556,"avatar_url":"https://avatars.githubusercontent.com/u/112556?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremybarnes","html_url":"https://github.com/jeremybarnes","followers_url":"https://api.github.com/users/jeremybarnes/followers","following_url":"https://api.github.com/users/jeremybarnes/following{/other_user}","gists_url":"https://api.github.com/users/jeremybarnes/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremybarnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremybarnes/subscriptions","organizations_url":"https://api.github.com/users/jeremybarnes/orgs","repos_url":"https://api.github.com/users/jeremybarnes/repos","events_url":"https://api.github.com/users/jeremybarnes/events{/privacy}","received_events_url":"https://api.github.com/users/jeremybarnes/received_events","type":"User","site_admin":false},"body":"This is a topic branch for the changes to get MLDB working on the TX1 and Pi 3 with reasonable performance training random forests (which was my demo at PAPIs).\r\n\r\nThe distinct issue numbers found and fixed are in the individual commits. ","created_at":"2016-10-19T14:31:06Z","updated_at":"2016-10-19T15:33:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74b4a083ad10e025991fc3d747735c7eb075b3a5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mldbai/mldb/pulls/724/commits","review_comments_url":"https://api.github.com/repos/mldbai/mldb/pulls/724/comments","review_comment_url":"https://api.github.com/repos/mldbai/mldb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mldbai/mldb/issues/724/comments","statuses_url":"https://api.github.com/repos/mldbai/mldb/statuses/5e36586f44297a4058683821d7ddd8e721af9b1f","head":{"label":"mldbai:MLDB-1940-jetson-tx1-cuda","ref":"MLDB-1940-jetson-tx1-cuda","sha":"5e36586f44297a4058683821d7ddd8e721af9b1f","user":{"login":"mldbai","id":11510172,"avatar_url":"https://avatars.githubusercontent.com/u/11510172?v=3","gravatar_id":"","url":"https://api.github.com/users/mldbai","html_url":"https://github.com/mldbai","followers_url":"https://api.github.com/users/mldbai/followers","following_url":"https://api.github.com/users/mldbai/following{/other_user}","gists_url":"https://api.github.com/users/mldbai/gists{/gist_id}","starred_url":"https://api.github.com/users/mldbai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mldbai/subscriptions","organizations_url":"https://api.github.com/users/mldbai/orgs","repos_url":"https://api.github.com/users/mldbai/repos","events_url":"https://api.github.com/users/mldbai/events{/privacy}","received_events_url":"https://api.github.com/users/mldbai/received_events","type":"Organization","site_admin":false},"repo":{"id":47634692,"name":"mldb","full_name":"mldbai/mldb","owner":{"login":"mldbai","id":11510172,"avatar_url":"https://avatars.githubusercontent.com/u/11510172?v=3","gravatar_id":"","url":"https://api.github.com/users/mldbai","html_url":"https://github.com/mldbai","followers_url":"https://api.github.com/users/mldbai/followers","following_url":"https://api.github.com/users/mldbai/following{/other_user}","gists_url":"https://api.github.com/users/mldbai/gists{/gist_id}","starred_url":"https://api.github.com/users/mldbai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mldbai/subscriptions","organizations_url":"https://api.github.com/users/mldbai/orgs","repos_url":"https://api.github.com/users/mldbai/repos","events_url":"https://api.github.com/users/mldbai/events{/privacy}","received_events_url":"https://api.github.com/users/mldbai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mldbai/mldb","description":"MLDB is the Machine Learning Database","fork":false,"url":"https://api.github.com/repos/mldbai/mldb","forks_url":"https://api.github.com/repos/mldbai/mldb/forks","keys_url":"https://api.github.com/repos/mldbai/mldb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mldbai/mldb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mldbai/mldb/teams","hooks_url":"https://api.github.com/repos/mldbai/mldb/hooks","issue_events_url":"https://api.github.com/repos/mldbai/mldb/issues/events{/number}","events_url":"https://api.github.com/repos/mldbai/mldb/events","assignees_url":"https://api.github.com/repos/mldbai/mldb/assignees{/user}","branches_url":"https://api.github.com/repos/mldbai/mldb/branches{/branch}","tags_url":"https://api.github.com/repos/mldbai/mldb/tags","blobs_url":"https://api.github.com/repos/mldbai/mldb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mldbai/mldb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mldbai/mldb/git/refs{/sha}","trees_url":"https://api.github.com/repos/mldbai/mldb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mldbai/mldb/statuses/{sha}","languages_url":"https://api.github.com/repos/mldbai/mldb/languages","stargazers_url":"https://api.github.com/repos/mldbai/mldb/stargazers","contributors_url":"https://api.github.com/repos/mldbai/mldb/contributors","subscribers_url":"https://api.github.com/repos/mldbai/mldb/subscribers","subscription_url":"https://api.github.com/repos/mldbai/mldb/subscription","commits_url":"https://api.github.com/repos/mldbai/mldb/commits{/sha}","git_commits_url":"https://api.github.com/repos/mldbai/mldb/git/commits{/sha}","comments_url":"https://api.github.com/repos/mldbai/mldb/comments{/number}","issue_comment_url":"https://api.github.com/repos/mldbai/mldb/issues/comments{/number}","contents_url":"https://api.github.com/repos/mldbai/mldb/contents/{+path}","compare_url":"https://api.github.com/repos/mldbai/mldb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mldbai/mldb/merges","archive_url":"https://api.github.com/repos/mldbai/mldb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mldbai/mldb/downloads","issues_url":"https://api.github.com/repos/mldbai/mldb/issues{/number}","pulls_url":"https://api.github.com/repos/mldbai/mldb/pulls{/number}","milestones_url":"https://api.github.com/repos/mldbai/mldb/milestones{/number}","notifications_url":"https://api.github.com/repos/mldbai/mldb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mldbai/mldb/labels{/name}","releases_url":"https://api.github.com/repos/mldbai/mldb/releases{/id}","deployments_url":"https://api.github.com/repos/mldbai/mldb/deployments","created_at":"2015-12-08T16:34:16Z","updated_at":"2016-10-18T01:06:56Z","pushed_at":"2016-10-19T15:20:42Z","git_url":"git://github.com/mldbai/mldb.git","ssh_url":"git@github.com:mldbai/mldb.git","clone_url":"https://github.com/mldbai/mldb.git","svn_url":"https://github.com/mldbai/mldb","homepage":"http://mldb.ai","size":31591,"stargazers_count":225,"watchers_count":225,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":25,"forks":18,"open_issues":25,"watchers":225,"default_branch":"master"}},"base":{"label":"mldbai:master","ref":"master","sha":"182c3a8745c18be606fefb9594b215d0c0751ea3","user":{"login":"mldbai","id":11510172,"avatar_url":"https://avatars.githubusercontent.com/u/11510172?v=3","gravatar_id":"","url":"https://api.github.com/users/mldbai","html_url":"https://github.com/mldbai","followers_url":"https://api.github.com/users/mldbai/followers","following_url":"https://api.github.com/users/mldbai/following{/other_user}","gists_url":"https://api.github.com/users/mldbai/gists{/gist_id}","starred_url":"https://api.github.com/users/mldbai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mldbai/subscriptions","organizations_url":"https://api.github.com/users/mldbai/orgs","repos_url":"https://api.github.com/users/mldbai/repos","events_url":"https://api.github.com/users/mldbai/events{/privacy}","received_events_url":"https://api.github.com/users/mldbai/received_events","type":"Organization","site_admin":false},"repo":{"id":47634692,"name":"mldb","full_name":"mldbai/mldb","owner":{"login":"mldbai","id":11510172,"avatar_url":"https://avatars.githubusercontent.com/u/11510172?v=3","gravatar_id":"","url":"https://api.github.com/users/mldbai","html_url":"https://github.com/mldbai","followers_url":"https://api.github.com/users/mldbai/followers","following_url":"https://api.github.com/users/mldbai/following{/other_user}","gists_url":"https://api.github.com/users/mldbai/gists{/gist_id}","starred_url":"https://api.github.com/users/mldbai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mldbai/subscriptions","organizations_url":"https://api.github.com/users/mldbai/orgs","repos_url":"https://api.github.com/users/mldbai/repos","events_url":"https://api.github.com/users/mldbai/events{/privacy}","received_events_url":"https://api.github.com/users/mldbai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mldbai/mldb","description":"MLDB is the Machine Learning Database","fork":false,"url":"https://api.github.com/repos/mldbai/mldb","forks_url":"https://api.github.com/repos/mldbai/mldb/forks","keys_url":"https://api.github.com/repos/mldbai/mldb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mldbai/mldb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mldbai/mldb/teams","hooks_url":"https://api.github.com/repos/mldbai/mldb/hooks","issue_events_url":"https://api.github.com/repos/mldbai/mldb/issues/events{/number}","events_url":"https://api.github.com/repos/mldbai/mldb/events","assignees_url":"https://api.github.com/repos/mldbai/mldb/assignees{/user}","branches_url":"https://api.github.com/repos/mldbai/mldb/branches{/branch}","tags_url":"https://api.github.com/repos/mldbai/mldb/tags","blobs_url":"https://api.github.com/repos/mldbai/mldb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mldbai/mldb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mldbai/mldb/git/refs{/sha}","trees_url":"https://api.github.com/repos/mldbai/mldb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mldbai/mldb/statuses/{sha}","languages_url":"https://api.github.com/repos/mldbai/mldb/languages","stargazers_url":"https://api.github.com/repos/mldbai/mldb/stargazers","contributors_url":"https://api.github.com/repos/mldbai/mldb/contributors","subscribers_url":"https://api.github.com/repos/mldbai/mldb/subscribers","subscription_url":"https://api.github.com/repos/mldbai/mldb/subscription","commits_url":"https://api.github.com/repos/mldbai/mldb/commits{/sha}","git_commits_url":"https://api.github.com/repos/mldbai/mldb/git/commits{/sha}","comments_url":"https://api.github.com/repos/mldbai/mldb/comments{/number}","issue_comment_url":"https://api.github.com/repos/mldbai/mldb/issues/comments{/number}","contents_url":"https://api.github.com/repos/mldbai/mldb/contents/{+path}","compare_url":"https://api.github.com/repos/mldbai/mldb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mldbai/mldb/merges","archive_url":"https://api.github.com/repos/mldbai/mldb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mldbai/mldb/downloads","issues_url":"https://api.github.com/repos/mldbai/mldb/issues{/number}","pulls_url":"https://api.github.com/repos/mldbai/mldb/pulls{/number}","milestones_url":"https://api.github.com/repos/mldbai/mldb/milestones{/number}","notifications_url":"https://api.github.com/repos/mldbai/mldb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mldbai/mldb/labels{/name}","releases_url":"https://api.github.com/repos/mldbai/mldb/releases{/id}","deployments_url":"https://api.github.com/repos/mldbai/mldb/deployments","created_at":"2015-12-08T16:34:16Z","updated_at":"2016-10-18T01:06:56Z","pushed_at":"2016-10-19T15:20:42Z","git_url":"git://github.com/mldbai/mldb.git","ssh_url":"git@github.com:mldbai/mldb.git","clone_url":"https://github.com/mldbai/mldb.git","svn_url":"https://github.com/mldbai/mldb","homepage":"http://mldb.ai","size":31591,"stargazers_count":225,"watchers_count":225,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":25,"forks":18,"open_issues":25,"watchers":225,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mldbai/mldb/pulls/724"},"html":{"href":"https://github.com/mldbai/mldb/pull/724"},"issue":{"href":"https://api.github.com/repos/mldbai/mldb/issues/724"},"comments":{"href":"https://api.github.com/repos/mldbai/mldb/issues/724/comments"},"review_comments":{"href":"https://api.github.com/repos/mldbai/mldb/pulls/724/comments"},"review_comment":{"href":"https://api.github.com/repos/mldbai/mldb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mldbai/mldb/pulls/724/commits"},"statuses":{"href":"https://api.github.com/repos/mldbai/mldb/statuses/5e36586f44297a4058683821d7ddd8e721af9b1f"}}}}
{"actor":{"display_login":"jeremybarnes"}}