{"action":"created","issue":{"url":"https://api.github.com/repos/apache/flink/issues/2571","repository_url":"https://api.github.com/repos/apache/flink","labels_url":"https://api.github.com/repos/apache/flink/issues/2571/labels{/name}","comments_url":"https://api.github.com/repos/apache/flink/issues/2571/comments","events_url":"https://api.github.com/repos/apache/flink/issues/2571/events","html_url":"https://github.com/apache/flink/pull/2571","id":180084676,"number":2571,"title":"[FLINK-4348] Simplify logic of SlotManager","user":{"login":"mxm","id":837221,"avatar_url":"https://avatars.githubusercontent.com/u/837221?v=3","gravatar_id":"","url":"https://api.github.com/users/mxm","html_url":"https://github.com/mxm","followers_url":"https://api.github.com/users/mxm/followers","following_url":"https://api.github.com/users/mxm/following{/other_user}","gists_url":"https://api.github.com/users/mxm/gists{/gist_id}","starred_url":"https://api.github.com/users/mxm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxm/subscriptions","organizations_url":"https://api.github.com/users/mxm/orgs","repos_url":"https://api.github.com/users/mxm/repos","events_url":"https://api.github.com/users/mxm/events{/privacy}","received_events_url":"https://api.github.com/users/mxm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-09-29T15:37:49Z","updated_at":"2016-09-30T09:47:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/2571","html_url":"https://github.com/apache/flink/pull/2571","diff_url":"https://github.com/apache/flink/pull/2571.diff","patch_url":"https://github.com/apache/flink/pull/2571.patch"},"body":"This pull request is split up into two commits:\r\n\r\n1. It removes some code from the `SlotManager` to make it simpler. \r\n  - It makes use of `handleSlotRequestFailedAtTaskManager` and simplifies it because we can assume that a Slot is only registered once if we talk to the same instance of a TaskExecutor. Further, we can omit to check the free slots because we previously removed the slot from the free slots.\r\n  - `updateSlotStatus` only deals with new Task slots. All other updates are performed by the `ResourceManager`. In case the ResourceManager creashes, it will re-register all slot statuses.\r\n\r\n2. It fences `TaskExecutor` messages using an `InstanceID` which is required to make 1 work correctly. New messages have been introduced to achieve that."},"comment":{"url":"https://api.github.com/repos/apache/flink/issues/comments/250704694","html_url":"https://github.com/apache/flink/pull/2571#issuecomment-250704694","issue_url":"https://api.github.com/repos/apache/flink/issues/2571","id":250704694,"user":{"login":"KurtYoung","id":955396,"avatar_url":"https://avatars.githubusercontent.com/u/955396?v=3","gravatar_id":"","url":"https://api.github.com/users/KurtYoung","html_url":"https://github.com/KurtYoung","followers_url":"https://api.github.com/users/KurtYoung/followers","following_url":"https://api.github.com/users/KurtYoung/following{/other_user}","gists_url":"https://api.github.com/users/KurtYoung/gists{/gist_id}","starred_url":"https://api.github.com/users/KurtYoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KurtYoung/subscriptions","organizations_url":"https://api.github.com/users/KurtYoung/orgs","repos_url":"https://api.github.com/users/KurtYoung/repos","events_url":"https://api.github.com/users/KurtYoung/events{/privacy}","received_events_url":"https://api.github.com/users/KurtYoung/received_events","type":"User","site_admin":false},"created_at":"2016-09-30T09:47:36Z","updated_at":"2016-09-30T09:47:36Z","body":"@mxm I think that situation will happen when RM request slot from TM, TM accept the request, but the response was somehow missed. Typically, when an rpc error occurred, the send could not know whether the receiver handles that request or not. \r\n\r\nThe changes looks good to me. "}}
{"actor":{"display_login":"KurtYoung"}}