{"action":"created","issue":{"url":"https://api.github.com/repos/sherpa/sherpa/issues/267","repository_url":"https://api.github.com/repos/sherpa/sherpa","labels_url":"https://api.github.com/repos/sherpa/sherpa/issues/267/labels{/name}","comments_url":"https://api.github.com/repos/sherpa/sherpa/issues/267/comments","events_url":"https://api.github.com/repos/sherpa/sherpa/issues/267/events","html_url":"https://github.com/sherpa/sherpa/pull/267","id":175641716,"number":267,"title":"add wstat tests","user":{"login":"DougBurke","id":224638,"avatar_url":"https://avatars.githubusercontent.com/u/224638?v=3","gravatar_id":"","url":"https://api.github.com/users/DougBurke","html_url":"https://github.com/DougBurke","followers_url":"https://api.github.com/users/DougBurke/followers","following_url":"https://api.github.com/users/DougBurke/following{/other_user}","gists_url":"https://api.github.com/users/DougBurke/gists{/gist_id}","starred_url":"https://api.github.com/users/DougBurke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DougBurke/subscriptions","organizations_url":"https://api.github.com/users/DougBurke/orgs","repos_url":"https://api.github.com/users/DougBurke/repos","events_url":"https://api.github.com/users/DougBurke/events{/privacy}","received_events_url":"https://api.github.com/users/DougBurke/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sherpa/sherpa/labels/3%20%20-%20Working","name":"3  - Working","color":"ededed"},{"url":"https://api.github.com/repos/sherpa/sherpa/labels/area:tests","name":"area:tests","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/sherpa/sherpa/milestones/3","html_url":"https://github.com/sherpa/sherpa/milestones/4.8.2","labels_url":"https://api.github.com/repos/sherpa/sherpa/milestones/3/labels","id":1652200,"number":3,"title":"4.8.2","description":"","creator":{"login":"olaurino","id":5692321,"avatar_url":"https://avatars.githubusercontent.com/u/5692321?v=3","gravatar_id":"","url":"https://api.github.com/users/olaurino","html_url":"https://github.com/olaurino","followers_url":"https://api.github.com/users/olaurino/followers","following_url":"https://api.github.com/users/olaurino/following{/other_user}","gists_url":"https://api.github.com/users/olaurino/gists{/gist_id}","starred_url":"https://api.github.com/users/olaurino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olaurino/subscriptions","organizations_url":"https://api.github.com/users/olaurino/orgs","repos_url":"https://api.github.com/users/olaurino/repos","events_url":"https://api.github.com/users/olaurino/events{/privacy}","received_events_url":"https://api.github.com/users/olaurino/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":18,"state":"open","created_at":"2016-03-17T20:37:49Z","updated_at":"2016-09-09T19:13:31Z","due_on":"2016-09-01T04:00:00Z","closed_at":null},"comments":17,"created_at":"2016-09-08T01:03:27Z","updated_at":"2016-09-09T19:50:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sherpa/sherpa/pulls/267","html_url":"https://github.com/sherpa/sherpa/pull/267","diff_url":"https://github.com/sherpa/sherpa/pull/267.diff","patch_url":"https://github.com/sherpa/sherpa/pull/267.patch"},"body":"# Summary\r\n\r\nAdd several regression tests for wstat.\r\n\r\n# Details\r\n\r\nIssue #248 pointed out some problems with wstat (in particular, when used with a dataset with a non-scalar backscal value that had been filtered). The simple fix to this (PR #249) has caused problems elsewhere. In order to help disentangle things, this test suite is a set of simple regression tests, intended to exercise the various options, in particular:\r\n\r\n- grouped vs ungrouped\r\n- filtered vs unfiltered\r\n- scalar vs array for the BACKSCAL value\r\n\r\nThree of the tests are marked as \"Expected Fail\", and cover the cases that are fixed in #249 as well as the cases that are causing problems with #249 (which are from tests added to the master branch in PR #195 and being tested as part of #249).\r\n\r\n# Notes\r\n\r\nI have included PR #263 in this PR in order to give the tests a chance on Travis. This can be rebased once 263 has been merged."},"comment":{"url":"https://api.github.com/repos/sherpa/sherpa/issues/comments/246020527","html_url":"https://github.com/sherpa/sherpa/pull/267#issuecomment-246020527","issue_url":"https://api.github.com/repos/sherpa/sherpa/issues/267","id":246020527,"user":{"login":"DougBurke","id":224638,"avatar_url":"https://avatars.githubusercontent.com/u/224638?v=3","gravatar_id":"","url":"https://api.github.com/users/DougBurke","html_url":"https://github.com/DougBurke","followers_url":"https://api.github.com/users/DougBurke/followers","following_url":"https://api.github.com/users/DougBurke/following{/other_user}","gists_url":"https://api.github.com/users/DougBurke/gists{/gist_id}","starred_url":"https://api.github.com/users/DougBurke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DougBurke/subscriptions","organizations_url":"https://api.github.com/users/DougBurke/orgs","repos_url":"https://api.github.com/users/DougBurke/repos","events_url":"https://api.github.com/users/DougBurke/events{/privacy}","received_events_url":"https://api.github.com/users/DougBurke/received_events","type":"User","site_admin":false},"created_at":"2016-09-09T19:50:25Z","updated_at":"2016-09-09T19:50:25Z","body":"Rebased against master. Original tip was 4f691545512aef201fa65591fbd1b1ca85c3af18\r\n\r\nI took the opportunity to squash the commits.  I have also add regression tests for issue #227 which I developed as part of #269 (these add two new `expectedFailure` cases). It's nice to get a test in that demonstrates the problem before any fix is added.\r\n\r\nI did look at `py.test` but quickly decided I don't have the time to learn how to use it and still get things in for 4.8.2."}}
{"actor":{"display_login":"DougBurke"}}