{"action":"created","comment":{"url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments/55752042","id":55752042,"diff_hunk":"@@ -26,8 +26,22 @@ <h1 class=\"instructions\">Description</h1>\n     t.done();\n   }),\n   t.step_func(function (error) {\n-    assert_equals(error.name, \"SecurityError\", \"SecurityError returned\");\n-    assert_equals(error.constraintName, null, \"constraintName attribute not set for permission denied\");\n+    // NOTE ALEX: last call specs and editor specs differ here:\n+    // editor draft, 2016: https://w3c.github.io/mediacapture-main/getusermedia.html\n+    // assert_equals(error.name, \"securityError\", \"securityError returned\");\n+    // last call working draft, 2016: https://www.w3.org/TR/mediacapture-streams/\n+    // assert_equals(error.name, \"PermissionDeniedError\", \"PermissionDeniedError returned\");\n+    if(error.name != \"SecurityError\" &&          // FF\n+       error.name != \"PermissionDeniedError\") {  // all others\n+      assert_unreached(\"Error type is neither securityError or PermissionDeniedError.\");\n+      t.done();\n+    };\n+    // NOTE ALEX: this is also nullable, but practically, all the browsers but FF set it to an empty string.","path":"mediacapture-streams/obtaining-local-multimedia-content/navigatorusermedia/deny.html","position":16,"original_position":16,"commit_id":"55e8dfa0864b2e90baa87ccf03f004dbeae4fe28","original_commit_id":"55e8dfa0864b2e90baa87ccf03f004dbeae4fe28","user":{"login":"agouaillard","id":325022,"avatar_url":"https://avatars.githubusercontent.com/u/325022?v=3","gravatar_id":"","url":"https://api.github.com/users/agouaillard","html_url":"https://github.com/agouaillard","followers_url":"https://api.github.com/users/agouaillard/followers","following_url":"https://api.github.com/users/agouaillard/following{/other_user}","gists_url":"https://api.github.com/users/agouaillard/gists{/gist_id}","starred_url":"https://api.github.com/users/agouaillard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agouaillard/subscriptions","organizations_url":"https://api.github.com/users/agouaillard/orgs","repos_url":"https://api.github.com/users/agouaillard/repos","events_url":"https://api.github.com/users/agouaillard/events{/privacy}","received_events_url":"https://api.github.com/users/agouaillard/received_events","type":"User","site_admin":false},"body":"that has been resolved of line. My mistake the original test was actually correct. I m correcting that.","created_at":"2016-03-10T21:25:27Z","updated_at":"2016-03-10T21:25:27Z","html_url":"https://github.com/w3c/web-platform-tests/pull/2657#discussion_r55752042","pull_request_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/2657","_links":{"self":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments/55752042"},"html":{"href":"https://github.com/w3c/web-platform-tests/pull/2657#discussion_r55752042"},"pull_request":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/2657"}}},"pull_request":{"url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/2657","id":61827353,"html_url":"https://github.com/w3c/web-platform-tests/pull/2657","diff_url":"https://github.com/w3c/web-platform-tests/pull/2657.diff","patch_url":"https://github.com/w3c/web-platform-tests/pull/2657.patch","issue_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/2657","number":2657,"state":"open","locked":false,"title":"Add Basic navigator.mediaDevices test.","user":{"login":"agouaillard","id":325022,"avatar_url":"https://avatars.githubusercontent.com/u/325022?v=3","gravatar_id":"","url":"https://api.github.com/users/agouaillard","html_url":"https://github.com/agouaillard","followers_url":"https://api.github.com/users/agouaillard/followers","following_url":"https://api.github.com/users/agouaillard/following{/other_user}","gists_url":"https://api.github.com/users/agouaillard/gists{/gist_id}","starred_url":"https://api.github.com/users/agouaillard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agouaillard/subscriptions","organizations_url":"https://api.github.com/users/agouaillard/orgs","repos_url":"https://api.github.com/users/agouaillard/repos","events_url":"https://api.github.com/users/agouaillard/events{/privacy}","received_events_url":"https://api.github.com/users/agouaillard/received_events","type":"User","site_admin":false},"body":"=> DOM","created_at":"2016-03-05T23:05:00Z","updated_at":"2016-03-10T21:25:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8dd9b2840a020bcea9ce06443ffc5ded0e8eddc6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/2657/commits","review_comments_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/2657/comments","review_comment_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/2657/comments","statuses_url":"https://api.github.com/repos/w3c/web-platform-tests/statuses/55e8dfa0864b2e90baa87ccf03f004dbeae4fe28","head":{"label":"agouaillard:master","ref":"master","sha":"55e8dfa0864b2e90baa87ccf03f004dbeae4fe28","user":{"login":"agouaillard","id":325022,"avatar_url":"https://avatars.githubusercontent.com/u/325022?v=3","gravatar_id":"","url":"https://api.github.com/users/agouaillard","html_url":"https://github.com/agouaillard","followers_url":"https://api.github.com/users/agouaillard/followers","following_url":"https://api.github.com/users/agouaillard/following{/other_user}","gists_url":"https://api.github.com/users/agouaillard/gists{/gist_id}","starred_url":"https://api.github.com/users/agouaillard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agouaillard/subscriptions","organizations_url":"https://api.github.com/users/agouaillard/orgs","repos_url":"https://api.github.com/users/agouaillard/repos","events_url":"https://api.github.com/users/agouaillard/events{/privacy}","received_events_url":"https://api.github.com/users/agouaillard/received_events","type":"User","site_admin":false},"repo":{"id":52818903,"name":"web-platform-tests","full_name":"agouaillard/web-platform-tests","owner":{"login":"agouaillard","id":325022,"avatar_url":"https://avatars.githubusercontent.com/u/325022?v=3","gravatar_id":"","url":"https://api.github.com/users/agouaillard","html_url":"https://github.com/agouaillard","followers_url":"https://api.github.com/users/agouaillard/followers","following_url":"https://api.github.com/users/agouaillard/following{/other_user}","gists_url":"https://api.github.com/users/agouaillard/gists{/gist_id}","starred_url":"https://api.github.com/users/agouaillard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agouaillard/subscriptions","organizations_url":"https://api.github.com/users/agouaillard/orgs","repos_url":"https://api.github.com/users/agouaillard/repos","events_url":"https://api.github.com/users/agouaillard/events{/privacy}","received_events_url":"https://api.github.com/users/agouaillard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agouaillard/web-platform-tests","description":"Test Suites for Web Platform specifications—including WHATWG, W3C and others","fork":true,"url":"https://api.github.com/repos/agouaillard/web-platform-tests","forks_url":"https://api.github.com/repos/agouaillard/web-platform-tests/forks","keys_url":"https://api.github.com/repos/agouaillard/web-platform-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agouaillard/web-platform-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agouaillard/web-platform-tests/teams","hooks_url":"https://api.github.com/repos/agouaillard/web-platform-tests/hooks","issue_events_url":"https://api.github.com/repos/agouaillard/web-platform-tests/issues/events{/number}","events_url":"https://api.github.com/repos/agouaillard/web-platform-tests/events","assignees_url":"https://api.github.com/repos/agouaillard/web-platform-tests/assignees{/user}","branches_url":"https://api.github.com/repos/agouaillard/web-platform-tests/branches{/branch}","tags_url":"https://api.github.com/repos/agouaillard/web-platform-tests/tags","blobs_url":"https://api.github.com/repos/agouaillard/web-platform-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agouaillard/web-platform-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agouaillard/web-platform-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/agouaillard/web-platform-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agouaillard/web-platform-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/agouaillard/web-platform-tests/languages","stargazers_url":"https://api.github.com/repos/agouaillard/web-platform-tests/stargazers","contributors_url":"https://api.github.com/repos/agouaillard/web-platform-tests/contributors","subscribers_url":"https://api.github.com/repos/agouaillard/web-platform-tests/subscribers","subscription_url":"https://api.github.com/repos/agouaillard/web-platform-tests/subscription","commits_url":"https://api.github.com/repos/agouaillard/web-platform-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/agouaillard/web-platform-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/agouaillard/web-platform-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/agouaillard/web-platform-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/agouaillard/web-platform-tests/contents/{+path}","compare_url":"https://api.github.com/repos/agouaillard/web-platform-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agouaillard/web-platform-tests/merges","archive_url":"https://api.github.com/repos/agouaillard/web-platform-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agouaillard/web-platform-tests/downloads","issues_url":"https://api.github.com/repos/agouaillard/web-platform-tests/issues{/number}","pulls_url":"https://api.github.com/repos/agouaillard/web-platform-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/agouaillard/web-platform-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/agouaillard/web-platform-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agouaillard/web-platform-tests/labels{/name}","releases_url":"https://api.github.com/repos/agouaillard/web-platform-tests/releases{/id}","deployments_url":"https://api.github.com/repos/agouaillard/web-platform-tests/deployments","created_at":"2016-02-29T19:43:44Z","updated_at":"2016-02-29T19:44:10Z","pushed_at":"2016-03-06T02:53:33Z","git_url":"git://github.com/agouaillard/web-platform-tests.git","ssh_url":"git@github.com:agouaillard/web-platform-tests.git","clone_url":"https://github.com/agouaillard/web-platform-tests.git","svn_url":"https://github.com/agouaillard/web-platform-tests","homepage":"http://irc.w3.org/?channels=testing","size":149618,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"w3c:master","ref":"master","sha":"da8893c3d432f82d962b05dccaca1c6dbce0d137","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":3618133,"name":"web-platform-tests","full_name":"w3c/web-platform-tests","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/web-platform-tests","description":"Test Suites for Web Platform specifications—including WHATWG, W3C and others","fork":false,"url":"https://api.github.com/repos/w3c/web-platform-tests","forks_url":"https://api.github.com/repos/w3c/web-platform-tests/forks","keys_url":"https://api.github.com/repos/w3c/web-platform-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/web-platform-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/web-platform-tests/teams","hooks_url":"https://api.github.com/repos/w3c/web-platform-tests/hooks","issue_events_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/web-platform-tests/events","assignees_url":"https://api.github.com/repos/w3c/web-platform-tests/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/web-platform-tests/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/web-platform-tests/tags","blobs_url":"https://api.github.com/repos/w3c/web-platform-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/web-platform-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/web-platform-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/web-platform-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/web-platform-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/web-platform-tests/languages","stargazers_url":"https://api.github.com/repos/w3c/web-platform-tests/stargazers","contributors_url":"https://api.github.com/repos/w3c/web-platform-tests/contributors","subscribers_url":"https://api.github.com/repos/w3c/web-platform-tests/subscribers","subscription_url":"https://api.github.com/repos/w3c/web-platform-tests/subscription","commits_url":"https://api.github.com/repos/w3c/web-platform-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/web-platform-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/web-platform-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/web-platform-tests/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/web-platform-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/web-platform-tests/merges","archive_url":"https://api.github.com/repos/w3c/web-platform-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/web-platform-tests/downloads","issues_url":"https://api.github.com/repos/w3c/web-platform-tests/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/web-platform-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/web-platform-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/web-platform-tests/labels{/name}","releases_url":"https://api.github.com/repos/w3c/web-platform-tests/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/web-platform-tests/deployments","created_at":"2012-03-04T12:58:11Z","updated_at":"2016-03-08T06:29:25Z","pushed_at":"2016-03-10T11:12:53Z","git_url":"git://github.com/w3c/web-platform-tests.git","ssh_url":"git@github.com:w3c/web-platform-tests.git","clone_url":"https://github.com/w3c/web-platform-tests.git","svn_url":"https://github.com/w3c/web-platform-tests","homepage":"http://irc.w3.org/?channels=testing","size":293537,"stargazers_count":728,"watchers_count":728,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":817,"mirror_url":null,"open_issues_count":261,"forks":817,"open_issues":261,"watchers":728,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/2657"},"html":{"href":"https://github.com/w3c/web-platform-tests/pull/2657"},"issue":{"href":"https://api.github.com/repos/w3c/web-platform-tests/issues/2657"},"comments":{"href":"https://api.github.com/repos/w3c/web-platform-tests/issues/2657/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/2657/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/2657/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/web-platform-tests/statuses/55e8dfa0864b2e90baa87ccf03f004dbeae4fe28"}}}}