{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/49536779","id":49536779,"diff_hunk":"@@ -115,3 +123,23 @@ type MemoryStats struct {\n \t// Cumulative number of major page faults.\n \tMajorPageFaults *int64 `json:\"majorPageFaults,omitempty\"`\n }\n+\n+// VolumeStats contains data about Volume filesystem usage.\n+type VolumeStats struct {\n+\t// Embedded FsStats\n+\tFsStats\n+\t// Path is the directory path the Volume is mounted to\n+\tPath string `json:\"path,omitempty\"`\n+}\n+\n+// FsStats contains data about filesystem usage.\n+type FsStats struct {\n+\t// Unique identifier for the filesystem device so that FsStats can be aggregated per-device\n+\tDeviceId string `json:\"deviceId\"`","path":"pkg/kubelet/server/stats/types.go","position":45,"original_position":45,"commit_id":"9caafb4fc9783429e89f19992d0e613ed8f21647","original_commit_id":"9caafb4fc9783429e89f19992d0e613ed8f21647","user":{"login":"pwittrock","id":7882754,"avatar_url":"https://avatars.githubusercontent.com/u/7882754?v=3","gravatar_id":"","url":"https://api.github.com/users/pwittrock","html_url":"https://github.com/pwittrock","followers_url":"https://api.github.com/users/pwittrock/followers","following_url":"https://api.github.com/users/pwittrock/following{/other_user}","gists_url":"https://api.github.com/users/pwittrock/gists{/gist_id}","starred_url":"https://api.github.com/users/pwittrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwittrock/subscriptions","organizations_url":"https://api.github.com/users/pwittrock/orgs","repos_url":"https://api.github.com/users/pwittrock/repos","events_url":"https://api.github.com/users/pwittrock/events{/privacy}","received_events_url":"https://api.github.com/users/pwittrock/received_events","type":"User","site_admin":false},"body":"SGTM.  There will not be a sensible way of aggregating the total fs usage for a pod across logs / rootfs / volumes as we will not know if the device is shared.","created_at":"2016-01-13T00:30:15Z","updated_at":"2016-01-13T00:30:15Z","html_url":"https://github.com/kubernetes/kubernetes/pull/19572#discussion_r49536779","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19572","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/49536779"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/19572#discussion_r49536779"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19572"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19572","id":55831994,"html_url":"https://github.com/kubernetes/kubernetes/pull/19572","diff_url":"https://github.com/kubernetes/kubernetes/pull/19572.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/19572.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/19572","number":19572,"state":"open","locked":false,"title":"Define stats api fields for exporting filesystem metrics #17331","user":{"login":"pwittrock","id":7882754,"avatar_url":"https://avatars.githubusercontent.com/u/7882754?v=3","gravatar_id":"","url":"https://api.github.com/users/pwittrock","html_url":"https://github.com/pwittrock","followers_url":"https://api.github.com/users/pwittrock/followers","following_url":"https://api.github.com/users/pwittrock/following{/other_user}","gists_url":"https://api.github.com/users/pwittrock/gists{/gist_id}","starred_url":"https://api.github.com/users/pwittrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwittrock/subscriptions","organizations_url":"https://api.github.com/users/pwittrock/orgs","repos_url":"https://api.github.com/users/pwittrock/repos","events_url":"https://api.github.com/users/pwittrock/events{/privacy}","received_events_url":"https://api.github.com/users/pwittrock/received_events","type":"User","site_admin":false},"body":"Defines fields for exporting filesystem metrics for containters and volumes\r\n\r\n@vishh ","created_at":"2016-01-12T23:12:48Z","updated_at":"2016-01-13T00:30:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53a37fe5c6d0d502043083c4cadaeab18d67d0e3","assignee":{"login":"timstclair","id":3272040,"avatar_url":"https://avatars.githubusercontent.com/u/3272040?v=3","gravatar_id":"","url":"https://api.github.com/users/timstclair","html_url":"https://github.com/timstclair","followers_url":"https://api.github.com/users/timstclair/followers","following_url":"https://api.github.com/users/timstclair/following{/other_user}","gists_url":"https://api.github.com/users/timstclair/gists{/gist_id}","starred_url":"https://api.github.com/users/timstclair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timstclair/subscriptions","organizations_url":"https://api.github.com/users/timstclair/orgs","repos_url":"https://api.github.com/users/timstclair/repos","events_url":"https://api.github.com/users/timstclair/events{/privacy}","received_events_url":"https://api.github.com/users/timstclair/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19572/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19572/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/19572/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/9caafb4fc9783429e89f19992d0e613ed8f21647","head":{"label":"pwittrock:exportfsmetrics","ref":"exportfsmetrics","sha":"9caafb4fc9783429e89f19992d0e613ed8f21647","user":{"login":"pwittrock","id":7882754,"avatar_url":"https://avatars.githubusercontent.com/u/7882754?v=3","gravatar_id":"","url":"https://api.github.com/users/pwittrock","html_url":"https://github.com/pwittrock","followers_url":"https://api.github.com/users/pwittrock/followers","following_url":"https://api.github.com/users/pwittrock/following{/other_user}","gists_url":"https://api.github.com/users/pwittrock/gists{/gist_id}","starred_url":"https://api.github.com/users/pwittrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwittrock/subscriptions","organizations_url":"https://api.github.com/users/pwittrock/orgs","repos_url":"https://api.github.com/users/pwittrock/repos","events_url":"https://api.github.com/users/pwittrock/events{/privacy}","received_events_url":"https://api.github.com/users/pwittrock/received_events","type":"User","site_admin":false},"repo":{"id":40577370,"name":"kubernetes","full_name":"pwittrock/kubernetes","owner":{"login":"pwittrock","id":7882754,"avatar_url":"https://avatars.githubusercontent.com/u/7882754?v=3","gravatar_id":"","url":"https://api.github.com/users/pwittrock","html_url":"https://github.com/pwittrock","followers_url":"https://api.github.com/users/pwittrock/followers","following_url":"https://api.github.com/users/pwittrock/following{/other_user}","gists_url":"https://api.github.com/users/pwittrock/gists{/gist_id}","starred_url":"https://api.github.com/users/pwittrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwittrock/subscriptions","organizations_url":"https://api.github.com/users/pwittrock/orgs","repos_url":"https://api.github.com/users/pwittrock/repos","events_url":"https://api.github.com/users/pwittrock/events{/privacy}","received_events_url":"https://api.github.com/users/pwittrock/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pwittrock/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/pwittrock/kubernetes","forks_url":"https://api.github.com/repos/pwittrock/kubernetes/forks","keys_url":"https://api.github.com/repos/pwittrock/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pwittrock/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pwittrock/kubernetes/teams","hooks_url":"https://api.github.com/repos/pwittrock/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/pwittrock/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/pwittrock/kubernetes/events","assignees_url":"https://api.github.com/repos/pwittrock/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/pwittrock/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/pwittrock/kubernetes/tags","blobs_url":"https://api.github.com/repos/pwittrock/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pwittrock/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pwittrock/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/pwittrock/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pwittrock/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/pwittrock/kubernetes/languages","stargazers_url":"https://api.github.com/repos/pwittrock/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/pwittrock/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/pwittrock/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/pwittrock/kubernetes/subscription","commits_url":"https://api.github.com/repos/pwittrock/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/pwittrock/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/pwittrock/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/pwittrock/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/pwittrock/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/pwittrock/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pwittrock/kubernetes/merges","archive_url":"https://api.github.com/repos/pwittrock/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pwittrock/kubernetes/downloads","issues_url":"https://api.github.com/repos/pwittrock/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/pwittrock/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/pwittrock/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/pwittrock/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pwittrock/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/pwittrock/kubernetes/releases{/id}","created_at":"2015-08-12T03:03:08Z","updated_at":"2016-01-12T23:13:27Z","pushed_at":"2016-01-12T23:13:22Z","git_url":"git://github.com/pwittrock/kubernetes.git","ssh_url":"git@github.com:pwittrock/kubernetes.git","clone_url":"https://github.com/pwittrock/kubernetes.git","svn_url":"https://github.com/pwittrock/kubernetes","homepage":"http://kubernetes.io","size":147378,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"6d367480f9d1442d0dd3c910a2d6b1677a14ae29","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-01-12T22:37:07Z","pushed_at":"2016-01-13T00:27:04Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":304066,"stargazers_count":12095,"watchers_count":12095,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3382,"mirror_url":null,"open_issues_count":2758,"forks":3382,"open_issues":2758,"watchers":12095,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19572"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/19572"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/19572"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/19572/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19572/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19572/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/9caafb4fc9783429e89f19992d0e613ed8f21647"}}}}