{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/comments/66133536","id":66133536,"diff_hunk":"@@ -438,6 +454,10 @@ else\n     done\n fi\n \n+if [ \"$TEST_MIGRATE_UPGRADE\" = \"false\" ] ; then","path":"hack/testing/logging.sh","position":34,"original_position":34,"commit_id":"11e11e93caec61914ab853db912ebcc928ad318c","original_commit_id":"11e11e93caec61914ab853db912ebcc928ad318c","user":{"login":"ewolinetz","id":1427473,"avatar_url":"https://avatars.githubusercontent.com/u/1427473?v=3","gravatar_id":"","url":"https://api.github.com/users/ewolinetz","html_url":"https://github.com/ewolinetz","followers_url":"https://api.github.com/users/ewolinetz/followers","following_url":"https://api.github.com/users/ewolinetz/following{/other_user}","gists_url":"https://api.github.com/users/ewolinetz/gists{/gist_id}","starred_url":"https://api.github.com/users/ewolinetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewolinetz/subscriptions","organizations_url":"https://api.github.com/users/ewolinetz/orgs","repos_url":"https://api.github.com/users/ewolinetz/repos","events_url":"https://api.github.com/users/ewolinetz/events{/privacy}","received_events_url":"https://api.github.com/users/ewolinetz/received_events","type":"User","site_admin":false},"body":"this overlaps and is probably of no use with https://github.com/openshift/origin-aggregated-logging/pull/162","created_at":"2016-06-07T19:09:04Z","updated_at":"2016-06-07T19:09:04Z","html_url":"https://github.com/openshift/origin-aggregated-logging/pull/142#discussion_r66133536","pull_request_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/142","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/comments/66133536"},"html":{"href":"https://github.com/openshift/origin-aggregated-logging/pull/142#discussion_r66133536"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/142"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/142","id":70779498,"html_url":"https://github.com/openshift/origin-aggregated-logging/pull/142","diff_url":"https://github.com/openshift/origin-aggregated-logging/pull/142.diff","patch_url":"https://github.com/openshift/origin-aggregated-logging/pull/142.patch","issue_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/142","number":142,"state":"open","locked":false,"title":"Allow reading system logs from the journal instead of /var/log/messages","user":{"login":"richm","id":23066,"avatar_url":"https://avatars.githubusercontent.com/u/23066?v=3","gravatar_id":"","url":"https://api.github.com/users/richm","html_url":"https://github.com/richm","followers_url":"https://api.github.com/users/richm/followers","following_url":"https://api.github.com/users/richm/following{/other_user}","gists_url":"https://api.github.com/users/richm/gists{/gist_id}","starred_url":"https://api.github.com/users/richm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richm/subscriptions","organizations_url":"https://api.github.com/users/richm/orgs","repos_url":"https://api.github.com/users/richm/repos","events_url":"https://api.github.com/users/richm/events{/privacy}","received_events_url":"https://api.github.com/users/richm/received_events","type":"User","site_admin":false},"body":"This introduces a new environment variable: USE_JOURNAL.  If this is\r\nset to \"true\", fluentd will use the systemd-journal input plugin to\r\nread log messages from the journal instead of /var/log/messages*.\r\nThe immediate benefit is performance - reading log entries directly\r\nfrom the journal rather than having them go from the journal to\r\nrsyslog to /var/log/messages.  Another benefit is the microsecond\r\nprecision timestamps instead of seconds used by /var/log/messages.\r\nThere is a lot of metadata available from the journal which we can\r\nnow use.\r\nThis is not yet a complete replacement for the file based input.\r\n\r\n* Need to handle log throttling.  Might have to be done at the\r\n  journal level - there aren't any sort of throttling configuration\r\n  options in https://github.com/reevoo/fluent-plugin-systemd\r\n  journald (man journald.conf) has RateLimitInterval=, RateLimitBurst=\r\n  options.\r\n* Need to handle the case if user has configured persistent journal\r\n  logs (man journald.conf - Storage=) so may need to read from\r\n  /var/log/journal in addition to/instead of /run/log/journal\r\n* Need to handle historical logs.  The default configuration for\r\n  journald.conf on el7 is `Storage=auto` which means /run/log/journal\r\n  will be used for `volatile` storage unless the user has created\r\n  /var/log/journal.  `volatile` means not persistent, so the persistent\r\n  logs by default will be /var/log/messages*.  We need some way to grab\r\n  those logs, and de-dup them before storing in elasticsearch.","created_at":"2016-05-19T23:04:26Z","updated_at":"2016-06-07T19:09:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"091e81f43c1c7685012f3cfdf9136f066c7c44ea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/142/commits","review_comments_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/142/comments","review_comment_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/142/comments","statuses_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/statuses/11e11e93caec61914ab853db912ebcc928ad318c","head":{"label":"richm:use-journal","ref":"use-journal","sha":"11e11e93caec61914ab853db912ebcc928ad318c","user":{"login":"richm","id":23066,"avatar_url":"https://avatars.githubusercontent.com/u/23066?v=3","gravatar_id":"","url":"https://api.github.com/users/richm","html_url":"https://github.com/richm","followers_url":"https://api.github.com/users/richm/followers","following_url":"https://api.github.com/users/richm/following{/other_user}","gists_url":"https://api.github.com/users/richm/gists{/gist_id}","starred_url":"https://api.github.com/users/richm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richm/subscriptions","organizations_url":"https://api.github.com/users/richm/orgs","repos_url":"https://api.github.com/users/richm/repos","events_url":"https://api.github.com/users/richm/events{/privacy}","received_events_url":"https://api.github.com/users/richm/received_events","type":"User","site_admin":false},"repo":{"id":49232711,"name":"origin-aggregated-logging","full_name":"richm/origin-aggregated-logging","owner":{"login":"richm","id":23066,"avatar_url":"https://avatars.githubusercontent.com/u/23066?v=3","gravatar_id":"","url":"https://api.github.com/users/richm","html_url":"https://github.com/richm","followers_url":"https://api.github.com/users/richm/followers","following_url":"https://api.github.com/users/richm/following{/other_user}","gists_url":"https://api.github.com/users/richm/gists{/gist_id}","starred_url":"https://api.github.com/users/richm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richm/subscriptions","organizations_url":"https://api.github.com/users/richm/orgs","repos_url":"https://api.github.com/users/richm/repos","events_url":"https://api.github.com/users/richm/events{/privacy}","received_events_url":"https://api.github.com/users/richm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/richm/origin-aggregated-logging","description":"","fork":true,"url":"https://api.github.com/repos/richm/origin-aggregated-logging","forks_url":"https://api.github.com/repos/richm/origin-aggregated-logging/forks","keys_url":"https://api.github.com/repos/richm/origin-aggregated-logging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richm/origin-aggregated-logging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richm/origin-aggregated-logging/teams","hooks_url":"https://api.github.com/repos/richm/origin-aggregated-logging/hooks","issue_events_url":"https://api.github.com/repos/richm/origin-aggregated-logging/issues/events{/number}","events_url":"https://api.github.com/repos/richm/origin-aggregated-logging/events","assignees_url":"https://api.github.com/repos/richm/origin-aggregated-logging/assignees{/user}","branches_url":"https://api.github.com/repos/richm/origin-aggregated-logging/branches{/branch}","tags_url":"https://api.github.com/repos/richm/origin-aggregated-logging/tags","blobs_url":"https://api.github.com/repos/richm/origin-aggregated-logging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richm/origin-aggregated-logging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richm/origin-aggregated-logging/git/refs{/sha}","trees_url":"https://api.github.com/repos/richm/origin-aggregated-logging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richm/origin-aggregated-logging/statuses/{sha}","languages_url":"https://api.github.com/repos/richm/origin-aggregated-logging/languages","stargazers_url":"https://api.github.com/repos/richm/origin-aggregated-logging/stargazers","contributors_url":"https://api.github.com/repos/richm/origin-aggregated-logging/contributors","subscribers_url":"https://api.github.com/repos/richm/origin-aggregated-logging/subscribers","subscription_url":"https://api.github.com/repos/richm/origin-aggregated-logging/subscription","commits_url":"https://api.github.com/repos/richm/origin-aggregated-logging/commits{/sha}","git_commits_url":"https://api.github.com/repos/richm/origin-aggregated-logging/git/commits{/sha}","comments_url":"https://api.github.com/repos/richm/origin-aggregated-logging/comments{/number}","issue_comment_url":"https://api.github.com/repos/richm/origin-aggregated-logging/issues/comments{/number}","contents_url":"https://api.github.com/repos/richm/origin-aggregated-logging/contents/{+path}","compare_url":"https://api.github.com/repos/richm/origin-aggregated-logging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richm/origin-aggregated-logging/merges","archive_url":"https://api.github.com/repos/richm/origin-aggregated-logging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richm/origin-aggregated-logging/downloads","issues_url":"https://api.github.com/repos/richm/origin-aggregated-logging/issues{/number}","pulls_url":"https://api.github.com/repos/richm/origin-aggregated-logging/pulls{/number}","milestones_url":"https://api.github.com/repos/richm/origin-aggregated-logging/milestones{/number}","notifications_url":"https://api.github.com/repos/richm/origin-aggregated-logging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richm/origin-aggregated-logging/labels{/name}","releases_url":"https://api.github.com/repos/richm/origin-aggregated-logging/releases{/id}","deployments_url":"https://api.github.com/repos/richm/origin-aggregated-logging/deployments","created_at":"2016-01-07T21:46:59Z","updated_at":"2016-01-14T20:15:40Z","pushed_at":"2016-06-07T14:59:37Z","git_url":"git://github.com/richm/origin-aggregated-logging.git","ssh_url":"git@github.com:richm/origin-aggregated-logging.git","clone_url":"https://github.com/richm/origin-aggregated-logging.git","svn_url":"https://github.com/richm/origin-aggregated-logging","homepage":null,"size":385,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"f5ce81c51707238a5036baa33e0329d45d74115f","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":42467822,"name":"origin-aggregated-logging","full_name":"openshift/origin-aggregated-logging","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin-aggregated-logging","description":"","fork":false,"url":"https://api.github.com/repos/openshift/origin-aggregated-logging","forks_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/forks","keys_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/teams","hooks_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/events","assignees_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/tags","blobs_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/languages","stargazers_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/subscription","commits_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/merges","archive_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/downloads","issues_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/deployments","created_at":"2015-09-14T18:14:19Z","updated_at":"2016-05-26T07:35:33Z","pushed_at":"2016-06-07T18:55:07Z","git_url":"git://github.com/openshift/origin-aggregated-logging.git","ssh_url":"git@github.com:openshift/origin-aggregated-logging.git","clone_url":"https://github.com/openshift/origin-aggregated-logging.git","svn_url":"https://github.com/openshift/origin-aggregated-logging","homepage":null,"size":356,"stargazers_count":7,"watchers_count":7,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":23,"forks":25,"open_issues":23,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/142"},"html":{"href":"https://github.com/openshift/origin-aggregated-logging/pull/142"},"issue":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/142"},"comments":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/142/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/142/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/142/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/statuses/11e11e93caec61914ab853db912ebcc928ad318c"}}}}
{"actor":{"display_login":"ewolinetz"}}