{"action":"opened","number":229,"pull_request":{"url":"https://api.github.com/repos/zulip/zulip-android/pulls/229","id":95404969,"html_url":"https://github.com/zulip/zulip-android/pull/229","diff_url":"https://github.com/zulip/zulip-android/pull/229.diff","patch_url":"https://github.com/zulip/zulip-android/pull/229.patch","issue_url":"https://api.github.com/repos/zulip/zulip-android/issues/229","number":229,"state":"open","locked":false,"title":"Fix bug#227","user":{"login":"Sam1301","id":14239866,"avatar_url":"https://avatars.githubusercontent.com/u/14239866?v=3","gravatar_id":"","url":"https://api.github.com/users/Sam1301","html_url":"https://github.com/Sam1301","followers_url":"https://api.github.com/users/Sam1301/followers","following_url":"https://api.github.com/users/Sam1301/following{/other_user}","gists_url":"https://api.github.com/users/Sam1301/gists{/gist_id}","starred_url":"https://api.github.com/users/Sam1301/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sam1301/subscriptions","organizations_url":"https://api.github.com/users/Sam1301/orgs","repos_url":"https://api.github.com/users/Sam1301/repos","events_url":"https://api.github.com/users/Sam1301/events{/privacy}","received_events_url":"https://api.github.com/users/Sam1301/received_events","type":"User","site_admin":false},"body":"This pr addresses #227 \r\nThe server url first entered (when the app is started) was being used everytime, regardless of what the user typed in next. After removing `if(zulipServices != null)` in `getZulipServices()` in `ZulipApp.java`, everytime the user presses enter, a new `zulipServices` object is created and returned.\r\nI have also hidden `/api` from the user and removed any leading/trailing spaces in `serverUrl` entered by the user.","created_at":"2016-11-27T14:48:25Z","updated_at":"2016-11-27T14:48:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zulip/zulip-android/pulls/229/commits","review_comments_url":"https://api.github.com/repos/zulip/zulip-android/pulls/229/comments","review_comment_url":"https://api.github.com/repos/zulip/zulip-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zulip/zulip-android/issues/229/comments","statuses_url":"https://api.github.com/repos/zulip/zulip-android/statuses/11a4bd5945a75fe1efb3dc6f98566d64c110cb13","head":{"label":"Sam1301:bug-fix-backends","ref":"bug-fix-backends","sha":"11a4bd5945a75fe1efb3dc6f98566d64c110cb13","user":{"login":"Sam1301","id":14239866,"avatar_url":"https://avatars.githubusercontent.com/u/14239866?v=3","gravatar_id":"","url":"https://api.github.com/users/Sam1301","html_url":"https://github.com/Sam1301","followers_url":"https://api.github.com/users/Sam1301/followers","following_url":"https://api.github.com/users/Sam1301/following{/other_user}","gists_url":"https://api.github.com/users/Sam1301/gists{/gist_id}","starred_url":"https://api.github.com/users/Sam1301/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sam1301/subscriptions","organizations_url":"https://api.github.com/users/Sam1301/orgs","repos_url":"https://api.github.com/users/Sam1301/repos","events_url":"https://api.github.com/users/Sam1301/events{/privacy}","received_events_url":"https://api.github.com/users/Sam1301/received_events","type":"User","site_admin":false},"repo":{"id":69284370,"name":"zulip-android","full_name":"Sam1301/zulip-android","owner":{"login":"Sam1301","id":14239866,"avatar_url":"https://avatars.githubusercontent.com/u/14239866?v=3","gravatar_id":"","url":"https://api.github.com/users/Sam1301","html_url":"https://github.com/Sam1301","followers_url":"https://api.github.com/users/Sam1301/followers","following_url":"https://api.github.com/users/Sam1301/following{/other_user}","gists_url":"https://api.github.com/users/Sam1301/gists{/gist_id}","starred_url":"https://api.github.com/users/Sam1301/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sam1301/subscriptions","organizations_url":"https://api.github.com/users/Sam1301/orgs","repos_url":"https://api.github.com/users/Sam1301/repos","events_url":"https://api.github.com/users/Sam1301/events{/privacy}","received_events_url":"https://api.github.com/users/Sam1301/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sam1301/zulip-android","description":"Zulip Android app","fork":true,"url":"https://api.github.com/repos/Sam1301/zulip-android","forks_url":"https://api.github.com/repos/Sam1301/zulip-android/forks","keys_url":"https://api.github.com/repos/Sam1301/zulip-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sam1301/zulip-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sam1301/zulip-android/teams","hooks_url":"https://api.github.com/repos/Sam1301/zulip-android/hooks","issue_events_url":"https://api.github.com/repos/Sam1301/zulip-android/issues/events{/number}","events_url":"https://api.github.com/repos/Sam1301/zulip-android/events","assignees_url":"https://api.github.com/repos/Sam1301/zulip-android/assignees{/user}","branches_url":"https://api.github.com/repos/Sam1301/zulip-android/branches{/branch}","tags_url":"https://api.github.com/repos/Sam1301/zulip-android/tags","blobs_url":"https://api.github.com/repos/Sam1301/zulip-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sam1301/zulip-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sam1301/zulip-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sam1301/zulip-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sam1301/zulip-android/statuses/{sha}","languages_url":"https://api.github.com/repos/Sam1301/zulip-android/languages","stargazers_url":"https://api.github.com/repos/Sam1301/zulip-android/stargazers","contributors_url":"https://api.github.com/repos/Sam1301/zulip-android/contributors","subscribers_url":"https://api.github.com/repos/Sam1301/zulip-android/subscribers","subscription_url":"https://api.github.com/repos/Sam1301/zulip-android/subscription","commits_url":"https://api.github.com/repos/Sam1301/zulip-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sam1301/zulip-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sam1301/zulip-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sam1301/zulip-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sam1301/zulip-android/contents/{+path}","compare_url":"https://api.github.com/repos/Sam1301/zulip-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sam1301/zulip-android/merges","archive_url":"https://api.github.com/repos/Sam1301/zulip-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sam1301/zulip-android/downloads","issues_url":"https://api.github.com/repos/Sam1301/zulip-android/issues{/number}","pulls_url":"https://api.github.com/repos/Sam1301/zulip-android/pulls{/number}","milestones_url":"https://api.github.com/repos/Sam1301/zulip-android/milestones{/number}","notifications_url":"https://api.github.com/repos/Sam1301/zulip-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sam1301/zulip-android/labels{/name}","releases_url":"https://api.github.com/repos/Sam1301/zulip-android/releases{/id}","deployments_url":"https://api.github.com/repos/Sam1301/zulip-android/deployments","created_at":"2016-09-26T19:17:41Z","updated_at":"2016-09-26T19:17:42Z","pushed_at":"2016-11-27T14:36:32Z","git_url":"git://github.com/Sam1301/zulip-android.git","ssh_url":"git@github.com:Sam1301/zulip-android.git","clone_url":"https://github.com/Sam1301/zulip-android.git","svn_url":"https://github.com/Sam1301/zulip-android","homepage":null,"size":8459,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zulip:master","ref":"master","sha":"026c4a211835795266881be62e8531ae3d6a2890","user":{"login":"zulip","id":4921959,"avatar_url":"https://avatars.githubusercontent.com/u/4921959?v=3","gravatar_id":"","url":"https://api.github.com/users/zulip","html_url":"https://github.com/zulip","followers_url":"https://api.github.com/users/zulip/followers","following_url":"https://api.github.com/users/zulip/following{/other_user}","gists_url":"https://api.github.com/users/zulip/gists{/gist_id}","starred_url":"https://api.github.com/users/zulip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulip/subscriptions","organizations_url":"https://api.github.com/users/zulip/orgs","repos_url":"https://api.github.com/users/zulip/repos","events_url":"https://api.github.com/users/zulip/events{/privacy}","received_events_url":"https://api.github.com/users/zulip/received_events","type":"Organization","site_admin":false},"repo":{"id":43160849,"name":"zulip-android","full_name":"zulip/zulip-android","owner":{"login":"zulip","id":4921959,"avatar_url":"https://avatars.githubusercontent.com/u/4921959?v=3","gravatar_id":"","url":"https://api.github.com/users/zulip","html_url":"https://github.com/zulip","followers_url":"https://api.github.com/users/zulip/followers","following_url":"https://api.github.com/users/zulip/following{/other_user}","gists_url":"https://api.github.com/users/zulip/gists{/gist_id}","starred_url":"https://api.github.com/users/zulip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulip/subscriptions","organizations_url":"https://api.github.com/users/zulip/orgs","repos_url":"https://api.github.com/users/zulip/repos","events_url":"https://api.github.com/users/zulip/events{/privacy}","received_events_url":"https://api.github.com/users/zulip/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zulip/zulip-android","description":"Zulip Android app","fork":false,"url":"https://api.github.com/repos/zulip/zulip-android","forks_url":"https://api.github.com/repos/zulip/zulip-android/forks","keys_url":"https://api.github.com/repos/zulip/zulip-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zulip/zulip-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zulip/zulip-android/teams","hooks_url":"https://api.github.com/repos/zulip/zulip-android/hooks","issue_events_url":"https://api.github.com/repos/zulip/zulip-android/issues/events{/number}","events_url":"https://api.github.com/repos/zulip/zulip-android/events","assignees_url":"https://api.github.com/repos/zulip/zulip-android/assignees{/user}","branches_url":"https://api.github.com/repos/zulip/zulip-android/branches{/branch}","tags_url":"https://api.github.com/repos/zulip/zulip-android/tags","blobs_url":"https://api.github.com/repos/zulip/zulip-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zulip/zulip-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zulip/zulip-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/zulip/zulip-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zulip/zulip-android/statuses/{sha}","languages_url":"https://api.github.com/repos/zulip/zulip-android/languages","stargazers_url":"https://api.github.com/repos/zulip/zulip-android/stargazers","contributors_url":"https://api.github.com/repos/zulip/zulip-android/contributors","subscribers_url":"https://api.github.com/repos/zulip/zulip-android/subscribers","subscription_url":"https://api.github.com/repos/zulip/zulip-android/subscription","commits_url":"https://api.github.com/repos/zulip/zulip-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/zulip/zulip-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/zulip/zulip-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/zulip/zulip-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/zulip/zulip-android/contents/{+path}","compare_url":"https://api.github.com/repos/zulip/zulip-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zulip/zulip-android/merges","archive_url":"https://api.github.com/repos/zulip/zulip-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zulip/zulip-android/downloads","issues_url":"https://api.github.com/repos/zulip/zulip-android/issues{/number}","pulls_url":"https://api.github.com/repos/zulip/zulip-android/pulls{/number}","milestones_url":"https://api.github.com/repos/zulip/zulip-android/milestones{/number}","notifications_url":"https://api.github.com/repos/zulip/zulip-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zulip/zulip-android/labels{/name}","releases_url":"https://api.github.com/repos/zulip/zulip-android/releases{/id}","deployments_url":"https://api.github.com/repos/zulip/zulip-android/deployments","created_at":"2015-09-25T16:39:37Z","updated_at":"2016-11-17T15:36:06Z","pushed_at":"2016-11-24T15:39:43Z","git_url":"git://github.com/zulip/zulip-android.git","ssh_url":"git@github.com:zulip/zulip-android.git","clone_url":"https://github.com/zulip/zulip-android.git","svn_url":"https://github.com/zulip/zulip-android","homepage":null,"size":21852,"stargazers_count":312,"watchers_count":312,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":162,"mirror_url":null,"open_issues_count":36,"forks":162,"open_issues":36,"watchers":312,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zulip/zulip-android/pulls/229"},"html":{"href":"https://github.com/zulip/zulip-android/pull/229"},"issue":{"href":"https://api.github.com/repos/zulip/zulip-android/issues/229"},"comments":{"href":"https://api.github.com/repos/zulip/zulip-android/issues/229/comments"},"review_comments":{"href":"https://api.github.com/repos/zulip/zulip-android/pulls/229/comments"},"review_comment":{"href":"https://api.github.com/repos/zulip/zulip-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zulip/zulip-android/pulls/229/commits"},"statuses":{"href":"https://api.github.com/repos/zulip/zulip-android/statuses/11a4bd5945a75fe1efb3dc6f98566d64c110cb13"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":11,"deletions":6,"changed_files":2}}
{"actor":{"display_login":"Sam1301"}}