{"action":"created","issue":{"url":"https://api.github.com/repos/Magics-Group/wcjs-renderer/issues/15","repository_url":"https://api.github.com/repos/Magics-Group/wcjs-renderer","labels_url":"https://api.github.com/repos/Magics-Group/wcjs-renderer/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/Magics-Group/wcjs-renderer/issues/15/comments","events_url":"https://api.github.com/repos/Magics-Group/wcjs-renderer/issues/15/events","html_url":"https://github.com/Magics-Group/wcjs-renderer/pull/15","id":154661184,"number":15,"title":"Add callbacks corresponding to the VLC callbacks","user":{"login":"guidupuy","id":1026103,"avatar_url":"https://avatars.githubusercontent.com/u/1026103?v=3","gravatar_id":"","url":"https://api.github.com/users/guidupuy","html_url":"https://github.com/guidupuy","followers_url":"https://api.github.com/users/guidupuy/followers","following_url":"https://api.github.com/users/guidupuy/following{/other_user}","gists_url":"https://api.github.com/users/guidupuy/gists{/gist_id}","starred_url":"https://api.github.com/users/guidupuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guidupuy/subscriptions","organizations_url":"https://api.github.com/users/guidupuy/orgs","repos_url":"https://api.github.com/users/guidupuy/repos","events_url":"https://api.github.com/users/guidupuy/events{/privacy}","received_events_url":"https://api.github.com/users/guidupuy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-05-13T08:40:38Z","updated_at":"2016-05-18T08:42:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Magics-Group/wcjs-renderer/pulls/15","html_url":"https://github.com/Magics-Group/wcjs-renderer/pull/15","diff_url":"https://github.com/Magics-Group/wcjs-renderer/pull/15.diff","patch_url":"https://github.com/Magics-Group/wcjs-renderer/pull/15.patch"},"body":"If I understand correctly, with VLC you can only have 1 callback for the various events (using event listeners would be better, but we don't have this option yet). `wcjs-renderer` consumes some of these callbacks, leaving no option for the developer to subscribe to them. This commit offers the ability to specify custom callbacks and have wcjs-renderer fire them.\r\n\r\nI've also used the opportunity to fix a bug where `gl.drawArrays` was called without ensuring that `gl` was actually defined. Quite critical when WebGL isn't available..."},"comment":{"url":"https://api.github.com/repos/Magics-Group/wcjs-renderer/issues/comments/219963029","html_url":"https://github.com/Magics-Group/wcjs-renderer/pull/15#issuecomment-219963029","issue_url":"https://api.github.com/repos/Magics-Group/wcjs-renderer/issues/15","id":219963029,"user":{"login":"guidupuy","id":1026103,"avatar_url":"https://avatars.githubusercontent.com/u/1026103?v=3","gravatar_id":"","url":"https://api.github.com/users/guidupuy","html_url":"https://github.com/guidupuy","followers_url":"https://api.github.com/users/guidupuy/followers","following_url":"https://api.github.com/users/guidupuy/following{/other_user}","gists_url":"https://api.github.com/users/guidupuy/gists{/gist_id}","starred_url":"https://api.github.com/users/guidupuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guidupuy/subscriptions","organizations_url":"https://api.github.com/users/guidupuy/orgs","repos_url":"https://api.github.com/users/guidupuy/repos","events_url":"https://api.github.com/users/guidupuy/events{/privacy}","received_events_url":"https://api.github.com/users/guidupuy/received_events","type":"User","site_admin":false},"created_at":"2016-05-18T08:42:54Z","updated_at":"2016-05-18T08:42:54Z","body":"@luigiplr not sure I'll have the time for this, unfortunately... But thanks for asking, much appreciated!"}}