{"action":"created","issue":{"url":"https://api.github.com/repos/apache/opennlp/issues/14","repository_url":"https://api.github.com/repos/apache/opennlp","labels_url":"https://api.github.com/repos/apache/opennlp/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/apache/opennlp/issues/14/comments","events_url":"https://api.github.com/repos/apache/opennlp/issues/14/events","html_url":"https://github.com/apache/opennlp/pull/14","id":197033594,"number":14,"title":"Refactor data indexer","user":{"login":"danielruss","id":3767675,"avatar_url":"https://avatars.githubusercontent.com/u/3767675?v=3","gravatar_id":"","url":"https://api.github.com/users/danielruss","html_url":"https://github.com/danielruss","followers_url":"https://api.github.com/users/danielruss/followers","following_url":"https://api.github.com/users/danielruss/following{/other_user}","gists_url":"https://api.github.com/users/danielruss/gists{/gist_id}","starred_url":"https://api.github.com/users/danielruss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielruss/subscriptions","organizations_url":"https://api.github.com/users/danielruss/orgs","repos_url":"https://api.github.com/users/danielruss/repos","events_url":"https://api.github.com/users/danielruss/events{/privacy}","received_events_url":"https://api.github.com/users/danielruss/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-21T21:10:30Z","updated_at":"2016-12-23T16:17:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/opennlp/pulls/14","html_url":"https://github.com/apache/opennlp/pull/14","diff_url":"https://github.com/apache/opennlp/pull/14.diff","patch_url":"https://github.com/apache/opennlp/pull/14.patch"},"body":"Added a patch that changes multiple items (Sorry That I did not fix 1 item at a time-I am a scientist not a software engineer):\r\n\r\n1.) Added method to EventTrainer – train(DataIndexer indexer) –Then I added the method to AbstractEventTrainer. No other code needed to be changed.\r\n2.) Created a new class – PluggableParmeters: Only AbstractTrainers had access to getXXXParam(Value,Default). So I pulled out this functionality into a separate class. Now both AbstractTrainers and AbstractDataIndexers can hold parameters.\r\n3.) Refactored DataIndexer. This touched a lot of code. Added init(Map,Map) method and index(ObjectStream<Event>) method. Changed 1-Pass and 2-Pass DataIndexers. Everywhere 1-pass/2-pass indexers where created, I changed the constructor, and added the init and index methods.\r\n4.) Changed GIS.doTrain(indexer) to use the parameters passed in the init method.\r\n5.) QNTrainer – created a working init method. Changed the isValid method so it is not the init method.\r\n\r\n#4 Make the GIS class work within the new training API\r\n"},"comment":{"url":"https://api.github.com/repos/apache/opennlp/issues/comments/269012651","html_url":"https://github.com/apache/opennlp/pull/14#issuecomment-269012651","issue_url":"https://api.github.com/repos/apache/opennlp/issues/14","id":269012651,"user":{"login":"kottmann","id":1217786,"avatar_url":"https://avatars.githubusercontent.com/u/1217786?v=3","gravatar_id":"","url":"https://api.github.com/users/kottmann","html_url":"https://github.com/kottmann","followers_url":"https://api.github.com/users/kottmann/followers","following_url":"https://api.github.com/users/kottmann/following{/other_user}","gists_url":"https://api.github.com/users/kottmann/gists{/gist_id}","starred_url":"https://api.github.com/users/kottmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kottmann/subscriptions","organizations_url":"https://api.github.com/users/kottmann/orgs","repos_url":"https://api.github.com/users/kottmann/repos","events_url":"https://api.github.com/users/kottmann/events{/privacy}","received_events_url":"https://api.github.com/users/kottmann/received_events","type":"User","site_admin":false},"created_at":"2016-12-23T16:17:54Z","updated_at":"2016-12-23T16:17:54Z","body":"- I get a compilation error in this branch:\r\n[INFO] -------------------------------------------------------------\r\n[ERROR] COMPILATION ERROR : \r\n[INFO] -------------------------------------------------------------\r\n[ERROR] /home/joern/dev/opennlp/opennlp-tools/src/test/java/opennlp/tools/ml/MockEventTrainer.java:[27,8] opennlp.tools.ml.MockEventTrainer is not abstract and does not override abstract method train(opennlp.tools.ml.model.DataIndexer) in opennlp.tools.ml.EventTrainer\r\n[INFO] 1 error\r\n\r\n- There are also still many changes with tab indents instead of two spaces."}}
{"actor":{"display_login":"kottmann"}}