{"action":"closed","number":19142,"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/19142","id":74777866,"html_url":"https://github.com/symfony/symfony/pull/19142","diff_url":"https://github.com/symfony/symfony/pull/19142.diff","patch_url":"https://github.com/symfony/symfony/pull/19142.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/19142","number":19142,"state":"closed","locked":false,"title":"[Security] [Guard] Improve comment with working example","user":{"login":"pasdeloup","id":3264047,"avatar_url":"https://avatars.githubusercontent.com/u/3264047?v=3","gravatar_id":"","url":"https://api.github.com/users/pasdeloup","html_url":"https://github.com/pasdeloup","followers_url":"https://api.github.com/users/pasdeloup/followers","following_url":"https://api.github.com/users/pasdeloup/following{/other_user}","gists_url":"https://api.github.com/users/pasdeloup/gists{/gist_id}","starred_url":"https://api.github.com/users/pasdeloup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pasdeloup/subscriptions","organizations_url":"https://api.github.com/users/pasdeloup/orgs","repos_url":"https://api.github.com/users/pasdeloup/repos","events_url":"https://api.github.com/users/pasdeloup/events{/privacy}","received_events_url":"https://api.github.com/users/pasdeloup/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | 2.8\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | -\r\n| License       | MIT\r\n| Doc PR        | -\r\n\r\nImprove the code given in the comment to make it work.\r\nIf you follow blindly the previous example (as I did) and never return null, you're stucked in an infinite redirection loop on your login page.\r\n\r\n","created_at":"2016-06-22T12:50:01Z","updated_at":"2016-06-23T07:37:39Z","closed_at":"2016-06-23T07:37:39Z","merged_at":null,"merge_commit_sha":"a623e9bab79a6c050ac79fc8c98860f9547431b3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/19142/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/19142/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/19142/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/8129bd3d9fc8b9d17f48a6596984dc5c97f8e7ee","head":{"label":"Sedona-Solutions:fix/guard_comment","ref":"fix/guard_comment","sha":"8129bd3d9fc8b9d17f48a6596984dc5c97f8e7ee","user":{"login":"Sedona-Solutions","id":18006695,"avatar_url":"https://avatars.githubusercontent.com/u/18006695?v=3","gravatar_id":"","url":"https://api.github.com/users/Sedona-Solutions","html_url":"https://github.com/Sedona-Solutions","followers_url":"https://api.github.com/users/Sedona-Solutions/followers","following_url":"https://api.github.com/users/Sedona-Solutions/following{/other_user}","gists_url":"https://api.github.com/users/Sedona-Solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/Sedona-Solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sedona-Solutions/subscriptions","organizations_url":"https://api.github.com/users/Sedona-Solutions/orgs","repos_url":"https://api.github.com/users/Sedona-Solutions/repos","events_url":"https://api.github.com/users/Sedona-Solutions/events{/privacy}","received_events_url":"https://api.github.com/users/Sedona-Solutions/received_events","type":"Organization","site_admin":false},"repo":{"id":60160726,"name":"symfony","full_name":"Sedona-Solutions/symfony","owner":{"login":"Sedona-Solutions","id":18006695,"avatar_url":"https://avatars.githubusercontent.com/u/18006695?v=3","gravatar_id":"","url":"https://api.github.com/users/Sedona-Solutions","html_url":"https://github.com/Sedona-Solutions","followers_url":"https://api.github.com/users/Sedona-Solutions/followers","following_url":"https://api.github.com/users/Sedona-Solutions/following{/other_user}","gists_url":"https://api.github.com/users/Sedona-Solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/Sedona-Solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sedona-Solutions/subscriptions","organizations_url":"https://api.github.com/users/Sedona-Solutions/orgs","repos_url":"https://api.github.com/users/Sedona-Solutions/repos","events_url":"https://api.github.com/users/Sedona-Solutions/events{/privacy}","received_events_url":"https://api.github.com/users/Sedona-Solutions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sedona-Solutions/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/Sedona-Solutions/symfony","forks_url":"https://api.github.com/repos/Sedona-Solutions/symfony/forks","keys_url":"https://api.github.com/repos/Sedona-Solutions/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sedona-Solutions/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sedona-Solutions/symfony/teams","hooks_url":"https://api.github.com/repos/Sedona-Solutions/symfony/hooks","issue_events_url":"https://api.github.com/repos/Sedona-Solutions/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/Sedona-Solutions/symfony/events","assignees_url":"https://api.github.com/repos/Sedona-Solutions/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/Sedona-Solutions/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/Sedona-Solutions/symfony/tags","blobs_url":"https://api.github.com/repos/Sedona-Solutions/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sedona-Solutions/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sedona-Solutions/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sedona-Solutions/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sedona-Solutions/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/Sedona-Solutions/symfony/languages","stargazers_url":"https://api.github.com/repos/Sedona-Solutions/symfony/stargazers","contributors_url":"https://api.github.com/repos/Sedona-Solutions/symfony/contributors","subscribers_url":"https://api.github.com/repos/Sedona-Solutions/symfony/subscribers","subscription_url":"https://api.github.com/repos/Sedona-Solutions/symfony/subscription","commits_url":"https://api.github.com/repos/Sedona-Solutions/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sedona-Solutions/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sedona-Solutions/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sedona-Solutions/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sedona-Solutions/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/Sedona-Solutions/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sedona-Solutions/symfony/merges","archive_url":"https://api.github.com/repos/Sedona-Solutions/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sedona-Solutions/symfony/downloads","issues_url":"https://api.github.com/repos/Sedona-Solutions/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/Sedona-Solutions/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/Sedona-Solutions/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/Sedona-Solutions/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sedona-Solutions/symfony/labels{/name}","releases_url":"https://api.github.com/repos/Sedona-Solutions/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/Sedona-Solutions/symfony/deployments","created_at":"2016-06-01T08:49:30Z","updated_at":"2016-06-01T08:49:48Z","pushed_at":"2016-06-22T13:01:21Z","git_url":"git://github.com/Sedona-Solutions/symfony.git","ssh_url":"git@github.com:Sedona-Solutions/symfony.git","clone_url":"https://github.com/Sedona-Solutions/symfony.git","svn_url":"https://github.com/Sedona-Solutions/symfony","homepage":"symfony.com","size":72264,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:2.8","ref":"2.8","sha":"90151ef5c5502f87fa9bb361419855194ab630a5","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2016-06-22T20:12:17Z","pushed_at":"2016-06-23T07:37:36Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":134073,"stargazers_count":12535,"watchers_count":12535,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4897,"mirror_url":null,"open_issues_count":683,"forks":4897,"open_issues":683,"watchers":12535,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19142"},"html":{"href":"https://github.com/symfony/symfony/pull/19142"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/19142"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/19142/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19142/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19142/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/8129bd3d9fc8b9d17f48a6596984dc5c97f8e7ee"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":1,"review_comments":4,"commits":2,"additions":9,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"fabpot"}}