{"action":"closed","number":7572,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/7572","id":76508604,"html_url":"https://github.com/nodejs/node/pull/7572","diff_url":"https://github.com/nodejs/node/pull/7572.diff","patch_url":"https://github.com/nodejs/node/pull/7572.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/7572","number":7572,"state":"closed","locked":false,"title":"child_process: workaround fd passing issue on OS X","user":{"login":"santigimeno","id":1084056,"avatar_url":"https://avatars.githubusercontent.com/u/1084056?v=3","gravatar_id":"","url":"https://api.github.com/users/santigimeno","html_url":"https://github.com/santigimeno","followers_url":"https://api.github.com/users/santigimeno/followers","following_url":"https://api.github.com/users/santigimeno/following{/other_user}","gists_url":"https://api.github.com/users/santigimeno/gists{/gist_id}","starred_url":"https://api.github.com/users/santigimeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/santigimeno/subscriptions","organizations_url":"https://api.github.com/users/santigimeno/orgs","repos_url":"https://api.github.com/users/santigimeno/repos","events_url":"https://api.github.com/users/santigimeno/events{/privacy}","received_events_url":"https://api.github.com/users/santigimeno/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\nchild_process\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\n\r\nThere's an issue on some `OS X` versions when passing fd's between processes.\r\nWhen the handle associated to a specific file descriptor is closed by the sender\r\nprocess before it's received in the destination, the handle is indeed closed\r\nwhile it should remain opened. As a workaround for `OS X`, don't close the\r\nhandle until the `NODE_HANDLE_ACK` is received by the sender.\r\nAdded `test-child-process-pass-fd` that is basically `test-cluster-net-send` but\r\ncreating lots of workers, so the issue reproduces on `OS X` consistently.\r\n\r\nFixes: https://github.com/nodejs/node/issues/7512\r\n\r\n/cc @bnoordhuis ","created_at":"2016-07-06T21:54:33Z","updated_at":"2016-08-20T10:26:00Z","closed_at":"2016-08-20T10:26:00Z","merged_at":"2016-08-20T10:26:00Z","merge_commit_sha":"db6253f94a7e499b2bacf5998a246c7cd06f7245","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/7572/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/7572/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/7572/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/db6253f94a7e499b2bacf5998a246c7cd06f7245","head":{"label":"santigimeno:pass_fd","ref":"pass_fd","sha":"db6253f94a7e499b2bacf5998a246c7cd06f7245","user":{"login":"santigimeno","id":1084056,"avatar_url":"https://avatars.githubusercontent.com/u/1084056?v=3","gravatar_id":"","url":"https://api.github.com/users/santigimeno","html_url":"https://github.com/santigimeno","followers_url":"https://api.github.com/users/santigimeno/followers","following_url":"https://api.github.com/users/santigimeno/following{/other_user}","gists_url":"https://api.github.com/users/santigimeno/gists{/gist_id}","starred_url":"https://api.github.com/users/santigimeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/santigimeno/subscriptions","organizations_url":"https://api.github.com/users/santigimeno/orgs","repos_url":"https://api.github.com/users/santigimeno/repos","events_url":"https://api.github.com/users/santigimeno/events{/privacy}","received_events_url":"https://api.github.com/users/santigimeno/received_events","type":"User","site_admin":false},"repo":{"id":46618546,"name":"node","full_name":"santigimeno/node","owner":{"login":"santigimeno","id":1084056,"avatar_url":"https://avatars.githubusercontent.com/u/1084056?v=3","gravatar_id":"","url":"https://api.github.com/users/santigimeno","html_url":"https://github.com/santigimeno","followers_url":"https://api.github.com/users/santigimeno/followers","following_url":"https://api.github.com/users/santigimeno/following{/other_user}","gists_url":"https://api.github.com/users/santigimeno/gists{/gist_id}","starred_url":"https://api.github.com/users/santigimeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/santigimeno/subscriptions","organizations_url":"https://api.github.com/users/santigimeno/orgs","repos_url":"https://api.github.com/users/santigimeno/repos","events_url":"https://api.github.com/users/santigimeno/events{/privacy}","received_events_url":"https://api.github.com/users/santigimeno/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/santigimeno/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/santigimeno/node","forks_url":"https://api.github.com/repos/santigimeno/node/forks","keys_url":"https://api.github.com/repos/santigimeno/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/santigimeno/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/santigimeno/node/teams","hooks_url":"https://api.github.com/repos/santigimeno/node/hooks","issue_events_url":"https://api.github.com/repos/santigimeno/node/issues/events{/number}","events_url":"https://api.github.com/repos/santigimeno/node/events","assignees_url":"https://api.github.com/repos/santigimeno/node/assignees{/user}","branches_url":"https://api.github.com/repos/santigimeno/node/branches{/branch}","tags_url":"https://api.github.com/repos/santigimeno/node/tags","blobs_url":"https://api.github.com/repos/santigimeno/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/santigimeno/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/santigimeno/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/santigimeno/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/santigimeno/node/statuses/{sha}","languages_url":"https://api.github.com/repos/santigimeno/node/languages","stargazers_url":"https://api.github.com/repos/santigimeno/node/stargazers","contributors_url":"https://api.github.com/repos/santigimeno/node/contributors","subscribers_url":"https://api.github.com/repos/santigimeno/node/subscribers","subscription_url":"https://api.github.com/repos/santigimeno/node/subscription","commits_url":"https://api.github.com/repos/santigimeno/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/santigimeno/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/santigimeno/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/santigimeno/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/santigimeno/node/contents/{+path}","compare_url":"https://api.github.com/repos/santigimeno/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/santigimeno/node/merges","archive_url":"https://api.github.com/repos/santigimeno/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/santigimeno/node/downloads","issues_url":"https://api.github.com/repos/santigimeno/node/issues{/number}","pulls_url":"https://api.github.com/repos/santigimeno/node/pulls{/number}","milestones_url":"https://api.github.com/repos/santigimeno/node/milestones{/number}","notifications_url":"https://api.github.com/repos/santigimeno/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/santigimeno/node/labels{/name}","releases_url":"https://api.github.com/repos/santigimeno/node/releases{/id}","deployments_url":"https://api.github.com/repos/santigimeno/node/deployments","created_at":"2015-11-21T14:27:00Z","updated_at":"2016-03-09T00:35:06Z","pushed_at":"2016-08-20T08:59:35Z","git_url":"git://github.com/santigimeno/node.git","ssh_url":"git@github.com:santigimeno/node.git","clone_url":"https://github.com/santigimeno/node.git","svn_url":"https://github.com/santigimeno/node","homepage":"https://nodejs.org","size":207684,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"294e3008ad65d92fc6ad9d97f043093054e079ad","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-08-20T09:40:43Z","pushed_at":"2016-08-20T10:25:45Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":291078,"stargazers_count":25903,"watchers_count":25903,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3992,"mirror_url":null,"open_issues_count":750,"forks":3992,"open_issues":750,"watchers":25903,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/7572"},"html":{"href":"https://github.com/nodejs/node/pull/7572"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/7572"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/7572/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/7572/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/7572/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/db6253f94a7e499b2bacf5998a246c7cd06f7245"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"santigimeno","id":1084056,"avatar_url":"https://avatars.githubusercontent.com/u/1084056?v=3","gravatar_id":"","url":"https://api.github.com/users/santigimeno","html_url":"https://github.com/santigimeno","followers_url":"https://api.github.com/users/santigimeno/followers","following_url":"https://api.github.com/users/santigimeno/following{/other_user}","gists_url":"https://api.github.com/users/santigimeno/gists{/gist_id}","starred_url":"https://api.github.com/users/santigimeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/santigimeno/subscriptions","organizations_url":"https://api.github.com/users/santigimeno/orgs","repos_url":"https://api.github.com/users/santigimeno/repos","events_url":"https://api.github.com/users/santigimeno/events{/privacy}","received_events_url":"https://api.github.com/users/santigimeno/received_events","type":"User","site_admin":false},"comments":21,"review_comments":13,"commits":1,"additions":86,"deletions":8,"changed_files":2}}
{"actor":{"display_login":"santigimeno"}}