{"action":"opened","number":1094,"pull_request":{"url":"https://api.github.com/repos/INN/Largo/pulls/1094","id":56958619,"html_url":"https://github.com/INN/Largo/pull/1094","diff_url":"https://github.com/INN/Largo/pull/1094.diff","patch_url":"https://github.com/INN/Largo/pull/1094.patch","issue_url":"https://api.github.com/repos/INN/Largo/issues/1094","number":1094,"state":"open","locked":false,"title":"1090 fix","user":{"login":"benlk","id":1754187,"avatar_url":"https://avatars.githubusercontent.com/u/1754187?v=3","gravatar_id":"","url":"https://api.github.com/users/benlk","html_url":"https://github.com/benlk","followers_url":"https://api.github.com/users/benlk/followers","following_url":"https://api.github.com/users/benlk/following{/other_user}","gists_url":"https://api.github.com/users/benlk/gists{/gist_id}","starred_url":"https://api.github.com/users/benlk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlk/subscriptions","organizations_url":"https://api.github.com/users/benlk/orgs","repos_url":"https://api.github.com/users/benlk/repos","events_url":"https://api.github.com/users/benlk/events{/privacy}","received_events_url":"https://api.github.com/users/benlk/received_events","type":"User","site_admin":false},"body":"## Changes\r\n\r\n- change the `id` for the \"None\" top term option from string `'null'` to string `'none'`, because it might've been undocumented type conversion.\r\n- internal documentation of the function `largo_top_term`\r\n- rework of the logic of `largo_top_term`, closing an edge case where a post with the following characteristics would not have a top term link output:\r\n    - category set\r\n    - no top term explicitly set\r\n    - created in the database instead of through the post editor, because that's the only way that such a combo would exist, likely\r\n\r\n## Why\r\n\r\nBecause the @!@#$%^&* top term wasn't showing up.\r\n\r\nFor [RNS-104](http://jira.inn.org/browse/RNS-104).","created_at":"2016-01-23T00:04:54Z","updated_at":"2016-01-23T00:04:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":{"url":"https://api.github.com/repos/INN/Largo/milestones/14","html_url":"https://github.com/INN/Largo/milestones/0.5.5%20-%20Story%20Elements","labels_url":"https://api.github.com/repos/INN/Largo/milestones/14/labels","id":1232413,"number":14,"title":"0.5.5 - Story Elements","description":"all elements that might appear within the body of an article, any other odds and ends on story pages","creator":{"login":"aschweigert","id":490703,"avatar_url":"https://avatars.githubusercontent.com/u/490703?v=3","gravatar_id":"","url":"https://api.github.com/users/aschweigert","html_url":"https://github.com/aschweigert","followers_url":"https://api.github.com/users/aschweigert/followers","following_url":"https://api.github.com/users/aschweigert/following{/other_user}","gists_url":"https://api.github.com/users/aschweigert/gists{/gist_id}","starred_url":"https://api.github.com/users/aschweigert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschweigert/subscriptions","organizations_url":"https://api.github.com/users/aschweigert/orgs","repos_url":"https://api.github.com/users/aschweigert/repos","events_url":"https://api.github.com/users/aschweigert/events{/privacy}","received_events_url":"https://api.github.com/users/aschweigert/received_events","type":"User","site_admin":false},"open_issues":33,"closed_issues":5,"state":"open","created_at":"2015-07-29T21:25:51Z","updated_at":"2016-01-23T00:04:54Z","due_on":"2016-02-29T05:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/INN/Largo/pulls/1094/commits","review_comments_url":"https://api.github.com/repos/INN/Largo/pulls/1094/comments","review_comment_url":"https://api.github.com/repos/INN/Largo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/INN/Largo/issues/1094/comments","statuses_url":"https://api.github.com/repos/INN/Largo/statuses/910ac8d4ddf63a8a7f187b0e3d476daf7a14d0a5","head":{"label":"INN:1090-fix","ref":"1090-fix","sha":"910ac8d4ddf63a8a7f187b0e3d476daf7a14d0a5","user":{"login":"INN","id":1553533,"avatar_url":"https://avatars.githubusercontent.com/u/1553533?v=3","gravatar_id":"","url":"https://api.github.com/users/INN","html_url":"https://github.com/INN","followers_url":"https://api.github.com/users/INN/followers","following_url":"https://api.github.com/users/INN/following{/other_user}","gists_url":"https://api.github.com/users/INN/gists{/gist_id}","starred_url":"https://api.github.com/users/INN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/INN/subscriptions","organizations_url":"https://api.github.com/users/INN/orgs","repos_url":"https://api.github.com/users/INN/repos","events_url":"https://api.github.com/users/INN/events{/privacy}","received_events_url":"https://api.github.com/users/INN/received_events","type":"Organization","site_admin":false},"repo":{"id":3789101,"name":"Largo","full_name":"INN/Largo","owner":{"login":"INN","id":1553533,"avatar_url":"https://avatars.githubusercontent.com/u/1553533?v=3","gravatar_id":"","url":"https://api.github.com/users/INN","html_url":"https://github.com/INN","followers_url":"https://api.github.com/users/INN/followers","following_url":"https://api.github.com/users/INN/following{/other_user}","gists_url":"https://api.github.com/users/INN/gists{/gist_id}","starred_url":"https://api.github.com/users/INN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/INN/subscriptions","organizations_url":"https://api.github.com/users/INN/orgs","repos_url":"https://api.github.com/users/INN/repos","events_url":"https://api.github.com/users/INN/events{/privacy}","received_events_url":"https://api.github.com/users/INN/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/INN/Largo","description":"A WordPress framework for news websites. Finely crafted and expertly honed by the Institute for Nonprofit News.","fork":true,"url":"https://api.github.com/repos/INN/Largo","forks_url":"https://api.github.com/repos/INN/Largo/forks","keys_url":"https://api.github.com/repos/INN/Largo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/INN/Largo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/INN/Largo/teams","hooks_url":"https://api.github.com/repos/INN/Largo/hooks","issue_events_url":"https://api.github.com/repos/INN/Largo/issues/events{/number}","events_url":"https://api.github.com/repos/INN/Largo/events","assignees_url":"https://api.github.com/repos/INN/Largo/assignees{/user}","branches_url":"https://api.github.com/repos/INN/Largo/branches{/branch}","tags_url":"https://api.github.com/repos/INN/Largo/tags","blobs_url":"https://api.github.com/repos/INN/Largo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/INN/Largo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/INN/Largo/git/refs{/sha}","trees_url":"https://api.github.com/repos/INN/Largo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/INN/Largo/statuses/{sha}","languages_url":"https://api.github.com/repos/INN/Largo/languages","stargazers_url":"https://api.github.com/repos/INN/Largo/stargazers","contributors_url":"https://api.github.com/repos/INN/Largo/contributors","subscribers_url":"https://api.github.com/repos/INN/Largo/subscribers","subscription_url":"https://api.github.com/repos/INN/Largo/subscription","commits_url":"https://api.github.com/repos/INN/Largo/commits{/sha}","git_commits_url":"https://api.github.com/repos/INN/Largo/git/commits{/sha}","comments_url":"https://api.github.com/repos/INN/Largo/comments{/number}","issue_comment_url":"https://api.github.com/repos/INN/Largo/issues/comments{/number}","contents_url":"https://api.github.com/repos/INN/Largo/contents/{+path}","compare_url":"https://api.github.com/repos/INN/Largo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/INN/Largo/merges","archive_url":"https://api.github.com/repos/INN/Largo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/INN/Largo/downloads","issues_url":"https://api.github.com/repos/INN/Largo/issues{/number}","pulls_url":"https://api.github.com/repos/INN/Largo/pulls{/number}","milestones_url":"https://api.github.com/repos/INN/Largo/milestones{/number}","notifications_url":"https://api.github.com/repos/INN/Largo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/INN/Largo/labels{/name}","releases_url":"https://api.github.com/repos/INN/Largo/releases{/id}","deployments_url":"https://api.github.com/repos/INN/Largo/deployments","created_at":"2012-03-21T17:11:36Z","updated_at":"2016-01-21T00:55:03Z","pushed_at":"2016-01-22T23:53:13Z","git_url":"git://github.com/INN/Largo.git","ssh_url":"git@github.com:INN/Largo.git","clone_url":"https://github.com/INN/Largo.git","svn_url":"https://github.com/INN/Largo","homepage":"http://largoproject.org","size":17835,"stargazers_count":88,"watchers_count":88,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":308,"forks":40,"open_issues":308,"watchers":88,"default_branch":"master"}},"base":{"label":"INN:develop","ref":"develop","sha":"5eb72f52bdc584ce9fc26371503354db569a2429","user":{"login":"INN","id":1553533,"avatar_url":"https://avatars.githubusercontent.com/u/1553533?v=3","gravatar_id":"","url":"https://api.github.com/users/INN","html_url":"https://github.com/INN","followers_url":"https://api.github.com/users/INN/followers","following_url":"https://api.github.com/users/INN/following{/other_user}","gists_url":"https://api.github.com/users/INN/gists{/gist_id}","starred_url":"https://api.github.com/users/INN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/INN/subscriptions","organizations_url":"https://api.github.com/users/INN/orgs","repos_url":"https://api.github.com/users/INN/repos","events_url":"https://api.github.com/users/INN/events{/privacy}","received_events_url":"https://api.github.com/users/INN/received_events","type":"Organization","site_admin":false},"repo":{"id":3789101,"name":"Largo","full_name":"INN/Largo","owner":{"login":"INN","id":1553533,"avatar_url":"https://avatars.githubusercontent.com/u/1553533?v=3","gravatar_id":"","url":"https://api.github.com/users/INN","html_url":"https://github.com/INN","followers_url":"https://api.github.com/users/INN/followers","following_url":"https://api.github.com/users/INN/following{/other_user}","gists_url":"https://api.github.com/users/INN/gists{/gist_id}","starred_url":"https://api.github.com/users/INN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/INN/subscriptions","organizations_url":"https://api.github.com/users/INN/orgs","repos_url":"https://api.github.com/users/INN/repos","events_url":"https://api.github.com/users/INN/events{/privacy}","received_events_url":"https://api.github.com/users/INN/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/INN/Largo","description":"A WordPress framework for news websites. Finely crafted and expertly honed by the Institute for Nonprofit News.","fork":true,"url":"https://api.github.com/repos/INN/Largo","forks_url":"https://api.github.com/repos/INN/Largo/forks","keys_url":"https://api.github.com/repos/INN/Largo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/INN/Largo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/INN/Largo/teams","hooks_url":"https://api.github.com/repos/INN/Largo/hooks","issue_events_url":"https://api.github.com/repos/INN/Largo/issues/events{/number}","events_url":"https://api.github.com/repos/INN/Largo/events","assignees_url":"https://api.github.com/repos/INN/Largo/assignees{/user}","branches_url":"https://api.github.com/repos/INN/Largo/branches{/branch}","tags_url":"https://api.github.com/repos/INN/Largo/tags","blobs_url":"https://api.github.com/repos/INN/Largo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/INN/Largo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/INN/Largo/git/refs{/sha}","trees_url":"https://api.github.com/repos/INN/Largo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/INN/Largo/statuses/{sha}","languages_url":"https://api.github.com/repos/INN/Largo/languages","stargazers_url":"https://api.github.com/repos/INN/Largo/stargazers","contributors_url":"https://api.github.com/repos/INN/Largo/contributors","subscribers_url":"https://api.github.com/repos/INN/Largo/subscribers","subscription_url":"https://api.github.com/repos/INN/Largo/subscription","commits_url":"https://api.github.com/repos/INN/Largo/commits{/sha}","git_commits_url":"https://api.github.com/repos/INN/Largo/git/commits{/sha}","comments_url":"https://api.github.com/repos/INN/Largo/comments{/number}","issue_comment_url":"https://api.github.com/repos/INN/Largo/issues/comments{/number}","contents_url":"https://api.github.com/repos/INN/Largo/contents/{+path}","compare_url":"https://api.github.com/repos/INN/Largo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/INN/Largo/merges","archive_url":"https://api.github.com/repos/INN/Largo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/INN/Largo/downloads","issues_url":"https://api.github.com/repos/INN/Largo/issues{/number}","pulls_url":"https://api.github.com/repos/INN/Largo/pulls{/number}","milestones_url":"https://api.github.com/repos/INN/Largo/milestones{/number}","notifications_url":"https://api.github.com/repos/INN/Largo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/INN/Largo/labels{/name}","releases_url":"https://api.github.com/repos/INN/Largo/releases{/id}","deployments_url":"https://api.github.com/repos/INN/Largo/deployments","created_at":"2012-03-21T17:11:36Z","updated_at":"2016-01-21T00:55:03Z","pushed_at":"2016-01-22T23:53:13Z","git_url":"git://github.com/INN/Largo.git","ssh_url":"git@github.com:INN/Largo.git","clone_url":"https://github.com/INN/Largo.git","svn_url":"https://github.com/INN/Largo","homepage":"http://largoproject.org","size":17835,"stargazers_count":88,"watchers_count":88,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":308,"forks":40,"open_issues":308,"watchers":88,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/INN/Largo/pulls/1094"},"html":{"href":"https://github.com/INN/Largo/pull/1094"},"issue":{"href":"https://api.github.com/repos/INN/Largo/issues/1094"},"comments":{"href":"https://api.github.com/repos/INN/Largo/issues/1094/comments"},"review_comments":{"href":"https://api.github.com/repos/INN/Largo/pulls/1094/comments"},"review_comment":{"href":"https://api.github.com/repos/INN/Largo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/INN/Largo/pulls/1094/commits"},"statuses":{"href":"https://api.github.com/repos/INN/Largo/statuses/910ac8d4ddf63a8a7f187b0e3d476daf7a14d0a5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":8,"additions":33,"deletions":8,"changed_files":2}}