{"action":"created","comment":{"url":"https://api.github.com/repos/brave/browser-laptop/pulls/comments/87123425","pull_request_review_id":7747848,"id":87123425,"diff_hunk":"@@ -137,6 +137,12 @@ let generateBraveManifest = () => {\n     cspDirectives['style-src'] = '\\'self\\' \\'unsafe-inline\\' http://' + devServer\n   }\n \n+  // TODO:\n+  // * Move WebTorrent to its own renderer process, similar to the way it's done in\n+  //   WebTorrent Desktop\n+  // * Remove this CSP exception:\n+  cspDirectives['connect-src'] = '*'","path":"app/extensions.js","position":null,"original_position":17,"commit_id":"b460ab70ac85cec94f6c9f2eb993a0ea3f32736a","original_commit_id":"0834c988bea07dc2030945b4e73f6cb53e7557aa","user":{"login":"dcposch","id":169280,"avatar_url":"https://avatars.githubusercontent.com/u/169280?v=3","gravatar_id":"","url":"https://api.github.com/users/dcposch","html_url":"https://github.com/dcposch","followers_url":"https://api.github.com/users/dcposch/followers","following_url":"https://api.github.com/users/dcposch/following{/other_user}","gists_url":"https://api.github.com/users/dcposch/gists{/gist_id}","starred_url":"https://api.github.com/users/dcposch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcposch/subscriptions","organizations_url":"https://api.github.com/users/dcposch/orgs","repos_url":"https://api.github.com/users/dcposch/repos","events_url":"https://api.github.com/users/dcposch/events{/privacy}","received_events_url":"https://api.github.com/users/dcposch/received_events","type":"User","site_admin":false},"body":"done!","created_at":"2016-11-09T02:04:10Z","updated_at":"2016-11-09T02:04:10Z","html_url":"https://github.com/brave/browser-laptop/pull/5342#discussion_r87123425","pull_request_url":"https://api.github.com/repos/brave/browser-laptop/pulls/5342","_links":{"self":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/comments/87123425"},"html":{"href":"https://github.com/brave/browser-laptop/pull/5342#discussion_r87123425"},"pull_request":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/5342"}}},"pull_request":{"url":"https://api.github.com/repos/brave/browser-laptop/pulls/5342","id":91902780,"html_url":"https://github.com/brave/browser-laptop/pull/5342","diff_url":"https://github.com/brave/browser-laptop/pull/5342.diff","patch_url":"https://github.com/brave/browser-laptop/pull/5342.patch","issue_url":"https://api.github.com/repos/brave/browser-laptop/issues/5342","number":5342,"state":"open","locked":false,"title":"[WIP] Add WebTorrent support","user":{"login":"dcposch","id":169280,"avatar_url":"https://avatars.githubusercontent.com/u/169280?v=3","gravatar_id":"","url":"https://api.github.com/users/dcposch","html_url":"https://github.com/dcposch","followers_url":"https://api.github.com/users/dcposch/followers","following_url":"https://api.github.com/users/dcposch/following{/other_user}","gists_url":"https://api.github.com/users/dcposch/gists{/gist_id}","starred_url":"https://api.github.com/users/dcposch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcposch/subscriptions","organizations_url":"https://api.github.com/users/dcposch/orgs","repos_url":"https://api.github.com/users/dcposch/repos","events_url":"https://api.github.com/users/dcposch/events{/privacy}","received_events_url":"https://api.github.com/users/dcposch/received_events","type":"User","site_admin":false},"body":"See #3256 \r\n\r\nThis is still pretty raw. It demonstrates torrent support in Brave.\r\n\r\n### Visit a magnet URL\r\n\r\n![screen shot 2016-11-01 at 8 03 05 pm](https://cloud.githubusercontent.com/assets/169280/19915404/3db5d5c6-a06f-11e6-9484-072e3327e635.png)\r\n\r\n### Bookmark a magnet link\r\n\r\n<img width=\"365\" alt=\"screen shot 2016-11-01 at 8 04 02 pm\" src=\"https://cloud.githubusercontent.com/assets/169280/19915445/8092dbdc-a06f-11e6-9baf-9f27c6944580.png\">\r\n\r\n### Play files in a torrent\r\n\r\n![brave-webtorrent-1](https://cloud.githubusercontent.com/assets/169280/19915515/221a9e04-a070-11e6-9881-02db97656212.gif)\r\n\r\n\r\n### Here are some of the things we still need to do:\r\n- [ ] Design nicer UX\r\n- [ ] Implement nicer UX\r\n- [ ] Add tests\r\n- [ ] Probably move WebTorrent to its own process. Currently it's running in the Brave extension content script, with some of the CSP restrictions disabled.\r\n- [ ] Security review\r\n\r\nFeedback appreciated!\r\n\r\n@BrendanEich @diracdeltas @ayumi @bbondy \r\n","created_at":"2016-11-02T03:17:26Z","updated_at":"2016-11-09T02:04:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab0962da7cffa7c303acb13b33e346e3f7e383e3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/brave/browser-laptop/pulls/5342/commits","review_comments_url":"https://api.github.com/repos/brave/browser-laptop/pulls/5342/comments","review_comment_url":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave/browser-laptop/issues/5342/comments","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/b460ab70ac85cec94f6c9f2eb993a0ea3f32736a","head":{"label":"dcposch:master","ref":"master","sha":"b460ab70ac85cec94f6c9f2eb993a0ea3f32736a","user":{"login":"dcposch","id":169280,"avatar_url":"https://avatars.githubusercontent.com/u/169280?v=3","gravatar_id":"","url":"https://api.github.com/users/dcposch","html_url":"https://github.com/dcposch","followers_url":"https://api.github.com/users/dcposch/followers","following_url":"https://api.github.com/users/dcposch/following{/other_user}","gists_url":"https://api.github.com/users/dcposch/gists{/gist_id}","starred_url":"https://api.github.com/users/dcposch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcposch/subscriptions","organizations_url":"https://api.github.com/users/dcposch/orgs","repos_url":"https://api.github.com/users/dcposch/repos","events_url":"https://api.github.com/users/dcposch/events{/privacy}","received_events_url":"https://api.github.com/users/dcposch/received_events","type":"User","site_admin":false},"repo":{"id":72562261,"name":"browser-laptop","full_name":"dcposch/browser-laptop","owner":{"login":"dcposch","id":169280,"avatar_url":"https://avatars.githubusercontent.com/u/169280?v=3","gravatar_id":"","url":"https://api.github.com/users/dcposch","html_url":"https://github.com/dcposch","followers_url":"https://api.github.com/users/dcposch/followers","following_url":"https://api.github.com/users/dcposch/following{/other_user}","gists_url":"https://api.github.com/users/dcposch/gists{/gist_id}","starred_url":"https://api.github.com/users/dcposch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcposch/subscriptions","organizations_url":"https://api.github.com/users/dcposch/orgs","repos_url":"https://api.github.com/users/dcposch/repos","events_url":"https://api.github.com/users/dcposch/events{/privacy}","received_events_url":"https://api.github.com/users/dcposch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dcposch/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":true,"url":"https://api.github.com/repos/dcposch/browser-laptop","forks_url":"https://api.github.com/repos/dcposch/browser-laptop/forks","keys_url":"https://api.github.com/repos/dcposch/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcposch/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcposch/browser-laptop/teams","hooks_url":"https://api.github.com/repos/dcposch/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/dcposch/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/dcposch/browser-laptop/events","assignees_url":"https://api.github.com/repos/dcposch/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/dcposch/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/dcposch/browser-laptop/tags","blobs_url":"https://api.github.com/repos/dcposch/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcposch/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcposch/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcposch/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcposch/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/dcposch/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/dcposch/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/dcposch/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/dcposch/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/dcposch/browser-laptop/subscription","commits_url":"https://api.github.com/repos/dcposch/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcposch/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcposch/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcposch/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcposch/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/dcposch/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcposch/browser-laptop/merges","archive_url":"https://api.github.com/repos/dcposch/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcposch/browser-laptop/downloads","issues_url":"https://api.github.com/repos/dcposch/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/dcposch/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/dcposch/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/dcposch/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcposch/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/dcposch/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/dcposch/browser-laptop/deployments","created_at":"2016-11-01T18:00:22Z","updated_at":"2016-11-04T02:36:48Z","pushed_at":"2016-11-09T02:03:53Z","git_url":"git://github.com/dcposch/browser-laptop.git","ssh_url":"git@github.com:dcposch/browser-laptop.git","clone_url":"https://github.com/dcposch/browser-laptop.git","svn_url":"https://github.com/dcposch/browser-laptop","homepage":"https://www.brave.com","size":40342,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"brave:master","ref":"master","sha":"c741f9fe520c6c05a5e0299e1e7012ee73d26664","user":{"login":"brave","id":12301619,"avatar_url":"https://avatars.githubusercontent.com/u/12301619?v=3","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":46891997,"name":"browser-laptop","full_name":"brave/browser-laptop","owner":{"login":"brave","id":12301619,"avatar_url":"https://avatars.githubusercontent.com/u/12301619?v=3","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":false,"url":"https://api.github.com/repos/brave/browser-laptop","forks_url":"https://api.github.com/repos/brave/browser-laptop/forks","keys_url":"https://api.github.com/repos/brave/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/browser-laptop/teams","hooks_url":"https://api.github.com/repos/brave/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/brave/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/brave/browser-laptop/events","assignees_url":"https://api.github.com/repos/brave/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/brave/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/brave/browser-laptop/tags","blobs_url":"https://api.github.com/repos/brave/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/brave/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/brave/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/brave/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/brave/browser-laptop/subscription","commits_url":"https://api.github.com/repos/brave/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/brave/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/browser-laptop/merges","archive_url":"https://api.github.com/repos/brave/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/browser-laptop/downloads","issues_url":"https://api.github.com/repos/brave/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/brave/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/brave/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/brave/browser-laptop/deployments","created_at":"2015-11-25T22:55:10Z","updated_at":"2016-11-08T19:06:10Z","pushed_at":"2016-11-09T02:03:53Z","git_url":"git://github.com/brave/browser-laptop.git","ssh_url":"git@github.com:brave/browser-laptop.git","clone_url":"https://github.com/brave/browser-laptop.git","svn_url":"https://github.com/brave/browser-laptop","homepage":"https://www.brave.com","size":43649,"stargazers_count":3750,"watchers_count":3750,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":424,"mirror_url":null,"open_issues_count":1516,"forks":424,"open_issues":1516,"watchers":3750,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/5342"},"html":{"href":"https://github.com/brave/browser-laptop/pull/5342"},"issue":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/5342"},"comments":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/5342/comments"},"review_comments":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/5342/comments"},"review_comment":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/5342/commits"},"statuses":{"href":"https://api.github.com/repos/brave/browser-laptop/statuses/b460ab70ac85cec94f6c9f2eb993a0ea3f32736a"}}}}
{"actor":{"display_login":"dcposch"}}