{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/70811385","id":70811385,"diff_hunk":"@@ -0,0 +1,31 @@\n+/*\n+Copyright 2016 The Kubernetes Authors.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package admission\n+\n+import \"k8s.io/kubernetes/pkg/controller/framework\"\n+\n+// Validator holds Validate functions, which are responsible for validation of initialized shared resources\n+// and should be implemented on admission plugins\n+type Validator interface {\n+\tValidate() error\n+}\n+\n+// WantsNamespaceInformer defines a function which sets NamespaceInformer for admission plugins that need it\n+type WantsNamespaceInformer interface {","path":"pkg/admission/types.go","position":28,"original_position":28,"commit_id":"f6b5e057d0b5c4498928f62f48c876d539c2f7aa","original_commit_id":"f6b5e057d0b5c4498928f62f48c876d539c2f7aa","user":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"body":"You probably want this to be `WantsInformerFactory`.","created_at":"2016-07-14T14:10:20Z","updated_at":"2016-07-14T14:10:20Z","html_url":"https://github.com/kubernetes/kubernetes/pull/26709#discussion_r70811385","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26709","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/70811385"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/26709#discussion_r70811385"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26709"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26709","id":72348717,"html_url":"https://github.com/kubernetes/kubernetes/pull/26709","diff_url":"https://github.com/kubernetes/kubernetes/pull/26709.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/26709.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26709","number":26709,"state":"open","locked":false,"title":"Allow shareable resources for admission control plugins.","user":{"login":"hodovska","id":9335600,"avatar_url":"https://avatars.githubusercontent.com/u/9335600?v=3","gravatar_id":"","url":"https://api.github.com/users/hodovska","html_url":"https://github.com/hodovska","followers_url":"https://api.github.com/users/hodovska/followers","following_url":"https://api.github.com/users/hodovska/following{/other_user}","gists_url":"https://api.github.com/users/hodovska/gists{/gist_id}","starred_url":"https://api.github.com/users/hodovska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hodovska/subscriptions","organizations_url":"https://api.github.com/users/hodovska/orgs","repos_url":"https://api.github.com/users/hodovska/repos","events_url":"https://api.github.com/users/hodovska/events{/privacy}","received_events_url":"https://api.github.com/users/hodovska/received_events","type":"User","site_admin":false},"body":"Changes allow admission control plugins to share resources. This is done via new PluginInitialization structure. The structure can be extended for other resources, for now it is an shared informer for namespace plugins (NamespiceLifecycle, NamespaceAutoProvisioning, NamespaceExists).\r\n\r\nIf a plugins needs some kind of shared resource e.g. client, the client shall be added to PluginInitializer and Wants methods implemented to every plugin which will use it.","created_at":"2016-06-02T13:45:48Z","updated_at":"2016-07-14T14:10:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a903fb0abb27c7aa9b88429bda8a26c35b616ab7","assignee":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"assignees":[{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},{"login":"derekwaynecarr","id":6233452,"avatar_url":"https://avatars.githubusercontent.com/u/6233452?v=3","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26709/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26709/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26709/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/f6b5e057d0b5c4498928f62f48c876d539c2f7aa","head":{"label":"hodovska:master","ref":"master","sha":"f6b5e057d0b5c4498928f62f48c876d539c2f7aa","user":{"login":"hodovska","id":9335600,"avatar_url":"https://avatars.githubusercontent.com/u/9335600?v=3","gravatar_id":"","url":"https://api.github.com/users/hodovska","html_url":"https://github.com/hodovska","followers_url":"https://api.github.com/users/hodovska/followers","following_url":"https://api.github.com/users/hodovska/following{/other_user}","gists_url":"https://api.github.com/users/hodovska/gists{/gist_id}","starred_url":"https://api.github.com/users/hodovska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hodovska/subscriptions","organizations_url":"https://api.github.com/users/hodovska/orgs","repos_url":"https://api.github.com/users/hodovska/repos","events_url":"https://api.github.com/users/hodovska/events{/privacy}","received_events_url":"https://api.github.com/users/hodovska/received_events","type":"User","site_admin":false},"repo":{"id":55980907,"name":"kubernetes","full_name":"hodovska/kubernetes","owner":{"login":"hodovska","id":9335600,"avatar_url":"https://avatars.githubusercontent.com/u/9335600?v=3","gravatar_id":"","url":"https://api.github.com/users/hodovska","html_url":"https://github.com/hodovska","followers_url":"https://api.github.com/users/hodovska/followers","following_url":"https://api.github.com/users/hodovska/following{/other_user}","gists_url":"https://api.github.com/users/hodovska/gists{/gist_id}","starred_url":"https://api.github.com/users/hodovska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hodovska/subscriptions","organizations_url":"https://api.github.com/users/hodovska/orgs","repos_url":"https://api.github.com/users/hodovska/repos","events_url":"https://api.github.com/users/hodovska/events{/privacy}","received_events_url":"https://api.github.com/users/hodovska/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hodovska/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/hodovska/kubernetes","forks_url":"https://api.github.com/repos/hodovska/kubernetes/forks","keys_url":"https://api.github.com/repos/hodovska/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hodovska/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hodovska/kubernetes/teams","hooks_url":"https://api.github.com/repos/hodovska/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/hodovska/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/hodovska/kubernetes/events","assignees_url":"https://api.github.com/repos/hodovska/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/hodovska/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/hodovska/kubernetes/tags","blobs_url":"https://api.github.com/repos/hodovska/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hodovska/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hodovska/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/hodovska/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hodovska/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/hodovska/kubernetes/languages","stargazers_url":"https://api.github.com/repos/hodovska/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/hodovska/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/hodovska/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/hodovska/kubernetes/subscription","commits_url":"https://api.github.com/repos/hodovska/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/hodovska/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/hodovska/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/hodovska/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/hodovska/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/hodovska/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hodovska/kubernetes/merges","archive_url":"https://api.github.com/repos/hodovska/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hodovska/kubernetes/downloads","issues_url":"https://api.github.com/repos/hodovska/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/hodovska/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/hodovska/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/hodovska/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hodovska/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/hodovska/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/hodovska/kubernetes/deployments","created_at":"2016-04-11T14:47:55Z","updated_at":"2016-04-11T14:48:09Z","pushed_at":"2016-07-14T13:20:44Z","git_url":"git://github.com/hodovska/kubernetes.git","ssh_url":"git@github.com:hodovska/kubernetes.git","clone_url":"https://github.com/hodovska/kubernetes.git","svn_url":"https://github.com/hodovska/kubernetes","homepage":"http://kubernetes.io","size":281028,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"339c6924b2d8a8d2a5713d3c9964d7ebe0dcdec1","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-07-14T14:09:10Z","pushed_at":"2016-07-14T13:57:00Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":491008,"stargazers_count":15513,"watchers_count":15513,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4874,"mirror_url":null,"open_issues_count":3928,"forks":4874,"open_issues":3928,"watchers":15513,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26709"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/26709"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/26709"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/26709/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26709/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26709/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/f6b5e057d0b5c4498928f62f48c876d539c2f7aa"}}}}
{"actor":{"display_login":"deads2k"}}