{"action":"created","issue":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/5283","repository_url":"https://api.github.com/repos/ampproject/amphtml","labels_url":"https://api.github.com/repos/ampproject/amphtml/issues/5283/labels{/name}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/5283/comments","events_url":"https://api.github.com/repos/ampproject/amphtml/issues/5283/events","html_url":"https://github.com/ampproject/amphtml/pull/5283","id":179829396,"number":5283,"title":"Amp reddit extension","user":{"login":"samiamorwas","id":2023433,"avatar_url":"https://avatars.githubusercontent.com/u/2023433?v=3","gravatar_id":"","url":"https://api.github.com/users/samiamorwas","html_url":"https://github.com/samiamorwas","followers_url":"https://api.github.com/users/samiamorwas/followers","following_url":"https://api.github.com/users/samiamorwas/following{/other_user}","gists_url":"https://api.github.com/users/samiamorwas/gists{/gist_id}","starred_url":"https://api.github.com/users/samiamorwas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samiamorwas/subscriptions","organizations_url":"https://api.github.com/users/samiamorwas/orgs","repos_url":"https://api.github.com/users/samiamorwas/repos","events_url":"https://api.github.com/users/samiamorwas/events{/privacy}","received_events_url":"https://api.github.com/users/samiamorwas/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ampproject/amphtml/labels/3P","name":"3P","color":"006b75"},{"url":"https://api.github.com/repos/ampproject/amphtml/labels/NEEDS%20REVIEW","name":"NEEDS REVIEW","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"erwinmombay","id":354746,"avatar_url":"https://avatars.githubusercontent.com/u/354746?v=3","gravatar_id":"","url":"https://api.github.com/users/erwinmombay","html_url":"https://github.com/erwinmombay","followers_url":"https://api.github.com/users/erwinmombay/followers","following_url":"https://api.github.com/users/erwinmombay/following{/other_user}","gists_url":"https://api.github.com/users/erwinmombay/gists{/gist_id}","starred_url":"https://api.github.com/users/erwinmombay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwinmombay/subscriptions","organizations_url":"https://api.github.com/users/erwinmombay/orgs","repos_url":"https://api.github.com/users/erwinmombay/repos","events_url":"https://api.github.com/users/erwinmombay/events{/privacy}","received_events_url":"https://api.github.com/users/erwinmombay/received_events","type":"User","site_admin":false},"assignees":[{"login":"erwinmombay","id":354746,"avatar_url":"https://avatars.githubusercontent.com/u/354746?v=3","gravatar_id":"","url":"https://api.github.com/users/erwinmombay","html_url":"https://github.com/erwinmombay","followers_url":"https://api.github.com/users/erwinmombay/followers","following_url":"https://api.github.com/users/erwinmombay/following{/other_user}","gists_url":"https://api.github.com/users/erwinmombay/gists{/gist_id}","starred_url":"https://api.github.com/users/erwinmombay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwinmombay/subscriptions","organizations_url":"https://api.github.com/users/erwinmombay/orgs","repos_url":"https://api.github.com/users/erwinmombay/repos","events_url":"https://api.github.com/users/erwinmombay/events{/privacy}","received_events_url":"https://api.github.com/users/erwinmombay/received_events","type":"User","site_admin":false},{"login":"lannka","id":8496897,"avatar_url":"https://avatars.githubusercontent.com/u/8496897?v=3","gravatar_id":"","url":"https://api.github.com/users/lannka","html_url":"https://github.com/lannka","followers_url":"https://api.github.com/users/lannka/followers","following_url":"https://api.github.com/users/lannka/following{/other_user}","gists_url":"https://api.github.com/users/lannka/gists{/gist_id}","starred_url":"https://api.github.com/users/lannka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lannka/subscriptions","organizations_url":"https://api.github.com/users/lannka/orgs","repos_url":"https://api.github.com/users/lannka/repos","events_url":"https://api.github.com/users/lannka/events{/privacy}","received_events_url":"https://api.github.com/users/lannka/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2016-09-28T17:00:35Z","updated_at":"2016-10-11T17:46:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/5283","html_url":"https://github.com/ampproject/amphtml/pull/5283","diff_url":"https://github.com/ampproject/amphtml/pull/5283.diff","patch_url":"https://github.com/ampproject/amphtml/pull/5283.patch"},"body":"Reddit embeds appear to require iframes bootstrapped with external scripts, but I'm not sure if there are performance concerns with this approach. In the process of getting a corporate CLA taken care of."},"comment":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/comments/252991311","html_url":"https://github.com/ampproject/amphtml/pull/5283#issuecomment-252991311","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/5283","id":252991311,"user":{"login":"cramforce","id":89679,"avatar_url":"https://avatars.githubusercontent.com/u/89679?v=3","gravatar_id":"","url":"https://api.github.com/users/cramforce","html_url":"https://github.com/cramforce","followers_url":"https://api.github.com/users/cramforce/followers","following_url":"https://api.github.com/users/cramforce/following{/other_user}","gists_url":"https://api.github.com/users/cramforce/gists{/gist_id}","starred_url":"https://api.github.com/users/cramforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramforce/subscriptions","organizations_url":"https://api.github.com/users/cramforce/orgs","repos_url":"https://api.github.com/users/cramforce/repos","events_url":"https://api.github.com/users/cramforce/events{/privacy}","received_events_url":"https://api.github.com/users/cramforce/received_events","type":"User","site_admin":false},"created_at":"2016-10-11T17:46:30Z","updated_at":"2016-10-11T17:46:30Z","body":"Yes, there is an \"ads.extern\" which is misnamed, but the right file.\n\nOn Mon, Oct 10, 2016 at 3:41 PM, erwin mombay <notifications@github.com>\nwrote:\n\n> *@erwinmombay* commented on this pull request.\n> ------------------------------\n>\n> In 3p/reddit.js\n> <https://github.com/ampproject/amphtml/pull/5283#pullrequestreview-3586009>\n> :\n>\n> > +  blockquote.setAttribute('data-card-created', Math.floor(Date.now() / 1000));\n> +  return blockquote;\n> +}\n> +\n> +/**\n> + * @param {!Window} global\n> + * @param {!Object} data The element data\n> + * @return {!Element} div\n> + */\n> +function getCommentContainer(global, data) {\n> +  const div = global.document.createElement('div');\n> +  div.classList.add('reddit-embed');\n> +  div.setAttribute('data-embed-media', 'www.redditmedia.com');\n> +  // 'uuid' and 'created' are provided by the embed script, but don't seem\n> +  // to actually be needed. Account for them, but let them default to undefined.\n> +  div.setAttribute('data-embed-uuid', data.uuid);\n>\n> @cramforce <https://github.com/cramforce> should we be declaring these in\n> the extern?\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/ampproject/amphtml/pull/5283#pullrequestreview-3586009>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AAFeT2tnmKk7Wh6t9L_xou6TJZ1xndOCks5qyr79gaJpZM4KJEOu>\n> .\n>\n"}}
{"actor":{"display_login":"cramforce"}}