{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaDiffEq/Sundials.jl/issues/101","repository_url":"https://api.github.com/repos/JuliaDiffEq/Sundials.jl","labels_url":"https://api.github.com/repos/JuliaDiffEq/Sundials.jl/issues/101/labels{/name}","comments_url":"https://api.github.com/repos/JuliaDiffEq/Sundials.jl/issues/101/comments","events_url":"https://api.github.com/repos/JuliaDiffEq/Sundials.jl/issues/101/events","html_url":"https://github.com/JuliaDiffEq/Sundials.jl/pull/101","id":191435965,"number":101,"title":"Add finalizers to mem types","user":{"login":"ChrisRackauckas","id":1814174,"avatar_url":"https://avatars.githubusercontent.com/u/1814174?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisRackauckas","html_url":"https://github.com/ChrisRackauckas","followers_url":"https://api.github.com/users/ChrisRackauckas/followers","following_url":"https://api.github.com/users/ChrisRackauckas/following{/other_user}","gists_url":"https://api.github.com/users/ChrisRackauckas/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisRackauckas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisRackauckas/subscriptions","organizations_url":"https://api.github.com/users/ChrisRackauckas/orgs","repos_url":"https://api.github.com/users/ChrisRackauckas/repos","events_url":"https://api.github.com/users/ChrisRackauckas/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisRackauckas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-24T05:23:19Z","updated_at":"2016-11-24T05:34:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/JuliaDiffEq/Sundials.jl/pulls/101","html_url":"https://github.com/JuliaDiffEq/Sundials.jl/pull/101","diff_url":"https://github.com/JuliaDiffEq/Sundials.jl/pull/101.diff","patch_url":"https://github.com/JuliaDiffEq/Sundials.jl/pull/101.patch"},"body":"Closes #96 and opens up the possibility of #100 by changing to using mem pointer containers such as `CVODEMemContainer` with a finalizer on the type so that way garbage collection handles freeing (instead of the fragile try/finally requirement!). \r\n\r\nConversions such as \r\n\r\n```julia\r\nconvert(::Type{CVODEMemPtr},mem::CVODEMemContainer) = mem.ptr\r\n```\r\n\r\nare used so that way the Clang auto-generated code is pretty much untouched, allowing for future changes like #89 to not be difficult. This does cause an internal API change, for example `CVODEMemContainer(CV_BDF, CV_NEWTON)` instead of `CVodeCreate(CV_BDF, CV_NEWTON)`. The simple and common interfaces were fixed to reflect this (but have no user-facing change), and so were the examples.\r\n\r\n@musm @mauro3"},"comment":{"url":"https://api.github.com/repos/JuliaDiffEq/Sundials.jl/issues/comments/262693981","html_url":"https://github.com/JuliaDiffEq/Sundials.jl/pull/101#issuecomment-262693981","issue_url":"https://api.github.com/repos/JuliaDiffEq/Sundials.jl/issues/101","id":262693981,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-11-24T05:34:37Z","updated_at":"2016-11-24T05:34:37Z","body":"\n[![Coverage Status](https://coveralls.io/builds/8978769/badge)](https://coveralls.io/builds/8978769)\n\nCoverage increased (+0.2%) to 17.641% when pulling **acec68835ab4403b05966cb01559f54ca10d2df7 on finalize** into **c7881996cbddf74e8e22bb290233fda2d5e9b061 on master**.\n"}}
{"actor":{"display_login":"coveralls"}}