{"action":"created","issue":{"url":"https://api.github.com/repos/nknapp/promised-handlebars/issues/13","repository_url":"https://api.github.com/repos/nknapp/promised-handlebars","labels_url":"https://api.github.com/repos/nknapp/promised-handlebars/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/nknapp/promised-handlebars/issues/13/comments","events_url":"https://api.github.com/repos/nknapp/promised-handlebars/issues/13/events","html_url":"https://github.com/nknapp/promised-handlebars/issues/13","id":166513318,"number":13,"title":"Use bluebird instead of Q to get a better performance.","user":{"login":"anson0370","id":283559,"avatar_url":"https://avatars.githubusercontent.com/u/283559?v=3","gravatar_id":"","url":"https://api.github.com/users/anson0370","html_url":"https://github.com/anson0370","followers_url":"https://api.github.com/users/anson0370/followers","following_url":"https://api.github.com/users/anson0370/following{/other_user}","gists_url":"https://api.github.com/users/anson0370/gists{/gist_id}","starred_url":"https://api.github.com/users/anson0370/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anson0370/subscriptions","organizations_url":"https://api.github.com/users/anson0370/orgs","repos_url":"https://api.github.com/users/anson0370/repos","events_url":"https://api.github.com/users/anson0370/events{/privacy}","received_events_url":"https://api.github.com/users/anson0370/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-20T07:20:26Z","updated_at":"2016-07-20T16:18:37Z","closed_at":null,"body":"I have done this on my [fork](https://github.com/TerminusHQ/promised-handlebars/commit/405e243236b7d733f12801b6f19bfc058d75d8e2). And I got a really performance improve.\r\nI'm not sure is there any problem with this change so I didn't make a PR.\r\n\r\nThanks for your work."},"comment":{"url":"https://api.github.com/repos/nknapp/promised-handlebars/issues/comments/234000724","html_url":"https://github.com/nknapp/promised-handlebars/issues/13#issuecomment-234000724","issue_url":"https://api.github.com/repos/nknapp/promised-handlebars/issues/13","id":234000724,"user":{"login":"nknapp","id":636150,"avatar_url":"https://avatars.githubusercontent.com/u/636150?v=3","gravatar_id":"","url":"https://api.github.com/users/nknapp","html_url":"https://github.com/nknapp","followers_url":"https://api.github.com/users/nknapp/followers","following_url":"https://api.github.com/users/nknapp/following{/other_user}","gists_url":"https://api.github.com/users/nknapp/gists{/gist_id}","starred_url":"https://api.github.com/users/nknapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nknapp/subscriptions","organizations_url":"https://api.github.com/users/nknapp/orgs","repos_url":"https://api.github.com/users/nknapp/repos","events_url":"https://api.github.com/users/nknapp/events{/privacy}","received_events_url":"https://api.github.com/users/nknapp/received_events","type":"User","site_admin":false},"created_at":"2016-07-20T16:18:37Z","updated_at":"2016-07-20T16:18:37Z","body":"I've preferred Q at the moment for the smaller library size (i.e. download time). Bluebird seems to carry a lot of stuff that is not needed in node.\r\n\r\nBut, if it a performance improvement, I would consider changing this. \r\nFor compatibilty reasons, I would add an option to the main function where the Promise constructor can be passed in. Apart from the \".all\" function, \".isPromiseAlike\" and \"deep\", no special functions are used, so this might even work with a plain ES6-Promise constructor and without any libraries.\r\n\r\nI would remove the dependency to `q` only with a major version bump. If you want to make a PR for discussion, please go ahead. I should be based on the current master though (there will be another commit shortly, so you may want to wait until the end of the week. I still have a bug to fix).\r\n"}}
{"actor":{"display_login":"nknapp"}}