{"action":"created","issue":{"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/171","repository_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket","labels_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/171/labels{/name}","comments_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/171/comments","events_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/171/events","html_url":"https://github.com/JoinMarket-Org/joinmarket/issues/171","id":98646839,"number":171,"title":"A new protocol","user":{"login":"chris-belcher","id":8398185,"avatar_url":"https://avatars.githubusercontent.com/u/8398185?v=3","gravatar_id":"","url":"https://api.github.com/users/chris-belcher","html_url":"https://github.com/chris-belcher","followers_url":"https://api.github.com/users/chris-belcher/followers","following_url":"https://api.github.com/users/chris-belcher/following{/other_user}","gists_url":"https://api.github.com/users/chris-belcher/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-belcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-belcher/subscriptions","organizations_url":"https://api.github.com/users/chris-belcher/orgs","repos_url":"https://api.github.com/users/chris-belcher/repos","events_url":"https://api.github.com/users/chris-belcher/events{/privacy}","received_events_url":"https://api.github.com/users/chris-belcher/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/labels/enhancement","name":"enhancement","color":"207de5"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2015-08-03T00:01:23Z","updated_at":"2016-07-12T17:56:22Z","closed_at":null,"body":"Issue which combines all the features we want when the protocol is updated.\r\n\r\nTalking to some people, it seems doing a breaking change, a \"hardfork\", is quite an unpopular idea. It would split the liquidity, updating would end up having to be rushed by some people, giving not enough time to check the code. So it seems the compromise solution is to code it that new bots will accept both protocols and the old protocol is gradually phased out.\r\n\r\nStuff to fix:\r\n#88 Fix bug where maker must known the private key of the coinjoin address.\r\n#83 Using p2sh / multisig as inputs.\r\n#45 Some cleanup, changing names, adding a field\r\n#29 Minimum other maker count field\r\nhttps://github.com/chris-belcher/joinmarket/pull/90#issuecomment-108648823 Allowing taker to not authenticate\r\n#120 Fixing miner fees. Changing maker's tx fee contribution to a fee/kB and having a new field of \"lowest fee/kB tx this maker is willing to sign off for\"\r\n\r\nIt should also be noted that the patientsendpayment.py script *does not work at all* in the current protocol, because makers must know the private key of the coinjoin address they're sending to.\r\n\r\n#90 Some code already written\r\nThe branch https://github.com/chris-belcher/joinmarket/tree/newprotocol\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/comments/232126740","html_url":"https://github.com/JoinMarket-Org/joinmarket/issues/171#issuecomment-232126740","issue_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/171","id":232126740,"user":{"login":"AdamISZ","id":4278257,"avatar_url":"https://avatars.githubusercontent.com/u/4278257?v=3","gravatar_id":"","url":"https://api.github.com/users/AdamISZ","html_url":"https://github.com/AdamISZ","followers_url":"https://api.github.com/users/AdamISZ/followers","following_url":"https://api.github.com/users/AdamISZ/following{/other_user}","gists_url":"https://api.github.com/users/AdamISZ/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamISZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamISZ/subscriptions","organizations_url":"https://api.github.com/users/AdamISZ/orgs","repos_url":"https://api.github.com/users/AdamISZ/repos","events_url":"https://api.github.com/users/AdamISZ/events{/privacy}","received_events_url":"https://api.github.com/users/AdamISZ/received_events","type":"User","site_admin":false},"created_at":"2016-07-12T17:56:22Z","updated_at":"2016-07-12T17:56:22Z","body":"As per IRC, 8ecae434c24fdec1eab42d6e8e0b4a59518b365e for standardised bitcoin signature format with prefix.\r\n\r\nWhole build test passes except tx_broadcast. I think I know what that is, but can be addressed later."}}
{"actor":{"display_login":"AdamISZ"}}