{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/MIEngine/pulls/comments/52073208","id":52073208,"diff_hunk":"@@ -8,15 +8,15 @@ namespace MICore\n {\n     internal class NativeMethods\n     {\n-        // TODO: It would be better to route these to the correct .so files directly rather than pasing through system.native. \n+        private const string Libc = \"libc\";","path":"src/MICore/NativeMethods.cs","position":5,"original_position":5,"commit_id":"4ddd08cc9733abfa7859840782c331109e5b5627","original_commit_id":"4ddd08cc9733abfa7859840782c331109e5b5627","user":{"login":"gregg-miskelly","id":11078489,"avatar_url":"https://avatars.githubusercontent.com/u/11078489?v=3","gravatar_id":"","url":"https://api.github.com/users/gregg-miskelly","html_url":"https://github.com/gregg-miskelly","followers_url":"https://api.github.com/users/gregg-miskelly/followers","following_url":"https://api.github.com/users/gregg-miskelly/following{/other_user}","gists_url":"https://api.github.com/users/gregg-miskelly/gists{/gist_id}","starred_url":"https://api.github.com/users/gregg-miskelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregg-miskelly/subscriptions","organizations_url":"https://api.github.com/users/gregg-miskelly/orgs","repos_url":"https://api.github.com/users/gregg-miskelly/repos","events_url":"https://api.github.com/users/gregg-miskelly/events{/privacy}","received_events_url":"https://api.github.com/users/gregg-miskelly/received_events","type":"User","site_admin":false},"body":"Maybe I am missing something, but I don't see an explicit check that we are on Linux. It seems like we may need some additional calls to RuntimeInformation.IsOSPlatform(OSPlatform.Linux).\r\nAlso, it seems like we might want to rename this class to 'UnixNativeMethods' or maybe 'LinuxNativeMethods' if this code doesn't work on OSX either.","created_at":"2016-02-05T21:11:16Z","updated_at":"2016-02-05T21:11:16Z","html_url":"https://github.com/Microsoft/MIEngine/pull/171#discussion_r52073208","pull_request_url":"https://api.github.com/repos/Microsoft/MIEngine/pulls/171","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/MIEngine/pulls/comments/52073208"},"html":{"href":"https://github.com/Microsoft/MIEngine/pull/171#discussion_r52073208"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/MIEngine/pulls/171"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/MIEngine/pulls/171","id":58388316,"html_url":"https://github.com/Microsoft/MIEngine/pull/171","diff_url":"https://github.com/Microsoft/MIEngine/pull/171.diff","patch_url":"https://github.com/Microsoft/MIEngine/pull/171.patch","issue_url":"https://api.github.com/repos/Microsoft/MIEngine/issues/171","number":171,"state":"open","locked":false,"title":"Changing entry points for System.Native calls.","user":{"login":"wiktork","id":15879456,"avatar_url":"https://avatars.githubusercontent.com/u/15879456?v=3","gravatar_id":"","url":"https://api.github.com/users/wiktork","html_url":"https://github.com/wiktork","followers_url":"https://api.github.com/users/wiktork/followers","following_url":"https://api.github.com/users/wiktork/following{/other_user}","gists_url":"https://api.github.com/users/wiktork/gists{/gist_id}","starred_url":"https://api.github.com/users/wiktork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiktork/subscriptions","organizations_url":"https://api.github.com/users/wiktork/orgs","repos_url":"https://api.github.com/users/wiktork/repos","events_url":"https://api.github.com/users/wiktork/events{/privacy}","received_events_url":"https://api.github.com/users/wiktork/received_events","type":"User","site_admin":false},"body":"- Newer version of the CLR uses different names.","created_at":"2016-02-05T04:50:57Z","updated_at":"2016-02-05T21:11:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d63515cb4b4c9037b462b870c3561ced7378a6e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/MIEngine/pulls/171/commits","review_comments_url":"https://api.github.com/repos/Microsoft/MIEngine/pulls/171/comments","review_comment_url":"https://api.github.com/repos/Microsoft/MIEngine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/MIEngine/issues/171/comments","statuses_url":"https://api.github.com/repos/Microsoft/MIEngine/statuses/4ddd08cc9733abfa7859840782c331109e5b5627","head":{"label":"wiktork:master","ref":"master","sha":"4ddd08cc9733abfa7859840782c331109e5b5627","user":{"login":"wiktork","id":15879456,"avatar_url":"https://avatars.githubusercontent.com/u/15879456?v=3","gravatar_id":"","url":"https://api.github.com/users/wiktork","html_url":"https://github.com/wiktork","followers_url":"https://api.github.com/users/wiktork/followers","following_url":"https://api.github.com/users/wiktork/following{/other_user}","gists_url":"https://api.github.com/users/wiktork/gists{/gist_id}","starred_url":"https://api.github.com/users/wiktork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiktork/subscriptions","organizations_url":"https://api.github.com/users/wiktork/orgs","repos_url":"https://api.github.com/users/wiktork/repos","events_url":"https://api.github.com/users/wiktork/events{/privacy}","received_events_url":"https://api.github.com/users/wiktork/received_events","type":"User","site_admin":false},"repo":{"id":51115663,"name":"MIEngine","full_name":"wiktork/MIEngine","owner":{"login":"wiktork","id":15879456,"avatar_url":"https://avatars.githubusercontent.com/u/15879456?v=3","gravatar_id":"","url":"https://api.github.com/users/wiktork","html_url":"https://github.com/wiktork","followers_url":"https://api.github.com/users/wiktork/followers","following_url":"https://api.github.com/users/wiktork/following{/other_user}","gists_url":"https://api.github.com/users/wiktork/gists{/gist_id}","starred_url":"https://api.github.com/users/wiktork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiktork/subscriptions","organizations_url":"https://api.github.com/users/wiktork/orgs","repos_url":"https://api.github.com/users/wiktork/repos","events_url":"https://api.github.com/users/wiktork/events{/privacy}","received_events_url":"https://api.github.com/users/wiktork/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wiktork/MIEngine","description":"The Visual Studio MI Debug Engine (\"MIEngine\") provides an open-source Visual Studio Debugger extension that works with MI-enabled debuggers such as gdb, lldb, and clrdbg. ","fork":true,"url":"https://api.github.com/repos/wiktork/MIEngine","forks_url":"https://api.github.com/repos/wiktork/MIEngine/forks","keys_url":"https://api.github.com/repos/wiktork/MIEngine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wiktork/MIEngine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wiktork/MIEngine/teams","hooks_url":"https://api.github.com/repos/wiktork/MIEngine/hooks","issue_events_url":"https://api.github.com/repos/wiktork/MIEngine/issues/events{/number}","events_url":"https://api.github.com/repos/wiktork/MIEngine/events","assignees_url":"https://api.github.com/repos/wiktork/MIEngine/assignees{/user}","branches_url":"https://api.github.com/repos/wiktork/MIEngine/branches{/branch}","tags_url":"https://api.github.com/repos/wiktork/MIEngine/tags","blobs_url":"https://api.github.com/repos/wiktork/MIEngine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wiktork/MIEngine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wiktork/MIEngine/git/refs{/sha}","trees_url":"https://api.github.com/repos/wiktork/MIEngine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wiktork/MIEngine/statuses/{sha}","languages_url":"https://api.github.com/repos/wiktork/MIEngine/languages","stargazers_url":"https://api.github.com/repos/wiktork/MIEngine/stargazers","contributors_url":"https://api.github.com/repos/wiktork/MIEngine/contributors","subscribers_url":"https://api.github.com/repos/wiktork/MIEngine/subscribers","subscription_url":"https://api.github.com/repos/wiktork/MIEngine/subscription","commits_url":"https://api.github.com/repos/wiktork/MIEngine/commits{/sha}","git_commits_url":"https://api.github.com/repos/wiktork/MIEngine/git/commits{/sha}","comments_url":"https://api.github.com/repos/wiktork/MIEngine/comments{/number}","issue_comment_url":"https://api.github.com/repos/wiktork/MIEngine/issues/comments{/number}","contents_url":"https://api.github.com/repos/wiktork/MIEngine/contents/{+path}","compare_url":"https://api.github.com/repos/wiktork/MIEngine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wiktork/MIEngine/merges","archive_url":"https://api.github.com/repos/wiktork/MIEngine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wiktork/MIEngine/downloads","issues_url":"https://api.github.com/repos/wiktork/MIEngine/issues{/number}","pulls_url":"https://api.github.com/repos/wiktork/MIEngine/pulls{/number}","milestones_url":"https://api.github.com/repos/wiktork/MIEngine/milestones{/number}","notifications_url":"https://api.github.com/repos/wiktork/MIEngine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wiktork/MIEngine/labels{/name}","releases_url":"https://api.github.com/repos/wiktork/MIEngine/releases{/id}","deployments_url":"https://api.github.com/repos/wiktork/MIEngine/deployments","created_at":"2016-02-05T00:24:31Z","updated_at":"2016-02-05T00:24:32Z","pushed_at":"2016-02-05T16:25:41Z","git_url":"git://github.com/wiktork/MIEngine.git","ssh_url":"git@github.com:wiktork/MIEngine.git","clone_url":"https://github.com/wiktork/MIEngine.git","svn_url":"https://github.com/wiktork/MIEngine","homepage":null,"size":2748,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"314b6f65dcb337b6b25a3400fc7b40f94e3a2792","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":36405087,"name":"MIEngine","full_name":"Microsoft/MIEngine","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/MIEngine","description":"The Visual Studio MI Debug Engine (\"MIEngine\") provides an open-source Visual Studio Debugger extension that works with MI-enabled debuggers such as gdb, lldb, and clrdbg. ","fork":false,"url":"https://api.github.com/repos/Microsoft/MIEngine","forks_url":"https://api.github.com/repos/Microsoft/MIEngine/forks","keys_url":"https://api.github.com/repos/Microsoft/MIEngine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/MIEngine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/MIEngine/teams","hooks_url":"https://api.github.com/repos/Microsoft/MIEngine/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/MIEngine/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/MIEngine/events","assignees_url":"https://api.github.com/repos/Microsoft/MIEngine/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/MIEngine/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/MIEngine/tags","blobs_url":"https://api.github.com/repos/Microsoft/MIEngine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/MIEngine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/MIEngine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/MIEngine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/MIEngine/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/MIEngine/languages","stargazers_url":"https://api.github.com/repos/Microsoft/MIEngine/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/MIEngine/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/MIEngine/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/MIEngine/subscription","commits_url":"https://api.github.com/repos/Microsoft/MIEngine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/MIEngine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/MIEngine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/MIEngine/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/MIEngine/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/MIEngine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/MIEngine/merges","archive_url":"https://api.github.com/repos/Microsoft/MIEngine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/MIEngine/downloads","issues_url":"https://api.github.com/repos/Microsoft/MIEngine/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/MIEngine/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/MIEngine/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/MIEngine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/MIEngine/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/MIEngine/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/MIEngine/deployments","created_at":"2015-05-28T00:44:08Z","updated_at":"2016-02-01T03:21:28Z","pushed_at":"2016-02-05T21:05:46Z","git_url":"git://github.com/Microsoft/MIEngine.git","ssh_url":"git@github.com:Microsoft/MIEngine.git","clone_url":"https://github.com/Microsoft/MIEngine.git","svn_url":"https://github.com/Microsoft/MIEngine","homepage":null,"size":3123,"stargazers_count":269,"watchers_count":269,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":26,"forks":66,"open_issues":26,"watchers":269,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/MIEngine/pulls/171"},"html":{"href":"https://github.com/Microsoft/MIEngine/pull/171"},"issue":{"href":"https://api.github.com/repos/Microsoft/MIEngine/issues/171"},"comments":{"href":"https://api.github.com/repos/Microsoft/MIEngine/issues/171/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/MIEngine/pulls/171/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/MIEngine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/MIEngine/pulls/171/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/MIEngine/statuses/4ddd08cc9733abfa7859840782c331109e5b5627"}}}}