{"action":"created","issue":{"url":"https://api.github.com/repos/WycliffeAssociates/8woc/issues/311","repository_url":"https://api.github.com/repos/WycliffeAssociates/8woc","labels_url":"https://api.github.com/repos/WycliffeAssociates/8woc/issues/311/labels{/name}","comments_url":"https://api.github.com/repos/WycliffeAssociates/8woc/issues/311/comments","events_url":"https://api.github.com/repos/WycliffeAssociates/8woc/issues/311/events","html_url":"https://github.com/WycliffeAssociates/8woc/pull/311","id":169139910,"number":311,"title":"Use toast notifications instead of alerts, and fix sidebar bugs.","user":{"login":"ihoegen","id":11003242,"avatar_url":"https://avatars.githubusercontent.com/u/11003242?v=3","gravatar_id":"","url":"https://api.github.com/users/ihoegen","html_url":"https://github.com/ihoegen","followers_url":"https://api.github.com/users/ihoegen/followers","following_url":"https://api.github.com/users/ihoegen/following{/other_user}","gists_url":"https://api.github.com/users/ihoegen/gists{/gist_id}","starred_url":"https://api.github.com/users/ihoegen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihoegen/subscriptions","organizations_url":"https://api.github.com/users/ihoegen/orgs","repos_url":"https://api.github.com/users/ihoegen/repos","events_url":"https://api.github.com/users/ihoegen/events{/privacy}","received_events_url":"https://api.github.com/users/ihoegen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-03T14:06:10Z","updated_at":"2016-08-03T17:36:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/WycliffeAssociates/8woc/pulls/311","html_url":"https://github.com/WycliffeAssociates/8woc/pull/311","diff_url":"https://github.com/WycliffeAssociates/8woc/pull/311.diff","patch_url":"https://github.com/WycliffeAssociates/8woc/pull/311.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/wycliffeassociates/8woc/311)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/WycliffeAssociates/8woc/issues/comments/237309580","html_url":"https://github.com/WycliffeAssociates/8woc/pull/311#issuecomment-237309580","issue_url":"https://api.github.com/repos/WycliffeAssociates/8woc/issues/311","id":237309580,"user":{"login":"mannycolon","id":17072300,"avatar_url":"https://avatars.githubusercontent.com/u/17072300?v=3","gravatar_id":"","url":"https://api.github.com/users/mannycolon","html_url":"https://github.com/mannycolon","followers_url":"https://api.github.com/users/mannycolon/followers","following_url":"https://api.github.com/users/mannycolon/following{/other_user}","gists_url":"https://api.github.com/users/mannycolon/gists{/gist_id}","starred_url":"https://api.github.com/users/mannycolon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mannycolon/subscriptions","organizations_url":"https://api.github.com/users/mannycolon/orgs","repos_url":"https://api.github.com/users/mannycolon/repos","events_url":"https://api.github.com/users/mannycolon/events{/privacy}","received_events_url":"https://api.github.com/users/mannycolon/received_events","type":"User","site_admin":false},"created_at":"2016-08-03T17:36:17Z","updated_at":"2016-08-03T17:36:17Z","body":"\n\n\n\nReviewed 7 of 8 files at r1, 10 of 10 files at r2, 1 of 1 files at r3.\nReview status: all files reviewed at latest revision, 12 unresolved discussions.\n\n---\n\n*[src/js/components/core/BooksOfBible.js, line 2 \\[r2\\]](https://reviewable.io:443/reviews/wycliffeassociates/8woc/311#-KOG7Q4ntUNF73IfL3XR:-KOG7Q4o7u8tWJhi8Ydl:590905030) ([raw file](https://github.com/wycliffeassociates/8woc/blob/d1fc0474c334f1c91fb8942d6f08eb1fab3cde8e/src/js/components/core/BooksOfBible.js#L2)):*\n> ```JavaScript\n>     /**\n>    * @description - This function uses AI to dynammically traspile the bible into byte\n> ```\n\nplease removed the AI word from description\n\n---\n\n*[src/js/components/core/MenuBar.js, line 9 \\[r1\\]](https://reviewable.io:443/reviews/wycliffeassociates/8woc/311#-KOG6tNnfHCu-tp-cMI6:-KOG6tNnfHCu-tp-cMI7:952063525) ([raw file](https://github.com/wycliffeassociates/8woc/blob/b7ea6a09121d0b4b2d2be4faae88becfaf01f632/src/js/components/core/MenuBar.js#L9)):*\n> ```JavaScript\n> const CoreStore = require('../../stores/CoreStore.js');\n> const git = require('./GitApi.js');\n> const toast = require('../../NotificationApi/ToastApi.js');\n> ```\n\ndont require \n\n---\n\n*[src/js/components/core/MenuBar.js, line 35 \\[r1\\]](https://reviewable.io:443/reviews/wycliffeassociates/8woc/311#-KOG6ZAQ0gwUKSeeXoe_:-KOG6ZAQ0gwUKSeeXoea:1589226651) ([raw file](https://github.com/wycliffeassociates/8woc/blob/b7ea6a09121d0b4b2d2be4faae88becfaf01f632/src/js/components/core/MenuBar.js#L35)):*\n> ```JavaScript\n>             git(path).save('Manual Save', path);\n>           } else {\n>               success(title, msg, time)\n> ```\n\nremove success(title, msg, time)\nn\n\n---\n\n*[src/js/components/core/SwitchCheckModal.js, line 23 \\[r1\\]](https://reviewable.io:443/reviews/wycliffeassociates/8woc/311#-KOG7dFAVMdgeScbRVbe:-KOG7dFBJ62UWnEhI8Ag:1280099814) ([raw file](https://github.com/wycliffeassociates/8woc/blob/b7ea6a09121d0b4b2d2be4faae88becfaf01f632/src/js/components/core/SwitchCheckModal.js#L23)):*\n> ```JavaScript\n> const AppDescription = require('./AppDescription');\n> const api = window.ModuleApi;\n> const toast = require('../../NotificationApi/ToastApi.js');\n> ```\n\nyou dont need to require toast, please use it through the api\nexample: api.toast.success();\n\n---\n\n*[src/js/components/core/create_project/ProjectModal.js, line 65 \\[r3\\]](https://reviewable.io:443/reviews/wycliffeassociates/8woc/311#-KOGSSVBnX9mJmH-U143:-KOGSSVBnX9mJmH-U144:-1842722881) ([raw file](https://github.com/wycliffeassociates/8woc/blob/9fde3b729f94842370cda0e51c1e1a5fba4bda04/src/js/components/core/create_project/ProjectModal.js#L65)):*\n> ```JavaScript\n>   },\n>     /**\n>    * @description - This keeps the currentCheckNamespace in tact\n> ```\n\ni believe intact is the right spelling lol, Im praying for you brother\n\n---\n\n*[src/js/components/core/SideBar/GitSync.js, line 9 \\[r3\\]](https://reviewable.io:443/reviews/wycliffeassociates/8woc/311#-KOGSiZ5mSJQP6t1EOIH:-KOGSiZ5mSJQP6t1EOII:907311386) ([raw file](https://github.com/wycliffeassociates/8woc/blob/9fde3b729f94842370cda0e51c1e1a5fba4bda04/src/js/components/core/SideBar/GitSync.js#L9)):*\n> ```JavaScript\n> const user = CoreStore.getLoggedInUser();\n> const gogs = require('../login/GogsApi.js');\n> const toast = require('../../../NotificationApi/ToastApi.js');\n> ```\n\nyou dont need to require toast, use it through the api\n\n---\n\n*[src/js/components/core/SideBar/GitSync.js, line 43 \\[r3\\]](https://reviewable.io:443/reviews/wycliffeassociates/8woc/311#-KOGSz7BNncIDfdGbPrn:-KOGSz7BNncIDfdGbPro:1806376762) ([raw file](https://github.com/wycliffeassociates/8woc/blob/9fde3b729f94842370cda0e51c1e1a5fba4bda04/src/js/components/core/SideBar/GitSync.js#L43)):*\n> ```JavaScript\n>               });\n>             } else {\n>               toast.success('Update succesful', '', 3);\n> ```\n\napi.Toast.success(\" \",\" \",3);\n\n---\n\n*[src/js/components/core/SideBar/GitSync.js, line 69 \\[r3\\]](https://reviewable.io:443/reviews/wycliffeassociates/8woc/311#-KOGTGBHF3AU-k1LtTWL:-KOGTGBHF3AU-k1LtTWM:-149221371) ([raw file](https://github.com/wycliffeassociates/8woc/blob/9fde3b729f94842370cda0e51c1e1a5fba4bda04/src/js/components/core/SideBar/GitSync.js#L69)):*\n> ```JavaScript\n>                         api.updateManifest('repo', remoteLink);\n>                         git(path).update(newRemote, 'master', true, function(){\n>                           toast.success('Update succesful', '', 3);\n> ```\n\nsame here\n\n---\n\n*[src/js/components/core/SideBar/GitSync.js, line 73 \\[r3\\]](https://reviewable.io:443/reviews/wycliffeassociates/8woc/311#-KOGTHk9H_7a5u4bF6jH:-KOGTHk9H_7a5u4bF6jI:-149221371) ([raw file](https://github.com/wycliffeassociates/8woc/blob/9fde3b729f94842370cda0e51c1e1a5fba4bda04/src/js/components/core/SideBar/GitSync.js#L73)):*\n> ```JavaScript\n>                       });\n>                     } else {\n>                       toast.success('Update succesful', '', 3);\n> ```\n\nsame here\n\n---\n\n*[src/js/components/core/SideBar/SideNavBar.js, line 15 \\[r3\\]](https://reviewable.io:443/reviews/wycliffeassociates/8woc/311#-KOGTLPLHhdGMJhN5aV3:-KOGTLPLHhdGMJhN5aV4:-149221371) ([raw file](https://github.com/wycliffeassociates/8woc/blob/9fde3b729f94842370cda0e51c1e1a5fba4bda04/src/js/components/core/SideBar/SideNavBar.js#L15)):*\n> ```JavaScript\n> const gogs = require('../login/GogsApi.js');\n> const sync = require('./GitSync.js');\n> const toast = require('../../../NotificationApi/ToastApi.js');\n> ```\n\nsame here\n\n---\n\n*[src/js/components/core/SideBar/SideNavBar.js, line 26 \\[r3\\]](https://reviewable.io:443/reviews/wycliffeassociates/8woc/311#-KOGTMljDsbcRIHe24pL:-KOGTMljDsbcRIHe24pM:-149221371) ([raw file](https://github.com/wycliffeassociates/8woc/blob/9fde3b729f94842370cda0e51c1e1a5fba4bda04/src/js/components/core/SideBar/SideNavBar.js#L26)):*\n> ```JavaScript\n>       sync();\n>     } else {\n>       toast.info('Open a project first, then try again', '', 3);\n> ```\n\nsame here\n\n---\n\n*[src/js/components/core/SideBar/SideNavBar.js, line 43 \\[r3\\]](https://reviewable.io:443/reviews/wycliffeassociates/8woc/311#-KOGTPGoUw6kypVEUwa9:-KOGTPGoUw6kypVEUwaA:-149221371) ([raw file](https://github.com/wycliffeassociates/8woc/blob/9fde3b729f94842370cda0e51c1e1a5fba4bda04/src/js/components/core/SideBar/SideNavBar.js#L43)):*\n> ```JavaScript\n>       CoreActions.updateCheckModal(true);\n>     } else {\n>       toast.info('Open a project first, then try again', '', 3);\n> ```\n\nsame here\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/wycliffeassociates/8woc/311)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"mannycolon"}}