{"action":"closed","number":1263,"pull_request":{"url":"https://api.github.com/repos/bosun-monitor/bosun/pulls/1263","id":42810222,"html_url":"https://github.com/bosun-monitor/bosun/pull/1263","diff_url":"https://github.com/bosun-monitor/bosun/pull/1263.diff","patch_url":"https://github.com/bosun-monitor/bosun/pull/1263.patch","issue_url":"https://api.github.com/repos/bosun-monitor/bosun/issues/1263","number":1263,"state":"closed","locked":false,"title":"Compile error fixes + negative filter patterns + total_time metric for httpunit collector","user":{"login":"rajder","id":3704611,"avatar_url":"https://avatars.githubusercontent.com/u/3704611?v=3","gravatar_id":"","url":"https://api.github.com/users/rajder","html_url":"https://github.com/rajder","followers_url":"https://api.github.com/users/rajder/followers","following_url":"https://api.github.com/users/rajder/following{/other_user}","gists_url":"https://api.github.com/users/rajder/gists{/gist_id}","starred_url":"https://api.github.com/users/rajder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajder/subscriptions","organizations_url":"https://api.github.com/users/rajder/orgs","repos_url":"https://api.github.com/users/rajder/repos","events_url":"https://api.github.com/users/rajder/events{/privacy}","received_events_url":"https://api.github.com/users/rajder/received_events","type":"User","site_admin":false},"body":"Can now disable collectors using filter patterns prefixed by \"-\", eg. scollector-windows-amd64.exe -p -d -l -f=\"network_windows,-tcp\" on my dev. machine prints:\r\nbosun.org/cmd/scollector/collectors.c_network_windows\r\n\r\n(excluding c_network_windows_tcp)\r\n\r\n\r\nI needed this specifically for disabling c_network_windows_tcp while keeping c_network_windows enabled, trying to find performance issues caused by one of the two collectors, or both. High CPU usage by WmiPrvSE.exe and blocked collectors seems to be the symptoms (have not solved the issue or confirmed the offending collector yet)\r\nEdit: It was not one of the network collectors. Could be some WMI related issue. It seems like the issue mostly occurs when the machines are under heavy load.\r\n","created_at":"2015-08-19T12:51:03Z","updated_at":"2016-03-02T00:09:07Z","closed_at":"2016-03-02T00:09:07Z","merged_at":null,"merge_commit_sha":"89aa89b79961daf6c42f791be47b1a8254c30761","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bosun-monitor/bosun/pulls/1263/commits","review_comments_url":"https://api.github.com/repos/bosun-monitor/bosun/pulls/1263/comments","review_comment_url":"https://api.github.com/repos/bosun-monitor/bosun/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bosun-monitor/bosun/issues/1263/comments","statuses_url":"https://api.github.com/repos/bosun-monitor/bosun/statuses/11d4cfa9c586fc141e532c4077c25e5f78d5b712","head":{"label":"rajder:master","ref":"master","sha":"11d4cfa9c586fc141e532c4077c25e5f78d5b712","user":{"login":"rajder","id":3704611,"avatar_url":"https://avatars.githubusercontent.com/u/3704611?v=3","gravatar_id":"","url":"https://api.github.com/users/rajder","html_url":"https://github.com/rajder","followers_url":"https://api.github.com/users/rajder/followers","following_url":"https://api.github.com/users/rajder/following{/other_user}","gists_url":"https://api.github.com/users/rajder/gists{/gist_id}","starred_url":"https://api.github.com/users/rajder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajder/subscriptions","organizations_url":"https://api.github.com/users/rajder/orgs","repos_url":"https://api.github.com/users/rajder/repos","events_url":"https://api.github.com/users/rajder/events{/privacy}","received_events_url":"https://api.github.com/users/rajder/received_events","type":"User","site_admin":false},"repo":{"id":41032559,"name":"bosun","full_name":"rajder/bosun","owner":{"login":"rajder","id":3704611,"avatar_url":"https://avatars.githubusercontent.com/u/3704611?v=3","gravatar_id":"","url":"https://api.github.com/users/rajder","html_url":"https://github.com/rajder","followers_url":"https://api.github.com/users/rajder/followers","following_url":"https://api.github.com/users/rajder/following{/other_user}","gists_url":"https://api.github.com/users/rajder/gists{/gist_id}","starred_url":"https://api.github.com/users/rajder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajder/subscriptions","organizations_url":"https://api.github.com/users/rajder/orgs","repos_url":"https://api.github.com/users/rajder/repos","events_url":"https://api.github.com/users/rajder/events{/privacy}","received_events_url":"https://api.github.com/users/rajder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rajder/bosun","description":"Time Series Alerting Framework","fork":true,"url":"https://api.github.com/repos/rajder/bosun","forks_url":"https://api.github.com/repos/rajder/bosun/forks","keys_url":"https://api.github.com/repos/rajder/bosun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rajder/bosun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rajder/bosun/teams","hooks_url":"https://api.github.com/repos/rajder/bosun/hooks","issue_events_url":"https://api.github.com/repos/rajder/bosun/issues/events{/number}","events_url":"https://api.github.com/repos/rajder/bosun/events","assignees_url":"https://api.github.com/repos/rajder/bosun/assignees{/user}","branches_url":"https://api.github.com/repos/rajder/bosun/branches{/branch}","tags_url":"https://api.github.com/repos/rajder/bosun/tags","blobs_url":"https://api.github.com/repos/rajder/bosun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rajder/bosun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rajder/bosun/git/refs{/sha}","trees_url":"https://api.github.com/repos/rajder/bosun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rajder/bosun/statuses/{sha}","languages_url":"https://api.github.com/repos/rajder/bosun/languages","stargazers_url":"https://api.github.com/repos/rajder/bosun/stargazers","contributors_url":"https://api.github.com/repos/rajder/bosun/contributors","subscribers_url":"https://api.github.com/repos/rajder/bosun/subscribers","subscription_url":"https://api.github.com/repos/rajder/bosun/subscription","commits_url":"https://api.github.com/repos/rajder/bosun/commits{/sha}","git_commits_url":"https://api.github.com/repos/rajder/bosun/git/commits{/sha}","comments_url":"https://api.github.com/repos/rajder/bosun/comments{/number}","issue_comment_url":"https://api.github.com/repos/rajder/bosun/issues/comments{/number}","contents_url":"https://api.github.com/repos/rajder/bosun/contents/{+path}","compare_url":"https://api.github.com/repos/rajder/bosun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rajder/bosun/merges","archive_url":"https://api.github.com/repos/rajder/bosun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rajder/bosun/downloads","issues_url":"https://api.github.com/repos/rajder/bosun/issues{/number}","pulls_url":"https://api.github.com/repos/rajder/bosun/pulls{/number}","milestones_url":"https://api.github.com/repos/rajder/bosun/milestones{/number}","notifications_url":"https://api.github.com/repos/rajder/bosun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rajder/bosun/labels{/name}","releases_url":"https://api.github.com/repos/rajder/bosun/releases{/id}","deployments_url":"https://api.github.com/repos/rajder/bosun/deployments","created_at":"2015-08-19T12:29:38Z","updated_at":"2015-08-19T12:29:39Z","pushed_at":"2015-11-09T13:20:48Z","git_url":"git://github.com/rajder/bosun.git","ssh_url":"git@github.com:rajder/bosun.git","clone_url":"https://github.com/rajder/bosun.git","svn_url":"https://github.com/rajder/bosun","homepage":"http://bosun.org","size":31615,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bosun-monitor:master","ref":"master","sha":"74c3f732138e0815974ef86213df01e3405018bd","user":{"login":"bosun-monitor","id":9555242,"avatar_url":"https://avatars.githubusercontent.com/u/9555242?v=3","gravatar_id":"","url":"https://api.github.com/users/bosun-monitor","html_url":"https://github.com/bosun-monitor","followers_url":"https://api.github.com/users/bosun-monitor/followers","following_url":"https://api.github.com/users/bosun-monitor/following{/other_user}","gists_url":"https://api.github.com/users/bosun-monitor/gists{/gist_id}","starred_url":"https://api.github.com/users/bosun-monitor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bosun-monitor/subscriptions","organizations_url":"https://api.github.com/users/bosun-monitor/orgs","repos_url":"https://api.github.com/users/bosun-monitor/repos","events_url":"https://api.github.com/users/bosun-monitor/events{/privacy}","received_events_url":"https://api.github.com/users/bosun-monitor/received_events","type":"Organization","site_admin":false},"repo":{"id":14410778,"name":"bosun","full_name":"bosun-monitor/bosun","owner":{"login":"bosun-monitor","id":9555242,"avatar_url":"https://avatars.githubusercontent.com/u/9555242?v=3","gravatar_id":"","url":"https://api.github.com/users/bosun-monitor","html_url":"https://github.com/bosun-monitor","followers_url":"https://api.github.com/users/bosun-monitor/followers","following_url":"https://api.github.com/users/bosun-monitor/following{/other_user}","gists_url":"https://api.github.com/users/bosun-monitor/gists{/gist_id}","starred_url":"https://api.github.com/users/bosun-monitor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bosun-monitor/subscriptions","organizations_url":"https://api.github.com/users/bosun-monitor/orgs","repos_url":"https://api.github.com/users/bosun-monitor/repos","events_url":"https://api.github.com/users/bosun-monitor/events{/privacy}","received_events_url":"https://api.github.com/users/bosun-monitor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bosun-monitor/bosun","description":"Time Series Alerting Framework","fork":false,"url":"https://api.github.com/repos/bosun-monitor/bosun","forks_url":"https://api.github.com/repos/bosun-monitor/bosun/forks","keys_url":"https://api.github.com/repos/bosun-monitor/bosun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bosun-monitor/bosun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bosun-monitor/bosun/teams","hooks_url":"https://api.github.com/repos/bosun-monitor/bosun/hooks","issue_events_url":"https://api.github.com/repos/bosun-monitor/bosun/issues/events{/number}","events_url":"https://api.github.com/repos/bosun-monitor/bosun/events","assignees_url":"https://api.github.com/repos/bosun-monitor/bosun/assignees{/user}","branches_url":"https://api.github.com/repos/bosun-monitor/bosun/branches{/branch}","tags_url":"https://api.github.com/repos/bosun-monitor/bosun/tags","blobs_url":"https://api.github.com/repos/bosun-monitor/bosun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bosun-monitor/bosun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bosun-monitor/bosun/git/refs{/sha}","trees_url":"https://api.github.com/repos/bosun-monitor/bosun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bosun-monitor/bosun/statuses/{sha}","languages_url":"https://api.github.com/repos/bosun-monitor/bosun/languages","stargazers_url":"https://api.github.com/repos/bosun-monitor/bosun/stargazers","contributors_url":"https://api.github.com/repos/bosun-monitor/bosun/contributors","subscribers_url":"https://api.github.com/repos/bosun-monitor/bosun/subscribers","subscription_url":"https://api.github.com/repos/bosun-monitor/bosun/subscription","commits_url":"https://api.github.com/repos/bosun-monitor/bosun/commits{/sha}","git_commits_url":"https://api.github.com/repos/bosun-monitor/bosun/git/commits{/sha}","comments_url":"https://api.github.com/repos/bosun-monitor/bosun/comments{/number}","issue_comment_url":"https://api.github.com/repos/bosun-monitor/bosun/issues/comments{/number}","contents_url":"https://api.github.com/repos/bosun-monitor/bosun/contents/{+path}","compare_url":"https://api.github.com/repos/bosun-monitor/bosun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bosun-monitor/bosun/merges","archive_url":"https://api.github.com/repos/bosun-monitor/bosun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bosun-monitor/bosun/downloads","issues_url":"https://api.github.com/repos/bosun-monitor/bosun/issues{/number}","pulls_url":"https://api.github.com/repos/bosun-monitor/bosun/pulls{/number}","milestones_url":"https://api.github.com/repos/bosun-monitor/bosun/milestones{/number}","notifications_url":"https://api.github.com/repos/bosun-monitor/bosun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bosun-monitor/bosun/labels{/name}","releases_url":"https://api.github.com/repos/bosun-monitor/bosun/releases{/id}","deployments_url":"https://api.github.com/repos/bosun-monitor/bosun/deployments","created_at":"2013-11-15T00:12:27Z","updated_at":"2016-03-01T03:25:32Z","pushed_at":"2016-03-02T00:09:05Z","git_url":"git://github.com/bosun-monitor/bosun.git","ssh_url":"git@github.com:bosun-monitor/bosun.git","clone_url":"https://github.com/bosun-monitor/bosun.git","svn_url":"https://github.com/bosun-monitor/bosun","homepage":"http://bosun.org","size":53411,"stargazers_count":1663,"watchers_count":1663,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":219,"mirror_url":null,"open_issues_count":242,"forks":219,"open_issues":242,"watchers":1663,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bosun-monitor/bosun/pulls/1263"},"html":{"href":"https://github.com/bosun-monitor/bosun/pull/1263"},"issue":{"href":"https://api.github.com/repos/bosun-monitor/bosun/issues/1263"},"comments":{"href":"https://api.github.com/repos/bosun-monitor/bosun/issues/1263/comments"},"review_comments":{"href":"https://api.github.com/repos/bosun-monitor/bosun/pulls/1263/comments"},"review_comment":{"href":"https://api.github.com/repos/bosun-monitor/bosun/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bosun-monitor/bosun/pulls/1263/commits"},"statuses":{"href":"https://api.github.com/repos/bosun-monitor/bosun/statuses/11d4cfa9c586fc141e532c4077c25e5f78d5b712"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":7,"review_comments":7,"commits":1,"additions":58,"deletions":28,"changed_files":5}}