{"action":"created","comment":{"url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/pulls/comments/68589330","id":68589330,"diff_hunk":"@@ -88,39 +85,34 @@ def getMonitored(self, datasource):\n         return rtn\n \n     def monitored(self):\n-        \"\"\"Return True if this service should be monitored. False otherwise.\"\"\"\n+        return self.is_monitored()\n \n+    def is_monitored(self):","path":"ZenPacks/zenoss/Microsoft/Windows/WinService.py","position":53,"original_position":53,"commit_id":"98b278cdad97a578dc9f4f2f58ee487f1c663fbf","original_commit_id":"98b278cdad97a578dc9f4f2f58ee487f1c663fbf","user":{"login":"dbouchillon","id":8355179,"avatar_url":"https://avatars.githubusercontent.com/u/8355179?v=3","gravatar_id":"","url":"https://api.github.com/users/dbouchillon","html_url":"https://github.com/dbouchillon","followers_url":"https://api.github.com/users/dbouchillon/followers","following_url":"https://api.github.com/users/dbouchillon/following{/other_user}","gists_url":"https://api.github.com/users/dbouchillon/gists{/gist_id}","starred_url":"https://api.github.com/users/dbouchillon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbouchillon/subscriptions","organizations_url":"https://api.github.com/users/dbouchillon/orgs","repos_url":"https://api.github.com/users/dbouchillon/repos","events_url":"https://api.github.com/users/dbouchillon/events{/privacy}","received_events_url":"https://api.github.com/users/dbouchillon/received_events","type":"User","site_admin":false},"body":"move the guts of is_monitored() into monitored() and remove the is_monitored() function","created_at":"2016-06-27T14:47:00Z","updated_at":"2016-06-27T14:47:00Z","html_url":"https://github.com/zenoss/ZenPacks.zenoss.Microsoft.Windows/pull/600#discussion_r68589330","pull_request_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/pulls/600","_links":{"self":{"href":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/pulls/comments/68589330"},"html":{"href":"https://github.com/zenoss/ZenPacks.zenoss.Microsoft.Windows/pull/600#discussion_r68589330"},"pull_request":{"href":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/pulls/600"}}},"pull_request":{"url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/pulls/600","id":75145921,"html_url":"https://github.com/zenoss/ZenPacks.zenoss.Microsoft.Windows/pull/600","diff_url":"https://github.com/zenoss/ZenPacks.zenoss.Microsoft.Windows/pull/600.diff","patch_url":"https://github.com/zenoss/ZenPacks.zenoss.Microsoft.Windows/pull/600.patch","issue_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/issues/600","number":600,"state":"open","locked":false,"title":"clean up WinService/ServiceDatasource ","user":{"login":"j053ph4","id":1128457,"avatar_url":"https://avatars.githubusercontent.com/u/1128457?v=3","gravatar_id":"","url":"https://api.github.com/users/j053ph4","html_url":"https://github.com/j053ph4","followers_url":"https://api.github.com/users/j053ph4/followers","following_url":"https://api.github.com/users/j053ph4/following{/other_user}","gists_url":"https://api.github.com/users/j053ph4/gists{/gist_id}","starred_url":"https://api.github.com/users/j053ph4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j053ph4/subscriptions","organizations_url":"https://api.github.com/users/j053ph4/orgs","repos_url":"https://api.github.com/users/j053ph4/repos","events_url":"https://api.github.com/users/j053ph4/events{/privacy}","received_events_url":"https://api.github.com/users/j053ph4/received_events","type":"User","site_admin":false},"body":"Better accommodate both templates and service classes","created_at":"2016-06-24T17:22:20Z","updated_at":"2016-06-27T14:47:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fde33128f0be41098091285c88ad312f5db0967e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/pulls/600/commits","review_comments_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/pulls/600/comments","review_comment_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/issues/600/comments","statuses_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/statuses/98b278cdad97a578dc9f4f2f58ee487f1c663fbf","head":{"label":"zenoss:feature/minor-service-fixes","ref":"feature/minor-service-fixes","sha":"98b278cdad97a578dc9f4f2f58ee487f1c663fbf","user":{"login":"zenoss","id":243767,"avatar_url":"https://avatars.githubusercontent.com/u/243767?v=3","gravatar_id":"","url":"https://api.github.com/users/zenoss","html_url":"https://github.com/zenoss","followers_url":"https://api.github.com/users/zenoss/followers","following_url":"https://api.github.com/users/zenoss/following{/other_user}","gists_url":"https://api.github.com/users/zenoss/gists{/gist_id}","starred_url":"https://api.github.com/users/zenoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenoss/subscriptions","organizations_url":"https://api.github.com/users/zenoss/orgs","repos_url":"https://api.github.com/users/zenoss/repos","events_url":"https://api.github.com/users/zenoss/events{/privacy}","received_events_url":"https://api.github.com/users/zenoss/received_events","type":"Organization","site_admin":false},"repo":{"id":9173686,"name":"ZenPacks.zenoss.Microsoft.Windows","full_name":"zenoss/ZenPacks.zenoss.Microsoft.Windows","owner":{"login":"zenoss","id":243767,"avatar_url":"https://avatars.githubusercontent.com/u/243767?v=3","gravatar_id":"","url":"https://api.github.com/users/zenoss","html_url":"https://github.com/zenoss","followers_url":"https://api.github.com/users/zenoss/followers","following_url":"https://api.github.com/users/zenoss/following{/other_user}","gists_url":"https://api.github.com/users/zenoss/gists{/gist_id}","starred_url":"https://api.github.com/users/zenoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenoss/subscriptions","organizations_url":"https://api.github.com/users/zenoss/orgs","repos_url":"https://api.github.com/users/zenoss/repos","events_url":"https://api.github.com/users/zenoss/events{/privacy}","received_events_url":"https://api.github.com/users/zenoss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zenoss/ZenPacks.zenoss.Microsoft.Windows","description":"Microsoft Windows ZenPack","fork":false,"url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows","forks_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/forks","keys_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/teams","hooks_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/hooks","issue_events_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/issues/events{/number}","events_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/events","assignees_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/assignees{/user}","branches_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/branches{/branch}","tags_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/tags","blobs_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/statuses/{sha}","languages_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/languages","stargazers_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/stargazers","contributors_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/contributors","subscribers_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/subscribers","subscription_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/subscription","commits_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/contents/{+path}","compare_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/merges","archive_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/downloads","issues_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/issues{/number}","pulls_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/pulls{/number}","milestones_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/milestones{/number}","notifications_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/labels{/name}","releases_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/releases{/id}","deployments_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/deployments","created_at":"2013-04-02T15:42:21Z","updated_at":"2016-06-09T14:25:02Z","pushed_at":"2016-06-27T13:31:31Z","git_url":"git://github.com/zenoss/ZenPacks.zenoss.Microsoft.Windows.git","ssh_url":"git@github.com:zenoss/ZenPacks.zenoss.Microsoft.Windows.git","clone_url":"https://github.com/zenoss/ZenPacks.zenoss.Microsoft.Windows.git","svn_url":"https://github.com/zenoss/ZenPacks.zenoss.Microsoft.Windows","homepage":null,"size":12901,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":24,"forks":14,"open_issues":24,"watchers":10,"default_branch":"develop"}},"base":{"label":"zenoss:develop","ref":"develop","sha":"fb33348c079432167e30b2b320f41fff483e0ee2","user":{"login":"zenoss","id":243767,"avatar_url":"https://avatars.githubusercontent.com/u/243767?v=3","gravatar_id":"","url":"https://api.github.com/users/zenoss","html_url":"https://github.com/zenoss","followers_url":"https://api.github.com/users/zenoss/followers","following_url":"https://api.github.com/users/zenoss/following{/other_user}","gists_url":"https://api.github.com/users/zenoss/gists{/gist_id}","starred_url":"https://api.github.com/users/zenoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenoss/subscriptions","organizations_url":"https://api.github.com/users/zenoss/orgs","repos_url":"https://api.github.com/users/zenoss/repos","events_url":"https://api.github.com/users/zenoss/events{/privacy}","received_events_url":"https://api.github.com/users/zenoss/received_events","type":"Organization","site_admin":false},"repo":{"id":9173686,"name":"ZenPacks.zenoss.Microsoft.Windows","full_name":"zenoss/ZenPacks.zenoss.Microsoft.Windows","owner":{"login":"zenoss","id":243767,"avatar_url":"https://avatars.githubusercontent.com/u/243767?v=3","gravatar_id":"","url":"https://api.github.com/users/zenoss","html_url":"https://github.com/zenoss","followers_url":"https://api.github.com/users/zenoss/followers","following_url":"https://api.github.com/users/zenoss/following{/other_user}","gists_url":"https://api.github.com/users/zenoss/gists{/gist_id}","starred_url":"https://api.github.com/users/zenoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenoss/subscriptions","organizations_url":"https://api.github.com/users/zenoss/orgs","repos_url":"https://api.github.com/users/zenoss/repos","events_url":"https://api.github.com/users/zenoss/events{/privacy}","received_events_url":"https://api.github.com/users/zenoss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zenoss/ZenPacks.zenoss.Microsoft.Windows","description":"Microsoft Windows ZenPack","fork":false,"url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows","forks_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/forks","keys_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/teams","hooks_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/hooks","issue_events_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/issues/events{/number}","events_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/events","assignees_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/assignees{/user}","branches_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/branches{/branch}","tags_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/tags","blobs_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/statuses/{sha}","languages_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/languages","stargazers_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/stargazers","contributors_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/contributors","subscribers_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/subscribers","subscription_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/subscription","commits_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/contents/{+path}","compare_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/merges","archive_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/downloads","issues_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/issues{/number}","pulls_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/pulls{/number}","milestones_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/milestones{/number}","notifications_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/labels{/name}","releases_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/releases{/id}","deployments_url":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/deployments","created_at":"2013-04-02T15:42:21Z","updated_at":"2016-06-09T14:25:02Z","pushed_at":"2016-06-27T13:31:31Z","git_url":"git://github.com/zenoss/ZenPacks.zenoss.Microsoft.Windows.git","ssh_url":"git@github.com:zenoss/ZenPacks.zenoss.Microsoft.Windows.git","clone_url":"https://github.com/zenoss/ZenPacks.zenoss.Microsoft.Windows.git","svn_url":"https://github.com/zenoss/ZenPacks.zenoss.Microsoft.Windows","homepage":null,"size":12901,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":24,"forks":14,"open_issues":24,"watchers":10,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/pulls/600"},"html":{"href":"https://github.com/zenoss/ZenPacks.zenoss.Microsoft.Windows/pull/600"},"issue":{"href":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/issues/600"},"comments":{"href":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/issues/600/comments"},"review_comments":{"href":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/pulls/600/comments"},"review_comment":{"href":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/pulls/600/commits"},"statuses":{"href":"https://api.github.com/repos/zenoss/ZenPacks.zenoss.Microsoft.Windows/statuses/98b278cdad97a578dc9f4f2f58ee487f1c663fbf"}}}}
{"actor":{"display_login":"dbouchillon"}}