{"action":"created","comment":{"url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/comments/90571526","pull_request_review_id":11091163,"id":90571526,"diff_hunk":"@@ -0,0 +1,101 @@\n+# -*- coding: utf-8 -*-\n+#\n+# Copyright (c) 2015 Red Hat\n+# Licensed under The MIT License (MIT)\n+# http://opensource.org/licenses/MIT\n+#\n+\n+from __future__ import print_function\n+\n+import json\n+\n+from pdc_client.plugin_helpers import (PDCClientPlugin,\n+                                       extract_arguments,\n+                                       add_parser_arguments,\n+                                       add_create_update_args)\n+\n+\n+class AuthGroupResourcePermissionPlugin(PDCClientPlugin):\n+    def register(self):\n+        self.set_command('auth/group-resource-permissions')\n+        list_parser = self.add_action('list', help='list all groups and their resource permission')\n+        add_parser_arguments(list_parser, {'resource': {},\n+                                           'permission': {},\n+                                           'group': {}},\n+                             group='Filtering')\n+        list_parser.set_defaults(func=self.list_group_resource_permission)\n+\n+        info_parser = self.add_action('info', help='display details about a group resource permission')\n+        info_parser.add_argument('id', metavar='ID')\n+        info_parser.set_defaults(func=self.group_resource_permission_info)\n+\n+        update_parser = self.add_action('update', help='update an existing group resource permission')\n+        update_parser.add_argument('id', metavar='ID')\n+        self.add_create_update_argument(update_parser, required=True)\n+        update_parser.set_defaults(func=self.group_resource_permission_update)\n+\n+        create_parser = self.add_action('create', help='create new group resource permission')","path":"pdc_client/plugins/auth_group_resource_permissions.py","position":37,"original_position":37,"commit_id":"cbedc58e8c46c714764e8164b4301e9b01b8f937","original_commit_id":"cbedc58e8c46c714764e8164b4301e9b01b8f937","user":{"login":"ycheng-aa","id":7261866,"avatar_url":"https://avatars.githubusercontent.com/u/7261866?v=3","gravatar_id":"","url":"https://api.github.com/users/ycheng-aa","html_url":"https://github.com/ycheng-aa","followers_url":"https://api.github.com/users/ycheng-aa/followers","following_url":"https://api.github.com/users/ycheng-aa/following{/other_user}","gists_url":"https://api.github.com/users/ycheng-aa/gists{/gist_id}","starred_url":"https://api.github.com/users/ycheng-aa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ycheng-aa/subscriptions","organizations_url":"https://api.github.com/users/ycheng-aa/orgs","repos_url":"https://api.github.com/users/ycheng-aa/repos","events_url":"https://api.github.com/users/ycheng-aa/events{/privacy}","received_events_url":"https://api.github.com/users/ycheng-aa/received_events","type":"User","site_admin":false},"body":"For user, is it better to let help text to be something like `grant a resource permission to a group`. `create` is what dev implemented. We don't have describe it from developer's point of view to our customer. \r\n\r\nSame as update, but I am not sure in update how to make it clear and friendly.","created_at":"2016-12-02T01:16:00Z","updated_at":"2016-12-02T01:18:02Z","html_url":"https://github.com/product-definition-center/pdc-client/pull/79#discussion_r90571526","pull_request_url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/79","_links":{"self":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/comments/90571526"},"html":{"href":"https://github.com/product-definition-center/pdc-client/pull/79#discussion_r90571526"},"pull_request":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/79"}}},"pull_request":{"url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/79","id":96200536,"html_url":"https://github.com/product-definition-center/pdc-client/pull/79","diff_url":"https://github.com/product-definition-center/pdc-client/pull/79.diff","patch_url":"https://github.com/product-definition-center/pdc-client/pull/79.patch","issue_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues/79","number":79,"state":"open","locked":false,"title":"Add a new plugin of auth/group-resource-permission","user":{"login":"bliuredhat","id":13480348,"avatar_url":"https://avatars.githubusercontent.com/u/13480348?v=3","gravatar_id":"","url":"https://api.github.com/users/bliuredhat","html_url":"https://github.com/bliuredhat","followers_url":"https://api.github.com/users/bliuredhat/followers","following_url":"https://api.github.com/users/bliuredhat/following{/other_user}","gists_url":"https://api.github.com/users/bliuredhat/gists{/gist_id}","starred_url":"https://api.github.com/users/bliuredhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bliuredhat/subscriptions","organizations_url":"https://api.github.com/users/bliuredhat/orgs","repos_url":"https://api.github.com/users/bliuredhat/repos","events_url":"https://api.github.com/users/bliuredhat/events{/privacy}","received_events_url":"https://api.github.com/users/bliuredhat/received_events","type":"User","site_admin":false},"body":"JIRA: PDC-1755","created_at":"2016-12-02T00:40:43Z","updated_at":"2016-12-02T01:39:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"536e248188390b4d22f6d2ea128cc7f5fc7d13bf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/79/commits","review_comments_url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/79/comments","review_comment_url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues/79/comments","statuses_url":"https://api.github.com/repos/product-definition-center/pdc-client/statuses/cbedc58e8c46c714764e8164b4301e9b01b8f937","head":{"label":"product-definition-center:PDC-1755_add_auth/group-resource-permission","ref":"PDC-1755_add_auth/group-resource-permission","sha":"cbedc58e8c46c714764e8164b4301e9b01b8f937","user":{"login":"product-definition-center","id":15812210,"avatar_url":"https://avatars.githubusercontent.com/u/15812210?v=3","gravatar_id":"","url":"https://api.github.com/users/product-definition-center","html_url":"https://github.com/product-definition-center","followers_url":"https://api.github.com/users/product-definition-center/followers","following_url":"https://api.github.com/users/product-definition-center/following{/other_user}","gists_url":"https://api.github.com/users/product-definition-center/gists{/gist_id}","starred_url":"https://api.github.com/users/product-definition-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/product-definition-center/subscriptions","organizations_url":"https://api.github.com/users/product-definition-center/orgs","repos_url":"https://api.github.com/users/product-definition-center/repos","events_url":"https://api.github.com/users/product-definition-center/events{/privacy}","received_events_url":"https://api.github.com/users/product-definition-center/received_events","type":"Organization","site_admin":false},"repo":{"id":46246883,"name":"pdc-client","full_name":"product-definition-center/pdc-client","owner":{"login":"product-definition-center","id":15812210,"avatar_url":"https://avatars.githubusercontent.com/u/15812210?v=3","gravatar_id":"","url":"https://api.github.com/users/product-definition-center","html_url":"https://github.com/product-definition-center","followers_url":"https://api.github.com/users/product-definition-center/followers","following_url":"https://api.github.com/users/product-definition-center/following{/other_user}","gists_url":"https://api.github.com/users/product-definition-center/gists{/gist_id}","starred_url":"https://api.github.com/users/product-definition-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/product-definition-center/subscriptions","organizations_url":"https://api.github.com/users/product-definition-center/orgs","repos_url":"https://api.github.com/users/product-definition-center/repos","events_url":"https://api.github.com/users/product-definition-center/events{/privacy}","received_events_url":"https://api.github.com/users/product-definition-center/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/product-definition-center/pdc-client","description":"Client for Product Definition Center (PDC) in Python","fork":false,"url":"https://api.github.com/repos/product-definition-center/pdc-client","forks_url":"https://api.github.com/repos/product-definition-center/pdc-client/forks","keys_url":"https://api.github.com/repos/product-definition-center/pdc-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/product-definition-center/pdc-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/product-definition-center/pdc-client/teams","hooks_url":"https://api.github.com/repos/product-definition-center/pdc-client/hooks","issue_events_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues/events{/number}","events_url":"https://api.github.com/repos/product-definition-center/pdc-client/events","assignees_url":"https://api.github.com/repos/product-definition-center/pdc-client/assignees{/user}","branches_url":"https://api.github.com/repos/product-definition-center/pdc-client/branches{/branch}","tags_url":"https://api.github.com/repos/product-definition-center/pdc-client/tags","blobs_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/product-definition-center/pdc-client/statuses/{sha}","languages_url":"https://api.github.com/repos/product-definition-center/pdc-client/languages","stargazers_url":"https://api.github.com/repos/product-definition-center/pdc-client/stargazers","contributors_url":"https://api.github.com/repos/product-definition-center/pdc-client/contributors","subscribers_url":"https://api.github.com/repos/product-definition-center/pdc-client/subscribers","subscription_url":"https://api.github.com/repos/product-definition-center/pdc-client/subscription","commits_url":"https://api.github.com/repos/product-definition-center/pdc-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/product-definition-center/pdc-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/product-definition-center/pdc-client/contents/{+path}","compare_url":"https://api.github.com/repos/product-definition-center/pdc-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/product-definition-center/pdc-client/merges","archive_url":"https://api.github.com/repos/product-definition-center/pdc-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/product-definition-center/pdc-client/downloads","issues_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues{/number}","pulls_url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls{/number}","milestones_url":"https://api.github.com/repos/product-definition-center/pdc-client/milestones{/number}","notifications_url":"https://api.github.com/repos/product-definition-center/pdc-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/product-definition-center/pdc-client/labels{/name}","releases_url":"https://api.github.com/repos/product-definition-center/pdc-client/releases{/id}","deployments_url":"https://api.github.com/repos/product-definition-center/pdc-client/deployments","created_at":"2015-11-16T02:23:01Z","updated_at":"2016-10-31T05:47:10Z","pushed_at":"2016-12-02T00:40:43Z","git_url":"git://github.com/product-definition-center/pdc-client.git","ssh_url":"git@github.com:product-definition-center/pdc-client.git","clone_url":"https://github.com/product-definition-center/pdc-client.git","svn_url":"https://github.com/product-definition-center/pdc-client","homepage":"","size":542,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":1,"forks":9,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"product-definition-center:master","ref":"master","sha":"6ff334931b7abf5b6816ec50f379f8fe422e1916","user":{"login":"product-definition-center","id":15812210,"avatar_url":"https://avatars.githubusercontent.com/u/15812210?v=3","gravatar_id":"","url":"https://api.github.com/users/product-definition-center","html_url":"https://github.com/product-definition-center","followers_url":"https://api.github.com/users/product-definition-center/followers","following_url":"https://api.github.com/users/product-definition-center/following{/other_user}","gists_url":"https://api.github.com/users/product-definition-center/gists{/gist_id}","starred_url":"https://api.github.com/users/product-definition-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/product-definition-center/subscriptions","organizations_url":"https://api.github.com/users/product-definition-center/orgs","repos_url":"https://api.github.com/users/product-definition-center/repos","events_url":"https://api.github.com/users/product-definition-center/events{/privacy}","received_events_url":"https://api.github.com/users/product-definition-center/received_events","type":"Organization","site_admin":false},"repo":{"id":46246883,"name":"pdc-client","full_name":"product-definition-center/pdc-client","owner":{"login":"product-definition-center","id":15812210,"avatar_url":"https://avatars.githubusercontent.com/u/15812210?v=3","gravatar_id":"","url":"https://api.github.com/users/product-definition-center","html_url":"https://github.com/product-definition-center","followers_url":"https://api.github.com/users/product-definition-center/followers","following_url":"https://api.github.com/users/product-definition-center/following{/other_user}","gists_url":"https://api.github.com/users/product-definition-center/gists{/gist_id}","starred_url":"https://api.github.com/users/product-definition-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/product-definition-center/subscriptions","organizations_url":"https://api.github.com/users/product-definition-center/orgs","repos_url":"https://api.github.com/users/product-definition-center/repos","events_url":"https://api.github.com/users/product-definition-center/events{/privacy}","received_events_url":"https://api.github.com/users/product-definition-center/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/product-definition-center/pdc-client","description":"Client for Product Definition Center (PDC) in Python","fork":false,"url":"https://api.github.com/repos/product-definition-center/pdc-client","forks_url":"https://api.github.com/repos/product-definition-center/pdc-client/forks","keys_url":"https://api.github.com/repos/product-definition-center/pdc-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/product-definition-center/pdc-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/product-definition-center/pdc-client/teams","hooks_url":"https://api.github.com/repos/product-definition-center/pdc-client/hooks","issue_events_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues/events{/number}","events_url":"https://api.github.com/repos/product-definition-center/pdc-client/events","assignees_url":"https://api.github.com/repos/product-definition-center/pdc-client/assignees{/user}","branches_url":"https://api.github.com/repos/product-definition-center/pdc-client/branches{/branch}","tags_url":"https://api.github.com/repos/product-definition-center/pdc-client/tags","blobs_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/product-definition-center/pdc-client/statuses/{sha}","languages_url":"https://api.github.com/repos/product-definition-center/pdc-client/languages","stargazers_url":"https://api.github.com/repos/product-definition-center/pdc-client/stargazers","contributors_url":"https://api.github.com/repos/product-definition-center/pdc-client/contributors","subscribers_url":"https://api.github.com/repos/product-definition-center/pdc-client/subscribers","subscription_url":"https://api.github.com/repos/product-definition-center/pdc-client/subscription","commits_url":"https://api.github.com/repos/product-definition-center/pdc-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/product-definition-center/pdc-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/product-definition-center/pdc-client/contents/{+path}","compare_url":"https://api.github.com/repos/product-definition-center/pdc-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/product-definition-center/pdc-client/merges","archive_url":"https://api.github.com/repos/product-definition-center/pdc-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/product-definition-center/pdc-client/downloads","issues_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues{/number}","pulls_url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls{/number}","milestones_url":"https://api.github.com/repos/product-definition-center/pdc-client/milestones{/number}","notifications_url":"https://api.github.com/repos/product-definition-center/pdc-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/product-definition-center/pdc-client/labels{/name}","releases_url":"https://api.github.com/repos/product-definition-center/pdc-client/releases{/id}","deployments_url":"https://api.github.com/repos/product-definition-center/pdc-client/deployments","created_at":"2015-11-16T02:23:01Z","updated_at":"2016-10-31T05:47:10Z","pushed_at":"2016-12-02T00:40:43Z","git_url":"git://github.com/product-definition-center/pdc-client.git","ssh_url":"git@github.com:product-definition-center/pdc-client.git","clone_url":"https://github.com/product-definition-center/pdc-client.git","svn_url":"https://github.com/product-definition-center/pdc-client","homepage":"","size":542,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":1,"forks":9,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/79"},"html":{"href":"https://github.com/product-definition-center/pdc-client/pull/79"},"issue":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/issues/79"},"comments":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/issues/79/comments"},"review_comments":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/79/comments"},"review_comment":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/79/commits"},"statuses":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/statuses/cbedc58e8c46c714764e8164b4301e9b01b8f937"}}}}
{"actor":{"display_login":"ycheng-aa"}}