{"action":"created","comment":{"url":"https://api.github.com/repos/collectd/collectd/pulls/comments/65814481","id":65814481,"diff_hunk":"@@ -867,9 +867,13 @@ static int disk_read (void)\n \t\toutput_name = disk_name;\n \n #if HAVE_LIBUDEV\n-\t\tchar *alt_name = disk_udev_attr_name (handle_udev, disk_name, conf_udev_name_attr);\n-\t\tif (alt_name != NULL)\n-\t\t\toutput_name = alt_name;\n+\t\tchar *alt_name = NULL;\n+\t\tif (conf_udev_name_attr != NULL)\n+\t\t{\n+\t\t\talt_name = disk_udev_attr_name (handle_udev, disk_name, conf_udev_name_attr);\n+\t\t\tif (alt_name != NULL)\n+\t\t\t\toutput_name = alt_name;","path":"src/disk.c","position":59,"original_position":12,"commit_id":"baec98579514cae9888f15af623dc59c0e89e434","original_commit_id":"bdbc066e4646876a774e940995859a4760b8946c","user":{"login":"rubenk","id":47338,"avatar_url":"https://avatars.githubusercontent.com/u/47338?v=3","gravatar_id":"","url":"https://api.github.com/users/rubenk","html_url":"https://github.com/rubenk","followers_url":"https://api.github.com/users/rubenk/followers","following_url":"https://api.github.com/users/rubenk/following{/other_user}","gists_url":"https://api.github.com/users/rubenk/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenk/subscriptions","organizations_url":"https://api.github.com/users/rubenk/orgs","repos_url":"https://api.github.com/users/rubenk/repos","events_url":"https://api.github.com/users/rubenk/events{/privacy}","received_events_url":"https://api.github.com/users/rubenk/received_events","type":"User","site_admin":false},"body":"Thank Coverity ;) I should have caught it during review, sorry.","created_at":"2016-06-05T09:39:52Z","updated_at":"2016-06-05T09:39:52Z","html_url":"https://github.com/collectd/collectd/pull/1723#discussion_r65814481","pull_request_url":"https://api.github.com/repos/collectd/collectd/pulls/1723","_links":{"self":{"href":"https://api.github.com/repos/collectd/collectd/pulls/comments/65814481"},"html":{"href":"https://github.com/collectd/collectd/pull/1723#discussion_r65814481"},"pull_request":{"href":"https://api.github.com/repos/collectd/collectd/pulls/1723"}}},"pull_request":{"url":"https://api.github.com/repos/collectd/collectd/pulls/1723","id":71345444,"html_url":"https://github.com/collectd/collectd/pull/1723","diff_url":"https://github.com/collectd/collectd/pull/1723.diff","patch_url":"https://github.com/collectd/collectd/pull/1723.patch","issue_url":"https://api.github.com/repos/collectd/collectd/issues/1723","number":1723,"state":"closed","locked":false,"title":"Disk plugin: UdevNameAttr feature improvements","user":{"login":"rpv-tomsk","id":13328211,"avatar_url":"https://avatars.githubusercontent.com/u/13328211?v=3","gravatar_id":"","url":"https://api.github.com/users/rpv-tomsk","html_url":"https://github.com/rpv-tomsk","followers_url":"https://api.github.com/users/rpv-tomsk/followers","following_url":"https://api.github.com/users/rpv-tomsk/following{/other_user}","gists_url":"https://api.github.com/users/rpv-tomsk/gists{/gist_id}","starred_url":"https://api.github.com/users/rpv-tomsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpv-tomsk/subscriptions","organizations_url":"https://api.github.com/users/rpv-tomsk/orgs","repos_url":"https://api.github.com/users/rpv-tomsk/repos","events_url":"https://api.github.com/users/rpv-tomsk/events{/privacy}","received_events_url":"https://api.github.com/users/rpv-tomsk/received_events","type":"User","site_admin":false},"body":"disk plugin: Initialize udev context only once, not per each read\r\ndisk plugin: Call disk_udev_attr_name() only when UdevNameAttr configured","created_at":"2016-05-25T07:57:02Z","updated_at":"2016-06-05T09:39:52Z","closed_at":"2016-05-25T11:57:11Z","merged_at":"2016-05-25T11:57:11Z","merge_commit_sha":"a9463994041a275662c555d883521d0c8c23e812","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/collectd/collectd/pulls/1723/commits","review_comments_url":"https://api.github.com/repos/collectd/collectd/pulls/1723/comments","review_comment_url":"https://api.github.com/repos/collectd/collectd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/collectd/collectd/issues/1723/comments","statuses_url":"https://api.github.com/repos/collectd/collectd/statuses/baec98579514cae9888f15af623dc59c0e89e434","head":{"label":"rpv-tomsk:disk-plugin","ref":"disk-plugin","sha":"baec98579514cae9888f15af623dc59c0e89e434","user":{"login":"rpv-tomsk","id":13328211,"avatar_url":"https://avatars.githubusercontent.com/u/13328211?v=3","gravatar_id":"","url":"https://api.github.com/users/rpv-tomsk","html_url":"https://github.com/rpv-tomsk","followers_url":"https://api.github.com/users/rpv-tomsk/followers","following_url":"https://api.github.com/users/rpv-tomsk/following{/other_user}","gists_url":"https://api.github.com/users/rpv-tomsk/gists{/gist_id}","starred_url":"https://api.github.com/users/rpv-tomsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpv-tomsk/subscriptions","organizations_url":"https://api.github.com/users/rpv-tomsk/orgs","repos_url":"https://api.github.com/users/rpv-tomsk/repos","events_url":"https://api.github.com/users/rpv-tomsk/events{/privacy}","received_events_url":"https://api.github.com/users/rpv-tomsk/received_events","type":"User","site_admin":false},"repo":{"id":52437705,"name":"collectd","full_name":"rpv-tomsk/collectd","owner":{"login":"rpv-tomsk","id":13328211,"avatar_url":"https://avatars.githubusercontent.com/u/13328211?v=3","gravatar_id":"","url":"https://api.github.com/users/rpv-tomsk","html_url":"https://github.com/rpv-tomsk","followers_url":"https://api.github.com/users/rpv-tomsk/followers","following_url":"https://api.github.com/users/rpv-tomsk/following{/other_user}","gists_url":"https://api.github.com/users/rpv-tomsk/gists{/gist_id}","starred_url":"https://api.github.com/users/rpv-tomsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpv-tomsk/subscriptions","organizations_url":"https://api.github.com/users/rpv-tomsk/orgs","repos_url":"https://api.github.com/users/rpv-tomsk/repos","events_url":"https://api.github.com/users/rpv-tomsk/events{/privacy}","received_events_url":"https://api.github.com/users/rpv-tomsk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rpv-tomsk/collectd","description":"The system statistics collection daemon. Mirror of the canonical repository (updated automatically). Please send Pull Requests here!","fork":true,"url":"https://api.github.com/repos/rpv-tomsk/collectd","forks_url":"https://api.github.com/repos/rpv-tomsk/collectd/forks","keys_url":"https://api.github.com/repos/rpv-tomsk/collectd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rpv-tomsk/collectd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rpv-tomsk/collectd/teams","hooks_url":"https://api.github.com/repos/rpv-tomsk/collectd/hooks","issue_events_url":"https://api.github.com/repos/rpv-tomsk/collectd/issues/events{/number}","events_url":"https://api.github.com/repos/rpv-tomsk/collectd/events","assignees_url":"https://api.github.com/repos/rpv-tomsk/collectd/assignees{/user}","branches_url":"https://api.github.com/repos/rpv-tomsk/collectd/branches{/branch}","tags_url":"https://api.github.com/repos/rpv-tomsk/collectd/tags","blobs_url":"https://api.github.com/repos/rpv-tomsk/collectd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rpv-tomsk/collectd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rpv-tomsk/collectd/git/refs{/sha}","trees_url":"https://api.github.com/repos/rpv-tomsk/collectd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rpv-tomsk/collectd/statuses/{sha}","languages_url":"https://api.github.com/repos/rpv-tomsk/collectd/languages","stargazers_url":"https://api.github.com/repos/rpv-tomsk/collectd/stargazers","contributors_url":"https://api.github.com/repos/rpv-tomsk/collectd/contributors","subscribers_url":"https://api.github.com/repos/rpv-tomsk/collectd/subscribers","subscription_url":"https://api.github.com/repos/rpv-tomsk/collectd/subscription","commits_url":"https://api.github.com/repos/rpv-tomsk/collectd/commits{/sha}","git_commits_url":"https://api.github.com/repos/rpv-tomsk/collectd/git/commits{/sha}","comments_url":"https://api.github.com/repos/rpv-tomsk/collectd/comments{/number}","issue_comment_url":"https://api.github.com/repos/rpv-tomsk/collectd/issues/comments{/number}","contents_url":"https://api.github.com/repos/rpv-tomsk/collectd/contents/{+path}","compare_url":"https://api.github.com/repos/rpv-tomsk/collectd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rpv-tomsk/collectd/merges","archive_url":"https://api.github.com/repos/rpv-tomsk/collectd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rpv-tomsk/collectd/downloads","issues_url":"https://api.github.com/repos/rpv-tomsk/collectd/issues{/number}","pulls_url":"https://api.github.com/repos/rpv-tomsk/collectd/pulls{/number}","milestones_url":"https://api.github.com/repos/rpv-tomsk/collectd/milestones{/number}","notifications_url":"https://api.github.com/repos/rpv-tomsk/collectd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rpv-tomsk/collectd/labels{/name}","releases_url":"https://api.github.com/repos/rpv-tomsk/collectd/releases{/id}","deployments_url":"https://api.github.com/repos/rpv-tomsk/collectd/deployments","created_at":"2016-02-24T11:35:57Z","updated_at":"2016-02-24T12:16:00Z","pushed_at":"2016-06-05T06:59:11Z","git_url":"git://github.com/rpv-tomsk/collectd.git","ssh_url":"git@github.com:rpv-tomsk/collectd.git","clone_url":"https://github.com/rpv-tomsk/collectd.git","svn_url":"https://github.com/rpv-tomsk/collectd","homepage":"http://collectd.org/","size":14071,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"collectd:master","ref":"master","sha":"826293bf3acfdcee6632f5d8f0b6be013f2cebab","user":{"login":"collectd","id":1027481,"avatar_url":"https://avatars.githubusercontent.com/u/1027481?v=3","gravatar_id":"","url":"https://api.github.com/users/collectd","html_url":"https://github.com/collectd","followers_url":"https://api.github.com/users/collectd/followers","following_url":"https://api.github.com/users/collectd/following{/other_user}","gists_url":"https://api.github.com/users/collectd/gists{/gist_id}","starred_url":"https://api.github.com/users/collectd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collectd/subscriptions","organizations_url":"https://api.github.com/users/collectd/orgs","repos_url":"https://api.github.com/users/collectd/repos","events_url":"https://api.github.com/users/collectd/events{/privacy}","received_events_url":"https://api.github.com/users/collectd/received_events","type":"Organization","site_admin":false},"repo":{"id":3208640,"name":"collectd","full_name":"collectd/collectd","owner":{"login":"collectd","id":1027481,"avatar_url":"https://avatars.githubusercontent.com/u/1027481?v=3","gravatar_id":"","url":"https://api.github.com/users/collectd","html_url":"https://github.com/collectd","followers_url":"https://api.github.com/users/collectd/followers","following_url":"https://api.github.com/users/collectd/following{/other_user}","gists_url":"https://api.github.com/users/collectd/gists{/gist_id}","starred_url":"https://api.github.com/users/collectd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collectd/subscriptions","organizations_url":"https://api.github.com/users/collectd/orgs","repos_url":"https://api.github.com/users/collectd/repos","events_url":"https://api.github.com/users/collectd/events{/privacy}","received_events_url":"https://api.github.com/users/collectd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/collectd/collectd","description":"The system statistics collection daemon. Mirror of the canonical repository (updated automatically). Please send Pull Requests here!","fork":false,"url":"https://api.github.com/repos/collectd/collectd","forks_url":"https://api.github.com/repos/collectd/collectd/forks","keys_url":"https://api.github.com/repos/collectd/collectd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/collectd/collectd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/collectd/collectd/teams","hooks_url":"https://api.github.com/repos/collectd/collectd/hooks","issue_events_url":"https://api.github.com/repos/collectd/collectd/issues/events{/number}","events_url":"https://api.github.com/repos/collectd/collectd/events","assignees_url":"https://api.github.com/repos/collectd/collectd/assignees{/user}","branches_url":"https://api.github.com/repos/collectd/collectd/branches{/branch}","tags_url":"https://api.github.com/repos/collectd/collectd/tags","blobs_url":"https://api.github.com/repos/collectd/collectd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/collectd/collectd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/collectd/collectd/git/refs{/sha}","trees_url":"https://api.github.com/repos/collectd/collectd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/collectd/collectd/statuses/{sha}","languages_url":"https://api.github.com/repos/collectd/collectd/languages","stargazers_url":"https://api.github.com/repos/collectd/collectd/stargazers","contributors_url":"https://api.github.com/repos/collectd/collectd/contributors","subscribers_url":"https://api.github.com/repos/collectd/collectd/subscribers","subscription_url":"https://api.github.com/repos/collectd/collectd/subscription","commits_url":"https://api.github.com/repos/collectd/collectd/commits{/sha}","git_commits_url":"https://api.github.com/repos/collectd/collectd/git/commits{/sha}","comments_url":"https://api.github.com/repos/collectd/collectd/comments{/number}","issue_comment_url":"https://api.github.com/repos/collectd/collectd/issues/comments{/number}","contents_url":"https://api.github.com/repos/collectd/collectd/contents/{+path}","compare_url":"https://api.github.com/repos/collectd/collectd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/collectd/collectd/merges","archive_url":"https://api.github.com/repos/collectd/collectd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/collectd/collectd/downloads","issues_url":"https://api.github.com/repos/collectd/collectd/issues{/number}","pulls_url":"https://api.github.com/repos/collectd/collectd/pulls{/number}","milestones_url":"https://api.github.com/repos/collectd/collectd/milestones{/number}","notifications_url":"https://api.github.com/repos/collectd/collectd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/collectd/collectd/labels{/name}","releases_url":"https://api.github.com/repos/collectd/collectd/releases{/id}","deployments_url":"https://api.github.com/repos/collectd/collectd/deployments","created_at":"2012-01-18T13:07:51Z","updated_at":"2016-06-05T09:34:05Z","pushed_at":"2016-06-05T06:59:11Z","git_url":"git://github.com/collectd/collectd.git","ssh_url":"git@github.com:collectd/collectd.git","clone_url":"https://github.com/collectd/collectd.git","svn_url":"https://github.com/collectd/collectd","homepage":"http://collectd.org/","size":27341,"stargazers_count":1162,"watchers_count":1162,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":666,"mirror_url":null,"open_issues_count":361,"forks":666,"open_issues":361,"watchers":1162,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/collectd/collectd/pulls/1723"},"html":{"href":"https://github.com/collectd/collectd/pull/1723"},"issue":{"href":"https://api.github.com/repos/collectd/collectd/issues/1723"},"comments":{"href":"https://api.github.com/repos/collectd/collectd/issues/1723/comments"},"review_comments":{"href":"https://api.github.com/repos/collectd/collectd/pulls/1723/comments"},"review_comment":{"href":"https://api.github.com/repos/collectd/collectd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/collectd/collectd/pulls/1723/commits"},"statuses":{"href":"https://api.github.com/repos/collectd/collectd/statuses/baec98579514cae9888f15af623dc59c0e89e434"}}}}
{"actor":{"display_login":"rubenk"}}