{"action":"closed","number":27,"pull_request":{"url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/pulls/27","id":57908328,"html_url":"https://github.com/dolphinsmalltalk/DolphinVM/pull/27","diff_url":"https://github.com/dolphinsmalltalk/DolphinVM/pull/27.diff","patch_url":"https://github.com/dolphinsmalltalk/DolphinVM/pull/27.patch","issue_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/issues/27","number":27,"state":"closed","locked":false,"title":"Git tag as product version","user":{"login":"jgfoster","id":1577872,"avatar_url":"https://avatars.githubusercontent.com/u/1577872?v=3","gravatar_id":"","url":"https://api.github.com/users/jgfoster","html_url":"https://github.com/jgfoster","followers_url":"https://api.github.com/users/jgfoster/followers","following_url":"https://api.github.com/users/jgfoster/following{/other_user}","gists_url":"https://api.github.com/users/jgfoster/gists{/gist_id}","starred_url":"https://api.github.com/users/jgfoster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgfoster/subscriptions","organizations_url":"https://api.github.com/users/jgfoster/orgs","repos_url":"https://api.github.com/users/jgfoster/repos","events_url":"https://api.github.com/users/jgfoster/events{/privacy}","received_events_url":"https://api.github.com/users/jgfoster/received_events","type":"User","site_admin":false},"body":"With this set of commits we use the git tag-commit as the product version in each .dll and .exe. The basic approach is to have a pre-build script that creates a Version.h in the intermediate directory based on the current git tag-commit. Each resource file (*.rc) has been edited to replace the product version string with a macro that is defined in Version.h. Again, the .rc files do not show diffs very well because they were initially committed with Unix line endings and now have Windows line endings (see #23).","created_at":"2016-02-01T22:10:46Z","updated_at":"2016-02-04T05:46:09Z","closed_at":"2016-02-04T05:46:09Z","merged_at":null,"merge_commit_sha":"325acc2c78b154ee70b22cc936edab528dbe3b20","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/pulls/27/commits","review_comments_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/pulls/27/comments","review_comment_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/issues/27/comments","statuses_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/statuses/8dfd8183621cf88320826c18155dc24609b1509d","head":{"label":"jgfoster:git_tag_as_product_version","ref":"git_tag_as_product_version","sha":"8dfd8183621cf88320826c18155dc24609b1509d","user":{"login":"jgfoster","id":1577872,"avatar_url":"https://avatars.githubusercontent.com/u/1577872?v=3","gravatar_id":"","url":"https://api.github.com/users/jgfoster","html_url":"https://github.com/jgfoster","followers_url":"https://api.github.com/users/jgfoster/followers","following_url":"https://api.github.com/users/jgfoster/following{/other_user}","gists_url":"https://api.github.com/users/jgfoster/gists{/gist_id}","starred_url":"https://api.github.com/users/jgfoster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgfoster/subscriptions","organizations_url":"https://api.github.com/users/jgfoster/orgs","repos_url":"https://api.github.com/users/jgfoster/repos","events_url":"https://api.github.com/users/jgfoster/events{/privacy}","received_events_url":"https://api.github.com/users/jgfoster/received_events","type":"User","site_admin":false},"repo":{"id":49602212,"name":"DolphinVM","full_name":"jgfoster/DolphinVM","owner":{"login":"jgfoster","id":1577872,"avatar_url":"https://avatars.githubusercontent.com/u/1577872?v=3","gravatar_id":"","url":"https://api.github.com/users/jgfoster","html_url":"https://github.com/jgfoster","followers_url":"https://api.github.com/users/jgfoster/followers","following_url":"https://api.github.com/users/jgfoster/following{/other_user}","gists_url":"https://api.github.com/users/jgfoster/gists{/gist_id}","starred_url":"https://api.github.com/users/jgfoster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgfoster/subscriptions","organizations_url":"https://api.github.com/users/jgfoster/orgs","repos_url":"https://api.github.com/users/jgfoster/repos","events_url":"https://api.github.com/users/jgfoster/events{/privacy}","received_events_url":"https://api.github.com/users/jgfoster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jgfoster/DolphinVM","description":"Dolphin Smalltalk virtual machine","fork":true,"url":"https://api.github.com/repos/jgfoster/DolphinVM","forks_url":"https://api.github.com/repos/jgfoster/DolphinVM/forks","keys_url":"https://api.github.com/repos/jgfoster/DolphinVM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgfoster/DolphinVM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgfoster/DolphinVM/teams","hooks_url":"https://api.github.com/repos/jgfoster/DolphinVM/hooks","issue_events_url":"https://api.github.com/repos/jgfoster/DolphinVM/issues/events{/number}","events_url":"https://api.github.com/repos/jgfoster/DolphinVM/events","assignees_url":"https://api.github.com/repos/jgfoster/DolphinVM/assignees{/user}","branches_url":"https://api.github.com/repos/jgfoster/DolphinVM/branches{/branch}","tags_url":"https://api.github.com/repos/jgfoster/DolphinVM/tags","blobs_url":"https://api.github.com/repos/jgfoster/DolphinVM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgfoster/DolphinVM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgfoster/DolphinVM/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgfoster/DolphinVM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgfoster/DolphinVM/statuses/{sha}","languages_url":"https://api.github.com/repos/jgfoster/DolphinVM/languages","stargazers_url":"https://api.github.com/repos/jgfoster/DolphinVM/stargazers","contributors_url":"https://api.github.com/repos/jgfoster/DolphinVM/contributors","subscribers_url":"https://api.github.com/repos/jgfoster/DolphinVM/subscribers","subscription_url":"https://api.github.com/repos/jgfoster/DolphinVM/subscription","commits_url":"https://api.github.com/repos/jgfoster/DolphinVM/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgfoster/DolphinVM/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgfoster/DolphinVM/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgfoster/DolphinVM/issues/comments{/number}","contents_url":"https://api.github.com/repos/jgfoster/DolphinVM/contents/{+path}","compare_url":"https://api.github.com/repos/jgfoster/DolphinVM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgfoster/DolphinVM/merges","archive_url":"https://api.github.com/repos/jgfoster/DolphinVM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgfoster/DolphinVM/downloads","issues_url":"https://api.github.com/repos/jgfoster/DolphinVM/issues{/number}","pulls_url":"https://api.github.com/repos/jgfoster/DolphinVM/pulls{/number}","milestones_url":"https://api.github.com/repos/jgfoster/DolphinVM/milestones{/number}","notifications_url":"https://api.github.com/repos/jgfoster/DolphinVM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgfoster/DolphinVM/labels{/name}","releases_url":"https://api.github.com/repos/jgfoster/DolphinVM/releases{/id}","deployments_url":"https://api.github.com/repos/jgfoster/DolphinVM/deployments","created_at":"2016-01-13T21:13:36Z","updated_at":"2016-01-13T21:13:37Z","pushed_at":"2016-02-04T05:45:22Z","git_url":"git://github.com/jgfoster/DolphinVM.git","ssh_url":"git@github.com:jgfoster/DolphinVM.git","clone_url":"https://github.com/jgfoster/DolphinVM.git","svn_url":"https://github.com/jgfoster/DolphinVM","homepage":null,"size":6408,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dolphinsmalltalk:master","ref":"master","sha":"8eac068e56c69f5eb92d7f97b4a933b12074c53d","user":{"login":"dolphinsmalltalk","id":16529717,"avatar_url":"https://avatars.githubusercontent.com/u/16529717?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphinsmalltalk","html_url":"https://github.com/dolphinsmalltalk","followers_url":"https://api.github.com/users/dolphinsmalltalk/followers","following_url":"https://api.github.com/users/dolphinsmalltalk/following{/other_user}","gists_url":"https://api.github.com/users/dolphinsmalltalk/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphinsmalltalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphinsmalltalk/subscriptions","organizations_url":"https://api.github.com/users/dolphinsmalltalk/orgs","repos_url":"https://api.github.com/users/dolphinsmalltalk/repos","events_url":"https://api.github.com/users/dolphinsmalltalk/events{/privacy}","received_events_url":"https://api.github.com/users/dolphinsmalltalk/received_events","type":"Organization","site_admin":false},"repo":{"id":30906598,"name":"DolphinVM","full_name":"dolphinsmalltalk/DolphinVM","owner":{"login":"dolphinsmalltalk","id":16529717,"avatar_url":"https://avatars.githubusercontent.com/u/16529717?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphinsmalltalk","html_url":"https://github.com/dolphinsmalltalk","followers_url":"https://api.github.com/users/dolphinsmalltalk/followers","following_url":"https://api.github.com/users/dolphinsmalltalk/following{/other_user}","gists_url":"https://api.github.com/users/dolphinsmalltalk/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphinsmalltalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphinsmalltalk/subscriptions","organizations_url":"https://api.github.com/users/dolphinsmalltalk/orgs","repos_url":"https://api.github.com/users/dolphinsmalltalk/repos","events_url":"https://api.github.com/users/dolphinsmalltalk/events{/privacy}","received_events_url":"https://api.github.com/users/dolphinsmalltalk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphinsmalltalk/DolphinVM","description":"Dolphin Smalltalk virtual machine","fork":false,"url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM","forks_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/forks","keys_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/teams","hooks_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/hooks","issue_events_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/issues/events{/number}","events_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/events","assignees_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/assignees{/user}","branches_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/branches{/branch}","tags_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/tags","blobs_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/languages","stargazers_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/stargazers","contributors_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/contributors","subscribers_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/subscribers","subscription_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/subscription","commits_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/contents/{+path}","compare_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/merges","archive_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/downloads","issues_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/issues{/number}","pulls_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/labels{/name}","releases_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/releases{/id}","deployments_url":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/deployments","created_at":"2015-02-17T07:18:12Z","updated_at":"2016-01-27T18:49:38Z","pushed_at":"2016-02-04T04:30:45Z","git_url":"git://github.com/dolphinsmalltalk/DolphinVM.git","ssh_url":"git@github.com:dolphinsmalltalk/DolphinVM.git","clone_url":"https://github.com/dolphinsmalltalk/DolphinVM.git","svn_url":"https://github.com/dolphinsmalltalk/DolphinVM","homepage":null,"size":6372,"stargazers_count":65,"watchers_count":65,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":14,"forks":15,"open_issues":14,"watchers":65,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/pulls/27"},"html":{"href":"https://github.com/dolphinsmalltalk/DolphinVM/pull/27"},"issue":{"href":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/issues/27"},"comments":{"href":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/dolphinsmalltalk/DolphinVM/statuses/8dfd8183621cf88320826c18155dc24609b1509d"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":9,"additions":2336,"deletions":2054,"changed_files":30}}