{"action":"created","issue":{"url":"https://api.github.com/repos/jisaacks/GitGutter/issues/331","repository_url":"https://api.github.com/repos/jisaacks/GitGutter","labels_url":"https://api.github.com/repos/jisaacks/GitGutter/issues/331/labels{/name}","comments_url":"https://api.github.com/repos/jisaacks/GitGutter/issues/331/comments","events_url":"https://api.github.com/repos/jisaacks/GitGutter/issues/331/events","html_url":"https://github.com/jisaacks/GitGutter/pull/331","id":189781196,"number":331,"title":"Some usage optimization","user":{"login":"deathaxe","id":16542113,"avatar_url":"https://avatars.githubusercontent.com/u/16542113?v=3","gravatar_id":"","url":"https://api.github.com/users/deathaxe","html_url":"https://github.com/deathaxe","followers_url":"https://api.github.com/users/deathaxe/followers","following_url":"https://api.github.com/users/deathaxe/following{/other_user}","gists_url":"https://api.github.com/users/deathaxe/gists{/gist_id}","starred_url":"https://api.github.com/users/deathaxe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deathaxe/subscriptions","organizations_url":"https://api.github.com/users/deathaxe/orgs","repos_url":"https://api.github.com/users/deathaxe/repos","events_url":"https://api.github.com/users/deathaxe/events{/privacy}","received_events_url":"https://api.github.com/users/deathaxe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-11-16T17:28:46Z","updated_at":"2016-11-18T17:31:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jisaacks/GitGutter/pulls/331","html_url":"https://github.com/jisaacks/GitGutter/pull/331","diff_url":"https://github.com/jisaacks/GitGutter/pull/331.diff","patch_url":"https://github.com/jisaacks/GitGutter/pull/331.patch"},"body":"Hello guys, very much thanks for your incredible good work with GitGutter 1.4.0. \r\n\r\nA also made up my mind how to improve this plug-in a little bit and found two things I would like to discuss or already started to in the issues section.\r\n\r\nSorry for I was not yet able to distinguish the commits to make a pull request for each.\r\n\r\n1. Create temp files only for views, whose content is stored in a git repository. (trivial minor improvement)\r\n2. Run Git and diff only if necessary and avoid running it twice.\r\n\r\nI think it's better to talk about real code, than generally discuss things. I know there are some concerns about the second probosal and I am sure it needs extensive testing before productive use, but I think it could generally help saving some CPU in the background.\r\n\r\nThe basic idea behind it is to let git_gutter run only for visible views if live_mode or focus_change_mode are active as git_gutter will run for each view being activated anyway.\r\n\r\nI was already able to prevent git_gutter from running 100 times when doing a search and replace in files with this commit and did not find significant issues with gutter not being updated for none active but visible views. \r\n\r\nHope you are willing to test and discuss it. :-)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/jisaacks/GitGutter/issues/comments/261591217","html_url":"https://github.com/jisaacks/GitGutter/pull/331#issuecomment-261591217","issue_url":"https://api.github.com/repos/jisaacks/GitGutter/issues/331","id":261591217,"user":{"login":"deathaxe","id":16542113,"avatar_url":"https://avatars.githubusercontent.com/u/16542113?v=3","gravatar_id":"","url":"https://api.github.com/users/deathaxe","html_url":"https://github.com/deathaxe","followers_url":"https://api.github.com/users/deathaxe/followers","following_url":"https://api.github.com/users/deathaxe/following{/other_user}","gists_url":"https://api.github.com/users/deathaxe/gists{/gist_id}","starred_url":"https://api.github.com/users/deathaxe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deathaxe/subscriptions","organizations_url":"https://api.github.com/users/deathaxe/orgs","repos_url":"https://api.github.com/users/deathaxe/repos","events_url":"https://api.github.com/users/deathaxe/events{/privacy}","received_events_url":"https://api.github.com/users/deathaxe/received_events","type":"User","site_admin":false},"created_at":"2016-11-18T17:31:06Z","updated_at":"2016-11-18T17:31:06Z","body":"> and maybe it would be better to split them into separate pull request.\r\n\r\nJust to ask, as I did not do several pull requests in parallel right now: I would need to create a new feature-branch for that and move all changes over there based on the latest official commit of jisaacks?"}}
{"actor":{"display_login":"deathaxe"}}