{"action":"created","comment":{"url":"https://api.github.com/repos/smartercleanup/platform/pulls/comments/54368391","id":54368391,"diff_hunk":"@@ -298,8 +316,22 @@ var Shareabouts = Shareabouts || {};\n     },\n \n     clearFilter: function() {\n+      console.log(\"clearFilter\");\n+\n       var self = this;\n       this.locationTypeFilter = null;\n+\n+      // REFACTOR\n+      // Not too sure about this part of the code... I replaced the commented-out section below\n+      // with to loops that iterate through all collections in the collection object, and all models\n+      // within those collections\n+      _.each(this.collection, function(collection) {\n+        _.each(collection.models, function(model) {\n+          self.layerViews[model.cid].render();\n+        });\n+      });\n+\n+      /*","path":"src/sa_web/static/js/views/map-view.js","position":88,"original_position":88,"commit_id":"a055c967a577aa59921e545f50aeda364a9e9eb3","original_commit_id":"a055c967a577aa59921e545f50aeda364a9e9eb3","user":{"login":"LukeSwart","id":4207017,"avatar_url":"https://avatars.githubusercontent.com/u/4207017?v=3","gravatar_id":"","url":"https://api.github.com/users/LukeSwart","html_url":"https://github.com/LukeSwart","followers_url":"https://api.github.com/users/LukeSwart/followers","following_url":"https://api.github.com/users/LukeSwart/following{/other_user}","gists_url":"https://api.github.com/users/LukeSwart/gists{/gist_id}","starred_url":"https://api.github.com/users/LukeSwart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukeSwart/subscriptions","organizations_url":"https://api.github.com/users/LukeSwart/orgs","repos_url":"https://api.github.com/users/LukeSwart/repos","events_url":"https://api.github.com/users/LukeSwart/events{/privacy}","received_events_url":"https://api.github.com/users/LukeSwart/received_events","type":"User","site_admin":false},"body":"Yep, that makes sense. We are no longer using this filter, because it really needs to be refactored and re-implemented. It would be helpful if you to keep an eye out for it, and let me know if it causes you any issues, or if you have any ideas for the future implementation.","created_at":"2016-02-29T04:30:09Z","updated_at":"2016-02-29T04:30:09Z","html_url":"https://github.com/smartercleanup/platform/pull/298#discussion_r54368391","pull_request_url":"https://api.github.com/repos/smartercleanup/platform/pulls/298","_links":{"self":{"href":"https://api.github.com/repos/smartercleanup/platform/pulls/comments/54368391"},"html":{"href":"https://github.com/smartercleanup/platform/pull/298#discussion_r54368391"},"pull_request":{"href":"https://api.github.com/repos/smartercleanup/platform/pulls/298"}}},"pull_request":{"url":"https://api.github.com/repos/smartercleanup/platform/pulls/298","id":61014766,"html_url":"https://github.com/smartercleanup/platform/pull/298","diff_url":"https://github.com/smartercleanup/platform/pull/298.diff","patch_url":"https://github.com/smartercleanup/platform/pull/298.patch","issue_url":"https://api.github.com/repos/smartercleanup/platform/issues/298","number":298,"state":"open","locked":false,"title":"Goldpbear/backbone model refactor","user":{"login":"goldpbear","id":9222338,"avatar_url":"https://avatars.githubusercontent.com/u/9222338?v=3","gravatar_id":"","url":"https://api.github.com/users/goldpbear","html_url":"https://github.com/goldpbear","followers_url":"https://api.github.com/users/goldpbear/followers","following_url":"https://api.github.com/users/goldpbear/following{/other_user}","gists_url":"https://api.github.com/users/goldpbear/gists{/gist_id}","starred_url":"https://api.github.com/users/goldpbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goldpbear/subscriptions","organizations_url":"https://api.github.com/users/goldpbear/orgs","repos_url":"https://api.github.com/users/goldpbear/repos","events_url":"https://api.github.com/users/goldpbear/events{/privacy}","received_events_url":"https://api.github.com/users/goldpbear/received_events","type":"User","site_admin":false},"body":"Rough first stab at refactoring backbone collections into a single object, facilitating cleaner urls. I added comments (with the word \"REFACTOR\" to make them easy to find) explaining what I tried to do. A couple of obvious issues exist-- typing in direct paths to refactored landmark urls does not take the user to that landmark (this is probably an issue with making the API call incorrectly), and landmark icons do not resize properly when clicking from icon to icon for some reason.","created_at":"2016-02-29T00:32:15Z","updated_at":"2016-02-29T04:30:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"285e6901ae458a628fd359b045714e933fc157de","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/smartercleanup/platform/pulls/298/commits","review_comments_url":"https://api.github.com/repos/smartercleanup/platform/pulls/298/comments","review_comment_url":"https://api.github.com/repos/smartercleanup/platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartercleanup/platform/issues/298/comments","statuses_url":"https://api.github.com/repos/smartercleanup/platform/statuses/a055c967a577aa59921e545f50aeda364a9e9eb3","head":{"label":"smartercleanup:goldpbear/backboneModelRefactor","ref":"goldpbear/backboneModelRefactor","sha":"a055c967a577aa59921e545f50aeda364a9e9eb3","user":{"login":"smartercleanup","id":7245803,"avatar_url":"https://avatars.githubusercontent.com/u/7245803?v=3","gravatar_id":"","url":"https://api.github.com/users/smartercleanup","html_url":"https://github.com/smartercleanup","followers_url":"https://api.github.com/users/smartercleanup/followers","following_url":"https://api.github.com/users/smartercleanup/following{/other_user}","gists_url":"https://api.github.com/users/smartercleanup/gists{/gist_id}","starred_url":"https://api.github.com/users/smartercleanup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartercleanup/subscriptions","organizations_url":"https://api.github.com/users/smartercleanup/orgs","repos_url":"https://api.github.com/users/smartercleanup/repos","events_url":"https://api.github.com/users/smartercleanup/events{/privacy}","received_events_url":"https://api.github.com/users/smartercleanup/received_events","type":"Organization","site_admin":false},"repo":{"id":28108305,"name":"platform","full_name":"smartercleanup/platform","owner":{"login":"smartercleanup","id":7245803,"avatar_url":"https://avatars.githubusercontent.com/u/7245803?v=3","gravatar_id":"","url":"https://api.github.com/users/smartercleanup","html_url":"https://github.com/smartercleanup","followers_url":"https://api.github.com/users/smartercleanup/followers","following_url":"https://api.github.com/users/smartercleanup/following{/other_user}","gists_url":"https://api.github.com/users/smartercleanup/gists{/gist_id}","starred_url":"https://api.github.com/users/smartercleanup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartercleanup/subscriptions","organizations_url":"https://api.github.com/users/smartercleanup/orgs","repos_url":"https://api.github.com/users/smartercleanup/repos","events_url":"https://api.github.com/users/smartercleanup/events{/privacy}","received_events_url":"https://api.github.com/users/smartercleanup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartercleanup/platform","description":"Hey Duwamish! is a community engagement tool designed for environmental cleanup projects","fork":false,"url":"https://api.github.com/repos/smartercleanup/platform","forks_url":"https://api.github.com/repos/smartercleanup/platform/forks","keys_url":"https://api.github.com/repos/smartercleanup/platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartercleanup/platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartercleanup/platform/teams","hooks_url":"https://api.github.com/repos/smartercleanup/platform/hooks","issue_events_url":"https://api.github.com/repos/smartercleanup/platform/issues/events{/number}","events_url":"https://api.github.com/repos/smartercleanup/platform/events","assignees_url":"https://api.github.com/repos/smartercleanup/platform/assignees{/user}","branches_url":"https://api.github.com/repos/smartercleanup/platform/branches{/branch}","tags_url":"https://api.github.com/repos/smartercleanup/platform/tags","blobs_url":"https://api.github.com/repos/smartercleanup/platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartercleanup/platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartercleanup/platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartercleanup/platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartercleanup/platform/statuses/{sha}","languages_url":"https://api.github.com/repos/smartercleanup/platform/languages","stargazers_url":"https://api.github.com/repos/smartercleanup/platform/stargazers","contributors_url":"https://api.github.com/repos/smartercleanup/platform/contributors","subscribers_url":"https://api.github.com/repos/smartercleanup/platform/subscribers","subscription_url":"https://api.github.com/repos/smartercleanup/platform/subscription","commits_url":"https://api.github.com/repos/smartercleanup/platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartercleanup/platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartercleanup/platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartercleanup/platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartercleanup/platform/contents/{+path}","compare_url":"https://api.github.com/repos/smartercleanup/platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartercleanup/platform/merges","archive_url":"https://api.github.com/repos/smartercleanup/platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartercleanup/platform/downloads","issues_url":"https://api.github.com/repos/smartercleanup/platform/issues{/number}","pulls_url":"https://api.github.com/repos/smartercleanup/platform/pulls{/number}","milestones_url":"https://api.github.com/repos/smartercleanup/platform/milestones{/number}","notifications_url":"https://api.github.com/repos/smartercleanup/platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartercleanup/platform/labels{/name}","releases_url":"https://api.github.com/repos/smartercleanup/platform/releases{/id}","deployments_url":"https://api.github.com/repos/smartercleanup/platform/deployments","created_at":"2014-12-16T21:51:30Z","updated_at":"2016-02-28T04:20:38Z","pushed_at":"2016-02-29T02:01:13Z","git_url":"git://github.com/smartercleanup/platform.git","ssh_url":"git@github.com:smartercleanup/platform.git","clone_url":"https://github.com/smartercleanup/platform.git","svn_url":"https://github.com/smartercleanup/platform","homepage":"http://heyduwamish.org","size":15450,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":78,"forks":14,"open_issues":78,"watchers":27,"default_branch":"master"}},"base":{"label":"smartercleanup:develop","ref":"develop","sha":"7f838bf1d62f88d7868b7baf06449a328657a348","user":{"login":"smartercleanup","id":7245803,"avatar_url":"https://avatars.githubusercontent.com/u/7245803?v=3","gravatar_id":"","url":"https://api.github.com/users/smartercleanup","html_url":"https://github.com/smartercleanup","followers_url":"https://api.github.com/users/smartercleanup/followers","following_url":"https://api.github.com/users/smartercleanup/following{/other_user}","gists_url":"https://api.github.com/users/smartercleanup/gists{/gist_id}","starred_url":"https://api.github.com/users/smartercleanup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartercleanup/subscriptions","organizations_url":"https://api.github.com/users/smartercleanup/orgs","repos_url":"https://api.github.com/users/smartercleanup/repos","events_url":"https://api.github.com/users/smartercleanup/events{/privacy}","received_events_url":"https://api.github.com/users/smartercleanup/received_events","type":"Organization","site_admin":false},"repo":{"id":28108305,"name":"platform","full_name":"smartercleanup/platform","owner":{"login":"smartercleanup","id":7245803,"avatar_url":"https://avatars.githubusercontent.com/u/7245803?v=3","gravatar_id":"","url":"https://api.github.com/users/smartercleanup","html_url":"https://github.com/smartercleanup","followers_url":"https://api.github.com/users/smartercleanup/followers","following_url":"https://api.github.com/users/smartercleanup/following{/other_user}","gists_url":"https://api.github.com/users/smartercleanup/gists{/gist_id}","starred_url":"https://api.github.com/users/smartercleanup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartercleanup/subscriptions","organizations_url":"https://api.github.com/users/smartercleanup/orgs","repos_url":"https://api.github.com/users/smartercleanup/repos","events_url":"https://api.github.com/users/smartercleanup/events{/privacy}","received_events_url":"https://api.github.com/users/smartercleanup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartercleanup/platform","description":"Hey Duwamish! is a community engagement tool designed for environmental cleanup projects","fork":false,"url":"https://api.github.com/repos/smartercleanup/platform","forks_url":"https://api.github.com/repos/smartercleanup/platform/forks","keys_url":"https://api.github.com/repos/smartercleanup/platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartercleanup/platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartercleanup/platform/teams","hooks_url":"https://api.github.com/repos/smartercleanup/platform/hooks","issue_events_url":"https://api.github.com/repos/smartercleanup/platform/issues/events{/number}","events_url":"https://api.github.com/repos/smartercleanup/platform/events","assignees_url":"https://api.github.com/repos/smartercleanup/platform/assignees{/user}","branches_url":"https://api.github.com/repos/smartercleanup/platform/branches{/branch}","tags_url":"https://api.github.com/repos/smartercleanup/platform/tags","blobs_url":"https://api.github.com/repos/smartercleanup/platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartercleanup/platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartercleanup/platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartercleanup/platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartercleanup/platform/statuses/{sha}","languages_url":"https://api.github.com/repos/smartercleanup/platform/languages","stargazers_url":"https://api.github.com/repos/smartercleanup/platform/stargazers","contributors_url":"https://api.github.com/repos/smartercleanup/platform/contributors","subscribers_url":"https://api.github.com/repos/smartercleanup/platform/subscribers","subscription_url":"https://api.github.com/repos/smartercleanup/platform/subscription","commits_url":"https://api.github.com/repos/smartercleanup/platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartercleanup/platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartercleanup/platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartercleanup/platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartercleanup/platform/contents/{+path}","compare_url":"https://api.github.com/repos/smartercleanup/platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartercleanup/platform/merges","archive_url":"https://api.github.com/repos/smartercleanup/platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartercleanup/platform/downloads","issues_url":"https://api.github.com/repos/smartercleanup/platform/issues{/number}","pulls_url":"https://api.github.com/repos/smartercleanup/platform/pulls{/number}","milestones_url":"https://api.github.com/repos/smartercleanup/platform/milestones{/number}","notifications_url":"https://api.github.com/repos/smartercleanup/platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartercleanup/platform/labels{/name}","releases_url":"https://api.github.com/repos/smartercleanup/platform/releases{/id}","deployments_url":"https://api.github.com/repos/smartercleanup/platform/deployments","created_at":"2014-12-16T21:51:30Z","updated_at":"2016-02-28T04:20:38Z","pushed_at":"2016-02-29T02:01:13Z","git_url":"git://github.com/smartercleanup/platform.git","ssh_url":"git@github.com:smartercleanup/platform.git","clone_url":"https://github.com/smartercleanup/platform.git","svn_url":"https://github.com/smartercleanup/platform","homepage":"http://heyduwamish.org","size":15450,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":78,"forks":14,"open_issues":78,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartercleanup/platform/pulls/298"},"html":{"href":"https://github.com/smartercleanup/platform/pull/298"},"issue":{"href":"https://api.github.com/repos/smartercleanup/platform/issues/298"},"comments":{"href":"https://api.github.com/repos/smartercleanup/platform/issues/298/comments"},"review_comments":{"href":"https://api.github.com/repos/smartercleanup/platform/pulls/298/comments"},"review_comment":{"href":"https://api.github.com/repos/smartercleanup/platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartercleanup/platform/pulls/298/commits"},"statuses":{"href":"https://api.github.com/repos/smartercleanup/platform/statuses/a055c967a577aa59921e545f50aeda364a9e9eb3"}}}}