{"action":"created","comment":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/75341711","id":75341711,"diff_hunk":"@@ -444,32 +465,48 @@ void EnggDiffFittingPresenter::enableMultiRun(\n             \"Please try again\");\n       } else {\n \n+        // clear previous directories set before updateFittingDirVec\n+        if (g_fitting_runno_counter == 0)\n+          g_multi_run_directories.clear();\n+\n         // to track the FittingRunnoChanged loop number\n         g_fitting_runno_counter++;\n \n-        // if given a multi run number instead\n+        // rewrite the vector of run number which is available\n+        std::vector<std::string> foundRunNumber;\n+\n         for (size_t i = 0; i < RunNumberVec.size(); i++) {\n           // save dir for every vector\n-          updateFittingDirVec(focusDir, RunNumberVec[i], fittingRunNoDirVec);\n+          updateFittingDirVec(focusDir, RunNumberVec[i], fittingRunNoDirVec,\n+                              foundRunNumber);\n         }\n+\n         int diff = (lastNum - firstNum) + 1;\n-        auto run_vec_size = RunNumberVec.size();\n+        auto run_vec_size = foundRunNumber.size();","path":"MantidQt/CustomInterfaces/src/EnggDiffraction/EnggDiffFittingPresenter.cpp","position":171,"original_position":171,"commit_id":"e4ac555f977ec17ec638427ef1fbf6823ee516f1","original_commit_id":"e4ac555f977ec17ec638427ef1fbf6823ee516f1","user":{"login":"DavidFair","id":1817032,"avatar_url":"https://avatars.githubusercontent.com/u/1817032?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidFair","html_url":"https://github.com/DavidFair","followers_url":"https://api.github.com/users/DavidFair/followers","following_url":"https://api.github.com/users/DavidFair/following{/other_user}","gists_url":"https://api.github.com/users/DavidFair/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidFair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidFair/subscriptions","organizations_url":"https://api.github.com/users/DavidFair/orgs","repos_url":"https://api.github.com/users/DavidFair/repos","events_url":"https://api.github.com/users/DavidFair/events{/privacy}","received_events_url":"https://api.github.com/users/DavidFair/received_events","type":"User","site_admin":false},"body":"Could we make this `size_t` instead of `auto`?","created_at":"2016-08-18T16:29:21Z","updated_at":"2016-08-18T16:29:21Z","html_url":"https://github.com/mantidproject/mantid/pull/17276#discussion_r75341711","pull_request_url":"https://api.github.com/repos/mantidproject/mantid/pulls/17276","_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/75341711"},"html":{"href":"https://github.com/mantidproject/mantid/pull/17276#discussion_r75341711"},"pull_request":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/17276"}}},"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/17276","id":81838996,"html_url":"https://github.com/mantidproject/mantid/pull/17276","diff_url":"https://github.com/mantidproject/mantid/pull/17276.diff","patch_url":"https://github.com/mantidproject/mantid/pull/17276.patch","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/17276","number":17276,"state":"open","locked":false,"title":"Engg:: Enable Fitting tab to accept cropped and texture files","user":{"login":"shahrozahmed1","id":13132173,"avatar_url":"https://avatars.githubusercontent.com/u/13132173?v=3","gravatar_id":"","url":"https://api.github.com/users/shahrozahmed1","html_url":"https://github.com/shahrozahmed1","followers_url":"https://api.github.com/users/shahrozahmed1/followers","following_url":"https://api.github.com/users/shahrozahmed1/following{/other_user}","gists_url":"https://api.github.com/users/shahrozahmed1/gists{/gist_id}","starred_url":"https://api.github.com/users/shahrozahmed1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shahrozahmed1/subscriptions","organizations_url":"https://api.github.com/users/shahrozahmed1/orgs","repos_url":"https://api.github.com/users/shahrozahmed1/repos","events_url":"https://api.github.com/users/shahrozahmed1/events{/privacy}","received_events_url":"https://api.github.com/users/shahrozahmed1/received_events","type":"User","site_admin":false},"body":"**Description of work.**\r\n\r\nUser now will be able to provide a cropped or texture workspace as an input for the Fitting Tab.\r\nThe algorithm SaveDiffFittingAscii will be utilised and will be saving the output as `csv` file in the following folder: C:\\EnginX_Mantid\\User\\<RB-Number>\\SinglePeakFitting\\ according to the run number of the cropped or texture file.\r\n\r\n**To test:**\r\n\r\nFocused files can be found here: `\\\\olympic\\Babylon5\\Public\\Shahroz\\`\r\nMake sure you can find the texture and cropped files in directory above.\r\n\r\n\r\n**Test 1**\r\nGo to: `Interfaces/Diffraction/Engineering Diffraction/Fitting Tab`\r\n\r\nBrowse the file `ENGINX_256663_focused_cropped.nxs`\r\nBank widget should be updated to `cropped`\r\nClick `Fit` button once it has been enabled\r\nUpon completion, please checks that Fitting results has been saved in the following directory `C:\\EnginX_Mantid\\User\\<RB-Number>\\SinglePeakFitting` with the following format `ENGINX_1256663_Single_Peak_Fitting.csv` with bank name set as `customised`\r\n\r\n**Test 2**\r\nGo to: `Interfaces/Diffraction/Engineering Diffraction/Fitting Tab`\r\n\r\nBrowse the file `ENGINX_256664_focused_texture_bank_3.nxs`\r\nBank widget should be updated to 3\r\nClick `Fit` button once it has been enabled\r\nUpon completion, please checks that Fitting results has been saved in the following directory `C:\\EnginX_Mantid\\User\\<RB-Number>\\SinglePeakFitting` with the following format `ENGINX_256664_Single_Peak_Fitting.csv` with bank name set as `customised`\r\n\r\n\r\nFixes #17241\r\n*Does not need to be in the release notes.*\r\n\r\n<!-- RELEASE NOTES\r\nEither edit the file in docs/source/release/... and it will be in your pull request or state\r\n*Does not need to be in the release notes.*\r\n-->\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)? Is it well structured with small focussed classes/methods/functions?\r\n- [ ] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] How do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant documentation been added/updated?\r\n- [ ] Is user-facing documentation written in a user-friendly manner?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it.\r\n","created_at":"2016-08-18T15:43:05Z","updated_at":"2016-08-18T16:29:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b72e8c6a60ab4658ea21826e41a11beb5a7118a9","assignee":{"login":"DavidFair","id":1817032,"avatar_url":"https://avatars.githubusercontent.com/u/1817032?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidFair","html_url":"https://github.com/DavidFair","followers_url":"https://api.github.com/users/DavidFair/followers","following_url":"https://api.github.com/users/DavidFair/following{/other_user}","gists_url":"https://api.github.com/users/DavidFair/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidFair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidFair/subscriptions","organizations_url":"https://api.github.com/users/DavidFair/orgs","repos_url":"https://api.github.com/users/DavidFair/repos","events_url":"https://api.github.com/users/DavidFair/events{/privacy}","received_events_url":"https://api.github.com/users/DavidFair/received_events","type":"User","site_admin":false},"assignees":[{"login":"DavidFair","id":1817032,"avatar_url":"https://avatars.githubusercontent.com/u/1817032?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidFair","html_url":"https://github.com/DavidFair","followers_url":"https://api.github.com/users/DavidFair/followers","following_url":"https://api.github.com/users/DavidFair/following{/other_user}","gists_url":"https://api.github.com/users/DavidFair/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidFair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidFair/subscriptions","organizations_url":"https://api.github.com/users/DavidFair/orgs","repos_url":"https://api.github.com/users/DavidFair/repos","events_url":"https://api.github.com/users/DavidFair/events{/privacy}","received_events_url":"https://api.github.com/users/DavidFair/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/58","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.8","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/58/labels","id":1505614,"number":58,"title":"Release 3.8","description":"","creator":{"login":"granrothge","id":5910574,"avatar_url":"https://avatars.githubusercontent.com/u/5910574?v=3","gravatar_id":"","url":"https://api.github.com/users/granrothge","html_url":"https://github.com/granrothge","followers_url":"https://api.github.com/users/granrothge/followers","following_url":"https://api.github.com/users/granrothge/following{/other_user}","gists_url":"https://api.github.com/users/granrothge/gists{/gist_id}","starred_url":"https://api.github.com/users/granrothge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granrothge/subscriptions","organizations_url":"https://api.github.com/users/granrothge/orgs","repos_url":"https://api.github.com/users/granrothge/repos","events_url":"https://api.github.com/users/granrothge/events{/privacy}","received_events_url":"https://api.github.com/users/granrothge/received_events","type":"User","site_admin":false},"open_issues":718,"closed_issues":626,"state":"open","created_at":"2016-01-13T20:00:53Z","updated_at":"2016-08-18T15:43:05Z","due_on":"2016-10-09T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mantidproject/mantid/pulls/17276/commits","review_comments_url":"https://api.github.com/repos/mantidproject/mantid/pulls/17276/comments","review_comment_url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/17276/comments","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/e4ac555f977ec17ec638427ef1fbf6823ee516f1","head":{"label":"mantidproject:17241_enable_fitting_tab_to_accept_cropped_texture_files","ref":"17241_enable_fitting_tab_to_accept_cropped_texture_files","sha":"e4ac555f977ec17ec638427ef1fbf6823ee516f1","user":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2016-08-06T12:19:17Z","pushed_at":"2016-08-18T16:05:51Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":433622,"stargazers_count":47,"watchers_count":47,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":1645,"forks":36,"open_issues":1645,"watchers":47,"default_branch":"master"}},"base":{"label":"mantidproject:master","ref":"master","sha":"efd80ef58845c0162fbb5b84a1130e1fd9c432e2","user":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2016-08-06T12:19:17Z","pushed_at":"2016-08-18T16:05:51Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":433622,"stargazers_count":47,"watchers_count":47,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":1645,"forks":36,"open_issues":1645,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/17276"},"html":{"href":"https://github.com/mantidproject/mantid/pull/17276"},"issue":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/17276"},"comments":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/17276/comments"},"review_comments":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/17276/comments"},"review_comment":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/17276/commits"},"statuses":{"href":"https://api.github.com/repos/mantidproject/mantid/statuses/e4ac555f977ec17ec638427ef1fbf6823ee516f1"}}}}
{"actor":{"display_login":"DavidFair"}}