{"action":"created","comment":{"url":"https://api.github.com/repos/serut/meteor-coverage/pulls/comments/79665210","id":79665210,"diff_hunk":"@@ -23,8 +23,8 @@ export default class {\n       switch (type) {\n       case 'remap':\n         {\n-          let reportRemap = new ReportRemap(res, type, options);\n-          Conf.remap && reportRemap.generate();\n+          let reportRemap = new ReportRemap(res, type, options, Log);","path":"server/report/report-service.js","position":22,"original_position":22,"commit_id":"bb64310c958657dd02cc33f816fa268d12f60ea0","original_commit_id":"bb64310c958657dd02cc33f816fa268d12f60ea0","user":{"login":"serut","id":2767218,"avatar_url":"https://avatars.githubusercontent.com/u/2767218?v=3","gravatar_id":"","url":"https://api.github.com/users/serut","html_url":"https://github.com/serut","followers_url":"https://api.github.com/users/serut/followers","following_url":"https://api.github.com/users/serut/following{/other_user}","gists_url":"https://api.github.com/users/serut/gists{/gist_id}","starred_url":"https://api.github.com/users/serut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serut/subscriptions","organizations_url":"https://api.github.com/users/serut/orgs","repos_url":"https://api.github.com/users/serut/repos","events_url":"https://api.github.com/users/serut/events{/privacy}","received_events_url":"https://api.github.com/users/serut/received_events","type":"User","site_admin":false},"body":"useless parameter Log there","created_at":"2016-09-20T17:21:30Z","updated_at":"2016-09-20T17:21:30Z","html_url":"https://github.com/serut/meteor-coverage/pull/37#discussion_r79665210","pull_request_url":"https://api.github.com/repos/serut/meteor-coverage/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/serut/meteor-coverage/pulls/comments/79665210"},"html":{"href":"https://github.com/serut/meteor-coverage/pull/37#discussion_r79665210"},"pull_request":{"href":"https://api.github.com/repos/serut/meteor-coverage/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/serut/meteor-coverage/pulls/37","id":86015381,"html_url":"https://github.com/serut/meteor-coverage/pull/37","diff_url":"https://github.com/serut/meteor-coverage/pull/37.diff","patch_url":"https://github.com/serut/meteor-coverage/pull/37.patch","issue_url":"https://api.github.com/repos/serut/meteor-coverage/issues/37","number":37,"state":"open","locked":false,"title":"Fix remap @ dev-1.0.0","user":{"login":"cgalvarez","id":10707639,"avatar_url":"https://avatars.githubusercontent.com/u/10707639?v=3","gravatar_id":"","url":"https://api.github.com/users/cgalvarez","html_url":"https://github.com/cgalvarez","followers_url":"https://api.github.com/users/cgalvarez/followers","following_url":"https://api.github.com/users/cgalvarez/following{/other_user}","gists_url":"https://api.github.com/users/cgalvarez/gists{/gist_id}","starred_url":"https://api.github.com/users/cgalvarez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgalvarez/subscriptions","organizations_url":"https://api.github.com/users/cgalvarez/orgs","repos_url":"https://api.github.com/users/cgalvarez/repos","events_url":"https://api.github.com/users/cgalvarez/events{/privacy}","received_events_url":"https://api.github.com/users/cgalvarez/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\n- [x] Fix remap timeout or replace `it` by `xit` to ignore the test\r\n- [x] Edit readme.md with how to use remap\r\n- [x] Remove legacy code inside reporters because now files  are merged correctly mapped with real ones \r\n- [x] Edit changelog\r\n- [x] Update version in `package.js` and `package.json`\r\n- [ ] meteor-coverage-app-exemple build ok : [![Build Status](https://travis-ci.org/serut/meteor-coverage-app-exemple.svg?branch=master)](https://travis-ci.org/serut/meteor-coverage-app-exemple) 👋 \r\n- [ ] Remove annoying messages printed with `console.error()` by `remap-istanbul` when writing files of HTML report (printed as errors, but they are not; printed [here](https://github.com/gotwarlost/istanbul/blob/master/lib/report/html.js#L478-L487)).\r\n- [ ] Issue with `console.log` and `Log.info`\r\n- [ ] Improve coverage\r\n\r\n### Steps to reproduce issue with `console.log` and `Log.info`\r\n\r\n1. Replace [`warn: Log.info`](https://github.com/serut/meteor-coverage/blob/dev-1.0.0-fixes/server/report/report-remap.js#L69) with `warn: console.warn`.\r\n2. Exec `meteor npm run test > output.txt`.\r\n3. You'll see some messages like `Could not find ...` that `remap-istanbul` prints for every file included in the coverage that has no source map.\r\n\r\nMy intention was printing it as additional info, but when using `Log.info` or `console.log`, it prints absolutely nothing.\r\n\r\n### Issue with remap\r\n\r\nI should see the message `export coverage using the following format [ remap ]`, but I don't see it in the verbose output.\r\n\r\n## Types of changes\r\n\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n","created_at":"2016-09-20T16:57:31Z","updated_at":"2016-09-20T17:21:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f073af9c1a3bb569bfacf1578dec770860a2ac3f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/serut/meteor-coverage/pulls/37/commits","review_comments_url":"https://api.github.com/repos/serut/meteor-coverage/pulls/37/comments","review_comment_url":"https://api.github.com/repos/serut/meteor-coverage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/serut/meteor-coverage/issues/37/comments","statuses_url":"https://api.github.com/repos/serut/meteor-coverage/statuses/bb64310c958657dd02cc33f816fa268d12f60ea0","head":{"label":"serut:dev-1.0.0-fixes","ref":"dev-1.0.0-fixes","sha":"bb64310c958657dd02cc33f816fa268d12f60ea0","user":{"login":"serut","id":2767218,"avatar_url":"https://avatars.githubusercontent.com/u/2767218?v=3","gravatar_id":"","url":"https://api.github.com/users/serut","html_url":"https://github.com/serut","followers_url":"https://api.github.com/users/serut/followers","following_url":"https://api.github.com/users/serut/following{/other_user}","gists_url":"https://api.github.com/users/serut/gists{/gist_id}","starred_url":"https://api.github.com/users/serut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serut/subscriptions","organizations_url":"https://api.github.com/users/serut/orgs","repos_url":"https://api.github.com/users/serut/repos","events_url":"https://api.github.com/users/serut/events{/privacy}","received_events_url":"https://api.github.com/users/serut/received_events","type":"User","site_admin":false},"repo":{"id":54708593,"name":"meteor-coverage","full_name":"serut/meteor-coverage","owner":{"login":"serut","id":2767218,"avatar_url":"https://avatars.githubusercontent.com/u/2767218?v=3","gravatar_id":"","url":"https://api.github.com/users/serut","html_url":"https://github.com/serut","followers_url":"https://api.github.com/users/serut/followers","following_url":"https://api.github.com/users/serut/following{/other_user}","gists_url":"https://api.github.com/users/serut/gists{/gist_id}","starred_url":"https://api.github.com/users/serut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serut/subscriptions","organizations_url":"https://api.github.com/users/serut/orgs","repos_url":"https://api.github.com/users/serut/repos","events_url":"https://api.github.com/users/serut/events{/privacy}","received_events_url":"https://api.github.com/users/serut/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/serut/meteor-coverage","description":"Server and client coverage for Meteor","fork":false,"url":"https://api.github.com/repos/serut/meteor-coverage","forks_url":"https://api.github.com/repos/serut/meteor-coverage/forks","keys_url":"https://api.github.com/repos/serut/meteor-coverage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serut/meteor-coverage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serut/meteor-coverage/teams","hooks_url":"https://api.github.com/repos/serut/meteor-coverage/hooks","issue_events_url":"https://api.github.com/repos/serut/meteor-coverage/issues/events{/number}","events_url":"https://api.github.com/repos/serut/meteor-coverage/events","assignees_url":"https://api.github.com/repos/serut/meteor-coverage/assignees{/user}","branches_url":"https://api.github.com/repos/serut/meteor-coverage/branches{/branch}","tags_url":"https://api.github.com/repos/serut/meteor-coverage/tags","blobs_url":"https://api.github.com/repos/serut/meteor-coverage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serut/meteor-coverage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serut/meteor-coverage/git/refs{/sha}","trees_url":"https://api.github.com/repos/serut/meteor-coverage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serut/meteor-coverage/statuses/{sha}","languages_url":"https://api.github.com/repos/serut/meteor-coverage/languages","stargazers_url":"https://api.github.com/repos/serut/meteor-coverage/stargazers","contributors_url":"https://api.github.com/repos/serut/meteor-coverage/contributors","subscribers_url":"https://api.github.com/repos/serut/meteor-coverage/subscribers","subscription_url":"https://api.github.com/repos/serut/meteor-coverage/subscription","commits_url":"https://api.github.com/repos/serut/meteor-coverage/commits{/sha}","git_commits_url":"https://api.github.com/repos/serut/meteor-coverage/git/commits{/sha}","comments_url":"https://api.github.com/repos/serut/meteor-coverage/comments{/number}","issue_comment_url":"https://api.github.com/repos/serut/meteor-coverage/issues/comments{/number}","contents_url":"https://api.github.com/repos/serut/meteor-coverage/contents/{+path}","compare_url":"https://api.github.com/repos/serut/meteor-coverage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serut/meteor-coverage/merges","archive_url":"https://api.github.com/repos/serut/meteor-coverage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serut/meteor-coverage/downloads","issues_url":"https://api.github.com/repos/serut/meteor-coverage/issues{/number}","pulls_url":"https://api.github.com/repos/serut/meteor-coverage/pulls{/number}","milestones_url":"https://api.github.com/repos/serut/meteor-coverage/milestones{/number}","notifications_url":"https://api.github.com/repos/serut/meteor-coverage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serut/meteor-coverage/labels{/name}","releases_url":"https://api.github.com/repos/serut/meteor-coverage/releases{/id}","deployments_url":"https://api.github.com/repos/serut/meteor-coverage/deployments","created_at":"2016-03-25T09:19:59Z","updated_at":"2016-09-20T15:10:46Z","pushed_at":"2016-09-20T16:57:31Z","git_url":"git://github.com/serut/meteor-coverage.git","ssh_url":"git@github.com:serut/meteor-coverage.git","clone_url":"https://github.com/serut/meteor-coverage.git","svn_url":"https://github.com/serut/meteor-coverage","homepage":"","size":192,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":8,"forks":7,"open_issues":8,"watchers":18,"default_branch":"master"}},"base":{"label":"serut:dev-1.0.0","ref":"dev-1.0.0","sha":"a970c3f00d6fdccad841e3f04bc45049589b02d6","user":{"login":"serut","id":2767218,"avatar_url":"https://avatars.githubusercontent.com/u/2767218?v=3","gravatar_id":"","url":"https://api.github.com/users/serut","html_url":"https://github.com/serut","followers_url":"https://api.github.com/users/serut/followers","following_url":"https://api.github.com/users/serut/following{/other_user}","gists_url":"https://api.github.com/users/serut/gists{/gist_id}","starred_url":"https://api.github.com/users/serut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serut/subscriptions","organizations_url":"https://api.github.com/users/serut/orgs","repos_url":"https://api.github.com/users/serut/repos","events_url":"https://api.github.com/users/serut/events{/privacy}","received_events_url":"https://api.github.com/users/serut/received_events","type":"User","site_admin":false},"repo":{"id":54708593,"name":"meteor-coverage","full_name":"serut/meteor-coverage","owner":{"login":"serut","id":2767218,"avatar_url":"https://avatars.githubusercontent.com/u/2767218?v=3","gravatar_id":"","url":"https://api.github.com/users/serut","html_url":"https://github.com/serut","followers_url":"https://api.github.com/users/serut/followers","following_url":"https://api.github.com/users/serut/following{/other_user}","gists_url":"https://api.github.com/users/serut/gists{/gist_id}","starred_url":"https://api.github.com/users/serut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serut/subscriptions","organizations_url":"https://api.github.com/users/serut/orgs","repos_url":"https://api.github.com/users/serut/repos","events_url":"https://api.github.com/users/serut/events{/privacy}","received_events_url":"https://api.github.com/users/serut/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/serut/meteor-coverage","description":"Server and client coverage for Meteor","fork":false,"url":"https://api.github.com/repos/serut/meteor-coverage","forks_url":"https://api.github.com/repos/serut/meteor-coverage/forks","keys_url":"https://api.github.com/repos/serut/meteor-coverage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serut/meteor-coverage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serut/meteor-coverage/teams","hooks_url":"https://api.github.com/repos/serut/meteor-coverage/hooks","issue_events_url":"https://api.github.com/repos/serut/meteor-coverage/issues/events{/number}","events_url":"https://api.github.com/repos/serut/meteor-coverage/events","assignees_url":"https://api.github.com/repos/serut/meteor-coverage/assignees{/user}","branches_url":"https://api.github.com/repos/serut/meteor-coverage/branches{/branch}","tags_url":"https://api.github.com/repos/serut/meteor-coverage/tags","blobs_url":"https://api.github.com/repos/serut/meteor-coverage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serut/meteor-coverage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serut/meteor-coverage/git/refs{/sha}","trees_url":"https://api.github.com/repos/serut/meteor-coverage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serut/meteor-coverage/statuses/{sha}","languages_url":"https://api.github.com/repos/serut/meteor-coverage/languages","stargazers_url":"https://api.github.com/repos/serut/meteor-coverage/stargazers","contributors_url":"https://api.github.com/repos/serut/meteor-coverage/contributors","subscribers_url":"https://api.github.com/repos/serut/meteor-coverage/subscribers","subscription_url":"https://api.github.com/repos/serut/meteor-coverage/subscription","commits_url":"https://api.github.com/repos/serut/meteor-coverage/commits{/sha}","git_commits_url":"https://api.github.com/repos/serut/meteor-coverage/git/commits{/sha}","comments_url":"https://api.github.com/repos/serut/meteor-coverage/comments{/number}","issue_comment_url":"https://api.github.com/repos/serut/meteor-coverage/issues/comments{/number}","contents_url":"https://api.github.com/repos/serut/meteor-coverage/contents/{+path}","compare_url":"https://api.github.com/repos/serut/meteor-coverage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serut/meteor-coverage/merges","archive_url":"https://api.github.com/repos/serut/meteor-coverage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serut/meteor-coverage/downloads","issues_url":"https://api.github.com/repos/serut/meteor-coverage/issues{/number}","pulls_url":"https://api.github.com/repos/serut/meteor-coverage/pulls{/number}","milestones_url":"https://api.github.com/repos/serut/meteor-coverage/milestones{/number}","notifications_url":"https://api.github.com/repos/serut/meteor-coverage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serut/meteor-coverage/labels{/name}","releases_url":"https://api.github.com/repos/serut/meteor-coverage/releases{/id}","deployments_url":"https://api.github.com/repos/serut/meteor-coverage/deployments","created_at":"2016-03-25T09:19:59Z","updated_at":"2016-09-20T15:10:46Z","pushed_at":"2016-09-20T16:57:31Z","git_url":"git://github.com/serut/meteor-coverage.git","ssh_url":"git@github.com:serut/meteor-coverage.git","clone_url":"https://github.com/serut/meteor-coverage.git","svn_url":"https://github.com/serut/meteor-coverage","homepage":"","size":192,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":8,"forks":7,"open_issues":8,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/serut/meteor-coverage/pulls/37"},"html":{"href":"https://github.com/serut/meteor-coverage/pull/37"},"issue":{"href":"https://api.github.com/repos/serut/meteor-coverage/issues/37"},"comments":{"href":"https://api.github.com/repos/serut/meteor-coverage/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/serut/meteor-coverage/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/serut/meteor-coverage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/serut/meteor-coverage/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/serut/meteor-coverage/statuses/bb64310c958657dd02cc33f816fa268d12f60ea0"}}}}
{"actor":{"display_login":"serut"}}