{"action":"created","comment":{"url":"https://api.github.com/repos/mike820324/microProxy/pulls/comments/87981087","pull_request_review_id":8568516,"id":87981087,"diff_hunk":"@@ -49,5 +51,6 @@ def register_stream_handler(cls):  # pragma: no cover\n \n     @classmethod\n     def get_logger(cls, name):  # pragma: no cover\n-        logger = logging.getLogger(name)\n+        shortname = \".\".join(split_str for split_str in name.split(\".\") if split_str != \"microproxy\")\n+        logger = logging.getLogger(shortname)","path":"microproxy/log.py","position":17,"original_position":17,"commit_id":"f5ac599c37396346766d1a4a638763c3370418f4","original_commit_id":"f5ac599c37396346766d1a4a638763c3370418f4","user":{"login":"chhsiao90","id":10794200,"avatar_url":"https://avatars.githubusercontent.com/u/10794200?v=3","gravatar_id":"","url":"https://api.github.com/users/chhsiao90","html_url":"https://github.com/chhsiao90","followers_url":"https://api.github.com/users/chhsiao90/followers","following_url":"https://api.github.com/users/chhsiao90/following{/other_user}","gists_url":"https://api.github.com/users/chhsiao90/gists{/gist_id}","starred_url":"https://api.github.com/users/chhsiao90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chhsiao90/subscriptions","organizations_url":"https://api.github.com/users/chhsiao90/orgs","repos_url":"https://api.github.com/users/chhsiao90/repos","events_url":"https://api.github.com/users/chhsiao90/events{/privacy}","received_events_url":"https://api.github.com/users/chhsiao90/received_events","type":"User","site_admin":false},"body":"Is this code mean remove microproxy for the logger name?\r\nMaybe it need a comment or extract a function for it.\r\nIt's not clear to see the code and know what this code mean.\r\n\r\nBTW, do we really need to remove microproxy prefix of logger name?\r\nWhat could we get the benefit from it?","created_at":"2016-11-15T09:52:12Z","updated_at":"2016-11-15T09:52:42Z","html_url":"https://github.com/mike820324/microProxy/pull/233#discussion_r87981087","pull_request_url":"https://api.github.com/repos/mike820324/microProxy/pulls/233","_links":{"self":{"href":"https://api.github.com/repos/mike820324/microProxy/pulls/comments/87981087"},"html":{"href":"https://github.com/mike820324/microProxy/pull/233#discussion_r87981087"},"pull_request":{"href":"https://api.github.com/repos/mike820324/microProxy/pulls/233"}}},"pull_request":{"url":"https://api.github.com/repos/mike820324/microProxy/pulls/233","id":93688209,"html_url":"https://github.com/mike820324/microProxy/pull/233","diff_url":"https://github.com/mike820324/microProxy/pull/233.diff","patch_url":"https://github.com/mike820324/microProxy/pull/233.patch","issue_url":"https://api.github.com/repos/mike820324/microProxy/issues/233","number":233,"state":"open","locked":false,"title":"Fix proxy start failed when using logger config file.","user":{"login":"mike820324","id":1079601,"avatar_url":"https://avatars.githubusercontent.com/u/1079601?v=3","gravatar_id":"","url":"https://api.github.com/users/mike820324","html_url":"https://github.com/mike820324","followers_url":"https://api.github.com/users/mike820324/followers","following_url":"https://api.github.com/users/mike820324/following{/other_user}","gists_url":"https://api.github.com/users/mike820324/gists{/gist_id}","starred_url":"https://api.github.com/users/mike820324/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike820324/subscriptions","organizations_url":"https://api.github.com/users/mike820324/orgs","repos_url":"https://api.github.com/users/mike820324/repos","events_url":"https://api.github.com/users/mike820324/events{/privacy}","received_events_url":"https://api.github.com/users/mike820324/received_events","type":"User","site_admin":false},"body":"The previous PR will cause proxy server start failed when using logger config file.","created_at":"2016-11-15T02:14:02Z","updated_at":"2016-11-15T09:52:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eac191aef32c9b54ba72accc5f46c9130ca395ee","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mike820324/microProxy/pulls/233/commits","review_comments_url":"https://api.github.com/repos/mike820324/microProxy/pulls/233/comments","review_comment_url":"https://api.github.com/repos/mike820324/microProxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mike820324/microProxy/issues/233/comments","statuses_url":"https://api.github.com/repos/mike820324/microProxy/statuses/f5ac599c37396346766d1a4a638763c3370418f4","head":{"label":"mike820324:logger-quickfix","ref":"logger-quickfix","sha":"f5ac599c37396346766d1a4a638763c3370418f4","user":{"login":"mike820324","id":1079601,"avatar_url":"https://avatars.githubusercontent.com/u/1079601?v=3","gravatar_id":"","url":"https://api.github.com/users/mike820324","html_url":"https://github.com/mike820324","followers_url":"https://api.github.com/users/mike820324/followers","following_url":"https://api.github.com/users/mike820324/following{/other_user}","gists_url":"https://api.github.com/users/mike820324/gists{/gist_id}","starred_url":"https://api.github.com/users/mike820324/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike820324/subscriptions","organizations_url":"https://api.github.com/users/mike820324/orgs","repos_url":"https://api.github.com/users/mike820324/repos","events_url":"https://api.github.com/users/mike820324/events{/privacy}","received_events_url":"https://api.github.com/users/mike820324/received_events","type":"User","site_admin":false},"repo":{"id":56387587,"name":"microProxy","full_name":"mike820324/microProxy","owner":{"login":"mike820324","id":1079601,"avatar_url":"https://avatars.githubusercontent.com/u/1079601?v=3","gravatar_id":"","url":"https://api.github.com/users/mike820324","html_url":"https://github.com/mike820324","followers_url":"https://api.github.com/users/mike820324/followers","following_url":"https://api.github.com/users/mike820324/following{/other_user}","gists_url":"https://api.github.com/users/mike820324/gists{/gist_id}","starred_url":"https://api.github.com/users/mike820324/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike820324/subscriptions","organizations_url":"https://api.github.com/users/mike820324/orgs","repos_url":"https://api.github.com/users/mike820324/repos","events_url":"https://api.github.com/users/mike820324/events{/privacy}","received_events_url":"https://api.github.com/users/mike820324/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mike820324/microProxy","description":"A http/https interceptor written in pure python.","fork":false,"url":"https://api.github.com/repos/mike820324/microProxy","forks_url":"https://api.github.com/repos/mike820324/microProxy/forks","keys_url":"https://api.github.com/repos/mike820324/microProxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mike820324/microProxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mike820324/microProxy/teams","hooks_url":"https://api.github.com/repos/mike820324/microProxy/hooks","issue_events_url":"https://api.github.com/repos/mike820324/microProxy/issues/events{/number}","events_url":"https://api.github.com/repos/mike820324/microProxy/events","assignees_url":"https://api.github.com/repos/mike820324/microProxy/assignees{/user}","branches_url":"https://api.github.com/repos/mike820324/microProxy/branches{/branch}","tags_url":"https://api.github.com/repos/mike820324/microProxy/tags","blobs_url":"https://api.github.com/repos/mike820324/microProxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mike820324/microProxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mike820324/microProxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mike820324/microProxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mike820324/microProxy/statuses/{sha}","languages_url":"https://api.github.com/repos/mike820324/microProxy/languages","stargazers_url":"https://api.github.com/repos/mike820324/microProxy/stargazers","contributors_url":"https://api.github.com/repos/mike820324/microProxy/contributors","subscribers_url":"https://api.github.com/repos/mike820324/microProxy/subscribers","subscription_url":"https://api.github.com/repos/mike820324/microProxy/subscription","commits_url":"https://api.github.com/repos/mike820324/microProxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mike820324/microProxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mike820324/microProxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mike820324/microProxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mike820324/microProxy/contents/{+path}","compare_url":"https://api.github.com/repos/mike820324/microProxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mike820324/microProxy/merges","archive_url":"https://api.github.com/repos/mike820324/microProxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mike820324/microProxy/downloads","issues_url":"https://api.github.com/repos/mike820324/microProxy/issues{/number}","pulls_url":"https://api.github.com/repos/mike820324/microProxy/pulls{/number}","milestones_url":"https://api.github.com/repos/mike820324/microProxy/milestones{/number}","notifications_url":"https://api.github.com/repos/mike820324/microProxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mike820324/microProxy/labels{/name}","releases_url":"https://api.github.com/repos/mike820324/microProxy/releases{/id}","deployments_url":"https://api.github.com/repos/mike820324/microProxy/deployments","created_at":"2016-04-16T14:20:57Z","updated_at":"2016-10-26T03:17:21Z","pushed_at":"2016-11-15T02:14:02Z","git_url":"git://github.com/mike820324/microProxy.git","ssh_url":"git@github.com:mike820324/microProxy.git","clone_url":"https://github.com/mike820324/microProxy.git","svn_url":"https://github.com/mike820324/microProxy","homepage":"","size":514,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":14,"forks":0,"open_issues":14,"watchers":4,"default_branch":"master"}},"base":{"label":"mike820324:master","ref":"master","sha":"689ac52c7502e6f46f4f28b25c4dbc25cfe5ec81","user":{"login":"mike820324","id":1079601,"avatar_url":"https://avatars.githubusercontent.com/u/1079601?v=3","gravatar_id":"","url":"https://api.github.com/users/mike820324","html_url":"https://github.com/mike820324","followers_url":"https://api.github.com/users/mike820324/followers","following_url":"https://api.github.com/users/mike820324/following{/other_user}","gists_url":"https://api.github.com/users/mike820324/gists{/gist_id}","starred_url":"https://api.github.com/users/mike820324/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike820324/subscriptions","organizations_url":"https://api.github.com/users/mike820324/orgs","repos_url":"https://api.github.com/users/mike820324/repos","events_url":"https://api.github.com/users/mike820324/events{/privacy}","received_events_url":"https://api.github.com/users/mike820324/received_events","type":"User","site_admin":false},"repo":{"id":56387587,"name":"microProxy","full_name":"mike820324/microProxy","owner":{"login":"mike820324","id":1079601,"avatar_url":"https://avatars.githubusercontent.com/u/1079601?v=3","gravatar_id":"","url":"https://api.github.com/users/mike820324","html_url":"https://github.com/mike820324","followers_url":"https://api.github.com/users/mike820324/followers","following_url":"https://api.github.com/users/mike820324/following{/other_user}","gists_url":"https://api.github.com/users/mike820324/gists{/gist_id}","starred_url":"https://api.github.com/users/mike820324/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike820324/subscriptions","organizations_url":"https://api.github.com/users/mike820324/orgs","repos_url":"https://api.github.com/users/mike820324/repos","events_url":"https://api.github.com/users/mike820324/events{/privacy}","received_events_url":"https://api.github.com/users/mike820324/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mike820324/microProxy","description":"A http/https interceptor written in pure python.","fork":false,"url":"https://api.github.com/repos/mike820324/microProxy","forks_url":"https://api.github.com/repos/mike820324/microProxy/forks","keys_url":"https://api.github.com/repos/mike820324/microProxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mike820324/microProxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mike820324/microProxy/teams","hooks_url":"https://api.github.com/repos/mike820324/microProxy/hooks","issue_events_url":"https://api.github.com/repos/mike820324/microProxy/issues/events{/number}","events_url":"https://api.github.com/repos/mike820324/microProxy/events","assignees_url":"https://api.github.com/repos/mike820324/microProxy/assignees{/user}","branches_url":"https://api.github.com/repos/mike820324/microProxy/branches{/branch}","tags_url":"https://api.github.com/repos/mike820324/microProxy/tags","blobs_url":"https://api.github.com/repos/mike820324/microProxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mike820324/microProxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mike820324/microProxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mike820324/microProxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mike820324/microProxy/statuses/{sha}","languages_url":"https://api.github.com/repos/mike820324/microProxy/languages","stargazers_url":"https://api.github.com/repos/mike820324/microProxy/stargazers","contributors_url":"https://api.github.com/repos/mike820324/microProxy/contributors","subscribers_url":"https://api.github.com/repos/mike820324/microProxy/subscribers","subscription_url":"https://api.github.com/repos/mike820324/microProxy/subscription","commits_url":"https://api.github.com/repos/mike820324/microProxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mike820324/microProxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mike820324/microProxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mike820324/microProxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mike820324/microProxy/contents/{+path}","compare_url":"https://api.github.com/repos/mike820324/microProxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mike820324/microProxy/merges","archive_url":"https://api.github.com/repos/mike820324/microProxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mike820324/microProxy/downloads","issues_url":"https://api.github.com/repos/mike820324/microProxy/issues{/number}","pulls_url":"https://api.github.com/repos/mike820324/microProxy/pulls{/number}","milestones_url":"https://api.github.com/repos/mike820324/microProxy/milestones{/number}","notifications_url":"https://api.github.com/repos/mike820324/microProxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mike820324/microProxy/labels{/name}","releases_url":"https://api.github.com/repos/mike820324/microProxy/releases{/id}","deployments_url":"https://api.github.com/repos/mike820324/microProxy/deployments","created_at":"2016-04-16T14:20:57Z","updated_at":"2016-10-26T03:17:21Z","pushed_at":"2016-11-15T02:14:02Z","git_url":"git://github.com/mike820324/microProxy.git","ssh_url":"git@github.com:mike820324/microProxy.git","clone_url":"https://github.com/mike820324/microProxy.git","svn_url":"https://github.com/mike820324/microProxy","homepage":"","size":514,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":14,"forks":0,"open_issues":14,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mike820324/microProxy/pulls/233"},"html":{"href":"https://github.com/mike820324/microProxy/pull/233"},"issue":{"href":"https://api.github.com/repos/mike820324/microProxy/issues/233"},"comments":{"href":"https://api.github.com/repos/mike820324/microProxy/issues/233/comments"},"review_comments":{"href":"https://api.github.com/repos/mike820324/microProxy/pulls/233/comments"},"review_comment":{"href":"https://api.github.com/repos/mike820324/microProxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mike820324/microProxy/pulls/233/commits"},"statuses":{"href":"https://api.github.com/repos/mike820324/microProxy/statuses/f5ac599c37396346766d1a4a638763c3370418f4"}}}}
{"actor":{"display_login":"chhsiao90"}}