{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/86342087","pull_request_review_id":7004591,"id":86342087,"diff_hunk":"@@ -1933,4 +1934,70 @@ private function cleanJoomlaCache()\n \t\t$model->setState('client_id', 1);\n \t\t$model->clean();\n \t}\n+\n+\t/**\n+\t * Method to update template source formats on Joomla Update\n+\t *\n+\t * @return  void\n+\t *\n+\t * @since   __DEPLOY_VERSION__\n+\t */\n+\tprotected function updateTemplateSourceFormats()\n+\t{\n+\t\t$db = JFactory::getDbo();\n+\n+\t\ttry\n+\t\t{\n+\t\t\t// Get the params for the templates component\n+\t\t\t$params = $db->setQuery(\n+\t\t\t\t$db->getQuery(true)\n+\t\t\t\t\t->select($db->quoteName('params'))\n+\t\t\t\t\t->from($db->quoteName('#__extensions'))\n+\t\t\t\t\t->where($db->quoteName('name') . ' = ' . $db->quote('com_templates'))\n+\t\t\t\t\t->where($db->quoteName('type') . ' = ' . $db->quote('component'))\n+\t\t\t\t\t->where($db->quoteName('element') . ' = ' . $db->quote('com_templates'))\n+\t\t\t)->loadResult();\n+\t\t}\n+\t\tcatch (JDatabaseExceptionExecuting $e)\n+\t\t{\n+\t\t\techo JText::sprintf('JLIB_DATABASE_ERROR_FUNCTION_FAILED', $e->getCode(), $e->getMessage()) . '<br />';\n+\n+\t\t\treturn;\n+\t\t}\n+\n+\t\t$params         = json_decode($params, true);\n+\t\t$sourceformats  = explode(',', $params['source_formats']);","path":"administrator/components/com_admin/script.php","position":44,"original_position":44,"commit_id":"a71cd95290a72267de6fb1629853269cecd9f866","original_commit_id":"a71cd95290a72267de6fb1629853269cecd9f866","user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"body":"you probably could replace all above code by just:\r\n```php\r\n$sourceformats = explode(',', JComponentHelper::getParams('com_templates')->get('source_formats', 'txt,less,ini,xml,js,php,css,scss,sass'));\r\n```","created_at":"2016-11-03T13:33:55Z","updated_at":"2016-11-03T13:33:55Z","html_url":"https://github.com/joomla/joomla-cms/pull/12727#discussion_r86342087","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/12727","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/86342087"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/12727#discussion_r86342087"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/12727"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/12727","id":92137759,"html_url":"https://github.com/joomla/joomla-cms/pull/12727","diff_url":"https://github.com/joomla/joomla-cms/pull/12727.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/12727.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12727","number":12727,"state":"open","locked":false,"title":"[com_templates] - support for scss,sass source formats on joomla update","user":{"login":"alikon","id":181681,"avatar_url":"https://avatars.githubusercontent.com/u/181681?v=3","gravatar_id":"","url":"https://api.github.com/users/alikon","html_url":"https://github.com/alikon","followers_url":"https://api.github.com/users/alikon/followers","following_url":"https://api.github.com/users/alikon/following{/other_user}","gists_url":"https://api.github.com/users/alikon/gists{/gist_id}","starred_url":"https://api.github.com/users/alikon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alikon/subscriptions","organizations_url":"https://api.github.com/users/alikon/orgs","repos_url":"https://api.github.com/users/alikon/repos","events_url":"https://api.github.com/users/alikon/events{/privacy}","received_events_url":"https://api.github.com/users/alikon/received_events","type":"User","site_admin":false},"body":"Pull Request for Issue #10186 .\r\n\r\n### Summary of Changes\r\n added support support for scss,sass source formats on update\r\n\r\nsee #12712 for more info\r\n\r\n\r\n\r\n","created_at":"2016-11-03T11:49:00Z","updated_at":"2016-11-03T13:33:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f952610f68e13f63ae075ffb039fcaef8a83da5a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/12727/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/12727/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12727/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/a71cd95290a72267de6fb1629853269cecd9f866","head":{"label":"alikon:patch-87","ref":"patch-87","sha":"a71cd95290a72267de6fb1629853269cecd9f866","user":{"login":"alikon","id":181681,"avatar_url":"https://avatars.githubusercontent.com/u/181681?v=3","gravatar_id":"","url":"https://api.github.com/users/alikon","html_url":"https://github.com/alikon","followers_url":"https://api.github.com/users/alikon/followers","following_url":"https://api.github.com/users/alikon/following{/other_user}","gists_url":"https://api.github.com/users/alikon/gists{/gist_id}","starred_url":"https://api.github.com/users/alikon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alikon/subscriptions","organizations_url":"https://api.github.com/users/alikon/orgs","repos_url":"https://api.github.com/users/alikon/repos","events_url":"https://api.github.com/users/alikon/events{/privacy}","received_events_url":"https://api.github.com/users/alikon/received_events","type":"User","site_admin":false},"repo":{"id":27932665,"name":"joomla-cms","full_name":"alikon/joomla-cms","owner":{"login":"alikon","id":181681,"avatar_url":"https://avatars.githubusercontent.com/u/181681?v=3","gravatar_id":"","url":"https://api.github.com/users/alikon","html_url":"https://github.com/alikon","followers_url":"https://api.github.com/users/alikon/followers","following_url":"https://api.github.com/users/alikon/following{/other_user}","gists_url":"https://api.github.com/users/alikon/gists{/gist_id}","starred_url":"https://api.github.com/users/alikon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alikon/subscriptions","organizations_url":"https://api.github.com/users/alikon/orgs","repos_url":"https://api.github.com/users/alikon/repos","events_url":"https://api.github.com/users/alikon/events{/privacy}","received_events_url":"https://api.github.com/users/alikon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alikon/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/alikon/joomla-cms","forks_url":"https://api.github.com/repos/alikon/joomla-cms/forks","keys_url":"https://api.github.com/repos/alikon/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alikon/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alikon/joomla-cms/teams","hooks_url":"https://api.github.com/repos/alikon/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/alikon/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/alikon/joomla-cms/events","assignees_url":"https://api.github.com/repos/alikon/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/alikon/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/alikon/joomla-cms/tags","blobs_url":"https://api.github.com/repos/alikon/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alikon/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alikon/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/alikon/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alikon/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/alikon/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/alikon/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/alikon/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/alikon/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/alikon/joomla-cms/subscription","commits_url":"https://api.github.com/repos/alikon/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/alikon/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/alikon/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/alikon/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/alikon/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/alikon/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alikon/joomla-cms/merges","archive_url":"https://api.github.com/repos/alikon/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alikon/joomla-cms/downloads","issues_url":"https://api.github.com/repos/alikon/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/alikon/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/alikon/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/alikon/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alikon/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/alikon/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/alikon/joomla-cms/deployments","created_at":"2014-12-12T18:26:04Z","updated_at":"2016-06-01T05:07:02Z","pushed_at":"2016-11-03T11:45:30Z","git_url":"git://github.com/alikon/joomla-cms.git","ssh_url":"git@github.com:alikon/joomla-cms.git","clone_url":"https://github.com/alikon/joomla-cms.git","svn_url":"https://github.com/alikon/joomla-cms","homepage":"http://joomla.org","size":163418,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"6b90996e377834405a08a344d378f7ed086f2b29","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2016-11-03T08:48:23Z","pushed_at":"2016-11-03T12:48:03Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":308272,"stargazers_count":2176,"watchers_count":2176,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2326,"mirror_url":null,"open_issues_count":564,"forks":2326,"open_issues":564,"watchers":2176,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/12727"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/12727"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/12727"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/12727/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/12727/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/12727/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/a71cd95290a72267de6fb1629853269cecd9f866"}}}}
{"actor":{"display_login":"andrepereiradasilva"}}