{"action":"created","comment":{"url":"https://api.github.com/repos/angered-ghandi/OpenAOE/pulls/comments/70913557","id":70913557,"diff_hunk":"@@ -20,14 +20,11 @@\n // SOFTWARE.\n \n use specs;\n+use types::Vector4;\n \n #[derive(Clone, Debug)]\n pub struct TransformComponent {\n-    // TODO: Move to a vector type\n-    pub x: f32,\n-    pub y: f32,\n-    pub z: f32,\n-    pub rotation: f32,\n+    pub pos: Vector4<f32>","path":"src/ecs/component/transform_component.rs","position":13,"original_position":13,"commit_id":"0450ae7e9f50be4837ebee7d31f542cd713e527f","original_commit_id":"0450ae7e9f50be4837ebee7d31f542cd713e527f","user":{"login":"angered-ghandi","id":20009343,"avatar_url":"https://avatars.githubusercontent.com/u/20009343?v=3","gravatar_id":"","url":"https://api.github.com/users/angered-ghandi","html_url":"https://github.com/angered-ghandi","followers_url":"https://api.github.com/users/angered-ghandi/followers","following_url":"https://api.github.com/users/angered-ghandi/following{/other_user}","gists_url":"https://api.github.com/users/angered-ghandi/gists{/gist_id}","starred_url":"https://api.github.com/users/angered-ghandi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angered-ghandi/subscriptions","organizations_url":"https://api.github.com/users/angered-ghandi/orgs","repos_url":"https://api.github.com/users/angered-ghandi/repos","events_url":"https://api.github.com/users/angered-ghandi/events{/privacy}","received_events_url":"https://api.github.com/users/angered-ghandi/received_events","type":"User","site_admin":false},"body":"I think we should maintain the rotation separately from the position vector.","created_at":"2016-07-15T02:22:40Z","updated_at":"2016-07-15T02:22:40Z","html_url":"https://github.com/angered-ghandi/OpenAOE/pull/24#discussion_r70913557","pull_request_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/angered-ghandi/OpenAOE/pulls/comments/70913557"},"html":{"href":"https://github.com/angered-ghandi/OpenAOE/pull/24#discussion_r70913557"},"pull_request":{"href":"https://api.github.com/repos/angered-ghandi/OpenAOE/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/angered-ghandi/OpenAOE/pulls/24","id":77486904,"html_url":"https://github.com/angered-ghandi/OpenAOE/pull/24","diff_url":"https://github.com/angered-ghandi/OpenAOE/pull/24.diff","patch_url":"https://github.com/angered-ghandi/OpenAOE/pull/24.patch","issue_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/issues/24","number":24,"state":"open","locked":false,"title":"Add Vector2, Vector3 and Vector4 types","user":{"login":"RockyTV","id":1251067,"avatar_url":"https://avatars.githubusercontent.com/u/1251067?v=3","gravatar_id":"","url":"https://api.github.com/users/RockyTV","html_url":"https://github.com/RockyTV","followers_url":"https://api.github.com/users/RockyTV/followers","following_url":"https://api.github.com/users/RockyTV/following{/other_user}","gists_url":"https://api.github.com/users/RockyTV/gists{/gist_id}","starred_url":"https://api.github.com/users/RockyTV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RockyTV/subscriptions","organizations_url":"https://api.github.com/users/RockyTV/orgs","repos_url":"https://api.github.com/users/RockyTV/repos","events_url":"https://api.github.com/users/RockyTV/events{/privacy}","received_events_url":"https://api.github.com/users/RockyTV/received_events","type":"User","site_admin":false},"body":"I decided to use `Vector` as fields instead of turning the whole component into a `Vector` because this way we can still `impl specs::Component` on the component, otherwise rustc will throw [E0117](https://doc.rust-lang.org/error-index.html#E0117)\r\nCloses #18","created_at":"2016-07-14T16:37:54Z","updated_at":"2016-07-15T02:22:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59bdfef42b7fd116acb2d20bdac4d6e513e8d875","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/pulls/24/commits","review_comments_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/pulls/24/comments","review_comment_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/issues/24/comments","statuses_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/statuses/0450ae7e9f50be4837ebee7d31f542cd713e527f","head":{"label":"RockyTV:vector-type","ref":"vector-type","sha":"0450ae7e9f50be4837ebee7d31f542cd713e527f","user":{"login":"RockyTV","id":1251067,"avatar_url":"https://avatars.githubusercontent.com/u/1251067?v=3","gravatar_id":"","url":"https://api.github.com/users/RockyTV","html_url":"https://github.com/RockyTV","followers_url":"https://api.github.com/users/RockyTV/followers","following_url":"https://api.github.com/users/RockyTV/following{/other_user}","gists_url":"https://api.github.com/users/RockyTV/gists{/gist_id}","starred_url":"https://api.github.com/users/RockyTV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RockyTV/subscriptions","organizations_url":"https://api.github.com/users/RockyTV/orgs","repos_url":"https://api.github.com/users/RockyTV/repos","events_url":"https://api.github.com/users/RockyTV/events{/privacy}","received_events_url":"https://api.github.com/users/RockyTV/received_events","type":"User","site_admin":false},"repo":{"id":63192452,"name":"OpenAOE","full_name":"RockyTV/OpenAOE","owner":{"login":"RockyTV","id":1251067,"avatar_url":"https://avatars.githubusercontent.com/u/1251067?v=3","gravatar_id":"","url":"https://api.github.com/users/RockyTV","html_url":"https://github.com/RockyTV","followers_url":"https://api.github.com/users/RockyTV/followers","following_url":"https://api.github.com/users/RockyTV/following{/other_user}","gists_url":"https://api.github.com/users/RockyTV/gists{/gist_id}","starred_url":"https://api.github.com/users/RockyTV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RockyTV/subscriptions","organizations_url":"https://api.github.com/users/RockyTV/orgs","repos_url":"https://api.github.com/users/RockyTV/repos","events_url":"https://api.github.com/users/RockyTV/events{/privacy}","received_events_url":"https://api.github.com/users/RockyTV/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RockyTV/OpenAOE","description":"An open source reimplementation of Age of Empires (1997)","fork":true,"url":"https://api.github.com/repos/RockyTV/OpenAOE","forks_url":"https://api.github.com/repos/RockyTV/OpenAOE/forks","keys_url":"https://api.github.com/repos/RockyTV/OpenAOE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RockyTV/OpenAOE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RockyTV/OpenAOE/teams","hooks_url":"https://api.github.com/repos/RockyTV/OpenAOE/hooks","issue_events_url":"https://api.github.com/repos/RockyTV/OpenAOE/issues/events{/number}","events_url":"https://api.github.com/repos/RockyTV/OpenAOE/events","assignees_url":"https://api.github.com/repos/RockyTV/OpenAOE/assignees{/user}","branches_url":"https://api.github.com/repos/RockyTV/OpenAOE/branches{/branch}","tags_url":"https://api.github.com/repos/RockyTV/OpenAOE/tags","blobs_url":"https://api.github.com/repos/RockyTV/OpenAOE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RockyTV/OpenAOE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RockyTV/OpenAOE/git/refs{/sha}","trees_url":"https://api.github.com/repos/RockyTV/OpenAOE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RockyTV/OpenAOE/statuses/{sha}","languages_url":"https://api.github.com/repos/RockyTV/OpenAOE/languages","stargazers_url":"https://api.github.com/repos/RockyTV/OpenAOE/stargazers","contributors_url":"https://api.github.com/repos/RockyTV/OpenAOE/contributors","subscribers_url":"https://api.github.com/repos/RockyTV/OpenAOE/subscribers","subscription_url":"https://api.github.com/repos/RockyTV/OpenAOE/subscription","commits_url":"https://api.github.com/repos/RockyTV/OpenAOE/commits{/sha}","git_commits_url":"https://api.github.com/repos/RockyTV/OpenAOE/git/commits{/sha}","comments_url":"https://api.github.com/repos/RockyTV/OpenAOE/comments{/number}","issue_comment_url":"https://api.github.com/repos/RockyTV/OpenAOE/issues/comments{/number}","contents_url":"https://api.github.com/repos/RockyTV/OpenAOE/contents/{+path}","compare_url":"https://api.github.com/repos/RockyTV/OpenAOE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RockyTV/OpenAOE/merges","archive_url":"https://api.github.com/repos/RockyTV/OpenAOE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RockyTV/OpenAOE/downloads","issues_url":"https://api.github.com/repos/RockyTV/OpenAOE/issues{/number}","pulls_url":"https://api.github.com/repos/RockyTV/OpenAOE/pulls{/number}","milestones_url":"https://api.github.com/repos/RockyTV/OpenAOE/milestones{/number}","notifications_url":"https://api.github.com/repos/RockyTV/OpenAOE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RockyTV/OpenAOE/labels{/name}","releases_url":"https://api.github.com/repos/RockyTV/OpenAOE/releases{/id}","deployments_url":"https://api.github.com/repos/RockyTV/OpenAOE/deployments","created_at":"2016-07-12T21:08:32Z","updated_at":"2016-07-12T21:08:33Z","pushed_at":"2016-07-14T16:40:52Z","git_url":"git://github.com/RockyTV/OpenAOE.git","ssh_url":"git@github.com:RockyTV/OpenAOE.git","clone_url":"https://github.com/RockyTV/OpenAOE.git","svn_url":"https://github.com/RockyTV/OpenAOE","homepage":null,"size":376,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angered-ghandi:master","ref":"master","sha":"f4aa4e34d2d6d0b96ec593f71b340366ee3bc128","user":{"login":"angered-ghandi","id":20009343,"avatar_url":"https://avatars.githubusercontent.com/u/20009343?v=3","gravatar_id":"","url":"https://api.github.com/users/angered-ghandi","html_url":"https://github.com/angered-ghandi","followers_url":"https://api.github.com/users/angered-ghandi/followers","following_url":"https://api.github.com/users/angered-ghandi/following{/other_user}","gists_url":"https://api.github.com/users/angered-ghandi/gists{/gist_id}","starred_url":"https://api.github.com/users/angered-ghandi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angered-ghandi/subscriptions","organizations_url":"https://api.github.com/users/angered-ghandi/orgs","repos_url":"https://api.github.com/users/angered-ghandi/repos","events_url":"https://api.github.com/users/angered-ghandi/events{/privacy}","received_events_url":"https://api.github.com/users/angered-ghandi/received_events","type":"User","site_admin":false},"repo":{"id":61417595,"name":"OpenAOE","full_name":"angered-ghandi/OpenAOE","owner":{"login":"angered-ghandi","id":20009343,"avatar_url":"https://avatars.githubusercontent.com/u/20009343?v=3","gravatar_id":"","url":"https://api.github.com/users/angered-ghandi","html_url":"https://github.com/angered-ghandi","followers_url":"https://api.github.com/users/angered-ghandi/followers","following_url":"https://api.github.com/users/angered-ghandi/following{/other_user}","gists_url":"https://api.github.com/users/angered-ghandi/gists{/gist_id}","starred_url":"https://api.github.com/users/angered-ghandi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angered-ghandi/subscriptions","organizations_url":"https://api.github.com/users/angered-ghandi/orgs","repos_url":"https://api.github.com/users/angered-ghandi/repos","events_url":"https://api.github.com/users/angered-ghandi/events{/privacy}","received_events_url":"https://api.github.com/users/angered-ghandi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/angered-ghandi/OpenAOE","description":"An open source reimplementation of Age of Empires (1997)","fork":false,"url":"https://api.github.com/repos/angered-ghandi/OpenAOE","forks_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/forks","keys_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/teams","hooks_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/hooks","issue_events_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/issues/events{/number}","events_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/events","assignees_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/assignees{/user}","branches_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/branches{/branch}","tags_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/tags","blobs_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/git/refs{/sha}","trees_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/statuses/{sha}","languages_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/languages","stargazers_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/stargazers","contributors_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/contributors","subscribers_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/subscribers","subscription_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/subscription","commits_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/commits{/sha}","git_commits_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/git/commits{/sha}","comments_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/comments{/number}","issue_comment_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/issues/comments{/number}","contents_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/contents/{+path}","compare_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/merges","archive_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/downloads","issues_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/issues{/number}","pulls_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/pulls{/number}","milestones_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/milestones{/number}","notifications_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/labels{/name}","releases_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/releases{/id}","deployments_url":"https://api.github.com/repos/angered-ghandi/OpenAOE/deployments","created_at":"2016-06-18T04:53:32Z","updated_at":"2016-07-13T17:11:36Z","pushed_at":"2016-07-14T16:40:52Z","git_url":"git://github.com/angered-ghandi/OpenAOE.git","ssh_url":"git@github.com:angered-ghandi/OpenAOE.git","clone_url":"https://github.com/angered-ghandi/OpenAOE.git","svn_url":"https://github.com/angered-ghandi/OpenAOE","homepage":null,"size":364,"stargazers_count":24,"watchers_count":24,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":10,"forks":5,"open_issues":10,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angered-ghandi/OpenAOE/pulls/24"},"html":{"href":"https://github.com/angered-ghandi/OpenAOE/pull/24"},"issue":{"href":"https://api.github.com/repos/angered-ghandi/OpenAOE/issues/24"},"comments":{"href":"https://api.github.com/repos/angered-ghandi/OpenAOE/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/angered-ghandi/OpenAOE/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/angered-ghandi/OpenAOE/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angered-ghandi/OpenAOE/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/angered-ghandi/OpenAOE/statuses/0450ae7e9f50be4837ebee7d31f542cd713e527f"}}}}
{"actor":{"display_login":"angered-ghandi"}}