{"action":"created","comment":{"url":"https://api.github.com/repos/brson/mir2wasm/pulls/comments/72466940","id":72466940,"diff_hunk":"@@ -1,4 +1,5 @@\n-#![feature(lang_items, no_core)]\n+// xfail - this makes an unknown error when we try to interpret it in binaryen.","path":"tests/compile-pass/enum.rs","position":2,"original_position":2,"commit_id":"d534cbcd08e426993e94a1a72d9b34964eeef8ae","original_commit_id":"d534cbcd08e426993e94a1a72d9b34964eeef8ae","user":{"login":"eholk","id":105766,"avatar_url":"https://avatars.githubusercontent.com/u/105766?v=3","gravatar_id":"","url":"https://api.github.com/users/eholk","html_url":"https://github.com/eholk","followers_url":"https://api.github.com/users/eholk/followers","following_url":"https://api.github.com/users/eholk/following{/other_user}","gists_url":"https://api.github.com/users/eholk/gists{/gist_id}","starred_url":"https://api.github.com/users/eholk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eholk/subscriptions","organizations_url":"https://api.github.com/users/eholk/orgs","repos_url":"https://api.github.com/users/eholk/repos","events_url":"https://api.github.com/users/eholk/events{/privacy}","received_events_url":"https://api.github.com/users/eholk/received_events","type":"User","site_admin":false},"body":"I made a change to also interpret the compile-pass tests. It would be better to just copy them all into run-pass, but this was quicker for now. Ultimately, I'd like to merge all the compile-pass tests into run-pass, so we don't make any distinction.","created_at":"2016-07-27T15:52:22Z","updated_at":"2016-07-27T15:52:22Z","html_url":"https://github.com/brson/mir2wasm/pull/31#discussion_r72466940","pull_request_url":"https://api.github.com/repos/brson/mir2wasm/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/brson/mir2wasm/pulls/comments/72466940"},"html":{"href":"https://github.com/brson/mir2wasm/pull/31#discussion_r72466940"},"pull_request":{"href":"https://api.github.com/repos/brson/mir2wasm/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/brson/mir2wasm/pulls/31","id":78771185,"html_url":"https://github.com/brson/mir2wasm/pull/31","diff_url":"https://github.com/brson/mir2wasm/pull/31.diff","patch_url":"https://github.com/brson/mir2wasm/pull/31.patch","issue_url":"https://api.github.com/repos/brson/mir2wasm/issues/31","number":31,"state":"closed","locked":false,"title":"Run tests in binaryen interpreter, check output (#15)","user":{"login":"eholk","id":105766,"avatar_url":"https://avatars.githubusercontent.com/u/105766?v=3","gravatar_id":"","url":"https://api.github.com/users/eholk","html_url":"https://github.com/eholk","followers_url":"https://api.github.com/users/eholk/followers","following_url":"https://api.github.com/users/eholk/following{/other_user}","gists_url":"https://api.github.com/users/eholk/gists{/gist_id}","starred_url":"https://api.github.com/users/eholk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eholk/subscriptions","organizations_url":"https://api.github.com/users/eholk/orgs","repos_url":"https://api.github.com/users/eholk/repos","events_url":"https://api.github.com/users/eholk/events{/privacy}","received_events_url":"https://api.github.com/users/eholk/received_events","type":"User","site_admin":false},"body":"This change uses the `--run` option (thanks, @lqd!) to run the tests in the binaryen interpreter after compiling. Since we don't have a good way to return process exit statuses from the interpreter, we check stdout instead. Comments in the source file are used to specify what the expected test output is.\r\n\r\n@lqd and/or @brson - Could you review and accept the PR if it looks good to you?","created_at":"2016-07-25T23:50:46Z","updated_at":"2016-07-27T15:52:22Z","closed_at":"2016-07-25T23:54:09Z","merged_at":"2016-07-25T23:54:09Z","merge_commit_sha":"250186c312ce964778ef21607a2eb689947fb018","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/brson/mir2wasm/pulls/31/commits","review_comments_url":"https://api.github.com/repos/brson/mir2wasm/pulls/31/comments","review_comment_url":"https://api.github.com/repos/brson/mir2wasm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brson/mir2wasm/issues/31/comments","statuses_url":"https://api.github.com/repos/brson/mir2wasm/statuses/d534cbcd08e426993e94a1a72d9b34964eeef8ae","head":{"label":"eholk:test-infra","ref":"test-infra","sha":"d534cbcd08e426993e94a1a72d9b34964eeef8ae","user":{"login":"eholk","id":105766,"avatar_url":"https://avatars.githubusercontent.com/u/105766?v=3","gravatar_id":"","url":"https://api.github.com/users/eholk","html_url":"https://github.com/eholk","followers_url":"https://api.github.com/users/eholk/followers","following_url":"https://api.github.com/users/eholk/following{/other_user}","gists_url":"https://api.github.com/users/eholk/gists{/gist_id}","starred_url":"https://api.github.com/users/eholk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eholk/subscriptions","organizations_url":"https://api.github.com/users/eholk/orgs","repos_url":"https://api.github.com/users/eholk/repos","events_url":"https://api.github.com/users/eholk/events{/privacy}","received_events_url":"https://api.github.com/users/eholk/received_events","type":"User","site_admin":false},"repo":{"id":62244938,"name":"mir2wasm","full_name":"eholk/mir2wasm","owner":{"login":"eholk","id":105766,"avatar_url":"https://avatars.githubusercontent.com/u/105766?v=3","gravatar_id":"","url":"https://api.github.com/users/eholk","html_url":"https://github.com/eholk","followers_url":"https://api.github.com/users/eholk/followers","following_url":"https://api.github.com/users/eholk/following{/other_user}","gists_url":"https://api.github.com/users/eholk/gists{/gist_id}","starred_url":"https://api.github.com/users/eholk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eholk/subscriptions","organizations_url":"https://api.github.com/users/eholk/orgs","repos_url":"https://api.github.com/users/eholk/repos","events_url":"https://api.github.com/users/eholk/events{/privacy}","received_events_url":"https://api.github.com/users/eholk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eholk/mir2wasm","description":"An experimental compiler from Rust to WebAssembly","fork":true,"url":"https://api.github.com/repos/eholk/mir2wasm","forks_url":"https://api.github.com/repos/eholk/mir2wasm/forks","keys_url":"https://api.github.com/repos/eholk/mir2wasm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eholk/mir2wasm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eholk/mir2wasm/teams","hooks_url":"https://api.github.com/repos/eholk/mir2wasm/hooks","issue_events_url":"https://api.github.com/repos/eholk/mir2wasm/issues/events{/number}","events_url":"https://api.github.com/repos/eholk/mir2wasm/events","assignees_url":"https://api.github.com/repos/eholk/mir2wasm/assignees{/user}","branches_url":"https://api.github.com/repos/eholk/mir2wasm/branches{/branch}","tags_url":"https://api.github.com/repos/eholk/mir2wasm/tags","blobs_url":"https://api.github.com/repos/eholk/mir2wasm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eholk/mir2wasm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eholk/mir2wasm/git/refs{/sha}","trees_url":"https://api.github.com/repos/eholk/mir2wasm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eholk/mir2wasm/statuses/{sha}","languages_url":"https://api.github.com/repos/eholk/mir2wasm/languages","stargazers_url":"https://api.github.com/repos/eholk/mir2wasm/stargazers","contributors_url":"https://api.github.com/repos/eholk/mir2wasm/contributors","subscribers_url":"https://api.github.com/repos/eholk/mir2wasm/subscribers","subscription_url":"https://api.github.com/repos/eholk/mir2wasm/subscription","commits_url":"https://api.github.com/repos/eholk/mir2wasm/commits{/sha}","git_commits_url":"https://api.github.com/repos/eholk/mir2wasm/git/commits{/sha}","comments_url":"https://api.github.com/repos/eholk/mir2wasm/comments{/number}","issue_comment_url":"https://api.github.com/repos/eholk/mir2wasm/issues/comments{/number}","contents_url":"https://api.github.com/repos/eholk/mir2wasm/contents/{+path}","compare_url":"https://api.github.com/repos/eholk/mir2wasm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eholk/mir2wasm/merges","archive_url":"https://api.github.com/repos/eholk/mir2wasm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eholk/mir2wasm/downloads","issues_url":"https://api.github.com/repos/eholk/mir2wasm/issues{/number}","pulls_url":"https://api.github.com/repos/eholk/mir2wasm/pulls{/number}","milestones_url":"https://api.github.com/repos/eholk/mir2wasm/milestones{/number}","notifications_url":"https://api.github.com/repos/eholk/mir2wasm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eholk/mir2wasm/labels{/name}","releases_url":"https://api.github.com/repos/eholk/mir2wasm/releases{/id}","deployments_url":"https://api.github.com/repos/eholk/mir2wasm/deployments","created_at":"2016-06-29T17:30:31Z","updated_at":"2016-06-29T17:30:32Z","pushed_at":"2016-07-26T01:25:37Z","git_url":"git://github.com/eholk/mir2wasm.git","ssh_url":"git@github.com:eholk/mir2wasm.git","clone_url":"https://github.com/eholk/mir2wasm.git","svn_url":"https://github.com/eholk/mir2wasm","homepage":"","size":482,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brson:master","ref":"master","sha":"a4fedaa4489d5a9a23d25786964e463124a90b9e","user":{"login":"brson","id":147214,"avatar_url":"https://avatars.githubusercontent.com/u/147214?v=3","gravatar_id":"","url":"https://api.github.com/users/brson","html_url":"https://github.com/brson","followers_url":"https://api.github.com/users/brson/followers","following_url":"https://api.github.com/users/brson/following{/other_user}","gists_url":"https://api.github.com/users/brson/gists{/gist_id}","starred_url":"https://api.github.com/users/brson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brson/subscriptions","organizations_url":"https://api.github.com/users/brson/orgs","repos_url":"https://api.github.com/users/brson/repos","events_url":"https://api.github.com/users/brson/events{/privacy}","received_events_url":"https://api.github.com/users/brson/received_events","type":"User","site_admin":false},"repo":{"id":58480872,"name":"mir2wasm","full_name":"brson/mir2wasm","owner":{"login":"brson","id":147214,"avatar_url":"https://avatars.githubusercontent.com/u/147214?v=3","gravatar_id":"","url":"https://api.github.com/users/brson","html_url":"https://github.com/brson","followers_url":"https://api.github.com/users/brson/followers","following_url":"https://api.github.com/users/brson/following{/other_user}","gists_url":"https://api.github.com/users/brson/gists{/gist_id}","starred_url":"https://api.github.com/users/brson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brson/subscriptions","organizations_url":"https://api.github.com/users/brson/orgs","repos_url":"https://api.github.com/users/brson/repos","events_url":"https://api.github.com/users/brson/events{/privacy}","received_events_url":"https://api.github.com/users/brson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brson/mir2wasm","description":"An experimental compiler from Rust to WebAssembly","fork":true,"url":"https://api.github.com/repos/brson/mir2wasm","forks_url":"https://api.github.com/repos/brson/mir2wasm/forks","keys_url":"https://api.github.com/repos/brson/mir2wasm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brson/mir2wasm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brson/mir2wasm/teams","hooks_url":"https://api.github.com/repos/brson/mir2wasm/hooks","issue_events_url":"https://api.github.com/repos/brson/mir2wasm/issues/events{/number}","events_url":"https://api.github.com/repos/brson/mir2wasm/events","assignees_url":"https://api.github.com/repos/brson/mir2wasm/assignees{/user}","branches_url":"https://api.github.com/repos/brson/mir2wasm/branches{/branch}","tags_url":"https://api.github.com/repos/brson/mir2wasm/tags","blobs_url":"https://api.github.com/repos/brson/mir2wasm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brson/mir2wasm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brson/mir2wasm/git/refs{/sha}","trees_url":"https://api.github.com/repos/brson/mir2wasm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brson/mir2wasm/statuses/{sha}","languages_url":"https://api.github.com/repos/brson/mir2wasm/languages","stargazers_url":"https://api.github.com/repos/brson/mir2wasm/stargazers","contributors_url":"https://api.github.com/repos/brson/mir2wasm/contributors","subscribers_url":"https://api.github.com/repos/brson/mir2wasm/subscribers","subscription_url":"https://api.github.com/repos/brson/mir2wasm/subscription","commits_url":"https://api.github.com/repos/brson/mir2wasm/commits{/sha}","git_commits_url":"https://api.github.com/repos/brson/mir2wasm/git/commits{/sha}","comments_url":"https://api.github.com/repos/brson/mir2wasm/comments{/number}","issue_comment_url":"https://api.github.com/repos/brson/mir2wasm/issues/comments{/number}","contents_url":"https://api.github.com/repos/brson/mir2wasm/contents/{+path}","compare_url":"https://api.github.com/repos/brson/mir2wasm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brson/mir2wasm/merges","archive_url":"https://api.github.com/repos/brson/mir2wasm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brson/mir2wasm/downloads","issues_url":"https://api.github.com/repos/brson/mir2wasm/issues{/number}","pulls_url":"https://api.github.com/repos/brson/mir2wasm/pulls{/number}","milestones_url":"https://api.github.com/repos/brson/mir2wasm/milestones{/number}","notifications_url":"https://api.github.com/repos/brson/mir2wasm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brson/mir2wasm/labels{/name}","releases_url":"https://api.github.com/repos/brson/mir2wasm/releases{/id}","deployments_url":"https://api.github.com/repos/brson/mir2wasm/deployments","created_at":"2016-05-10T17:29:21Z","updated_at":"2016-07-27T05:12:54Z","pushed_at":"2016-07-26T20:05:08Z","git_url":"git://github.com/brson/mir2wasm.git","ssh_url":"git@github.com:brson/mir2wasm.git","clone_url":"https://github.com/brson/mir2wasm.git","svn_url":"https://github.com/brson/mir2wasm","homepage":"","size":482,"stargazers_count":52,"watchers_count":52,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":4,"forks":8,"open_issues":4,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brson/mir2wasm/pulls/31"},"html":{"href":"https://github.com/brson/mir2wasm/pull/31"},"issue":{"href":"https://api.github.com/repos/brson/mir2wasm/issues/31"},"comments":{"href":"https://api.github.com/repos/brson/mir2wasm/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/brson/mir2wasm/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/brson/mir2wasm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brson/mir2wasm/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/brson/mir2wasm/statuses/d534cbcd08e426993e94a1a72d9b34964eeef8ae"}}}}
{"actor":{"display_login":"eholk"}}