{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/tng016/TicTacToe/pulls/1","id":84793762,"html_url":"https://github.com/tng016/TicTacToe/pull/1","diff_url":"https://github.com/tng016/TicTacToe/pull/1.diff","patch_url":"https://github.com/tng016/TicTacToe/pull/1.patch","issue_url":"https://api.github.com/repos/tng016/TicTacToe/issues/1","number":1,"state":"open","locked":false,"title":"minor refactoring of TTTApp class","user":{"login":"tn52","id":6353836,"avatar_url":"https://avatars.githubusercontent.com/u/6353836?v=3","gravatar_id":"","url":"https://api.github.com/users/tn52","html_url":"https://github.com/tn52","followers_url":"https://api.github.com/users/tn52/followers","following_url":"https://api.github.com/users/tn52/following{/other_user}","gists_url":"https://api.github.com/users/tn52/gists{/gist_id}","starred_url":"https://api.github.com/users/tn52/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tn52/subscriptions","organizations_url":"https://api.github.com/users/tn52/orgs","repos_url":"https://api.github.com/users/tn52/repos","events_url":"https://api.github.com/users/tn52/events{/privacy}","received_events_url":"https://api.github.com/users/tn52/received_events","type":"User","site_admin":false},"body":"Changes made:\r\n1. renamed in and in2 (important to rename them appropriately so that its easier to read, know their purpose)\r\n2. refactored the xo method into one line (what this means is: \"(boolean expression) : (if true return this) ? (if false return this) ; \" )\r\n3. executed xo method in beginning and stored into a char variable, so I only have to execute the method only once every turn\r\n\r\nOther small problems/edge cases I noted: \r\n- take into account draw --> print something out in event of a tie\r\n- invalid inputs --> maybe print a warning if inputs are out of range (not 1,2 or 3)\r\n","created_at":"2016-09-11T18:27:06Z","updated_at":"2016-09-11T18:27:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tng016/TicTacToe/pulls/1/commits","review_comments_url":"https://api.github.com/repos/tng016/TicTacToe/pulls/1/comments","review_comment_url":"https://api.github.com/repos/tng016/TicTacToe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tng016/TicTacToe/issues/1/comments","statuses_url":"https://api.github.com/repos/tng016/TicTacToe/statuses/119b55f335ded2818afac291c87b8c14861a1613","head":{"label":"tn52:master","ref":"master","sha":"119b55f335ded2818afac291c87b8c14861a1613","user":{"login":"tn52","id":6353836,"avatar_url":"https://avatars.githubusercontent.com/u/6353836?v=3","gravatar_id":"","url":"https://api.github.com/users/tn52","html_url":"https://github.com/tn52","followers_url":"https://api.github.com/users/tn52/followers","following_url":"https://api.github.com/users/tn52/following{/other_user}","gists_url":"https://api.github.com/users/tn52/gists{/gist_id}","starred_url":"https://api.github.com/users/tn52/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tn52/subscriptions","organizations_url":"https://api.github.com/users/tn52/orgs","repos_url":"https://api.github.com/users/tn52/repos","events_url":"https://api.github.com/users/tn52/events{/privacy}","received_events_url":"https://api.github.com/users/tn52/received_events","type":"User","site_admin":false},"repo":{"id":67945398,"name":"TicTacToe","full_name":"tn52/TicTacToe","owner":{"login":"tn52","id":6353836,"avatar_url":"https://avatars.githubusercontent.com/u/6353836?v=3","gravatar_id":"","url":"https://api.github.com/users/tn52","html_url":"https://github.com/tn52","followers_url":"https://api.github.com/users/tn52/followers","following_url":"https://api.github.com/users/tn52/following{/other_user}","gists_url":"https://api.github.com/users/tn52/gists{/gist_id}","starred_url":"https://api.github.com/users/tn52/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tn52/subscriptions","organizations_url":"https://api.github.com/users/tn52/orgs","repos_url":"https://api.github.com/users/tn52/repos","events_url":"https://api.github.com/users/tn52/events{/privacy}","received_events_url":"https://api.github.com/users/tn52/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tn52/TicTacToe","description":null,"fork":true,"url":"https://api.github.com/repos/tn52/TicTacToe","forks_url":"https://api.github.com/repos/tn52/TicTacToe/forks","keys_url":"https://api.github.com/repos/tn52/TicTacToe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tn52/TicTacToe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tn52/TicTacToe/teams","hooks_url":"https://api.github.com/repos/tn52/TicTacToe/hooks","issue_events_url":"https://api.github.com/repos/tn52/TicTacToe/issues/events{/number}","events_url":"https://api.github.com/repos/tn52/TicTacToe/events","assignees_url":"https://api.github.com/repos/tn52/TicTacToe/assignees{/user}","branches_url":"https://api.github.com/repos/tn52/TicTacToe/branches{/branch}","tags_url":"https://api.github.com/repos/tn52/TicTacToe/tags","blobs_url":"https://api.github.com/repos/tn52/TicTacToe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tn52/TicTacToe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tn52/TicTacToe/git/refs{/sha}","trees_url":"https://api.github.com/repos/tn52/TicTacToe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tn52/TicTacToe/statuses/{sha}","languages_url":"https://api.github.com/repos/tn52/TicTacToe/languages","stargazers_url":"https://api.github.com/repos/tn52/TicTacToe/stargazers","contributors_url":"https://api.github.com/repos/tn52/TicTacToe/contributors","subscribers_url":"https://api.github.com/repos/tn52/TicTacToe/subscribers","subscription_url":"https://api.github.com/repos/tn52/TicTacToe/subscription","commits_url":"https://api.github.com/repos/tn52/TicTacToe/commits{/sha}","git_commits_url":"https://api.github.com/repos/tn52/TicTacToe/git/commits{/sha}","comments_url":"https://api.github.com/repos/tn52/TicTacToe/comments{/number}","issue_comment_url":"https://api.github.com/repos/tn52/TicTacToe/issues/comments{/number}","contents_url":"https://api.github.com/repos/tn52/TicTacToe/contents/{+path}","compare_url":"https://api.github.com/repos/tn52/TicTacToe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tn52/TicTacToe/merges","archive_url":"https://api.github.com/repos/tn52/TicTacToe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tn52/TicTacToe/downloads","issues_url":"https://api.github.com/repos/tn52/TicTacToe/issues{/number}","pulls_url":"https://api.github.com/repos/tn52/TicTacToe/pulls{/number}","milestones_url":"https://api.github.com/repos/tn52/TicTacToe/milestones{/number}","notifications_url":"https://api.github.com/repos/tn52/TicTacToe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tn52/TicTacToe/labels{/name}","releases_url":"https://api.github.com/repos/tn52/TicTacToe/releases{/id}","deployments_url":"https://api.github.com/repos/tn52/TicTacToe/deployments","created_at":"2016-09-11T17:58:20Z","updated_at":"2016-09-11T17:58:21Z","pushed_at":"2016-09-11T18:20:51Z","git_url":"git://github.com/tn52/TicTacToe.git","ssh_url":"git@github.com:tn52/TicTacToe.git","clone_url":"https://github.com/tn52/TicTacToe.git","svn_url":"https://github.com/tn52/TicTacToe","homepage":null,"size":4,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tng016:master","ref":"master","sha":"61e56d842a866a9b3c71522915aca353be58aaa4","user":{"login":"tng016","id":22077775,"avatar_url":"https://avatars.githubusercontent.com/u/22077775?v=3","gravatar_id":"","url":"https://api.github.com/users/tng016","html_url":"https://github.com/tng016","followers_url":"https://api.github.com/users/tng016/followers","following_url":"https://api.github.com/users/tng016/following{/other_user}","gists_url":"https://api.github.com/users/tng016/gists{/gist_id}","starred_url":"https://api.github.com/users/tng016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tng016/subscriptions","organizations_url":"https://api.github.com/users/tng016/orgs","repos_url":"https://api.github.com/users/tng016/repos","events_url":"https://api.github.com/users/tng016/events{/privacy}","received_events_url":"https://api.github.com/users/tng016/received_events","type":"User","site_admin":false},"repo":{"id":67940969,"name":"TicTacToe","full_name":"tng016/TicTacToe","owner":{"login":"tng016","id":22077775,"avatar_url":"https://avatars.githubusercontent.com/u/22077775?v=3","gravatar_id":"","url":"https://api.github.com/users/tng016","html_url":"https://github.com/tng016","followers_url":"https://api.github.com/users/tng016/followers","following_url":"https://api.github.com/users/tng016/following{/other_user}","gists_url":"https://api.github.com/users/tng016/gists{/gist_id}","starred_url":"https://api.github.com/users/tng016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tng016/subscriptions","organizations_url":"https://api.github.com/users/tng016/orgs","repos_url":"https://api.github.com/users/tng016/repos","events_url":"https://api.github.com/users/tng016/events{/privacy}","received_events_url":"https://api.github.com/users/tng016/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tng016/TicTacToe","description":null,"fork":false,"url":"https://api.github.com/repos/tng016/TicTacToe","forks_url":"https://api.github.com/repos/tng016/TicTacToe/forks","keys_url":"https://api.github.com/repos/tng016/TicTacToe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tng016/TicTacToe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tng016/TicTacToe/teams","hooks_url":"https://api.github.com/repos/tng016/TicTacToe/hooks","issue_events_url":"https://api.github.com/repos/tng016/TicTacToe/issues/events{/number}","events_url":"https://api.github.com/repos/tng016/TicTacToe/events","assignees_url":"https://api.github.com/repos/tng016/TicTacToe/assignees{/user}","branches_url":"https://api.github.com/repos/tng016/TicTacToe/branches{/branch}","tags_url":"https://api.github.com/repos/tng016/TicTacToe/tags","blobs_url":"https://api.github.com/repos/tng016/TicTacToe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tng016/TicTacToe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tng016/TicTacToe/git/refs{/sha}","trees_url":"https://api.github.com/repos/tng016/TicTacToe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tng016/TicTacToe/statuses/{sha}","languages_url":"https://api.github.com/repos/tng016/TicTacToe/languages","stargazers_url":"https://api.github.com/repos/tng016/TicTacToe/stargazers","contributors_url":"https://api.github.com/repos/tng016/TicTacToe/contributors","subscribers_url":"https://api.github.com/repos/tng016/TicTacToe/subscribers","subscription_url":"https://api.github.com/repos/tng016/TicTacToe/subscription","commits_url":"https://api.github.com/repos/tng016/TicTacToe/commits{/sha}","git_commits_url":"https://api.github.com/repos/tng016/TicTacToe/git/commits{/sha}","comments_url":"https://api.github.com/repos/tng016/TicTacToe/comments{/number}","issue_comment_url":"https://api.github.com/repos/tng016/TicTacToe/issues/comments{/number}","contents_url":"https://api.github.com/repos/tng016/TicTacToe/contents/{+path}","compare_url":"https://api.github.com/repos/tng016/TicTacToe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tng016/TicTacToe/merges","archive_url":"https://api.github.com/repos/tng016/TicTacToe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tng016/TicTacToe/downloads","issues_url":"https://api.github.com/repos/tng016/TicTacToe/issues{/number}","pulls_url":"https://api.github.com/repos/tng016/TicTacToe/pulls{/number}","milestones_url":"https://api.github.com/repos/tng016/TicTacToe/milestones{/number}","notifications_url":"https://api.github.com/repos/tng016/TicTacToe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tng016/TicTacToe/labels{/name}","releases_url":"https://api.github.com/repos/tng016/TicTacToe/releases{/id}","deployments_url":"https://api.github.com/repos/tng016/TicTacToe/deployments","created_at":"2016-09-11T16:30:12Z","updated_at":"2016-09-11T16:31:40Z","pushed_at":"2016-09-11T18:27:06Z","git_url":"git://github.com/tng016/TicTacToe.git","ssh_url":"git@github.com:tng016/TicTacToe.git","clone_url":"https://github.com/tng016/TicTacToe.git","svn_url":"https://github.com/tng016/TicTacToe","homepage":null,"size":4,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tng016/TicTacToe/pulls/1"},"html":{"href":"https://github.com/tng016/TicTacToe/pull/1"},"issue":{"href":"https://api.github.com/repos/tng016/TicTacToe/issues/1"},"comments":{"href":"https://api.github.com/repos/tng016/TicTacToe/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/tng016/TicTacToe/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/tng016/TicTacToe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tng016/TicTacToe/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/tng016/TicTacToe/statuses/119b55f335ded2818afac291c87b8c14861a1613"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":15,"deletions":15,"changed_files":1}}
{"actor":{"display_login":"tn52"}}