{"action":"created","issue":{"url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/3048","repository_url":"https://api.github.com/repos/HabitRPG/habitrpg","labels_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/3048/labels{/name}","comments_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/3048/comments","events_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/3048/events","html_url":"https://github.com/HabitRPG/habitrpg/issues/3048","id":29146472,"number":3048,"title":"Critical hit rolled back","user":{"login":"SabreCat","id":4501321,"avatar_url":"https://avatars.githubusercontent.com/u/4501321?v=3","gravatar_id":"","url":"https://api.github.com/users/SabreCat","html_url":"https://github.com/SabreCat","followers_url":"https://api.github.com/users/SabreCat/followers","following_url":"https://api.github.com/users/SabreCat/following{/other_user}","gists_url":"https://api.github.com/users/SabreCat/gists{/gist_id}","starred_url":"https://api.github.com/users/SabreCat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SabreCat/subscriptions","organizations_url":"https://api.github.com/users/SabreCat/orgs","repos_url":"https://api.github.com/users/SabreCat/repos","events_url":"https://api.github.com/users/SabreCat/events{/privacy}","received_events_url":"https://api.github.com/users/SabreCat/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/HabitRPG/habitrpg/labels/bug","name":"bug","color":"e102d8"},{"url":"https://api.github.com/repos/HabitRPG/habitrpg/labels/need%20investigation","name":"need investigation","color":"eb6420"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2014-03-11T01:03:58Z","updated_at":"2016-06-01T08:47:35Z","closed_at":"2016-06-01T08:47:34Z","body":"Today I scored a critical hit, got the notification and the extra Experience and Gold... and then immediately thereafter got a notification of lost XP and Gold. I didn't react in time to screenshot it to be sure, but it seemed like I lost the crit bonus and kept the base value.\r\n\r\nI noticed that I also got a chat notif from my party during the sync from that click, and it turned out someone had cast Valorous Presence. Does the `_.reduce` of `user.stats` include buffs? In that case, it could be a `predictableRandom` issue: the server had my updated stats, which didn't roll a crit; the client had my pre-buff stats, which did. Server wins of course, so I got faked out.\r\n\r\n<bountysource-plugin>\r\n---\r\nWant to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/1437458-critical-hit-rolled-back?utm_campaign=plugin&utm_content=tracker%2F68393&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F68393&utm_medium=issues&utm_source=github).\r\n</bountysource-plugin>"},"comment":{"url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/comments/222931024","html_url":"https://github.com/HabitRPG/habitrpg/issues/3048#issuecomment-222931024","issue_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/3048","id":222931024,"user":{"login":"paglias","id":589911,"avatar_url":"https://avatars.githubusercontent.com/u/589911?v=3","gravatar_id":"","url":"https://api.github.com/users/paglias","html_url":"https://github.com/paglias","followers_url":"https://api.github.com/users/paglias/followers","following_url":"https://api.github.com/users/paglias/following{/other_user}","gists_url":"https://api.github.com/users/paglias/gists{/gist_id}","starred_url":"https://api.github.com/users/paglias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paglias/subscriptions","organizations_url":"https://api.github.com/users/paglias/orgs","repos_url":"https://api.github.com/users/paglias/repos","events_url":"https://api.github.com/users/paglias/events{/privacy}","received_events_url":"https://api.github.com/users/paglias/received_events","type":"User","site_admin":false},"created_at":"2016-06-01T08:47:34Z","updated_at":"2016-06-01T08:47:34Z","body":"Critical hits are handled on the server now"}}
{"actor":{"display_login":"paglias"}}