{"action":"created","comment":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments/71702050","id":71702050,"diff_hunk":"@@ -486,33 +476,15 @@ public boolean isQuestionFullyAnsweredByTeam(FeedbackQuestionAttributes question\n     \n     \n     /**\n-     * Updates the feedback question number, shifts other questions up/down\n+     * Updates the feedback question, including propagating question number update,\n+     * shifts other questions up/down\n      * depending on the change.\n+     * @throws EntityAlreadyExistsException\n      */\n-    public void updateFeedbackQuestionNumber(FeedbackQuestionAttributes newQuestion)\n-        throws InvalidParametersException, EntityDoesNotExistException {\n-        \n-        FeedbackQuestionAttributes oldQuestion =\n-                fqDb.getFeedbackQuestion(newQuestion.getId());\n-\n-        if (oldQuestion == null) {\n-            throw new EntityDoesNotExistException(\"Trying to update a feedback question that does not exist.\");\n-        }\n+    public void updateFeedbackQuestionWithQuestionNumberUpdate(FeedbackQuestionAttributes newQuestion)\n+        throws InvalidParametersException, EntityDoesNotExistException, EntityAlreadyExistsException {","path":"src/main/java/teammates/logic/core/FeedbackQuestionsLogic.java","position":107,"original_position":107,"commit_id":"8df57ee5437a885b8015fe6163d258390149fba5","original_commit_id":"8df57ee5437a885b8015fe6163d258390149fba5","user":{"login":"JosephineKwa","id":9999077,"avatar_url":"https://avatars.githubusercontent.com/u/9999077?v=3","gravatar_id":"","url":"https://api.github.com/users/JosephineKwa","html_url":"https://github.com/JosephineKwa","followers_url":"https://api.github.com/users/JosephineKwa/followers","following_url":"https://api.github.com/users/JosephineKwa/following{/other_user}","gists_url":"https://api.github.com/users/JosephineKwa/gists{/gist_id}","starred_url":"https://api.github.com/users/JosephineKwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosephineKwa/subscriptions","organizations_url":"https://api.github.com/users/JosephineKwa/orgs","repos_url":"https://api.github.com/users/JosephineKwa/repos","events_url":"https://api.github.com/users/JosephineKwa/events{/privacy}","received_events_url":"https://api.github.com/users/JosephineKwa/received_events","type":"User","site_admin":false},"body":"add 4 more spaces before `throws`","created_at":"2016-07-21T13:14:10Z","updated_at":"2016-07-21T13:14:10Z","html_url":"https://github.com/TEAMMATES/teammates/pull/5842#discussion_r71702050","pull_request_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/5842","_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments/71702050"},"html":{"href":"https://github.com/TEAMMATES/teammates/pull/5842#discussion_r71702050"},"pull_request":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/5842"}}},"pull_request":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/5842","id":77400976,"html_url":"https://github.com/TEAMMATES/teammates/pull/5842","diff_url":"https://github.com/TEAMMATES/teammates/pull/5842.diff","patch_url":"https://github.com/TEAMMATES/teammates/pull/5842.patch","issue_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/5842","number":5842,"state":"open","locked":false,"title":"New Question entity #5839","user":{"login":"kanghj","id":2216119,"avatar_url":"https://avatars.githubusercontent.com/u/2216119?v=3","gravatar_id":"","url":"https://api.github.com/users/kanghj","html_url":"https://github.com/kanghj","followers_url":"https://api.github.com/users/kanghj/followers","following_url":"https://api.github.com/users/kanghj/following{/other_user}","gists_url":"https://api.github.com/users/kanghj/gists{/gist_id}","starred_url":"https://api.github.com/users/kanghj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanghj/subscriptions","organizations_url":"https://api.github.com/users/kanghj/orgs","repos_url":"https://api.github.com/users/kanghj/repos","events_url":"https://api.github.com/users/kanghj/events{/privacy}","received_events_url":"https://api.github.com/users/kanghj/received_events","type":"User","site_admin":false},"body":"Fixes #5839. ~~Ongoing~~, ~~waiting on #5836~~\r\n\r\nEdit: ~~still ongoing~~","created_at":"2016-07-14T05:17:32Z","updated_at":"2016-07-21T13:14:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b075dfa260b735cdf1ad89c1f85e9799fc3bbb15","assignee":{"login":"JosephineKwa","id":9999077,"avatar_url":"https://avatars.githubusercontent.com/u/9999077?v=3","gravatar_id":"","url":"https://api.github.com/users/JosephineKwa","html_url":"https://github.com/JosephineKwa","followers_url":"https://api.github.com/users/JosephineKwa/followers","following_url":"https://api.github.com/users/JosephineKwa/following{/other_user}","gists_url":"https://api.github.com/users/JosephineKwa/gists{/gist_id}","starred_url":"https://api.github.com/users/JosephineKwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosephineKwa/subscriptions","organizations_url":"https://api.github.com/users/JosephineKwa/orgs","repos_url":"https://api.github.com/users/JosephineKwa/repos","events_url":"https://api.github.com/users/JosephineKwa/events{/privacy}","received_events_url":"https://api.github.com/users/JosephineKwa/received_events","type":"User","site_admin":false},"assignees":[{"login":"JosephineKwa","id":9999077,"avatar_url":"https://avatars.githubusercontent.com/u/9999077?v=3","gravatar_id":"","url":"https://api.github.com/users/JosephineKwa","html_url":"https://github.com/JosephineKwa","followers_url":"https://api.github.com/users/JosephineKwa/followers","following_url":"https://api.github.com/users/JosephineKwa/following{/other_user}","gists_url":"https://api.github.com/users/JosephineKwa/gists{/gist_id}","starred_url":"https://api.github.com/users/JosephineKwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosephineKwa/subscriptions","organizations_url":"https://api.github.com/users/JosephineKwa/orgs","repos_url":"https://api.github.com/users/JosephineKwa/repos","events_url":"https://api.github.com/users/JosephineKwa/events{/privacy}","received_events_url":"https://api.github.com/users/JosephineKwa/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/5842/commits","review_comments_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/5842/comments","review_comment_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/5842/comments","statuses_url":"https://api.github.com/repos/TEAMMATES/teammates/statuses/8df57ee5437a885b8015fe6163d258390149fba5","head":{"label":"TEAMMATES:5839-question-entity","ref":"5839-question-entity","sha":"8df57ee5437a885b8015fe6163d258390149fba5","user":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars.githubusercontent.com/u/7374810?v=3","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"repo":{"id":19369035,"name":"teammates","full_name":"TEAMMATES/teammates","owner":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars.githubusercontent.com/u/7374810?v=3","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TEAMMATES/teammates","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":false,"url":"https://api.github.com/repos/TEAMMATES/teammates","forks_url":"https://api.github.com/repos/TEAMMATES/teammates/forks","keys_url":"https://api.github.com/repos/TEAMMATES/teammates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TEAMMATES/teammates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TEAMMATES/teammates/teams","hooks_url":"https://api.github.com/repos/TEAMMATES/teammates/hooks","issue_events_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/events{/number}","events_url":"https://api.github.com/repos/TEAMMATES/teammates/events","assignees_url":"https://api.github.com/repos/TEAMMATES/teammates/assignees{/user}","branches_url":"https://api.github.com/repos/TEAMMATES/teammates/branches{/branch}","tags_url":"https://api.github.com/repos/TEAMMATES/teammates/tags","blobs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TEAMMATES/teammates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/refs{/sha}","trees_url":"https://api.github.com/repos/TEAMMATES/teammates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TEAMMATES/teammates/statuses/{sha}","languages_url":"https://api.github.com/repos/TEAMMATES/teammates/languages","stargazers_url":"https://api.github.com/repos/TEAMMATES/teammates/stargazers","contributors_url":"https://api.github.com/repos/TEAMMATES/teammates/contributors","subscribers_url":"https://api.github.com/repos/TEAMMATES/teammates/subscribers","subscription_url":"https://api.github.com/repos/TEAMMATES/teammates/subscription","commits_url":"https://api.github.com/repos/TEAMMATES/teammates/commits{/sha}","git_commits_url":"https://api.github.com/repos/TEAMMATES/teammates/git/commits{/sha}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/comments{/number}","issue_comment_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/comments{/number}","contents_url":"https://api.github.com/repos/TEAMMATES/teammates/contents/{+path}","compare_url":"https://api.github.com/repos/TEAMMATES/teammates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TEAMMATES/teammates/merges","archive_url":"https://api.github.com/repos/TEAMMATES/teammates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TEAMMATES/teammates/downloads","issues_url":"https://api.github.com/repos/TEAMMATES/teammates/issues{/number}","pulls_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls{/number}","milestones_url":"https://api.github.com/repos/TEAMMATES/teammates/milestones{/number}","notifications_url":"https://api.github.com/repos/TEAMMATES/teammates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TEAMMATES/teammates/labels{/name}","releases_url":"https://api.github.com/repos/TEAMMATES/teammates/releases{/id}","deployments_url":"https://api.github.com/repos/TEAMMATES/teammates/deployments","created_at":"2014-05-02T07:43:00Z","updated_at":"2016-07-20T19:59:31Z","pushed_at":"2016-07-21T12:45:31Z","git_url":"git://github.com/TEAMMATES/teammates.git","ssh_url":"git@github.com:TEAMMATES/teammates.git","clone_url":"https://github.com/TEAMMATES/teammates.git","svn_url":"https://github.com/TEAMMATES/teammates","homepage":"http://teammatesv4.appspot.com/","size":192541,"stargazers_count":103,"watchers_count":103,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":273,"mirror_url":null,"open_issues_count":491,"forks":273,"open_issues":491,"watchers":103,"default_branch":"master"}},"base":{"label":"TEAMMATES:master","ref":"master","sha":"67fb7ad41a76c7f039101d23f7051ed03e8566bc","user":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars.githubusercontent.com/u/7374810?v=3","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"repo":{"id":19369035,"name":"teammates","full_name":"TEAMMATES/teammates","owner":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars.githubusercontent.com/u/7374810?v=3","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TEAMMATES/teammates","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":false,"url":"https://api.github.com/repos/TEAMMATES/teammates","forks_url":"https://api.github.com/repos/TEAMMATES/teammates/forks","keys_url":"https://api.github.com/repos/TEAMMATES/teammates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TEAMMATES/teammates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TEAMMATES/teammates/teams","hooks_url":"https://api.github.com/repos/TEAMMATES/teammates/hooks","issue_events_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/events{/number}","events_url":"https://api.github.com/repos/TEAMMATES/teammates/events","assignees_url":"https://api.github.com/repos/TEAMMATES/teammates/assignees{/user}","branches_url":"https://api.github.com/repos/TEAMMATES/teammates/branches{/branch}","tags_url":"https://api.github.com/repos/TEAMMATES/teammates/tags","blobs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TEAMMATES/teammates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/refs{/sha}","trees_url":"https://api.github.com/repos/TEAMMATES/teammates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TEAMMATES/teammates/statuses/{sha}","languages_url":"https://api.github.com/repos/TEAMMATES/teammates/languages","stargazers_url":"https://api.github.com/repos/TEAMMATES/teammates/stargazers","contributors_url":"https://api.github.com/repos/TEAMMATES/teammates/contributors","subscribers_url":"https://api.github.com/repos/TEAMMATES/teammates/subscribers","subscription_url":"https://api.github.com/repos/TEAMMATES/teammates/subscription","commits_url":"https://api.github.com/repos/TEAMMATES/teammates/commits{/sha}","git_commits_url":"https://api.github.com/repos/TEAMMATES/teammates/git/commits{/sha}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/comments{/number}","issue_comment_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/comments{/number}","contents_url":"https://api.github.com/repos/TEAMMATES/teammates/contents/{+path}","compare_url":"https://api.github.com/repos/TEAMMATES/teammates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TEAMMATES/teammates/merges","archive_url":"https://api.github.com/repos/TEAMMATES/teammates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TEAMMATES/teammates/downloads","issues_url":"https://api.github.com/repos/TEAMMATES/teammates/issues{/number}","pulls_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls{/number}","milestones_url":"https://api.github.com/repos/TEAMMATES/teammates/milestones{/number}","notifications_url":"https://api.github.com/repos/TEAMMATES/teammates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TEAMMATES/teammates/labels{/name}","releases_url":"https://api.github.com/repos/TEAMMATES/teammates/releases{/id}","deployments_url":"https://api.github.com/repos/TEAMMATES/teammates/deployments","created_at":"2014-05-02T07:43:00Z","updated_at":"2016-07-20T19:59:31Z","pushed_at":"2016-07-21T12:45:31Z","git_url":"git://github.com/TEAMMATES/teammates.git","ssh_url":"git@github.com:TEAMMATES/teammates.git","clone_url":"https://github.com/TEAMMATES/teammates.git","svn_url":"https://github.com/TEAMMATES/teammates","homepage":"http://teammatesv4.appspot.com/","size":192541,"stargazers_count":103,"watchers_count":103,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":273,"mirror_url":null,"open_issues_count":491,"forks":273,"open_issues":491,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/5842"},"html":{"href":"https://github.com/TEAMMATES/teammates/pull/5842"},"issue":{"href":"https://api.github.com/repos/TEAMMATES/teammates/issues/5842"},"comments":{"href":"https://api.github.com/repos/TEAMMATES/teammates/issues/5842/comments"},"review_comments":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/5842/comments"},"review_comment":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/5842/commits"},"statuses":{"href":"https://api.github.com/repos/TEAMMATES/teammates/statuses/8df57ee5437a885b8015fe6163d258390149fba5"}}}}
{"actor":{"display_login":"JosephineKwa"}}