{"action":"closed","number":8746,"pull_request":{"url":"https://api.github.com/repos/zurb/foundation-sites/pulls/8746","id":69078630,"html_url":"https://github.com/zurb/foundation-sites/pull/8746","diff_url":"https://github.com/zurb/foundation-sites/pull/8746.diff","patch_url":"https://github.com/zurb/foundation-sites/pull/8746.patch","issue_url":"https://api.github.com/repos/zurb/foundation-sites/issues/8746","number":8746,"state":"closed","locked":false,"title":"prevent cb() from fire multiple as move is called until animation fin…","user":{"login":"designerno1","id":8417506,"avatar_url":"https://avatars.githubusercontent.com/u/8417506?v=3","gravatar_id":"","url":"https://api.github.com/users/designerno1","html_url":"https://github.com/designerno1","followers_url":"https://api.github.com/users/designerno1/followers","following_url":"https://api.github.com/users/designerno1/following{/other_user}","gists_url":"https://api.github.com/users/designerno1/gists{/gist_id}","starred_url":"https://api.github.com/users/designerno1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/designerno1/subscriptions","organizations_url":"https://api.github.com/users/designerno1/orgs","repos_url":"https://api.github.com/users/designerno1/repos","events_url":"https://api.github.com/users/designerno1/events{/privacy}","received_events_url":"https://api.github.com/users/designerno1/received_events","type":"User","site_admin":false},"body":"fixes #8724 \r\n@kball \r\nwould you please take a look at the JS\r\n```js\r\nFoundation.Move(this.options.slideSpeed, $target, function(){\r\n      $target.slideUp(_this.options.slideSpeed, function () {\r\n```\r\nin the old version of Foundation.Move the `fn.apply(elem);` gets called until the anim finishes, but in the fn. `slideDown` `slideUp` is called so the slidedown and slideup gets called in a 250 duration about 11 times, so the callback specified in the slideDown/slideUp also fires 11 times\r\n\r\nso i wrapped the fn.apply in the !start if, to only call it once the animationframe is requested.\r\nAs i don't know what `requestAnimationFrame` is about and exactly how it works i don't know if thats the right way as maybe if the animationFrame is queued the slideDown ever fires.","created_at":"2016-05-05T22:08:53Z","updated_at":"2016-05-05T23:12:47Z","closed_at":"2016-05-05T23:12:47Z","merged_at":null,"merge_commit_sha":"f918f6139de501e3a44a3d6bd07fc06a90eab1cc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zurb/foundation-sites/pulls/8746/commits","review_comments_url":"https://api.github.com/repos/zurb/foundation-sites/pulls/8746/comments","review_comment_url":"https://api.github.com/repos/zurb/foundation-sites/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zurb/foundation-sites/issues/8746/comments","statuses_url":"https://api.github.com/repos/zurb/foundation-sites/statuses/59861535caea0bb923d7c6f2d4631dbaecac7311","head":{"label":"designerno1:motion-cb-fix","ref":"motion-cb-fix","sha":"59861535caea0bb923d7c6f2d4631dbaecac7311","user":{"login":"designerno1","id":8417506,"avatar_url":"https://avatars.githubusercontent.com/u/8417506?v=3","gravatar_id":"","url":"https://api.github.com/users/designerno1","html_url":"https://github.com/designerno1","followers_url":"https://api.github.com/users/designerno1/followers","following_url":"https://api.github.com/users/designerno1/following{/other_user}","gists_url":"https://api.github.com/users/designerno1/gists{/gist_id}","starred_url":"https://api.github.com/users/designerno1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/designerno1/subscriptions","organizations_url":"https://api.github.com/users/designerno1/orgs","repos_url":"https://api.github.com/users/designerno1/repos","events_url":"https://api.github.com/users/designerno1/events{/privacy}","received_events_url":"https://api.github.com/users/designerno1/received_events","type":"User","site_admin":false},"repo":{"id":47497584,"name":"foundation-sites","full_name":"designerno1/foundation-sites","owner":{"login":"designerno1","id":8417506,"avatar_url":"https://avatars.githubusercontent.com/u/8417506?v=3","gravatar_id":"","url":"https://api.github.com/users/designerno1","html_url":"https://github.com/designerno1","followers_url":"https://api.github.com/users/designerno1/followers","following_url":"https://api.github.com/users/designerno1/following{/other_user}","gists_url":"https://api.github.com/users/designerno1/gists{/gist_id}","starred_url":"https://api.github.com/users/designerno1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/designerno1/subscriptions","organizations_url":"https://api.github.com/users/designerno1/orgs","repos_url":"https://api.github.com/users/designerno1/repos","events_url":"https://api.github.com/users/designerno1/events{/privacy}","received_events_url":"https://api.github.com/users/designerno1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/designerno1/foundation-sites","description":"The most advanced responsive front-end framework in the world. Quickly create prototypes and production code for sites that work on any kind of device.","fork":true,"url":"https://api.github.com/repos/designerno1/foundation-sites","forks_url":"https://api.github.com/repos/designerno1/foundation-sites/forks","keys_url":"https://api.github.com/repos/designerno1/foundation-sites/keys{/key_id}","collaborators_url":"https://api.github.com/repos/designerno1/foundation-sites/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/designerno1/foundation-sites/teams","hooks_url":"https://api.github.com/repos/designerno1/foundation-sites/hooks","issue_events_url":"https://api.github.com/repos/designerno1/foundation-sites/issues/events{/number}","events_url":"https://api.github.com/repos/designerno1/foundation-sites/events","assignees_url":"https://api.github.com/repos/designerno1/foundation-sites/assignees{/user}","branches_url":"https://api.github.com/repos/designerno1/foundation-sites/branches{/branch}","tags_url":"https://api.github.com/repos/designerno1/foundation-sites/tags","blobs_url":"https://api.github.com/repos/designerno1/foundation-sites/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/designerno1/foundation-sites/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/designerno1/foundation-sites/git/refs{/sha}","trees_url":"https://api.github.com/repos/designerno1/foundation-sites/git/trees{/sha}","statuses_url":"https://api.github.com/repos/designerno1/foundation-sites/statuses/{sha}","languages_url":"https://api.github.com/repos/designerno1/foundation-sites/languages","stargazers_url":"https://api.github.com/repos/designerno1/foundation-sites/stargazers","contributors_url":"https://api.github.com/repos/designerno1/foundation-sites/contributors","subscribers_url":"https://api.github.com/repos/designerno1/foundation-sites/subscribers","subscription_url":"https://api.github.com/repos/designerno1/foundation-sites/subscription","commits_url":"https://api.github.com/repos/designerno1/foundation-sites/commits{/sha}","git_commits_url":"https://api.github.com/repos/designerno1/foundation-sites/git/commits{/sha}","comments_url":"https://api.github.com/repos/designerno1/foundation-sites/comments{/number}","issue_comment_url":"https://api.github.com/repos/designerno1/foundation-sites/issues/comments{/number}","contents_url":"https://api.github.com/repos/designerno1/foundation-sites/contents/{+path}","compare_url":"https://api.github.com/repos/designerno1/foundation-sites/compare/{base}...{head}","merges_url":"https://api.github.com/repos/designerno1/foundation-sites/merges","archive_url":"https://api.github.com/repos/designerno1/foundation-sites/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/designerno1/foundation-sites/downloads","issues_url":"https://api.github.com/repos/designerno1/foundation-sites/issues{/number}","pulls_url":"https://api.github.com/repos/designerno1/foundation-sites/pulls{/number}","milestones_url":"https://api.github.com/repos/designerno1/foundation-sites/milestones{/number}","notifications_url":"https://api.github.com/repos/designerno1/foundation-sites/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/designerno1/foundation-sites/labels{/name}","releases_url":"https://api.github.com/repos/designerno1/foundation-sites/releases{/id}","deployments_url":"https://api.github.com/repos/designerno1/foundation-sites/deployments","created_at":"2015-12-06T13:23:20Z","updated_at":"2016-04-20T23:47:51Z","pushed_at":"2016-05-05T23:12:28Z","git_url":"git://github.com/designerno1/foundation-sites.git","ssh_url":"git@github.com:designerno1/foundation-sites.git","clone_url":"https://github.com/designerno1/foundation-sites.git","svn_url":"https://github.com/designerno1/foundation-sites","homepage":"http://foundation.zurb.com","size":115679,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"zurb:develop","ref":"develop","sha":"b945d1cda30d47d5eb6e4d950475eb10d697d587","user":{"login":"zurb","id":156122,"avatar_url":"https://avatars.githubusercontent.com/u/156122?v=3","gravatar_id":"","url":"https://api.github.com/users/zurb","html_url":"https://github.com/zurb","followers_url":"https://api.github.com/users/zurb/followers","following_url":"https://api.github.com/users/zurb/following{/other_user}","gists_url":"https://api.github.com/users/zurb/gists{/gist_id}","starred_url":"https://api.github.com/users/zurb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zurb/subscriptions","organizations_url":"https://api.github.com/users/zurb/orgs","repos_url":"https://api.github.com/users/zurb/repos","events_url":"https://api.github.com/users/zurb/events{/privacy}","received_events_url":"https://api.github.com/users/zurb/received_events","type":"Organization","site_admin":false},"repo":{"id":2573058,"name":"foundation-sites","full_name":"zurb/foundation-sites","owner":{"login":"zurb","id":156122,"avatar_url":"https://avatars.githubusercontent.com/u/156122?v=3","gravatar_id":"","url":"https://api.github.com/users/zurb","html_url":"https://github.com/zurb","followers_url":"https://api.github.com/users/zurb/followers","following_url":"https://api.github.com/users/zurb/following{/other_user}","gists_url":"https://api.github.com/users/zurb/gists{/gist_id}","starred_url":"https://api.github.com/users/zurb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zurb/subscriptions","organizations_url":"https://api.github.com/users/zurb/orgs","repos_url":"https://api.github.com/users/zurb/repos","events_url":"https://api.github.com/users/zurb/events{/privacy}","received_events_url":"https://api.github.com/users/zurb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zurb/foundation-sites","description":"The most advanced responsive front-end framework in the world. Quickly create prototypes and production code for sites that work on any kind of device.","fork":false,"url":"https://api.github.com/repos/zurb/foundation-sites","forks_url":"https://api.github.com/repos/zurb/foundation-sites/forks","keys_url":"https://api.github.com/repos/zurb/foundation-sites/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zurb/foundation-sites/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zurb/foundation-sites/teams","hooks_url":"https://api.github.com/repos/zurb/foundation-sites/hooks","issue_events_url":"https://api.github.com/repos/zurb/foundation-sites/issues/events{/number}","events_url":"https://api.github.com/repos/zurb/foundation-sites/events","assignees_url":"https://api.github.com/repos/zurb/foundation-sites/assignees{/user}","branches_url":"https://api.github.com/repos/zurb/foundation-sites/branches{/branch}","tags_url":"https://api.github.com/repos/zurb/foundation-sites/tags","blobs_url":"https://api.github.com/repos/zurb/foundation-sites/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zurb/foundation-sites/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zurb/foundation-sites/git/refs{/sha}","trees_url":"https://api.github.com/repos/zurb/foundation-sites/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zurb/foundation-sites/statuses/{sha}","languages_url":"https://api.github.com/repos/zurb/foundation-sites/languages","stargazers_url":"https://api.github.com/repos/zurb/foundation-sites/stargazers","contributors_url":"https://api.github.com/repos/zurb/foundation-sites/contributors","subscribers_url":"https://api.github.com/repos/zurb/foundation-sites/subscribers","subscription_url":"https://api.github.com/repos/zurb/foundation-sites/subscription","commits_url":"https://api.github.com/repos/zurb/foundation-sites/commits{/sha}","git_commits_url":"https://api.github.com/repos/zurb/foundation-sites/git/commits{/sha}","comments_url":"https://api.github.com/repos/zurb/foundation-sites/comments{/number}","issue_comment_url":"https://api.github.com/repos/zurb/foundation-sites/issues/comments{/number}","contents_url":"https://api.github.com/repos/zurb/foundation-sites/contents/{+path}","compare_url":"https://api.github.com/repos/zurb/foundation-sites/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zurb/foundation-sites/merges","archive_url":"https://api.github.com/repos/zurb/foundation-sites/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zurb/foundation-sites/downloads","issues_url":"https://api.github.com/repos/zurb/foundation-sites/issues{/number}","pulls_url":"https://api.github.com/repos/zurb/foundation-sites/pulls{/number}","milestones_url":"https://api.github.com/repos/zurb/foundation-sites/milestones{/number}","notifications_url":"https://api.github.com/repos/zurb/foundation-sites/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zurb/foundation-sites/labels{/name}","releases_url":"https://api.github.com/repos/zurb/foundation-sites/releases{/id}","deployments_url":"https://api.github.com/repos/zurb/foundation-sites/deployments","created_at":"2011-10-13T23:05:42Z","updated_at":"2016-05-05T18:59:43Z","pushed_at":"2016-05-05T22:08:53Z","git_url":"git://github.com/zurb/foundation-sites.git","ssh_url":"git@github.com:zurb/foundation-sites.git","clone_url":"https://github.com/zurb/foundation-sites.git","svn_url":"https://github.com/zurb/foundation-sites","homepage":"http://foundation.zurb.com","size":135922,"stargazers_count":23243,"watchers_count":23243,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5037,"mirror_url":null,"open_issues_count":287,"forks":5037,"open_issues":287,"watchers":23243,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/zurb/foundation-sites/pulls/8746"},"html":{"href":"https://github.com/zurb/foundation-sites/pull/8746"},"issue":{"href":"https://api.github.com/repos/zurb/foundation-sites/issues/8746"},"comments":{"href":"https://api.github.com/repos/zurb/foundation-sites/issues/8746/comments"},"review_comments":{"href":"https://api.github.com/repos/zurb/foundation-sites/pulls/8746/comments"},"review_comment":{"href":"https://api.github.com/repos/zurb/foundation-sites/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zurb/foundation-sites/pulls/8746/commits"},"statuses":{"href":"https://api.github.com/repos/zurb/foundation-sites/statuses/59861535caea0bb923d7c6f2d4631dbaecac7311"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":4,"deletions":2,"changed_files":1}}