{"action":"created","issue":{"url":"https://api.github.com/repos/pearu/pylibnidaqmx/issues/66","repository_url":"https://api.github.com/repos/pearu/pylibnidaqmx","labels_url":"https://api.github.com/repos/pearu/pylibnidaqmx/issues/66/labels{/name}","comments_url":"https://api.github.com/repos/pearu/pylibnidaqmx/issues/66/comments","events_url":"https://api.github.com/repos/pearu/pylibnidaqmx/issues/66/events","html_url":"https://github.com/pearu/pylibnidaqmx/pull/66","id":164111171,"number":66,"title":"implement DAQmxWriteDigitalU32","user":{"login":"lorem-ipsum","id":1010629,"avatar_url":"https://avatars.githubusercontent.com/u/1010629?v=3","gravatar_id":"","url":"https://api.github.com/users/lorem-ipsum","html_url":"https://github.com/lorem-ipsum","followers_url":"https://api.github.com/users/lorem-ipsum/followers","following_url":"https://api.github.com/users/lorem-ipsum/following{/other_user}","gists_url":"https://api.github.com/users/lorem-ipsum/gists{/gist_id}","starred_url":"https://api.github.com/users/lorem-ipsum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorem-ipsum/subscriptions","organizations_url":"https://api.github.com/users/lorem-ipsum/orgs","repos_url":"https://api.github.com/users/lorem-ipsum/repos","events_url":"https://api.github.com/users/lorem-ipsum/events{/privacy}","received_events_url":"https://api.github.com/users/lorem-ipsum/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-06T15:56:25Z","updated_at":"2016-07-19T19:57:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pearu/pylibnidaqmx/pulls/66","html_url":"https://github.com/pearu/pylibnidaqmx/pull/66","diff_url":"https://github.com/pearu/pylibnidaqmx/pull/66.diff","patch_url":"https://github.com/pearu/pylibnidaqmx/pull/66.patch"},"body":"called the function write_32, beacuse I couldn't think of a better name.\r\n\r\nit is mostly a copy of the write function. If you have some better ideas on how to implement them (there are also U8 and U16) I'm happy to make changes"},"comment":{"url":"https://api.github.com/repos/pearu/pylibnidaqmx/issues/comments/233747291","html_url":"https://github.com/pearu/pylibnidaqmx/pull/66#issuecomment-233747291","issue_url":"https://api.github.com/repos/pearu/pylibnidaqmx/issues/66","id":233747291,"user":{"login":"hoechenberger","id":2046265,"avatar_url":"https://avatars.githubusercontent.com/u/2046265?v=3","gravatar_id":"","url":"https://api.github.com/users/hoechenberger","html_url":"https://github.com/hoechenberger","followers_url":"https://api.github.com/users/hoechenberger/followers","following_url":"https://api.github.com/users/hoechenberger/following{/other_user}","gists_url":"https://api.github.com/users/hoechenberger/gists{/gist_id}","starred_url":"https://api.github.com/users/hoechenberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoechenberger/subscriptions","organizations_url":"https://api.github.com/users/hoechenberger/orgs","repos_url":"https://api.github.com/users/hoechenberger/repos","events_url":"https://api.github.com/users/hoechenberger/events{/privacy}","received_events_url":"https://api.github.com/users/hoechenberger/received_events","type":"User","site_admin":false},"created_at":"2016-07-19T19:57:26Z","updated_at":"2016-07-19T19:57:26Z","body":"Hi @lorem-ipsum, thanks for the contribution! I would suggest the following backward-compatible API change to `DigitalOutputTask.write()`:\r\n\r\nCurrent API:\r\n```python\r\ndef write(self, data, \r\n          auto_start=True, timeout=10.0, \r\n          layout='group_by_channel'):\r\n```\r\n\r\nProposed API:\r\n```python\r\ndef write(self, data, \r\n          auto_start=True, timeout=10.0, \r\n          layout='group_by_channel',\r\n          write_type='channel',\r\n          dtype=np.uint8):\r\n```\r\n\r\nwith\r\n\r\n```python\r\nwrite_type : {'channel', 'port'}\r\n\r\n    `channel` writes to each digital line in the task.\r\n    `port` writes to the entire port.\r\n\r\ndtype : {np.uint8, np.uint16, np.uint32}\r\n\r\n    In case of `write_type='channel'`, `dtype` will always be set to `np.unit8`.\r\n\r\nNotes\r\n-----\r\n\r\nIn case of `write_type='channel'`, `DAQmxWriteDigitalLines()` will be called.\r\nIn case of `write_type='port'`, `DAQmxWriteDigitalUx()` will be called, with `x`\r\ndepending on the specified `dtype` (8, 16, 32).\r\n```\r\nWe could then\r\n* merge your suggestion into the existing `DigitalOutputTask.write()` method, and\r\n* easily add support for `DAQmxWriteDigitalU8()` and `DAQmxWriteDigitalU16` as well.\r\n\r\nDoes that make sense? Did I overlook something? :)"}}
{"actor":{"display_login":"hoechenberger"}}