{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/paas-cf/pulls/comments/68972696","id":68972696,"diff_hunk":"@@ -148,6 +148,7 @@ properties:\n     extra_headers_to_log:\n     debug_addr:\n     enable_routing_api:\n+    drain_wait: 15","path":"manifests/cf-manifest/manifest/020-cf-properties.yml","position":12,"original_position":4,"commit_id":"9292aae6d40b45aa9e2703b5eb297264ab8904fd","original_commit_id":"008b20512ffe44d1c58281d526dc007e31662f17","user":{"login":"keymon","id":280032,"avatar_url":"https://avatars.githubusercontent.com/u/280032?v=3","gravatar_id":"","url":"https://api.github.com/users/keymon","html_url":"https://github.com/keymon","followers_url":"https://api.github.com/users/keymon/followers","following_url":"https://api.github.com/users/keymon/following{/other_user}","gists_url":"https://api.github.com/users/keymon/gists{/gist_id}","starred_url":"https://api.github.com/users/keymon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keymon/subscriptions","organizations_url":"https://api.github.com/users/keymon/orgs","repos_url":"https://api.github.com/users/keymon/repos","events_url":"https://api.github.com/users/keymon/events{/privacy}","received_events_url":"https://api.github.com/users/keymon/received_events","type":"User","site_admin":false},"body":"Can you explain better in the commit message why this happens:\r\n\r\n> Set gorouter drain_wait to 15s \r\n>\r\n> With this setting the gorouter will keep serving to new connections for 15 seconds after getting the drain signal, but respond 500 error when the HTTPMonitor user agent is used. \r\n>\r\n> As the ELBs  healthcheck runs every 5 seconds and fails after 2 failures, and it will send the custom header (currently by using a custom frontent in haproxy). \r\n>\r\n> This way we ensure that we don't drop any incoming connection before the ELB marks the gorouter down.","created_at":"2016-06-29T15:47:12Z","updated_at":"2016-06-29T15:47:12Z","html_url":"https://github.com/alphagov/paas-cf/pull/341#discussion_r68972696","pull_request_url":"https://api.github.com/repos/alphagov/paas-cf/pulls/341","_links":{"self":{"href":"https://api.github.com/repos/alphagov/paas-cf/pulls/comments/68972696"},"html":{"href":"https://github.com/alphagov/paas-cf/pull/341#discussion_r68972696"},"pull_request":{"href":"https://api.github.com/repos/alphagov/paas-cf/pulls/341"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/paas-cf/pulls/341","id":75658548,"html_url":"https://github.com/alphagov/paas-cf/pull/341","diff_url":"https://github.com/alphagov/paas-cf/pull/341.diff","patch_url":"https://github.com/alphagov/paas-cf/pull/341.patch","issue_url":"https://api.github.com/repos/alphagov/paas-cf/issues/341","number":341,"state":"open","locked":false,"title":"[#121933113] Fix gorouter issue for zero downtime deploy","user":{"login":"combor","id":163394,"avatar_url":"https://avatars.githubusercontent.com/u/163394?v=3","gravatar_id":"","url":"https://api.github.com/users/combor","html_url":"https://github.com/combor","followers_url":"https://api.github.com/users/combor/followers","following_url":"https://api.github.com/users/combor/following{/other_user}","gists_url":"https://api.github.com/users/combor/gists{/gist_id}","starred_url":"https://api.github.com/users/combor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/combor/subscriptions","organizations_url":"https://api.github.com/users/combor/orgs","repos_url":"https://api.github.com/users/combor/repos","events_url":"https://api.github.com/users/combor/events{/privacy}","received_events_url":"https://api.github.com/users/combor/received_events","type":"User","site_admin":false},"body":"## What\r\nStory: https://www.pivotaltracker.com/story/show/121933113\r\n\r\nIt's a part of zero downtime deployment epic. \r\n\r\nThis PR implements custom healthcheck for haproxy to enable connection draining to make sure we don't server any errors during cf-deploy.\r\n\r\nAlso we split routing-release from main cf-release and use our fork to deliver gorouter fix for early exit when more than one signal is received. More details about that fix in routing-release PR: https://github.com/alphagov/paas-routing-release/pull/1\r\n\r\nAs a result of above listed changes we increase the availability test success rate threshold to 100% as we expect true zero downtime deployment now  \r\n\r\n## How to review\r\n\r\n- [ ] Review: https://github.com/alphagov/paas-haproxy-release/pull/3\r\n- [ ] Review: https://github.com/alphagov/paas-routing-release/pull/1\r\n- [ ] Run pipeline from `121933113_routers` branch, it will force full router update as it contains  https://github.com/alphagov/paas-cf/commit/9292aae6d40b45aa9e2703b5eb297264ab8904fd. Later you will remove it. Check if availability test passes.\r\n- [ ] Merge: https://github.com/alphagov/paas-haproxy-release/pull/3\r\n- [ ] Remove https://github.com/alphagov/paas-cf/blob/2937b4c8d0ff8612256503607c4393ac1f2de145/concourse/pipelines/create-bosh-cloudfoundry.yml#L89, put a new tag on `paas-haproxy` and update https://github.com/alphagov/paas-cf/blob/2937b4c8d0ff8612256503607c4393ac1f2de145/manifests/cf-manifest/manifest/000-base-cf-deployment.yml#L29\r\n- [ ] Remove https://github.com/alphagov/paas-cf/commit/2c2e606cd1c3641e47440edb7b258cc1a254a249 , put new tag on `routing-release` and update https://github.com/alphagov/paas-cf/blob/758e0b5eef87228e640f6a33fb79c69d1bb251f1/manifests/cf-manifest/manifest/000-base-cf-deployment.yml#L31\r\n- [ ] Remove https://github.com/alphagov/paas-cf/commit/9292aae6d40b45aa9e2703b5eb297264ab8904fd\r\n- [ ] Merge this PR\r\n\r\n## Who can review\r\n\r\nNot @saliceti , @timmow or @combor\r\n","created_at":"2016-06-29T14:30:42Z","updated_at":"2016-06-29T15:47:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8020553d20080e26df0526a7ecf6b9fbfee3a61b","assignee":{"login":"keymon","id":280032,"avatar_url":"https://avatars.githubusercontent.com/u/280032?v=3","gravatar_id":"","url":"https://api.github.com/users/keymon","html_url":"https://github.com/keymon","followers_url":"https://api.github.com/users/keymon/followers","following_url":"https://api.github.com/users/keymon/following{/other_user}","gists_url":"https://api.github.com/users/keymon/gists{/gist_id}","starred_url":"https://api.github.com/users/keymon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keymon/subscriptions","organizations_url":"https://api.github.com/users/keymon/orgs","repos_url":"https://api.github.com/users/keymon/repos","events_url":"https://api.github.com/users/keymon/events{/privacy}","received_events_url":"https://api.github.com/users/keymon/received_events","type":"User","site_admin":false},"assignees":[{"login":"keymon","id":280032,"avatar_url":"https://avatars.githubusercontent.com/u/280032?v=3","gravatar_id":"","url":"https://api.github.com/users/keymon","html_url":"https://github.com/keymon","followers_url":"https://api.github.com/users/keymon/followers","following_url":"https://api.github.com/users/keymon/following{/other_user}","gists_url":"https://api.github.com/users/keymon/gists{/gist_id}","starred_url":"https://api.github.com/users/keymon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keymon/subscriptions","organizations_url":"https://api.github.com/users/keymon/orgs","repos_url":"https://api.github.com/users/keymon/repos","events_url":"https://api.github.com/users/keymon/events{/privacy}","received_events_url":"https://api.github.com/users/keymon/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/paas-cf/pulls/341/commits","review_comments_url":"https://api.github.com/repos/alphagov/paas-cf/pulls/341/comments","review_comment_url":"https://api.github.com/repos/alphagov/paas-cf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/paas-cf/issues/341/comments","statuses_url":"https://api.github.com/repos/alphagov/paas-cf/statuses/9292aae6d40b45aa9e2703b5eb297264ab8904fd","head":{"label":"alphagov:121933113_routers","ref":"121933113_routers","sha":"9292aae6d40b45aa9e2703b5eb297264ab8904fd","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":46716359,"name":"paas-cf","full_name":"alphagov/paas-cf","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/paas-cf","description":"Government PaaS - Cloud Foundry","fork":false,"url":"https://api.github.com/repos/alphagov/paas-cf","forks_url":"https://api.github.com/repos/alphagov/paas-cf/forks","keys_url":"https://api.github.com/repos/alphagov/paas-cf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/paas-cf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/paas-cf/teams","hooks_url":"https://api.github.com/repos/alphagov/paas-cf/hooks","issue_events_url":"https://api.github.com/repos/alphagov/paas-cf/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/paas-cf/events","assignees_url":"https://api.github.com/repos/alphagov/paas-cf/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/paas-cf/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/paas-cf/tags","blobs_url":"https://api.github.com/repos/alphagov/paas-cf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/paas-cf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/paas-cf/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/paas-cf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/paas-cf/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/paas-cf/languages","stargazers_url":"https://api.github.com/repos/alphagov/paas-cf/stargazers","contributors_url":"https://api.github.com/repos/alphagov/paas-cf/contributors","subscribers_url":"https://api.github.com/repos/alphagov/paas-cf/subscribers","subscription_url":"https://api.github.com/repos/alphagov/paas-cf/subscription","commits_url":"https://api.github.com/repos/alphagov/paas-cf/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/paas-cf/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/paas-cf/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/paas-cf/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/paas-cf/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/paas-cf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/paas-cf/merges","archive_url":"https://api.github.com/repos/alphagov/paas-cf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/paas-cf/downloads","issues_url":"https://api.github.com/repos/alphagov/paas-cf/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/paas-cf/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/paas-cf/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/paas-cf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/paas-cf/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/paas-cf/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/paas-cf/deployments","created_at":"2015-11-23T11:36:57Z","updated_at":"2016-06-26T19:12:41Z","pushed_at":"2016-06-29T15:31:21Z","git_url":"git://github.com/alphagov/paas-cf.git","ssh_url":"git@github.com:alphagov/paas-cf.git","clone_url":"https://github.com/alphagov/paas-cf.git","svn_url":"https://github.com/alphagov/paas-cf","homepage":null,"size":14852,"stargazers_count":18,"watchers_count":18,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":18,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"edc35dde3e4465d610a927015244239b3ca14525","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":46716359,"name":"paas-cf","full_name":"alphagov/paas-cf","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/paas-cf","description":"Government PaaS - Cloud Foundry","fork":false,"url":"https://api.github.com/repos/alphagov/paas-cf","forks_url":"https://api.github.com/repos/alphagov/paas-cf/forks","keys_url":"https://api.github.com/repos/alphagov/paas-cf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/paas-cf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/paas-cf/teams","hooks_url":"https://api.github.com/repos/alphagov/paas-cf/hooks","issue_events_url":"https://api.github.com/repos/alphagov/paas-cf/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/paas-cf/events","assignees_url":"https://api.github.com/repos/alphagov/paas-cf/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/paas-cf/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/paas-cf/tags","blobs_url":"https://api.github.com/repos/alphagov/paas-cf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/paas-cf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/paas-cf/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/paas-cf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/paas-cf/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/paas-cf/languages","stargazers_url":"https://api.github.com/repos/alphagov/paas-cf/stargazers","contributors_url":"https://api.github.com/repos/alphagov/paas-cf/contributors","subscribers_url":"https://api.github.com/repos/alphagov/paas-cf/subscribers","subscription_url":"https://api.github.com/repos/alphagov/paas-cf/subscription","commits_url":"https://api.github.com/repos/alphagov/paas-cf/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/paas-cf/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/paas-cf/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/paas-cf/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/paas-cf/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/paas-cf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/paas-cf/merges","archive_url":"https://api.github.com/repos/alphagov/paas-cf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/paas-cf/downloads","issues_url":"https://api.github.com/repos/alphagov/paas-cf/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/paas-cf/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/paas-cf/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/paas-cf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/paas-cf/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/paas-cf/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/paas-cf/deployments","created_at":"2015-11-23T11:36:57Z","updated_at":"2016-06-26T19:12:41Z","pushed_at":"2016-06-29T15:31:21Z","git_url":"git://github.com/alphagov/paas-cf.git","ssh_url":"git@github.com:alphagov/paas-cf.git","clone_url":"https://github.com/alphagov/paas-cf.git","svn_url":"https://github.com/alphagov/paas-cf","homepage":null,"size":14852,"stargazers_count":18,"watchers_count":18,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/paas-cf/pulls/341"},"html":{"href":"https://github.com/alphagov/paas-cf/pull/341"},"issue":{"href":"https://api.github.com/repos/alphagov/paas-cf/issues/341"},"comments":{"href":"https://api.github.com/repos/alphagov/paas-cf/issues/341/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/paas-cf/pulls/341/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/paas-cf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/paas-cf/pulls/341/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/paas-cf/statuses/9292aae6d40b45aa9e2703b5eb297264ab8904fd"}}}}
{"actor":{"display_login":"keymon"}}