{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/uvisor/pulls/comments/54078684","id":54078684,"diff_hunk":"@@ -0,0 +1,60 @@\n+/*\n+ * Copyright 2016 Silicon Laboratories, Inc.\n+ * SPDX-License-Identifier: Apache-2.0\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may\n+ * not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT\n+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+#ifndef __CONFIGURATIONS_H__\n+#define __CONFIGURATIONS_H__\n+\n+/*******************************************************************************\n+ * Universal configurations\n+ ******************************************************************************/\n+\n+/* Memory boundaries */\n+#define FLASH_ORIGIN 0x00000000\n+\n+/* Memory boundaries */\n+#define SRAM_ORIGIN  0x20000000\n+#define SRAM_OFFSET  0x0\n+\n+/* Minimum memory requirements */\n+#define FLASH_LENGTH_MIN 0x10000  /* 64k */\n+#define SRAM_LENGTH_MIN  0x8000   /* 32k */\n+\n+/*******************************************************************************\n+ * Hardware-specific configurations\n+ *\n+ * Configurations are named after the parameter values, in this order:\n+ *   - CORE\n+ *   - PLATFORM\n+ ******************************************************************************/\n+#if defined(CONFIGURATION_EFM32_M3_P1)\n+    /* ARM core selection */\n+#   define CORE_CORTEX_M3","path":"platform/efm32/inc/configurations.h","position":44,"original_position":44,"commit_id":"cfc9911497c2b54abb45aaa23350cad88b61243a","original_commit_id":"cfc9911497c2b54abb45aaa23350cad88b61243a","user":{"login":"meriac","id":408576,"avatar_url":"https://avatars.githubusercontent.com/u/408576?v=3","gravatar_id":"","url":"https://api.github.com/users/meriac","html_url":"https://github.com/meriac","followers_url":"https://api.github.com/users/meriac/followers","following_url":"https://api.github.com/users/meriac/following{/other_user}","gists_url":"https://api.github.com/users/meriac/gists{/gist_id}","starred_url":"https://api.github.com/users/meriac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meriac/subscriptions","organizations_url":"https://api.github.com/users/meriac/orgs","repos_url":"https://api.github.com/users/meriac/repos","events_url":"https://api.github.com/users/meriac/events{/privacy}","received_events_url":"https://api.github.com/users/meriac/received_events","type":"User","site_admin":false},"body":"I would leave it as it is - it's probably more readable as its now.","created_at":"2016-02-25T10:55:52Z","updated_at":"2016-02-25T10:55:52Z","html_url":"https://github.com/ARMmbed/uvisor/pull/165#discussion_r54078684","pull_request_url":"https://api.github.com/repos/ARMmbed/uvisor/pulls/165","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/uvisor/pulls/comments/54078684"},"html":{"href":"https://github.com/ARMmbed/uvisor/pull/165#discussion_r54078684"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/uvisor/pulls/165"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/uvisor/pulls/165","id":60488359,"html_url":"https://github.com/ARMmbed/uvisor/pull/165","diff_url":"https://github.com/ARMmbed/uvisor/pull/165.diff","patch_url":"https://github.com/ARMmbed/uvisor/pull/165.patch","issue_url":"https://api.github.com/repos/ARMmbed/uvisor/issues/165","number":165,"state":"open","locked":false,"title":"Add support for EFM32 families","user":{"login":"akselsm","id":5024903,"avatar_url":"https://avatars.githubusercontent.com/u/5024903?v=3","gravatar_id":"","url":"https://api.github.com/users/akselsm","html_url":"https://github.com/akselsm","followers_url":"https://api.github.com/users/akselsm/followers","following_url":"https://api.github.com/users/akselsm/following{/other_user}","gists_url":"https://api.github.com/users/akselsm/gists{/gist_id}","starred_url":"https://api.github.com/users/akselsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akselsm/subscriptions","organizations_url":"https://api.github.com/users/akselsm/orgs","repos_url":"https://api.github.com/users/akselsm/repos","events_url":"https://api.github.com/users/akselsm/events{/privacy}","received_events_url":"https://api.github.com/users/akselsm/received_events","type":"User","site_admin":false},"body":"Add support for Giant Gecko, Leopard Gecko, Wonder Gecko, Jade Gecko and Pearl Gecko.\r\n\r\nThe published versions of cmsis-core-*, mbed-hal-* and target-efm32*-* in the yotta registry all have uvisor support, but the config parameter \"uvisor/present\" is currently set to false, in order for things not to break until support is merged and published in uvisor-lib. Will need to be overridden on the yotta build command line, or in config.json, in order to test before merge.","created_at":"2016-02-24T10:40:12Z","updated_at":"2016-02-25T10:55:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abe0e7f8ce30128dc36914204bf6a5721175220a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/uvisor/pulls/165/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/uvisor/pulls/165/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/uvisor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/uvisor/issues/165/comments","statuses_url":"https://api.github.com/repos/ARMmbed/uvisor/statuses/cfc9911497c2b54abb45aaa23350cad88b61243a","head":{"label":"akselsm:feature/efm32_support","ref":"feature/efm32_support","sha":"cfc9911497c2b54abb45aaa23350cad88b61243a","user":{"login":"akselsm","id":5024903,"avatar_url":"https://avatars.githubusercontent.com/u/5024903?v=3","gravatar_id":"","url":"https://api.github.com/users/akselsm","html_url":"https://github.com/akselsm","followers_url":"https://api.github.com/users/akselsm/followers","following_url":"https://api.github.com/users/akselsm/following{/other_user}","gists_url":"https://api.github.com/users/akselsm/gists{/gist_id}","starred_url":"https://api.github.com/users/akselsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akselsm/subscriptions","organizations_url":"https://api.github.com/users/akselsm/orgs","repos_url":"https://api.github.com/users/akselsm/repos","events_url":"https://api.github.com/users/akselsm/events{/privacy}","received_events_url":"https://api.github.com/users/akselsm/received_events","type":"User","site_admin":false},"repo":{"id":43811567,"name":"uvisor","full_name":"akselsm/uvisor","owner":{"login":"akselsm","id":5024903,"avatar_url":"https://avatars.githubusercontent.com/u/5024903?v=3","gravatar_id":"","url":"https://api.github.com/users/akselsm","html_url":"https://github.com/akselsm","followers_url":"https://api.github.com/users/akselsm/followers","following_url":"https://api.github.com/users/akselsm/following{/other_user}","gists_url":"https://api.github.com/users/akselsm/gists{/gist_id}","starred_url":"https://api.github.com/users/akselsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akselsm/subscriptions","organizations_url":"https://api.github.com/users/akselsm/orgs","repos_url":"https://api.github.com/users/akselsm/repos","events_url":"https://api.github.com/users/akselsm/events{/privacy}","received_events_url":"https://api.github.com/users/akselsm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akselsm/uvisor","description":"mbed OS uVisor -- device security layer for ARMv7M microcontrollers","fork":true,"url":"https://api.github.com/repos/akselsm/uvisor","forks_url":"https://api.github.com/repos/akselsm/uvisor/forks","keys_url":"https://api.github.com/repos/akselsm/uvisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akselsm/uvisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akselsm/uvisor/teams","hooks_url":"https://api.github.com/repos/akselsm/uvisor/hooks","issue_events_url":"https://api.github.com/repos/akselsm/uvisor/issues/events{/number}","events_url":"https://api.github.com/repos/akselsm/uvisor/events","assignees_url":"https://api.github.com/repos/akselsm/uvisor/assignees{/user}","branches_url":"https://api.github.com/repos/akselsm/uvisor/branches{/branch}","tags_url":"https://api.github.com/repos/akselsm/uvisor/tags","blobs_url":"https://api.github.com/repos/akselsm/uvisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akselsm/uvisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akselsm/uvisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/akselsm/uvisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akselsm/uvisor/statuses/{sha}","languages_url":"https://api.github.com/repos/akselsm/uvisor/languages","stargazers_url":"https://api.github.com/repos/akselsm/uvisor/stargazers","contributors_url":"https://api.github.com/repos/akselsm/uvisor/contributors","subscribers_url":"https://api.github.com/repos/akselsm/uvisor/subscribers","subscription_url":"https://api.github.com/repos/akselsm/uvisor/subscription","commits_url":"https://api.github.com/repos/akselsm/uvisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/akselsm/uvisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/akselsm/uvisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/akselsm/uvisor/issues/comments{/number}","contents_url":"https://api.github.com/repos/akselsm/uvisor/contents/{+path}","compare_url":"https://api.github.com/repos/akselsm/uvisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akselsm/uvisor/merges","archive_url":"https://api.github.com/repos/akselsm/uvisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akselsm/uvisor/downloads","issues_url":"https://api.github.com/repos/akselsm/uvisor/issues{/number}","pulls_url":"https://api.github.com/repos/akselsm/uvisor/pulls{/number}","milestones_url":"https://api.github.com/repos/akselsm/uvisor/milestones{/number}","notifications_url":"https://api.github.com/repos/akselsm/uvisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akselsm/uvisor/labels{/name}","releases_url":"https://api.github.com/repos/akselsm/uvisor/releases{/id}","deployments_url":"https://api.github.com/repos/akselsm/uvisor/deployments","created_at":"2015-10-07T11:39:30Z","updated_at":"2016-02-16T15:11:12Z","pushed_at":"2016-02-25T10:21:13Z","git_url":"git://github.com/akselsm/uvisor.git","ssh_url":"git@github.com:akselsm/uvisor.git","clone_url":"https://github.com/akselsm/uvisor.git","svn_url":"https://github.com/akselsm/uvisor","homepage":"","size":4109,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"825c26920115f721c9025acd4c748aff9716d419","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":27869517,"name":"uvisor","full_name":"ARMmbed/uvisor","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/uvisor","description":"mbed OS uVisor -- device security layer for ARMv7M microcontrollers","fork":false,"url":"https://api.github.com/repos/ARMmbed/uvisor","forks_url":"https://api.github.com/repos/ARMmbed/uvisor/forks","keys_url":"https://api.github.com/repos/ARMmbed/uvisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/uvisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/uvisor/teams","hooks_url":"https://api.github.com/repos/ARMmbed/uvisor/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/uvisor/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/uvisor/events","assignees_url":"https://api.github.com/repos/ARMmbed/uvisor/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/uvisor/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/uvisor/tags","blobs_url":"https://api.github.com/repos/ARMmbed/uvisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/uvisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/uvisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/uvisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/uvisor/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/uvisor/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/uvisor/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/uvisor/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/uvisor/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/uvisor/subscription","commits_url":"https://api.github.com/repos/ARMmbed/uvisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/uvisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/uvisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/uvisor/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/uvisor/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/uvisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/uvisor/merges","archive_url":"https://api.github.com/repos/ARMmbed/uvisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/uvisor/downloads","issues_url":"https://api.github.com/repos/ARMmbed/uvisor/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/uvisor/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/uvisor/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/uvisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/uvisor/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/uvisor/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/uvisor/deployments","created_at":"2014-12-11T11:59:50Z","updated_at":"2016-02-23T13:01:13Z","pushed_at":"2016-02-25T10:21:14Z","git_url":"git://github.com/ARMmbed/uvisor.git","ssh_url":"git@github.com:ARMmbed/uvisor.git","clone_url":"https://github.com/ARMmbed/uvisor.git","svn_url":"https://github.com/ARMmbed/uvisor","homepage":"","size":5235,"stargazers_count":50,"watchers_count":50,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":21,"forks":19,"open_issues":21,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/uvisor/pulls/165"},"html":{"href":"https://github.com/ARMmbed/uvisor/pull/165"},"issue":{"href":"https://api.github.com/repos/ARMmbed/uvisor/issues/165"},"comments":{"href":"https://api.github.com/repos/ARMmbed/uvisor/issues/165/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/uvisor/pulls/165/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/uvisor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/uvisor/pulls/165/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/uvisor/statuses/cfc9911497c2b54abb45aaa23350cad88b61243a"}}}}