{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6638","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6638/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6638/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6638/events","html_url":"https://github.com/cockroachdb/cockroach/pull/6638","id":154328211,"number":6638,"title":"ui next: Line Graph Component","user":{"login":"mrtracy","id":6969858,"avatar_url":"https://avatars.githubusercontent.com/u/6969858?v=3","gravatar_id":"","url":"https://api.github.com/users/mrtracy","html_url":"https://github.com/mrtracy","followers_url":"https://api.github.com/users/mrtracy/followers","following_url":"https://api.github.com/users/mrtracy/following{/other_user}","gists_url":"https://api.github.com/users/mrtracy/gists{/gist_id}","starred_url":"https://api.github.com/users/mrtracy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrtracy/subscriptions","organizations_url":"https://api.github.com/users/mrtracy/orgs","repos_url":"https://api.github.com/users/mrtracy/repos","events_url":"https://api.github.com/users/mrtracy/events{/privacy}","received_events_url":"https://api.github.com/users/mrtracy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"maxlang","id":3691886,"avatar_url":"https://avatars.githubusercontent.com/u/3691886?v=3","gravatar_id":"","url":"https://api.github.com/users/maxlang","html_url":"https://github.com/maxlang","followers_url":"https://api.github.com/users/maxlang/followers","following_url":"https://api.github.com/users/maxlang/following{/other_user}","gists_url":"https://api.github.com/users/maxlang/gists{/gist_id}","starred_url":"https://api.github.com/users/maxlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxlang/subscriptions","organizations_url":"https://api.github.com/users/maxlang/orgs","repos_url":"https://api.github.com/users/maxlang/repos","events_url":"https://api.github.com/users/maxlang/events{/privacy}","received_events_url":"https://api.github.com/users/maxlang/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2016-05-11T19:53:20Z","updated_at":"2016-05-12T17:41:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/6638","html_url":"https://github.com/cockroachdb/cockroach/pull/6638","diff_url":"https://github.com/cockroachdb/cockroach/pull/6638.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/6638.patch"},"body":"Commit adds the `LineGraph` component. This component is designed to be placed\r\ninside of a MetricsDataProvider component. Most of the NVD3 code has been taken\r\ndirectly from the previous UI, with some modifications to work with the new data\r\nmodel.\r\n\r\nCommit also changes the name of 'Selector' to 'Metric', to avoid confusion with\r\nthe Reselect library's selectors.\r\n\r\nCommit also adds a TODO list in app/app.tsx, cataloging the remaining\r\nunimplemented components and pages in the ui next project.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/6638)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/218831400","html_url":"https://github.com/cockroachdb/cockroach/pull/6638#issuecomment-218831400","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6638","id":218831400,"user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"created_at":"2016-05-12T17:41:11Z","updated_at":"2016-05-12T17:41:11Z","body":"\n\n\n\n\n\nReview status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.\n\n---\n\n*[ui/next/app/components/linegraph.tsx, line 12 \\[r1\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/6638#-KHWYLj8OYILLbhh5GTg:-KHa2L4YUwBwe9AsM2G7:-1912744063) ([raw file](https://github.com/cockroachdb/cockroach/blob/d7a9305b88e21c47625c9f45ec3f3f15410a4f12/ui/next/app/components/linegraph.tsx#L12)):*\n<details><summary><i>Previously, mrtracy wrote…</i></summary>\n> No, actually; the repeated property \"Results\" on a TSResponseMessage is of type Result, not ResultMessage.</details>\nAh, I see. Can the `let result: TSResult = this.props.data.results[idx];` below be written as `let result = this.props.data.results[idx];` without loss of type information?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/6638)*\n<!-- Sent from Reviewable.io -->\n"}}