{"action":"closed","issue":{"url":"https://api.github.com/repos/mpv-player/mpv/issues/3295","repository_url":"https://api.github.com/repos/mpv-player/mpv","labels_url":"https://api.github.com/repos/mpv-player/mpv/issues/3295/labels{/name}","comments_url":"https://api.github.com/repos/mpv-player/mpv/issues/3295/comments","events_url":"https://api.github.com/repos/mpv-player/mpv/issues/3295/events","html_url":"https://github.com/mpv-player/mpv/issues/3295","id":162998590,"number":3295,"title":"mpv accesses private fields from AVFrame struct directly","user":{"login":"jamrial","id":2442845,"avatar_url":"https://avatars.githubusercontent.com/u/2442845?v=3","gravatar_id":"","url":"https://api.github.com/users/jamrial","html_url":"https://github.com/jamrial","followers_url":"https://api.github.com/users/jamrial/followers","following_url":"https://api.github.com/users/jamrial/following{/other_user}","gists_url":"https://api.github.com/users/jamrial/gists{/gist_id}","starred_url":"https://api.github.com/users/jamrial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamrial/subscriptions","organizations_url":"https://api.github.com/users/jamrial/orgs","repos_url":"https://api.github.com/users/jamrial/repos","events_url":"https://api.github.com/users/jamrial/events{/privacy}","received_events_url":"https://api.github.com/users/jamrial/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mpv-player/mpv/labels/ffmpeg-bug","name":"ffmpeg-bug","color":"444444"},{"url":"https://api.github.com/repos/mpv-player/mpv/labels/wontfix","name":"wontfix","color":"e11d21"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-06-29T18:47:56Z","updated_at":"2016-06-29T18:59:19Z","closed_at":"2016-06-29T18:59:19Z","body":"git head commit e40851ea22e9686572b6a905161106f2a66e5983, https://github.com/mpv-player/mpv/blob/master/audio/audio.c#L351 and https://github.com/mpv-player/mpv/blob/master/audio/audio.c#L352 and https://github.com/mpv-player/mpv/blob/master/audio/audio.c#L414 should be using av_frame_get_channels(avframe) instead as stated in the field's doxy.\r\n\r\nThis apparently broke mpv audio playback as reported in https://trac.ffmpeg.org/ticket/5676 if you compile mpv using ffmpeg 3.0 shared libraries but use ffmpeg 3.1 shared libraries at runtime, since avframe->channels has a different offset (A new public field was added above it).\r\n\r\nI didn't check if there are other similar usage of fields marked as no direct access."}}
{"actor":{"display_login":"wm4"}}