{"action":"closed","number":9026,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/9026","id":71406958,"html_url":"https://github.com/openshift/origin/pull/9026","diff_url":"https://github.com/openshift/origin/pull/9026.diff","patch_url":"https://github.com/openshift/origin/pull/9026.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/9026","number":9026,"state":"closed","locked":false,"title":"Reconcile configs when their deployments are terminated","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"body":"Using a shared cache can obsolete this commit since we can identify in the\r\nupdate resource handler of the controller that the deployment was marked\r\nas complete/failed and requeue the deployment config without the need to\r\nannotate it. For now trigger a dc reconcilation on complete deployments too.\r\n\r\nNeeded for https://github.com/openshift/origin/pull/8691\r\n\r\nDeployment finishes -> deployer pod controller annotates the dc -> dc reconciled by the deploymentconfig controller -> cleaned up\r\n\r\n@stevekuznetsov @ironcladlou @mfojtik @smarterclayton \r\n\r\nI will factor this out once we have caches","created_at":"2016-05-25T14:58:37Z","updated_at":"2016-05-26T16:53:22Z","closed_at":"2016-05-26T16:53:22Z","merged_at":null,"merge_commit_sha":"18d8118f570ea21382496622654beb28e082ddd1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/9026/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/9026/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/9026/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/faa30cd3e0fae3637fd93f27d5cc05c5c109a3d8","head":{"label":"kargakis:reconcile-dcs-on-terminated-deployments","ref":"reconcile-dcs-on-terminated-deployments","sha":"faa30cd3e0fae3637fd93f27d5cc05c5c109a3d8","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"repo":{"id":29889288,"name":"origin","full_name":"kargakis/origin","owner":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kargakis/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/kargakis/origin","forks_url":"https://api.github.com/repos/kargakis/origin/forks","keys_url":"https://api.github.com/repos/kargakis/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kargakis/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kargakis/origin/teams","hooks_url":"https://api.github.com/repos/kargakis/origin/hooks","issue_events_url":"https://api.github.com/repos/kargakis/origin/issues/events{/number}","events_url":"https://api.github.com/repos/kargakis/origin/events","assignees_url":"https://api.github.com/repos/kargakis/origin/assignees{/user}","branches_url":"https://api.github.com/repos/kargakis/origin/branches{/branch}","tags_url":"https://api.github.com/repos/kargakis/origin/tags","blobs_url":"https://api.github.com/repos/kargakis/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kargakis/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kargakis/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/kargakis/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kargakis/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/kargakis/origin/languages","stargazers_url":"https://api.github.com/repos/kargakis/origin/stargazers","contributors_url":"https://api.github.com/repos/kargakis/origin/contributors","subscribers_url":"https://api.github.com/repos/kargakis/origin/subscribers","subscription_url":"https://api.github.com/repos/kargakis/origin/subscription","commits_url":"https://api.github.com/repos/kargakis/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/kargakis/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/kargakis/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/kargakis/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/kargakis/origin/contents/{+path}","compare_url":"https://api.github.com/repos/kargakis/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kargakis/origin/merges","archive_url":"https://api.github.com/repos/kargakis/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kargakis/origin/downloads","issues_url":"https://api.github.com/repos/kargakis/origin/issues{/number}","pulls_url":"https://api.github.com/repos/kargakis/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/kargakis/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/kargakis/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kargakis/origin/labels{/name}","releases_url":"https://api.github.com/repos/kargakis/origin/releases{/id}","deployments_url":"https://api.github.com/repos/kargakis/origin/deployments","created_at":"2015-01-27T00:24:14Z","updated_at":"2016-01-12T09:45:46Z","pushed_at":"2016-05-26T16:16:24Z","git_url":"git://github.com/kargakis/origin.git","ssh_url":"git@github.com:kargakis/origin.git","clone_url":"https://github.com/kargakis/origin.git","svn_url":"https://github.com/kargakis/origin","homepage":"https://openshift.github.io","size":264679,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"e65adfae2f38a9cd5ed54aeb0b93bebe8ced196f","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift - Build, deploy, and manage cloud-native and legacy applications with Kubernetes and Docker","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-05-25T20:04:28Z","pushed_at":"2016-05-26T16:37:41Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":509083,"stargazers_count":1320,"watchers_count":1320,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":793,"mirror_url":null,"open_issues_count":1010,"forks":793,"open_issues":1010,"watchers":1320,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/9026"},"html":{"href":"https://github.com/openshift/origin/pull/9026"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/9026"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/9026/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/9026/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/9026/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/faa30cd3e0fae3637fd93f27d5cc05c5c109a3d8"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":8,"deletions":5,"changed_files":2}}
{"actor":{"display_login":"kargakis"}}