{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/60929428","id":60929428,"diff_hunk":"@@ -1,20 +1,239 @@\n-.notifications-subscribe-link--has-subscriptions {\n+$live-notifications-icon-width: 36px;\n+$live-notifications-icon-width: 32px;\n+$notifications-button-height: 28px;\n+\n+@mixin notifcations-button-style($foreground: $neutral-2, $background: #ffffff) {\n+    .notifications__button {\n+        color: $foreground;\n+        border-color: $foreground;\n+        border-style: solid;\n+\n+        .inline-icon {\n+            fill: $foreground\n+        }\n+    }\n+\n+    .notifications__button--subscribed {\n+        color: $background;\n+        background-color: $foreground;\n+        .inline-icon {\n+            fill: $background;\n+            background-color: $foreground;\n+        }\n+\n+        &:hover {\n+            background-color: darken($foreground, 10%);\n+            .inline-icon {\n+                background-color: darken($foreground, 10%);\n+            }\n+        }\n+    }\n+\n+    .notifications__button--unsubscribed {\n+        color: $foreground;\n+        background-color: transparent;\n+        .inline-icon {\n+            fill: $foreground;\n+            background-color: $background;\n+        }\n+\n+        &:hover {\n+            background-color: darken($background, 10%);\n+            .inline-icon {\n+                background-color: darken($background, 10%);\n+            }\n+\n+        }\n+    }\n+}\n+\n+@mixin notifications-button-toned($tone, $foreground: $news-main-1, $background: #ffffff) {\n+    .tonal--tone-#{$tone} {\n+        @include notifcations-button-style($foreground, $background);\n+    }\n+}\n+\n+.live-notifications {\n+    margin-bottom: $gs-baseline /2;\n+    position: relative;\n+}\n+\n+.notifications__button {\n+\n+    .inline-icon {\n+        svg {\n+            width: 1.143em;\n+            height: .857em;\n+        }\n+    }\n+}\n+\n+.notifcations-follow-input--solo {\n+\n+    .submit-input__icon {\n+        display: inline-block;\n+        margin-right: $gs-gutter / 4;\n+    }\n+}\n+\n+.live-notifications__label {\n     display: none;\n }\n \n-.notifications-subscribe-link__headline {\n-    @include fs-header(3);\n-    margin: 0;\n+@each $state in (subscribed, unsubscribed) {\n+    .notifications__button--#{$state} {\n+        .live-notifications__label--#{$state} {\n+            display: inline;\n+        }\n+    }\n }\n \n-.notifications-link {\n-    margin-top: $gs-baseline;\n-    margin-bottom: $gs-baseline / 2;\n+@include notifcations-button-style();\n+@include notifications-button-toned(live, $live-default, $neutral-8);\n+@include notifications-button-toned(dead, $live-default, $neutral-8);\n+\n+.live-notifications-denied {\n+    position: fixed;\n+    display: block;\n+    top: .625rem;\n+    left: 5.275rem;\n+    width: 26.825rem;\n+    height: 4.7625rem;\n+    background: fade-out($live-default, 1 - .95);","path":"static/src/stylesheets/module/preferences/_notifications.scss","position":109,"original_position":109,"commit_id":"6f4b0e66c297ad778fa3be0bd47f1ac46793d229","original_commit_id":"6f4b0e66c297ad778fa3be0bd47f1ac46793d229","user":{"login":"gtrufitt","id":638051,"avatar_url":"https://avatars.githubusercontent.com/u/638051?v=3","gravatar_id":"","url":"https://api.github.com/users/gtrufitt","html_url":"https://github.com/gtrufitt","followers_url":"https://api.github.com/users/gtrufitt/followers","following_url":"https://api.github.com/users/gtrufitt/following{/other_user}","gists_url":"https://api.github.com/users/gtrufitt/gists{/gist_id}","starred_url":"https://api.github.com/users/gtrufitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtrufitt/subscriptions","organizations_url":"https://api.github.com/users/gtrufitt/orgs","repos_url":"https://api.github.com/users/gtrufitt/repos","events_url":"https://api.github.com/users/gtrufitt/events{/privacy}","received_events_url":"https://api.github.com/users/gtrufitt/received_events","type":"User","site_admin":false},"body":"Confused as to why `1 - .95` and not just `.05`? @sndrs I think this came from breaking-news, what was thinking of writing it like that?","created_at":"2016-04-25T15:08:40Z","updated_at":"2016-04-25T15:08:40Z","html_url":"https://github.com/guardian/frontend/pull/12661#discussion_r60929428","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/12661","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/60929428"},"html":{"href":"https://github.com/guardian/frontend/pull/12661#discussion_r60929428"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/12661"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/12661","id":67701512,"html_url":"https://github.com/guardian/frontend/pull/12661","diff_url":"https://github.com/guardian/frontend/pull/12661.diff","patch_url":"https://github.com/guardian/frontend/pull/12661.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/12661","number":12661,"state":"open","locked":false,"title":"Notifications ui redesign","user":{"login":"NathanielBennett","id":986155,"avatar_url":"https://avatars.githubusercontent.com/u/986155?v=3","gravatar_id":"","url":"https://api.github.com/users/NathanielBennett","html_url":"https://github.com/NathanielBennett","followers_url":"https://api.github.com/users/NathanielBennett/followers","following_url":"https://api.github.com/users/NathanielBennett/following{/other_user}","gists_url":"https://api.github.com/users/NathanielBennett/gists{/gist_id}","starred_url":"https://api.github.com/users/NathanielBennett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NathanielBennett/subscriptions","organizations_url":"https://api.github.com/users/NathanielBennett/orgs","repos_url":"https://api.github.com/users/NathanielBennett/repos","events_url":"https://api.github.com/users/NathanielBennett/events{/privacy}","received_events_url":"https://api.github.com/users/NathanielBennett/received_events","type":"User","site_admin":false},"body":"##My Awesome Pull Request\r\nLeicester City, still top ..\r\n\r\n## What does this change?\r\nChanges the design of live notifications - moves it to the left hand column. This means a slight change in the left-hand stickiness .\r\n\r\n## What is the value of this and can you measure success?\r\n\r\nIt's still at present a 0% ab test. We wanna ramp it up for the next big boxing match when it will with  any luck get us a load of return visiotors\r\n\r\n## Does this affect other platforms - Amp, Apps, etc?\r\n\r\nBefore: \r\n![notifications-before](https://cloud.githubusercontent.com/assets/986155/14781963/d49276fc-0add-11e6-955c-abf57b2b3a71.png)\r\n\r\nAfter: \r\n\r\n(With explainer, disappears after first follow)\r\n![explainer](https://cloud.githubusercontent.com/assets/986155/14781980/02f007bc-0ade-11e6-8326-72be39d96dee.png)\r\n\r\n(Following)\r\n![alerts-on](https://cloud.githubusercontent.com/assets/986155/14781995/221aa638-0ade-11e6-9ed2-3e3234f6e2ba.png)\r\n\r\n(Display a message when notifications are blocked)\r\n![blocked-permissions](https://cloud.githubusercontent.com/assets/986155/14781996/222a7784-0ade-11e6-82c0-1c1c5fc7c44d.png)\r\n\r\n\r\n\r\n\r\n\r\n\r\n## Screenshots\r\n\r\n## Request for comment\r\n\r\n\r\n<!--\r\n*Does this PR meet the [contributing guidelines](https://github.com/guardian/frontend/blob/issue_pr_templates/.github/CONTRIBUTING.md#submission)?*\r\n-->\r\n","created_at":"2016-04-25T11:07:02Z","updated_at":"2016-04-25T15:08:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09f6d6238d1ab658a635db341f546fefacb559f3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/12661/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/12661/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/12661/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/6f4b0e66c297ad778fa3be0bd47f1ac46793d229","head":{"label":"guardian:notifications-ui-redesign","ref":"notifications-ui-redesign","sha":"6f4b0e66c297ad778fa3be0bd47f1ac46793d229","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2016-04-25T10:45:26Z","pushed_at":"2016-04-25T14:58:27Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":471005,"stargazers_count":3167,"watchers_count":3167,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":324,"mirror_url":null,"open_issues_count":44,"forks":324,"open_issues":44,"watchers":3167,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"a4170fd24f66e32ed455394e5131077d6f2a13a2","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2016-04-25T10:45:26Z","pushed_at":"2016-04-25T14:58:27Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":471005,"stargazers_count":3167,"watchers_count":3167,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":324,"mirror_url":null,"open_issues_count":44,"forks":324,"open_issues":44,"watchers":3167,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/12661"},"html":{"href":"https://github.com/guardian/frontend/pull/12661"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/12661"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/12661/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/12661/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/12661/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/6f4b0e66c297ad778fa3be0bd47f1ac46793d229"}}}}