{"action":"created","issue":{"url":"https://api.github.com/repos/ManiacalLabs/BiblioPixel/issues/70","repository_url":"https://api.github.com/repos/ManiacalLabs/BiblioPixel","labels_url":"https://api.github.com/repos/ManiacalLabs/BiblioPixel/issues/70/labels{/name}","comments_url":"https://api.github.com/repos/ManiacalLabs/BiblioPixel/issues/70/comments","events_url":"https://api.github.com/repos/ManiacalLabs/BiblioPixel/issues/70/events","html_url":"https://github.com/ManiacalLabs/BiblioPixel/pull/70","id":194856779,"number":70,"title":"mass code cleanup","user":{"login":"adammhaile","id":957162,"avatar_url":"https://avatars.githubusercontent.com/u/957162?v=3","gravatar_id":"","url":"https://api.github.com/users/adammhaile","html_url":"https://github.com/adammhaile","followers_url":"https://api.github.com/users/adammhaile/followers","following_url":"https://api.github.com/users/adammhaile/following{/other_user}","gists_url":"https://api.github.com/users/adammhaile/gists{/gist_id}","starred_url":"https://api.github.com/users/adammhaile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adammhaile/subscriptions","organizations_url":"https://api.github.com/users/adammhaile/orgs","repos_url":"https://api.github.com/users/adammhaile/repos","events_url":"https://api.github.com/users/adammhaile/events{/privacy}","received_events_url":"https://api.github.com/users/adammhaile/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-11T21:11:41Z","updated_at":"2016-12-11T21:47:29Z","closed_at":"2016-12-11T21:47:06Z","pull_request":{"url":"https://api.github.com/repos/ManiacalLabs/BiblioPixel/pulls/70","html_url":"https://github.com/ManiacalLabs/BiblioPixel/pull/70","diff_url":"https://github.com/ManiacalLabs/BiblioPixel/pull/70.diff","patch_url":"https://github.com/ManiacalLabs/BiblioPixel/pull/70.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/ManiacalLabs/BiblioPixel/issues/comments/266310560","html_url":"https://github.com/ManiacalLabs/BiblioPixel/pull/70#issuecomment-266310560","issue_url":"https://api.github.com/repos/ManiacalLabs/BiblioPixel/issues/70","id":266310560,"user":{"login":"rec","id":253362,"avatar_url":"https://avatars.githubusercontent.com/u/253362?v=3","gravatar_id":"","url":"https://api.github.com/users/rec","html_url":"https://github.com/rec","followers_url":"https://api.github.com/users/rec/followers","following_url":"https://api.github.com/users/rec/following{/other_user}","gists_url":"https://api.github.com/users/rec/gists{/gist_id}","starred_url":"https://api.github.com/users/rec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rec/subscriptions","organizations_url":"https://api.github.com/users/rec/orgs","repos_url":"https://api.github.com/users/rec/repos","events_url":"https://api.github.com/users/rec/events{/privacy}","received_events_url":"https://api.github.com/users/rec/received_events","type":"User","site_admin":false},"created_at":"2016-12-11T21:47:29Z","updated_at":"2016-12-11T21:47:29Z","body":"On 11 December 2016 at 22:44, Dread <notifications@github.com> wrote:\n\n> But then it fails flake8 ;) I'll clean it up...\n>\n\nInteresting!  What failure do you get?  I'm reading the flake8 manual,\nseems great to me....\n\n\n>\n> On Sun, Dec 11, 2016 at 4:40 PM, Tom Swirly <notifications@github.com>\n> wrote:\n>\n> > Perhaps...comment out the previous line, revert that line, and put a big\n> > TODO there linking to this?\n> >\n> > Otherwise - looking really good!\n> >\n> > On 11 December 2016 at 22:36, Dread <notifications@github.com> wrote:\n> >\n> > > *@adammhaile* commented on this pull request.\n> > > ------------------------------\n> > >\n> > > In bibliopixel/led.py\n> > > <https://github.com/ManiacalLabs/BiblioPixel/pull/70>:\n> > >\n> > > > @@ -506,7 +506,7 @@ def push_to_driver(self, frameTime=None):\n> > > def color(i):\n> > > return self._colors[(h + width * i) * 3]\n> > > buf = [color(i) for i in range(self.height)]\n> > > - self.drivers[0].update_colors()\n> > > + self.drivers[0].set_colors(buf, 0)\n> > >\n> > > buf was set in line 508 and never used. Honestly that wasn't tested but\n> > it\n> > > didn't in fact work... so I was guessing. Just doing cleanup of\n> somewhat\n> > > logical things, but then a LOT of testing is needed.\n> > >\n> > > —\n> > > You are receiving this because you commented.\n> > > Reply to this email directly, view it on GitHub\n> > > <https://github.com/ManiacalLabs/BiblioPixel/pull/70>, or mute the\n> > thread\n> > > <https://github.com/notifications/unsubscribe-auth/\n> > AAPdshHKgLhcuVSroIebV6EN4gSgZAw6ks5rHGzPgaJpZM4LKCT3>\n> > > .\n> > >\n> >\n> >\n> >\n> > --\n> > /t\n> >\n> > http://radio.swirly.com - art music radio 24/7 366/1000\n> >\n> > —\n> > You are receiving this because you authored the thread.\n> > Reply to this email directly, view it on GitHub\n> > <https://github.com/ManiacalLabs/BiblioPixel/pull/\n> 70#issuecomment-266310129>,\n> > or mute the thread\n> > <https://github.com/notifications/unsubscribe-auth/AA6a6rYr_3WZS_\n> QkkB6gTuFNc0lTKFPQks5rHG3hgaJpZM4LKCT3>\n> > .\n> >\n>\n> —\n> You are receiving this because you commented.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/ManiacalLabs/BiblioPixel/pull/70#issuecomment-266310390>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AAPdssAVmklusC1bmULTYiOnDozgOO-wks5rHG7XgaJpZM4LKCT3>\n> .\n>\n\n\n\n-- \n     /t\n\nhttp://radio.swirly.com - art music radio 24/7 366/1000\n"}}
{"actor":{"display_login":"rec"}}