{"action":"created","comment":{"url":"https://api.github.com/repos/learningequality/kolibri/pulls/comments/84393898","pull_request_review_id":5174453,"id":84393898,"diff_hunk":"@@ -186,7 +186,9 @@ class Model {\n   set(attributes) {\n     // force IDs to always be strings - this should be changed on the server-side too\n     if (attributes && this.resource.idKey in attributes) {\n-      attributes[this.resource.idKey] = String(attributes[this.resource.idKey]);\n+      if(attributes[this.resource.idKey]) { // but null or undefined stays the same good old.","path":"kolibri/core/assets/src/api-resource.js","position":5,"original_position":5,"commit_id":"f5af52ba010cd74e706e36af41cffe5055f7f420","original_commit_id":"5c33b0684a7cce4e1df0ee5357018f7d7e2b82ea","user":{"login":"indirectlylit","id":2367265,"avatar_url":"https://avatars.githubusercontent.com/u/2367265?v=3","gravatar_id":"","url":"https://api.github.com/users/indirectlylit","html_url":"https://github.com/indirectlylit","followers_url":"https://api.github.com/users/indirectlylit/followers","following_url":"https://api.github.com/users/indirectlylit/following{/other_user}","gists_url":"https://api.github.com/users/indirectlylit/gists{/gist_id}","starred_url":"https://api.github.com/users/indirectlylit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indirectlylit/subscriptions","organizations_url":"https://api.github.com/users/indirectlylit/orgs","repos_url":"https://api.github.com/users/indirectlylit/repos","events_url":"https://api.github.com/users/indirectlylit/events{/privacy}","received_events_url":"https://api.github.com/users/indirectlylit/received_events","type":"User","site_admin":false},"body":"whitespace: `if (attributes[this.resource.idKey])`\r\n\r\nalso, I don't really understand the comment","created_at":"2016-10-20T23:08:06Z","updated_at":"2016-10-20T23:34:47Z","html_url":"https://github.com/learningequality/kolibri/pull/565#discussion_r84393898","pull_request_url":"https://api.github.com/repos/learningequality/kolibri/pulls/565","_links":{"self":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/comments/84393898"},"html":{"href":"https://github.com/learningequality/kolibri/pull/565#discussion_r84393898"},"pull_request":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/565"}}},"pull_request":{"url":"https://api.github.com/repos/learningequality/kolibri/pulls/565","id":88178442,"html_url":"https://github.com/learningequality/kolibri/pull/565","diff_url":"https://github.com/learningequality/kolibri/pull/565.diff","patch_url":"https://github.com/learningequality/kolibri/pull/565.patch","issue_url":"https://api.github.com/repos/learningequality/kolibri/issues/565","number":565,"state":"open","locked":false,"title":"Continue Richard's PR Mastery models #564","user":{"login":"66eli77","id":5577205,"avatar_url":"https://avatars.githubusercontent.com/u/5577205?v=3","gravatar_id":"","url":"https://api.github.com/users/66eli77","html_url":"https://github.com/66eli77","followers_url":"https://api.github.com/users/66eli77/followers","following_url":"https://api.github.com/users/66eli77/following{/other_user}","gists_url":"https://api.github.com/users/66eli77/gists{/gist_id}","starred_url":"https://api.github.com/users/66eli77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/66eli77/subscriptions","organizations_url":"https://api.github.com/users/66eli77/orgs","repos_url":"https://api.github.com/users/66eli77/repos","events_url":"https://api.github.com/users/66eli77/events{/privacy}","received_events_url":"https://api.github.com/users/66eli77/received_events","type":"User","site_admin":false},"body":"Link to original: #564\r\n\r\nsee also:\r\n\r\n* https://github.com/learningequality/kolibri-exercise-perseus-plugin/pull/2\r\n* https://github.com/learningequality/kolibri-exercise-perseus-plugin/pull/3\r\n\r\ngoogle doc reference:\r\n*https://docs.google.com/document/d/10w7EYH4EkWvBIa-WEC7j9os7DIfvHfNTK4U7iYhUlQ8/edit","created_at":"2016-10-05T23:57:06Z","updated_at":"2016-10-20T23:34:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef1b613ea37404673922883843588a9a71219941","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/learningequality/kolibri/pulls/565/commits","review_comments_url":"https://api.github.com/repos/learningequality/kolibri/pulls/565/comments","review_comment_url":"https://api.github.com/repos/learningequality/kolibri/pulls/comments{/number}","comments_url":"https://api.github.com/repos/learningequality/kolibri/issues/565/comments","statuses_url":"https://api.github.com/repos/learningequality/kolibri/statuses/f5af52ba010cd74e706e36af41cffe5055f7f420","head":{"label":"66eli77:fork-richard","ref":"fork-richard","sha":"f5af52ba010cd74e706e36af41cffe5055f7f420","user":{"login":"66eli77","id":5577205,"avatar_url":"https://avatars.githubusercontent.com/u/5577205?v=3","gravatar_id":"","url":"https://api.github.com/users/66eli77","html_url":"https://github.com/66eli77","followers_url":"https://api.github.com/users/66eli77/followers","following_url":"https://api.github.com/users/66eli77/following{/other_user}","gists_url":"https://api.github.com/users/66eli77/gists{/gist_id}","starred_url":"https://api.github.com/users/66eli77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/66eli77/subscriptions","organizations_url":"https://api.github.com/users/66eli77/orgs","repos_url":"https://api.github.com/users/66eli77/repos","events_url":"https://api.github.com/users/66eli77/events{/privacy}","received_events_url":"https://api.github.com/users/66eli77/received_events","type":"User","site_admin":false},"repo":{"id":50968300,"name":"kolibri","full_name":"66eli77/kolibri","owner":{"login":"66eli77","id":5577205,"avatar_url":"https://avatars.githubusercontent.com/u/5577205?v=3","gravatar_id":"","url":"https://api.github.com/users/66eli77","html_url":"https://github.com/66eli77","followers_url":"https://api.github.com/users/66eli77/followers","following_url":"https://api.github.com/users/66eli77/following{/other_user}","gists_url":"https://api.github.com/users/66eli77/gists{/gist_id}","starred_url":"https://api.github.com/users/66eli77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/66eli77/subscriptions","organizations_url":"https://api.github.com/users/66eli77/orgs","repos_url":"https://api.github.com/users/66eli77/repos","events_url":"https://api.github.com/users/66eli77/events{/privacy}","received_events_url":"https://api.github.com/users/66eli77/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/66eli77/kolibri","description":"This is where Kolibri shall be born, watch and participate!","fork":true,"url":"https://api.github.com/repos/66eli77/kolibri","forks_url":"https://api.github.com/repos/66eli77/kolibri/forks","keys_url":"https://api.github.com/repos/66eli77/kolibri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/66eli77/kolibri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/66eli77/kolibri/teams","hooks_url":"https://api.github.com/repos/66eli77/kolibri/hooks","issue_events_url":"https://api.github.com/repos/66eli77/kolibri/issues/events{/number}","events_url":"https://api.github.com/repos/66eli77/kolibri/events","assignees_url":"https://api.github.com/repos/66eli77/kolibri/assignees{/user}","branches_url":"https://api.github.com/repos/66eli77/kolibri/branches{/branch}","tags_url":"https://api.github.com/repos/66eli77/kolibri/tags","blobs_url":"https://api.github.com/repos/66eli77/kolibri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/66eli77/kolibri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/66eli77/kolibri/git/refs{/sha}","trees_url":"https://api.github.com/repos/66eli77/kolibri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/66eli77/kolibri/statuses/{sha}","languages_url":"https://api.github.com/repos/66eli77/kolibri/languages","stargazers_url":"https://api.github.com/repos/66eli77/kolibri/stargazers","contributors_url":"https://api.github.com/repos/66eli77/kolibri/contributors","subscribers_url":"https://api.github.com/repos/66eli77/kolibri/subscribers","subscription_url":"https://api.github.com/repos/66eli77/kolibri/subscription","commits_url":"https://api.github.com/repos/66eli77/kolibri/commits{/sha}","git_commits_url":"https://api.github.com/repos/66eli77/kolibri/git/commits{/sha}","comments_url":"https://api.github.com/repos/66eli77/kolibri/comments{/number}","issue_comment_url":"https://api.github.com/repos/66eli77/kolibri/issues/comments{/number}","contents_url":"https://api.github.com/repos/66eli77/kolibri/contents/{+path}","compare_url":"https://api.github.com/repos/66eli77/kolibri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/66eli77/kolibri/merges","archive_url":"https://api.github.com/repos/66eli77/kolibri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/66eli77/kolibri/downloads","issues_url":"https://api.github.com/repos/66eli77/kolibri/issues{/number}","pulls_url":"https://api.github.com/repos/66eli77/kolibri/pulls{/number}","milestones_url":"https://api.github.com/repos/66eli77/kolibri/milestones{/number}","notifications_url":"https://api.github.com/repos/66eli77/kolibri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/66eli77/kolibri/labels{/name}","releases_url":"https://api.github.com/repos/66eli77/kolibri/releases{/id}","deployments_url":"https://api.github.com/repos/66eli77/kolibri/deployments","created_at":"2016-02-03T02:34:15Z","updated_at":"2016-02-03T02:34:16Z","pushed_at":"2016-10-20T23:17:25Z","git_url":"git://github.com/66eli77/kolibri.git","ssh_url":"git@github.com:66eli77/kolibri.git","clone_url":"https://github.com/66eli77/kolibri.git","svn_url":"https://github.com/66eli77/kolibri","homepage":"http://learningequality.org/kolibri/","size":8559,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"learningequality:develop","ref":"develop","sha":"88ada6cd58695bf76d83bebcbd6c479a0c0a8d91","user":{"login":"learningequality","id":3926525,"avatar_url":"https://avatars.githubusercontent.com/u/3926525?v=3","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"repo":{"id":49976939,"name":"kolibri","full_name":"learningequality/kolibri","owner":{"login":"learningequality","id":3926525,"avatar_url":"https://avatars.githubusercontent.com/u/3926525?v=3","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/learningequality/kolibri","description":"This is where Kolibri shall be born, watch and participate!","fork":false,"url":"https://api.github.com/repos/learningequality/kolibri","forks_url":"https://api.github.com/repos/learningequality/kolibri/forks","keys_url":"https://api.github.com/repos/learningequality/kolibri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/learningequality/kolibri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/learningequality/kolibri/teams","hooks_url":"https://api.github.com/repos/learningequality/kolibri/hooks","issue_events_url":"https://api.github.com/repos/learningequality/kolibri/issues/events{/number}","events_url":"https://api.github.com/repos/learningequality/kolibri/events","assignees_url":"https://api.github.com/repos/learningequality/kolibri/assignees{/user}","branches_url":"https://api.github.com/repos/learningequality/kolibri/branches{/branch}","tags_url":"https://api.github.com/repos/learningequality/kolibri/tags","blobs_url":"https://api.github.com/repos/learningequality/kolibri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/learningequality/kolibri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/learningequality/kolibri/git/refs{/sha}","trees_url":"https://api.github.com/repos/learningequality/kolibri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/learningequality/kolibri/statuses/{sha}","languages_url":"https://api.github.com/repos/learningequality/kolibri/languages","stargazers_url":"https://api.github.com/repos/learningequality/kolibri/stargazers","contributors_url":"https://api.github.com/repos/learningequality/kolibri/contributors","subscribers_url":"https://api.github.com/repos/learningequality/kolibri/subscribers","subscription_url":"https://api.github.com/repos/learningequality/kolibri/subscription","commits_url":"https://api.github.com/repos/learningequality/kolibri/commits{/sha}","git_commits_url":"https://api.github.com/repos/learningequality/kolibri/git/commits{/sha}","comments_url":"https://api.github.com/repos/learningequality/kolibri/comments{/number}","issue_comment_url":"https://api.github.com/repos/learningequality/kolibri/issues/comments{/number}","contents_url":"https://api.github.com/repos/learningequality/kolibri/contents/{+path}","compare_url":"https://api.github.com/repos/learningequality/kolibri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/learningequality/kolibri/merges","archive_url":"https://api.github.com/repos/learningequality/kolibri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/learningequality/kolibri/downloads","issues_url":"https://api.github.com/repos/learningequality/kolibri/issues{/number}","pulls_url":"https://api.github.com/repos/learningequality/kolibri/pulls{/number}","milestones_url":"https://api.github.com/repos/learningequality/kolibri/milestones{/number}","notifications_url":"https://api.github.com/repos/learningequality/kolibri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/learningequality/kolibri/labels{/name}","releases_url":"https://api.github.com/repos/learningequality/kolibri/releases{/id}","deployments_url":"https://api.github.com/repos/learningequality/kolibri/deployments","created_at":"2016-01-19T19:22:07Z","updated_at":"2016-09-20T00:16:36Z","pushed_at":"2016-10-20T23:31:18Z","git_url":"git://github.com/learningequality/kolibri.git","ssh_url":"git@github.com:learningequality/kolibri.git","clone_url":"https://github.com/learningequality/kolibri.git","svn_url":"https://github.com/learningequality/kolibri","homepage":"http://learningequality.org/kolibri/","size":10908,"stargazers_count":32,"watchers_count":32,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":49,"forks":35,"open_issues":49,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/565"},"html":{"href":"https://github.com/learningequality/kolibri/pull/565"},"issue":{"href":"https://api.github.com/repos/learningequality/kolibri/issues/565"},"comments":{"href":"https://api.github.com/repos/learningequality/kolibri/issues/565/comments"},"review_comments":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/565/comments"},"review_comment":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/565/commits"},"statuses":{"href":"https://api.github.com/repos/learningequality/kolibri/statuses/f5af52ba010cd74e706e36af41cffe5055f7f420"}}}}
{"actor":{"display_login":"indirectlylit"}}