{"action":"created","issue":{"url":"https://api.github.com/repos/hgb2/PSAS-Capstone/issues/26","repository_url":"https://api.github.com/repos/hgb2/PSAS-Capstone","labels_url":"https://api.github.com/repos/hgb2/PSAS-Capstone/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/hgb2/PSAS-Capstone/issues/26/comments","events_url":"https://api.github.com/repos/hgb2/PSAS-Capstone/issues/26/events","html_url":"https://github.com/hgb2/PSAS-Capstone/pull/26","id":171081018,"number":26,"title":"Control tests","user":{"login":"BrianBreniser","id":6211210,"avatar_url":"https://avatars.githubusercontent.com/u/6211210?v=3","gravatar_id":"","url":"https://api.github.com/users/BrianBreniser","html_url":"https://github.com/BrianBreniser","followers_url":"https://api.github.com/users/BrianBreniser/followers","following_url":"https://api.github.com/users/BrianBreniser/following{/other_user}","gists_url":"https://api.github.com/users/BrianBreniser/gists{/gist_id}","starred_url":"https://api.github.com/users/BrianBreniser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrianBreniser/subscriptions","organizations_url":"https://api.github.com/users/BrianBreniser/orgs","repos_url":"https://api.github.com/users/BrianBreniser/repos","events_url":"https://api.github.com/users/BrianBreniser/events{/privacy}","received_events_url":"https://api.github.com/users/BrianBreniser/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-14T21:55:07Z","updated_at":"2016-08-15T18:42:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hgb2/PSAS-Capstone/pulls/26","html_url":"https://github.com/hgb2/PSAS-Capstone/pull/26","diff_url":"https://github.com/hgb2/PSAS-Capstone/pull/26.diff","patch_url":"https://github.com/hgb2/PSAS-Capstone/pull/26.patch"},"body":"I added some tests, and did some minor code cleanup, although most of them won't work if there isn't a real gpio device, so we will have to test them on the LED prototype. The ones that do pass ensure that a few simple things are working properly every time tests are run.\r\n\r\nFeedback is appreciated. I'll merge these changes if someone checks them off."},"comment":{"url":"https://api.github.com/repos/hgb2/PSAS-Capstone/issues/comments/239889882","html_url":"https://github.com/hgb2/PSAS-Capstone/pull/26#issuecomment-239889882","issue_url":"https://api.github.com/repos/hgb2/PSAS-Capstone/issues/26","id":239889882,"user":{"login":"cwalexand","id":9542541,"avatar_url":"https://avatars.githubusercontent.com/u/9542541?v=3","gravatar_id":"","url":"https://api.github.com/users/cwalexand","html_url":"https://github.com/cwalexand","followers_url":"https://api.github.com/users/cwalexand/followers","following_url":"https://api.github.com/users/cwalexand/following{/other_user}","gists_url":"https://api.github.com/users/cwalexand/gists{/gist_id}","starred_url":"https://api.github.com/users/cwalexand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwalexand/subscriptions","organizations_url":"https://api.github.com/users/cwalexand/orgs","repos_url":"https://api.github.com/users/cwalexand/repos","events_url":"https://api.github.com/users/cwalexand/events{/privacy}","received_events_url":"https://api.github.com/users/cwalexand/received_events","type":"User","site_admin":false},"created_at":"2016-08-15T18:42:09Z","updated_at":"2016-08-15T18:42:09Z","body":"Both modes introduce new warnings into the build. Below are the results for test_mode. The same warnings occur for flight_mode but have different line numbers.\r\n\r\nsrc/gpio.rs:147:9: 147:14 warning: variable does not need to be mutable, #[warn(unused_mut)] on by default\r\nsrc/gpio.rs:147     let mut p = MyPins::new();\r\n\r\nsrc/gpio.rs:165:9: 165:10 warning: unused variable: `v`, #[warn(unused_variables)] on by default\r\nsrc/gpio.rs:165     let v = p.get_value(42).unwrap();\r\n\r\nsrc/gpio.rs:173:5: 173:24 warning: unused result which must be used, #[warn(unused_must_use)] on by default\r\nsrc/gpio.rs:173     p.set_value(42, 0);\r\n\r\n-----------------------------------------------------------------------------------\r\nBoth modes ignore the following tests:\r\n\r\ntest gpio::test_multiple_pins ... ignored\r\ntest gpio::test_set_pin ... ignored\r\ntest timestep ... ignored"}}
{"actor":{"display_login":"cwalexand"}}