{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7839","repository_url":"https://api.github.com/repos/scikit-learn/scikit-learn","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7839/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7839/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7839/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/7839","id":187816023,"number":7839,"title":"Add floating point option to max_feature option in CountVectorizer and TfidfVectorizer to use a percentage of the features.","user":{"login":"Mxbonn","id":11473168,"avatar_url":"https://avatars.githubusercontent.com/u/11473168?v=3","gravatar_id":"","url":"https://api.github.com/users/Mxbonn","html_url":"https://github.com/Mxbonn","followers_url":"https://api.github.com/users/Mxbonn/followers","following_url":"https://api.github.com/users/Mxbonn/following{/other_user}","gists_url":"https://api.github.com/users/Mxbonn/gists{/gist_id}","starred_url":"https://api.github.com/users/Mxbonn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mxbonn/subscriptions","organizations_url":"https://api.github.com/users/Mxbonn/orgs","repos_url":"https://api.github.com/users/Mxbonn/repos","events_url":"https://api.github.com/users/Mxbonn/events{/privacy}","received_events_url":"https://api.github.com/users/Mxbonn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-07T20:17:21Z","updated_at":"2016-11-08T11:55:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7839","html_url":"https://github.com/scikit-learn/scikit-learn/pull/7839","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/7839.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/7839.patch"},"body":"I added an option to CountVectorizer and TfidfVectorizer to use a floating point value for the max_features parameter to express a percentage of the features instead of an absolute value.\r\n\r\nI also changed the default from None to 1.0 and added tests.\r\n\r\nThis is my first contribution to this project so let me know if I did anything wrong :)."},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/259117977","html_url":"https://github.com/scikit-learn/scikit-learn/pull/7839#issuecomment-259117977","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7839","id":259117977,"user":{"login":"jnothman","id":78827,"avatar_url":"https://avatars.githubusercontent.com/u/78827?v=3","gravatar_id":"","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following{/other_user}","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User","site_admin":false},"created_at":"2016-11-08T11:55:32Z","updated_at":"2016-11-08T11:55:32Z","body":"Otherwise LGTM"}}
{"actor":{"display_login":"jnothman"}}