{"action":"created","issue":{"url":"https://api.github.com/repos/chapel-lang/chapel/issues/3569","repository_url":"https://api.github.com/repos/chapel-lang/chapel","labels_url":"https://api.github.com/repos/chapel-lang/chapel/issues/3569/labels{/name}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/issues/3569/comments","events_url":"https://api.github.com/repos/chapel-lang/chapel/issues/3569/events","html_url":"https://github.com/chapel-lang/chapel/pull/3569","id":143107347,"number":3569,"title":"Fix logic for re-making version.cpp","user":{"login":"bradcray","id":7536222,"avatar_url":"https://avatars.githubusercontent.com/u/7536222?v=3","gravatar_id":"","url":"https://api.github.com/users/bradcray","html_url":"https://github.com/bradcray","followers_url":"https://api.github.com/users/bradcray/followers","following_url":"https://api.github.com/users/bradcray/following{/other_user}","gists_url":"https://api.github.com/users/bradcray/gists{/gist_id}","starred_url":"https://api.github.com/users/bradcray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradcray/subscriptions","organizations_url":"https://api.github.com/users/bradcray/orgs","repos_url":"https://api.github.com/users/bradcray/repos","events_url":"https://api.github.com/users/bradcray/events{/privacy}","received_events_url":"https://api.github.com/users/bradcray/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-23T23:40:31Z","updated_at":"2016-03-23T23:46:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/3569","html_url":"https://github.com/chapel-lang/chapel/pull/3569","diff_url":"https://github.com/chapel-lang/chapel/pull/3569.diff","patch_url":"https://github.com/chapel-lang/chapel/pull/3569.patch"},"body":"For quite some time now, if building the Chapel compiler outside\r\nof a .git setting, we would rebuild version.cpp on every compile\r\nbecause the logic that avoids creating a new compiler/main/BUILD_VERSION\r\nfile if nothing has changed version-wise is only intelligent when\r\ngit is involved.  When git is not involved -- or when we don't\r\nhave the util/devel/updateBuildVersion script available (as in a\r\nrelease build setting), we would just echo \"0\" out to\r\ncompiler/main/BUILD_VERSION on *every* compile, forcing a rebuild.\r\n\r\nThis commit fixes that issue by only dropping a \"0\" into that file\r\nin the event that the file does not exist.  The reviewer should\r\ndouble-check my shell syntax, as I'm not an expert (specifically,\r\nwhile this works on bash, will it work on sh?  If we care...)\r\n\r\nWhile here, I also removed the check for .svn, which I believe\r\npredates our move to git and was probably preserved for the\r\nperiod of time when we were sitting on both svn and git before\r\ndisconnecting from svn."},"comment":{"url":"https://api.github.com/repos/chapel-lang/chapel/issues/comments/200585521","html_url":"https://github.com/chapel-lang/chapel/pull/3569#issuecomment-200585521","issue_url":"https://api.github.com/repos/chapel-lang/chapel/issues/3569","id":200585521,"user":{"login":"ronawho","id":1588337,"avatar_url":"https://avatars.githubusercontent.com/u/1588337?v=3","gravatar_id":"","url":"https://api.github.com/users/ronawho","html_url":"https://github.com/ronawho","followers_url":"https://api.github.com/users/ronawho/followers","following_url":"https://api.github.com/users/ronawho/following{/other_user}","gists_url":"https://api.github.com/users/ronawho/gists{/gist_id}","starred_url":"https://api.github.com/users/ronawho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronawho/subscriptions","organizations_url":"https://api.github.com/users/ronawho/orgs","repos_url":"https://api.github.com/users/ronawho/repos","events_url":"https://api.github.com/users/ronawho/events{/privacy}","received_events_url":"https://api.github.com/users/ronawho/received_events","type":"User","site_admin":false},"created_at":"2016-03-23T23:46:13Z","updated_at":"2016-03-23T23:46:13Z","body":":+1: "}}