{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/91559439","pull_request_review_id":12069510,"id":91559439,"diff_hunk":"@@ -138,11 +138,11 @@\n       <PackageTargetFramework>uap10.1</PackageTargetFramework>\n       <NuGetTargetMoniker>UAP,Version=v10.1</NuGetTargetMoniker>\n     </TargetGroups>\n-    <TargetGroups Include=\"portable-net45+win8+sl5\">\n+    <TargetGroups Include=\"portable_net45+win8+sl5\">","path":"src/Tools/GenerateProps/targetgroups.props","position":5,"original_position":5,"commit_id":"37049df257ecfc7fe8f366696d53c1e654fbf13a","original_commit_id":"37049df257ecfc7fe8f366696d53c1e654fbf13a","user":{"login":"ericstj","id":8918108,"avatar_url":"https://avatars.githubusercontent.com/u/8918108?v=3","gravatar_id":"","url":"https://api.github.com/users/ericstj","html_url":"https://github.com/ericstj","followers_url":"https://api.github.com/users/ericstj/followers","following_url":"https://api.github.com/users/ericstj/following{/other_user}","gists_url":"https://api.github.com/users/ericstj/gists{/gist_id}","starred_url":"https://api.github.com/users/ericstj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericstj/subscriptions","organizations_url":"https://api.github.com/users/ericstj/orgs","repos_url":"https://api.github.com/users/ericstj/repos","events_url":"https://api.github.com/users/ericstj/events{/privacy}","received_events_url":"https://api.github.com/users/ericstj/received_events","type":"User","site_admin":false},"body":"We need it for value tuple, but these strings are purely opaque keys so we can choose whatever value we want.","created_at":"2016-12-08T17:08:27Z","updated_at":"2016-12-08T17:08:27Z","html_url":"https://github.com/dotnet/corefx/pull/14171#discussion_r91559439","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/14171","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/91559439"},"html":{"href":"https://github.com/dotnet/corefx/pull/14171#discussion_r91559439"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/14171"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/14171","id":96374697,"html_url":"https://github.com/dotnet/corefx/pull/14171","diff_url":"https://github.com/dotnet/corefx/pull/14171.diff","patch_url":"https://github.com/dotnet/corefx/pull/14171.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/14171","number":14171,"state":"open","locked":false,"title":"vertical build port to Dev/eng [Do not merge]","user":{"login":"chcosta","id":10092143,"avatar_url":"https://avatars.githubusercontent.com/u/10092143?v=3","gravatar_id":"","url":"https://api.github.com/users/chcosta","html_url":"https://github.com/chcosta","followers_url":"https://api.github.com/users/chcosta/followers","following_url":"https://api.github.com/users/chcosta/following{/other_user}","gists_url":"https://api.github.com/users/chcosta/gists{/gist_id}","starred_url":"https://api.github.com/users/chcosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chcosta/subscriptions","organizations_url":"https://api.github.com/users/chcosta/orgs","repos_url":"https://api.github.com/users/chcosta/repos","events_url":"https://api.github.com/users/chcosta/events{/privacy}","received_events_url":"https://api.github.com/users/chcosta/received_events","type":"User","site_admin":false},"body":"Now that Eric has checked in, I'm able to move my work into the dev/eng branch.  This change brings in code to build only those libraries contributing to a specific vertical.  The code was originally written as a proof-of-concept against corefx/master.  Not being able to play in dev/eng means that the code base quickly diverged and now there is quite a bit of cleanup work to bring these changes back in line with the direction of dev/eng.\r\n\r\nWork to be done (I'll capture all of this in a separate issue):\r\n- Refactor to consume Eric's configurations props file\r\n- Make the vertical build a first-class citizen, in its current implementation, you only perform a vertical build if you include `/p:VerticalGroup=Windows_NT-netcoreapp1.1-Debug`.  Making it a first class build means we can get rid of quite a bit of code from buildvertical.targets and eliminate buildvertical.traversal.targets\r\n- Default target group is no longer a concept, update Configurations to reflect that and remove default target group code.\r\n- Some libraries which were previously building, are not building cleanly in dev/eng, I've omitted these from the build by adding an 'omit.txt' file in the library folder.\r\n- Names of properties / targets / etc will probably need to change because concepts have changed\r\n- Binary output needs to be updated to conform with Wes' documented spec - https://github.com/dotnet/corefx/blob/63205dc4918e0520c3c512f322d00c3206c5a9ff/Documentation/coding-guidelines/project-guidelines.md\r\n\r\nI don't want to slow down anyone's work which requires this build output, so I'm ok with submitting this code as-is if it is needed and cleaning it up with additional checkins as we evolve the code, i'm also ok with holding off on checking this in. I'd prefer not to check-in as-is if nobody is clamoring for the work.  Now that I am working in dev/eng, I am feeling far less angst about being removed from the rest of the vertical build changes.\r\n\r\n/cc @ellismg @weshaggard @ericstj @mellinoe @markwilkie ","created_at":"2016-12-03T00:05:48Z","updated_at":"2016-12-08T17:08:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a93515a5a0bb68c266049ae6a2c1df1a225fd72","assignee":{"login":"chcosta","id":10092143,"avatar_url":"https://avatars.githubusercontent.com/u/10092143?v=3","gravatar_id":"","url":"https://api.github.com/users/chcosta","html_url":"https://github.com/chcosta","followers_url":"https://api.github.com/users/chcosta/followers","following_url":"https://api.github.com/users/chcosta/following{/other_user}","gists_url":"https://api.github.com/users/chcosta/gists{/gist_id}","starred_url":"https://api.github.com/users/chcosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chcosta/subscriptions","organizations_url":"https://api.github.com/users/chcosta/orgs","repos_url":"https://api.github.com/users/chcosta/repos","events_url":"https://api.github.com/users/chcosta/events{/privacy}","received_events_url":"https://api.github.com/users/chcosta/received_events","type":"User","site_admin":false},"assignees":[{"login":"chcosta","id":10092143,"avatar_url":"https://avatars.githubusercontent.com/u/10092143?v=3","gravatar_id":"","url":"https://api.github.com/users/chcosta","html_url":"https://github.com/chcosta","followers_url":"https://api.github.com/users/chcosta/followers","following_url":"https://api.github.com/users/chcosta/following{/other_user}","gists_url":"https://api.github.com/users/chcosta/gists{/gist_id}","starred_url":"https://api.github.com/users/chcosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chcosta/subscriptions","organizations_url":"https://api.github.com/users/chcosta/orgs","repos_url":"https://api.github.com/users/chcosta/repos","events_url":"https://api.github.com/users/chcosta/events{/privacy}","received_events_url":"https://api.github.com/users/chcosta/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/14171/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/14171/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/14171/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/37049df257ecfc7fe8f366696d53c1e654fbf13a","head":{"label":"chcosta:dev/eng_port","ref":"dev/eng_port","sha":"37049df257ecfc7fe8f366696d53c1e654fbf13a","user":{"login":"chcosta","id":10092143,"avatar_url":"https://avatars.githubusercontent.com/u/10092143?v=3","gravatar_id":"","url":"https://api.github.com/users/chcosta","html_url":"https://github.com/chcosta","followers_url":"https://api.github.com/users/chcosta/followers","following_url":"https://api.github.com/users/chcosta/following{/other_user}","gists_url":"https://api.github.com/users/chcosta/gists{/gist_id}","starred_url":"https://api.github.com/users/chcosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chcosta/subscriptions","organizations_url":"https://api.github.com/users/chcosta/orgs","repos_url":"https://api.github.com/users/chcosta/repos","events_url":"https://api.github.com/users/chcosta/events{/privacy}","received_events_url":"https://api.github.com/users/chcosta/received_events","type":"User","site_admin":false},"repo":{"id":38846544,"name":"corefx","full_name":"chcosta/corefx","owner":{"login":"chcosta","id":10092143,"avatar_url":"https://avatars.githubusercontent.com/u/10092143?v=3","gravatar_id":"","url":"https://api.github.com/users/chcosta","html_url":"https://github.com/chcosta","followers_url":"https://api.github.com/users/chcosta/followers","following_url":"https://api.github.com/users/chcosta/following{/other_user}","gists_url":"https://api.github.com/users/chcosta/gists{/gist_id}","starred_url":"https://api.github.com/users/chcosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chcosta/subscriptions","organizations_url":"https://api.github.com/users/chcosta/orgs","repos_url":"https://api.github.com/users/chcosta/repos","events_url":"https://api.github.com/users/chcosta/events{/privacy}","received_events_url":"https://api.github.com/users/chcosta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chcosta/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/chcosta/corefx","forks_url":"https://api.github.com/repos/chcosta/corefx/forks","keys_url":"https://api.github.com/repos/chcosta/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chcosta/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chcosta/corefx/teams","hooks_url":"https://api.github.com/repos/chcosta/corefx/hooks","issue_events_url":"https://api.github.com/repos/chcosta/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/chcosta/corefx/events","assignees_url":"https://api.github.com/repos/chcosta/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/chcosta/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/chcosta/corefx/tags","blobs_url":"https://api.github.com/repos/chcosta/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chcosta/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chcosta/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/chcosta/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chcosta/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/chcosta/corefx/languages","stargazers_url":"https://api.github.com/repos/chcosta/corefx/stargazers","contributors_url":"https://api.github.com/repos/chcosta/corefx/contributors","subscribers_url":"https://api.github.com/repos/chcosta/corefx/subscribers","subscription_url":"https://api.github.com/repos/chcosta/corefx/subscription","commits_url":"https://api.github.com/repos/chcosta/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/chcosta/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/chcosta/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/chcosta/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/chcosta/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/chcosta/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chcosta/corefx/merges","archive_url":"https://api.github.com/repos/chcosta/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chcosta/corefx/downloads","issues_url":"https://api.github.com/repos/chcosta/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/chcosta/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/chcosta/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/chcosta/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chcosta/corefx/labels{/name}","releases_url":"https://api.github.com/repos/chcosta/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/chcosta/corefx/deployments","created_at":"2015-07-09T21:37:18Z","updated_at":"2016-02-17T21:55:35Z","pushed_at":"2016-12-08T06:47:02Z","git_url":"git://github.com/chcosta/corefx.git","ssh_url":"git@github.com:chcosta/corefx.git","clone_url":"https://github.com/chcosta/corefx.git","svn_url":"https://github.com/chcosta/corefx","homepage":"http://dotnet.github.io/core/","size":130280,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:dev/eng","ref":"dev/eng","sha":"3114be1c11706f189ccc1c4fbbb87551481e906d","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-12-08T16:24:05Z","pushed_at":"2016-12-08T16:57:35Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":170150,"stargazers_count":10923,"watchers_count":10923,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2792,"mirror_url":null,"open_issues_count":1287,"forks":2792,"open_issues":1287,"watchers":10923,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/14171"},"html":{"href":"https://github.com/dotnet/corefx/pull/14171"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/14171"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/14171/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/14171/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/14171/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/37049df257ecfc7fe8f366696d53c1e654fbf13a"}}}}
{"actor":{"display_login":"ericstj"}}