{"action":"created","issue":{"url":"https://api.github.com/repos/uber-go/zap/issues/126","repository_url":"https://api.github.com/repos/uber-go/zap","labels_url":"https://api.github.com/repos/uber-go/zap/issues/126/labels{/name}","comments_url":"https://api.github.com/repos/uber-go/zap/issues/126/comments","events_url":"https://api.github.com/repos/uber-go/zap/issues/126/events","html_url":"https://github.com/uber-go/zap/pull/126","id":169171790,"number":126,"title":"Fix Check not triggering panic/exit on Panic/Fatal","user":{"login":"prashantv","id":140159,"avatar_url":"https://avatars.githubusercontent.com/u/140159?v=3","gravatar_id":"","url":"https://api.github.com/users/prashantv","html_url":"https://github.com/prashantv","followers_url":"https://api.github.com/users/prashantv/followers","following_url":"https://api.github.com/users/prashantv/following{/other_user}","gists_url":"https://api.github.com/users/prashantv/gists{/gist_id}","starred_url":"https://api.github.com/users/prashantv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prashantv/subscriptions","organizations_url":"https://api.github.com/users/prashantv/orgs","repos_url":"https://api.github.com/users/prashantv/repos","events_url":"https://api.github.com/users/prashantv/events{/privacy}","received_events_url":"https://api.github.com/users/prashantv/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"akshayjshah","id":972790,"avatar_url":"https://avatars.githubusercontent.com/u/972790?v=3","gravatar_id":"","url":"https://api.github.com/users/akshayjshah","html_url":"https://github.com/akshayjshah","followers_url":"https://api.github.com/users/akshayjshah/followers","following_url":"https://api.github.com/users/akshayjshah/following{/other_user}","gists_url":"https://api.github.com/users/akshayjshah/gists{/gist_id}","starred_url":"https://api.github.com/users/akshayjshah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akshayjshah/subscriptions","organizations_url":"https://api.github.com/users/akshayjshah/orgs","repos_url":"https://api.github.com/users/akshayjshah/repos","events_url":"https://api.github.com/users/akshayjshah/events{/privacy}","received_events_url":"https://api.github.com/users/akshayjshah/received_events","type":"User","site_admin":false},"assignees":[{"login":"akshayjshah","id":972790,"avatar_url":"https://avatars.githubusercontent.com/u/972790?v=3","gravatar_id":"","url":"https://api.github.com/users/akshayjshah","html_url":"https://github.com/akshayjshah","followers_url":"https://api.github.com/users/akshayjshah/followers","following_url":"https://api.github.com/users/akshayjshah/following{/other_user}","gists_url":"https://api.github.com/users/akshayjshah/gists{/gist_id}","starred_url":"https://api.github.com/users/akshayjshah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akshayjshah/subscriptions","organizations_url":"https://api.github.com/users/akshayjshah/orgs","repos_url":"https://api.github.com/users/akshayjshah/repos","events_url":"https://api.github.com/users/akshayjshah/events{/privacy}","received_events_url":"https://api.github.com/users/akshayjshah/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-08-03T16:13:21Z","updated_at":"2016-08-04T01:27:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/uber-go/zap/pulls/126","html_url":"https://github.com/uber-go/zap/pull/126","diff_url":"https://github.com/uber-go/zap/pull/126.diff","patch_url":"https://github.com/uber-go/zap/pull/126.patch"},"body":"Panic and Fatal should always cause a panic or exit, even if the level\r\nis disabled. This is handled correctly in logger.Panic/Fatal/Log, but\r\nwhen the CheckedMessage is used, we're not calling panic/exit.\r\n\r\nWe should always return a valid message from Check when the level is\r\nFatal or Panic. This means that Panic/Fatal will not be sampled, since\r\nthe sampler should not call panic/exit directly, but should defer to the\r\nunderlying logger, and there's no way to specify don't log, but call the\r\npanic/exit functions.\r\n\r\nFixes #125 "},"comment":{"url":"https://api.github.com/repos/uber-go/zap/issues/comments/237424848","html_url":"https://github.com/uber-go/zap/pull/126#issuecomment-237424848","issue_url":"https://api.github.com/repos/uber-go/zap/issues/126","id":237424848,"user":{"login":"akshayjshah","id":972790,"avatar_url":"https://avatars.githubusercontent.com/u/972790?v=3","gravatar_id":"","url":"https://api.github.com/users/akshayjshah","html_url":"https://github.com/akshayjshah","followers_url":"https://api.github.com/users/akshayjshah/followers","following_url":"https://api.github.com/users/akshayjshah/following{/other_user}","gists_url":"https://api.github.com/users/akshayjshah/gists{/gist_id}","starred_url":"https://api.github.com/users/akshayjshah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akshayjshah/subscriptions","organizations_url":"https://api.github.com/users/akshayjshah/orgs","repos_url":"https://api.github.com/users/akshayjshah/repos","events_url":"https://api.github.com/users/akshayjshah/events{/privacy}","received_events_url":"https://api.github.com/users/akshayjshah/received_events","type":"User","site_admin":false},"created_at":"2016-08-04T01:27:59Z","updated_at":"2016-08-04T01:27:59Z","body":":shipit:"}}
{"actor":{"display_login":"akshayjshah"}}