{"action":"created","issue":{"url":"https://api.github.com/repos/apache/jena/issues/157","repository_url":"https://api.github.com/repos/apache/jena","labels_url":"https://api.github.com/repos/apache/jena/issues/157/labels{/name}","comments_url":"https://api.github.com/repos/apache/jena/issues/157/comments","events_url":"https://api.github.com/repos/apache/jena/issues/157/events","html_url":"https://github.com/apache/jena/pull/157","id":166110659,"number":157,"title":"Fixes for JENA-1212","user":{"login":"ehedgehog","id":455956,"avatar_url":"https://avatars.githubusercontent.com/u/455956?v=3","gravatar_id":"","url":"https://api.github.com/users/ehedgehog","html_url":"https://github.com/ehedgehog","followers_url":"https://api.github.com/users/ehedgehog/followers","following_url":"https://api.github.com/users/ehedgehog/following{/other_user}","gists_url":"https://api.github.com/users/ehedgehog/gists{/gist_id}","starred_url":"https://api.github.com/users/ehedgehog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehedgehog/subscriptions","organizations_url":"https://api.github.com/users/ehedgehog/orgs","repos_url":"https://api.github.com/users/ehedgehog/repos","events_url":"https://api.github.com/users/ehedgehog/events{/privacy}","received_events_url":"https://api.github.com/users/ehedgehog/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":29,"created_at":"2016-07-18T14:43:28Z","updated_at":"2016-07-26T14:52:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/jena/pulls/157","html_url":"https://github.com/apache/jena/pull/157","diff_url":"https://github.com/apache/jena/pull/157.diff","patch_url":"https://github.com/apache/jena/pull/157.patch"},"body":"Comparator used by sorting blocks of bindings now\r\nchecks for cancellation every 10000 compares and\r\naborts the sort if cancelled=true."},"comment":{"url":"https://api.github.com/repos/apache/jena/issues/comments/235293005","html_url":"https://github.com/apache/jena/pull/157#issuecomment-235293005","issue_url":"https://api.github.com/repos/apache/jena/issues/157","id":235293005,"user":{"login":"ehedgehog","id":455956,"avatar_url":"https://avatars.githubusercontent.com/u/455956?v=3","gravatar_id":"","url":"https://api.github.com/users/ehedgehog","html_url":"https://github.com/ehedgehog","followers_url":"https://api.github.com/users/ehedgehog/followers","following_url":"https://api.github.com/users/ehedgehog/following{/other_user}","gists_url":"https://api.github.com/users/ehedgehog/gists{/gist_id}","starred_url":"https://api.github.com/users/ehedgehog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehedgehog/subscriptions","organizations_url":"https://api.github.com/users/ehedgehog/orgs","repos_url":"https://api.github.com/users/ehedgehog/repos","events_url":"https://api.github.com/users/ehedgehog/events{/privacy}","received_events_url":"https://api.github.com/users/ehedgehog/received_events","type":"User","site_admin":false},"created_at":"2016-07-26T14:52:54Z","updated_at":"2016-07-26T14:52:54Z","body":"OK. Timing: I had writen tests that did not allow for garbage collection times and had also not allocated\r\nenough heap to the JVM running the timing test.\r\n\r\nHere's what I did. Create an array of 8M Bindings. Create a base BindingComparator with a \r\nSortCondition of ?v = \"x/\" + ((i * 223 * 359) & 0xffffff) where i is the index of the  \r\ncomparator -- this is so that sorting is predictable but telements are not already sorted.\r\nRun the GC and then sort the array using either the base comparator (A) or the\r\ncomparator  wrapped as an abortableComparator (B). Report the time taken.\r\nRun comparison 20 times AB AB AB AB ... Discard first 10 measurments as\r\nwarmup. The remaining sorts take 59-61 seconds with no visible bias to either A or B.\r\n\r\nSimilar results (that is, little difference between A and B) obtain using 2M bindings \r\nrather than 8M, and using a different generated values for the SortCondition.\r\n\r\nWe also compared timings of a typical query from our initial problem app; swichting\r\nfrom the Fuseki currently in use for this app to the code in this pull request,\r\nie with cancellable sorts, replaced runs of approximately 26.5 seconds with\r\nruns of approximately 27.7 seconds.\r\n\r\nI think this is enough to say that making sorts cancellable has an overhead of\r\n2-4%. Do we think that's OK ?\r\n\r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"ehedgehog"}}