{"action":"created","issue":{"url":"https://api.github.com/repos/emberjs/ember.js/issues/13666","repository_url":"https://api.github.com/repos/emberjs/ember.js","labels_url":"https://api.github.com/repos/emberjs/ember.js/issues/13666/labels{/name}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/13666/comments","events_url":"https://api.github.com/repos/emberjs/ember.js/issues/13666/events","html_url":"https://github.com/emberjs/ember.js/pull/13666","id":160170691,"number":13666,"title":"[FEATURE ember-string-ishtmlsafe] Added Ember.String.isHtmlSafe.","user":{"login":"workmanw","id":825487,"avatar_url":"https://avatars.githubusercontent.com/u/825487?v=3","gravatar_id":"","url":"https://api.github.com/users/workmanw","html_url":"https://github.com/workmanw","followers_url":"https://api.github.com/users/workmanw/followers","following_url":"https://api.github.com/users/workmanw/following{/other_user}","gists_url":"https://api.github.com/users/workmanw/gists{/gist_id}","starred_url":"https://api.github.com/users/workmanw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/workmanw/subscriptions","organizations_url":"https://api.github.com/users/workmanw/orgs","repos_url":"https://api.github.com/users/workmanw/repos","events_url":"https://api.github.com/users/workmanw/events{/privacy}","received_events_url":"https://api.github.com/users/workmanw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-06-14T12:37:44Z","updated_at":"2016-06-19T15:27:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/13666","html_url":"https://github.com/emberjs/ember.js/pull/13666","diff_url":"https://github.com/emberjs/ember.js/pull/13666.diff","patch_url":"https://github.com/emberjs/ember.js/pull/13666.patch"},"body":"RFC: https://github.com/emberjs/rfcs/pull/139\r\n\r\nThe feature is ready to go. I just need to figure out how to deprecate using:\r\n `var safeStr = new Ember.Handlebars.SafeString('<div>Hello</div>');` \r\n\r\nwithout breaking `safeStr instanceOf Ember.Handlebars.SafeString`. If anyone has thoughts on that I'd love to hear them. "},"comment":{"url":"https://api.github.com/repos/emberjs/ember.js/issues/comments/227003208","html_url":"https://github.com/emberjs/ember.js/pull/13666#issuecomment-227003208","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/13666","id":227003208,"user":{"login":"workmanw","id":825487,"avatar_url":"https://avatars.githubusercontent.com/u/825487?v=3","gravatar_id":"","url":"https://api.github.com/users/workmanw","html_url":"https://github.com/workmanw","followers_url":"https://api.github.com/users/workmanw/followers","following_url":"https://api.github.com/users/workmanw/following{/other_user}","gists_url":"https://api.github.com/users/workmanw/gists{/gist_id}","starred_url":"https://api.github.com/users/workmanw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/workmanw/subscriptions","organizations_url":"https://api.github.com/users/workmanw/orgs","repos_url":"https://api.github.com/users/workmanw/repos","events_url":"https://api.github.com/users/workmanw/events{/privacy}","received_events_url":"https://api.github.com/users/workmanw/received_events","type":"User","site_admin":false},"created_at":"2016-06-19T15:27:27Z","updated_at":"2016-06-19T15:27:27Z","body":"@rwjblue I converted the related `ember-htmlbars` tests over to `ember-glimmer` tests using the new harness. This could definitely use a review. A few things to call out that I had no idea about:\r\n\r\n* Should the `safe-string-test.js` and `string-test.js` be in `ember-glimmer/tests/compat` and `ember-glimmer/tests/utils` respectfully? These seem to be the first test files with non-integration tests added to `ember-glimmer`. I put them in `compat` and `utils` to maintain consistency w/ `ember-htmlbars`.\r\n* Additionally, I wasn't sure what test class to use because I couldn't really find other non-integration tests, so I went with `TestCase`.\r\n\r\nIs there someone I should ping for a review who is familiar with the new glimmer test stuff?\r\n\r\nI didn't squash these commits to make it easier to review the testing changes. Once I get the 👍 I'll happily squash them down."}}
{"actor":{"display_login":"workmanw"}}