{"action":"created","comment":{"url":"https://api.github.com/repos/jitsi/libjitsi/pulls/comments/77410025","id":77410025,"diff_hunk":"@@ -324,21 +321,16 @@ private SSRCDesc getSSRCDesc(long ssrc)\n      */\n     private Endpoint getEndpoint(String endpointId)\n     {\n-        Endpoint endpoint = endpoints.get(endpointId);\n-        if (endpoint == null)\n+        synchronized (endpoints)\n         {\n-            synchronized (endpoints)\n+            Endpoint endpoint = endpoints.get(endpointId);","path":"src/org/jitsi/impl/neomedia/recording/SynchronizerImpl.java","position":60,"original_position":60,"commit_id":"36aed379244c7a28d7d30439da350121c72e3e25","original_commit_id":"36aed379244c7a28d7d30439da350121c72e3e25","user":{"login":"lyubomir","id":3251887,"avatar_url":"https://avatars.githubusercontent.com/u/3251887?v=3","gravatar_id":"","url":"https://api.github.com/users/lyubomir","html_url":"https://github.com/lyubomir","followers_url":"https://api.github.com/users/lyubomir/followers","following_url":"https://api.github.com/users/lyubomir/following{/other_user}","gists_url":"https://api.github.com/users/lyubomir/gists{/gist_id}","starred_url":"https://api.github.com/users/lyubomir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyubomir/subscriptions","organizations_url":"https://api.github.com/users/lyubomir/orgs","repos_url":"https://api.github.com/users/lyubomir/repos","events_url":"https://api.github.com/users/lyubomir/events{/privacy}","received_events_url":"https://api.github.com/users/lyubomir/received_events","type":"User","site_admin":false},"body":"Unlike ssrcs, there's no protected block that does only reading so I don't think that you want the reads protected. Anyway, I'd like to mention getLocalTime again because there's an unprotected read from endpoints. Some analysis tools would flag such a synchronization as inconsistent.","created_at":"2016-09-02T20:51:04Z","updated_at":"2016-09-02T20:51:04Z","html_url":"https://github.com/jitsi/libjitsi/pull/196#discussion_r77410025","pull_request_url":"https://api.github.com/repos/jitsi/libjitsi/pulls/196","_links":{"self":{"href":"https://api.github.com/repos/jitsi/libjitsi/pulls/comments/77410025"},"html":{"href":"https://github.com/jitsi/libjitsi/pull/196#discussion_r77410025"},"pull_request":{"href":"https://api.github.com/repos/jitsi/libjitsi/pulls/196"}}},"pull_request":{"url":"https://api.github.com/repos/jitsi/libjitsi/pulls/196","id":83486160,"html_url":"https://github.com/jitsi/libjitsi/pull/196","diff_url":"https://github.com/jitsi/libjitsi/pull/196.diff","patch_url":"https://github.com/jitsi/libjitsi/pull/196.patch","issue_url":"https://api.github.com/repos/jitsi/libjitsi/issues/196","number":196,"state":"open","locked":false,"title":"Sync fixes","user":{"login":"bgrozev","id":3264699,"avatar_url":"https://avatars.githubusercontent.com/u/3264699?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrozev","html_url":"https://github.com/bgrozev","followers_url":"https://api.github.com/users/bgrozev/followers","following_url":"https://api.github.com/users/bgrozev/following{/other_user}","gists_url":"https://api.github.com/users/bgrozev/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrozev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrozev/subscriptions","organizations_url":"https://api.github.com/users/bgrozev/orgs","repos_url":"https://api.github.com/users/bgrozev/repos","events_url":"https://api.github.com/users/bgrozev/events{/privacy}","received_events_url":"https://api.github.com/users/bgrozev/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-31T16:29:33Z","updated_at":"2016-09-02T20:51:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6922a7061d2501782fce7ee81cb3b137212b4de7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jitsi/libjitsi/pulls/196/commits","review_comments_url":"https://api.github.com/repos/jitsi/libjitsi/pulls/196/comments","review_comment_url":"https://api.github.com/repos/jitsi/libjitsi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jitsi/libjitsi/issues/196/comments","statuses_url":"https://api.github.com/repos/jitsi/libjitsi/statuses/36aed379244c7a28d7d30439da350121c72e3e25","head":{"label":"bgrozev:sync-fixes","ref":"sync-fixes","sha":"36aed379244c7a28d7d30439da350121c72e3e25","user":{"login":"bgrozev","id":3264699,"avatar_url":"https://avatars.githubusercontent.com/u/3264699?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrozev","html_url":"https://github.com/bgrozev","followers_url":"https://api.github.com/users/bgrozev/followers","following_url":"https://api.github.com/users/bgrozev/following{/other_user}","gists_url":"https://api.github.com/users/bgrozev/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrozev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrozev/subscriptions","organizations_url":"https://api.github.com/users/bgrozev/orgs","repos_url":"https://api.github.com/users/bgrozev/repos","events_url":"https://api.github.com/users/bgrozev/events{/privacy}","received_events_url":"https://api.github.com/users/bgrozev/received_events","type":"User","site_admin":false},"repo":{"id":22766792,"name":"libjitsi","full_name":"bgrozev/libjitsi","owner":{"login":"bgrozev","id":3264699,"avatar_url":"https://avatars.githubusercontent.com/u/3264699?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrozev","html_url":"https://github.com/bgrozev","followers_url":"https://api.github.com/users/bgrozev/followers","following_url":"https://api.github.com/users/bgrozev/following{/other_user}","gists_url":"https://api.github.com/users/bgrozev/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrozev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrozev/subscriptions","organizations_url":"https://api.github.com/users/bgrozev/orgs","repos_url":"https://api.github.com/users/bgrozev/repos","events_url":"https://api.github.com/users/bgrozev/events{/privacy}","received_events_url":"https://api.github.com/users/bgrozev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bgrozev/libjitsi","description":"libjitsi is an advanced Java media library for secure real-time audio/video communication. It allows applications to capture, playback, stream, encode/decode and encrypt audio and video flows. It also allows for advanced features such as audio mixing, handling multiple streams, participation in audio and video conferences.  Originally libjitsi was part of the Jitsi client source code but we decided to spin it off so that other projects can also use it.  libjitsi is distributed under the terms of the LGPL. ","fork":true,"url":"https://api.github.com/repos/bgrozev/libjitsi","forks_url":"https://api.github.com/repos/bgrozev/libjitsi/forks","keys_url":"https://api.github.com/repos/bgrozev/libjitsi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bgrozev/libjitsi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bgrozev/libjitsi/teams","hooks_url":"https://api.github.com/repos/bgrozev/libjitsi/hooks","issue_events_url":"https://api.github.com/repos/bgrozev/libjitsi/issues/events{/number}","events_url":"https://api.github.com/repos/bgrozev/libjitsi/events","assignees_url":"https://api.github.com/repos/bgrozev/libjitsi/assignees{/user}","branches_url":"https://api.github.com/repos/bgrozev/libjitsi/branches{/branch}","tags_url":"https://api.github.com/repos/bgrozev/libjitsi/tags","blobs_url":"https://api.github.com/repos/bgrozev/libjitsi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bgrozev/libjitsi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bgrozev/libjitsi/git/refs{/sha}","trees_url":"https://api.github.com/repos/bgrozev/libjitsi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bgrozev/libjitsi/statuses/{sha}","languages_url":"https://api.github.com/repos/bgrozev/libjitsi/languages","stargazers_url":"https://api.github.com/repos/bgrozev/libjitsi/stargazers","contributors_url":"https://api.github.com/repos/bgrozev/libjitsi/contributors","subscribers_url":"https://api.github.com/repos/bgrozev/libjitsi/subscribers","subscription_url":"https://api.github.com/repos/bgrozev/libjitsi/subscription","commits_url":"https://api.github.com/repos/bgrozev/libjitsi/commits{/sha}","git_commits_url":"https://api.github.com/repos/bgrozev/libjitsi/git/commits{/sha}","comments_url":"https://api.github.com/repos/bgrozev/libjitsi/comments{/number}","issue_comment_url":"https://api.github.com/repos/bgrozev/libjitsi/issues/comments{/number}","contents_url":"https://api.github.com/repos/bgrozev/libjitsi/contents/{+path}","compare_url":"https://api.github.com/repos/bgrozev/libjitsi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bgrozev/libjitsi/merges","archive_url":"https://api.github.com/repos/bgrozev/libjitsi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bgrozev/libjitsi/downloads","issues_url":"https://api.github.com/repos/bgrozev/libjitsi/issues{/number}","pulls_url":"https://api.github.com/repos/bgrozev/libjitsi/pulls{/number}","milestones_url":"https://api.github.com/repos/bgrozev/libjitsi/milestones{/number}","notifications_url":"https://api.github.com/repos/bgrozev/libjitsi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bgrozev/libjitsi/labels{/name}","releases_url":"https://api.github.com/repos/bgrozev/libjitsi/releases{/id}","deployments_url":"https://api.github.com/repos/bgrozev/libjitsi/deployments","created_at":"2014-08-08T18:05:08Z","updated_at":"2016-02-17T20:05:39Z","pushed_at":"2016-08-31T16:29:08Z","git_url":"git://github.com/bgrozev/libjitsi.git","ssh_url":"git@github.com:bgrozev/libjitsi.git","clone_url":"https://github.com/bgrozev/libjitsi.git","svn_url":"https://github.com/bgrozev/libjitsi","homepage":null,"size":83908,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jitsi:master","ref":"master","sha":"bb5d7b153a33cb72acefacffe381e53729090d44","user":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars.githubusercontent.com/u/3671647?v=3","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"repo":{"id":9657553,"name":"libjitsi","full_name":"jitsi/libjitsi","owner":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars.githubusercontent.com/u/3671647?v=3","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jitsi/libjitsi","description":"Advanced Java media library for secure real-time audio/video communication.","fork":false,"url":"https://api.github.com/repos/jitsi/libjitsi","forks_url":"https://api.github.com/repos/jitsi/libjitsi/forks","keys_url":"https://api.github.com/repos/jitsi/libjitsi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jitsi/libjitsi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jitsi/libjitsi/teams","hooks_url":"https://api.github.com/repos/jitsi/libjitsi/hooks","issue_events_url":"https://api.github.com/repos/jitsi/libjitsi/issues/events{/number}","events_url":"https://api.github.com/repos/jitsi/libjitsi/events","assignees_url":"https://api.github.com/repos/jitsi/libjitsi/assignees{/user}","branches_url":"https://api.github.com/repos/jitsi/libjitsi/branches{/branch}","tags_url":"https://api.github.com/repos/jitsi/libjitsi/tags","blobs_url":"https://api.github.com/repos/jitsi/libjitsi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jitsi/libjitsi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jitsi/libjitsi/git/refs{/sha}","trees_url":"https://api.github.com/repos/jitsi/libjitsi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jitsi/libjitsi/statuses/{sha}","languages_url":"https://api.github.com/repos/jitsi/libjitsi/languages","stargazers_url":"https://api.github.com/repos/jitsi/libjitsi/stargazers","contributors_url":"https://api.github.com/repos/jitsi/libjitsi/contributors","subscribers_url":"https://api.github.com/repos/jitsi/libjitsi/subscribers","subscription_url":"https://api.github.com/repos/jitsi/libjitsi/subscription","commits_url":"https://api.github.com/repos/jitsi/libjitsi/commits{/sha}","git_commits_url":"https://api.github.com/repos/jitsi/libjitsi/git/commits{/sha}","comments_url":"https://api.github.com/repos/jitsi/libjitsi/comments{/number}","issue_comment_url":"https://api.github.com/repos/jitsi/libjitsi/issues/comments{/number}","contents_url":"https://api.github.com/repos/jitsi/libjitsi/contents/{+path}","compare_url":"https://api.github.com/repos/jitsi/libjitsi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jitsi/libjitsi/merges","archive_url":"https://api.github.com/repos/jitsi/libjitsi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jitsi/libjitsi/downloads","issues_url":"https://api.github.com/repos/jitsi/libjitsi/issues{/number}","pulls_url":"https://api.github.com/repos/jitsi/libjitsi/pulls{/number}","milestones_url":"https://api.github.com/repos/jitsi/libjitsi/milestones{/number}","notifications_url":"https://api.github.com/repos/jitsi/libjitsi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jitsi/libjitsi/labels{/name}","releases_url":"https://api.github.com/repos/jitsi/libjitsi/releases{/id}","deployments_url":"https://api.github.com/repos/jitsi/libjitsi/deployments","created_at":"2013-04-24T21:01:15Z","updated_at":"2016-09-01T04:53:13Z","pushed_at":"2016-09-01T01:49:08Z","git_url":"git://github.com/jitsi/libjitsi.git","ssh_url":"git@github.com:jitsi/libjitsi.git","clone_url":"https://github.com/jitsi/libjitsi.git","svn_url":"https://github.com/jitsi/libjitsi","homepage":"","size":85125,"stargazers_count":187,"watchers_count":187,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":121,"mirror_url":null,"open_issues_count":16,"forks":121,"open_issues":16,"watchers":187,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jitsi/libjitsi/pulls/196"},"html":{"href":"https://github.com/jitsi/libjitsi/pull/196"},"issue":{"href":"https://api.github.com/repos/jitsi/libjitsi/issues/196"},"comments":{"href":"https://api.github.com/repos/jitsi/libjitsi/issues/196/comments"},"review_comments":{"href":"https://api.github.com/repos/jitsi/libjitsi/pulls/196/comments"},"review_comment":{"href":"https://api.github.com/repos/jitsi/libjitsi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jitsi/libjitsi/pulls/196/commits"},"statuses":{"href":"https://api.github.com/repos/jitsi/libjitsi/statuses/36aed379244c7a28d7d30439da350121c72e3e25"}}}}
{"actor":{"display_login":"lyubomir"}}