{"action":"created","comment":{"url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/pulls/comments/83740008","pull_request_review_id":4563718,"id":83740008,"diff_hunk":"@@ -1,74 +1,94 @@\n-Puppet::Type.type(:package).provide(:brewcask,\n-                                    :parent => :brewcommon,\n-                                    :source => :brewcommon) do\n-  desc \"Package management using HomeBrew casks on OS X\"\n+require 'puppet/provider/package'\n \n-  has_feature :install_options\n+Puppet::Type.type(:package).provide(:brewcommon,","path":"lib/puppet/provider/package/brewcask.rb","position":8,"original_position":8,"commit_id":"dab49875fa5284fff15f06772895ceb71b352685","original_commit_id":"dab49875fa5284fff15f06772895ceb71b352685","user":{"login":"TheKevJames","id":3341822,"avatar_url":"https://avatars.githubusercontent.com/u/3341822?v=3","gravatar_id":"","url":"https://api.github.com/users/TheKevJames","html_url":"https://github.com/TheKevJames","followers_url":"https://api.github.com/users/TheKevJames/followers","following_url":"https://api.github.com/users/TheKevJames/following{/other_user}","gists_url":"https://api.github.com/users/TheKevJames/gists{/gist_id}","starred_url":"https://api.github.com/users/TheKevJames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheKevJames/subscriptions","organizations_url":"https://api.github.com/users/TheKevJames/orgs","repos_url":"https://api.github.com/users/TheKevJames/repos","events_url":"https://api.github.com/users/TheKevJames/events{/privacy}","received_events_url":"https://api.github.com/users/TheKevJames/received_events","type":"User","site_admin":false},"body":"This looks like you accidentally copied `brewcommon` into `brewcask.rb`?","created_at":"2016-10-17T21:37:34Z","updated_at":"2016-10-17T21:38:27Z","html_url":"https://github.com/TheKevJames/puppet-homebrew/pull/52#discussion_r83740008","pull_request_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/pulls/52","_links":{"self":{"href":"https://api.github.com/repos/TheKevJames/puppet-homebrew/pulls/comments/83740008"},"html":{"href":"https://github.com/TheKevJames/puppet-homebrew/pull/52#discussion_r83740008"},"pull_request":{"href":"https://api.github.com/repos/TheKevJames/puppet-homebrew/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/pulls/52","id":86500205,"html_url":"https://github.com/TheKevJames/puppet-homebrew/pull/52","diff_url":"https://github.com/TheKevJames/puppet-homebrew/pull/52.diff","patch_url":"https://github.com/TheKevJames/puppet-homebrew/pull/52.patch","issue_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/issues/52","number":52,"state":"open","locked":false,"title":"Fix package not found error","user":{"login":"jordigg","id":404331,"avatar_url":"https://avatars.githubusercontent.com/u/404331?v=3","gravatar_id":"","url":"https://api.github.com/users/jordigg","html_url":"https://github.com/jordigg","followers_url":"https://api.github.com/users/jordigg/followers","following_url":"https://api.github.com/users/jordigg/following{/other_user}","gists_url":"https://api.github.com/users/jordigg/gists{/gist_id}","starred_url":"https://api.github.com/users/jordigg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordigg/subscriptions","organizations_url":"https://api.github.com/users/jordigg/orgs","repos_url":"https://api.github.com/users/jordigg/repos","events_url":"https://api.github.com/users/jordigg/events{/privacy}","received_events_url":"https://api.github.com/users/jordigg/received_events","type":"User","site_admin":false},"body":"After splitting the output returned by the commands run via Brew another error appeared because we'll still parsing the brew cask output looking for error messages.\r\n\r\nTested on fresh machines on 10.11 and 10.12. Brew and brew cask apps get installed successfully.","created_at":"2016-09-23T11:55:57Z","updated_at":"2016-10-17T21:38:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e00060570099aeb3cae9f66626f5e2b24cac89aa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/pulls/52/commits","review_comments_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/pulls/52/comments","review_comment_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/issues/52/comments","statuses_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/statuses/dab49875fa5284fff15f06772895ceb71b352685","head":{"label":"improbable-io:fix_package_not_found","ref":"fix_package_not_found","sha":"dab49875fa5284fff15f06772895ceb71b352685","user":{"login":"improbable-io","id":7579705,"avatar_url":"https://avatars.githubusercontent.com/u/7579705?v=3","gravatar_id":"","url":"https://api.github.com/users/improbable-io","html_url":"https://github.com/improbable-io","followers_url":"https://api.github.com/users/improbable-io/followers","following_url":"https://api.github.com/users/improbable-io/following{/other_user}","gists_url":"https://api.github.com/users/improbable-io/gists{/gist_id}","starred_url":"https://api.github.com/users/improbable-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/improbable-io/subscriptions","organizations_url":"https://api.github.com/users/improbable-io/orgs","repos_url":"https://api.github.com/users/improbable-io/repos","events_url":"https://api.github.com/users/improbable-io/events{/privacy}","received_events_url":"https://api.github.com/users/improbable-io/received_events","type":"Organization","site_admin":false},"repo":{"id":67955567,"name":"puppet-homebrew","full_name":"improbable-io/puppet-homebrew","owner":{"login":"improbable-io","id":7579705,"avatar_url":"https://avatars.githubusercontent.com/u/7579705?v=3","gravatar_id":"","url":"https://api.github.com/users/improbable-io","html_url":"https://github.com/improbable-io","followers_url":"https://api.github.com/users/improbable-io/followers","following_url":"https://api.github.com/users/improbable-io/following{/other_user}","gists_url":"https://api.github.com/users/improbable-io/gists{/gist_id}","starred_url":"https://api.github.com/users/improbable-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/improbable-io/subscriptions","organizations_url":"https://api.github.com/users/improbable-io/orgs","repos_url":"https://api.github.com/users/improbable-io/repos","events_url":"https://api.github.com/users/improbable-io/events{/privacy}","received_events_url":"https://api.github.com/users/improbable-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/improbable-io/puppet-homebrew","description":"Homebrew (+ brewcask! +taps!) package installer and provider","fork":true,"url":"https://api.github.com/repos/improbable-io/puppet-homebrew","forks_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/forks","keys_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/teams","hooks_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/hooks","issue_events_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/events","assignees_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/tags","blobs_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/languages","stargazers_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/stargazers","contributors_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/contributors","subscribers_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/subscribers","subscription_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/subscription","commits_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/issues/comments{/number}","contents_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/merges","archive_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/downloads","issues_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/labels{/name}","releases_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/releases{/id}","deployments_url":"https://api.github.com/repos/improbable-io/puppet-homebrew/deployments","created_at":"2016-09-11T21:33:17Z","updated_at":"2016-09-11T21:33:19Z","pushed_at":"2016-10-17T21:33:04Z","git_url":"git://github.com/improbable-io/puppet-homebrew.git","ssh_url":"git@github.com:improbable-io/puppet-homebrew.git","clone_url":"https://github.com/improbable-io/puppet-homebrew.git","svn_url":"https://github.com/improbable-io/puppet-homebrew","homepage":"","size":113,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TheKevJames:master","ref":"master","sha":"b1610d1a4a9d1d112213d369b6a21bab30c3bdcd","user":{"login":"TheKevJames","id":3341822,"avatar_url":"https://avatars.githubusercontent.com/u/3341822?v=3","gravatar_id":"","url":"https://api.github.com/users/TheKevJames","html_url":"https://github.com/TheKevJames","followers_url":"https://api.github.com/users/TheKevJames/followers","following_url":"https://api.github.com/users/TheKevJames/following{/other_user}","gists_url":"https://api.github.com/users/TheKevJames/gists{/gist_id}","starred_url":"https://api.github.com/users/TheKevJames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheKevJames/subscriptions","organizations_url":"https://api.github.com/users/TheKevJames/orgs","repos_url":"https://api.github.com/users/TheKevJames/repos","events_url":"https://api.github.com/users/TheKevJames/events{/privacy}","received_events_url":"https://api.github.com/users/TheKevJames/received_events","type":"User","site_admin":false},"repo":{"id":51730162,"name":"puppet-homebrew","full_name":"TheKevJames/puppet-homebrew","owner":{"login":"TheKevJames","id":3341822,"avatar_url":"https://avatars.githubusercontent.com/u/3341822?v=3","gravatar_id":"","url":"https://api.github.com/users/TheKevJames","html_url":"https://github.com/TheKevJames","followers_url":"https://api.github.com/users/TheKevJames/followers","following_url":"https://api.github.com/users/TheKevJames/following{/other_user}","gists_url":"https://api.github.com/users/TheKevJames/gists{/gist_id}","starred_url":"https://api.github.com/users/TheKevJames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheKevJames/subscriptions","organizations_url":"https://api.github.com/users/TheKevJames/orgs","repos_url":"https://api.github.com/users/TheKevJames/repos","events_url":"https://api.github.com/users/TheKevJames/events{/privacy}","received_events_url":"https://api.github.com/users/TheKevJames/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TheKevJames/puppet-homebrew","description":"Homebrew (+ brewcask! +taps!) package installer and provider","fork":false,"url":"https://api.github.com/repos/TheKevJames/puppet-homebrew","forks_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/forks","keys_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/teams","hooks_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/hooks","issue_events_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/events","assignees_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/tags","blobs_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/languages","stargazers_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/stargazers","contributors_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/contributors","subscribers_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/subscribers","subscription_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/subscription","commits_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/merges","archive_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/downloads","issues_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/labels{/name}","releases_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/releases{/id}","deployments_url":"https://api.github.com/repos/TheKevJames/puppet-homebrew/deployments","created_at":"2016-02-15T04:12:08Z","updated_at":"2016-08-13T06:31:38Z","pushed_at":"2016-10-17T21:33:05Z","git_url":"git://github.com/TheKevJames/puppet-homebrew.git","ssh_url":"git@github.com:TheKevJames/puppet-homebrew.git","clone_url":"https://github.com/TheKevJames/puppet-homebrew.git","svn_url":"https://github.com/TheKevJames/puppet-homebrew","homepage":"","size":115,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":14,"forks":4,"open_issues":14,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TheKevJames/puppet-homebrew/pulls/52"},"html":{"href":"https://github.com/TheKevJames/puppet-homebrew/pull/52"},"issue":{"href":"https://api.github.com/repos/TheKevJames/puppet-homebrew/issues/52"},"comments":{"href":"https://api.github.com/repos/TheKevJames/puppet-homebrew/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/TheKevJames/puppet-homebrew/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/TheKevJames/puppet-homebrew/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TheKevJames/puppet-homebrew/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/TheKevJames/puppet-homebrew/statuses/dab49875fa5284fff15f06772895ceb71b352685"}}}}
{"actor":{"display_login":"TheKevJames"}}