{"action":"created","issue":{"url":"https://api.github.com/repos/Blizzard/node-rdkafka/issues/72","repository_url":"https://api.github.com/repos/Blizzard/node-rdkafka","labels_url":"https://api.github.com/repos/Blizzard/node-rdkafka/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/Blizzard/node-rdkafka/issues/72/comments","events_url":"https://api.github.com/repos/Blizzard/node-rdkafka/issues/72/events","html_url":"https://github.com/Blizzard/node-rdkafka/pull/72","id":194078947,"number":72,"title":"Added message payload in the delivery report object","user":{"login":"edoardocomar","id":6661532,"avatar_url":"https://avatars.githubusercontent.com/u/6661532?v=3","gravatar_id":"","url":"https://api.github.com/users/edoardocomar","html_url":"https://github.com/edoardocomar","followers_url":"https://api.github.com/users/edoardocomar/followers","following_url":"https://api.github.com/users/edoardocomar/following{/other_user}","gists_url":"https://api.github.com/users/edoardocomar/gists{/gist_id}","starred_url":"https://api.github.com/users/edoardocomar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edoardocomar/subscriptions","organizations_url":"https://api.github.com/users/edoardocomar/orgs","repos_url":"https://api.github.com/users/edoardocomar/repos","events_url":"https://api.github.com/users/edoardocomar/events{/privacy}","received_events_url":"https://api.github.com/users/edoardocomar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-12-07T15:25:39Z","updated_at":"2016-12-08T01:54:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Blizzard/node-rdkafka/pulls/72","html_url":"https://github.com/Blizzard/node-rdkafka/pull/72","diff_url":"https://github.com/Blizzard/node-rdkafka/pull/72.diff","patch_url":"https://github.com/Blizzard/node-rdkafka/pull/72.patch"},"body":"changed the delivery report callback API, inserted err argument before\r\nreport\r\n\r\ndr_msg_cb configuration used as flag to copy or not the msg payload in\r\nthe delivery report\r\n\r\nmessage payload not copied on the error path (see callbacks.cc TODO)\r\n\r\nfixes #70 \r\ncommitted for discussion, cleanup (eg public flag in Dispatcher TODO)\r\n\r\ndeveloped with @mimaison"},"comment":{"url":"https://api.github.com/repos/Blizzard/node-rdkafka/issues/comments/265630964","html_url":"https://github.com/Blizzard/node-rdkafka/pull/72#issuecomment-265630964","issue_url":"https://api.github.com/repos/Blizzard/node-rdkafka/issues/72","id":265630964,"user":{"login":"edoardocomar","id":6661532,"avatar_url":"https://avatars.githubusercontent.com/u/6661532?v=3","gravatar_id":"","url":"https://api.github.com/users/edoardocomar","html_url":"https://github.com/edoardocomar","followers_url":"https://api.github.com/users/edoardocomar/followers","following_url":"https://api.github.com/users/edoardocomar/following{/other_user}","gists_url":"https://api.github.com/users/edoardocomar/gists{/gist_id}","starred_url":"https://api.github.com/users/edoardocomar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edoardocomar/subscriptions","organizations_url":"https://api.github.com/users/edoardocomar/orgs","repos_url":"https://api.github.com/users/edoardocomar/repos","events_url":"https://api.github.com/users/edoardocomar/events{/privacy}","received_events_url":"https://api.github.com/users/edoardocomar/received_events","type":"User","site_admin":false},"created_at":"2016-12-08T01:54:48Z","updated_at":"2016-12-08T01:54:48Z","body":"@webmakersteve \r\nabout the event, in your snippet above\r\n```\r\n    this._client.onDeliveryReport(function onDeliveryReport(err, report) {\r\n      if (err) {\r\n        self.emit('error', LibrdKafkaError.create(err));\r\n      } else {\r\n        self.outstandingMessages--;\r\n        self.emit('delivery-report', err, report);\r\n      }\r\n    });\r\n```\r\nwhy having err in the else when it's always falsy ?\r\n"}}
{"actor":{"display_login":"edoardocomar"}}