{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/86662880","pull_request_review_id":7312572,"id":86662880,"diff_hunk":"@@ -632,6 +646,13 @@ def split(self, X, y, groups=None):\n \n         test : ndarray\n             The testing set indices for that split.\n+\n+        Note\n+        ----\n+\n+        Multiple calls to the ``split`` method will not return identical\n+        training or testing sets unless ``random_state`` is set to an integer","path":"sklearn/model_selection/_split.py","position":37,"original_position":37,"commit_id":"4f188250b3d2bcd4d9855032bf85f9a0df1adf6c","original_commit_id":"4f188250b3d2bcd4d9855032bf85f9a0df1adf6c","user":{"login":"jnothman","id":78827,"avatar_url":"https://avatars.githubusercontent.com/u/78827?v=3","gravatar_id":"","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following{/other_user}","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User","site_admin":false},"body":"only if shuffle=True","created_at":"2016-11-05T11:20:15Z","updated_at":"2016-11-05T11:23:49Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/7823#discussion_r86662880","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7823","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/86662880"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/7823#discussion_r86662880"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7823"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7823","id":92317667,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/7823","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/7823.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/7823.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7823","number":7823,"state":"open","locked":false,"title":"[MRG] Add few more tests + Documentation","user":{"login":"raghavrv","id":9487348,"avatar_url":"https://avatars.githubusercontent.com/u/9487348?v=3","gravatar_id":"","url":"https://api.github.com/users/raghavrv","html_url":"https://github.com/raghavrv","followers_url":"https://api.github.com/users/raghavrv/followers","following_url":"https://api.github.com/users/raghavrv/following{/other_user}","gists_url":"https://api.github.com/users/raghavrv/gists{/gist_id}","starred_url":"https://api.github.com/users/raghavrv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raghavrv/subscriptions","organizations_url":"https://api.github.com/users/raghavrv/orgs","repos_url":"https://api.github.com/users/raghavrv/repos","events_url":"https://api.github.com/users/raghavrv/events{/privacy}","received_events_url":"https://api.github.com/users/raghavrv/received_events","type":"User","site_admin":false},"body":"**TODO**\r\n\r\n- [x] Addres Joel's comment https://github.com/scikit-learn/scikit-learn/issues/7808#issuecomment-257568422\r\n- [x] Document that multiple split calls may not return identical train/test sets if `random_state` is not set.\r\n- [x] There was a warning that suppressed a test. Using `np.testing.assert_equal` to test for equality of nested lists fixes that.\r\n- [x] The word rank in the mock table view of `cv_results_` is assumed [as a link](http://scikit-learn.org/0.18/modules/generated/sklearn.model_selection.GridSearchCV.html#sklearn.model_selection.GridSearchCV).\r\n\r\n@jnothman @amueller Pl. review :)","created_at":"2016-11-04T10:45:02Z","updated_at":"2016-11-05T11:23:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d85c9a65432801e0d62fdac4fdb7bc2ddf65ece2","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones/22","html_url":"https://github.com/scikit-learn/scikit-learn/milestones/0.18.1","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones/22/labels","id":2046567,"number":22,"title":"0.18.1","description":"Urgent fixes to bugs and web site issues.","creator":{"login":"jnothman","id":78827,"avatar_url":"https://avatars.githubusercontent.com/u/78827?v=3","gravatar_id":"","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following{/other_user}","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":58,"state":"open","created_at":"2016-10-04T11:55:58Z","updated_at":"2016-11-04T10:45:27Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7823/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7823/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7823/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/4f188250b3d2bcd4d9855032bf85f9a0df1adf6c","head":{"label":"raghavrv:model_selection_touchups","ref":"model_selection_touchups","sha":"4f188250b3d2bcd4d9855032bf85f9a0df1adf6c","user":{"login":"raghavrv","id":9487348,"avatar_url":"https://avatars.githubusercontent.com/u/9487348?v=3","gravatar_id":"","url":"https://api.github.com/users/raghavrv","html_url":"https://github.com/raghavrv","followers_url":"https://api.github.com/users/raghavrv/followers","following_url":"https://api.github.com/users/raghavrv/following{/other_user}","gists_url":"https://api.github.com/users/raghavrv/gists{/gist_id}","starred_url":"https://api.github.com/users/raghavrv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raghavrv/subscriptions","organizations_url":"https://api.github.com/users/raghavrv/orgs","repos_url":"https://api.github.com/users/raghavrv/repos","events_url":"https://api.github.com/users/raghavrv/events{/privacy}","received_events_url":"https://api.github.com/users/raghavrv/received_events","type":"User","site_admin":false},"repo":{"id":26038110,"name":"scikit-learn","full_name":"raghavrv/scikit-learn","owner":{"login":"raghavrv","id":9487348,"avatar_url":"https://avatars.githubusercontent.com/u/9487348?v=3","gravatar_id":"","url":"https://api.github.com/users/raghavrv","html_url":"https://github.com/raghavrv","followers_url":"https://api.github.com/users/raghavrv/followers","following_url":"https://api.github.com/users/raghavrv/following{/other_user}","gists_url":"https://api.github.com/users/raghavrv/gists{/gist_id}","starred_url":"https://api.github.com/users/raghavrv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raghavrv/subscriptions","organizations_url":"https://api.github.com/users/raghavrv/orgs","repos_url":"https://api.github.com/users/raghavrv/repos","events_url":"https://api.github.com/users/raghavrv/events{/privacy}","received_events_url":"https://api.github.com/users/raghavrv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/raghavrv/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/raghavrv/scikit-learn","forks_url":"https://api.github.com/repos/raghavrv/scikit-learn/forks","keys_url":"https://api.github.com/repos/raghavrv/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raghavrv/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raghavrv/scikit-learn/teams","hooks_url":"https://api.github.com/repos/raghavrv/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/raghavrv/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/raghavrv/scikit-learn/events","assignees_url":"https://api.github.com/repos/raghavrv/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/raghavrv/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/raghavrv/scikit-learn/tags","blobs_url":"https://api.github.com/repos/raghavrv/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raghavrv/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raghavrv/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/raghavrv/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raghavrv/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/raghavrv/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/raghavrv/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/raghavrv/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/raghavrv/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/raghavrv/scikit-learn/subscription","commits_url":"https://api.github.com/repos/raghavrv/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/raghavrv/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/raghavrv/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/raghavrv/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/raghavrv/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/raghavrv/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raghavrv/scikit-learn/merges","archive_url":"https://api.github.com/repos/raghavrv/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raghavrv/scikit-learn/downloads","issues_url":"https://api.github.com/repos/raghavrv/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/raghavrv/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/raghavrv/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/raghavrv/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raghavrv/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/raghavrv/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/raghavrv/scikit-learn/deployments","created_at":"2014-11-01T00:56:31Z","updated_at":"2016-04-27T18:29:41Z","pushed_at":"2016-11-04T17:02:54Z","git_url":"git://github.com/raghavrv/scikit-learn.git","ssh_url":"git@github.com:raghavrv/scikit-learn.git","clone_url":"https://github.com/raghavrv/scikit-learn.git","svn_url":"https://github.com/raghavrv/scikit-learn","homepage":"http://scikit-learn.org","size":94310,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"d7c956afc8c67642bbd42fd9bacb007b5fbc443a","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2016-11-05T10:47:32Z","pushed_at":"2016-11-05T10:44:54Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":127836,"stargazers_count":14525,"watchers_count":14525,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8243,"mirror_url":null,"open_issues_count":1107,"forks":8243,"open_issues":1107,"watchers":14525,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7823"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/7823"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7823"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7823/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7823/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7823/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/4f188250b3d2bcd4d9855032bf85f9a0df1adf6c"}}}}
{"actor":{"display_login":"jnothman"}}