{"action":"created","comment":{"url":"https://api.github.com/repos/django/djangoproject.com/pulls/comments/52432813","id":52432813,"diff_hunk":"@@ -0,0 +1,23 @@\n+import base64\n+import hashlib\n+\n+from django.contrib.auth.hashers import PBKDF2PasswordHasher\n+from django.utils.crypto import pbkdf2\n+from django.utils.encoding import force_bytes\n+\n+\n+class PBKDF2WrappedSHA1PasswordHasher(PBKDF2PasswordHasher):\n+    algorithm = 'pbkdf2_wrapped_sha1'\n+\n+    def encode_sha1_hash(self, sha1_hash, salt, iterations=None):","path":"accounts/hashers.py","position":12,"original_position":12,"commit_id":"51608594927b3d4572e4e570218fa83808026997","original_commit_id":"51608594927b3d4572e4e570218fa83808026997","user":{"login":"apollo13","id":81547,"avatar_url":"https://avatars.githubusercontent.com/u/81547?v=3","gravatar_id":"","url":"https://api.github.com/users/apollo13","html_url":"https://github.com/apollo13","followers_url":"https://api.github.com/users/apollo13/followers","following_url":"https://api.github.com/users/apollo13/following{/other_user}","gists_url":"https://api.github.com/users/apollo13/gists{/gist_id}","starred_url":"https://api.github.com/users/apollo13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollo13/subscriptions","organizations_url":"https://api.github.com/users/apollo13/orgs","repos_url":"https://api.github.com/users/apollo13/repos","events_url":"https://api.github.com/users/apollo13/events{/privacy}","received_events_url":"https://api.github.com/users/apollo13/received_events","type":"User","site_admin":false},"body":"Isn't that just a copy of the original `encode` method?, ie couldn't you just call `super` in `encode` below?","created_at":"2016-02-10T09:26:09Z","updated_at":"2016-02-10T09:26:09Z","html_url":"https://github.com/django/djangoproject.com/pull/634#discussion_r52432813","pull_request_url":"https://api.github.com/repos/django/djangoproject.com/pulls/634","_links":{"self":{"href":"https://api.github.com/repos/django/djangoproject.com/pulls/comments/52432813"},"html":{"href":"https://github.com/django/djangoproject.com/pull/634#discussion_r52432813"},"pull_request":{"href":"https://api.github.com/repos/django/djangoproject.com/pulls/634"}}},"pull_request":{"url":"https://api.github.com/repos/django/djangoproject.com/pulls/634","id":58795428,"html_url":"https://github.com/django/djangoproject.com/pull/634","diff_url":"https://github.com/django/djangoproject.com/pull/634.diff","patch_url":"https://github.com/django/djangoproject.com/pull/634.patch","issue_url":"https://api.github.com/repos/django/djangoproject.com/issues/634","number":634,"state":"open","locked":false,"title":"Added a wrapped password hasher to upgrade SHA1 hashes.","user":{"login":"timgraham","id":411869,"avatar_url":"https://avatars.githubusercontent.com/u/411869?v=3","gravatar_id":"","url":"https://api.github.com/users/timgraham","html_url":"https://github.com/timgraham","followers_url":"https://api.github.com/users/timgraham/followers","following_url":"https://api.github.com/users/timgraham/following{/other_user}","gists_url":"https://api.github.com/users/timgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/timgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timgraham/subscriptions","organizations_url":"https://api.github.com/users/timgraham/orgs","repos_url":"https://api.github.com/users/timgraham/repos","events_url":"https://api.github.com/users/timgraham/events{/privacy}","received_events_url":"https://api.github.com/users/timgraham/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-09T19:22:49Z","updated_at":"2016-02-10T09:26:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84cb955558bf6ae094760300053d615151c7a630","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/django/djangoproject.com/pulls/634/commits","review_comments_url":"https://api.github.com/repos/django/djangoproject.com/pulls/634/comments","review_comment_url":"https://api.github.com/repos/django/djangoproject.com/pulls/comments{/number}","comments_url":"https://api.github.com/repos/django/djangoproject.com/issues/634/comments","statuses_url":"https://api.github.com/repos/django/djangoproject.com/statuses/51608594927b3d4572e4e570218fa83808026997","head":{"label":"timgraham:632","ref":"632","sha":"51608594927b3d4572e4e570218fa83808026997","user":{"login":"timgraham","id":411869,"avatar_url":"https://avatars.githubusercontent.com/u/411869?v=3","gravatar_id":"","url":"https://api.github.com/users/timgraham","html_url":"https://github.com/timgraham","followers_url":"https://api.github.com/users/timgraham/followers","following_url":"https://api.github.com/users/timgraham/following{/other_user}","gists_url":"https://api.github.com/users/timgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/timgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timgraham/subscriptions","organizations_url":"https://api.github.com/users/timgraham/orgs","repos_url":"https://api.github.com/users/timgraham/repos","events_url":"https://api.github.com/users/timgraham/events{/privacy}","received_events_url":"https://api.github.com/users/timgraham/received_events","type":"User","site_admin":false},"repo":{"id":16510963,"name":"djangoproject.com","full_name":"timgraham/djangoproject.com","owner":{"login":"timgraham","id":411869,"avatar_url":"https://avatars.githubusercontent.com/u/411869?v=3","gravatar_id":"","url":"https://api.github.com/users/timgraham","html_url":"https://github.com/timgraham","followers_url":"https://api.github.com/users/timgraham/followers","following_url":"https://api.github.com/users/timgraham/following{/other_user}","gists_url":"https://api.github.com/users/timgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/timgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timgraham/subscriptions","organizations_url":"https://api.github.com/users/timgraham/orgs","repos_url":"https://api.github.com/users/timgraham/repos","events_url":"https://api.github.com/users/timgraham/events{/privacy}","received_events_url":"https://api.github.com/users/timgraham/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timgraham/djangoproject.com","description":"Source code to djangoproject.com","fork":true,"url":"https://api.github.com/repos/timgraham/djangoproject.com","forks_url":"https://api.github.com/repos/timgraham/djangoproject.com/forks","keys_url":"https://api.github.com/repos/timgraham/djangoproject.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timgraham/djangoproject.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timgraham/djangoproject.com/teams","hooks_url":"https://api.github.com/repos/timgraham/djangoproject.com/hooks","issue_events_url":"https://api.github.com/repos/timgraham/djangoproject.com/issues/events{/number}","events_url":"https://api.github.com/repos/timgraham/djangoproject.com/events","assignees_url":"https://api.github.com/repos/timgraham/djangoproject.com/assignees{/user}","branches_url":"https://api.github.com/repos/timgraham/djangoproject.com/branches{/branch}","tags_url":"https://api.github.com/repos/timgraham/djangoproject.com/tags","blobs_url":"https://api.github.com/repos/timgraham/djangoproject.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timgraham/djangoproject.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timgraham/djangoproject.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/timgraham/djangoproject.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timgraham/djangoproject.com/statuses/{sha}","languages_url":"https://api.github.com/repos/timgraham/djangoproject.com/languages","stargazers_url":"https://api.github.com/repos/timgraham/djangoproject.com/stargazers","contributors_url":"https://api.github.com/repos/timgraham/djangoproject.com/contributors","subscribers_url":"https://api.github.com/repos/timgraham/djangoproject.com/subscribers","subscription_url":"https://api.github.com/repos/timgraham/djangoproject.com/subscription","commits_url":"https://api.github.com/repos/timgraham/djangoproject.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/timgraham/djangoproject.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/timgraham/djangoproject.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/timgraham/djangoproject.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/timgraham/djangoproject.com/contents/{+path}","compare_url":"https://api.github.com/repos/timgraham/djangoproject.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timgraham/djangoproject.com/merges","archive_url":"https://api.github.com/repos/timgraham/djangoproject.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timgraham/djangoproject.com/downloads","issues_url":"https://api.github.com/repos/timgraham/djangoproject.com/issues{/number}","pulls_url":"https://api.github.com/repos/timgraham/djangoproject.com/pulls{/number}","milestones_url":"https://api.github.com/repos/timgraham/djangoproject.com/milestones{/number}","notifications_url":"https://api.github.com/repos/timgraham/djangoproject.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timgraham/djangoproject.com/labels{/name}","releases_url":"https://api.github.com/repos/timgraham/djangoproject.com/releases{/id}","deployments_url":"https://api.github.com/repos/timgraham/djangoproject.com/deployments","created_at":"2014-02-04T12:24:34Z","updated_at":"2015-08-25T23:10:17Z","pushed_at":"2016-02-10T00:45:27Z","git_url":"git://github.com/timgraham/djangoproject.com.git","ssh_url":"git@github.com:timgraham/djangoproject.com.git","clone_url":"https://github.com/timgraham/djangoproject.com.git","svn_url":"https://github.com/timgraham/djangoproject.com","homepage":"http://djangoproject.com/","size":14601,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"django:master","ref":"master","sha":"e51eba97f7e226d2e9deb31f8c23b1e00df04b9c","user":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"repo":{"id":690903,"name":"djangoproject.com","full_name":"django/djangoproject.com","owner":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/django/djangoproject.com","description":"Source code to djangoproject.com","fork":false,"url":"https://api.github.com/repos/django/djangoproject.com","forks_url":"https://api.github.com/repos/django/djangoproject.com/forks","keys_url":"https://api.github.com/repos/django/djangoproject.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/django/djangoproject.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/django/djangoproject.com/teams","hooks_url":"https://api.github.com/repos/django/djangoproject.com/hooks","issue_events_url":"https://api.github.com/repos/django/djangoproject.com/issues/events{/number}","events_url":"https://api.github.com/repos/django/djangoproject.com/events","assignees_url":"https://api.github.com/repos/django/djangoproject.com/assignees{/user}","branches_url":"https://api.github.com/repos/django/djangoproject.com/branches{/branch}","tags_url":"https://api.github.com/repos/django/djangoproject.com/tags","blobs_url":"https://api.github.com/repos/django/djangoproject.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/django/djangoproject.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/django/djangoproject.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/django/djangoproject.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/django/djangoproject.com/statuses/{sha}","languages_url":"https://api.github.com/repos/django/djangoproject.com/languages","stargazers_url":"https://api.github.com/repos/django/djangoproject.com/stargazers","contributors_url":"https://api.github.com/repos/django/djangoproject.com/contributors","subscribers_url":"https://api.github.com/repos/django/djangoproject.com/subscribers","subscription_url":"https://api.github.com/repos/django/djangoproject.com/subscription","commits_url":"https://api.github.com/repos/django/djangoproject.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/django/djangoproject.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/django/djangoproject.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/django/djangoproject.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/django/djangoproject.com/contents/{+path}","compare_url":"https://api.github.com/repos/django/djangoproject.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/django/djangoproject.com/merges","archive_url":"https://api.github.com/repos/django/djangoproject.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/django/djangoproject.com/downloads","issues_url":"https://api.github.com/repos/django/djangoproject.com/issues{/number}","pulls_url":"https://api.github.com/repos/django/djangoproject.com/pulls{/number}","milestones_url":"https://api.github.com/repos/django/djangoproject.com/milestones{/number}","notifications_url":"https://api.github.com/repos/django/djangoproject.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/django/djangoproject.com/labels{/name}","releases_url":"https://api.github.com/repos/django/djangoproject.com/releases{/id}","deployments_url":"https://api.github.com/repos/django/djangoproject.com/deployments","created_at":"2010-05-28T11:27:09Z","updated_at":"2016-02-09T21:15:39Z","pushed_at":"2016-02-10T00:45:28Z","git_url":"git://github.com/django/djangoproject.com.git","ssh_url":"git@github.com:django/djangoproject.com.git","clone_url":"https://github.com/django/djangoproject.com.git","svn_url":"https://github.com/django/djangoproject.com","homepage":"https://www.djangoproject.com/","size":15824,"stargazers_count":574,"watchers_count":574,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":240,"mirror_url":null,"open_issues_count":38,"forks":240,"open_issues":38,"watchers":574,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/django/djangoproject.com/pulls/634"},"html":{"href":"https://github.com/django/djangoproject.com/pull/634"},"issue":{"href":"https://api.github.com/repos/django/djangoproject.com/issues/634"},"comments":{"href":"https://api.github.com/repos/django/djangoproject.com/issues/634/comments"},"review_comments":{"href":"https://api.github.com/repos/django/djangoproject.com/pulls/634/comments"},"review_comment":{"href":"https://api.github.com/repos/django/djangoproject.com/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/django/djangoproject.com/pulls/634/commits"},"statuses":{"href":"https://api.github.com/repos/django/djangoproject.com/statuses/51608594927b3d4572e4e570218fa83808026997"}}}}