{"action":"created","comment":{"url":"https://api.github.com/repos/go-authboss/authboss/pulls/comments/62437258","id":62437258,"diff_hunk":"@@ -130,17 +132,21 @@ func (c *Confirm) afterRegister(ctx *authboss.Context) error {\n \t\treturn err\n \t}\n \n-\tgoConfirmEmail(c, email, base64.URLEncoding.EncodeToString(token))\n+\tgoConfirmEmail(c, ctx, email, base64.URLEncoding.EncodeToString(token))\n \n \treturn nil\n }\n \n-var goConfirmEmail = func(c *Confirm, to, token string) {\n-\tgo c.confirmEmail(to, token)\n+var goConfirmEmail = func(c *Confirm, ctx *authboss.Context, to, token string) {\n+\tif ctx.DisableGoroutines {\n+\t\tc.confirmEmail(ctx, to, token)\n+\t} else {\n+\t\tgo c.confirmEmail(ctx, to, token)\n+\t}\n }\n \n // confirmEmail sends a confirmation e-mail.\n-func (c *Confirm) confirmEmail(to, token string) {\n+func (c *Confirm) confirmEmail(ctx *authboss.Context, to, token string) {","path":"confirm/confirm.go","position":49,"original_position":49,"commit_id":"8ed6deac0845b19a3adec11fe7fbcf542102768c","original_commit_id":"8ed6deac0845b19a3adec11fe7fbcf542102768c","user":{"login":"aarondl","id":699706,"avatar_url":"https://avatars.githubusercontent.com/u/699706?v=3","gravatar_id":"","url":"https://api.github.com/users/aarondl","html_url":"https://github.com/aarondl","followers_url":"https://api.github.com/users/aarondl/followers","following_url":"https://api.github.com/users/aarondl/following{/other_user}","gists_url":"https://api.github.com/users/aarondl/gists{/gist_id}","starred_url":"https://api.github.com/users/aarondl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aarondl/subscriptions","organizations_url":"https://api.github.com/users/aarondl/orgs","repos_url":"https://api.github.com/users/aarondl/repos","events_url":"https://api.github.com/users/aarondl/events{/privacy}","received_events_url":"https://api.github.com/users/aarondl/received_events","type":"User","site_admin":false},"body":"Sorry, my bad this isn't the breakage. It just looked similar. Annotated the real failure below.","created_at":"2016-05-08T19:47:39Z","updated_at":"2016-05-08T19:47:39Z","html_url":"https://github.com/go-authboss/authboss/pull/83#discussion_r62437258","pull_request_url":"https://api.github.com/repos/go-authboss/authboss/pulls/83","_links":{"self":{"href":"https://api.github.com/repos/go-authboss/authboss/pulls/comments/62437258"},"html":{"href":"https://github.com/go-authboss/authboss/pull/83#discussion_r62437258"},"pull_request":{"href":"https://api.github.com/repos/go-authboss/authboss/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/go-authboss/authboss/pulls/83","id":68799554,"html_url":"https://github.com/go-authboss/authboss/pull/83","diff_url":"https://github.com/go-authboss/authboss/pull/83.diff","patch_url":"https://github.com/go-authboss/authboss/pull/83.patch","issue_url":"https://api.github.com/repos/go-authboss/authboss/issues/83","number":83,"state":"open","locked":false,"title":"Additional -Maker properties on Config for GAE support","user":{"login":"buu700","id":415435,"avatar_url":"https://avatars.githubusercontent.com/u/415435?v=3","gravatar_id":"","url":"https://api.github.com/users/buu700","html_url":"https://github.com/buu700","followers_url":"https://api.github.com/users/buu700/followers","following_url":"https://api.github.com/users/buu700/following{/other_user}","gists_url":"https://api.github.com/users/buu700/gists{/gist_id}","starred_url":"https://api.github.com/users/buu700/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buu700/subscriptions","organizations_url":"https://api.github.com/users/buu700/orgs","repos_url":"https://api.github.com/users/buu700/repos","events_url":"https://api.github.com/users/buu700/events{/privacy}","received_events_url":"https://api.github.com/users/buu700/received_events","type":"User","site_admin":false},"body":"I tried to keep everything about these new properties as consistent with CookieStoreMaker/SessionStoreMaker as I could. However, I may very well have structured this in such a way that the new -Maker functions won't always have been called by the time they're needed to have been called. I didn't do any testing or thorough investigation beyond some greps to make sure that my change wasn't obviously wrong, as I figure that with your better grasp on the broader structure and context of the code, issues of that nature will be more immediately apparent to you when you review this.","created_at":"2016-05-04T01:15:25Z","updated_at":"2016-05-08T19:47:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32e0566ef5f9bad2c39c1d7518b5301400adecc2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/go-authboss/authboss/pulls/83/commits","review_comments_url":"https://api.github.com/repos/go-authboss/authboss/pulls/83/comments","review_comment_url":"https://api.github.com/repos/go-authboss/authboss/pulls/comments{/number}","comments_url":"https://api.github.com/repos/go-authboss/authboss/issues/83/comments","statuses_url":"https://api.github.com/repos/go-authboss/authboss/statuses/8ed6deac0845b19a3adec11fe7fbcf542102768c","head":{"label":"buu700:master","ref":"master","sha":"8ed6deac0845b19a3adec11fe7fbcf542102768c","user":{"login":"buu700","id":415435,"avatar_url":"https://avatars.githubusercontent.com/u/415435?v=3","gravatar_id":"","url":"https://api.github.com/users/buu700","html_url":"https://github.com/buu700","followers_url":"https://api.github.com/users/buu700/followers","following_url":"https://api.github.com/users/buu700/following{/other_user}","gists_url":"https://api.github.com/users/buu700/gists{/gist_id}","starred_url":"https://api.github.com/users/buu700/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buu700/subscriptions","organizations_url":"https://api.github.com/users/buu700/orgs","repos_url":"https://api.github.com/users/buu700/repos","events_url":"https://api.github.com/users/buu700/events{/privacy}","received_events_url":"https://api.github.com/users/buu700/received_events","type":"User","site_admin":false},"repo":{"id":52416120,"name":"authboss","full_name":"buu700/authboss","owner":{"login":"buu700","id":415435,"avatar_url":"https://avatars.githubusercontent.com/u/415435?v=3","gravatar_id":"","url":"https://api.github.com/users/buu700","html_url":"https://github.com/buu700","followers_url":"https://api.github.com/users/buu700/followers","following_url":"https://api.github.com/users/buu700/following{/other_user}","gists_url":"https://api.github.com/users/buu700/gists{/gist_id}","starred_url":"https://api.github.com/users/buu700/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buu700/subscriptions","organizations_url":"https://api.github.com/users/buu700/orgs","repos_url":"https://api.github.com/users/buu700/repos","events_url":"https://api.github.com/users/buu700/events{/privacy}","received_events_url":"https://api.github.com/users/buu700/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/buu700/authboss","description":"The boss of http auth.","fork":true,"url":"https://api.github.com/repos/buu700/authboss","forks_url":"https://api.github.com/repos/buu700/authboss/forks","keys_url":"https://api.github.com/repos/buu700/authboss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buu700/authboss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buu700/authboss/teams","hooks_url":"https://api.github.com/repos/buu700/authboss/hooks","issue_events_url":"https://api.github.com/repos/buu700/authboss/issues/events{/number}","events_url":"https://api.github.com/repos/buu700/authboss/events","assignees_url":"https://api.github.com/repos/buu700/authboss/assignees{/user}","branches_url":"https://api.github.com/repos/buu700/authboss/branches{/branch}","tags_url":"https://api.github.com/repos/buu700/authboss/tags","blobs_url":"https://api.github.com/repos/buu700/authboss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buu700/authboss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buu700/authboss/git/refs{/sha}","trees_url":"https://api.github.com/repos/buu700/authboss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buu700/authboss/statuses/{sha}","languages_url":"https://api.github.com/repos/buu700/authboss/languages","stargazers_url":"https://api.github.com/repos/buu700/authboss/stargazers","contributors_url":"https://api.github.com/repos/buu700/authboss/contributors","subscribers_url":"https://api.github.com/repos/buu700/authboss/subscribers","subscription_url":"https://api.github.com/repos/buu700/authboss/subscription","commits_url":"https://api.github.com/repos/buu700/authboss/commits{/sha}","git_commits_url":"https://api.github.com/repos/buu700/authboss/git/commits{/sha}","comments_url":"https://api.github.com/repos/buu700/authboss/comments{/number}","issue_comment_url":"https://api.github.com/repos/buu700/authboss/issues/comments{/number}","contents_url":"https://api.github.com/repos/buu700/authboss/contents/{+path}","compare_url":"https://api.github.com/repos/buu700/authboss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buu700/authboss/merges","archive_url":"https://api.github.com/repos/buu700/authboss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buu700/authboss/downloads","issues_url":"https://api.github.com/repos/buu700/authboss/issues{/number}","pulls_url":"https://api.github.com/repos/buu700/authboss/pulls{/number}","milestones_url":"https://api.github.com/repos/buu700/authboss/milestones{/number}","notifications_url":"https://api.github.com/repos/buu700/authboss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buu700/authboss/labels{/name}","releases_url":"https://api.github.com/repos/buu700/authboss/releases{/id}","deployments_url":"https://api.github.com/repos/buu700/authboss/deployments","created_at":"2016-02-24T05:12:22Z","updated_at":"2016-02-24T05:12:23Z","pushed_at":"2016-05-07T06:12:21Z","git_url":"git://github.com/buu700/authboss.git","ssh_url":"git@github.com:buu700/authboss.git","clone_url":"https://github.com/buu700/authboss.git","svn_url":"https://github.com/buu700/authboss","homepage":"","size":420,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"go-authboss:master","ref":"master","sha":"45dedd0c2d946baf8585b5ef15b5ebf140944d2e","user":{"login":"go-authboss","id":10378281,"avatar_url":"https://avatars.githubusercontent.com/u/10378281?v=3","gravatar_id":"","url":"https://api.github.com/users/go-authboss","html_url":"https://github.com/go-authboss","followers_url":"https://api.github.com/users/go-authboss/followers","following_url":"https://api.github.com/users/go-authboss/following{/other_user}","gists_url":"https://api.github.com/users/go-authboss/gists{/gist_id}","starred_url":"https://api.github.com/users/go-authboss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-authboss/subscriptions","organizations_url":"https://api.github.com/users/go-authboss/orgs","repos_url":"https://api.github.com/users/go-authboss/repos","events_url":"https://api.github.com/users/go-authboss/events{/privacy}","received_events_url":"https://api.github.com/users/go-authboss/received_events","type":"Organization","site_admin":false},"repo":{"id":28735637,"name":"authboss","full_name":"go-authboss/authboss","owner":{"login":"go-authboss","id":10378281,"avatar_url":"https://avatars.githubusercontent.com/u/10378281?v=3","gravatar_id":"","url":"https://api.github.com/users/go-authboss","html_url":"https://github.com/go-authboss","followers_url":"https://api.github.com/users/go-authboss/followers","following_url":"https://api.github.com/users/go-authboss/following{/other_user}","gists_url":"https://api.github.com/users/go-authboss/gists{/gist_id}","starred_url":"https://api.github.com/users/go-authboss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-authboss/subscriptions","organizations_url":"https://api.github.com/users/go-authboss/orgs","repos_url":"https://api.github.com/users/go-authboss/repos","events_url":"https://api.github.com/users/go-authboss/events{/privacy}","received_events_url":"https://api.github.com/users/go-authboss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/go-authboss/authboss","description":"The boss of http auth.","fork":false,"url":"https://api.github.com/repos/go-authboss/authboss","forks_url":"https://api.github.com/repos/go-authboss/authboss/forks","keys_url":"https://api.github.com/repos/go-authboss/authboss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-authboss/authboss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-authboss/authboss/teams","hooks_url":"https://api.github.com/repos/go-authboss/authboss/hooks","issue_events_url":"https://api.github.com/repos/go-authboss/authboss/issues/events{/number}","events_url":"https://api.github.com/repos/go-authboss/authboss/events","assignees_url":"https://api.github.com/repos/go-authboss/authboss/assignees{/user}","branches_url":"https://api.github.com/repos/go-authboss/authboss/branches{/branch}","tags_url":"https://api.github.com/repos/go-authboss/authboss/tags","blobs_url":"https://api.github.com/repos/go-authboss/authboss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-authboss/authboss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-authboss/authboss/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-authboss/authboss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-authboss/authboss/statuses/{sha}","languages_url":"https://api.github.com/repos/go-authboss/authboss/languages","stargazers_url":"https://api.github.com/repos/go-authboss/authboss/stargazers","contributors_url":"https://api.github.com/repos/go-authboss/authboss/contributors","subscribers_url":"https://api.github.com/repos/go-authboss/authboss/subscribers","subscription_url":"https://api.github.com/repos/go-authboss/authboss/subscription","commits_url":"https://api.github.com/repos/go-authboss/authboss/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-authboss/authboss/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-authboss/authboss/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-authboss/authboss/issues/comments{/number}","contents_url":"https://api.github.com/repos/go-authboss/authboss/contents/{+path}","compare_url":"https://api.github.com/repos/go-authboss/authboss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-authboss/authboss/merges","archive_url":"https://api.github.com/repos/go-authboss/authboss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-authboss/authboss/downloads","issues_url":"https://api.github.com/repos/go-authboss/authboss/issues{/number}","pulls_url":"https://api.github.com/repos/go-authboss/authboss/pulls{/number}","milestones_url":"https://api.github.com/repos/go-authboss/authboss/milestones{/number}","notifications_url":"https://api.github.com/repos/go-authboss/authboss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-authboss/authboss/labels{/name}","releases_url":"https://api.github.com/repos/go-authboss/authboss/releases{/id}","deployments_url":"https://api.github.com/repos/go-authboss/authboss/deployments","created_at":"2015-01-03T05:12:02Z","updated_at":"2016-05-05T17:57:39Z","pushed_at":"2016-05-08T19:37:14Z","git_url":"git://github.com/go-authboss/authboss.git","ssh_url":"git@github.com:go-authboss/authboss.git","clone_url":"https://github.com/go-authboss/authboss.git","svn_url":"https://github.com/go-authboss/authboss","homepage":"","size":420,"stargazers_count":601,"watchers_count":601,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":11,"forks":19,"open_issues":11,"watchers":601,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/go-authboss/authboss/pulls/83"},"html":{"href":"https://github.com/go-authboss/authboss/pull/83"},"issue":{"href":"https://api.github.com/repos/go-authboss/authboss/issues/83"},"comments":{"href":"https://api.github.com/repos/go-authboss/authboss/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/go-authboss/authboss/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/go-authboss/authboss/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/go-authboss/authboss/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/go-authboss/authboss/statuses/8ed6deac0845b19a3adec11fe7fbcf542102768c"}}}}