{"action":"created","issue":{"url":"https://api.github.com/repos/rtfpessoa/diff2html/issues/90","repository_url":"https://api.github.com/repos/rtfpessoa/diff2html","labels_url":"https://api.github.com/repos/rtfpessoa/diff2html/issues/90/labels{/name}","comments_url":"https://api.github.com/repos/rtfpessoa/diff2html/issues/90/comments","events_url":"https://api.github.com/repos/rtfpessoa/diff2html/issues/90/events","html_url":"https://github.com/rtfpessoa/diff2html/issues/90","id":165079458,"number":90,"title":"Binary files not listed in the diff","user":{"login":"rmpestano","id":1592273,"avatar_url":"https://avatars.githubusercontent.com/u/1592273?v=3","gravatar_id":"","url":"https://api.github.com/users/rmpestano","html_url":"https://github.com/rmpestano","followers_url":"https://api.github.com/users/rmpestano/followers","following_url":"https://api.github.com/users/rmpestano/following{/other_user}","gists_url":"https://api.github.com/users/rmpestano/gists{/gist_id}","starred_url":"https://api.github.com/users/rmpestano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmpestano/subscriptions","organizations_url":"https://api.github.com/users/rmpestano/orgs","repos_url":"https://api.github.com/users/rmpestano/repos","events_url":"https://api.github.com/users/rmpestano/events{/privacy}","received_events_url":"https://api.github.com/users/rmpestano/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-07-12T13:24:09Z","updated_at":"2016-07-12T17:36:52Z","closed_at":"2016-07-12T15:23:34Z","body":"Hi,\r\n\r\nI've made a diff from the following commit: https://github.com/rmpestano/last-changes-plugin/commit/1d620edfc16476650af3aa696389f42535f6034d\r\n\r\nAs you can see there are two files changes. The problem I'm facing is that diff2html is ignoring the binary file diff.\r\n\r\nHere is the diff I've generated:\r\n\r\n```\r\ndiff --git a/README.adoc b/README.adoc\r\nindex be99c75..9bbce57 100644\r\n--- a/README.adoc\r\n+++ b/README.adoc\r\n@@ -20,7 +20,7 @@\r\n \r\n Last Changes is a *Jenkin plugin* that shows _rich VCS diffs_ between builds.\r\n \r\n-IMPORTANT: Only `Git` and `Svn` are supported.\r\n+IMPORTANT: Only `Git` and `Svn` based projects are supported.\r\n \r\n == Introduction\r\n \r\n@@ -37,23 +37,23 @@\r\n \r\n == Objectives\r\n \r\n-The main objective of this plugin is to have fast access to what has changed on a Jenkins build.\r\n+The main objective of this plugin is to have _fast_ access to what has changed on a Jenkins build.\r\n \r\n Another interesting aspect is that it can easily help to find the `root cause` of a `failling build` by highlighting what has changed.\r\n \r\n-Also the plugin _shines_ in a https://en.wikipedia.org/wiki/Continuous_delivery[*continuous delivery*^] environment, where each _commit_ generates a release candidate.\r\n+And finally the plugin _shines_ in a https://en.wikipedia.org/wiki/Continuous_delivery[*continuous delivery*^] environment, where each _commit_ generates a release candidate.\r\n \r\n \r\n == How it works?\r\n \r\n-. This plugin expects `git` or `svn` based builds.\r\n+. This plugin expects `git` or `svn` based builds (a.k.a _Source Code Management_ configuration section).\r\n . While your job runs the plugin reads your build workspace to retrieve the current VCS revision;\r\n . The diff between `actual` and `previous` revisions will be stored;\r\n . The `diff` for each build can be viewed later in html format.\r\n \r\n IMPORTANT: To get most from this plugin use `periodically SCM pooling` to trigger your builds, http://www.nailedtothex.org/roller/kyle/entry/articles-jenkins-poll[more details here^].\r\n \r\n-NOTE: The plugin *always* compare current revision with previous one even no new commit has been made.\r\n+WARNING: The plugin *always* compare current revision with previous one even no new commit has been made.\r\n \r\n == Usage\r\n \r\ndiff --git a/last-changes-config.png b/last-changes-config.png\r\nindex 322248b..56fc1f2 100644\r\n--- a/last-changes-config.png\r\n+++ b/last-changes-config.png\r\nBinary files differ\r\n\r\n```\r\n\r\nHere is the output where binary file change is ignored:\r\n\r\n![generated-diff](https://cloud.githubusercontent.com/assets/1592273/16768402/a23cc9ee-481a-11e6-9f68-e024d5057d8e.png)\r\n\r\n\r\nThe html source from the page that uses diff2html can be found here:\r\n\r\n```\r\njQuery(document).ready(function() {\r\n                  var sidePanelTD=document.getElementById('side-panel');\r\n                               if(sidePanelTD) {\r\n                                 sidePanelTD.parentNode.removeChild(sidePanelTD);\r\n                               }\r\n                var diff2htmlUi = new Diff2HtmlUI({diff: buildChanges});\r\n\r\n                    diff2htmlUi.draw('#line-by-line', {\r\n                         inputFormat: 'json',\r\n                         outputFormat: 'line-by-line',\r\n                         showFiles: true,\r\n                         synchronisedScroll: false,\r\n                         matchWordsThreshold: '0.25',\r\n                         matchingMaxComparisons: '1000.0',\r\n                         matching: 'lines'\r\n                         }\r\n                        );\r\n                    diff2htmlUi.fileListCloseable('#line-by-line', false);\r\n                    diff2htmlUi.highlightCode('#line-by-line');\r\n\r\n                }); //end documentReady\r\n\r\n                var buildChanges = \"diff --git a\\/README.adoc b\\/README.adoc\\nindex be99c75..9bbce57 100644\\n--- a\\/README.adoc\\n+++ b\\/README.adoc\\n@@ -20,7 +20,7 @@\\n \\r\\n Last Changes is a *Jenkin plugin* that shows _rich VCS diffs_ between builds.\\r\\n \\r\\n-IMPORTANT: Only `Git` and `Svn` are supported.\\r\\n+IMPORTANT: Only `Git` and `Svn` based projects are supported.\\r\\n \\r\\n == Introduction\\r\\n \\r\\n@@ -37,23 +37,23 @@\\n \\r\\n == Objectives\\r\\n \\r\\n-The main objective of this plugin is to have fast access to what has changed on a Jenkins build.\\r\\n+The main objective of this plugin is to have _fast_ access to what has changed on a Jenkins build.\\r\\n \\r\\n Another interesting aspect is that it can easily help to find the `root cause` of a `failling build` by highlighting what has changed.\\r\\n \\r\\n-Also the plugin _shines_ in a https:\\/\\/en.wikipedia.org\\/wiki\\/Continuous_delivery[*continuous delivery*^] environment, where each _commit_ generates a release candidate.\\r\\n+And finally the plugin _shines_ in a https:\\/\\/en.wikipedia.org\\/wiki\\/Continuous_delivery[*continuous delivery*^] environment, where each _commit_ generates a release candidate.\\r\\n \\r\\n \\r\\n == How it works?\\r\\n \\r\\n-. This plugin expects `git` or `svn` based builds.\\r\\n+. This plugin expects `git` or `svn` based builds (a.k.a _Source Code Management_ configuration section).\\r\\n . While your job runs the plugin reads your build workspace to retrieve the current VCS revision;\\r\\n . The diff between `actual` and `previous` revisions will be stored;\\r\\n . The `diff` for each build can be viewed later in html format.\\r\\n \\r\\n IMPORTANT: To get most from this plugin use `periodically SCM pooling` to trigger your builds, http:\\/\\/www.nailedtothex.org\\/roller\\/kyle\\/entry\\/articles-jenkins-poll[more details here^].\\r\\n \\r\\n-NOTE: The plugin *always* compare current revision with previous one even no new commit has been made.\\r\\n+WARNING: The plugin *always* compare current revision with previous one even no new commit has been made.\\r\\n \\r\\n == Usage\\r\\n \\r\\ndiff --git a\\/last-changes-config.png b\\/last-changes-config.png\\nindex 322248b..56fc1f2 100644\\n--- a\\/last-changes-config.png\\n+++ b\\/last-changes-config.png\\nBinary files differ\\n\";\r\n```\r\n\r\nCan you see something wrong?\r\n\r\nthanks in advance.\r\n"},"comment":{"url":"https://api.github.com/repos/rtfpessoa/diff2html/issues/comments/232120768","html_url":"https://github.com/rtfpessoa/diff2html/issues/90#issuecomment-232120768","issue_url":"https://api.github.com/repos/rtfpessoa/diff2html/issues/90","id":232120768,"user":{"login":"rtfpessoa","id":902384,"avatar_url":"https://avatars.githubusercontent.com/u/902384?v=3","gravatar_id":"","url":"https://api.github.com/users/rtfpessoa","html_url":"https://github.com/rtfpessoa","followers_url":"https://api.github.com/users/rtfpessoa/followers","following_url":"https://api.github.com/users/rtfpessoa/following{/other_user}","gists_url":"https://api.github.com/users/rtfpessoa/gists{/gist_id}","starred_url":"https://api.github.com/users/rtfpessoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtfpessoa/subscriptions","organizations_url":"https://api.github.com/users/rtfpessoa/orgs","repos_url":"https://api.github.com/users/rtfpessoa/repos","events_url":"https://api.github.com/users/rtfpessoa/events{/privacy}","received_events_url":"https://api.github.com/users/rtfpessoa/received_events","type":"User","site_admin":false},"created_at":"2016-07-12T17:36:52Z","updated_at":"2016-07-12T17:36:52Z","body":"That is \"expected\" behaviour.\r\n\r\nIf I cannot find `@@ ........ @@` I log that error.\r\n\r\nMaybe I can log it only If the line starts with `@` and ignore it there is no suck line, like in binary files."}}
{"actor":{"display_login":"rtfpessoa"}}