{"action":"created","comment":{"url":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/comments/89016339","pull_request_review_id":9569777,"id":89016339,"diff_hunk":"@@ -1,5 +1,6 @@\n defmodule Thrift.Generator.BinaryProtocolTest do\n-  use ExUnit.Case, async: true\n+  use ThriftTestCase, cleanup: false\n+  # use ExUnit.Case, async: true","path":"test/generator/binary_protocol_test.exs","position":4,"original_position":4,"commit_id":"993aa728e20d5fd5dabeebada08d1867b9564e6f","original_commit_id":"993aa728e20d5fd5dabeebada08d1867b9564e6f","user":{"login":"jparise","id":10311,"avatar_url":"https://avatars.githubusercontent.com/u/10311?v=3","gravatar_id":"","url":"https://api.github.com/users/jparise","html_url":"https://github.com/jparise","followers_url":"https://api.github.com/users/jparise/followers","following_url":"https://api.github.com/users/jparise/following{/other_user}","gists_url":"https://api.github.com/users/jparise/gists{/gist_id}","starred_url":"https://api.github.com/users/jparise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jparise/subscriptions","organizations_url":"https://api.github.com/users/jparise/orgs","repos_url":"https://api.github.com/users/jparise/repos","events_url":"https://api.github.com/users/jparise/events{/privacy}","received_events_url":"https://api.github.com/users/jparise/received_events","type":"User","site_admin":false},"body":"Drop this?","created_at":"2016-11-21T23:53:36Z","updated_at":"2016-11-21T23:53:49Z","html_url":"https://github.com/pinterest/elixir-thrift/pull/47#discussion_r89016339","pull_request_url":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/47","_links":{"self":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/comments/89016339"},"html":{"href":"https://github.com/pinterest/elixir-thrift/pull/47#discussion_r89016339"},"pull_request":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/47"}}},"pull_request":{"url":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/47","id":94717053,"html_url":"https://github.com/pinterest/elixir-thrift/pull/47","diff_url":"https://github.com/pinterest/elixir-thrift/pull/47.diff","patch_url":"https://github.com/pinterest/elixir-thrift/pull/47.patch","issue_url":"https://api.github.com/repos/pinterest/elixir-thrift/issues/47","number":47,"state":"open","locked":false,"title":"More work on deserialization","user":{"login":"pguillory","id":304366,"avatar_url":"https://avatars.githubusercontent.com/u/304366?v=3","gravatar_id":"","url":"https://api.github.com/users/pguillory","html_url":"https://github.com/pguillory","followers_url":"https://api.github.com/users/pguillory/followers","following_url":"https://api.github.com/users/pguillory/following{/other_user}","gists_url":"https://api.github.com/users/pguillory/gists{/gist_id}","starred_url":"https://api.github.com/users/pguillory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pguillory/subscriptions","organizations_url":"https://api.github.com/users/pguillory/orgs","repos_url":"https://api.github.com/users/pguillory/repos","events_url":"https://api.github.com/users/pguillory/events{/privacy}","received_events_url":"https://api.github.com/users/pguillory/received_events","type":"User","site_admin":false},"body":"- Filled in some missing functionality, like deserializing lists of sets or maps.\r\n- Added a little documentation. It doesn't communicate the idea well at the\r\n  moment.\r\n- Re-organized a bit.\r\n- Cleaned up whitespace and commented out code.","created_at":"2016-11-21T23:15:09Z","updated_at":"2016-11-21T23:53:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2892b62f41d92e9f796f3c960cca21f95cefeae3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/47/commits","review_comments_url":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/47/comments","review_comment_url":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pinterest/elixir-thrift/issues/47/comments","statuses_url":"https://api.github.com/repos/pinterest/elixir-thrift/statuses/993aa728e20d5fd5dabeebada08d1867b9564e6f","head":{"label":"pguillory:deserialization","ref":"deserialization","sha":"993aa728e20d5fd5dabeebada08d1867b9564e6f","user":{"login":"pguillory","id":304366,"avatar_url":"https://avatars.githubusercontent.com/u/304366?v=3","gravatar_id":"","url":"https://api.github.com/users/pguillory","html_url":"https://github.com/pguillory","followers_url":"https://api.github.com/users/pguillory/followers","following_url":"https://api.github.com/users/pguillory/following{/other_user}","gists_url":"https://api.github.com/users/pguillory/gists{/gist_id}","starred_url":"https://api.github.com/users/pguillory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pguillory/subscriptions","organizations_url":"https://api.github.com/users/pguillory/orgs","repos_url":"https://api.github.com/users/pguillory/repos","events_url":"https://api.github.com/users/pguillory/events{/privacy}","received_events_url":"https://api.github.com/users/pguillory/received_events","type":"User","site_admin":false},"repo":{"id":73316748,"name":"elixir-thrift","full_name":"pguillory/elixir-thrift","owner":{"login":"pguillory","id":304366,"avatar_url":"https://avatars.githubusercontent.com/u/304366?v=3","gravatar_id":"","url":"https://api.github.com/users/pguillory","html_url":"https://github.com/pguillory","followers_url":"https://api.github.com/users/pguillory/followers","following_url":"https://api.github.com/users/pguillory/following{/other_user}","gists_url":"https://api.github.com/users/pguillory/gists{/gist_id}","starred_url":"https://api.github.com/users/pguillory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pguillory/subscriptions","organizations_url":"https://api.github.com/users/pguillory/orgs","repos_url":"https://api.github.com/users/pguillory/repos","events_url":"https://api.github.com/users/pguillory/events{/privacy}","received_events_url":"https://api.github.com/users/pguillory/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pguillory/elixir-thrift","description":"Thrift Utilities for Elixir","fork":true,"url":"https://api.github.com/repos/pguillory/elixir-thrift","forks_url":"https://api.github.com/repos/pguillory/elixir-thrift/forks","keys_url":"https://api.github.com/repos/pguillory/elixir-thrift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pguillory/elixir-thrift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pguillory/elixir-thrift/teams","hooks_url":"https://api.github.com/repos/pguillory/elixir-thrift/hooks","issue_events_url":"https://api.github.com/repos/pguillory/elixir-thrift/issues/events{/number}","events_url":"https://api.github.com/repos/pguillory/elixir-thrift/events","assignees_url":"https://api.github.com/repos/pguillory/elixir-thrift/assignees{/user}","branches_url":"https://api.github.com/repos/pguillory/elixir-thrift/branches{/branch}","tags_url":"https://api.github.com/repos/pguillory/elixir-thrift/tags","blobs_url":"https://api.github.com/repos/pguillory/elixir-thrift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pguillory/elixir-thrift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pguillory/elixir-thrift/git/refs{/sha}","trees_url":"https://api.github.com/repos/pguillory/elixir-thrift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pguillory/elixir-thrift/statuses/{sha}","languages_url":"https://api.github.com/repos/pguillory/elixir-thrift/languages","stargazers_url":"https://api.github.com/repos/pguillory/elixir-thrift/stargazers","contributors_url":"https://api.github.com/repos/pguillory/elixir-thrift/contributors","subscribers_url":"https://api.github.com/repos/pguillory/elixir-thrift/subscribers","subscription_url":"https://api.github.com/repos/pguillory/elixir-thrift/subscription","commits_url":"https://api.github.com/repos/pguillory/elixir-thrift/commits{/sha}","git_commits_url":"https://api.github.com/repos/pguillory/elixir-thrift/git/commits{/sha}","comments_url":"https://api.github.com/repos/pguillory/elixir-thrift/comments{/number}","issue_comment_url":"https://api.github.com/repos/pguillory/elixir-thrift/issues/comments{/number}","contents_url":"https://api.github.com/repos/pguillory/elixir-thrift/contents/{+path}","compare_url":"https://api.github.com/repos/pguillory/elixir-thrift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pguillory/elixir-thrift/merges","archive_url":"https://api.github.com/repos/pguillory/elixir-thrift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pguillory/elixir-thrift/downloads","issues_url":"https://api.github.com/repos/pguillory/elixir-thrift/issues{/number}","pulls_url":"https://api.github.com/repos/pguillory/elixir-thrift/pulls{/number}","milestones_url":"https://api.github.com/repos/pguillory/elixir-thrift/milestones{/number}","notifications_url":"https://api.github.com/repos/pguillory/elixir-thrift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pguillory/elixir-thrift/labels{/name}","releases_url":"https://api.github.com/repos/pguillory/elixir-thrift/releases{/id}","deployments_url":"https://api.github.com/repos/pguillory/elixir-thrift/deployments","created_at":"2016-11-09T19:59:13Z","updated_at":"2016-11-09T19:59:14Z","pushed_at":"2016-11-21T23:13:17Z","git_url":"git://github.com/pguillory/elixir-thrift.git","ssh_url":"git@github.com:pguillory/elixir-thrift.git","clone_url":"https://github.com/pguillory/elixir-thrift.git","svn_url":"https://github.com/pguillory/elixir-thrift","homepage":"https://hexdocs.pm/thrift/","size":202,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pinterest:pure_elixir_implementation","ref":"pure_elixir_implementation","sha":"e6a7312b3248cb40f7bf23b6ee5198c268c4e5d8","user":{"login":"pinterest","id":541152,"avatar_url":"https://avatars.githubusercontent.com/u/541152?v=3","gravatar_id":"","url":"https://api.github.com/users/pinterest","html_url":"https://github.com/pinterest","followers_url":"https://api.github.com/users/pinterest/followers","following_url":"https://api.github.com/users/pinterest/following{/other_user}","gists_url":"https://api.github.com/users/pinterest/gists{/gist_id}","starred_url":"https://api.github.com/users/pinterest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinterest/subscriptions","organizations_url":"https://api.github.com/users/pinterest/orgs","repos_url":"https://api.github.com/users/pinterest/repos","events_url":"https://api.github.com/users/pinterest/events{/privacy}","received_events_url":"https://api.github.com/users/pinterest/received_events","type":"Organization","site_admin":false},"repo":{"id":43914111,"name":"elixir-thrift","full_name":"pinterest/elixir-thrift","owner":{"login":"pinterest","id":541152,"avatar_url":"https://avatars.githubusercontent.com/u/541152?v=3","gravatar_id":"","url":"https://api.github.com/users/pinterest","html_url":"https://github.com/pinterest","followers_url":"https://api.github.com/users/pinterest/followers","following_url":"https://api.github.com/users/pinterest/following{/other_user}","gists_url":"https://api.github.com/users/pinterest/gists{/gist_id}","starred_url":"https://api.github.com/users/pinterest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinterest/subscriptions","organizations_url":"https://api.github.com/users/pinterest/orgs","repos_url":"https://api.github.com/users/pinterest/repos","events_url":"https://api.github.com/users/pinterest/events{/privacy}","received_events_url":"https://api.github.com/users/pinterest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pinterest/elixir-thrift","description":"Thrift Utilities for Elixir","fork":false,"url":"https://api.github.com/repos/pinterest/elixir-thrift","forks_url":"https://api.github.com/repos/pinterest/elixir-thrift/forks","keys_url":"https://api.github.com/repos/pinterest/elixir-thrift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pinterest/elixir-thrift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pinterest/elixir-thrift/teams","hooks_url":"https://api.github.com/repos/pinterest/elixir-thrift/hooks","issue_events_url":"https://api.github.com/repos/pinterest/elixir-thrift/issues/events{/number}","events_url":"https://api.github.com/repos/pinterest/elixir-thrift/events","assignees_url":"https://api.github.com/repos/pinterest/elixir-thrift/assignees{/user}","branches_url":"https://api.github.com/repos/pinterest/elixir-thrift/branches{/branch}","tags_url":"https://api.github.com/repos/pinterest/elixir-thrift/tags","blobs_url":"https://api.github.com/repos/pinterest/elixir-thrift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pinterest/elixir-thrift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pinterest/elixir-thrift/git/refs{/sha}","trees_url":"https://api.github.com/repos/pinterest/elixir-thrift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pinterest/elixir-thrift/statuses/{sha}","languages_url":"https://api.github.com/repos/pinterest/elixir-thrift/languages","stargazers_url":"https://api.github.com/repos/pinterest/elixir-thrift/stargazers","contributors_url":"https://api.github.com/repos/pinterest/elixir-thrift/contributors","subscribers_url":"https://api.github.com/repos/pinterest/elixir-thrift/subscribers","subscription_url":"https://api.github.com/repos/pinterest/elixir-thrift/subscription","commits_url":"https://api.github.com/repos/pinterest/elixir-thrift/commits{/sha}","git_commits_url":"https://api.github.com/repos/pinterest/elixir-thrift/git/commits{/sha}","comments_url":"https://api.github.com/repos/pinterest/elixir-thrift/comments{/number}","issue_comment_url":"https://api.github.com/repos/pinterest/elixir-thrift/issues/comments{/number}","contents_url":"https://api.github.com/repos/pinterest/elixir-thrift/contents/{+path}","compare_url":"https://api.github.com/repos/pinterest/elixir-thrift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pinterest/elixir-thrift/merges","archive_url":"https://api.github.com/repos/pinterest/elixir-thrift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pinterest/elixir-thrift/downloads","issues_url":"https://api.github.com/repos/pinterest/elixir-thrift/issues{/number}","pulls_url":"https://api.github.com/repos/pinterest/elixir-thrift/pulls{/number}","milestones_url":"https://api.github.com/repos/pinterest/elixir-thrift/milestones{/number}","notifications_url":"https://api.github.com/repos/pinterest/elixir-thrift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pinterest/elixir-thrift/labels{/name}","releases_url":"https://api.github.com/repos/pinterest/elixir-thrift/releases{/id}","deployments_url":"https://api.github.com/repos/pinterest/elixir-thrift/deployments","created_at":"2015-10-08T20:17:30Z","updated_at":"2016-11-10T16:27:14Z","pushed_at":"2016-11-21T23:35:55Z","git_url":"git://github.com/pinterest/elixir-thrift.git","ssh_url":"git@github.com:pinterest/elixir-thrift.git","clone_url":"https://github.com/pinterest/elixir-thrift.git","svn_url":"https://github.com/pinterest/elixir-thrift","homepage":"https://hexdocs.pm/thrift/","size":238,"stargazers_count":35,"watchers_count":35,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":4,"forks":11,"open_issues":4,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/47"},"html":{"href":"https://github.com/pinterest/elixir-thrift/pull/47"},"issue":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/issues/47"},"comments":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/statuses/993aa728e20d5fd5dabeebada08d1867b9564e6f"}}}}
{"actor":{"display_login":"jparise"}}