{"action":"created","comment":{"url":"https://api.github.com/repos/tklengyel/drakvuf/pulls/comments/55332468","id":55332468,"diff_hunk":"@@ -223,6 +223,34 @@ struct drakvuf_trap {\n     void *data;\n };\n \n+\n+////////////////////////////////////////////////////////////////////////////\n+\n+// IMHO these definitions must be placed within another file, named\n+// libdrakvuf-windows.h or something similar\n+\n+// For get_previous_mode...\n+typedef enum _MODE {\n+    KernelMode,\n+    UserMode,\n+    MaximumMode\n+} MODE ;\n+\n+// Confirmed only on Win7 SP1...\n+typedef enum _OBJECT_MANAGER_OBJECT_TYPE {\n+    ObjManagerProcessObject = 7,","path":"src/libdrakvuf/libdrakvuf.h","position":19,"original_position":19,"commit_id":"9769240dd4f59fdd806c5e15d4480e620d131d1c","original_commit_id":"9769240dd4f59fdd806c5e15d4480e620d131d1c","user":{"login":"tklengyel","id":3172829,"avatar_url":"https://avatars.githubusercontent.com/u/3172829?v=3","gravatar_id":"","url":"https://api.github.com/users/tklengyel","html_url":"https://github.com/tklengyel","followers_url":"https://api.github.com/users/tklengyel/followers","following_url":"https://api.github.com/users/tklengyel/following{/other_user}","gists_url":"https://api.github.com/users/tklengyel/gists{/gist_id}","starred_url":"https://api.github.com/users/tklengyel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tklengyel/subscriptions","organizations_url":"https://api.github.com/users/tklengyel/orgs","repos_url":"https://api.github.com/users/tklengyel/repos","events_url":"https://api.github.com/users/tklengyel/events{/privacy}","received_events_url":"https://api.github.com/users/tklengyel/received_events","type":"User","site_admin":false},"body":"Generally for enum members I like to name them in all capital instead of camel-casing as to be able to differentiate them from variables. So these should be instead OBJ_MANAGER_PROCESS_OBJECT, etc..","created_at":"2016-03-08T09:07:46Z","updated_at":"2016-03-08T09:07:46Z","html_url":"https://github.com/tklengyel/drakvuf/pull/97#discussion_r55332468","pull_request_url":"https://api.github.com/repos/tklengyel/drakvuf/pulls/97","_links":{"self":{"href":"https://api.github.com/repos/tklengyel/drakvuf/pulls/comments/55332468"},"html":{"href":"https://github.com/tklengyel/drakvuf/pull/97#discussion_r55332468"},"pull_request":{"href":"https://api.github.com/repos/tklengyel/drakvuf/pulls/97"}}},"pull_request":{"url":"https://api.github.com/repos/tklengyel/drakvuf/pulls/97","id":62039810,"html_url":"https://github.com/tklengyel/drakvuf/pull/97","diff_url":"https://github.com/tklengyel/drakvuf/pull/97.diff","patch_url":"https://github.com/tklengyel/drakvuf/pull/97.patch","issue_url":"https://api.github.com/repos/tklengyel/drakvuf/issues/97","number":97,"state":"open","locked":false,"title":"Added useful Windows routines...","user":{"login":"aoshiken","id":5227552,"avatar_url":"https://avatars.githubusercontent.com/u/5227552?v=3","gravatar_id":"","url":"https://api.github.com/users/aoshiken","html_url":"https://github.com/aoshiken","followers_url":"https://api.github.com/users/aoshiken/followers","following_url":"https://api.github.com/users/aoshiken/following{/other_user}","gists_url":"https://api.github.com/users/aoshiken/gists{/gist_id}","starred_url":"https://api.github.com/users/aoshiken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aoshiken/subscriptions","organizations_url":"https://api.github.com/users/aoshiken/orgs","repos_url":"https://api.github.com/users/aoshiken/repos","events_url":"https://api.github.com/users/aoshiken/events{/privacy}","received_events_url":"https://api.github.com/users/aoshiken/received_events","type":"User","site_admin":false},"body":"...for use within the hooks:\r\n- drakvuf_get_current_thread_id(): Get the current thread id\r\n- drakvuf_get_previous_mode(): Return the thread PreviousMode (see libdrakvuf.h)\r\n- drakvuf_is_ethread(): Check if the address argument is an _ETHREAD\r\n- drakvuf_is_eprocess(): Check if the adress argument is an _EPROCESS\r\n- drakvuf_obj_ref_by_handle(): Returns the Object body address from a HANDLE cheking its validity\r\n\r\nThis PR replaces #96 \r\n","created_at":"2016-03-08T08:37:49Z","updated_at":"2016-03-08T09:07:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6bf36b4adb0a94994c56e515679ae6ac47f26d31","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tklengyel/drakvuf/pulls/97/commits","review_comments_url":"https://api.github.com/repos/tklengyel/drakvuf/pulls/97/comments","review_comment_url":"https://api.github.com/repos/tklengyel/drakvuf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tklengyel/drakvuf/issues/97/comments","statuses_url":"https://api.github.com/repos/tklengyel/drakvuf/statuses/9769240dd4f59fdd806c5e15d4480e620d131d1c","head":{"label":"aoshiken:windows-utils","ref":"windows-utils","sha":"9769240dd4f59fdd806c5e15d4480e620d131d1c","user":{"login":"aoshiken","id":5227552,"avatar_url":"https://avatars.githubusercontent.com/u/5227552?v=3","gravatar_id":"","url":"https://api.github.com/users/aoshiken","html_url":"https://github.com/aoshiken","followers_url":"https://api.github.com/users/aoshiken/followers","following_url":"https://api.github.com/users/aoshiken/following{/other_user}","gists_url":"https://api.github.com/users/aoshiken/gists{/gist_id}","starred_url":"https://api.github.com/users/aoshiken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aoshiken/subscriptions","organizations_url":"https://api.github.com/users/aoshiken/orgs","repos_url":"https://api.github.com/users/aoshiken/repos","events_url":"https://api.github.com/users/aoshiken/events{/privacy}","received_events_url":"https://api.github.com/users/aoshiken/received_events","type":"User","site_admin":false},"repo":{"id":49659405,"name":"drakvuf","full_name":"aoshiken/drakvuf","owner":{"login":"aoshiken","id":5227552,"avatar_url":"https://avatars.githubusercontent.com/u/5227552?v=3","gravatar_id":"","url":"https://api.github.com/users/aoshiken","html_url":"https://github.com/aoshiken","followers_url":"https://api.github.com/users/aoshiken/followers","following_url":"https://api.github.com/users/aoshiken/following{/other_user}","gists_url":"https://api.github.com/users/aoshiken/gists{/gist_id}","starred_url":"https://api.github.com/users/aoshiken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aoshiken/subscriptions","organizations_url":"https://api.github.com/users/aoshiken/orgs","repos_url":"https://api.github.com/users/aoshiken/repos","events_url":"https://api.github.com/users/aoshiken/events{/privacy}","received_events_url":"https://api.github.com/users/aoshiken/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aoshiken/drakvuf","description":"DRAKVUF Dynamic Malware Analysis System","fork":true,"url":"https://api.github.com/repos/aoshiken/drakvuf","forks_url":"https://api.github.com/repos/aoshiken/drakvuf/forks","keys_url":"https://api.github.com/repos/aoshiken/drakvuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aoshiken/drakvuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aoshiken/drakvuf/teams","hooks_url":"https://api.github.com/repos/aoshiken/drakvuf/hooks","issue_events_url":"https://api.github.com/repos/aoshiken/drakvuf/issues/events{/number}","events_url":"https://api.github.com/repos/aoshiken/drakvuf/events","assignees_url":"https://api.github.com/repos/aoshiken/drakvuf/assignees{/user}","branches_url":"https://api.github.com/repos/aoshiken/drakvuf/branches{/branch}","tags_url":"https://api.github.com/repos/aoshiken/drakvuf/tags","blobs_url":"https://api.github.com/repos/aoshiken/drakvuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aoshiken/drakvuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aoshiken/drakvuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/aoshiken/drakvuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aoshiken/drakvuf/statuses/{sha}","languages_url":"https://api.github.com/repos/aoshiken/drakvuf/languages","stargazers_url":"https://api.github.com/repos/aoshiken/drakvuf/stargazers","contributors_url":"https://api.github.com/repos/aoshiken/drakvuf/contributors","subscribers_url":"https://api.github.com/repos/aoshiken/drakvuf/subscribers","subscription_url":"https://api.github.com/repos/aoshiken/drakvuf/subscription","commits_url":"https://api.github.com/repos/aoshiken/drakvuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/aoshiken/drakvuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/aoshiken/drakvuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/aoshiken/drakvuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/aoshiken/drakvuf/contents/{+path}","compare_url":"https://api.github.com/repos/aoshiken/drakvuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aoshiken/drakvuf/merges","archive_url":"https://api.github.com/repos/aoshiken/drakvuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aoshiken/drakvuf/downloads","issues_url":"https://api.github.com/repos/aoshiken/drakvuf/issues{/number}","pulls_url":"https://api.github.com/repos/aoshiken/drakvuf/pulls{/number}","milestones_url":"https://api.github.com/repos/aoshiken/drakvuf/milestones{/number}","notifications_url":"https://api.github.com/repos/aoshiken/drakvuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aoshiken/drakvuf/labels{/name}","releases_url":"https://api.github.com/repos/aoshiken/drakvuf/releases{/id}","deployments_url":"https://api.github.com/repos/aoshiken/drakvuf/deployments","created_at":"2016-01-14T16:25:14Z","updated_at":"2016-03-07T15:32:38Z","pushed_at":"2016-03-08T08:33:45Z","git_url":"git://github.com/aoshiken/drakvuf.git","ssh_url":"git@github.com:aoshiken/drakvuf.git","clone_url":"https://github.com/aoshiken/drakvuf.git","svn_url":"https://github.com/aoshiken/drakvuf","homepage":"http://drakvuf.com","size":6958,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"tklengyel:master","ref":"master","sha":"b8ec625c0639b7a44b787fbdf7fc55f1db025ddc","user":{"login":"tklengyel","id":3172829,"avatar_url":"https://avatars.githubusercontent.com/u/3172829?v=3","gravatar_id":"","url":"https://api.github.com/users/tklengyel","html_url":"https://github.com/tklengyel","followers_url":"https://api.github.com/users/tklengyel/followers","following_url":"https://api.github.com/users/tklengyel/following{/other_user}","gists_url":"https://api.github.com/users/tklengyel/gists{/gist_id}","starred_url":"https://api.github.com/users/tklengyel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tklengyel/subscriptions","organizations_url":"https://api.github.com/users/tklengyel/orgs","repos_url":"https://api.github.com/users/tklengyel/repos","events_url":"https://api.github.com/users/tklengyel/events{/privacy}","received_events_url":"https://api.github.com/users/tklengyel/received_events","type":"User","site_admin":false},"repo":{"id":23253045,"name":"drakvuf","full_name":"tklengyel/drakvuf","owner":{"login":"tklengyel","id":3172829,"avatar_url":"https://avatars.githubusercontent.com/u/3172829?v=3","gravatar_id":"","url":"https://api.github.com/users/tklengyel","html_url":"https://github.com/tklengyel","followers_url":"https://api.github.com/users/tklengyel/followers","following_url":"https://api.github.com/users/tklengyel/following{/other_user}","gists_url":"https://api.github.com/users/tklengyel/gists{/gist_id}","starred_url":"https://api.github.com/users/tklengyel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tklengyel/subscriptions","organizations_url":"https://api.github.com/users/tklengyel/orgs","repos_url":"https://api.github.com/users/tklengyel/repos","events_url":"https://api.github.com/users/tklengyel/events{/privacy}","received_events_url":"https://api.github.com/users/tklengyel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tklengyel/drakvuf","description":"DRAKVUF Dynamic Malware Analysis System","fork":false,"url":"https://api.github.com/repos/tklengyel/drakvuf","forks_url":"https://api.github.com/repos/tklengyel/drakvuf/forks","keys_url":"https://api.github.com/repos/tklengyel/drakvuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tklengyel/drakvuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tklengyel/drakvuf/teams","hooks_url":"https://api.github.com/repos/tklengyel/drakvuf/hooks","issue_events_url":"https://api.github.com/repos/tklengyel/drakvuf/issues/events{/number}","events_url":"https://api.github.com/repos/tklengyel/drakvuf/events","assignees_url":"https://api.github.com/repos/tklengyel/drakvuf/assignees{/user}","branches_url":"https://api.github.com/repos/tklengyel/drakvuf/branches{/branch}","tags_url":"https://api.github.com/repos/tklengyel/drakvuf/tags","blobs_url":"https://api.github.com/repos/tklengyel/drakvuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tklengyel/drakvuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tklengyel/drakvuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/tklengyel/drakvuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tklengyel/drakvuf/statuses/{sha}","languages_url":"https://api.github.com/repos/tklengyel/drakvuf/languages","stargazers_url":"https://api.github.com/repos/tklengyel/drakvuf/stargazers","contributors_url":"https://api.github.com/repos/tklengyel/drakvuf/contributors","subscribers_url":"https://api.github.com/repos/tklengyel/drakvuf/subscribers","subscription_url":"https://api.github.com/repos/tklengyel/drakvuf/subscription","commits_url":"https://api.github.com/repos/tklengyel/drakvuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/tklengyel/drakvuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/tklengyel/drakvuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/tklengyel/drakvuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/tklengyel/drakvuf/contents/{+path}","compare_url":"https://api.github.com/repos/tklengyel/drakvuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tklengyel/drakvuf/merges","archive_url":"https://api.github.com/repos/tklengyel/drakvuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tklengyel/drakvuf/downloads","issues_url":"https://api.github.com/repos/tklengyel/drakvuf/issues{/number}","pulls_url":"https://api.github.com/repos/tklengyel/drakvuf/pulls{/number}","milestones_url":"https://api.github.com/repos/tklengyel/drakvuf/milestones{/number}","notifications_url":"https://api.github.com/repos/tklengyel/drakvuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tklengyel/drakvuf/labels{/name}","releases_url":"https://api.github.com/repos/tklengyel/drakvuf/releases{/id}","deployments_url":"https://api.github.com/repos/tklengyel/drakvuf/deployments","created_at":"2014-08-23T10:00:28Z","updated_at":"2016-03-07T15:34:12Z","pushed_at":"2016-03-08T08:37:50Z","git_url":"git://github.com/tklengyel/drakvuf.git","ssh_url":"git@github.com:tklengyel/drakvuf.git","clone_url":"https://github.com/tklengyel/drakvuf.git","svn_url":"https://github.com/tklengyel/drakvuf","homepage":"http://drakvuf.com","size":7032,"stargazers_count":121,"watchers_count":121,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":27,"mirror_url":null,"open_issues_count":6,"forks":27,"open_issues":6,"watchers":121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tklengyel/drakvuf/pulls/97"},"html":{"href":"https://github.com/tklengyel/drakvuf/pull/97"},"issue":{"href":"https://api.github.com/repos/tklengyel/drakvuf/issues/97"},"comments":{"href":"https://api.github.com/repos/tklengyel/drakvuf/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/tklengyel/drakvuf/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/tklengyel/drakvuf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tklengyel/drakvuf/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/tklengyel/drakvuf/statuses/9769240dd4f59fdd806c5e15d4480e620d131d1c"}}}}