{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/82352927","pull_request_review_id":3266871,"id":82352927,"diff_hunk":"@@ -123,5 +123,15 @@ class RolesControllerTest < ActionController::TestCase\n       assert_not_nil cloned_role\n       assert_equal @role.permissions, cloned_role.permissions\n     end\n+\n+    test \"cloned roles should have builtin value 0 instead of `false`\" do\n+      params = { :role => {:name => 'clonedrole'},\n+                 :original_role_id => @role.id,\n+                 :cloned_role => true }\n+      post :create, params, set_session_user\n+\n+      cloned_role = Role.find_by_name('clonedrole')","path":"test/controllers/roles_controller_test.rb","position":11,"original_position":11,"commit_id":"1546bd10df0c368ba8206e60f245e28aafc48cdb","original_commit_id":"1546bd10df0c368ba8206e60f245e28aafc48cdb","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Useless assignment to variable - cloned_role.","created_at":"2016-10-07T09:04:16Z","updated_at":"2016-10-07T09:04:16Z","html_url":"https://github.com/theforeman/foreman/pull/3925#discussion_r82352927","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/3925","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/82352927"},"html":{"href":"https://github.com/theforeman/foreman/pull/3925#discussion_r82352927"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3925"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/3925","id":88403112,"html_url":"https://github.com/theforeman/foreman/pull/3925","diff_url":"https://github.com/theforeman/foreman/pull/3925.diff","patch_url":"https://github.com/theforeman/foreman/pull/3925.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/3925","number":3925,"state":"open","locked":false,"title":"Fixes #16828 role.builtin = 0(integer) value instead of 'false'","user":{"login":"swapnilabnave","id":1291980,"avatar_url":"https://avatars.githubusercontent.com/u/1291980?v=3","gravatar_id":"","url":"https://api.github.com/users/swapnilabnave","html_url":"https://github.com/swapnilabnave","followers_url":"https://api.github.com/users/swapnilabnave/followers","following_url":"https://api.github.com/users/swapnilabnave/following{/other_user}","gists_url":"https://api.github.com/users/swapnilabnave/gists{/gist_id}","starred_url":"https://api.github.com/users/swapnilabnave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swapnilabnave/subscriptions","organizations_url":"https://api.github.com/users/swapnilabnave/orgs","repos_url":"https://api.github.com/users/swapnilabnave/repos","events_url":"https://api.github.com/users/swapnilabnave/events{/privacy}","received_events_url":"https://api.github.com/users/swapnilabnave/received_events","type":"User","site_admin":false},"body":"Though `roles.builtin` has [`:default => 0`](https://github.com/theforeman/foreman/blob/12612809c5deb885b13ceaf36b6a147c21688eb5/db/migrate/20160715131352_set_role_builtin_default.rb). This is to ensure cloned roles always have `builtin == 0`","created_at":"2016-10-07T09:03:34Z","updated_at":"2016-10-07T09:04:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44e7620539488a85ce38b287385473b347e39fa1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/3925/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/3925/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/3925/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/1546bd10df0c368ba8206e60f245e28aafc48cdb","head":{"label":"swapnilabnave:16828_ensure_builtin_0_cloned_role","ref":"16828_ensure_builtin_0_cloned_role","sha":"1546bd10df0c368ba8206e60f245e28aafc48cdb","user":{"login":"swapnilabnave","id":1291980,"avatar_url":"https://avatars.githubusercontent.com/u/1291980?v=3","gravatar_id":"","url":"https://api.github.com/users/swapnilabnave","html_url":"https://github.com/swapnilabnave","followers_url":"https://api.github.com/users/swapnilabnave/followers","following_url":"https://api.github.com/users/swapnilabnave/following{/other_user}","gists_url":"https://api.github.com/users/swapnilabnave/gists{/gist_id}","starred_url":"https://api.github.com/users/swapnilabnave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swapnilabnave/subscriptions","organizations_url":"https://api.github.com/users/swapnilabnave/orgs","repos_url":"https://api.github.com/users/swapnilabnave/repos","events_url":"https://api.github.com/users/swapnilabnave/events{/privacy}","received_events_url":"https://api.github.com/users/swapnilabnave/received_events","type":"User","site_admin":false},"repo":{"id":63067611,"name":"foreman","full_name":"swapnilabnave/foreman","owner":{"login":"swapnilabnave","id":1291980,"avatar_url":"https://avatars.githubusercontent.com/u/1291980?v=3","gravatar_id":"","url":"https://api.github.com/users/swapnilabnave","html_url":"https://github.com/swapnilabnave","followers_url":"https://api.github.com/users/swapnilabnave/followers","following_url":"https://api.github.com/users/swapnilabnave/following{/other_user}","gists_url":"https://api.github.com/users/swapnilabnave/gists{/gist_id}","starred_url":"https://api.github.com/users/swapnilabnave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swapnilabnave/subscriptions","organizations_url":"https://api.github.com/users/swapnilabnave/orgs","repos_url":"https://api.github.com/users/swapnilabnave/repos","events_url":"https://api.github.com/users/swapnilabnave/events{/privacy}","received_events_url":"https://api.github.com/users/swapnilabnave/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/swapnilabnave/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/swapnilabnave/foreman","forks_url":"https://api.github.com/repos/swapnilabnave/foreman/forks","keys_url":"https://api.github.com/repos/swapnilabnave/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swapnilabnave/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swapnilabnave/foreman/teams","hooks_url":"https://api.github.com/repos/swapnilabnave/foreman/hooks","issue_events_url":"https://api.github.com/repos/swapnilabnave/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/swapnilabnave/foreman/events","assignees_url":"https://api.github.com/repos/swapnilabnave/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/swapnilabnave/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/swapnilabnave/foreman/tags","blobs_url":"https://api.github.com/repos/swapnilabnave/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swapnilabnave/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swapnilabnave/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/swapnilabnave/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swapnilabnave/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/swapnilabnave/foreman/languages","stargazers_url":"https://api.github.com/repos/swapnilabnave/foreman/stargazers","contributors_url":"https://api.github.com/repos/swapnilabnave/foreman/contributors","subscribers_url":"https://api.github.com/repos/swapnilabnave/foreman/subscribers","subscription_url":"https://api.github.com/repos/swapnilabnave/foreman/subscription","commits_url":"https://api.github.com/repos/swapnilabnave/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/swapnilabnave/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/swapnilabnave/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/swapnilabnave/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/swapnilabnave/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/swapnilabnave/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swapnilabnave/foreman/merges","archive_url":"https://api.github.com/repos/swapnilabnave/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swapnilabnave/foreman/downloads","issues_url":"https://api.github.com/repos/swapnilabnave/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/swapnilabnave/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/swapnilabnave/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/swapnilabnave/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swapnilabnave/foreman/labels{/name}","releases_url":"https://api.github.com/repos/swapnilabnave/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/swapnilabnave/foreman/deployments","created_at":"2016-07-11T12:52:05Z","updated_at":"2016-10-07T08:49:41Z","pushed_at":"2016-10-07T08:58:29Z","git_url":"git://github.com/swapnilabnave/foreman.git","ssh_url":"git@github.com:swapnilabnave/foreman.git","clone_url":"https://github.com/swapnilabnave/foreman.git","svn_url":"https://github.com/swapnilabnave/foreman","homepage":"http://theforeman.org","size":51722,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"a4d7a037ba2cd143713e6a92f49ad6dc8c314628","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/foreman/deployments","created_at":"2009-07-23T15:07:00Z","updated_at":"2016-10-05T03:43:09Z","pushed_at":"2016-10-07T09:03:34Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":72443,"stargazers_count":1093,"watchers_count":1093,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":553,"mirror_url":null,"open_issues_count":79,"forks":553,"open_issues":79,"watchers":1093,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3925"},"html":{"href":"https://github.com/theforeman/foreman/pull/3925"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/3925"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/3925/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3925/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3925/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/1546bd10df0c368ba8206e60f245e28aafc48cdb"}}}}
{"actor":{"display_login":"houndci-bot"}}