{"action":"created","issue":{"url":"https://api.github.com/repos/draft-js-plugins/draft-js-plugins/issues/271","repository_url":"https://api.github.com/repos/draft-js-plugins/draft-js-plugins","labels_url":"https://api.github.com/repos/draft-js-plugins/draft-js-plugins/issues/271/labels{/name}","comments_url":"https://api.github.com/repos/draft-js-plugins/draft-js-plugins/issues/271/comments","events_url":"https://api.github.com/repos/draft-js-plugins/draft-js-plugins/issues/271/events","html_url":"https://github.com/draft-js-plugins/draft-js-plugins/pull/271","id":155947501,"number":271,"title":"Support `onClick` handler in mentions","user":{"login":"alexkuz","id":790659,"avatar_url":"https://avatars.githubusercontent.com/u/790659?v=3","gravatar_id":"","url":"https://api.github.com/users/alexkuz","html_url":"https://github.com/alexkuz","followers_url":"https://api.github.com/users/alexkuz/followers","following_url":"https://api.github.com/users/alexkuz/following{/other_user}","gists_url":"https://api.github.com/users/alexkuz/gists{/gist_id}","starred_url":"https://api.github.com/users/alexkuz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexkuz/subscriptions","organizations_url":"https://api.github.com/users/alexkuz/orgs","repos_url":"https://api.github.com/users/alexkuz/repos","events_url":"https://api.github.com/users/alexkuz/events{/privacy}","received_events_url":"https://api.github.com/users/alexkuz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-05-20T11:59:46Z","updated_at":"2016-05-24T10:36:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/draft-js-plugins/draft-js-plugins/pulls/271","html_url":"https://github.com/draft-js-plugins/draft-js-plugins/pull/271","diff_url":"https://github.com/draft-js-plugins/draft-js-plugins/pull/271.diff","patch_url":"https://github.com/draft-js-plugins/draft-js-plugins/pull/271.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/draft-js-plugins/draft-js-plugins/issues/comments/221230960","html_url":"https://github.com/draft-js-plugins/draft-js-plugins/pull/271#issuecomment-221230960","issue_url":"https://api.github.com/repos/draft-js-plugins/draft-js-plugins/issues/271","id":221230960,"user":{"login":"antoinerey","id":3336873,"avatar_url":"https://avatars.githubusercontent.com/u/3336873?v=3","gravatar_id":"","url":"https://api.github.com/users/antoinerey","html_url":"https://github.com/antoinerey","followers_url":"https://api.github.com/users/antoinerey/followers","following_url":"https://api.github.com/users/antoinerey/following{/other_user}","gists_url":"https://api.github.com/users/antoinerey/gists{/gist_id}","starred_url":"https://api.github.com/users/antoinerey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoinerey/subscriptions","organizations_url":"https://api.github.com/users/antoinerey/orgs","repos_url":"https://api.github.com/users/antoinerey/repos","events_url":"https://api.github.com/users/antoinerey/events{/privacy}","received_events_url":"https://api.github.com/users/antoinerey/received_events","type":"User","site_admin":false},"created_at":"2016-05-24T10:36:51Z","updated_at":"2016-05-24T10:36:51Z","body":"Correct me if I'm wrong. \r\n\r\nWhat you're suggesting here is, instead of giving each props manually, we could give a whole component with props already set on it, to the draft js plugin.\r\n\r\nSo instead of :\r\n\r\n``` js\r\nconst linkify = linkifyPlugin({\r\n  linkProps: {\r\n    style: { color: 'red' },\r\n    title: 'My link',\r\n  },\r\n})\r\n```\r\n\r\nWe could have :\r\n\r\n``` js\r\nconst linkify = linkifyPlugin({\r\n  linkComponent: (\r\n    <Link style={ ... } title=\"My link\" />\r\n  )\r\n})\r\n```\r\n\r\nIt would offer more flexibility but what if the developer gives a **display block** component instead of a **display inline** one ? This change will affect the layout which can be totally broken."}}
{"actor":{"display_login":"antoinerey"}}