{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/comments/78770097","id":78770097,"diff_hunk":"@@ -68,7 +68,7 @@ static LmUDRObjMethodInvoke makeNewObj(\n         return result;\n     }\n \n-    public static class ReturnInfo\n+    public class ReturnInfo","path":"core/sql/src/main/java/org/trafodion/sql/udr/LmUDRObjMethodInvoke.java","position":5,"original_position":5,"commit_id":"27b957b3782bce269418bc2addca1523ebe90215","original_commit_id":"27b957b3782bce269418bc2addca1523ebe90215","user":{"login":"zellerh","id":7062636,"avatar_url":"https://avatars.githubusercontent.com/u/7062636?v=3","gravatar_id":"","url":"https://api.github.com/users/zellerh","html_url":"https://github.com/zellerh","followers_url":"https://api.github.com/users/zellerh/followers","following_url":"https://api.github.com/users/zellerh/following{/other_user}","gists_url":"https://api.github.com/users/zellerh/gists{/gist_id}","starred_url":"https://api.github.com/users/zellerh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zellerh/subscriptions","organizations_url":"https://api.github.com/users/zellerh/orgs","repos_url":"https://api.github.com/users/zellerh/repos","events_url":"https://api.github.com/users/zellerh/events{/privacy}","received_events_url":"https://api.github.com/users/zellerh/received_events","type":"User","site_admin":false},"body":"Yes, what you say in your last sentence is what I'm thinking as well. If a nested class doesn't need an association with an object of its parent class then it is preferable to make it static. In this case, I feel that passing a ReturnInfo object across JNI is a bit strange with an inner class, as we would separate the two related objects.","created_at":"2016-09-14T15:17:33Z","updated_at":"2016-09-14T15:17:33Z","html_url":"https://github.com/apache/incubator-trafodion/pull/697#discussion_r78770097","pull_request_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/697","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/comments/78770097"},"html":{"href":"https://github.com/apache/incubator-trafodion/pull/697#discussion_r78770097"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/697"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/697","id":84976232,"html_url":"https://github.com/apache/incubator-trafodion/pull/697","diff_url":"https://github.com/apache/incubator-trafodion/pull/697.diff","patch_url":"https://github.com/apache/incubator-trafodion/pull/697.patch","issue_url":"https://api.github.com/repos/apache/incubator-trafodion/issues/697","number":697,"state":"open","locked":false,"title":"[TRAFODION-2218] Memory leak from JVM used for TMUDF compile time interaction","user":{"login":"sureshsubbiah","id":3596671,"avatar_url":"https://avatars.githubusercontent.com/u/3596671?v=3","gravatar_id":"","url":"https://api.github.com/users/sureshsubbiah","html_url":"https://github.com/sureshsubbiah","followers_url":"https://api.github.com/users/sureshsubbiah/followers","following_url":"https://api.github.com/users/sureshsubbiah/following{/other_user}","gists_url":"https://api.github.com/users/sureshsubbiah/gists{/gist_id}","starred_url":"https://api.github.com/users/sureshsubbiah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sureshsubbiah/subscriptions","organizations_url":"https://api.github.com/users/sureshsubbiah/orgs","repos_url":"https://api.github.com/users/sureshsubbiah/repos","events_url":"https://api.github.com/users/sureshsubbiah/events{/privacy}","received_events_url":"https://api.github.com/users/sureshsubbiah/received_events","type":"User","site_admin":false},"body":"DeleteLocalRef added. ReturnInfo is no longer static. Please see JIRA for an explanation.","created_at":"2016-09-13T02:30:43Z","updated_at":"2016-09-14T15:17:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"926b3ba585d6ced51bdeacd6f526a6af903f926a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/697/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/697/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-trafodion/issues/697/comments","statuses_url":"https://api.github.com/repos/apache/incubator-trafodion/statuses/27b957b3782bce269418bc2addca1523ebe90215","head":{"label":"sureshsubbiah:unnest1","ref":"unnest1","sha":"27b957b3782bce269418bc2addca1523ebe90215","user":{"login":"sureshsubbiah","id":3596671,"avatar_url":"https://avatars.githubusercontent.com/u/3596671?v=3","gravatar_id":"","url":"https://api.github.com/users/sureshsubbiah","html_url":"https://github.com/sureshsubbiah","followers_url":"https://api.github.com/users/sureshsubbiah/followers","following_url":"https://api.github.com/users/sureshsubbiah/following{/other_user}","gists_url":"https://api.github.com/users/sureshsubbiah/gists{/gist_id}","starred_url":"https://api.github.com/users/sureshsubbiah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sureshsubbiah/subscriptions","organizations_url":"https://api.github.com/users/sureshsubbiah/orgs","repos_url":"https://api.github.com/users/sureshsubbiah/repos","events_url":"https://api.github.com/users/sureshsubbiah/events{/privacy}","received_events_url":"https://api.github.com/users/sureshsubbiah/received_events","type":"User","site_admin":false},"repo":{"id":37834164,"name":"incubator-trafodion","full_name":"sureshsubbiah/incubator-trafodion","owner":{"login":"sureshsubbiah","id":3596671,"avatar_url":"https://avatars.githubusercontent.com/u/3596671?v=3","gravatar_id":"","url":"https://api.github.com/users/sureshsubbiah","html_url":"https://github.com/sureshsubbiah","followers_url":"https://api.github.com/users/sureshsubbiah/followers","following_url":"https://api.github.com/users/sureshsubbiah/following{/other_user}","gists_url":"https://api.github.com/users/sureshsubbiah/gists{/gist_id}","starred_url":"https://api.github.com/users/sureshsubbiah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sureshsubbiah/subscriptions","organizations_url":"https://api.github.com/users/sureshsubbiah/orgs","repos_url":"https://api.github.com/users/sureshsubbiah/repos","events_url":"https://api.github.com/users/sureshsubbiah/events{/privacy}","received_events_url":"https://api.github.com/users/sureshsubbiah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sureshsubbiah/incubator-trafodion","description":"Mirror of Apache Trafodion (Incubating)","fork":true,"url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion","forks_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/forks","keys_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/teams","hooks_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/hooks","issue_events_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/issues/events{/number}","events_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/events","assignees_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/assignees{/user}","branches_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/branches{/branch}","tags_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/tags","blobs_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/git/refs{/sha}","trees_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/statuses/{sha}","languages_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/languages","stargazers_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/stargazers","contributors_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/contributors","subscribers_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/subscribers","subscription_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/subscription","commits_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/commits{/sha}","git_commits_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/git/commits{/sha}","comments_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/comments{/number}","issue_comment_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/issues/comments{/number}","contents_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/contents/{+path}","compare_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/merges","archive_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/downloads","issues_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/issues{/number}","pulls_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/pulls{/number}","milestones_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/milestones{/number}","notifications_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/labels{/name}","releases_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/releases{/id}","deployments_url":"https://api.github.com/repos/sureshsubbiah/incubator-trafodion/deployments","created_at":"2015-06-22T02:20:28Z","updated_at":"2015-06-22T02:21:07Z","pushed_at":"2016-09-13T02:29:49Z","git_url":"git://github.com/sureshsubbiah/incubator-trafodion.git","ssh_url":"git@github.com:sureshsubbiah/incubator-trafodion.git","clone_url":"https://github.com/sureshsubbiah/incubator-trafodion.git","svn_url":"https://github.com/sureshsubbiah/incubator-trafodion","homepage":null,"size":73048,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"057ae469c2ec9a363159851cdee905ad65aafaa9","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":36349344,"name":"incubator-trafodion","full_name":"apache/incubator-trafodion","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-trafodion","description":"Mirror of Apache Trafodion (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-trafodion","forks_url":"https://api.github.com/repos/apache/incubator-trafodion/forks","keys_url":"https://api.github.com/repos/apache/incubator-trafodion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-trafodion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-trafodion/teams","hooks_url":"https://api.github.com/repos/apache/incubator-trafodion/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-trafodion/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-trafodion/events","assignees_url":"https://api.github.com/repos/apache/incubator-trafodion/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-trafodion/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-trafodion/tags","blobs_url":"https://api.github.com/repos/apache/incubator-trafodion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-trafodion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-trafodion/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-trafodion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-trafodion/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-trafodion/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-trafodion/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-trafodion/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-trafodion/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-trafodion/subscription","commits_url":"https://api.github.com/repos/apache/incubator-trafodion/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-trafodion/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-trafodion/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-trafodion/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-trafodion/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-trafodion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-trafodion/merges","archive_url":"https://api.github.com/repos/apache/incubator-trafodion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-trafodion/downloads","issues_url":"https://api.github.com/repos/apache/incubator-trafodion/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-trafodion/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-trafodion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-trafodion/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-trafodion/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-trafodion/deployments","created_at":"2015-05-27T07:00:05Z","updated_at":"2016-09-11T02:35:44Z","pushed_at":"2016-09-14T10:32:22Z","git_url":"git://github.com/apache/incubator-trafodion.git","ssh_url":"git@github.com:apache/incubator-trafodion.git","clone_url":"https://github.com/apache/incubator-trafodion.git","svn_url":"https://github.com/apache/incubator-trafodion","homepage":null,"size":77196,"stargazers_count":76,"watchers_count":76,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":78,"mirror_url":"git://git.apache.org/incubator-trafodion.git","open_issues_count":13,"forks":78,"open_issues":13,"watchers":76,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/697"},"html":{"href":"https://github.com/apache/incubator-trafodion/pull/697"},"issue":{"href":"https://api.github.com/repos/apache/incubator-trafodion/issues/697"},"comments":{"href":"https://api.github.com/repos/apache/incubator-trafodion/issues/697/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/697/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/697/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-trafodion/statuses/27b957b3782bce269418bc2addca1523ebe90215"}}}}
{"actor":{"display_login":"zellerh"}}