{"action":"created","comment":{"url":"https://api.github.com/repos/cbaylis/luajit-aarch64/pulls/comments/70814728","id":70814728,"diff_hunk":"@@ -504,7 +513,22 @@ static void asm_tvptr(ASMState *as, Reg dest, IRRef ref)\n \n static void asm_aref(ASMState *as, IRIns *ir)\n {\n-    lua_unimpl();\n+  Reg dest = ra_dest(as, ir, RSET_GPR);\n+  Reg idx, base;\n+  if (irref_isk(ir->op2)) {\n+    IRRef tab = IR(ir->op1)->op1;\n+    int32_t ofs = asm_fuseabase(as, tab);\n+    IRRef refa = ofs ? tab : ir->op1;\n+    uint32_t k = emit_isk12(A64I_ADDx, ofs + 8*IR(ir->op2)->i);\n+    if (k != -1) {\n+      base = ra_alloc1(as, refa, RSET_GPR);\n+      emit_dn(as, A64I_ADDx^k, dest, base);","path":"src/lj_asm_arm64.h","position":43,"original_position":43,"commit_id":"7ef6f97b41f8628e33e75ecbb2ea8c432a1c4b3c","original_commit_id":"7ef6f97b41f8628e33e75ecbb2ea8c432a1c4b3c","user":{"login":"sindrom91","id":12616635,"avatar_url":"https://avatars.githubusercontent.com/u/12616635?v=3","gravatar_id":"","url":"https://api.github.com/users/sindrom91","html_url":"https://github.com/sindrom91","followers_url":"https://api.github.com/users/sindrom91/followers","following_url":"https://api.github.com/users/sindrom91/following{/other_user}","gists_url":"https://api.github.com/users/sindrom91/gists{/gist_id}","starred_url":"https://api.github.com/users/sindrom91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindrom91/subscriptions","organizations_url":"https://api.github.com/users/sindrom91/orgs","repos_url":"https://api.github.com/users/sindrom91/repos","events_url":"https://api.github.com/users/sindrom91/events{/privacy}","received_events_url":"https://api.github.com/users/sindrom91/received_events","type":"User","site_admin":false},"body":"Yep, I'll add another commit to fix that.","created_at":"2016-07-14T14:26:03Z","updated_at":"2016-07-14T14:26:03Z","html_url":"https://github.com/cbaylis/luajit-aarch64/pull/22#discussion_r70814728","pull_request_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/cbaylis/luajit-aarch64/pulls/comments/70814728"},"html":{"href":"https://github.com/cbaylis/luajit-aarch64/pull/22#discussion_r70814728"},"pull_request":{"href":"https://api.github.com/repos/cbaylis/luajit-aarch64/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/cbaylis/luajit-aarch64/pulls/22","id":77458748,"html_url":"https://github.com/cbaylis/luajit-aarch64/pull/22","diff_url":"https://github.com/cbaylis/luajit-aarch64/pull/22.diff","patch_url":"https://github.com/cbaylis/luajit-aarch64/pull/22.patch","issue_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/issues/22","number":22,"state":"open","locked":false,"title":"asm_aref and asm_gc_check","user":{"login":"sindrom91","id":12616635,"avatar_url":"https://avatars.githubusercontent.com/u/12616635?v=3","gravatar_id":"","url":"https://api.github.com/users/sindrom91","html_url":"https://github.com/sindrom91","followers_url":"https://api.github.com/users/sindrom91/followers","following_url":"https://api.github.com/users/sindrom91/following{/other_user}","gists_url":"https://api.github.com/users/sindrom91/gists{/gist_id}","starred_url":"https://api.github.com/users/sindrom91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindrom91/subscriptions","organizations_url":"https://api.github.com/users/sindrom91/orgs","repos_url":"https://api.github.com/users/sindrom91/repos","events_url":"https://api.github.com/users/sindrom91/events{/privacy}","received_events_url":"https://api.github.com/users/sindrom91/received_events","type":"User","site_admin":false},"body":"This commit will help out with astore_* examples, since it contains asm_aref and asm_fuseabase implementations. I haven't thoroughly tested the functions, but they definitely can be used for debugging astore_* examples.\r\n\r\nThere are some more changes that I feel I should explain:\r\n - lj_vm_exit_handler: st_vmstate macro uses GL register, which isn't restored, so I added a line that restores it before using st_vmstate.\r\n - emit_lsptr: Using movk without movz caused lowest 16 bits to be filled with some trash that was previously in that register, instead of zeros. My change is definitely not optimal, but I think it's ok for a temporary solution.\r\n\r\nComments are welcome.","created_at":"2016-07-14T13:47:05Z","updated_at":"2016-07-14T14:26:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e167cf406a1e7fdfda0f5c4cdfb4a4f55c87ed4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/pulls/22/commits","review_comments_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/pulls/22/comments","review_comment_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/issues/22/comments","statuses_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/statuses/7ef6f97b41f8628e33e75ecbb2ea8c432a1c4b3c","head":{"label":"sindrom91:aref","ref":"aref","sha":"7ef6f97b41f8628e33e75ecbb2ea8c432a1c4b3c","user":{"login":"sindrom91","id":12616635,"avatar_url":"https://avatars.githubusercontent.com/u/12616635?v=3","gravatar_id":"","url":"https://api.github.com/users/sindrom91","html_url":"https://github.com/sindrom91","followers_url":"https://api.github.com/users/sindrom91/followers","following_url":"https://api.github.com/users/sindrom91/following{/other_user}","gists_url":"https://api.github.com/users/sindrom91/gists{/gist_id}","starred_url":"https://api.github.com/users/sindrom91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindrom91/subscriptions","organizations_url":"https://api.github.com/users/sindrom91/orgs","repos_url":"https://api.github.com/users/sindrom91/repos","events_url":"https://api.github.com/users/sindrom91/events{/privacy}","received_events_url":"https://api.github.com/users/sindrom91/received_events","type":"User","site_admin":false},"repo":{"id":61034110,"name":"luajit-aarch64","full_name":"sindrom91/luajit-aarch64","owner":{"login":"sindrom91","id":12616635,"avatar_url":"https://avatars.githubusercontent.com/u/12616635?v=3","gravatar_id":"","url":"https://api.github.com/users/sindrom91","html_url":"https://github.com/sindrom91","followers_url":"https://api.github.com/users/sindrom91/followers","following_url":"https://api.github.com/users/sindrom91/following{/other_user}","gists_url":"https://api.github.com/users/sindrom91/gists{/gist_id}","starred_url":"https://api.github.com/users/sindrom91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindrom91/subscriptions","organizations_url":"https://api.github.com/users/sindrom91/orgs","repos_url":"https://api.github.com/users/sindrom91/repos","events_url":"https://api.github.com/users/sindrom91/events{/privacy}","received_events_url":"https://api.github.com/users/sindrom91/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sindrom91/luajit-aarch64","description":null,"fork":true,"url":"https://api.github.com/repos/sindrom91/luajit-aarch64","forks_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/forks","keys_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/teams","hooks_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/hooks","issue_events_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/issues/events{/number}","events_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/events","assignees_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/assignees{/user}","branches_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/branches{/branch}","tags_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/tags","blobs_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/git/refs{/sha}","trees_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/statuses/{sha}","languages_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/languages","stargazers_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/stargazers","contributors_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/contributors","subscribers_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/subscribers","subscription_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/subscription","commits_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/commits{/sha}","git_commits_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/git/commits{/sha}","comments_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/comments{/number}","issue_comment_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/issues/comments{/number}","contents_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/contents/{+path}","compare_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/merges","archive_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/downloads","issues_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/issues{/number}","pulls_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/pulls{/number}","milestones_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/milestones{/number}","notifications_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/labels{/name}","releases_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/releases{/id}","deployments_url":"https://api.github.com/repos/sindrom91/luajit-aarch64/deployments","created_at":"2016-06-13T12:22:06Z","updated_at":"2016-06-13T12:22:27Z","pushed_at":"2016-07-14T13:41:30Z","git_url":"git://github.com/sindrom91/luajit-aarch64.git","ssh_url":"git@github.com:sindrom91/luajit-aarch64.git","clone_url":"https://github.com/sindrom91/luajit-aarch64.git","svn_url":"https://github.com/sindrom91/luajit-aarch64","homepage":null,"size":3577,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cbaylis:aarch64-v2.1-new","ref":"aarch64-v2.1-new","sha":"0332c17ffc5ba7f99a6c9083fbedb8ca6e27bb85","user":{"login":"cbaylis","id":19856351,"avatar_url":"https://avatars.githubusercontent.com/u/19856351?v=3","gravatar_id":"","url":"https://api.github.com/users/cbaylis","html_url":"https://github.com/cbaylis","followers_url":"https://api.github.com/users/cbaylis/followers","following_url":"https://api.github.com/users/cbaylis/following{/other_user}","gists_url":"https://api.github.com/users/cbaylis/gists{/gist_id}","starred_url":"https://api.github.com/users/cbaylis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbaylis/subscriptions","organizations_url":"https://api.github.com/users/cbaylis/orgs","repos_url":"https://api.github.com/users/cbaylis/repos","events_url":"https://api.github.com/users/cbaylis/events{/privacy}","received_events_url":"https://api.github.com/users/cbaylis/received_events","type":"User","site_admin":false},"repo":{"id":61025574,"name":"luajit-aarch64","full_name":"cbaylis/luajit-aarch64","owner":{"login":"cbaylis","id":19856351,"avatar_url":"https://avatars.githubusercontent.com/u/19856351?v=3","gravatar_id":"","url":"https://api.github.com/users/cbaylis","html_url":"https://github.com/cbaylis","followers_url":"https://api.github.com/users/cbaylis/followers","following_url":"https://api.github.com/users/cbaylis/following{/other_user}","gists_url":"https://api.github.com/users/cbaylis/gists{/gist_id}","starred_url":"https://api.github.com/users/cbaylis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbaylis/subscriptions","organizations_url":"https://api.github.com/users/cbaylis/orgs","repos_url":"https://api.github.com/users/cbaylis/repos","events_url":"https://api.github.com/users/cbaylis/events{/privacy}","received_events_url":"https://api.github.com/users/cbaylis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cbaylis/luajit-aarch64","description":null,"fork":false,"url":"https://api.github.com/repos/cbaylis/luajit-aarch64","forks_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/forks","keys_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/teams","hooks_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/hooks","issue_events_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/issues/events{/number}","events_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/events","assignees_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/assignees{/user}","branches_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/branches{/branch}","tags_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/tags","blobs_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/git/refs{/sha}","trees_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/statuses/{sha}","languages_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/languages","stargazers_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/stargazers","contributors_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/contributors","subscribers_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/subscribers","subscription_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/subscription","commits_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/commits{/sha}","git_commits_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/git/commits{/sha}","comments_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/comments{/number}","issue_comment_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/issues/comments{/number}","contents_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/contents/{+path}","compare_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/merges","archive_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/downloads","issues_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/issues{/number}","pulls_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/pulls{/number}","milestones_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/milestones{/number}","notifications_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/labels{/name}","releases_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/releases{/id}","deployments_url":"https://api.github.com/repos/cbaylis/luajit-aarch64/deployments","created_at":"2016-06-13T09:51:40Z","updated_at":"2016-06-13T09:52:27Z","pushed_at":"2016-07-14T13:47:05Z","git_url":"git://github.com/cbaylis/luajit-aarch64.git","ssh_url":"git@github.com:cbaylis/luajit-aarch64.git","clone_url":"https://github.com/cbaylis/luajit-aarch64.git","svn_url":"https://github.com/cbaylis/luajit-aarch64","homepage":null,"size":3554,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cbaylis/luajit-aarch64/pulls/22"},"html":{"href":"https://github.com/cbaylis/luajit-aarch64/pull/22"},"issue":{"href":"https://api.github.com/repos/cbaylis/luajit-aarch64/issues/22"},"comments":{"href":"https://api.github.com/repos/cbaylis/luajit-aarch64/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/cbaylis/luajit-aarch64/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/cbaylis/luajit-aarch64/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cbaylis/luajit-aarch64/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/cbaylis/luajit-aarch64/statuses/7ef6f97b41f8628e33e75ecbb2ea8c432a1c4b3c"}}}}
{"actor":{"display_login":"sindrom91"}}