{"action":"created","comment":{"url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/pulls/comments/77692446","id":77692446,"diff_hunk":"@@ -1085,7 +1092,9 @@ public Group patchGroup(Group oldGroup, Group newGroup) throws CharonException {\n                             throw new IdentitySCIMException(\n                                     \"User store domain is not indicated for user :\" + userDisplayName);\n                         }\n-                        if (!userStoreDomainForGroup.equalsIgnoreCase(userStoreDomainForUser)) {\n+                        if ((standardRoleDomains == null || !UserCoreUtil.isContain(userStoreDomainForGroup,","path":"components/org.wso2.carbon.identity.scim.provider/src/main/java/org/wso2/carbon/identity/scim/provider/impl/SCIMUserManager.java","position":39,"original_position":60,"commit_id":"246d5c8d41715f47a15a559debe48992b69342b3","original_commit_id":"246d5c8d41715f47a15a559debe48992b69342b3","user":{"login":"GayanM","id":3436694,"avatar_url":"https://avatars.githubusercontent.com/u/3436694?v=3","gravatar_id":"","url":"https://api.github.com/users/GayanM","html_url":"https://github.com/GayanM","followers_url":"https://api.github.com/users/GayanM/followers","following_url":"https://api.github.com/users/GayanM/following{/other_user}","gists_url":"https://api.github.com/users/GayanM/gists{/gist_id}","starred_url":"https://api.github.com/users/GayanM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GayanM/subscriptions","organizations_url":"https://api.github.com/users/GayanM/orgs","repos_url":"https://api.github.com/users/GayanM/repos","events_url":"https://api.github.com/users/GayanM/events{/privacy}","received_events_url":"https://api.github.com/users/GayanM/received_events","type":"User","site_admin":false},"body":"\r\n\r\nmove this logic private method otherwise if statement is not readable\r\n","created_at":"2016-09-06T18:31:55Z","updated_at":"2016-09-06T18:31:55Z","html_url":"https://github.com/wso2-extensions/identity-inbound-provisioning-scim/pull/22#discussion_r77692446","pull_request_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/pulls/comments/77692446"},"html":{"href":"https://github.com/wso2-extensions/identity-inbound-provisioning-scim/pull/22#discussion_r77692446"},"pull_request":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/pulls/22","id":84063855,"html_url":"https://github.com/wso2-extensions/identity-inbound-provisioning-scim/pull/22","diff_url":"https://github.com/wso2-extensions/identity-inbound-provisioning-scim/pull/22.diff","patch_url":"https://github.com/wso2-extensions/identity-inbound-provisioning-scim/pull/22.patch","issue_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/issues/22","number":22,"state":"closed","locked":false,"title":"Fixed IDENTITY-5044","user":{"login":"harsha1979","id":2236308,"avatar_url":"https://avatars.githubusercontent.com/u/2236308?v=3","gravatar_id":"","url":"https://api.github.com/users/harsha1979","html_url":"https://github.com/harsha1979","followers_url":"https://api.github.com/users/harsha1979/followers","following_url":"https://api.github.com/users/harsha1979/following{/other_user}","gists_url":"https://api.github.com/users/harsha1979/gists{/gist_id}","starred_url":"https://api.github.com/users/harsha1979/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsha1979/subscriptions","organizations_url":"https://api.github.com/users/harsha1979/orgs","repos_url":"https://api.github.com/users/harsha1979/repos","events_url":"https://api.github.com/users/harsha1979/events{/privacy}","received_events_url":"https://api.github.com/users/harsha1979/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-06T05:51:18Z","updated_at":"2016-09-06T18:31:55Z","closed_at":"2016-09-06T06:00:29Z","merged_at":"2016-09-06T06:00:29Z","merge_commit_sha":"5d5f4756cf72917bac73803a770067863d7d7513","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/pulls/22/commits","review_comments_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/pulls/22/comments","review_comment_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/issues/22/comments","statuses_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/statuses/246d5c8d41715f47a15a559debe48992b69342b3","head":{"label":"wso2-extensions:release-5.1.1","ref":"release-5.1.1","sha":"246d5c8d41715f47a15a559debe48992b69342b3","user":{"login":"wso2-extensions","id":17171218,"avatar_url":"https://avatars.githubusercontent.com/u/17171218?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2-extensions","html_url":"https://github.com/wso2-extensions","followers_url":"https://api.github.com/users/wso2-extensions/followers","following_url":"https://api.github.com/users/wso2-extensions/following{/other_user}","gists_url":"https://api.github.com/users/wso2-extensions/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2-extensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2-extensions/subscriptions","organizations_url":"https://api.github.com/users/wso2-extensions/orgs","repos_url":"https://api.github.com/users/wso2-extensions/repos","events_url":"https://api.github.com/users/wso2-extensions/events{/privacy}","received_events_url":"https://api.github.com/users/wso2-extensions/received_events","type":"Organization","site_admin":false},"repo":{"id":52766196,"name":"identity-inbound-provisioning-scim","full_name":"wso2-extensions/identity-inbound-provisioning-scim","owner":{"login":"wso2-extensions","id":17171218,"avatar_url":"https://avatars.githubusercontent.com/u/17171218?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2-extensions","html_url":"https://github.com/wso2-extensions","followers_url":"https://api.github.com/users/wso2-extensions/followers","following_url":"https://api.github.com/users/wso2-extensions/following{/other_user}","gists_url":"https://api.github.com/users/wso2-extensions/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2-extensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2-extensions/subscriptions","organizations_url":"https://api.github.com/users/wso2-extensions/orgs","repos_url":"https://api.github.com/users/wso2-extensions/repos","events_url":"https://api.github.com/users/wso2-extensions/events{/privacy}","received_events_url":"https://api.github.com/users/wso2-extensions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wso2-extensions/identity-inbound-provisioning-scim","description":"","fork":false,"url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim","forks_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/forks","keys_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/teams","hooks_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/hooks","issue_events_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/issues/events{/number}","events_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/events","assignees_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/assignees{/user}","branches_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/branches{/branch}","tags_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/tags","blobs_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/languages","stargazers_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/stargazers","contributors_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/contributors","subscribers_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/subscribers","subscription_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/subscription","commits_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/contents/{+path}","compare_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/merges","archive_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/downloads","issues_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/issues{/number}","pulls_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/labels{/name}","releases_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/releases{/id}","deployments_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/deployments","created_at":"2016-02-29T05:25:27Z","updated_at":"2016-03-03T05:56:41Z","pushed_at":"2016-09-06T10:33:56Z","git_url":"git://github.com/wso2-extensions/identity-inbound-provisioning-scim.git","ssh_url":"git@github.com:wso2-extensions/identity-inbound-provisioning-scim.git","clone_url":"https://github.com/wso2-extensions/identity-inbound-provisioning-scim.git","svn_url":"https://github.com/wso2-extensions/identity-inbound-provisioning-scim","homepage":null,"size":344,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":2,"forks":15,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2-extensions:master","ref":"master","sha":"0c7f28a74dc661626e23ef90c4804948cb0a751e","user":{"login":"wso2-extensions","id":17171218,"avatar_url":"https://avatars.githubusercontent.com/u/17171218?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2-extensions","html_url":"https://github.com/wso2-extensions","followers_url":"https://api.github.com/users/wso2-extensions/followers","following_url":"https://api.github.com/users/wso2-extensions/following{/other_user}","gists_url":"https://api.github.com/users/wso2-extensions/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2-extensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2-extensions/subscriptions","organizations_url":"https://api.github.com/users/wso2-extensions/orgs","repos_url":"https://api.github.com/users/wso2-extensions/repos","events_url":"https://api.github.com/users/wso2-extensions/events{/privacy}","received_events_url":"https://api.github.com/users/wso2-extensions/received_events","type":"Organization","site_admin":false},"repo":{"id":52766196,"name":"identity-inbound-provisioning-scim","full_name":"wso2-extensions/identity-inbound-provisioning-scim","owner":{"login":"wso2-extensions","id":17171218,"avatar_url":"https://avatars.githubusercontent.com/u/17171218?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2-extensions","html_url":"https://github.com/wso2-extensions","followers_url":"https://api.github.com/users/wso2-extensions/followers","following_url":"https://api.github.com/users/wso2-extensions/following{/other_user}","gists_url":"https://api.github.com/users/wso2-extensions/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2-extensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2-extensions/subscriptions","organizations_url":"https://api.github.com/users/wso2-extensions/orgs","repos_url":"https://api.github.com/users/wso2-extensions/repos","events_url":"https://api.github.com/users/wso2-extensions/events{/privacy}","received_events_url":"https://api.github.com/users/wso2-extensions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wso2-extensions/identity-inbound-provisioning-scim","description":"","fork":false,"url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim","forks_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/forks","keys_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/teams","hooks_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/hooks","issue_events_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/issues/events{/number}","events_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/events","assignees_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/assignees{/user}","branches_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/branches{/branch}","tags_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/tags","blobs_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/languages","stargazers_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/stargazers","contributors_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/contributors","subscribers_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/subscribers","subscription_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/subscription","commits_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/contents/{+path}","compare_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/merges","archive_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/downloads","issues_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/issues{/number}","pulls_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/labels{/name}","releases_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/releases{/id}","deployments_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/deployments","created_at":"2016-02-29T05:25:27Z","updated_at":"2016-03-03T05:56:41Z","pushed_at":"2016-09-06T10:33:56Z","git_url":"git://github.com/wso2-extensions/identity-inbound-provisioning-scim.git","ssh_url":"git@github.com:wso2-extensions/identity-inbound-provisioning-scim.git","clone_url":"https://github.com/wso2-extensions/identity-inbound-provisioning-scim.git","svn_url":"https://github.com/wso2-extensions/identity-inbound-provisioning-scim","homepage":null,"size":344,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":2,"forks":15,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/pulls/22"},"html":{"href":"https://github.com/wso2-extensions/identity-inbound-provisioning-scim/pull/22"},"issue":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/issues/22"},"comments":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-provisioning-scim/statuses/246d5c8d41715f47a15a559debe48992b69342b3"}}}}
{"actor":{"display_login":"GayanM"}}