{"action":"opened","number":11402,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11402","id":86026090,"html_url":"https://github.com/ManageIQ/manageiq/pull/11402","diff_url":"https://github.com/ManageIQ/manageiq/pull/11402.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/11402.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11402","number":11402,"state":"open","locked":false,"title":"ArbitrationProfile API bug fix","user":{"login":"jntullo","id":2433314,"avatar_url":"https://avatars.githubusercontent.com/u/2433314?v=3","gravatar_id":"","url":"https://api.github.com/users/jntullo","html_url":"https://github.com/jntullo","followers_url":"https://api.github.com/users/jntullo/followers","following_url":"https://api.github.com/users/jntullo/following{/other_user}","gists_url":"https://api.github.com/users/jntullo/gists{/gist_id}","starred_url":"https://api.github.com/users/jntullo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jntullo/subscriptions","organizations_url":"https://api.github.com/users/jntullo/orgs","repos_url":"https://api.github.com/users/jntullo/repos","events_url":"https://api.github.com/users/jntullo/events{/privacy}","received_events_url":"https://api.github.com/users/jntullo/received_events","type":"User","site_admin":false},"body":"When creating an ArbitrationProfile via the API, the Profile was being created successfully but was throwing the following error:\r\n\r\n```\r\n{\r\n\"error\":{\r\n\"kind\":\"internal_server_error\",\r\n\"message\":\"undefined method `validate_profile' for #\\u003cApi::ArbitrationProfilesController:0x007fda2a8defd0\\u003e\",\r\n\"klass\":\"NoMethodError\"\r\n}\r\n}\r\n```\r\nas reported by @jeff-phillips-18.\r\n\r\nEnded up simplifying and doing the validation within the `create_resource`. Also added in http status checks into the tests to make sure this issue can be caught in the future.\r\n\r\n@miq-bot add_label service broker, api ","created_at":"2016-09-20T18:02:44Z","updated_at":"2016-09-20T18:02:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11402/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11402/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11402/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/78fe9a8ff3b7d8754fb0890aa6b0c088cf45bcc4","head":{"label":"jntullo:arbitration_profile_fix","ref":"arbitration_profile_fix","sha":"78fe9a8ff3b7d8754fb0890aa6b0c088cf45bcc4","user":{"login":"jntullo","id":2433314,"avatar_url":"https://avatars.githubusercontent.com/u/2433314?v=3","gravatar_id":"","url":"https://api.github.com/users/jntullo","html_url":"https://github.com/jntullo","followers_url":"https://api.github.com/users/jntullo/followers","following_url":"https://api.github.com/users/jntullo/following{/other_user}","gists_url":"https://api.github.com/users/jntullo/gists{/gist_id}","starred_url":"https://api.github.com/users/jntullo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jntullo/subscriptions","organizations_url":"https://api.github.com/users/jntullo/orgs","repos_url":"https://api.github.com/users/jntullo/repos","events_url":"https://api.github.com/users/jntullo/events{/privacy}","received_events_url":"https://api.github.com/users/jntullo/received_events","type":"User","site_admin":false},"repo":{"id":60654025,"name":"manageiq","full_name":"jntullo/manageiq","owner":{"login":"jntullo","id":2433314,"avatar_url":"https://avatars.githubusercontent.com/u/2433314?v=3","gravatar_id":"","url":"https://api.github.com/users/jntullo","html_url":"https://github.com/jntullo","followers_url":"https://api.github.com/users/jntullo/followers","following_url":"https://api.github.com/users/jntullo/following{/other_user}","gists_url":"https://api.github.com/users/jntullo/gists{/gist_id}","starred_url":"https://api.github.com/users/jntullo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jntullo/subscriptions","organizations_url":"https://api.github.com/users/jntullo/orgs","repos_url":"https://api.github.com/users/jntullo/repos","events_url":"https://api.github.com/users/jntullo/events{/privacy}","received_events_url":"https://api.github.com/users/jntullo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jntullo/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/jntullo/manageiq","forks_url":"https://api.github.com/repos/jntullo/manageiq/forks","keys_url":"https://api.github.com/repos/jntullo/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jntullo/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jntullo/manageiq/teams","hooks_url":"https://api.github.com/repos/jntullo/manageiq/hooks","issue_events_url":"https://api.github.com/repos/jntullo/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/jntullo/manageiq/events","assignees_url":"https://api.github.com/repos/jntullo/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/jntullo/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/jntullo/manageiq/tags","blobs_url":"https://api.github.com/repos/jntullo/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jntullo/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jntullo/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/jntullo/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jntullo/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/jntullo/manageiq/languages","stargazers_url":"https://api.github.com/repos/jntullo/manageiq/stargazers","contributors_url":"https://api.github.com/repos/jntullo/manageiq/contributors","subscribers_url":"https://api.github.com/repos/jntullo/manageiq/subscribers","subscription_url":"https://api.github.com/repos/jntullo/manageiq/subscription","commits_url":"https://api.github.com/repos/jntullo/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/jntullo/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/jntullo/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/jntullo/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/jntullo/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/jntullo/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jntullo/manageiq/merges","archive_url":"https://api.github.com/repos/jntullo/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jntullo/manageiq/downloads","issues_url":"https://api.github.com/repos/jntullo/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/jntullo/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/jntullo/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/jntullo/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jntullo/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/jntullo/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/jntullo/manageiq/deployments","created_at":"2016-06-07T23:41:12Z","updated_at":"2016-06-07T23:41:33Z","pushed_at":"2016-09-20T18:02:24Z","git_url":"git://github.com/jntullo/manageiq.git","ssh_url":"git@github.com:jntullo/manageiq.git","clone_url":"https://github.com/jntullo/manageiq.git","svn_url":"https://github.com/jntullo/manageiq","homepage":"manageiq.org","size":157256,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"ca5afae5cf68660f1beb2612015c4007ac89d502","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Open-Source Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-09-20T07:31:50Z","pushed_at":"2016-09-20T17:14:55Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":203532,"stargazers_count":322,"watchers_count":322,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":350,"mirror_url":null,"open_issues_count":844,"forks":350,"open_issues":844,"watchers":322,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11402"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/11402"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/11402"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/11402/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11402/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11402/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/78fe9a8ff3b7d8754fb0890aa6b0c088cf45bcc4"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":12,"deletions":10,"changed_files":2}}
{"actor":{"display_login":"jntullo"}}