{"action":"created","comment":{"url":"https://api.github.com/repos/oe-lite/core/pulls/comments/85709133","pull_request_review_id":6407854,"id":85709133,"diff_hunk":"@@ -3,19 +3,30 @@ HOMEPAGE = \"http://www.gnu.org/software/readline/\"\n \n RECIPE_TYPES = \"machine native sdk\"\n \n-SRC_URI = \"ftp://ftp.gnu.org/gnu/readline/readline-${PV}.tar.gz\"\n+SRC_URI = \"ftp://ftp.gnu.org/gnu/readline/readline-${PV}.tar.gz \\\n+           file://0000-curses-link.patch\"\n \n inherit autotools make-vpath\n \n #Only used for Aarch64\n AUTOCONFDIRS = \"/support\"\n \n+EXTRA_OECONF += \"${TERMCAP_OECONF}\"\n+TERMCAP_OECONF = \" ac_cv_lib_ncurses_tgetent=yes bash_cv_termcap_lib=libncurses\"\n+TERMCAP_OECONF:HOST_OS_mingw32 = \"\"\n+\n inherit auto-package-libs\n AUTO_PACKAGE_LIBS = \"readline history\"\n+AUTO_PACKAGE_LIBS_DEPENDS = \"libc ${TERMCAP}\"\n+AUTO_PACKAGE_LIBS_RDEPENDS = \"libc ${TERMCAP}\"\n AUTO_PACKAGE_LIBS_DEV_DEPENDS = \"${PN}-dev\"\n AUTO_PACKAGE_LIBS_DEV_RDEPENDS = \"${PN}-dev\"\n \n+PROVIDES_${PN}-libreadline = \"libreadline-6\"\n+PROVIDES_${PN}-libhistory = \"libhistory-6\"","path":"recipes/readline/readline.inc","position":25,"original_position":25,"commit_id":"d67db437c8bd5559fbd39dafdef858b13f3cc5e0","original_commit_id":"d67db437c8bd5559fbd39dafdef858b13f3cc5e0","user":{"login":"esben","id":122934,"avatar_url":"https://avatars.githubusercontent.com/u/122934?v=3","gravatar_id":"","url":"https://api.github.com/users/esben","html_url":"https://github.com/esben","followers_url":"https://api.github.com/users/esben/followers","following_url":"https://api.github.com/users/esben/following{/other_user}","gists_url":"https://api.github.com/users/esben/gists{/gist_id}","starred_url":"https://api.github.com/users/esben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esben/subscriptions","organizations_url":"https://api.github.com/users/esben/orgs","repos_url":"https://api.github.com/users/esben/repos","events_url":"https://api.github.com/users/esben/events{/privacy}","received_events_url":"https://api.github.com/users/esben/received_events","type":"User","site_admin":false},"body":"Why are you not using\r\n```\r\nLIBRARY_VERSION = \"6\"\r\n```\r\n?","created_at":"2016-10-31T09:54:35Z","updated_at":"2016-10-31T09:54:49Z","html_url":"https://github.com/oe-lite/core/pull/180#discussion_r85709133","pull_request_url":"https://api.github.com/repos/oe-lite/core/pulls/180","_links":{"self":{"href":"https://api.github.com/repos/oe-lite/core/pulls/comments/85709133"},"html":{"href":"https://github.com/oe-lite/core/pull/180#discussion_r85709133"},"pull_request":{"href":"https://api.github.com/repos/oe-lite/core/pulls/180"}}},"pull_request":{"url":"https://api.github.com/repos/oe-lite/core/pulls/180","id":91486265,"html_url":"https://github.com/oe-lite/core/pull/180","diff_url":"https://github.com/oe-lite/core/pull/180.diff","patch_url":"https://github.com/oe-lite/core/pull/180.patch","issue_url":"https://api.github.com/repos/oe-lite/core/issues/180","number":180,"state":"open","locked":false,"title":"readline: link with ncurses","user":{"login":"sknsean","id":12713608,"avatar_url":"https://avatars.githubusercontent.com/u/12713608?v=3","gravatar_id":"","url":"https://api.github.com/users/sknsean","html_url":"https://github.com/sknsean","followers_url":"https://api.github.com/users/sknsean/followers","following_url":"https://api.github.com/users/sknsean/following{/other_user}","gists_url":"https://api.github.com/users/sknsean/gists{/gist_id}","starred_url":"https://api.github.com/users/sknsean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sknsean/subscriptions","organizations_url":"https://api.github.com/users/sknsean/orgs","repos_url":"https://api.github.com/users/sknsean/repos","events_url":"https://api.github.com/users/sknsean/events{/privacy}","received_events_url":"https://api.github.com/users/sknsean/received_events","type":"User","site_admin":false},"body":"readline needs ncurses for termcap, so we actually needs to link\nwith it and add it to RDEPENDS.\n\nconfigure for readline is broken so we have to hard add linking with\nncurses.\n\nSigned-off-by: Sean Nyekjaer sean@nyekjaer.dk\n","created_at":"2016-10-29T11:15:48Z","updated_at":"2016-10-31T09:54:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de83ccd00a7f4474d42ce9e1b70af98241e9e25a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/oe-lite/core/pulls/180/commits","review_comments_url":"https://api.github.com/repos/oe-lite/core/pulls/180/comments","review_comment_url":"https://api.github.com/repos/oe-lite/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oe-lite/core/issues/180/comments","statuses_url":"https://api.github.com/repos/oe-lite/core/statuses/d67db437c8bd5559fbd39dafdef858b13f3cc5e0","head":{"label":"sknsean:readline","ref":"readline","sha":"d67db437c8bd5559fbd39dafdef858b13f3cc5e0","user":{"login":"sknsean","id":12713608,"avatar_url":"https://avatars.githubusercontent.com/u/12713608?v=3","gravatar_id":"","url":"https://api.github.com/users/sknsean","html_url":"https://github.com/sknsean","followers_url":"https://api.github.com/users/sknsean/followers","following_url":"https://api.github.com/users/sknsean/following{/other_user}","gists_url":"https://api.github.com/users/sknsean/gists{/gist_id}","starred_url":"https://api.github.com/users/sknsean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sknsean/subscriptions","organizations_url":"https://api.github.com/users/sknsean/orgs","repos_url":"https://api.github.com/users/sknsean/repos","events_url":"https://api.github.com/users/sknsean/events{/privacy}","received_events_url":"https://api.github.com/users/sknsean/received_events","type":"User","site_admin":false},"repo":{"id":36863927,"name":"core","full_name":"sknsean/core","owner":{"login":"sknsean","id":12713608,"avatar_url":"https://avatars.githubusercontent.com/u/12713608?v=3","gravatar_id":"","url":"https://api.github.com/users/sknsean","html_url":"https://github.com/sknsean","followers_url":"https://api.github.com/users/sknsean/followers","following_url":"https://api.github.com/users/sknsean/following{/other_user}","gists_url":"https://api.github.com/users/sknsean/gists{/gist_id}","starred_url":"https://api.github.com/users/sknsean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sknsean/subscriptions","organizations_url":"https://api.github.com/users/sknsean/orgs","repos_url":"https://api.github.com/users/sknsean/repos","events_url":"https://api.github.com/users/sknsean/events{/privacy}","received_events_url":"https://api.github.com/users/sknsean/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sknsean/core","description":"official meta/core repository","fork":true,"url":"https://api.github.com/repos/sknsean/core","forks_url":"https://api.github.com/repos/sknsean/core/forks","keys_url":"https://api.github.com/repos/sknsean/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sknsean/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sknsean/core/teams","hooks_url":"https://api.github.com/repos/sknsean/core/hooks","issue_events_url":"https://api.github.com/repos/sknsean/core/issues/events{/number}","events_url":"https://api.github.com/repos/sknsean/core/events","assignees_url":"https://api.github.com/repos/sknsean/core/assignees{/user}","branches_url":"https://api.github.com/repos/sknsean/core/branches{/branch}","tags_url":"https://api.github.com/repos/sknsean/core/tags","blobs_url":"https://api.github.com/repos/sknsean/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sknsean/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sknsean/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/sknsean/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sknsean/core/statuses/{sha}","languages_url":"https://api.github.com/repos/sknsean/core/languages","stargazers_url":"https://api.github.com/repos/sknsean/core/stargazers","contributors_url":"https://api.github.com/repos/sknsean/core/contributors","subscribers_url":"https://api.github.com/repos/sknsean/core/subscribers","subscription_url":"https://api.github.com/repos/sknsean/core/subscription","commits_url":"https://api.github.com/repos/sknsean/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/sknsean/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/sknsean/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/sknsean/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/sknsean/core/contents/{+path}","compare_url":"https://api.github.com/repos/sknsean/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sknsean/core/merges","archive_url":"https://api.github.com/repos/sknsean/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sknsean/core/downloads","issues_url":"https://api.github.com/repos/sknsean/core/issues{/number}","pulls_url":"https://api.github.com/repos/sknsean/core/pulls{/number}","milestones_url":"https://api.github.com/repos/sknsean/core/milestones{/number}","notifications_url":"https://api.github.com/repos/sknsean/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sknsean/core/labels{/name}","releases_url":"https://api.github.com/repos/sknsean/core/releases{/id}","deployments_url":"https://api.github.com/repos/sknsean/core/deployments","created_at":"2015-06-04T10:29:21Z","updated_at":"2016-10-25T11:47:38Z","pushed_at":"2016-10-31T07:54:03Z","git_url":"git://github.com/sknsean/core.git","ssh_url":"git@github.com:sknsean/core.git","clone_url":"https://github.com/sknsean/core.git","svn_url":"https://github.com/sknsean/core","homepage":null,"size":4898,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"oe-lite:master","ref":"master","sha":"fef5add696feef0f1f5b36819d3e0e1d0fc25a6f","user":{"login":"oe-lite","id":7683915,"avatar_url":"https://avatars.githubusercontent.com/u/7683915?v=3","gravatar_id":"","url":"https://api.github.com/users/oe-lite","html_url":"https://github.com/oe-lite","followers_url":"https://api.github.com/users/oe-lite/followers","following_url":"https://api.github.com/users/oe-lite/following{/other_user}","gists_url":"https://api.github.com/users/oe-lite/gists{/gist_id}","starred_url":"https://api.github.com/users/oe-lite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oe-lite/subscriptions","organizations_url":"https://api.github.com/users/oe-lite/orgs","repos_url":"https://api.github.com/users/oe-lite/repos","events_url":"https://api.github.com/users/oe-lite/events{/privacy}","received_events_url":"https://api.github.com/users/oe-lite/received_events","type":"Organization","site_admin":false},"repo":{"id":26163604,"name":"core","full_name":"oe-lite/core","owner":{"login":"oe-lite","id":7683915,"avatar_url":"https://avatars.githubusercontent.com/u/7683915?v=3","gravatar_id":"","url":"https://api.github.com/users/oe-lite","html_url":"https://github.com/oe-lite","followers_url":"https://api.github.com/users/oe-lite/followers","following_url":"https://api.github.com/users/oe-lite/following{/other_user}","gists_url":"https://api.github.com/users/oe-lite/gists{/gist_id}","starred_url":"https://api.github.com/users/oe-lite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oe-lite/subscriptions","organizations_url":"https://api.github.com/users/oe-lite/orgs","repos_url":"https://api.github.com/users/oe-lite/repos","events_url":"https://api.github.com/users/oe-lite/events{/privacy}","received_events_url":"https://api.github.com/users/oe-lite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oe-lite/core","description":"Official OE-lite/core repository","fork":false,"url":"https://api.github.com/repos/oe-lite/core","forks_url":"https://api.github.com/repos/oe-lite/core/forks","keys_url":"https://api.github.com/repos/oe-lite/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oe-lite/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oe-lite/core/teams","hooks_url":"https://api.github.com/repos/oe-lite/core/hooks","issue_events_url":"https://api.github.com/repos/oe-lite/core/issues/events{/number}","events_url":"https://api.github.com/repos/oe-lite/core/events","assignees_url":"https://api.github.com/repos/oe-lite/core/assignees{/user}","branches_url":"https://api.github.com/repos/oe-lite/core/branches{/branch}","tags_url":"https://api.github.com/repos/oe-lite/core/tags","blobs_url":"https://api.github.com/repos/oe-lite/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oe-lite/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oe-lite/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/oe-lite/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oe-lite/core/statuses/{sha}","languages_url":"https://api.github.com/repos/oe-lite/core/languages","stargazers_url":"https://api.github.com/repos/oe-lite/core/stargazers","contributors_url":"https://api.github.com/repos/oe-lite/core/contributors","subscribers_url":"https://api.github.com/repos/oe-lite/core/subscribers","subscription_url":"https://api.github.com/repos/oe-lite/core/subscription","commits_url":"https://api.github.com/repos/oe-lite/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/oe-lite/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/oe-lite/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/oe-lite/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/oe-lite/core/contents/{+path}","compare_url":"https://api.github.com/repos/oe-lite/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oe-lite/core/merges","archive_url":"https://api.github.com/repos/oe-lite/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oe-lite/core/downloads","issues_url":"https://api.github.com/repos/oe-lite/core/issues{/number}","pulls_url":"https://api.github.com/repos/oe-lite/core/pulls{/number}","milestones_url":"https://api.github.com/repos/oe-lite/core/milestones{/number}","notifications_url":"https://api.github.com/repos/oe-lite/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oe-lite/core/labels{/name}","releases_url":"https://api.github.com/repos/oe-lite/core/releases{/id}","deployments_url":"https://api.github.com/repos/oe-lite/core/deployments","created_at":"2014-11-04T10:14:38Z","updated_at":"2016-10-28T08:37:05Z","pushed_at":"2016-10-31T07:54:03Z","git_url":"git://github.com/oe-lite/core.git","ssh_url":"git@github.com:oe-lite/core.git","clone_url":"https://github.com/oe-lite/core.git","svn_url":"https://github.com/oe-lite/core","homepage":"","size":5051,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":32,"forks":14,"open_issues":32,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oe-lite/core/pulls/180"},"html":{"href":"https://github.com/oe-lite/core/pull/180"},"issue":{"href":"https://api.github.com/repos/oe-lite/core/issues/180"},"comments":{"href":"https://api.github.com/repos/oe-lite/core/issues/180/comments"},"review_comments":{"href":"https://api.github.com/repos/oe-lite/core/pulls/180/comments"},"review_comment":{"href":"https://api.github.com/repos/oe-lite/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oe-lite/core/pulls/180/commits"},"statuses":{"href":"https://api.github.com/repos/oe-lite/core/statuses/d67db437c8bd5559fbd39dafdef858b13f3cc5e0"}}}}
{"actor":{"display_login":"esben"}}