{"action":"created","comment":{"url":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/comments/65823163","id":65823163,"diff_hunk":"@@ -179,24 +180,23 @@ def test_get_event_from_type_node_BaseEvent(self):\n     def test_get_event_from_type_node_Inhereted_AuditEvent(self):\n         ev = opcua.common.events.get_event_obj_from_type_node(opcua.Node(self.opc.iserver.isession, ua.NodeId(ua.ObjectIds.AuditEventType)))\n         self.assertIsNot(ev, None)  # we did not receive event\n-        self.assertIsInstance(ev, ua.BaseEvent)\n-        self.assertIsInstance(ev, ua.AuditEvent)\n+        self.assertIsInstance(ev, BaseEvent)\n+        self.assertIsInstance(ev, AuditEvent)\n         self.assertEqual(ev.EventType, ua.NodeId(ua.ObjectIds.AuditEventType))\n-        self.assertEqual(ev.Severity, ua.Variant(1, ua.VariantType.UInt16))","path":"tests/tests_server.py","position":17,"original_position":17,"commit_id":"9490ac05d68fa06ff0e6e37e13905e3af5c3197c","original_commit_id":"9490ac05d68fa06ff0e6e37e13905e3af5c3197c","user":{"login":"oroulet","id":2564046,"avatar_url":"https://avatars.githubusercontent.com/u/2564046?v=3","gravatar_id":"","url":"https://api.github.com/users/oroulet","html_url":"https://github.com/oroulet","followers_url":"https://api.github.com/users/oroulet/followers","following_url":"https://api.github.com/users/oroulet/following{/other_user}","gists_url":"https://api.github.com/users/oroulet/gists{/gist_id}","starred_url":"https://api.github.com/users/oroulet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oroulet/subscriptions","organizations_url":"https://api.github.com/users/oroulet/orgs","repos_url":"https://api.github.com/users/oroulet/repos","events_url":"https://api.github.com/users/oroulet/events{/privacy}","received_events_url":"https://api.github.com/users/oroulet/received_events","type":"User","site_admin":false},"body":"In events some properties were python built-in, other variants, I changed class to only use built-in. Type is stored in self.data_type (yes a bit ugly). We can add test for data type if you think it is important.\r\nAnyway events are defined by constructing event type where data type can be clearly specified ","created_at":"2016-06-05T19:38:22Z","updated_at":"2016-06-05T19:38:22Z","html_url":"https://github.com/FreeOpcUa/python-opcua/pull/200#discussion_r65823163","pull_request_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/200","_links":{"self":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/comments/65823163"},"html":{"href":"https://github.com/FreeOpcUa/python-opcua/pull/200#discussion_r65823163"},"pull_request":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/200"}}},"pull_request":{"url":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/200","id":72595899,"html_url":"https://github.com/FreeOpcUa/python-opcua/pull/200","diff_url":"https://github.com/FreeOpcUa/python-opcua/pull/200.diff","patch_url":"https://github.com/FreeOpcUa/python-opcua/pull/200.patch","issue_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues/200","number":200,"state":"closed","locked":false,"title":"fix, renaming and restructure of event stuff","user":{"login":"oroulet","id":2564046,"avatar_url":"https://avatars.githubusercontent.com/u/2564046?v=3","gravatar_id":"","url":"https://api.github.com/users/oroulet","html_url":"https://github.com/oroulet","followers_url":"https://api.github.com/users/oroulet/followers","following_url":"https://api.github.com/users/oroulet/following{/other_user}","gists_url":"https://api.github.com/users/oroulet/gists{/gist_id}","starred_url":"https://api.github.com/users/oroulet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oroulet/subscriptions","organizations_url":"https://api.github.com/users/oroulet/orgs","repos_url":"https://api.github.com/users/oroulet/repos","events_url":"https://api.github.com/users/oroulet/events{/privacy}","received_events_url":"https://api.github.com/users/oroulet/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-04T07:34:14Z","updated_at":"2016-06-05T19:38:22Z","closed_at":"2016-06-04T20:00:31Z","merged_at":"2016-06-04T20:00:31Z","merge_commit_sha":"3620aa0d71d5ba2153560ee77af766b5d4abe281","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/200/commits","review_comments_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/200/comments","review_comment_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues/200/comments","statuses_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/statuses/9490ac05d68fa06ff0e6e37e13905e3af5c3197c","head":{"label":"FreeOpcUa:ev2","ref":"ev2","sha":"9490ac05d68fa06ff0e6e37e13905e3af5c3197c","user":{"login":"FreeOpcUa","id":7480453,"avatar_url":"https://avatars.githubusercontent.com/u/7480453?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeOpcUa","html_url":"https://github.com/FreeOpcUa","followers_url":"https://api.github.com/users/FreeOpcUa/followers","following_url":"https://api.github.com/users/FreeOpcUa/following{/other_user}","gists_url":"https://api.github.com/users/FreeOpcUa/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeOpcUa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeOpcUa/subscriptions","organizations_url":"https://api.github.com/users/FreeOpcUa/orgs","repos_url":"https://api.github.com/users/FreeOpcUa/repos","events_url":"https://api.github.com/users/FreeOpcUa/events{/privacy}","received_events_url":"https://api.github.com/users/FreeOpcUa/received_events","type":"Organization","site_admin":false},"repo":{"id":31074280,"name":"python-opcua","full_name":"FreeOpcUa/python-opcua","owner":{"login":"FreeOpcUa","id":7480453,"avatar_url":"https://avatars.githubusercontent.com/u/7480453?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeOpcUa","html_url":"https://github.com/FreeOpcUa","followers_url":"https://api.github.com/users/FreeOpcUa/followers","following_url":"https://api.github.com/users/FreeOpcUa/following{/other_user}","gists_url":"https://api.github.com/users/FreeOpcUa/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeOpcUa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeOpcUa/subscriptions","organizations_url":"https://api.github.com/users/FreeOpcUa/orgs","repos_url":"https://api.github.com/users/FreeOpcUa/repos","events_url":"https://api.github.com/users/FreeOpcUa/events{/privacy}","received_events_url":"https://api.github.com/users/FreeOpcUa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FreeOpcUa/python-opcua","description":"LGPL Pure Python OPC-UA Client and Server","fork":false,"url":"https://api.github.com/repos/FreeOpcUa/python-opcua","forks_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/forks","keys_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/teams","hooks_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/hooks","issue_events_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues/events{/number}","events_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/events","assignees_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/assignees{/user}","branches_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/branches{/branch}","tags_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/tags","blobs_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/statuses/{sha}","languages_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/languages","stargazers_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/stargazers","contributors_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/contributors","subscribers_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/subscribers","subscription_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/subscription","commits_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues/comments{/number}","contents_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/contents/{+path}","compare_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/merges","archive_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/downloads","issues_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues{/number}","pulls_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls{/number}","milestones_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/milestones{/number}","notifications_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/labels{/name}","releases_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/releases{/id}","deployments_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/deployments","created_at":"2015-02-20T16:46:53Z","updated_at":"2016-06-03T16:43:32Z","pushed_at":"2016-06-04T20:02:08Z","git_url":"git://github.com/FreeOpcUa/python-opcua.git","ssh_url":"git@github.com:FreeOpcUa/python-opcua.git","clone_url":"https://github.com/FreeOpcUa/python-opcua.git","svn_url":"https://github.com/FreeOpcUa/python-opcua","homepage":"http://freeopcua.github.io/","size":2863,"stargazers_count":63,"watchers_count":63,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":21,"forks":32,"open_issues":21,"watchers":63,"default_branch":"master"}},"base":{"label":"FreeOpcUa:master","ref":"master","sha":"c5c8fe8e945d34126d8550c63d23a74148cef525","user":{"login":"FreeOpcUa","id":7480453,"avatar_url":"https://avatars.githubusercontent.com/u/7480453?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeOpcUa","html_url":"https://github.com/FreeOpcUa","followers_url":"https://api.github.com/users/FreeOpcUa/followers","following_url":"https://api.github.com/users/FreeOpcUa/following{/other_user}","gists_url":"https://api.github.com/users/FreeOpcUa/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeOpcUa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeOpcUa/subscriptions","organizations_url":"https://api.github.com/users/FreeOpcUa/orgs","repos_url":"https://api.github.com/users/FreeOpcUa/repos","events_url":"https://api.github.com/users/FreeOpcUa/events{/privacy}","received_events_url":"https://api.github.com/users/FreeOpcUa/received_events","type":"Organization","site_admin":false},"repo":{"id":31074280,"name":"python-opcua","full_name":"FreeOpcUa/python-opcua","owner":{"login":"FreeOpcUa","id":7480453,"avatar_url":"https://avatars.githubusercontent.com/u/7480453?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeOpcUa","html_url":"https://github.com/FreeOpcUa","followers_url":"https://api.github.com/users/FreeOpcUa/followers","following_url":"https://api.github.com/users/FreeOpcUa/following{/other_user}","gists_url":"https://api.github.com/users/FreeOpcUa/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeOpcUa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeOpcUa/subscriptions","organizations_url":"https://api.github.com/users/FreeOpcUa/orgs","repos_url":"https://api.github.com/users/FreeOpcUa/repos","events_url":"https://api.github.com/users/FreeOpcUa/events{/privacy}","received_events_url":"https://api.github.com/users/FreeOpcUa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FreeOpcUa/python-opcua","description":"LGPL Pure Python OPC-UA Client and Server","fork":false,"url":"https://api.github.com/repos/FreeOpcUa/python-opcua","forks_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/forks","keys_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/teams","hooks_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/hooks","issue_events_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues/events{/number}","events_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/events","assignees_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/assignees{/user}","branches_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/branches{/branch}","tags_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/tags","blobs_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/statuses/{sha}","languages_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/languages","stargazers_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/stargazers","contributors_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/contributors","subscribers_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/subscribers","subscription_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/subscription","commits_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues/comments{/number}","contents_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/contents/{+path}","compare_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/merges","archive_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/downloads","issues_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues{/number}","pulls_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls{/number}","milestones_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/milestones{/number}","notifications_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/labels{/name}","releases_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/releases{/id}","deployments_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/deployments","created_at":"2015-02-20T16:46:53Z","updated_at":"2016-06-03T16:43:32Z","pushed_at":"2016-06-04T20:02:08Z","git_url":"git://github.com/FreeOpcUa/python-opcua.git","ssh_url":"git@github.com:FreeOpcUa/python-opcua.git","clone_url":"https://github.com/FreeOpcUa/python-opcua.git","svn_url":"https://github.com/FreeOpcUa/python-opcua","homepage":"http://freeopcua.github.io/","size":2863,"stargazers_count":63,"watchers_count":63,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":21,"forks":32,"open_issues":21,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/200"},"html":{"href":"https://github.com/FreeOpcUa/python-opcua/pull/200"},"issue":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues/200"},"comments":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues/200/comments"},"review_comments":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/200/comments"},"review_comment":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/200/commits"},"statuses":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/statuses/9490ac05d68fa06ff0e6e37e13905e3af5c3197c"}}}}
{"actor":{"display_login":"oroulet"}}