{"action":"created","comment":{"url":"https://api.github.com/repos/emk/heroku-buildpack-rust/pulls/comments/66260991","id":66260991,"diff_hunk":"@@ -33,31 +33,29 @@ fi\n mkdir -p \"$2\"\n cd \"$2\"\n \n+RUST_HOME=`pwd`/rust-$VERSION\n+\n # Make sure we have the correct Rust binaries and set up PATH.\n-if [ -d rust-cache-$VERSION ]; then\n+if [ -d $RUST_HOME ]; then\n   echo \"-----> Using Rust version $VERSION\"\n else\n   echo \"-----> Downloading Rust version $VERSION binaries from $URL\"","path":"bin/compile","position":11,"original_position":11,"commit_id":"f6ce5b9e0675307a8eab45e1ba6b78010eb13072","original_commit_id":"f6ce5b9e0675307a8eab45e1ba6b78010eb13072","user":{"login":"binarycleric","id":197226,"avatar_url":"https://avatars.githubusercontent.com/u/197226?v=3","gravatar_id":"","url":"https://api.github.com/users/binarycleric","html_url":"https://github.com/binarycleric","followers_url":"https://api.github.com/users/binarycleric/followers","following_url":"https://api.github.com/users/binarycleric/following{/other_user}","gists_url":"https://api.github.com/users/binarycleric/gists{/gist_id}","starred_url":"https://api.github.com/users/binarycleric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binarycleric/subscriptions","organizations_url":"https://api.github.com/users/binarycleric/orgs","repos_url":"https://api.github.com/users/binarycleric/repos","events_url":"https://api.github.com/users/binarycleric/events{/privacy}","received_events_url":"https://api.github.com/users/binarycleric/received_events","type":"User","site_admin":false},"body":"Yes, a good point! I'll try to fix that up as soon as I get a chance. I just started a new job so I lot of my spoons have been going into that.","created_at":"2016-06-08T14:04:12Z","updated_at":"2016-06-08T14:04:12Z","html_url":"https://github.com/emk/heroku-buildpack-rust/pull/8#discussion_r66260991","pull_request_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/emk/heroku-buildpack-rust/pulls/comments/66260991"},"html":{"href":"https://github.com/emk/heroku-buildpack-rust/pull/8#discussion_r66260991"},"pull_request":{"href":"https://api.github.com/repos/emk/heroku-buildpack-rust/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/emk/heroku-buildpack-rust/pulls/8","id":70954759,"html_url":"https://github.com/emk/heroku-buildpack-rust/pull/8","diff_url":"https://github.com/emk/heroku-buildpack-rust/pull/8.diff","patch_url":"https://github.com/emk/heroku-buildpack-rust/pull/8.patch","issue_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/issues/8","number":8,"state":"open","locked":false,"title":"Updated buildpack to use rustup.sh","user":{"login":"binarycleric","id":197226,"avatar_url":"https://avatars.githubusercontent.com/u/197226?v=3","gravatar_id":"","url":"https://api.github.com/users/binarycleric","html_url":"https://github.com/binarycleric","followers_url":"https://api.github.com/users/binarycleric/followers","following_url":"https://api.github.com/users/binarycleric/following{/other_user}","gists_url":"https://api.github.com/users/binarycleric/gists{/gist_id}","starred_url":"https://api.github.com/users/binarycleric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binarycleric/subscriptions","organizations_url":"https://api.github.com/users/binarycleric/orgs","repos_url":"https://api.github.com/users/binarycleric/repos","events_url":"https://api.github.com/users/binarycleric/events{/privacy}","received_events_url":"https://api.github.com/users/binarycleric/received_events","type":"User","site_admin":false},"body":"Previously this buildpack was trying to download and install rust manually which caused many stdlibs to be missing. Rust provides a script to automate a bunch of the install processes and switching to this greatly simplified the buildpack.\r\n\r\nI tried it on a test app using iron and everything seemed to work correctly (https://github.com/binarycleric/resume-api). Forgive any bad code in that repo, I'm still learning Rust.","created_at":"2016-05-21T17:06:05Z","updated_at":"2016-06-08T14:04:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e28c16694ee3dc364a10225e79c2cdf82fde6293","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/pulls/8/commits","review_comments_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/pulls/8/comments","review_comment_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/issues/8/comments","statuses_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/statuses/f6ce5b9e0675307a8eab45e1ba6b78010eb13072","head":{"label":"binarycleric:switching_to_rustup","ref":"switching_to_rustup","sha":"f6ce5b9e0675307a8eab45e1ba6b78010eb13072","user":{"login":"binarycleric","id":197226,"avatar_url":"https://avatars.githubusercontent.com/u/197226?v=3","gravatar_id":"","url":"https://api.github.com/users/binarycleric","html_url":"https://github.com/binarycleric","followers_url":"https://api.github.com/users/binarycleric/followers","following_url":"https://api.github.com/users/binarycleric/following{/other_user}","gists_url":"https://api.github.com/users/binarycleric/gists{/gist_id}","starred_url":"https://api.github.com/users/binarycleric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binarycleric/subscriptions","organizations_url":"https://api.github.com/users/binarycleric/orgs","repos_url":"https://api.github.com/users/binarycleric/repos","events_url":"https://api.github.com/users/binarycleric/events{/privacy}","received_events_url":"https://api.github.com/users/binarycleric/received_events","type":"User","site_admin":false},"repo":{"id":59368167,"name":"heroku-buildpack-rust","full_name":"binarycleric/heroku-buildpack-rust","owner":{"login":"binarycleric","id":197226,"avatar_url":"https://avatars.githubusercontent.com/u/197226?v=3","gravatar_id":"","url":"https://api.github.com/users/binarycleric","html_url":"https://github.com/binarycleric","followers_url":"https://api.github.com/users/binarycleric/followers","following_url":"https://api.github.com/users/binarycleric/following{/other_user}","gists_url":"https://api.github.com/users/binarycleric/gists{/gist_id}","starred_url":"https://api.github.com/users/binarycleric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binarycleric/subscriptions","organizations_url":"https://api.github.com/users/binarycleric/orgs","repos_url":"https://api.github.com/users/binarycleric/repos","events_url":"https://api.github.com/users/binarycleric/events{/privacy}","received_events_url":"https://api.github.com/users/binarycleric/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/binarycleric/heroku-buildpack-rust","description":"A new, from-scratch buildpack for Rust applications on Heroku.","fork":true,"url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust","forks_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/forks","keys_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/teams","hooks_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/hooks","issue_events_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/issues/events{/number}","events_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/events","assignees_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/assignees{/user}","branches_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/branches{/branch}","tags_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/tags","blobs_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/statuses/{sha}","languages_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/languages","stargazers_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/stargazers","contributors_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/contributors","subscribers_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/subscribers","subscription_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/subscription","commits_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/contents/{+path}","compare_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/merges","archive_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/downloads","issues_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/issues{/number}","pulls_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/pulls{/number}","milestones_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/milestones{/number}","notifications_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/labels{/name}","releases_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/releases{/id}","deployments_url":"https://api.github.com/repos/binarycleric/heroku-buildpack-rust/deployments","created_at":"2016-05-21T15:48:26Z","updated_at":"2016-05-21T21:41:45Z","pushed_at":"2016-05-21T17:04:02Z","git_url":"git://github.com/binarycleric/heroku-buildpack-rust.git","ssh_url":"git@github.com:binarycleric/heroku-buildpack-rust.git","clone_url":"https://github.com/binarycleric/heroku-buildpack-rust.git","svn_url":"https://github.com/binarycleric/heroku-buildpack-rust","homepage":null,"size":22,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"emk:master","ref":"master","sha":"78dcb49ef1b2da9ad06fd204fb500a5350fceeed","user":{"login":"emk","id":36963,"avatar_url":"https://avatars.githubusercontent.com/u/36963?v=3","gravatar_id":"","url":"https://api.github.com/users/emk","html_url":"https://github.com/emk","followers_url":"https://api.github.com/users/emk/followers","following_url":"https://api.github.com/users/emk/following{/other_user}","gists_url":"https://api.github.com/users/emk/gists{/gist_id}","starred_url":"https://api.github.com/users/emk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emk/subscriptions","organizations_url":"https://api.github.com/users/emk/orgs","repos_url":"https://api.github.com/users/emk/repos","events_url":"https://api.github.com/users/emk/events{/privacy}","received_events_url":"https://api.github.com/users/emk/received_events","type":"User","site_admin":false},"repo":{"id":20312826,"name":"heroku-buildpack-rust","full_name":"emk/heroku-buildpack-rust","owner":{"login":"emk","id":36963,"avatar_url":"https://avatars.githubusercontent.com/u/36963?v=3","gravatar_id":"","url":"https://api.github.com/users/emk","html_url":"https://github.com/emk","followers_url":"https://api.github.com/users/emk/followers","following_url":"https://api.github.com/users/emk/following{/other_user}","gists_url":"https://api.github.com/users/emk/gists{/gist_id}","starred_url":"https://api.github.com/users/emk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emk/subscriptions","organizations_url":"https://api.github.com/users/emk/orgs","repos_url":"https://api.github.com/users/emk/repos","events_url":"https://api.github.com/users/emk/events{/privacy}","received_events_url":"https://api.github.com/users/emk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emk/heroku-buildpack-rust","description":"A new, from-scratch buildpack for Rust applications on Heroku.","fork":false,"url":"https://api.github.com/repos/emk/heroku-buildpack-rust","forks_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/forks","keys_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/teams","hooks_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/hooks","issue_events_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/issues/events{/number}","events_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/events","assignees_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/assignees{/user}","branches_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/branches{/branch}","tags_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/tags","blobs_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/statuses/{sha}","languages_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/languages","stargazers_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/stargazers","contributors_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/contributors","subscribers_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/subscribers","subscription_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/subscription","commits_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/contents/{+path}","compare_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/merges","archive_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/downloads","issues_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/issues{/number}","pulls_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/pulls{/number}","milestones_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/milestones{/number}","notifications_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/labels{/name}","releases_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/releases{/id}","deployments_url":"https://api.github.com/repos/emk/heroku-buildpack-rust/deployments","created_at":"2014-05-30T00:49:30Z","updated_at":"2016-06-02T01:56:34Z","pushed_at":"2016-05-21T17:06:05Z","git_url":"git://github.com/emk/heroku-buildpack-rust.git","ssh_url":"git@github.com:emk/heroku-buildpack-rust.git","clone_url":"https://github.com/emk/heroku-buildpack-rust.git","svn_url":"https://github.com/emk/heroku-buildpack-rust","homepage":null,"size":326,"stargazers_count":51,"watchers_count":51,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":5,"forks":27,"open_issues":5,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emk/heroku-buildpack-rust/pulls/8"},"html":{"href":"https://github.com/emk/heroku-buildpack-rust/pull/8"},"issue":{"href":"https://api.github.com/repos/emk/heroku-buildpack-rust/issues/8"},"comments":{"href":"https://api.github.com/repos/emk/heroku-buildpack-rust/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/emk/heroku-buildpack-rust/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/emk/heroku-buildpack-rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emk/heroku-buildpack-rust/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/emk/heroku-buildpack-rust/statuses/f6ce5b9e0675307a8eab45e1ba6b78010eb13072"}}}}
{"actor":{"display_login":"binarycleric"}}