{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/22568","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/22568/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/22568/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/22568/events","html_url":"https://github.com/kubernetes/kubernetes/pull/22568","id":138620379,"number":22568,"title":"Considering all nodes for the scheduler cache to allow lookups","user":{"login":"abhgupta","id":1211613,"avatar_url":"https://avatars.githubusercontent.com/u/1211613?v=3","gravatar_id":"","url":"https://api.github.com/users/abhgupta","html_url":"https://github.com/abhgupta","followers_url":"https://api.github.com/users/abhgupta/followers","following_url":"https://api.github.com/users/abhgupta/following{/other_user}","gists_url":"https://api.github.com/users/abhgupta/gists{/gist_id}","starred_url":"https://api.github.com/users/abhgupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhgupta/subscriptions","organizations_url":"https://api.github.com/users/abhgupta/orgs","repos_url":"https://api.github.com/users/abhgupta/repos","events_url":"https://api.github.com/users/abhgupta/events{/privacy}","received_events_url":"https://api.github.com/users/abhgupta/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/ok-to-merge","name":"ok-to-merge","color":"fbca04"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/S","name":"size/S","color":"77bb00"}],"state":"open","locked":false,"assignee":{"login":"davidopp","id":8264113,"avatar_url":"https://avatars.githubusercontent.com/u/8264113?v=3","gravatar_id":"","url":"https://api.github.com/users/davidopp","html_url":"https://github.com/davidopp","followers_url":"https://api.github.com/users/davidopp/followers","following_url":"https://api.github.com/users/davidopp/following{/other_user}","gists_url":"https://api.github.com/users/davidopp/gists{/gist_id}","starred_url":"https://api.github.com/users/davidopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidopp/subscriptions","organizations_url":"https://api.github.com/users/davidopp/orgs","repos_url":"https://api.github.com/users/davidopp/repos","events_url":"https://api.github.com/users/davidopp/events{/privacy}","received_events_url":"https://api.github.com/users/davidopp/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/18","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.3","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/18/labels","id":1638460,"number":18,"title":"v1.3","description":"https://github.com/kubernetes/kubernetes/wiki/Release-1.3","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":145,"closed_issues":476,"state":"open","created_at":"2016-03-11T07:40:20Z","updated_at":"2016-06-05T00:59:34Z","due_on":"2016-06-24T07:00:00Z","closed_at":null},"comments":14,"created_at":"2016-03-04T23:53:23Z","updated_at":"2016-06-05T02:54:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22568","html_url":"https://github.com/kubernetes/kubernetes/pull/22568","diff_url":"https://github.com/kubernetes/kubernetes/pull/22568.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/22568.patch"},"body":"Fixes the actual issue that led me to create https://github.com/kubernetes/kubernetes/issues/22554\r\n\r\nCurrently the nodes in the cache provided to the predicates excludes the unschedulable nodes using field level filtering for the watch results. This results in the above issue as the `ServiceAffinity` predicate uses the cached node list to look up the node metadata for a peer pod (another pod belonging to the same service). Since this peer pod could be currently hosted on a node that is currently unschedulable, the lookup could potentially fail, resulting in the pod failing to be scheduled.\r\n\r\nAs part of the fix, we are now including all nodes in the watch results and excluding the unschedulable nodes using `NodeCondition`\r\n\r\n@derekwaynecarr PTAL"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/223790167","html_url":"https://github.com/kubernetes/kubernetes/pull/22568#issuecomment-223790167","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/22568","id":223790167,"user":{"login":"davidopp","id":8264113,"avatar_url":"https://avatars.githubusercontent.com/u/8264113?v=3","gravatar_id":"","url":"https://api.github.com/users/davidopp","html_url":"https://github.com/davidopp","followers_url":"https://api.github.com/users/davidopp/followers","following_url":"https://api.github.com/users/davidopp/following{/other_user}","gists_url":"https://api.github.com/users/davidopp/gists{/gist_id}","starred_url":"https://api.github.com/users/davidopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidopp/subscriptions","organizations_url":"https://api.github.com/users/davidopp/orgs","repos_url":"https://api.github.com/users/davidopp/repos","events_url":"https://api.github.com/users/davidopp/events{/privacy}","received_events_url":"https://api.github.com/users/davidopp/received_events","type":"User","site_admin":false},"created_at":"2016-06-05T02:54:31Z","updated_at":"2016-06-05T02:54:31Z","body":"@spxtr @fejta do either of you know what is actually failing here? I thought it was #25539 but it has now failed a third time so I'm not sure.\r\n"}}
{"actor":{"display_login":"davidopp"}}