{"action":"created","issue":{"url":"https://api.github.com/repos/xamarin/xamarin-android/issues/175","repository_url":"https://api.github.com/repos/xamarin/xamarin-android","labels_url":"https://api.github.com/repos/xamarin/xamarin-android/issues/175/labels{/name}","comments_url":"https://api.github.com/repos/xamarin/xamarin-android/issues/175/comments","events_url":"https://api.github.com/repos/xamarin/xamarin-android/issues/175/events","html_url":"https://github.com/xamarin/xamarin-android/pull/175","id":172030867,"number":175,"title":"F# Android projects don't build when language is changed in XS fixes …","user":{"login":"nosami","id":667194,"avatar_url":"https://avatars.githubusercontent.com/u/667194?v=3","gravatar_id":"","url":"https://api.github.com/users/nosami","html_url":"https://github.com/nosami","followers_url":"https://api.github.com/users/nosami/followers","following_url":"https://api.github.com/users/nosami/following{/other_user}","gists_url":"https://api.github.com/users/nosami/gists{/gist_id}","starred_url":"https://api.github.com/users/nosami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nosami/subscriptions","organizations_url":"https://api.github.com/users/nosami/orgs","repos_url":"https://api.github.com/users/nosami/repos","events_url":"https://api.github.com/users/nosami/events{/privacy}","received_events_url":"https://api.github.com/users/nosami/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-08-19T00:29:57Z","updated_at":"2016-08-19T15:46:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xamarin/xamarin-android/pulls/175","html_url":"https://github.com/xamarin/xamarin-android/pull/175","diff_url":"https://github.com/xamarin/xamarin-android/pull/175.diff","patch_url":"https://github.com/xamarin/xamarin-android/pull/175.patch"},"body":"F# projects don't build when lang is changed in XS\r\n\r\nSetting the UI language in XS sets the msbuild variable `LANGUAGE = en`\r\n(or whatever language you choose).\r\n\r\nThe Android F# targets check for the existence of this variable to\r\ndetermine if Microsoft.FSharp.targets has been loaded.\r\n\r\nMicrosoft.FSharp.targets sets `<Language>F#</Language>` so it is better\r\nto check for the presence of F# being set rather than checking to see\r\nif it's not empty.\r\n\r\nFixes #43525 \r\n"},"comment":{"url":"https://api.github.com/repos/xamarin/xamarin-android/issues/comments/241055139","html_url":"https://github.com/xamarin/xamarin-android/pull/175#issuecomment-241055139","issue_url":"https://api.github.com/repos/xamarin/xamarin-android/issues/175","id":241055139,"user":{"login":"jonpryor","id":155958,"avatar_url":"https://avatars.githubusercontent.com/u/155958?v=3","gravatar_id":"","url":"https://api.github.com/users/jonpryor","html_url":"https://github.com/jonpryor","followers_url":"https://api.github.com/users/jonpryor/followers","following_url":"https://api.github.com/users/jonpryor/following{/other_user}","gists_url":"https://api.github.com/users/jonpryor/gists{/gist_id}","starred_url":"https://api.github.com/users/jonpryor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonpryor/subscriptions","organizations_url":"https://api.github.com/users/jonpryor/orgs","repos_url":"https://api.github.com/users/jonpryor/repos","events_url":"https://api.github.com/users/jonpryor/events{/privacy}","received_events_url":"https://api.github.com/users/jonpryor/received_events","type":"User","site_admin":false},"created_at":"2016-08-19T15:46:25Z","updated_at":"2016-08-19T15:46:25Z","body":"Here's another plausible fix. This is in `/Library/Frameworks/Mono.framework/Versions/4.4.2/lib/mono/4.5/Microsoft.FSharp.Targets`:\r\n\r\n    <Import Project=\"$(MSBuildExtensionsPath)\\$(MSBuildToolsVersion)\\$(MSBuildThisFile)\\ImportBefore\\*\" Condition=\"'$(ImportByWildcardBeforeMicrosoftFSharpTargets)' == 'true' and exists('$(MSBuildExtensionsPath)\\$(MSBuildToolsVersion)\\$(MSBuildThisFile)\\ImportBefore')\"/>\r\n\r\nMono.framework could add a file here which imports a new, unambiguous, MSBuild property, such as `$(ProgrammingLanguageName)`, and this new MSBuild property could be used by Xamarin.Android instead of using `$(Language)`.\r\n\r\nAlas, that would be Mono-specific."}}
{"actor":{"display_login":"jonpryor"}}