{"action":"created","issue":{"url":"https://api.github.com/repos/uProxy/uproxy/issues/2508","repository_url":"https://api.github.com/repos/uProxy/uproxy","labels_url":"https://api.github.com/repos/uProxy/uproxy/issues/2508/labels{/name}","comments_url":"https://api.github.com/repos/uProxy/uproxy/issues/2508/comments","events_url":"https://api.github.com/repos/uProxy/uproxy/issues/2508/events","html_url":"https://github.com/uProxy/uproxy/pull/2508","id":161969670,"number":2508,"title":"prep for making RC4 obfuscator the default","user":{"login":"trevj","id":5142116,"avatar_url":"https://avatars.githubusercontent.com/u/5142116?v=3","gravatar_id":"","url":"https://api.github.com/users/trevj","html_url":"https://github.com/trevj","followers_url":"https://api.github.com/users/trevj/followers","following_url":"https://api.github.com/users/trevj/following{/other_user}","gists_url":"https://api.github.com/users/trevj/gists{/gist_id}","starred_url":"https://api.github.com/users/trevj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevj/subscriptions","organizations_url":"https://api.github.com/users/trevj/orgs","repos_url":"https://api.github.com/users/trevj/repos","events_url":"https://api.github.com/users/trevj/events{/privacy}","received_events_url":"https://api.github.com/users/trevj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"bemasc","id":191945,"avatar_url":"https://avatars.githubusercontent.com/u/191945?v=3","gravatar_id":"","url":"https://api.github.com/users/bemasc","html_url":"https://github.com/bemasc","followers_url":"https://api.github.com/users/bemasc/followers","following_url":"https://api.github.com/users/bemasc/following{/other_user}","gists_url":"https://api.github.com/users/bemasc/gists{/gist_id}","starred_url":"https://api.github.com/users/bemasc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bemasc/subscriptions","organizations_url":"https://api.github.com/users/bemasc/orgs","repos_url":"https://api.github.com/users/bemasc/repos","events_url":"https://api.github.com/users/bemasc/events{/privacy}","received_events_url":"https://api.github.com/users/bemasc/received_events","type":"User","site_admin":false},"assignees":[{"login":"bemasc","id":191945,"avatar_url":"https://avatars.githubusercontent.com/u/191945?v=3","gravatar_id":"","url":"https://api.github.com/users/bemasc","html_url":"https://github.com/bemasc","followers_url":"https://api.github.com/users/bemasc/followers","following_url":"https://api.github.com/users/bemasc/following{/other_user}","gists_url":"https://api.github.com/users/bemasc/gists{/gist_id}","starred_url":"https://api.github.com/users/bemasc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bemasc/subscriptions","organizations_url":"https://api.github.com/users/bemasc/orgs","repos_url":"https://api.github.com/users/bemasc/repos","events_url":"https://api.github.com/users/bemasc/events{/privacy}","received_events_url":"https://api.github.com/users/bemasc/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2016-06-23T16:44:40Z","updated_at":"2016-07-15T18:27:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/uProxy/uproxy/pulls/2508","html_url":"https://github.com/uProxy/uproxy/pull/2508","diff_url":"https://github.com/uProxy/uproxy/pull/2508.diff","patch_url":"https://github.com/uProxy/uproxy/pull/2508.patch"},"body":"This makes the RC4 obfuscator the default. It's mostly a simple bump to our `MESSAGE_VERSION` mechanism which has helped us roll out new features forever. However, I also had to incorporate this mechanism into cloud servers: I added a new command, `version`, which returns the server's `MESSAGE_VERSION`. If it's 6 then the client will offer RC4; otherwise, plain Caesar.\r\n\r\nThat said, this isn't quite ready yet. I just benchmarked this and am seeing a measurable drop in performance:\r\n\r\n| obfuscator | Kb/sec |\r\n| --- | --- |\r\n| none | 1847 |\r\n| caesar | 1798 |\r\n| rc4 | 1482 |\r\n\r\nIn the real-world any kind of latency between client and server will make this irrelevant but since it really doesn't tally with what I saw in my [previous benchmark](https://github.com/uProxy/uproxy-lib/pull/397) which showed near-identical throughput, I want to investigate a bit.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/uproxy/uproxy/2508)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/uProxy/uproxy/issues/comments/233030619","html_url":"https://github.com/uProxy/uproxy/pull/2508#issuecomment-233030619","issue_url":"https://api.github.com/repos/uProxy/uproxy/issues/2508","id":233030619,"user":{"login":"jab","id":64992,"avatar_url":"https://avatars.githubusercontent.com/u/64992?v=3","gravatar_id":"","url":"https://api.github.com/users/jab","html_url":"https://github.com/jab","followers_url":"https://api.github.com/users/jab/followers","following_url":"https://api.github.com/users/jab/following{/other_user}","gists_url":"https://api.github.com/users/jab/gists{/gist_id}","starred_url":"https://api.github.com/users/jab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jab/subscriptions","organizations_url":"https://api.github.com/users/jab/orgs","repos_url":"https://api.github.com/users/jab/repos","events_url":"https://api.github.com/users/jab/events{/privacy}","received_events_url":"https://api.github.com/users/jab/received_events","type":"User","site_admin":false},"created_at":"2016-07-15T18:27:59Z","updated_at":"2016-07-15T18:27:59Z","body":"Just took a quick look, so sorry again I didn't get to it sooner. 😢 \r\nOnly familiar enough to give a superficial 👍  (modulo my superficial comments). Probably worth getting @bemasc's 👍  before merging."}}
{"actor":{"display_login":"jab"}}