{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/58705195","id":58705195,"diff_hunk":"@@ -73,17 +77,11 @@ void CEmuFileWrapper::CleanUp()\n         delete m_files[i].file_lock;\n         m_files[i].file_lock = nullptr;\n       }\n-#if !defined(TARGET_WINDOWS)\n       //Don't memset on Windows as it overwrites our pointer","path":"xbmc/cores/DllLoader/exports/util/EmuFileWrapper.cpp","position":16,"original_position":16,"commit_id":"8a5438702735154eda5b8a089f84fd0eb4d03674","original_commit_id":"8a5438702735154eda5b8a089f84fd0eb4d03674","user":{"login":"fritsch","id":1089309,"avatar_url":"https://avatars.githubusercontent.com/u/1089309?v=3","gravatar_id":"","url":"https://api.github.com/users/fritsch","html_url":"https://github.com/fritsch","followers_url":"https://api.github.com/users/fritsch/followers","following_url":"https://api.github.com/users/fritsch/following{/other_user}","gists_url":"https://api.github.com/users/fritsch/gists{/gist_id}","starred_url":"https://api.github.com/users/fritsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fritsch/subscriptions","organizations_url":"https://api.github.com/users/fritsch/orgs","repos_url":"https://api.github.com/users/fritsch/repos","events_url":"https://api.github.com/users/fritsch/events{/privacy}","received_events_url":"https://api.github.com/users/fritsch/received_events","type":"User","site_admin":false},"body":"See what it does? It was not memset before, cause of the PlaceHolder ptr  should not be overwritten. No the PlaceHolder is deleted prior the memsetting. That's the idea here.","created_at":"2016-04-06T13:36:32Z","updated_at":"2016-04-06T13:36:32Z","html_url":"https://github.com/xbmc/xbmc/pull/9565#discussion_r58705195","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/9565","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/58705195"},"html":{"href":"https://github.com/xbmc/xbmc/pull/9565#discussion_r58705195"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/9565"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/9565","id":65460196,"html_url":"https://github.com/xbmc/xbmc/pull/9565","diff_url":"https://github.com/xbmc/xbmc/pull/9565.diff","patch_url":"https://github.com/xbmc/xbmc/pull/9565.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/9565","number":9565,"state":"open","locked":false,"title":"EmuFileWrapper: Properly memset the file structure","user":{"login":"fritsch","id":1089309,"avatar_url":"https://avatars.githubusercontent.com/u/1089309?v=3","gravatar_id":"","url":"https://api.github.com/users/fritsch","html_url":"https://github.com/fritsch","followers_url":"https://api.github.com/users/fritsch/followers","following_url":"https://api.github.com/users/fritsch/following{/other_user}","gists_url":"https://api.github.com/users/fritsch/gists{/gist_id}","starred_url":"https://api.github.com/users/fritsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fritsch/subscriptions","organizations_url":"https://api.github.com/users/fritsch/orgs","repos_url":"https://api.github.com/users/fritsch/repos","events_url":"https://api.github.com/users/fritsch/events{/privacy}","received_events_url":"https://api.github.com/users/fritsch/received_events","type":"User","site_admin":false},"body":"Do not change behaviour. Make sure all fields are properly set to zero.","created_at":"2016-04-06T12:50:26Z","updated_at":"2016-04-06T13:36:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9237825172268bafa29fc0959c9a1c2b1544aa58","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/9565/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/9565/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/9565/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/8a5438702735154eda5b8a089f84fd0eb4d03674","head":{"label":"fritsch:memset","ref":"memset","sha":"8a5438702735154eda5b8a089f84fd0eb4d03674","user":{"login":"fritsch","id":1089309,"avatar_url":"https://avatars.githubusercontent.com/u/1089309?v=3","gravatar_id":"","url":"https://api.github.com/users/fritsch","html_url":"https://github.com/fritsch","followers_url":"https://api.github.com/users/fritsch/followers","following_url":"https://api.github.com/users/fritsch/following{/other_user}","gists_url":"https://api.github.com/users/fritsch/gists{/gist_id}","starred_url":"https://api.github.com/users/fritsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fritsch/subscriptions","organizations_url":"https://api.github.com/users/fritsch/orgs","repos_url":"https://api.github.com/users/fritsch/repos","events_url":"https://api.github.com/users/fritsch/events{/privacy}","received_events_url":"https://api.github.com/users/fritsch/received_events","type":"User","site_admin":false},"repo":{"id":2808359,"name":"xbmc","full_name":"fritsch/xbmc","owner":{"login":"fritsch","id":1089309,"avatar_url":"https://avatars.githubusercontent.com/u/1089309?v=3","gravatar_id":"","url":"https://api.github.com/users/fritsch","html_url":"https://github.com/fritsch","followers_url":"https://api.github.com/users/fritsch/followers","following_url":"https://api.github.com/users/fritsch/following{/other_user}","gists_url":"https://api.github.com/users/fritsch/gists{/gist_id}","starred_url":"https://api.github.com/users/fritsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fritsch/subscriptions","organizations_url":"https://api.github.com/users/fritsch/orgs","repos_url":"https://api.github.com/users/fritsch/repos","events_url":"https://api.github.com/users/fritsch/events{/privacy}","received_events_url":"https://api.github.com/users/fritsch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fritsch/xbmc","description":"Fork of  XBMC Main PVR Development Repository.","fork":true,"url":"https://api.github.com/repos/fritsch/xbmc","forks_url":"https://api.github.com/repos/fritsch/xbmc/forks","keys_url":"https://api.github.com/repos/fritsch/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fritsch/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fritsch/xbmc/teams","hooks_url":"https://api.github.com/repos/fritsch/xbmc/hooks","issue_events_url":"https://api.github.com/repos/fritsch/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/fritsch/xbmc/events","assignees_url":"https://api.github.com/repos/fritsch/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/fritsch/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/fritsch/xbmc/tags","blobs_url":"https://api.github.com/repos/fritsch/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fritsch/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fritsch/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/fritsch/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fritsch/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/fritsch/xbmc/languages","stargazers_url":"https://api.github.com/repos/fritsch/xbmc/stargazers","contributors_url":"https://api.github.com/repos/fritsch/xbmc/contributors","subscribers_url":"https://api.github.com/repos/fritsch/xbmc/subscribers","subscription_url":"https://api.github.com/repos/fritsch/xbmc/subscription","commits_url":"https://api.github.com/repos/fritsch/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/fritsch/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/fritsch/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/fritsch/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/fritsch/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/fritsch/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fritsch/xbmc/merges","archive_url":"https://api.github.com/repos/fritsch/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fritsch/xbmc/downloads","issues_url":"https://api.github.com/repos/fritsch/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/fritsch/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/fritsch/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/fritsch/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fritsch/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/fritsch/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/fritsch/xbmc/deployments","created_at":"2011-11-19T11:16:56Z","updated_at":"2016-01-14T22:05:57Z","pushed_at":"2016-04-06T12:49:51Z","git_url":"git://github.com/fritsch/xbmc.git","ssh_url":"git@github.com:fritsch/xbmc.git","clone_url":"https://github.com/fritsch/xbmc.git","svn_url":"https://github.com/fritsch/xbmc","homepage":"http://xbmc.org","size":558337,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"2e7dc772d4a78e8f94cf7b481ce7db23a6225587","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/xbmc/xbmc/deployments","created_at":"2011-01-03T21:18:51Z","updated_at":"2016-04-06T08:52:45Z","pushed_at":"2016-04-06T13:34:34Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1745439,"stargazers_count":4651,"watchers_count":4651,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3427,"mirror_url":null,"open_issues_count":226,"forks":3427,"open_issues":226,"watchers":4651,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/9565"},"html":{"href":"https://github.com/xbmc/xbmc/pull/9565"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/9565"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/9565/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/9565/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/9565/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/8a5438702735154eda5b8a089f84fd0eb4d03674"}}}}