{"action":"created","issue":{"url":"https://api.github.com/repos/nette/mail/issues/30","repository_url":"https://api.github.com/repos/nette/mail","labels_url":"https://api.github.com/repos/nette/mail/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/nette/mail/issues/30/comments","events_url":"https://api.github.com/repos/nette/mail/issues/30/events","html_url":"https://github.com/nette/mail/pull/30","id":159822958,"number":30,"title":"Allow set stream context","user":{"login":"ZZromanZZ","id":99749,"avatar_url":"https://avatars.githubusercontent.com/u/99749?v=3","gravatar_id":"","url":"https://api.github.com/users/ZZromanZZ","html_url":"https://github.com/ZZromanZZ","followers_url":"https://api.github.com/users/ZZromanZZ/followers","following_url":"https://api.github.com/users/ZZromanZZ/following{/other_user}","gists_url":"https://api.github.com/users/ZZromanZZ/gists{/gist_id}","starred_url":"https://api.github.com/users/ZZromanZZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZZromanZZ/subscriptions","organizations_url":"https://api.github.com/users/ZZromanZZ/orgs","repos_url":"https://api.github.com/users/ZZromanZZ/repos","events_url":"https://api.github.com/users/ZZromanZZ/events{/privacy}","received_events_url":"https://api.github.com/users/ZZromanZZ/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-06-12T11:34:36Z","updated_at":"2016-06-12T20:54:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nette/mail/pulls/30","html_url":"https://github.com/nette/mail/pull/30","diff_url":"https://github.com/nette/mail/pull/30.diff","patch_url":"https://github.com/nette/mail/pull/30.patch"},"body":"In current implementation, there is no way to modify stream context parameters.\r\n\r\nWhich means there is no way to connect (since [php 5.6](http://php.net/manual/en/migration56.openssl.php)) to SSL/TLS server with self-signed, expired, missmatched CN, etc..\r\n\r\nSee this problem on [forum](https://forum.nette.org/cs/25121-nette-mail-smtpmailer-na-port-587-certificate-verify-failed), for example.\r\n\r\nIf this is acceptable I would like to discuss possible approaches:\r\n- allow set full stream context \r\n- allow set only some values (verify_peer, verify_peer_name, etc...)\r\n\r\nAlso there is problem how to catch warnings from underlying Openssl library and provide it to SmtpException as error message.\r\n\r\nThere is MR, more like experiment, implementation is vague.\r\n\r\nWe can find inspiration for example in [Ruby](https://github.com/mikel/mail/blob/master/lib/mail/network/delivery_methods/smtp.rb)."},"comment":{"url":"https://api.github.com/repos/nette/mail/issues/comments/225459756","html_url":"https://github.com/nette/mail/pull/30#issuecomment-225459756","issue_url":"https://api.github.com/repos/nette/mail/issues/30","id":225459756,"user":{"login":"ZZromanZZ","id":99749,"avatar_url":"https://avatars.githubusercontent.com/u/99749?v=3","gravatar_id":"","url":"https://api.github.com/users/ZZromanZZ","html_url":"https://github.com/ZZromanZZ","followers_url":"https://api.github.com/users/ZZromanZZ/followers","following_url":"https://api.github.com/users/ZZromanZZ/following{/other_user}","gists_url":"https://api.github.com/users/ZZromanZZ/gists{/gist_id}","starred_url":"https://api.github.com/users/ZZromanZZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZZromanZZ/subscriptions","organizations_url":"https://api.github.com/users/ZZromanZZ/orgs","repos_url":"https://api.github.com/users/ZZromanZZ/repos","events_url":"https://api.github.com/users/ZZromanZZ/events{/privacy}","received_events_url":"https://api.github.com/users/ZZromanZZ/received_events","type":"User","site_admin":false},"created_at":"2016-06-12T20:54:44Z","updated_at":"2016-06-12T20:54:44Z","body":"I have still problem with `error_get_last()`, it doesn't catch all warnings properly.\r\nI'm starting to lean towards that let the implementation without `error_get_last()` and let SmtpException untouched."}}
{"actor":{"display_login":"ZZromanZZ"}}