{"action":"created","comment":{"url":"https://api.github.com/repos/apache/storm/pulls/comments/69431654","id":69431654,"diff_hunk":"@@ -76,24 +77,41 @@ public void prepare(Map stormConf) {\n         producer = new Producer(config);\n     }\n \n-    public void updateState(List<TridentTuple> tuples, TridentCollector collector) {\n-        String topic = null;\n-        for (TridentTuple tuple : tuples) {\n-            try {\n-                topic = topicSelector.getTopic(tuple);\n+    @SuppressWarnings(\"rawtypes\")","path":"external/storm-kafka/src/jvm/storm/kafka/trident/TridentKafkaState.java","position":null,"original_position":17,"commit_id":"7b9fac12dd0dc9c583e35f345417863818e45e61","original_commit_id":"518e402e96ea1202f55813f8b94467fbcf93c725","user":{"login":"supermonk","id":5060860,"avatar_url":"https://avatars.githubusercontent.com/u/5060860?v=3","gravatar_id":"","url":"https://api.github.com/users/supermonk","html_url":"https://github.com/supermonk","followers_url":"https://api.github.com/users/supermonk/followers","following_url":"https://api.github.com/users/supermonk/following{/other_user}","gists_url":"https://api.github.com/users/supermonk/gists{/gist_id}","starred_url":"https://api.github.com/users/supermonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supermonk/subscriptions","organizations_url":"https://api.github.com/users/supermonk/orgs","repos_url":"https://api.github.com/users/supermonk/repos","events_url":"https://api.github.com/users/supermonk/events{/privacy}","received_events_url":"https://api.github.com/users/supermonk/received_events","type":"User","site_admin":false},"body":"@abellina, Thanks for the comment. I have fixed it now. let me know if any queries.","created_at":"2016-07-04T09:30:37Z","updated_at":"2016-07-04T09:30:37Z","html_url":"https://github.com/apache/storm/pull/1538#discussion_r69431654","pull_request_url":"https://api.github.com/repos/apache/storm/pulls/1538","_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/comments/69431654"},"html":{"href":"https://github.com/apache/storm/pull/1538#discussion_r69431654"},"pull_request":{"href":"https://api.github.com/repos/apache/storm/pulls/1538"}}},"pull_request":{"url":"https://api.github.com/repos/apache/storm/pulls/1538","id":76055076,"html_url":"https://github.com/apache/storm/pull/1538","diff_url":"https://github.com/apache/storm/pull/1538.diff","patch_url":"https://github.com/apache/storm/pull/1538.patch","issue_url":"https://api.github.com/repos/apache/storm/issues/1538","number":1538,"state":"open","locked":false,"title":"Sending the Data to Kafka as a batch, instead of sending one tuple ea…","user":{"login":"supermonk","id":5060860,"avatar_url":"https://avatars.githubusercontent.com/u/5060860?v=3","gravatar_id":"","url":"https://api.github.com/users/supermonk","html_url":"https://github.com/supermonk","followers_url":"https://api.github.com/users/supermonk/followers","following_url":"https://api.github.com/users/supermonk/following{/other_user}","gists_url":"https://api.github.com/users/supermonk/gists{/gist_id}","starred_url":"https://api.github.com/users/supermonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supermonk/subscriptions","organizations_url":"https://api.github.com/users/supermonk/orgs","repos_url":"https://api.github.com/users/supermonk/repos","events_url":"https://api.github.com/users/supermonk/events{/privacy}","received_events_url":"https://api.github.com/users/supermonk/received_events","type":"User","site_admin":false},"body":"Sending the Data to Kafka as a batch, instead of sending one tuple each. 0.10 storm-kafka version uses Producer.scala (kafka-client) class which has two methods, we are using now the second method which sends in batch.\r\n\r\nRef : https://github.com/apache/kafka/blob/623ab1e7c6497c000bc9c9978637f20542a3191c/core/src/main/scala/kafka/javaapi/producer/Producer.scala","created_at":"2016-07-02T03:47:06Z","updated_at":"2016-07-04T09:30:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ef23fe260ba968319e82daa5ca6378019688f13","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/storm/pulls/1538/commits","review_comments_url":"https://api.github.com/repos/apache/storm/pulls/1538/comments","review_comment_url":"https://api.github.com/repos/apache/storm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/storm/issues/1538/comments","statuses_url":"https://api.github.com/repos/apache/storm/statuses/7b9fac12dd0dc9c583e35f345417863818e45e61","head":{"label":"Symantec:0.10.x-branch","ref":"0.10.x-branch","sha":"7b9fac12dd0dc9c583e35f345417863818e45e61","user":{"login":"Symantec","id":7462319,"avatar_url":"https://avatars.githubusercontent.com/u/7462319?v=3","gravatar_id":"","url":"https://api.github.com/users/Symantec","html_url":"https://github.com/Symantec","followers_url":"https://api.github.com/users/Symantec/followers","following_url":"https://api.github.com/users/Symantec/following{/other_user}","gists_url":"https://api.github.com/users/Symantec/gists{/gist_id}","starred_url":"https://api.github.com/users/Symantec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Symantec/subscriptions","organizations_url":"https://api.github.com/users/Symantec/orgs","repos_url":"https://api.github.com/users/Symantec/repos","events_url":"https://api.github.com/users/Symantec/events{/privacy}","received_events_url":"https://api.github.com/users/Symantec/received_events","type":"Organization","site_admin":false},"repo":{"id":55430453,"name":"storm","full_name":"Symantec/storm","owner":{"login":"Symantec","id":7462319,"avatar_url":"https://avatars.githubusercontent.com/u/7462319?v=3","gravatar_id":"","url":"https://api.github.com/users/Symantec","html_url":"https://github.com/Symantec","followers_url":"https://api.github.com/users/Symantec/followers","following_url":"https://api.github.com/users/Symantec/following{/other_user}","gists_url":"https://api.github.com/users/Symantec/gists{/gist_id}","starred_url":"https://api.github.com/users/Symantec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Symantec/subscriptions","organizations_url":"https://api.github.com/users/Symantec/orgs","repos_url":"https://api.github.com/users/Symantec/repos","events_url":"https://api.github.com/users/Symantec/events{/privacy}","received_events_url":"https://api.github.com/users/Symantec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Symantec/storm","description":"Mirror of Apache Storm","fork":true,"url":"https://api.github.com/repos/Symantec/storm","forks_url":"https://api.github.com/repos/Symantec/storm/forks","keys_url":"https://api.github.com/repos/Symantec/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Symantec/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Symantec/storm/teams","hooks_url":"https://api.github.com/repos/Symantec/storm/hooks","issue_events_url":"https://api.github.com/repos/Symantec/storm/issues/events{/number}","events_url":"https://api.github.com/repos/Symantec/storm/events","assignees_url":"https://api.github.com/repos/Symantec/storm/assignees{/user}","branches_url":"https://api.github.com/repos/Symantec/storm/branches{/branch}","tags_url":"https://api.github.com/repos/Symantec/storm/tags","blobs_url":"https://api.github.com/repos/Symantec/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Symantec/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Symantec/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/Symantec/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Symantec/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/Symantec/storm/languages","stargazers_url":"https://api.github.com/repos/Symantec/storm/stargazers","contributors_url":"https://api.github.com/repos/Symantec/storm/contributors","subscribers_url":"https://api.github.com/repos/Symantec/storm/subscribers","subscription_url":"https://api.github.com/repos/Symantec/storm/subscription","commits_url":"https://api.github.com/repos/Symantec/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/Symantec/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/Symantec/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/Symantec/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/Symantec/storm/contents/{+path}","compare_url":"https://api.github.com/repos/Symantec/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Symantec/storm/merges","archive_url":"https://api.github.com/repos/Symantec/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Symantec/storm/downloads","issues_url":"https://api.github.com/repos/Symantec/storm/issues{/number}","pulls_url":"https://api.github.com/repos/Symantec/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/Symantec/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/Symantec/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Symantec/storm/labels{/name}","releases_url":"https://api.github.com/repos/Symantec/storm/releases{/id}","deployments_url":"https://api.github.com/repos/Symantec/storm/deployments","created_at":"2016-04-04T17:21:11Z","updated_at":"2016-04-04T17:21:16Z","pushed_at":"2016-07-04T09:29:33Z","git_url":"git://github.com/Symantec/storm.git","ssh_url":"git@github.com:Symantec/storm.git","clone_url":"https://github.com/Symantec/storm.git","svn_url":"https://github.com/Symantec/storm","homepage":null,"size":156054,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:0.10.x-branch","ref":"0.10.x-branch","sha":"cbe558cda8f7e5f7c189ffe09898a809541dc93c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":14135470,"name":"storm","full_name":"apache/storm","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/storm","description":"Mirror of Apache Storm","fork":false,"url":"https://api.github.com/repos/apache/storm","forks_url":"https://api.github.com/repos/apache/storm/forks","keys_url":"https://api.github.com/repos/apache/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/storm/teams","hooks_url":"https://api.github.com/repos/apache/storm/hooks","issue_events_url":"https://api.github.com/repos/apache/storm/issues/events{/number}","events_url":"https://api.github.com/repos/apache/storm/events","assignees_url":"https://api.github.com/repos/apache/storm/assignees{/user}","branches_url":"https://api.github.com/repos/apache/storm/branches{/branch}","tags_url":"https://api.github.com/repos/apache/storm/tags","blobs_url":"https://api.github.com/repos/apache/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/storm/languages","stargazers_url":"https://api.github.com/repos/apache/storm/stargazers","contributors_url":"https://api.github.com/repos/apache/storm/contributors","subscribers_url":"https://api.github.com/repos/apache/storm/subscribers","subscription_url":"https://api.github.com/repos/apache/storm/subscription","commits_url":"https://api.github.com/repos/apache/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/storm/contents/{+path}","compare_url":"https://api.github.com/repos/apache/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/storm/merges","archive_url":"https://api.github.com/repos/apache/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/storm/downloads","issues_url":"https://api.github.com/repos/apache/storm/issues{/number}","pulls_url":"https://api.github.com/repos/apache/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/storm/labels{/name}","releases_url":"https://api.github.com/repos/apache/storm/releases{/id}","deployments_url":"https://api.github.com/repos/apache/storm/deployments","created_at":"2013-11-05T08:00:14Z","updated_at":"2016-07-04T05:13:42Z","pushed_at":"2016-07-04T09:29:37Z","git_url":"git://github.com/apache/storm.git","ssh_url":"git@github.com:apache/storm.git","clone_url":"https://github.com/apache/storm.git","svn_url":"https://github.com/apache/storm","homepage":null,"size":171135,"stargazers_count":3295,"watchers_count":3295,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2462,"mirror_url":"git://git.apache.org/storm.git","open_issues_count":139,"forks":2462,"open_issues":139,"watchers":3295,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/1538"},"html":{"href":"https://github.com/apache/storm/pull/1538"},"issue":{"href":"https://api.github.com/repos/apache/storm/issues/1538"},"comments":{"href":"https://api.github.com/repos/apache/storm/issues/1538/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/storm/pulls/1538/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/storm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/storm/pulls/1538/commits"},"statuses":{"href":"https://api.github.com/repos/apache/storm/statuses/7b9fac12dd0dc9c583e35f345417863818e45e61"}}}}
{"actor":{"display_login":"supermonk"}}