{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/pulls/comments/61506256","id":61506256,"diff_hunk":"@@ -187,10 +187,11 @@ interface CodePushCordovaPlugin {\n      * Calling this function is required on the first run after an update. On every subsequent application run, calling this function is a noop.\n      * If using sync API, calling this function is not required since sync calls it internally.\n      *\n+     * @param deploymentKey Optional string deployment key for this package.\n      * @param notifySucceeded Optional callback invoked if the plugin was successfully notified.\n      * @param notifyFailed Optional callback invoked in case of an error during notifying the plugin.\n      */\n-    notifyApplicationReady(notifySucceeded?: SuccessCallback<void>, notifyFailed?: ErrorCallback): void;\n+    notifyApplicationReady(deploymentKey?: string, notifySucceeded?: SuccessCallback<void>, notifyFailed?: ErrorCallback): void;","path":"typings/codePush.d.ts","position":9,"original_position":9,"commit_id":"b5721f593ad65a402dd084e81dfa881f6ce74efa","original_commit_id":"b5721f593ad65a402dd084e81dfa881f6ce74efa","user":{"login":"dlebu","id":12283206,"avatar_url":"https://avatars.githubusercontent.com/u/12283206?v=3","gravatar_id":"","url":"https://api.github.com/users/dlebu","html_url":"https://github.com/dlebu","followers_url":"https://api.github.com/users/dlebu/followers","following_url":"https://api.github.com/users/dlebu/following{/other_user}","gists_url":"https://api.github.com/users/dlebu/gists{/gist_id}","starred_url":"https://api.github.com/users/dlebu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlebu/subscriptions","organizations_url":"https://api.github.com/users/dlebu/orgs","repos_url":"https://api.github.com/users/dlebu/repos","events_url":"https://api.github.com/users/dlebu/events{/privacy}","received_events_url":"https://api.github.com/users/dlebu/received_events","type":"User","site_admin":false},"body":"This is an API breaking change. Is this really necessary? Can't we be smarter in the native code and remember the custom deployment key?","created_at":"2016-04-28T21:33:03Z","updated_at":"2016-04-28T21:33:03Z","html_url":"https://github.com/Microsoft/cordova-plugin-code-push/pull/109#discussion_r61506256","pull_request_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/pulls/109","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/pulls/comments/61506256"},"html":{"href":"https://github.com/Microsoft/cordova-plugin-code-push/pull/109#discussion_r61506256"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/pulls/109"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/pulls/109","id":68293082,"html_url":"https://github.com/Microsoft/cordova-plugin-code-push/pull/109","diff_url":"https://github.com/Microsoft/cordova-plugin-code-push/pull/109.diff","patch_url":"https://github.com/Microsoft/cordova-plugin-code-push/pull/109.patch","issue_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/issues/109","number":109,"state":"open","locked":false,"title":"Fix nil deploymentkey crash","user":{"login":"ryuyu","id":11051729,"avatar_url":"https://avatars.githubusercontent.com/u/11051729?v=3","gravatar_id":"","url":"https://api.github.com/users/ryuyu","html_url":"https://github.com/ryuyu","followers_url":"https://api.github.com/users/ryuyu/followers","following_url":"https://api.github.com/users/ryuyu/following{/other_user}","gists_url":"https://api.github.com/users/ryuyu/gists{/gist_id}","starred_url":"https://api.github.com/users/ryuyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryuyu/subscriptions","organizations_url":"https://api.github.com/users/ryuyu/orgs","repos_url":"https://api.github.com/users/ryuyu/repos","events_url":"https://api.github.com/users/ryuyu/events{/privacy}","received_events_url":"https://api.github.com/users/ryuyu/received_events","type":"User","site_admin":false},"body":"Fixes a crash that was caused by attempting to report status when the deployment key wasn't specified in config.xml.\r\n\r\nAddresses https://github.com/Microsoft/cordova-plugin-code-push/issues/108\r\n\r\n@lostintangent @geof90 ","created_at":"2016-04-28T21:24:10Z","updated_at":"2016-04-28T21:33:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee5620b7c85fb4ddcbecdf9a83003ba8088c6c22","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/pulls/109/commits","review_comments_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/pulls/109/comments","review_comment_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/issues/109/comments","statuses_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/statuses/b5721f593ad65a402dd084e81dfa881f6ce74efa","head":{"label":"Microsoft:fix-nil-deploymentkey-crash","ref":"fix-nil-deploymentkey-crash","sha":"b5721f593ad65a402dd084e81dfa881f6ce74efa","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":41043374,"name":"cordova-plugin-code-push","full_name":"Microsoft/cordova-plugin-code-push","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/cordova-plugin-code-push","description":"Cordova plugin for CodePush","fork":false,"url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push","forks_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/forks","keys_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/teams","hooks_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/events","assignees_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/tags","blobs_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/languages","stargazers_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/subscription","commits_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/merges","archive_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/downloads","issues_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/deployments","created_at":"2015-08-19T15:40:12Z","updated_at":"2016-04-28T06:59:24Z","pushed_at":"2016-04-28T21:24:10Z","git_url":"git://github.com/Microsoft/cordova-plugin-code-push.git","ssh_url":"git@github.com:Microsoft/cordova-plugin-code-push.git","clone_url":"https://github.com/Microsoft/cordova-plugin-code-push.git","svn_url":"https://github.com/Microsoft/cordova-plugin-code-push","homepage":"http://codepush.tools","size":843,"stargazers_count":116,"watchers_count":116,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":8,"forks":15,"open_issues":8,"watchers":116,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"cb00b9f82296e5de74ad49ad177ebfa0437bd1b7","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":41043374,"name":"cordova-plugin-code-push","full_name":"Microsoft/cordova-plugin-code-push","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/cordova-plugin-code-push","description":"Cordova plugin for CodePush","fork":false,"url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push","forks_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/forks","keys_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/teams","hooks_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/events","assignees_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/tags","blobs_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/languages","stargazers_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/subscription","commits_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/merges","archive_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/downloads","issues_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/deployments","created_at":"2015-08-19T15:40:12Z","updated_at":"2016-04-28T06:59:24Z","pushed_at":"2016-04-28T21:24:10Z","git_url":"git://github.com/Microsoft/cordova-plugin-code-push.git","ssh_url":"git@github.com:Microsoft/cordova-plugin-code-push.git","clone_url":"https://github.com/Microsoft/cordova-plugin-code-push.git","svn_url":"https://github.com/Microsoft/cordova-plugin-code-push","homepage":"http://codepush.tools","size":843,"stargazers_count":116,"watchers_count":116,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":8,"forks":15,"open_issues":8,"watchers":116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/pulls/109"},"html":{"href":"https://github.com/Microsoft/cordova-plugin-code-push/pull/109"},"issue":{"href":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/issues/109"},"comments":{"href":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/cordova-plugin-code-push/statuses/b5721f593ad65a402dd084e81dfa881f6ce74efa"}}}}