{"action":"created","issue":{"url":"https://api.github.com/repos/certtools/intelmq/issues/796","repository_url":"https://api.github.com/repos/certtools/intelmq","labels_url":"https://api.github.com/repos/certtools/intelmq/issues/796/labels{/name}","comments_url":"https://api.github.com/repos/certtools/intelmq/issues/796/comments","events_url":"https://api.github.com/repos/certtools/intelmq/issues/796/events","html_url":"https://github.com/certtools/intelmq/pull/796","id":191952083,"number":796,"title":"Do not log password parameters","user":{"login":"ondj","id":19149300,"avatar_url":"https://avatars.githubusercontent.com/u/19149300?v=3","gravatar_id":"","url":"https://api.github.com/users/ondj","html_url":"https://github.com/ondj","followers_url":"https://api.github.com/users/ondj/followers","following_url":"https://api.github.com/users/ondj/following{/other_user}","gists_url":"https://api.github.com/users/ondj/gists{/gist_id}","starred_url":"https://api.github.com/users/ondj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ondj/subscriptions","organizations_url":"https://api.github.com/users/ondj/orgs","repos_url":"https://api.github.com/users/ondj/repos","events_url":"https://api.github.com/users/ondj/events{/privacy}","received_events_url":"https://api.github.com/users/ondj/received_events","type":"User","site_admin":false},"labels":[{"id":406908797,"url":"https://api.github.com/repos/certtools/intelmq/labels/component:%20core","name":"component: core","color":"d4c5f9","default":false},{"id":278525244,"url":"https://api.github.com/repos/certtools/intelmq/labels/needs:%20discussion","name":"needs: discussion","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":{"login":"sebix","id":199050,"avatar_url":"https://avatars.githubusercontent.com/u/199050?v=3","gravatar_id":"","url":"https://api.github.com/users/sebix","html_url":"https://github.com/sebix","followers_url":"https://api.github.com/users/sebix/followers","following_url":"https://api.github.com/users/sebix/following{/other_user}","gists_url":"https://api.github.com/users/sebix/gists{/gist_id}","starred_url":"https://api.github.com/users/sebix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebix/subscriptions","organizations_url":"https://api.github.com/users/sebix/orgs","repos_url":"https://api.github.com/users/sebix/repos","events_url":"https://api.github.com/users/sebix/events{/privacy}","received_events_url":"https://api.github.com/users/sebix/received_events","type":"User","site_admin":false},"assignees":[{"login":"sebix","id":199050,"avatar_url":"https://avatars.githubusercontent.com/u/199050?v=3","gravatar_id":"","url":"https://api.github.com/users/sebix","html_url":"https://github.com/sebix","followers_url":"https://api.github.com/users/sebix/followers","following_url":"https://api.github.com/users/sebix/following{/other_user}","gists_url":"https://api.github.com/users/sebix/gists{/gist_id}","starred_url":"https://api.github.com/users/sebix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebix/subscriptions","organizations_url":"https://api.github.com/users/sebix/orgs","repos_url":"https://api.github.com/users/sebix/repos","events_url":"https://api.github.com/users/sebix/events{/privacy}","received_events_url":"https://api.github.com/users/sebix/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-11-28T09:08:41Z","updated_at":"2016-11-29T16:46:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/certtools/intelmq/pulls/796","html_url":"https://github.com/certtools/intelmq/pull/796","diff_url":"https://github.com/certtools/intelmq/pull/796.diff","patch_url":"https://github.com/certtools/intelmq/pull/796.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/certtools/intelmq/issues/comments/263626168","html_url":"https://github.com/certtools/intelmq/pull/796#issuecomment-263626168","issue_url":"https://api.github.com/repos/certtools/intelmq/issues/796","id":263626168,"user":{"login":"dmth","id":4152441,"avatar_url":"https://avatars.githubusercontent.com/u/4152441?v=3","gravatar_id":"","url":"https://api.github.com/users/dmth","html_url":"https://github.com/dmth","followers_url":"https://api.github.com/users/dmth/followers","following_url":"https://api.github.com/users/dmth/following{/other_user}","gists_url":"https://api.github.com/users/dmth/gists{/gist_id}","starred_url":"https://api.github.com/users/dmth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmth/subscriptions","organizations_url":"https://api.github.com/users/dmth/orgs","repos_url":"https://api.github.com/users/dmth/repos","events_url":"https://api.github.com/users/dmth/events{/privacy}","received_events_url":"https://api.github.com/users/dmth/received_events","type":"User","site_admin":false},"created_at":"2016-11-29T16:46:30Z","updated_at":"2016-11-29T16:46:30Z","body":"Without looking at the code, replacing the `password` value in the logs with an obfuscated thing is ok, IMHO. Exchange of debugging-logs is a little bit safer now, as you lower the risks of sharing passwords without intent."}}
{"actor":{"display_login":"dmth"}}