{"action":"closed","issue":{"url":"https://api.github.com/repos/facebook/buck/issues/655","repository_url":"https://api.github.com/repos/facebook/buck","labels_url":"https://api.github.com/repos/facebook/buck/issues/655/labels{/name}","comments_url":"https://api.github.com/repos/facebook/buck/issues/655/comments","events_url":"https://api.github.com/repos/facebook/buck/issues/655/events","html_url":"https://github.com/facebook/buck/issues/655","id":133513900,"number":655,"title":"Android build should fail with incorrect keystore alias","user":{"login":"DanielGrech","id":655292,"avatar_url":"https://avatars.githubusercontent.com/u/655292?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielGrech","html_url":"https://github.com/DanielGrech","followers_url":"https://api.github.com/users/DanielGrech/followers","following_url":"https://api.github.com/users/DanielGrech/following{/other_user}","gists_url":"https://api.github.com/users/DanielGrech/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielGrech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielGrech/subscriptions","organizations_url":"https://api.github.com/users/DanielGrech/orgs","repos_url":"https://api.github.com/users/DanielGrech/repos","events_url":"https://api.github.com/users/DanielGrech/events{/privacy}","received_events_url":"https://api.github.com/users/DanielGrech/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-02-14T06:53:30Z","updated_at":"2016-03-08T23:43:03Z","closed_at":"2016-03-08T23:43:03Z","body":"Trying to build a project with a keystore as such:\r\n\r\nPertinent BUCK file contents:\r\n\r\n```\r\n/** \r\n    release.keystore.properties contents:\r\n\r\n    key.alias=some_incorrect_alias\r\n    key.store.password=password1\r\n    key.alias.password=password1\r\n*/\r\n\r\nkeystore(\r\n    name = 'release',\r\n    store = 'release.keystore',\r\n    properties = 'release.keystore.properties',\r\n    visibility = ['PUBLIC']\r\n)\r\n\r\nandroid_binary(\r\n    name = 'myapp_release',\r\n    manifest = ':release-manifest',\r\n    keystore = '//keystore:release',\r\n    package_type = 'release',\r\n    deps = [\r\n      ':main-lib'\r\n    ]\r\n)\r\n```\r\n\r\nThe file `release.keystore.properties` has an incorrect alias listed. I expect that the `buck build myapp_release` command should fail if the alias is incorrect. Instead, it fails silently and the resulting APK is not signed.\r\n\r\nValidated with the command:\r\n\r\n```\r\njarsigner -verify -verbose -certs buck-out/gen/myapp_release.apk\r\n\r\n  s = signature was verified \r\n  m = entry is listed in manifest\r\n  k = at least one certificate was found in keystore\r\n  i = at least one certificate was found in identity scope\r\n\r\nno manifest.\r\njar is unsigned. (signatures missing or not parsable)\r\n```"}}