{"action":"created","comment":{"url":"https://api.github.com/repos/steinwurf/petro/pulls/comments/80860660","pull_request_review_id":1883250,"id":80860660,"diff_hunk":"@@ -0,0 +1,143 @@\n+// Copyright (c) Steinwurf ApS 2016.\n+// All Rights Reserved\n+//\n+// Distributed under the \"BSD License\". See the accompanying LICENSE.rst file.\n+\n+#include \"avc_sample_extractor.hpp\"\n+\n+#include \"timestamp_extractor_layer.hpp\"\n+#include \"sample_extractor_layer.hpp\"\n+#include \"avc_track_layer.hpp\"\n+#include \"parser_layer.hpp\"\n+#include \"memory_mapped_file_layer.hpp\"\n+\n+namespace petro\n+{\n+namespace extractor\n+{\n+    /// stack for extracting avc samples\n+    struct avc_sample_extractor::impl :\n+        timestamp_extractor_layer<\n+        sample_extractor_layer<\n+        avc_track_layer<\n+        parser_layer<\n+        memory_mapped_file_layer>>>>\n+    { };\n+\n+    avc_sample_extractor::avc_sample_extractor() :\n+        m_impl(new avc_sample_extractor::impl())\n+    { }\n+\n+    avc_sample_extractor::~avc_sample_extractor()\n+    { }","path":"src/petro/extractor/avc_sample_extractor.cpp","position":32,"original_position":32,"commit_id":"4450c3f58c77e3ec3940b9d2ed2a063276c303a6","original_commit_id":"4450c3f58c77e3ec3940b9d2ed2a063276c303a6","user":{"login":"jpihl","id":583663,"avatar_url":"https://avatars.githubusercontent.com/u/583663?v=3","gravatar_id":"","url":"https://api.github.com/users/jpihl","html_url":"https://github.com/jpihl","followers_url":"https://api.github.com/users/jpihl/followers","following_url":"https://api.github.com/users/jpihl/following{/other_user}","gists_url":"https://api.github.com/users/jpihl/gists{/gist_id}","starred_url":"https://api.github.com/users/jpihl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpihl/subscriptions","organizations_url":"https://api.github.com/users/jpihl/orgs","repos_url":"https://api.github.com/users/jpihl/repos","events_url":"https://api.github.com/users/jpihl/events{/privacy}","received_events_url":"https://api.github.com/users/jpihl/received_events","type":"User","site_admin":false},"body":"is it necessary to have this empty destructor?","created_at":"2016-09-28T07:56:42Z","updated_at":"2016-09-28T08:00:32Z","html_url":"https://github.com/steinwurf/petro/pull/21#discussion_r80860660","pull_request_url":"https://api.github.com/repos/steinwurf/petro/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/steinwurf/petro/pulls/comments/80860660"},"html":{"href":"https://github.com/steinwurf/petro/pull/21#discussion_r80860660"},"pull_request":{"href":"https://api.github.com/repos/steinwurf/petro/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/steinwurf/petro/pulls/21","id":87013377,"html_url":"https://github.com/steinwurf/petro/pull/21","diff_url":"https://github.com/steinwurf/petro/pull/21.diff","patch_url":"https://github.com/steinwurf/petro/pull/21.patch","issue_url":"https://api.github.com/repos/steinwurf/petro/issues/21","number":21,"state":"open","locked":false,"title":"Use pimpl avc extractor","user":{"login":"mortenvp","id":1279584,"avatar_url":"https://avatars.githubusercontent.com/u/1279584?v=3","gravatar_id":"","url":"https://api.github.com/users/mortenvp","html_url":"https://github.com/mortenvp","followers_url":"https://api.github.com/users/mortenvp/followers","following_url":"https://api.github.com/users/mortenvp/following{/other_user}","gists_url":"https://api.github.com/users/mortenvp/gists{/gist_id}","starred_url":"https://api.github.com/users/mortenvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mortenvp/subscriptions","organizations_url":"https://api.github.com/users/mortenvp/orgs","repos_url":"https://api.github.com/users/mortenvp/repos","events_url":"https://api.github.com/users/mortenvp/events{/privacy}","received_events_url":"https://api.github.com/users/mortenvp/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-27T21:13:25Z","updated_at":"2016-09-28T08:00:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd97ffa3f1671f1c810c0921dfa6e064fde625fc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/steinwurf/petro/pulls/21/commits","review_comments_url":"https://api.github.com/repos/steinwurf/petro/pulls/21/comments","review_comment_url":"https://api.github.com/repos/steinwurf/petro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/steinwurf/petro/issues/21/comments","statuses_url":"https://api.github.com/repos/steinwurf/petro/statuses/4450c3f58c77e3ec3940b9d2ed2a063276c303a6","head":{"label":"steinwurf:use-pimpl-avc-extractor","ref":"use-pimpl-avc-extractor","sha":"4450c3f58c77e3ec3940b9d2ed2a063276c303a6","user":{"login":"steinwurf","id":1279612,"avatar_url":"https://avatars.githubusercontent.com/u/1279612?v=3","gravatar_id":"","url":"https://api.github.com/users/steinwurf","html_url":"https://github.com/steinwurf","followers_url":"https://api.github.com/users/steinwurf/followers","following_url":"https://api.github.com/users/steinwurf/following{/other_user}","gists_url":"https://api.github.com/users/steinwurf/gists{/gist_id}","starred_url":"https://api.github.com/users/steinwurf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steinwurf/subscriptions","organizations_url":"https://api.github.com/users/steinwurf/orgs","repos_url":"https://api.github.com/users/steinwurf/repos","events_url":"https://api.github.com/users/steinwurf/events{/privacy}","received_events_url":"https://api.github.com/users/steinwurf/received_events","type":"Organization","site_admin":false},"repo":{"id":46416459,"name":"petro","full_name":"steinwurf/petro","owner":{"login":"steinwurf","id":1279612,"avatar_url":"https://avatars.githubusercontent.com/u/1279612?v=3","gravatar_id":"","url":"https://api.github.com/users/steinwurf","html_url":"https://github.com/steinwurf","followers_url":"https://api.github.com/users/steinwurf/followers","following_url":"https://api.github.com/users/steinwurf/following{/other_user}","gists_url":"https://api.github.com/users/steinwurf/gists{/gist_id}","starred_url":"https://api.github.com/users/steinwurf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steinwurf/subscriptions","organizations_url":"https://api.github.com/users/steinwurf/orgs","repos_url":"https://api.github.com/users/steinwurf/repos","events_url":"https://api.github.com/users/steinwurf/events{/privacy}","received_events_url":"https://api.github.com/users/steinwurf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/steinwurf/petro","description":"mp4 parser","fork":false,"url":"https://api.github.com/repos/steinwurf/petro","forks_url":"https://api.github.com/repos/steinwurf/petro/forks","keys_url":"https://api.github.com/repos/steinwurf/petro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steinwurf/petro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steinwurf/petro/teams","hooks_url":"https://api.github.com/repos/steinwurf/petro/hooks","issue_events_url":"https://api.github.com/repos/steinwurf/petro/issues/events{/number}","events_url":"https://api.github.com/repos/steinwurf/petro/events","assignees_url":"https://api.github.com/repos/steinwurf/petro/assignees{/user}","branches_url":"https://api.github.com/repos/steinwurf/petro/branches{/branch}","tags_url":"https://api.github.com/repos/steinwurf/petro/tags","blobs_url":"https://api.github.com/repos/steinwurf/petro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steinwurf/petro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steinwurf/petro/git/refs{/sha}","trees_url":"https://api.github.com/repos/steinwurf/petro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steinwurf/petro/statuses/{sha}","languages_url":"https://api.github.com/repos/steinwurf/petro/languages","stargazers_url":"https://api.github.com/repos/steinwurf/petro/stargazers","contributors_url":"https://api.github.com/repos/steinwurf/petro/contributors","subscribers_url":"https://api.github.com/repos/steinwurf/petro/subscribers","subscription_url":"https://api.github.com/repos/steinwurf/petro/subscription","commits_url":"https://api.github.com/repos/steinwurf/petro/commits{/sha}","git_commits_url":"https://api.github.com/repos/steinwurf/petro/git/commits{/sha}","comments_url":"https://api.github.com/repos/steinwurf/petro/comments{/number}","issue_comment_url":"https://api.github.com/repos/steinwurf/petro/issues/comments{/number}","contents_url":"https://api.github.com/repos/steinwurf/petro/contents/{+path}","compare_url":"https://api.github.com/repos/steinwurf/petro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steinwurf/petro/merges","archive_url":"https://api.github.com/repos/steinwurf/petro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steinwurf/petro/downloads","issues_url":"https://api.github.com/repos/steinwurf/petro/issues{/number}","pulls_url":"https://api.github.com/repos/steinwurf/petro/pulls{/number}","milestones_url":"https://api.github.com/repos/steinwurf/petro/milestones{/number}","notifications_url":"https://api.github.com/repos/steinwurf/petro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steinwurf/petro/labels{/name}","releases_url":"https://api.github.com/repos/steinwurf/petro/releases{/id}","deployments_url":"https://api.github.com/repos/steinwurf/petro/deployments","created_at":"2015-11-18T12:12:04Z","updated_at":"2016-07-18T18:10:45Z","pushed_at":"2016-09-27T21:13:26Z","git_url":"git://github.com/steinwurf/petro.git","ssh_url":"git@github.com:steinwurf/petro.git","clone_url":"https://github.com/steinwurf/petro.git","svn_url":"https://github.com/steinwurf/petro","homepage":null,"size":18773,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"steinwurf:master","ref":"master","sha":"aee5fa7c3c3d30292fd540846991f16ff59faea0","user":{"login":"steinwurf","id":1279612,"avatar_url":"https://avatars.githubusercontent.com/u/1279612?v=3","gravatar_id":"","url":"https://api.github.com/users/steinwurf","html_url":"https://github.com/steinwurf","followers_url":"https://api.github.com/users/steinwurf/followers","following_url":"https://api.github.com/users/steinwurf/following{/other_user}","gists_url":"https://api.github.com/users/steinwurf/gists{/gist_id}","starred_url":"https://api.github.com/users/steinwurf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steinwurf/subscriptions","organizations_url":"https://api.github.com/users/steinwurf/orgs","repos_url":"https://api.github.com/users/steinwurf/repos","events_url":"https://api.github.com/users/steinwurf/events{/privacy}","received_events_url":"https://api.github.com/users/steinwurf/received_events","type":"Organization","site_admin":false},"repo":{"id":46416459,"name":"petro","full_name":"steinwurf/petro","owner":{"login":"steinwurf","id":1279612,"avatar_url":"https://avatars.githubusercontent.com/u/1279612?v=3","gravatar_id":"","url":"https://api.github.com/users/steinwurf","html_url":"https://github.com/steinwurf","followers_url":"https://api.github.com/users/steinwurf/followers","following_url":"https://api.github.com/users/steinwurf/following{/other_user}","gists_url":"https://api.github.com/users/steinwurf/gists{/gist_id}","starred_url":"https://api.github.com/users/steinwurf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steinwurf/subscriptions","organizations_url":"https://api.github.com/users/steinwurf/orgs","repos_url":"https://api.github.com/users/steinwurf/repos","events_url":"https://api.github.com/users/steinwurf/events{/privacy}","received_events_url":"https://api.github.com/users/steinwurf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/steinwurf/petro","description":"mp4 parser","fork":false,"url":"https://api.github.com/repos/steinwurf/petro","forks_url":"https://api.github.com/repos/steinwurf/petro/forks","keys_url":"https://api.github.com/repos/steinwurf/petro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steinwurf/petro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steinwurf/petro/teams","hooks_url":"https://api.github.com/repos/steinwurf/petro/hooks","issue_events_url":"https://api.github.com/repos/steinwurf/petro/issues/events{/number}","events_url":"https://api.github.com/repos/steinwurf/petro/events","assignees_url":"https://api.github.com/repos/steinwurf/petro/assignees{/user}","branches_url":"https://api.github.com/repos/steinwurf/petro/branches{/branch}","tags_url":"https://api.github.com/repos/steinwurf/petro/tags","blobs_url":"https://api.github.com/repos/steinwurf/petro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steinwurf/petro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steinwurf/petro/git/refs{/sha}","trees_url":"https://api.github.com/repos/steinwurf/petro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steinwurf/petro/statuses/{sha}","languages_url":"https://api.github.com/repos/steinwurf/petro/languages","stargazers_url":"https://api.github.com/repos/steinwurf/petro/stargazers","contributors_url":"https://api.github.com/repos/steinwurf/petro/contributors","subscribers_url":"https://api.github.com/repos/steinwurf/petro/subscribers","subscription_url":"https://api.github.com/repos/steinwurf/petro/subscription","commits_url":"https://api.github.com/repos/steinwurf/petro/commits{/sha}","git_commits_url":"https://api.github.com/repos/steinwurf/petro/git/commits{/sha}","comments_url":"https://api.github.com/repos/steinwurf/petro/comments{/number}","issue_comment_url":"https://api.github.com/repos/steinwurf/petro/issues/comments{/number}","contents_url":"https://api.github.com/repos/steinwurf/petro/contents/{+path}","compare_url":"https://api.github.com/repos/steinwurf/petro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steinwurf/petro/merges","archive_url":"https://api.github.com/repos/steinwurf/petro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steinwurf/petro/downloads","issues_url":"https://api.github.com/repos/steinwurf/petro/issues{/number}","pulls_url":"https://api.github.com/repos/steinwurf/petro/pulls{/number}","milestones_url":"https://api.github.com/repos/steinwurf/petro/milestones{/number}","notifications_url":"https://api.github.com/repos/steinwurf/petro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steinwurf/petro/labels{/name}","releases_url":"https://api.github.com/repos/steinwurf/petro/releases{/id}","deployments_url":"https://api.github.com/repos/steinwurf/petro/deployments","created_at":"2015-11-18T12:12:04Z","updated_at":"2016-07-18T18:10:45Z","pushed_at":"2016-09-27T21:13:26Z","git_url":"git://github.com/steinwurf/petro.git","ssh_url":"git@github.com:steinwurf/petro.git","clone_url":"https://github.com/steinwurf/petro.git","svn_url":"https://github.com/steinwurf/petro","homepage":null,"size":18773,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/steinwurf/petro/pulls/21"},"html":{"href":"https://github.com/steinwurf/petro/pull/21"},"issue":{"href":"https://api.github.com/repos/steinwurf/petro/issues/21"},"comments":{"href":"https://api.github.com/repos/steinwurf/petro/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/steinwurf/petro/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/steinwurf/petro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/steinwurf/petro/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/steinwurf/petro/statuses/4450c3f58c77e3ec3940b9d2ed2a063276c303a6"}}}}
{"actor":{"display_login":"jpihl"}}