{"action":"created","comment":{"url":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/comments/86457683","pull_request_review_id":7117636,"id":86457683,"diff_hunk":"@@ -375,6 +432,76 @@ do --Helper functions\n \tfunction LaserPointer:shouldWalk()\n \t\treturn self:isHeadMounted() or self.testWalkToMode\n \tend\n+\n+\tfunction LaserPointer:getRippleOriginPosition()\n+\t\tlocal humanoid = getLocalHumanoid()\n+\t\tif not humanoid then return end\n+\n+\t\tlocal rootPart = humanoid.Torso\n+\t\tif not rootPart then return end\n+\n+\t\tlocal hipHeight = humanoid.HipHeight\n+\t\tif humanoid.RigType == Enum.HumanoidRigType.R6 then\n+\t\t\thipHeight = 3\n+\t\tend\n+\n+\t\treturn rootPart:GetRenderCFrame().p - Vector3.new(0, hipHeight - 0.01, 0)\n+\tend\n+\n+\tfunction LaserPointer:getMaxRippleRadius()\n+\t\tlocal humanoid = getLocalHumanoid()\n+\t\tif not humanoid then return 0 end\n+\n+\t\treturn humanoid.WalkSpeed * TELEPORT.RIPPLE_MAX_BUDGET_SECONDS\n+\tend\n+\n+\tfunction LaserPointer:calculateRippleRadius()\n+\t\tlocal humanoid = getLocalHumanoid()\n+\t\tif not humanoid then return 0 end\n+\n+\t\tif self.rippleDisabled then\n+\t\t\treturn 0\n+\t\tend\n+\n+\t\tlocal currentTime = tick()\n+\t\tlocal timeSinceRippleStart = currentTime - self.rippleStartTime\n+\n+\t\tlocal budget = math.min(timeSinceRippleStart, TELEPORT.RIPPLE_MAX_BUDGET_SECONDS)\n+\t\tlocal studsPerSecond = humanoid.WalkSpeed\n+\n+\t\treturn budget * studsPerSecond\n+\tend\n+\n+\tfunction LaserPointer:calculateParabolaRipplePlaneIntersection()\n+\t\t-- x = (-b + sqrt(b^2 - 4ac)) / 2a\n+\t\tlocal parabolaOriginCF = self.originPart:GetRenderCFrame()\n+\t\tlocal planeHeight = self:getRippleOriginPosition().Y\n+\t\tlocal a, b, c = self.parabola.A, -self.parabola.B, parabolaOriginCF.p.Y - planeHeight\n+\n+\t\tif a == 0 then\n+\t\t\ta = 1e-6","path":"CoreScriptsRoot/Modules/VR/LaserPointer.lua","position":211,"original_position":211,"commit_id":"1d5b30f1fffc630f4da087677d38f2c8d997f650","original_commit_id":"1d5b30f1fffc630f4da087677d38f2c8d997f650","user":{"login":"SolarCrane","id":6992752,"avatar_url":"https://avatars.githubusercontent.com/u/6992752?v=3","gravatar_id":"","url":"https://api.github.com/users/SolarCrane","html_url":"https://github.com/SolarCrane","followers_url":"https://api.github.com/users/SolarCrane/followers","following_url":"https://api.github.com/users/SolarCrane/following{/other_user}","gists_url":"https://api.github.com/users/SolarCrane/gists{/gist_id}","starred_url":"https://api.github.com/users/SolarCrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolarCrane/subscriptions","organizations_url":"https://api.github.com/users/SolarCrane/orgs","repos_url":"https://api.github.com/users/SolarCrane/repos","events_url":"https://api.github.com/users/SolarCrane/events{/privacy}","received_events_url":"https://api.github.com/users/SolarCrane/received_events","type":"User","site_admin":false},"body":"1e-6 seems to be going around a lot here, do we want to put this in some constant?","created_at":"2016-11-03T22:33:05Z","updated_at":"2016-11-03T22:33:05Z","html_url":"https://github.com/ROBLOX/Core-Scripts/pull/614#discussion_r86457683","pull_request_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/614","_links":{"self":{"href":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/comments/86457683"},"html":{"href":"https://github.com/ROBLOX/Core-Scripts/pull/614#discussion_r86457683"},"pull_request":{"href":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/614"}}},"pull_request":{"url":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/614","id":91468962,"html_url":"https://github.com/ROBLOX/Core-Scripts/pull/614","diff_url":"https://github.com/ROBLOX/Core-Scripts/pull/614.diff","patch_url":"https://github.com/ROBLOX/Core-Scripts/pull/614.patch","issue_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/issues/614","number":614,"state":"open","locked":false,"title":"Add ripple warp mode to LaserPointer","user":{"login":"kyle-emmerich","id":1709380,"avatar_url":"https://avatars.githubusercontent.com/u/1709380?v=3","gravatar_id":"","url":"https://api.github.com/users/kyle-emmerich","html_url":"https://github.com/kyle-emmerich","followers_url":"https://api.github.com/users/kyle-emmerich/followers","following_url":"https://api.github.com/users/kyle-emmerich/following{/other_user}","gists_url":"https://api.github.com/users/kyle-emmerich/gists{/gist_id}","starred_url":"https://api.github.com/users/kyle-emmerich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyle-emmerich/subscriptions","organizations_url":"https://api.github.com/users/kyle-emmerich/orgs","repos_url":"https://api.github.com/users/kyle-emmerich/repos","events_url":"https://api.github.com/users/kyle-emmerich/events{/privacy}","received_events_url":"https://api.github.com/users/kyle-emmerich/received_events","type":"User","site_admin":false},"body":"This mode is still behind a flag\n","created_at":"2016-10-28T23:43:45Z","updated_at":"2016-11-03T22:33:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"508572bec0968f73d37453b5ef3a868c53b840ef","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/614/commits","review_comments_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/614/comments","review_comment_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/issues/614/comments","statuses_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/statuses/1d5b30f1fffc630f4da087677d38f2c8d997f650","head":{"label":"kyle-emmerich:ripple","ref":"ripple","sha":"1d5b30f1fffc630f4da087677d38f2c8d997f650","user":{"login":"kyle-emmerich","id":1709380,"avatar_url":"https://avatars.githubusercontent.com/u/1709380?v=3","gravatar_id":"","url":"https://api.github.com/users/kyle-emmerich","html_url":"https://github.com/kyle-emmerich","followers_url":"https://api.github.com/users/kyle-emmerich/followers","following_url":"https://api.github.com/users/kyle-emmerich/following{/other_user}","gists_url":"https://api.github.com/users/kyle-emmerich/gists{/gist_id}","starred_url":"https://api.github.com/users/kyle-emmerich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyle-emmerich/subscriptions","organizations_url":"https://api.github.com/users/kyle-emmerich/orgs","repos_url":"https://api.github.com/users/kyle-emmerich/repos","events_url":"https://api.github.com/users/kyle-emmerich/events{/privacy}","received_events_url":"https://api.github.com/users/kyle-emmerich/received_events","type":"User","site_admin":false},"repo":{"id":54408280,"name":"Core-Scripts","full_name":"kyle-emmerich/Core-Scripts","owner":{"login":"kyle-emmerich","id":1709380,"avatar_url":"https://avatars.githubusercontent.com/u/1709380?v=3","gravatar_id":"","url":"https://api.github.com/users/kyle-emmerich","html_url":"https://github.com/kyle-emmerich","followers_url":"https://api.github.com/users/kyle-emmerich/followers","following_url":"https://api.github.com/users/kyle-emmerich/following{/other_user}","gists_url":"https://api.github.com/users/kyle-emmerich/gists{/gist_id}","starred_url":"https://api.github.com/users/kyle-emmerich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyle-emmerich/subscriptions","organizations_url":"https://api.github.com/users/kyle-emmerich/orgs","repos_url":"https://api.github.com/users/kyle-emmerich/repos","events_url":"https://api.github.com/users/kyle-emmerich/events{/privacy}","received_events_url":"https://api.github.com/users/kyle-emmerich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kyle-emmerich/Core-Scripts","description":"All of ROBLOX's core client scripts.","fork":true,"url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts","forks_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/forks","keys_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/teams","hooks_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/hooks","issue_events_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/issues/events{/number}","events_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/events","assignees_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/assignees{/user}","branches_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/branches{/branch}","tags_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/tags","blobs_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/languages","stargazers_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/stargazers","contributors_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/contributors","subscribers_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/subscribers","subscription_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/subscription","commits_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/contents/{+path}","compare_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/merges","archive_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/downloads","issues_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/issues{/number}","pulls_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/labels{/name}","releases_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/releases{/id}","deployments_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/deployments","created_at":"2016-03-21T17:18:43Z","updated_at":"2016-10-31T18:13:00Z","pushed_at":"2016-10-31T18:12:56Z","git_url":"git://github.com/kyle-emmerich/Core-Scripts.git","ssh_url":"git@github.com:kyle-emmerich/Core-Scripts.git","clone_url":"https://github.com/kyle-emmerich/Core-Scripts.git","svn_url":"https://github.com/kyle-emmerich/Core-Scripts","homepage":"","size":3633,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ROBLOX:master","ref":"master","sha":"c919ae873d6b21d46b2fb107a80c3559d6a0b542","user":{"login":"ROBLOX","id":4195619,"avatar_url":"https://avatars.githubusercontent.com/u/4195619?v=3","gravatar_id":"","url":"https://api.github.com/users/ROBLOX","html_url":"https://github.com/ROBLOX","followers_url":"https://api.github.com/users/ROBLOX/followers","following_url":"https://api.github.com/users/ROBLOX/following{/other_user}","gists_url":"https://api.github.com/users/ROBLOX/gists{/gist_id}","starred_url":"https://api.github.com/users/ROBLOX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ROBLOX/subscriptions","organizations_url":"https://api.github.com/users/ROBLOX/orgs","repos_url":"https://api.github.com/users/ROBLOX/repos","events_url":"https://api.github.com/users/ROBLOX/events{/privacy}","received_events_url":"https://api.github.com/users/ROBLOX/received_events","type":"Organization","site_admin":false},"repo":{"id":19040095,"name":"Core-Scripts","full_name":"ROBLOX/Core-Scripts","owner":{"login":"ROBLOX","id":4195619,"avatar_url":"https://avatars.githubusercontent.com/u/4195619?v=3","gravatar_id":"","url":"https://api.github.com/users/ROBLOX","html_url":"https://github.com/ROBLOX","followers_url":"https://api.github.com/users/ROBLOX/followers","following_url":"https://api.github.com/users/ROBLOX/following{/other_user}","gists_url":"https://api.github.com/users/ROBLOX/gists{/gist_id}","starred_url":"https://api.github.com/users/ROBLOX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ROBLOX/subscriptions","organizations_url":"https://api.github.com/users/ROBLOX/orgs","repos_url":"https://api.github.com/users/ROBLOX/repos","events_url":"https://api.github.com/users/ROBLOX/events{/privacy}","received_events_url":"https://api.github.com/users/ROBLOX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ROBLOX/Core-Scripts","description":"All of ROBLOX's core client scripts.","fork":false,"url":"https://api.github.com/repos/ROBLOX/Core-Scripts","forks_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/forks","keys_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/teams","hooks_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/hooks","issue_events_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/issues/events{/number}","events_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/events","assignees_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/assignees{/user}","branches_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/branches{/branch}","tags_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/tags","blobs_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/languages","stargazers_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/stargazers","contributors_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/contributors","subscribers_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/subscribers","subscription_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/subscription","commits_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/contents/{+path}","compare_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/merges","archive_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/downloads","issues_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/issues{/number}","pulls_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/labels{/name}","releases_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/releases{/id}","deployments_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/deployments","created_at":"2014-04-22T18:02:17Z","updated_at":"2016-10-24T18:08:07Z","pushed_at":"2016-11-03T21:52:32Z","git_url":"git://github.com/ROBLOX/Core-Scripts.git","ssh_url":"git@github.com:ROBLOX/Core-Scripts.git","clone_url":"https://github.com/ROBLOX/Core-Scripts.git","svn_url":"https://github.com/ROBLOX/Core-Scripts","homepage":"","size":4861,"stargazers_count":59,"watchers_count":59,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":98,"mirror_url":null,"open_issues_count":30,"forks":98,"open_issues":30,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/614"},"html":{"href":"https://github.com/ROBLOX/Core-Scripts/pull/614"},"issue":{"href":"https://api.github.com/repos/ROBLOX/Core-Scripts/issues/614"},"comments":{"href":"https://api.github.com/repos/ROBLOX/Core-Scripts/issues/614/comments"},"review_comments":{"href":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/614/comments"},"review_comment":{"href":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/614/commits"},"statuses":{"href":"https://api.github.com/repos/ROBLOX/Core-Scripts/statuses/1d5b30f1fffc630f4da087677d38f2c8d997f650"}}}}
{"actor":{"display_login":"SolarCrane"}}