{"action":"created","issue":{"url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/issues/2236","repository_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers","labels_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/issues/2236/labels{/name}","comments_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/issues/2236/comments","events_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/issues/2236/events","html_url":"https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/2236","id":191591333,"number":2236,"title":"Documentation culture settings are ignored in the stylecop.json","user":{"login":"nick-korsakov","id":15720243,"avatar_url":"https://avatars.githubusercontent.com/u/15720243?v=3","gravatar_id":"","url":"https://api.github.com/users/nick-korsakov","html_url":"https://github.com/nick-korsakov","followers_url":"https://api.github.com/users/nick-korsakov/followers","following_url":"https://api.github.com/users/nick-korsakov/following{/other_user}","gists_url":"https://api.github.com/users/nick-korsakov/gists{/gist_id}","starred_url":"https://api.github.com/users/nick-korsakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nick-korsakov/subscriptions","organizations_url":"https://api.github.com/users/nick-korsakov/orgs","repos_url":"https://api.github.com/users/nick-korsakov/repos","events_url":"https://api.github.com/users/nick-korsakov/events{/privacy}","received_events_url":"https://api.github.com/users/nick-korsakov/received_events","type":"User","site_admin":false},"labels":[{"id":148730597,"url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/labels/bug","name":"bug","color":"fc2929","default":true},{"id":149024781,"url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/labels/up%20for%20grabs","name":"up for grabs","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-24T21:10:01Z","updated_at":"2016-12-14T17:25:55Z","closed_at":null,"body":"I use next settings in the stylecop.json with StyleCop Analyzers 1.1.0-beta001:\r\n```json\r\n{\r\n    \"documentationRules\": {\r\n        \"documentationCulture\": \"ru-RU\"\r\n    }\r\n}\r\n```\r\nStyleCop warns me [SA1642](https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.0-beta001/documentation/SA1642.md) (Constructor summary documentation must begin with standard text) when I use such comment:\r\n```csharp\r\n/// <summary>\r\n/// Инициализирует новый экземпляр <see cref=\"MyClass\"/> .\r\n/// </summary>\r\npublic MyClass()\r\n{\r\n}\r\n```\r\nBut [DocumentationResources.ru-RU.resx](https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.0-beta001/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/DocumentationResources.ru-RU.resx) contains:\r\n```xml\r\n<data name=\"NonPrivateConstructorStandardTextFirstPart\" xml:space=\"preserve\">\r\n  <value>Инициализирует новый экземпляр {0} </value>\r\n</data>\r\n<data name=\"NonPrivateConstructorStandardTextSecondPart\" xml:space=\"preserve\">\r\n  <value />\r\n</data>\r\n```\r\nMy comment matches it even in last space. I think \"documentationCulture\": \"ru-RU\" is ignored because when I used English comment [SA1642](https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.0-beta001/documentation/SA1642.md) warning was gone:\r\n```csharp\r\n/// <summary>\r\n/// Initializes a new instance of the <see cref=\"MyClass\"/> class.\r\n/// </summary>\r\npublic MyClass()\r\n{\r\n}\r\n```\r\nNo warning. But it's suspicious that [DocumentationResources.resx](https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.0-beta001/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/DocumentationResources.resx) contains \"Initializes a new instance of the {0}\" instead of \"Initializes a new instance of the {0} **class**\":\r\n```xml\r\n<data name=\"NonPrivateConstructorStandardTextFirstPart\" xml:space=\"preserve\">\r\n  <value>Initializes a new instance of the </value>\r\n</data>\r\n<data name=\"NonPrivateConstructorStandardTextSecondPart\" xml:space=\"preserve\">\r\n  <value> {0}</value>\r\n</data>\r\n```\r\nWorking comment doesn't matches English resource file."},"comment":{"url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/issues/comments/267097648","html_url":"https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/2236#issuecomment-267097648","issue_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/issues/2236","id":267097648,"user":{"login":"nick-korsakov","id":15720243,"avatar_url":"https://avatars.githubusercontent.com/u/15720243?v=3","gravatar_id":"","url":"https://api.github.com/users/nick-korsakov","html_url":"https://github.com/nick-korsakov","followers_url":"https://api.github.com/users/nick-korsakov/followers","following_url":"https://api.github.com/users/nick-korsakov/following{/other_user}","gists_url":"https://api.github.com/users/nick-korsakov/gists{/gist_id}","starred_url":"https://api.github.com/users/nick-korsakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nick-korsakov/subscriptions","organizations_url":"https://api.github.com/users/nick-korsakov/orgs","repos_url":"https://api.github.com/users/nick-korsakov/repos","events_url":"https://api.github.com/users/nick-korsakov/events{/privacy}","received_events_url":"https://api.github.com/users/nick-korsakov/received_events","type":"User","site_admin":false},"created_at":"2016-12-14T17:25:55Z","updated_at":"2016-12-14T17:25:55Z","body":"> Have you added your configuration file according to the instructions...\r\n\r\nYes.\r\n\r\nMy `stylecop.json` is [above](https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/2236#issuecomment-263048903).\r\n\r\nMy `project.json` is below:\r\n```json\r\n{\r\n    \"version\": \"0.1.0\",\r\n    \"buildOptions\": {\r\n        \"debugType\": \"portable\",\r\n        \"emitEntryPoint\": true,\r\n        \"additionalArguments\": [\r\n            \"/ruleset: rules.ruleset\",\r\n            \"/additionalfile: stylecop.json\"\r\n        ],\r\n        \"xmlDoc\": \"true\"\r\n    },\r\n    \"dependencies\": {\r\n        \"StyleCop.Analyzers\":\r\n        {\r\n            \"version\": \"1.1.0-beta001\",\r\n            \"type\": \"build\"\r\n        }\r\n    },\r\n    \"frameworks\": {\r\n        \"netcoreapp1.1\": {\r\n            \"dependencies\": {\r\n                \"Microsoft.NETCore.App\": {\r\n                    \"type\": \"platform\",\r\n                    \"version\": \"1.1.0\"\r\n                }\r\n            },\r\n            \"imports\": \"dnxcore50\"\r\n        }\r\n    }\r\n}\r\n```\r\n\r\nAnd `rules.ruleset`:\r\n```xml\r\n<?xml version=\"1.0\" encoding=\"utf-8\"?>\r\n<RuleSet Name=\"StyleCop.Analyzers rules\" ToolsVersion=\"14.0\">\r\n    <Rules AnalyzerId=\"StyleCop.Analyzers\" RuleNamespace=\"StyleCop.Analyzers\">\r\n        <!--\r\n        <Rule Id=\"SA1623\" Action=\"Hidden\" />\r\n        <Rule Id=\"SA1636\" Action=\"Hidden\" />\r\n        -->\r\n    </Rules>\r\n</RuleSet>\r\n```\r\n\r\nAny changes in those files takes effect. Most of rules works."}}
{"actor":{"display_login":"nick-korsakov"}}