{"action":"created","comment":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/75277800","id":75277800,"diff_hunk":"@@ -30,22 +30,23 @@ def upload_scripts(machine, args):\n     if args[\"containers\"]:\n         machine.upload([os.path.join(testinfra.TEST_DIR,\"..\", \"containers\")], \"/var/tmp\")\n \n-def run_install_script(machine, do_build, do_install, skip, arg, args):\n+def run_install_script(machine, do_build, do_install, skips, arg, args):\n     install = do_install\n     if args[\"containers\"]:\n         do_install = False\n \n+    skip_args = map(lambda skip: \" --skip '%s'\" % skip, skips)\n     machine.execute(\"cd /var/tmp; ./%s.install%s%s%s%s%s%s\" % (machine.image,\n                                                          \" --verbose\" if args[\"verbose\"] else \"\",\n                                                          \" --quick\" if args[\"quick\"] else \"\",\n                                                          \" --build\" if do_build else \"\",\n                                                          \" --install\" if do_install else \"\",\n-                                                         \" --skip '%s'\" % skip if skip else \"\",\n+                                                         \" \".join(skip_args),\n                                                          \" '%s'\" % arg if arg else \"\"))\n     if install and args[\"containers\"]:\n         machine.execute(\"/var/lib/testvm/containers.install\")\n \n-def build_and_maybe_install(image, do_install=False, skip=None, args=None):\n+def build_and_maybe_install(image, do_install=False, skips=[], args=None):","path":"test/common/vmmanage.py","position":23,"original_position":23,"commit_id":"acca6da3a9c54da4c0cf3a3782760dd1ec06e1b0","original_commit_id":"acca6da3a9c54da4c0cf3a3782760dd1ec06e1b0","user":{"login":"stefwalter","id":795070,"avatar_url":"https://avatars.githubusercontent.com/u/795070?v=3","gravatar_id":"","url":"https://api.github.com/users/stefwalter","html_url":"https://github.com/stefwalter","followers_url":"https://api.github.com/users/stefwalter/followers","following_url":"https://api.github.com/users/stefwalter/following{/other_user}","gists_url":"https://api.github.com/users/stefwalter/gists{/gist_id}","starred_url":"https://api.github.com/users/stefwalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefwalter/subscriptions","organizations_url":"https://api.github.com/users/stefwalter/orgs","repos_url":"https://api.github.com/users/stefwalter/repos","events_url":"https://api.github.com/users/stefwalter/events{/privacy}","received_events_url":"https://api.github.com/users/stefwalter/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2016-08-18T09:42:40Z","updated_at":"2016-08-18T09:42:40Z","html_url":"https://github.com/cockpit-project/cockpit/pull/4596#discussion_r75277800","pull_request_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/4596","_links":{"self":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/75277800"},"html":{"href":"https://github.com/cockpit-project/cockpit/pull/4596#discussion_r75277800"},"pull_request":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/4596"}}},"pull_request":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/4596","id":74342673,"html_url":"https://github.com/cockpit-project/cockpit/pull/4596","diff_url":"https://github.com/cockpit-project/cockpit/pull/4596.diff","patch_url":"https://github.com/cockpit-project/cockpit/pull/4596.patch","issue_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/4596","number":4596,"state":"open","locked":false,"title":"Skip cockpit-test-assets when installing in a target machine","user":{"login":"stefwalter","id":795070,"avatar_url":"https://avatars.githubusercontent.com/u/795070?v=3","gravatar_id":"","url":"https://api.github.com/users/stefwalter","html_url":"https://github.com/stefwalter","followers_url":"https://api.github.com/users/stefwalter/followers","following_url":"https://api.github.com/users/stefwalter/following{/other_user}","gists_url":"https://api.github.com/users/stefwalter/gists{/gist_id}","starred_url":"https://api.github.com/users/stefwalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefwalter/subscriptions","organizations_url":"https://api.github.com/users/stefwalter/orgs","repos_url":"https://api.github.com/users/stefwalter/repos","events_url":"https://api.github.com/users/stefwalter/events{/privacy}","received_events_url":"https://api.github.com/users/stefwalter/received_events","type":"User","site_admin":false},"body":"When vm-install is used with --address, these machines are used for demoing, or debugging, and we don't want all the playground stuff cluttering up the sidebar.","created_at":"2016-06-18T17:26:17Z","updated_at":"2016-08-18T09:42:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92c93ee8856ad6de0265fe627210a701c9530963","assignee":{"login":"dperpeet","id":8711649,"avatar_url":"https://avatars.githubusercontent.com/u/8711649?v=3","gravatar_id":"","url":"https://api.github.com/users/dperpeet","html_url":"https://github.com/dperpeet","followers_url":"https://api.github.com/users/dperpeet/followers","following_url":"https://api.github.com/users/dperpeet/following{/other_user}","gists_url":"https://api.github.com/users/dperpeet/gists{/gist_id}","starred_url":"https://api.github.com/users/dperpeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dperpeet/subscriptions","organizations_url":"https://api.github.com/users/dperpeet/orgs","repos_url":"https://api.github.com/users/dperpeet/repos","events_url":"https://api.github.com/users/dperpeet/events{/privacy}","received_events_url":"https://api.github.com/users/dperpeet/received_events","type":"User","site_admin":false},"assignees":[{"login":"dperpeet","id":8711649,"avatar_url":"https://avatars.githubusercontent.com/u/8711649?v=3","gravatar_id":"","url":"https://api.github.com/users/dperpeet","html_url":"https://github.com/dperpeet","followers_url":"https://api.github.com/users/dperpeet/followers","following_url":"https://api.github.com/users/dperpeet/following{/other_user}","gists_url":"https://api.github.com/users/dperpeet/gists{/gist_id}","starred_url":"https://api.github.com/users/dperpeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dperpeet/subscriptions","organizations_url":"https://api.github.com/users/dperpeet/orgs","repos_url":"https://api.github.com/users/dperpeet/repos","events_url":"https://api.github.com/users/dperpeet/events{/privacy}","received_events_url":"https://api.github.com/users/dperpeet/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/4596/commits","review_comments_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/4596/comments","review_comment_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/4596/comments","statuses_url":"https://api.github.com/repos/cockpit-project/cockpit/statuses/acca6da3a9c54da4c0cf3a3782760dd1ec06e1b0","head":{"label":"stefwalter:dont-install-test-assets","ref":"dont-install-test-assets","sha":"acca6da3a9c54da4c0cf3a3782760dd1ec06e1b0","user":{"login":"stefwalter","id":795070,"avatar_url":"https://avatars.githubusercontent.com/u/795070?v=3","gravatar_id":"","url":"https://api.github.com/users/stefwalter","html_url":"https://github.com/stefwalter","followers_url":"https://api.github.com/users/stefwalter/followers","following_url":"https://api.github.com/users/stefwalter/following{/other_user}","gists_url":"https://api.github.com/users/stefwalter/gists{/gist_id}","starred_url":"https://api.github.com/users/stefwalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefwalter/subscriptions","organizations_url":"https://api.github.com/users/stefwalter/orgs","repos_url":"https://api.github.com/users/stefwalter/repos","events_url":"https://api.github.com/users/stefwalter/events{/privacy}","received_events_url":"https://api.github.com/users/stefwalter/received_events","type":"User","site_admin":false},"repo":{"id":14296513,"name":"cockpit","full_name":"stefwalter/cockpit","owner":{"login":"stefwalter","id":795070,"avatar_url":"https://avatars.githubusercontent.com/u/795070?v=3","gravatar_id":"","url":"https://api.github.com/users/stefwalter","html_url":"https://github.com/stefwalter","followers_url":"https://api.github.com/users/stefwalter/followers","following_url":"https://api.github.com/users/stefwalter/following{/other_user}","gists_url":"https://api.github.com/users/stefwalter/gists{/gist_id}","starred_url":"https://api.github.com/users/stefwalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefwalter/subscriptions","organizations_url":"https://api.github.com/users/stefwalter/orgs","repos_url":"https://api.github.com/users/stefwalter/repos","events_url":"https://api.github.com/users/stefwalter/events{/privacy}","received_events_url":"https://api.github.com/users/stefwalter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stefwalter/cockpit","description":"Cockpit, a user interface for Linux servers","fork":true,"url":"https://api.github.com/repos/stefwalter/cockpit","forks_url":"https://api.github.com/repos/stefwalter/cockpit/forks","keys_url":"https://api.github.com/repos/stefwalter/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stefwalter/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stefwalter/cockpit/teams","hooks_url":"https://api.github.com/repos/stefwalter/cockpit/hooks","issue_events_url":"https://api.github.com/repos/stefwalter/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/stefwalter/cockpit/events","assignees_url":"https://api.github.com/repos/stefwalter/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/stefwalter/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/stefwalter/cockpit/tags","blobs_url":"https://api.github.com/repos/stefwalter/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stefwalter/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stefwalter/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/stefwalter/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stefwalter/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/stefwalter/cockpit/languages","stargazers_url":"https://api.github.com/repos/stefwalter/cockpit/stargazers","contributors_url":"https://api.github.com/repos/stefwalter/cockpit/contributors","subscribers_url":"https://api.github.com/repos/stefwalter/cockpit/subscribers","subscription_url":"https://api.github.com/repos/stefwalter/cockpit/subscription","commits_url":"https://api.github.com/repos/stefwalter/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/stefwalter/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/stefwalter/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/stefwalter/cockpit/issues/comments{/number}","contents_url":"https://api.github.com/repos/stefwalter/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/stefwalter/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stefwalter/cockpit/merges","archive_url":"https://api.github.com/repos/stefwalter/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stefwalter/cockpit/downloads","issues_url":"https://api.github.com/repos/stefwalter/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/stefwalter/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/stefwalter/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/stefwalter/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stefwalter/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/stefwalter/cockpit/releases{/id}","deployments_url":"https://api.github.com/repos/stefwalter/cockpit/deployments","created_at":"2013-11-11T09:27:50Z","updated_at":"2015-10-26T15:34:42Z","pushed_at":"2016-08-18T09:36:18Z","git_url":"git://github.com/stefwalter/cockpit.git","ssh_url":"git@github.com:stefwalter/cockpit.git","clone_url":"https://github.com/stefwalter/cockpit.git","svn_url":"https://github.com/stefwalter/cockpit","homepage":"http://www.cockpit-project.org/","size":29186,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockpit-project:master","ref":"master","sha":"e66a7f3a618286b8f221b26108d77b66e8af39e5","user":{"login":"cockpit-project","id":5765104,"avatar_url":"https://avatars.githubusercontent.com/u/5765104?v=3","gravatar_id":"","url":"https://api.github.com/users/cockpit-project","html_url":"https://github.com/cockpit-project","followers_url":"https://api.github.com/users/cockpit-project/followers","following_url":"https://api.github.com/users/cockpit-project/following{/other_user}","gists_url":"https://api.github.com/users/cockpit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cockpit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockpit-project/subscriptions","organizations_url":"https://api.github.com/users/cockpit-project/orgs","repos_url":"https://api.github.com/users/cockpit-project/repos","events_url":"https://api.github.com/users/cockpit-project/events{/privacy}","received_events_url":"https://api.github.com/users/cockpit-project/received_events","type":"Organization","site_admin":false},"repo":{"id":14049216,"name":"cockpit","full_name":"cockpit-project/cockpit","owner":{"login":"cockpit-project","id":5765104,"avatar_url":"https://avatars.githubusercontent.com/u/5765104?v=3","gravatar_id":"","url":"https://api.github.com/users/cockpit-project","html_url":"https://github.com/cockpit-project","followers_url":"https://api.github.com/users/cockpit-project/followers","following_url":"https://api.github.com/users/cockpit-project/following{/other_user}","gists_url":"https://api.github.com/users/cockpit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cockpit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockpit-project/subscriptions","organizations_url":"https://api.github.com/users/cockpit-project/orgs","repos_url":"https://api.github.com/users/cockpit-project/repos","events_url":"https://api.github.com/users/cockpit-project/events{/privacy}","received_events_url":"https://api.github.com/users/cockpit-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockpit-project/cockpit","description":"Cockpit, a user interface for Linux servers","fork":false,"url":"https://api.github.com/repos/cockpit-project/cockpit","forks_url":"https://api.github.com/repos/cockpit-project/cockpit/forks","keys_url":"https://api.github.com/repos/cockpit-project/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockpit-project/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockpit-project/cockpit/teams","hooks_url":"https://api.github.com/repos/cockpit-project/cockpit/hooks","issue_events_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/cockpit-project/cockpit/events","assignees_url":"https://api.github.com/repos/cockpit-project/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/cockpit-project/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/cockpit-project/cockpit/tags","blobs_url":"https://api.github.com/repos/cockpit-project/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockpit-project/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockpit-project/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockpit-project/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockpit-project/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/cockpit-project/cockpit/languages","stargazers_url":"https://api.github.com/repos/cockpit-project/cockpit/stargazers","contributors_url":"https://api.github.com/repos/cockpit-project/cockpit/contributors","subscribers_url":"https://api.github.com/repos/cockpit-project/cockpit/subscribers","subscription_url":"https://api.github.com/repos/cockpit-project/cockpit/subscription","commits_url":"https://api.github.com/repos/cockpit-project/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockpit-project/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockpit-project/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/cockpit-project/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockpit-project/cockpit/merges","archive_url":"https://api.github.com/repos/cockpit-project/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockpit-project/cockpit/downloads","issues_url":"https://api.github.com/repos/cockpit-project/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/cockpit-project/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/cockpit-project/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockpit-project/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/cockpit-project/cockpit/releases{/id}","deployments_url":"https://api.github.com/repos/cockpit-project/cockpit/deployments","created_at":"2013-11-01T17:36:46Z","updated_at":"2016-08-18T03:25:18Z","pushed_at":"2016-08-18T09:36:18Z","git_url":"git://github.com/cockpit-project/cockpit.git","ssh_url":"git@github.com:cockpit-project/cockpit.git","clone_url":"https://github.com/cockpit-project/cockpit.git","svn_url":"https://github.com/cockpit-project/cockpit","homepage":"http://www.cockpit-project.org/","size":38090,"stargazers_count":1677,"watchers_count":1677,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":220,"mirror_url":null,"open_issues_count":418,"forks":220,"open_issues":418,"watchers":1677,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/4596"},"html":{"href":"https://github.com/cockpit-project/cockpit/pull/4596"},"issue":{"href":"https://api.github.com/repos/cockpit-project/cockpit/issues/4596"},"comments":{"href":"https://api.github.com/repos/cockpit-project/cockpit/issues/4596/comments"},"review_comments":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/4596/comments"},"review_comment":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/4596/commits"},"statuses":{"href":"https://api.github.com/repos/cockpit-project/cockpit/statuses/acca6da3a9c54da4c0cf3a3782760dd1ec06e1b0"}}}}
{"actor":{"display_login":"stefwalter"}}