{"action":"created","issue":{"url":"https://api.github.com/repos/jeremykendall/php-domain-parser/issues/61","labels_url":"https://api.github.com/repos/jeremykendall/php-domain-parser/issues/61/labels{/name}","comments_url":"https://api.github.com/repos/jeremykendall/php-domain-parser/issues/61/comments","events_url":"https://api.github.com/repos/jeremykendall/php-domain-parser/issues/61/events","html_url":"https://github.com/jeremykendall/php-domain-parser/pull/61","id":128189244,"number":61,"title":"Overall modification prompted by magic functions breaking phpspec tests.","user":{"login":"Saeven","id":887224,"avatar_url":"https://avatars.githubusercontent.com/u/887224?v=3","gravatar_id":"","url":"https://api.github.com/users/Saeven","html_url":"https://github.com/Saeven","followers_url":"https://api.github.com/users/Saeven/followers","following_url":"https://api.github.com/users/Saeven/following{/other_user}","gists_url":"https://api.github.com/users/Saeven/gists{/gist_id}","starred_url":"https://api.github.com/users/Saeven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Saeven/subscriptions","organizations_url":"https://api.github.com/users/Saeven/orgs","repos_url":"https://api.github.com/users/Saeven/repos","events_url":"https://api.github.com/users/Saeven/events{/privacy}","received_events_url":"https://api.github.com/users/Saeven/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-22T16:13:44Z","updated_at":"2016-01-22T16:21:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jeremykendall/php-domain-parser/pulls/61","html_url":"https://github.com/jeremykendall/php-domain-parser/pull/61","diff_url":"https://github.com/jeremykendall/php-domain-parser/pull/61.diff","patch_url":"https://github.com/jeremykendall/php-domain-parser/pull/61.patch"},"body":"Thanks for being open-minded about this one, really appreciate it.  \r\n\r\nMainly replaced magic FNs, and corrected some typos along the way.  Tests all fixed.  Recommend a major version increment since this'll be a BC if folks are using versions with typos or pseudo-public access.\r\n\r\n* Fixed typo in 'isMultiLabelDomain' (was isMutliLabelDomain).\r\n* Standardized use of Registrable vs. Registerable  (registrable is proper spelling)\r\n* Removed magic getters, substituted with proper accessors\r\n* Made private members previous accessed by accessors, protected to permit inheritance\r\n* Changed all tests and docs to reflect changes"},"comment":{"url":"https://api.github.com/repos/jeremykendall/php-domain-parser/issues/comments/173966827","html_url":"https://github.com/jeremykendall/php-domain-parser/pull/61#issuecomment-173966827","issue_url":"https://api.github.com/repos/jeremykendall/php-domain-parser/issues/61","id":173966827,"user":{"login":"Saeven","id":887224,"avatar_url":"https://avatars.githubusercontent.com/u/887224?v=3","gravatar_id":"","url":"https://api.github.com/users/Saeven","html_url":"https://github.com/Saeven","followers_url":"https://api.github.com/users/Saeven/followers","following_url":"https://api.github.com/users/Saeven/following{/other_user}","gists_url":"https://api.github.com/users/Saeven/gists{/gist_id}","starred_url":"https://api.github.com/users/Saeven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Saeven/subscriptions","organizations_url":"https://api.github.com/users/Saeven/orgs","repos_url":"https://api.github.com/users/Saeven/repos","events_url":"https://api.github.com/users/Saeven/events{/privacy}","received_events_url":"https://api.github.com/users/Saeven/received_events","type":"User","site_admin":false},"created_at":"2016-01-22T16:21:10Z","updated_at":"2016-01-22T16:21:10Z","body":"Tests are passing on PHP7 on my local machine.  I'll set up PHP5 and give it a shot."}}