{"action":"created","comment":{"url":"https://api.github.com/repos/espressif/esp-idf/pulls/comments/92079304","pull_request_review_id":12587184,"id":92079304,"diff_hunk":"@@ -0,0 +1,207 @@\n+// Copyright 2010-2016 Espressif Systems (Shanghai) PTE LTD\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//     http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+// Test for spi_flash_{read,write}.\n+\n+#include <assert.h>\n+#include <stdint.h>\n+#include <stdio.h>\n+#include <string.h>\n+#include <sys/param.h>\n+\n+#include <unity.h>\n+#include <esp_spi_flash.h>\n+#include <rom/spi_flash.h>\n+#include \"../cache_utils.h\"\n+#include \"soc/timer_group_struct.h\"\n+#include \"soc/timer_group_reg.h\"\n+\n+/* Base offset in flash for tests. */\n+#define FLASH_BASE 0x100000","path":"components/spi_flash/test/test_read_write.c","position":31,"original_position":31,"commit_id":"0cd646a3f55af7f118f30e37890ed98afbf8ff29","original_commit_id":"0cd646a3f55af7f118f30e37890ed98afbf8ff29","user":{"login":"igrr","id":4349050,"avatar_url":"https://avatars.githubusercontent.com/u/4349050?v=3","gravatar_id":"","url":"https://api.github.com/users/igrr","html_url":"https://github.com/igrr","followers_url":"https://api.github.com/users/igrr/followers","following_url":"https://api.github.com/users/igrr/following{/other_user}","gists_url":"https://api.github.com/users/igrr/gists{/gist_id}","starred_url":"https://api.github.com/users/igrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igrr/subscriptions","organizations_url":"https://api.github.com/users/igrr/orgs","repos_url":"https://api.github.com/users/igrr/repos","events_url":"https://api.github.com/users/igrr/events{/privacy}","received_events_url":"https://api.github.com/users/igrr/received_events","type":"User","site_admin":false},"body":"IIRC, the factory partition ends at only at 0x110000","created_at":"2016-12-13T01:19:03Z","updated_at":"2016-12-13T01:25:03Z","html_url":"https://github.com/espressif/esp-idf/pull/155#discussion_r92079304","pull_request_url":"https://api.github.com/repos/espressif/esp-idf/pulls/155","_links":{"self":{"href":"https://api.github.com/repos/espressif/esp-idf/pulls/comments/92079304"},"html":{"href":"https://github.com/espressif/esp-idf/pull/155#discussion_r92079304"},"pull_request":{"href":"https://api.github.com/repos/espressif/esp-idf/pulls/155"}}},"pull_request":{"url":"https://api.github.com/repos/espressif/esp-idf/pulls/155","id":97349324,"html_url":"https://github.com/espressif/esp-idf/pull/155","diff_url":"https://github.com/espressif/esp-idf/pull/155.diff","patch_url":"https://github.com/espressif/esp-idf/pull/155.patch","issue_url":"https://api.github.com/repos/espressif/esp-idf/issues/155","number":155,"state":"open","locked":false,"title":"Remove alignment reqs from spi_flash_{read,write}","user":{"login":"rojer","id":531307,"avatar_url":"https://avatars.githubusercontent.com/u/531307?v=3","gravatar_id":"","url":"https://api.github.com/users/rojer","html_url":"https://github.com/rojer","followers_url":"https://api.github.com/users/rojer/followers","following_url":"https://api.github.com/users/rojer/following{/other_user}","gists_url":"https://api.github.com/users/rojer/gists{/gist_id}","starred_url":"https://api.github.com/users/rojer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rojer/subscriptions","organizations_url":"https://api.github.com/users/rojer/orgs","repos_url":"https://api.github.com/users/rojer/repos","events_url":"https://api.github.com/users/rojer/events{/privacy}","received_events_url":"https://api.github.com/users/rojer/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-09T17:34:36Z","updated_at":"2016-12-13T01:25:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cef84db49f23aaba0e6cf714d300b3cc56084619","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/espressif/esp-idf/pulls/155/commits","review_comments_url":"https://api.github.com/repos/espressif/esp-idf/pulls/155/comments","review_comment_url":"https://api.github.com/repos/espressif/esp-idf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/espressif/esp-idf/issues/155/comments","statuses_url":"https://api.github.com/repos/espressif/esp-idf/statuses/0cd646a3f55af7f118f30e37890ed98afbf8ff29","head":{"label":"cesanta:flash_align","ref":"flash_align","sha":"0cd646a3f55af7f118f30e37890ed98afbf8ff29","user":{"login":"cesanta","id":5111322,"avatar_url":"https://avatars.githubusercontent.com/u/5111322?v=3","gravatar_id":"","url":"https://api.github.com/users/cesanta","html_url":"https://github.com/cesanta","followers_url":"https://api.github.com/users/cesanta/followers","following_url":"https://api.github.com/users/cesanta/following{/other_user}","gists_url":"https://api.github.com/users/cesanta/gists{/gist_id}","starred_url":"https://api.github.com/users/cesanta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesanta/subscriptions","organizations_url":"https://api.github.com/users/cesanta/orgs","repos_url":"https://api.github.com/users/cesanta/repos","events_url":"https://api.github.com/users/cesanta/events{/privacy}","received_events_url":"https://api.github.com/users/cesanta/received_events","type":"Organization","site_admin":false},"repo":{"id":75497881,"name":"esp-idf","full_name":"cesanta/esp-idf","owner":{"login":"cesanta","id":5111322,"avatar_url":"https://avatars.githubusercontent.com/u/5111322?v=3","gravatar_id":"","url":"https://api.github.com/users/cesanta","html_url":"https://github.com/cesanta","followers_url":"https://api.github.com/users/cesanta/followers","following_url":"https://api.github.com/users/cesanta/following{/other_user}","gists_url":"https://api.github.com/users/cesanta/gists{/gist_id}","starred_url":"https://api.github.com/users/cesanta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesanta/subscriptions","organizations_url":"https://api.github.com/users/cesanta/orgs","repos_url":"https://api.github.com/users/cesanta/repos","events_url":"https://api.github.com/users/cesanta/events{/privacy}","received_events_url":"https://api.github.com/users/cesanta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cesanta/esp-idf","description":"Espressif IoT Development Framework. Official development framework for ESP32.","fork":true,"url":"https://api.github.com/repos/cesanta/esp-idf","forks_url":"https://api.github.com/repos/cesanta/esp-idf/forks","keys_url":"https://api.github.com/repos/cesanta/esp-idf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cesanta/esp-idf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cesanta/esp-idf/teams","hooks_url":"https://api.github.com/repos/cesanta/esp-idf/hooks","issue_events_url":"https://api.github.com/repos/cesanta/esp-idf/issues/events{/number}","events_url":"https://api.github.com/repos/cesanta/esp-idf/events","assignees_url":"https://api.github.com/repos/cesanta/esp-idf/assignees{/user}","branches_url":"https://api.github.com/repos/cesanta/esp-idf/branches{/branch}","tags_url":"https://api.github.com/repos/cesanta/esp-idf/tags","blobs_url":"https://api.github.com/repos/cesanta/esp-idf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cesanta/esp-idf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cesanta/esp-idf/git/refs{/sha}","trees_url":"https://api.github.com/repos/cesanta/esp-idf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cesanta/esp-idf/statuses/{sha}","languages_url":"https://api.github.com/repos/cesanta/esp-idf/languages","stargazers_url":"https://api.github.com/repos/cesanta/esp-idf/stargazers","contributors_url":"https://api.github.com/repos/cesanta/esp-idf/contributors","subscribers_url":"https://api.github.com/repos/cesanta/esp-idf/subscribers","subscription_url":"https://api.github.com/repos/cesanta/esp-idf/subscription","commits_url":"https://api.github.com/repos/cesanta/esp-idf/commits{/sha}","git_commits_url":"https://api.github.com/repos/cesanta/esp-idf/git/commits{/sha}","comments_url":"https://api.github.com/repos/cesanta/esp-idf/comments{/number}","issue_comment_url":"https://api.github.com/repos/cesanta/esp-idf/issues/comments{/number}","contents_url":"https://api.github.com/repos/cesanta/esp-idf/contents/{+path}","compare_url":"https://api.github.com/repos/cesanta/esp-idf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cesanta/esp-idf/merges","archive_url":"https://api.github.com/repos/cesanta/esp-idf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cesanta/esp-idf/downloads","issues_url":"https://api.github.com/repos/cesanta/esp-idf/issues{/number}","pulls_url":"https://api.github.com/repos/cesanta/esp-idf/pulls{/number}","milestones_url":"https://api.github.com/repos/cesanta/esp-idf/milestones{/number}","notifications_url":"https://api.github.com/repos/cesanta/esp-idf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cesanta/esp-idf/labels{/name}","releases_url":"https://api.github.com/repos/cesanta/esp-idf/releases{/id}","deployments_url":"https://api.github.com/repos/cesanta/esp-idf/deployments","created_at":"2016-12-03T20:15:42Z","updated_at":"2016-12-03T20:15:52Z","pushed_at":"2016-12-12T18:06:48Z","git_url":"git://github.com/cesanta/esp-idf.git","ssh_url":"git@github.com:cesanta/esp-idf.git","clone_url":"https://github.com/cesanta/esp-idf.git","svn_url":"https://github.com/cesanta/esp-idf","homepage":"","size":9728,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"espressif:master","ref":"master","sha":"f807d16310719b0dcef07de0276934653b6e48ed","user":{"login":"espressif","id":9460735,"avatar_url":"https://avatars.githubusercontent.com/u/9460735?v=3","gravatar_id":"","url":"https://api.github.com/users/espressif","html_url":"https://github.com/espressif","followers_url":"https://api.github.com/users/espressif/followers","following_url":"https://api.github.com/users/espressif/following{/other_user}","gists_url":"https://api.github.com/users/espressif/gists{/gist_id}","starred_url":"https://api.github.com/users/espressif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espressif/subscriptions","organizations_url":"https://api.github.com/users/espressif/orgs","repos_url":"https://api.github.com/users/espressif/repos","events_url":"https://api.github.com/users/espressif/events{/privacy}","received_events_url":"https://api.github.com/users/espressif/received_events","type":"Organization","site_admin":false},"repo":{"id":65899476,"name":"esp-idf","full_name":"espressif/esp-idf","owner":{"login":"espressif","id":9460735,"avatar_url":"https://avatars.githubusercontent.com/u/9460735?v=3","gravatar_id":"","url":"https://api.github.com/users/espressif","html_url":"https://github.com/espressif","followers_url":"https://api.github.com/users/espressif/followers","following_url":"https://api.github.com/users/espressif/following{/other_user}","gists_url":"https://api.github.com/users/espressif/gists{/gist_id}","starred_url":"https://api.github.com/users/espressif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espressif/subscriptions","organizations_url":"https://api.github.com/users/espressif/orgs","repos_url":"https://api.github.com/users/espressif/repos","events_url":"https://api.github.com/users/espressif/events{/privacy}","received_events_url":"https://api.github.com/users/espressif/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/espressif/esp-idf","description":"Espressif IoT Development Framework. Official development framework for ESP32.","fork":false,"url":"https://api.github.com/repos/espressif/esp-idf","forks_url":"https://api.github.com/repos/espressif/esp-idf/forks","keys_url":"https://api.github.com/repos/espressif/esp-idf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/espressif/esp-idf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/espressif/esp-idf/teams","hooks_url":"https://api.github.com/repos/espressif/esp-idf/hooks","issue_events_url":"https://api.github.com/repos/espressif/esp-idf/issues/events{/number}","events_url":"https://api.github.com/repos/espressif/esp-idf/events","assignees_url":"https://api.github.com/repos/espressif/esp-idf/assignees{/user}","branches_url":"https://api.github.com/repos/espressif/esp-idf/branches{/branch}","tags_url":"https://api.github.com/repos/espressif/esp-idf/tags","blobs_url":"https://api.github.com/repos/espressif/esp-idf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/espressif/esp-idf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/espressif/esp-idf/git/refs{/sha}","trees_url":"https://api.github.com/repos/espressif/esp-idf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/espressif/esp-idf/statuses/{sha}","languages_url":"https://api.github.com/repos/espressif/esp-idf/languages","stargazers_url":"https://api.github.com/repos/espressif/esp-idf/stargazers","contributors_url":"https://api.github.com/repos/espressif/esp-idf/contributors","subscribers_url":"https://api.github.com/repos/espressif/esp-idf/subscribers","subscription_url":"https://api.github.com/repos/espressif/esp-idf/subscription","commits_url":"https://api.github.com/repos/espressif/esp-idf/commits{/sha}","git_commits_url":"https://api.github.com/repos/espressif/esp-idf/git/commits{/sha}","comments_url":"https://api.github.com/repos/espressif/esp-idf/comments{/number}","issue_comment_url":"https://api.github.com/repos/espressif/esp-idf/issues/comments{/number}","contents_url":"https://api.github.com/repos/espressif/esp-idf/contents/{+path}","compare_url":"https://api.github.com/repos/espressif/esp-idf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/espressif/esp-idf/merges","archive_url":"https://api.github.com/repos/espressif/esp-idf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/espressif/esp-idf/downloads","issues_url":"https://api.github.com/repos/espressif/esp-idf/issues{/number}","pulls_url":"https://api.github.com/repos/espressif/esp-idf/pulls{/number}","milestones_url":"https://api.github.com/repos/espressif/esp-idf/milestones{/number}","notifications_url":"https://api.github.com/repos/espressif/esp-idf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/espressif/esp-idf/labels{/name}","releases_url":"https://api.github.com/repos/espressif/esp-idf/releases{/id}","deployments_url":"https://api.github.com/repos/espressif/esp-idf/deployments","created_at":"2016-08-17T10:40:35Z","updated_at":"2016-12-12T14:52:38Z","pushed_at":"2016-12-12T18:06:49Z","git_url":"git://github.com/espressif/esp-idf.git","ssh_url":"git@github.com:espressif/esp-idf.git","clone_url":"https://github.com/espressif/esp-idf.git","svn_url":"https://github.com/espressif/esp-idf","homepage":"","size":9948,"stargazers_count":351,"watchers_count":351,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":110,"mirror_url":null,"open_issues_count":56,"forks":110,"open_issues":56,"watchers":351,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/espressif/esp-idf/pulls/155"},"html":{"href":"https://github.com/espressif/esp-idf/pull/155"},"issue":{"href":"https://api.github.com/repos/espressif/esp-idf/issues/155"},"comments":{"href":"https://api.github.com/repos/espressif/esp-idf/issues/155/comments"},"review_comments":{"href":"https://api.github.com/repos/espressif/esp-idf/pulls/155/comments"},"review_comment":{"href":"https://api.github.com/repos/espressif/esp-idf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/espressif/esp-idf/pulls/155/commits"},"statuses":{"href":"https://api.github.com/repos/espressif/esp-idf/statuses/0cd646a3f55af7f118f30e37890ed98afbf8ff29"}}}}
{"actor":{"display_login":"igrr"}}