{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift-corelibs-xctest/issues/166","repository_url":"https://api.github.com/repos/apple/swift-corelibs-xctest","labels_url":"https://api.github.com/repos/apple/swift-corelibs-xctest/issues/166/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-xctest/issues/166/comments","events_url":"https://api.github.com/repos/apple/swift-corelibs-xctest/issues/166/events","html_url":"https://github.com/apple/swift-corelibs-xctest/pull/166","id":172226446,"number":166,"title":"Add @discardableResult annotation to applicable public API methods.","user":{"login":"briancroom","id":1062518,"avatar_url":"https://avatars.githubusercontent.com/u/1062518?v=3","gravatar_id":"","url":"https://api.github.com/users/briancroom","html_url":"https://github.com/briancroom","followers_url":"https://api.github.com/users/briancroom/followers","following_url":"https://api.github.com/users/briancroom/following{/other_user}","gists_url":"https://api.github.com/users/briancroom/gists{/gist_id}","starred_url":"https://api.github.com/users/briancroom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briancroom/subscriptions","organizations_url":"https://api.github.com/users/briancroom/orgs","repos_url":"https://api.github.com/users/briancroom/repos","events_url":"https://api.github.com/users/briancroom/events{/privacy}","received_events_url":"https://api.github.com/users/briancroom/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-19T21:43:25Z","updated_at":"2016-08-19T23:25:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apple/swift-corelibs-xctest/pulls/166","html_url":"https://github.com/apple/swift-corelibs-xctest/pull/166","diff_url":"https://github.com/apple/swift-corelibs-xctest/pull/166.diff","patch_url":"https://github.com/apple/swift-corelibs-xctest/pull/166.patch"},"body":"This maintains consistency with the Darwin XCTest APIs. This also cleans up some warnings in the functional test suite which were being generated because this annotation wasn't present.\r\n\r\nI'll note that there's a case to be made that `expectation(description:file:line:)` should *not* have `@discardableResult`, because the expectation it produces can only be fulfilled by invoking a method on the returned value. Nonetheless, I think it's better to keep the APIs in sync for right now and revisit in the future."},"comment":{"url":"https://api.github.com/repos/apple/swift-corelibs-xctest/issues/comments/241159124","html_url":"https://github.com/apple/swift-corelibs-xctest/pull/166#issuecomment-241159124","issue_url":"https://api.github.com/repos/apple/swift-corelibs-xctest/issues/166","id":241159124,"user":{"login":"briancroom","id":1062518,"avatar_url":"https://avatars.githubusercontent.com/u/1062518?v=3","gravatar_id":"","url":"https://api.github.com/users/briancroom","html_url":"https://github.com/briancroom","followers_url":"https://api.github.com/users/briancroom/followers","following_url":"https://api.github.com/users/briancroom/following{/other_user}","gists_url":"https://api.github.com/users/briancroom/gists{/gist_id}","starred_url":"https://api.github.com/users/briancroom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briancroom/subscriptions","organizations_url":"https://api.github.com/users/briancroom/orgs","repos_url":"https://api.github.com/users/briancroom/repos","events_url":"https://api.github.com/users/briancroom/events{/privacy}","received_events_url":"https://api.github.com/users/briancroom/received_events","type":"User","site_admin":false},"created_at":"2016-08-19T23:25:09Z","updated_at":"2016-08-19T23:25:09Z","body":"Although the PR CI did pass, I've noticed a couple of disturbing issues from the OS X CI log. Firstly, it seems that the binaries for the functional tests are failing to launch properly, with the following error:\r\n\r\n```\r\ndyld: Library not loaded: @rpath/libswiftCore.dylib\r\n  Referenced from: /Users/buildnode/jenkins/workspace/swift-corelibs-xctest-PR-osx/Ninja-DebugAssert/xctest-macosx-x86_64/Debug/SwiftXCTest.framework/Versions/A/Frameworks/libswiftDarwin.dylib\r\n  Reason: Incompatible library version: libswiftDarwin.dylib requires version 1.0.0 or later, but libswiftCore.dylib provides version 0.0.0\r\n```\r\n\r\nSecondly, the CI is indicating a pass even though there are failing tests."}}
{"actor":{"display_login":"briancroom"}}