{"action":"created","issue":{"url":"https://api.github.com/repos/scrogson/oauth2/issues/52","repository_url":"https://api.github.com/repos/scrogson/oauth2","labels_url":"https://api.github.com/repos/scrogson/oauth2/issues/52/labels{/name}","comments_url":"https://api.github.com/repos/scrogson/oauth2/issues/52/comments","events_url":"https://api.github.com/repos/scrogson/oauth2/issues/52/events","html_url":"https://github.com/scrogson/oauth2/pull/52","id":146701565,"number":52,"title":"Major refactor and breaking changes","user":{"login":"scrogson","id":53274,"avatar_url":"https://avatars.githubusercontent.com/u/53274?v=3","gravatar_id":"","url":"https://api.github.com/users/scrogson","html_url":"https://github.com/scrogson","followers_url":"https://api.github.com/users/scrogson/followers","following_url":"https://api.github.com/users/scrogson/following{/other_user}","gists_url":"https://api.github.com/users/scrogson/gists{/gist_id}","starred_url":"https://api.github.com/users/scrogson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrogson/subscriptions","organizations_url":"https://api.github.com/users/scrogson/orgs","repos_url":"https://api.github.com/users/scrogson/repos","events_url":"https://api.github.com/users/scrogson/events{/privacy}","received_events_url":"https://api.github.com/users/scrogson/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/scrogson/oauth2/labels/rfc","name":"rfc","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-07T18:05:00Z","updated_at":"2016-04-07T21:03:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scrogson/oauth2/pulls/52","html_url":"https://github.com/scrogson/oauth2/pull/52","diff_url":"https://github.com/scrogson/oauth2/pull/52.diff","patch_url":"https://github.com/scrogson/oauth2/pull/52.patch"},"body":"This PR aims to grossly simplify the API and remove unnecessary dependencies.\r\n\r\nAll request functions like `get`, `post`, etc, have been moved to\r\nthe `OAuth2.Client` module.\r\n\r\nThe `%OAuth2.AccessToken{}` struct is now nested inside the `%OAuth2.Client{}`\r\nstruct under the `:token` key. This used to be in the reverse and I found it to be clumsy to update the client through the token.\r\n\r\nWhen you use `OAuth2.Client.get_token`, it will now return the `%OAuth2.Client{}`\r\nstruct with the token added.\r\n\r\n#### Removed dependencies \r\n\r\n- `Poison` (only used in test)\r\n- `HTTPoison` (just using `hackney` directly)\r\n- `mimetype_parser` no longer needed.\r\n\r\nI will work on updating the documentation and a thorough migration guide in the\r\nCHANGELOG before merging.\r\n\r\n\r\n- [ ] Update README\r\n- [ ] Update Documentation\r\n- [ ] Add a migration guide in the CHANGELOG\r\n\r\nFeedback is much appreciated!"},"comment":{"url":"https://api.github.com/repos/scrogson/oauth2/issues/comments/207087361","html_url":"https://github.com/scrogson/oauth2/pull/52#issuecomment-207087361","issue_url":"https://api.github.com/repos/scrogson/oauth2/issues/52","id":207087361,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-04-07T21:03:40Z","updated_at":"2016-04-07T21:03:40Z","body":"\n[![Coverage Status](https://coveralls.io/builds/5705888/badge)](https://coveralls.io/builds/5705888)\n\nCoverage increased (+1.01%) to 90.625% when pulling **cf21ddbdf9f646e7ae894ec6a3cacf3b5b7bb0b1 on refactor** into **7cc23d42fe2c388d20d71e04a9440ee572c0990c on master**.\n"}}