{"action":"created","comment":{"url":"https://api.github.com/repos/geotools/geotools/pulls/comments/88592256","pull_request_review_id":9162084,"id":88592256,"diff_hunk":"@@ -618,6 +623,45 @@ public void encode(Object object, QName name, OutputStream out)\n         }\n     }\n \n+    /**\n+     * Helper method that checks if the complex feature we want to encode maps\n+     * to a complex type that respects the GML object-property model.\n+     */\n+    private boolean isNonStrippedNestedElement(Object next, XSDElementDeclaration element) {","path":"modules/extension/xsd/xsd-core/src/main/java/org/geotools/xml/Encoder.java","position":27,"original_position":27,"commit_id":"a77e28af6e8ae8af1a8ed04bdd0e088a97676994","original_commit_id":"a77e28af6e8ae8af1a8ed04bdd0e088a97676994","user":{"login":"bencaradocdavies","id":1900866,"avatar_url":"https://avatars.githubusercontent.com/u/1900866?v=3","gravatar_id":"","url":"https://api.github.com/users/bencaradocdavies","html_url":"https://github.com/bencaradocdavies","followers_url":"https://api.github.com/users/bencaradocdavies/followers","following_url":"https://api.github.com/users/bencaradocdavies/following{/other_user}","gists_url":"https://api.github.com/users/bencaradocdavies/gists{/gist_id}","starred_url":"https://api.github.com/users/bencaradocdavies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bencaradocdavies/subscriptions","organizations_url":"https://api.github.com/users/bencaradocdavies/orgs","repos_url":"https://api.github.com/users/bencaradocdavies/repos","events_url":"https://api.github.com/users/bencaradocdavies/events{/privacy}","received_events_url":"https://api.github.com/users/bencaradocdavies/received_events","type":"User","site_admin":false},"body":"Method name should be ```isNonStripedNestedElement``` (i.e. striped not stripped).","created_at":"2016-11-18T02:53:04Z","updated_at":"2016-11-18T02:53:04Z","html_url":"https://github.com/geotools/geotools/pull/1386#discussion_r88592256","pull_request_url":"https://api.github.com/repos/geotools/geotools/pulls/1386","_links":{"self":{"href":"https://api.github.com/repos/geotools/geotools/pulls/comments/88592256"},"html":{"href":"https://github.com/geotools/geotools/pull/1386#discussion_r88592256"},"pull_request":{"href":"https://api.github.com/repos/geotools/geotools/pulls/1386"}}},"pull_request":{"url":"https://api.github.com/repos/geotools/geotools/pulls/1386","id":94151890,"html_url":"https://github.com/geotools/geotools/pull/1386","diff_url":"https://github.com/geotools/geotools/pull/1386.diff","patch_url":"https://github.com/geotools/geotools/pull/1386.patch","issue_url":"https://api.github.com/repos/geotools/geotools/issues/1386","number":1386,"state":"open","locked":false,"title":"[GEOT-5575] Relax the XML encoder to be able to encode nested complex types that don't respect the GML object-property model","user":{"login":"nmco","id":1590542,"avatar_url":"https://avatars.githubusercontent.com/u/1590542?v=3","gravatar_id":"","url":"https://api.github.com/users/nmco","html_url":"https://github.com/nmco","followers_url":"https://api.github.com/users/nmco/followers","following_url":"https://api.github.com/users/nmco/following{/other_user}","gists_url":"https://api.github.com/users/nmco/gists{/gist_id}","starred_url":"https://api.github.com/users/nmco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmco/subscriptions","organizations_url":"https://api.github.com/users/nmco/orgs","repos_url":"https://api.github.com/users/nmco/repos","events_url":"https://api.github.com/users/nmco/events{/privacy}","received_events_url":"https://api.github.com/users/nmco/received_events","type":"User","site_admin":false},"body":"Associated issue:\r\nhttps://osgeo-org.atlassian.net/browse/GEOT-5575\r\n\r\nGeoServer side pull requests that add app-schema test case with complex features:\r\nhttps://github.com/geoserver/geoserver/pull/1976","created_at":"2016-11-17T11:45:50Z","updated_at":"2016-11-18T02:53:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92a01df722db88eed48f24b31b1598f71055e0aa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/geotools/geotools/pulls/1386/commits","review_comments_url":"https://api.github.com/repos/geotools/geotools/pulls/1386/comments","review_comment_url":"https://api.github.com/repos/geotools/geotools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geotools/geotools/issues/1386/comments","statuses_url":"https://api.github.com/repos/geotools/geotools/statuses/a77e28af6e8ae8af1a8ed04bdd0e088a97676994","head":{"label":"nmco:relax-gml-encoder","ref":"relax-gml-encoder","sha":"a77e28af6e8ae8af1a8ed04bdd0e088a97676994","user":{"login":"nmco","id":1590542,"avatar_url":"https://avatars.githubusercontent.com/u/1590542?v=3","gravatar_id":"","url":"https://api.github.com/users/nmco","html_url":"https://github.com/nmco","followers_url":"https://api.github.com/users/nmco/followers","following_url":"https://api.github.com/users/nmco/following{/other_user}","gists_url":"https://api.github.com/users/nmco/gists{/gist_id}","starred_url":"https://api.github.com/users/nmco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmco/subscriptions","organizations_url":"https://api.github.com/users/nmco/orgs","repos_url":"https://api.github.com/users/nmco/repos","events_url":"https://api.github.com/users/nmco/events{/privacy}","received_events_url":"https://api.github.com/users/nmco/received_events","type":"User","site_admin":false},"repo":{"id":17440699,"name":"geotools","full_name":"nmco/geotools","owner":{"login":"nmco","id":1590542,"avatar_url":"https://avatars.githubusercontent.com/u/1590542?v=3","gravatar_id":"","url":"https://api.github.com/users/nmco","html_url":"https://github.com/nmco","followers_url":"https://api.github.com/users/nmco/followers","following_url":"https://api.github.com/users/nmco/following{/other_user}","gists_url":"https://api.github.com/users/nmco/gists{/gist_id}","starred_url":"https://api.github.com/users/nmco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmco/subscriptions","organizations_url":"https://api.github.com/users/nmco/orgs","repos_url":"https://api.github.com/users/nmco/repos","events_url":"https://api.github.com/users/nmco/events{/privacy}","received_events_url":"https://api.github.com/users/nmco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nmco/geotools","description":"Official GeoTools repository","fork":true,"url":"https://api.github.com/repos/nmco/geotools","forks_url":"https://api.github.com/repos/nmco/geotools/forks","keys_url":"https://api.github.com/repos/nmco/geotools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nmco/geotools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nmco/geotools/teams","hooks_url":"https://api.github.com/repos/nmco/geotools/hooks","issue_events_url":"https://api.github.com/repos/nmco/geotools/issues/events{/number}","events_url":"https://api.github.com/repos/nmco/geotools/events","assignees_url":"https://api.github.com/repos/nmco/geotools/assignees{/user}","branches_url":"https://api.github.com/repos/nmco/geotools/branches{/branch}","tags_url":"https://api.github.com/repos/nmco/geotools/tags","blobs_url":"https://api.github.com/repos/nmco/geotools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nmco/geotools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nmco/geotools/git/refs{/sha}","trees_url":"https://api.github.com/repos/nmco/geotools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nmco/geotools/statuses/{sha}","languages_url":"https://api.github.com/repos/nmco/geotools/languages","stargazers_url":"https://api.github.com/repos/nmco/geotools/stargazers","contributors_url":"https://api.github.com/repos/nmco/geotools/contributors","subscribers_url":"https://api.github.com/repos/nmco/geotools/subscribers","subscription_url":"https://api.github.com/repos/nmco/geotools/subscription","commits_url":"https://api.github.com/repos/nmco/geotools/commits{/sha}","git_commits_url":"https://api.github.com/repos/nmco/geotools/git/commits{/sha}","comments_url":"https://api.github.com/repos/nmco/geotools/comments{/number}","issue_comment_url":"https://api.github.com/repos/nmco/geotools/issues/comments{/number}","contents_url":"https://api.github.com/repos/nmco/geotools/contents/{+path}","compare_url":"https://api.github.com/repos/nmco/geotools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nmco/geotools/merges","archive_url":"https://api.github.com/repos/nmco/geotools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nmco/geotools/downloads","issues_url":"https://api.github.com/repos/nmco/geotools/issues{/number}","pulls_url":"https://api.github.com/repos/nmco/geotools/pulls{/number}","milestones_url":"https://api.github.com/repos/nmco/geotools/milestones{/number}","notifications_url":"https://api.github.com/repos/nmco/geotools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nmco/geotools/labels{/name}","releases_url":"https://api.github.com/repos/nmco/geotools/releases{/id}","deployments_url":"https://api.github.com/repos/nmco/geotools/deployments","created_at":"2014-03-05T12:55:46Z","updated_at":"2016-01-15T12:03:46Z","pushed_at":"2016-11-17T23:58:14Z","git_url":"git://github.com/nmco/geotools.git","ssh_url":"git@github.com:nmco/geotools.git","clone_url":"https://github.com/nmco/geotools.git","svn_url":"https://github.com/nmco/geotools","homepage":"http://geotools.org","size":131854,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"geotools:master","ref":"master","sha":"1573e8b8b8605e0b47732a58faab48c199d52ce5","user":{"login":"geotools","id":1187031,"avatar_url":"https://avatars.githubusercontent.com/u/1187031?v=3","gravatar_id":"","url":"https://api.github.com/users/geotools","html_url":"https://github.com/geotools","followers_url":"https://api.github.com/users/geotools/followers","following_url":"https://api.github.com/users/geotools/following{/other_user}","gists_url":"https://api.github.com/users/geotools/gists{/gist_id}","starred_url":"https://api.github.com/users/geotools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geotools/subscriptions","organizations_url":"https://api.github.com/users/geotools/orgs","repos_url":"https://api.github.com/users/geotools/repos","events_url":"https://api.github.com/users/geotools/events{/privacy}","received_events_url":"https://api.github.com/users/geotools/received_events","type":"Organization","site_admin":false},"repo":{"id":2752522,"name":"geotools","full_name":"geotools/geotools","owner":{"login":"geotools","id":1187031,"avatar_url":"https://avatars.githubusercontent.com/u/1187031?v=3","gravatar_id":"","url":"https://api.github.com/users/geotools","html_url":"https://github.com/geotools","followers_url":"https://api.github.com/users/geotools/followers","following_url":"https://api.github.com/users/geotools/following{/other_user}","gists_url":"https://api.github.com/users/geotools/gists{/gist_id}","starred_url":"https://api.github.com/users/geotools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geotools/subscriptions","organizations_url":"https://api.github.com/users/geotools/orgs","repos_url":"https://api.github.com/users/geotools/repos","events_url":"https://api.github.com/users/geotools/events{/privacy}","received_events_url":"https://api.github.com/users/geotools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geotools/geotools","description":"Official GeoTools repository","fork":false,"url":"https://api.github.com/repos/geotools/geotools","forks_url":"https://api.github.com/repos/geotools/geotools/forks","keys_url":"https://api.github.com/repos/geotools/geotools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geotools/geotools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geotools/geotools/teams","hooks_url":"https://api.github.com/repos/geotools/geotools/hooks","issue_events_url":"https://api.github.com/repos/geotools/geotools/issues/events{/number}","events_url":"https://api.github.com/repos/geotools/geotools/events","assignees_url":"https://api.github.com/repos/geotools/geotools/assignees{/user}","branches_url":"https://api.github.com/repos/geotools/geotools/branches{/branch}","tags_url":"https://api.github.com/repos/geotools/geotools/tags","blobs_url":"https://api.github.com/repos/geotools/geotools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geotools/geotools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geotools/geotools/git/refs{/sha}","trees_url":"https://api.github.com/repos/geotools/geotools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geotools/geotools/statuses/{sha}","languages_url":"https://api.github.com/repos/geotools/geotools/languages","stargazers_url":"https://api.github.com/repos/geotools/geotools/stargazers","contributors_url":"https://api.github.com/repos/geotools/geotools/contributors","subscribers_url":"https://api.github.com/repos/geotools/geotools/subscribers","subscription_url":"https://api.github.com/repos/geotools/geotools/subscription","commits_url":"https://api.github.com/repos/geotools/geotools/commits{/sha}","git_commits_url":"https://api.github.com/repos/geotools/geotools/git/commits{/sha}","comments_url":"https://api.github.com/repos/geotools/geotools/comments{/number}","issue_comment_url":"https://api.github.com/repos/geotools/geotools/issues/comments{/number}","contents_url":"https://api.github.com/repos/geotools/geotools/contents/{+path}","compare_url":"https://api.github.com/repos/geotools/geotools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geotools/geotools/merges","archive_url":"https://api.github.com/repos/geotools/geotools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geotools/geotools/downloads","issues_url":"https://api.github.com/repos/geotools/geotools/issues{/number}","pulls_url":"https://api.github.com/repos/geotools/geotools/pulls{/number}","milestones_url":"https://api.github.com/repos/geotools/geotools/milestones{/number}","notifications_url":"https://api.github.com/repos/geotools/geotools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geotools/geotools/labels{/name}","releases_url":"https://api.github.com/repos/geotools/geotools/releases{/id}","deployments_url":"https://api.github.com/repos/geotools/geotools/deployments","created_at":"2011-11-10T23:22:12Z","updated_at":"2016-11-04T10:48:37Z","pushed_at":"2016-11-17T23:09:50Z","git_url":"git://github.com/geotools/geotools.git","ssh_url":"git@github.com:geotools/geotools.git","clone_url":"https://github.com/geotools/geotools.git","svn_url":"https://github.com/geotools/geotools","homepage":"http://geotools.org","size":143239,"stargazers_count":341,"watchers_count":341,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":472,"mirror_url":null,"open_issues_count":15,"forks":472,"open_issues":15,"watchers":341,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geotools/geotools/pulls/1386"},"html":{"href":"https://github.com/geotools/geotools/pull/1386"},"issue":{"href":"https://api.github.com/repos/geotools/geotools/issues/1386"},"comments":{"href":"https://api.github.com/repos/geotools/geotools/issues/1386/comments"},"review_comments":{"href":"https://api.github.com/repos/geotools/geotools/pulls/1386/comments"},"review_comment":{"href":"https://api.github.com/repos/geotools/geotools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geotools/geotools/pulls/1386/commits"},"statuses":{"href":"https://api.github.com/repos/geotools/geotools/statuses/a77e28af6e8ae8af1a8ed04bdd0e088a97676994"}}}}
{"actor":{"display_login":"bencaradocdavies"}}