{"action":"created","issue":{"url":"https://api.github.com/repos/shazow/urllib3/issues/876","repository_url":"https://api.github.com/repos/shazow/urllib3","labels_url":"https://api.github.com/repos/shazow/urllib3/issues/876/labels{/name}","comments_url":"https://api.github.com/repos/shazow/urllib3/issues/876/comments","events_url":"https://api.github.com/repos/shazow/urllib3/issues/876/events","html_url":"https://github.com/shazow/urllib3/pull/876","id":156515888,"number":876,"title":"``PoolManager`` now references the gobal ``key_fn_by_scheme`` dictionary","user":{"login":"jeremycline","id":1977525,"avatar_url":"https://avatars.githubusercontent.com/u/1977525?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremycline","html_url":"https://github.com/jeremycline","followers_url":"https://api.github.com/users/jeremycline/followers","following_url":"https://api.github.com/users/jeremycline/following{/other_user}","gists_url":"https://api.github.com/users/jeremycline/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremycline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremycline/subscriptions","organizations_url":"https://api.github.com/users/jeremycline/orgs","repos_url":"https://api.github.com/users/jeremycline/repos","events_url":"https://api.github.com/users/jeremycline/events{/privacy}","received_events_url":"https://api.github.com/users/jeremycline/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-24T14:02:21Z","updated_at":"2016-05-24T14:09:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/shazow/urllib3/pulls/876","html_url":"https://github.com/shazow/urllib3/pull/876","diff_url":"https://github.com/shazow/urllib3/pull/876.diff","patch_url":"https://github.com/shazow/urllib3/pull/876.patch"},"body":"Initially for #830, the ``key_fn_by_scheme`` was copied for each\r\nPoolManager instance. This is inconcistent with the\r\n``pool_classes_by_scheme`` instance variable, which is a reference to\r\nthe global dictionary. This commit makes the two consistent by making\r\nthe ``key_fn_by_scheme`` instance variable a reference to the global\r\ndictionary."},"comment":{"url":"https://api.github.com/repos/shazow/urllib3/issues/comments/221282563","html_url":"https://github.com/shazow/urllib3/pull/876#issuecomment-221282563","issue_url":"https://api.github.com/repos/shazow/urllib3/issues/876","id":221282563,"user":{"login":"jeremycline","id":1977525,"avatar_url":"https://avatars.githubusercontent.com/u/1977525?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremycline","html_url":"https://github.com/jeremycline","followers_url":"https://api.github.com/users/jeremycline/followers","following_url":"https://api.github.com/users/jeremycline/following{/other_user}","gists_url":"https://api.github.com/users/jeremycline/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremycline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremycline/subscriptions","organizations_url":"https://api.github.com/users/jeremycline/orgs","repos_url":"https://api.github.com/users/jeremycline/repos","events_url":"https://api.github.com/users/jeremycline/events{/privacy}","received_events_url":"https://api.github.com/users/jeremycline/received_events","type":"User","site_admin":false},"created_at":"2016-05-24T14:09:11Z","updated_at":"2016-05-24T14:09:11Z","body":"My interpretation of https://github.com/shazow/urllib3/pull/828#issuecomment-221049208 was that it would be nice for things to be different, but it might be a breaking change so waiting for a v2.0 would be better."}}
{"actor":{"display_login":"jeremycline"}}