{"action":"created","issue":{"url":"https://api.github.com/repos/serilog/serilog/issues/656","repository_url":"https://api.github.com/repos/serilog/serilog","labels_url":"https://api.github.com/repos/serilog/serilog/issues/656/labels{/name}","comments_url":"https://api.github.com/repos/serilog/serilog/issues/656/comments","events_url":"https://api.github.com/repos/serilog/serilog/issues/656/events","html_url":"https://github.com/serilog/serilog/pull/656","id":131269428,"number":656,"title":"Adding buffered boolean param to FileSink and RollingFileSink","user":{"login":"Pvlerick","id":4704411,"avatar_url":"https://avatars.githubusercontent.com/u/4704411?v=3","gravatar_id":"","url":"https://api.github.com/users/Pvlerick","html_url":"https://github.com/Pvlerick","followers_url":"https://api.github.com/users/Pvlerick/followers","following_url":"https://api.github.com/users/Pvlerick/following{/other_user}","gists_url":"https://api.github.com/users/Pvlerick/gists{/gist_id}","starred_url":"https://api.github.com/users/Pvlerick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pvlerick/subscriptions","organizations_url":"https://api.github.com/users/Pvlerick/orgs","repos_url":"https://api.github.com/users/Pvlerick/repos","events_url":"https://api.github.com/users/Pvlerick/events{/privacy}","received_events_url":"https://api.github.com/users/Pvlerick/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-02-04T07:38:27Z","updated_at":"2016-02-10T07:21:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/serilog/serilog/pulls/656","html_url":"https://github.com/serilog/serilog/pull/656","diff_url":"https://github.com/serilog/serilog/pull/656.diff","patch_url":"https://github.com/serilog/serilog/pull/656.patch"},"body":"This is a rough draft implementation to address #650. I open this PR so we have code to discuss; this code is definitely not ready :wink: \r\n\r\nIn all honesty, I don't like the boolean parameter too much. Very often boolean parameters are passed around to mean \"behave in this way if true, in that way if false\"; I think if two behaviours are distinct enough they should have they own classes (```BufferedFileSink```?).\r\n\r\nThe second point is the task that is started to process what is put in the queue. I don't like it too much either and I'm wondering if there would be a way to use the explicit implementation of ```IProducerConsumerCollection<T>```. I didn't look into this too much so I will explore, but maybe someone already has an idea.\r\n\r\nLet me know what you think.\r\n"},"comment":{"url":"https://api.github.com/repos/serilog/serilog/issues/comments/182235621","html_url":"https://github.com/serilog/serilog/pull/656#issuecomment-182235621","issue_url":"https://api.github.com/repos/serilog/serilog/issues/656","id":182235621,"user":{"login":"Pvlerick","id":4704411,"avatar_url":"https://avatars.githubusercontent.com/u/4704411?v=3","gravatar_id":"","url":"https://api.github.com/users/Pvlerick","html_url":"https://github.com/Pvlerick","followers_url":"https://api.github.com/users/Pvlerick/followers","following_url":"https://api.github.com/users/Pvlerick/following{/other_user}","gists_url":"https://api.github.com/users/Pvlerick/gists{/gist_id}","starred_url":"https://api.github.com/users/Pvlerick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pvlerick/subscriptions","organizations_url":"https://api.github.com/users/Pvlerick/orgs","repos_url":"https://api.github.com/users/Pvlerick/repos","events_url":"https://api.github.com/users/Pvlerick/events{/privacy}","received_events_url":"https://api.github.com/users/Pvlerick/received_events","type":"User","site_admin":false},"created_at":"2016-02-10T07:21:30Z","updated_at":"2016-02-10T07:21:30Z","body":"@nblumhardt makes sense. I updated the PR."}}