{"action":"created","issue":{"url":"https://api.github.com/repos/arduino-libraries/WiFi101/issues/58","repository_url":"https://api.github.com/repos/arduino-libraries/WiFi101","labels_url":"https://api.github.com/repos/arduino-libraries/WiFi101/issues/58/labels{/name}","comments_url":"https://api.github.com/repos/arduino-libraries/WiFi101/issues/58/comments","events_url":"https://api.github.com/repos/arduino-libraries/WiFi101/issues/58/events","html_url":"https://github.com/arduino-libraries/WiFi101/pull/58","id":147510439,"number":58,"title":"Add setPins API to override default WINC1500 pins","user":{"login":"sandeepmistry","id":1163840,"avatar_url":"https://avatars.githubusercontent.com/u/1163840?v=3","gravatar_id":"","url":"https://api.github.com/users/sandeepmistry","html_url":"https://github.com/sandeepmistry","followers_url":"https://api.github.com/users/sandeepmistry/followers","following_url":"https://api.github.com/users/sandeepmistry/following{/other_user}","gists_url":"https://api.github.com/users/sandeepmistry/gists{/gist_id}","starred_url":"https://api.github.com/users/sandeepmistry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandeepmistry/subscriptions","organizations_url":"https://api.github.com/users/sandeepmistry/orgs","repos_url":"https://api.github.com/users/sandeepmistry/repos","events_url":"https://api.github.com/users/sandeepmistry/events{/privacy}","received_events_url":"https://api.github.com/users/sandeepmistry/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/arduino-libraries/WiFi101/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/arduino-libraries/WiFi101/labels/waiting%20for%20feedback","name":"waiting for feedback","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-04-11T18:17:02Z","updated_at":"2016-07-12T01:02:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/arduino-libraries/WiFi101/pulls/58","html_url":"https://github.com/arduino-libraries/WiFi101/pull/58","diff_url":"https://github.com/arduino-libraries/WiFi101/pull/58.diff","patch_url":"https://github.com/arduino-libraries/WiFi101/pull/58.patch"},"body":"A proposal to resolve #57.\r\n\r\nI've added a ``WiFiClass::setPins(int8_t cs, int8_t irq, int8_t rst, int8_t en)`` API. This API must be called before any other WiFi APIs to take effect.\r\n\r\nIt currently uses 4 bytes more RAM, I've opted to store the pins as ```int8_t``` to save a few bytes of RAM on AVR. No issues changing to using ```int``` if that would be better.\r\n\r\nHere's a size comparison ```ConnectWithWPA``` example sketch (sizes in bytes):\r\n\r\n| Board | Before | After | Difference |\r\n| -------- | --------- | ------ | -------------- |\r\n| Uno | 21,470 | 21,528 | 58 |\r\n| Zero | 19,820 | 19,916 | 96 |\r\n\r\ncc/ @ladyada @cmaglie @facchinm"},"comment":{"url":"https://api.github.com/repos/arduino-libraries/WiFi101/issues/comments/231909826","html_url":"https://github.com/arduino-libraries/WiFi101/pull/58#issuecomment-231909826","issue_url":"https://api.github.com/repos/arduino-libraries/WiFi101/issues/58","id":231909826,"user":{"login":"trlafleur","id":4571691,"avatar_url":"https://avatars.githubusercontent.com/u/4571691?v=3","gravatar_id":"","url":"https://api.github.com/users/trlafleur","html_url":"https://github.com/trlafleur","followers_url":"https://api.github.com/users/trlafleur/followers","following_url":"https://api.github.com/users/trlafleur/following{/other_user}","gists_url":"https://api.github.com/users/trlafleur/gists{/gist_id}","starred_url":"https://api.github.com/users/trlafleur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trlafleur/subscriptions","organizations_url":"https://api.github.com/users/trlafleur/orgs","repos_url":"https://api.github.com/users/trlafleur/repos","events_url":"https://api.github.com/users/trlafleur/events{/privacy}","received_events_url":"https://api.github.com/users/trlafleur/received_events","type":"User","site_admin":false},"created_at":"2016-07-12T01:02:45Z","updated_at":"2016-07-12T01:02:45Z","body":"did a test with a Feather M0 board with a WINC1500, looks to work just\nfine....\n\nOn Mon, Jul 11, 2016 at 2:46 PM, Sandeep Mistry <notifications@github.com>\nwrote:\n\n> Hi @trlafleur <https://github.com/trlafleur>,\n>\n> Have you had a chance to try this change out? If yes, please let us know\n> how your testing went and which hardware you were using.\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/arduino-libraries/WiFi101/pull/58#issuecomment-231875513>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe/AEXCKxxbuIzvK8-FZTacmuCzLBAPmOckks5qUrmagaJpZM4IEq7X>\n> .\n>\n\n\n\n-- \n\n~~ _/) ~~~~ _/) ~~~~ _/) ~~~~ _/) ~~\n\nTom Lafleur\n"}}
{"actor":{"display_login":"trlafleur"}}