{"action":"created","comment":{"url":"https://api.github.com/repos/softwerkskammer/Agora/pulls/comments/90279767","pull_request_review_id":10801363,"id":90279767,"diff_hunk":"@@ -67,10 +67,11 @@ module.exports = function (grunt) {\n       'softwerkskammer/build/stylesheets/less/agora.less'\n     ]\n   };\n+  const integrationTestCoverageDataFolder =  'softwerkskammer/coverageIntegration';\n   grunt.initConfig({\n     clean: {\n       build: ['softwerkskammer/build', 'softwerkskammer/frontendtests/fixtures/*.html'],\n-      coverage: ['softwerkskammer/coverage', 'softwerkskammer/coverageWithDB', 'softwerkskammer/karma-coverage'],\n+      coverage: ['softwerkskammer/coverage', integrationTestCoverageDataFolder, 'softwerkskammer/karma-coverage'],","path":"Gruntfile.js","position":9,"original_position":9,"commit_id":"cdbf7808866f20172fe842c4dbc74ba1a2ad9cf7","original_commit_id":"cdbf7808866f20172fe842c4dbc74ba1a2ad9cf7","user":{"login":"NicoleRauch","id":436499,"avatar_url":"https://avatars.githubusercontent.com/u/436499?v=3","gravatar_id":"","url":"https://api.github.com/users/NicoleRauch","html_url":"https://github.com/NicoleRauch","followers_url":"https://api.github.com/users/NicoleRauch/followers","following_url":"https://api.github.com/users/NicoleRauch/following{/other_user}","gists_url":"https://api.github.com/users/NicoleRauch/gists{/gist_id}","starred_url":"https://api.github.com/users/NicoleRauch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicoleRauch/subscriptions","organizations_url":"https://api.github.com/users/NicoleRauch/orgs","repos_url":"https://api.github.com/users/NicoleRauch/repos","events_url":"https://api.github.com/users/NicoleRauch/events{/privacy}","received_events_url":"https://api.github.com/users/NicoleRauch/received_events","type":"User","site_admin":false},"body":"Wohl kaum ohne Unterverzeichnis hier?","created_at":"2016-11-30T17:11:45Z","updated_at":"2016-11-30T17:11:45Z","html_url":"https://github.com/softwerkskammer/Agora/pull/1190#discussion_r90279767","pull_request_url":"https://api.github.com/repos/softwerkskammer/Agora/pulls/1190","_links":{"self":{"href":"https://api.github.com/repos/softwerkskammer/Agora/pulls/comments/90279767"},"html":{"href":"https://github.com/softwerkskammer/Agora/pull/1190#discussion_r90279767"},"pull_request":{"href":"https://api.github.com/repos/softwerkskammer/Agora/pulls/1190"}}},"pull_request":{"url":"https://api.github.com/repos/softwerkskammer/Agora/pulls/1190","id":95927154,"html_url":"https://github.com/softwerkskammer/Agora/pull/1190","diff_url":"https://github.com/softwerkskammer/Agora/pull/1190.diff","patch_url":"https://github.com/softwerkskammer/Agora/pull/1190.patch","issue_url":"https://api.github.com/repos/softwerkskammer/Agora/issues/1190","number":1190,"state":"open","locked":false,"title":"Separate unit and integration tests","user":{"login":"c089","id":327199,"avatar_url":"https://avatars.githubusercontent.com/u/327199?v=3","gravatar_id":"","url":"https://api.github.com/users/c089","html_url":"https://github.com/c089","followers_url":"https://api.github.com/users/c089/followers","following_url":"https://api.github.com/users/c089/following{/other_user}","gists_url":"https://api.github.com/users/c089/gists{/gist_id}","starred_url":"https://api.github.com/users/c089/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c089/subscriptions","organizations_url":"https://api.github.com/users/c089/orgs","repos_url":"https://api.github.com/users/c089/repos","events_url":"https://api.github.com/users/c089/events{/privacy}","received_events_url":"https://api.github.com/users/c089/received_events","type":"User","site_admin":false},"body":"This PR:\r\n\r\n* [X] renames `testWithDB` to a more generic `testIntegration` folder which should hold all tests that are not true, independent unit tests\r\n* [X] merges `testApp` into `testIntegration` to reduce duplication in grunt configuration without obvious benefit\r\n* [X] moves all integrated tests from `test` to `testIntegration`\r\n* [X] refactors some tests to trust the contract established by existing integration tests, making them true unit tests\r\n* [ ] reduces the timeout for unit tests from 6 seconds to a reasonable amount\r\n\r\nFuture Work that I consider out of scope for this PR: \r\n* refactor some services to adhere to the SRP (e.g. extract file system concerns from members service) so they can be unit tested\r\n* improve integration tests for image processing by throwing a friendlier error (\"you need to install imagemagick\" instead of a \"ENOENT\")","created_at":"2016-11-30T16:37:54Z","updated_at":"2016-11-30T17:11:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0475b3e9cd9cf00c88ddef2051bcba083b3e65ac","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/softwerkskammer/Agora/pulls/1190/commits","review_comments_url":"https://api.github.com/repos/softwerkskammer/Agora/pulls/1190/comments","review_comment_url":"https://api.github.com/repos/softwerkskammer/Agora/pulls/comments{/number}","comments_url":"https://api.github.com/repos/softwerkskammer/Agora/issues/1190/comments","statuses_url":"https://api.github.com/repos/softwerkskammer/Agora/statuses/cdbf7808866f20172fe842c4dbc74ba1a2ad9cf7","head":{"label":"c089:separate-unit-and-integration-tests","ref":"separate-unit-and-integration-tests","sha":"cdbf7808866f20172fe842c4dbc74ba1a2ad9cf7","user":{"login":"c089","id":327199,"avatar_url":"https://avatars.githubusercontent.com/u/327199?v=3","gravatar_id":"","url":"https://api.github.com/users/c089","html_url":"https://github.com/c089","followers_url":"https://api.github.com/users/c089/followers","following_url":"https://api.github.com/users/c089/following{/other_user}","gists_url":"https://api.github.com/users/c089/gists{/gist_id}","starred_url":"https://api.github.com/users/c089/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c089/subscriptions","organizations_url":"https://api.github.com/users/c089/orgs","repos_url":"https://api.github.com/users/c089/repos","events_url":"https://api.github.com/users/c089/events{/privacy}","received_events_url":"https://api.github.com/users/c089/received_events","type":"User","site_admin":false},"repo":{"id":11848963,"name":"agora","full_name":"c089/agora","owner":{"login":"c089","id":327199,"avatar_url":"https://avatars.githubusercontent.com/u/327199?v=3","gravatar_id":"","url":"https://api.github.com/users/c089","html_url":"https://github.com/c089","followers_url":"https://api.github.com/users/c089/followers","following_url":"https://api.github.com/users/c089/following{/other_user}","gists_url":"https://api.github.com/users/c089/gists{/gist_id}","starred_url":"https://api.github.com/users/c089/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c089/subscriptions","organizations_url":"https://api.github.com/users/c089/orgs","repos_url":"https://api.github.com/users/c089/repos","events_url":"https://api.github.com/users/c089/events{/privacy}","received_events_url":"https://api.github.com/users/c089/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/c089/agora","description":"Die Software für die Plattform der Softwerkskammer","fork":true,"url":"https://api.github.com/repos/c089/agora","forks_url":"https://api.github.com/repos/c089/agora/forks","keys_url":"https://api.github.com/repos/c089/agora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/c089/agora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/c089/agora/teams","hooks_url":"https://api.github.com/repos/c089/agora/hooks","issue_events_url":"https://api.github.com/repos/c089/agora/issues/events{/number}","events_url":"https://api.github.com/repos/c089/agora/events","assignees_url":"https://api.github.com/repos/c089/agora/assignees{/user}","branches_url":"https://api.github.com/repos/c089/agora/branches{/branch}","tags_url":"https://api.github.com/repos/c089/agora/tags","blobs_url":"https://api.github.com/repos/c089/agora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/c089/agora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/c089/agora/git/refs{/sha}","trees_url":"https://api.github.com/repos/c089/agora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/c089/agora/statuses/{sha}","languages_url":"https://api.github.com/repos/c089/agora/languages","stargazers_url":"https://api.github.com/repos/c089/agora/stargazers","contributors_url":"https://api.github.com/repos/c089/agora/contributors","subscribers_url":"https://api.github.com/repos/c089/agora/subscribers","subscription_url":"https://api.github.com/repos/c089/agora/subscription","commits_url":"https://api.github.com/repos/c089/agora/commits{/sha}","git_commits_url":"https://api.github.com/repos/c089/agora/git/commits{/sha}","comments_url":"https://api.github.com/repos/c089/agora/comments{/number}","issue_comment_url":"https://api.github.com/repos/c089/agora/issues/comments{/number}","contents_url":"https://api.github.com/repos/c089/agora/contents/{+path}","compare_url":"https://api.github.com/repos/c089/agora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/c089/agora/merges","archive_url":"https://api.github.com/repos/c089/agora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/c089/agora/downloads","issues_url":"https://api.github.com/repos/c089/agora/issues{/number}","pulls_url":"https://api.github.com/repos/c089/agora/pulls{/number}","milestones_url":"https://api.github.com/repos/c089/agora/milestones{/number}","notifications_url":"https://api.github.com/repos/c089/agora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/c089/agora/labels{/name}","releases_url":"https://api.github.com/repos/c089/agora/releases{/id}","deployments_url":"https://api.github.com/repos/c089/agora/deployments","created_at":"2013-08-02T17:40:37Z","updated_at":"2016-07-04T11:17:50Z","pushed_at":"2016-11-30T17:03:20Z","git_url":"git://github.com/c089/agora.git","ssh_url":"git@github.com:c089/agora.git","clone_url":"https://github.com/c089/agora.git","svn_url":"https://github.com/c089/agora","homepage":"","size":21022,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"softwerkskammer:master","ref":"master","sha":"f9db2610852a97c7b2edce712f560676f4a40cd8","user":{"login":"softwerkskammer","id":1238207,"avatar_url":"https://avatars.githubusercontent.com/u/1238207?v=3","gravatar_id":"","url":"https://api.github.com/users/softwerkskammer","html_url":"https://github.com/softwerkskammer","followers_url":"https://api.github.com/users/softwerkskammer/followers","following_url":"https://api.github.com/users/softwerkskammer/following{/other_user}","gists_url":"https://api.github.com/users/softwerkskammer/gists{/gist_id}","starred_url":"https://api.github.com/users/softwerkskammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softwerkskammer/subscriptions","organizations_url":"https://api.github.com/users/softwerkskammer/orgs","repos_url":"https://api.github.com/users/softwerkskammer/repos","events_url":"https://api.github.com/users/softwerkskammer/events{/privacy}","received_events_url":"https://api.github.com/users/softwerkskammer/received_events","type":"Organization","site_admin":false},"repo":{"id":8785436,"name":"Agora","full_name":"softwerkskammer/Agora","owner":{"login":"softwerkskammer","id":1238207,"avatar_url":"https://avatars.githubusercontent.com/u/1238207?v=3","gravatar_id":"","url":"https://api.github.com/users/softwerkskammer","html_url":"https://github.com/softwerkskammer","followers_url":"https://api.github.com/users/softwerkskammer/followers","following_url":"https://api.github.com/users/softwerkskammer/following{/other_user}","gists_url":"https://api.github.com/users/softwerkskammer/gists{/gist_id}","starred_url":"https://api.github.com/users/softwerkskammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softwerkskammer/subscriptions","organizations_url":"https://api.github.com/users/softwerkskammer/orgs","repos_url":"https://api.github.com/users/softwerkskammer/repos","events_url":"https://api.github.com/users/softwerkskammer/events{/privacy}","received_events_url":"https://api.github.com/users/softwerkskammer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/softwerkskammer/Agora","description":"Die Software für die Plattform der Softwerkskammer","fork":false,"url":"https://api.github.com/repos/softwerkskammer/Agora","forks_url":"https://api.github.com/repos/softwerkskammer/Agora/forks","keys_url":"https://api.github.com/repos/softwerkskammer/Agora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/softwerkskammer/Agora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/softwerkskammer/Agora/teams","hooks_url":"https://api.github.com/repos/softwerkskammer/Agora/hooks","issue_events_url":"https://api.github.com/repos/softwerkskammer/Agora/issues/events{/number}","events_url":"https://api.github.com/repos/softwerkskammer/Agora/events","assignees_url":"https://api.github.com/repos/softwerkskammer/Agora/assignees{/user}","branches_url":"https://api.github.com/repos/softwerkskammer/Agora/branches{/branch}","tags_url":"https://api.github.com/repos/softwerkskammer/Agora/tags","blobs_url":"https://api.github.com/repos/softwerkskammer/Agora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/softwerkskammer/Agora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/softwerkskammer/Agora/git/refs{/sha}","trees_url":"https://api.github.com/repos/softwerkskammer/Agora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/softwerkskammer/Agora/statuses/{sha}","languages_url":"https://api.github.com/repos/softwerkskammer/Agora/languages","stargazers_url":"https://api.github.com/repos/softwerkskammer/Agora/stargazers","contributors_url":"https://api.github.com/repos/softwerkskammer/Agora/contributors","subscribers_url":"https://api.github.com/repos/softwerkskammer/Agora/subscribers","subscription_url":"https://api.github.com/repos/softwerkskammer/Agora/subscription","commits_url":"https://api.github.com/repos/softwerkskammer/Agora/commits{/sha}","git_commits_url":"https://api.github.com/repos/softwerkskammer/Agora/git/commits{/sha}","comments_url":"https://api.github.com/repos/softwerkskammer/Agora/comments{/number}","issue_comment_url":"https://api.github.com/repos/softwerkskammer/Agora/issues/comments{/number}","contents_url":"https://api.github.com/repos/softwerkskammer/Agora/contents/{+path}","compare_url":"https://api.github.com/repos/softwerkskammer/Agora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/softwerkskammer/Agora/merges","archive_url":"https://api.github.com/repos/softwerkskammer/Agora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/softwerkskammer/Agora/downloads","issues_url":"https://api.github.com/repos/softwerkskammer/Agora/issues{/number}","pulls_url":"https://api.github.com/repos/softwerkskammer/Agora/pulls{/number}","milestones_url":"https://api.github.com/repos/softwerkskammer/Agora/milestones{/number}","notifications_url":"https://api.github.com/repos/softwerkskammer/Agora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/softwerkskammer/Agora/labels{/name}","releases_url":"https://api.github.com/repos/softwerkskammer/Agora/releases{/id}","deployments_url":"https://api.github.com/repos/softwerkskammer/Agora/deployments","created_at":"2013-03-14T21:07:21Z","updated_at":"2016-10-28T20:28:47Z","pushed_at":"2016-11-30T17:03:20Z","git_url":"git://github.com/softwerkskammer/Agora.git","ssh_url":"git@github.com:softwerkskammer/Agora.git","clone_url":"https://github.com/softwerkskammer/Agora.git","svn_url":"https://github.com/softwerkskammer/Agora","homepage":"","size":21143,"stargazers_count":39,"watchers_count":39,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":28,"forks":65,"open_issues":28,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/softwerkskammer/Agora/pulls/1190"},"html":{"href":"https://github.com/softwerkskammer/Agora/pull/1190"},"issue":{"href":"https://api.github.com/repos/softwerkskammer/Agora/issues/1190"},"comments":{"href":"https://api.github.com/repos/softwerkskammer/Agora/issues/1190/comments"},"review_comments":{"href":"https://api.github.com/repos/softwerkskammer/Agora/pulls/1190/comments"},"review_comment":{"href":"https://api.github.com/repos/softwerkskammer/Agora/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/softwerkskammer/Agora/pulls/1190/commits"},"statuses":{"href":"https://api.github.com/repos/softwerkskammer/Agora/statuses/cdbf7808866f20172fe842c4dbc74ba1a2ad9cf7"}}}}
{"actor":{"display_login":"NicoleRauch"}}