{"action":"created","comment":{"url":"https://api.github.com/repos/dmlc/mxnet/pulls/comments/61622407","id":61622407,"diff_hunk":"@@ -244,7 +247,7 @@ def predict(self, eval_data, num_batch=None, merge_batches=True, reset=True,\n                 break\n             self.forward(eval_batch, is_train=False)\n             pad = eval_batch.pad\n-            outputs = [out[0:out.shape[0]-pad].asnumpy() for out in self.get_outputs()]\n+            outputs = [out[0:out.shape[0]-pad] for out in self.get_outputs()]","path":"python/mxnet/module/base_module.py","position":26,"original_position":26,"commit_id":"459cd714a7cf8eaf1ec5266f47a003bf707cb721","original_commit_id":"f3f728087d054f17d899054edd17bd5d490b0454","user":{"login":"pluskid","id":3542,"avatar_url":"https://avatars.githubusercontent.com/u/3542?v=3","gravatar_id":"","url":"https://api.github.com/users/pluskid","html_url":"https://github.com/pluskid","followers_url":"https://api.github.com/users/pluskid/followers","following_url":"https://api.github.com/users/pluskid/following{/other_user}","gists_url":"https://api.github.com/users/pluskid/gists{/gist_id}","starred_url":"https://api.github.com/users/pluskid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pluskid/subscriptions","organizations_url":"https://api.github.com/users/pluskid/orgs","repos_url":"https://api.github.com/users/pluskid/repos","events_url":"https://api.github.com/users/pluskid/events{/privacy}","received_events_url":"https://api.github.com/users/pluskid/received_events","type":"User","site_admin":false},"body":"I think in this particular case it is better to keep a relatively unified interface than to keep it (exactly) backward compatible. Otherwise, it is also a question that whether you want to return np.array or ndarray for `iter_predict`. I think since the module API is already not exactly compatible with `FeedForward`, my personal opinion is to use this chance to have a cleaner interface here. I guess it might also perform better without those blocking `asnumpy()` call after each `forward`.","created_at":"2016-04-29T18:15:12Z","updated_at":"2016-04-29T18:15:12Z","html_url":"https://github.com/dmlc/mxnet/pull/1989#discussion_r61622407","pull_request_url":"https://api.github.com/repos/dmlc/mxnet/pulls/1989","_links":{"self":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/comments/61622407"},"html":{"href":"https://github.com/dmlc/mxnet/pull/1989#discussion_r61622407"},"pull_request":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/1989"}}},"pull_request":{"url":"https://api.github.com/repos/dmlc/mxnet/pulls/1989","id":68373761,"html_url":"https://github.com/dmlc/mxnet/pull/1989","diff_url":"https://github.com/dmlc/mxnet/pull/1989.diff","patch_url":"https://github.com/dmlc/mxnet/pull/1989.patch","issue_url":"https://api.github.com/repos/dmlc/mxnet/issues/1989","number":1989,"state":"open","locked":false,"title":"Fix module.predict","user":{"login":"pluskid","id":3542,"avatar_url":"https://avatars.githubusercontent.com/u/3542?v=3","gravatar_id":"","url":"https://api.github.com/users/pluskid","html_url":"https://github.com/pluskid","followers_url":"https://api.github.com/users/pluskid/followers","following_url":"https://api.github.com/users/pluskid/following{/other_user}","gists_url":"https://api.github.com/users/pluskid/gists{/gist_id}","starred_url":"https://api.github.com/users/pluskid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pluskid/subscriptions","organizations_url":"https://api.github.com/users/pluskid/orgs","repos_url":"https://api.github.com/users/pluskid/repos","events_url":"https://api.github.com/users/pluskid/events{/privacy}","received_events_url":"https://api.github.com/users/pluskid/received_events","type":"User","site_admin":false},"body":"See #1985\r\n\r\nAlso changed `fit` to reset eval metric on training data for each batch, to be compatible with the recent changes in `FeedForward`.","created_at":"2016-04-29T13:46:41Z","updated_at":"2016-04-29T18:15:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79f7aa67bce034e29400331407ac5974eb5a8b48","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dmlc/mxnet/pulls/1989/commits","review_comments_url":"https://api.github.com/repos/dmlc/mxnet/pulls/1989/comments","review_comment_url":"https://api.github.com/repos/dmlc/mxnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dmlc/mxnet/issues/1989/comments","statuses_url":"https://api.github.com/repos/dmlc/mxnet/statuses/459cd714a7cf8eaf1ec5266f47a003bf707cb721","head":{"label":"pluskid:master","ref":"master","sha":"459cd714a7cf8eaf1ec5266f47a003bf707cb721","user":{"login":"pluskid","id":3542,"avatar_url":"https://avatars.githubusercontent.com/u/3542?v=3","gravatar_id":"","url":"https://api.github.com/users/pluskid","html_url":"https://github.com/pluskid","followers_url":"https://api.github.com/users/pluskid/followers","following_url":"https://api.github.com/users/pluskid/following{/other_user}","gists_url":"https://api.github.com/users/pluskid/gists{/gist_id}","starred_url":"https://api.github.com/users/pluskid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pluskid/subscriptions","organizations_url":"https://api.github.com/users/pluskid/orgs","repos_url":"https://api.github.com/users/pluskid/repos","events_url":"https://api.github.com/users/pluskid/events{/privacy}","received_events_url":"https://api.github.com/users/pluskid/received_events","type":"User","site_admin":false},"repo":{"id":43519175,"name":"mxnet","full_name":"pluskid/mxnet","owner":{"login":"pluskid","id":3542,"avatar_url":"https://avatars.githubusercontent.com/u/3542?v=3","gravatar_id":"","url":"https://api.github.com/users/pluskid","html_url":"https://github.com/pluskid","followers_url":"https://api.github.com/users/pluskid/followers","following_url":"https://api.github.com/users/pluskid/following{/other_user}","gists_url":"https://api.github.com/users/pluskid/gists{/gist_id}","starred_url":"https://api.github.com/users/pluskid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pluskid/subscriptions","organizations_url":"https://api.github.com/users/pluskid/orgs","repos_url":"https://api.github.com/users/pluskid/repos","events_url":"https://api.github.com/users/pluskid/events{/privacy}","received_events_url":"https://api.github.com/users/pluskid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pluskid/mxnet","description":"efficient, flexible, distributed deep learning framework ","fork":true,"url":"https://api.github.com/repos/pluskid/mxnet","forks_url":"https://api.github.com/repos/pluskid/mxnet/forks","keys_url":"https://api.github.com/repos/pluskid/mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pluskid/mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pluskid/mxnet/teams","hooks_url":"https://api.github.com/repos/pluskid/mxnet/hooks","issue_events_url":"https://api.github.com/repos/pluskid/mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/pluskid/mxnet/events","assignees_url":"https://api.github.com/repos/pluskid/mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/pluskid/mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/pluskid/mxnet/tags","blobs_url":"https://api.github.com/repos/pluskid/mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pluskid/mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pluskid/mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/pluskid/mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pluskid/mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/pluskid/mxnet/languages","stargazers_url":"https://api.github.com/repos/pluskid/mxnet/stargazers","contributors_url":"https://api.github.com/repos/pluskid/mxnet/contributors","subscribers_url":"https://api.github.com/repos/pluskid/mxnet/subscribers","subscription_url":"https://api.github.com/repos/pluskid/mxnet/subscription","commits_url":"https://api.github.com/repos/pluskid/mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/pluskid/mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/pluskid/mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/pluskid/mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/pluskid/mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/pluskid/mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pluskid/mxnet/merges","archive_url":"https://api.github.com/repos/pluskid/mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pluskid/mxnet/downloads","issues_url":"https://api.github.com/repos/pluskid/mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/pluskid/mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/pluskid/mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/pluskid/mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pluskid/mxnet/labels{/name}","releases_url":"https://api.github.com/repos/pluskid/mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/pluskid/mxnet/deployments","created_at":"2015-10-01T20:26:25Z","updated_at":"2016-04-17T22:47:00Z","pushed_at":"2016-04-29T18:11:56Z","git_url":"git://github.com/pluskid/mxnet.git","ssh_url":"git@github.com:pluskid/mxnet.git","clone_url":"https://github.com/pluskid/mxnet.git","svn_url":"https://github.com/pluskid/mxnet","homepage":"","size":7232,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dmlc:master","ref":"master","sha":"49dfe7044cf747528423a04978f526b95766d3e0","user":{"login":"dmlc","id":11508361,"avatar_url":"https://avatars.githubusercontent.com/u/11508361?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"repo":{"id":34864402,"name":"mxnet","full_name":"dmlc/mxnet","owner":{"login":"dmlc","id":11508361,"avatar_url":"https://avatars.githubusercontent.com/u/11508361?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dmlc/mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":false,"url":"https://api.github.com/repos/dmlc/mxnet","forks_url":"https://api.github.com/repos/dmlc/mxnet/forks","keys_url":"https://api.github.com/repos/dmlc/mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmlc/mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmlc/mxnet/teams","hooks_url":"https://api.github.com/repos/dmlc/mxnet/hooks","issue_events_url":"https://api.github.com/repos/dmlc/mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/dmlc/mxnet/events","assignees_url":"https://api.github.com/repos/dmlc/mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/dmlc/mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/dmlc/mxnet/tags","blobs_url":"https://api.github.com/repos/dmlc/mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmlc/mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmlc/mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmlc/mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmlc/mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/dmlc/mxnet/languages","stargazers_url":"https://api.github.com/repos/dmlc/mxnet/stargazers","contributors_url":"https://api.github.com/repos/dmlc/mxnet/contributors","subscribers_url":"https://api.github.com/repos/dmlc/mxnet/subscribers","subscription_url":"https://api.github.com/repos/dmlc/mxnet/subscription","commits_url":"https://api.github.com/repos/dmlc/mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmlc/mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmlc/mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmlc/mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmlc/mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/dmlc/mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmlc/mxnet/merges","archive_url":"https://api.github.com/repos/dmlc/mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmlc/mxnet/downloads","issues_url":"https://api.github.com/repos/dmlc/mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/dmlc/mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/dmlc/mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/dmlc/mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmlc/mxnet/labels{/name}","releases_url":"https://api.github.com/repos/dmlc/mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/dmlc/mxnet/deployments","created_at":"2015-04-30T16:21:15Z","updated_at":"2016-04-29T16:19:25Z","pushed_at":"2016-04-29T18:11:57Z","git_url":"git://github.com/dmlc/mxnet.git","ssh_url":"git@github.com:dmlc/mxnet.git","clone_url":"https://github.com/dmlc/mxnet.git","svn_url":"https://github.com/dmlc/mxnet","homepage":"http://mxnet.rtfd.org","size":10060,"stargazers_count":3534,"watchers_count":3534,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1223,"mirror_url":null,"open_issues_count":275,"forks":1223,"open_issues":275,"watchers":3534,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/1989"},"html":{"href":"https://github.com/dmlc/mxnet/pull/1989"},"issue":{"href":"https://api.github.com/repos/dmlc/mxnet/issues/1989"},"comments":{"href":"https://api.github.com/repos/dmlc/mxnet/issues/1989/comments"},"review_comments":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/1989/comments"},"review_comment":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/1989/commits"},"statuses":{"href":"https://api.github.com/repos/dmlc/mxnet/statuses/459cd714a7cf8eaf1ec5266f47a003bf707cb721"}}}}