{"action":"created","issue":{"url":"https://api.github.com/repos/CartoDB/crankshaft/issues/129","repository_url":"https://api.github.com/repos/CartoDB/crankshaft","labels_url":"https://api.github.com/repos/CartoDB/crankshaft/issues/129/labels{/name}","comments_url":"https://api.github.com/repos/CartoDB/crankshaft/issues/129/comments","events_url":"https://api.github.com/repos/CartoDB/crankshaft/issues/129/events","html_url":"https://github.com/CartoDB/crankshaft/pull/129","id":178029191,"number":129,"title":"[interpolation] Add NN(s) method","user":{"login":"AbelVM","id":9017165,"avatar_url":"https://avatars.githubusercontent.com/u/9017165?v=3","gravatar_id":"","url":"https://api.github.com/users/AbelVM","html_url":"https://github.com/AbelVM","followers_url":"https://api.github.com/users/AbelVM/followers","following_url":"https://api.github.com/users/AbelVM/following{/other_user}","gists_url":"https://api.github.com/users/AbelVM/gists{/gist_id}","starred_url":"https://api.github.com/users/AbelVM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbelVM/subscriptions","organizations_url":"https://api.github.com/users/AbelVM/orgs","repos_url":"https://api.github.com/users/AbelVM/repos","events_url":"https://api.github.com/users/AbelVM/events{/privacy}","received_events_url":"https://api.github.com/users/AbelVM/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"iriberri","id":1730320,"avatar_url":"https://avatars.githubusercontent.com/u/1730320?v=3","gravatar_id":"","url":"https://api.github.com/users/iriberri","html_url":"https://github.com/iriberri","followers_url":"https://api.github.com/users/iriberri/followers","following_url":"https://api.github.com/users/iriberri/following{/other_user}","gists_url":"https://api.github.com/users/iriberri/gists{/gist_id}","starred_url":"https://api.github.com/users/iriberri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iriberri/subscriptions","organizations_url":"https://api.github.com/users/iriberri/orgs","repos_url":"https://api.github.com/users/iriberri/repos","events_url":"https://api.github.com/users/iriberri/events{/privacy}","received_events_url":"https://api.github.com/users/iriberri/received_events","type":"User","site_admin":false},"assignees":[{"login":"iriberri","id":1730320,"avatar_url":"https://avatars.githubusercontent.com/u/1730320?v=3","gravatar_id":"","url":"https://api.github.com/users/iriberri","html_url":"https://github.com/iriberri","followers_url":"https://api.github.com/users/iriberri/followers","following_url":"https://api.github.com/users/iriberri/following{/other_user}","gists_url":"https://api.github.com/users/iriberri/gists{/gist_id}","starred_url":"https://api.github.com/users/iriberri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iriberri/subscriptions","organizations_url":"https://api.github.com/users/iriberri/orgs","repos_url":"https://api.github.com/users/iriberri/repos","events_url":"https://api.github.com/users/iriberri/events{/privacy}","received_events_url":"https://api.github.com/users/iriberri/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-09-20T10:59:23Z","updated_at":"2016-09-20T12:52:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CartoDB/crankshaft/pulls/129","html_url":"https://github.com/CartoDB/crankshaft/pull/129","diff_url":"https://github.com/CartoDB/crankshaft/pull/129.diff","patch_url":"https://github.com/CartoDB/crankshaft/pull/129.patch"},"body":"- [x] All declared geometries are `geometry(Geometry, 4326)` for general geoms, or `geometry(Point, 4326)`\r\n- [x] Existing functions in crankshaft python library called from the extension are kept at least from version N to version N+1 (to avoid breakage during upgrades).\r\n- [x] Docs for public-facing functions are written\r\n- [x] New functions follow the naming conventions: `CDB_NameOfFunction`. Where internal functions begin with an underscore `_`.\r\n- [x] If appropriate, new functions accepts an arbitrary query as an input (see [Crankshaft Issue #6](https://github.com/CartoDB/crankshaft/issues/6) for more information)\r\n \r\n"},"comment":{"url":"https://api.github.com/repos/CartoDB/crankshaft/issues/comments/248292170","html_url":"https://github.com/CartoDB/crankshaft/pull/129#issuecomment-248292170","issue_url":"https://api.github.com/repos/CartoDB/crankshaft/issues/129","id":248292170,"user":{"login":"iriberri","id":1730320,"avatar_url":"https://avatars.githubusercontent.com/u/1730320?v=3","gravatar_id":"","url":"https://api.github.com/users/iriberri","html_url":"https://github.com/iriberri","followers_url":"https://api.github.com/users/iriberri/followers","following_url":"https://api.github.com/users/iriberri/following{/other_user}","gists_url":"https://api.github.com/users/iriberri/gists{/gist_id}","starred_url":"https://api.github.com/users/iriberri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iriberri/subscriptions","organizations_url":"https://api.github.com/users/iriberri/orgs","repos_url":"https://api.github.com/users/iriberri/repos","events_url":"https://api.github.com/users/iriberri/events{/privacy}","received_events_url":"https://api.github.com/users/iriberri/received_events","type":"User","site_admin":false},"created_at":"2016-09-20T12:52:20Z","updated_at":"2016-09-20T12:52:20Z","body":"It looks good, I just noticed that the output value -777.777 is not documented though. Not sure if you'd want to raise an exception if the method selected is 3.\r\n\r\nAlso, it's not new code, but I wonder why you initialize output to -999.999 if that value is never used."}}
{"actor":{"display_login":"iriberri"}}