{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/google-source-plugin/issues/3","repository_url":"https://api.github.com/repos/jenkinsci/google-source-plugin","labels_url":"https://api.github.com/repos/jenkinsci/google-source-plugin/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/google-source-plugin/issues/3/comments","events_url":"https://api.github.com/repos/jenkinsci/google-source-plugin/issues/3/events","html_url":"https://github.com/jenkinsci/google-source-plugin/pull/3","id":148439859,"number":3,"title":"Remove SourceMetadata extraction logic.","user":{"login":"tcnghia","id":138266,"avatar_url":"https://avatars.githubusercontent.com/u/138266?v=3","gravatar_id":"","url":"https://api.github.com/users/tcnghia","html_url":"https://github.com/tcnghia","followers_url":"https://api.github.com/users/tcnghia/followers","following_url":"https://api.github.com/users/tcnghia/following{/other_user}","gists_url":"https://api.github.com/users/tcnghia/gists{/gist_id}","starred_url":"https://api.github.com/users/tcnghia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcnghia/subscriptions","organizations_url":"https://api.github.com/users/tcnghia/orgs","repos_url":"https://api.github.com/users/tcnghia/repos","events_url":"https://api.github.com/users/tcnghia/events{/privacy}","received_events_url":"https://api.github.com/users/tcnghia/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-14T18:08:02Z","updated_at":"2016-04-14T18:25:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/google-source-plugin/pulls/3","html_url":"https://github.com/jenkinsci/google-source-plugin/pull/3","diff_url":"https://github.com/jenkinsci/google-source-plugin/pull/3.diff","patch_url":"https://github.com/jenkinsci/google-source-plugin/pull/3.patch"},"body":"SourceMetadata appears largely unused, and its extraction logic contains\r\ncode that can be dependent on Jenkins versions and versions of dependent\r\nplugins.\r\n\r\nSince the main purpose of the plugin is only about consuming\r\nGoogle OAuth credentials in accessing source code from\r\nhttps://source.developer.google.com and https://*.googlesource.com (see\r\nhttps://wiki.jenkins-ci.org/display/JENKINS/Google+Source+Plugin),\r\nremoving SourceMetadata and related classes will not removal main\r\nfunctionalities; only making the plugin less error-prone.\r\n\r\nThere seems to be a deserialization issue reported when users uninstall\r\nthe plugin, so I leave SourceMetadata as @Deprecated in order to avoid\r\nusers upgrading the plugin from hitting the deserialization issue."},"comment":{"url":"https://api.github.com/repos/jenkinsci/google-source-plugin/issues/comments/210087981","html_url":"https://github.com/jenkinsci/google-source-plugin/pull/3#issuecomment-210087981","issue_url":"https://api.github.com/repos/jenkinsci/google-source-plugin/issues/3","id":210087981,"user":{"login":"tcnghia","id":138266,"avatar_url":"https://avatars.githubusercontent.com/u/138266?v=3","gravatar_id":"","url":"https://api.github.com/users/tcnghia","html_url":"https://github.com/tcnghia","followers_url":"https://api.github.com/users/tcnghia/followers","following_url":"https://api.github.com/users/tcnghia/following{/other_user}","gists_url":"https://api.github.com/users/tcnghia/gists{/gist_id}","starred_url":"https://api.github.com/users/tcnghia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcnghia/subscriptions","organizations_url":"https://api.github.com/users/tcnghia/orgs","repos_url":"https://api.github.com/users/tcnghia/repos","events_url":"https://api.github.com/users/tcnghia/events{/privacy}","received_events_url":"https://api.github.com/users/tcnghia/received_events","type":"User","site_admin":false},"created_at":"2016-04-14T18:25:04Z","updated_at":"2016-04-14T18:25:04Z","body":"@astroilov can you please help review the PR?  thanks"}}