{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/68485314","id":68485314,"diff_hunk":"@@ -184,7 +184,8 @@ func (e *EndpointController) getPodServiceMemberships(pod *api.Pod) (sets.String\n \tfor i := range services {\n \t\tkey, err := keyFunc(&services[i])","path":"pkg/controller/endpoint/endpoints_controller.go","position":2,"original_position":2,"commit_id":"16cfff1ccbaae807b441b1febcba23257723d174","original_commit_id":"16cfff1ccbaae807b441b1febcba23257723d174","user":{"login":"249043822","id":18046309,"avatar_url":"https://avatars.githubusercontent.com/u/18046309?v=3","gravatar_id":"","url":"https://api.github.com/users/249043822","html_url":"https://github.com/249043822","followers_url":"https://api.github.com/users/249043822/followers","following_url":"https://api.github.com/users/249043822/following{/other_user}","gists_url":"https://api.github.com/users/249043822/gists{/gist_id}","starred_url":"https://api.github.com/users/249043822/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/249043822/subscriptions","organizations_url":"https://api.github.com/users/249043822/orgs","repos_url":"https://api.github.com/users/249043822/repos","events_url":"https://api.github.com/users/249043822/events{/privacy}","received_events_url":"https://api.github.com/users/249043822/received_events","type":"User","site_admin":false},"body":"I think if here return error,  addPod or updatePod func will return directly, it can't force a requeue for pod, like below\r\n\r\n\tif err != nil {\r\n\t\tglog.Errorf(\"Unable to get pod %v/%v's service memberships: %v\", pod.Namespace, pod.Name, err)\r\n\t\treturn\r\n\t}\r\n\r\n\r\n\r\nthen, the pod related service still doesn't get synced","created_at":"2016-06-25T06:50:50Z","updated_at":"2016-06-25T06:50:50Z","html_url":"https://github.com/kubernetes/kubernetes/pull/27842#discussion_r68485314","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27842","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/68485314"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/27842#discussion_r68485314"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27842"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27842","id":74739197,"html_url":"https://github.com/kubernetes/kubernetes/pull/27842","diff_url":"https://github.com/kubernetes/kubernetes/pull/27842.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/27842.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/27842","number":27842,"state":"open","locked":false,"title":"endpointsController get podServices should not return nil while encounted key error","user":{"login":"249043822","id":18046309,"avatar_url":"https://avatars.githubusercontent.com/u/18046309?v=3","gravatar_id":"","url":"https://api.github.com/users/249043822","html_url":"https://github.com/249043822","followers_url":"https://api.github.com/users/249043822/followers","following_url":"https://api.github.com/users/249043822/following{/other_user}","gists_url":"https://api.github.com/users/249043822/gists{/gist_id}","starred_url":"https://api.github.com/users/249043822/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/249043822/subscriptions","organizations_url":"https://api.github.com/users/249043822/orgs","repos_url":"https://api.github.com/users/249043822/repos","events_url":"https://api.github.com/users/249043822/events{/privacy}","received_events_url":"https://api.github.com/users/249043822/received_events","type":"User","site_admin":false},"body":"I think getPodServiceMemberships method shouldn't return directly while anyone service gets key error,\r\nwhen other services maybe ok","created_at":"2016-06-22T07:58:53Z","updated_at":"2016-06-25T06:50:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93162f81efa1e29454a9ff9dd7595eb6f5be0737","assignee":{"login":"bprashanth","id":10927820,"avatar_url":"https://avatars.githubusercontent.com/u/10927820?v=3","gravatar_id":"","url":"https://api.github.com/users/bprashanth","html_url":"https://github.com/bprashanth","followers_url":"https://api.github.com/users/bprashanth/followers","following_url":"https://api.github.com/users/bprashanth/following{/other_user}","gists_url":"https://api.github.com/users/bprashanth/gists{/gist_id}","starred_url":"https://api.github.com/users/bprashanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bprashanth/subscriptions","organizations_url":"https://api.github.com/users/bprashanth/orgs","repos_url":"https://api.github.com/users/bprashanth/repos","events_url":"https://api.github.com/users/bprashanth/events{/privacy}","received_events_url":"https://api.github.com/users/bprashanth/received_events","type":"User","site_admin":false},"assignees":[{"login":"bprashanth","id":10927820,"avatar_url":"https://avatars.githubusercontent.com/u/10927820?v=3","gravatar_id":"","url":"https://api.github.com/users/bprashanth","html_url":"https://github.com/bprashanth","followers_url":"https://api.github.com/users/bprashanth/followers","following_url":"https://api.github.com/users/bprashanth/following{/other_user}","gists_url":"https://api.github.com/users/bprashanth/gists{/gist_id}","starred_url":"https://api.github.com/users/bprashanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bprashanth/subscriptions","organizations_url":"https://api.github.com/users/bprashanth/orgs","repos_url":"https://api.github.com/users/bprashanth/repos","events_url":"https://api.github.com/users/bprashanth/events{/privacy}","received_events_url":"https://api.github.com/users/bprashanth/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27842/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27842/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/27842/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/16cfff1ccbaae807b441b1febcba23257723d174","head":{"label":"ZTE-PaaS:zhangke-patch-002","ref":"zhangke-patch-002","sha":"16cfff1ccbaae807b441b1febcba23257723d174","user":{"login":"ZTE-PaaS","id":19487201,"avatar_url":"https://avatars.githubusercontent.com/u/19487201?v=3","gravatar_id":"","url":"https://api.github.com/users/ZTE-PaaS","html_url":"https://github.com/ZTE-PaaS","followers_url":"https://api.github.com/users/ZTE-PaaS/followers","following_url":"https://api.github.com/users/ZTE-PaaS/following{/other_user}","gists_url":"https://api.github.com/users/ZTE-PaaS/gists{/gist_id}","starred_url":"https://api.github.com/users/ZTE-PaaS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZTE-PaaS/subscriptions","organizations_url":"https://api.github.com/users/ZTE-PaaS/orgs","repos_url":"https://api.github.com/users/ZTE-PaaS/repos","events_url":"https://api.github.com/users/ZTE-PaaS/events{/privacy}","received_events_url":"https://api.github.com/users/ZTE-PaaS/received_events","type":"Organization","site_admin":false},"repo":{"id":59443270,"name":"kubernetes","full_name":"ZTE-PaaS/kubernetes","owner":{"login":"ZTE-PaaS","id":19487201,"avatar_url":"https://avatars.githubusercontent.com/u/19487201?v=3","gravatar_id":"","url":"https://api.github.com/users/ZTE-PaaS","html_url":"https://github.com/ZTE-PaaS","followers_url":"https://api.github.com/users/ZTE-PaaS/followers","following_url":"https://api.github.com/users/ZTE-PaaS/following{/other_user}","gists_url":"https://api.github.com/users/ZTE-PaaS/gists{/gist_id}","starred_url":"https://api.github.com/users/ZTE-PaaS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZTE-PaaS/subscriptions","organizations_url":"https://api.github.com/users/ZTE-PaaS/orgs","repos_url":"https://api.github.com/users/ZTE-PaaS/repos","events_url":"https://api.github.com/users/ZTE-PaaS/events{/privacy}","received_events_url":"https://api.github.com/users/ZTE-PaaS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ZTE-PaaS/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/ZTE-PaaS/kubernetes","forks_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/forks","keys_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/teams","hooks_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/events","assignees_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/tags","blobs_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/languages","stargazers_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/subscription","commits_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/merges","archive_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/downloads","issues_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/ZTE-PaaS/kubernetes/deployments","created_at":"2016-05-23T01:26:00Z","updated_at":"2016-05-23T01:26:15Z","pushed_at":"2016-06-22T07:48:30Z","git_url":"git://github.com/ZTE-PaaS/kubernetes.git","ssh_url":"git@github.com:ZTE-PaaS/kubernetes.git","clone_url":"https://github.com/ZTE-PaaS/kubernetes.git","svn_url":"https://github.com/ZTE-PaaS/kubernetes","homepage":"http://kubernetes.io","size":271805,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"48f2b11c48ccfd8da5b4d5c3cf11db8fbd0fedfe","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-06-25T02:24:33Z","pushed_at":"2016-06-25T06:14:30Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":483447,"stargazers_count":15093,"watchers_count":15093,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4709,"mirror_url":null,"open_issues_count":3797,"forks":4709,"open_issues":3797,"watchers":15093,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27842"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/27842"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/27842"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/27842/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27842/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27842/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/16cfff1ccbaae807b441b1febcba23257723d174"}}}}
{"actor":{"display_login":"249043822"}}