{"action":"created","comment":{"url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/pulls/comments/72911231","id":72911231,"diff_hunk":"@@ -111,6 +111,28 @@ Babel.prototype.optionsHash = function() {\n       hash[key] = (typeof value === 'function') ? (value + '') : value;\n     }\n \n+    if (options.plugins) {\n+      hash.plugins = [];\n+\n+      for (var i = 0; i < options.plugins.length; i++) {\n+        var plugin = options.plugins[i];\n+\n+        // do not look for `._augmentCacheKey` on string plugins\n+        var pluginType = typeof plugin;\n+        var pluginAugmentsCacheKey = (\n+          (pluginType === 'object' || pluginType === 'function')\n+            && typeof plugin._augmentCacheKey === 'function'\n+        );\n+        if (pluginType === 'string') {\n+          hash.plugins.push(plugin);\n+        } else if (pluginAugmentsCacheKey) {\n+          hash.plugins.push(plugin._augmentCacheKey());\n+        } else {\n+          hash.plugins.push(pluginType === 'function' ? plugin + '' : plugin);","path":"index.js","position":21,"original_position":21,"commit_id":"a0512fa58086424ae91bab08607ba30addcfaab3","original_commit_id":"a0512fa58086424ae91bab08607ba30addcfaab3","user":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"body":"Falling back to non-persistent mode (with a warning) seems great. But I'm unsure if you can downgrade after the constructor. \r\n\r\nI can play with that to see. If we can't change strategy then a warning + a completely generated key (to ensure it is unique and prevent long term persistence) would work. ","created_at":"2016-07-31T21:26:12Z","updated_at":"2016-07-31T21:26:12Z","html_url":"https://github.com/babel/broccoli-babel-transpiler/pull/89#discussion_r72911231","pull_request_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/pulls/89","_links":{"self":{"href":"https://api.github.com/repos/babel/broccoli-babel-transpiler/pulls/comments/72911231"},"html":{"href":"https://github.com/babel/broccoli-babel-transpiler/pull/89#discussion_r72911231"},"pull_request":{"href":"https://api.github.com/repos/babel/broccoli-babel-transpiler/pulls/89"}}},"pull_request":{"url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/pulls/89","id":79236718,"html_url":"https://github.com/babel/broccoli-babel-transpiler/pull/89","diff_url":"https://github.com/babel/broccoli-babel-transpiler/pull/89.diff","patch_url":"https://github.com/babel/broccoli-babel-transpiler/pull/89.patch","issue_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/issues/89","number":89,"state":"open","locked":false,"title":"Allow plugins to bust the cache.","user":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"body":"This is a small step towards fixing https://github.com/babel/broccoli-babel-transpiler/issues/67.\r\n\r\n- [x] Needs tests\r\n- [ ] Verify with @stefanpenner on the naming of the cache key method for plugins\r\n- [ ] Backport to 5.x branch\r\n- [ ] Check with @Turbo87 about how to do this with babel 6 plugins?","created_at":"2016-07-28T17:34:19Z","updated_at":"2016-07-31T21:26:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1bd059271f83c7041cebc1cfba0eb7b0a7a48a69","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/pulls/89/commits","review_comments_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/pulls/89/comments","review_comment_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/issues/89/comments","statuses_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/statuses/a0512fa58086424ae91bab08607ba30addcfaab3","head":{"label":"babel:rwjblue-patch-1","ref":"rwjblue-patch-1","sha":"a0512fa58086424ae91bab08607ba30addcfaab3","user":{"login":"babel","id":9637642,"avatar_url":"https://avatars.githubusercontent.com/u/9637642?v=3","gravatar_id":"","url":"https://api.github.com/users/babel","html_url":"https://github.com/babel","followers_url":"https://api.github.com/users/babel/followers","following_url":"https://api.github.com/users/babel/following{/other_user}","gists_url":"https://api.github.com/users/babel/gists{/gist_id}","starred_url":"https://api.github.com/users/babel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babel/subscriptions","organizations_url":"https://api.github.com/users/babel/orgs","repos_url":"https://api.github.com/users/babel/repos","events_url":"https://api.github.com/users/babel/events{/privacy}","received_events_url":"https://api.github.com/users/babel/received_events","type":"Organization","site_admin":false},"repo":{"id":25077882,"name":"broccoli-babel-transpiler","full_name":"babel/broccoli-babel-transpiler","owner":{"login":"babel","id":9637642,"avatar_url":"https://avatars.githubusercontent.com/u/9637642?v=3","gravatar_id":"","url":"https://api.github.com/users/babel","html_url":"https://github.com/babel","followers_url":"https://api.github.com/users/babel/followers","following_url":"https://api.github.com/users/babel/following{/other_user}","gists_url":"https://api.github.com/users/babel/gists{/gist_id}","starred_url":"https://api.github.com/users/babel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babel/subscriptions","organizations_url":"https://api.github.com/users/babel/orgs","repos_url":"https://api.github.com/users/babel/repos","events_url":"https://api.github.com/users/babel/events{/privacy}","received_events_url":"https://api.github.com/users/babel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/babel/broccoli-babel-transpiler","description":"Broccoli plugin for Babel","fork":false,"url":"https://api.github.com/repos/babel/broccoli-babel-transpiler","forks_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/forks","keys_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/teams","hooks_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/hooks","issue_events_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/issues/events{/number}","events_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/events","assignees_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/assignees{/user}","branches_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/branches{/branch}","tags_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/tags","blobs_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/statuses/{sha}","languages_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/languages","stargazers_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/stargazers","contributors_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/contributors","subscribers_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/subscribers","subscription_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/subscription","commits_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/contents/{+path}","compare_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/merges","archive_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/downloads","issues_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/issues{/number}","pulls_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/pulls{/number}","milestones_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/milestones{/number}","notifications_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/labels{/name}","releases_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/releases{/id}","deployments_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/deployments","created_at":"2014-10-11T12:47:58Z","updated_at":"2016-07-26T12:41:37Z","pushed_at":"2016-07-31T02:28:37Z","git_url":"git://github.com/babel/broccoli-babel-transpiler.git","ssh_url":"git@github.com:babel/broccoli-babel-transpiler.git","clone_url":"https://github.com/babel/broccoli-babel-transpiler.git","svn_url":"https://github.com/babel/broccoli-babel-transpiler","homepage":"","size":108,"stargazers_count":35,"watchers_count":35,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":15,"forks":33,"open_issues":15,"watchers":35,"default_branch":"master"}},"base":{"label":"babel:master","ref":"master","sha":"4f7cdd7cc0af7a95d749693863a9d8d12053024d","user":{"login":"babel","id":9637642,"avatar_url":"https://avatars.githubusercontent.com/u/9637642?v=3","gravatar_id":"","url":"https://api.github.com/users/babel","html_url":"https://github.com/babel","followers_url":"https://api.github.com/users/babel/followers","following_url":"https://api.github.com/users/babel/following{/other_user}","gists_url":"https://api.github.com/users/babel/gists{/gist_id}","starred_url":"https://api.github.com/users/babel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babel/subscriptions","organizations_url":"https://api.github.com/users/babel/orgs","repos_url":"https://api.github.com/users/babel/repos","events_url":"https://api.github.com/users/babel/events{/privacy}","received_events_url":"https://api.github.com/users/babel/received_events","type":"Organization","site_admin":false},"repo":{"id":25077882,"name":"broccoli-babel-transpiler","full_name":"babel/broccoli-babel-transpiler","owner":{"login":"babel","id":9637642,"avatar_url":"https://avatars.githubusercontent.com/u/9637642?v=3","gravatar_id":"","url":"https://api.github.com/users/babel","html_url":"https://github.com/babel","followers_url":"https://api.github.com/users/babel/followers","following_url":"https://api.github.com/users/babel/following{/other_user}","gists_url":"https://api.github.com/users/babel/gists{/gist_id}","starred_url":"https://api.github.com/users/babel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babel/subscriptions","organizations_url":"https://api.github.com/users/babel/orgs","repos_url":"https://api.github.com/users/babel/repos","events_url":"https://api.github.com/users/babel/events{/privacy}","received_events_url":"https://api.github.com/users/babel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/babel/broccoli-babel-transpiler","description":"Broccoli plugin for Babel","fork":false,"url":"https://api.github.com/repos/babel/broccoli-babel-transpiler","forks_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/forks","keys_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/teams","hooks_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/hooks","issue_events_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/issues/events{/number}","events_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/events","assignees_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/assignees{/user}","branches_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/branches{/branch}","tags_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/tags","blobs_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/statuses/{sha}","languages_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/languages","stargazers_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/stargazers","contributors_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/contributors","subscribers_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/subscribers","subscription_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/subscription","commits_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/contents/{+path}","compare_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/merges","archive_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/downloads","issues_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/issues{/number}","pulls_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/pulls{/number}","milestones_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/milestones{/number}","notifications_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/labels{/name}","releases_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/releases{/id}","deployments_url":"https://api.github.com/repos/babel/broccoli-babel-transpiler/deployments","created_at":"2014-10-11T12:47:58Z","updated_at":"2016-07-26T12:41:37Z","pushed_at":"2016-07-31T02:28:37Z","git_url":"git://github.com/babel/broccoli-babel-transpiler.git","ssh_url":"git@github.com:babel/broccoli-babel-transpiler.git","clone_url":"https://github.com/babel/broccoli-babel-transpiler.git","svn_url":"https://github.com/babel/broccoli-babel-transpiler","homepage":"","size":108,"stargazers_count":35,"watchers_count":35,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":15,"forks":33,"open_issues":15,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/babel/broccoli-babel-transpiler/pulls/89"},"html":{"href":"https://github.com/babel/broccoli-babel-transpiler/pull/89"},"issue":{"href":"https://api.github.com/repos/babel/broccoli-babel-transpiler/issues/89"},"comments":{"href":"https://api.github.com/repos/babel/broccoli-babel-transpiler/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/babel/broccoli-babel-transpiler/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/babel/broccoli-babel-transpiler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/babel/broccoli-babel-transpiler/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/babel/broccoli-babel-transpiler/statuses/a0512fa58086424ae91bab08607ba30addcfaab3"}}}}
{"actor":{"display_login":"rwjblue"}}