{"action":"created","comment":{"url":"https://api.github.com/repos/vimeo/VIMNetworking/pulls/comments/65720614","id":65720614,"diff_hunk":"@@ -49,13 +49,20 @@ extern NSString *const __nonnull VIMConnectionNameShared;\n extern NSString *const __nonnull VIMConnectionNameVideos;\n extern NSString *const __nonnull VIMConnectionNameWatchlater;\n extern NSString *const __nonnull VIMConnectionNameViolations;\n+extern NSString *const __nonnull VIMConnectionNameVODItem;\n+extern NSString *const __nonnull VIMConnectionNameVODTrailer;\n \n @interface VIMConnection : VIMModelObject\n \n @property (nonatomic, copy, nullable) NSString *uri;\n @property (nonatomic, strong, nullable) NSNumber *total;\n @property (nonatomic, strong, nullable) NSArray *options;\n \n+#pragma mark - VOD related only","path":"VIMNetworking/Model/VIMConnection.h","position":13,"original_position":13,"commit_id":"a3ec3dfd2fbde48189c321ea614a094d7c609fda","original_commit_id":"a3ec3dfd2fbde48189c321ea614a094d7c609fda","user":{"login":"huebnerob","id":4182788,"avatar_url":"https://avatars.githubusercontent.com/u/4182788?v=3","gravatar_id":"","url":"https://api.github.com/users/huebnerob","html_url":"https://github.com/huebnerob","followers_url":"https://api.github.com/users/huebnerob/followers","following_url":"https://api.github.com/users/huebnerob/following{/other_user}","gists_url":"https://api.github.com/users/huebnerob/gists{/gist_id}","starred_url":"https://api.github.com/users/huebnerob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huebnerob/subscriptions","organizations_url":"https://api.github.com/users/huebnerob/orgs","repos_url":"https://api.github.com/users/huebnerob/repos","events_url":"https://api.github.com/users/huebnerob/events{/privacy}","received_events_url":"https://api.github.com/users/huebnerob/received_events","type":"User","site_admin":false},"body":"Would it make any sense to subclass something like a `VIMVODConnection` to keep these separate?","created_at":"2016-06-03T14:54:05Z","updated_at":"2016-06-03T14:54:05Z","html_url":"https://github.com/vimeo/VIMNetworking/pull/193#discussion_r65720614","pull_request_url":"https://api.github.com/repos/vimeo/VIMNetworking/pulls/193","_links":{"self":{"href":"https://api.github.com/repos/vimeo/VIMNetworking/pulls/comments/65720614"},"html":{"href":"https://github.com/vimeo/VIMNetworking/pull/193#discussion_r65720614"},"pull_request":{"href":"https://api.github.com/repos/vimeo/VIMNetworking/pulls/193"}}},"pull_request":{"url":"https://api.github.com/repos/vimeo/VIMNetworking/pulls/193","id":70985164,"html_url":"https://github.com/vimeo/VIMNetworking/pull/193","diff_url":"https://github.com/vimeo/VIMNetworking/pull/193.diff","patch_url":"https://github.com/vimeo/VIMNetworking/pull/193.patch","issue_url":"https://api.github.com/repos/vimeo/VIMNetworking/issues/193","number":193,"state":"open","locked":false,"title":"VIM-4074: VOD Model","user":{"login":"nicolelehrer","id":6685590,"avatar_url":"https://avatars.githubusercontent.com/u/6685590?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolelehrer","html_url":"https://github.com/nicolelehrer","followers_url":"https://api.github.com/users/nicolelehrer/followers","following_url":"https://api.github.com/users/nicolelehrer/following{/other_user}","gists_url":"https://api.github.com/users/nicolelehrer/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolelehrer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolelehrer/subscriptions","organizations_url":"https://api.github.com/users/nicolelehrer/orgs","repos_url":"https://api.github.com/users/nicolelehrer/repos","events_url":"https://api.github.com/users/nicolelehrer/events{/privacy}","received_events_url":"https://api.github.com/users/nicolelehrer/received_events","type":"User","site_admin":false},"body":"#### Ticket\r\n**Required for Vimeans only**\r\n[VIM-4074](https://vimean.atlassian.net/browse/VIM-4074)\r\n\r\n#### Ticket Summary\r\nAdd our model representation for VOD items (films or series)\r\nAugment our representation of video responses to handle videos associated with VOD items (trailer, film, extra content video, or an episode of a series)\r\n\r\n#### Implementation Summary\r\n`VIMJSONResponseSerializer`\r\n- added to acceptableContentTypes so we can receive JSON data for ondemand endpoints \r\n\r\n`VIMVODItem`\r\n- these are the kind of objects received for a user's VOD library, films or series they have paid for\r\n\r\n`VIMVideo+VOD`\r\n- category on `VIMVideo` to house all VOD related helpers \r\n- helpers to identify if a video is VOD when your origin is not the user's library, e.g. search results, feed\r\n\r\n`VIMConnection` \r\n- now supports `ondemand` and `trailer` connections\r\n- `videos` connection gives us the the videos for a series \r\n- new video count properties (e.g. extra, main, viewable counts) describe the number of videos associated with a VOD item\r\n\r\n`VIMInteraction`\r\n- buy, rent, subscribe interactions \r\n- with corresponding properties like stream, expiration and purchase dates \r\n- this tells us what kind of access someone has on a VOD item or one of its videos (if it was bought, rented or subscribed to)\r\n\r\n`VIMVideoPlayRepresentation` \r\n- corrected some naming inconsistency for `VIMVideoPlayabilityStatus`\r\n\r\nSome to-do's \r\n- API will update the date string format used for `expires_time` and `purchase_time` to match the format we already support. For now we use a helper method to parse this one-off format. See `VIMInteraction` implementation file for details. \r\n- API will update purchase interactions so they exist on a film object. Purchase logic is in line with anticipated behavior but should be tested. See `VIMVideo+VOD` implementation file for details. \r\n\r\n#### How to Test\r\nCode review only. [See parent PR for more context] (https://github.vimeows.com/MobileApps/Vimeo-iOS/pull/839)  \r\n\r\nIf helpful, API notes on VOD https://vimean.atlassian.net/wiki/display/DEV/API","created_at":"2016-05-22T19:00:55Z","updated_at":"2016-06-03T14:54:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83c5b038137e0d52d83a42e46e2bb51ab8ab317b","assignee":{"login":"huebnerob","id":4182788,"avatar_url":"https://avatars.githubusercontent.com/u/4182788?v=3","gravatar_id":"","url":"https://api.github.com/users/huebnerob","html_url":"https://github.com/huebnerob","followers_url":"https://api.github.com/users/huebnerob/followers","following_url":"https://api.github.com/users/huebnerob/following{/other_user}","gists_url":"https://api.github.com/users/huebnerob/gists{/gist_id}","starred_url":"https://api.github.com/users/huebnerob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huebnerob/subscriptions","organizations_url":"https://api.github.com/users/huebnerob/orgs","repos_url":"https://api.github.com/users/huebnerob/repos","events_url":"https://api.github.com/users/huebnerob/events{/privacy}","received_events_url":"https://api.github.com/users/huebnerob/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/vimeo/VIMNetworking/pulls/193/commits","review_comments_url":"https://api.github.com/repos/vimeo/VIMNetworking/pulls/193/comments","review_comment_url":"https://api.github.com/repos/vimeo/VIMNetworking/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vimeo/VIMNetworking/issues/193/comments","statuses_url":"https://api.github.com/repos/vimeo/VIMNetworking/statuses/a3ec3dfd2fbde48189c321ea614a094d7c609fda","head":{"label":"vimeo:VIM-4074-vod-model","ref":"VIM-4074-vod-model","sha":"a3ec3dfd2fbde48189c321ea614a094d7c609fda","user":{"login":"vimeo","id":317769,"avatar_url":"https://avatars.githubusercontent.com/u/317769?v=3","gravatar_id":"","url":"https://api.github.com/users/vimeo","html_url":"https://github.com/vimeo","followers_url":"https://api.github.com/users/vimeo/followers","following_url":"https://api.github.com/users/vimeo/following{/other_user}","gists_url":"https://api.github.com/users/vimeo/gists{/gist_id}","starred_url":"https://api.github.com/users/vimeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vimeo/subscriptions","organizations_url":"https://api.github.com/users/vimeo/orgs","repos_url":"https://api.github.com/users/vimeo/repos","events_url":"https://api.github.com/users/vimeo/events{/privacy}","received_events_url":"https://api.github.com/users/vimeo/received_events","type":"Organization","site_admin":false},"repo":{"id":33740468,"name":"VIMNetworking","full_name":"vimeo/VIMNetworking","owner":{"login":"vimeo","id":317769,"avatar_url":"https://avatars.githubusercontent.com/u/317769?v=3","gravatar_id":"","url":"https://api.github.com/users/vimeo","html_url":"https://github.com/vimeo","followers_url":"https://api.github.com/users/vimeo/followers","following_url":"https://api.github.com/users/vimeo/following{/other_user}","gists_url":"https://api.github.com/users/vimeo/gists{/gist_id}","starred_url":"https://api.github.com/users/vimeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vimeo/subscriptions","organizations_url":"https://api.github.com/users/vimeo/orgs","repos_url":"https://api.github.com/users/vimeo/repos","events_url":"https://api.github.com/users/vimeo/events{/privacy}","received_events_url":"https://api.github.com/users/vimeo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vimeo/VIMNetworking","description":"The Vimeo iOS SDK","fork":false,"url":"https://api.github.com/repos/vimeo/VIMNetworking","forks_url":"https://api.github.com/repos/vimeo/VIMNetworking/forks","keys_url":"https://api.github.com/repos/vimeo/VIMNetworking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vimeo/VIMNetworking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vimeo/VIMNetworking/teams","hooks_url":"https://api.github.com/repos/vimeo/VIMNetworking/hooks","issue_events_url":"https://api.github.com/repos/vimeo/VIMNetworking/issues/events{/number}","events_url":"https://api.github.com/repos/vimeo/VIMNetworking/events","assignees_url":"https://api.github.com/repos/vimeo/VIMNetworking/assignees{/user}","branches_url":"https://api.github.com/repos/vimeo/VIMNetworking/branches{/branch}","tags_url":"https://api.github.com/repos/vimeo/VIMNetworking/tags","blobs_url":"https://api.github.com/repos/vimeo/VIMNetworking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vimeo/VIMNetworking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vimeo/VIMNetworking/git/refs{/sha}","trees_url":"https://api.github.com/repos/vimeo/VIMNetworking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vimeo/VIMNetworking/statuses/{sha}","languages_url":"https://api.github.com/repos/vimeo/VIMNetworking/languages","stargazers_url":"https://api.github.com/repos/vimeo/VIMNetworking/stargazers","contributors_url":"https://api.github.com/repos/vimeo/VIMNetworking/contributors","subscribers_url":"https://api.github.com/repos/vimeo/VIMNetworking/subscribers","subscription_url":"https://api.github.com/repos/vimeo/VIMNetworking/subscription","commits_url":"https://api.github.com/repos/vimeo/VIMNetworking/commits{/sha}","git_commits_url":"https://api.github.com/repos/vimeo/VIMNetworking/git/commits{/sha}","comments_url":"https://api.github.com/repos/vimeo/VIMNetworking/comments{/number}","issue_comment_url":"https://api.github.com/repos/vimeo/VIMNetworking/issues/comments{/number}","contents_url":"https://api.github.com/repos/vimeo/VIMNetworking/contents/{+path}","compare_url":"https://api.github.com/repos/vimeo/VIMNetworking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vimeo/VIMNetworking/merges","archive_url":"https://api.github.com/repos/vimeo/VIMNetworking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vimeo/VIMNetworking/downloads","issues_url":"https://api.github.com/repos/vimeo/VIMNetworking/issues{/number}","pulls_url":"https://api.github.com/repos/vimeo/VIMNetworking/pulls{/number}","milestones_url":"https://api.github.com/repos/vimeo/VIMNetworking/milestones{/number}","notifications_url":"https://api.github.com/repos/vimeo/VIMNetworking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vimeo/VIMNetworking/labels{/name}","releases_url":"https://api.github.com/repos/vimeo/VIMNetworking/releases{/id}","deployments_url":"https://api.github.com/repos/vimeo/VIMNetworking/deployments","created_at":"2015-04-10T17:08:40Z","updated_at":"2016-05-26T06:48:42Z","pushed_at":"2016-06-03T14:09:00Z","git_url":"git://github.com/vimeo/VIMNetworking.git","ssh_url":"git@github.com:vimeo/VIMNetworking.git","clone_url":"https://github.com/vimeo/VIMNetworking.git","svn_url":"https://github.com/vimeo/VIMNetworking","homepage":null,"size":1264,"stargazers_count":38,"watchers_count":38,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":7,"forks":18,"open_issues":7,"watchers":38,"default_branch":"v6.0.2"}},"base":{"label":"vimeo:v6.1.0","ref":"v6.1.0","sha":"18de622b7df07995aef7b905ee2e4632e2fe0d06","user":{"login":"vimeo","id":317769,"avatar_url":"https://avatars.githubusercontent.com/u/317769?v=3","gravatar_id":"","url":"https://api.github.com/users/vimeo","html_url":"https://github.com/vimeo","followers_url":"https://api.github.com/users/vimeo/followers","following_url":"https://api.github.com/users/vimeo/following{/other_user}","gists_url":"https://api.github.com/users/vimeo/gists{/gist_id}","starred_url":"https://api.github.com/users/vimeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vimeo/subscriptions","organizations_url":"https://api.github.com/users/vimeo/orgs","repos_url":"https://api.github.com/users/vimeo/repos","events_url":"https://api.github.com/users/vimeo/events{/privacy}","received_events_url":"https://api.github.com/users/vimeo/received_events","type":"Organization","site_admin":false},"repo":{"id":33740468,"name":"VIMNetworking","full_name":"vimeo/VIMNetworking","owner":{"login":"vimeo","id":317769,"avatar_url":"https://avatars.githubusercontent.com/u/317769?v=3","gravatar_id":"","url":"https://api.github.com/users/vimeo","html_url":"https://github.com/vimeo","followers_url":"https://api.github.com/users/vimeo/followers","following_url":"https://api.github.com/users/vimeo/following{/other_user}","gists_url":"https://api.github.com/users/vimeo/gists{/gist_id}","starred_url":"https://api.github.com/users/vimeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vimeo/subscriptions","organizations_url":"https://api.github.com/users/vimeo/orgs","repos_url":"https://api.github.com/users/vimeo/repos","events_url":"https://api.github.com/users/vimeo/events{/privacy}","received_events_url":"https://api.github.com/users/vimeo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vimeo/VIMNetworking","description":"The Vimeo iOS SDK","fork":false,"url":"https://api.github.com/repos/vimeo/VIMNetworking","forks_url":"https://api.github.com/repos/vimeo/VIMNetworking/forks","keys_url":"https://api.github.com/repos/vimeo/VIMNetworking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vimeo/VIMNetworking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vimeo/VIMNetworking/teams","hooks_url":"https://api.github.com/repos/vimeo/VIMNetworking/hooks","issue_events_url":"https://api.github.com/repos/vimeo/VIMNetworking/issues/events{/number}","events_url":"https://api.github.com/repos/vimeo/VIMNetworking/events","assignees_url":"https://api.github.com/repos/vimeo/VIMNetworking/assignees{/user}","branches_url":"https://api.github.com/repos/vimeo/VIMNetworking/branches{/branch}","tags_url":"https://api.github.com/repos/vimeo/VIMNetworking/tags","blobs_url":"https://api.github.com/repos/vimeo/VIMNetworking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vimeo/VIMNetworking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vimeo/VIMNetworking/git/refs{/sha}","trees_url":"https://api.github.com/repos/vimeo/VIMNetworking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vimeo/VIMNetworking/statuses/{sha}","languages_url":"https://api.github.com/repos/vimeo/VIMNetworking/languages","stargazers_url":"https://api.github.com/repos/vimeo/VIMNetworking/stargazers","contributors_url":"https://api.github.com/repos/vimeo/VIMNetworking/contributors","subscribers_url":"https://api.github.com/repos/vimeo/VIMNetworking/subscribers","subscription_url":"https://api.github.com/repos/vimeo/VIMNetworking/subscription","commits_url":"https://api.github.com/repos/vimeo/VIMNetworking/commits{/sha}","git_commits_url":"https://api.github.com/repos/vimeo/VIMNetworking/git/commits{/sha}","comments_url":"https://api.github.com/repos/vimeo/VIMNetworking/comments{/number}","issue_comment_url":"https://api.github.com/repos/vimeo/VIMNetworking/issues/comments{/number}","contents_url":"https://api.github.com/repos/vimeo/VIMNetworking/contents/{+path}","compare_url":"https://api.github.com/repos/vimeo/VIMNetworking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vimeo/VIMNetworking/merges","archive_url":"https://api.github.com/repos/vimeo/VIMNetworking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vimeo/VIMNetworking/downloads","issues_url":"https://api.github.com/repos/vimeo/VIMNetworking/issues{/number}","pulls_url":"https://api.github.com/repos/vimeo/VIMNetworking/pulls{/number}","milestones_url":"https://api.github.com/repos/vimeo/VIMNetworking/milestones{/number}","notifications_url":"https://api.github.com/repos/vimeo/VIMNetworking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vimeo/VIMNetworking/labels{/name}","releases_url":"https://api.github.com/repos/vimeo/VIMNetworking/releases{/id}","deployments_url":"https://api.github.com/repos/vimeo/VIMNetworking/deployments","created_at":"2015-04-10T17:08:40Z","updated_at":"2016-05-26T06:48:42Z","pushed_at":"2016-06-03T14:09:00Z","git_url":"git://github.com/vimeo/VIMNetworking.git","ssh_url":"git@github.com:vimeo/VIMNetworking.git","clone_url":"https://github.com/vimeo/VIMNetworking.git","svn_url":"https://github.com/vimeo/VIMNetworking","homepage":null,"size":1264,"stargazers_count":38,"watchers_count":38,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":7,"forks":18,"open_issues":7,"watchers":38,"default_branch":"v6.0.2"}},"_links":{"self":{"href":"https://api.github.com/repos/vimeo/VIMNetworking/pulls/193"},"html":{"href":"https://github.com/vimeo/VIMNetworking/pull/193"},"issue":{"href":"https://api.github.com/repos/vimeo/VIMNetworking/issues/193"},"comments":{"href":"https://api.github.com/repos/vimeo/VIMNetworking/issues/193/comments"},"review_comments":{"href":"https://api.github.com/repos/vimeo/VIMNetworking/pulls/193/comments"},"review_comment":{"href":"https://api.github.com/repos/vimeo/VIMNetworking/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vimeo/VIMNetworking/pulls/193/commits"},"statuses":{"href":"https://api.github.com/repos/vimeo/VIMNetworking/statuses/a3ec3dfd2fbde48189c321ea614a094d7c609fda"}}}}
{"actor":{"display_login":"huebnerob"}}