{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/58189614","id":58189614,"diff_hunk":"@@ -149,7 +149,7 @@ void start(boolean keepOld)\n     if (mState == State.PROGRESS)\n       return;\n \n-    Location loc = LocationHelper.INSTANCE.getLastLocation();\n+    Location loc = LocationHelper.INSTANCE.getLastKnownLocation();","path":"android/src/com/mapswithme/maps/downloader/MigrationController.java","position":5,"original_position":5,"commit_id":"5931fd8cfccb4eb7910f8307a138e8feba9b9c2f","original_commit_id":"cc92bbc4b790b789ab9d08f4d3d2825564b6054a","user":{"login":"deathbaba","id":170263,"avatar_url":"https://avatars.githubusercontent.com/u/170263?v=3","gravatar_id":"","url":"https://api.github.com/users/deathbaba","html_url":"https://github.com/deathbaba","followers_url":"https://api.github.com/users/deathbaba/followers","following_url":"https://api.github.com/users/deathbaba/following{/other_user}","gists_url":"https://api.github.com/users/deathbaba/gists{/gist_id}","starred_url":"https://api.github.com/users/deathbaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deathbaba/subscriptions","organizations_url":"https://api.github.com/users/deathbaba/orgs","repos_url":"https://api.github.com/users/deathbaba/repos","events_url":"https://api.github.com/users/deathbaba/events{/privacy}","received_events_url":"https://api.github.com/users/deathbaba/received_events","type":"User","site_admin":false},"body":"Конечно важно! Если тебе нужна хоть какая-то позиция, не зависимо от времени протухания, то ты никак ее сейчас не получишь.\nИли нужно по времени у позиции сделать switch и разную логику.\n\n> On Apr 1, 2016, at 13:42, Alexander Marchuk <notifications@github.com> wrote:\n> \n> In android/src/com/mapswithme/maps/downloader/MigrationController.java <https://github.com/mapsme/omim/pull/2672#discussion_r58189451>:\n> \n> > @@ -149,7 +149,7 @@ void start(boolean keepOld)\n> >      if (mState == State.PROGRESS)\n> >        return;\n> >  \n> > -    Location loc = LocationHelper.INSTANCE.getLastLocation();\n> > +    Location loc = LocationHelper.INSTANCE.getLastKnownLocation();\n> Разве в месте использования это важно? Можно будет потом добавить методы для конкретных use-кейсов, внутри которых будет подходящие интервалы протухания. Но это уже когда появится необходимость.\n> \n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly or view it on GitHub <https://github.com/mapsme/omim/pull/2672/files/cc92bbc4b790b789ab9d08f4d3d2825564b6054a#r58189451>\n\n","created_at":"2016-04-01T10:43:47Z","updated_at":"2016-04-01T10:43:47Z","html_url":"https://github.com/mapsme/omim/pull/2672#discussion_r58189614","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/2672","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/58189614"},"html":{"href":"https://github.com/mapsme/omim/pull/2672#discussion_r58189614"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/2672"}}},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/2672","id":64918254,"html_url":"https://github.com/mapsme/omim/pull/2672","diff_url":"https://github.com/mapsme/omim/pull/2672.diff","patch_url":"https://github.com/mapsme/omim/pull/2672.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/2672","number":2672,"state":"open","locked":false,"title":"[new downloader][android] fix: Obtaining last known location regardle…","user":{"login":"trashkalmar","id":5173794,"avatar_url":"https://avatars.githubusercontent.com/u/5173794?v=3","gravatar_id":"","url":"https://api.github.com/users/trashkalmar","html_url":"https://github.com/trashkalmar","followers_url":"https://api.github.com/users/trashkalmar/followers","following_url":"https://api.github.com/users/trashkalmar/following{/other_user}","gists_url":"https://api.github.com/users/trashkalmar/gists{/gist_id}","starred_url":"https://api.github.com/users/trashkalmar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trashkalmar/subscriptions","organizations_url":"https://api.github.com/users/trashkalmar/orgs","repos_url":"https://api.github.com/users/trashkalmar/repos","events_url":"https://api.github.com/users/trashkalmar/events{/privacy}","received_events_url":"https://api.github.com/users/trashkalmar/received_events","type":"User","site_admin":false},"body":"…ss of \"My position\" button state.","created_at":"2016-04-01T09:33:23Z","updated_at":"2016-04-01T10:43:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f13e525aad85e14fe6945fe5c4ce3444c1a48cf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/2672/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/2672/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/2672/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/5931fd8cfccb4eb7910f8307a138e8feba9b9c2f","head":{"label":"trashkalmar:forced-last-location","ref":"forced-last-location","sha":"5931fd8cfccb4eb7910f8307a138e8feba9b9c2f","user":{"login":"trashkalmar","id":5173794,"avatar_url":"https://avatars.githubusercontent.com/u/5173794?v=3","gravatar_id":"","url":"https://api.github.com/users/trashkalmar","html_url":"https://github.com/trashkalmar","followers_url":"https://api.github.com/users/trashkalmar/followers","following_url":"https://api.github.com/users/trashkalmar/following{/other_user}","gists_url":"https://api.github.com/users/trashkalmar/gists{/gist_id}","starred_url":"https://api.github.com/users/trashkalmar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trashkalmar/subscriptions","organizations_url":"https://api.github.com/users/trashkalmar/orgs","repos_url":"https://api.github.com/users/trashkalmar/repos","events_url":"https://api.github.com/users/trashkalmar/events{/privacy}","received_events_url":"https://api.github.com/users/trashkalmar/received_events","type":"User","site_admin":false},"repo":{"id":43429123,"name":"omim","full_name":"trashkalmar/omim","owner":{"login":"trashkalmar","id":5173794,"avatar_url":"https://avatars.githubusercontent.com/u/5173794?v=3","gravatar_id":"","url":"https://api.github.com/users/trashkalmar","html_url":"https://github.com/trashkalmar","followers_url":"https://api.github.com/users/trashkalmar/followers","following_url":"https://api.github.com/users/trashkalmar/following{/other_user}","gists_url":"https://api.github.com/users/trashkalmar/gists{/gist_id}","starred_url":"https://api.github.com/users/trashkalmar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trashkalmar/subscriptions","organizations_url":"https://api.github.com/users/trashkalmar/orgs","repos_url":"https://api.github.com/users/trashkalmar/repos","events_url":"https://api.github.com/users/trashkalmar/events{/privacy}","received_events_url":"https://api.github.com/users/trashkalmar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trashkalmar/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":true,"url":"https://api.github.com/repos/trashkalmar/omim","forks_url":"https://api.github.com/repos/trashkalmar/omim/forks","keys_url":"https://api.github.com/repos/trashkalmar/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trashkalmar/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trashkalmar/omim/teams","hooks_url":"https://api.github.com/repos/trashkalmar/omim/hooks","issue_events_url":"https://api.github.com/repos/trashkalmar/omim/issues/events{/number}","events_url":"https://api.github.com/repos/trashkalmar/omim/events","assignees_url":"https://api.github.com/repos/trashkalmar/omim/assignees{/user}","branches_url":"https://api.github.com/repos/trashkalmar/omim/branches{/branch}","tags_url":"https://api.github.com/repos/trashkalmar/omim/tags","blobs_url":"https://api.github.com/repos/trashkalmar/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trashkalmar/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trashkalmar/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/trashkalmar/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trashkalmar/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/trashkalmar/omim/languages","stargazers_url":"https://api.github.com/repos/trashkalmar/omim/stargazers","contributors_url":"https://api.github.com/repos/trashkalmar/omim/contributors","subscribers_url":"https://api.github.com/repos/trashkalmar/omim/subscribers","subscription_url":"https://api.github.com/repos/trashkalmar/omim/subscription","commits_url":"https://api.github.com/repos/trashkalmar/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/trashkalmar/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/trashkalmar/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/trashkalmar/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/trashkalmar/omim/contents/{+path}","compare_url":"https://api.github.com/repos/trashkalmar/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trashkalmar/omim/merges","archive_url":"https://api.github.com/repos/trashkalmar/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trashkalmar/omim/downloads","issues_url":"https://api.github.com/repos/trashkalmar/omim/issues{/number}","pulls_url":"https://api.github.com/repos/trashkalmar/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/trashkalmar/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/trashkalmar/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trashkalmar/omim/labels{/name}","releases_url":"https://api.github.com/repos/trashkalmar/omim/releases{/id}","deployments_url":"https://api.github.com/repos/trashkalmar/omim/deployments","created_at":"2015-09-30T11:28:06Z","updated_at":"2016-01-14T16:18:44Z","pushed_at":"2016-04-01T10:18:59Z","git_url":"git://github.com/trashkalmar/omim.git","ssh_url":"git@github.com:trashkalmar/omim.git","clone_url":"https://github.com/trashkalmar/omim.git","svn_url":"https://github.com/trashkalmar/omim","homepage":null,"size":2271018,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:release-60","ref":"release-60","sha":"c9135f2cc1f445f5c5f2ef2adbb9131cf475152f","user":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"name":"omim","full_name":"mapsme/omim","owner":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapsme/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","deployments_url":"https://api.github.com/repos/mapsme/omim/deployments","created_at":"2015-09-20T02:57:13Z","updated_at":"2016-03-31T13:19:05Z","pushed_at":"2016-04-01T10:43:47Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":null,"size":2333902,"stargazers_count":1682,"watchers_count":1682,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":247,"mirror_url":null,"open_issues_count":121,"forks":247,"open_issues":121,"watchers":1682,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/2672"},"html":{"href":"https://github.com/mapsme/omim/pull/2672"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/2672"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/2672/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/2672/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/2672/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/5931fd8cfccb4eb7910f8307a138e8feba9b9c2f"}}}}