{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/15896","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/15896/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/15896/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/15896/events","html_url":"https://github.com/mantidproject/mantid/pull/15896","id":147997633,"number":15896,"title":"Function to calculate crystal field energies and intensities","user":{"login":"mantid-roman","id":1132713,"avatar_url":"https://avatars.githubusercontent.com/u/1132713?v=3","gravatar_id":"","url":"https://api.github.com/users/mantid-roman","html_url":"https://github.com/mantid-roman","followers_url":"https://api.github.com/users/mantid-roman/followers","following_url":"https://api.github.com/users/mantid-roman/following{/other_user}","gists_url":"https://api.github.com/users/mantid-roman/gists{/gist_id}","starred_url":"https://api.github.com/users/mantid-roman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantid-roman/subscriptions","organizations_url":"https://api.github.com/users/mantid-roman/orgs","repos_url":"https://api.github.com/users/mantid-roman/repos","events_url":"https://api.github.com/users/mantid-roman/events{/privacy}","received_events_url":"https://api.github.com/users/mantid-roman/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Fitting","name":"Component: Fitting","color":"009800"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Misc:%20Roadmap","name":"Misc: Roadmap","color":"5319e7"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Priority:%20High","name":"Priority: High","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/5","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.7","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/5/labels","id":1106939,"number":5,"title":"Release 3.7","description":"","creator":{"login":"peterfpeterson","id":404003,"avatar_url":"https://avatars.githubusercontent.com/u/404003?v=3","gravatar_id":"","url":"https://api.github.com/users/peterfpeterson","html_url":"https://github.com/peterfpeterson","followers_url":"https://api.github.com/users/peterfpeterson/followers","following_url":"https://api.github.com/users/peterfpeterson/following{/other_user}","gists_url":"https://api.github.com/users/peterfpeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/peterfpeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterfpeterson/subscriptions","organizations_url":"https://api.github.com/users/peterfpeterson/orgs","repos_url":"https://api.github.com/users/peterfpeterson/repos","events_url":"https://api.github.com/users/peterfpeterson/events{/privacy}","received_events_url":"https://api.github.com/users/peterfpeterson/received_events","type":"User","site_admin":false},"open_issues":588,"closed_issues":592,"state":"open","created_at":"2015-05-12T15:38:13Z","updated_at":"2016-04-20T15:31:18Z","due_on":"2016-06-05T23:00:00Z","closed_at":null},"comments":5,"created_at":"2016-04-13T09:16:39Z","updated_at":"2016-04-20T16:01:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/15896","html_url":"https://github.com/mantidproject/mantid/pull/15896","diff_url":"https://github.com/mantidproject/mantid/pull/15896.diff","patch_url":"https://github.com/mantidproject/mantid/pull/15896.patch"},"body":"Added a fitting function doing crystal field calculations. It is a new type of function in Mantid. To make it work a new interface `IFunctionGeneral` was added.\r\n\r\n**To test:**\r\n\r\nRun this script. The output is a table workspace with two columns: one for the peak positions and one for the intensities.\r\n\r\n```\r\n\tfun = 'name=CrystalFieldPeaks,Ion=Ce,Temperature=25.0,B20=0.37737,B22=3.9770,B40=-0.031787,B42=-0.11611,B44=-0.12544'\r\n\tEvaluateFunction(fun, None, OutputWorkspace='out')\r\n```\r\n\r\nFixes #15699.\r\n\r\nRelease notes will be updated when umbrella issue #15684 is finished.\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?\r\n- [ ] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] How do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant documentation been added/updated?\r\n- [ ] Is user-facing documentation written in a user-friendly manner?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it.\r\n"},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/212490382","html_url":"https://github.com/mantidproject/mantid/pull/15896#issuecomment-212490382","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/15896","id":212490382,"user":{"login":"mducle","id":14106963,"avatar_url":"https://avatars.githubusercontent.com/u/14106963?v=3","gravatar_id":"","url":"https://api.github.com/users/mducle","html_url":"https://github.com/mducle","followers_url":"https://api.github.com/users/mducle/followers","following_url":"https://api.github.com/users/mducle/following{/other_user}","gists_url":"https://api.github.com/users/mducle/gists{/gist_id}","starred_url":"https://api.github.com/users/mducle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mducle/subscriptions","organizations_url":"https://api.github.com/users/mducle/orgs","repos_url":"https://api.github.com/users/mducle/repos","events_url":"https://api.github.com/users/mducle/events{/privacy}","received_events_url":"https://api.github.com/users/mducle/received_events","type":"User","site_admin":false},"created_at":"2016-04-20T16:01:48Z","updated_at":"2016-04-20T16:01:48Z","body":"I'm happy!"}}