{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/81422234","pull_request_review_id":2406304,"id":81422234,"diff_hunk":"@@ -40,9 +40,11 @@ private[v1] class ApplicationListResource(uiRoot: UIRoot) {\n         status\n       }\n     }\n+\n+    val numApps = Option(limit).getOrElse(Integer.MAX_VALUE).asInstanceOf[Int]","path":"core/src/main/scala/org/apache/spark/status/api/v1/ApplicationListResource.scala","position":5,"original_position":5,"commit_id":"dc8146e7c9cb7d834340661cfb650f8997c2eab5","original_commit_id":"dc8146e7c9cb7d834340661cfb650f8997c2eab5","user":{"login":"srowen","id":822522,"avatar_url":"https://avatars.githubusercontent.com/u/822522?v=3","gravatar_id":"","url":"https://api.github.com/users/srowen","html_url":"https://github.com/srowen","followers_url":"https://api.github.com/users/srowen/followers","following_url":"https://api.github.com/users/srowen/following{/other_user}","gists_url":"https://api.github.com/users/srowen/gists{/gist_id}","starred_url":"https://api.github.com/users/srowen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srowen/subscriptions","organizations_url":"https://api.github.com/users/srowen/orgs","repos_url":"https://api.github.com/users/srowen/repos","events_url":"https://api.github.com/users/srowen/events{/privacy}","received_events_url":"https://api.github.com/users/srowen/received_events","type":"User","site_admin":false},"body":"Oh I see, this is weird because `limit` is a `java.lang.Integer`. I suggest `Option(limit).map(_.toInt).getOrElse(Int.MaxValue)` is a tiny bit better.","created_at":"2016-09-30T21:36:44Z","updated_at":"2016-09-30T21:38:29Z","html_url":"https://github.com/apache/spark/pull/15303#discussion_r81422234","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/15303","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/81422234"},"html":{"href":"https://github.com/apache/spark/pull/15303#discussion_r81422234"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/15303"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/15303","id":87392540,"html_url":"https://github.com/apache/spark/pull/15303","diff_url":"https://github.com/apache/spark/pull/15303.diff","patch_url":"https://github.com/apache/spark/pull/15303.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/15303","number":15303,"state":"open","locked":false,"title":"[SPARK-17671] Changed implementation of HistoryServer.getApplicationInfoList for lazy evaluation","user":{"login":"wgtmac","id":4684607,"avatar_url":"https://avatars.githubusercontent.com/u/4684607?v=3","gravatar_id":"","url":"https://api.github.com/users/wgtmac","html_url":"https://github.com/wgtmac","followers_url":"https://api.github.com/users/wgtmac/followers","following_url":"https://api.github.com/users/wgtmac/following{/other_user}","gists_url":"https://api.github.com/users/wgtmac/gists{/gist_id}","starred_url":"https://api.github.com/users/wgtmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wgtmac/subscriptions","organizations_url":"https://api.github.com/users/wgtmac/orgs","repos_url":"https://api.github.com/users/wgtmac/repos","events_url":"https://api.github.com/users/wgtmac/events{/privacy}","received_events_url":"https://api.github.com/users/wgtmac/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nChanged implementation of HistoryServer.getApplicationInfoList() to lazily evaluation the time-consuming transformation. In this way, ApplicationListResource can return an iterator without evaluating the whole input iterator.\r\n\r\n\r\n## How was this patch tested?\r\n\r\nNo API added. Just manual unit tests.\r\n\r\n","created_at":"2016-09-29T20:56:53Z","updated_at":"2016-09-30T21:38:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69d205c1cd84c96040d86a2496b768d4cb1ee619","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/15303/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/15303/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/15303/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/dc8146e7c9cb7d834340661cfb650f8997c2eab5","head":{"label":"wgtmac:SPARK-17671-merged","ref":"SPARK-17671-merged","sha":"dc8146e7c9cb7d834340661cfb650f8997c2eab5","user":{"login":"wgtmac","id":4684607,"avatar_url":"https://avatars.githubusercontent.com/u/4684607?v=3","gravatar_id":"","url":"https://api.github.com/users/wgtmac","html_url":"https://github.com/wgtmac","followers_url":"https://api.github.com/users/wgtmac/followers","following_url":"https://api.github.com/users/wgtmac/following{/other_user}","gists_url":"https://api.github.com/users/wgtmac/gists{/gist_id}","starred_url":"https://api.github.com/users/wgtmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wgtmac/subscriptions","organizations_url":"https://api.github.com/users/wgtmac/orgs","repos_url":"https://api.github.com/users/wgtmac/repos","events_url":"https://api.github.com/users/wgtmac/events{/privacy}","received_events_url":"https://api.github.com/users/wgtmac/received_events","type":"User","site_admin":false},"repo":{"id":52826553,"name":"spark","full_name":"wgtmac/spark","owner":{"login":"wgtmac","id":4684607,"avatar_url":"https://avatars.githubusercontent.com/u/4684607?v=3","gravatar_id":"","url":"https://api.github.com/users/wgtmac","html_url":"https://github.com/wgtmac","followers_url":"https://api.github.com/users/wgtmac/followers","following_url":"https://api.github.com/users/wgtmac/following{/other_user}","gists_url":"https://api.github.com/users/wgtmac/gists{/gist_id}","starred_url":"https://api.github.com/users/wgtmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wgtmac/subscriptions","organizations_url":"https://api.github.com/users/wgtmac/orgs","repos_url":"https://api.github.com/users/wgtmac/repos","events_url":"https://api.github.com/users/wgtmac/events{/privacy}","received_events_url":"https://api.github.com/users/wgtmac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wgtmac/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/wgtmac/spark","forks_url":"https://api.github.com/repos/wgtmac/spark/forks","keys_url":"https://api.github.com/repos/wgtmac/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wgtmac/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wgtmac/spark/teams","hooks_url":"https://api.github.com/repos/wgtmac/spark/hooks","issue_events_url":"https://api.github.com/repos/wgtmac/spark/issues/events{/number}","events_url":"https://api.github.com/repos/wgtmac/spark/events","assignees_url":"https://api.github.com/repos/wgtmac/spark/assignees{/user}","branches_url":"https://api.github.com/repos/wgtmac/spark/branches{/branch}","tags_url":"https://api.github.com/repos/wgtmac/spark/tags","blobs_url":"https://api.github.com/repos/wgtmac/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wgtmac/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wgtmac/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/wgtmac/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wgtmac/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/wgtmac/spark/languages","stargazers_url":"https://api.github.com/repos/wgtmac/spark/stargazers","contributors_url":"https://api.github.com/repos/wgtmac/spark/contributors","subscribers_url":"https://api.github.com/repos/wgtmac/spark/subscribers","subscription_url":"https://api.github.com/repos/wgtmac/spark/subscription","commits_url":"https://api.github.com/repos/wgtmac/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/wgtmac/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/wgtmac/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/wgtmac/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/wgtmac/spark/contents/{+path}","compare_url":"https://api.github.com/repos/wgtmac/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wgtmac/spark/merges","archive_url":"https://api.github.com/repos/wgtmac/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wgtmac/spark/downloads","issues_url":"https://api.github.com/repos/wgtmac/spark/issues{/number}","pulls_url":"https://api.github.com/repos/wgtmac/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/wgtmac/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/wgtmac/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wgtmac/spark/labels{/name}","releases_url":"https://api.github.com/repos/wgtmac/spark/releases{/id}","deployments_url":"https://api.github.com/repos/wgtmac/spark/deployments","created_at":"2016-02-29T21:36:47Z","updated_at":"2016-02-29T21:37:13Z","pushed_at":"2016-09-30T20:01:36Z","git_url":"git://github.com/wgtmac/spark.git","ssh_url":"git@github.com:wgtmac/spark.git","clone_url":"https://github.com/wgtmac/spark.git","svn_url":"https://github.com/wgtmac/spark","homepage":null,"size":176013,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"fe33121a53384811a8e094ab6c05dc85b7c7ca87","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-09-30T17:23:45Z","pushed_at":"2016-09-30T21:23:18Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":524767,"stargazers_count":10214,"watchers_count":10214,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9501,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":486,"forks":9501,"open_issues":486,"watchers":10214,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/15303"},"html":{"href":"https://github.com/apache/spark/pull/15303"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/15303"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/15303/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/15303/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/15303/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/dc8146e7c9cb7d834340661cfb650f8997c2eab5"}}}}
{"actor":{"display_login":"srowen"}}