{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/53853922","id":53853922,"diff_hunk":"@@ -21,14 +21,15 @@ let\n       username: ${cfg.databaseUsername}\n       encoding: utf8\n   '';\n+\n   gitlabShellYml = ''\n-    user: gitlab\n-    gitlab_url: \"http://${cfg.host}:${toString cfg.port}/\"\n+    user: ${cfg.user}\n+    gitlab_url: \"http://localhost:8080/\"","path":"nixos/modules/services/misc/gitlab.nix","position":9,"original_position":9,"commit_id":"a26d00b9caaa84509a0bc7d3e2fca20b971aa87b","original_commit_id":"a26d00b9caaa84509a0bc7d3e2fca20b971aa87b","user":{"login":"zimbatm","id":3248,"avatar_url":"https://avatars.githubusercontent.com/u/3248?v=3","gravatar_id":"","url":"https://api.github.com/users/zimbatm","html_url":"https://github.com/zimbatm","followers_url":"https://api.github.com/users/zimbatm/followers","following_url":"https://api.github.com/users/zimbatm/following{/other_user}","gists_url":"https://api.github.com/users/zimbatm/gists{/gist_id}","starred_url":"https://api.github.com/users/zimbatm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimbatm/subscriptions","organizations_url":"https://api.github.com/users/zimbatm/orgs","repos_url":"https://api.github.com/users/zimbatm/repos","events_url":"https://api.github.com/users/zimbatm/events{/privacy}","received_events_url":"https://api.github.com/users/zimbatm/received_events","type":"User","site_admin":false},"body":"Is this true, http://localhost:8080 is a constant ?","created_at":"2016-02-23T21:34:12Z","updated_at":"2016-02-23T21:34:12Z","html_url":"https://github.com/NixOS/nixpkgs/pull/13396#discussion_r53853922","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13396","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/53853922"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/13396#discussion_r53853922"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13396"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13396","id":60375488,"html_url":"https://github.com/NixOS/nixpkgs/pull/13396","diff_url":"https://github.com/NixOS/nixpkgs/pull/13396.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/13396.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/13396","number":13396,"state":"open","locked":false,"title":"gitlab: 8.0.5 -> 8.5.0, service improvements","user":{"login":"fpletz","id":114159,"avatar_url":"https://avatars.githubusercontent.com/u/114159?v=3","gravatar_id":"","url":"https://api.github.com/users/fpletz","html_url":"https://github.com/fpletz","followers_url":"https://api.github.com/users/fpletz/followers","following_url":"https://api.github.com/users/fpletz/following{/other_user}","gists_url":"https://api.github.com/users/fpletz/gists{/gist_id}","starred_url":"https://api.github.com/users/fpletz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpletz/subscriptions","organizations_url":"https://api.github.com/users/fpletz/orgs","repos_url":"https://api.github.com/users/fpletz/repos","events_url":"https://api.github.com/users/fpletz/events{/privacy}","received_events_url":"https://api.github.com/users/fpletz/received_events","type":"User","site_admin":false},"body":"###### Things done:\r\n- [x] Tested via `nix.useChroot`.\r\n- [x] Built on platform(s): x86_64\r\n- [x] Tested compilation of all pkgs that depend on this change: none\r\n- [x] Tested execution of binary products.\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\ncc @roblabla @cstrahan\r\n\r\n---\r\n\r\nUpdates gitlab to the current stable version and fixes a lot of features that\r\nwere broken, at least with the current version and our configuration.\r\n\r\nQuite a lot of sweat and tears has gone into testing nearly all features and\r\nreading/patching the Gitlab source as we're about to deploy gitlab for our\r\nwhole company.\r\n\r\nThings to note:\r\n\r\n * The gitlab config is now written as a nix attribute set and will be\r\n   converted to JSON. Gitlab uses YAML but JSON is a subset of YAML.\r\n   The `extraConfig` opition is also an attribute set that will be merged\r\n   with the default config. This way *all* Gitlab options are supported.\r\n\r\n * Some paths like uploads and configs are hardcoded in rails  (at least\r\n   after my study of the Gitlab source). This is why they are linked from\r\n   the Gitlab root to /run/gitlab and then linked to the  configurable\r\n   `statePath`.\r\n\r\n * Backup & restore should work out of the box from another Gitlab instance.\r\n\r\n * gitlab-git-http-server has been replaced by gitlab-workhorse upstream.\r\n   Push & pull over HTTPS works perfectly. Communication to gitlab is done\r\n   over unix sockets. An HTTP server is required to proxy requests to\r\n   gitlab-workhorse over another unix socket at\r\n   `/run/gitlab/gitlab-workhorse.socket`.\r\n\r\n * The user & group running gitlab are now configurable. These can even be\r\n   changed for live instances.\r\n\r\n * The initial email address & password of the root user can be configured.","created_at":"2016-02-23T17:16:36Z","updated_at":"2016-02-23T21:34:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d408275a35968fc58417235c2952ac5a0584fad","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13396/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13396/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/13396/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/a26d00b9caaa84509a0bc7d3e2fca20b971aa87b","head":{"label":"mayflower:pkg/gitlab","ref":"pkg/gitlab","sha":"a26d00b9caaa84509a0bc7d3e2fca20b971aa87b","user":{"login":"mayflower","id":536878,"avatar_url":"https://avatars.githubusercontent.com/u/536878?v=3","gravatar_id":"","url":"https://api.github.com/users/mayflower","html_url":"https://github.com/mayflower","followers_url":"https://api.github.com/users/mayflower/followers","following_url":"https://api.github.com/users/mayflower/following{/other_user}","gists_url":"https://api.github.com/users/mayflower/gists{/gist_id}","starred_url":"https://api.github.com/users/mayflower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mayflower/subscriptions","organizations_url":"https://api.github.com/users/mayflower/orgs","repos_url":"https://api.github.com/users/mayflower/repos","events_url":"https://api.github.com/users/mayflower/events{/privacy}","received_events_url":"https://api.github.com/users/mayflower/received_events","type":"Organization","site_admin":false},"repo":{"id":37146411,"name":"nixpkgs","full_name":"mayflower/nixpkgs","owner":{"login":"mayflower","id":536878,"avatar_url":"https://avatars.githubusercontent.com/u/536878?v=3","gravatar_id":"","url":"https://api.github.com/users/mayflower","html_url":"https://github.com/mayflower","followers_url":"https://api.github.com/users/mayflower/followers","following_url":"https://api.github.com/users/mayflower/following{/other_user}","gists_url":"https://api.github.com/users/mayflower/gists{/gist_id}","starred_url":"https://api.github.com/users/mayflower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mayflower/subscriptions","organizations_url":"https://api.github.com/users/mayflower/orgs","repos_url":"https://api.github.com/users/mayflower/repos","events_url":"https://api.github.com/users/mayflower/events{/privacy}","received_events_url":"https://api.github.com/users/mayflower/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mayflower/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/mayflower/nixpkgs","forks_url":"https://api.github.com/repos/mayflower/nixpkgs/forks","keys_url":"https://api.github.com/repos/mayflower/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mayflower/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mayflower/nixpkgs/teams","hooks_url":"https://api.github.com/repos/mayflower/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/mayflower/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/mayflower/nixpkgs/events","assignees_url":"https://api.github.com/repos/mayflower/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/mayflower/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/mayflower/nixpkgs/tags","blobs_url":"https://api.github.com/repos/mayflower/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mayflower/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mayflower/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mayflower/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mayflower/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/mayflower/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/mayflower/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/mayflower/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/mayflower/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/mayflower/nixpkgs/subscription","commits_url":"https://api.github.com/repos/mayflower/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mayflower/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mayflower/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mayflower/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mayflower/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/mayflower/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mayflower/nixpkgs/merges","archive_url":"https://api.github.com/repos/mayflower/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mayflower/nixpkgs/downloads","issues_url":"https://api.github.com/repos/mayflower/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/mayflower/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/mayflower/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/mayflower/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mayflower/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/mayflower/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/mayflower/nixpkgs/deployments","created_at":"2015-06-09T17:14:09Z","updated_at":"2016-01-11T06:27:57Z","pushed_at":"2016-02-23T17:24:17Z","git_url":"git://github.com/mayflower/nixpkgs.git","ssh_url":"git@github.com:mayflower/nixpkgs.git","clone_url":"https://github.com/mayflower/nixpkgs.git","svn_url":"https://github.com/mayflower/nixpkgs","homepage":null,"size":315278,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"d9d6a92d5eb6957b6987ee22e957f1b725966653","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2016-02-23T09:10:10Z","pushed_at":"2016-02-23T21:32:11Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":351343,"stargazers_count":959,"watchers_count":959,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1280,"mirror_url":null,"open_issues_count":1427,"forks":1280,"open_issues":1427,"watchers":959,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13396"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/13396"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/13396"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/13396/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13396/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/13396/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/a26d00b9caaa84509a0bc7d3e2fca20b971aa87b"}}}}