{"action":"created","comment":{"url":"https://api.github.com/repos/sourcegraph/appdash/pulls/comments/54549973","id":54549973,"diff_hunk":"@@ -123,6 +138,10 @@ func (cc *ChunkedCollector) Flush() error {\n \t\tif err := cc.Collector.Collect(spanID, p...); err != nil {","path":"collector.go","position":37,"original_position":37,"commit_id":"739470391eb2bdaa74b299326b2c5d491ef9a40f","original_commit_id":"739470391eb2bdaa74b299326b2c5d491ef9a40f","user":{"login":"keegancsmith","id":187831,"avatar_url":"https://avatars.githubusercontent.com/u/187831?v=3","gravatar_id":"","url":"https://api.github.com/users/keegancsmith","html_url":"https://github.com/keegancsmith","followers_url":"https://api.github.com/users/keegancsmith/followers","following_url":"https://api.github.com/users/keegancsmith/following{/other_user}","gists_url":"https://api.github.com/users/keegancsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/keegancsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keegancsmith/subscriptions","organizations_url":"https://api.github.com/users/keegancsmith/orgs","repos_url":"https://api.github.com/users/keegancsmith/repos","events_url":"https://api.github.com/users/keegancsmith/events{/privacy}","received_events_url":"https://api.github.com/users/keegancsmith/received_events","type":"User","site_admin":false},"body":"You should document the interaction between MinInterval and FlushTimeout","created_at":"2016-03-01T10:44:34Z","updated_at":"2016-03-01T10:44:34Z","html_url":"https://github.com/sourcegraph/appdash/pull/113#discussion_r54549973","pull_request_url":"https://api.github.com/repos/sourcegraph/appdash/pulls/113","_links":{"self":{"href":"https://api.github.com/repos/sourcegraph/appdash/pulls/comments/54549973"},"html":{"href":"https://github.com/sourcegraph/appdash/pull/113#discussion_r54549973"},"pull_request":{"href":"https://api.github.com/repos/sourcegraph/appdash/pulls/113"}}},"pull_request":{"url":"https://api.github.com/repos/sourcegraph/appdash/pulls/113","id":61195487,"html_url":"https://github.com/sourcegraph/appdash/pull/113","diff_url":"https://github.com/sourcegraph/appdash/pull/113.diff","patch_url":"https://github.com/sourcegraph/appdash/pull/113.patch","issue_url":"https://api.github.com/repos/sourcegraph/appdash/issues/113","number":113,"state":"open","locked":false,"title":"add a FlushTimeout field to ChunkedCollector to prevent memory consumption","user":{"login":"slimsag","id":3173176,"avatar_url":"https://avatars.githubusercontent.com/u/3173176?v=3","gravatar_id":"","url":"https://api.github.com/users/slimsag","html_url":"https://github.com/slimsag","followers_url":"https://api.github.com/users/slimsag/followers","following_url":"https://api.github.com/users/slimsag/following{/other_user}","gists_url":"https://api.github.com/users/slimsag/gists{/gist_id}","starred_url":"https://api.github.com/users/slimsag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slimsag/subscriptions","organizations_url":"https://api.github.com/users/slimsag/orgs","repos_url":"https://api.github.com/users/slimsag/repos","events_url":"https://api.github.com/users/slimsag/events{/privacy}","received_events_url":"https://api.github.com/users/slimsag/received_events","type":"User","site_admin":false},"body":"This change adds a FlushTimeout field to ChunkedCollector which can be used to prevent a large queue from building up within the ChunkedCollector, effectively leaking/consuming large amounts of memory, due to an misbehaving underlying collector (like RemoteCollector, which would attempt to reconnect to a flaky remote server upon each collection).\r\n\r\n/cc @neelance @keegancsmith ","created_at":"2016-03-01T05:35:15Z","updated_at":"2016-03-01T10:44:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d13dc1b83803734e69019c679c7d83ad85c0801","assignee":{"login":"shurcooL","id":1924134,"avatar_url":"https://avatars.githubusercontent.com/u/1924134?v=3","gravatar_id":"","url":"https://api.github.com/users/shurcooL","html_url":"https://github.com/shurcooL","followers_url":"https://api.github.com/users/shurcooL/followers","following_url":"https://api.github.com/users/shurcooL/following{/other_user}","gists_url":"https://api.github.com/users/shurcooL/gists{/gist_id}","starred_url":"https://api.github.com/users/shurcooL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shurcooL/subscriptions","organizations_url":"https://api.github.com/users/shurcooL/orgs","repos_url":"https://api.github.com/users/shurcooL/repos","events_url":"https://api.github.com/users/shurcooL/events{/privacy}","received_events_url":"https://api.github.com/users/shurcooL/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/sourcegraph/appdash/pulls/113/commits","review_comments_url":"https://api.github.com/repos/sourcegraph/appdash/pulls/113/comments","review_comment_url":"https://api.github.com/repos/sourcegraph/appdash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sourcegraph/appdash/issues/113/comments","statuses_url":"https://api.github.com/repos/sourcegraph/appdash/statuses/739470391eb2bdaa74b299326b2c5d491ef9a40f","head":{"label":"sourcegraph:sg/flush-timeout","ref":"sg/flush-timeout","sha":"739470391eb2bdaa74b299326b2c5d491ef9a40f","user":{"login":"sourcegraph","id":3979584,"avatar_url":"https://avatars.githubusercontent.com/u/3979584?v=3","gravatar_id":"","url":"https://api.github.com/users/sourcegraph","html_url":"https://github.com/sourcegraph","followers_url":"https://api.github.com/users/sourcegraph/followers","following_url":"https://api.github.com/users/sourcegraph/following{/other_user}","gists_url":"https://api.github.com/users/sourcegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcegraph/subscriptions","organizations_url":"https://api.github.com/users/sourcegraph/orgs","repos_url":"https://api.github.com/users/sourcegraph/repos","events_url":"https://api.github.com/users/sourcegraph/events{/privacy}","received_events_url":"https://api.github.com/users/sourcegraph/received_events","type":"Organization","site_admin":false},"repo":{"id":26996090,"name":"appdash","full_name":"sourcegraph/appdash","owner":{"login":"sourcegraph","id":3979584,"avatar_url":"https://avatars.githubusercontent.com/u/3979584?v=3","gravatar_id":"","url":"https://api.github.com/users/sourcegraph","html_url":"https://github.com/sourcegraph","followers_url":"https://api.github.com/users/sourcegraph/followers","following_url":"https://api.github.com/users/sourcegraph/following{/other_user}","gists_url":"https://api.github.com/users/sourcegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcegraph/subscriptions","organizations_url":"https://api.github.com/users/sourcegraph/orgs","repos_url":"https://api.github.com/users/sourcegraph/repos","events_url":"https://api.github.com/users/sourcegraph/events{/privacy}","received_events_url":"https://api.github.com/users/sourcegraph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sourcegraph/appdash","description":"Application tracing system for Go, based on Google's Dapper. Formerly known as apptrace.","fork":false,"url":"https://api.github.com/repos/sourcegraph/appdash","forks_url":"https://api.github.com/repos/sourcegraph/appdash/forks","keys_url":"https://api.github.com/repos/sourcegraph/appdash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sourcegraph/appdash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sourcegraph/appdash/teams","hooks_url":"https://api.github.com/repos/sourcegraph/appdash/hooks","issue_events_url":"https://api.github.com/repos/sourcegraph/appdash/issues/events{/number}","events_url":"https://api.github.com/repos/sourcegraph/appdash/events","assignees_url":"https://api.github.com/repos/sourcegraph/appdash/assignees{/user}","branches_url":"https://api.github.com/repos/sourcegraph/appdash/branches{/branch}","tags_url":"https://api.github.com/repos/sourcegraph/appdash/tags","blobs_url":"https://api.github.com/repos/sourcegraph/appdash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sourcegraph/appdash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sourcegraph/appdash/git/refs{/sha}","trees_url":"https://api.github.com/repos/sourcegraph/appdash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sourcegraph/appdash/statuses/{sha}","languages_url":"https://api.github.com/repos/sourcegraph/appdash/languages","stargazers_url":"https://api.github.com/repos/sourcegraph/appdash/stargazers","contributors_url":"https://api.github.com/repos/sourcegraph/appdash/contributors","subscribers_url":"https://api.github.com/repos/sourcegraph/appdash/subscribers","subscription_url":"https://api.github.com/repos/sourcegraph/appdash/subscription","commits_url":"https://api.github.com/repos/sourcegraph/appdash/commits{/sha}","git_commits_url":"https://api.github.com/repos/sourcegraph/appdash/git/commits{/sha}","comments_url":"https://api.github.com/repos/sourcegraph/appdash/comments{/number}","issue_comment_url":"https://api.github.com/repos/sourcegraph/appdash/issues/comments{/number}","contents_url":"https://api.github.com/repos/sourcegraph/appdash/contents/{+path}","compare_url":"https://api.github.com/repos/sourcegraph/appdash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sourcegraph/appdash/merges","archive_url":"https://api.github.com/repos/sourcegraph/appdash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sourcegraph/appdash/downloads","issues_url":"https://api.github.com/repos/sourcegraph/appdash/issues{/number}","pulls_url":"https://api.github.com/repos/sourcegraph/appdash/pulls{/number}","milestones_url":"https://api.github.com/repos/sourcegraph/appdash/milestones{/number}","notifications_url":"https://api.github.com/repos/sourcegraph/appdash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sourcegraph/appdash/labels{/name}","releases_url":"https://api.github.com/repos/sourcegraph/appdash/releases{/id}","deployments_url":"https://api.github.com/repos/sourcegraph/appdash/deployments","created_at":"2014-11-22T10:47:38Z","updated_at":"2016-02-29T21:30:24Z","pushed_at":"2016-03-01T05:35:15Z","git_url":"git://github.com/sourcegraph/appdash.git","ssh_url":"git@github.com:sourcegraph/appdash.git","clone_url":"https://github.com/sourcegraph/appdash.git","svn_url":"https://github.com/sourcegraph/appdash","homepage":"https://sourcegraph.com/sourcegraph/appdash","size":583,"stargazers_count":399,"watchers_count":399,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":11,"forks":26,"open_issues":11,"watchers":399,"default_branch":"master"}},"base":{"label":"sourcegraph:master","ref":"master","sha":"b66bf440f5f10774f883be87adb4b9ce6d3e3771","user":{"login":"sourcegraph","id":3979584,"avatar_url":"https://avatars.githubusercontent.com/u/3979584?v=3","gravatar_id":"","url":"https://api.github.com/users/sourcegraph","html_url":"https://github.com/sourcegraph","followers_url":"https://api.github.com/users/sourcegraph/followers","following_url":"https://api.github.com/users/sourcegraph/following{/other_user}","gists_url":"https://api.github.com/users/sourcegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcegraph/subscriptions","organizations_url":"https://api.github.com/users/sourcegraph/orgs","repos_url":"https://api.github.com/users/sourcegraph/repos","events_url":"https://api.github.com/users/sourcegraph/events{/privacy}","received_events_url":"https://api.github.com/users/sourcegraph/received_events","type":"Organization","site_admin":false},"repo":{"id":26996090,"name":"appdash","full_name":"sourcegraph/appdash","owner":{"login":"sourcegraph","id":3979584,"avatar_url":"https://avatars.githubusercontent.com/u/3979584?v=3","gravatar_id":"","url":"https://api.github.com/users/sourcegraph","html_url":"https://github.com/sourcegraph","followers_url":"https://api.github.com/users/sourcegraph/followers","following_url":"https://api.github.com/users/sourcegraph/following{/other_user}","gists_url":"https://api.github.com/users/sourcegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcegraph/subscriptions","organizations_url":"https://api.github.com/users/sourcegraph/orgs","repos_url":"https://api.github.com/users/sourcegraph/repos","events_url":"https://api.github.com/users/sourcegraph/events{/privacy}","received_events_url":"https://api.github.com/users/sourcegraph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sourcegraph/appdash","description":"Application tracing system for Go, based on Google's Dapper. Formerly known as apptrace.","fork":false,"url":"https://api.github.com/repos/sourcegraph/appdash","forks_url":"https://api.github.com/repos/sourcegraph/appdash/forks","keys_url":"https://api.github.com/repos/sourcegraph/appdash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sourcegraph/appdash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sourcegraph/appdash/teams","hooks_url":"https://api.github.com/repos/sourcegraph/appdash/hooks","issue_events_url":"https://api.github.com/repos/sourcegraph/appdash/issues/events{/number}","events_url":"https://api.github.com/repos/sourcegraph/appdash/events","assignees_url":"https://api.github.com/repos/sourcegraph/appdash/assignees{/user}","branches_url":"https://api.github.com/repos/sourcegraph/appdash/branches{/branch}","tags_url":"https://api.github.com/repos/sourcegraph/appdash/tags","blobs_url":"https://api.github.com/repos/sourcegraph/appdash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sourcegraph/appdash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sourcegraph/appdash/git/refs{/sha}","trees_url":"https://api.github.com/repos/sourcegraph/appdash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sourcegraph/appdash/statuses/{sha}","languages_url":"https://api.github.com/repos/sourcegraph/appdash/languages","stargazers_url":"https://api.github.com/repos/sourcegraph/appdash/stargazers","contributors_url":"https://api.github.com/repos/sourcegraph/appdash/contributors","subscribers_url":"https://api.github.com/repos/sourcegraph/appdash/subscribers","subscription_url":"https://api.github.com/repos/sourcegraph/appdash/subscription","commits_url":"https://api.github.com/repos/sourcegraph/appdash/commits{/sha}","git_commits_url":"https://api.github.com/repos/sourcegraph/appdash/git/commits{/sha}","comments_url":"https://api.github.com/repos/sourcegraph/appdash/comments{/number}","issue_comment_url":"https://api.github.com/repos/sourcegraph/appdash/issues/comments{/number}","contents_url":"https://api.github.com/repos/sourcegraph/appdash/contents/{+path}","compare_url":"https://api.github.com/repos/sourcegraph/appdash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sourcegraph/appdash/merges","archive_url":"https://api.github.com/repos/sourcegraph/appdash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sourcegraph/appdash/downloads","issues_url":"https://api.github.com/repos/sourcegraph/appdash/issues{/number}","pulls_url":"https://api.github.com/repos/sourcegraph/appdash/pulls{/number}","milestones_url":"https://api.github.com/repos/sourcegraph/appdash/milestones{/number}","notifications_url":"https://api.github.com/repos/sourcegraph/appdash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sourcegraph/appdash/labels{/name}","releases_url":"https://api.github.com/repos/sourcegraph/appdash/releases{/id}","deployments_url":"https://api.github.com/repos/sourcegraph/appdash/deployments","created_at":"2014-11-22T10:47:38Z","updated_at":"2016-02-29T21:30:24Z","pushed_at":"2016-03-01T05:35:15Z","git_url":"git://github.com/sourcegraph/appdash.git","ssh_url":"git@github.com:sourcegraph/appdash.git","clone_url":"https://github.com/sourcegraph/appdash.git","svn_url":"https://github.com/sourcegraph/appdash","homepage":"https://sourcegraph.com/sourcegraph/appdash","size":583,"stargazers_count":399,"watchers_count":399,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":11,"forks":26,"open_issues":11,"watchers":399,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sourcegraph/appdash/pulls/113"},"html":{"href":"https://github.com/sourcegraph/appdash/pull/113"},"issue":{"href":"https://api.github.com/repos/sourcegraph/appdash/issues/113"},"comments":{"href":"https://api.github.com/repos/sourcegraph/appdash/issues/113/comments"},"review_comments":{"href":"https://api.github.com/repos/sourcegraph/appdash/pulls/113/comments"},"review_comment":{"href":"https://api.github.com/repos/sourcegraph/appdash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sourcegraph/appdash/pulls/113/commits"},"statuses":{"href":"https://api.github.com/repos/sourcegraph/appdash/statuses/739470391eb2bdaa74b299326b2c5d491ef9a40f"}}}}