{"action":"created","comment":{"url":"https://api.github.com/repos/OPM/opm-simulators/pulls/comments/88426266","pull_request_review_id":8998527,"id":88426266,"diff_hunk":"@@ -367,10 +403,10 @@ namespace Opm\n                 }\n \n                 // write all cell data registered in local state\n-\t\tfor (const auto& pair : localState_.cellData()) {","path":"opm/autodiff/ParallelDebugOutput.hpp","position":131,"original_position":131,"commit_id":"80bbabc0b6e4034810c72710c3d049f9be20ba9a","original_commit_id":"80bbabc0b6e4034810c72710c3d049f9be20ba9a","user":{"login":"blattms","id":1944640,"avatar_url":"https://avatars.githubusercontent.com/u/1944640?v=3","gravatar_id":"","url":"https://api.github.com/users/blattms","html_url":"https://github.com/blattms","followers_url":"https://api.github.com/users/blattms/followers","following_url":"https://api.github.com/users/blattms/following{/other_user}","gists_url":"https://api.github.com/users/blattms/gists{/gist_id}","starred_url":"https://api.github.com/users/blattms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blattms/subscriptions","organizations_url":"https://api.github.com/users/blattms/orgs","repos_url":"https://api.github.com/users/blattms/repos","events_url":"https://api.github.com/users/blattms/events{/privacy}","received_events_url":"https://api.github.com/users/blattms/received_events","type":"User","site_admin":false},"body":"Yes that is intended as all the array are in cellData anyway. After gathering the data we extract that data from `globalCellData_` to `globalState_` using `solutionToSim`.\r\n\r\nAlso note that the globalState_ is only needed to support rudimentary matlab ouput in a parallel run. This output is (and was always) broken as the velocities will be wrong.","created_at":"2016-11-17T10:35:00Z","updated_at":"2016-11-17T10:35:00Z","html_url":"https://github.com/OPM/opm-simulators/pull/929#discussion_r88426266","pull_request_url":"https://api.github.com/repos/OPM/opm-simulators/pulls/929","_links":{"self":{"href":"https://api.github.com/repos/OPM/opm-simulators/pulls/comments/88426266"},"html":{"href":"https://github.com/OPM/opm-simulators/pull/929#discussion_r88426266"},"pull_request":{"href":"https://api.github.com/repos/OPM/opm-simulators/pulls/929"}}},"pull_request":{"url":"https://api.github.com/repos/OPM/opm-simulators/pulls/929","id":94047191,"html_url":"https://github.com/OPM/opm-simulators/pull/929","diff_url":"https://github.com/OPM/opm-simulators/pull/929.diff","patch_url":"https://github.com/OPM/opm-simulators/pull/929.patch","issue_url":"https://api.github.com/repos/OPM/opm-simulators/issues/929","number":929,"state":"open","locked":false,"title":"Allow output for user requested data in parallel runs.","user":{"login":"blattms","id":1944640,"avatar_url":"https://avatars.githubusercontent.com/u/1944640?v=3","gravatar_id":"","url":"https://api.github.com/users/blattms","html_url":"https://github.com/blattms","followers_url":"https://api.github.com/users/blattms/followers","following_url":"https://api.github.com/users/blattms/following{/other_user}","gists_url":"https://api.github.com/users/blattms/gists{/gist_id}","starred_url":"https://api.github.com/users/blattms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blattms/subscriptions","organizations_url":"https://api.github.com/users/blattms/orgs","repos_url":"https://api.github.com/users/blattms/repos","events_url":"https://api.github.com/users/blattms/events{/privacy}","received_events_url":"https://api.github.com/users/blattms/received_events","type":"User","site_admin":false},"body":"This PR further aligns parallel output with the one done in a serial. Previously outputting data in addition to the cell data registered with in `SimulationDataContainer` was not possible in a parallel run. Now we use the `data::Solution` map when gathering data. As this also gets the user requested cell data, we output this in parallel now, too.\r\n\r\nNorne seems to run fine. Will test with Model 2 also.","created_at":"2016-11-16T20:50:15Z","updated_at":"2016-11-17T10:35:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c68554b6a8adba0d5e489d660f3b1056e84b6ea","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OPM/opm-simulators/pulls/929/commits","review_comments_url":"https://api.github.com/repos/OPM/opm-simulators/pulls/929/comments","review_comment_url":"https://api.github.com/repos/OPM/opm-simulators/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OPM/opm-simulators/issues/929/comments","statuses_url":"https://api.github.com/repos/OPM/opm-simulators/statuses/80bbabc0b6e4034810c72710c3d049f9be20ba9a","head":{"label":"blattms:flexible-parallel-ouput","ref":"flexible-parallel-ouput","sha":"80bbabc0b6e4034810c72710c3d049f9be20ba9a","user":{"login":"blattms","id":1944640,"avatar_url":"https://avatars.githubusercontent.com/u/1944640?v=3","gravatar_id":"","url":"https://api.github.com/users/blattms","html_url":"https://github.com/blattms","followers_url":"https://api.github.com/users/blattms/followers","following_url":"https://api.github.com/users/blattms/following{/other_user}","gists_url":"https://api.github.com/users/blattms/gists{/gist_id}","starred_url":"https://api.github.com/users/blattms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blattms/subscriptions","organizations_url":"https://api.github.com/users/blattms/orgs","repos_url":"https://api.github.com/users/blattms/repos","events_url":"https://api.github.com/users/blattms/events{/privacy}","received_events_url":"https://api.github.com/users/blattms/received_events","type":"User","site_admin":false},"repo":{"id":15934062,"name":"opm-simulators","full_name":"blattms/opm-simulators","owner":{"login":"blattms","id":1944640,"avatar_url":"https://avatars.githubusercontent.com/u/1944640?v=3","gravatar_id":"","url":"https://api.github.com/users/blattms","html_url":"https://github.com/blattms","followers_url":"https://api.github.com/users/blattms/followers","following_url":"https://api.github.com/users/blattms/following{/other_user}","gists_url":"https://api.github.com/users/blattms/gists{/gist_id}","starred_url":"https://api.github.com/users/blattms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blattms/subscriptions","organizations_url":"https://api.github.com/users/blattms/orgs","repos_url":"https://api.github.com/users/blattms/repos","events_url":"https://api.github.com/users/blattms/events{/privacy}","received_events_url":"https://api.github.com/users/blattms/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blattms/opm-simulators","description":"Utilities for automatic differentiation and simulators based on AD.","fork":true,"url":"https://api.github.com/repos/blattms/opm-simulators","forks_url":"https://api.github.com/repos/blattms/opm-simulators/forks","keys_url":"https://api.github.com/repos/blattms/opm-simulators/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blattms/opm-simulators/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blattms/opm-simulators/teams","hooks_url":"https://api.github.com/repos/blattms/opm-simulators/hooks","issue_events_url":"https://api.github.com/repos/blattms/opm-simulators/issues/events{/number}","events_url":"https://api.github.com/repos/blattms/opm-simulators/events","assignees_url":"https://api.github.com/repos/blattms/opm-simulators/assignees{/user}","branches_url":"https://api.github.com/repos/blattms/opm-simulators/branches{/branch}","tags_url":"https://api.github.com/repos/blattms/opm-simulators/tags","blobs_url":"https://api.github.com/repos/blattms/opm-simulators/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blattms/opm-simulators/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blattms/opm-simulators/git/refs{/sha}","trees_url":"https://api.github.com/repos/blattms/opm-simulators/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blattms/opm-simulators/statuses/{sha}","languages_url":"https://api.github.com/repos/blattms/opm-simulators/languages","stargazers_url":"https://api.github.com/repos/blattms/opm-simulators/stargazers","contributors_url":"https://api.github.com/repos/blattms/opm-simulators/contributors","subscribers_url":"https://api.github.com/repos/blattms/opm-simulators/subscribers","subscription_url":"https://api.github.com/repos/blattms/opm-simulators/subscription","commits_url":"https://api.github.com/repos/blattms/opm-simulators/commits{/sha}","git_commits_url":"https://api.github.com/repos/blattms/opm-simulators/git/commits{/sha}","comments_url":"https://api.github.com/repos/blattms/opm-simulators/comments{/number}","issue_comment_url":"https://api.github.com/repos/blattms/opm-simulators/issues/comments{/number}","contents_url":"https://api.github.com/repos/blattms/opm-simulators/contents/{+path}","compare_url":"https://api.github.com/repos/blattms/opm-simulators/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blattms/opm-simulators/merges","archive_url":"https://api.github.com/repos/blattms/opm-simulators/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blattms/opm-simulators/downloads","issues_url":"https://api.github.com/repos/blattms/opm-simulators/issues{/number}","pulls_url":"https://api.github.com/repos/blattms/opm-simulators/pulls{/number}","milestones_url":"https://api.github.com/repos/blattms/opm-simulators/milestones{/number}","notifications_url":"https://api.github.com/repos/blattms/opm-simulators/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blattms/opm-simulators/labels{/name}","releases_url":"https://api.github.com/repos/blattms/opm-simulators/releases{/id}","deployments_url":"https://api.github.com/repos/blattms/opm-simulators/deployments","created_at":"2014-01-15T12:06:17Z","updated_at":"2016-11-10T12:10:21Z","pushed_at":"2016-11-16T20:30:41Z","git_url":"git://github.com/blattms/opm-simulators.git","ssh_url":"git@github.com:blattms/opm-simulators.git","clone_url":"https://github.com/blattms/opm-simulators.git","svn_url":"https://github.com/blattms/opm-simulators","homepage":null,"size":6972,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OPM:master","ref":"master","sha":"8cc64402beda5a9479a18ddf2b85642e2d3a904e","user":{"login":"OPM","id":1827197,"avatar_url":"https://avatars.githubusercontent.com/u/1827197?v=3","gravatar_id":"","url":"https://api.github.com/users/OPM","html_url":"https://github.com/OPM","followers_url":"https://api.github.com/users/OPM/followers","following_url":"https://api.github.com/users/OPM/following{/other_user}","gists_url":"https://api.github.com/users/OPM/gists{/gist_id}","starred_url":"https://api.github.com/users/OPM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPM/subscriptions","organizations_url":"https://api.github.com/users/OPM/orgs","repos_url":"https://api.github.com/users/OPM/repos","events_url":"https://api.github.com/users/OPM/events{/privacy}","received_events_url":"https://api.github.com/users/OPM/received_events","type":"Organization","site_admin":false},"repo":{"id":10097543,"name":"opm-simulators","full_name":"OPM/opm-simulators","owner":{"login":"OPM","id":1827197,"avatar_url":"https://avatars.githubusercontent.com/u/1827197?v=3","gravatar_id":"","url":"https://api.github.com/users/OPM","html_url":"https://github.com/OPM","followers_url":"https://api.github.com/users/OPM/followers","following_url":"https://api.github.com/users/OPM/following{/other_user}","gists_url":"https://api.github.com/users/OPM/gists{/gist_id}","starred_url":"https://api.github.com/users/OPM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPM/subscriptions","organizations_url":"https://api.github.com/users/OPM/orgs","repos_url":"https://api.github.com/users/OPM/repos","events_url":"https://api.github.com/users/OPM/events{/privacy}","received_events_url":"https://api.github.com/users/OPM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OPM/opm-simulators","description":"Simulator programs and utilities for automatic differentiation.","fork":false,"url":"https://api.github.com/repos/OPM/opm-simulators","forks_url":"https://api.github.com/repos/OPM/opm-simulators/forks","keys_url":"https://api.github.com/repos/OPM/opm-simulators/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OPM/opm-simulators/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OPM/opm-simulators/teams","hooks_url":"https://api.github.com/repos/OPM/opm-simulators/hooks","issue_events_url":"https://api.github.com/repos/OPM/opm-simulators/issues/events{/number}","events_url":"https://api.github.com/repos/OPM/opm-simulators/events","assignees_url":"https://api.github.com/repos/OPM/opm-simulators/assignees{/user}","branches_url":"https://api.github.com/repos/OPM/opm-simulators/branches{/branch}","tags_url":"https://api.github.com/repos/OPM/opm-simulators/tags","blobs_url":"https://api.github.com/repos/OPM/opm-simulators/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OPM/opm-simulators/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OPM/opm-simulators/git/refs{/sha}","trees_url":"https://api.github.com/repos/OPM/opm-simulators/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OPM/opm-simulators/statuses/{sha}","languages_url":"https://api.github.com/repos/OPM/opm-simulators/languages","stargazers_url":"https://api.github.com/repos/OPM/opm-simulators/stargazers","contributors_url":"https://api.github.com/repos/OPM/opm-simulators/contributors","subscribers_url":"https://api.github.com/repos/OPM/opm-simulators/subscribers","subscription_url":"https://api.github.com/repos/OPM/opm-simulators/subscription","commits_url":"https://api.github.com/repos/OPM/opm-simulators/commits{/sha}","git_commits_url":"https://api.github.com/repos/OPM/opm-simulators/git/commits{/sha}","comments_url":"https://api.github.com/repos/OPM/opm-simulators/comments{/number}","issue_comment_url":"https://api.github.com/repos/OPM/opm-simulators/issues/comments{/number}","contents_url":"https://api.github.com/repos/OPM/opm-simulators/contents/{+path}","compare_url":"https://api.github.com/repos/OPM/opm-simulators/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OPM/opm-simulators/merges","archive_url":"https://api.github.com/repos/OPM/opm-simulators/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OPM/opm-simulators/downloads","issues_url":"https://api.github.com/repos/OPM/opm-simulators/issues{/number}","pulls_url":"https://api.github.com/repos/OPM/opm-simulators/pulls{/number}","milestones_url":"https://api.github.com/repos/OPM/opm-simulators/milestones{/number}","notifications_url":"https://api.github.com/repos/OPM/opm-simulators/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OPM/opm-simulators/labels{/name}","releases_url":"https://api.github.com/repos/OPM/opm-simulators/releases{/id}","deployments_url":"https://api.github.com/repos/OPM/opm-simulators/deployments","created_at":"2013-05-16T08:59:22Z","updated_at":"2016-10-25T14:42:31Z","pushed_at":"2016-11-16T20:50:15Z","git_url":"git://github.com/OPM/opm-simulators.git","ssh_url":"git@github.com:OPM/opm-simulators.git","clone_url":"https://github.com/OPM/opm-simulators.git","svn_url":"https://github.com/OPM/opm-simulators","homepage":"http://www.opm-project.org","size":7808,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":46,"forks":32,"open_issues":46,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OPM/opm-simulators/pulls/929"},"html":{"href":"https://github.com/OPM/opm-simulators/pull/929"},"issue":{"href":"https://api.github.com/repos/OPM/opm-simulators/issues/929"},"comments":{"href":"https://api.github.com/repos/OPM/opm-simulators/issues/929/comments"},"review_comments":{"href":"https://api.github.com/repos/OPM/opm-simulators/pulls/929/comments"},"review_comment":{"href":"https://api.github.com/repos/OPM/opm-simulators/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OPM/opm-simulators/pulls/929/commits"},"statuses":{"href":"https://api.github.com/repos/OPM/opm-simulators/statuses/80bbabc0b6e4034810c72710c3d049f9be20ba9a"}}}}
{"actor":{"display_login":"blattms"}}