{"action":"closed","number":1611,"pull_request":{"url":"https://api.github.com/repos/FAForever/fa/pulls/1611","id":89908288,"html_url":"https://github.com/FAForever/fa/pull/1611","diff_url":"https://github.com/FAForever/fa/pull/1611.diff","patch_url":"https://github.com/FAForever/fa/pull/1611.patch","issue_url":"https://api.github.com/repos/FAForever/fa/issues/1611","number":1611,"state":"closed","locked":false,"title":"Players giving objective units doesn't break the objective anymore","user":{"login":"TheKeyBlue","id":20644178,"avatar_url":"https://avatars.githubusercontent.com/u/20644178?v=3","gravatar_id":"","url":"https://api.github.com/users/TheKeyBlue","html_url":"https://github.com/TheKeyBlue","followers_url":"https://api.github.com/users/TheKeyBlue/followers","following_url":"https://api.github.com/users/TheKeyBlue/following{/other_user}","gists_url":"https://api.github.com/users/TheKeyBlue/gists{/gist_id}","starred_url":"https://api.github.com/users/TheKeyBlue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheKeyBlue/subscriptions","organizations_url":"https://api.github.com/users/TheKeyBlue/orgs","repos_url":"https://api.github.com/users/TheKeyBlue/repos","events_url":"https://api.github.com/users/TheKeyBlue/events{/privacy}","received_events_url":"https://api.github.com/users/TheKeyBlue/received_events","type":"User","site_admin":false},"body":"fixes FAForever/fa-coop#47 (speed2 told me to PR it here)\nI created a UnitCallback that is called each time a player gives that unit to a different Player.\nEach specific unit used in an objective receives a trigger for it. The 'new' unit now has to replace the old unit in the Objective: replace in the Targets list, reassign triggers, reapply marks and arrows.\n","created_at":"2016-10-18T22:10:35Z","updated_at":"2016-11-16T22:09:35Z","closed_at":"2016-11-16T22:09:34Z","merged_at":"2016-11-16T22:09:34Z","merge_commit_sha":"14554559be2e9d6d17022e32b290ddf6519bcfe8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/FAForever/fa/pulls/1611/commits","review_comments_url":"https://api.github.com/repos/FAForever/fa/pulls/1611/comments","review_comment_url":"https://api.github.com/repos/FAForever/fa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FAForever/fa/issues/1611/comments","statuses_url":"https://api.github.com/repos/FAForever/fa/statuses/580f8d499726b7684866df075629d757aadbc6a3","head":{"label":"TheKeyBlue:fix/GiveIssue","ref":"fix/GiveIssue","sha":"580f8d499726b7684866df075629d757aadbc6a3","user":{"login":"TheKeyBlue","id":20644178,"avatar_url":"https://avatars.githubusercontent.com/u/20644178?v=3","gravatar_id":"","url":"https://api.github.com/users/TheKeyBlue","html_url":"https://github.com/TheKeyBlue","followers_url":"https://api.github.com/users/TheKeyBlue/followers","following_url":"https://api.github.com/users/TheKeyBlue/following{/other_user}","gists_url":"https://api.github.com/users/TheKeyBlue/gists{/gist_id}","starred_url":"https://api.github.com/users/TheKeyBlue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheKeyBlue/subscriptions","organizations_url":"https://api.github.com/users/TheKeyBlue/orgs","repos_url":"https://api.github.com/users/TheKeyBlue/repos","events_url":"https://api.github.com/users/TheKeyBlue/events{/privacy}","received_events_url":"https://api.github.com/users/TheKeyBlue/received_events","type":"User","site_admin":false},"repo":{"id":65283490,"name":"fa","full_name":"TheKeyBlue/fa","owner":{"login":"TheKeyBlue","id":20644178,"avatar_url":"https://avatars.githubusercontent.com/u/20644178?v=3","gravatar_id":"","url":"https://api.github.com/users/TheKeyBlue","html_url":"https://github.com/TheKeyBlue","followers_url":"https://api.github.com/users/TheKeyBlue/followers","following_url":"https://api.github.com/users/TheKeyBlue/following{/other_user}","gists_url":"https://api.github.com/users/TheKeyBlue/gists{/gist_id}","starred_url":"https://api.github.com/users/TheKeyBlue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheKeyBlue/subscriptions","organizations_url":"https://api.github.com/users/TheKeyBlue/orgs","repos_url":"https://api.github.com/users/TheKeyBlue/repos","events_url":"https://api.github.com/users/TheKeyBlue/events{/privacy}","received_events_url":"https://api.github.com/users/TheKeyBlue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TheKeyBlue/fa","description":"Lua code for FAF","fork":true,"url":"https://api.github.com/repos/TheKeyBlue/fa","forks_url":"https://api.github.com/repos/TheKeyBlue/fa/forks","keys_url":"https://api.github.com/repos/TheKeyBlue/fa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheKeyBlue/fa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheKeyBlue/fa/teams","hooks_url":"https://api.github.com/repos/TheKeyBlue/fa/hooks","issue_events_url":"https://api.github.com/repos/TheKeyBlue/fa/issues/events{/number}","events_url":"https://api.github.com/repos/TheKeyBlue/fa/events","assignees_url":"https://api.github.com/repos/TheKeyBlue/fa/assignees{/user}","branches_url":"https://api.github.com/repos/TheKeyBlue/fa/branches{/branch}","tags_url":"https://api.github.com/repos/TheKeyBlue/fa/tags","blobs_url":"https://api.github.com/repos/TheKeyBlue/fa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheKeyBlue/fa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheKeyBlue/fa/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheKeyBlue/fa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheKeyBlue/fa/statuses/{sha}","languages_url":"https://api.github.com/repos/TheKeyBlue/fa/languages","stargazers_url":"https://api.github.com/repos/TheKeyBlue/fa/stargazers","contributors_url":"https://api.github.com/repos/TheKeyBlue/fa/contributors","subscribers_url":"https://api.github.com/repos/TheKeyBlue/fa/subscribers","subscription_url":"https://api.github.com/repos/TheKeyBlue/fa/subscription","commits_url":"https://api.github.com/repos/TheKeyBlue/fa/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheKeyBlue/fa/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheKeyBlue/fa/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheKeyBlue/fa/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheKeyBlue/fa/contents/{+path}","compare_url":"https://api.github.com/repos/TheKeyBlue/fa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheKeyBlue/fa/merges","archive_url":"https://api.github.com/repos/TheKeyBlue/fa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheKeyBlue/fa/downloads","issues_url":"https://api.github.com/repos/TheKeyBlue/fa/issues{/number}","pulls_url":"https://api.github.com/repos/TheKeyBlue/fa/pulls{/number}","milestones_url":"https://api.github.com/repos/TheKeyBlue/fa/milestones{/number}","notifications_url":"https://api.github.com/repos/TheKeyBlue/fa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheKeyBlue/fa/labels{/name}","releases_url":"https://api.github.com/repos/TheKeyBlue/fa/releases{/id}","deployments_url":"https://api.github.com/repos/TheKeyBlue/fa/deployments","created_at":"2016-08-09T09:47:00Z","updated_at":"2016-08-09T09:47:12Z","pushed_at":"2016-11-16T13:33:10Z","git_url":"git://github.com/TheKeyBlue/fa.git","ssh_url":"git@github.com:TheKeyBlue/fa.git","clone_url":"https://github.com/TheKeyBlue/fa.git","svn_url":"https://github.com/TheKeyBlue/fa","homepage":"","size":113464,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"FAForever:deploy/fafdevelop","ref":"deploy/fafdevelop","sha":"97fe567ffcaedb1f4098feae4be8577fa0476947","user":{"login":"FAForever","id":8887184,"avatar_url":"https://avatars.githubusercontent.com/u/8887184?v=3","gravatar_id":"","url":"https://api.github.com/users/FAForever","html_url":"https://github.com/FAForever","followers_url":"https://api.github.com/users/FAForever/followers","following_url":"https://api.github.com/users/FAForever/following{/other_user}","gists_url":"https://api.github.com/users/FAForever/gists{/gist_id}","starred_url":"https://api.github.com/users/FAForever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FAForever/subscriptions","organizations_url":"https://api.github.com/users/FAForever/orgs","repos_url":"https://api.github.com/users/FAForever/repos","events_url":"https://api.github.com/users/FAForever/events{/privacy}","received_events_url":"https://api.github.com/users/FAForever/received_events","type":"Organization","site_admin":false},"repo":{"id":24403473,"name":"fa","full_name":"FAForever/fa","owner":{"login":"FAForever","id":8887184,"avatar_url":"https://avatars.githubusercontent.com/u/8887184?v=3","gravatar_id":"","url":"https://api.github.com/users/FAForever","html_url":"https://github.com/FAForever","followers_url":"https://api.github.com/users/FAForever/followers","following_url":"https://api.github.com/users/FAForever/following{/other_user}","gists_url":"https://api.github.com/users/FAForever/gists{/gist_id}","starred_url":"https://api.github.com/users/FAForever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FAForever/subscriptions","organizations_url":"https://api.github.com/users/FAForever/orgs","repos_url":"https://api.github.com/users/FAForever/repos","events_url":"https://api.github.com/users/FAForever/events{/privacy}","received_events_url":"https://api.github.com/users/FAForever/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FAForever/fa","description":"Lua code for FAF","fork":false,"url":"https://api.github.com/repos/FAForever/fa","forks_url":"https://api.github.com/repos/FAForever/fa/forks","keys_url":"https://api.github.com/repos/FAForever/fa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FAForever/fa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FAForever/fa/teams","hooks_url":"https://api.github.com/repos/FAForever/fa/hooks","issue_events_url":"https://api.github.com/repos/FAForever/fa/issues/events{/number}","events_url":"https://api.github.com/repos/FAForever/fa/events","assignees_url":"https://api.github.com/repos/FAForever/fa/assignees{/user}","branches_url":"https://api.github.com/repos/FAForever/fa/branches{/branch}","tags_url":"https://api.github.com/repos/FAForever/fa/tags","blobs_url":"https://api.github.com/repos/FAForever/fa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FAForever/fa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FAForever/fa/git/refs{/sha}","trees_url":"https://api.github.com/repos/FAForever/fa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FAForever/fa/statuses/{sha}","languages_url":"https://api.github.com/repos/FAForever/fa/languages","stargazers_url":"https://api.github.com/repos/FAForever/fa/stargazers","contributors_url":"https://api.github.com/repos/FAForever/fa/contributors","subscribers_url":"https://api.github.com/repos/FAForever/fa/subscribers","subscription_url":"https://api.github.com/repos/FAForever/fa/subscription","commits_url":"https://api.github.com/repos/FAForever/fa/commits{/sha}","git_commits_url":"https://api.github.com/repos/FAForever/fa/git/commits{/sha}","comments_url":"https://api.github.com/repos/FAForever/fa/comments{/number}","issue_comment_url":"https://api.github.com/repos/FAForever/fa/issues/comments{/number}","contents_url":"https://api.github.com/repos/FAForever/fa/contents/{+path}","compare_url":"https://api.github.com/repos/FAForever/fa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FAForever/fa/merges","archive_url":"https://api.github.com/repos/FAForever/fa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FAForever/fa/downloads","issues_url":"https://api.github.com/repos/FAForever/fa/issues{/number}","pulls_url":"https://api.github.com/repos/FAForever/fa/pulls{/number}","milestones_url":"https://api.github.com/repos/FAForever/fa/milestones{/number}","notifications_url":"https://api.github.com/repos/FAForever/fa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FAForever/fa/labels{/name}","releases_url":"https://api.github.com/repos/FAForever/fa/releases{/id}","deployments_url":"https://api.github.com/repos/FAForever/fa/deployments","created_at":"2014-09-24T06:34:12Z","updated_at":"2016-11-13T13:21:37Z","pushed_at":"2016-11-16T22:09:34Z","git_url":"git://github.com/FAForever/fa.git","ssh_url":"git@github.com:FAForever/fa.git","clone_url":"https://github.com/FAForever/fa.git","svn_url":"https://github.com/FAForever/fa","homepage":"","size":129146,"stargazers_count":40,"watchers_count":40,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"open_issues_count":206,"forks":62,"open_issues":206,"watchers":40,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/FAForever/fa/pulls/1611"},"html":{"href":"https://github.com/FAForever/fa/pull/1611"},"issue":{"href":"https://api.github.com/repos/FAForever/fa/issues/1611"},"comments":{"href":"https://api.github.com/repos/FAForever/fa/issues/1611/comments"},"review_comments":{"href":"https://api.github.com/repos/FAForever/fa/pulls/1611/comments"},"review_comment":{"href":"https://api.github.com/repos/FAForever/fa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FAForever/fa/pulls/1611/commits"},"statuses":{"href":"https://api.github.com/repos/FAForever/fa/statuses/580f8d499726b7684866df075629d757aadbc6a3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"aeoncleanse","id":8494967,"avatar_url":"https://avatars.githubusercontent.com/u/8494967?v=3","gravatar_id":"","url":"https://api.github.com/users/aeoncleanse","html_url":"https://github.com/aeoncleanse","followers_url":"https://api.github.com/users/aeoncleanse/followers","following_url":"https://api.github.com/users/aeoncleanse/following{/other_user}","gists_url":"https://api.github.com/users/aeoncleanse/gists{/gist_id}","starred_url":"https://api.github.com/users/aeoncleanse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeoncleanse/subscriptions","organizations_url":"https://api.github.com/users/aeoncleanse/orgs","repos_url":"https://api.github.com/users/aeoncleanse/repos","events_url":"https://api.github.com/users/aeoncleanse/events{/privacy}","received_events_url":"https://api.github.com/users/aeoncleanse/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":194,"deletions":51,"changed_files":5}}
{"actor":{"display_login":"aeoncleanse"}}