{"action":"created","issue":{"url":"https://api.github.com/repos/eranpeer/FakeIt/issues/72","repository_url":"https://api.github.com/repos/eranpeer/FakeIt","labels_url":"https://api.github.com/repos/eranpeer/FakeIt/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/eranpeer/FakeIt/issues/72/comments","events_url":"https://api.github.com/repos/eranpeer/FakeIt/issues/72/events","html_url":"https://github.com/eranpeer/FakeIt/pull/72","id":175824645,"number":72,"title":"Reset don't reinit offset vector","user":{"login":"facetothefate","id":4744394,"avatar_url":"https://avatars.githubusercontent.com/u/4744394?v=3","gravatar_id":"","url":"https://api.github.com/users/facetothefate","html_url":"https://github.com/facetothefate","followers_url":"https://api.github.com/users/facetothefate/followers","following_url":"https://api.github.com/users/facetothefate/following{/other_user}","gists_url":"https://api.github.com/users/facetothefate/gists{/gist_id}","starred_url":"https://api.github.com/users/facetothefate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facetothefate/subscriptions","organizations_url":"https://api.github.com/users/facetothefate/orgs","repos_url":"https://api.github.com/users/facetothefate/repos","events_url":"https://api.github.com/users/facetothefate/events{/privacy}","received_events_url":"https://api.github.com/users/facetothefate/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-08T18:16:35Z","updated_at":"2016-09-08T18:20:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/eranpeer/FakeIt/pulls/72","html_url":"https://github.com/eranpeer/FakeIt/pull/72","diff_url":"https://github.com/eranpeer/FakeIt/pull/72.diff","patch_url":"https://github.com/eranpeer/FakeIt/pull/72.patch"},"body":"I wonder why we don't reinit the offset vector here ?\r\n\r\nI got a segmentation fault today, in my test, I have a big struct contains a lot of the virtual method, called mock_a \r\nI have two different test class, one setting up some functions of mock_a, the other one firstly reset the mock_a, and setting up some more functions, then I ran into a segmentation fault.\r\n\r\nI trace back, it turns out the offset vector contains the old offset which are added in the previous test class.\r\nI think this happened because the two offset have same id.\r\n \r\nhowever with _methodMocks have been reset, the old offset will provide a NULL pointer.\r\nThen I have a segmentation fault.\r\n\r\nBTW, why we need to keep track all the offsets ?\r\nWhy we don't make the whole _methodMocks as a map (id as the key)?"},"comment":{"url":"https://api.github.com/repos/eranpeer/FakeIt/issues/comments/245690758","html_url":"https://github.com/eranpeer/FakeIt/pull/72#issuecomment-245690758","issue_url":"https://api.github.com/repos/eranpeer/FakeIt/issues/72","id":245690758,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-09-08T18:20:35Z","updated_at":"2016-09-08T18:20:35Z","body":"\n[![Coverage Status](https://coveralls.io/builds/7803708/badge)](https://coveralls.io/builds/7803708)\n\nCoverage increased (+1.0e-05%) to 99.974% when pulling **808fed2efa0fef4015b3a35aba62e1d9f7c5c985 on facetothefate:master** into **44f13731138b30de72a32aeb16f7a21490bc9135 on eranpeer:master**.\n"}}
{"actor":{"display_login":"coveralls"}}