{"action":"opened","number":48,"pull_request":{"url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/pulls/48","id":55172819,"html_url":"https://github.com/doctrine/DoctrineCouchDBBundle/pull/48","diff_url":"https://github.com/doctrine/DoctrineCouchDBBundle/pull/48.diff","patch_url":"https://github.com/doctrine/DoctrineCouchDBBundle/pull/48.patch","issue_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/issues/48","number":48,"state":"open","locked":false,"title":"remove deprecated factory service syntax.","user":{"login":"bangpound","id":6731,"avatar_url":"https://avatars.githubusercontent.com/u/6731?v=3","gravatar_id":"","url":"https://api.github.com/users/bangpound","html_url":"https://github.com/bangpound","followers_url":"https://api.github.com/users/bangpound/followers","following_url":"https://api.github.com/users/bangpound/following{/other_user}","gists_url":"https://api.github.com/users/bangpound/gists{/gist_id}","starred_url":"https://api.github.com/users/bangpound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangpound/subscriptions","organizations_url":"https://api.github.com/users/bangpound/orgs","repos_url":"https://api.github.com/users/bangpound/repos","events_url":"https://api.github.com/users/bangpound/events{/privacy}","received_events_url":"https://api.github.com/users/bangpound/received_events","type":"User","site_admin":false},"body":"Symfony 3 dropped the deprecated `setFactoryClass` and `setFactoryMethod` methods for definitions, and these have to be replaced with just `setFactory`. However, that method wasn't added until Symfony 2.5 (?), so this pull request breaks compatibility with this bundle's minimum requirements. Is there a way to support both variations in the XML service definitions?\r\n\r\nIn d13e6afffbbc33933dfb3296a6fab2e5225bb892, Symfony 3 support was added, but I don't see how it can actually work without this change. Should that patch be reverted?\r\n\r\nWhat do the project maintainers advise?","created_at":"2016-01-06T03:16:54Z","updated_at":"2016-01-06T03:16:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/pulls/48/commits","review_comments_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/pulls/48/comments","review_comment_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/issues/48/comments","statuses_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/statuses/7e64be71c4b911c6ac330ebd8cba940908398028","head":{"label":"bangpound:fix-factory-definitions","ref":"fix-factory-definitions","sha":"7e64be71c4b911c6ac330ebd8cba940908398028","user":{"login":"bangpound","id":6731,"avatar_url":"https://avatars.githubusercontent.com/u/6731?v=3","gravatar_id":"","url":"https://api.github.com/users/bangpound","html_url":"https://github.com/bangpound","followers_url":"https://api.github.com/users/bangpound/followers","following_url":"https://api.github.com/users/bangpound/following{/other_user}","gists_url":"https://api.github.com/users/bangpound/gists{/gist_id}","starred_url":"https://api.github.com/users/bangpound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangpound/subscriptions","organizations_url":"https://api.github.com/users/bangpound/orgs","repos_url":"https://api.github.com/users/bangpound/repos","events_url":"https://api.github.com/users/bangpound/events{/privacy}","received_events_url":"https://api.github.com/users/bangpound/received_events","type":"User","site_admin":false},"repo":{"id":12039145,"name":"DoctrineCouchDBBundle","full_name":"bangpound/DoctrineCouchDBBundle","owner":{"login":"bangpound","id":6731,"avatar_url":"https://avatars.githubusercontent.com/u/6731?v=3","gravatar_id":"","url":"https://api.github.com/users/bangpound","html_url":"https://github.com/bangpound","followers_url":"https://api.github.com/users/bangpound/followers","following_url":"https://api.github.com/users/bangpound/following{/other_user}","gists_url":"https://api.github.com/users/bangpound/gists{/gist_id}","starred_url":"https://api.github.com/users/bangpound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangpound/subscriptions","organizations_url":"https://api.github.com/users/bangpound/orgs","repos_url":"https://api.github.com/users/bangpound/repos","events_url":"https://api.github.com/users/bangpound/events{/privacy}","received_events_url":"https://api.github.com/users/bangpound/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bangpound/DoctrineCouchDBBundle","description":"Symfony Bundle for DoctrineCouchDB","fork":true,"url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle","forks_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/forks","keys_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/teams","hooks_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/hooks","issue_events_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/issues/events{/number}","events_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/events","assignees_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/assignees{/user}","branches_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/branches{/branch}","tags_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/tags","blobs_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/languages","stargazers_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/stargazers","contributors_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/contributors","subscribers_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/subscribers","subscription_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/subscription","commits_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/contents/{+path}","compare_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/merges","archive_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/downloads","issues_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/issues{/number}","pulls_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/labels{/name}","releases_url":"https://api.github.com/repos/bangpound/DoctrineCouchDBBundle/releases{/id}","created_at":"2013-08-11T16:57:32Z","updated_at":"2014-09-03T06:40:31Z","pushed_at":"2016-01-06T03:06:12Z","git_url":"git://github.com/bangpound/DoctrineCouchDBBundle.git","ssh_url":"git@github.com:bangpound/DoctrineCouchDBBundle.git","clone_url":"https://github.com/bangpound/DoctrineCouchDBBundle.git","svn_url":"https://github.com/bangpound/DoctrineCouchDBBundle","homepage":"http://www.doctrine-project.org","size":124,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"doctrine:master","ref":"master","sha":"7b1204c6655e607c7114e7cbfbf5de0f5d9ba93a","user":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=3","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"repo":{"id":1838413,"name":"DoctrineCouchDBBundle","full_name":"doctrine/DoctrineCouchDBBundle","owner":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=3","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doctrine/DoctrineCouchDBBundle","description":"Symfony Bundle for DoctrineCouchDB","fork":false,"url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle","forks_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/forks","keys_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/teams","hooks_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/hooks","issue_events_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/issues/events{/number}","events_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/events","assignees_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/assignees{/user}","branches_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/branches{/branch}","tags_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/tags","blobs_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/languages","stargazers_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/stargazers","contributors_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/contributors","subscribers_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/subscribers","subscription_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/subscription","commits_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/contents/{+path}","compare_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/merges","archive_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/downloads","issues_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/issues{/number}","pulls_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/labels{/name}","releases_url":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/releases{/id}","created_at":"2011-06-02T17:36:51Z","updated_at":"2015-11-08T19:05:33Z","pushed_at":"2015-12-14T20:07:38Z","git_url":"git://github.com/doctrine/DoctrineCouchDBBundle.git","ssh_url":"git@github.com:doctrine/DoctrineCouchDBBundle.git","clone_url":"https://github.com/doctrine/DoctrineCouchDBBundle.git","svn_url":"https://github.com/doctrine/DoctrineCouchDBBundle","homepage":"http://www.doctrine-project.org","size":128,"stargazers_count":43,"watchers_count":43,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":4,"forks":26,"open_issues":4,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/pulls/48"},"html":{"href":"https://github.com/doctrine/DoctrineCouchDBBundle/pull/48"},"issue":{"href":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/issues/48"},"comments":{"href":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/doctrine/DoctrineCouchDBBundle/statuses/7e64be71c4b911c6ac330ebd8cba940908398028"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":6,"changed_files":2}}