{"action":"created","comment":{"url":"https://api.github.com/repos/wmde/FundraisingFrontend/pulls/comments/56837923","id":56837923,"diff_hunk":"@@ -0,0 +1,60 @@\n+'use strict';\n+\n+var objectAssign = require( 'object-assign' ),\n+\n+\t/**\n+\t * View Handler for showing and hiding elements if the update value matches a regular expression\n+\t * @class\n+\t */\n+\tElementSlider = {\n+\t\tel: null,\n+\t\tshowOnValue: null,\n+\n+\t\t// internal fields\n+\t\tslideSpeed: 600,\n+\t\tisHidden: null,","path":"app/js/lib/view_handler/element_slide.js","position":15,"original_position":15,"commit_id":"d507049c11c76fd128b8c9eb6634f274361819e5","original_commit_id":"d507049c11c76fd128b8c9eb6634f274361819e5","user":{"login":"gbirke","id":223326,"avatar_url":"https://avatars.githubusercontent.com/u/223326?v=3","gravatar_id":"","url":"https://api.github.com/users/gbirke","html_url":"https://github.com/gbirke","followers_url":"https://api.github.com/users/gbirke/followers","following_url":"https://api.github.com/users/gbirke/following{/other_user}","gists_url":"https://api.github.com/users/gbirke/gists{/gist_id}","starred_url":"https://api.github.com/users/gbirke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbirke/subscriptions","organizations_url":"https://api.github.com/users/gbirke/orgs","repos_url":"https://api.github.com/users/gbirke/repos","events_url":"https://api.github.com/users/gbirke/events{/privacy}","received_events_url":"https://api.github.com/users/gbirke/received_events","type":"User","site_admin":false},"body":"No, it should be null to always trigger the show/hide event when the store is initialized. This makes the view Handler more independent form the initial HTML/CSS state, which may also be different for different instances of the view handler. Take for example period and bank data fields. In the default form, period is hidden and bank data fields are shown. If we initialize with `false` instead of `null`, the creator of the form must remember to remove the \"display:none\" code from the bank data fields, otherwise the visual state and the intended state differ.\r\n\r\nAny recommendations on how to make this intention more clear in the code?\r\n","created_at":"2016-03-21T15:09:42Z","updated_at":"2016-03-21T15:09:42Z","html_url":"https://github.com/wmde/FundraisingFrontend/pull/285#discussion_r56837923","pull_request_url":"https://api.github.com/repos/wmde/FundraisingFrontend/pulls/285","_links":{"self":{"href":"https://api.github.com/repos/wmde/FundraisingFrontend/pulls/comments/56837923"},"html":{"href":"https://github.com/wmde/FundraisingFrontend/pull/285#discussion_r56837923"},"pull_request":{"href":"https://api.github.com/repos/wmde/FundraisingFrontend/pulls/285"}}},"pull_request":{"url":"https://api.github.com/repos/wmde/FundraisingFrontend/pulls/285","id":63378161,"html_url":"https://github.com/wmde/FundraisingFrontend/pull/285","diff_url":"https://github.com/wmde/FundraisingFrontend/pull/285.diff","patch_url":"https://github.com/wmde/FundraisingFrontend/pull/285.patch","issue_url":"https://api.github.com/repos/wmde/FundraisingFrontend/issues/285","number":285,"state":"open","locked":false,"title":"Show and hide bank data","user":{"login":"gbirke","id":223326,"avatar_url":"https://avatars.githubusercontent.com/u/223326?v=3","gravatar_id":"","url":"https://api.github.com/users/gbirke","html_url":"https://github.com/gbirke","followers_url":"https://api.github.com/users/gbirke/followers","following_url":"https://api.github.com/users/gbirke/following{/other_user}","gists_url":"https://api.github.com/users/gbirke/gists{/gist_id}","starred_url":"https://api.github.com/users/gbirke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbirke/subscriptions","organizations_url":"https://api.github.com/users/gbirke/orgs","repos_url":"https://api.github.com/users/gbirke/repos","events_url":"https://api.github.com/users/gbirke/events{/privacy}","received_events_url":"https://api.github.com/users/gbirke/received_events","type":"User","site_admin":false},"body":"Show and hide the input fields of the bank data, depending on the selected payment method.\r\n\r\nRemove the old \"slide\" code in other places (personal info, payment period) and replace it with the new view handler class.\r\n","created_at":"2016-03-18T14:02:22Z","updated_at":"2016-03-21T15:09:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a77a3be7b2d6e1018143c61fa8fafbfa9660006","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wmde/FundraisingFrontend/pulls/285/commits","review_comments_url":"https://api.github.com/repos/wmde/FundraisingFrontend/pulls/285/comments","review_comment_url":"https://api.github.com/repos/wmde/FundraisingFrontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wmde/FundraisingFrontend/issues/285/comments","statuses_url":"https://api.github.com/repos/wmde/FundraisingFrontend/statuses/d507049c11c76fd128b8c9eb6634f274361819e5","head":{"label":"wmde:form-part-visibility","ref":"form-part-visibility","sha":"d507049c11c76fd128b8c9eb6634f274361819e5","user":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"repo":{"id":42872217,"name":"FundraisingFrontend","full_name":"wmde/FundraisingFrontend","owner":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wmde/FundraisingFrontend","description":"Fundraising Frontend backend code v2 alpha","fork":false,"url":"https://api.github.com/repos/wmde/FundraisingFrontend","forks_url":"https://api.github.com/repos/wmde/FundraisingFrontend/forks","keys_url":"https://api.github.com/repos/wmde/FundraisingFrontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmde/FundraisingFrontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmde/FundraisingFrontend/teams","hooks_url":"https://api.github.com/repos/wmde/FundraisingFrontend/hooks","issue_events_url":"https://api.github.com/repos/wmde/FundraisingFrontend/issues/events{/number}","events_url":"https://api.github.com/repos/wmde/FundraisingFrontend/events","assignees_url":"https://api.github.com/repos/wmde/FundraisingFrontend/assignees{/user}","branches_url":"https://api.github.com/repos/wmde/FundraisingFrontend/branches{/branch}","tags_url":"https://api.github.com/repos/wmde/FundraisingFrontend/tags","blobs_url":"https://api.github.com/repos/wmde/FundraisingFrontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmde/FundraisingFrontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmde/FundraisingFrontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmde/FundraisingFrontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmde/FundraisingFrontend/statuses/{sha}","languages_url":"https://api.github.com/repos/wmde/FundraisingFrontend/languages","stargazers_url":"https://api.github.com/repos/wmde/FundraisingFrontend/stargazers","contributors_url":"https://api.github.com/repos/wmde/FundraisingFrontend/contributors","subscribers_url":"https://api.github.com/repos/wmde/FundraisingFrontend/subscribers","subscription_url":"https://api.github.com/repos/wmde/FundraisingFrontend/subscription","commits_url":"https://api.github.com/repos/wmde/FundraisingFrontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmde/FundraisingFrontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmde/FundraisingFrontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmde/FundraisingFrontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/wmde/FundraisingFrontend/contents/{+path}","compare_url":"https://api.github.com/repos/wmde/FundraisingFrontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmde/FundraisingFrontend/merges","archive_url":"https://api.github.com/repos/wmde/FundraisingFrontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmde/FundraisingFrontend/downloads","issues_url":"https://api.github.com/repos/wmde/FundraisingFrontend/issues{/number}","pulls_url":"https://api.github.com/repos/wmde/FundraisingFrontend/pulls{/number}","milestones_url":"https://api.github.com/repos/wmde/FundraisingFrontend/milestones{/number}","notifications_url":"https://api.github.com/repos/wmde/FundraisingFrontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmde/FundraisingFrontend/labels{/name}","releases_url":"https://api.github.com/repos/wmde/FundraisingFrontend/releases{/id}","deployments_url":"https://api.github.com/repos/wmde/FundraisingFrontend/deployments","created_at":"2015-09-21T14:42:43Z","updated_at":"2016-01-29T13:01:30Z","pushed_at":"2016-03-21T14:39:43Z","git_url":"git://github.com/wmde/FundraisingFrontend.git","ssh_url":"git@github.com:wmde/FundraisingFrontend.git","clone_url":"https://github.com/wmde/FundraisingFrontend.git","svn_url":"https://github.com/wmde/FundraisingFrontend","homepage":"","size":1388,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"wmde:master","ref":"master","sha":"f54e6afab7fc7b35228d4608032cb37fb6c9d16e","user":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"repo":{"id":42872217,"name":"FundraisingFrontend","full_name":"wmde/FundraisingFrontend","owner":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wmde/FundraisingFrontend","description":"Fundraising Frontend backend code v2 alpha","fork":false,"url":"https://api.github.com/repos/wmde/FundraisingFrontend","forks_url":"https://api.github.com/repos/wmde/FundraisingFrontend/forks","keys_url":"https://api.github.com/repos/wmde/FundraisingFrontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmde/FundraisingFrontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmde/FundraisingFrontend/teams","hooks_url":"https://api.github.com/repos/wmde/FundraisingFrontend/hooks","issue_events_url":"https://api.github.com/repos/wmde/FundraisingFrontend/issues/events{/number}","events_url":"https://api.github.com/repos/wmde/FundraisingFrontend/events","assignees_url":"https://api.github.com/repos/wmde/FundraisingFrontend/assignees{/user}","branches_url":"https://api.github.com/repos/wmde/FundraisingFrontend/branches{/branch}","tags_url":"https://api.github.com/repos/wmde/FundraisingFrontend/tags","blobs_url":"https://api.github.com/repos/wmde/FundraisingFrontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmde/FundraisingFrontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmde/FundraisingFrontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmde/FundraisingFrontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmde/FundraisingFrontend/statuses/{sha}","languages_url":"https://api.github.com/repos/wmde/FundraisingFrontend/languages","stargazers_url":"https://api.github.com/repos/wmde/FundraisingFrontend/stargazers","contributors_url":"https://api.github.com/repos/wmde/FundraisingFrontend/contributors","subscribers_url":"https://api.github.com/repos/wmde/FundraisingFrontend/subscribers","subscription_url":"https://api.github.com/repos/wmde/FundraisingFrontend/subscription","commits_url":"https://api.github.com/repos/wmde/FundraisingFrontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmde/FundraisingFrontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmde/FundraisingFrontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmde/FundraisingFrontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/wmde/FundraisingFrontend/contents/{+path}","compare_url":"https://api.github.com/repos/wmde/FundraisingFrontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmde/FundraisingFrontend/merges","archive_url":"https://api.github.com/repos/wmde/FundraisingFrontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmde/FundraisingFrontend/downloads","issues_url":"https://api.github.com/repos/wmde/FundraisingFrontend/issues{/number}","pulls_url":"https://api.github.com/repos/wmde/FundraisingFrontend/pulls{/number}","milestones_url":"https://api.github.com/repos/wmde/FundraisingFrontend/milestones{/number}","notifications_url":"https://api.github.com/repos/wmde/FundraisingFrontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmde/FundraisingFrontend/labels{/name}","releases_url":"https://api.github.com/repos/wmde/FundraisingFrontend/releases{/id}","deployments_url":"https://api.github.com/repos/wmde/FundraisingFrontend/deployments","created_at":"2015-09-21T14:42:43Z","updated_at":"2016-01-29T13:01:30Z","pushed_at":"2016-03-21T14:39:43Z","git_url":"git://github.com/wmde/FundraisingFrontend.git","ssh_url":"git@github.com:wmde/FundraisingFrontend.git","clone_url":"https://github.com/wmde/FundraisingFrontend.git","svn_url":"https://github.com/wmde/FundraisingFrontend","homepage":"","size":1388,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wmde/FundraisingFrontend/pulls/285"},"html":{"href":"https://github.com/wmde/FundraisingFrontend/pull/285"},"issue":{"href":"https://api.github.com/repos/wmde/FundraisingFrontend/issues/285"},"comments":{"href":"https://api.github.com/repos/wmde/FundraisingFrontend/issues/285/comments"},"review_comments":{"href":"https://api.github.com/repos/wmde/FundraisingFrontend/pulls/285/comments"},"review_comment":{"href":"https://api.github.com/repos/wmde/FundraisingFrontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wmde/FundraisingFrontend/pulls/285/commits"},"statuses":{"href":"https://api.github.com/repos/wmde/FundraisingFrontend/statuses/d507049c11c76fd128b8c9eb6634f274361819e5"}}}}