{"action":"opened","number":1226,"pull_request":{"url":"https://api.github.com/repos/ravendb/ravendb/pulls/1226","id":99581320,"html_url":"https://github.com/ravendb/ravendb/pull/1226","diff_url":"https://github.com/ravendb/ravendb/pull/1226.diff","patch_url":"https://github.com/ravendb/ravendb/pull/1226.patch","issue_url":"https://api.github.com/repos/ravendb/ravendb/issues/1226","number":1226,"state":"open","locked":false,"title":"Use the knowledge that some values are actually constant.","user":{"login":"redknightlois","id":1045411,"avatar_url":"https://avatars.githubusercontent.com/u/1045411?v=3","gravatar_id":"","url":"https://api.github.com/users/redknightlois","html_url":"https://github.com/redknightlois","followers_url":"https://api.github.com/users/redknightlois/followers","following_url":"https://api.github.com/users/redknightlois/following{/other_user}","gists_url":"https://api.github.com/users/redknightlois/gists{/gist_id}","starred_url":"https://api.github.com/users/redknightlois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redknightlois/subscriptions","organizations_url":"https://api.github.com/users/redknightlois/orgs","repos_url":"https://api.github.com/users/redknightlois/repos","events_url":"https://api.github.com/users/redknightlois/events{/privacy}","received_events_url":"https://api.github.com/users/redknightlois/received_events","type":"User","site_admin":false},"body":"Avoiding references to memory locations when the value stored is actually a constant.\r\n\r\nThe JIT usually has a hard time allocating register uses. Many times it can also unfold computation and doing that at compilation time. Using static readonly variables to store constants defeat those optimizations, therefore I tracked down the uses of such a mechanism and introduced a mechanism to be able to ensure ahead of time (manually) that the constant didnt change, and if it did fail fast.\r\n\r\nRemoved dead code.","created_at":"2016-12-28T18:57:19Z","updated_at":"2016-12-28T18:57:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ravendb/ravendb/pulls/1226/commits","review_comments_url":"https://api.github.com/repos/ravendb/ravendb/pulls/1226/comments","review_comment_url":"https://api.github.com/repos/ravendb/ravendb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ravendb/ravendb/issues/1226/comments","statuses_url":"https://api.github.com/repos/ravendb/ravendb/statuses/a77f2940304d746ff88bfab91de90d4f72d70cb0","head":{"label":"Corvalius:v4.0","ref":"v4.0","sha":"a77f2940304d746ff88bfab91de90d4f72d70cb0","user":{"login":"Corvalius","id":1424411,"avatar_url":"https://avatars.githubusercontent.com/u/1424411?v=3","gravatar_id":"","url":"https://api.github.com/users/Corvalius","html_url":"https://github.com/Corvalius","followers_url":"https://api.github.com/users/Corvalius/followers","following_url":"https://api.github.com/users/Corvalius/following{/other_user}","gists_url":"https://api.github.com/users/Corvalius/gists{/gist_id}","starred_url":"https://api.github.com/users/Corvalius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Corvalius/subscriptions","organizations_url":"https://api.github.com/users/Corvalius/orgs","repos_url":"https://api.github.com/users/Corvalius/repos","events_url":"https://api.github.com/users/Corvalius/events{/privacy}","received_events_url":"https://api.github.com/users/Corvalius/received_events","type":"Organization","site_admin":false},"repo":{"id":18448801,"name":"ravendb","full_name":"Corvalius/ravendb","owner":{"login":"Corvalius","id":1424411,"avatar_url":"https://avatars.githubusercontent.com/u/1424411?v=3","gravatar_id":"","url":"https://api.github.com/users/Corvalius","html_url":"https://github.com/Corvalius","followers_url":"https://api.github.com/users/Corvalius/followers","following_url":"https://api.github.com/users/Corvalius/following{/other_user}","gists_url":"https://api.github.com/users/Corvalius/gists{/gist_id}","starred_url":"https://api.github.com/users/Corvalius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Corvalius/subscriptions","organizations_url":"https://api.github.com/users/Corvalius/orgs","repos_url":"https://api.github.com/users/Corvalius/repos","events_url":"https://api.github.com/users/Corvalius/events{/privacy}","received_events_url":"https://api.github.com/users/Corvalius/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Corvalius/ravendb","description":"A linq enabled document database for .NET","fork":true,"url":"https://api.github.com/repos/Corvalius/ravendb","forks_url":"https://api.github.com/repos/Corvalius/ravendb/forks","keys_url":"https://api.github.com/repos/Corvalius/ravendb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Corvalius/ravendb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Corvalius/ravendb/teams","hooks_url":"https://api.github.com/repos/Corvalius/ravendb/hooks","issue_events_url":"https://api.github.com/repos/Corvalius/ravendb/issues/events{/number}","events_url":"https://api.github.com/repos/Corvalius/ravendb/events","assignees_url":"https://api.github.com/repos/Corvalius/ravendb/assignees{/user}","branches_url":"https://api.github.com/repos/Corvalius/ravendb/branches{/branch}","tags_url":"https://api.github.com/repos/Corvalius/ravendb/tags","blobs_url":"https://api.github.com/repos/Corvalius/ravendb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Corvalius/ravendb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Corvalius/ravendb/git/refs{/sha}","trees_url":"https://api.github.com/repos/Corvalius/ravendb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Corvalius/ravendb/statuses/{sha}","languages_url":"https://api.github.com/repos/Corvalius/ravendb/languages","stargazers_url":"https://api.github.com/repos/Corvalius/ravendb/stargazers","contributors_url":"https://api.github.com/repos/Corvalius/ravendb/contributors","subscribers_url":"https://api.github.com/repos/Corvalius/ravendb/subscribers","subscription_url":"https://api.github.com/repos/Corvalius/ravendb/subscription","commits_url":"https://api.github.com/repos/Corvalius/ravendb/commits{/sha}","git_commits_url":"https://api.github.com/repos/Corvalius/ravendb/git/commits{/sha}","comments_url":"https://api.github.com/repos/Corvalius/ravendb/comments{/number}","issue_comment_url":"https://api.github.com/repos/Corvalius/ravendb/issues/comments{/number}","contents_url":"https://api.github.com/repos/Corvalius/ravendb/contents/{+path}","compare_url":"https://api.github.com/repos/Corvalius/ravendb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Corvalius/ravendb/merges","archive_url":"https://api.github.com/repos/Corvalius/ravendb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Corvalius/ravendb/downloads","issues_url":"https://api.github.com/repos/Corvalius/ravendb/issues{/number}","pulls_url":"https://api.github.com/repos/Corvalius/ravendb/pulls{/number}","milestones_url":"https://api.github.com/repos/Corvalius/ravendb/milestones{/number}","notifications_url":"https://api.github.com/repos/Corvalius/ravendb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Corvalius/ravendb/labels{/name}","releases_url":"https://api.github.com/repos/Corvalius/ravendb/releases{/id}","deployments_url":"https://api.github.com/repos/Corvalius/ravendb/deployments","created_at":"2014-04-04T18:48:26Z","updated_at":"2016-02-29T12:20:54Z","pushed_at":"2016-12-28T18:56:21Z","git_url":"git://github.com/Corvalius/ravendb.git","ssh_url":"git@github.com:Corvalius/ravendb.git","clone_url":"https://github.com/Corvalius/ravendb.git","svn_url":"https://github.com/Corvalius/ravendb","homepage":"http://ayende.com/Blog/","size":379622,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ravendb:v4.0","ref":"v4.0","sha":"4a3d5ad686ec779365bade58d97c4b386af52ab3","user":{"login":"ravendb","id":213792,"avatar_url":"https://avatars.githubusercontent.com/u/213792?v=3","gravatar_id":"","url":"https://api.github.com/users/ravendb","html_url":"https://github.com/ravendb","followers_url":"https://api.github.com/users/ravendb/followers","following_url":"https://api.github.com/users/ravendb/following{/other_user}","gists_url":"https://api.github.com/users/ravendb/gists{/gist_id}","starred_url":"https://api.github.com/users/ravendb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravendb/subscriptions","organizations_url":"https://api.github.com/users/ravendb/orgs","repos_url":"https://api.github.com/users/ravendb/repos","events_url":"https://api.github.com/users/ravendb/events{/privacy}","received_events_url":"https://api.github.com/users/ravendb/received_events","type":"Organization","site_admin":false},"repo":{"id":542714,"name":"ravendb","full_name":"ravendb/ravendb","owner":{"login":"ravendb","id":213792,"avatar_url":"https://avatars.githubusercontent.com/u/213792?v=3","gravatar_id":"","url":"https://api.github.com/users/ravendb","html_url":"https://github.com/ravendb","followers_url":"https://api.github.com/users/ravendb/followers","following_url":"https://api.github.com/users/ravendb/following{/other_user}","gists_url":"https://api.github.com/users/ravendb/gists{/gist_id}","starred_url":"https://api.github.com/users/ravendb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravendb/subscriptions","organizations_url":"https://api.github.com/users/ravendb/orgs","repos_url":"https://api.github.com/users/ravendb/repos","events_url":"https://api.github.com/users/ravendb/events{/privacy}","received_events_url":"https://api.github.com/users/ravendb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ravendb/ravendb","description":"A linq enabled document database for .NET","fork":false,"url":"https://api.github.com/repos/ravendb/ravendb","forks_url":"https://api.github.com/repos/ravendb/ravendb/forks","keys_url":"https://api.github.com/repos/ravendb/ravendb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ravendb/ravendb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ravendb/ravendb/teams","hooks_url":"https://api.github.com/repos/ravendb/ravendb/hooks","issue_events_url":"https://api.github.com/repos/ravendb/ravendb/issues/events{/number}","events_url":"https://api.github.com/repos/ravendb/ravendb/events","assignees_url":"https://api.github.com/repos/ravendb/ravendb/assignees{/user}","branches_url":"https://api.github.com/repos/ravendb/ravendb/branches{/branch}","tags_url":"https://api.github.com/repos/ravendb/ravendb/tags","blobs_url":"https://api.github.com/repos/ravendb/ravendb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ravendb/ravendb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ravendb/ravendb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ravendb/ravendb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ravendb/ravendb/statuses/{sha}","languages_url":"https://api.github.com/repos/ravendb/ravendb/languages","stargazers_url":"https://api.github.com/repos/ravendb/ravendb/stargazers","contributors_url":"https://api.github.com/repos/ravendb/ravendb/contributors","subscribers_url":"https://api.github.com/repos/ravendb/ravendb/subscribers","subscription_url":"https://api.github.com/repos/ravendb/ravendb/subscription","commits_url":"https://api.github.com/repos/ravendb/ravendb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ravendb/ravendb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ravendb/ravendb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ravendb/ravendb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ravendb/ravendb/contents/{+path}","compare_url":"https://api.github.com/repos/ravendb/ravendb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ravendb/ravendb/merges","archive_url":"https://api.github.com/repos/ravendb/ravendb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ravendb/ravendb/downloads","issues_url":"https://api.github.com/repos/ravendb/ravendb/issues{/number}","pulls_url":"https://api.github.com/repos/ravendb/ravendb/pulls{/number}","milestones_url":"https://api.github.com/repos/ravendb/ravendb/milestones{/number}","notifications_url":"https://api.github.com/repos/ravendb/ravendb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ravendb/ravendb/labels{/name}","releases_url":"https://api.github.com/repos/ravendb/ravendb/releases{/id}","deployments_url":"https://api.github.com/repos/ravendb/ravendb/deployments","created_at":"2010-03-02T11:05:30Z","updated_at":"2016-12-28T13:18:23Z","pushed_at":"2016-12-28T18:29:25Z","git_url":"git://github.com/ravendb/ravendb.git","ssh_url":"git@github.com:ravendb/ravendb.git","clone_url":"https://github.com/ravendb/ravendb.git","svn_url":"https://github.com/ravendb/ravendb","homepage":"http://ravendb.net","size":379718,"stargazers_count":1606,"watchers_count":1606,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":641,"mirror_url":null,"open_issues_count":6,"forks":641,"open_issues":6,"watchers":1606,"default_branch":"v3.5"}},"_links":{"self":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/1226"},"html":{"href":"https://github.com/ravendb/ravendb/pull/1226"},"issue":{"href":"https://api.github.com/repos/ravendb/ravendb/issues/1226"},"comments":{"href":"https://api.github.com/repos/ravendb/ravendb/issues/1226/comments"},"review_comments":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/1226/comments"},"review_comment":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/1226/commits"},"statuses":{"href":"https://api.github.com/repos/ravendb/ravendb/statuses/a77f2940304d746ff88bfab91de90d4f72d70cb0"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":168,"deletions":309,"changed_files":29}}
{"actor":{"display_login":"redknightlois"}}