{"action":"closed","issue":{"url":"https://api.github.com/repos/ptaoussanis/sente/issues/272","repository_url":"https://api.github.com/repos/ptaoussanis/sente","labels_url":"https://api.github.com/repos/ptaoussanis/sente/issues/272/labels{/name}","comments_url":"https://api.github.com/repos/ptaoussanis/sente/issues/272/comments","events_url":"https://api.github.com/repos/ptaoussanis/sente/issues/272/events","html_url":"https://github.com/ptaoussanis/sente/issues/272","id":179935364,"number":272,"title":"Calculate RTT for :chsk/ws-ping messages","user":{"login":"danielcompton","id":811954,"avatar_url":"https://avatars.githubusercontent.com/u/811954?v=3","gravatar_id":"","url":"https://api.github.com/users/danielcompton","html_url":"https://github.com/danielcompton","followers_url":"https://api.github.com/users/danielcompton/followers","following_url":"https://api.github.com/users/danielcompton/following{/other_user}","gists_url":"https://api.github.com/users/danielcompton/gists{/gist_id}","starred_url":"https://api.github.com/users/danielcompton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielcompton/subscriptions","organizations_url":"https://api.github.com/users/danielcompton/orgs","repos_url":"https://api.github.com/users/danielcompton/repos","events_url":"https://api.github.com/users/danielcompton/events{/privacy}","received_events_url":"https://api.github.com/users/danielcompton/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ptaoussanis/sente/labels/design%20needed","name":"design needed","color":"006b75"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-29T02:05:07Z","updated_at":"2016-09-30T03:39:48Z","closed_at":"2016-09-30T03:39:48Z","body":"It would be helpful for monitoring to see the round trip time for ping's (ping from server to client and reply to server again) to detect when clients have slow connections or there are other network issues. I don't have a really concrete design in mind, but here are a few thoughts:\r\n\r\n* This would probably require a sequence number on pings to correlate them\r\n* It's probably unnecessary to calculate this for all users all the time, it may be better to be able to sample them\r\n* This should be optional, as it probably incurs some overhead\r\n* I'm not sure where this info should go, on the connected uid's map?\r\n* I'm not sure what should be recorded? Do we record raw values, or present the user with summary statistics\r\n* Do we store this in a core.async dropping buffer, or some other limited size buffer?"}}
{"actor":{"display_login":"danielcompton"}}