{"action":"created","comment":{"url":"https://api.github.com/repos/Manishearth/rust-clippy/pulls/comments/55272740","id":55272740,"diff_hunk":"@@ -0,0 +1,41 @@\n+use rustc::lint::*;\n+use rustc_front::hir::*;\n+use utils::{span_lint, span_help_and_lint, snippet, span_lint_and_then};\n+\n+/// **What it does:** This lint finds classic overflow checks.\n+///\n+/// **Why is this bad?** Most classic C overflow checks will fail in Rust. Users can use functions like overflowing_* and wrapping_* instead.","path":"src/overflow_check_conditional.rs","position":7,"original_position":7,"commit_id":"9e0bf22f494b7345d855558fd355f3462e5bb14e","original_commit_id":"9e0bf22f494b7345d855558fd355f3462e5bb14e","user":{"login":"mcarton","id":3751788,"avatar_url":"https://avatars.githubusercontent.com/u/3751788?v=3","gravatar_id":"","url":"https://api.github.com/users/mcarton","html_url":"https://github.com/mcarton","followers_url":"https://api.github.com/users/mcarton/followers","following_url":"https://api.github.com/users/mcarton/following{/other_user}","gists_url":"https://api.github.com/users/mcarton/gists{/gist_id}","starred_url":"https://api.github.com/users/mcarton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcarton/subscriptions","organizations_url":"https://api.github.com/users/mcarton/orgs","repos_url":"https://api.github.com/users/mcarton/repos","events_url":"https://api.github.com/users/mcarton/events{/privacy}","received_events_url":"https://api.github.com/users/mcarton/received_events","type":"User","site_admin":false},"body":"Can you put `overflowing_*` and `wrapping_*` between quotes? Looks better on the wiki.\r\n```markdown\r\n`overflowing_*` and `wrapping_*`\r\n```","created_at":"2016-03-07T21:11:42Z","updated_at":"2016-03-07T21:11:42Z","html_url":"https://github.com/Manishearth/rust-clippy/pull/741#discussion_r55272740","pull_request_url":"https://api.github.com/repos/Manishearth/rust-clippy/pulls/741","_links":{"self":{"href":"https://api.github.com/repos/Manishearth/rust-clippy/pulls/comments/55272740"},"html":{"href":"https://github.com/Manishearth/rust-clippy/pull/741#discussion_r55272740"},"pull_request":{"href":"https://api.github.com/repos/Manishearth/rust-clippy/pulls/741"}}},"pull_request":{"url":"https://api.github.com/repos/Manishearth/rust-clippy/pulls/741","id":61844944,"html_url":"https://github.com/Manishearth/rust-clippy/pull/741","diff_url":"https://github.com/Manishearth/rust-clippy/pull/741.diff","patch_url":"https://github.com/Manishearth/rust-clippy/pull/741.patch","issue_url":"https://api.github.com/repos/Manishearth/rust-clippy/issues/741","number":741,"state":"open","locked":false,"title":"Linting classical overflow checks","user":{"login":"martiansideofthemoon","id":8805240,"avatar_url":"https://avatars.githubusercontent.com/u/8805240?v=3","gravatar_id":"","url":"https://api.github.com/users/martiansideofthemoon","html_url":"https://github.com/martiansideofthemoon","followers_url":"https://api.github.com/users/martiansideofthemoon/followers","following_url":"https://api.github.com/users/martiansideofthemoon/following{/other_user}","gists_url":"https://api.github.com/users/martiansideofthemoon/gists{/gist_id}","starred_url":"https://api.github.com/users/martiansideofthemoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martiansideofthemoon/subscriptions","organizations_url":"https://api.github.com/users/martiansideofthemoon/orgs","repos_url":"https://api.github.com/users/martiansideofthemoon/repos","events_url":"https://api.github.com/users/martiansideofthemoon/events{/privacy}","received_events_url":"https://api.github.com/users/martiansideofthemoon/received_events","type":"User","site_admin":false},"body":"@Manishearth , @mcarton getting a compile error in `cyclomatic_complexity.rs` as follows :- [https://pastebin.mozilla.org/8862490](https://pastebin.mozilla.org/8862490)","created_at":"2016-03-06T15:03:16Z","updated_at":"2016-03-07T21:11:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d88edbe45e29fabea90f58f74ba28c05714e5ce0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Manishearth/rust-clippy/pulls/741/commits","review_comments_url":"https://api.github.com/repos/Manishearth/rust-clippy/pulls/741/comments","review_comment_url":"https://api.github.com/repos/Manishearth/rust-clippy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Manishearth/rust-clippy/issues/741/comments","statuses_url":"https://api.github.com/repos/Manishearth/rust-clippy/statuses/9e0bf22f494b7345d855558fd355f3462e5bb14e","head":{"label":"martiansideofthemoon:blastoise","ref":"blastoise","sha":"9e0bf22f494b7345d855558fd355f3462e5bb14e","user":{"login":"martiansideofthemoon","id":8805240,"avatar_url":"https://avatars.githubusercontent.com/u/8805240?v=3","gravatar_id":"","url":"https://api.github.com/users/martiansideofthemoon","html_url":"https://github.com/martiansideofthemoon","followers_url":"https://api.github.com/users/martiansideofthemoon/followers","following_url":"https://api.github.com/users/martiansideofthemoon/following{/other_user}","gists_url":"https://api.github.com/users/martiansideofthemoon/gists{/gist_id}","starred_url":"https://api.github.com/users/martiansideofthemoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martiansideofthemoon/subscriptions","organizations_url":"https://api.github.com/users/martiansideofthemoon/orgs","repos_url":"https://api.github.com/users/martiansideofthemoon/repos","events_url":"https://api.github.com/users/martiansideofthemoon/events{/privacy}","received_events_url":"https://api.github.com/users/martiansideofthemoon/received_events","type":"User","site_admin":false},"repo":{"id":53069151,"name":"rust-clippy","full_name":"martiansideofthemoon/rust-clippy","owner":{"login":"martiansideofthemoon","id":8805240,"avatar_url":"https://avatars.githubusercontent.com/u/8805240?v=3","gravatar_id":"","url":"https://api.github.com/users/martiansideofthemoon","html_url":"https://github.com/martiansideofthemoon","followers_url":"https://api.github.com/users/martiansideofthemoon/followers","following_url":"https://api.github.com/users/martiansideofthemoon/following{/other_user}","gists_url":"https://api.github.com/users/martiansideofthemoon/gists{/gist_id}","starred_url":"https://api.github.com/users/martiansideofthemoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martiansideofthemoon/subscriptions","organizations_url":"https://api.github.com/users/martiansideofthemoon/orgs","repos_url":"https://api.github.com/users/martiansideofthemoon/repos","events_url":"https://api.github.com/users/martiansideofthemoon/events{/privacy}","received_events_url":"https://api.github.com/users/martiansideofthemoon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martiansideofthemoon/rust-clippy","description":"A bunch of lints to catch common mistakes and improve your Rust code","fork":true,"url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy","forks_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/forks","keys_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/teams","hooks_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/hooks","issue_events_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/issues/events{/number}","events_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/events","assignees_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/assignees{/user}","branches_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/branches{/branch}","tags_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/tags","blobs_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/git/refs{/sha}","trees_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/statuses/{sha}","languages_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/languages","stargazers_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/stargazers","contributors_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/contributors","subscribers_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/subscribers","subscription_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/subscription","commits_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/commits{/sha}","git_commits_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/git/commits{/sha}","comments_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/comments{/number}","issue_comment_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/issues/comments{/number}","contents_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/contents/{+path}","compare_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/merges","archive_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/downloads","issues_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/issues{/number}","pulls_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/pulls{/number}","milestones_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/milestones{/number}","notifications_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/labels{/name}","releases_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/releases{/id}","deployments_url":"https://api.github.com/repos/martiansideofthemoon/rust-clippy/deployments","created_at":"2016-03-03T17:22:08Z","updated_at":"2016-03-03T17:22:09Z","pushed_at":"2016-03-07T21:08:39Z","git_url":"git://github.com/martiansideofthemoon/rust-clippy.git","ssh_url":"git@github.com:martiansideofthemoon/rust-clippy.git","clone_url":"https://github.com/martiansideofthemoon/rust-clippy.git","svn_url":"https://github.com/martiansideofthemoon/rust-clippy","homepage":"","size":1615,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Manishearth:master","ref":"master","sha":"88ac226ac22a234b948fc78dceb953fceff8d6f7","user":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"repo":{"id":26850443,"name":"rust-clippy","full_name":"Manishearth/rust-clippy","owner":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Manishearth/rust-clippy","description":"A bunch of lints to catch common mistakes and improve your Rust code","fork":false,"url":"https://api.github.com/repos/Manishearth/rust-clippy","forks_url":"https://api.github.com/repos/Manishearth/rust-clippy/forks","keys_url":"https://api.github.com/repos/Manishearth/rust-clippy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Manishearth/rust-clippy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Manishearth/rust-clippy/teams","hooks_url":"https://api.github.com/repos/Manishearth/rust-clippy/hooks","issue_events_url":"https://api.github.com/repos/Manishearth/rust-clippy/issues/events{/number}","events_url":"https://api.github.com/repos/Manishearth/rust-clippy/events","assignees_url":"https://api.github.com/repos/Manishearth/rust-clippy/assignees{/user}","branches_url":"https://api.github.com/repos/Manishearth/rust-clippy/branches{/branch}","tags_url":"https://api.github.com/repos/Manishearth/rust-clippy/tags","blobs_url":"https://api.github.com/repos/Manishearth/rust-clippy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Manishearth/rust-clippy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Manishearth/rust-clippy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Manishearth/rust-clippy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Manishearth/rust-clippy/statuses/{sha}","languages_url":"https://api.github.com/repos/Manishearth/rust-clippy/languages","stargazers_url":"https://api.github.com/repos/Manishearth/rust-clippy/stargazers","contributors_url":"https://api.github.com/repos/Manishearth/rust-clippy/contributors","subscribers_url":"https://api.github.com/repos/Manishearth/rust-clippy/subscribers","subscription_url":"https://api.github.com/repos/Manishearth/rust-clippy/subscription","commits_url":"https://api.github.com/repos/Manishearth/rust-clippy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Manishearth/rust-clippy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Manishearth/rust-clippy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Manishearth/rust-clippy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Manishearth/rust-clippy/contents/{+path}","compare_url":"https://api.github.com/repos/Manishearth/rust-clippy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Manishearth/rust-clippy/merges","archive_url":"https://api.github.com/repos/Manishearth/rust-clippy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Manishearth/rust-clippy/downloads","issues_url":"https://api.github.com/repos/Manishearth/rust-clippy/issues{/number}","pulls_url":"https://api.github.com/repos/Manishearth/rust-clippy/pulls{/number}","milestones_url":"https://api.github.com/repos/Manishearth/rust-clippy/milestones{/number}","notifications_url":"https://api.github.com/repos/Manishearth/rust-clippy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Manishearth/rust-clippy/labels{/name}","releases_url":"https://api.github.com/repos/Manishearth/rust-clippy/releases{/id}","deployments_url":"https://api.github.com/repos/Manishearth/rust-clippy/deployments","created_at":"2014-11-19T07:49:21Z","updated_at":"2016-03-07T13:05:01Z","pushed_at":"2016-03-07T21:08:39Z","git_url":"git://github.com/Manishearth/rust-clippy.git","ssh_url":"git@github.com:Manishearth/rust-clippy.git","clone_url":"https://github.com/Manishearth/rust-clippy.git","svn_url":"https://github.com/Manishearth/rust-clippy","homepage":"","size":1766,"stargazers_count":487,"watchers_count":487,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":149,"forks":58,"open_issues":149,"watchers":487,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Manishearth/rust-clippy/pulls/741"},"html":{"href":"https://github.com/Manishearth/rust-clippy/pull/741"},"issue":{"href":"https://api.github.com/repos/Manishearth/rust-clippy/issues/741"},"comments":{"href":"https://api.github.com/repos/Manishearth/rust-clippy/issues/741/comments"},"review_comments":{"href":"https://api.github.com/repos/Manishearth/rust-clippy/pulls/741/comments"},"review_comment":{"href":"https://api.github.com/repos/Manishearth/rust-clippy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Manishearth/rust-clippy/pulls/741/commits"},"statuses":{"href":"https://api.github.com/repos/Manishearth/rust-clippy/statuses/9e0bf22f494b7345d855558fd355f3462e5bb14e"}}}}