{"action":"created","comment":{"url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/comments/80721034","pull_request_review_id":1752902,"id":80721034,"diff_hunk":"@@ -0,0 +1,253 @@\n+/*\n+ * Copyright 2015-2016 Red Hat, Inc. and/or its affiliates\n+ * and other contributors as indicated by the @author tags.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.hawkular.apm.tests.wildfly.zipkin;\n+\n+import java.io.IOException;\n+import java.util.ArrayList;\n+import java.util.Arrays;\n+import java.util.Collection;\n+import java.util.List;\n+import java.util.concurrent.TimeUnit;\n+\n+import org.hawkular.apm.analytics.service.rest.client.AnalyticsServiceRESTClient;\n+import org.hawkular.apm.api.model.Constants;\n+import org.hawkular.apm.api.model.analytics.CommunicationSummaryStatistics;\n+import org.hawkular.apm.api.model.analytics.NodeSummaryStatistics;\n+import org.hawkular.apm.api.model.events.CompletionTime;\n+import org.hawkular.apm.api.services.Criteria;\n+import org.hawkular.apm.api.utils.EndpointUtil;\n+import org.hawkular.apm.server.api.model.zipkin.AnnotationType;\n+import org.hawkular.apm.server.api.model.zipkin.BinaryAnnotation;\n+import org.hawkular.apm.server.api.model.zipkin.Span;\n+import org.hawkular.apm.tests.common.Wait;\n+import org.hawkular.apm.tests.wildfly.AbstractITest;\n+import org.junit.Assert;\n+import org.junit.Before;\n+import org.junit.BeforeClass;\n+import org.junit.Test;\n+\n+/**\n+ * @author Pavol Loffay\n+ */\n+public class SpanAnalyticsITest extends AbstractITest {\n+\n+    private static AnalyticsServiceRESTClient analyticsService;\n+\n+    @BeforeClass\n+    public static void beforeClass() {\n+        analyticsService = new AnalyticsServiceRESTClient();\n+        analyticsService.setUsername(HAWKULAR_APM_USERNAME);\n+        analyticsService.setPassword(HAWKULAR_APM_PASSWORD);\n+    }\n+\n+    @Before\n+    public void beforeTest() {\n+        analyticsService.clear(null);\n+    }\n+\n+    @Test\n+    public void testCompletionTime() throws IOException {\n+        BinaryAnnotation urlRootBinAnn = new BinaryAnnotation();\n+        urlRootBinAnn.setKey(Constants.ZIPKIN_BIN_ANNOTATION_HTTP_URL);\n+        urlRootBinAnn.setValue(\"http://localhost/root\");\n+        urlRootBinAnn.setType(AnnotationType.STRING);\n+\n+        Span rootSpan = new Span(Arrays.asList(urlRootBinAnn),\n+                SpanServiceITest.serverAnnotations(\n+                        SpanServiceITest.millisToMicroSeconds(1), SpanServiceITest.millisToMicroSeconds(30)));\n+        rootSpan.setTimestamp(SpanServiceITest.millisToMicroSeconds(1L));\n+        rootSpan.setDuration(SpanServiceITest.calculateDuration(1L, 30L));\n+        rootSpan.setTraceId(\"root\");\n+        rootSpan.setId(\"root\");\n+        rootSpan.setName(\"get\");\n+\n+        BinaryAnnotation urlServiceABinAnn = new BinaryAnnotation();\n+        urlServiceABinAnn.setKey(Constants.ZIPKIN_BIN_ANNOTATION_HTTP_URL);\n+        urlServiceABinAnn.setValue(\"http://localhost/serviceA\");\n+\n+        Span clientSpan = new Span(Arrays.asList(urlServiceABinAnn),\n+                SpanServiceITest.clientAnnotation(SpanServiceITest.millisToMicroSeconds(5),\n+                        SpanServiceITest.millisToMicroSeconds(15)));\n+        clientSpan.setTimestamp(SpanServiceITest.millisToMicroSeconds(5));\n+        clientSpan.setDuration(SpanServiceITest.calculateDuration(5L, 15L));\n+        clientSpan.setTraceId(rootSpan.getTraceId());\n+        clientSpan.setId(\"2\");\n+        clientSpan.setParentId(\"root\");\n+        clientSpan.setName(\"post\");\n+\n+        Span serverSpan = new Span(Arrays.asList(urlServiceABinAnn),\n+                SpanServiceITest.serverAnnotations(\n+                        SpanServiceITest.millisToMicroSeconds(7), SpanServiceITest.millisToMicroSeconds(10)));\n+        serverSpan.setTimestamp(SpanServiceITest.millisToMicroSeconds(7));\n+        serverSpan.setDuration(SpanServiceITest.calculateDuration(7L, 10L));\n+        serverSpan.setTraceId(rootSpan.getTraceId());\n+        serverSpan.setId(\"2\");\n+        serverSpan.setParentId(\"root\");\n+        serverSpan.setName(\"post\");\n+\n+        post(Server.Zipkin, \"/spans\", null, Arrays.asList(rootSpan));\n+        post(Server.Zipkin, \"/spans\", null, Arrays.asList(clientSpan));\n+        post(Server.Zipkin, \"/spans\", null, Arrays.asList(serverSpan));\n+\n+        Wait.until(() -> {\n+            List<CompletionTime> traceCompletionTimes = analyticsService.getTraceCompletionTimes(null, requestCriteria());\n+            return traceCompletionTimes == null || traceCompletionTimes.size() != 1 ? false : true;\n+        }, 30, TimeUnit.SECONDS);\n+\n+        List<CompletionTime> traceCompletionTimes = analyticsService.getTraceCompletionTimes(null, requestCriteria());\n+        Assert.assertEquals(1, traceCompletionTimes.size());\n+\n+        CompletionTime completionTime = traceCompletionTimes.get(0);\n+        Assert.assertEquals(rootSpan.getDuration(),\n+                TimeUnit.MICROSECONDS.convert(completionTime.getDuration(), TimeUnit.MILLISECONDS));\n+        Assert.assertEquals(\"/root\", completionTime.getUri());\n+        Assert.assertEquals(\"root\", completionTime.getId());\n+    }\n+","path":"tests/server/wildfly/src/test/java/org/hawkular/apm/tests/wildfly/zipkin/SpanAnalyticsITest.java","position":121,"original_position":121,"commit_id":"55d532530aa23cdcde83d2d88b08d560de6c086d","original_commit_id":"55d532530aa23cdcde83d2d88b08d560de6c086d","user":{"login":"objectiser","id":164562,"avatar_url":"https://avatars.githubusercontent.com/u/164562?v=3","gravatar_id":"","url":"https://api.github.com/users/objectiser","html_url":"https://github.com/objectiser","followers_url":"https://api.github.com/users/objectiser/followers","following_url":"https://api.github.com/users/objectiser/following{/other_user}","gists_url":"https://api.github.com/users/objectiser/gists{/gist_id}","starred_url":"https://api.github.com/users/objectiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectiser/subscriptions","organizations_url":"https://api.github.com/users/objectiser/orgs","repos_url":"https://api.github.com/users/objectiser/repos","events_url":"https://api.github.com/users/objectiser/events{/privacy}","received_events_url":"https://api.github.com/users/objectiser/received_events","type":"User","site_admin":false},"body":"Could you also add an example where the completion time is longer than the root span duration - i.e. the async case.","created_at":"2016-09-27T15:30:01Z","updated_at":"2016-09-27T15:40:50Z","html_url":"https://github.com/hawkular/hawkular-apm/pull/598#discussion_r80721034","pull_request_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/598","_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/comments/80721034"},"html":{"href":"https://github.com/hawkular/hawkular-apm/pull/598#discussion_r80721034"},"pull_request":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/598"}}},"pull_request":{"url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/598","id":86910456,"html_url":"https://github.com/hawkular/hawkular-apm/pull/598","diff_url":"https://github.com/hawkular/hawkular-apm/pull/598.diff","patch_url":"https://github.com/hawkular/hawkular-apm/pull/598.patch","issue_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues/598","number":598,"state":"open","locked":false,"title":"HWKAPM-521 | Zipkin integration tests for derived objects","user":{"login":"pavolloffay","id":5618424,"avatar_url":"https://avatars.githubusercontent.com/u/5618424?v=3","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false},"body":"https://issues.jboss.org/browse/HWKAPM-521\r\n\r\nReview notes:\r\n\r\nplease run `mvn clean install` in `tests/server/wildfly`","created_at":"2016-09-27T11:23:25Z","updated_at":"2016-09-27T15:40:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4066d379f558574b3ee4f96663d397c40efb29df","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/598/commits","review_comments_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/598/comments","review_comment_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues/598/comments","statuses_url":"https://api.github.com/repos/hawkular/hawkular-apm/statuses/55d532530aa23cdcde83d2d88b08d560de6c086d","head":{"label":"pavolloffay:HWKAPM-521-Integration-Tests-to-check-zipkin-reported-spans-trigger-derivation-of-information","ref":"HWKAPM-521-Integration-Tests-to-check-zipkin-reported-spans-trigger-derivation-of-information","sha":"55d532530aa23cdcde83d2d88b08d560de6c086d","user":{"login":"pavolloffay","id":5618424,"avatar_url":"https://avatars.githubusercontent.com/u/5618424?v=3","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false},"repo":{"id":54576177,"name":"hawkular-apm","full_name":"pavolloffay/hawkular-apm","owner":{"login":"pavolloffay","id":5618424,"avatar_url":"https://avatars.githubusercontent.com/u/5618424?v=3","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pavolloffay/hawkular-apm","description":"Business Transaction Management for Hawkular","fork":true,"url":"https://api.github.com/repos/pavolloffay/hawkular-apm","forks_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/forks","keys_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/teams","hooks_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/hooks","issue_events_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/issues/events{/number}","events_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/events","assignees_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/assignees{/user}","branches_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/branches{/branch}","tags_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/tags","blobs_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/git/refs{/sha}","trees_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/statuses/{sha}","languages_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/languages","stargazers_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/stargazers","contributors_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/contributors","subscribers_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/subscribers","subscription_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/subscription","commits_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/commits{/sha}","git_commits_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/git/commits{/sha}","comments_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/comments{/number}","issue_comment_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/issues/comments{/number}","contents_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/contents/{+path}","compare_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/merges","archive_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/downloads","issues_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/issues{/number}","pulls_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/pulls{/number}","milestones_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/milestones{/number}","notifications_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/labels{/name}","releases_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/releases{/id}","deployments_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/deployments","created_at":"2016-03-23T16:34:43Z","updated_at":"2016-07-15T10:12:23Z","pushed_at":"2016-09-27T15:03:19Z","git_url":"git://github.com/pavolloffay/hawkular-apm.git","ssh_url":"git@github.com:pavolloffay/hawkular-apm.git","clone_url":"https://github.com/pavolloffay/hawkular-apm.git","svn_url":"https://github.com/pavolloffay/hawkular-apm","homepage":"","size":6401,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hawkular:master","ref":"master","sha":"1135313e1a7a2c00907b268286b0b5ecd6162963","user":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"repo":{"id":34446334,"name":"hawkular-apm","full_name":"hawkular/hawkular-apm","owner":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hawkular/hawkular-apm","description":"Distributed Tracing and Application Performance Management","fork":false,"url":"https://api.github.com/repos/hawkular/hawkular-apm","forks_url":"https://api.github.com/repos/hawkular/hawkular-apm/forks","keys_url":"https://api.github.com/repos/hawkular/hawkular-apm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hawkular/hawkular-apm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hawkular/hawkular-apm/teams","hooks_url":"https://api.github.com/repos/hawkular/hawkular-apm/hooks","issue_events_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues/events{/number}","events_url":"https://api.github.com/repos/hawkular/hawkular-apm/events","assignees_url":"https://api.github.com/repos/hawkular/hawkular-apm/assignees{/user}","branches_url":"https://api.github.com/repos/hawkular/hawkular-apm/branches{/branch}","tags_url":"https://api.github.com/repos/hawkular/hawkular-apm/tags","blobs_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/refs{/sha}","trees_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hawkular/hawkular-apm/statuses/{sha}","languages_url":"https://api.github.com/repos/hawkular/hawkular-apm/languages","stargazers_url":"https://api.github.com/repos/hawkular/hawkular-apm/stargazers","contributors_url":"https://api.github.com/repos/hawkular/hawkular-apm/contributors","subscribers_url":"https://api.github.com/repos/hawkular/hawkular-apm/subscribers","subscription_url":"https://api.github.com/repos/hawkular/hawkular-apm/subscription","commits_url":"https://api.github.com/repos/hawkular/hawkular-apm/commits{/sha}","git_commits_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/commits{/sha}","comments_url":"https://api.github.com/repos/hawkular/hawkular-apm/comments{/number}","issue_comment_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues/comments{/number}","contents_url":"https://api.github.com/repos/hawkular/hawkular-apm/contents/{+path}","compare_url":"https://api.github.com/repos/hawkular/hawkular-apm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hawkular/hawkular-apm/merges","archive_url":"https://api.github.com/repos/hawkular/hawkular-apm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hawkular/hawkular-apm/downloads","issues_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues{/number}","pulls_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls{/number}","milestones_url":"https://api.github.com/repos/hawkular/hawkular-apm/milestones{/number}","notifications_url":"https://api.github.com/repos/hawkular/hawkular-apm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hawkular/hawkular-apm/labels{/name}","releases_url":"https://api.github.com/repos/hawkular/hawkular-apm/releases{/id}","deployments_url":"https://api.github.com/repos/hawkular/hawkular-apm/deployments","created_at":"2015-04-23T09:17:50Z","updated_at":"2016-09-23T00:56:14Z","pushed_at":"2016-09-27T15:09:13Z","git_url":"git://github.com/hawkular/hawkular-apm.git","ssh_url":"git@github.com:hawkular/hawkular-apm.git","clone_url":"https://github.com/hawkular/hawkular-apm.git","svn_url":"https://github.com/hawkular/hawkular-apm","homepage":"","size":6417,"stargazers_count":23,"watchers_count":23,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":7,"forks":16,"open_issues":7,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/598"},"html":{"href":"https://github.com/hawkular/hawkular-apm/pull/598"},"issue":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/issues/598"},"comments":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/issues/598/comments"},"review_comments":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/598/comments"},"review_comment":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/598/commits"},"statuses":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/statuses/55d532530aa23cdcde83d2d88b08d560de6c086d"}}}}
{"actor":{"display_login":"objectiser"}}