{"action":"opened","number":47,"pull_request":{"url":"https://api.github.com/repos/rburkey2005/virtualagc/pulls/47","id":83563610,"html_url":"https://github.com/rburkey2005/virtualagc/pull/47","diff_url":"https://github.com/rburkey2005/virtualagc/pull/47.diff","patch_url":"https://github.com/rburkey2005/virtualagc/pull/47.patch","issue_url":"https://api.github.com/repos/rburkey2005/virtualagc/issues/47","number":47,"state":"open","locked":false,"title":"Updated handling of TIME6 and T6RUPT. Hopefully fixes #46.","user":{"login":"thewonderidiot","id":94056,"avatar_url":"https://avatars.githubusercontent.com/u/94056?v=3","gravatar_id":"","url":"https://api.github.com/users/thewonderidiot","html_url":"https://github.com/thewonderidiot","followers_url":"https://api.github.com/users/thewonderidiot/followers","following_url":"https://api.github.com/users/thewonderidiot/following{/other_user}","gists_url":"https://api.github.com/users/thewonderidiot/gists{/gist_id}","starred_url":"https://api.github.com/users/thewonderidiot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewonderidiot/subscriptions","organizations_url":"https://api.github.com/users/thewonderidiot/orgs","repos_url":"https://api.github.com/users/thewonderidiot/repos","events_url":"https://api.github.com/users/thewonderidiot/events{/privacy}","received_events_url":"https://api.github.com/users/thewonderidiot/received_events","type":"User","site_admin":false},"body":"In theory this should make handling of TIME6 much more accurate, and fix #46. Rationale for the changes:\r\n\r\n![t6on](https://cloud.githubusercontent.com/assets/94056/18153647/c6c1418a-6fb3-11e6-9e45-1b7fda12a5c9.png)\r\nT6P, the counter pulse that generates a counter request on TIME6, can only occur if T6ON is set via CH13 bit 15. If not set, TIME6 cannot increment.\r\n\r\n![t6on_clear](https://cloud.githubusercontent.com/assets/94056/18153706/1031bee4-6fb4-11e6-853b-906cf66c9a7c.png)\r\nT6ON, in turn, is cleared when T6RPT is triggered.\r\n\r\n![t6rpt](https://cloud.githubusercontent.com/assets/94056/18153746/4fd379fc-6fb4-11e6-838e-8f2d9b0f8989.png)\r\nT6RPT requests are generated when a ZOUT pulse is emitted for counter 31, AKA TIME6 (the other two inputs on that gate are counter addressing)\r\n\r\nAnd lastly, a quick look at the sim, on the DINC *before* ZOUT occurs and T6RUPT is generated:\r\n![dinc_cycle](https://cloud.githubusercontent.com/assets/94056/18153893/27c1bd2e-6fb5-11e6-972c-2d0f7879577a.png)\r\n\r\nThe control pulses generated by the sim match what is described by Hugh Blair-Smith in his Memo#9:\r\n```\r\nDINC\r\n\r\n 1. xx  RSCT   WS\r\n 2. xx  RSC    WG\r\n 5. xx  RG     WY     TSGN   TMZ    TPZG\r\n 6. 00  MONEX  POUT\r\n 6. 10  PONEX  MOUT\r\n 6. x1         ZOUT\r\n 7. xx  RU     WSC    WG     WOVR\r\n 8. xx  RB     WS\r\n```\r\nI won't go through every step (unless requested), but the important bits are:\r\n**T01.** RSCT WS reads the counter cells to determine which counter is being addressed. This is why the DINC line doesn't go high until T02; the computer doesn't know it's doing a DINC yet\r\n**T05.** The current counter value is put into one input of the adder, and tested for polarity and zero-ness. We read a positive 1, so no tests pass and the branch registers remain 0.\r\n**T06.** MONEX puts -1 into the other adder input, and generates a POUT. Note that POUT lasts longer than all the other control pulses -- that's because it's apparently timed with the CDU strobe, rather than one of the 12 fundamental timepulses.\r\n**T07.** Reads the results of 1 + (-1) out of the adder and puts them into G. This is where the vertical cursor is; the result is -0.\r\n\r\nAccording to the sim, TIME6 increments 0.3125ms after TIME1 and TIME3 do. That's smaller than VirtualAGC is even ticking the clocks right now, so I doubt the delta is going to matter for simulation purposes. It might, though, so it's worth noting.\r\n\r\n@eddievhfan1984, can you give this a whirl and see if it fixes your program alarms?","created_at":"2016-09-01T03:09:10Z","updated_at":"2016-09-01T03:09:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rburkey2005/virtualagc/pulls/47/commits","review_comments_url":"https://api.github.com/repos/rburkey2005/virtualagc/pulls/47/comments","review_comment_url":"https://api.github.com/repos/rburkey2005/virtualagc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rburkey2005/virtualagc/issues/47/comments","statuses_url":"https://api.github.com/repos/rburkey2005/virtualagc/statuses/fd205ce62fe00587fdef69712d42d41d7a1bfc70","head":{"label":"thewonderidiot:time6_fixes","ref":"time6_fixes","sha":"fd205ce62fe00587fdef69712d42d41d7a1bfc70","user":{"login":"thewonderidiot","id":94056,"avatar_url":"https://avatars.githubusercontent.com/u/94056?v=3","gravatar_id":"","url":"https://api.github.com/users/thewonderidiot","html_url":"https://github.com/thewonderidiot","followers_url":"https://api.github.com/users/thewonderidiot/followers","following_url":"https://api.github.com/users/thewonderidiot/following{/other_user}","gists_url":"https://api.github.com/users/thewonderidiot/gists{/gist_id}","starred_url":"https://api.github.com/users/thewonderidiot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewonderidiot/subscriptions","organizations_url":"https://api.github.com/users/thewonderidiot/orgs","repos_url":"https://api.github.com/users/thewonderidiot/repos","events_url":"https://api.github.com/users/thewonderidiot/events{/privacy}","received_events_url":"https://api.github.com/users/thewonderidiot/received_events","type":"User","site_admin":false},"repo":{"id":52065209,"name":"virtualagc","full_name":"thewonderidiot/virtualagc","owner":{"login":"thewonderidiot","id":94056,"avatar_url":"https://avatars.githubusercontent.com/u/94056?v=3","gravatar_id":"","url":"https://api.github.com/users/thewonderidiot","html_url":"https://github.com/thewonderidiot","followers_url":"https://api.github.com/users/thewonderidiot/followers","following_url":"https://api.github.com/users/thewonderidiot/following{/other_user}","gists_url":"https://api.github.com/users/thewonderidiot/gists{/gist_id}","starred_url":"https://api.github.com/users/thewonderidiot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewonderidiot/subscriptions","organizations_url":"https://api.github.com/users/thewonderidiot/orgs","repos_url":"https://api.github.com/users/thewonderidiot/repos","events_url":"https://api.github.com/users/thewonderidiot/events{/privacy}","received_events_url":"https://api.github.com/users/thewonderidiot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thewonderidiot/virtualagc","description":"Virtual Apollo Guidance Computer (AGC) software","fork":true,"url":"https://api.github.com/repos/thewonderidiot/virtualagc","forks_url":"https://api.github.com/repos/thewonderidiot/virtualagc/forks","keys_url":"https://api.github.com/repos/thewonderidiot/virtualagc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thewonderidiot/virtualagc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thewonderidiot/virtualagc/teams","hooks_url":"https://api.github.com/repos/thewonderidiot/virtualagc/hooks","issue_events_url":"https://api.github.com/repos/thewonderidiot/virtualagc/issues/events{/number}","events_url":"https://api.github.com/repos/thewonderidiot/virtualagc/events","assignees_url":"https://api.github.com/repos/thewonderidiot/virtualagc/assignees{/user}","branches_url":"https://api.github.com/repos/thewonderidiot/virtualagc/branches{/branch}","tags_url":"https://api.github.com/repos/thewonderidiot/virtualagc/tags","blobs_url":"https://api.github.com/repos/thewonderidiot/virtualagc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thewonderidiot/virtualagc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thewonderidiot/virtualagc/git/refs{/sha}","trees_url":"https://api.github.com/repos/thewonderidiot/virtualagc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thewonderidiot/virtualagc/statuses/{sha}","languages_url":"https://api.github.com/repos/thewonderidiot/virtualagc/languages","stargazers_url":"https://api.github.com/repos/thewonderidiot/virtualagc/stargazers","contributors_url":"https://api.github.com/repos/thewonderidiot/virtualagc/contributors","subscribers_url":"https://api.github.com/repos/thewonderidiot/virtualagc/subscribers","subscription_url":"https://api.github.com/repos/thewonderidiot/virtualagc/subscription","commits_url":"https://api.github.com/repos/thewonderidiot/virtualagc/commits{/sha}","git_commits_url":"https://api.github.com/repos/thewonderidiot/virtualagc/git/commits{/sha}","comments_url":"https://api.github.com/repos/thewonderidiot/virtualagc/comments{/number}","issue_comment_url":"https://api.github.com/repos/thewonderidiot/virtualagc/issues/comments{/number}","contents_url":"https://api.github.com/repos/thewonderidiot/virtualagc/contents/{+path}","compare_url":"https://api.github.com/repos/thewonderidiot/virtualagc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thewonderidiot/virtualagc/merges","archive_url":"https://api.github.com/repos/thewonderidiot/virtualagc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thewonderidiot/virtualagc/downloads","issues_url":"https://api.github.com/repos/thewonderidiot/virtualagc/issues{/number}","pulls_url":"https://api.github.com/repos/thewonderidiot/virtualagc/pulls{/number}","milestones_url":"https://api.github.com/repos/thewonderidiot/virtualagc/milestones{/number}","notifications_url":"https://api.github.com/repos/thewonderidiot/virtualagc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thewonderidiot/virtualagc/labels{/name}","releases_url":"https://api.github.com/repos/thewonderidiot/virtualagc/releases{/id}","deployments_url":"https://api.github.com/repos/thewonderidiot/virtualagc/deployments","created_at":"2016-02-19T06:01:45Z","updated_at":"2016-08-31T22:19:54Z","pushed_at":"2016-09-01T02:45:32Z","git_url":"git://github.com/thewonderidiot/virtualagc.git","ssh_url":"git@github.com:thewonderidiot/virtualagc.git","clone_url":"https://github.com/thewonderidiot/virtualagc.git","svn_url":"https://github.com/thewonderidiot/virtualagc","homepage":"http://www.ibiblio.org/apollo","size":10885,"stargazers_count":1,"watchers_count":1,"language":"Assembly","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rburkey2005:master","ref":"master","sha":"d042fd025834ed52c43f16826a56f323450be07b","user":{"login":"rburkey2005","id":11841400,"avatar_url":"https://avatars.githubusercontent.com/u/11841400?v=3","gravatar_id":"","url":"https://api.github.com/users/rburkey2005","html_url":"https://github.com/rburkey2005","followers_url":"https://api.github.com/users/rburkey2005/followers","following_url":"https://api.github.com/users/rburkey2005/following{/other_user}","gists_url":"https://api.github.com/users/rburkey2005/gists{/gist_id}","starred_url":"https://api.github.com/users/rburkey2005/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rburkey2005/subscriptions","organizations_url":"https://api.github.com/users/rburkey2005/orgs","repos_url":"https://api.github.com/users/rburkey2005/repos","events_url":"https://api.github.com/users/rburkey2005/events{/privacy}","received_events_url":"https://api.github.com/users/rburkey2005/received_events","type":"User","site_admin":false},"repo":{"id":33563164,"name":"virtualagc","full_name":"rburkey2005/virtualagc","owner":{"login":"rburkey2005","id":11841400,"avatar_url":"https://avatars.githubusercontent.com/u/11841400?v=3","gravatar_id":"","url":"https://api.github.com/users/rburkey2005","html_url":"https://github.com/rburkey2005","followers_url":"https://api.github.com/users/rburkey2005/followers","following_url":"https://api.github.com/users/rburkey2005/following{/other_user}","gists_url":"https://api.github.com/users/rburkey2005/gists{/gist_id}","starred_url":"https://api.github.com/users/rburkey2005/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rburkey2005/subscriptions","organizations_url":"https://api.github.com/users/rburkey2005/orgs","repos_url":"https://api.github.com/users/rburkey2005/repos","events_url":"https://api.github.com/users/rburkey2005/events{/privacy}","received_events_url":"https://api.github.com/users/rburkey2005/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rburkey2005/virtualagc","description":"Virtual Apollo Guidance Computer (AGC) software","fork":false,"url":"https://api.github.com/repos/rburkey2005/virtualagc","forks_url":"https://api.github.com/repos/rburkey2005/virtualagc/forks","keys_url":"https://api.github.com/repos/rburkey2005/virtualagc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rburkey2005/virtualagc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rburkey2005/virtualagc/teams","hooks_url":"https://api.github.com/repos/rburkey2005/virtualagc/hooks","issue_events_url":"https://api.github.com/repos/rburkey2005/virtualagc/issues/events{/number}","events_url":"https://api.github.com/repos/rburkey2005/virtualagc/events","assignees_url":"https://api.github.com/repos/rburkey2005/virtualagc/assignees{/user}","branches_url":"https://api.github.com/repos/rburkey2005/virtualagc/branches{/branch}","tags_url":"https://api.github.com/repos/rburkey2005/virtualagc/tags","blobs_url":"https://api.github.com/repos/rburkey2005/virtualagc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rburkey2005/virtualagc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rburkey2005/virtualagc/git/refs{/sha}","trees_url":"https://api.github.com/repos/rburkey2005/virtualagc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rburkey2005/virtualagc/statuses/{sha}","languages_url":"https://api.github.com/repos/rburkey2005/virtualagc/languages","stargazers_url":"https://api.github.com/repos/rburkey2005/virtualagc/stargazers","contributors_url":"https://api.github.com/repos/rburkey2005/virtualagc/contributors","subscribers_url":"https://api.github.com/repos/rburkey2005/virtualagc/subscribers","subscription_url":"https://api.github.com/repos/rburkey2005/virtualagc/subscription","commits_url":"https://api.github.com/repos/rburkey2005/virtualagc/commits{/sha}","git_commits_url":"https://api.github.com/repos/rburkey2005/virtualagc/git/commits{/sha}","comments_url":"https://api.github.com/repos/rburkey2005/virtualagc/comments{/number}","issue_comment_url":"https://api.github.com/repos/rburkey2005/virtualagc/issues/comments{/number}","contents_url":"https://api.github.com/repos/rburkey2005/virtualagc/contents/{+path}","compare_url":"https://api.github.com/repos/rburkey2005/virtualagc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rburkey2005/virtualagc/merges","archive_url":"https://api.github.com/repos/rburkey2005/virtualagc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rburkey2005/virtualagc/downloads","issues_url":"https://api.github.com/repos/rburkey2005/virtualagc/issues{/number}","pulls_url":"https://api.github.com/repos/rburkey2005/virtualagc/pulls{/number}","milestones_url":"https://api.github.com/repos/rburkey2005/virtualagc/milestones{/number}","notifications_url":"https://api.github.com/repos/rburkey2005/virtualagc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rburkey2005/virtualagc/labels{/name}","releases_url":"https://api.github.com/repos/rburkey2005/virtualagc/releases{/id}","deployments_url":"https://api.github.com/repos/rburkey2005/virtualagc/deployments","created_at":"2015-04-07T19:17:25Z","updated_at":"2016-08-31T09:08:46Z","pushed_at":"2016-09-01T01:14:13Z","git_url":"git://github.com/rburkey2005/virtualagc.git","ssh_url":"git@github.com:rburkey2005/virtualagc.git","clone_url":"https://github.com/rburkey2005/virtualagc.git","svn_url":"https://github.com/rburkey2005/virtualagc","homepage":"http://www.ibiblio.org/apollo","size":78051,"stargazers_count":292,"watchers_count":292,"language":"Assembly","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":56,"mirror_url":null,"open_issues_count":13,"forks":56,"open_issues":13,"watchers":292,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rburkey2005/virtualagc/pulls/47"},"html":{"href":"https://github.com/rburkey2005/virtualagc/pull/47"},"issue":{"href":"https://api.github.com/repos/rburkey2005/virtualagc/issues/47"},"comments":{"href":"https://api.github.com/repos/rburkey2005/virtualagc/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/rburkey2005/virtualagc/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/rburkey2005/virtualagc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rburkey2005/virtualagc/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/rburkey2005/virtualagc/statuses/fd205ce62fe00587fdef69712d42d41d7a1bfc70"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":29,"deletions":46,"changed_files":1}}
{"actor":{"display_login":"thewonderidiot"}}