{"action":"created","comment":{"url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/pulls/comments/90861361","pull_request_review_id":11372620,"id":90861361,"diff_hunk":"@@ -0,0 +1,16 @@\n+'use strict';\n+\n+const BASE_SCHEMA = './schema.json';\n+\n+/**\n+ * Loads custom schema from config or fixed base schema\n+ *\n+ * @param {Config} config\n+ *\n+ * @returns {Object}\n+ */\n+module.exports = config => {\n+    const customSchema = config.getConfig().schema;\n+\n+    return require(customSchema ? config.resolvePath(customSchema) : BASE_SCHEMA);","path":"lib/loader.js","position":15,"original_position":15,"commit_id":"33d2004bcbffe57b7292a693fa50922cd9652e73","original_commit_id":"33d2004bcbffe57b7292a693fa50922cd9652e73","user":{"login":"dima117","id":5608639,"avatar_url":"https://avatars.githubusercontent.com/u/5608639?v=3","gravatar_id":"","url":"https://api.github.com/users/dima117","html_url":"https://github.com/dima117","followers_url":"https://api.github.com/users/dima117/followers","following_url":"https://api.github.com/users/dima117/following{/other_user}","gists_url":"https://api.github.com/users/dima117/gists{/gist_id}","starred_url":"https://api.github.com/users/dima117/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dima117/subscriptions","organizations_url":"https://api.github.com/users/dima117/orgs","repos_url":"https://api.github.com/users/dima117/repos","events_url":"https://api.github.com/users/dima117/events{/privacy}","received_events_url":"https://api.github.com/users/dima117/received_events","type":"User","site_admin":false},"body":"предлагаю загружать схему внутри валидатора и там же кэшировать (в качестве ключа - разрезолвленный путь)","created_at":"2016-12-05T13:14:53Z","updated_at":"2016-12-05T13:22:33Z","html_url":"https://github.com/bemhint/bemhint-deps-schema/pull/7#discussion_r90861361","pull_request_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/bemhint/bemhint-deps-schema/pulls/comments/90861361"},"html":{"href":"https://github.com/bemhint/bemhint-deps-schema/pull/7#discussion_r90861361"},"pull_request":{"href":"https://api.github.com/repos/bemhint/bemhint-deps-schema/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/pulls/7","id":93480971,"html_url":"https://github.com/bemhint/bemhint-deps-schema/pull/7","diff_url":"https://github.com/bemhint/bemhint-deps-schema/pull/7.diff","patch_url":"https://github.com/bemhint/bemhint-deps-schema/pull/7.patch","issue_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/issues/7","number":7,"state":"open","locked":false,"title":"Custom schema and elem-mod-issue fix","user":{"login":"Vittly","id":1221916,"avatar_url":"https://avatars.githubusercontent.com/u/1221916?v=3","gravatar_id":"","url":"https://api.github.com/users/Vittly","html_url":"https://github.com/Vittly","followers_url":"https://api.github.com/users/Vittly/followers","following_url":"https://api.github.com/users/Vittly/following{/other_user}","gists_url":"https://api.github.com/users/Vittly/gists{/gist_id}","starred_url":"https://api.github.com/users/Vittly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vittly/subscriptions","organizations_url":"https://api.github.com/users/Vittly/orgs","repos_url":"https://api.github.com/users/Vittly/repos","events_url":"https://api.github.com/users/Vittly/events{/privacy}","received_events_url":"https://api.github.com/users/Vittly/received_events","type":"User","site_admin":false},"body":"* Добавил `mod`/`val` в элемент, записываемый в виде объекта\r\n* Доприбирался в тестах\r\n* Добавил возможность задавать в настройках кастомну схему (из проекта)","created_at":"2016-11-13T18:12:37Z","updated_at":"2016-12-05T13:22:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17ff61957b40901ada7c9b6bcd28ea9739e1ac60","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/pulls/7/commits","review_comments_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/pulls/7/comments","review_comment_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/issues/7/comments","statuses_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/statuses/33d2004bcbffe57b7292a693fa50922cd9652e73","head":{"label":"Vittly:external-schema-issue","ref":"external-schema-issue","sha":"33d2004bcbffe57b7292a693fa50922cd9652e73","user":{"login":"Vittly","id":1221916,"avatar_url":"https://avatars.githubusercontent.com/u/1221916?v=3","gravatar_id":"","url":"https://api.github.com/users/Vittly","html_url":"https://github.com/Vittly","followers_url":"https://api.github.com/users/Vittly/followers","following_url":"https://api.github.com/users/Vittly/following{/other_user}","gists_url":"https://api.github.com/users/Vittly/gists{/gist_id}","starred_url":"https://api.github.com/users/Vittly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vittly/subscriptions","organizations_url":"https://api.github.com/users/Vittly/orgs","repos_url":"https://api.github.com/users/Vittly/repos","events_url":"https://api.github.com/users/Vittly/events{/privacy}","received_events_url":"https://api.github.com/users/Vittly/received_events","type":"User","site_admin":false},"repo":{"id":72998762,"name":"bemhint-deps-schema","full_name":"Vittly/bemhint-deps-schema","owner":{"login":"Vittly","id":1221916,"avatar_url":"https://avatars.githubusercontent.com/u/1221916?v=3","gravatar_id":"","url":"https://api.github.com/users/Vittly","html_url":"https://github.com/Vittly","followers_url":"https://api.github.com/users/Vittly/followers","following_url":"https://api.github.com/users/Vittly/following{/other_user}","gists_url":"https://api.github.com/users/Vittly/gists{/gist_id}","starred_url":"https://api.github.com/users/Vittly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vittly/subscriptions","organizations_url":"https://api.github.com/users/Vittly/orgs","repos_url":"https://api.github.com/users/Vittly/repos","events_url":"https://api.github.com/users/Vittly/events{/privacy}","received_events_url":"https://api.github.com/users/Vittly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Vittly/bemhint-deps-schema","description":"Plugin for bemhint which checks *.deps.js to be written by specification","fork":true,"url":"https://api.github.com/repos/Vittly/bemhint-deps-schema","forks_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/forks","keys_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/teams","hooks_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/hooks","issue_events_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/issues/events{/number}","events_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/events","assignees_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/assignees{/user}","branches_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/branches{/branch}","tags_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/tags","blobs_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/statuses/{sha}","languages_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/languages","stargazers_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/stargazers","contributors_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/contributors","subscribers_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/subscribers","subscription_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/subscription","commits_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/contents/{+path}","compare_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/merges","archive_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/downloads","issues_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/issues{/number}","pulls_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/pulls{/number}","milestones_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/milestones{/number}","notifications_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/labels{/name}","releases_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/releases{/id}","deployments_url":"https://api.github.com/repos/Vittly/bemhint-deps-schema/deployments","created_at":"2016-11-06T15:12:36Z","updated_at":"2016-11-06T15:12:38Z","pushed_at":"2016-12-04T08:26:40Z","git_url":"git://github.com/Vittly/bemhint-deps-schema.git","ssh_url":"git@github.com:Vittly/bemhint-deps-schema.git","clone_url":"https://github.com/Vittly/bemhint-deps-schema.git","svn_url":"https://github.com/Vittly/bemhint-deps-schema","homepage":"","size":57,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bemhint:master","ref":"master","sha":"db1b3fed4f77913cef82cd32be31606481943267","user":{"login":"bemhint","id":18241542,"avatar_url":"https://avatars.githubusercontent.com/u/18241542?v=3","gravatar_id":"","url":"https://api.github.com/users/bemhint","html_url":"https://github.com/bemhint","followers_url":"https://api.github.com/users/bemhint/followers","following_url":"https://api.github.com/users/bemhint/following{/other_user}","gists_url":"https://api.github.com/users/bemhint/gists{/gist_id}","starred_url":"https://api.github.com/users/bemhint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bemhint/subscriptions","organizations_url":"https://api.github.com/users/bemhint/orgs","repos_url":"https://api.github.com/users/bemhint/repos","events_url":"https://api.github.com/users/bemhint/events{/privacy}","received_events_url":"https://api.github.com/users/bemhint/received_events","type":"Organization","site_admin":false},"repo":{"id":59286448,"name":"bemhint-deps-schema","full_name":"bemhint/bemhint-deps-schema","owner":{"login":"bemhint","id":18241542,"avatar_url":"https://avatars.githubusercontent.com/u/18241542?v=3","gravatar_id":"","url":"https://api.github.com/users/bemhint","html_url":"https://github.com/bemhint","followers_url":"https://api.github.com/users/bemhint/followers","following_url":"https://api.github.com/users/bemhint/following{/other_user}","gists_url":"https://api.github.com/users/bemhint/gists{/gist_id}","starred_url":"https://api.github.com/users/bemhint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bemhint/subscriptions","organizations_url":"https://api.github.com/users/bemhint/orgs","repos_url":"https://api.github.com/users/bemhint/repos","events_url":"https://api.github.com/users/bemhint/events{/privacy}","received_events_url":"https://api.github.com/users/bemhint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bemhint/bemhint-deps-schema","description":"Plugin for bemhint which checks *.deps.js to be written by specification","fork":false,"url":"https://api.github.com/repos/bemhint/bemhint-deps-schema","forks_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/forks","keys_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/teams","hooks_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/hooks","issue_events_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/issues/events{/number}","events_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/events","assignees_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/assignees{/user}","branches_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/branches{/branch}","tags_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/tags","blobs_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/git/refs{/sha}","trees_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/statuses/{sha}","languages_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/languages","stargazers_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/stargazers","contributors_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/contributors","subscribers_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/subscribers","subscription_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/subscription","commits_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/commits{/sha}","git_commits_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/git/commits{/sha}","comments_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/comments{/number}","issue_comment_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/issues/comments{/number}","contents_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/contents/{+path}","compare_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/merges","archive_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/downloads","issues_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/issues{/number}","pulls_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/pulls{/number}","milestones_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/milestones{/number}","notifications_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/labels{/name}","releases_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/releases{/id}","deployments_url":"https://api.github.com/repos/bemhint/bemhint-deps-schema/deployments","created_at":"2016-05-20T10:37:06Z","updated_at":"2016-11-15T12:36:10Z","pushed_at":"2016-12-04T08:26:41Z","git_url":"git://github.com/bemhint/bemhint-deps-schema.git","ssh_url":"git@github.com:bemhint/bemhint-deps-schema.git","clone_url":"https://github.com/bemhint/bemhint-deps-schema.git","svn_url":"https://github.com/bemhint/bemhint-deps-schema","homepage":"","size":41,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":8,"forks":1,"open_issues":8,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bemhint/bemhint-deps-schema/pulls/7"},"html":{"href":"https://github.com/bemhint/bemhint-deps-schema/pull/7"},"issue":{"href":"https://api.github.com/repos/bemhint/bemhint-deps-schema/issues/7"},"comments":{"href":"https://api.github.com/repos/bemhint/bemhint-deps-schema/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/bemhint/bemhint-deps-schema/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/bemhint/bemhint-deps-schema/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bemhint/bemhint-deps-schema/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/bemhint/bemhint-deps-schema/statuses/33d2004bcbffe57b7292a693fa50922cd9652e73"}}}}
{"actor":{"display_login":"dima117"}}