{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react/issues/8479","repository_url":"https://api.github.com/repos/facebook/react","labels_url":"https://api.github.com/repos/facebook/react/issues/8479/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react/issues/8479/comments","events_url":"https://api.github.com/repos/facebook/react/issues/8479/events","html_url":"https://github.com/facebook/react/pull/8479","id":193042808,"number":8479,"title":"[Fiber] Scheduler improvements","user":{"login":"acdlite","id":3624098,"avatar_url":"https://avatars.githubusercontent.com/u/3624098?v=3","gravatar_id":"","url":"https://api.github.com/users/acdlite","html_url":"https://github.com/acdlite","followers_url":"https://api.github.com/users/acdlite/followers","following_url":"https://api.github.com/users/acdlite/following{/other_user}","gists_url":"https://api.github.com/users/acdlite/gists{/gist_id}","starred_url":"https://api.github.com/users/acdlite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acdlite/subscriptions","organizations_url":"https://api.github.com/users/acdlite/orgs","repos_url":"https://api.github.com/users/acdlite/repos","events_url":"https://api.github.com/users/acdlite/events{/privacy}","received_events_url":"https://api.github.com/users/acdlite/received_events","type":"User","site_admin":false},"labels":[{"id":196858374,"url":"https://api.github.com/repos/facebook/react/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7","default":false},{"id":130714673,"url":"https://api.github.com/repos/facebook/react/labels/GH%20Review:%20accepted","name":"GH Review: accepted","color":"009800","default":false}],"state":"open","locked":false,"assignee":{"login":"sebmarkbage","id":63648,"avatar_url":"https://avatars.githubusercontent.com/u/63648?v=3","gravatar_id":"","url":"https://api.github.com/users/sebmarkbage","html_url":"https://github.com/sebmarkbage","followers_url":"https://api.github.com/users/sebmarkbage/followers","following_url":"https://api.github.com/users/sebmarkbage/following{/other_user}","gists_url":"https://api.github.com/users/sebmarkbage/gists{/gist_id}","starred_url":"https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebmarkbage/subscriptions","organizations_url":"https://api.github.com/users/sebmarkbage/orgs","repos_url":"https://api.github.com/users/sebmarkbage/repos","events_url":"https://api.github.com/users/sebmarkbage/events{/privacy}","received_events_url":"https://api.github.com/users/sebmarkbage/received_events","type":"User","site_admin":false},"assignees":[{"login":"sebmarkbage","id":63648,"avatar_url":"https://avatars.githubusercontent.com/u/63648?v=3","gravatar_id":"","url":"https://api.github.com/users/sebmarkbage","html_url":"https://github.com/sebmarkbage","followers_url":"https://api.github.com/users/sebmarkbage/followers","following_url":"https://api.github.com/users/sebmarkbage/following{/other_user}","gists_url":"https://api.github.com/users/sebmarkbage/gists{/gist_id}","starred_url":"https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebmarkbage/subscriptions","organizations_url":"https://api.github.com/users/sebmarkbage/orgs","repos_url":"https://api.github.com/users/sebmarkbage/repos","events_url":"https://api.github.com/users/sebmarkbage/events{/privacy}","received_events_url":"https://api.github.com/users/sebmarkbage/received_events","type":"User","site_admin":false},{"login":"gaearon","id":810438,"avatar_url":"https://avatars.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2016-12-02T06:19:45Z","updated_at":"2016-12-06T19:45:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/8479","html_url":"https://github.com/facebook/react/pull/8479","diff_url":"https://github.com/facebook/react/pull/8479.diff","patch_url":"https://github.com/facebook/react/pull/8479.patch"},"body":"- [x] Split the commit phase from `performUnitOfWork` so that we can complete a tree without having to commit it within the same frame.\r\n- [x] Consolidate the work loop functions.\r\n- [x] Consolidate try-catch-finally blocks. Aim for three: one for the work loop, and one for each pass of the commit phase.\r\n- [x] Avoid checking for failed work every time so that we don't pay a penalty in the normal case. When we know there are errors somewhere in the tree, use a forked version of the work loop that performs the check and is slightly slower. In the normal case, use the faster version without the check.\r\n- [x] Error recovery work should not be incremental. Give it Task priority. (Why?)\r\n- [x] Fix bug from https://github.com/facebook/react/pull/8485"},"comment":{"url":"https://api.github.com/repos/facebook/react/issues/comments/265252541","html_url":"https://github.com/facebook/react/pull/8479#issuecomment-265252541","issue_url":"https://api.github.com/repos/facebook/react/issues/8479","id":265252541,"user":{"login":"acdlite","id":3624098,"avatar_url":"https://avatars.githubusercontent.com/u/3624098?v=3","gravatar_id":"","url":"https://api.github.com/users/acdlite","html_url":"https://github.com/acdlite","followers_url":"https://api.github.com/users/acdlite/followers","following_url":"https://api.github.com/users/acdlite/following{/other_user}","gists_url":"https://api.github.com/users/acdlite/gists{/gist_id}","starred_url":"https://api.github.com/users/acdlite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acdlite/subscriptions","organizations_url":"https://api.github.com/users/acdlite/orgs","repos_url":"https://api.github.com/users/acdlite/repos","events_url":"https://api.github.com/users/acdlite/events{/privacy}","received_events_url":"https://api.github.com/users/acdlite/received_events","type":"User","site_admin":false},"created_at":"2016-12-06T19:45:37Z","updated_at":"2016-12-06T19:45:37Z","body":"Feedback todo items:\r\n\r\n- [ ] Error handling in `detachRef` callbacks.\r\n- [ ] Related to previous: error that originate in the host environment during failed tree unmounting should not be ignored, unlike user-originating errors. Right now all such errors are ignored.\r\n- [ ] Use the `updateQueue` instead of `pendingProps` for top-level updates."}}
{"actor":{"display_login":"acdlite"}}