{"action":"created","issue":{"url":"https://api.github.com/repos/npm/npm/issues/12290","repository_url":"https://api.github.com/repos/npm/npm","labels_url":"https://api.github.com/repos/npm/npm/issues/12290/labels{/name}","comments_url":"https://api.github.com/repos/npm/npm/issues/12290/comments","events_url":"https://api.github.com/repos/npm/npm/issues/12290/events","html_url":"https://github.com/npm/npm/pull/12290","id":147167327,"number":12290,"title":"Peer shrinkwrap fix","user":{"login":"majgis","id":546259,"avatar_url":"https://avatars.githubusercontent.com/u/546259?v=3","gravatar_id":"","url":"https://api.github.com/users/majgis","html_url":"https://github.com/majgis","followers_url":"https://api.github.com/users/majgis/followers","following_url":"https://api.github.com/users/majgis/following{/other_user}","gists_url":"https://api.github.com/users/majgis/gists{/gist_id}","starred_url":"https://api.github.com/users/majgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majgis/subscriptions","organizations_url":"https://api.github.com/users/majgis/orgs","repos_url":"https://api.github.com/users/majgis/repos","events_url":"https://api.github.com/users/majgis/events{/privacy}","received_events_url":"https://api.github.com/users/majgis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/npm/npm/labels/review","name":"review","color":"343434"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-04-09T21:58:30Z","updated_at":"2016-04-15T22:15:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/npm/npm/pulls/12290","html_url":"https://github.com/npm/npm/pull/12290","diff_url":"https://github.com/npm/npm/pull/12290.diff","patch_url":"https://github.com/npm/npm/pull/12290.patch"},"body":"This should fix #5135.  \r\n\r\nI read the guidelines for contributing which recommended squashing to a single commit.  I intentionally left two commits so that you can verify the added test is failing first.  I was just bitten by not doing this, as I was comparing two undefined values output by the rmFrom function.  There was also another test that was fixed, that was also comparing two undefined values.\r\n\r\nIn response to [CERT vulnerability note VU#319816](https://www.kb.cert.org/vuls/id/319816) we started requiring the use of npm-shrinkwrap.json files in our builds. As this issue circumvents this precaution while also breaking applications, we are anxious to see this issue resolved in the next lts release."},"comment":{"url":"https://api.github.com/repos/npm/npm/issues/comments/210666609","html_url":"https://github.com/npm/npm/pull/12290#issuecomment-210666609","issue_url":"https://api.github.com/repos/npm/npm/issues/12290","id":210666609,"user":{"login":"kevinold","id":21967,"avatar_url":"https://avatars.githubusercontent.com/u/21967?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinold","html_url":"https://github.com/kevinold","followers_url":"https://api.github.com/users/kevinold/followers","following_url":"https://api.github.com/users/kevinold/following{/other_user}","gists_url":"https://api.github.com/users/kevinold/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinold/subscriptions","organizations_url":"https://api.github.com/users/kevinold/orgs","repos_url":"https://api.github.com/users/kevinold/repos","events_url":"https://api.github.com/users/kevinold/events{/privacy}","received_events_url":"https://api.github.com/users/kevinold/received_events","type":"User","site_admin":false},"created_at":"2016-04-15T22:15:20Z","updated_at":"2016-04-15T22:15:20Z","body":"@majgis I can confirm that this solves #12276"}}