{"action":"created","comment":{"url":"https://api.github.com/repos/freeipa/freeipa/pulls/comments/86512283","pull_request_review_id":7166566,"id":86512283,"diff_hunk":"@@ -221,21 +274,26 @@ static int ipa_ldap_bind(const char *server_name, krb5_principal bind_princ,\n                                &bv, NULL, NULL, NULL);\n         if (ret != LDAP_SUCCESS) {\n             fprintf(stderr, _(\"Simple bind failed\\n\"));\n-            goto done;\n         }\n     } else {\n-        ret = ldap_sasl_interactive_bind_s(ld, NULL, \"GSSAPI\",\n-                                           NULL, NULL, LDAP_SASL_QUIET,\n-                                           ldap_sasl_interact, bind_princ);\n+        if (strcmp(mech, LDAP_SASL_EXTERNAL) == 0) {\n+            ret = ldap_sasl_bind_s(ld, NULL, LDAP_SASL_EXTERNAL,\n+                               NULL, NULL, NULL, NULL);","path":"client/ipa-getkeytab.c","position":179,"original_position":179,"commit_id":"35e2e2ae82d66ef369ac29a36705751963cd2735","original_commit_id":"35e2e2ae82d66ef369ac29a36705751963cd2735","user":{"login":"simo5","id":8332609,"avatar_url":"https://avatars.githubusercontent.com/u/8332609?v=3","gravatar_id":"","url":"https://api.github.com/users/simo5","html_url":"https://github.com/simo5","followers_url":"https://api.github.com/users/simo5/followers","following_url":"https://api.github.com/users/simo5/following{/other_user}","gists_url":"https://api.github.com/users/simo5/gists{/gist_id}","starred_url":"https://api.github.com/users/simo5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simo5/subscriptions","organizations_url":"https://api.github.com/users/simo5/orgs","repos_url":"https://api.github.com/users/simo5/repos","events_url":"https://api.github.com/users/simo5/events{/privacy}","received_events_url":"https://api.github.com/users/simo5/received_events","type":"User","site_admin":false},"body":"bad indent, sshould start under 'ld'","created_at":"2016-11-04T09:39:47Z","updated_at":"2016-11-04T09:39:47Z","html_url":"https://github.com/freeipa/freeipa/pull/202#discussion_r86512283","pull_request_url":"https://api.github.com/repos/freeipa/freeipa/pulls/202","_links":{"self":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/comments/86512283"},"html":{"href":"https://github.com/freeipa/freeipa/pull/202#discussion_r86512283"},"pull_request":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/202"}}},"pull_request":{"url":"https://api.github.com/repos/freeipa/freeipa/pulls/202","id":91766123,"html_url":"https://github.com/freeipa/freeipa/pull/202","diff_url":"https://github.com/freeipa/freeipa/pull/202.diff","patch_url":"https://github.com/freeipa/freeipa/pull/202.patch","issue_url":"https://api.github.com/repos/freeipa/freeipa/issues/202","number":202,"state":"open","locked":false,"title":"ipa-getkeytab enhancements","user":{"login":"martbab","id":1563843,"avatar_url":"https://avatars.githubusercontent.com/u/1563843?v=3","gravatar_id":"","url":"https://api.github.com/users/martbab","html_url":"https://github.com/martbab","followers_url":"https://api.github.com/users/martbab/followers","following_url":"https://api.github.com/users/martbab/following{/other_user}","gists_url":"https://api.github.com/users/martbab/gists{/gist_id}","starred_url":"https://api.github.com/users/martbab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martbab/subscriptions","organizations_url":"https://api.github.com/users/martbab/orgs","repos_url":"https://api.github.com/users/martbab/repos","events_url":"https://api.github.com/users/martbab/events{/privacy}","received_events_url":"https://api.github.com/users/martbab/received_events","type":"User","site_admin":false},"body":"This PR implements '-H' and '-Y' options mentioned in\nhttps://fedorahosted.org/freeipa/ticket/6409 along with the ability to specify\nCA cert on the command line (which proved useful during the work on installer\nrefactoring).\n\nSince my C skills are not at the level I would like them to be it would be nice\nif you point out even the tiniest mistakes, risky code or non-idiomatic usage.\n\nAlso the test case `test_retrieval_using_plain_ldap` fails due to unsuccesful\nsimple bind. I wanted to implement StartTLS for simple binds over ldap://, but\nI get the following errors in dirsrv error log:\n\n        [01/Nov/2016:10:44:52.395126000 +0000] connection - conn=883 fd=135\n        Incoming BER Element was 3 bytes, max allowable is 209715200 bytes.\n        Change the nsslapd-maxbersize attribute in cn=config to increase.\n\nI guess there is something fishy with the way I initialize the StartTLS\nsession. I would appreciate your help with it.","created_at":"2016-11-01T11:10:22Z","updated_at":"2016-11-04T09:49:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a895ac97ed702fa26236c0713e4675b3b46980c5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/freeipa/freeipa/pulls/202/commits","review_comments_url":"https://api.github.com/repos/freeipa/freeipa/pulls/202/comments","review_comment_url":"https://api.github.com/repos/freeipa/freeipa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freeipa/freeipa/issues/202/comments","statuses_url":"https://api.github.com/repos/freeipa/freeipa/statuses/35e2e2ae82d66ef369ac29a36705751963cd2735","head":{"label":"martbab:getkeytab-enhancements","ref":"getkeytab-enhancements","sha":"35e2e2ae82d66ef369ac29a36705751963cd2735","user":{"login":"martbab","id":1563843,"avatar_url":"https://avatars.githubusercontent.com/u/1563843?v=3","gravatar_id":"","url":"https://api.github.com/users/martbab","html_url":"https://github.com/martbab","followers_url":"https://api.github.com/users/martbab/followers","following_url":"https://api.github.com/users/martbab/following{/other_user}","gists_url":"https://api.github.com/users/martbab/gists{/gist_id}","starred_url":"https://api.github.com/users/martbab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martbab/subscriptions","organizations_url":"https://api.github.com/users/martbab/orgs","repos_url":"https://api.github.com/users/martbab/repos","events_url":"https://api.github.com/users/martbab/events{/privacy}","received_events_url":"https://api.github.com/users/martbab/received_events","type":"User","site_admin":false},"repo":{"id":61827099,"name":"freeipa","full_name":"martbab/freeipa","owner":{"login":"martbab","id":1563843,"avatar_url":"https://avatars.githubusercontent.com/u/1563843?v=3","gravatar_id":"","url":"https://api.github.com/users/martbab","html_url":"https://github.com/martbab","followers_url":"https://api.github.com/users/martbab/followers","following_url":"https://api.github.com/users/martbab/following{/other_user}","gists_url":"https://api.github.com/users/martbab/gists{/gist_id}","starred_url":"https://api.github.com/users/martbab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martbab/subscriptions","organizations_url":"https://api.github.com/users/martbab/orgs","repos_url":"https://api.github.com/users/martbab/repos","events_url":"https://api.github.com/users/martbab/events{/privacy}","received_events_url":"https://api.github.com/users/martbab/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martbab/freeipa","description":"Mirror of FreeIPA, an integrated security information management solution","fork":true,"url":"https://api.github.com/repos/martbab/freeipa","forks_url":"https://api.github.com/repos/martbab/freeipa/forks","keys_url":"https://api.github.com/repos/martbab/freeipa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martbab/freeipa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martbab/freeipa/teams","hooks_url":"https://api.github.com/repos/martbab/freeipa/hooks","issue_events_url":"https://api.github.com/repos/martbab/freeipa/issues/events{/number}","events_url":"https://api.github.com/repos/martbab/freeipa/events","assignees_url":"https://api.github.com/repos/martbab/freeipa/assignees{/user}","branches_url":"https://api.github.com/repos/martbab/freeipa/branches{/branch}","tags_url":"https://api.github.com/repos/martbab/freeipa/tags","blobs_url":"https://api.github.com/repos/martbab/freeipa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martbab/freeipa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martbab/freeipa/git/refs{/sha}","trees_url":"https://api.github.com/repos/martbab/freeipa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martbab/freeipa/statuses/{sha}","languages_url":"https://api.github.com/repos/martbab/freeipa/languages","stargazers_url":"https://api.github.com/repos/martbab/freeipa/stargazers","contributors_url":"https://api.github.com/repos/martbab/freeipa/contributors","subscribers_url":"https://api.github.com/repos/martbab/freeipa/subscribers","subscription_url":"https://api.github.com/repos/martbab/freeipa/subscription","commits_url":"https://api.github.com/repos/martbab/freeipa/commits{/sha}","git_commits_url":"https://api.github.com/repos/martbab/freeipa/git/commits{/sha}","comments_url":"https://api.github.com/repos/martbab/freeipa/comments{/number}","issue_comment_url":"https://api.github.com/repos/martbab/freeipa/issues/comments{/number}","contents_url":"https://api.github.com/repos/martbab/freeipa/contents/{+path}","compare_url":"https://api.github.com/repos/martbab/freeipa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martbab/freeipa/merges","archive_url":"https://api.github.com/repos/martbab/freeipa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martbab/freeipa/downloads","issues_url":"https://api.github.com/repos/martbab/freeipa/issues{/number}","pulls_url":"https://api.github.com/repos/martbab/freeipa/pulls{/number}","milestones_url":"https://api.github.com/repos/martbab/freeipa/milestones{/number}","notifications_url":"https://api.github.com/repos/martbab/freeipa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martbab/freeipa/labels{/name}","releases_url":"https://api.github.com/repos/martbab/freeipa/releases{/id}","deployments_url":"https://api.github.com/repos/martbab/freeipa/deployments","created_at":"2016-06-23T18:19:26Z","updated_at":"2016-06-23T18:19:31Z","pushed_at":"2016-11-03T17:08:18Z","git_url":"git://github.com/martbab/freeipa.git","ssh_url":"git@github.com:martbab/freeipa.git","clone_url":"https://github.com/martbab/freeipa.git","svn_url":"https://github.com/martbab/freeipa","homepage":"http://freeipa.org/","size":36946,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"freeipa:master","ref":"master","sha":"f12abfb852dfb1a7759928b05defde68d5d7a3df","user":{"login":"freeipa","id":10979201,"avatar_url":"https://avatars.githubusercontent.com/u/10979201?v=3","gravatar_id":"","url":"https://api.github.com/users/freeipa","html_url":"https://github.com/freeipa","followers_url":"https://api.github.com/users/freeipa/followers","following_url":"https://api.github.com/users/freeipa/following{/other_user}","gists_url":"https://api.github.com/users/freeipa/gists{/gist_id}","starred_url":"https://api.github.com/users/freeipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeipa/subscriptions","organizations_url":"https://api.github.com/users/freeipa/orgs","repos_url":"https://api.github.com/users/freeipa/repos","events_url":"https://api.github.com/users/freeipa/events{/privacy}","received_events_url":"https://api.github.com/users/freeipa/received_events","type":"Organization","site_admin":false},"repo":{"id":4340318,"name":"freeipa","full_name":"freeipa/freeipa","owner":{"login":"freeipa","id":10979201,"avatar_url":"https://avatars.githubusercontent.com/u/10979201?v=3","gravatar_id":"","url":"https://api.github.com/users/freeipa","html_url":"https://github.com/freeipa","followers_url":"https://api.github.com/users/freeipa/followers","following_url":"https://api.github.com/users/freeipa/following{/other_user}","gists_url":"https://api.github.com/users/freeipa/gists{/gist_id}","starred_url":"https://api.github.com/users/freeipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeipa/subscriptions","organizations_url":"https://api.github.com/users/freeipa/orgs","repos_url":"https://api.github.com/users/freeipa/repos","events_url":"https://api.github.com/users/freeipa/events{/privacy}","received_events_url":"https://api.github.com/users/freeipa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freeipa/freeipa","description":"Mirror of FreeIPA, an integrated security information management solution","fork":false,"url":"https://api.github.com/repos/freeipa/freeipa","forks_url":"https://api.github.com/repos/freeipa/freeipa/forks","keys_url":"https://api.github.com/repos/freeipa/freeipa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freeipa/freeipa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freeipa/freeipa/teams","hooks_url":"https://api.github.com/repos/freeipa/freeipa/hooks","issue_events_url":"https://api.github.com/repos/freeipa/freeipa/issues/events{/number}","events_url":"https://api.github.com/repos/freeipa/freeipa/events","assignees_url":"https://api.github.com/repos/freeipa/freeipa/assignees{/user}","branches_url":"https://api.github.com/repos/freeipa/freeipa/branches{/branch}","tags_url":"https://api.github.com/repos/freeipa/freeipa/tags","blobs_url":"https://api.github.com/repos/freeipa/freeipa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freeipa/freeipa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freeipa/freeipa/git/refs{/sha}","trees_url":"https://api.github.com/repos/freeipa/freeipa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freeipa/freeipa/statuses/{sha}","languages_url":"https://api.github.com/repos/freeipa/freeipa/languages","stargazers_url":"https://api.github.com/repos/freeipa/freeipa/stargazers","contributors_url":"https://api.github.com/repos/freeipa/freeipa/contributors","subscribers_url":"https://api.github.com/repos/freeipa/freeipa/subscribers","subscription_url":"https://api.github.com/repos/freeipa/freeipa/subscription","commits_url":"https://api.github.com/repos/freeipa/freeipa/commits{/sha}","git_commits_url":"https://api.github.com/repos/freeipa/freeipa/git/commits{/sha}","comments_url":"https://api.github.com/repos/freeipa/freeipa/comments{/number}","issue_comment_url":"https://api.github.com/repos/freeipa/freeipa/issues/comments{/number}","contents_url":"https://api.github.com/repos/freeipa/freeipa/contents/{+path}","compare_url":"https://api.github.com/repos/freeipa/freeipa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freeipa/freeipa/merges","archive_url":"https://api.github.com/repos/freeipa/freeipa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freeipa/freeipa/downloads","issues_url":"https://api.github.com/repos/freeipa/freeipa/issues{/number}","pulls_url":"https://api.github.com/repos/freeipa/freeipa/pulls{/number}","milestones_url":"https://api.github.com/repos/freeipa/freeipa/milestones{/number}","notifications_url":"https://api.github.com/repos/freeipa/freeipa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freeipa/freeipa/labels{/name}","releases_url":"https://api.github.com/repos/freeipa/freeipa/releases{/id}","deployments_url":"https://api.github.com/repos/freeipa/freeipa/deployments","created_at":"2012-05-15T20:34:40Z","updated_at":"2016-10-28T21:05:45Z","pushed_at":"2016-11-04T06:36:13Z","git_url":"git://github.com/freeipa/freeipa.git","ssh_url":"git@github.com:freeipa/freeipa.git","clone_url":"https://github.com/freeipa/freeipa.git","svn_url":"https://github.com/freeipa/freeipa","homepage":"http://www.freeipa.org","size":37785,"stargazers_count":44,"watchers_count":44,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":46,"forks":53,"open_issues":46,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/202"},"html":{"href":"https://github.com/freeipa/freeipa/pull/202"},"issue":{"href":"https://api.github.com/repos/freeipa/freeipa/issues/202"},"comments":{"href":"https://api.github.com/repos/freeipa/freeipa/issues/202/comments"},"review_comments":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/202/comments"},"review_comment":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/202/commits"},"statuses":{"href":"https://api.github.com/repos/freeipa/freeipa/statuses/35e2e2ae82d66ef369ac29a36705751963cd2735"}}}}
{"actor":{"display_login":"simo5"}}