{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/55042001","id":55042001,"diff_hunk":"@@ -444,3 +444,35 @@ func WaitForObservedDeployment(getDeploymentFunc func() (*extensions.Deployment,\n \t\treturn deployment.Status.ObservedGeneration >= desiredGeneration, nil\n \t})\n }\n+\n+// ResolveFenceposts resolves both maxSurge and maxUnavailable. This needs to happen in one\n+// step. For example:\n+//\n+// 2 desired, max unavailable 1%, surge 0% - should scale old(-1), then new(+1), then old(-1), then new(+1)\n+// 1 desired, max unavailable 1%, surge 0% - should scale old(-1), then new(+1)\n+// 2 desired, max unavailable 25%, surge 1% - should scale new(+1), then old(-1), then new(+1), then old(-1)\n+// 1 desired, max unavailable 25%, surge 1% - should scale new(+1), then old(-1)\n+// 2 desired, max unavailable 0%, surge 1% - should scale new(+1), then old(-1), then new(+1), then old(-1)\n+// 1 desired, max unavailable 0%, surge 1% - should scale new(+1), then old(-1)\n+func ResolveFenceposts(maxSurge, maxUnavailable *intstrutil.IntOrString, desired int) (int, int, error) {","path":"pkg/util/deployment/deployment.go","position":14,"original_position":14,"commit_id":"56d2f68bb96a3ae3a8e204dc8331f1e86a419f8e","original_commit_id":"56d2f68bb96a3ae3a8e204dc8331f1e86a419f8e","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"body":"Already used in the rest of the IntOrString helpers so I opted not to change that here.","created_at":"2016-03-04T15:19:31Z","updated_at":"2016-03-04T15:19:31Z","html_url":"https://github.com/kubernetes/kubernetes/pull/22516#discussion_r55042001","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22516","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/55042001"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/22516#discussion_r55042001"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22516"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22516","id":61693943,"html_url":"https://github.com/kubernetes/kubernetes/pull/22516","diff_url":"https://github.com/kubernetes/kubernetes/pull/22516.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/22516.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/22516","number":22516,"state":"open","locked":false,"title":"Resolve fenceposts for deployments together","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"body":"In case of a deployment with zero maxSurge and a percent of maxUnavailable other than 100%, a deployment would block because it couldn't scale up (no surge) or scale down (maxUnavailable floored to zero). This PR resolves both fenceposts together, and in case of a zero maxSurge we ceil maxUnavailable, in case of a non-zero maxSurge, we continue flooring maxUnavailable.\r\n\r\n@bgrant0607 @smarterclayton @janetkuo @mqliang PTAL","created_at":"2016-03-04T10:36:02Z","updated_at":"2016-03-04T15:19:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6b0509b5be85064b6df6ac7cd1fce24d1c37aaa","assignee":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/15","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.2","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/15/labels","id":1278499,"number":15,"title":"v1.2","description":"https://github.com/kubernetes/kubernetes/wiki/Release-1.2","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":137,"closed_issues":542,"state":"open","created_at":"2015-08-29T03:54:16Z","updated_at":"2016-03-04T15:07:57Z","due_on":"2016-03-04T05:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22516/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22516/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/22516/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/56d2f68bb96a3ae3a8e204dc8331f1e86a419f8e","head":{"label":"kargakis:resolve-fenceposts-together","ref":"resolve-fenceposts-together","sha":"56d2f68bb96a3ae3a8e204dc8331f1e86a419f8e","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"repo":{"id":33254730,"name":"kubernetes","full_name":"kargakis/kubernetes","owner":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kargakis/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/kargakis/kubernetes","forks_url":"https://api.github.com/repos/kargakis/kubernetes/forks","keys_url":"https://api.github.com/repos/kargakis/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kargakis/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kargakis/kubernetes/teams","hooks_url":"https://api.github.com/repos/kargakis/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kargakis/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kargakis/kubernetes/events","assignees_url":"https://api.github.com/repos/kargakis/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kargakis/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kargakis/kubernetes/tags","blobs_url":"https://api.github.com/repos/kargakis/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kargakis/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kargakis/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kargakis/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kargakis/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kargakis/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kargakis/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kargakis/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kargakis/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kargakis/kubernetes/subscription","commits_url":"https://api.github.com/repos/kargakis/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kargakis/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kargakis/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kargakis/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kargakis/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kargakis/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kargakis/kubernetes/merges","archive_url":"https://api.github.com/repos/kargakis/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kargakis/kubernetes/downloads","issues_url":"https://api.github.com/repos/kargakis/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kargakis/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kargakis/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kargakis/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kargakis/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kargakis/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kargakis/kubernetes/deployments","created_at":"2015-04-01T15:11:37Z","updated_at":"2016-01-12T10:44:51Z","pushed_at":"2016-03-04T15:05:36Z","git_url":"git://github.com/kargakis/kubernetes.git","ssh_url":"git@github.com:kargakis/kubernetes.git","clone_url":"https://github.com/kargakis/kubernetes.git","svn_url":"https://github.com/kargakis/kubernetes","homepage":"http://kubernetes.io","size":173609,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"49f438bfac6174b00410739961c829eaa161b75c","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-03-04T14:55:51Z","pushed_at":"2016-03-04T15:00:00Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":334131,"stargazers_count":13033,"watchers_count":13033,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3743,"mirror_url":null,"open_issues_count":2984,"forks":3743,"open_issues":2984,"watchers":13033,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22516"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/22516"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/22516"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/22516/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22516/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22516/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/56d2f68bb96a3ae3a8e204dc8331f1e86a419f8e"}}}}