{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/kibana/issues/6791","repository_url":"https://api.github.com/repos/elastic/kibana","labels_url":"https://api.github.com/repos/elastic/kibana/issues/6791/labels{/name}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/6791/comments","events_url":"https://api.github.com/repos/elastic/kibana/issues/6791/events","html_url":"https://github.com/elastic/kibana/pull/6791","id":146116528,"number":6791,"title":"Added a custom banner feature in advanced settings","user":{"login":"bevacqua","id":934293,"avatar_url":"https://avatars.githubusercontent.com/u/934293?v=3","gravatar_id":"","url":"https://api.github.com/users/bevacqua","html_url":"https://github.com/bevacqua","followers_url":"https://api.github.com/users/bevacqua/followers","following_url":"https://api.github.com/users/bevacqua/following{/other_user}","gists_url":"https://api.github.com/users/bevacqua/gists{/gist_id}","starred_url":"https://api.github.com/users/bevacqua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bevacqua/subscriptions","organizations_url":"https://api.github.com/users/bevacqua/orgs","repos_url":"https://api.github.com/users/bevacqua/repos","events_url":"https://api.github.com/users/bevacqua/events{/privacy}","received_events_url":"https://api.github.com/users/bevacqua/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elastic/kibana/labels/review","name":"review","color":"eb6420"}],"state":"open","locked":false,"assignee":{"login":"bevacqua","id":934293,"avatar_url":"https://avatars.githubusercontent.com/u/934293?v=3","gravatar_id":"","url":"https://api.github.com/users/bevacqua","html_url":"https://github.com/bevacqua","followers_url":"https://api.github.com/users/bevacqua/followers","following_url":"https://api.github.com/users/bevacqua/following{/other_user}","gists_url":"https://api.github.com/users/bevacqua/gists{/gist_id}","starred_url":"https://api.github.com/users/bevacqua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bevacqua/subscriptions","organizations_url":"https://api.github.com/users/bevacqua/orgs","repos_url":"https://api.github.com/users/bevacqua/repos","events_url":"https://api.github.com/users/bevacqua/events{/privacy}","received_events_url":"https://api.github.com/users/bevacqua/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2016-04-05T21:58:21Z","updated_at":"2016-04-08T01:26:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/6791","html_url":"https://github.com/elastic/kibana/pull/6791","diff_url":"https://github.com/elastic/kibana/pull/6791.diff","patch_url":"https://github.com/elastic/kibana/pull/6791.patch"},"body":"Replaces #6765. Fixes #4452 by adding the ability to compose a toast notification using Markdown through advanced settings.\r\n\r\n- Adds [`trunc-text`][ttext] and [`trunc-html`][thtml] which are two small modules that handle proper text and HTML truncation by words\r\n- Adds advanced setting display mode for Markdown, which gets rendered as HTML\r\n- Adds Markdown filter which allows to easily render text as HTML in views\r\n- Adds support in `kbn-truncated` for truncated HTML\r\n- Adds banner notification support\r\n- Minor refactors like removing an outdated piece of commented-out code, replacing `var` with `const`, etc.\r\n- [ ] We can customize which types of DOM elements are allowed in the banner notification. Currently it's only sanitized via `marked` and `insane`, meaning there won't be any `<script>` tags or any other craze like that.\r\n- [ ] Is missing style configuration _(namely: `background-color`)_ because I need advice as to where to modify styles, and how the notification should be presented\r\n\r\nSome screenshots:\r\n\r\n<img width=\"1434\" alt=\"screen shot 2016-04-04 at 15 19 38\" src=\"https://cloud.githubusercontent.com/assets/934293/14258397/bd4b98cc-fa78-11e5-8c16-60fc661cce58.png\">\r\n<img width=\"1160\" alt=\"screen shot 2016-04-04 at 15 20 04\" src=\"https://cloud.githubusercontent.com/assets/934293/14258398/bd72ee40-fa78-11e5-8856-b9afe3515664.png\">\r\n<img width=\"1166\" alt=\"screen shot 2016-04-04 at 15 20 09\" src=\"https://cloud.githubusercontent.com/assets/934293/14258399/bd82ee3a-fa78-11e5-8b84-4ce624dcdc97.png\">\r\n\r\n[ttext]: https://github.com/bevacqua/trunc-text\r\n[thtml]: https://github.com/bevacqua/trunc-html"},"comment":{"url":"https://api.github.com/repos/elastic/kibana/issues/comments/207162213","html_url":"https://github.com/elastic/kibana/pull/6791#issuecomment-207162213","issue_url":"https://api.github.com/repos/elastic/kibana/issues/6791","id":207162213,"user":{"login":"tsullivan","id":908371,"avatar_url":"https://avatars.githubusercontent.com/u/908371?v=3","gravatar_id":"","url":"https://api.github.com/users/tsullivan","html_url":"https://github.com/tsullivan","followers_url":"https://api.github.com/users/tsullivan/followers","following_url":"https://api.github.com/users/tsullivan/following{/other_user}","gists_url":"https://api.github.com/users/tsullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/tsullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsullivan/subscriptions","organizations_url":"https://api.github.com/users/tsullivan/orgs","repos_url":"https://api.github.com/users/tsullivan/repos","events_url":"https://api.github.com/users/tsullivan/events{/privacy}","received_events_url":"https://api.github.com/users/tsullivan/received_events","type":"User","site_admin":false},"created_at":"2016-04-08T01:26:16Z","updated_at":"2016-04-08T01:26:16Z","body":"A few questions that don't have to be addressed in this PR:\r\n\r\n- Should the banner have a \"don't show this message again\" button? I ask because after it's initially closed, it will re-appear after a full-page refresh (unless the \"lifetime\" time has elapsed).\r\n- Should there be a limit on how many words of text can be entered into the field in the advanced settings screen? Looks like you can enter as many as you want, and the UI won't tell you that words get cut off in the actual banner message (but the user can see the result at the top after saving the message)"}}