{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/81792747","pull_request_review_id":2746867,"id":81792747,"diff_hunk":"@@ -211,8 +211,12 @@ static void log_usage(struct req_state *s, const string& op_name)\n   string p = payer.to_str();\n   rgw_usage_log_entry entry(u, p, bucket_name);\n \n-  uint64_t bytes_sent = s->cio->get_bytes_sent();\n-  uint64_t bytes_received = s->cio->get_bytes_received();\n+  uint64_t bytes_sent = 0;\n+  uint64_t bytes_received = 0;\n+  if (ACCOUNTING_IO(s)) {\n+    bytes_sent = ACCOUNTING_IO(s)->get_bytes_sent();\n+    bytes_received = ACCOUNTING_IO(s)->get_bytes_received();\n+  }","path":"src/rgw/rgw_log.cc","position":11,"original_position":11,"commit_id":"7b6fed3dfdd410b78b6739619770336cd4e0d74e","original_commit_id":"7b6fed3dfdd410b78b6739619770336cd4e0d74e","user":{"login":"cbodley","id":1928002,"avatar_url":"https://avatars.githubusercontent.com/u/1928002?v=3","gravatar_id":"","url":"https://api.github.com/users/cbodley","html_url":"https://github.com/cbodley","followers_url":"https://api.github.com/users/cbodley/followers","following_url":"https://api.github.com/users/cbodley/following{/other_user}","gists_url":"https://api.github.com/users/cbodley/gists{/gist_id}","starred_url":"https://api.github.com/users/cbodley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbodley/subscriptions","organizations_url":"https://api.github.com/users/cbodley/orgs","repos_url":"https://api.github.com/users/cbodley/repos","events_url":"https://api.github.com/users/cbodley/events{/privacy}","received_events_url":"https://api.github.com/users/cbodley/received_events","type":"User","site_admin":false},"body":"consider storing the result of `ACCOUNTING_IO(s)` in a temporary so we only `dynamic_cast` once","created_at":"2016-10-04T16:06:18Z","updated_at":"2016-10-04T16:06:18Z","html_url":"https://github.com/ceph/ceph/pull/10767#discussion_r81792747","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/10767","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/81792747"},"html":{"href":"https://github.com/ceph/ceph/pull/10767#discussion_r81792747"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10767"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/10767","id":81678195,"html_url":"https://github.com/ceph/ceph/pull/10767","diff_url":"https://github.com/ceph/ceph/pull/10767.diff","patch_url":"https://github.com/ceph/ceph/pull/10767.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/10767","number":10767,"state":"open","locked":false,"title":"[DNM] rgw: frontend subsystem rework","user":{"login":"rzarzynski","id":1891217,"avatar_url":"https://avatars.githubusercontent.com/u/1891217?v=3","gravatar_id":"","url":"https://api.github.com/users/rzarzynski","html_url":"https://github.com/rzarzynski","followers_url":"https://api.github.com/users/rzarzynski/followers","following_url":"https://api.github.com/users/rzarzynski/following{/other_user}","gists_url":"https://api.github.com/users/rzarzynski/gists{/gist_id}","starred_url":"https://api.github.com/users/rzarzynski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzarzynski/subscriptions","organizations_url":"https://api.github.com/users/rzarzynski/orgs","repos_url":"https://api.github.com/users/rzarzynski/repos","events_url":"https://api.github.com/users/rzarzynski/events{/privacy}","received_events_url":"https://api.github.com/users/rzarzynski/received_events","type":"User","site_admin":false},"body":"TODO:\r\n* Document the new interfaces.\r\n* Test frontends and RadosGW's APIs. The test matrix will be quite big.\r\n* Apply the new filters over `RGWRestfulIO` to all frontends.\r\n* Move the AWS Auth v4 signature generator to a dedicated filter.\r\n* Seek and fix API clients which violate the call order of `RGWRestfulIO`. This is not the highest priority as we have `RGWRestfulIOReorderingEngine` now that could be used together with the new ASIO frontend.","created_at":"2016-08-17T16:53:00Z","updated_at":"2016-10-04T16:06:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"737aade70236910ca6bc31e4208c8335778bd512","assignee":{"login":"cbodley","id":1928002,"avatar_url":"https://avatars.githubusercontent.com/u/1928002?v=3","gravatar_id":"","url":"https://api.github.com/users/cbodley","html_url":"https://github.com/cbodley","followers_url":"https://api.github.com/users/cbodley/followers","following_url":"https://api.github.com/users/cbodley/following{/other_user}","gists_url":"https://api.github.com/users/cbodley/gists{/gist_id}","starred_url":"https://api.github.com/users/cbodley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbodley/subscriptions","organizations_url":"https://api.github.com/users/cbodley/orgs","repos_url":"https://api.github.com/users/cbodley/repos","events_url":"https://api.github.com/users/cbodley/events{/privacy}","received_events_url":"https://api.github.com/users/cbodley/received_events","type":"User","site_admin":false},"assignees":[{"login":"cbodley","id":1928002,"avatar_url":"https://avatars.githubusercontent.com/u/1928002?v=3","gravatar_id":"","url":"https://api.github.com/users/cbodley","html_url":"https://github.com/cbodley","followers_url":"https://api.github.com/users/cbodley/followers","following_url":"https://api.github.com/users/cbodley/following{/other_user}","gists_url":"https://api.github.com/users/cbodley/gists{/gist_id}","starred_url":"https://api.github.com/users/cbodley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbodley/subscriptions","organizations_url":"https://api.github.com/users/cbodley/orgs","repos_url":"https://api.github.com/users/cbodley/repos","events_url":"https://api.github.com/users/cbodley/events{/privacy}","received_events_url":"https://api.github.com/users/cbodley/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/10767/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/10767/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/10767/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/7b6fed3dfdd410b78b6739619770336cd4e0d74e","head":{"label":"rzarzynski:wip-rgw-frontend-rework","ref":"wip-rgw-frontend-rework","sha":"7b6fed3dfdd410b78b6739619770336cd4e0d74e","user":{"login":"rzarzynski","id":1891217,"avatar_url":"https://avatars.githubusercontent.com/u/1891217?v=3","gravatar_id":"","url":"https://api.github.com/users/rzarzynski","html_url":"https://github.com/rzarzynski","followers_url":"https://api.github.com/users/rzarzynski/followers","following_url":"https://api.github.com/users/rzarzynski/following{/other_user}","gists_url":"https://api.github.com/users/rzarzynski/gists{/gist_id}","starred_url":"https://api.github.com/users/rzarzynski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzarzynski/subscriptions","organizations_url":"https://api.github.com/users/rzarzynski/orgs","repos_url":"https://api.github.com/users/rzarzynski/repos","events_url":"https://api.github.com/users/rzarzynski/events{/privacy}","received_events_url":"https://api.github.com/users/rzarzynski/received_events","type":"User","site_admin":false},"repo":{"id":29937571,"name":"ceph","full_name":"rzarzynski/ceph","owner":{"login":"rzarzynski","id":1891217,"avatar_url":"https://avatars.githubusercontent.com/u/1891217?v=3","gravatar_id":"","url":"https://api.github.com/users/rzarzynski","html_url":"https://github.com/rzarzynski","followers_url":"https://api.github.com/users/rzarzynski/followers","following_url":"https://api.github.com/users/rzarzynski/following{/other_user}","gists_url":"https://api.github.com/users/rzarzynski/gists{/gist_id}","starred_url":"https://api.github.com/users/rzarzynski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzarzynski/subscriptions","organizations_url":"https://api.github.com/users/rzarzynski/orgs","repos_url":"https://api.github.com/users/rzarzynski/repos","events_url":"https://api.github.com/users/rzarzynski/events{/privacy}","received_events_url":"https://api.github.com/users/rzarzynski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rzarzynski/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/rzarzynski/ceph","forks_url":"https://api.github.com/repos/rzarzynski/ceph/forks","keys_url":"https://api.github.com/repos/rzarzynski/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rzarzynski/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rzarzynski/ceph/teams","hooks_url":"https://api.github.com/repos/rzarzynski/ceph/hooks","issue_events_url":"https://api.github.com/repos/rzarzynski/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/rzarzynski/ceph/events","assignees_url":"https://api.github.com/repos/rzarzynski/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/rzarzynski/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/rzarzynski/ceph/tags","blobs_url":"https://api.github.com/repos/rzarzynski/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rzarzynski/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rzarzynski/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/rzarzynski/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rzarzynski/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/rzarzynski/ceph/languages","stargazers_url":"https://api.github.com/repos/rzarzynski/ceph/stargazers","contributors_url":"https://api.github.com/repos/rzarzynski/ceph/contributors","subscribers_url":"https://api.github.com/repos/rzarzynski/ceph/subscribers","subscription_url":"https://api.github.com/repos/rzarzynski/ceph/subscription","commits_url":"https://api.github.com/repos/rzarzynski/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/rzarzynski/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/rzarzynski/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/rzarzynski/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/rzarzynski/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/rzarzynski/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rzarzynski/ceph/merges","archive_url":"https://api.github.com/repos/rzarzynski/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rzarzynski/ceph/downloads","issues_url":"https://api.github.com/repos/rzarzynski/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/rzarzynski/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/rzarzynski/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/rzarzynski/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rzarzynski/ceph/labels{/name}","releases_url":"https://api.github.com/repos/rzarzynski/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/rzarzynski/ceph/deployments","created_at":"2015-01-27T22:12:49Z","updated_at":"2016-02-09T13:55:19Z","pushed_at":"2016-10-04T12:10:44Z","git_url":"git://github.com/rzarzynski/ceph.git","ssh_url":"git@github.com:rzarzynski/ceph.git","clone_url":"https://github.com/rzarzynski/ceph.git","svn_url":"https://github.com/rzarzynski/ceph","homepage":"http://ceph.com","size":171651,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"2d1f164613089b6eab2fae046685aab9b646ef4d","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-10-04T10:22:50Z","pushed_at":"2016-10-04T16:05:11Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":242409,"stargazers_count":2511,"watchers_count":2511,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1474,"mirror_url":null,"open_issues_count":414,"forks":1474,"open_issues":414,"watchers":2511,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10767"},"html":{"href":"https://github.com/ceph/ceph/pull/10767"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/10767"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/10767/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10767/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10767/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/7b6fed3dfdd410b78b6739619770336cd4e0d74e"}}}}
{"actor":{"display_login":"cbodley"}}