{"action":"created","comment":{"url":"https://api.github.com/repos/vapor/socks/pulls/comments/84714363","pull_request_review_id":5474473,"id":84714363,"diff_hunk":"@@ -0,0 +1,100 @@\n+//","path":"Sources/SocksCore/SocketOptions+Deprecated.swift","position":1,"original_position":1,"commit_id":"cb151a5252fb7d68350a0a9392c77c9b46b1d4c7","original_commit_id":"cb151a5252fb7d68350a0a9392c77c9b46b1d4c7","user":{"login":"andreasley","id":1769714,"avatar_url":"https://avatars.githubusercontent.com/u/1769714?v=3","gravatar_id":"","url":"https://api.github.com/users/andreasley","html_url":"https://github.com/andreasley","followers_url":"https://api.github.com/users/andreasley/followers","following_url":"https://api.github.com/users/andreasley/following{/other_user}","gists_url":"https://api.github.com/users/andreasley/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasley/subscriptions","organizations_url":"https://api.github.com/users/andreasley/orgs","repos_url":"https://api.github.com/users/andreasley/repos","events_url":"https://api.github.com/users/andreasley/events{/privacy}","received_events_url":"https://api.github.com/users/andreasley/received_events","type":"User","site_admin":false},"body":"Not sure what you mean by that. Almost all files in SocksCore have headers. Should I just omit any header in new files?","created_at":"2016-10-24T15:31:43Z","updated_at":"2016-10-24T15:31:43Z","html_url":"https://github.com/vapor/socks/pull/85#discussion_r84714363","pull_request_url":"https://api.github.com/repos/vapor/socks/pulls/85","_links":{"self":{"href":"https://api.github.com/repos/vapor/socks/pulls/comments/84714363"},"html":{"href":"https://github.com/vapor/socks/pull/85#discussion_r84714363"},"pull_request":{"href":"https://api.github.com/repos/vapor/socks/pulls/85"}}},"pull_request":{"url":"https://api.github.com/repos/vapor/socks/pulls/85","id":90246663,"html_url":"https://github.com/vapor/socks/pull/85","diff_url":"https://github.com/vapor/socks/pull/85.diff","patch_url":"https://github.com/vapor/socks/pull/85.patch","issue_url":"https://api.github.com/repos/vapor/socks/issues/85","number":85,"state":"open","locked":false,"title":"Fixes for a few crashes related to setsockopt() and getsockopt()","user":{"login":"andreasley","id":1769714,"avatar_url":"https://avatars.githubusercontent.com/u/1769714?v=3","gravatar_id":"","url":"https://api.github.com/users/andreasley","html_url":"https://github.com/andreasley","followers_url":"https://api.github.com/users/andreasley/followers","following_url":"https://api.github.com/users/andreasley/following{/other_user}","gists_url":"https://api.github.com/users/andreasley/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasley/subscriptions","organizations_url":"https://api.github.com/users/andreasley/orgs","repos_url":"https://api.github.com/users/andreasley/repos","events_url":"https://api.github.com/users/andreasley/events{/privacy}","received_events_url":"https://api.github.com/users/andreasley/received_events","type":"User","site_admin":false},"body":"In certain circumstances, `setsockopt()` and `getsockopt()` can fail (e.g. when the socket is already closed). The current version correctly detects that, but the properties for the options would force-try anyway and end up with a crash. This PR deprecates the properties in favor of throwing funcs.","created_at":"2016-10-20T17:35:49Z","updated_at":"2016-10-24T15:31:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c6985720beb46c9efd5db50e576b89407318d30","assignee":{"login":"andreasley","id":1769714,"avatar_url":"https://avatars.githubusercontent.com/u/1769714?v=3","gravatar_id":"","url":"https://api.github.com/users/andreasley","html_url":"https://github.com/andreasley","followers_url":"https://api.github.com/users/andreasley/followers","following_url":"https://api.github.com/users/andreasley/following{/other_user}","gists_url":"https://api.github.com/users/andreasley/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasley/subscriptions","organizations_url":"https://api.github.com/users/andreasley/orgs","repos_url":"https://api.github.com/users/andreasley/repos","events_url":"https://api.github.com/users/andreasley/events{/privacy}","received_events_url":"https://api.github.com/users/andreasley/received_events","type":"User","site_admin":false},"assignees":[{"login":"andreasley","id":1769714,"avatar_url":"https://avatars.githubusercontent.com/u/1769714?v=3","gravatar_id":"","url":"https://api.github.com/users/andreasley","html_url":"https://github.com/andreasley","followers_url":"https://api.github.com/users/andreasley/followers","following_url":"https://api.github.com/users/andreasley/following{/other_user}","gists_url":"https://api.github.com/users/andreasley/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasley/subscriptions","organizations_url":"https://api.github.com/users/andreasley/orgs","repos_url":"https://api.github.com/users/andreasley/repos","events_url":"https://api.github.com/users/andreasley/events{/privacy}","received_events_url":"https://api.github.com/users/andreasley/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/vapor/socks/pulls/85/commits","review_comments_url":"https://api.github.com/repos/vapor/socks/pulls/85/comments","review_comment_url":"https://api.github.com/repos/vapor/socks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vapor/socks/issues/85/comments","statuses_url":"https://api.github.com/repos/vapor/socks/statuses/cb151a5252fb7d68350a0a9392c77c9b46b1d4c7","head":{"label":"andreasley:development-andreasley","ref":"development-andreasley","sha":"cb151a5252fb7d68350a0a9392c77c9b46b1d4c7","user":{"login":"andreasley","id":1769714,"avatar_url":"https://avatars.githubusercontent.com/u/1769714?v=3","gravatar_id":"","url":"https://api.github.com/users/andreasley","html_url":"https://github.com/andreasley","followers_url":"https://api.github.com/users/andreasley/followers","following_url":"https://api.github.com/users/andreasley/following{/other_user}","gists_url":"https://api.github.com/users/andreasley/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasley/subscriptions","organizations_url":"https://api.github.com/users/andreasley/orgs","repos_url":"https://api.github.com/users/andreasley/repos","events_url":"https://api.github.com/users/andreasley/events{/privacy}","received_events_url":"https://api.github.com/users/andreasley/received_events","type":"User","site_admin":false},"repo":{"id":71487067,"name":"socks","full_name":"andreasley/socks","owner":{"login":"andreasley","id":1769714,"avatar_url":"https://avatars.githubusercontent.com/u/1769714?v=3","gravatar_id":"","url":"https://api.github.com/users/andreasley","html_url":"https://github.com/andreasley","followers_url":"https://api.github.com/users/andreasley/followers","following_url":"https://api.github.com/users/andreasley/following{/other_user}","gists_url":"https://api.github.com/users/andreasley/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasley/subscriptions","organizations_url":"https://api.github.com/users/andreasley/orgs","repos_url":"https://api.github.com/users/andreasley/repos","events_url":"https://api.github.com/users/andreasley/events{/privacy}","received_events_url":"https://api.github.com/users/andreasley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andreasley/socks","description":"Pure-Swift Sockets: TCP, UDP; Client, Server; Linux, OS X. ","fork":true,"url":"https://api.github.com/repos/andreasley/socks","forks_url":"https://api.github.com/repos/andreasley/socks/forks","keys_url":"https://api.github.com/repos/andreasley/socks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreasley/socks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreasley/socks/teams","hooks_url":"https://api.github.com/repos/andreasley/socks/hooks","issue_events_url":"https://api.github.com/repos/andreasley/socks/issues/events{/number}","events_url":"https://api.github.com/repos/andreasley/socks/events","assignees_url":"https://api.github.com/repos/andreasley/socks/assignees{/user}","branches_url":"https://api.github.com/repos/andreasley/socks/branches{/branch}","tags_url":"https://api.github.com/repos/andreasley/socks/tags","blobs_url":"https://api.github.com/repos/andreasley/socks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreasley/socks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreasley/socks/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreasley/socks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreasley/socks/statuses/{sha}","languages_url":"https://api.github.com/repos/andreasley/socks/languages","stargazers_url":"https://api.github.com/repos/andreasley/socks/stargazers","contributors_url":"https://api.github.com/repos/andreasley/socks/contributors","subscribers_url":"https://api.github.com/repos/andreasley/socks/subscribers","subscription_url":"https://api.github.com/repos/andreasley/socks/subscription","commits_url":"https://api.github.com/repos/andreasley/socks/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreasley/socks/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreasley/socks/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreasley/socks/issues/comments{/number}","contents_url":"https://api.github.com/repos/andreasley/socks/contents/{+path}","compare_url":"https://api.github.com/repos/andreasley/socks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreasley/socks/merges","archive_url":"https://api.github.com/repos/andreasley/socks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreasley/socks/downloads","issues_url":"https://api.github.com/repos/andreasley/socks/issues{/number}","pulls_url":"https://api.github.com/repos/andreasley/socks/pulls{/number}","milestones_url":"https://api.github.com/repos/andreasley/socks/milestones{/number}","notifications_url":"https://api.github.com/repos/andreasley/socks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreasley/socks/labels{/name}","releases_url":"https://api.github.com/repos/andreasley/socks/releases{/id}","deployments_url":"https://api.github.com/repos/andreasley/socks/deployments","created_at":"2016-10-20T17:25:17Z","updated_at":"2016-10-20T17:25:19Z","pushed_at":"2016-10-20T17:29:33Z","git_url":"git://github.com/andreasley/socks.git","ssh_url":"git@github.com:andreasley/socks.git","clone_url":"https://github.com/andreasley/socks.git","svn_url":"https://github.com/andreasley/socks","homepage":"","size":193,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vapor:master","ref":"master","sha":"3233dee2ae19ec7273308d6457f49594b422a4ba","user":{"login":"vapor","id":17364220,"avatar_url":"https://avatars.githubusercontent.com/u/17364220?v=3","gravatar_id":"","url":"https://api.github.com/users/vapor","html_url":"https://github.com/vapor","followers_url":"https://api.github.com/users/vapor/followers","following_url":"https://api.github.com/users/vapor/following{/other_user}","gists_url":"https://api.github.com/users/vapor/gists{/gist_id}","starred_url":"https://api.github.com/users/vapor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vapor/subscriptions","organizations_url":"https://api.github.com/users/vapor/orgs","repos_url":"https://api.github.com/users/vapor/repos","events_url":"https://api.github.com/users/vapor/events{/privacy}","received_events_url":"https://api.github.com/users/vapor/received_events","type":"Organization","site_admin":false},"repo":{"id":51764518,"name":"socks","full_name":"vapor/socks","owner":{"login":"vapor","id":17364220,"avatar_url":"https://avatars.githubusercontent.com/u/17364220?v=3","gravatar_id":"","url":"https://api.github.com/users/vapor","html_url":"https://github.com/vapor","followers_url":"https://api.github.com/users/vapor/followers","following_url":"https://api.github.com/users/vapor/following{/other_user}","gists_url":"https://api.github.com/users/vapor/gists{/gist_id}","starred_url":"https://api.github.com/users/vapor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vapor/subscriptions","organizations_url":"https://api.github.com/users/vapor/orgs","repos_url":"https://api.github.com/users/vapor/repos","events_url":"https://api.github.com/users/vapor/events{/privacy}","received_events_url":"https://api.github.com/users/vapor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vapor/socks","description":"Pure-Swift Sockets: TCP, UDP; Client, Server; Linux, OS X. ","fork":false,"url":"https://api.github.com/repos/vapor/socks","forks_url":"https://api.github.com/repos/vapor/socks/forks","keys_url":"https://api.github.com/repos/vapor/socks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vapor/socks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vapor/socks/teams","hooks_url":"https://api.github.com/repos/vapor/socks/hooks","issue_events_url":"https://api.github.com/repos/vapor/socks/issues/events{/number}","events_url":"https://api.github.com/repos/vapor/socks/events","assignees_url":"https://api.github.com/repos/vapor/socks/assignees{/user}","branches_url":"https://api.github.com/repos/vapor/socks/branches{/branch}","tags_url":"https://api.github.com/repos/vapor/socks/tags","blobs_url":"https://api.github.com/repos/vapor/socks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vapor/socks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vapor/socks/git/refs{/sha}","trees_url":"https://api.github.com/repos/vapor/socks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vapor/socks/statuses/{sha}","languages_url":"https://api.github.com/repos/vapor/socks/languages","stargazers_url":"https://api.github.com/repos/vapor/socks/stargazers","contributors_url":"https://api.github.com/repos/vapor/socks/contributors","subscribers_url":"https://api.github.com/repos/vapor/socks/subscribers","subscription_url":"https://api.github.com/repos/vapor/socks/subscription","commits_url":"https://api.github.com/repos/vapor/socks/commits{/sha}","git_commits_url":"https://api.github.com/repos/vapor/socks/git/commits{/sha}","comments_url":"https://api.github.com/repos/vapor/socks/comments{/number}","issue_comment_url":"https://api.github.com/repos/vapor/socks/issues/comments{/number}","contents_url":"https://api.github.com/repos/vapor/socks/contents/{+path}","compare_url":"https://api.github.com/repos/vapor/socks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vapor/socks/merges","archive_url":"https://api.github.com/repos/vapor/socks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vapor/socks/downloads","issues_url":"https://api.github.com/repos/vapor/socks/issues{/number}","pulls_url":"https://api.github.com/repos/vapor/socks/pulls{/number}","milestones_url":"https://api.github.com/repos/vapor/socks/milestones{/number}","notifications_url":"https://api.github.com/repos/vapor/socks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vapor/socks/labels{/name}","releases_url":"https://api.github.com/repos/vapor/socks/releases{/id}","deployments_url":"https://api.github.com/repos/vapor/socks/deployments","created_at":"2016-02-15T15:24:32Z","updated_at":"2016-10-23T14:12:18Z","pushed_at":"2016-10-20T17:35:50Z","git_url":"git://github.com/vapor/socks.git","ssh_url":"git@github.com:vapor/socks.git","clone_url":"https://github.com/vapor/socks.git","svn_url":"https://github.com/vapor/socks","homepage":"","size":328,"stargazers_count":330,"watchers_count":330,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":10,"forks":27,"open_issues":10,"watchers":330,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vapor/socks/pulls/85"},"html":{"href":"https://github.com/vapor/socks/pull/85"},"issue":{"href":"https://api.github.com/repos/vapor/socks/issues/85"},"comments":{"href":"https://api.github.com/repos/vapor/socks/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/vapor/socks/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/vapor/socks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vapor/socks/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/vapor/socks/statuses/cb151a5252fb7d68350a0a9392c77c9b46b1d4c7"}}}}
{"actor":{"display_login":"andreasley"}}