{"action":"created","comment":{"url":"https://api.github.com/repos/appsignal/appsignal-ruby/pulls/comments/77826426","id":77826426,"diff_hunk":"@@ -92,18 +92,23 @@\n \n       context \"when allocation tracking and gc instrumentation have been enabled\" do\n         before do\n+          GC::Profiler.stub(:enable)","path":"spec/lib/appsignal_spec.rb","position":4,"original_position":4,"commit_id":"8fd93239c440dd12960aba7a8abbb9d085cb742c","original_commit_id":"8fd93239c440dd12960aba7a8abbb9d085cb742c","user":{"login":"tombruijn","id":282402,"avatar_url":"https://avatars.githubusercontent.com/u/282402?v=3","gravatar_id":"","url":"https://api.github.com/users/tombruijn","html_url":"https://github.com/tombruijn","followers_url":"https://api.github.com/users/tombruijn/followers","following_url":"https://api.github.com/users/tombruijn/following{/other_user}","gists_url":"https://api.github.com/users/tombruijn/gists{/gist_id}","starred_url":"https://api.github.com/users/tombruijn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tombruijn/subscriptions","organizations_url":"https://api.github.com/users/tombruijn/orgs","repos_url":"https://api.github.com/users/tombruijn/repos","events_url":"https://api.github.com/users/tombruijn/events{/privacy}","received_events_url":"https://api.github.com/users/tombruijn/received_events","type":"User","site_admin":false},"body":"using the `allow(GC::Profiler).to receive(:enable)` syntax matches more with the `expect(GC::Profiler).to receive(:method_name)` you use elsewhere. It does the same thing","created_at":"2016-09-07T13:56:41Z","updated_at":"2016-09-07T13:56:41Z","html_url":"https://github.com/appsignal/appsignal-ruby/pull/134#discussion_r77826426","pull_request_url":"https://api.github.com/repos/appsignal/appsignal-ruby/pulls/134","_links":{"self":{"href":"https://api.github.com/repos/appsignal/appsignal-ruby/pulls/comments/77826426"},"html":{"href":"https://github.com/appsignal/appsignal-ruby/pull/134#discussion_r77826426"},"pull_request":{"href":"https://api.github.com/repos/appsignal/appsignal-ruby/pulls/134"}}},"pull_request":{"url":"https://api.github.com/repos/appsignal/appsignal-ruby/pulls/134","id":83452903,"html_url":"https://github.com/appsignal/appsignal-ruby/pull/134","diff_url":"https://github.com/appsignal/appsignal-ruby/pull/134.diff","patch_url":"https://github.com/appsignal/appsignal-ruby/pull/134.patch","issue_url":"https://api.github.com/repos/appsignal/appsignal-ruby/issues/134","number":134,"state":"open","locked":false,"title":"Use GC::Profiler to track garbage collection time","user":{"login":"jeffkreeftmeijer","id":43621,"avatar_url":"https://avatars.githubusercontent.com/u/43621?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffkreeftmeijer","html_url":"https://github.com/jeffkreeftmeijer","followers_url":"https://api.github.com/users/jeffkreeftmeijer/followers","following_url":"https://api.github.com/users/jeffkreeftmeijer/following{/other_user}","gists_url":"https://api.github.com/users/jeffkreeftmeijer/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffkreeftmeijer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffkreeftmeijer/subscriptions","organizations_url":"https://api.github.com/users/jeffkreeftmeijer/orgs","repos_url":"https://api.github.com/users/jeffkreeftmeijer/repos","events_url":"https://api.github.com/users/jeffkreeftmeijer/events{/privacy}","received_events_url":"https://api.github.com/users/jeffkreeftmeijer/received_events","type":"User","site_admin":false},"body":"Instead of using Ruby's internal events, we'll use `GC::Profiler` to send garbage collection time to the agent per event.\r\n\r\n### TODO\r\n- [x]  Add a comment with the rationale behind this approach in garbage_collection_profiler.rb?","created_at":"2016-08-31T13:31:12Z","updated_at":"2016-09-07T13:56:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09d44a12f918fded76dbb45a6be9624aff86a19d","assignee":{"login":"thijsc","id":9794,"avatar_url":"https://avatars.githubusercontent.com/u/9794?v=3","gravatar_id":"","url":"https://api.github.com/users/thijsc","html_url":"https://github.com/thijsc","followers_url":"https://api.github.com/users/thijsc/followers","following_url":"https://api.github.com/users/thijsc/following{/other_user}","gists_url":"https://api.github.com/users/thijsc/gists{/gist_id}","starred_url":"https://api.github.com/users/thijsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thijsc/subscriptions","organizations_url":"https://api.github.com/users/thijsc/orgs","repos_url":"https://api.github.com/users/thijsc/repos","events_url":"https://api.github.com/users/thijsc/events{/privacy}","received_events_url":"https://api.github.com/users/thijsc/received_events","type":"User","site_admin":false},"assignees":[{"login":"thijsc","id":9794,"avatar_url":"https://avatars.githubusercontent.com/u/9794?v=3","gravatar_id":"","url":"https://api.github.com/users/thijsc","html_url":"https://github.com/thijsc","followers_url":"https://api.github.com/users/thijsc/followers","following_url":"https://api.github.com/users/thijsc/following{/other_user}","gists_url":"https://api.github.com/users/thijsc/gists{/gist_id}","starred_url":"https://api.github.com/users/thijsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thijsc/subscriptions","organizations_url":"https://api.github.com/users/thijsc/orgs","repos_url":"https://api.github.com/users/thijsc/repos","events_url":"https://api.github.com/users/thijsc/events{/privacy}","received_events_url":"https://api.github.com/users/thijsc/received_events","type":"User","site_admin":false},{"login":"matsimitsu","id":28408,"avatar_url":"https://avatars.githubusercontent.com/u/28408?v=3","gravatar_id":"","url":"https://api.github.com/users/matsimitsu","html_url":"https://github.com/matsimitsu","followers_url":"https://api.github.com/users/matsimitsu/followers","following_url":"https://api.github.com/users/matsimitsu/following{/other_user}","gists_url":"https://api.github.com/users/matsimitsu/gists{/gist_id}","starred_url":"https://api.github.com/users/matsimitsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matsimitsu/subscriptions","organizations_url":"https://api.github.com/users/matsimitsu/orgs","repos_url":"https://api.github.com/users/matsimitsu/repos","events_url":"https://api.github.com/users/matsimitsu/events{/privacy}","received_events_url":"https://api.github.com/users/matsimitsu/received_events","type":"User","site_admin":false},{"login":"tombruijn","id":282402,"avatar_url":"https://avatars.githubusercontent.com/u/282402?v=3","gravatar_id":"","url":"https://api.github.com/users/tombruijn","html_url":"https://github.com/tombruijn","followers_url":"https://api.github.com/users/tombruijn/followers","following_url":"https://api.github.com/users/tombruijn/following{/other_user}","gists_url":"https://api.github.com/users/tombruijn/gists{/gist_id}","starred_url":"https://api.github.com/users/tombruijn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tombruijn/subscriptions","organizations_url":"https://api.github.com/users/tombruijn/orgs","repos_url":"https://api.github.com/users/tombruijn/repos","events_url":"https://api.github.com/users/tombruijn/events{/privacy}","received_events_url":"https://api.github.com/users/tombruijn/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/appsignal/appsignal-ruby/pulls/134/commits","review_comments_url":"https://api.github.com/repos/appsignal/appsignal-ruby/pulls/134/comments","review_comment_url":"https://api.github.com/repos/appsignal/appsignal-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appsignal/appsignal-ruby/issues/134/comments","statuses_url":"https://api.github.com/repos/appsignal/appsignal-ruby/statuses/8fd93239c440dd12960aba7a8abbb9d085cb742c","head":{"label":"appsignal:gc_profiler","ref":"gc_profiler","sha":"8fd93239c440dd12960aba7a8abbb9d085cb742c","user":{"login":"appsignal","id":3984134,"avatar_url":"https://avatars.githubusercontent.com/u/3984134?v=3","gravatar_id":"","url":"https://api.github.com/users/appsignal","html_url":"https://github.com/appsignal","followers_url":"https://api.github.com/users/appsignal/followers","following_url":"https://api.github.com/users/appsignal/following{/other_user}","gists_url":"https://api.github.com/users/appsignal/gists{/gist_id}","starred_url":"https://api.github.com/users/appsignal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appsignal/subscriptions","organizations_url":"https://api.github.com/users/appsignal/orgs","repos_url":"https://api.github.com/users/appsignal/repos","events_url":"https://api.github.com/users/appsignal/events{/privacy}","received_events_url":"https://api.github.com/users/appsignal/received_events","type":"Organization","site_admin":false},"repo":{"id":10100635,"name":"appsignal-ruby","full_name":"appsignal/appsignal-ruby","owner":{"login":"appsignal","id":3984134,"avatar_url":"https://avatars.githubusercontent.com/u/3984134?v=3","gravatar_id":"","url":"https://api.github.com/users/appsignal","html_url":"https://github.com/appsignal","followers_url":"https://api.github.com/users/appsignal/followers","following_url":"https://api.github.com/users/appsignal/following{/other_user}","gists_url":"https://api.github.com/users/appsignal/gists{/gist_id}","starred_url":"https://api.github.com/users/appsignal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appsignal/subscriptions","organizations_url":"https://api.github.com/users/appsignal/orgs","repos_url":"https://api.github.com/users/appsignal/repos","events_url":"https://api.github.com/users/appsignal/events{/privacy}","received_events_url":"https://api.github.com/users/appsignal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appsignal/appsignal-ruby","description":"AppSignal agent for Ruby","fork":false,"url":"https://api.github.com/repos/appsignal/appsignal-ruby","forks_url":"https://api.github.com/repos/appsignal/appsignal-ruby/forks","keys_url":"https://api.github.com/repos/appsignal/appsignal-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appsignal/appsignal-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appsignal/appsignal-ruby/teams","hooks_url":"https://api.github.com/repos/appsignal/appsignal-ruby/hooks","issue_events_url":"https://api.github.com/repos/appsignal/appsignal-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/appsignal/appsignal-ruby/events","assignees_url":"https://api.github.com/repos/appsignal/appsignal-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/appsignal/appsignal-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/appsignal/appsignal-ruby/tags","blobs_url":"https://api.github.com/repos/appsignal/appsignal-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appsignal/appsignal-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appsignal/appsignal-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/appsignal/appsignal-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appsignal/appsignal-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/appsignal/appsignal-ruby/languages","stargazers_url":"https://api.github.com/repos/appsignal/appsignal-ruby/stargazers","contributors_url":"https://api.github.com/repos/appsignal/appsignal-ruby/contributors","subscribers_url":"https://api.github.com/repos/appsignal/appsignal-ruby/subscribers","subscription_url":"https://api.github.com/repos/appsignal/appsignal-ruby/subscription","commits_url":"https://api.github.com/repos/appsignal/appsignal-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/appsignal/appsignal-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/appsignal/appsignal-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/appsignal/appsignal-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/appsignal/appsignal-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/appsignal/appsignal-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appsignal/appsignal-ruby/merges","archive_url":"https://api.github.com/repos/appsignal/appsignal-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appsignal/appsignal-ruby/downloads","issues_url":"https://api.github.com/repos/appsignal/appsignal-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/appsignal/appsignal-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/appsignal/appsignal-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/appsignal/appsignal-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appsignal/appsignal-ruby/labels{/name}","releases_url":"https://api.github.com/repos/appsignal/appsignal-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/appsignal/appsignal-ruby/deployments","created_at":"2013-05-16T12:25:54Z","updated_at":"2016-08-18T07:02:59Z","pushed_at":"2016-09-07T13:08:23Z","git_url":"git://github.com/appsignal/appsignal-ruby.git","ssh_url":"git@github.com:appsignal/appsignal-ruby.git","clone_url":"https://github.com/appsignal/appsignal-ruby.git","svn_url":"https://github.com/appsignal/appsignal-ruby","homepage":"https://appsignal.com","size":2446,"stargazers_count":28,"watchers_count":28,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":13,"forks":43,"open_issues":13,"watchers":28,"default_branch":"master"}},"base":{"label":"appsignal:develop","ref":"develop","sha":"d03eb6c7b55ffc1fe20e138e26114e60dea8ef6e","user":{"login":"appsignal","id":3984134,"avatar_url":"https://avatars.githubusercontent.com/u/3984134?v=3","gravatar_id":"","url":"https://api.github.com/users/appsignal","html_url":"https://github.com/appsignal","followers_url":"https://api.github.com/users/appsignal/followers","following_url":"https://api.github.com/users/appsignal/following{/other_user}","gists_url":"https://api.github.com/users/appsignal/gists{/gist_id}","starred_url":"https://api.github.com/users/appsignal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appsignal/subscriptions","organizations_url":"https://api.github.com/users/appsignal/orgs","repos_url":"https://api.github.com/users/appsignal/repos","events_url":"https://api.github.com/users/appsignal/events{/privacy}","received_events_url":"https://api.github.com/users/appsignal/received_events","type":"Organization","site_admin":false},"repo":{"id":10100635,"name":"appsignal-ruby","full_name":"appsignal/appsignal-ruby","owner":{"login":"appsignal","id":3984134,"avatar_url":"https://avatars.githubusercontent.com/u/3984134?v=3","gravatar_id":"","url":"https://api.github.com/users/appsignal","html_url":"https://github.com/appsignal","followers_url":"https://api.github.com/users/appsignal/followers","following_url":"https://api.github.com/users/appsignal/following{/other_user}","gists_url":"https://api.github.com/users/appsignal/gists{/gist_id}","starred_url":"https://api.github.com/users/appsignal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appsignal/subscriptions","organizations_url":"https://api.github.com/users/appsignal/orgs","repos_url":"https://api.github.com/users/appsignal/repos","events_url":"https://api.github.com/users/appsignal/events{/privacy}","received_events_url":"https://api.github.com/users/appsignal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appsignal/appsignal-ruby","description":"AppSignal agent for Ruby","fork":false,"url":"https://api.github.com/repos/appsignal/appsignal-ruby","forks_url":"https://api.github.com/repos/appsignal/appsignal-ruby/forks","keys_url":"https://api.github.com/repos/appsignal/appsignal-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appsignal/appsignal-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appsignal/appsignal-ruby/teams","hooks_url":"https://api.github.com/repos/appsignal/appsignal-ruby/hooks","issue_events_url":"https://api.github.com/repos/appsignal/appsignal-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/appsignal/appsignal-ruby/events","assignees_url":"https://api.github.com/repos/appsignal/appsignal-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/appsignal/appsignal-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/appsignal/appsignal-ruby/tags","blobs_url":"https://api.github.com/repos/appsignal/appsignal-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appsignal/appsignal-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appsignal/appsignal-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/appsignal/appsignal-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appsignal/appsignal-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/appsignal/appsignal-ruby/languages","stargazers_url":"https://api.github.com/repos/appsignal/appsignal-ruby/stargazers","contributors_url":"https://api.github.com/repos/appsignal/appsignal-ruby/contributors","subscribers_url":"https://api.github.com/repos/appsignal/appsignal-ruby/subscribers","subscription_url":"https://api.github.com/repos/appsignal/appsignal-ruby/subscription","commits_url":"https://api.github.com/repos/appsignal/appsignal-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/appsignal/appsignal-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/appsignal/appsignal-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/appsignal/appsignal-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/appsignal/appsignal-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/appsignal/appsignal-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appsignal/appsignal-ruby/merges","archive_url":"https://api.github.com/repos/appsignal/appsignal-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appsignal/appsignal-ruby/downloads","issues_url":"https://api.github.com/repos/appsignal/appsignal-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/appsignal/appsignal-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/appsignal/appsignal-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/appsignal/appsignal-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appsignal/appsignal-ruby/labels{/name}","releases_url":"https://api.github.com/repos/appsignal/appsignal-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/appsignal/appsignal-ruby/deployments","created_at":"2013-05-16T12:25:54Z","updated_at":"2016-08-18T07:02:59Z","pushed_at":"2016-09-07T13:08:23Z","git_url":"git://github.com/appsignal/appsignal-ruby.git","ssh_url":"git@github.com:appsignal/appsignal-ruby.git","clone_url":"https://github.com/appsignal/appsignal-ruby.git","svn_url":"https://github.com/appsignal/appsignal-ruby","homepage":"https://appsignal.com","size":2446,"stargazers_count":28,"watchers_count":28,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":13,"forks":43,"open_issues":13,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appsignal/appsignal-ruby/pulls/134"},"html":{"href":"https://github.com/appsignal/appsignal-ruby/pull/134"},"issue":{"href":"https://api.github.com/repos/appsignal/appsignal-ruby/issues/134"},"comments":{"href":"https://api.github.com/repos/appsignal/appsignal-ruby/issues/134/comments"},"review_comments":{"href":"https://api.github.com/repos/appsignal/appsignal-ruby/pulls/134/comments"},"review_comment":{"href":"https://api.github.com/repos/appsignal/appsignal-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appsignal/appsignal-ruby/pulls/134/commits"},"statuses":{"href":"https://api.github.com/repos/appsignal/appsignal-ruby/statuses/8fd93239c440dd12960aba7a8abbb9d085cb742c"}}}}
{"actor":{"display_login":"tombruijn"}}