{"action":"created","comment":{"url":"https://api.github.com/repos/Zenika/react-loader/pulls/comments/82866247","pull_request_review_id":3740767,"id":82866247,"diff_hunk":"@@ -7,15 +7,99 @@ import Example from 'Example'\n import styles from './Examples.scss'\n \n import Base from './Base'\n+import OneParam from './OneParam'\n+import TwoParams from './TwoParams'\n+import DontWait from './DontWait'\n+import Loader from './Loader'\n \n const Examples = ({ style, className }) => (\n   <div style={style} className={`${styles.examples} ${className}`}>\n     <Example\n       className={styles.example}\n       link=\"Base\"\n       code=\"export&nbsp;default loader(Base)\"\n+      buttons={{ 0: true }}\n+      example={<Base />}\n     >\n-      <Base />\n+      <div className={styles.doc}>\n+        <h3>Base: defaults parameters</h3>\n+        <p className={styles.description}>\n+          In this example, the loader wraps a Component with its default parameters.\n+          It means that the loader calls <pre>this.props.load</pre>\n+          &nbsp;if presents, then waits for <pre>this.props.loaded</pre>\n+          &nbsp;to be truthy, and finally prints the wrapped components.\n+          While waiting for <pre>this.props.loaded</pre>&nbsp;\n+          to be truthy, hoc-react-loader takes care of printing\n+          a loading spin based on the background color.\n+        </p>\n+      </div>\n+    </Example>\n+\n+    <Example\n+      className={styles.example}\n+      link=\"OneParam\"\n+      code=\"export&nbsp;default loader(OneParam, { wait: ['prop'] })\"\n+      buttons={{ 1: true }}\n+      example={<OneParam />}\n+    >\n+      <div className={styles.doc}>\n+        <h3>OneParam: waiting for a given param</h3>\n+        <p className={styles.description}>\n+          Like previous example, the default loader is used (Loading spin) and\n+          &nbsp;<pre>this.props.load</pre> is called. But this time, the <pre>HOC</pre> waits for\n+          &nbsp;<pre>this.props.prop</pre> as specified in the <pre>wait</pre> param.\n+        </p>\n+      </div>\n+    </Example>\n+\n+    <Example\n+      className={styles.example}\n+      link=\"TwoParams\"\n+      code=\"export&nbsp;default loader(TwoParams, { wait: ['prop', 'prop2'] })\"\n+      buttons={{ 1: true, 2: true }}\n+      example={<TwoParams />}\n+    >\n+      <div className={styles.doc}>\n+        <h3>TwoParams: wait for multiple props</h3>\n+        <p className={styles.description}>\n+          Waiting for multiple props is easy, just give an array in the <pre>wait</pre> param.\n+          Here, <pre>hoc-react-loader</pre> waits for <pre>prop</pre> and <pre>prop2</pre>\n+          &nbsp;to be truthy!\n+        </p>\n+      </div>\n+    </Example>\n+\n+    <Example\n+      className={styles.example}\n+      link=\"DontWait\"\n+      code=\"export&nbsp;default loader(DontWait, { wait: false })\"\n+      buttons={{ 0: true }}\n+      example={<DontWait />}\n+    >\n+      <div className={styles.doc}>\n+        <h3>DontWait: don't show the placeholder</h3>\n+        <p className={styles.description}>\n+          If the <pre>wait</pre> param is set to <pre>false</pre> the <pre>hoc-react-loader</pre>\n+          &nbsp;will not print the Loader (default or specified one). But <pre>this.props.load</pre>\n+          &nbsp;is called if presents!\n+        </p>\n+      </div>\n+    </Example>\n+\n+    <Example\n+      className={styles.example}\n+      link=\"Base\"\n+      code=\"export&nbsp;default loader(Loader, { Loader: CustomLoader })\"\n+      buttons={{ 0: true }}\n+      example={<Loader />}\n+    >\n+      <div className={styles.doc}>\n+        <h3>Loader: change the default loader</h3>","path":"examples/src/components/Examples/Examples.jsx","position":92,"original_position":92,"commit_id":"314078a78644bcd3944c7641a2241cdc46a9b333","original_commit_id":"314078a78644bcd3944c7641a2241cdc46a9b333","user":{"login":"hgwood","id":1656170,"avatar_url":"https://avatars.githubusercontent.com/u/1656170?v=3","gravatar_id":"","url":"https://api.github.com/users/hgwood","html_url":"https://github.com/hgwood","followers_url":"https://api.github.com/users/hgwood/followers","following_url":"https://api.github.com/users/hgwood/following{/other_user}","gists_url":"https://api.github.com/users/hgwood/gists{/gist_id}","starred_url":"https://api.github.com/users/hgwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hgwood/subscriptions","organizations_url":"https://api.github.com/users/hgwood/orgs","repos_url":"https://api.github.com/users/hgwood/repos","events_url":"https://api.github.com/users/hgwood/events{/privacy}","received_events_url":"https://api.github.com/users/hgwood/received_events","type":"User","site_admin":false},"body":"Loader -> loading indicator (both times)","created_at":"2016-10-11T19:06:34Z","updated_at":"2016-10-11T19:06:34Z","html_url":"https://github.com/Zenika/react-loader/pull/29#discussion_r82866247","pull_request_url":"https://api.github.com/repos/Zenika/react-loader/pulls/29","_links":{"self":{"href":"https://api.github.com/repos/Zenika/react-loader/pulls/comments/82866247"},"html":{"href":"https://github.com/Zenika/react-loader/pull/29#discussion_r82866247"},"pull_request":{"href":"https://api.github.com/repos/Zenika/react-loader/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/Zenika/react-loader/pulls/29","id":88850721,"html_url":"https://github.com/Zenika/react-loader/pull/29","diff_url":"https://github.com/Zenika/react-loader/pull/29.diff","patch_url":"https://github.com/Zenika/react-loader/pull/29.patch","issue_url":"https://api.github.com/repos/Zenika/react-loader/issues/29","number":29,"state":"open","locked":false,"title":"documentation + minor fixes","user":{"login":"fabienjuif","id":17828231,"avatar_url":"https://avatars.githubusercontent.com/u/17828231?v=3","gravatar_id":"","url":"https://api.github.com/users/fabienjuif","html_url":"https://github.com/fabienjuif","followers_url":"https://api.github.com/users/fabienjuif/followers","following_url":"https://api.github.com/users/fabienjuif/following{/other_user}","gists_url":"https://api.github.com/users/fabienjuif/gists{/gist_id}","starred_url":"https://api.github.com/users/fabienjuif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabienjuif/subscriptions","organizations_url":"https://api.github.com/users/fabienjuif/orgs","repos_url":"https://api.github.com/users/fabienjuif/repos","events_url":"https://api.github.com/users/fabienjuif/events{/privacy}","received_events_url":"https://api.github.com/users/fabienjuif/received_events","type":"User","site_admin":false},"body":"- [x] New colors\r\n- [x] New description\r\n- [x] New API examples\r\n- [x] Examples are simplier\r\n- [x] Add tests for the spinner (100% coverage, yeah) \r\n- [x] Fix `wait: false`\r\n- [x] Fix Spiner parent to parent color finder","created_at":"2016-10-11T15:07:35Z","updated_at":"2016-10-11T19:10:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24b8d6860d8990cd0316067e2dc1a5b2e5e82040","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Zenika/react-loader/pulls/29/commits","review_comments_url":"https://api.github.com/repos/Zenika/react-loader/pulls/29/comments","review_comment_url":"https://api.github.com/repos/Zenika/react-loader/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Zenika/react-loader/issues/29/comments","statuses_url":"https://api.github.com/repos/Zenika/react-loader/statuses/314078a78644bcd3944c7641a2241cdc46a9b333","head":{"label":"Zenika:docs","ref":"docs","sha":"314078a78644bcd3944c7641a2241cdc46a9b333","user":{"login":"Zenika","id":630230,"avatar_url":"https://avatars.githubusercontent.com/u/630230?v=3","gravatar_id":"","url":"https://api.github.com/users/Zenika","html_url":"https://github.com/Zenika","followers_url":"https://api.github.com/users/Zenika/followers","following_url":"https://api.github.com/users/Zenika/following{/other_user}","gists_url":"https://api.github.com/users/Zenika/gists{/gist_id}","starred_url":"https://api.github.com/users/Zenika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zenika/subscriptions","organizations_url":"https://api.github.com/users/Zenika/orgs","repos_url":"https://api.github.com/users/Zenika/repos","events_url":"https://api.github.com/users/Zenika/events{/privacy}","received_events_url":"https://api.github.com/users/Zenika/received_events","type":"Organization","site_admin":false},"repo":{"id":65548817,"name":"react-loader","full_name":"Zenika/react-loader","owner":{"login":"Zenika","id":630230,"avatar_url":"https://avatars.githubusercontent.com/u/630230?v=3","gravatar_id":"","url":"https://api.github.com/users/Zenika","html_url":"https://github.com/Zenika","followers_url":"https://api.github.com/users/Zenika/followers","following_url":"https://api.github.com/users/Zenika/following{/other_user}","gists_url":"https://api.github.com/users/Zenika/gists{/gist_id}","starred_url":"https://api.github.com/users/Zenika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zenika/subscriptions","organizations_url":"https://api.github.com/users/Zenika/orgs","repos_url":"https://api.github.com/users/Zenika/repos","events_url":"https://api.github.com/users/Zenika/events{/privacy}","received_events_url":"https://api.github.com/users/Zenika/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Zenika/react-loader","description":"Calls the load function from props at mount","fork":false,"url":"https://api.github.com/repos/Zenika/react-loader","forks_url":"https://api.github.com/repos/Zenika/react-loader/forks","keys_url":"https://api.github.com/repos/Zenika/react-loader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zenika/react-loader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zenika/react-loader/teams","hooks_url":"https://api.github.com/repos/Zenika/react-loader/hooks","issue_events_url":"https://api.github.com/repos/Zenika/react-loader/issues/events{/number}","events_url":"https://api.github.com/repos/Zenika/react-loader/events","assignees_url":"https://api.github.com/repos/Zenika/react-loader/assignees{/user}","branches_url":"https://api.github.com/repos/Zenika/react-loader/branches{/branch}","tags_url":"https://api.github.com/repos/Zenika/react-loader/tags","blobs_url":"https://api.github.com/repos/Zenika/react-loader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zenika/react-loader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zenika/react-loader/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zenika/react-loader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zenika/react-loader/statuses/{sha}","languages_url":"https://api.github.com/repos/Zenika/react-loader/languages","stargazers_url":"https://api.github.com/repos/Zenika/react-loader/stargazers","contributors_url":"https://api.github.com/repos/Zenika/react-loader/contributors","subscribers_url":"https://api.github.com/repos/Zenika/react-loader/subscribers","subscription_url":"https://api.github.com/repos/Zenika/react-loader/subscription","commits_url":"https://api.github.com/repos/Zenika/react-loader/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zenika/react-loader/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zenika/react-loader/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zenika/react-loader/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zenika/react-loader/contents/{+path}","compare_url":"https://api.github.com/repos/Zenika/react-loader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zenika/react-loader/merges","archive_url":"https://api.github.com/repos/Zenika/react-loader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zenika/react-loader/downloads","issues_url":"https://api.github.com/repos/Zenika/react-loader/issues{/number}","pulls_url":"https://api.github.com/repos/Zenika/react-loader/pulls{/number}","milestones_url":"https://api.github.com/repos/Zenika/react-loader/milestones{/number}","notifications_url":"https://api.github.com/repos/Zenika/react-loader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zenika/react-loader/labels{/name}","releases_url":"https://api.github.com/repos/Zenika/react-loader/releases{/id}","deployments_url":"https://api.github.com/repos/Zenika/react-loader/deployments","created_at":"2016-08-12T11:36:15Z","updated_at":"2016-10-11T14:32:38Z","pushed_at":"2016-10-11T17:31:33Z","git_url":"git://github.com/Zenika/react-loader.git","ssh_url":"git@github.com:Zenika/react-loader.git","clone_url":"https://github.com/Zenika/react-loader.git","svn_url":"https://github.com/Zenika/react-loader","homepage":"https://zenika.github.io/react-loader/","size":331,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":9,"default_branch":"master"}},"base":{"label":"Zenika:master","ref":"master","sha":"3388385acb4859d158e613232d4d6e46db5aba6d","user":{"login":"Zenika","id":630230,"avatar_url":"https://avatars.githubusercontent.com/u/630230?v=3","gravatar_id":"","url":"https://api.github.com/users/Zenika","html_url":"https://github.com/Zenika","followers_url":"https://api.github.com/users/Zenika/followers","following_url":"https://api.github.com/users/Zenika/following{/other_user}","gists_url":"https://api.github.com/users/Zenika/gists{/gist_id}","starred_url":"https://api.github.com/users/Zenika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zenika/subscriptions","organizations_url":"https://api.github.com/users/Zenika/orgs","repos_url":"https://api.github.com/users/Zenika/repos","events_url":"https://api.github.com/users/Zenika/events{/privacy}","received_events_url":"https://api.github.com/users/Zenika/received_events","type":"Organization","site_admin":false},"repo":{"id":65548817,"name":"react-loader","full_name":"Zenika/react-loader","owner":{"login":"Zenika","id":630230,"avatar_url":"https://avatars.githubusercontent.com/u/630230?v=3","gravatar_id":"","url":"https://api.github.com/users/Zenika","html_url":"https://github.com/Zenika","followers_url":"https://api.github.com/users/Zenika/followers","following_url":"https://api.github.com/users/Zenika/following{/other_user}","gists_url":"https://api.github.com/users/Zenika/gists{/gist_id}","starred_url":"https://api.github.com/users/Zenika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zenika/subscriptions","organizations_url":"https://api.github.com/users/Zenika/orgs","repos_url":"https://api.github.com/users/Zenika/repos","events_url":"https://api.github.com/users/Zenika/events{/privacy}","received_events_url":"https://api.github.com/users/Zenika/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Zenika/react-loader","description":"Calls the load function from props at mount","fork":false,"url":"https://api.github.com/repos/Zenika/react-loader","forks_url":"https://api.github.com/repos/Zenika/react-loader/forks","keys_url":"https://api.github.com/repos/Zenika/react-loader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zenika/react-loader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zenika/react-loader/teams","hooks_url":"https://api.github.com/repos/Zenika/react-loader/hooks","issue_events_url":"https://api.github.com/repos/Zenika/react-loader/issues/events{/number}","events_url":"https://api.github.com/repos/Zenika/react-loader/events","assignees_url":"https://api.github.com/repos/Zenika/react-loader/assignees{/user}","branches_url":"https://api.github.com/repos/Zenika/react-loader/branches{/branch}","tags_url":"https://api.github.com/repos/Zenika/react-loader/tags","blobs_url":"https://api.github.com/repos/Zenika/react-loader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zenika/react-loader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zenika/react-loader/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zenika/react-loader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zenika/react-loader/statuses/{sha}","languages_url":"https://api.github.com/repos/Zenika/react-loader/languages","stargazers_url":"https://api.github.com/repos/Zenika/react-loader/stargazers","contributors_url":"https://api.github.com/repos/Zenika/react-loader/contributors","subscribers_url":"https://api.github.com/repos/Zenika/react-loader/subscribers","subscription_url":"https://api.github.com/repos/Zenika/react-loader/subscription","commits_url":"https://api.github.com/repos/Zenika/react-loader/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zenika/react-loader/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zenika/react-loader/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zenika/react-loader/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zenika/react-loader/contents/{+path}","compare_url":"https://api.github.com/repos/Zenika/react-loader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zenika/react-loader/merges","archive_url":"https://api.github.com/repos/Zenika/react-loader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zenika/react-loader/downloads","issues_url":"https://api.github.com/repos/Zenika/react-loader/issues{/number}","pulls_url":"https://api.github.com/repos/Zenika/react-loader/pulls{/number}","milestones_url":"https://api.github.com/repos/Zenika/react-loader/milestones{/number}","notifications_url":"https://api.github.com/repos/Zenika/react-loader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zenika/react-loader/labels{/name}","releases_url":"https://api.github.com/repos/Zenika/react-loader/releases{/id}","deployments_url":"https://api.github.com/repos/Zenika/react-loader/deployments","created_at":"2016-08-12T11:36:15Z","updated_at":"2016-10-11T14:32:38Z","pushed_at":"2016-10-11T17:31:33Z","git_url":"git://github.com/Zenika/react-loader.git","ssh_url":"git@github.com:Zenika/react-loader.git","clone_url":"https://github.com/Zenika/react-loader.git","svn_url":"https://github.com/Zenika/react-loader","homepage":"https://zenika.github.io/react-loader/","size":331,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Zenika/react-loader/pulls/29"},"html":{"href":"https://github.com/Zenika/react-loader/pull/29"},"issue":{"href":"https://api.github.com/repos/Zenika/react-loader/issues/29"},"comments":{"href":"https://api.github.com/repos/Zenika/react-loader/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/Zenika/react-loader/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/Zenika/react-loader/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Zenika/react-loader/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/Zenika/react-loader/statuses/314078a78644bcd3944c7641a2241cdc46a9b333"}}}}
{"actor":{"display_login":"hgwood"}}