{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/80849806","pull_request_review_id":1874032,"id":80849806,"diff_hunk":"@@ -380,14 +387,42 @@ func (m *kubeGenericRuntimeManager) computePodContainerChanges(pod *api.Pod, pod\n \n \tsandboxChanged, attempt, sandboxID := m.podSandboxChanged(pod, podStatus)\n \tchanges := podContainerSpecChanges{\n-\t\tCreateSandbox:     sandboxChanged,\n-\t\tSandboxID:         sandboxID,\n-\t\tAttempt:           attempt,\n-\t\tContainersToStart: make(map[int]string),\n-\t\tContainersToKeep:  make(map[kubecontainer.ContainerID]int),\n-\t\tContainersToKill:  make(map[kubecontainer.ContainerID]containerToKillInfo),\n+\t\tCreateSandbox:        sandboxChanged,\n+\t\tSandboxID:            sandboxID,\n+\t\tAttempt:              attempt,\n+\t\tContainersToStart:    make(map[int]string),\n+\t\tContainersToKeep:     make(map[kubecontainer.ContainerID]int),\n+\t\tInitContainersToKeep: make(map[kubecontainer.ContainerID]int),\n+\t\tContainersToKill:     make(map[kubecontainer.ContainerID]containerToKillInfo),\n+\t}\n+\n+\t// check the status of init containers.\n+\tinitFailed := false\n+\t// always reset the init containers if the sandbox is changed.\n+\tif !sandboxChanged {\n+\tContainers:\n+\t\t// keep all successfully completed containers up to and including the first failing container","path":"pkg/kubelet/kuberuntime/kuberuntime_manager.go","position":null,"original_position":38,"commit_id":"c52a714d27e69510b0e8209a4a942c6a5a1ac94b","original_commit_id":"47c578b084734b32535ff7df74a2a38b8bcec63e","user":{"login":"feiskyer","id":676637,"avatar_url":"https://avatars.githubusercontent.com/u/676637?v=3","gravatar_id":"","url":"https://api.github.com/users/feiskyer","html_url":"https://github.com/feiskyer","followers_url":"https://api.github.com/users/feiskyer/followers","following_url":"https://api.github.com/users/feiskyer/following{/other_user}","gists_url":"https://api.github.com/users/feiskyer/gists{/gist_id}","starred_url":"https://api.github.com/users/feiskyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feiskyer/subscriptions","organizations_url":"https://api.github.com/users/feiskyer/orgs","repos_url":"https://api.github.com/users/feiskyer/repos","events_url":"https://api.github.com/users/feiskyer/events{/privacy}","received_events_url":"https://api.github.com/users/feiskyer/received_events","type":"User","site_admin":false},"body":"ack","created_at":"2016-09-28T06:25:18Z","updated_at":"2016-09-28T06:25:18Z","html_url":"https://github.com/kubernetes/kubernetes/pull/33363#discussion_r80849806","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33363","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/80849806"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/33363#discussion_r80849806"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33363"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33363","id":86482247,"html_url":"https://github.com/kubernetes/kubernetes/pull/33363","diff_url":"https://github.com/kubernetes/kubernetes/pull/33363.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/33363.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/33363","number":33363,"state":"open","locked":false,"title":"CRI: Add init containers","user":{"login":"feiskyer","id":676637,"avatar_url":"https://avatars.githubusercontent.com/u/676637?v=3","gravatar_id":"","url":"https://api.github.com/users/feiskyer","html_url":"https://github.com/feiskyer","followers_url":"https://api.github.com/users/feiskyer/followers","following_url":"https://api.github.com/users/feiskyer/following{/other_user}","gists_url":"https://api.github.com/users/feiskyer/gists{/gist_id}","starred_url":"https://api.github.com/users/feiskyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feiskyer/subscriptions","organizations_url":"https://api.github.com/users/feiskyer/orgs","repos_url":"https://api.github.com/users/feiskyer/repos","events_url":"https://api.github.com/users/feiskyer/events{/privacy}","received_events_url":"https://api.github.com/users/feiskyer/received_events","type":"User","site_admin":false},"body":"This PR adds init containers support in CRI.\r\n\r\nCC @yujuhong @Random-Liu @yifan-gu \r\n\r\nAlso CC @kubernetes/sig-node @kubernetes/sig-rktnetes\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/33363)\n<!-- Reviewable:end -->\n","created_at":"2016-09-23T09:39:24Z","updated_at":"2016-09-28T06:25:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"974b92e75463dc7060147e53c0799bf2e8694492","assignee":{"login":"yifan-gu","id":3278588,"avatar_url":"https://avatars.githubusercontent.com/u/3278588?v=3","gravatar_id":"","url":"https://api.github.com/users/yifan-gu","html_url":"https://github.com/yifan-gu","followers_url":"https://api.github.com/users/yifan-gu/followers","following_url":"https://api.github.com/users/yifan-gu/following{/other_user}","gists_url":"https://api.github.com/users/yifan-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/yifan-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifan-gu/subscriptions","organizations_url":"https://api.github.com/users/yifan-gu/orgs","repos_url":"https://api.github.com/users/yifan-gu/repos","events_url":"https://api.github.com/users/yifan-gu/events{/privacy}","received_events_url":"https://api.github.com/users/yifan-gu/received_events","type":"User","site_admin":false},"assignees":[{"login":"yifan-gu","id":3278588,"avatar_url":"https://avatars.githubusercontent.com/u/3278588?v=3","gravatar_id":"","url":"https://api.github.com/users/yifan-gu","html_url":"https://github.com/yifan-gu","followers_url":"https://api.github.com/users/yifan-gu/followers","following_url":"https://api.github.com/users/yifan-gu/following{/other_user}","gists_url":"https://api.github.com/users/yifan-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/yifan-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifan-gu/subscriptions","organizations_url":"https://api.github.com/users/yifan-gu/orgs","repos_url":"https://api.github.com/users/yifan-gu/repos","events_url":"https://api.github.com/users/yifan-gu/events{/privacy}","received_events_url":"https://api.github.com/users/yifan-gu/received_events","type":"User","site_admin":false},{"login":"Random-Liu","id":5821883,"avatar_url":"https://avatars.githubusercontent.com/u/5821883?v=3","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},{"login":"yujuhong","id":10524058,"avatar_url":"https://avatars.githubusercontent.com/u/10524058?v=3","gravatar_id":"","url":"https://api.github.com/users/yujuhong","html_url":"https://github.com/yujuhong","followers_url":"https://api.github.com/users/yujuhong/followers","following_url":"https://api.github.com/users/yujuhong/following{/other_user}","gists_url":"https://api.github.com/users/yujuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/yujuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yujuhong/subscriptions","organizations_url":"https://api.github.com/users/yujuhong/orgs","repos_url":"https://api.github.com/users/yujuhong/repos","events_url":"https://api.github.com/users/yujuhong/events{/privacy}","received_events_url":"https://api.github.com/users/yujuhong/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/23","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.5","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/23/labels","id":1945978,"number":23,"title":"v1.5","description":"","creator":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"open_issues":209,"closed_issues":98,"state":"open","created_at":"2016-08-16T21:47:28Z","updated_at":"2016-09-28T05:58:20Z","due_on":"2016-12-09T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33363/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33363/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/33363/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/c52a714d27e69510b0e8209a4a942c6a5a1ac94b","head":{"label":"feiskyer:initcontainer","ref":"initcontainer","sha":"c52a714d27e69510b0e8209a4a942c6a5a1ac94b","user":{"login":"feiskyer","id":676637,"avatar_url":"https://avatars.githubusercontent.com/u/676637?v=3","gravatar_id":"","url":"https://api.github.com/users/feiskyer","html_url":"https://github.com/feiskyer","followers_url":"https://api.github.com/users/feiskyer/followers","following_url":"https://api.github.com/users/feiskyer/following{/other_user}","gists_url":"https://api.github.com/users/feiskyer/gists{/gist_id}","starred_url":"https://api.github.com/users/feiskyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feiskyer/subscriptions","organizations_url":"https://api.github.com/users/feiskyer/orgs","repos_url":"https://api.github.com/users/feiskyer/repos","events_url":"https://api.github.com/users/feiskyer/events{/privacy}","received_events_url":"https://api.github.com/users/feiskyer/received_events","type":"User","site_admin":false},"repo":{"id":39993689,"name":"kubernetes","full_name":"feiskyer/kubernetes","owner":{"login":"feiskyer","id":676637,"avatar_url":"https://avatars.githubusercontent.com/u/676637?v=3","gravatar_id":"","url":"https://api.github.com/users/feiskyer","html_url":"https://github.com/feiskyer","followers_url":"https://api.github.com/users/feiskyer/followers","following_url":"https://api.github.com/users/feiskyer/following{/other_user}","gists_url":"https://api.github.com/users/feiskyer/gists{/gist_id}","starred_url":"https://api.github.com/users/feiskyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feiskyer/subscriptions","organizations_url":"https://api.github.com/users/feiskyer/orgs","repos_url":"https://api.github.com/users/feiskyer/repos","events_url":"https://api.github.com/users/feiskyer/events{/privacy}","received_events_url":"https://api.github.com/users/feiskyer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/feiskyer/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/feiskyer/kubernetes","forks_url":"https://api.github.com/repos/feiskyer/kubernetes/forks","keys_url":"https://api.github.com/repos/feiskyer/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feiskyer/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feiskyer/kubernetes/teams","hooks_url":"https://api.github.com/repos/feiskyer/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/feiskyer/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/feiskyer/kubernetes/events","assignees_url":"https://api.github.com/repos/feiskyer/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/feiskyer/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/feiskyer/kubernetes/tags","blobs_url":"https://api.github.com/repos/feiskyer/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feiskyer/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feiskyer/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/feiskyer/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feiskyer/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/feiskyer/kubernetes/languages","stargazers_url":"https://api.github.com/repos/feiskyer/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/feiskyer/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/feiskyer/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/feiskyer/kubernetes/subscription","commits_url":"https://api.github.com/repos/feiskyer/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/feiskyer/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/feiskyer/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/feiskyer/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/feiskyer/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/feiskyer/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feiskyer/kubernetes/merges","archive_url":"https://api.github.com/repos/feiskyer/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feiskyer/kubernetes/downloads","issues_url":"https://api.github.com/repos/feiskyer/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/feiskyer/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/feiskyer/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/feiskyer/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feiskyer/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/feiskyer/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/feiskyer/kubernetes/deployments","created_at":"2015-07-31T07:53:03Z","updated_at":"2016-02-12T09:40:13Z","pushed_at":"2016-09-28T06:24:19Z","git_url":"git://github.com/feiskyer/kubernetes.git","ssh_url":"git@github.com:feiskyer/kubernetes.git","clone_url":"https://github.com/feiskyer/kubernetes.git","svn_url":"https://github.com/feiskyer/kubernetes","homepage":"http://kubernetes.io","size":328947,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"08dd56942438919418296134882a8cd4fa68b468","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-09-28T05:58:23Z","pushed_at":"2016-09-28T06:24:27Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":572208,"stargazers_count":17125,"watchers_count":17125,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5553,"mirror_url":null,"open_issues_count":4651,"forks":5553,"open_issues":4651,"watchers":17125,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33363"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/33363"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/33363"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/33363/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33363/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33363/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/c52a714d27e69510b0e8209a4a942c6a5a1ac94b"}}}}
{"actor":{"display_login":"feiskyer"}}