{"action":"created","comment":{"url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/pulls/comments/87874054","pull_request_review_id":8467524,"id":87874054,"diff_hunk":"@@ -33,39 +35,79 @@ export class SNSClient {\n     this.snsCreateTopic = bPromise.promisify(snsClient.createTopic, context);\n     this.snsPublish = bPromise.promisify(snsClient.publish, context);\n     this.snsSubscribeTopic = bPromise.promisify(snsClient.subscribe, context);\n+    this.snsListTopics = bPromise.promisify(snsClient.listTopics, context);\n \n     this.log = log || new NoopLogger();\n   }\n \n-  private async getArn(topicName:string):Promise<string> {\n+  private topicFullName(topicName:string):string {\n+    return `${this.config.namePrefix}-${topicName}`;\n+  }\n+\n+  private async getArn(topicName:string, createIfUnknown:boolean):Promise<string> {","path":"src/clients/sns.ts","position":23,"original_position":23,"commit_id":"b52d17b2cbcd09056ca13a56ff36a8984db82eb7","original_commit_id":"b52d17b2cbcd09056ca13a56ff36a8984db82eb7","user":{"login":"igrayson","id":6943580,"avatar_url":"https://avatars.githubusercontent.com/u/6943580?v=3","gravatar_id":"","url":"https://api.github.com/users/igrayson","html_url":"https://github.com/igrayson","followers_url":"https://api.github.com/users/igrayson/followers","following_url":"https://api.github.com/users/igrayson/following{/other_user}","gists_url":"https://api.github.com/users/igrayson/gists{/gist_id}","starred_url":"https://api.github.com/users/igrayson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igrayson/subscriptions","organizations_url":"https://api.github.com/users/igrayson/orgs","repos_url":"https://api.github.com/users/igrayson/repos","events_url":"https://api.github.com/users/igrayson/events{/privacy}","received_events_url":"https://api.github.com/users/igrayson/received_events","type":"User","site_admin":false},"body":"It's fairly unintuitive that a `getArn` call would write (create) an arn. `getOrCreateArn`?","created_at":"2016-11-14T19:27:51Z","updated_at":"2016-11-14T19:27:51Z","html_url":"https://github.com/convoyinc/lib-task-scheduler/pull/3#discussion_r87874054","pull_request_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/convoyinc/lib-task-scheduler/pulls/comments/87874054"},"html":{"href":"https://github.com/convoyinc/lib-task-scheduler/pull/3#discussion_r87874054"},"pull_request":{"href":"https://api.github.com/repos/convoyinc/lib-task-scheduler/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/pulls/3","id":93383637,"html_url":"https://github.com/convoyinc/lib-task-scheduler/pull/3","diff_url":"https://github.com/convoyinc/lib-task-scheduler/pull/3.diff","patch_url":"https://github.com/convoyinc/lib-task-scheduler/pull/3.patch","issue_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/issues/3","number":3,"state":"open","locked":false,"title":"Add findArn to sns","user":{"login":"logandillard","id":20586282,"avatar_url":"https://avatars.githubusercontent.com/u/20586282?v=3","gravatar_id":"","url":"https://api.github.com/users/logandillard","html_url":"https://github.com/logandillard","followers_url":"https://api.github.com/users/logandillard/followers","following_url":"https://api.github.com/users/logandillard/following{/other_user}","gists_url":"https://api.github.com/users/logandillard/gists{/gist_id}","starred_url":"https://api.github.com/users/logandillard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logandillard/subscriptions","organizations_url":"https://api.github.com/users/logandillard/orgs","repos_url":"https://api.github.com/users/logandillard/repos","events_url":"https://api.github.com/users/logandillard/events{/privacy}","received_events_url":"https://api.github.com/users/logandillard/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-11T19:22:49Z","updated_at":"2016-11-14T19:27:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"992275777c47d281031ddfa88ca94c5aeb1d6391","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/pulls/3/commits","review_comments_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/pulls/3/comments","review_comment_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/issues/3/comments","statuses_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/statuses/b52d17b2cbcd09056ca13a56ff36a8984db82eb7","head":{"label":"convoyinc:logan/sns","ref":"logan/sns","sha":"b52d17b2cbcd09056ca13a56ff36a8984db82eb7","user":{"login":"convoyinc","id":11140206,"avatar_url":"https://avatars.githubusercontent.com/u/11140206?v=3","gravatar_id":"","url":"https://api.github.com/users/convoyinc","html_url":"https://github.com/convoyinc","followers_url":"https://api.github.com/users/convoyinc/followers","following_url":"https://api.github.com/users/convoyinc/following{/other_user}","gists_url":"https://api.github.com/users/convoyinc/gists{/gist_id}","starred_url":"https://api.github.com/users/convoyinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convoyinc/subscriptions","organizations_url":"https://api.github.com/users/convoyinc/orgs","repos_url":"https://api.github.com/users/convoyinc/repos","events_url":"https://api.github.com/users/convoyinc/events{/privacy}","received_events_url":"https://api.github.com/users/convoyinc/received_events","type":"Organization","site_admin":false},"repo":{"id":72069238,"name":"lib-task-scheduler","full_name":"convoyinc/lib-task-scheduler","owner":{"login":"convoyinc","id":11140206,"avatar_url":"https://avatars.githubusercontent.com/u/11140206?v=3","gravatar_id":"","url":"https://api.github.com/users/convoyinc","html_url":"https://github.com/convoyinc","followers_url":"https://api.github.com/users/convoyinc/followers","following_url":"https://api.github.com/users/convoyinc/following{/other_user}","gists_url":"https://api.github.com/users/convoyinc/gists{/gist_id}","starred_url":"https://api.github.com/users/convoyinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convoyinc/subscriptions","organizations_url":"https://api.github.com/users/convoyinc/orgs","repos_url":"https://api.github.com/users/convoyinc/repos","events_url":"https://api.github.com/users/convoyinc/events{/privacy}","received_events_url":"https://api.github.com/users/convoyinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/convoyinc/lib-task-scheduler","description":null,"fork":false,"url":"https://api.github.com/repos/convoyinc/lib-task-scheduler","forks_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/forks","keys_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/teams","hooks_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/hooks","issue_events_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/issues/events{/number}","events_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/events","assignees_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/assignees{/user}","branches_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/branches{/branch}","tags_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/tags","blobs_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/git/refs{/sha}","trees_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/statuses/{sha}","languages_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/languages","stargazers_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/stargazers","contributors_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/contributors","subscribers_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/subscribers","subscription_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/subscription","commits_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/commits{/sha}","git_commits_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/git/commits{/sha}","comments_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/comments{/number}","issue_comment_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/issues/comments{/number}","contents_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/contents/{+path}","compare_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/merges","archive_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/downloads","issues_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/issues{/number}","pulls_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/pulls{/number}","milestones_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/milestones{/number}","notifications_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/labels{/name}","releases_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/releases{/id}","deployments_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/deployments","created_at":"2016-10-27T03:53:57Z","updated_at":"2016-10-27T22:01:17Z","pushed_at":"2016-11-14T18:50:11Z","git_url":"git://github.com/convoyinc/lib-task-scheduler.git","ssh_url":"git@github.com:convoyinc/lib-task-scheduler.git","clone_url":"https://github.com/convoyinc/lib-task-scheduler.git","svn_url":"https://github.com/convoyinc/lib-task-scheduler","homepage":null,"size":1004,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"convoyinc:master","ref":"master","sha":"04cab1cad33103caf8ba2146134bd3cdadec24e5","user":{"login":"convoyinc","id":11140206,"avatar_url":"https://avatars.githubusercontent.com/u/11140206?v=3","gravatar_id":"","url":"https://api.github.com/users/convoyinc","html_url":"https://github.com/convoyinc","followers_url":"https://api.github.com/users/convoyinc/followers","following_url":"https://api.github.com/users/convoyinc/following{/other_user}","gists_url":"https://api.github.com/users/convoyinc/gists{/gist_id}","starred_url":"https://api.github.com/users/convoyinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convoyinc/subscriptions","organizations_url":"https://api.github.com/users/convoyinc/orgs","repos_url":"https://api.github.com/users/convoyinc/repos","events_url":"https://api.github.com/users/convoyinc/events{/privacy}","received_events_url":"https://api.github.com/users/convoyinc/received_events","type":"Organization","site_admin":false},"repo":{"id":72069238,"name":"lib-task-scheduler","full_name":"convoyinc/lib-task-scheduler","owner":{"login":"convoyinc","id":11140206,"avatar_url":"https://avatars.githubusercontent.com/u/11140206?v=3","gravatar_id":"","url":"https://api.github.com/users/convoyinc","html_url":"https://github.com/convoyinc","followers_url":"https://api.github.com/users/convoyinc/followers","following_url":"https://api.github.com/users/convoyinc/following{/other_user}","gists_url":"https://api.github.com/users/convoyinc/gists{/gist_id}","starred_url":"https://api.github.com/users/convoyinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convoyinc/subscriptions","organizations_url":"https://api.github.com/users/convoyinc/orgs","repos_url":"https://api.github.com/users/convoyinc/repos","events_url":"https://api.github.com/users/convoyinc/events{/privacy}","received_events_url":"https://api.github.com/users/convoyinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/convoyinc/lib-task-scheduler","description":null,"fork":false,"url":"https://api.github.com/repos/convoyinc/lib-task-scheduler","forks_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/forks","keys_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/teams","hooks_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/hooks","issue_events_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/issues/events{/number}","events_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/events","assignees_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/assignees{/user}","branches_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/branches{/branch}","tags_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/tags","blobs_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/git/refs{/sha}","trees_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/statuses/{sha}","languages_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/languages","stargazers_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/stargazers","contributors_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/contributors","subscribers_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/subscribers","subscription_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/subscription","commits_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/commits{/sha}","git_commits_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/git/commits{/sha}","comments_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/comments{/number}","issue_comment_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/issues/comments{/number}","contents_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/contents/{+path}","compare_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/merges","archive_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/downloads","issues_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/issues{/number}","pulls_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/pulls{/number}","milestones_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/milestones{/number}","notifications_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/labels{/name}","releases_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/releases{/id}","deployments_url":"https://api.github.com/repos/convoyinc/lib-task-scheduler/deployments","created_at":"2016-10-27T03:53:57Z","updated_at":"2016-10-27T22:01:17Z","pushed_at":"2016-11-14T18:50:11Z","git_url":"git://github.com/convoyinc/lib-task-scheduler.git","ssh_url":"git@github.com:convoyinc/lib-task-scheduler.git","clone_url":"https://github.com/convoyinc/lib-task-scheduler.git","svn_url":"https://github.com/convoyinc/lib-task-scheduler","homepage":null,"size":1004,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/convoyinc/lib-task-scheduler/pulls/3"},"html":{"href":"https://github.com/convoyinc/lib-task-scheduler/pull/3"},"issue":{"href":"https://api.github.com/repos/convoyinc/lib-task-scheduler/issues/3"},"comments":{"href":"https://api.github.com/repos/convoyinc/lib-task-scheduler/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/convoyinc/lib-task-scheduler/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/convoyinc/lib-task-scheduler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/convoyinc/lib-task-scheduler/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/convoyinc/lib-task-scheduler/statuses/b52d17b2cbcd09056ca13a56ff36a8984db82eb7"}}}}
{"actor":{"display_login":"igrayson"}}