{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/69484217","id":69484217,"diff_hunk":"@@ -1580,15 +1576,21 @@ impl FragmentDisplayListBuilding for Fragment {\n             text_color: text_color.to_gfx_color(),\n             orientation: orientation,\n             baseline_origin: baseline_origin,\n-            blur_radius: shadow_blur_radius.unwrap_or(Au(0)),\n+            blur_radius: shadow_blur_radius,\n         }));\n \n         // Create display items for text decorations.\n         let mut text_decorations = self.style()\n                                        .get_inheritedtext()\n                                        ._servo_text_decorations_in_effect;\n-        if shadow_blur_radius.is_some() {\n+        if let Some(shadow) = text_shadow {\n             // If we're painting a shadow, paint the decorations the same color as the shadow.\n+            let color = self.style().resolve_color(shadow.color);\n+            text_decorations.underline = text_decorations.underline.map(|_| color);\n+            text_decorations.overline = text_decorations.overline.map(|_| color);\n+            text_decorations.line_through = text_decorations.line_through.map(|_| color);\n+        } else {\n+            // Otherwise, paint the decorations the same color as the text color.\n             text_decorations.underline = text_decorations.underline.map(|_| text_color);\n             text_decorations.overline = text_decorations.overline.map(|_| text_color);\n             text_decorations.line_through = text_decorations.line_through.map(|_| text_color);","path":"components/layout/display_list_builder.rs","position":116,"original_position":116,"commit_id":"22bf780b18b15e5b96118d5a42cbc06d26d6acd6","original_commit_id":"22bf780b18b15e5b96118d5a42cbc06d26d6acd6","user":{"login":"frewsxcv","id":416575,"avatar_url":"https://avatars.githubusercontent.com/u/416575?v=3","gravatar_id":"","url":"https://api.github.com/users/frewsxcv","html_url":"https://github.com/frewsxcv","followers_url":"https://api.github.com/users/frewsxcv/followers","following_url":"https://api.github.com/users/frewsxcv/following{/other_user}","gists_url":"https://api.github.com/users/frewsxcv/gists{/gist_id}","starred_url":"https://api.github.com/users/frewsxcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frewsxcv/subscriptions","organizations_url":"https://api.github.com/users/frewsxcv/orgs","repos_url":"https://api.github.com/users/frewsxcv/repos","events_url":"https://api.github.com/users/frewsxcv/events{/privacy}","received_events_url":"https://api.github.com/users/frewsxcv/received_events","type":"User","site_admin":false},"body":"Alternatively:\r\n\r\n```rust\r\nlet color = if let Some(shadow) {\r\n    self.style().resolve_color(shadow.color)\r\n} else {\r\n    text_color\r\n};\r\ntext_decorations.underline = text_decorations.underline.map(|_| color);\r\ntext_decorations.overline = text_decorations.overline.map(|_| color);\r\ntext_decorations.line_through = text_decorations.line_through.map(|_| color);\r\n```","created_at":"2016-07-04T18:23:06Z","updated_at":"2016-07-04T18:23:06Z","html_url":"https://github.com/servo/servo/pull/12233#discussion_r69484217","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/12233","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/69484217"},"html":{"href":"https://github.com/servo/servo/pull/12233#discussion_r69484217"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/12233"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/12233","id":76191450,"html_url":"https://github.com/servo/servo/pull/12233","diff_url":"https://github.com/servo/servo/pull/12233.diff","patch_url":"https://github.com/servo/servo/pull/12233.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/12233","number":12233,"state":"open","locked":false,"title":"Make text decorations have the same color as the text if no shadows are present","user":{"login":"KiChjang","id":3248587,"avatar_url":"https://avatars.githubusercontent.com/u/3248587?v=3","gravatar_id":"","url":"https://api.github.com/users/KiChjang","html_url":"https://github.com/KiChjang","followers_url":"https://api.github.com/users/KiChjang/followers","following_url":"https://api.github.com/users/KiChjang/following{/other_user}","gists_url":"https://api.github.com/users/KiChjang/gists{/gist_id}","starred_url":"https://api.github.com/users/KiChjang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiChjang/subscriptions","organizations_url":"https://api.github.com/users/KiChjang/orgs","repos_url":"https://api.github.com/users/KiChjang/repos","events_url":"https://api.github.com/users/KiChjang/events{/privacy}","received_events_url":"https://api.github.com/users/KiChjang/received_events","type":"User","site_admin":false},"body":"<!-- Please describe your changes on the following line: -->\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [x] `./mach build -d` does not report any errors\r\n- [x] `./mach test-tidy` does not report any errors\r\n- [x] These changes fix #11870 (github issue number if applicable).\r\n\r\n<!-- Either: -->\r\n- [ ] There are tests for these changes OR\r\n- [x] These changes do not require tests because according to @SimonSapin, making reftests against underlines are impossible\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/12233)\n<!-- Reviewable:end -->\n","created_at":"2016-07-04T18:09:27Z","updated_at":"2016-07-04T18:23:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea34f17d48bf09e7ed05ffd029f31f84da5db96d","assignee":{"login":"mbrubeck","id":5920,"avatar_url":"https://avatars.githubusercontent.com/u/5920?v=3","gravatar_id":"","url":"https://api.github.com/users/mbrubeck","html_url":"https://github.com/mbrubeck","followers_url":"https://api.github.com/users/mbrubeck/followers","following_url":"https://api.github.com/users/mbrubeck/following{/other_user}","gists_url":"https://api.github.com/users/mbrubeck/gists{/gist_id}","starred_url":"https://api.github.com/users/mbrubeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbrubeck/subscriptions","organizations_url":"https://api.github.com/users/mbrubeck/orgs","repos_url":"https://api.github.com/users/mbrubeck/repos","events_url":"https://api.github.com/users/mbrubeck/events{/privacy}","received_events_url":"https://api.github.com/users/mbrubeck/received_events","type":"User","site_admin":false},"assignees":[{"login":"mbrubeck","id":5920,"avatar_url":"https://avatars.githubusercontent.com/u/5920?v=3","gravatar_id":"","url":"https://api.github.com/users/mbrubeck","html_url":"https://github.com/mbrubeck","followers_url":"https://api.github.com/users/mbrubeck/followers","following_url":"https://api.github.com/users/mbrubeck/following{/other_user}","gists_url":"https://api.github.com/users/mbrubeck/gists{/gist_id}","starred_url":"https://api.github.com/users/mbrubeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbrubeck/subscriptions","organizations_url":"https://api.github.com/users/mbrubeck/orgs","repos_url":"https://api.github.com/users/mbrubeck/repos","events_url":"https://api.github.com/users/mbrubeck/events{/privacy}","received_events_url":"https://api.github.com/users/mbrubeck/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/12233/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/12233/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/12233/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/22bf780b18b15e5b96118d5a42cbc06d26d6acd6","head":{"label":"KiChjang:underline-color","ref":"underline-color","sha":"22bf780b18b15e5b96118d5a42cbc06d26d6acd6","user":{"login":"KiChjang","id":3248587,"avatar_url":"https://avatars.githubusercontent.com/u/3248587?v=3","gravatar_id":"","url":"https://api.github.com/users/KiChjang","html_url":"https://github.com/KiChjang","followers_url":"https://api.github.com/users/KiChjang/followers","following_url":"https://api.github.com/users/KiChjang/following{/other_user}","gists_url":"https://api.github.com/users/KiChjang/gists{/gist_id}","starred_url":"https://api.github.com/users/KiChjang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiChjang/subscriptions","organizations_url":"https://api.github.com/users/KiChjang/orgs","repos_url":"https://api.github.com/users/KiChjang/repos","events_url":"https://api.github.com/users/KiChjang/events{/privacy}","received_events_url":"https://api.github.com/users/KiChjang/received_events","type":"User","site_admin":false},"repo":{"id":30110248,"name":"servo","full_name":"KiChjang/servo","owner":{"login":"KiChjang","id":3248587,"avatar_url":"https://avatars.githubusercontent.com/u/3248587?v=3","gravatar_id":"","url":"https://api.github.com/users/KiChjang","html_url":"https://github.com/KiChjang","followers_url":"https://api.github.com/users/KiChjang/followers","following_url":"https://api.github.com/users/KiChjang/following{/other_user}","gists_url":"https://api.github.com/users/KiChjang/gists{/gist_id}","starred_url":"https://api.github.com/users/KiChjang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiChjang/subscriptions","organizations_url":"https://api.github.com/users/KiChjang/orgs","repos_url":"https://api.github.com/users/KiChjang/repos","events_url":"https://api.github.com/users/KiChjang/events{/privacy}","received_events_url":"https://api.github.com/users/KiChjang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KiChjang/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/KiChjang/servo","forks_url":"https://api.github.com/repos/KiChjang/servo/forks","keys_url":"https://api.github.com/repos/KiChjang/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KiChjang/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KiChjang/servo/teams","hooks_url":"https://api.github.com/repos/KiChjang/servo/hooks","issue_events_url":"https://api.github.com/repos/KiChjang/servo/issues/events{/number}","events_url":"https://api.github.com/repos/KiChjang/servo/events","assignees_url":"https://api.github.com/repos/KiChjang/servo/assignees{/user}","branches_url":"https://api.github.com/repos/KiChjang/servo/branches{/branch}","tags_url":"https://api.github.com/repos/KiChjang/servo/tags","blobs_url":"https://api.github.com/repos/KiChjang/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KiChjang/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KiChjang/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/KiChjang/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KiChjang/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/KiChjang/servo/languages","stargazers_url":"https://api.github.com/repos/KiChjang/servo/stargazers","contributors_url":"https://api.github.com/repos/KiChjang/servo/contributors","subscribers_url":"https://api.github.com/repos/KiChjang/servo/subscribers","subscription_url":"https://api.github.com/repos/KiChjang/servo/subscription","commits_url":"https://api.github.com/repos/KiChjang/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/KiChjang/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/KiChjang/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/KiChjang/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/KiChjang/servo/contents/{+path}","compare_url":"https://api.github.com/repos/KiChjang/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KiChjang/servo/merges","archive_url":"https://api.github.com/repos/KiChjang/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KiChjang/servo/downloads","issues_url":"https://api.github.com/repos/KiChjang/servo/issues{/number}","pulls_url":"https://api.github.com/repos/KiChjang/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/KiChjang/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/KiChjang/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KiChjang/servo/labels{/name}","releases_url":"https://api.github.com/repos/KiChjang/servo/releases{/id}","deployments_url":"https://api.github.com/repos/KiChjang/servo/deployments","created_at":"2015-01-31T11:19:01Z","updated_at":"2016-01-11T11:18:01Z","pushed_at":"2016-07-04T18:08:17Z","git_url":"git://github.com/KiChjang/servo.git","ssh_url":"git@github.com:KiChjang/servo.git","clone_url":"https://github.com/KiChjang/servo.git","svn_url":"https://github.com/KiChjang/servo","homepage":"","size":193114,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"36974f0746261b971c93ed7dfb9bd726675ccf69","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2016-07-04T18:19:28Z","pushed_at":"2016-07-04T18:18:09Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":266777,"stargazers_count":7331,"watchers_count":7331,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1178,"mirror_url":null,"open_issues_count":1602,"forks":1178,"open_issues":1602,"watchers":7331,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/12233"},"html":{"href":"https://github.com/servo/servo/pull/12233"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/12233"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/12233/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/12233/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/12233/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/22bf780b18b15e5b96118d5a42cbc06d26d6acd6"}}}}
{"actor":{"display_login":"frewsxcv"}}