{"action":"created","issue":{"url":"https://api.github.com/repos/solidusio/solidus/issues/1602","repository_url":"https://api.github.com/repos/solidusio/solidus","labels_url":"https://api.github.com/repos/solidusio/solidus/issues/1602/labels{/name}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/1602/comments","events_url":"https://api.github.com/repos/solidusio/solidus/issues/1602/events","html_url":"https://github.com/solidusio/solidus/pull/1602","id":190953178,"number":1602,"title":"calling remove_from when promotion is not eligible","user":{"login":"flyfy1","id":1553760,"avatar_url":"https://avatars.githubusercontent.com/u/1553760?v=3","gravatar_id":"","url":"https://api.github.com/users/flyfy1","html_url":"https://github.com/flyfy1","followers_url":"https://api.github.com/users/flyfy1/followers","following_url":"https://api.github.com/users/flyfy1/following{/other_user}","gists_url":"https://api.github.com/users/flyfy1/gists{/gist_id}","starred_url":"https://api.github.com/users/flyfy1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flyfy1/subscriptions","organizations_url":"https://api.github.com/users/flyfy1/orgs","repos_url":"https://api.github.com/users/flyfy1/repos","events_url":"https://api.github.com/users/flyfy1/events{/privacy}","received_events_url":"https://api.github.com/users/flyfy1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-22T09:55:26Z","updated_at":"2016-11-25T12:38:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/1602","html_url":"https://github.com/solidusio/solidus/pull/1602","diff_url":"https://github.com/solidusio/solidus/pull/1602.diff","patch_url":"https://github.com/solidusio/solidus/pull/1602.patch"},"body":"This is a proof-of-concept work. Currently, although `Promotion#remove_from` is defined, and properly defined & tested in the different `PromotionActions`.. but it's not called.\r\n\r\nBased on my understanding, the place where a promotion should be removed, are the PromotionHandlers (pls correct me if I'm wrong). Therefore, I'm putting this proof-of-concept code to ask if `remove_from` can be called this way.\r\n\r\nIf can, then other PromotionHandlers would be updated in similar ways."},"comment":{"url":"https://api.github.com/repos/solidusio/solidus/issues/comments/262949779","html_url":"https://github.com/solidusio/solidus/pull/1602#issuecomment-262949779","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/1602","id":262949779,"user":{"login":"cbrunsdon","id":279013,"avatar_url":"https://avatars.githubusercontent.com/u/279013?v=3","gravatar_id":"","url":"https://api.github.com/users/cbrunsdon","html_url":"https://github.com/cbrunsdon","followers_url":"https://api.github.com/users/cbrunsdon/followers","following_url":"https://api.github.com/users/cbrunsdon/following{/other_user}","gists_url":"https://api.github.com/users/cbrunsdon/gists{/gist_id}","starred_url":"https://api.github.com/users/cbrunsdon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbrunsdon/subscriptions","organizations_url":"https://api.github.com/users/cbrunsdon/orgs","repos_url":"https://api.github.com/users/cbrunsdon/repos","events_url":"https://api.github.com/users/cbrunsdon/events{/privacy}","received_events_url":"https://api.github.com/users/cbrunsdon/received_events","type":"User","site_admin":false},"created_at":"2016-11-25T12:38:58Z","updated_at":"2016-11-25T12:38:58Z","body":"I think the idea with how this code currently functions is it will maintain all promotions on an order, but only use the one that provided the greatest savings.\r\n\r\nThe idea being, if I added one coupon code for \"$10 off\" and another for \"10% off\", at some point in time the 10% off will become more valuable and that should be that one thats used (which is why we I believe we don't remove promos from an order).\r\n\r\nI'm not saying I agree that should be the default behavior, but its why any changes like this are going to be pretty serious discussions as it will be changing default behavior in a pretty subtle way, but something many people are quite likely counting on."}}
{"actor":{"display_login":"cbrunsdon"}}