{"action":"created","comment":{"url":"https://api.github.com/repos/eslint/generator-eslint/pulls/comments/73900871","id":73900871,"diff_hunk":"@@ -8,28 +8,37 @@\n // Rule Definition\n //------------------------------------------------------------------------------\n \n-module.exports = function(context) {\n+module.exports = {\n+    meta: {\n+        docs: {\n+            description: \"<%= desc %>\",\n+            category: \"Fill me in\",\n+            recommended: false\n+        },\n+        fixable: null,  // or \"code\" or \"whitespace\"\n+        schema: [\n+            // fill in your schema\n+        ]\n+    },\n \n-    // variables should be defined here\n+    create: function(context) {\n \n-    //--------------------------------------------------------------------------\n-    // Helpers\n-    //--------------------------------------------------------------------------\n+        // variables should be defined here\n \n-    // any helper functions should go here or else delete this section\n+        //----------------------------------------------------------------------\n+        // Helpers\n+        //----------------------------------------------------------------------","path":"rule/templates/_rule.js","position":29,"original_position":29,"commit_id":"28aa87efec95ff18023de330e1a3a33b2040ef12","original_commit_id":"28aa87efec95ff18023de330e1a3a33b2040ef12","user":{"login":"vitorbal","id":626038,"avatar_url":"https://avatars.githubusercontent.com/u/626038?v=3","gravatar_id":"","url":"https://api.github.com/users/vitorbal","html_url":"https://github.com/vitorbal","followers_url":"https://api.github.com/users/vitorbal/followers","following_url":"https://api.github.com/users/vitorbal/following{/other_user}","gists_url":"https://api.github.com/users/vitorbal/gists{/gist_id}","starred_url":"https://api.github.com/users/vitorbal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitorbal/subscriptions","organizations_url":"https://api.github.com/users/vitorbal/orgs","repos_url":"https://api.github.com/users/vitorbal/repos","events_url":"https://api.github.com/users/vitorbal/events{/privacy}","received_events_url":"https://api.github.com/users/vitorbal/received_events","type":"User","site_admin":false},"body":"OK! In that case, LGTM :)","created_at":"2016-08-08T15:52:05Z","updated_at":"2016-08-08T15:52:05Z","html_url":"https://github.com/eslint/generator-eslint/pull/41#discussion_r73900871","pull_request_url":"https://api.github.com/repos/eslint/generator-eslint/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/eslint/generator-eslint/pulls/comments/73900871"},"html":{"href":"https://github.com/eslint/generator-eslint/pull/41#discussion_r73900871"},"pull_request":{"href":"https://api.github.com/repos/eslint/generator-eslint/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/eslint/generator-eslint/pulls/41","id":80345848,"html_url":"https://github.com/eslint/generator-eslint/pull/41","diff_url":"https://github.com/eslint/generator-eslint/pull/41.diff","patch_url":"https://github.com/eslint/generator-eslint/pull/41.patch","issue_url":"https://api.github.com/repos/eslint/generator-eslint/issues/41","number":41,"state":"open","locked":false,"title":"Update: Rule generator uses new rule format (fixes #36)","user":{"login":"platinumazure","id":284282,"avatar_url":"https://avatars.githubusercontent.com/u/284282?v=3","gravatar_id":"","url":"https://api.github.com/users/platinumazure","html_url":"https://github.com/platinumazure","followers_url":"https://api.github.com/users/platinumazure/followers","following_url":"https://api.github.com/users/platinumazure/following{/other_user}","gists_url":"https://api.github.com/users/platinumazure/gists{/gist_id}","starred_url":"https://api.github.com/users/platinumazure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/platinumazure/subscriptions","organizations_url":"https://api.github.com/users/platinumazure/orgs","repos_url":"https://api.github.com/users/platinumazure/repos","events_url":"https://api.github.com/users/platinumazure/events{/privacy}","received_events_url":"https://api.github.com/users/platinumazure/received_events","type":"User","site_admin":false},"body":"**What issue does this pull request address?**\r\nFixes #36.\r\n\r\n**What changes did you make? (Give an overview)**\r\nChanged the structure of the _rule.js template to conform to ESLint's new rule format.\r\n\r\n**Is there anything you'd like reviewers to focus on?**\r\nI did run eslint on the generated file and everything looks good (it at least parses), but it would be good to get a second set of eyes on it. You can use `npm link` to link the branch to a global pseudo-install of generator-eslint, and then `yo eslint:rule` lets you run the new code.\r\n\r\nAlso, should I write any new tests for this?","created_at":"2016-08-06T17:25:16Z","updated_at":"2016-08-08T15:52:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"137ddfc9dea2240a8e6ed2e192443df9ec0645c1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eslint/generator-eslint/pulls/41/commits","review_comments_url":"https://api.github.com/repos/eslint/generator-eslint/pulls/41/comments","review_comment_url":"https://api.github.com/repos/eslint/generator-eslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eslint/generator-eslint/issues/41/comments","statuses_url":"https://api.github.com/repos/eslint/generator-eslint/statuses/28aa87efec95ff18023de330e1a3a33b2040ef12","head":{"label":"eslint:new-rule-format","ref":"new-rule-format","sha":"28aa87efec95ff18023de330e1a3a33b2040ef12","user":{"login":"eslint","id":6019716,"avatar_url":"https://avatars.githubusercontent.com/u/6019716?v=3","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"repo":{"id":16241464,"name":"generator-eslint","full_name":"eslint/generator-eslint","owner":{"login":"eslint","id":6019716,"avatar_url":"https://avatars.githubusercontent.com/u/6019716?v=3","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eslint/generator-eslint","description":"A Yeoman generator to help with ESLint development","fork":false,"url":"https://api.github.com/repos/eslint/generator-eslint","forks_url":"https://api.github.com/repos/eslint/generator-eslint/forks","keys_url":"https://api.github.com/repos/eslint/generator-eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eslint/generator-eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eslint/generator-eslint/teams","hooks_url":"https://api.github.com/repos/eslint/generator-eslint/hooks","issue_events_url":"https://api.github.com/repos/eslint/generator-eslint/issues/events{/number}","events_url":"https://api.github.com/repos/eslint/generator-eslint/events","assignees_url":"https://api.github.com/repos/eslint/generator-eslint/assignees{/user}","branches_url":"https://api.github.com/repos/eslint/generator-eslint/branches{/branch}","tags_url":"https://api.github.com/repos/eslint/generator-eslint/tags","blobs_url":"https://api.github.com/repos/eslint/generator-eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eslint/generator-eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eslint/generator-eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/eslint/generator-eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eslint/generator-eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/eslint/generator-eslint/languages","stargazers_url":"https://api.github.com/repos/eslint/generator-eslint/stargazers","contributors_url":"https://api.github.com/repos/eslint/generator-eslint/contributors","subscribers_url":"https://api.github.com/repos/eslint/generator-eslint/subscribers","subscription_url":"https://api.github.com/repos/eslint/generator-eslint/subscription","commits_url":"https://api.github.com/repos/eslint/generator-eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/eslint/generator-eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/eslint/generator-eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/eslint/generator-eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/eslint/generator-eslint/contents/{+path}","compare_url":"https://api.github.com/repos/eslint/generator-eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eslint/generator-eslint/merges","archive_url":"https://api.github.com/repos/eslint/generator-eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eslint/generator-eslint/downloads","issues_url":"https://api.github.com/repos/eslint/generator-eslint/issues{/number}","pulls_url":"https://api.github.com/repos/eslint/generator-eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/eslint/generator-eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/eslint/generator-eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eslint/generator-eslint/labels{/name}","releases_url":"https://api.github.com/repos/eslint/generator-eslint/releases{/id}","deployments_url":"https://api.github.com/repos/eslint/generator-eslint/deployments","created_at":"2014-01-25T22:24:39Z","updated_at":"2016-07-30T16:06:50Z","pushed_at":"2016-08-08T15:35:16Z","git_url":"git://github.com/eslint/generator-eslint.git","ssh_url":"git@github.com:eslint/generator-eslint.git","clone_url":"https://github.com/eslint/generator-eslint.git","svn_url":"https://github.com/eslint/generator-eslint","homepage":null,"size":52,"stargazers_count":37,"watchers_count":37,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":5,"forks":11,"open_issues":5,"watchers":37,"default_branch":"master"}},"base":{"label":"eslint:master","ref":"master","sha":"314f47a7f360c433ca8bf98d3397867cfc83ce6e","user":{"login":"eslint","id":6019716,"avatar_url":"https://avatars.githubusercontent.com/u/6019716?v=3","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"repo":{"id":16241464,"name":"generator-eslint","full_name":"eslint/generator-eslint","owner":{"login":"eslint","id":6019716,"avatar_url":"https://avatars.githubusercontent.com/u/6019716?v=3","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eslint/generator-eslint","description":"A Yeoman generator to help with ESLint development","fork":false,"url":"https://api.github.com/repos/eslint/generator-eslint","forks_url":"https://api.github.com/repos/eslint/generator-eslint/forks","keys_url":"https://api.github.com/repos/eslint/generator-eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eslint/generator-eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eslint/generator-eslint/teams","hooks_url":"https://api.github.com/repos/eslint/generator-eslint/hooks","issue_events_url":"https://api.github.com/repos/eslint/generator-eslint/issues/events{/number}","events_url":"https://api.github.com/repos/eslint/generator-eslint/events","assignees_url":"https://api.github.com/repos/eslint/generator-eslint/assignees{/user}","branches_url":"https://api.github.com/repos/eslint/generator-eslint/branches{/branch}","tags_url":"https://api.github.com/repos/eslint/generator-eslint/tags","blobs_url":"https://api.github.com/repos/eslint/generator-eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eslint/generator-eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eslint/generator-eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/eslint/generator-eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eslint/generator-eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/eslint/generator-eslint/languages","stargazers_url":"https://api.github.com/repos/eslint/generator-eslint/stargazers","contributors_url":"https://api.github.com/repos/eslint/generator-eslint/contributors","subscribers_url":"https://api.github.com/repos/eslint/generator-eslint/subscribers","subscription_url":"https://api.github.com/repos/eslint/generator-eslint/subscription","commits_url":"https://api.github.com/repos/eslint/generator-eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/eslint/generator-eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/eslint/generator-eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/eslint/generator-eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/eslint/generator-eslint/contents/{+path}","compare_url":"https://api.github.com/repos/eslint/generator-eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eslint/generator-eslint/merges","archive_url":"https://api.github.com/repos/eslint/generator-eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eslint/generator-eslint/downloads","issues_url":"https://api.github.com/repos/eslint/generator-eslint/issues{/number}","pulls_url":"https://api.github.com/repos/eslint/generator-eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/eslint/generator-eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/eslint/generator-eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eslint/generator-eslint/labels{/name}","releases_url":"https://api.github.com/repos/eslint/generator-eslint/releases{/id}","deployments_url":"https://api.github.com/repos/eslint/generator-eslint/deployments","created_at":"2014-01-25T22:24:39Z","updated_at":"2016-07-30T16:06:50Z","pushed_at":"2016-08-08T15:35:16Z","git_url":"git://github.com/eslint/generator-eslint.git","ssh_url":"git@github.com:eslint/generator-eslint.git","clone_url":"https://github.com/eslint/generator-eslint.git","svn_url":"https://github.com/eslint/generator-eslint","homepage":null,"size":52,"stargazers_count":37,"watchers_count":37,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":5,"forks":11,"open_issues":5,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eslint/generator-eslint/pulls/41"},"html":{"href":"https://github.com/eslint/generator-eslint/pull/41"},"issue":{"href":"https://api.github.com/repos/eslint/generator-eslint/issues/41"},"comments":{"href":"https://api.github.com/repos/eslint/generator-eslint/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/eslint/generator-eslint/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/eslint/generator-eslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eslint/generator-eslint/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/eslint/generator-eslint/statuses/28aa87efec95ff18023de330e1a3a33b2040ef12"}}}}
{"actor":{"display_login":"vitorbal"}}