{"action":"opened","number":985,"pull_request":{"url":"https://api.github.com/repos/NewSpring/Holtzmann/pulls/985","id":84981357,"html_url":"https://github.com/NewSpring/Holtzmann/pull/985","diff_url":"https://github.com/NewSpring/Holtzmann/pull/985.diff","patch_url":"https://github.com/NewSpring/Holtzmann/pull/985.patch","issue_url":"https://api.github.com/repos/NewSpring/Holtzmann/issues/985","number":985,"state":"open","locked":false,"title":"[WIP] Smooth Scroll","user":{"login":"johnthepink","id":816517,"avatar_url":"https://avatars.githubusercontent.com/u/816517?v=3","gravatar_id":"","url":"https://api.github.com/users/johnthepink","html_url":"https://github.com/johnthepink","followers_url":"https://api.github.com/users/johnthepink/followers","following_url":"https://api.github.com/users/johnthepink/following{/other_user}","gists_url":"https://api.github.com/users/johnthepink/gists{/gist_id}","starred_url":"https://api.github.com/users/johnthepink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnthepink/subscriptions","organizations_url":"https://api.github.com/users/johnthepink/orgs","repos_url":"https://api.github.com/users/johnthepink/repos","events_url":"https://api.github.com/users/johnthepink/events{/privacy}","received_events_url":"https://api.github.com/users/johnthepink/received_events","type":"User","site_admin":false},"body":"Concerning #619 \r\n\r\nI've been playing with this, if anyone has any thoughts please chime in.\r\n\r\nThis enables the smooth native-like scrolling in the app, which causes a lot of style havoc. Most are probably fixable, but I think the most difficult one is this breaks our pull-to-refresh mechanism and our header.\r\n\r\nThis is because the container element has to be:\r\n\r\n```css\r\n.somecontainer {\r\n  position: absolute;\r\n  height: 100%;\r\n  overflow-y: scroll;\r\n  -webkit-overflow-scrolling: touch;\r\n}\r\n```\r\n\r\nIt seems like this may be a lot easier if we were okay with locking the header at the top of the app. The last time I tried turning this back on, we didn't have the header at all. So it was easy enough to position the spinner absolutely and make it work. Now we have this:\r\n\r\n<img width=\"311\" alt=\"screenshot 2016-09-12 23 44 54\" src=\"https://cloud.githubusercontent.com/assets/816517/18460853/091e7000-7943-11e6-894d-614d9e07a944.png\">\r\n\r\nAll that to say, I don't think this is going to be an easy fix, but I will keep playing with it. ","created_at":"2016-09-13T03:48:27Z","updated_at":"2016-09-13T03:48:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"068ab949efd27b81b80120bd5ae2e7912de95550","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NewSpring/Holtzmann/pulls/985/commits","review_comments_url":"https://api.github.com/repos/NewSpring/Holtzmann/pulls/985/comments","review_comment_url":"https://api.github.com/repos/NewSpring/Holtzmann/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NewSpring/Holtzmann/issues/985/comments","statuses_url":"https://api.github.com/repos/NewSpring/Holtzmann/statuses/4a8160d7cfcf8a34ee3086343a5b7375fc86b932","head":{"label":"NewSpring:smooth-scroll","ref":"smooth-scroll","sha":"4a8160d7cfcf8a34ee3086343a5b7375fc86b932","user":{"login":"NewSpring","id":1241964,"avatar_url":"https://avatars.githubusercontent.com/u/1241964?v=3","gravatar_id":"","url":"https://api.github.com/users/NewSpring","html_url":"https://github.com/NewSpring","followers_url":"https://api.github.com/users/NewSpring/followers","following_url":"https://api.github.com/users/NewSpring/following{/other_user}","gists_url":"https://api.github.com/users/NewSpring/gists{/gist_id}","starred_url":"https://api.github.com/users/NewSpring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NewSpring/subscriptions","organizations_url":"https://api.github.com/users/NewSpring/orgs","repos_url":"https://api.github.com/users/NewSpring/repos","events_url":"https://api.github.com/users/NewSpring/events{/privacy}","received_events_url":"https://api.github.com/users/NewSpring/received_events","type":"Organization","site_admin":false},"repo":{"id":31171598,"name":"Holtzmann","full_name":"NewSpring/Holtzmann","owner":{"login":"NewSpring","id":1241964,"avatar_url":"https://avatars.githubusercontent.com/u/1241964?v=3","gravatar_id":"","url":"https://api.github.com/users/NewSpring","html_url":"https://github.com/NewSpring","followers_url":"https://api.github.com/users/NewSpring/followers","following_url":"https://api.github.com/users/NewSpring/following{/other_user}","gists_url":"https://api.github.com/users/NewSpring/gists{/gist_id}","starred_url":"https://api.github.com/users/NewSpring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NewSpring/subscriptions","organizations_url":"https://api.github.com/users/NewSpring/orgs","repos_url":"https://api.github.com/users/NewSpring/repos","events_url":"https://api.github.com/users/NewSpring/events{/privacy}","received_events_url":"https://api.github.com/users/NewSpring/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NewSpring/Holtzmann","description":"The main NewSpring namespace and utilities for all newspring packages. ","fork":false,"url":"https://api.github.com/repos/NewSpring/Holtzmann","forks_url":"https://api.github.com/repos/NewSpring/Holtzmann/forks","keys_url":"https://api.github.com/repos/NewSpring/Holtzmann/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NewSpring/Holtzmann/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NewSpring/Holtzmann/teams","hooks_url":"https://api.github.com/repos/NewSpring/Holtzmann/hooks","issue_events_url":"https://api.github.com/repos/NewSpring/Holtzmann/issues/events{/number}","events_url":"https://api.github.com/repos/NewSpring/Holtzmann/events","assignees_url":"https://api.github.com/repos/NewSpring/Holtzmann/assignees{/user}","branches_url":"https://api.github.com/repos/NewSpring/Holtzmann/branches{/branch}","tags_url":"https://api.github.com/repos/NewSpring/Holtzmann/tags","blobs_url":"https://api.github.com/repos/NewSpring/Holtzmann/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NewSpring/Holtzmann/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NewSpring/Holtzmann/git/refs{/sha}","trees_url":"https://api.github.com/repos/NewSpring/Holtzmann/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NewSpring/Holtzmann/statuses/{sha}","languages_url":"https://api.github.com/repos/NewSpring/Holtzmann/languages","stargazers_url":"https://api.github.com/repos/NewSpring/Holtzmann/stargazers","contributors_url":"https://api.github.com/repos/NewSpring/Holtzmann/contributors","subscribers_url":"https://api.github.com/repos/NewSpring/Holtzmann/subscribers","subscription_url":"https://api.github.com/repos/NewSpring/Holtzmann/subscription","commits_url":"https://api.github.com/repos/NewSpring/Holtzmann/commits{/sha}","git_commits_url":"https://api.github.com/repos/NewSpring/Holtzmann/git/commits{/sha}","comments_url":"https://api.github.com/repos/NewSpring/Holtzmann/comments{/number}","issue_comment_url":"https://api.github.com/repos/NewSpring/Holtzmann/issues/comments{/number}","contents_url":"https://api.github.com/repos/NewSpring/Holtzmann/contents/{+path}","compare_url":"https://api.github.com/repos/NewSpring/Holtzmann/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NewSpring/Holtzmann/merges","archive_url":"https://api.github.com/repos/NewSpring/Holtzmann/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NewSpring/Holtzmann/downloads","issues_url":"https://api.github.com/repos/NewSpring/Holtzmann/issues{/number}","pulls_url":"https://api.github.com/repos/NewSpring/Holtzmann/pulls{/number}","milestones_url":"https://api.github.com/repos/NewSpring/Holtzmann/milestones{/number}","notifications_url":"https://api.github.com/repos/NewSpring/Holtzmann/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NewSpring/Holtzmann/labels{/name}","releases_url":"https://api.github.com/repos/NewSpring/Holtzmann/releases{/id}","deployments_url":"https://api.github.com/repos/NewSpring/Holtzmann/deployments","created_at":"2015-02-22T17:27:05Z","updated_at":"2016-09-12T21:39:46Z","pushed_at":"2016-09-13T03:48:27Z","git_url":"git://github.com/NewSpring/Holtzmann.git","ssh_url":"git@github.com:NewSpring/Holtzmann.git","clone_url":"https://github.com/NewSpring/Holtzmann.git","svn_url":"https://github.com/NewSpring/Holtzmann","homepage":"","size":22700,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":94,"forks":3,"open_issues":94,"watchers":9,"default_branch":"master"}},"base":{"label":"NewSpring:master","ref":"master","sha":"50b2a9315d01e8fe212265f25f0e2d58eca012ae","user":{"login":"NewSpring","id":1241964,"avatar_url":"https://avatars.githubusercontent.com/u/1241964?v=3","gravatar_id":"","url":"https://api.github.com/users/NewSpring","html_url":"https://github.com/NewSpring","followers_url":"https://api.github.com/users/NewSpring/followers","following_url":"https://api.github.com/users/NewSpring/following{/other_user}","gists_url":"https://api.github.com/users/NewSpring/gists{/gist_id}","starred_url":"https://api.github.com/users/NewSpring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NewSpring/subscriptions","organizations_url":"https://api.github.com/users/NewSpring/orgs","repos_url":"https://api.github.com/users/NewSpring/repos","events_url":"https://api.github.com/users/NewSpring/events{/privacy}","received_events_url":"https://api.github.com/users/NewSpring/received_events","type":"Organization","site_admin":false},"repo":{"id":31171598,"name":"Holtzmann","full_name":"NewSpring/Holtzmann","owner":{"login":"NewSpring","id":1241964,"avatar_url":"https://avatars.githubusercontent.com/u/1241964?v=3","gravatar_id":"","url":"https://api.github.com/users/NewSpring","html_url":"https://github.com/NewSpring","followers_url":"https://api.github.com/users/NewSpring/followers","following_url":"https://api.github.com/users/NewSpring/following{/other_user}","gists_url":"https://api.github.com/users/NewSpring/gists{/gist_id}","starred_url":"https://api.github.com/users/NewSpring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NewSpring/subscriptions","organizations_url":"https://api.github.com/users/NewSpring/orgs","repos_url":"https://api.github.com/users/NewSpring/repos","events_url":"https://api.github.com/users/NewSpring/events{/privacy}","received_events_url":"https://api.github.com/users/NewSpring/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NewSpring/Holtzmann","description":"The main NewSpring namespace and utilities for all newspring packages. ","fork":false,"url":"https://api.github.com/repos/NewSpring/Holtzmann","forks_url":"https://api.github.com/repos/NewSpring/Holtzmann/forks","keys_url":"https://api.github.com/repos/NewSpring/Holtzmann/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NewSpring/Holtzmann/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NewSpring/Holtzmann/teams","hooks_url":"https://api.github.com/repos/NewSpring/Holtzmann/hooks","issue_events_url":"https://api.github.com/repos/NewSpring/Holtzmann/issues/events{/number}","events_url":"https://api.github.com/repos/NewSpring/Holtzmann/events","assignees_url":"https://api.github.com/repos/NewSpring/Holtzmann/assignees{/user}","branches_url":"https://api.github.com/repos/NewSpring/Holtzmann/branches{/branch}","tags_url":"https://api.github.com/repos/NewSpring/Holtzmann/tags","blobs_url":"https://api.github.com/repos/NewSpring/Holtzmann/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NewSpring/Holtzmann/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NewSpring/Holtzmann/git/refs{/sha}","trees_url":"https://api.github.com/repos/NewSpring/Holtzmann/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NewSpring/Holtzmann/statuses/{sha}","languages_url":"https://api.github.com/repos/NewSpring/Holtzmann/languages","stargazers_url":"https://api.github.com/repos/NewSpring/Holtzmann/stargazers","contributors_url":"https://api.github.com/repos/NewSpring/Holtzmann/contributors","subscribers_url":"https://api.github.com/repos/NewSpring/Holtzmann/subscribers","subscription_url":"https://api.github.com/repos/NewSpring/Holtzmann/subscription","commits_url":"https://api.github.com/repos/NewSpring/Holtzmann/commits{/sha}","git_commits_url":"https://api.github.com/repos/NewSpring/Holtzmann/git/commits{/sha}","comments_url":"https://api.github.com/repos/NewSpring/Holtzmann/comments{/number}","issue_comment_url":"https://api.github.com/repos/NewSpring/Holtzmann/issues/comments{/number}","contents_url":"https://api.github.com/repos/NewSpring/Holtzmann/contents/{+path}","compare_url":"https://api.github.com/repos/NewSpring/Holtzmann/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NewSpring/Holtzmann/merges","archive_url":"https://api.github.com/repos/NewSpring/Holtzmann/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NewSpring/Holtzmann/downloads","issues_url":"https://api.github.com/repos/NewSpring/Holtzmann/issues{/number}","pulls_url":"https://api.github.com/repos/NewSpring/Holtzmann/pulls{/number}","milestones_url":"https://api.github.com/repos/NewSpring/Holtzmann/milestones{/number}","notifications_url":"https://api.github.com/repos/NewSpring/Holtzmann/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NewSpring/Holtzmann/labels{/name}","releases_url":"https://api.github.com/repos/NewSpring/Holtzmann/releases{/id}","deployments_url":"https://api.github.com/repos/NewSpring/Holtzmann/deployments","created_at":"2015-02-22T17:27:05Z","updated_at":"2016-09-12T21:39:46Z","pushed_at":"2016-09-13T03:48:27Z","git_url":"git://github.com/NewSpring/Holtzmann.git","ssh_url":"git@github.com:NewSpring/Holtzmann.git","clone_url":"https://github.com/NewSpring/Holtzmann.git","svn_url":"https://github.com/NewSpring/Holtzmann","homepage":"","size":22700,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":94,"forks":3,"open_issues":94,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NewSpring/Holtzmann/pulls/985"},"html":{"href":"https://github.com/NewSpring/Holtzmann/pull/985"},"issue":{"href":"https://api.github.com/repos/NewSpring/Holtzmann/issues/985"},"comments":{"href":"https://api.github.com/repos/NewSpring/Holtzmann/issues/985/comments"},"review_comments":{"href":"https://api.github.com/repos/NewSpring/Holtzmann/pulls/985/comments"},"review_comment":{"href":"https://api.github.com/repos/NewSpring/Holtzmann/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NewSpring/Holtzmann/pulls/985/commits"},"statuses":{"href":"https://api.github.com/repos/NewSpring/Holtzmann/statuses/4a8160d7cfcf8a34ee3086343a5b7375fc86b932"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"johnthepink"}}