{"action":"created","issue":{"url":"https://api.github.com/repos/thebergamo/k7-sequelize/issues/6","repository_url":"https://api.github.com/repos/thebergamo/k7-sequelize","labels_url":"https://api.github.com/repos/thebergamo/k7-sequelize/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/thebergamo/k7-sequelize/issues/6/comments","events_url":"https://api.github.com/repos/thebergamo/k7-sequelize/issues/6/events","html_url":"https://github.com/thebergamo/k7-sequelize/pull/6","id":195767648,"number":6,"title":"Fixed done callback in load()","user":{"login":"vitoravelino","id":188554,"avatar_url":"https://avatars.githubusercontent.com/u/188554?v=3","gravatar_id":"","url":"https://api.github.com/users/vitoravelino","html_url":"https://github.com/vitoravelino","followers_url":"https://api.github.com/users/vitoravelino/followers","following_url":"https://api.github.com/users/vitoravelino/following{/other_user}","gists_url":"https://api.github.com/users/vitoravelino/gists{/gist_id}","starred_url":"https://api.github.com/users/vitoravelino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitoravelino/subscriptions","organizations_url":"https://api.github.com/users/vitoravelino/orgs","repos_url":"https://api.github.com/users/vitoravelino/repos","events_url":"https://api.github.com/users/vitoravelino/events{/privacy}","received_events_url":"https://api.github.com/users/vitoravelino/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-15T10:22:26Z","updated_at":"2016-12-15T11:52:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/thebergamo/k7-sequelize/pulls/6","html_url":"https://github.com/thebergamo/k7-sequelize/pull/6","diff_url":"https://github.com/thebergamo/k7-sequelize/pull/6.diff","patch_url":"https://github.com/thebergamo/k7-sequelize/pull/6.patch"},"body":"The `load()` function wasn't calling the `done` callback in the end and the k7 Loader wasn't being able to attach the db to hapi server instance.\r\n\r\nWill require a patch version bump if accepted."},"comment":{"url":"https://api.github.com/repos/thebergamo/k7-sequelize/issues/comments/267310031","html_url":"https://github.com/thebergamo/k7-sequelize/pull/6#issuecomment-267310031","issue_url":"https://api.github.com/repos/thebergamo/k7-sequelize/issues/6","id":267310031,"user":{"login":"thebergamo","id":1778730,"avatar_url":"https://avatars.githubusercontent.com/u/1778730?v=3","gravatar_id":"","url":"https://api.github.com/users/thebergamo","html_url":"https://github.com/thebergamo","followers_url":"https://api.github.com/users/thebergamo/followers","following_url":"https://api.github.com/users/thebergamo/following{/other_user}","gists_url":"https://api.github.com/users/thebergamo/gists{/gist_id}","starred_url":"https://api.github.com/users/thebergamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thebergamo/subscriptions","organizations_url":"https://api.github.com/users/thebergamo/orgs","repos_url":"https://api.github.com/users/thebergamo/repos","events_url":"https://api.github.com/users/thebergamo/events{/privacy}","received_events_url":"https://api.github.com/users/thebergamo/received_events","type":"User","site_admin":false},"created_at":"2016-12-15T11:52:55Z","updated_at":"2016-12-15T11:52:55Z","body":"Thanks very much for your contribuition @vitoravelino ;)\r\n\r\nLet's look inside the PR.\r\n\r\nI guess, your commit is to be compatible with the k7 1.5 right? In this case, is very wanted keep the idea behind the v1.5 of k7, the idea is keep all the things asynchronous, maybe a better disclaimer in the k7 module is required to explain this thing.\r\n\r\n If you can make the `getModels` async like the function in the [k7-mongoose](https://github.com/thebergamo/k7-mongoose) I'm more confident to accept de PR. what you think?\r\nSome improves in the tests are very welcomed too."}}
{"actor":{"display_login":"thebergamo"}}