{"action":"created","issue":{"url":"https://api.github.com/repos/farkam135/GoIV/issues/131","repository_url":"https://api.github.com/repos/farkam135/GoIV","labels_url":"https://api.github.com/repos/farkam135/GoIV/issues/131/labels{/name}","comments_url":"https://api.github.com/repos/farkam135/GoIV/issues/131/comments","events_url":"https://api.github.com/repos/farkam135/GoIV/issues/131/events","html_url":"https://github.com/farkam135/GoIV/pull/131","id":172418000,"number":131,"title":"Fix candy name based Pokemon search","user":{"login":"sarav","id":247061,"avatar_url":"https://avatars.githubusercontent.com/u/247061?v=3","gravatar_id":"","url":"https://api.github.com/users/sarav","html_url":"https://github.com/sarav","followers_url":"https://api.github.com/users/sarav/followers","following_url":"https://api.github.com/users/sarav/following{/other_user}","gists_url":"https://api.github.com/users/sarav/gists{/gist_id}","starred_url":"https://api.github.com/users/sarav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarav/subscriptions","organizations_url":"https://api.github.com/users/sarav/orgs","repos_url":"https://api.github.com/users/sarav/repos","events_url":"https://api.github.com/users/sarav/events{/privacy}","received_events_url":"https://api.github.com/users/sarav/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":29,"created_at":"2016-08-22T10:25:41Z","updated_at":"2016-08-24T16:46:05Z","closed_at":"2016-08-23T03:45:18Z","pull_request":{"url":"https://api.github.com/repos/farkam135/GoIV/pulls/131","html_url":"https://github.com/farkam135/GoIV/pull/131","diff_url":"https://github.com/farkam135/GoIV/pull/131.diff","patch_url":"https://github.com/farkam135/GoIV/pull/131.patch"},"body":"If the pokemon name match isn't good, we can't just pick the pokemon\r\nname that matches the candy name perfectly. If the candy name was\r\ndetected perfectly, then we'll always end up picking the base pokemon.\r\n\r\nInstead, we use the candy name to limit the list of pokemon names we\r\nhave to check for similarity. Also, if the candy name is not detected\r\nperfectly, we have to approximately check only 1/3 of the pokemon names\r\nfor similarity with the candy name instead of the whole pokedex.\r\n\r\nOnce we figure out the base pokemon with the best candy name match, we\r\ngo through all the pokemon with that candy name and see how well they\r\nmatch with the detected pokemon name."},"comment":{"url":"https://api.github.com/repos/farkam135/GoIV/issues/comments/242132361","html_url":"https://github.com/farkam135/GoIV/pull/131#issuecomment-242132361","issue_url":"https://api.github.com/repos/farkam135/GoIV/issues/131","id":242132361,"user":{"login":"Blaisorblade","id":289960,"avatar_url":"https://avatars.githubusercontent.com/u/289960?v=3","gravatar_id":"","url":"https://api.github.com/users/Blaisorblade","html_url":"https://github.com/Blaisorblade","followers_url":"https://api.github.com/users/Blaisorblade/followers","following_url":"https://api.github.com/users/Blaisorblade/following{/other_user}","gists_url":"https://api.github.com/users/Blaisorblade/gists{/gist_id}","starred_url":"https://api.github.com/users/Blaisorblade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blaisorblade/subscriptions","organizations_url":"https://api.github.com/users/Blaisorblade/orgs","repos_url":"https://api.github.com/users/Blaisorblade/repos","events_url":"https://api.github.com/users/Blaisorblade/events{/privacy}","received_events_url":"https://api.github.com/users/Blaisorblade/received_events","type":"User","site_admin":false},"created_at":"2016-08-24T16:46:05Z","updated_at":"2016-08-24T16:46:05Z","body":"I haven't seen coding standards around—I started https://github.com/farkam135/GoIV/blob/master/DEVELOPMENT.md. The only thing not mentioned is \"hey, there's this Discord chatroom where devs hang out\", the one linked on our Reddit (https://discord.gg/y6BvF5D0).\r\n\r\nRe Git: even if reviewing enforced standards on all PRs, `git log --pretty=oneline 2.1.0..2.2.0` has 130 entries and many make sense for devs but not for users (and some msgs could be better, yes).  Though maybe that could be a starting point for a manual changelog.\r\n\r\nAnyway, these are the options, it's not up to me to pick what matters most."}}
{"actor":{"display_login":"Blaisorblade"}}