{"action":"created","comment":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/84924777","pull_request_review_id":5650770,"id":84924777,"diff_hunk":"@@ -45,22 +45,22 @@ builder.storeAsBinary().enable();\n \n ===== Equality Considerations\n \n-When using lazy deserialization/storing as binary, keys and values are wrapped as link:http://docs.jboss.org/infinispan/{infinispanversion}/apidocs/org/infinispan/marshall/core/MarshalledValue[MarshalledValue]s.\n-It is this wrapper class that transparently takes care of serialization and deserialization on demand, and internally may have a reference to the object itself being wrapped, or the serialized, byte array representation of this object. \n+When using lazy deserialization/storing as binary, keys and values are wrapped as link:{javadocroot}/org/infinispan/marshall/core/MarshalledValue[MarshalledValue]s.\n+It is this wrapper class that transparently takes care of serialization and deserialization on demand, and internally may have a reference to the object itself being wrapped, or the serialized, byte array representation of this object.\n \n This has a particular effect on the behavior of equality.\n The equals() method of this class will either compare binary representations (byte arrays) or delegate to the wrapped object instance's equals() method, depending on whether both instances being compared are in serialized or deserialized form at the time of comparison.\n If one of the instances being compared is in one form and the other in another form, then one instance is either serialized or deserialized.\n-The preference will be to compare object representations, unless the cache is link:http://docs.jboss.org/infinispan/{infinispanversion}/apidocs/org/infinispan/Cache.html#compact()[compacted], in which case byte array comparison is favored.\n+The preference will be to compare object representations, unless the cache is link:{javadocroot}/org/infinispan/Cache.html#compact()[compacted], in which case byte array comparison is favored.","path":"documentation/src/main/asciidoc/user_guide/marshalling.adoc","position":30,"original_position":30,"commit_id":"83f0cf12235e7e180ab29e7895cc2b247b83dac5","original_commit_id":"c4f18b450e95bd9511e43c14ee9797c9662ca44c","user":{"login":"danberindei","id":504907,"avatar_url":"https://avatars.githubusercontent.com/u/504907?v=3","gravatar_id":"","url":"https://api.github.com/users/danberindei","html_url":"https://github.com/danberindei","followers_url":"https://api.github.com/users/danberindei/followers","following_url":"https://api.github.com/users/danberindei/following{/other_user}","gists_url":"https://api.github.com/users/danberindei/gists{/gist_id}","starred_url":"https://api.github.com/users/danberindei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danberindei/subscriptions","organizations_url":"https://api.github.com/users/danberindei/orgs","repos_url":"https://api.github.com/users/danberindei/repos","events_url":"https://api.github.com/users/danberindei/events{/privacy}","received_events_url":"https://api.github.com/users/danberindei/received_events","type":"User","site_admin":false},"body":"Old-style javadoc link","created_at":"2016-10-25T15:07:15Z","updated_at":"2016-10-25T15:13:12Z","html_url":"https://github.com/infinispan/infinispan/pull/4622#discussion_r84924777","pull_request_url":"https://api.github.com/repos/infinispan/infinispan/pulls/4622","_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/84924777"},"html":{"href":"https://github.com/infinispan/infinispan/pull/4622#discussion_r84924777"},"pull_request":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/4622"}}},"pull_request":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/4622","id":89971620,"html_url":"https://github.com/infinispan/infinispan/pull/4622","diff_url":"https://github.com/infinispan/infinispan/pull/4622.diff","patch_url":"https://github.com/infinispan/infinispan/pull/4622.patch","issue_url":"https://api.github.com/repos/infinispan/infinispan/issues/4622","number":4622,"state":"open","locked":false,"title":"Documentation fixes","user":{"login":"tristantarrant","id":392478,"avatar_url":"https://avatars.githubusercontent.com/u/392478?v=3","gravatar_id":"","url":"https://api.github.com/users/tristantarrant","html_url":"https://github.com/tristantarrant","followers_url":"https://api.github.com/users/tristantarrant/followers","following_url":"https://api.github.com/users/tristantarrant/following{/other_user}","gists_url":"https://api.github.com/users/tristantarrant/gists{/gist_id}","starred_url":"https://api.github.com/users/tristantarrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tristantarrant/subscriptions","organizations_url":"https://api.github.com/users/tristantarrant/orgs","repos_url":"https://api.github.com/users/tristantarrant/repos","events_url":"https://api.github.com/users/tristantarrant/events{/privacy}","received_events_url":"https://api.github.com/users/tristantarrant/received_events","type":"User","site_admin":false},"body":"This PR contains two parts:\r\n* replaces all links to JavaDocs and WildFly docs using a parameterized prefix\r\n* splits and rearranges the server guide and adds some more details about the JMX connector","created_at":"2016-10-19T09:26:08Z","updated_at":"2016-10-25T15:13:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f490a005032a63a5ca7fbe2e6cfd37f5c1f04d4b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/infinispan/infinispan/pulls/4622/commits","review_comments_url":"https://api.github.com/repos/infinispan/infinispan/pulls/4622/comments","review_comment_url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infinispan/infinispan/issues/4622/comments","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/83f0cf12235e7e180ab29e7895cc2b247b83dac5","head":{"label":"tristantarrant:jmx_docs","ref":"jmx_docs","sha":"83f0cf12235e7e180ab29e7895cc2b247b83dac5","user":{"login":"tristantarrant","id":392478,"avatar_url":"https://avatars.githubusercontent.com/u/392478?v=3","gravatar_id":"","url":"https://api.github.com/users/tristantarrant","html_url":"https://github.com/tristantarrant","followers_url":"https://api.github.com/users/tristantarrant/followers","following_url":"https://api.github.com/users/tristantarrant/following{/other_user}","gists_url":"https://api.github.com/users/tristantarrant/gists{/gist_id}","starred_url":"https://api.github.com/users/tristantarrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tristantarrant/subscriptions","organizations_url":"https://api.github.com/users/tristantarrant/orgs","repos_url":"https://api.github.com/users/tristantarrant/repos","events_url":"https://api.github.com/users/tristantarrant/events{/privacy}","received_events_url":"https://api.github.com/users/tristantarrant/received_events","type":"User","site_admin":false},"repo":{"id":2035565,"name":"infinispan","full_name":"tristantarrant/infinispan","owner":{"login":"tristantarrant","id":392478,"avatar_url":"https://avatars.githubusercontent.com/u/392478?v=3","gravatar_id":"","url":"https://api.github.com/users/tristantarrant","html_url":"https://github.com/tristantarrant","followers_url":"https://api.github.com/users/tristantarrant/followers","following_url":"https://api.github.com/users/tristantarrant/following{/other_user}","gists_url":"https://api.github.com/users/tristantarrant/gists{/gist_id}","starred_url":"https://api.github.com/users/tristantarrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tristantarrant/subscriptions","organizations_url":"https://api.github.com/users/tristantarrant/orgs","repos_url":"https://api.github.com/users/tristantarrant/repos","events_url":"https://api.github.com/users/tristantarrant/events{/privacy}","received_events_url":"https://api.github.com/users/tristantarrant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tristantarrant/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":true,"url":"https://api.github.com/repos/tristantarrant/infinispan","forks_url":"https://api.github.com/repos/tristantarrant/infinispan/forks","keys_url":"https://api.github.com/repos/tristantarrant/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tristantarrant/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tristantarrant/infinispan/teams","hooks_url":"https://api.github.com/repos/tristantarrant/infinispan/hooks","issue_events_url":"https://api.github.com/repos/tristantarrant/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/tristantarrant/infinispan/events","assignees_url":"https://api.github.com/repos/tristantarrant/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/tristantarrant/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/tristantarrant/infinispan/tags","blobs_url":"https://api.github.com/repos/tristantarrant/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tristantarrant/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tristantarrant/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/tristantarrant/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tristantarrant/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/tristantarrant/infinispan/languages","stargazers_url":"https://api.github.com/repos/tristantarrant/infinispan/stargazers","contributors_url":"https://api.github.com/repos/tristantarrant/infinispan/contributors","subscribers_url":"https://api.github.com/repos/tristantarrant/infinispan/subscribers","subscription_url":"https://api.github.com/repos/tristantarrant/infinispan/subscription","commits_url":"https://api.github.com/repos/tristantarrant/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/tristantarrant/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/tristantarrant/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/tristantarrant/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/tristantarrant/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/tristantarrant/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tristantarrant/infinispan/merges","archive_url":"https://api.github.com/repos/tristantarrant/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tristantarrant/infinispan/downloads","issues_url":"https://api.github.com/repos/tristantarrant/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/tristantarrant/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/tristantarrant/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/tristantarrant/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tristantarrant/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/tristantarrant/infinispan/releases{/id}","deployments_url":"https://api.github.com/repos/tristantarrant/infinispan/deployments","created_at":"2011-07-12T10:59:18Z","updated_at":"2014-06-25T09:10:17Z","pushed_at":"2016-10-25T10:18:59Z","git_url":"git://github.com/tristantarrant/infinispan.git","ssh_url":"git@github.com:tristantarrant/infinispan.git","clone_url":"https://github.com/tristantarrant/infinispan.git","svn_url":"https://github.com/tristantarrant/infinispan","homepage":"http://www.infinispan.org","size":79821,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"infinispan:master","ref":"master","sha":"06d33c118b87f5f1c2f83c80addbda172b3b2ac7","user":{"login":"infinispan","id":458093,"avatar_url":"https://avatars.githubusercontent.com/u/458093?v=3","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"repo":{"id":1050944,"name":"infinispan","full_name":"infinispan/infinispan","owner":{"login":"infinispan","id":458093,"avatar_url":"https://avatars.githubusercontent.com/u/458093?v=3","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/infinispan/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":false,"url":"https://api.github.com/repos/infinispan/infinispan","forks_url":"https://api.github.com/repos/infinispan/infinispan/forks","keys_url":"https://api.github.com/repos/infinispan/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infinispan/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infinispan/infinispan/teams","hooks_url":"https://api.github.com/repos/infinispan/infinispan/hooks","issue_events_url":"https://api.github.com/repos/infinispan/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/infinispan/infinispan/events","assignees_url":"https://api.github.com/repos/infinispan/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/infinispan/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/infinispan/infinispan/tags","blobs_url":"https://api.github.com/repos/infinispan/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infinispan/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infinispan/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/infinispan/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/infinispan/infinispan/languages","stargazers_url":"https://api.github.com/repos/infinispan/infinispan/stargazers","contributors_url":"https://api.github.com/repos/infinispan/infinispan/contributors","subscribers_url":"https://api.github.com/repos/infinispan/infinispan/subscribers","subscription_url":"https://api.github.com/repos/infinispan/infinispan/subscription","commits_url":"https://api.github.com/repos/infinispan/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/infinispan/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/infinispan/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/infinispan/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/infinispan/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/infinispan/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infinispan/infinispan/merges","archive_url":"https://api.github.com/repos/infinispan/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infinispan/infinispan/downloads","issues_url":"https://api.github.com/repos/infinispan/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/infinispan/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/infinispan/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/infinispan/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infinispan/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/infinispan/infinispan/releases{/id}","deployments_url":"https://api.github.com/repos/infinispan/infinispan/deployments","created_at":"2010-11-04T12:33:19Z","updated_at":"2016-10-24T22:55:38Z","pushed_at":"2016-10-25T15:01:59Z","git_url":"git://github.com/infinispan/infinispan.git","ssh_url":"git@github.com:infinispan/infinispan.git","clone_url":"https://github.com/infinispan/infinispan.git","svn_url":"https://github.com/infinispan/infinispan","homepage":"http://www.infinispan.org","size":105789,"stargazers_count":498,"watchers_count":498,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":367,"mirror_url":null,"open_issues_count":27,"forks":367,"open_issues":27,"watchers":498,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/4622"},"html":{"href":"https://github.com/infinispan/infinispan/pull/4622"},"issue":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/4622"},"comments":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/4622/comments"},"review_comments":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/4622/comments"},"review_comment":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/4622/commits"},"statuses":{"href":"https://api.github.com/repos/infinispan/infinispan/statuses/83f0cf12235e7e180ab29e7895cc2b247b83dac5"}}}}
{"actor":{"display_login":"danberindei"}}