{"action":"closed","number":51,"pull_request":{"url":"https://api.github.com/repos/nir0s/ld/pulls/51","id":58492760,"html_url":"https://github.com/nir0s/ld/pull/51","diff_url":"https://github.com/nir0s/ld/pull/51.diff","patch_url":"https://github.com/nir0s/ld/pull/51.patch","issue_url":"https://api.github.com/repos/nir0s/ld/issues/51","number":51,"state":"closed","locked":false,"title":"Fixes #36: Unreliable id() and meaning of base().","user":{"login":"andy-maier","id":8939758,"avatar_url":"https://avatars.githubusercontent.com/u/8939758?v=3","gravatar_id":"","url":"https://api.github.com/users/andy-maier","html_url":"https://github.com/andy-maier","followers_url":"https://api.github.com/users/andy-maier/followers","following_url":"https://api.github.com/users/andy-maier/following{/other_user}","gists_url":"https://api.github.com/users/andy-maier/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-maier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-maier/subscriptions","organizations_url":"https://api.github.com/users/andy-maier/orgs","repos_url":"https://api.github.com/users/andy-maier/repos","events_url":"https://api.github.com/users/andy-maier/events{/privacy}","received_events_url":"https://api.github.com/users/andy-maier/received_events","type":"User","site_admin":false},"body":"This PR fixes issue #36: Unreliable id() and meaning of base().\r\nPlease review and merge.\r\nIn addition to what the commit message says, I have also updated the docstrings for those methods that had to do with the change.\r\n\r\nDetails from the commit message:\r\n- Added support for a reliable distro ID returned by `id()`.\r\n  The normalization happens only for `id()`; the `*_release_info()` and\r\n  `get_*_release_attr()` methods do not provide a reliable ID; these\r\n  methods provide the values as obtained from the respective sources.\r\n- The set of distros for which the ID is reliable has been initially\r\n  taken from the `_DIST_TO_BASE` dict. A TODO has been added to make\r\n  sure we review that list.\r\n- These reliable distros are documented with their ID values in the\r\n  description of the `id()` method.\r\n- Removed the `base()` method and, because it was no longer used, its\r\n  `_DIST_TO_BASE` dict.\r\n- Adjusted testcases and standalone query script to the changed behavior\r\n  of the `id()` method.\r\n- Documented a TODO in the `TestOverall` test class for those distros that\r\n  have reliable IDs, but have no testcase representation so far.\r\n- Changed the mocking concept for the `TestLSBRelease` class to also use\r\n  the concept from `DistroTestCase`. This became necessary because the\r\n  previous mocking concept was making assumptions about the\r\n  implementation that were no longer met. As part of that, the LSB\r\n  output files in the \"special\" directory became simple `lsb_release`\r\n  scripts that print a hard coded set of lines, in the \"testdistros\"\r\n  directory.","created_at":"2016-02-05T22:21:25Z","updated_at":"2016-03-02T08:50:03Z","closed_at":"2016-03-02T08:50:03Z","merged_at":"2016-03-02T08:50:03Z","merge_commit_sha":"606c09bc4f0dca155de3efb80c34896a672ac38d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nir0s/ld/pulls/51/commits","review_comments_url":"https://api.github.com/repos/nir0s/ld/pulls/51/comments","review_comment_url":"https://api.github.com/repos/nir0s/ld/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nir0s/ld/issues/51/comments","statuses_url":"https://api.github.com/repos/nir0s/ld/statuses/309612b2fb1f683789230179f49d5a38347cffef","head":{"label":"andy-maier:reliableid","ref":"reliableid","sha":"309612b2fb1f683789230179f49d5a38347cffef","user":{"login":"andy-maier","id":8939758,"avatar_url":"https://avatars.githubusercontent.com/u/8939758?v=3","gravatar_id":"","url":"https://api.github.com/users/andy-maier","html_url":"https://github.com/andy-maier","followers_url":"https://api.github.com/users/andy-maier/followers","following_url":"https://api.github.com/users/andy-maier/following{/other_user}","gists_url":"https://api.github.com/users/andy-maier/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-maier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-maier/subscriptions","organizations_url":"https://api.github.com/users/andy-maier/orgs","repos_url":"https://api.github.com/users/andy-maier/repos","events_url":"https://api.github.com/users/andy-maier/events{/privacy}","received_events_url":"https://api.github.com/users/andy-maier/received_events","type":"User","site_admin":false},"repo":{"id":48998446,"name":"ld","full_name":"andy-maier/ld","owner":{"login":"andy-maier","id":8939758,"avatar_url":"https://avatars.githubusercontent.com/u/8939758?v=3","gravatar_id":"","url":"https://api.github.com/users/andy-maier","html_url":"https://github.com/andy-maier","followers_url":"https://api.github.com/users/andy-maier/followers","following_url":"https://api.github.com/users/andy-maier/following{/other_user}","gists_url":"https://api.github.com/users/andy-maier/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-maier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-maier/subscriptions","organizations_url":"https://api.github.com/users/andy-maier/orgs","repos_url":"https://api.github.com/users/andy-maier/repos","events_url":"https://api.github.com/users/andy-maier/events{/privacy}","received_events_url":"https://api.github.com/users/andy-maier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andy-maier/ld","description":"A much more elaborate renewed alternative implementation for Python's platform.linux_distribution()","fork":true,"url":"https://api.github.com/repos/andy-maier/ld","forks_url":"https://api.github.com/repos/andy-maier/ld/forks","keys_url":"https://api.github.com/repos/andy-maier/ld/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andy-maier/ld/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andy-maier/ld/teams","hooks_url":"https://api.github.com/repos/andy-maier/ld/hooks","issue_events_url":"https://api.github.com/repos/andy-maier/ld/issues/events{/number}","events_url":"https://api.github.com/repos/andy-maier/ld/events","assignees_url":"https://api.github.com/repos/andy-maier/ld/assignees{/user}","branches_url":"https://api.github.com/repos/andy-maier/ld/branches{/branch}","tags_url":"https://api.github.com/repos/andy-maier/ld/tags","blobs_url":"https://api.github.com/repos/andy-maier/ld/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andy-maier/ld/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andy-maier/ld/git/refs{/sha}","trees_url":"https://api.github.com/repos/andy-maier/ld/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andy-maier/ld/statuses/{sha}","languages_url":"https://api.github.com/repos/andy-maier/ld/languages","stargazers_url":"https://api.github.com/repos/andy-maier/ld/stargazers","contributors_url":"https://api.github.com/repos/andy-maier/ld/contributors","subscribers_url":"https://api.github.com/repos/andy-maier/ld/subscribers","subscription_url":"https://api.github.com/repos/andy-maier/ld/subscription","commits_url":"https://api.github.com/repos/andy-maier/ld/commits{/sha}","git_commits_url":"https://api.github.com/repos/andy-maier/ld/git/commits{/sha}","comments_url":"https://api.github.com/repos/andy-maier/ld/comments{/number}","issue_comment_url":"https://api.github.com/repos/andy-maier/ld/issues/comments{/number}","contents_url":"https://api.github.com/repos/andy-maier/ld/contents/{+path}","compare_url":"https://api.github.com/repos/andy-maier/ld/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andy-maier/ld/merges","archive_url":"https://api.github.com/repos/andy-maier/ld/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andy-maier/ld/downloads","issues_url":"https://api.github.com/repos/andy-maier/ld/issues{/number}","pulls_url":"https://api.github.com/repos/andy-maier/ld/pulls{/number}","milestones_url":"https://api.github.com/repos/andy-maier/ld/milestones{/number}","notifications_url":"https://api.github.com/repos/andy-maier/ld/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andy-maier/ld/labels{/name}","releases_url":"https://api.github.com/repos/andy-maier/ld/releases{/id}","deployments_url":"https://api.github.com/repos/andy-maier/ld/deployments","created_at":"2016-01-04T13:23:56Z","updated_at":"2016-01-11T08:59:42Z","pushed_at":"2016-03-02T07:01:31Z","git_url":"git://github.com/andy-maier/ld.git","ssh_url":"git@github.com:andy-maier/ld.git","clone_url":"https://github.com/andy-maier/ld.git","svn_url":"https://github.com/andy-maier/ld","homepage":"","size":91,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nir0s:master","ref":"master","sha":"127e9e7bdc2e20187a8b5d934935a855115b6d59","user":{"login":"nir0s","id":2003076,"avatar_url":"https://avatars.githubusercontent.com/u/2003076?v=3","gravatar_id":"","url":"https://api.github.com/users/nir0s","html_url":"https://github.com/nir0s","followers_url":"https://api.github.com/users/nir0s/followers","following_url":"https://api.github.com/users/nir0s/following{/other_user}","gists_url":"https://api.github.com/users/nir0s/gists{/gist_id}","starred_url":"https://api.github.com/users/nir0s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nir0s/subscriptions","organizations_url":"https://api.github.com/users/nir0s/orgs","repos_url":"https://api.github.com/users/nir0s/repos","events_url":"https://api.github.com/users/nir0s/events{/privacy}","received_events_url":"https://api.github.com/users/nir0s/received_events","type":"User","site_admin":false},"repo":{"id":47115470,"name":"ld","full_name":"nir0s/ld","owner":{"login":"nir0s","id":2003076,"avatar_url":"https://avatars.githubusercontent.com/u/2003076?v=3","gravatar_id":"","url":"https://api.github.com/users/nir0s","html_url":"https://github.com/nir0s","followers_url":"https://api.github.com/users/nir0s/followers","following_url":"https://api.github.com/users/nir0s/following{/other_user}","gists_url":"https://api.github.com/users/nir0s/gists{/gist_id}","starred_url":"https://api.github.com/users/nir0s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nir0s/subscriptions","organizations_url":"https://api.github.com/users/nir0s/orgs","repos_url":"https://api.github.com/users/nir0s/repos","events_url":"https://api.github.com/users/nir0s/events{/privacy}","received_events_url":"https://api.github.com/users/nir0s/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nir0s/ld","description":"A much more elaborate renewed alternative implementation for Python's platform.linux_distribution()","fork":false,"url":"https://api.github.com/repos/nir0s/ld","forks_url":"https://api.github.com/repos/nir0s/ld/forks","keys_url":"https://api.github.com/repos/nir0s/ld/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nir0s/ld/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nir0s/ld/teams","hooks_url":"https://api.github.com/repos/nir0s/ld/hooks","issue_events_url":"https://api.github.com/repos/nir0s/ld/issues/events{/number}","events_url":"https://api.github.com/repos/nir0s/ld/events","assignees_url":"https://api.github.com/repos/nir0s/ld/assignees{/user}","branches_url":"https://api.github.com/repos/nir0s/ld/branches{/branch}","tags_url":"https://api.github.com/repos/nir0s/ld/tags","blobs_url":"https://api.github.com/repos/nir0s/ld/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nir0s/ld/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nir0s/ld/git/refs{/sha}","trees_url":"https://api.github.com/repos/nir0s/ld/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nir0s/ld/statuses/{sha}","languages_url":"https://api.github.com/repos/nir0s/ld/languages","stargazers_url":"https://api.github.com/repos/nir0s/ld/stargazers","contributors_url":"https://api.github.com/repos/nir0s/ld/contributors","subscribers_url":"https://api.github.com/repos/nir0s/ld/subscribers","subscription_url":"https://api.github.com/repos/nir0s/ld/subscription","commits_url":"https://api.github.com/repos/nir0s/ld/commits{/sha}","git_commits_url":"https://api.github.com/repos/nir0s/ld/git/commits{/sha}","comments_url":"https://api.github.com/repos/nir0s/ld/comments{/number}","issue_comment_url":"https://api.github.com/repos/nir0s/ld/issues/comments{/number}","contents_url":"https://api.github.com/repos/nir0s/ld/contents/{+path}","compare_url":"https://api.github.com/repos/nir0s/ld/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nir0s/ld/merges","archive_url":"https://api.github.com/repos/nir0s/ld/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nir0s/ld/downloads","issues_url":"https://api.github.com/repos/nir0s/ld/issues{/number}","pulls_url":"https://api.github.com/repos/nir0s/ld/pulls{/number}","milestones_url":"https://api.github.com/repos/nir0s/ld/milestones{/number}","notifications_url":"https://api.github.com/repos/nir0s/ld/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nir0s/ld/labels{/name}","releases_url":"https://api.github.com/repos/nir0s/ld/releases{/id}","deployments_url":"https://api.github.com/repos/nir0s/ld/deployments","created_at":"2015-11-30T11:58:01Z","updated_at":"2016-02-18T21:15:00Z","pushed_at":"2016-03-02T08:50:03Z","git_url":"git://github.com/nir0s/ld.git","ssh_url":"git@github.com:nir0s/ld.git","clone_url":"https://github.com/nir0s/ld.git","svn_url":"https://github.com/nir0s/ld","homepage":"","size":70,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":8,"forks":1,"open_issues":8,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nir0s/ld/pulls/51"},"html":{"href":"https://github.com/nir0s/ld/pull/51"},"issue":{"href":"https://api.github.com/repos/nir0s/ld/issues/51"},"comments":{"href":"https://api.github.com/repos/nir0s/ld/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/nir0s/ld/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/nir0s/ld/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nir0s/ld/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/nir0s/ld/statuses/309612b2fb1f683789230179f49d5a38347cffef"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"andy-maier","id":8939758,"avatar_url":"https://avatars.githubusercontent.com/u/8939758?v=3","gravatar_id":"","url":"https://api.github.com/users/andy-maier","html_url":"https://github.com/andy-maier","followers_url":"https://api.github.com/users/andy-maier/followers","following_url":"https://api.github.com/users/andy-maier/following{/other_user}","gists_url":"https://api.github.com/users/andy-maier/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-maier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-maier/subscriptions","organizations_url":"https://api.github.com/users/andy-maier/orgs","repos_url":"https://api.github.com/users/andy-maier/repos","events_url":"https://api.github.com/users/andy-maier/events{/privacy}","received_events_url":"https://api.github.com/users/andy-maier/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":261,"deletions":183,"changed_files":8}}