{"action":"opened","number":25015,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25015","id":68477404,"html_url":"https://github.com/kubernetes/kubernetes/pull/25015","diff_url":"https://github.com/kubernetes/kubernetes/pull/25015.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/25015.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25015","number":25015,"state":"open","locked":false,"title":"Add support for managing ELB attributes with service nnotations","user":{"login":"krancour","id":1821014,"avatar_url":"https://avatars.githubusercontent.com/u/1821014?v=3","gravatar_id":"","url":"https://api.github.com/users/krancour","html_url":"https://github.com/krancour","followers_url":"https://api.github.com/users/krancour/followers","following_url":"https://api.github.com/users/krancour/following{/other_user}","gists_url":"https://api.github.com/users/krancour/gists{/gist_id}","starred_url":"https://api.github.com/users/krancour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krancour/subscriptions","organizations_url":"https://api.github.com/users/krancour/orgs","repos_url":"https://api.github.com/users/krancour/repos","events_url":"https://api.github.com/users/krancour/events{/privacy}","received_events_url":"https://api.github.com/users/krancour/received_events","type":"User","site_admin":false},"body":"I noticed recently that there is existing (but undocumented) precedent for the AWS cloud provider to manage ELB-specifc load balancer configuration based on service annotations.  In particular, one can _already_ designate an ELB as \"internal\" using the `service.beta.kubernetes.io/aws-load-balancer-internal: \"true\"` annotation.\r\n\r\nThis PR extends this capability to the management of ELB attributes, which includes the following items:\r\n* Access logs:\r\n    * Enabled / disabled\r\n    * Emit interval\r\n    * S3 bucket name\r\n    * S3 bucket prefix\r\n* Connection draining:\r\n    * Enabled / disabled\r\n    * Timeout\r\n* Connection:\r\n    * Idle timeout\r\n* Cross-zone load balancing:\r\n    * Enabled / disabled\r\n\r\nSome of these are possibly more useful than others.  Use cases that immediately come to mind:\r\n\r\n* Enabling cross-zone load balancing is potentially useful for \"Ubernetes Light,\" or anyone otherwise attempting to spread worker nodes around multiple AZs.\r\n* Increasing idle timeout is useful for the benefit of anyone dealing with long-running requests. An example I personally care about would be git pushes to Deis' builder component.","created_at":"2016-04-30T19:59:29Z","updated_at":"2016-04-30T19:59:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25015/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25015/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25015/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/9eaa46fd41cc376a22e1972032644a8bdbaed751","head":{"label":"krancour:manage-elb-attributes","ref":"manage-elb-attributes","sha":"9eaa46fd41cc376a22e1972032644a8bdbaed751","user":{"login":"krancour","id":1821014,"avatar_url":"https://avatars.githubusercontent.com/u/1821014?v=3","gravatar_id":"","url":"https://api.github.com/users/krancour","html_url":"https://github.com/krancour","followers_url":"https://api.github.com/users/krancour/followers","following_url":"https://api.github.com/users/krancour/following{/other_user}","gists_url":"https://api.github.com/users/krancour/gists{/gist_id}","starred_url":"https://api.github.com/users/krancour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krancour/subscriptions","organizations_url":"https://api.github.com/users/krancour/orgs","repos_url":"https://api.github.com/users/krancour/repos","events_url":"https://api.github.com/users/krancour/events{/privacy}","received_events_url":"https://api.github.com/users/krancour/received_events","type":"User","site_admin":false},"repo":{"id":45628443,"name":"kubernetes","full_name":"krancour/kubernetes","owner":{"login":"krancour","id":1821014,"avatar_url":"https://avatars.githubusercontent.com/u/1821014?v=3","gravatar_id":"","url":"https://api.github.com/users/krancour","html_url":"https://github.com/krancour","followers_url":"https://api.github.com/users/krancour/followers","following_url":"https://api.github.com/users/krancour/following{/other_user}","gists_url":"https://api.github.com/users/krancour/gists{/gist_id}","starred_url":"https://api.github.com/users/krancour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krancour/subscriptions","organizations_url":"https://api.github.com/users/krancour/orgs","repos_url":"https://api.github.com/users/krancour/repos","events_url":"https://api.github.com/users/krancour/events{/privacy}","received_events_url":"https://api.github.com/users/krancour/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krancour/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/krancour/kubernetes","forks_url":"https://api.github.com/repos/krancour/kubernetes/forks","keys_url":"https://api.github.com/repos/krancour/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krancour/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krancour/kubernetes/teams","hooks_url":"https://api.github.com/repos/krancour/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/krancour/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/krancour/kubernetes/events","assignees_url":"https://api.github.com/repos/krancour/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/krancour/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/krancour/kubernetes/tags","blobs_url":"https://api.github.com/repos/krancour/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krancour/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krancour/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/krancour/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krancour/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/krancour/kubernetes/languages","stargazers_url":"https://api.github.com/repos/krancour/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/krancour/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/krancour/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/krancour/kubernetes/subscription","commits_url":"https://api.github.com/repos/krancour/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/krancour/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/krancour/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/krancour/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/krancour/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/krancour/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krancour/kubernetes/merges","archive_url":"https://api.github.com/repos/krancour/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krancour/kubernetes/downloads","issues_url":"https://api.github.com/repos/krancour/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/krancour/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/krancour/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/krancour/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krancour/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/krancour/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/krancour/kubernetes/deployments","created_at":"2015-11-05T17:41:34Z","updated_at":"2016-04-30T19:46:50Z","pushed_at":"2016-04-30T19:47:14Z","git_url":"git://github.com/krancour/kubernetes.git","ssh_url":"git@github.com:krancour/kubernetes.git","clone_url":"https://github.com/krancour/kubernetes.git","svn_url":"https://github.com/krancour/kubernetes","homepage":"http://kubernetes.io","size":187044,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"b930d58fcb5ba6496153d81f0f046434288d2a16","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-04-30T18:36:22Z","pushed_at":"2016-04-30T19:19:38Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":389095,"stargazers_count":14154,"watchers_count":14154,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4222,"mirror_url":null,"open_issues_count":3527,"forks":4222,"open_issues":3527,"watchers":14154,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25015"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/25015"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/25015"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/25015/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25015/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25015/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/9eaa46fd41cc376a22e1972032644a8bdbaed751"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":147,"deletions":2,"changed_files":3}}