{"action":"closed","number":35,"pull_request":{"url":"https://api.github.com/repos/cournape/zipfile2/pulls/35","id":63780949,"html_url":"https://github.com/cournape/zipfile2/pull/35","diff_url":"https://github.com/cournape/zipfile2/pull/35.diff","patch_url":"https://github.com/cournape/zipfile2/pull/35.patch","issue_url":"https://api.github.com/repos/cournape/zipfile2/issues/35","number":35,"state":"closed","locked":false,"title":"BUG: fix softlink detection when extracting a zipfile.","user":{"login":"cournape","id":25111,"avatar_url":"https://avatars.githubusercontent.com/u/25111?v=3","gravatar_id":"","url":"https://api.github.com/users/cournape","html_url":"https://github.com/cournape","followers_url":"https://api.github.com/users/cournape/followers","following_url":"https://api.github.com/users/cournape/following{/other_user}","gists_url":"https://api.github.com/users/cournape/gists{/gist_id}","starred_url":"https://api.github.com/users/cournape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cournape/subscriptions","organizations_url":"https://api.github.com/users/cournape/orgs","repos_url":"https://api.github.com/users/cournape/repos","events_url":"https://api.github.com/users/cournape/events{/privacy}","received_events_url":"https://api.github.com/users/cournape/received_events","type":"User","site_admin":false},"body":"Before this change, we would only detect as symlink an archive  marked as symlink and with permissions set to `0o0755`. While not a big deal for our eggs (since we hardcode every symlink to that value in the buildsystem), it prevented correct exctraction of zipfiles created w/ e.g. `zipfile -y ...`.","created_at":"2016-03-22T19:43:58Z","updated_at":"2016-03-22T20:36:43Z","closed_at":"2016-03-22T20:36:43Z","merged_at":"2016-03-22T20:36:43Z","merge_commit_sha":"64400d0f4dd6803a593f916abcc54bf0aeb62b44","assignee":null,"milestone":{"url":"https://api.github.com/repos/cournape/zipfile2/milestones/2","html_url":"https://github.com/cournape/zipfile2/milestones/0.12.0","labels_url":"https://api.github.com/repos/cournape/zipfile2/milestones/2/labels","id":1330722,"number":2,"title":"0.12.0","description":"","creator":{"login":"cournape","id":25111,"avatar_url":"https://avatars.githubusercontent.com/u/25111?v=3","gravatar_id":"","url":"https://api.github.com/users/cournape","html_url":"https://github.com/cournape","followers_url":"https://api.github.com/users/cournape/followers","following_url":"https://api.github.com/users/cournape/following{/other_user}","gists_url":"https://api.github.com/users/cournape/gists{/gist_id}","starred_url":"https://api.github.com/users/cournape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cournape/subscriptions","organizations_url":"https://api.github.com/users/cournape/orgs","repos_url":"https://api.github.com/users/cournape/repos","events_url":"https://api.github.com/users/cournape/events{/privacy}","received_events_url":"https://api.github.com/users/cournape/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":1,"state":"open","created_at":"2015-09-30T09:00:44Z","updated_at":"2016-03-22T20:36:43Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cournape/zipfile2/pulls/35/commits","review_comments_url":"https://api.github.com/repos/cournape/zipfile2/pulls/35/comments","review_comment_url":"https://api.github.com/repos/cournape/zipfile2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cournape/zipfile2/issues/35/comments","statuses_url":"https://api.github.com/repos/cournape/zipfile2/statuses/3f6bb936f43997979ac759a42f5c230c3d713e29","head":{"label":"cournape:fix-symlink-handling","ref":"fix-symlink-handling","sha":"3f6bb936f43997979ac759a42f5c230c3d713e29","user":{"login":"cournape","id":25111,"avatar_url":"https://avatars.githubusercontent.com/u/25111?v=3","gravatar_id":"","url":"https://api.github.com/users/cournape","html_url":"https://github.com/cournape","followers_url":"https://api.github.com/users/cournape/followers","following_url":"https://api.github.com/users/cournape/following{/other_user}","gists_url":"https://api.github.com/users/cournape/gists{/gist_id}","starred_url":"https://api.github.com/users/cournape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cournape/subscriptions","organizations_url":"https://api.github.com/users/cournape/orgs","repos_url":"https://api.github.com/users/cournape/repos","events_url":"https://api.github.com/users/cournape/events{/privacy}","received_events_url":"https://api.github.com/users/cournape/received_events","type":"User","site_admin":false},"repo":{"id":35537759,"name":"zipfile2","full_name":"cournape/zipfile2","owner":{"login":"cournape","id":25111,"avatar_url":"https://avatars.githubusercontent.com/u/25111?v=3","gravatar_id":"","url":"https://api.github.com/users/cournape","html_url":"https://github.com/cournape","followers_url":"https://api.github.com/users/cournape/followers","following_url":"https://api.github.com/users/cournape/following{/other_user}","gists_url":"https://api.github.com/users/cournape/gists{/gist_id}","starred_url":"https://api.github.com/users/cournape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cournape/subscriptions","organizations_url":"https://api.github.com/users/cournape/orgs","repos_url":"https://api.github.com/users/cournape/repos","events_url":"https://api.github.com/users/cournape/events{/privacy}","received_events_url":"https://api.github.com/users/cournape/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cournape/zipfile2","description":"An improved ZipFile class for python","fork":false,"url":"https://api.github.com/repos/cournape/zipfile2","forks_url":"https://api.github.com/repos/cournape/zipfile2/forks","keys_url":"https://api.github.com/repos/cournape/zipfile2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cournape/zipfile2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cournape/zipfile2/teams","hooks_url":"https://api.github.com/repos/cournape/zipfile2/hooks","issue_events_url":"https://api.github.com/repos/cournape/zipfile2/issues/events{/number}","events_url":"https://api.github.com/repos/cournape/zipfile2/events","assignees_url":"https://api.github.com/repos/cournape/zipfile2/assignees{/user}","branches_url":"https://api.github.com/repos/cournape/zipfile2/branches{/branch}","tags_url":"https://api.github.com/repos/cournape/zipfile2/tags","blobs_url":"https://api.github.com/repos/cournape/zipfile2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cournape/zipfile2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cournape/zipfile2/git/refs{/sha}","trees_url":"https://api.github.com/repos/cournape/zipfile2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cournape/zipfile2/statuses/{sha}","languages_url":"https://api.github.com/repos/cournape/zipfile2/languages","stargazers_url":"https://api.github.com/repos/cournape/zipfile2/stargazers","contributors_url":"https://api.github.com/repos/cournape/zipfile2/contributors","subscribers_url":"https://api.github.com/repos/cournape/zipfile2/subscribers","subscription_url":"https://api.github.com/repos/cournape/zipfile2/subscription","commits_url":"https://api.github.com/repos/cournape/zipfile2/commits{/sha}","git_commits_url":"https://api.github.com/repos/cournape/zipfile2/git/commits{/sha}","comments_url":"https://api.github.com/repos/cournape/zipfile2/comments{/number}","issue_comment_url":"https://api.github.com/repos/cournape/zipfile2/issues/comments{/number}","contents_url":"https://api.github.com/repos/cournape/zipfile2/contents/{+path}","compare_url":"https://api.github.com/repos/cournape/zipfile2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cournape/zipfile2/merges","archive_url":"https://api.github.com/repos/cournape/zipfile2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cournape/zipfile2/downloads","issues_url":"https://api.github.com/repos/cournape/zipfile2/issues{/number}","pulls_url":"https://api.github.com/repos/cournape/zipfile2/pulls{/number}","milestones_url":"https://api.github.com/repos/cournape/zipfile2/milestones{/number}","notifications_url":"https://api.github.com/repos/cournape/zipfile2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cournape/zipfile2/labels{/name}","releases_url":"https://api.github.com/repos/cournape/zipfile2/releases{/id}","deployments_url":"https://api.github.com/repos/cournape/zipfile2/deployments","created_at":"2015-05-13T08:39:51Z","updated_at":"2015-08-09T00:18:14Z","pushed_at":"2016-03-22T20:36:43Z","git_url":"git://github.com/cournape/zipfile2.git","ssh_url":"git@github.com:cournape/zipfile2.git","clone_url":"https://github.com/cournape/zipfile2.git","svn_url":"https://github.com/cournape/zipfile2","homepage":null,"size":101,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"cournape:master","ref":"master","sha":"55b0f78aa64bac2bbbae144a58f6768600dfb7dd","user":{"login":"cournape","id":25111,"avatar_url":"https://avatars.githubusercontent.com/u/25111?v=3","gravatar_id":"","url":"https://api.github.com/users/cournape","html_url":"https://github.com/cournape","followers_url":"https://api.github.com/users/cournape/followers","following_url":"https://api.github.com/users/cournape/following{/other_user}","gists_url":"https://api.github.com/users/cournape/gists{/gist_id}","starred_url":"https://api.github.com/users/cournape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cournape/subscriptions","organizations_url":"https://api.github.com/users/cournape/orgs","repos_url":"https://api.github.com/users/cournape/repos","events_url":"https://api.github.com/users/cournape/events{/privacy}","received_events_url":"https://api.github.com/users/cournape/received_events","type":"User","site_admin":false},"repo":{"id":35537759,"name":"zipfile2","full_name":"cournape/zipfile2","owner":{"login":"cournape","id":25111,"avatar_url":"https://avatars.githubusercontent.com/u/25111?v=3","gravatar_id":"","url":"https://api.github.com/users/cournape","html_url":"https://github.com/cournape","followers_url":"https://api.github.com/users/cournape/followers","following_url":"https://api.github.com/users/cournape/following{/other_user}","gists_url":"https://api.github.com/users/cournape/gists{/gist_id}","starred_url":"https://api.github.com/users/cournape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cournape/subscriptions","organizations_url":"https://api.github.com/users/cournape/orgs","repos_url":"https://api.github.com/users/cournape/repos","events_url":"https://api.github.com/users/cournape/events{/privacy}","received_events_url":"https://api.github.com/users/cournape/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cournape/zipfile2","description":"An improved ZipFile class for python","fork":false,"url":"https://api.github.com/repos/cournape/zipfile2","forks_url":"https://api.github.com/repos/cournape/zipfile2/forks","keys_url":"https://api.github.com/repos/cournape/zipfile2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cournape/zipfile2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cournape/zipfile2/teams","hooks_url":"https://api.github.com/repos/cournape/zipfile2/hooks","issue_events_url":"https://api.github.com/repos/cournape/zipfile2/issues/events{/number}","events_url":"https://api.github.com/repos/cournape/zipfile2/events","assignees_url":"https://api.github.com/repos/cournape/zipfile2/assignees{/user}","branches_url":"https://api.github.com/repos/cournape/zipfile2/branches{/branch}","tags_url":"https://api.github.com/repos/cournape/zipfile2/tags","blobs_url":"https://api.github.com/repos/cournape/zipfile2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cournape/zipfile2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cournape/zipfile2/git/refs{/sha}","trees_url":"https://api.github.com/repos/cournape/zipfile2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cournape/zipfile2/statuses/{sha}","languages_url":"https://api.github.com/repos/cournape/zipfile2/languages","stargazers_url":"https://api.github.com/repos/cournape/zipfile2/stargazers","contributors_url":"https://api.github.com/repos/cournape/zipfile2/contributors","subscribers_url":"https://api.github.com/repos/cournape/zipfile2/subscribers","subscription_url":"https://api.github.com/repos/cournape/zipfile2/subscription","commits_url":"https://api.github.com/repos/cournape/zipfile2/commits{/sha}","git_commits_url":"https://api.github.com/repos/cournape/zipfile2/git/commits{/sha}","comments_url":"https://api.github.com/repos/cournape/zipfile2/comments{/number}","issue_comment_url":"https://api.github.com/repos/cournape/zipfile2/issues/comments{/number}","contents_url":"https://api.github.com/repos/cournape/zipfile2/contents/{+path}","compare_url":"https://api.github.com/repos/cournape/zipfile2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cournape/zipfile2/merges","archive_url":"https://api.github.com/repos/cournape/zipfile2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cournape/zipfile2/downloads","issues_url":"https://api.github.com/repos/cournape/zipfile2/issues{/number}","pulls_url":"https://api.github.com/repos/cournape/zipfile2/pulls{/number}","milestones_url":"https://api.github.com/repos/cournape/zipfile2/milestones{/number}","notifications_url":"https://api.github.com/repos/cournape/zipfile2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cournape/zipfile2/labels{/name}","releases_url":"https://api.github.com/repos/cournape/zipfile2/releases{/id}","deployments_url":"https://api.github.com/repos/cournape/zipfile2/deployments","created_at":"2015-05-13T08:39:51Z","updated_at":"2015-08-09T00:18:14Z","pushed_at":"2016-03-22T20:36:43Z","git_url":"git://github.com/cournape/zipfile2.git","ssh_url":"git@github.com:cournape/zipfile2.git","clone_url":"https://github.com/cournape/zipfile2.git","svn_url":"https://github.com/cournape/zipfile2","homepage":null,"size":101,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cournape/zipfile2/pulls/35"},"html":{"href":"https://github.com/cournape/zipfile2/pull/35"},"issue":{"href":"https://api.github.com/repos/cournape/zipfile2/issues/35"},"comments":{"href":"https://api.github.com/repos/cournape/zipfile2/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/cournape/zipfile2/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/cournape/zipfile2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cournape/zipfile2/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/cournape/zipfile2/statuses/3f6bb936f43997979ac759a42f5c230c3d713e29"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"cournape","id":25111,"avatar_url":"https://avatars.githubusercontent.com/u/25111?v=3","gravatar_id":"","url":"https://api.github.com/users/cournape","html_url":"https://github.com/cournape","followers_url":"https://api.github.com/users/cournape/followers","following_url":"https://api.github.com/users/cournape/following{/other_user}","gists_url":"https://api.github.com/users/cournape/gists{/gist_id}","starred_url":"https://api.github.com/users/cournape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cournape/subscriptions","organizations_url":"https://api.github.com/users/cournape/orgs","repos_url":"https://api.github.com/users/cournape/repos","events_url":"https://api.github.com/users/cournape/events{/privacy}","received_events_url":"https://api.github.com/users/cournape/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":35,"deletions":3,"changed_files":4}}