{"action":"created","comment":{"url":"https://api.github.com/repos/rails/rails/pulls/comments/53118655","id":53118655,"diff_hunk":"@@ -37,9 +37,9 @@ def teardown\n     )\n   end\n \n-  test \"parses json params for application/vnd.api+json\" do\n+  test \"does not parses unregistered media types such as application/vnd.api+json\" do","path":"actionpack/test/dispatch/request/json_params_parsing_test.rb","position":5,"original_position":5,"commit_id":"c4d90b70f4f27a527e9c2cd3af6cebf560b8df98","original_commit_id":"c4d90b70f4f27a527e9c2cd3af6cebf560b8df98","user":{"login":"bf4","id":142914,"avatar_url":"https://avatars.githubusercontent.com/u/142914?v=3","gravatar_id":"","url":"https://api.github.com/users/bf4","html_url":"https://github.com/bf4","followers_url":"https://api.github.com/users/bf4/followers","following_url":"https://api.github.com/users/bf4/following{/other_user}","gists_url":"https://api.github.com/users/bf4/gists{/gist_id}","starred_url":"https://api.github.com/users/bf4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bf4/subscriptions","organizations_url":"https://api.github.com/users/bf4/orgs","repos_url":"https://api.github.com/users/bf4/repos","events_url":"https://api.github.com/users/bf4/events{/privacy}","received_events_url":"https://api.github.com/users/bf4/received_events","type":"User","site_admin":false},"body":"@rafaelfranca typo `does not parses` should be `does not parse`.  Just leave it for someone else?","created_at":"2016-02-17T04:00:37Z","updated_at":"2016-02-17T04:00:37Z","html_url":"https://github.com/rails/rails/pull/23712#discussion_r53118655","pull_request_url":"https://api.github.com/repos/rails/rails/pulls/23712","_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/53118655"},"html":{"href":"https://github.com/rails/rails/pull/23712#discussion_r53118655"},"pull_request":{"href":"https://api.github.com/repos/rails/rails/pulls/23712"}}},"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/23712","id":59515303,"html_url":"https://github.com/rails/rails/pull/23712","diff_url":"https://github.com/rails/rails/pull/23712.diff","patch_url":"https://github.com/rails/rails/pull/23712.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/23712","number":23712,"state":"closed","locked":false,"title":"The JSON API media type should only work wih a JSON API handler","user":{"login":"bf4","id":142914,"avatar_url":"https://avatars.githubusercontent.com/u/142914?v=3","gravatar_id":"","url":"https://api.github.com/users/bf4","html_url":"https://github.com/bf4","followers_url":"https://api.github.com/users/bf4/followers","following_url":"https://api.github.com/users/bf4/following{/other_user}","gists_url":"https://api.github.com/users/bf4/gists{/gist_id}","starred_url":"https://api.github.com/users/bf4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bf4/subscriptions","organizations_url":"https://api.github.com/users/bf4/orgs","repos_url":"https://api.github.com/users/bf4/repos","events_url":"https://api.github.com/users/bf4/events{/privacy}","received_events_url":"https://api.github.com/users/bf4/received_events","type":"User","site_admin":false},"body":"Revises behavior introduced in #20329 #21251\r\n\r\nSince the media type 'application/vnd.api+json' is a spec,\r\nit is inappropriate to handle it with the JSON renderer.\r\n\r\n## Updated Description per [discussion](https://github.com/rails/rails/pull/23712#issuecomment-184977238)\r\n\r\n>  Let's remove it and introduce back only when we have defined the proper API for the handlers.\r\n\r\nThis PR removes support for the JSON API media type.\r\n\r\nWe recommend the media type be registered on its own as `jsonapi` when a jsonapi Renderer and deserializer (Http::Parameters::DEFAULT_PARSERS) are added.\r\n\r\n## Original Description\r\n\r\n[This PR](6f73b1906fea9ac29f257e8e0c88c117901bbb9e) adds support for a JSON API media type.\r\n\r\n- [ ] It does not currently include a JSON API renderer, but I could add that\r\nhere.\r\n- [ ] The JSON being parsed in the tests is invalid JSON API, but I\r\n  retained the example for test continuity.  I'd like to change that as\r\n  well.\r\n\r\nI've chosen to register JSON API as `api_json` per\r\n[JSONAPI-resources](https://github.com/cerebris/jsonapi-resources/blob/v0.7.0/lib/jsonapi/mime_types.rb),\r\none of the more mature Rails+JSON API gems out there.  An alternate name\r\ncould be `jsonapi`. In both cases, I would recommend the renderer be\r\nnamed after the registered mime type.\r\n\r\nIs related to work in https://github.com/rails/rails/pull/21496\r\n\r\ncc @dgeb","created_at":"2016-02-16T16:25:35Z","updated_at":"2016-02-17T04:00:37Z","closed_at":"2016-02-17T03:54:30Z","merged_at":"2016-02-17T03:54:30Z","merge_commit_sha":"9e331a2f39bb3d64dee0cb9928cd0b6bf9294487","assignee":{"login":"senny","id":5402,"avatar_url":"https://avatars.githubusercontent.com/u/5402?v=3","gravatar_id":"","url":"https://api.github.com/users/senny","html_url":"https://github.com/senny","followers_url":"https://api.github.com/users/senny/followers","following_url":"https://api.github.com/users/senny/following{/other_user}","gists_url":"https://api.github.com/users/senny/gists{/gist_id}","starred_url":"https://api.github.com/users/senny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senny/subscriptions","organizations_url":"https://api.github.com/users/senny/orgs","repos_url":"https://api.github.com/users/senny/repos","events_url":"https://api.github.com/users/senny/events{/privacy}","received_events_url":"https://api.github.com/users/senny/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/23712/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/23712/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/23712/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/c4d90b70f4f27a527e9c2cd3af6cebf560b8df98","head":{"label":"bf4:incorrect_to_accept_json_api_and_not_render_spec","ref":"incorrect_to_accept_json_api_and_not_render_spec","sha":"c4d90b70f4f27a527e9c2cd3af6cebf560b8df98","user":{"login":"bf4","id":142914,"avatar_url":"https://avatars.githubusercontent.com/u/142914?v=3","gravatar_id":"","url":"https://api.github.com/users/bf4","html_url":"https://github.com/bf4","followers_url":"https://api.github.com/users/bf4/followers","following_url":"https://api.github.com/users/bf4/following{/other_user}","gists_url":"https://api.github.com/users/bf4/gists{/gist_id}","starred_url":"https://api.github.com/users/bf4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bf4/subscriptions","organizations_url":"https://api.github.com/users/bf4/orgs","repos_url":"https://api.github.com/users/bf4/repos","events_url":"https://api.github.com/users/bf4/events{/privacy}","received_events_url":"https://api.github.com/users/bf4/received_events","type":"User","site_admin":false},"repo":{"id":10260023,"name":"rails","full_name":"bf4/rails","owner":{"login":"bf4","id":142914,"avatar_url":"https://avatars.githubusercontent.com/u/142914?v=3","gravatar_id":"","url":"https://api.github.com/users/bf4","html_url":"https://github.com/bf4","followers_url":"https://api.github.com/users/bf4/followers","following_url":"https://api.github.com/users/bf4/following{/other_user}","gists_url":"https://api.github.com/users/bf4/gists{/gist_id}","starred_url":"https://api.github.com/users/bf4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bf4/subscriptions","organizations_url":"https://api.github.com/users/bf4/orgs","repos_url":"https://api.github.com/users/bf4/repos","events_url":"https://api.github.com/users/bf4/events{/privacy}","received_events_url":"https://api.github.com/users/bf4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bf4/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/bf4/rails","forks_url":"https://api.github.com/repos/bf4/rails/forks","keys_url":"https://api.github.com/repos/bf4/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bf4/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bf4/rails/teams","hooks_url":"https://api.github.com/repos/bf4/rails/hooks","issue_events_url":"https://api.github.com/repos/bf4/rails/issues/events{/number}","events_url":"https://api.github.com/repos/bf4/rails/events","assignees_url":"https://api.github.com/repos/bf4/rails/assignees{/user}","branches_url":"https://api.github.com/repos/bf4/rails/branches{/branch}","tags_url":"https://api.github.com/repos/bf4/rails/tags","blobs_url":"https://api.github.com/repos/bf4/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bf4/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bf4/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/bf4/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bf4/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/bf4/rails/languages","stargazers_url":"https://api.github.com/repos/bf4/rails/stargazers","contributors_url":"https://api.github.com/repos/bf4/rails/contributors","subscribers_url":"https://api.github.com/repos/bf4/rails/subscribers","subscription_url":"https://api.github.com/repos/bf4/rails/subscription","commits_url":"https://api.github.com/repos/bf4/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/bf4/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/bf4/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/bf4/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/bf4/rails/contents/{+path}","compare_url":"https://api.github.com/repos/bf4/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bf4/rails/merges","archive_url":"https://api.github.com/repos/bf4/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bf4/rails/downloads","issues_url":"https://api.github.com/repos/bf4/rails/issues{/number}","pulls_url":"https://api.github.com/repos/bf4/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/bf4/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/bf4/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bf4/rails/labels{/name}","releases_url":"https://api.github.com/repos/bf4/rails/releases{/id}","deployments_url":"https://api.github.com/repos/bf4/rails/deployments","created_at":"2013-05-24T05:39:41Z","updated_at":"2014-08-18T02:52:28Z","pushed_at":"2016-02-17T03:54:51Z","git_url":"git://github.com/bf4/rails.git","ssh_url":"git@github.com:bf4/rails.git","clone_url":"https://github.com/bf4/rails.git","svn_url":"https://github.com/bf4/rails","homepage":"http://rubyonrails.org","size":121734,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"ecc8f283cfc1b002b5141c527a827e74b770f2f0","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","deployments_url":"https://api.github.com/repos/rails/rails/deployments","created_at":"2008-04-11T02:19:47Z","updated_at":"2016-02-17T01:47:25Z","pushed_at":"2016-02-17T03:54:32Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":326717,"stargazers_count":29727,"watchers_count":29727,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12058,"mirror_url":null,"open_issues_count":892,"forks":12058,"open_issues":892,"watchers":29727,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/23712"},"html":{"href":"https://github.com/rails/rails/pull/23712"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/23712"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/23712/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/23712/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/23712/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/c4d90b70f4f27a527e9c2cd3af6cebf560b8df98"}}}}