{"action":"created","comment":{"url":"https://api.github.com/repos/opencv/opencv/pulls/comments/80153944","id":80153944,"diff_hunk":"@@ -377,10 +377,15 @@ if(MSVC)\n endif()\n \n if(NOT OPENCV_FP16_DISABLE)\n+  if(ARM)\n+    set(FP16_OPTION \"-mfpu=neon-fp16\")\n+  elseif(X86 OR X86_64)\n+    set(FP16_OPTION \"-mf16c\")\n+  endif()","path":"cmake/OpenCVCompilerOptions.cmake","position":null,"original_position":8,"commit_id":"239515cf9d777031a4c672c0d73fc4cd4f8f9351","original_commit_id":"034f77e2c3957394f3a294967bfcddfcf79fe2ed","user":{"login":"tomoaki0705","id":3737315,"avatar_url":"https://avatars.githubusercontent.com/u/3737315?v=3","gravatar_id":"","url":"https://api.github.com/users/tomoaki0705","html_url":"https://github.com/tomoaki0705","followers_url":"https://api.github.com/users/tomoaki0705/followers","following_url":"https://api.github.com/users/tomoaki0705/following{/other_user}","gists_url":"https://api.github.com/users/tomoaki0705/gists{/gist_id}","starred_url":"https://api.github.com/users/tomoaki0705/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomoaki0705/subscriptions","organizations_url":"https://api.github.com/users/tomoaki0705/orgs","repos_url":"https://api.github.com/users/tomoaki0705/repos","events_url":"https://api.github.com/users/tomoaki0705/events{/privacy}","received_events_url":"https://api.github.com/users/tomoaki0705/received_events","type":"User","site_admin":false},"body":"@alalek , thank you for your review and suggestion.\r\nI switched back to ```try_compile```\r\nI was facing a problem that when the processor doesn't support FP16, the program was crashing with ``illegal instruction``\r\nI checked and this happened even I disabled the ```CV_FP16```\r\nI then realized that the generated binary had some AVX instructions.\r\n```\r\n~/opencv-fork/build$ cd modules/core\r\n~/opencv-fork/build/modules/core$ make test/test_intrin.cpp.s\r\n~/opencv-fork/build/modules/core$ grep vadd CMakeFiles/opencv_test_core.dir/test/test_intrin.cpp.s\r\n        vaddps  %xmm0, %xmm1, %xmm1\r\n        vaddps  %xmm2, %xmm3, %xmm0\r\n        vaddps  %xmm1, %xmm0, %xmm0\r\n```\r\nThose ```vaddps``` instructions were not from the ```FP16``` related part.\r\nSo I let the FP16 feature rely on AVX flag, too.","created_at":"2016-09-22T22:55:54Z","updated_at":"2016-09-22T22:55:54Z","html_url":"https://github.com/opencv/opencv/pull/7317#discussion_r80153944","pull_request_url":"https://api.github.com/repos/opencv/opencv/pulls/7317","_links":{"self":{"href":"https://api.github.com/repos/opencv/opencv/pulls/comments/80153944"},"html":{"href":"https://github.com/opencv/opencv/pull/7317#discussion_r80153944"},"pull_request":{"href":"https://api.github.com/repos/opencv/opencv/pulls/7317"}}},"pull_request":{"url":"https://api.github.com/repos/opencv/opencv/pulls/7317","id":85940761,"html_url":"https://github.com/opencv/opencv/pull/7317","diff_url":"https://github.com/opencv/opencv/pull/7317.diff","patch_url":"https://github.com/opencv/opencv/pull/7317.patch","issue_url":"https://api.github.com/repos/opencv/opencv/issues/7317","number":7317,"state":"open","locked":false,"title":"build: check FP16 build condition correctly","user":{"login":"tomoaki0705","id":3737315,"avatar_url":"https://avatars.githubusercontent.com/u/3737315?v=3","gravatar_id":"","url":"https://api.github.com/users/tomoaki0705","html_url":"https://github.com/tomoaki0705","followers_url":"https://api.github.com/users/tomoaki0705/followers","following_url":"https://api.github.com/users/tomoaki0705/following{/other_user}","gists_url":"https://api.github.com/users/tomoaki0705/gists{/gist_id}","starred_url":"https://api.github.com/users/tomoaki0705/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomoaki0705/subscriptions","organizations_url":"https://api.github.com/users/tomoaki0705/orgs","repos_url":"https://api.github.com/users/tomoaki0705/repos","events_url":"https://api.github.com/users/tomoaki0705/events{/privacy}","received_events_url":"https://api.github.com/users/tomoaki0705/received_events","type":"User","site_admin":false},"body":"<!-- Please use this line to close one or multiple issues when this pullrequest gets merged\r\nYou can add another line right under the first one:\r\nresolves #1234\r\nresolves #1235\r\n-->\r\n\r\n### This pullrequest changes\r\n\r\n<!-- Please describe what your pullrequest is changing -->\r\n\r\n  * use GNUC_MINOR in correct place to check the version of GCC\r\n  * guard using ifdef correctly in case of various configuration\r\n  * use v_float16x4 correctly by including the right header file\r\n  * check FP16 compiler support using cmake correctly","created_at":"2016-09-20T09:33:53Z","updated_at":"2016-09-22T22:55:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb8984baf43b2fb6b12032fb25946a18e0eb008c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/opencv/opencv/pulls/7317/commits","review_comments_url":"https://api.github.com/repos/opencv/opencv/pulls/7317/comments","review_comment_url":"https://api.github.com/repos/opencv/opencv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencv/opencv/issues/7317/comments","statuses_url":"https://api.github.com/repos/opencv/opencv/statuses/239515cf9d777031a4c672c0d73fc4cd4f8f9351","head":{"label":"tomoaki0705:fixIfdefFp16","ref":"fixIfdefFp16","sha":"239515cf9d777031a4c672c0d73fc4cd4f8f9351","user":{"login":"tomoaki0705","id":3737315,"avatar_url":"https://avatars.githubusercontent.com/u/3737315?v=3","gravatar_id":"","url":"https://api.github.com/users/tomoaki0705","html_url":"https://github.com/tomoaki0705","followers_url":"https://api.github.com/users/tomoaki0705/followers","following_url":"https://api.github.com/users/tomoaki0705/following{/other_user}","gists_url":"https://api.github.com/users/tomoaki0705/gists{/gist_id}","starred_url":"https://api.github.com/users/tomoaki0705/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomoaki0705/subscriptions","organizations_url":"https://api.github.com/users/tomoaki0705/orgs","repos_url":"https://api.github.com/users/tomoaki0705/repos","events_url":"https://api.github.com/users/tomoaki0705/events{/privacy}","received_events_url":"https://api.github.com/users/tomoaki0705/received_events","type":"User","site_admin":false},"repo":{"id":56547524,"name":"opencv","full_name":"tomoaki0705/opencv","owner":{"login":"tomoaki0705","id":3737315,"avatar_url":"https://avatars.githubusercontent.com/u/3737315?v=3","gravatar_id":"","url":"https://api.github.com/users/tomoaki0705","html_url":"https://github.com/tomoaki0705","followers_url":"https://api.github.com/users/tomoaki0705/followers","following_url":"https://api.github.com/users/tomoaki0705/following{/other_user}","gists_url":"https://api.github.com/users/tomoaki0705/gists{/gist_id}","starred_url":"https://api.github.com/users/tomoaki0705/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomoaki0705/subscriptions","organizations_url":"https://api.github.com/users/tomoaki0705/orgs","repos_url":"https://api.github.com/users/tomoaki0705/repos","events_url":"https://api.github.com/users/tomoaki0705/events{/privacy}","received_events_url":"https://api.github.com/users/tomoaki0705/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomoaki0705/opencv","description":"Open Source Computer Vision Library","fork":true,"url":"https://api.github.com/repos/tomoaki0705/opencv","forks_url":"https://api.github.com/repos/tomoaki0705/opencv/forks","keys_url":"https://api.github.com/repos/tomoaki0705/opencv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomoaki0705/opencv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomoaki0705/opencv/teams","hooks_url":"https://api.github.com/repos/tomoaki0705/opencv/hooks","issue_events_url":"https://api.github.com/repos/tomoaki0705/opencv/issues/events{/number}","events_url":"https://api.github.com/repos/tomoaki0705/opencv/events","assignees_url":"https://api.github.com/repos/tomoaki0705/opencv/assignees{/user}","branches_url":"https://api.github.com/repos/tomoaki0705/opencv/branches{/branch}","tags_url":"https://api.github.com/repos/tomoaki0705/opencv/tags","blobs_url":"https://api.github.com/repos/tomoaki0705/opencv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomoaki0705/opencv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomoaki0705/opencv/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomoaki0705/opencv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomoaki0705/opencv/statuses/{sha}","languages_url":"https://api.github.com/repos/tomoaki0705/opencv/languages","stargazers_url":"https://api.github.com/repos/tomoaki0705/opencv/stargazers","contributors_url":"https://api.github.com/repos/tomoaki0705/opencv/contributors","subscribers_url":"https://api.github.com/repos/tomoaki0705/opencv/subscribers","subscription_url":"https://api.github.com/repos/tomoaki0705/opencv/subscription","commits_url":"https://api.github.com/repos/tomoaki0705/opencv/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomoaki0705/opencv/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomoaki0705/opencv/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomoaki0705/opencv/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomoaki0705/opencv/contents/{+path}","compare_url":"https://api.github.com/repos/tomoaki0705/opencv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomoaki0705/opencv/merges","archive_url":"https://api.github.com/repos/tomoaki0705/opencv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomoaki0705/opencv/downloads","issues_url":"https://api.github.com/repos/tomoaki0705/opencv/issues{/number}","pulls_url":"https://api.github.com/repos/tomoaki0705/opencv/pulls{/number}","milestones_url":"https://api.github.com/repos/tomoaki0705/opencv/milestones{/number}","notifications_url":"https://api.github.com/repos/tomoaki0705/opencv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomoaki0705/opencv/labels{/name}","releases_url":"https://api.github.com/repos/tomoaki0705/opencv/releases{/id}","deployments_url":"https://api.github.com/repos/tomoaki0705/opencv/deployments","created_at":"2016-04-18T22:48:30Z","updated_at":"2016-04-18T22:48:42Z","pushed_at":"2016-09-22T22:22:42Z","git_url":"git://github.com/tomoaki0705/opencv.git","ssh_url":"git@github.com:tomoaki0705/opencv.git","clone_url":"https://github.com/tomoaki0705/opencv.git","svn_url":"https://github.com/tomoaki0705/opencv","homepage":"opencv.org","size":426489,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencv:master","ref":"master","sha":"7f14a278a71b065baf53340f7181c5cc62dc722e","user":{"login":"opencv","id":5009934,"avatar_url":"https://avatars.githubusercontent.com/u/5009934?v=3","gravatar_id":"","url":"https://api.github.com/users/opencv","html_url":"https://github.com/opencv","followers_url":"https://api.github.com/users/opencv/followers","following_url":"https://api.github.com/users/opencv/following{/other_user}","gists_url":"https://api.github.com/users/opencv/gists{/gist_id}","starred_url":"https://api.github.com/users/opencv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencv/subscriptions","organizations_url":"https://api.github.com/users/opencv/orgs","repos_url":"https://api.github.com/users/opencv/repos","events_url":"https://api.github.com/users/opencv/events{/privacy}","received_events_url":"https://api.github.com/users/opencv/received_events","type":"Organization","site_admin":false},"repo":{"id":5108051,"name":"opencv","full_name":"opencv/opencv","owner":{"login":"opencv","id":5009934,"avatar_url":"https://avatars.githubusercontent.com/u/5009934?v=3","gravatar_id":"","url":"https://api.github.com/users/opencv","html_url":"https://github.com/opencv","followers_url":"https://api.github.com/users/opencv/followers","following_url":"https://api.github.com/users/opencv/following{/other_user}","gists_url":"https://api.github.com/users/opencv/gists{/gist_id}","starred_url":"https://api.github.com/users/opencv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencv/subscriptions","organizations_url":"https://api.github.com/users/opencv/orgs","repos_url":"https://api.github.com/users/opencv/repos","events_url":"https://api.github.com/users/opencv/events{/privacy}","received_events_url":"https://api.github.com/users/opencv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencv/opencv","description":"Open Source Computer Vision Library","fork":false,"url":"https://api.github.com/repos/opencv/opencv","forks_url":"https://api.github.com/repos/opencv/opencv/forks","keys_url":"https://api.github.com/repos/opencv/opencv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencv/opencv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencv/opencv/teams","hooks_url":"https://api.github.com/repos/opencv/opencv/hooks","issue_events_url":"https://api.github.com/repos/opencv/opencv/issues/events{/number}","events_url":"https://api.github.com/repos/opencv/opencv/events","assignees_url":"https://api.github.com/repos/opencv/opencv/assignees{/user}","branches_url":"https://api.github.com/repos/opencv/opencv/branches{/branch}","tags_url":"https://api.github.com/repos/opencv/opencv/tags","blobs_url":"https://api.github.com/repos/opencv/opencv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencv/opencv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencv/opencv/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencv/opencv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencv/opencv/statuses/{sha}","languages_url":"https://api.github.com/repos/opencv/opencv/languages","stargazers_url":"https://api.github.com/repos/opencv/opencv/stargazers","contributors_url":"https://api.github.com/repos/opencv/opencv/contributors","subscribers_url":"https://api.github.com/repos/opencv/opencv/subscribers","subscription_url":"https://api.github.com/repos/opencv/opencv/subscription","commits_url":"https://api.github.com/repos/opencv/opencv/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencv/opencv/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencv/opencv/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencv/opencv/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencv/opencv/contents/{+path}","compare_url":"https://api.github.com/repos/opencv/opencv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencv/opencv/merges","archive_url":"https://api.github.com/repos/opencv/opencv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencv/opencv/downloads","issues_url":"https://api.github.com/repos/opencv/opencv/issues{/number}","pulls_url":"https://api.github.com/repos/opencv/opencv/pulls{/number}","milestones_url":"https://api.github.com/repos/opencv/opencv/milestones{/number}","notifications_url":"https://api.github.com/repos/opencv/opencv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencv/opencv/labels{/name}","releases_url":"https://api.github.com/repos/opencv/opencv/releases{/id}","deployments_url":"https://api.github.com/repos/opencv/opencv/deployments","created_at":"2012-07-19T09:40:17Z","updated_at":"2016-09-22T22:33:56Z","pushed_at":"2016-09-22T22:22:43Z","git_url":"git://github.com/opencv/opencv.git","ssh_url":"git@github.com:opencv/opencv.git","clone_url":"https://github.com/opencv/opencv.git","svn_url":"https://github.com/opencv/opencv","homepage":"opencv.org","size":1084678,"stargazers_count":11246,"watchers_count":11246,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9231,"mirror_url":null,"open_issues_count":975,"forks":9231,"open_issues":975,"watchers":11246,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencv/opencv/pulls/7317"},"html":{"href":"https://github.com/opencv/opencv/pull/7317"},"issue":{"href":"https://api.github.com/repos/opencv/opencv/issues/7317"},"comments":{"href":"https://api.github.com/repos/opencv/opencv/issues/7317/comments"},"review_comments":{"href":"https://api.github.com/repos/opencv/opencv/pulls/7317/comments"},"review_comment":{"href":"https://api.github.com/repos/opencv/opencv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencv/opencv/pulls/7317/commits"},"statuses":{"href":"https://api.github.com/repos/opencv/opencv/statuses/239515cf9d777031a4c672c0d73fc4cd4f8f9351"}}}}
{"actor":{"display_login":"tomoaki0705"}}