{"action":"created","issue":{"url":"https://api.github.com/repos/akvo/akvo-flow/issues/1660","repository_url":"https://api.github.com/repos/akvo/akvo-flow","labels_url":"https://api.github.com/repos/akvo/akvo-flow/issues/1660/labels{/name}","comments_url":"https://api.github.com/repos/akvo/akvo-flow/issues/1660/comments","events_url":"https://api.github.com/repos/akvo/akvo-flow/issues/1660/events","html_url":"https://github.com/akvo/akvo-flow/issues/1660","id":154222967,"number":1660,"title":"Assign a data approval workflow to a survey definition - MVP (estimated: 48)","user":{"login":"janagombitova","id":12456965,"avatar_url":"https://avatars.githubusercontent.com/u/12456965?v=3","gravatar_id":"","url":"https://api.github.com/users/janagombitova","html_url":"https://github.com/janagombitova","followers_url":"https://api.github.com/users/janagombitova/followers","following_url":"https://api.github.com/users/janagombitova/following{/other_user}","gists_url":"https://api.github.com/users/janagombitova/gists{/gist_id}","starred_url":"https://api.github.com/users/janagombitova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janagombitova/subscriptions","organizations_url":"https://api.github.com/users/janagombitova/orgs","repos_url":"https://api.github.com/users/janagombitova/repos","events_url":"https://api.github.com/users/janagombitova/events{/privacy}","received_events_url":"https://api.github.com/users/janagombitova/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"muloem","id":533336,"avatar_url":"https://avatars.githubusercontent.com/u/533336?v=3","gravatar_id":"","url":"https://api.github.com/users/muloem","html_url":"https://github.com/muloem","followers_url":"https://api.github.com/users/muloem/followers","following_url":"https://api.github.com/users/muloem/following{/other_user}","gists_url":"https://api.github.com/users/muloem/gists{/gist_id}","starred_url":"https://api.github.com/users/muloem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muloem/subscriptions","organizations_url":"https://api.github.com/users/muloem/orgs","repos_url":"https://api.github.com/users/muloem/repos","events_url":"https://api.github.com/users/muloem/events{/privacy}","received_events_url":"https://api.github.com/users/muloem/received_events","type":"User","site_admin":false},"assignees":[{"login":"muloem","id":533336,"avatar_url":"https://avatars.githubusercontent.com/u/533336?v=3","gravatar_id":"","url":"https://api.github.com/users/muloem","html_url":"https://github.com/muloem","followers_url":"https://api.github.com/users/muloem/followers","following_url":"https://api.github.com/users/muloem/following{/other_user}","gists_url":"https://api.github.com/users/muloem/gists{/gist_id}","starred_url":"https://api.github.com/users/muloem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muloem/subscriptions","organizations_url":"https://api.github.com/users/muloem/orgs","repos_url":"https://api.github.com/users/muloem/repos","events_url":"https://api.github.com/users/muloem/events{/privacy}","received_events_url":"https://api.github.com/users/muloem/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/akvo/akvo-flow/milestones/89","html_url":"https://github.com/akvo/akvo-flow/milestones/1.9.11","labels_url":"https://api.github.com/repos/akvo/akvo-flow/milestones/89/labels","id":2008769,"number":89,"title":"1.9.11","description":"Data approval release ","creator":{"login":"janagombitova","id":12456965,"avatar_url":"https://avatars.githubusercontent.com/u/12456965?v=3","gravatar_id":"","url":"https://api.github.com/users/janagombitova","html_url":"https://github.com/janagombitova","followers_url":"https://api.github.com/users/janagombitova/followers","following_url":"https://api.github.com/users/janagombitova/following{/other_user}","gists_url":"https://api.github.com/users/janagombitova/gists{/gist_id}","starred_url":"https://api.github.com/users/janagombitova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janagombitova/subscriptions","organizations_url":"https://api.github.com/users/janagombitova/orgs","repos_url":"https://api.github.com/users/janagombitova/repos","events_url":"https://api.github.com/users/janagombitova/events{/privacy}","received_events_url":"https://api.github.com/users/janagombitova/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":0,"state":"open","created_at":"2016-09-16T09:07:10Z","updated_at":"2016-09-26T13:48:09Z","due_on":"2016-10-03T00:00:00Z","closed_at":null},"comments":7,"created_at":"2016-05-11T11:41:39Z","updated_at":"2016-10-03T12:12:26Z","closed_at":null,"body":"For all the background information on this feature and the decisions around the MVP please check: akvo/akvo-product-design#82\r\n\r\n\r\n#### Assign approval workflow to survey\r\n**Details:** \r\nThe user will select which workflow he wants to use when defining the survey following the monitoring pattern. \r\n- In the survey definition in 'Advanced settings' section, add a checkbox 'Enable data approval workflow features' in the same way as monitoring is enabled. \r\n- Once selected the user will see: \r\n   - a dropdown with the list of existing data approval workflows \r\n   - a link 'Show data approval workflow', which is not enabled. \r\n- He selects the approval workflow from the list and it is show as selected in the dropdown and the 'Show data approval workflow' is activated. \r\n- Once clicking on 'Show data approval workflow' the workflow is shown in its title, type and steps in a in page pop-up\r\n\r\n**Questions:**\r\nWill the user need to re-publish a survey after making this change? \r\n\r\n\r\n\r\n#### Assign responsible user to an approval workflow \r\nIn the survey definition after the user selects a workflow here is also the place where the user will define which dashboard user is responsible in implementing the workflow step. We have decided not to add this user permission in the general Users tab because: \r\n- one workflow can be used in multiple surveys what makes the user selection complex\r\n- a particular user John is responsible to implement one step is survey A but not in survey B\r\n- the user adds a workflow to a survey in the survey definition and we expect him to make the decision on who is responsible at this point of time as well\r\n\r\n**Details:** (draft)\r\n- please follow the mock ups and functional design doc\r\n- when viewing selected workflow in the survey definition each step holds a clickable link 'Responsible user'\r\n- after selected a list of users is rendered - only users with 'View data' permission for this survey\r\n- users are selected and assigned -> only the user who is selected for implementing a step will have the power to implement the workflow step on the datapoint in the Monitoring tab \r\n  "},"comment":{"url":"https://api.github.com/repos/akvo/akvo-flow/issues/comments/251090827","html_url":"https://github.com/akvo/akvo-flow/issues/1660#issuecomment-251090827","issue_url":"https://api.github.com/repos/akvo/akvo-flow/issues/1660","id":251090827,"user":{"login":"janagombitova","id":12456965,"avatar_url":"https://avatars.githubusercontent.com/u/12456965?v=3","gravatar_id":"","url":"https://api.github.com/users/janagombitova","html_url":"https://github.com/janagombitova","followers_url":"https://api.github.com/users/janagombitova/followers","following_url":"https://api.github.com/users/janagombitova/following{/other_user}","gists_url":"https://api.github.com/users/janagombitova/gists{/gist_id}","starred_url":"https://api.github.com/users/janagombitova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janagombitova/subscriptions","organizations_url":"https://api.github.com/users/janagombitova/orgs","repos_url":"https://api.github.com/users/janagombitova/repos","events_url":"https://api.github.com/users/janagombitova/events{/privacy}","received_events_url":"https://api.github.com/users/janagombitova/received_events","type":"User","site_admin":false},"created_at":"2016-10-03T12:12:26Z","updated_at":"2016-10-03T12:12:26Z","body":"# 2nd round of testing \r\n\r\nFor this review we can consider the implementation good enough and any comments (from the previous tests) will be handled in the following sprints \r\n\r\n👍 assigning an approval group to a survey passes the test"}}
{"actor":{"display_login":"janagombitova"}}