{"action":"created","issue":{"url":"https://api.github.com/repos/ztellman/aleph/issues/284","repository_url":"https://api.github.com/repos/ztellman/aleph","labels_url":"https://api.github.com/repos/ztellman/aleph/issues/284/labels{/name}","comments_url":"https://api.github.com/repos/ztellman/aleph/issues/284/comments","events_url":"https://api.github.com/repos/ztellman/aleph/issues/284/events","html_url":"https://github.com/ztellman/aleph/issues/284","id":192965576,"number":284,"title":"Refactoring of wrap-query-params changes nested parameter handling","user":{"login":"camdez","id":141447,"avatar_url":"https://avatars.githubusercontent.com/u/141447?v=3","gravatar_id":"","url":"https://api.github.com/users/camdez","html_url":"https://github.com/camdez","followers_url":"https://api.github.com/users/camdez/followers","following_url":"https://api.github.com/users/camdez/following{/other_user}","gists_url":"https://api.github.com/users/camdez/gists{/gist_id}","starred_url":"https://api.github.com/users/camdez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camdez/subscriptions","organizations_url":"https://api.github.com/users/camdez/orgs","repos_url":"https://api.github.com/users/camdez/repos","events_url":"https://api.github.com/users/camdez/events{/privacy}","received_events_url":"https://api.github.com/users/camdez/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-12-01T21:21:23Z","updated_at":"2016-12-02T03:18:29Z","closed_at":null,"body":"[The recent \"refactoring\" of `wrap-query-params`](https://github.com/ztellman/aleph/commit/d0b50d66c8f218f1f3451489f4ef2a6057f8b7f1#diff-0699d0c8d41a57446aff9b64094ddf35R393) introduces breaking changes to how nested query parameters are handled. I'm guessing this is not intentional based on the commit description (please close if I'm incorrect).\r\n\r\nBehavior prior to d0b50d66c8f218f1f3451489f4ef2a6057f8b7f1:\r\n\r\n```clj\r\n(aleph.http.client-middleware/decorate-query-params\r\n {:query-params {:foo {:bar 42}}})\r\n;; => {:query-string \"foo%5Bbar%5D=42\"}\r\n```\r\n\r\nBehavior after d0b50d66c8f218f1f3451489f4ef2a6057f8b7f1 (note function was renamed):\r\n\r\n```clj\r\n(aleph.http.client-middleware/wrap-query-params\r\n {:query-params {:foo {:bar 42}}})\r\n;; => {:query-string \"foo=%7B%3Abar+42%7D\"}\r\n```\r\n\r\nThe updated version also leaves the `nest-params` function unused, so it seems it may have been a simple oversight. \r\n\r\n/cc @solatis "},"comment":{"url":"https://api.github.com/repos/ztellman/aleph/issues/comments/264363433","html_url":"https://github.com/ztellman/aleph/issues/284#issuecomment-264363433","issue_url":"https://api.github.com/repos/ztellman/aleph/issues/284","id":264363433,"user":{"login":"solatis","id":119317,"avatar_url":"https://avatars.githubusercontent.com/u/119317?v=3","gravatar_id":"","url":"https://api.github.com/users/solatis","html_url":"https://github.com/solatis","followers_url":"https://api.github.com/users/solatis/followers","following_url":"https://api.github.com/users/solatis/following{/other_user}","gists_url":"https://api.github.com/users/solatis/gists{/gist_id}","starred_url":"https://api.github.com/users/solatis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solatis/subscriptions","organizations_url":"https://api.github.com/users/solatis/orgs","repos_url":"https://api.github.com/users/solatis/repos","events_url":"https://api.github.com/users/solatis/events{/privacy}","received_events_url":"https://api.github.com/users/solatis/received_events","type":"User","site_admin":false},"created_at":"2016-12-02T03:18:29Z","updated_at":"2016-12-02T03:18:29Z","body":"@camdez I ported the `wrap-nested-params` into aleph, could you take a look whether this properly addresses your issue ?"}}
{"actor":{"display_login":"solatis"}}