{"action":"created","comment":{"url":"https://api.github.com/repos/root-mirror/root/pulls/comments/51846245","id":51846245,"diff_hunk":"@@ -4153,10 +4156,14 @@ int RootCling(int argc,\n    }\n \n    std::string resourceDir;\n-#ifdef R__LLVMRESOURCEDIR\n-   resourceDir = \"@R__LLVMRESOURCEDIR@\";\n+#ifdef R__EXTERN_LLVMDIR\n+   resourceDir = R__EXTERN_LLVMDIR;","path":"core/utils/src/rootcling.cxx","position":45,"original_position":45,"commit_id":"fdbcd5e78824b54b2114ef19ce5fd033986f9fd9","original_commit_id":"ad6e69c5968b3284065b9844875d87e0612c4916","user":{"login":"ellert","id":1931206,"avatar_url":"https://avatars.githubusercontent.com/u/1931206?v=3","gravatar_id":"","url":"https://api.github.com/users/ellert","html_url":"https://github.com/ellert","followers_url":"https://api.github.com/users/ellert/followers","following_url":"https://api.github.com/users/ellert/following{/other_user}","gists_url":"https://api.github.com/users/ellert/gists{/gist_id}","starred_url":"https://api.github.com/users/ellert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ellert/subscriptions","organizations_url":"https://api.github.com/users/ellert/orgs","repos_url":"https://api.github.com/users/ellert/repos","events_url":"https://api.github.com/users/ellert/events{/privacy}","received_events_url":"https://api.github.com/users/ellert/received_events","type":"User","site_admin":false},"body":"The removal of #ifdef R__LLVMRESOURCEDIR was done, as you say, because it was not used any more.\r\n\r\nThe addition of #ifdef R__EXTERN_LLVMDIR was not intended as a replacement for this, but is part of the replacement of TMetaUtils::GetLLVMResourceDir that follows. Compare to the similar replacement in core/meta/src/TCling.cxx.\r\n\r\nEarlier in the rootcling.cxx file there is a #define R__LLVMDIR which doesn't seem to be used anywhere. Maybe this can be removed.","created_at":"2016-02-04T09:18:51Z","updated_at":"2016-02-04T09:18:51Z","html_url":"https://github.com/root-mirror/root/pull/130#discussion_r51846245","pull_request_url":"https://api.github.com/repos/root-mirror/root/pulls/130","_links":{"self":{"href":"https://api.github.com/repos/root-mirror/root/pulls/comments/51846245"},"html":{"href":"https://github.com/root-mirror/root/pull/130#discussion_r51846245"},"pull_request":{"href":"https://api.github.com/repos/root-mirror/root/pulls/130"}}},"pull_request":{"url":"https://api.github.com/repos/root-mirror/root/pulls/130","id":55538151,"html_url":"https://github.com/root-mirror/root/pull/130","diff_url":"https://github.com/root-mirror/root/pull/130.diff","patch_url":"https://github.com/root-mirror/root/pull/130.patch","issue_url":"https://api.github.com/repos/root-mirror/root/issues/130","number":130,"state":"open","locked":false,"title":"Make it possible to run tests when configuring with -Dgnuinstall:BOOL=ON","user":{"login":"ellert","id":1931206,"avatar_url":"https://avatars.githubusercontent.com/u/1931206?v=3","gravatar_id":"","url":"https://api.github.com/users/ellert","html_url":"https://github.com/ellert","followers_url":"https://api.github.com/users/ellert/followers","following_url":"https://api.github.com/users/ellert/following{/other_user}","gists_url":"https://api.github.com/users/ellert/gists{/gist_id}","starred_url":"https://api.github.com/users/ellert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ellert/subscriptions","organizations_url":"https://api.github.com/users/ellert/orgs","repos_url":"https://api.github.com/users/ellert/repos","events_url":"https://api.github.com/users/ellert/events{/privacy}","received_events_url":"https://api.github.com/users/ellert/received_events","type":"User","site_admin":false},"body":"This is a possible solution for ROOT-7538. I hope this is at least similar to what you had in mind when you wrote the comment in that ticket. Hopefully it can at least be used as a start.","created_at":"2016-01-09T08:23:54Z","updated_at":"2016-02-04T09:18:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e28f905b8f53563b2c4ccad1af8367020e8f6eeb","assignee":{"login":"karies","id":144675,"avatar_url":"https://avatars.githubusercontent.com/u/144675?v=3","gravatar_id":"","url":"https://api.github.com/users/karies","html_url":"https://github.com/karies","followers_url":"https://api.github.com/users/karies/followers","following_url":"https://api.github.com/users/karies/following{/other_user}","gists_url":"https://api.github.com/users/karies/gists{/gist_id}","starred_url":"https://api.github.com/users/karies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karies/subscriptions","organizations_url":"https://api.github.com/users/karies/orgs","repos_url":"https://api.github.com/users/karies/repos","events_url":"https://api.github.com/users/karies/events{/privacy}","received_events_url":"https://api.github.com/users/karies/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/root-mirror/root/pulls/130/commits","review_comments_url":"https://api.github.com/repos/root-mirror/root/pulls/130/comments","review_comment_url":"https://api.github.com/repos/root-mirror/root/pulls/comments{/number}","comments_url":"https://api.github.com/repos/root-mirror/root/issues/130/comments","statuses_url":"https://api.github.com/repos/root-mirror/root/statuses/fdbcd5e78824b54b2114ef19ce5fd033986f9fd9","head":{"label":"ellert:install-test","ref":"install-test","sha":"fdbcd5e78824b54b2114ef19ce5fd033986f9fd9","user":{"login":"ellert","id":1931206,"avatar_url":"https://avatars.githubusercontent.com/u/1931206?v=3","gravatar_id":"","url":"https://api.github.com/users/ellert","html_url":"https://github.com/ellert","followers_url":"https://api.github.com/users/ellert/followers","following_url":"https://api.github.com/users/ellert/following{/other_user}","gists_url":"https://api.github.com/users/ellert/gists{/gist_id}","starred_url":"https://api.github.com/users/ellert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ellert/subscriptions","organizations_url":"https://api.github.com/users/ellert/orgs","repos_url":"https://api.github.com/users/ellert/repos","events_url":"https://api.github.com/users/ellert/events{/privacy}","received_events_url":"https://api.github.com/users/ellert/received_events","type":"User","site_admin":false},"repo":{"id":42727342,"name":"root","full_name":"ellert/root","owner":{"login":"ellert","id":1931206,"avatar_url":"https://avatars.githubusercontent.com/u/1931206?v=3","gravatar_id":"","url":"https://api.github.com/users/ellert","html_url":"https://github.com/ellert","followers_url":"https://api.github.com/users/ellert/followers","following_url":"https://api.github.com/users/ellert/following{/other_user}","gists_url":"https://api.github.com/users/ellert/gists{/gist_id}","starred_url":"https://api.github.com/users/ellert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ellert/subscriptions","organizations_url":"https://api.github.com/users/ellert/orgs","repos_url":"https://api.github.com/users/ellert/repos","events_url":"https://api.github.com/users/ellert/events{/privacy}","received_events_url":"https://api.github.com/users/ellert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ellert/root","description":"Mirror of official ROOT git repository","fork":true,"url":"https://api.github.com/repos/ellert/root","forks_url":"https://api.github.com/repos/ellert/root/forks","keys_url":"https://api.github.com/repos/ellert/root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ellert/root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ellert/root/teams","hooks_url":"https://api.github.com/repos/ellert/root/hooks","issue_events_url":"https://api.github.com/repos/ellert/root/issues/events{/number}","events_url":"https://api.github.com/repos/ellert/root/events","assignees_url":"https://api.github.com/repos/ellert/root/assignees{/user}","branches_url":"https://api.github.com/repos/ellert/root/branches{/branch}","tags_url":"https://api.github.com/repos/ellert/root/tags","blobs_url":"https://api.github.com/repos/ellert/root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ellert/root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ellert/root/git/refs{/sha}","trees_url":"https://api.github.com/repos/ellert/root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ellert/root/statuses/{sha}","languages_url":"https://api.github.com/repos/ellert/root/languages","stargazers_url":"https://api.github.com/repos/ellert/root/stargazers","contributors_url":"https://api.github.com/repos/ellert/root/contributors","subscribers_url":"https://api.github.com/repos/ellert/root/subscribers","subscription_url":"https://api.github.com/repos/ellert/root/subscription","commits_url":"https://api.github.com/repos/ellert/root/commits{/sha}","git_commits_url":"https://api.github.com/repos/ellert/root/git/commits{/sha}","comments_url":"https://api.github.com/repos/ellert/root/comments{/number}","issue_comment_url":"https://api.github.com/repos/ellert/root/issues/comments{/number}","contents_url":"https://api.github.com/repos/ellert/root/contents/{+path}","compare_url":"https://api.github.com/repos/ellert/root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ellert/root/merges","archive_url":"https://api.github.com/repos/ellert/root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ellert/root/downloads","issues_url":"https://api.github.com/repos/ellert/root/issues{/number}","pulls_url":"https://api.github.com/repos/ellert/root/pulls{/number}","milestones_url":"https://api.github.com/repos/ellert/root/milestones{/number}","notifications_url":"https://api.github.com/repos/ellert/root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ellert/root/labels{/name}","releases_url":"https://api.github.com/repos/ellert/root/releases{/id}","deployments_url":"https://api.github.com/repos/ellert/root/deployments","created_at":"2015-09-18T14:31:05Z","updated_at":"2016-01-16T04:44:01Z","pushed_at":"2016-02-04T08:32:36Z","git_url":"git://github.com/ellert/root.git","ssh_url":"git@github.com:ellert/root.git","clone_url":"https://github.com/ellert/root.git","svn_url":"https://github.com/ellert/root","homepage":"http://root.cern.ch","size":550416,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"root-mirror:master","ref":"master","sha":"bc8c6929e3a3fb14b52280129da26b0d98882689","user":{"login":"root-mirror","id":4849136,"avatar_url":"https://avatars.githubusercontent.com/u/4849136?v=3","gravatar_id":"","url":"https://api.github.com/users/root-mirror","html_url":"https://github.com/root-mirror","followers_url":"https://api.github.com/users/root-mirror/followers","following_url":"https://api.github.com/users/root-mirror/following{/other_user}","gists_url":"https://api.github.com/users/root-mirror/gists{/gist_id}","starred_url":"https://api.github.com/users/root-mirror/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-mirror/subscriptions","organizations_url":"https://api.github.com/users/root-mirror/orgs","repos_url":"https://api.github.com/users/root-mirror/repos","events_url":"https://api.github.com/users/root-mirror/events{/privacy}","received_events_url":"https://api.github.com/users/root-mirror/received_events","type":"Organization","site_admin":false},"repo":{"id":10994345,"name":"root","full_name":"root-mirror/root","owner":{"login":"root-mirror","id":4849136,"avatar_url":"https://avatars.githubusercontent.com/u/4849136?v=3","gravatar_id":"","url":"https://api.github.com/users/root-mirror","html_url":"https://github.com/root-mirror","followers_url":"https://api.github.com/users/root-mirror/followers","following_url":"https://api.github.com/users/root-mirror/following{/other_user}","gists_url":"https://api.github.com/users/root-mirror/gists{/gist_id}","starred_url":"https://api.github.com/users/root-mirror/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-mirror/subscriptions","organizations_url":"https://api.github.com/users/root-mirror/orgs","repos_url":"https://api.github.com/users/root-mirror/repos","events_url":"https://api.github.com/users/root-mirror/events{/privacy}","received_events_url":"https://api.github.com/users/root-mirror/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/root-mirror/root","description":"Mirror of official ROOT git repository","fork":false,"url":"https://api.github.com/repos/root-mirror/root","forks_url":"https://api.github.com/repos/root-mirror/root/forks","keys_url":"https://api.github.com/repos/root-mirror/root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/root-mirror/root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/root-mirror/root/teams","hooks_url":"https://api.github.com/repos/root-mirror/root/hooks","issue_events_url":"https://api.github.com/repos/root-mirror/root/issues/events{/number}","events_url":"https://api.github.com/repos/root-mirror/root/events","assignees_url":"https://api.github.com/repos/root-mirror/root/assignees{/user}","branches_url":"https://api.github.com/repos/root-mirror/root/branches{/branch}","tags_url":"https://api.github.com/repos/root-mirror/root/tags","blobs_url":"https://api.github.com/repos/root-mirror/root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/root-mirror/root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/root-mirror/root/git/refs{/sha}","trees_url":"https://api.github.com/repos/root-mirror/root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/root-mirror/root/statuses/{sha}","languages_url":"https://api.github.com/repos/root-mirror/root/languages","stargazers_url":"https://api.github.com/repos/root-mirror/root/stargazers","contributors_url":"https://api.github.com/repos/root-mirror/root/contributors","subscribers_url":"https://api.github.com/repos/root-mirror/root/subscribers","subscription_url":"https://api.github.com/repos/root-mirror/root/subscription","commits_url":"https://api.github.com/repos/root-mirror/root/commits{/sha}","git_commits_url":"https://api.github.com/repos/root-mirror/root/git/commits{/sha}","comments_url":"https://api.github.com/repos/root-mirror/root/comments{/number}","issue_comment_url":"https://api.github.com/repos/root-mirror/root/issues/comments{/number}","contents_url":"https://api.github.com/repos/root-mirror/root/contents/{+path}","compare_url":"https://api.github.com/repos/root-mirror/root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/root-mirror/root/merges","archive_url":"https://api.github.com/repos/root-mirror/root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/root-mirror/root/downloads","issues_url":"https://api.github.com/repos/root-mirror/root/issues{/number}","pulls_url":"https://api.github.com/repos/root-mirror/root/pulls{/number}","milestones_url":"https://api.github.com/repos/root-mirror/root/milestones{/number}","notifications_url":"https://api.github.com/repos/root-mirror/root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/root-mirror/root/labels{/name}","releases_url":"https://api.github.com/repos/root-mirror/root/releases{/id}","deployments_url":"https://api.github.com/repos/root-mirror/root/deployments","created_at":"2013-06-27T10:46:59Z","updated_at":"2016-02-02T09:14:45Z","pushed_at":"2016-02-04T08:49:25Z","git_url":"git://github.com/root-mirror/root.git","ssh_url":"git@github.com:root-mirror/root.git","clone_url":"https://github.com/root-mirror/root.git","svn_url":"https://github.com/root-mirror/root","homepage":"http://root.cern.ch","size":553196,"stargazers_count":159,"watchers_count":159,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":134,"mirror_url":null,"open_issues_count":29,"forks":134,"open_issues":29,"watchers":159,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/root-mirror/root/pulls/130"},"html":{"href":"https://github.com/root-mirror/root/pull/130"},"issue":{"href":"https://api.github.com/repos/root-mirror/root/issues/130"},"comments":{"href":"https://api.github.com/repos/root-mirror/root/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/root-mirror/root/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/root-mirror/root/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/root-mirror/root/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/root-mirror/root/statuses/fdbcd5e78824b54b2114ef19ce5fd033986f9fd9"}}}}