{"action":"created","issue":{"url":"https://api.github.com/repos/apollostack/apollo-client/issues/743","repository_url":"https://api.github.com/repos/apollostack/apollo-client","labels_url":"https://api.github.com/repos/apollostack/apollo-client/issues/743/labels{/name}","comments_url":"https://api.github.com/repos/apollostack/apollo-client/issues/743/comments","events_url":"https://api.github.com/repos/apollostack/apollo-client/issues/743/events","html_url":"https://github.com/apollostack/apollo-client/pull/743","id":180820884,"number":743,"title":"First implementation of observable to promise","user":{"login":"tmeasday","id":132554,"avatar_url":"https://avatars.githubusercontent.com/u/132554?v=3","gravatar_id":"","url":"https://api.github.com/users/tmeasday","html_url":"https://github.com/tmeasday","followers_url":"https://api.github.com/users/tmeasday/followers","following_url":"https://api.github.com/users/tmeasday/following{/other_user}","gists_url":"https://api.github.com/users/tmeasday/gists{/gist_id}","starred_url":"https://api.github.com/users/tmeasday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmeasday/subscriptions","organizations_url":"https://api.github.com/users/tmeasday/orgs","repos_url":"https://api.github.com/users/tmeasday/repos","events_url":"https://api.github.com/users/tmeasday/events{/privacy}","received_events_url":"https://api.github.com/users/tmeasday/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"helfer","id":6569980,"avatar_url":"https://avatars.githubusercontent.com/u/6569980?v=3","gravatar_id":"","url":"https://api.github.com/users/helfer","html_url":"https://github.com/helfer","followers_url":"https://api.github.com/users/helfer/followers","following_url":"https://api.github.com/users/helfer/following{/other_user}","gists_url":"https://api.github.com/users/helfer/gists{/gist_id}","starred_url":"https://api.github.com/users/helfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helfer/subscriptions","organizations_url":"https://api.github.com/users/helfer/orgs","repos_url":"https://api.github.com/users/helfer/repos","events_url":"https://api.github.com/users/helfer/events{/privacy}","received_events_url":"https://api.github.com/users/helfer/received_events","type":"User","site_admin":false},"assignees":[{"login":"helfer","id":6569980,"avatar_url":"https://avatars.githubusercontent.com/u/6569980?v=3","gravatar_id":"","url":"https://api.github.com/users/helfer","html_url":"https://github.com/helfer","followers_url":"https://api.github.com/users/helfer/followers","following_url":"https://api.github.com/users/helfer/following{/other_user}","gists_url":"https://api.github.com/users/helfer/gists{/gist_id}","starred_url":"https://api.github.com/users/helfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helfer/subscriptions","organizations_url":"https://api.github.com/users/helfer/orgs","repos_url":"https://api.github.com/users/helfer/repos","events_url":"https://api.github.com/users/helfer/events{/privacy}","received_events_url":"https://api.github.com/users/helfer/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-10-04T07:14:57Z","updated_at":"2016-10-04T21:13:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apollostack/apollo-client/pulls/743","html_url":"https://github.com/apollostack/apollo-client/pull/743","diff_url":"https://github.com/apollostack/apollo-client/pull/743.diff","patch_url":"https://github.com/apollostack/apollo-client/pull/743.patch"},"body":"@helfer I was thinking about how it's awkward to pass `done` around and how mocha is much more suited to dealing with promises, and I figured out a way to turn something that fires multiple times (like an observable) into a promise that resolves or rejects.\r\n\r\nWhat do you think? Does it make it hard to understand what the tests are doing?\r\n\r\nThese two sample tests are pretty much unmodified by the change (in terms of what they do)."},"comment":{"url":"https://api.github.com/repos/apollostack/apollo-client/issues/comments/251515539","html_url":"https://github.com/apollostack/apollo-client/pull/743#issuecomment-251515539","issue_url":"https://api.github.com/repos/apollostack/apollo-client/issues/743","id":251515539,"user":{"login":"tmeasday","id":132554,"avatar_url":"https://avatars.githubusercontent.com/u/132554?v=3","gravatar_id":"","url":"https://api.github.com/users/tmeasday","html_url":"https://github.com/tmeasday","followers_url":"https://api.github.com/users/tmeasday/followers","following_url":"https://api.github.com/users/tmeasday/following{/other_user}","gists_url":"https://api.github.com/users/tmeasday/gists{/gist_id}","starred_url":"https://api.github.com/users/tmeasday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmeasday/subscriptions","organizations_url":"https://api.github.com/users/tmeasday/orgs","repos_url":"https://api.github.com/users/tmeasday/repos","events_url":"https://api.github.com/users/tmeasday/events{/privacy}","received_events_url":"https://api.github.com/users/tmeasday/received_events","type":"User","site_admin":false},"created_at":"2016-10-04T21:13:45Z","updated_at":"2016-10-04T21:13:45Z","body":"I just wanted to leave the `refactor-tests` branch mergeable (which it is). \r\n\r\nIf we like this I'll start using it instead when refactoring tests"}}
{"actor":{"display_login":"tmeasday"}}