{"action":"created","issue":{"url":"https://api.github.com/repos/Zasilkovna/virtuemart3/issues/4","repository_url":"https://api.github.com/repos/Zasilkovna/virtuemart3","labels_url":"https://api.github.com/repos/Zasilkovna/virtuemart3/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/Zasilkovna/virtuemart3/issues/4/comments","events_url":"https://api.github.com/repos/Zasilkovna/virtuemart3/issues/4/events","html_url":"https://github.com/Zasilkovna/virtuemart3/issues/4","id":180309578,"number":4,"title":"Plugin is not compatible with any other plugin !","user":{"login":"stAn47","id":3664914,"avatar_url":"https://avatars.githubusercontent.com/u/3664914?v=3","gravatar_id":"","url":"https://api.github.com/users/stAn47","html_url":"https://github.com/stAn47","followers_url":"https://api.github.com/users/stAn47/followers","following_url":"https://api.github.com/users/stAn47/following{/other_user}","gists_url":"https://api.github.com/users/stAn47/gists{/gist_id}","starred_url":"https://api.github.com/users/stAn47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stAn47/subscriptions","organizations_url":"https://api.github.com/users/stAn47/orgs","repos_url":"https://api.github.com/users/stAn47/repos","events_url":"https://api.github.com/users/stAn47/events{/privacy}","received_events_url":"https://api.github.com/users/stAn47/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Zasilkovna/virtuemart3/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/Zasilkovna/virtuemart3/labels/help%20wanted","name":"help wanted","color":"159818"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-30T13:54:04Z","updated_at":"2016-09-30T15:45:14Z","closed_at":null,"body":"Plugin is not compatible with any other plugin !\r\nsince the function \r\n\r\nplgVmOnSelectCheckShipment\r\n\r\nis executed per all enabled Joomla plugins even when they are not configured in Virtuemart, zasilkovna plugin rewrites the virtumeart_payment_id even when it is not used at all, (not configured in Virtuemart but still enabled in Joomla)\r\n\r\nsuggested update: \r\n```\r\n\r\npublic function plgVmOnSelectCheckShipment(VirtueMartCart &$cart)\r\n\t{\r\n\t\t// these 2 functions will make sure that this plugin won't interfere with the 3rd party shipment methods\r\n\t\tif (!$this->selectedThisByMethodId ($cart->virtuemart_shipmentmethod_id)) {\r\n\t\t\treturn NULL; // Another method was selected, do nothing\r\n\t\t}\r\n\t\tif (!($method = $this->getVmPluginMethod ($cart->virtuemart_shipmentmethod_id))) {\r\n\t\t\treturn NULL; // Another method was selected, do nothing\r\n\t\t}\r\n\t\tif ($this->OnSelectCheck($cart)) {\r\n\t\t// init the session if not yet initialized: \r\n\t\t   $session = JFactory::getSession(); \r\n\t\t\r\n\t\tif ($this->OnSelectCheck($cart)) {\r\n\t\t\t$session->set('branch_id', JRequest::getInt('branch_id', 0));\r\n\t\t\t$session->set('branch_currency', JRequest::getVar('branch_currency', ''));\r\n\t\t\t$session->set('branch_name_street', JRequest::getVar('branch_name_street', ''));\r\n\t\t\t\r\n\t\t} \r\n\t\t\r\n\t\t// this will break any 3rd party plugins: \r\n\t\t//$cart->virtuemart_paymentmethod_id = 0;//reset selected payment. Payment options are shown depending on selected shipment\r\n\t\t    return true; \r\n\t\t}\r\n\t\t\r\n\t\treturn false; \r\n\t\t\r\n\t\t\r\n\t}\r\n\r\n```"},"comment":{"url":"https://api.github.com/repos/Zasilkovna/virtuemart3/issues/comments/250779313","html_url":"https://github.com/Zasilkovna/virtuemart3/issues/4#issuecomment-250779313","issue_url":"https://api.github.com/repos/Zasilkovna/virtuemart3/issues/4","id":250779313,"user":{"login":"matyx","id":7956225,"avatar_url":"https://avatars.githubusercontent.com/u/7956225?v=3","gravatar_id":"","url":"https://api.github.com/users/matyx","html_url":"https://github.com/matyx","followers_url":"https://api.github.com/users/matyx/followers","following_url":"https://api.github.com/users/matyx/following{/other_user}","gists_url":"https://api.github.com/users/matyx/gists{/gist_id}","starred_url":"https://api.github.com/users/matyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matyx/subscriptions","organizations_url":"https://api.github.com/users/matyx/orgs","repos_url":"https://api.github.com/users/matyx/repos","events_url":"https://api.github.com/users/matyx/events{/privacy}","received_events_url":"https://api.github.com/users/matyx/received_events","type":"User","site_admin":false},"created_at":"2016-09-30T15:45:14Z","updated_at":"2016-09-30T15:45:14Z","body":"Thanks for contributing, we will take a look on it next week"}}
{"actor":{"display_login":"matyx"}}