{"action":"created","issue":{"url":"https://api.github.com/repos/yuri-karadzhov/glsl-template-loader/issues/1","repository_url":"https://api.github.com/repos/yuri-karadzhov/glsl-template-loader","labels_url":"https://api.github.com/repos/yuri-karadzhov/glsl-template-loader/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/yuri-karadzhov/glsl-template-loader/issues/1/comments","events_url":"https://api.github.com/repos/yuri-karadzhov/glsl-template-loader/issues/1/events","html_url":"https://github.com/yuri-karadzhov/glsl-template-loader/pull/1","id":177909713,"number":1,"title":"Fixes","user":{"login":"yofreke","id":536581,"avatar_url":"https://avatars.githubusercontent.com/u/536581?v=3","gravatar_id":"","url":"https://api.github.com/users/yofreke","html_url":"https://github.com/yofreke","followers_url":"https://api.github.com/users/yofreke/followers","following_url":"https://api.github.com/users/yofreke/following{/other_user}","gists_url":"https://api.github.com/users/yofreke/gists{/gist_id}","starred_url":"https://api.github.com/users/yofreke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yofreke/subscriptions","organizations_url":"https://api.github.com/users/yofreke/orgs","repos_url":"https://api.github.com/users/yofreke/repos","events_url":"https://api.github.com/users/yofreke/events{/privacy}","received_events_url":"https://api.github.com/users/yofreke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-19T21:59:50Z","updated_at":"2016-09-26T15:34:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/yuri-karadzhov/glsl-template-loader/pulls/1","html_url":"https://github.com/yuri-karadzhov/glsl-template-loader/pull/1","diff_url":"https://github.com/yuri-karadzhov/glsl-template-loader/pull/1.diff","patch_url":"https://github.com/yuri-karadzhov/glsl-template-loader/pull/1.patch"},"body":"- Fix es6 param format for use with LTS\r\n- Babel output source for better browser compatibility (template literals are not yet fully adopted)\r\n- Better promise errors by using bluebird\r\n- Better source parsing with glsl-man instead of regex\r\n- Better error logging with chalk\r\n- Proper module resolution using webpack\r\n- Updated Readme\r\n- Sweet error logs (see below)\r\n\r\n<img width=\"519\" alt=\"screenshot 2016-09-22 17 19 57\" src=\"https://cloud.githubusercontent.com/assets/536581/18770289/61e4f0b2-80e9-11e6-892d-f6b0359ceb5c.png\">\r\n"},"comment":{"url":"https://api.github.com/repos/yuri-karadzhov/glsl-template-loader/issues/comments/249606328","html_url":"https://github.com/yuri-karadzhov/glsl-template-loader/pull/1#issuecomment-249606328","issue_url":"https://api.github.com/repos/yuri-karadzhov/glsl-template-loader/issues/1","id":249606328,"user":{"login":"yofreke","id":536581,"avatar_url":"https://avatars.githubusercontent.com/u/536581?v=3","gravatar_id":"","url":"https://api.github.com/users/yofreke","html_url":"https://github.com/yofreke","followers_url":"https://api.github.com/users/yofreke/followers","following_url":"https://api.github.com/users/yofreke/following{/other_user}","gists_url":"https://api.github.com/users/yofreke/gists{/gist_id}","starred_url":"https://api.github.com/users/yofreke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yofreke/subscriptions","organizations_url":"https://api.github.com/users/yofreke/orgs","repos_url":"https://api.github.com/users/yofreke/repos","events_url":"https://api.github.com/users/yofreke/events{/privacy}","received_events_url":"https://api.github.com/users/yofreke/received_events","type":"User","site_admin":false},"created_at":"2016-09-26T15:34:53Z","updated_at":"2016-09-26T15:34:53Z","body":">We use promises just for better api to load files, I think that should work fine with native promices too, we won't have complex errors here (file not found probably the only one we should care about).\r\n\r\nThat is very optimistic.  The problem I was having is a failure inside of `readFile` would not propagate up to the `catch` [here](https://github.com/yuri-karadzhov/glsl-template-loader/blob/master/index.js#L38).\r\n\r\nUntil I can rely on native promise implementations to work all of the time, and not silently fail, I ship bluebird.  The entire [readFile](https://github.com/yuri-karadzhov/glsl-template-loader/blob/master/index.js#L8) function could have been easily replaced by [bluebirds promisify](http://bluebirdjs.com/docs/api/promise.promisify.html).  Native promises have not yet caught up.\r\n\r\nI'm currently using this fork at work, so I really cant revert bluebird.  I can perhaps pull that out if you want, in favor of native promises, but no guarantee on the timeframe.\r\n\r\n>we still need to support es6 template strings\r\n\r\nTemplate literals are [supported in node LTS](http://node.green/#template-literals), no need to transform them."}}
{"actor":{"display_login":"yofreke"}}