{"action":"created","issue":{"url":"https://api.github.com/repos/Anachron/i3blocks/issues/25","repository_url":"https://api.github.com/repos/Anachron/i3blocks","labels_url":"https://api.github.com/repos/Anachron/i3blocks/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/Anachron/i3blocks/issues/25/comments","events_url":"https://api.github.com/repos/Anachron/i3blocks/issues/25/events","html_url":"https://github.com/Anachron/i3blocks/pull/25","id":175478893,"number":25,"title":"evaluate pacman line count directly","user":{"login":"dmfay","id":3075455,"avatar_url":"https://avatars.githubusercontent.com/u/3075455?v=3","gravatar_id":"","url":"https://api.github.com/users/dmfay","html_url":"https://github.com/dmfay","followers_url":"https://api.github.com/users/dmfay/followers","following_url":"https://api.github.com/users/dmfay/following{/other_user}","gists_url":"https://api.github.com/users/dmfay/gists{/gist_id}","starred_url":"https://api.github.com/users/dmfay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmfay/subscriptions","organizations_url":"https://api.github.com/users/dmfay/orgs","repos_url":"https://api.github.com/users/dmfay/repos","events_url":"https://api.github.com/users/dmfay/events{/privacy}","received_events_url":"https://api.github.com/users/dmfay/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-07T11:28:38Z","updated_at":"2016-10-13T10:47:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Anachron/i3blocks/pulls/25","html_url":"https://github.com/Anachron/i3blocks/pull/25","diff_url":"https://github.com/Anachron/i3blocks/pull/25.diff","patch_url":"https://github.com/Anachron/i3blocks/pull/25.patch"},"body":"I noticed the blocklet reporting 1 update even when `pacman -Qu` returned no names -- turned out that even though `$PACKAGES` was properly empty, echoing it appended a newline which got picked up by `wc`."},"comment":{"url":"https://api.github.com/repos/Anachron/i3blocks/issues/comments/253479650","html_url":"https://github.com/Anachron/i3blocks/pull/25#issuecomment-253479650","issue_url":"https://api.github.com/repos/Anachron/i3blocks/issues/25","id":253479650,"user":{"login":"egolus","id":6723020,"avatar_url":"https://avatars.githubusercontent.com/u/6723020?v=3","gravatar_id":"","url":"https://api.github.com/users/egolus","html_url":"https://github.com/egolus","followers_url":"https://api.github.com/users/egolus/followers","following_url":"https://api.github.com/users/egolus/following{/other_user}","gists_url":"https://api.github.com/users/egolus/gists{/gist_id}","starred_url":"https://api.github.com/users/egolus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egolus/subscriptions","organizations_url":"https://api.github.com/users/egolus/orgs","repos_url":"https://api.github.com/users/egolus/repos","events_url":"https://api.github.com/users/egolus/events{/privacy}","received_events_url":"https://api.github.com/users/egolus/received_events","type":"User","site_admin":false},"created_at":"2016-10-13T10:47:16Z","updated_at":"2016-10-13T10:47:16Z","body":"The check on [line 7](https://github.com/Anachron/i3blocks/pull/25/files#diff-e0535023e5acf8cc8974154295d02d60L7) should have tested for no packages but tested the return value for the variable assignment of `URGENT_VALUE` instead. You should either take it out completely (if you want to use pacman directly) or put the variable assignment in the head of the script so the check comes directly after the pacman call. (there's also the problem that `return` doesn't work there, it should be an `exit`)"}}
{"actor":{"display_login":"egolus"}}