{"action":"created","comment":{"url":"https://api.github.com/repos/baidu/bfs/pulls/comments/77429946","id":77429946,"diff_hunk":"@@ -455,11 +457,10 @@ bool ChunkServerManager::UpdateChunkServer(int cs_id, const std::string& tag, in\n         info->set_status(kCsActive);\n     }\n     info->set_kick(false);\n-    if (info->is_dead()) {\n+    if (info->status() == kCsOffline) {","path":"src/nameserver/chunkserver_manager.cc","position":63,"original_position":63,"commit_id":"8bd97cd6a9102dfe4636a3b6a6948a6d52cdbd48","original_commit_id":"8bd97cd6a9102dfe4636a3b6a6948a6d52cdbd48","user":{"login":"bluebore","id":6851389,"avatar_url":"https://avatars.githubusercontent.com/u/6851389?v=3","gravatar_id":"","url":"https://api.github.com/users/bluebore","html_url":"https://github.com/bluebore","followers_url":"https://api.github.com/users/bluebore/followers","following_url":"https://api.github.com/users/bluebore/following{/other_user}","gists_url":"https://api.github.com/users/bluebore/gists{/gist_id}","starred_url":"https://api.github.com/users/bluebore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluebore/subscriptions","organizations_url":"https://api.github.com/users/bluebore/orgs","repos_url":"https://api.github.com/users/bluebore/repos","events_url":"https://api.github.com/users/bluebore/events{/privacy}","received_events_url":"https://api.github.com/users/bluebore/received_events","type":"User","site_admin":false},"body":"这里不应该把cs状态改了么？","created_at":"2016-09-03T02:50:04Z","updated_at":"2016-09-03T02:50:04Z","html_url":"https://github.com/baidu/bfs/pull/469#discussion_r77429946","pull_request_url":"https://api.github.com/repos/baidu/bfs/pulls/469","_links":{"self":{"href":"https://api.github.com/repos/baidu/bfs/pulls/comments/77429946"},"html":{"href":"https://github.com/baidu/bfs/pull/469#discussion_r77429946"},"pull_request":{"href":"https://api.github.com/repos/baidu/bfs/pulls/469"}}},"pull_request":{"url":"https://api.github.com/repos/baidu/bfs/pulls/469","id":83761014,"html_url":"https://github.com/baidu/bfs/pull/469","diff_url":"https://github.com/baidu/bfs/pull/469.diff","patch_url":"https://github.com/baidu/bfs/pull/469.patch","issue_url":"https://api.github.com/repos/baidu/bfs/issues/469","number":469,"state":"open","locked":false,"title":"Remove is_dead","user":{"login":"yvxiang","id":1382038,"avatar_url":"https://avatars.githubusercontent.com/u/1382038?v=3","gravatar_id":"","url":"https://api.github.com/users/yvxiang","html_url":"https://github.com/yvxiang","followers_url":"https://api.github.com/users/yvxiang/followers","following_url":"https://api.github.com/users/yvxiang/following{/other_user}","gists_url":"https://api.github.com/users/yvxiang/gists{/gist_id}","starred_url":"https://api.github.com/users/yvxiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yvxiang/subscriptions","organizations_url":"https://api.github.com/users/yvxiang/orgs","repos_url":"https://api.github.com/users/yvxiang/repos","events_url":"https://api.github.com/users/yvxiang/events{/privacy}","received_events_url":"https://api.github.com/users/yvxiang/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-02T08:08:16Z","updated_at":"2016-09-03T02:50:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73b313a799e8cc9ab1da7ac565b4f5bea0679d52","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/baidu/bfs/pulls/469/commits","review_comments_url":"https://api.github.com/repos/baidu/bfs/pulls/469/comments","review_comment_url":"https://api.github.com/repos/baidu/bfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/baidu/bfs/issues/469/comments","statuses_url":"https://api.github.com/repos/baidu/bfs/statuses/8bd97cd6a9102dfe4636a3b6a6948a6d52cdbd48","head":{"label":"yvxiang:remove_dead","ref":"remove_dead","sha":"8bd97cd6a9102dfe4636a3b6a6948a6d52cdbd48","user":{"login":"yvxiang","id":1382038,"avatar_url":"https://avatars.githubusercontent.com/u/1382038?v=3","gravatar_id":"","url":"https://api.github.com/users/yvxiang","html_url":"https://github.com/yvxiang","followers_url":"https://api.github.com/users/yvxiang/followers","following_url":"https://api.github.com/users/yvxiang/following{/other_user}","gists_url":"https://api.github.com/users/yvxiang/gists{/gist_id}","starred_url":"https://api.github.com/users/yvxiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yvxiang/subscriptions","organizations_url":"https://api.github.com/users/yvxiang/orgs","repos_url":"https://api.github.com/users/yvxiang/repos","events_url":"https://api.github.com/users/yvxiang/events{/privacy}","received_events_url":"https://api.github.com/users/yvxiang/received_events","type":"User","site_admin":false},"repo":{"id":32985190,"name":"dfs","full_name":"yvxiang/dfs","owner":{"login":"yvxiang","id":1382038,"avatar_url":"https://avatars.githubusercontent.com/u/1382038?v=3","gravatar_id":"","url":"https://api.github.com/users/yvxiang","html_url":"https://github.com/yvxiang","followers_url":"https://api.github.com/users/yvxiang/followers","following_url":"https://api.github.com/users/yvxiang/following{/other_user}","gists_url":"https://api.github.com/users/yvxiang/gists{/gist_id}","starred_url":"https://api.github.com/users/yvxiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yvxiang/subscriptions","organizations_url":"https://api.github.com/users/yvxiang/orgs","repos_url":"https://api.github.com/users/yvxiang/repos","events_url":"https://api.github.com/users/yvxiang/events{/privacy}","received_events_url":"https://api.github.com/users/yvxiang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yvxiang/dfs","description":"突然想写个分布式文件系统~","fork":true,"url":"https://api.github.com/repos/yvxiang/dfs","forks_url":"https://api.github.com/repos/yvxiang/dfs/forks","keys_url":"https://api.github.com/repos/yvxiang/dfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yvxiang/dfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yvxiang/dfs/teams","hooks_url":"https://api.github.com/repos/yvxiang/dfs/hooks","issue_events_url":"https://api.github.com/repos/yvxiang/dfs/issues/events{/number}","events_url":"https://api.github.com/repos/yvxiang/dfs/events","assignees_url":"https://api.github.com/repos/yvxiang/dfs/assignees{/user}","branches_url":"https://api.github.com/repos/yvxiang/dfs/branches{/branch}","tags_url":"https://api.github.com/repos/yvxiang/dfs/tags","blobs_url":"https://api.github.com/repos/yvxiang/dfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yvxiang/dfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yvxiang/dfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/yvxiang/dfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yvxiang/dfs/statuses/{sha}","languages_url":"https://api.github.com/repos/yvxiang/dfs/languages","stargazers_url":"https://api.github.com/repos/yvxiang/dfs/stargazers","contributors_url":"https://api.github.com/repos/yvxiang/dfs/contributors","subscribers_url":"https://api.github.com/repos/yvxiang/dfs/subscribers","subscription_url":"https://api.github.com/repos/yvxiang/dfs/subscription","commits_url":"https://api.github.com/repos/yvxiang/dfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/yvxiang/dfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/yvxiang/dfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/yvxiang/dfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/yvxiang/dfs/contents/{+path}","compare_url":"https://api.github.com/repos/yvxiang/dfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yvxiang/dfs/merges","archive_url":"https://api.github.com/repos/yvxiang/dfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yvxiang/dfs/downloads","issues_url":"https://api.github.com/repos/yvxiang/dfs/issues{/number}","pulls_url":"https://api.github.com/repos/yvxiang/dfs/pulls{/number}","milestones_url":"https://api.github.com/repos/yvxiang/dfs/milestones{/number}","notifications_url":"https://api.github.com/repos/yvxiang/dfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yvxiang/dfs/labels{/name}","releases_url":"https://api.github.com/repos/yvxiang/dfs/releases{/id}","deployments_url":"https://api.github.com/repos/yvxiang/dfs/deployments","created_at":"2015-03-27T12:37:26Z","updated_at":"2016-01-12T10:38:47Z","pushed_at":"2016-09-02T11:39:15Z","git_url":"git://github.com/yvxiang/dfs.git","ssh_url":"git@github.com:yvxiang/dfs.git","clone_url":"https://github.com/yvxiang/dfs.git","svn_url":"https://github.com/yvxiang/dfs","homepage":null,"size":11280,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"baidu:master","ref":"master","sha":"02394be47e40e997c99718b421025829e1616967","user":{"login":"baidu","id":13245940,"avatar_url":"https://avatars.githubusercontent.com/u/13245940?v=3","gravatar_id":"","url":"https://api.github.com/users/baidu","html_url":"https://github.com/baidu","followers_url":"https://api.github.com/users/baidu/followers","following_url":"https://api.github.com/users/baidu/following{/other_user}","gists_url":"https://api.github.com/users/baidu/gists{/gist_id}","starred_url":"https://api.github.com/users/baidu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baidu/subscriptions","organizations_url":"https://api.github.com/users/baidu/orgs","repos_url":"https://api.github.com/users/baidu/repos","events_url":"https://api.github.com/users/baidu/events{/privacy}","received_events_url":"https://api.github.com/users/baidu/received_events","type":"Organization","site_admin":false},"repo":{"id":26562172,"name":"bfs","full_name":"baidu/bfs","owner":{"login":"baidu","id":13245940,"avatar_url":"https://avatars.githubusercontent.com/u/13245940?v=3","gravatar_id":"","url":"https://api.github.com/users/baidu","html_url":"https://github.com/baidu","followers_url":"https://api.github.com/users/baidu/followers","following_url":"https://api.github.com/users/baidu/following{/other_user}","gists_url":"https://api.github.com/users/baidu/gists{/gist_id}","starred_url":"https://api.github.com/users/baidu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baidu/subscriptions","organizations_url":"https://api.github.com/users/baidu/orgs","repos_url":"https://api.github.com/users/baidu/repos","events_url":"https://api.github.com/users/baidu/events{/privacy}","received_events_url":"https://api.github.com/users/baidu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/baidu/bfs","description":"The Baidu File System.","fork":false,"url":"https://api.github.com/repos/baidu/bfs","forks_url":"https://api.github.com/repos/baidu/bfs/forks","keys_url":"https://api.github.com/repos/baidu/bfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/baidu/bfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/baidu/bfs/teams","hooks_url":"https://api.github.com/repos/baidu/bfs/hooks","issue_events_url":"https://api.github.com/repos/baidu/bfs/issues/events{/number}","events_url":"https://api.github.com/repos/baidu/bfs/events","assignees_url":"https://api.github.com/repos/baidu/bfs/assignees{/user}","branches_url":"https://api.github.com/repos/baidu/bfs/branches{/branch}","tags_url":"https://api.github.com/repos/baidu/bfs/tags","blobs_url":"https://api.github.com/repos/baidu/bfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/baidu/bfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/baidu/bfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/baidu/bfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/baidu/bfs/statuses/{sha}","languages_url":"https://api.github.com/repos/baidu/bfs/languages","stargazers_url":"https://api.github.com/repos/baidu/bfs/stargazers","contributors_url":"https://api.github.com/repos/baidu/bfs/contributors","subscribers_url":"https://api.github.com/repos/baidu/bfs/subscribers","subscription_url":"https://api.github.com/repos/baidu/bfs/subscription","commits_url":"https://api.github.com/repos/baidu/bfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/baidu/bfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/baidu/bfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/baidu/bfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/baidu/bfs/contents/{+path}","compare_url":"https://api.github.com/repos/baidu/bfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/baidu/bfs/merges","archive_url":"https://api.github.com/repos/baidu/bfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/baidu/bfs/downloads","issues_url":"https://api.github.com/repos/baidu/bfs/issues{/number}","pulls_url":"https://api.github.com/repos/baidu/bfs/pulls{/number}","milestones_url":"https://api.github.com/repos/baidu/bfs/milestones{/number}","notifications_url":"https://api.github.com/repos/baidu/bfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/baidu/bfs/labels{/name}","releases_url":"https://api.github.com/repos/baidu/bfs/releases{/id}","deployments_url":"https://api.github.com/repos/baidu/bfs/deployments","created_at":"2014-11-13T00:00:29Z","updated_at":"2016-09-02T23:14:21Z","pushed_at":"2016-09-02T11:39:15Z","git_url":"git://github.com/baidu/bfs.git","ssh_url":"git@github.com:baidu/bfs.git","clone_url":"https://github.com/baidu/bfs.git","svn_url":"https://github.com/baidu/bfs","homepage":"","size":11876,"stargazers_count":52,"watchers_count":52,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":77,"forks":30,"open_issues":77,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/baidu/bfs/pulls/469"},"html":{"href":"https://github.com/baidu/bfs/pull/469"},"issue":{"href":"https://api.github.com/repos/baidu/bfs/issues/469"},"comments":{"href":"https://api.github.com/repos/baidu/bfs/issues/469/comments"},"review_comments":{"href":"https://api.github.com/repos/baidu/bfs/pulls/469/comments"},"review_comment":{"href":"https://api.github.com/repos/baidu/bfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/baidu/bfs/pulls/469/commits"},"statuses":{"href":"https://api.github.com/repos/baidu/bfs/statuses/8bd97cd6a9102dfe4636a3b6a6948a6d52cdbd48"}}}}
{"actor":{"display_login":"bluebore"}}