{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10550","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10550/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10550/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10550/events","html_url":"https://github.com/ManageIQ/manageiq/pull/10550","id":171696300,"number":10550,"title":"Implement Vmware vCloud NetworkManager","user":{"login":"miha-plesko","id":8102426,"avatar_url":"https://avatars.githubusercontent.com/u/8102426?v=3","gravatar_id":"","url":"https://api.github.com/users/miha-plesko","html_url":"https://github.com/miha-plesko","followers_url":"https://api.github.com/users/miha-plesko/followers","following_url":"https://api.github.com/users/miha-plesko/following{/other_user}","gists_url":"https://api.github.com/users/miha-plesko/gists{/gist_id}","starred_url":"https://api.github.com/users/miha-plesko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miha-plesko/subscriptions","organizations_url":"https://api.github.com/users/miha-plesko/orgs","repos_url":"https://api.github.com/users/miha-plesko/repos","events_url":"https://api.github.com/users/miha-plesko/events{/privacy}","received_events_url":"https://api.github.com/users/miha-plesko/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/providers/network","name":"providers/network","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/providers/vmware/cloud","name":"providers/vmware/cloud","color":"5319e7"}],"state":"open","locked":false,"assignee":{"login":"blomquisg","id":14183,"avatar_url":"https://avatars.githubusercontent.com/u/14183?v=3","gravatar_id":"","url":"https://api.github.com/users/blomquisg","html_url":"https://github.com/blomquisg","followers_url":"https://api.github.com/users/blomquisg/followers","following_url":"https://api.github.com/users/blomquisg/following{/other_user}","gists_url":"https://api.github.com/users/blomquisg/gists{/gist_id}","starred_url":"https://api.github.com/users/blomquisg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blomquisg/subscriptions","organizations_url":"https://api.github.com/users/blomquisg/orgs","repos_url":"https://api.github.com/users/blomquisg/repos","events_url":"https://api.github.com/users/blomquisg/events{/privacy}","received_events_url":"https://api.github.com/users/blomquisg/received_events","type":"User","site_admin":false},"assignees":[{"login":"blomquisg","id":14183,"avatar_url":"https://avatars.githubusercontent.com/u/14183?v=3","gravatar_id":"","url":"https://api.github.com/users/blomquisg","html_url":"https://github.com/blomquisg","followers_url":"https://api.github.com/users/blomquisg/followers","following_url":"https://api.github.com/users/blomquisg/following{/other_user}","gists_url":"https://api.github.com/users/blomquisg/gists{/gist_id}","starred_url":"https://api.github.com/users/blomquisg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blomquisg/subscriptions","organizations_url":"https://api.github.com/users/blomquisg/orgs","repos_url":"https://api.github.com/users/blomquisg/repos","events_url":"https://api.github.com/users/blomquisg/events{/privacy}","received_events_url":"https://api.github.com/users/blomquisg/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-08-17T16:03:00Z","updated_at":"2016-08-18T07:56:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10550","html_url":"https://github.com/ManageIQ/manageiq/pull/10550","diff_url":"https://github.com/ManageIQ/manageiq/pull/10550.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/10550.patch"},"body":"Purpose or Intent\r\n-----------------\r\nThis patch adds basic NetworkManager functionality for the Vmware Cloud. Since FOG support is quite limited atm, most of the data is left empty. Network structure is fetched so that user can navigate thru cloud_networks, cloud_subnets, network_ports and eventually reach VMs.\r\n\r\nNOTE: Vmware Cloud does not support cloud_subnets therefore dummy values are used to comply with structure\r\n\r\nNOTE: Vmware Cloud does not have separate network manager so we share credentials with CloudManager."},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/240650834","html_url":"https://github.com/ManageIQ/manageiq/pull/10550#issuecomment-240650834","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10550","id":240650834,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2016-08-18T07:56:35Z","updated_at":"2016-08-18T07:56:35Z","body":"<rubocop />Checked commit https://github.com/xlab-si/manageiq/commit/75fbb1b8065baccf9a318da5d077f1c4db4ef93a with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1\n23 files checked, 18 offenses detected\n\n**app/models/manageiq/providers/vmware/network_manager/cloud_network/org_vdc_net.rb**\n- [ ] :grey_exclamation: - [Line 1](https://github.com/xlab-si/manageiq/blob/75fbb1b8065baccf9a318da5d077f1c4db4ef93a/app/models/manageiq/providers/vmware/network_manager/cloud_network/org_vdc_net.rb#L1), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [134/120]\n\n**app/models/manageiq/providers/vmware/network_manager/cloud_network/vapp_net.rb**\n- [ ] :grey_exclamation: - [Line 1](https://github.com/xlab-si/manageiq/blob/75fbb1b8065baccf9a318da5d077f1c4db4ef93a/app/models/manageiq/providers/vmware/network_manager/cloud_network/vapp_net.rb#L1), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [132/120]\n\n**app/models/manageiq/providers/vmware/network_manager/refresh_parser.rb**\n- [ ] :exclamation: - [Line 113](https://github.com/xlab-si/manageiq/blob/75fbb1b8065baccf9a318da5d077f1c4db4ef93a/app/models/manageiq/providers/vmware/network_manager/refresh_parser.rb#L113), Col 40 - [Performance/Detect](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Performance/Detect) - Use `find` instead of `select.first`.\n- [ ] :exclamation: - [Line 114](https://github.com/xlab-si/manageiq/blob/75fbb1b8065baccf9a318da5d077f1c4db4ef93a/app/models/manageiq/providers/vmware/network_manager/refresh_parser.rb#L114), Col 42 - [Performance/Detect](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Performance/Detect) - Use `find` instead of `select.first`.\n- [ ] :exclamation: - [Line 30](https://github.com/xlab-si/manageiq/blob/75fbb1b8065baccf9a318da5d077f1c4db4ef93a/app/models/manageiq/providers/vmware/network_manager/refresh_parser.rb#L30), Col 9 - [Style/AccessorMethodName](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/AccessorMethodName) - Do not prefix reader method names with `get_`.\n- [ ] :exclamation: - [Line 41](https://github.com/xlab-si/manageiq/blob/75fbb1b8065baccf9a318da5d077f1c4db4ef93a/app/models/manageiq/providers/vmware/network_manager/refresh_parser.rb#L41), Col 9 - [Style/AccessorMethodName](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/AccessorMethodName) - Do not prefix reader method names with `get_`.\n- [ ] :exclamation: - [Line 68](https://github.com/xlab-si/manageiq/blob/75fbb1b8065baccf9a318da5d077f1c4db4ef93a/app/models/manageiq/providers/vmware/network_manager/refresh_parser.rb#L68), Col 22 - [Style/MultilineTernaryOperator](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/MultilineTernaryOperator) - Avoid multi-line ?: (the ternary operator); use `if`/`unless` instead.\n- [ ] :grey_exclamation: - [Line 2](https://github.com/xlab-si/manageiq/blob/75fbb1b8065baccf9a318da5d077f1c4db4ef93a/app/models/manageiq/providers/vmware/network_manager/refresh_parser.rb#L2), Col 3 - [Metrics/ClassLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/ClassLength) - Class has too many lines. [152/100]\n- [ ] :grey_exclamation: - [Line 99](https://github.com/xlab-si/manageiq/blob/75fbb1b8065baccf9a318da5d077f1c4db4ef93a/app/models/manageiq/providers/vmware/network_manager/refresh_parser.rb#L99), Col 5 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for parse_network_port is too high. [28.48/20]\n\n**app/models/manageiq/providers/vmware/network_manager/refresh_worker/runner.rb**\n- [ ] :grey_exclamation: - [Line 1](https://github.com/xlab-si/manageiq/blob/75fbb1b8065baccf9a318da5d077f1c4db4ef93a/app/models/manageiq/providers/vmware/network_manager/refresh_worker/runner.rb#L1), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [130/120]\n\n**lib/miq_automation_engine/service_models/miq_ae_service_manageiq-providers-vmware-network_manager-cloud_network-org_vdc_net.rb**\n- [ ] :grey_exclamation: - [Line 2](https://github.com/xlab-si/manageiq/blob/75fbb1b8065baccf9a318da5d077f1c4db4ef93a/lib/miq_automation_engine/service_models/miq_ae_service_manageiq-providers-vmware-network_manager-cloud_network-org_vdc_net.rb#L2), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [151/120]\n\n**lib/miq_automation_engine/service_models/miq_ae_service_manageiq-providers-vmware-network_manager-cloud_network-vapp_net.rb**\n- [ ] :grey_exclamation: - [Line 2](https://github.com/xlab-si/manageiq/blob/75fbb1b8065baccf9a318da5d077f1c4db4ef93a/lib/miq_automation_engine/service_models/miq_ae_service_manageiq-providers-vmware-network_manager-cloud_network-vapp_net.rb#L2), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [149/120]\n\n**spec/models/manageiq/providers/vmware/cloud_manager/refresher_spec.rb**\n- [ ] :exclamation: - [Line 61](https://github.com/xlab-si/manageiq/blob/75fbb1b8065baccf9a318da5d077f1c4db4ef93a/spec/models/manageiq/providers/vmware/cloud_manager/refresher_spec.rb#L61), Col 47 - [Style/ExtraSpacing](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/ExtraSpacing) - Unnecessary spacing detected.\n\n**spec/models/manageiq/providers/vmware/network_manager/refresher_spec.rb**\n- [ ] :exclamation: - [Line 116](https://github.com/xlab-si/manageiq/blob/75fbb1b8065baccf9a318da5d077f1c4db4ef93a/spec/models/manageiq/providers/vmware/network_manager/refresher_spec.rb#L116), Col 31 - [Performance/Detect](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Performance/Detect) - Use `find` instead of `select.first`.\n- [ ] :exclamation: - [Line 87](https://github.com/xlab-si/manageiq/blob/75fbb1b8065baccf9a318da5d077f1c4db4ef93a/spec/models/manageiq/providers/vmware/network_manager/refresher_spec.rb#L87), Col 31 - [Performance/Detect](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Performance/Detect) - Use `find` instead of `select.first`.\n- [ ] :grey_exclamation: - [Line 62](https://github.com/xlab-si/manageiq/blob/75fbb1b8065baccf9a318da5d077f1c4db4ef93a/spec/models/manageiq/providers/vmware/network_manager/refresher_spec.rb#L62), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for assert_network_counts is too high. [22/20]\n- [ ] :grey_exclamation: - [Line 70](https://github.com/xlab-si/manageiq/blob/75fbb1b8065baccf9a318da5d077f1c4db4ef93a/spec/models/manageiq/providers/vmware/network_manager/refresher_spec.rb#L70), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for assert_specific_network_tree_vdc is too high. [41.19/20]\n- [ ] :grey_exclamation: - [Line 99](https://github.com/xlab-si/manageiq/blob/75fbb1b8065baccf9a318da5d077f1c4db4ef93a/spec/models/manageiq/providers/vmware/network_manager/refresher_spec.rb#L99), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for assert_specific_network_tree_vapp is too high. [41.19/20]\n"}}
{"actor":{"display_login":"miq-bot"}}