{"action":"created","issue":{"url":"https://api.github.com/repos/conda/conda-build/issues/861","repository_url":"https://api.github.com/repos/conda/conda-build","labels_url":"https://api.github.com/repos/conda/conda-build/issues/861/labels{/name}","comments_url":"https://api.github.com/repos/conda/conda-build/issues/861/comments","events_url":"https://api.github.com/repos/conda/conda-build/issues/861/events","html_url":"https://github.com/conda/conda-build/pull/861","id":145419835,"number":861,"title":"Attempting to improve the logic for VS on Win","user":{"login":"patricksnape","id":708474,"avatar_url":"https://avatars.githubusercontent.com/u/708474?v=3","gravatar_id":"","url":"https://api.github.com/users/patricksnape","html_url":"https://github.com/patricksnape","followers_url":"https://api.github.com/users/patricksnape/followers","following_url":"https://api.github.com/users/patricksnape/following{/other_user}","gists_url":"https://api.github.com/users/patricksnape/gists{/gist_id}","starred_url":"https://api.github.com/users/patricksnape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patricksnape/subscriptions","organizations_url":"https://api.github.com/users/patricksnape/orgs","repos_url":"https://api.github.com/users/patricksnape/repos","events_url":"https://api.github.com/users/patricksnape/events{/privacy}","received_events_url":"https://api.github.com/users/patricksnape/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2016-04-02T21:32:29Z","updated_at":"2016-04-06T06:18:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/conda/conda-build/pulls/861","html_url":"https://github.com/conda/conda-build/pull/861","diff_url":"https://github.com/conda/conda-build/pull/861.diff","patch_url":"https://github.com/conda/conda-build/pull/861.patch"},"body":"Both VS9 and VS10 do not work out of the box for 64-bit builds.\r\nThis should try and remedy that. For VS9 it prefers the\r\nMicrosoft Visual C++ Compiler for Python 2.7 and when\r\nfalling back VS9 will call the correct bat file manually, rather\r\nthan relying on the broken logic in vcvarsall.bat.\r\n\r\nFor VS10, it will correctly call the Windows SDK rather than\r\nrelying on the also potentially incorrect vcvarsall.bat.\r\n\r\nThis was pretty difficult to test in my VM because I broke\r\nit trying to test the different combinations. I need to create\r\na clean image and try each of the scenarios. \r\n\r\nWhat would be the best way to test this? I guess builds\r\nneed to be kicked off on Appveyor?"},"comment":{"url":"https://api.github.com/repos/conda/conda-build/issues/comments/206137276","html_url":"https://github.com/conda/conda-build/pull/861#issuecomment-206137276","issue_url":"https://api.github.com/repos/conda/conda-build/issues/861","id":206137276,"user":{"login":"patricksnape","id":708474,"avatar_url":"https://avatars.githubusercontent.com/u/708474?v=3","gravatar_id":"","url":"https://api.github.com/users/patricksnape","html_url":"https://github.com/patricksnape","followers_url":"https://api.github.com/users/patricksnape/followers","following_url":"https://api.github.com/users/patricksnape/following{/other_user}","gists_url":"https://api.github.com/users/patricksnape/gists{/gist_id}","starred_url":"https://api.github.com/users/patricksnape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patricksnape/subscriptions","organizations_url":"https://api.github.com/users/patricksnape/orgs","repos_url":"https://api.github.com/users/patricksnape/repos","events_url":"https://api.github.com/users/patricksnape/events{/privacy}","received_events_url":"https://api.github.com/users/patricksnape/received_events","type":"User","site_admin":false},"created_at":"2016-04-06T06:18:21Z","updated_at":"2016-04-06T06:18:21Z","body":"OK I had a look, agree with most of the changes. I can see where you are coming from w.r.t the VS 2008 Express changes - however, if we don't want to explicitly perform that, I believe we should maybe print a warning at least? Or I fear you will get a lot of people who will run into the error and start raising bugs - maybe we write it in the Wiki and then somehow direct people there? Or maybe when we detect a setup error in Windows at all we try and route them to the Wiki where we can answer many questions?"}}