{"action":"created","comment":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments/74314223","id":74314223,"diff_hunk":"@@ -30,4 +39,11 @@ export function assign(target: any, ...args) {\n   }\n \n   return target;\n-}\n\\ No newline at end of file\n+}\n+\n+/** Generates a unique id in the global scope (this spans across duplicate copies of the same library.) */\n+export function getId(prefix?: string): string {\n+  let index = _global[CURRENT_ID_PROPERTY]++;\n+\n+  return (prefix || '') + index;\n+}","path":"src/utilities/object.ts","position":26,"original_position":26,"commit_id":"f12c51b25688b35949319923b9bb1b1428a594f7","original_commit_id":"72e9387de986291ba2f52b2ab399ed407ef6994e","user":{"login":"dzearing","id":1110944,"avatar_url":"https://avatars.githubusercontent.com/u/1110944?v=3","gravatar_id":"","url":"https://api.github.com/users/dzearing","html_url":"https://github.com/dzearing","followers_url":"https://api.github.com/users/dzearing/followers","following_url":"https://api.github.com/users/dzearing/following{/other_user}","gists_url":"https://api.github.com/users/dzearing/gists{/gist_id}","starred_url":"https://api.github.com/users/dzearing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzearing/subscriptions","organizations_url":"https://api.github.com/users/dzearing/orgs","repos_url":"https://api.github.com/users/dzearing/repos","events_url":"https://api.github.com/users/dzearing/events{/privacy}","received_events_url":"https://api.github.com/users/dzearing/received_events","type":"User","site_admin":false},"body":"no. I will never enable that rule.\r\n","created_at":"2016-08-10T19:33:49Z","updated_at":"2016-08-10T19:33:49Z","html_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/112#discussion_r74314223","pull_request_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/112","_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments/74314223"},"html":{"href":"https://github.com/OfficeDev/office-ui-fabric-react/pull/112#discussion_r74314223"},"pull_request":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/112"}}},"pull_request":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/112","id":80841477,"html_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/112","diff_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/112.diff","patch_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/112.patch","issue_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/112","number":112,"state":"open","locked":false,"title":"Checkbox props implemented according to 'React consistency' discussion","user":{"login":"dzearing","id":1110944,"avatar_url":"https://avatars.githubusercontent.com/u/1110944?v=3","gravatar_id":"","url":"https://api.github.com/users/dzearing","html_url":"https://github.com/dzearing","followers_url":"https://api.github.com/users/dzearing/followers","following_url":"https://api.github.com/users/dzearing/following{/other_user}","gists_url":"https://api.github.com/users/dzearing/gists{/gist_id}","starred_url":"https://api.github.com/users/dzearing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzearing/subscriptions","organizations_url":"https://api.github.com/users/dzearing/orgs","repos_url":"https://api.github.com/users/dzearing/repos","events_url":"https://api.github.com/users/dzearing/events{/privacy}","received_events_url":"https://api.github.com/users/dzearing/received_events","type":"User","site_admin":false},"body":"The fundamental changes here are:\r\n\r\n* Checkbox props now take in more consistent parameters (checked, defaultChecked, onChange) that you would expect for an input element.\r\n\r\n* Checkbox also has an inputProps parameter to allow the caller to mix in additional settings on the input element, prior to us applying top-level params. This allows for a way to apply things like data-automation-id to the input element.\r\n\r\n* A utility \"getId\" has been added to object.ts to create globally unique ids that are even unique across duplicate copies of a module.\r\n","created_at":"2016-08-10T18:15:12Z","updated_at":"2016-08-10T19:33:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbc1bcec19d46bedba818d24d155cc6e5bc4c606","assignee":{"login":"cliffkoh","id":1003246,"avatar_url":"https://avatars.githubusercontent.com/u/1003246?v=3","gravatar_id":"","url":"https://api.github.com/users/cliffkoh","html_url":"https://github.com/cliffkoh","followers_url":"https://api.github.com/users/cliffkoh/followers","following_url":"https://api.github.com/users/cliffkoh/following{/other_user}","gists_url":"https://api.github.com/users/cliffkoh/gists{/gist_id}","starred_url":"https://api.github.com/users/cliffkoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cliffkoh/subscriptions","organizations_url":"https://api.github.com/users/cliffkoh/orgs","repos_url":"https://api.github.com/users/cliffkoh/repos","events_url":"https://api.github.com/users/cliffkoh/events{/privacy}","received_events_url":"https://api.github.com/users/cliffkoh/received_events","type":"User","site_admin":false},"assignees":[{"login":"cliffkoh","id":1003246,"avatar_url":"https://avatars.githubusercontent.com/u/1003246?v=3","gravatar_id":"","url":"https://api.github.com/users/cliffkoh","html_url":"https://github.com/cliffkoh","followers_url":"https://api.github.com/users/cliffkoh/followers","following_url":"https://api.github.com/users/cliffkoh/following{/other_user}","gists_url":"https://api.github.com/users/cliffkoh/gists{/gist_id}","starred_url":"https://api.github.com/users/cliffkoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cliffkoh/subscriptions","organizations_url":"https://api.github.com/users/cliffkoh/orgs","repos_url":"https://api.github.com/users/cliffkoh/repos","events_url":"https://api.github.com/users/cliffkoh/events{/privacy}","received_events_url":"https://api.github.com/users/cliffkoh/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/112/commits","review_comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/112/comments","review_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/112/comments","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/f12c51b25688b35949319923b9bb1b1428a594f7","head":{"label":"dzearing:checkbox-updates","ref":"checkbox-updates","sha":"f12c51b25688b35949319923b9bb1b1428a594f7","user":{"login":"dzearing","id":1110944,"avatar_url":"https://avatars.githubusercontent.com/u/1110944?v=3","gravatar_id":"","url":"https://api.github.com/users/dzearing","html_url":"https://github.com/dzearing","followers_url":"https://api.github.com/users/dzearing/followers","following_url":"https://api.github.com/users/dzearing/following{/other_user}","gists_url":"https://api.github.com/users/dzearing/gists{/gist_id}","starred_url":"https://api.github.com/users/dzearing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzearing/subscriptions","organizations_url":"https://api.github.com/users/dzearing/orgs","repos_url":"https://api.github.com/users/dzearing/repos","events_url":"https://api.github.com/users/dzearing/events{/privacy}","received_events_url":"https://api.github.com/users/dzearing/received_events","type":"User","site_admin":false},"repo":{"id":64567735,"name":"office-ui-fabric-react","full_name":"dzearing/office-ui-fabric-react","owner":{"login":"dzearing","id":1110944,"avatar_url":"https://avatars.githubusercontent.com/u/1110944?v=3","gravatar_id":"","url":"https://api.github.com/users/dzearing","html_url":"https://github.com/dzearing","followers_url":"https://api.github.com/users/dzearing/followers","following_url":"https://api.github.com/users/dzearing/following{/other_user}","gists_url":"https://api.github.com/users/dzearing/gists{/gist_id}","starred_url":"https://api.github.com/users/dzearing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzearing/subscriptions","organizations_url":"https://api.github.com/users/dzearing/orgs","repos_url":"https://api.github.com/users/dzearing/repos","events_url":"https://api.github.com/users/dzearing/events{/privacy}","received_events_url":"https://api.github.com/users/dzearing/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dzearing/office-ui-fabric-react","description":"React components for building experiences for Office and Office 365.","fork":true,"url":"https://api.github.com/repos/dzearing/office-ui-fabric-react","forks_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/forks","keys_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/teams","hooks_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/hooks","issue_events_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/issues/events{/number}","events_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/events","assignees_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/assignees{/user}","branches_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/branches{/branch}","tags_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/tags","blobs_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/statuses/{sha}","languages_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/languages","stargazers_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/stargazers","contributors_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/contributors","subscribers_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/subscribers","subscription_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/subscription","commits_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/contents/{+path}","compare_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/merges","archive_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/downloads","issues_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/issues{/number}","pulls_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/pulls{/number}","milestones_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/milestones{/number}","notifications_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/labels{/name}","releases_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/releases{/id}","deployments_url":"https://api.github.com/repos/dzearing/office-ui-fabric-react/deployments","created_at":"2016-07-30T23:09:24Z","updated_at":"2016-07-30T23:09:28Z","pushed_at":"2016-08-10T19:32:12Z","git_url":"git://github.com/dzearing/office-ui-fabric-react.git","ssh_url":"git@github.com:dzearing/office-ui-fabric-react.git","clone_url":"https://github.com/dzearing/office-ui-fabric-react.git","svn_url":"https://github.com/dzearing/office-ui-fabric-react","homepage":"http://dev.office.com/fabric","size":2095,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OfficeDev:master","ref":"master","sha":"4b9f1fb7e2d52b1eaf81851f0c717f15b57e4507","user":{"login":"OfficeDev","id":6789362,"avatar_url":"https://avatars.githubusercontent.com/u/6789362?v=3","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"repo":{"id":60537144,"name":"office-ui-fabric-react","full_name":"OfficeDev/office-ui-fabric-react","owner":{"login":"OfficeDev","id":6789362,"avatar_url":"https://avatars.githubusercontent.com/u/6789362?v=3","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OfficeDev/office-ui-fabric-react","description":"React components for building experiences for Office and Office 365.","fork":false,"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react","forks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/forks","keys_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/teams","hooks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/hooks","issue_events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/events{/number}","events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/events","assignees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/assignees{/user}","branches_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/branches{/branch}","tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/tags","blobs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/{sha}","languages_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/languages","stargazers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/stargazers","contributors_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contributors","subscribers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscribers","subscription_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscription","commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contents/{+path}","compare_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/merges","archive_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/downloads","issues_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues{/number}","pulls_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls{/number}","milestones_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/milestones{/number}","notifications_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/labels{/name}","releases_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/releases{/id}","deployments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/deployments","created_at":"2016-06-06T15:03:44Z","updated_at":"2016-08-10T09:02:29Z","pushed_at":"2016-08-10T19:32:13Z","git_url":"git://github.com/OfficeDev/office-ui-fabric-react.git","ssh_url":"git@github.com:OfficeDev/office-ui-fabric-react.git","clone_url":"https://github.com/OfficeDev/office-ui-fabric-react.git","svn_url":"https://github.com/OfficeDev/office-ui-fabric-react","homepage":"http://dev.office.com/fabric","size":2350,"stargazers_count":41,"watchers_count":41,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":36,"forks":19,"open_issues":36,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/112"},"html":{"href":"https://github.com/OfficeDev/office-ui-fabric-react/pull/112"},"issue":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/112"},"comments":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/112/comments"},"review_comments":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/112/comments"},"review_comment":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/112/commits"},"statuses":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/f12c51b25688b35949319923b9bb1b1428a594f7"}}}}
{"actor":{"display_login":"dzearing"}}