{"action":"created","comment":{"url":"https://api.github.com/repos/slimphp/Slim/pulls/comments/56200871","id":56200871,"diff_hunk":"@@ -162,6 +162,38 @@ public function testPathForWithQueryParameters()\n         );\n     }\n \n+    public function testPathForWithQueryParametersForPath()\n+    {\n+        $methods = ['GET'];\n+        $pattern = '/hello/{name}';\n+        $callable = function ($request, $response, $args) {\n+            echo sprintf('Hello %s', $args['name']);\n+        };\n+        $route = $this->router->map($methods, $pattern, $callable);\n+        $route->setName('foo');\n+\n+        $this->assertEquals(\n+            '/hello/josh?a=b',\n+            $this->router->pathFor('foo', [], ['name' => 'josh', 'a' => 'b'])\n+        );\n+    }\n+\n+    public function testPathForWithCombinedParameters()\n+    {\n+        $methods = ['GET'];\n+        $pattern = '/hello/{name}';\n+        $callable = function ($request, $response, $args) {\n+            echo sprintf('Hello %s', $args['name']);\n+        };\n+        $route = $this->router->map($methods, $pattern, $callable);\n+        $route->setName('foo');\n+\n+        $this->assertEquals(\n+            '/hello/josh?a=b',","path":"tests/RouterTest.php","position":49,"original_position":49,"commit_id":"4df82cb3860edd4159092434c74e5534c40d2a8c","original_commit_id":"4df82cb3860edd4159092434c74e5534c40d2a8c","user":{"login":"campersau","id":4009570,"avatar_url":"https://avatars.githubusercontent.com/u/4009570?v=3","gravatar_id":"","url":"https://api.github.com/users/campersau","html_url":"https://github.com/campersau","followers_url":"https://api.github.com/users/campersau/followers","following_url":"https://api.github.com/users/campersau/following{/other_user}","gists_url":"https://api.github.com/users/campersau/gists{/gist_id}","starred_url":"https://api.github.com/users/campersau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/campersau/subscriptions","organizations_url":"https://api.github.com/users/campersau/orgs","repos_url":"https://api.github.com/users/campersau/repos","events_url":"https://api.github.com/users/campersau/events{/privacy}","received_events_url":"https://api.github.com/users/campersau/received_events","type":"User","site_admin":false},"body":"What would happen if the url looked like this: `/hello/josh?name=test` ?","created_at":"2016-03-15T17:05:23Z","updated_at":"2016-03-15T17:05:23Z","html_url":"https://github.com/slimphp/Slim/pull/1800#discussion_r56200871","pull_request_url":"https://api.github.com/repos/slimphp/Slim/pulls/1800","_links":{"self":{"href":"https://api.github.com/repos/slimphp/Slim/pulls/comments/56200871"},"html":{"href":"https://github.com/slimphp/Slim/pull/1800#discussion_r56200871"},"pull_request":{"href":"https://api.github.com/repos/slimphp/Slim/pulls/1800"}}},"pull_request":{"url":"https://api.github.com/repos/slimphp/Slim/pulls/1800","id":61842303,"html_url":"https://github.com/slimphp/Slim/pull/1800","diff_url":"https://github.com/slimphp/Slim/pull/1800.diff","patch_url":"https://github.com/slimphp/Slim/pull/1800.patch","issue_url":"https://api.github.com/repos/slimphp/Slim/issues/1800","number":1800,"state":"open","locked":false,"title":"More flexibility for URL parameters","user":{"login":"aimeos","id":8647429,"avatar_url":"https://avatars.githubusercontent.com/u/8647429?v=3","gravatar_id":"","url":"https://api.github.com/users/aimeos","html_url":"https://github.com/aimeos","followers_url":"https://api.github.com/users/aimeos/followers","following_url":"https://api.github.com/users/aimeos/following{/other_user}","gists_url":"https://api.github.com/users/aimeos/gists{/gist_id}","starred_url":"https://api.github.com/users/aimeos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aimeos/subscriptions","organizations_url":"https://api.github.com/users/aimeos/orgs","repos_url":"https://api.github.com/users/aimeos/repos","events_url":"https://api.github.com/users/aimeos/events{/privacy}","received_events_url":"https://api.github.com/users/aimeos/received_events","type":"User","site_admin":false},"body":"Use query parameter in route path if no URL parameter is explicitly available.","created_at":"2016-03-06T13:09:33Z","updated_at":"2016-03-15T17:05:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"620b235e2c80fe615d99e64c19164fd686f92ab9","assignee":{"login":"silentworks","id":79497,"avatar_url":"https://avatars.githubusercontent.com/u/79497?v=3","gravatar_id":"","url":"https://api.github.com/users/silentworks","html_url":"https://github.com/silentworks","followers_url":"https://api.github.com/users/silentworks/followers","following_url":"https://api.github.com/users/silentworks/following{/other_user}","gists_url":"https://api.github.com/users/silentworks/gists{/gist_id}","starred_url":"https://api.github.com/users/silentworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silentworks/subscriptions","organizations_url":"https://api.github.com/users/silentworks/orgs","repos_url":"https://api.github.com/users/silentworks/repos","events_url":"https://api.github.com/users/silentworks/events{/privacy}","received_events_url":"https://api.github.com/users/silentworks/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/slimphp/Slim/pulls/1800/commits","review_comments_url":"https://api.github.com/repos/slimphp/Slim/pulls/1800/comments","review_comment_url":"https://api.github.com/repos/slimphp/Slim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slimphp/Slim/issues/1800/comments","statuses_url":"https://api.github.com/repos/slimphp/Slim/statuses/4df82cb3860edd4159092434c74e5534c40d2a8c","head":{"label":"aimeos:3.x","ref":"3.x","sha":"4df82cb3860edd4159092434c74e5534c40d2a8c","user":{"login":"aimeos","id":8647429,"avatar_url":"https://avatars.githubusercontent.com/u/8647429?v=3","gravatar_id":"","url":"https://api.github.com/users/aimeos","html_url":"https://github.com/aimeos","followers_url":"https://api.github.com/users/aimeos/followers","following_url":"https://api.github.com/users/aimeos/following{/other_user}","gists_url":"https://api.github.com/users/aimeos/gists{/gist_id}","starred_url":"https://api.github.com/users/aimeos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aimeos/subscriptions","organizations_url":"https://api.github.com/users/aimeos/orgs","repos_url":"https://api.github.com/users/aimeos/repos","events_url":"https://api.github.com/users/aimeos/events{/privacy}","received_events_url":"https://api.github.com/users/aimeos/received_events","type":"User","site_admin":false},"repo":{"id":53254824,"name":"Slim","full_name":"aimeos/Slim","owner":{"login":"aimeos","id":8647429,"avatar_url":"https://avatars.githubusercontent.com/u/8647429?v=3","gravatar_id":"","url":"https://api.github.com/users/aimeos","html_url":"https://github.com/aimeos","followers_url":"https://api.github.com/users/aimeos/followers","following_url":"https://api.github.com/users/aimeos/following{/other_user}","gists_url":"https://api.github.com/users/aimeos/gists{/gist_id}","starred_url":"https://api.github.com/users/aimeos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aimeos/subscriptions","organizations_url":"https://api.github.com/users/aimeos/orgs","repos_url":"https://api.github.com/users/aimeos/repos","events_url":"https://api.github.com/users/aimeos/events{/privacy}","received_events_url":"https://api.github.com/users/aimeos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aimeos/Slim","description":"Slim Framework source code","fork":true,"url":"https://api.github.com/repos/aimeos/Slim","forks_url":"https://api.github.com/repos/aimeos/Slim/forks","keys_url":"https://api.github.com/repos/aimeos/Slim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aimeos/Slim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aimeos/Slim/teams","hooks_url":"https://api.github.com/repos/aimeos/Slim/hooks","issue_events_url":"https://api.github.com/repos/aimeos/Slim/issues/events{/number}","events_url":"https://api.github.com/repos/aimeos/Slim/events","assignees_url":"https://api.github.com/repos/aimeos/Slim/assignees{/user}","branches_url":"https://api.github.com/repos/aimeos/Slim/branches{/branch}","tags_url":"https://api.github.com/repos/aimeos/Slim/tags","blobs_url":"https://api.github.com/repos/aimeos/Slim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aimeos/Slim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aimeos/Slim/git/refs{/sha}","trees_url":"https://api.github.com/repos/aimeos/Slim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aimeos/Slim/statuses/{sha}","languages_url":"https://api.github.com/repos/aimeos/Slim/languages","stargazers_url":"https://api.github.com/repos/aimeos/Slim/stargazers","contributors_url":"https://api.github.com/repos/aimeos/Slim/contributors","subscribers_url":"https://api.github.com/repos/aimeos/Slim/subscribers","subscription_url":"https://api.github.com/repos/aimeos/Slim/subscription","commits_url":"https://api.github.com/repos/aimeos/Slim/commits{/sha}","git_commits_url":"https://api.github.com/repos/aimeos/Slim/git/commits{/sha}","comments_url":"https://api.github.com/repos/aimeos/Slim/comments{/number}","issue_comment_url":"https://api.github.com/repos/aimeos/Slim/issues/comments{/number}","contents_url":"https://api.github.com/repos/aimeos/Slim/contents/{+path}","compare_url":"https://api.github.com/repos/aimeos/Slim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aimeos/Slim/merges","archive_url":"https://api.github.com/repos/aimeos/Slim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aimeos/Slim/downloads","issues_url":"https://api.github.com/repos/aimeos/Slim/issues{/number}","pulls_url":"https://api.github.com/repos/aimeos/Slim/pulls{/number}","milestones_url":"https://api.github.com/repos/aimeos/Slim/milestones{/number}","notifications_url":"https://api.github.com/repos/aimeos/Slim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aimeos/Slim/labels{/name}","releases_url":"https://api.github.com/repos/aimeos/Slim/releases{/id}","deployments_url":"https://api.github.com/repos/aimeos/Slim/deployments","created_at":"2016-03-06T12:56:05Z","updated_at":"2016-03-06T12:56:07Z","pushed_at":"2016-03-12T15:21:01Z","git_url":"git://github.com/aimeos/Slim.git","ssh_url":"git@github.com:aimeos/Slim.git","clone_url":"https://github.com/aimeos/Slim.git","svn_url":"https://github.com/aimeos/Slim","homepage":"http://slimframework.com","size":4907,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.x"}},"base":{"label":"slimphp:3.x","ref":"3.x","sha":"1d99b8846c784d885201b2b709bfedb63656ed30","user":{"login":"slimphp","id":11195762,"avatar_url":"https://avatars.githubusercontent.com/u/11195762?v=3","gravatar_id":"","url":"https://api.github.com/users/slimphp","html_url":"https://github.com/slimphp","followers_url":"https://api.github.com/users/slimphp/followers","following_url":"https://api.github.com/users/slimphp/following{/other_user}","gists_url":"https://api.github.com/users/slimphp/gists{/gist_id}","starred_url":"https://api.github.com/users/slimphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slimphp/subscriptions","organizations_url":"https://api.github.com/users/slimphp/orgs","repos_url":"https://api.github.com/users/slimphp/repos","events_url":"https://api.github.com/users/slimphp/events{/privacy}","received_events_url":"https://api.github.com/users/slimphp/received_events","type":"Organization","site_admin":false},"repo":{"id":926544,"name":"Slim","full_name":"slimphp/Slim","owner":{"login":"slimphp","id":11195762,"avatar_url":"https://avatars.githubusercontent.com/u/11195762?v=3","gravatar_id":"","url":"https://api.github.com/users/slimphp","html_url":"https://github.com/slimphp","followers_url":"https://api.github.com/users/slimphp/followers","following_url":"https://api.github.com/users/slimphp/following{/other_user}","gists_url":"https://api.github.com/users/slimphp/gists{/gist_id}","starred_url":"https://api.github.com/users/slimphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slimphp/subscriptions","organizations_url":"https://api.github.com/users/slimphp/orgs","repos_url":"https://api.github.com/users/slimphp/repos","events_url":"https://api.github.com/users/slimphp/events{/privacy}","received_events_url":"https://api.github.com/users/slimphp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slimphp/Slim","description":"Slim Framework source code","fork":false,"url":"https://api.github.com/repos/slimphp/Slim","forks_url":"https://api.github.com/repos/slimphp/Slim/forks","keys_url":"https://api.github.com/repos/slimphp/Slim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slimphp/Slim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slimphp/Slim/teams","hooks_url":"https://api.github.com/repos/slimphp/Slim/hooks","issue_events_url":"https://api.github.com/repos/slimphp/Slim/issues/events{/number}","events_url":"https://api.github.com/repos/slimphp/Slim/events","assignees_url":"https://api.github.com/repos/slimphp/Slim/assignees{/user}","branches_url":"https://api.github.com/repos/slimphp/Slim/branches{/branch}","tags_url":"https://api.github.com/repos/slimphp/Slim/tags","blobs_url":"https://api.github.com/repos/slimphp/Slim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slimphp/Slim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slimphp/Slim/git/refs{/sha}","trees_url":"https://api.github.com/repos/slimphp/Slim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slimphp/Slim/statuses/{sha}","languages_url":"https://api.github.com/repos/slimphp/Slim/languages","stargazers_url":"https://api.github.com/repos/slimphp/Slim/stargazers","contributors_url":"https://api.github.com/repos/slimphp/Slim/contributors","subscribers_url":"https://api.github.com/repos/slimphp/Slim/subscribers","subscription_url":"https://api.github.com/repos/slimphp/Slim/subscription","commits_url":"https://api.github.com/repos/slimphp/Slim/commits{/sha}","git_commits_url":"https://api.github.com/repos/slimphp/Slim/git/commits{/sha}","comments_url":"https://api.github.com/repos/slimphp/Slim/comments{/number}","issue_comment_url":"https://api.github.com/repos/slimphp/Slim/issues/comments{/number}","contents_url":"https://api.github.com/repos/slimphp/Slim/contents/{+path}","compare_url":"https://api.github.com/repos/slimphp/Slim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slimphp/Slim/merges","archive_url":"https://api.github.com/repos/slimphp/Slim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slimphp/Slim/downloads","issues_url":"https://api.github.com/repos/slimphp/Slim/issues{/number}","pulls_url":"https://api.github.com/repos/slimphp/Slim/pulls{/number}","milestones_url":"https://api.github.com/repos/slimphp/Slim/milestones{/number}","notifications_url":"https://api.github.com/repos/slimphp/Slim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slimphp/Slim/labels{/name}","releases_url":"https://api.github.com/repos/slimphp/Slim/releases{/id}","deployments_url":"https://api.github.com/repos/slimphp/Slim/deployments","created_at":"2010-09-21T01:17:06Z","updated_at":"2016-03-15T11:00:57Z","pushed_at":"2016-03-13T11:57:45Z","git_url":"git://github.com/slimphp/Slim.git","ssh_url":"git@github.com:slimphp/Slim.git","clone_url":"https://github.com/slimphp/Slim.git","svn_url":"https://github.com/slimphp/Slim","homepage":"http://slimframework.com","size":6528,"stargazers_count":6512,"watchers_count":6512,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1246,"mirror_url":null,"open_issues_count":25,"forks":1246,"open_issues":25,"watchers":6512,"default_branch":"3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/slimphp/Slim/pulls/1800"},"html":{"href":"https://github.com/slimphp/Slim/pull/1800"},"issue":{"href":"https://api.github.com/repos/slimphp/Slim/issues/1800"},"comments":{"href":"https://api.github.com/repos/slimphp/Slim/issues/1800/comments"},"review_comments":{"href":"https://api.github.com/repos/slimphp/Slim/pulls/1800/comments"},"review_comment":{"href":"https://api.github.com/repos/slimphp/Slim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slimphp/Slim/pulls/1800/commits"},"statuses":{"href":"https://api.github.com/repos/slimphp/Slim/statuses/4df82cb3860edd4159092434c74e5534c40d2a8c"}}}}