{"action":"created","comment":{"url":"https://api.github.com/repos/jgrapht/jgrapht/pulls/comments/89824064","pull_request_review_id":10357582,"id":89824064,"diff_hunk":"@@ -0,0 +1,70 @@\n+/*\n+ * (C) Copyright 2016-2016, by Dimitrios Michail and Contributors.\n+ *\n+ * JGraphT : a free Java graph-theory library\n+ *\n+ * This program and the accompanying materials are dual-licensed under\n+ * either\n+ *\n+ * (a) the terms of the GNU Lesser General Public License version 2.1\n+ * as published by the Free Software Foundation, or (at your option) any\n+ * later version.\n+ *\n+ * or (per the licensee's choosing)\n+ *\n+ * (b) the terms of the Eclipse Public License v1.0 as published by\n+ * the Eclipse Foundation.\n+ */\n+package org.jgrapht.alg.matching;\n+\n+import java.io.Serializable;\n+import java.util.Set;\n+\n+import org.jgrapht.alg.interfaces.MatchingAlgorithm.Matching;\n+\n+/**\n+ * A default implementation of the matching interface.\n+ * \n+ * @param <E> the graph edge type\n+ *\n+ * @author Dimitrios Michail\n+ */\n+class DefaultMatching<E>","path":"jgrapht-core/src/main/java/org/jgrapht/alg/matching/DefaultMatching.java","position":32,"original_position":32,"commit_id":"dc382e17bd1efb2164f17a49fd08bb37cdb60924","original_commit_id":"dc382e17bd1efb2164f17a49fd08bb37cdb60924","user":{"login":"jkinable","id":2742474,"avatar_url":"https://avatars.githubusercontent.com/u/2742474?v=3","gravatar_id":"","url":"https://api.github.com/users/jkinable","html_url":"https://github.com/jkinable","followers_url":"https://api.github.com/users/jkinable/followers","following_url":"https://api.github.com/users/jkinable/following{/other_user}","gists_url":"https://api.github.com/users/jkinable/gists{/gist_id}","starred_url":"https://api.github.com/users/jkinable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkinable/subscriptions","organizations_url":"https://api.github.com/users/jkinable/orgs","repos_url":"https://api.github.com/users/jkinable/repos","events_url":"https://api.github.com/users/jkinable/events{/privacy}","received_events_url":"https://api.github.com/users/jkinable/received_events","type":"User","site_admin":false},"body":"In the MaximumFlowAlgorithm interface, @jsichi  and Alexey added both the MaximumFlow interface as well as a MaximumFlowImpl which implements the MaximumFlow interface. Here there are some consistency issues:\r\n\r\n1. Naming: DefaultMatching vs MatchingImpl (same as MaximumFlowImpl)\r\n2. Here the DefaultMatching is a dedicated class, whereas in the Flow case, the implementation is located in the MaximumFlowAlgorithm interface.\r\n\r\nI would suggest to keep everything as consistent as possible. Let's choose a standard name, e.g DefaultMatching or MatchingImpl and enforce the same for the other interfaces. Similarly, should the default implementation reside in the interface, or in a separate class? @jsichi preferences?","created_at":"2016-11-28T16:47:07Z","updated_at":"2016-11-28T16:47:07Z","html_url":"https://github.com/jgrapht/jgrapht/pull/320#discussion_r89824064","pull_request_url":"https://api.github.com/repos/jgrapht/jgrapht/pulls/320","_links":{"self":{"href":"https://api.github.com/repos/jgrapht/jgrapht/pulls/comments/89824064"},"html":{"href":"https://github.com/jgrapht/jgrapht/pull/320#discussion_r89824064"},"pull_request":{"href":"https://api.github.com/repos/jgrapht/jgrapht/pulls/320"}}},"pull_request":{"url":"https://api.github.com/repos/jgrapht/jgrapht/pulls/320","id":91162917,"html_url":"https://github.com/jgrapht/jgrapht/pull/320","diff_url":"https://github.com/jgrapht/jgrapht/pull/320.diff","patch_url":"https://github.com/jgrapht/jgrapht/pull/320.patch","issue_url":"https://api.github.com/repos/jgrapht/jgrapht/issues/320","number":320,"state":"open","locked":false,"title":"Revised matchings interfaces","user":{"login":"d-michail","id":15940875,"avatar_url":"https://avatars.githubusercontent.com/u/15940875?v=3","gravatar_id":"","url":"https://api.github.com/users/d-michail","html_url":"https://github.com/d-michail","followers_url":"https://api.github.com/users/d-michail/followers","following_url":"https://api.github.com/users/d-michail/following{/other_user}","gists_url":"https://api.github.com/users/d-michail/gists{/gist_id}","starred_url":"https://api.github.com/users/d-michail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-michail/subscriptions","organizations_url":"https://api.github.com/users/d-michail/orgs","repos_url":"https://api.github.com/users/d-michail/repos","events_url":"https://api.github.com/users/d-michail/events{/privacy}","received_events_url":"https://api.github.com/users/d-michail/received_events","type":"User","site_admin":false},"body":"Followup of pull-request #281 which adjusts the matching interfaces. \n","created_at":"2016-10-27T09:25:13Z","updated_at":"2016-11-28T16:47:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"691d777772ebb7e4bb2c85eb83d87eb8edc2663f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jgrapht/jgrapht/pulls/320/commits","review_comments_url":"https://api.github.com/repos/jgrapht/jgrapht/pulls/320/comments","review_comment_url":"https://api.github.com/repos/jgrapht/jgrapht/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jgrapht/jgrapht/issues/320/comments","statuses_url":"https://api.github.com/repos/jgrapht/jgrapht/statuses/dc382e17bd1efb2164f17a49fd08bb37cdb60924","head":{"label":"d-michail:matching-interfaces","ref":"matching-interfaces","sha":"dc382e17bd1efb2164f17a49fd08bb37cdb60924","user":{"login":"d-michail","id":15940875,"avatar_url":"https://avatars.githubusercontent.com/u/15940875?v=3","gravatar_id":"","url":"https://api.github.com/users/d-michail","html_url":"https://github.com/d-michail","followers_url":"https://api.github.com/users/d-michail/followers","following_url":"https://api.github.com/users/d-michail/following{/other_user}","gists_url":"https://api.github.com/users/d-michail/gists{/gist_id}","starred_url":"https://api.github.com/users/d-michail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-michail/subscriptions","organizations_url":"https://api.github.com/users/d-michail/orgs","repos_url":"https://api.github.com/users/d-michail/repos","events_url":"https://api.github.com/users/d-michail/events{/privacy}","received_events_url":"https://api.github.com/users/d-michail/received_events","type":"User","site_admin":false},"repo":{"id":63318196,"name":"jgrapht","full_name":"d-michail/jgrapht","owner":{"login":"d-michail","id":15940875,"avatar_url":"https://avatars.githubusercontent.com/u/15940875?v=3","gravatar_id":"","url":"https://api.github.com/users/d-michail","html_url":"https://github.com/d-michail","followers_url":"https://api.github.com/users/d-michail/followers","following_url":"https://api.github.com/users/d-michail/following{/other_user}","gists_url":"https://api.github.com/users/d-michail/gists{/gist_id}","starred_url":"https://api.github.com/users/d-michail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-michail/subscriptions","organizations_url":"https://api.github.com/users/d-michail/orgs","repos_url":"https://api.github.com/users/d-michail/repos","events_url":"https://api.github.com/users/d-michail/events{/privacy}","received_events_url":"https://api.github.com/users/d-michail/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d-michail/jgrapht","description":"Master repository for the JGraphT project","fork":true,"url":"https://api.github.com/repos/d-michail/jgrapht","forks_url":"https://api.github.com/repos/d-michail/jgrapht/forks","keys_url":"https://api.github.com/repos/d-michail/jgrapht/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d-michail/jgrapht/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d-michail/jgrapht/teams","hooks_url":"https://api.github.com/repos/d-michail/jgrapht/hooks","issue_events_url":"https://api.github.com/repos/d-michail/jgrapht/issues/events{/number}","events_url":"https://api.github.com/repos/d-michail/jgrapht/events","assignees_url":"https://api.github.com/repos/d-michail/jgrapht/assignees{/user}","branches_url":"https://api.github.com/repos/d-michail/jgrapht/branches{/branch}","tags_url":"https://api.github.com/repos/d-michail/jgrapht/tags","blobs_url":"https://api.github.com/repos/d-michail/jgrapht/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d-michail/jgrapht/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d-michail/jgrapht/git/refs{/sha}","trees_url":"https://api.github.com/repos/d-michail/jgrapht/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d-michail/jgrapht/statuses/{sha}","languages_url":"https://api.github.com/repos/d-michail/jgrapht/languages","stargazers_url":"https://api.github.com/repos/d-michail/jgrapht/stargazers","contributors_url":"https://api.github.com/repos/d-michail/jgrapht/contributors","subscribers_url":"https://api.github.com/repos/d-michail/jgrapht/subscribers","subscription_url":"https://api.github.com/repos/d-michail/jgrapht/subscription","commits_url":"https://api.github.com/repos/d-michail/jgrapht/commits{/sha}","git_commits_url":"https://api.github.com/repos/d-michail/jgrapht/git/commits{/sha}","comments_url":"https://api.github.com/repos/d-michail/jgrapht/comments{/number}","issue_comment_url":"https://api.github.com/repos/d-michail/jgrapht/issues/comments{/number}","contents_url":"https://api.github.com/repos/d-michail/jgrapht/contents/{+path}","compare_url":"https://api.github.com/repos/d-michail/jgrapht/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d-michail/jgrapht/merges","archive_url":"https://api.github.com/repos/d-michail/jgrapht/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d-michail/jgrapht/downloads","issues_url":"https://api.github.com/repos/d-michail/jgrapht/issues{/number}","pulls_url":"https://api.github.com/repos/d-michail/jgrapht/pulls{/number}","milestones_url":"https://api.github.com/repos/d-michail/jgrapht/milestones{/number}","notifications_url":"https://api.github.com/repos/d-michail/jgrapht/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d-michail/jgrapht/labels{/name}","releases_url":"https://api.github.com/repos/d-michail/jgrapht/releases{/id}","deployments_url":"https://api.github.com/repos/d-michail/jgrapht/deployments","created_at":"2016-07-14T08:35:27Z","updated_at":"2016-11-05T10:41:58Z","pushed_at":"2016-11-11T19:06:13Z","git_url":"git://github.com/d-michail/jgrapht.git","ssh_url":"git@github.com:d-michail/jgrapht.git","clone_url":"https://github.com/d-michail/jgrapht.git","svn_url":"https://github.com/d-michail/jgrapht","homepage":"http://www.jgrapht.org","size":6977,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"jgrapht:master","ref":"master","sha":"cd7828a6e2ccacf7394e77d7a39741f0bdb27efc","user":{"login":"jgrapht","id":1624681,"avatar_url":"https://avatars.githubusercontent.com/u/1624681?v=3","gravatar_id":"","url":"https://api.github.com/users/jgrapht","html_url":"https://github.com/jgrapht","followers_url":"https://api.github.com/users/jgrapht/followers","following_url":"https://api.github.com/users/jgrapht/following{/other_user}","gists_url":"https://api.github.com/users/jgrapht/gists{/gist_id}","starred_url":"https://api.github.com/users/jgrapht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgrapht/subscriptions","organizations_url":"https://api.github.com/users/jgrapht/orgs","repos_url":"https://api.github.com/users/jgrapht/repos","events_url":"https://api.github.com/users/jgrapht/events{/privacy}","received_events_url":"https://api.github.com/users/jgrapht/received_events","type":"Organization","site_admin":false},"repo":{"id":3969325,"name":"jgrapht","full_name":"jgrapht/jgrapht","owner":{"login":"jgrapht","id":1624681,"avatar_url":"https://avatars.githubusercontent.com/u/1624681?v=3","gravatar_id":"","url":"https://api.github.com/users/jgrapht","html_url":"https://github.com/jgrapht","followers_url":"https://api.github.com/users/jgrapht/followers","following_url":"https://api.github.com/users/jgrapht/following{/other_user}","gists_url":"https://api.github.com/users/jgrapht/gists{/gist_id}","starred_url":"https://api.github.com/users/jgrapht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgrapht/subscriptions","organizations_url":"https://api.github.com/users/jgrapht/orgs","repos_url":"https://api.github.com/users/jgrapht/repos","events_url":"https://api.github.com/users/jgrapht/events{/privacy}","received_events_url":"https://api.github.com/users/jgrapht/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jgrapht/jgrapht","description":"Master repository for the JGraphT project","fork":true,"url":"https://api.github.com/repos/jgrapht/jgrapht","forks_url":"https://api.github.com/repos/jgrapht/jgrapht/forks","keys_url":"https://api.github.com/repos/jgrapht/jgrapht/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgrapht/jgrapht/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgrapht/jgrapht/teams","hooks_url":"https://api.github.com/repos/jgrapht/jgrapht/hooks","issue_events_url":"https://api.github.com/repos/jgrapht/jgrapht/issues/events{/number}","events_url":"https://api.github.com/repos/jgrapht/jgrapht/events","assignees_url":"https://api.github.com/repos/jgrapht/jgrapht/assignees{/user}","branches_url":"https://api.github.com/repos/jgrapht/jgrapht/branches{/branch}","tags_url":"https://api.github.com/repos/jgrapht/jgrapht/tags","blobs_url":"https://api.github.com/repos/jgrapht/jgrapht/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgrapht/jgrapht/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgrapht/jgrapht/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgrapht/jgrapht/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgrapht/jgrapht/statuses/{sha}","languages_url":"https://api.github.com/repos/jgrapht/jgrapht/languages","stargazers_url":"https://api.github.com/repos/jgrapht/jgrapht/stargazers","contributors_url":"https://api.github.com/repos/jgrapht/jgrapht/contributors","subscribers_url":"https://api.github.com/repos/jgrapht/jgrapht/subscribers","subscription_url":"https://api.github.com/repos/jgrapht/jgrapht/subscription","commits_url":"https://api.github.com/repos/jgrapht/jgrapht/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgrapht/jgrapht/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgrapht/jgrapht/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgrapht/jgrapht/issues/comments{/number}","contents_url":"https://api.github.com/repos/jgrapht/jgrapht/contents/{+path}","compare_url":"https://api.github.com/repos/jgrapht/jgrapht/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgrapht/jgrapht/merges","archive_url":"https://api.github.com/repos/jgrapht/jgrapht/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgrapht/jgrapht/downloads","issues_url":"https://api.github.com/repos/jgrapht/jgrapht/issues{/number}","pulls_url":"https://api.github.com/repos/jgrapht/jgrapht/pulls{/number}","milestones_url":"https://api.github.com/repos/jgrapht/jgrapht/milestones{/number}","notifications_url":"https://api.github.com/repos/jgrapht/jgrapht/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgrapht/jgrapht/labels{/name}","releases_url":"https://api.github.com/repos/jgrapht/jgrapht/releases{/id}","deployments_url":"https://api.github.com/repos/jgrapht/jgrapht/deployments","created_at":"2012-04-09T05:30:23Z","updated_at":"2016-11-23T16:06:03Z","pushed_at":"2016-11-23T01:26:43Z","git_url":"git://github.com/jgrapht/jgrapht.git","ssh_url":"git@github.com:jgrapht/jgrapht.git","clone_url":"https://github.com/jgrapht/jgrapht.git","svn_url":"https://github.com/jgrapht/jgrapht","homepage":"http://www.jgrapht.org","size":8816,"stargazers_count":765,"watchers_count":765,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":323,"mirror_url":null,"open_issues_count":54,"forks":323,"open_issues":54,"watchers":765,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jgrapht/jgrapht/pulls/320"},"html":{"href":"https://github.com/jgrapht/jgrapht/pull/320"},"issue":{"href":"https://api.github.com/repos/jgrapht/jgrapht/issues/320"},"comments":{"href":"https://api.github.com/repos/jgrapht/jgrapht/issues/320/comments"},"review_comments":{"href":"https://api.github.com/repos/jgrapht/jgrapht/pulls/320/comments"},"review_comment":{"href":"https://api.github.com/repos/jgrapht/jgrapht/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jgrapht/jgrapht/pulls/320/commits"},"statuses":{"href":"https://api.github.com/repos/jgrapht/jgrapht/statuses/dc382e17bd1efb2164f17a49fd08bb37cdb60924"}}}}
{"actor":{"display_login":"jkinable"}}