{"action":"created","issue":{"url":"https://api.github.com/repos/vuejs/vuefire/issues/25","repository_url":"https://api.github.com/repos/vuejs/vuefire","labels_url":"https://api.github.com/repos/vuejs/vuefire/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/vuejs/vuefire/issues/25/comments","events_url":"https://api.github.com/repos/vuejs/vuefire/issues/25/events","html_url":"https://github.com/vuejs/vuefire/pull/25","id":170518286,"number":25,"title":"Enabled firebase to be called as function, thus enabling patterns where Firebase ref's are stored in root component","user":{"login":"DaBs","id":865202,"avatar_url":"https://avatars.githubusercontent.com/u/865202?v=3","gravatar_id":"","url":"https://api.github.com/users/DaBs","html_url":"https://github.com/DaBs","followers_url":"https://api.github.com/users/DaBs/followers","following_url":"https://api.github.com/users/DaBs/following{/other_user}","gists_url":"https://api.github.com/users/DaBs/gists{/gist_id}","starred_url":"https://api.github.com/users/DaBs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaBs/subscriptions","organizations_url":"https://api.github.com/users/DaBs/orgs","repos_url":"https://api.github.com/users/DaBs/repos","events_url":"https://api.github.com/users/DaBs/events{/privacy}","received_events_url":"https://api.github.com/users/DaBs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-08-10T21:03:19Z","updated_at":"2016-08-15T22:38:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vuejs/vuefire/pulls/25","html_url":"https://github.com/vuejs/vuefire/pull/25","diff_url":"https://github.com/vuejs/vuefire/pull/25.diff","patch_url":"https://github.com/vuejs/vuefire/pull/25.patch"},"body":"This pull request will enable using the firebase option in the same way as the data option, by calling it as a function and returning an object. This allows for coding patterns where you originally define the Firebase references as data in the root component, but want to use the later on in child components, e.g. \r\n```javascript\r\nexport default {\r\n    ...,\r\n    firebase() {\r\n        return {\r\n            someArray: this.$root.database.ref('someArray')\r\n        }\r\n    },\r\n    ...\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/vuejs/vuefire/issues/comments/239950621","html_url":"https://github.com/vuejs/vuefire/pull/25#issuecomment-239950621","issue_url":"https://api.github.com/repos/vuejs/vuefire/issues/25","id":239950621,"user":{"login":"posva","id":664177,"avatar_url":"https://avatars.githubusercontent.com/u/664177?v=3","gravatar_id":"","url":"https://api.github.com/users/posva","html_url":"https://github.com/posva","followers_url":"https://api.github.com/users/posva/followers","following_url":"https://api.github.com/users/posva/following{/other_user}","gists_url":"https://api.github.com/users/posva/gists{/gist_id}","starred_url":"https://api.github.com/users/posva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/posva/subscriptions","organizations_url":"https://api.github.com/users/posva/orgs","repos_url":"https://api.github.com/users/posva/repos","events_url":"https://api.github.com/users/posva/events{/privacy}","received_events_url":"https://api.github.com/users/posva/received_events","type":"User","site_admin":false},"created_at":"2016-08-15T22:38:23Z","updated_at":"2016-08-15T22:38:23Z","body":"@DaBs It's ok, I actually feel being pushy 😓 \r\nThe unit test is much better that way. It'd be perfect if you can use a spy and check it gets called only once after the `$mount`\r\nI'd also remove the regex on the throw. If it throws anything it can be considered as a failure"}}
{"actor":{"display_login":"posva"}}