{"action":"opened","number":163,"pull_request":{"url":"https://api.github.com/repos/dyninst/dyninst/pulls/163","id":82972213,"html_url":"https://github.com/dyninst/dyninst/pull/163","diff_url":"https://github.com/dyninst/dyninst/pull/163.diff","patch_url":"https://github.com/dyninst/dyninst/pull/163.patch","issue_url":"https://api.github.com/repos/dyninst/dyninst/issues/163","number":163,"state":"open","locked":false,"title":"fix insnCodeGen::modifyData's 64-bit conversion","user":{"login":"cuviper","id":36186,"avatar_url":"https://avatars.githubusercontent.com/u/36186?v=3","gravatar_id":"","url":"https://api.github.com/users/cuviper","html_url":"https://github.com/cuviper","followers_url":"https://api.github.com/users/cuviper/followers","following_url":"https://api.github.com/users/cuviper/following{/other_user}","gists_url":"https://api.github.com/users/cuviper/gists{/gist_id}","starred_url":"https://api.github.com/users/cuviper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuviper/subscriptions","organizations_url":"https://api.github.com/users/cuviper/orgs","repos_url":"https://api.github.com/users/cuviper/repos","events_url":"https://api.github.com/users/cuviper/events{/privacy}","received_events_url":"https://api.github.com/users/cuviper/received_events","type":"User","site_admin":false},"body":"On RHEL6 with a prelinked `/lib64/libc-2.12.so`, all of tests involving\r\nfork instrumentation were getting SIGSEGV in the mutatee.  This worked\r\nin 9.1, and it also works fine after `prelink -u` to undo libc.  Using\r\ngit-bisect found 2b86eb4577bb as the point of regression.\r\n\r\nIt seems prelink ends up with libc sitting far away from the relocation\r\nbuffer, more than a 32-bit displacement, so `insnCodeGen::modifyData`\r\ndecides to rewrite that to a 64-bit immediate.  To do this, it has to\r\nemit additional instructions first.  But after the commit above, part of\r\nthe rewritten instruction has already been written when we're trying to\r\nemit those extras, and things gets clobbered.\r\n\r\nThis patch emits those preamble instructions first, before any part of\r\nthe newly rewritten instruction is copied out.","created_at":"2016-08-27T00:48:00Z","updated_at":"2016-08-27T00:48:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9763d605a6065bcf80052197c902d3b43e23b8c5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dyninst/dyninst/pulls/163/commits","review_comments_url":"https://api.github.com/repos/dyninst/dyninst/pulls/163/comments","review_comment_url":"https://api.github.com/repos/dyninst/dyninst/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dyninst/dyninst/issues/163/comments","statuses_url":"https://api.github.com/repos/dyninst/dyninst/statuses/2ef16d80916233c55e2694af373adb69a863933c","head":{"label":"cuviper:modify-data-64","ref":"modify-data-64","sha":"2ef16d80916233c55e2694af373adb69a863933c","user":{"login":"cuviper","id":36186,"avatar_url":"https://avatars.githubusercontent.com/u/36186?v=3","gravatar_id":"","url":"https://api.github.com/users/cuviper","html_url":"https://github.com/cuviper","followers_url":"https://api.github.com/users/cuviper/followers","following_url":"https://api.github.com/users/cuviper/following{/other_user}","gists_url":"https://api.github.com/users/cuviper/gists{/gist_id}","starred_url":"https://api.github.com/users/cuviper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuviper/subscriptions","organizations_url":"https://api.github.com/users/cuviper/orgs","repos_url":"https://api.github.com/users/cuviper/repos","events_url":"https://api.github.com/users/cuviper/events{/privacy}","received_events_url":"https://api.github.com/users/cuviper/received_events","type":"User","site_admin":false},"repo":{"id":58493562,"name":"dyninst","full_name":"cuviper/dyninst","owner":{"login":"cuviper","id":36186,"avatar_url":"https://avatars.githubusercontent.com/u/36186?v=3","gravatar_id":"","url":"https://api.github.com/users/cuviper","html_url":"https://github.com/cuviper","followers_url":"https://api.github.com/users/cuviper/followers","following_url":"https://api.github.com/users/cuviper/following{/other_user}","gists_url":"https://api.github.com/users/cuviper/gists{/gist_id}","starred_url":"https://api.github.com/users/cuviper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuviper/subscriptions","organizations_url":"https://api.github.com/users/cuviper/orgs","repos_url":"https://api.github.com/users/cuviper/repos","events_url":"https://api.github.com/users/cuviper/events{/privacy}","received_events_url":"https://api.github.com/users/cuviper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cuviper/dyninst","description":"DyninstAPI: Tools for binary instrumentation, analysis, and modification.","fork":true,"url":"https://api.github.com/repos/cuviper/dyninst","forks_url":"https://api.github.com/repos/cuviper/dyninst/forks","keys_url":"https://api.github.com/repos/cuviper/dyninst/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cuviper/dyninst/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cuviper/dyninst/teams","hooks_url":"https://api.github.com/repos/cuviper/dyninst/hooks","issue_events_url":"https://api.github.com/repos/cuviper/dyninst/issues/events{/number}","events_url":"https://api.github.com/repos/cuviper/dyninst/events","assignees_url":"https://api.github.com/repos/cuviper/dyninst/assignees{/user}","branches_url":"https://api.github.com/repos/cuviper/dyninst/branches{/branch}","tags_url":"https://api.github.com/repos/cuviper/dyninst/tags","blobs_url":"https://api.github.com/repos/cuviper/dyninst/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cuviper/dyninst/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cuviper/dyninst/git/refs{/sha}","trees_url":"https://api.github.com/repos/cuviper/dyninst/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cuviper/dyninst/statuses/{sha}","languages_url":"https://api.github.com/repos/cuviper/dyninst/languages","stargazers_url":"https://api.github.com/repos/cuviper/dyninst/stargazers","contributors_url":"https://api.github.com/repos/cuviper/dyninst/contributors","subscribers_url":"https://api.github.com/repos/cuviper/dyninst/subscribers","subscription_url":"https://api.github.com/repos/cuviper/dyninst/subscription","commits_url":"https://api.github.com/repos/cuviper/dyninst/commits{/sha}","git_commits_url":"https://api.github.com/repos/cuviper/dyninst/git/commits{/sha}","comments_url":"https://api.github.com/repos/cuviper/dyninst/comments{/number}","issue_comment_url":"https://api.github.com/repos/cuviper/dyninst/issues/comments{/number}","contents_url":"https://api.github.com/repos/cuviper/dyninst/contents/{+path}","compare_url":"https://api.github.com/repos/cuviper/dyninst/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cuviper/dyninst/merges","archive_url":"https://api.github.com/repos/cuviper/dyninst/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cuviper/dyninst/downloads","issues_url":"https://api.github.com/repos/cuviper/dyninst/issues{/number}","pulls_url":"https://api.github.com/repos/cuviper/dyninst/pulls{/number}","milestones_url":"https://api.github.com/repos/cuviper/dyninst/milestones{/number}","notifications_url":"https://api.github.com/repos/cuviper/dyninst/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cuviper/dyninst/labels{/name}","releases_url":"https://api.github.com/repos/cuviper/dyninst/releases{/id}","deployments_url":"https://api.github.com/repos/cuviper/dyninst/deployments","created_at":"2016-05-10T21:05:38Z","updated_at":"2016-05-10T21:05:44Z","pushed_at":"2016-08-27T00:45:12Z","git_url":"git://github.com/cuviper/dyninst.git","ssh_url":"git@github.com:cuviper/dyninst.git","clone_url":"https://github.com/cuviper/dyninst.git","svn_url":"https://github.com/cuviper/dyninst","homepage":"http://www.dyninst.org","size":171905,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dyninst:v9.2_patches","ref":"v9.2_patches","sha":"9d5a42622dfd95dcefccc1de756f42ac3a7ee352","user":{"login":"dyninst","id":7452836,"avatar_url":"https://avatars.githubusercontent.com/u/7452836?v=3","gravatar_id":"","url":"https://api.github.com/users/dyninst","html_url":"https://github.com/dyninst","followers_url":"https://api.github.com/users/dyninst/followers","following_url":"https://api.github.com/users/dyninst/following{/other_user}","gists_url":"https://api.github.com/users/dyninst/gists{/gist_id}","starred_url":"https://api.github.com/users/dyninst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dyninst/subscriptions","organizations_url":"https://api.github.com/users/dyninst/orgs","repos_url":"https://api.github.com/users/dyninst/repos","events_url":"https://api.github.com/users/dyninst/events{/privacy}","received_events_url":"https://api.github.com/users/dyninst/received_events","type":"Organization","site_admin":false},"repo":{"id":57918231,"name":"dyninst","full_name":"dyninst/dyninst","owner":{"login":"dyninst","id":7452836,"avatar_url":"https://avatars.githubusercontent.com/u/7452836?v=3","gravatar_id":"","url":"https://api.github.com/users/dyninst","html_url":"https://github.com/dyninst","followers_url":"https://api.github.com/users/dyninst/followers","following_url":"https://api.github.com/users/dyninst/following{/other_user}","gists_url":"https://api.github.com/users/dyninst/gists{/gist_id}","starred_url":"https://api.github.com/users/dyninst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dyninst/subscriptions","organizations_url":"https://api.github.com/users/dyninst/orgs","repos_url":"https://api.github.com/users/dyninst/repos","events_url":"https://api.github.com/users/dyninst/events{/privacy}","received_events_url":"https://api.github.com/users/dyninst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dyninst/dyninst","description":"DyninstAPI: Tools for binary instrumentation, analysis, and modification.","fork":false,"url":"https://api.github.com/repos/dyninst/dyninst","forks_url":"https://api.github.com/repos/dyninst/dyninst/forks","keys_url":"https://api.github.com/repos/dyninst/dyninst/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dyninst/dyninst/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dyninst/dyninst/teams","hooks_url":"https://api.github.com/repos/dyninst/dyninst/hooks","issue_events_url":"https://api.github.com/repos/dyninst/dyninst/issues/events{/number}","events_url":"https://api.github.com/repos/dyninst/dyninst/events","assignees_url":"https://api.github.com/repos/dyninst/dyninst/assignees{/user}","branches_url":"https://api.github.com/repos/dyninst/dyninst/branches{/branch}","tags_url":"https://api.github.com/repos/dyninst/dyninst/tags","blobs_url":"https://api.github.com/repos/dyninst/dyninst/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dyninst/dyninst/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dyninst/dyninst/git/refs{/sha}","trees_url":"https://api.github.com/repos/dyninst/dyninst/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dyninst/dyninst/statuses/{sha}","languages_url":"https://api.github.com/repos/dyninst/dyninst/languages","stargazers_url":"https://api.github.com/repos/dyninst/dyninst/stargazers","contributors_url":"https://api.github.com/repos/dyninst/dyninst/contributors","subscribers_url":"https://api.github.com/repos/dyninst/dyninst/subscribers","subscription_url":"https://api.github.com/repos/dyninst/dyninst/subscription","commits_url":"https://api.github.com/repos/dyninst/dyninst/commits{/sha}","git_commits_url":"https://api.github.com/repos/dyninst/dyninst/git/commits{/sha}","comments_url":"https://api.github.com/repos/dyninst/dyninst/comments{/number}","issue_comment_url":"https://api.github.com/repos/dyninst/dyninst/issues/comments{/number}","contents_url":"https://api.github.com/repos/dyninst/dyninst/contents/{+path}","compare_url":"https://api.github.com/repos/dyninst/dyninst/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dyninst/dyninst/merges","archive_url":"https://api.github.com/repos/dyninst/dyninst/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dyninst/dyninst/downloads","issues_url":"https://api.github.com/repos/dyninst/dyninst/issues{/number}","pulls_url":"https://api.github.com/repos/dyninst/dyninst/pulls{/number}","milestones_url":"https://api.github.com/repos/dyninst/dyninst/milestones{/number}","notifications_url":"https://api.github.com/repos/dyninst/dyninst/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dyninst/dyninst/labels{/name}","releases_url":"https://api.github.com/repos/dyninst/dyninst/releases{/id}","deployments_url":"https://api.github.com/repos/dyninst/dyninst/deployments","created_at":"2016-05-02T20:06:57Z","updated_at":"2016-08-26T01:49:18Z","pushed_at":"2016-08-27T00:48:01Z","git_url":"git://github.com/dyninst/dyninst.git","ssh_url":"git@github.com:dyninst/dyninst.git","clone_url":"https://github.com/dyninst/dyninst.git","svn_url":"https://github.com/dyninst/dyninst","homepage":"http://www.dyninst.org","size":186114,"stargazers_count":26,"watchers_count":26,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":28,"forks":15,"open_issues":28,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dyninst/dyninst/pulls/163"},"html":{"href":"https://github.com/dyninst/dyninst/pull/163"},"issue":{"href":"https://api.github.com/repos/dyninst/dyninst/issues/163"},"comments":{"href":"https://api.github.com/repos/dyninst/dyninst/issues/163/comments"},"review_comments":{"href":"https://api.github.com/repos/dyninst/dyninst/pulls/163/comments"},"review_comment":{"href":"https://api.github.com/repos/dyninst/dyninst/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dyninst/dyninst/pulls/163/commits"},"statuses":{"href":"https://api.github.com/repos/dyninst/dyninst/statuses/2ef16d80916233c55e2694af373adb69a863933c"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":11,"deletions":12,"changed_files":1}}
{"actor":{"display_login":"cuviper"}}