{"action":"opened","number":3889,"pull_request":{"url":"https://api.github.com/repos/google/flatbuffers/pulls/3889","id":71909749,"html_url":"https://github.com/google/flatbuffers/pull/3889","diff_url":"https://github.com/google/flatbuffers/pull/3889.diff","patch_url":"https://github.com/google/flatbuffers/pull/3889.patch","issue_url":"https://api.github.com/repos/google/flatbuffers/issues/3889","number":3889,"state":"open","locked":false,"title":"MSVC doesn't allow alignment on function params.","user":{"login":"phraemer","id":143631,"avatar_url":"https://avatars.githubusercontent.com/u/143631?v=3","gravatar_id":"","url":"https://api.github.com/users/phraemer","html_url":"https://github.com/phraemer","followers_url":"https://api.github.com/users/phraemer/followers","following_url":"https://api.github.com/users/phraemer/following{/other_user}","gists_url":"https://api.github.com/users/phraemer/gists{/gist_id}","starred_url":"https://api.github.com/users/phraemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phraemer/subscriptions","organizations_url":"https://api.github.com/users/phraemer/orgs","repos_url":"https://api.github.com/users/phraemer/repos","events_url":"https://api.github.com/users/phraemer/events{/privacy}","received_events_url":"https://api.github.com/users/phraemer/received_events","type":"User","site_admin":false},"body":"MSVC doesn't allow alignment on function params. This change avoids copying the object and thus avoids this issue https://msdn.microsoft.com/en-us/library/373ak2y1.aspx\r\n\r\nAccording to MS' documentation for ` __declspec(align(#))`\r\n\r\n> The compiler does not guarantee or attempt to preserve the alignment attribute of data during a copy or data transform operation.\r\nhttps://msdn.microsoft.com/en-us/library/83ythb65.aspx\r\n\r\n\r\n","created_at":"2016-05-30T14:36:39Z","updated_at":"2016-05-30T14:36:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/flatbuffers/pulls/3889/commits","review_comments_url":"https://api.github.com/repos/google/flatbuffers/pulls/3889/comments","review_comment_url":"https://api.github.com/repos/google/flatbuffers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/flatbuffers/issues/3889/comments","statuses_url":"https://api.github.com/repos/google/flatbuffers/statuses/b1e8be27a9544b525a94612f9edbe00e306c07c4","head":{"label":"PSPDFKit-labs:james/avoid-msvc-align-error","ref":"james/avoid-msvc-align-error","sha":"b1e8be27a9544b525a94612f9edbe00e306c07c4","user":{"login":"PSPDFKit-labs","id":10983927,"avatar_url":"https://avatars.githubusercontent.com/u/10983927?v=3","gravatar_id":"","url":"https://api.github.com/users/PSPDFKit-labs","html_url":"https://github.com/PSPDFKit-labs","followers_url":"https://api.github.com/users/PSPDFKit-labs/followers","following_url":"https://api.github.com/users/PSPDFKit-labs/following{/other_user}","gists_url":"https://api.github.com/users/PSPDFKit-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/PSPDFKit-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PSPDFKit-labs/subscriptions","organizations_url":"https://api.github.com/users/PSPDFKit-labs/orgs","repos_url":"https://api.github.com/users/PSPDFKit-labs/repos","events_url":"https://api.github.com/users/PSPDFKit-labs/events{/privacy}","received_events_url":"https://api.github.com/users/PSPDFKit-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":59581008,"name":"flatbuffers","full_name":"PSPDFKit-labs/flatbuffers","owner":{"login":"PSPDFKit-labs","id":10983927,"avatar_url":"https://avatars.githubusercontent.com/u/10983927?v=3","gravatar_id":"","url":"https://api.github.com/users/PSPDFKit-labs","html_url":"https://github.com/PSPDFKit-labs","followers_url":"https://api.github.com/users/PSPDFKit-labs/followers","following_url":"https://api.github.com/users/PSPDFKit-labs/following{/other_user}","gists_url":"https://api.github.com/users/PSPDFKit-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/PSPDFKit-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PSPDFKit-labs/subscriptions","organizations_url":"https://api.github.com/users/PSPDFKit-labs/orgs","repos_url":"https://api.github.com/users/PSPDFKit-labs/repos","events_url":"https://api.github.com/users/PSPDFKit-labs/events{/privacy}","received_events_url":"https://api.github.com/users/PSPDFKit-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PSPDFKit-labs/flatbuffers","description":"Memory Efficient Serialization Library","fork":true,"url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers","forks_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/forks","keys_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/teams","hooks_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/hooks","issue_events_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/issues/events{/number}","events_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/events","assignees_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/assignees{/user}","branches_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/branches{/branch}","tags_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/tags","blobs_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/git/refs{/sha}","trees_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/statuses/{sha}","languages_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/languages","stargazers_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/stargazers","contributors_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/contributors","subscribers_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/subscribers","subscription_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/subscription","commits_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/commits{/sha}","git_commits_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/git/commits{/sha}","comments_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/comments{/number}","issue_comment_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/issues/comments{/number}","contents_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/contents/{+path}","compare_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/merges","archive_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/downloads","issues_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/issues{/number}","pulls_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/pulls{/number}","milestones_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/milestones{/number}","notifications_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/labels{/name}","releases_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/releases{/id}","deployments_url":"https://api.github.com/repos/PSPDFKit-labs/flatbuffers/deployments","created_at":"2016-05-24T14:36:14Z","updated_at":"2016-05-24T14:36:15Z","pushed_at":"2016-05-26T16:37:35Z","git_url":"git://github.com/PSPDFKit-labs/flatbuffers.git","ssh_url":"git@github.com:PSPDFKit-labs/flatbuffers.git","clone_url":"https://github.com/PSPDFKit-labs/flatbuffers.git","svn_url":"https://github.com/PSPDFKit-labs/flatbuffers","homepage":"http://google.github.io/flatbuffers/","size":2449,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"06eb6e94e34053ced993a4f689176f50e901439c","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":19953044,"name":"flatbuffers","full_name":"google/flatbuffers","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/flatbuffers","description":"Memory Efficient Serialization Library","fork":false,"url":"https://api.github.com/repos/google/flatbuffers","forks_url":"https://api.github.com/repos/google/flatbuffers/forks","keys_url":"https://api.github.com/repos/google/flatbuffers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/flatbuffers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/flatbuffers/teams","hooks_url":"https://api.github.com/repos/google/flatbuffers/hooks","issue_events_url":"https://api.github.com/repos/google/flatbuffers/issues/events{/number}","events_url":"https://api.github.com/repos/google/flatbuffers/events","assignees_url":"https://api.github.com/repos/google/flatbuffers/assignees{/user}","branches_url":"https://api.github.com/repos/google/flatbuffers/branches{/branch}","tags_url":"https://api.github.com/repos/google/flatbuffers/tags","blobs_url":"https://api.github.com/repos/google/flatbuffers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/flatbuffers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/flatbuffers/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/flatbuffers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/flatbuffers/statuses/{sha}","languages_url":"https://api.github.com/repos/google/flatbuffers/languages","stargazers_url":"https://api.github.com/repos/google/flatbuffers/stargazers","contributors_url":"https://api.github.com/repos/google/flatbuffers/contributors","subscribers_url":"https://api.github.com/repos/google/flatbuffers/subscribers","subscription_url":"https://api.github.com/repos/google/flatbuffers/subscription","commits_url":"https://api.github.com/repos/google/flatbuffers/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/flatbuffers/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/flatbuffers/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/flatbuffers/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/flatbuffers/contents/{+path}","compare_url":"https://api.github.com/repos/google/flatbuffers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/flatbuffers/merges","archive_url":"https://api.github.com/repos/google/flatbuffers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/flatbuffers/downloads","issues_url":"https://api.github.com/repos/google/flatbuffers/issues{/number}","pulls_url":"https://api.github.com/repos/google/flatbuffers/pulls{/number}","milestones_url":"https://api.github.com/repos/google/flatbuffers/milestones{/number}","notifications_url":"https://api.github.com/repos/google/flatbuffers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/flatbuffers/labels{/name}","releases_url":"https://api.github.com/repos/google/flatbuffers/releases{/id}","deployments_url":"https://api.github.com/repos/google/flatbuffers/deployments","created_at":"2014-05-19T18:33:01Z","updated_at":"2016-05-30T14:28:40Z","pushed_at":"2016-05-30T11:04:52Z","git_url":"git://github.com/google/flatbuffers.git","ssh_url":"git@github.com:google/flatbuffers.git","clone_url":"https://github.com/google/flatbuffers.git","svn_url":"https://github.com/google/flatbuffers","homepage":"http://google.github.io/flatbuffers/","size":23906,"stargazers_count":5581,"watchers_count":5581,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":772,"mirror_url":null,"open_issues_count":105,"forks":772,"open_issues":105,"watchers":5581,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/flatbuffers/pulls/3889"},"html":{"href":"https://github.com/google/flatbuffers/pull/3889"},"issue":{"href":"https://api.github.com/repos/google/flatbuffers/issues/3889"},"comments":{"href":"https://api.github.com/repos/google/flatbuffers/issues/3889/comments"},"review_comments":{"href":"https://api.github.com/repos/google/flatbuffers/pulls/3889/comments"},"review_comment":{"href":"https://api.github.com/repos/google/flatbuffers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/flatbuffers/pulls/3889/commits"},"statuses":{"href":"https://api.github.com/repos/google/flatbuffers/statuses/b1e8be27a9544b525a94612f9edbe00e306c07c4"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"phraemer"}}