{"action":"created","comment":{"url":"https://api.github.com/repos/praekelt/hellomama-registration/pulls/comments/77827525","id":77827525,"diff_hunk":"@@ -14,7 +14,7 @@\n import djcelery\n import dj_database_url\n import mimetypes\n-\n+from hellomama_registration.utils import MSG_TYPES","path":"hellomama_registration/settings.py","position":5,"original_position":5,"commit_id":"fcc20d40a802428dbb2a36fefae7fff3b6a8ff39","original_commit_id":"fcc20d40a802428dbb2a36fefae7fff3b6a8ff39","user":{"login":"rudigiesler","id":8234653,"avatar_url":"https://avatars.githubusercontent.com/u/8234653?v=3","gravatar_id":"","url":"https://api.github.com/users/rudigiesler","html_url":"https://github.com/rudigiesler","followers_url":"https://api.github.com/users/rudigiesler/followers","following_url":"https://api.github.com/users/rudigiesler/following{/other_user}","gists_url":"https://api.github.com/users/rudigiesler/gists{/gist_id}","starred_url":"https://api.github.com/users/rudigiesler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudigiesler/subscriptions","organizations_url":"https://api.github.com/users/rudigiesler/orgs","repos_url":"https://api.github.com/users/rudigiesler/repos","events_url":"https://api.github.com/users/rudigiesler/events{/privacy}","received_events_url":"https://api.github.com/users/rudigiesler/received_events","type":"User","site_admin":false},"body":"I was worried about changing the functionality too much. This way it is defined statically in code, like it was previously, whereas putting it in settings makes it a dynamic thing that can be overridden in your setting file (which is possibly better), but I'm not sure what the reason was for making it static in the first place.\r\n\r\nI don't see any reason to not put it in the settings file though","created_at":"2016-09-07T14:02:24Z","updated_at":"2016-09-07T14:02:24Z","html_url":"https://github.com/praekelt/hellomama-registration/pull/84#discussion_r77827525","pull_request_url":"https://api.github.com/repos/praekelt/hellomama-registration/pulls/84","_links":{"self":{"href":"https://api.github.com/repos/praekelt/hellomama-registration/pulls/comments/77827525"},"html":{"href":"https://github.com/praekelt/hellomama-registration/pull/84#discussion_r77827525"},"pull_request":{"href":"https://api.github.com/repos/praekelt/hellomama-registration/pulls/84"}}},"pull_request":{"url":"https://api.github.com/repos/praekelt/hellomama-registration/pulls/84","id":84293954,"html_url":"https://github.com/praekelt/hellomama-registration/pull/84","diff_url":"https://github.com/praekelt/hellomama-registration/pull/84.diff","patch_url":"https://github.com/praekelt/hellomama-registration/pull/84.patch","issue_url":"https://api.github.com/repos/praekelt/hellomama-registration/issues/84","number":84,"state":"open","locked":false,"title":"Add message_type metric","user":{"login":"rudigiesler","id":8234653,"avatar_url":"https://avatars.githubusercontent.com/u/8234653?v=3","gravatar_id":"","url":"https://api.github.com/users/rudigiesler","html_url":"https://github.com/rudigiesler","followers_url":"https://api.github.com/users/rudigiesler/followers","following_url":"https://api.github.com/users/rudigiesler/following{/other_user}","gists_url":"https://api.github.com/users/rudigiesler/gists{/gist_id}","starred_url":"https://api.github.com/users/rudigiesler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudigiesler/subscriptions","organizations_url":"https://api.github.com/users/rudigiesler/orgs","repos_url":"https://api.github.com/users/rudigiesler/repos","events_url":"https://api.github.com/users/rudigiesler/events{/privacy}","received_events_url":"https://api.github.com/users/rudigiesler/received_events","type":"User","site_admin":false},"body":"Add metric firing for each new registration namespaced by the metric_type","created_at":"2016-09-07T12:50:39Z","updated_at":"2016-09-07T14:02:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cbb6a60bd2fd0d354e8401529f11ac666df1537","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/praekelt/hellomama-registration/pulls/84/commits","review_comments_url":"https://api.github.com/repos/praekelt/hellomama-registration/pulls/84/comments","review_comment_url":"https://api.github.com/repos/praekelt/hellomama-registration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/praekelt/hellomama-registration/issues/84/comments","statuses_url":"https://api.github.com/repos/praekelt/hellomama-registration/statuses/fcc20d40a802428dbb2a36fefae7fff3b6a8ff39","head":{"label":"praekelt:feature/add-message-type-metric","ref":"feature/add-message-type-metric","sha":"fcc20d40a802428dbb2a36fefae7fff3b6a8ff39","user":{"login":"praekelt","id":81810,"avatar_url":"https://avatars.githubusercontent.com/u/81810?v=3","gravatar_id":"","url":"https://api.github.com/users/praekelt","html_url":"https://github.com/praekelt","followers_url":"https://api.github.com/users/praekelt/followers","following_url":"https://api.github.com/users/praekelt/following{/other_user}","gists_url":"https://api.github.com/users/praekelt/gists{/gist_id}","starred_url":"https://api.github.com/users/praekelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekelt/subscriptions","organizations_url":"https://api.github.com/users/praekelt/orgs","repos_url":"https://api.github.com/users/praekelt/repos","events_url":"https://api.github.com/users/praekelt/events{/privacy}","received_events_url":"https://api.github.com/users/praekelt/received_events","type":"Organization","site_admin":false},"repo":{"id":50417477,"name":"hellomama-registration","full_name":"praekelt/hellomama-registration","owner":{"login":"praekelt","id":81810,"avatar_url":"https://avatars.githubusercontent.com/u/81810?v=3","gravatar_id":"","url":"https://api.github.com/users/praekelt","html_url":"https://github.com/praekelt","followers_url":"https://api.github.com/users/praekelt/followers","following_url":"https://api.github.com/users/praekelt/following{/other_user}","gists_url":"https://api.github.com/users/praekelt/gists{/gist_id}","starred_url":"https://api.github.com/users/praekelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekelt/subscriptions","organizations_url":"https://api.github.com/users/praekelt/orgs","repos_url":"https://api.github.com/users/praekelt/repos","events_url":"https://api.github.com/users/praekelt/events{/privacy}","received_events_url":"https://api.github.com/users/praekelt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/praekelt/hellomama-registration","description":"","fork":false,"url":"https://api.github.com/repos/praekelt/hellomama-registration","forks_url":"https://api.github.com/repos/praekelt/hellomama-registration/forks","keys_url":"https://api.github.com/repos/praekelt/hellomama-registration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/praekelt/hellomama-registration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/praekelt/hellomama-registration/teams","hooks_url":"https://api.github.com/repos/praekelt/hellomama-registration/hooks","issue_events_url":"https://api.github.com/repos/praekelt/hellomama-registration/issues/events{/number}","events_url":"https://api.github.com/repos/praekelt/hellomama-registration/events","assignees_url":"https://api.github.com/repos/praekelt/hellomama-registration/assignees{/user}","branches_url":"https://api.github.com/repos/praekelt/hellomama-registration/branches{/branch}","tags_url":"https://api.github.com/repos/praekelt/hellomama-registration/tags","blobs_url":"https://api.github.com/repos/praekelt/hellomama-registration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/praekelt/hellomama-registration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/praekelt/hellomama-registration/git/refs{/sha}","trees_url":"https://api.github.com/repos/praekelt/hellomama-registration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/praekelt/hellomama-registration/statuses/{sha}","languages_url":"https://api.github.com/repos/praekelt/hellomama-registration/languages","stargazers_url":"https://api.github.com/repos/praekelt/hellomama-registration/stargazers","contributors_url":"https://api.github.com/repos/praekelt/hellomama-registration/contributors","subscribers_url":"https://api.github.com/repos/praekelt/hellomama-registration/subscribers","subscription_url":"https://api.github.com/repos/praekelt/hellomama-registration/subscription","commits_url":"https://api.github.com/repos/praekelt/hellomama-registration/commits{/sha}","git_commits_url":"https://api.github.com/repos/praekelt/hellomama-registration/git/commits{/sha}","comments_url":"https://api.github.com/repos/praekelt/hellomama-registration/comments{/number}","issue_comment_url":"https://api.github.com/repos/praekelt/hellomama-registration/issues/comments{/number}","contents_url":"https://api.github.com/repos/praekelt/hellomama-registration/contents/{+path}","compare_url":"https://api.github.com/repos/praekelt/hellomama-registration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/praekelt/hellomama-registration/merges","archive_url":"https://api.github.com/repos/praekelt/hellomama-registration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/praekelt/hellomama-registration/downloads","issues_url":"https://api.github.com/repos/praekelt/hellomama-registration/issues{/number}","pulls_url":"https://api.github.com/repos/praekelt/hellomama-registration/pulls{/number}","milestones_url":"https://api.github.com/repos/praekelt/hellomama-registration/milestones{/number}","notifications_url":"https://api.github.com/repos/praekelt/hellomama-registration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/praekelt/hellomama-registration/labels{/name}","releases_url":"https://api.github.com/repos/praekelt/hellomama-registration/releases{/id}","deployments_url":"https://api.github.com/repos/praekelt/hellomama-registration/deployments","created_at":"2016-01-26T09:15:27Z","updated_at":"2016-02-19T12:28:04Z","pushed_at":"2016-09-07T13:58:50Z","git_url":"git://github.com/praekelt/hellomama-registration.git","ssh_url":"git@github.com:praekelt/hellomama-registration.git","clone_url":"https://github.com/praekelt/hellomama-registration.git","svn_url":"https://github.com/praekelt/hellomama-registration","homepage":null,"size":104798,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":0,"default_branch":"develop"}},"base":{"label":"praekelt:develop","ref":"develop","sha":"cb52e7b1a507ca7b6065c6994d11d3c07a41e6f1","user":{"login":"praekelt","id":81810,"avatar_url":"https://avatars.githubusercontent.com/u/81810?v=3","gravatar_id":"","url":"https://api.github.com/users/praekelt","html_url":"https://github.com/praekelt","followers_url":"https://api.github.com/users/praekelt/followers","following_url":"https://api.github.com/users/praekelt/following{/other_user}","gists_url":"https://api.github.com/users/praekelt/gists{/gist_id}","starred_url":"https://api.github.com/users/praekelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekelt/subscriptions","organizations_url":"https://api.github.com/users/praekelt/orgs","repos_url":"https://api.github.com/users/praekelt/repos","events_url":"https://api.github.com/users/praekelt/events{/privacy}","received_events_url":"https://api.github.com/users/praekelt/received_events","type":"Organization","site_admin":false},"repo":{"id":50417477,"name":"hellomama-registration","full_name":"praekelt/hellomama-registration","owner":{"login":"praekelt","id":81810,"avatar_url":"https://avatars.githubusercontent.com/u/81810?v=3","gravatar_id":"","url":"https://api.github.com/users/praekelt","html_url":"https://github.com/praekelt","followers_url":"https://api.github.com/users/praekelt/followers","following_url":"https://api.github.com/users/praekelt/following{/other_user}","gists_url":"https://api.github.com/users/praekelt/gists{/gist_id}","starred_url":"https://api.github.com/users/praekelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekelt/subscriptions","organizations_url":"https://api.github.com/users/praekelt/orgs","repos_url":"https://api.github.com/users/praekelt/repos","events_url":"https://api.github.com/users/praekelt/events{/privacy}","received_events_url":"https://api.github.com/users/praekelt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/praekelt/hellomama-registration","description":"","fork":false,"url":"https://api.github.com/repos/praekelt/hellomama-registration","forks_url":"https://api.github.com/repos/praekelt/hellomama-registration/forks","keys_url":"https://api.github.com/repos/praekelt/hellomama-registration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/praekelt/hellomama-registration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/praekelt/hellomama-registration/teams","hooks_url":"https://api.github.com/repos/praekelt/hellomama-registration/hooks","issue_events_url":"https://api.github.com/repos/praekelt/hellomama-registration/issues/events{/number}","events_url":"https://api.github.com/repos/praekelt/hellomama-registration/events","assignees_url":"https://api.github.com/repos/praekelt/hellomama-registration/assignees{/user}","branches_url":"https://api.github.com/repos/praekelt/hellomama-registration/branches{/branch}","tags_url":"https://api.github.com/repos/praekelt/hellomama-registration/tags","blobs_url":"https://api.github.com/repos/praekelt/hellomama-registration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/praekelt/hellomama-registration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/praekelt/hellomama-registration/git/refs{/sha}","trees_url":"https://api.github.com/repos/praekelt/hellomama-registration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/praekelt/hellomama-registration/statuses/{sha}","languages_url":"https://api.github.com/repos/praekelt/hellomama-registration/languages","stargazers_url":"https://api.github.com/repos/praekelt/hellomama-registration/stargazers","contributors_url":"https://api.github.com/repos/praekelt/hellomama-registration/contributors","subscribers_url":"https://api.github.com/repos/praekelt/hellomama-registration/subscribers","subscription_url":"https://api.github.com/repos/praekelt/hellomama-registration/subscription","commits_url":"https://api.github.com/repos/praekelt/hellomama-registration/commits{/sha}","git_commits_url":"https://api.github.com/repos/praekelt/hellomama-registration/git/commits{/sha}","comments_url":"https://api.github.com/repos/praekelt/hellomama-registration/comments{/number}","issue_comment_url":"https://api.github.com/repos/praekelt/hellomama-registration/issues/comments{/number}","contents_url":"https://api.github.com/repos/praekelt/hellomama-registration/contents/{+path}","compare_url":"https://api.github.com/repos/praekelt/hellomama-registration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/praekelt/hellomama-registration/merges","archive_url":"https://api.github.com/repos/praekelt/hellomama-registration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/praekelt/hellomama-registration/downloads","issues_url":"https://api.github.com/repos/praekelt/hellomama-registration/issues{/number}","pulls_url":"https://api.github.com/repos/praekelt/hellomama-registration/pulls{/number}","milestones_url":"https://api.github.com/repos/praekelt/hellomama-registration/milestones{/number}","notifications_url":"https://api.github.com/repos/praekelt/hellomama-registration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/praekelt/hellomama-registration/labels{/name}","releases_url":"https://api.github.com/repos/praekelt/hellomama-registration/releases{/id}","deployments_url":"https://api.github.com/repos/praekelt/hellomama-registration/deployments","created_at":"2016-01-26T09:15:27Z","updated_at":"2016-02-19T12:28:04Z","pushed_at":"2016-09-07T13:58:50Z","git_url":"git://github.com/praekelt/hellomama-registration.git","ssh_url":"git@github.com:praekelt/hellomama-registration.git","clone_url":"https://github.com/praekelt/hellomama-registration.git","svn_url":"https://github.com/praekelt/hellomama-registration","homepage":null,"size":104798,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/praekelt/hellomama-registration/pulls/84"},"html":{"href":"https://github.com/praekelt/hellomama-registration/pull/84"},"issue":{"href":"https://api.github.com/repos/praekelt/hellomama-registration/issues/84"},"comments":{"href":"https://api.github.com/repos/praekelt/hellomama-registration/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/praekelt/hellomama-registration/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/praekelt/hellomama-registration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/praekelt/hellomama-registration/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/praekelt/hellomama-registration/statuses/fcc20d40a802428dbb2a36fefae7fff3b6a8ff39"}}}}
{"actor":{"display_login":"rudigiesler"}}