{"action":"created","comment":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/76460619","id":76460619,"diff_hunk":"@@ -594,6 +594,10 @@ private boolean isDirectory(String path) throws IOException {\n       }\n     }\n \n+    if (self.length() == 0) {","path":"underfs/swift/src/main/java/alluxio/underfs/swift/SwiftUnderFileSystem.java","position":13,"original_position":13,"commit_id":"d319111f887a27ecf3cdc21d829306aa4178e69b","original_commit_id":"d319111f887a27ecf3cdc21d829306aa4178e69b","user":{"login":"calvinjia","id":2223813,"avatar_url":"https://avatars.githubusercontent.com/u/2223813?v=3","gravatar_id":"","url":"https://api.github.com/users/calvinjia","html_url":"https://github.com/calvinjia","followers_url":"https://api.github.com/users/calvinjia/followers","following_url":"https://api.github.com/users/calvinjia/following{/other_user}","gists_url":"https://api.github.com/users/calvinjia/gists{/gist_id}","starred_url":"https://api.github.com/users/calvinjia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvinjia/subscriptions","organizations_url":"https://api.github.com/users/calvinjia/orgs","repos_url":"https://api.github.com/users/calvinjia/repos","events_url":"https://api.github.com/users/calvinjia/events{/privacy}","received_events_url":"https://api.github.com/users/calvinjia/received_events","type":"User","site_admin":false},"body":"Is `isRoot(self)` a more logical condition to check?","created_at":"2016-08-26T17:56:17Z","updated_at":"2016-08-26T17:56:17Z","html_url":"https://github.com/Alluxio/alluxio/pull/3866#discussion_r76460619","pull_request_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/3866","_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/76460619"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/3866#discussion_r76460619"},"pull_request":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/3866"}}},"pull_request":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/3866","id":82826294,"html_url":"https://github.com/Alluxio/alluxio/pull/3866","diff_url":"https://github.com/Alluxio/alluxio/pull/3866.diff","patch_url":"https://github.com/Alluxio/alluxio/pull/3866.patch","issue_url":"https://api.github.com/repos/Alluxio/alluxio/issues/3866","number":3866,"state":"open","locked":false,"title":"[ALLUXIO-2211] Fix recursive loadMetadata of a Swift directory","user":{"login":"madanadit","id":2262458,"avatar_url":"https://avatars.githubusercontent.com/u/2262458?v=3","gravatar_id":"","url":"https://api.github.com/users/madanadit","html_url":"https://github.com/madanadit","followers_url":"https://api.github.com/users/madanadit/followers","following_url":"https://api.github.com/users/madanadit/following{/other_user}","gists_url":"https://api.github.com/users/madanadit/gists{/gist_id}","starred_url":"https://api.github.com/users/madanadit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madanadit/subscriptions","organizations_url":"https://api.github.com/users/madanadit/orgs","repos_url":"https://api.github.com/users/madanadit/repos","events_url":"https://api.github.com/users/madanadit/events{/privacy}","received_events_url":"https://api.github.com/users/madanadit/received_events","type":"User","site_admin":false},"body":"This addresses https://alluxio.atlassian.net/browse/ALLUXIO-2211.\r\n\r\nThe core problem is that FileSystemMaster:loadMetadataAndJournal calls list as follows:\r\nString[] files = ufs.list(ufsUri.getPath());\r\n\r\ngetPath eliminates the 'swift://container/' scheme from the uri. The Swift UFS and some others I presume expect that the scheme is present. Although others are more robust to an absence. This PR makes Swift more robust.\r\n\r\nI will address correct loadMetadataAndJournal to pass the fully qualified path to a UFS in a later PR which establishes a contract with all UFSs.","created_at":"2016-08-26T03:16:30Z","updated_at":"2016-08-26T17:56:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3486bbc56a47be2bb514d00f3fcbd3c630922c0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/3866/commits","review_comments_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/3866/comments","review_comment_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/issues/3866/comments","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/d319111f887a27ecf3cdc21d829306aa4178e69b","head":{"label":"madanadit:swift-loadmeta","ref":"swift-loadmeta","sha":"d319111f887a27ecf3cdc21d829306aa4178e69b","user":{"login":"madanadit","id":2262458,"avatar_url":"https://avatars.githubusercontent.com/u/2262458?v=3","gravatar_id":"","url":"https://api.github.com/users/madanadit","html_url":"https://github.com/madanadit","followers_url":"https://api.github.com/users/madanadit/followers","following_url":"https://api.github.com/users/madanadit/following{/other_user}","gists_url":"https://api.github.com/users/madanadit/gists{/gist_id}","starred_url":"https://api.github.com/users/madanadit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madanadit/subscriptions","organizations_url":"https://api.github.com/users/madanadit/orgs","repos_url":"https://api.github.com/users/madanadit/repos","events_url":"https://api.github.com/users/madanadit/events{/privacy}","received_events_url":"https://api.github.com/users/madanadit/received_events","type":"User","site_admin":false},"repo":{"id":61668690,"name":"alluxio","full_name":"madanadit/alluxio","owner":{"login":"madanadit","id":2262458,"avatar_url":"https://avatars.githubusercontent.com/u/2262458?v=3","gravatar_id":"","url":"https://api.github.com/users/madanadit","html_url":"https://github.com/madanadit","followers_url":"https://api.github.com/users/madanadit/followers","following_url":"https://api.github.com/users/madanadit/following{/other_user}","gists_url":"https://api.github.com/users/madanadit/gists{/gist_id}","starred_url":"https://api.github.com/users/madanadit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madanadit/subscriptions","organizations_url":"https://api.github.com/users/madanadit/orgs","repos_url":"https://api.github.com/users/madanadit/repos","events_url":"https://api.github.com/users/madanadit/events{/privacy}","received_events_url":"https://api.github.com/users/madanadit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/madanadit/alluxio","description":"Alluxio, formerly Tachyon, Memory Speed Virtual Distributed Storage System","fork":true,"url":"https://api.github.com/repos/madanadit/alluxio","forks_url":"https://api.github.com/repos/madanadit/alluxio/forks","keys_url":"https://api.github.com/repos/madanadit/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/madanadit/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/madanadit/alluxio/teams","hooks_url":"https://api.github.com/repos/madanadit/alluxio/hooks","issue_events_url":"https://api.github.com/repos/madanadit/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/madanadit/alluxio/events","assignees_url":"https://api.github.com/repos/madanadit/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/madanadit/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/madanadit/alluxio/tags","blobs_url":"https://api.github.com/repos/madanadit/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/madanadit/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/madanadit/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/madanadit/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/madanadit/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/madanadit/alluxio/languages","stargazers_url":"https://api.github.com/repos/madanadit/alluxio/stargazers","contributors_url":"https://api.github.com/repos/madanadit/alluxio/contributors","subscribers_url":"https://api.github.com/repos/madanadit/alluxio/subscribers","subscription_url":"https://api.github.com/repos/madanadit/alluxio/subscription","commits_url":"https://api.github.com/repos/madanadit/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/madanadit/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/madanadit/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/madanadit/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/madanadit/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/madanadit/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/madanadit/alluxio/merges","archive_url":"https://api.github.com/repos/madanadit/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/madanadit/alluxio/downloads","issues_url":"https://api.github.com/repos/madanadit/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/madanadit/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/madanadit/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/madanadit/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/madanadit/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/madanadit/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/madanadit/alluxio/deployments","created_at":"2016-06-21T21:34:10Z","updated_at":"2016-06-21T21:34:15Z","pushed_at":"2016-08-26T03:03:24Z","git_url":"git://github.com/madanadit/alluxio.git","ssh_url":"git@github.com:madanadit/alluxio.git","clone_url":"https://github.com/madanadit/alluxio.git","svn_url":"https://github.com/madanadit/alluxio","homepage":"http://www.alluxio.org/","size":58670,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Alluxio:master","ref":"master","sha":"76088bae4af8cdb5e5b5fd3067024dd43b0ec99e","user":{"login":"Alluxio","id":16203694,"avatar_url":"https://avatars.githubusercontent.com/u/16203694?v=3","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"alluxio","full_name":"Alluxio/alluxio","owner":{"login":"Alluxio","id":16203694,"avatar_url":"https://avatars.githubusercontent.com/u/16203694?v=3","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alluxio/alluxio","description":"Alluxio, formerly Tachyon, Memory Speed Virtual Distributed Storage System","fork":false,"url":"https://api.github.com/repos/Alluxio/alluxio","forks_url":"https://api.github.com/repos/Alluxio/alluxio/forks","keys_url":"https://api.github.com/repos/Alluxio/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alluxio/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alluxio/alluxio/teams","hooks_url":"https://api.github.com/repos/Alluxio/alluxio/hooks","issue_events_url":"https://api.github.com/repos/Alluxio/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/Alluxio/alluxio/events","assignees_url":"https://api.github.com/repos/Alluxio/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/Alluxio/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/Alluxio/alluxio/tags","blobs_url":"https://api.github.com/repos/Alluxio/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alluxio/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alluxio/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alluxio/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/Alluxio/alluxio/languages","stargazers_url":"https://api.github.com/repos/Alluxio/alluxio/stargazers","contributors_url":"https://api.github.com/repos/Alluxio/alluxio/contributors","subscribers_url":"https://api.github.com/repos/Alluxio/alluxio/subscribers","subscription_url":"https://api.github.com/repos/Alluxio/alluxio/subscription","commits_url":"https://api.github.com/repos/Alluxio/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alluxio/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alluxio/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alluxio/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/Alluxio/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alluxio/alluxio/merges","archive_url":"https://api.github.com/repos/Alluxio/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alluxio/alluxio/downloads","issues_url":"https://api.github.com/repos/Alluxio/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/Alluxio/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/Alluxio/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/Alluxio/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alluxio/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/Alluxio/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/Alluxio/alluxio/deployments","created_at":"2012-12-21T17:43:46Z","updated_at":"2016-08-25T17:57:01Z","pushed_at":"2016-08-26T17:52:38Z","git_url":"git://github.com/Alluxio/alluxio.git","ssh_url":"git@github.com:Alluxio/alluxio.git","clone_url":"https://github.com/Alluxio/alluxio.git","svn_url":"https://github.com/Alluxio/alluxio","homepage":"http://www.alluxio.org/","size":90951,"stargazers_count":2565,"watchers_count":2565,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1062,"mirror_url":null,"open_issues_count":19,"forks":1062,"open_issues":19,"watchers":2565,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/3866"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/3866"},"issue":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/3866"},"comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/3866/comments"},"review_comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/3866/comments"},"review_comment":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/3866/commits"},"statuses":{"href":"https://api.github.com/repos/Alluxio/alluxio/statuses/d319111f887a27ecf3cdc21d829306aa4178e69b"}}}}
{"actor":{"display_login":"calvinjia"}}