{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25945","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25945/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25945/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25945/events","html_url":"https://github.com/kubernetes/kubernetes/pull/25945","id":155886321,"number":25945,"title":"cache: reflector should never stop watching","user":{"login":"xiang90","id":4479947,"avatar_url":"https://avatars.githubusercontent.com/u/4479947?v=3","gravatar_id":"","url":"https://api.github.com/users/xiang90","html_url":"https://github.com/xiang90","followers_url":"https://api.github.com/users/xiang90/followers","following_url":"https://api.github.com/users/xiang90/following{/other_user}","gists_url":"https://api.github.com/users/xiang90/gists{/gist_id}","starred_url":"https://api.github.com/users/xiang90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiang90/subscriptions","organizations_url":"https://api.github.com/users/xiang90/orgs","repos_url":"https://api.github.com/users/xiang90/repos","events_url":"https://api.github.com/users/xiang90/events{/privacy}","received_events_url":"https://api.github.com/users/xiang90/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-label-needed","name":"release-note-label-needed","color":"db5a64"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00"}],"state":"open","locked":false,"assignee":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2016-05-20T04:48:28Z","updated_at":"2016-05-20T05:38:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25945","html_url":"https://github.com/kubernetes/kubernetes/pull/25945","diff_url":"https://github.com/kubernetes/kubernetes/pull/25945.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/25945.patch"},"body":"A recent change tries to separate resync and relist. The motivation\r\nwas to avoid triggering relist when a resync is required.\r\n\r\nHowever, the change is not effective since it stops the watcher. As hongchao\r\nmentioned in the original comment, today's storage interface will not deliever\r\nany progress notification to the watch chan. So any watcher that does not receive\r\nevents for the last few seconds will not be able to catch up from the previous\r\nindex after a hard close since the index of the last received event is out of\r\nthe cache window inside etcd2.\r\n\r\nThis pull request tries to fix this issue by not stoping watcher when a resync is\r\nrequired.\r\n\r\n/cc @hongchaodeng @wojtek-t @timothysc @rrati @smarterclayton "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/220521525","html_url":"https://github.com/kubernetes/kubernetes/pull/25945#issuecomment-220521525","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25945","id":220521525,"user":{"login":"k8s-bot","id":12551979,"avatar_url":"https://avatars.githubusercontent.com/u/12551979?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-bot","html_url":"https://github.com/k8s-bot","followers_url":"https://api.github.com/users/k8s-bot/followers","following_url":"https://api.github.com/users/k8s-bot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-bot/subscriptions","organizations_url":"https://api.github.com/users/k8s-bot/orgs","repos_url":"https://api.github.com/users/k8s-bot/repos","events_url":"https://api.github.com/users/k8s-bot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-bot/received_events","type":"User","site_admin":false},"created_at":"2016-05-20T05:38:07Z","updated_at":"2016-05-20T05:38:07Z","body":"GCE e2e build/test **passed** for commit daf26ba20a76dcb607855eeb07f1c91f060e196f.\n* [Build Log](http://pr-test.k8s.io/25945/kubernetes-pull-build-test-e2e-gce/40995/build-log.txt)\n* [Test Artifacts](https://console.developers.google.com/storage/browser/kubernetes-jenkins/pr-logs/pull/25945/kubernetes-pull-build-test-e2e-gce/40995/artifacts/)\n* [Internal Jenkins Results](http://goto.google.com/prkubekins/job/kubernetes-pull-build-test-e2e-gce//40995)\n"}}
{"actor":{"display_login":"k8s-bot"}}