{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/53307701","id":53307701,"diff_hunk":"@@ -28,10 +29,21 @@ impl ByteString {\n         str::from_utf8(&vec).ok()\n     }\n \n+    /// Returns ownership of the underlying Vec<u8> the ByteString is\n+    /// unusable afterwards as it has been moved","path":"components/script/dom/bindings/str.rs","position":13,"original_position":13,"commit_id":"e86fa360851aa751a829a31b07f3e2e4a4a4da1a","original_commit_id":"e86fa360851aa751a829a31b07f3e2e4a4a4da1a","user":{"login":"danlrobertson","id":7504153,"avatar_url":"https://avatars.githubusercontent.com/u/7504153?v=3","gravatar_id":"","url":"https://api.github.com/users/danlrobertson","html_url":"https://github.com/danlrobertson","followers_url":"https://api.github.com/users/danlrobertson/followers","following_url":"https://api.github.com/users/danlrobertson/following{/other_user}","gists_url":"https://api.github.com/users/danlrobertson/gists{/gist_id}","starred_url":"https://api.github.com/users/danlrobertson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danlrobertson/subscriptions","organizations_url":"https://api.github.com/users/danlrobertson/orgs","repos_url":"https://api.github.com/users/danlrobertson/repos","events_url":"https://api.github.com/users/danlrobertson/events{/privacy}","received_events_url":"https://api.github.com/users/danlrobertson/received_events","type":"User","site_admin":false},"body":"Much better documentation!","created_at":"2016-02-18T12:35:21Z","updated_at":"2016-02-18T12:35:21Z","html_url":"https://github.com/servo/servo/pull/9684#discussion_r53307701","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/9684","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/53307701"},"html":{"href":"https://github.com/servo/servo/pull/9684#discussion_r53307701"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/9684"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/9684","id":59715231,"html_url":"https://github.com/servo/servo/pull/9684","diff_url":"https://github.com/servo/servo/pull/9684.diff","patch_url":"https://github.com/servo/servo/pull/9684.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/9684","number":9684,"state":"open","locked":false,"title":"Add methods to move ByteStrings underlying bytes","user":{"login":"danlrobertson","id":7504153,"avatar_url":"https://avatars.githubusercontent.com/u/7504153?v=3","gravatar_id":"","url":"https://api.github.com/users/danlrobertson","html_url":"https://github.com/danlrobertson","followers_url":"https://api.github.com/users/danlrobertson/followers","following_url":"https://api.github.com/users/danlrobertson/following{/other_user}","gists_url":"https://api.github.com/users/danlrobertson/gists{/gist_id}","starred_url":"https://api.github.com/users/danlrobertson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danlrobertson/subscriptions","organizations_url":"https://api.github.com/users/danlrobertson/orgs","repos_url":"https://api.github.com/users/danlrobertson/repos","events_url":"https://api.github.com/users/danlrobertson/events{/privacy}","received_events_url":"https://api.github.com/users/danlrobertson/received_events","type":"User","site_admin":false},"body":"Add methods to move the underlying `Vec<u8>` for `ByteString`.\r\n\r\nI saw this as at least two methods. One to \"move and replace with and empty Vec<u8> (`bytes`), and one to take ownership of the whole object (`own_bytes`). I typically also don't like adding methods with out unit tests. If you think they're unnecessary, just let me know.\r\n\r\nAs always, please let me know if you have any comments, critiques, or nits!\r\n\r\nFixes #9655\r\n\r\n<!-- Reviewable:start -->\r\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/servo/servo/9684)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-02-17T21:57:20Z","updated_at":"2016-02-18T12:35:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96f2995368f513141fbc129641d4a5f3715e1f05","assignee":{"login":"KiChjang","id":3248587,"avatar_url":"https://avatars.githubusercontent.com/u/3248587?v=3","gravatar_id":"","url":"https://api.github.com/users/KiChjang","html_url":"https://github.com/KiChjang","followers_url":"https://api.github.com/users/KiChjang/followers","following_url":"https://api.github.com/users/KiChjang/following{/other_user}","gists_url":"https://api.github.com/users/KiChjang/gists{/gist_id}","starred_url":"https://api.github.com/users/KiChjang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiChjang/subscriptions","organizations_url":"https://api.github.com/users/KiChjang/orgs","repos_url":"https://api.github.com/users/KiChjang/repos","events_url":"https://api.github.com/users/KiChjang/events{/privacy}","received_events_url":"https://api.github.com/users/KiChjang/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/9684/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/9684/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/9684/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/e86fa360851aa751a829a31b07f3e2e4a4a4da1a","head":{"label":"danlrobertson:i9655","ref":"i9655","sha":"e86fa360851aa751a829a31b07f3e2e4a4a4da1a","user":{"login":"danlrobertson","id":7504153,"avatar_url":"https://avatars.githubusercontent.com/u/7504153?v=3","gravatar_id":"","url":"https://api.github.com/users/danlrobertson","html_url":"https://github.com/danlrobertson","followers_url":"https://api.github.com/users/danlrobertson/followers","following_url":"https://api.github.com/users/danlrobertson/following{/other_user}","gists_url":"https://api.github.com/users/danlrobertson/gists{/gist_id}","starred_url":"https://api.github.com/users/danlrobertson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danlrobertson/subscriptions","organizations_url":"https://api.github.com/users/danlrobertson/orgs","repos_url":"https://api.github.com/users/danlrobertson/repos","events_url":"https://api.github.com/users/danlrobertson/events{/privacy}","received_events_url":"https://api.github.com/users/danlrobertson/received_events","type":"User","site_admin":false},"repo":{"id":51486306,"name":"servo","full_name":"danlrobertson/servo","owner":{"login":"danlrobertson","id":7504153,"avatar_url":"https://avatars.githubusercontent.com/u/7504153?v=3","gravatar_id":"","url":"https://api.github.com/users/danlrobertson","html_url":"https://github.com/danlrobertson","followers_url":"https://api.github.com/users/danlrobertson/followers","following_url":"https://api.github.com/users/danlrobertson/following{/other_user}","gists_url":"https://api.github.com/users/danlrobertson/gists{/gist_id}","starred_url":"https://api.github.com/users/danlrobertson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danlrobertson/subscriptions","organizations_url":"https://api.github.com/users/danlrobertson/orgs","repos_url":"https://api.github.com/users/danlrobertson/repos","events_url":"https://api.github.com/users/danlrobertson/events{/privacy}","received_events_url":"https://api.github.com/users/danlrobertson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danlrobertson/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/danlrobertson/servo","forks_url":"https://api.github.com/repos/danlrobertson/servo/forks","keys_url":"https://api.github.com/repos/danlrobertson/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danlrobertson/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danlrobertson/servo/teams","hooks_url":"https://api.github.com/repos/danlrobertson/servo/hooks","issue_events_url":"https://api.github.com/repos/danlrobertson/servo/issues/events{/number}","events_url":"https://api.github.com/repos/danlrobertson/servo/events","assignees_url":"https://api.github.com/repos/danlrobertson/servo/assignees{/user}","branches_url":"https://api.github.com/repos/danlrobertson/servo/branches{/branch}","tags_url":"https://api.github.com/repos/danlrobertson/servo/tags","blobs_url":"https://api.github.com/repos/danlrobertson/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danlrobertson/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danlrobertson/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/danlrobertson/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danlrobertson/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/danlrobertson/servo/languages","stargazers_url":"https://api.github.com/repos/danlrobertson/servo/stargazers","contributors_url":"https://api.github.com/repos/danlrobertson/servo/contributors","subscribers_url":"https://api.github.com/repos/danlrobertson/servo/subscribers","subscription_url":"https://api.github.com/repos/danlrobertson/servo/subscription","commits_url":"https://api.github.com/repos/danlrobertson/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/danlrobertson/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/danlrobertson/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/danlrobertson/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/danlrobertson/servo/contents/{+path}","compare_url":"https://api.github.com/repos/danlrobertson/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danlrobertson/servo/merges","archive_url":"https://api.github.com/repos/danlrobertson/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danlrobertson/servo/downloads","issues_url":"https://api.github.com/repos/danlrobertson/servo/issues{/number}","pulls_url":"https://api.github.com/repos/danlrobertson/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/danlrobertson/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/danlrobertson/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danlrobertson/servo/labels{/name}","releases_url":"https://api.github.com/repos/danlrobertson/servo/releases{/id}","deployments_url":"https://api.github.com/repos/danlrobertson/servo/deployments","created_at":"2016-02-11T01:14:21Z","updated_at":"2016-02-10T10:56:02Z","pushed_at":"2016-02-18T03:04:58Z","git_url":"git://github.com/danlrobertson/servo.git","ssh_url":"git@github.com:danlrobertson/servo.git","clone_url":"https://github.com/danlrobertson/servo.git","svn_url":"https://github.com/danlrobertson/servo","homepage":"https://servo.org/","size":170665,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"bc034845b7e543e4e71fa21d6bf99e9f10ddb6c5","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2016-02-18T12:30:25Z","pushed_at":"2016-02-18T12:18:17Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":205067,"stargazers_count":5655,"watchers_count":5655,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":965,"mirror_url":null,"open_issues_count":1292,"forks":965,"open_issues":1292,"watchers":5655,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/9684"},"html":{"href":"https://github.com/servo/servo/pull/9684"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/9684"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/9684/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/9684/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/9684/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/e86fa360851aa751a829a31b07f3e2e4a4a4da1a"}}}}