{"action":"created","comment":{"url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments/89542049","pull_request_review_id":10088019,"id":89542049,"diff_hunk":"@@ -352,15 +366,15 @@ public boolean equals(Object obj) {\n                     return false;\n                 }\n             }\n-            else if ( !sourceType.equals( other.sourceType ) ) {\n+            else if ( !sourceType.erasure().equals( other.sourceType.erasure() ) ) {","path":"processor/src/main/java/org/mapstruct/ap/internal/conversion/Conversions.java","position":76,"original_position":76,"commit_id":"2cf4e5fe14a6d83b60d96a3134bf22daa2346bc0","original_commit_id":"2cf4e5fe14a6d83b60d96a3134bf22daa2346bc0","user":{"login":"filiphr","id":6012094,"avatar_url":"https://avatars.githubusercontent.com/u/6012094?v=3","gravatar_id":"","url":"https://api.github.com/users/filiphr","html_url":"https://github.com/filiphr","followers_url":"https://api.github.com/users/filiphr/followers","following_url":"https://api.github.com/users/filiphr/following{/other_user}","gists_url":"https://api.github.com/users/filiphr/gists{/gist_id}","starred_url":"https://api.github.com/users/filiphr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filiphr/subscriptions","organizations_url":"https://api.github.com/users/filiphr/orgs","repos_url":"https://api.github.com/users/filiphr/repos","events_url":"https://api.github.com/users/filiphr/events{/privacy}","received_events_url":"https://api.github.com/users/filiphr/received_events","type":"User","site_admin":false},"body":"This is another point where I was not sure. If they are removed then the conversions are not found.\r\nIt seems that the type `Iterable<T>` is not the same to `Iterable<T>` (I don't know why)","created_at":"2016-11-24T19:51:20Z","updated_at":"2016-11-24T19:51:20Z","html_url":"https://github.com/mapstruct/mapstruct/pull/964#discussion_r89542049","pull_request_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/964","_links":{"self":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments/89542049"},"html":{"href":"https://github.com/mapstruct/mapstruct/pull/964#discussion_r89542049"},"pull_request":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/964"}}},"pull_request":{"url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/964","id":94897045,"html_url":"https://github.com/mapstruct/mapstruct/pull/964","diff_url":"https://github.com/mapstruct/mapstruct/pull/964.diff","patch_url":"https://github.com/mapstruct/mapstruct/pull/964.patch","issue_url":"https://api.github.com/repos/mapstruct/mapstruct/issues/964","number":964,"state":"open","locked":false,"title":"#962 Java 8 Stream conversions to Collections","user":{"login":"filiphr","id":6012094,"avatar_url":"https://avatars.githubusercontent.com/u/6012094?v=3","gravatar_id":"","url":"https://api.github.com/users/filiphr","html_url":"https://github.com/filiphr","followers_url":"https://api.github.com/users/filiphr/followers","following_url":"https://api.github.com/users/filiphr/following{/other_user}","gists_url":"https://api.github.com/users/filiphr/gists{/gist_id}","starred_url":"https://api.github.com/users/filiphr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filiphr/subscriptions","organizations_url":"https://api.github.com/users/filiphr/orgs","repos_url":"https://api.github.com/users/filiphr/repos","events_url":"https://api.github.com/users/filiphr/events{/privacy}","received_events_url":"https://api.github.com/users/filiphr/received_events","type":"User","site_admin":false},"body":"This PR covers the easier part of #962 (converting a `Stream` to some collection type).  The implementation type are same as for the [collection mappings](http://mapstruct.org/documentation/1.1/reference/html/index.html#implementation-types-for-collection-mappings) (without the `Map` implementations of course 😄)\r\n\r\nDocumentation is not updated, once this is resolved I will update the documentation.\r\n\r\nAlso I am not sure why, but in the generated mappers there are no null checks for the Stream conversions. What am I doing wrong?\r\n\r\n","created_at":"2016-11-22T21:00:08Z","updated_at":"2016-11-24T19:51:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32cc3a013dcfd33f06f74ac6496d8e75f330eec2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/964/commits","review_comments_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/964/comments","review_comment_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapstruct/mapstruct/issues/964/comments","statuses_url":"https://api.github.com/repos/mapstruct/mapstruct/statuses/2cf4e5fe14a6d83b60d96a3134bf22daa2346bc0","head":{"label":"filiphr:java8-stream-conversions","ref":"java8-stream-conversions","sha":"2cf4e5fe14a6d83b60d96a3134bf22daa2346bc0","user":{"login":"filiphr","id":6012094,"avatar_url":"https://avatars.githubusercontent.com/u/6012094?v=3","gravatar_id":"","url":"https://api.github.com/users/filiphr","html_url":"https://github.com/filiphr","followers_url":"https://api.github.com/users/filiphr/followers","following_url":"https://api.github.com/users/filiphr/following{/other_user}","gists_url":"https://api.github.com/users/filiphr/gists{/gist_id}","starred_url":"https://api.github.com/users/filiphr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filiphr/subscriptions","organizations_url":"https://api.github.com/users/filiphr/orgs","repos_url":"https://api.github.com/users/filiphr/repos","events_url":"https://api.github.com/users/filiphr/events{/privacy}","received_events_url":"https://api.github.com/users/filiphr/received_events","type":"User","site_admin":false},"repo":{"id":66302052,"name":"mapstruct","full_name":"filiphr/mapstruct","owner":{"login":"filiphr","id":6012094,"avatar_url":"https://avatars.githubusercontent.com/u/6012094?v=3","gravatar_id":"","url":"https://api.github.com/users/filiphr","html_url":"https://github.com/filiphr","followers_url":"https://api.github.com/users/filiphr/followers","following_url":"https://api.github.com/users/filiphr/following{/other_user}","gists_url":"https://api.github.com/users/filiphr/gists{/gist_id}","starred_url":"https://api.github.com/users/filiphr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filiphr/subscriptions","organizations_url":"https://api.github.com/users/filiphr/orgs","repos_url":"https://api.github.com/users/filiphr/repos","events_url":"https://api.github.com/users/filiphr/events{/privacy}","received_events_url":"https://api.github.com/users/filiphr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/filiphr/mapstruct","description":"An annotation processor for generating type-safe bean mappers","fork":true,"url":"https://api.github.com/repos/filiphr/mapstruct","forks_url":"https://api.github.com/repos/filiphr/mapstruct/forks","keys_url":"https://api.github.com/repos/filiphr/mapstruct/keys{/key_id}","collaborators_url":"https://api.github.com/repos/filiphr/mapstruct/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/filiphr/mapstruct/teams","hooks_url":"https://api.github.com/repos/filiphr/mapstruct/hooks","issue_events_url":"https://api.github.com/repos/filiphr/mapstruct/issues/events{/number}","events_url":"https://api.github.com/repos/filiphr/mapstruct/events","assignees_url":"https://api.github.com/repos/filiphr/mapstruct/assignees{/user}","branches_url":"https://api.github.com/repos/filiphr/mapstruct/branches{/branch}","tags_url":"https://api.github.com/repos/filiphr/mapstruct/tags","blobs_url":"https://api.github.com/repos/filiphr/mapstruct/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/filiphr/mapstruct/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/filiphr/mapstruct/git/refs{/sha}","trees_url":"https://api.github.com/repos/filiphr/mapstruct/git/trees{/sha}","statuses_url":"https://api.github.com/repos/filiphr/mapstruct/statuses/{sha}","languages_url":"https://api.github.com/repos/filiphr/mapstruct/languages","stargazers_url":"https://api.github.com/repos/filiphr/mapstruct/stargazers","contributors_url":"https://api.github.com/repos/filiphr/mapstruct/contributors","subscribers_url":"https://api.github.com/repos/filiphr/mapstruct/subscribers","subscription_url":"https://api.github.com/repos/filiphr/mapstruct/subscription","commits_url":"https://api.github.com/repos/filiphr/mapstruct/commits{/sha}","git_commits_url":"https://api.github.com/repos/filiphr/mapstruct/git/commits{/sha}","comments_url":"https://api.github.com/repos/filiphr/mapstruct/comments{/number}","issue_comment_url":"https://api.github.com/repos/filiphr/mapstruct/issues/comments{/number}","contents_url":"https://api.github.com/repos/filiphr/mapstruct/contents/{+path}","compare_url":"https://api.github.com/repos/filiphr/mapstruct/compare/{base}...{head}","merges_url":"https://api.github.com/repos/filiphr/mapstruct/merges","archive_url":"https://api.github.com/repos/filiphr/mapstruct/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/filiphr/mapstruct/downloads","issues_url":"https://api.github.com/repos/filiphr/mapstruct/issues{/number}","pulls_url":"https://api.github.com/repos/filiphr/mapstruct/pulls{/number}","milestones_url":"https://api.github.com/repos/filiphr/mapstruct/milestones{/number}","notifications_url":"https://api.github.com/repos/filiphr/mapstruct/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/filiphr/mapstruct/labels{/name}","releases_url":"https://api.github.com/repos/filiphr/mapstruct/releases{/id}","deployments_url":"https://api.github.com/repos/filiphr/mapstruct/deployments","created_at":"2016-08-22T19:31:05Z","updated_at":"2016-08-22T19:31:12Z","pushed_at":"2016-11-23T19:02:53Z","git_url":"git://github.com/filiphr/mapstruct.git","ssh_url":"git@github.com:filiphr/mapstruct.git","clone_url":"https://github.com/filiphr/mapstruct.git","svn_url":"https://github.com/filiphr/mapstruct","homepage":"http://mapstruct.org/","size":4799,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapstruct:master","ref":"master","sha":"f3e489bc8c29beb68b49fb6a59dba90d841f70da","user":{"login":"mapstruct","id":4086779,"avatar_url":"https://avatars.githubusercontent.com/u/4086779?v=3","gravatar_id":"","url":"https://api.github.com/users/mapstruct","html_url":"https://github.com/mapstruct","followers_url":"https://api.github.com/users/mapstruct/followers","following_url":"https://api.github.com/users/mapstruct/following{/other_user}","gists_url":"https://api.github.com/users/mapstruct/gists{/gist_id}","starred_url":"https://api.github.com/users/mapstruct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapstruct/subscriptions","organizations_url":"https://api.github.com/users/mapstruct/orgs","repos_url":"https://api.github.com/users/mapstruct/repos","events_url":"https://api.github.com/users/mapstruct/events{/privacy}","received_events_url":"https://api.github.com/users/mapstruct/received_events","type":"Organization","site_admin":false},"repo":{"id":4470435,"name":"mapstruct","full_name":"mapstruct/mapstruct","owner":{"login":"mapstruct","id":4086779,"avatar_url":"https://avatars.githubusercontent.com/u/4086779?v=3","gravatar_id":"","url":"https://api.github.com/users/mapstruct","html_url":"https://github.com/mapstruct","followers_url":"https://api.github.com/users/mapstruct/followers","following_url":"https://api.github.com/users/mapstruct/following{/other_user}","gists_url":"https://api.github.com/users/mapstruct/gists{/gist_id}","starred_url":"https://api.github.com/users/mapstruct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapstruct/subscriptions","organizations_url":"https://api.github.com/users/mapstruct/orgs","repos_url":"https://api.github.com/users/mapstruct/repos","events_url":"https://api.github.com/users/mapstruct/events{/privacy}","received_events_url":"https://api.github.com/users/mapstruct/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapstruct/mapstruct","description":"An annotation processor for generating type-safe bean mappers","fork":false,"url":"https://api.github.com/repos/mapstruct/mapstruct","forks_url":"https://api.github.com/repos/mapstruct/mapstruct/forks","keys_url":"https://api.github.com/repos/mapstruct/mapstruct/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapstruct/mapstruct/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapstruct/mapstruct/teams","hooks_url":"https://api.github.com/repos/mapstruct/mapstruct/hooks","issue_events_url":"https://api.github.com/repos/mapstruct/mapstruct/issues/events{/number}","events_url":"https://api.github.com/repos/mapstruct/mapstruct/events","assignees_url":"https://api.github.com/repos/mapstruct/mapstruct/assignees{/user}","branches_url":"https://api.github.com/repos/mapstruct/mapstruct/branches{/branch}","tags_url":"https://api.github.com/repos/mapstruct/mapstruct/tags","blobs_url":"https://api.github.com/repos/mapstruct/mapstruct/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapstruct/mapstruct/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapstruct/mapstruct/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapstruct/mapstruct/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapstruct/mapstruct/statuses/{sha}","languages_url":"https://api.github.com/repos/mapstruct/mapstruct/languages","stargazers_url":"https://api.github.com/repos/mapstruct/mapstruct/stargazers","contributors_url":"https://api.github.com/repos/mapstruct/mapstruct/contributors","subscribers_url":"https://api.github.com/repos/mapstruct/mapstruct/subscribers","subscription_url":"https://api.github.com/repos/mapstruct/mapstruct/subscription","commits_url":"https://api.github.com/repos/mapstruct/mapstruct/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapstruct/mapstruct/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapstruct/mapstruct/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapstruct/mapstruct/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapstruct/mapstruct/contents/{+path}","compare_url":"https://api.github.com/repos/mapstruct/mapstruct/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapstruct/mapstruct/merges","archive_url":"https://api.github.com/repos/mapstruct/mapstruct/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapstruct/mapstruct/downloads","issues_url":"https://api.github.com/repos/mapstruct/mapstruct/issues{/number}","pulls_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls{/number}","milestones_url":"https://api.github.com/repos/mapstruct/mapstruct/milestones{/number}","notifications_url":"https://api.github.com/repos/mapstruct/mapstruct/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapstruct/mapstruct/labels{/name}","releases_url":"https://api.github.com/repos/mapstruct/mapstruct/releases{/id}","deployments_url":"https://api.github.com/repos/mapstruct/mapstruct/deployments","created_at":"2012-05-28T12:42:42Z","updated_at":"2016-11-24T09:20:12Z","pushed_at":"2016-11-23T19:02:53Z","git_url":"git://github.com/mapstruct/mapstruct.git","ssh_url":"git@github.com:mapstruct/mapstruct.git","clone_url":"https://github.com/mapstruct/mapstruct.git","svn_url":"https://github.com/mapstruct/mapstruct","homepage":"http://mapstruct.org/","size":6332,"stargazers_count":517,"watchers_count":517,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":123,"mirror_url":null,"open_issues_count":161,"forks":123,"open_issues":161,"watchers":517,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/964"},"html":{"href":"https://github.com/mapstruct/mapstruct/pull/964"},"issue":{"href":"https://api.github.com/repos/mapstruct/mapstruct/issues/964"},"comments":{"href":"https://api.github.com/repos/mapstruct/mapstruct/issues/964/comments"},"review_comments":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/964/comments"},"review_comment":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/964/commits"},"statuses":{"href":"https://api.github.com/repos/mapstruct/mapstruct/statuses/2cf4e5fe14a6d83b60d96a3134bf22daa2346bc0"}}}}
{"actor":{"display_login":"filiphr"}}