{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments/62184450","id":62184450,"diff_hunk":"@@ -814,6 +814,40 @@ - (void)setUsesImplicitHierarchyManagement:(BOOL)value\n   _usesImplicitHierarchyManagement = value;\n }\n \n+- (BOOL)_hasTransitionInProgress\n+{\n+    ASDN::MutexLocker l(_propertyLock);\n+    return _transitionInProgress;\n+}\n+\n+/// Starts a new transition and returns the transition id\n+- (int32_t)_startNewTransition\n+{\n+  ASDN::MutexLocker l(_propertyLock);\n+  _transitionInProgress = YES;\n+    \n+  if (!_transitionSentinel) {\n+    _transitionSentinel = [[ASSentinel alloc] init];\n+  }","path":"AsyncDisplayKit/ASDisplayNode.mm","position":87,"original_position":87,"commit_id":"7571b89d86a0ed67425020791dd0f5a5b97a2bd4","original_commit_id":"7571b89d86a0ed67425020791dd0f5a5b97a2bd4","user":{"login":"maicki","id":25288,"avatar_url":"https://avatars.githubusercontent.com/u/25288?v=3","gravatar_id":"","url":"https://api.github.com/users/maicki","html_url":"https://github.com/maicki","followers_url":"https://api.github.com/users/maicki/followers","following_url":"https://api.github.com/users/maicki/following{/other_user}","gists_url":"https://api.github.com/users/maicki/gists{/gist_id}","starred_url":"https://api.github.com/users/maicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maicki/subscriptions","organizations_url":"https://api.github.com/users/maicki/orgs","repos_url":"https://api.github.com/users/maicki/repos","events_url":"https://api.github.com/users/maicki/events{/privacy}","received_events_url":"https://api.github.com/users/maicki/received_events","type":"User","site_admin":false},"body":"@nguyenhuy @appleguy What do you guys think of using an instance variable that we atomically increase for that instead of the sentinel object (who does basically the same but has the overhead of creating and destroying an object ?","created_at":"2016-05-05T13:14:24Z","updated_at":"2016-05-05T13:14:24Z","html_url":"https://github.com/facebook/AsyncDisplayKit/pull/1622#discussion_r62184450","pull_request_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1622","_links":{"self":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments/62184450"},"html":{"href":"https://github.com/facebook/AsyncDisplayKit/pull/1622#discussion_r62184450"},"pull_request":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1622"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1622","id":68913490,"html_url":"https://github.com/facebook/AsyncDisplayKit/pull/1622","diff_url":"https://github.com/facebook/AsyncDisplayKit/pull/1622.diff","patch_url":"https://github.com/facebook/AsyncDisplayKit/pull/1622.patch","issue_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1622","number":1622,"state":"open","locked":false,"title":"[ASDisplayNode] Improve Transition ID handling","user":{"login":"maicki","id":25288,"avatar_url":"https://avatars.githubusercontent.com/u/25288?v=3","gravatar_id":"","url":"https://api.github.com/users/maicki","html_url":"https://github.com/maicki","followers_url":"https://api.github.com/users/maicki/followers","following_url":"https://api.github.com/users/maicki/following{/other_user}","gists_url":"https://api.github.com/users/maicki/gists{/gist_id}","starred_url":"https://api.github.com/users/maicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maicki/subscriptions","organizations_url":"https://api.github.com/users/maicki/orgs","repos_url":"https://api.github.com/users/maicki/repos","events_url":"https://api.github.com/users/maicki/events{/privacy}","received_events_url":"https://api.github.com/users/maicki/received_events","type":"User","site_admin":false},"body":"Currently in a race condition situation it can happen that subnodes get transition ids from supernodes where the supernodes transition id was reset but the subnode still has the old transition id value. This will trigger an exception although the assignment of the transition id is totally valid. This PR should address this by not reseting the transition id at all for a node and increase the transition id for new transitions.\r\n\r\ncc @nguyenhuy @appleguy @levi","created_at":"2016-05-04T18:57:22Z","updated_at":"2016-05-05T13:14:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54614b224c7edb2dd410fa09e0bc56a0381ab32a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1622/commits","review_comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1622/comments","review_comment_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1622/comments","statuses_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/statuses/7571b89d86a0ed67425020791dd0f5a5b97a2bd4","head":{"label":"maicki:ImproveTransitionIDHandling","ref":"ImproveTransitionIDHandling","sha":"7571b89d86a0ed67425020791dd0f5a5b97a2bd4","user":{"login":"maicki","id":25288,"avatar_url":"https://avatars.githubusercontent.com/u/25288?v=3","gravatar_id":"","url":"https://api.github.com/users/maicki","html_url":"https://github.com/maicki","followers_url":"https://api.github.com/users/maicki/followers","following_url":"https://api.github.com/users/maicki/following{/other_user}","gists_url":"https://api.github.com/users/maicki/gists{/gist_id}","starred_url":"https://api.github.com/users/maicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maicki/subscriptions","organizations_url":"https://api.github.com/users/maicki/orgs","repos_url":"https://api.github.com/users/maicki/repos","events_url":"https://api.github.com/users/maicki/events{/privacy}","received_events_url":"https://api.github.com/users/maicki/received_events","type":"User","site_admin":false},"repo":{"id":50892794,"name":"AsyncDisplayKit","full_name":"maicki/AsyncDisplayKit","owner":{"login":"maicki","id":25288,"avatar_url":"https://avatars.githubusercontent.com/u/25288?v=3","gravatar_id":"","url":"https://api.github.com/users/maicki","html_url":"https://github.com/maicki","followers_url":"https://api.github.com/users/maicki/followers","following_url":"https://api.github.com/users/maicki/following{/other_user}","gists_url":"https://api.github.com/users/maicki/gists{/gist_id}","starred_url":"https://api.github.com/users/maicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maicki/subscriptions","organizations_url":"https://api.github.com/users/maicki/orgs","repos_url":"https://api.github.com/users/maicki/repos","events_url":"https://api.github.com/users/maicki/events{/privacy}","received_events_url":"https://api.github.com/users/maicki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maicki/AsyncDisplayKit","description":"Smooth asynchronous user interfaces for iOS apps.","fork":true,"url":"https://api.github.com/repos/maicki/AsyncDisplayKit","forks_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/forks","keys_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/teams","hooks_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/hooks","issue_events_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/issues/events{/number}","events_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/events","assignees_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/assignees{/user}","branches_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/branches{/branch}","tags_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/tags","blobs_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/statuses/{sha}","languages_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/languages","stargazers_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/stargazers","contributors_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/contributors","subscribers_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/subscribers","subscription_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/subscription","commits_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/contents/{+path}","compare_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/merges","archive_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/downloads","issues_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/issues{/number}","pulls_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/pulls{/number}","milestones_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/milestones{/number}","notifications_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/labels{/name}","releases_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/releases{/id}","deployments_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/deployments","created_at":"2016-02-02T03:59:55Z","updated_at":"2016-04-23T02:52:21Z","pushed_at":"2016-05-05T04:04:00Z","git_url":"git://github.com/maicki/AsyncDisplayKit.git","ssh_url":"git@github.com:maicki/AsyncDisplayKit.git","clone_url":"https://github.com/maicki/AsyncDisplayKit.git","svn_url":"https://github.com/maicki/AsyncDisplayKit","homepage":"http://asyncdisplaykit.org","size":45602,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"3ee6c88ae42ba9c28db0d24131c4f948759084d2","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":21265042,"name":"AsyncDisplayKit","full_name":"facebook/AsyncDisplayKit","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/AsyncDisplayKit","description":"Smooth asynchronous user interfaces for iOS apps.","fork":false,"url":"https://api.github.com/repos/facebook/AsyncDisplayKit","forks_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/forks","keys_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/teams","hooks_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/hooks","issue_events_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/events","assignees_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/tags","blobs_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/languages","stargazers_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/stargazers","contributors_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/contributors","subscribers_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/subscribers","subscription_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/subscription","commits_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/merges","archive_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/downloads","issues_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/labels{/name}","releases_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/deployments","created_at":"2014-06-27T05:29:02Z","updated_at":"2016-05-05T10:51:08Z","pushed_at":"2016-05-05T04:04:01Z","git_url":"git://github.com/facebook/AsyncDisplayKit.git","ssh_url":"git@github.com:facebook/AsyncDisplayKit.git","clone_url":"https://github.com/facebook/AsyncDisplayKit.git","svn_url":"https://github.com/facebook/AsyncDisplayKit","homepage":"http://asyncdisplaykit.org","size":51706,"stargazers_count":8006,"watchers_count":8006,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1298,"mirror_url":null,"open_issues_count":156,"forks":1298,"open_issues":156,"watchers":8006,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1622"},"html":{"href":"https://github.com/facebook/AsyncDisplayKit/pull/1622"},"issue":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1622"},"comments":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1622/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1622/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1622/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/statuses/7571b89d86a0ed67425020791dd0f5a5b97a2bd4"}}}}