{"action":"created","comment":{"url":"https://api.github.com/repos/apache/camel/pulls/comments/80192166","id":80192166,"diff_hunk":"@@ -155,13 +155,22 @@ private Expression createSimpleExpression(String function, boolean strict) {\n         // date: prefix\n         remainder = ifStartsWithReturnRemainder(\"date:\", function);\n         if (remainder != null) {\n-            String[] parts = remainder.split(\":\");\n-            if (parts.length < 2) {\n-                throw new SimpleParserException(\"Valid syntax: ${date:command:pattern} was: \" + function, token.getIndex());\n+            String[] parts = remainder.split(\":\", 2);\n+            if (parts.length == 1) {\n+                return ExpressionBuilder.dateExpression(parts[0]);\n+            } else if (parts.length == 2) {\n+                return ExpressionBuilder.dateExpression(parts[0], parts[1]);\n+            }\n+        }\n+\n+        // date-with-timezone: prefix\n+        remainder = ifStartsWithReturnRemainder(\"date-with-timezone:\", function);\n+        if (remainder != null) {\n+            String[] parts = remainder.split(\":\", 3);\n+            if (parts.length < 3) {\n+                throw new SimpleParserException(\"Valid syntax: ${date:command:timezone:pattern} was: \" + function, token.getIndex());","path":"camel-core/src/main/java/org/apache/camel/language/simple/ast/SimpleFunctionExpression.java","position":20,"original_position":20,"commit_id":"b4f09dafc1c04fdf9515a20f462436a5ff284a4a","original_commit_id":"b4f09dafc1c04fdf9515a20f462436a5ff284a4a","user":{"login":"davsclaus","id":477100,"avatar_url":"https://avatars.githubusercontent.com/u/477100?v=3","gravatar_id":"","url":"https://api.github.com/users/davsclaus","html_url":"https://github.com/davsclaus","followers_url":"https://api.github.com/users/davsclaus/followers","following_url":"https://api.github.com/users/davsclaus/following{/other_user}","gists_url":"https://api.github.com/users/davsclaus/gists{/gist_id}","starred_url":"https://api.github.com/users/davsclaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davsclaus/subscriptions","organizations_url":"https://api.github.com/users/davsclaus/orgs","repos_url":"https://api.github.com/users/davsclaus/repos","events_url":"https://api.github.com/users/davsclaus/events{/privacy}","received_events_url":"https://api.github.com/users/davsclaus/received_events","type":"User","site_admin":false},"body":"That should be date-with-timezone","created_at":"2016-09-23T07:14:21Z","updated_at":"2016-09-23T07:14:21Z","html_url":"https://github.com/apache/camel/pull/1186#discussion_r80192166","pull_request_url":"https://api.github.com/repos/apache/camel/pulls/1186","_links":{"self":{"href":"https://api.github.com/repos/apache/camel/pulls/comments/80192166"},"html":{"href":"https://github.com/apache/camel/pull/1186#discussion_r80192166"},"pull_request":{"href":"https://api.github.com/repos/apache/camel/pulls/1186"}}},"pull_request":{"url":"https://api.github.com/repos/apache/camel/pulls/1186","id":86330844,"html_url":"https://github.com/apache/camel/pull/1186","diff_url":"https://github.com/apache/camel/pull/1186.diff","patch_url":"https://github.com/apache/camel/pull/1186.patch","issue_url":"https://api.github.com/repos/apache/camel/issues/1186","number":1186,"state":"open","locked":false,"title":"CAMEL-10339: Allow date offsets and timezones with Simple language","user":{"login":"yuruki","id":7396209,"avatar_url":"https://avatars.githubusercontent.com/u/7396209?v=3","gravatar_id":"","url":"https://api.github.com/users/yuruki","html_url":"https://github.com/yuruki","followers_url":"https://api.github.com/users/yuruki/followers","following_url":"https://api.github.com/users/yuruki/following{/other_user}","gists_url":"https://api.github.com/users/yuruki/gists{/gist_id}","starred_url":"https://api.github.com/users/yuruki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuruki/subscriptions","organizations_url":"https://api.github.com/users/yuruki/orgs","repos_url":"https://api.github.com/users/yuruki/repos","events_url":"https://api.github.com/users/yuruki/events{/privacy}","received_events_url":"https://api.github.com/users/yuruki/received_events","type":"User","site_admin":false},"body":"https://issues.apache.org/jira/browse/CAMEL-10339","created_at":"2016-09-22T12:49:53Z","updated_at":"2016-09-23T07:19:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8fca056ed806552c29036b1425a7768209c0a24b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/camel/pulls/1186/commits","review_comments_url":"https://api.github.com/repos/apache/camel/pulls/1186/comments","review_comment_url":"https://api.github.com/repos/apache/camel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/camel/issues/1186/comments","statuses_url":"https://api.github.com/repos/apache/camel/statuses/b4f09dafc1c04fdf9515a20f462436a5ff284a4a","head":{"label":"yuruki:camel-simpledate","ref":"camel-simpledate","sha":"b4f09dafc1c04fdf9515a20f462436a5ff284a4a","user":{"login":"yuruki","id":7396209,"avatar_url":"https://avatars.githubusercontent.com/u/7396209?v=3","gravatar_id":"","url":"https://api.github.com/users/yuruki","html_url":"https://github.com/yuruki","followers_url":"https://api.github.com/users/yuruki/followers","following_url":"https://api.github.com/users/yuruki/following{/other_user}","gists_url":"https://api.github.com/users/yuruki/gists{/gist_id}","starred_url":"https://api.github.com/users/yuruki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuruki/subscriptions","organizations_url":"https://api.github.com/users/yuruki/orgs","repos_url":"https://api.github.com/users/yuruki/repos","events_url":"https://api.github.com/users/yuruki/events{/privacy}","received_events_url":"https://api.github.com/users/yuruki/received_events","type":"User","site_admin":false},"repo":{"id":19112217,"name":"camel","full_name":"yuruki/camel","owner":{"login":"yuruki","id":7396209,"avatar_url":"https://avatars.githubusercontent.com/u/7396209?v=3","gravatar_id":"","url":"https://api.github.com/users/yuruki","html_url":"https://github.com/yuruki","followers_url":"https://api.github.com/users/yuruki/followers","following_url":"https://api.github.com/users/yuruki/following{/other_user}","gists_url":"https://api.github.com/users/yuruki/gists{/gist_id}","starred_url":"https://api.github.com/users/yuruki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuruki/subscriptions","organizations_url":"https://api.github.com/users/yuruki/orgs","repos_url":"https://api.github.com/users/yuruki/repos","events_url":"https://api.github.com/users/yuruki/events{/privacy}","received_events_url":"https://api.github.com/users/yuruki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yuruki/camel","description":"Mirror of Apache Camel","fork":true,"url":"https://api.github.com/repos/yuruki/camel","forks_url":"https://api.github.com/repos/yuruki/camel/forks","keys_url":"https://api.github.com/repos/yuruki/camel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuruki/camel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuruki/camel/teams","hooks_url":"https://api.github.com/repos/yuruki/camel/hooks","issue_events_url":"https://api.github.com/repos/yuruki/camel/issues/events{/number}","events_url":"https://api.github.com/repos/yuruki/camel/events","assignees_url":"https://api.github.com/repos/yuruki/camel/assignees{/user}","branches_url":"https://api.github.com/repos/yuruki/camel/branches{/branch}","tags_url":"https://api.github.com/repos/yuruki/camel/tags","blobs_url":"https://api.github.com/repos/yuruki/camel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuruki/camel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuruki/camel/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuruki/camel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuruki/camel/statuses/{sha}","languages_url":"https://api.github.com/repos/yuruki/camel/languages","stargazers_url":"https://api.github.com/repos/yuruki/camel/stargazers","contributors_url":"https://api.github.com/repos/yuruki/camel/contributors","subscribers_url":"https://api.github.com/repos/yuruki/camel/subscribers","subscription_url":"https://api.github.com/repos/yuruki/camel/subscription","commits_url":"https://api.github.com/repos/yuruki/camel/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuruki/camel/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuruki/camel/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuruki/camel/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuruki/camel/contents/{+path}","compare_url":"https://api.github.com/repos/yuruki/camel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuruki/camel/merges","archive_url":"https://api.github.com/repos/yuruki/camel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuruki/camel/downloads","issues_url":"https://api.github.com/repos/yuruki/camel/issues{/number}","pulls_url":"https://api.github.com/repos/yuruki/camel/pulls{/number}","milestones_url":"https://api.github.com/repos/yuruki/camel/milestones{/number}","notifications_url":"https://api.github.com/repos/yuruki/camel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuruki/camel/labels{/name}","releases_url":"https://api.github.com/repos/yuruki/camel/releases{/id}","deployments_url":"https://api.github.com/repos/yuruki/camel/deployments","created_at":"2014-04-24T14:48:55Z","updated_at":"2015-10-27T14:21:55Z","pushed_at":"2016-09-22T12:48:50Z","git_url":"git://github.com/yuruki/camel.git","ssh_url":"git@github.com:yuruki/camel.git","clone_url":"https://github.com/yuruki/camel.git","svn_url":"https://github.com/yuruki/camel","homepage":null,"size":130040,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"29a3d25f9faf875a4a983aa2f13e506fe0d821aa","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":206317,"name":"camel","full_name":"apache/camel","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/camel","description":"Mirror of Apache Camel","fork":false,"url":"https://api.github.com/repos/apache/camel","forks_url":"https://api.github.com/repos/apache/camel/forks","keys_url":"https://api.github.com/repos/apache/camel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/camel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/camel/teams","hooks_url":"https://api.github.com/repos/apache/camel/hooks","issue_events_url":"https://api.github.com/repos/apache/camel/issues/events{/number}","events_url":"https://api.github.com/repos/apache/camel/events","assignees_url":"https://api.github.com/repos/apache/camel/assignees{/user}","branches_url":"https://api.github.com/repos/apache/camel/branches{/branch}","tags_url":"https://api.github.com/repos/apache/camel/tags","blobs_url":"https://api.github.com/repos/apache/camel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/camel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/camel/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/camel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/camel/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/camel/languages","stargazers_url":"https://api.github.com/repos/apache/camel/stargazers","contributors_url":"https://api.github.com/repos/apache/camel/contributors","subscribers_url":"https://api.github.com/repos/apache/camel/subscribers","subscription_url":"https://api.github.com/repos/apache/camel/subscription","commits_url":"https://api.github.com/repos/apache/camel/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/camel/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/camel/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/camel/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/camel/contents/{+path}","compare_url":"https://api.github.com/repos/apache/camel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/camel/merges","archive_url":"https://api.github.com/repos/apache/camel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/camel/downloads","issues_url":"https://api.github.com/repos/apache/camel/issues{/number}","pulls_url":"https://api.github.com/repos/apache/camel/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/camel/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/camel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/camel/labels{/name}","releases_url":"https://api.github.com/repos/apache/camel/releases{/id}","deployments_url":"https://api.github.com/repos/apache/camel/deployments","created_at":"2009-05-21T00:25:36Z","updated_at":"2016-09-22T15:33:20Z","pushed_at":"2016-09-23T06:20:26Z","git_url":"git://github.com/apache/camel.git","ssh_url":"git@github.com:apache/camel.git","clone_url":"https://github.com/apache/camel.git","svn_url":"https://github.com/apache/camel","homepage":null,"size":156628,"stargazers_count":942,"watchers_count":942,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1402,"mirror_url":"git://git.apache.org/camel.git","open_issues_count":11,"forks":1402,"open_issues":11,"watchers":942,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/camel/pulls/1186"},"html":{"href":"https://github.com/apache/camel/pull/1186"},"issue":{"href":"https://api.github.com/repos/apache/camel/issues/1186"},"comments":{"href":"https://api.github.com/repos/apache/camel/issues/1186/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/camel/pulls/1186/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/camel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/camel/pulls/1186/commits"},"statuses":{"href":"https://api.github.com/repos/apache/camel/statuses/b4f09dafc1c04fdf9515a20f462436a5ff284a4a"}}}}
{"actor":{"display_login":"davsclaus"}}