{"action":"created","comment":{"url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/comments/63901271","id":63901271,"diff_hunk":"@@ -2641,12 +2666,12 @@ public static Boolean isMailValid( Context actualContext, Scriptable actualObjec\n           return Boolean.FALSE;\n         }\n \n-        retval = Boolean.TRUE;\n+        isValid = Boolean.TRUE;\n \n       } catch ( Exception e ) {\n         throw Context.reportRuntimeError( \"Error in isMailValid function: \" + e.getMessage() );\n       }\n-      return retval;\n+      return isValid;","path":"engine/src/org/pentaho/di/trans/steps/scriptvalues_mod/ScriptValuesAddedFunctions.java","position":252,"original_position":252,"commit_id":"173d4c776d60b01f0928890a33067dc1830abf9f","original_commit_id":"173d4c776d60b01f0928890a33067dc1830abf9f","user":{"login":"IvanNikolaychuk","id":13676748,"avatar_url":"https://avatars.githubusercontent.com/u/13676748?v=3","gravatar_id":"","url":"https://api.github.com/users/IvanNikolaychuk","html_url":"https://github.com/IvanNikolaychuk","followers_url":"https://api.github.com/users/IvanNikolaychuk/followers","following_url":"https://api.github.com/users/IvanNikolaychuk/following{/other_user}","gists_url":"https://api.github.com/users/IvanNikolaychuk/gists{/gist_id}","starred_url":"https://api.github.com/users/IvanNikolaychuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IvanNikolaychuk/subscriptions","organizations_url":"https://api.github.com/users/IvanNikolaychuk/orgs","repos_url":"https://api.github.com/users/IvanNikolaychuk/repos","events_url":"https://api.github.com/users/IvanNikolaychuk/events{/privacy}","received_events_url":"https://api.github.com/users/IvanNikolaychuk/received_events","type":"User","site_admin":false},"body":"You are right, it can.\r\n\r\nBut It's just a place where I refactored a variable name to camel case style (with no intention to change logic)\r\nActually there are bunch of such drawbacks in this class (it's ~ 3 k. lines length), so I decided just to make sure that my code is safe, and refactored a few things that strike the eyes without changing any logic.\r\n\r\nSo, I highly recomend to refactore this class and to make it more safe, but I would rather do this in context of the hole class, but not just in this method. But I need time and aggrement for this :)","created_at":"2016-05-19T15:34:43Z","updated_at":"2016-05-19T15:34:43Z","html_url":"https://github.com/pentaho/pentaho-kettle/pull/2524#discussion_r63901271","pull_request_url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/2524","_links":{"self":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/comments/63901271"},"html":{"href":"https://github.com/pentaho/pentaho-kettle/pull/2524#discussion_r63901271"},"pull_request":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/2524"}}},"pull_request":{"url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/2524","id":70527547,"html_url":"https://github.com/pentaho/pentaho-kettle/pull/2524","diff_url":"https://github.com/pentaho/pentaho-kettle/pull/2524.diff","patch_url":"https://github.com/pentaho/pentaho-kettle/pull/2524.patch","issue_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/2524","number":2524,"state":"open","locked":false,"title":"[PDI-14852] setVariable in Javascript Step with scope of parent job does not work","user":{"login":"IvanNikolaychuk","id":13676748,"avatar_url":"https://avatars.githubusercontent.com/u/13676748?v=3","gravatar_id":"","url":"https://api.github.com/users/IvanNikolaychuk","html_url":"https://github.com/IvanNikolaychuk","followers_url":"https://api.github.com/users/IvanNikolaychuk/followers","following_url":"https://api.github.com/users/IvanNikolaychuk/following{/other_user}","gists_url":"https://api.github.com/users/IvanNikolaychuk/gists{/gist_id}","starred_url":"https://api.github.com/users/IvanNikolaychuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IvanNikolaychuk/subscriptions","organizations_url":"https://api.github.com/users/IvanNikolaychuk/orgs","repos_url":"https://api.github.com/users/IvanNikolaychuk/repos","events_url":"https://api.github.com/users/IvanNikolaychuk/events{/privacy}","received_events_url":"https://api.github.com/users/IvanNikolaychuk/received_events","type":"User","site_admin":false},"body":"- Refactoring (changing variable names, representing variable scopes as enums, separating logic of setting variable on different scope-levels in different methods)\r\n- Starting to climb variable-space hierarchy from the step's transformation (not from the step itself, as the first call to step's parent will lead to the transformation itself, which is not the expected behavior)","created_at":"2016-05-18T13:29:27Z","updated_at":"2016-05-19T15:34:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d55a04e169211626cdd234512866f87344e24075","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/2524/commits","review_comments_url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/2524/comments","review_comment_url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/2524/comments","statuses_url":"https://api.github.com/repos/pentaho/pentaho-kettle/statuses/173d4c776d60b01f0928890a33067dc1830abf9f","head":{"label":"IvanNikolaychuk:PDI-14852","ref":"PDI-14852","sha":"173d4c776d60b01f0928890a33067dc1830abf9f","user":{"login":"IvanNikolaychuk","id":13676748,"avatar_url":"https://avatars.githubusercontent.com/u/13676748?v=3","gravatar_id":"","url":"https://api.github.com/users/IvanNikolaychuk","html_url":"https://github.com/IvanNikolaychuk","followers_url":"https://api.github.com/users/IvanNikolaychuk/followers","following_url":"https://api.github.com/users/IvanNikolaychuk/following{/other_user}","gists_url":"https://api.github.com/users/IvanNikolaychuk/gists{/gist_id}","starred_url":"https://api.github.com/users/IvanNikolaychuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IvanNikolaychuk/subscriptions","organizations_url":"https://api.github.com/users/IvanNikolaychuk/orgs","repos_url":"https://api.github.com/users/IvanNikolaychuk/repos","events_url":"https://api.github.com/users/IvanNikolaychuk/events{/privacy}","received_events_url":"https://api.github.com/users/IvanNikolaychuk/received_events","type":"User","site_admin":false},"repo":{"id":43285015,"name":"pentaho-kettle","full_name":"IvanNikolaychuk/pentaho-kettle","owner":{"login":"IvanNikolaychuk","id":13676748,"avatar_url":"https://avatars.githubusercontent.com/u/13676748?v=3","gravatar_id":"","url":"https://api.github.com/users/IvanNikolaychuk","html_url":"https://github.com/IvanNikolaychuk","followers_url":"https://api.github.com/users/IvanNikolaychuk/followers","following_url":"https://api.github.com/users/IvanNikolaychuk/following{/other_user}","gists_url":"https://api.github.com/users/IvanNikolaychuk/gists{/gist_id}","starred_url":"https://api.github.com/users/IvanNikolaychuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IvanNikolaychuk/subscriptions","organizations_url":"https://api.github.com/users/IvanNikolaychuk/orgs","repos_url":"https://api.github.com/users/IvanNikolaychuk/repos","events_url":"https://api.github.com/users/IvanNikolaychuk/events{/privacy}","received_events_url":"https://api.github.com/users/IvanNikolaychuk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/IvanNikolaychuk/pentaho-kettle","description":"Pentaho Data Integration ( ETL ) a.k.a Kettle","fork":true,"url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle","forks_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/forks","keys_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/teams","hooks_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/hooks","issue_events_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/issues/events{/number}","events_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/events","assignees_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/assignees{/user}","branches_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/branches{/branch}","tags_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/tags","blobs_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/git/refs{/sha}","trees_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/statuses/{sha}","languages_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/languages","stargazers_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/stargazers","contributors_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/contributors","subscribers_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/subscribers","subscription_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/subscription","commits_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/commits{/sha}","git_commits_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/git/commits{/sha}","comments_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/comments{/number}","issue_comment_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/issues/comments{/number}","contents_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/contents/{+path}","compare_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/merges","archive_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/downloads","issues_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/issues{/number}","pulls_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/pulls{/number}","milestones_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/milestones{/number}","notifications_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/labels{/name}","releases_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/releases{/id}","deployments_url":"https://api.github.com/repos/IvanNikolaychuk/pentaho-kettle/deployments","created_at":"2015-09-28T06:57:59Z","updated_at":"2016-04-27T10:48:49Z","pushed_at":"2016-05-18T09:50:59Z","git_url":"git://github.com/IvanNikolaychuk/pentaho-kettle.git","ssh_url":"git@github.com:IvanNikolaychuk/pentaho-kettle.git","clone_url":"https://github.com/IvanNikolaychuk/pentaho-kettle.git","svn_url":"https://github.com/IvanNikolaychuk/pentaho-kettle","homepage":null,"size":499403,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pentaho:master","ref":"master","sha":"56b83b81577e1b81e1001f73d15cdb670b962e20","user":{"login":"pentaho","id":1022787,"avatar_url":"https://avatars.githubusercontent.com/u/1022787?v=3","gravatar_id":"","url":"https://api.github.com/users/pentaho","html_url":"https://github.com/pentaho","followers_url":"https://api.github.com/users/pentaho/followers","following_url":"https://api.github.com/users/pentaho/following{/other_user}","gists_url":"https://api.github.com/users/pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaho/subscriptions","organizations_url":"https://api.github.com/users/pentaho/orgs","repos_url":"https://api.github.com/users/pentaho/repos","events_url":"https://api.github.com/users/pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/pentaho/received_events","type":"Organization","site_admin":false},"repo":{"id":13421878,"name":"pentaho-kettle","full_name":"pentaho/pentaho-kettle","owner":{"login":"pentaho","id":1022787,"avatar_url":"https://avatars.githubusercontent.com/u/1022787?v=3","gravatar_id":"","url":"https://api.github.com/users/pentaho","html_url":"https://github.com/pentaho","followers_url":"https://api.github.com/users/pentaho/followers","following_url":"https://api.github.com/users/pentaho/following{/other_user}","gists_url":"https://api.github.com/users/pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaho/subscriptions","organizations_url":"https://api.github.com/users/pentaho/orgs","repos_url":"https://api.github.com/users/pentaho/repos","events_url":"https://api.github.com/users/pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/pentaho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pentaho/pentaho-kettle","description":"Pentaho Data Integration ( ETL ) a.k.a Kettle","fork":false,"url":"https://api.github.com/repos/pentaho/pentaho-kettle","forks_url":"https://api.github.com/repos/pentaho/pentaho-kettle/forks","keys_url":"https://api.github.com/repos/pentaho/pentaho-kettle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pentaho/pentaho-kettle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pentaho/pentaho-kettle/teams","hooks_url":"https://api.github.com/repos/pentaho/pentaho-kettle/hooks","issue_events_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/events{/number}","events_url":"https://api.github.com/repos/pentaho/pentaho-kettle/events","assignees_url":"https://api.github.com/repos/pentaho/pentaho-kettle/assignees{/user}","branches_url":"https://api.github.com/repos/pentaho/pentaho-kettle/branches{/branch}","tags_url":"https://api.github.com/repos/pentaho/pentaho-kettle/tags","blobs_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/refs{/sha}","trees_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pentaho/pentaho-kettle/statuses/{sha}","languages_url":"https://api.github.com/repos/pentaho/pentaho-kettle/languages","stargazers_url":"https://api.github.com/repos/pentaho/pentaho-kettle/stargazers","contributors_url":"https://api.github.com/repos/pentaho/pentaho-kettle/contributors","subscribers_url":"https://api.github.com/repos/pentaho/pentaho-kettle/subscribers","subscription_url":"https://api.github.com/repos/pentaho/pentaho-kettle/subscription","commits_url":"https://api.github.com/repos/pentaho/pentaho-kettle/commits{/sha}","git_commits_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/commits{/sha}","comments_url":"https://api.github.com/repos/pentaho/pentaho-kettle/comments{/number}","issue_comment_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/comments{/number}","contents_url":"https://api.github.com/repos/pentaho/pentaho-kettle/contents/{+path}","compare_url":"https://api.github.com/repos/pentaho/pentaho-kettle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pentaho/pentaho-kettle/merges","archive_url":"https://api.github.com/repos/pentaho/pentaho-kettle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pentaho/pentaho-kettle/downloads","issues_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues{/number}","pulls_url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls{/number}","milestones_url":"https://api.github.com/repos/pentaho/pentaho-kettle/milestones{/number}","notifications_url":"https://api.github.com/repos/pentaho/pentaho-kettle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pentaho/pentaho-kettle/labels{/name}","releases_url":"https://api.github.com/repos/pentaho/pentaho-kettle/releases{/id}","deployments_url":"https://api.github.com/repos/pentaho/pentaho-kettle/deployments","created_at":"2013-10-08T18:27:11Z","updated_at":"2016-05-19T08:40:52Z","pushed_at":"2016-05-19T15:26:47Z","git_url":"git://github.com/pentaho/pentaho-kettle.git","ssh_url":"git@github.com:pentaho/pentaho-kettle.git","clone_url":"https://github.com/pentaho/pentaho-kettle.git","svn_url":"https://github.com/pentaho/pentaho-kettle","homepage":null,"size":517910,"stargazers_count":575,"watchers_count":575,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":638,"mirror_url":null,"open_issues_count":48,"forks":638,"open_issues":48,"watchers":575,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/2524"},"html":{"href":"https://github.com/pentaho/pentaho-kettle/pull/2524"},"issue":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/2524"},"comments":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/2524/comments"},"review_comments":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/2524/comments"},"review_comment":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/2524/commits"},"statuses":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/statuses/173d4c776d60b01f0928890a33067dc1830abf9f"}}}}