{"action":"created","comment":{"url":"https://api.github.com/repos/solettaproject/soletta/pulls/comments/65096083","id":65096083,"diff_hunk":"@@ -1780,13 +1784,25 @@ sol_lwm2m_resource_init(struct sol_lwm2m_resource *resource,\n                 (uint16_t)va_arg(ap, int);\n             break;\n         default:\n-            r = -EINVAL;\n+            SOL_WRN(\"Unknown resource data type\");\n+            goto err_exit;\n         }\n     }\n \n-    if (r < 0)\n-        free(resource->data);\n+    va_end(ap);\n+    return 0;\n \n+err_ref:\n+    r = -EOVERFLOW;\n+err_exit:\n+    if (data_type == SOL_LWM2M_RESOURCE_DATA_TYPE_OPAQUE ||\n+        data_type == SOL_LWM2M_RESOURCE_DATA_TYPE_OPAQUE) {","path":"src/lib/comms/sol-lwm2m.c","position":59,"original_position":59,"commit_id":"4f7f01f75c9ca60852d1c0936d6755b4394febbc","original_commit_id":"4f7f01f75c9ca60852d1c0936d6755b4394febbc","user":{"login":"otaviobp","id":36560,"avatar_url":"https://avatars.githubusercontent.com/u/36560?v=3","gravatar_id":"","url":"https://api.github.com/users/otaviobp","html_url":"https://github.com/otaviobp","followers_url":"https://api.github.com/users/otaviobp/followers","following_url":"https://api.github.com/users/otaviobp/following{/other_user}","gists_url":"https://api.github.com/users/otaviobp/gists{/gist_id}","starred_url":"https://api.github.com/users/otaviobp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otaviobp/subscriptions","organizations_url":"https://api.github.com/users/otaviobp/orgs","repos_url":"https://api.github.com/users/otaviobp/repos","events_url":"https://api.github.com/users/otaviobp/events{/privacy}","received_events_url":"https://api.github.com/users/otaviobp/received_events","type":"User","site_admin":false},"body":"Or is comparing equal const values","created_at":"2016-05-30T17:48:53Z","updated_at":"2016-05-30T17:48:53Z","html_url":"https://github.com/solettaproject/soletta/pull/2105#discussion_r65096083","pull_request_url":"https://api.github.com/repos/solettaproject/soletta/pulls/2105","_links":{"self":{"href":"https://api.github.com/repos/solettaproject/soletta/pulls/comments/65096083"},"html":{"href":"https://github.com/solettaproject/soletta/pull/2105#discussion_r65096083"},"pull_request":{"href":"https://api.github.com/repos/solettaproject/soletta/pulls/2105"}}},"pull_request":{"url":"https://api.github.com/repos/solettaproject/soletta/pulls/2105","id":71768776,"html_url":"https://github.com/solettaproject/soletta/pull/2105","diff_url":"https://github.com/solettaproject/soletta/pull/2105.diff","patch_url":"https://github.com/solettaproject/soletta/pull/2105.patch","issue_url":"https://api.github.com/repos/solettaproject/soletta/issues/2105","number":2105,"state":"open","locked":false,"title":"LWM2M: Use struct sol_blob for string and opaque resource types.","user":{"login":"cabelitos","id":984610,"avatar_url":"https://avatars.githubusercontent.com/u/984610?v=3","gravatar_id":"","url":"https://api.github.com/users/cabelitos","html_url":"https://github.com/cabelitos","followers_url":"https://api.github.com/users/cabelitos/followers","following_url":"https://api.github.com/users/cabelitos/following{/other_user}","gists_url":"https://api.github.com/users/cabelitos/gists{/gist_id}","starred_url":"https://api.github.com/users/cabelitos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cabelitos/subscriptions","organizations_url":"https://api.github.com/users/cabelitos/orgs","repos_url":"https://api.github.com/users/cabelitos/repos","events_url":"https://api.github.com/users/cabelitos/events{/privacy}","received_events_url":"https://api.github.com/users/cabelitos/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Guilherme Iscaro <guilherme.iscaro@intel.com>","created_at":"2016-05-27T20:30:29Z","updated_at":"2016-05-30T17:48:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea9a87ce228bc197f376e67feffbdc55952f2f67","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/solettaproject/soletta/pulls/2105/commits","review_comments_url":"https://api.github.com/repos/solettaproject/soletta/pulls/2105/comments","review_comment_url":"https://api.github.com/repos/solettaproject/soletta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solettaproject/soletta/issues/2105/comments","statuses_url":"https://api.github.com/repos/solettaproject/soletta/statuses/4f7f01f75c9ca60852d1c0936d6755b4394febbc","head":{"label":"cabelitos:lwm","ref":"lwm","sha":"4f7f01f75c9ca60852d1c0936d6755b4394febbc","user":{"login":"cabelitos","id":984610,"avatar_url":"https://avatars.githubusercontent.com/u/984610?v=3","gravatar_id":"","url":"https://api.github.com/users/cabelitos","html_url":"https://github.com/cabelitos","followers_url":"https://api.github.com/users/cabelitos/followers","following_url":"https://api.github.com/users/cabelitos/following{/other_user}","gists_url":"https://api.github.com/users/cabelitos/gists{/gist_id}","starred_url":"https://api.github.com/users/cabelitos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cabelitos/subscriptions","organizations_url":"https://api.github.com/users/cabelitos/orgs","repos_url":"https://api.github.com/users/cabelitos/repos","events_url":"https://api.github.com/users/cabelitos/events{/privacy}","received_events_url":"https://api.github.com/users/cabelitos/received_events","type":"User","site_admin":false},"repo":{"id":37933311,"name":"soletta","full_name":"cabelitos/soletta","owner":{"login":"cabelitos","id":984610,"avatar_url":"https://avatars.githubusercontent.com/u/984610?v=3","gravatar_id":"","url":"https://api.github.com/users/cabelitos","html_url":"https://github.com/cabelitos","followers_url":"https://api.github.com/users/cabelitos/followers","following_url":"https://api.github.com/users/cabelitos/following{/other_user}","gists_url":"https://api.github.com/users/cabelitos/gists{/gist_id}","starred_url":"https://api.github.com/users/cabelitos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cabelitos/subscriptions","organizations_url":"https://api.github.com/users/cabelitos/orgs","repos_url":"https://api.github.com/users/cabelitos/repos","events_url":"https://api.github.com/users/cabelitos/events{/privacy}","received_events_url":"https://api.github.com/users/cabelitos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cabelitos/soletta","description":"Soletta Project is a framework for making IoT devices.  With Soletta Project's libraries developers can easily write software for devices that control actuators/sensors and communicate using standard technologies. It enables adding smartness even on the smallest edge devices.  ","fork":true,"url":"https://api.github.com/repos/cabelitos/soletta","forks_url":"https://api.github.com/repos/cabelitos/soletta/forks","keys_url":"https://api.github.com/repos/cabelitos/soletta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cabelitos/soletta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cabelitos/soletta/teams","hooks_url":"https://api.github.com/repos/cabelitos/soletta/hooks","issue_events_url":"https://api.github.com/repos/cabelitos/soletta/issues/events{/number}","events_url":"https://api.github.com/repos/cabelitos/soletta/events","assignees_url":"https://api.github.com/repos/cabelitos/soletta/assignees{/user}","branches_url":"https://api.github.com/repos/cabelitos/soletta/branches{/branch}","tags_url":"https://api.github.com/repos/cabelitos/soletta/tags","blobs_url":"https://api.github.com/repos/cabelitos/soletta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cabelitos/soletta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cabelitos/soletta/git/refs{/sha}","trees_url":"https://api.github.com/repos/cabelitos/soletta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cabelitos/soletta/statuses/{sha}","languages_url":"https://api.github.com/repos/cabelitos/soletta/languages","stargazers_url":"https://api.github.com/repos/cabelitos/soletta/stargazers","contributors_url":"https://api.github.com/repos/cabelitos/soletta/contributors","subscribers_url":"https://api.github.com/repos/cabelitos/soletta/subscribers","subscription_url":"https://api.github.com/repos/cabelitos/soletta/subscription","commits_url":"https://api.github.com/repos/cabelitos/soletta/commits{/sha}","git_commits_url":"https://api.github.com/repos/cabelitos/soletta/git/commits{/sha}","comments_url":"https://api.github.com/repos/cabelitos/soletta/comments{/number}","issue_comment_url":"https://api.github.com/repos/cabelitos/soletta/issues/comments{/number}","contents_url":"https://api.github.com/repos/cabelitos/soletta/contents/{+path}","compare_url":"https://api.github.com/repos/cabelitos/soletta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cabelitos/soletta/merges","archive_url":"https://api.github.com/repos/cabelitos/soletta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cabelitos/soletta/downloads","issues_url":"https://api.github.com/repos/cabelitos/soletta/issues{/number}","pulls_url":"https://api.github.com/repos/cabelitos/soletta/pulls{/number}","milestones_url":"https://api.github.com/repos/cabelitos/soletta/milestones{/number}","notifications_url":"https://api.github.com/repos/cabelitos/soletta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cabelitos/soletta/labels{/name}","releases_url":"https://api.github.com/repos/cabelitos/soletta/releases{/id}","deployments_url":"https://api.github.com/repos/cabelitos/soletta/deployments","created_at":"2015-06-23T17:19:15Z","updated_at":"2016-02-02T19:26:17Z","pushed_at":"2016-05-27T20:30:16Z","git_url":"git://github.com/cabelitos/soletta.git","ssh_url":"git@github.com:cabelitos/soletta.git","clone_url":"https://github.com/cabelitos/soletta.git","svn_url":"https://github.com/cabelitos/soletta","homepage":"","size":20429,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solettaproject:master","ref":"master","sha":"d8ba70bd9698834f4b63793b7725b2a58897a803","user":{"login":"solettaproject","id":12736897,"avatar_url":"https://avatars.githubusercontent.com/u/12736897?v=3","gravatar_id":"","url":"https://api.github.com/users/solettaproject","html_url":"https://github.com/solettaproject","followers_url":"https://api.github.com/users/solettaproject/followers","following_url":"https://api.github.com/users/solettaproject/following{/other_user}","gists_url":"https://api.github.com/users/solettaproject/gists{/gist_id}","starred_url":"https://api.github.com/users/solettaproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solettaproject/subscriptions","organizations_url":"https://api.github.com/users/solettaproject/orgs","repos_url":"https://api.github.com/users/solettaproject/repos","events_url":"https://api.github.com/users/solettaproject/events{/privacy}","received_events_url":"https://api.github.com/users/solettaproject/received_events","type":"Organization","site_admin":false},"repo":{"id":37087063,"name":"soletta","full_name":"solettaproject/soletta","owner":{"login":"solettaproject","id":12736897,"avatar_url":"https://avatars.githubusercontent.com/u/12736897?v=3","gravatar_id":"","url":"https://api.github.com/users/solettaproject","html_url":"https://github.com/solettaproject","followers_url":"https://api.github.com/users/solettaproject/followers","following_url":"https://api.github.com/users/solettaproject/following{/other_user}","gists_url":"https://api.github.com/users/solettaproject/gists{/gist_id}","starred_url":"https://api.github.com/users/solettaproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solettaproject/subscriptions","organizations_url":"https://api.github.com/users/solettaproject/orgs","repos_url":"https://api.github.com/users/solettaproject/repos","events_url":"https://api.github.com/users/solettaproject/events{/privacy}","received_events_url":"https://api.github.com/users/solettaproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/solettaproject/soletta","description":"Soletta Project is a framework for making IoT devices.  With Soletta Project's libraries developers can easily write software for devices that control actuators/sensors and communicate using standard technologies. It enables adding smartness even on the smallest edge devices.  ","fork":false,"url":"https://api.github.com/repos/solettaproject/soletta","forks_url":"https://api.github.com/repos/solettaproject/soletta/forks","keys_url":"https://api.github.com/repos/solettaproject/soletta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solettaproject/soletta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solettaproject/soletta/teams","hooks_url":"https://api.github.com/repos/solettaproject/soletta/hooks","issue_events_url":"https://api.github.com/repos/solettaproject/soletta/issues/events{/number}","events_url":"https://api.github.com/repos/solettaproject/soletta/events","assignees_url":"https://api.github.com/repos/solettaproject/soletta/assignees{/user}","branches_url":"https://api.github.com/repos/solettaproject/soletta/branches{/branch}","tags_url":"https://api.github.com/repos/solettaproject/soletta/tags","blobs_url":"https://api.github.com/repos/solettaproject/soletta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solettaproject/soletta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solettaproject/soletta/git/refs{/sha}","trees_url":"https://api.github.com/repos/solettaproject/soletta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solettaproject/soletta/statuses/{sha}","languages_url":"https://api.github.com/repos/solettaproject/soletta/languages","stargazers_url":"https://api.github.com/repos/solettaproject/soletta/stargazers","contributors_url":"https://api.github.com/repos/solettaproject/soletta/contributors","subscribers_url":"https://api.github.com/repos/solettaproject/soletta/subscribers","subscription_url":"https://api.github.com/repos/solettaproject/soletta/subscription","commits_url":"https://api.github.com/repos/solettaproject/soletta/commits{/sha}","git_commits_url":"https://api.github.com/repos/solettaproject/soletta/git/commits{/sha}","comments_url":"https://api.github.com/repos/solettaproject/soletta/comments{/number}","issue_comment_url":"https://api.github.com/repos/solettaproject/soletta/issues/comments{/number}","contents_url":"https://api.github.com/repos/solettaproject/soletta/contents/{+path}","compare_url":"https://api.github.com/repos/solettaproject/soletta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solettaproject/soletta/merges","archive_url":"https://api.github.com/repos/solettaproject/soletta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solettaproject/soletta/downloads","issues_url":"https://api.github.com/repos/solettaproject/soletta/issues{/number}","pulls_url":"https://api.github.com/repos/solettaproject/soletta/pulls{/number}","milestones_url":"https://api.github.com/repos/solettaproject/soletta/milestones{/number}","notifications_url":"https://api.github.com/repos/solettaproject/soletta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solettaproject/soletta/labels{/name}","releases_url":"https://api.github.com/repos/solettaproject/soletta/releases{/id}","deployments_url":"https://api.github.com/repos/solettaproject/soletta/deployments","created_at":"2015-06-08T19:13:18Z","updated_at":"2016-05-29T11:42:20Z","pushed_at":"2016-05-30T14:39:48Z","git_url":"git://github.com/solettaproject/soletta.git","ssh_url":"git@github.com:solettaproject/soletta.git","clone_url":"https://github.com/solettaproject/soletta.git","svn_url":"https://github.com/solettaproject/soletta","homepage":"http://solettaproject.org","size":28727,"stargazers_count":98,"watchers_count":98,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":85,"mirror_url":null,"open_issues_count":169,"forks":85,"open_issues":169,"watchers":98,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solettaproject/soletta/pulls/2105"},"html":{"href":"https://github.com/solettaproject/soletta/pull/2105"},"issue":{"href":"https://api.github.com/repos/solettaproject/soletta/issues/2105"},"comments":{"href":"https://api.github.com/repos/solettaproject/soletta/issues/2105/comments"},"review_comments":{"href":"https://api.github.com/repos/solettaproject/soletta/pulls/2105/comments"},"review_comment":{"href":"https://api.github.com/repos/solettaproject/soletta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solettaproject/soletta/pulls/2105/commits"},"statuses":{"href":"https://api.github.com/repos/solettaproject/soletta/statuses/4f7f01f75c9ca60852d1c0936d6755b4394febbc"}}}}
{"actor":{"display_login":"otaviobp"}}