{"action":"closed","number":132,"pull_request":{"url":"https://api.github.com/repos/hyperoslo/ImagePicker/pulls/132","id":65368952,"html_url":"https://github.com/hyperoslo/ImagePicker/pull/132","diff_url":"https://github.com/hyperoslo/ImagePicker/pull/132.diff","patch_url":"https://github.com/hyperoslo/ImagePicker/pull/132.patch","issue_url":"https://api.github.com/repos/hyperoslo/ImagePicker/issues/132","number":132,"state":"closed","locked":false,"title":"Refactored ImageGalleryPanGestureDelegate","user":{"login":"aashishdhawan","id":1090001,"avatar_url":"https://avatars.githubusercontent.com/u/1090001?v=3","gravatar_id":"","url":"https://api.github.com/users/aashishdhawan","html_url":"https://github.com/aashishdhawan","followers_url":"https://api.github.com/users/aashishdhawan/followers","following_url":"https://api.github.com/users/aashishdhawan/following{/other_user}","gists_url":"https://api.github.com/users/aashishdhawan/gists{/gist_id}","starred_url":"https://api.github.com/users/aashishdhawan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aashishdhawan/subscriptions","organizations_url":"https://api.github.com/users/aashishdhawan/orgs","repos_url":"https://api.github.com/users/aashishdhawan/repos","events_url":"https://api.github.com/users/aashishdhawan/events{/privacy}","received_events_url":"https://api.github.com/users/aashishdhawan/received_events","type":"User","site_admin":false},"body":"Refactors code a little bit. The original implementation had 2 issues. \r\n\r\n1. `ImageGalleryPanGestureDelegate ` had following functions \r\n\r\n```\r\n- func presentViewController(controller: UIAlertController)\r\n-  func dismissViewController(controller: UIAlertController)\r\n-  func permissionGranted()\r\n-  func hideViews()\r\n```\r\n\r\nThese should not fall under `ImageGalleryPanGestureDelegate`.\r\n\r\n2.  It is not responsibility of `ImageGalleryView ` to call `PHPhotoLibrary.requestAuthorization`...violates `MVC` in my point of view.","created_at":"2016-04-05T20:27:19Z","updated_at":"2016-04-15T16:26:06Z","closed_at":"2016-04-15T16:26:06Z","merged_at":"2016-04-15T16:26:06Z","merge_commit_sha":"1f19b7850e69ce2e92109963ab8e87f360147140","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hyperoslo/ImagePicker/pulls/132/commits","review_comments_url":"https://api.github.com/repos/hyperoslo/ImagePicker/pulls/132/comments","review_comment_url":"https://api.github.com/repos/hyperoslo/ImagePicker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperoslo/ImagePicker/issues/132/comments","statuses_url":"https://api.github.com/repos/hyperoslo/ImagePicker/statuses/9254ee23f6a3f6860887b5785f791526ff7a1120","head":{"label":"hyperoslo:refactor/better","ref":"refactor/better","sha":"9254ee23f6a3f6860887b5785f791526ff7a1120","user":{"login":"hyperoslo","id":1340892,"avatar_url":"https://avatars.githubusercontent.com/u/1340892?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperoslo","html_url":"https://github.com/hyperoslo","followers_url":"https://api.github.com/users/hyperoslo/followers","following_url":"https://api.github.com/users/hyperoslo/following{/other_user}","gists_url":"https://api.github.com/users/hyperoslo/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperoslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperoslo/subscriptions","organizations_url":"https://api.github.com/users/hyperoslo/orgs","repos_url":"https://api.github.com/users/hyperoslo/repos","events_url":"https://api.github.com/users/hyperoslo/events{/privacy}","received_events_url":"https://api.github.com/users/hyperoslo/received_events","type":"Organization","site_admin":false},"repo":{"id":40171919,"name":"ImagePicker","full_name":"hyperoslo/ImagePicker","owner":{"login":"hyperoslo","id":1340892,"avatar_url":"https://avatars.githubusercontent.com/u/1340892?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperoslo","html_url":"https://github.com/hyperoslo","followers_url":"https://api.github.com/users/hyperoslo/followers","following_url":"https://api.github.com/users/hyperoslo/following{/other_user}","gists_url":"https://api.github.com/users/hyperoslo/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperoslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperoslo/subscriptions","organizations_url":"https://api.github.com/users/hyperoslo/orgs","repos_url":"https://api.github.com/users/hyperoslo/repos","events_url":"https://api.github.com/users/hyperoslo/events{/privacy}","received_events_url":"https://api.github.com/users/hyperoslo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperoslo/ImagePicker","description":"Reinventing the way ImagePicker works.","fork":false,"url":"https://api.github.com/repos/hyperoslo/ImagePicker","forks_url":"https://api.github.com/repos/hyperoslo/ImagePicker/forks","keys_url":"https://api.github.com/repos/hyperoslo/ImagePicker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperoslo/ImagePicker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperoslo/ImagePicker/teams","hooks_url":"https://api.github.com/repos/hyperoslo/ImagePicker/hooks","issue_events_url":"https://api.github.com/repos/hyperoslo/ImagePicker/issues/events{/number}","events_url":"https://api.github.com/repos/hyperoslo/ImagePicker/events","assignees_url":"https://api.github.com/repos/hyperoslo/ImagePicker/assignees{/user}","branches_url":"https://api.github.com/repos/hyperoslo/ImagePicker/branches{/branch}","tags_url":"https://api.github.com/repos/hyperoslo/ImagePicker/tags","blobs_url":"https://api.github.com/repos/hyperoslo/ImagePicker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperoslo/ImagePicker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperoslo/ImagePicker/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperoslo/ImagePicker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperoslo/ImagePicker/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperoslo/ImagePicker/languages","stargazers_url":"https://api.github.com/repos/hyperoslo/ImagePicker/stargazers","contributors_url":"https://api.github.com/repos/hyperoslo/ImagePicker/contributors","subscribers_url":"https://api.github.com/repos/hyperoslo/ImagePicker/subscribers","subscription_url":"https://api.github.com/repos/hyperoslo/ImagePicker/subscription","commits_url":"https://api.github.com/repos/hyperoslo/ImagePicker/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperoslo/ImagePicker/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperoslo/ImagePicker/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperoslo/ImagePicker/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperoslo/ImagePicker/contents/{+path}","compare_url":"https://api.github.com/repos/hyperoslo/ImagePicker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperoslo/ImagePicker/merges","archive_url":"https://api.github.com/repos/hyperoslo/ImagePicker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperoslo/ImagePicker/downloads","issues_url":"https://api.github.com/repos/hyperoslo/ImagePicker/issues{/number}","pulls_url":"https://api.github.com/repos/hyperoslo/ImagePicker/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperoslo/ImagePicker/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperoslo/ImagePicker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperoslo/ImagePicker/labels{/name}","releases_url":"https://api.github.com/repos/hyperoslo/ImagePicker/releases{/id}","deployments_url":"https://api.github.com/repos/hyperoslo/ImagePicker/deployments","created_at":"2015-08-04T08:13:33Z","updated_at":"2016-04-15T12:36:01Z","pushed_at":"2016-04-15T16:26:06Z","git_url":"git://github.com/hyperoslo/ImagePicker.git","ssh_url":"git@github.com:hyperoslo/ImagePicker.git","clone_url":"https://github.com/hyperoslo/ImagePicker.git","svn_url":"https://github.com/hyperoslo/ImagePicker","homepage":"","size":14224,"stargazers_count":1282,"watchers_count":1282,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":76,"mirror_url":null,"open_issues_count":19,"forks":76,"open_issues":19,"watchers":1282,"default_branch":"master"}},"base":{"label":"hyperoslo:master","ref":"master","sha":"80ab6cf58e2a21b17d952d8758fb6baa48662d2c","user":{"login":"hyperoslo","id":1340892,"avatar_url":"https://avatars.githubusercontent.com/u/1340892?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperoslo","html_url":"https://github.com/hyperoslo","followers_url":"https://api.github.com/users/hyperoslo/followers","following_url":"https://api.github.com/users/hyperoslo/following{/other_user}","gists_url":"https://api.github.com/users/hyperoslo/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperoslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperoslo/subscriptions","organizations_url":"https://api.github.com/users/hyperoslo/orgs","repos_url":"https://api.github.com/users/hyperoslo/repos","events_url":"https://api.github.com/users/hyperoslo/events{/privacy}","received_events_url":"https://api.github.com/users/hyperoslo/received_events","type":"Organization","site_admin":false},"repo":{"id":40171919,"name":"ImagePicker","full_name":"hyperoslo/ImagePicker","owner":{"login":"hyperoslo","id":1340892,"avatar_url":"https://avatars.githubusercontent.com/u/1340892?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperoslo","html_url":"https://github.com/hyperoslo","followers_url":"https://api.github.com/users/hyperoslo/followers","following_url":"https://api.github.com/users/hyperoslo/following{/other_user}","gists_url":"https://api.github.com/users/hyperoslo/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperoslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperoslo/subscriptions","organizations_url":"https://api.github.com/users/hyperoslo/orgs","repos_url":"https://api.github.com/users/hyperoslo/repos","events_url":"https://api.github.com/users/hyperoslo/events{/privacy}","received_events_url":"https://api.github.com/users/hyperoslo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperoslo/ImagePicker","description":"Reinventing the way ImagePicker works.","fork":false,"url":"https://api.github.com/repos/hyperoslo/ImagePicker","forks_url":"https://api.github.com/repos/hyperoslo/ImagePicker/forks","keys_url":"https://api.github.com/repos/hyperoslo/ImagePicker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperoslo/ImagePicker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperoslo/ImagePicker/teams","hooks_url":"https://api.github.com/repos/hyperoslo/ImagePicker/hooks","issue_events_url":"https://api.github.com/repos/hyperoslo/ImagePicker/issues/events{/number}","events_url":"https://api.github.com/repos/hyperoslo/ImagePicker/events","assignees_url":"https://api.github.com/repos/hyperoslo/ImagePicker/assignees{/user}","branches_url":"https://api.github.com/repos/hyperoslo/ImagePicker/branches{/branch}","tags_url":"https://api.github.com/repos/hyperoslo/ImagePicker/tags","blobs_url":"https://api.github.com/repos/hyperoslo/ImagePicker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperoslo/ImagePicker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperoslo/ImagePicker/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperoslo/ImagePicker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperoslo/ImagePicker/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperoslo/ImagePicker/languages","stargazers_url":"https://api.github.com/repos/hyperoslo/ImagePicker/stargazers","contributors_url":"https://api.github.com/repos/hyperoslo/ImagePicker/contributors","subscribers_url":"https://api.github.com/repos/hyperoslo/ImagePicker/subscribers","subscription_url":"https://api.github.com/repos/hyperoslo/ImagePicker/subscription","commits_url":"https://api.github.com/repos/hyperoslo/ImagePicker/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperoslo/ImagePicker/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperoslo/ImagePicker/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperoslo/ImagePicker/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperoslo/ImagePicker/contents/{+path}","compare_url":"https://api.github.com/repos/hyperoslo/ImagePicker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperoslo/ImagePicker/merges","archive_url":"https://api.github.com/repos/hyperoslo/ImagePicker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperoslo/ImagePicker/downloads","issues_url":"https://api.github.com/repos/hyperoslo/ImagePicker/issues{/number}","pulls_url":"https://api.github.com/repos/hyperoslo/ImagePicker/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperoslo/ImagePicker/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperoslo/ImagePicker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperoslo/ImagePicker/labels{/name}","releases_url":"https://api.github.com/repos/hyperoslo/ImagePicker/releases{/id}","deployments_url":"https://api.github.com/repos/hyperoslo/ImagePicker/deployments","created_at":"2015-08-04T08:13:33Z","updated_at":"2016-04-15T12:36:01Z","pushed_at":"2016-04-15T16:26:06Z","git_url":"git://github.com/hyperoslo/ImagePicker.git","ssh_url":"git@github.com:hyperoslo/ImagePicker.git","clone_url":"https://github.com/hyperoslo/ImagePicker.git","svn_url":"https://github.com/hyperoslo/ImagePicker","homepage":"","size":14224,"stargazers_count":1282,"watchers_count":1282,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":76,"mirror_url":null,"open_issues_count":19,"forks":76,"open_issues":19,"watchers":1282,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperoslo/ImagePicker/pulls/132"},"html":{"href":"https://github.com/hyperoslo/ImagePicker/pull/132"},"issue":{"href":"https://api.github.com/repos/hyperoslo/ImagePicker/issues/132"},"comments":{"href":"https://api.github.com/repos/hyperoslo/ImagePicker/issues/132/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperoslo/ImagePicker/pulls/132/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperoslo/ImagePicker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperoslo/ImagePicker/pulls/132/commits"},"statuses":{"href":"https://api.github.com/repos/hyperoslo/ImagePicker/statuses/9254ee23f6a3f6860887b5785f791526ff7a1120"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"aashishdhawan","id":1090001,"avatar_url":"https://avatars.githubusercontent.com/u/1090001?v=3","gravatar_id":"","url":"https://api.github.com/users/aashishdhawan","html_url":"https://github.com/aashishdhawan","followers_url":"https://api.github.com/users/aashishdhawan/followers","following_url":"https://api.github.com/users/aashishdhawan/following{/other_user}","gists_url":"https://api.github.com/users/aashishdhawan/gists{/gist_id}","starred_url":"https://api.github.com/users/aashishdhawan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aashishdhawan/subscriptions","organizations_url":"https://api.github.com/users/aashishdhawan/orgs","repos_url":"https://api.github.com/users/aashishdhawan/repos","events_url":"https://api.github.com/users/aashishdhawan/events{/privacy}","received_events_url":"https://api.github.com/users/aashishdhawan/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":1,"additions":49,"deletions":58,"changed_files":2}}