{"action":"created","issue":{"url":"https://api.github.com/repos/elifesciences/search/issues/25","repository_url":"https://api.github.com/repos/elifesciences/search","labels_url":"https://api.github.com/repos/elifesciences/search/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/elifesciences/search/issues/25/comments","events_url":"https://api.github.com/repos/elifesciences/search/issues/25/events","html_url":"https://github.com/elifesciences/search/pull/25","id":186264963,"number":25,"title":"Vendor update","user":{"login":"stephenwf","id":8266711,"avatar_url":"https://avatars.githubusercontent.com/u/8266711?v=3","gravatar_id":"","url":"https://api.github.com/users/stephenwf","html_url":"https://github.com/stephenwf","followers_url":"https://api.github.com/users/stephenwf/followers","following_url":"https://api.github.com/users/stephenwf/following{/other_user}","gists_url":"https://api.github.com/users/stephenwf/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenwf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenwf/subscriptions","organizations_url":"https://api.github.com/users/stephenwf/orgs","repos_url":"https://api.github.com/users/stephenwf/repos","events_url":"https://api.github.com/users/stephenwf/events{/privacy}","received_events_url":"https://api.github.com/users/stephenwf/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-10-31T11:48:59Z","updated_at":"2016-11-03T09:34:21Z","closed_at":"2016-11-02T16:45:56Z","pull_request":{"url":"https://api.github.com/repos/elifesciences/search/pulls/25","html_url":"https://github.com/elifesciences/search/pull/25","diff_url":"https://github.com/elifesciences/search/pull/25.diff","patch_url":"https://github.com/elifesciences/search/pull/25.patch"},"body":"@giorgiosironi @elrossco22 \r\n\r\nI'm going to use this for now to try and get the code up to the latest \"source of truth\".\r\n\r\nThe latest changes that appear to be breaking are the subjects change from this format:\r\n```json\r\n\"subjects\": [\"id1\", \"id2\"]\r\n```\r\n\r\nto\r\n```json\r\n\"subjects\": [\r\n  {\"id\": \"id1\", \"name\": \"subject name 1\" },\r\n  {\"id\": \"id2\", \"name\": \"subject name 2\" },\r\n]\r\n```\r\n\r\nWe depend on this change being made to:\r\n\r\n- [x] API SDK\r\n- [x] API Dummy\r\n- [x] API Validator (Api-RAML)\r\n\r\nI will continue to update this with the latest vendors, and add the subject specific changes here.\r\n\r\nIn addition, I'm writing tests that are tied to the vendors (Api SDK). This will allow us to see BC breaks by using the data from the vendors and testing out code against them. (Test data providers). This should be good for catching regressions too. You can see the example posted here for Blog Articles which I'm using as a starting point, I will scale the test once we are happy with the level of coverage.\r\n"},"comment":{"url":"https://api.github.com/repos/elifesciences/search/issues/comments/258096811","html_url":"https://github.com/elifesciences/search/pull/25#issuecomment-258096811","issue_url":"https://api.github.com/repos/elifesciences/search/issues/25","id":258096811,"user":{"login":"giorgiosironi","id":160299,"avatar_url":"https://avatars.githubusercontent.com/u/160299?v=3","gravatar_id":"","url":"https://api.github.com/users/giorgiosironi","html_url":"https://github.com/giorgiosironi","followers_url":"https://api.github.com/users/giorgiosironi/followers","following_url":"https://api.github.com/users/giorgiosironi/following{/other_user}","gists_url":"https://api.github.com/users/giorgiosironi/gists{/gist_id}","starred_url":"https://api.github.com/users/giorgiosironi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giorgiosironi/subscriptions","organizations_url":"https://api.github.com/users/giorgiosironi/orgs","repos_url":"https://api.github.com/users/giorgiosironi/repos","events_url":"https://api.github.com/users/giorgiosironi/events{/privacy}","received_events_url":"https://api.github.com/users/giorgiosironi/received_events","type":"User","site_admin":false},"created_at":"2016-11-03T09:34:21Z","updated_at":"2016-11-03T09:34:21Z","body":"Interestingly, this code run fine on `search--ci` but failed the smoke tests on `search--end2end`:\r\n```\r\n$ curl -v http://localhost/search\r\n* Hostname was NOT found in DNS cache\r\n*   Trying 127.0.0.1...\r\n* Connected to localhost (127.0.0.1) port 80 (#0)\r\n> GET /search HTTP/1.1\r\n> User-Agent: curl/7.35.0\r\n> Host: localhost\r\n> Accept: */*\r\n> \r\n< HTTP/1.1 500 Internal Server Error\r\n* Server nginx/1.4.6 (Ubuntu) is not blacklisted\r\n< Server: nginx/1.4.6 (Ubuntu)\r\n< Date: Thu, 03 Nov 2016 09:31:14 GMT\r\n< Content-Type: text/html; charset=UTF-8\r\n< Transfer-Encoding: chunked\r\n< Connection: keep-alive\r\n< \r\n* Connection #0 to host localhost left intact\r\nelife@end2end--search:/srv/search$ tail -n 1 /var/log/php_errors.log\r\n[03-Nov-2016 09:31:14 UTC] PHP Fatal error:  Trait 'tests\\eLife\\Search\\RamlRequirement' not found in /srv/search/src/Search/Api/Query/MockQueryBuilder.php on line 9\r\n```"}}
{"actor":{"display_login":"giorgiosironi"}}