{"action":"created","issue":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2234","repository_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge","labels_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2234/labels{/name}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2234/comments","events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2234/events","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2234","id":119988815,"number":2234,"title":"Add support for context based key bindings","user":{"login":"Lunatrius","id":864627,"avatar_url":"https://avatars.githubusercontent.com/u/864627?v=3","gravatar_id":"","url":"https://api.github.com/users/Lunatrius","html_url":"https://github.com/Lunatrius","followers_url":"https://api.github.com/users/Lunatrius/followers","following_url":"https://api.github.com/users/Lunatrius/following{/other_user}","gists_url":"https://api.github.com/users/Lunatrius/gists{/gist_id}","starred_url":"https://api.github.com/users/Lunatrius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lunatrius/subscriptions","organizations_url":"https://api.github.com/users/Lunatrius/orgs","repos_url":"https://api.github.com/users/Lunatrius/repos","events_url":"https://api.github.com/users/Lunatrius/events{/privacy}","received_events_url":"https://api.github.com/users/Lunatrius/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels/Feature","name":"Feature","color":"009800"},{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels/RFC","name":"RFC","color":"006b75"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":17,"created_at":"2015-12-02T17:01:57Z","updated_at":"2016-02-14T23:31:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2234","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2234","diff_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2234.diff","patch_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2234.patch"},"body":"The code in the PR is tested and works, but is by no means final, it's merely a **draft/mock-up** for the discussion/feedback that is needed.\r\n\r\nCurrently only the key press is implemented, however adding key holding should be fairly trivial."},"comment":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/comments/184004981","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2234#issuecomment-184004981","issue_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2234","id":184004981,"user":{"login":"mezz","id":916092,"avatar_url":"https://avatars.githubusercontent.com/u/916092?v=3","gravatar_id":"","url":"https://api.github.com/users/mezz","html_url":"https://github.com/mezz","followers_url":"https://api.github.com/users/mezz/followers","following_url":"https://api.github.com/users/mezz/following{/other_user}","gists_url":"https://api.github.com/users/mezz/gists{/gist_id}","starred_url":"https://api.github.com/users/mezz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mezz/subscriptions","organizations_url":"https://api.github.com/users/mezz/orgs","repos_url":"https://api.github.com/users/mezz/repos","events_url":"https://api.github.com/users/mezz/events{/privacy}","received_events_url":"https://api.github.com/users/mezz/received_events","type":"User","site_admin":false},"created_at":"2016-02-14T23:31:03Z","updated_at":"2016-02-14T23:31:03Z","body":"I worry that this PR is going off the rails.\r\nBuilding a robust key system with callbacks should be out of scope for this problem. Getting vanilla to follow the rules of any such system is not possible, which negates most of the benefits.\r\n\r\nAll that's needed is \"modifier + key\" registrations in the Controls menu, and a boolean setting to say \"This hotkey is context-sensitive and does not care about conflicts, please ignore them\". It will let the modders, players, and pack makers resolve conflicts."}}