{"action":"created","issue":{"url":"https://api.github.com/repos/ipfs/js-ipfs/issues/670","repository_url":"https://api.github.com/repos/ipfs/js-ipfs","labels_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/670/labels{/name}","comments_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/670/comments","events_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/670/events","html_url":"https://github.com/ipfs/js-ipfs/pull/670","id":195721206,"number":670,"title":"fix: update sharness tests to use right cli","user":{"login":"diasdavid","id":1211152,"avatar_url":"https://avatars.githubusercontent.com/u/1211152?v=3","gravatar_id":"","url":"https://api.github.com/users/diasdavid","html_url":"https://github.com/diasdavid","followers_url":"https://api.github.com/users/diasdavid/followers","following_url":"https://api.github.com/users/diasdavid/following{/other_user}","gists_url":"https://api.github.com/users/diasdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/diasdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasdavid/subscriptions","organizations_url":"https://api.github.com/users/diasdavid/orgs","repos_url":"https://api.github.com/users/diasdavid/repos","events_url":"https://api.github.com/users/diasdavid/events{/privacy}","received_events_url":"https://api.github.com/users/diasdavid/received_events","type":"User","site_admin":false},"labels":[{"id":491319655,"url":"https://api.github.com/repos/ipfs/js-ipfs/labels/ready","name":"ready","color":"e6e6e6","default":false}],"state":"open","locked":false,"assignee":{"login":"chriscool","id":208954,"avatar_url":"https://avatars.githubusercontent.com/u/208954?v=3","gravatar_id":"","url":"https://api.github.com/users/chriscool","html_url":"https://github.com/chriscool","followers_url":"https://api.github.com/users/chriscool/followers","following_url":"https://api.github.com/users/chriscool/following{/other_user}","gists_url":"https://api.github.com/users/chriscool/gists{/gist_id}","starred_url":"https://api.github.com/users/chriscool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriscool/subscriptions","organizations_url":"https://api.github.com/users/chriscool/orgs","repos_url":"https://api.github.com/users/chriscool/repos","events_url":"https://api.github.com/users/chriscool/events{/privacy}","received_events_url":"https://api.github.com/users/chriscool/received_events","type":"User","site_admin":false},"assignees":[{"login":"chriscool","id":208954,"avatar_url":"https://avatars.githubusercontent.com/u/208954?v=3","gravatar_id":"","url":"https://api.github.com/users/chriscool","html_url":"https://github.com/chriscool","followers_url":"https://api.github.com/users/chriscool/followers","following_url":"https://api.github.com/users/chriscool/following{/other_user}","gists_url":"https://api.github.com/users/chriscool/gists{/gist_id}","starred_url":"https://api.github.com/users/chriscool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriscool/subscriptions","organizations_url":"https://api.github.com/users/chriscool/orgs","repos_url":"https://api.github.com/users/chriscool/repos","events_url":"https://api.github.com/users/chriscool/events{/privacy}","received_events_url":"https://api.github.com/users/chriscool/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-12-15T05:38:12Z","updated_at":"2016-12-19T07:24:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ipfs/js-ipfs/pulls/670","html_url":"https://github.com/ipfs/js-ipfs/pull/670","diff_url":"https://github.com/ipfs/js-ipfs/pull/670.diff","patch_url":"https://github.com/ipfs/js-ipfs/pull/670.patch"},"body":"@chriscool I've updated the sharness tests to point to `jsipfs` instead of `ipfs`. Everything seems ok to me, just wanted your confirmation."},"comment":{"url":"https://api.github.com/repos/ipfs/js-ipfs/issues/comments/267898419","html_url":"https://github.com/ipfs/js-ipfs/pull/670#issuecomment-267898419","issue_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/670","id":267898419,"user":{"login":"chriscool","id":208954,"avatar_url":"https://avatars.githubusercontent.com/u/208954?v=3","gravatar_id":"","url":"https://api.github.com/users/chriscool","html_url":"https://github.com/chriscool","followers_url":"https://api.github.com/users/chriscool/followers","following_url":"https://api.github.com/users/chriscool/following{/other_user}","gists_url":"https://api.github.com/users/chriscool/gists{/gist_id}","starred_url":"https://api.github.com/users/chriscool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriscool/subscriptions","organizations_url":"https://api.github.com/users/chriscool/orgs","repos_url":"https://api.github.com/users/chriscool/repos","events_url":"https://api.github.com/users/chriscool/events{/privacy}","received_events_url":"https://api.github.com/users/chriscool/received_events","type":"User","site_admin":false},"created_at":"2016-12-19T07:24:39Z","updated_at":"2016-12-19T07:24:39Z","body":"I don't think that is necessary. The Makefile already does:\r\n\r\n```\r\n../bin/ipfs:\r\n\tmkdir -p ../bin\r\n\tcd ../bin && ln -s ../../src/cli/bin.js ipfs\r\n```\r\n\r\nThis means that when running tests \"ipfs\" will be in fact \"jsipfs\".\r\n\r\nAnd with this we don't need to change tests which mean that hopefully in the end we will be able to have exactly the same test suite for jsipfs and for go-ipfs.\r\n"}}
{"actor":{"display_login":"chriscool"}}