{"action":"created","comment":{"url":"https://api.github.com/repos/neovim/neovim/pulls/comments/70170093","id":70170093,"diff_hunk":"@@ -793,6 +794,57 @@ static VTermKey convert_key(int key, VTermModifier *statep)\n     case K_KMULTIPLY: return VTERM_KEY_KP_MULT;\n     case K_KDIVIDE:   return VTERM_KEY_KP_DIVIDE;\n \n+    case K_S_F1:      *statep |= VTERM_MOD_SHIFT;","path":"src/nvim/terminal.c","position":12,"original_position":12,"commit_id":"b30162b8be9c2239545c6d9fb6f40db9da94a67c","original_commit_id":"b30162b8be9c2239545c6d9fb6f40db9da94a67c","user":{"login":"justinmk","id":1359421,"avatar_url":"https://avatars.githubusercontent.com/u/1359421?v=3","gravatar_id":"","url":"https://api.github.com/users/justinmk","html_url":"https://github.com/justinmk","followers_url":"https://api.github.com/users/justinmk/followers","following_url":"https://api.github.com/users/justinmk/following{/other_user}","gists_url":"https://api.github.com/users/justinmk/gists{/gist_id}","starred_url":"https://api.github.com/users/justinmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinmk/subscriptions","organizations_url":"https://api.github.com/users/justinmk/orgs","repos_url":"https://api.github.com/users/justinmk/repos","events_url":"https://api.github.com/users/justinmk/events{/privacy}","received_events_url":"https://api.github.com/users/justinmk/received_events","type":"User","site_admin":false},"body":"perhaps all of these `K_S_*` variants should be grouped in a separate switch before this one.\r\n\r\n```c\r\nswitch(key) {\r\n    case K_S_F2:\r\n    case K_S_F3:\r\n    case K_S_F4:\r\n    ...\r\n      *statep |= VTERM_MOD_SHIFT;\r\n}","created_at":"2016-07-09T17:51:56Z","updated_at":"2016-07-09T17:51:56Z","html_url":"https://github.com/neovim/neovim/pull/5014#discussion_r70170093","pull_request_url":"https://api.github.com/repos/neovim/neovim/pulls/5014","_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/70170093"},"html":{"href":"https://github.com/neovim/neovim/pull/5014#discussion_r70170093"},"pull_request":{"href":"https://api.github.com/repos/neovim/neovim/pulls/5014"}}},"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/5014","id":76379280,"html_url":"https://github.com/neovim/neovim/pull/5014","diff_url":"https://github.com/neovim/neovim/pull/5014.diff","patch_url":"https://github.com/neovim/neovim/pull/5014.patch","issue_url":"https://api.github.com/repos/neovim/neovim/issues/5014","number":5014,"state":"open","locked":false,"title":"[WIP] Fix function keys in embedded terminal","user":{"login":"rjmill","id":12422195,"avatar_url":"https://avatars.githubusercontent.com/u/12422195?v=3","gravatar_id":"","url":"https://api.github.com/users/rjmill","html_url":"https://github.com/rjmill","followers_url":"https://api.github.com/users/rjmill/followers","following_url":"https://api.github.com/users/rjmill/following{/other_user}","gists_url":"https://api.github.com/users/rjmill/gists{/gist_id}","starred_url":"https://api.github.com/users/rjmill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjmill/subscriptions","organizations_url":"https://api.github.com/users/rjmill/orgs","repos_url":"https://api.github.com/users/rjmill/repos","events_url":"https://api.github.com/users/rjmill/events{/privacy}","received_events_url":"https://api.github.com/users/rjmill/received_events","type":"User","site_admin":false},"body":"fix #4343\r\n\r\nF5-F12 seem to be working perfectly. F1-F4 work as expected in htop and bash, but output extra characters in zsh.","created_at":"2016-07-06T05:05:47Z","updated_at":"2016-07-09T17:51:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"282c8b8aa6bec67f5fe3a2afdace1b82ae2945d7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/neovim/neovim/pulls/5014/commits","review_comments_url":"https://api.github.com/repos/neovim/neovim/pulls/5014/comments","review_comment_url":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/5014/comments","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/b30162b8be9c2239545c6d9fb6f40db9da94a67c","head":{"label":"rjmill:fix-function-keys","ref":"fix-function-keys","sha":"b30162b8be9c2239545c6d9fb6f40db9da94a67c","user":{"login":"rjmill","id":12422195,"avatar_url":"https://avatars.githubusercontent.com/u/12422195?v=3","gravatar_id":"","url":"https://api.github.com/users/rjmill","html_url":"https://github.com/rjmill","followers_url":"https://api.github.com/users/rjmill/followers","following_url":"https://api.github.com/users/rjmill/following{/other_user}","gists_url":"https://api.github.com/users/rjmill/gists{/gist_id}","starred_url":"https://api.github.com/users/rjmill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjmill/subscriptions","organizations_url":"https://api.github.com/users/rjmill/orgs","repos_url":"https://api.github.com/users/rjmill/repos","events_url":"https://api.github.com/users/rjmill/events{/privacy}","received_events_url":"https://api.github.com/users/rjmill/received_events","type":"User","site_admin":false},"repo":{"id":51489681,"name":"neovim","full_name":"rjmill/neovim","owner":{"login":"rjmill","id":12422195,"avatar_url":"https://avatars.githubusercontent.com/u/12422195?v=3","gravatar_id":"","url":"https://api.github.com/users/rjmill","html_url":"https://github.com/rjmill","followers_url":"https://api.github.com/users/rjmill/followers","following_url":"https://api.github.com/users/rjmill/following{/other_user}","gists_url":"https://api.github.com/users/rjmill/gists{/gist_id}","starred_url":"https://api.github.com/users/rjmill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjmill/subscriptions","organizations_url":"https://api.github.com/users/rjmill/orgs","repos_url":"https://api.github.com/users/rjmill/repos","events_url":"https://api.github.com/users/rjmill/events{/privacy}","received_events_url":"https://api.github.com/users/rjmill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rjmill/neovim","description":"Vim-fork focused on extensibility and agility. Consider helping sustain Neovim development! ","fork":true,"url":"https://api.github.com/repos/rjmill/neovim","forks_url":"https://api.github.com/repos/rjmill/neovim/forks","keys_url":"https://api.github.com/repos/rjmill/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rjmill/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rjmill/neovim/teams","hooks_url":"https://api.github.com/repos/rjmill/neovim/hooks","issue_events_url":"https://api.github.com/repos/rjmill/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/rjmill/neovim/events","assignees_url":"https://api.github.com/repos/rjmill/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/rjmill/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/rjmill/neovim/tags","blobs_url":"https://api.github.com/repos/rjmill/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rjmill/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rjmill/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/rjmill/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rjmill/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/rjmill/neovim/languages","stargazers_url":"https://api.github.com/repos/rjmill/neovim/stargazers","contributors_url":"https://api.github.com/repos/rjmill/neovim/contributors","subscribers_url":"https://api.github.com/repos/rjmill/neovim/subscribers","subscription_url":"https://api.github.com/repos/rjmill/neovim/subscription","commits_url":"https://api.github.com/repos/rjmill/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/rjmill/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/rjmill/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/rjmill/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/rjmill/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/rjmill/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rjmill/neovim/merges","archive_url":"https://api.github.com/repos/rjmill/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rjmill/neovim/downloads","issues_url":"https://api.github.com/repos/rjmill/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/rjmill/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/rjmill/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/rjmill/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rjmill/neovim/labels{/name}","releases_url":"https://api.github.com/repos/rjmill/neovim/releases{/id}","deployments_url":"https://api.github.com/repos/rjmill/neovim/deployments","created_at":"2016-02-11T02:33:36Z","updated_at":"2016-02-11T02:33:42Z","pushed_at":"2016-07-09T17:45:39Z","git_url":"git://github.com/rjmill/neovim.git","ssh_url":"git@github.com:rjmill/neovim.git","clone_url":"https://github.com/rjmill/neovim.git","svn_url":"https://github.com/rjmill/neovim","homepage":"https://salt.bountysource.com/teams/neovim","size":43198,"stargazers_count":0,"watchers_count":0,"language":"VimL","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neovim:master","ref":"master","sha":"ef72303a1ff862fde6d9399941c091c0a0692cce","user":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"repo":{"id":16408992,"name":"neovim","full_name":"neovim/neovim","owner":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neovim/neovim","description":"Vim-fork focused on extensibility and agility.","fork":false,"url":"https://api.github.com/repos/neovim/neovim","forks_url":"https://api.github.com/repos/neovim/neovim/forks","keys_url":"https://api.github.com/repos/neovim/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neovim/neovim/teams","hooks_url":"https://api.github.com/repos/neovim/neovim/hooks","issue_events_url":"https://api.github.com/repos/neovim/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/neovim/neovim/events","assignees_url":"https://api.github.com/repos/neovim/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/neovim/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/neovim/neovim/tags","blobs_url":"https://api.github.com/repos/neovim/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neovim/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neovim/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/neovim/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/neovim/neovim/languages","stargazers_url":"https://api.github.com/repos/neovim/neovim/stargazers","contributors_url":"https://api.github.com/repos/neovim/neovim/contributors","subscribers_url":"https://api.github.com/repos/neovim/neovim/subscribers","subscription_url":"https://api.github.com/repos/neovim/neovim/subscription","commits_url":"https://api.github.com/repos/neovim/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/neovim/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/neovim/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/neovim/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/neovim/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/neovim/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neovim/neovim/merges","archive_url":"https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neovim/neovim/downloads","issues_url":"https://api.github.com/repos/neovim/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/neovim/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/neovim/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neovim/neovim/labels{/name}","releases_url":"https://api.github.com/repos/neovim/neovim/releases{/id}","deployments_url":"https://api.github.com/repos/neovim/neovim/deployments","created_at":"2014-01-31T13:39:22Z","updated_at":"2016-07-09T17:29:26Z","pushed_at":"2016-07-09T17:45:40Z","git_url":"git://github.com/neovim/neovim.git","ssh_url":"git@github.com:neovim/neovim.git","clone_url":"https://github.com/neovim/neovim.git","svn_url":"https://github.com/neovim/neovim","homepage":"https://salt.bountysource.com/teams/neovim","size":70686,"stargazers_count":19249,"watchers_count":19249,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1354,"mirror_url":null,"open_issues_count":721,"forks":1354,"open_issues":721,"watchers":19249,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/5014"},"html":{"href":"https://github.com/neovim/neovim/pull/5014"},"issue":{"href":"https://api.github.com/repos/neovim/neovim/issues/5014"},"comments":{"href":"https://api.github.com/repos/neovim/neovim/issues/5014/comments"},"review_comments":{"href":"https://api.github.com/repos/neovim/neovim/pulls/5014/comments"},"review_comment":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neovim/neovim/pulls/5014/commits"},"statuses":{"href":"https://api.github.com/repos/neovim/neovim/statuses/b30162b8be9c2239545c6d9fb6f40db9da94a67c"}}}}
{"actor":{"display_login":"justinmk"}}