{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7287","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7287/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7287/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7287/events","html_url":"https://github.com/bitcoin/bitcoin/pull/7287","id":124764198,"number":7287,"title":"Consensus: Remove calls to error() and FormatStateMessage()","user":{"login":"jtimon","id":1008458,"avatar_url":"https://avatars.githubusercontent.com/u/1008458?v=3","gravatar_id":"","url":"https://api.github.com/users/jtimon","html_url":"https://github.com/jtimon","followers_url":"https://api.github.com/users/jtimon/followers","following_url":"https://api.github.com/users/jtimon/following{/other_user}","gists_url":"https://api.github.com/users/jtimon/gists{/gist_id}","starred_url":"https://api.github.com/users/jtimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtimon/subscriptions","organizations_url":"https://api.github.com/users/jtimon/orgs","repos_url":"https://api.github.com/users/jtimon/repos","events_url":"https://api.github.com/users/jtimon/events{/privacy}","received_events_url":"https://api.github.com/users/jtimon/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Refactoring","name":"Refactoring","color":"E6F6D6"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2016-01-04T14:03:39Z","updated_at":"2016-01-30T10:18:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7287","html_url":"https://github.com/bitcoin/bitcoin/pull/7287","diff_url":"https://github.com/bitcoin/bitcoin/pull/7287.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/7287.patch"},"body":"Remove calls to error() and FormatStateMessage() ~~and FormatMoney()~~ from some consensus code in main.\r\n\r\nThis is necessary because libconsensus cannot depend on util.cpp, which exposes globals among other things. Doing this before moving this consensus code out of main allows consensus/consensus.cpp to never depend on util.cpp and it removes the necessity to make FormatStateMessage() non-static to call it, temporarily, from consensus/consensus.cpp.\r\n\r\nThis also restores some error reporting that seems to have been lost, maybe while moving to use FormatStateMessage()."},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/177136655","html_url":"https://github.com/bitcoin/bitcoin/pull/7287#issuecomment-177136655","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7287","id":177136655,"user":{"login":"laanwj","id":126646,"avatar_url":"https://avatars.githubusercontent.com/u/126646?v=3","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"created_at":"2016-01-30T10:18:10Z","updated_at":"2016-01-30T10:18:10Z","body":"Tested ACK 93fc58c"}}