{"action":"created","issue":{"url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/951","repository_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React","labels_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/951/labels{/name}","comments_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/951/comments","events_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/951/events","html_url":"https://github.com/Semantic-Org/Semantic-UI-React/pull/951","id":192055633,"number":951,"title":"breaking(Form|RatingIcon|Search|SearchResult): Pass props to event handlers","user":{"login":"jcarbo","id":847027,"avatar_url":"https://avatars.githubusercontent.com/u/847027?v=3","gravatar_id":"","url":"https://api.github.com/users/jcarbo","html_url":"https://github.com/jcarbo","followers_url":"https://api.github.com/users/jcarbo/followers","following_url":"https://api.github.com/users/jcarbo/following{/other_user}","gists_url":"https://api.github.com/users/jcarbo/gists{/gist_id}","starred_url":"https://api.github.com/users/jcarbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcarbo/subscriptions","organizations_url":"https://api.github.com/users/jcarbo/orgs","repos_url":"https://api.github.com/users/jcarbo/repos","events_url":"https://api.github.com/users/jcarbo/events{/privacy}","received_events_url":"https://api.github.com/users/jcarbo/received_events","type":"User","site_admin":false},"labels":[{"id":432565724,"url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/labels/ready%20for%20review","name":"ready for review","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-11-28T16:45:09Z","updated_at":"2016-11-30T19:54:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/pulls/951","html_url":"https://github.com/Semantic-Org/Semantic-UI-React/pull/951","diff_url":"https://github.com/Semantic-Org/Semantic-UI-React/pull/951.diff","patch_url":"https://github.com/Semantic-Org/Semantic-UI-React/pull/951.patch"},"body":"Breaking Changes!\r\n-------------------\r\n\r\nThe following components have breaking changes in their event handler props.\r\n\r\n### Form\r\n\r\nHandler | Previous Signature | Current Signature\r\n------- | ------------------ | -----------------\r\nonClick | (e, formData) | (e, { ...props, formData })\r\n\r\n### RatingIcon\r\n\r\nHandler | Previous Signature | Current Signature\r\n------- | ------------------ | -----------------\r\nonClick | (e, index) | (e, { ...props, index })\r\nonKeyUp | (e, index) | (e, { ...props, index })\r\nonMouseEnter | (e, index) | (e, { ...props, index })\r\n\r\n### Search\r\n\r\nNOTE: The handler name changed from `onChange` to `onResultSelect`. The change was made because:\r\n- onChange doesn't really make sense in this context since nothing is really changing.\r\n- given the result is being returned, onChange made even less sense.\r\n- it maps closer to the SUI-core event (`onSelect`). The reason to not use `onSelect` is because that's a built-in html event type for when a user selects text.\r\n\r\nHandler | New Name | Previous Signature | Current Signature\r\n------- | -------- | ------------------ | -----------------\r\nonChange | onResultSelect | (e, result) | (e, result) _no change_\r\n\r\n### SearchResult\r\n\r\nHandler | Previous Signature | Current Signature\r\n------- | ------------------ | -----------------\r\nonClick | (e, id) | (e, { ...props, id })\r\n\r\n\r\n----\r\n\r\nFixes #623\r\n\r\nThis updates the common tests for event handling to ensure any handlers that we wrap are called with `(event, data)` as arguments."},"comment":{"url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/comments/263976990","html_url":"https://github.com/Semantic-Org/Semantic-UI-React/pull/951#issuecomment-263976990","issue_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/951","id":263976990,"user":{"login":"levithomason","id":5067638,"avatar_url":"https://avatars.githubusercontent.com/u/5067638?v=3","gravatar_id":"","url":"https://api.github.com/users/levithomason","html_url":"https://github.com/levithomason","followers_url":"https://api.github.com/users/levithomason/followers","following_url":"https://api.github.com/users/levithomason/following{/other_user}","gists_url":"https://api.github.com/users/levithomason/gists{/gist_id}","starred_url":"https://api.github.com/users/levithomason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levithomason/subscriptions","organizations_url":"https://api.github.com/users/levithomason/orgs","repos_url":"https://api.github.com/users/levithomason/repos","events_url":"https://api.github.com/users/levithomason/events{/privacy}","received_events_url":"https://api.github.com/users/levithomason/received_events","type":"User","site_admin":false},"created_at":"2016-11-30T19:54:15Z","updated_at":"2016-11-30T19:54:15Z","body":"### Doc Examples\r\n\r\nI'm guessing there are several doc site examples that need to be updated to reflect the new changes as well.  Would finding handler prop names in the docs, `/on[A-Z]\\w+=\\{/`, and updating where necessary.\r\n\r\n### RatingIcon\r\n\r\n>For clarity, RatingIcon is internal component and it can't be used outside Rating component. I think it's bad idea to export it.\r\n\r\n@layershifter Good call. We should make this a private component in this case.  Simply prefixing its name with `_` will make it private.  The common tests will then automatically assert that it _is not_ exposed anywhere in the API."}}
{"actor":{"display_login":"levithomason"}}