{"action":"created","comment":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/51931352","id":51931352,"diff_hunk":"@@ -25,15 +25,14 @@\n \n import org.voltdb.VoltTable;\n import org.voltdb.utils.MiscUtils;\n-import org.voltdb.VoltProcedure;\n \n public class UpdateBothMP extends ReplicatedUpdateBaseProc {\n \n     public VoltTable[] run(byte cid, long rid, byte[] value, byte rollback) {\n-        VoltTable[] results1 = doWork(p_getCIDData, p_cleanUp, p_insert, p_export, p_getAdhocData,\n-                cid, rid, value, rollback);\n-        VoltTable[] results2 = doWork(r_getCIDData, r_cleanUp, r_insert, r_export, r_getAdhocData,\n-                cid, rid, value, rollback);\n+        VoltTable[] results1 = doWork(p_getCIDData, p_cleanUp, p_insert, p_export, p_getAdhocData, p_getViewData,\n+                cid, rid, value, rollback, true);","path":"tests/test_apps/txnid-selfcheck2/src/txnIdSelfCheck/procedures/UpdateBothMP.java","position":14,"original_position":14,"commit_id":"24631a5e44b281977c5059f58454c0c93c54a5e5","original_commit_id":"714415315e6faa1ebcdd5fb3500b27ec0c457222","user":{"login":"pdshaw","id":11930069,"avatar_url":"https://avatars.githubusercontent.com/u/11930069?v=3","gravatar_id":"","url":"https://api.github.com/users/pdshaw","html_url":"https://github.com/pdshaw","followers_url":"https://api.github.com/users/pdshaw/followers","following_url":"https://api.github.com/users/pdshaw/following{/other_user}","gists_url":"https://api.github.com/users/pdshaw/gists{/gist_id}","starred_url":"https://api.github.com/users/pdshaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdshaw/subscriptions","organizations_url":"https://api.github.com/users/pdshaw/orgs","repos_url":"https://api.github.com/users/pdshaw/repos","events_url":"https://api.github.com/users/pdshaw/events{/privacy}","received_events_url":"https://api.github.com/users/pdshaw/received_events","type":"User","site_admin":false},"body":"Rollback is still there.\r\n\r\nI added \"usestreamviews\" to the base class. The partitioned classes pass true to use and check the export MV. The others pass \"false\" since export MV's aren't supported.\r\n\r\nI'll update comments to clarify this.","created_at":"2016-02-04T20:17:53Z","updated_at":"2016-02-04T20:17:53Z","html_url":"https://github.com/VoltDB/voltdb/pull/3242#discussion_r51931352","pull_request_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/3242","_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/51931352"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/3242#discussion_r51931352"},"pull_request":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/3242"}}},"pull_request":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/3242","id":58204307,"html_url":"https://github.com/VoltDB/voltdb/pull/3242","diff_url":"https://github.com/VoltDB/voltdb/pull/3242.diff","patch_url":"https://github.com/VoltDB/voltdb/pull/3242.patch","issue_url":"https://api.github.com/repos/VoltDB/voltdb/issues/3242","number":3242,"state":"open","locked":false,"title":"Eng 9544 Adds export materialized view and checking to txnid-selfcheck2 test","user":{"login":"pdshaw","id":11930069,"avatar_url":"https://avatars.githubusercontent.com/u/11930069?v=3","gravatar_id":"","url":"https://api.github.com/users/pdshaw","html_url":"https://github.com/pdshaw","followers_url":"https://api.github.com/users/pdshaw/followers","following_url":"https://api.github.com/users/pdshaw/following{/other_user}","gists_url":"https://api.github.com/users/pdshaw/gists{/gist_id}","starred_url":"https://api.github.com/users/pdshaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdshaw/subscriptions","organizations_url":"https://api.github.com/users/pdshaw/orgs","repos_url":"https://api.github.com/users/pdshaw/repos","events_url":"https://api.github.com/users/pdshaw/events{/privacy}","received_events_url":"https://api.github.com/users/pdshaw/received_events","type":"User","site_admin":false},"body":"Note -- contains new test, exportview, which is a simplified test of export with materialized view, used for early testing of the feature.\r\n\r\nWe can delete it before merge to master if its functionality is subsumed by txnid2 or other tests.","created_at":"2016-02-03T21:36:01Z","updated_at":"2016-02-04T20:17:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f573dfa4ed4d49ba85a2977a64455a7a38f355e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/3242/commits","review_comments_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/3242/comments","review_comment_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/issues/3242/comments","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/24631a5e44b281977c5059f58454c0c93c54a5e5","head":{"label":"VoltDB:ENG-9544","ref":"ENG-9544","sha":"24631a5e44b281977c5059f58454c0c93c54a5e5","user":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"name":"voltdb","full_name":"VoltDB/voltdb","owner":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","deployments_url":"https://api.github.com/repos/VoltDB/voltdb/deployments","created_at":"2011-09-23T18:46:12Z","updated_at":"2016-02-04T10:04:41Z","pushed_at":"2016-02-04T20:17:43Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":528706,"stargazers_count":729,"watchers_count":729,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":217,"mirror_url":null,"open_issues_count":23,"forks":217,"open_issues":23,"watchers":729,"default_branch":"master"}},"base":{"label":"VoltDB:ENG-9067","ref":"ENG-9067","sha":"72bde4b7bd442a421807056427e35b4f84f07082","user":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"name":"voltdb","full_name":"VoltDB/voltdb","owner":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","deployments_url":"https://api.github.com/repos/VoltDB/voltdb/deployments","created_at":"2011-09-23T18:46:12Z","updated_at":"2016-02-04T10:04:41Z","pushed_at":"2016-02-04T20:17:43Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":528706,"stargazers_count":729,"watchers_count":729,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":217,"mirror_url":null,"open_issues_count":23,"forks":217,"open_issues":23,"watchers":729,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/3242"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/3242"},"issue":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/3242"},"comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/3242/comments"},"review_comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/3242/comments"},"review_comment":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/3242/commits"},"statuses":{"href":"https://api.github.com/repos/VoltDB/voltdb/statuses/24631a5e44b281977c5059f58454c0c93c54a5e5"}}}}