{"action":"created","issue":{"url":"https://api.github.com/repos/mesosphere/marathon-lb/issues/308","repository_url":"https://api.github.com/repos/mesosphere/marathon-lb","labels_url":"https://api.github.com/repos/mesosphere/marathon-lb/issues/308/labels{/name}","comments_url":"https://api.github.com/repos/mesosphere/marathon-lb/issues/308/comments","events_url":"https://api.github.com/repos/mesosphere/marathon-lb/issues/308/events","html_url":"https://github.com/mesosphere/marathon-lb/pull/308","id":176030272,"number":308,"title":"Python cleanup","user":{"login":"JayH5","id":1748643,"avatar_url":"https://avatars.githubusercontent.com/u/1748643?v=3","gravatar_id":"","url":"https://api.github.com/users/JayH5","html_url":"https://github.com/JayH5","followers_url":"https://api.github.com/users/JayH5/followers","following_url":"https://api.github.com/users/JayH5/following{/other_user}","gists_url":"https://api.github.com/users/JayH5/gists{/gist_id}","starred_url":"https://api.github.com/users/JayH5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JayH5/subscriptions","organizations_url":"https://api.github.com/users/JayH5/orgs","repos_url":"https://api.github.com/users/JayH5/repos","events_url":"https://api.github.com/users/JayH5/events{/privacy}","received_events_url":"https://api.github.com/users/JayH5/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-09T14:57:37Z","updated_at":"2016-09-09T14:57:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mesosphere/marathon-lb/pulls/308","html_url":"https://github.com/mesosphere/marathon-lb/pull/308","diff_url":"https://github.com/mesosphere/marathon-lb/pull/308.diff","patch_url":"https://github.com/mesosphere/marathon-lb/pull/308.patch"},"body":"General cleanup of Python code, mostly around imports and the test runner.\r\n\r\n* Apply PEP-8 guidelines to imports: https://www.python.org/dev/peps/pep-0008/#imports\r\n* Split development requirements into `requirements-dev.txt`\r\n* Add note to README about how to run tests\r\n* Use pytest to run tests\r\n* Use pytest-cov for coverage tests\r\n* Use pytest-pep8 for pep8 style check\r\n* Fix some duplicated test names (this was causing at least 2 tests not to run)\r\n\r\nThis will obviously need someone to update the CI settings so that requirements are installed properly and all the tests are run.\r\n\r\nThere is one more problem with the code that I picked up running [`flake8`](http://flake8.readthedocs.io/en/latest/): [this method](https://github.com/mesosphere/marathon-lb/blob/v1.3.5/utils.py#L149-L150) doesn't actually set `ip_cache` as it sets `ip_cache` local to the method, not the module. I'd recommend running a linter like `flake8` as part of the build, but it's a separate command that would need to be added to the CI so I can't do that."},"comment":{"url":"https://api.github.com/repos/mesosphere/marathon-lb/issues/comments/245938296","html_url":"https://github.com/mesosphere/marathon-lb/pull/308#issuecomment-245938296","issue_url":"https://api.github.com/repos/mesosphere/marathon-lb/issues/308","id":245938296,"user":{"login":"mesosphere-ci","id":16123494,"avatar_url":"https://avatars.githubusercontent.com/u/16123494?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere-ci","html_url":"https://github.com/mesosphere-ci","followers_url":"https://api.github.com/users/mesosphere-ci/followers","following_url":"https://api.github.com/users/mesosphere-ci/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere-ci/subscriptions","organizations_url":"https://api.github.com/users/mesosphere-ci/orgs","repos_url":"https://api.github.com/users/mesosphere-ci/repos","events_url":"https://api.github.com/users/mesosphere-ci/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere-ci/received_events","type":"User","site_admin":false},"created_at":"2016-09-09T14:57:38Z","updated_at":"2016-09-09T14:57:38Z","body":"Can one of the admins verify this patch?"}}
{"actor":{"display_login":"mesosphere-ci"}}