{"action":"created","issue":{"url":"https://api.github.com/repos/svof/svof/issues/169","repository_url":"https://api.github.com/repos/svof/svof","labels_url":"https://api.github.com/repos/svof/svof/issues/169/labels{/name}","comments_url":"https://api.github.com/repos/svof/svof/issues/169/comments","events_url":"https://api.github.com/repos/svof/svof/issues/169/events","html_url":"https://github.com/svof/svof/issues/169","id":142703752,"number":169,"title":"reset.defs on charname removes offline_defences","user":{"login":"bunster","id":8473052,"avatar_url":"https://avatars.githubusercontent.com/u/8473052?v=3","gravatar_id":"","url":"https://api.github.com/users/bunster","html_url":"https://github.com/bunster","followers_url":"https://api.github.com/users/bunster/followers","following_url":"https://api.github.com/users/bunster/following{/other_user}","gists_url":"https://api.github.com/users/bunster/gists{/gist_id}","starred_url":"https://api.github.com/users/bunster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bunster/subscriptions","organizations_url":"https://api.github.com/users/bunster/orgs","repos_url":"https://api.github.com/users/bunster/repos","events_url":"https://api.github.com/users/bunster/events{/privacy}","received_events_url":"https://api.github.com/users/bunster/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/svof/svof/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/svof/svof/labels/low%20priority","name":"low priority","color":"009800"},{"url":"https://api.github.com/repos/svof/svof/labels/simple%20difficulty","name":"simple difficulty","color":"d4c5f9"},{"url":"https://api.github.com/repos/svof/svof/labels/up%20for%20grabs","name":"up for grabs","color":"006b75"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-22T16:30:12Z","updated_at":"2016-04-14T09:11:39Z","closed_at":null,"body":"As the title says, it looks like the order in which it is done kinda defeats the purpose of having _offline_defence_ on a _def_dict_.\r\n\r\n**signals.systemstart** calls **defload()** which adds the offline defences, then **reset.defs()** is called on **signals.(gmcp)charname**.\r\n\r\nAm I wrong to assume this is the case?"},"comment":{"url":"https://api.github.com/repos/svof/svof/issues/comments/209840511","html_url":"https://github.com/svof/svof/issues/169#issuecomment-209840511","issue_url":"https://api.github.com/repos/svof/svof/issues/169","id":209840511,"user":{"login":"vadi2","id":110988,"avatar_url":"https://avatars.githubusercontent.com/u/110988?v=3","gravatar_id":"","url":"https://api.github.com/users/vadi2","html_url":"https://github.com/vadi2","followers_url":"https://api.github.com/users/vadi2/followers","following_url":"https://api.github.com/users/vadi2/following{/other_user}","gists_url":"https://api.github.com/users/vadi2/gists{/gist_id}","starred_url":"https://api.github.com/users/vadi2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadi2/subscriptions","organizations_url":"https://api.github.com/users/vadi2/orgs","repos_url":"https://api.github.com/users/vadi2/repos","events_url":"https://api.github.com/users/vadi2/events{/privacy}","received_events_url":"https://api.github.com/users/vadi2/received_events","type":"User","site_admin":false},"created_at":"2016-04-14T09:11:39Z","updated_at":"2016-04-14T09:11:39Z","body":"Is there an actual issue with this that you're investigating? ``offline_defences`` is for defences that stay through QQ like dragonform, and the reset call is to reset defences that don't stay through QQ - you'll see it doesn't actually reset all defences:\r\n\r\n```\r\n    if not defs_data[def] or (defs_data[def] and not defs_data[def].stays_on_death) then\r\n      defc[def] = nil\r\n    end\r\n```"}}