{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/22498","repository_url":"https://api.github.com/repos/owncloud/core","labels_url":"https://api.github.com/repos/owncloud/core/issues/22498/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/22498/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/22498/events","html_url":"https://github.com/owncloud/core/pull/22498","id":134546796,"number":22498,"title":"Properly trigger testRemote after getting a 404 from remote fed share","user":{"login":"PVince81","id":277525,"avatar_url":"https://avatars.githubusercontent.com/u/277525?v=3","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/core/labels/4%20-%20To%20release","name":"4 - To release","color":"ededed"},{"url":"https://api.github.com/repos/owncloud/core/labels/feature:federated-cloud-sharing","name":"feature:federated-cloud-sharing","color":"d4c5f9"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/48","html_url":"https://github.com/owncloud/core/milestones/9.0-current","labels_url":"https://api.github.com/repos/owncloud/core/milestones/48/labels","id":1196845,"number":48,"title":"9.0-current","description":"","creator":{"login":"cmonteroluque","id":879976,"avatar_url":"https://avatars.githubusercontent.com/u/879976?v=3","gravatar_id":"","url":"https://api.github.com/users/cmonteroluque","html_url":"https://github.com/cmonteroluque","followers_url":"https://api.github.com/users/cmonteroluque/followers","following_url":"https://api.github.com/users/cmonteroluque/following{/other_user}","gists_url":"https://api.github.com/users/cmonteroluque/gists{/gist_id}","starred_url":"https://api.github.com/users/cmonteroluque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmonteroluque/subscriptions","organizations_url":"https://api.github.com/users/cmonteroluque/orgs","repos_url":"https://api.github.com/users/cmonteroluque/repos","events_url":"https://api.github.com/users/cmonteroluque/events{/privacy}","received_events_url":"https://api.github.com/users/cmonteroluque/received_events","type":"User","site_admin":false},"open_issues":114,"closed_issues":1669,"state":"open","created_at":"2015-07-07T14:21:23Z","updated_at":"2016-02-24T14:47:08Z","due_on":"2016-03-08T04:00:00Z","closed_at":null},"comments":3,"created_at":"2016-02-18T11:00:30Z","updated_at":"2016-02-24T14:47:54Z","closed_at":"2016-02-18T13:24:55Z","pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/22498","html_url":"https://github.com/owncloud/core/pull/22498","diff_url":"https://github.com/owncloud/core/pull/22498.diff","patch_url":"https://github.com/owncloud/core/pull/22498.patch"},"body":"Whenever a remote fed share's shareinfo call returns a 404, don't\r\ndirectly assume the storage is not available by throwing\r\nStorageNotAvailableException. We need to properly throw\r\nNotFoundException to trigger the later logic that calls testRemote()\r\nthat verifies that the 404 is not from a broken server but really from\r\nan obsolete share.\r\n\r\nWhen throwing this exception, the following code gets triggered properly: https://github.com/owncloud/core/blob/73d46afc3c5ef237cc8a5431aa1bef4686a7521b/apps/files_sharing/lib/external/storage.php#L187\r\nAs you can see, if the remote server properly exists, it will then proceed to remove the share.\r\n\r\nI believe this bug was introduced when we moved to Guzzle, and exceptions needed to be thrown manually and that one was missing.\r\n\r\nFixes https://github.com/owncloud/core/issues/22483\r\n\r\nPlease review @rullzer @schiesbn @icewind1991 @nasli"},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/188285417","html_url":"https://github.com/owncloud/core/pull/22498#issuecomment-188285417","issue_url":"https://api.github.com/repos/owncloud/core/issues/22498","id":188285417,"user":{"login":"PVince81","id":277525,"avatar_url":"https://avatars.githubusercontent.com/u/277525?v=3","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"created_at":"2016-02-24T14:47:54Z","updated_at":"2016-02-24T14:47:54Z","body":"@karlitschek backport to stable8.1 and stable8.2 ?\r\n\r\nCC @MorrisJobke "}}