{"action":"created","issue":{"url":"https://api.github.com/repos/astropy/astropy/issues/4920","repository_url":"https://api.github.com/repos/astropy/astropy","labels_url":"https://api.github.com/repos/astropy/astropy/issues/4920/labels{/name}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/4920/comments","events_url":"https://api.github.com/repos/astropy/astropy/issues/4920/events","html_url":"https://github.com/astropy/astropy/pull/4920","id":154921884,"number":4920,"title":"Solar system plan94","user":{"login":"mhvk","id":2789820,"avatar_url":"https://avatars.githubusercontent.com/u/2789820?v=3","gravatar_id":"","url":"https://api.github.com/users/mhvk","html_url":"https://github.com/mhvk","followers_url":"https://api.github.com/users/mhvk/followers","following_url":"https://api.github.com/users/mhvk/following{/other_user}","gists_url":"https://api.github.com/users/mhvk/gists{/gist_id}","starred_url":"https://api.github.com/users/mhvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhvk/subscriptions","organizations_url":"https://api.github.com/users/mhvk/orgs","repos_url":"https://api.github.com/users/mhvk/repos","events_url":"https://api.github.com/users/mhvk/events{/privacy}","received_events_url":"https://api.github.com/users/mhvk/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/astropy/astropy/labels/coordinates","name":"coordinates","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/astropy/astropy/milestones/26","html_url":"https://github.com/astropy/astropy/milestones/v1.2.0","labels_url":"https://api.github.com/repos/astropy/astropy/milestones/26/labels","id":1114049,"number":26,"title":"v1.2.0","description":"","creator":{"login":"astrofrog","id":314716,"avatar_url":"https://avatars.githubusercontent.com/u/314716?v=3","gravatar_id":"","url":"https://api.github.com/users/astrofrog","html_url":"https://github.com/astrofrog","followers_url":"https://api.github.com/users/astrofrog/followers","following_url":"https://api.github.com/users/astrofrog/following{/other_user}","gists_url":"https://api.github.com/users/astrofrog/gists{/gist_id}","starred_url":"https://api.github.com/users/astrofrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astrofrog/subscriptions","organizations_url":"https://api.github.com/users/astrofrog/orgs","repos_url":"https://api.github.com/users/astrofrog/repos","events_url":"https://api.github.com/users/astrofrog/events{/privacy}","received_events_url":"https://api.github.com/users/astrofrog/received_events","type":"User","site_admin":false},"open_issues":35,"closed_issues":171,"state":"open","created_at":"2015-05-17T16:11:47Z","updated_at":"2016-05-23T20:56:46Z","due_on":null,"closed_at":null},"comments":33,"created_at":"2016-05-15T18:15:28Z","updated_at":"2016-05-23T23:47:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/astropy/astropy/pulls/4920","html_url":"https://github.com/astropy/astropy/pull/4920","diff_url":"https://github.com/astropy/astropy/pull/4920.diff","patch_url":"https://github.com/astropy/astropy/pull/4920.patch"},"body":"This adds the option to calculate approximate planet positions using `erfa.plan94`, i.e., without downloading a (huge) ephemeris file.\r\n\r\nIdeally, this gets merged for 1.2.0 since it changes the API for `get_body`.\r\n\r\n@eteq, @StuartLittlefair - comments?"},"comment":{"url":"https://api.github.com/repos/astropy/astropy/issues/comments/221128467","html_url":"https://github.com/astropy/astropy/pull/4920#issuecomment-221128467","issue_url":"https://api.github.com/repos/astropy/astropy/issues/4920","id":221128467,"user":{"login":"eteq","id":346587,"avatar_url":"https://avatars.githubusercontent.com/u/346587?v=3","gravatar_id":"","url":"https://api.github.com/users/eteq","html_url":"https://github.com/eteq","followers_url":"https://api.github.com/users/eteq/followers","following_url":"https://api.github.com/users/eteq/following{/other_user}","gists_url":"https://api.github.com/users/eteq/gists{/gist_id}","starred_url":"https://api.github.com/users/eteq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eteq/subscriptions","organizations_url":"https://api.github.com/users/eteq/orgs","repos_url":"https://api.github.com/users/eteq/repos","events_url":"https://api.github.com/users/eteq/events{/privacy}","received_events_url":"https://api.github.com/users/eteq/received_events","type":"User","site_admin":false},"created_at":"2016-05-23T23:47:17Z","updated_at":"2016-05-23T23:47:17Z","body":"Alright, I've finished my review, @mhvk - a bunch of minor comments above (primarily documentation/wording, although a few are slightly more significant).  A few general comments:\r\n\r\n* I think it would be better to change the name from `approximate` to `erfa`.  They're all approximations at some level (i.e. de432 is more approximate than de430), it's just that the `erfa` approach is somewhat more approximate than the others.  And I think calling it `erfa` makes it clearer that the it's the *specific* set of approximations used in erfa.\r\n* I think it should be made clearer that the potentially large  download happens when the `set` is done (if it's used), rather than only at the first `get_body` (or similar).  This could go in the docs for `solar_system_ephemerides`, or maybe even in the narrative docs directly as a ``.. note::``?  But I think it should be said clearly somewhere so that no one is surprised by a huge download just from setting state.\r\n\r\nThere are a couple other things, but I'll issue a PR against your branch shortly because it seemed easier to just do them rather than explain them."}}
{"actor":{"display_login":"eteq"}}