{"action":"closed","number":1316,"pull_request":{"url":"https://api.github.com/repos/zanata/zanata-server/pulls/1316","id":88605863,"html_url":"https://github.com/zanata/zanata-server/pull/1316","diff_url":"https://github.com/zanata/zanata-server/pull/1316.diff","patch_url":"https://github.com/zanata/zanata-server/pull/1316.patch","issue_url":"https://api.github.com/repos/zanata/zanata-server/issues/1316","number":1316,"state":"closed","locked":false,"title":"Update to RichFaces 4.5.17.Final","user":{"login":"seanf","id":54155,"avatar_url":"https://avatars.githubusercontent.com/u/54155?v=3","gravatar_id":"","url":"https://api.github.com/users/seanf","html_url":"https://github.com/seanf","followers_url":"https://api.github.com/users/seanf/followers","following_url":"https://api.github.com/users/seanf/following{/other_user}","gists_url":"https://api.github.com/users/seanf/gists{/gist_id}","starred_url":"https://api.github.com/users/seanf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanf/subscriptions","organizations_url":"https://api.github.com/users/seanf/orgs","repos_url":"https://api.github.com/users/seanf/repos","events_url":"https://api.github.com/users/seanf/events{/privacy}","received_events_url":"https://api.github.com/users/seanf/received_events","type":"User","site_admin":false},"body":"JIRA issue URL: *[paste URL here]*\r\n\r\n*[Add a short description of what is changed here.]*\r\n\r\n\r\n## Reviewer tasks\r\n\r\nThe following is based on the\r\n[Zanata Development Guidelines](https://github.com/zanata/zanata-server/wiki/Development-Guidelines).\r\nAs a reviewer, you should check the guidelines regularly for updates, and just\r\nto refresh your memory.\r\n\r\n\r\nThe reviewer can use this list for reference to make sure\r\nthey have considered all the important points.\r\n\r\nUse the checkboxes or not, whatever works best for you.\r\n\r\n - Code quality\r\n   - [ ] Code passes style check (checkstyle/eslint)\r\n   - [ ] Code is clear and concise\r\n   - [ ] UI code is internationalised\r\n   - [ ] Code has adequate comments where appropriate\r\n   - Code is in an appropriate place\r\n     - [ ] Classes are in appropriate packages\r\n     - [ ] Code fits with class's responsibilities (SRP)\r\n   - [ ] Configuration files are documented enough\r\n   - If code is removed\r\n     - [ ] No remaining code references the removed code\r\n       - [ ] No orphaned rewrite rules\r\n       - [ ] No orphaned config settings\r\n     - [ ] No remaining comments refer to the removed code\r\n     - [ ] Unused imports and libraries are removed\r\n - Testing\r\n   - [ ] New code has tests\r\n   - [ ] Changed code has tests\r\n   - [ ] All tests pass\r\n   - [ ] Test coverage stable or increased\r\n - Documentation\r\n   - [ ] New features are documented\r\n   - [ ] Docs removed for deleted features\r\n   - [ ] Docs updated for all changed features\r\n   - [ ] Developer/sysadmin docs updated if appropriate\r\n - If there are new dependencies\r\n   - [ ] Does each new dependency pass all the\r\n         [Considerations for new dependencies](https://github.com/zanata/zanata-server/wiki/Development-Guidelines#new-technologies-and-dependencies)?\r\n\r\n\r\n----\r\n*This template can be updated in .github/PULL_REQUEST_TEMPLATE.md*\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/zanata/zanata-server/1316)\n<!-- Reviewable:end -->\n","created_at":"2016-10-10T03:04:50Z","updated_at":"2016-10-11T02:52:40Z","closed_at":"2016-10-11T02:52:40Z","merged_at":"2016-10-11T02:52:40Z","merge_commit_sha":"5b492a28dcafc4522a34e46046b675d418494689","assignee":{"login":"djansen-redhat","id":4597195,"avatar_url":"https://avatars.githubusercontent.com/u/4597195?v=3","gravatar_id":"","url":"https://api.github.com/users/djansen-redhat","html_url":"https://github.com/djansen-redhat","followers_url":"https://api.github.com/users/djansen-redhat/followers","following_url":"https://api.github.com/users/djansen-redhat/following{/other_user}","gists_url":"https://api.github.com/users/djansen-redhat/gists{/gist_id}","starred_url":"https://api.github.com/users/djansen-redhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djansen-redhat/subscriptions","organizations_url":"https://api.github.com/users/djansen-redhat/orgs","repos_url":"https://api.github.com/users/djansen-redhat/repos","events_url":"https://api.github.com/users/djansen-redhat/events{/privacy}","received_events_url":"https://api.github.com/users/djansen-redhat/received_events","type":"User","site_admin":false},"assignees":[{"login":"djansen-redhat","id":4597195,"avatar_url":"https://avatars.githubusercontent.com/u/4597195?v=3","gravatar_id":"","url":"https://api.github.com/users/djansen-redhat","html_url":"https://github.com/djansen-redhat","followers_url":"https://api.github.com/users/djansen-redhat/followers","following_url":"https://api.github.com/users/djansen-redhat/following{/other_user}","gists_url":"https://api.github.com/users/djansen-redhat/gists{/gist_id}","starred_url":"https://api.github.com/users/djansen-redhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djansen-redhat/subscriptions","organizations_url":"https://api.github.com/users/djansen-redhat/orgs","repos_url":"https://api.github.com/users/djansen-redhat/repos","events_url":"https://api.github.com/users/djansen-redhat/events{/privacy}","received_events_url":"https://api.github.com/users/djansen-redhat/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/zanata/zanata-server/pulls/1316/commits","review_comments_url":"https://api.github.com/repos/zanata/zanata-server/pulls/1316/comments","review_comment_url":"https://api.github.com/repos/zanata/zanata-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zanata/zanata-server/issues/1316/comments","statuses_url":"https://api.github.com/repos/zanata/zanata-server/statuses/1dc75ecde916dffe128714695da33f2e0b92ca9d","head":{"label":"zanata:richfaces-4.5.17","ref":"richfaces-4.5.17","sha":"1dc75ecde916dffe128714695da33f2e0b92ca9d","user":{"login":"zanata","id":637455,"avatar_url":"https://avatars.githubusercontent.com/u/637455?v=3","gravatar_id":"","url":"https://api.github.com/users/zanata","html_url":"https://github.com/zanata","followers_url":"https://api.github.com/users/zanata/followers","following_url":"https://api.github.com/users/zanata/following{/other_user}","gists_url":"https://api.github.com/users/zanata/gists{/gist_id}","starred_url":"https://api.github.com/users/zanata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanata/subscriptions","organizations_url":"https://api.github.com/users/zanata/orgs","repos_url":"https://api.github.com/users/zanata/repos","events_url":"https://api.github.com/users/zanata/events{/privacy}","received_events_url":"https://api.github.com/users/zanata/received_events","type":"Organization","site_admin":false},"repo":{"id":1461609,"name":"zanata-server","full_name":"zanata/zanata-server","owner":{"login":"zanata","id":637455,"avatar_url":"https://avatars.githubusercontent.com/u/637455?v=3","gravatar_id":"","url":"https://api.github.com/users/zanata","html_url":"https://github.com/zanata","followers_url":"https://api.github.com/users/zanata/followers","following_url":"https://api.github.com/users/zanata/following{/other_user}","gists_url":"https://api.github.com/users/zanata/gists{/gist_id}","starred_url":"https://api.github.com/users/zanata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanata/subscriptions","organizations_url":"https://api.github.com/users/zanata/orgs","repos_url":"https://api.github.com/users/zanata/repos","events_url":"https://api.github.com/users/zanata/events{/privacy}","received_events_url":"https://api.github.com/users/zanata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zanata/zanata-server","description":"Zanata is a web-based system for translators to translate documentation and software online using a web browser.","fork":false,"url":"https://api.github.com/repos/zanata/zanata-server","forks_url":"https://api.github.com/repos/zanata/zanata-server/forks","keys_url":"https://api.github.com/repos/zanata/zanata-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zanata/zanata-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zanata/zanata-server/teams","hooks_url":"https://api.github.com/repos/zanata/zanata-server/hooks","issue_events_url":"https://api.github.com/repos/zanata/zanata-server/issues/events{/number}","events_url":"https://api.github.com/repos/zanata/zanata-server/events","assignees_url":"https://api.github.com/repos/zanata/zanata-server/assignees{/user}","branches_url":"https://api.github.com/repos/zanata/zanata-server/branches{/branch}","tags_url":"https://api.github.com/repos/zanata/zanata-server/tags","blobs_url":"https://api.github.com/repos/zanata/zanata-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zanata/zanata-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zanata/zanata-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/zanata/zanata-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zanata/zanata-server/statuses/{sha}","languages_url":"https://api.github.com/repos/zanata/zanata-server/languages","stargazers_url":"https://api.github.com/repos/zanata/zanata-server/stargazers","contributors_url":"https://api.github.com/repos/zanata/zanata-server/contributors","subscribers_url":"https://api.github.com/repos/zanata/zanata-server/subscribers","subscription_url":"https://api.github.com/repos/zanata/zanata-server/subscription","commits_url":"https://api.github.com/repos/zanata/zanata-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/zanata/zanata-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/zanata/zanata-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/zanata/zanata-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/zanata/zanata-server/contents/{+path}","compare_url":"https://api.github.com/repos/zanata/zanata-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zanata/zanata-server/merges","archive_url":"https://api.github.com/repos/zanata/zanata-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zanata/zanata-server/downloads","issues_url":"https://api.github.com/repos/zanata/zanata-server/issues{/number}","pulls_url":"https://api.github.com/repos/zanata/zanata-server/pulls{/number}","milestones_url":"https://api.github.com/repos/zanata/zanata-server/milestones{/number}","notifications_url":"https://api.github.com/repos/zanata/zanata-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zanata/zanata-server/labels{/name}","releases_url":"https://api.github.com/repos/zanata/zanata-server/releases{/id}","deployments_url":"https://api.github.com/repos/zanata/zanata-server/deployments","created_at":"2011-03-10T00:24:47Z","updated_at":"2016-10-10T13:56:48Z","pushed_at":"2016-10-11T02:52:41Z","git_url":"git://github.com/zanata/zanata-server.git","ssh_url":"git@github.com:zanata/zanata-server.git","clone_url":"https://github.com/zanata/zanata-server.git","svn_url":"https://github.com/zanata/zanata-server","homepage":"http://zanata.org","size":216824,"stargazers_count":198,"watchers_count":198,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":18,"forks":55,"open_issues":18,"watchers":198,"default_branch":"master"}},"base":{"label":"zanata:master","ref":"master","sha":"2713672f1be0909567c181de2fce258fb14f2608","user":{"login":"zanata","id":637455,"avatar_url":"https://avatars.githubusercontent.com/u/637455?v=3","gravatar_id":"","url":"https://api.github.com/users/zanata","html_url":"https://github.com/zanata","followers_url":"https://api.github.com/users/zanata/followers","following_url":"https://api.github.com/users/zanata/following{/other_user}","gists_url":"https://api.github.com/users/zanata/gists{/gist_id}","starred_url":"https://api.github.com/users/zanata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanata/subscriptions","organizations_url":"https://api.github.com/users/zanata/orgs","repos_url":"https://api.github.com/users/zanata/repos","events_url":"https://api.github.com/users/zanata/events{/privacy}","received_events_url":"https://api.github.com/users/zanata/received_events","type":"Organization","site_admin":false},"repo":{"id":1461609,"name":"zanata-server","full_name":"zanata/zanata-server","owner":{"login":"zanata","id":637455,"avatar_url":"https://avatars.githubusercontent.com/u/637455?v=3","gravatar_id":"","url":"https://api.github.com/users/zanata","html_url":"https://github.com/zanata","followers_url":"https://api.github.com/users/zanata/followers","following_url":"https://api.github.com/users/zanata/following{/other_user}","gists_url":"https://api.github.com/users/zanata/gists{/gist_id}","starred_url":"https://api.github.com/users/zanata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanata/subscriptions","organizations_url":"https://api.github.com/users/zanata/orgs","repos_url":"https://api.github.com/users/zanata/repos","events_url":"https://api.github.com/users/zanata/events{/privacy}","received_events_url":"https://api.github.com/users/zanata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zanata/zanata-server","description":"Zanata is a web-based system for translators to translate documentation and software online using a web browser.","fork":false,"url":"https://api.github.com/repos/zanata/zanata-server","forks_url":"https://api.github.com/repos/zanata/zanata-server/forks","keys_url":"https://api.github.com/repos/zanata/zanata-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zanata/zanata-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zanata/zanata-server/teams","hooks_url":"https://api.github.com/repos/zanata/zanata-server/hooks","issue_events_url":"https://api.github.com/repos/zanata/zanata-server/issues/events{/number}","events_url":"https://api.github.com/repos/zanata/zanata-server/events","assignees_url":"https://api.github.com/repos/zanata/zanata-server/assignees{/user}","branches_url":"https://api.github.com/repos/zanata/zanata-server/branches{/branch}","tags_url":"https://api.github.com/repos/zanata/zanata-server/tags","blobs_url":"https://api.github.com/repos/zanata/zanata-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zanata/zanata-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zanata/zanata-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/zanata/zanata-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zanata/zanata-server/statuses/{sha}","languages_url":"https://api.github.com/repos/zanata/zanata-server/languages","stargazers_url":"https://api.github.com/repos/zanata/zanata-server/stargazers","contributors_url":"https://api.github.com/repos/zanata/zanata-server/contributors","subscribers_url":"https://api.github.com/repos/zanata/zanata-server/subscribers","subscription_url":"https://api.github.com/repos/zanata/zanata-server/subscription","commits_url":"https://api.github.com/repos/zanata/zanata-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/zanata/zanata-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/zanata/zanata-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/zanata/zanata-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/zanata/zanata-server/contents/{+path}","compare_url":"https://api.github.com/repos/zanata/zanata-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zanata/zanata-server/merges","archive_url":"https://api.github.com/repos/zanata/zanata-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zanata/zanata-server/downloads","issues_url":"https://api.github.com/repos/zanata/zanata-server/issues{/number}","pulls_url":"https://api.github.com/repos/zanata/zanata-server/pulls{/number}","milestones_url":"https://api.github.com/repos/zanata/zanata-server/milestones{/number}","notifications_url":"https://api.github.com/repos/zanata/zanata-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zanata/zanata-server/labels{/name}","releases_url":"https://api.github.com/repos/zanata/zanata-server/releases{/id}","deployments_url":"https://api.github.com/repos/zanata/zanata-server/deployments","created_at":"2011-03-10T00:24:47Z","updated_at":"2016-10-10T13:56:48Z","pushed_at":"2016-10-11T02:52:41Z","git_url":"git://github.com/zanata/zanata-server.git","ssh_url":"git@github.com:zanata/zanata-server.git","clone_url":"https://github.com/zanata/zanata-server.git","svn_url":"https://github.com/zanata/zanata-server","homepage":"http://zanata.org","size":216824,"stargazers_count":198,"watchers_count":198,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":18,"forks":55,"open_issues":18,"watchers":198,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zanata/zanata-server/pulls/1316"},"html":{"href":"https://github.com/zanata/zanata-server/pull/1316"},"issue":{"href":"https://api.github.com/repos/zanata/zanata-server/issues/1316"},"comments":{"href":"https://api.github.com/repos/zanata/zanata-server/issues/1316/comments"},"review_comments":{"href":"https://api.github.com/repos/zanata/zanata-server/pulls/1316/comments"},"review_comment":{"href":"https://api.github.com/repos/zanata/zanata-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zanata/zanata-server/pulls/1316/commits"},"statuses":{"href":"https://api.github.com/repos/zanata/zanata-server/statuses/1dc75ecde916dffe128714695da33f2e0b92ca9d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"seanf","id":54155,"avatar_url":"https://avatars.githubusercontent.com/u/54155?v=3","gravatar_id":"","url":"https://api.github.com/users/seanf","html_url":"https://github.com/seanf","followers_url":"https://api.github.com/users/seanf/followers","following_url":"https://api.github.com/users/seanf/following{/other_user}","gists_url":"https://api.github.com/users/seanf/gists{/gist_id}","starred_url":"https://api.github.com/users/seanf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanf/subscriptions","organizations_url":"https://api.github.com/users/seanf/orgs","repos_url":"https://api.github.com/users/seanf/repos","events_url":"https://api.github.com/users/seanf/events{/privacy}","received_events_url":"https://api.github.com/users/seanf/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"seanf"}}