{"action":"opened","number":2097,"pull_request":{"url":"https://api.github.com/repos/philc/vimium/pulls/2097","id":66454101,"html_url":"https://github.com/philc/vimium/pull/2097","diff_url":"https://github.com/philc/vimium/pull/2097.diff","patch_url":"https://github.com/philc/vimium/pull/2097.patch","issue_url":"https://api.github.com/repos/philc/vimium/issues/2097","number":2097,"state":"open","locked":false,"title":"Rework UI component init sequence.","user":{"login":"smblott-github","id":2641335,"avatar_url":"https://avatars.githubusercontent.com/u/2641335?v=3","gravatar_id":"","url":"https://api.github.com/users/smblott-github","html_url":"https://github.com/smblott-github","followers_url":"https://api.github.com/users/smblott-github/followers","following_url":"https://api.github.com/users/smblott-github/following{/other_user}","gists_url":"https://api.github.com/users/smblott-github/gists{/gist_id}","starred_url":"https://api.github.com/users/smblott-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smblott-github/subscriptions","organizations_url":"https://api.github.com/users/smblott-github/orgs","repos_url":"https://api.github.com/users/smblott-github/repos","events_url":"https://api.github.com/users/smblott-github/events{/privacy}","received_events_url":"https://api.github.com/users/smblott-github/received_events","type":"User","site_admin":false},"body":"In testing global link hints, it seems that UI components can be opened before they're actually ready, and Vimium hangs with a broken UI component displayed.  This issue seems to be in 1.54 too.\r\n\r\nIt's not clear what's causing this -- and it's hard to reproduce systematically.  However, it only seems to happen on navigation.  Therefore, it seems likely that there is an issue with the initialization sequence.\r\n\r\nHere, we wait for:\r\n\r\n- the DOM content to be ready, and\r\n- the port to be provided\r\n\r\nbefore registering the UI component as ready.\r\n\r\n(Will merge pretty much directly.  Posting as a PR because this issue needs a little visibility... And it may not yet be fully resolved.)","created_at":"2016-04-14T09:31:39Z","updated_at":"2016-04-14T09:31:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/philc/vimium/pulls/2097/commits","review_comments_url":"https://api.github.com/repos/philc/vimium/pulls/2097/comments","review_comment_url":"https://api.github.com/repos/philc/vimium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/philc/vimium/issues/2097/comments","statuses_url":"https://api.github.com/repos/philc/vimium/statuses/39115e921af964a73d49da3085319fc1160009d2","head":{"label":"smblott-github:ui-component-init-sequence","ref":"ui-component-init-sequence","sha":"39115e921af964a73d49da3085319fc1160009d2","user":{"login":"smblott-github","id":2641335,"avatar_url":"https://avatars.githubusercontent.com/u/2641335?v=3","gravatar_id":"","url":"https://api.github.com/users/smblott-github","html_url":"https://github.com/smblott-github","followers_url":"https://api.github.com/users/smblott-github/followers","following_url":"https://api.github.com/users/smblott-github/following{/other_user}","gists_url":"https://api.github.com/users/smblott-github/gists{/gist_id}","starred_url":"https://api.github.com/users/smblott-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smblott-github/subscriptions","organizations_url":"https://api.github.com/users/smblott-github/orgs","repos_url":"https://api.github.com/users/smblott-github/repos","events_url":"https://api.github.com/users/smblott-github/events{/privacy}","received_events_url":"https://api.github.com/users/smblott-github/received_events","type":"User","site_admin":false},"repo":{"id":18924701,"name":"vimium","full_name":"smblott-github/vimium","owner":{"login":"smblott-github","id":2641335,"avatar_url":"https://avatars.githubusercontent.com/u/2641335?v=3","gravatar_id":"","url":"https://api.github.com/users/smblott-github","html_url":"https://github.com/smblott-github","followers_url":"https://api.github.com/users/smblott-github/followers","following_url":"https://api.github.com/users/smblott-github/following{/other_user}","gists_url":"https://api.github.com/users/smblott-github/gists{/gist_id}","starred_url":"https://api.github.com/users/smblott-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smblott-github/subscriptions","organizations_url":"https://api.github.com/users/smblott-github/orgs","repos_url":"https://api.github.com/users/smblott-github/repos","events_url":"https://api.github.com/users/smblott-github/events{/privacy}","received_events_url":"https://api.github.com/users/smblott-github/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smblott-github/vimium","description":"The hacker's browser.","fork":true,"url":"https://api.github.com/repos/smblott-github/vimium","forks_url":"https://api.github.com/repos/smblott-github/vimium/forks","keys_url":"https://api.github.com/repos/smblott-github/vimium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smblott-github/vimium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smblott-github/vimium/teams","hooks_url":"https://api.github.com/repos/smblott-github/vimium/hooks","issue_events_url":"https://api.github.com/repos/smblott-github/vimium/issues/events{/number}","events_url":"https://api.github.com/repos/smblott-github/vimium/events","assignees_url":"https://api.github.com/repos/smblott-github/vimium/assignees{/user}","branches_url":"https://api.github.com/repos/smblott-github/vimium/branches{/branch}","tags_url":"https://api.github.com/repos/smblott-github/vimium/tags","blobs_url":"https://api.github.com/repos/smblott-github/vimium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smblott-github/vimium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smblott-github/vimium/git/refs{/sha}","trees_url":"https://api.github.com/repos/smblott-github/vimium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smblott-github/vimium/statuses/{sha}","languages_url":"https://api.github.com/repos/smblott-github/vimium/languages","stargazers_url":"https://api.github.com/repos/smblott-github/vimium/stargazers","contributors_url":"https://api.github.com/repos/smblott-github/vimium/contributors","subscribers_url":"https://api.github.com/repos/smblott-github/vimium/subscribers","subscription_url":"https://api.github.com/repos/smblott-github/vimium/subscription","commits_url":"https://api.github.com/repos/smblott-github/vimium/commits{/sha}","git_commits_url":"https://api.github.com/repos/smblott-github/vimium/git/commits{/sha}","comments_url":"https://api.github.com/repos/smblott-github/vimium/comments{/number}","issue_comment_url":"https://api.github.com/repos/smblott-github/vimium/issues/comments{/number}","contents_url":"https://api.github.com/repos/smblott-github/vimium/contents/{+path}","compare_url":"https://api.github.com/repos/smblott-github/vimium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smblott-github/vimium/merges","archive_url":"https://api.github.com/repos/smblott-github/vimium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smblott-github/vimium/downloads","issues_url":"https://api.github.com/repos/smblott-github/vimium/issues{/number}","pulls_url":"https://api.github.com/repos/smblott-github/vimium/pulls{/number}","milestones_url":"https://api.github.com/repos/smblott-github/vimium/milestones{/number}","notifications_url":"https://api.github.com/repos/smblott-github/vimium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smblott-github/vimium/labels{/name}","releases_url":"https://api.github.com/repos/smblott-github/vimium/releases{/id}","deployments_url":"https://api.github.com/repos/smblott-github/vimium/deployments","created_at":"2014-04-18T20:29:25Z","updated_at":"2016-01-13T13:08:36Z","pushed_at":"2016-04-14T07:37:02Z","git_url":"git://github.com/smblott-github/vimium.git","ssh_url":"git@github.com:smblott-github/vimium.git","clone_url":"https://github.com/smblott-github/vimium.git","svn_url":"https://github.com/smblott-github/vimium","homepage":"","size":5370,"stargazers_count":1,"watchers_count":1,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"philc:master","ref":"master","sha":"f144c7c9d3f141636ce6a3856db3abf08a4fc063","user":{"login":"philc","id":8598,"avatar_url":"https://avatars.githubusercontent.com/u/8598?v=3","gravatar_id":"","url":"https://api.github.com/users/philc","html_url":"https://github.com/philc","followers_url":"https://api.github.com/users/philc/followers","following_url":"https://api.github.com/users/philc/following{/other_user}","gists_url":"https://api.github.com/users/philc/gists{/gist_id}","starred_url":"https://api.github.com/users/philc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philc/subscriptions","organizations_url":"https://api.github.com/users/philc/orgs","repos_url":"https://api.github.com/users/philc/repos","events_url":"https://api.github.com/users/philc/events{/privacy}","received_events_url":"https://api.github.com/users/philc/received_events","type":"User","site_admin":false},"repo":{"id":312262,"name":"vimium","full_name":"philc/vimium","owner":{"login":"philc","id":8598,"avatar_url":"https://avatars.githubusercontent.com/u/8598?v=3","gravatar_id":"","url":"https://api.github.com/users/philc","html_url":"https://github.com/philc","followers_url":"https://api.github.com/users/philc/followers","following_url":"https://api.github.com/users/philc/following{/other_user}","gists_url":"https://api.github.com/users/philc/gists{/gist_id}","starred_url":"https://api.github.com/users/philc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philc/subscriptions","organizations_url":"https://api.github.com/users/philc/orgs","repos_url":"https://api.github.com/users/philc/repos","events_url":"https://api.github.com/users/philc/events{/privacy}","received_events_url":"https://api.github.com/users/philc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/philc/vimium","description":"The hacker's browser.","fork":false,"url":"https://api.github.com/repos/philc/vimium","forks_url":"https://api.github.com/repos/philc/vimium/forks","keys_url":"https://api.github.com/repos/philc/vimium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/philc/vimium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/philc/vimium/teams","hooks_url":"https://api.github.com/repos/philc/vimium/hooks","issue_events_url":"https://api.github.com/repos/philc/vimium/issues/events{/number}","events_url":"https://api.github.com/repos/philc/vimium/events","assignees_url":"https://api.github.com/repos/philc/vimium/assignees{/user}","branches_url":"https://api.github.com/repos/philc/vimium/branches{/branch}","tags_url":"https://api.github.com/repos/philc/vimium/tags","blobs_url":"https://api.github.com/repos/philc/vimium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/philc/vimium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/philc/vimium/git/refs{/sha}","trees_url":"https://api.github.com/repos/philc/vimium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/philc/vimium/statuses/{sha}","languages_url":"https://api.github.com/repos/philc/vimium/languages","stargazers_url":"https://api.github.com/repos/philc/vimium/stargazers","contributors_url":"https://api.github.com/repos/philc/vimium/contributors","subscribers_url":"https://api.github.com/repos/philc/vimium/subscribers","subscription_url":"https://api.github.com/repos/philc/vimium/subscription","commits_url":"https://api.github.com/repos/philc/vimium/commits{/sha}","git_commits_url":"https://api.github.com/repos/philc/vimium/git/commits{/sha}","comments_url":"https://api.github.com/repos/philc/vimium/comments{/number}","issue_comment_url":"https://api.github.com/repos/philc/vimium/issues/comments{/number}","contents_url":"https://api.github.com/repos/philc/vimium/contents/{+path}","compare_url":"https://api.github.com/repos/philc/vimium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/philc/vimium/merges","archive_url":"https://api.github.com/repos/philc/vimium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/philc/vimium/downloads","issues_url":"https://api.github.com/repos/philc/vimium/issues{/number}","pulls_url":"https://api.github.com/repos/philc/vimium/pulls{/number}","milestones_url":"https://api.github.com/repos/philc/vimium/milestones{/number}","notifications_url":"https://api.github.com/repos/philc/vimium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/philc/vimium/labels{/name}","releases_url":"https://api.github.com/repos/philc/vimium/releases{/id}","deployments_url":"https://api.github.com/repos/philc/vimium/deployments","created_at":"2009-09-20T07:08:19Z","updated_at":"2016-04-13T21:37:01Z","pushed_at":"2016-04-13T19:48:32Z","git_url":"git://github.com/philc/vimium.git","ssh_url":"git@github.com:philc/vimium.git","clone_url":"https://github.com/philc/vimium.git","svn_url":"https://github.com/philc/vimium","homepage":"","size":7755,"stargazers_count":4570,"watchers_count":4570,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":657,"mirror_url":null,"open_issues_count":76,"forks":657,"open_issues":76,"watchers":4570,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/philc/vimium/pulls/2097"},"html":{"href":"https://github.com/philc/vimium/pull/2097"},"issue":{"href":"https://api.github.com/repos/philc/vimium/issues/2097"},"comments":{"href":"https://api.github.com/repos/philc/vimium/issues/2097/comments"},"review_comments":{"href":"https://api.github.com/repos/philc/vimium/pulls/2097/comments"},"review_comment":{"href":"https://api.github.com/repos/philc/vimium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/philc/vimium/pulls/2097/commits"},"statuses":{"href":"https://api.github.com/repos/philc/vimium/statuses/39115e921af964a73d49da3085319fc1160009d2"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":20,"deletions":8,"changed_files":2}}