{"action":"created","issue":{"url":"https://api.github.com/repos/conveyal/gridualizer/issues/5","repository_url":"https://api.github.com/repos/conveyal/gridualizer","labels_url":"https://api.github.com/repos/conveyal/gridualizer/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/conveyal/gridualizer/issues/5/comments","events_url":"https://api.github.com/repos/conveyal/gridualizer/issues/5/events","html_url":"https://github.com/conveyal/gridualizer/pull/5","id":193973556,"number":5,"title":"feat(leaflet): Remove internal leaflet and react-leaflet usage.","user":{"login":"trevorgerhardt","id":776780,"avatar_url":"https://avatars.githubusercontent.com/u/776780?v=3","gravatar_id":"","url":"https://api.github.com/users/trevorgerhardt","html_url":"https://github.com/trevorgerhardt","followers_url":"https://api.github.com/users/trevorgerhardt/followers","following_url":"https://api.github.com/users/trevorgerhardt/following{/other_user}","gists_url":"https://api.github.com/users/trevorgerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/trevorgerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevorgerhardt/subscriptions","organizations_url":"https://api.github.com/users/trevorgerhardt/orgs","repos_url":"https://api.github.com/users/trevorgerhardt/repos","events_url":"https://api.github.com/users/trevorgerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/trevorgerhardt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-12-07T07:05:34Z","updated_at":"2016-12-12T15:26:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/conveyal/gridualizer/pulls/5","html_url":"https://github.com/conveyal/gridualizer/pull/5","diff_url":"https://github.com/conveyal/gridualizer/pull/5.diff","patch_url":"https://github.com/conveyal/gridualizer/pull/5.patch"},"body":"The motivation for this is to allow supporting leaflet 0.x and 1.x at the same time. It also became apparent that it was trivial to create a Leaflet GridLayer to display any of the visualizations so it removes the custom react-leaflet layers from the library also. (see [example.js](https://github.com/conveyal/gridualizer/blob/remove-leaflet-dependency/example.js#L20)) This also separates the Choropleth break functions into their own files.\r\n\r\nBREAKING CHANGE: No longer extends leaflet layers or react-leaflet layers. Must be done manually."},"comment":{"url":"https://api.github.com/repos/conveyal/gridualizer/issues/comments/266459544","html_url":"https://github.com/conveyal/gridualizer/pull/5#issuecomment-266459544","issue_url":"https://api.github.com/repos/conveyal/gridualizer/issues/5","id":266459544,"user":{"login":"mattwigway","id":566958,"avatar_url":"https://avatars.githubusercontent.com/u/566958?v=3","gravatar_id":"","url":"https://api.github.com/users/mattwigway","html_url":"https://github.com/mattwigway","followers_url":"https://api.github.com/users/mattwigway/followers","following_url":"https://api.github.com/users/mattwigway/following{/other_user}","gists_url":"https://api.github.com/users/mattwigway/gists{/gist_id}","starred_url":"https://api.github.com/users/mattwigway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattwigway/subscriptions","organizations_url":"https://api.github.com/users/mattwigway/orgs","repos_url":"https://api.github.com/users/mattwigway/repos","events_url":"https://api.github.com/users/mattwigway/events{/privacy}","received_events_url":"https://api.github.com/users/mattwigway/received_events","type":"User","site_admin":false},"created_at":"2016-12-12T15:26:46Z","updated_at":"2016-12-12T15:26:46Z","body":"Sure, but what about when we want the same logic in, say, TAUI?\n\nOn Mon, Dec 12, 2016 at 10:19 AM, Trevor Gerhardt <notifications@github.com>\nwrote:\n\n> Yup, and that's part of my point. The react specific implementation with\n> lengthy react specific logic should live within the application it's being\n> used. We won't \"lose\" the layers, just move that logic directly into SE.\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/conveyal/gridualizer/pull/5#issuecomment-266457465>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AAimrtJCjbHv9mbvaqwuHSCC_buYZ0QIks5rHWX4gaJpZM4LGQ3P>\n> .\n>\n\n\n\n-- \nMatthew Wigginton Conway [WIG-in-tun CON-way]\nTransportation Analytics/Open Source\nWashington, DC\n"}}
{"actor":{"display_login":"mattwigway"}}