{"action":"created","issue":{"url":"https://api.github.com/repos/angular/protractor/issues/3577","repository_url":"https://api.github.com/repos/angular/protractor","labels_url":"https://api.github.com/repos/angular/protractor/issues/3577/labels{/name}","comments_url":"https://api.github.com/repos/angular/protractor/issues/3577/comments","events_url":"https://api.github.com/repos/angular/protractor/issues/3577/events","html_url":"https://github.com/angular/protractor/pull/3577","id":177988797,"number":3577,"title":"[testapp] ng1 Added iframe and windows to the testapp","user":{"login":"manoj9788","id":1823178,"avatar_url":"https://avatars.githubusercontent.com/u/1823178?v=3","gravatar_id":"","url":"https://api.github.com/users/manoj9788","html_url":"https://github.com/manoj9788","followers_url":"https://api.github.com/users/manoj9788/followers","following_url":"https://api.github.com/users/manoj9788/following{/other_user}","gists_url":"https://api.github.com/users/manoj9788/gists{/gist_id}","starred_url":"https://api.github.com/users/manoj9788/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manoj9788/subscriptions","organizations_url":"https://api.github.com/users/manoj9788/orgs","repos_url":"https://api.github.com/users/manoj9788/repos","events_url":"https://api.github.com/users/manoj9788/events{/privacy}","received_events_url":"https://api.github.com/users/manoj9788/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular/protractor/labels/cla:%20yes","name":"cla: yes","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-09-20T07:46:27Z","updated_at":"2016-09-20T17:02:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/angular/protractor/pulls/3577","html_url":"https://github.com/angular/protractor/pull/3577","diff_url":"https://github.com/angular/protractor/pull/3577.diff","patch_url":"https://github.com/angular/protractor/pull/3577.patch"},"body":"Works as it is, simple and no fancy stuff,  Intent is that we can write tests using Protractor API for scenarios like switching into iFrames and switching into new window. Tests will be in my next PR.\r\n"},"comment":{"url":"https://api.github.com/repos/angular/protractor/issues/comments/248365109","html_url":"https://github.com/angular/protractor/pull/3577#issuecomment-248365109","issue_url":"https://api.github.com/repos/angular/protractor/issues/3577","id":248365109,"user":{"login":"juliemr","id":2081709,"avatar_url":"https://avatars.githubusercontent.com/u/2081709?v=3","gravatar_id":"","url":"https://api.github.com/users/juliemr","html_url":"https://github.com/juliemr","followers_url":"https://api.github.com/users/juliemr/followers","following_url":"https://api.github.com/users/juliemr/following{/other_user}","gists_url":"https://api.github.com/users/juliemr/gists{/gist_id}","starred_url":"https://api.github.com/users/juliemr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliemr/subscriptions","organizations_url":"https://api.github.com/users/juliemr/orgs","repos_url":"https://api.github.com/users/juliemr/repos","events_url":"https://api.github.com/users/juliemr/events{/privacy}","received_events_url":"https://api.github.com/users/juliemr/received_events","type":"User","site_admin":false},"created_at":"2016-09-20T17:02:48Z","updated_at":"2016-09-20T17:02:48Z","body":"Thanks for the contribution. I have some questions about the goal. Why do we need to write tests for iframes and windows? There is nothing special about the way that Protractor handles these cases compared to anything else build on top of webdriver, or how Angular handles them as a framework. I don't want to pollute our tests with complexity that's not related to us.\r\n\r\nIf we're adding tests here because users have to deal with iframes and windows, and need to see examples, that would be better to put in a place like https://github.com/angular/protractor-cookbook"}}
{"actor":{"display_login":"juliemr"}}