{"action":"created","comment":{"url":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/comments/88617980","pull_request_review_id":9186310,"id":88617980,"diff_hunk":"@@ -947,6 +1010,49 @@ private void filterByStatuses(String tenantId, AlertsCriteria criteria, Collecti\n         if (isEmpty(tenantId)) {\n             throw new IllegalArgumentException(\"TenantId must be not null\");\n         }\n+        List<Event> events = getEvents(tenantId, criteria);","path":"hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassAlertsServiceImpl.java","position":184,"original_position":184,"commit_id":"ecd6005ef0b0c5a62fb13a71c3e0219595f64188","original_commit_id":"ecd6005ef0b0c5a62fb13a71c3e0219595f64188","user":{"login":"lucasponce","id":1662329,"avatar_url":"https://avatars.githubusercontent.com/u/1662329?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasponce","html_url":"https://github.com/lucasponce","followers_url":"https://api.github.com/users/lucasponce/followers","following_url":"https://api.github.com/users/lucasponce/following{/other_user}","gists_url":"https://api.github.com/users/lucasponce/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasponce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasponce/subscriptions","organizations_url":"https://api.github.com/users/lucasponce/orgs","repos_url":"https://api.github.com/users/lucasponce/repos","events_url":"https://api.github.com/users/lucasponce/events{/privacy}","received_events_url":"https://api.github.com/users/lucasponce/received_events","type":"User","site_admin":false},"body":"+1","created_at":"2016-11-18T08:47:28Z","updated_at":"2016-11-18T08:47:28Z","html_url":"https://github.com/hawkular/hawkular-alerts/pull/262#discussion_r88617980","pull_request_url":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/262","_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/comments/88617980"},"html":{"href":"https://github.com/hawkular/hawkular-alerts/pull/262#discussion_r88617980"},"pull_request":{"href":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/262"}}},"pull_request":{"url":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/262","id":94178037,"html_url":"https://github.com/hawkular/hawkular-alerts/pull/262","diff_url":"https://github.com/hawkular/hawkular-alerts/pull/262.diff","patch_url":"https://github.com/hawkular/hawkular-alerts/pull/262.patch","issue_url":"https://api.github.com/repos/hawkular/hawkular-alerts/issues/262","number":262,"state":"open","locked":false,"title":"HWKALERTS-188 Add cross-tenant ops per fetching events/alerts","user":{"login":"lucasponce","id":1662329,"avatar_url":"https://avatars.githubusercontent.com/u/1662329?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasponce","html_url":"https://github.com/lucasponce","followers_url":"https://api.github.com/users/lucasponce/followers","following_url":"https://api.github.com/users/lucasponce/following{/other_user}","gists_url":"https://api.github.com/users/lucasponce/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasponce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasponce/subscriptions","organizations_url":"https://api.github.com/users/lucasponce/orgs","repos_url":"https://api.github.com/users/lucasponce/repos","events_url":"https://api.github.com/users/lucasponce/events{/privacy}","received_events_url":"https://api.github.com/users/lucasponce/received_events","type":"User","site_admin":false},"body":"- Creating new /admin endpoint for cross tenant operations\r\n- Add support for fetching alerts/events from multiple tenants\r\n- Add additional tests\r\n\r\nplease @jshaughn, could you review ?\r\n\r\nI haven't included on this one the batching optimizations.\r\n\r\nI'm performing some local testing before to send them into the code.\r\nBut this cross tenant feature is almost ready for review.","created_at":"2016-11-17T14:31:42Z","updated_at":"2016-11-18T08:47:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb4531648c579aed0a67b275d90e4af2bac72a8b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/262/commits","review_comments_url":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/262/comments","review_comment_url":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hawkular/hawkular-alerts/issues/262/comments","statuses_url":"https://api.github.com/repos/hawkular/hawkular-alerts/statuses/ecd6005ef0b0c5a62fb13a71c3e0219595f64188","head":{"label":"lucasponce:multi-tenant-fetching","ref":"multi-tenant-fetching","sha":"ecd6005ef0b0c5a62fb13a71c3e0219595f64188","user":{"login":"lucasponce","id":1662329,"avatar_url":"https://avatars.githubusercontent.com/u/1662329?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasponce","html_url":"https://github.com/lucasponce","followers_url":"https://api.github.com/users/lucasponce/followers","following_url":"https://api.github.com/users/lucasponce/following{/other_user}","gists_url":"https://api.github.com/users/lucasponce/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasponce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasponce/subscriptions","organizations_url":"https://api.github.com/users/lucasponce/orgs","repos_url":"https://api.github.com/users/lucasponce/repos","events_url":"https://api.github.com/users/lucasponce/events{/privacy}","received_events_url":"https://api.github.com/users/lucasponce/received_events","type":"User","site_admin":false},"repo":{"id":29670224,"name":"hawkular-alerts","full_name":"lucasponce/hawkular-alerts","owner":{"login":"lucasponce","id":1662329,"avatar_url":"https://avatars.githubusercontent.com/u/1662329?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasponce","html_url":"https://github.com/lucasponce","followers_url":"https://api.github.com/users/lucasponce/followers","following_url":"https://api.github.com/users/lucasponce/following{/other_user}","gists_url":"https://api.github.com/users/lucasponce/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasponce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasponce/subscriptions","organizations_url":"https://api.github.com/users/lucasponce/orgs","repos_url":"https://api.github.com/users/lucasponce/repos","events_url":"https://api.github.com/users/lucasponce/events{/privacy}","received_events_url":"https://api.github.com/users/lucasponce/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lucasponce/hawkular-alerts","description":"Alerting subsystem for Hawkular","fork":true,"url":"https://api.github.com/repos/lucasponce/hawkular-alerts","forks_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/forks","keys_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/teams","hooks_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/hooks","issue_events_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/issues/events{/number}","events_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/events","assignees_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/assignees{/user}","branches_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/branches{/branch}","tags_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/tags","blobs_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/git/refs{/sha}","trees_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/statuses/{sha}","languages_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/languages","stargazers_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/stargazers","contributors_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/contributors","subscribers_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/subscribers","subscription_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/subscription","commits_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/commits{/sha}","git_commits_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/git/commits{/sha}","comments_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/comments{/number}","issue_comment_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/issues/comments{/number}","contents_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/contents/{+path}","compare_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/merges","archive_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/downloads","issues_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/issues{/number}","pulls_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/pulls{/number}","milestones_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/milestones{/number}","notifications_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/labels{/name}","releases_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/releases{/id}","deployments_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/deployments","created_at":"2015-01-22T09:03:07Z","updated_at":"2016-01-11T08:46:24Z","pushed_at":"2016-11-17T14:30:15Z","git_url":"git://github.com/lucasponce/hawkular-alerts.git","ssh_url":"git@github.com:lucasponce/hawkular-alerts.git","clone_url":"https://github.com/lucasponce/hawkular-alerts.git","svn_url":"https://github.com/lucasponce/hawkular-alerts","homepage":null,"size":4124,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hawkular:master","ref":"master","sha":"4da35fab98941f1ca9f2ac7efd38a18d3bc1f47e","user":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"repo":{"id":29608496,"name":"hawkular-alerts","full_name":"hawkular/hawkular-alerts","owner":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hawkular/hawkular-alerts","description":"Alerting subsystem for Hawkular","fork":false,"url":"https://api.github.com/repos/hawkular/hawkular-alerts","forks_url":"https://api.github.com/repos/hawkular/hawkular-alerts/forks","keys_url":"https://api.github.com/repos/hawkular/hawkular-alerts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hawkular/hawkular-alerts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hawkular/hawkular-alerts/teams","hooks_url":"https://api.github.com/repos/hawkular/hawkular-alerts/hooks","issue_events_url":"https://api.github.com/repos/hawkular/hawkular-alerts/issues/events{/number}","events_url":"https://api.github.com/repos/hawkular/hawkular-alerts/events","assignees_url":"https://api.github.com/repos/hawkular/hawkular-alerts/assignees{/user}","branches_url":"https://api.github.com/repos/hawkular/hawkular-alerts/branches{/branch}","tags_url":"https://api.github.com/repos/hawkular/hawkular-alerts/tags","blobs_url":"https://api.github.com/repos/hawkular/hawkular-alerts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hawkular/hawkular-alerts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hawkular/hawkular-alerts/git/refs{/sha}","trees_url":"https://api.github.com/repos/hawkular/hawkular-alerts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hawkular/hawkular-alerts/statuses/{sha}","languages_url":"https://api.github.com/repos/hawkular/hawkular-alerts/languages","stargazers_url":"https://api.github.com/repos/hawkular/hawkular-alerts/stargazers","contributors_url":"https://api.github.com/repos/hawkular/hawkular-alerts/contributors","subscribers_url":"https://api.github.com/repos/hawkular/hawkular-alerts/subscribers","subscription_url":"https://api.github.com/repos/hawkular/hawkular-alerts/subscription","commits_url":"https://api.github.com/repos/hawkular/hawkular-alerts/commits{/sha}","git_commits_url":"https://api.github.com/repos/hawkular/hawkular-alerts/git/commits{/sha}","comments_url":"https://api.github.com/repos/hawkular/hawkular-alerts/comments{/number}","issue_comment_url":"https://api.github.com/repos/hawkular/hawkular-alerts/issues/comments{/number}","contents_url":"https://api.github.com/repos/hawkular/hawkular-alerts/contents/{+path}","compare_url":"https://api.github.com/repos/hawkular/hawkular-alerts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hawkular/hawkular-alerts/merges","archive_url":"https://api.github.com/repos/hawkular/hawkular-alerts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hawkular/hawkular-alerts/downloads","issues_url":"https://api.github.com/repos/hawkular/hawkular-alerts/issues{/number}","pulls_url":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls{/number}","milestones_url":"https://api.github.com/repos/hawkular/hawkular-alerts/milestones{/number}","notifications_url":"https://api.github.com/repos/hawkular/hawkular-alerts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hawkular/hawkular-alerts/labels{/name}","releases_url":"https://api.github.com/repos/hawkular/hawkular-alerts/releases{/id}","deployments_url":"https://api.github.com/repos/hawkular/hawkular-alerts/deployments","created_at":"2015-01-21T19:59:08Z","updated_at":"2016-11-16T03:50:54Z","pushed_at":"2016-11-17T14:31:43Z","git_url":"git://github.com/hawkular/hawkular-alerts.git","ssh_url":"git@github.com:hawkular/hawkular-alerts.git","clone_url":"https://github.com/hawkular/hawkular-alerts.git","svn_url":"https://github.com/hawkular/hawkular-alerts","homepage":null,"size":4321,"stargazers_count":17,"watchers_count":17,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":1,"forks":17,"open_issues":1,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/262"},"html":{"href":"https://github.com/hawkular/hawkular-alerts/pull/262"},"issue":{"href":"https://api.github.com/repos/hawkular/hawkular-alerts/issues/262"},"comments":{"href":"https://api.github.com/repos/hawkular/hawkular-alerts/issues/262/comments"},"review_comments":{"href":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/262/comments"},"review_comment":{"href":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/262/commits"},"statuses":{"href":"https://api.github.com/repos/hawkular/hawkular-alerts/statuses/ecd6005ef0b0c5a62fb13a71c3e0219595f64188"}}}}
{"actor":{"display_login":"lucasponce"}}