{"action":"created","issue":{"url":"https://api.github.com/repos/pantheon-systems/search_api_pantheon/issues/40","repository_url":"https://api.github.com/repos/pantheon-systems/search_api_pantheon","labels_url":"https://api.github.com/repos/pantheon-systems/search_api_pantheon/issues/40/labels{/name}","comments_url":"https://api.github.com/repos/pantheon-systems/search_api_pantheon/issues/40/comments","events_url":"https://api.github.com/repos/pantheon-systems/search_api_pantheon/issues/40/events","html_url":"https://github.com/pantheon-systems/search_api_pantheon/pull/40","id":180776114,"number":40,"title":"Get index host and port settings via non-platform dependent func","user":{"login":"pirog","id":713424,"avatar_url":"https://avatars.githubusercontent.com/u/713424?v=3","gravatar_id":"","url":"https://api.github.com/users/pirog","html_url":"https://github.com/pirog","followers_url":"https://api.github.com/users/pirog/followers","following_url":"https://api.github.com/users/pirog/following{/other_user}","gists_url":"https://api.github.com/users/pirog/gists{/gist_id}","starred_url":"https://api.github.com/users/pirog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pirog/subscriptions","organizations_url":"https://api.github.com/users/pirog/orgs","repos_url":"https://api.github.com/users/pirog/repos","events_url":"https://api.github.com/users/pirog/events{/privacy}","received_events_url":"https://api.github.com/users/pirog/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-03T23:55:15Z","updated_at":"2016-10-11T21:30:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pantheon-systems/search_api_pantheon/pulls/40","html_url":"https://github.com/pantheon-systems/search_api_pantheon/pull/40","diff_url":"https://github.com/pantheon-systems/search_api_pantheon/pull/40.diff","patch_url":"https://github.com/pantheon-systems/search_api_pantheon/pull/40.patch"},"body":"For a little more background on this proposed change\r\n\r\n1. I arrived here checking out an issue over on the Kalabox queue https://github.com/kalabox/kalabox/issues/1640\r\n2. Initially i figured we could implement `pantheon_variable_get` on our end as well to provide out of the box pantheon solr compatibility with D8 (like we do for D7) but after asking around in the #power-users group the (perhaps not accurate) suggestion was to actually do something like this PR which i think should work both on Pantheon and Kalabox (plus this helps ensure a user wont get a fatal error if they move off pantheon)\r\n\r\nIf anything in 2 above is not viable let me know and i'm more than happy to go ahead with a kalabox-side solution."},"comment":{"url":"https://api.github.com/repos/pantheon-systems/search_api_pantheon/issues/comments/253052716","html_url":"https://github.com/pantheon-systems/search_api_pantheon/pull/40#issuecomment-253052716","issue_url":"https://api.github.com/repos/pantheon-systems/search_api_pantheon/issues/40","id":253052716,"user":{"login":"stevector","id":211029,"avatar_url":"https://avatars.githubusercontent.com/u/211029?v=3","gravatar_id":"","url":"https://api.github.com/users/stevector","html_url":"https://github.com/stevector","followers_url":"https://api.github.com/users/stevector/followers","following_url":"https://api.github.com/users/stevector/following{/other_user}","gists_url":"https://api.github.com/users/stevector/gists{/gist_id}","starred_url":"https://api.github.com/users/stevector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevector/subscriptions","organizations_url":"https://api.github.com/users/stevector/orgs","repos_url":"https://api.github.com/users/stevector/repos","events_url":"https://api.github.com/users/stevector/events{/privacy}","received_events_url":"https://api.github.com/users/stevector/received_events","type":"User","site_admin":false},"created_at":"2016-10-11T21:30:40Z","updated_at":"2016-10-11T21:30:40Z","body":"Yeah, the fail is because PRs from forks don't get access to Circle CI variables like the machine token (if they did, a PR could use the machine token for malicious changes). I'll bring @pirog's commit over to this repo to rerun the tests."}}
{"actor":{"display_login":"stevector"}}