{"action":"created","comment":{"url":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments/90853461","pull_request_review_id":11367003,"id":90853461,"diff_hunk":"@@ -15,64 +15,76 @@\n # along with this program.  If not, see <http://www.gnu.org/licenses/>.\n \n import os\n+import fixtures\n import subprocess\n \n import integration_tests\n+import testscenarios\n from snapcraft.tests import fixture_setup\n \n \n-class TestParser(integration_tests.TestCase):\n+class ParserTestCase(integration_tests.TestCase):\n     \"\"\"Test bin/snapcraft-parser\"\"\"\n \n-    def test_parser_basic(self):\n-        \"\"\"Test snapcraft-parser basic usage\"\"\"\n-        fixture = fixture_setup.FakePartsWiki()\n-        self.useFixture(fixture)\n+    def setUp(self):\n+        super().setUp()\n \n-        args = [self.snapcraft_parser_command, '--index',\n-                fixture.fake_parts_wiki_fixture.url,\n-                '--debug', '--output', 'parts.yaml']\n-        subprocess.check_call(args, stderr=subprocess.DEVNULL,\n-                              stdout=subprocess.DEVNULL)\n+        tempdir = fixtures.TempDir()\n+        self.useFixture(tempdir)\n+        self.useFixture(fixtures.EnvironmentVariable('TMPDIR', tempdir.path))\n+        self.tempdir = tempdir.path\n \n-        self.assertTrue(os.path.exists('parts.yaml'))\n+    def call_parser(self, wiki_path, expect_valid, expect_output=True):\n+        part_file = os.path.join(self.tempdir, 'parts.yaml')\n+        args = [self.snapcraft_parser_command, '--index', wiki_path,\n+                '--debug',\n+                '--output', part_file]","path":"integration_tests/test_parser.py","position":38,"original_position":38,"commit_id":"46c01ee4c8e3027193104a45eb9682ed88ec6440","original_commit_id":"46c01ee4c8e3027193104a45eb9682ed88ec6440","user":{"login":"3v1n0","id":345675,"avatar_url":"https://avatars.githubusercontent.com/u/345675?v=3","gravatar_id":"","url":"https://api.github.com/users/3v1n0","html_url":"https://github.com/3v1n0","followers_url":"https://api.github.com/users/3v1n0/followers","following_url":"https://api.github.com/users/3v1n0/following{/other_user}","gists_url":"https://api.github.com/users/3v1n0/gists{/gist_id}","starred_url":"https://api.github.com/users/3v1n0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3v1n0/subscriptions","organizations_url":"https://api.github.com/users/3v1n0/orgs","repos_url":"https://api.github.com/users/3v1n0/repos","events_url":"https://api.github.com/users/3v1n0/events{/privacy}","received_events_url":"https://api.github.com/users/3v1n0/received_events","type":"User","site_admin":false},"body":"Thanks, merged (and rebased) that commit into mine.","created_at":"2016-12-05T12:17:07Z","updated_at":"2016-12-05T12:17:07Z","html_url":"https://github.com/snapcore/snapcraft/pull/931#discussion_r90853461","pull_request_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/931","_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments/90853461"},"html":{"href":"https://github.com/snapcore/snapcraft/pull/931#discussion_r90853461"},"pull_request":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/931"}}},"pull_request":{"url":"https://api.github.com/repos/snapcore/snapcraft/pulls/931","id":95523172,"html_url":"https://github.com/snapcore/snapcraft/pull/931","diff_url":"https://github.com/snapcore/snapcraft/pull/931.diff","patch_url":"https://github.com/snapcore/snapcraft/pull/931.patch","issue_url":"https://api.github.com/repos/snapcore/snapcraft/issues/931","number":931,"state":"open","locked":false,"title":"parser: add support for origin-{branch,commit,tag}","user":{"login":"3v1n0","id":345675,"avatar_url":"https://avatars.githubusercontent.com/u/345675?v=3","gravatar_id":"","url":"https://api.github.com/users/3v1n0","html_url":"https://github.com/3v1n0","followers_url":"https://api.github.com/users/3v1n0/followers","following_url":"https://api.github.com/users/3v1n0/following{/other_user}","gists_url":"https://api.github.com/users/3v1n0/gists{/gist_id}","starred_url":"https://api.github.com/users/3v1n0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3v1n0/subscriptions","organizations_url":"https://api.github.com/users/3v1n0/orgs","repos_url":"https://api.github.com/users/3v1n0/repos","events_url":"https://api.github.com/users/3v1n0/events{/privacy}","received_events_url":"https://api.github.com/users/3v1n0/received_events","type":"User","site_admin":false},"body":"Add support for more sources options, so that you can use multiple branches on remote part repositories.\r\n\r\n@josepht","created_at":"2016-11-28T15:48:28Z","updated_at":"2016-12-05T12:17:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4dffa263bb8cd7d5b38c0fc621095377ffc56789","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/931/commits","review_comments_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/931/comments","review_comment_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snapcore/snapcraft/issues/931/comments","statuses_url":"https://api.github.com/repos/snapcore/snapcraft/statuses/46c01ee4c8e3027193104a45eb9682ed88ec6440","head":{"label":"3v1n0:parser-support-more-sources-options","ref":"parser-support-more-sources-options","sha":"46c01ee4c8e3027193104a45eb9682ed88ec6440","user":{"login":"3v1n0","id":345675,"avatar_url":"https://avatars.githubusercontent.com/u/345675?v=3","gravatar_id":"","url":"https://api.github.com/users/3v1n0","html_url":"https://github.com/3v1n0","followers_url":"https://api.github.com/users/3v1n0/followers","following_url":"https://api.github.com/users/3v1n0/following{/other_user}","gists_url":"https://api.github.com/users/3v1n0/gists{/gist_id}","starred_url":"https://api.github.com/users/3v1n0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3v1n0/subscriptions","organizations_url":"https://api.github.com/users/3v1n0/orgs","repos_url":"https://api.github.com/users/3v1n0/repos","events_url":"https://api.github.com/users/3v1n0/events{/privacy}","received_events_url":"https://api.github.com/users/3v1n0/received_events","type":"User","site_admin":false},"repo":{"id":58781157,"name":"snapcraft","full_name":"3v1n0/snapcraft","owner":{"login":"3v1n0","id":345675,"avatar_url":"https://avatars.githubusercontent.com/u/345675?v=3","gravatar_id":"","url":"https://api.github.com/users/3v1n0","html_url":"https://github.com/3v1n0","followers_url":"https://api.github.com/users/3v1n0/followers","following_url":"https://api.github.com/users/3v1n0/following{/other_user}","gists_url":"https://api.github.com/users/3v1n0/gists{/gist_id}","starred_url":"https://api.github.com/users/3v1n0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3v1n0/subscriptions","organizations_url":"https://api.github.com/users/3v1n0/orgs","repos_url":"https://api.github.com/users/3v1n0/repos","events_url":"https://api.github.com/users/3v1n0/events{/privacy}","received_events_url":"https://api.github.com/users/3v1n0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/3v1n0/snapcraft","description":"Snapcraft is a delightful packaging tool","fork":true,"url":"https://api.github.com/repos/3v1n0/snapcraft","forks_url":"https://api.github.com/repos/3v1n0/snapcraft/forks","keys_url":"https://api.github.com/repos/3v1n0/snapcraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/3v1n0/snapcraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/3v1n0/snapcraft/teams","hooks_url":"https://api.github.com/repos/3v1n0/snapcraft/hooks","issue_events_url":"https://api.github.com/repos/3v1n0/snapcraft/issues/events{/number}","events_url":"https://api.github.com/repos/3v1n0/snapcraft/events","assignees_url":"https://api.github.com/repos/3v1n0/snapcraft/assignees{/user}","branches_url":"https://api.github.com/repos/3v1n0/snapcraft/branches{/branch}","tags_url":"https://api.github.com/repos/3v1n0/snapcraft/tags","blobs_url":"https://api.github.com/repos/3v1n0/snapcraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/3v1n0/snapcraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/3v1n0/snapcraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/3v1n0/snapcraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/3v1n0/snapcraft/statuses/{sha}","languages_url":"https://api.github.com/repos/3v1n0/snapcraft/languages","stargazers_url":"https://api.github.com/repos/3v1n0/snapcraft/stargazers","contributors_url":"https://api.github.com/repos/3v1n0/snapcraft/contributors","subscribers_url":"https://api.github.com/repos/3v1n0/snapcraft/subscribers","subscription_url":"https://api.github.com/repos/3v1n0/snapcraft/subscription","commits_url":"https://api.github.com/repos/3v1n0/snapcraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/3v1n0/snapcraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/3v1n0/snapcraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/3v1n0/snapcraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/3v1n0/snapcraft/contents/{+path}","compare_url":"https://api.github.com/repos/3v1n0/snapcraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/3v1n0/snapcraft/merges","archive_url":"https://api.github.com/repos/3v1n0/snapcraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/3v1n0/snapcraft/downloads","issues_url":"https://api.github.com/repos/3v1n0/snapcraft/issues{/number}","pulls_url":"https://api.github.com/repos/3v1n0/snapcraft/pulls{/number}","milestones_url":"https://api.github.com/repos/3v1n0/snapcraft/milestones{/number}","notifications_url":"https://api.github.com/repos/3v1n0/snapcraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/3v1n0/snapcraft/labels{/name}","releases_url":"https://api.github.com/repos/3v1n0/snapcraft/releases{/id}","deployments_url":"https://api.github.com/repos/3v1n0/snapcraft/deployments","created_at":"2016-05-14T00:17:31Z","updated_at":"2016-05-14T00:17:32Z","pushed_at":"2016-12-02T11:25:18Z","git_url":"git://github.com/3v1n0/snapcraft.git","ssh_url":"git@github.com:3v1n0/snapcraft.git","clone_url":"https://github.com/3v1n0/snapcraft.git","svn_url":"https://github.com/3v1n0/snapcraft","homepage":null,"size":5611,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snapcore:master","ref":"master","sha":"4c35acef26de6ce53a082ceb1be54f0179f8769a","user":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars.githubusercontent.com/u/19532717?v=3","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":45199136,"name":"snapcraft","full_name":"snapcore/snapcraft","owner":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars.githubusercontent.com/u/19532717?v=3","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/snapcore/snapcraft","description":"Snapcraft is a delightful packaging tool","fork":false,"url":"https://api.github.com/repos/snapcore/snapcraft","forks_url":"https://api.github.com/repos/snapcore/snapcraft/forks","keys_url":"https://api.github.com/repos/snapcore/snapcraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snapcraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snapcraft/teams","hooks_url":"https://api.github.com/repos/snapcore/snapcraft/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snapcraft/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snapcraft/events","assignees_url":"https://api.github.com/repos/snapcore/snapcraft/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snapcraft/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snapcraft/tags","blobs_url":"https://api.github.com/repos/snapcore/snapcraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snapcraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snapcraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snapcraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snapcraft/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snapcraft/languages","stargazers_url":"https://api.github.com/repos/snapcore/snapcraft/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snapcraft/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snapcraft/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snapcraft/subscription","commits_url":"https://api.github.com/repos/snapcore/snapcraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snapcraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snapcraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snapcraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snapcraft/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snapcraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snapcraft/merges","archive_url":"https://api.github.com/repos/snapcore/snapcraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snapcraft/downloads","issues_url":"https://api.github.com/repos/snapcore/snapcraft/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snapcraft/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snapcraft/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snapcraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snapcraft/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snapcraft/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snapcraft/deployments","created_at":"2015-10-29T17:23:15Z","updated_at":"2016-12-01T16:33:22Z","pushed_at":"2016-12-05T12:09:22Z","git_url":"git://github.com/snapcore/snapcraft.git","ssh_url":"git@github.com:snapcore/snapcraft.git","clone_url":"https://github.com/snapcore/snapcraft.git","svn_url":"https://github.com/snapcore/snapcraft","homepage":null,"size":8556,"stargazers_count":241,"watchers_count":241,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":140,"mirror_url":null,"open_issues_count":20,"forks":140,"open_issues":20,"watchers":241,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/931"},"html":{"href":"https://github.com/snapcore/snapcraft/pull/931"},"issue":{"href":"https://api.github.com/repos/snapcore/snapcraft/issues/931"},"comments":{"href":"https://api.github.com/repos/snapcore/snapcraft/issues/931/comments"},"review_comments":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/931/comments"},"review_comment":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/931/commits"},"statuses":{"href":"https://api.github.com/repos/snapcore/snapcraft/statuses/46c01ee4c8e3027193104a45eb9682ed88ec6440"}}}}
{"actor":{"display_login":"3v1n0"}}