{"action":"created","issue":{"url":"https://api.github.com/repos/hashicorp/terraform/issues/8083","repository_url":"https://api.github.com/repos/hashicorp/terraform","labels_url":"https://api.github.com/repos/hashicorp/terraform/issues/8083/labels{/name}","comments_url":"https://api.github.com/repos/hashicorp/terraform/issues/8083/comments","events_url":"https://api.github.com/repos/hashicorp/terraform/issues/8083/events","html_url":"https://github.com/hashicorp/terraform/pull/8083","id":170276984,"number":8083,"title":"[WIP] Add support for using a GCP Image Family","user":{"login":"cblecker","id":1431969,"avatar_url":"https://avatars.githubusercontent.com/u/1431969?v=3","gravatar_id":"","url":"https://api.github.com/users/cblecker","html_url":"https://github.com/cblecker","followers_url":"https://api.github.com/users/cblecker/followers","following_url":"https://api.github.com/users/cblecker/following{/other_user}","gists_url":"https://api.github.com/users/cblecker/gists{/gist_id}","starred_url":"https://api.github.com/users/cblecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cblecker/subscriptions","organizations_url":"https://api.github.com/users/cblecker/orgs","repos_url":"https://api.github.com/users/cblecker/repos","events_url":"https://api.github.com/users/cblecker/events{/privacy}","received_events_url":"https://api.github.com/users/cblecker/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/hashicorp/terraform/labels/enhancement","name":"enhancement","color":"d4c5f9"},{"url":"https://api.github.com/repos/hashicorp/terraform/labels/provider/google-cloud","name":"provider/google-cloud","color":"bfdadc"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-09T21:36:15Z","updated_at":"2016-08-10T01:06:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hashicorp/terraform/pulls/8083","html_url":"https://github.com/hashicorp/terraform/pull/8083","diff_url":"https://github.com/hashicorp/terraform/pull/8083.diff","patch_url":"https://github.com/hashicorp/terraform/pull/8083.patch"},"body":"Please excuse any mistakes in this as it's my first attempt at a PR for Terraform :)\r\n\r\nWhen I dug into #7562 a bit more, it looked easier than I initially thought to use the image family api instead of the regular image api.\r\n\r\nI haven't updated the documentation or anything yet, but I wanted to ensure I'm on the right track. I tested this with my terraform config, and it seemed to work as expected."},"comment":{"url":"https://api.github.com/repos/hashicorp/terraform/issues/comments/238738446","html_url":"https://github.com/hashicorp/terraform/pull/8083#issuecomment-238738446","issue_url":"https://api.github.com/repos/hashicorp/terraform/issues/8083","id":238738446,"user":{"login":"cblecker","id":1431969,"avatar_url":"https://avatars.githubusercontent.com/u/1431969?v=3","gravatar_id":"","url":"https://api.github.com/users/cblecker","html_url":"https://github.com/cblecker","followers_url":"https://api.github.com/users/cblecker/followers","following_url":"https://api.github.com/users/cblecker/following{/other_user}","gists_url":"https://api.github.com/users/cblecker/gists{/gist_id}","starred_url":"https://api.github.com/users/cblecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cblecker/subscriptions","organizations_url":"https://api.github.com/users/cblecker/orgs","repos_url":"https://api.github.com/users/cblecker/repos","events_url":"https://api.github.com/users/cblecker/events{/privacy}","received_events_url":"https://api.github.com/users/cblecker/received_events","type":"User","site_admin":false},"created_at":"2016-08-10T01:06:04Z","updated_at":"2016-08-10T01:06:04Z","body":"I figured out how to run the acceptance tests, saw they weren't working properly, and then fixed them. I also had to modify the test for these image families, as Google doesn't have/support a Debian 7 image family.\r\n\r\n```\r\n$ make testacc TEST=./builtin/providers/google TESTARGS='-run=TestAccComputeInstance_basic[1-5]'\r\n==> Checking that code complies with gofmt requirements...\r\n/opt/gopath/bin/stringer\r\ngo generate $(go list ./... | grep -v /terraform/vendor/)\r\n2016/08/09 20:56:01 Generated command/internal_plugin_list.go\r\nTF_ACC=1 go test ./builtin/providers/google -v -run=TestAccComputeInstance_basic[1-5] -timeout 120m\r\n=== RUN   TestAccComputeInstance_basic1\r\n--- PASS: TestAccComputeInstance_basic1 (82.49s)\r\n=== RUN   TestAccComputeInstance_basic2\r\n--- PASS: TestAccComputeInstance_basic2 (72.63s)\r\n=== RUN   TestAccComputeInstance_basic3\r\n--- PASS: TestAccComputeInstance_basic3 (90.19s)\r\n=== RUN   TestAccComputeInstance_basic4\r\n--- PASS: TestAccComputeInstance_basic4 (72.50s)\r\n=== RUN   TestAccComputeInstance_basic5\r\n--- PASS: TestAccComputeInstance_basic5 (72.59s)\r\nPASS\r\nok  \tgithub.com/hashicorp/terraform/builtin/providers/google\t390.406s\r\n```\r\n\r\nSide note: Should the other acceptance tests in this project be updated to use Debian 8 too?"}}
{"actor":{"display_login":"cblecker"}}