{"action":"created","issue":{"url":"https://api.github.com/repos/stedmanblake/chativism/issues/35","repository_url":"https://api.github.com/repos/stedmanblake/chativism","labels_url":"https://api.github.com/repos/stedmanblake/chativism/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/stedmanblake/chativism/issues/35/comments","events_url":"https://api.github.com/repos/stedmanblake/chativism/issues/35/events","html_url":"https://github.com/stedmanblake/chativism/pull/35","id":197431620,"number":35,"title":"IssueCard expansion & CTA","user":{"login":"stedmanblake","id":4050144,"avatar_url":"https://avatars.githubusercontent.com/u/4050144?v=3","gravatar_id":"","url":"https://api.github.com/users/stedmanblake","html_url":"https://github.com/stedmanblake","followers_url":"https://api.github.com/users/stedmanblake/followers","following_url":"https://api.github.com/users/stedmanblake/following{/other_user}","gists_url":"https://api.github.com/users/stedmanblake/gists{/gist_id}","starred_url":"https://api.github.com/users/stedmanblake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stedmanblake/subscriptions","organizations_url":"https://api.github.com/users/stedmanblake/orgs","repos_url":"https://api.github.com/users/stedmanblake/repos","events_url":"https://api.github.com/users/stedmanblake/events{/privacy}","received_events_url":"https://api.github.com/users/stedmanblake/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-23T22:09:07Z","updated_at":"2016-12-25T03:40:06Z","closed_at":"2016-12-23T22:22:43Z","pull_request":{"url":"https://api.github.com/repos/stedmanblake/chativism/pulls/35","html_url":"https://github.com/stedmanblake/chativism/pull/35","diff_url":"https://github.com/stedmanblake/chativism/pull/35.diff","patch_url":"https://github.com/stedmanblake/chativism/pull/35.patch"},"body":"@barneyjackson things to think about:\r\n\r\n- We moved `expanded` from the IssueCard's state to the global store, on `state.data.issues` (see https://github.com/stedmanblake/chativism/pull/35/commits/b6778c4c0bf8f049f857760933be9369f0c3daec) s/t now, only one Issue will ever be expanded at a time. I actually paired w/ Neena on this commit, which was super fun 😍  hahah. Oh, and she made me this mug for Christmas: \r\n![img_2501_sm](https://cloud.githubusercontent.com/assets/4050144/21463249/1cf79d0e-c91b-11e6-8c5e-b31bdb50a7f6.jpg)\r\n\r\n- the [FloatingActionCTA](https://material.io/guidelines/components/buttons-floating-action-button.html) is the recommended component to use for a 'primary action'. The downside is that it may be unclear which Issue it corresponds to. We render it fixed to the bottom-right of the screen the entire time, until, the user clicks to expand another card, or to close the current one.\r\n- We could alternatively use the [Chip](http://www.material-ui.com/#/components/chip) component to put a little more information along w/ the floating CTA, e.g.:\r\n![image](https://cloud.githubusercontent.com/assets/4050144/21463151/22581806-c91a-11e6-9063-352a7d8de113.png)\r\n\r\nFix #13 \r\nFix #33 \r\nFix #34 \r\n\r\n### Default View:\r\n![image](https://cloud.githubusercontent.com/assets/4050144/21463091/31c82f98-c919-11e6-9b21-7d787bd2af9b.png)\r\n\r\n### Expanded View:\r\n![image](https://cloud.githubusercontent.com/assets/4050144/21463099/4629bb8c-c919-11e6-99a3-c79b12843d99.png)\r\n![image](https://cloud.githubusercontent.com/assets/4050144/21463105/531abf80-c919-11e6-8401-9f97b47beda3.png)\r\n"},"comment":{"url":"https://api.github.com/repos/stedmanblake/chativism/issues/comments/269108945","html_url":"https://github.com/stedmanblake/chativism/pull/35#issuecomment-269108945","issue_url":"https://api.github.com/repos/stedmanblake/chativism/issues/35","id":269108945,"user":{"login":"barneyjackson","id":1398471,"avatar_url":"https://avatars.githubusercontent.com/u/1398471?v=3","gravatar_id":"","url":"https://api.github.com/users/barneyjackson","html_url":"https://github.com/barneyjackson","followers_url":"https://api.github.com/users/barneyjackson/followers","following_url":"https://api.github.com/users/barneyjackson/following{/other_user}","gists_url":"https://api.github.com/users/barneyjackson/gists{/gist_id}","starred_url":"https://api.github.com/users/barneyjackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barneyjackson/subscriptions","organizations_url":"https://api.github.com/users/barneyjackson/orgs","repos_url":"https://api.github.com/users/barneyjackson/repos","events_url":"https://api.github.com/users/barneyjackson/events{/privacy}","received_events_url":"https://api.github.com/users/barneyjackson/received_events","type":"User","site_admin":false},"created_at":"2016-12-25T03:40:06Z","updated_at":"2016-12-25T03:40:06Z","body":"Nice man! Looks like some good progress. I was looking at colors yesterday before my flight and couldn't settle on anything I liked, but the updated Cards looked great. I feel like the \"Collapse\" text is superfluous though, we should either make the action clearer somehow without words or just remove it. I'll be working on the homepage tomorrow afternoon. I like the idea of the chip component; the floating phone icon on it's own isn't completely obvious who you're calling/what it means. Nice UI hustle!\n\n\n\n________________________________\nFrom: Stedman Blake Hood <notifications@github.com>\nSent: Friday, December 23, 2016 2:22:43 PM\nTo: stedmanblake/chativism\nCc: barneyjackson; Mention\nSubject: Re: [stedmanblake/chativism] IssueCard expansion & CTA (#35)\n\n\nMerged #35<https://github.com/stedmanblake/chativism/pull/35>.\n\n-\nYou are receiving this because you were mentioned.\nReply to this email directly, view it on GitHub<https://github.com/stedmanblake/chativism/pull/35#event-904410628>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABVWxxJPG4ZWORsqcuLwSXrUJpYOOXx8ks5rLEmzgaJpZM4LVFi0>.\n"}}
{"actor":{"display_login":"barneyjackson"}}