{"action":"created","comment":{"url":"https://api.github.com/repos/chef/chef-server/pulls/comments/86012373","pull_request_review_id":6686567,"id":86012373,"diff_hunk":"@@ -73,6 +73,12 @@ http {\n   }\n   <%- end -%>\n \n+  <% if node['private_chef']['data_collector']['root_url'] && node['private_chef']['data_collector']['token'] -%>\n+  upstream data-collector {\n+    server <%= URI.parse(node['private_chef']['data_collector']['root_url']).host %>:<%= URI.parse(node['private_chef']['data_collector']['root_url']).port %>;","path":"omnibus/files/private-chef-cookbooks/private-chef/templates/default/nginx/nginx.conf.erb","position":6,"original_position":6,"commit_id":"86ad2779f811fb5be40b1bd7865971ddcf1675da","original_commit_id":"bb0efc646b250eac89d39eb7010265d7b7dbc5e0","user":{"login":"marcparadise","id":1130204,"avatar_url":"https://avatars.githubusercontent.com/u/1130204?v=3","gravatar_id":"","url":"https://api.github.com/users/marcparadise","html_url":"https://github.com/marcparadise","followers_url":"https://api.github.com/users/marcparadise/followers","following_url":"https://api.github.com/users/marcparadise/following{/other_user}","gists_url":"https://api.github.com/users/marcparadise/gists{/gist_id}","starred_url":"https://api.github.com/users/marcparadise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcparadise/subscriptions","organizations_url":"https://api.github.com/users/marcparadise/orgs","repos_url":"https://api.github.com/users/marcparadise/repos","events_url":"https://api.github.com/users/marcparadise/events{/privacy}","received_events_url":"https://api.github.com/users/marcparadise/received_events","type":"User","site_admin":false},"body":"If `token` were set but no `root_url` were set, nginx woudl fail to start. Maybe modify the conditional above to check for both?","created_at":"2016-11-01T20:04:46Z","updated_at":"2016-11-01T20:13:48Z","html_url":"https://github.com/chef/chef-server/pull/984#discussion_r86012373","pull_request_url":"https://api.github.com/repos/chef/chef-server/pulls/984","_links":{"self":{"href":"https://api.github.com/repos/chef/chef-server/pulls/comments/86012373"},"html":{"href":"https://github.com/chef/chef-server/pull/984#discussion_r86012373"},"pull_request":{"href":"https://api.github.com/repos/chef/chef-server/pulls/984"}}},"pull_request":{"url":"https://api.github.com/repos/chef/chef-server/pulls/984","id":91271473,"html_url":"https://github.com/chef/chef-server/pull/984","diff_url":"https://github.com/chef/chef-server/pull/984.diff","patch_url":"https://github.com/chef/chef-server/pull/984.patch","issue_url":"https://api.github.com/repos/chef/chef-server/issues/984","number":984,"state":"open","locked":false,"title":"Security features for /data-collector/ endpoint","user":{"login":"sersut","id":1695955,"avatar_url":"https://avatars.githubusercontent.com/u/1695955?v=3","gravatar_id":"","url":"https://api.github.com/users/sersut","html_url":"https://github.com/sersut","followers_url":"https://api.github.com/users/sersut/followers","following_url":"https://api.github.com/users/sersut/following{/other_user}","gists_url":"https://api.github.com/users/sersut/gists{/gist_id}","starred_url":"https://api.github.com/users/sersut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sersut/subscriptions","organizations_url":"https://api.github.com/users/sersut/orgs","repos_url":"https://api.github.com/users/sersut/repos","events_url":"https://api.github.com/users/sersut/events{/privacy}","received_events_url":"https://api.github.com/users/sersut/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Serdar Sutay serdarsutay@gmail.com\r\n","created_at":"2016-10-27T20:09:28Z","updated_at":"2016-11-01T20:13:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1edc09193433fcd232e44c528fd40b2c846bbe2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/chef/chef-server/pulls/984/commits","review_comments_url":"https://api.github.com/repos/chef/chef-server/pulls/984/comments","review_comment_url":"https://api.github.com/repos/chef/chef-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/chef-server/issues/984/comments","statuses_url":"https://api.github.com/repos/chef/chef-server/statuses/86ad2779f811fb5be40b1bd7865971ddcf1675da","head":{"label":"chef:sersut/visibility","ref":"sersut/visibility","sha":"86ad2779f811fb5be40b1bd7865971ddcf1675da","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":24732433,"name":"chef-server","full_name":"chef/chef-server","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/chef-server","description":"The Chef Server ","fork":false,"url":"https://api.github.com/repos/chef/chef-server","forks_url":"https://api.github.com/repos/chef/chef-server/forks","keys_url":"https://api.github.com/repos/chef/chef-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/chef-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/chef-server/teams","hooks_url":"https://api.github.com/repos/chef/chef-server/hooks","issue_events_url":"https://api.github.com/repos/chef/chef-server/issues/events{/number}","events_url":"https://api.github.com/repos/chef/chef-server/events","assignees_url":"https://api.github.com/repos/chef/chef-server/assignees{/user}","branches_url":"https://api.github.com/repos/chef/chef-server/branches{/branch}","tags_url":"https://api.github.com/repos/chef/chef-server/tags","blobs_url":"https://api.github.com/repos/chef/chef-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/chef-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/chef-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/chef-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/chef-server/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/chef-server/languages","stargazers_url":"https://api.github.com/repos/chef/chef-server/stargazers","contributors_url":"https://api.github.com/repos/chef/chef-server/contributors","subscribers_url":"https://api.github.com/repos/chef/chef-server/subscribers","subscription_url":"https://api.github.com/repos/chef/chef-server/subscription","commits_url":"https://api.github.com/repos/chef/chef-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/chef-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/chef-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/chef-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/chef-server/contents/{+path}","compare_url":"https://api.github.com/repos/chef/chef-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/chef-server/merges","archive_url":"https://api.github.com/repos/chef/chef-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/chef-server/downloads","issues_url":"https://api.github.com/repos/chef/chef-server/issues{/number}","pulls_url":"https://api.github.com/repos/chef/chef-server/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/chef-server/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/chef-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/chef-server/labels{/name}","releases_url":"https://api.github.com/repos/chef/chef-server/releases{/id}","deployments_url":"https://api.github.com/repos/chef/chef-server/deployments","created_at":"2014-10-02T19:04:18Z","updated_at":"2016-10-27T01:12:56Z","pushed_at":"2016-11-01T18:20:31Z","git_url":"git://github.com/chef/chef-server.git","ssh_url":"git@github.com:chef/chef-server.git","clone_url":"https://github.com/chef/chef-server.git","svn_url":"https://github.com/chef/chef-server","homepage":"https://www.chef.io/chef/","size":21500,"stargazers_count":118,"watchers_count":118,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":270,"forks":70,"open_issues":270,"watchers":118,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"f4a124354730cbd61c14635dca955d385cfa382d","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":24732433,"name":"chef-server","full_name":"chef/chef-server","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/chef-server","description":"The Chef Server ","fork":false,"url":"https://api.github.com/repos/chef/chef-server","forks_url":"https://api.github.com/repos/chef/chef-server/forks","keys_url":"https://api.github.com/repos/chef/chef-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/chef-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/chef-server/teams","hooks_url":"https://api.github.com/repos/chef/chef-server/hooks","issue_events_url":"https://api.github.com/repos/chef/chef-server/issues/events{/number}","events_url":"https://api.github.com/repos/chef/chef-server/events","assignees_url":"https://api.github.com/repos/chef/chef-server/assignees{/user}","branches_url":"https://api.github.com/repos/chef/chef-server/branches{/branch}","tags_url":"https://api.github.com/repos/chef/chef-server/tags","blobs_url":"https://api.github.com/repos/chef/chef-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/chef-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/chef-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/chef-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/chef-server/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/chef-server/languages","stargazers_url":"https://api.github.com/repos/chef/chef-server/stargazers","contributors_url":"https://api.github.com/repos/chef/chef-server/contributors","subscribers_url":"https://api.github.com/repos/chef/chef-server/subscribers","subscription_url":"https://api.github.com/repos/chef/chef-server/subscription","commits_url":"https://api.github.com/repos/chef/chef-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/chef-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/chef-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/chef-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/chef-server/contents/{+path}","compare_url":"https://api.github.com/repos/chef/chef-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/chef-server/merges","archive_url":"https://api.github.com/repos/chef/chef-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/chef-server/downloads","issues_url":"https://api.github.com/repos/chef/chef-server/issues{/number}","pulls_url":"https://api.github.com/repos/chef/chef-server/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/chef-server/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/chef-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/chef-server/labels{/name}","releases_url":"https://api.github.com/repos/chef/chef-server/releases{/id}","deployments_url":"https://api.github.com/repos/chef/chef-server/deployments","created_at":"2014-10-02T19:04:18Z","updated_at":"2016-10-27T01:12:56Z","pushed_at":"2016-11-01T18:20:31Z","git_url":"git://github.com/chef/chef-server.git","ssh_url":"git@github.com:chef/chef-server.git","clone_url":"https://github.com/chef/chef-server.git","svn_url":"https://github.com/chef/chef-server","homepage":"https://www.chef.io/chef/","size":21500,"stargazers_count":118,"watchers_count":118,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":270,"forks":70,"open_issues":270,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/chef-server/pulls/984"},"html":{"href":"https://github.com/chef/chef-server/pull/984"},"issue":{"href":"https://api.github.com/repos/chef/chef-server/issues/984"},"comments":{"href":"https://api.github.com/repos/chef/chef-server/issues/984/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/chef-server/pulls/984/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/chef-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/chef-server/pulls/984/commits"},"statuses":{"href":"https://api.github.com/repos/chef/chef-server/statuses/86ad2779f811fb5be40b1bd7865971ddcf1675da"}}}}
{"actor":{"display_login":"marcparadise"}}