{"action":"created","issue":{"url":"https://api.github.com/repos/ameyk/CASK-PSL/issues/5","repository_url":"https://api.github.com/repos/ameyk/CASK-PSL","labels_url":"https://api.github.com/repos/ameyk/CASK-PSL/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/ameyk/CASK-PSL/issues/5/comments","events_url":"https://api.github.com/repos/ameyk/CASK-PSL/issues/5/events","html_url":"https://github.com/ameyk/CASK-PSL/pull/5","id":161878648,"number":5,"title":"Feature/xml parser - Code review changes","user":{"login":"ananya-bhattacharya","id":10112217,"avatar_url":"https://avatars.githubusercontent.com/u/10112217?v=3","gravatar_id":"","url":"https://api.github.com/users/ananya-bhattacharya","html_url":"https://github.com/ananya-bhattacharya","followers_url":"https://api.github.com/users/ananya-bhattacharya/followers","following_url":"https://api.github.com/users/ananya-bhattacharya/following{/other_user}","gists_url":"https://api.github.com/users/ananya-bhattacharya/gists{/gist_id}","starred_url":"https://api.github.com/users/ananya-bhattacharya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ananya-bhattacharya/subscriptions","organizations_url":"https://api.github.com/users/ananya-bhattacharya/orgs","repos_url":"https://api.github.com/users/ananya-bhattacharya/repos","events_url":"https://api.github.com/users/ananya-bhattacharya/events{/privacy}","received_events_url":"https://api.github.com/users/ananya-bhattacharya/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-23T09:31:19Z","updated_at":"2016-06-23T13:51:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ameyk/CASK-PSL/pulls/5","html_url":"https://github.com/ameyk/CASK-PSL/pull/5","diff_url":"https://github.com/ameyk/CASK-PSL/pull/5.diff","patch_url":"https://github.com/ameyk/CASK-PSL/pull/5.patch"},"body":"1.Changed the test assertions as suggested in CASK review comments.\r\n2.Split the validateXpathAndSchema() into validateXpathAndSchema() and getxPathMapping() and called getxPathMapping() in inititalize \r\n3. TypeConvertor(as suggested by Ali), can be used only to an extent since the it does not check if the schema is null. Therefore checking the schema type in parseValue() and then returning the value using the TypeConvertor() get call"},"comment":{"url":"https://api.github.com/repos/ameyk/CASK-PSL/issues/comments/228056298","html_url":"https://github.com/ameyk/CASK-PSL/pull/5#issuecomment-228056298","issue_url":"https://api.github.com/repos/ameyk/CASK-PSL/issues/5","id":228056298,"user":{"login":"bhushankawadkar","id":17117900,"avatar_url":"https://avatars.githubusercontent.com/u/17117900?v=3","gravatar_id":"","url":"https://api.github.com/users/bhushankawadkar","html_url":"https://github.com/bhushankawadkar","followers_url":"https://api.github.com/users/bhushankawadkar/followers","following_url":"https://api.github.com/users/bhushankawadkar/following{/other_user}","gists_url":"https://api.github.com/users/bhushankawadkar/gists{/gist_id}","starred_url":"https://api.github.com/users/bhushankawadkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhushankawadkar/subscriptions","organizations_url":"https://api.github.com/users/bhushankawadkar/orgs","repos_url":"https://api.github.com/users/bhushankawadkar/repos","events_url":"https://api.github.com/users/bhushankawadkar/events{/privacy}","received_events_url":"https://api.github.com/users/bhushankawadkar/received_events","type":"User","site_admin":false},"created_at":"2016-06-23T13:51:17Z","updated_at":"2016-06-23T13:51:17Z","body":"LGTM"}}
{"actor":{"display_login":"bhushankawadkar"}}