{"action":"created","comment":{"url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/pulls/comments/49441372","id":49441372,"diff_hunk":"@@ -313,14 +324,59 @@ public void testDeploymentArtifacts() {\n         assertNotNull(app);\n         assertEquals(app.getChildren().size(), 1);\n \n-        EntitySpec<?> tomcatServer = ToscaPlanToSpecTransformer\n-                .findChildEntitySpecByPlanId(app, \"tomcat_server\");\n+        EntitySpec<TomcatServer> tomcatServer =\n+                (EntitySpec<TomcatServer>) ToscaPlanToSpecTransformer","path":"brooklyn-tosca-transformer/src/test/java/io/cloudsoft/tosca/a4c/brooklyn/ToscaPlanToSpecTransformerTest.java","position":118,"original_position":118,"commit_id":"ab49fa3c4edb86ebe0444b79578836317b8f8a41","original_commit_id":"ab49fa3c4edb86ebe0444b79578836317b8f8a41","user":{"login":"sjcorbett","id":837527,"avatar_url":"https://avatars.githubusercontent.com/u/837527?v=3","gravatar_id":"","url":"https://api.github.com/users/sjcorbett","html_url":"https://github.com/sjcorbett","followers_url":"https://api.github.com/users/sjcorbett/followers","following_url":"https://api.github.com/users/sjcorbett/following{/other_user}","gists_url":"https://api.github.com/users/sjcorbett/gists{/gist_id}","starred_url":"https://api.github.com/users/sjcorbett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjcorbett/subscriptions","organizations_url":"https://api.github.com/users/sjcorbett/orgs","repos_url":"https://api.github.com/users/sjcorbett/repos","events_url":"https://api.github.com/users/sjcorbett/events{/privacy}","received_events_url":"https://api.github.com/users/sjcorbett/received_events","type":"User","site_admin":false},"body":"There's no need to cast to TomcatServer here.","created_at":"2016-01-12T11:14:53Z","updated_at":"2016-01-12T11:14:53Z","html_url":"https://github.com/cloudsoft/brooklyn-tosca/pull/41#discussion_r49441372","pull_request_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/pulls/comments/49441372"},"html":{"href":"https://github.com/cloudsoft/brooklyn-tosca/pull/41#discussion_r49441372"},"pull_request":{"href":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/pulls/41","id":52521625,"html_url":"https://github.com/cloudsoft/brooklyn-tosca/pull/41","diff_url":"https://github.com/cloudsoft/brooklyn-tosca/pull/41.diff","patch_url":"https://github.com/cloudsoft/brooklyn-tosca/pull/41.patch","issue_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/issues/41","number":41,"state":"open","locked":false,"title":"Features/op artifacts from topology","user":{"login":"kiuby88","id":3704424,"avatar_url":"https://avatars.githubusercontent.com/u/3704424?v=3","gravatar_id":"","url":"https://api.github.com/users/kiuby88","html_url":"https://github.com/kiuby88","followers_url":"https://api.github.com/users/kiuby88/followers","following_url":"https://api.github.com/users/kiuby88/following{/other_user}","gists_url":"https://api.github.com/users/kiuby88/gists{/gist_id}","starred_url":"https://api.github.com/users/kiuby88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiuby88/subscriptions","organizations_url":"https://api.github.com/users/kiuby88/orgs","repos_url":"https://api.github.com/users/kiuby88/repos","events_url":"https://api.github.com/users/kiuby88/events{/privacy}","received_events_url":"https://api.github.com/users/kiuby88/received_events","type":"User","site_admin":false},"body":"It allows to specify a Interface from a topology template, for example:\r\n```\r\n  node_templates:\r\n    script_hello:\r\n      type: tosca.nodes.SoftwareComponent\r\n      requirements:\r\n      - host: a_server\r\n      interfaces:\r\n        Standard:\r\n           create: https://raw.githubusercontent.com/ahgittin/tosca-demo/master/script1/scripts/create.sh\r\n           configure: https://raw.githubusercontent.com/ahgittin/tosca-demo/master/script1/scripts/configure.sh\r\n           start: https://raw.githubusercontent.com/ahgittin/tosca-demo/master/script1/scripts/start.sh\r\n           stop: https://raw.githubusercontent.com/ahgittin/tosca-demo/master/script1/scripts/stop.sh\r\n```\r\nA default NodeTemplate's Interface can be defined by the NodeType. However, a user could try to redefine an operation, so it will redefine an operation from topology template.","created_at":"2015-12-03T11:22:11Z","updated_at":"2016-01-12T11:14:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2bf1b8ba2289eb3a7eeac959280f42f984b23052","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/pulls/41/commits","review_comments_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/pulls/41/comments","review_comment_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/issues/41/comments","statuses_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/statuses/ab49fa3c4edb86ebe0444b79578836317b8f8a41","head":{"label":"kiuby88:features/op-artifacts-from-topology","ref":"features/op-artifacts-from-topology","sha":"ab49fa3c4edb86ebe0444b79578836317b8f8a41","user":{"login":"kiuby88","id":3704424,"avatar_url":"https://avatars.githubusercontent.com/u/3704424?v=3","gravatar_id":"","url":"https://api.github.com/users/kiuby88","html_url":"https://github.com/kiuby88","followers_url":"https://api.github.com/users/kiuby88/followers","following_url":"https://api.github.com/users/kiuby88/following{/other_user}","gists_url":"https://api.github.com/users/kiuby88/gists{/gist_id}","starred_url":"https://api.github.com/users/kiuby88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiuby88/subscriptions","organizations_url":"https://api.github.com/users/kiuby88/orgs","repos_url":"https://api.github.com/users/kiuby88/repos","events_url":"https://api.github.com/users/kiuby88/events{/privacy}","received_events_url":"https://api.github.com/users/kiuby88/received_events","type":"User","site_admin":false},"repo":{"id":43336070,"name":"brooklyn-tosca","full_name":"kiuby88/brooklyn-tosca","owner":{"login":"kiuby88","id":3704424,"avatar_url":"https://avatars.githubusercontent.com/u/3704424?v=3","gravatar_id":"","url":"https://api.github.com/users/kiuby88","html_url":"https://github.com/kiuby88","followers_url":"https://api.github.com/users/kiuby88/followers","following_url":"https://api.github.com/users/kiuby88/following{/other_user}","gists_url":"https://api.github.com/users/kiuby88/gists{/gist_id}","starred_url":"https://api.github.com/users/kiuby88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiuby88/subscriptions","organizations_url":"https://api.github.com/users/kiuby88/orgs","repos_url":"https://api.github.com/users/kiuby88/repos","events_url":"https://api.github.com/users/kiuby88/events{/privacy}","received_events_url":"https://api.github.com/users/kiuby88/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kiuby88/brooklyn-tosca","description":"","fork":true,"url":"https://api.github.com/repos/kiuby88/brooklyn-tosca","forks_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/forks","keys_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/teams","hooks_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/hooks","issue_events_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/issues/events{/number}","events_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/events","assignees_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/assignees{/user}","branches_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/branches{/branch}","tags_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/tags","blobs_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/statuses/{sha}","languages_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/languages","stargazers_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/stargazers","contributors_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/contributors","subscribers_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/subscribers","subscription_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/subscription","commits_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/contents/{+path}","compare_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/merges","archive_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/downloads","issues_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/issues{/number}","pulls_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/pulls{/number}","milestones_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/milestones{/number}","notifications_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/labels{/name}","releases_url":"https://api.github.com/repos/kiuby88/brooklyn-tosca/releases{/id}","created_at":"2015-09-29T00:56:08Z","updated_at":"2015-09-29T00:56:08Z","pushed_at":"2016-01-12T09:56:33Z","git_url":"git://github.com/kiuby88/brooklyn-tosca.git","ssh_url":"git@github.com:kiuby88/brooklyn-tosca.git","clone_url":"https://github.com/kiuby88/brooklyn-tosca.git","svn_url":"https://github.com/kiuby88/brooklyn-tosca","homepage":null,"size":932,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudsoft:master","ref":"master","sha":"2dc3bcf5cd70888eea2f6f02ece892028ded8a77","user":{"login":"cloudsoft","id":831459,"avatar_url":"https://avatars.githubusercontent.com/u/831459?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudsoft","html_url":"https://github.com/cloudsoft","followers_url":"https://api.github.com/users/cloudsoft/followers","following_url":"https://api.github.com/users/cloudsoft/following{/other_user}","gists_url":"https://api.github.com/users/cloudsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudsoft/subscriptions","organizations_url":"https://api.github.com/users/cloudsoft/orgs","repos_url":"https://api.github.com/users/cloudsoft/repos","events_url":"https://api.github.com/users/cloudsoft/events{/privacy}","received_events_url":"https://api.github.com/users/cloudsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":42243454,"name":"brooklyn-tosca","full_name":"cloudsoft/brooklyn-tosca","owner":{"login":"cloudsoft","id":831459,"avatar_url":"https://avatars.githubusercontent.com/u/831459?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudsoft","html_url":"https://github.com/cloudsoft","followers_url":"https://api.github.com/users/cloudsoft/followers","following_url":"https://api.github.com/users/cloudsoft/following{/other_user}","gists_url":"https://api.github.com/users/cloudsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudsoft/subscriptions","organizations_url":"https://api.github.com/users/cloudsoft/orgs","repos_url":"https://api.github.com/users/cloudsoft/repos","events_url":"https://api.github.com/users/cloudsoft/events{/privacy}","received_events_url":"https://api.github.com/users/cloudsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudsoft/brooklyn-tosca","description":"","fork":false,"url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca","forks_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/forks","keys_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/teams","hooks_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/hooks","issue_events_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/issues/events{/number}","events_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/events","assignees_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/assignees{/user}","branches_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/branches{/branch}","tags_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/tags","blobs_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/languages","stargazers_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/stargazers","contributors_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/contributors","subscribers_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/subscribers","subscription_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/subscription","commits_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/contents/{+path}","compare_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/merges","archive_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/downloads","issues_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/issues{/number}","pulls_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/labels{/name}","releases_url":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/releases{/id}","created_at":"2015-09-10T12:36:54Z","updated_at":"2016-01-11T11:40:35Z","pushed_at":"2016-01-12T10:55:33Z","git_url":"git://github.com/cloudsoft/brooklyn-tosca.git","ssh_url":"git@github.com:cloudsoft/brooklyn-tosca.git","clone_url":"https://github.com/cloudsoft/brooklyn-tosca.git","svn_url":"https://github.com/cloudsoft/brooklyn-tosca","homepage":null,"size":954,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":1,"forks":12,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/pulls/41"},"html":{"href":"https://github.com/cloudsoft/brooklyn-tosca/pull/41"},"issue":{"href":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/issues/41"},"comments":{"href":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/cloudsoft/brooklyn-tosca/statuses/ab49fa3c4edb86ebe0444b79578836317b8f8a41"}}}}