{"action":"created","comment":{"url":"https://api.github.com/repos/RackHD/on-core/pulls/comments/51297728","id":51297728,"diff_hunk":"@@ -26,7 +26,7 @@ function constantsFactory (path) {\n               error: 'red',\n               warning: 'yellow',\n               info: 'green',\n-              debug: 'blue',\n+              debug: 'cyan',","path":"lib/common/constants.js","position":5,"original_position":5,"commit_id":"eb60b616ccc0121f8ad9d71b70077b220b7322af","original_commit_id":"eb60b616ccc0121f8ad9d71b70077b220b7322af","user":{"login":"benbp","id":1020379,"avatar_url":"https://avatars.githubusercontent.com/u/1020379?v=3","gravatar_id":"","url":"https://api.github.com/users/benbp","html_url":"https://github.com/benbp","followers_url":"https://api.github.com/users/benbp/followers","following_url":"https://api.github.com/users/benbp/following{/other_user}","gists_url":"https://api.github.com/users/benbp/gists{/gist_id}","starred_url":"https://api.github.com/users/benbp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbp/subscriptions","organizations_url":"https://api.github.com/users/benbp/orgs","repos_url":"https://api.github.com/users/benbp/repos","events_url":"https://api.github.com/users/benbp/events{/privacy}","received_events_url":"https://api.github.com/users/benbp/received_events","type":"User","site_admin":false},"body":"Heh, so, I can tell the difference between cyan and the other colors, however I **did** notice that I actually can't tell the difference between info and warning messages (green and yellow)!","created_at":"2016-01-29T18:41:01Z","updated_at":"2016-01-29T18:41:01Z","html_url":"https://github.com/RackHD/on-core/pull/66#discussion_r51297728","pull_request_url":"https://api.github.com/repos/RackHD/on-core/pulls/66","_links":{"self":{"href":"https://api.github.com/repos/RackHD/on-core/pulls/comments/51297728"},"html":{"href":"https://github.com/RackHD/on-core/pull/66#discussion_r51297728"},"pull_request":{"href":"https://api.github.com/repos/RackHD/on-core/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/RackHD/on-core/pulls/66","id":56441627,"html_url":"https://github.com/RackHD/on-core/pull/66","diff_url":"https://github.com/RackHD/on-core/pull/66.diff","patch_url":"https://github.com/RackHD/on-core/pull/66.patch","issue_url":"https://api.github.com/repos/RackHD/on-core/issues/66","number":66,"state":"open","locked":false,"title":"improve log output (color/level/caller)","user":{"login":"yyscamper","id":511378,"avatar_url":"https://avatars.githubusercontent.com/u/511378?v=3","gravatar_id":"","url":"https://api.github.com/users/yyscamper","html_url":"https://github.com/yyscamper","followers_url":"https://api.github.com/users/yyscamper/followers","following_url":"https://api.github.com/users/yyscamper/following{/other_user}","gists_url":"https://api.github.com/users/yyscamper/gists{/gist_id}","starred_url":"https://api.github.com/users/yyscamper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyscamper/subscriptions","organizations_url":"https://api.github.com/users/yyscamper/orgs","repos_url":"https://api.github.com/users/yyscamper/repos","events_url":"https://api.github.com/users/yyscamper/events{/privacy}","received_events_url":"https://api.github.com/users/yyscamper/received_events","type":"User","site_admin":false},"body":"Change includes:\r\n\r\n- default turn off colorful output, user can turn on the colorful output by configuration: --color or --logColorEnable\r\n- create argument handler service as the common place for argument handling. \r\n- print full log level name\r\n- print caller uses the same color of corresponding log level\r\n- change the color for 'debug' level to cyan\r\n- improve LogEvent unittest coverage\r\n\r\nthis change is from the google group discussion [Remove the color code from RackHD log file]( https://groups.google.com/forum/#!topic/rackhd/7xtNfbg9jzM)\r\nThe code follows the implementation of the \"colors\" module: https://github.com/Marak/colors.js/blob/master/lib%2Fsystem%2Fsupports-colors.js#L34-L38\r\n\r\n@RackHD/corecommitters @iceiilin @WangWinson @cgx027 @pengz1 @sunnyqianzhang ","created_at":"2016-01-19T09:41:57Z","updated_at":"2016-01-29T18:41:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06603b38ff35ff9d012d7688a5a44ced9c7208d9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RackHD/on-core/pulls/66/commits","review_comments_url":"https://api.github.com/repos/RackHD/on-core/pulls/66/comments","review_comment_url":"https://api.github.com/repos/RackHD/on-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RackHD/on-core/issues/66/comments","statuses_url":"https://api.github.com/repos/RackHD/on-core/statuses/eb60b616ccc0121f8ad9d71b70077b220b7322af","head":{"label":"yyscamper:logImprove","ref":"logImprove","sha":"eb60b616ccc0121f8ad9d71b70077b220b7322af","user":{"login":"yyscamper","id":511378,"avatar_url":"https://avatars.githubusercontent.com/u/511378?v=3","gravatar_id":"","url":"https://api.github.com/users/yyscamper","html_url":"https://github.com/yyscamper","followers_url":"https://api.github.com/users/yyscamper/followers","following_url":"https://api.github.com/users/yyscamper/following{/other_user}","gists_url":"https://api.github.com/users/yyscamper/gists{/gist_id}","starred_url":"https://api.github.com/users/yyscamper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyscamper/subscriptions","organizations_url":"https://api.github.com/users/yyscamper/orgs","repos_url":"https://api.github.com/users/yyscamper/repos","events_url":"https://api.github.com/users/yyscamper/events{/privacy}","received_events_url":"https://api.github.com/users/yyscamper/received_events","type":"User","site_admin":false},"repo":{"id":45583975,"name":"on-core","full_name":"yyscamper/on-core","owner":{"login":"yyscamper","id":511378,"avatar_url":"https://avatars.githubusercontent.com/u/511378?v=3","gravatar_id":"","url":"https://api.github.com/users/yyscamper","html_url":"https://github.com/yyscamper","followers_url":"https://api.github.com/users/yyscamper/followers","following_url":"https://api.github.com/users/yyscamper/following{/other_user}","gists_url":"https://api.github.com/users/yyscamper/gists{/gist_id}","starred_url":"https://api.github.com/users/yyscamper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyscamper/subscriptions","organizations_url":"https://api.github.com/users/yyscamper/orgs","repos_url":"https://api.github.com/users/yyscamper/repos","events_url":"https://api.github.com/users/yyscamper/events{/privacy}","received_events_url":"https://api.github.com/users/yyscamper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yyscamper/on-core","description":"","fork":true,"url":"https://api.github.com/repos/yyscamper/on-core","forks_url":"https://api.github.com/repos/yyscamper/on-core/forks","keys_url":"https://api.github.com/repos/yyscamper/on-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yyscamper/on-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yyscamper/on-core/teams","hooks_url":"https://api.github.com/repos/yyscamper/on-core/hooks","issue_events_url":"https://api.github.com/repos/yyscamper/on-core/issues/events{/number}","events_url":"https://api.github.com/repos/yyscamper/on-core/events","assignees_url":"https://api.github.com/repos/yyscamper/on-core/assignees{/user}","branches_url":"https://api.github.com/repos/yyscamper/on-core/branches{/branch}","tags_url":"https://api.github.com/repos/yyscamper/on-core/tags","blobs_url":"https://api.github.com/repos/yyscamper/on-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yyscamper/on-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yyscamper/on-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/yyscamper/on-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yyscamper/on-core/statuses/{sha}","languages_url":"https://api.github.com/repos/yyscamper/on-core/languages","stargazers_url":"https://api.github.com/repos/yyscamper/on-core/stargazers","contributors_url":"https://api.github.com/repos/yyscamper/on-core/contributors","subscribers_url":"https://api.github.com/repos/yyscamper/on-core/subscribers","subscription_url":"https://api.github.com/repos/yyscamper/on-core/subscription","commits_url":"https://api.github.com/repos/yyscamper/on-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/yyscamper/on-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/yyscamper/on-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/yyscamper/on-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/yyscamper/on-core/contents/{+path}","compare_url":"https://api.github.com/repos/yyscamper/on-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yyscamper/on-core/merges","archive_url":"https://api.github.com/repos/yyscamper/on-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yyscamper/on-core/downloads","issues_url":"https://api.github.com/repos/yyscamper/on-core/issues{/number}","pulls_url":"https://api.github.com/repos/yyscamper/on-core/pulls{/number}","milestones_url":"https://api.github.com/repos/yyscamper/on-core/milestones{/number}","notifications_url":"https://api.github.com/repos/yyscamper/on-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yyscamper/on-core/labels{/name}","releases_url":"https://api.github.com/repos/yyscamper/on-core/releases{/id}","deployments_url":"https://api.github.com/repos/yyscamper/on-core/deployments","created_at":"2015-11-05T03:08:15Z","updated_at":"2016-01-19T06:48:04Z","pushed_at":"2016-01-29T09:16:39Z","git_url":"git://github.com/yyscamper/on-core.git","ssh_url":"git@github.com:yyscamper/on-core.git","clone_url":"https://github.com/yyscamper/on-core.git","svn_url":"https://github.com/yyscamper/on-core","homepage":null,"size":766,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"RackHD:master","ref":"master","sha":"c219d8d1c26db3d0cf26b898749f09789f6ba320","user":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars.githubusercontent.com/u/13982662?v=3","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"repo":{"id":41690044,"name":"on-core","full_name":"RackHD/on-core","owner":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars.githubusercontent.com/u/13982662?v=3","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RackHD/on-core","description":"","fork":false,"url":"https://api.github.com/repos/RackHD/on-core","forks_url":"https://api.github.com/repos/RackHD/on-core/forks","keys_url":"https://api.github.com/repos/RackHD/on-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RackHD/on-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RackHD/on-core/teams","hooks_url":"https://api.github.com/repos/RackHD/on-core/hooks","issue_events_url":"https://api.github.com/repos/RackHD/on-core/issues/events{/number}","events_url":"https://api.github.com/repos/RackHD/on-core/events","assignees_url":"https://api.github.com/repos/RackHD/on-core/assignees{/user}","branches_url":"https://api.github.com/repos/RackHD/on-core/branches{/branch}","tags_url":"https://api.github.com/repos/RackHD/on-core/tags","blobs_url":"https://api.github.com/repos/RackHD/on-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RackHD/on-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RackHD/on-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/RackHD/on-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RackHD/on-core/statuses/{sha}","languages_url":"https://api.github.com/repos/RackHD/on-core/languages","stargazers_url":"https://api.github.com/repos/RackHD/on-core/stargazers","contributors_url":"https://api.github.com/repos/RackHD/on-core/contributors","subscribers_url":"https://api.github.com/repos/RackHD/on-core/subscribers","subscription_url":"https://api.github.com/repos/RackHD/on-core/subscription","commits_url":"https://api.github.com/repos/RackHD/on-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/RackHD/on-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/RackHD/on-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/RackHD/on-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/RackHD/on-core/contents/{+path}","compare_url":"https://api.github.com/repos/RackHD/on-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RackHD/on-core/merges","archive_url":"https://api.github.com/repos/RackHD/on-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RackHD/on-core/downloads","issues_url":"https://api.github.com/repos/RackHD/on-core/issues{/number}","pulls_url":"https://api.github.com/repos/RackHD/on-core/pulls{/number}","milestones_url":"https://api.github.com/repos/RackHD/on-core/milestones{/number}","notifications_url":"https://api.github.com/repos/RackHD/on-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RackHD/on-core/labels{/name}","releases_url":"https://api.github.com/repos/RackHD/on-core/releases{/id}","deployments_url":"https://api.github.com/repos/RackHD/on-core/deployments","created_at":"2015-08-31T17:28:32Z","updated_at":"2016-01-13T05:43:33Z","pushed_at":"2016-01-29T09:16:39Z","git_url":"git://github.com/RackHD/on-core.git","ssh_url":"git@github.com:RackHD/on-core.git","clone_url":"https://github.com/RackHD/on-core.git","svn_url":"https://github.com/RackHD/on-core","homepage":null,"size":797,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":3,"forks":25,"open_issues":3,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RackHD/on-core/pulls/66"},"html":{"href":"https://github.com/RackHD/on-core/pull/66"},"issue":{"href":"https://api.github.com/repos/RackHD/on-core/issues/66"},"comments":{"href":"https://api.github.com/repos/RackHD/on-core/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/RackHD/on-core/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/RackHD/on-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RackHD/on-core/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/RackHD/on-core/statuses/eb60b616ccc0121f8ad9d71b70077b220b7322af"}}}}