{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/rkt/pulls/comments/86120097","pull_request_review_id":6793494,"id":86120097,"diff_hunk":"@@ -258,9 +258,11 @@ The gateway is configured for the default route, allowing the pod to access exte\n \n ### dhcp\n \n-DHCP type requires a daemon to be running on the host.\n+The DHCP type requires a special client daemon, part of the [CNI DHCP plugin][cni-dhcp], to be running on the host.\n+This acts as a proxy between a DHCP client running inside the container and a DHCP service already running on the network, as well as renewing leases appropriately.\n+\n The DHCP plugin binary can be executed in the daemon mode by launching it with `daemon` argument.\n-However the DHCP plugin is bundled in stage1.aci so this requires extracting the binary from it:\n+However in rkt the DHCP plugin is bundled in stage1.aci so this requires extracting the binary from it:","path":"Documentation/networking/overview.md","position":10,"original_position":10,"commit_id":"2f192c55051182be8d4deed0667fa92fefc45192","original_commit_id":"2f192c55051182be8d4deed0667fa92fefc45192","user":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?v=3","gravatar_id":"","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"body":"ack","created_at":"2016-11-02T11:25:10Z","updated_at":"2016-11-02T11:25:10Z","html_url":"https://github.com/coreos/rkt/pull/3325#discussion_r86120097","pull_request_url":"https://api.github.com/repos/coreos/rkt/pulls/3325","_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments/86120097"},"html":{"href":"https://github.com/coreos/rkt/pull/3325#discussion_r86120097"},"pull_request":{"href":"https://api.github.com/repos/coreos/rkt/pulls/3325"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/3325","id":91215787,"html_url":"https://github.com/coreos/rkt/pull/3325","diff_url":"https://github.com/coreos/rkt/pull/3325.diff","patch_url":"https://github.com/coreos/rkt/pull/3325.patch","issue_url":"https://api.github.com/repos/coreos/rkt/issues/3325","number":3325,"state":"open","locked":false,"title":"docs/networking: minor clarification to DHCP type","user":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?v=3","gravatar_id":"","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"body":"Make it explicit that the DHCP daemon being referred to is the one\nthat's part of the special CNI DHCP plugin.\n","created_at":"2016-10-27T14:46:26Z","updated_at":"2016-11-02T11:25:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"acd44e35813783410af7c22e2e1fa60f2fdf0817","assignee":{"login":"lucab","id":98086,"avatar_url":"https://avatars.githubusercontent.com/u/98086?v=3","gravatar_id":"","url":"https://api.github.com/users/lucab","html_url":"https://github.com/lucab","followers_url":"https://api.github.com/users/lucab/followers","following_url":"https://api.github.com/users/lucab/following{/other_user}","gists_url":"https://api.github.com/users/lucab/gists{/gist_id}","starred_url":"https://api.github.com/users/lucab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucab/subscriptions","organizations_url":"https://api.github.com/users/lucab/orgs","repos_url":"https://api.github.com/users/lucab/repos","events_url":"https://api.github.com/users/lucab/events{/privacy}","received_events_url":"https://api.github.com/users/lucab/received_events","type":"User","site_admin":false},"assignees":[{"login":"lucab","id":98086,"avatar_url":"https://avatars.githubusercontent.com/u/98086?v=3","gravatar_id":"","url":"https://api.github.com/users/lucab","html_url":"https://github.com/lucab","followers_url":"https://api.github.com/users/lucab/followers","following_url":"https://api.github.com/users/lucab/following{/other_user}","gists_url":"https://api.github.com/users/lucab/gists{/gist_id}","starred_url":"https://api.github.com/users/lucab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucab/subscriptions","organizations_url":"https://api.github.com/users/lucab/orgs","repos_url":"https://api.github.com/users/lucab/repos","events_url":"https://api.github.com/users/lucab/events{/privacy}","received_events_url":"https://api.github.com/users/lucab/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/coreos/rkt/milestones/53","html_url":"https://github.com/coreos/rkt/milestones/v1.19.0","labels_url":"https://api.github.com/repos/coreos/rkt/milestones/53/labels","id":2067473,"number":53,"title":"v1.19.0","description":"","creator":{"login":"lucab","id":98086,"avatar_url":"https://avatars.githubusercontent.com/u/98086?v=3","gravatar_id":"","url":"https://api.github.com/users/lucab","html_url":"https://github.com/lucab","followers_url":"https://api.github.com/users/lucab/followers","following_url":"https://api.github.com/users/lucab/following{/other_user}","gists_url":"https://api.github.com/users/lucab/gists{/gist_id}","starred_url":"https://api.github.com/users/lucab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucab/subscriptions","organizations_url":"https://api.github.com/users/lucab/orgs","repos_url":"https://api.github.com/users/lucab/repos","events_url":"https://api.github.com/users/lucab/events{/privacy}","received_events_url":"https://api.github.com/users/lucab/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":2,"state":"open","created_at":"2016-10-13T10:24:58Z","updated_at":"2016-11-01T09:33:09Z","due_on":"2016-11-10T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/coreos/rkt/pulls/3325/commits","review_comments_url":"https://api.github.com/repos/coreos/rkt/pulls/3325/comments","review_comment_url":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/3325/comments","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/2f192c55051182be8d4deed0667fa92fefc45192","head":{"label":"jonboulle:master","ref":"master","sha":"2f192c55051182be8d4deed0667fa92fefc45192","user":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?v=3","gravatar_id":"","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"repo":{"id":27398988,"name":"rkt","full_name":"jonboulle/rkt","owner":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?v=3","gravatar_id":"","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonboulle/rkt","description":"App Container runtime","fork":true,"url":"https://api.github.com/repos/jonboulle/rkt","forks_url":"https://api.github.com/repos/jonboulle/rkt/forks","keys_url":"https://api.github.com/repos/jonboulle/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonboulle/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonboulle/rkt/teams","hooks_url":"https://api.github.com/repos/jonboulle/rkt/hooks","issue_events_url":"https://api.github.com/repos/jonboulle/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/jonboulle/rkt/events","assignees_url":"https://api.github.com/repos/jonboulle/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/jonboulle/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/jonboulle/rkt/tags","blobs_url":"https://api.github.com/repos/jonboulle/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonboulle/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonboulle/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonboulle/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonboulle/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/jonboulle/rkt/languages","stargazers_url":"https://api.github.com/repos/jonboulle/rkt/stargazers","contributors_url":"https://api.github.com/repos/jonboulle/rkt/contributors","subscribers_url":"https://api.github.com/repos/jonboulle/rkt/subscribers","subscription_url":"https://api.github.com/repos/jonboulle/rkt/subscription","commits_url":"https://api.github.com/repos/jonboulle/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonboulle/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonboulle/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonboulle/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonboulle/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/jonboulle/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonboulle/rkt/merges","archive_url":"https://api.github.com/repos/jonboulle/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonboulle/rkt/downloads","issues_url":"https://api.github.com/repos/jonboulle/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/jonboulle/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/jonboulle/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/jonboulle/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonboulle/rkt/labels{/name}","releases_url":"https://api.github.com/repos/jonboulle/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/jonboulle/rkt/deployments","created_at":"2014-12-01T20:44:29Z","updated_at":"2016-10-27T14:46:27Z","pushed_at":"2016-11-01T18:11:07Z","git_url":"git://github.com/jonboulle/rkt.git","ssh_url":"git@github.com:jonboulle/rkt.git","clone_url":"https://github.com/jonboulle/rkt.git","svn_url":"https://github.com/jonboulle/rkt","homepage":"","size":23423,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"6c20fcd87c2ba89b3e428f29024637f224962c09","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rkt","full_name":"coreos/rkt","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rkt","description":"rkt is a container engine for Linux designed to be composable, secure, and built on standards","fork":false,"url":"https://api.github.com/repos/coreos/rkt","forks_url":"https://api.github.com/repos/coreos/rkt/forks","keys_url":"https://api.github.com/repos/coreos/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rkt/teams","hooks_url":"https://api.github.com/repos/coreos/rkt/hooks","issue_events_url":"https://api.github.com/repos/coreos/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rkt/events","assignees_url":"https://api.github.com/repos/coreos/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rkt/tags","blobs_url":"https://api.github.com/repos/coreos/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rkt/languages","stargazers_url":"https://api.github.com/repos/coreos/rkt/stargazers","contributors_url":"https://api.github.com/repos/coreos/rkt/contributors","subscribers_url":"https://api.github.com/repos/coreos/rkt/subscribers","subscription_url":"https://api.github.com/repos/coreos/rkt/subscription","commits_url":"https://api.github.com/repos/coreos/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rkt/merges","archive_url":"https://api.github.com/repos/coreos/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rkt/downloads","issues_url":"https://api.github.com/repos/coreos/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rkt/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/rkt/deployments","created_at":"2014-11-11T23:13:18Z","updated_at":"2016-11-02T10:11:22Z","pushed_at":"2016-11-02T03:45:02Z","git_url":"git://github.com/coreos/rkt.git","ssh_url":"git@github.com:coreos/rkt.git","clone_url":"https://github.com/coreos/rkt.git","svn_url":"https://github.com/coreos/rkt","homepage":"","size":34760,"stargazers_count":6362,"watchers_count":6362,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":620,"mirror_url":null,"open_issues_count":403,"forks":620,"open_issues":403,"watchers":6362,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/3325"},"html":{"href":"https://github.com/coreos/rkt/pull/3325"},"issue":{"href":"https://api.github.com/repos/coreos/rkt/issues/3325"},"comments":{"href":"https://api.github.com/repos/coreos/rkt/issues/3325/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rkt/pulls/3325/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/rkt/pulls/3325/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rkt/statuses/2f192c55051182be8d4deed0667fa92fefc45192"}}}}
{"actor":{"display_login":"jonboulle"}}