{"action":"created","comment":{"url":"https://api.github.com/repos/auth0/react-native-lock-ios/pulls/comments/50328493","id":50328493,"diff_hunk":"@@ -44,6 +49,19 @@ - (void)configureLockWithClientId:(NSString *)clientId domain:(NSString *)domain\n     _lock = [A0Lock newLockWithClientId:clientId domain:domain];\n }\n \n+- (void)hideWithCallback:(A0LockCallback)callback {\n+    if (self.shown) {","path":"objc/core/A0LockReact.m","position":17,"original_position":17,"commit_id":"48637e05b6ed576ea116b6a18c5f586fcfbcd303","original_commit_id":"48637e05b6ed576ea116b6a18c5f586fcfbcd303","user":{"login":"hzalaz","id":895992,"avatar_url":"https://avatars.githubusercontent.com/u/895992?v=3","gravatar_id":"","url":"https://api.github.com/users/hzalaz","html_url":"https://github.com/hzalaz","followers_url":"https://api.github.com/users/hzalaz/followers","following_url":"https://api.github.com/users/hzalaz/following{/other_user}","gists_url":"https://api.github.com/users/hzalaz/gists{/gist_id}","starred_url":"https://api.github.com/users/hzalaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzalaz/subscriptions","organizations_url":"https://api.github.com/users/hzalaz/orgs","repos_url":"https://api.github.com/users/hzalaz/repos","events_url":"https://api.github.com/users/hzalaz/events{/privacy}","received_events_url":"https://api.github.com/users/hzalaz/received_events","type":"User","site_admin":false},"body":"I am not convinced we should add this flag, the worst case scenario is that you'll dismiss a VC that is presented from the rootViewController of the window if Lock is not displayed (which should be strange). So I'd rather remove this flag and just dismiss the presented VC.","created_at":"2016-01-20T22:14:35Z","updated_at":"2016-01-20T22:14:35Z","html_url":"https://github.com/auth0/react-native-lock-ios/pull/10#discussion_r50328493","pull_request_url":"https://api.github.com/repos/auth0/react-native-lock-ios/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/auth0/react-native-lock-ios/pulls/comments/50328493"},"html":{"href":"https://github.com/auth0/react-native-lock-ios/pull/10#discussion_r50328493"},"pull_request":{"href":"https://api.github.com/repos/auth0/react-native-lock-ios/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/auth0/react-native-lock-ios/pulls/10","id":56672985,"html_url":"https://github.com/auth0/react-native-lock-ios/pull/10","diff_url":"https://github.com/auth0/react-native-lock-ios/pull/10.diff","patch_url":"https://github.com/auth0/react-native-lock-ios/pull/10.patch","issue_url":"https://api.github.com/repos/auth0/react-native-lock-ios/issues/10","number":10,"state":"open","locked":false,"title":"Add hide method to react-native-lock-ios","user":{"login":"brianneisler","id":1471972,"avatar_url":"https://avatars.githubusercontent.com/u/1471972?v=3","gravatar_id":"","url":"https://api.github.com/users/brianneisler","html_url":"https://github.com/brianneisler","followers_url":"https://api.github.com/users/brianneisler/followers","following_url":"https://api.github.com/users/brianneisler/following{/other_user}","gists_url":"https://api.github.com/users/brianneisler/gists{/gist_id}","starred_url":"https://api.github.com/users/brianneisler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianneisler/subscriptions","organizations_url":"https://api.github.com/users/brianneisler/orgs","repos_url":"https://api.github.com/users/brianneisler/repos","events_url":"https://api.github.com/users/brianneisler/events{/privacy}","received_events_url":"https://api.github.com/users/brianneisler/received_events","type":"User","site_admin":false},"body":"Adds hide method to react-native-lock-ios. Api is same as generic auth0 lock api.","created_at":"2016-01-20T21:54:00Z","updated_at":"2016-01-20T22:14:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de8066be1a6186cf1167078ecec4adff9745b08b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/auth0/react-native-lock-ios/pulls/10/commits","review_comments_url":"https://api.github.com/repos/auth0/react-native-lock-ios/pulls/10/comments","review_comment_url":"https://api.github.com/repos/auth0/react-native-lock-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/auth0/react-native-lock-ios/issues/10/comments","statuses_url":"https://api.github.com/repos/auth0/react-native-lock-ios/statuses/48637e05b6ed576ea116b6a18c5f586fcfbcd303","head":{"label":"sprightco:hide","ref":"hide","sha":"48637e05b6ed576ea116b6a18c5f586fcfbcd303","user":{"login":"sprightco","id":10040679,"avatar_url":"https://avatars.githubusercontent.com/u/10040679?v=3","gravatar_id":"","url":"https://api.github.com/users/sprightco","html_url":"https://github.com/sprightco","followers_url":"https://api.github.com/users/sprightco/followers","following_url":"https://api.github.com/users/sprightco/following{/other_user}","gists_url":"https://api.github.com/users/sprightco/gists{/gist_id}","starred_url":"https://api.github.com/users/sprightco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sprightco/subscriptions","organizations_url":"https://api.github.com/users/sprightco/orgs","repos_url":"https://api.github.com/users/sprightco/repos","events_url":"https://api.github.com/users/sprightco/events{/privacy}","received_events_url":"https://api.github.com/users/sprightco/received_events","type":"Organization","site_admin":false},"repo":{"id":47178642,"name":"react-native-lock-ios","full_name":"sprightco/react-native-lock-ios","owner":{"login":"sprightco","id":10040679,"avatar_url":"https://avatars.githubusercontent.com/u/10040679?v=3","gravatar_id":"","url":"https://api.github.com/users/sprightco","html_url":"https://github.com/sprightco","followers_url":"https://api.github.com/users/sprightco/followers","following_url":"https://api.github.com/users/sprightco/following{/other_user}","gists_url":"https://api.github.com/users/sprightco/gists{/gist_id}","starred_url":"https://api.github.com/users/sprightco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sprightco/subscriptions","organizations_url":"https://api.github.com/users/sprightco/orgs","repos_url":"https://api.github.com/users/sprightco/repos","events_url":"https://api.github.com/users/sprightco/events{/privacy}","received_events_url":"https://api.github.com/users/sprightco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sprightco/react-native-lock-ios","description":"A wrapper of Lock for iOS to use with React Native","fork":true,"url":"https://api.github.com/repos/sprightco/react-native-lock-ios","forks_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/forks","keys_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/teams","hooks_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/hooks","issue_events_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/issues/events{/number}","events_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/events","assignees_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/assignees{/user}","branches_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/branches{/branch}","tags_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/tags","blobs_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/languages","stargazers_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/stargazers","contributors_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/contributors","subscribers_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/subscribers","subscription_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/subscription","commits_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/contents/{+path}","compare_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/merges","archive_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/downloads","issues_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/issues{/number}","pulls_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/labels{/name}","releases_url":"https://api.github.com/repos/sprightco/react-native-lock-ios/releases{/id}","created_at":"2015-12-01T09:18:01Z","updated_at":"2016-01-19T21:28:09Z","pushed_at":"2016-01-20T22:12:14Z","git_url":"git://github.com/sprightco/react-native-lock-ios.git","ssh_url":"git@github.com:sprightco/react-native-lock-ios.git","clone_url":"https://github.com/sprightco/react-native-lock-ios.git","svn_url":"https://github.com/sprightco/react-native-lock-ios","homepage":"https://auth0.com/docs","size":49,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"auth0:master","ref":"master","sha":"0d81dcb66524146413a0831d190b957b5d0d60c9","user":{"login":"auth0","id":2824157,"avatar_url":"https://avatars.githubusercontent.com/u/2824157?v=3","gravatar_id":"","url":"https://api.github.com/users/auth0","html_url":"https://github.com/auth0","followers_url":"https://api.github.com/users/auth0/followers","following_url":"https://api.github.com/users/auth0/following{/other_user}","gists_url":"https://api.github.com/users/auth0/gists{/gist_id}","starred_url":"https://api.github.com/users/auth0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auth0/subscriptions","organizations_url":"https://api.github.com/users/auth0/orgs","repos_url":"https://api.github.com/users/auth0/repos","events_url":"https://api.github.com/users/auth0/events{/privacy}","received_events_url":"https://api.github.com/users/auth0/received_events","type":"Organization","site_admin":false},"repo":{"id":45700808,"name":"react-native-lock-ios","full_name":"auth0/react-native-lock-ios","owner":{"login":"auth0","id":2824157,"avatar_url":"https://avatars.githubusercontent.com/u/2824157?v=3","gravatar_id":"","url":"https://api.github.com/users/auth0","html_url":"https://github.com/auth0","followers_url":"https://api.github.com/users/auth0/followers","following_url":"https://api.github.com/users/auth0/following{/other_user}","gists_url":"https://api.github.com/users/auth0/gists{/gist_id}","starred_url":"https://api.github.com/users/auth0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auth0/subscriptions","organizations_url":"https://api.github.com/users/auth0/orgs","repos_url":"https://api.github.com/users/auth0/repos","events_url":"https://api.github.com/users/auth0/events{/privacy}","received_events_url":"https://api.github.com/users/auth0/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/auth0/react-native-lock-ios","description":"A wrapper of Lock for iOS to use with React Native","fork":false,"url":"https://api.github.com/repos/auth0/react-native-lock-ios","forks_url":"https://api.github.com/repos/auth0/react-native-lock-ios/forks","keys_url":"https://api.github.com/repos/auth0/react-native-lock-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/auth0/react-native-lock-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/auth0/react-native-lock-ios/teams","hooks_url":"https://api.github.com/repos/auth0/react-native-lock-ios/hooks","issue_events_url":"https://api.github.com/repos/auth0/react-native-lock-ios/issues/events{/number}","events_url":"https://api.github.com/repos/auth0/react-native-lock-ios/events","assignees_url":"https://api.github.com/repos/auth0/react-native-lock-ios/assignees{/user}","branches_url":"https://api.github.com/repos/auth0/react-native-lock-ios/branches{/branch}","tags_url":"https://api.github.com/repos/auth0/react-native-lock-ios/tags","blobs_url":"https://api.github.com/repos/auth0/react-native-lock-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/auth0/react-native-lock-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/auth0/react-native-lock-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/auth0/react-native-lock-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/auth0/react-native-lock-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/auth0/react-native-lock-ios/languages","stargazers_url":"https://api.github.com/repos/auth0/react-native-lock-ios/stargazers","contributors_url":"https://api.github.com/repos/auth0/react-native-lock-ios/contributors","subscribers_url":"https://api.github.com/repos/auth0/react-native-lock-ios/subscribers","subscription_url":"https://api.github.com/repos/auth0/react-native-lock-ios/subscription","commits_url":"https://api.github.com/repos/auth0/react-native-lock-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/auth0/react-native-lock-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/auth0/react-native-lock-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/auth0/react-native-lock-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/auth0/react-native-lock-ios/contents/{+path}","compare_url":"https://api.github.com/repos/auth0/react-native-lock-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/auth0/react-native-lock-ios/merges","archive_url":"https://api.github.com/repos/auth0/react-native-lock-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/auth0/react-native-lock-ios/downloads","issues_url":"https://api.github.com/repos/auth0/react-native-lock-ios/issues{/number}","pulls_url":"https://api.github.com/repos/auth0/react-native-lock-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/auth0/react-native-lock-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/auth0/react-native-lock-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/auth0/react-native-lock-ios/labels{/name}","releases_url":"https://api.github.com/repos/auth0/react-native-lock-ios/releases{/id}","created_at":"2015-11-06T18:51:41Z","updated_at":"2016-01-19T09:15:04Z","pushed_at":"2016-01-20T22:09:36Z","git_url":"git://github.com/auth0/react-native-lock-ios.git","ssh_url":"git@github.com:auth0/react-native-lock-ios.git","clone_url":"https://github.com/auth0/react-native-lock-ios.git","svn_url":"https://github.com/auth0/react-native-lock-ios","homepage":"https://auth0.com/docs","size":49,"stargazers_count":26,"watchers_count":26,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":5,"forks":3,"open_issues":5,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/auth0/react-native-lock-ios/pulls/10"},"html":{"href":"https://github.com/auth0/react-native-lock-ios/pull/10"},"issue":{"href":"https://api.github.com/repos/auth0/react-native-lock-ios/issues/10"},"comments":{"href":"https://api.github.com/repos/auth0/react-native-lock-ios/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/auth0/react-native-lock-ios/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/auth0/react-native-lock-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/auth0/react-native-lock-ios/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/auth0/react-native-lock-ios/statuses/48637e05b6ed576ea116b6a18c5f586fcfbcd303"}}}}