{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/74943246","id":74943246,"diff_hunk":"@@ -0,0 +1,2 @@\n+[Format]\n+max-line-length=80","path":".pylintrc","position":2,"original_position":2,"commit_id":"d6ec1f8b01e562286c067b7d656c937a62894cc9","original_commit_id":"8d48f0f916b0a912da3149ce207c0428c19ede1a","user":{"login":"bogdanm","id":211717,"avatar_url":"https://avatars.githubusercontent.com/u/211717?v=3","gravatar_id":"","url":"https://api.github.com/users/bogdanm","html_url":"https://github.com/bogdanm","followers_url":"https://api.github.com/users/bogdanm/followers","following_url":"https://api.github.com/users/bogdanm/following{/other_user}","gists_url":"https://api.github.com/users/bogdanm/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdanm/subscriptions","organizations_url":"https://api.github.com/users/bogdanm/orgs","repos_url":"https://api.github.com/users/bogdanm/repos","events_url":"https://api.github.com/users/bogdanm/events{/privacy}","received_events_url":"https://api.github.com/users/bogdanm/received_events","type":"User","site_admin":false},"body":"Again, as an observation, I would be really, really unhappy if I was asked to have 8.5/10 on pylint in order to be able to contribute to mbed-os. A lot of pylint rules are pseudo-arbitrary at best. I believe it's a really bad idea to add this restriction.","created_at":"2016-08-16T14:17:47Z","updated_at":"2016-08-16T14:17:47Z","html_url":"https://github.com/ARMmbed/mbed-os/pull/2458#discussion_r74943246","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/2458","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/74943246"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/2458#discussion_r74943246"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/2458"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/2458","id":81385684,"html_url":"https://github.com/ARMmbed/mbed-os/pull/2458","diff_url":"https://github.com/ARMmbed/mbed-os/pull/2458.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/2458.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/2458","number":2458,"state":"open","locked":false,"title":"[tools!] Pylint checking and formatting","user":{"login":"theotherjimmy","id":685409,"avatar_url":"https://avatars.githubusercontent.com/u/685409?v=3","gravatar_id":"","url":"https://api.github.com/users/theotherjimmy","html_url":"https://github.com/theotherjimmy","followers_url":"https://api.github.com/users/theotherjimmy/followers","following_url":"https://api.github.com/users/theotherjimmy/following{/other_user}","gists_url":"https://api.github.com/users/theotherjimmy/gists{/gist_id}","starred_url":"https://api.github.com/users/theotherjimmy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theotherjimmy/subscriptions","organizations_url":"https://api.github.com/users/theotherjimmy/orgs","repos_url":"https://api.github.com/users/theotherjimmy/repos","events_url":"https://api.github.com/users/theotherjimmy/events{/privacy}","received_events_url":"https://api.github.com/users/theotherjimmy/received_events","type":"User","site_admin":false},"body":"So, this is a big one. I added pylint checking to the CI for a large number of the python modules that are part of the tools, and made all of them \"pass\" with an 8.5 or above.","created_at":"2016-08-15T22:22:06Z","updated_at":"2016-08-16T14:17:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"207246449d1889fad161fec1c426ac63d6bac785","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/2458/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/2458/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/2458/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/d6ec1f8b01e562286c067b7d656c937a62894cc9","head":{"label":"theotherjimmy:pylint","ref":"pylint","sha":"d6ec1f8b01e562286c067b7d656c937a62894cc9","user":{"login":"theotherjimmy","id":685409,"avatar_url":"https://avatars.githubusercontent.com/u/685409?v=3","gravatar_id":"","url":"https://api.github.com/users/theotherjimmy","html_url":"https://github.com/theotherjimmy","followers_url":"https://api.github.com/users/theotherjimmy/followers","following_url":"https://api.github.com/users/theotherjimmy/following{/other_user}","gists_url":"https://api.github.com/users/theotherjimmy/gists{/gist_id}","starred_url":"https://api.github.com/users/theotherjimmy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theotherjimmy/subscriptions","organizations_url":"https://api.github.com/users/theotherjimmy/orgs","repos_url":"https://api.github.com/users/theotherjimmy/repos","events_url":"https://api.github.com/users/theotherjimmy/events{/privacy}","received_events_url":"https://api.github.com/users/theotherjimmy/received_events","type":"User","site_admin":false},"repo":{"id":59587271,"name":"mbed","full_name":"theotherjimmy/mbed","owner":{"login":"theotherjimmy","id":685409,"avatar_url":"https://avatars.githubusercontent.com/u/685409?v=3","gravatar_id":"","url":"https://api.github.com/users/theotherjimmy","html_url":"https://github.com/theotherjimmy","followers_url":"https://api.github.com/users/theotherjimmy/followers","following_url":"https://api.github.com/users/theotherjimmy/following{/other_user}","gists_url":"https://api.github.com/users/theotherjimmy/gists{/gist_id}","starred_url":"https://api.github.com/users/theotherjimmy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theotherjimmy/subscriptions","organizations_url":"https://api.github.com/users/theotherjimmy/orgs","repos_url":"https://api.github.com/users/theotherjimmy/repos","events_url":"https://api.github.com/users/theotherjimmy/events{/privacy}","received_events_url":"https://api.github.com/users/theotherjimmy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/theotherjimmy/mbed","description":"mbed libraries and tools (Classic). For mbed OS, look here: https://www.mbed.com/en/development/software/mbed-os/","fork":true,"url":"https://api.github.com/repos/theotherjimmy/mbed","forks_url":"https://api.github.com/repos/theotherjimmy/mbed/forks","keys_url":"https://api.github.com/repos/theotherjimmy/mbed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theotherjimmy/mbed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theotherjimmy/mbed/teams","hooks_url":"https://api.github.com/repos/theotherjimmy/mbed/hooks","issue_events_url":"https://api.github.com/repos/theotherjimmy/mbed/issues/events{/number}","events_url":"https://api.github.com/repos/theotherjimmy/mbed/events","assignees_url":"https://api.github.com/repos/theotherjimmy/mbed/assignees{/user}","branches_url":"https://api.github.com/repos/theotherjimmy/mbed/branches{/branch}","tags_url":"https://api.github.com/repos/theotherjimmy/mbed/tags","blobs_url":"https://api.github.com/repos/theotherjimmy/mbed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theotherjimmy/mbed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theotherjimmy/mbed/git/refs{/sha}","trees_url":"https://api.github.com/repos/theotherjimmy/mbed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theotherjimmy/mbed/statuses/{sha}","languages_url":"https://api.github.com/repos/theotherjimmy/mbed/languages","stargazers_url":"https://api.github.com/repos/theotherjimmy/mbed/stargazers","contributors_url":"https://api.github.com/repos/theotherjimmy/mbed/contributors","subscribers_url":"https://api.github.com/repos/theotherjimmy/mbed/subscribers","subscription_url":"https://api.github.com/repos/theotherjimmy/mbed/subscription","commits_url":"https://api.github.com/repos/theotherjimmy/mbed/commits{/sha}","git_commits_url":"https://api.github.com/repos/theotherjimmy/mbed/git/commits{/sha}","comments_url":"https://api.github.com/repos/theotherjimmy/mbed/comments{/number}","issue_comment_url":"https://api.github.com/repos/theotherjimmy/mbed/issues/comments{/number}","contents_url":"https://api.github.com/repos/theotherjimmy/mbed/contents/{+path}","compare_url":"https://api.github.com/repos/theotherjimmy/mbed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theotherjimmy/mbed/merges","archive_url":"https://api.github.com/repos/theotherjimmy/mbed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theotherjimmy/mbed/downloads","issues_url":"https://api.github.com/repos/theotherjimmy/mbed/issues{/number}","pulls_url":"https://api.github.com/repos/theotherjimmy/mbed/pulls{/number}","milestones_url":"https://api.github.com/repos/theotherjimmy/mbed/milestones{/number}","notifications_url":"https://api.github.com/repos/theotherjimmy/mbed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theotherjimmy/mbed/labels{/name}","releases_url":"https://api.github.com/repos/theotherjimmy/mbed/releases{/id}","deployments_url":"https://api.github.com/repos/theotherjimmy/mbed/deployments","created_at":"2016-05-24T15:53:58Z","updated_at":"2016-05-24T15:54:55Z","pushed_at":"2016-08-16T14:05:22Z","git_url":"git://github.com/theotherjimmy/mbed.git","ssh_url":"git@github.com:theotherjimmy/mbed.git","clone_url":"https://github.com/theotherjimmy/mbed.git","svn_url":"https://github.com/theotherjimmy/mbed","homepage":"","size":60652,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"8d368775e32ac6405f434857e206f5cd87f1f3fe","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":8270972,"name":"mbed-os","full_name":"ARMmbed/mbed-os","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbed-os","description":"ARM mbed OS is a platform operating system designed for the internet of things","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-os","forks_url":"https://api.github.com/repos/ARMmbed/mbed-os/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-os/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-os/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-os/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-os/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-os/deployments","created_at":"2013-02-18T15:23:11Z","updated_at":"2016-08-16T02:36:01Z","pushed_at":"2016-08-16T14:10:55Z","git_url":"git://github.com/ARMmbed/mbed-os.git","ssh_url":"git@github.com:ARMmbed/mbed-os.git","clone_url":"https://github.com/ARMmbed/mbed-os.git","svn_url":"https://github.com/ARMmbed/mbed-os","homepage":"https://mbed.com","size":71618,"stargazers_count":718,"watchers_count":718,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":707,"mirror_url":null,"open_issues_count":331,"forks":707,"open_issues":331,"watchers":718,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/2458"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/2458"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/2458"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/2458/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/2458/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/2458/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/d6ec1f8b01e562286c067b7d656c937a62894cc9"}}}}
{"actor":{"display_login":"bogdanm"}}