{"action":"created","issue":{"url":"https://api.github.com/repos/developersdo/empleo-dot-net/issues/252","repository_url":"https://api.github.com/repos/developersdo/empleo-dot-net","labels_url":"https://api.github.com/repos/developersdo/empleo-dot-net/issues/252/labels{/name}","comments_url":"https://api.github.com/repos/developersdo/empleo-dot-net/issues/252/comments","events_url":"https://api.github.com/repos/developersdo/empleo-dot-net/issues/252/events","html_url":"https://github.com/developersdo/empleo-dot-net/pull/252","id":133270113,"number":252,"title":"Soft Delete Job Opportunity","user":{"login":"luis-ramirez","id":6517152,"avatar_url":"https://avatars.githubusercontent.com/u/6517152?v=3","gravatar_id":"","url":"https://api.github.com/users/luis-ramirez","html_url":"https://github.com/luis-ramirez","followers_url":"https://api.github.com/users/luis-ramirez/followers","following_url":"https://api.github.com/users/luis-ramirez/following{/other_user}","gists_url":"https://api.github.com/users/luis-ramirez/gists{/gist_id}","starred_url":"https://api.github.com/users/luis-ramirez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luis-ramirez/subscriptions","organizations_url":"https://api.github.com/users/luis-ramirez/orgs","repos_url":"https://api.github.com/users/luis-ramirez/repos","events_url":"https://api.github.com/users/luis-ramirez/events{/privacy}","received_events_url":"https://api.github.com/users/luis-ramirez/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-02-12T15:33:17Z","updated_at":"2016-02-15T19:52:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/developersdo/empleo-dot-net/pulls/252","html_url":"https://github.com/developersdo/empleo-dot-net/pull/252","diff_url":"https://github.com/developersdo/empleo-dot-net/pull/252.diff","patch_url":"https://github.com/developersdo/empleo-dot-net/pull/252.patch"},"body":"### What's New\r\n\r\n- Resolved Issue #248 \r\n\r\n- Added IsActive column to JobOpportunity to enable Soft-Delete\r\n\r\n- Implement EF Interceptor to handle all querys related to IsActive column\r\n\r\n- References\r\n\t[StackOverflow Post](http://stackoverflow.com/questions/29377494/learning-entity-framework-6-command-tree-interceptors)\r\n\t[Channel9 Video](https://channel9.msdn.com/Events/TechEd/NorthAmerica/2014/DEV-B417#fbid=)"},"comment":{"url":"https://api.github.com/repos/developersdo/empleo-dot-net/issues/comments/184362459","html_url":"https://github.com/developersdo/empleo-dot-net/pull/252#issuecomment-184362459","issue_url":"https://api.github.com/repos/developersdo/empleo-dot-net/issues/252","id":184362459,"user":{"login":"EfrainReyes","id":3720319,"avatar_url":"https://avatars.githubusercontent.com/u/3720319?v=3","gravatar_id":"","url":"https://api.github.com/users/EfrainReyes","html_url":"https://github.com/EfrainReyes","followers_url":"https://api.github.com/users/EfrainReyes/followers","following_url":"https://api.github.com/users/EfrainReyes/following{/other_user}","gists_url":"https://api.github.com/users/EfrainReyes/gists{/gist_id}","starred_url":"https://api.github.com/users/EfrainReyes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EfrainReyes/subscriptions","organizations_url":"https://api.github.com/users/EfrainReyes/orgs","repos_url":"https://api.github.com/users/EfrainReyes/repos","events_url":"https://api.github.com/users/EfrainReyes/events{/privacy}","received_events_url":"https://api.github.com/users/EfrainReyes/received_events","type":"User","site_admin":false},"created_at":"2016-02-15T19:52:59Z","updated_at":"2016-02-15T19:52:59Z","body":"Para cosas como estas es que uno debe tener una suite de unit tests, para que cuando haya cambios así no haya que probar las cosas una a una.\r\n\r\nEn fin, es correcto que esto mitiga el problema actual (i.e. resuelve), pero a largo plazo deberíamos discutir si esa solución es viable, ya que hay múltiples escenarios posibles donde pudiéramos querer los applicants inactivos, que pueden ser entorpecidos por filtrarlos a nivel del ORM, pero que serían features a más largo plazo:\r\n\r\n- Count del número total de trabajos que una compañía ha colocado.\r\n- Cuando tengamos perfiles de usuario, que una compañía (o un admin user) pueda ver todos los trabajos que ha publicado, incluyendo los eliminados, y restaurarlos (o por lo menos ver el texto para crear una nueva vacante) si así lo desea.\r\n\r\nY en caso de que decidamos al final si tumbamos el interceptor, el esfuerzo no será mayor que remover algunas líneas de código y cambiar otras (asumiendo que para ese entonces tengamos tests listos para los repos).\r\n\r\n+1"}}