{"action":"created","issue":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4982","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4982/labels{/name}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4982/comments","events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4982/events","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/4982","id":128691630,"number":4982,"title":"BUG Fix regressions in #4873","user":{"login":"tractorcow","id":936064,"avatar_url":"https://avatars.githubusercontent.com/u/936064?v=3","gravatar_id":"","url":"https://api.github.com/users/tractorcow","html_url":"https://github.com/tractorcow","followers_url":"https://api.github.com/users/tractorcow/followers","following_url":"https://api.github.com/users/tractorcow/following{/other_user}","gists_url":"https://api.github.com/users/tractorcow/gists{/gist_id}","starred_url":"https://api.github.com/users/tractorcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tractorcow/subscriptions","organizations_url":"https://api.github.com/users/tractorcow/orgs","repos_url":"https://api.github.com/users/tractorcow/repos","events_url":"https://api.github.com/users/tractorcow/events{/privacy}","received_events_url":"https://api.github.com/users/tractorcow/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/milestones/29","html_url":"https://github.com/silverstripe/silverstripe-framework/milestones/3.4.0","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/milestones/29/labels","id":1472109,"number":29,"title":"3.4.0","description":"","creator":{"login":"tractorcow","id":936064,"avatar_url":"https://avatars.githubusercontent.com/u/936064?v=3","gravatar_id":"","url":"https://api.github.com/users/tractorcow","html_url":"https://github.com/tractorcow","followers_url":"https://api.github.com/users/tractorcow/followers","following_url":"https://api.github.com/users/tractorcow/following{/other_user}","gists_url":"https://api.github.com/users/tractorcow/gists{/gist_id}","starred_url":"https://api.github.com/users/tractorcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tractorcow/subscriptions","organizations_url":"https://api.github.com/users/tractorcow/orgs","repos_url":"https://api.github.com/users/tractorcow/repos","events_url":"https://api.github.com/users/tractorcow/events{/privacy}","received_events_url":"https://api.github.com/users/tractorcow/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":4,"state":"open","created_at":"2015-12-23T01:59:08Z","updated_at":"2016-01-26T20:47:57Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-01-26T01:27:15Z","updated_at":"2016-01-26T23:04:07Z","closed_at":"2016-01-26T20:47:32Z","pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4982","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/4982","diff_url":"https://github.com/silverstripe/silverstripe-framework/pull/4982.diff","patch_url":"https://github.com/silverstripe/silverstripe-framework/pull/4982.patch"},"body":"See  https://github.com/silverstripe/silverstripe-framework/pull/4873\r\n\r\nPreviously, it did nothing. However, with the prior fix, suddenly extra classes popped up in places which broke certain layouts.\r\n\r\nThis fix reverts the method so that the old undesirable behaviour remains ONLY in the deprecated method."},"comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/comments/175284542","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/4982#issuecomment-175284542","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4982","id":175284542,"user":{"login":"dhensby","id":563596,"avatar_url":"https://avatars.githubusercontent.com/u/563596?v=3","gravatar_id":"","url":"https://api.github.com/users/dhensby","html_url":"https://github.com/dhensby","followers_url":"https://api.github.com/users/dhensby/followers","following_url":"https://api.github.com/users/dhensby/following{/other_user}","gists_url":"https://api.github.com/users/dhensby/gists{/gist_id}","starred_url":"https://api.github.com/users/dhensby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhensby/subscriptions","organizations_url":"https://api.github.com/users/dhensby/orgs","repos_url":"https://api.github.com/users/dhensby/repos","events_url":"https://api.github.com/users/dhensby/events{/privacy}","received_events_url":"https://api.github.com/users/dhensby/received_events","type":"User","site_admin":false},"created_at":"2016-01-26T23:04:07Z","updated_at":"2016-01-26T23:04:07Z","body":"> E.g. 'field' and 'CompositeField' classes should not suddenly be appearing in the HTML. In 4.0 I'll drop that method, and eradicate them altogether.\r\n\r\nI agree - I dislike this incredibly - but it should be consistently terrible - let's get rid of it ASAP"}}