{"action":"created","issue":{"url":"https://api.github.com/repos/pypa/pip/issues/3806","repository_url":"https://api.github.com/repos/pypa/pip","labels_url":"https://api.github.com/repos/pypa/pip/issues/3806/labels{/name}","comments_url":"https://api.github.com/repos/pypa/pip/issues/3806/comments","events_url":"https://api.github.com/repos/pypa/pip/issues/3806/events","html_url":"https://github.com/pypa/pip/pull/3806","id":161407027,"number":3806,"title":"Change install command's default behaviour to upgrade packages by default","user":{"login":"pradyunsg","id":3275593,"avatar_url":"https://avatars.githubusercontent.com/u/3275593?v=3","gravatar_id":"","url":"https://api.github.com/users/pradyunsg","html_url":"https://github.com/pradyunsg","followers_url":"https://api.github.com/users/pradyunsg/followers","following_url":"https://api.github.com/users/pradyunsg/following{/other_user}","gists_url":"https://api.github.com/users/pradyunsg/gists{/gist_id}","starred_url":"https://api.github.com/users/pradyunsg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pradyunsg/subscriptions","organizations_url":"https://api.github.com/users/pradyunsg/orgs","repos_url":"https://api.github.com/users/pradyunsg/repos","events_url":"https://api.github.com/users/pradyunsg/events{/privacy}","received_events_url":"https://api.github.com/users/pradyunsg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-06-21T10:58:39Z","updated_at":"2016-06-23T18:33:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pypa/pip/pulls/3806","html_url":"https://github.com/pypa/pip/pull/3806","diff_url":"https://github.com/pypa/pip/pull/3806.diff","patch_url":"https://github.com/pypa/pip/pull/3806.patch"},"body":"Resolves #3786.\r\n\r\nCheck-list:\r\n - [x] Hand-tested implementation.\r\n   - [x] Implement a resolution to the `--target` problem\r\n - [x] Update tests.\r\n - [x] Update documentation.\r\n - [x] Revisit the write-up written for issue 59 to update it with what has been implemented.\r\n - [x] Request code review and peer testing.\r\n - [ ] Shout out on distutils-sig for views/comments.\r\n - [ ] Resolve any new issues that come up.\r\n   - [x] Fix test failure caused by change in PyPI.\r\n       - [x] Rebase this work off the master once the fix merges."},"comment":{"url":"https://api.github.com/repos/pypa/pip/issues/comments/228142738","html_url":"https://github.com/pypa/pip/pull/3806#issuecomment-228142738","issue_url":"https://api.github.com/repos/pypa/pip/issues/3806","id":228142738,"user":{"login":"njsmith","id":609896,"avatar_url":"https://avatars.githubusercontent.com/u/609896?v=3","gravatar_id":"","url":"https://api.github.com/users/njsmith","html_url":"https://github.com/njsmith","followers_url":"https://api.github.com/users/njsmith/followers","following_url":"https://api.github.com/users/njsmith/following{/other_user}","gists_url":"https://api.github.com/users/njsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/njsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njsmith/subscriptions","organizations_url":"https://api.github.com/users/njsmith/orgs","repos_url":"https://api.github.com/users/njsmith/repos","events_url":"https://api.github.com/users/njsmith/events{/privacy}","received_events_url":"https://api.github.com/users/njsmith/received_events","type":"User","site_admin":false},"created_at":"2016-06-23T18:33:56Z","updated_at":"2016-06-23T18:33:56Z","body":"In addition to my line comments above:\r\n* There should probably be a test that checks that passing `--upgrade` and `-U` is legal.\r\n* From one of the tests, I got the impression that you might have changed the behavior of `pip install <URL>` and `pip install <PATH>` so that they always reinstall, even if a nominally identical package is already installed. I think this is a *great* idea if so, but it's a behavior change that wasn't discussed in this thread before and has been somewhat controversial in the past, so I wanted to check. (a) is this true? (b) if so it needs to be mentioned in the release notes as a separate change.\r\n\r\nI think that's everything -- overall it looks pretty good to me (though it would probably be good to get a quick pass over the core logic by someone who is more familiar with pip's core requirement logic). And thanks so much for pushing this forward!"}}
{"actor":{"display_login":"njsmith"}}