{"action":"created","issue":{"url":"https://api.github.com/repos/sinonjs/sinon-test/issues/7","repository_url":"https://api.github.com/repos/sinonjs/sinon-test","labels_url":"https://api.github.com/repos/sinonjs/sinon-test/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/sinonjs/sinon-test/issues/7/comments","events_url":"https://api.github.com/repos/sinonjs/sinon-test/issues/7/events","html_url":"https://github.com/sinonjs/sinon-test/pull/7","id":144773919,"number":7,"title":"delay sandbox restoration until promise resolution when wrapped returns promise","user":{"login":"shaunc","id":193170,"avatar_url":"https://avatars.githubusercontent.com/u/193170?v=3","gravatar_id":"","url":"https://api.github.com/users/shaunc","html_url":"https://github.com/shaunc","followers_url":"https://api.github.com/users/shaunc/followers","following_url":"https://api.github.com/users/shaunc/following{/other_user}","gists_url":"https://api.github.com/users/shaunc/gists{/gist_id}","starred_url":"https://api.github.com/users/shaunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaunc/subscriptions","organizations_url":"https://api.github.com/users/shaunc/orgs","repos_url":"https://api.github.com/users/shaunc/repos","events_url":"https://api.github.com/users/shaunc/events{/privacy}","received_events_url":"https://api.github.com/users/shaunc/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-03-31T02:51:04Z","updated_at":"2016-09-12T18:33:51Z","closed_at":"2016-04-16T06:16:14Z","pull_request":{"url":"https://api.github.com/repos/sinonjs/sinon-test/pulls/7","html_url":"https://github.com/sinonjs/sinon-test/pull/7","diff_url":"https://github.com/sinonjs/sinon-test/pull/7.diff","patch_url":"https://github.com/sinonjs/sinon-test/pull/7.patch"},"body":"For https://github.com/sinonjs/sinon-test/issues/6.\r\n\r\nThe test works in node. Unfortunately I am not very familiar with browserify & buster, and the test doesn't work properly there: it doesn't seem to progress on the async promise.\r\n\r\nThus this is not actually ready to go, but you may be able to tell me how to fix it pretty easily."},"comment":{"url":"https://api.github.com/repos/sinonjs/sinon-test/issues/comments/246446031","html_url":"https://github.com/sinonjs/sinon-test/pull/7#issuecomment-246446031","issue_url":"https://api.github.com/repos/sinonjs/sinon-test/issues/7","id":246446031,"user":{"login":"fearphage","id":23887,"avatar_url":"https://avatars.githubusercontent.com/u/23887?v=3","gravatar_id":"","url":"https://api.github.com/users/fearphage","html_url":"https://github.com/fearphage","followers_url":"https://api.github.com/users/fearphage/followers","following_url":"https://api.github.com/users/fearphage/following{/other_user}","gists_url":"https://api.github.com/users/fearphage/gists{/gist_id}","starred_url":"https://api.github.com/users/fearphage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fearphage/subscriptions","organizations_url":"https://api.github.com/users/fearphage/orgs","repos_url":"https://api.github.com/users/fearphage/repos","events_url":"https://api.github.com/users/fearphage/events{/privacy}","received_events_url":"https://api.github.com/users/fearphage/received_events","type":"User","site_admin":false},"created_at":"2016-09-12T18:33:50Z","updated_at":"2016-09-12T18:33:50Z","body":"FYI convert to mocha:\r\n\r\n```shell\r\nsed -i '\r\n    s/setUp:/beforeEach:/g; \r\n    s/tearDown:/afterEach:/g; \r\n    s/^});/};/; \r\n    s/^buster.testCase.*/module.exports = {/;' test/test-test.js \\\r\n  && npm install mocha \\\r\n  && mocha --ui exports test/test-test.js\r\n```\r\n\r\nThe other test file requires some manual interaction due to using those keywords in mock objects. \r\n\r\nSide note: I'm seeing the mocha test fail just like my local v1.17 tests. However buster tests pass. I can't make sense of it."}}
{"actor":{"display_login":"fearphage"}}