{"action":"closed","number":9658,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/9658","id":83210955,"html_url":"https://github.com/facebook/react-native/pull/9658","diff_url":"https://github.com/facebook/react-native/pull/9658.diff","patch_url":"https://github.com/facebook/react-native/pull/9658.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/9658","number":9658,"state":"closed","locked":false,"title":"Android: Add support for having borders on <Text> & <TextInput> components","user":{"login":"rigdern","id":199935,"avatar_url":"https://avatars.githubusercontent.com/u/199935?v=3","gravatar_id":"","url":"https://api.github.com/users/rigdern","html_url":"https://github.com/rigdern","followers_url":"https://api.github.com/users/rigdern/followers","following_url":"https://api.github.com/users/rigdern/following{/other_user}","gists_url":"https://api.github.com/users/rigdern/gists{/gist_id}","starred_url":"https://api.github.com/users/rigdern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigdern/subscriptions","organizations_url":"https://api.github.com/users/rigdern/orgs","repos_url":"https://api.github.com/users/rigdern/repos","events_url":"https://api.github.com/users/rigdern/events{/privacy}","received_events_url":"https://api.github.com/users/rigdern/received_events","type":"User","site_admin":false},"body":"Currently, `<Text>` and `<TextInput>` components on Android do not support borders.\r\nThis change adds support for the borderRadius, borderColor, and\r\nborderWidth props on the `<Text>` and `<TextInput>` components on Android.\r\n\r\nReactViewGroup already implements this functionality so\r\nwe copied its implementation over into the ReactTextView\r\nand ReactEditText classes.\r\n\r\n**Test plan (required)**\r\n\r\nVerified that the various border props work on Text and TextInput components in a test app.\r\n\r\nAdam Comella\r\nMicrosoft Corp.","created_at":"2016-08-30T05:37:18Z","updated_at":"2016-09-08T09:59:03Z","closed_at":"2016-09-08T09:59:03Z","merged_at":null,"merge_commit_sha":"168a6743a5a6a9c196cbe77e056ab3296d1cd4dc","assignee":{"login":"andreicoman11","id":6615092,"avatar_url":"https://avatars.githubusercontent.com/u/6615092?v=3","gravatar_id":"","url":"https://api.github.com/users/andreicoman11","html_url":"https://github.com/andreicoman11","followers_url":"https://api.github.com/users/andreicoman11/followers","following_url":"https://api.github.com/users/andreicoman11/following{/other_user}","gists_url":"https://api.github.com/users/andreicoman11/gists{/gist_id}","starred_url":"https://api.github.com/users/andreicoman11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreicoman11/subscriptions","organizations_url":"https://api.github.com/users/andreicoman11/orgs","repos_url":"https://api.github.com/users/andreicoman11/repos","events_url":"https://api.github.com/users/andreicoman11/events{/privacy}","received_events_url":"https://api.github.com/users/andreicoman11/received_events","type":"User","site_admin":false},"assignees":[{"login":"andreicoman11","id":6615092,"avatar_url":"https://avatars.githubusercontent.com/u/6615092?v=3","gravatar_id":"","url":"https://api.github.com/users/andreicoman11","html_url":"https://github.com/andreicoman11","followers_url":"https://api.github.com/users/andreicoman11/followers","following_url":"https://api.github.com/users/andreicoman11/following{/other_user}","gists_url":"https://api.github.com/users/andreicoman11/gists{/gist_id}","starred_url":"https://api.github.com/users/andreicoman11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreicoman11/subscriptions","organizations_url":"https://api.github.com/users/andreicoman11/orgs","repos_url":"https://api.github.com/users/andreicoman11/repos","events_url":"https://api.github.com/users/andreicoman11/events{/privacy}","received_events_url":"https://api.github.com/users/andreicoman11/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/9658/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/9658/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/9658/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/b6916ebf2c93389d2575e4337fbf86cdd882e2ca","head":{"label":"rigdern:rigdern/textBorder","ref":"rigdern/textBorder","sha":"b6916ebf2c93389d2575e4337fbf86cdd882e2ca","user":{"login":"rigdern","id":199935,"avatar_url":"https://avatars.githubusercontent.com/u/199935?v=3","gravatar_id":"","url":"https://api.github.com/users/rigdern","html_url":"https://github.com/rigdern","followers_url":"https://api.github.com/users/rigdern/followers","following_url":"https://api.github.com/users/rigdern/following{/other_user}","gists_url":"https://api.github.com/users/rigdern/gists{/gist_id}","starred_url":"https://api.github.com/users/rigdern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigdern/subscriptions","organizations_url":"https://api.github.com/users/rigdern/orgs","repos_url":"https://api.github.com/users/rigdern/repos","events_url":"https://api.github.com/users/rigdern/events{/privacy}","received_events_url":"https://api.github.com/users/rigdern/received_events","type":"User","site_admin":false},"repo":{"id":39579697,"name":"react-native","full_name":"rigdern/react-native","owner":{"login":"rigdern","id":199935,"avatar_url":"https://avatars.githubusercontent.com/u/199935?v=3","gravatar_id":"","url":"https://api.github.com/users/rigdern","html_url":"https://github.com/rigdern","followers_url":"https://api.github.com/users/rigdern/followers","following_url":"https://api.github.com/users/rigdern/following{/other_user}","gists_url":"https://api.github.com/users/rigdern/gists{/gist_id}","starred_url":"https://api.github.com/users/rigdern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigdern/subscriptions","organizations_url":"https://api.github.com/users/rigdern/orgs","repos_url":"https://api.github.com/users/rigdern/repos","events_url":"https://api.github.com/users/rigdern/events{/privacy}","received_events_url":"https://api.github.com/users/rigdern/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rigdern/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/rigdern/react-native","forks_url":"https://api.github.com/repos/rigdern/react-native/forks","keys_url":"https://api.github.com/repos/rigdern/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rigdern/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rigdern/react-native/teams","hooks_url":"https://api.github.com/repos/rigdern/react-native/hooks","issue_events_url":"https://api.github.com/repos/rigdern/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/rigdern/react-native/events","assignees_url":"https://api.github.com/repos/rigdern/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/rigdern/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/rigdern/react-native/tags","blobs_url":"https://api.github.com/repos/rigdern/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rigdern/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rigdern/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/rigdern/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rigdern/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/rigdern/react-native/languages","stargazers_url":"https://api.github.com/repos/rigdern/react-native/stargazers","contributors_url":"https://api.github.com/repos/rigdern/react-native/contributors","subscribers_url":"https://api.github.com/repos/rigdern/react-native/subscribers","subscription_url":"https://api.github.com/repos/rigdern/react-native/subscription","commits_url":"https://api.github.com/repos/rigdern/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/rigdern/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/rigdern/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/rigdern/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/rigdern/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/rigdern/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rigdern/react-native/merges","archive_url":"https://api.github.com/repos/rigdern/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rigdern/react-native/downloads","issues_url":"https://api.github.com/repos/rigdern/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/rigdern/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/rigdern/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/rigdern/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rigdern/react-native/labels{/name}","releases_url":"https://api.github.com/repos/rigdern/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/rigdern/react-native/deployments","created_at":"2015-07-23T16:53:43Z","updated_at":"2016-07-20T02:47:21Z","pushed_at":"2016-09-07T22:24:22Z","git_url":"git://github.com/rigdern/react-native.git","ssh_url":"git@github.com:rigdern/react-native.git","clone_url":"https://github.com/rigdern/react-native.git","svn_url":"https://github.com/rigdern/react-native","homepage":"http://facebook.github.io/react-native/","size":53918,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"5eaef1c631bcf70aed98ac575adb898fee5ba241","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2016-09-08T09:54:39Z","pushed_at":"2016-09-08T09:58:37Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":129769,"stargazers_count":37323,"watchers_count":37323,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8234,"mirror_url":null,"open_issues_count":1227,"forks":8234,"open_issues":1227,"watchers":37323,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/9658"},"html":{"href":"https://github.com/facebook/react-native/pull/9658"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/9658"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/9658/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/9658/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/9658/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/b6916ebf2c93389d2575e4337fbf86cdd882e2ca"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":13,"review_comments":0,"commits":4,"additions":216,"deletions":2,"changed_files":7}}
{"actor":{"display_login":"facebook-github-bot-4"}}