{"action":"created","issue":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/1082","repository_url":"https://api.github.com/repos/ampproject/amphtml","labels_url":"https://api.github.com/repos/ampproject/amphtml/issues/1082/labels{/name}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/1082/comments","events_url":"https://api.github.com/repos/ampproject/amphtml/issues/1082/events","html_url":"https://github.com/ampproject/amphtml/issues/1082","id":120617120,"number":1082,"title":"amp-analytics should have mandatory nodisplay layout, much like amp-font","user":{"login":"powdercloud","id":14113543,"avatar_url":"https://avatars.githubusercontent.com/u/14113543?v=3","gravatar_id":"","url":"https://api.github.com/users/powdercloud","html_url":"https://github.com/powdercloud","followers_url":"https://api.github.com/users/powdercloud/followers","following_url":"https://api.github.com/users/powdercloud/following{/other_user}","gists_url":"https://api.github.com/users/powdercloud/gists{/gist_id}","starred_url":"https://api.github.com/users/powdercloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/powdercloud/subscriptions","organizations_url":"https://api.github.com/users/powdercloud/orgs","repos_url":"https://api.github.com/users/powdercloud/repos","events_url":"https://api.github.com/users/powdercloud/events{/privacy}","received_events_url":"https://api.github.com/users/powdercloud/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ampproject/amphtml/labels/Related%20to:%20Analytics","name":"Related to: Analytics","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"avimehta","id":179359,"avatar_url":"https://avatars.githubusercontent.com/u/179359?v=3","gravatar_id":"","url":"https://api.github.com/users/avimehta","html_url":"https://github.com/avimehta","followers_url":"https://api.github.com/users/avimehta/followers","following_url":"https://api.github.com/users/avimehta/following{/other_user}","gists_url":"https://api.github.com/users/avimehta/gists{/gist_id}","starred_url":"https://api.github.com/users/avimehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avimehta/subscriptions","organizations_url":"https://api.github.com/users/avimehta/orgs","repos_url":"https://api.github.com/users/avimehta/repos","events_url":"https://api.github.com/users/avimehta/events{/privacy}","received_events_url":"https://api.github.com/users/avimehta/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/ampproject/amphtml/milestones/9","html_url":"https://github.com/ampproject/amphtml/milestones/Up%20Next","labels_url":"https://api.github.com/repos/ampproject/amphtml/milestones/9/labels","id":1621302,"number":9,"title":"Up Next","description":"This milestone collects issues we plan to work on soon.","creator":{"login":"rudygalfi","id":3888212,"avatar_url":"https://avatars.githubusercontent.com/u/3888212?v=3","gravatar_id":"","url":"https://api.github.com/users/rudygalfi","html_url":"https://github.com/rudygalfi","followers_url":"https://api.github.com/users/rudygalfi/followers","following_url":"https://api.github.com/users/rudygalfi/following{/other_user}","gists_url":"https://api.github.com/users/rudygalfi/gists{/gist_id}","starred_url":"https://api.github.com/users/rudygalfi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudygalfi/subscriptions","organizations_url":"https://api.github.com/users/rudygalfi/orgs","repos_url":"https://api.github.com/users/rudygalfi/repos","events_url":"https://api.github.com/users/rudygalfi/events{/privacy}","received_events_url":"https://api.github.com/users/rudygalfi/received_events","type":"User","site_admin":false},"open_issues":33,"closed_issues":2,"state":"open","created_at":"2016-03-04T00:12:33Z","updated_at":"2016-03-04T03:55:04Z","due_on":null,"closed_at":null},"comments":10,"created_at":"2015-12-06T08:01:53Z","updated_at":"2016-03-04T04:13:23Z","closed_at":null,"body":"I noticed that the recently contributed amp-analytics.js says: isLayoutSupported(layout) { return true; }\r\nI don't think that's cool, it's too loose and means that any layout can be attached to this tag, but that kind of makes no sense because an analytics thing doesn't really have a layout - or does it?\r\nIf the analytics engine creates a single pixel, then it should be FIXED, like amp-pixel. This means it should be registered in src/layout.js as an element with natural dimensions.\r\nOtherwise, if it doesn't have any pixels, I think it should go like amp-font, so that means it will have layout=nodisplay required on the tag (as in, users will have to write it).\r\nIf there should be some nodisplay default, then it probably needs to be registered in src/layout.js, much like the natural dimensions. But that mechanism doesn't exist yet. I'd go for the explicit layout=nodisplay for consistency with amp-font.\r\n@dvoytenko @avimehta "},"comment":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/comments/192091107","html_url":"https://github.com/ampproject/amphtml/issues/1082#issuecomment-192091107","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/1082","id":192091107,"user":{"login":"rudygalfi","id":3888212,"avatar_url":"https://avatars.githubusercontent.com/u/3888212?v=3","gravatar_id":"","url":"https://api.github.com/users/rudygalfi","html_url":"https://github.com/rudygalfi","followers_url":"https://api.github.com/users/rudygalfi/followers","following_url":"https://api.github.com/users/rudygalfi/following{/other_user}","gists_url":"https://api.github.com/users/rudygalfi/gists{/gist_id}","starred_url":"https://api.github.com/users/rudygalfi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudygalfi/subscriptions","organizations_url":"https://api.github.com/users/rudygalfi/orgs","repos_url":"https://api.github.com/users/rudygalfi/repos","events_url":"https://api.github.com/users/rudygalfi/events{/privacy}","received_events_url":"https://api.github.com/users/rudygalfi/received_events","type":"User","site_admin":false},"created_at":"2016-03-04T04:13:23Z","updated_at":"2016-03-04T04:13:23Z","body":"@jridgewell @cramforce Can this be closed?"}}