{"action":"created","issue":{"url":"https://api.github.com/repos/getquill/quill/issues/515","repository_url":"https://api.github.com/repos/getquill/quill","labels_url":"https://api.github.com/repos/getquill/quill/issues/515/labels{/name}","comments_url":"https://api.github.com/repos/getquill/quill/issues/515/comments","events_url":"https://api.github.com/repos/getquill/quill/issues/515/events","html_url":"https://github.com/getquill/quill/pull/515","id":171355077,"number":515,"title":"[WIP]: Removed Closeable from dataSource type in JdbcContext constructor","user":{"login":"hlysig","id":223798,"avatar_url":"https://avatars.githubusercontent.com/u/223798?v=3","gravatar_id":"","url":"https://api.github.com/users/hlysig","html_url":"https://github.com/hlysig","followers_url":"https://api.github.com/users/hlysig/followers","following_url":"https://api.github.com/users/hlysig/following{/other_user}","gists_url":"https://api.github.com/users/hlysig/gists{/gist_id}","starred_url":"https://api.github.com/users/hlysig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlysig/subscriptions","organizations_url":"https://api.github.com/users/hlysig/orgs","repos_url":"https://api.github.com/users/hlysig/repos","events_url":"https://api.github.com/users/hlysig/events{/privacy}","received_events_url":"https://api.github.com/users/hlysig/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-16T08:43:25Z","updated_at":"2016-08-16T17:25:09Z","closed_at":"2016-08-16T15:11:37Z","pull_request":{"url":"https://api.github.com/repos/getquill/quill/pulls/515","html_url":"https://github.com/getquill/quill/pull/515","diff_url":"https://github.com/getquill/quill/pull/515.diff","patch_url":"https://github.com/getquill/quill/pull/515.patch"},"body":"### Problem\r\nIn documentation it stated that context can be initialized as follows.\r\n\r\n```\r\ndef createDataSource: javax.sql.DataSource with java.io.Closeable = ???\r\nlazy val ctx = new JdbcContext[MySQLDialect, SnakeCase](createDataSource)\r\n```\r\n\r\nCurrently, `javax.sql.DataSource` does not implement `java.io.Closeable`. Thus for this functionality to work, we must wrap `javax.sql.DataSource` to implement `java.io.Closeable`.\r\n\r\nIn this pull request we remove this type `java.io.Closeable` constraint but keep the close functionality if `javax.sql.DataSource` indeed implements `java.io.Closeable`.\r\n\r\n@getquill/maintainers\r\n"},"comment":{"url":"https://api.github.com/repos/getquill/quill/issues/comments/240174598","html_url":"https://github.com/getquill/quill/pull/515#issuecomment-240174598","issue_url":"https://api.github.com/repos/getquill/quill/issues/515","id":240174598,"user":{"login":"fwbrasil","id":831175,"avatar_url":"https://avatars.githubusercontent.com/u/831175?v=3","gravatar_id":"","url":"https://api.github.com/users/fwbrasil","html_url":"https://github.com/fwbrasil","followers_url":"https://api.github.com/users/fwbrasil/followers","following_url":"https://api.github.com/users/fwbrasil/following{/other_user}","gists_url":"https://api.github.com/users/fwbrasil/gists{/gist_id}","starred_url":"https://api.github.com/users/fwbrasil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwbrasil/subscriptions","organizations_url":"https://api.github.com/users/fwbrasil/orgs","repos_url":"https://api.github.com/users/fwbrasil/repos","events_url":"https://api.github.com/users/fwbrasil/events{/privacy}","received_events_url":"https://api.github.com/users/fwbrasil/received_events","type":"User","site_admin":false},"created_at":"2016-08-16T17:25:09Z","updated_at":"2016-08-16T17:25:09Z","body":"@hlysig why closed?"}}
{"actor":{"display_login":"fwbrasil"}}