{"action":"created","comment":{"url":"https://api.github.com/repos/nix-rust/nix/pulls/comments/70175844","id":70175844,"diff_hunk":"@@ -8,12 +8,20 @@ mod ffi {\n \n     extern {\n         pub fn epoll_create(size: c_int) -> c_int;\n+        pub fn epoll_create1(flags: c_int) -> c_int;\n         pub fn epoll_ctl(epfd: c_int, op: c_int, fd: c_int, event: *const EpollEvent) -> c_int;\n         pub fn epoll_wait(epfd: c_int, events: *mut EpollEvent, max_events: c_int, timeout: c_int) -> c_int;","path":"src/sys/epoll.rs","position":6,"original_position":6,"commit_id":"5246ae64a6888965d2af0082a59a5bbe9cbd0ded","original_commit_id":"5246ae64a6888965d2af0082a59a5bbe9cbd0ded","user":{"login":"posborne","id":41714,"avatar_url":"https://avatars.githubusercontent.com/u/41714?v=3","gravatar_id":"","url":"https://api.github.com/users/posborne","html_url":"https://github.com/posborne","followers_url":"https://api.github.com/users/posborne/followers","following_url":"https://api.github.com/users/posborne/following{/other_user}","gists_url":"https://api.github.com/users/posborne/gists{/gist_id}","starred_url":"https://api.github.com/users/posborne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/posborne/subscriptions","organizations_url":"https://api.github.com/users/posborne/orgs","repos_url":"https://api.github.com/users/posborne/repos","events_url":"https://api.github.com/users/posborne/events{/privacy}","received_events_url":"https://api.github.com/users/posborne/received_events","type":"User","site_admin":false},"body":"Hi @kubo39 , although this is not directly related to your PR we have been moving to defining ffi constants entirely in libc and using those rather than defining our own (see [CONVENTIONS.md](https://github.com/nix-rust/nix/blob/master/CONVENTIONS.md#libc-constants-functions-and-structs).  it looks like the existing constants are present but `epoll_create1` is not.  Can you please do the following:\r\n\r\n1. Open up a PR to libc adding `epoll_create1`\r\n2. Update `epoll.rs` to use the ffi definitions from libc.\r\n\r\nAlso, thanks for the change!","created_at":"2016-07-10T04:44:47Z","updated_at":"2016-07-10T04:44:47Z","html_url":"https://github.com/nix-rust/nix/pull/384#discussion_r70175844","pull_request_url":"https://api.github.com/repos/nix-rust/nix/pulls/384","_links":{"self":{"href":"https://api.github.com/repos/nix-rust/nix/pulls/comments/70175844"},"html":{"href":"https://github.com/nix-rust/nix/pull/384#discussion_r70175844"},"pull_request":{"href":"https://api.github.com/repos/nix-rust/nix/pulls/384"}}},"pull_request":{"url":"https://api.github.com/repos/nix-rust/nix/pulls/384","id":76852628,"html_url":"https://github.com/nix-rust/nix/pull/384","diff_url":"https://github.com/nix-rust/nix/pull/384.diff","patch_url":"https://github.com/nix-rust/nix/pull/384.patch","issue_url":"https://api.github.com/repos/nix-rust/nix/issues/384","number":384,"state":"open","locked":false,"title":"Add epoll_create1.","user":{"login":"kubo39","id":927749,"avatar_url":"https://avatars.githubusercontent.com/u/927749?v=3","gravatar_id":"","url":"https://api.github.com/users/kubo39","html_url":"https://github.com/kubo39","followers_url":"https://api.github.com/users/kubo39/followers","following_url":"https://api.github.com/users/kubo39/following{/other_user}","gists_url":"https://api.github.com/users/kubo39/gists{/gist_id}","starred_url":"https://api.github.com/users/kubo39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubo39/subscriptions","organizations_url":"https://api.github.com/users/kubo39/orgs","repos_url":"https://api.github.com/users/kubo39/repos","events_url":"https://api.github.com/users/kubo39/events{/privacy}","received_events_url":"https://api.github.com/users/kubo39/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-09T17:41:19Z","updated_at":"2016-07-10T04:44:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a933f88c47fa85a1bb278104caac87d2baab13d9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nix-rust/nix/pulls/384/commits","review_comments_url":"https://api.github.com/repos/nix-rust/nix/pulls/384/comments","review_comment_url":"https://api.github.com/repos/nix-rust/nix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nix-rust/nix/issues/384/comments","statuses_url":"https://api.github.com/repos/nix-rust/nix/statuses/5246ae64a6888965d2af0082a59a5bbe9cbd0ded","head":{"label":"kubo39:add_epoll_create1-and-set-cloexec","ref":"add_epoll_create1-and-set-cloexec","sha":"5246ae64a6888965d2af0082a59a5bbe9cbd0ded","user":{"login":"kubo39","id":927749,"avatar_url":"https://avatars.githubusercontent.com/u/927749?v=3","gravatar_id":"","url":"https://api.github.com/users/kubo39","html_url":"https://github.com/kubo39","followers_url":"https://api.github.com/users/kubo39/followers","following_url":"https://api.github.com/users/kubo39/following{/other_user}","gists_url":"https://api.github.com/users/kubo39/gists{/gist_id}","starred_url":"https://api.github.com/users/kubo39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubo39/subscriptions","organizations_url":"https://api.github.com/users/kubo39/orgs","repos_url":"https://api.github.com/users/kubo39/repos","events_url":"https://api.github.com/users/kubo39/events{/privacy}","received_events_url":"https://api.github.com/users/kubo39/received_events","type":"User","site_admin":false},"repo":{"id":54887823,"name":"nix","full_name":"kubo39/nix","owner":{"login":"kubo39","id":927749,"avatar_url":"https://avatars.githubusercontent.com/u/927749?v=3","gravatar_id":"","url":"https://api.github.com/users/kubo39","html_url":"https://github.com/kubo39","followers_url":"https://api.github.com/users/kubo39/followers","following_url":"https://api.github.com/users/kubo39/following{/other_user}","gists_url":"https://api.github.com/users/kubo39/gists{/gist_id}","starred_url":"https://api.github.com/users/kubo39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubo39/subscriptions","organizations_url":"https://api.github.com/users/kubo39/orgs","repos_url":"https://api.github.com/users/kubo39/repos","events_url":"https://api.github.com/users/kubo39/events{/privacy}","received_events_url":"https://api.github.com/users/kubo39/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kubo39/nix","description":"Rust friendly bindings to *nix APIs","fork":true,"url":"https://api.github.com/repos/kubo39/nix","forks_url":"https://api.github.com/repos/kubo39/nix/forks","keys_url":"https://api.github.com/repos/kubo39/nix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubo39/nix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubo39/nix/teams","hooks_url":"https://api.github.com/repos/kubo39/nix/hooks","issue_events_url":"https://api.github.com/repos/kubo39/nix/issues/events{/number}","events_url":"https://api.github.com/repos/kubo39/nix/events","assignees_url":"https://api.github.com/repos/kubo39/nix/assignees{/user}","branches_url":"https://api.github.com/repos/kubo39/nix/branches{/branch}","tags_url":"https://api.github.com/repos/kubo39/nix/tags","blobs_url":"https://api.github.com/repos/kubo39/nix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubo39/nix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubo39/nix/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubo39/nix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubo39/nix/statuses/{sha}","languages_url":"https://api.github.com/repos/kubo39/nix/languages","stargazers_url":"https://api.github.com/repos/kubo39/nix/stargazers","contributors_url":"https://api.github.com/repos/kubo39/nix/contributors","subscribers_url":"https://api.github.com/repos/kubo39/nix/subscribers","subscription_url":"https://api.github.com/repos/kubo39/nix/subscription","commits_url":"https://api.github.com/repos/kubo39/nix/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubo39/nix/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubo39/nix/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubo39/nix/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubo39/nix/contents/{+path}","compare_url":"https://api.github.com/repos/kubo39/nix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubo39/nix/merges","archive_url":"https://api.github.com/repos/kubo39/nix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubo39/nix/downloads","issues_url":"https://api.github.com/repos/kubo39/nix/issues{/number}","pulls_url":"https://api.github.com/repos/kubo39/nix/pulls{/number}","milestones_url":"https://api.github.com/repos/kubo39/nix/milestones{/number}","notifications_url":"https://api.github.com/repos/kubo39/nix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubo39/nix/labels{/name}","releases_url":"https://api.github.com/repos/kubo39/nix/releases{/id}","deployments_url":"https://api.github.com/repos/kubo39/nix/deployments","created_at":"2016-03-28T11:29:30Z","updated_at":"2016-03-28T11:29:32Z","pushed_at":"2016-07-09T19:02:53Z","git_url":"git://github.com/kubo39/nix.git","ssh_url":"git@github.com:kubo39/nix.git","clone_url":"https://github.com/kubo39/nix.git","svn_url":"https://github.com/kubo39/nix","homepage":"","size":808,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nix-rust:master","ref":"master","sha":"168951b5dc3236457bd5a1f2c017f565a16b3017","user":{"login":"nix-rust","id":17190941,"avatar_url":"https://avatars.githubusercontent.com/u/17190941?v=3","gravatar_id":"","url":"https://api.github.com/users/nix-rust","html_url":"https://github.com/nix-rust","followers_url":"https://api.github.com/users/nix-rust/followers","following_url":"https://api.github.com/users/nix-rust/following{/other_user}","gists_url":"https://api.github.com/users/nix-rust/gists{/gist_id}","starred_url":"https://api.github.com/users/nix-rust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nix-rust/subscriptions","organizations_url":"https://api.github.com/users/nix-rust/orgs","repos_url":"https://api.github.com/users/nix-rust/repos","events_url":"https://api.github.com/users/nix-rust/events{/privacy}","received_events_url":"https://api.github.com/users/nix-rust/received_events","type":"Organization","site_admin":false},"repo":{"id":22734848,"name":"nix","full_name":"nix-rust/nix","owner":{"login":"nix-rust","id":17190941,"avatar_url":"https://avatars.githubusercontent.com/u/17190941?v=3","gravatar_id":"","url":"https://api.github.com/users/nix-rust","html_url":"https://github.com/nix-rust","followers_url":"https://api.github.com/users/nix-rust/followers","following_url":"https://api.github.com/users/nix-rust/following{/other_user}","gists_url":"https://api.github.com/users/nix-rust/gists{/gist_id}","starred_url":"https://api.github.com/users/nix-rust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nix-rust/subscriptions","organizations_url":"https://api.github.com/users/nix-rust/orgs","repos_url":"https://api.github.com/users/nix-rust/repos","events_url":"https://api.github.com/users/nix-rust/events{/privacy}","received_events_url":"https://api.github.com/users/nix-rust/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nix-rust/nix","description":"Rust friendly bindings to *nix APIs","fork":false,"url":"https://api.github.com/repos/nix-rust/nix","forks_url":"https://api.github.com/repos/nix-rust/nix/forks","keys_url":"https://api.github.com/repos/nix-rust/nix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nix-rust/nix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nix-rust/nix/teams","hooks_url":"https://api.github.com/repos/nix-rust/nix/hooks","issue_events_url":"https://api.github.com/repos/nix-rust/nix/issues/events{/number}","events_url":"https://api.github.com/repos/nix-rust/nix/events","assignees_url":"https://api.github.com/repos/nix-rust/nix/assignees{/user}","branches_url":"https://api.github.com/repos/nix-rust/nix/branches{/branch}","tags_url":"https://api.github.com/repos/nix-rust/nix/tags","blobs_url":"https://api.github.com/repos/nix-rust/nix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nix-rust/nix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nix-rust/nix/git/refs{/sha}","trees_url":"https://api.github.com/repos/nix-rust/nix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nix-rust/nix/statuses/{sha}","languages_url":"https://api.github.com/repos/nix-rust/nix/languages","stargazers_url":"https://api.github.com/repos/nix-rust/nix/stargazers","contributors_url":"https://api.github.com/repos/nix-rust/nix/contributors","subscribers_url":"https://api.github.com/repos/nix-rust/nix/subscribers","subscription_url":"https://api.github.com/repos/nix-rust/nix/subscription","commits_url":"https://api.github.com/repos/nix-rust/nix/commits{/sha}","git_commits_url":"https://api.github.com/repos/nix-rust/nix/git/commits{/sha}","comments_url":"https://api.github.com/repos/nix-rust/nix/comments{/number}","issue_comment_url":"https://api.github.com/repos/nix-rust/nix/issues/comments{/number}","contents_url":"https://api.github.com/repos/nix-rust/nix/contents/{+path}","compare_url":"https://api.github.com/repos/nix-rust/nix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nix-rust/nix/merges","archive_url":"https://api.github.com/repos/nix-rust/nix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nix-rust/nix/downloads","issues_url":"https://api.github.com/repos/nix-rust/nix/issues{/number}","pulls_url":"https://api.github.com/repos/nix-rust/nix/pulls{/number}","milestones_url":"https://api.github.com/repos/nix-rust/nix/milestones{/number}","notifications_url":"https://api.github.com/repos/nix-rust/nix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nix-rust/nix/labels{/name}","releases_url":"https://api.github.com/repos/nix-rust/nix/releases{/id}","deployments_url":"https://api.github.com/repos/nix-rust/nix/deployments","created_at":"2014-08-07T20:03:36Z","updated_at":"2016-07-04T15:04:23Z","pushed_at":"2016-07-09T19:02:53Z","git_url":"git://github.com/nix-rust/nix.git","ssh_url":"git@github.com:nix-rust/nix.git","clone_url":"https://github.com/nix-rust/nix.git","svn_url":"https://github.com/nix-rust/nix","homepage":"","size":1062,"stargazers_count":332,"watchers_count":332,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":99,"mirror_url":null,"open_issues_count":47,"forks":99,"open_issues":47,"watchers":332,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nix-rust/nix/pulls/384"},"html":{"href":"https://github.com/nix-rust/nix/pull/384"},"issue":{"href":"https://api.github.com/repos/nix-rust/nix/issues/384"},"comments":{"href":"https://api.github.com/repos/nix-rust/nix/issues/384/comments"},"review_comments":{"href":"https://api.github.com/repos/nix-rust/nix/pulls/384/comments"},"review_comment":{"href":"https://api.github.com/repos/nix-rust/nix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nix-rust/nix/pulls/384/commits"},"statuses":{"href":"https://api.github.com/repos/nix-rust/nix/statuses/5246ae64a6888965d2af0082a59a5bbe9cbd0ded"}}}}
{"actor":{"display_login":"posborne"}}