{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/91159925","pull_request_review_id":11669789,"id":91159925,"diff_hunk":"@@ -146,7 +149,8 @@ void ClientHelloParser::ParseExtension(const uint16_t type,\n       ocsp_request_ = 1;\n       break;\n     case kTLSSessionTicket:\n-      tls_ticket_size_ = len;\n+      // TBD POSSIBLE DATA LOSS:\n+      tls_ticket_size_ = static_cast<uint16_t>(len & kTLSTicketSizeMask);","path":"src/node_crypto_clienthello.cc","position":16,"original_position":16,"commit_id":"6259a3adbdde6a0884cd4d94f2533b6093cdbc91","original_commit_id":"6259a3adbdde6a0884cd4d94f2533b6093cdbc91","user":{"login":"indutny","id":238531,"avatar_url":"https://avatars.githubusercontent.com/u/238531?v=3","gravatar_id":"","url":"https://api.github.com/users/indutny","html_url":"https://github.com/indutny","followers_url":"https://api.github.com/users/indutny/followers","following_url":"https://api.github.com/users/indutny/following{/other_user}","gists_url":"https://api.github.com/users/indutny/gists{/gist_id}","starred_url":"https://api.github.com/users/indutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indutny/subscriptions","organizations_url":"https://api.github.com/users/indutny/orgs","repos_url":"https://api.github.com/users/indutny/repos","events_url":"https://api.github.com/users/indutny/events{/privacy}","received_events_url":"https://api.github.com/users/indutny/received_events","type":"User","site_admin":false},"body":"That's how much bits it occupies in binary representation. I don't have any strong feelings about making it wider, though.","created_at":"2016-12-06T20:02:43Z","updated_at":"2016-12-06T20:02:43Z","html_url":"https://github.com/nodejs/node/pull/10142#discussion_r91159925","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/10142","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/91159925"},"html":{"href":"https://github.com/nodejs/node/pull/10142#discussion_r91159925"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/10142"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/10142","id":96731041,"html_url":"https://github.com/nodejs/node/pull/10142","diff_url":"https://github.com/nodejs/node/pull/10142.diff","patch_url":"https://github.com/nodejs/node/pull/10142.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/10142","number":10142,"state":"open","locked":false,"title":"crypto: build warning fixes","user":{"login":"brodybits","id":1559888,"avatar_url":"https://avatars.githubusercontent.com/u/1559888?v=3","gravatar_id":"","url":"https://api.github.com/users/brodybits","html_url":"https://github.com/brodybits","followers_url":"https://api.github.com/users/brodybits/followers","following_url":"https://api.github.com/users/brodybits/following{/other_user}","gists_url":"https://api.github.com/users/brodybits/gists{/gist_id}","starred_url":"https://api.github.com/users/brodybits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brodybits/subscriptions","organizations_url":"https://api.github.com/users/brodybits/orgs","repos_url":"https://api.github.com/users/brodybits/repos","events_url":"https://api.github.com/users/brodybits/events{/privacy}","received_events_url":"https://api.github.com/users/brodybits/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j8 test` (UNIX [macOS]; Linux i386 & amd64) **and** `vcbuild test nosign` (`.\\vcbuild.bat nosign` then ` .\\vcbuild.bat test nosign nobuild` as Administrator on Windows) PASS OK\r\n- [x] commit message follows commit guidelines\r\n\r\n###### Additional item\r\n\r\n- [x] I hereby certify the statements in [Developer's Certificate of Origin 1.1](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#developers-certificate-of-origin-11)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\n\r\ncrypto\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\n\r\n- use unsigned long exponent in BIO_printf: resolve warning in Ubuntu Linux i386 build\r\n- use static kTLSTicketSizeMask: resolve conversion warning on Windows\r\n\r\nNOTE: This was originally a part of PR #10139 (build, warning, header, and include fixes).\r\n\r\nADDITIONAL NOTE: This and other changes related to _PR #10139_ are marked `// TBD POSSIBLE DATA LOSS:` since I think we should examine these conversions at some point. I would be happy to take some or all of these out if necessary.","created_at":"2016-12-06T14:13:21Z","updated_at":"2016-12-06T20:02:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b85c1c5a1cfa29a3b8d0077c4d0d22197a5f0596","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/10142/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/10142/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/10142/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/6259a3adbdde6a0884cd4d94f2533b6093cdbc91","head":{"label":"brodybits:cb-crypto-warning-fixes","ref":"cb-crypto-warning-fixes","sha":"6259a3adbdde6a0884cd4d94f2533b6093cdbc91","user":{"login":"brodybits","id":1559888,"avatar_url":"https://avatars.githubusercontent.com/u/1559888?v=3","gravatar_id":"","url":"https://api.github.com/users/brodybits","html_url":"https://github.com/brodybits","followers_url":"https://api.github.com/users/brodybits/followers","following_url":"https://api.github.com/users/brodybits/following{/other_user}","gists_url":"https://api.github.com/users/brodybits/gists{/gist_id}","starred_url":"https://api.github.com/users/brodybits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brodybits/subscriptions","organizations_url":"https://api.github.com/users/brodybits/orgs","repos_url":"https://api.github.com/users/brodybits/repos","events_url":"https://api.github.com/users/brodybits/events{/privacy}","received_events_url":"https://api.github.com/users/brodybits/received_events","type":"User","site_admin":false},"repo":{"id":42064642,"name":"node","full_name":"brodybits/node","owner":{"login":"brodybits","id":1559888,"avatar_url":"https://avatars.githubusercontent.com/u/1559888?v=3","gravatar_id":"","url":"https://api.github.com/users/brodybits","html_url":"https://github.com/brodybits","followers_url":"https://api.github.com/users/brodybits/followers","following_url":"https://api.github.com/users/brodybits/following{/other_user}","gists_url":"https://api.github.com/users/brodybits/gists{/gist_id}","starred_url":"https://api.github.com/users/brodybits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brodybits/subscriptions","organizations_url":"https://api.github.com/users/brodybits/orgs","repos_url":"https://api.github.com/users/brodybits/repos","events_url":"https://api.github.com/users/brodybits/events{/privacy}","received_events_url":"https://api.github.com/users/brodybits/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brodybits/node","description":"✨Future Node.js releases will be from this repo. ✨","fork":true,"url":"https://api.github.com/repos/brodybits/node","forks_url":"https://api.github.com/repos/brodybits/node/forks","keys_url":"https://api.github.com/repos/brodybits/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brodybits/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brodybits/node/teams","hooks_url":"https://api.github.com/repos/brodybits/node/hooks","issue_events_url":"https://api.github.com/repos/brodybits/node/issues/events{/number}","events_url":"https://api.github.com/repos/brodybits/node/events","assignees_url":"https://api.github.com/repos/brodybits/node/assignees{/user}","branches_url":"https://api.github.com/repos/brodybits/node/branches{/branch}","tags_url":"https://api.github.com/repos/brodybits/node/tags","blobs_url":"https://api.github.com/repos/brodybits/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brodybits/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brodybits/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/brodybits/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brodybits/node/statuses/{sha}","languages_url":"https://api.github.com/repos/brodybits/node/languages","stargazers_url":"https://api.github.com/repos/brodybits/node/stargazers","contributors_url":"https://api.github.com/repos/brodybits/node/contributors","subscribers_url":"https://api.github.com/repos/brodybits/node/subscribers","subscription_url":"https://api.github.com/repos/brodybits/node/subscription","commits_url":"https://api.github.com/repos/brodybits/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/brodybits/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/brodybits/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/brodybits/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/brodybits/node/contents/{+path}","compare_url":"https://api.github.com/repos/brodybits/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brodybits/node/merges","archive_url":"https://api.github.com/repos/brodybits/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brodybits/node/downloads","issues_url":"https://api.github.com/repos/brodybits/node/issues{/number}","pulls_url":"https://api.github.com/repos/brodybits/node/pulls{/number}","milestones_url":"https://api.github.com/repos/brodybits/node/milestones{/number}","notifications_url":"https://api.github.com/repos/brodybits/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brodybits/node/labels{/name}","releases_url":"https://api.github.com/repos/brodybits/node/releases{/id}","deployments_url":"https://api.github.com/repos/brodybits/node/deployments","created_at":"2015-09-07T16:55:07Z","updated_at":"2016-11-10T19:38:43Z","pushed_at":"2016-12-06T14:26:00Z","git_url":"git://github.com/brodybits/node.git","ssh_url":"git@github.com:brodybits/node.git","clone_url":"https://github.com/brodybits/node.git","svn_url":"https://github.com/brodybits/node","homepage":"https://nodejs.org","size":230280,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"9d493d006496bee01c6d54a7d1c9a3ef8068fd87","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-12-06T18:23:08Z","pushed_at":"2016-12-06T20:01:49Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":375232,"stargazers_count":29599,"watchers_count":29599,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5274,"mirror_url":null,"open_issues_count":1055,"forks":5274,"open_issues":1055,"watchers":29599,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/10142"},"html":{"href":"https://github.com/nodejs/node/pull/10142"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/10142"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/10142/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/10142/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/10142/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/6259a3adbdde6a0884cd4d94f2533b6093cdbc91"}}}}
{"actor":{"display_login":"indutny"}}