{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/paas-cf/issues/404","repository_url":"https://api.github.com/repos/alphagov/paas-cf","labels_url":"https://api.github.com/repos/alphagov/paas-cf/issues/404/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/paas-cf/issues/404/comments","events_url":"https://api.github.com/repos/alphagov/paas-cf/issues/404/events","html_url":"https://github.com/alphagov/paas-cf/pull/404","id":169100286,"number":404,"title":"[120765225] Disable healthcheck DB on DEV","user":{"login":"richardc","id":55650,"avatar_url":"https://avatars.githubusercontent.com/u/55650?v=3","gravatar_id":"","url":"https://api.github.com/users/richardc","html_url":"https://github.com/richardc","followers_url":"https://api.github.com/users/richardc/followers","following_url":"https://api.github.com/users/richardc/following{/other_user}","gists_url":"https://api.github.com/users/richardc/gists{/gist_id}","starred_url":"https://api.github.com/users/richardc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardc/subscriptions","organizations_url":"https://api.github.com/users/richardc/orgs","repos_url":"https://api.github.com/users/richardc/repos","events_url":"https://api.github.com/users/richardc/events{/privacy}","received_events_url":"https://api.github.com/users/richardc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"dcarley","id":260438,"avatar_url":"https://avatars.githubusercontent.com/u/260438?v=3","gravatar_id":"","url":"https://api.github.com/users/dcarley","html_url":"https://github.com/dcarley","followers_url":"https://api.github.com/users/dcarley/followers","following_url":"https://api.github.com/users/dcarley/following{/other_user}","gists_url":"https://api.github.com/users/dcarley/gists{/gist_id}","starred_url":"https://api.github.com/users/dcarley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcarley/subscriptions","organizations_url":"https://api.github.com/users/dcarley/orgs","repos_url":"https://api.github.com/users/dcarley/repos","events_url":"https://api.github.com/users/dcarley/events{/privacy}","received_events_url":"https://api.github.com/users/dcarley/received_events","type":"User","site_admin":false},"assignees":[{"login":"dcarley","id":260438,"avatar_url":"https://avatars.githubusercontent.com/u/260438?v=3","gravatar_id":"","url":"https://api.github.com/users/dcarley","html_url":"https://github.com/dcarley","followers_url":"https://api.github.com/users/dcarley/followers","following_url":"https://api.github.com/users/dcarley/following{/other_user}","gists_url":"https://api.github.com/users/dcarley/gists{/gist_id}","starred_url":"https://api.github.com/users/dcarley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcarley/subscriptions","organizations_url":"https://api.github.com/users/dcarley/orgs","repos_url":"https://api.github.com/users/dcarley/repos","events_url":"https://api.github.com/users/dcarley/events{/privacy}","received_events_url":"https://api.github.com/users/dcarley/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-08-03T10:35:25Z","updated_at":"2016-08-03T11:55:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/alphagov/paas-cf/pulls/404","html_url":"https://github.com/alphagov/paas-cf/pull/404","diff_url":"https://github.com/alphagov/paas-cf/pull/404.diff","patch_url":"https://github.com/alphagov/paas-cf/pull/404.patch"},"body":"## What\r\n\r\nDisable healthcheck DB on DEV\r\n\r\nThis commit disables provisioning of healthcheck DB on DEV environments to\r\nsave space,time and money :). It keeps it enabled on non-dev envs.\r\n\r\nChanges consists of default setting in Makefile, that is passed via\r\npipeline upload script and new condition in deploy-healthcheck to test it.\r\n\r\n## How to review\r\n\r\nDeploy pipeline - during running of post-deploy.deploy-healthcheck note the new order of operations doesn't include provisioning a `healthcheck-db` service.\r\n\r\n## Who can review\r\n\r\nCannot be reviewed by @combor or @richardc"},"comment":{"url":"https://api.github.com/repos/alphagov/paas-cf/issues/comments/237216826","html_url":"https://github.com/alphagov/paas-cf/pull/404#issuecomment-237216826","issue_url":"https://api.github.com/repos/alphagov/paas-cf/issues/404","id":237216826,"user":{"login":"dcarley","id":260438,"avatar_url":"https://avatars.githubusercontent.com/u/260438?v=3","gravatar_id":"","url":"https://api.github.com/users/dcarley","html_url":"https://github.com/dcarley","followers_url":"https://api.github.com/users/dcarley/followers","following_url":"https://api.github.com/users/dcarley/following{/other_user}","gists_url":"https://api.github.com/users/dcarley/gists{/gist_id}","starred_url":"https://api.github.com/users/dcarley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcarley/subscriptions","organizations_url":"https://api.github.com/users/dcarley/orgs","repos_url":"https://api.github.com/users/dcarley/repos","events_url":"https://api.github.com/users/dcarley/events{/privacy}","received_events_url":"https://api.github.com/users/dcarley/received_events","type":"User","site_admin":false},"created_at":"2016-08-03T11:55:10Z","updated_at":"2016-08-03T11:55:10Z","body":"> What is the impact of this change on existing dev environments that have a healthcheck db? Do we need to remove the db? Will things still work when destroying an environment?\r\n\r\nGood question and we should add the answer to the commit message.\r\n\r\nWe discussed in kick-off that the task which removes the healthcheck DB in `autodelete-cloudfoundry` and `destroy-cloudfoundry` would be sufficient in cleaning up existing environments. It looks like the work we already did to make it resilient to the DB creation failing will allow it to continue working, but I'll double check when testing."}}
{"actor":{"display_login":"dcarley"}}