{"action":"created","comment":{"url":"https://api.github.com/repos/rapid7/dap/pulls/comments/74039637","id":74039637,"diff_hunk":"@@ -50,17 +51,23 @@ def read_record\n   # JSON Input (line-delimited records)\n   #\n   class InputJSON\n-    \n+\n     include FileSource\n \n     def initialize(args)\n       self.open(args.first)\n     end\n \n-    def read_record  \n+    def read_record\n       line = self.fd.readline rescue nil\n       return Error::EOF unless line\n-      json = Oj.load(line.strip) rescue nil\n+      begin\n+        json = Oj.load(line.strip)\n+      rescue\n+        $stderr.puts \"\\nRecord is not valid JSON and will be skipped.\"","path":"lib/dap/input.rb","position":57,"original_position":57,"commit_id":"60efb48180f02393faeef3e8d9a105a67d92da7b","original_commit_id":"60efb48180f02393faeef3e8d9a105a67d92da7b","user":{"login":"tsellers-r7","id":20306699,"avatar_url":"https://avatars.githubusercontent.com/u/20306699?v=3","gravatar_id":"","url":"https://api.github.com/users/tsellers-r7","html_url":"https://github.com/tsellers-r7","followers_url":"https://api.github.com/users/tsellers-r7/followers","following_url":"https://api.github.com/users/tsellers-r7/following{/other_user}","gists_url":"https://api.github.com/users/tsellers-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/tsellers-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsellers-r7/subscriptions","organizations_url":"https://api.github.com/users/tsellers-r7/orgs","repos_url":"https://api.github.com/users/tsellers-r7/repos","events_url":"https://api.github.com/users/tsellers-r7/events{/privacy}","received_events_url":"https://api.github.com/users/tsellers-r7/received_events","type":"User","site_admin":false},"body":"This output, when handed large results, creates a wall of text.  Without the extra line break before there would be no visual breaks at all.  I've tossed you a screenshot sample.","created_at":"2016-08-09T11:21:33Z","updated_at":"2016-08-09T11:21:33Z","html_url":"https://github.com/rapid7/dap/pull/17#discussion_r74039637","pull_request_url":"https://api.github.com/repos/rapid7/dap/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/rapid7/dap/pulls/comments/74039637"},"html":{"href":"https://github.com/rapid7/dap/pull/17#discussion_r74039637"},"pull_request":{"href":"https://api.github.com/repos/rapid7/dap/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/rapid7/dap/pulls/17","id":80531857,"html_url":"https://github.com/rapid7/dap/pull/17","diff_url":"https://github.com/rapid7/dap/pull/17.diff","patch_url":"https://github.com/rapid7/dap/pull/17.patch","issue_url":"https://api.github.com/repos/rapid7/dap/issues/17","number":17,"state":"open","locked":false,"title":"Add error msg RE: invalid JSON","user":{"login":"tsellers-r7","id":20306699,"avatar_url":"https://avatars.githubusercontent.com/u/20306699?v=3","gravatar_id":"","url":"https://api.github.com/users/tsellers-r7","html_url":"https://github.com/tsellers-r7","followers_url":"https://api.github.com/users/tsellers-r7/followers","following_url":"https://api.github.com/users/tsellers-r7/following{/other_user}","gists_url":"https://api.github.com/users/tsellers-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/tsellers-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsellers-r7/subscriptions","organizations_url":"https://api.github.com/users/tsellers-r7/orgs","repos_url":"https://api.github.com/users/tsellers-r7/repos","events_url":"https://api.github.com/users/tsellers-r7/events{/privacy}","received_events_url":"https://api.github.com/users/tsellers-r7/received_events","type":"User","site_admin":false},"body":"Changes so that when DAP encounters invalid JSON it will log this event and the data it was requested to parse to STDERR. ","created_at":"2016-08-08T22:18:21Z","updated_at":"2016-08-09T11:21:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5180ba2f898147c852f0ee368705f8b54c10e0db","assignee":{"login":"jhart-r7","id":3869433,"avatar_url":"https://avatars.githubusercontent.com/u/3869433?v=3","gravatar_id":"","url":"https://api.github.com/users/jhart-r7","html_url":"https://github.com/jhart-r7","followers_url":"https://api.github.com/users/jhart-r7/followers","following_url":"https://api.github.com/users/jhart-r7/following{/other_user}","gists_url":"https://api.github.com/users/jhart-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/jhart-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhart-r7/subscriptions","organizations_url":"https://api.github.com/users/jhart-r7/orgs","repos_url":"https://api.github.com/users/jhart-r7/repos","events_url":"https://api.github.com/users/jhart-r7/events{/privacy}","received_events_url":"https://api.github.com/users/jhart-r7/received_events","type":"User","site_admin":false},"assignees":[{"login":"jhart-r7","id":3869433,"avatar_url":"https://avatars.githubusercontent.com/u/3869433?v=3","gravatar_id":"","url":"https://api.github.com/users/jhart-r7","html_url":"https://github.com/jhart-r7","followers_url":"https://api.github.com/users/jhart-r7/followers","following_url":"https://api.github.com/users/jhart-r7/following{/other_user}","gists_url":"https://api.github.com/users/jhart-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/jhart-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhart-r7/subscriptions","organizations_url":"https://api.github.com/users/jhart-r7/orgs","repos_url":"https://api.github.com/users/jhart-r7/repos","events_url":"https://api.github.com/users/jhart-r7/events{/privacy}","received_events_url":"https://api.github.com/users/jhart-r7/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rapid7/dap/pulls/17/commits","review_comments_url":"https://api.github.com/repos/rapid7/dap/pulls/17/comments","review_comment_url":"https://api.github.com/repos/rapid7/dap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rapid7/dap/issues/17/comments","statuses_url":"https://api.github.com/repos/rapid7/dap/statuses/60efb48180f02393faeef3e8d9a105a67d92da7b","head":{"label":"tsellers-r7:dap_input_json_error_message","ref":"dap_input_json_error_message","sha":"60efb48180f02393faeef3e8d9a105a67d92da7b","user":{"login":"tsellers-r7","id":20306699,"avatar_url":"https://avatars.githubusercontent.com/u/20306699?v=3","gravatar_id":"","url":"https://api.github.com/users/tsellers-r7","html_url":"https://github.com/tsellers-r7","followers_url":"https://api.github.com/users/tsellers-r7/followers","following_url":"https://api.github.com/users/tsellers-r7/following{/other_user}","gists_url":"https://api.github.com/users/tsellers-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/tsellers-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsellers-r7/subscriptions","organizations_url":"https://api.github.com/users/tsellers-r7/orgs","repos_url":"https://api.github.com/users/tsellers-r7/repos","events_url":"https://api.github.com/users/tsellers-r7/events{/privacy}","received_events_url":"https://api.github.com/users/tsellers-r7/received_events","type":"User","site_admin":false},"repo":{"id":63068153,"name":"dap","full_name":"tsellers-r7/dap","owner":{"login":"tsellers-r7","id":20306699,"avatar_url":"https://avatars.githubusercontent.com/u/20306699?v=3","gravatar_id":"","url":"https://api.github.com/users/tsellers-r7","html_url":"https://github.com/tsellers-r7","followers_url":"https://api.github.com/users/tsellers-r7/followers","following_url":"https://api.github.com/users/tsellers-r7/following{/other_user}","gists_url":"https://api.github.com/users/tsellers-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/tsellers-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsellers-r7/subscriptions","organizations_url":"https://api.github.com/users/tsellers-r7/orgs","repos_url":"https://api.github.com/users/tsellers-r7/repos","events_url":"https://api.github.com/users/tsellers-r7/events{/privacy}","received_events_url":"https://api.github.com/users/tsellers-r7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tsellers-r7/dap","description":"Data Analysis Pipeline","fork":true,"url":"https://api.github.com/repos/tsellers-r7/dap","forks_url":"https://api.github.com/repos/tsellers-r7/dap/forks","keys_url":"https://api.github.com/repos/tsellers-r7/dap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsellers-r7/dap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsellers-r7/dap/teams","hooks_url":"https://api.github.com/repos/tsellers-r7/dap/hooks","issue_events_url":"https://api.github.com/repos/tsellers-r7/dap/issues/events{/number}","events_url":"https://api.github.com/repos/tsellers-r7/dap/events","assignees_url":"https://api.github.com/repos/tsellers-r7/dap/assignees{/user}","branches_url":"https://api.github.com/repos/tsellers-r7/dap/branches{/branch}","tags_url":"https://api.github.com/repos/tsellers-r7/dap/tags","blobs_url":"https://api.github.com/repos/tsellers-r7/dap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsellers-r7/dap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsellers-r7/dap/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsellers-r7/dap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsellers-r7/dap/statuses/{sha}","languages_url":"https://api.github.com/repos/tsellers-r7/dap/languages","stargazers_url":"https://api.github.com/repos/tsellers-r7/dap/stargazers","contributors_url":"https://api.github.com/repos/tsellers-r7/dap/contributors","subscribers_url":"https://api.github.com/repos/tsellers-r7/dap/subscribers","subscription_url":"https://api.github.com/repos/tsellers-r7/dap/subscription","commits_url":"https://api.github.com/repos/tsellers-r7/dap/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsellers-r7/dap/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsellers-r7/dap/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsellers-r7/dap/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsellers-r7/dap/contents/{+path}","compare_url":"https://api.github.com/repos/tsellers-r7/dap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsellers-r7/dap/merges","archive_url":"https://api.github.com/repos/tsellers-r7/dap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsellers-r7/dap/downloads","issues_url":"https://api.github.com/repos/tsellers-r7/dap/issues{/number}","pulls_url":"https://api.github.com/repos/tsellers-r7/dap/pulls{/number}","milestones_url":"https://api.github.com/repos/tsellers-r7/dap/milestones{/number}","notifications_url":"https://api.github.com/repos/tsellers-r7/dap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsellers-r7/dap/labels{/name}","releases_url":"https://api.github.com/repos/tsellers-r7/dap/releases{/id}","deployments_url":"https://api.github.com/repos/tsellers-r7/dap/deployments","created_at":"2016-07-11T12:58:57Z","updated_at":"2016-07-11T12:58:57Z","pushed_at":"2016-08-08T22:15:42Z","git_url":"git://github.com/tsellers-r7/dap.git","ssh_url":"git@github.com:tsellers-r7/dap.git","clone_url":"https://github.com/tsellers-r7/dap.git","svn_url":"https://github.com/tsellers-r7/dap","homepage":null,"size":1282,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rapid7:master","ref":"master","sha":"375fec59384fadf4c937a9a96fedd7db8cbc725b","user":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"repo":{"id":14264205,"name":"dap","full_name":"rapid7/dap","owner":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rapid7/dap","description":"Data Analysis Pipeline","fork":false,"url":"https://api.github.com/repos/rapid7/dap","forks_url":"https://api.github.com/repos/rapid7/dap/forks","keys_url":"https://api.github.com/repos/rapid7/dap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rapid7/dap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rapid7/dap/teams","hooks_url":"https://api.github.com/repos/rapid7/dap/hooks","issue_events_url":"https://api.github.com/repos/rapid7/dap/issues/events{/number}","events_url":"https://api.github.com/repos/rapid7/dap/events","assignees_url":"https://api.github.com/repos/rapid7/dap/assignees{/user}","branches_url":"https://api.github.com/repos/rapid7/dap/branches{/branch}","tags_url":"https://api.github.com/repos/rapid7/dap/tags","blobs_url":"https://api.github.com/repos/rapid7/dap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rapid7/dap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rapid7/dap/git/refs{/sha}","trees_url":"https://api.github.com/repos/rapid7/dap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rapid7/dap/statuses/{sha}","languages_url":"https://api.github.com/repos/rapid7/dap/languages","stargazers_url":"https://api.github.com/repos/rapid7/dap/stargazers","contributors_url":"https://api.github.com/repos/rapid7/dap/contributors","subscribers_url":"https://api.github.com/repos/rapid7/dap/subscribers","subscription_url":"https://api.github.com/repos/rapid7/dap/subscription","commits_url":"https://api.github.com/repos/rapid7/dap/commits{/sha}","git_commits_url":"https://api.github.com/repos/rapid7/dap/git/commits{/sha}","comments_url":"https://api.github.com/repos/rapid7/dap/comments{/number}","issue_comment_url":"https://api.github.com/repos/rapid7/dap/issues/comments{/number}","contents_url":"https://api.github.com/repos/rapid7/dap/contents/{+path}","compare_url":"https://api.github.com/repos/rapid7/dap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rapid7/dap/merges","archive_url":"https://api.github.com/repos/rapid7/dap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rapid7/dap/downloads","issues_url":"https://api.github.com/repos/rapid7/dap/issues{/number}","pulls_url":"https://api.github.com/repos/rapid7/dap/pulls{/number}","milestones_url":"https://api.github.com/repos/rapid7/dap/milestones{/number}","notifications_url":"https://api.github.com/repos/rapid7/dap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rapid7/dap/labels{/name}","releases_url":"https://api.github.com/repos/rapid7/dap/releases{/id}","deployments_url":"https://api.github.com/repos/rapid7/dap/deployments","created_at":"2013-11-09T20:14:34Z","updated_at":"2016-07-24T09:38:17Z","pushed_at":"2016-08-08T22:18:21Z","git_url":"git://github.com/rapid7/dap.git","ssh_url":"git@github.com:rapid7/dap.git","clone_url":"https://github.com/rapid7/dap.git","svn_url":"https://github.com/rapid7/dap","homepage":null,"size":1275,"stargazers_count":44,"watchers_count":44,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":3,"forks":10,"open_issues":3,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rapid7/dap/pulls/17"},"html":{"href":"https://github.com/rapid7/dap/pull/17"},"issue":{"href":"https://api.github.com/repos/rapid7/dap/issues/17"},"comments":{"href":"https://api.github.com/repos/rapid7/dap/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/rapid7/dap/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/rapid7/dap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rapid7/dap/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/rapid7/dap/statuses/60efb48180f02393faeef3e8d9a105a67d92da7b"}}}}
{"actor":{"display_login":"tsellers-r7"}}