{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/vaadin-date-picker/issues/242","repository_url":"https://api.github.com/repos/vaadin/vaadin-date-picker","labels_url":"https://api.github.com/repos/vaadin/vaadin-date-picker/issues/242/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/vaadin-date-picker/issues/242/comments","events_url":"https://api.github.com/repos/vaadin/vaadin-date-picker/issues/242/events","html_url":"https://github.com/vaadin/vaadin-date-picker/pull/242","id":178369799,"number":242,"title":"Improve swipe gesture to reveal year scroller","user":{"login":"tehapo","id":368220,"avatar_url":"https://avatars.githubusercontent.com/u/368220?v=3","gravatar_id":"","url":"https://api.github.com/users/tehapo","html_url":"https://github.com/tehapo","followers_url":"https://api.github.com/users/tehapo/followers","following_url":"https://api.github.com/users/tehapo/following{/other_user}","gists_url":"https://api.github.com/users/tehapo/gists{/gist_id}","starred_url":"https://api.github.com/users/tehapo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tehapo/subscriptions","organizations_url":"https://api.github.com/users/tehapo/orgs","repos_url":"https://api.github.com/users/tehapo/repos","events_url":"https://api.github.com/users/tehapo/events{/privacy}","received_events_url":"https://api.github.com/users/tehapo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/vaadin/vaadin-date-picker/labels/in%20review","name":"in review","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-09-21T14:50:00Z","updated_at":"2016-09-23T08:06:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vaadin/vaadin-date-picker/pulls/242","html_url":"https://github.com/vaadin/vaadin-date-picker/pull/242","diff_url":"https://github.com/vaadin/vaadin-date-picker/pull/242.diff","patch_url":"https://github.com/vaadin/vaadin-date-picker/pull/242.patch"},"body":"Fixes #190 \r\n\r\nSome notes for review.\r\n* Only way to really review this is to simply try this out with an Android and/or iOS device. If your device has too large screen, you might need to tweak the `iron-media-query` in `vaadin-date-picker-overlay` and increase the `min-width`.\r\n* This PR improves three things.\r\n  * A costly repaint is avoided by adding the `will-change` CSS property to the icon that gets rotated.\r\n  * The `on-track` is moved one level up in the DOM to actually track also when swiping on top of the year scroller to hide it.\r\n  * Handling the `track` state is rewritten and should now feel more natural and also support a fast fling instead of just a deliberate and slow swipe.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/vaadin-date-picker/242)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/vaadin/vaadin-date-picker/issues/comments/249128997","html_url":"https://github.com/vaadin/vaadin-date-picker/pull/242#issuecomment-249128997","issue_url":"https://api.github.com/repos/vaadin/vaadin-date-picker/issues/242","id":249128997,"user":{"login":"tomivirkki","id":1222264,"avatar_url":"https://avatars.githubusercontent.com/u/1222264?v=3","gravatar_id":"","url":"https://api.github.com/users/tomivirkki","html_url":"https://github.com/tomivirkki","followers_url":"https://api.github.com/users/tomivirkki/followers","following_url":"https://api.github.com/users/tomivirkki/following{/other_user}","gists_url":"https://api.github.com/users/tomivirkki/gists{/gist_id}","starred_url":"https://api.github.com/users/tomivirkki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomivirkki/subscriptions","organizations_url":"https://api.github.com/users/tomivirkki/orgs","repos_url":"https://api.github.com/users/tomivirkki/repos","events_url":"https://api.github.com/users/tomivirkki/events{/privacy}","received_events_url":"https://api.github.com/users/tomivirkki/received_events","type":"User","site_admin":false},"created_at":"2016-09-23T08:06:05Z","updated_at":"2016-09-23T08:06:05Z","body":"For some reason the year scroller isn't scrollable (on iPad 2) with this change... if that's not an issue then <img class=\"emoji\" title=\":lgtm:\" alt=\":lgtm:\" align=\"absmiddle\" src=\"https://reviewable.io/lgtm.png\" height=\"20\" width=\"61\"/>\n\n---\n\n\n\n\n\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/vaadin/vaadin-date-picker/242#-:-KSL1uthp8HzHYxJ74sB:bp93d9q)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"tomivirkki"}}