{"action":"created","issue":{"url":"https://api.github.com/repos/openmrs/openmrs-core/issues/1875","repository_url":"https://api.github.com/repos/openmrs/openmrs-core","labels_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/1875/labels{/name}","comments_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/1875/comments","events_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/1875/events","html_url":"https://github.com/openmrs/openmrs-core/pull/1875","id":190746514,"number":1875,"title":"TRUNK-4958: Refactored OpenmrsUtil.copyFile method","user":{"login":"lkukielka","id":17404322,"avatar_url":"https://avatars.githubusercontent.com/u/17404322?v=3","gravatar_id":"","url":"https://api.github.com/users/lkukielka","html_url":"https://github.com/lkukielka","followers_url":"https://api.github.com/users/lkukielka/followers","following_url":"https://api.github.com/users/lkukielka/following{/other_user}","gists_url":"https://api.github.com/users/lkukielka/gists{/gist_id}","starred_url":"https://api.github.com/users/lkukielka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lkukielka/subscriptions","organizations_url":"https://api.github.com/users/lkukielka/orgs","repos_url":"https://api.github.com/users/lkukielka/repos","events_url":"https://api.github.com/users/lkukielka/events{/privacy}","received_events_url":"https://api.github.com/users/lkukielka/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":19,"created_at":"2016-11-21T15:20:21Z","updated_at":"2016-12-27T15:37:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/1875","html_url":"https://github.com/openmrs/openmrs-core/pull/1875","diff_url":"https://github.com/openmrs/openmrs-core/pull/1875.diff","patch_url":"https://github.com/openmrs/openmrs-core/pull/1875.patch"},"body":"<!--- Provide PR Title above as: 'TRUNK-JiraIssueNumber JiraIssueTitle' -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nI replaced custom implementation of copy file in OpenmrsUtil.copyFile(...) with the apache commons IOUtils.copy(...). This is for reducing the code. I also added 3 tests for testing above functionality. I also decided to change method return type from void to boolean. It didnt change usage of method but helped with testing.\r\n\r\n## Related Issue\r\n<!--- This project only accepts pull requests related to open issues -->\r\n<!--- If suggesting a new feature or change, please discuss it in an issue\r\nfirst -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to\r\nreproduce -->\r\n<!--- Please link to the issue here: -->\r\nsee https://issues.openmrs.org/browse/TRUNK-4958\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that\r\napply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to\r\nhelp! -->\r\n- [ ] My pull request only contains one single commit.\r\n- [ ] My pull request is based on the latest master branch\r\n  `git pull --rebase upstream master`.\r\n- [ ] I ran `mvn clean package` right before creating this pull request and\r\n  added all formatting changes to my commit.\r\n- [ ] My code follows the code style of this project.\r\n- [ ] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All new and existing tests passed.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/openmrs/openmrs-core/issues/comments/269341603","html_url":"https://github.com/openmrs/openmrs-core/pull/1875#issuecomment-269341603","issue_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/1875","id":269341603,"user":{"login":"dkayiwa","id":1390773,"avatar_url":"https://avatars.githubusercontent.com/u/1390773?v=3","gravatar_id":"","url":"https://api.github.com/users/dkayiwa","html_url":"https://github.com/dkayiwa","followers_url":"https://api.github.com/users/dkayiwa/followers","following_url":"https://api.github.com/users/dkayiwa/following{/other_user}","gists_url":"https://api.github.com/users/dkayiwa/gists{/gist_id}","starred_url":"https://api.github.com/users/dkayiwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkayiwa/subscriptions","organizations_url":"https://api.github.com/users/dkayiwa/orgs","repos_url":"https://api.github.com/users/dkayiwa/repos","events_url":"https://api.github.com/users/dkayiwa/events{/privacy}","received_events_url":"https://api.github.com/users/dkayiwa/received_events","type":"User","site_admin":false},"created_at":"2016-12-27T15:37:40Z","updated_at":"2016-12-27T15:37:40Z","body":"@lkukielka you actually do not have to inform me. We have a process here that you need to follow: https://wiki.openmrs.org/display/docs/Pull+Request+Tips\r\nCan you go through it and do the needful?"}}
{"actor":{"display_login":"dkayiwa"}}