{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/56248864","id":56248864,"diff_hunk":"@@ -833,3 +853,6 @@ config.substitutions.append(('%target-object-format', config.target_object_forma\n \n config.substitutions.append(('%target-resilience-test-wmo', config.target_resilience_test_wmo))\n config.substitutions.append(('%target-resilience-test', config.target_resilience_test))\n+\n+config.substitutions.append(('%target-llvm-profdata', os.path.join(llvm_tools_dir, 'llvm-profdata')))\n+config.substitutions.append(('%target-llvm-cov', os.path.join(llvm_tools_dir, 'llvm-cov')))","path":"test/lit.cfg","position":33,"original_position":33,"commit_id":"a1fbd05ba14dd77ea94950842cd1091bf077337c","original_commit_id":"a1fbd05ba14dd77ea94950842cd1091bf077337c","user":{"login":"jrose-apple","id":15097531,"avatar_url":"https://avatars.githubusercontent.com/u/15097531?v=3","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"body":"Is anyone using these, though? Do you expect anyone to set them from the command line? If not, you should just ignore them altogether, like FileCheck.","created_at":"2016-03-15T22:01:34Z","updated_at":"2016-03-15T22:01:34Z","html_url":"https://github.com/apple/swift/pull/1678#discussion_r56248864","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/1678","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/56248864"},"html":{"href":"https://github.com/apple/swift/pull/1678#discussion_r56248864"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/1678"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/1678","id":62785826,"html_url":"https://github.com/apple/swift/pull/1678","diff_url":"https://github.com/apple/swift/pull/1678.diff","patch_url":"https://github.com/apple/swift/pull/1678.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/1678","number":1678,"state":"open","locked":false,"title":"Hook compiler-rt up to the swift build system","user":{"login":"vedantk","id":97683,"avatar_url":"https://avatars.githubusercontent.com/u/97683?v=3","gravatar_id":"","url":"https://api.github.com/users/vedantk","html_url":"https://github.com/vedantk","followers_url":"https://api.github.com/users/vedantk/followers","following_url":"https://api.github.com/users/vedantk/following{/other_user}","gists_url":"https://api.github.com/users/vedantk/gists{/gist_id}","starred_url":"https://api.github.com/users/vedantk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vedantk/subscriptions","organizations_url":"https://api.github.com/users/vedantk/orgs","repos_url":"https://api.github.com/users/vedantk/repos","events_url":"https://api.github.com/users/vedantk/events{/privacy}","received_events_url":"https://api.github.com/users/vedantk/received_events","type":"User","site_admin":false},"body":"#### What's in this pull request?\r\nAn updated version of the patch to build compiler-rt along with swift.\r\n\r\n* * * *\r\n\r\nBefore merging this pull request to apple/swift repository:\r\n- [ ] Test pull request on Swift continuous integration.\r\n\r\n<details>\r\n  <summary>Triggering Swift CI</summary>\r\n\r\nThe swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:\r\n\r\n**Smoke Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please smoke test\r\n        OS X platform               | @swift-ci Please smoke test OS X platform\r\n        Linux platform              | @swift-ci Please smoke test Linux platform\r\n\r\n **Validation Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please test\r\n        OS X platform               | @swift-ci Please test OS X platform\r\n        Linux platform              | @swift-ci Please test Linux platform\r\n\r\nNote: Only members of the Apple organization can trigger swift-ci.\r\n</details>\r\n\r\n","created_at":"2016-03-14T17:27:28Z","updated_at":"2016-03-15T22:01:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81c8ede75971b736e3339eeecf383f9247b8679b","assignee":{"login":"vedantk","id":97683,"avatar_url":"https://avatars.githubusercontent.com/u/97683?v=3","gravatar_id":"","url":"https://api.github.com/users/vedantk","html_url":"https://github.com/vedantk","followers_url":"https://api.github.com/users/vedantk/followers","following_url":"https://api.github.com/users/vedantk/following{/other_user}","gists_url":"https://api.github.com/users/vedantk/gists{/gist_id}","starred_url":"https://api.github.com/users/vedantk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vedantk/subscriptions","organizations_url":"https://api.github.com/users/vedantk/orgs","repos_url":"https://api.github.com/users/vedantk/repos","events_url":"https://api.github.com/users/vedantk/events{/privacy}","received_events_url":"https://api.github.com/users/vedantk/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/1678/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/1678/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/1678/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/a1fbd05ba14dd77ea94950842cd1091bf077337c","head":{"label":"vedantk:compiler-rt","ref":"compiler-rt","sha":"a1fbd05ba14dd77ea94950842cd1091bf077337c","user":{"login":"vedantk","id":97683,"avatar_url":"https://avatars.githubusercontent.com/u/97683?v=3","gravatar_id":"","url":"https://api.github.com/users/vedantk","html_url":"https://github.com/vedantk","followers_url":"https://api.github.com/users/vedantk/followers","following_url":"https://api.github.com/users/vedantk/following{/other_user}","gists_url":"https://api.github.com/users/vedantk/gists{/gist_id}","starred_url":"https://api.github.com/users/vedantk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vedantk/subscriptions","organizations_url":"https://api.github.com/users/vedantk/orgs","repos_url":"https://api.github.com/users/vedantk/repos","events_url":"https://api.github.com/users/vedantk/events{/privacy}","received_events_url":"https://api.github.com/users/vedantk/received_events","type":"User","site_admin":false},"repo":{"id":50128431,"name":"swift","full_name":"vedantk/swift","owner":{"login":"vedantk","id":97683,"avatar_url":"https://avatars.githubusercontent.com/u/97683?v=3","gravatar_id":"","url":"https://api.github.com/users/vedantk","html_url":"https://github.com/vedantk","followers_url":"https://api.github.com/users/vedantk/followers","following_url":"https://api.github.com/users/vedantk/following{/other_user}","gists_url":"https://api.github.com/users/vedantk/gists{/gist_id}","starred_url":"https://api.github.com/users/vedantk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vedantk/subscriptions","organizations_url":"https://api.github.com/users/vedantk/orgs","repos_url":"https://api.github.com/users/vedantk/repos","events_url":"https://api.github.com/users/vedantk/events{/privacy}","received_events_url":"https://api.github.com/users/vedantk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vedantk/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/vedantk/swift","forks_url":"https://api.github.com/repos/vedantk/swift/forks","keys_url":"https://api.github.com/repos/vedantk/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vedantk/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vedantk/swift/teams","hooks_url":"https://api.github.com/repos/vedantk/swift/hooks","issue_events_url":"https://api.github.com/repos/vedantk/swift/issues/events{/number}","events_url":"https://api.github.com/repos/vedantk/swift/events","assignees_url":"https://api.github.com/repos/vedantk/swift/assignees{/user}","branches_url":"https://api.github.com/repos/vedantk/swift/branches{/branch}","tags_url":"https://api.github.com/repos/vedantk/swift/tags","blobs_url":"https://api.github.com/repos/vedantk/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vedantk/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vedantk/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/vedantk/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vedantk/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/vedantk/swift/languages","stargazers_url":"https://api.github.com/repos/vedantk/swift/stargazers","contributors_url":"https://api.github.com/repos/vedantk/swift/contributors","subscribers_url":"https://api.github.com/repos/vedantk/swift/subscribers","subscription_url":"https://api.github.com/repos/vedantk/swift/subscription","commits_url":"https://api.github.com/repos/vedantk/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/vedantk/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/vedantk/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/vedantk/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/vedantk/swift/contents/{+path}","compare_url":"https://api.github.com/repos/vedantk/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vedantk/swift/merges","archive_url":"https://api.github.com/repos/vedantk/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vedantk/swift/downloads","issues_url":"https://api.github.com/repos/vedantk/swift/issues{/number}","pulls_url":"https://api.github.com/repos/vedantk/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/vedantk/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/vedantk/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vedantk/swift/labels{/name}","releases_url":"https://api.github.com/repos/vedantk/swift/releases{/id}","deployments_url":"https://api.github.com/repos/vedantk/swift/deployments","created_at":"2016-01-21T18:38:23Z","updated_at":"2016-01-21T18:38:39Z","pushed_at":"2016-03-14T17:24:53Z","git_url":"git://github.com/vedantk/swift.git","ssh_url":"git@github.com:vedantk/swift.git","clone_url":"https://github.com/vedantk/swift.git","svn_url":"https://github.com/vedantk/swift","homepage":"https://swift.org/","size":78408,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"0bdf4a982494c84e216b9b0b84e1143892e3bf5a","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2016-03-15T21:52:28Z","pushed_at":"2016-03-15T22:00:59Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":108853,"stargazers_count":27647,"watchers_count":27647,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3614,"mirror_url":null,"open_issues_count":57,"forks":3614,"open_issues":57,"watchers":27647,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/1678"},"html":{"href":"https://github.com/apple/swift/pull/1678"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/1678"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/1678/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/1678/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/1678/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/a1fbd05ba14dd77ea94950842cd1091bf077337c"}}}}