{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues/942","repository_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues/942/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues/942/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues/942/events","html_url":"https://github.com/GoogleCloudPlatform/cloud-bigtable-client/pull/942","id":169504833,"number":942,"title":"Fix javadoc:aggregate-jar target","user":{"login":"rameshdharan","id":517036,"avatar_url":"https://avatars.githubusercontent.com/u/517036?v=3","gravatar_id":"","url":"https://api.github.com/users/rameshdharan","html_url":"https://github.com/rameshdharan","followers_url":"https://api.github.com/users/rameshdharan/followers","following_url":"https://api.github.com/users/rameshdharan/following{/other_user}","gists_url":"https://api.github.com/users/rameshdharan/gists{/gist_id}","starred_url":"https://api.github.com/users/rameshdharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rameshdharan/subscriptions","organizations_url":"https://api.github.com/users/rameshdharan/orgs","repos_url":"https://api.github.com/users/rameshdharan/repos","events_url":"https://api.github.com/users/rameshdharan/events{/privacy}","received_events_url":"https://api.github.com/users/rameshdharan/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-05T00:33:42Z","updated_at":"2016-08-05T00:39:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/pulls/942","html_url":"https://github.com/GoogleCloudPlatform/cloud-bigtable-client/pull/942","diff_url":"https://github.com/GoogleCloudPlatform/cloud-bigtable-client/pull/942.diff","patch_url":"https://github.com/GoogleCloudPlatform/cloud-bigtable-client/pull/942.patch"},"body":"This change makes the javadoc:aggregate-jar target work at the\ntop-level.\n\nDoing this correclty is complicated because javadoc:aggregate is\nconfused by the repackaged/shadedPattern renaming of the bigtable client\nin the dataflow submodules.\n\nAfter a lot of experimentation, banging my head against the wall, and\ndiscussions with Jeff I decided the best way to handle javadoc at\nthe top-level was simply to exclude the dataflow projects; we already\nhave a way to handle and publish those docs that we aren't going to\nchange, so we simply skip the com.google.cloud.bigtable.dataflow*\npackages when doing a top-level javadoc:aggregate[-jar] for the main\nproject.\n\nI also made a change to ensure that you can turn back on the doclint\nbehavior by passing -Ddoclint on the commandline if you want to inspect\nit for any javadoc target, though it's still not particularly useful\ngiven all the noise from grpc-java (and note that they have it disabled\nin their build).\n\nI also made some tweaks to the way we express configuration so the\njavadoc stuff will apply for all profiles, and the aggregate-jar target\nwill be used during the package phase.\n\nFinally I threw in a couple of fixes for new warnings that I noticed."},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues/comments/237726538","html_url":"https://github.com/GoogleCloudPlatform/cloud-bigtable-client/pull/942#issuecomment-237726538","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues/942","id":237726538,"user":{"login":"sduskis","id":99305,"avatar_url":"https://avatars.githubusercontent.com/u/99305?v=3","gravatar_id":"","url":"https://api.github.com/users/sduskis","html_url":"https://github.com/sduskis","followers_url":"https://api.github.com/users/sduskis/followers","following_url":"https://api.github.com/users/sduskis/following{/other_user}","gists_url":"https://api.github.com/users/sduskis/gists{/gist_id}","starred_url":"https://api.github.com/users/sduskis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sduskis/subscriptions","organizations_url":"https://api.github.com/users/sduskis/orgs","repos_url":"https://api.github.com/users/sduskis/repos","events_url":"https://api.github.com/users/sduskis/events{/privacy}","received_events_url":"https://api.github.com/users/sduskis/received_events","type":"User","site_admin":false},"created_at":"2016-08-05T00:39:30Z","updated_at":"2016-08-05T00:39:30Z","body":"LGTM.\r\n\r\nI have a follow up request for another PR.  Let's please get rid of the v1 proto files and the excludePackageNames."}}
{"actor":{"display_login":"sduskis"}}