{"action":"created","comment":{"url":"https://api.github.com/repos/mesonbuild/meson/pulls/comments/89675263","pull_request_review_id":10218446,"id":89675263,"diff_hunk":"@@ -380,7 +380,12 @@ def run_tests(extra_args):\n     build_time = 0\n     test_time = 0\n \n-    executor = conc.ProcessPoolExecutor(max_workers=multiprocessing.cpu_count())\n+    try:\n+        # This fails in some CI environments for unknown reasons.\n+        num_workers = multiprocessing.cpu_count()\n+    except Exception:","path":"run_project_tests.py","position":8,"original_position":8,"commit_id":"30db0b18bbfa4ae21dffb61aab36f97a43929b35","original_commit_id":"30db0b18bbfa4ae21dffb61aab36f97a43929b35","user":{"login":"jpakkane","id":4079821,"avatar_url":"https://avatars.githubusercontent.com/u/4079821?v=3","gravatar_id":"","url":"https://api.github.com/users/jpakkane","html_url":"https://github.com/jpakkane","followers_url":"https://api.github.com/users/jpakkane/followers","following_url":"https://api.github.com/users/jpakkane/following{/other_user}","gists_url":"https://api.github.com/users/jpakkane/gists{/gist_id}","starred_url":"https://api.github.com/users/jpakkane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpakkane/subscriptions","organizations_url":"https://api.github.com/users/jpakkane/orgs","repos_url":"https://api.github.com/users/jpakkane/repos","events_url":"https://api.github.com/users/jpakkane/events{/privacy}","received_events_url":"https://api.github.com/users/jpakkane/received_events","type":"User","site_admin":false},"body":"Why not `Exception`? I tested this manually and it catches a `NotImplementedError` without problems as it inherits from `Exception`. Also, the error we get in Debian reproducible builds is not `NotImplementedError` but instead something else (related so semaphors?), but sadly I don't have a link to the error log handy.","created_at":"2016-11-26T17:55:09Z","updated_at":"2016-11-26T17:55:09Z","html_url":"https://github.com/mesonbuild/meson/pull/1090#discussion_r89675263","pull_request_url":"https://api.github.com/repos/mesonbuild/meson/pulls/1090","_links":{"self":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/comments/89675263"},"html":{"href":"https://github.com/mesonbuild/meson/pull/1090#discussion_r89675263"},"pull_request":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/1090"}}},"pull_request":{"url":"https://api.github.com/repos/mesonbuild/meson/pulls/1090","id":94893763,"html_url":"https://github.com/mesonbuild/meson/pull/1090","diff_url":"https://github.com/mesonbuild/meson/pull/1090.diff","patch_url":"https://github.com/mesonbuild/meson/pull/1090.patch","issue_url":"https://api.github.com/repos/mesonbuild/meson/issues/1090","number":1090,"state":"open","locked":false,"title":"Guard against cpu_count failing.","user":{"login":"jpakkane","id":4079821,"avatar_url":"https://avatars.githubusercontent.com/u/4079821?v=3","gravatar_id":"","url":"https://api.github.com/users/jpakkane","html_url":"https://github.com/jpakkane","followers_url":"https://api.github.com/users/jpakkane/followers","following_url":"https://api.github.com/users/jpakkane/following{/other_user}","gists_url":"https://api.github.com/users/jpakkane/gists{/gist_id}","starred_url":"https://api.github.com/users/jpakkane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpakkane/subscriptions","organizations_url":"https://api.github.com/users/jpakkane/orgs","repos_url":"https://api.github.com/users/jpakkane/repos","events_url":"https://api.github.com/users/jpakkane/events{/privacy}","received_events_url":"https://api.github.com/users/jpakkane/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-22T20:39:46Z","updated_at":"2016-11-26T17:55:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6df60584f53244b7c47533689bf2b6e738df7093","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mesonbuild/meson/pulls/1090/commits","review_comments_url":"https://api.github.com/repos/mesonbuild/meson/pulls/1090/comments","review_comment_url":"https://api.github.com/repos/mesonbuild/meson/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesonbuild/meson/issues/1090/comments","statuses_url":"https://api.github.com/repos/mesonbuild/meson/statuses/30db0b18bbfa4ae21dffb61aab36f97a43929b35","head":{"label":"mesonbuild:multiproc","ref":"multiproc","sha":"30db0b18bbfa4ae21dffb61aab36f97a43929b35","user":{"login":"mesonbuild","id":12551236,"avatar_url":"https://avatars.githubusercontent.com/u/12551236?v=3","gravatar_id":"","url":"https://api.github.com/users/mesonbuild","html_url":"https://github.com/mesonbuild","followers_url":"https://api.github.com/users/mesonbuild/followers","following_url":"https://api.github.com/users/mesonbuild/following{/other_user}","gists_url":"https://api.github.com/users/mesonbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/mesonbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesonbuild/subscriptions","organizations_url":"https://api.github.com/users/mesonbuild/orgs","repos_url":"https://api.github.com/users/mesonbuild/repos","events_url":"https://api.github.com/users/mesonbuild/events{/privacy}","received_events_url":"https://api.github.com/users/mesonbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":19784232,"name":"meson","full_name":"mesonbuild/meson","owner":{"login":"mesonbuild","id":12551236,"avatar_url":"https://avatars.githubusercontent.com/u/12551236?v=3","gravatar_id":"","url":"https://api.github.com/users/mesonbuild","html_url":"https://github.com/mesonbuild","followers_url":"https://api.github.com/users/mesonbuild/followers","following_url":"https://api.github.com/users/mesonbuild/following{/other_user}","gists_url":"https://api.github.com/users/mesonbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/mesonbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesonbuild/subscriptions","organizations_url":"https://api.github.com/users/mesonbuild/orgs","repos_url":"https://api.github.com/users/mesonbuild/repos","events_url":"https://api.github.com/users/mesonbuild/events{/privacy}","received_events_url":"https://api.github.com/users/mesonbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesonbuild/meson","description":"The Meson Build System","fork":false,"url":"https://api.github.com/repos/mesonbuild/meson","forks_url":"https://api.github.com/repos/mesonbuild/meson/forks","keys_url":"https://api.github.com/repos/mesonbuild/meson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesonbuild/meson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesonbuild/meson/teams","hooks_url":"https://api.github.com/repos/mesonbuild/meson/hooks","issue_events_url":"https://api.github.com/repos/mesonbuild/meson/issues/events{/number}","events_url":"https://api.github.com/repos/mesonbuild/meson/events","assignees_url":"https://api.github.com/repos/mesonbuild/meson/assignees{/user}","branches_url":"https://api.github.com/repos/mesonbuild/meson/branches{/branch}","tags_url":"https://api.github.com/repos/mesonbuild/meson/tags","blobs_url":"https://api.github.com/repos/mesonbuild/meson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesonbuild/meson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesonbuild/meson/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesonbuild/meson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesonbuild/meson/statuses/{sha}","languages_url":"https://api.github.com/repos/mesonbuild/meson/languages","stargazers_url":"https://api.github.com/repos/mesonbuild/meson/stargazers","contributors_url":"https://api.github.com/repos/mesonbuild/meson/contributors","subscribers_url":"https://api.github.com/repos/mesonbuild/meson/subscribers","subscription_url":"https://api.github.com/repos/mesonbuild/meson/subscription","commits_url":"https://api.github.com/repos/mesonbuild/meson/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesonbuild/meson/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesonbuild/meson/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesonbuild/meson/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesonbuild/meson/contents/{+path}","compare_url":"https://api.github.com/repos/mesonbuild/meson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesonbuild/meson/merges","archive_url":"https://api.github.com/repos/mesonbuild/meson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesonbuild/meson/downloads","issues_url":"https://api.github.com/repos/mesonbuild/meson/issues{/number}","pulls_url":"https://api.github.com/repos/mesonbuild/meson/pulls{/number}","milestones_url":"https://api.github.com/repos/mesonbuild/meson/milestones{/number}","notifications_url":"https://api.github.com/repos/mesonbuild/meson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesonbuild/meson/labels{/name}","releases_url":"https://api.github.com/repos/mesonbuild/meson/releases{/id}","deployments_url":"https://api.github.com/repos/mesonbuild/meson/deployments","created_at":"2014-05-14T15:08:16Z","updated_at":"2016-11-24T18:09:59Z","pushed_at":"2016-11-26T17:11:59Z","git_url":"git://github.com/mesonbuild/meson.git","ssh_url":"git@github.com:mesonbuild/meson.git","clone_url":"https://github.com/mesonbuild/meson.git","svn_url":"https://github.com/mesonbuild/meson","homepage":null,"size":4941,"stargazers_count":569,"watchers_count":569,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":91,"mirror_url":null,"open_issues_count":166,"forks":91,"open_issues":166,"watchers":569,"default_branch":"master"}},"base":{"label":"mesonbuild:master","ref":"master","sha":"587a0bb3d14addcacd62282a46957b86d582f1be","user":{"login":"mesonbuild","id":12551236,"avatar_url":"https://avatars.githubusercontent.com/u/12551236?v=3","gravatar_id":"","url":"https://api.github.com/users/mesonbuild","html_url":"https://github.com/mesonbuild","followers_url":"https://api.github.com/users/mesonbuild/followers","following_url":"https://api.github.com/users/mesonbuild/following{/other_user}","gists_url":"https://api.github.com/users/mesonbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/mesonbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesonbuild/subscriptions","organizations_url":"https://api.github.com/users/mesonbuild/orgs","repos_url":"https://api.github.com/users/mesonbuild/repos","events_url":"https://api.github.com/users/mesonbuild/events{/privacy}","received_events_url":"https://api.github.com/users/mesonbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":19784232,"name":"meson","full_name":"mesonbuild/meson","owner":{"login":"mesonbuild","id":12551236,"avatar_url":"https://avatars.githubusercontent.com/u/12551236?v=3","gravatar_id":"","url":"https://api.github.com/users/mesonbuild","html_url":"https://github.com/mesonbuild","followers_url":"https://api.github.com/users/mesonbuild/followers","following_url":"https://api.github.com/users/mesonbuild/following{/other_user}","gists_url":"https://api.github.com/users/mesonbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/mesonbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesonbuild/subscriptions","organizations_url":"https://api.github.com/users/mesonbuild/orgs","repos_url":"https://api.github.com/users/mesonbuild/repos","events_url":"https://api.github.com/users/mesonbuild/events{/privacy}","received_events_url":"https://api.github.com/users/mesonbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesonbuild/meson","description":"The Meson Build System","fork":false,"url":"https://api.github.com/repos/mesonbuild/meson","forks_url":"https://api.github.com/repos/mesonbuild/meson/forks","keys_url":"https://api.github.com/repos/mesonbuild/meson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesonbuild/meson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesonbuild/meson/teams","hooks_url":"https://api.github.com/repos/mesonbuild/meson/hooks","issue_events_url":"https://api.github.com/repos/mesonbuild/meson/issues/events{/number}","events_url":"https://api.github.com/repos/mesonbuild/meson/events","assignees_url":"https://api.github.com/repos/mesonbuild/meson/assignees{/user}","branches_url":"https://api.github.com/repos/mesonbuild/meson/branches{/branch}","tags_url":"https://api.github.com/repos/mesonbuild/meson/tags","blobs_url":"https://api.github.com/repos/mesonbuild/meson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesonbuild/meson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesonbuild/meson/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesonbuild/meson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesonbuild/meson/statuses/{sha}","languages_url":"https://api.github.com/repos/mesonbuild/meson/languages","stargazers_url":"https://api.github.com/repos/mesonbuild/meson/stargazers","contributors_url":"https://api.github.com/repos/mesonbuild/meson/contributors","subscribers_url":"https://api.github.com/repos/mesonbuild/meson/subscribers","subscription_url":"https://api.github.com/repos/mesonbuild/meson/subscription","commits_url":"https://api.github.com/repos/mesonbuild/meson/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesonbuild/meson/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesonbuild/meson/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesonbuild/meson/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesonbuild/meson/contents/{+path}","compare_url":"https://api.github.com/repos/mesonbuild/meson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesonbuild/meson/merges","archive_url":"https://api.github.com/repos/mesonbuild/meson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesonbuild/meson/downloads","issues_url":"https://api.github.com/repos/mesonbuild/meson/issues{/number}","pulls_url":"https://api.github.com/repos/mesonbuild/meson/pulls{/number}","milestones_url":"https://api.github.com/repos/mesonbuild/meson/milestones{/number}","notifications_url":"https://api.github.com/repos/mesonbuild/meson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesonbuild/meson/labels{/name}","releases_url":"https://api.github.com/repos/mesonbuild/meson/releases{/id}","deployments_url":"https://api.github.com/repos/mesonbuild/meson/deployments","created_at":"2014-05-14T15:08:16Z","updated_at":"2016-11-24T18:09:59Z","pushed_at":"2016-11-26T17:11:59Z","git_url":"git://github.com/mesonbuild/meson.git","ssh_url":"git@github.com:mesonbuild/meson.git","clone_url":"https://github.com/mesonbuild/meson.git","svn_url":"https://github.com/mesonbuild/meson","homepage":null,"size":4941,"stargazers_count":569,"watchers_count":569,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":91,"mirror_url":null,"open_issues_count":166,"forks":91,"open_issues":166,"watchers":569,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/1090"},"html":{"href":"https://github.com/mesonbuild/meson/pull/1090"},"issue":{"href":"https://api.github.com/repos/mesonbuild/meson/issues/1090"},"comments":{"href":"https://api.github.com/repos/mesonbuild/meson/issues/1090/comments"},"review_comments":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/1090/comments"},"review_comment":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/1090/commits"},"statuses":{"href":"https://api.github.com/repos/mesonbuild/meson/statuses/30db0b18bbfa4ae21dffb61aab36f97a43929b35"}}}}
{"actor":{"display_login":"jpakkane"}}