{"action":"created","comment":{"url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/comments/78321902","id":78321902,"diff_hunk":"@@ -292,10 +292,11 @@ def postInstall(self):\n         # However, we ignore the case where the remote already exists,\n         # which occurs when the content itself provides the remote\n         # config file.\n-        sysroot = OSTree.Sysroot.new(self._sysroot_path)\n+        sysroot_path = Gio.File.new_for_path(iutil.getSysroot())\n+        sysroot = OSTree.Sysroot.new(sysroot_path)","path":"pyanaconda/packaging/rpmostreepayload.py","position":6,"original_position":6,"commit_id":"56e9779abec39371d1e50008d6b1bfddce70978b","original_commit_id":"56e9779abec39371d1e50008d6b1bfddce70978b","user":{"login":"vpodzime","id":1044278,"avatar_url":"https://avatars.githubusercontent.com/u/1044278?v=3","gravatar_id":"","url":"https://api.github.com/users/vpodzime","html_url":"https://github.com/vpodzime","followers_url":"https://api.github.com/users/vpodzime/followers","following_url":"https://api.github.com/users/vpodzime/following{/other_user}","gists_url":"https://api.github.com/users/vpodzime/gists{/gist_id}","starred_url":"https://api.github.com/users/vpodzime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpodzime/subscriptions","organizations_url":"https://api.github.com/users/vpodzime/orgs","repos_url":"https://api.github.com/users/vpodzime/repos","events_url":"https://api.github.com/users/vpodzime/events{/privacy}","received_events_url":"https://api.github.com/users/vpodzime/received_events","type":"User","site_admin":false},"body":"I have no idea what's going on in this patch, but maybe ``sysroot_file`` would be a better name for the variable?","created_at":"2016-09-12T06:53:57Z","updated_at":"2016-09-12T06:53:57Z","html_url":"https://github.com/rhinstaller/anaconda/pull/781#discussion_r78321902","pull_request_url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/781","_links":{"self":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/comments/78321902"},"html":{"href":"https://github.com/rhinstaller/anaconda/pull/781#discussion_r78321902"},"pull_request":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/781"}}},"pull_request":{"url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/781","id":84741598,"html_url":"https://github.com/rhinstaller/anaconda/pull/781","diff_url":"https://github.com/rhinstaller/anaconda/pull/781.diff","patch_url":"https://github.com/rhinstaller/anaconda/pull/781.patch","issue_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/781","number":781,"state":"open","locked":false,"title":"rpmostreepayload: Fix remote handling to use correct sysroot","user":{"login":"cgwalters","id":244096,"avatar_url":"https://avatars.githubusercontent.com/u/244096?v=3","gravatar_id":"","url":"https://api.github.com/users/cgwalters","html_url":"https://github.com/cgwalters","followers_url":"https://api.github.com/users/cgwalters/followers","following_url":"https://api.github.com/users/cgwalters/following{/other_user}","gists_url":"https://api.github.com/users/cgwalters/gists{/gist_id}","starred_url":"https://api.github.com/users/cgwalters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgwalters/subscriptions","organizations_url":"https://api.github.com/users/cgwalters/orgs","repos_url":"https://api.github.com/users/cgwalters/repos","events_url":"https://api.github.com/users/cgwalters/events{/privacy}","received_events_url":"https://api.github.com/users/cgwalters/received_events","type":"User","site_admin":false},"body":"I'm working on Atomic Workstation, and putting the ostree remote\r\nconfig into a package (same as CentOS is doing it), and this\r\nis the current recommendation.\r\n\r\nSee\r\nhttps://github.com/rhinstaller/anaconda/pull/474\r\nfor some previous discussion around this.\r\n\r\nRecently, this broke; we end up deleting the remote in the package,\r\nand the reason for this is we're using the *physical* sysroot rather\r\nthan the target, which means we look at the wrong\r\n`/mnt/sysimage/etc/ostree/remotes.d`.\r\n\r\nWhat I don't yet know is *why* this broke - I have a suspicion it's\r\nrelated to some of the mount setup changes bcl did previously here,\r\nbut anyways, this patch fixes things.","created_at":"2016-09-10T02:18:29Z","updated_at":"2016-09-12T06:53:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e2f54bacd3772388ff801de64e83550fc95f5df","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/781/commits","review_comments_url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/781/comments","review_comment_url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/781/comments","statuses_url":"https://api.github.com/repos/rhinstaller/anaconda/statuses/56e9779abec39371d1e50008d6b1bfddce70978b","head":{"label":"cgwalters:rpmostree-fix-remote","ref":"rpmostree-fix-remote","sha":"56e9779abec39371d1e50008d6b1bfddce70978b","user":{"login":"cgwalters","id":244096,"avatar_url":"https://avatars.githubusercontent.com/u/244096?v=3","gravatar_id":"","url":"https://api.github.com/users/cgwalters","html_url":"https://github.com/cgwalters","followers_url":"https://api.github.com/users/cgwalters/followers","following_url":"https://api.github.com/users/cgwalters/following{/other_user}","gists_url":"https://api.github.com/users/cgwalters/gists{/gist_id}","starred_url":"https://api.github.com/users/cgwalters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgwalters/subscriptions","organizations_url":"https://api.github.com/users/cgwalters/orgs","repos_url":"https://api.github.com/users/cgwalters/repos","events_url":"https://api.github.com/users/cgwalters/events{/privacy}","received_events_url":"https://api.github.com/users/cgwalters/received_events","type":"User","site_admin":false},"repo":{"id":30938326,"name":"anaconda","full_name":"cgwalters/anaconda","owner":{"login":"cgwalters","id":244096,"avatar_url":"https://avatars.githubusercontent.com/u/244096?v=3","gravatar_id":"","url":"https://api.github.com/users/cgwalters","html_url":"https://github.com/cgwalters","followers_url":"https://api.github.com/users/cgwalters/followers","following_url":"https://api.github.com/users/cgwalters/following{/other_user}","gists_url":"https://api.github.com/users/cgwalters/gists{/gist_id}","starred_url":"https://api.github.com/users/cgwalters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgwalters/subscriptions","organizations_url":"https://api.github.com/users/cgwalters/orgs","repos_url":"https://api.github.com/users/cgwalters/repos","events_url":"https://api.github.com/users/cgwalters/events{/privacy}","received_events_url":"https://api.github.com/users/cgwalters/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cgwalters/anaconda","description":"Graphical system installer","fork":true,"url":"https://api.github.com/repos/cgwalters/anaconda","forks_url":"https://api.github.com/repos/cgwalters/anaconda/forks","keys_url":"https://api.github.com/repos/cgwalters/anaconda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cgwalters/anaconda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cgwalters/anaconda/teams","hooks_url":"https://api.github.com/repos/cgwalters/anaconda/hooks","issue_events_url":"https://api.github.com/repos/cgwalters/anaconda/issues/events{/number}","events_url":"https://api.github.com/repos/cgwalters/anaconda/events","assignees_url":"https://api.github.com/repos/cgwalters/anaconda/assignees{/user}","branches_url":"https://api.github.com/repos/cgwalters/anaconda/branches{/branch}","tags_url":"https://api.github.com/repos/cgwalters/anaconda/tags","blobs_url":"https://api.github.com/repos/cgwalters/anaconda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cgwalters/anaconda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cgwalters/anaconda/git/refs{/sha}","trees_url":"https://api.github.com/repos/cgwalters/anaconda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cgwalters/anaconda/statuses/{sha}","languages_url":"https://api.github.com/repos/cgwalters/anaconda/languages","stargazers_url":"https://api.github.com/repos/cgwalters/anaconda/stargazers","contributors_url":"https://api.github.com/repos/cgwalters/anaconda/contributors","subscribers_url":"https://api.github.com/repos/cgwalters/anaconda/subscribers","subscription_url":"https://api.github.com/repos/cgwalters/anaconda/subscription","commits_url":"https://api.github.com/repos/cgwalters/anaconda/commits{/sha}","git_commits_url":"https://api.github.com/repos/cgwalters/anaconda/git/commits{/sha}","comments_url":"https://api.github.com/repos/cgwalters/anaconda/comments{/number}","issue_comment_url":"https://api.github.com/repos/cgwalters/anaconda/issues/comments{/number}","contents_url":"https://api.github.com/repos/cgwalters/anaconda/contents/{+path}","compare_url":"https://api.github.com/repos/cgwalters/anaconda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cgwalters/anaconda/merges","archive_url":"https://api.github.com/repos/cgwalters/anaconda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cgwalters/anaconda/downloads","issues_url":"https://api.github.com/repos/cgwalters/anaconda/issues{/number}","pulls_url":"https://api.github.com/repos/cgwalters/anaconda/pulls{/number}","milestones_url":"https://api.github.com/repos/cgwalters/anaconda/milestones{/number}","notifications_url":"https://api.github.com/repos/cgwalters/anaconda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cgwalters/anaconda/labels{/name}","releases_url":"https://api.github.com/repos/cgwalters/anaconda/releases{/id}","deployments_url":"https://api.github.com/repos/cgwalters/anaconda/deployments","created_at":"2015-02-17T21:19:45Z","updated_at":"2015-02-17T21:19:48Z","pushed_at":"2016-09-12T02:09:57Z","git_url":"git://github.com/cgwalters/anaconda.git","ssh_url":"git@github.com:cgwalters/anaconda.git","clone_url":"https://github.com/cgwalters/anaconda.git","svn_url":"https://github.com/cgwalters/anaconda","homepage":null,"size":132590,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rhinstaller:master","ref":"master","sha":"5651d238381cdf1d76ed71b43e7ccee07f273c56","user":{"login":"rhinstaller","id":10549274,"avatar_url":"https://avatars.githubusercontent.com/u/10549274?v=3","gravatar_id":"","url":"https://api.github.com/users/rhinstaller","html_url":"https://github.com/rhinstaller","followers_url":"https://api.github.com/users/rhinstaller/followers","following_url":"https://api.github.com/users/rhinstaller/following{/other_user}","gists_url":"https://api.github.com/users/rhinstaller/gists{/gist_id}","starred_url":"https://api.github.com/users/rhinstaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhinstaller/subscriptions","organizations_url":"https://api.github.com/users/rhinstaller/orgs","repos_url":"https://api.github.com/users/rhinstaller/repos","events_url":"https://api.github.com/users/rhinstaller/events{/privacy}","received_events_url":"https://api.github.com/users/rhinstaller/received_events","type":"Organization","site_admin":false},"repo":{"id":30210846,"name":"anaconda","full_name":"rhinstaller/anaconda","owner":{"login":"rhinstaller","id":10549274,"avatar_url":"https://avatars.githubusercontent.com/u/10549274?v=3","gravatar_id":"","url":"https://api.github.com/users/rhinstaller","html_url":"https://github.com/rhinstaller","followers_url":"https://api.github.com/users/rhinstaller/followers","following_url":"https://api.github.com/users/rhinstaller/following{/other_user}","gists_url":"https://api.github.com/users/rhinstaller/gists{/gist_id}","starred_url":"https://api.github.com/users/rhinstaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhinstaller/subscriptions","organizations_url":"https://api.github.com/users/rhinstaller/orgs","repos_url":"https://api.github.com/users/rhinstaller/repos","events_url":"https://api.github.com/users/rhinstaller/events{/privacy}","received_events_url":"https://api.github.com/users/rhinstaller/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rhinstaller/anaconda","description":"Graphical system installer","fork":false,"url":"https://api.github.com/repos/rhinstaller/anaconda","forks_url":"https://api.github.com/repos/rhinstaller/anaconda/forks","keys_url":"https://api.github.com/repos/rhinstaller/anaconda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhinstaller/anaconda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhinstaller/anaconda/teams","hooks_url":"https://api.github.com/repos/rhinstaller/anaconda/hooks","issue_events_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/events{/number}","events_url":"https://api.github.com/repos/rhinstaller/anaconda/events","assignees_url":"https://api.github.com/repos/rhinstaller/anaconda/assignees{/user}","branches_url":"https://api.github.com/repos/rhinstaller/anaconda/branches{/branch}","tags_url":"https://api.github.com/repos/rhinstaller/anaconda/tags","blobs_url":"https://api.github.com/repos/rhinstaller/anaconda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhinstaller/anaconda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhinstaller/anaconda/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhinstaller/anaconda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhinstaller/anaconda/statuses/{sha}","languages_url":"https://api.github.com/repos/rhinstaller/anaconda/languages","stargazers_url":"https://api.github.com/repos/rhinstaller/anaconda/stargazers","contributors_url":"https://api.github.com/repos/rhinstaller/anaconda/contributors","subscribers_url":"https://api.github.com/repos/rhinstaller/anaconda/subscribers","subscription_url":"https://api.github.com/repos/rhinstaller/anaconda/subscription","commits_url":"https://api.github.com/repos/rhinstaller/anaconda/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhinstaller/anaconda/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhinstaller/anaconda/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhinstaller/anaconda/contents/{+path}","compare_url":"https://api.github.com/repos/rhinstaller/anaconda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhinstaller/anaconda/merges","archive_url":"https://api.github.com/repos/rhinstaller/anaconda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhinstaller/anaconda/downloads","issues_url":"https://api.github.com/repos/rhinstaller/anaconda/issues{/number}","pulls_url":"https://api.github.com/repos/rhinstaller/anaconda/pulls{/number}","milestones_url":"https://api.github.com/repos/rhinstaller/anaconda/milestones{/number}","notifications_url":"https://api.github.com/repos/rhinstaller/anaconda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhinstaller/anaconda/labels{/name}","releases_url":"https://api.github.com/repos/rhinstaller/anaconda/releases{/id}","deployments_url":"https://api.github.com/repos/rhinstaller/anaconda/deployments","created_at":"2015-02-02T21:56:45Z","updated_at":"2016-09-09T23:47:37Z","pushed_at":"2016-09-12T02:11:55Z","git_url":"git://github.com/rhinstaller/anaconda.git","ssh_url":"git@github.com:rhinstaller/anaconda.git","clone_url":"https://github.com/rhinstaller/anaconda.git","svn_url":"https://github.com/rhinstaller/anaconda","homepage":null,"size":193179,"stargazers_count":62,"watchers_count":62,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":77,"mirror_url":null,"open_issues_count":30,"forks":77,"open_issues":30,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/781"},"html":{"href":"https://github.com/rhinstaller/anaconda/pull/781"},"issue":{"href":"https://api.github.com/repos/rhinstaller/anaconda/issues/781"},"comments":{"href":"https://api.github.com/repos/rhinstaller/anaconda/issues/781/comments"},"review_comments":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/781/comments"},"review_comment":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/781/commits"},"statuses":{"href":"https://api.github.com/repos/rhinstaller/anaconda/statuses/56e9779abec39371d1e50008d6b1bfddce70978b"}}}}
{"actor":{"display_login":"vpodzime"}}