{"action":"created","issue":{"url":"https://api.github.com/repos/BRML/climin/issues/37","repository_url":"https://api.github.com/repos/BRML/climin","labels_url":"https://api.github.com/repos/BRML/climin/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/BRML/climin/issues/37/comments","events_url":"https://api.github.com/repos/BRML/climin/issues/37/events","html_url":"https://github.com/BRML/climin/pull/37","id":110630213,"number":37,"title":"Produces an iterator without calling minibatches function","user":{"login":"bachard","id":6204610,"avatar_url":"https://avatars.githubusercontent.com/u/6204610?v=3","gravatar_id":"","url":"https://api.github.com/users/bachard","html_url":"https://github.com/bachard","followers_url":"https://api.github.com/users/bachard/followers","following_url":"https://api.github.com/users/bachard/following{/other_user}","gists_url":"https://api.github.com/users/bachard/gists{/gist_id}","starred_url":"https://api.github.com/users/bachard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bachard/subscriptions","organizations_url":"https://api.github.com/users/bachard/orgs","repos_url":"https://api.github.com/users/bachard/repos","events_url":"https://api.github.com/users/bachard/events{/privacy}","received_events_url":"https://api.github.com/users/bachard/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2015-10-09T10:21:46Z","updated_at":"2016-07-14T14:02:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/BRML/climin/pulls/37","html_url":"https://github.com/BRML/climin/pull/37","diff_url":"https://github.com/BRML/climin/pull/37.diff","patch_url":"https://github.com/BRML/climin/pull/37.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/BRML/climin/issues/comments/232674310","html_url":"https://github.com/BRML/climin/pull/37#issuecomment-232674310","issue_url":"https://api.github.com/repos/BRML/climin/issues/37","id":232674310,"user":{"login":"msoelch","id":6438560,"avatar_url":"https://avatars.githubusercontent.com/u/6438560?v=3","gravatar_id":"","url":"https://api.github.com/users/msoelch","html_url":"https://github.com/msoelch","followers_url":"https://api.github.com/users/msoelch/followers","following_url":"https://api.github.com/users/msoelch/following{/other_user}","gists_url":"https://api.github.com/users/msoelch/gists{/gist_id}","starred_url":"https://api.github.com/users/msoelch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msoelch/subscriptions","organizations_url":"https://api.github.com/users/msoelch/orgs","repos_url":"https://api.github.com/users/msoelch/repos","events_url":"https://api.github.com/users/msoelch/events{/privacy}","received_events_url":"https://api.github.com/users/msoelch/received_events","type":"User","site_admin":false},"created_at":"2016-07-14T14:02:16Z","updated_at":"2016-07-14T14:02:16Z","body":"Thanks for clarification.\r\n\r\n@bachard Is your data set still available? I would like to run some tests without creating large random h5 files.\r\n\r\nDiscussed with @makarl. We can probably merge this pull request with some minor changes. The current plan is as follows:\r\n\r\nMake the following code snippet work:\r\n```\r\nf = h5py.File('myData.h5')\r\narr_it = iterator_from_h5(f)\r\nbatches = climin.iter_minibatches(arr_it, ...) \r\n```\r\nIn other words, not throwing away the functionality of HDF5 should be handled outside `iter_minibatches` in the (to be implemented) `iterator_from_h5`.\r\n\r\nIf that works, `iter_minibatches` and `minibatches` can be decoupled and refactored to avoid duplicate code.\r\n\r\nIn a last step, we might even collapse `minibatches` to return a list cast of the iterator returned by `iter_minibatches`."}}
{"actor":{"display_login":"msoelch"}}