{"action":"created","comment":{"url":"https://api.github.com/repos/pfsense/pfsense/pulls/comments/93262649","pull_request_review_id":13785938,"id":93262649,"diff_hunk":"@@ -84,6 +85,14 @@\n \t\t\tunset($config['system']['prefer_ipv4']);\n \t\t}\n \n+\t\tif (($_POST['global-v6duid']) != \"\") {\n+\t\t\t$_POST['global-v6duid'] = strtolower(str_replace(\"-\", \":\", $_POST['global-v6duid']));\n+\t\t\tif (!is_duid($_POST['global-v6duid'])) {\n+\t\t\t\t$input_errors[] = gettext(\"A valid DUID must be specified.\");\n+\t\t\t} else {\n+\t\t\t$config['system']['global-v6duid'] = $_POST['global-v6duid'];","path":"src/usr/local/www/system_advanced_network.php","position":17,"original_position":17,"commit_id":"0bcfc4143a5ab62bf83cb7a052369ab49e287598","original_commit_id":"0bcfc4143a5ab62bf83cb7a052369ab49e287598","user":{"login":"rbgarga","id":149872,"avatar_url":"https://avatars.githubusercontent.com/u/149872?v=3","gravatar_id":"","url":"https://api.github.com/users/rbgarga","html_url":"https://github.com/rbgarga","followers_url":"https://api.github.com/users/rbgarga/followers","following_url":"https://api.github.com/users/rbgarga/following{/other_user}","gists_url":"https://api.github.com/users/rbgarga/gists{/gist_id}","starred_url":"https://api.github.com/users/rbgarga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbgarga/subscriptions","organizations_url":"https://api.github.com/users/rbgarga/orgs","repos_url":"https://api.github.com/users/rbgarga/repos","events_url":"https://api.github.com/users/rbgarga/events{/privacy}","received_events_url":"https://api.github.com/users/rbgarga/received_events","type":"User","site_admin":false},"body":"Fix indent and add missing }","created_at":"2016-12-20T15:42:47Z","updated_at":"2016-12-20T15:42:55Z","html_url":"https://github.com/pfsense/pfsense/pull/3297#discussion_r93262649","pull_request_url":"https://api.github.com/repos/pfsense/pfsense/pulls/3297","_links":{"self":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/comments/93262649"},"html":{"href":"https://github.com/pfsense/pfsense/pull/3297#discussion_r93262649"},"pull_request":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/3297"}}},"pull_request":{"url":"https://api.github.com/repos/pfsense/pfsense/pulls/3297","id":98736639,"html_url":"https://github.com/pfsense/pfsense/pull/3297","diff_url":"https://github.com/pfsense/pfsense/pull/3297.diff","patch_url":"https://github.com/pfsense/pfsense/pull/3297.patch","issue_url":"https://api.github.com/repos/pfsense/pfsense/issues/3297","number":3297,"state":"open","locked":false,"title":"User Define DUID - Moved to System->Advanced->Networking","user":{"login":"marjohn56","id":17962918,"avatar_url":"https://avatars.githubusercontent.com/u/17962918?v=3","gravatar_id":"","url":"https://api.github.com/users/marjohn56","html_url":"https://github.com/marjohn56","followers_url":"https://api.github.com/users/marjohn56/followers","following_url":"https://api.github.com/users/marjohn56/following{/other_user}","gists_url":"https://api.github.com/users/marjohn56/gists{/gist_id}","starred_url":"https://api.github.com/users/marjohn56/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marjohn56/subscriptions","organizations_url":"https://api.github.com/users/marjohn56/orgs","repos_url":"https://api.github.com/users/marjohn56/repos","events_url":"https://api.github.com/users/marjohn56/events{/privacy}","received_events_url":"https://api.github.com/users/marjohn56/received_events","type":"User","site_admin":false},"body":"Moved the Configuration of the DUID to System->Advanced->Networking.\r\n\r\nDUID validity is checked for content and length. then creates a system\r\nconfig variable called global-v6duid.\r\nCan replace PR #3294\r\n\r\nIn Interfaces WAN an option exists to use the global DUID ( which has\r\nbeen defined or it flags an error ). On WAN interface configure the\r\nwrite of the DUID file takes place by calling the function in util.inc","created_at":"2016-12-20T12:06:04Z","updated_at":"2016-12-20T15:42:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e60ee95078cc2bc8387b07a7cde7aa4ff358304e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pfsense/pfsense/pulls/3297/commits","review_comments_url":"https://api.github.com/repos/pfsense/pfsense/pulls/3297/comments","review_comment_url":"https://api.github.com/repos/pfsense/pfsense/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pfsense/pfsense/issues/3297/comments","statuses_url":"https://api.github.com/repos/pfsense/pfsense/statuses/0bcfc4143a5ab62bf83cb7a052369ab49e287598","head":{"label":"marjohn56:DUID-to-System--Advanced","ref":"DUID-to-System--Advanced","sha":"0bcfc4143a5ab62bf83cb7a052369ab49e287598","user":{"login":"marjohn56","id":17962918,"avatar_url":"https://avatars.githubusercontent.com/u/17962918?v=3","gravatar_id":"","url":"https://api.github.com/users/marjohn56","html_url":"https://github.com/marjohn56","followers_url":"https://api.github.com/users/marjohn56/followers","following_url":"https://api.github.com/users/marjohn56/following{/other_user}","gists_url":"https://api.github.com/users/marjohn56/gists{/gist_id}","starred_url":"https://api.github.com/users/marjohn56/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marjohn56/subscriptions","organizations_url":"https://api.github.com/users/marjohn56/orgs","repos_url":"https://api.github.com/users/marjohn56/repos","events_url":"https://api.github.com/users/marjohn56/events{/privacy}","received_events_url":"https://api.github.com/users/marjohn56/received_events","type":"User","site_admin":false},"repo":{"id":76896436,"name":"pfsense","full_name":"marjohn56/pfsense","owner":{"login":"marjohn56","id":17962918,"avatar_url":"https://avatars.githubusercontent.com/u/17962918?v=3","gravatar_id":"","url":"https://api.github.com/users/marjohn56","html_url":"https://github.com/marjohn56","followers_url":"https://api.github.com/users/marjohn56/followers","following_url":"https://api.github.com/users/marjohn56/following{/other_user}","gists_url":"https://api.github.com/users/marjohn56/gists{/gist_id}","starred_url":"https://api.github.com/users/marjohn56/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marjohn56/subscriptions","organizations_url":"https://api.github.com/users/marjohn56/orgs","repos_url":"https://api.github.com/users/marjohn56/repos","events_url":"https://api.github.com/users/marjohn56/events{/privacy}","received_events_url":"https://api.github.com/users/marjohn56/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marjohn56/pfsense","description":"Main repository for pfSense","fork":true,"url":"https://api.github.com/repos/marjohn56/pfsense","forks_url":"https://api.github.com/repos/marjohn56/pfsense/forks","keys_url":"https://api.github.com/repos/marjohn56/pfsense/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marjohn56/pfsense/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marjohn56/pfsense/teams","hooks_url":"https://api.github.com/repos/marjohn56/pfsense/hooks","issue_events_url":"https://api.github.com/repos/marjohn56/pfsense/issues/events{/number}","events_url":"https://api.github.com/repos/marjohn56/pfsense/events","assignees_url":"https://api.github.com/repos/marjohn56/pfsense/assignees{/user}","branches_url":"https://api.github.com/repos/marjohn56/pfsense/branches{/branch}","tags_url":"https://api.github.com/repos/marjohn56/pfsense/tags","blobs_url":"https://api.github.com/repos/marjohn56/pfsense/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marjohn56/pfsense/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marjohn56/pfsense/git/refs{/sha}","trees_url":"https://api.github.com/repos/marjohn56/pfsense/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marjohn56/pfsense/statuses/{sha}","languages_url":"https://api.github.com/repos/marjohn56/pfsense/languages","stargazers_url":"https://api.github.com/repos/marjohn56/pfsense/stargazers","contributors_url":"https://api.github.com/repos/marjohn56/pfsense/contributors","subscribers_url":"https://api.github.com/repos/marjohn56/pfsense/subscribers","subscription_url":"https://api.github.com/repos/marjohn56/pfsense/subscription","commits_url":"https://api.github.com/repos/marjohn56/pfsense/commits{/sha}","git_commits_url":"https://api.github.com/repos/marjohn56/pfsense/git/commits{/sha}","comments_url":"https://api.github.com/repos/marjohn56/pfsense/comments{/number}","issue_comment_url":"https://api.github.com/repos/marjohn56/pfsense/issues/comments{/number}","contents_url":"https://api.github.com/repos/marjohn56/pfsense/contents/{+path}","compare_url":"https://api.github.com/repos/marjohn56/pfsense/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marjohn56/pfsense/merges","archive_url":"https://api.github.com/repos/marjohn56/pfsense/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marjohn56/pfsense/downloads","issues_url":"https://api.github.com/repos/marjohn56/pfsense/issues{/number}","pulls_url":"https://api.github.com/repos/marjohn56/pfsense/pulls{/number}","milestones_url":"https://api.github.com/repos/marjohn56/pfsense/milestones{/number}","notifications_url":"https://api.github.com/repos/marjohn56/pfsense/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marjohn56/pfsense/labels{/name}","releases_url":"https://api.github.com/repos/marjohn56/pfsense/releases{/id}","deployments_url":"https://api.github.com/repos/marjohn56/pfsense/deployments","created_at":"2016-12-19T20:52:34Z","updated_at":"2016-12-19T20:52:40Z","pushed_at":"2016-12-20T14:39:51Z","git_url":"git://github.com/marjohn56/pfsense.git","ssh_url":"git@github.com:marjohn56/pfsense.git","clone_url":"https://github.com/marjohn56/pfsense.git","svn_url":"https://github.com/marjohn56/pfsense","homepage":"http://www.pfsense.org","size":94303,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pfsense:master","ref":"master","sha":"652ce2b5a6ec23b34eda938aec6ec955c5d1253c","user":{"login":"pfsense","id":3716965,"avatar_url":"https://avatars.githubusercontent.com/u/3716965?v=3","gravatar_id":"","url":"https://api.github.com/users/pfsense","html_url":"https://github.com/pfsense","followers_url":"https://api.github.com/users/pfsense/followers","following_url":"https://api.github.com/users/pfsense/following{/other_user}","gists_url":"https://api.github.com/users/pfsense/gists{/gist_id}","starred_url":"https://api.github.com/users/pfsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfsense/subscriptions","organizations_url":"https://api.github.com/users/pfsense/orgs","repos_url":"https://api.github.com/users/pfsense/repos","events_url":"https://api.github.com/users/pfsense/events{/privacy}","received_events_url":"https://api.github.com/users/pfsense/received_events","type":"Organization","site_admin":false},"repo":{"id":1740040,"name":"pfsense","full_name":"pfsense/pfsense","owner":{"login":"pfsense","id":3716965,"avatar_url":"https://avatars.githubusercontent.com/u/3716965?v=3","gravatar_id":"","url":"https://api.github.com/users/pfsense","html_url":"https://github.com/pfsense","followers_url":"https://api.github.com/users/pfsense/followers","following_url":"https://api.github.com/users/pfsense/following{/other_user}","gists_url":"https://api.github.com/users/pfsense/gists{/gist_id}","starred_url":"https://api.github.com/users/pfsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfsense/subscriptions","organizations_url":"https://api.github.com/users/pfsense/orgs","repos_url":"https://api.github.com/users/pfsense/repos","events_url":"https://api.github.com/users/pfsense/events{/privacy}","received_events_url":"https://api.github.com/users/pfsense/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pfsense/pfsense","description":"Main repository for pfSense","fork":false,"url":"https://api.github.com/repos/pfsense/pfsense","forks_url":"https://api.github.com/repos/pfsense/pfsense/forks","keys_url":"https://api.github.com/repos/pfsense/pfsense/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pfsense/pfsense/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pfsense/pfsense/teams","hooks_url":"https://api.github.com/repos/pfsense/pfsense/hooks","issue_events_url":"https://api.github.com/repos/pfsense/pfsense/issues/events{/number}","events_url":"https://api.github.com/repos/pfsense/pfsense/events","assignees_url":"https://api.github.com/repos/pfsense/pfsense/assignees{/user}","branches_url":"https://api.github.com/repos/pfsense/pfsense/branches{/branch}","tags_url":"https://api.github.com/repos/pfsense/pfsense/tags","blobs_url":"https://api.github.com/repos/pfsense/pfsense/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pfsense/pfsense/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pfsense/pfsense/git/refs{/sha}","trees_url":"https://api.github.com/repos/pfsense/pfsense/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pfsense/pfsense/statuses/{sha}","languages_url":"https://api.github.com/repos/pfsense/pfsense/languages","stargazers_url":"https://api.github.com/repos/pfsense/pfsense/stargazers","contributors_url":"https://api.github.com/repos/pfsense/pfsense/contributors","subscribers_url":"https://api.github.com/repos/pfsense/pfsense/subscribers","subscription_url":"https://api.github.com/repos/pfsense/pfsense/subscription","commits_url":"https://api.github.com/repos/pfsense/pfsense/commits{/sha}","git_commits_url":"https://api.github.com/repos/pfsense/pfsense/git/commits{/sha}","comments_url":"https://api.github.com/repos/pfsense/pfsense/comments{/number}","issue_comment_url":"https://api.github.com/repos/pfsense/pfsense/issues/comments{/number}","contents_url":"https://api.github.com/repos/pfsense/pfsense/contents/{+path}","compare_url":"https://api.github.com/repos/pfsense/pfsense/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pfsense/pfsense/merges","archive_url":"https://api.github.com/repos/pfsense/pfsense/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pfsense/pfsense/downloads","issues_url":"https://api.github.com/repos/pfsense/pfsense/issues{/number}","pulls_url":"https://api.github.com/repos/pfsense/pfsense/pulls{/number}","milestones_url":"https://api.github.com/repos/pfsense/pfsense/milestones{/number}","notifications_url":"https://api.github.com/repos/pfsense/pfsense/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pfsense/pfsense/labels{/name}","releases_url":"https://api.github.com/repos/pfsense/pfsense/releases{/id}","deployments_url":"https://api.github.com/repos/pfsense/pfsense/deployments","created_at":"2011-05-12T19:44:21Z","updated_at":"2016-12-20T14:22:03Z","pushed_at":"2016-12-20T15:41:01Z","git_url":"git://github.com/pfsense/pfsense.git","ssh_url":"git@github.com:pfsense/pfsense.git","clone_url":"https://github.com/pfsense/pfsense.git","svn_url":"https://github.com/pfsense/pfsense","homepage":"http://www.pfsense.org","size":94286,"stargazers_count":1135,"watchers_count":1135,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":579,"mirror_url":null,"open_issues_count":21,"forks":579,"open_issues":21,"watchers":1135,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/3297"},"html":{"href":"https://github.com/pfsense/pfsense/pull/3297"},"issue":{"href":"https://api.github.com/repos/pfsense/pfsense/issues/3297"},"comments":{"href":"https://api.github.com/repos/pfsense/pfsense/issues/3297/comments"},"review_comments":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/3297/comments"},"review_comment":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/3297/commits"},"statuses":{"href":"https://api.github.com/repos/pfsense/pfsense/statuses/0bcfc4143a5ab62bf83cb7a052369ab49e287598"}}}}
{"actor":{"display_login":"rbgarga"}}