{"action":"created","comment":{"url":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/comments/76531633","id":76531633,"diff_hunk":"@@ -13,18 +13,18 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n See the License for the specific language governing permissions and\n limitations under the License.\n */\n-package markets.orderbooks\n+package markets.orderbooks.concurrent\n \n import markets.RandomOrderGenerator._\n import markets.orders.{AskOrder, BidOrder}\n import markets.tradables.Tradable\n \n \n-class ConcurrentSortedOrderBookSpec extends ConcurrentOrderBookSpec {\n+class SortedOrderBookSpec extends OrderBookSpec {\n \n-  override def askOrderBookFactory(tradable: Tradable) = ConcurrentSortedOrderBook[AskOrder](tradable)\n+  override def askOrderBookFactory(tradable: Tradable) = SortedOrderBook[AskOrder](tradable)\n \n-  override def bidOrderBookFactory(tradable: Tradable) = ConcurrentSortedOrderBook[BidOrder](tradable)\n+  override def bidOrderBookFactory(tradable: Tradable) = SortedOrderBook[BidOrder](tradable)","path":"src/test/scala-2.11/markets/orderbooks/concurrent/SortedOrderBookSpec.scala","position":19,"original_position":19,"commit_id":"e833a7adbb5cad9f42c17091a3492fd8f1369ef4","original_commit_id":"e833a7adbb5cad9f42c17091a3492fd8f1369ef4","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars.githubusercontent.com/u/19940114?v=3","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Public method must have explicit type](https://www.codacy.com/app/davidrpugh/markets-sandbox/file/3622589531/issues/source?bid=2921361&fileBranchId=3631862#l27)","created_at":"2016-08-28T13:06:40Z","updated_at":"2016-08-28T13:06:40Z","html_url":"https://github.com/ScalABM/markets-sandbox/pull/166#discussion_r76531633","pull_request_url":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/166","_links":{"self":{"href":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/comments/76531633"},"html":{"href":"https://github.com/ScalABM/markets-sandbox/pull/166#discussion_r76531633"},"pull_request":{"href":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/166"}}},"pull_request":{"url":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/166","id":82706287,"html_url":"https://github.com/ScalABM/markets-sandbox/pull/166","diff_url":"https://github.com/ScalABM/markets-sandbox/pull/166.diff","patch_url":"https://github.com/ScalABM/markets-sandbox/pull/166.patch","issue_url":"https://api.github.com/repos/ScalABM/markets-sandbox/issues/166","number":166,"state":"open","locked":false,"title":"Reordering the orderbooks package","user":{"login":"davidrpugh","id":2219562,"avatar_url":"https://avatars.githubusercontent.com/u/2219562?v=3","gravatar_id":"","url":"https://api.github.com/users/davidrpugh","html_url":"https://github.com/davidrpugh","followers_url":"https://api.github.com/users/davidrpugh/followers","following_url":"https://api.github.com/users/davidrpugh/following{/other_user}","gists_url":"https://api.github.com/users/davidrpugh/gists{/gist_id}","starred_url":"https://api.github.com/users/davidrpugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidrpugh/subscriptions","organizations_url":"https://api.github.com/users/davidrpugh/orgs","repos_url":"https://api.github.com/users/davidrpugh/repos","events_url":"https://api.github.com/users/davidrpugh/events{/privacy}","received_events_url":"https://api.github.com/users/davidrpugh/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-25T11:56:16Z","updated_at":"2016-08-28T13:06:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf669f7ce8950bc0de4c5593b028be1aa3959850","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/166/commits","review_comments_url":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/166/comments","review_comment_url":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ScalABM/markets-sandbox/issues/166/comments","statuses_url":"https://api.github.com/repos/ScalABM/markets-sandbox/statuses/e833a7adbb5cad9f42c17091a3492fd8f1369ef4","head":{"label":"ScalABM:reorg-orderbooks","ref":"reorg-orderbooks","sha":"e833a7adbb5cad9f42c17091a3492fd8f1369ef4","user":{"login":"ScalABM","id":12729421,"avatar_url":"https://avatars.githubusercontent.com/u/12729421?v=3","gravatar_id":"","url":"https://api.github.com/users/ScalABM","html_url":"https://github.com/ScalABM","followers_url":"https://api.github.com/users/ScalABM/followers","following_url":"https://api.github.com/users/ScalABM/following{/other_user}","gists_url":"https://api.github.com/users/ScalABM/gists{/gist_id}","starred_url":"https://api.github.com/users/ScalABM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScalABM/subscriptions","organizations_url":"https://api.github.com/users/ScalABM/orgs","repos_url":"https://api.github.com/users/ScalABM/repos","events_url":"https://api.github.com/users/ScalABM/events{/privacy}","received_events_url":"https://api.github.com/users/ScalABM/received_events","type":"Organization","site_admin":false},"repo":{"id":44811632,"name":"markets-sandbox","full_name":"ScalABM/markets-sandbox","owner":{"login":"ScalABM","id":12729421,"avatar_url":"https://avatars.githubusercontent.com/u/12729421?v=3","gravatar_id":"","url":"https://api.github.com/users/ScalABM","html_url":"https://github.com/ScalABM","followers_url":"https://api.github.com/users/ScalABM/followers","following_url":"https://api.github.com/users/ScalABM/following{/other_user}","gists_url":"https://api.github.com/users/ScalABM/gists{/gist_id}","starred_url":"https://api.github.com/users/ScalABM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScalABM/subscriptions","organizations_url":"https://api.github.com/users/ScalABM/orgs","repos_url":"https://api.github.com/users/ScalABM/repos","events_url":"https://api.github.com/users/ScalABM/events{/privacy}","received_events_url":"https://api.github.com/users/ScalABM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ScalABM/markets-sandbox","description":"A sandbox for building and testing scalable implementations of various market micro-structures.","fork":false,"url":"https://api.github.com/repos/ScalABM/markets-sandbox","forks_url":"https://api.github.com/repos/ScalABM/markets-sandbox/forks","keys_url":"https://api.github.com/repos/ScalABM/markets-sandbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ScalABM/markets-sandbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ScalABM/markets-sandbox/teams","hooks_url":"https://api.github.com/repos/ScalABM/markets-sandbox/hooks","issue_events_url":"https://api.github.com/repos/ScalABM/markets-sandbox/issues/events{/number}","events_url":"https://api.github.com/repos/ScalABM/markets-sandbox/events","assignees_url":"https://api.github.com/repos/ScalABM/markets-sandbox/assignees{/user}","branches_url":"https://api.github.com/repos/ScalABM/markets-sandbox/branches{/branch}","tags_url":"https://api.github.com/repos/ScalABM/markets-sandbox/tags","blobs_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ScalABM/markets-sandbox/statuses/{sha}","languages_url":"https://api.github.com/repos/ScalABM/markets-sandbox/languages","stargazers_url":"https://api.github.com/repos/ScalABM/markets-sandbox/stargazers","contributors_url":"https://api.github.com/repos/ScalABM/markets-sandbox/contributors","subscribers_url":"https://api.github.com/repos/ScalABM/markets-sandbox/subscribers","subscription_url":"https://api.github.com/repos/ScalABM/markets-sandbox/subscription","commits_url":"https://api.github.com/repos/ScalABM/markets-sandbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/ScalABM/markets-sandbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/ScalABM/markets-sandbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/ScalABM/markets-sandbox/contents/{+path}","compare_url":"https://api.github.com/repos/ScalABM/markets-sandbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ScalABM/markets-sandbox/merges","archive_url":"https://api.github.com/repos/ScalABM/markets-sandbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ScalABM/markets-sandbox/downloads","issues_url":"https://api.github.com/repos/ScalABM/markets-sandbox/issues{/number}","pulls_url":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls{/number}","milestones_url":"https://api.github.com/repos/ScalABM/markets-sandbox/milestones{/number}","notifications_url":"https://api.github.com/repos/ScalABM/markets-sandbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ScalABM/markets-sandbox/labels{/name}","releases_url":"https://api.github.com/repos/ScalABM/markets-sandbox/releases{/id}","deployments_url":"https://api.github.com/repos/ScalABM/markets-sandbox/deployments","created_at":"2015-10-23T12:25:31Z","updated_at":"2016-02-12T14:49:56Z","pushed_at":"2016-08-28T13:05:07Z","git_url":"git://github.com/ScalABM/markets-sandbox.git","ssh_url":"git@github.com:ScalABM/markets-sandbox.git","clone_url":"https://github.com/ScalABM/markets-sandbox.git","svn_url":"https://github.com/ScalABM/markets-sandbox","homepage":null,"size":976,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":17,"forks":1,"open_issues":17,"watchers":1,"default_branch":"master"}},"base":{"label":"ScalABM:develop","ref":"develop","sha":"31f2dae006011680bf3bc48860052c7894308423","user":{"login":"ScalABM","id":12729421,"avatar_url":"https://avatars.githubusercontent.com/u/12729421?v=3","gravatar_id":"","url":"https://api.github.com/users/ScalABM","html_url":"https://github.com/ScalABM","followers_url":"https://api.github.com/users/ScalABM/followers","following_url":"https://api.github.com/users/ScalABM/following{/other_user}","gists_url":"https://api.github.com/users/ScalABM/gists{/gist_id}","starred_url":"https://api.github.com/users/ScalABM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScalABM/subscriptions","organizations_url":"https://api.github.com/users/ScalABM/orgs","repos_url":"https://api.github.com/users/ScalABM/repos","events_url":"https://api.github.com/users/ScalABM/events{/privacy}","received_events_url":"https://api.github.com/users/ScalABM/received_events","type":"Organization","site_admin":false},"repo":{"id":44811632,"name":"markets-sandbox","full_name":"ScalABM/markets-sandbox","owner":{"login":"ScalABM","id":12729421,"avatar_url":"https://avatars.githubusercontent.com/u/12729421?v=3","gravatar_id":"","url":"https://api.github.com/users/ScalABM","html_url":"https://github.com/ScalABM","followers_url":"https://api.github.com/users/ScalABM/followers","following_url":"https://api.github.com/users/ScalABM/following{/other_user}","gists_url":"https://api.github.com/users/ScalABM/gists{/gist_id}","starred_url":"https://api.github.com/users/ScalABM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScalABM/subscriptions","organizations_url":"https://api.github.com/users/ScalABM/orgs","repos_url":"https://api.github.com/users/ScalABM/repos","events_url":"https://api.github.com/users/ScalABM/events{/privacy}","received_events_url":"https://api.github.com/users/ScalABM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ScalABM/markets-sandbox","description":"A sandbox for building and testing scalable implementations of various market micro-structures.","fork":false,"url":"https://api.github.com/repos/ScalABM/markets-sandbox","forks_url":"https://api.github.com/repos/ScalABM/markets-sandbox/forks","keys_url":"https://api.github.com/repos/ScalABM/markets-sandbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ScalABM/markets-sandbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ScalABM/markets-sandbox/teams","hooks_url":"https://api.github.com/repos/ScalABM/markets-sandbox/hooks","issue_events_url":"https://api.github.com/repos/ScalABM/markets-sandbox/issues/events{/number}","events_url":"https://api.github.com/repos/ScalABM/markets-sandbox/events","assignees_url":"https://api.github.com/repos/ScalABM/markets-sandbox/assignees{/user}","branches_url":"https://api.github.com/repos/ScalABM/markets-sandbox/branches{/branch}","tags_url":"https://api.github.com/repos/ScalABM/markets-sandbox/tags","blobs_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ScalABM/markets-sandbox/statuses/{sha}","languages_url":"https://api.github.com/repos/ScalABM/markets-sandbox/languages","stargazers_url":"https://api.github.com/repos/ScalABM/markets-sandbox/stargazers","contributors_url":"https://api.github.com/repos/ScalABM/markets-sandbox/contributors","subscribers_url":"https://api.github.com/repos/ScalABM/markets-sandbox/subscribers","subscription_url":"https://api.github.com/repos/ScalABM/markets-sandbox/subscription","commits_url":"https://api.github.com/repos/ScalABM/markets-sandbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/ScalABM/markets-sandbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/ScalABM/markets-sandbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/ScalABM/markets-sandbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/ScalABM/markets-sandbox/contents/{+path}","compare_url":"https://api.github.com/repos/ScalABM/markets-sandbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ScalABM/markets-sandbox/merges","archive_url":"https://api.github.com/repos/ScalABM/markets-sandbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ScalABM/markets-sandbox/downloads","issues_url":"https://api.github.com/repos/ScalABM/markets-sandbox/issues{/number}","pulls_url":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls{/number}","milestones_url":"https://api.github.com/repos/ScalABM/markets-sandbox/milestones{/number}","notifications_url":"https://api.github.com/repos/ScalABM/markets-sandbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ScalABM/markets-sandbox/labels{/name}","releases_url":"https://api.github.com/repos/ScalABM/markets-sandbox/releases{/id}","deployments_url":"https://api.github.com/repos/ScalABM/markets-sandbox/deployments","created_at":"2015-10-23T12:25:31Z","updated_at":"2016-02-12T14:49:56Z","pushed_at":"2016-08-28T13:05:07Z","git_url":"git://github.com/ScalABM/markets-sandbox.git","ssh_url":"git@github.com:ScalABM/markets-sandbox.git","clone_url":"https://github.com/ScalABM/markets-sandbox.git","svn_url":"https://github.com/ScalABM/markets-sandbox","homepage":null,"size":976,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":17,"forks":1,"open_issues":17,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/166"},"html":{"href":"https://github.com/ScalABM/markets-sandbox/pull/166"},"issue":{"href":"https://api.github.com/repos/ScalABM/markets-sandbox/issues/166"},"comments":{"href":"https://api.github.com/repos/ScalABM/markets-sandbox/issues/166/comments"},"review_comments":{"href":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/166/comments"},"review_comment":{"href":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ScalABM/markets-sandbox/pulls/166/commits"},"statuses":{"href":"https://api.github.com/repos/ScalABM/markets-sandbox/statuses/e833a7adbb5cad9f42c17091a3492fd8f1369ef4"}}}}
{"actor":{"display_login":"codacy-bot"}}