{"action":"created","comment":{"url":"https://api.github.com/repos/Jegp/jarrace/pulls/comments/51455887","id":51455887,"diff_hunk":"@@ -0,0 +1,15 @@\n+/**\n+ * © Copyright 2016 CERN. This software is distributed under the terms of the Apache License Version 2.0, copied\n+ * verbatim in the file “COPYING”. In applying this licence, CERN does not waive the privileges and immunities granted\n+ * to it by virtue of its status as an Intergovernmental Organization or submit itself to any jurisdiction.\n+ */\n+package cern.jarrace.controller.jvm;\n+\n+/**\n+ * Interface that is responsible for spawning JVMs executing cern.jarrace.agent.AgentRegistry#main\n+ *\n+ * @author tiagomr\n+ */\n+public interface AgentRegistrySpawner {","path":"controller/src/main/java/cern/jarrace/controller/jvm/AgentRegistrySpawner.java","position":13,"original_position":13,"commit_id":"a71cf8a2cb2095951cce3f90dfdbee14647f65fa","original_commit_id":"d7bb279340f501596e393bb9101420c0bbee2bd8","user":{"login":"tiagomr","id":7980551,"avatar_url":"https://avatars.githubusercontent.com/u/7980551?v=3","gravatar_id":"","url":"https://api.github.com/users/tiagomr","html_url":"https://github.com/tiagomr","followers_url":"https://api.github.com/users/tiagomr/followers","following_url":"https://api.github.com/users/tiagomr/following{/other_user}","gists_url":"https://api.github.com/users/tiagomr/gists{/gist_id}","starred_url":"https://api.github.com/users/tiagomr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiagomr/subscriptions","organizations_url":"https://api.github.com/users/tiagomr/orgs","repos_url":"https://api.github.com/users/tiagomr/repos","events_url":"https://api.github.com/users/tiagomr/events{/privacy}","received_events_url":"https://api.github.com/users/tiagomr/received_events","type":"User","site_admin":false},"body":"You can register several things in the same controller and you can also implement different DIscovery mechanisms without deploying the controller (not happening now and yet not discussed, but nonetheless possible).\r\nLike this we also decouple the controller from everything else allowing for an easier way to create standalone deployments that do not have to necessarily pass by the controller.","created_at":"2016-02-01T18:12:00Z","updated_at":"2016-02-01T18:12:00Z","html_url":"https://github.com/Jegp/jarrace/pull/2#discussion_r51455887","pull_request_url":"https://api.github.com/repos/Jegp/jarrace/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/Jegp/jarrace/pulls/comments/51455887"},"html":{"href":"https://github.com/Jegp/jarrace/pull/2#discussion_r51455887"},"pull_request":{"href":"https://api.github.com/repos/Jegp/jarrace/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/Jegp/jarrace/pulls/2","id":57228892,"html_url":"https://github.com/Jegp/jarrace/pull/2","diff_url":"https://github.com/Jegp/jarrace/pull/2.diff","patch_url":"https://github.com/Jegp/jarrace/pull/2.patch","issue_url":"https://api.github.com/repos/Jegp/jarrace/issues/2","number":2,"state":"open","locked":false,"title":"Service registration","user":{"login":"tiagomr","id":7980551,"avatar_url":"https://avatars.githubusercontent.com/u/7980551?v=3","gravatar_id":"","url":"https://api.github.com/users/tiagomr","html_url":"https://github.com/tiagomr","followers_url":"https://api.github.com/users/tiagomr/followers","following_url":"https://api.github.com/users/tiagomr/following{/other_user}","gists_url":"https://api.github.com/users/tiagomr/gists{/gist_id}","starred_url":"https://api.github.com/users/tiagomr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiagomr/subscriptions","organizations_url":"https://api.github.com/users/tiagomr/orgs","repos_url":"https://api.github.com/users/tiagomr/repos","events_url":"https://api.github.com/users/tiagomr/events{/privacy}","received_events_url":"https://api.github.com/users/tiagomr/received_events","type":"User","site_admin":false},"body":"Before each entrypoint would have to be registered in separate requests, now the registration of entrypoints have been removed and the user can register a service, being a service composed by and Agent, a Class and list of methods from that class that the agent can execute","created_at":"2016-01-26T15:51:39Z","updated_at":"2016-02-01T18:12:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aaa03a279b1ef1dd7222b6b2552fe2511d4347df","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Jegp/jarrace/pulls/2/commits","review_comments_url":"https://api.github.com/repos/Jegp/jarrace/pulls/2/comments","review_comment_url":"https://api.github.com/repos/Jegp/jarrace/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Jegp/jarrace/issues/2/comments","statuses_url":"https://api.github.com/repos/Jegp/jarrace/statuses/a71cf8a2cb2095951cce3f90dfdbee14647f65fa","head":{"label":"Jegp:serviceRegistration","ref":"serviceRegistration","sha":"a71cf8a2cb2095951cce3f90dfdbee14647f65fa","user":{"login":"Jegp","id":1064317,"avatar_url":"https://avatars.githubusercontent.com/u/1064317?v=3","gravatar_id":"","url":"https://api.github.com/users/Jegp","html_url":"https://github.com/Jegp","followers_url":"https://api.github.com/users/Jegp/followers","following_url":"https://api.github.com/users/Jegp/following{/other_user}","gists_url":"https://api.github.com/users/Jegp/gists{/gist_id}","starred_url":"https://api.github.com/users/Jegp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jegp/subscriptions","organizations_url":"https://api.github.com/users/Jegp/orgs","repos_url":"https://api.github.com/users/Jegp/repos","events_url":"https://api.github.com/users/Jegp/events{/privacy}","received_events_url":"https://api.github.com/users/Jegp/received_events","type":"User","site_admin":false},"repo":{"id":49164561,"name":"jarrace","full_name":"Jegp/jarrace","owner":{"login":"Jegp","id":1064317,"avatar_url":"https://avatars.githubusercontent.com/u/1064317?v=3","gravatar_id":"","url":"https://api.github.com/users/Jegp","html_url":"https://github.com/Jegp","followers_url":"https://api.github.com/users/Jegp/followers","following_url":"https://api.github.com/users/Jegp/following{/other_user}","gists_url":"https://api.github.com/users/Jegp/gists{/gist_id}","starred_url":"https://api.github.com/users/Jegp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jegp/subscriptions","organizations_url":"https://api.github.com/users/Jegp/orgs","repos_url":"https://api.github.com/users/Jegp/repos","events_url":"https://api.github.com/users/Jegp/events{/privacy}","received_events_url":"https://api.github.com/users/Jegp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jegp/jarrace","description":"A simple scripting frontend for the Java Debugger Interface","fork":true,"url":"https://api.github.com/repos/Jegp/jarrace","forks_url":"https://api.github.com/repos/Jegp/jarrace/forks","keys_url":"https://api.github.com/repos/Jegp/jarrace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jegp/jarrace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jegp/jarrace/teams","hooks_url":"https://api.github.com/repos/Jegp/jarrace/hooks","issue_events_url":"https://api.github.com/repos/Jegp/jarrace/issues/events{/number}","events_url":"https://api.github.com/repos/Jegp/jarrace/events","assignees_url":"https://api.github.com/repos/Jegp/jarrace/assignees{/user}","branches_url":"https://api.github.com/repos/Jegp/jarrace/branches{/branch}","tags_url":"https://api.github.com/repos/Jegp/jarrace/tags","blobs_url":"https://api.github.com/repos/Jegp/jarrace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jegp/jarrace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jegp/jarrace/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jegp/jarrace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jegp/jarrace/statuses/{sha}","languages_url":"https://api.github.com/repos/Jegp/jarrace/languages","stargazers_url":"https://api.github.com/repos/Jegp/jarrace/stargazers","contributors_url":"https://api.github.com/repos/Jegp/jarrace/contributors","subscribers_url":"https://api.github.com/repos/Jegp/jarrace/subscribers","subscription_url":"https://api.github.com/repos/Jegp/jarrace/subscription","commits_url":"https://api.github.com/repos/Jegp/jarrace/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jegp/jarrace/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jegp/jarrace/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jegp/jarrace/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jegp/jarrace/contents/{+path}","compare_url":"https://api.github.com/repos/Jegp/jarrace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jegp/jarrace/merges","archive_url":"https://api.github.com/repos/Jegp/jarrace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jegp/jarrace/downloads","issues_url":"https://api.github.com/repos/Jegp/jarrace/issues{/number}","pulls_url":"https://api.github.com/repos/Jegp/jarrace/pulls{/number}","milestones_url":"https://api.github.com/repos/Jegp/jarrace/milestones{/number}","notifications_url":"https://api.github.com/repos/Jegp/jarrace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jegp/jarrace/labels{/name}","releases_url":"https://api.github.com/repos/Jegp/jarrace/releases{/id}","deployments_url":"https://api.github.com/repos/Jegp/jarrace/deployments","created_at":"2016-01-06T22:03:56Z","updated_at":"2016-01-19T10:28:25Z","pushed_at":"2016-02-01T15:45:14Z","git_url":"git://github.com/Jegp/jarrace.git","ssh_url":"git@github.com:Jegp/jarrace.git","clone_url":"https://github.com/Jegp/jarrace.git","svn_url":"https://github.com/Jegp/jarrace","homepage":"","size":780,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"Jegp:controller","ref":"controller","sha":"c68dfb227769aec23d356b6716b06fa1c9cf0724","user":{"login":"Jegp","id":1064317,"avatar_url":"https://avatars.githubusercontent.com/u/1064317?v=3","gravatar_id":"","url":"https://api.github.com/users/Jegp","html_url":"https://github.com/Jegp","followers_url":"https://api.github.com/users/Jegp/followers","following_url":"https://api.github.com/users/Jegp/following{/other_user}","gists_url":"https://api.github.com/users/Jegp/gists{/gist_id}","starred_url":"https://api.github.com/users/Jegp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jegp/subscriptions","organizations_url":"https://api.github.com/users/Jegp/orgs","repos_url":"https://api.github.com/users/Jegp/repos","events_url":"https://api.github.com/users/Jegp/events{/privacy}","received_events_url":"https://api.github.com/users/Jegp/received_events","type":"User","site_admin":false},"repo":{"id":49164561,"name":"jarrace","full_name":"Jegp/jarrace","owner":{"login":"Jegp","id":1064317,"avatar_url":"https://avatars.githubusercontent.com/u/1064317?v=3","gravatar_id":"","url":"https://api.github.com/users/Jegp","html_url":"https://github.com/Jegp","followers_url":"https://api.github.com/users/Jegp/followers","following_url":"https://api.github.com/users/Jegp/following{/other_user}","gists_url":"https://api.github.com/users/Jegp/gists{/gist_id}","starred_url":"https://api.github.com/users/Jegp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jegp/subscriptions","organizations_url":"https://api.github.com/users/Jegp/orgs","repos_url":"https://api.github.com/users/Jegp/repos","events_url":"https://api.github.com/users/Jegp/events{/privacy}","received_events_url":"https://api.github.com/users/Jegp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jegp/jarrace","description":"A simple scripting frontend for the Java Debugger Interface","fork":true,"url":"https://api.github.com/repos/Jegp/jarrace","forks_url":"https://api.github.com/repos/Jegp/jarrace/forks","keys_url":"https://api.github.com/repos/Jegp/jarrace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jegp/jarrace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jegp/jarrace/teams","hooks_url":"https://api.github.com/repos/Jegp/jarrace/hooks","issue_events_url":"https://api.github.com/repos/Jegp/jarrace/issues/events{/number}","events_url":"https://api.github.com/repos/Jegp/jarrace/events","assignees_url":"https://api.github.com/repos/Jegp/jarrace/assignees{/user}","branches_url":"https://api.github.com/repos/Jegp/jarrace/branches{/branch}","tags_url":"https://api.github.com/repos/Jegp/jarrace/tags","blobs_url":"https://api.github.com/repos/Jegp/jarrace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jegp/jarrace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jegp/jarrace/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jegp/jarrace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jegp/jarrace/statuses/{sha}","languages_url":"https://api.github.com/repos/Jegp/jarrace/languages","stargazers_url":"https://api.github.com/repos/Jegp/jarrace/stargazers","contributors_url":"https://api.github.com/repos/Jegp/jarrace/contributors","subscribers_url":"https://api.github.com/repos/Jegp/jarrace/subscribers","subscription_url":"https://api.github.com/repos/Jegp/jarrace/subscription","commits_url":"https://api.github.com/repos/Jegp/jarrace/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jegp/jarrace/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jegp/jarrace/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jegp/jarrace/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jegp/jarrace/contents/{+path}","compare_url":"https://api.github.com/repos/Jegp/jarrace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jegp/jarrace/merges","archive_url":"https://api.github.com/repos/Jegp/jarrace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jegp/jarrace/downloads","issues_url":"https://api.github.com/repos/Jegp/jarrace/issues{/number}","pulls_url":"https://api.github.com/repos/Jegp/jarrace/pulls{/number}","milestones_url":"https://api.github.com/repos/Jegp/jarrace/milestones{/number}","notifications_url":"https://api.github.com/repos/Jegp/jarrace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jegp/jarrace/labels{/name}","releases_url":"https://api.github.com/repos/Jegp/jarrace/releases{/id}","deployments_url":"https://api.github.com/repos/Jegp/jarrace/deployments","created_at":"2016-01-06T22:03:56Z","updated_at":"2016-01-19T10:28:25Z","pushed_at":"2016-02-01T15:45:14Z","git_url":"git://github.com/Jegp/jarrace.git","ssh_url":"git@github.com:Jegp/jarrace.git","clone_url":"https://github.com/Jegp/jarrace.git","svn_url":"https://github.com/Jegp/jarrace","homepage":"","size":780,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Jegp/jarrace/pulls/2"},"html":{"href":"https://github.com/Jegp/jarrace/pull/2"},"issue":{"href":"https://api.github.com/repos/Jegp/jarrace/issues/2"},"comments":{"href":"https://api.github.com/repos/Jegp/jarrace/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/Jegp/jarrace/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/Jegp/jarrace/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Jegp/jarrace/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/Jegp/jarrace/statuses/a71cf8a2cb2095951cce3f90dfdbee14647f65fa"}}}}