{"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/51416098","id":51416098,"diff_hunk":"@@ -0,0 +1,24 @@\n+// Copyright 2016 Citra Emulator Project\n+// Licensed under GPLv2 or any later version\n+// Refer to the license.txt file included.\n+\n+#pragma once\n+\n+#include \"core/hle/kernel/event.h\"","path":"src/audio_core/svc.h","position":null,"original_position":7,"commit_id":"df4289d243e06e9eff66e6e502c2467969f8f7f3","original_commit_id":"f4b4b6e3046b413261df378ea25234f55ab6c625","user":{"login":"lioncash","id":712067,"avatar_url":"https://avatars.githubusercontent.com/u/712067?v=3","gravatar_id":"","url":"https://api.github.com/users/lioncash","html_url":"https://github.com/lioncash","followers_url":"https://api.github.com/users/lioncash/followers","following_url":"https://api.github.com/users/lioncash/following{/other_user}","gists_url":"https://api.github.com/users/lioncash/gists{/gist_id}","starred_url":"https://api.github.com/users/lioncash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lioncash/subscriptions","organizations_url":"https://api.github.com/users/lioncash/orgs","repos_url":"https://api.github.com/users/lioncash/repos","events_url":"https://api.github.com/users/lioncash/events{/privacy}","received_events_url":"https://api.github.com/users/lioncash/received_events","type":"User","site_admin":false},"body":"Yeah, just realized that was a typo on my part. the forward declaration for Event can be kept, but `core/hle/kernel/kernel.h` will need to be included to satisfy SharedPtr (since it's a typedef, not a class like I thought it was).","created_at":"2016-02-01T13:14:17Z","updated_at":"2016-02-01T13:14:17Z","html_url":"https://github.com/citra-emu/citra/pull/1386#discussion_r51416098","pull_request_url":"https://api.github.com/repos/citra-emu/citra/pulls/1386","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/51416098"},"html":{"href":"https://github.com/citra-emu/citra/pull/1386#discussion_r51416098"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/1386"}}},"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/1386","id":57786601,"html_url":"https://github.com/citra-emu/citra/pull/1386","diff_url":"https://github.com/citra-emu/citra/pull/1386.diff","patch_url":"https://github.com/citra-emu/citra/pull/1386.patch","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/1386","number":1386,"state":"open","locked":false,"title":"Audio Core: Skeleton","user":{"login":"MerryMage","id":8682882,"avatar_url":"https://avatars.githubusercontent.com/u/8682882?v=3","gravatar_id":"","url":"https://api.github.com/users/MerryMage","html_url":"https://github.com/MerryMage","followers_url":"https://api.github.com/users/MerryMage/followers","following_url":"https://api.github.com/users/MerryMage/following{/other_user}","gists_url":"https://api.github.com/users/MerryMage/gists{/gist_id}","starred_url":"https://api.github.com/users/MerryMage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MerryMage/subscriptions","organizations_url":"https://api.github.com/users/MerryMage/orgs","repos_url":"https://api.github.com/users/MerryMage/repos","events_url":"https://api.github.com/users/MerryMage/events{/privacy}","received_events_url":"https://api.github.com/users/MerryMage/received_events","type":"User","site_admin":false},"body":"A propsed skeleton of audio core that hopefully demonstrates how I am going to approach implementation. \r\n\r\nAudio processing will be coordinated in DSP::HLE::Tick.\r\n\r\nI intend to slowly flesh this skeleton out over a series of PRs. Implementing `Sink`s would probably be the very last thing I do.\r\n\r\nThis subsumes #1299.","created_at":"2016-02-01T00:42:35Z","updated_at":"2016-02-01T13:14:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd20bc3369decdfc17258519bc32719e608ba546","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/citra/pulls/1386/commits","review_comments_url":"https://api.github.com/repos/citra-emu/citra/pulls/1386/comments","review_comment_url":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/1386/comments","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/df4289d243e06e9eff66e6e502c2467969f8f7f3","head":{"label":"MerryMage:audio-core-skeleton","ref":"audio-core-skeleton","sha":"df4289d243e06e9eff66e6e502c2467969f8f7f3","user":{"login":"MerryMage","id":8682882,"avatar_url":"https://avatars.githubusercontent.com/u/8682882?v=3","gravatar_id":"","url":"https://api.github.com/users/MerryMage","html_url":"https://github.com/MerryMage","followers_url":"https://api.github.com/users/MerryMage/followers","following_url":"https://api.github.com/users/MerryMage/following{/other_user}","gists_url":"https://api.github.com/users/MerryMage/gists{/gist_id}","starred_url":"https://api.github.com/users/MerryMage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MerryMage/subscriptions","organizations_url":"https://api.github.com/users/MerryMage/orgs","repos_url":"https://api.github.com/users/MerryMage/repos","events_url":"https://api.github.com/users/MerryMage/events{/privacy}","received_events_url":"https://api.github.com/users/MerryMage/received_events","type":"User","site_admin":false},"repo":{"id":49902315,"name":"citra","full_name":"MerryMage/citra","owner":{"login":"MerryMage","id":8682882,"avatar_url":"https://avatars.githubusercontent.com/u/8682882?v=3","gravatar_id":"","url":"https://api.github.com/users/MerryMage","html_url":"https://github.com/MerryMage","followers_url":"https://api.github.com/users/MerryMage/followers","following_url":"https://api.github.com/users/MerryMage/following{/other_user}","gists_url":"https://api.github.com/users/MerryMage/gists{/gist_id}","starred_url":"https://api.github.com/users/MerryMage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MerryMage/subscriptions","organizations_url":"https://api.github.com/users/MerryMage/orgs","repos_url":"https://api.github.com/users/MerryMage/repos","events_url":"https://api.github.com/users/MerryMage/events{/privacy}","received_events_url":"https://api.github.com/users/MerryMage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MerryMage/citra","description":"Nintendo 3DS emulator/debugger","fork":true,"url":"https://api.github.com/repos/MerryMage/citra","forks_url":"https://api.github.com/repos/MerryMage/citra/forks","keys_url":"https://api.github.com/repos/MerryMage/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MerryMage/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MerryMage/citra/teams","hooks_url":"https://api.github.com/repos/MerryMage/citra/hooks","issue_events_url":"https://api.github.com/repos/MerryMage/citra/issues/events{/number}","events_url":"https://api.github.com/repos/MerryMage/citra/events","assignees_url":"https://api.github.com/repos/MerryMage/citra/assignees{/user}","branches_url":"https://api.github.com/repos/MerryMage/citra/branches{/branch}","tags_url":"https://api.github.com/repos/MerryMage/citra/tags","blobs_url":"https://api.github.com/repos/MerryMage/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MerryMage/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MerryMage/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/MerryMage/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MerryMage/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/MerryMage/citra/languages","stargazers_url":"https://api.github.com/repos/MerryMage/citra/stargazers","contributors_url":"https://api.github.com/repos/MerryMage/citra/contributors","subscribers_url":"https://api.github.com/repos/MerryMage/citra/subscribers","subscription_url":"https://api.github.com/repos/MerryMage/citra/subscription","commits_url":"https://api.github.com/repos/MerryMage/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/MerryMage/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/MerryMage/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/MerryMage/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/MerryMage/citra/contents/{+path}","compare_url":"https://api.github.com/repos/MerryMage/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MerryMage/citra/merges","archive_url":"https://api.github.com/repos/MerryMage/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MerryMage/citra/downloads","issues_url":"https://api.github.com/repos/MerryMage/citra/issues{/number}","pulls_url":"https://api.github.com/repos/MerryMage/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/MerryMage/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/MerryMage/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MerryMage/citra/labels{/name}","releases_url":"https://api.github.com/repos/MerryMage/citra/releases{/id}","deployments_url":"https://api.github.com/repos/MerryMage/citra/deployments","created_at":"2016-01-18T20:13:00Z","updated_at":"2016-01-26T06:34:03Z","pushed_at":"2016-02-01T11:32:49Z","git_url":"git://github.com/MerryMage/citra.git","ssh_url":"git@github.com:MerryMage/citra.git","clone_url":"https://github.com/MerryMage/citra.git","svn_url":"https://github.com/MerryMage/citra","homepage":null,"size":11901,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"audio-core-base"}},"base":{"label":"citra-emu:master","ref":"master","sha":"cd0b31fd7334d574477a3c92bcbd392e8c3eb5e1","user":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":19866730,"name":"citra","full_name":"citra-emu/citra","owner":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citra-emu/citra","description":"Nintendo 3DS emulator/debugger","fork":false,"url":"https://api.github.com/repos/citra-emu/citra","forks_url":"https://api.github.com/repos/citra-emu/citra/forks","keys_url":"https://api.github.com/repos/citra-emu/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/citra/teams","hooks_url":"https://api.github.com/repos/citra-emu/citra/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/citra/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/citra/events","assignees_url":"https://api.github.com/repos/citra-emu/citra/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/citra/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/citra/tags","blobs_url":"https://api.github.com/repos/citra-emu/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/citra/languages","stargazers_url":"https://api.github.com/repos/citra-emu/citra/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/citra/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/citra/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/citra/subscription","commits_url":"https://api.github.com/repos/citra-emu/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/citra-emu/citra/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/citra/merges","archive_url":"https://api.github.com/repos/citra-emu/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/citra/downloads","issues_url":"https://api.github.com/repos/citra-emu/citra/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/citra/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/citra/releases{/id}","deployments_url":"https://api.github.com/repos/citra-emu/citra/deployments","created_at":"2014-05-16T18:33:15Z","updated_at":"2016-02-01T08:08:57Z","pushed_at":"2016-02-01T13:10:30Z","git_url":"git://github.com/citra-emu/citra.git","ssh_url":"git@github.com:citra-emu/citra.git","clone_url":"https://github.com/citra-emu/citra.git","svn_url":"https://github.com/citra-emu/citra","homepage":null,"size":18786,"stargazers_count":1471,"watchers_count":1471,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":348,"mirror_url":null,"open_issues_count":145,"forks":348,"open_issues":145,"watchers":1471,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/1386"},"html":{"href":"https://github.com/citra-emu/citra/pull/1386"},"issue":{"href":"https://api.github.com/repos/citra-emu/citra/issues/1386"},"comments":{"href":"https://api.github.com/repos/citra-emu/citra/issues/1386/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/1386/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/1386/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/citra/statuses/df4289d243e06e9eff66e6e502c2467969f8f7f3"}}}}