{"action":"created","issue":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3509","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3509/labels{/name}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3509/comments","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3509/events","html_url":"https://github.com/dolphin-emu/dolphin/pull/3509","id":126453152,"number":3509,"title":"[WIP] PixelShaderGen: Manually wrap negative indirect texture coordinates","user":{"login":"stenzek","id":11288319,"avatar_url":"https://avatars.githubusercontent.com/u/11288319?v=3","gravatar_id":"","url":"https://api.github.com/users/stenzek","html_url":"https://github.com/stenzek","followers_url":"https://api.github.com/users/stenzek/followers","following_url":"https://api.github.com/users/stenzek/following{/other_user}","gists_url":"https://api.github.com/users/stenzek/gists{/gist_id}","starred_url":"https://api.github.com/users/stenzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stenzek/subscriptions","organizations_url":"https://api.github.com/users/stenzek/orgs","repos_url":"https://api.github.com/users/stenzek/repos","events_url":"https://api.github.com/users/stenzek/events{/privacy}","received_events_url":"https://api.github.com/users/stenzek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-01-13T16:09:52Z","updated_at":"2016-01-13T16:25:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3509","html_url":"https://github.com/dolphin-emu/dolphin/pull/3509","diff_url":"https://github.com/dolphin-emu/dolphin/pull/3509.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/3509.patch"},"body":"Using integer modulo here is not consistent across drivers, so we manually wrap the coordinates if they are negative.\r\n\r\nThis was causing raindrops to render incorrectly in F-Zero GX with OGL on windows/intel and mesa/llvmpipe, as well as D3D, due to the previous implementation invoking UB when the coordinates were negative. (see GLSL spec re % operator, D3D seems to take the sign from the LHS)\r\n\r\nMarked WIP because I need to clean up the changes a little still, and we're not sure if this actually matches hardware behavior in regards to how negative coordinates are handled."},"comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/171349896","html_url":"https://github.com/dolphin-emu/dolphin/pull/3509#issuecomment-171349896","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3509","id":171349896,"user":{"login":"dolphin-emu-bot","id":6899296,"avatar_url":"https://avatars.githubusercontent.com/u/6899296?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu-bot","html_url":"https://github.com/dolphin-emu-bot","followers_url":"https://api.github.com/users/dolphin-emu-bot/followers","following_url":"https://api.github.com/users/dolphin-emu-bot/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu-bot/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu-bot/orgs","repos_url":"https://api.github.com/users/dolphin-emu-bot/repos","events_url":"https://api.github.com/users/dolphin-emu-bot/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu-bot/received_events","type":"User","site_admin":false},"created_at":"2016-01-13T16:25:54Z","updated_at":"2016-01-13T16:25:54Z","body":"[FifoCI](https://fifoci.dolphin-emu.org/about/) detected that this change impacts graphical             rendering. Here are the [behavior differences](https://fifoci.dolphin-emu.org/version/ac523f8a59e42fec753a0192ed3006fe27758320/)             detected by the system:\n\n* `f-zero-rain` on `ogl-lin-intel`: [diff](https://fifoci.dolphin-emu.org/compare/1149674-1149143/)\n* `f-zero-rain` on `ogl-lin-mesa`: [diff](https://fifoci.dolphin-emu.org/compare/1149809-1149361/)\n* `ss-map` on `ogl-lin-mesa`: [diff](https://fifoci.dolphin-emu.org/compare/1149796-1149359/)\n* `f-zero-rain` on `sw-lin-mesa`: [diff](https://fifoci.dolphin-emu.org/compare/1149744-1149283/)\n* `ss-map` on `sw-lin-mesa`: [diff](https://fifoci.dolphin-emu.org/compare/1149699-1149239/)\n\n<sub><sup>automated-fifoci-reporter</sup></sub>"}}