{"action":"closed","number":971,"pull_request":{"url":"https://api.github.com/repos/yarnpkg/yarn/pulls/971","id":89151509,"html_url":"https://github.com/yarnpkg/yarn/pull/971","diff_url":"https://github.com/yarnpkg/yarn/pull/971.diff","patch_url":"https://github.com/yarnpkg/yarn/pull/971.patch","issue_url":"https://api.github.com/repos/yarnpkg/yarn/issues/971","number":971,"state":"closed","locked":false,"title":"Fix support for private GitHub shortcuts deps","user":{"login":"ramasilveyra","id":7464663,"avatar_url":"https://avatars.githubusercontent.com/u/7464663?v=3","gravatar_id":"","url":"https://api.github.com/users/ramasilveyra","html_url":"https://github.com/ramasilveyra","followers_url":"https://api.github.com/users/ramasilveyra/followers","following_url":"https://api.github.com/users/ramasilveyra/following{/other_user}","gists_url":"https://api.github.com/users/ramasilveyra/gists{/gist_id}","starred_url":"https://api.github.com/users/ramasilveyra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramasilveyra/subscriptions","organizations_url":"https://api.github.com/users/ramasilveyra/orgs","repos_url":"https://api.github.com/users/ramasilveyra/repos","events_url":"https://api.github.com/users/ramasilveyra/events{/privacy}","received_events_url":"https://api.github.com/users/ramasilveyra/received_events","type":"User","site_admin":false},"body":"**Summary**\n\nFix support for private GitHub shortcuts deps. See #573\n\n**Test plan**\n\n![Example of commands and code](https://cloud.githubusercontent.com/assets/7464663/19340622/3ca7c65e-9100-11e6-94d5-82d1aa3226db.gif)\n\nOnly works with shortcuts:\n\n``` json\n\"private-test\": \"github:ramasilveyra/private-test#d6c5789\"\n\"private-test\": \"ramasilveyra/private-test#d6c5789\"\n```\n\nI tried to follow the same name convention of [npm/hosted-git-info](https://github.com/npm/hosted-git-info) for the \"urls\".\n\nI found that npm first tries the `git://` (info.git()) url then the `git@...` (info.ssh()) url then the `https://` (info.https()) url and finally the `git+ssh://...` (info.sshurl()) url: https://github.com/npm/npm/commit/6b0f58877f37df9904490ffbaaad33862bd36dce\n\nAlso what do you think about using this package to support the same repository urls for Github, Bitbucket and Gitlab as npm? It could solve a couple of incompatibility issues.\n\nTo make it work with this urls needs a little of more work on the `GitResolver`:\n\n``` json\n\"private-test\": \"git://github.com/ramasilveyra/private-test.git#d6c5789\"\n\"private-test\": \"git@github.com:ramasilveyra/private-test.git#d6c5789\"\n\"private-test\": \"git+https://github.com/ramasilveyra/private-test.git#d6c5789\"\n\"private-test\": \"git+ssh://git@github.com/ramasilveyra/private-test.git#d6c5789\"\n```\n\n**Update**\nyarn v0.16.0 actually works with:\n\n```\n\"private-test\": \"git+ssh://git@github.com/ramasilveyra/private-test.git#d6c5789\"\n```\n","created_at":"2016-10-13T07:48:32Z","updated_at":"2016-10-31T14:54:26Z","closed_at":"2016-10-31T14:54:26Z","merged_at":null,"merge_commit_sha":"1a40a39b5e3618d881853d572e1e281aa341d267","assignee":{"login":"bestander","id":2121048,"avatar_url":"https://avatars.githubusercontent.com/u/2121048?v=3","gravatar_id":"","url":"https://api.github.com/users/bestander","html_url":"https://github.com/bestander","followers_url":"https://api.github.com/users/bestander/followers","following_url":"https://api.github.com/users/bestander/following{/other_user}","gists_url":"https://api.github.com/users/bestander/gists{/gist_id}","starred_url":"https://api.github.com/users/bestander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bestander/subscriptions","organizations_url":"https://api.github.com/users/bestander/orgs","repos_url":"https://api.github.com/users/bestander/repos","events_url":"https://api.github.com/users/bestander/events{/privacy}","received_events_url":"https://api.github.com/users/bestander/received_events","type":"User","site_admin":false},"assignees":[{"login":"bestander","id":2121048,"avatar_url":"https://avatars.githubusercontent.com/u/2121048?v=3","gravatar_id":"","url":"https://api.github.com/users/bestander","html_url":"https://github.com/bestander","followers_url":"https://api.github.com/users/bestander/followers","following_url":"https://api.github.com/users/bestander/following{/other_user}","gists_url":"https://api.github.com/users/bestander/gists{/gist_id}","starred_url":"https://api.github.com/users/bestander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bestander/subscriptions","organizations_url":"https://api.github.com/users/bestander/orgs","repos_url":"https://api.github.com/users/bestander/repos","events_url":"https://api.github.com/users/bestander/events{/privacy}","received_events_url":"https://api.github.com/users/bestander/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/971/commits","review_comments_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/971/comments","review_comment_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yarnpkg/yarn/issues/971/comments","statuses_url":"https://api.github.com/repos/yarnpkg/yarn/statuses/b0c741c7ecaf6a50c200fb3252aab6d7d75396b0","head":{"label":"ramasilveyra:fix-private-git-packages","ref":"fix-private-git-packages","sha":"b0c741c7ecaf6a50c200fb3252aab6d7d75396b0","user":{"login":"ramasilveyra","id":7464663,"avatar_url":"https://avatars.githubusercontent.com/u/7464663?v=3","gravatar_id":"","url":"https://api.github.com/users/ramasilveyra","html_url":"https://github.com/ramasilveyra","followers_url":"https://api.github.com/users/ramasilveyra/followers","following_url":"https://api.github.com/users/ramasilveyra/following{/other_user}","gists_url":"https://api.github.com/users/ramasilveyra/gists{/gist_id}","starred_url":"https://api.github.com/users/ramasilveyra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramasilveyra/subscriptions","organizations_url":"https://api.github.com/users/ramasilveyra/orgs","repos_url":"https://api.github.com/users/ramasilveyra/repos","events_url":"https://api.github.com/users/ramasilveyra/events{/privacy}","received_events_url":"https://api.github.com/users/ramasilveyra/received_events","type":"User","site_admin":false},"repo":{"id":70765208,"name":"yarn","full_name":"ramasilveyra/yarn","owner":{"login":"ramasilveyra","id":7464663,"avatar_url":"https://avatars.githubusercontent.com/u/7464663?v=3","gravatar_id":"","url":"https://api.github.com/users/ramasilveyra","html_url":"https://github.com/ramasilveyra","followers_url":"https://api.github.com/users/ramasilveyra/followers","following_url":"https://api.github.com/users/ramasilveyra/following{/other_user}","gists_url":"https://api.github.com/users/ramasilveyra/gists{/gist_id}","starred_url":"https://api.github.com/users/ramasilveyra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramasilveyra/subscriptions","organizations_url":"https://api.github.com/users/ramasilveyra/orgs","repos_url":"https://api.github.com/users/ramasilveyra/repos","events_url":"https://api.github.com/users/ramasilveyra/events{/privacy}","received_events_url":"https://api.github.com/users/ramasilveyra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ramasilveyra/yarn","description":"📦🐈 Fast, reliable, and secure dependency management.","fork":true,"url":"https://api.github.com/repos/ramasilveyra/yarn","forks_url":"https://api.github.com/repos/ramasilveyra/yarn/forks","keys_url":"https://api.github.com/repos/ramasilveyra/yarn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ramasilveyra/yarn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ramasilveyra/yarn/teams","hooks_url":"https://api.github.com/repos/ramasilveyra/yarn/hooks","issue_events_url":"https://api.github.com/repos/ramasilveyra/yarn/issues/events{/number}","events_url":"https://api.github.com/repos/ramasilveyra/yarn/events","assignees_url":"https://api.github.com/repos/ramasilveyra/yarn/assignees{/user}","branches_url":"https://api.github.com/repos/ramasilveyra/yarn/branches{/branch}","tags_url":"https://api.github.com/repos/ramasilveyra/yarn/tags","blobs_url":"https://api.github.com/repos/ramasilveyra/yarn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ramasilveyra/yarn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ramasilveyra/yarn/git/refs{/sha}","trees_url":"https://api.github.com/repos/ramasilveyra/yarn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ramasilveyra/yarn/statuses/{sha}","languages_url":"https://api.github.com/repos/ramasilveyra/yarn/languages","stargazers_url":"https://api.github.com/repos/ramasilveyra/yarn/stargazers","contributors_url":"https://api.github.com/repos/ramasilveyra/yarn/contributors","subscribers_url":"https://api.github.com/repos/ramasilveyra/yarn/subscribers","subscription_url":"https://api.github.com/repos/ramasilveyra/yarn/subscription","commits_url":"https://api.github.com/repos/ramasilveyra/yarn/commits{/sha}","git_commits_url":"https://api.github.com/repos/ramasilveyra/yarn/git/commits{/sha}","comments_url":"https://api.github.com/repos/ramasilveyra/yarn/comments{/number}","issue_comment_url":"https://api.github.com/repos/ramasilveyra/yarn/issues/comments{/number}","contents_url":"https://api.github.com/repos/ramasilveyra/yarn/contents/{+path}","compare_url":"https://api.github.com/repos/ramasilveyra/yarn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ramasilveyra/yarn/merges","archive_url":"https://api.github.com/repos/ramasilveyra/yarn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ramasilveyra/yarn/downloads","issues_url":"https://api.github.com/repos/ramasilveyra/yarn/issues{/number}","pulls_url":"https://api.github.com/repos/ramasilveyra/yarn/pulls{/number}","milestones_url":"https://api.github.com/repos/ramasilveyra/yarn/milestones{/number}","notifications_url":"https://api.github.com/repos/ramasilveyra/yarn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ramasilveyra/yarn/labels{/name}","releases_url":"https://api.github.com/repos/ramasilveyra/yarn/releases{/id}","deployments_url":"https://api.github.com/repos/ramasilveyra/yarn/deployments","created_at":"2016-10-13T03:25:08Z","updated_at":"2016-10-13T03:25:24Z","pushed_at":"2016-10-28T15:58:59Z","git_url":"git://github.com/ramasilveyra/yarn.git","ssh_url":"git@github.com:ramasilveyra/yarn.git","clone_url":"https://github.com/ramasilveyra/yarn.git","svn_url":"https://github.com/ramasilveyra/yarn","homepage":"https://yarnpkg.com","size":41501,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yarnpkg:master","ref":"master","sha":"0c63149deddced5c7d4b1fe74fb0d0c496e6f888","user":{"login":"yarnpkg","id":22247014,"avatar_url":"https://avatars.githubusercontent.com/u/22247014?v=3","gravatar_id":"","url":"https://api.github.com/users/yarnpkg","html_url":"https://github.com/yarnpkg","followers_url":"https://api.github.com/users/yarnpkg/followers","following_url":"https://api.github.com/users/yarnpkg/following{/other_user}","gists_url":"https://api.github.com/users/yarnpkg/gists{/gist_id}","starred_url":"https://api.github.com/users/yarnpkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarnpkg/subscriptions","organizations_url":"https://api.github.com/users/yarnpkg/orgs","repos_url":"https://api.github.com/users/yarnpkg/repos","events_url":"https://api.github.com/users/yarnpkg/events{/privacy}","received_events_url":"https://api.github.com/users/yarnpkg/received_events","type":"Organization","site_admin":false},"repo":{"id":49970642,"name":"yarn","full_name":"yarnpkg/yarn","owner":{"login":"yarnpkg","id":22247014,"avatar_url":"https://avatars.githubusercontent.com/u/22247014?v=3","gravatar_id":"","url":"https://api.github.com/users/yarnpkg","html_url":"https://github.com/yarnpkg","followers_url":"https://api.github.com/users/yarnpkg/followers","following_url":"https://api.github.com/users/yarnpkg/following{/other_user}","gists_url":"https://api.github.com/users/yarnpkg/gists{/gist_id}","starred_url":"https://api.github.com/users/yarnpkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarnpkg/subscriptions","organizations_url":"https://api.github.com/users/yarnpkg/orgs","repos_url":"https://api.github.com/users/yarnpkg/repos","events_url":"https://api.github.com/users/yarnpkg/events{/privacy}","received_events_url":"https://api.github.com/users/yarnpkg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yarnpkg/yarn","description":"📦🐈 Fast, reliable, and secure dependency management.","fork":false,"url":"https://api.github.com/repos/yarnpkg/yarn","forks_url":"https://api.github.com/repos/yarnpkg/yarn/forks","keys_url":"https://api.github.com/repos/yarnpkg/yarn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarnpkg/yarn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarnpkg/yarn/teams","hooks_url":"https://api.github.com/repos/yarnpkg/yarn/hooks","issue_events_url":"https://api.github.com/repos/yarnpkg/yarn/issues/events{/number}","events_url":"https://api.github.com/repos/yarnpkg/yarn/events","assignees_url":"https://api.github.com/repos/yarnpkg/yarn/assignees{/user}","branches_url":"https://api.github.com/repos/yarnpkg/yarn/branches{/branch}","tags_url":"https://api.github.com/repos/yarnpkg/yarn/tags","blobs_url":"https://api.github.com/repos/yarnpkg/yarn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarnpkg/yarn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarnpkg/yarn/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarnpkg/yarn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarnpkg/yarn/statuses/{sha}","languages_url":"https://api.github.com/repos/yarnpkg/yarn/languages","stargazers_url":"https://api.github.com/repos/yarnpkg/yarn/stargazers","contributors_url":"https://api.github.com/repos/yarnpkg/yarn/contributors","subscribers_url":"https://api.github.com/repos/yarnpkg/yarn/subscribers","subscription_url":"https://api.github.com/repos/yarnpkg/yarn/subscription","commits_url":"https://api.github.com/repos/yarnpkg/yarn/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarnpkg/yarn/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarnpkg/yarn/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarnpkg/yarn/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarnpkg/yarn/contents/{+path}","compare_url":"https://api.github.com/repos/yarnpkg/yarn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarnpkg/yarn/merges","archive_url":"https://api.github.com/repos/yarnpkg/yarn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarnpkg/yarn/downloads","issues_url":"https://api.github.com/repos/yarnpkg/yarn/issues{/number}","pulls_url":"https://api.github.com/repos/yarnpkg/yarn/pulls{/number}","milestones_url":"https://api.github.com/repos/yarnpkg/yarn/milestones{/number}","notifications_url":"https://api.github.com/repos/yarnpkg/yarn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarnpkg/yarn/labels{/name}","releases_url":"https://api.github.com/repos/yarnpkg/yarn/releases{/id}","deployments_url":"https://api.github.com/repos/yarnpkg/yarn/deployments","created_at":"2016-01-19T17:39:16Z","updated_at":"2016-10-31T14:54:05Z","pushed_at":"2016-10-31T14:28:32Z","git_url":"git://github.com/yarnpkg/yarn.git","ssh_url":"git@github.com:yarnpkg/yarn.git","clone_url":"https://github.com/yarnpkg/yarn.git","svn_url":"https://github.com/yarnpkg/yarn","homepage":"https://yarnpkg.com","size":52009,"stargazers_count":17973,"watchers_count":17973,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":566,"mirror_url":null,"open_issues_count":399,"forks":566,"open_issues":399,"watchers":17973,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/971"},"html":{"href":"https://github.com/yarnpkg/yarn/pull/971"},"issue":{"href":"https://api.github.com/repos/yarnpkg/yarn/issues/971"},"comments":{"href":"https://api.github.com/repos/yarnpkg/yarn/issues/971/comments"},"review_comments":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/971/comments"},"review_comment":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/971/commits"},"statuses":{"href":"https://api.github.com/repos/yarnpkg/yarn/statuses/b0c741c7ecaf6a50c200fb3252aab6d7d75396b0"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":19,"review_comments":3,"commits":1,"additions":53,"deletions":11,"changed_files":8}}
{"actor":{"display_login":"ramasilveyra"}}