{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/79347006","id":79347006,"diff_hunk":"@@ -820,15 +826,60 @@ def dump_cff( self, outName = None, jsonPath = None, begin = None,\n         theFile.close()\n         return\n \n-    def fileList( self, parent = False ):\n+    def createdatasetfile_hippy(self, filename, filesperjob, firstrun, lastrun):\n+        with open(filename, \"w\") as f:\n+            for job in self.__chunks(self.fileList(firstRun=firstrun, lastRun=lastrun, forcerunselection=True), filesperjob):\n+                f.write(\",\".join(\"'{}'\".format(file) for file in job)+\"\\n\")\n+\n+    @staticmethod\n+    def getrunnumberfromfilename(filename):\n+        parts = filename.split(\"/\")\n+        result = error = None\n+        if parts[0] != \"\" or parts[1] != \"store\":","path":"Alignment/OfflineValidation/python/TkAlAllInOneTool/dataset.py","position":145,"original_position":145,"commit_id":"2fe508a49fa9cb22a05e31c9c33b1762d9954cfe","original_commit_id":"2fe508a49fa9cb22a05e31c9c33b1762d9954cfe","user":{"login":"ghellwig","id":4136328,"avatar_url":"https://avatars.githubusercontent.com/u/4136328?v=3","gravatar_id":"","url":"https://api.github.com/users/ghellwig","html_url":"https://github.com/ghellwig","followers_url":"https://api.github.com/users/ghellwig/followers","following_url":"https://api.github.com/users/ghellwig/following{/other_user}","gists_url":"https://api.github.com/users/ghellwig/gists{/gist_id}","starred_url":"https://api.github.com/users/ghellwig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghellwig/subscriptions","organizations_url":"https://api.github.com/users/ghellwig/orgs","repos_url":"https://api.github.com/users/ghellwig/repos","events_url":"https://api.github.com/users/ghellwig/events{/privacy}","received_events_url":"https://api.github.com/users/ghellwig/received_events","type":"User","site_admin":false},"body":"@hroskes shouldn't it be `and` instead of `or`?","created_at":"2016-09-19T08:43:13Z","updated_at":"2016-09-19T08:43:13Z","html_url":"https://github.com/cms-sw/cmssw/pull/15886#discussion_r79347006","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15886","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/79347006"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/15886#discussion_r79347006"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/15886"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15886","id":85643159,"html_url":"https://github.com/cms-sw/cmssw/pull/15886","diff_url":"https://github.com/cms-sw/cmssw/pull/15886.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/15886.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15886","number":15886,"state":"open","locked":false,"title":"Script to create a HipPy input dataset file","user":{"login":"hroskes","id":5262585,"avatar_url":"https://avatars.githubusercontent.com/u/5262585?v=3","gravatar_id":"","url":"https://api.github.com/users/hroskes","html_url":"https://github.com/hroskes","followers_url":"https://api.github.com/users/hroskes/followers","following_url":"https://api.github.com/users/hroskes/following{/other_user}","gists_url":"https://api.github.com/users/hroskes/gists{/gist_id}","starred_url":"https://api.github.com/users/hroskes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hroskes/subscriptions","organizations_url":"https://api.github.com/users/hroskes/orgs","repos_url":"https://api.github.com/users/hroskes/repos","events_url":"https://api.github.com/users/hroskes/events{/privacy}","received_events_url":"https://api.github.com/users/hroskes/received_events","type":"User","site_admin":false},"body":"Can also add a similar function for MP if that's needed, but I'm not familiar with the syntax.\r\n\r\nAlso make the AIO tool dataset class a bit more general by splitting up the biggest function.  No point in rewriting another module to do the same thing.\r\n\r\nAlso, remove some inefficiency in validation by skipping files that have the run number in their filename if they are not in the selected run range.\r\n\r\nAnd a little fix in the geometry comparison.","created_at":"2016-09-16T21:32:37Z","updated_at":"2016-09-19T08:56:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"327402d75bf5c3c5f1afc8775698885765ce2bf9","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":56,"closed_issues":1474,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-09-19T06:07:03Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15886/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15886/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15886/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/2fe508a49fa9cb22a05e31c9c33b1762d9954cfe","head":{"label":"hroskes:hippy-dataset","ref":"hippy-dataset","sha":"2fe508a49fa9cb22a05e31c9c33b1762d9954cfe","user":{"login":"hroskes","id":5262585,"avatar_url":"https://avatars.githubusercontent.com/u/5262585?v=3","gravatar_id":"","url":"https://api.github.com/users/hroskes","html_url":"https://github.com/hroskes","followers_url":"https://api.github.com/users/hroskes/followers","following_url":"https://api.github.com/users/hroskes/following{/other_user}","gists_url":"https://api.github.com/users/hroskes/gists{/gist_id}","starred_url":"https://api.github.com/users/hroskes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hroskes/subscriptions","organizations_url":"https://api.github.com/users/hroskes/orgs","repos_url":"https://api.github.com/users/hroskes/repos","events_url":"https://api.github.com/users/hroskes/events{/privacy}","received_events_url":"https://api.github.com/users/hroskes/received_events","type":"User","site_admin":false},"repo":{"id":16704466,"name":"cmssw","full_name":"hroskes/cmssw","owner":{"login":"hroskes","id":5262585,"avatar_url":"https://avatars.githubusercontent.com/u/5262585?v=3","gravatar_id":"","url":"https://api.github.com/users/hroskes","html_url":"https://github.com/hroskes","followers_url":"https://api.github.com/users/hroskes/followers","following_url":"https://api.github.com/users/hroskes/following{/other_user}","gists_url":"https://api.github.com/users/hroskes/gists{/gist_id}","starred_url":"https://api.github.com/users/hroskes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hroskes/subscriptions","organizations_url":"https://api.github.com/users/hroskes/orgs","repos_url":"https://api.github.com/users/hroskes/repos","events_url":"https://api.github.com/users/hroskes/events{/privacy}","received_events_url":"https://api.github.com/users/hroskes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hroskes/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/hroskes/cmssw","forks_url":"https://api.github.com/repos/hroskes/cmssw/forks","keys_url":"https://api.github.com/repos/hroskes/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hroskes/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hroskes/cmssw/teams","hooks_url":"https://api.github.com/repos/hroskes/cmssw/hooks","issue_events_url":"https://api.github.com/repos/hroskes/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/hroskes/cmssw/events","assignees_url":"https://api.github.com/repos/hroskes/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/hroskes/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/hroskes/cmssw/tags","blobs_url":"https://api.github.com/repos/hroskes/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hroskes/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hroskes/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/hroskes/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hroskes/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/hroskes/cmssw/languages","stargazers_url":"https://api.github.com/repos/hroskes/cmssw/stargazers","contributors_url":"https://api.github.com/repos/hroskes/cmssw/contributors","subscribers_url":"https://api.github.com/repos/hroskes/cmssw/subscribers","subscription_url":"https://api.github.com/repos/hroskes/cmssw/subscription","commits_url":"https://api.github.com/repos/hroskes/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/hroskes/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/hroskes/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/hroskes/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/hroskes/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/hroskes/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hroskes/cmssw/merges","archive_url":"https://api.github.com/repos/hroskes/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hroskes/cmssw/downloads","issues_url":"https://api.github.com/repos/hroskes/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/hroskes/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/hroskes/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/hroskes/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hroskes/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/hroskes/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/hroskes/cmssw/deployments","created_at":"2014-02-10T18:17:12Z","updated_at":"2015-03-02T17:43:22Z","pushed_at":"2016-09-16T21:29:13Z","git_url":"git://github.com/hroskes/cmssw.git","ssh_url":"git@github.com:hroskes/cmssw.git","clone_url":"https://github.com/hroskes/cmssw.git","svn_url":"https://github.com/hroskes/cmssw","homepage":"cms-sw.github.io/cmssw","size":795972,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_8_1_X"}},"base":{"label":"cms-sw:CMSSW_8_1_X","ref":"CMSSW_8_1_X","sha":"813e5adfbc1678f6e7f1f7558b9cb2bc8654a8b8","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2016-09-16T11:38:20Z","pushed_at":"2016-09-19T06:36:20Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1108503,"stargazers_count":341,"watchers_count":341,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1978,"mirror_url":null,"open_issues_count":358,"forks":1978,"open_issues":358,"watchers":341,"default_branch":"CMSSW_8_1_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/15886"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/15886"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/15886"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/15886/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/15886/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/15886/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/2fe508a49fa9cb22a05e31c9c33b1762d9954cfe"}}}}
{"actor":{"display_login":"ghellwig"}}