{"action":"opened","number":947,"pull_request":{"url":"https://api.github.com/repos/shazow/urllib3/pulls/947","id":81309340,"html_url":"https://github.com/shazow/urllib3/pull/947","diff_url":"https://github.com/shazow/urllib3/pull/947.diff","patch_url":"https://github.com/shazow/urllib3/pull/947.patch","issue_url":"https://api.github.com/repos/shazow/urllib3/issues/947","number":947,"state":"open","locked":false,"title":"Add support for ChaCha20.","user":{"login":"Lukasa","id":1382556,"avatar_url":"https://avatars.githubusercontent.com/u/1382556?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukasa","html_url":"https://github.com/Lukasa","followers_url":"https://api.github.com/users/Lukasa/followers","following_url":"https://api.github.com/users/Lukasa/following{/other_user}","gists_url":"https://api.github.com/users/Lukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukasa/subscriptions","organizations_url":"https://api.github.com/users/Lukasa/orgs","repos_url":"https://api.github.com/users/Lukasa/repos","events_url":"https://api.github.com/users/Lukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Lukasa/received_events","type":"User","site_admin":false},"body":"ChaCha20 is coming in OpenSSL 1.1.0, and it's generally pretty excellent. OpenSSL kindly ignores requests for ciphers that it doesn't support, so we can unconditionally update our code to request ChaCha20 and expect OpenSSL to just quietly ignore the change when it doesn't know what ChaCha is.\r\n\r\nThis change has us prefer AES-GCM over ChaCha20. This decision is made mostly because newer processors have AES-NI hardware acceleration instructions, and right now we're not in a good place to query whether or not those instructions are present, so we just assume that they are. However, [CPython issue 27766](https://bugs.python.org/issue27766), in addition to making this change, also provides a private function that could be queried for AES-NI support. We may want to wait until CPython 3.6 drops to see if that function makes it in, because we could use it to be smarter about our cipher string.","created_at":"2016-08-15T13:08:28Z","updated_at":"2016-08-15T13:08:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/shazow/urllib3/pulls/947/commits","review_comments_url":"https://api.github.com/repos/shazow/urllib3/pulls/947/comments","review_comment_url":"https://api.github.com/repos/shazow/urllib3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shazow/urllib3/issues/947/comments","statuses_url":"https://api.github.com/repos/shazow/urllib3/statuses/809de735db497b2e8249b45d12ca0acf7466fe4f","head":{"label":"Lukasa:update-cipher-suites","ref":"update-cipher-suites","sha":"809de735db497b2e8249b45d12ca0acf7466fe4f","user":{"login":"Lukasa","id":1382556,"avatar_url":"https://avatars.githubusercontent.com/u/1382556?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukasa","html_url":"https://github.com/Lukasa","followers_url":"https://api.github.com/users/Lukasa/followers","following_url":"https://api.github.com/users/Lukasa/following{/other_user}","gists_url":"https://api.github.com/users/Lukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukasa/subscriptions","organizations_url":"https://api.github.com/users/Lukasa/orgs","repos_url":"https://api.github.com/users/Lukasa/repos","events_url":"https://api.github.com/users/Lukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Lukasa/received_events","type":"User","site_admin":false},"repo":{"id":7964060,"name":"urllib3","full_name":"Lukasa/urllib3","owner":{"login":"Lukasa","id":1382556,"avatar_url":"https://avatars.githubusercontent.com/u/1382556?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukasa","html_url":"https://github.com/Lukasa","followers_url":"https://api.github.com/users/Lukasa/followers","following_url":"https://api.github.com/users/Lukasa/following{/other_user}","gists_url":"https://api.github.com/users/Lukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukasa/subscriptions","organizations_url":"https://api.github.com/users/Lukasa/orgs","repos_url":"https://api.github.com/users/Lukasa/repos","events_url":"https://api.github.com/users/Lukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Lukasa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Lukasa/urllib3","description":"Python HTTP library with thread-safe connection pooling, file post support, sanity friendly, and more.","fork":true,"url":"https://api.github.com/repos/Lukasa/urllib3","forks_url":"https://api.github.com/repos/Lukasa/urllib3/forks","keys_url":"https://api.github.com/repos/Lukasa/urllib3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lukasa/urllib3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lukasa/urllib3/teams","hooks_url":"https://api.github.com/repos/Lukasa/urllib3/hooks","issue_events_url":"https://api.github.com/repos/Lukasa/urllib3/issues/events{/number}","events_url":"https://api.github.com/repos/Lukasa/urllib3/events","assignees_url":"https://api.github.com/repos/Lukasa/urllib3/assignees{/user}","branches_url":"https://api.github.com/repos/Lukasa/urllib3/branches{/branch}","tags_url":"https://api.github.com/repos/Lukasa/urllib3/tags","blobs_url":"https://api.github.com/repos/Lukasa/urllib3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lukasa/urllib3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lukasa/urllib3/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lukasa/urllib3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lukasa/urllib3/statuses/{sha}","languages_url":"https://api.github.com/repos/Lukasa/urllib3/languages","stargazers_url":"https://api.github.com/repos/Lukasa/urllib3/stargazers","contributors_url":"https://api.github.com/repos/Lukasa/urllib3/contributors","subscribers_url":"https://api.github.com/repos/Lukasa/urllib3/subscribers","subscription_url":"https://api.github.com/repos/Lukasa/urllib3/subscription","commits_url":"https://api.github.com/repos/Lukasa/urllib3/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lukasa/urllib3/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lukasa/urllib3/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lukasa/urllib3/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lukasa/urllib3/contents/{+path}","compare_url":"https://api.github.com/repos/Lukasa/urllib3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lukasa/urllib3/merges","archive_url":"https://api.github.com/repos/Lukasa/urllib3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lukasa/urllib3/downloads","issues_url":"https://api.github.com/repos/Lukasa/urllib3/issues{/number}","pulls_url":"https://api.github.com/repos/Lukasa/urllib3/pulls{/number}","milestones_url":"https://api.github.com/repos/Lukasa/urllib3/milestones{/number}","notifications_url":"https://api.github.com/repos/Lukasa/urllib3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lukasa/urllib3/labels{/name}","releases_url":"https://api.github.com/repos/Lukasa/urllib3/releases{/id}","deployments_url":"https://api.github.com/repos/Lukasa/urllib3/deployments","created_at":"2013-02-01T18:51:13Z","updated_at":"2016-03-04T10:52:02Z","pushed_at":"2016-08-15T13:04:09Z","git_url":"git://github.com/Lukasa/urllib3.git","ssh_url":"git@github.com:Lukasa/urllib3.git","clone_url":"https://github.com/Lukasa/urllib3.git","svn_url":"https://github.com/Lukasa/urllib3","homepage":"http://urllib3.readthedocs.org/","size":2888,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"shazow:master","ref":"master","sha":"fce51c7bdd5acbf6c6e01aaa9149025749a73bdc","user":{"login":"shazow","id":6292,"avatar_url":"https://avatars.githubusercontent.com/u/6292?v=3","gravatar_id":"","url":"https://api.github.com/users/shazow","html_url":"https://github.com/shazow","followers_url":"https://api.github.com/users/shazow/followers","following_url":"https://api.github.com/users/shazow/following{/other_user}","gists_url":"https://api.github.com/users/shazow/gists{/gist_id}","starred_url":"https://api.github.com/users/shazow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shazow/subscriptions","organizations_url":"https://api.github.com/users/shazow/orgs","repos_url":"https://api.github.com/users/shazow/repos","events_url":"https://api.github.com/users/shazow/events{/privacy}","received_events_url":"https://api.github.com/users/shazow/received_events","type":"User","site_admin":false},"repo":{"id":2410676,"name":"urllib3","full_name":"shazow/urllib3","owner":{"login":"shazow","id":6292,"avatar_url":"https://avatars.githubusercontent.com/u/6292?v=3","gravatar_id":"","url":"https://api.github.com/users/shazow","html_url":"https://github.com/shazow","followers_url":"https://api.github.com/users/shazow/followers","following_url":"https://api.github.com/users/shazow/following{/other_user}","gists_url":"https://api.github.com/users/shazow/gists{/gist_id}","starred_url":"https://api.github.com/users/shazow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shazow/subscriptions","organizations_url":"https://api.github.com/users/shazow/orgs","repos_url":"https://api.github.com/users/shazow/repos","events_url":"https://api.github.com/users/shazow/events{/privacy}","received_events_url":"https://api.github.com/users/shazow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shazow/urllib3","description":"Python HTTP library with thread-safe connection pooling, file post support, sanity friendly, and more.","fork":false,"url":"https://api.github.com/repos/shazow/urllib3","forks_url":"https://api.github.com/repos/shazow/urllib3/forks","keys_url":"https://api.github.com/repos/shazow/urllib3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shazow/urllib3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shazow/urllib3/teams","hooks_url":"https://api.github.com/repos/shazow/urllib3/hooks","issue_events_url":"https://api.github.com/repos/shazow/urllib3/issues/events{/number}","events_url":"https://api.github.com/repos/shazow/urllib3/events","assignees_url":"https://api.github.com/repos/shazow/urllib3/assignees{/user}","branches_url":"https://api.github.com/repos/shazow/urllib3/branches{/branch}","tags_url":"https://api.github.com/repos/shazow/urllib3/tags","blobs_url":"https://api.github.com/repos/shazow/urllib3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shazow/urllib3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shazow/urllib3/git/refs{/sha}","trees_url":"https://api.github.com/repos/shazow/urllib3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shazow/urllib3/statuses/{sha}","languages_url":"https://api.github.com/repos/shazow/urllib3/languages","stargazers_url":"https://api.github.com/repos/shazow/urllib3/stargazers","contributors_url":"https://api.github.com/repos/shazow/urllib3/contributors","subscribers_url":"https://api.github.com/repos/shazow/urllib3/subscribers","subscription_url":"https://api.github.com/repos/shazow/urllib3/subscription","commits_url":"https://api.github.com/repos/shazow/urllib3/commits{/sha}","git_commits_url":"https://api.github.com/repos/shazow/urllib3/git/commits{/sha}","comments_url":"https://api.github.com/repos/shazow/urllib3/comments{/number}","issue_comment_url":"https://api.github.com/repos/shazow/urllib3/issues/comments{/number}","contents_url":"https://api.github.com/repos/shazow/urllib3/contents/{+path}","compare_url":"https://api.github.com/repos/shazow/urllib3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shazow/urllib3/merges","archive_url":"https://api.github.com/repos/shazow/urllib3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shazow/urllib3/downloads","issues_url":"https://api.github.com/repos/shazow/urllib3/issues{/number}","pulls_url":"https://api.github.com/repos/shazow/urllib3/pulls{/number}","milestones_url":"https://api.github.com/repos/shazow/urllib3/milestones{/number}","notifications_url":"https://api.github.com/repos/shazow/urllib3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shazow/urllib3/labels{/name}","releases_url":"https://api.github.com/repos/shazow/urllib3/releases{/id}","deployments_url":"https://api.github.com/repos/shazow/urllib3/deployments","created_at":"2011-09-18T18:08:28Z","updated_at":"2016-08-12T13:38:21Z","pushed_at":"2016-08-12T14:41:34Z","git_url":"git://github.com/shazow/urllib3.git","ssh_url":"git@github.com:shazow/urllib3.git","clone_url":"https://github.com/shazow/urllib3.git","svn_url":"https://github.com/shazow/urllib3","homepage":"https://urllib3.readthedocs.io/","size":4711,"stargazers_count":1100,"watchers_count":1100,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":367,"mirror_url":null,"open_issues_count":122,"forks":367,"open_issues":122,"watchers":1100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shazow/urllib3/pulls/947"},"html":{"href":"https://github.com/shazow/urllib3/pull/947"},"issue":{"href":"https://api.github.com/repos/shazow/urllib3/issues/947"},"comments":{"href":"https://api.github.com/repos/shazow/urllib3/issues/947/comments"},"review_comments":{"href":"https://api.github.com/repos/shazow/urllib3/pulls/947/comments"},"review_comment":{"href":"https://api.github.com/repos/shazow/urllib3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shazow/urllib3/pulls/947/commits"},"statuses":{"href":"https://api.github.com/repos/shazow/urllib3/statuses/809de735db497b2e8249b45d12ca0acf7466fe4f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"Lukasa"}}