{"action":"created","comment":{"url":"https://api.github.com/repos/sulu/sulu/pulls/comments/69084559","id":69084559,"diff_hunk":"@@ -545,7 +545,7 @@ private function createPage($title, $locale, $data = [], $parent = null, array $\n             $path = $this->sessionManager->getContentPath('sulu_io') . '/' . $title;\n         }\n         if ($parent !== null) {\n-            $path = $parent->getPath();\n+            $path = $parent->getPath() . '/' . $title;","path":"src/Sulu/Bundle/ContentBundle/Tests/Functional/Controller/NodeControllerFieldsTest.php","position":5,"original_position":5,"commit_id":"2d00582b8ea8cb0f89e858f2ece6dad1e8adfd6f","original_commit_id":"2d00582b8ea8cb0f89e858f2ece6dad1e8adfd6f","user":{"login":"danrot","id":405874,"avatar_url":"https://avatars.githubusercontent.com/u/405874?v=3","gravatar_id":"","url":"https://api.github.com/users/danrot","html_url":"https://github.com/danrot","followers_url":"https://api.github.com/users/danrot/followers","following_url":"https://api.github.com/users/danrot/following{/other_user}","gists_url":"https://api.github.com/users/danrot/gists{/gist_id}","starred_url":"https://api.github.com/users/danrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrot/subscriptions","organizations_url":"https://api.github.com/users/danrot/orgs","repos_url":"https://api.github.com/users/danrot/repos","events_url":"https://api.github.com/users/danrot/events{/privacy}","received_events_url":"https://api.github.com/users/danrot/received_events","type":"User","site_admin":false},"body":"Check why this was necessary.","created_at":"2016-06-30T07:34:58Z","updated_at":"2016-06-30T07:34:58Z","html_url":"https://github.com/sulu/sulu/pull/2361#discussion_r69084559","pull_request_url":"https://api.github.com/repos/sulu/sulu/pulls/2361","_links":{"self":{"href":"https://api.github.com/repos/sulu/sulu/pulls/comments/69084559"},"html":{"href":"https://github.com/sulu/sulu/pull/2361#discussion_r69084559"},"pull_request":{"href":"https://api.github.com/repos/sulu/sulu/pulls/2361"}}},"pull_request":{"url":"https://api.github.com/repos/sulu/sulu/pulls/2361","id":68813399,"html_url":"https://github.com/sulu/sulu/pull/2361","diff_url":"https://github.com/sulu/sulu/pull/2361.diff","patch_url":"https://github.com/sulu/sulu/pull/2361.patch","issue_url":"https://api.github.com/repos/sulu/sulu/issues/2361","number":2361,"state":"open","locked":false,"title":"added publishing mechanism to pages","user":{"login":"danrot","id":405874,"avatar_url":"https://avatars.githubusercontent.com/u/405874?v=3","gravatar_id":"","url":"https://api.github.com/users/danrot","html_url":"https://github.com/danrot","followers_url":"https://api.github.com/users/danrot/followers","following_url":"https://api.github.com/users/danrot/following{/other_user}","gists_url":"https://api.github.com/users/danrot/gists{/gist_id}","starred_url":"https://api.github.com/users/danrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrot/subscriptions","organizations_url":"https://api.github.com/users/danrot/orgs","repos_url":"https://api.github.com/users/danrot/repos","events_url":"https://api.github.com/users/danrot/events{/privacy}","received_events_url":"https://api.github.com/users/danrot/received_events","type":"User","site_admin":false},"body":"| Q | A\r\n| --- | ---\r\n| Bug fix? | no\r\n| New feature? | yes\r\n| BC breaks? | no\r\n| Deprecations? | no\r\n| Fixed tickets | fixes #2028 \r\n| Related issues/PRs | https://github.com/sulu/sulu-document-manager/pull/81 https://github.com/sulu/sulu/pull/2386 https://github.com/sulu/sulu/pull/2414 #2448 #2479 https://github.com/massiveart/husky/pull/661 https://github.com/sulu/sulu-standard/pull/696 https://github.com/massiveart/husky/pull/664 https://github.com/massiveart/husky/pull/636 https://github.com/sulu/sulu/pull/2509 #2518\r\n| License | MIT\r\n| Documentation PR | TODO\r\n\r\n#### What's in this PR?\r\n\r\nThis PR implements the new drafting feature once it is finished.\r\n\r\n#### To Do\r\n\r\n- [ ] Create a documentation PR\r\n- [ ] French translations\r\n- [ ] Split into smaller parts\r\n    - [x] FormTypes and serialization (movement of parent attribute) (#2518)\r\n    - [ ] UI?\r\n- [x] Check failing test for changing snippet type to not existing snippet type (use paths instead of UUID again)\r\n- [x] Show a simple save button when shadow checkbox is selected in settings tab\r\n- [x] Delete history routes\r\n- [x] Remove restore history routes (#2479)\r\n- [x] Change URL from published ResourceSegment after move (currently the draft value is taken)\r\n- [x] Copy page should result always in a draft page\r\n- [x] Show green dot in column navigation for published pages (only if also draft exists)\r\n- [x] Search Subscriber should index for persist and publish, but in different indexes\r\n- [x] Publish `CustomUrl` immediately\r\n- [x] `AutoNameSubscriber` should be usable without `StructureBehavior` (then the AutoNameBehavior could be reused for `CustomUrl`) (#2448)\r\n- [x] Publish from other forms than content (not working for settings)\r\n- [x] ~~Publish security?~~ (not important before having security on the website)\r\n- [x] Save page with draft should not check if resource locator is already in use\r\n    - [x] Move check to publish\r\n- [x] Show history of routes shows infinite loader when no route exists yet\r\n- [x] Show label for draft\r\n- [ ] Delete draft (separate commit)\r\n- [ ] Add possibility to disable publishing\r\n- [ ] Reindex must also work correctly (currently has to be executed for admin and website context)\r\n- [ ] Ask the user if published or draft should be copied","created_at":"2016-05-04T05:43:27Z","updated_at":"2016-06-30T07:34:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f085746abb0cd27271d88508d8c113413bbc9198","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sulu/sulu/pulls/2361/commits","review_comments_url":"https://api.github.com/repos/sulu/sulu/pulls/2361/comments","review_comment_url":"https://api.github.com/repos/sulu/sulu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sulu/sulu/issues/2361/comments","statuses_url":"https://api.github.com/repos/sulu/sulu/statuses/2d00582b8ea8cb0f89e858f2ece6dad1e8adfd6f","head":{"label":"danrot:feature/publishing","ref":"feature/publishing","sha":"2d00582b8ea8cb0f89e858f2ece6dad1e8adfd6f","user":{"login":"danrot","id":405874,"avatar_url":"https://avatars.githubusercontent.com/u/405874?v=3","gravatar_id":"","url":"https://api.github.com/users/danrot","html_url":"https://github.com/danrot","followers_url":"https://api.github.com/users/danrot/followers","following_url":"https://api.github.com/users/danrot/following{/other_user}","gists_url":"https://api.github.com/users/danrot/gists{/gist_id}","starred_url":"https://api.github.com/users/danrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrot/subscriptions","organizations_url":"https://api.github.com/users/danrot/orgs","repos_url":"https://api.github.com/users/danrot/repos","events_url":"https://api.github.com/users/danrot/events{/privacy}","received_events_url":"https://api.github.com/users/danrot/received_events","type":"User","site_admin":false},"repo":{"id":52616950,"name":"sulu","full_name":"danrot/sulu","owner":{"login":"danrot","id":405874,"avatar_url":"https://avatars.githubusercontent.com/u/405874?v=3","gravatar_id":"","url":"https://api.github.com/users/danrot","html_url":"https://github.com/danrot","followers_url":"https://api.github.com/users/danrot/followers","following_url":"https://api.github.com/users/danrot/following{/other_user}","gists_url":"https://api.github.com/users/danrot/gists{/gist_id}","starred_url":"https://api.github.com/users/danrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrot/subscriptions","organizations_url":"https://api.github.com/users/danrot/orgs","repos_url":"https://api.github.com/users/danrot/repos","events_url":"https://api.github.com/users/danrot/events{/privacy}","received_events_url":"https://api.github.com/users/danrot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danrot/sulu","description":"Sulu core bundles & components","fork":true,"url":"https://api.github.com/repos/danrot/sulu","forks_url":"https://api.github.com/repos/danrot/sulu/forks","keys_url":"https://api.github.com/repos/danrot/sulu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danrot/sulu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danrot/sulu/teams","hooks_url":"https://api.github.com/repos/danrot/sulu/hooks","issue_events_url":"https://api.github.com/repos/danrot/sulu/issues/events{/number}","events_url":"https://api.github.com/repos/danrot/sulu/events","assignees_url":"https://api.github.com/repos/danrot/sulu/assignees{/user}","branches_url":"https://api.github.com/repos/danrot/sulu/branches{/branch}","tags_url":"https://api.github.com/repos/danrot/sulu/tags","blobs_url":"https://api.github.com/repos/danrot/sulu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danrot/sulu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danrot/sulu/git/refs{/sha}","trees_url":"https://api.github.com/repos/danrot/sulu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danrot/sulu/statuses/{sha}","languages_url":"https://api.github.com/repos/danrot/sulu/languages","stargazers_url":"https://api.github.com/repos/danrot/sulu/stargazers","contributors_url":"https://api.github.com/repos/danrot/sulu/contributors","subscribers_url":"https://api.github.com/repos/danrot/sulu/subscribers","subscription_url":"https://api.github.com/repos/danrot/sulu/subscription","commits_url":"https://api.github.com/repos/danrot/sulu/commits{/sha}","git_commits_url":"https://api.github.com/repos/danrot/sulu/git/commits{/sha}","comments_url":"https://api.github.com/repos/danrot/sulu/comments{/number}","issue_comment_url":"https://api.github.com/repos/danrot/sulu/issues/comments{/number}","contents_url":"https://api.github.com/repos/danrot/sulu/contents/{+path}","compare_url":"https://api.github.com/repos/danrot/sulu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danrot/sulu/merges","archive_url":"https://api.github.com/repos/danrot/sulu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danrot/sulu/downloads","issues_url":"https://api.github.com/repos/danrot/sulu/issues{/number}","pulls_url":"https://api.github.com/repos/danrot/sulu/pulls{/number}","milestones_url":"https://api.github.com/repos/danrot/sulu/milestones{/number}","notifications_url":"https://api.github.com/repos/danrot/sulu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danrot/sulu/labels{/name}","releases_url":"https://api.github.com/repos/danrot/sulu/releases{/id}","deployments_url":"https://api.github.com/repos/danrot/sulu/deployments","created_at":"2016-02-26T16:22:17Z","updated_at":"2016-02-26T16:22:24Z","pushed_at":"2016-06-30T07:06:35Z","git_url":"git://github.com/danrot/sulu.git","ssh_url":"git@github.com:danrot/sulu.git","clone_url":"https://github.com/danrot/sulu.git","svn_url":"https://github.com/danrot/sulu","homepage":"sulu.io","size":71037,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"sulu:develop","ref":"develop","sha":"7b56068cd6cbbaf48df0c50d7486114233e91173","user":{"login":"sulu","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=3","gravatar_id":"","url":"https://api.github.com/users/sulu","html_url":"https://github.com/sulu","followers_url":"https://api.github.com/users/sulu/followers","following_url":"https://api.github.com/users/sulu/following{/other_user}","gists_url":"https://api.github.com/users/sulu/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu/subscriptions","organizations_url":"https://api.github.com/users/sulu/orgs","repos_url":"https://api.github.com/users/sulu/repos","events_url":"https://api.github.com/users/sulu/events{/privacy}","received_events_url":"https://api.github.com/users/sulu/received_events","type":"Organization","site_admin":false},"repo":{"id":13678015,"name":"sulu","full_name":"sulu/sulu","owner":{"login":"sulu","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=3","gravatar_id":"","url":"https://api.github.com/users/sulu","html_url":"https://github.com/sulu","followers_url":"https://api.github.com/users/sulu/followers","following_url":"https://api.github.com/users/sulu/following{/other_user}","gists_url":"https://api.github.com/users/sulu/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu/subscriptions","organizations_url":"https://api.github.com/users/sulu/orgs","repos_url":"https://api.github.com/users/sulu/repos","events_url":"https://api.github.com/users/sulu/events{/privacy}","received_events_url":"https://api.github.com/users/sulu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sulu/sulu","description":"Sulu core bundles & components","fork":false,"url":"https://api.github.com/repos/sulu/sulu","forks_url":"https://api.github.com/repos/sulu/sulu/forks","keys_url":"https://api.github.com/repos/sulu/sulu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sulu/sulu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sulu/sulu/teams","hooks_url":"https://api.github.com/repos/sulu/sulu/hooks","issue_events_url":"https://api.github.com/repos/sulu/sulu/issues/events{/number}","events_url":"https://api.github.com/repos/sulu/sulu/events","assignees_url":"https://api.github.com/repos/sulu/sulu/assignees{/user}","branches_url":"https://api.github.com/repos/sulu/sulu/branches{/branch}","tags_url":"https://api.github.com/repos/sulu/sulu/tags","blobs_url":"https://api.github.com/repos/sulu/sulu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sulu/sulu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sulu/sulu/git/refs{/sha}","trees_url":"https://api.github.com/repos/sulu/sulu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sulu/sulu/statuses/{sha}","languages_url":"https://api.github.com/repos/sulu/sulu/languages","stargazers_url":"https://api.github.com/repos/sulu/sulu/stargazers","contributors_url":"https://api.github.com/repos/sulu/sulu/contributors","subscribers_url":"https://api.github.com/repos/sulu/sulu/subscribers","subscription_url":"https://api.github.com/repos/sulu/sulu/subscription","commits_url":"https://api.github.com/repos/sulu/sulu/commits{/sha}","git_commits_url":"https://api.github.com/repos/sulu/sulu/git/commits{/sha}","comments_url":"https://api.github.com/repos/sulu/sulu/comments{/number}","issue_comment_url":"https://api.github.com/repos/sulu/sulu/issues/comments{/number}","contents_url":"https://api.github.com/repos/sulu/sulu/contents/{+path}","compare_url":"https://api.github.com/repos/sulu/sulu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sulu/sulu/merges","archive_url":"https://api.github.com/repos/sulu/sulu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sulu/sulu/downloads","issues_url":"https://api.github.com/repos/sulu/sulu/issues{/number}","pulls_url":"https://api.github.com/repos/sulu/sulu/pulls{/number}","milestones_url":"https://api.github.com/repos/sulu/sulu/milestones{/number}","notifications_url":"https://api.github.com/repos/sulu/sulu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sulu/sulu/labels{/name}","releases_url":"https://api.github.com/repos/sulu/sulu/releases{/id}","deployments_url":"https://api.github.com/repos/sulu/sulu/deployments","created_at":"2013-10-18T12:57:02Z","updated_at":"2016-06-09T05:19:04Z","pushed_at":"2016-06-30T07:22:22Z","git_url":"git://github.com/sulu/sulu.git","ssh_url":"git@github.com:sulu/sulu.git","clone_url":"https://github.com/sulu/sulu.git","svn_url":"https://github.com/sulu/sulu","homepage":"sulu.io","size":81592,"stargazers_count":127,"watchers_count":127,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":407,"forks":44,"open_issues":407,"watchers":127,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sulu/sulu/pulls/2361"},"html":{"href":"https://github.com/sulu/sulu/pull/2361"},"issue":{"href":"https://api.github.com/repos/sulu/sulu/issues/2361"},"comments":{"href":"https://api.github.com/repos/sulu/sulu/issues/2361/comments"},"review_comments":{"href":"https://api.github.com/repos/sulu/sulu/pulls/2361/comments"},"review_comment":{"href":"https://api.github.com/repos/sulu/sulu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sulu/sulu/pulls/2361/commits"},"statuses":{"href":"https://api.github.com/repos/sulu/sulu/statuses/2d00582b8ea8cb0f89e858f2ece6dad1e8adfd6f"}}}}
{"actor":{"display_login":"danrot"}}