{"action":"created","issue":{"url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/4265","repository_url":"https://api.github.com/repos/ankidroid/Anki-Android","labels_url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/4265/labels{/name}","comments_url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/4265/comments","events_url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/4265/events","html_url":"https://github.com/ankidroid/Anki-Android/pull/4265","id":153268311,"number":4265,"title":"Whiteboard gesture fix","user":{"login":"timrae","id":2818274,"avatar_url":"https://avatars.githubusercontent.com/u/2818274?v=3","gravatar_id":"","url":"https://api.github.com/users/timrae","html_url":"https://github.com/timrae","followers_url":"https://api.github.com/users/timrae/followers","following_url":"https://api.github.com/users/timrae/following{/other_user}","gists_url":"https://api.github.com/users/timrae/gists{/gist_id}","starred_url":"https://api.github.com/users/timrae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timrae/subscriptions","organizations_url":"https://api.github.com/users/timrae/orgs","repos_url":"https://api.github.com/users/timrae/repos","events_url":"https://api.github.com/users/timrae/events{/privacy}","received_events_url":"https://api.github.com/users/timrae/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-05-05T16:23:10Z","updated_at":"2016-05-07T19:13:05Z","closed_at":"2016-05-06T10:08:17Z","pull_request":{"url":"https://api.github.com/repos/ankidroid/Anki-Android/pulls/4265","html_url":"https://github.com/ankidroid/Anki-Android/pull/4265","diff_url":"https://github.com/ankidroid/Anki-Android/pull/4265.diff","patch_url":"https://github.com/ankidroid/Anki-Android/pull/4265.patch"},"body":"I think this fixes #4259. Hopefully it hasn't introduced other errors elsewhere. I'm looking to get some feedback on how well it works and a few points below before merging.\r\n\r\nThe PR adds a 20dp margin to all edges of the whiteboard and gesture detector layers. The gesture detector layer already had this margin in the top and bottom, so I just kept the same number arbitrarily. The number seems to basically work, but according to my testing it may need to be slightly increased in some cases. \r\n\r\n0. I'm not sure if there's any standard for how many dp are taken up by these \"system swipe zones\"...? If there is an official number then we should use it, if not then I guess we could either dig into the source code, use trial and error, or change to a different and more reliable approach (not sure what that might be).\r\n\r\n0. Obviously the PR reduces the drawable area of the whiteboard. See the screenshot below; it's probably much more noticeable on a smaller screen. Maybe we should disable the margin when fullscreen is disabled?\r\n\r\n0. Perhaps with this change to the gesture touch layer, we could also re-enable swipe to open the navigation drawer, as this PR also effectively deals with the same issue. Again, 20dp might be too small for 100% reliable results.\r\n\r\n![whiteboard_gesture_limits](https://cloud.githubusercontent.com/assets/2818274/15049055/5f3e9992-1327-11e6-8555-d3400bc92290.png)"},"comment":{"url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/comments/217662544","html_url":"https://github.com/ankidroid/Anki-Android/pull/4265#issuecomment-217662544","issue_url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/4265","id":217662544,"user":{"login":"timrae","id":2818274,"avatar_url":"https://avatars.githubusercontent.com/u/2818274?v=3","gravatar_id":"","url":"https://api.github.com/users/timrae","html_url":"https://github.com/timrae","followers_url":"https://api.github.com/users/timrae/followers","following_url":"https://api.github.com/users/timrae/following{/other_user}","gists_url":"https://api.github.com/users/timrae/gists{/gist_id}","starred_url":"https://api.github.com/users/timrae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timrae/subscriptions","organizations_url":"https://api.github.com/users/timrae/orgs","repos_url":"https://api.github.com/users/timrae/repos","events_url":"https://api.github.com/users/timrae/events{/privacy}","received_events_url":"https://api.github.com/users/timrae/received_events","type":"User","site_admin":false},"created_at":"2016-05-07T19:13:05Z","updated_at":"2016-05-07T19:13:05Z","body":"I'm pretty sure it was working almost the same as it was now thanks to some hacks by the material drawer author, but with #3867."}}