{"action":"created","issue":{"url":"https://api.github.com/repos/openmrs/openmrs-core/issues/1887","repository_url":"https://api.github.com/repos/openmrs/openmrs-core","labels_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/1887/labels{/name}","comments_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/1887/comments","events_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/1887/events","html_url":"https://github.com/openmrs/openmrs-core/pull/1887","id":194407824,"number":1887,"title":"Trunck 4975 Making Family name as Optional","user":{"login":"fanyui","id":12346597,"avatar_url":"https://avatars.githubusercontent.com/u/12346597?v=3","gravatar_id":"","url":"https://api.github.com/users/fanyui","html_url":"https://github.com/fanyui","followers_url":"https://api.github.com/users/fanyui/followers","following_url":"https://api.github.com/users/fanyui/following{/other_user}","gists_url":"https://api.github.com/users/fanyui/gists{/gist_id}","starred_url":"https://api.github.com/users/fanyui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanyui/subscriptions","organizations_url":"https://api.github.com/users/fanyui/orgs","repos_url":"https://api.github.com/users/fanyui/repos","events_url":"https://api.github.com/users/fanyui/events{/privacy}","received_events_url":"https://api.github.com/users/fanyui/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-12-08T18:22:02Z","updated_at":"2016-12-08T20:53:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/1887","html_url":"https://github.com/openmrs/openmrs-core/pull/1887","diff_url":"https://github.com/openmrs/openmrs-core/pull/1887.diff","patch_url":"https://github.com/openmrs/openmrs-core/pull/1887.patch"},"body":"<!--- Provide PR Title above as: 'TRUNK-JiraIssueNumber JiraIssueTitle' -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nI Removed the validation carried out on familyName\r\nand also change the message.properties file to give a message that best resemble the error.\r\nI also remove the tests that are carried out on the patientName when you compile the project\r\n## Related Issue\r\n<!--- This project only accepts pull requests related to open issues -->\r\n<!--- If suggesting a new feature or change, please discuss it in an issue\r\nfirst -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to\r\nreproduce -->\r\n<!--- Please link to the issue here: -->\r\nsee https://issues.openmrs.org/browse/TRUNK-4975\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that\r\napply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to\r\nhelp! -->\r\n- [ ] My pull request only contains one single commit.\r\n- [x] My pull request is based on the latest master branch\r\n  `git pull --rebase upstream master`.\r\n- [ ] I ran `mvn clean package` right before creating this pull request and\r\n  added all formatting changes to my commit.\r\n- [x] My code follows the code style of this project.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/openmrs/openmrs-core/issues/comments/265852350","html_url":"https://github.com/openmrs/openmrs-core/pull/1887#issuecomment-265852350","issue_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/1887","id":265852350,"user":{"login":"fanyui","id":12346597,"avatar_url":"https://avatars.githubusercontent.com/u/12346597?v=3","gravatar_id":"","url":"https://api.github.com/users/fanyui","html_url":"https://github.com/fanyui","followers_url":"https://api.github.com/users/fanyui/followers","following_url":"https://api.github.com/users/fanyui/following{/other_user}","gists_url":"https://api.github.com/users/fanyui/gists{/gist_id}","starred_url":"https://api.github.com/users/fanyui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanyui/subscriptions","organizations_url":"https://api.github.com/users/fanyui/orgs","repos_url":"https://api.github.com/users/fanyui/repos","events_url":"https://api.github.com/users/fanyui/events{/privacy}","received_events_url":"https://api.github.com/users/fanyui/received_events","type":"User","site_admin":false},"created_at":"2016-12-08T20:53:45Z","updated_at":"2016-12-08T20:53:45Z","body":"@dkayiwa I have not noticed an error as it builds without errors or maybe\nam looking for the errors at the wrong place. I will appreciate  pointers\non how to find the said error.\n\nOn Thu, Dec 8, 2016 at 7:23 PM, dkayiwa <notifications@github.com> wrote:\n\n> @fanyui <https://github.com/fanyui> did you notice the travis failure?\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/openmrs/openmrs-core/pull/1887#issuecomment-265829933>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ALxk5UqfliP_tme_P4_M4Q0VD8LnZ2TLks5rGFkVgaJpZM4LIIMc>\n> .\n>\n"}}
{"actor":{"display_login":"fanyui"}}