{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/pulls/comments/88972359","pull_request_review_id":9526890,"id":88972359,"diff_hunk":"@@ -192,6 +194,31 @@ public String getInstanceCapStr() {\n         }\n     }\n \n+    public void setIdleMinutes(int i) {\n+        this.idleMinutes = i;\n+    }\n+\n+    public int getIdleMinutes() {\n+        return idleMinutes;\n+    }\n+\n+    @DataBoundSetter\n+    public void setIdleMinutesStr(String idleMinutes) {\n+        if (\"\".equals(idleMinutes)) {","path":"src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodTemplate.java","position":23,"original_position":23,"commit_id":"b7fe12c2bcb1ba9ad459933f6e3882b66b5f8749","original_commit_id":"b7fe12c2bcb1ba9ad459933f6e3882b66b5f8749","user":{"login":"jeffersongirao","id":70795,"avatar_url":"https://avatars.githubusercontent.com/u/70795?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffersongirao","html_url":"https://github.com/jeffersongirao","followers_url":"https://api.github.com/users/jeffersongirao/followers","following_url":"https://api.github.com/users/jeffersongirao/following{/other_user}","gists_url":"https://api.github.com/users/jeffersongirao/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffersongirao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffersongirao/subscriptions","organizations_url":"https://api.github.com/users/jeffersongirao/orgs","repos_url":"https://api.github.com/users/jeffersongirao/repos","events_url":"https://api.github.com/users/jeffersongirao/events{/privacy}","received_events_url":"https://api.github.com/users/jeffersongirao/received_events","type":"User","site_admin":false},"body":"Is it ok to introduce a dependency here? I was just trying to be consistent with what is implemented for setInstanceCapStr.","created_at":"2016-11-21T19:42:23Z","updated_at":"2016-11-21T19:42:23Z","html_url":"https://github.com/jenkinsci/kubernetes-plugin/pull/91#discussion_r88972359","pull_request_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/pulls/91","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/pulls/comments/88972359"},"html":{"href":"https://github.com/jenkinsci/kubernetes-plugin/pull/91#discussion_r88972359"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/pulls/91"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/pulls/91","id":93623923,"html_url":"https://github.com/jenkinsci/kubernetes-plugin/pull/91","diff_url":"https://github.com/jenkinsci/kubernetes-plugin/pull/91.diff","patch_url":"https://github.com/jenkinsci/kubernetes-plugin/pull/91.patch","issue_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/issues/91","number":91,"state":"open","locked":false,"title":"Adding basic retention","user":{"login":"jeffersongirao","id":70795,"avatar_url":"https://avatars.githubusercontent.com/u/70795?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffersongirao","html_url":"https://github.com/jeffersongirao","followers_url":"https://api.github.com/users/jeffersongirao/followers","following_url":"https://api.github.com/users/jeffersongirao/following{/other_user}","gists_url":"https://api.github.com/users/jeffersongirao/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffersongirao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffersongirao/subscriptions","organizations_url":"https://api.github.com/users/jeffersongirao/orgs","repos_url":"https://api.github.com/users/jeffersongirao/repos","events_url":"https://api.github.com/users/jeffersongirao/events{/privacy}","received_events_url":"https://api.github.com/users/jeffersongirao/received_events","type":"User","site_admin":false},"body":"* The idea is to re-use slaves after successful builds, the slave is terminated after being idle for the time defined in idleMinutes. That is useful for builds that rely heavily on cached data for \"speed\".","created_at":"2016-11-14T18:48:31Z","updated_at":"2016-11-21T19:42:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9aaa2f3d4526525f6b78288fa34e21d143616ebc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/pulls/91/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/pulls/91/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/issues/91/comments","statuses_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/statuses/b7fe12c2bcb1ba9ad459933f6e3882b66b5f8749","head":{"label":"jeffersongirao:retention","ref":"retention","sha":"b7fe12c2bcb1ba9ad459933f6e3882b66b5f8749","user":{"login":"jeffersongirao","id":70795,"avatar_url":"https://avatars.githubusercontent.com/u/70795?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffersongirao","html_url":"https://github.com/jeffersongirao","followers_url":"https://api.github.com/users/jeffersongirao/followers","following_url":"https://api.github.com/users/jeffersongirao/following{/other_user}","gists_url":"https://api.github.com/users/jeffersongirao/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffersongirao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffersongirao/subscriptions","organizations_url":"https://api.github.com/users/jeffersongirao/orgs","repos_url":"https://api.github.com/users/jeffersongirao/repos","events_url":"https://api.github.com/users/jeffersongirao/events{/privacy}","received_events_url":"https://api.github.com/users/jeffersongirao/received_events","type":"User","site_admin":false},"repo":{"id":69798271,"name":"kubernetes-plugin","full_name":"jeffersongirao/kubernetes-plugin","owner":{"login":"jeffersongirao","id":70795,"avatar_url":"https://avatars.githubusercontent.com/u/70795?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffersongirao","html_url":"https://github.com/jeffersongirao","followers_url":"https://api.github.com/users/jeffersongirao/followers","following_url":"https://api.github.com/users/jeffersongirao/following{/other_user}","gists_url":"https://api.github.com/users/jeffersongirao/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffersongirao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffersongirao/subscriptions","organizations_url":"https://api.github.com/users/jeffersongirao/orgs","repos_url":"https://api.github.com/users/jeffersongirao/repos","events_url":"https://api.github.com/users/jeffersongirao/events{/privacy}","received_events_url":"https://api.github.com/users/jeffersongirao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeffersongirao/kubernetes-plugin","description":"Jenkins plugin to run dynamic slaves in a Kubernetes/Docker environment","fork":true,"url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin","forks_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/forks","keys_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/teams","hooks_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/hooks","issue_events_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/events","assignees_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/tags","blobs_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/languages","stargazers_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/stargazers","contributors_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/contributors","subscribers_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/subscribers","subscription_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/subscription","commits_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/merges","archive_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/downloads","issues_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jeffersongirao/kubernetes-plugin/deployments","created_at":"2016-10-02T13:20:48Z","updated_at":"2016-10-02T13:20:50Z","pushed_at":"2016-11-21T19:14:31Z","git_url":"git://github.com/jeffersongirao/kubernetes-plugin.git","ssh_url":"git@github.com:jeffersongirao/kubernetes-plugin.git","clone_url":"https://github.com/jeffersongirao/kubernetes-plugin.git","svn_url":"https://github.com/jeffersongirao/kubernetes-plugin","homepage":null,"size":637,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"921d44d9140238af1e6ae5faa482e1478bdf4946","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":30860673,"name":"kubernetes-plugin","full_name":"jenkinsci/kubernetes-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/kubernetes-plugin","description":"Jenkins plugin to run dynamic slaves in a Kubernetes/Docker environment","fork":true,"url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin","forks_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/deployments","created_at":"2015-02-16T09:02:22Z","updated_at":"2016-11-19T18:23:18Z","pushed_at":"2016-11-21T19:06:00Z","git_url":"git://github.com/jenkinsci/kubernetes-plugin.git","ssh_url":"git@github.com:jenkinsci/kubernetes-plugin.git","clone_url":"https://github.com/jenkinsci/kubernetes-plugin.git","svn_url":"https://github.com/jenkinsci/kubernetes-plugin","homepage":null,"size":808,"stargazers_count":111,"watchers_count":111,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"open_issues_count":3,"forks":86,"open_issues":3,"watchers":111,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/pulls/91"},"html":{"href":"https://github.com/jenkinsci/kubernetes-plugin/pull/91"},"issue":{"href":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/issues/91"},"comments":{"href":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/kubernetes-plugin/statuses/b7fe12c2bcb1ba9ad459933f6e3882b66b5f8749"}}}}
{"actor":{"display_login":"jeffersongirao"}}