{"action":"closed","number":92,"pull_request":{"url":"https://api.github.com/repos/reactjs/react-autocomplete/pulls/92","id":65435406,"html_url":"https://github.com/reactjs/react-autocomplete/pull/92","diff_url":"https://github.com/reactjs/react-autocomplete/pull/92.diff","patch_url":"https://github.com/reactjs/react-autocomplete/pull/92.patch","issue_url":"https://api.github.com/repos/reactjs/react-autocomplete/issues/92","number":92,"state":"closed","locked":false,"title":"[changed] Prevent `Return` in menu from submitting surrounding form","user":{"login":"CMTegner","id":820552,"avatar_url":"https://avatars.githubusercontent.com/u/820552?v=3","gravatar_id":"","url":"https://api.github.com/users/CMTegner","html_url":"https://github.com/CMTegner","followers_url":"https://api.github.com/users/CMTegner/followers","following_url":"https://api.github.com/users/CMTegner/following{/other_user}","gists_url":"https://api.github.com/users/CMTegner/gists{/gist_id}","starred_url":"https://api.github.com/users/CMTegner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMTegner/subscriptions","organizations_url":"https://api.github.com/users/CMTegner/orgs","repos_url":"https://api.github.com/users/CMTegner/repos","events_url":"https://api.github.com/users/CMTegner/events{/privacy}","received_events_url":"https://api.github.com/users/CMTegner/received_events","type":"User","site_admin":false},"body":"The default behaviour of hitting `Return` in a `<input type=text>` is to submit\r\nthe immediate surrounding form. I would hazard a guess that this isn't the\r\nexpected result when using `Return` to select an item in the autocomplete\r\nmenu. Since we don't expose the event object to the consumer via `onSelect` we\r\nneed to make sure we're making the most sensible choice by default.\r\n\r\nHitting `Return` a second time (after the menu has closed itself) will\r\nresult in the default, expected behaviour.","created_at":"2016-04-06T09:30:50Z","updated_at":"2016-06-05T17:29:32Z","closed_at":"2016-06-05T17:29:32Z","merged_at":"2016-06-05T17:29:32Z","merge_commit_sha":"705ee040efbbdf4250107017a3f60b0c3e5abbdf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/reactjs/react-autocomplete/pulls/92/commits","review_comments_url":"https://api.github.com/repos/reactjs/react-autocomplete/pulls/92/comments","review_comment_url":"https://api.github.com/repos/reactjs/react-autocomplete/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactjs/react-autocomplete/issues/92/comments","statuses_url":"https://api.github.com/repos/reactjs/react-autocomplete/statuses/d09968dbcbce57b02c4a86b2aa16c07586b332d1","head":{"label":"CMTegner:prevent-submit-on-select-item","ref":"prevent-submit-on-select-item","sha":"d09968dbcbce57b02c4a86b2aa16c07586b332d1","user":{"login":"CMTegner","id":820552,"avatar_url":"https://avatars.githubusercontent.com/u/820552?v=3","gravatar_id":"","url":"https://api.github.com/users/CMTegner","html_url":"https://github.com/CMTegner","followers_url":"https://api.github.com/users/CMTegner/followers","following_url":"https://api.github.com/users/CMTegner/following{/other_user}","gists_url":"https://api.github.com/users/CMTegner/gists{/gist_id}","starred_url":"https://api.github.com/users/CMTegner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMTegner/subscriptions","organizations_url":"https://api.github.com/users/CMTegner/orgs","repos_url":"https://api.github.com/users/CMTegner/repos","events_url":"https://api.github.com/users/CMTegner/events{/privacy}","received_events_url":"https://api.github.com/users/CMTegner/received_events","type":"User","site_admin":false},"repo":{"id":45457760,"name":"react-autocomplete","full_name":"CMTegner/react-autocomplete","owner":{"login":"CMTegner","id":820552,"avatar_url":"https://avatars.githubusercontent.com/u/820552?v=3","gravatar_id":"","url":"https://api.github.com/users/CMTegner","html_url":"https://github.com/CMTegner","followers_url":"https://api.github.com/users/CMTegner/followers","following_url":"https://api.github.com/users/CMTegner/following{/other_user}","gists_url":"https://api.github.com/users/CMTegner/gists{/gist_id}","starred_url":"https://api.github.com/users/CMTegner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMTegner/subscriptions","organizations_url":"https://api.github.com/users/CMTegner/orgs","repos_url":"https://api.github.com/users/CMTegner/repos","events_url":"https://api.github.com/users/CMTegner/events{/privacy}","received_events_url":"https://api.github.com/users/CMTegner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CMTegner/react-autocomplete","description":"WAI-ARIA compliant React autocomplete (combobox) component","fork":true,"url":"https://api.github.com/repos/CMTegner/react-autocomplete","forks_url":"https://api.github.com/repos/CMTegner/react-autocomplete/forks","keys_url":"https://api.github.com/repos/CMTegner/react-autocomplete/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CMTegner/react-autocomplete/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CMTegner/react-autocomplete/teams","hooks_url":"https://api.github.com/repos/CMTegner/react-autocomplete/hooks","issue_events_url":"https://api.github.com/repos/CMTegner/react-autocomplete/issues/events{/number}","events_url":"https://api.github.com/repos/CMTegner/react-autocomplete/events","assignees_url":"https://api.github.com/repos/CMTegner/react-autocomplete/assignees{/user}","branches_url":"https://api.github.com/repos/CMTegner/react-autocomplete/branches{/branch}","tags_url":"https://api.github.com/repos/CMTegner/react-autocomplete/tags","blobs_url":"https://api.github.com/repos/CMTegner/react-autocomplete/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CMTegner/react-autocomplete/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CMTegner/react-autocomplete/git/refs{/sha}","trees_url":"https://api.github.com/repos/CMTegner/react-autocomplete/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CMTegner/react-autocomplete/statuses/{sha}","languages_url":"https://api.github.com/repos/CMTegner/react-autocomplete/languages","stargazers_url":"https://api.github.com/repos/CMTegner/react-autocomplete/stargazers","contributors_url":"https://api.github.com/repos/CMTegner/react-autocomplete/contributors","subscribers_url":"https://api.github.com/repos/CMTegner/react-autocomplete/subscribers","subscription_url":"https://api.github.com/repos/CMTegner/react-autocomplete/subscription","commits_url":"https://api.github.com/repos/CMTegner/react-autocomplete/commits{/sha}","git_commits_url":"https://api.github.com/repos/CMTegner/react-autocomplete/git/commits{/sha}","comments_url":"https://api.github.com/repos/CMTegner/react-autocomplete/comments{/number}","issue_comment_url":"https://api.github.com/repos/CMTegner/react-autocomplete/issues/comments{/number}","contents_url":"https://api.github.com/repos/CMTegner/react-autocomplete/contents/{+path}","compare_url":"https://api.github.com/repos/CMTegner/react-autocomplete/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CMTegner/react-autocomplete/merges","archive_url":"https://api.github.com/repos/CMTegner/react-autocomplete/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CMTegner/react-autocomplete/downloads","issues_url":"https://api.github.com/repos/CMTegner/react-autocomplete/issues{/number}","pulls_url":"https://api.github.com/repos/CMTegner/react-autocomplete/pulls{/number}","milestones_url":"https://api.github.com/repos/CMTegner/react-autocomplete/milestones{/number}","notifications_url":"https://api.github.com/repos/CMTegner/react-autocomplete/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CMTegner/react-autocomplete/labels{/name}","releases_url":"https://api.github.com/repos/CMTegner/react-autocomplete/releases{/id}","deployments_url":"https://api.github.com/repos/CMTegner/react-autocomplete/deployments","created_at":"2015-11-03T10:05:06Z","updated_at":"2016-02-12T00:08:12Z","pushed_at":"2016-06-04T21:02:37Z","git_url":"git://github.com/CMTegner/react-autocomplete.git","ssh_url":"git@github.com:CMTegner/react-autocomplete.git","clone_url":"https://github.com/CMTegner/react-autocomplete.git","svn_url":"https://github.com/CMTegner/react-autocomplete","homepage":"","size":2797,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reactjs:master","ref":"master","sha":"dafac97715935741cb4f80a8f6a1ff341e6b7ff6","user":{"login":"reactjs","id":6412038,"avatar_url":"https://avatars.githubusercontent.com/u/6412038?v=3","gravatar_id":"","url":"https://api.github.com/users/reactjs","html_url":"https://github.com/reactjs","followers_url":"https://api.github.com/users/reactjs/followers","following_url":"https://api.github.com/users/reactjs/following{/other_user}","gists_url":"https://api.github.com/users/reactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/reactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactjs/subscriptions","organizations_url":"https://api.github.com/users/reactjs/orgs","repos_url":"https://api.github.com/users/reactjs/repos","events_url":"https://api.github.com/users/reactjs/events{/privacy}","received_events_url":"https://api.github.com/users/reactjs/received_events","type":"Organization","site_admin":false},"repo":{"id":20636942,"name":"react-autocomplete","full_name":"reactjs/react-autocomplete","owner":{"login":"reactjs","id":6412038,"avatar_url":"https://avatars.githubusercontent.com/u/6412038?v=3","gravatar_id":"","url":"https://api.github.com/users/reactjs","html_url":"https://github.com/reactjs","followers_url":"https://api.github.com/users/reactjs/followers","following_url":"https://api.github.com/users/reactjs/following{/other_user}","gists_url":"https://api.github.com/users/reactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/reactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactjs/subscriptions","organizations_url":"https://api.github.com/users/reactjs/orgs","repos_url":"https://api.github.com/users/reactjs/repos","events_url":"https://api.github.com/users/reactjs/events{/privacy}","received_events_url":"https://api.github.com/users/reactjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reactjs/react-autocomplete","description":"WAI-ARIA compliant React autocomplete (combobox) component","fork":false,"url":"https://api.github.com/repos/reactjs/react-autocomplete","forks_url":"https://api.github.com/repos/reactjs/react-autocomplete/forks","keys_url":"https://api.github.com/repos/reactjs/react-autocomplete/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactjs/react-autocomplete/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactjs/react-autocomplete/teams","hooks_url":"https://api.github.com/repos/reactjs/react-autocomplete/hooks","issue_events_url":"https://api.github.com/repos/reactjs/react-autocomplete/issues/events{/number}","events_url":"https://api.github.com/repos/reactjs/react-autocomplete/events","assignees_url":"https://api.github.com/repos/reactjs/react-autocomplete/assignees{/user}","branches_url":"https://api.github.com/repos/reactjs/react-autocomplete/branches{/branch}","tags_url":"https://api.github.com/repos/reactjs/react-autocomplete/tags","blobs_url":"https://api.github.com/repos/reactjs/react-autocomplete/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactjs/react-autocomplete/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactjs/react-autocomplete/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactjs/react-autocomplete/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactjs/react-autocomplete/statuses/{sha}","languages_url":"https://api.github.com/repos/reactjs/react-autocomplete/languages","stargazers_url":"https://api.github.com/repos/reactjs/react-autocomplete/stargazers","contributors_url":"https://api.github.com/repos/reactjs/react-autocomplete/contributors","subscribers_url":"https://api.github.com/repos/reactjs/react-autocomplete/subscribers","subscription_url":"https://api.github.com/repos/reactjs/react-autocomplete/subscription","commits_url":"https://api.github.com/repos/reactjs/react-autocomplete/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactjs/react-autocomplete/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactjs/react-autocomplete/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactjs/react-autocomplete/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactjs/react-autocomplete/contents/{+path}","compare_url":"https://api.github.com/repos/reactjs/react-autocomplete/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactjs/react-autocomplete/merges","archive_url":"https://api.github.com/repos/reactjs/react-autocomplete/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactjs/react-autocomplete/downloads","issues_url":"https://api.github.com/repos/reactjs/react-autocomplete/issues{/number}","pulls_url":"https://api.github.com/repos/reactjs/react-autocomplete/pulls{/number}","milestones_url":"https://api.github.com/repos/reactjs/react-autocomplete/milestones{/number}","notifications_url":"https://api.github.com/repos/reactjs/react-autocomplete/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactjs/react-autocomplete/labels{/name}","releases_url":"https://api.github.com/repos/reactjs/react-autocomplete/releases{/id}","deployments_url":"https://api.github.com/repos/reactjs/react-autocomplete/deployments","created_at":"2014-06-09T06:38:01Z","updated_at":"2016-06-05T13:59:12Z","pushed_at":"2016-06-05T17:29:32Z","git_url":"git://github.com/reactjs/react-autocomplete.git","ssh_url":"git@github.com:reactjs/react-autocomplete.git","clone_url":"https://github.com/reactjs/react-autocomplete.git","svn_url":"https://github.com/reactjs/react-autocomplete","homepage":"","size":3013,"stargazers_count":601,"watchers_count":601,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":212,"mirror_url":null,"open_issues_count":60,"forks":212,"open_issues":60,"watchers":601,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactjs/react-autocomplete/pulls/92"},"html":{"href":"https://github.com/reactjs/react-autocomplete/pull/92"},"issue":{"href":"https://api.github.com/repos/reactjs/react-autocomplete/issues/92"},"comments":{"href":"https://api.github.com/repos/reactjs/react-autocomplete/issues/92/comments"},"review_comments":{"href":"https://api.github.com/repos/reactjs/react-autocomplete/pulls/92/comments"},"review_comment":{"href":"https://api.github.com/repos/reactjs/react-autocomplete/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactjs/react-autocomplete/pulls/92/commits"},"statuses":{"href":"https://api.github.com/repos/reactjs/react-autocomplete/statuses/d09968dbcbce57b02c4a86b2aa16c07586b332d1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sprjr","id":682566,"avatar_url":"https://avatars.githubusercontent.com/u/682566?v=3","gravatar_id":"","url":"https://api.github.com/users/sprjr","html_url":"https://github.com/sprjr","followers_url":"https://api.github.com/users/sprjr/followers","following_url":"https://api.github.com/users/sprjr/following{/other_user}","gists_url":"https://api.github.com/users/sprjr/gists{/gist_id}","starred_url":"https://api.github.com/users/sprjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sprjr/subscriptions","organizations_url":"https://api.github.com/users/sprjr/orgs","repos_url":"https://api.github.com/users/sprjr/repos","events_url":"https://api.github.com/users/sprjr/events{/privacy}","received_events_url":"https://api.github.com/users/sprjr/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":4,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"sprjr"}}