{"action":"created","comment":{"url":"https://api.github.com/repos/astropy/astropy/pulls/comments/63656518","id":63656518,"diff_hunk":"@@ -124,9 +123,9 @@ def astrometric_to_astrometric(from_astrometric_coord, to_astrometric_frame):\n         # Otherwise, the transform occurs just by setting the new origin.\n         return to_astrometric_frame.realize_frame(from_astrometric_coord.cartesian)\n \n-    @frame_transform_graph.transform(DynamicMatrixTransform, framecls, Astrometric)\n+    @frame_transform_graph.transform(DynamicMatrixTransform, framecls, _Astrometric)\n     def icrs_to_astrometric(reference_frame, astrometric_frame):","path":"astropy/coordinates/builtin_frames/astrometric.py","position":65,"original_position":65,"commit_id":"ec76e729e814eacf6735b6164df2edbf35473b24","original_commit_id":"ec76e729e814eacf6735b6164df2edbf35473b24","user":{"login":"cdeil","id":852409,"avatar_url":"https://avatars.githubusercontent.com/u/852409?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"body":"Change `icrs_to_astrometric` to `reference_to_astrometric` here?\r\nThis was a suggestion @taldcroft made in the other issue and I also found this confusing to name this `icrs` when it's not specific to icrs.","created_at":"2016-05-18T07:23:30Z","updated_at":"2016-05-18T07:23:30Z","html_url":"https://github.com/astropy/astropy/pull/4941#discussion_r63656518","pull_request_url":"https://api.github.com/repos/astropy/astropy/pulls/4941","_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments/63656518"},"html":{"href":"https://github.com/astropy/astropy/pull/4941#discussion_r63656518"},"pull_request":{"href":"https://api.github.com/repos/astropy/astropy/pulls/4941"}}},"pull_request":{"url":"https://api.github.com/repos/astropy/astropy/pulls/4941","id":70449068,"html_url":"https://github.com/astropy/astropy/pull/4941","diff_url":"https://github.com/astropy/astropy/pull/4941.diff","patch_url":"https://github.com/astropy/astropy/pull/4941.patch","issue_url":"https://api.github.com/repos/astropy/astropy/issues/4941","number":4941,"state":"open","locked":false,"title":"Make AstrometricFrame behave like other coordinate frames.","user":{"login":"alexrudy","id":427688,"avatar_url":"https://avatars.githubusercontent.com/u/427688?v=3","gravatar_id":"","url":"https://api.github.com/users/alexrudy","html_url":"https://github.com/alexrudy","followers_url":"https://api.github.com/users/alexrudy/followers","following_url":"https://api.github.com/users/alexrudy/following{/other_user}","gists_url":"https://api.github.com/users/alexrudy/gists{/gist_id}","starred_url":"https://api.github.com/users/alexrudy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexrudy/subscriptions","organizations_url":"https://api.github.com/users/alexrudy/orgs","repos_url":"https://api.github.com/users/alexrudy/repos","events_url":"https://api.github.com/users/alexrudy/events{/privacy}","received_events_url":"https://api.github.com/users/alexrudy/received_events","type":"User","site_admin":false},"body":"This is a stub trying to make the AstrometricFrame behave like @taldcroft suggested in #4931.\r\n\r\nSome things are still a little bit wonky:\r\n\r\n- Can CoordinateFrameAttribute use a variable frame, without having to redefine the attribute each time?\r\n- Is it possible to switch the inheritance order of coordinate frame so that AstrometricFrame-specific methods etc. appear first?\r\n- Should AstrometricFrame always be called AstrometricFrame, or should it incorporate the name of the base frame class?\r\n\r\nAlso, still needs some minor doc fixes and a changelog entry.","created_at":"2016-05-17T23:44:23Z","updated_at":"2016-05-18T07:23:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"560afba2f9ea7adac22659185cacc53b73f4d5e3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/astropy/astropy/pulls/4941/commits","review_comments_url":"https://api.github.com/repos/astropy/astropy/pulls/4941/comments","review_comment_url":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/4941/comments","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/ec76e729e814eacf6735b6164df2edbf35473b24","head":{"label":"alexrudy:astrometric-magic","ref":"astrometric-magic","sha":"ec76e729e814eacf6735b6164df2edbf35473b24","user":{"login":"alexrudy","id":427688,"avatar_url":"https://avatars.githubusercontent.com/u/427688?v=3","gravatar_id":"","url":"https://api.github.com/users/alexrudy","html_url":"https://github.com/alexrudy","followers_url":"https://api.github.com/users/alexrudy/followers","following_url":"https://api.github.com/users/alexrudy/following{/other_user}","gists_url":"https://api.github.com/users/alexrudy/gists{/gist_id}","starred_url":"https://api.github.com/users/alexrudy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexrudy/subscriptions","organizations_url":"https://api.github.com/users/alexrudy/orgs","repos_url":"https://api.github.com/users/alexrudy/repos","events_url":"https://api.github.com/users/alexrudy/events{/privacy}","received_events_url":"https://api.github.com/users/alexrudy/received_events","type":"User","site_admin":false},"repo":{"id":8404941,"name":"astropy","full_name":"alexrudy/astropy","owner":{"login":"alexrudy","id":427688,"avatar_url":"https://avatars.githubusercontent.com/u/427688?v=3","gravatar_id":"","url":"https://api.github.com/users/alexrudy","html_url":"https://github.com/alexrudy","followers_url":"https://api.github.com/users/alexrudy/followers","following_url":"https://api.github.com/users/alexrudy/following{/other_user}","gists_url":"https://api.github.com/users/alexrudy/gists{/gist_id}","starred_url":"https://api.github.com/users/alexrudy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexrudy/subscriptions","organizations_url":"https://api.github.com/users/alexrudy/orgs","repos_url":"https://api.github.com/users/alexrudy/repos","events_url":"https://api.github.com/users/alexrudy/events{/privacy}","received_events_url":"https://api.github.com/users/alexrudy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexrudy/astropy","description":"Main AstroPy repository","fork":true,"url":"https://api.github.com/repos/alexrudy/astropy","forks_url":"https://api.github.com/repos/alexrudy/astropy/forks","keys_url":"https://api.github.com/repos/alexrudy/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexrudy/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexrudy/astropy/teams","hooks_url":"https://api.github.com/repos/alexrudy/astropy/hooks","issue_events_url":"https://api.github.com/repos/alexrudy/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/alexrudy/astropy/events","assignees_url":"https://api.github.com/repos/alexrudy/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/alexrudy/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/alexrudy/astropy/tags","blobs_url":"https://api.github.com/repos/alexrudy/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexrudy/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexrudy/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexrudy/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexrudy/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/alexrudy/astropy/languages","stargazers_url":"https://api.github.com/repos/alexrudy/astropy/stargazers","contributors_url":"https://api.github.com/repos/alexrudy/astropy/contributors","subscribers_url":"https://api.github.com/repos/alexrudy/astropy/subscribers","subscription_url":"https://api.github.com/repos/alexrudy/astropy/subscription","commits_url":"https://api.github.com/repos/alexrudy/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexrudy/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexrudy/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexrudy/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexrudy/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/alexrudy/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexrudy/astropy/merges","archive_url":"https://api.github.com/repos/alexrudy/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexrudy/astropy/downloads","issues_url":"https://api.github.com/repos/alexrudy/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/alexrudy/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/alexrudy/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/alexrudy/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexrudy/astropy/labels{/name}","releases_url":"https://api.github.com/repos/alexrudy/astropy/releases{/id}","deployments_url":"https://api.github.com/repos/alexrudy/astropy/deployments","created_at":"2013-02-25T08:07:33Z","updated_at":"2014-09-08T21:18:31Z","pushed_at":"2016-05-18T00:44:37Z","git_url":"git://github.com/alexrudy/astropy.git","ssh_url":"git@github.com:alexrudy/astropy.git","clone_url":"https://github.com/alexrudy/astropy.git","svn_url":"https://github.com/alexrudy/astropy","homepage":"astropy.org","size":46540,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"astropy:master","ref":"master","sha":"1862f243b2f7a6dc0accf44a15f0ba7fb93069df","user":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?v=3","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":2081289,"name":"astropy","full_name":"astropy/astropy","owner":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?v=3","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astropy/astropy","description":"Repository for the Astropy core package","fork":false,"url":"https://api.github.com/repos/astropy/astropy","forks_url":"https://api.github.com/repos/astropy/astropy/forks","keys_url":"https://api.github.com/repos/astropy/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astropy/teams","hooks_url":"https://api.github.com/repos/astropy/astropy/hooks","issue_events_url":"https://api.github.com/repos/astropy/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astropy/events","assignees_url":"https://api.github.com/repos/astropy/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astropy/tags","blobs_url":"https://api.github.com/repos/astropy/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astropy/languages","stargazers_url":"https://api.github.com/repos/astropy/astropy/stargazers","contributors_url":"https://api.github.com/repos/astropy/astropy/contributors","subscribers_url":"https://api.github.com/repos/astropy/astropy/subscribers","subscription_url":"https://api.github.com/repos/astropy/astropy/subscription","commits_url":"https://api.github.com/repos/astropy/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astropy/merges","archive_url":"https://api.github.com/repos/astropy/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astropy/downloads","issues_url":"https://api.github.com/repos/astropy/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astropy/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astropy/releases{/id}","deployments_url":"https://api.github.com/repos/astropy/astropy/deployments","created_at":"2011-07-21T01:33:49Z","updated_at":"2016-05-16T15:34:17Z","pushed_at":"2016-05-18T02:10:48Z","git_url":"git://github.com/astropy/astropy.git","ssh_url":"git@github.com:astropy/astropy.git","clone_url":"https://github.com/astropy/astropy.git","svn_url":"https://github.com/astropy/astropy","homepage":"www.astropy.org","size":65373,"stargazers_count":854,"watchers_count":854,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":545,"mirror_url":null,"open_issues_count":708,"forks":545,"open_issues":708,"watchers":854,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/4941"},"html":{"href":"https://github.com/astropy/astropy/pull/4941"},"issue":{"href":"https://api.github.com/repos/astropy/astropy/issues/4941"},"comments":{"href":"https://api.github.com/repos/astropy/astropy/issues/4941/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astropy/pulls/4941/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/astropy/pulls/4941/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astropy/statuses/ec76e729e814eacf6735b6164df2edbf35473b24"}}}}