{"action":"created","issue":{"url":"https://api.github.com/repos/inuitcss/inuitcss/issues/112","repository_url":"https://api.github.com/repos/inuitcss/inuitcss","labels_url":"https://api.github.com/repos/inuitcss/inuitcss/issues/112/labels{/name}","comments_url":"https://api.github.com/repos/inuitcss/inuitcss/issues/112/comments","events_url":"https://api.github.com/repos/inuitcss/inuitcss/issues/112/events","html_url":"https://github.com/inuitcss/inuitcss/issues/112","id":168516589,"number":112,"title":"[generic.shared] Use rem units?","user":{"login":"johannes-r","id":4764281,"avatar_url":"https://avatars.githubusercontent.com/u/4764281?v=3","gravatar_id":"","url":"https://api.github.com/users/johannes-r","html_url":"https://github.com/johannes-r","followers_url":"https://api.github.com/users/johannes-r/followers","following_url":"https://api.github.com/users/johannes-r/following{/other_user}","gists_url":"https://api.github.com/users/johannes-r/gists{/gist_id}","starred_url":"https://api.github.com/users/johannes-r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johannes-r/subscriptions","organizations_url":"https://api.github.com/users/johannes-r/orgs","repos_url":"https://api.github.com/users/johannes-r/repos","events_url":"https://api.github.com/users/johannes-r/events{/privacy}","received_events_url":"https://api.github.com/users/johannes-r/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/inuitcss/inuitcss/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/inuitcss/inuitcss/milestones/1","html_url":"https://github.com/inuitcss/inuitcss/milestones/6.0.0-beta.3","labels_url":"https://api.github.com/repos/inuitcss/inuitcss/milestones/1/labels","id":1920162,"number":1,"title":"6.0.0-beta.3","description":null,"creator":{"login":"csshugs","id":4582857,"avatar_url":"https://avatars.githubusercontent.com/u/4582857?v=3","gravatar_id":"","url":"https://api.github.com/users/csshugs","html_url":"https://github.com/csshugs","followers_url":"https://api.github.com/users/csshugs/followers","following_url":"https://api.github.com/users/csshugs/following{/other_user}","gists_url":"https://api.github.com/users/csshugs/gists{/gist_id}","starred_url":"https://api.github.com/users/csshugs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csshugs/subscriptions","organizations_url":"https://api.github.com/users/csshugs/orgs","repos_url":"https://api.github.com/users/csshugs/repos","events_url":"https://api.github.com/users/csshugs/events{/privacy}","received_events_url":"https://api.github.com/users/csshugs/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":0,"state":"open","created_at":"2016-08-03T08:30:17Z","updated_at":"2016-08-03T08:31:45Z","due_on":null,"closed_at":null},"comments":25,"created_at":"2016-07-31T12:55:04Z","updated_at":"2016-08-04T14:17:52Z","closed_at":null,"body":"Can't we use `rem` units here instead of `px`? Like the original [generic.shared](https://github.com/inuitcss/generic.shared/blob/master/_generic.shared.scss) did?\r\n\r\nuse:\r\n```\r\n@include inuit-rem(margin-bottom, $inuit-global-spacing-unit);\r\n```\r\n\r\ninstead of:\r\n```\r\nmargin-bottom: $inuit-global-spacing-unit;\r\n```\r\n\r\nOr is there a reason this hasn't been ported over?"},"comment":{"url":"https://api.github.com/repos/inuitcss/inuitcss/issues/comments/237566748","html_url":"https://github.com/inuitcss/inuitcss/issues/112#issuecomment-237566748","issue_url":"https://api.github.com/repos/inuitcss/inuitcss/issues/112","id":237566748,"user":{"login":"csswizardry","id":751944,"avatar_url":"https://avatars.githubusercontent.com/u/751944?v=3","gravatar_id":"","url":"https://api.github.com/users/csswizardry","html_url":"https://github.com/csswizardry","followers_url":"https://api.github.com/users/csswizardry/followers","following_url":"https://api.github.com/users/csswizardry/following{/other_user}","gists_url":"https://api.github.com/users/csswizardry/gists{/gist_id}","starred_url":"https://api.github.com/users/csswizardry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csswizardry/subscriptions","organizations_url":"https://api.github.com/users/csswizardry/orgs","repos_url":"https://api.github.com/users/csswizardry/repos","events_url":"https://api.github.com/users/csswizardry/events{/privacy}","received_events_url":"https://api.github.com/users/csswizardry/received_events","type":"User","site_admin":false},"created_at":"2016-08-04T14:17:52Z","updated_at":"2016-08-04T14:17:52Z","body":"1. I think that using rems globally is usually not the correct thing to do (happy to expand if people need it).\r\n2. If people want rems throughout the whole project, they can use [a post-processor](https://teamtreehouse.com/library/convert-pixels-to-rems).\r\n3. inuitcss should provide rems for typography-specific things (font-sizes, margins on type elements).\r\n4. We can probably achieve point 3 without needing an entire file for it."}}
{"actor":{"display_login":"csswizardry"}}