{"action":"created","issue":{"url":"https://api.github.com/repos/docker/toolbox/issues/183","repository_url":"https://api.github.com/repos/docker/toolbox","labels_url":"https://api.github.com/repos/docker/toolbox/issues/183/labels{/name}","comments_url":"https://api.github.com/repos/docker/toolbox/issues/183/comments","events_url":"https://api.github.com/repos/docker/toolbox/issues/183/events","html_url":"https://github.com/docker/toolbox/pull/183","id":106363780,"number":183,"title":"Add proxy variables to docker-machine command if they exists","user":{"login":"nickho","id":285996,"avatar_url":"https://avatars.githubusercontent.com/u/285996?v=3","gravatar_id":"","url":"https://api.github.com/users/nickho","html_url":"https://github.com/nickho","followers_url":"https://api.github.com/users/nickho/followers","following_url":"https://api.github.com/users/nickho/following{/other_user}","gists_url":"https://api.github.com/users/nickho/gists{/gist_id}","starred_url":"https://api.github.com/users/nickho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickho/subscriptions","organizations_url":"https://api.github.com/users/nickho/orgs","repos_url":"https://api.github.com/users/nickho/repos","events_url":"https://api.github.com/users/nickho/events{/privacy}","received_events_url":"https://api.github.com/users/nickho/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-09-14T15:12:48Z","updated_at":"2016-03-16T00:02:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/toolbox/pulls/183","html_url":"https://github.com/docker/toolbox/pull/183","diff_url":"https://github.com/docker/toolbox/pull/183.diff","patch_url":"https://github.com/docker/toolbox/pull/183.patch"},"body":"This attempt to solve the proxy issue when installing docker-toolbox on windows, but i believe the same mechanism could be used on mac as well. See #78. There is still work to be done for Kitematic.\r\n\r\nThis solution use the `HTTP_PROXY`, `HTTPS_PROXY`, and `NO_PROXY` system variables and pass them to the `docker-machine` `--engine-env` parameters.\r\n\r\nDon't forget to set the NO_PROXY system variable with at least the 192.168.99.100/101/102/103... IPs and dns names used to access local servers like 'kitematic', 'default', 'dev'.\r\n\r\nThis successfully launch the Docker Quickstart Terminal on windows if you set your *_PROXY variables as environnement variables before the first launch (in Control Panel). I believe this is the standard way to set proxy infos on Windows, Mac and Linux.\r\n"},"comment":{"url":"https://api.github.com/repos/docker/toolbox/issues/comments/197073601","html_url":"https://github.com/docker/toolbox/pull/183#issuecomment-197073601","issue_url":"https://api.github.com/repos/docker/toolbox/issues/183","id":197073601,"user":{"login":"nathanleclaire","id":1476820,"avatar_url":"https://avatars.githubusercontent.com/u/1476820?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanleclaire","html_url":"https://github.com/nathanleclaire","followers_url":"https://api.github.com/users/nathanleclaire/followers","following_url":"https://api.github.com/users/nathanleclaire/following{/other_user}","gists_url":"https://api.github.com/users/nathanleclaire/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanleclaire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanleclaire/subscriptions","organizations_url":"https://api.github.com/users/nathanleclaire/orgs","repos_url":"https://api.github.com/users/nathanleclaire/repos","events_url":"https://api.github.com/users/nathanleclaire/events{/privacy}","received_events_url":"https://api.github.com/users/nathanleclaire/received_events","type":"User","site_admin":false},"created_at":"2016-03-16T00:02:29Z","updated_at":"2016-03-16T00:02:29Z","body":"This seems to work OK, although I agree with @tianon that for simplicity's sake maybe we should drop the internal single quotes since we most likely won't need them.\r\n\r\n```console\r\n$ PROXY_ENV=\"foo\"\r\n$ PROXY_ENV=\"bar'$PROXY_ENV'\"\r\n$ echo $PROXY_ENV\r\nbar'foo'\r\n```"}}