{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/77330560","id":77330560,"diff_hunk":"@@ -275,6 +275,8 @@\n       gocd-server = 252;\n       terraria = 253;\n       mattermost = 254;\n+      quagga = 255;","path":"nixos/modules/misc/ids.nix","position":null,"original_position":4,"commit_id":"eb141309345e0200da8536792cfef41297600819","original_commit_id":"f0011d0377bfb028d6bc071e79afb402a9ba4182","user":{"login":"tavyc","id":3650609,"avatar_url":"https://avatars.githubusercontent.com/u/3650609?v=3","gravatar_id":"","url":"https://api.github.com/users/tavyc","html_url":"https://github.com/tavyc","followers_url":"https://api.github.com/users/tavyc/followers","following_url":"https://api.github.com/users/tavyc/following{/other_user}","gists_url":"https://api.github.com/users/tavyc/gists{/gist_id}","starred_url":"https://api.github.com/users/tavyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tavyc/subscriptions","organizations_url":"https://api.github.com/users/tavyc/orgs","repos_url":"https://api.github.com/users/tavyc/repos","events_url":"https://api.github.com/users/tavyc/events{/privacy}","received_events_url":"https://api.github.com/users/tavyc/received_events","type":"User","site_admin":false},"body":"There is no specific reason to use static ids, I just assumed it to be good practice for daemons, according to the comment at the top of misc/ids.nix.\r\n\r\nI've updated the module to use dynamic ids, and rebased the PR.","created_at":"2016-09-02T11:14:32Z","updated_at":"2016-09-02T11:14:32Z","html_url":"https://github.com/NixOS/nixpkgs/pull/18207#discussion_r77330560","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/18207","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/77330560"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/18207#discussion_r77330560"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/18207"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/18207","id":83771535,"html_url":"https://github.com/NixOS/nixpkgs/pull/18207","diff_url":"https://github.com/NixOS/nixpkgs/pull/18207.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/18207.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/18207","number":18207,"state":"open","locked":false,"title":"quagga service: init","user":{"login":"tavyc","id":3650609,"avatar_url":"https://avatars.githubusercontent.com/u/3650609?v=3","gravatar_id":"","url":"https://api.github.com/users/tavyc","html_url":"https://github.com/tavyc","followers_url":"https://api.github.com/users/tavyc/followers","following_url":"https://api.github.com/users/tavyc/following{/other_user}","gists_url":"https://api.github.com/users/tavyc/gists{/gist_id}","starred_url":"https://api.github.com/users/tavyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tavyc/subscriptions","organizations_url":"https://api.github.com/users/tavyc/orgs","repos_url":"https://api.github.com/users/tavyc/repos","events_url":"https://api.github.com/users/tavyc/events{/privacy}","received_events_url":"https://api.github.com/users/tavyc/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nThis adds a NixOS module to configure the Quagga IP routing software suite.\r\n\r\nIncluded is a test case which sets up a network of 4 machines and verifies the correct operation of a minimal OSPF configuration; it takes about a minute to run.\r\n\r\nTested on master and in production on multiple machines running release-16.03.\r\n\r\n###### Things done\r\n\r\n- [x] Tested using sandboxing\r\n  ([nix.useChroot](http://nixos.org/nixos/manual/options.html#opt-nix.useChroot) on NixOS,\r\n    or option `build-use-chroot` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] OS X\r\n   - [ ] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2016-09-02T09:32:05Z","updated_at":"2016-09-02T11:14:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10a08cdebd917367e09ee732f80f65d3cf1e6f2a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/18207/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/18207/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/18207/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/eb141309345e0200da8536792cfef41297600819","head":{"label":"tavyc:quagga-module","ref":"quagga-module","sha":"eb141309345e0200da8536792cfef41297600819","user":{"login":"tavyc","id":3650609,"avatar_url":"https://avatars.githubusercontent.com/u/3650609?v=3","gravatar_id":"","url":"https://api.github.com/users/tavyc","html_url":"https://github.com/tavyc","followers_url":"https://api.github.com/users/tavyc/followers","following_url":"https://api.github.com/users/tavyc/following{/other_user}","gists_url":"https://api.github.com/users/tavyc/gists{/gist_id}","starred_url":"https://api.github.com/users/tavyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tavyc/subscriptions","organizations_url":"https://api.github.com/users/tavyc/orgs","repos_url":"https://api.github.com/users/tavyc/repos","events_url":"https://api.github.com/users/tavyc/events{/privacy}","received_events_url":"https://api.github.com/users/tavyc/received_events","type":"User","site_admin":false},"repo":{"id":50460383,"name":"nixpkgs","full_name":"tavyc/nixpkgs","owner":{"login":"tavyc","id":3650609,"avatar_url":"https://avatars.githubusercontent.com/u/3650609?v=3","gravatar_id":"","url":"https://api.github.com/users/tavyc","html_url":"https://github.com/tavyc","followers_url":"https://api.github.com/users/tavyc/followers","following_url":"https://api.github.com/users/tavyc/following{/other_user}","gists_url":"https://api.github.com/users/tavyc/gists{/gist_id}","starred_url":"https://api.github.com/users/tavyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tavyc/subscriptions","organizations_url":"https://api.github.com/users/tavyc/orgs","repos_url":"https://api.github.com/users/tavyc/repos","events_url":"https://api.github.com/users/tavyc/events{/privacy}","received_events_url":"https://api.github.com/users/tavyc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tavyc/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/tavyc/nixpkgs","forks_url":"https://api.github.com/repos/tavyc/nixpkgs/forks","keys_url":"https://api.github.com/repos/tavyc/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tavyc/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tavyc/nixpkgs/teams","hooks_url":"https://api.github.com/repos/tavyc/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/tavyc/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/tavyc/nixpkgs/events","assignees_url":"https://api.github.com/repos/tavyc/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/tavyc/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/tavyc/nixpkgs/tags","blobs_url":"https://api.github.com/repos/tavyc/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tavyc/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tavyc/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/tavyc/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tavyc/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/tavyc/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/tavyc/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/tavyc/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/tavyc/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/tavyc/nixpkgs/subscription","commits_url":"https://api.github.com/repos/tavyc/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/tavyc/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/tavyc/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/tavyc/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/tavyc/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/tavyc/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tavyc/nixpkgs/merges","archive_url":"https://api.github.com/repos/tavyc/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tavyc/nixpkgs/downloads","issues_url":"https://api.github.com/repos/tavyc/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/tavyc/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/tavyc/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/tavyc/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tavyc/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/tavyc/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/tavyc/nixpkgs/deployments","created_at":"2016-01-26T21:26:19Z","updated_at":"2016-01-26T21:26:39Z","pushed_at":"2016-09-02T11:06:37Z","git_url":"git://github.com/tavyc/nixpkgs.git","ssh_url":"git@github.com:tavyc/nixpkgs.git","clone_url":"https://github.com/tavyc/nixpkgs.git","svn_url":"https://github.com/tavyc/nixpkgs","homepage":null,"size":341208,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"0bdec3194acbd3f42e467a45225ed0f15f9a13b1","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2016-09-02T07:39:46Z","pushed_at":"2016-09-02T11:06:38Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":583716,"stargazers_count":1271,"watchers_count":1271,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1587,"mirror_url":null,"open_issues_count":1514,"forks":1587,"open_issues":1514,"watchers":1271,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/18207"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/18207"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/18207"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/18207/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/18207/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/18207/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/eb141309345e0200da8536792cfef41297600819"}}}}
{"actor":{"display_login":"tavyc"}}