{"action":"created","comment":{"url":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/comments/69637706","id":69637706,"diff_hunk":"@@ -66,6 +66,48 @@ function getTimesDiff(fsStat, vinylStat) {\n   return timesDiff;\n }\n \n+function getOwnerDiff(fsStat, vinylStat) {\n+  if (/^win/.test(process.platform)) {\n+    return; // Always return undefined on windows.\n+  }\n+\n+  if (typeof vinylStat.uid !== 'number' &&\n+      typeof vinylStat.gid !== 'number') {\n+    return;\n+  }\n+\n+  var uid = fsStat.uid; // Default to current uid.\n+  if (typeof vinylStat.uid === 'number' &&\n+      vinylStat.uid >= 0) {\n+    uid = vinylStat.uid;\n+  }\n+\n+  var gid = fsStat.gid; // Default to current gid.\n+  if (typeof vinylStat.gid === 'number' &&\n+      vinylStat.gid >= 0) {\n+    gid = vinylStat.gid;\n+  }\n+\n+  if (isEqual(uid, fsStat.uid) &&\n+      isEqual(gid, fsStat.gid)) {\n+    return;\n+  }\n+\n+  if (uid < 0) {\n+    uid = undefined;","path":"lib/file-operations.js","position":32,"original_position":32,"commit_id":"1a7936a3022da4693e42fcd1bead3431eecb55da","original_commit_id":"1a7936a3022da4693e42fcd1bead3431eecb55da","user":{"login":"phated","id":992373,"avatar_url":"https://avatars.githubusercontent.com/u/992373?v=3","gravatar_id":"","url":"https://api.github.com/users/phated","html_url":"https://github.com/phated","followers_url":"https://api.github.com/users/phated/followers","following_url":"https://api.github.com/users/phated/following{/other_user}","gists_url":"https://api.github.com/users/phated/gists{/gist_id}","starred_url":"https://api.github.com/users/phated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phated/subscriptions","organizations_url":"https://api.github.com/users/phated/orgs","repos_url":"https://api.github.com/users/phated/repos","events_url":"https://api.github.com/users/phated/events{/privacy}","received_events_url":"https://api.github.com/users/phated/received_events","type":"User","site_admin":false},"body":"this should be defaulted when `isValid...` is checked","created_at":"2016-07-05T21:03:43Z","updated_at":"2016-07-05T21:03:43Z","html_url":"https://github.com/gulpjs/vinyl-fs/pull/188#discussion_r69637706","pull_request_url":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/188","_links":{"self":{"href":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/comments/69637706"},"html":{"href":"https://github.com/gulpjs/vinyl-fs/pull/188#discussion_r69637706"},"pull_request":{"href":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/188"}}},"pull_request":{"url":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/188","id":76276479,"html_url":"https://github.com/gulpjs/vinyl-fs/pull/188","diff_url":"https://github.com/gulpjs/vinyl-fs/pull/188.diff","patch_url":"https://github.com/gulpjs/vinyl-fs/pull/188.patch","issue_url":"https://api.github.com/repos/gulpjs/vinyl-fs/issues/188","number":188,"state":"open","locked":false,"title":"Added support for changing uid/gid (fix #157)","user":{"login":"stephanvl","id":1942599,"avatar_url":"https://avatars.githubusercontent.com/u/1942599?v=3","gravatar_id":"","url":"https://api.github.com/users/stephanvl","html_url":"https://github.com/stephanvl","followers_url":"https://api.github.com/users/stephanvl/followers","following_url":"https://api.github.com/users/stephanvl/following{/other_user}","gists_url":"https://api.github.com/users/stephanvl/gists{/gist_id}","starred_url":"https://api.github.com/users/stephanvl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephanvl/subscriptions","organizations_url":"https://api.github.com/users/stephanvl/orgs","repos_url":"https://api.github.com/users/stephanvl/repos","events_url":"https://api.github.com/users/stephanvl/events{/privacy}","received_events_url":"https://api.github.com/users/stephanvl/received_events","type":"User","site_admin":false},"body":"This PR adds support for changing the uid/gid of a file/directory.\r\n\r\nChanging the uid/gid of a file is only possible as the root user and will fail silently if this run as a non root user.\r\n\r\nWhat do you think we should do in this case?","created_at":"2016-07-05T13:44:51Z","updated_at":"2016-07-05T21:03:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c5de3d18e44d217c893576f0584ebda81af2512","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/188/commits","review_comments_url":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/188/comments","review_comment_url":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gulpjs/vinyl-fs/issues/188/comments","statuses_url":"https://api.github.com/repos/gulpjs/vinyl-fs/statuses/1a7936a3022da4693e42fcd1bead3431eecb55da","head":{"label":"stephanvl:master","ref":"master","sha":"1a7936a3022da4693e42fcd1bead3431eecb55da","user":{"login":"stephanvl","id":1942599,"avatar_url":"https://avatars.githubusercontent.com/u/1942599?v=3","gravatar_id":"","url":"https://api.github.com/users/stephanvl","html_url":"https://github.com/stephanvl","followers_url":"https://api.github.com/users/stephanvl/followers","following_url":"https://api.github.com/users/stephanvl/following{/other_user}","gists_url":"https://api.github.com/users/stephanvl/gists{/gist_id}","starred_url":"https://api.github.com/users/stephanvl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephanvl/subscriptions","organizations_url":"https://api.github.com/users/stephanvl/orgs","repos_url":"https://api.github.com/users/stephanvl/repos","events_url":"https://api.github.com/users/stephanvl/events{/privacy}","received_events_url":"https://api.github.com/users/stephanvl/received_events","type":"User","site_admin":false},"repo":{"id":62636385,"name":"vinyl-fs","full_name":"stephanvl/vinyl-fs","owner":{"login":"stephanvl","id":1942599,"avatar_url":"https://avatars.githubusercontent.com/u/1942599?v=3","gravatar_id":"","url":"https://api.github.com/users/stephanvl","html_url":"https://github.com/stephanvl","followers_url":"https://api.github.com/users/stephanvl/followers","following_url":"https://api.github.com/users/stephanvl/following{/other_user}","gists_url":"https://api.github.com/users/stephanvl/gists{/gist_id}","starred_url":"https://api.github.com/users/stephanvl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephanvl/subscriptions","organizations_url":"https://api.github.com/users/stephanvl/orgs","repos_url":"https://api.github.com/users/stephanvl/repos","events_url":"https://api.github.com/users/stephanvl/events{/privacy}","received_events_url":"https://api.github.com/users/stephanvl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stephanvl/vinyl-fs","description":"Vinyl adapter for the file system","fork":true,"url":"https://api.github.com/repos/stephanvl/vinyl-fs","forks_url":"https://api.github.com/repos/stephanvl/vinyl-fs/forks","keys_url":"https://api.github.com/repos/stephanvl/vinyl-fs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stephanvl/vinyl-fs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stephanvl/vinyl-fs/teams","hooks_url":"https://api.github.com/repos/stephanvl/vinyl-fs/hooks","issue_events_url":"https://api.github.com/repos/stephanvl/vinyl-fs/issues/events{/number}","events_url":"https://api.github.com/repos/stephanvl/vinyl-fs/events","assignees_url":"https://api.github.com/repos/stephanvl/vinyl-fs/assignees{/user}","branches_url":"https://api.github.com/repos/stephanvl/vinyl-fs/branches{/branch}","tags_url":"https://api.github.com/repos/stephanvl/vinyl-fs/tags","blobs_url":"https://api.github.com/repos/stephanvl/vinyl-fs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stephanvl/vinyl-fs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stephanvl/vinyl-fs/git/refs{/sha}","trees_url":"https://api.github.com/repos/stephanvl/vinyl-fs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stephanvl/vinyl-fs/statuses/{sha}","languages_url":"https://api.github.com/repos/stephanvl/vinyl-fs/languages","stargazers_url":"https://api.github.com/repos/stephanvl/vinyl-fs/stargazers","contributors_url":"https://api.github.com/repos/stephanvl/vinyl-fs/contributors","subscribers_url":"https://api.github.com/repos/stephanvl/vinyl-fs/subscribers","subscription_url":"https://api.github.com/repos/stephanvl/vinyl-fs/subscription","commits_url":"https://api.github.com/repos/stephanvl/vinyl-fs/commits{/sha}","git_commits_url":"https://api.github.com/repos/stephanvl/vinyl-fs/git/commits{/sha}","comments_url":"https://api.github.com/repos/stephanvl/vinyl-fs/comments{/number}","issue_comment_url":"https://api.github.com/repos/stephanvl/vinyl-fs/issues/comments{/number}","contents_url":"https://api.github.com/repos/stephanvl/vinyl-fs/contents/{+path}","compare_url":"https://api.github.com/repos/stephanvl/vinyl-fs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stephanvl/vinyl-fs/merges","archive_url":"https://api.github.com/repos/stephanvl/vinyl-fs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stephanvl/vinyl-fs/downloads","issues_url":"https://api.github.com/repos/stephanvl/vinyl-fs/issues{/number}","pulls_url":"https://api.github.com/repos/stephanvl/vinyl-fs/pulls{/number}","milestones_url":"https://api.github.com/repos/stephanvl/vinyl-fs/milestones{/number}","notifications_url":"https://api.github.com/repos/stephanvl/vinyl-fs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stephanvl/vinyl-fs/labels{/name}","releases_url":"https://api.github.com/repos/stephanvl/vinyl-fs/releases{/id}","deployments_url":"https://api.github.com/repos/stephanvl/vinyl-fs/deployments","created_at":"2016-07-05T12:49:30Z","updated_at":"2016-07-05T12:49:31Z","pushed_at":"2016-07-05T13:55:24Z","git_url":"git://github.com/stephanvl/vinyl-fs.git","ssh_url":"git@github.com:stephanvl/vinyl-fs.git","clone_url":"https://github.com/stephanvl/vinyl-fs.git","svn_url":"https://github.com/stephanvl/vinyl-fs","homepage":null,"size":331,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gulpjs:master","ref":"master","sha":"5ffb005b4ce8fd054f32df6593f55c7066895f40","user":{"login":"gulpjs","id":6200624,"avatar_url":"https://avatars.githubusercontent.com/u/6200624?v=3","gravatar_id":"","url":"https://api.github.com/users/gulpjs","html_url":"https://github.com/gulpjs","followers_url":"https://api.github.com/users/gulpjs/followers","following_url":"https://api.github.com/users/gulpjs/following{/other_user}","gists_url":"https://api.github.com/users/gulpjs/gists{/gist_id}","starred_url":"https://api.github.com/users/gulpjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gulpjs/subscriptions","organizations_url":"https://api.github.com/users/gulpjs/orgs","repos_url":"https://api.github.com/users/gulpjs/repos","events_url":"https://api.github.com/users/gulpjs/events{/privacy}","received_events_url":"https://api.github.com/users/gulpjs/received_events","type":"Organization","site_admin":false},"repo":{"id":15355019,"name":"vinyl-fs","full_name":"gulpjs/vinyl-fs","owner":{"login":"gulpjs","id":6200624,"avatar_url":"https://avatars.githubusercontent.com/u/6200624?v=3","gravatar_id":"","url":"https://api.github.com/users/gulpjs","html_url":"https://github.com/gulpjs","followers_url":"https://api.github.com/users/gulpjs/followers","following_url":"https://api.github.com/users/gulpjs/following{/other_user}","gists_url":"https://api.github.com/users/gulpjs/gists{/gist_id}","starred_url":"https://api.github.com/users/gulpjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gulpjs/subscriptions","organizations_url":"https://api.github.com/users/gulpjs/orgs","repos_url":"https://api.github.com/users/gulpjs/repos","events_url":"https://api.github.com/users/gulpjs/events{/privacy}","received_events_url":"https://api.github.com/users/gulpjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gulpjs/vinyl-fs","description":"Vinyl adapter for the file system","fork":false,"url":"https://api.github.com/repos/gulpjs/vinyl-fs","forks_url":"https://api.github.com/repos/gulpjs/vinyl-fs/forks","keys_url":"https://api.github.com/repos/gulpjs/vinyl-fs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gulpjs/vinyl-fs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gulpjs/vinyl-fs/teams","hooks_url":"https://api.github.com/repos/gulpjs/vinyl-fs/hooks","issue_events_url":"https://api.github.com/repos/gulpjs/vinyl-fs/issues/events{/number}","events_url":"https://api.github.com/repos/gulpjs/vinyl-fs/events","assignees_url":"https://api.github.com/repos/gulpjs/vinyl-fs/assignees{/user}","branches_url":"https://api.github.com/repos/gulpjs/vinyl-fs/branches{/branch}","tags_url":"https://api.github.com/repos/gulpjs/vinyl-fs/tags","blobs_url":"https://api.github.com/repos/gulpjs/vinyl-fs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gulpjs/vinyl-fs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gulpjs/vinyl-fs/git/refs{/sha}","trees_url":"https://api.github.com/repos/gulpjs/vinyl-fs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gulpjs/vinyl-fs/statuses/{sha}","languages_url":"https://api.github.com/repos/gulpjs/vinyl-fs/languages","stargazers_url":"https://api.github.com/repos/gulpjs/vinyl-fs/stargazers","contributors_url":"https://api.github.com/repos/gulpjs/vinyl-fs/contributors","subscribers_url":"https://api.github.com/repos/gulpjs/vinyl-fs/subscribers","subscription_url":"https://api.github.com/repos/gulpjs/vinyl-fs/subscription","commits_url":"https://api.github.com/repos/gulpjs/vinyl-fs/commits{/sha}","git_commits_url":"https://api.github.com/repos/gulpjs/vinyl-fs/git/commits{/sha}","comments_url":"https://api.github.com/repos/gulpjs/vinyl-fs/comments{/number}","issue_comment_url":"https://api.github.com/repos/gulpjs/vinyl-fs/issues/comments{/number}","contents_url":"https://api.github.com/repos/gulpjs/vinyl-fs/contents/{+path}","compare_url":"https://api.github.com/repos/gulpjs/vinyl-fs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gulpjs/vinyl-fs/merges","archive_url":"https://api.github.com/repos/gulpjs/vinyl-fs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gulpjs/vinyl-fs/downloads","issues_url":"https://api.github.com/repos/gulpjs/vinyl-fs/issues{/number}","pulls_url":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls{/number}","milestones_url":"https://api.github.com/repos/gulpjs/vinyl-fs/milestones{/number}","notifications_url":"https://api.github.com/repos/gulpjs/vinyl-fs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gulpjs/vinyl-fs/labels{/name}","releases_url":"https://api.github.com/repos/gulpjs/vinyl-fs/releases{/id}","deployments_url":"https://api.github.com/repos/gulpjs/vinyl-fs/deployments","created_at":"2013-12-21T06:40:44Z","updated_at":"2016-07-04T03:54:49Z","pushed_at":"2016-07-05T13:55:24Z","git_url":"git://github.com/gulpjs/vinyl-fs.git","ssh_url":"git@github.com:gulpjs/vinyl-fs.git","clone_url":"https://github.com/gulpjs/vinyl-fs.git","svn_url":"https://github.com/gulpjs/vinyl-fs","homepage":null,"size":398,"stargazers_count":510,"watchers_count":510,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":84,"mirror_url":null,"open_issues_count":8,"forks":84,"open_issues":8,"watchers":510,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/188"},"html":{"href":"https://github.com/gulpjs/vinyl-fs/pull/188"},"issue":{"href":"https://api.github.com/repos/gulpjs/vinyl-fs/issues/188"},"comments":{"href":"https://api.github.com/repos/gulpjs/vinyl-fs/issues/188/comments"},"review_comments":{"href":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/188/comments"},"review_comment":{"href":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/188/commits"},"statuses":{"href":"https://api.github.com/repos/gulpjs/vinyl-fs/statuses/1a7936a3022da4693e42fcd1bead3431eecb55da"}}}}
{"actor":{"display_login":"phated"}}