{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/49798751","id":49798751,"diff_hunk":"@@ -422,7 +422,7 @@ pub struct StreamedResponse<R: HttpResponse> {\n impl<R: HttpResponse> Read for StreamedResponse<R> {\n     #[inline]\n     fn read(&mut self, buf: &mut [u8]) -> io::Result<usize> {\n-        match self.decoder {\n+       match self.decoder {","path":"components/net/http_loader.rs","position":5,"original_position":5,"commit_id":"32c56fcce31929550ad449c8973a9a59c7966e89","original_commit_id":"32c56fcce31929550ad449c8973a9a59c7966e89","user":{"login":"nikkisquared","id":7886109,"avatar_url":"https://avatars.githubusercontent.com/u/7886109?v=3","gravatar_id":"","url":"https://api.github.com/users/nikkisquared","html_url":"https://github.com/nikkisquared","followers_url":"https://api.github.com/users/nikkisquared/followers","following_url":"https://api.github.com/users/nikkisquared/following{/other_user}","gists_url":"https://api.github.com/users/nikkisquared/gists{/gist_id}","starred_url":"https://api.github.com/users/nikkisquared/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikkisquared/subscriptions","organizations_url":"https://api.github.com/users/nikkisquared/orgs","repos_url":"https://api.github.com/users/nikkisquared/repos","events_url":"https://api.github.com/users/nikkisquared/events{/privacy}","received_events_url":"https://api.github.com/users/nikkisquared/received_events","type":"User","site_admin":false},"body":"yep, whoops, I caught and fixed that before, but then I must've accidentally undone it when I was trying to fix a different mistake I made. for some reason test-tidy doesn't catch it (assuming it's supposed to be unhappy about spaces not divisible by 4)","created_at":"2016-01-14T22:57:14Z","updated_at":"2016-01-14T22:57:14Z","html_url":"https://github.com/servo/servo/pull/9321#discussion_r49798751","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/9321","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/49798751"},"html":{"href":"https://github.com/servo/servo/pull/9321#discussion_r49798751"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/9321"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/9321","id":56105061,"html_url":"https://github.com/servo/servo/pull/9321","diff_url":"https://github.com/servo/servo/pull/9321.diff","patch_url":"https://github.com/servo/servo/pull/9321.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/9321","number":9321,"state":"open","locked":false,"title":"Test setting response.body and fetching a message on a server","user":{"login":"nikkisquared","id":7886109,"avatar_url":"https://avatars.githubusercontent.com/u/7886109?v=3","gravatar_id":"","url":"https://api.github.com/users/nikkisquared","html_url":"https://github.com/nikkisquared","followers_url":"https://api.github.com/users/nikkisquared/followers","following_url":"https://api.github.com/users/nikkisquared/following{/other_user}","gists_url":"https://api.github.com/users/nikkisquared/gists{/gist_id}","starred_url":"https://api.github.com/users/nikkisquared/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikkisquared/subscriptions","organizations_url":"https://api.github.com/users/nikkisquared/orgs","repos_url":"https://api.github.com/users/nikkisquared/repos","events_url":"https://api.github.com/users/nikkisquared/events{/privacy}","received_events_url":"https://api.github.com/users/nikkisquared/received_events","type":"User","site_admin":false},"body":"I've updated http_fetch to now set response.body, as well as written a test to ensure that fetch can retrieve a message on a server. I've also looked into partially implementing some more of http_fetch while trying to figure out where response.body gets written to.\r\n\r\nAs always I'd like feedback on my logic, I'm confident there are more steps for handling response.body I need but I find the specification difficult to parse on this.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/servo/servo/9321)\n<!-- Reviewable:end -->\n","created_at":"2016-01-14T22:41:03Z","updated_at":"2016-01-14T22:57:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77a6845e01318c4bc20c7897efb01c8cb45e50a9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/9321/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/9321/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/9321/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/32c56fcce31929550ad449c8973a9a59c7966e89","head":{"label":"nikkisquared:response_body","ref":"response_body","sha":"32c56fcce31929550ad449c8973a9a59c7966e89","user":{"login":"nikkisquared","id":7886109,"avatar_url":"https://avatars.githubusercontent.com/u/7886109?v=3","gravatar_id":"","url":"https://api.github.com/users/nikkisquared","html_url":"https://github.com/nikkisquared","followers_url":"https://api.github.com/users/nikkisquared/followers","following_url":"https://api.github.com/users/nikkisquared/following{/other_user}","gists_url":"https://api.github.com/users/nikkisquared/gists{/gist_id}","starred_url":"https://api.github.com/users/nikkisquared/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikkisquared/subscriptions","organizations_url":"https://api.github.com/users/nikkisquared/orgs","repos_url":"https://api.github.com/users/nikkisquared/repos","events_url":"https://api.github.com/users/nikkisquared/events{/privacy}","received_events_url":"https://api.github.com/users/nikkisquared/received_events","type":"User","site_admin":false},"repo":{"id":44995414,"name":"servo","full_name":"nikkisquared/servo","owner":{"login":"nikkisquared","id":7886109,"avatar_url":"https://avatars.githubusercontent.com/u/7886109?v=3","gravatar_id":"","url":"https://api.github.com/users/nikkisquared","html_url":"https://github.com/nikkisquared","followers_url":"https://api.github.com/users/nikkisquared/followers","following_url":"https://api.github.com/users/nikkisquared/following{/other_user}","gists_url":"https://api.github.com/users/nikkisquared/gists{/gist_id}","starred_url":"https://api.github.com/users/nikkisquared/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikkisquared/subscriptions","organizations_url":"https://api.github.com/users/nikkisquared/orgs","repos_url":"https://api.github.com/users/nikkisquared/repos","events_url":"https://api.github.com/users/nikkisquared/events{/privacy}","received_events_url":"https://api.github.com/users/nikkisquared/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nikkisquared/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/nikkisquared/servo","forks_url":"https://api.github.com/repos/nikkisquared/servo/forks","keys_url":"https://api.github.com/repos/nikkisquared/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nikkisquared/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nikkisquared/servo/teams","hooks_url":"https://api.github.com/repos/nikkisquared/servo/hooks","issue_events_url":"https://api.github.com/repos/nikkisquared/servo/issues/events{/number}","events_url":"https://api.github.com/repos/nikkisquared/servo/events","assignees_url":"https://api.github.com/repos/nikkisquared/servo/assignees{/user}","branches_url":"https://api.github.com/repos/nikkisquared/servo/branches{/branch}","tags_url":"https://api.github.com/repos/nikkisquared/servo/tags","blobs_url":"https://api.github.com/repos/nikkisquared/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nikkisquared/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nikkisquared/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/nikkisquared/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nikkisquared/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/nikkisquared/servo/languages","stargazers_url":"https://api.github.com/repos/nikkisquared/servo/stargazers","contributors_url":"https://api.github.com/repos/nikkisquared/servo/contributors","subscribers_url":"https://api.github.com/repos/nikkisquared/servo/subscribers","subscription_url":"https://api.github.com/repos/nikkisquared/servo/subscription","commits_url":"https://api.github.com/repos/nikkisquared/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/nikkisquared/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/nikkisquared/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/nikkisquared/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/nikkisquared/servo/contents/{+path}","compare_url":"https://api.github.com/repos/nikkisquared/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nikkisquared/servo/merges","archive_url":"https://api.github.com/repos/nikkisquared/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nikkisquared/servo/downloads","issues_url":"https://api.github.com/repos/nikkisquared/servo/issues{/number}","pulls_url":"https://api.github.com/repos/nikkisquared/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/nikkisquared/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/nikkisquared/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nikkisquared/servo/labels{/name}","releases_url":"https://api.github.com/repos/nikkisquared/servo/releases{/id}","created_at":"2015-10-26T20:31:05Z","updated_at":"2015-10-26T20:04:06Z","pushed_at":"2016-01-14T22:35:26Z","git_url":"git://github.com/nikkisquared/servo.git","ssh_url":"git@github.com:nikkisquared/servo.git","clone_url":"https://github.com/nikkisquared/servo.git","svn_url":"https://github.com/nikkisquared/servo","homepage":"","size":167631,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"a28b5cb43859b6300c0b157c6b3d25d78606dda8","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","created_at":"2012-02-08T19:07:25Z","updated_at":"2016-01-14T22:11:37Z","pushed_at":"2016-01-14T22:52:26Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":197570,"stargazers_count":5479,"watchers_count":5479,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":920,"mirror_url":null,"open_issues_count":1263,"forks":920,"open_issues":1263,"watchers":5479,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/9321"},"html":{"href":"https://github.com/servo/servo/pull/9321"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/9321"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/9321/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/9321/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/9321/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/32c56fcce31929550ad449c8973a9a59c7966e89"}}}}