{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/57981164","id":57981164,"diff_hunk":"@@ -0,0 +1,207 @@\n+﻿using System.IO;\n+using System.Collections.Generic;\n+using System.Linq;\n+using Microsoft.Xunit.Performance;\n+using System.Xml;\n+using SerializationTypes;\n+\n+namespace System.Runtime.Serialization\n+{\n+    #region Performance tests configuration types\n+\n+    public enum SerializerType\n+    {\n+        DataContractSerializer,\n+        DataContractJsonSerializer,\n+        XmlSerializer,\n+        JsonNet\n+    }\n+\n+    public enum TestType\n+    {\n+        SimpleType,\n+        ISerializable,\n+        Dictionary,\n+        ListOfInt,\n+        String,\n+        ByteArray,\n+        XmlElement\n+    }\n+\n+    public interface IPerfTestSerializer\n+    {\n+        void Init(object obj);\n+        void Serialize(object obj, Stream s);\n+        void Deserialize(Stream s);\n+    }\n+\n+    public abstract class SerializerFactory","path":"src/System.Runtime.Serialization.Xml/tests/Performance/PerformanceTestsCommon.cs","position":38,"original_position":38,"commit_id":"d6ba2daf8e9c59227226920dfc5ffd8b4749762f","original_commit_id":"3ccf460c5db8dba3b161cdb458d4079b881849aa","user":{"login":"khdang","id":10590707,"avatar_url":"https://avatars.githubusercontent.com/u/10590707?v=3","gravatar_id":"","url":"https://api.github.com/users/khdang","html_url":"https://github.com/khdang","followers_url":"https://api.github.com/users/khdang/followers","following_url":"https://api.github.com/users/khdang/following{/other_user}","gists_url":"https://api.github.com/users/khdang/gists{/gist_id}","starred_url":"https://api.github.com/users/khdang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khdang/subscriptions","organizations_url":"https://api.github.com/users/khdang/orgs","repos_url":"https://api.github.com/users/khdang/repos","events_url":"https://api.github.com/users/khdang/events{/privacy}","received_events_url":"https://api.github.com/users/khdang/received_events","type":"User","site_admin":false},"body":"I don't have a good reason. I've updated this to interface as well.","created_at":"2016-03-30T23:33:06Z","updated_at":"2016-03-30T23:33:06Z","html_url":"https://github.com/dotnet/corefx/pull/7119#discussion_r57981164","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/7119","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/57981164"},"html":{"href":"https://github.com/dotnet/corefx/pull/7119#discussion_r57981164"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7119"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/7119","id":63653516,"html_url":"https://github.com/dotnet/corefx/pull/7119","diff_url":"https://github.com/dotnet/corefx/pull/7119.diff","patch_url":"https://github.com/dotnet/corefx/pull/7119.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/7119","number":7119,"state":"open","locked":false,"title":"Improve serialization performance tests","user":{"login":"khdang","id":10590707,"avatar_url":"https://avatars.githubusercontent.com/u/10590707?v=3","gravatar_id":"","url":"https://api.github.com/users/khdang","html_url":"https://github.com/khdang","followers_url":"https://api.github.com/users/khdang/followers","following_url":"https://api.github.com/users/khdang/following{/other_user}","gists_url":"https://api.github.com/users/khdang/gists{/gist_id}","starred_url":"https://api.github.com/users/khdang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khdang/subscriptions","organizations_url":"https://api.github.com/users/khdang/orgs","repos_url":"https://api.github.com/users/khdang/repos","events_url":"https://api.github.com/users/khdang/events{/privacy}","received_events_url":"https://api.github.com/users/khdang/received_events","type":"User","site_admin":false},"body":"- Refactor all serialization performance tests to remove duplicated code. Adding more perf tests for all serializers is also more straightforward. Update namespace so the tests show up properly in reports.\r\n- Add a flag in test project to enable running tests without project references, which helps us run against Desktop facades for comparison purpose\r\n- Add performance tests for Json.Net for comparison purpose\r\n\r\ncc: @SGuyGe @shmao @zhenlan","created_at":"2016-03-22T00:21:58Z","updated_at":"2016-03-30T23:33:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7520340a1413879ad4ced3e5a2eae496bb152f2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/7119/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/7119/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/7119/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/d6ba2daf8e9c59227226920dfc5ffd8b4749762f","head":{"label":"khdang:improve_serialization_perf_tests","ref":"improve_serialization_perf_tests","sha":"d6ba2daf8e9c59227226920dfc5ffd8b4749762f","user":{"login":"khdang","id":10590707,"avatar_url":"https://avatars.githubusercontent.com/u/10590707?v=3","gravatar_id":"","url":"https://api.github.com/users/khdang","html_url":"https://github.com/khdang","followers_url":"https://api.github.com/users/khdang/followers","following_url":"https://api.github.com/users/khdang/following{/other_user}","gists_url":"https://api.github.com/users/khdang/gists{/gist_id}","starred_url":"https://api.github.com/users/khdang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khdang/subscriptions","organizations_url":"https://api.github.com/users/khdang/orgs","repos_url":"https://api.github.com/users/khdang/repos","events_url":"https://api.github.com/users/khdang/events{/privacy}","received_events_url":"https://api.github.com/users/khdang/received_events","type":"User","site_admin":false},"repo":{"id":33624190,"name":"corefx","full_name":"khdang/corefx","owner":{"login":"khdang","id":10590707,"avatar_url":"https://avatars.githubusercontent.com/u/10590707?v=3","gravatar_id":"","url":"https://api.github.com/users/khdang","html_url":"https://github.com/khdang","followers_url":"https://api.github.com/users/khdang/followers","following_url":"https://api.github.com/users/khdang/following{/other_user}","gists_url":"https://api.github.com/users/khdang/gists{/gist_id}","starred_url":"https://api.github.com/users/khdang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khdang/subscriptions","organizations_url":"https://api.github.com/users/khdang/orgs","repos_url":"https://api.github.com/users/khdang/repos","events_url":"https://api.github.com/users/khdang/events{/privacy}","received_events_url":"https://api.github.com/users/khdang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/khdang/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/khdang/corefx","forks_url":"https://api.github.com/repos/khdang/corefx/forks","keys_url":"https://api.github.com/repos/khdang/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/khdang/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/khdang/corefx/teams","hooks_url":"https://api.github.com/repos/khdang/corefx/hooks","issue_events_url":"https://api.github.com/repos/khdang/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/khdang/corefx/events","assignees_url":"https://api.github.com/repos/khdang/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/khdang/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/khdang/corefx/tags","blobs_url":"https://api.github.com/repos/khdang/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/khdang/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/khdang/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/khdang/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/khdang/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/khdang/corefx/languages","stargazers_url":"https://api.github.com/repos/khdang/corefx/stargazers","contributors_url":"https://api.github.com/repos/khdang/corefx/contributors","subscribers_url":"https://api.github.com/repos/khdang/corefx/subscribers","subscription_url":"https://api.github.com/repos/khdang/corefx/subscription","commits_url":"https://api.github.com/repos/khdang/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/khdang/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/khdang/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/khdang/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/khdang/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/khdang/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/khdang/corefx/merges","archive_url":"https://api.github.com/repos/khdang/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/khdang/corefx/downloads","issues_url":"https://api.github.com/repos/khdang/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/khdang/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/khdang/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/khdang/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/khdang/corefx/labels{/name}","releases_url":"https://api.github.com/repos/khdang/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/khdang/corefx/deployments","created_at":"2015-04-08T18:20:35Z","updated_at":"2016-02-10T22:31:56Z","pushed_at":"2016-03-30T07:29:06Z","git_url":"git://github.com/khdang/corefx.git","ssh_url":"git@github.com:khdang/corefx.git","clone_url":"https://github.com/khdang/corefx.git","svn_url":"https://github.com/khdang/corefx","homepage":"","size":60863,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"1e754187c74924f77a27c67c127dc19eb138a18e","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-03-30T22:59:14Z","pushed_at":"2016-03-30T23:30:45Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/","size":83544,"stargazers_count":9396,"watchers_count":9396,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2210,"mirror_url":null,"open_issues_count":937,"forks":2210,"open_issues":937,"watchers":9396,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7119"},"html":{"href":"https://github.com/dotnet/corefx/pull/7119"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/7119"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/7119/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7119/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7119/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/d6ba2daf8e9c59227226920dfc5ffd8b4749762f"}}}}