{"action":"created","issue":{"url":"https://api.github.com/repos/waf-project/waf/issues/1600","repository_url":"https://api.github.com/repos/waf-project/waf","labels_url":"https://api.github.com/repos/waf-project/waf/issues/1600/labels{/name}","comments_url":"https://api.github.com/repos/waf-project/waf/issues/1600/comments","events_url":"https://api.github.com/repos/waf-project/waf/issues/1600/events","html_url":"https://github.com/waf-project/waf/issues/1600","id":95151439,"number":1600,"title":"check_cfg and check_cc leave inconsistent environment","user":{"login":"rr-","id":1045476,"avatar_url":"https://avatars.githubusercontent.com/u/1045476?v=3","gravatar_id":"","url":"https://api.github.com/users/rr-","html_url":"https://github.com/rr-","followers_url":"https://api.github.com/users/rr-/followers","following_url":"https://api.github.com/users/rr-/following{/other_user}","gists_url":"https://api.github.com/users/rr-/gists{/gist_id}","starred_url":"https://api.github.com/users/rr-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rr-/subscriptions","organizations_url":"https://api.github.com/users/rr-/orgs","repos_url":"https://api.github.com/users/rr-/repos","events_url":"https://api.github.com/users/rr-/events{/privacy}","received_events_url":"https://api.github.com/users/rr-/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/waf-project/waf/labels/waf%201.9","name":"waf 1.9","color":"5319e7"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2015-07-15T09:48:43Z","updated_at":"2016-06-26T12:18:15Z","closed_at":"2016-06-26T12:18:15Z","body":"Running `check_cfg` like this:\r\n\r\n    ctx.check_cfg(\r\n        package = 'libpng',\r\n        args = '--cflags --libs',\r\n        uselib_store = 'LIBPNG',\r\n        mandatory = True)\r\n\r\nDefines `HAVE_LIBPNG` inside `env` like so:\r\n\r\n    'HAVE_LIBPNG' 1\r\n\r\nAt the same time, running `check_cc` like this:\r\n\r\n    ctx.check_cc(\r\n        header_name = 'Windows.h',\r\n        uselib_store = 'WINDOWS',\r\n        mandatory = False)\r\n\r\nDefines `HAVE_WINDOWS_H` inside `DEFINES` like so:\r\n\r\n    'DEFINES' ['HAVE_WINDOWS_H=1']\r\n\r\nThese are inconsistent. In case of `check_cc`, it is difficult to test the configuration without doing some parsing. (The test is feasible when manually deciding which modules to compile.)"},"comment":{"url":"https://api.github.com/repos/waf-project/waf/issues/comments/228598558","html_url":"https://github.com/waf-project/waf/issues/1600#issuecomment-228598558","issue_url":"https://api.github.com/repos/waf-project/waf/issues/1600","id":228598558,"user":{"login":"ita1024","id":508304,"avatar_url":"https://avatars.githubusercontent.com/u/508304?v=3","gravatar_id":"","url":"https://api.github.com/users/ita1024","html_url":"https://github.com/ita1024","followers_url":"https://api.github.com/users/ita1024/followers","following_url":"https://api.github.com/users/ita1024/following{/other_user}","gists_url":"https://api.github.com/users/ita1024/gists{/gist_id}","starred_url":"https://api.github.com/users/ita1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ita1024/subscriptions","organizations_url":"https://api.github.com/users/ita1024/orgs","repos_url":"https://api.github.com/users/ita1024/repos","events_url":"https://api.github.com/users/ita1024/events{/privacy}","received_events_url":"https://api.github.com/users/ita1024/received_events","type":"User","site_admin":false},"created_at":"2016-06-26T12:18:15Z","updated_at":"2016-06-26T12:18:15Z","body":"Waf 1.9.0 was released today, so we can finally close this."}}
{"actor":{"display_login":"ita1024"}}