{"action":"created","issue":{"url":"https://api.github.com/repos/UKHomeOffice/hof-controllers/issues/72","repository_url":"https://api.github.com/repos/UKHomeOffice/hof-controllers","labels_url":"https://api.github.com/repos/UKHomeOffice/hof-controllers/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/UKHomeOffice/hof-controllers/issues/72/comments","events_url":"https://api.github.com/repos/UKHomeOffice/hof-controllers/issues/72/events","html_url":"https://github.com/UKHomeOffice/hof-controllers/pull/72","id":166049279,"number":72,"title":"Bugfix - prevent reset session race condition","user":{"login":"davet1985","id":1334068,"avatar_url":"https://avatars.githubusercontent.com/u/1334068?v=3","gravatar_id":"","url":"https://api.github.com/users/davet1985","html_url":"https://github.com/davet1985","followers_url":"https://api.github.com/users/davet1985/followers","following_url":"https://api.github.com/users/davet1985/following{/other_user}","gists_url":"https://api.github.com/users/davet1985/gists{/gist_id}","starred_url":"https://api.github.com/users/davet1985/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davet1985/subscriptions","organizations_url":"https://api.github.com/users/davet1985/orgs","repos_url":"https://api.github.com/users/davet1985/repos","events_url":"https://api.github.com/users/davet1985/events{/privacy}","received_events_url":"https://api.github.com/users/davet1985/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-18T09:00:04Z","updated_at":"2016-07-18T09:47:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/UKHomeOffice/hof-controllers/pulls/72","html_url":"https://github.com/UKHomeOffice/hof-controllers/pull/72","diff_url":"https://github.com/UKHomeOffice/hof-controllers/pull/72.diff","patch_url":"https://github.com/UKHomeOffice/hof-controllers/pull/72.patch"},"body":"There is a potential race condition in the `BaseController.getValues` function. Looks like it’s possible for the `super.getValues` function to call the callback, which calls the following middleware functions and sends the response, before the session has been reset.\r\n\r\nThe following has been done to fix this issue: -\r\n\r\n* defer the callback for the next middleware function until after the check for resetting the session\r\n* handle error returned from parent controller `getValues` by immediately firing the callback with the error"},"comment":{"url":"https://api.github.com/repos/UKHomeOffice/hof-controllers/issues/comments/233287121","html_url":"https://github.com/UKHomeOffice/hof-controllers/pull/72#issuecomment-233287121","issue_url":"https://api.github.com/repos/UKHomeOffice/hof-controllers/issues/72","id":233287121,"user":{"login":"daniel-ac-martin","id":10604229,"avatar_url":"https://avatars.githubusercontent.com/u/10604229?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-ac-martin","html_url":"https://github.com/daniel-ac-martin","followers_url":"https://api.github.com/users/daniel-ac-martin/followers","following_url":"https://api.github.com/users/daniel-ac-martin/following{/other_user}","gists_url":"https://api.github.com/users/daniel-ac-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-ac-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-ac-martin/subscriptions","organizations_url":"https://api.github.com/users/daniel-ac-martin/orgs","repos_url":"https://api.github.com/users/daniel-ac-martin/repos","events_url":"https://api.github.com/users/daniel-ac-martin/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-ac-martin/received_events","type":"User","site_admin":false},"created_at":"2016-07-18T09:47:33Z","updated_at":"2016-07-18T09:47:33Z","body":"LGTM."}}
{"actor":{"display_login":"daniel-ac-martin"}}