{"action":"created","comment":{"url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/comments/82364209","pull_request_review_id":3277214,"id":82364209,"diff_hunk":"@@ -100,12 +107,7 @@ export default class Camera extends Component {\n       method, onUserMedia, onUploadFallback,\n       faceCaptureClick: this.capture.once,\n       countDownRef: (c) => { this.countdown = c },\n-      webcamRef: (c) => {","path":"src/components/Camera/index.js","position":35,"original_position":35,"commit_id":"fefeef42e1a0c3bdecf55ecd67694a92ec60c2ae","original_commit_id":"fefeef42e1a0c3bdecf55ecd67694a92ec60c2ae","user":{"login":"rfreitas","id":651348,"avatar_url":"https://avatars.githubusercontent.com/u/651348?v=3","gravatar_id":"","url":"https://api.github.com/users/rfreitas","html_url":"https://github.com/rfreitas","followers_url":"https://api.github.com/users/rfreitas/followers","following_url":"https://api.github.com/users/rfreitas/following{/other_user}","gists_url":"https://api.github.com/users/rfreitas/gists{/gist_id}","starred_url":"https://api.github.com/users/rfreitas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfreitas/subscriptions","organizations_url":"https://api.github.com/users/rfreitas/orgs","repos_url":"https://api.github.com/users/rfreitas/repos","events_url":"https://api.github.com/users/rfreitas/events{/privacy}","received_events_url":"https://api.github.com/users/rfreitas/received_events","type":"User","site_admin":false},"body":"this was the hack to figure out when mounting and unmounting the webcam","created_at":"2016-10-07T10:21:09Z","updated_at":"2016-10-07T10:21:09Z","html_url":"https://github.com/onfido/onfido-sdk-ui/pull/71#discussion_r82364209","pull_request_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/71","_links":{"self":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/comments/82364209"},"html":{"href":"https://github.com/onfido/onfido-sdk-ui/pull/71#discussion_r82364209"},"pull_request":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/71","id":88240480,"html_url":"https://github.com/onfido/onfido-sdk-ui/pull/71","diff_url":"https://github.com/onfido/onfido-sdk-ui/pull/71.diff","patch_url":"https://github.com/onfido/onfido-sdk-ui/pull/71.patch","issue_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/71","number":71,"state":"closed","locked":false,"title":"Fix/component lifecycle issue","user":{"login":"rfreitas","id":651348,"avatar_url":"https://avatars.githubusercontent.com/u/651348?v=3","gravatar_id":"","url":"https://api.github.com/users/rfreitas","html_url":"https://github.com/rfreitas","followers_url":"https://api.github.com/users/rfreitas/followers","following_url":"https://api.github.com/users/rfreitas/following{/other_user}","gists_url":"https://api.github.com/users/rfreitas/gists{/gist_id}","starred_url":"https://api.github.com/users/rfreitas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfreitas/subscriptions","organizations_url":"https://api.github.com/users/rfreitas/orgs","repos_url":"https://api.github.com/users/rfreitas/repos","events_url":"https://api.github.com/users/rfreitas/events{/privacy}","received_events_url":"https://api.github.com/users/rfreitas/received_events","type":"User","site_admin":false},"body":"This a fix for the bug #54.\r\n\r\nIt only solves the lifecycle issues for `Camera` and `Capture`.\r\n\r\nThe issue is due to `preact` not handling nested pure components well. Sibling and stateful parents often don't get lifecycle method calls if they have pure components associated with them.\r\n\r\nThe fix found was _impurify_ some components.\r\n\r\nThis is a hack/workaround and more general fix should be found.","created_at":"2016-10-06T11:01:41Z","updated_at":"2016-10-07T10:21:09Z","closed_at":"2016-10-06T14:39:42Z","merged_at":"2016-10-06T14:39:42Z","merge_commit_sha":"bdc67353c88b6efa538ab069892d053fbd39fe47","assignee":{"login":"jalba","id":4622392,"avatar_url":"https://avatars.githubusercontent.com/u/4622392?v=3","gravatar_id":"","url":"https://api.github.com/users/jalba","html_url":"https://github.com/jalba","followers_url":"https://api.github.com/users/jalba/followers","following_url":"https://api.github.com/users/jalba/following{/other_user}","gists_url":"https://api.github.com/users/jalba/gists{/gist_id}","starred_url":"https://api.github.com/users/jalba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jalba/subscriptions","organizations_url":"https://api.github.com/users/jalba/orgs","repos_url":"https://api.github.com/users/jalba/repos","events_url":"https://api.github.com/users/jalba/events{/privacy}","received_events_url":"https://api.github.com/users/jalba/received_events","type":"User","site_admin":false},"assignees":[{"login":"jalba","id":4622392,"avatar_url":"https://avatars.githubusercontent.com/u/4622392?v=3","gravatar_id":"","url":"https://api.github.com/users/jalba","html_url":"https://github.com/jalba","followers_url":"https://api.github.com/users/jalba/followers","following_url":"https://api.github.com/users/jalba/following{/other_user}","gists_url":"https://api.github.com/users/jalba/gists{/gist_id}","starred_url":"https://api.github.com/users/jalba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jalba/subscriptions","organizations_url":"https://api.github.com/users/jalba/orgs","repos_url":"https://api.github.com/users/jalba/repos","events_url":"https://api.github.com/users/jalba/events{/privacy}","received_events_url":"https://api.github.com/users/jalba/received_events","type":"User","site_admin":false},{"login":"stephencookdev","id":8496655,"avatar_url":"https://avatars.githubusercontent.com/u/8496655?v=3","gravatar_id":"","url":"https://api.github.com/users/stephencookdev","html_url":"https://github.com/stephencookdev","followers_url":"https://api.github.com/users/stephencookdev/followers","following_url":"https://api.github.com/users/stephencookdev/following{/other_user}","gists_url":"https://api.github.com/users/stephencookdev/gists{/gist_id}","starred_url":"https://api.github.com/users/stephencookdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephencookdev/subscriptions","organizations_url":"https://api.github.com/users/stephencookdev/orgs","repos_url":"https://api.github.com/users/stephencookdev/repos","events_url":"https://api.github.com/users/stephencookdev/events{/privacy}","received_events_url":"https://api.github.com/users/stephencookdev/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/71/commits","review_comments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/71/comments","review_comment_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/71/comments","statuses_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/statuses/fefeef42e1a0c3bdecf55ecd67694a92ec60c2ae","head":{"label":"onfido:fix/component-lifecycle-issue","ref":"fix/component-lifecycle-issue","sha":"fefeef42e1a0c3bdecf55ecd67694a92ec60c2ae","user":{"login":"onfido","id":6752448,"avatar_url":"https://avatars.githubusercontent.com/u/6752448?v=3","gravatar_id":"","url":"https://api.github.com/users/onfido","html_url":"https://github.com/onfido","followers_url":"https://api.github.com/users/onfido/followers","following_url":"https://api.github.com/users/onfido/following{/other_user}","gists_url":"https://api.github.com/users/onfido/gists{/gist_id}","starred_url":"https://api.github.com/users/onfido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onfido/subscriptions","organizations_url":"https://api.github.com/users/onfido/orgs","repos_url":"https://api.github.com/users/onfido/repos","events_url":"https://api.github.com/users/onfido/events{/privacy}","received_events_url":"https://api.github.com/users/onfido/received_events","type":"Organization","site_admin":false},"repo":{"id":59305266,"name":"onfido-sdk-ui","full_name":"onfido/onfido-sdk-ui","owner":{"login":"onfido","id":6752448,"avatar_url":"https://avatars.githubusercontent.com/u/6752448?v=3","gravatar_id":"","url":"https://api.github.com/users/onfido","html_url":"https://github.com/onfido","followers_url":"https://api.github.com/users/onfido/followers","following_url":"https://api.github.com/users/onfido/following{/other_user}","gists_url":"https://api.github.com/users/onfido/gists{/gist_id}","starred_url":"https://api.github.com/users/onfido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onfido/subscriptions","organizations_url":"https://api.github.com/users/onfido/orgs","repos_url":"https://api.github.com/users/onfido/repos","events_url":"https://api.github.com/users/onfido/events{/privacy}","received_events_url":"https://api.github.com/users/onfido/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onfido/onfido-sdk-ui","description":"The UI layer for the Onfido SDK","fork":false,"url":"https://api.github.com/repos/onfido/onfido-sdk-ui","forks_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/forks","keys_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/teams","hooks_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/hooks","issue_events_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/events{/number}","events_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/events","assignees_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/assignees{/user}","branches_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/branches{/branch}","tags_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/tags","blobs_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/languages","stargazers_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/stargazers","contributors_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/contributors","subscribers_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/subscribers","subscription_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/subscription","commits_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/contents/{+path}","compare_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/merges","archive_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/downloads","issues_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues{/number}","pulls_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/labels{/name}","releases_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/releases{/id}","deployments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/deployments","created_at":"2016-05-20T15:25:36Z","updated_at":"2016-09-02T17:40:12Z","pushed_at":"2016-10-07T09:55:22Z","git_url":"git://github.com/onfido/onfido-sdk-ui.git","ssh_url":"git@github.com:onfido/onfido-sdk-ui.git","clone_url":"https://github.com/onfido/onfido-sdk-ui.git","svn_url":"https://github.com/onfido/onfido-sdk-ui","homepage":null,"size":3253,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":7,"default_branch":"master"}},"base":{"label":"onfido:master","ref":"master","sha":"6d532b43a4f2d4c80f974606e96ec040d4883deb","user":{"login":"onfido","id":6752448,"avatar_url":"https://avatars.githubusercontent.com/u/6752448?v=3","gravatar_id":"","url":"https://api.github.com/users/onfido","html_url":"https://github.com/onfido","followers_url":"https://api.github.com/users/onfido/followers","following_url":"https://api.github.com/users/onfido/following{/other_user}","gists_url":"https://api.github.com/users/onfido/gists{/gist_id}","starred_url":"https://api.github.com/users/onfido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onfido/subscriptions","organizations_url":"https://api.github.com/users/onfido/orgs","repos_url":"https://api.github.com/users/onfido/repos","events_url":"https://api.github.com/users/onfido/events{/privacy}","received_events_url":"https://api.github.com/users/onfido/received_events","type":"Organization","site_admin":false},"repo":{"id":59305266,"name":"onfido-sdk-ui","full_name":"onfido/onfido-sdk-ui","owner":{"login":"onfido","id":6752448,"avatar_url":"https://avatars.githubusercontent.com/u/6752448?v=3","gravatar_id":"","url":"https://api.github.com/users/onfido","html_url":"https://github.com/onfido","followers_url":"https://api.github.com/users/onfido/followers","following_url":"https://api.github.com/users/onfido/following{/other_user}","gists_url":"https://api.github.com/users/onfido/gists{/gist_id}","starred_url":"https://api.github.com/users/onfido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onfido/subscriptions","organizations_url":"https://api.github.com/users/onfido/orgs","repos_url":"https://api.github.com/users/onfido/repos","events_url":"https://api.github.com/users/onfido/events{/privacy}","received_events_url":"https://api.github.com/users/onfido/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onfido/onfido-sdk-ui","description":"The UI layer for the Onfido SDK","fork":false,"url":"https://api.github.com/repos/onfido/onfido-sdk-ui","forks_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/forks","keys_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/teams","hooks_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/hooks","issue_events_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/events{/number}","events_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/events","assignees_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/assignees{/user}","branches_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/branches{/branch}","tags_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/tags","blobs_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/languages","stargazers_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/stargazers","contributors_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/contributors","subscribers_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/subscribers","subscription_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/subscription","commits_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/contents/{+path}","compare_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/merges","archive_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/downloads","issues_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues{/number}","pulls_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/labels{/name}","releases_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/releases{/id}","deployments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/deployments","created_at":"2016-05-20T15:25:36Z","updated_at":"2016-09-02T17:40:12Z","pushed_at":"2016-10-07T09:55:22Z","git_url":"git://github.com/onfido/onfido-sdk-ui.git","ssh_url":"git@github.com:onfido/onfido-sdk-ui.git","clone_url":"https://github.com/onfido/onfido-sdk-ui.git","svn_url":"https://github.com/onfido/onfido-sdk-ui","homepage":null,"size":3253,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/71"},"html":{"href":"https://github.com/onfido/onfido-sdk-ui/pull/71"},"issue":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/71"},"comments":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/statuses/fefeef42e1a0c3bdecf55ecd67694a92ec60c2ae"}}}}
{"actor":{"display_login":"rfreitas"}}