{"action":"created","comment":{"url":"https://api.github.com/repos/sdelements/sdetools/pulls/comments/52465687","id":52465687,"diff_hunk":"@@ -217,10 +219,17 @@ def generate_token_auth_header(self):\n \n     def urlencode(self, args):\n         \"\"\"\n+        Smart url-encode. Given a string, returns the string urlencoded in a UTF8\n+        compatible way. If given a dict, returns a url string of the args encoded\n         Unicode friendly wrapper around urlencode\n         \"\"\"\n-        encoded_args = self.encode_dict_utf8(args)\n-        return urllib.urlencode(encoded_args)\n+        if isinstance(args, basestring):\n+            return urlencode_str(args)\n+        elif isinstance(args, dict):\n+            encoded_args = self.encode_dict_utf8(args)\n+            return urllib.urlencode(encoded_args)\n+        raise TypeError(\"Unexpected Data type, expects dict or string type\")\n+","path":"sdetools/sdelib/restclient.py","position":47,"original_position":47,"commit_id":"d91a2b5d442be91800791407e55bce2974b20056","original_commit_id":"d91a2b5d442be91800791407e55bce2974b20056","user":{"login":"lmontopo","id":8933459,"avatar_url":"https://avatars.githubusercontent.com/u/8933459?v=3","gravatar_id":"","url":"https://api.github.com/users/lmontopo","html_url":"https://github.com/lmontopo","followers_url":"https://api.github.com/users/lmontopo/followers","following_url":"https://api.github.com/users/lmontopo/following{/other_user}","gists_url":"https://api.github.com/users/lmontopo/gists{/gist_id}","starred_url":"https://api.github.com/users/lmontopo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmontopo/subscriptions","organizations_url":"https://api.github.com/users/lmontopo/orgs","repos_url":"https://api.github.com/users/lmontopo/repos","events_url":"https://api.github.com/users/lmontopo/events{/privacy}","received_events_url":"https://api.github.com/users/lmontopo/received_events","type":"User","site_admin":false},"body":"remove extra blank line. ","created_at":"2016-02-10T14:45:35Z","updated_at":"2016-02-10T14:45:35Z","html_url":"https://github.com/sdelements/sdetools/pull/332#discussion_r52465687","pull_request_url":"https://api.github.com/repos/sdelements/sdetools/pulls/332","_links":{"self":{"href":"https://api.github.com/repos/sdelements/sdetools/pulls/comments/52465687"},"html":{"href":"https://github.com/sdelements/sdetools/pull/332#discussion_r52465687"},"pull_request":{"href":"https://api.github.com/repos/sdelements/sdetools/pulls/332"}}},"pull_request":{"url":"https://api.github.com/repos/sdelements/sdetools/pulls/332","id":58813244,"html_url":"https://github.com/sdelements/sdetools/pull/332","diff_url":"https://github.com/sdelements/sdetools/pull/332.diff","patch_url":"https://github.com/sdelements/sdetools/pull/332.patch","issue_url":"https://api.github.com/repos/sdelements/sdetools/issues/332","number":332,"state":"open","locked":false,"title":"Fixes issues with urlencode_str","user":{"login":"JeffBain","id":164910,"avatar_url":"https://avatars.githubusercontent.com/u/164910?v=3","gravatar_id":"","url":"https://api.github.com/users/JeffBain","html_url":"https://github.com/JeffBain","followers_url":"https://api.github.com/users/JeffBain/followers","following_url":"https://api.github.com/users/JeffBain/following{/other_user}","gists_url":"https://api.github.com/users/JeffBain/gists{/gist_id}","starred_url":"https://api.github.com/users/JeffBain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeffBain/subscriptions","organizations_url":"https://api.github.com/users/JeffBain/orgs","repos_url":"https://api.github.com/users/JeffBain/repos","events_url":"https://api.github.com/users/JeffBain/events{/privacy}","received_events_url":"https://api.github.com/users/JeffBain/received_events","type":"User","site_admin":false},"body":"    * We make all uses of urlencode_str unicode-friendly, which should fix issues\r\n      with unicode in tasks etc. that our original fixes didn't catch\r\n\r\nRefs SDE-1795","created_at":"2016-02-09T21:43:07Z","updated_at":"2016-02-10T14:45:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d50a12ce0a1fb9a379e75a08f3dfa33d43a0930","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sdelements/sdetools/pulls/332/commits","review_comments_url":"https://api.github.com/repos/sdelements/sdetools/pulls/332/comments","review_comment_url":"https://api.github.com/repos/sdelements/sdetools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sdelements/sdetools/issues/332/comments","statuses_url":"https://api.github.com/repos/sdelements/sdetools/statuses/d91a2b5d442be91800791407e55bce2974b20056","head":{"label":"sdelements:fix/SDE-1795_unicode_issues_2","ref":"fix/SDE-1795_unicode_issues_2","sha":"d91a2b5d442be91800791407e55bce2974b20056","user":{"login":"sdelements","id":739346,"avatar_url":"https://avatars.githubusercontent.com/u/739346?v=3","gravatar_id":"","url":"https://api.github.com/users/sdelements","html_url":"https://github.com/sdelements","followers_url":"https://api.github.com/users/sdelements/followers","following_url":"https://api.github.com/users/sdelements/following{/other_user}","gists_url":"https://api.github.com/users/sdelements/gists{/gist_id}","starred_url":"https://api.github.com/users/sdelements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdelements/subscriptions","organizations_url":"https://api.github.com/users/sdelements/orgs","repos_url":"https://api.github.com/users/sdelements/repos","events_url":"https://api.github.com/users/sdelements/events{/privacy}","received_events_url":"https://api.github.com/users/sdelements/received_events","type":"Organization","site_admin":false},"repo":{"id":4272561,"name":"sdetools","full_name":"sdelements/sdetools","owner":{"login":"sdelements","id":739346,"avatar_url":"https://avatars.githubusercontent.com/u/739346?v=3","gravatar_id":"","url":"https://api.github.com/users/sdelements","html_url":"https://github.com/sdelements","followers_url":"https://api.github.com/users/sdelements/followers","following_url":"https://api.github.com/users/sdelements/following{/other_user}","gists_url":"https://api.github.com/users/sdelements/gists{/gist_id}","starred_url":"https://api.github.com/users/sdelements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdelements/subscriptions","organizations_url":"https://api.github.com/users/sdelements/orgs","repos_url":"https://api.github.com/users/sdelements/repos","events_url":"https://api.github.com/users/sdelements/events{/privacy}","received_events_url":"https://api.github.com/users/sdelements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sdelements/sdetools","description":"SD Element Tools: A collection of SD Elements integration tools built around SD Elements API.","fork":false,"url":"https://api.github.com/repos/sdelements/sdetools","forks_url":"https://api.github.com/repos/sdelements/sdetools/forks","keys_url":"https://api.github.com/repos/sdelements/sdetools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdelements/sdetools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdelements/sdetools/teams","hooks_url":"https://api.github.com/repos/sdelements/sdetools/hooks","issue_events_url":"https://api.github.com/repos/sdelements/sdetools/issues/events{/number}","events_url":"https://api.github.com/repos/sdelements/sdetools/events","assignees_url":"https://api.github.com/repos/sdelements/sdetools/assignees{/user}","branches_url":"https://api.github.com/repos/sdelements/sdetools/branches{/branch}","tags_url":"https://api.github.com/repos/sdelements/sdetools/tags","blobs_url":"https://api.github.com/repos/sdelements/sdetools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdelements/sdetools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdelements/sdetools/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdelements/sdetools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdelements/sdetools/statuses/{sha}","languages_url":"https://api.github.com/repos/sdelements/sdetools/languages","stargazers_url":"https://api.github.com/repos/sdelements/sdetools/stargazers","contributors_url":"https://api.github.com/repos/sdelements/sdetools/contributors","subscribers_url":"https://api.github.com/repos/sdelements/sdetools/subscribers","subscription_url":"https://api.github.com/repos/sdelements/sdetools/subscription","commits_url":"https://api.github.com/repos/sdelements/sdetools/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdelements/sdetools/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdelements/sdetools/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdelements/sdetools/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdelements/sdetools/contents/{+path}","compare_url":"https://api.github.com/repos/sdelements/sdetools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdelements/sdetools/merges","archive_url":"https://api.github.com/repos/sdelements/sdetools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdelements/sdetools/downloads","issues_url":"https://api.github.com/repos/sdelements/sdetools/issues{/number}","pulls_url":"https://api.github.com/repos/sdelements/sdetools/pulls{/number}","milestones_url":"https://api.github.com/repos/sdelements/sdetools/milestones{/number}","notifications_url":"https://api.github.com/repos/sdelements/sdetools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdelements/sdetools/labels{/name}","releases_url":"https://api.github.com/repos/sdelements/sdetools/releases{/id}","deployments_url":"https://api.github.com/repos/sdelements/sdetools/deployments","created_at":"2012-05-09T14:33:34Z","updated_at":"2016-01-26T12:43:59Z","pushed_at":"2016-02-09T21:53:45Z","git_url":"git://github.com/sdelements/sdetools.git","ssh_url":"git@github.com:sdelements/sdetools.git","clone_url":"https://github.com/sdelements/sdetools.git","svn_url":"https://github.com/sdelements/sdetools","homepage":"https://travis-ci.org/sdelements/sdetools","size":10848,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":21,"forks":3,"open_issues":21,"watchers":10,"default_branch":"master"}},"base":{"label":"sdelements:master","ref":"master","sha":"1efe46fe0baf1dc5e13bf1589079d690ed5aa3ce","user":{"login":"sdelements","id":739346,"avatar_url":"https://avatars.githubusercontent.com/u/739346?v=3","gravatar_id":"","url":"https://api.github.com/users/sdelements","html_url":"https://github.com/sdelements","followers_url":"https://api.github.com/users/sdelements/followers","following_url":"https://api.github.com/users/sdelements/following{/other_user}","gists_url":"https://api.github.com/users/sdelements/gists{/gist_id}","starred_url":"https://api.github.com/users/sdelements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdelements/subscriptions","organizations_url":"https://api.github.com/users/sdelements/orgs","repos_url":"https://api.github.com/users/sdelements/repos","events_url":"https://api.github.com/users/sdelements/events{/privacy}","received_events_url":"https://api.github.com/users/sdelements/received_events","type":"Organization","site_admin":false},"repo":{"id":4272561,"name":"sdetools","full_name":"sdelements/sdetools","owner":{"login":"sdelements","id":739346,"avatar_url":"https://avatars.githubusercontent.com/u/739346?v=3","gravatar_id":"","url":"https://api.github.com/users/sdelements","html_url":"https://github.com/sdelements","followers_url":"https://api.github.com/users/sdelements/followers","following_url":"https://api.github.com/users/sdelements/following{/other_user}","gists_url":"https://api.github.com/users/sdelements/gists{/gist_id}","starred_url":"https://api.github.com/users/sdelements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdelements/subscriptions","organizations_url":"https://api.github.com/users/sdelements/orgs","repos_url":"https://api.github.com/users/sdelements/repos","events_url":"https://api.github.com/users/sdelements/events{/privacy}","received_events_url":"https://api.github.com/users/sdelements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sdelements/sdetools","description":"SD Element Tools: A collection of SD Elements integration tools built around SD Elements API.","fork":false,"url":"https://api.github.com/repos/sdelements/sdetools","forks_url":"https://api.github.com/repos/sdelements/sdetools/forks","keys_url":"https://api.github.com/repos/sdelements/sdetools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdelements/sdetools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdelements/sdetools/teams","hooks_url":"https://api.github.com/repos/sdelements/sdetools/hooks","issue_events_url":"https://api.github.com/repos/sdelements/sdetools/issues/events{/number}","events_url":"https://api.github.com/repos/sdelements/sdetools/events","assignees_url":"https://api.github.com/repos/sdelements/sdetools/assignees{/user}","branches_url":"https://api.github.com/repos/sdelements/sdetools/branches{/branch}","tags_url":"https://api.github.com/repos/sdelements/sdetools/tags","blobs_url":"https://api.github.com/repos/sdelements/sdetools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdelements/sdetools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdelements/sdetools/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdelements/sdetools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdelements/sdetools/statuses/{sha}","languages_url":"https://api.github.com/repos/sdelements/sdetools/languages","stargazers_url":"https://api.github.com/repos/sdelements/sdetools/stargazers","contributors_url":"https://api.github.com/repos/sdelements/sdetools/contributors","subscribers_url":"https://api.github.com/repos/sdelements/sdetools/subscribers","subscription_url":"https://api.github.com/repos/sdelements/sdetools/subscription","commits_url":"https://api.github.com/repos/sdelements/sdetools/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdelements/sdetools/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdelements/sdetools/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdelements/sdetools/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdelements/sdetools/contents/{+path}","compare_url":"https://api.github.com/repos/sdelements/sdetools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdelements/sdetools/merges","archive_url":"https://api.github.com/repos/sdelements/sdetools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdelements/sdetools/downloads","issues_url":"https://api.github.com/repos/sdelements/sdetools/issues{/number}","pulls_url":"https://api.github.com/repos/sdelements/sdetools/pulls{/number}","milestones_url":"https://api.github.com/repos/sdelements/sdetools/milestones{/number}","notifications_url":"https://api.github.com/repos/sdelements/sdetools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdelements/sdetools/labels{/name}","releases_url":"https://api.github.com/repos/sdelements/sdetools/releases{/id}","deployments_url":"https://api.github.com/repos/sdelements/sdetools/deployments","created_at":"2012-05-09T14:33:34Z","updated_at":"2016-01-26T12:43:59Z","pushed_at":"2016-02-09T21:53:45Z","git_url":"git://github.com/sdelements/sdetools.git","ssh_url":"git@github.com:sdelements/sdetools.git","clone_url":"https://github.com/sdelements/sdetools.git","svn_url":"https://github.com/sdelements/sdetools","homepage":"https://travis-ci.org/sdelements/sdetools","size":10848,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":21,"forks":3,"open_issues":21,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sdelements/sdetools/pulls/332"},"html":{"href":"https://github.com/sdelements/sdetools/pull/332"},"issue":{"href":"https://api.github.com/repos/sdelements/sdetools/issues/332"},"comments":{"href":"https://api.github.com/repos/sdelements/sdetools/issues/332/comments"},"review_comments":{"href":"https://api.github.com/repos/sdelements/sdetools/pulls/332/comments"},"review_comment":{"href":"https://api.github.com/repos/sdelements/sdetools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sdelements/sdetools/pulls/332/commits"},"statuses":{"href":"https://api.github.com/repos/sdelements/sdetools/statuses/d91a2b5d442be91800791407e55bce2974b20056"}}}}