{"action":"created","comment":{"url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/comments/81990079","pull_request_review_id":2928871,"id":81990079,"diff_hunk":"@@ -146,11 +150,10 @@ function OutputStream(options) {\n               case \"\\b\": return \"\\\\b\";\n               case \"\\f\": return \"\\\\f\";\n               case \"\\x0B\": return options.screw_ie8 ? \"\\\\v\" : \"\\\\x0B\";\n-              case \"\\u2028\": return \"\\\\u2028\";\n-              case \"\\u2029\": return \"\\\\u2029\";\n-              case \"\\ufeff\": return \"\\\\ufeff\";\n               case \"\\0\":\n                   return /[0-7]/.test(str.charAt(i+1)) ? \"\\\\x00\" : \"\\\\0\";\n+              default:\n+                  return to_ascii(s);","path":"lib/output.js","position":30,"original_position":30,"commit_id":"41ad14e6fac98828a2c2e0cdacd364417413a193","original_commit_id":"41ad14e6fac98828a2c2e0cdacd364417413a193","user":{"login":"stefanbethke","id":3328988,"avatar_url":"https://avatars.githubusercontent.com/u/3328988?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanbethke","html_url":"https://github.com/stefanbethke","followers_url":"https://api.github.com/users/stefanbethke/followers","following_url":"https://api.github.com/users/stefanbethke/following{/other_user}","gists_url":"https://api.github.com/users/stefanbethke/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanbethke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanbethke/subscriptions","organizations_url":"https://api.github.com/users/stefanbethke/orgs","repos_url":"https://api.github.com/users/stefanbethke/repos","events_url":"https://api.github.com/users/stefanbethke/events{/privacy}","received_events_url":"https://api.github.com/users/stefanbethke/received_events","type":"User","site_admin":false},"body":"Sorry about that, that's a really stupid oversight on my part. I'll push a fix as soon as I can figure out how to test \\u2028 properly, which now is correctly converted to a literal in ascii.js::ascii_only_false. Setting expect_exact to \"...\\u2028...\" results in a JS_Parse_Error.","created_at":"2016-10-05T14:47:44Z","updated_at":"2016-10-05T14:47:44Z","html_url":"https://github.com/mishoo/UglifyJS2/pull/1311#discussion_r81990079","pull_request_url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/1311","_links":{"self":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/comments/81990079"},"html":{"href":"https://github.com/mishoo/UglifyJS2/pull/1311#discussion_r81990079"},"pull_request":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/1311"}}},"pull_request":{"url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/1311","id":87518530,"html_url":"https://github.com/mishoo/UglifyJS2/pull/1311","diff_url":"https://github.com/mishoo/UglifyJS2/pull/1311.diff","patch_url":"https://github.com/mishoo/UglifyJS2/pull/1311.patch","issue_url":"https://api.github.com/repos/mishoo/UglifyJS2/issues/1311","number":1311,"state":"open","locked":false,"title":"Enable uglification of slevithan/xregexp","user":{"login":"stefanbethke","id":3328988,"avatar_url":"https://avatars.githubusercontent.com/u/3328988?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanbethke","html_url":"https://github.com/stefanbethke","followers_url":"https://api.github.com/users/stefanbethke/followers","following_url":"https://api.github.com/users/stefanbethke/following{/other_user}","gists_url":"https://api.github.com/users/stefanbethke/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanbethke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanbethke/subscriptions","organizations_url":"https://api.github.com/users/stefanbethke/orgs","repos_url":"https://api.github.com/users/stefanbethke/repos","events_url":"https://api.github.com/users/stefanbethke/events{/privacy}","received_events_url":"https://api.github.com/users/stefanbethke/received_events","type":"User","site_admin":false},"body":"The XRegExp library translates Unicode-aware regexps into native JS expressions.  To do so, it uses escaped literals a lot, including code points that are Unicode noncharacters. While the uglified code can be loaded in browser and appears to be working properly, the uglified file will contain noncharacter literals.\r\n\r\nIf the uglified file is loaded into a system that does verify correct UTF-8 encoding, errors occur. For example, certain content management systems wrap resources in XML files, and Java XML parsers often complain about invalid Unicode codepoints or UTF-8 sequences.\r\n\r\nThis change is not a comprehensive solution, but will properly keep all Unicode noncharacters used by XRegExp in their escaped form.","created_at":"2016-09-30T15:48:35Z","updated_at":"2016-10-05T14:47:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"695f9b87a9daae69da234b4adde867bed871482f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/1311/commits","review_comments_url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/1311/comments","review_comment_url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mishoo/UglifyJS2/issues/1311/comments","statuses_url":"https://api.github.com/repos/mishoo/UglifyJS2/statuses/41ad14e6fac98828a2c2e0cdacd364417413a193","head":{"label":"stefanbethke:master","ref":"master","sha":"41ad14e6fac98828a2c2e0cdacd364417413a193","user":{"login":"stefanbethke","id":3328988,"avatar_url":"https://avatars.githubusercontent.com/u/3328988?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanbethke","html_url":"https://github.com/stefanbethke","followers_url":"https://api.github.com/users/stefanbethke/followers","following_url":"https://api.github.com/users/stefanbethke/following{/other_user}","gists_url":"https://api.github.com/users/stefanbethke/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanbethke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanbethke/subscriptions","organizations_url":"https://api.github.com/users/stefanbethke/orgs","repos_url":"https://api.github.com/users/stefanbethke/repos","events_url":"https://api.github.com/users/stefanbethke/events{/privacy}","received_events_url":"https://api.github.com/users/stefanbethke/received_events","type":"User","site_admin":false},"repo":{"id":69656371,"name":"UglifyJS2","full_name":"stefanbethke/UglifyJS2","owner":{"login":"stefanbethke","id":3328988,"avatar_url":"https://avatars.githubusercontent.com/u/3328988?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanbethke","html_url":"https://github.com/stefanbethke","followers_url":"https://api.github.com/users/stefanbethke/followers","following_url":"https://api.github.com/users/stefanbethke/following{/other_user}","gists_url":"https://api.github.com/users/stefanbethke/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanbethke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanbethke/subscriptions","organizations_url":"https://api.github.com/users/stefanbethke/orgs","repos_url":"https://api.github.com/users/stefanbethke/repos","events_url":"https://api.github.com/users/stefanbethke/events{/privacy}","received_events_url":"https://api.github.com/users/stefanbethke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stefanbethke/UglifyJS2","description":" JavaScript parser / mangler / compressor / beautifier toolkit","fork":true,"url":"https://api.github.com/repos/stefanbethke/UglifyJS2","forks_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/forks","keys_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/teams","hooks_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/hooks","issue_events_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/issues/events{/number}","events_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/events","assignees_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/assignees{/user}","branches_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/branches{/branch}","tags_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/tags","blobs_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/git/refs{/sha}","trees_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/statuses/{sha}","languages_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/languages","stargazers_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/stargazers","contributors_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/contributors","subscribers_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/subscribers","subscription_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/subscription","commits_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/commits{/sha}","git_commits_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/git/commits{/sha}","comments_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/comments{/number}","issue_comment_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/issues/comments{/number}","contents_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/contents/{+path}","compare_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/merges","archive_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/downloads","issues_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/issues{/number}","pulls_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/pulls{/number}","milestones_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/milestones{/number}","notifications_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/labels{/name}","releases_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/releases{/id}","deployments_url":"https://api.github.com/repos/stefanbethke/UglifyJS2/deployments","created_at":"2016-09-30T10:08:38Z","updated_at":"2016-09-30T10:08:40Z","pushed_at":"2016-10-04T16:56:13Z","git_url":"git://github.com/stefanbethke/UglifyJS2.git","ssh_url":"git@github.com:stefanbethke/UglifyJS2.git","clone_url":"https://github.com/stefanbethke/UglifyJS2.git","svn_url":"https://github.com/stefanbethke/UglifyJS2","homepage":"http://lisperator.net/uglifyjs/","size":2217,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mishoo:master","ref":"master","sha":"0111497fc98d5098f81bc749f77da5734add37bb","user":{"login":"mishoo","id":334725,"avatar_url":"https://avatars.githubusercontent.com/u/334725?v=3","gravatar_id":"","url":"https://api.github.com/users/mishoo","html_url":"https://github.com/mishoo","followers_url":"https://api.github.com/users/mishoo/followers","following_url":"https://api.github.com/users/mishoo/following{/other_user}","gists_url":"https://api.github.com/users/mishoo/gists{/gist_id}","starred_url":"https://api.github.com/users/mishoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishoo/subscriptions","organizations_url":"https://api.github.com/users/mishoo/orgs","repos_url":"https://api.github.com/users/mishoo/repos","events_url":"https://api.github.com/users/mishoo/events{/privacy}","received_events_url":"https://api.github.com/users/mishoo/received_events","type":"User","site_admin":false},"repo":{"id":5569059,"name":"UglifyJS2","full_name":"mishoo/UglifyJS2","owner":{"login":"mishoo","id":334725,"avatar_url":"https://avatars.githubusercontent.com/u/334725?v=3","gravatar_id":"","url":"https://api.github.com/users/mishoo","html_url":"https://github.com/mishoo","followers_url":"https://api.github.com/users/mishoo/followers","following_url":"https://api.github.com/users/mishoo/following{/other_user}","gists_url":"https://api.github.com/users/mishoo/gists{/gist_id}","starred_url":"https://api.github.com/users/mishoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishoo/subscriptions","organizations_url":"https://api.github.com/users/mishoo/orgs","repos_url":"https://api.github.com/users/mishoo/repos","events_url":"https://api.github.com/users/mishoo/events{/privacy}","received_events_url":"https://api.github.com/users/mishoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mishoo/UglifyJS2","description":" JavaScript parser / mangler / compressor / beautifier toolkit","fork":false,"url":"https://api.github.com/repos/mishoo/UglifyJS2","forks_url":"https://api.github.com/repos/mishoo/UglifyJS2/forks","keys_url":"https://api.github.com/repos/mishoo/UglifyJS2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mishoo/UglifyJS2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mishoo/UglifyJS2/teams","hooks_url":"https://api.github.com/repos/mishoo/UglifyJS2/hooks","issue_events_url":"https://api.github.com/repos/mishoo/UglifyJS2/issues/events{/number}","events_url":"https://api.github.com/repos/mishoo/UglifyJS2/events","assignees_url":"https://api.github.com/repos/mishoo/UglifyJS2/assignees{/user}","branches_url":"https://api.github.com/repos/mishoo/UglifyJS2/branches{/branch}","tags_url":"https://api.github.com/repos/mishoo/UglifyJS2/tags","blobs_url":"https://api.github.com/repos/mishoo/UglifyJS2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mishoo/UglifyJS2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mishoo/UglifyJS2/git/refs{/sha}","trees_url":"https://api.github.com/repos/mishoo/UglifyJS2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mishoo/UglifyJS2/statuses/{sha}","languages_url":"https://api.github.com/repos/mishoo/UglifyJS2/languages","stargazers_url":"https://api.github.com/repos/mishoo/UglifyJS2/stargazers","contributors_url":"https://api.github.com/repos/mishoo/UglifyJS2/contributors","subscribers_url":"https://api.github.com/repos/mishoo/UglifyJS2/subscribers","subscription_url":"https://api.github.com/repos/mishoo/UglifyJS2/subscription","commits_url":"https://api.github.com/repos/mishoo/UglifyJS2/commits{/sha}","git_commits_url":"https://api.github.com/repos/mishoo/UglifyJS2/git/commits{/sha}","comments_url":"https://api.github.com/repos/mishoo/UglifyJS2/comments{/number}","issue_comment_url":"https://api.github.com/repos/mishoo/UglifyJS2/issues/comments{/number}","contents_url":"https://api.github.com/repos/mishoo/UglifyJS2/contents/{+path}","compare_url":"https://api.github.com/repos/mishoo/UglifyJS2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mishoo/UglifyJS2/merges","archive_url":"https://api.github.com/repos/mishoo/UglifyJS2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mishoo/UglifyJS2/downloads","issues_url":"https://api.github.com/repos/mishoo/UglifyJS2/issues{/number}","pulls_url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls{/number}","milestones_url":"https://api.github.com/repos/mishoo/UglifyJS2/milestones{/number}","notifications_url":"https://api.github.com/repos/mishoo/UglifyJS2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mishoo/UglifyJS2/labels{/name}","releases_url":"https://api.github.com/repos/mishoo/UglifyJS2/releases{/id}","deployments_url":"https://api.github.com/repos/mishoo/UglifyJS2/deployments","created_at":"2012-08-27T09:31:03Z","updated_at":"2016-10-05T11:22:07Z","pushed_at":"2016-10-05T12:52:16Z","git_url":"git://github.com/mishoo/UglifyJS2.git","ssh_url":"git@github.com:mishoo/UglifyJS2.git","clone_url":"https://github.com/mishoo/UglifyJS2.git","svn_url":"https://github.com/mishoo/UglifyJS2","homepage":"http://lisperator.net/uglifyjs/","size":3980,"stargazers_count":5449,"watchers_count":5449,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":605,"mirror_url":null,"open_issues_count":262,"forks":605,"open_issues":262,"watchers":5449,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/1311"},"html":{"href":"https://github.com/mishoo/UglifyJS2/pull/1311"},"issue":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/issues/1311"},"comments":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/issues/1311/comments"},"review_comments":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/1311/comments"},"review_comment":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/1311/commits"},"statuses":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/statuses/41ad14e6fac98828a2c2e0cdacd364417413a193"}}}}
{"actor":{"display_login":"stefanbethke"}}