{"action":"created","comment":{"url":"https://api.github.com/repos/RackHD/on-tasks/pulls/comments/63644565","id":63644565,"diff_hunk":"@@ -152,6 +154,77 @@ describe('Install OS Job', function () {\n         );\n     });\n \n+    describe('test _validateOptions', function() {\n+        it('should correct fsType when mountPoint is swap but fsType is wrong', function() {\n+            var options = {\n+                    profile: 'testprofile',\n+                    completionUri: '',\n+                    installPartitions: [\n+                    {\n+                        \"mountPoint\": \"swap\",\n+                        \"size\": \"500\",\n+                        \"fsType\": \"ext3\"\n+                    }\n+                    ]\n+                };\n+            var job = new InstallOsJob(options, {target: 'testid'}, uuid.v4());\n+            expect(job.options.installPartitions[0].fsType).to.equal('swap');\n+        });\n+\n+        it('should fail when mountPoint type is not correct', function() {\n+            var options = {\n+                    profile: 'testprofile',\n+                    completionUri: '',\n+                    installPartitions: [\n+                    {\n+                        \"mountPoint\": {},\n+                        \"size\": \"500\",\n+                        \"fsType\": \"ext3\"\n+                    }\n+                    ]\n+                };\n+            expect(function() {\n+                var job = new InstallOsJob(options, {target: 'testid'}, uuid.v4());\n+            }).to.throw(Errors.AssertionError, /undefined/);\n+        });\n+\n+        it('should fail when size type is not correct', function() {\n+            var options = {\n+                    profile: 'testprofile',\n+                    completionUri: '',\n+                    installPartitions: [\n+                    {\n+                        \"mountPoint\": \"/boot\",\n+                        \"size\": {},\n+                        \"fsType\": \"ext3\"\n+                    }\n+                    ]\n+                };\n+            expect(function() {\n+                var job = new InstallOsJob(options, {target: 'testid'}, uuid.v4());","path":"spec/lib/jobs/install-os-job-spec.js","position":50,"original_position":67,"commit_id":"5efffbc5843160984a47ff99b20c74c1fe0d6b25","original_commit_id":"5efffbc5843160984a47ff99b20c74c1fe0d6b25","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"'job' is defined but never used.","created_at":"2016-05-18T04:49:20Z","updated_at":"2016-05-18T04:49:20Z","html_url":"https://github.com/RackHD/on-tasks/pull/213#discussion_r63644565","pull_request_url":"https://api.github.com/repos/RackHD/on-tasks/pulls/213","_links":{"self":{"href":"https://api.github.com/repos/RackHD/on-tasks/pulls/comments/63644565"},"html":{"href":"https://github.com/RackHD/on-tasks/pull/213#discussion_r63644565"},"pull_request":{"href":"https://api.github.com/repos/RackHD/on-tasks/pulls/213"}}},"pull_request":{"url":"https://api.github.com/repos/RackHD/on-tasks/pulls/213","id":70339483,"html_url":"https://github.com/RackHD/on-tasks/pull/213","diff_url":"https://github.com/RackHD/on-tasks/pull/213.diff","patch_url":"https://github.com/RackHD/on-tasks/pull/213.patch","issue_url":"https://api.github.com/repos/RackHD/on-tasks/issues/213","number":213,"state":"open","locked":false,"title":"Add partitioning support for os installation","user":{"login":"anhou","id":14013330,"avatar_url":"https://avatars.githubusercontent.com/u/14013330?v=3","gravatar_id":"","url":"https://api.github.com/users/anhou","html_url":"https://github.com/anhou","followers_url":"https://api.github.com/users/anhou/followers","following_url":"https://api.github.com/users/anhou/following{/other_user}","gists_url":"https://api.github.com/users/anhou/gists{/gist_id}","starred_url":"https://api.github.com/users/anhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anhou/subscriptions","organizations_url":"https://api.github.com/users/anhou/orgs","repos_url":"https://api.github.com/users/anhou/repos","events_url":"https://api.github.com/users/anhou/events{/privacy}","received_events_url":"https://api.github.com/users/anhou/received_events","type":"User","site_admin":false},"body":"temporarily only support CentOS, CentOS is a starting point, other Linux OS will be added\r\nmore description, please see docs PR: https://github.com/RackHD/docs/pull/278\r\nrelated PR: https://github.com/RackHD/on-tasks/pull/285\r\n\r\nalso address ODR-654 https://hwjiraprd01.corp.emc.com/browse/ODR-654\r\n\r\n@RackHD/corecommitters @RackHD/rackhd_dev ","created_at":"2016-05-17T11:17:27Z","updated_at":"2016-05-18T04:49:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49b88b8b8a711d947da48bd9bf90cc771199a929","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RackHD/on-tasks/pulls/213/commits","review_comments_url":"https://api.github.com/repos/RackHD/on-tasks/pulls/213/comments","review_comment_url":"https://api.github.com/repos/RackHD/on-tasks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RackHD/on-tasks/issues/213/comments","statuses_url":"https://api.github.com/repos/RackHD/on-tasks/statuses/5efffbc5843160984a47ff99b20c74c1fe0d6b25","head":{"label":"anhou:feature/partitioning","ref":"feature/partitioning","sha":"5efffbc5843160984a47ff99b20c74c1fe0d6b25","user":{"login":"anhou","id":14013330,"avatar_url":"https://avatars.githubusercontent.com/u/14013330?v=3","gravatar_id":"","url":"https://api.github.com/users/anhou","html_url":"https://github.com/anhou","followers_url":"https://api.github.com/users/anhou/followers","following_url":"https://api.github.com/users/anhou/following{/other_user}","gists_url":"https://api.github.com/users/anhou/gists{/gist_id}","starred_url":"https://api.github.com/users/anhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anhou/subscriptions","organizations_url":"https://api.github.com/users/anhou/orgs","repos_url":"https://api.github.com/users/anhou/repos","events_url":"https://api.github.com/users/anhou/events{/privacy}","received_events_url":"https://api.github.com/users/anhou/received_events","type":"User","site_admin":false},"repo":{"id":48165152,"name":"on-tasks","full_name":"anhou/on-tasks","owner":{"login":"anhou","id":14013330,"avatar_url":"https://avatars.githubusercontent.com/u/14013330?v=3","gravatar_id":"","url":"https://api.github.com/users/anhou","html_url":"https://github.com/anhou","followers_url":"https://api.github.com/users/anhou/followers","following_url":"https://api.github.com/users/anhou/following{/other_user}","gists_url":"https://api.github.com/users/anhou/gists{/gist_id}","starred_url":"https://api.github.com/users/anhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anhou/subscriptions","organizations_url":"https://api.github.com/users/anhou/orgs","repos_url":"https://api.github.com/users/anhou/repos","events_url":"https://api.github.com/users/anhou/events{/privacy}","received_events_url":"https://api.github.com/users/anhou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anhou/on-tasks","description":"","fork":true,"url":"https://api.github.com/repos/anhou/on-tasks","forks_url":"https://api.github.com/repos/anhou/on-tasks/forks","keys_url":"https://api.github.com/repos/anhou/on-tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anhou/on-tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anhou/on-tasks/teams","hooks_url":"https://api.github.com/repos/anhou/on-tasks/hooks","issue_events_url":"https://api.github.com/repos/anhou/on-tasks/issues/events{/number}","events_url":"https://api.github.com/repos/anhou/on-tasks/events","assignees_url":"https://api.github.com/repos/anhou/on-tasks/assignees{/user}","branches_url":"https://api.github.com/repos/anhou/on-tasks/branches{/branch}","tags_url":"https://api.github.com/repos/anhou/on-tasks/tags","blobs_url":"https://api.github.com/repos/anhou/on-tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anhou/on-tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anhou/on-tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/anhou/on-tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anhou/on-tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/anhou/on-tasks/languages","stargazers_url":"https://api.github.com/repos/anhou/on-tasks/stargazers","contributors_url":"https://api.github.com/repos/anhou/on-tasks/contributors","subscribers_url":"https://api.github.com/repos/anhou/on-tasks/subscribers","subscription_url":"https://api.github.com/repos/anhou/on-tasks/subscription","commits_url":"https://api.github.com/repos/anhou/on-tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/anhou/on-tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/anhou/on-tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/anhou/on-tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/anhou/on-tasks/contents/{+path}","compare_url":"https://api.github.com/repos/anhou/on-tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anhou/on-tasks/merges","archive_url":"https://api.github.com/repos/anhou/on-tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anhou/on-tasks/downloads","issues_url":"https://api.github.com/repos/anhou/on-tasks/issues{/number}","pulls_url":"https://api.github.com/repos/anhou/on-tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/anhou/on-tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/anhou/on-tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anhou/on-tasks/labels{/name}","releases_url":"https://api.github.com/repos/anhou/on-tasks/releases{/id}","deployments_url":"https://api.github.com/repos/anhou/on-tasks/deployments","created_at":"2015-12-17T09:30:09Z","updated_at":"2015-12-17T09:30:11Z","pushed_at":"2016-05-18T04:49:10Z","git_url":"git://github.com/anhou/on-tasks.git","ssh_url":"git@github.com:anhou/on-tasks.git","clone_url":"https://github.com/anhou/on-tasks.git","svn_url":"https://github.com/anhou/on-tasks","homepage":null,"size":1321,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RackHD:master","ref":"master","sha":"177f5f04ae97af259c66ca9f97634d38e2ffa5d1","user":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars.githubusercontent.com/u/13982662?v=3","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"repo":{"id":41690099,"name":"on-tasks","full_name":"RackHD/on-tasks","owner":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars.githubusercontent.com/u/13982662?v=3","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RackHD/on-tasks","description":"","fork":false,"url":"https://api.github.com/repos/RackHD/on-tasks","forks_url":"https://api.github.com/repos/RackHD/on-tasks/forks","keys_url":"https://api.github.com/repos/RackHD/on-tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RackHD/on-tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RackHD/on-tasks/teams","hooks_url":"https://api.github.com/repos/RackHD/on-tasks/hooks","issue_events_url":"https://api.github.com/repos/RackHD/on-tasks/issues/events{/number}","events_url":"https://api.github.com/repos/RackHD/on-tasks/events","assignees_url":"https://api.github.com/repos/RackHD/on-tasks/assignees{/user}","branches_url":"https://api.github.com/repos/RackHD/on-tasks/branches{/branch}","tags_url":"https://api.github.com/repos/RackHD/on-tasks/tags","blobs_url":"https://api.github.com/repos/RackHD/on-tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RackHD/on-tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RackHD/on-tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/RackHD/on-tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RackHD/on-tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/RackHD/on-tasks/languages","stargazers_url":"https://api.github.com/repos/RackHD/on-tasks/stargazers","contributors_url":"https://api.github.com/repos/RackHD/on-tasks/contributors","subscribers_url":"https://api.github.com/repos/RackHD/on-tasks/subscribers","subscription_url":"https://api.github.com/repos/RackHD/on-tasks/subscription","commits_url":"https://api.github.com/repos/RackHD/on-tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/RackHD/on-tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/RackHD/on-tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/RackHD/on-tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/RackHD/on-tasks/contents/{+path}","compare_url":"https://api.github.com/repos/RackHD/on-tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RackHD/on-tasks/merges","archive_url":"https://api.github.com/repos/RackHD/on-tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RackHD/on-tasks/downloads","issues_url":"https://api.github.com/repos/RackHD/on-tasks/issues{/number}","pulls_url":"https://api.github.com/repos/RackHD/on-tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/RackHD/on-tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/RackHD/on-tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RackHD/on-tasks/labels{/name}","releases_url":"https://api.github.com/repos/RackHD/on-tasks/releases{/id}","deployments_url":"https://api.github.com/repos/RackHD/on-tasks/deployments","created_at":"2015-08-31T17:29:32Z","updated_at":"2016-05-17T08:18:08Z","pushed_at":"2016-05-18T04:49:10Z","git_url":"git://github.com/RackHD/on-tasks.git","ssh_url":"git@github.com:RackHD/on-tasks.git","clone_url":"https://github.com/RackHD/on-tasks.git","svn_url":"https://github.com/RackHD/on-tasks","homepage":null,"size":1437,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":14,"forks":41,"open_issues":14,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RackHD/on-tasks/pulls/213"},"html":{"href":"https://github.com/RackHD/on-tasks/pull/213"},"issue":{"href":"https://api.github.com/repos/RackHD/on-tasks/issues/213"},"comments":{"href":"https://api.github.com/repos/RackHD/on-tasks/issues/213/comments"},"review_comments":{"href":"https://api.github.com/repos/RackHD/on-tasks/pulls/213/comments"},"review_comment":{"href":"https://api.github.com/repos/RackHD/on-tasks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RackHD/on-tasks/pulls/213/commits"},"statuses":{"href":"https://api.github.com/repos/RackHD/on-tasks/statuses/5efffbc5843160984a47ff99b20c74c1fe0d6b25"}}}}