{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11364","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11364/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11364/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11364/events","html_url":"https://github.com/ManageIQ/manageiq/pull/11364","id":177794057,"number":11364,"title":"Ensure api config references only valid miq_product_features","user":{"login":"isimluk","id":6666052,"avatar_url":"https://avatars.githubusercontent.com/u/6666052?v=3","gravatar_id":"","url":"https://api.github.com/users/isimluk","html_url":"https://github.com/isimluk","followers_url":"https://api.github.com/users/isimluk/followers","following_url":"https://api.github.com/users/isimluk/following{/other_user}","gists_url":"https://api.github.com/users/isimluk/gists{/gist_id}","starred_url":"https://api.github.com/users/isimluk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isimluk/subscriptions","organizations_url":"https://api.github.com/users/isimluk/orgs","repos_url":"https://api.github.com/users/isimluk/repos","events_url":"https://api.github.com/users/isimluk/events{/privacy}","received_events_url":"https://api.github.com/users/isimluk/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/api","name":"api","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":{"login":"abellotti","id":5797328,"avatar_url":"https://avatars.githubusercontent.com/u/5797328?v=3","gravatar_id":"","url":"https://api.github.com/users/abellotti","html_url":"https://github.com/abellotti","followers_url":"https://api.github.com/users/abellotti/followers","following_url":"https://api.github.com/users/abellotti/following{/other_user}","gists_url":"https://api.github.com/users/abellotti/gists{/gist_id}","starred_url":"https://api.github.com/users/abellotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abellotti/subscriptions","organizations_url":"https://api.github.com/users/abellotti/orgs","repos_url":"https://api.github.com/users/abellotti/repos","events_url":"https://api.github.com/users/abellotti/events{/privacy}","received_events_url":"https://api.github.com/users/abellotti/received_events","type":"User","site_admin":false},"assignees":[{"login":"abellotti","id":5797328,"avatar_url":"https://avatars.githubusercontent.com/u/5797328?v=3","gravatar_id":"","url":"https://api.github.com/users/abellotti","html_url":"https://github.com/abellotti","followers_url":"https://api.github.com/users/abellotti/followers","following_url":"https://api.github.com/users/abellotti/following{/other_user}","gists_url":"https://api.github.com/users/abellotti/gists{/gist_id}","starred_url":"https://api.github.com/users/abellotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abellotti/subscriptions","organizations_url":"https://api.github.com/users/abellotti/orgs","repos_url":"https://api.github.com/users/abellotti/repos","events_url":"https://api.github.com/users/abellotti/events{/privacy}","received_events_url":"https://api.github.com/users/abellotti/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-09-19T14:06:10Z","updated_at":"2016-09-19T15:37:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11364","html_url":"https://github.com/ManageIQ/manageiq/pull/11364","diff_url":"https://github.com/ManageIQ/manageiq/pull/11364.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/11364.patch"},"body":"https://bugzilla.redhat.com/show_bug.cgi?id=1376753\r\n\r\n## Problem\r\nThe `/api/policies` and `/api/policy_profiles` was returning Forbidden even thought the spec tests were passing. That was cause by `config/api.yml` referencing invalid `miq_product_feature`. \r\n\r\n## Solution\r\nThis pr introduces rspec that asserts that `config/api.yml` contains only valid `miq_product_features`. And also this pr fixes all the abuses one by one.\r\n\r\nSince each abuse was different in its nature and applied fix differs, reviewers are advised to consult respective commit messages.\r\n\r\n@miq-bot add_label api, bug\r\n@miq-bot assign @abellotti"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/248029092","html_url":"https://github.com/ManageIQ/manageiq/pull/11364#issuecomment-248029092","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11364","id":248029092,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2016-09-19T15:37:33Z","updated_at":"2016-09-19T15:37:33Z","body":"<rubocop />Checked commits https://github.com/isimluk/manageiq/compare/af66451b150b62617076c9e3bcd20d9ceb0702ec~...2a4bc00a8e6e8db4e3d93204cac5084d833016f2 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1\n1 file checked, 0 offenses detected\nEverything looks good. :+1:\n"}}
{"actor":{"display_login":"miq-bot"}}