{"action":"closed","number":3958,"pull_request":{"url":"https://api.github.com/repos/godotengine/godot/pulls/3958","id":61850961,"html_url":"https://github.com/godotengine/godot/pull/3958","diff_url":"https://github.com/godotengine/godot/pull/3958.diff","patch_url":"https://github.com/godotengine/godot/pull/3958.patch","issue_url":"https://api.github.com/repos/godotengine/godot/issues/3958","number":3958,"state":"closed","locked":false,"title":"Fix to CPU skinning path when using GPU skinning (meshes with morphs)","user":{"login":"SaracenOne","id":12756047,"avatar_url":"https://avatars.githubusercontent.com/u/12756047?v=3","gravatar_id":"","url":"https://api.github.com/users/SaracenOne","html_url":"https://github.com/SaracenOne","followers_url":"https://api.github.com/users/SaracenOne/followers","following_url":"https://api.github.com/users/SaracenOne/following{/other_user}","gists_url":"https://api.github.com/users/SaracenOne/gists{/gist_id}","starred_url":"https://api.github.com/users/SaracenOne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaracenOne/subscriptions","organizations_url":"https://api.github.com/users/SaracenOne/orgs","repos_url":"https://api.github.com/users/SaracenOne/repos","events_url":"https://api.github.com/users/SaracenOne/events{/privacy}","received_events_url":"https://api.github.com/users/SaracenOne/received_events","type":"User","site_admin":false},"body":"This fixes and issue where when using GPU skinning, meshes still using a CPU path for skinning (meshes using morph data) would be skinned both on the CPU and GPU, resulting in the root bone offset being doubled and wasted performance. Detecting this based on the existance of morph data might not be the best universal solution, but it should at least resolve the issue for the time being until something broader can be introduced.","created_at":"2016-03-06T18:51:19Z","updated_at":"2016-03-08T18:34:36Z","closed_at":"2016-03-08T18:34:36Z","merged_at":"2016-03-08T18:34:36Z","merge_commit_sha":"88d4d4ccebc8b956e00a6bf544442a4ccf6ce0ff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/godotengine/godot/pulls/3958/commits","review_comments_url":"https://api.github.com/repos/godotengine/godot/pulls/3958/comments","review_comment_url":"https://api.github.com/repos/godotengine/godot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/godotengine/godot/issues/3958/comments","statuses_url":"https://api.github.com/repos/godotengine/godot/statuses/23a4683879f4da5b09f05e79a43e061e78ccdb43","head":{"label":"SaracenOne:cpu_skinning_path_fix","ref":"cpu_skinning_path_fix","sha":"23a4683879f4da5b09f05e79a43e061e78ccdb43","user":{"login":"SaracenOne","id":12756047,"avatar_url":"https://avatars.githubusercontent.com/u/12756047?v=3","gravatar_id":"","url":"https://api.github.com/users/SaracenOne","html_url":"https://github.com/SaracenOne","followers_url":"https://api.github.com/users/SaracenOne/followers","following_url":"https://api.github.com/users/SaracenOne/following{/other_user}","gists_url":"https://api.github.com/users/SaracenOne/gists{/gist_id}","starred_url":"https://api.github.com/users/SaracenOne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaracenOne/subscriptions","organizations_url":"https://api.github.com/users/SaracenOne/orgs","repos_url":"https://api.github.com/users/SaracenOne/repos","events_url":"https://api.github.com/users/SaracenOne/events{/privacy}","received_events_url":"https://api.github.com/users/SaracenOne/received_events","type":"User","site_admin":false},"repo":{"id":37738603,"name":"godot","full_name":"SaracenOne/godot","owner":{"login":"SaracenOne","id":12756047,"avatar_url":"https://avatars.githubusercontent.com/u/12756047?v=3","gravatar_id":"","url":"https://api.github.com/users/SaracenOne","html_url":"https://github.com/SaracenOne","followers_url":"https://api.github.com/users/SaracenOne/followers","following_url":"https://api.github.com/users/SaracenOne/following{/other_user}","gists_url":"https://api.github.com/users/SaracenOne/gists{/gist_id}","starred_url":"https://api.github.com/users/SaracenOne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaracenOne/subscriptions","organizations_url":"https://api.github.com/users/SaracenOne/orgs","repos_url":"https://api.github.com/users/SaracenOne/repos","events_url":"https://api.github.com/users/SaracenOne/events{/privacy}","received_events_url":"https://api.github.com/users/SaracenOne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SaracenOne/godot","description":"Godot Game Engine","fork":true,"url":"https://api.github.com/repos/SaracenOne/godot","forks_url":"https://api.github.com/repos/SaracenOne/godot/forks","keys_url":"https://api.github.com/repos/SaracenOne/godot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SaracenOne/godot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SaracenOne/godot/teams","hooks_url":"https://api.github.com/repos/SaracenOne/godot/hooks","issue_events_url":"https://api.github.com/repos/SaracenOne/godot/issues/events{/number}","events_url":"https://api.github.com/repos/SaracenOne/godot/events","assignees_url":"https://api.github.com/repos/SaracenOne/godot/assignees{/user}","branches_url":"https://api.github.com/repos/SaracenOne/godot/branches{/branch}","tags_url":"https://api.github.com/repos/SaracenOne/godot/tags","blobs_url":"https://api.github.com/repos/SaracenOne/godot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SaracenOne/godot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SaracenOne/godot/git/refs{/sha}","trees_url":"https://api.github.com/repos/SaracenOne/godot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SaracenOne/godot/statuses/{sha}","languages_url":"https://api.github.com/repos/SaracenOne/godot/languages","stargazers_url":"https://api.github.com/repos/SaracenOne/godot/stargazers","contributors_url":"https://api.github.com/repos/SaracenOne/godot/contributors","subscribers_url":"https://api.github.com/repos/SaracenOne/godot/subscribers","subscription_url":"https://api.github.com/repos/SaracenOne/godot/subscription","commits_url":"https://api.github.com/repos/SaracenOne/godot/commits{/sha}","git_commits_url":"https://api.github.com/repos/SaracenOne/godot/git/commits{/sha}","comments_url":"https://api.github.com/repos/SaracenOne/godot/comments{/number}","issue_comment_url":"https://api.github.com/repos/SaracenOne/godot/issues/comments{/number}","contents_url":"https://api.github.com/repos/SaracenOne/godot/contents/{+path}","compare_url":"https://api.github.com/repos/SaracenOne/godot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SaracenOne/godot/merges","archive_url":"https://api.github.com/repos/SaracenOne/godot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SaracenOne/godot/downloads","issues_url":"https://api.github.com/repos/SaracenOne/godot/issues{/number}","pulls_url":"https://api.github.com/repos/SaracenOne/godot/pulls{/number}","milestones_url":"https://api.github.com/repos/SaracenOne/godot/milestones{/number}","notifications_url":"https://api.github.com/repos/SaracenOne/godot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SaracenOne/godot/labels{/name}","releases_url":"https://api.github.com/repos/SaracenOne/godot/releases{/id}","deployments_url":"https://api.github.com/repos/SaracenOne/godot/deployments","created_at":"2015-06-19T18:20:59Z","updated_at":"2016-02-05T18:51:01Z","pushed_at":"2016-03-07T23:44:12Z","git_url":"git://github.com/SaracenOne/godot.git","ssh_url":"git@github.com:SaracenOne/godot.git","clone_url":"https://github.com/SaracenOne/godot.git","svn_url":"https://github.com/SaracenOne/godot","homepage":null,"size":78323,"stargazers_count":4,"watchers_count":4,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":4,"default_branch":"galatea"}},"base":{"label":"godotengine:master","ref":"master","sha":"a283d367a7cb54807e8c2e6015167feca9f604d1","user":{"login":"godotengine","id":6318500,"avatar_url":"https://avatars.githubusercontent.com/u/6318500?v=3","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"repo":{"id":15634981,"name":"godot","full_name":"godotengine/godot","owner":{"login":"godotengine","id":6318500,"avatar_url":"https://avatars.githubusercontent.com/u/6318500?v=3","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/godotengine/godot","description":"Godot Game Engine","fork":false,"url":"https://api.github.com/repos/godotengine/godot","forks_url":"https://api.github.com/repos/godotengine/godot/forks","keys_url":"https://api.github.com/repos/godotengine/godot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/godotengine/godot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/godotengine/godot/teams","hooks_url":"https://api.github.com/repos/godotengine/godot/hooks","issue_events_url":"https://api.github.com/repos/godotengine/godot/issues/events{/number}","events_url":"https://api.github.com/repos/godotengine/godot/events","assignees_url":"https://api.github.com/repos/godotengine/godot/assignees{/user}","branches_url":"https://api.github.com/repos/godotengine/godot/branches{/branch}","tags_url":"https://api.github.com/repos/godotengine/godot/tags","blobs_url":"https://api.github.com/repos/godotengine/godot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/godotengine/godot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/godotengine/godot/git/refs{/sha}","trees_url":"https://api.github.com/repos/godotengine/godot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/godotengine/godot/statuses/{sha}","languages_url":"https://api.github.com/repos/godotengine/godot/languages","stargazers_url":"https://api.github.com/repos/godotengine/godot/stargazers","contributors_url":"https://api.github.com/repos/godotengine/godot/contributors","subscribers_url":"https://api.github.com/repos/godotengine/godot/subscribers","subscription_url":"https://api.github.com/repos/godotengine/godot/subscription","commits_url":"https://api.github.com/repos/godotengine/godot/commits{/sha}","git_commits_url":"https://api.github.com/repos/godotengine/godot/git/commits{/sha}","comments_url":"https://api.github.com/repos/godotengine/godot/comments{/number}","issue_comment_url":"https://api.github.com/repos/godotengine/godot/issues/comments{/number}","contents_url":"https://api.github.com/repos/godotengine/godot/contents/{+path}","compare_url":"https://api.github.com/repos/godotengine/godot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/godotengine/godot/merges","archive_url":"https://api.github.com/repos/godotengine/godot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/godotengine/godot/downloads","issues_url":"https://api.github.com/repos/godotengine/godot/issues{/number}","pulls_url":"https://api.github.com/repos/godotengine/godot/pulls{/number}","milestones_url":"https://api.github.com/repos/godotengine/godot/milestones{/number}","notifications_url":"https://api.github.com/repos/godotengine/godot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/godotengine/godot/labels{/name}","releases_url":"https://api.github.com/repos/godotengine/godot/releases{/id}","deployments_url":"https://api.github.com/repos/godotengine/godot/deployments","created_at":"2014-01-04T16:05:36Z","updated_at":"2016-03-08T18:01:56Z","pushed_at":"2016-03-08T18:34:36Z","git_url":"git://github.com/godotengine/godot.git","ssh_url":"git@github.com:godotengine/godot.git","clone_url":"https://github.com/godotengine/godot.git","svn_url":"https://github.com/godotengine/godot","homepage":"http://www.godotengine.org","size":113447,"stargazers_count":5409,"watchers_count":5409,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1428,"mirror_url":null,"open_issues_count":870,"forks":1428,"open_issues":870,"watchers":5409,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/godotengine/godot/pulls/3958"},"html":{"href":"https://github.com/godotengine/godot/pull/3958"},"issue":{"href":"https://api.github.com/repos/godotengine/godot/issues/3958"},"comments":{"href":"https://api.github.com/repos/godotengine/godot/issues/3958/comments"},"review_comments":{"href":"https://api.github.com/repos/godotengine/godot/pulls/3958/comments"},"review_comment":{"href":"https://api.github.com/repos/godotengine/godot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/godotengine/godot/pulls/3958/commits"},"statuses":{"href":"https://api.github.com/repos/godotengine/godot/statuses/23a4683879f4da5b09f05e79a43e061e78ccdb43"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"reduz","id":6265307,"avatar_url":"https://avatars.githubusercontent.com/u/6265307?v=3","gravatar_id":"","url":"https://api.github.com/users/reduz","html_url":"https://github.com/reduz","followers_url":"https://api.github.com/users/reduz/followers","following_url":"https://api.github.com/users/reduz/following{/other_user}","gists_url":"https://api.github.com/users/reduz/gists{/gist_id}","starred_url":"https://api.github.com/users/reduz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reduz/subscriptions","organizations_url":"https://api.github.com/users/reduz/orgs","repos_url":"https://api.github.com/users/reduz/repos","events_url":"https://api.github.com/users/reduz/events{/privacy}","received_events_url":"https://api.github.com/users/reduz/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":11,"deletions":3,"changed_files":1}}