{"action":"created","comment":{"url":"https://api.github.com/repos/hpcloud/fissile/pulls/comments/90330689","pull_request_review_id":10851672,"id":90330689,"diff_hunk":"@@ -225,6 +234,124 @@ func (j *Job) loadJobSpec() (err error) {\n \treturn nil\n }\n \n+// MergeSpec is used to merge temporary spec patches into each job. otherJob should only be\n+// the hcf/patch-properties job.  The code assumes package and property objects are immutable,\n+// as they're now being shared across jobs. Also, the results are undefined if specified packages\n+// or properties already exist in the destination job.\n+func (j *Job) MergeSpec(otherJob *Job) {\n+\t// Ignore otherJob.Name, otherJob.Description\n+\tif otherJob.Packages != nil {\n+\t\tj.Packages = append(j.Packages, otherJob.Packages...)","path":"model/job.go","position":null,"original_position":34,"commit_id":"de743b274981cd88309fe0ffc996e18096c1708d","original_commit_id":"503e7f3ad495a9cdc1f4f2240792941aed663ee3","user":{"login":"ericpromislow","id":108392,"avatar_url":"https://avatars.githubusercontent.com/u/108392?v=3","gravatar_id":"","url":"https://api.github.com/users/ericpromislow","html_url":"https://github.com/ericpromislow","followers_url":"https://api.github.com/users/ericpromislow/followers","following_url":"https://api.github.com/users/ericpromislow/following{/other_user}","gists_url":"https://api.github.com/users/ericpromislow/gists{/gist_id}","starred_url":"https://api.github.com/users/ericpromislow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericpromislow/subscriptions","organizations_url":"https://api.github.com/users/ericpromislow/orgs","repos_url":"https://api.github.com/users/ericpromislow/repos","events_url":"https://api.github.com/users/ericpromislow/events{/privacy}","received_events_url":"https://api.github.com/users/ericpromislow/received_events","type":"User","site_admin":false},"body":"done in de743b2","created_at":"2016-11-30T21:20:52Z","updated_at":"2016-11-30T21:20:52Z","html_url":"https://github.com/hpcloud/fissile/pull/185#discussion_r90330689","pull_request_url":"https://api.github.com/repos/hpcloud/fissile/pulls/185","_links":{"self":{"href":"https://api.github.com/repos/hpcloud/fissile/pulls/comments/90330689"},"html":{"href":"https://github.com/hpcloud/fissile/pull/185#discussion_r90330689"},"pull_request":{"href":"https://api.github.com/repos/hpcloud/fissile/pulls/185"}}},"pull_request":{"url":"https://api.github.com/repos/hpcloud/fissile/pulls/185","id":95236869,"html_url":"https://github.com/hpcloud/fissile/pull/185","diff_url":"https://github.com/hpcloud/fissile/pull/185.diff","patch_url":"https://github.com/hpcloud/fissile/pull/185.patch","issue_url":"https://api.github.com/repos/hpcloud/fissile/issues/185","number":185,"state":"open","locked":false,"title":"Hcf 1124 simplify config generator","user":{"login":"ericpromislow","id":108392,"avatar_url":"https://avatars.githubusercontent.com/u/108392?v=3","gravatar_id":"","url":"https://api.github.com/users/ericpromislow","html_url":"https://github.com/ericpromislow","followers_url":"https://api.github.com/users/ericpromislow/followers","following_url":"https://api.github.com/users/ericpromislow/following{/other_user}","gists_url":"https://api.github.com/users/ericpromislow/gists{/gist_id}","starred_url":"https://api.github.com/users/ericpromislow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericpromislow/subscriptions","organizations_url":"https://api.github.com/users/ericpromislow/orgs","repos_url":"https://api.github.com/users/ericpromislow/repos","events_url":"https://api.github.com/users/ericpromislow/events{/privacy}","received_events_url":"https://api.github.com/users/ericpromislow/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-25T00:24:21Z","updated_at":"2016-11-30T21:20:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce87e4f9d94be0f014b95c1250aa5f4a5a2905b2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hpcloud/fissile/pulls/185/commits","review_comments_url":"https://api.github.com/repos/hpcloud/fissile/pulls/185/comments","review_comment_url":"https://api.github.com/repos/hpcloud/fissile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcloud/fissile/issues/185/comments","statuses_url":"https://api.github.com/repos/hpcloud/fissile/statuses/de743b274981cd88309fe0ffc996e18096c1708d","head":{"label":"hpcloud:HCF-1124-simplify-config-generator","ref":"HCF-1124-simplify-config-generator","sha":"de743b274981cd88309fe0ffc996e18096c1708d","user":{"login":"hpcloud","id":366390,"avatar_url":"https://avatars.githubusercontent.com/u/366390?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcloud","html_url":"https://github.com/hpcloud","followers_url":"https://api.github.com/users/hpcloud/followers","following_url":"https://api.github.com/users/hpcloud/following{/other_user}","gists_url":"https://api.github.com/users/hpcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcloud/subscriptions","organizations_url":"https://api.github.com/users/hpcloud/orgs","repos_url":"https://api.github.com/users/hpcloud/repos","events_url":"https://api.github.com/users/hpcloud/events{/privacy}","received_events_url":"https://api.github.com/users/hpcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":42498148,"name":"fissile","full_name":"hpcloud/fissile","owner":{"login":"hpcloud","id":366390,"avatar_url":"https://avatars.githubusercontent.com/u/366390?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcloud","html_url":"https://github.com/hpcloud","followers_url":"https://api.github.com/users/hpcloud/followers","following_url":"https://api.github.com/users/hpcloud/following{/other_user}","gists_url":"https://api.github.com/users/hpcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcloud/subscriptions","organizations_url":"https://api.github.com/users/hpcloud/orgs","repos_url":"https://api.github.com/users/hpcloud/repos","events_url":"https://api.github.com/users/hpcloud/events{/privacy}","received_events_url":"https://api.github.com/users/hpcloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcloud/fissile","description":"Turn a BOSH release into Docker images / files","fork":false,"url":"https://api.github.com/repos/hpcloud/fissile","forks_url":"https://api.github.com/repos/hpcloud/fissile/forks","keys_url":"https://api.github.com/repos/hpcloud/fissile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcloud/fissile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcloud/fissile/teams","hooks_url":"https://api.github.com/repos/hpcloud/fissile/hooks","issue_events_url":"https://api.github.com/repos/hpcloud/fissile/issues/events{/number}","events_url":"https://api.github.com/repos/hpcloud/fissile/events","assignees_url":"https://api.github.com/repos/hpcloud/fissile/assignees{/user}","branches_url":"https://api.github.com/repos/hpcloud/fissile/branches{/branch}","tags_url":"https://api.github.com/repos/hpcloud/fissile/tags","blobs_url":"https://api.github.com/repos/hpcloud/fissile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcloud/fissile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcloud/fissile/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcloud/fissile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcloud/fissile/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcloud/fissile/languages","stargazers_url":"https://api.github.com/repos/hpcloud/fissile/stargazers","contributors_url":"https://api.github.com/repos/hpcloud/fissile/contributors","subscribers_url":"https://api.github.com/repos/hpcloud/fissile/subscribers","subscription_url":"https://api.github.com/repos/hpcloud/fissile/subscription","commits_url":"https://api.github.com/repos/hpcloud/fissile/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcloud/fissile/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcloud/fissile/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcloud/fissile/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcloud/fissile/contents/{+path}","compare_url":"https://api.github.com/repos/hpcloud/fissile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcloud/fissile/merges","archive_url":"https://api.github.com/repos/hpcloud/fissile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcloud/fissile/downloads","issues_url":"https://api.github.com/repos/hpcloud/fissile/issues{/number}","pulls_url":"https://api.github.com/repos/hpcloud/fissile/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcloud/fissile/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcloud/fissile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcloud/fissile/labels{/name}","releases_url":"https://api.github.com/repos/hpcloud/fissile/releases{/id}","deployments_url":"https://api.github.com/repos/hpcloud/fissile/deployments","created_at":"2015-09-15T05:51:21Z","updated_at":"2016-11-06T16:49:05Z","pushed_at":"2016-11-30T21:20:46Z","git_url":"git://github.com/hpcloud/fissile.git","ssh_url":"git@github.com:hpcloud/fissile.git","clone_url":"https://github.com/hpcloud/fissile.git","svn_url":"https://github.com/hpcloud/fissile","homepage":"","size":58546,"stargazers_count":15,"watchers_count":15,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":15,"default_branch":"master"}},"base":{"label":"hpcloud:master","ref":"master","sha":"dd0129e36ac6c401164cb7bbf95a470e33ef2a92","user":{"login":"hpcloud","id":366390,"avatar_url":"https://avatars.githubusercontent.com/u/366390?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcloud","html_url":"https://github.com/hpcloud","followers_url":"https://api.github.com/users/hpcloud/followers","following_url":"https://api.github.com/users/hpcloud/following{/other_user}","gists_url":"https://api.github.com/users/hpcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcloud/subscriptions","organizations_url":"https://api.github.com/users/hpcloud/orgs","repos_url":"https://api.github.com/users/hpcloud/repos","events_url":"https://api.github.com/users/hpcloud/events{/privacy}","received_events_url":"https://api.github.com/users/hpcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":42498148,"name":"fissile","full_name":"hpcloud/fissile","owner":{"login":"hpcloud","id":366390,"avatar_url":"https://avatars.githubusercontent.com/u/366390?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcloud","html_url":"https://github.com/hpcloud","followers_url":"https://api.github.com/users/hpcloud/followers","following_url":"https://api.github.com/users/hpcloud/following{/other_user}","gists_url":"https://api.github.com/users/hpcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcloud/subscriptions","organizations_url":"https://api.github.com/users/hpcloud/orgs","repos_url":"https://api.github.com/users/hpcloud/repos","events_url":"https://api.github.com/users/hpcloud/events{/privacy}","received_events_url":"https://api.github.com/users/hpcloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcloud/fissile","description":"Turn a BOSH release into Docker images / files","fork":false,"url":"https://api.github.com/repos/hpcloud/fissile","forks_url":"https://api.github.com/repos/hpcloud/fissile/forks","keys_url":"https://api.github.com/repos/hpcloud/fissile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcloud/fissile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcloud/fissile/teams","hooks_url":"https://api.github.com/repos/hpcloud/fissile/hooks","issue_events_url":"https://api.github.com/repos/hpcloud/fissile/issues/events{/number}","events_url":"https://api.github.com/repos/hpcloud/fissile/events","assignees_url":"https://api.github.com/repos/hpcloud/fissile/assignees{/user}","branches_url":"https://api.github.com/repos/hpcloud/fissile/branches{/branch}","tags_url":"https://api.github.com/repos/hpcloud/fissile/tags","blobs_url":"https://api.github.com/repos/hpcloud/fissile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcloud/fissile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcloud/fissile/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcloud/fissile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcloud/fissile/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcloud/fissile/languages","stargazers_url":"https://api.github.com/repos/hpcloud/fissile/stargazers","contributors_url":"https://api.github.com/repos/hpcloud/fissile/contributors","subscribers_url":"https://api.github.com/repos/hpcloud/fissile/subscribers","subscription_url":"https://api.github.com/repos/hpcloud/fissile/subscription","commits_url":"https://api.github.com/repos/hpcloud/fissile/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcloud/fissile/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcloud/fissile/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcloud/fissile/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcloud/fissile/contents/{+path}","compare_url":"https://api.github.com/repos/hpcloud/fissile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcloud/fissile/merges","archive_url":"https://api.github.com/repos/hpcloud/fissile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcloud/fissile/downloads","issues_url":"https://api.github.com/repos/hpcloud/fissile/issues{/number}","pulls_url":"https://api.github.com/repos/hpcloud/fissile/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcloud/fissile/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcloud/fissile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcloud/fissile/labels{/name}","releases_url":"https://api.github.com/repos/hpcloud/fissile/releases{/id}","deployments_url":"https://api.github.com/repos/hpcloud/fissile/deployments","created_at":"2015-09-15T05:51:21Z","updated_at":"2016-11-06T16:49:05Z","pushed_at":"2016-11-30T21:20:46Z","git_url":"git://github.com/hpcloud/fissile.git","ssh_url":"git@github.com:hpcloud/fissile.git","clone_url":"https://github.com/hpcloud/fissile.git","svn_url":"https://github.com/hpcloud/fissile","homepage":"","size":58546,"stargazers_count":15,"watchers_count":15,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcloud/fissile/pulls/185"},"html":{"href":"https://github.com/hpcloud/fissile/pull/185"},"issue":{"href":"https://api.github.com/repos/hpcloud/fissile/issues/185"},"comments":{"href":"https://api.github.com/repos/hpcloud/fissile/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcloud/fissile/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcloud/fissile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcloud/fissile/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/hpcloud/fissile/statuses/de743b274981cd88309fe0ffc996e18096c1708d"}}}}
{"actor":{"display_login":"ericpromislow"}}