{"action":"created","comment":{"url":"https://api.github.com/repos/mendersoftware/mender/pulls/comments/89290457","pull_request_review_id":9836125,"id":89290457,"diff_hunk":"@@ -64,8 +64,9 @@ const (\n )\n \n var (\n-\tdefaultManifestFile = path.Join(getConfDirPath(), \"build_mender\")\n-\tdefaultDataStore    = getStateDirPath()\n+\tdefaultArtifactInfoFile = path.Join(getConfDirPath(), \"artifact-info\")\n+\tdefaultDeviceTypeFile   = path.Join(getStateDirPath(), \"device_type\")","path":"mender.go","position":16,"original_position":16,"commit_id":"b388b284c6124e25d60739f05ab5c8a7279d70e2","original_commit_id":"b388b284c6124e25d60739f05ab5c8a7279d70e2","user":{"login":"kacf","id":4037094,"avatar_url":"https://avatars.githubusercontent.com/u/4037094?v=3","gravatar_id":"","url":"https://api.github.com/users/kacf","html_url":"https://github.com/kacf","followers_url":"https://api.github.com/users/kacf/followers","following_url":"https://api.github.com/users/kacf/following{/other_user}","gists_url":"https://api.github.com/users/kacf/gists{/gist_id}","starred_url":"https://api.github.com/users/kacf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kacf/subscriptions","organizations_url":"https://api.github.com/users/kacf/orgs","repos_url":"https://api.github.com/users/kacf/repos","events_url":"https://api.github.com/users/kacf/events{/privacy}","received_events_url":"https://api.github.com/users/kacf/received_events","type":"User","site_admin":false},"body":"Yes, it should be `artifact_info`. Not sure why I didn't do it immediately, it's the only one with a dash right now. I will change it.","created_at":"2016-11-23T10:40:03Z","updated_at":"2016-11-23T10:40:04Z","html_url":"https://github.com/mendersoftware/mender/pull/152#discussion_r89290457","pull_request_url":"https://api.github.com/repos/mendersoftware/mender/pulls/152","_links":{"self":{"href":"https://api.github.com/repos/mendersoftware/mender/pulls/comments/89290457"},"html":{"href":"https://github.com/mendersoftware/mender/pull/152#discussion_r89290457"},"pull_request":{"href":"https://api.github.com/repos/mendersoftware/mender/pulls/152"}}},"pull_request":{"url":"https://api.github.com/repos/mendersoftware/mender/pulls/152","id":94786545,"html_url":"https://github.com/mendersoftware/mender/pull/152","diff_url":"https://github.com/mendersoftware/mender/pull/152.diff","patch_url":"https://github.com/mendersoftware/mender/pull/152.patch","issue_url":"https://api.github.com/repos/mendersoftware/mender/issues/152","number":152,"state":"open","locked":false,"title":"Clean up reference to artifact names and device types.","user":{"login":"kacf","id":4037094,"avatar_url":"https://avatars.githubusercontent.com/u/4037094?v=3","gravatar_id":"","url":"https://api.github.com/users/kacf","html_url":"https://github.com/kacf","followers_url":"https://api.github.com/users/kacf/followers","following_url":"https://api.github.com/users/kacf/following{/other_user}","gists_url":"https://api.github.com/users/kacf/gists{/gist_id}","starred_url":"https://api.github.com/users/kacf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kacf/subscriptions","organizations_url":"https://api.github.com/users/kacf/orgs","repos_url":"https://api.github.com/users/kacf/repos","events_url":"https://api.github.com/users/kacf/events{/privacy}","received_events_url":"https://api.github.com/users/kacf/received_events","type":"User","site_admin":false},"body":"* Image ID and Yocto ID have been merged into one, and there is only one\r\n  id now, which is the artifact name.\r\n\r\n* device type information has been moved to a separate file in\r\n  /var/lib/mender.\r\n\r\n* artifact_name and device_type attributes have both been lowercased\r\n  to match json attributes.\r\n\r\nFixes MEN-762, MEN-763\r\n\r\nSigned-off-by: Kristian Amlie <kristian.amlie@mender.io>","created_at":"2016-11-22T10:30:51Z","updated_at":"2016-11-23T10:40:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ab7255894c58a9f2355e92ea6cea3a01ead18a3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mendersoftware/mender/pulls/152/commits","review_comments_url":"https://api.github.com/repos/mendersoftware/mender/pulls/152/comments","review_comment_url":"https://api.github.com/repos/mendersoftware/mender/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mendersoftware/mender/issues/152/comments","statuses_url":"https://api.github.com/repos/mendersoftware/mender/statuses/b388b284c6124e25d60739f05ab5c8a7279d70e2","head":{"label":"kacf:artifact_info-fixes","ref":"artifact_info-fixes","sha":"b388b284c6124e25d60739f05ab5c8a7279d70e2","user":{"login":"kacf","id":4037094,"avatar_url":"https://avatars.githubusercontent.com/u/4037094?v=3","gravatar_id":"","url":"https://api.github.com/users/kacf","html_url":"https://github.com/kacf","followers_url":"https://api.github.com/users/kacf/followers","following_url":"https://api.github.com/users/kacf/following{/other_user}","gists_url":"https://api.github.com/users/kacf/gists{/gist_id}","starred_url":"https://api.github.com/users/kacf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kacf/subscriptions","organizations_url":"https://api.github.com/users/kacf/orgs","repos_url":"https://api.github.com/users/kacf/repos","events_url":"https://api.github.com/users/kacf/events{/privacy}","received_events_url":"https://api.github.com/users/kacf/received_events","type":"User","site_admin":false},"repo":{"id":50182755,"name":"mender","full_name":"kacf/mender","owner":{"login":"kacf","id":4037094,"avatar_url":"https://avatars.githubusercontent.com/u/4037094?v=3","gravatar_id":"","url":"https://api.github.com/users/kacf","html_url":"https://github.com/kacf","followers_url":"https://api.github.com/users/kacf/followers","following_url":"https://api.github.com/users/kacf/following{/other_user}","gists_url":"https://api.github.com/users/kacf/gists{/gist_id}","starred_url":"https://api.github.com/users/kacf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kacf/subscriptions","organizations_url":"https://api.github.com/users/kacf/orgs","repos_url":"https://api.github.com/users/kacf/repos","events_url":"https://api.github.com/users/kacf/events{/privacy}","received_events_url":"https://api.github.com/users/kacf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kacf/mender","description":"Mender over-the-air software updates.","fork":true,"url":"https://api.github.com/repos/kacf/mender","forks_url":"https://api.github.com/repos/kacf/mender/forks","keys_url":"https://api.github.com/repos/kacf/mender/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kacf/mender/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kacf/mender/teams","hooks_url":"https://api.github.com/repos/kacf/mender/hooks","issue_events_url":"https://api.github.com/repos/kacf/mender/issues/events{/number}","events_url":"https://api.github.com/repos/kacf/mender/events","assignees_url":"https://api.github.com/repos/kacf/mender/assignees{/user}","branches_url":"https://api.github.com/repos/kacf/mender/branches{/branch}","tags_url":"https://api.github.com/repos/kacf/mender/tags","blobs_url":"https://api.github.com/repos/kacf/mender/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kacf/mender/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kacf/mender/git/refs{/sha}","trees_url":"https://api.github.com/repos/kacf/mender/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kacf/mender/statuses/{sha}","languages_url":"https://api.github.com/repos/kacf/mender/languages","stargazers_url":"https://api.github.com/repos/kacf/mender/stargazers","contributors_url":"https://api.github.com/repos/kacf/mender/contributors","subscribers_url":"https://api.github.com/repos/kacf/mender/subscribers","subscription_url":"https://api.github.com/repos/kacf/mender/subscription","commits_url":"https://api.github.com/repos/kacf/mender/commits{/sha}","git_commits_url":"https://api.github.com/repos/kacf/mender/git/commits{/sha}","comments_url":"https://api.github.com/repos/kacf/mender/comments{/number}","issue_comment_url":"https://api.github.com/repos/kacf/mender/issues/comments{/number}","contents_url":"https://api.github.com/repos/kacf/mender/contents/{+path}","compare_url":"https://api.github.com/repos/kacf/mender/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kacf/mender/merges","archive_url":"https://api.github.com/repos/kacf/mender/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kacf/mender/downloads","issues_url":"https://api.github.com/repos/kacf/mender/issues{/number}","pulls_url":"https://api.github.com/repos/kacf/mender/pulls{/number}","milestones_url":"https://api.github.com/repos/kacf/mender/milestones{/number}","notifications_url":"https://api.github.com/repos/kacf/mender/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kacf/mender/labels{/name}","releases_url":"https://api.github.com/repos/kacf/mender/releases{/id}","deployments_url":"https://api.github.com/repos/kacf/mender/deployments","created_at":"2016-01-22T13:23:56Z","updated_at":"2016-01-22T13:23:57Z","pushed_at":"2016-11-22T13:43:49Z","git_url":"git://github.com/kacf/mender.git","ssh_url":"git@github.com:kacf/mender.git","clone_url":"https://github.com/kacf/mender.git","svn_url":"https://github.com/kacf/mender","homepage":"https://mender.io","size":1435,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mendersoftware:master","ref":"master","sha":"679955cc0c06181cbdd71f251dbc620075487cc0","user":{"login":"mendersoftware","id":15040539,"avatar_url":"https://avatars.githubusercontent.com/u/15040539?v=3","gravatar_id":"","url":"https://api.github.com/users/mendersoftware","html_url":"https://github.com/mendersoftware","followers_url":"https://api.github.com/users/mendersoftware/followers","following_url":"https://api.github.com/users/mendersoftware/following{/other_user}","gists_url":"https://api.github.com/users/mendersoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/mendersoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mendersoftware/subscriptions","organizations_url":"https://api.github.com/users/mendersoftware/orgs","repos_url":"https://api.github.com/users/mendersoftware/repos","events_url":"https://api.github.com/users/mendersoftware/events{/privacy}","received_events_url":"https://api.github.com/users/mendersoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":47542798,"name":"mender","full_name":"mendersoftware/mender","owner":{"login":"mendersoftware","id":15040539,"avatar_url":"https://avatars.githubusercontent.com/u/15040539?v=3","gravatar_id":"","url":"https://api.github.com/users/mendersoftware","html_url":"https://github.com/mendersoftware","followers_url":"https://api.github.com/users/mendersoftware/followers","following_url":"https://api.github.com/users/mendersoftware/following{/other_user}","gists_url":"https://api.github.com/users/mendersoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/mendersoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mendersoftware/subscriptions","organizations_url":"https://api.github.com/users/mendersoftware/orgs","repos_url":"https://api.github.com/users/mendersoftware/repos","events_url":"https://api.github.com/users/mendersoftware/events{/privacy}","received_events_url":"https://api.github.com/users/mendersoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mendersoftware/mender","description":"Mender over-the-air software updates.","fork":false,"url":"https://api.github.com/repos/mendersoftware/mender","forks_url":"https://api.github.com/repos/mendersoftware/mender/forks","keys_url":"https://api.github.com/repos/mendersoftware/mender/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mendersoftware/mender/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mendersoftware/mender/teams","hooks_url":"https://api.github.com/repos/mendersoftware/mender/hooks","issue_events_url":"https://api.github.com/repos/mendersoftware/mender/issues/events{/number}","events_url":"https://api.github.com/repos/mendersoftware/mender/events","assignees_url":"https://api.github.com/repos/mendersoftware/mender/assignees{/user}","branches_url":"https://api.github.com/repos/mendersoftware/mender/branches{/branch}","tags_url":"https://api.github.com/repos/mendersoftware/mender/tags","blobs_url":"https://api.github.com/repos/mendersoftware/mender/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mendersoftware/mender/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mendersoftware/mender/git/refs{/sha}","trees_url":"https://api.github.com/repos/mendersoftware/mender/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mendersoftware/mender/statuses/{sha}","languages_url":"https://api.github.com/repos/mendersoftware/mender/languages","stargazers_url":"https://api.github.com/repos/mendersoftware/mender/stargazers","contributors_url":"https://api.github.com/repos/mendersoftware/mender/contributors","subscribers_url":"https://api.github.com/repos/mendersoftware/mender/subscribers","subscription_url":"https://api.github.com/repos/mendersoftware/mender/subscription","commits_url":"https://api.github.com/repos/mendersoftware/mender/commits{/sha}","git_commits_url":"https://api.github.com/repos/mendersoftware/mender/git/commits{/sha}","comments_url":"https://api.github.com/repos/mendersoftware/mender/comments{/number}","issue_comment_url":"https://api.github.com/repos/mendersoftware/mender/issues/comments{/number}","contents_url":"https://api.github.com/repos/mendersoftware/mender/contents/{+path}","compare_url":"https://api.github.com/repos/mendersoftware/mender/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mendersoftware/mender/merges","archive_url":"https://api.github.com/repos/mendersoftware/mender/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mendersoftware/mender/downloads","issues_url":"https://api.github.com/repos/mendersoftware/mender/issues{/number}","pulls_url":"https://api.github.com/repos/mendersoftware/mender/pulls{/number}","milestones_url":"https://api.github.com/repos/mendersoftware/mender/milestones{/number}","notifications_url":"https://api.github.com/repos/mendersoftware/mender/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mendersoftware/mender/labels{/name}","releases_url":"https://api.github.com/repos/mendersoftware/mender/releases{/id}","deployments_url":"https://api.github.com/repos/mendersoftware/mender/deployments","created_at":"2015-12-07T09:36:43Z","updated_at":"2016-11-23T09:21:58Z","pushed_at":"2016-11-22T13:43:50Z","git_url":"git://github.com/mendersoftware/mender.git","ssh_url":"git@github.com:mendersoftware/mender.git","clone_url":"https://github.com/mendersoftware/mender.git","svn_url":"https://github.com/mendersoftware/mender","homepage":"https://mender.io","size":1481,"stargazers_count":44,"watchers_count":44,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":2,"forks":14,"open_issues":2,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mendersoftware/mender/pulls/152"},"html":{"href":"https://github.com/mendersoftware/mender/pull/152"},"issue":{"href":"https://api.github.com/repos/mendersoftware/mender/issues/152"},"comments":{"href":"https://api.github.com/repos/mendersoftware/mender/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/mendersoftware/mender/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/mendersoftware/mender/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mendersoftware/mender/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/mendersoftware/mender/statuses/b388b284c6124e25d60739f05ab5c8a7279d70e2"}}}}
{"actor":{"display_login":"kacf"}}