{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/go-ethereum/issues/2924","repository_url":"https://api.github.com/repos/ethereum/go-ethereum","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/2924/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/2924/comments","events_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/2924/events","html_url":"https://github.com/ethereum/go-ethereum/pull/2924","id":172150095,"number":2924,"title":"fix to allow import of testnet blocks","user":{"login":"Hellsegga","id":20972132,"avatar_url":"https://avatars.githubusercontent.com/u/20972132?v=3","gravatar_id":"","url":"https://api.github.com/users/Hellsegga","html_url":"https://github.com/Hellsegga","followers_url":"https://api.github.com/users/Hellsegga/followers","following_url":"https://api.github.com/users/Hellsegga/following{/other_user}","gists_url":"https://api.github.com/users/Hellsegga/gists{/gist_id}","starred_url":"https://api.github.com/users/Hellsegga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hellsegga/subscriptions","organizations_url":"https://api.github.com/users/Hellsegga/orgs","repos_url":"https://api.github.com/users/Hellsegga/repos","events_url":"https://api.github.com/users/Hellsegga/events{/privacy}","received_events_url":"https://api.github.com/users/Hellsegga/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-19T14:54:42Z","updated_at":"2016-08-22T08:50:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/2924","html_url":"https://github.com/ethereum/go-ethereum/pull/2924","diff_url":"https://github.com/ethereum/go-ethereum/pull/2924.diff","patch_url":"https://github.com/ethereum/go-ethereum/pull/2924.patch"},"body":"As described in https://github.com/ethereum/go-ethereum/issues/2905 import of testnet blocks fails because `init` and `import` commands don't set the transaction \"StartingNonce\" for testnet.\r\nIn the fix I simply set the \"StartingNonce\" in the init and import commands functions in the same way it's done for a node start (in `MakeSystemNode`), if testnet flag is detected.\r\n\r\nAfter this fix the behavior of import is this: import skips the first block so it expects the user to first load a genesis block (if blocks are from testnet or from custom blockchain, for default net it's not required). Maybe this could be changed in the future to not require the user to manually load the testnet genesis."},"comment":{"url":"https://api.github.com/repos/ethereum/go-ethereum/issues/comments/241350838","html_url":"https://github.com/ethereum/go-ethereum/pull/2924#issuecomment-241350838","issue_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/2924","id":241350838,"user":{"login":"karalabe","id":129561,"avatar_url":"https://avatars.githubusercontent.com/u/129561?v=3","gravatar_id":"","url":"https://api.github.com/users/karalabe","html_url":"https://github.com/karalabe","followers_url":"https://api.github.com/users/karalabe/followers","following_url":"https://api.github.com/users/karalabe/following{/other_user}","gists_url":"https://api.github.com/users/karalabe/gists{/gist_id}","starred_url":"https://api.github.com/users/karalabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karalabe/subscriptions","organizations_url":"https://api.github.com/users/karalabe/orgs","repos_url":"https://api.github.com/users/karalabe/repos","events_url":"https://api.github.com/users/karalabe/events{/privacy}","received_events_url":"https://api.github.com/users/karalabe/received_events","type":"User","site_admin":false},"created_at":"2016-08-22T08:50:53Z","updated_at":"2016-08-22T08:50:53Z","body":"LGTM :+1: \r\n\r\nFor anyone merging: please modify commit message to be prefixed with `cmd/geth`.\r\n\r\nSide idea: long term we probably want to move the \"custom\" nonce as a chain configuration parameter (i.e. `config` field of the genesis.json, so that it can be tracked like all the other config values (forks) without needing to set global variables). But this is out of the scope of this PR, just mentioning it for the reference :)"}}
{"actor":{"display_login":"karalabe"}}