{"action":"closed","issue":{"url":"https://api.github.com/repos/riot/riot/issues/2035","repository_url":"https://api.github.com/repos/riot/riot","labels_url":"https://api.github.com/repos/riot/riot/issues/2035/labels{/name}","comments_url":"https://api.github.com/repos/riot/riot/issues/2035/comments","events_url":"https://api.github.com/repos/riot/riot/issues/2035/events","html_url":"https://github.com/riot/riot/issues/2035","id":184055783,"number":2035,"title":"Riot next specs using getElementById instead of $","user":{"login":"vitogit","id":5280619,"avatar_url":"https://avatars.githubusercontent.com/u/5280619?v=3","gravatar_id":"","url":"https://api.github.com/users/vitogit","html_url":"https://github.com/vitogit","followers_url":"https://api.github.com/users/vitogit/followers","following_url":"https://api.github.com/users/vitogit/following{/other_user}","gists_url":"https://api.github.com/users/vitogit/gists{/gist_id}","starred_url":"https://api.github.com/users/vitogit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitogit/subscriptions","organizations_url":"https://api.github.com/users/vitogit/orgs","repos_url":"https://api.github.com/users/vitogit/repos","events_url":"https://api.github.com/users/vitogit/events{/privacy}","received_events_url":"https://api.github.com/users/vitogit/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-19T19:43:32Z","updated_at":"2016-10-19T19:45:36Z","closed_at":"2016-10-19T19:45:36Z","body":"I saw that some tests like https://github.com/riot/riot/blob/next/test/specs/browser/core.spec.js are using `document.getElementById querySelect or by tag` when they could use $ or $$ (a helper method that is available).\r\n\r\nCan I create a PR against next branch to fix it? because I know that prs should be against dev branch, but tests are different from next\r\n\r\nHere are the changes, tests run without problems.\r\nhttps://github.com/riot/riot/compare/next...vitogit:update_tests?expand=1\r\n\r\nIf not, then people be aware when creating tests that those helper methods are avaiable and defined in helper/index.js\r\n\r\n5. How would you tag this issue?\r\n  - [x ] Question\r\n"}}
{"actor":{"display_login":"GianlucaGuarini"}}