{"action":"created","issue":{"url":"https://api.github.com/repos/caskdata/hydrator-plugins/issues/285","repository_url":"https://api.github.com/repos/caskdata/hydrator-plugins","labels_url":"https://api.github.com/repos/caskdata/hydrator-plugins/issues/285/labels{/name}","comments_url":"https://api.github.com/repos/caskdata/hydrator-plugins/issues/285/comments","events_url":"https://api.github.com/repos/caskdata/hydrator-plugins/issues/285/events","html_url":"https://github.com/caskdata/hydrator-plugins/pull/285","id":159171511,"number":285,"title":"CDAP-5881 - First draft of XML Reader","user":{"login":"bhushankawadkar","id":17117900,"avatar_url":"https://avatars.githubusercontent.com/u/17117900?v=3","gravatar_id":"","url":"https://api.github.com/users/bhushankawadkar","html_url":"https://github.com/bhushankawadkar","followers_url":"https://api.github.com/users/bhushankawadkar/followers","following_url":"https://api.github.com/users/bhushankawadkar/following{/other_user}","gists_url":"https://api.github.com/users/bhushankawadkar/gists{/gist_id}","starred_url":"https://api.github.com/users/bhushankawadkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhushankawadkar/subscriptions","organizations_url":"https://api.github.com/users/bhushankawadkar/orgs","repos_url":"https://api.github.com/users/bhushankawadkar/repos","events_url":"https://api.github.com/users/bhushankawadkar/events{/privacy}","received_events_url":"https://api.github.com/users/bhushankawadkar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"bhushankawadkar","id":17117900,"avatar_url":"https://avatars.githubusercontent.com/u/17117900?v=3","gravatar_id":"","url":"https://api.github.com/users/bhushankawadkar","html_url":"https://github.com/bhushankawadkar","followers_url":"https://api.github.com/users/bhushankawadkar/followers","following_url":"https://api.github.com/users/bhushankawadkar/following{/other_user}","gists_url":"https://api.github.com/users/bhushankawadkar/gists{/gist_id}","starred_url":"https://api.github.com/users/bhushankawadkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhushankawadkar/subscriptions","organizations_url":"https://api.github.com/users/bhushankawadkar/orgs","repos_url":"https://api.github.com/users/bhushankawadkar/repos","events_url":"https://api.github.com/users/bhushankawadkar/events{/privacy}","received_events_url":"https://api.github.com/users/bhushankawadkar/received_events","type":"User","site_admin":false},"assignees":[{"login":"bhushankawadkar","id":17117900,"avatar_url":"https://avatars.githubusercontent.com/u/17117900?v=3","gravatar_id":"","url":"https://api.github.com/users/bhushankawadkar","html_url":"https://github.com/bhushankawadkar","followers_url":"https://api.github.com/users/bhushankawadkar/followers","following_url":"https://api.github.com/users/bhushankawadkar/following{/other_user}","gists_url":"https://api.github.com/users/bhushankawadkar/gists{/gist_id}","starred_url":"https://api.github.com/users/bhushankawadkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhushankawadkar/subscriptions","organizations_url":"https://api.github.com/users/bhushankawadkar/orgs","repos_url":"https://api.github.com/users/bhushankawadkar/repos","events_url":"https://api.github.com/users/bhushankawadkar/events{/privacy}","received_events_url":"https://api.github.com/users/bhushankawadkar/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2016-06-08T14:03:19Z","updated_at":"2016-06-30T01:18:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/caskdata/hydrator-plugins/pulls/285","html_url":"https://github.com/caskdata/hydrator-plugins/pull/285","diff_url":"https://github.com/caskdata/hydrator-plugins/pull/285.diff","patch_url":"https://github.com/caskdata/hydrator-plugins/pull/285.patch"},"body":"Initial draft of XML Reader with node path approach."},"comment":{"url":"https://api.github.com/repos/caskdata/hydrator-plugins/issues/comments/229534849","html_url":"https://github.com/caskdata/hydrator-plugins/pull/285#issuecomment-229534849","issue_url":"https://api.github.com/repos/caskdata/hydrator-plugins/issues/285","id":229534849,"user":{"login":"bdmogal","id":3895099,"avatar_url":"https://avatars.githubusercontent.com/u/3895099?v=3","gravatar_id":"","url":"https://api.github.com/users/bdmogal","html_url":"https://github.com/bdmogal","followers_url":"https://api.github.com/users/bdmogal/followers","following_url":"https://api.github.com/users/bdmogal/following{/other_user}","gists_url":"https://api.github.com/users/bdmogal/gists{/gist_id}","starred_url":"https://api.github.com/users/bdmogal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdmogal/subscriptions","organizations_url":"https://api.github.com/users/bdmogal/orgs","repos_url":"https://api.github.com/users/bdmogal/repos","events_url":"https://api.github.com/users/bdmogal/events{/privacy}","received_events_url":"https://api.github.com/users/bdmogal/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T01:18:40Z","updated_at":"2016-06-30T01:18:40Z","body":"@bhushankawadkar, I'm mostly done with my review, other than a few more open comments.\r\n\r\nHowever, I still have a major concern that this source does a lot more than reading XML. To me, a lot of code here (post-actions, file tracking, etc) can apply to any file source, not just XML. It seems like the XML Reader should just be extending a more generic File source by providing an XMLInputFormat. What were the usecases for doing all of this in the XML Reader? It makes the code much more complicated than it should be."}}
{"actor":{"display_login":"bdmogal"}}