{"action":"created","comment":{"url":"https://api.github.com/repos/apache/storm/pulls/comments/88936241","pull_request_review_id":9487932,"id":88936241,"diff_hunk":"@@ -0,0 +1,64 @@\n+/**\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements.  See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership.  The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License.  You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.apache.storm.scheduler.utils;\n+\n+import org.apache.storm.utils.Utils;\n+import java.util.Map;\n+import java.io.File;\n+import org.yaml.snakeyaml.Yaml;\n+import org.yaml.snakeyaml.constructor.SafeConstructor;\n+import java.io.FileInputStream;\n+import java.io.InputStreamReader;\n+import org.slf4j.Logger;\n+import org.slf4j.LoggerFactory;\n+\n+public class SchedulerUtils {","path":"storm-core/src/jvm/org/apache/storm/scheduler/utils/SchedulerUtils.java","position":30,"original_position":30,"commit_id":"a3024280e0aa1352ff7c0bd79f5d0e04fafff844","original_commit_id":"a3024280e0aa1352ff7c0bd79f5d0e04fafff844","user":{"login":"revans2","id":3441321,"avatar_url":"https://avatars.githubusercontent.com/u/3441321?v=3","gravatar_id":"","url":"https://api.github.com/users/revans2","html_url":"https://github.com/revans2","followers_url":"https://api.github.com/users/revans2/followers","following_url":"https://api.github.com/users/revans2/following{/other_user}","gists_url":"https://api.github.com/users/revans2/gists{/gist_id}","starred_url":"https://api.github.com/users/revans2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/revans2/subscriptions","organizations_url":"https://api.github.com/users/revans2/orgs","repos_url":"https://api.github.com/users/revans2/repos","events_url":"https://api.github.com/users/revans2/events{/privacy}","received_events_url":"https://api.github.com/users/revans2/received_events","type":"User","site_admin":false},"body":"Now that we are on java 8 it might be good to move these static methods into the IConfigLoader interface.  in java 8 static methods can be part of an interface.","created_at":"2016-11-21T16:45:30Z","updated_at":"2016-11-21T16:48:29Z","html_url":"https://github.com/apache/storm/pull/1785#discussion_r88936241","pull_request_url":"https://api.github.com/repos/apache/storm/pulls/1785","_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/comments/88936241"},"html":{"href":"https://github.com/apache/storm/pull/1785#discussion_r88936241"},"pull_request":{"href":"https://api.github.com/repos/apache/storm/pulls/1785"}}},"pull_request":{"url":"https://api.github.com/repos/apache/storm/pulls/1785","id":94195983,"html_url":"https://github.com/apache/storm/pull/1785","diff_url":"https://github.com/apache/storm/pull/1785.diff","patch_url":"https://github.com/apache/storm/pull/1785.patch","issue_url":"https://api.github.com/repos/apache/storm/issues/1785","number":1785,"state":"open","locked":false,"title":"[STORM-2201] Add dynamic scheduler configuration loading.","user":{"login":"ppoulosk","id":4550393,"avatar_url":"https://avatars.githubusercontent.com/u/4550393?v=3","gravatar_id":"","url":"https://api.github.com/users/ppoulosk","html_url":"https://github.com/ppoulosk","followers_url":"https://api.github.com/users/ppoulosk/followers","following_url":"https://api.github.com/users/ppoulosk/following{/other_user}","gists_url":"https://api.github.com/users/ppoulosk/gists{/gist_id}","starred_url":"https://api.github.com/users/ppoulosk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppoulosk/subscriptions","organizations_url":"https://api.github.com/users/ppoulosk/orgs","repos_url":"https://api.github.com/users/ppoulosk/repos","events_url":"https://api.github.com/users/ppoulosk/events{/privacy}","received_events_url":"https://api.github.com/users/ppoulosk/received_events","type":"User","site_admin":false},"body":"This adds an interface and two implementations, one that will load from a local file, and another\r\nthat will load a config from artifactory.\r\n\r\nIt also modifies the ResourceAwareScheduler and Multitenant schedulers to have a plugin interface and configuration entries for the plugin.\r\n\r\nUnit tests are also added for the implementations.","created_at":"2016-11-17T16:02:09Z","updated_at":"2016-11-21T16:48:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"891430e85a3c85bc18dce051b28f8a0355fe58b4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/storm/pulls/1785/commits","review_comments_url":"https://api.github.com/repos/apache/storm/pulls/1785/comments","review_comment_url":"https://api.github.com/repos/apache/storm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/storm/issues/1785/comments","statuses_url":"https://api.github.com/repos/apache/storm/statuses/a3024280e0aa1352ff7c0bd79f5d0e04fafff844","head":{"label":"ppoulosk:STORM-2201","ref":"STORM-2201","sha":"a3024280e0aa1352ff7c0bd79f5d0e04fafff844","user":{"login":"ppoulosk","id":4550393,"avatar_url":"https://avatars.githubusercontent.com/u/4550393?v=3","gravatar_id":"","url":"https://api.github.com/users/ppoulosk","html_url":"https://github.com/ppoulosk","followers_url":"https://api.github.com/users/ppoulosk/followers","following_url":"https://api.github.com/users/ppoulosk/following{/other_user}","gists_url":"https://api.github.com/users/ppoulosk/gists{/gist_id}","starred_url":"https://api.github.com/users/ppoulosk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppoulosk/subscriptions","organizations_url":"https://api.github.com/users/ppoulosk/orgs","repos_url":"https://api.github.com/users/ppoulosk/repos","events_url":"https://api.github.com/users/ppoulosk/events{/privacy}","received_events_url":"https://api.github.com/users/ppoulosk/received_events","type":"User","site_admin":false},"repo":{"id":31718433,"name":"storm","full_name":"ppoulosk/storm","owner":{"login":"ppoulosk","id":4550393,"avatar_url":"https://avatars.githubusercontent.com/u/4550393?v=3","gravatar_id":"","url":"https://api.github.com/users/ppoulosk","html_url":"https://github.com/ppoulosk","followers_url":"https://api.github.com/users/ppoulosk/followers","following_url":"https://api.github.com/users/ppoulosk/following{/other_user}","gists_url":"https://api.github.com/users/ppoulosk/gists{/gist_id}","starred_url":"https://api.github.com/users/ppoulosk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppoulosk/subscriptions","organizations_url":"https://api.github.com/users/ppoulosk/orgs","repos_url":"https://api.github.com/users/ppoulosk/repos","events_url":"https://api.github.com/users/ppoulosk/events{/privacy}","received_events_url":"https://api.github.com/users/ppoulosk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ppoulosk/storm","description":"Mirror of Apache Storm","fork":true,"url":"https://api.github.com/repos/ppoulosk/storm","forks_url":"https://api.github.com/repos/ppoulosk/storm/forks","keys_url":"https://api.github.com/repos/ppoulosk/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ppoulosk/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ppoulosk/storm/teams","hooks_url":"https://api.github.com/repos/ppoulosk/storm/hooks","issue_events_url":"https://api.github.com/repos/ppoulosk/storm/issues/events{/number}","events_url":"https://api.github.com/repos/ppoulosk/storm/events","assignees_url":"https://api.github.com/repos/ppoulosk/storm/assignees{/user}","branches_url":"https://api.github.com/repos/ppoulosk/storm/branches{/branch}","tags_url":"https://api.github.com/repos/ppoulosk/storm/tags","blobs_url":"https://api.github.com/repos/ppoulosk/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ppoulosk/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ppoulosk/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/ppoulosk/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ppoulosk/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/ppoulosk/storm/languages","stargazers_url":"https://api.github.com/repos/ppoulosk/storm/stargazers","contributors_url":"https://api.github.com/repos/ppoulosk/storm/contributors","subscribers_url":"https://api.github.com/repos/ppoulosk/storm/subscribers","subscription_url":"https://api.github.com/repos/ppoulosk/storm/subscription","commits_url":"https://api.github.com/repos/ppoulosk/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/ppoulosk/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/ppoulosk/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/ppoulosk/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/ppoulosk/storm/contents/{+path}","compare_url":"https://api.github.com/repos/ppoulosk/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ppoulosk/storm/merges","archive_url":"https://api.github.com/repos/ppoulosk/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ppoulosk/storm/downloads","issues_url":"https://api.github.com/repos/ppoulosk/storm/issues{/number}","pulls_url":"https://api.github.com/repos/ppoulosk/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/ppoulosk/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/ppoulosk/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ppoulosk/storm/labels{/name}","releases_url":"https://api.github.com/repos/ppoulosk/storm/releases{/id}","deployments_url":"https://api.github.com/repos/ppoulosk/storm/deployments","created_at":"2015-03-05T14:43:36Z","updated_at":"2016-03-08T15:27:27Z","pushed_at":"2016-11-17T15:58:02Z","git_url":"git://github.com/ppoulosk/storm.git","ssh_url":"git@github.com:ppoulosk/storm.git","clone_url":"https://github.com/ppoulosk/storm.git","svn_url":"https://github.com/ppoulosk/storm","homepage":null,"size":36712,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"8c449dc7154464b73ae92adb06185e4eb68f8f54","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":14135470,"name":"storm","full_name":"apache/storm","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/storm","description":"Mirror of Apache Storm","fork":false,"url":"https://api.github.com/repos/apache/storm","forks_url":"https://api.github.com/repos/apache/storm/forks","keys_url":"https://api.github.com/repos/apache/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/storm/teams","hooks_url":"https://api.github.com/repos/apache/storm/hooks","issue_events_url":"https://api.github.com/repos/apache/storm/issues/events{/number}","events_url":"https://api.github.com/repos/apache/storm/events","assignees_url":"https://api.github.com/repos/apache/storm/assignees{/user}","branches_url":"https://api.github.com/repos/apache/storm/branches{/branch}","tags_url":"https://api.github.com/repos/apache/storm/tags","blobs_url":"https://api.github.com/repos/apache/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/storm/languages","stargazers_url":"https://api.github.com/repos/apache/storm/stargazers","contributors_url":"https://api.github.com/repos/apache/storm/contributors","subscribers_url":"https://api.github.com/repos/apache/storm/subscribers","subscription_url":"https://api.github.com/repos/apache/storm/subscription","commits_url":"https://api.github.com/repos/apache/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/storm/contents/{+path}","compare_url":"https://api.github.com/repos/apache/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/storm/merges","archive_url":"https://api.github.com/repos/apache/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/storm/downloads","issues_url":"https://api.github.com/repos/apache/storm/issues{/number}","pulls_url":"https://api.github.com/repos/apache/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/storm/labels{/name}","releases_url":"https://api.github.com/repos/apache/storm/releases{/id}","deployments_url":"https://api.github.com/repos/apache/storm/deployments","created_at":"2013-11-05T08:00:14Z","updated_at":"2016-11-21T09:41:34Z","pushed_at":"2016-11-21T13:45:59Z","git_url":"git://github.com/apache/storm.git","ssh_url":"git@github.com:apache/storm.git","clone_url":"https://github.com/apache/storm.git","svn_url":"https://github.com/apache/storm","homepage":null,"size":178083,"stargazers_count":3693,"watchers_count":3693,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2786,"mirror_url":"git://git.apache.org/storm.git","open_issues_count":130,"forks":2786,"open_issues":130,"watchers":3693,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/1785"},"html":{"href":"https://github.com/apache/storm/pull/1785"},"issue":{"href":"https://api.github.com/repos/apache/storm/issues/1785"},"comments":{"href":"https://api.github.com/repos/apache/storm/issues/1785/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/storm/pulls/1785/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/storm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/storm/pulls/1785/commits"},"statuses":{"href":"https://api.github.com/repos/apache/storm/statuses/a3024280e0aa1352ff7c0bd79f5d0e04fafff844"}}}}
{"actor":{"display_login":"revans2"}}