{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/84706225","pull_request_review_id":5466581,"id":84706225,"diff_hunk":"@@ -9824,12 +9824,12 @@ void ReplicatedPG::recover_got(hobject_t oid, eversion_t v)\n   }\n }\n \n-\n-void ReplicatedPG::failed_push(pg_shard_t from, const hobject_t &soid)\n+void ReplicatedPG::failed_push(const list<pg_shard_t> &from, const hobject_t &soid)\n {\n   assert(recovering.count(soid));\n   recovering.erase(soid);\n-  missing_loc.remove_location(soid, from);\n+  for (list<pg_shard_t>::const_iterator i = from.begin(); i != from.end() ; ++i)","path":"src/osd/ReplicatedPG.cc","position":null,"original_position":11,"commit_id":"82cdb93a9879a8ee1bfb8546f7e766f275446473","original_commit_id":"9284fec3af77bd5bab79c55dde953ff32f321a2b","user":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"body":"could use range-based loop.","created_at":"2016-10-24T14:56:58Z","updated_at":"2016-10-24T14:56:58Z","html_url":"https://github.com/ceph/ceph/pull/9304#discussion_r84706225","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/9304","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/84706225"},"html":{"href":"https://github.com/ceph/ceph/pull/9304#discussion_r84706225"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9304"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/9304","id":71308850,"html_url":"https://github.com/ceph/ceph/pull/9304","diff_url":"https://github.com/ceph/ceph/pull/9304.diff","patch_url":"https://github.com/ceph/ceph/pull/9304.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/9304","number":9304,"state":"open","locked":false,"title":"DNM: Handle EC recovery read errors","user":{"login":"dzafman","id":2467610,"avatar_url":"https://avatars.githubusercontent.com/u/2467610?v=3","gravatar_id":"","url":"https://api.github.com/users/dzafman","html_url":"https://github.com/dzafman","followers_url":"https://api.github.com/users/dzafman/followers","following_url":"https://api.github.com/users/dzafman/following{/other_user}","gists_url":"https://api.github.com/users/dzafman/gists{/gist_id}","starred_url":"https://api.github.com/users/dzafman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzafman/subscriptions","organizations_url":"https://api.github.com/users/dzafman/orgs","repos_url":"https://api.github.com/users/dzafman/repos","events_url":"https://api.github.com/users/dzafman/events{/privacy}","received_events_url":"https://api.github.com/users/dzafman/received_events","type":"User","site_admin":false},"body":"I end up with active+degraded pg which doesn't repair if I remove an object on all nodes in a way where it gets recognized as missing.  With this fix the OSD doesn't crash.  Need to figure out how to get recovery to finish.  I assume I can have an error which will have to be discovered later by scrubbing.","created_at":"2016-05-24T23:22:32Z","updated_at":"2016-10-24T14:56:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"895da9784780754ce374a23c540ca0cec1091954","assignee":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"assignees":[{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/9304/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/9304/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/9304/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/82cdb93a9879a8ee1bfb8546f7e766f275446473","head":{"label":"dzafman:wip-13937","ref":"wip-13937","sha":"82cdb93a9879a8ee1bfb8546f7e766f275446473","user":{"login":"dzafman","id":2467610,"avatar_url":"https://avatars.githubusercontent.com/u/2467610?v=3","gravatar_id":"","url":"https://api.github.com/users/dzafman","html_url":"https://github.com/dzafman","followers_url":"https://api.github.com/users/dzafman/followers","following_url":"https://api.github.com/users/dzafman/following{/other_user}","gists_url":"https://api.github.com/users/dzafman/gists{/gist_id}","starred_url":"https://api.github.com/users/dzafman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzafman/subscriptions","organizations_url":"https://api.github.com/users/dzafman/orgs","repos_url":"https://api.github.com/users/dzafman/repos","events_url":"https://api.github.com/users/dzafman/events{/privacy}","received_events_url":"https://api.github.com/users/dzafman/received_events","type":"User","site_admin":false},"repo":{"id":7757983,"name":"ceph","full_name":"dzafman/ceph","owner":{"login":"dzafman","id":2467610,"avatar_url":"https://avatars.githubusercontent.com/u/2467610?v=3","gravatar_id":"","url":"https://api.github.com/users/dzafman","html_url":"https://github.com/dzafman","followers_url":"https://api.github.com/users/dzafman/followers","following_url":"https://api.github.com/users/dzafman/following{/other_user}","gists_url":"https://api.github.com/users/dzafman/gists{/gist_id}","starred_url":"https://api.github.com/users/dzafman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzafman/subscriptions","organizations_url":"https://api.github.com/users/dzafman/orgs","repos_url":"https://api.github.com/users/dzafman/repos","events_url":"https://api.github.com/users/dzafman/events{/privacy}","received_events_url":"https://api.github.com/users/dzafman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dzafman/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/dzafman/ceph","forks_url":"https://api.github.com/repos/dzafman/ceph/forks","keys_url":"https://api.github.com/repos/dzafman/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dzafman/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dzafman/ceph/teams","hooks_url":"https://api.github.com/repos/dzafman/ceph/hooks","issue_events_url":"https://api.github.com/repos/dzafman/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/dzafman/ceph/events","assignees_url":"https://api.github.com/repos/dzafman/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/dzafman/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/dzafman/ceph/tags","blobs_url":"https://api.github.com/repos/dzafman/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dzafman/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dzafman/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/dzafman/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dzafman/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/dzafman/ceph/languages","stargazers_url":"https://api.github.com/repos/dzafman/ceph/stargazers","contributors_url":"https://api.github.com/repos/dzafman/ceph/contributors","subscribers_url":"https://api.github.com/repos/dzafman/ceph/subscribers","subscription_url":"https://api.github.com/repos/dzafman/ceph/subscription","commits_url":"https://api.github.com/repos/dzafman/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/dzafman/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/dzafman/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/dzafman/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/dzafman/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/dzafman/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dzafman/ceph/merges","archive_url":"https://api.github.com/repos/dzafman/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dzafman/ceph/downloads","issues_url":"https://api.github.com/repos/dzafman/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/dzafman/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/dzafman/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/dzafman/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dzafman/ceph/labels{/name}","releases_url":"https://api.github.com/repos/dzafman/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/dzafman/ceph/deployments","created_at":"2013-01-22T18:07:43Z","updated_at":"2014-06-25T02:23:55Z","pushed_at":"2016-10-22T01:18:29Z","git_url":"git://github.com/dzafman/ceph.git","ssh_url":"git@github.com:dzafman/ceph.git","clone_url":"https://github.com/dzafman/ceph.git","svn_url":"https://github.com/dzafman/ceph","homepage":"http://ceph.com","size":170772,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"2e11cdb7fcfdbd9136259498d426e7fe5bc9e661","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-10-24T10:20:39Z","pushed_at":"2016-10-24T14:23:34Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":245914,"stargazers_count":2556,"watchers_count":2556,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1510,"mirror_url":null,"open_issues_count":388,"forks":1510,"open_issues":388,"watchers":2556,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9304"},"html":{"href":"https://github.com/ceph/ceph/pull/9304"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/9304"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/9304/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9304/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9304/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/82cdb93a9879a8ee1bfb8546f7e766f275446473"}}}}
{"actor":{"display_login":"tchaikov"}}