{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react/issues/6864","repository_url":"https://api.github.com/repos/facebook/react","labels_url":"https://api.github.com/repos/facebook/react/issues/6864/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react/issues/6864/comments","events_url":"https://api.github.com/repos/facebook/react/issues/6864/events","html_url":"https://github.com/facebook/react/issues/6864","id":156652691,"number":6864,"title":"[Performance] Disable PropTypes validation in production builds","user":{"login":"rigdern","id":199935,"avatar_url":"https://avatars.githubusercontent.com/u/199935?v=3","gravatar_id":"","url":"https://api.github.com/users/rigdern","html_url":"https://github.com/rigdern","followers_url":"https://api.github.com/users/rigdern/followers","following_url":"https://api.github.com/users/rigdern/following{/other_user}","gists_url":"https://api.github.com/users/rigdern/gists{/gist_id}","starred_url":"https://api.github.com/users/rigdern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigdern/subscriptions","organizations_url":"https://api.github.com/users/rigdern/orgs","repos_url":"https://api.github.com/users/rigdern/repos","events_url":"https://api.github.com/users/rigdern/events{/privacy}","received_events_url":"https://api.github.com/users/rigdern/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed","name":"Status: Unconfirmed","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-25T02:55:16Z","updated_at":"2016-05-25T04:19:36Z","closed_at":null,"body":"React can run faster in production builds if it doesn't check PropTypes. Looking at the code, I don't see any `__DEV__` checks which would prevent PropTypes validation from running in production builds:\r\n  - [createElement](https://github.com/facebook/react/blob/db6ac5c01c4ad669db7ca264bc81ae5b3d6dfa01/src/isomorphic/classic/element/ReactElementValidator.js#L217)\r\n  - [cloneElement](https://github.com/facebook/react/blob/db6ac5c01c4ad669db7ca264bc81ae5b3d6dfa01/src/isomorphic/classic/element/ReactElementValidator.js#L262)\r\n\r\nWe're seeing functions like `validatePropTypes` and `checkType` pop up while doing performance analysis on our app."},"comment":{"url":"https://api.github.com/repos/facebook/react/issues/comments/221469433","html_url":"https://github.com/facebook/react/issues/6864#issuecomment-221469433","issue_url":"https://api.github.com/repos/facebook/react/issues/6864","id":221469433,"user":{"login":"jimfb","id":9595985,"avatar_url":"https://avatars.githubusercontent.com/u/9595985?v=3","gravatar_id":"","url":"https://api.github.com/users/jimfb","html_url":"https://github.com/jimfb","followers_url":"https://api.github.com/users/jimfb/followers","following_url":"https://api.github.com/users/jimfb/following{/other_user}","gists_url":"https://api.github.com/users/jimfb/gists{/gist_id}","starred_url":"https://api.github.com/users/jimfb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimfb/subscriptions","organizations_url":"https://api.github.com/users/jimfb/orgs","repos_url":"https://api.github.com/users/jimfb/repos","events_url":"https://api.github.com/users/jimfb/events{/privacy}","received_events_url":"https://api.github.com/users/jimfb/received_events","type":"User","site_admin":false},"created_at":"2016-05-25T04:19:36Z","updated_at":"2016-05-25T04:19:36Z","body":"Yeah, I'm pretty sure the functions you linked are not called in production."}}
{"actor":{"display_login":"jimfb"}}