{"action":"created","comment":{"url":"https://api.github.com/repos/smartcat-labs/data-loader/pulls/comments/89616025","pull_request_review_id":10160655,"id":89616025,"diff_hunk":"@@ -59,12 +66,12 @@ public RandomBuilder(Class<T> objectType, Randomizer random) {\n     }\n \n     public RandomBuilder<T> randomFromRange(String fieldName, Long lower, Long upper) {\n-        fieldRules.put(fieldName, RangeRule.withRanges(lower, upper).withRandom(random));\n+        fieldRules.put(fieldName, RangeRuleLong.withRanges(lower, upper).withRandom(random));\n         return this;\n     }\n \n     public RandomBuilder<T> exclusiveRandomFromRange(String fieldName, Long lower, Long upper) {","path":"data-gen/src/main/java/io/smartcat/data/loader/RandomBuilder.java","position":23,"original_position":23,"commit_id":"ecccd53efccc3556aedbe7339f391293009952d2","original_commit_id":"ecccd53efccc3556aedbe7339f391293009952d2","user":{"login":"mgobec","id":555650,"avatar_url":"https://avatars.githubusercontent.com/u/555650?v=3","gravatar_id":"","url":"https://api.github.com/users/mgobec","html_url":"https://github.com/mgobec","followers_url":"https://api.github.com/users/mgobec/followers","following_url":"https://api.github.com/users/mgobec/following{/other_user}","gists_url":"https://api.github.com/users/mgobec/gists{/gist_id}","starred_url":"https://api.github.com/users/mgobec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgobec/subscriptions","organizations_url":"https://api.github.com/users/mgobec/orgs","repos_url":"https://api.github.com/users/mgobec/repos","events_url":"https://api.github.com/users/mgobec/events{/privacy}","received_events_url":"https://api.github.com/users/mgobec/received_events","type":"User","site_admin":false},"body":"I guess these 2 method definitions should be different since boundary params are Long and return type is generic?","created_at":"2016-11-25T13:15:30Z","updated_at":"2016-11-25T13:15:30Z","html_url":"https://github.com/smartcat-labs/data-loader/pull/32#discussion_r89616025","pull_request_url":"https://api.github.com/repos/smartcat-labs/data-loader/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/smartcat-labs/data-loader/pulls/comments/89616025"},"html":{"href":"https://github.com/smartcat-labs/data-loader/pull/32#discussion_r89616025"},"pull_request":{"href":"https://api.github.com/repos/smartcat-labs/data-loader/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/smartcat-labs/data-loader/pulls/32","id":95300895,"html_url":"https://github.com/smartcat-labs/data-loader/pull/32","diff_url":"https://github.com/smartcat-labs/data-loader/pull/32.diff","patch_url":"https://github.com/smartcat-labs/data-loader/pull/32.patch","issue_url":"https://api.github.com/repos/smartcat-labs/data-loader/issues/32","number":32,"state":"open","locked":false,"title":"More tests and refactoring","user":{"login":"milannister","id":4706789,"avatar_url":"https://avatars.githubusercontent.com/u/4706789?v=3","gravatar_id":"","url":"https://api.github.com/users/milannister","html_url":"https://github.com/milannister","followers_url":"https://api.github.com/users/milannister/followers","following_url":"https://api.github.com/users/milannister/following{/other_user}","gists_url":"https://api.github.com/users/milannister/gists{/gist_id}","starred_url":"https://api.github.com/users/milannister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milannister/subscriptions","organizations_url":"https://api.github.com/users/milannister/orgs","repos_url":"https://api.github.com/users/milannister/repos","events_url":"https://api.github.com/users/milannister/events{/privacy}","received_events_url":"https://api.github.com/users/milannister/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-25T12:59:16Z","updated_at":"2016-11-25T13:15:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3841c00c45c14820be89003ffee561760b4f6f46","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/smartcat-labs/data-loader/pulls/32/commits","review_comments_url":"https://api.github.com/repos/smartcat-labs/data-loader/pulls/32/comments","review_comment_url":"https://api.github.com/repos/smartcat-labs/data-loader/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartcat-labs/data-loader/issues/32/comments","statuses_url":"https://api.github.com/repos/smartcat-labs/data-loader/statuses/ecccd53efccc3556aedbe7339f391293009952d2","head":{"label":"smartcat-labs:more-tests","ref":"more-tests","sha":"ecccd53efccc3556aedbe7339f391293009952d2","user":{"login":"smartcat-labs","id":12434092,"avatar_url":"https://avatars.githubusercontent.com/u/12434092?v=3","gravatar_id":"","url":"https://api.github.com/users/smartcat-labs","html_url":"https://github.com/smartcat-labs","followers_url":"https://api.github.com/users/smartcat-labs/followers","following_url":"https://api.github.com/users/smartcat-labs/following{/other_user}","gists_url":"https://api.github.com/users/smartcat-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/smartcat-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartcat-labs/subscriptions","organizations_url":"https://api.github.com/users/smartcat-labs/orgs","repos_url":"https://api.github.com/users/smartcat-labs/repos","events_url":"https://api.github.com/users/smartcat-labs/events{/privacy}","received_events_url":"https://api.github.com/users/smartcat-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":69666299,"name":"data-loader","full_name":"smartcat-labs/data-loader","owner":{"login":"smartcat-labs","id":12434092,"avatar_url":"https://avatars.githubusercontent.com/u/12434092?v=3","gravatar_id":"","url":"https://api.github.com/users/smartcat-labs","html_url":"https://github.com/smartcat-labs","followers_url":"https://api.github.com/users/smartcat-labs/followers","following_url":"https://api.github.com/users/smartcat-labs/following{/other_user}","gists_url":"https://api.github.com/users/smartcat-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/smartcat-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartcat-labs/subscriptions","organizations_url":"https://api.github.com/users/smartcat-labs/orgs","repos_url":"https://api.github.com/users/smartcat-labs/repos","events_url":"https://api.github.com/users/smartcat-labs/events{/privacy}","received_events_url":"https://api.github.com/users/smartcat-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartcat-labs/data-loader","description":"Data and load generator","fork":false,"url":"https://api.github.com/repos/smartcat-labs/data-loader","forks_url":"https://api.github.com/repos/smartcat-labs/data-loader/forks","keys_url":"https://api.github.com/repos/smartcat-labs/data-loader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartcat-labs/data-loader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartcat-labs/data-loader/teams","hooks_url":"https://api.github.com/repos/smartcat-labs/data-loader/hooks","issue_events_url":"https://api.github.com/repos/smartcat-labs/data-loader/issues/events{/number}","events_url":"https://api.github.com/repos/smartcat-labs/data-loader/events","assignees_url":"https://api.github.com/repos/smartcat-labs/data-loader/assignees{/user}","branches_url":"https://api.github.com/repos/smartcat-labs/data-loader/branches{/branch}","tags_url":"https://api.github.com/repos/smartcat-labs/data-loader/tags","blobs_url":"https://api.github.com/repos/smartcat-labs/data-loader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartcat-labs/data-loader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartcat-labs/data-loader/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartcat-labs/data-loader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartcat-labs/data-loader/statuses/{sha}","languages_url":"https://api.github.com/repos/smartcat-labs/data-loader/languages","stargazers_url":"https://api.github.com/repos/smartcat-labs/data-loader/stargazers","contributors_url":"https://api.github.com/repos/smartcat-labs/data-loader/contributors","subscribers_url":"https://api.github.com/repos/smartcat-labs/data-loader/subscribers","subscription_url":"https://api.github.com/repos/smartcat-labs/data-loader/subscription","commits_url":"https://api.github.com/repos/smartcat-labs/data-loader/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartcat-labs/data-loader/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartcat-labs/data-loader/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartcat-labs/data-loader/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartcat-labs/data-loader/contents/{+path}","compare_url":"https://api.github.com/repos/smartcat-labs/data-loader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartcat-labs/data-loader/merges","archive_url":"https://api.github.com/repos/smartcat-labs/data-loader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartcat-labs/data-loader/downloads","issues_url":"https://api.github.com/repos/smartcat-labs/data-loader/issues{/number}","pulls_url":"https://api.github.com/repos/smartcat-labs/data-loader/pulls{/number}","milestones_url":"https://api.github.com/repos/smartcat-labs/data-loader/milestones{/number}","notifications_url":"https://api.github.com/repos/smartcat-labs/data-loader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartcat-labs/data-loader/labels{/name}","releases_url":"https://api.github.com/repos/smartcat-labs/data-loader/releases{/id}","deployments_url":"https://api.github.com/repos/smartcat-labs/data-loader/deployments","created_at":"2016-09-30T12:47:28Z","updated_at":"2016-11-17T18:42:48Z","pushed_at":"2016-11-25T12:59:16Z","git_url":"git://github.com/smartcat-labs/data-loader.git","ssh_url":"git@github.com:smartcat-labs/data-loader.git","clone_url":"https://github.com/smartcat-labs/data-loader.git","svn_url":"https://github.com/smartcat-labs/data-loader","homepage":"http://www.smartcat.io","size":106,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":16,"forks":0,"open_issues":16,"watchers":0,"default_branch":"master"}},"base":{"label":"smartcat-labs:master","ref":"master","sha":"0b196594d947773c7957fd9d85e344a3180ce2ce","user":{"login":"smartcat-labs","id":12434092,"avatar_url":"https://avatars.githubusercontent.com/u/12434092?v=3","gravatar_id":"","url":"https://api.github.com/users/smartcat-labs","html_url":"https://github.com/smartcat-labs","followers_url":"https://api.github.com/users/smartcat-labs/followers","following_url":"https://api.github.com/users/smartcat-labs/following{/other_user}","gists_url":"https://api.github.com/users/smartcat-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/smartcat-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartcat-labs/subscriptions","organizations_url":"https://api.github.com/users/smartcat-labs/orgs","repos_url":"https://api.github.com/users/smartcat-labs/repos","events_url":"https://api.github.com/users/smartcat-labs/events{/privacy}","received_events_url":"https://api.github.com/users/smartcat-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":69666299,"name":"data-loader","full_name":"smartcat-labs/data-loader","owner":{"login":"smartcat-labs","id":12434092,"avatar_url":"https://avatars.githubusercontent.com/u/12434092?v=3","gravatar_id":"","url":"https://api.github.com/users/smartcat-labs","html_url":"https://github.com/smartcat-labs","followers_url":"https://api.github.com/users/smartcat-labs/followers","following_url":"https://api.github.com/users/smartcat-labs/following{/other_user}","gists_url":"https://api.github.com/users/smartcat-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/smartcat-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartcat-labs/subscriptions","organizations_url":"https://api.github.com/users/smartcat-labs/orgs","repos_url":"https://api.github.com/users/smartcat-labs/repos","events_url":"https://api.github.com/users/smartcat-labs/events{/privacy}","received_events_url":"https://api.github.com/users/smartcat-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartcat-labs/data-loader","description":"Data and load generator","fork":false,"url":"https://api.github.com/repos/smartcat-labs/data-loader","forks_url":"https://api.github.com/repos/smartcat-labs/data-loader/forks","keys_url":"https://api.github.com/repos/smartcat-labs/data-loader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartcat-labs/data-loader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartcat-labs/data-loader/teams","hooks_url":"https://api.github.com/repos/smartcat-labs/data-loader/hooks","issue_events_url":"https://api.github.com/repos/smartcat-labs/data-loader/issues/events{/number}","events_url":"https://api.github.com/repos/smartcat-labs/data-loader/events","assignees_url":"https://api.github.com/repos/smartcat-labs/data-loader/assignees{/user}","branches_url":"https://api.github.com/repos/smartcat-labs/data-loader/branches{/branch}","tags_url":"https://api.github.com/repos/smartcat-labs/data-loader/tags","blobs_url":"https://api.github.com/repos/smartcat-labs/data-loader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartcat-labs/data-loader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartcat-labs/data-loader/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartcat-labs/data-loader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartcat-labs/data-loader/statuses/{sha}","languages_url":"https://api.github.com/repos/smartcat-labs/data-loader/languages","stargazers_url":"https://api.github.com/repos/smartcat-labs/data-loader/stargazers","contributors_url":"https://api.github.com/repos/smartcat-labs/data-loader/contributors","subscribers_url":"https://api.github.com/repos/smartcat-labs/data-loader/subscribers","subscription_url":"https://api.github.com/repos/smartcat-labs/data-loader/subscription","commits_url":"https://api.github.com/repos/smartcat-labs/data-loader/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartcat-labs/data-loader/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartcat-labs/data-loader/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartcat-labs/data-loader/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartcat-labs/data-loader/contents/{+path}","compare_url":"https://api.github.com/repos/smartcat-labs/data-loader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartcat-labs/data-loader/merges","archive_url":"https://api.github.com/repos/smartcat-labs/data-loader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartcat-labs/data-loader/downloads","issues_url":"https://api.github.com/repos/smartcat-labs/data-loader/issues{/number}","pulls_url":"https://api.github.com/repos/smartcat-labs/data-loader/pulls{/number}","milestones_url":"https://api.github.com/repos/smartcat-labs/data-loader/milestones{/number}","notifications_url":"https://api.github.com/repos/smartcat-labs/data-loader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartcat-labs/data-loader/labels{/name}","releases_url":"https://api.github.com/repos/smartcat-labs/data-loader/releases{/id}","deployments_url":"https://api.github.com/repos/smartcat-labs/data-loader/deployments","created_at":"2016-09-30T12:47:28Z","updated_at":"2016-11-17T18:42:48Z","pushed_at":"2016-11-25T12:59:16Z","git_url":"git://github.com/smartcat-labs/data-loader.git","ssh_url":"git@github.com:smartcat-labs/data-loader.git","clone_url":"https://github.com/smartcat-labs/data-loader.git","svn_url":"https://github.com/smartcat-labs/data-loader","homepage":"http://www.smartcat.io","size":106,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":16,"forks":0,"open_issues":16,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartcat-labs/data-loader/pulls/32"},"html":{"href":"https://github.com/smartcat-labs/data-loader/pull/32"},"issue":{"href":"https://api.github.com/repos/smartcat-labs/data-loader/issues/32"},"comments":{"href":"https://api.github.com/repos/smartcat-labs/data-loader/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/smartcat-labs/data-loader/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/smartcat-labs/data-loader/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartcat-labs/data-loader/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/smartcat-labs/data-loader/statuses/ecccd53efccc3556aedbe7339f391293009952d2"}}}}
{"actor":{"display_login":"mgobec"}}