{"comment":{"url":"https://api.github.com/repos/meitar/buoy/comments/20083046","html_url":"https://github.com/meitar/buoy/commit/9e47b84d7be1c4d7605a2cadca1978f403a34d7c#commitcomment-20083046","id":20083046,"user":{"login":"hurtstotouchfire","id":1400344,"avatar_url":"https://avatars.githubusercontent.com/u/1400344?v=3","gravatar_id":"","url":"https://api.github.com/users/hurtstotouchfire","html_url":"https://github.com/hurtstotouchfire","followers_url":"https://api.github.com/users/hurtstotouchfire/followers","following_url":"https://api.github.com/users/hurtstotouchfire/following{/other_user}","gists_url":"https://api.github.com/users/hurtstotouchfire/gists{/gist_id}","starred_url":"https://api.github.com/users/hurtstotouchfire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hurtstotouchfire/subscriptions","organizations_url":"https://api.github.com/users/hurtstotouchfire/orgs","repos_url":"https://api.github.com/users/hurtstotouchfire/repos","events_url":"https://api.github.com/users/hurtstotouchfire/events{/privacy}","received_events_url":"https://api.github.com/users/hurtstotouchfire/received_events","type":"User","site_admin":false},"position":43,"line":43,"path":"includes/alert.js","commit_id":"9e47b84d7be1c4d7605a2cadca1978f403a34d7c","created_at":"2016-12-06T06:13:23Z","updated_at":"2016-12-06T06:13:23Z","body":"In general, I disagree. I prefer for configurable constants to be defined all in one readable place, early on. There are many cases where changing the publicly visible functionality of a method involves tweaking a constant, and I shouldn't have to wade through the implementation to do that. \r\n\r\nBut given that this particular implementation has the constant value early on in the function and it's very readable, I don't think any of my concerns apply, so this is fine."}}
{"actor":{"display_login":"hurtstotouchfire"}}