{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/93871614","pull_request_review_id":14405110,"id":93871614,"diff_hunk":"@@ -612,11 +612,11 @@ public function dateAdd($date, $interval, $datePart)\n \t{\n \t\tif (substr($interval, 0, 1) != '-')\n \t\t{\n-\t\t\treturn \"timestamp '\" . $date . \"' + interval '\" . $interval . \" \" . $datePart . \"'\";\n+\t\t\treturn \"timestamp '\" . $date . \"' + interval '\" . $interval . ' ' . $datePart . \"'\";\n \t\t}\n \t\telse\n \t\t{\n-\t\t\treturn \"timestamp '\" . $date . \"' - interval '\" . ltrim($interval, '-') . \" \" . $datePart . \"'\";\n+\t\t\treturn \"timestamp '\" . $date . \"' - interval '\" . ltrim($interval, '-') . ' ' . $datePart . \"'\";","path":"libraries/joomla/database/query/postgresql.php","position":10,"original_position":10,"commit_id":"5c091c89cd2ab5f2b008283abb64b2ffac33bb21","original_commit_id":"5c091c89cd2ab5f2b008283abb64b2ffac33bb21","user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"body":"same thing as the other. missing `'` and `\"` IMHO makes the code less readable","created_at":"2016-12-26T14:57:01Z","updated_at":"2016-12-26T15:00:53Z","html_url":"https://github.com/joomla/joomla-cms/pull/13372#discussion_r93871614","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13372","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/93871614"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/13372#discussion_r93871614"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/13372"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13372","id":99331629,"html_url":"https://github.com/joomla/joomla-cms/pull/13372","diff_url":"https://github.com/joomla/joomla-cms/pull/13372.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/13372.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13372","number":13372,"state":"open","locked":false,"title":"Unnecessary double quotes in  /libraries/joomla","user":{"login":"frankmayer","id":825497,"avatar_url":"https://avatars.githubusercontent.com/u/825497?v=3","gravatar_id":"","url":"https://api.github.com/users/frankmayer","html_url":"https://github.com/frankmayer","followers_url":"https://api.github.com/users/frankmayer/followers","following_url":"https://api.github.com/users/frankmayer/following{/other_user}","gists_url":"https://api.github.com/users/frankmayer/gists{/gist_id}","starred_url":"https://api.github.com/users/frankmayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankmayer/subscriptions","organizations_url":"https://api.github.com/users/frankmayer/orgs","repos_url":"https://api.github.com/users/frankmayer/repos","events_url":"https://api.github.com/users/frankmayer/events{/privacy}","received_events_url":"https://api.github.com/users/frankmayer/received_events","type":"User","site_admin":false},"body":"### Summary of Changes\r\n- Replace unnecessary double quotes in /libraries/joomla\r\n- Formatting\r\n\r\nA lot of changes in this one, but they are only from double quotes to single quotes, where appropriate. \r\nBesides the quantity of the changes, this PR should be fairly easy to review. No change in behavior is expected.\r\n\r\n### Testing Instructions\r\n\r\nNone, should not change behavior\r\n\r\n\r\n### Documentation Changes Required\r\n\r\nNone.\r\n","created_at":"2016-12-25T23:56:33Z","updated_at":"2016-12-26T15:00:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa0555bedca02a66c08a6870ebeb667ba378ed06","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13372/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13372/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13372/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/5c091c89cd2ab5f2b008283abb64b2ffac33bb21","head":{"label":"frankmayer:unnecessary-double-quotes-in-libraries-joomla","ref":"unnecessary-double-quotes-in-libraries-joomla","sha":"5c091c89cd2ab5f2b008283abb64b2ffac33bb21","user":{"login":"frankmayer","id":825497,"avatar_url":"https://avatars.githubusercontent.com/u/825497?v=3","gravatar_id":"","url":"https://api.github.com/users/frankmayer","html_url":"https://github.com/frankmayer","followers_url":"https://api.github.com/users/frankmayer/followers","following_url":"https://api.github.com/users/frankmayer/following{/other_user}","gists_url":"https://api.github.com/users/frankmayer/gists{/gist_id}","starred_url":"https://api.github.com/users/frankmayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankmayer/subscriptions","organizations_url":"https://api.github.com/users/frankmayer/orgs","repos_url":"https://api.github.com/users/frankmayer/repos","events_url":"https://api.github.com/users/frankmayer/events{/privacy}","received_events_url":"https://api.github.com/users/frankmayer/received_events","type":"User","site_admin":false},"repo":{"id":69169032,"name":"joomla-cms","full_name":"frankmayer/joomla-cms","owner":{"login":"frankmayer","id":825497,"avatar_url":"https://avatars.githubusercontent.com/u/825497?v=3","gravatar_id":"","url":"https://api.github.com/users/frankmayer","html_url":"https://github.com/frankmayer","followers_url":"https://api.github.com/users/frankmayer/followers","following_url":"https://api.github.com/users/frankmayer/following{/other_user}","gists_url":"https://api.github.com/users/frankmayer/gists{/gist_id}","starred_url":"https://api.github.com/users/frankmayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankmayer/subscriptions","organizations_url":"https://api.github.com/users/frankmayer/orgs","repos_url":"https://api.github.com/users/frankmayer/repos","events_url":"https://api.github.com/users/frankmayer/events{/privacy}","received_events_url":"https://api.github.com/users/frankmayer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/frankmayer/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/frankmayer/joomla-cms","forks_url":"https://api.github.com/repos/frankmayer/joomla-cms/forks","keys_url":"https://api.github.com/repos/frankmayer/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frankmayer/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frankmayer/joomla-cms/teams","hooks_url":"https://api.github.com/repos/frankmayer/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/frankmayer/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/frankmayer/joomla-cms/events","assignees_url":"https://api.github.com/repos/frankmayer/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/frankmayer/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/frankmayer/joomla-cms/tags","blobs_url":"https://api.github.com/repos/frankmayer/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frankmayer/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frankmayer/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/frankmayer/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frankmayer/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/frankmayer/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/frankmayer/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/frankmayer/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/frankmayer/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/frankmayer/joomla-cms/subscription","commits_url":"https://api.github.com/repos/frankmayer/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/frankmayer/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/frankmayer/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/frankmayer/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/frankmayer/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/frankmayer/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frankmayer/joomla-cms/merges","archive_url":"https://api.github.com/repos/frankmayer/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frankmayer/joomla-cms/downloads","issues_url":"https://api.github.com/repos/frankmayer/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/frankmayer/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/frankmayer/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/frankmayer/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frankmayer/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/frankmayer/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/frankmayer/joomla-cms/deployments","created_at":"2016-09-25T14:24:41Z","updated_at":"2016-09-25T14:24:55Z","pushed_at":"2016-12-26T14:14:58Z","git_url":"git://github.com/frankmayer/joomla-cms.git","ssh_url":"git@github.com:frankmayer/joomla-cms.git","clone_url":"https://github.com/frankmayer/joomla-cms.git","svn_url":"https://github.com/frankmayer/joomla-cms","homepage":"https://www.joomla.org","size":168603,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"d0842d521fe8b0fa944659ad5d0db59364cd5233","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2016-12-26T03:08:39Z","pushed_at":"2016-12-26T14:15:00Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":168963,"stargazers_count":2214,"watchers_count":2214,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2362,"mirror_url":null,"open_issues_count":570,"forks":2362,"open_issues":570,"watchers":2214,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/13372"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/13372"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/13372"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/13372/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/13372/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/13372/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/5c091c89cd2ab5f2b008283abb64b2ffac33bb21"}}}}
{"actor":{"display_login":"andrepereiradasilva"}}