{"action":"created","comment":{"url":"https://api.github.com/repos/inliniac/suricata/pulls/comments/80435830","id":80435830,"diff_hunk":"@@ -408,3 +416,39 @@ static void DetectFilestoreFree(void *ptr)\n         SCFree(ptr);\n     }\n }\n+\n+#ifdef UNITTESTS\n+/*\n+ * The purpose of this test is to confirm that\n+ * filestore and bypass keywords can't\n+ * can't work together\n+ */\n+static int DetectFilestoreTest01(void)\n+{\n+    DetectEngineCtx *de_ctx = NULL;\n+    int result = 1;\n+\n+    de_ctx = DetectEngineCtxInit();\n+    FAIL_IF(de_ctx == NULL);\n+\n+    de_ctx->flags |= DE_QUIET;\n+\n+    de_ctx->sig_list = SigInit(de_ctx,\"alert http any any -> any any \"\n+                               \"(bypass; filestore; \"\n+                               \"content:\\\"message\\\"; http_host; \"\n+                               \"sid:1;)\");\n+    FAIL_IF_NOT_NULL(de_ctx->sig_list);\n+\n+    if (de_ctx != NULL)","path":"src/detect-filestore.c","position":58,"original_position":58,"commit_id":"327be39ab633cc34d5ff3a9526599adad9b64380","original_commit_id":"327be39ab633cc34d5ff3a9526599adad9b64380","user":{"login":"regit","id":308616,"avatar_url":"https://avatars.githubusercontent.com/u/308616?v=3","gravatar_id":"","url":"https://api.github.com/users/regit","html_url":"https://github.com/regit","followers_url":"https://api.github.com/users/regit/followers","following_url":"https://api.github.com/users/regit/following{/other_user}","gists_url":"https://api.github.com/users/regit/gists{/gist_id}","starred_url":"https://api.github.com/users/regit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regit/subscriptions","organizations_url":"https://api.github.com/users/regit/orgs","repos_url":"https://api.github.com/users/regit/repos","events_url":"https://api.github.com/users/regit/events{/privacy}","received_events_url":"https://api.github.com/users/regit/received_events","type":"User","site_admin":false},"body":"ack","created_at":"2016-09-26T09:19:42Z","updated_at":"2016-09-26T09:19:42Z","html_url":"https://github.com/inliniac/suricata/pull/2282#discussion_r80435830","pull_request_url":"https://api.github.com/repos/inliniac/suricata/pulls/2282","_links":{"self":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/comments/80435830"},"html":{"href":"https://github.com/inliniac/suricata/pull/2282#discussion_r80435830"},"pull_request":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/2282"}}},"pull_request":{"url":"https://api.github.com/repos/inliniac/suricata/pulls/2282","id":86689621,"html_url":"https://github.com/inliniac/suricata/pull/2282","diff_url":"https://github.com/inliniac/suricata/pull/2282.diff","patch_url":"https://github.com/inliniac/suricata/pull/2282.patch","issue_url":"https://api.github.com/repos/inliniac/suricata/issues/2282","number":2282,"state":"open","locked":false,"title":"Bypass v9","user":{"login":"regit","id":308616,"avatar_url":"https://avatars.githubusercontent.com/u/308616?v=3","gravatar_id":"","url":"https://api.github.com/users/regit","html_url":"https://github.com/regit","followers_url":"https://api.github.com/users/regit/followers","following_url":"https://api.github.com/users/regit/following{/other_user}","gists_url":"https://api.github.com/users/regit/gists{/gist_id}","starred_url":"https://api.github.com/users/regit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regit/subscriptions","organizations_url":"https://api.github.com/users/regit/orgs","repos_url":"https://api.github.com/users/regit/repos","events_url":"https://api.github.com/users/regit/events{/privacy}","received_events_url":"https://api.github.com/users/regit/received_events","type":"User","site_admin":false},"body":"Update of #2278.\r\n\r\nCallback in capture method now return a status which allows to detect the bypass failure in lower level. A rebase has been done and flow flags had to be  updated to get some free room.\r\n\r\nPR builds:\r\n- PR regit: https://buildbot.openinfosecfoundation.org/builders/regit/builds/199\r\n- PR regit-pcap: https://buildbot.openinfosecfoundation.org/builders/regit-pcap/builds/195\r\n","created_at":"2016-09-26T06:53:00Z","updated_at":"2016-09-26T09:19:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbe3958955fbbb9a6c8e126fdb3d61cda5856f90","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/inliniac/suricata/pulls/2282/commits","review_comments_url":"https://api.github.com/repos/inliniac/suricata/pulls/2282/comments","review_comment_url":"https://api.github.com/repos/inliniac/suricata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inliniac/suricata/issues/2282/comments","statuses_url":"https://api.github.com/repos/inliniac/suricata/statuses/327be39ab633cc34d5ff3a9526599adad9b64380","head":{"label":"regit:bypass-v9","ref":"bypass-v9","sha":"327be39ab633cc34d5ff3a9526599adad9b64380","user":{"login":"regit","id":308616,"avatar_url":"https://avatars.githubusercontent.com/u/308616?v=3","gravatar_id":"","url":"https://api.github.com/users/regit","html_url":"https://github.com/regit","followers_url":"https://api.github.com/users/regit/followers","following_url":"https://api.github.com/users/regit/following{/other_user}","gists_url":"https://api.github.com/users/regit/gists{/gist_id}","starred_url":"https://api.github.com/users/regit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regit/subscriptions","organizations_url":"https://api.github.com/users/regit/orgs","repos_url":"https://api.github.com/users/regit/repos","events_url":"https://api.github.com/users/regit/events{/privacy}","received_events_url":"https://api.github.com/users/regit/received_events","type":"User","site_admin":false},"repo":{"id":5410368,"name":"suricata","full_name":"regit/suricata","owner":{"login":"regit","id":308616,"avatar_url":"https://avatars.githubusercontent.com/u/308616?v=3","gravatar_id":"","url":"https://api.github.com/users/regit","html_url":"https://github.com/regit","followers_url":"https://api.github.com/users/regit/followers","following_url":"https://api.github.com/users/regit/following{/other_user}","gists_url":"https://api.github.com/users/regit/gists{/gist_id}","starred_url":"https://api.github.com/users/regit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regit/subscriptions","organizations_url":"https://api.github.com/users/regit/orgs","repos_url":"https://api.github.com/users/regit/repos","events_url":"https://api.github.com/users/regit/events{/privacy}","received_events_url":"https://api.github.com/users/regit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/regit/suricata","description":"My personal development tree for Suricata.","fork":true,"url":"https://api.github.com/repos/regit/suricata","forks_url":"https://api.github.com/repos/regit/suricata/forks","keys_url":"https://api.github.com/repos/regit/suricata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/regit/suricata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/regit/suricata/teams","hooks_url":"https://api.github.com/repos/regit/suricata/hooks","issue_events_url":"https://api.github.com/repos/regit/suricata/issues/events{/number}","events_url":"https://api.github.com/repos/regit/suricata/events","assignees_url":"https://api.github.com/repos/regit/suricata/assignees{/user}","branches_url":"https://api.github.com/repos/regit/suricata/branches{/branch}","tags_url":"https://api.github.com/repos/regit/suricata/tags","blobs_url":"https://api.github.com/repos/regit/suricata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/regit/suricata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/regit/suricata/git/refs{/sha}","trees_url":"https://api.github.com/repos/regit/suricata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/regit/suricata/statuses/{sha}","languages_url":"https://api.github.com/repos/regit/suricata/languages","stargazers_url":"https://api.github.com/repos/regit/suricata/stargazers","contributors_url":"https://api.github.com/repos/regit/suricata/contributors","subscribers_url":"https://api.github.com/repos/regit/suricata/subscribers","subscription_url":"https://api.github.com/repos/regit/suricata/subscription","commits_url":"https://api.github.com/repos/regit/suricata/commits{/sha}","git_commits_url":"https://api.github.com/repos/regit/suricata/git/commits{/sha}","comments_url":"https://api.github.com/repos/regit/suricata/comments{/number}","issue_comment_url":"https://api.github.com/repos/regit/suricata/issues/comments{/number}","contents_url":"https://api.github.com/repos/regit/suricata/contents/{+path}","compare_url":"https://api.github.com/repos/regit/suricata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/regit/suricata/merges","archive_url":"https://api.github.com/repos/regit/suricata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/regit/suricata/downloads","issues_url":"https://api.github.com/repos/regit/suricata/issues{/number}","pulls_url":"https://api.github.com/repos/regit/suricata/pulls{/number}","milestones_url":"https://api.github.com/repos/regit/suricata/milestones{/number}","notifications_url":"https://api.github.com/repos/regit/suricata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/regit/suricata/labels{/name}","releases_url":"https://api.github.com/repos/regit/suricata/releases{/id}","deployments_url":"https://api.github.com/repos/regit/suricata/deployments","created_at":"2012-08-14T08:45:02Z","updated_at":"2016-04-11T00:50:36Z","pushed_at":"2016-09-25T23:28:21Z","git_url":"git://github.com/regit/suricata.git","ssh_url":"git@github.com:regit/suricata.git","clone_url":"https://github.com/regit/suricata.git","svn_url":"https://github.com/regit/suricata","homepage":"","size":31067,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":0,"forks":13,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"inliniac:master","ref":"master","sha":"70c16f50e733f6f7cc40c1bc3465eb966e3be517","user":{"login":"inliniac","id":719366,"avatar_url":"https://avatars.githubusercontent.com/u/719366?v=3","gravatar_id":"","url":"https://api.github.com/users/inliniac","html_url":"https://github.com/inliniac","followers_url":"https://api.github.com/users/inliniac/followers","following_url":"https://api.github.com/users/inliniac/following{/other_user}","gists_url":"https://api.github.com/users/inliniac/gists{/gist_id}","starred_url":"https://api.github.com/users/inliniac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inliniac/subscriptions","organizations_url":"https://api.github.com/users/inliniac/orgs","repos_url":"https://api.github.com/users/inliniac/repos","events_url":"https://api.github.com/users/inliniac/events{/privacy}","received_events_url":"https://api.github.com/users/inliniac/received_events","type":"User","site_admin":false},"repo":{"id":5410234,"name":"suricata","full_name":"inliniac/suricata","owner":{"login":"inliniac","id":719366,"avatar_url":"https://avatars.githubusercontent.com/u/719366?v=3","gravatar_id":"","url":"https://api.github.com/users/inliniac","html_url":"https://github.com/inliniac","followers_url":"https://api.github.com/users/inliniac/followers","following_url":"https://api.github.com/users/inliniac/following{/other_user}","gists_url":"https://api.github.com/users/inliniac/gists{/gist_id}","starred_url":"https://api.github.com/users/inliniac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inliniac/subscriptions","organizations_url":"https://api.github.com/users/inliniac/orgs","repos_url":"https://api.github.com/users/inliniac/repos","events_url":"https://api.github.com/users/inliniac/events{/privacy}","received_events_url":"https://api.github.com/users/inliniac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/inliniac/suricata","description":"Mirror of the official OISF Suricata git repository","fork":false,"url":"https://api.github.com/repos/inliniac/suricata","forks_url":"https://api.github.com/repos/inliniac/suricata/forks","keys_url":"https://api.github.com/repos/inliniac/suricata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inliniac/suricata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inliniac/suricata/teams","hooks_url":"https://api.github.com/repos/inliniac/suricata/hooks","issue_events_url":"https://api.github.com/repos/inliniac/suricata/issues/events{/number}","events_url":"https://api.github.com/repos/inliniac/suricata/events","assignees_url":"https://api.github.com/repos/inliniac/suricata/assignees{/user}","branches_url":"https://api.github.com/repos/inliniac/suricata/branches{/branch}","tags_url":"https://api.github.com/repos/inliniac/suricata/tags","blobs_url":"https://api.github.com/repos/inliniac/suricata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inliniac/suricata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inliniac/suricata/git/refs{/sha}","trees_url":"https://api.github.com/repos/inliniac/suricata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inliniac/suricata/statuses/{sha}","languages_url":"https://api.github.com/repos/inliniac/suricata/languages","stargazers_url":"https://api.github.com/repos/inliniac/suricata/stargazers","contributors_url":"https://api.github.com/repos/inliniac/suricata/contributors","subscribers_url":"https://api.github.com/repos/inliniac/suricata/subscribers","subscription_url":"https://api.github.com/repos/inliniac/suricata/subscription","commits_url":"https://api.github.com/repos/inliniac/suricata/commits{/sha}","git_commits_url":"https://api.github.com/repos/inliniac/suricata/git/commits{/sha}","comments_url":"https://api.github.com/repos/inliniac/suricata/comments{/number}","issue_comment_url":"https://api.github.com/repos/inliniac/suricata/issues/comments{/number}","contents_url":"https://api.github.com/repos/inliniac/suricata/contents/{+path}","compare_url":"https://api.github.com/repos/inliniac/suricata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inliniac/suricata/merges","archive_url":"https://api.github.com/repos/inliniac/suricata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inliniac/suricata/downloads","issues_url":"https://api.github.com/repos/inliniac/suricata/issues{/number}","pulls_url":"https://api.github.com/repos/inliniac/suricata/pulls{/number}","milestones_url":"https://api.github.com/repos/inliniac/suricata/milestones{/number}","notifications_url":"https://api.github.com/repos/inliniac/suricata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inliniac/suricata/labels{/name}","releases_url":"https://api.github.com/repos/inliniac/suricata/releases{/id}","deployments_url":"https://api.github.com/repos/inliniac/suricata/deployments","created_at":"2012-08-14T08:30:06Z","updated_at":"2016-09-24T13:58:28Z","pushed_at":"2016-09-26T07:51:44Z","git_url":"git://github.com/inliniac/suricata.git","ssh_url":"git@github.com:inliniac/suricata.git","clone_url":"https://github.com/inliniac/suricata.git","svn_url":"https://github.com/inliniac/suricata","homepage":"http://suricata-ids.org/","size":51432,"stargazers_count":309,"watchers_count":309,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":278,"mirror_url":null,"open_issues_count":29,"forks":278,"open_issues":29,"watchers":309,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/2282"},"html":{"href":"https://github.com/inliniac/suricata/pull/2282"},"issue":{"href":"https://api.github.com/repos/inliniac/suricata/issues/2282"},"comments":{"href":"https://api.github.com/repos/inliniac/suricata/issues/2282/comments"},"review_comments":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/2282/comments"},"review_comment":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/2282/commits"},"statuses":{"href":"https://api.github.com/repos/inliniac/suricata/statuses/327be39ab633cc34d5ff3a9526599adad9b64380"}}}}
{"actor":{"display_login":"regit"}}