{"action":"created","issue":{"url":"https://api.github.com/repos/uTox/uTox/issues/481","repository_url":"https://api.github.com/repos/uTox/uTox","labels_url":"https://api.github.com/repos/uTox/uTox/issues/481/labels{/name}","comments_url":"https://api.github.com/repos/uTox/uTox/issues/481/comments","events_url":"https://api.github.com/repos/uTox/uTox/issues/481/events","html_url":"https://github.com/uTox/uTox/pull/481","id":189516290,"number":481,"title":"[WIP] Fix avatars","user":{"login":"endoffile78","id":11342054,"avatar_url":"https://avatars.githubusercontent.com/u/11342054?v=3","gravatar_id":"","url":"https://api.github.com/users/endoffile78","html_url":"https://github.com/endoffile78","followers_url":"https://api.github.com/users/endoffile78/followers","following_url":"https://api.github.com/users/endoffile78/following{/other_user}","gists_url":"https://api.github.com/users/endoffile78/gists{/gist_id}","starred_url":"https://api.github.com/users/endoffile78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endoffile78/subscriptions","organizations_url":"https://api.github.com/users/endoffile78/orgs","repos_url":"https://api.github.com/users/endoffile78/repos","events_url":"https://api.github.com/users/endoffile78/events{/privacy}","received_events_url":"https://api.github.com/users/endoffile78/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"GrayHatter","id":243408,"avatar_url":"https://avatars.githubusercontent.com/u/243408?v=3","gravatar_id":"","url":"https://api.github.com/users/GrayHatter","html_url":"https://github.com/GrayHatter","followers_url":"https://api.github.com/users/GrayHatter/followers","following_url":"https://api.github.com/users/GrayHatter/following{/other_user}","gists_url":"https://api.github.com/users/GrayHatter/gists{/gist_id}","starred_url":"https://api.github.com/users/GrayHatter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrayHatter/subscriptions","organizations_url":"https://api.github.com/users/GrayHatter/orgs","repos_url":"https://api.github.com/users/GrayHatter/repos","events_url":"https://api.github.com/users/GrayHatter/events{/privacy}","received_events_url":"https://api.github.com/users/GrayHatter/received_events","type":"User","site_admin":false},"assignees":[{"login":"GrayHatter","id":243408,"avatar_url":"https://avatars.githubusercontent.com/u/243408?v=3","gravatar_id":"","url":"https://api.github.com/users/GrayHatter","html_url":"https://github.com/GrayHatter","followers_url":"https://api.github.com/users/GrayHatter/followers","following_url":"https://api.github.com/users/GrayHatter/following{/other_user}","gists_url":"https://api.github.com/users/GrayHatter/gists{/gist_id}","starred_url":"https://api.github.com/users/GrayHatter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrayHatter/subscriptions","organizations_url":"https://api.github.com/users/GrayHatter/orgs","repos_url":"https://api.github.com/users/GrayHatter/repos","events_url":"https://api.github.com/users/GrayHatter/events{/privacy}","received_events_url":"https://api.github.com/users/GrayHatter/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-11-15T21:47:19Z","updated_at":"2016-11-20T21:29:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/uTox/uTox/pulls/481","html_url":"https://github.com/uTox/uTox/pull/481","diff_url":"https://github.com/uTox/uTox/pull/481.diff","patch_url":"https://github.com/uTox/uTox/pull/481.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/utox/utox/481)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/uTox/uTox/issues/comments/261807192","html_url":"https://github.com/uTox/uTox/pull/481#issuecomment-261807192","issue_url":"https://api.github.com/repos/uTox/uTox/issues/481","id":261807192,"user":{"login":"endoffile78","id":11342054,"avatar_url":"https://avatars.githubusercontent.com/u/11342054?v=3","gravatar_id":"","url":"https://api.github.com/users/endoffile78","html_url":"https://github.com/endoffile78","followers_url":"https://api.github.com/users/endoffile78/followers","following_url":"https://api.github.com/users/endoffile78/following{/other_user}","gists_url":"https://api.github.com/users/endoffile78/gists{/gist_id}","starred_url":"https://api.github.com/users/endoffile78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endoffile78/subscriptions","organizations_url":"https://api.github.com/users/endoffile78/orgs","repos_url":"https://api.github.com/users/endoffile78/repos","events_url":"https://api.github.com/users/endoffile78/events{/privacy}","received_events_url":"https://api.github.com/users/endoffile78/received_events","type":"User","site_admin":false},"created_at":"2016-11-20T21:29:38Z","updated_at":"2016-11-20T21:29:38Z","body":"\n\n\n\nReview status: 3 of 6 files reviewed at latest revision, 5 unresolved discussions, some commit checks failed.\n\n---\n\n*[src/avatar.c, line 127 at r1](https://reviewable.io:443/reviews/utox/utox/481#-KWeHT0vxDFXl3fUWoCI:-KX2d9lo0LBdgPhbmEQm:b-896fix) ([raw file](https://github.com/utox/utox/blob/c08203a6a2b98a5601bbd2392969ba325ee7e817/src/avatar.c#L127)):*\n<details><summary><i>Previously, GrayHatter (Gregory Mullen) wrote…</i></summary>\n> Generate the filename in this function, then use the native function to get the `FILE*` and then read from inside this function.\n> \n> There's no reason anything outside of this file should know anything about avatars, or how they're saved or loaded.\n> \n> This is a change from the way it was/is but it's what needs to be done.\n> \n> Also: do we want to just keep this file in memory, instead of hitting the disk all the time?\n</details>\nDone.\n\n---\n\n*[src/avatar.c, line 16 at r2](https://reviewable.io:443/reviews/utox/utox/481#-KX2Yd-lm3DK2uQ9wXhF:-KX2d6TXdJMDvqX9cfxL:b-896fix) ([raw file](https://github.com/utox/utox/blob/5d25874b141fe50930443bc411e155c516ae971d/src/avatar.c#L16)):*\n<details><summary><i>Previously, GrayHatter (Gregory Mullen) wrote…</i></summary>\n> this was a magic number I needed to replace, it's `TOX_PUBLIC_KEY_SIZE * 2`\n</details>\nDone.\n\n---\n\n*[src/avatar.c, line 41 at r2](https://reviewable.io:443/reviews/utox/utox/481#-KX2YnTSj3LG-S9_yw0W:-KX2d7LWuyeVLYnq4WLe:b-896fix) ([raw file](https://github.com/utox/utox/blob/5d25874b141fe50930443bc411e155c516ae971d/src/avatar.c#L41)):*\n<details><summary><i>Previously, GrayHatter (Gregory Mullen) wrote…</i></summary>\n> ditto here and every where else `TOX_PUBLIC_KEY_SIZE * 2`\n</details>\nDone.\n\n---\n\n*[src/avatar.c, line 41 at r2](https://reviewable.io:443/reviews/utox/utox/481#-KX2Z-LVBdsVnbiHbl04:-KX2d7l-JEVyPg2CTe3Z:b-896fix) ([raw file](https://github.com/utox/utox/blob/5d25874b141fe50930443bc411e155c516ae971d/src/avatar.c#L41)):*\n<details><summary><i>Previously, GrayHatter (Gregory Mullen) wrote…</i></summary>\n> can we make this static?\n</details>\nDone.\n\n---\n\n*[src/file_transfers.c, line 859 at r2](https://reviewable.io:443/reviews/utox/utox/481#-KX2_JBxmlgxredcMO6s:-KX2dAqC7XAotdX2qktm:b-896fix) ([raw file](https://github.com/utox/utox/blob/5d25874b141fe50930443bc411e155c516ae971d/src/file_transfers.c#L859)):*\n<details><summary><i>Previously, GrayHatter (Gregory Mullen) wrote…</i></summary>\n> debug_error\n</details>\nDone.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/utox/utox/481)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"endoffile78"}}