{"action":"created","issue":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/3608","repository_url":"https://api.github.com/repos/RobotLocomotion/drake","labels_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/3608/labels{/name}","comments_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/3608/comments","events_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/3608/events","html_url":"https://github.com/RobotLocomotion/drake/issues/3608","id":179795379,"number":3608,"title":"DrakeJoints Contains Macros that Violate Style Guide","user":{"login":"liangfok","id":1388098,"avatar_url":"https://avatars.githubusercontent.com/u/1388098?v=3","gravatar_id":"","url":"https://api.github.com/users/liangfok","html_url":"https://github.com/liangfok","followers_url":"https://api.github.com/users/liangfok/followers","following_url":"https://api.github.com/users/liangfok/following{/other_user}","gists_url":"https://api.github.com/users/liangfok/gists{/gist_id}","starred_url":"https://api.github.com/users/liangfok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liangfok/subscriptions","organizations_url":"https://api.github.com/users/liangfok/orgs","repos_url":"https://api.github.com/users/liangfok/repos","events_url":"https://api.github.com/users/liangfok/events{/privacy}","received_events_url":"https://api.github.com/users/liangfok/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/RobotLocomotion/drake/labels/priority:%20high","name":"priority: high","color":"b60205"},{"url":"https://api.github.com/repos/RobotLocomotion/drake/labels/team:%20dynamics","name":"team: dynamics","color":"0052cc"},{"url":"https://api.github.com/repos/RobotLocomotion/drake/labels/type:%20design","name":"type: design","color":"0e8a16"},{"url":"https://api.github.com/repos/RobotLocomotion/drake/labels/type:%20feature%20request","name":"type: feature request","color":"0e8a16"}],"state":"open","locked":false,"assignee":{"login":"amcastro-tri","id":17601461,"avatar_url":"https://avatars.githubusercontent.com/u/17601461?v=3","gravatar_id":"","url":"https://api.github.com/users/amcastro-tri","html_url":"https://github.com/amcastro-tri","followers_url":"https://api.github.com/users/amcastro-tri/followers","following_url":"https://api.github.com/users/amcastro-tri/following{/other_user}","gists_url":"https://api.github.com/users/amcastro-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/amcastro-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amcastro-tri/subscriptions","organizations_url":"https://api.github.com/users/amcastro-tri/orgs","repos_url":"https://api.github.com/users/amcastro-tri/repos","events_url":"https://api.github.com/users/amcastro-tri/events{/privacy}","received_events_url":"https://api.github.com/users/amcastro-tri/received_events","type":"User","site_admin":false},"assignees":[{"login":"amcastro-tri","id":17601461,"avatar_url":"https://avatars.githubusercontent.com/u/17601461?v=3","gravatar_id":"","url":"https://api.github.com/users/amcastro-tri","html_url":"https://github.com/amcastro-tri","followers_url":"https://api.github.com/users/amcastro-tri/followers","following_url":"https://api.github.com/users/amcastro-tri/following{/other_user}","gists_url":"https://api.github.com/users/amcastro-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/amcastro-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amcastro-tri/subscriptions","organizations_url":"https://api.github.com/users/amcastro-tri/orgs","repos_url":"https://api.github.com/users/amcastro-tri/repos","events_url":"https://api.github.com/users/amcastro-tri/events{/privacy}","received_events_url":"https://api.github.com/users/amcastro-tri/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2016-09-28T14:49:50Z","updated_at":"2016-10-21T14:28:35Z","closed_at":null,"body":"`drake-distro/drake/systems/plants/joints/DrakeJoint.h` contains a macro called `POSITION_AND_VELOCITY_DEPENDENT_METHODS` that violates our style guide.\r\n\r\nFrom our [style guide](https://google.github.io/styleguide/cppguide.html#Preprocessor_Macros):\r\n\r\n> Don't use macros to define pieces of a C++ API.\r\n\r\nI encountered this issue when I tried to add Doxygen comment blocks to the methods that were defined via macro. It didn't work."},"comment":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/comments/255392142","html_url":"https://github.com/RobotLocomotion/drake/issues/3608#issuecomment-255392142","issue_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/3608","id":255392142,"user":{"login":"amcastro-tri","id":17601461,"avatar_url":"https://avatars.githubusercontent.com/u/17601461?v=3","gravatar_id":"","url":"https://api.github.com/users/amcastro-tri","html_url":"https://github.com/amcastro-tri","followers_url":"https://api.github.com/users/amcastro-tri/followers","following_url":"https://api.github.com/users/amcastro-tri/following{/other_user}","gists_url":"https://api.github.com/users/amcastro-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/amcastro-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amcastro-tri/subscriptions","organizations_url":"https://api.github.com/users/amcastro-tri/orgs","repos_url":"https://api.github.com/users/amcastro-tri/repos","events_url":"https://api.github.com/users/amcastro-tri/events{/privacy}","received_events_url":"https://api.github.com/users/amcastro-tri/received_events","type":"User","site_admin":false},"created_at":"2016-10-21T14:28:35Z","updated_at":"2016-10-21T14:28:35Z","body":"Not sure about that yet. @sherm1, didn't you have at the time an alternative solution to this? I remember some code from you in `simulator.h` [here](https://github.com/RobotLocomotion/drake/blob/348e8f73df8b5ed25539c41cc7f8a2993419fc83/drake/systems/analysis/simulator.h#L239) but removed by @jwnimmer-tri's PR #3802.\r\n"}}
{"actor":{"display_login":"amcastro-tri"}}