{"action":"created","issue":{"url":"https://api.github.com/repos/rails/rails/issues/26131","repository_url":"https://api.github.com/repos/rails/rails","labels_url":"https://api.github.com/repos/rails/rails/issues/26131/labels{/name}","comments_url":"https://api.github.com/repos/rails/rails/issues/26131/comments","events_url":"https://api.github.com/repos/rails/rails/issues/26131/events","html_url":"https://github.com/rails/rails/pull/26131","id":170800880,"number":26131,"title":"Remove dead code and ensure values are strings before calling gsub","user":{"login":"smellsblue","id":150632,"avatar_url":"https://avatars.githubusercontent.com/u/150632?v=3","gravatar_id":"","url":"https://api.github.com/users/smellsblue","html_url":"https://github.com/smellsblue","followers_url":"https://api.github.com/users/smellsblue/followers","following_url":"https://api.github.com/users/smellsblue/following{/other_user}","gists_url":"https://api.github.com/users/smellsblue/gists{/gist_id}","starred_url":"https://api.github.com/users/smellsblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smellsblue/subscriptions","organizations_url":"https://api.github.com/users/smellsblue/orgs","repos_url":"https://api.github.com/users/smellsblue/repos","events_url":"https://api.github.com/users/smellsblue/events{/privacy}","received_events_url":"https://api.github.com/users/smellsblue/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rails/rails/labels/actionview","name":"actionview","color":"d7e102"}],"state":"closed","locked":false,"assignee":{"login":"matthewd","id":1034,"avatar_url":"https://avatars.githubusercontent.com/u/1034?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewd","html_url":"https://github.com/matthewd","followers_url":"https://api.github.com/users/matthewd/followers","following_url":"https://api.github.com/users/matthewd/following{/other_user}","gists_url":"https://api.github.com/users/matthewd/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewd/subscriptions","organizations_url":"https://api.github.com/users/matthewd/orgs","repos_url":"https://api.github.com/users/matthewd/repos","events_url":"https://api.github.com/users/matthewd/events{/privacy}","received_events_url":"https://api.github.com/users/matthewd/received_events","type":"User","site_admin":false},"assignees":[{"login":"matthewd","id":1034,"avatar_url":"https://avatars.githubusercontent.com/u/1034?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewd","html_url":"https://github.com/matthewd","followers_url":"https://api.github.com/users/matthewd/followers","following_url":"https://api.github.com/users/matthewd/following{/other_user}","gists_url":"https://api.github.com/users/matthewd/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewd/subscriptions","organizations_url":"https://api.github.com/users/matthewd/orgs","repos_url":"https://api.github.com/users/matthewd/repos","events_url":"https://api.github.com/users/matthewd/events{/privacy}","received_events_url":"https://api.github.com/users/matthewd/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2016-08-12T05:22:29Z","updated_at":"2016-08-17T18:13:14Z","closed_at":"2016-08-12T06:12:07Z","pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/26131","html_url":"https://github.com/rails/rails/pull/26131","diff_url":"https://github.com/rails/rails/pull/26131.diff","patch_url":"https://github.com/rails/rails/pull/26131.patch"},"body":"There is a new bug introduced from this recent commit: https://github.com/rails/rails/commit/4bcccf5ecd81a6272479537911b7d9760c5be164\r\n\r\nIf you are not escaping and you have an attribute value that isn't a string, this used to work, but now the `gsub` call will cause an error.\r\n\r\nI also noticed a dead line of code added from that commit, which I've removed.\r\n\r\nThanks to @esb for this comment: https://github.com/rails/rails/commit/4bcccf5ecd81a6272479537911b7d9760c5be164#commitcomment-18616328\r\n\r\nI found this in our usage of 3.2, but it appears like this will affect the other stable releases too (minus the dead code bit it appears). Please let me know if you would rather I open this against master instead.\r\n\r\n/cc @andrewcarpenter @tenderlove "},"comment":{"url":"https://api.github.com/repos/rails/rails/issues/comments/240498801","html_url":"https://github.com/rails/rails/pull/26131#issuecomment-240498801","issue_url":"https://api.github.com/repos/rails/rails/issues/26131","id":240498801,"user":{"login":"rafaelfranca","id":47848,"avatar_url":"https://avatars.githubusercontent.com/u/47848?v=3","gravatar_id":"","url":"https://api.github.com/users/rafaelfranca","html_url":"https://github.com/rafaelfranca","followers_url":"https://api.github.com/users/rafaelfranca/followers","following_url":"https://api.github.com/users/rafaelfranca/following{/other_user}","gists_url":"https://api.github.com/users/rafaelfranca/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelfranca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelfranca/subscriptions","organizations_url":"https://api.github.com/users/rafaelfranca/orgs","repos_url":"https://api.github.com/users/rafaelfranca/repos","events_url":"https://api.github.com/users/rafaelfranca/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelfranca/received_events","type":"User","site_admin":false},"created_at":"2016-08-17T18:13:13Z","updated_at":"2016-08-17T18:13:13Z","body":"We don't plan releases for 3.2. It is a non supported version and we sometimes release security patches on it. I recommend to use the stable branch "}}
{"actor":{"display_login":"rafaelfranca"}}