{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/86332993","pull_request_review_id":6995601,"id":86332993,"diff_hunk":"@@ -1,38 +1,53 @@\n #!/bin/bash\n \n-\n-git_origin=$(git config --get remote.origin.url | sed 's/.\\+[\\/:]\\([^\\/]\\+\\/[^\\/]\\+\\)$/\\1/')\n-git_branch=$(git rev-parse --abbrev-ref HEAD)\n-v8ver=${1:-v8} #default v8\n-svn_prefix=https://github.com\n-svn_path=\"$svn_prefix/$git_origin/branches/$git_branch/deps/$v8ver\"\n-#svn_path=\"$git_origin/branches/$git_branch/deps/$v8ver\"\n-gclient_string=\"solutions = [{'name': 'v8', 'url': '$svn_path', 'managed': False}]\"\n+if [ $# -eq 0 ]; then\n+  # Default branch is master\n+  BRANCH=\"master\"\n+else\n+  # eg: 5.4-lkgr\n+  BRANCH=\"$1\"\n+fi\n \n # clean up if someone presses ctrl-c\n trap cleanup INT\n \n function cleanup() {\n   trap - INT\n-\n   rm .gclient || true\n   rm .gclient_entries || true\n   rm -rf _bad_scm/ || true\n-\n-  #if v8ver isn't v8, move the v8 folders\n-  #back to what they were\n-  if [ \"$v8ver\" != \"v8\" ]; then\n-    mv v8 $v8ver\n-    mv .v8old v8\n+  if [ \"$BRANCH\" == \"master\" ]; then\n+    echo \"git cleanup if branch is master\"","path":"tools/make-v8.sh","position":35,"original_position":35,"commit_id":"73e7c69f2f8f25915cf37a5c4fd7f88774305584","original_commit_id":"3c54a7ea238b7e72ab24a925645bd7e889e0fbb2","user":{"login":"jbajwa","id":577562,"avatar_url":"https://avatars.githubusercontent.com/u/577562?v=3","gravatar_id":"","url":"https://api.github.com/users/jbajwa","html_url":"https://github.com/jbajwa","followers_url":"https://api.github.com/users/jbajwa/followers","following_url":"https://api.github.com/users/jbajwa/following{/other_user}","gists_url":"https://api.github.com/users/jbajwa/gists{/gist_id}","starred_url":"https://api.github.com/users/jbajwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbajwa/subscriptions","organizations_url":"https://api.github.com/users/jbajwa/orgs","repos_url":"https://api.github.com/users/jbajwa/repos","events_url":"https://api.github.com/users/jbajwa/events{/privacy}","received_events_url":"https://api.github.com/users/jbajwa/received_events","type":"User","site_admin":false},"body":"we only need the cleanup for the v8 bundled with node (here master would be v8 master). If you want to test eg v8@5.5, then you don't need the cleanup since thats not the v8 bundled with node and can be tested standalone. Use case for that would be, if you want to test a specific v8 version before merging into node.","created_at":"2016-11-03T12:38:03Z","updated_at":"2016-11-03T12:38:03Z","html_url":"https://github.com/nodejs/node/pull/9393#discussion_r86332993","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/9393","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/86332993"},"html":{"href":"https://github.com/nodejs/node/pull/9393#discussion_r86332993"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/9393"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/9393","id":91740766,"html_url":"https://github.com/nodejs/node/pull/9393","diff_url":"https://github.com/nodejs/node/pull/9393.diff","patch_url":"https://github.com/nodejs/node/pull/9393.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/9393","number":9393,"state":"open","locked":false,"title":"v8: update make-v8.sh to use git","user":{"login":"jbajwa","id":577562,"avatar_url":"https://avatars.githubusercontent.com/u/577562?v=3","gravatar_id":"","url":"https://api.github.com/users/jbajwa","html_url":"https://github.com/jbajwa","followers_url":"https://api.github.com/users/jbajwa/followers","following_url":"https://api.github.com/users/jbajwa/following{/other_user}","gists_url":"https://api.github.com/users/jbajwa/gists{/gist_id}","starred_url":"https://api.github.com/users/jbajwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbajwa/subscriptions","organizations_url":"https://api.github.com/users/jbajwa/orgs","repos_url":"https://api.github.com/users/jbajwa/repos","events_url":"https://api.github.com/users/jbajwa/events{/privacy}","received_events_url":"https://api.github.com/users/jbajwa/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j8 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\nv8\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\n\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\n\r\ngoogle build tool gclient doesn't support svn anymore. Updating v8 build script \r\nto use git instead. More info #9222 ","created_at":"2016-11-01T07:10:23Z","updated_at":"2016-11-03T12:38:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5be558a77e377208229bc04a057f71f1b5c36e7f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/9393/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/9393/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/9393/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/73e7c69f2f8f25915cf37a5c4fd7f88774305584","head":{"label":"jbajwa:patch-make-v8","ref":"patch-make-v8","sha":"73e7c69f2f8f25915cf37a5c4fd7f88774305584","user":{"login":"jbajwa","id":577562,"avatar_url":"https://avatars.githubusercontent.com/u/577562?v=3","gravatar_id":"","url":"https://api.github.com/users/jbajwa","html_url":"https://github.com/jbajwa","followers_url":"https://api.github.com/users/jbajwa/followers","following_url":"https://api.github.com/users/jbajwa/following{/other_user}","gists_url":"https://api.github.com/users/jbajwa/gists{/gist_id}","starred_url":"https://api.github.com/users/jbajwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbajwa/subscriptions","organizations_url":"https://api.github.com/users/jbajwa/orgs","repos_url":"https://api.github.com/users/jbajwa/repos","events_url":"https://api.github.com/users/jbajwa/events{/privacy}","received_events_url":"https://api.github.com/users/jbajwa/received_events","type":"User","site_admin":false},"repo":{"id":71738470,"name":"node","full_name":"jbajwa/node","owner":{"login":"jbajwa","id":577562,"avatar_url":"https://avatars.githubusercontent.com/u/577562?v=3","gravatar_id":"","url":"https://api.github.com/users/jbajwa","html_url":"https://github.com/jbajwa","followers_url":"https://api.github.com/users/jbajwa/followers","following_url":"https://api.github.com/users/jbajwa/following{/other_user}","gists_url":"https://api.github.com/users/jbajwa/gists{/gist_id}","starred_url":"https://api.github.com/users/jbajwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbajwa/subscriptions","organizations_url":"https://api.github.com/users/jbajwa/orgs","repos_url":"https://api.github.com/users/jbajwa/repos","events_url":"https://api.github.com/users/jbajwa/events{/privacy}","received_events_url":"https://api.github.com/users/jbajwa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jbajwa/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/jbajwa/node","forks_url":"https://api.github.com/repos/jbajwa/node/forks","keys_url":"https://api.github.com/repos/jbajwa/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbajwa/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbajwa/node/teams","hooks_url":"https://api.github.com/repos/jbajwa/node/hooks","issue_events_url":"https://api.github.com/repos/jbajwa/node/issues/events{/number}","events_url":"https://api.github.com/repos/jbajwa/node/events","assignees_url":"https://api.github.com/repos/jbajwa/node/assignees{/user}","branches_url":"https://api.github.com/repos/jbajwa/node/branches{/branch}","tags_url":"https://api.github.com/repos/jbajwa/node/tags","blobs_url":"https://api.github.com/repos/jbajwa/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbajwa/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbajwa/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbajwa/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbajwa/node/statuses/{sha}","languages_url":"https://api.github.com/repos/jbajwa/node/languages","stargazers_url":"https://api.github.com/repos/jbajwa/node/stargazers","contributors_url":"https://api.github.com/repos/jbajwa/node/contributors","subscribers_url":"https://api.github.com/repos/jbajwa/node/subscribers","subscription_url":"https://api.github.com/repos/jbajwa/node/subscription","commits_url":"https://api.github.com/repos/jbajwa/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbajwa/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbajwa/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbajwa/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbajwa/node/contents/{+path}","compare_url":"https://api.github.com/repos/jbajwa/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbajwa/node/merges","archive_url":"https://api.github.com/repos/jbajwa/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbajwa/node/downloads","issues_url":"https://api.github.com/repos/jbajwa/node/issues{/number}","pulls_url":"https://api.github.com/repos/jbajwa/node/pulls{/number}","milestones_url":"https://api.github.com/repos/jbajwa/node/milestones{/number}","notifications_url":"https://api.github.com/repos/jbajwa/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbajwa/node/labels{/name}","releases_url":"https://api.github.com/repos/jbajwa/node/releases{/id}","deployments_url":"https://api.github.com/repos/jbajwa/node/deployments","created_at":"2016-10-24T00:33:26Z","updated_at":"2016-10-24T00:33:50Z","pushed_at":"2016-11-03T12:34:39Z","git_url":"git://github.com/jbajwa/node.git","ssh_url":"git@github.com:jbajwa/node.git","clone_url":"https://github.com/jbajwa/node.git","svn_url":"https://github.com/jbajwa/node","homepage":"https://nodejs.org","size":242902,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"21427fded9ee8bb7b4eabbc1d75ed2355ac64b54","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-11-03T10:43:16Z","pushed_at":"2016-11-03T12:34:40Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":358615,"stargazers_count":28567,"watchers_count":28567,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4753,"mirror_url":null,"open_issues_count":873,"forks":4753,"open_issues":873,"watchers":28567,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/9393"},"html":{"href":"https://github.com/nodejs/node/pull/9393"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/9393"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/9393/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/9393/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/9393/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/73e7c69f2f8f25915cf37a5c4fd7f88774305584"}}}}
{"actor":{"display_login":"jbajwa"}}