{"action":"closed","number":268,"pull_request":{"url":"https://api.github.com/repos/cfpb/hmda-platform/pulls/268","id":64555944,"html_url":"https://github.com/cfpb/hmda-platform/pull/268","diff_url":"https://github.com/cfpb/hmda-platform/pull/268.diff","patch_url":"https://github.com/cfpb/hmda-platform/pull/268.patch","issue_url":"https://api.github.com/repos/cfpb/hmda-platform/issues/268","number":268,"state":"closed","locked":false,"title":"implement V340","user":{"login":"lgdean","id":371459,"avatar_url":"https://avatars.githubusercontent.com/u/371459?v=3","gravatar_id":"","url":"https://api.github.com/users/lgdean","html_url":"https://github.com/lgdean","followers_url":"https://api.github.com/users/lgdean/followers","following_url":"https://api.github.com/users/lgdean/following{/other_user}","gists_url":"https://api.github.com/users/lgdean/gists{/gist_id}","starred_url":"https://api.github.com/users/lgdean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgdean/subscriptions","organizations_url":"https://api.github.com/users/lgdean/orgs","repos_url":"https://api.github.com/users/lgdean/repos","events_url":"https://api.github.com/users/lgdean/events{/privacy}","received_events_url":"https://api.github.com/users/lgdean/received_events","type":"User","site_admin":false},"body":"#158 \r\n\r\nI raised one question in a comment (which we may or may not address now, but if not, doing things this way may become a default).  I also wonder about conventions for naming tests, as these names may not follow any existing one.  (There's should vs must vs just-plain does, for one thing.  Do we want to standardize yet? Ever?)","created_at":"2016-03-30T00:35:24Z","updated_at":"2016-03-31T20:14:30Z","closed_at":"2016-03-31T20:14:30Z","merged_at":"2016-03-31T20:14:30Z","merge_commit_sha":"84ec92a379699c99a377d5570b82abd93e150323","assignee":{"login":"jmarin","id":438146,"avatar_url":"https://avatars.githubusercontent.com/u/438146?v=3","gravatar_id":"","url":"https://api.github.com/users/jmarin","html_url":"https://github.com/jmarin","followers_url":"https://api.github.com/users/jmarin/followers","following_url":"https://api.github.com/users/jmarin/following{/other_user}","gists_url":"https://api.github.com/users/jmarin/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarin/subscriptions","organizations_url":"https://api.github.com/users/jmarin/orgs","repos_url":"https://api.github.com/users/jmarin/repos","events_url":"https://api.github.com/users/jmarin/events{/privacy}","received_events_url":"https://api.github.com/users/jmarin/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/cfpb/hmda-platform/pulls/268/commits","review_comments_url":"https://api.github.com/repos/cfpb/hmda-platform/pulls/268/comments","review_comment_url":"https://api.github.com/repos/cfpb/hmda-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cfpb/hmda-platform/issues/268/comments","statuses_url":"https://api.github.com/repos/cfpb/hmda-platform/statuses/86be39393a9af666ddf5bc578602f9f344b71e04","head":{"label":"lgdean:V340-purchaser-type","ref":"V340-purchaser-type","sha":"86be39393a9af666ddf5bc578602f9f344b71e04","user":{"login":"lgdean","id":371459,"avatar_url":"https://avatars.githubusercontent.com/u/371459?v=3","gravatar_id":"","url":"https://api.github.com/users/lgdean","html_url":"https://github.com/lgdean","followers_url":"https://api.github.com/users/lgdean/followers","following_url":"https://api.github.com/users/lgdean/following{/other_user}","gists_url":"https://api.github.com/users/lgdean/gists{/gist_id}","starred_url":"https://api.github.com/users/lgdean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgdean/subscriptions","organizations_url":"https://api.github.com/users/lgdean/orgs","repos_url":"https://api.github.com/users/lgdean/repos","events_url":"https://api.github.com/users/lgdean/events{/privacy}","received_events_url":"https://api.github.com/users/lgdean/received_events","type":"User","site_admin":false},"repo":{"id":50669709,"name":"hmda-platform","full_name":"lgdean/hmda-platform","owner":{"login":"lgdean","id":371459,"avatar_url":"https://avatars.githubusercontent.com/u/371459?v=3","gravatar_id":"","url":"https://api.github.com/users/lgdean","html_url":"https://github.com/lgdean","followers_url":"https://api.github.com/users/lgdean/followers","following_url":"https://api.github.com/users/lgdean/following{/other_user}","gists_url":"https://api.github.com/users/lgdean/gists{/gist_id}","starred_url":"https://api.github.com/users/lgdean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgdean/subscriptions","organizations_url":"https://api.github.com/users/lgdean/orgs","repos_url":"https://api.github.com/users/lgdean/repos","events_url":"https://api.github.com/users/lgdean/events{/privacy}","received_events_url":"https://api.github.com/users/lgdean/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lgdean/hmda-platform","description":"","fork":true,"url":"https://api.github.com/repos/lgdean/hmda-platform","forks_url":"https://api.github.com/repos/lgdean/hmda-platform/forks","keys_url":"https://api.github.com/repos/lgdean/hmda-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lgdean/hmda-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lgdean/hmda-platform/teams","hooks_url":"https://api.github.com/repos/lgdean/hmda-platform/hooks","issue_events_url":"https://api.github.com/repos/lgdean/hmda-platform/issues/events{/number}","events_url":"https://api.github.com/repos/lgdean/hmda-platform/events","assignees_url":"https://api.github.com/repos/lgdean/hmda-platform/assignees{/user}","branches_url":"https://api.github.com/repos/lgdean/hmda-platform/branches{/branch}","tags_url":"https://api.github.com/repos/lgdean/hmda-platform/tags","blobs_url":"https://api.github.com/repos/lgdean/hmda-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lgdean/hmda-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lgdean/hmda-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/lgdean/hmda-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lgdean/hmda-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/lgdean/hmda-platform/languages","stargazers_url":"https://api.github.com/repos/lgdean/hmda-platform/stargazers","contributors_url":"https://api.github.com/repos/lgdean/hmda-platform/contributors","subscribers_url":"https://api.github.com/repos/lgdean/hmda-platform/subscribers","subscription_url":"https://api.github.com/repos/lgdean/hmda-platform/subscription","commits_url":"https://api.github.com/repos/lgdean/hmda-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/lgdean/hmda-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/lgdean/hmda-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/lgdean/hmda-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/lgdean/hmda-platform/contents/{+path}","compare_url":"https://api.github.com/repos/lgdean/hmda-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lgdean/hmda-platform/merges","archive_url":"https://api.github.com/repos/lgdean/hmda-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lgdean/hmda-platform/downloads","issues_url":"https://api.github.com/repos/lgdean/hmda-platform/issues{/number}","pulls_url":"https://api.github.com/repos/lgdean/hmda-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/lgdean/hmda-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/lgdean/hmda-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lgdean/hmda-platform/labels{/name}","releases_url":"https://api.github.com/repos/lgdean/hmda-platform/releases{/id}","deployments_url":"https://api.github.com/repos/lgdean/hmda-platform/deployments","created_at":"2016-01-29T15:06:27Z","updated_at":"2016-02-23T01:42:55Z","pushed_at":"2016-03-31T19:55:14Z","git_url":"git://github.com/lgdean/hmda-platform.git","ssh_url":"git@github.com:lgdean/hmda-platform.git","clone_url":"https://github.com/lgdean/hmda-platform.git","svn_url":"https://github.com/lgdean/hmda-platform","homepage":"","size":729,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cfpb:master","ref":"master","sha":"256a49b4dfbe2a29dfcc4b5893370cc34ac86796","user":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"repo":{"id":50141662,"name":"hmda-platform","full_name":"cfpb/hmda-platform","owner":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfpb/hmda-platform","description":"","fork":false,"url":"https://api.github.com/repos/cfpb/hmda-platform","forks_url":"https://api.github.com/repos/cfpb/hmda-platform/forks","keys_url":"https://api.github.com/repos/cfpb/hmda-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfpb/hmda-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfpb/hmda-platform/teams","hooks_url":"https://api.github.com/repos/cfpb/hmda-platform/hooks","issue_events_url":"https://api.github.com/repos/cfpb/hmda-platform/issues/events{/number}","events_url":"https://api.github.com/repos/cfpb/hmda-platform/events","assignees_url":"https://api.github.com/repos/cfpb/hmda-platform/assignees{/user}","branches_url":"https://api.github.com/repos/cfpb/hmda-platform/branches{/branch}","tags_url":"https://api.github.com/repos/cfpb/hmda-platform/tags","blobs_url":"https://api.github.com/repos/cfpb/hmda-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfpb/hmda-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfpb/hmda-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfpb/hmda-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfpb/hmda-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/cfpb/hmda-platform/languages","stargazers_url":"https://api.github.com/repos/cfpb/hmda-platform/stargazers","contributors_url":"https://api.github.com/repos/cfpb/hmda-platform/contributors","subscribers_url":"https://api.github.com/repos/cfpb/hmda-platform/subscribers","subscription_url":"https://api.github.com/repos/cfpb/hmda-platform/subscription","commits_url":"https://api.github.com/repos/cfpb/hmda-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfpb/hmda-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfpb/hmda-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfpb/hmda-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfpb/hmda-platform/contents/{+path}","compare_url":"https://api.github.com/repos/cfpb/hmda-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfpb/hmda-platform/merges","archive_url":"https://api.github.com/repos/cfpb/hmda-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfpb/hmda-platform/downloads","issues_url":"https://api.github.com/repos/cfpb/hmda-platform/issues{/number}","pulls_url":"https://api.github.com/repos/cfpb/hmda-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/cfpb/hmda-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/cfpb/hmda-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfpb/hmda-platform/labels{/name}","releases_url":"https://api.github.com/repos/cfpb/hmda-platform/releases{/id}","deployments_url":"https://api.github.com/repos/cfpb/hmda-platform/deployments","created_at":"2016-01-21T22:39:17Z","updated_at":"2016-03-18T23:37:13Z","pushed_at":"2016-03-31T20:14:30Z","git_url":"git://github.com/cfpb/hmda-platform.git","ssh_url":"git@github.com:cfpb/hmda-platform.git","clone_url":"https://github.com/cfpb/hmda-platform.git","svn_url":"https://github.com/cfpb/hmda-platform","homepage":"","size":757,"stargazers_count":2,"watchers_count":2,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":200,"forks":6,"open_issues":200,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cfpb/hmda-platform/pulls/268"},"html":{"href":"https://github.com/cfpb/hmda-platform/pull/268"},"issue":{"href":"https://api.github.com/repos/cfpb/hmda-platform/issues/268"},"comments":{"href":"https://api.github.com/repos/cfpb/hmda-platform/issues/268/comments"},"review_comments":{"href":"https://api.github.com/repos/cfpb/hmda-platform/pulls/268/comments"},"review_comment":{"href":"https://api.github.com/repos/cfpb/hmda-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cfpb/hmda-platform/pulls/268/commits"},"statuses":{"href":"https://api.github.com/repos/cfpb/hmda-platform/statuses/86be39393a9af666ddf5bc578602f9f344b71e04"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jmarin","id":438146,"avatar_url":"https://avatars.githubusercontent.com/u/438146?v=3","gravatar_id":"","url":"https://api.github.com/users/jmarin","html_url":"https://github.com/jmarin","followers_url":"https://api.github.com/users/jmarin/followers","following_url":"https://api.github.com/users/jmarin/following{/other_user}","gists_url":"https://api.github.com/users/jmarin/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarin/subscriptions","organizations_url":"https://api.github.com/users/jmarin/orgs","repos_url":"https://api.github.com/users/jmarin/repos","events_url":"https://api.github.com/users/jmarin/events{/privacy}","received_events_url":"https://api.github.com/users/jmarin/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"commits":2,"additions":39,"deletions":2,"changed_files":3}}