{"comment":{"url":"https://api.github.com/repos/apache/flink/comments/19376219","html_url":"https://github.com/apache/flink/commit/6731ec1e48d0a0092dd2330adda73bcf37fda8d7#commitcomment-19376219","id":19376219,"user":{"login":"StephanEwen","id":1727146,"avatar_url":"https://avatars.githubusercontent.com/u/1727146?v=3","gravatar_id":"","url":"https://api.github.com/users/StephanEwen","html_url":"https://github.com/StephanEwen","followers_url":"https://api.github.com/users/StephanEwen/followers","following_url":"https://api.github.com/users/StephanEwen/following{/other_user}","gists_url":"https://api.github.com/users/StephanEwen/gists{/gist_id}","starred_url":"https://api.github.com/users/StephanEwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephanEwen/subscriptions","organizations_url":"https://api.github.com/users/StephanEwen/orgs","repos_url":"https://api.github.com/users/StephanEwen/repos","events_url":"https://api.github.com/users/StephanEwen/events{/privacy}","received_events_url":"https://api.github.com/users/StephanEwen/received_events","type":"User","site_admin":false},"position":77,"line":162,"path":"flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/testutils/DataGenerators.java","commit_id":"6731ec1e48d0a0092dd2330adda73bcf37fda8d7","created_at":"2016-10-11T12:01:58Z","updated_at":"2016-10-11T12:01:58Z","body":"That seems like a hack that throws the next person looking into this code off. I think pulling the function out into a dedicated (static, non-anonymous) class is the clean way to go."}}
{"actor":{"display_login":"StephanEwen"}}