{"action":"created","comment":{"url":"https://api.github.com/repos/trillek-team/tec/pulls/comments/84840105","pull_request_review_id":5589894,"id":84840105,"diff_hunk":"@@ -24,27 +24,27 @@ namespace tec {\n \ttypedef std::uint32_t tid; /// Type ID\n \n \t/// Returns the name of an component on compile time\n-\ttemplate<class TYPE> const char* GetTypeName(void) { return \"UNKNOWN\"; }\n+\ttemplate<class TYPE> constexpr const char* GetTypeName(void) { return \"UNKNOWN\"; }\n \t/// Returns the TypeID of a component on compile time\n-\ttemplate<class TYPE> const tid GetTypeID(void) { return proto::Component::COMPONENT_NOT_SET; }\n+\ttemplate<class TYPE> constexpr tid GetTypeID(void) { return proto::Component::COMPONENT_NOT_SET; }\n \t/// Returns the name of a resource type on Compile time\n-\ttemplate<class TYPE> const char* GetTypeEXT(void) { return \"UNKNOWN\"; }\n+\ttemplate<class TYPE> constexpr const char* GetTypeEXT(void) { return \"UNKNOWN\"; }","path":"common/types.hpp","position":11,"original_position":11,"commit_id":"9b7eec3492730cf746a628d5cc025cf31dc37eb2","original_commit_id":"9b7eec3492730cf746a628d5cc025cf31dc37eb2","user":{"login":"milesrout","id":5534373,"avatar_url":"https://avatars.githubusercontent.com/u/5534373?v=3","gravatar_id":"","url":"https://api.github.com/users/milesrout","html_url":"https://github.com/milesrout","followers_url":"https://api.github.com/users/milesrout/followers","following_url":"https://api.github.com/users/milesrout/following{/other_user}","gists_url":"https://api.github.com/users/milesrout/gists{/gist_id}","starred_url":"https://api.github.com/users/milesrout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milesrout/subscriptions","organizations_url":"https://api.github.com/users/milesrout/orgs","repos_url":"https://api.github.com/users/milesrout/repos","events_url":"https://api.github.com/users/milesrout/events{/privacy}","received_events_url":"https://api.github.com/users/milesrout/received_events","type":"User","site_admin":false},"body":"i'm still pretty sure this stuff isn't necessary","created_at":"2016-10-25T06:54:31Z","updated_at":"2016-10-25T06:55:33Z","html_url":"https://github.com/trillek-team/tec/pull/110#discussion_r84840105","pull_request_url":"https://api.github.com/repos/trillek-team/tec/pulls/110","_links":{"self":{"href":"https://api.github.com/repos/trillek-team/tec/pulls/comments/84840105"},"html":{"href":"https://github.com/trillek-team/tec/pull/110#discussion_r84840105"},"pull_request":{"href":"https://api.github.com/repos/trillek-team/tec/pulls/110"}}},"pull_request":{"url":"https://api.github.com/repos/trillek-team/tec/pulls/110","id":90746996,"html_url":"https://github.com/trillek-team/tec/pull/110","diff_url":"https://github.com/trillek-team/tec/pull/110.diff","patch_url":"https://github.com/trillek-team/tec/pull/110.patch","issue_url":"https://api.github.com/repos/trillek-team/tec/issues/110","number":110,"state":"open","locked":false,"title":"Const correctness and GameStateQueue","user":{"login":"adam4813","id":3011917,"avatar_url":"https://avatars.githubusercontent.com/u/3011917?v=3","gravatar_id":"","url":"https://api.github.com/users/adam4813","html_url":"https://github.com/adam4813","followers_url":"https://api.github.com/users/adam4813/followers","following_url":"https://api.github.com/users/adam4813/following{/other_user}","gists_url":"https://api.github.com/users/adam4813/gists{/gist_id}","starred_url":"https://api.github.com/users/adam4813/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam4813/subscriptions","organizations_url":"https://api.github.com/users/adam4813/orgs","repos_url":"https://api.github.com/users/adam4813/repos","events_url":"https://api.github.com/users/adam4813/events{/privacy}","received_events_url":"https://api.github.com/users/adam4813/received_events","type":"User","site_admin":false},"body":"Does lots of const correctness fixes and adds GameStateQueue to introduce a separation of concerns with simulation and GameState updates.\r\n\r\nCloses #12 \r\nCloses #108 ","created_at":"2016-10-25T06:37:35Z","updated_at":"2016-10-25T06:55:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae60c232f61a2ccc0e11c5eba37d61a183730957","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/trillek-team/tec/pulls/110/commits","review_comments_url":"https://api.github.com/repos/trillek-team/tec/pulls/110/comments","review_comment_url":"https://api.github.com/repos/trillek-team/tec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/trillek-team/tec/issues/110/comments","statuses_url":"https://api.github.com/repos/trillek-team/tec/statuses/9b7eec3492730cf746a628d5cc025cf31dc37eb2","head":{"label":"adam4813:master","ref":"master","sha":"9b7eec3492730cf746a628d5cc025cf31dc37eb2","user":{"login":"adam4813","id":3011917,"avatar_url":"https://avatars.githubusercontent.com/u/3011917?v=3","gravatar_id":"","url":"https://api.github.com/users/adam4813","html_url":"https://github.com/adam4813","followers_url":"https://api.github.com/users/adam4813/followers","following_url":"https://api.github.com/users/adam4813/following{/other_user}","gists_url":"https://api.github.com/users/adam4813/gists{/gist_id}","starred_url":"https://api.github.com/users/adam4813/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam4813/subscriptions","organizations_url":"https://api.github.com/users/adam4813/orgs","repos_url":"https://api.github.com/users/adam4813/repos","events_url":"https://api.github.com/users/adam4813/events{/privacy}","received_events_url":"https://api.github.com/users/adam4813/received_events","type":"User","site_admin":false},"repo":{"id":37303024,"name":"tec","full_name":"adam4813/tec","owner":{"login":"adam4813","id":3011917,"avatar_url":"https://avatars.githubusercontent.com/u/3011917?v=3","gravatar_id":"","url":"https://api.github.com/users/adam4813","html_url":"https://github.com/adam4813","followers_url":"https://api.github.com/users/adam4813/followers","following_url":"https://api.github.com/users/adam4813/following{/other_user}","gists_url":"https://api.github.com/users/adam4813/gists{/gist_id}","starred_url":"https://api.github.com/users/adam4813/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam4813/subscriptions","organizations_url":"https://api.github.com/users/adam4813/orgs","repos_url":"https://api.github.com/users/adam4813/repos","events_url":"https://api.github.com/users/adam4813/events{/privacy}","received_events_url":"https://api.github.com/users/adam4813/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adam4813/tec","description":null,"fork":true,"url":"https://api.github.com/repos/adam4813/tec","forks_url":"https://api.github.com/repos/adam4813/tec/forks","keys_url":"https://api.github.com/repos/adam4813/tec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adam4813/tec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adam4813/tec/teams","hooks_url":"https://api.github.com/repos/adam4813/tec/hooks","issue_events_url":"https://api.github.com/repos/adam4813/tec/issues/events{/number}","events_url":"https://api.github.com/repos/adam4813/tec/events","assignees_url":"https://api.github.com/repos/adam4813/tec/assignees{/user}","branches_url":"https://api.github.com/repos/adam4813/tec/branches{/branch}","tags_url":"https://api.github.com/repos/adam4813/tec/tags","blobs_url":"https://api.github.com/repos/adam4813/tec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adam4813/tec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adam4813/tec/git/refs{/sha}","trees_url":"https://api.github.com/repos/adam4813/tec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adam4813/tec/statuses/{sha}","languages_url":"https://api.github.com/repos/adam4813/tec/languages","stargazers_url":"https://api.github.com/repos/adam4813/tec/stargazers","contributors_url":"https://api.github.com/repos/adam4813/tec/contributors","subscribers_url":"https://api.github.com/repos/adam4813/tec/subscribers","subscription_url":"https://api.github.com/repos/adam4813/tec/subscription","commits_url":"https://api.github.com/repos/adam4813/tec/commits{/sha}","git_commits_url":"https://api.github.com/repos/adam4813/tec/git/commits{/sha}","comments_url":"https://api.github.com/repos/adam4813/tec/comments{/number}","issue_comment_url":"https://api.github.com/repos/adam4813/tec/issues/comments{/number}","contents_url":"https://api.github.com/repos/adam4813/tec/contents/{+path}","compare_url":"https://api.github.com/repos/adam4813/tec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adam4813/tec/merges","archive_url":"https://api.github.com/repos/adam4813/tec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adam4813/tec/downloads","issues_url":"https://api.github.com/repos/adam4813/tec/issues{/number}","pulls_url":"https://api.github.com/repos/adam4813/tec/pulls{/number}","milestones_url":"https://api.github.com/repos/adam4813/tec/milestones{/number}","notifications_url":"https://api.github.com/repos/adam4813/tec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adam4813/tec/labels{/name}","releases_url":"https://api.github.com/repos/adam4813/tec/releases{/id}","deployments_url":"https://api.github.com/repos/adam4813/tec/deployments","created_at":"2015-06-12T05:04:49Z","updated_at":"2016-04-06T19:18:23Z","pushed_at":"2016-10-25T06:35:54Z","git_url":"git://github.com/adam4813/tec.git","ssh_url":"git@github.com:adam4813/tec.git","clone_url":"https://github.com/adam4813/tec.git","svn_url":"https://github.com/adam4813/tec","homepage":null,"size":1039,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"trillek-team:master","ref":"master","sha":"a3a4833c57a59e20dc97938cced253c47fdbd1d8","user":{"login":"trillek-team","id":5213089,"avatar_url":"https://avatars.githubusercontent.com/u/5213089?v=3","gravatar_id":"","url":"https://api.github.com/users/trillek-team","html_url":"https://github.com/trillek-team","followers_url":"https://api.github.com/users/trillek-team/followers","following_url":"https://api.github.com/users/trillek-team/following{/other_user}","gists_url":"https://api.github.com/users/trillek-team/gists{/gist_id}","starred_url":"https://api.github.com/users/trillek-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trillek-team/subscriptions","organizations_url":"https://api.github.com/users/trillek-team/orgs","repos_url":"https://api.github.com/users/trillek-team/repos","events_url":"https://api.github.com/users/trillek-team/events{/privacy}","received_events_url":"https://api.github.com/users/trillek-team/received_events","type":"Organization","site_admin":false},"repo":{"id":35164637,"name":"tec","full_name":"trillek-team/tec","owner":{"login":"trillek-team","id":5213089,"avatar_url":"https://avatars.githubusercontent.com/u/5213089?v=3","gravatar_id":"","url":"https://api.github.com/users/trillek-team","html_url":"https://github.com/trillek-team","followers_url":"https://api.github.com/users/trillek-team/followers","following_url":"https://api.github.com/users/trillek-team/following{/other_user}","gists_url":"https://api.github.com/users/trillek-team/gists{/gist_id}","starred_url":"https://api.github.com/users/trillek-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trillek-team/subscriptions","organizations_url":"https://api.github.com/users/trillek-team/orgs","repos_url":"https://api.github.com/users/trillek-team/repos","events_url":"https://api.github.com/users/trillek-team/events{/privacy}","received_events_url":"https://api.github.com/users/trillek-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trillek-team/tec","description":"The Trillek Engine","fork":false,"url":"https://api.github.com/repos/trillek-team/tec","forks_url":"https://api.github.com/repos/trillek-team/tec/forks","keys_url":"https://api.github.com/repos/trillek-team/tec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trillek-team/tec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trillek-team/tec/teams","hooks_url":"https://api.github.com/repos/trillek-team/tec/hooks","issue_events_url":"https://api.github.com/repos/trillek-team/tec/issues/events{/number}","events_url":"https://api.github.com/repos/trillek-team/tec/events","assignees_url":"https://api.github.com/repos/trillek-team/tec/assignees{/user}","branches_url":"https://api.github.com/repos/trillek-team/tec/branches{/branch}","tags_url":"https://api.github.com/repos/trillek-team/tec/tags","blobs_url":"https://api.github.com/repos/trillek-team/tec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trillek-team/tec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trillek-team/tec/git/refs{/sha}","trees_url":"https://api.github.com/repos/trillek-team/tec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trillek-team/tec/statuses/{sha}","languages_url":"https://api.github.com/repos/trillek-team/tec/languages","stargazers_url":"https://api.github.com/repos/trillek-team/tec/stargazers","contributors_url":"https://api.github.com/repos/trillek-team/tec/contributors","subscribers_url":"https://api.github.com/repos/trillek-team/tec/subscribers","subscription_url":"https://api.github.com/repos/trillek-team/tec/subscription","commits_url":"https://api.github.com/repos/trillek-team/tec/commits{/sha}","git_commits_url":"https://api.github.com/repos/trillek-team/tec/git/commits{/sha}","comments_url":"https://api.github.com/repos/trillek-team/tec/comments{/number}","issue_comment_url":"https://api.github.com/repos/trillek-team/tec/issues/comments{/number}","contents_url":"https://api.github.com/repos/trillek-team/tec/contents/{+path}","compare_url":"https://api.github.com/repos/trillek-team/tec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trillek-team/tec/merges","archive_url":"https://api.github.com/repos/trillek-team/tec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trillek-team/tec/downloads","issues_url":"https://api.github.com/repos/trillek-team/tec/issues{/number}","pulls_url":"https://api.github.com/repos/trillek-team/tec/pulls{/number}","milestones_url":"https://api.github.com/repos/trillek-team/tec/milestones{/number}","notifications_url":"https://api.github.com/repos/trillek-team/tec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trillek-team/tec/labels{/name}","releases_url":"https://api.github.com/repos/trillek-team/tec/releases{/id}","deployments_url":"https://api.github.com/repos/trillek-team/tec/deployments","created_at":"2015-05-06T14:48:31Z","updated_at":"2016-10-25T00:05:49Z","pushed_at":"2016-10-25T06:37:35Z","git_url":"git://github.com/trillek-team/tec.git","ssh_url":"git@github.com:trillek-team/tec.git","clone_url":"https://github.com/trillek-team/tec.git","svn_url":"https://github.com/trillek-team/tec","homepage":"http://trillek.org","size":1027,"stargazers_count":53,"watchers_count":53,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":27,"forks":13,"open_issues":27,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/trillek-team/tec/pulls/110"},"html":{"href":"https://github.com/trillek-team/tec/pull/110"},"issue":{"href":"https://api.github.com/repos/trillek-team/tec/issues/110"},"comments":{"href":"https://api.github.com/repos/trillek-team/tec/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/trillek-team/tec/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/trillek-team/tec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/trillek-team/tec/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/trillek-team/tec/statuses/9b7eec3492730cf746a628d5cc025cf31dc37eb2"}}}}
{"actor":{"display_login":"milesrout"}}