{"action":"created","issue":{"url":"https://api.github.com/repos/wrye-bash/wrye-bash/issues/329","repository_url":"https://api.github.com/repos/wrye-bash/wrye-bash","labels_url":"https://api.github.com/repos/wrye-bash/wrye-bash/issues/329/labels{/name}","comments_url":"https://api.github.com/repos/wrye-bash/wrye-bash/issues/329/comments","events_url":"https://api.github.com/repos/wrye-bash/wrye-bash/issues/329/events","html_url":"https://github.com/wrye-bash/wrye-bash/pull/329","id":181833234,"number":329,"title":"Update to the LOOT API v0.10","user":{"login":"WrinklyNinja","id":2430738,"avatar_url":"https://avatars.githubusercontent.com/u/2430738?v=3","gravatar_id":"","url":"https://api.github.com/users/WrinklyNinja","html_url":"https://github.com/WrinklyNinja","followers_url":"https://api.github.com/users/WrinklyNinja/followers","following_url":"https://api.github.com/users/WrinklyNinja/following{/other_user}","gists_url":"https://api.github.com/users/WrinklyNinja/gists{/gist_id}","starred_url":"https://api.github.com/users/WrinklyNinja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WrinklyNinja/subscriptions","organizations_url":"https://api.github.com/users/WrinklyNinja/orgs","repos_url":"https://api.github.com/users/WrinklyNinja/repos","events_url":"https://api.github.com/users/WrinklyNinja/events{/privacy}","received_events_url":"https://api.github.com/users/WrinklyNinja/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2016-10-08T15:53:02Z","updated_at":"2016-10-17T07:20:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wrye-bash/wrye-bash/pulls/329","html_url":"https://github.com/wrye-bash/wrye-bash/pull/329","diff_url":"https://github.com/wrye-bash/wrye-bash/pull/329.diff","patch_url":"https://github.com/wrye-bash/wrye-bash/pull/329.patch"},"body":"**NOT YET READY FOR MERGE**\r\n\r\nv0.10 of the LOOT API completely breaks backwards compatibility and introduces a new autogenerated Python wrapper that has much less performance overhead than the existing ctypes-based, handmade v0.6 wrapper that currently exists in Bash's repository.\r\n\r\nThis commit:\r\n\r\n- [x] replaces the existing v0.6 DLL and python wrapper with the v0.10 equivalents\r\n- [x] updates the Bash code that uses the LOOT API to work with the new wrapper\r\n- [x] updates the taglists, generating them from the latest v0.10 masterlists\r\n- [x] updates `mods_metadata.py` to not crash if the LOOT API cannot be imported\r\n- [ ] adds an install script that downloads and installs the LOOT API and the MSVC 2015 redistributable dependency\r\n- [ ] updates the readme to mention the new MSVC 2015 redistributable dependency\r\n- [ ] updates the NSIS installer to run a new LOOT API install script\r\n\r\nAside from any unchecked boxes in the list above, this PR isn't ready for merge because it's using a pre-release build of the v0.10 API, and I'd rather this was merged after I've replaced the current build with the v0.10 release build. The v0.10 release is partly dependent on seeing if the API works in practice.\r\n\r\nI'm also interested in knowing what the performance improvement is like for others."},"comment":{"url":"https://api.github.com/repos/wrye-bash/wrye-bash/issues/comments/254130915","html_url":"https://github.com/wrye-bash/wrye-bash/pull/329#issuecomment-254130915","issue_url":"https://api.github.com/repos/wrye-bash/wrye-bash/issues/329","id":254130915,"user":{"login":"WrinklyNinja","id":2430738,"avatar_url":"https://avatars.githubusercontent.com/u/2430738?v=3","gravatar_id":"","url":"https://api.github.com/users/WrinklyNinja","html_url":"https://github.com/WrinklyNinja","followers_url":"https://api.github.com/users/WrinklyNinja/followers","following_url":"https://api.github.com/users/WrinklyNinja/following{/other_user}","gists_url":"https://api.github.com/users/WrinklyNinja/gists{/gist_id}","starred_url":"https://api.github.com/users/WrinklyNinja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WrinklyNinja/subscriptions","organizations_url":"https://api.github.com/users/WrinklyNinja/orgs","repos_url":"https://api.github.com/users/WrinklyNinja/repos","events_url":"https://api.github.com/users/WrinklyNinja/events{/privacy}","received_events_url":"https://api.github.com/users/WrinklyNinja/received_events","type":"User","site_admin":false},"created_at":"2016-10-17T07:20:37Z","updated_at":"2016-10-17T07:20:37Z","body":"I've just rebased on top of the latest wrye-bash `dev` branch and have added the install script and removed the LOOT API binary. The script currently doesn't handle the MSVC redist, I'll add that later."}}
{"actor":{"display_login":"WrinklyNinja"}}