{"action":"created","comment":{"url":"https://api.github.com/repos/lsst/jointcal/pulls/comments/72873745","id":72873745,"diff_hunk":"@@ -0,0 +1,72 @@\n+# See COPYRIGHT file at the top of the source tree.\n+\n+from __future__ import division, absolute_import, print_function\n+\n+import unittest\n+import os\n+\n+from astropy import units as u\n+\n+import lsst.afw.geom\n+import lsst.afw.coord as afwCoord\n+import lsst.utils\n+import lsst.pex.exceptions\n+\n+import jointcalTestBase\n+\n+try:\n+    data_dir = lsst.utils.getPackageDir('validation_data_hsc')\n+    os.environ['ASTROMETRY_NET_DATA_DIR'] = os.path.join(data_dir, 'sdss-dr9-fink-v5b')\n+except lsst.pex.exceptions.NotFoundError:\n+    data_dir = None\n+\n+# We don't want the absolute astrometry to become significantly worse\n+# than the single-epoch astrometry (about 0.040\").\n+# This value was empirically determined from the first run of jointcal on\n+# this data, and will likely vary from survey to survey.\n+absolute_error = 52e-3*u.arcsecond\n+# Set to True for a comparison plot and some diagnostic numbers.\n+do_plot = False\n+\n+\n+# for MemoryTestCase\n+def setup_module(module):\n+    lsst.utils.tests.init()\n+\n+\n+class JointcalTestHSC(jointcalTestBase.JointcalTestBase, lsst.utils.tests.TestCase):\n+    def setUp(self):\n+        jointcalTestBase.JointcalTestBase.setUp(self)\n+        self.do_plot = do_plot\n+        self.match_radius = 0.1*lsst.afw.geom.arcseconds\n+\n+        # position of this validation_data_hsc catalog\n+        center = afwCoord.IcrsCoord(320.367492*lsst.afw.geom.degrees, 0.3131554*lsst.afw.geom.degrees)\n+        radius = 5*lsst.afw.geom.degrees\n+        self._prep_reference_loader(center, radius)\n+\n+        self.input_dir = os.path.join(data_dir, 'DATA')\n+        self.all_visits = [903334, 903336, 903338, 903342, 903344, 903346]\n+\n+    @unittest.skipIf(data_dir is None, \"validation_data_jointcal not setup\")\n+    def test_jointcalTask_2_visits(self):\n+        # NOTE: The relative RMS limit was empirically determined from the\n+        # first run of jointcal on this data. We should always do better than\n+        # this in the future!\n+        self._testJointCalTask(2, 17e-3*u.arcsecond, absolute_error)\n+\n+    @unittest.skipIf(data_dir is None, \"validation_data_jointcal not setup\")\n+    def test_jointcalTask_6_visits(self):\n+        # NOTE: The relative RMS limit was empirically determined from the\n+        # first run of jointcal on this data. We should always do better than\n+        # this in the future!\n+        self._testJointCalTask(6, 10e-3*u.arcsecond, absolute_error)\n+\n+\n+# TODO: the memory test cases currently fail in jointcal. I'll have to clean that up later.","path":"tests/testJointcal_hsc.py","position":66,"original_position":66,"commit_id":"462aba3579c3622bf89f58d40d6b1dd1b3244f68","original_commit_id":"462aba3579c3622bf89f58d40d6b1dd1b3244f68","user":{"login":"parejkoj","id":1606089,"avatar_url":"https://avatars.githubusercontent.com/u/1606089?v=3","gravatar_id":"","url":"https://api.github.com/users/parejkoj","html_url":"https://github.com/parejkoj","followers_url":"https://api.github.com/users/parejkoj/followers","following_url":"https://api.github.com/users/parejkoj/following{/other_user}","gists_url":"https://api.github.com/users/parejkoj/gists{/gist_id}","starred_url":"https://api.github.com/users/parejkoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parejkoj/subscriptions","organizations_url":"https://api.github.com/users/parejkoj/orgs","repos_url":"https://api.github.com/users/parejkoj/repos","events_url":"https://api.github.com/users/parejkoj/events{/privacy}","received_events_url":"https://api.github.com/users/parejkoj/received_events","type":"User","site_admin":false},"body":"Ticket was already filed. I've tweaked the TODO to reference that.","created_at":"2016-07-29T23:18:51Z","updated_at":"2016-07-29T23:18:51Z","html_url":"https://github.com/lsst/jointcal/pull/15#discussion_r72873745","pull_request_url":"https://api.github.com/repos/lsst/jointcal/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/lsst/jointcal/pulls/comments/72873745"},"html":{"href":"https://github.com/lsst/jointcal/pull/15#discussion_r72873745"},"pull_request":{"href":"https://api.github.com/repos/lsst/jointcal/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/lsst/jointcal/pulls/15","id":79430444,"html_url":"https://github.com/lsst/jointcal/pull/15","diff_url":"https://github.com/lsst/jointcal/pull/15.diff","patch_url":"https://github.com/lsst/jointcal/pull/15.patch","issue_url":"https://api.github.com/repos/lsst/jointcal/issues/15","number":15,"state":"open","locked":false,"title":"Tickets/dm 6622","user":{"login":"parejkoj","id":1606089,"avatar_url":"https://avatars.githubusercontent.com/u/1606089?v=3","gravatar_id":"","url":"https://api.github.com/users/parejkoj","html_url":"https://github.com/parejkoj","followers_url":"https://api.github.com/users/parejkoj/followers","following_url":"https://api.github.com/users/parejkoj/following{/other_user}","gists_url":"https://api.github.com/users/parejkoj/gists{/gist_id}","starred_url":"https://api.github.com/users/parejkoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parejkoj/subscriptions","organizations_url":"https://api.github.com/users/parejkoj/orgs","repos_url":"https://api.github.com/users/parejkoj/repos","events_url":"https://api.github.com/users/parejkoj/events{/privacy}","received_events_url":"https://api.github.com/users/parejkoj/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-29T21:56:16Z","updated_at":"2016-07-29T23:18:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c89ff47a978b95349ae06a19570700946b3c4d9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lsst/jointcal/pulls/15/commits","review_comments_url":"https://api.github.com/repos/lsst/jointcal/pulls/15/comments","review_comment_url":"https://api.github.com/repos/lsst/jointcal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst/jointcal/issues/15/comments","statuses_url":"https://api.github.com/repos/lsst/jointcal/statuses/462aba3579c3622bf89f58d40d6b1dd1b3244f68","head":{"label":"lsst:tickets/DM-6622","ref":"tickets/DM-6622","sha":"462aba3579c3622bf89f58d40d6b1dd1b3244f68","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":52640673,"name":"jointcal","full_name":"lsst/jointcal","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/jointcal","description":"Simultaneous astrometry ","fork":true,"url":"https://api.github.com/repos/lsst/jointcal","forks_url":"https://api.github.com/repos/lsst/jointcal/forks","keys_url":"https://api.github.com/repos/lsst/jointcal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/jointcal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/jointcal/teams","hooks_url":"https://api.github.com/repos/lsst/jointcal/hooks","issue_events_url":"https://api.github.com/repos/lsst/jointcal/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/jointcal/events","assignees_url":"https://api.github.com/repos/lsst/jointcal/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/jointcal/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/jointcal/tags","blobs_url":"https://api.github.com/repos/lsst/jointcal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/jointcal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/jointcal/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/jointcal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/jointcal/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/jointcal/languages","stargazers_url":"https://api.github.com/repos/lsst/jointcal/stargazers","contributors_url":"https://api.github.com/repos/lsst/jointcal/contributors","subscribers_url":"https://api.github.com/repos/lsst/jointcal/subscribers","subscription_url":"https://api.github.com/repos/lsst/jointcal/subscription","commits_url":"https://api.github.com/repos/lsst/jointcal/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/jointcal/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/jointcal/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/jointcal/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/jointcal/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/jointcal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/jointcal/merges","archive_url":"https://api.github.com/repos/lsst/jointcal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/jointcal/downloads","issues_url":"https://api.github.com/repos/lsst/jointcal/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/jointcal/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/jointcal/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/jointcal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/jointcal/labels{/name}","releases_url":"https://api.github.com/repos/lsst/jointcal/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/jointcal/deployments","created_at":"2016-02-26T23:56:59Z","updated_at":"2016-02-26T23:59:02Z","pushed_at":"2016-07-29T21:56:16Z","git_url":"git://github.com/lsst/jointcal.git","ssh_url":"git@github.com:lsst/jointcal.git","clone_url":"https://github.com/lsst/jointcal.git","svn_url":"https://github.com/lsst/jointcal","homepage":null,"size":1749,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"lsst:master","ref":"master","sha":"1db18aaf444616e6b611f8b9b3b237818827aa73","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":52640673,"name":"jointcal","full_name":"lsst/jointcal","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/jointcal","description":"Simultaneous astrometry ","fork":true,"url":"https://api.github.com/repos/lsst/jointcal","forks_url":"https://api.github.com/repos/lsst/jointcal/forks","keys_url":"https://api.github.com/repos/lsst/jointcal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/jointcal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/jointcal/teams","hooks_url":"https://api.github.com/repos/lsst/jointcal/hooks","issue_events_url":"https://api.github.com/repos/lsst/jointcal/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/jointcal/events","assignees_url":"https://api.github.com/repos/lsst/jointcal/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/jointcal/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/jointcal/tags","blobs_url":"https://api.github.com/repos/lsst/jointcal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/jointcal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/jointcal/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/jointcal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/jointcal/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/jointcal/languages","stargazers_url":"https://api.github.com/repos/lsst/jointcal/stargazers","contributors_url":"https://api.github.com/repos/lsst/jointcal/contributors","subscribers_url":"https://api.github.com/repos/lsst/jointcal/subscribers","subscription_url":"https://api.github.com/repos/lsst/jointcal/subscription","commits_url":"https://api.github.com/repos/lsst/jointcal/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/jointcal/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/jointcal/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/jointcal/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/jointcal/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/jointcal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/jointcal/merges","archive_url":"https://api.github.com/repos/lsst/jointcal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/jointcal/downloads","issues_url":"https://api.github.com/repos/lsst/jointcal/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/jointcal/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/jointcal/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/jointcal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/jointcal/labels{/name}","releases_url":"https://api.github.com/repos/lsst/jointcal/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/jointcal/deployments","created_at":"2016-02-26T23:56:59Z","updated_at":"2016-02-26T23:59:02Z","pushed_at":"2016-07-29T21:56:16Z","git_url":"git://github.com/lsst/jointcal.git","ssh_url":"git@github.com:lsst/jointcal.git","clone_url":"https://github.com/lsst/jointcal.git","svn_url":"https://github.com/lsst/jointcal","homepage":null,"size":1749,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst/jointcal/pulls/15"},"html":{"href":"https://github.com/lsst/jointcal/pull/15"},"issue":{"href":"https://api.github.com/repos/lsst/jointcal/issues/15"},"comments":{"href":"https://api.github.com/repos/lsst/jointcal/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst/jointcal/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst/jointcal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst/jointcal/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/lsst/jointcal/statuses/462aba3579c3622bf89f58d40d6b1dd1b3244f68"}}}}
{"actor":{"display_login":"parejkoj"}}