{"action":"created","issue":{"url":"https://api.github.com/repos/graphhopper/graphhopper/issues/719","repository_url":"https://api.github.com/repos/graphhopper/graphhopper","labels_url":"https://api.github.com/repos/graphhopper/graphhopper/issues/719/labels{/name}","comments_url":"https://api.github.com/repos/graphhopper/graphhopper/issues/719/comments","events_url":"https://api.github.com/repos/graphhopper/graphhopper/issues/719/events","html_url":"https://github.com/graphhopper/graphhopper/pull/719","id":154737631,"number":719,"title":"introduces under_score notation for all properties, fixes #682","user":{"login":"karussell","id":129644,"avatar_url":"https://avatars.githubusercontent.com/u/129644?v=3","gravatar_id":"","url":"https://api.github.com/users/karussell","html_url":"https://github.com/karussell","followers_url":"https://api.github.com/users/karussell/followers","following_url":"https://api.github.com/users/karussell/following{/other_user}","gists_url":"https://api.github.com/users/karussell/gists{/gist_id}","starred_url":"https://api.github.com/users/karussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karussell/subscriptions","organizations_url":"https://api.github.com/users/karussell/orgs","repos_url":"https://api.github.com/users/karussell/repos","events_url":"https://api.github.com/users/karussell/events{/privacy}","received_events_url":"https://api.github.com/users/karussell/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/graphhopper/graphhopper/labels/improvement","name":"improvement","color":"d7e102"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/graphhopper/graphhopper/milestones/8","html_url":"https://github.com/graphhopper/graphhopper/milestones/0.7","labels_url":"https://api.github.com/repos/graphhopper/graphhopper/milestones/8/labels","id":1542551,"number":8,"title":"0.7","description":"","creator":{"login":"karussell","id":129644,"avatar_url":"https://avatars.githubusercontent.com/u/129644?v=3","gravatar_id":"","url":"https://api.github.com/users/karussell","html_url":"https://github.com/karussell","followers_url":"https://api.github.com/users/karussell/followers","following_url":"https://api.github.com/users/karussell/following{/other_user}","gists_url":"https://api.github.com/users/karussell/gists{/gist_id}","starred_url":"https://api.github.com/users/karussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karussell/subscriptions","organizations_url":"https://api.github.com/users/karussell/orgs","repos_url":"https://api.github.com/users/karussell/repos","events_url":"https://api.github.com/users/karussell/events{/privacy}","received_events_url":"https://api.github.com/users/karussell/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":31,"state":"open","created_at":"2016-01-25T19:54:56Z","updated_at":"2016-05-14T12:19:44Z","due_on":null,"closed_at":null},"comments":13,"created_at":"2016-05-13T15:23:19Z","updated_at":"2016-05-14T14:04:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/graphhopper/graphhopper/pulls/719","html_url":"https://github.com/graphhopper/graphhopper/pull/719","diff_url":"https://github.com/graphhopper/graphhopper/pull/719.diff","patch_url":"https://github.com/graphhopper/graphhopper/pull/719.patch"},"body":"This change fixes #682 and requires a re-import as not only the storable properties are changed but also the EncodingManager properties like turnCosts -> turn_costs\r\n\r\nDone:\r\n\r\n * under_score is now default for get and put\r\n * keep 'routing.' prefix for defaults specified in config.properties, on query the 'routing.' is not allowed possible\r\n\r\nSome backward breaking changes (no fallback for now):\r\n\r\n * The biggest change is that we do no longer handle upper case as before e.g. stuff like this will fail now `assertEquals(\"valueA\", subject.get(\"FOO\", \"\"));`. The reason is that camelCase still works and is automatically converted to under_score\r\n * graph.elevation.calcmean -> graph.elevation.calc_mean\r\n * graph.elevation.cache_dir -> graph.elevation.cache_dir\r\n * graph.elevation.baseurl -> graph.elevation.base_url\r\n * osmreader.preferred-language -> osmreader.preferred_language\r\n * prepare.contracted-nodes -> prepare.contracted_nodes\r\n * prepare.logmessages -> prepare.log_messages\r\n * osmreader.way_point_max_distance -> routing.way_point_max_distance\r\n\r\nTODOs:\r\n \r\n - [ ] pass correct properties to measurement -> graphhopper.sh script (measurement.git_info, graph.import_time, graph.size_in_MB, location_index, etc) and config-example.properties\r\n - [ ] update measurement JS\r\n - [ ] update I18N keys and access to those key in the JS UI\r\n - [ ] change constants versions\r\n - [x] `routing.roundTrip.maxRetries`\r\n"},"comment":{"url":"https://api.github.com/repos/graphhopper/graphhopper/issues/comments/219222077","html_url":"https://github.com/graphhopper/graphhopper/pull/719#issuecomment-219222077","issue_url":"https://api.github.com/repos/graphhopper/graphhopper/issues/719","id":219222077,"user":{"login":"devemux86","id":3484020,"avatar_url":"https://avatars.githubusercontent.com/u/3484020?v=3","gravatar_id":"","url":"https://api.github.com/users/devemux86","html_url":"https://github.com/devemux86","followers_url":"https://api.github.com/users/devemux86/followers","following_url":"https://api.github.com/users/devemux86/following{/other_user}","gists_url":"https://api.github.com/users/devemux86/gists{/gist_id}","starred_url":"https://api.github.com/users/devemux86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devemux86/subscriptions","organizations_url":"https://api.github.com/users/devemux86/orgs","repos_url":"https://api.github.com/users/devemux86/repos","events_url":"https://api.github.com/users/devemux86/events{/privacy}","received_events_url":"https://api.github.com/users/devemux86/received_events","type":"User","site_admin":false},"created_at":"2016-05-14T14:04:23Z","updated_at":"2016-05-14T14:04:23Z","body":"Probably a separate issue about hosting all fixed strings regardless category in such class(es) would be best and keep this for the notation?"}}