{"action":"created","comment":{"url":"https://api.github.com/repos/scality/S3/pulls/comments/79848006","id":79848006,"diff_hunk":"@@ -63,7 +74,7 @@ export default function objectPutPart(authInfo, request, log, cb) {\n     if (partNumber > 10000) {\n         return cb(errors.TooManyParts);\n     }\n-    if (!Number.isInteger(partNumber)) {\n+    if (!Number.isInteger(partNumber) || partNumber < 1) {","path":"lib/api/objectPutPart.js","position":32,"original_position":32,"commit_id":"56f24b9ebdc3b700cf53b3c278d25a2e0aebbbeb","original_commit_id":"56f24b9ebdc3b700cf53b3c278d25a2e0aebbbeb","user":{"login":"alexandre-merle","id":18259837,"avatar_url":"https://avatars.githubusercontent.com/u/18259837?v=3","gravatar_id":"","url":"https://api.github.com/users/alexandre-merle","html_url":"https://github.com/alexandre-merle","followers_url":"https://api.github.com/users/alexandre-merle/followers","following_url":"https://api.github.com/users/alexandre-merle/following{/other_user}","gists_url":"https://api.github.com/users/alexandre-merle/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandre-merle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandre-merle/subscriptions","organizations_url":"https://api.github.com/users/alexandre-merle/orgs","repos_url":"https://api.github.com/users/alexandre-merle/repos","events_url":"https://api.github.com/users/alexandre-merle/events{/privacy}","received_events_url":"https://api.github.com/users/alexandre-merle/received_events","type":"User","site_admin":false},"body":"Its a silent fix here, and this should go against rel/1.1 actually","created_at":"2016-09-21T14:34:38Z","updated_at":"2016-09-21T14:48:07Z","html_url":"https://github.com/scality/S3/pull/174#discussion_r79848006","pull_request_url":"https://api.github.com/repos/scality/S3/pulls/174","_links":{"self":{"href":"https://api.github.com/repos/scality/S3/pulls/comments/79848006"},"html":{"href":"https://github.com/scality/S3/pull/174#discussion_r79848006"},"pull_request":{"href":"https://api.github.com/repos/scality/S3/pulls/174"}}},"pull_request":{"url":"https://api.github.com/repos/scality/S3/pulls/174","id":82973686,"html_url":"https://github.com/scality/S3/pull/174","diff_url":"https://github.com/scality/S3/pull/174.diff","patch_url":"https://github.com/scality/S3/pull/174.patch","issue_url":"https://api.github.com/repos/scality/S3/issues/174","number":174,"state":"open","locked":false,"title":"Ft/copy part","user":{"login":"LaurenSpiegel","id":7368115,"avatar_url":"https://avatars.githubusercontent.com/u/7368115?v=3","gravatar_id":"","url":"https://api.github.com/users/LaurenSpiegel","html_url":"https://github.com/LaurenSpiegel","followers_url":"https://api.github.com/users/LaurenSpiegel/followers","following_url":"https://api.github.com/users/LaurenSpiegel/following{/other_user}","gists_url":"https://api.github.com/users/LaurenSpiegel/gists{/gist_id}","starred_url":"https://api.github.com/users/LaurenSpiegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaurenSpiegel/subscriptions","organizations_url":"https://api.github.com/users/LaurenSpiegel/orgs","repos_url":"https://api.github.com/users/LaurenSpiegel/repos","events_url":"https://api.github.com/users/LaurenSpiegel/events{/privacy}","received_events_url":"https://api.github.com/users/LaurenSpiegel/received_events","type":"User","site_admin":false},"body":"Implements upload part copy feature.\r\n\r\nNote: THIS CONTAINS A SMALL BREAKING CHANGE.\r\nThis modifies the format in which a put part stores data.\r\nAs a consequence, the way that an MPU is completed is altered.\r\nThis means that an MPU that was initiated prior to May 2nd,\r\nwill not be able to be completed.\r\n","created_at":"2016-08-27T01:33:12Z","updated_at":"2016-09-21T14:48:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec64577b5f943fc50f00c5c750fbcab9defc1b6b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scality/S3/pulls/174/commits","review_comments_url":"https://api.github.com/repos/scality/S3/pulls/174/comments","review_comment_url":"https://api.github.com/repos/scality/S3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scality/S3/issues/174/comments","statuses_url":"https://api.github.com/repos/scality/S3/statuses/56f24b9ebdc3b700cf53b3c278d25a2e0aebbbeb","head":{"label":"scality:ft/copyPart","ref":"ft/copyPart","sha":"56f24b9ebdc3b700cf53b3c278d25a2e0aebbbeb","user":{"login":"scality","id":383812,"avatar_url":"https://avatars.githubusercontent.com/u/383812?v=3","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"repo":{"id":60165924,"name":"S3","full_name":"scality/S3","owner":{"login":"scality","id":383812,"avatar_url":"https://avatars.githubusercontent.com/u/383812?v=3","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scality/S3","description":"An open-source Node.js implementation of a server handling the S3 protocol","fork":false,"url":"https://api.github.com/repos/scality/S3","forks_url":"https://api.github.com/repos/scality/S3/forks","keys_url":"https://api.github.com/repos/scality/S3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scality/S3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scality/S3/teams","hooks_url":"https://api.github.com/repos/scality/S3/hooks","issue_events_url":"https://api.github.com/repos/scality/S3/issues/events{/number}","events_url":"https://api.github.com/repos/scality/S3/events","assignees_url":"https://api.github.com/repos/scality/S3/assignees{/user}","branches_url":"https://api.github.com/repos/scality/S3/branches{/branch}","tags_url":"https://api.github.com/repos/scality/S3/tags","blobs_url":"https://api.github.com/repos/scality/S3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scality/S3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scality/S3/git/refs{/sha}","trees_url":"https://api.github.com/repos/scality/S3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scality/S3/statuses/{sha}","languages_url":"https://api.github.com/repos/scality/S3/languages","stargazers_url":"https://api.github.com/repos/scality/S3/stargazers","contributors_url":"https://api.github.com/repos/scality/S3/contributors","subscribers_url":"https://api.github.com/repos/scality/S3/subscribers","subscription_url":"https://api.github.com/repos/scality/S3/subscription","commits_url":"https://api.github.com/repos/scality/S3/commits{/sha}","git_commits_url":"https://api.github.com/repos/scality/S3/git/commits{/sha}","comments_url":"https://api.github.com/repos/scality/S3/comments{/number}","issue_comment_url":"https://api.github.com/repos/scality/S3/issues/comments{/number}","contents_url":"https://api.github.com/repos/scality/S3/contents/{+path}","compare_url":"https://api.github.com/repos/scality/S3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scality/S3/merges","archive_url":"https://api.github.com/repos/scality/S3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scality/S3/downloads","issues_url":"https://api.github.com/repos/scality/S3/issues{/number}","pulls_url":"https://api.github.com/repos/scality/S3/pulls{/number}","milestones_url":"https://api.github.com/repos/scality/S3/milestones{/number}","notifications_url":"https://api.github.com/repos/scality/S3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scality/S3/labels{/name}","releases_url":"https://api.github.com/repos/scality/S3/releases{/id}","deployments_url":"https://api.github.com/repos/scality/S3/deployments","created_at":"2016-06-01T09:58:56Z","updated_at":"2016-09-21T14:18:03Z","pushed_at":"2016-09-21T14:32:55Z","git_url":"git://github.com/scality/S3.git","ssh_url":"git@github.com:scality/S3.git","clone_url":"https://github.com/scality/S3.git","svn_url":"https://github.com/scality/S3","homepage":"http://s3.scality.com","size":3403,"stargazers_count":205,"watchers_count":205,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":25,"forks":17,"open_issues":25,"watchers":205,"default_branch":"master"}},"base":{"label":"scality:master","ref":"master","sha":"d3ba43b87ce07a640ade2413f5f915e178a73dff","user":{"login":"scality","id":383812,"avatar_url":"https://avatars.githubusercontent.com/u/383812?v=3","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"repo":{"id":60165924,"name":"S3","full_name":"scality/S3","owner":{"login":"scality","id":383812,"avatar_url":"https://avatars.githubusercontent.com/u/383812?v=3","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scality/S3","description":"An open-source Node.js implementation of a server handling the S3 protocol","fork":false,"url":"https://api.github.com/repos/scality/S3","forks_url":"https://api.github.com/repos/scality/S3/forks","keys_url":"https://api.github.com/repos/scality/S3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scality/S3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scality/S3/teams","hooks_url":"https://api.github.com/repos/scality/S3/hooks","issue_events_url":"https://api.github.com/repos/scality/S3/issues/events{/number}","events_url":"https://api.github.com/repos/scality/S3/events","assignees_url":"https://api.github.com/repos/scality/S3/assignees{/user}","branches_url":"https://api.github.com/repos/scality/S3/branches{/branch}","tags_url":"https://api.github.com/repos/scality/S3/tags","blobs_url":"https://api.github.com/repos/scality/S3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scality/S3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scality/S3/git/refs{/sha}","trees_url":"https://api.github.com/repos/scality/S3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scality/S3/statuses/{sha}","languages_url":"https://api.github.com/repos/scality/S3/languages","stargazers_url":"https://api.github.com/repos/scality/S3/stargazers","contributors_url":"https://api.github.com/repos/scality/S3/contributors","subscribers_url":"https://api.github.com/repos/scality/S3/subscribers","subscription_url":"https://api.github.com/repos/scality/S3/subscription","commits_url":"https://api.github.com/repos/scality/S3/commits{/sha}","git_commits_url":"https://api.github.com/repos/scality/S3/git/commits{/sha}","comments_url":"https://api.github.com/repos/scality/S3/comments{/number}","issue_comment_url":"https://api.github.com/repos/scality/S3/issues/comments{/number}","contents_url":"https://api.github.com/repos/scality/S3/contents/{+path}","compare_url":"https://api.github.com/repos/scality/S3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scality/S3/merges","archive_url":"https://api.github.com/repos/scality/S3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scality/S3/downloads","issues_url":"https://api.github.com/repos/scality/S3/issues{/number}","pulls_url":"https://api.github.com/repos/scality/S3/pulls{/number}","milestones_url":"https://api.github.com/repos/scality/S3/milestones{/number}","notifications_url":"https://api.github.com/repos/scality/S3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scality/S3/labels{/name}","releases_url":"https://api.github.com/repos/scality/S3/releases{/id}","deployments_url":"https://api.github.com/repos/scality/S3/deployments","created_at":"2016-06-01T09:58:56Z","updated_at":"2016-09-21T14:18:03Z","pushed_at":"2016-09-21T14:32:55Z","git_url":"git://github.com/scality/S3.git","ssh_url":"git@github.com:scality/S3.git","clone_url":"https://github.com/scality/S3.git","svn_url":"https://github.com/scality/S3","homepage":"http://s3.scality.com","size":3403,"stargazers_count":205,"watchers_count":205,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":25,"forks":17,"open_issues":25,"watchers":205,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scality/S3/pulls/174"},"html":{"href":"https://github.com/scality/S3/pull/174"},"issue":{"href":"https://api.github.com/repos/scality/S3/issues/174"},"comments":{"href":"https://api.github.com/repos/scality/S3/issues/174/comments"},"review_comments":{"href":"https://api.github.com/repos/scality/S3/pulls/174/comments"},"review_comment":{"href":"https://api.github.com/repos/scality/S3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scality/S3/pulls/174/commits"},"statuses":{"href":"https://api.github.com/repos/scality/S3/statuses/56f24b9ebdc3b700cf53b3c278d25a2e0aebbbeb"}}}}
{"actor":{"display_login":"alexandre-merle"}}