{"action":"created","comment":{"url":"https://api.github.com/repos/pysmt/pysmt/pulls/comments/60537875","id":60537875,"diff_hunk":"@@ -610,7 +610,7 @@ def test_pickling(self):\n \n         self.assertEqual(str(f), \"(A & (! B))\", str(f))\n \n-        serialized = pickle.dumps(f)\n+        serialized = pickle.dumps(f, -1)","path":"pysmt/test/test_formula.py","position":5,"original_position":5,"commit_id":"07bb800a70732901682eb8d1a7bf3577d26bf765","original_commit_id":"07bb800a70732901682eb8d1a7bf3577d26bf765","user":{"login":"mikand","id":2255972,"avatar_url":"https://avatars.githubusercontent.com/u/2255972?v=3","gravatar_id":"","url":"https://api.github.com/users/mikand","html_url":"https://github.com/mikand","followers_url":"https://api.github.com/users/mikand/followers","following_url":"https://api.github.com/users/mikand/following{/other_user}","gists_url":"https://api.github.com/users/mikand/gists{/gist_id}","starred_url":"https://api.github.com/users/mikand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikand/subscriptions","organizations_url":"https://api.github.com/users/mikand/orgs","repos_url":"https://api.github.com/users/mikand/repos","events_url":"https://api.github.com/users/mikand/events{/privacy}","received_events_url":"https://api.github.com/users/mikand/received_events","type":"User","site_admin":false},"body":"```-1``` here is confusing, you should use HIGHEST_PROTOCOL (https://docs.python.org/2/library/pickle.html#pickle.dumps)\r\n\r\nBut anyway, why is this needed?","created_at":"2016-04-21T07:42:49Z","updated_at":"2016-04-21T07:42:49Z","html_url":"https://github.com/pysmt/pysmt/pull/247#discussion_r60537875","pull_request_url":"https://api.github.com/repos/pysmt/pysmt/pulls/247","_links":{"self":{"href":"https://api.github.com/repos/pysmt/pysmt/pulls/comments/60537875"},"html":{"href":"https://github.com/pysmt/pysmt/pull/247#discussion_r60537875"},"pull_request":{"href":"https://api.github.com/repos/pysmt/pysmt/pulls/247"}}},"pull_request":{"url":"https://api.github.com/repos/pysmt/pysmt/pulls/247","id":67252820,"html_url":"https://github.com/pysmt/pysmt/pull/247","diff_url":"https://github.com/pysmt/pysmt/pull/247.diff","patch_url":"https://github.com/pysmt/pysmt/pull/247.patch","issue_url":"https://api.github.com/repos/pysmt/pysmt/issues/247","number":247,"state":"open","locked":false,"title":"Basic performance optimizations","user":{"login":"marcogario","id":1058447,"avatar_url":"https://avatars.githubusercontent.com/u/1058447?v=3","gravatar_id":"","url":"https://api.github.com/users/marcogario","html_url":"https://github.com/marcogario","followers_url":"https://api.github.com/users/marcogario/followers","following_url":"https://api.github.com/users/marcogario/following{/other_user}","gists_url":"https://api.github.com/users/marcogario/gists{/gist_id}","starred_url":"https://api.github.com/users/marcogario/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcogario/subscriptions","organizations_url":"https://api.github.com/users/marcogario/orgs","repos_url":"https://api.github.com/users/marcogario/repos","events_url":"https://api.github.com/users/marcogario/events{/privacy}","received_events_url":"https://api.github.com/users/marcogario/received_events","type":"User","site_admin":false},"body":"1. Avoid use of len() to test emptiness of a dictionary\r\n   (DagWalker._get_key) and a list (DagWalker._process_stack)\r\n   This leads to 75% less calls to len() and a 10% runtime improvement.\r\n\r\n2. Use __slots__ for FNode. This leads to 30% memory reduction.","created_at":"2016-04-20T20:28:00Z","updated_at":"2016-04-21T07:42:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2af64996563cd1010263f45a4c8d16ca0fcbe169","assignee":{"login":"mikand","id":2255972,"avatar_url":"https://avatars.githubusercontent.com/u/2255972?v=3","gravatar_id":"","url":"https://api.github.com/users/mikand","html_url":"https://github.com/mikand","followers_url":"https://api.github.com/users/mikand/followers","following_url":"https://api.github.com/users/mikand/following{/other_user}","gists_url":"https://api.github.com/users/mikand/gists{/gist_id}","starred_url":"https://api.github.com/users/mikand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikand/subscriptions","organizations_url":"https://api.github.com/users/mikand/orgs","repos_url":"https://api.github.com/users/mikand/repos","events_url":"https://api.github.com/users/mikand/events{/privacy}","received_events_url":"https://api.github.com/users/mikand/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/pysmt/pysmt/milestones/9","html_url":"https://github.com/pysmt/pysmt/milestones/0.4.4","labels_url":"https://api.github.com/repos/pysmt/pysmt/milestones/9/labels","id":1347810,"number":9,"title":"0.4.4","description":"","creator":{"login":"marcogario","id":1058447,"avatar_url":"https://avatars.githubusercontent.com/u/1058447?v=3","gravatar_id":"","url":"https://api.github.com/users/marcogario","html_url":"https://github.com/marcogario","followers_url":"https://api.github.com/users/marcogario/followers","following_url":"https://api.github.com/users/marcogario/following{/other_user}","gists_url":"https://api.github.com/users/marcogario/gists{/gist_id}","starred_url":"https://api.github.com/users/marcogario/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcogario/subscriptions","organizations_url":"https://api.github.com/users/marcogario/orgs","repos_url":"https://api.github.com/users/marcogario/repos","events_url":"https://api.github.com/users/marcogario/events{/privacy}","received_events_url":"https://api.github.com/users/marcogario/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":7,"state":"open","created_at":"2015-10-09T19:39:09Z","updated_at":"2016-04-20T20:30:14Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/pysmt/pysmt/pulls/247/commits","review_comments_url":"https://api.github.com/repos/pysmt/pysmt/pulls/247/comments","review_comment_url":"https://api.github.com/repos/pysmt/pysmt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pysmt/pysmt/issues/247/comments","statuses_url":"https://api.github.com/repos/pysmt/pysmt/statuses/07bb800a70732901682eb8d1a7bf3577d26bf765","head":{"label":"pysmt:optimizations","ref":"optimizations","sha":"07bb800a70732901682eb8d1a7bf3577d26bf765","user":{"login":"pysmt","id":10014498,"avatar_url":"https://avatars.githubusercontent.com/u/10014498?v=3","gravatar_id":"","url":"https://api.github.com/users/pysmt","html_url":"https://github.com/pysmt","followers_url":"https://api.github.com/users/pysmt/followers","following_url":"https://api.github.com/users/pysmt/following{/other_user}","gists_url":"https://api.github.com/users/pysmt/gists{/gist_id}","starred_url":"https://api.github.com/users/pysmt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pysmt/subscriptions","organizations_url":"https://api.github.com/users/pysmt/orgs","repos_url":"https://api.github.com/users/pysmt/repos","events_url":"https://api.github.com/users/pysmt/events{/privacy}","received_events_url":"https://api.github.com/users/pysmt/received_events","type":"Organization","site_admin":false},"repo":{"id":27359780,"name":"pysmt","full_name":"pysmt/pysmt","owner":{"login":"pysmt","id":10014498,"avatar_url":"https://avatars.githubusercontent.com/u/10014498?v=3","gravatar_id":"","url":"https://api.github.com/users/pysmt","html_url":"https://github.com/pysmt","followers_url":"https://api.github.com/users/pysmt/followers","following_url":"https://api.github.com/users/pysmt/following{/other_user}","gists_url":"https://api.github.com/users/pysmt/gists{/gist_id}","starred_url":"https://api.github.com/users/pysmt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pysmt/subscriptions","organizations_url":"https://api.github.com/users/pysmt/orgs","repos_url":"https://api.github.com/users/pysmt/repos","events_url":"https://api.github.com/users/pysmt/events{/privacy}","received_events_url":"https://api.github.com/users/pysmt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pysmt/pysmt","description":"pySMT: A library for SMT formulae manipulation and solving","fork":false,"url":"https://api.github.com/repos/pysmt/pysmt","forks_url":"https://api.github.com/repos/pysmt/pysmt/forks","keys_url":"https://api.github.com/repos/pysmt/pysmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pysmt/pysmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pysmt/pysmt/teams","hooks_url":"https://api.github.com/repos/pysmt/pysmt/hooks","issue_events_url":"https://api.github.com/repos/pysmt/pysmt/issues/events{/number}","events_url":"https://api.github.com/repos/pysmt/pysmt/events","assignees_url":"https://api.github.com/repos/pysmt/pysmt/assignees{/user}","branches_url":"https://api.github.com/repos/pysmt/pysmt/branches{/branch}","tags_url":"https://api.github.com/repos/pysmt/pysmt/tags","blobs_url":"https://api.github.com/repos/pysmt/pysmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pysmt/pysmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pysmt/pysmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/pysmt/pysmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pysmt/pysmt/statuses/{sha}","languages_url":"https://api.github.com/repos/pysmt/pysmt/languages","stargazers_url":"https://api.github.com/repos/pysmt/pysmt/stargazers","contributors_url":"https://api.github.com/repos/pysmt/pysmt/contributors","subscribers_url":"https://api.github.com/repos/pysmt/pysmt/subscribers","subscription_url":"https://api.github.com/repos/pysmt/pysmt/subscription","commits_url":"https://api.github.com/repos/pysmt/pysmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/pysmt/pysmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/pysmt/pysmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/pysmt/pysmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/pysmt/pysmt/contents/{+path}","compare_url":"https://api.github.com/repos/pysmt/pysmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pysmt/pysmt/merges","archive_url":"https://api.github.com/repos/pysmt/pysmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pysmt/pysmt/downloads","issues_url":"https://api.github.com/repos/pysmt/pysmt/issues{/number}","pulls_url":"https://api.github.com/repos/pysmt/pysmt/pulls{/number}","milestones_url":"https://api.github.com/repos/pysmt/pysmt/milestones{/number}","notifications_url":"https://api.github.com/repos/pysmt/pysmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pysmt/pysmt/labels{/name}","releases_url":"https://api.github.com/repos/pysmt/pysmt/releases{/id}","deployments_url":"https://api.github.com/repos/pysmt/pysmt/deployments","created_at":"2014-12-01T02:52:26Z","updated_at":"2016-04-14T05:16:16Z","pushed_at":"2016-04-21T07:40:26Z","git_url":"git://github.com/pysmt/pysmt.git","ssh_url":"git@github.com:pysmt/pysmt.git","clone_url":"https://github.com/pysmt/pysmt.git","svn_url":"https://github.com/pysmt/pysmt","homepage":"http://www.pysmt.org","size":1826,"stargazers_count":61,"watchers_count":61,"language":"SMT","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":28,"forks":13,"open_issues":28,"watchers":61,"default_branch":"master"}},"base":{"label":"pysmt:master","ref":"master","sha":"2a1cfff0701e210f66b76a778ed2416af8e449f1","user":{"login":"pysmt","id":10014498,"avatar_url":"https://avatars.githubusercontent.com/u/10014498?v=3","gravatar_id":"","url":"https://api.github.com/users/pysmt","html_url":"https://github.com/pysmt","followers_url":"https://api.github.com/users/pysmt/followers","following_url":"https://api.github.com/users/pysmt/following{/other_user}","gists_url":"https://api.github.com/users/pysmt/gists{/gist_id}","starred_url":"https://api.github.com/users/pysmt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pysmt/subscriptions","organizations_url":"https://api.github.com/users/pysmt/orgs","repos_url":"https://api.github.com/users/pysmt/repos","events_url":"https://api.github.com/users/pysmt/events{/privacy}","received_events_url":"https://api.github.com/users/pysmt/received_events","type":"Organization","site_admin":false},"repo":{"id":27359780,"name":"pysmt","full_name":"pysmt/pysmt","owner":{"login":"pysmt","id":10014498,"avatar_url":"https://avatars.githubusercontent.com/u/10014498?v=3","gravatar_id":"","url":"https://api.github.com/users/pysmt","html_url":"https://github.com/pysmt","followers_url":"https://api.github.com/users/pysmt/followers","following_url":"https://api.github.com/users/pysmt/following{/other_user}","gists_url":"https://api.github.com/users/pysmt/gists{/gist_id}","starred_url":"https://api.github.com/users/pysmt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pysmt/subscriptions","organizations_url":"https://api.github.com/users/pysmt/orgs","repos_url":"https://api.github.com/users/pysmt/repos","events_url":"https://api.github.com/users/pysmt/events{/privacy}","received_events_url":"https://api.github.com/users/pysmt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pysmt/pysmt","description":"pySMT: A library for SMT formulae manipulation and solving","fork":false,"url":"https://api.github.com/repos/pysmt/pysmt","forks_url":"https://api.github.com/repos/pysmt/pysmt/forks","keys_url":"https://api.github.com/repos/pysmt/pysmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pysmt/pysmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pysmt/pysmt/teams","hooks_url":"https://api.github.com/repos/pysmt/pysmt/hooks","issue_events_url":"https://api.github.com/repos/pysmt/pysmt/issues/events{/number}","events_url":"https://api.github.com/repos/pysmt/pysmt/events","assignees_url":"https://api.github.com/repos/pysmt/pysmt/assignees{/user}","branches_url":"https://api.github.com/repos/pysmt/pysmt/branches{/branch}","tags_url":"https://api.github.com/repos/pysmt/pysmt/tags","blobs_url":"https://api.github.com/repos/pysmt/pysmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pysmt/pysmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pysmt/pysmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/pysmt/pysmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pysmt/pysmt/statuses/{sha}","languages_url":"https://api.github.com/repos/pysmt/pysmt/languages","stargazers_url":"https://api.github.com/repos/pysmt/pysmt/stargazers","contributors_url":"https://api.github.com/repos/pysmt/pysmt/contributors","subscribers_url":"https://api.github.com/repos/pysmt/pysmt/subscribers","subscription_url":"https://api.github.com/repos/pysmt/pysmt/subscription","commits_url":"https://api.github.com/repos/pysmt/pysmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/pysmt/pysmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/pysmt/pysmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/pysmt/pysmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/pysmt/pysmt/contents/{+path}","compare_url":"https://api.github.com/repos/pysmt/pysmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pysmt/pysmt/merges","archive_url":"https://api.github.com/repos/pysmt/pysmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pysmt/pysmt/downloads","issues_url":"https://api.github.com/repos/pysmt/pysmt/issues{/number}","pulls_url":"https://api.github.com/repos/pysmt/pysmt/pulls{/number}","milestones_url":"https://api.github.com/repos/pysmt/pysmt/milestones{/number}","notifications_url":"https://api.github.com/repos/pysmt/pysmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pysmt/pysmt/labels{/name}","releases_url":"https://api.github.com/repos/pysmt/pysmt/releases{/id}","deployments_url":"https://api.github.com/repos/pysmt/pysmt/deployments","created_at":"2014-12-01T02:52:26Z","updated_at":"2016-04-14T05:16:16Z","pushed_at":"2016-04-21T07:40:26Z","git_url":"git://github.com/pysmt/pysmt.git","ssh_url":"git@github.com:pysmt/pysmt.git","clone_url":"https://github.com/pysmt/pysmt.git","svn_url":"https://github.com/pysmt/pysmt","homepage":"http://www.pysmt.org","size":1826,"stargazers_count":61,"watchers_count":61,"language":"SMT","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":28,"forks":13,"open_issues":28,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pysmt/pysmt/pulls/247"},"html":{"href":"https://github.com/pysmt/pysmt/pull/247"},"issue":{"href":"https://api.github.com/repos/pysmt/pysmt/issues/247"},"comments":{"href":"https://api.github.com/repos/pysmt/pysmt/issues/247/comments"},"review_comments":{"href":"https://api.github.com/repos/pysmt/pysmt/pulls/247/comments"},"review_comment":{"href":"https://api.github.com/repos/pysmt/pysmt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pysmt/pysmt/pulls/247/commits"},"statuses":{"href":"https://api.github.com/repos/pysmt/pysmt/statuses/07bb800a70732901682eb8d1a7bf3577d26bf765"}}}}