{"action":"created","issue":{"url":"https://api.github.com/repos/alexa-pi/AlexaPi/issues/30","repository_url":"https://api.github.com/repos/alexa-pi/AlexaPi","labels_url":"https://api.github.com/repos/alexa-pi/AlexaPi/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/alexa-pi/AlexaPi/issues/30/comments","events_url":"https://api.github.com/repos/alexa-pi/AlexaPi/issues/30/events","html_url":"https://github.com/alexa-pi/AlexaPi/pull/30","id":179087123,"number":30,"title":"Device platforms - fixes #26","user":{"login":"renekliment","id":156399,"avatar_url":"https://avatars.githubusercontent.com/u/156399?v=3","gravatar_id":"","url":"https://api.github.com/users/renekliment","html_url":"https://github.com/renekliment","followers_url":"https://api.github.com/users/renekliment/followers","following_url":"https://api.github.com/users/renekliment/following{/other_user}","gists_url":"https://api.github.com/users/renekliment/gists{/gist_id}","starred_url":"https://api.github.com/users/renekliment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renekliment/subscriptions","organizations_url":"https://api.github.com/users/renekliment/orgs","repos_url":"https://api.github.com/users/renekliment/repos","events_url":"https://api.github.com/users/renekliment/events{/privacy}","received_events_url":"https://api.github.com/users/renekliment/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":24,"created_at":"2016-09-25T13:49:38Z","updated_at":"2016-10-21T14:44:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/alexa-pi/AlexaPi/pulls/30","html_url":"https://github.com/alexa-pi/AlexaPi/pull/30","diff_url":"https://github.com/alexa-pi/AlexaPi/pull/30.diff","patch_url":"https://github.com/alexa-pi/AlexaPi/pull/30.patch"},"body":"So here it goes. So far it's quite a silly code.\r\n\r\nTwo things:\r\n- the triggering mechanism probably needs to get some rework - callbacks and stuff instead of polling the `should_record()`\r\n- the stuff in the _desktop_ platform should be common for all _AlexaPi_ platforms and should not require `[Enter]`\r\n\r\nBoth things should be however addressed in #24, because this PR solves only the abstraction / making it modular. It doesn't and shouldn't change the logic. \r\n\r\n@sammachin So this is how I'd do it. If / when this gets merged, feel free to do the thing you wanna do. I suggest adding a `platform.indicate_processing(state=True)` method. But we can discuss that in the corresponding issue / PR.\r\n\r\n@alexa-pi/coreteam Please test."},"comment":{"url":"https://api.github.com/repos/alexa-pi/AlexaPi/issues/comments/255396415","html_url":"https://github.com/alexa-pi/AlexaPi/pull/30#issuecomment-255396415","issue_url":"https://api.github.com/repos/alexa-pi/AlexaPi/issues/30","id":255396415,"user":{"login":"illperipherals","id":17368055,"avatar_url":"https://avatars.githubusercontent.com/u/17368055?v=3","gravatar_id":"","url":"https://api.github.com/users/illperipherals","html_url":"https://github.com/illperipherals","followers_url":"https://api.github.com/users/illperipherals/followers","following_url":"https://api.github.com/users/illperipherals/following{/other_user}","gists_url":"https://api.github.com/users/illperipherals/gists{/gist_id}","starred_url":"https://api.github.com/users/illperipherals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/illperipherals/subscriptions","organizations_url":"https://api.github.com/users/illperipherals/orgs","repos_url":"https://api.github.com/users/illperipherals/repos","events_url":"https://api.github.com/users/illperipherals/events{/privacy}","received_events_url":"https://api.github.com/users/illperipherals/received_events","type":"User","site_admin":false},"created_at":"2016-10-21T14:44:28Z","updated_at":"2016-10-21T14:44:28Z","body":"Good deal! I have been running well over a day since I updated, and everything is working fine on my end. I agree on the merge."}}
{"actor":{"display_login":"illperipherals"}}