{"action":"created","comment":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/comments/84349324","pull_request_review_id":5133109,"id":84349324,"diff_hunk":"@@ -0,0 +1,23 @@\n+# frozen_string_literal: true\n+require 'rails_helper'\n+require_dependency 'evss/claims_service'\n+\n+describe EVSS::BaseService do\n+  context 'with an outage' do\n+    let(:service) { EVSS::ClaimsService.new({}) }","path":"spec/lib/evss/base_service_spec.rb","position":7,"original_position":7,"commit_id":"a3efc457d4988497e823350a8a5e05d7b2d259f7","original_commit_id":"a3efc457d4988497e823350a8a5e05d7b2d259f7","user":{"login":"austin-martinez","id":16657563,"avatar_url":"https://avatars.githubusercontent.com/u/16657563?v=3","gravatar_id":"","url":"https://api.github.com/users/austin-martinez","html_url":"https://github.com/austin-martinez","followers_url":"https://api.github.com/users/austin-martinez/followers","following_url":"https://api.github.com/users/austin-martinez/following{/other_user}","gists_url":"https://api.github.com/users/austin-martinez/gists{/gist_id}","starred_url":"https://api.github.com/users/austin-martinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austin-martinez/subscriptions","organizations_url":"https://api.github.com/users/austin-martinez/orgs","repos_url":"https://api.github.com/users/austin-martinez/repos","events_url":"https://api.github.com/users/austin-martinez/events{/privacy}","received_events_url":"https://api.github.com/users/austin-martinez/received_events","type":"User","site_admin":false},"body":"Could you create a dummy class that has the BaseService as its parent and instantiate that here? Then you could either `send :get/:post` on that instance or define methods in the dummy class that call those? That may not work with the way the breakers services are set up though. In the end I think what you had before may be the best, just in a different file 😃  ","created_at":"2016-10-20T18:39:20Z","updated_at":"2016-10-20T18:39:20Z","html_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/307#discussion_r84349324","pull_request_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/307","_links":{"self":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/comments/84349324"},"html":{"href":"https://github.com/department-of-veterans-affairs/vets-api/pull/307#discussion_r84349324"},"pull_request":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/307"}}},"pull_request":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/307","id":90227573,"html_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/307","diff_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/307.diff","patch_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/307.patch","issue_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/307","number":307,"state":"open","locked":false,"title":"add breakers for EVSS","user":{"login":"aub","id":2895,"avatar_url":"https://avatars.githubusercontent.com/u/2895?v=3","gravatar_id":"","url":"https://api.github.com/users/aub","html_url":"https://github.com/aub","followers_url":"https://api.github.com/users/aub/followers","following_url":"https://api.github.com/users/aub/following{/other_user}","gists_url":"https://api.github.com/users/aub/gists{/gist_id}","starred_url":"https://api.github.com/users/aub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aub/subscriptions","organizations_url":"https://api.github.com/users/aub/orgs","repos_url":"https://api.github.com/users/aub/repos","events_url":"https://api.github.com/users/aub/events{/privacy}","received_events_url":"https://api.github.com/users/aub/received_events","type":"User","site_admin":false},"body":"This adds Breakers to the EVSS Claims, Common, and Documents services. It just needs to create the new breakers services and include the middleware at the Base level.","created_at":"2016-10-20T15:45:51Z","updated_at":"2016-10-20T18:39:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e92ae4313424cbc775f5365a55f78b962f40d1ea","assignee":{"login":"robbiethegeek","id":408668,"avatar_url":"https://avatars.githubusercontent.com/u/408668?v=3","gravatar_id":"","url":"https://api.github.com/users/robbiethegeek","html_url":"https://github.com/robbiethegeek","followers_url":"https://api.github.com/users/robbiethegeek/followers","following_url":"https://api.github.com/users/robbiethegeek/following{/other_user}","gists_url":"https://api.github.com/users/robbiethegeek/gists{/gist_id}","starred_url":"https://api.github.com/users/robbiethegeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbiethegeek/subscriptions","organizations_url":"https://api.github.com/users/robbiethegeek/orgs","repos_url":"https://api.github.com/users/robbiethegeek/repos","events_url":"https://api.github.com/users/robbiethegeek/events{/privacy}","received_events_url":"https://api.github.com/users/robbiethegeek/received_events","type":"User","site_admin":false},"assignees":[{"login":"robbiethegeek","id":408668,"avatar_url":"https://avatars.githubusercontent.com/u/408668?v=3","gravatar_id":"","url":"https://api.github.com/users/robbiethegeek","html_url":"https://github.com/robbiethegeek","followers_url":"https://api.github.com/users/robbiethegeek/followers","following_url":"https://api.github.com/users/robbiethegeek/following{/other_user}","gists_url":"https://api.github.com/users/robbiethegeek/gists{/gist_id}","starred_url":"https://api.github.com/users/robbiethegeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbiethegeek/subscriptions","organizations_url":"https://api.github.com/users/robbiethegeek/orgs","repos_url":"https://api.github.com/users/robbiethegeek/repos","events_url":"https://api.github.com/users/robbiethegeek/events{/privacy}","received_events_url":"https://api.github.com/users/robbiethegeek/received_events","type":"User","site_admin":false},{"login":"austin-martinez","id":16657563,"avatar_url":"https://avatars.githubusercontent.com/u/16657563?v=3","gravatar_id":"","url":"https://api.github.com/users/austin-martinez","html_url":"https://github.com/austin-martinez","followers_url":"https://api.github.com/users/austin-martinez/followers","following_url":"https://api.github.com/users/austin-martinez/following{/other_user}","gists_url":"https://api.github.com/users/austin-martinez/gists{/gist_id}","starred_url":"https://api.github.com/users/austin-martinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austin-martinez/subscriptions","organizations_url":"https://api.github.com/users/austin-martinez/orgs","repos_url":"https://api.github.com/users/austin-martinez/repos","events_url":"https://api.github.com/users/austin-martinez/events{/privacy}","received_events_url":"https://api.github.com/users/austin-martinez/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/307/commits","review_comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/307/comments","review_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/307/comments","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/statuses/a3efc457d4988497e823350a8a5e05d7b2d259f7","head":{"label":"department-of-veterans-affairs:evss_breakers","ref":"evss_breakers","sha":"a3efc457d4988497e823350a8a5e05d7b2d259f7","user":{"login":"department-of-veterans-affairs","id":5421563,"avatar_url":"https://avatars.githubusercontent.com/u/5421563?v=3","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"repo":{"id":62409417,"name":"vets-api","full_name":"department-of-veterans-affairs/vets-api","owner":{"login":"department-of-veterans-affairs","id":5421563,"avatar_url":"https://avatars.githubusercontent.com/u/5421563?v=3","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/department-of-veterans-affairs/vets-api","description":"API for vets.gov","fork":false,"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api","forks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/forks","keys_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/teams","hooks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/hooks","issue_events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/events{/number}","events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/events","assignees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/assignees{/user}","branches_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/branches{/branch}","tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/tags","blobs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/statuses/{sha}","languages_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/languages","stargazers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/stargazers","contributors_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/contributors","subscribers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/subscribers","subscription_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/subscription","commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/contents/{+path}","compare_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/merges","archive_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/downloads","issues_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues{/number}","pulls_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls{/number}","milestones_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/milestones{/number}","notifications_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/labels{/name}","releases_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/releases{/id}","deployments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/deployments","created_at":"2016-07-01T17:33:19Z","updated_at":"2016-10-03T04:59:16Z","pushed_at":"2016-10-20T18:26:50Z","git_url":"git://github.com/department-of-veterans-affairs/vets-api.git","ssh_url":"git@github.com:department-of-veterans-affairs/vets-api.git","clone_url":"https://github.com/department-of-veterans-affairs/vets-api.git","svn_url":"https://github.com/department-of-veterans-affairs/vets-api","homepage":null,"size":4717,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":39,"forks":1,"open_issues":39,"watchers":4,"default_branch":"master"}},"base":{"label":"department-of-veterans-affairs:master","ref":"master","sha":"af00ecbc52342d7cbc8a57abbbc3c9450f0bf6c5","user":{"login":"department-of-veterans-affairs","id":5421563,"avatar_url":"https://avatars.githubusercontent.com/u/5421563?v=3","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"repo":{"id":62409417,"name":"vets-api","full_name":"department-of-veterans-affairs/vets-api","owner":{"login":"department-of-veterans-affairs","id":5421563,"avatar_url":"https://avatars.githubusercontent.com/u/5421563?v=3","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/department-of-veterans-affairs/vets-api","description":"API for vets.gov","fork":false,"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api","forks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/forks","keys_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/teams","hooks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/hooks","issue_events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/events{/number}","events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/events","assignees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/assignees{/user}","branches_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/branches{/branch}","tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/tags","blobs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/statuses/{sha}","languages_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/languages","stargazers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/stargazers","contributors_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/contributors","subscribers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/subscribers","subscription_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/subscription","commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/contents/{+path}","compare_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/merges","archive_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/downloads","issues_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues{/number}","pulls_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls{/number}","milestones_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/milestones{/number}","notifications_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/labels{/name}","releases_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/releases{/id}","deployments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/deployments","created_at":"2016-07-01T17:33:19Z","updated_at":"2016-10-03T04:59:16Z","pushed_at":"2016-10-20T18:26:50Z","git_url":"git://github.com/department-of-veterans-affairs/vets-api.git","ssh_url":"git@github.com:department-of-veterans-affairs/vets-api.git","clone_url":"https://github.com/department-of-veterans-affairs/vets-api.git","svn_url":"https://github.com/department-of-veterans-affairs/vets-api","homepage":null,"size":4717,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":39,"forks":1,"open_issues":39,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/307"},"html":{"href":"https://github.com/department-of-veterans-affairs/vets-api/pull/307"},"issue":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/307"},"comments":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/307/comments"},"review_comments":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/307/comments"},"review_comment":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/307/commits"},"statuses":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/statuses/a3efc457d4988497e823350a8a5e05d7b2d259f7"}}}}
{"actor":{"display_login":"austin-martinez"}}