{"action":"created","comment":{"url":"https://api.github.com/repos/ory-am/fosite/pulls/comments/82960446","pull_request_review_id":3830102,"id":82960446,"diff_hunk":"@@ -0,0 +1,26 @@\n+package oauth2\n+\n+import (\n+\t\"golang.org/x/net/context\"\n+\n+\t\"github.com/ory-am/fosite\"\n+)\n+\n+type TokenRevocationHandler struct {\n+\tTokenRevocationStorage TokenRevocationStorage\n+}\n+\n+// RevokeToken implements https://tools.ietf.org/html/rfc7009#section-2.1\n+func (r *TokenRevocationHandler) RevokeToken(ctx context.Context, token string, tokenType fosite.TokenType) error {\n+\tif tokenType == fosite.RefreshToken {","path":"handler/oauth2/flow_revoke.go","position":15,"original_position":15,"commit_id":"67d2cc2c29a554eaa20e36959e811a7304c2d82c","original_commit_id":"67d2cc2c29a554eaa20e36959e811a7304c2d82c","user":{"login":"arekkas","id":3372410,"avatar_url":"https://avatars.githubusercontent.com/u/3372410?v=3","gravatar_id":"","url":"https://api.github.com/users/arekkas","html_url":"https://github.com/arekkas","followers_url":"https://api.github.com/users/arekkas/followers","following_url":"https://api.github.com/users/arekkas/following{/other_user}","gists_url":"https://api.github.com/users/arekkas/gists{/gist_id}","starred_url":"https://api.github.com/users/arekkas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arekkas/subscriptions","organizations_url":"https://api.github.com/users/arekkas/orgs","repos_url":"https://api.github.com/users/arekkas/repos","events_url":"https://api.github.com/users/arekkas/events{/privacy}","received_events_url":"https://api.github.com/users/arekkas/received_events","type":"User","site_admin":false},"body":"It looks like this is clashing with the definition:\r\n\r\n>   token_type_hint  OPTIONAL.  A hint about the type of the token\r\n           submitted for revocation.  Clients MAY pass this parameter in\r\n           order to help the authorization server to optimize the token\r\n           lookup.  If the server is unable to locate the token using\r\n           the given hint, it MUST extend its search across all of its\r\n           supported token types.  An authorization server MAY ignore\r\n           this parameter, particularly if it is able to detect the\r\n           token type automatically.  This specification defines two\r\n           such values:","created_at":"2016-10-12T08:46:14Z","updated_at":"2016-10-12T08:46:14Z","html_url":"https://github.com/ory-am/fosite/pull/112#discussion_r82960446","pull_request_url":"https://api.github.com/repos/ory-am/fosite/pulls/112","_links":{"self":{"href":"https://api.github.com/repos/ory-am/fosite/pulls/comments/82960446"},"html":{"href":"https://github.com/ory-am/fosite/pull/112#discussion_r82960446"},"pull_request":{"href":"https://api.github.com/repos/ory-am/fosite/pulls/112"}}},"pull_request":{"url":"https://api.github.com/repos/ory-am/fosite/pulls/112","id":88953356,"html_url":"https://github.com/ory-am/fosite/pull/112","diff_url":"https://github.com/ory-am/fosite/pull/112.diff","patch_url":"https://github.com/ory-am/fosite/pull/112.patch","issue_url":"https://api.github.com/repos/ory-am/fosite/issues/112","number":112,"state":"open","locked":false,"title":"oauth2: added token revocation handling","user":{"login":"jrossiter","id":7498914,"avatar_url":"https://avatars.githubusercontent.com/u/7498914?v=3","gravatar_id":"","url":"https://api.github.com/users/jrossiter","html_url":"https://github.com/jrossiter","followers_url":"https://api.github.com/users/jrossiter/followers","following_url":"https://api.github.com/users/jrossiter/following{/other_user}","gists_url":"https://api.github.com/users/jrossiter/gists{/gist_id}","starred_url":"https://api.github.com/users/jrossiter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrossiter/subscriptions","organizations_url":"https://api.github.com/users/jrossiter/orgs","repos_url":"https://api.github.com/users/jrossiter/repos","events_url":"https://api.github.com/users/jrossiter/events{/privacy}","received_events_url":"https://api.github.com/users/jrossiter/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Jason Rossiter <jrossiter403@gmail.com>","created_at":"2016-10-12T04:52:56Z","updated_at":"2016-10-12T08:46:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4516cc25aeae41f2629fc9fcb87dee702025ed34","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ory-am/fosite/pulls/112/commits","review_comments_url":"https://api.github.com/repos/ory-am/fosite/pulls/112/comments","review_comment_url":"https://api.github.com/repos/ory-am/fosite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ory-am/fosite/issues/112/comments","statuses_url":"https://api.github.com/repos/ory-am/fosite/statuses/67d2cc2c29a554eaa20e36959e811a7304c2d82c","head":{"label":"jrossiter:oauth2-token-revocation","ref":"oauth2-token-revocation","sha":"67d2cc2c29a554eaa20e36959e811a7304c2d82c","user":{"login":"jrossiter","id":7498914,"avatar_url":"https://avatars.githubusercontent.com/u/7498914?v=3","gravatar_id":"","url":"https://api.github.com/users/jrossiter","html_url":"https://github.com/jrossiter","followers_url":"https://api.github.com/users/jrossiter/followers","following_url":"https://api.github.com/users/jrossiter/following{/other_user}","gists_url":"https://api.github.com/users/jrossiter/gists{/gist_id}","starred_url":"https://api.github.com/users/jrossiter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrossiter/subscriptions","organizations_url":"https://api.github.com/users/jrossiter/orgs","repos_url":"https://api.github.com/users/jrossiter/repos","events_url":"https://api.github.com/users/jrossiter/events{/privacy}","received_events_url":"https://api.github.com/users/jrossiter/received_events","type":"User","site_admin":false},"repo":{"id":70043531,"name":"fosite","full_name":"jrossiter/fosite","owner":{"login":"jrossiter","id":7498914,"avatar_url":"https://avatars.githubusercontent.com/u/7498914?v=3","gravatar_id":"","url":"https://api.github.com/users/jrossiter","html_url":"https://github.com/jrossiter","followers_url":"https://api.github.com/users/jrossiter/followers","following_url":"https://api.github.com/users/jrossiter/following{/other_user}","gists_url":"https://api.github.com/users/jrossiter/gists{/gist_id}","starred_url":"https://api.github.com/users/jrossiter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrossiter/subscriptions","organizations_url":"https://api.github.com/users/jrossiter/orgs","repos_url":"https://api.github.com/users/jrossiter/repos","events_url":"https://api.github.com/users/jrossiter/events{/privacy}","received_events_url":"https://api.github.com/users/jrossiter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrossiter/fosite","description":"Extensible security first OAuth2 and OpenID Connect framework for Google's Go Language.","fork":true,"url":"https://api.github.com/repos/jrossiter/fosite","forks_url":"https://api.github.com/repos/jrossiter/fosite/forks","keys_url":"https://api.github.com/repos/jrossiter/fosite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrossiter/fosite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrossiter/fosite/teams","hooks_url":"https://api.github.com/repos/jrossiter/fosite/hooks","issue_events_url":"https://api.github.com/repos/jrossiter/fosite/issues/events{/number}","events_url":"https://api.github.com/repos/jrossiter/fosite/events","assignees_url":"https://api.github.com/repos/jrossiter/fosite/assignees{/user}","branches_url":"https://api.github.com/repos/jrossiter/fosite/branches{/branch}","tags_url":"https://api.github.com/repos/jrossiter/fosite/tags","blobs_url":"https://api.github.com/repos/jrossiter/fosite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrossiter/fosite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrossiter/fosite/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrossiter/fosite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrossiter/fosite/statuses/{sha}","languages_url":"https://api.github.com/repos/jrossiter/fosite/languages","stargazers_url":"https://api.github.com/repos/jrossiter/fosite/stargazers","contributors_url":"https://api.github.com/repos/jrossiter/fosite/contributors","subscribers_url":"https://api.github.com/repos/jrossiter/fosite/subscribers","subscription_url":"https://api.github.com/repos/jrossiter/fosite/subscription","commits_url":"https://api.github.com/repos/jrossiter/fosite/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrossiter/fosite/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrossiter/fosite/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrossiter/fosite/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrossiter/fosite/contents/{+path}","compare_url":"https://api.github.com/repos/jrossiter/fosite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrossiter/fosite/merges","archive_url":"https://api.github.com/repos/jrossiter/fosite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrossiter/fosite/downloads","issues_url":"https://api.github.com/repos/jrossiter/fosite/issues{/number}","pulls_url":"https://api.github.com/repos/jrossiter/fosite/pulls{/number}","milestones_url":"https://api.github.com/repos/jrossiter/fosite/milestones{/number}","notifications_url":"https://api.github.com/repos/jrossiter/fosite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrossiter/fosite/labels{/name}","releases_url":"https://api.github.com/repos/jrossiter/fosite/releases{/id}","deployments_url":"https://api.github.com/repos/jrossiter/fosite/deployments","created_at":"2016-10-05T08:46:15Z","updated_at":"2016-10-05T08:46:16Z","pushed_at":"2016-10-12T04:55:36Z","git_url":"git://github.com/jrossiter/fosite.git","ssh_url":"git@github.com:jrossiter/fosite.git","clone_url":"https://github.com/jrossiter/fosite.git","svn_url":"https://github.com/jrossiter/fosite","homepage":"","size":4816,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ory-am:master","ref":"master","sha":"60a767221625d0f6541f203e41a7ef20a1782eb0","user":{"login":"ory-am","id":10667373,"avatar_url":"https://avatars.githubusercontent.com/u/10667373?v=3","gravatar_id":"","url":"https://api.github.com/users/ory-am","html_url":"https://github.com/ory-am","followers_url":"https://api.github.com/users/ory-am/followers","following_url":"https://api.github.com/users/ory-am/following{/other_user}","gists_url":"https://api.github.com/users/ory-am/gists{/gist_id}","starred_url":"https://api.github.com/users/ory-am/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ory-am/subscriptions","organizations_url":"https://api.github.com/users/ory-am/orgs","repos_url":"https://api.github.com/users/ory-am/repos","events_url":"https://api.github.com/users/ory-am/events{/privacy}","received_events_url":"https://api.github.com/users/ory-am/received_events","type":"Organization","site_admin":false},"repo":{"id":48582772,"name":"fosite","full_name":"ory-am/fosite","owner":{"login":"ory-am","id":10667373,"avatar_url":"https://avatars.githubusercontent.com/u/10667373?v=3","gravatar_id":"","url":"https://api.github.com/users/ory-am","html_url":"https://github.com/ory-am","followers_url":"https://api.github.com/users/ory-am/followers","following_url":"https://api.github.com/users/ory-am/following{/other_user}","gists_url":"https://api.github.com/users/ory-am/gists{/gist_id}","starred_url":"https://api.github.com/users/ory-am/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ory-am/subscriptions","organizations_url":"https://api.github.com/users/ory-am/orgs","repos_url":"https://api.github.com/users/ory-am/repos","events_url":"https://api.github.com/users/ory-am/events{/privacy}","received_events_url":"https://api.github.com/users/ory-am/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ory-am/fosite","description":"Extensible security first OAuth2 and OpenID Connect framework for Google's Go Language.","fork":false,"url":"https://api.github.com/repos/ory-am/fosite","forks_url":"https://api.github.com/repos/ory-am/fosite/forks","keys_url":"https://api.github.com/repos/ory-am/fosite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ory-am/fosite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ory-am/fosite/teams","hooks_url":"https://api.github.com/repos/ory-am/fosite/hooks","issue_events_url":"https://api.github.com/repos/ory-am/fosite/issues/events{/number}","events_url":"https://api.github.com/repos/ory-am/fosite/events","assignees_url":"https://api.github.com/repos/ory-am/fosite/assignees{/user}","branches_url":"https://api.github.com/repos/ory-am/fosite/branches{/branch}","tags_url":"https://api.github.com/repos/ory-am/fosite/tags","blobs_url":"https://api.github.com/repos/ory-am/fosite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ory-am/fosite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ory-am/fosite/git/refs{/sha}","trees_url":"https://api.github.com/repos/ory-am/fosite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ory-am/fosite/statuses/{sha}","languages_url":"https://api.github.com/repos/ory-am/fosite/languages","stargazers_url":"https://api.github.com/repos/ory-am/fosite/stargazers","contributors_url":"https://api.github.com/repos/ory-am/fosite/contributors","subscribers_url":"https://api.github.com/repos/ory-am/fosite/subscribers","subscription_url":"https://api.github.com/repos/ory-am/fosite/subscription","commits_url":"https://api.github.com/repos/ory-am/fosite/commits{/sha}","git_commits_url":"https://api.github.com/repos/ory-am/fosite/git/commits{/sha}","comments_url":"https://api.github.com/repos/ory-am/fosite/comments{/number}","issue_comment_url":"https://api.github.com/repos/ory-am/fosite/issues/comments{/number}","contents_url":"https://api.github.com/repos/ory-am/fosite/contents/{+path}","compare_url":"https://api.github.com/repos/ory-am/fosite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ory-am/fosite/merges","archive_url":"https://api.github.com/repos/ory-am/fosite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ory-am/fosite/downloads","issues_url":"https://api.github.com/repos/ory-am/fosite/issues{/number}","pulls_url":"https://api.github.com/repos/ory-am/fosite/pulls{/number}","milestones_url":"https://api.github.com/repos/ory-am/fosite/milestones{/number}","notifications_url":"https://api.github.com/repos/ory-am/fosite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ory-am/fosite/labels{/name}","releases_url":"https://api.github.com/repos/ory-am/fosite/releases{/id}","deployments_url":"https://api.github.com/repos/ory-am/fosite/deployments","created_at":"2015-12-25T14:23:27Z","updated_at":"2016-10-06T09:52:30Z","pushed_at":"2016-10-12T04:55:36Z","git_url":"git://github.com/ory-am/fosite.git","ssh_url":"git@github.com:ory-am/fosite.git","clone_url":"https://github.com/ory-am/fosite.git","svn_url":"https://github.com/ory-am/fosite","homepage":"","size":4940,"stargazers_count":645,"watchers_count":645,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":15,"forks":31,"open_issues":15,"watchers":645,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ory-am/fosite/pulls/112"},"html":{"href":"https://github.com/ory-am/fosite/pull/112"},"issue":{"href":"https://api.github.com/repos/ory-am/fosite/issues/112"},"comments":{"href":"https://api.github.com/repos/ory-am/fosite/issues/112/comments"},"review_comments":{"href":"https://api.github.com/repos/ory-am/fosite/pulls/112/comments"},"review_comment":{"href":"https://api.github.com/repos/ory-am/fosite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ory-am/fosite/pulls/112/commits"},"statuses":{"href":"https://api.github.com/repos/ory-am/fosite/statuses/67d2cc2c29a554eaa20e36959e811a7304c2d82c"}}}}
{"actor":{"display_login":"arekkas"}}