{"action":"created","comment":{"url":"https://api.github.com/repos/Icenium/icenium-cli/pulls/comments/68527143","id":68527143,"diff_hunk":"@@ -336,8 +296,48 @@ export class CordovaProjectPluginsService implements IPluginsService {\n \t\t}).future<IPlugin[]>()();\n \t}\n \n+\tprotected getPluginsDirName(): string {\n+\t\treturn \"plugins\";","path":"lib/services/plugins/cordova-project-plugins-service.ts","position":342,"original_position":342,"commit_id":"de190cd783507084ebc31b5b047e75e916f08a12","original_commit_id":"de190cd783507084ebc31b5b047e75e916f08a12","user":{"login":"rosen-vladimirov","id":8351653,"avatar_url":"https://avatars.githubusercontent.com/u/8351653?v=3","gravatar_id":"","url":"https://api.github.com/users/rosen-vladimirov","html_url":"https://github.com/rosen-vladimirov","followers_url":"https://api.github.com/users/rosen-vladimirov/followers","following_url":"https://api.github.com/users/rosen-vladimirov/following{/other_user}","gists_url":"https://api.github.com/users/rosen-vladimirov/gists{/gist_id}","starred_url":"https://api.github.com/users/rosen-vladimirov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosen-vladimirov/subscriptions","organizations_url":"https://api.github.com/users/rosen-vladimirov/orgs","repos_url":"https://api.github.com/users/rosen-vladimirov/repos","events_url":"https://api.github.com/users/rosen-vladimirov/events{/privacy}","received_events_url":"https://api.github.com/users/rosen-vladimirov/received_events","type":"User","site_admin":false},"body":"is it \"plugins\" or \"Plugins\"? On Linux this is really important","created_at":"2016-06-27T06:24:53Z","updated_at":"2016-06-27T06:24:53Z","html_url":"https://github.com/Icenium/icenium-cli/pull/1452#discussion_r68527143","pull_request_url":"https://api.github.com/repos/Icenium/icenium-cli/pulls/1452","_links":{"self":{"href":"https://api.github.com/repos/Icenium/icenium-cli/pulls/comments/68527143"},"html":{"href":"https://github.com/Icenium/icenium-cli/pull/1452#discussion_r68527143"},"pull_request":{"href":"https://api.github.com/repos/Icenium/icenium-cli/pulls/1452"}}},"pull_request":{"url":"https://api.github.com/repos/Icenium/icenium-cli/pulls/1452","id":74411162,"html_url":"https://github.com/Icenium/icenium-cli/pull/1452","diff_url":"https://github.com/Icenium/icenium-cli/pull/1452.diff","patch_url":"https://github.com/Icenium/icenium-cli/pull/1452.patch","issue_url":"https://api.github.com/repos/Icenium/icenium-cli/issues/1452","number":1452,"state":"open","locked":false,"title":"Use npm to find and fetch Cordova plugins","user":{"login":"TsvetanMilanov","id":10463529,"avatar_url":"https://avatars.githubusercontent.com/u/10463529?v=3","gravatar_id":"","url":"https://api.github.com/users/TsvetanMilanov","html_url":"https://github.com/TsvetanMilanov","followers_url":"https://api.github.com/users/TsvetanMilanov/followers","following_url":"https://api.github.com/users/TsvetanMilanov/following{/other_user}","gists_url":"https://api.github.com/users/TsvetanMilanov/gists{/gist_id}","starred_url":"https://api.github.com/users/TsvetanMilanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TsvetanMilanov/subscriptions","organizations_url":"https://api.github.com/users/TsvetanMilanov/orgs","repos_url":"https://api.github.com/users/TsvetanMilanov/repos","events_url":"https://api.github.com/users/TsvetanMilanov/events{/privacy}","received_events_url":"https://api.github.com/users/TsvetanMilanov/received_events","type":"User","site_admin":false},"body":"The common logic for searching for Cordova and NativeScript plugins in npm is extracted in `npm-plugins-service-base`. The framework specific logic is implemented in `cordova-project-plugins-service` and `nativescript-project-plugins-service`.\r\nThe fetch logic for Cordova tgz plugins is changed - now we extract the plugin in plugins directory. For NativeScript tgz plugins the behavior remains the same - just copy the tgz file in the plugins directory and add the path to it to package.json.\r\nThe remove plugin command now can remove fetched plugins.","created_at":"2016-06-20T09:11:45Z","updated_at":"2016-06-27T06:24:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c76776cb454dd1007218386b1754ecabb196420","assignee":{"login":"TsvetanMilanov","id":10463529,"avatar_url":"https://avatars.githubusercontent.com/u/10463529?v=3","gravatar_id":"","url":"https://api.github.com/users/TsvetanMilanov","html_url":"https://github.com/TsvetanMilanov","followers_url":"https://api.github.com/users/TsvetanMilanov/followers","following_url":"https://api.github.com/users/TsvetanMilanov/following{/other_user}","gists_url":"https://api.github.com/users/TsvetanMilanov/gists{/gist_id}","starred_url":"https://api.github.com/users/TsvetanMilanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TsvetanMilanov/subscriptions","organizations_url":"https://api.github.com/users/TsvetanMilanov/orgs","repos_url":"https://api.github.com/users/TsvetanMilanov/repos","events_url":"https://api.github.com/users/TsvetanMilanov/events{/privacy}","received_events_url":"https://api.github.com/users/TsvetanMilanov/received_events","type":"User","site_admin":false},"assignees":[{"login":"TsvetanMilanov","id":10463529,"avatar_url":"https://avatars.githubusercontent.com/u/10463529?v=3","gravatar_id":"","url":"https://api.github.com/users/TsvetanMilanov","html_url":"https://github.com/TsvetanMilanov","followers_url":"https://api.github.com/users/TsvetanMilanov/followers","following_url":"https://api.github.com/users/TsvetanMilanov/following{/other_user}","gists_url":"https://api.github.com/users/TsvetanMilanov/gists{/gist_id}","starred_url":"https://api.github.com/users/TsvetanMilanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TsvetanMilanov/subscriptions","organizations_url":"https://api.github.com/users/TsvetanMilanov/orgs","repos_url":"https://api.github.com/users/TsvetanMilanov/repos","events_url":"https://api.github.com/users/TsvetanMilanov/events{/privacy}","received_events_url":"https://api.github.com/users/TsvetanMilanov/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Icenium/icenium-cli/milestones/19","html_url":"https://github.com/Icenium/icenium-cli/milestones/3.4","labels_url":"https://api.github.com/repos/Icenium/icenium-cli/milestones/19/labels","id":1837669,"number":19,"title":"3.4","description":"","creator":{"login":"rosen-vladimirov","id":8351653,"avatar_url":"https://avatars.githubusercontent.com/u/8351653?v=3","gravatar_id":"","url":"https://api.github.com/users/rosen-vladimirov","html_url":"https://github.com/rosen-vladimirov","followers_url":"https://api.github.com/users/rosen-vladimirov/followers","following_url":"https://api.github.com/users/rosen-vladimirov/following{/other_user}","gists_url":"https://api.github.com/users/rosen-vladimirov/gists{/gist_id}","starred_url":"https://api.github.com/users/rosen-vladimirov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosen-vladimirov/subscriptions","organizations_url":"https://api.github.com/users/rosen-vladimirov/orgs","repos_url":"https://api.github.com/users/rosen-vladimirov/repos","events_url":"https://api.github.com/users/rosen-vladimirov/events{/privacy}","received_events_url":"https://api.github.com/users/rosen-vladimirov/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":2,"state":"open","created_at":"2016-06-20T09:07:23Z","updated_at":"2016-06-24T14:55:29Z","due_on":"2016-07-24T21:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/Icenium/icenium-cli/pulls/1452/commits","review_comments_url":"https://api.github.com/repos/Icenium/icenium-cli/pulls/1452/comments","review_comment_url":"https://api.github.com/repos/Icenium/icenium-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Icenium/icenium-cli/issues/1452/comments","statuses_url":"https://api.github.com/repos/Icenium/icenium-cli/statuses/de190cd783507084ebc31b5b047e75e916f08a12","head":{"label":"Icenium:milanov/remove-plugman","ref":"milanov/remove-plugman","sha":"de190cd783507084ebc31b5b047e75e916f08a12","user":{"login":"Icenium","id":1152554,"avatar_url":"https://avatars.githubusercontent.com/u/1152554?v=3","gravatar_id":"","url":"https://api.github.com/users/Icenium","html_url":"https://github.com/Icenium","followers_url":"https://api.github.com/users/Icenium/followers","following_url":"https://api.github.com/users/Icenium/following{/other_user}","gists_url":"https://api.github.com/users/Icenium/gists{/gist_id}","starred_url":"https://api.github.com/users/Icenium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Icenium/subscriptions","organizations_url":"https://api.github.com/users/Icenium/orgs","repos_url":"https://api.github.com/users/Icenium/repos","events_url":"https://api.github.com/users/Icenium/events{/privacy}","received_events_url":"https://api.github.com/users/Icenium/received_events","type":"Organization","site_admin":false},"repo":{"id":14398834,"name":"icenium-cli","full_name":"Icenium/icenium-cli","owner":{"login":"Icenium","id":1152554,"avatar_url":"https://avatars.githubusercontent.com/u/1152554?v=3","gravatar_id":"","url":"https://api.github.com/users/Icenium","html_url":"https://github.com/Icenium","followers_url":"https://api.github.com/users/Icenium/followers","following_url":"https://api.github.com/users/Icenium/following{/other_user}","gists_url":"https://api.github.com/users/Icenium/gists{/gist_id}","starred_url":"https://api.github.com/users/Icenium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Icenium/subscriptions","organizations_url":"https://api.github.com/users/Icenium/orgs","repos_url":"https://api.github.com/users/Icenium/repos","events_url":"https://api.github.com/users/Icenium/events{/privacy}","received_events_url":"https://api.github.com/users/Icenium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Icenium/icenium-cli","description":"Cross Platform Command Line Interface for Telerik AppBuilder","fork":false,"url":"https://api.github.com/repos/Icenium/icenium-cli","forks_url":"https://api.github.com/repos/Icenium/icenium-cli/forks","keys_url":"https://api.github.com/repos/Icenium/icenium-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Icenium/icenium-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Icenium/icenium-cli/teams","hooks_url":"https://api.github.com/repos/Icenium/icenium-cli/hooks","issue_events_url":"https://api.github.com/repos/Icenium/icenium-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Icenium/icenium-cli/events","assignees_url":"https://api.github.com/repos/Icenium/icenium-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Icenium/icenium-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Icenium/icenium-cli/tags","blobs_url":"https://api.github.com/repos/Icenium/icenium-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Icenium/icenium-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Icenium/icenium-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Icenium/icenium-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Icenium/icenium-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Icenium/icenium-cli/languages","stargazers_url":"https://api.github.com/repos/Icenium/icenium-cli/stargazers","contributors_url":"https://api.github.com/repos/Icenium/icenium-cli/contributors","subscribers_url":"https://api.github.com/repos/Icenium/icenium-cli/subscribers","subscription_url":"https://api.github.com/repos/Icenium/icenium-cli/subscription","commits_url":"https://api.github.com/repos/Icenium/icenium-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Icenium/icenium-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Icenium/icenium-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Icenium/icenium-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Icenium/icenium-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Icenium/icenium-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Icenium/icenium-cli/merges","archive_url":"https://api.github.com/repos/Icenium/icenium-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Icenium/icenium-cli/downloads","issues_url":"https://api.github.com/repos/Icenium/icenium-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Icenium/icenium-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Icenium/icenium-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Icenium/icenium-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Icenium/icenium-cli/labels{/name}","releases_url":"https://api.github.com/repos/Icenium/icenium-cli/releases{/id}","deployments_url":"https://api.github.com/repos/Icenium/icenium-cli/deployments","created_at":"2013-11-14T15:27:18Z","updated_at":"2016-04-14T13:36:06Z","pushed_at":"2016-06-24T15:56:53Z","git_url":"git://github.com/Icenium/icenium-cli.git","ssh_url":"git@github.com:Icenium/icenium-cli.git","clone_url":"https://github.com/Icenium/icenium-cli.git","svn_url":"https://github.com/Icenium/icenium-cli","homepage":"","size":28421,"stargazers_count":26,"watchers_count":26,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":13,"forks":7,"open_issues":13,"watchers":26,"default_branch":"master"}},"base":{"label":"Icenium:master","ref":"master","sha":"a58de019a611ec63e9517045aae6c8de600dc3b5","user":{"login":"Icenium","id":1152554,"avatar_url":"https://avatars.githubusercontent.com/u/1152554?v=3","gravatar_id":"","url":"https://api.github.com/users/Icenium","html_url":"https://github.com/Icenium","followers_url":"https://api.github.com/users/Icenium/followers","following_url":"https://api.github.com/users/Icenium/following{/other_user}","gists_url":"https://api.github.com/users/Icenium/gists{/gist_id}","starred_url":"https://api.github.com/users/Icenium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Icenium/subscriptions","organizations_url":"https://api.github.com/users/Icenium/orgs","repos_url":"https://api.github.com/users/Icenium/repos","events_url":"https://api.github.com/users/Icenium/events{/privacy}","received_events_url":"https://api.github.com/users/Icenium/received_events","type":"Organization","site_admin":false},"repo":{"id":14398834,"name":"icenium-cli","full_name":"Icenium/icenium-cli","owner":{"login":"Icenium","id":1152554,"avatar_url":"https://avatars.githubusercontent.com/u/1152554?v=3","gravatar_id":"","url":"https://api.github.com/users/Icenium","html_url":"https://github.com/Icenium","followers_url":"https://api.github.com/users/Icenium/followers","following_url":"https://api.github.com/users/Icenium/following{/other_user}","gists_url":"https://api.github.com/users/Icenium/gists{/gist_id}","starred_url":"https://api.github.com/users/Icenium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Icenium/subscriptions","organizations_url":"https://api.github.com/users/Icenium/orgs","repos_url":"https://api.github.com/users/Icenium/repos","events_url":"https://api.github.com/users/Icenium/events{/privacy}","received_events_url":"https://api.github.com/users/Icenium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Icenium/icenium-cli","description":"Cross Platform Command Line Interface for Telerik AppBuilder","fork":false,"url":"https://api.github.com/repos/Icenium/icenium-cli","forks_url":"https://api.github.com/repos/Icenium/icenium-cli/forks","keys_url":"https://api.github.com/repos/Icenium/icenium-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Icenium/icenium-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Icenium/icenium-cli/teams","hooks_url":"https://api.github.com/repos/Icenium/icenium-cli/hooks","issue_events_url":"https://api.github.com/repos/Icenium/icenium-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Icenium/icenium-cli/events","assignees_url":"https://api.github.com/repos/Icenium/icenium-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Icenium/icenium-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Icenium/icenium-cli/tags","blobs_url":"https://api.github.com/repos/Icenium/icenium-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Icenium/icenium-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Icenium/icenium-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Icenium/icenium-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Icenium/icenium-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Icenium/icenium-cli/languages","stargazers_url":"https://api.github.com/repos/Icenium/icenium-cli/stargazers","contributors_url":"https://api.github.com/repos/Icenium/icenium-cli/contributors","subscribers_url":"https://api.github.com/repos/Icenium/icenium-cli/subscribers","subscription_url":"https://api.github.com/repos/Icenium/icenium-cli/subscription","commits_url":"https://api.github.com/repos/Icenium/icenium-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Icenium/icenium-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Icenium/icenium-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Icenium/icenium-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Icenium/icenium-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Icenium/icenium-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Icenium/icenium-cli/merges","archive_url":"https://api.github.com/repos/Icenium/icenium-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Icenium/icenium-cli/downloads","issues_url":"https://api.github.com/repos/Icenium/icenium-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Icenium/icenium-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Icenium/icenium-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Icenium/icenium-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Icenium/icenium-cli/labels{/name}","releases_url":"https://api.github.com/repos/Icenium/icenium-cli/releases{/id}","deployments_url":"https://api.github.com/repos/Icenium/icenium-cli/deployments","created_at":"2013-11-14T15:27:18Z","updated_at":"2016-04-14T13:36:06Z","pushed_at":"2016-06-24T15:56:53Z","git_url":"git://github.com/Icenium/icenium-cli.git","ssh_url":"git@github.com:Icenium/icenium-cli.git","clone_url":"https://github.com/Icenium/icenium-cli.git","svn_url":"https://github.com/Icenium/icenium-cli","homepage":"","size":28421,"stargazers_count":26,"watchers_count":26,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":13,"forks":7,"open_issues":13,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Icenium/icenium-cli/pulls/1452"},"html":{"href":"https://github.com/Icenium/icenium-cli/pull/1452"},"issue":{"href":"https://api.github.com/repos/Icenium/icenium-cli/issues/1452"},"comments":{"href":"https://api.github.com/repos/Icenium/icenium-cli/issues/1452/comments"},"review_comments":{"href":"https://api.github.com/repos/Icenium/icenium-cli/pulls/1452/comments"},"review_comment":{"href":"https://api.github.com/repos/Icenium/icenium-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Icenium/icenium-cli/pulls/1452/commits"},"statuses":{"href":"https://api.github.com/repos/Icenium/icenium-cli/statuses/de190cd783507084ebc31b5b047e75e916f08a12"}}}}
{"actor":{"display_login":"rosen-vladimirov"}}