{"action":"created","issue":{"url":"https://api.github.com/repos/angr/simuvex/issues/16","repository_url":"https://api.github.com/repos/angr/simuvex","labels_url":"https://api.github.com/repos/angr/simuvex/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/angr/simuvex/issues/16/comments","events_url":"https://api.github.com/repos/angr/simuvex/issues/16/events","html_url":"https://github.com/angr/simuvex/pull/16","id":144159298,"number":16,"title":"Update comments and reformatting.","user":{"login":"ekse","id":77594,"avatar_url":"https://avatars.githubusercontent.com/u/77594?v=3","gravatar_id":"","url":"https://api.github.com/users/ekse","html_url":"https://github.com/ekse","followers_url":"https://api.github.com/users/ekse/followers","following_url":"https://api.github.com/users/ekse/following{/other_user}","gists_url":"https://api.github.com/users/ekse/gists{/gist_id}","starred_url":"https://api.github.com/users/ekse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekse/subscriptions","organizations_url":"https://api.github.com/users/ekse/orgs","repos_url":"https://api.github.com/users/ekse/repos","events_url":"https://api.github.com/users/ekse/events{/privacy}","received_events_url":"https://api.github.com/users/ekse/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-29T05:22:08Z","updated_at":"2016-03-30T02:06:15Z","closed_at":"2016-03-29T05:24:34Z","pull_request":{"url":"https://api.github.com/repos/angr/simuvex/pulls/16","html_url":"https://github.com/angr/simuvex/pull/16","diff_url":"https://github.com/angr/simuvex/pull/16.diff","patch_url":"https://github.com/angr/simuvex/pull/16.patch"},"body":"Mostly reformatting, the only added content is the definition of IMark (did I get it right?).\r\n\r\nAlso, PEP8 recommends 2 white lines before class definitions. If we would rather keep the formatting as it is I can modify my code style config so that it stops complaining about it."},"comment":{"url":"https://api.github.com/repos/angr/simuvex/issues/comments/203191853","html_url":"https://github.com/angr/simuvex/pull/16#issuecomment-203191853","issue_url":"https://api.github.com/repos/angr/simuvex/issues/16","id":203191853,"user":{"login":"zardus","id":3453847,"avatar_url":"https://avatars.githubusercontent.com/u/3453847?v=3","gravatar_id":"","url":"https://api.github.com/users/zardus","html_url":"https://github.com/zardus","followers_url":"https://api.github.com/users/zardus/followers","following_url":"https://api.github.com/users/zardus/following{/other_user}","gists_url":"https://api.github.com/users/zardus/gists{/gist_id}","starred_url":"https://api.github.com/users/zardus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zardus/subscriptions","organizations_url":"https://api.github.com/users/zardus/orgs","repos_url":"https://api.github.com/users/zardus/repos","events_url":"https://api.github.com/users/zardus/events{/privacy}","received_events_url":"https://api.github.com/users/zardus/received_events","type":"User","site_admin":false},"created_at":"2016-03-30T02:06:15Z","updated_at":"2016-03-30T02:06:15Z","body":"Regarding the lines before the class definition, what style checker are you using? We use pylint (which I guess isn't really just a style checker), with the configuration in `angr-dev` (https://github.com/angr/angr-dev/blob/master/pylintrc). In theory, that file should produce a clean lint on all the repos. In practice, some people don't use it and end up pushing code that doesn't lint :-(\r\n\r\nI'm personally pretty happy with that pylintrc, but I'm open to slowly changing to be more pep8-like in some ways (like the line skip before classes) if it makes life easier for people. We also have a dream of one day cleaning up the linting errors and making linting part of the CI to maintain future code quality."}}