{"action":"closed","number":9456,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/9456","id":92279782,"html_url":"https://github.com/nodejs/node/pull/9456","diff_url":"https://github.com/nodejs/node/pull/9456.diff","patch_url":"https://github.com/nodejs/node/pull/9456.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/9456","number":9456,"state":"closed","locked":false,"title":"Implementation of --adjacent-node-modules to support module symlinking to global cache","user":{"login":"phestermcs","id":4985028,"avatar_url":"https://avatars.githubusercontent.com/u/4985028?v=3","gravatar_id":"","url":"https://api.github.com/users/phestermcs","html_url":"https://github.com/phestermcs","followers_url":"https://api.github.com/users/phestermcs/followers","following_url":"https://api.github.com/users/phestermcs/following{/other_user}","gists_url":"https://api.github.com/users/phestermcs/gists{/gist_id}","starred_url":"https://api.github.com/users/phestermcs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phestermcs/subscriptions","organizations_url":"https://api.github.com/users/phestermcs/orgs","repos_url":"https://api.github.com/users/phestermcs/repos","events_url":"https://api.github.com/users/phestermcs/events{/privacy}","received_events_url":"https://api.github.com/users/phestermcs/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j8 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [ ] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\nModules\r\n\r\n##### Description of change\r\nBranched from v7.0.0 tag.\r\n\r\nUsing --adjacent-node-modules cmdline arg, or setting NODE_ADJACENT_NODE_MODULES, adds additional search paths for resolving prefix-less requires (i.e. require('somelib') ).\r\n\r\nDetails provided in this [issue](https://github.com/yarnpkg/rfcs/issues/18)\r\n\r\nIt's expected this PR will be rejected for now, but there were some who wanted to take a peak first.\r\n\r\n##### Test results\r\n[----------] Global test environment tear-down\r\n[==========] 26 tests from 2 test cases ran. (233 ms total)\r\n[  PASSED  ] 26 tests.\r\nrunning 'python tools\\test.py --mode=release  addons doctool known_issues message parallel sequential -J'\r\n=== release test-http-chunk-problem ===\r\nPath: parallel/test-http-chunk-problem\r\nCommand: C:\\src\\node\\Release\\node.exe C:\\src\\node\\test\\parallel\\test-http-chunk-problem.js\r\n--- TIMEOUT ---\r\n=== release test-process-kill-null ===\r\nPath: parallel/test-process-kill-null\r\nCommand: C:\\src\\node\\Release\\node.exe C:\\src\\node\\test\\parallel\\test-process-kill-null.js\r\n--- TIMEOUT ---\r\n[03:37|% 100|+ 1257|-   2]: Done\r\nrunning jslint\r\n\r\nC:\\src\\node>","created_at":"2016-11-04T03:42:49Z","updated_at":"2016-11-21T04:27:59Z","closed_at":"2016-11-21T04:27:59Z","merged_at":null,"merge_commit_sha":"82df55481aa701c90bb458541452905562304278","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/9456/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/9456/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/9456/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/9ce5e4c432c5a0077982625b4a49142baf279562","head":{"label":"phestermcs:adj-nm","ref":"adj-nm","sha":"9ce5e4c432c5a0077982625b4a49142baf279562","user":{"login":"phestermcs","id":4985028,"avatar_url":"https://avatars.githubusercontent.com/u/4985028?v=3","gravatar_id":"","url":"https://api.github.com/users/phestermcs","html_url":"https://github.com/phestermcs","followers_url":"https://api.github.com/users/phestermcs/followers","following_url":"https://api.github.com/users/phestermcs/following{/other_user}","gists_url":"https://api.github.com/users/phestermcs/gists{/gist_id}","starred_url":"https://api.github.com/users/phestermcs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phestermcs/subscriptions","organizations_url":"https://api.github.com/users/phestermcs/orgs","repos_url":"https://api.github.com/users/phestermcs/repos","events_url":"https://api.github.com/users/phestermcs/events{/privacy}","received_events_url":"https://api.github.com/users/phestermcs/received_events","type":"User","site_admin":false},"repo":{"id":70953024,"name":"node","full_name":"phestermcs/node","owner":{"login":"phestermcs","id":4985028,"avatar_url":"https://avatars.githubusercontent.com/u/4985028?v=3","gravatar_id":"","url":"https://api.github.com/users/phestermcs","html_url":"https://github.com/phestermcs","followers_url":"https://api.github.com/users/phestermcs/followers","following_url":"https://api.github.com/users/phestermcs/following{/other_user}","gists_url":"https://api.github.com/users/phestermcs/gists{/gist_id}","starred_url":"https://api.github.com/users/phestermcs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phestermcs/subscriptions","organizations_url":"https://api.github.com/users/phestermcs/orgs","repos_url":"https://api.github.com/users/phestermcs/repos","events_url":"https://api.github.com/users/phestermcs/events{/privacy}","received_events_url":"https://api.github.com/users/phestermcs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phestermcs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/phestermcs/node","forks_url":"https://api.github.com/repos/phestermcs/node/forks","keys_url":"https://api.github.com/repos/phestermcs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phestermcs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phestermcs/node/teams","hooks_url":"https://api.github.com/repos/phestermcs/node/hooks","issue_events_url":"https://api.github.com/repos/phestermcs/node/issues/events{/number}","events_url":"https://api.github.com/repos/phestermcs/node/events","assignees_url":"https://api.github.com/repos/phestermcs/node/assignees{/user}","branches_url":"https://api.github.com/repos/phestermcs/node/branches{/branch}","tags_url":"https://api.github.com/repos/phestermcs/node/tags","blobs_url":"https://api.github.com/repos/phestermcs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phestermcs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phestermcs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/phestermcs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phestermcs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/phestermcs/node/languages","stargazers_url":"https://api.github.com/repos/phestermcs/node/stargazers","contributors_url":"https://api.github.com/repos/phestermcs/node/contributors","subscribers_url":"https://api.github.com/repos/phestermcs/node/subscribers","subscription_url":"https://api.github.com/repos/phestermcs/node/subscription","commits_url":"https://api.github.com/repos/phestermcs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/phestermcs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/phestermcs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/phestermcs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/phestermcs/node/contents/{+path}","compare_url":"https://api.github.com/repos/phestermcs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phestermcs/node/merges","archive_url":"https://api.github.com/repos/phestermcs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phestermcs/node/downloads","issues_url":"https://api.github.com/repos/phestermcs/node/issues{/number}","pulls_url":"https://api.github.com/repos/phestermcs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/phestermcs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/phestermcs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phestermcs/node/labels{/name}","releases_url":"https://api.github.com/repos/phestermcs/node/releases{/id}","deployments_url":"https://api.github.com/repos/phestermcs/node/deployments","created_at":"2016-10-14T23:02:13Z","updated_at":"2016-11-12T19:39:33Z","pushed_at":"2016-11-05T15:46:54Z","git_url":"git://github.com/phestermcs/node.git","ssh_url":"git@github.com:phestermcs/node.git","clone_url":"https://github.com/phestermcs/node.git","svn_url":"https://github.com/phestermcs/node","homepage":"https://nodejs.org","size":242929,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:v7.x","ref":"v7.x","sha":"27e1749dcb669e432d3630545926e2db1b356f3c","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-11-21T03:42:16Z","pushed_at":"2016-11-21T02:31:12Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":365597,"stargazers_count":29059,"watchers_count":29059,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5000,"mirror_url":null,"open_issues_count":931,"forks":5000,"open_issues":931,"watchers":29059,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/9456"},"html":{"href":"https://github.com/nodejs/node/pull/9456"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/9456"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/9456/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/9456/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/9456/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/9ce5e4c432c5a0077982625b4a49142baf279562"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":7,"review_comments":1,"commits":5,"additions":53,"deletions":8,"changed_files":4}}
{"actor":{"display_login":"phestermcs"}}