{"action":"created","issue":{"url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/769","repository_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React","labels_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/769/labels{/name}","comments_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/769/comments","events_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/769/events","html_url":"https://github.com/Semantic-Org/Semantic-UI-React/pull/769","id":186102292,"number":769,"title":"Add controlled modal example to docs","user":{"login":"lewisblackwood","id":10392867,"avatar_url":"https://avatars.githubusercontent.com/u/10392867?v=3","gravatar_id":"","url":"https://api.github.com/users/lewisblackwood","html_url":"https://github.com/lewisblackwood","followers_url":"https://api.github.com/users/lewisblackwood/followers","following_url":"https://api.github.com/users/lewisblackwood/following{/other_user}","gists_url":"https://api.github.com/users/lewisblackwood/gists{/gist_id}","starred_url":"https://api.github.com/users/lewisblackwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lewisblackwood/subscriptions","organizations_url":"https://api.github.com/users/lewisblackwood/orgs","repos_url":"https://api.github.com/users/lewisblackwood/repos","events_url":"https://api.github.com/users/lewisblackwood/events{/privacy}","received_events_url":"https://api.github.com/users/lewisblackwood/received_events","type":"User","site_admin":false},"labels":[{"id":453542456,"url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/labels/needs%20author%20feedback","name":"needs author feedback","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-10-29T21:34:47Z","updated_at":"2016-11-03T14:33:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/pulls/769","html_url":"https://github.com/Semantic-Org/Semantic-UI-React/pull/769","diff_url":"https://github.com/Semantic-Org/Semantic-UI-React/pull/769.diff","patch_url":"https://github.com/Semantic-Org/Semantic-UI-React/pull/769.patch"},"body":"An example of a controlled modal component utilising the open prop. See issue https://github.com/Semantic-Org/Semantic-UI-React/issues/690.\n\n@levithomason could you advise on how to include `open` in the prop table at the top of the document?\n"},"comment":{"url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/comments/258159237","html_url":"https://github.com/Semantic-Org/Semantic-UI-React/pull/769#issuecomment-258159237","issue_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/769","id":258159237,"user":{"login":"lewisblackwood","id":10392867,"avatar_url":"https://avatars.githubusercontent.com/u/10392867?v=3","gravatar_id":"","url":"https://api.github.com/users/lewisblackwood","html_url":"https://github.com/lewisblackwood","followers_url":"https://api.github.com/users/lewisblackwood/followers","following_url":"https://api.github.com/users/lewisblackwood/following{/other_user}","gists_url":"https://api.github.com/users/lewisblackwood/gists{/gist_id}","starred_url":"https://api.github.com/users/lewisblackwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lewisblackwood/subscriptions","organizations_url":"https://api.github.com/users/lewisblackwood/orgs","repos_url":"https://api.github.com/users/lewisblackwood/repos","events_url":"https://api.github.com/users/lewisblackwood/events{/privacy}","received_events_url":"https://api.github.com/users/lewisblackwood/received_events","type":"User","site_admin":false},"created_at":"2016-11-03T14:33:29Z","updated_at":"2016-11-03T14:33:29Z","body":"Thanks for the clarification @levithomason!\r\n\r\nThe controlled component now works 👍 \r\n\r\nWhat's the best way to maintain the functionality in the uncontrolled components, where `open` isn't passed as a prop?\r\n\r\nI've been looking at the pattern of `activeIndex` in `Accordion`, but I'm not sure how to apply it to the modal. Should `Modal` now inherit from `AutoControlledComponent` and have `open` set as as `autoControlledProps`?\r\n\r\n"}}
{"actor":{"display_login":"lewisblackwood"}}