{"action":"created","issue":{"url":"https://api.github.com/repos/DynamoRIO/dynamorio/issues/2087","repository_url":"https://api.github.com/repos/DynamoRIO/dynamorio","labels_url":"https://api.github.com/repos/DynamoRIO/dynamorio/issues/2087/labels{/name}","comments_url":"https://api.github.com/repos/DynamoRIO/dynamorio/issues/2087/comments","events_url":"https://api.github.com/repos/DynamoRIO/dynamorio/issues/2087/events","html_url":"https://github.com/DynamoRIO/dynamorio/issues/2087","id":192850262,"number":2087,"title":"Problem with SHOW_RESULTS","user":{"login":"egrimley","id":12933337,"avatar_url":"https://avatars.githubusercontent.com/u/12933337?v=3","gravatar_id":"","url":"https://api.github.com/users/egrimley","html_url":"https://github.com/egrimley","followers_url":"https://api.github.com/users/egrimley/followers","following_url":"https://api.github.com/users/egrimley/following{/other_user}","gists_url":"https://api.github.com/users/egrimley/gists{/gist_id}","starred_url":"https://api.github.com/users/egrimley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egrimley/subscriptions","organizations_url":"https://api.github.com/users/egrimley/orgs","repos_url":"https://api.github.com/users/egrimley/repos","events_url":"https://api.github.com/users/egrimley/events{/privacy}","received_events_url":"https://api.github.com/users/egrimley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-01T13:44:05Z","updated_at":"2016-12-01T17:19:35Z","closed_at":null,"body":"With i#2083 and i#2084 fixed, there's still a bunch of failures on Debian arm64 Stretch, but only without DEBUG:\r\n\r\n```\r\nThe following tests FAILED:\r\n\t105 - code_api|sample.bbsize (Failed)\r\n\t107 - code_api|sample.memtrace_simple (Failed)\r\n\t108 - code_api|sample.instrace_simple (Failed)\r\n\t109 - code_api|sample.wrap (Failed)\r\n\t110 - code_api|sample.signal (Failed)\r\n\t111 - code_api|sample.syscall (Failed)\r\n\t112 - code_api|sample.inline (Failed)\r\n\t113 - code_api|sample.inscount (Failed)\r\n\t114 - code_api|sample.inscount.cleancall (Failed)\r\n\t115 - code_api|sample.inscount.prof-pcs.cleancall (Failed)\r\n\t116 - code_api|sample.stl_test (Failed)\r\n```\r\n\r\nThe problem can be fixed with this daft patch:\r\n\r\n```\r\n--- a/api/samples/CMakeLists.txt\r\n+++ b/api/samples/CMakeLists.txt\r\n@@ -86,12 +86,12 @@ else (BUILD_TESTS)\r\n   set(SHOW_RESULTS_DEFAULT ON)\r\n endif (BUILD_TESTS)\r\n \r\n-option(SHOW_RESULTS\r\n+option(SHOW_RESULTZ\r\n   \"Display client results in pop-up (Windows) or console message (Linux)\"\r\n   ${SHOW_RESULTS_DEFAULT})\r\n-if (SHOW_RESULTS)\r\n+if (SHOW_RESULTZ)\r\n   add_definitions(-DSHOW_RESULTS)\r\n-endif (SHOW_RESULTS)\r\n+endif (SHOW_RESULTZ)\r\n \r\n option(SHOW_SYMBOLS \"Use symbol lookup in clients that support it\" ON)\r\n if (SHOW_SYMBOLS)\r\n```\r\n\r\nSo it looks as though the name \"SHOW_RESULTS\" is somehow special, perhaps used by cmake itself or some other component. However, I can't discover how or why. Any ideas?"},"comment":{"url":"https://api.github.com/repos/DynamoRIO/dynamorio/issues/comments/264235228","html_url":"https://github.com/DynamoRIO/dynamorio/issues/2087#issuecomment-264235228","issue_url":"https://api.github.com/repos/DynamoRIO/dynamorio/issues/2087","id":264235228,"user":{"login":"derekbruening","id":6509618,"avatar_url":"https://avatars.githubusercontent.com/u/6509618?v=3","gravatar_id":"","url":"https://api.github.com/users/derekbruening","html_url":"https://github.com/derekbruening","followers_url":"https://api.github.com/users/derekbruening/followers","following_url":"https://api.github.com/users/derekbruening/following{/other_user}","gists_url":"https://api.github.com/users/derekbruening/gists{/gist_id}","starred_url":"https://api.github.com/users/derekbruening/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekbruening/subscriptions","organizations_url":"https://api.github.com/users/derekbruening/orgs","repos_url":"https://api.github.com/users/derekbruening/repos","events_url":"https://api.github.com/users/derekbruening/events{/privacy}","received_events_url":"https://api.github.com/users/derekbruening/received_events","type":"User","site_admin":false},"created_at":"2016-12-01T17:19:35Z","updated_at":"2016-12-01T17:19:35Z","body":"Are you sure this isn't just an artifact of enabling BUILD_TESTS in an already-configured build dir that didn't have it enabled before, or something like that?  I.e., does this really happen in a clean dir.  Also, please verify the actual test failure reasons."}}
{"actor":{"display_login":"derekbruening"}}