{"action":"created","comment":{"url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/pulls/comments/91298434","pull_request_review_id":11806095,"id":91298434,"diff_hunk":"@@ -110,4 +180,70 @@ describe('The dp-data-selection component', function () {\n         expect(dataSelectionApi.query).toHaveBeenCalledTimes(2);\n         expect(scope.vm.currentPage).toBe(3);\n     });\n+\n+    it('cannot show more than 100 pages', function () {\n+        const component = getComponent(mockedState);\n+        let scope = component.isolateScope();\n+\n+        // Change the state\n+        scope.vm.state.page = 101;\n+        $rootScope.$apply();\n+\n+        expect(scope.vm.currentPage).toBe(101);\n+    });","path":"modules/data-selection/components/data-selection/data-selection.component.test.js","position":171,"original_position":171,"commit_id":"f40cbd99daf0719ff9a829793eff62d8775458c1","original_commit_id":"81dc31386eb65388619733b0e2ad2bfceabb75aa","user":{"login":"ErikNijland","id":7983484,"avatar_url":"https://avatars.githubusercontent.com/u/7983484?v=3","gravatar_id":"","url":"https://api.github.com/users/ErikNijland","html_url":"https://github.com/ErikNijland","followers_url":"https://api.github.com/users/ErikNijland/followers","following_url":"https://api.github.com/users/ErikNijland/following{/other_user}","gists_url":"https://api.github.com/users/ErikNijland/gists{/gist_id}","starred_url":"https://api.github.com/users/ErikNijland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErikNijland/subscriptions","organizations_url":"https://api.github.com/users/ErikNijland/orgs","repos_url":"https://api.github.com/users/ErikNijland/repos","events_url":"https://api.github.com/users/ErikNijland/events{/privacy}","received_events_url":"https://api.github.com/users/ErikNijland/received_events","type":"User","site_admin":false},"body":"Ik snap het ook niet :). Heb de test verwijderd.","created_at":"2016-12-07T14:05:07Z","updated_at":"2016-12-07T14:05:07Z","html_url":"https://github.com/DatapuntAmsterdam/atlas/pull/326#discussion_r91298434","pull_request_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/pulls/326","_links":{"self":{"href":"https://api.github.com/repos/DatapuntAmsterdam/atlas/pulls/comments/91298434"},"html":{"href":"https://github.com/DatapuntAmsterdam/atlas/pull/326#discussion_r91298434"},"pull_request":{"href":"https://api.github.com/repos/DatapuntAmsterdam/atlas/pulls/326"}}},"pull_request":{"url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/pulls/326","id":96746076,"html_url":"https://github.com/DatapuntAmsterdam/atlas/pull/326","diff_url":"https://github.com/DatapuntAmsterdam/atlas/pull/326.diff","patch_url":"https://github.com/DatapuntAmsterdam/atlas/pull/326.patch","issue_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/issues/326","number":326,"state":"open","locked":false,"title":"[tg-2203] puntenwolk","user":{"login":"ErikNijland","id":7983484,"avatar_url":"https://avatars.githubusercontent.com/u/7983484?v=3","gravatar_id":"","url":"https://api.github.com/users/ErikNijland","html_url":"https://github.com/ErikNijland","followers_url":"https://api.github.com/users/ErikNijland/followers","following_url":"https://api.github.com/users/ErikNijland/following{/other_user}","gists_url":"https://api.github.com/users/ErikNijland/gists{/gist_id}","starred_url":"https://api.github.com/users/ErikNijland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErikNijland/subscriptions","organizations_url":"https://api.github.com/users/ErikNijland/orgs","repos_url":"https://api.github.com/users/ErikNijland/repos","events_url":"https://api.github.com/users/ErikNijland/events{/privacy}","received_events_url":"https://api.github.com/users/ErikNijland/received_events","type":"User","site_admin":false},"body":"- In de state zit een nieuwe variabele dataSelection.markers. Een Array met [lat, lon] waardes.\r\n- Het oude SHOW_DATA_SELECTION is gesplitst in twee actions FETCH_ & SHOW_ varianten. Bij de SHOW_ variant worden 'onder bepaalde voorwaarden' de markers aan de state toegevoegd. Dit volgt het patroon van FETCH_ en SHOW_ zoals bij detail en straatbeeld.\r\n- De map.controller maakt nu onderscheid tussen twee type markers: markers.regular (de oude) en markers.clustered (de nieuwe).\r\n- Via map.directive worden er 2 nieuwe highlight.factory functies aangroepen .addCluster en .removeCluster.\r\n\r\nNog niet gedaan:\r\n- [tg-2226] Opmaak: Nico is er nog mee bezig\r\n- [tg-2136] Loading indicator in de kaart tonen bij lijstweergave\r\n- [tg-2202] Verwijzigingen naar lijstweergave terugzetten. Pas doen als alles af is en het 'live live' mag.","created_at":"2016-12-06T15:33:38Z","updated_at":"2016-12-07T14:05:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"617f58d0a9391f8353d3766b7b8510525cd4aa15","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/pulls/326/commits","review_comments_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/pulls/326/comments","review_comment_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/issues/326/comments","statuses_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/statuses/f40cbd99daf0719ff9a829793eff62d8775458c1","head":{"label":"DatapuntAmsterdam:feature/tg-2203-puntenwolk","ref":"feature/tg-2203-puntenwolk","sha":"f40cbd99daf0719ff9a829793eff62d8775458c1","user":{"login":"DatapuntAmsterdam","id":15195167,"avatar_url":"https://avatars.githubusercontent.com/u/15195167?v=3","gravatar_id":"","url":"https://api.github.com/users/DatapuntAmsterdam","html_url":"https://github.com/DatapuntAmsterdam","followers_url":"https://api.github.com/users/DatapuntAmsterdam/followers","following_url":"https://api.github.com/users/DatapuntAmsterdam/following{/other_user}","gists_url":"https://api.github.com/users/DatapuntAmsterdam/gists{/gist_id}","starred_url":"https://api.github.com/users/DatapuntAmsterdam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DatapuntAmsterdam/subscriptions","organizations_url":"https://api.github.com/users/DatapuntAmsterdam/orgs","repos_url":"https://api.github.com/users/DatapuntAmsterdam/repos","events_url":"https://api.github.com/users/DatapuntAmsterdam/events{/privacy}","received_events_url":"https://api.github.com/users/DatapuntAmsterdam/received_events","type":"Organization","site_admin":false},"repo":{"id":60016458,"name":"atlas","full_name":"DatapuntAmsterdam/atlas","owner":{"login":"DatapuntAmsterdam","id":15195167,"avatar_url":"https://avatars.githubusercontent.com/u/15195167?v=3","gravatar_id":"","url":"https://api.github.com/users/DatapuntAmsterdam","html_url":"https://github.com/DatapuntAmsterdam","followers_url":"https://api.github.com/users/DatapuntAmsterdam/followers","following_url":"https://api.github.com/users/DatapuntAmsterdam/following{/other_user}","gists_url":"https://api.github.com/users/DatapuntAmsterdam/gists{/gist_id}","starred_url":"https://api.github.com/users/DatapuntAmsterdam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DatapuntAmsterdam/subscriptions","organizations_url":"https://api.github.com/users/DatapuntAmsterdam/orgs","repos_url":"https://api.github.com/users/DatapuntAmsterdam/repos","events_url":"https://api.github.com/users/DatapuntAmsterdam/events{/privacy}","received_events_url":"https://api.github.com/users/DatapuntAmsterdam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DatapuntAmsterdam/atlas","description":null,"fork":false,"url":"https://api.github.com/repos/DatapuntAmsterdam/atlas","forks_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/forks","keys_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/teams","hooks_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/hooks","issue_events_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/issues/events{/number}","events_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/events","assignees_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/assignees{/user}","branches_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/branches{/branch}","tags_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/tags","blobs_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/git/refs{/sha}","trees_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/statuses/{sha}","languages_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/languages","stargazers_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/stargazers","contributors_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/contributors","subscribers_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/subscribers","subscription_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/subscription","commits_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/commits{/sha}","git_commits_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/git/commits{/sha}","comments_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/comments{/number}","issue_comment_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/issues/comments{/number}","contents_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/contents/{+path}","compare_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/merges","archive_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/downloads","issues_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/issues{/number}","pulls_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/pulls{/number}","milestones_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/milestones{/number}","notifications_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/labels{/name}","releases_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/releases{/id}","deployments_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/deployments","created_at":"2016-05-30T14:31:42Z","updated_at":"2016-10-25T06:17:20Z","pushed_at":"2016-12-07T13:24:42Z","git_url":"git://github.com/DatapuntAmsterdam/atlas.git","ssh_url":"git@github.com:DatapuntAmsterdam/atlas.git","clone_url":"https://github.com/DatapuntAmsterdam/atlas.git","svn_url":"https://github.com/DatapuntAmsterdam/atlas","homepage":"","size":9174,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":6,"forks":3,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"DatapuntAmsterdam:master","ref":"master","sha":"d39c46b6bc25dc873813381ba2a08ba733837e6e","user":{"login":"DatapuntAmsterdam","id":15195167,"avatar_url":"https://avatars.githubusercontent.com/u/15195167?v=3","gravatar_id":"","url":"https://api.github.com/users/DatapuntAmsterdam","html_url":"https://github.com/DatapuntAmsterdam","followers_url":"https://api.github.com/users/DatapuntAmsterdam/followers","following_url":"https://api.github.com/users/DatapuntAmsterdam/following{/other_user}","gists_url":"https://api.github.com/users/DatapuntAmsterdam/gists{/gist_id}","starred_url":"https://api.github.com/users/DatapuntAmsterdam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DatapuntAmsterdam/subscriptions","organizations_url":"https://api.github.com/users/DatapuntAmsterdam/orgs","repos_url":"https://api.github.com/users/DatapuntAmsterdam/repos","events_url":"https://api.github.com/users/DatapuntAmsterdam/events{/privacy}","received_events_url":"https://api.github.com/users/DatapuntAmsterdam/received_events","type":"Organization","site_admin":false},"repo":{"id":60016458,"name":"atlas","full_name":"DatapuntAmsterdam/atlas","owner":{"login":"DatapuntAmsterdam","id":15195167,"avatar_url":"https://avatars.githubusercontent.com/u/15195167?v=3","gravatar_id":"","url":"https://api.github.com/users/DatapuntAmsterdam","html_url":"https://github.com/DatapuntAmsterdam","followers_url":"https://api.github.com/users/DatapuntAmsterdam/followers","following_url":"https://api.github.com/users/DatapuntAmsterdam/following{/other_user}","gists_url":"https://api.github.com/users/DatapuntAmsterdam/gists{/gist_id}","starred_url":"https://api.github.com/users/DatapuntAmsterdam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DatapuntAmsterdam/subscriptions","organizations_url":"https://api.github.com/users/DatapuntAmsterdam/orgs","repos_url":"https://api.github.com/users/DatapuntAmsterdam/repos","events_url":"https://api.github.com/users/DatapuntAmsterdam/events{/privacy}","received_events_url":"https://api.github.com/users/DatapuntAmsterdam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DatapuntAmsterdam/atlas","description":null,"fork":false,"url":"https://api.github.com/repos/DatapuntAmsterdam/atlas","forks_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/forks","keys_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/teams","hooks_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/hooks","issue_events_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/issues/events{/number}","events_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/events","assignees_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/assignees{/user}","branches_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/branches{/branch}","tags_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/tags","blobs_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/git/refs{/sha}","trees_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/statuses/{sha}","languages_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/languages","stargazers_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/stargazers","contributors_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/contributors","subscribers_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/subscribers","subscription_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/subscription","commits_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/commits{/sha}","git_commits_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/git/commits{/sha}","comments_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/comments{/number}","issue_comment_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/issues/comments{/number}","contents_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/contents/{+path}","compare_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/merges","archive_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/downloads","issues_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/issues{/number}","pulls_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/pulls{/number}","milestones_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/milestones{/number}","notifications_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/labels{/name}","releases_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/releases{/id}","deployments_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/deployments","created_at":"2016-05-30T14:31:42Z","updated_at":"2016-10-25T06:17:20Z","pushed_at":"2016-12-07T13:24:42Z","git_url":"git://github.com/DatapuntAmsterdam/atlas.git","ssh_url":"git@github.com:DatapuntAmsterdam/atlas.git","clone_url":"https://github.com/DatapuntAmsterdam/atlas.git","svn_url":"https://github.com/DatapuntAmsterdam/atlas","homepage":"","size":9174,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":6,"forks":3,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DatapuntAmsterdam/atlas/pulls/326"},"html":{"href":"https://github.com/DatapuntAmsterdam/atlas/pull/326"},"issue":{"href":"https://api.github.com/repos/DatapuntAmsterdam/atlas/issues/326"},"comments":{"href":"https://api.github.com/repos/DatapuntAmsterdam/atlas/issues/326/comments"},"review_comments":{"href":"https://api.github.com/repos/DatapuntAmsterdam/atlas/pulls/326/comments"},"review_comment":{"href":"https://api.github.com/repos/DatapuntAmsterdam/atlas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DatapuntAmsterdam/atlas/pulls/326/commits"},"statuses":{"href":"https://api.github.com/repos/DatapuntAmsterdam/atlas/statuses/f40cbd99daf0719ff9a829793eff62d8775458c1"}}}}
{"actor":{"display_login":"ErikNijland"}}