{"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/checkdomain/Comodo/pulls/3","id":95928893,"html_url":"https://github.com/checkdomain/Comodo/pull/3","diff_url":"https://github.com/checkdomain/Comodo/pull/3.diff","patch_url":"https://github.com/checkdomain/Comodo/pull/3.patch","issue_url":"https://api.github.com/repos/checkdomain/Comodo/issues/3","number":3,"state":"open","locked":false,"title":"Clean up unit tests","user":{"login":"klaude","id":45157,"avatar_url":"https://avatars.githubusercontent.com/u/45157?v=3","gravatar_id":"","url":"https://api.github.com/users/klaude","html_url":"https://github.com/klaude","followers_url":"https://api.github.com/users/klaude/followers","following_url":"https://api.github.com/users/klaude/following{/other_user}","gists_url":"https://api.github.com/users/klaude/gists{/gist_id}","starred_url":"https://api.github.com/users/klaude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klaude/subscriptions","organizations_url":"https://api.github.com/users/klaude/orgs","repos_url":"https://api.github.com/users/klaude/repos","events_url":"https://api.github.com/users/klaude/events{/privacy}","received_events_url":"https://api.github.com/users/klaude/received_events","type":"User","site_admin":false},"body":"Greetings,\r\n\r\nI've been evaluating this library to use at work. The first thing I did was to clone it and run PHPUnit to see how it acted. The test run presented a number of warnings due to use of the deprecated `getMock()` method in tests. I fixed up the test suite and then gave it a quick run through for PHPUnit best practices and PSR-2 compliance. The first commit in this branch fixes the test run, but the other two re pretty opinionated and can be dropped from the branch if y'all like. Let me know what you think!","created_at":"2016-11-30T16:46:12Z","updated_at":"2016-11-30T16:46:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/checkdomain/Comodo/pulls/3/commits","review_comments_url":"https://api.github.com/repos/checkdomain/Comodo/pulls/3/comments","review_comment_url":"https://api.github.com/repos/checkdomain/Comodo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/checkdomain/Comodo/issues/3/comments","statuses_url":"https://api.github.com/repos/checkdomain/Comodo/statuses/a02849664c5d3c1d46bb4b61444ea8acf97c1d8e","head":{"label":"klaude:clean-up-unit-tests","ref":"clean-up-unit-tests","sha":"a02849664c5d3c1d46bb4b61444ea8acf97c1d8e","user":{"login":"klaude","id":45157,"avatar_url":"https://avatars.githubusercontent.com/u/45157?v=3","gravatar_id":"","url":"https://api.github.com/users/klaude","html_url":"https://github.com/klaude","followers_url":"https://api.github.com/users/klaude/followers","following_url":"https://api.github.com/users/klaude/following{/other_user}","gists_url":"https://api.github.com/users/klaude/gists{/gist_id}","starred_url":"https://api.github.com/users/klaude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klaude/subscriptions","organizations_url":"https://api.github.com/users/klaude/orgs","repos_url":"https://api.github.com/users/klaude/repos","events_url":"https://api.github.com/users/klaude/events{/privacy}","received_events_url":"https://api.github.com/users/klaude/received_events","type":"User","site_admin":false},"repo":{"id":75121726,"name":"Comodo","full_name":"klaude/Comodo","owner":{"login":"klaude","id":45157,"avatar_url":"https://avatars.githubusercontent.com/u/45157?v=3","gravatar_id":"","url":"https://api.github.com/users/klaude","html_url":"https://github.com/klaude","followers_url":"https://api.github.com/users/klaude/followers","following_url":"https://api.github.com/users/klaude/following{/other_user}","gists_url":"https://api.github.com/users/klaude/gists{/gist_id}","starred_url":"https://api.github.com/users/klaude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klaude/subscriptions","organizations_url":"https://api.github.com/users/klaude/orgs","repos_url":"https://api.github.com/users/klaude/repos","events_url":"https://api.github.com/users/klaude/events{/privacy}","received_events_url":"https://api.github.com/users/klaude/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/klaude/Comodo","description":"Comodo API Wrapper","fork":true,"url":"https://api.github.com/repos/klaude/Comodo","forks_url":"https://api.github.com/repos/klaude/Comodo/forks","keys_url":"https://api.github.com/repos/klaude/Comodo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/klaude/Comodo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/klaude/Comodo/teams","hooks_url":"https://api.github.com/repos/klaude/Comodo/hooks","issue_events_url":"https://api.github.com/repos/klaude/Comodo/issues/events{/number}","events_url":"https://api.github.com/repos/klaude/Comodo/events","assignees_url":"https://api.github.com/repos/klaude/Comodo/assignees{/user}","branches_url":"https://api.github.com/repos/klaude/Comodo/branches{/branch}","tags_url":"https://api.github.com/repos/klaude/Comodo/tags","blobs_url":"https://api.github.com/repos/klaude/Comodo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/klaude/Comodo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/klaude/Comodo/git/refs{/sha}","trees_url":"https://api.github.com/repos/klaude/Comodo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/klaude/Comodo/statuses/{sha}","languages_url":"https://api.github.com/repos/klaude/Comodo/languages","stargazers_url":"https://api.github.com/repos/klaude/Comodo/stargazers","contributors_url":"https://api.github.com/repos/klaude/Comodo/contributors","subscribers_url":"https://api.github.com/repos/klaude/Comodo/subscribers","subscription_url":"https://api.github.com/repos/klaude/Comodo/subscription","commits_url":"https://api.github.com/repos/klaude/Comodo/commits{/sha}","git_commits_url":"https://api.github.com/repos/klaude/Comodo/git/commits{/sha}","comments_url":"https://api.github.com/repos/klaude/Comodo/comments{/number}","issue_comment_url":"https://api.github.com/repos/klaude/Comodo/issues/comments{/number}","contents_url":"https://api.github.com/repos/klaude/Comodo/contents/{+path}","compare_url":"https://api.github.com/repos/klaude/Comodo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/klaude/Comodo/merges","archive_url":"https://api.github.com/repos/klaude/Comodo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/klaude/Comodo/downloads","issues_url":"https://api.github.com/repos/klaude/Comodo/issues{/number}","pulls_url":"https://api.github.com/repos/klaude/Comodo/pulls{/number}","milestones_url":"https://api.github.com/repos/klaude/Comodo/milestones{/number}","notifications_url":"https://api.github.com/repos/klaude/Comodo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/klaude/Comodo/labels{/name}","releases_url":"https://api.github.com/repos/klaude/Comodo/releases{/id}","deployments_url":"https://api.github.com/repos/klaude/Comodo/deployments","created_at":"2016-11-29T21:02:22Z","updated_at":"2016-11-29T21:02:23Z","pushed_at":"2016-11-30T16:40:10Z","git_url":"git://github.com/klaude/Comodo.git","ssh_url":"git@github.com:klaude/Comodo.git","clone_url":"https://github.com/klaude/Comodo.git","svn_url":"https://github.com/klaude/Comodo","homepage":null,"size":95,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"checkdomain:master","ref":"master","sha":"3767a42016a7a31512aad75061d9fab1bbc2c927","user":{"login":"checkdomain","id":2493963,"avatar_url":"https://avatars.githubusercontent.com/u/2493963?v=3","gravatar_id":"","url":"https://api.github.com/users/checkdomain","html_url":"https://github.com/checkdomain","followers_url":"https://api.github.com/users/checkdomain/followers","following_url":"https://api.github.com/users/checkdomain/following{/other_user}","gists_url":"https://api.github.com/users/checkdomain/gists{/gist_id}","starred_url":"https://api.github.com/users/checkdomain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/checkdomain/subscriptions","organizations_url":"https://api.github.com/users/checkdomain/orgs","repos_url":"https://api.github.com/users/checkdomain/repos","events_url":"https://api.github.com/users/checkdomain/events{/privacy}","received_events_url":"https://api.github.com/users/checkdomain/received_events","type":"Organization","site_admin":false},"repo":{"id":18761528,"name":"Comodo","full_name":"checkdomain/Comodo","owner":{"login":"checkdomain","id":2493963,"avatar_url":"https://avatars.githubusercontent.com/u/2493963?v=3","gravatar_id":"","url":"https://api.github.com/users/checkdomain","html_url":"https://github.com/checkdomain","followers_url":"https://api.github.com/users/checkdomain/followers","following_url":"https://api.github.com/users/checkdomain/following{/other_user}","gists_url":"https://api.github.com/users/checkdomain/gists{/gist_id}","starred_url":"https://api.github.com/users/checkdomain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/checkdomain/subscriptions","organizations_url":"https://api.github.com/users/checkdomain/orgs","repos_url":"https://api.github.com/users/checkdomain/repos","events_url":"https://api.github.com/users/checkdomain/events{/privacy}","received_events_url":"https://api.github.com/users/checkdomain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/checkdomain/Comodo","description":"Comodo API Wrapper","fork":false,"url":"https://api.github.com/repos/checkdomain/Comodo","forks_url":"https://api.github.com/repos/checkdomain/Comodo/forks","keys_url":"https://api.github.com/repos/checkdomain/Comodo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/checkdomain/Comodo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/checkdomain/Comodo/teams","hooks_url":"https://api.github.com/repos/checkdomain/Comodo/hooks","issue_events_url":"https://api.github.com/repos/checkdomain/Comodo/issues/events{/number}","events_url":"https://api.github.com/repos/checkdomain/Comodo/events","assignees_url":"https://api.github.com/repos/checkdomain/Comodo/assignees{/user}","branches_url":"https://api.github.com/repos/checkdomain/Comodo/branches{/branch}","tags_url":"https://api.github.com/repos/checkdomain/Comodo/tags","blobs_url":"https://api.github.com/repos/checkdomain/Comodo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/checkdomain/Comodo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/checkdomain/Comodo/git/refs{/sha}","trees_url":"https://api.github.com/repos/checkdomain/Comodo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/checkdomain/Comodo/statuses/{sha}","languages_url":"https://api.github.com/repos/checkdomain/Comodo/languages","stargazers_url":"https://api.github.com/repos/checkdomain/Comodo/stargazers","contributors_url":"https://api.github.com/repos/checkdomain/Comodo/contributors","subscribers_url":"https://api.github.com/repos/checkdomain/Comodo/subscribers","subscription_url":"https://api.github.com/repos/checkdomain/Comodo/subscription","commits_url":"https://api.github.com/repos/checkdomain/Comodo/commits{/sha}","git_commits_url":"https://api.github.com/repos/checkdomain/Comodo/git/commits{/sha}","comments_url":"https://api.github.com/repos/checkdomain/Comodo/comments{/number}","issue_comment_url":"https://api.github.com/repos/checkdomain/Comodo/issues/comments{/number}","contents_url":"https://api.github.com/repos/checkdomain/Comodo/contents/{+path}","compare_url":"https://api.github.com/repos/checkdomain/Comodo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/checkdomain/Comodo/merges","archive_url":"https://api.github.com/repos/checkdomain/Comodo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/checkdomain/Comodo/downloads","issues_url":"https://api.github.com/repos/checkdomain/Comodo/issues{/number}","pulls_url":"https://api.github.com/repos/checkdomain/Comodo/pulls{/number}","milestones_url":"https://api.github.com/repos/checkdomain/Comodo/milestones{/number}","notifications_url":"https://api.github.com/repos/checkdomain/Comodo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/checkdomain/Comodo/labels{/name}","releases_url":"https://api.github.com/repos/checkdomain/Comodo/releases{/id}","deployments_url":"https://api.github.com/repos/checkdomain/Comodo/deployments","created_at":"2014-04-14T13:29:55Z","updated_at":"2016-11-28T14:10:11Z","pushed_at":"2016-08-22T12:52:09Z","git_url":"git://github.com/checkdomain/Comodo.git","ssh_url":"git@github.com:checkdomain/Comodo.git","clone_url":"https://github.com/checkdomain/Comodo.git","svn_url":"https://github.com/checkdomain/Comodo","homepage":null,"size":95,"stargazers_count":4,"watchers_count":4,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/checkdomain/Comodo/pulls/3"},"html":{"href":"https://github.com/checkdomain/Comodo/pull/3"},"issue":{"href":"https://api.github.com/repos/checkdomain/Comodo/issues/3"},"comments":{"href":"https://api.github.com/repos/checkdomain/Comodo/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/checkdomain/Comodo/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/checkdomain/Comodo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/checkdomain/Comodo/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/checkdomain/Comodo/statuses/a02849664c5d3c1d46bb4b61444ea8acf97c1d8e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":317,"deletions":323,"changed_files":4}}
{"actor":{"display_login":"klaude"}}