{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/63994025","id":63994025,"diff_hunk":"@@ -37,6 +38,14 @@ private[sql] object Column {\n   def apply(expr: Expression): Column = new Column(expr)\n \n   def unapply(col: Column): Option[Expression] = Some(col.expr)\n+\n+  private[sql] def generateAlias(e: Expression, index: Int): String = {\n+    e match {\n+      case a: AggregateExpression if a.aggregateFunction.isInstanceOf[TypedAggregateExpression] =>\n+        s\"${a.aggregateFunction.prettyName}_c${index}\"","path":"sql/core/src/main/scala/org/apache/spark/sql/Column.scala","position":16,"original_position":16,"commit_id":"689c51311d31765c715edc94e4ac28e798c761c5","original_commit_id":"689c51311d31765c715edc94e4ac28e798c761c5","user":{"login":"dilipbiswal","id":14225158,"avatar_url":"https://avatars.githubusercontent.com/u/14225158?v=3","gravatar_id":"","url":"https://api.github.com/users/dilipbiswal","html_url":"https://github.com/dilipbiswal","followers_url":"https://api.github.com/users/dilipbiswal/followers","following_url":"https://api.github.com/users/dilipbiswal/following{/other_user}","gists_url":"https://api.github.com/users/dilipbiswal/gists{/gist_id}","starred_url":"https://api.github.com/users/dilipbiswal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilipbiswal/subscriptions","organizations_url":"https://api.github.com/users/dilipbiswal/orgs","repos_url":"https://api.github.com/users/dilipbiswal/repos","events_url":"https://api.github.com/users/dilipbiswal/events{/privacy}","received_events_url":"https://api.github.com/users/dilipbiswal/received_events","type":"User","site_admin":false},"body":"@cloud-fan Looks like following. Lets go with this ? I will drop the index parameter.\r\n\r\n```SQL\r\n+-------------------+-------------------+\r\n|TypedSumDouble(int)|TypedSumDouble(int)|\r\n+-------------------+-------------------+\r\n|               11.0|               11.0|\r\n+-------------------+-------------------+\r\n```","created_at":"2016-05-20T05:54:24Z","updated_at":"2016-05-20T05:54:24Z","html_url":"https://github.com/apache/spark/pull/13045#discussion_r63994025","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/13045","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/63994025"},"html":{"href":"https://github.com/apache/spark/pull/13045#discussion_r63994025"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/13045"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/13045","id":69619450,"html_url":"https://github.com/apache/spark/pull/13045","diff_url":"https://github.com/apache/spark/pull/13045.diff","patch_url":"https://github.com/apache/spark/pull/13045.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/13045","number":13045,"state":"open","locked":false,"title":"[SPARK-15114][SQL] Column name generated by typed aggregate is super verbose","user":{"login":"dilipbiswal","id":14225158,"avatar_url":"https://avatars.githubusercontent.com/u/14225158?v=3","gravatar_id":"","url":"https://api.github.com/users/dilipbiswal","html_url":"https://github.com/dilipbiswal","followers_url":"https://api.github.com/users/dilipbiswal/followers","following_url":"https://api.github.com/users/dilipbiswal/following{/other_user}","gists_url":"https://api.github.com/users/dilipbiswal/gists{/gist_id}","starred_url":"https://api.github.com/users/dilipbiswal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilipbiswal/subscriptions","organizations_url":"https://api.github.com/users/dilipbiswal/orgs","repos_url":"https://api.github.com/users/dilipbiswal/repos","events_url":"https://api.github.com/users/dilipbiswal/events{/privacy}","received_events_url":"https://api.github.com/users/dilipbiswal/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nGenerate a shorter default alias for `AggregateExpression `, In this PR, aggregate function name along with a index is used for generating the alias name.\r\n\r\n```SQL\r\nval ds = Seq(1, 3, 2, 5).toDS()\r\nds.select(typed.sum((i: Int) => i), typed.avg((i: Int) => i)).show()\r\n```\r\n\r\nOutput before change.\r\n```SQL\r\n+-----------------------------------------------------------------------------------------------------------------------------+---------------------------------------------------------------------------------------------------------------------------------------------+\r\n|typedsumdouble(unresolveddeserializer(upcast(input[0, int], IntegerType, - root class: \"scala.Int\"), value#1), upcast(value))|typedaverage(unresolveddeserializer(upcast(input[0, int], IntegerType, - root class: \"scala.Int\"), value#1), newInstance(class scala.Tuple2))|\r\n+-----------------------------------------------------------------------------------------------------------------------------+---------------------------------------------------------------------------------------------------------------------------------------------+\r\n|                                                                                                                         11.0|                                                                                                                                         2.75|\r\n+-----------------------------------------------------------------------------------------------------------------------------+---------------------------------------------------------------------------------------------------------------------------------------------+\r\n```\r\nOutput after change:\r\n```SQL\r\n+-----------------+---------------+\r\n|typedsumdouble_c1|typedaverage_c2|\r\n+-----------------+---------------+\r\n|             11.0|           2.75|\r\n+-----------------+---------------+\r\n```\r\n\r\nNote: There is one test in ParquetSuites.scala which shows that that the system picked alias\r\nname is not usable and is rejected.  [test](https://github.com/apache/spark/blob/master/sql/hive/src/test/scala/org/apache/spark/sql/hive/parquetSuites.scala#L672-#L687)\r\n## How was this patch tested?\r\n\r\nA new test was added in DataSetAggregatorSuite. \r\n","created_at":"2016-05-11T06:09:27Z","updated_at":"2016-05-20T05:54:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e3427c9752c3b13ded4acd29d08cd954489d28b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/13045/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/13045/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/13045/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/689c51311d31765c715edc94e4ac28e798c761c5","head":{"label":"dilipbiswal:spark-15114","ref":"spark-15114","sha":"689c51311d31765c715edc94e4ac28e798c761c5","user":{"login":"dilipbiswal","id":14225158,"avatar_url":"https://avatars.githubusercontent.com/u/14225158?v=3","gravatar_id":"","url":"https://api.github.com/users/dilipbiswal","html_url":"https://github.com/dilipbiswal","followers_url":"https://api.github.com/users/dilipbiswal/followers","following_url":"https://api.github.com/users/dilipbiswal/following{/other_user}","gists_url":"https://api.github.com/users/dilipbiswal/gists{/gist_id}","starred_url":"https://api.github.com/users/dilipbiswal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilipbiswal/subscriptions","organizations_url":"https://api.github.com/users/dilipbiswal/orgs","repos_url":"https://api.github.com/users/dilipbiswal/repos","events_url":"https://api.github.com/users/dilipbiswal/events{/privacy}","received_events_url":"https://api.github.com/users/dilipbiswal/received_events","type":"User","site_admin":false},"repo":{"id":42921897,"name":"spark","full_name":"dilipbiswal/spark","owner":{"login":"dilipbiswal","id":14225158,"avatar_url":"https://avatars.githubusercontent.com/u/14225158?v=3","gravatar_id":"","url":"https://api.github.com/users/dilipbiswal","html_url":"https://github.com/dilipbiswal","followers_url":"https://api.github.com/users/dilipbiswal/followers","following_url":"https://api.github.com/users/dilipbiswal/following{/other_user}","gists_url":"https://api.github.com/users/dilipbiswal/gists{/gist_id}","starred_url":"https://api.github.com/users/dilipbiswal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilipbiswal/subscriptions","organizations_url":"https://api.github.com/users/dilipbiswal/orgs","repos_url":"https://api.github.com/users/dilipbiswal/repos","events_url":"https://api.github.com/users/dilipbiswal/events{/privacy}","received_events_url":"https://api.github.com/users/dilipbiswal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dilipbiswal/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/dilipbiswal/spark","forks_url":"https://api.github.com/repos/dilipbiswal/spark/forks","keys_url":"https://api.github.com/repos/dilipbiswal/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dilipbiswal/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dilipbiswal/spark/teams","hooks_url":"https://api.github.com/repos/dilipbiswal/spark/hooks","issue_events_url":"https://api.github.com/repos/dilipbiswal/spark/issues/events{/number}","events_url":"https://api.github.com/repos/dilipbiswal/spark/events","assignees_url":"https://api.github.com/repos/dilipbiswal/spark/assignees{/user}","branches_url":"https://api.github.com/repos/dilipbiswal/spark/branches{/branch}","tags_url":"https://api.github.com/repos/dilipbiswal/spark/tags","blobs_url":"https://api.github.com/repos/dilipbiswal/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dilipbiswal/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dilipbiswal/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/dilipbiswal/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dilipbiswal/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/dilipbiswal/spark/languages","stargazers_url":"https://api.github.com/repos/dilipbiswal/spark/stargazers","contributors_url":"https://api.github.com/repos/dilipbiswal/spark/contributors","subscribers_url":"https://api.github.com/repos/dilipbiswal/spark/subscribers","subscription_url":"https://api.github.com/repos/dilipbiswal/spark/subscription","commits_url":"https://api.github.com/repos/dilipbiswal/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/dilipbiswal/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/dilipbiswal/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/dilipbiswal/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/dilipbiswal/spark/contents/{+path}","compare_url":"https://api.github.com/repos/dilipbiswal/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dilipbiswal/spark/merges","archive_url":"https://api.github.com/repos/dilipbiswal/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dilipbiswal/spark/downloads","issues_url":"https://api.github.com/repos/dilipbiswal/spark/issues{/number}","pulls_url":"https://api.github.com/repos/dilipbiswal/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/dilipbiswal/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/dilipbiswal/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dilipbiswal/spark/labels{/name}","releases_url":"https://api.github.com/repos/dilipbiswal/spark/releases{/id}","deployments_url":"https://api.github.com/repos/dilipbiswal/spark/deployments","created_at":"2015-09-22T08:39:46Z","updated_at":"2016-04-06T08:56:13Z","pushed_at":"2016-05-19T19:49:40Z","git_url":"git://github.com/dilipbiswal/spark.git","ssh_url":"git@github.com:dilipbiswal/spark.git","clone_url":"https://github.com/dilipbiswal/spark.git","svn_url":"https://github.com/dilipbiswal/spark","homepage":null,"size":176646,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"bb1362eb3b36b553dca246b95f59ba7fd8adcc8a","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-05-20T03:41:46Z","pushed_at":"2016-05-20T05:49:44Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":494445,"stargazers_count":8587,"watchers_count":8587,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7969,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":419,"forks":7969,"open_issues":419,"watchers":8587,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/13045"},"html":{"href":"https://github.com/apache/spark/pull/13045"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/13045"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/13045/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/13045/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/13045/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/689c51311d31765c715edc94e4ac28e798c761c5"}}}}
{"actor":{"display_login":"dilipbiswal"}}