{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/10776","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/10776/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/10776/comments","events_url":"https://api.github.com/repos/servo/servo/issues/10776/events","html_url":"https://github.com/servo/servo/pull/10776","id":149990880,"number":10776,"title":"Implement GetVertexAttrib","user":{"login":"dzbarsky","id":1565842,"avatar_url":"https://avatars.githubusercontent.com/u/1565842?v=3","gravatar_id":"","url":"https://api.github.com/users/dzbarsky","html_url":"https://github.com/dzbarsky","followers_url":"https://api.github.com/users/dzbarsky/followers","following_url":"https://api.github.com/users/dzbarsky/following{/other_user}","gists_url":"https://api.github.com/users/dzbarsky/gists{/gist_id}","starred_url":"https://api.github.com/users/dzbarsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzbarsky/subscriptions","organizations_url":"https://api.github.com/users/dzbarsky/orgs","repos_url":"https://api.github.com/users/dzbarsky/repos","events_url":"https://api.github.com/users/dzbarsky/events{/privacy}","received_events_url":"https://api.github.com/users/dzbarsky/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-answer","name":"S-awaiting-answer","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"nox","id":123095,"avatar_url":"https://avatars.githubusercontent.com/u/123095?v=3","gravatar_id":"","url":"https://api.github.com/users/nox","html_url":"https://github.com/nox","followers_url":"https://api.github.com/users/nox/followers","following_url":"https://api.github.com/users/nox/following{/other_user}","gists_url":"https://api.github.com/users/nox/gists{/gist_id}","starred_url":"https://api.github.com/users/nox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nox/subscriptions","organizations_url":"https://api.github.com/users/nox/orgs","repos_url":"https://api.github.com/users/nox/repos","events_url":"https://api.github.com/users/nox/events{/privacy}","received_events_url":"https://api.github.com/users/nox/received_events","type":"User","site_admin":false},"milestone":null,"comments":9,"created_at":"2016-04-21T07:29:19Z","updated_at":"2016-04-29T05:08:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/10776","html_url":"https://github.com/servo/servo/pull/10776","diff_url":"https://github.com/servo/servo/pull/10776.diff","patch_url":"https://github.com/servo/servo/pull/10776.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/10776)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/215628094","html_url":"https://github.com/servo/servo/pull/10776#issuecomment-215628094","issue_url":"https://api.github.com/repos/servo/servo/issues/10776","id":215628094,"user":{"login":"dzbarsky","id":1565842,"avatar_url":"https://avatars.githubusercontent.com/u/1565842?v=3","gravatar_id":"","url":"https://api.github.com/users/dzbarsky","html_url":"https://github.com/dzbarsky","followers_url":"https://api.github.com/users/dzbarsky/followers","following_url":"https://api.github.com/users/dzbarsky/following{/other_user}","gists_url":"https://api.github.com/users/dzbarsky/gists{/gist_id}","starred_url":"https://api.github.com/users/dzbarsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzbarsky/subscriptions","organizations_url":"https://api.github.com/users/dzbarsky/orgs","repos_url":"https://api.github.com/users/dzbarsky/repos","events_url":"https://api.github.com/users/dzbarsky/events{/privacy}","received_events_url":"https://api.github.com/users/dzbarsky/received_events","type":"User","site_admin":false},"created_at":"2016-04-29T05:08:16Z","updated_at":"2016-04-29T05:08:16Z","body":"\n\n\n\nReview status: 0 of 7 files reviewed at latest revision, 4 unresolved discussions.\n\n---\n\n*[components/script/dom/webglrenderingcontext.rs, line 125 \\[r3\\]](https://reviewable.io:443/reviews/servo/servo/10776#-KFriKdq-KpixwrESAB6-r3-125:-KGVPbr3NIV9dI9eHsHf:-1202985255) ([raw file](https://github.com/servo/servo/blob/dbf8915f0fa0fdca739a27e7a4eea41558d00672/components/script/dom/webglrenderingcontext.rs#L125)):*\nare you suggesting we can use VERTEX_ATTRIB_ARRAY_BUFFER_BINDING to avoid storing the 0'th vertex attrib? if so this will go away...\n\n---\n\n*[components/script/dom/webglrenderingcontext.rs, line 1001 \\[r3\\]](https://reviewable.io:443/reviews/servo/servo/10776#-KGLpMwBe2Xswy7TyneN:-KGVPVOqAxYZvKs4LzBE:-1188923373) ([raw file](https://github.com/servo/servo/blob/dbf8915f0fa0fdca739a27e7a4eea41558d00672/components/script/dom/webglrenderingcontext.rs#L1001)):*\nsorry, what is VERTEX_ATTRIB_ARRAY_BUFFER_BINDING?\n\n---\n\n*[components/script/dom/webglrenderingcontext.rs, line 1018 \\[r3\\]](https://reviewable.io:443/reviews/servo/servo/10776#-KGLpjvviHM66z95pYl-:-KGVP3UbITfoUwDVZ420:-233470090) ([raw file](https://github.com/servo/servo/blob/dbf8915f0fa0fdca739a27e7a4eea41558d00672/components/script/dom/webglrenderingcontext.rs#L1018)):*\nWe do this all over the place, let's fix in a followup?\n\n---\n\n*[tests/wpt/metadata/webgl/conformance-1.0.3/conformance/attribs/gl-vertex-attrib.html.ini, line 3 \\[r3\\]](https://reviewable.io:443/reviews/servo/servo/10776#-KGLqN9qfcYFR9RMfpz3:-KGVOg2NlPhKFN51FGAC:843353120) ([raw file](https://github.com/servo/servo/blob/dbf8915f0fa0fdca739a27e7a4eea41558d00672/tests/wpt/metadata/webgl/conformance-1.0.3/conformance/attribs/gl-vertex-attrib.html.ini#L3)):*\nYeah, it seems like the VertexAttrib vector methods are all busted and don't actually set things correctly - I debugged a little and it looks like going from JSObject to slice returns None but I haven't had time to figure out why yet\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/servo/servo/10776)*\n<!-- Sent from Reviewable.io -->\n"}}