{"action":"created","comment":{"url":"https://api.github.com/repos/lhorie/mithril.js/pulls/comments/58293810","id":58293810,"diff_hunk":"@@ -1706,16 +1706,16 @@\n \t\tvar currentTarget = e.currentTarget || e.srcElement\n \t\tvar args\n \n+\t\twhile (currentTarget && !/^a$/i.test(currentTarget.nodeName)) {","path":"mithril.js","position":4,"original_position":4,"commit_id":"1f8a0aeea5fb5e3e59bf8c707a2b6365df7e7e0e","original_commit_id":"1f8a0aeea5fb5e3e59bf8c707a2b6365df7e7e0e","user":{"login":"adriengibrat","id":62407,"avatar_url":"https://avatars.githubusercontent.com/u/62407?v=3","gravatar_id":"","url":"https://api.github.com/users/adriengibrat","html_url":"https://github.com/adriengibrat","followers_url":"https://api.github.com/users/adriengibrat/followers","following_url":"https://api.github.com/users/adriengibrat/following{/other_user}","gists_url":"https://api.github.com/users/adriengibrat/gists{/gist_id}","starred_url":"https://api.github.com/users/adriengibrat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriengibrat/subscriptions","organizations_url":"https://api.github.com/users/adriengibrat/orgs","repos_url":"https://api.github.com/users/adriengibrat/repos","events_url":"https://api.github.com/users/adriengibrat/events{/privacy}","received_events_url":"https://api.github.com/users/adriengibrat/received_events","type":"User","site_admin":false},"body":"yep, even `currentTarget.nodeName.toLowerCase() != 'a'`\r\n\r\nI wonder if simply looking for the first parent with `currentTarget.href` wouldn't be more solid...","created_at":"2016-04-02T14:05:57Z","updated_at":"2016-04-02T14:05:57Z","html_url":"https://github.com/lhorie/mithril.js/pull/1009#discussion_r58293810","pull_request_url":"https://api.github.com/repos/lhorie/mithril.js/pulls/1009","_links":{"self":{"href":"https://api.github.com/repos/lhorie/mithril.js/pulls/comments/58293810"},"html":{"href":"https://github.com/lhorie/mithril.js/pull/1009#discussion_r58293810"},"pull_request":{"href":"https://api.github.com/repos/lhorie/mithril.js/pulls/1009"}}},"pull_request":{"url":"https://api.github.com/repos/lhorie/mithril.js/pulls/1009","id":65036652,"html_url":"https://github.com/lhorie/mithril.js/pull/1009","diff_url":"https://github.com/lhorie/mithril.js/pull/1009.diff","patch_url":"https://github.com/lhorie/mithril.js/pull/1009.patch","issue_url":"https://api.github.com/repos/lhorie/mithril.js/issues/1009","number":1009,"state":"open","locked":false,"title":"fix finding current target parent link in routeUnobtrusive","user":{"login":"adriengibrat","id":62407,"avatar_url":"https://avatars.githubusercontent.com/u/62407?v=3","gravatar_id":"","url":"https://api.github.com/users/adriengibrat","html_url":"https://github.com/adriengibrat","followers_url":"https://api.github.com/users/adriengibrat/followers","following_url":"https://api.github.com/users/adriengibrat/following{/other_user}","gists_url":"https://api.github.com/users/adriengibrat/gists{/gist_id}","starred_url":"https://api.github.com/users/adriengibrat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriengibrat/subscriptions","organizations_url":"https://api.github.com/users/adriengibrat/orgs","repos_url":"https://api.github.com/users/adriengibrat/repos","events_url":"https://api.github.com/users/adriengibrat/events{/privacy}","received_events_url":"https://api.github.com/users/adriengibrat/received_events","type":"User","site_admin":false},"body":"It seems the logic is to find parent link... what is done ine the commit:\r\n- move finding current target parent link before parsing query string\r\n- fix too loose regexp that was matching any node withe an 'a' in its name (table, area,acronym, etc.)","created_at":"2016-04-02T12:24:33Z","updated_at":"2016-04-02T14:05:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d689c56662d03a5404b15caa2c1e211b21c0d3bd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lhorie/mithril.js/pulls/1009/commits","review_comments_url":"https://api.github.com/repos/lhorie/mithril.js/pulls/1009/comments","review_comment_url":"https://api.github.com/repos/lhorie/mithril.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lhorie/mithril.js/issues/1009/comments","statuses_url":"https://api.github.com/repos/lhorie/mithril.js/statuses/1f8a0aeea5fb5e3e59bf8c707a2b6365df7e7e0e","head":{"label":"adriengibrat:fix_routeUnobtrusive","ref":"fix_routeUnobtrusive","sha":"1f8a0aeea5fb5e3e59bf8c707a2b6365df7e7e0e","user":{"login":"adriengibrat","id":62407,"avatar_url":"https://avatars.githubusercontent.com/u/62407?v=3","gravatar_id":"","url":"https://api.github.com/users/adriengibrat","html_url":"https://github.com/adriengibrat","followers_url":"https://api.github.com/users/adriengibrat/followers","following_url":"https://api.github.com/users/adriengibrat/following{/other_user}","gists_url":"https://api.github.com/users/adriengibrat/gists{/gist_id}","starred_url":"https://api.github.com/users/adriengibrat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriengibrat/subscriptions","organizations_url":"https://api.github.com/users/adriengibrat/orgs","repos_url":"https://api.github.com/users/adriengibrat/repos","events_url":"https://api.github.com/users/adriengibrat/events{/privacy}","received_events_url":"https://api.github.com/users/adriengibrat/received_events","type":"User","site_admin":false},"repo":{"id":54341533,"name":"mithril.js","full_name":"adriengibrat/mithril.js","owner":{"login":"adriengibrat","id":62407,"avatar_url":"https://avatars.githubusercontent.com/u/62407?v=3","gravatar_id":"","url":"https://api.github.com/users/adriengibrat","html_url":"https://github.com/adriengibrat","followers_url":"https://api.github.com/users/adriengibrat/followers","following_url":"https://api.github.com/users/adriengibrat/following{/other_user}","gists_url":"https://api.github.com/users/adriengibrat/gists{/gist_id}","starred_url":"https://api.github.com/users/adriengibrat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriengibrat/subscriptions","organizations_url":"https://api.github.com/users/adriengibrat/orgs","repos_url":"https://api.github.com/users/adriengibrat/repos","events_url":"https://api.github.com/users/adriengibrat/events{/privacy}","received_events_url":"https://api.github.com/users/adriengibrat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adriengibrat/mithril.js","description":"A Javascript Framework for Building Brilliant Applications (development repo)","fork":true,"url":"https://api.github.com/repos/adriengibrat/mithril.js","forks_url":"https://api.github.com/repos/adriengibrat/mithril.js/forks","keys_url":"https://api.github.com/repos/adriengibrat/mithril.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adriengibrat/mithril.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adriengibrat/mithril.js/teams","hooks_url":"https://api.github.com/repos/adriengibrat/mithril.js/hooks","issue_events_url":"https://api.github.com/repos/adriengibrat/mithril.js/issues/events{/number}","events_url":"https://api.github.com/repos/adriengibrat/mithril.js/events","assignees_url":"https://api.github.com/repos/adriengibrat/mithril.js/assignees{/user}","branches_url":"https://api.github.com/repos/adriengibrat/mithril.js/branches{/branch}","tags_url":"https://api.github.com/repos/adriengibrat/mithril.js/tags","blobs_url":"https://api.github.com/repos/adriengibrat/mithril.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adriengibrat/mithril.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adriengibrat/mithril.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/adriengibrat/mithril.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adriengibrat/mithril.js/statuses/{sha}","languages_url":"https://api.github.com/repos/adriengibrat/mithril.js/languages","stargazers_url":"https://api.github.com/repos/adriengibrat/mithril.js/stargazers","contributors_url":"https://api.github.com/repos/adriengibrat/mithril.js/contributors","subscribers_url":"https://api.github.com/repos/adriengibrat/mithril.js/subscribers","subscription_url":"https://api.github.com/repos/adriengibrat/mithril.js/subscription","commits_url":"https://api.github.com/repos/adriengibrat/mithril.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/adriengibrat/mithril.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/adriengibrat/mithril.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/adriengibrat/mithril.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/adriengibrat/mithril.js/contents/{+path}","compare_url":"https://api.github.com/repos/adriengibrat/mithril.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adriengibrat/mithril.js/merges","archive_url":"https://api.github.com/repos/adriengibrat/mithril.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adriengibrat/mithril.js/downloads","issues_url":"https://api.github.com/repos/adriengibrat/mithril.js/issues{/number}","pulls_url":"https://api.github.com/repos/adriengibrat/mithril.js/pulls{/number}","milestones_url":"https://api.github.com/repos/adriengibrat/mithril.js/milestones{/number}","notifications_url":"https://api.github.com/repos/adriengibrat/mithril.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adriengibrat/mithril.js/labels{/name}","releases_url":"https://api.github.com/repos/adriengibrat/mithril.js/releases{/id}","deployments_url":"https://api.github.com/repos/adriengibrat/mithril.js/deployments","created_at":"2016-03-20T21:28:51Z","updated_at":"2016-03-20T21:28:53Z","pushed_at":"2016-04-02T12:16:44Z","git_url":"git://github.com/adriengibrat/mithril.js.git","ssh_url":"git@github.com:adriengibrat/mithril.js.git","clone_url":"https://github.com/adriengibrat/mithril.js.git","svn_url":"https://github.com/adriengibrat/mithril.js","homepage":"http://mithril.js.org","size":4505,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"next"}},"base":{"label":"lhorie:next","ref":"next","sha":"4f34acc0327e3d9d20dc3d591112c6c36757da27","user":{"login":"lhorie","id":1637573,"avatar_url":"https://avatars.githubusercontent.com/u/1637573?v=3","gravatar_id":"","url":"https://api.github.com/users/lhorie","html_url":"https://github.com/lhorie","followers_url":"https://api.github.com/users/lhorie/followers","following_url":"https://api.github.com/users/lhorie/following{/other_user}","gists_url":"https://api.github.com/users/lhorie/gists{/gist_id}","starred_url":"https://api.github.com/users/lhorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhorie/subscriptions","organizations_url":"https://api.github.com/users/lhorie/orgs","repos_url":"https://api.github.com/users/lhorie/repos","events_url":"https://api.github.com/users/lhorie/events{/privacy}","received_events_url":"https://api.github.com/users/lhorie/received_events","type":"User","site_admin":false},"repo":{"id":17814354,"name":"mithril.js","full_name":"lhorie/mithril.js","owner":{"login":"lhorie","id":1637573,"avatar_url":"https://avatars.githubusercontent.com/u/1637573?v=3","gravatar_id":"","url":"https://api.github.com/users/lhorie","html_url":"https://github.com/lhorie","followers_url":"https://api.github.com/users/lhorie/followers","following_url":"https://api.github.com/users/lhorie/following{/other_user}","gists_url":"https://api.github.com/users/lhorie/gists{/gist_id}","starred_url":"https://api.github.com/users/lhorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhorie/subscriptions","organizations_url":"https://api.github.com/users/lhorie/orgs","repos_url":"https://api.github.com/users/lhorie/repos","events_url":"https://api.github.com/users/lhorie/events{/privacy}","received_events_url":"https://api.github.com/users/lhorie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lhorie/mithril.js","description":"A Javascript Framework for Building Brilliant Applications (development repo)","fork":false,"url":"https://api.github.com/repos/lhorie/mithril.js","forks_url":"https://api.github.com/repos/lhorie/mithril.js/forks","keys_url":"https://api.github.com/repos/lhorie/mithril.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lhorie/mithril.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lhorie/mithril.js/teams","hooks_url":"https://api.github.com/repos/lhorie/mithril.js/hooks","issue_events_url":"https://api.github.com/repos/lhorie/mithril.js/issues/events{/number}","events_url":"https://api.github.com/repos/lhorie/mithril.js/events","assignees_url":"https://api.github.com/repos/lhorie/mithril.js/assignees{/user}","branches_url":"https://api.github.com/repos/lhorie/mithril.js/branches{/branch}","tags_url":"https://api.github.com/repos/lhorie/mithril.js/tags","blobs_url":"https://api.github.com/repos/lhorie/mithril.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lhorie/mithril.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lhorie/mithril.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/lhorie/mithril.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lhorie/mithril.js/statuses/{sha}","languages_url":"https://api.github.com/repos/lhorie/mithril.js/languages","stargazers_url":"https://api.github.com/repos/lhorie/mithril.js/stargazers","contributors_url":"https://api.github.com/repos/lhorie/mithril.js/contributors","subscribers_url":"https://api.github.com/repos/lhorie/mithril.js/subscribers","subscription_url":"https://api.github.com/repos/lhorie/mithril.js/subscription","commits_url":"https://api.github.com/repos/lhorie/mithril.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/lhorie/mithril.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/lhorie/mithril.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/lhorie/mithril.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/lhorie/mithril.js/contents/{+path}","compare_url":"https://api.github.com/repos/lhorie/mithril.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lhorie/mithril.js/merges","archive_url":"https://api.github.com/repos/lhorie/mithril.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lhorie/mithril.js/downloads","issues_url":"https://api.github.com/repos/lhorie/mithril.js/issues{/number}","pulls_url":"https://api.github.com/repos/lhorie/mithril.js/pulls{/number}","milestones_url":"https://api.github.com/repos/lhorie/mithril.js/milestones{/number}","notifications_url":"https://api.github.com/repos/lhorie/mithril.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lhorie/mithril.js/labels{/name}","releases_url":"https://api.github.com/repos/lhorie/mithril.js/releases{/id}","deployments_url":"https://api.github.com/repos/lhorie/mithril.js/deployments","created_at":"2014-03-17T01:59:39Z","updated_at":"2016-04-02T01:34:42Z","pushed_at":"2016-04-02T12:24:33Z","git_url":"git://github.com/lhorie/mithril.js.git","ssh_url":"git@github.com:lhorie/mithril.js.git","clone_url":"https://github.com/lhorie/mithril.js.git","svn_url":"https://github.com/lhorie/mithril.js","homepage":"http://mithril.js.org","size":5572,"stargazers_count":5768,"watchers_count":5768,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":435,"mirror_url":null,"open_issues_count":93,"forks":435,"open_issues":93,"watchers":5768,"default_branch":"next"}},"_links":{"self":{"href":"https://api.github.com/repos/lhorie/mithril.js/pulls/1009"},"html":{"href":"https://github.com/lhorie/mithril.js/pull/1009"},"issue":{"href":"https://api.github.com/repos/lhorie/mithril.js/issues/1009"},"comments":{"href":"https://api.github.com/repos/lhorie/mithril.js/issues/1009/comments"},"review_comments":{"href":"https://api.github.com/repos/lhorie/mithril.js/pulls/1009/comments"},"review_comment":{"href":"https://api.github.com/repos/lhorie/mithril.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lhorie/mithril.js/pulls/1009/commits"},"statuses":{"href":"https://api.github.com/repos/lhorie/mithril.js/statuses/1f8a0aeea5fb5e3e59bf8c707a2b6365df7e7e0e"}}}}