{"action":"created","comment":{"url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/pulls/comments/63965693","id":63965693,"diff_hunk":"@@ -21,28 +28,39 @@ class LoginAndRegistrationTest < FlowTestCase\n     user_signup_page.email.set('valid@email.com')\n     user_signup_page.password.set('123456')\n     user_signup_page.password_confirmation.set('123456')\n-    images_index_page = user_signup_page.create_account!.as_a(PageObjects::Images::IndexPage)\n+    images_index_page = user_signup_page.create_account!\n     assert_equal 'Welcome to the Share Image App!', images_index_page.flash_message(:success)\n   end\n \n   test 'login and logout' do\n-    new_user = {\n-      name: 'newuser',\n-      email: 'valid@email.com',\n-      password: '123456',\n-      password_confirmation: '123456'\n-    }\n-    User.create!(new_user)\n     images_index_page = PageObjects::Images::IndexPage.visit\n     user_login_page = images_index_page.sign_up_or_log_in!\n+\n     fail_login = { email: 'invalid', password: ' ' }\n     user_login_page = user_login_page.log_in!(fail_login).as_a(PageObjects::LoginPage)\n     assert_equal 'Invalid password/username', user_login_page.flash_message(:danger)\n-    user_login_page.email.set(new_user[:email])\n-    user_login_page.password.set(new_user[:password])\n-    images_index_page = user_login_page.log_in!.as_a(PageObjects::Images::IndexPage)\n+\n+    images_index_page = user_login_page.log_in!(email: @user.email, password: @user.password)\n     assert_equal 'Welcome to the Share Image App!', images_index_page.flash_message(:success)\n-    log_out_index_page = images_index_page.log_out!.as_a(PageObjects::Images::IndexPage)\n+\n+    log_out_index_page = images_index_page.log_out!\n     assert_equal 'You successfully logged out', log_out_index_page.flash_message(:success)\n   end\n+\n+  test 'login from show page' do","path":"test/flow_tests/login_and_registration_test.rb","position":49,"original_position":49,"commit_id":"8d294ed2a9ca9695687eebffbfe8800eb6714c6a","original_commit_id":"8d294ed2a9ca9695687eebffbfe8800eb6714c6a","user":{"login":"rmacklin","id":1863540,"avatar_url":"https://avatars.githubusercontent.com/u/1863540?v=3","gravatar_id":"","url":"https://api.github.com/users/rmacklin","html_url":"https://github.com/rmacklin","followers_url":"https://api.github.com/users/rmacklin/followers","following_url":"https://api.github.com/users/rmacklin/following{/other_user}","gists_url":"https://api.github.com/users/rmacklin/gists{/gist_id}","starred_url":"https://api.github.com/users/rmacklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmacklin/subscriptions","organizations_url":"https://api.github.com/users/rmacklin/orgs","repos_url":"https://api.github.com/users/rmacklin/repos","events_url":"https://api.github.com/users/rmacklin/events{/privacy}","received_events_url":"https://api.github.com/users/rmacklin/received_events","type":"User","site_admin":false},"body":"What's the purpose of this test?","created_at":"2016-05-19T22:38:32Z","updated_at":"2016-05-19T22:38:32Z","html_url":"https://github.com/AppFolioOnboarding/image-sharer-wilsonyqm/pull/47#discussion_r63965693","pull_request_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/pulls/47","_links":{"self":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/pulls/comments/63965693"},"html":{"href":"https://github.com/AppFolioOnboarding/image-sharer-wilsonyqm/pull/47#discussion_r63965693"},"pull_request":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/pulls/47"}}},"pull_request":{"url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/pulls/47","id":70456217,"html_url":"https://github.com/AppFolioOnboarding/image-sharer-wilsonyqm/pull/47","diff_url":"https://github.com/AppFolioOnboarding/image-sharer-wilsonyqm/pull/47.diff","patch_url":"https://github.com/AppFolioOnboarding/image-sharer-wilsonyqm/pull/47.patch","issue_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/issues/47","number":47,"state":"open","locked":false,"title":"Authorization","user":{"login":"wilsonyqm","id":9424989,"avatar_url":"https://avatars.githubusercontent.com/u/9424989?v=3","gravatar_id":"","url":"https://api.github.com/users/wilsonyqm","html_url":"https://github.com/wilsonyqm","followers_url":"https://api.github.com/users/wilsonyqm/followers","following_url":"https://api.github.com/users/wilsonyqm/following{/other_user}","gists_url":"https://api.github.com/users/wilsonyqm/gists{/gist_id}","starred_url":"https://api.github.com/users/wilsonyqm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilsonyqm/subscriptions","organizations_url":"https://api.github.com/users/wilsonyqm/orgs","repos_url":"https://api.github.com/users/wilsonyqm/repos","events_url":"https://api.github.com/users/wilsonyqm/events{/privacy}","received_events_url":"https://api.github.com/users/wilsonyqm/received_events","type":"User","site_admin":false},"body":"Closes #14\r\n","created_at":"2016-05-18T01:18:41Z","updated_at":"2016-05-19T22:38:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c70e71082454072c353e435e8a90426fc47beee","assignee":{"login":"jyoder","id":1054998,"avatar_url":"https://avatars.githubusercontent.com/u/1054998?v=3","gravatar_id":"","url":"https://api.github.com/users/jyoder","html_url":"https://github.com/jyoder","followers_url":"https://api.github.com/users/jyoder/followers","following_url":"https://api.github.com/users/jyoder/following{/other_user}","gists_url":"https://api.github.com/users/jyoder/gists{/gist_id}","starred_url":"https://api.github.com/users/jyoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jyoder/subscriptions","organizations_url":"https://api.github.com/users/jyoder/orgs","repos_url":"https://api.github.com/users/jyoder/repos","events_url":"https://api.github.com/users/jyoder/events{/privacy}","received_events_url":"https://api.github.com/users/jyoder/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/pulls/47/commits","review_comments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/pulls/47/comments","review_comment_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/issues/47/comments","statuses_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/statuses/8d294ed2a9ca9695687eebffbfe8800eb6714c6a","head":{"label":"AppFolioOnboarding:authorization","ref":"authorization","sha":"8d294ed2a9ca9695687eebffbfe8800eb6714c6a","user":{"login":"AppFolioOnboarding","id":16782391,"avatar_url":"https://avatars.githubusercontent.com/u/16782391?v=3","gravatar_id":"","url":"https://api.github.com/users/AppFolioOnboarding","html_url":"https://github.com/AppFolioOnboarding","followers_url":"https://api.github.com/users/AppFolioOnboarding/followers","following_url":"https://api.github.com/users/AppFolioOnboarding/following{/other_user}","gists_url":"https://api.github.com/users/AppFolioOnboarding/gists{/gist_id}","starred_url":"https://api.github.com/users/AppFolioOnboarding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppFolioOnboarding/subscriptions","organizations_url":"https://api.github.com/users/AppFolioOnboarding/orgs","repos_url":"https://api.github.com/users/AppFolioOnboarding/repos","events_url":"https://api.github.com/users/AppFolioOnboarding/events{/privacy}","received_events_url":"https://api.github.com/users/AppFolioOnboarding/received_events","type":"Organization","site_admin":false},"repo":{"id":55442589,"name":"image-sharer-wilsonyqm","full_name":"AppFolioOnboarding/image-sharer-wilsonyqm","owner":{"login":"AppFolioOnboarding","id":16782391,"avatar_url":"https://avatars.githubusercontent.com/u/16782391?v=3","gravatar_id":"","url":"https://api.github.com/users/AppFolioOnboarding","html_url":"https://github.com/AppFolioOnboarding","followers_url":"https://api.github.com/users/AppFolioOnboarding/followers","following_url":"https://api.github.com/users/AppFolioOnboarding/following{/other_user}","gists_url":"https://api.github.com/users/AppFolioOnboarding/gists{/gist_id}","starred_url":"https://api.github.com/users/AppFolioOnboarding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppFolioOnboarding/subscriptions","organizations_url":"https://api.github.com/users/AppFolioOnboarding/orgs","repos_url":"https://api.github.com/users/AppFolioOnboarding/repos","events_url":"https://api.github.com/users/AppFolioOnboarding/events{/privacy}","received_events_url":"https://api.github.com/users/AppFolioOnboarding/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AppFolioOnboarding/image-sharer-wilsonyqm","description":"image-sharer-wilsonyqm created by Classroom for GitHub","fork":false,"url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm","forks_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/forks","keys_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/teams","hooks_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/hooks","issue_events_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/issues/events{/number}","events_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/events","assignees_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/assignees{/user}","branches_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/branches{/branch}","tags_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/tags","blobs_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/git/refs{/sha}","trees_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/statuses/{sha}","languages_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/languages","stargazers_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/stargazers","contributors_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/contributors","subscribers_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/subscribers","subscription_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/subscription","commits_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/commits{/sha}","git_commits_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/git/commits{/sha}","comments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/comments{/number}","issue_comment_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/issues/comments{/number}","contents_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/contents/{+path}","compare_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/merges","archive_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/downloads","issues_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/issues{/number}","pulls_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/pulls{/number}","milestones_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/milestones{/number}","notifications_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/labels{/name}","releases_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/releases{/id}","deployments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/deployments","created_at":"2016-04-04T20:29:58Z","updated_at":"2016-04-04T20:30:08Z","pushed_at":"2016-05-19T22:20:04Z","git_url":"git://github.com/AppFolioOnboarding/image-sharer-wilsonyqm.git","ssh_url":"git@github.com:AppFolioOnboarding/image-sharer-wilsonyqm.git","clone_url":"https://github.com/AppFolioOnboarding/image-sharer-wilsonyqm.git","svn_url":"https://github.com/AppFolioOnboarding/image-sharer-wilsonyqm","homepage":null,"size":158,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"AppFolioOnboarding:master","ref":"master","sha":"79bb3bd1741db0b0d9571ab8051e6a07085b1658","user":{"login":"AppFolioOnboarding","id":16782391,"avatar_url":"https://avatars.githubusercontent.com/u/16782391?v=3","gravatar_id":"","url":"https://api.github.com/users/AppFolioOnboarding","html_url":"https://github.com/AppFolioOnboarding","followers_url":"https://api.github.com/users/AppFolioOnboarding/followers","following_url":"https://api.github.com/users/AppFolioOnboarding/following{/other_user}","gists_url":"https://api.github.com/users/AppFolioOnboarding/gists{/gist_id}","starred_url":"https://api.github.com/users/AppFolioOnboarding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppFolioOnboarding/subscriptions","organizations_url":"https://api.github.com/users/AppFolioOnboarding/orgs","repos_url":"https://api.github.com/users/AppFolioOnboarding/repos","events_url":"https://api.github.com/users/AppFolioOnboarding/events{/privacy}","received_events_url":"https://api.github.com/users/AppFolioOnboarding/received_events","type":"Organization","site_admin":false},"repo":{"id":55442589,"name":"image-sharer-wilsonyqm","full_name":"AppFolioOnboarding/image-sharer-wilsonyqm","owner":{"login":"AppFolioOnboarding","id":16782391,"avatar_url":"https://avatars.githubusercontent.com/u/16782391?v=3","gravatar_id":"","url":"https://api.github.com/users/AppFolioOnboarding","html_url":"https://github.com/AppFolioOnboarding","followers_url":"https://api.github.com/users/AppFolioOnboarding/followers","following_url":"https://api.github.com/users/AppFolioOnboarding/following{/other_user}","gists_url":"https://api.github.com/users/AppFolioOnboarding/gists{/gist_id}","starred_url":"https://api.github.com/users/AppFolioOnboarding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppFolioOnboarding/subscriptions","organizations_url":"https://api.github.com/users/AppFolioOnboarding/orgs","repos_url":"https://api.github.com/users/AppFolioOnboarding/repos","events_url":"https://api.github.com/users/AppFolioOnboarding/events{/privacy}","received_events_url":"https://api.github.com/users/AppFolioOnboarding/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AppFolioOnboarding/image-sharer-wilsonyqm","description":"image-sharer-wilsonyqm created by Classroom for GitHub","fork":false,"url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm","forks_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/forks","keys_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/teams","hooks_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/hooks","issue_events_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/issues/events{/number}","events_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/events","assignees_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/assignees{/user}","branches_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/branches{/branch}","tags_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/tags","blobs_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/git/refs{/sha}","trees_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/statuses/{sha}","languages_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/languages","stargazers_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/stargazers","contributors_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/contributors","subscribers_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/subscribers","subscription_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/subscription","commits_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/commits{/sha}","git_commits_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/git/commits{/sha}","comments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/comments{/number}","issue_comment_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/issues/comments{/number}","contents_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/contents/{+path}","compare_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/merges","archive_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/downloads","issues_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/issues{/number}","pulls_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/pulls{/number}","milestones_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/milestones{/number}","notifications_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/labels{/name}","releases_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/releases{/id}","deployments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/deployments","created_at":"2016-04-04T20:29:58Z","updated_at":"2016-04-04T20:30:08Z","pushed_at":"2016-05-19T22:20:04Z","git_url":"git://github.com/AppFolioOnboarding/image-sharer-wilsonyqm.git","ssh_url":"git@github.com:AppFolioOnboarding/image-sharer-wilsonyqm.git","clone_url":"https://github.com/AppFolioOnboarding/image-sharer-wilsonyqm.git","svn_url":"https://github.com/AppFolioOnboarding/image-sharer-wilsonyqm","homepage":null,"size":158,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/pulls/47"},"html":{"href":"https://github.com/AppFolioOnboarding/image-sharer-wilsonyqm/pull/47"},"issue":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/issues/47"},"comments":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-wilsonyqm/statuses/8d294ed2a9ca9695687eebffbfe8800eb6714c6a"}}}}
{"actor":{"display_login":"rmacklin"}}