{"action":"created","comment":{"url":"https://api.github.com/repos/meanjs/mean/pulls/comments/55915787","id":55915787,"diff_hunk":"@@ -26,7 +26,7 @@\n     function compileDirective(template) {\n       // function to compile a fresh directive with the given template, or a default one\n       // input form with directive\n-      if (!template) template = '<input type=\"password\" id=\"newPassword\" name=\"newPassword\" class=\"form-control\" ng-model=\"passwordMock.newPassword\" placeholder=\"New Password\" autocomplete=\"new-password\" uib-popover=\"{{popoverMsg}}\" uib-popover-trigger=\"focus\" uib-popover-placement=\"top\" password-validator required>' +\n+      if (!template) template = '<input type=\"password\" id=\"newPassword\" name=\"newPassword\" class=\"form-control\" ng-model=\"passwordMock.newPassword\" placeholder=\"New Password\" autocomplete=\"new-password\" uib-popover=\"{{getPopoverMsg}}\" uib-popover-trigger=\"focus\" uib-popover-placement=\"top\" password-validator required>' +","path":"modules/users/tests/client/password-verify.client.directive.tests.js","position":5,"original_position":5,"commit_id":"173b702f6a0a0a4e0cfe782aedcab0201411a89b","original_commit_id":"173b702f6a0a0a4e0cfe782aedcab0201411a89b","user":{"login":"mleanos","id":5613734,"avatar_url":"https://avatars.githubusercontent.com/u/5613734?v=3","gravatar_id":"","url":"https://api.github.com/users/mleanos","html_url":"https://github.com/mleanos","followers_url":"https://api.github.com/users/mleanos/followers","following_url":"https://api.github.com/users/mleanos/following{/other_user}","gists_url":"https://api.github.com/users/mleanos/gists{/gist_id}","starred_url":"https://api.github.com/users/mleanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mleanos/subscriptions","organizations_url":"https://api.github.com/users/mleanos/orgs","repos_url":"https://api.github.com/users/mleanos/repos","events_url":"https://api.github.com/users/mleanos/events{/privacy}","received_events_url":"https://api.github.com/users/mleanos/received_events","type":"User","site_admin":false},"body":"I don't think `vm` is relevant here. We're only testing the directive, and there's no context for a *controller* here. IIRC, from working with these tests, I think this is the correct way to write isolated tests for directives.\r\n","created_at":"2016-03-12T04:16:57Z","updated_at":"2016-03-12T04:16:57Z","html_url":"https://github.com/meanjs/mean/pull/1208#discussion_r55915787","pull_request_url":"https://api.github.com/repos/meanjs/mean/pulls/1208","_links":{"self":{"href":"https://api.github.com/repos/meanjs/mean/pulls/comments/55915787"},"html":{"href":"https://github.com/meanjs/mean/pull/1208#discussion_r55915787"},"pull_request":{"href":"https://api.github.com/repos/meanjs/mean/pulls/1208"}}},"pull_request":{"url":"https://api.github.com/repos/meanjs/mean/pulls/1208","id":59122571,"html_url":"https://github.com/meanjs/mean/pull/1208","diff_url":"https://github.com/meanjs/mean/pull/1208.diff","patch_url":"https://github.com/meanjs/mean/pull/1208.patch","issue_url":"https://api.github.com/repos/meanjs/mean/issues/1208","number":1208,"state":"open","locked":false,"title":"feat(users): Modify users module to implement style guidelines.","user":{"login":"itelo","id":11433064,"avatar_url":"https://avatars.githubusercontent.com/u/11433064?v=3","gravatar_id":"","url":"https://api.github.com/users/itelo","html_url":"https://github.com/itelo","followers_url":"https://api.github.com/users/itelo/followers","following_url":"https://api.github.com/users/itelo/following{/other_user}","gists_url":"https://api.github.com/users/itelo/gists{/gist_id}","starred_url":"https://api.github.com/users/itelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itelo/subscriptions","organizations_url":"https://api.github.com/users/itelo/orgs","repos_url":"https://api.github.com/users/itelo/repos","events_url":"https://api.github.com/users/itelo/events{/privacy}","received_events_url":"https://api.github.com/users/itelo/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-12T01:37:54Z","updated_at":"2016-03-12T04:16:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e50ae44a01cb0e42ad0583c59dc1dc2cfec715f","assignee":{"login":"mleanos","id":5613734,"avatar_url":"https://avatars.githubusercontent.com/u/5613734?v=3","gravatar_id":"","url":"https://api.github.com/users/mleanos","html_url":"https://github.com/mleanos","followers_url":"https://api.github.com/users/mleanos/followers","following_url":"https://api.github.com/users/mleanos/following{/other_user}","gists_url":"https://api.github.com/users/mleanos/gists{/gist_id}","starred_url":"https://api.github.com/users/mleanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mleanos/subscriptions","organizations_url":"https://api.github.com/users/mleanos/orgs","repos_url":"https://api.github.com/users/mleanos/repos","events_url":"https://api.github.com/users/mleanos/events{/privacy}","received_events_url":"https://api.github.com/users/mleanos/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/meanjs/mean/milestones/6","html_url":"https://github.com/meanjs/mean/milestones/0.5.0","labels_url":"https://api.github.com/repos/meanjs/mean/milestones/6/labels","id":1213421,"number":6,"title":"0.5.0","description":"","creator":{"login":"ilanbiala","id":3695164,"avatar_url":"https://avatars.githubusercontent.com/u/3695164?v=3","gravatar_id":"","url":"https://api.github.com/users/ilanbiala","html_url":"https://github.com/ilanbiala","followers_url":"https://api.github.com/users/ilanbiala/followers","following_url":"https://api.github.com/users/ilanbiala/following{/other_user}","gists_url":"https://api.github.com/users/ilanbiala/gists{/gist_id}","starred_url":"https://api.github.com/users/ilanbiala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilanbiala/subscriptions","organizations_url":"https://api.github.com/users/ilanbiala/orgs","repos_url":"https://api.github.com/users/ilanbiala/repos","events_url":"https://api.github.com/users/ilanbiala/events{/privacy}","received_events_url":"https://api.github.com/users/ilanbiala/received_events","type":"User","site_admin":false},"open_issues":43,"closed_issues":115,"state":"open","created_at":"2015-07-17T18:54:42Z","updated_at":"2016-03-11T01:05:39Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/meanjs/mean/pulls/1208/commits","review_comments_url":"https://api.github.com/repos/meanjs/mean/pulls/1208/comments","review_comment_url":"https://api.github.com/repos/meanjs/mean/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meanjs/mean/issues/1208/comments","statuses_url":"https://api.github.com/repos/meanjs/mean/statuses/173b702f6a0a0a4e0cfe782aedcab0201411a89b","head":{"label":"itelo:users-styleguide","ref":"users-styleguide","sha":"173b702f6a0a0a4e0cfe782aedcab0201411a89b","user":{"login":"itelo","id":11433064,"avatar_url":"https://avatars.githubusercontent.com/u/11433064?v=3","gravatar_id":"","url":"https://api.github.com/users/itelo","html_url":"https://github.com/itelo","followers_url":"https://api.github.com/users/itelo/followers","following_url":"https://api.github.com/users/itelo/following{/other_user}","gists_url":"https://api.github.com/users/itelo/gists{/gist_id}","starred_url":"https://api.github.com/users/itelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itelo/subscriptions","organizations_url":"https://api.github.com/users/itelo/orgs","repos_url":"https://api.github.com/users/itelo/repos","events_url":"https://api.github.com/users/itelo/events{/privacy}","received_events_url":"https://api.github.com/users/itelo/received_events","type":"User","site_admin":false},"repo":{"id":51097734,"name":"mean","full_name":"itelo/mean","owner":{"login":"itelo","id":11433064,"avatar_url":"https://avatars.githubusercontent.com/u/11433064?v=3","gravatar_id":"","url":"https://api.github.com/users/itelo","html_url":"https://github.com/itelo","followers_url":"https://api.github.com/users/itelo/followers","following_url":"https://api.github.com/users/itelo/following{/other_user}","gists_url":"https://api.github.com/users/itelo/gists{/gist_id}","starred_url":"https://api.github.com/users/itelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itelo/subscriptions","organizations_url":"https://api.github.com/users/itelo/orgs","repos_url":"https://api.github.com/users/itelo/repos","events_url":"https://api.github.com/users/itelo/events{/privacy}","received_events_url":"https://api.github.com/users/itelo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/itelo/mean","description":"MEAN.JS - Full-Stack JavaScript Using MongoDB, Express, AngularJS, and Node.js - ","fork":true,"url":"https://api.github.com/repos/itelo/mean","forks_url":"https://api.github.com/repos/itelo/mean/forks","keys_url":"https://api.github.com/repos/itelo/mean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/itelo/mean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/itelo/mean/teams","hooks_url":"https://api.github.com/repos/itelo/mean/hooks","issue_events_url":"https://api.github.com/repos/itelo/mean/issues/events{/number}","events_url":"https://api.github.com/repos/itelo/mean/events","assignees_url":"https://api.github.com/repos/itelo/mean/assignees{/user}","branches_url":"https://api.github.com/repos/itelo/mean/branches{/branch}","tags_url":"https://api.github.com/repos/itelo/mean/tags","blobs_url":"https://api.github.com/repos/itelo/mean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/itelo/mean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/itelo/mean/git/refs{/sha}","trees_url":"https://api.github.com/repos/itelo/mean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/itelo/mean/statuses/{sha}","languages_url":"https://api.github.com/repos/itelo/mean/languages","stargazers_url":"https://api.github.com/repos/itelo/mean/stargazers","contributors_url":"https://api.github.com/repos/itelo/mean/contributors","subscribers_url":"https://api.github.com/repos/itelo/mean/subscribers","subscription_url":"https://api.github.com/repos/itelo/mean/subscription","commits_url":"https://api.github.com/repos/itelo/mean/commits{/sha}","git_commits_url":"https://api.github.com/repos/itelo/mean/git/commits{/sha}","comments_url":"https://api.github.com/repos/itelo/mean/comments{/number}","issue_comment_url":"https://api.github.com/repos/itelo/mean/issues/comments{/number}","contents_url":"https://api.github.com/repos/itelo/mean/contents/{+path}","compare_url":"https://api.github.com/repos/itelo/mean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/itelo/mean/merges","archive_url":"https://api.github.com/repos/itelo/mean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/itelo/mean/downloads","issues_url":"https://api.github.com/repos/itelo/mean/issues{/number}","pulls_url":"https://api.github.com/repos/itelo/mean/pulls{/number}","milestones_url":"https://api.github.com/repos/itelo/mean/milestones{/number}","notifications_url":"https://api.github.com/repos/itelo/mean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/itelo/mean/labels{/name}","releases_url":"https://api.github.com/repos/itelo/mean/releases{/id}","deployments_url":"https://api.github.com/repos/itelo/mean/deployments","created_at":"2016-02-04T18:56:47Z","updated_at":"2016-02-04T18:56:48Z","pushed_at":"2016-03-10T23:32:01Z","git_url":"git://github.com/itelo/mean.git","ssh_url":"git@github.com:itelo/mean.git","clone_url":"https://github.com/itelo/mean.git","svn_url":"https://github.com/itelo/mean","homepage":"http://meanjs.org","size":2630,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"meanjs:master","ref":"master","sha":"8f00edcd8270203fcc026bfc4e6796678ff1c4e2","user":{"login":"meanjs","id":6232122,"avatar_url":"https://avatars.githubusercontent.com/u/6232122?v=3","gravatar_id":"","url":"https://api.github.com/users/meanjs","html_url":"https://github.com/meanjs","followers_url":"https://api.github.com/users/meanjs/followers","following_url":"https://api.github.com/users/meanjs/following{/other_user}","gists_url":"https://api.github.com/users/meanjs/gists{/gist_id}","starred_url":"https://api.github.com/users/meanjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meanjs/subscriptions","organizations_url":"https://api.github.com/users/meanjs/orgs","repos_url":"https://api.github.com/users/meanjs/repos","events_url":"https://api.github.com/users/meanjs/events{/privacy}","received_events_url":"https://api.github.com/users/meanjs/received_events","type":"Organization","site_admin":false},"repo":{"id":15508537,"name":"mean","full_name":"meanjs/mean","owner":{"login":"meanjs","id":6232122,"avatar_url":"https://avatars.githubusercontent.com/u/6232122?v=3","gravatar_id":"","url":"https://api.github.com/users/meanjs","html_url":"https://github.com/meanjs","followers_url":"https://api.github.com/users/meanjs/followers","following_url":"https://api.github.com/users/meanjs/following{/other_user}","gists_url":"https://api.github.com/users/meanjs/gists{/gist_id}","starred_url":"https://api.github.com/users/meanjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meanjs/subscriptions","organizations_url":"https://api.github.com/users/meanjs/orgs","repos_url":"https://api.github.com/users/meanjs/repos","events_url":"https://api.github.com/users/meanjs/events{/privacy}","received_events_url":"https://api.github.com/users/meanjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meanjs/mean","description":"MEAN.JS - Full-Stack JavaScript Using MongoDB, Express, AngularJS, and Node.js - ","fork":false,"url":"https://api.github.com/repos/meanjs/mean","forks_url":"https://api.github.com/repos/meanjs/mean/forks","keys_url":"https://api.github.com/repos/meanjs/mean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meanjs/mean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meanjs/mean/teams","hooks_url":"https://api.github.com/repos/meanjs/mean/hooks","issue_events_url":"https://api.github.com/repos/meanjs/mean/issues/events{/number}","events_url":"https://api.github.com/repos/meanjs/mean/events","assignees_url":"https://api.github.com/repos/meanjs/mean/assignees{/user}","branches_url":"https://api.github.com/repos/meanjs/mean/branches{/branch}","tags_url":"https://api.github.com/repos/meanjs/mean/tags","blobs_url":"https://api.github.com/repos/meanjs/mean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meanjs/mean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meanjs/mean/git/refs{/sha}","trees_url":"https://api.github.com/repos/meanjs/mean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meanjs/mean/statuses/{sha}","languages_url":"https://api.github.com/repos/meanjs/mean/languages","stargazers_url":"https://api.github.com/repos/meanjs/mean/stargazers","contributors_url":"https://api.github.com/repos/meanjs/mean/contributors","subscribers_url":"https://api.github.com/repos/meanjs/mean/subscribers","subscription_url":"https://api.github.com/repos/meanjs/mean/subscription","commits_url":"https://api.github.com/repos/meanjs/mean/commits{/sha}","git_commits_url":"https://api.github.com/repos/meanjs/mean/git/commits{/sha}","comments_url":"https://api.github.com/repos/meanjs/mean/comments{/number}","issue_comment_url":"https://api.github.com/repos/meanjs/mean/issues/comments{/number}","contents_url":"https://api.github.com/repos/meanjs/mean/contents/{+path}","compare_url":"https://api.github.com/repos/meanjs/mean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meanjs/mean/merges","archive_url":"https://api.github.com/repos/meanjs/mean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meanjs/mean/downloads","issues_url":"https://api.github.com/repos/meanjs/mean/issues{/number}","pulls_url":"https://api.github.com/repos/meanjs/mean/pulls{/number}","milestones_url":"https://api.github.com/repos/meanjs/mean/milestones{/number}","notifications_url":"https://api.github.com/repos/meanjs/mean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meanjs/mean/labels{/name}","releases_url":"https://api.github.com/repos/meanjs/mean/releases{/id}","deployments_url":"https://api.github.com/repos/meanjs/mean/deployments","created_at":"2013-12-29T13:01:15Z","updated_at":"2016-03-12T00:32:29Z","pushed_at":"2016-03-11T01:05:39Z","git_url":"git://github.com/meanjs/mean.git","ssh_url":"git@github.com:meanjs/mean.git","clone_url":"https://github.com/meanjs/mean.git","svn_url":"https://github.com/meanjs/mean","homepage":"http://meanjs.org","size":5258,"stargazers_count":3183,"watchers_count":3183,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1214,"mirror_url":null,"open_issues_count":76,"forks":1214,"open_issues":76,"watchers":3183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/meanjs/mean/pulls/1208"},"html":{"href":"https://github.com/meanjs/mean/pull/1208"},"issue":{"href":"https://api.github.com/repos/meanjs/mean/issues/1208"},"comments":{"href":"https://api.github.com/repos/meanjs/mean/issues/1208/comments"},"review_comments":{"href":"https://api.github.com/repos/meanjs/mean/pulls/1208/comments"},"review_comment":{"href":"https://api.github.com/repos/meanjs/mean/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meanjs/mean/pulls/1208/commits"},"statuses":{"href":"https://api.github.com/repos/meanjs/mean/statuses/173b702f6a0a0a4e0cfe782aedcab0201411a89b"}}}}