{"action":"created","comment":{"url":"https://api.github.com/repos/atom/atom/pulls/comments/74073552","id":74073552,"diff_hunk":"@@ -21,57 +21,47 @@ You can use either:\n Whichever version you use, ensure that:\n \n  * The default installation folder is chosen so the build tools can find it\n- * If using Visual Studio make sure Visual C++ support is selected/installed\n- * If using Visual C++ Build Tools make sure Windows 8 SDK is selected/installed\n+ * Visual C++ support is selected/installed if using Visual Studio\n+ * Windows 8 SDK is selected/installed if using Visual C++ Build Tools\n  * A `git` command is in your path\n- * Set the `GYP_MSVS_VERSION` environment variable to the Visual Studio/Build Tools version (`2013` or `2015`) e.g. ``[Environment]::SetEnvironmentVariable(\"GYP_MSVS_VERSION\", \"2015\", \"User\")`` in PowerShell or set it in Windows advanced system settings control panel.\n+ * The `GYP_MSVS_VERSION` environment variable is set to the corresponding Visual Studio/Build Tools version (`2013` or `2015`)\n \n ## Instructions\n \n-You can run these commands using Command Prompt, PowerShell or Git Shell via [GitHub Desktop](https://desktop.github.com/). These instructions will assume the use of Bash from Git Shell - if you are using Command Prompt use a backslash instead: i.e. `script\\build`.","path":"docs/build-instructions/windows.md","position":23,"original_position":23,"commit_id":"d853afd5c59ed86ae14fed13d71660a7ab162b86","original_commit_id":"d853afd5c59ed86ae14fed13d71660a7ab162b86","user":{"login":"damieng","id":118951,"avatar_url":"https://avatars.githubusercontent.com/u/118951?v=3","gravatar_id":"","url":"https://api.github.com/users/damieng","html_url":"https://github.com/damieng","followers_url":"https://api.github.com/users/damieng/followers","following_url":"https://api.github.com/users/damieng/following{/other_user}","gists_url":"https://api.github.com/users/damieng/gists{/gist_id}","starred_url":"https://api.github.com/users/damieng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damieng/subscriptions","organizations_url":"https://api.github.com/users/damieng/orgs","repos_url":"https://api.github.com/users/damieng/repos","events_url":"https://api.github.com/users/damieng/events{/privacy}","received_events_url":"https://api.github.com/users/damieng/received_events","type":"User","site_admin":false},"body":"Ah, you're right. A mention of bash there.","created_at":"2016-08-09T14:50:00Z","updated_at":"2016-08-09T14:50:00Z","html_url":"https://github.com/atom/atom/pull/12373#discussion_r74073552","pull_request_url":"https://api.github.com/repos/atom/atom/pulls/12373","_links":{"self":{"href":"https://api.github.com/repos/atom/atom/pulls/comments/74073552"},"html":{"href":"https://github.com/atom/atom/pull/12373#discussion_r74073552"},"pull_request":{"href":"https://api.github.com/repos/atom/atom/pulls/12373"}}},"pull_request":{"url":"https://api.github.com/repos/atom/atom/pulls/12373","id":80626179,"html_url":"https://github.com/atom/atom/pull/12373","diff_url":"https://github.com/atom/atom/pull/12373.diff","patch_url":"https://github.com/atom/atom/pull/12373.patch","issue_url":"https://api.github.com/repos/atom/atom/issues/12373","number":12373,"state":"open","locked":false,"title":"Update Windows build instructions to refer to Command Prompt more","user":{"login":"50Wliu","id":2766036,"avatar_url":"https://avatars.githubusercontent.com/u/2766036?v=3","gravatar_id":"","url":"https://api.github.com/users/50Wliu","html_url":"https://github.com/50Wliu","followers_url":"https://api.github.com/users/50Wliu/followers","following_url":"https://api.github.com/users/50Wliu/following{/other_user}","gists_url":"https://api.github.com/users/50Wliu/gists{/gist_id}","starred_url":"https://api.github.com/users/50Wliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/50Wliu/subscriptions","organizations_url":"https://api.github.com/users/50Wliu/orgs","repos_url":"https://api.github.com/users/50Wliu/repos","events_url":"https://api.github.com/users/50Wliu/events{/privacy}","received_events_url":"https://api.github.com/users/50Wliu/received_events","type":"User","site_admin":false},"body":"Despite the instructions saying that all the commands assumed the usage of Bash, it was actually the other way around - all commands used cmd syntax.  Other than clarifying that, I've also simplified/streamlined some of the sections.\r\n\r\nThere is one unfortunate \"bug\" introduced by these changes: whichever language package is being used by Linguist to highlight `cmd` blocks doesn't differentiate between when `dir` is being used as a command or as an argument.\r\n\r\n```cmd\r\nscript\\build --install-dir\r\n```\r\ncompared to\r\n```cmd\r\ndir\r\n```\r\n\r\n/cc @damieng ","created_at":"2016-08-09T14:04:03Z","updated_at":"2016-08-09T14:50:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e5857fd59a162782048e21d9151d3dd2c533376","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/atom/atom/pulls/12373/commits","review_comments_url":"https://api.github.com/repos/atom/atom/pulls/12373/comments","review_comment_url":"https://api.github.com/repos/atom/atom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/atom/issues/12373/comments","statuses_url":"https://api.github.com/repos/atom/atom/statuses/d853afd5c59ed86ae14fed13d71660a7ab162b86","head":{"label":"atom:wl-windows-build-instructions","ref":"wl-windows-build-instructions","sha":"d853afd5c59ed86ae14fed13d71660a7ab162b86","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":3228505,"name":"atom","full_name":"atom/atom","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/atom","description":"The hackable text editor","fork":false,"url":"https://api.github.com/repos/atom/atom","forks_url":"https://api.github.com/repos/atom/atom/forks","keys_url":"https://api.github.com/repos/atom/atom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/atom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/atom/teams","hooks_url":"https://api.github.com/repos/atom/atom/hooks","issue_events_url":"https://api.github.com/repos/atom/atom/issues/events{/number}","events_url":"https://api.github.com/repos/atom/atom/events","assignees_url":"https://api.github.com/repos/atom/atom/assignees{/user}","branches_url":"https://api.github.com/repos/atom/atom/branches{/branch}","tags_url":"https://api.github.com/repos/atom/atom/tags","blobs_url":"https://api.github.com/repos/atom/atom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/atom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/atom/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/atom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/atom/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/atom/languages","stargazers_url":"https://api.github.com/repos/atom/atom/stargazers","contributors_url":"https://api.github.com/repos/atom/atom/contributors","subscribers_url":"https://api.github.com/repos/atom/atom/subscribers","subscription_url":"https://api.github.com/repos/atom/atom/subscription","commits_url":"https://api.github.com/repos/atom/atom/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/atom/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/atom/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/atom/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/atom/contents/{+path}","compare_url":"https://api.github.com/repos/atom/atom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/atom/merges","archive_url":"https://api.github.com/repos/atom/atom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/atom/downloads","issues_url":"https://api.github.com/repos/atom/atom/issues{/number}","pulls_url":"https://api.github.com/repos/atom/atom/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/atom/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/atom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/atom/labels{/name}","releases_url":"https://api.github.com/repos/atom/atom/releases{/id}","deployments_url":"https://api.github.com/repos/atom/atom/deployments","created_at":"2012-01-20T18:18:21Z","updated_at":"2016-08-09T14:47:33Z","pushed_at":"2016-08-09T14:34:39Z","git_url":"git://github.com/atom/atom.git","ssh_url":"git@github.com:atom/atom.git","clone_url":"https://github.com/atom/atom.git","svn_url":"https://github.com/atom/atom","homepage":"https://atom.io","size":366865,"stargazers_count":29779,"watchers_count":29779,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5114,"mirror_url":null,"open_issues_count":1834,"forks":5114,"open_issues":1834,"watchers":29779,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"b73b269ffb5929068bb8cfc81f5d184a080cf9df","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":3228505,"name":"atom","full_name":"atom/atom","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/atom","description":"The hackable text editor","fork":false,"url":"https://api.github.com/repos/atom/atom","forks_url":"https://api.github.com/repos/atom/atom/forks","keys_url":"https://api.github.com/repos/atom/atom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/atom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/atom/teams","hooks_url":"https://api.github.com/repos/atom/atom/hooks","issue_events_url":"https://api.github.com/repos/atom/atom/issues/events{/number}","events_url":"https://api.github.com/repos/atom/atom/events","assignees_url":"https://api.github.com/repos/atom/atom/assignees{/user}","branches_url":"https://api.github.com/repos/atom/atom/branches{/branch}","tags_url":"https://api.github.com/repos/atom/atom/tags","blobs_url":"https://api.github.com/repos/atom/atom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/atom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/atom/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/atom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/atom/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/atom/languages","stargazers_url":"https://api.github.com/repos/atom/atom/stargazers","contributors_url":"https://api.github.com/repos/atom/atom/contributors","subscribers_url":"https://api.github.com/repos/atom/atom/subscribers","subscription_url":"https://api.github.com/repos/atom/atom/subscription","commits_url":"https://api.github.com/repos/atom/atom/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/atom/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/atom/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/atom/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/atom/contents/{+path}","compare_url":"https://api.github.com/repos/atom/atom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/atom/merges","archive_url":"https://api.github.com/repos/atom/atom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/atom/downloads","issues_url":"https://api.github.com/repos/atom/atom/issues{/number}","pulls_url":"https://api.github.com/repos/atom/atom/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/atom/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/atom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/atom/labels{/name}","releases_url":"https://api.github.com/repos/atom/atom/releases{/id}","deployments_url":"https://api.github.com/repos/atom/atom/deployments","created_at":"2012-01-20T18:18:21Z","updated_at":"2016-08-09T14:47:33Z","pushed_at":"2016-08-09T14:34:39Z","git_url":"git://github.com/atom/atom.git","ssh_url":"git@github.com:atom/atom.git","clone_url":"https://github.com/atom/atom.git","svn_url":"https://github.com/atom/atom","homepage":"https://atom.io","size":366865,"stargazers_count":29779,"watchers_count":29779,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5114,"mirror_url":null,"open_issues_count":1834,"forks":5114,"open_issues":1834,"watchers":29779,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/atom/pulls/12373"},"html":{"href":"https://github.com/atom/atom/pull/12373"},"issue":{"href":"https://api.github.com/repos/atom/atom/issues/12373"},"comments":{"href":"https://api.github.com/repos/atom/atom/issues/12373/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/atom/pulls/12373/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/atom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/atom/pulls/12373/commits"},"statuses":{"href":"https://api.github.com/repos/atom/atom/statuses/d853afd5c59ed86ae14fed13d71660a7ab162b86"}}}}
{"actor":{"display_login":"damieng"}}