{"action":"created","comment":{"url":"https://api.github.com/repos/elkarte/Elkarte/pulls/comments/64145023","id":64145023,"diff_hunk":"@@ -419,7 +419,7 @@\n $txt['profile_warning_effect_watch'] = 'User will be added to moderator watch list.';\n $txt['profile_warning_effect_own_watched'] = 'You are on the moderator watch list.';\n $txt['profile_warning_is_watch'] = 'being watched';\n-$txt['profile_warning_effect_moderation'] = 'All users posts will be moderated.';\n+$txt['profile_warning_effect_moderate'] = 'All users posts will be moderated.';","path":"themes/default/languages/english/Profile.english.php","position":5,"original_position":5,"commit_id":"fa3c224329f0eb7d301301a92cea0a6b266a2a57","original_commit_id":"fa3c224329f0eb7d301301a92cea0a6b266a2a57","user":{"login":"Frenzie","id":202757,"avatar_url":"https://avatars.githubusercontent.com/u/202757?v=3","gravatar_id":"","url":"https://api.github.com/users/Frenzie","html_url":"https://github.com/Frenzie","followers_url":"https://api.github.com/users/Frenzie/followers","following_url":"https://api.github.com/users/Frenzie/following{/other_user}","gists_url":"https://api.github.com/users/Frenzie/gists{/gist_id}","starred_url":"https://api.github.com/users/Frenzie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frenzie/subscriptions","organizations_url":"https://api.github.com/users/Frenzie/orgs","repos_url":"https://api.github.com/users/Frenzie/repos","events_url":"https://api.github.com/users/Frenzie/events{/privacy}","received_events_url":"https://api.github.com/users/Frenzie/received_events","type":"User","site_admin":false},"body":"Should be either `user` or `user\\'s`. But if I catch the meaning correctly I'd better be rewritten to something like `All posts by this user will be moderated.`","created_at":"2016-05-22T06:46:55Z","updated_at":"2016-05-22T06:46:55Z","html_url":"https://github.com/elkarte/Elkarte/pull/2549#discussion_r64145023","pull_request_url":"https://api.github.com/repos/elkarte/Elkarte/pulls/2549","_links":{"self":{"href":"https://api.github.com/repos/elkarte/Elkarte/pulls/comments/64145023"},"html":{"href":"https://github.com/elkarte/Elkarte/pull/2549#discussion_r64145023"},"pull_request":{"href":"https://api.github.com/repos/elkarte/Elkarte/pulls/2549"}}},"pull_request":{"url":"https://api.github.com/repos/elkarte/Elkarte/pulls/2549","id":70962081,"html_url":"https://github.com/elkarte/Elkarte/pull/2549","diff_url":"https://github.com/elkarte/Elkarte/pull/2549.diff","patch_url":"https://github.com/elkarte/Elkarte/pull/2549.patch","issue_url":"https://api.github.com/repos/elkarte/Elkarte/issues/2549","number":2549,"state":"open","locked":false,"title":"Do not merge, just for feedback","user":{"login":"Spuds","id":1181042,"avatar_url":"https://avatars.githubusercontent.com/u/1181042?v=3","gravatar_id":"","url":"https://api.github.com/users/Spuds","html_url":"https://github.com/Spuds","followers_url":"https://api.github.com/users/Spuds/followers","following_url":"https://api.github.com/users/Spuds/following{/other_user}","gists_url":"https://api.github.com/users/Spuds/gists{/gist_id}","starred_url":"https://api.github.com/users/Spuds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spuds/subscriptions","organizations_url":"https://api.github.com/users/Spuds/orgs","repos_url":"https://api.github.com/users/Spuds/repos","events_url":"https://api.github.com/users/Spuds/events{/privacy}","received_events_url":"https://api.github.com/users/Spuds/received_events","type":"User","site_admin":false},"body":"Ignore the minor things in the PR and look at \r\n\r\nhttps://github.com/elkarte/Elkarte/commit/f989f89b10c4393b5f05db49b22aec68fafd3705\r\nhttps://github.com/elkarte/Elkarte/commit/950d85fdb157ea4a029c87abd280434c4b91df7a\r\nhttps://github.com/elkarte/Elkarte/commit/f72e92f746ae6b914d2e7101d9b4691ad2c854ce\r\nhttps://github.com/elkarte/Elkarte/commit/fa3c224329f0eb7d301301a92cea0a6b266a2a57\r\n\r\nThis is moving the profile Buddies tab to be ajax.   Have not looked at \"recent\" tab yet but that would be next. \r\n\r\nTo make this work UI tabs allows us to specify an href value to load ajax html into a tab when its activated.  Given the way tabs work, it has to be HTML and not XML data (its called to late in the stack to effect the ajax settings).  So is kind of \"ugly\" having the action inside of xml.controller since it does not return XML.  You could use the tab load event to trigger a AJAX / XML event and then build the values but that IMO gets super ugly in the JS, at least any way I could see this working.\r\n\r\nHad to do a minor refactor of ProfileInfo.controller so that one could call the buddies function from the xml controller (or anywhere), as to much user context was built inside of the main method. So this just broke it up in to small methods so one can call the needed methods to get things rolling.\r\n\r\nSo take a look, give me thoughts on if we should proceed or make change or leave things as they were.","created_at":"2016-05-21T22:27:08Z","updated_at":"2016-05-22T06:46:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17706a60b6025d8d9c5cca40e0d92f23eedc3019","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elkarte/Elkarte/pulls/2549/commits","review_comments_url":"https://api.github.com/repos/elkarte/Elkarte/pulls/2549/comments","review_comment_url":"https://api.github.com/repos/elkarte/Elkarte/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elkarte/Elkarte/issues/2549/comments","statuses_url":"https://api.github.com/repos/elkarte/Elkarte/statuses/fa3c224329f0eb7d301301a92cea0a6b266a2a57","head":{"label":"Spuds:mybugs","ref":"mybugs","sha":"fa3c224329f0eb7d301301a92cea0a6b266a2a57","user":{"login":"Spuds","id":1181042,"avatar_url":"https://avatars.githubusercontent.com/u/1181042?v=3","gravatar_id":"","url":"https://api.github.com/users/Spuds","html_url":"https://github.com/Spuds","followers_url":"https://api.github.com/users/Spuds/followers","following_url":"https://api.github.com/users/Spuds/following{/other_user}","gists_url":"https://api.github.com/users/Spuds/gists{/gist_id}","starred_url":"https://api.github.com/users/Spuds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spuds/subscriptions","organizations_url":"https://api.github.com/users/Spuds/orgs","repos_url":"https://api.github.com/users/Spuds/repos","events_url":"https://api.github.com/users/Spuds/events{/privacy}","received_events_url":"https://api.github.com/users/Spuds/received_events","type":"User","site_admin":false},"repo":{"id":11324354,"name":"Elkarte","full_name":"Spuds/Elkarte","owner":{"login":"Spuds","id":1181042,"avatar_url":"https://avatars.githubusercontent.com/u/1181042?v=3","gravatar_id":"","url":"https://api.github.com/users/Spuds","html_url":"https://github.com/Spuds","followers_url":"https://api.github.com/users/Spuds/followers","following_url":"https://api.github.com/users/Spuds/following{/other_user}","gists_url":"https://api.github.com/users/Spuds/gists{/gist_id}","starred_url":"https://api.github.com/users/Spuds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spuds/subscriptions","organizations_url":"https://api.github.com/users/Spuds/orgs","repos_url":"https://api.github.com/users/Spuds/repos","events_url":"https://api.github.com/users/Spuds/events{/privacy}","received_events_url":"https://api.github.com/users/Spuds/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Spuds/Elkarte","description":"Development workspace for Elkarte, a modern version of SMF","fork":true,"url":"https://api.github.com/repos/Spuds/Elkarte","forks_url":"https://api.github.com/repos/Spuds/Elkarte/forks","keys_url":"https://api.github.com/repos/Spuds/Elkarte/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Spuds/Elkarte/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Spuds/Elkarte/teams","hooks_url":"https://api.github.com/repos/Spuds/Elkarte/hooks","issue_events_url":"https://api.github.com/repos/Spuds/Elkarte/issues/events{/number}","events_url":"https://api.github.com/repos/Spuds/Elkarte/events","assignees_url":"https://api.github.com/repos/Spuds/Elkarte/assignees{/user}","branches_url":"https://api.github.com/repos/Spuds/Elkarte/branches{/branch}","tags_url":"https://api.github.com/repos/Spuds/Elkarte/tags","blobs_url":"https://api.github.com/repos/Spuds/Elkarte/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Spuds/Elkarte/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Spuds/Elkarte/git/refs{/sha}","trees_url":"https://api.github.com/repos/Spuds/Elkarte/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Spuds/Elkarte/statuses/{sha}","languages_url":"https://api.github.com/repos/Spuds/Elkarte/languages","stargazers_url":"https://api.github.com/repos/Spuds/Elkarte/stargazers","contributors_url":"https://api.github.com/repos/Spuds/Elkarte/contributors","subscribers_url":"https://api.github.com/repos/Spuds/Elkarte/subscribers","subscription_url":"https://api.github.com/repos/Spuds/Elkarte/subscription","commits_url":"https://api.github.com/repos/Spuds/Elkarte/commits{/sha}","git_commits_url":"https://api.github.com/repos/Spuds/Elkarte/git/commits{/sha}","comments_url":"https://api.github.com/repos/Spuds/Elkarte/comments{/number}","issue_comment_url":"https://api.github.com/repos/Spuds/Elkarte/issues/comments{/number}","contents_url":"https://api.github.com/repos/Spuds/Elkarte/contents/{+path}","compare_url":"https://api.github.com/repos/Spuds/Elkarte/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Spuds/Elkarte/merges","archive_url":"https://api.github.com/repos/Spuds/Elkarte/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Spuds/Elkarte/downloads","issues_url":"https://api.github.com/repos/Spuds/Elkarte/issues{/number}","pulls_url":"https://api.github.com/repos/Spuds/Elkarte/pulls{/number}","milestones_url":"https://api.github.com/repos/Spuds/Elkarte/milestones{/number}","notifications_url":"https://api.github.com/repos/Spuds/Elkarte/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Spuds/Elkarte/labels{/name}","releases_url":"https://api.github.com/repos/Spuds/Elkarte/releases{/id}","deployments_url":"https://api.github.com/repos/Spuds/Elkarte/deployments","created_at":"2013-07-10T21:02:12Z","updated_at":"2014-06-30T12:21:32Z","pushed_at":"2016-05-21T22:14:16Z","git_url":"git://github.com/Spuds/Elkarte.git","ssh_url":"git@github.com:Spuds/Elkarte.git","clone_url":"https://github.com/Spuds/Elkarte.git","svn_url":"https://github.com/Spuds/Elkarte","homepage":"http://www.elkarte.net","size":65056,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elkarte:development","ref":"development","sha":"bc0d8a640e9cc51bdc0e8c19a6d75e3c0cb5a414","user":{"login":"elkarte","id":3117105,"avatar_url":"https://avatars.githubusercontent.com/u/3117105?v=3","gravatar_id":"","url":"https://api.github.com/users/elkarte","html_url":"https://github.com/elkarte","followers_url":"https://api.github.com/users/elkarte/followers","following_url":"https://api.github.com/users/elkarte/following{/other_user}","gists_url":"https://api.github.com/users/elkarte/gists{/gist_id}","starred_url":"https://api.github.com/users/elkarte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elkarte/subscriptions","organizations_url":"https://api.github.com/users/elkarte/orgs","repos_url":"https://api.github.com/users/elkarte/repos","events_url":"https://api.github.com/users/elkarte/events{/privacy}","received_events_url":"https://api.github.com/users/elkarte/received_events","type":"Organization","site_admin":false},"repo":{"id":6815666,"name":"Elkarte","full_name":"elkarte/Elkarte","owner":{"login":"elkarte","id":3117105,"avatar_url":"https://avatars.githubusercontent.com/u/3117105?v=3","gravatar_id":"","url":"https://api.github.com/users/elkarte","html_url":"https://github.com/elkarte","followers_url":"https://api.github.com/users/elkarte/followers","following_url":"https://api.github.com/users/elkarte/following{/other_user}","gists_url":"https://api.github.com/users/elkarte/gists{/gist_id}","starred_url":"https://api.github.com/users/elkarte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elkarte/subscriptions","organizations_url":"https://api.github.com/users/elkarte/orgs","repos_url":"https://api.github.com/users/elkarte/repos","events_url":"https://api.github.com/users/elkarte/events{/privacy}","received_events_url":"https://api.github.com/users/elkarte/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elkarte/Elkarte","description":"ElkArte Forum.  A free, open source, PHP-based discussion forum.","fork":false,"url":"https://api.github.com/repos/elkarte/Elkarte","forks_url":"https://api.github.com/repos/elkarte/Elkarte/forks","keys_url":"https://api.github.com/repos/elkarte/Elkarte/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elkarte/Elkarte/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elkarte/Elkarte/teams","hooks_url":"https://api.github.com/repos/elkarte/Elkarte/hooks","issue_events_url":"https://api.github.com/repos/elkarte/Elkarte/issues/events{/number}","events_url":"https://api.github.com/repos/elkarte/Elkarte/events","assignees_url":"https://api.github.com/repos/elkarte/Elkarte/assignees{/user}","branches_url":"https://api.github.com/repos/elkarte/Elkarte/branches{/branch}","tags_url":"https://api.github.com/repos/elkarte/Elkarte/tags","blobs_url":"https://api.github.com/repos/elkarte/Elkarte/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elkarte/Elkarte/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elkarte/Elkarte/git/refs{/sha}","trees_url":"https://api.github.com/repos/elkarte/Elkarte/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elkarte/Elkarte/statuses/{sha}","languages_url":"https://api.github.com/repos/elkarte/Elkarte/languages","stargazers_url":"https://api.github.com/repos/elkarte/Elkarte/stargazers","contributors_url":"https://api.github.com/repos/elkarte/Elkarte/contributors","subscribers_url":"https://api.github.com/repos/elkarte/Elkarte/subscribers","subscription_url":"https://api.github.com/repos/elkarte/Elkarte/subscription","commits_url":"https://api.github.com/repos/elkarte/Elkarte/commits{/sha}","git_commits_url":"https://api.github.com/repos/elkarte/Elkarte/git/commits{/sha}","comments_url":"https://api.github.com/repos/elkarte/Elkarte/comments{/number}","issue_comment_url":"https://api.github.com/repos/elkarte/Elkarte/issues/comments{/number}","contents_url":"https://api.github.com/repos/elkarte/Elkarte/contents/{+path}","compare_url":"https://api.github.com/repos/elkarte/Elkarte/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elkarte/Elkarte/merges","archive_url":"https://api.github.com/repos/elkarte/Elkarte/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elkarte/Elkarte/downloads","issues_url":"https://api.github.com/repos/elkarte/Elkarte/issues{/number}","pulls_url":"https://api.github.com/repos/elkarte/Elkarte/pulls{/number}","milestones_url":"https://api.github.com/repos/elkarte/Elkarte/milestones{/number}","notifications_url":"https://api.github.com/repos/elkarte/Elkarte/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elkarte/Elkarte/labels{/name}","releases_url":"https://api.github.com/repos/elkarte/Elkarte/releases{/id}","deployments_url":"https://api.github.com/repos/elkarte/Elkarte/deployments","created_at":"2012-11-22T16:04:26Z","updated_at":"2016-05-18T15:47:54Z","pushed_at":"2016-05-22T06:10:56Z","git_url":"git://github.com/elkarte/Elkarte.git","ssh_url":"git@github.com:elkarte/Elkarte.git","clone_url":"https://github.com/elkarte/Elkarte.git","svn_url":"https://github.com/elkarte/Elkarte","homepage":"http://www.elkarte.net","size":77199,"stargazers_count":62,"watchers_count":62,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":44,"mirror_url":null,"open_issues_count":227,"forks":44,"open_issues":227,"watchers":62,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/elkarte/Elkarte/pulls/2549"},"html":{"href":"https://github.com/elkarte/Elkarte/pull/2549"},"issue":{"href":"https://api.github.com/repos/elkarte/Elkarte/issues/2549"},"comments":{"href":"https://api.github.com/repos/elkarte/Elkarte/issues/2549/comments"},"review_comments":{"href":"https://api.github.com/repos/elkarte/Elkarte/pulls/2549/comments"},"review_comment":{"href":"https://api.github.com/repos/elkarte/Elkarte/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elkarte/Elkarte/pulls/2549/commits"},"statuses":{"href":"https://api.github.com/repos/elkarte/Elkarte/statuses/fa3c224329f0eb7d301301a92cea0a6b266a2a57"}}}}
{"actor":{"display_login":"Frenzie"}}