{"action":"created","comment":{"url":"https://api.github.com/repos/torchbox/wagtail/pulls/comments/76980591","id":76980591,"diff_hunk":"@@ -0,0 +1,34 @@\n+from __future__ import absolute_import, unicode_literals\n+\n+\n+# Helper functions for migrating the Rendition.filter foreign key to the filter_spec field,\n+# and the corresponding reverse migration\n+\n+def get_fill_filter_spec_migrations(app_name, rendition_model_name):\n+\n+    def fill_filter_spec_forward(apps, schema_editor):\n+        # Populate Rendition.filter_spec with the spec string of the corresponding Filter object\n+        Rendition = apps.get_model(app_name, rendition_model_name)\n+        db_alias = schema_editor.connection.alias","path":"wagtail/wagtailimages/utils.py","position":12,"original_position":12,"commit_id":"d4d156fc6d44caf2f7935ec80f046878cd76a4a9","original_commit_id":"d4d156fc6d44caf2f7935ec80f046878cd76a4a9","user":{"login":"gasman","id":85097,"avatar_url":"https://avatars.githubusercontent.com/u/85097?v=3","gravatar_id":"","url":"https://api.github.com/users/gasman","html_url":"https://github.com/gasman","followers_url":"https://api.github.com/users/gasman/followers","following_url":"https://api.github.com/users/gasman/following{/other_user}","gists_url":"https://api.github.com/users/gasman/gists{/gist_id}","starred_url":"https://api.github.com/users/gasman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasman/subscriptions","organizations_url":"https://api.github.com/users/gasman/orgs","repos_url":"https://api.github.com/users/gasman/repos","events_url":"https://api.github.com/users/gasman/events{/privacy}","received_events_url":"https://api.github.com/users/gasman/received_events","type":"User","site_admin":false},"body":"Not sure, actually - I kept that unchanged from #2537. @Gagaro?","created_at":"2016-08-31T12:48:46Z","updated_at":"2016-08-31T12:48:46Z","html_url":"https://github.com/torchbox/wagtail/pull/2910#discussion_r76980591","pull_request_url":"https://api.github.com/repos/torchbox/wagtail/pulls/2910","_links":{"self":{"href":"https://api.github.com/repos/torchbox/wagtail/pulls/comments/76980591"},"html":{"href":"https://github.com/torchbox/wagtail/pull/2910#discussion_r76980591"},"pull_request":{"href":"https://api.github.com/repos/torchbox/wagtail/pulls/2910"}}},"pull_request":{"url":"https://api.github.com/repos/torchbox/wagtail/pulls/2910","id":81181796,"html_url":"https://github.com/torchbox/wagtail/pull/2910","diff_url":"https://github.com/torchbox/wagtail/pull/2910.diff","patch_url":"https://github.com/torchbox/wagtail/pull/2910.patch","issue_url":"https://api.github.com/repos/torchbox/wagtail/issues/2910","number":2910,"state":"open","locked":false,"title":"Introduce `filter_spec` field to Rendition","user":{"login":"gasman","id":85097,"avatar_url":"https://avatars.githubusercontent.com/u/85097?v=3","gravatar_id":"","url":"https://api.github.com/users/gasman","html_url":"https://github.com/gasman","followers_url":"https://api.github.com/users/gasman/followers","following_url":"https://api.github.com/users/gasman/following{/other_user}","gists_url":"https://api.github.com/users/gasman/gists{/gist_id}","starred_url":"https://api.github.com/users/gasman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasman/subscriptions","organizations_url":"https://api.github.com/users/gasman/orgs","repos_url":"https://api.github.com/users/gasman/repos","events_url":"https://api.github.com/users/gasman/events{/privacy}","received_events_url":"https://api.github.com/users/gasman/received_events","type":"User","site_admin":false},"body":"First step of #2881","created_at":"2016-08-12T20:55:07Z","updated_at":"2016-08-31T12:48:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d400d84c8a6383dcd5fb369daf5a73267104297","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/torchbox/wagtail/milestones/30","html_url":"https://github.com/torchbox/wagtail/milestones/1.7","labels_url":"https://api.github.com/repos/torchbox/wagtail/milestones/30/labels","id":1911767,"number":30,"title":"1.7","description":"","creator":{"login":"gasman","id":85097,"avatar_url":"https://avatars.githubusercontent.com/u/85097?v=3","gravatar_id":"","url":"https://api.github.com/users/gasman","html_url":"https://github.com/gasman","followers_url":"https://api.github.com/users/gasman/followers","following_url":"https://api.github.com/users/gasman/following{/other_user}","gists_url":"https://api.github.com/users/gasman/gists{/gist_id}","starred_url":"https://api.github.com/users/gasman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasman/subscriptions","organizations_url":"https://api.github.com/users/gasman/orgs","repos_url":"https://api.github.com/users/gasman/repos","events_url":"https://api.github.com/users/gasman/events{/privacy}","received_events_url":"https://api.github.com/users/gasman/received_events","type":"User","site_admin":false},"open_issues":43,"closed_issues":12,"state":"open","created_at":"2016-07-29T14:29:35Z","updated_at":"2016-08-31T12:14:08Z","due_on":"2016-09-29T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/torchbox/wagtail/pulls/2910/commits","review_comments_url":"https://api.github.com/repos/torchbox/wagtail/pulls/2910/comments","review_comment_url":"https://api.github.com/repos/torchbox/wagtail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/torchbox/wagtail/issues/2910/comments","statuses_url":"https://api.github.com/repos/torchbox/wagtail/statuses/d4d156fc6d44caf2f7935ec80f046878cd76a4a9","head":{"label":"gasman:cleanup/filter-spec-field","ref":"cleanup/filter-spec-field","sha":"d4d156fc6d44caf2f7935ec80f046878cd76a4a9","user":{"login":"gasman","id":85097,"avatar_url":"https://avatars.githubusercontent.com/u/85097?v=3","gravatar_id":"","url":"https://api.github.com/users/gasman","html_url":"https://github.com/gasman","followers_url":"https://api.github.com/users/gasman/followers","following_url":"https://api.github.com/users/gasman/following{/other_user}","gists_url":"https://api.github.com/users/gasman/gists{/gist_id}","starred_url":"https://api.github.com/users/gasman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasman/subscriptions","organizations_url":"https://api.github.com/users/gasman/orgs","repos_url":"https://api.github.com/users/gasman/repos","events_url":"https://api.github.com/users/gasman/events{/privacy}","received_events_url":"https://api.github.com/users/gasman/received_events","type":"User","site_admin":false},"repo":{"id":18436628,"name":"wagtail","full_name":"gasman/wagtail","owner":{"login":"gasman","id":85097,"avatar_url":"https://avatars.githubusercontent.com/u/85097?v=3","gravatar_id":"","url":"https://api.github.com/users/gasman","html_url":"https://github.com/gasman","followers_url":"https://api.github.com/users/gasman/followers","following_url":"https://api.github.com/users/gasman/following{/other_user}","gists_url":"https://api.github.com/users/gasman/gists{/gist_id}","starred_url":"https://api.github.com/users/gasman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasman/subscriptions","organizations_url":"https://api.github.com/users/gasman/orgs","repos_url":"https://api.github.com/users/gasman/repos","events_url":"https://api.github.com/users/gasman/events{/privacy}","received_events_url":"https://api.github.com/users/gasman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gasman/wagtail","description":"A new Django content management system","fork":true,"url":"https://api.github.com/repos/gasman/wagtail","forks_url":"https://api.github.com/repos/gasman/wagtail/forks","keys_url":"https://api.github.com/repos/gasman/wagtail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gasman/wagtail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gasman/wagtail/teams","hooks_url":"https://api.github.com/repos/gasman/wagtail/hooks","issue_events_url":"https://api.github.com/repos/gasman/wagtail/issues/events{/number}","events_url":"https://api.github.com/repos/gasman/wagtail/events","assignees_url":"https://api.github.com/repos/gasman/wagtail/assignees{/user}","branches_url":"https://api.github.com/repos/gasman/wagtail/branches{/branch}","tags_url":"https://api.github.com/repos/gasman/wagtail/tags","blobs_url":"https://api.github.com/repos/gasman/wagtail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gasman/wagtail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gasman/wagtail/git/refs{/sha}","trees_url":"https://api.github.com/repos/gasman/wagtail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gasman/wagtail/statuses/{sha}","languages_url":"https://api.github.com/repos/gasman/wagtail/languages","stargazers_url":"https://api.github.com/repos/gasman/wagtail/stargazers","contributors_url":"https://api.github.com/repos/gasman/wagtail/contributors","subscribers_url":"https://api.github.com/repos/gasman/wagtail/subscribers","subscription_url":"https://api.github.com/repos/gasman/wagtail/subscription","commits_url":"https://api.github.com/repos/gasman/wagtail/commits{/sha}","git_commits_url":"https://api.github.com/repos/gasman/wagtail/git/commits{/sha}","comments_url":"https://api.github.com/repos/gasman/wagtail/comments{/number}","issue_comment_url":"https://api.github.com/repos/gasman/wagtail/issues/comments{/number}","contents_url":"https://api.github.com/repos/gasman/wagtail/contents/{+path}","compare_url":"https://api.github.com/repos/gasman/wagtail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gasman/wagtail/merges","archive_url":"https://api.github.com/repos/gasman/wagtail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gasman/wagtail/downloads","issues_url":"https://api.github.com/repos/gasman/wagtail/issues{/number}","pulls_url":"https://api.github.com/repos/gasman/wagtail/pulls{/number}","milestones_url":"https://api.github.com/repos/gasman/wagtail/milestones{/number}","notifications_url":"https://api.github.com/repos/gasman/wagtail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gasman/wagtail/labels{/name}","releases_url":"https://api.github.com/repos/gasman/wagtail/releases{/id}","deployments_url":"https://api.github.com/repos/gasman/wagtail/deployments","created_at":"2014-04-04T11:18:59Z","updated_at":"2015-02-21T17:50:33Z","pushed_at":"2016-08-24T15:43:27Z","git_url":"git://github.com/gasman/wagtail.git","ssh_url":"git@github.com:gasman/wagtail.git","clone_url":"https://github.com/gasman/wagtail.git","svn_url":"https://github.com/gasman/wagtail","homepage":"wagtail.io","size":37331,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"torchbox:master","ref":"master","sha":"e39fb5646cc0302184ba190f2b6190c01ad48d8b","user":{"login":"torchbox","id":84015,"avatar_url":"https://avatars.githubusercontent.com/u/84015?v=3","gravatar_id":"","url":"https://api.github.com/users/torchbox","html_url":"https://github.com/torchbox","followers_url":"https://api.github.com/users/torchbox/followers","following_url":"https://api.github.com/users/torchbox/following{/other_user}","gists_url":"https://api.github.com/users/torchbox/gists{/gist_id}","starred_url":"https://api.github.com/users/torchbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torchbox/subscriptions","organizations_url":"https://api.github.com/users/torchbox/orgs","repos_url":"https://api.github.com/users/torchbox/repos","events_url":"https://api.github.com/users/torchbox/events{/privacy}","received_events_url":"https://api.github.com/users/torchbox/received_events","type":"Organization","site_admin":false},"repo":{"id":16479108,"name":"wagtail","full_name":"torchbox/wagtail","owner":{"login":"torchbox","id":84015,"avatar_url":"https://avatars.githubusercontent.com/u/84015?v=3","gravatar_id":"","url":"https://api.github.com/users/torchbox","html_url":"https://github.com/torchbox","followers_url":"https://api.github.com/users/torchbox/followers","following_url":"https://api.github.com/users/torchbox/following{/other_user}","gists_url":"https://api.github.com/users/torchbox/gists{/gist_id}","starred_url":"https://api.github.com/users/torchbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torchbox/subscriptions","organizations_url":"https://api.github.com/users/torchbox/orgs","repos_url":"https://api.github.com/users/torchbox/repos","events_url":"https://api.github.com/users/torchbox/events{/privacy}","received_events_url":"https://api.github.com/users/torchbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/torchbox/wagtail","description":"A Django content management system focused on flexibility and user experience","fork":false,"url":"https://api.github.com/repos/torchbox/wagtail","forks_url":"https://api.github.com/repos/torchbox/wagtail/forks","keys_url":"https://api.github.com/repos/torchbox/wagtail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/torchbox/wagtail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/torchbox/wagtail/teams","hooks_url":"https://api.github.com/repos/torchbox/wagtail/hooks","issue_events_url":"https://api.github.com/repos/torchbox/wagtail/issues/events{/number}","events_url":"https://api.github.com/repos/torchbox/wagtail/events","assignees_url":"https://api.github.com/repos/torchbox/wagtail/assignees{/user}","branches_url":"https://api.github.com/repos/torchbox/wagtail/branches{/branch}","tags_url":"https://api.github.com/repos/torchbox/wagtail/tags","blobs_url":"https://api.github.com/repos/torchbox/wagtail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/torchbox/wagtail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/torchbox/wagtail/git/refs{/sha}","trees_url":"https://api.github.com/repos/torchbox/wagtail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/torchbox/wagtail/statuses/{sha}","languages_url":"https://api.github.com/repos/torchbox/wagtail/languages","stargazers_url":"https://api.github.com/repos/torchbox/wagtail/stargazers","contributors_url":"https://api.github.com/repos/torchbox/wagtail/contributors","subscribers_url":"https://api.github.com/repos/torchbox/wagtail/subscribers","subscription_url":"https://api.github.com/repos/torchbox/wagtail/subscription","commits_url":"https://api.github.com/repos/torchbox/wagtail/commits{/sha}","git_commits_url":"https://api.github.com/repos/torchbox/wagtail/git/commits{/sha}","comments_url":"https://api.github.com/repos/torchbox/wagtail/comments{/number}","issue_comment_url":"https://api.github.com/repos/torchbox/wagtail/issues/comments{/number}","contents_url":"https://api.github.com/repos/torchbox/wagtail/contents/{+path}","compare_url":"https://api.github.com/repos/torchbox/wagtail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/torchbox/wagtail/merges","archive_url":"https://api.github.com/repos/torchbox/wagtail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/torchbox/wagtail/downloads","issues_url":"https://api.github.com/repos/torchbox/wagtail/issues{/number}","pulls_url":"https://api.github.com/repos/torchbox/wagtail/pulls{/number}","milestones_url":"https://api.github.com/repos/torchbox/wagtail/milestones{/number}","notifications_url":"https://api.github.com/repos/torchbox/wagtail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/torchbox/wagtail/labels{/name}","releases_url":"https://api.github.com/repos/torchbox/wagtail/releases{/id}","deployments_url":"https://api.github.com/repos/torchbox/wagtail/deployments","created_at":"2014-02-03T12:41:59Z","updated_at":"2016-08-30T21:21:12Z","pushed_at":"2016-08-31T11:59:58Z","git_url":"git://github.com/torchbox/wagtail.git","ssh_url":"git@github.com:torchbox/wagtail.git","clone_url":"https://github.com/torchbox/wagtail.git","svn_url":"https://github.com/torchbox/wagtail","homepage":"wagtail.io","size":47071,"stargazers_count":3672,"watchers_count":3672,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":720,"mirror_url":null,"open_issues_count":490,"forks":720,"open_issues":490,"watchers":3672,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/torchbox/wagtail/pulls/2910"},"html":{"href":"https://github.com/torchbox/wagtail/pull/2910"},"issue":{"href":"https://api.github.com/repos/torchbox/wagtail/issues/2910"},"comments":{"href":"https://api.github.com/repos/torchbox/wagtail/issues/2910/comments"},"review_comments":{"href":"https://api.github.com/repos/torchbox/wagtail/pulls/2910/comments"},"review_comment":{"href":"https://api.github.com/repos/torchbox/wagtail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/torchbox/wagtail/pulls/2910/commits"},"statuses":{"href":"https://api.github.com/repos/torchbox/wagtail/statuses/d4d156fc6d44caf2f7935ec80f046878cd76a4a9"}}}}
{"actor":{"display_login":"gasman"}}