{"action":"created","issue":{"url":"https://api.github.com/repos/LeanKit-Labs/eslint-config-leankit/issues/4","labels_url":"https://api.github.com/repos/LeanKit-Labs/eslint-config-leankit/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/LeanKit-Labs/eslint-config-leankit/issues/4/comments","events_url":"https://api.github.com/repos/LeanKit-Labs/eslint-config-leankit/issues/4/events","html_url":"https://github.com/LeanKit-Labs/eslint-config-leankit/pull/4","id":124767195,"number":4,"title":"Minor Tweaks to eslint-config-leankit based previous implementation","user":{"login":"elijahmanor","id":86454,"avatar_url":"https://avatars.githubusercontent.com/u/86454?v=3","gravatar_id":"","url":"https://api.github.com/users/elijahmanor","html_url":"https://github.com/elijahmanor","followers_url":"https://api.github.com/users/elijahmanor/followers","following_url":"https://api.github.com/users/elijahmanor/following{/other_user}","gists_url":"https://api.github.com/users/elijahmanor/gists{/gist_id}","starred_url":"https://api.github.com/users/elijahmanor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elijahmanor/subscriptions","organizations_url":"https://api.github.com/users/elijahmanor/orgs","repos_url":"https://api.github.com/users/elijahmanor/repos","events_url":"https://api.github.com/users/elijahmanor/events{/privacy}","received_events_url":"https://api.github.com/users/elijahmanor/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/LeanKit-Labs/eslint-config-leankit/labels/Needs%20Developer%20Review","name":"Needs Developer Review","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-04T14:20:33Z","updated_at":"2016-01-04T14:56:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/LeanKit-Labs/eslint-config-leankit/pulls/4","html_url":"https://github.com/LeanKit-Labs/eslint-config-leankit/pull/4","diff_url":"https://github.com/LeanKit-Labs/eslint-config-leankit/pull/4.diff","patch_url":"https://github.com/LeanKit-Labs/eslint-config-leankit/pull/4.patch"},"body":"Minor Tweaks to `eslint-config-leankit` based on lessons learned when integrating the rules into `nonstop-index-ui`\r\n\r\n## Turned off the following rules\r\n\r\n* `react/jsx-handler-names` - it turns out this is problematic when using `lux` actions directly\r\n* `no-extra-parens` - make this a trial rule as grouping can help make code clearer and it can conflict with the `react/wrap-multilines` rule making an override necessary\r\n* `react/jsx-boolean-value` - it is redundant to enforce this rule\r\n* `no-param-reassign` - this is done frequently and the fix bloats the code\r\n* `no-eq-null` - this edgecase is infrequent and `!= null` to indicate `null` and `undefined` is nice\r\n* `newline-after-var` - this is done frequently and feels very nit picky\r\n\r\n## Update the following rules\r\n\r\n* `react/sort-comp` - swap getActions/getActionGroup and stores\r\n* `react/jsx-quotes` is deprecated and should use `jsx-quotes` instead\r\n\r\n## Turn all warnings into errors\r\n\r\nWarnings should just be considered as errors. \r\n\r\n* `no-console`\r\n* `react/sort-comp`\r\n\r\n## There are 4 remaining TRIAL rules\r\n\r\nThese rules are marked as `// TRIAL` in this repo and it is up to the consumer to turn these rules on and experiment with their options. If we come to an agreement on these rules then they'll be turned on in a future update.\r\n\r\n* `complexity`\r\n* `arrow-body-style`\r\n* `no-negated-condition`\r\n* `no-extra-parens`"},"comment":{"url":"https://api.github.com/repos/LeanKit-Labs/eslint-config-leankit/issues/comments/168698545","html_url":"https://github.com/LeanKit-Labs/eslint-config-leankit/pull/4#issuecomment-168698545","issue_url":"https://api.github.com/repos/LeanKit-Labs/eslint-config-leankit/issues/4","id":168698545,"user":{"login":"dcneiner","id":106974,"avatar_url":"https://avatars.githubusercontent.com/u/106974?v=3","gravatar_id":"","url":"https://api.github.com/users/dcneiner","html_url":"https://github.com/dcneiner","followers_url":"https://api.github.com/users/dcneiner/followers","following_url":"https://api.github.com/users/dcneiner/following{/other_user}","gists_url":"https://api.github.com/users/dcneiner/gists{/gist_id}","starred_url":"https://api.github.com/users/dcneiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcneiner/subscriptions","organizations_url":"https://api.github.com/users/dcneiner/orgs","repos_url":"https://api.github.com/users/dcneiner/repos","events_url":"https://api.github.com/users/dcneiner/events{/privacy}","received_events_url":"https://api.github.com/users/dcneiner/received_events","type":"User","site_admin":false},"created_at":"2016-01-04T14:56:45Z","updated_at":"2016-01-04T14:56:45Z","body":"@elijahmanor I think `no-console` needs to be kept as a warning, or else our projects won't build when we intentionally add debug console statements. Is there another workaround I am not thinking about here?"}}