{"action":"created","issue":{"url":"https://api.github.com/repos/jsk-ros-pkg/jsk_common/issues/1458","repository_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_common","labels_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_common/issues/1458/labels{/name}","comments_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_common/issues/1458/comments","events_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_common/issues/1458/events","html_url":"https://github.com/jsk-ros-pkg/jsk_common/pull/1458","id":181620132,"number":1458,"title":"Add interactive dynamic tf publisher","user":{"login":"iory","id":4690682,"avatar_url":"https://avatars.githubusercontent.com/u/4690682?v=3","gravatar_id":"","url":"https://api.github.com/users/iory","html_url":"https://github.com/iory","followers_url":"https://api.github.com/users/iory/followers","following_url":"https://api.github.com/users/iory/following{/other_user}","gists_url":"https://api.github.com/users/iory/gists{/gist_id}","starred_url":"https://api.github.com/users/iory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iory/subscriptions","organizations_url":"https://api.github.com/users/iory/orgs","repos_url":"https://api.github.com/users/iory/repos","events_url":"https://api.github.com/users/iory/events{/privacy}","received_events_url":"https://api.github.com/users/iory/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-10-07T09:14:51Z","updated_at":"2016-10-14T06:37:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jsk-ros-pkg/jsk_common/pulls/1458","html_url":"https://github.com/jsk-ros-pkg/jsk_common/pull/1458","diff_url":"https://github.com/jsk-ros-pkg/jsk_common/pull/1458.diff","patch_url":"https://github.com/jsk-ros-pkg/jsk_common/pull/1458.patch"},"body":"![myimage](https://cloud.githubusercontent.com/assets/4690682/19184832/e6240f12-8cb9-11e6-82ff-11706f28be1a.gif)\r\n"},"comment":{"url":"https://api.github.com/repos/jsk-ros-pkg/jsk_common/issues/comments/253721216","html_url":"https://github.com/jsk-ros-pkg/jsk_common/pull/1458#issuecomment-253721216","issue_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_common/issues/1458","id":253721216,"user":{"login":"wkentaro","id":4310419,"avatar_url":"https://avatars.githubusercontent.com/u/4310419?v=3","gravatar_id":"","url":"https://api.github.com/users/wkentaro","html_url":"https://github.com/wkentaro","followers_url":"https://api.github.com/users/wkentaro/followers","following_url":"https://api.github.com/users/wkentaro/following{/other_user}","gists_url":"https://api.github.com/users/wkentaro/gists{/gist_id}","starred_url":"https://api.github.com/users/wkentaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkentaro/subscriptions","organizations_url":"https://api.github.com/users/wkentaro/orgs","repos_url":"https://api.github.com/users/wkentaro/repos","events_url":"https://api.github.com/users/wkentaro/events{/privacy}","received_events_url":"https://api.github.com/users/wkentaro/received_events","type":"User","site_admin":false},"created_at":"2016-10-14T06:37:10Z","updated_at":"2016-10-14T06:37:10Z","body":"I don't have enough time for a detailed investigation, but I'd like to provide below comments\r\n\r\n- this seems have similar feature as nodes in jsk_interactive_marker, so why not you place this there?\r\n- [jsk_interactive_marker/marker_6dof](https://github.com/jsk-ros-pkg/jsk_visualization/blob/master/jsk_interactive_markers/jsk_interactive_marker/src/marker_6dof.cpp), [jsk_interactive_marker/transformable_object_server](https://github.com/jsk-ros-pkg/jsk_visualization/blob/master/jsk_interactive_markers/jsk_interactive_marker/src/transformable_server_sample.cpp) is same but this node is simpler, so if there is no nodes which has same feature in jsk_interactive_marker, I support you adding this to jsk-ros-pkg.\r\n- Though I agree with adding this node, maybe you can firstly send PR to [interactive_markers](https://github.com/ros-visualization/interactive_markers) as a proposal.\r\n\r\nIMO, the procedure you should do is\r\n\r\n1. Ask to @YuOhara and @mmurooka if same featured node exists, seems know much about this kind of node with participation to DRC.\r\n2. If not 1, check if same featured node exists in [jsk_interactive_marker](https://github.com/jsk-ros-pkg/jsk_visualization/tree/master/jsk_interactive_markers/jsk_interactive_marker).\r\n3. Send proposal PR to [interactive_markers](https://github.com/ros-visualization/interactive_markers).\r\n4. If not 2, send PR to [jsk_interactive_marker](https://github.com/jsk-ros-pkg/jsk_visualization/tree/master/jsk_interactive_markers/jsk_interactive_marker) to place this node there."}}
{"actor":{"display_login":"wkentaro"}}