{"action":"created","issue":{"url":"https://api.github.com/repos/biopython/biopython/issues/968","repository_url":"https://api.github.com/repos/biopython/biopython","labels_url":"https://api.github.com/repos/biopython/biopython/issues/968/labels{/name}","comments_url":"https://api.github.com/repos/biopython/biopython/issues/968/comments","events_url":"https://api.github.com/repos/biopython/biopython/issues/968/events","html_url":"https://github.com/biopython/biopython/pull/968","id":182501718,"number":968,"title":"Added a feature for changing the id of an PDB.Entity's child.","user":{"login":"Bernhard10","id":662579,"avatar_url":"https://avatars.githubusercontent.com/u/662579?v=3","gravatar_id":"","url":"https://api.github.com/users/Bernhard10","html_url":"https://github.com/Bernhard10","followers_url":"https://api.github.com/users/Bernhard10/followers","following_url":"https://api.github.com/users/Bernhard10/following{/other_user}","gists_url":"https://api.github.com/users/Bernhard10/gists{/gist_id}","starred_url":"https://api.github.com/users/Bernhard10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bernhard10/subscriptions","organizations_url":"https://api.github.com/users/Bernhard10/orgs","repos_url":"https://api.github.com/users/Bernhard10/repos","events_url":"https://api.github.com/users/Bernhard10/events{/privacy}","received_events_url":"https://api.github.com/users/Bernhard10/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-10-12T11:29:00Z","updated_at":"2016-10-21T10:02:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/biopython/biopython/pulls/968","html_url":"https://github.com/biopython/biopython/pull/968","diff_url":"https://github.com/biopython/biopython/pull/968.diff","patch_url":"https://github.com/biopython/biopython/pull/968.patch"},"body":"When changing the id of an `PDB.Entity`, it has to be changed at 2 places:\r\n*) The element's attribute `id`\r\n*) The parent's `child_dict`.\r\nFurther more, the `full_id` has to be invalidated recursively for all children.\r\n\r\nI do not know biopython well enough to know if there are many usecases for this feature and if there are other pitfalls that I missed, but this is a first reference implementation how changing an entity's id could work.\r\n\r\nA probably better implementation would be making `Entity.id` a property with a costum setter method that uses the `.parent` attribute to acces the parent's `child_dict`\r\nIf this feature makes sense, I could implement this alternative version."},"comment":{"url":"https://api.github.com/repos/biopython/biopython/issues/comments/255343031","html_url":"https://github.com/biopython/biopython/pull/968#issuecomment-255343031","issue_url":"https://api.github.com/repos/biopython/biopython/issues/968","id":255343031,"user":{"login":"peterjc","id":63959,"avatar_url":"https://avatars.githubusercontent.com/u/63959?v=3","gravatar_id":"","url":"https://api.github.com/users/peterjc","html_url":"https://github.com/peterjc","followers_url":"https://api.github.com/users/peterjc/followers","following_url":"https://api.github.com/users/peterjc/following{/other_user}","gists_url":"https://api.github.com/users/peterjc/gists{/gist_id}","starred_url":"https://api.github.com/users/peterjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterjc/subscriptions","organizations_url":"https://api.github.com/users/peterjc/orgs","repos_url":"https://api.github.com/users/peterjc/repos","events_url":"https://api.github.com/users/peterjc/events{/privacy}","received_events_url":"https://api.github.com/users/peterjc/received_events","type":"User","site_admin":false},"created_at":"2016-10-21T10:02:12Z","updated_at":"2016-10-21T10:02:12Z","body":"This looks good. Two questions before I squash-and-mege this:\r\n\r\nAre you happy to be named in the NEWS and CONTRIB files?\r\n\r\nAre you happy to dual licence your Biopython contributions under both the current Biopython Licence Agreement and the 3-Clause BSD license? See #898 \r\n\r\nThanks!"}}
{"actor":{"display_login":"peterjc"}}