{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/74544671","id":74544671,"diff_hunk":"@@ -30,3 +33,29 @@ def test_good_ajax_request(self):\n         self.assertEqual(total, 2)\n         self.assertDictEqual(callback, {'objectName': 'Conditional'})\n         self.assertEqual(self.xmodule.poll_answer, 'No')\n+\n+    def test_poll_export_with_unescaped_characters_xml(self):\n+        \"\"\"\n+        Make sure that poll_module will export fine if its xml contains\n+        unescaped_characters.\n+        \"\"\"\n+        module_system = DummySystem(load_error_modules=True)\n+        id_generator = Mock()\n+        id_generator.target_course_id = self.xmodule.course_id\n+        sample_poll_xml = '''\n+        <poll_question display_name=\"Poll Question\">\n+            <p>How old are you?</p>\n+            <answer id=\"less18\">18</answer>\n+        </poll_question>\n+        '''\n+\n+        output = PollDescriptor.from_xml(sample_poll_xml, module_system, id_generator)\n+        # Update the answer with invalid character.\n+        invalid_characters_poll_answer = output.answers[0]\n+        invalid_characters_poll_answer['text'] = '< 18'  # invalid greater-than character.\n+        output.answers[0] = invalid_characters_poll_answer\n+        output.save()\n+\n+        xml = output.definition_to_xml(None)\n+        child_texts = xml.xpath('//text()')  # extract texts of all children.","path":"common/lib/xmodule/xmodule/tests/test_poll.py","position":39,"original_position":39,"commit_id":"bbc8ed48127b169c21a217a86c4192de3af75aa2","original_commit_id":"bbc8ed48127b169c21a217a86c4192de3af75aa2","user":{"login":"mushtaqak","id":6991154,"avatar_url":"https://avatars.githubusercontent.com/u/6991154?v=3","gravatar_id":"","url":"https://api.github.com/users/mushtaqak","html_url":"https://github.com/mushtaqak","followers_url":"https://api.github.com/users/mushtaqak/followers","following_url":"https://api.github.com/users/mushtaqak/following{/other_user}","gists_url":"https://api.github.com/users/mushtaqak/gists{/gist_id}","starred_url":"https://api.github.com/users/mushtaqak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mushtaqak/subscriptions","organizations_url":"https://api.github.com/users/mushtaqak/orgs","repos_url":"https://api.github.com/users/mushtaqak/repos","events_url":"https://api.github.com/users/mushtaqak/events{/privacy}","received_events_url":"https://api.github.com/users/mushtaqak/received_events","type":"User","site_admin":false},"body":"Same here. I would prefer comment before the line just to be consistent.\r\n","created_at":"2016-08-12T06:00:48Z","updated_at":"2016-08-12T06:00:48Z","html_url":"https://github.com/edx/edx-platform/pull/13219#discussion_r74544671","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/13219","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/74544671"},"html":{"href":"https://github.com/edx/edx-platform/pull/13219#discussion_r74544671"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13219"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/13219","id":80959987,"html_url":"https://github.com/edx/edx-platform/pull/13219","diff_url":"https://github.com/edx/edx-platform/pull/13219.diff","patch_url":"https://github.com/edx/edx-platform/pull/13219.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/13219","number":13219,"state":"open","locked":false,"title":"Escape characters for poll-module export","user":{"login":"Shrhawk","id":7054417,"avatar_url":"https://avatars.githubusercontent.com/u/7054417?v=3","gravatar_id":"","url":"https://api.github.com/users/Shrhawk","html_url":"https://github.com/Shrhawk","followers_url":"https://api.github.com/users/Shrhawk/followers","following_url":"https://api.github.com/users/Shrhawk/following{/other_user}","gists_url":"https://api.github.com/users/Shrhawk/gists{/gist_id}","starred_url":"https://api.github.com/users/Shrhawk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shrhawk/subscriptions","organizations_url":"https://api.github.com/users/Shrhawk/orgs","repos_url":"https://api.github.com/users/Shrhawk/repos","events_url":"https://api.github.com/users/Shrhawk/events{/privacy}","received_events_url":"https://api.github.com/users/Shrhawk/received_events","type":"User","site_admin":false},"body":"[PLAT-1036](https://openedx.atlassian.net/browse/PLAT-1036)\r\n","created_at":"2016-08-11T13:45:54Z","updated_at":"2016-08-12T06:00:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d74f4ad7e01ea1312d1e848ab0c85218cd760a4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/13219/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/13219/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/13219/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/bbc8ed48127b169c21a217a86c4192de3af75aa2","head":{"label":"edx:shr/bug/PLAT-1036-export-fails-with-poll-module","ref":"shr/bug/PLAT-1036-export-fails-with-poll-module","sha":"bbc8ed48127b169c21a217a86c4192de3af75aa2","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-08-11T21:01:32Z","pushed_at":"2016-08-12T00:01:03Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":806891,"stargazers_count":2711,"watchers_count":2711,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1637,"mirror_url":null,"open_issues_count":131,"forks":1637,"open_issues":131,"watchers":2711,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"b7c9ef9bfeee8322b693cf704f26dc789c1bec1e","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-08-11T21:01:32Z","pushed_at":"2016-08-12T00:01:03Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":806891,"stargazers_count":2711,"watchers_count":2711,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1637,"mirror_url":null,"open_issues_count":131,"forks":1637,"open_issues":131,"watchers":2711,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13219"},"html":{"href":"https://github.com/edx/edx-platform/pull/13219"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/13219"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/13219/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13219/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13219/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/bbc8ed48127b169c21a217a86c4192de3af75aa2"}}}}
{"actor":{"display_login":"mushtaqak"}}