{"action":"created","comment":{"url":"https://api.github.com/repos/nest/nest-simulator/pulls/comments/91868954","pull_request_review_id":12378226,"id":91868954,"diff_hunk":"@@ -1087,8 +1087,8 @@ nest::ConnectionManager::get_connections( DictionaryDatum params ) const\n \n // Helper method, implemented as operator<<(), that removes ConnectionIDs from\n // input deque and appends them to output deque.\n-static inline std::deque< nest::ConnectionID >& operator<<(\n-  std::deque< nest::ConnectionID >& out,\n+static inline std::deque< nest::ConnectionID >&\n+join_deques( std::deque< nest::ConnectionID >& out,","path":"nestkernel/connection_manager.cpp","position":7,"original_position":7,"commit_id":"9fa19e44e51ec4280c6b7313f71b3d371151c5f9","original_commit_id":"9fa19e44e51ec4280c6b7313f71b3d371151c5f9","user":{"login":"heplesser","id":1059644,"avatar_url":"https://avatars.githubusercontent.com/u/1059644?v=3","gravatar_id":"","url":"https://api.github.com/users/heplesser","html_url":"https://github.com/heplesser","followers_url":"https://api.github.com/users/heplesser/followers","following_url":"https://api.github.com/users/heplesser/following{/other_user}","gists_url":"https://api.github.com/users/heplesser/gists{/gist_id}","starred_url":"https://api.github.com/users/heplesser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heplesser/subscriptions","organizations_url":"https://api.github.com/users/heplesser/orgs","repos_url":"https://api.github.com/users/heplesser/repos","events_url":"https://api.github.com/users/heplesser/events{/privacy}","received_events_url":"https://api.github.com/users/heplesser/received_events","type":"User","site_admin":false},"body":"The `static` is confusing here, since this use of `static` is so rare hardly anyone knows what it does. It does make sense, as it makes sure there won't be any conflicts with functions of same name and signature defined in other cpp-files, but you should probably comment on this here.\r\n\r\nI am also wondering a little about the name. Maybe `extend( connectome, conns_in_thread )` or `add_to( connectome, conns_in_thread )` would make for even more readable code.\r\n\r\n","created_at":"2016-12-11T23:27:43Z","updated_at":"2016-12-11T23:27:43Z","html_url":"https://github.com/nest/nest-simulator/pull/587#discussion_r91868954","pull_request_url":"https://api.github.com/repos/nest/nest-simulator/pulls/587","_links":{"self":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/comments/91868954"},"html":{"href":"https://github.com/nest/nest-simulator/pull/587#discussion_r91868954"},"pull_request":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/587"}}},"pull_request":{"url":"https://api.github.com/repos/nest/nest-simulator/pulls/587","id":97471481,"html_url":"https://github.com/nest/nest-simulator/pull/587","diff_url":"https://github.com/nest/nest-simulator/pull/587.diff","patch_url":"https://github.com/nest/nest-simulator/pull/587.patch","issue_url":"https://api.github.com/repos/nest/nest-simulator/issues/587","number":587,"state":"open","locked":false,"title":"Replace operator<< with regular function to avoid issues with K compiler","user":{"login":"jakobj","id":1562742,"avatar_url":"https://avatars.githubusercontent.com/u/1562742?v=3","gravatar_id":"","url":"https://api.github.com/users/jakobj","html_url":"https://github.com/jakobj","followers_url":"https://api.github.com/users/jakobj/followers","following_url":"https://api.github.com/users/jakobj/following{/other_user}","gists_url":"https://api.github.com/users/jakobj/gists{/gist_id}","starred_url":"https://api.github.com/users/jakobj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakobj/subscriptions","organizations_url":"https://api.github.com/users/jakobj/orgs","repos_url":"https://api.github.com/users/jakobj/repos","events_url":"https://api.github.com/users/jakobj/events{/privacy}","received_events_url":"https://api.github.com/users/jakobj/received_events","type":"User","site_admin":false},"body":"This PR fixes an incompatibility with the K compiler as discussed in #581.\r\nI suggest @janhahne and @JanneM as reviewers.","created_at":"2016-12-11T20:31:16Z","updated_at":"2016-12-11T23:27:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e619689c6f9270538f6120109bdcb2d3e4ae90d","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/nest/nest-simulator/milestones/3","html_url":"https://github.com/nest/nest-simulator/milestone/3","labels_url":"https://api.github.com/repos/nest/nest-simulator/milestones/3/labels","id":2141267,"number":3,"title":"NEST 2.12","description":"Last release in NEST 2 series","creator":{"login":"heplesser","id":1059644,"avatar_url":"https://avatars.githubusercontent.com/u/1059644?v=3","gravatar_id":"","url":"https://api.github.com/users/heplesser","html_url":"https://github.com/heplesser","followers_url":"https://api.github.com/users/heplesser/followers","following_url":"https://api.github.com/users/heplesser/following{/other_user}","gists_url":"https://api.github.com/users/heplesser/gists{/gist_id}","starred_url":"https://api.github.com/users/heplesser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heplesser/subscriptions","organizations_url":"https://api.github.com/users/heplesser/orgs","repos_url":"https://api.github.com/users/heplesser/repos","events_url":"https://api.github.com/users/heplesser/events{/privacy}","received_events_url":"https://api.github.com/users/heplesser/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":10,"state":"open","created_at":"2016-11-17T08:24:22Z","updated_at":"2016-12-11T23:24:18Z","due_on":"2016-12-22T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/nest/nest-simulator/pulls/587/commits","review_comments_url":"https://api.github.com/repos/nest/nest-simulator/pulls/587/comments","review_comment_url":"https://api.github.com/repos/nest/nest-simulator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nest/nest-simulator/issues/587/comments","statuses_url":"https://api.github.com/repos/nest/nest-simulator/statuses/9fa19e44e51ec4280c6b7313f71b3d371151c5f9","head":{"label":"jakobj:fix581/operator_overloading_on_K","ref":"fix581/operator_overloading_on_K","sha":"9fa19e44e51ec4280c6b7313f71b3d371151c5f9","user":{"login":"jakobj","id":1562742,"avatar_url":"https://avatars.githubusercontent.com/u/1562742?v=3","gravatar_id":"","url":"https://api.github.com/users/jakobj","html_url":"https://github.com/jakobj","followers_url":"https://api.github.com/users/jakobj/followers","following_url":"https://api.github.com/users/jakobj/following{/other_user}","gists_url":"https://api.github.com/users/jakobj/gists{/gist_id}","starred_url":"https://api.github.com/users/jakobj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakobj/subscriptions","organizations_url":"https://api.github.com/users/jakobj/orgs","repos_url":"https://api.github.com/users/jakobj/repos","events_url":"https://api.github.com/users/jakobj/events{/privacy}","received_events_url":"https://api.github.com/users/jakobj/received_events","type":"User","site_admin":false},"repo":{"id":35839448,"name":"nest-simulator","full_name":"jakobj/nest-simulator","owner":{"login":"jakobj","id":1562742,"avatar_url":"https://avatars.githubusercontent.com/u/1562742?v=3","gravatar_id":"","url":"https://api.github.com/users/jakobj","html_url":"https://github.com/jakobj","followers_url":"https://api.github.com/users/jakobj/followers","following_url":"https://api.github.com/users/jakobj/following{/other_user}","gists_url":"https://api.github.com/users/jakobj/gists{/gist_id}","starred_url":"https://api.github.com/users/jakobj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakobj/subscriptions","organizations_url":"https://api.github.com/users/jakobj/orgs","repos_url":"https://api.github.com/users/jakobj/repos","events_url":"https://api.github.com/users/jakobj/events{/privacy}","received_events_url":"https://api.github.com/users/jakobj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jakobj/nest-simulator","description":"The NEST simulator","fork":true,"url":"https://api.github.com/repos/jakobj/nest-simulator","forks_url":"https://api.github.com/repos/jakobj/nest-simulator/forks","keys_url":"https://api.github.com/repos/jakobj/nest-simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jakobj/nest-simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jakobj/nest-simulator/teams","hooks_url":"https://api.github.com/repos/jakobj/nest-simulator/hooks","issue_events_url":"https://api.github.com/repos/jakobj/nest-simulator/issues/events{/number}","events_url":"https://api.github.com/repos/jakobj/nest-simulator/events","assignees_url":"https://api.github.com/repos/jakobj/nest-simulator/assignees{/user}","branches_url":"https://api.github.com/repos/jakobj/nest-simulator/branches{/branch}","tags_url":"https://api.github.com/repos/jakobj/nest-simulator/tags","blobs_url":"https://api.github.com/repos/jakobj/nest-simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jakobj/nest-simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jakobj/nest-simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/jakobj/nest-simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jakobj/nest-simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/jakobj/nest-simulator/languages","stargazers_url":"https://api.github.com/repos/jakobj/nest-simulator/stargazers","contributors_url":"https://api.github.com/repos/jakobj/nest-simulator/contributors","subscribers_url":"https://api.github.com/repos/jakobj/nest-simulator/subscribers","subscription_url":"https://api.github.com/repos/jakobj/nest-simulator/subscription","commits_url":"https://api.github.com/repos/jakobj/nest-simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/jakobj/nest-simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/jakobj/nest-simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/jakobj/nest-simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/jakobj/nest-simulator/contents/{+path}","compare_url":"https://api.github.com/repos/jakobj/nest-simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jakobj/nest-simulator/merges","archive_url":"https://api.github.com/repos/jakobj/nest-simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jakobj/nest-simulator/downloads","issues_url":"https://api.github.com/repos/jakobj/nest-simulator/issues{/number}","pulls_url":"https://api.github.com/repos/jakobj/nest-simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/jakobj/nest-simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/jakobj/nest-simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jakobj/nest-simulator/labels{/name}","releases_url":"https://api.github.com/repos/jakobj/nest-simulator/releases{/id}","deployments_url":"https://api.github.com/repos/jakobj/nest-simulator/deployments","created_at":"2015-05-18T19:59:20Z","updated_at":"2016-02-02T13:45:05Z","pushed_at":"2016-12-11T23:09:34Z","git_url":"git://github.com/jakobj/nest-simulator.git","ssh_url":"git@github.com:jakobj/nest-simulator.git","clone_url":"https://github.com/jakobj/nest-simulator.git","svn_url":"https://github.com/jakobj/nest-simulator","homepage":null,"size":19363,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nest:master","ref":"master","sha":"17226fb80649964487fbfde4e9e619e97586066c","user":{"login":"nest","id":2377019,"avatar_url":"https://avatars.githubusercontent.com/u/2377019?v=3","gravatar_id":"","url":"https://api.github.com/users/nest","html_url":"https://github.com/nest","followers_url":"https://api.github.com/users/nest/followers","following_url":"https://api.github.com/users/nest/following{/other_user}","gists_url":"https://api.github.com/users/nest/gists{/gist_id}","starred_url":"https://api.github.com/users/nest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nest/subscriptions","organizations_url":"https://api.github.com/users/nest/orgs","repos_url":"https://api.github.com/users/nest/repos","events_url":"https://api.github.com/users/nest/events{/privacy}","received_events_url":"https://api.github.com/users/nest/received_events","type":"Organization","site_admin":false},"repo":{"id":33933892,"name":"nest-simulator","full_name":"nest/nest-simulator","owner":{"login":"nest","id":2377019,"avatar_url":"https://avatars.githubusercontent.com/u/2377019?v=3","gravatar_id":"","url":"https://api.github.com/users/nest","html_url":"https://github.com/nest","followers_url":"https://api.github.com/users/nest/followers","following_url":"https://api.github.com/users/nest/following{/other_user}","gists_url":"https://api.github.com/users/nest/gists{/gist_id}","starred_url":"https://api.github.com/users/nest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nest/subscriptions","organizations_url":"https://api.github.com/users/nest/orgs","repos_url":"https://api.github.com/users/nest/repos","events_url":"https://api.github.com/users/nest/events{/privacy}","received_events_url":"https://api.github.com/users/nest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nest/nest-simulator","description":"The NEST simulator","fork":false,"url":"https://api.github.com/repos/nest/nest-simulator","forks_url":"https://api.github.com/repos/nest/nest-simulator/forks","keys_url":"https://api.github.com/repos/nest/nest-simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nest/nest-simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nest/nest-simulator/teams","hooks_url":"https://api.github.com/repos/nest/nest-simulator/hooks","issue_events_url":"https://api.github.com/repos/nest/nest-simulator/issues/events{/number}","events_url":"https://api.github.com/repos/nest/nest-simulator/events","assignees_url":"https://api.github.com/repos/nest/nest-simulator/assignees{/user}","branches_url":"https://api.github.com/repos/nest/nest-simulator/branches{/branch}","tags_url":"https://api.github.com/repos/nest/nest-simulator/tags","blobs_url":"https://api.github.com/repos/nest/nest-simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nest/nest-simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nest/nest-simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/nest/nest-simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nest/nest-simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/nest/nest-simulator/languages","stargazers_url":"https://api.github.com/repos/nest/nest-simulator/stargazers","contributors_url":"https://api.github.com/repos/nest/nest-simulator/contributors","subscribers_url":"https://api.github.com/repos/nest/nest-simulator/subscribers","subscription_url":"https://api.github.com/repos/nest/nest-simulator/subscription","commits_url":"https://api.github.com/repos/nest/nest-simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/nest/nest-simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/nest/nest-simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/nest/nest-simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/nest/nest-simulator/contents/{+path}","compare_url":"https://api.github.com/repos/nest/nest-simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nest/nest-simulator/merges","archive_url":"https://api.github.com/repos/nest/nest-simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nest/nest-simulator/downloads","issues_url":"https://api.github.com/repos/nest/nest-simulator/issues{/number}","pulls_url":"https://api.github.com/repos/nest/nest-simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/nest/nest-simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/nest/nest-simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nest/nest-simulator/labels{/name}","releases_url":"https://api.github.com/repos/nest/nest-simulator/releases{/id}","deployments_url":"https://api.github.com/repos/nest/nest-simulator/deployments","created_at":"2015-04-14T13:39:12Z","updated_at":"2016-12-09T23:02:58Z","pushed_at":"2016-12-11T23:09:34Z","git_url":"git://github.com/nest/nest-simulator.git","ssh_url":"git@github.com:nest/nest-simulator.git","clone_url":"https://github.com/nest/nest-simulator.git","svn_url":"https://github.com/nest/nest-simulator","homepage":null,"size":38106,"stargazers_count":94,"watchers_count":94,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":98,"mirror_url":null,"open_issues_count":178,"forks":98,"open_issues":178,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/587"},"html":{"href":"https://github.com/nest/nest-simulator/pull/587"},"issue":{"href":"https://api.github.com/repos/nest/nest-simulator/issues/587"},"comments":{"href":"https://api.github.com/repos/nest/nest-simulator/issues/587/comments"},"review_comments":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/587/comments"},"review_comment":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/587/commits"},"statuses":{"href":"https://api.github.com/repos/nest/nest-simulator/statuses/9fa19e44e51ec4280c6b7313f71b3d371151c5f9"}}}}
{"actor":{"display_login":"heplesser"}}