{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/926","repository_url":"https://api.github.com/repos/Microsoft/ChakraCore","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/926/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/926/comments","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/926/events","html_url":"https://github.com/Microsoft/ChakraCore/pull/926","id":153317998,"number":926,"title":"New debugging APIs","user":{"login":"agarwal-sandeep","id":12059066,"avatar_url":"https://avatars.githubusercontent.com/u/12059066?v=3","gravatar_id":"","url":"https://api.github.com/users/agarwal-sandeep","html_url":"https://github.com/agarwal-sandeep","followers_url":"https://api.github.com/users/agarwal-sandeep/followers","following_url":"https://api.github.com/users/agarwal-sandeep/following{/other_user}","gists_url":"https://api.github.com/users/agarwal-sandeep/gists{/gist_id}","starred_url":"https://api.github.com/users/agarwal-sandeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agarwal-sandeep/subscriptions","organizations_url":"https://api.github.com/users/agarwal-sandeep/orgs","repos_url":"https://api.github.com/users/agarwal-sandeep/repos","events_url":"https://api.github.com/users/agarwal-sandeep/events{/privacy}","received_events_url":"https://api.github.com/users/agarwal-sandeep/received_events","type":"User","site_admin":false},"labels":[{"id":307793006,"url":"https://api.github.com/repos/Microsoft/ChakraCore/labels/cla-not-required","name":"cla-not-required","color":"009800","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-05-05T20:27:52Z","updated_at":"2016-12-21T05:16:19Z","closed_at":"2016-05-11T16:59:30Z","pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/926","html_url":"https://github.com/Microsoft/ChakraCore/pull/926","diff_url":"https://github.com/Microsoft/ChakraCore/pull/926.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/926.patch"},"body":"This PR adds debugging APIs to _ChakraCore_ and test debugger to ch.\n\nSample tests are under [test\\Debugger](https://github.com/Microsoft/ChakraCore/tree/JsRTDebugging/test/Debugger). Once this PR is merged next PR will port existing PDM based debugger tests to run with ch/ChakraCore. I have already run those tests and don’t see any issue.\n\nNew APIs are prefixed with _JsDiag_ to group them under a pseudo namespace, in future if we plan to have other diagnostic APIs this will help.\nThere are a total of 17 JsDiag\\* APIs. Currently the APIs on only exposed in ChakraCore once we have windows review this will be exposed in Chakra as well.\n\nWith this change the binary size of ChakraCore/Chakra increase by about a max of 19KB across all architectures which is acceptable.\n\nTo demonstrate the use, capabilities and completeness of these APIs [Node-ChakraCore](https://github.com/nodejs/node-chakracore) have been enhanced to provide debugging support with [VSCode](https://code.visualstudio.com/) (no change to VSCode required). ChakraCore code in Node-ChakraCore is synced with this PR commit. The code is available at https://github.com/agarwal-sandeep/node-chakracore/tree/debugging\n\nThere is some more investigation required to make [Node-Inspector](https://github.com/node-inspector/node-inspector) work with Node-ChakraCore. I am working on it.\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments/268437571","html_url":"https://github.com/Microsoft/ChakraCore/pull/926#issuecomment-268437571","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/926","id":268437571,"user":{"login":"MidoriYakumo","id":6872220,"avatar_url":"https://avatars.githubusercontent.com/u/6872220?v=3","gravatar_id":"","url":"https://api.github.com/users/MidoriYakumo","html_url":"https://github.com/MidoriYakumo","followers_url":"https://api.github.com/users/MidoriYakumo/followers","following_url":"https://api.github.com/users/MidoriYakumo/following{/other_user}","gists_url":"https://api.github.com/users/MidoriYakumo/gists{/gist_id}","starred_url":"https://api.github.com/users/MidoriYakumo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MidoriYakumo/subscriptions","organizations_url":"https://api.github.com/users/MidoriYakumo/orgs","repos_url":"https://api.github.com/users/MidoriYakumo/repos","events_url":"https://api.github.com/users/MidoriYakumo/events{/privacy}","received_events_url":"https://api.github.com/users/MidoriYakumo/received_events","type":"User","site_admin":false},"created_at":"2016-12-21T05:16:19Z","updated_at":"2016-12-21T05:16:19Z","body":"Is this Visual Studio compatible? I can not try to step into Javascript code in Visual Studio with codes mix with C++ and Javascript"}}
{"actor":{"display_login":"MidoriYakumo"}}