{"action":"closed","issue":{"url":"https://api.github.com/repos/nim-lang/Nim/issues/2128","repository_url":"https://api.github.com/repos/nim-lang/Nim","labels_url":"https://api.github.com/repos/nim-lang/Nim/issues/2128/labels{/name}","comments_url":"https://api.github.com/repos/nim-lang/Nim/issues/2128/comments","events_url":"https://api.github.com/repos/nim-lang/Nim/issues/2128/events","html_url":"https://github.com/nim-lang/Nim/issues/2128","id":57701421,"number":2128,"title":"Use standard compiler flags in build script","user":{"login":"infinity0","id":78398,"avatar_url":"https://avatars.githubusercontent.com/u/78398?v=3","gravatar_id":"","url":"https://api.github.com/users/infinity0","html_url":"https://github.com/infinity0","followers_url":"https://api.github.com/users/infinity0/followers","following_url":"https://api.github.com/users/infinity0/following{/other_user}","gists_url":"https://api.github.com/users/infinity0/gists{/gist_id}","starred_url":"https://api.github.com/users/infinity0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinity0/subscriptions","organizations_url":"https://api.github.com/users/infinity0/orgs","repos_url":"https://api.github.com/users/infinity0/repos","events_url":"https://api.github.com/users/infinity0/events{/privacy}","received_events_url":"https://api.github.com/users/infinity0/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nim-lang/Nim/labels/Feature","name":"Feature","color":"0080f0"},{"url":"https://api.github.com/repos/nim-lang/Nim/labels/Installation","name":"Installation","color":"eb6420"},{"url":"https://api.github.com/repos/nim-lang/Nim/labels/Low%20Priority","name":"Low Priority","color":"4ed600"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-02-14T18:15:09Z","updated_at":"2016-06-05T13:31:27Z","closed_at":"2016-06-05T13:31:27Z","body":"`build.sh` should honour standard flags, namely `LDFLAGS`, `CFLAGS` instead of its own custom forms. Also, they should accept changes from the environment, e.g.:\r\n\r\n~~~~\r\n[..]\r\nCFLAGS=\"${CFLAGS:-} -w -O3 -fno-strict-aliasing\"\r\nLDFLAGS=\"${LDFLAGS:-}\"\r\n[..]\r\ncase $uos in\r\n  *linux* ) \r\n    myos=\"linux\" \r\n    LDFLAGS=\"$LDFLAGS -ldl -lm\"\r\n~~~~\r\n\r\nThis would make it easier for distributions to make tweaks such as https://wiki.debian.org/Hardening.\r\n\r\n(This would also obsolete the need for `--extraBuildArgs`)"}}
{"actor":{"display_login":"dom96"}}