{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19021","repository_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19021/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19021/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19021/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/issues/19021","id":186104659,"number":19021,"title":"melee_test unit test failures","user":{"login":"mutability","id":3055062,"avatar_url":"https://avatars.githubusercontent.com/u/3055062?v=3","gravatar_id":"","url":"https://api.github.com/users/mutability","html_url":"https://github.com/mutability","followers_url":"https://api.github.com/users/mutability/followers","following_url":"https://api.github.com/users/mutability/following{/other_user}","gists_url":"https://api.github.com/users/mutability/gists{/gist_id}","starred_url":"https://api.github.com/users/mutability/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mutability/subscriptions","organizations_url":"https://api.github.com/users/mutability/orgs","repos_url":"https://api.github.com/users/mutability/repos","events_url":"https://api.github.com/users/mutability/events{/privacy}","received_events_url":"https://api.github.com/users/mutability/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-29T22:29:38Z","updated_at":"2016-10-30T04:24:04Z","closed_at":null,"body":"Using 9d41e9fd4a4c453b799faa43a60d469295cf8eff\r\n\r\n```\r\n-------------------------------------------------------------------------------\r\nCharacter attacking a zombie\r\n  8/8/8/8, 3 all skills, two-by-four\r\n      Then: The chance to hit is between 75% and 85%\r\n-------------------------------------------------------------------------------\r\nmelee_test.cpp:68\r\n...............................................................................\r\n\r\nmelee_test.cpp:62: FAILED:\r\n  REQUIRE( prob < high )\r\nwith expansion:\r\n  0.8964f < 0.85f\r\nwith messages:\r\n  Zombie has get_dodge() == 0.000000\r\n  Details for TestCharacter\r\n  get_hit() == 6.5\r\n  get_hit_base() == 6.5\r\n  get_hit_weapon() == 4.5\r\n  \r\n\r\n-------------------------------------------------------------------------------\r\nCharacter attacking a manhack\r\n  8/8/8/8, 3 all skills, two-by-four\r\n      Then: The chance to hit is between 35% and 45%\r\n-------------------------------------------------------------------------------\r\nmelee_test.cpp:96\r\n...............................................................................\r\n\r\nmelee_test.cpp:62: FAILED:\r\n  REQUIRE( prob < high )\r\nwith expansion:\r\n  0.5217f < 0.45f\r\nwith messages:\r\n  Manhack has get_dodge() == 6.000000\r\n  Details for TestCharacter\r\n  get_hit() == 6.5\r\n  get_hit_base() == 6.5\r\n  get_hit_weapon() == 4.5\r\n  \r\n\r\n-------------------------------------------------------------------------------\r\nCharacter attacking a manhack\r\n  10/10/10/10, 8 all skills, katana\r\n      Then: The chance to hit is between 65% and 75%\r\n-------------------------------------------------------------------------------\r\nmelee_test.cpp:96\r\n...............................................................................\r\n\r\nmelee_test.cpp:62: FAILED:\r\n  REQUIRE( prob < high )\r\nwith expansion:\r\n  0.9499f < 0.75f\r\nwith messages:\r\n  Manhack has get_dodge() == 6.000000\r\n  Details for TestCharacter\r\n  get_hit() == 14.5\r\n  get_hit_base() == 14.5\r\n  get_hit_weapon() == 12\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/257131371","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/issues/19021#issuecomment-257131371","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19021","id":257131371,"user":{"login":"Coolthulhu","id":1878860,"avatar_url":"https://avatars.githubusercontent.com/u/1878860?v=3","gravatar_id":"","url":"https://api.github.com/users/Coolthulhu","html_url":"https://github.com/Coolthulhu","followers_url":"https://api.github.com/users/Coolthulhu/followers","following_url":"https://api.github.com/users/Coolthulhu/following{/other_user}","gists_url":"https://api.github.com/users/Coolthulhu/gists{/gist_id}","starred_url":"https://api.github.com/users/Coolthulhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coolthulhu/subscriptions","organizations_url":"https://api.github.com/users/Coolthulhu/orgs","repos_url":"https://api.github.com/users/Coolthulhu/repos","events_url":"https://api.github.com/users/Coolthulhu/events{/privacy}","received_events_url":"https://api.github.com/users/Coolthulhu/received_events","type":"User","site_admin":false},"created_at":"2016-10-30T04:24:04Z","updated_at":"2016-10-30T04:24:04Z","body":"Found it:\r\nhttps://github.com/CleverRaven/Cataclysm-DDA/pull/18697/files#diff-90b4b16185aad709bdd9e732caa26aaaR154\r\n\r\nThe original code was `weapon skill / 3`, except for unarmed which got `unarmed / 2`. New code is just plain `weapon skill`, making it much stronger than expected."}}
{"actor":{"display_login":"Coolthulhu"}}