{"action":"created","issue":{"url":"https://api.github.com/repos/emanoelxavier/openid2go/issues/10","repository_url":"https://api.github.com/repos/emanoelxavier/openid2go","labels_url":"https://api.github.com/repos/emanoelxavier/openid2go/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/emanoelxavier/openid2go/issues/10/comments","events_url":"https://api.github.com/repos/emanoelxavier/openid2go/issues/10/events","html_url":"https://github.com/emanoelxavier/openid2go/pull/10","id":191905471,"number":10,"title":"Configurable http client","user":{"login":"kujenga","id":4854867,"avatar_url":"https://avatars.githubusercontent.com/u/4854867?v=3","gravatar_id":"","url":"https://api.github.com/users/kujenga","html_url":"https://github.com/kujenga","followers_url":"https://api.github.com/users/kujenga/followers","following_url":"https://api.github.com/users/kujenga/following{/other_user}","gists_url":"https://api.github.com/users/kujenga/gists{/gist_id}","starred_url":"https://api.github.com/users/kujenga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kujenga/subscriptions","organizations_url":"https://api.github.com/users/kujenga/orgs","repos_url":"https://api.github.com/users/kujenga/repos","events_url":"https://api.github.com/users/kujenga/events{/privacy}","received_events_url":"https://api.github.com/users/kujenga/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-28T02:17:04Z","updated_at":"2016-11-29T16:03:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/emanoelxavier/openid2go/pulls/10","html_url":"https://github.com/emanoelxavier/openid2go/pull/10","diff_url":"https://github.com/emanoelxavier/openid2go/pull/10.diff","patch_url":"https://github.com/emanoelxavier/openid2go/pull/10.patch"},"body":"This PR implements the configuration functionality needed to support the use of this library on Google App Engine, which is not capable of using the standard `net/http` library in Golang. The issue is documented here: https://github.com/emanoelxavier/openid2go/issues/9\r\n\r\nThis PR is implemented in the simplest possible way, with only internal changes being made to the codebase, except for an additional `HTTPGetter` configuration function.\r\n\r\nIt might be more idiomatic to use the `context` package rather than passing the literal request around in each method header, but since that `context` isn't currently used, this implementation seemed to make the most sense for now."},"comment":{"url":"https://api.github.com/repos/emanoelxavier/openid2go/issues/comments/263612498","html_url":"https://github.com/emanoelxavier/openid2go/pull/10#issuecomment-263612498","issue_url":"https://api.github.com/repos/emanoelxavier/openid2go/issues/10","id":263612498,"user":{"login":"emanoelxavier","id":4925909,"avatar_url":"https://avatars.githubusercontent.com/u/4925909?v=3","gravatar_id":"","url":"https://api.github.com/users/emanoelxavier","html_url":"https://github.com/emanoelxavier","followers_url":"https://api.github.com/users/emanoelxavier/followers","following_url":"https://api.github.com/users/emanoelxavier/following{/other_user}","gists_url":"https://api.github.com/users/emanoelxavier/gists{/gist_id}","starred_url":"https://api.github.com/users/emanoelxavier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emanoelxavier/subscriptions","organizations_url":"https://api.github.com/users/emanoelxavier/orgs","repos_url":"https://api.github.com/users/emanoelxavier/repos","events_url":"https://api.github.com/users/emanoelxavier/events{/privacy}","received_events_url":"https://api.github.com/users/emanoelxavier/received_events","type":"User","site_admin":false},"created_at":"2016-11-29T16:03:04Z","updated_at":"2016-11-29T16:03:04Z","body":"Looks like the pull request is missing the updates on the test files. Please include the necessary test changes as well and run both the unit and integration tests described on the Readme of the package. I expect that the existing integration tests should pass without any change but I recommend adding a new one that uses the new extension point with the urlfetch client, the new test will help validating the approach and also serve as an example on how to use the new extension point."}}
{"actor":{"display_login":"emanoelxavier"}}