{"action":"created","issue":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/15354","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/15354/labels{/name}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/15354/comments","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/15354/events","html_url":"https://github.com/TrinityCore/TrinityCore/pull/15354","id":103138974,"number":15354,"title":"[WIP] Spells/Death Grip fix. The pull effect shouldn't work on some bosses","user":{"login":"chaodhib","id":6612710,"avatar_url":"https://avatars.githubusercontent.com/u/6612710?v=3","gravatar_id":"","url":"https://api.github.com/users/chaodhib","html_url":"https://github.com/chaodhib","followers_url":"https://api.github.com/users/chaodhib/followers","following_url":"https://api.github.com/users/chaodhib/following{/other_user}","gists_url":"https://api.github.com/users/chaodhib/gists{/gist_id}","starred_url":"https://api.github.com/users/chaodhib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaodhib/subscriptions","organizations_url":"https://api.github.com/users/chaodhib/orgs","repos_url":"https://api.github.com/users/chaodhib/repos","events_url":"https://api.github.com/users/chaodhib/events{/privacy}","received_events_url":"https://api.github.com/users/chaodhib/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Branch-3.3.5a","name":"Branch-3.3.5a","color":"188846"},{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Comp-Core","name":"Comp-Core","color":"FF6600"},{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Feedback-FixOutdatedMissingWIP","name":"Feedback-FixOutdatedMissingWIP","color":"d7e102"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":16,"created_at":"2015-08-25T23:38:25Z","updated_at":"2016-01-17T19:59:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15354","html_url":"https://github.com/TrinityCore/TrinityCore/pull/15354","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/15354.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/15354.patch"},"body":"Fixes https://github.com/TrinityCore/TrinityCore/issues/14870\r\n\r\n* An extra flag CREATURE_FLAG_EXTRA_NO_PULL_BY_GRIP has been created to handle the immunity to the pull component of the spell Death Grip\r\n* a spell script has been written to the third spell called by the Death Grip chain in order to send to the client the message \"immune\" if the creature has the flag mentioned above.\r\n* the 3 spell scripts are grouped together in the spell_dk for convenience.\r\n\r\nPatchwerk (16028) is taken as the dummy:\r\n![wowscrnshot_082615_012611](https://cloud.githubusercontent.com/assets/6612710/9482281/c47f795a-4b92-11e5-95e8-e3a9f6b6778d.jpg)\r\nThis screenshot is taken after the fix is applied. It show that indeed the taunt is applied but not the pull.\r\n\r\nFor some reason, the dk didnt got the same threat as the highest in list and only got aggro for the 3s duration of the taunt. Unsure if this is linked to the PR.\r\n\r\nTo do:\r\n- [X] implement the extra flag\r\n- [X] Make use of it to implement the immunity\r\n- [x] Message \"immune\" should be shown to the caster if the mob is immune to the pull effect.\r\n- [ ] Investigate the thing about the bugged threat. See if it's linked to this PR.\r\n- [ ] Update the flag of each boss. And then, update the known exceptions. (SQL queries)"},"comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments/172371891","html_url":"https://github.com/TrinityCore/TrinityCore/pull/15354#issuecomment-172371891","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/15354","id":172371891,"user":{"login":"ccrs","id":4329612,"avatar_url":"https://avatars.githubusercontent.com/u/4329612?v=3","gravatar_id":"","url":"https://api.github.com/users/ccrs","html_url":"https://github.com/ccrs","followers_url":"https://api.github.com/users/ccrs/followers","following_url":"https://api.github.com/users/ccrs/following{/other_user}","gists_url":"https://api.github.com/users/ccrs/gists{/gist_id}","starred_url":"https://api.github.com/users/ccrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccrs/subscriptions","organizations_url":"https://api.github.com/users/ccrs/orgs","repos_url":"https://api.github.com/users/ccrs/repos","events_url":"https://api.github.com/users/ccrs/events{/privacy}","received_events_url":"https://api.github.com/users/ccrs/received_events","type":"User","site_admin":false},"created_at":"2016-01-17T19:59:04Z","updated_at":"2016-01-17T19:59:04Z","body":"I vote for the second solution :P "}}