{"action":"created","comment":{"url":"https://api.github.com/repos/AVnu/Open-AVB/pulls/comments/54264806","id":54264806,"diff_hunk":"@@ -949,6 +949,8 @@ class PTPMessagePathDelayRespFollowUp:public PTPMessageCommon {\n \tPortIdentity *requestingPortIdentity;\n \n \tPTPMessagePathDelayRespFollowUp(void) { }\n+\n+\tconst static uint16_t SEQID_DIFF_THRESHOLD = 4;","path":"daemons/gptp/common/avbts_message.hpp","position":5,"original_position":5,"commit_id":"4b8a463056425e310985f4c408a0c30ec67b4700","original_commit_id":"4b8a463056425e310985f4c408a0c30ec67b4700","user":{"login":"davidcemin","id":219919,"avatar_url":"https://avatars.githubusercontent.com/u/219919?v=3","gravatar_id":"","url":"https://api.github.com/users/davidcemin","html_url":"https://github.com/davidcemin","followers_url":"https://api.github.com/users/davidcemin/followers","following_url":"https://api.github.com/users/davidcemin/following{/other_user}","gists_url":"https://api.github.com/users/davidcemin/gists{/gist_id}","starred_url":"https://api.github.com/users/davidcemin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidcemin/subscriptions","organizations_url":"https://api.github.com/users/davidcemin/orgs","repos_url":"https://api.github.com/users/davidcemin/repos","events_url":"https://api.github.com/users/davidcemin/events{/privacy}","received_events_url":"https://api.github.com/users/davidcemin/received_events","type":"User","site_admin":false},"body":"I forgot to remove this one.","created_at":"2016-02-26T16:24:00Z","updated_at":"2016-02-26T16:24:00Z","html_url":"https://github.com/AVnu/Open-AVB/pull/349#discussion_r54264806","pull_request_url":"https://api.github.com/repos/AVnu/Open-AVB/pulls/349","_links":{"self":{"href":"https://api.github.com/repos/AVnu/Open-AVB/pulls/comments/54264806"},"html":{"href":"https://github.com/AVnu/Open-AVB/pull/349#discussion_r54264806"},"pull_request":{"href":"https://api.github.com/repos/AVnu/Open-AVB/pulls/349"}}},"pull_request":{"url":"https://api.github.com/repos/AVnu/Open-AVB/pulls/349","id":59106328,"html_url":"https://github.com/AVnu/Open-AVB/pull/349","diff_url":"https://github.com/AVnu/Open-AVB/pull/349.diff","patch_url":"https://github.com/AVnu/Open-AVB/pull/349.patch","issue_url":"https://api.github.com/repos/AVnu/Open-AVB/issues/349","number":349,"state":"open","locked":false,"title":"Handles lost of Resp and Fup messages","user":{"login":"davidcemin","id":219919,"avatar_url":"https://avatars.githubusercontent.com/u/219919?v=3","gravatar_id":"","url":"https://api.github.com/users/davidcemin","html_url":"https://github.com/davidcemin","followers_url":"https://api.github.com/users/davidcemin/followers","following_url":"https://api.github.com/users/davidcemin/following{/other_user}","gists_url":"https://api.github.com/users/davidcemin/gists{/gist_id}","starred_url":"https://api.github.com/users/davidcemin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidcemin/subscriptions","organizations_url":"https://api.github.com/users/davidcemin/orgs","repos_url":"https://api.github.com/users/davidcemin/repos","events_url":"https://api.github.com/users/davidcemin/events{/privacy}","received_events_url":"https://api.github.com/users/davidcemin/received_events","type":"User","site_admin":false},"body":"This patch fixes Issue #138 and potentially others as well. There are other open issues that are related to handle fups/resp lost messages and making gPTP not being asCapable. The Issue #138 was fixed and I am retesting the whole thing to see if at this point nothing got broken and if there are other ones fixed as well. \r\n\r\nI will be posting the other results directly on the open issues if I have good news. For now I want to create the pull request (which is quite small - but required lot of investigation and testing) so people can review and we can move forward and integrate this into Avnu's repo.","created_at":"2016-02-11T22:43:59Z","updated_at":"2016-02-26T16:24:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce02f091a8ba779ee1bd94634f50e6c309855b74","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AVnu/Open-AVB/pulls/349/commits","review_comments_url":"https://api.github.com/repos/AVnu/Open-AVB/pulls/349/comments","review_comment_url":"https://api.github.com/repos/AVnu/Open-AVB/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AVnu/Open-AVB/issues/349/comments","statuses_url":"https://api.github.com/repos/AVnu/Open-AVB/statuses/4b8a463056425e310985f4c408a0c30ec67b4700","head":{"label":"davidcemin:task-gptpv3","ref":"task-gptpv3","sha":"4b8a463056425e310985f4c408a0c30ec67b4700","user":{"login":"davidcemin","id":219919,"avatar_url":"https://avatars.githubusercontent.com/u/219919?v=3","gravatar_id":"","url":"https://api.github.com/users/davidcemin","html_url":"https://github.com/davidcemin","followers_url":"https://api.github.com/users/davidcemin/followers","following_url":"https://api.github.com/users/davidcemin/following{/other_user}","gists_url":"https://api.github.com/users/davidcemin/gists{/gist_id}","starred_url":"https://api.github.com/users/davidcemin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidcemin/subscriptions","organizations_url":"https://api.github.com/users/davidcemin/orgs","repos_url":"https://api.github.com/users/davidcemin/repos","events_url":"https://api.github.com/users/davidcemin/events{/privacy}","received_events_url":"https://api.github.com/users/davidcemin/received_events","type":"User","site_admin":false},"repo":{"id":44438338,"name":"Open-AVB","full_name":"davidcemin/Open-AVB","owner":{"login":"davidcemin","id":219919,"avatar_url":"https://avatars.githubusercontent.com/u/219919?v=3","gravatar_id":"","url":"https://api.github.com/users/davidcemin","html_url":"https://github.com/davidcemin","followers_url":"https://api.github.com/users/davidcemin/followers","following_url":"https://api.github.com/users/davidcemin/following{/other_user}","gists_url":"https://api.github.com/users/davidcemin/gists{/gist_id}","starred_url":"https://api.github.com/users/davidcemin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidcemin/subscriptions","organizations_url":"https://api.github.com/users/davidcemin/orgs","repos_url":"https://api.github.com/users/davidcemin/repos","events_url":"https://api.github.com/users/davidcemin/events{/privacy}","received_events_url":"https://api.github.com/users/davidcemin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidcemin/Open-AVB","description":"Open AVB - an AVnu sponsored repository for Audio/Video Bridging technology","fork":true,"url":"https://api.github.com/repos/davidcemin/Open-AVB","forks_url":"https://api.github.com/repos/davidcemin/Open-AVB/forks","keys_url":"https://api.github.com/repos/davidcemin/Open-AVB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidcemin/Open-AVB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidcemin/Open-AVB/teams","hooks_url":"https://api.github.com/repos/davidcemin/Open-AVB/hooks","issue_events_url":"https://api.github.com/repos/davidcemin/Open-AVB/issues/events{/number}","events_url":"https://api.github.com/repos/davidcemin/Open-AVB/events","assignees_url":"https://api.github.com/repos/davidcemin/Open-AVB/assignees{/user}","branches_url":"https://api.github.com/repos/davidcemin/Open-AVB/branches{/branch}","tags_url":"https://api.github.com/repos/davidcemin/Open-AVB/tags","blobs_url":"https://api.github.com/repos/davidcemin/Open-AVB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidcemin/Open-AVB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidcemin/Open-AVB/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidcemin/Open-AVB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidcemin/Open-AVB/statuses/{sha}","languages_url":"https://api.github.com/repos/davidcemin/Open-AVB/languages","stargazers_url":"https://api.github.com/repos/davidcemin/Open-AVB/stargazers","contributors_url":"https://api.github.com/repos/davidcemin/Open-AVB/contributors","subscribers_url":"https://api.github.com/repos/davidcemin/Open-AVB/subscribers","subscription_url":"https://api.github.com/repos/davidcemin/Open-AVB/subscription","commits_url":"https://api.github.com/repos/davidcemin/Open-AVB/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidcemin/Open-AVB/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidcemin/Open-AVB/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidcemin/Open-AVB/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidcemin/Open-AVB/contents/{+path}","compare_url":"https://api.github.com/repos/davidcemin/Open-AVB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidcemin/Open-AVB/merges","archive_url":"https://api.github.com/repos/davidcemin/Open-AVB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidcemin/Open-AVB/downloads","issues_url":"https://api.github.com/repos/davidcemin/Open-AVB/issues{/number}","pulls_url":"https://api.github.com/repos/davidcemin/Open-AVB/pulls{/number}","milestones_url":"https://api.github.com/repos/davidcemin/Open-AVB/milestones{/number}","notifications_url":"https://api.github.com/repos/davidcemin/Open-AVB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidcemin/Open-AVB/labels{/name}","releases_url":"https://api.github.com/repos/davidcemin/Open-AVB/releases{/id}","deployments_url":"https://api.github.com/repos/davidcemin/Open-AVB/deployments","created_at":"2015-10-17T13:35:57Z","updated_at":"2015-10-17T13:35:59Z","pushed_at":"2016-02-25T17:41:41Z","git_url":"git://github.com/davidcemin/Open-AVB.git","ssh_url":"git@github.com:davidcemin/Open-AVB.git","clone_url":"https://github.com/davidcemin/Open-AVB.git","svn_url":"https://github.com/davidcemin/Open-AVB","homepage":"","size":12104,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AVnu:feature-gptp-next","ref":"feature-gptp-next","sha":"943f9e36c98df7852fadecdcfa88e2eb1feb4ce8","user":{"login":"AVnu","id":700271,"avatar_url":"https://avatars.githubusercontent.com/u/700271?v=3","gravatar_id":"","url":"https://api.github.com/users/AVnu","html_url":"https://github.com/AVnu","followers_url":"https://api.github.com/users/AVnu/followers","following_url":"https://api.github.com/users/AVnu/following{/other_user}","gists_url":"https://api.github.com/users/AVnu/gists{/gist_id}","starred_url":"https://api.github.com/users/AVnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AVnu/subscriptions","organizations_url":"https://api.github.com/users/AVnu/orgs","repos_url":"https://api.github.com/users/AVnu/repos","events_url":"https://api.github.com/users/AVnu/events{/privacy}","received_events_url":"https://api.github.com/users/AVnu/received_events","type":"Organization","site_admin":false},"repo":{"id":5693778,"name":"Open-AVB","full_name":"AVnu/Open-AVB","owner":{"login":"AVnu","id":700271,"avatar_url":"https://avatars.githubusercontent.com/u/700271?v=3","gravatar_id":"","url":"https://api.github.com/users/AVnu","html_url":"https://github.com/AVnu","followers_url":"https://api.github.com/users/AVnu/followers","following_url":"https://api.github.com/users/AVnu/following{/other_user}","gists_url":"https://api.github.com/users/AVnu/gists{/gist_id}","starred_url":"https://api.github.com/users/AVnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AVnu/subscriptions","organizations_url":"https://api.github.com/users/AVnu/orgs","repos_url":"https://api.github.com/users/AVnu/repos","events_url":"https://api.github.com/users/AVnu/events{/privacy}","received_events_url":"https://api.github.com/users/AVnu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AVnu/Open-AVB","description":"Open AVB - an AVnu sponsored repository for Audio/Video Bridging technology","fork":false,"url":"https://api.github.com/repos/AVnu/Open-AVB","forks_url":"https://api.github.com/repos/AVnu/Open-AVB/forks","keys_url":"https://api.github.com/repos/AVnu/Open-AVB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AVnu/Open-AVB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AVnu/Open-AVB/teams","hooks_url":"https://api.github.com/repos/AVnu/Open-AVB/hooks","issue_events_url":"https://api.github.com/repos/AVnu/Open-AVB/issues/events{/number}","events_url":"https://api.github.com/repos/AVnu/Open-AVB/events","assignees_url":"https://api.github.com/repos/AVnu/Open-AVB/assignees{/user}","branches_url":"https://api.github.com/repos/AVnu/Open-AVB/branches{/branch}","tags_url":"https://api.github.com/repos/AVnu/Open-AVB/tags","blobs_url":"https://api.github.com/repos/AVnu/Open-AVB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AVnu/Open-AVB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AVnu/Open-AVB/git/refs{/sha}","trees_url":"https://api.github.com/repos/AVnu/Open-AVB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AVnu/Open-AVB/statuses/{sha}","languages_url":"https://api.github.com/repos/AVnu/Open-AVB/languages","stargazers_url":"https://api.github.com/repos/AVnu/Open-AVB/stargazers","contributors_url":"https://api.github.com/repos/AVnu/Open-AVB/contributors","subscribers_url":"https://api.github.com/repos/AVnu/Open-AVB/subscribers","subscription_url":"https://api.github.com/repos/AVnu/Open-AVB/subscription","commits_url":"https://api.github.com/repos/AVnu/Open-AVB/commits{/sha}","git_commits_url":"https://api.github.com/repos/AVnu/Open-AVB/git/commits{/sha}","comments_url":"https://api.github.com/repos/AVnu/Open-AVB/comments{/number}","issue_comment_url":"https://api.github.com/repos/AVnu/Open-AVB/issues/comments{/number}","contents_url":"https://api.github.com/repos/AVnu/Open-AVB/contents/{+path}","compare_url":"https://api.github.com/repos/AVnu/Open-AVB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AVnu/Open-AVB/merges","archive_url":"https://api.github.com/repos/AVnu/Open-AVB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AVnu/Open-AVB/downloads","issues_url":"https://api.github.com/repos/AVnu/Open-AVB/issues{/number}","pulls_url":"https://api.github.com/repos/AVnu/Open-AVB/pulls{/number}","milestones_url":"https://api.github.com/repos/AVnu/Open-AVB/milestones{/number}","notifications_url":"https://api.github.com/repos/AVnu/Open-AVB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AVnu/Open-AVB/labels{/name}","releases_url":"https://api.github.com/repos/AVnu/Open-AVB/releases{/id}","deployments_url":"https://api.github.com/repos/AVnu/Open-AVB/deployments","created_at":"2012-09-05T21:19:39Z","updated_at":"2016-02-25T15:05:01Z","pushed_at":"2016-02-25T17:41:42Z","git_url":"git://github.com/AVnu/Open-AVB.git","ssh_url":"git@github.com:AVnu/Open-AVB.git","clone_url":"https://github.com/AVnu/Open-AVB.git","svn_url":"https://github.com/AVnu/Open-AVB","homepage":"","size":13253,"stargazers_count":81,"watchers_count":81,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":85,"mirror_url":null,"open_issues_count":86,"forks":85,"open_issues":86,"watchers":81,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AVnu/Open-AVB/pulls/349"},"html":{"href":"https://github.com/AVnu/Open-AVB/pull/349"},"issue":{"href":"https://api.github.com/repos/AVnu/Open-AVB/issues/349"},"comments":{"href":"https://api.github.com/repos/AVnu/Open-AVB/issues/349/comments"},"review_comments":{"href":"https://api.github.com/repos/AVnu/Open-AVB/pulls/349/comments"},"review_comment":{"href":"https://api.github.com/repos/AVnu/Open-AVB/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AVnu/Open-AVB/pulls/349/commits"},"statuses":{"href":"https://api.github.com/repos/AVnu/Open-AVB/statuses/4b8a463056425e310985f4c408a0c30ec67b4700"}}}}