{"action":"created","issue":{"url":"https://api.github.com/repos/restrictcontentpro/restrict-content-pro/issues/474","repository_url":"https://api.github.com/repos/restrictcontentpro/restrict-content-pro","labels_url":"https://api.github.com/repos/restrictcontentpro/restrict-content-pro/issues/474/labels{/name}","comments_url":"https://api.github.com/repos/restrictcontentpro/restrict-content-pro/issues/474/comments","events_url":"https://api.github.com/repos/restrictcontentpro/restrict-content-pro/issues/474/events","html_url":"https://github.com/restrictcontentpro/restrict-content-pro/issues/474","id":151431540,"number":474,"title":"Non-translatable string in templates/paypal-express-confirm.php line 27","user":{"login":"michaelbeil","id":4752949,"avatar_url":"https://avatars.githubusercontent.com/u/4752949?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelbeil","html_url":"https://github.com/michaelbeil","followers_url":"https://api.github.com/users/michaelbeil/followers","following_url":"https://api.github.com/users/michaelbeil/following{/other_user}","gists_url":"https://api.github.com/users/michaelbeil/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelbeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelbeil/subscriptions","organizations_url":"https://api.github.com/users/michaelbeil/orgs","repos_url":"https://api.github.com/users/michaelbeil/repos","events_url":"https://api.github.com/users/michaelbeil/events{/privacy}","received_events_url":"https://api.github.com/users/michaelbeil/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/restrictcontentpro/restrict-content-pro/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/restrictcontentpro/restrict-content-pro/labels/Has%20PR","name":"Has PR","color":"009800"},{"url":"https://api.github.com/repos/restrictcontentpro/restrict-content-pro/labels/needs-testing","name":"needs-testing","color":"0b02e1"}],"state":"open","locked":false,"assignee":{"login":"michaelbeil","id":4752949,"avatar_url":"https://avatars.githubusercontent.com/u/4752949?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelbeil","html_url":"https://github.com/michaelbeil","followers_url":"https://api.github.com/users/michaelbeil/followers","following_url":"https://api.github.com/users/michaelbeil/following{/other_user}","gists_url":"https://api.github.com/users/michaelbeil/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelbeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelbeil/subscriptions","organizations_url":"https://api.github.com/users/michaelbeil/orgs","repos_url":"https://api.github.com/users/michaelbeil/repos","events_url":"https://api.github.com/users/michaelbeil/events{/privacy}","received_events_url":"https://api.github.com/users/michaelbeil/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/restrictcontentpro/restrict-content-pro/milestones/43","html_url":"https://github.com/restrictcontentpro/restrict-content-pro/milestones/2.5.4","labels_url":"https://api.github.com/repos/restrictcontentpro/restrict-content-pro/milestones/43/labels","id":1738788,"number":43,"title":"2.5.4","description":null,"creator":{"login":"pippinsplugins","id":1034109,"avatar_url":"https://avatars.githubusercontent.com/u/1034109?v=3","gravatar_id":"","url":"https://api.github.com/users/pippinsplugins","html_url":"https://github.com/pippinsplugins","followers_url":"https://api.github.com/users/pippinsplugins/followers","following_url":"https://api.github.com/users/pippinsplugins/following{/other_user}","gists_url":"https://api.github.com/users/pippinsplugins/gists{/gist_id}","starred_url":"https://api.github.com/users/pippinsplugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pippinsplugins/subscriptions","organizations_url":"https://api.github.com/users/pippinsplugins/orgs","repos_url":"https://api.github.com/users/pippinsplugins/repos","events_url":"https://api.github.com/users/pippinsplugins/events{/privacy}","received_events_url":"https://api.github.com/users/pippinsplugins/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":4,"state":"open","created_at":"2016-04-29T15:26:51Z","updated_at":"2016-05-04T20:37:10Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-04-27T16:36:48Z","updated_at":"2016-05-05T16:51:45Z","closed_at":null,"body":"Currently we are outputting a dynamic string here:\r\n\r\n```php\r\necho sprintf( __( 'Every %d %s(s)', $rcp_checkout_details['subscription']['duration'], 'rcp' ),\r\n    $rcp_checkout_details['subscription']['duration'],\r\n    $rcp_checkout_details['subscription']['duration_unit']\r\n``` \r\n\r\nThis could be better:\r\n```php\r\nprintf( _n( 'Every %1$d %2$s', 'Every %1$d %2$ss', 'rcp' ),\r\n    esc_html( $rcp_checkout_details['subscription']['duration'] ),\r\n    esc_html( $rcp_checkout_details['subscription']['duration_unit'] )\r\n);\r\n```\r\n\r\nEven still, we have an issue with the duration and duration units that are added dynamically to the string based on the RCP settings.  "},"comment":{"url":"https://api.github.com/repos/restrictcontentpro/restrict-content-pro/issues/comments/217208489","html_url":"https://github.com/restrictcontentpro/restrict-content-pro/issues/474#issuecomment-217208489","issue_url":"https://api.github.com/repos/restrictcontentpro/restrict-content-pro/issues/474","id":217208489,"user":{"login":"michaelbeil","id":4752949,"avatar_url":"https://avatars.githubusercontent.com/u/4752949?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelbeil","html_url":"https://github.com/michaelbeil","followers_url":"https://api.github.com/users/michaelbeil/followers","following_url":"https://api.github.com/users/michaelbeil/following{/other_user}","gists_url":"https://api.github.com/users/michaelbeil/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelbeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelbeil/subscriptions","organizations_url":"https://api.github.com/users/michaelbeil/orgs","repos_url":"https://api.github.com/users/michaelbeil/repos","events_url":"https://api.github.com/users/michaelbeil/events{/privacy}","received_events_url":"https://api.github.com/users/michaelbeil/received_events","type":"User","site_admin":false},"created_at":"2016-05-05T16:51:45Z","updated_at":"2016-05-05T16:51:45Z","body":"Reviewed and looks good. "}}