{"action":"created","comment":{"url":"https://api.github.com/repos/ravendb/ravendb/pulls/comments/87392561","pull_request_review_id":8006198,"id":87392561,"diff_hunk":"@@ -883,6 +883,9 @@ private IndexingPerformanceStats ExecuteIndexingBatch(IndexingBatchForIndex batc\n                     }\n \n                     var keepTrying = true;\n+                    //Here we make sure that the database isn't been disposed so we won't advance the indexing etags on \n+                    //aborted batches (see RavenDB-5603 related changes)\n+                    if (context.Database.Disposed == false)","path":"Raven.Database/Indexing/IndexingExecuter.cs","position":6,"original_position":6,"commit_id":"34f0c8e4b91a9ae341342e010771a5693b51bc2e","original_commit_id":"34f0c8e4b91a9ae341342e010771a5693b51bc2e","user":{"login":"ayende","id":116915,"avatar_url":"https://avatars.githubusercontent.com/u/116915?v=3","gravatar_id":"","url":"https://api.github.com/users/ayende","html_url":"https://github.com/ayende","followers_url":"https://api.github.com/users/ayende/followers","following_url":"https://api.github.com/users/ayende/following{/other_user}","gists_url":"https://api.github.com/users/ayende/gists{/gist_id}","starred_url":"https://api.github.com/users/ayende/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayende/subscriptions","organizations_url":"https://api.github.com/users/ayende/orgs","repos_url":"https://api.github.com/users/ayende/repos","events_url":"https://api.github.com/users/ayende/events{/privacy}","received_events_url":"https://api.github.com/users/ayende/received_events","type":"User","site_admin":false},"body":"You added an if statement on a big statement without {}","created_at":"2016-11-10T13:23:57Z","updated_at":"2016-11-10T13:23:57Z","html_url":"https://github.com/ravendb/ravendb/pull/853#discussion_r87392561","pull_request_url":"https://api.github.com/repos/ravendb/ravendb/pulls/853","_links":{"self":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/comments/87392561"},"html":{"href":"https://github.com/ravendb/ravendb/pull/853#discussion_r87392561"},"pull_request":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/853"}}},"pull_request":{"url":"https://api.github.com/repos/ravendb/ravendb/pulls/853","id":93147265,"html_url":"https://github.com/ravendb/ravendb/pull/853","diff_url":"https://github.com/ravendb/ravendb/pull/853.diff","patch_url":"https://github.com/ravendb/ravendb/pull/853.patch","issue_url":"https://api.github.com/repos/ravendb/ravendb/issues/853","number":853,"state":"open","locked":false,"title":"RavenDB-5603","user":{"login":"talweiss1982","id":8511829,"avatar_url":"https://avatars.githubusercontent.com/u/8511829?v=3","gravatar_id":"","url":"https://api.github.com/users/talweiss1982","html_url":"https://github.com/talweiss1982","followers_url":"https://api.github.com/users/talweiss1982/followers","following_url":"https://api.github.com/users/talweiss1982/following{/other_user}","gists_url":"https://api.github.com/users/talweiss1982/gists{/gist_id}","starred_url":"https://api.github.com/users/talweiss1982/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talweiss1982/subscriptions","organizations_url":"https://api.github.com/users/talweiss1982/orgs","repos_url":"https://api.github.com/users/talweiss1982/repos","events_url":"https://api.github.com/users/talweiss1982/events{/privacy}","received_events_url":"https://api.github.com/users/talweiss1982/received_events","type":"User","site_admin":false},"body":"* Will check for Database disposed flag before executing batches\r\n* Will not advance the etags of index batches if database is been disposed because we don't throw now and the code used to assume we would\r\n* Index/Transformer caches were been used in an unsafe manner causing key not found exceptions.","created_at":"2016-11-10T13:08:57Z","updated_at":"2016-11-10T13:23:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9b5510675e5376fc89ad03e62ba667b82008541","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ravendb/ravendb/pulls/853/commits","review_comments_url":"https://api.github.com/repos/ravendb/ravendb/pulls/853/comments","review_comment_url":"https://api.github.com/repos/ravendb/ravendb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ravendb/ravendb/issues/853/comments","statuses_url":"https://api.github.com/repos/ravendb/ravendb/statuses/34f0c8e4b91a9ae341342e010771a5693b51bc2e","head":{"label":"talweiss1982:RavenDB-5603","ref":"RavenDB-5603","sha":"34f0c8e4b91a9ae341342e010771a5693b51bc2e","user":{"login":"talweiss1982","id":8511829,"avatar_url":"https://avatars.githubusercontent.com/u/8511829?v=3","gravatar_id":"","url":"https://api.github.com/users/talweiss1982","html_url":"https://github.com/talweiss1982","followers_url":"https://api.github.com/users/talweiss1982/followers","following_url":"https://api.github.com/users/talweiss1982/following{/other_user}","gists_url":"https://api.github.com/users/talweiss1982/gists{/gist_id}","starred_url":"https://api.github.com/users/talweiss1982/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talweiss1982/subscriptions","organizations_url":"https://api.github.com/users/talweiss1982/orgs","repos_url":"https://api.github.com/users/talweiss1982/repos","events_url":"https://api.github.com/users/talweiss1982/events{/privacy}","received_events_url":"https://api.github.com/users/talweiss1982/received_events","type":"User","site_admin":false},"repo":{"id":25456966,"name":"ravendb","full_name":"talweiss1982/ravendb","owner":{"login":"talweiss1982","id":8511829,"avatar_url":"https://avatars.githubusercontent.com/u/8511829?v=3","gravatar_id":"","url":"https://api.github.com/users/talweiss1982","html_url":"https://github.com/talweiss1982","followers_url":"https://api.github.com/users/talweiss1982/followers","following_url":"https://api.github.com/users/talweiss1982/following{/other_user}","gists_url":"https://api.github.com/users/talweiss1982/gists{/gist_id}","starred_url":"https://api.github.com/users/talweiss1982/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talweiss1982/subscriptions","organizations_url":"https://api.github.com/users/talweiss1982/orgs","repos_url":"https://api.github.com/users/talweiss1982/repos","events_url":"https://api.github.com/users/talweiss1982/events{/privacy}","received_events_url":"https://api.github.com/users/talweiss1982/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/talweiss1982/ravendb","description":"A linq enabled document database for .NET","fork":true,"url":"https://api.github.com/repos/talweiss1982/ravendb","forks_url":"https://api.github.com/repos/talweiss1982/ravendb/forks","keys_url":"https://api.github.com/repos/talweiss1982/ravendb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/talweiss1982/ravendb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/talweiss1982/ravendb/teams","hooks_url":"https://api.github.com/repos/talweiss1982/ravendb/hooks","issue_events_url":"https://api.github.com/repos/talweiss1982/ravendb/issues/events{/number}","events_url":"https://api.github.com/repos/talweiss1982/ravendb/events","assignees_url":"https://api.github.com/repos/talweiss1982/ravendb/assignees{/user}","branches_url":"https://api.github.com/repos/talweiss1982/ravendb/branches{/branch}","tags_url":"https://api.github.com/repos/talweiss1982/ravendb/tags","blobs_url":"https://api.github.com/repos/talweiss1982/ravendb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/talweiss1982/ravendb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/talweiss1982/ravendb/git/refs{/sha}","trees_url":"https://api.github.com/repos/talweiss1982/ravendb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/talweiss1982/ravendb/statuses/{sha}","languages_url":"https://api.github.com/repos/talweiss1982/ravendb/languages","stargazers_url":"https://api.github.com/repos/talweiss1982/ravendb/stargazers","contributors_url":"https://api.github.com/repos/talweiss1982/ravendb/contributors","subscribers_url":"https://api.github.com/repos/talweiss1982/ravendb/subscribers","subscription_url":"https://api.github.com/repos/talweiss1982/ravendb/subscription","commits_url":"https://api.github.com/repos/talweiss1982/ravendb/commits{/sha}","git_commits_url":"https://api.github.com/repos/talweiss1982/ravendb/git/commits{/sha}","comments_url":"https://api.github.com/repos/talweiss1982/ravendb/comments{/number}","issue_comment_url":"https://api.github.com/repos/talweiss1982/ravendb/issues/comments{/number}","contents_url":"https://api.github.com/repos/talweiss1982/ravendb/contents/{+path}","compare_url":"https://api.github.com/repos/talweiss1982/ravendb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/talweiss1982/ravendb/merges","archive_url":"https://api.github.com/repos/talweiss1982/ravendb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/talweiss1982/ravendb/downloads","issues_url":"https://api.github.com/repos/talweiss1982/ravendb/issues{/number}","pulls_url":"https://api.github.com/repos/talweiss1982/ravendb/pulls{/number}","milestones_url":"https://api.github.com/repos/talweiss1982/ravendb/milestones{/number}","notifications_url":"https://api.github.com/repos/talweiss1982/ravendb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/talweiss1982/ravendb/labels{/name}","releases_url":"https://api.github.com/repos/talweiss1982/ravendb/releases{/id}","deployments_url":"https://api.github.com/repos/talweiss1982/ravendb/deployments","created_at":"2014-10-20T08:14:04Z","updated_at":"2016-04-18T15:25:47Z","pushed_at":"2016-11-10T13:08:40Z","git_url":"git://github.com/talweiss1982/ravendb.git","ssh_url":"git@github.com:talweiss1982/ravendb.git","clone_url":"https://github.com/talweiss1982/ravendb.git","svn_url":"https://github.com/talweiss1982/ravendb","homepage":"http://ayende.com/Blog/","size":375026,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ravendb:v3.5","ref":"v3.5","sha":"99e57aa4e9cc51475268f6e791be8f641ead83a9","user":{"login":"ravendb","id":213792,"avatar_url":"https://avatars.githubusercontent.com/u/213792?v=3","gravatar_id":"","url":"https://api.github.com/users/ravendb","html_url":"https://github.com/ravendb","followers_url":"https://api.github.com/users/ravendb/followers","following_url":"https://api.github.com/users/ravendb/following{/other_user}","gists_url":"https://api.github.com/users/ravendb/gists{/gist_id}","starred_url":"https://api.github.com/users/ravendb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravendb/subscriptions","organizations_url":"https://api.github.com/users/ravendb/orgs","repos_url":"https://api.github.com/users/ravendb/repos","events_url":"https://api.github.com/users/ravendb/events{/privacy}","received_events_url":"https://api.github.com/users/ravendb/received_events","type":"Organization","site_admin":false},"repo":{"id":542714,"name":"ravendb","full_name":"ravendb/ravendb","owner":{"login":"ravendb","id":213792,"avatar_url":"https://avatars.githubusercontent.com/u/213792?v=3","gravatar_id":"","url":"https://api.github.com/users/ravendb","html_url":"https://github.com/ravendb","followers_url":"https://api.github.com/users/ravendb/followers","following_url":"https://api.github.com/users/ravendb/following{/other_user}","gists_url":"https://api.github.com/users/ravendb/gists{/gist_id}","starred_url":"https://api.github.com/users/ravendb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravendb/subscriptions","organizations_url":"https://api.github.com/users/ravendb/orgs","repos_url":"https://api.github.com/users/ravendb/repos","events_url":"https://api.github.com/users/ravendb/events{/privacy}","received_events_url":"https://api.github.com/users/ravendb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ravendb/ravendb","description":"A linq enabled document database for .NET","fork":false,"url":"https://api.github.com/repos/ravendb/ravendb","forks_url":"https://api.github.com/repos/ravendb/ravendb/forks","keys_url":"https://api.github.com/repos/ravendb/ravendb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ravendb/ravendb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ravendb/ravendb/teams","hooks_url":"https://api.github.com/repos/ravendb/ravendb/hooks","issue_events_url":"https://api.github.com/repos/ravendb/ravendb/issues/events{/number}","events_url":"https://api.github.com/repos/ravendb/ravendb/events","assignees_url":"https://api.github.com/repos/ravendb/ravendb/assignees{/user}","branches_url":"https://api.github.com/repos/ravendb/ravendb/branches{/branch}","tags_url":"https://api.github.com/repos/ravendb/ravendb/tags","blobs_url":"https://api.github.com/repos/ravendb/ravendb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ravendb/ravendb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ravendb/ravendb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ravendb/ravendb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ravendb/ravendb/statuses/{sha}","languages_url":"https://api.github.com/repos/ravendb/ravendb/languages","stargazers_url":"https://api.github.com/repos/ravendb/ravendb/stargazers","contributors_url":"https://api.github.com/repos/ravendb/ravendb/contributors","subscribers_url":"https://api.github.com/repos/ravendb/ravendb/subscribers","subscription_url":"https://api.github.com/repos/ravendb/ravendb/subscription","commits_url":"https://api.github.com/repos/ravendb/ravendb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ravendb/ravendb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ravendb/ravendb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ravendb/ravendb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ravendb/ravendb/contents/{+path}","compare_url":"https://api.github.com/repos/ravendb/ravendb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ravendb/ravendb/merges","archive_url":"https://api.github.com/repos/ravendb/ravendb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ravendb/ravendb/downloads","issues_url":"https://api.github.com/repos/ravendb/ravendb/issues{/number}","pulls_url":"https://api.github.com/repos/ravendb/ravendb/pulls{/number}","milestones_url":"https://api.github.com/repos/ravendb/ravendb/milestones{/number}","notifications_url":"https://api.github.com/repos/ravendb/ravendb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ravendb/ravendb/labels{/name}","releases_url":"https://api.github.com/repos/ravendb/ravendb/releases{/id}","deployments_url":"https://api.github.com/repos/ravendb/ravendb/deployments","created_at":"2010-03-02T11:05:30Z","updated_at":"2016-11-08T21:18:57Z","pushed_at":"2016-11-10T13:08:57Z","git_url":"git://github.com/ravendb/ravendb.git","ssh_url":"git@github.com:ravendb/ravendb.git","clone_url":"https://github.com/ravendb/ravendb.git","svn_url":"https://github.com/ravendb/ravendb","homepage":"http://ravendb.net","size":408798,"stargazers_count":1585,"watchers_count":1585,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":643,"mirror_url":null,"open_issues_count":1,"forks":643,"open_issues":1,"watchers":1585,"default_branch":"v3.5"}},"_links":{"self":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/853"},"html":{"href":"https://github.com/ravendb/ravendb/pull/853"},"issue":{"href":"https://api.github.com/repos/ravendb/ravendb/issues/853"},"comments":{"href":"https://api.github.com/repos/ravendb/ravendb/issues/853/comments"},"review_comments":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/853/comments"},"review_comment":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/853/commits"},"statuses":{"href":"https://api.github.com/repos/ravendb/ravendb/statuses/34f0c8e4b91a9ae341342e010771a5693b51bc2e"}}}}
{"actor":{"display_login":"ayende"}}