{"action":"created","comment":{"url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/pulls/comments/84233062","pull_request_review_id":5021846,"id":84233062,"diff_hunk":"@@ -0,0 +1,71 @@\n+\n+from .base import Node\n+from datetime import timedelta\n+from ebu_tt_live.bindings._ebuttdt import LimitedClockTimingType, FullClockTimingType\n+import time\n+import random\n+\n+\n+class FixedDelayNode(Node):\n+\n+    _reference_clock = None\n+    _sequence = None\n+\n+    def __init__(self, node_id, carriage_impl, reference_clock):\n+        super(FixedDelayNode, self).__init__(node_id, carriage_impl)\n+        self._reference_clock = reference_clock\n+\n+        random_int = random.randint(0, 9999999999)\n+        new_identifier = 'sequence_{0}'.format(str(random_int))\n+        self._sequence = new_identifier\n+\n+    def process_document(self, document):\n+\n+        # change the sequence identifier\n+        document.sequence_identifier = self._sequence\n+\n+        # TODO: add an ebuttm:trace element to the document metadata\n+\n+        fixed_delay_int = 2\n+\n+        # document is explicitly timed: modify the document\n+        if document.binding.body.begin or document.binding.body.end:","path":"ebu_tt_live/node/delay.py","position":32,"original_position":32,"commit_id":"a0189bd25e39bfdb994a3849d9a43b6e9c74b4a5","original_commit_id":"a0189bd25e39bfdb994a3849d9a43b6e9c74b4a5","user":{"login":"nigelmegitt","id":4988915,"avatar_url":"https://avatars.githubusercontent.com/u/4988915?v=3","gravatar_id":"","url":"https://api.github.com/users/nigelmegitt","html_url":"https://github.com/nigelmegitt","followers_url":"https://api.github.com/users/nigelmegitt/followers","following_url":"https://api.github.com/users/nigelmegitt/following{/other_user}","gists_url":"https://api.github.com/users/nigelmegitt/gists{/gist_id}","starred_url":"https://api.github.com/users/nigelmegitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nigelmegitt/subscriptions","organizations_url":"https://api.github.com/users/nigelmegitt/orgs","repos_url":"https://api.github.com/users/nigelmegitt/repos","events_url":"https://api.github.com/users/nigelmegitt/events{/privacy}","received_events_url":"https://api.github.com/users/nigelmegitt/received_events","type":"User","site_admin":false},"body":"We need to look at this test - I am not convinced it is sufficient. I think we need to traverse the tree to see if any elements have `begin` or `end` attributes not just the `body`.","created_at":"2016-10-20T08:23:56Z","updated_at":"2016-10-20T08:23:56Z","html_url":"https://github.com/ebu/ebu-tt-live-toolkit/pull/246#discussion_r84233062","pull_request_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/pulls/246","_links":{"self":{"href":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/pulls/comments/84233062"},"html":{"href":"https://github.com/ebu/ebu-tt-live-toolkit/pull/246#discussion_r84233062"},"pull_request":{"href":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/pulls/246"}}},"pull_request":{"url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/pulls/246","id":90146561,"html_url":"https://github.com/ebu/ebu-tt-live-toolkit/pull/246","diff_url":"https://github.com/ebu/ebu-tt-live-toolkit/pull/246.diff","patch_url":"https://github.com/ebu/ebu-tt-live-toolkit/pull/246.patch","issue_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/issues/246","number":246,"state":"open","locked":false,"title":"Malik/issue 231 fixed delay node","user":{"login":"malikbeytrison","id":17120997,"avatar_url":"https://avatars.githubusercontent.com/u/17120997?v=3","gravatar_id":"","url":"https://api.github.com/users/malikbeytrison","html_url":"https://github.com/malikbeytrison","followers_url":"https://api.github.com/users/malikbeytrison/followers","following_url":"https://api.github.com/users/malikbeytrison/following{/other_user}","gists_url":"https://api.github.com/users/malikbeytrison/gists{/gist_id}","starred_url":"https://api.github.com/users/malikbeytrison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malikbeytrison/subscriptions","organizations_url":"https://api.github.com/users/malikbeytrison/orgs","repos_url":"https://api.github.com/users/malikbeytrison/repos","events_url":"https://api.github.com/users/malikbeytrison/events{/privacy}","received_events_url":"https://api.github.com/users/malikbeytrison/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-20T07:29:41Z","updated_at":"2016-10-20T08:30:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0af7781c2f0095b86e27b8ab4a7276c1f4a61e7c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/pulls/246/commits","review_comments_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/pulls/246/comments","review_comment_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/issues/246/comments","statuses_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/statuses/a0189bd25e39bfdb994a3849d9a43b6e9c74b4a5","head":{"label":"ebu:malik/issue-231-fixed-delay-node","ref":"malik/issue-231-fixed-delay-node","sha":"a0189bd25e39bfdb994a3849d9a43b6e9c74b4a5","user":{"login":"ebu","id":2692549,"avatar_url":"https://avatars.githubusercontent.com/u/2692549?v=3","gravatar_id":"","url":"https://api.github.com/users/ebu","html_url":"https://github.com/ebu","followers_url":"https://api.github.com/users/ebu/followers","following_url":"https://api.github.com/users/ebu/following{/other_user}","gists_url":"https://api.github.com/users/ebu/gists{/gist_id}","starred_url":"https://api.github.com/users/ebu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebu/subscriptions","organizations_url":"https://api.github.com/users/ebu/orgs","repos_url":"https://api.github.com/users/ebu/repos","events_url":"https://api.github.com/users/ebu/events{/privacy}","received_events_url":"https://api.github.com/users/ebu/received_events","type":"Organization","site_admin":false},"repo":{"id":49490064,"name":"ebu-tt-live-toolkit","full_name":"ebu/ebu-tt-live-toolkit","owner":{"login":"ebu","id":2692549,"avatar_url":"https://avatars.githubusercontent.com/u/2692549?v=3","gravatar_id":"","url":"https://api.github.com/users/ebu","html_url":"https://github.com/ebu","followers_url":"https://api.github.com/users/ebu/followers","following_url":"https://api.github.com/users/ebu/following{/other_user}","gists_url":"https://api.github.com/users/ebu/gists{/gist_id}","starred_url":"https://api.github.com/users/ebu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebu/subscriptions","organizations_url":"https://api.github.com/users/ebu/orgs","repos_url":"https://api.github.com/users/ebu/repos","events_url":"https://api.github.com/users/ebu/events{/privacy}","received_events_url":"https://api.github.com/users/ebu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ebu/ebu-tt-live-toolkit","description":null,"fork":false,"url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit","forks_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/forks","keys_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/teams","hooks_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/hooks","issue_events_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/events","assignees_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/tags","blobs_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/languages","stargazers_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/stargazers","contributors_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/contributors","subscribers_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/subscribers","subscription_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/subscription","commits_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/merges","archive_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/downloads","issues_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/deployments","created_at":"2016-01-12T09:41:21Z","updated_at":"2016-07-27T22:42:06Z","pushed_at":"2016-10-20T07:29:41Z","git_url":"git://github.com/ebu/ebu-tt-live-toolkit.git","ssh_url":"git@github.com:ebu/ebu-tt-live-toolkit.git","clone_url":"https://github.com/ebu/ebu-tt-live-toolkit.git","svn_url":"https://github.com/ebu/ebu-tt-live-toolkit","homepage":null,"size":11040,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":76,"forks":4,"open_issues":76,"watchers":6,"default_branch":"master"}},"base":{"label":"ebu:master","ref":"master","sha":"f30a781ee52ff304bc01df9e95aef0274b6363f2","user":{"login":"ebu","id":2692549,"avatar_url":"https://avatars.githubusercontent.com/u/2692549?v=3","gravatar_id":"","url":"https://api.github.com/users/ebu","html_url":"https://github.com/ebu","followers_url":"https://api.github.com/users/ebu/followers","following_url":"https://api.github.com/users/ebu/following{/other_user}","gists_url":"https://api.github.com/users/ebu/gists{/gist_id}","starred_url":"https://api.github.com/users/ebu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebu/subscriptions","organizations_url":"https://api.github.com/users/ebu/orgs","repos_url":"https://api.github.com/users/ebu/repos","events_url":"https://api.github.com/users/ebu/events{/privacy}","received_events_url":"https://api.github.com/users/ebu/received_events","type":"Organization","site_admin":false},"repo":{"id":49490064,"name":"ebu-tt-live-toolkit","full_name":"ebu/ebu-tt-live-toolkit","owner":{"login":"ebu","id":2692549,"avatar_url":"https://avatars.githubusercontent.com/u/2692549?v=3","gravatar_id":"","url":"https://api.github.com/users/ebu","html_url":"https://github.com/ebu","followers_url":"https://api.github.com/users/ebu/followers","following_url":"https://api.github.com/users/ebu/following{/other_user}","gists_url":"https://api.github.com/users/ebu/gists{/gist_id}","starred_url":"https://api.github.com/users/ebu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebu/subscriptions","organizations_url":"https://api.github.com/users/ebu/orgs","repos_url":"https://api.github.com/users/ebu/repos","events_url":"https://api.github.com/users/ebu/events{/privacy}","received_events_url":"https://api.github.com/users/ebu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ebu/ebu-tt-live-toolkit","description":null,"fork":false,"url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit","forks_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/forks","keys_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/teams","hooks_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/hooks","issue_events_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/events","assignees_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/tags","blobs_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/languages","stargazers_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/stargazers","contributors_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/contributors","subscribers_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/subscribers","subscription_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/subscription","commits_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/merges","archive_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/downloads","issues_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/deployments","created_at":"2016-01-12T09:41:21Z","updated_at":"2016-07-27T22:42:06Z","pushed_at":"2016-10-20T07:29:41Z","git_url":"git://github.com/ebu/ebu-tt-live-toolkit.git","ssh_url":"git@github.com:ebu/ebu-tt-live-toolkit.git","clone_url":"https://github.com/ebu/ebu-tt-live-toolkit.git","svn_url":"https://github.com/ebu/ebu-tt-live-toolkit","homepage":null,"size":11040,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":76,"forks":4,"open_issues":76,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/pulls/246"},"html":{"href":"https://github.com/ebu/ebu-tt-live-toolkit/pull/246"},"issue":{"href":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/issues/246"},"comments":{"href":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/issues/246/comments"},"review_comments":{"href":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/pulls/246/comments"},"review_comment":{"href":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/pulls/246/commits"},"statuses":{"href":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/statuses/a0189bd25e39bfdb994a3849d9a43b6e9c74b4a5"}}}}
{"actor":{"display_login":"nigelmegitt"}}