{"action":"created","issue":{"url":"https://api.github.com/repos/miguelcleon/ODM2-Admin/issues/46","repository_url":"https://api.github.com/repos/miguelcleon/ODM2-Admin","labels_url":"https://api.github.com/repos/miguelcleon/ODM2-Admin/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/miguelcleon/ODM2-Admin/issues/46/comments","events_url":"https://api.github.com/repos/miguelcleon/ODM2-Admin/issues/46/events","html_url":"https://github.com/miguelcleon/ODM2-Admin/issues/46","id":175856706,"number":46,"title":"Enforce a linter for pep8 rules","user":{"login":"ocefpaf","id":950575,"avatar_url":"https://avatars.githubusercontent.com/u/950575?v=3","gravatar_id":"","url":"https://api.github.com/users/ocefpaf","html_url":"https://github.com/ocefpaf","followers_url":"https://api.github.com/users/ocefpaf/followers","following_url":"https://api.github.com/users/ocefpaf/following{/other_user}","gists_url":"https://api.github.com/users/ocefpaf/gists{/gist_id}","starred_url":"https://api.github.com/users/ocefpaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocefpaf/subscriptions","organizations_url":"https://api.github.com/users/ocefpaf/orgs","repos_url":"https://api.github.com/users/ocefpaf/repos","events_url":"https://api.github.com/users/ocefpaf/events{/privacy}","received_events_url":"https://api.github.com/users/ocefpaf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-08T20:32:11Z","updated_at":"2016-09-09T19:24:42Z","closed_at":null,"body":"@miguelcleon do you want to enforce a linter for [`pep8`](https://www.python.org/dev/peps/pep-0008/) rules here? I usually do that in my code and I even add it as part of the continous integration tests.\r\n\r\n(See https://github.com/ocefpaf/ODM2-Admin/blob/Travis-CI/.travis.yml#L28 for example.)\r\n\r\nI already started to re-organizing the code in some places but the amount of work required to bring `ODM2-Admin` to compliance is quite a lot. Before taking this path I want to if there is an interest from the authors to continue.\r\n\r\nPros:\r\n\r\n- cleaner code;\r\n- lower the entry barrier for new contributors;\r\n- higher maintainability.\r\n\r\nCons:\r\n- too much work;\r\n- authors are a closed group who do not care about `pep8`.\r\n\r\nThe commit https://github.com/ocefpaf/ODM2-Admin/commit/4fafdebd5363daf9d85bbec274be919b5cafd858 has ~20% of the job done and it is already unmanageable (hard to review without tests). That is the main reason I am raising this issue."},"comment":{"url":"https://api.github.com/repos/miguelcleon/ODM2-Admin/issues/comments/246013838","html_url":"https://github.com/miguelcleon/ODM2-Admin/issues/46#issuecomment-246013838","issue_url":"https://api.github.com/repos/miguelcleon/ODM2-Admin/issues/46","id":246013838,"user":{"login":"emiliom","id":742403,"avatar_url":"https://avatars.githubusercontent.com/u/742403?v=3","gravatar_id":"","url":"https://api.github.com/users/emiliom","html_url":"https://github.com/emiliom","followers_url":"https://api.github.com/users/emiliom/followers","following_url":"https://api.github.com/users/emiliom/following{/other_user}","gists_url":"https://api.github.com/users/emiliom/gists{/gist_id}","starred_url":"https://api.github.com/users/emiliom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emiliom/subscriptions","organizations_url":"https://api.github.com/users/emiliom/orgs","repos_url":"https://api.github.com/users/emiliom/repos","events_url":"https://api.github.com/users/emiliom/events{/privacy}","received_events_url":"https://api.github.com/users/emiliom/received_events","type":"User","site_admin":false},"created_at":"2016-09-09T19:24:42Z","updated_at":"2016-09-09T19:24:42Z","body":"@ocefpaf, personally I'm starting to care more and more about pep8. I haven't looked at ODM2-Admin code with an eye for pep8, but I'm pretty sure the contributions/commits from @lsetiawan (working with me on ODM2-Admin) are not strictly pep8. I believe there are only two developers for ODM2-Admin at this time, @miguelcleon and @lsetiawan.\r\n\r\nSo, my 2 cents is that this is too much work and not worth it at this time. BUT I'm very interested in getting your help on improving on our ODM2 code base towards pep8, and being prodded regularly :). I suspect it'll be more effective if we dedicate certain commits to pep8 changes alone, when we can dedicate time to it (I'm speaking generally across ODM2, not just ODM2-Admin)."}}
{"actor":{"display_login":"emiliom"}}