{"action":"created","comment":{"url":"https://api.github.com/repos/exo-addons/chat-application/pulls/comments/57297197","id":57297197,"diff_hunk":"@@ -285,7 +285,7 @@\n <div id=\"team-modal-form\" class=\"uiPopup hide team-modal\">\n   <div class=\"popupHeader clearfix\">\n     <a class=\"uiIconClose pull-right\" data-dismiss=\"modal\" aria-hidden=\"true\"></a>\n-    <span class=\"PopupTitle popupTitle\">&{exoplatform.chat.team}</span>","path":"application/src/main/java/org/exoplatform/chat/portlet/chat/templates/index.gtmpl","position":22,"original_position":22,"commit_id":"13626be3e3222cc380f0a15b97d1f99001237a96","original_commit_id":"08eb071c4dd83b22eb21d29d059350c156f8b350","user":{"login":"trongtt","id":515969,"avatar_url":"https://avatars.githubusercontent.com/u/515969?v=3","gravatar_id":"","url":"https://api.github.com/users/trongtt","html_url":"https://github.com/trongtt","followers_url":"https://api.github.com/users/trongtt/followers","following_url":"https://api.github.com/users/trongtt/following{/other_user}","gists_url":"https://api.github.com/users/trongtt/gists{/gist_id}","starred_url":"https://api.github.com/users/trongtt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trongtt/subscriptions","organizations_url":"https://api.github.com/users/trongtt/orgs","repos_url":"https://api.github.com/users/trongtt/repos","events_url":"https://api.github.com/users/trongtt/events{/privacy}","received_events_url":"https://api.github.com/users/trongtt/received_events","type":"User","site_admin":false},"body":"I just had a look at the code, and find that we could improve this usage of resource bundles in client side (javascript).\r\n\r\nI guess the reason it had to replace \".\" by \"_\" in the key name is that the variable name in javascript doesn't accept \".\"\r\nIn fact, here we can absolutely use something like *chatBundleData[\"exoplatform_chat_edit\"]* instead of *chatBundleData.exoplatform_chat_edit*. So there is no problem if we keep using \".\" in the key name. This is also the way we are using in some other projects, that helps maintain resource bundles easily.\r\n\r\nWTDY if I should create a JIRA for such improvement ?","created_at":"2016-03-24T10:19:06Z","updated_at":"2016-03-24T10:19:06Z","html_url":"https://github.com/exo-addons/chat-application/pull/35#discussion_r57297197","pull_request_url":"https://api.github.com/repos/exo-addons/chat-application/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/exo-addons/chat-application/pulls/comments/57297197"},"html":{"href":"https://github.com/exo-addons/chat-application/pull/35#discussion_r57297197"},"pull_request":{"href":"https://api.github.com/repos/exo-addons/chat-application/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/exo-addons/chat-application/pulls/35","id":63926374,"html_url":"https://github.com/exo-addons/chat-application/pull/35","diff_url":"https://github.com/exo-addons/chat-application/pull/35.diff","patch_url":"https://github.com/exo-addons/chat-application/pull/35.patch","issue_url":"https://api.github.com/repos/exo-addons/chat-application/issues/35","number":35,"state":"open","locked":false,"title":"CHAT-384 : Show chat room's members to every member","user":{"login":"fdrouet","id":120171,"avatar_url":"https://avatars.githubusercontent.com/u/120171?v=3","gravatar_id":"","url":"https://api.github.com/users/fdrouet","html_url":"https://github.com/fdrouet","followers_url":"https://api.github.com/users/fdrouet/followers","following_url":"https://api.github.com/users/fdrouet/following{/other_user}","gists_url":"https://api.github.com/users/fdrouet/gists{/gist_id}","starred_url":"https://api.github.com/users/fdrouet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdrouet/subscriptions","organizations_url":"https://api.github.com/users/fdrouet/orgs","repos_url":"https://api.github.com/users/fdrouet/repos","events_url":"https://api.github.com/users/fdrouet/events{/privacy}","received_events_url":"https://api.github.com/users/fdrouet/received_events","type":"User","site_admin":false},"body":"- the Edit action in the chat was renamed to Settings + icon change\r\n- any member of team room has now a new Settings action icon which show a new read-only setting popup window with the chat room owner and the members list of the chat room (without the owner)\r\n\r\nThis PR is a basic implementation of the PFR-1041 requirement.","created_at":"2016-03-23T18:00:50Z","updated_at":"2016-03-24T10:19:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bee4a1d84cad1ee1c1c6028558a752b8c3d795b9","assignee":{"login":"fdrouet","id":120171,"avatar_url":"https://avatars.githubusercontent.com/u/120171?v=3","gravatar_id":"","url":"https://api.github.com/users/fdrouet","html_url":"https://github.com/fdrouet","followers_url":"https://api.github.com/users/fdrouet/followers","following_url":"https://api.github.com/users/fdrouet/following{/other_user}","gists_url":"https://api.github.com/users/fdrouet/gists{/gist_id}","starred_url":"https://api.github.com/users/fdrouet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdrouet/subscriptions","organizations_url":"https://api.github.com/users/fdrouet/orgs","repos_url":"https://api.github.com/users/fdrouet/repos","events_url":"https://api.github.com/users/fdrouet/events{/privacy}","received_events_url":"https://api.github.com/users/fdrouet/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/exo-addons/chat-application/pulls/35/commits","review_comments_url":"https://api.github.com/repos/exo-addons/chat-application/pulls/35/comments","review_comment_url":"https://api.github.com/repos/exo-addons/chat-application/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exo-addons/chat-application/issues/35/comments","statuses_url":"https://api.github.com/repos/exo-addons/chat-application/statuses/13626be3e3222cc380f0a15b97d1f99001237a96","head":{"label":"exo-addons:feature/show_members_CHAT-384","ref":"feature/show_members_CHAT-384","sha":"13626be3e3222cc380f0a15b97d1f99001237a96","user":{"login":"exo-addons","id":2581906,"avatar_url":"https://avatars.githubusercontent.com/u/2581906?v=3","gravatar_id":"","url":"https://api.github.com/users/exo-addons","html_url":"https://github.com/exo-addons","followers_url":"https://api.github.com/users/exo-addons/followers","following_url":"https://api.github.com/users/exo-addons/following{/other_user}","gists_url":"https://api.github.com/users/exo-addons/gists{/gist_id}","starred_url":"https://api.github.com/users/exo-addons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exo-addons/subscriptions","organizations_url":"https://api.github.com/users/exo-addons/orgs","repos_url":"https://api.github.com/users/exo-addons/repos","events_url":"https://api.github.com/users/exo-addons/events{/privacy}","received_events_url":"https://api.github.com/users/exo-addons/received_events","type":"Organization","site_admin":false},"repo":{"id":33261222,"name":"chat-application","full_name":"exo-addons/chat-application","owner":{"login":"exo-addons","id":2581906,"avatar_url":"https://avatars.githubusercontent.com/u/2581906?v=3","gravatar_id":"","url":"https://api.github.com/users/exo-addons","html_url":"https://github.com/exo-addons","followers_url":"https://api.github.com/users/exo-addons/followers","following_url":"https://api.github.com/users/exo-addons/following{/other_user}","gists_url":"https://api.github.com/users/exo-addons/gists{/gist_id}","starred_url":"https://api.github.com/users/exo-addons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exo-addons/subscriptions","organizations_url":"https://api.github.com/users/exo-addons/orgs","repos_url":"https://api.github.com/users/exo-addons/repos","events_url":"https://api.github.com/users/exo-addons/events{/privacy}","received_events_url":"https://api.github.com/users/exo-addons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exo-addons/chat-application","description":"Chat application","fork":true,"url":"https://api.github.com/repos/exo-addons/chat-application","forks_url":"https://api.github.com/repos/exo-addons/chat-application/forks","keys_url":"https://api.github.com/repos/exo-addons/chat-application/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exo-addons/chat-application/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exo-addons/chat-application/teams","hooks_url":"https://api.github.com/repos/exo-addons/chat-application/hooks","issue_events_url":"https://api.github.com/repos/exo-addons/chat-application/issues/events{/number}","events_url":"https://api.github.com/repos/exo-addons/chat-application/events","assignees_url":"https://api.github.com/repos/exo-addons/chat-application/assignees{/user}","branches_url":"https://api.github.com/repos/exo-addons/chat-application/branches{/branch}","tags_url":"https://api.github.com/repos/exo-addons/chat-application/tags","blobs_url":"https://api.github.com/repos/exo-addons/chat-application/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exo-addons/chat-application/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exo-addons/chat-application/git/refs{/sha}","trees_url":"https://api.github.com/repos/exo-addons/chat-application/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exo-addons/chat-application/statuses/{sha}","languages_url":"https://api.github.com/repos/exo-addons/chat-application/languages","stargazers_url":"https://api.github.com/repos/exo-addons/chat-application/stargazers","contributors_url":"https://api.github.com/repos/exo-addons/chat-application/contributors","subscribers_url":"https://api.github.com/repos/exo-addons/chat-application/subscribers","subscription_url":"https://api.github.com/repos/exo-addons/chat-application/subscription","commits_url":"https://api.github.com/repos/exo-addons/chat-application/commits{/sha}","git_commits_url":"https://api.github.com/repos/exo-addons/chat-application/git/commits{/sha}","comments_url":"https://api.github.com/repos/exo-addons/chat-application/comments{/number}","issue_comment_url":"https://api.github.com/repos/exo-addons/chat-application/issues/comments{/number}","contents_url":"https://api.github.com/repos/exo-addons/chat-application/contents/{+path}","compare_url":"https://api.github.com/repos/exo-addons/chat-application/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exo-addons/chat-application/merges","archive_url":"https://api.github.com/repos/exo-addons/chat-application/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exo-addons/chat-application/downloads","issues_url":"https://api.github.com/repos/exo-addons/chat-application/issues{/number}","pulls_url":"https://api.github.com/repos/exo-addons/chat-application/pulls{/number}","milestones_url":"https://api.github.com/repos/exo-addons/chat-application/milestones{/number}","notifications_url":"https://api.github.com/repos/exo-addons/chat-application/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exo-addons/chat-application/labels{/name}","releases_url":"https://api.github.com/repos/exo-addons/chat-application/releases{/id}","deployments_url":"https://api.github.com/repos/exo-addons/chat-application/deployments","created_at":"2015-04-01T17:12:47Z","updated_at":"2016-01-21T10:08:25Z","pushed_at":"2016-03-24T09:13:01Z","git_url":"git://github.com/exo-addons/chat-application.git","ssh_url":"git@github.com:exo-addons/chat-application.git","clone_url":"https://github.com/exo-addons/chat-application.git","svn_url":"https://github.com/exo-addons/chat-application","homepage":null,"size":23818,"stargazers_count":5,"watchers_count":5,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":6,"forks":6,"open_issues":6,"watchers":5,"default_branch":"develop"}},"base":{"label":"exo-addons:develop","ref":"develop","sha":"06676185549d9a5f986e6bbcc9f5c915eea9df3e","user":{"login":"exo-addons","id":2581906,"avatar_url":"https://avatars.githubusercontent.com/u/2581906?v=3","gravatar_id":"","url":"https://api.github.com/users/exo-addons","html_url":"https://github.com/exo-addons","followers_url":"https://api.github.com/users/exo-addons/followers","following_url":"https://api.github.com/users/exo-addons/following{/other_user}","gists_url":"https://api.github.com/users/exo-addons/gists{/gist_id}","starred_url":"https://api.github.com/users/exo-addons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exo-addons/subscriptions","organizations_url":"https://api.github.com/users/exo-addons/orgs","repos_url":"https://api.github.com/users/exo-addons/repos","events_url":"https://api.github.com/users/exo-addons/events{/privacy}","received_events_url":"https://api.github.com/users/exo-addons/received_events","type":"Organization","site_admin":false},"repo":{"id":33261222,"name":"chat-application","full_name":"exo-addons/chat-application","owner":{"login":"exo-addons","id":2581906,"avatar_url":"https://avatars.githubusercontent.com/u/2581906?v=3","gravatar_id":"","url":"https://api.github.com/users/exo-addons","html_url":"https://github.com/exo-addons","followers_url":"https://api.github.com/users/exo-addons/followers","following_url":"https://api.github.com/users/exo-addons/following{/other_user}","gists_url":"https://api.github.com/users/exo-addons/gists{/gist_id}","starred_url":"https://api.github.com/users/exo-addons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exo-addons/subscriptions","organizations_url":"https://api.github.com/users/exo-addons/orgs","repos_url":"https://api.github.com/users/exo-addons/repos","events_url":"https://api.github.com/users/exo-addons/events{/privacy}","received_events_url":"https://api.github.com/users/exo-addons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exo-addons/chat-application","description":"Chat application","fork":true,"url":"https://api.github.com/repos/exo-addons/chat-application","forks_url":"https://api.github.com/repos/exo-addons/chat-application/forks","keys_url":"https://api.github.com/repos/exo-addons/chat-application/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exo-addons/chat-application/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exo-addons/chat-application/teams","hooks_url":"https://api.github.com/repos/exo-addons/chat-application/hooks","issue_events_url":"https://api.github.com/repos/exo-addons/chat-application/issues/events{/number}","events_url":"https://api.github.com/repos/exo-addons/chat-application/events","assignees_url":"https://api.github.com/repos/exo-addons/chat-application/assignees{/user}","branches_url":"https://api.github.com/repos/exo-addons/chat-application/branches{/branch}","tags_url":"https://api.github.com/repos/exo-addons/chat-application/tags","blobs_url":"https://api.github.com/repos/exo-addons/chat-application/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exo-addons/chat-application/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exo-addons/chat-application/git/refs{/sha}","trees_url":"https://api.github.com/repos/exo-addons/chat-application/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exo-addons/chat-application/statuses/{sha}","languages_url":"https://api.github.com/repos/exo-addons/chat-application/languages","stargazers_url":"https://api.github.com/repos/exo-addons/chat-application/stargazers","contributors_url":"https://api.github.com/repos/exo-addons/chat-application/contributors","subscribers_url":"https://api.github.com/repos/exo-addons/chat-application/subscribers","subscription_url":"https://api.github.com/repos/exo-addons/chat-application/subscription","commits_url":"https://api.github.com/repos/exo-addons/chat-application/commits{/sha}","git_commits_url":"https://api.github.com/repos/exo-addons/chat-application/git/commits{/sha}","comments_url":"https://api.github.com/repos/exo-addons/chat-application/comments{/number}","issue_comment_url":"https://api.github.com/repos/exo-addons/chat-application/issues/comments{/number}","contents_url":"https://api.github.com/repos/exo-addons/chat-application/contents/{+path}","compare_url":"https://api.github.com/repos/exo-addons/chat-application/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exo-addons/chat-application/merges","archive_url":"https://api.github.com/repos/exo-addons/chat-application/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exo-addons/chat-application/downloads","issues_url":"https://api.github.com/repos/exo-addons/chat-application/issues{/number}","pulls_url":"https://api.github.com/repos/exo-addons/chat-application/pulls{/number}","milestones_url":"https://api.github.com/repos/exo-addons/chat-application/milestones{/number}","notifications_url":"https://api.github.com/repos/exo-addons/chat-application/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exo-addons/chat-application/labels{/name}","releases_url":"https://api.github.com/repos/exo-addons/chat-application/releases{/id}","deployments_url":"https://api.github.com/repos/exo-addons/chat-application/deployments","created_at":"2015-04-01T17:12:47Z","updated_at":"2016-01-21T10:08:25Z","pushed_at":"2016-03-24T09:13:01Z","git_url":"git://github.com/exo-addons/chat-application.git","ssh_url":"git@github.com:exo-addons/chat-application.git","clone_url":"https://github.com/exo-addons/chat-application.git","svn_url":"https://github.com/exo-addons/chat-application","homepage":null,"size":23818,"stargazers_count":5,"watchers_count":5,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":6,"forks":6,"open_issues":6,"watchers":5,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/exo-addons/chat-application/pulls/35"},"html":{"href":"https://github.com/exo-addons/chat-application/pull/35"},"issue":{"href":"https://api.github.com/repos/exo-addons/chat-application/issues/35"},"comments":{"href":"https://api.github.com/repos/exo-addons/chat-application/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/exo-addons/chat-application/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/exo-addons/chat-application/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exo-addons/chat-application/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/exo-addons/chat-application/statuses/13626be3e3222cc380f0a15b97d1f99001237a96"}}}}