{"action":"created","issue":{"url":"https://api.github.com/repos/glenco/SLsimLib/issues/112","repository_url":"https://api.github.com/repos/glenco/SLsimLib","labels_url":"https://api.github.com/repos/glenco/SLsimLib/issues/112/labels{/name}","comments_url":"https://api.github.com/repos/glenco/SLsimLib/issues/112/comments","events_url":"https://api.github.com/repos/glenco/SLsimLib/issues/112/events","html_url":"https://github.com/glenco/SLsimLib/issues/112","id":181055145,"number":112,"title":"Using a lens without parameter file","user":{"login":"FabienNugier","id":7163166,"avatar_url":"https://avatars.githubusercontent.com/u/7163166?v=3","gravatar_id":"","url":"https://api.github.com/users/FabienNugier","html_url":"https://github.com/FabienNugier","followers_url":"https://api.github.com/users/FabienNugier/followers","following_url":"https://api.github.com/users/FabienNugier/following{/other_user}","gists_url":"https://api.github.com/users/FabienNugier/gists{/gist_id}","starred_url":"https://api.github.com/users/FabienNugier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FabienNugier/subscriptions","organizations_url":"https://api.github.com/users/FabienNugier/orgs","repos_url":"https://api.github.com/users/FabienNugier/repos","events_url":"https://api.github.com/users/FabienNugier/events{/privacy}","received_events_url":"https://api.github.com/users/FabienNugier/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-10-05T03:08:38Z","updated_at":"2016-10-11T08:20:58Z","closed_at":null,"body":"I am having some trouble with insertSubstructures and more precisely the number of planes. Indeed, there is an assertion in insertSubstructures that checks the number of planes :\r\nassert(field_planes.size() == field_Nplanes_original);\r\nand this assertion fails when I call insertSubstructures on a lens that I created without the parameter file. The source of the problem seems to be that field_Nplanes_original is not initialized and thus takes a very large and unrealistic value. I tried to initialize it to zero in the constructor of the lens but then other problems appear with field_planes..."},"comment":{"url":"https://api.github.com/repos/glenco/SLsimLib/issues/comments/252844359","html_url":"https://github.com/glenco/SLsimLib/issues/112#issuecomment-252844359","issue_url":"https://api.github.com/repos/glenco/SLsimLib/issues/112","id":252844359,"user":{"login":"rbmetcalf","id":7499429,"avatar_url":"https://avatars.githubusercontent.com/u/7499429?v=3","gravatar_id":"","url":"https://api.github.com/users/rbmetcalf","html_url":"https://github.com/rbmetcalf","followers_url":"https://api.github.com/users/rbmetcalf/followers","following_url":"https://api.github.com/users/rbmetcalf/following{/other_user}","gists_url":"https://api.github.com/users/rbmetcalf/gists{/gist_id}","starred_url":"https://api.github.com/users/rbmetcalf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbmetcalf/subscriptions","organizations_url":"https://api.github.com/users/rbmetcalf/orgs","repos_url":"https://api.github.com/users/rbmetcalf/repos","events_url":"https://api.github.com/users/rbmetcalf/events{/privacy}","received_events_url":"https://api.github.com/users/rbmetcalf/received_events","type":"User","site_admin":false},"created_at":"2016-10-11T08:20:58Z","updated_at":"2016-10-11T08:20:58Z","body":"Yes.  The general philosophy was to keep the LensHalos independent of the cosmology.\r\nThis is why their constructors don't take a `COSMOLOGY` and calculate `Dist` right there.  \r\nBut the light-cones are all done in angular coordinates and there was a lot of projecting \r\nonto planes  while preserving angular position that was causing problems before.  \r\nIt became cumbersome not to have the angular position in the `LensHalo` and to make \r\nthat consistent with the physical position requires the distance.  As it is, you should be able \r\nto construct and use a `LensHalo` without having access to a `COSMOLOGY` and their\r\naction within the ray-shooting parts should not require it.  It is only when \r\nyou use `LensHalo::getX()` that the distance must have been set.  So there shouldn't be\r\nany need for `assert(Dist  !=  -1)` anywhere but in `LensHalo::getX()`.\r\n\r\n\r\n "}}
{"actor":{"display_login":"rbmetcalf"}}