{"action":"closed","issue":{"url":"https://api.github.com/repos/LSSTDESC/imSim/issues/31","repository_url":"https://api.github.com/repos/LSSTDESC/imSim","labels_url":"https://api.github.com/repos/LSSTDESC/imSim/issues/31/labels{/name}","comments_url":"https://api.github.com/repos/LSSTDESC/imSim/issues/31/comments","events_url":"https://api.github.com/repos/LSSTDESC/imSim/issues/31/events","html_url":"https://github.com/LSSTDESC/imSim/issues/31","id":187627072,"number":31,"title":"update instance catalog parsing code to handle all possible object descriptions","user":{"login":"jchiang87","id":1994473,"avatar_url":"https://avatars.githubusercontent.com/u/1994473?v=3","gravatar_id":"","url":"https://api.github.com/users/jchiang87","html_url":"https://github.com/jchiang87","followers_url":"https://api.github.com/users/jchiang87/followers","following_url":"https://api.github.com/users/jchiang87/following{/other_user}","gists_url":"https://api.github.com/users/jchiang87/gists{/gist_id}","starred_url":"https://api.github.com/users/jchiang87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchiang87/subscriptions","organizations_url":"https://api.github.com/users/jchiang87/orgs","repos_url":"https://api.github.com/users/jchiang87/repos","events_url":"https://api.github.com/users/jchiang87/events{/privacy}","received_events_url":"https://api.github.com/users/jchiang87/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-07T05:15:45Z","updated_at":"2016-11-29T23:08:20Z","closed_at":"2016-11-29T23:08:20Z","body":"The final columns in the `object` lines of an instance catalog contain the parameters for the spatial model and for the rest frame and Galactic extinction.  According to the [phosim documentation](https://bitbucket.org/phosim/phosim_release/wiki/Instance%20Catalog), the extinction entries can have four forms:\r\n\r\n1. `<internal dust model> iA_v iR_v <Galactic dust model> gA_v gR_v`\r\n2. `none <Galactic dust model> gA_v gR_v`\r\n3. `<internal dust model> iA_v iR_v none`\r\n4. `none none`\r\n\r\nwhere the choices for dust model are `CCM` or `calzetti` and the `A_v`s and `R_v`s are the model parameters, and `none` means that no dust model is to be applied.  In practice, only 1. and 2. will appear, but owing to a bug, CatSim currently writes the Galactic entry before the internal one; and the code now in imSim only handles cases that _look like_ 1. and 3. and [assumes that ordering](https://github.com/DarkEnergyScienceCollaboration/imSim/blob/5724abf72967df3537dd724199821c575ea3be82/python/desc/imsim/imSim.py#L186).  Since CatSim will presumably soon be fixed, the parser code should be updated to handle all four cases with the correct ordering. Twinkles instance catalogs for Run3 already have the fix applied.\r\n\r\nThe `spatial_pars` columns can have 0, 1, 2, 4, or 6 columns depending on the source type, so those columns should also be handled correctly.  The current imSim code only handles `point` and `sersic2d` models."}}
{"actor":{"display_login":"jchiang87"}}