{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular-cli/pulls/comments/82619786","pull_request_review_id":3514405,"id":82619786,"diff_hunk":"@@ -33,7 +33,8 @@ export function getWebpackCommonConfig(\n   return {\n     devtool: 'source-map',\n     resolve: {\n-      extensions: ['.ts', '.js']\n+      extensions: ['.ts', '.js'],\n+      modules: [ path.join(projectRoot, 'node_modules') ]","path":"packages/angular-cli/models/webpack-build-common.ts","position":null,"original_position":6,"commit_id":"fda89917d37b6636f8600e1a899b01b0981fc79c","original_commit_id":"7e1af74d66497ed33e92ab1a517147ddb4f201f2","user":{"login":"clydin","id":19598772,"avatar_url":"https://avatars.githubusercontent.com/u/19598772?v=3","gravatar_id":"","url":"https://api.github.com/users/clydin","html_url":"https://github.com/clydin","followers_url":"https://api.github.com/users/clydin/followers","following_url":"https://api.github.com/users/clydin/following{/other_user}","gists_url":"https://api.github.com/users/clydin/gists{/gist_id}","starred_url":"https://api.github.com/users/clydin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clydin/subscriptions","organizations_url":"https://api.github.com/users/clydin/orgs","repos_url":"https://api.github.com/users/clydin/repos","events_url":"https://api.github.com/users/clydin/events{/privacy}","received_events_url":"https://api.github.com/users/clydin/received_events","type":"User","site_admin":false},"body":"@mmolhoek, do you have an example?","created_at":"2016-10-10T14:52:46Z","updated_at":"2016-10-10T14:52:46Z","html_url":"https://github.com/angular/angular-cli/pull/2291#discussion_r82619786","pull_request_url":"https://api.github.com/repos/angular/angular-cli/pulls/2291","_links":{"self":{"href":"https://api.github.com/repos/angular/angular-cli/pulls/comments/82619786"},"html":{"href":"https://github.com/angular/angular-cli/pull/2291#discussion_r82619786"},"pull_request":{"href":"https://api.github.com/repos/angular/angular-cli/pulls/2291"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular-cli/pulls/2291","id":86319517,"html_url":"https://github.com/angular/angular-cli/pull/2291","diff_url":"https://github.com/angular/angular-cli/pull/2291.diff","patch_url":"https://github.com/angular/angular-cli/pull/2291.patch","issue_url":"https://api.github.com/repos/angular/angular-cli/issues/2291","number":2291,"state":"open","locked":false,"title":"fix(#1875): Support npm linked libraries","user":{"login":"serhiisol","id":8107129,"avatar_url":"https://avatars.githubusercontent.com/u/8107129?v=3","gravatar_id":"","url":"https://api.github.com/users/serhiisol","html_url":"https://github.com/serhiisol","followers_url":"https://api.github.com/users/serhiisol/followers","following_url":"https://api.github.com/users/serhiisol/following{/other_user}","gists_url":"https://api.github.com/users/serhiisol/gists{/gist_id}","starred_url":"https://api.github.com/users/serhiisol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serhiisol/subscriptions","organizations_url":"https://api.github.com/users/serhiisol/orgs","repos_url":"https://api.github.com/users/serhiisol/repos","events_url":"https://api.github.com/users/serhiisol/events{/privacy}","received_events_url":"https://api.github.com/users/serhiisol/received_events","type":"User","site_admin":false},"body":"This PR fixes the problem with linked packages (https://github.com/angular/angular-cli/issues/1875). \r\n\r\nOriginally I've used http://webpack.github.io/docs/troubleshooting.html#npm-linked-modules-doesn-t-find-their-dependencies official documentation. But for webpack2 the team has changed also configuration object, which doesn't work like described in the article.\r\n\r\nSo I've found another release note related to configuration object - https://gist.github.com/sokra/27b24881210b56bbaff7#resolving-options\r\n\r\nThe most important is ```Resolving options ``` section.\r\n\r\nSo we have to change our configuration object from:\r\n```\r\nmodule.exports = {\r\n  resolve: { fallback: path.join(__dirname, \"node_modules\") },\r\n  resolveLoader: { fallback: path.join(__dirname, \"node_modules\") }\r\n};\r\n```\r\nto:\r\n```\r\nmodule.exports = {\r\n  resolve: { \r\n    modules: [ 'node_modules', path.join(__dirname, \"node_modules\") ]\r\n  }\r\n};\r\n```\r\n\r\nCloses https://github.com/angular/angular-cli/issues/1875","created_at":"2016-09-22T11:23:58Z","updated_at":"2016-10-10T14:52:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71d9218d74fdf46f950f0d6e475c49b5de5e60d8","assignee":{"login":"TheLarkInn","id":3408176,"avatar_url":"https://avatars.githubusercontent.com/u/3408176?v=3","gravatar_id":"","url":"https://api.github.com/users/TheLarkInn","html_url":"https://github.com/TheLarkInn","followers_url":"https://api.github.com/users/TheLarkInn/followers","following_url":"https://api.github.com/users/TheLarkInn/following{/other_user}","gists_url":"https://api.github.com/users/TheLarkInn/gists{/gist_id}","starred_url":"https://api.github.com/users/TheLarkInn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheLarkInn/subscriptions","organizations_url":"https://api.github.com/users/TheLarkInn/orgs","repos_url":"https://api.github.com/users/TheLarkInn/repos","events_url":"https://api.github.com/users/TheLarkInn/events{/privacy}","received_events_url":"https://api.github.com/users/TheLarkInn/received_events","type":"User","site_admin":false},"assignees":[{"login":"TheLarkInn","id":3408176,"avatar_url":"https://avatars.githubusercontent.com/u/3408176?v=3","gravatar_id":"","url":"https://api.github.com/users/TheLarkInn","html_url":"https://github.com/TheLarkInn","followers_url":"https://api.github.com/users/TheLarkInn/followers","following_url":"https://api.github.com/users/TheLarkInn/following{/other_user}","gists_url":"https://api.github.com/users/TheLarkInn/gists{/gist_id}","starred_url":"https://api.github.com/users/TheLarkInn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheLarkInn/subscriptions","organizations_url":"https://api.github.com/users/TheLarkInn/orgs","repos_url":"https://api.github.com/users/TheLarkInn/repos","events_url":"https://api.github.com/users/TheLarkInn/events{/privacy}","received_events_url":"https://api.github.com/users/TheLarkInn/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular-cli/pulls/2291/commits","review_comments_url":"https://api.github.com/repos/angular/angular-cli/pulls/2291/comments","review_comment_url":"https://api.github.com/repos/angular/angular-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular-cli/issues/2291/comments","statuses_url":"https://api.github.com/repos/angular/angular-cli/statuses/fda89917d37b6636f8600e1a899b01b0981fc79c","head":{"label":"serhiisol:support-npm-linked-packages","ref":"support-npm-linked-packages","sha":"fda89917d37b6636f8600e1a899b01b0981fc79c","user":{"login":"serhiisol","id":8107129,"avatar_url":"https://avatars.githubusercontent.com/u/8107129?v=3","gravatar_id":"","url":"https://api.github.com/users/serhiisol","html_url":"https://github.com/serhiisol","followers_url":"https://api.github.com/users/serhiisol/followers","following_url":"https://api.github.com/users/serhiisol/following{/other_user}","gists_url":"https://api.github.com/users/serhiisol/gists{/gist_id}","starred_url":"https://api.github.com/users/serhiisol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serhiisol/subscriptions","organizations_url":"https://api.github.com/users/serhiisol/orgs","repos_url":"https://api.github.com/users/serhiisol/repos","events_url":"https://api.github.com/users/serhiisol/events{/privacy}","received_events_url":"https://api.github.com/users/serhiisol/received_events","type":"User","site_admin":false},"repo":{"id":68905117,"name":"angular-cli","full_name":"serhiisol/angular-cli","owner":{"login":"serhiisol","id":8107129,"avatar_url":"https://avatars.githubusercontent.com/u/8107129?v=3","gravatar_id":"","url":"https://api.github.com/users/serhiisol","html_url":"https://github.com/serhiisol","followers_url":"https://api.github.com/users/serhiisol/followers","following_url":"https://api.github.com/users/serhiisol/following{/other_user}","gists_url":"https://api.github.com/users/serhiisol/gists{/gist_id}","starred_url":"https://api.github.com/users/serhiisol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serhiisol/subscriptions","organizations_url":"https://api.github.com/users/serhiisol/orgs","repos_url":"https://api.github.com/users/serhiisol/repos","events_url":"https://api.github.com/users/serhiisol/events{/privacy}","received_events_url":"https://api.github.com/users/serhiisol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/serhiisol/angular-cli","description":"CLI tool for Angular2","fork":true,"url":"https://api.github.com/repos/serhiisol/angular-cli","forks_url":"https://api.github.com/repos/serhiisol/angular-cli/forks","keys_url":"https://api.github.com/repos/serhiisol/angular-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serhiisol/angular-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serhiisol/angular-cli/teams","hooks_url":"https://api.github.com/repos/serhiisol/angular-cli/hooks","issue_events_url":"https://api.github.com/repos/serhiisol/angular-cli/issues/events{/number}","events_url":"https://api.github.com/repos/serhiisol/angular-cli/events","assignees_url":"https://api.github.com/repos/serhiisol/angular-cli/assignees{/user}","branches_url":"https://api.github.com/repos/serhiisol/angular-cli/branches{/branch}","tags_url":"https://api.github.com/repos/serhiisol/angular-cli/tags","blobs_url":"https://api.github.com/repos/serhiisol/angular-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serhiisol/angular-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serhiisol/angular-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/serhiisol/angular-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serhiisol/angular-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/serhiisol/angular-cli/languages","stargazers_url":"https://api.github.com/repos/serhiisol/angular-cli/stargazers","contributors_url":"https://api.github.com/repos/serhiisol/angular-cli/contributors","subscribers_url":"https://api.github.com/repos/serhiisol/angular-cli/subscribers","subscription_url":"https://api.github.com/repos/serhiisol/angular-cli/subscription","commits_url":"https://api.github.com/repos/serhiisol/angular-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/serhiisol/angular-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/serhiisol/angular-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/serhiisol/angular-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/serhiisol/angular-cli/contents/{+path}","compare_url":"https://api.github.com/repos/serhiisol/angular-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serhiisol/angular-cli/merges","archive_url":"https://api.github.com/repos/serhiisol/angular-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serhiisol/angular-cli/downloads","issues_url":"https://api.github.com/repos/serhiisol/angular-cli/issues{/number}","pulls_url":"https://api.github.com/repos/serhiisol/angular-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/serhiisol/angular-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/serhiisol/angular-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serhiisol/angular-cli/labels{/name}","releases_url":"https://api.github.com/repos/serhiisol/angular-cli/releases{/id}","deployments_url":"https://api.github.com/repos/serhiisol/angular-cli/deployments","created_at":"2016-09-22T09:17:27Z","updated_at":"2016-09-22T09:17:28Z","pushed_at":"2016-10-10T13:30:27Z","git_url":"git://github.com/serhiisol/angular-cli.git","ssh_url":"git@github.com:serhiisol/angular-cli.git","clone_url":"https://github.com/serhiisol/angular-cli.git","svn_url":"https://github.com/serhiisol/angular-cli","homepage":"","size":1677,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"fbc585b9b9e397234f28dcea199a7ae5bf6b088e","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":36891867,"name":"angular-cli","full_name":"angular/angular-cli","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular-cli","description":"CLI tool for Angular2","fork":false,"url":"https://api.github.com/repos/angular/angular-cli","forks_url":"https://api.github.com/repos/angular/angular-cli/forks","keys_url":"https://api.github.com/repos/angular/angular-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular-cli/teams","hooks_url":"https://api.github.com/repos/angular/angular-cli/hooks","issue_events_url":"https://api.github.com/repos/angular/angular-cli/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular-cli/events","assignees_url":"https://api.github.com/repos/angular/angular-cli/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular-cli/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular-cli/tags","blobs_url":"https://api.github.com/repos/angular/angular-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular-cli/languages","stargazers_url":"https://api.github.com/repos/angular/angular-cli/stargazers","contributors_url":"https://api.github.com/repos/angular/angular-cli/contributors","subscribers_url":"https://api.github.com/repos/angular/angular-cli/subscribers","subscription_url":"https://api.github.com/repos/angular/angular-cli/subscription","commits_url":"https://api.github.com/repos/angular/angular-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular-cli/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular-cli/merges","archive_url":"https://api.github.com/repos/angular/angular-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular-cli/downloads","issues_url":"https://api.github.com/repos/angular/angular-cli/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular-cli/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular-cli/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular-cli/deployments","created_at":"2015-06-04T19:49:37Z","updated_at":"2016-10-10T13:59:20Z","pushed_at":"2016-10-10T13:30:28Z","git_url":"git://github.com/angular/angular-cli.git","ssh_url":"git@github.com:angular/angular-cli.git","clone_url":"https://github.com/angular/angular-cli.git","svn_url":"https://github.com/angular/angular-cli","homepage":"","size":3916,"stargazers_count":4325,"watchers_count":4325,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":668,"mirror_url":null,"open_issues_count":274,"forks":668,"open_issues":274,"watchers":4325,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular-cli/pulls/2291"},"html":{"href":"https://github.com/angular/angular-cli/pull/2291"},"issue":{"href":"https://api.github.com/repos/angular/angular-cli/issues/2291"},"comments":{"href":"https://api.github.com/repos/angular/angular-cli/issues/2291/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular-cli/pulls/2291/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular-cli/pulls/2291/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular-cli/statuses/fda89917d37b6636f8600e1a899b01b0981fc79c"}}}}
{"actor":{"display_login":"clydin"}}