{"action":"created","comment":{"url":"https://api.github.com/repos/exercism/xruby/pulls/comments/94277588","pull_request_review_id":14807786,"id":94277588,"diff_hunk":"@@ -1,27 +1,16 @@\n class Series\n-  def initialize(numeric_string)\n-    @digits = convert_to_digits(numeric_string)\n+  def initialize(series)\n+    @series = (series)\n   end\n-\n-  def slices(length)\n-    if length > digits.length\n-      fail ArgumentError.new('Not enough digits')\n+  def slices(n)\n+    if n > @series.length\n+      raise ArgumentError\n     end\n-    result = []\n-    i = -1\n-    begin\n-      i += 1\n-      i2 = i + length - 1\n-      result << digits[i..i2]\n-    end while i2 < digits.size - 1\n-    result\n-  end\n-\n-  private\n-\n-  attr_reader :digits\n-\n-  def convert_to_digits(s)\n-    s.chars.to_a.map(&:to_i)\n+    substrings = []\n+    until @series.length < n","path":"exercises/series/example.rb","position":32,"original_position":32,"commit_id":"81d11c30f067e9edb87ad73e9c0629cec3fc57f1","original_commit_id":"81d11c30f067e9edb87ad73e9c0629cec3fc57f1","user":{"login":"Insti","id":5096681,"avatar_url":"https://avatars.githubusercontent.com/u/5096681?v=3","gravatar_id":"","url":"https://api.github.com/users/Insti","html_url":"https://github.com/Insti","followers_url":"https://api.github.com/users/Insti/followers","following_url":"https://api.github.com/users/Insti/following{/other_user}","gists_url":"https://api.github.com/users/Insti/gists{/gist_id}","starred_url":"https://api.github.com/users/Insti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Insti/subscriptions","organizations_url":"https://api.github.com/users/Insti/orgs","repos_url":"https://api.github.com/users/Insti/repos","events_url":"https://api.github.com/users/Insti/events{/privacy}","received_events_url":"https://api.github.com/users/Insti/received_events","type":"User","site_admin":false},"body":"Maybe it would help if you added an additional test case for this at the end.","created_at":"2016-12-31T20:49:51Z","updated_at":"2016-12-31T20:49:51Z","html_url":"https://github.com/exercism/xruby/pull/524#discussion_r94277588","pull_request_url":"https://api.github.com/repos/exercism/xruby/pulls/524","_links":{"self":{"href":"https://api.github.com/repos/exercism/xruby/pulls/comments/94277588"},"html":{"href":"https://github.com/exercism/xruby/pull/524#discussion_r94277588"},"pull_request":{"href":"https://api.github.com/repos/exercism/xruby/pulls/524"}}},"pull_request":{"url":"https://api.github.com/repos/exercism/xruby/pulls/524","id":99794250,"html_url":"https://github.com/exercism/xruby/pull/524","diff_url":"https://github.com/exercism/xruby/pull/524.diff","patch_url":"https://github.com/exercism/xruby/pull/524.patch","issue_url":"https://api.github.com/repos/exercism/xruby/issues/524","number":524,"state":"open","locked":false,"title":"series: series_test.rb test for strings not arrays","user":{"login":"stevensonmt","id":8891908,"avatar_url":"https://avatars.githubusercontent.com/u/8891908?v=3","gravatar_id":"","url":"https://api.github.com/users/stevensonmt","html_url":"https://github.com/stevensonmt","followers_url":"https://api.github.com/users/stevensonmt/followers","following_url":"https://api.github.com/users/stevensonmt/following{/other_user}","gists_url":"https://api.github.com/users/stevensonmt/gists{/gist_id}","starred_url":"https://api.github.com/users/stevensonmt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevensonmt/subscriptions","organizations_url":"https://api.github.com/users/stevensonmt/orgs","repos_url":"https://api.github.com/users/stevensonmt/repos","events_url":"https://api.github.com/users/stevensonmt/events{/privacy}","received_events_url":"https://api.github.com/users/stevensonmt/received_events","type":"User","site_admin":false},"body":"Previous test looked for arrays of Ints but exercise prompt in readme called for strings.  This update makes tests look for strings.","created_at":"2016-12-31T01:38:21Z","updated_at":"2016-12-31T20:49:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e23a6df6127479fea4a86c80f4905a6f87e4e5e8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/exercism/xruby/pulls/524/commits","review_comments_url":"https://api.github.com/repos/exercism/xruby/pulls/524/comments","review_comment_url":"https://api.github.com/repos/exercism/xruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exercism/xruby/issues/524/comments","statuses_url":"https://api.github.com/repos/exercism/xruby/statuses/81d11c30f067e9edb87ad73e9c0629cec3fc57f1","head":{"label":"stevensonmt:series_update","ref":"series_update","sha":"81d11c30f067e9edb87ad73e9c0629cec3fc57f1","user":{"login":"stevensonmt","id":8891908,"avatar_url":"https://avatars.githubusercontent.com/u/8891908?v=3","gravatar_id":"","url":"https://api.github.com/users/stevensonmt","html_url":"https://github.com/stevensonmt","followers_url":"https://api.github.com/users/stevensonmt/followers","following_url":"https://api.github.com/users/stevensonmt/following{/other_user}","gists_url":"https://api.github.com/users/stevensonmt/gists{/gist_id}","starred_url":"https://api.github.com/users/stevensonmt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevensonmt/subscriptions","organizations_url":"https://api.github.com/users/stevensonmt/orgs","repos_url":"https://api.github.com/users/stevensonmt/repos","events_url":"https://api.github.com/users/stevensonmt/events{/privacy}","received_events_url":"https://api.github.com/users/stevensonmt/received_events","type":"User","site_admin":false},"repo":{"id":77719265,"name":"xruby","full_name":"stevensonmt/xruby","owner":{"login":"stevensonmt","id":8891908,"avatar_url":"https://avatars.githubusercontent.com/u/8891908?v=3","gravatar_id":"","url":"https://api.github.com/users/stevensonmt","html_url":"https://github.com/stevensonmt","followers_url":"https://api.github.com/users/stevensonmt/followers","following_url":"https://api.github.com/users/stevensonmt/following{/other_user}","gists_url":"https://api.github.com/users/stevensonmt/gists{/gist_id}","starred_url":"https://api.github.com/users/stevensonmt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevensonmt/subscriptions","organizations_url":"https://api.github.com/users/stevensonmt/orgs","repos_url":"https://api.github.com/users/stevensonmt/repos","events_url":"https://api.github.com/users/stevensonmt/events{/privacy}","received_events_url":"https://api.github.com/users/stevensonmt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stevensonmt/xruby","description":"Exercism Exercises in Ruby","fork":true,"url":"https://api.github.com/repos/stevensonmt/xruby","forks_url":"https://api.github.com/repos/stevensonmt/xruby/forks","keys_url":"https://api.github.com/repos/stevensonmt/xruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stevensonmt/xruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stevensonmt/xruby/teams","hooks_url":"https://api.github.com/repos/stevensonmt/xruby/hooks","issue_events_url":"https://api.github.com/repos/stevensonmt/xruby/issues/events{/number}","events_url":"https://api.github.com/repos/stevensonmt/xruby/events","assignees_url":"https://api.github.com/repos/stevensonmt/xruby/assignees{/user}","branches_url":"https://api.github.com/repos/stevensonmt/xruby/branches{/branch}","tags_url":"https://api.github.com/repos/stevensonmt/xruby/tags","blobs_url":"https://api.github.com/repos/stevensonmt/xruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stevensonmt/xruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stevensonmt/xruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/stevensonmt/xruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stevensonmt/xruby/statuses/{sha}","languages_url":"https://api.github.com/repos/stevensonmt/xruby/languages","stargazers_url":"https://api.github.com/repos/stevensonmt/xruby/stargazers","contributors_url":"https://api.github.com/repos/stevensonmt/xruby/contributors","subscribers_url":"https://api.github.com/repos/stevensonmt/xruby/subscribers","subscription_url":"https://api.github.com/repos/stevensonmt/xruby/subscription","commits_url":"https://api.github.com/repos/stevensonmt/xruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/stevensonmt/xruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/stevensonmt/xruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/stevensonmt/xruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/stevensonmt/xruby/contents/{+path}","compare_url":"https://api.github.com/repos/stevensonmt/xruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stevensonmt/xruby/merges","archive_url":"https://api.github.com/repos/stevensonmt/xruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stevensonmt/xruby/downloads","issues_url":"https://api.github.com/repos/stevensonmt/xruby/issues{/number}","pulls_url":"https://api.github.com/repos/stevensonmt/xruby/pulls{/number}","milestones_url":"https://api.github.com/repos/stevensonmt/xruby/milestones{/number}","notifications_url":"https://api.github.com/repos/stevensonmt/xruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stevensonmt/xruby/labels{/name}","releases_url":"https://api.github.com/repos/stevensonmt/xruby/releases{/id}","deployments_url":"https://api.github.com/repos/stevensonmt/xruby/deployments","created_at":"2016-12-31T01:25:17Z","updated_at":"2016-12-31T01:25:20Z","pushed_at":"2016-12-31T19:26:23Z","git_url":"git://github.com/stevensonmt/xruby.git","ssh_url":"git@github.com:stevensonmt/xruby.git","clone_url":"https://github.com/stevensonmt/xruby.git","svn_url":"https://github.com/stevensonmt/xruby","homepage":null,"size":945,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"exercism:master","ref":"master","sha":"0b11381c34888940da7fae0329a355df02508728","user":{"login":"exercism","id":5624255,"avatar_url":"https://avatars.githubusercontent.com/u/5624255?v=3","gravatar_id":"","url":"https://api.github.com/users/exercism","html_url":"https://github.com/exercism","followers_url":"https://api.github.com/users/exercism/followers","following_url":"https://api.github.com/users/exercism/following{/other_user}","gists_url":"https://api.github.com/users/exercism/gists{/gist_id}","starred_url":"https://api.github.com/users/exercism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exercism/subscriptions","organizations_url":"https://api.github.com/users/exercism/orgs","repos_url":"https://api.github.com/users/exercism/repos","events_url":"https://api.github.com/users/exercism/events{/privacy}","received_events_url":"https://api.github.com/users/exercism/received_events","type":"Organization","site_admin":false},"repo":{"id":17258847,"name":"xruby","full_name":"exercism/xruby","owner":{"login":"exercism","id":5624255,"avatar_url":"https://avatars.githubusercontent.com/u/5624255?v=3","gravatar_id":"","url":"https://api.github.com/users/exercism","html_url":"https://github.com/exercism","followers_url":"https://api.github.com/users/exercism/followers","following_url":"https://api.github.com/users/exercism/following{/other_user}","gists_url":"https://api.github.com/users/exercism/gists{/gist_id}","starred_url":"https://api.github.com/users/exercism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exercism/subscriptions","organizations_url":"https://api.github.com/users/exercism/orgs","repos_url":"https://api.github.com/users/exercism/repos","events_url":"https://api.github.com/users/exercism/events{/privacy}","received_events_url":"https://api.github.com/users/exercism/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exercism/xruby","description":"Exercism Exercises in Ruby","fork":false,"url":"https://api.github.com/repos/exercism/xruby","forks_url":"https://api.github.com/repos/exercism/xruby/forks","keys_url":"https://api.github.com/repos/exercism/xruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exercism/xruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exercism/xruby/teams","hooks_url":"https://api.github.com/repos/exercism/xruby/hooks","issue_events_url":"https://api.github.com/repos/exercism/xruby/issues/events{/number}","events_url":"https://api.github.com/repos/exercism/xruby/events","assignees_url":"https://api.github.com/repos/exercism/xruby/assignees{/user}","branches_url":"https://api.github.com/repos/exercism/xruby/branches{/branch}","tags_url":"https://api.github.com/repos/exercism/xruby/tags","blobs_url":"https://api.github.com/repos/exercism/xruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exercism/xruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exercism/xruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/exercism/xruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exercism/xruby/statuses/{sha}","languages_url":"https://api.github.com/repos/exercism/xruby/languages","stargazers_url":"https://api.github.com/repos/exercism/xruby/stargazers","contributors_url":"https://api.github.com/repos/exercism/xruby/contributors","subscribers_url":"https://api.github.com/repos/exercism/xruby/subscribers","subscription_url":"https://api.github.com/repos/exercism/xruby/subscription","commits_url":"https://api.github.com/repos/exercism/xruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/exercism/xruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/exercism/xruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/exercism/xruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/exercism/xruby/contents/{+path}","compare_url":"https://api.github.com/repos/exercism/xruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exercism/xruby/merges","archive_url":"https://api.github.com/repos/exercism/xruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exercism/xruby/downloads","issues_url":"https://api.github.com/repos/exercism/xruby/issues{/number}","pulls_url":"https://api.github.com/repos/exercism/xruby/pulls{/number}","milestones_url":"https://api.github.com/repos/exercism/xruby/milestones{/number}","notifications_url":"https://api.github.com/repos/exercism/xruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exercism/xruby/labels{/name}","releases_url":"https://api.github.com/repos/exercism/xruby/releases{/id}","deployments_url":"https://api.github.com/repos/exercism/xruby/deployments","created_at":"2014-02-27T18:11:43Z","updated_at":"2016-12-31T01:04:27Z","pushed_at":"2016-12-31T19:26:25Z","git_url":"git://github.com/exercism/xruby.git","ssh_url":"git@github.com:exercism/xruby.git","clone_url":"https://github.com/exercism/xruby.git","svn_url":"https://github.com/exercism/xruby","homepage":null,"size":933,"stargazers_count":152,"watchers_count":152,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":219,"mirror_url":null,"open_issues_count":26,"forks":219,"open_issues":26,"watchers":152,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/exercism/xruby/pulls/524"},"html":{"href":"https://github.com/exercism/xruby/pull/524"},"issue":{"href":"https://api.github.com/repos/exercism/xruby/issues/524"},"comments":{"href":"https://api.github.com/repos/exercism/xruby/issues/524/comments"},"review_comments":{"href":"https://api.github.com/repos/exercism/xruby/pulls/524/comments"},"review_comment":{"href":"https://api.github.com/repos/exercism/xruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exercism/xruby/pulls/524/commits"},"statuses":{"href":"https://api.github.com/repos/exercism/xruby/statuses/81d11c30f067e9edb87ad73e9c0629cec3fc57f1"}}}}
{"actor":{"display_login":"Insti"}}