{"action":"created","issue":{"url":"https://api.github.com/repos/sagiegurari/simple-oracledb/issues/7","repository_url":"https://api.github.com/repos/sagiegurari/simple-oracledb","labels_url":"https://api.github.com/repos/sagiegurari/simple-oracledb/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/sagiegurari/simple-oracledb/issues/7/comments","events_url":"https://api.github.com/repos/sagiegurari/simple-oracledb/issues/7/events","html_url":"https://github.com/sagiegurari/simple-oracledb/issues/7","id":169219000,"number":7,"title":"Will you support promise on query, insert and update methods ?","user":{"login":"lucasmartinez","id":8795184,"avatar_url":"https://avatars.githubusercontent.com/u/8795184?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasmartinez","html_url":"https://github.com/lucasmartinez","followers_url":"https://api.github.com/users/lucasmartinez/followers","following_url":"https://api.github.com/users/lucasmartinez/following{/other_user}","gists_url":"https://api.github.com/users/lucasmartinez/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasmartinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasmartinez/subscriptions","organizations_url":"https://api.github.com/users/lucasmartinez/orgs","repos_url":"https://api.github.com/users/lucasmartinez/repos","events_url":"https://api.github.com/users/lucasmartinez/events{/privacy}","received_events_url":"https://api.github.com/users/lucasmartinez/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sagiegurari/simple-oracledb/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-03T19:54:15Z","updated_at":"2016-08-04T10:52:49Z","closed_at":null,"body":"<!-- markdownlint-disable first-header-h1 no-multiple-blanks first-line-h1 required-headers -->\r\n#### Problem Description\r\nquery method is not returning a Promise.\r\n\r\n#### Code Example\r\n\r\nvar simpleOracledb = require('simple-oracledb'),\r\n   oracledb = require('oracledb');\r\n\r\nsimpleOracledb.extend(oracledb);\r\n\r\noracledb.createPool({\r\n   user: 'user',\r\n   password: 'password',\r\n   connectString: \"127.0.0.1/orcl\"\r\n}).then(function (dbpool) {\r\n   dbpool.getConnection().then(function (conection) {\r\n      conection.query('select sysdate from dual').then(function(r){\r\n         console.log(r);\r\n      })\r\n   });\r\n});\r\n\r\n````js\r\n//paste code here\r\n````\r\n\r\n#### Error Stack/Info (if any)\r\n\r\n/home/oracle/hermes/node_modules/simple-oracledb/lib/rows-reader.js:49\r\n            callback(error, jsRows);\r\n            ^\r\n\r\nTypeError: callback is not a function\r\n    at onAyncDone (/home/oracle/hermes/node_modules/simple-oracledb/lib/rows-reader.js:49:13)\r\n    at /home/oracle/hermes/node_modules/async/dist/async.js:3679:13\r\n    at /home/oracle/hermes/node_modules/async/dist/async.js:952:25\r\n    at iteratorCallback (/home/oracle/hermes/node_modules/async/dist/async.js:997:17)\r\n    at /home/oracle/hermes/node_modules/async/dist/async.js:847:20\r\n    at /home/oracle/hermes/node_modules/async/dist/async.js:3676:17\r\n    at /home/oracle/hermes/node_modules/async/dist/async.js:339:31\r\n    at onRowRead (/home/oracle/hermes/node_modules/simple-oracledb/lib/rows-reader.js:42:25)\r\n    at onAyncDone (/home/oracle/hermes/node_modules/simple-oracledb/lib/record-reader.js:117:9)\r\n    at /home/oracle/hermes/node_modules/async/dist/async.js:3679:13\r\n"},"comment":{"url":"https://api.github.com/repos/sagiegurari/simple-oracledb/issues/comments/237520235","html_url":"https://github.com/sagiegurari/simple-oracledb/issues/7#issuecomment-237520235","issue_url":"https://api.github.com/repos/sagiegurari/simple-oracledb/issues/7","id":237520235,"user":{"login":"lucasmartinez","id":8795184,"avatar_url":"https://avatars.githubusercontent.com/u/8795184?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasmartinez","html_url":"https://github.com/lucasmartinez","followers_url":"https://api.github.com/users/lucasmartinez/followers","following_url":"https://api.github.com/users/lucasmartinez/following{/other_user}","gists_url":"https://api.github.com/users/lucasmartinez/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasmartinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasmartinez/subscriptions","organizations_url":"https://api.github.com/users/lucasmartinez/orgs","repos_url":"https://api.github.com/users/lucasmartinez/repos","events_url":"https://api.github.com/users/lucasmartinez/events{/privacy}","received_events_url":"https://api.github.com/users/lucasmartinez/received_events","type":"User","site_admin":false},"created_at":"2016-08-04T10:52:49Z","updated_at":"2016-08-04T10:52:49Z","body":"Great job. Your library helped me a lot. I would like to use Promise in all my server functions to standarize the way my product is developed having Promise in front aplication and in my backend too. This way the code in front and backend are the same."}}
{"actor":{"display_login":"lucasmartinez"}}