{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/9741","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/9741/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/9741/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/9741/events","html_url":"https://github.com/nodejs/node/pull/9741","id":191021465,"number":9741,"title":"test: add toASCII and toUnicode punycode tests","user":{"login":"claudiorodriguez","id":3967972,"avatar_url":"https://avatars.githubusercontent.com/u/3967972?v=3","gravatar_id":"","url":"https://api.github.com/users/claudiorodriguez","html_url":"https://github.com/claudiorodriguez","followers_url":"https://api.github.com/users/claudiorodriguez/followers","following_url":"https://api.github.com/users/claudiorodriguez/following{/other_user}","gists_url":"https://api.github.com/users/claudiorodriguez/gists{/gist_id}","starred_url":"https://api.github.com/users/claudiorodriguez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claudiorodriguez/subscriptions","organizations_url":"https://api.github.com/users/claudiorodriguez/orgs","repos_url":"https://api.github.com/users/claudiorodriguez/repos","events_url":"https://api.github.com/users/claudiorodriguez/events{/privacy}","received_events_url":"https://api.github.com/users/claudiorodriguez/received_events","type":"User","site_admin":false},"labels":[{"id":176240519,"url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-22T14:27:06Z","updated_at":"2016-11-23T08:55:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/9741","html_url":"https://github.com/nodejs/node/pull/9741","diff_url":"https://github.com/nodejs/node/pull/9741.diff","patch_url":"https://github.com/nodejs/node/pull/9741.patch"},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j8 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\ntest\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\n\r\n- Add toUnicode and toASCII tests to test-punycode\r\n- Refactor test-punycode.js to better organize test cases\r\n- Change assert.equal to assert.strictEqual in test-punycode.js"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/262460831","html_url":"https://github.com/nodejs/node/pull/9741#issuecomment-262460831","issue_url":"https://api.github.com/repos/nodejs/node/issues/9741","id":262460831,"user":{"login":"claudiorodriguez","id":3967972,"avatar_url":"https://avatars.githubusercontent.com/u/3967972?v=3","gravatar_id":"","url":"https://api.github.com/users/claudiorodriguez","html_url":"https://github.com/claudiorodriguez","followers_url":"https://api.github.com/users/claudiorodriguez/followers","following_url":"https://api.github.com/users/claudiorodriguez/following{/other_user}","gists_url":"https://api.github.com/users/claudiorodriguez/gists{/gist_id}","starred_url":"https://api.github.com/users/claudiorodriguez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claudiorodriguez/subscriptions","organizations_url":"https://api.github.com/users/claudiorodriguez/orgs","repos_url":"https://api.github.com/users/claudiorodriguez/repos","events_url":"https://api.github.com/users/claudiorodriguez/events{/privacy}","received_events_url":"https://api.github.com/users/claudiorodriguez/received_events","type":"User","site_admin":false},"created_at":"2016-11-23T08:55:38Z","updated_at":"2016-11-23T08:55:38Z","body":"I've removed the duplicitous `string` and left the `\\u` encoded ones since they appear like that in the RFC, and also I've rewritten the `toUnicode` test to reflect its actual logic.\r\n\r\nNew CI: https://ci.nodejs.org/job/node-test-pull-request/4960/"}}
{"actor":{"display_login":"claudiorodriguez"}}