{"action":"created","issue":{"url":"https://api.github.com/repos/stan-dev/math/issues/270","repository_url":"https://api.github.com/repos/stan-dev/math","labels_url":"https://api.github.com/repos/stan-dev/math/issues/270/labels{/name}","comments_url":"https://api.github.com/repos/stan-dev/math/issues/270/comments","events_url":"https://api.github.com/repos/stan-dev/math/issues/270/events","html_url":"https://github.com/stan-dev/math/pull/270","id":144497220,"number":270,"title":"Bugfix/issue 230 jacobian transposed","user":{"login":"wds15","id":12070126,"avatar_url":"https://avatars.githubusercontent.com/u/12070126?v=3","gravatar_id":"","url":"https://api.github.com/users/wds15","html_url":"https://github.com/wds15","followers_url":"https://api.github.com/users/wds15/followers","following_url":"https://api.github.com/users/wds15/following{/other_user}","gists_url":"https://api.github.com/users/wds15/gists{/gist_id}","starred_url":"https://api.github.com/users/wds15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wds15/subscriptions","organizations_url":"https://api.github.com/users/wds15/orgs","repos_url":"https://api.github.com/users/wds15/repos","events_url":"https://api.github.com/users/wds15/events{/privacy}","received_events_url":"https://api.github.com/users/wds15/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/stan-dev/math/labels/code%20reviewed","name":"code reviewed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-03-30T08:06:29Z","updated_at":"2016-04-01T07:03:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/stan-dev/math/pulls/270","html_url":"https://github.com/stan-dev/math/pull/270","diff_url":"https://github.com/stan-dev/math/pull/270.diff","patch_url":"https://github.com/stan-dev/math/pull/270.patch"},"body":"#### Submisison Checklist\r\n\r\n- [X] Run unit tests: `./runTests.py src/test/unit`\r\n- [X] Run cpplint: `make cpplint`\r\n- [X] Declare copyright holder and open-source license: see below\r\n\r\n#### Summary:\r\nalign jacobian with common definition, i.e. to return a NxM matrix for a R^N -> R^M function\r\n\r\n#### Intended Effect:\r\nCurrently the output would the transposed MxN\r\n\r\n#### How to Verify:\r\nRun current tests for stan/math/rev/mat/functor/jacobian.hpp \r\n\r\n#### Side Effects:\r\nAll user code using the functions now get the correct (but different) sized matrices.\r\n\r\n#### Documentation:\r\n\r\n#### Reviewer Suggestions: \r\n@syclik @bob-carpenter \r\n#### Copyright and Licensing\r\n\r\nPlease list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Sebastian Weber\r\n\r\nBy submitting this pull request, the copyright holder is requiring to license the submitted work under the following licenses:\r\n- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)\r\n- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)\r\n"},"comment":{"url":"https://api.github.com/repos/stan-dev/math/issues/comments/204276944","html_url":"https://github.com/stan-dev/math/pull/270#issuecomment-204276944","issue_url":"https://api.github.com/repos/stan-dev/math/issues/270","id":204276944,"user":{"login":"wds15","id":12070126,"avatar_url":"https://avatars.githubusercontent.com/u/12070126?v=3","gravatar_id":"","url":"https://api.github.com/users/wds15","html_url":"https://github.com/wds15","followers_url":"https://api.github.com/users/wds15/followers","following_url":"https://api.github.com/users/wds15/following{/other_user}","gists_url":"https://api.github.com/users/wds15/gists{/gist_id}","starred_url":"https://api.github.com/users/wds15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wds15/subscriptions","organizations_url":"https://api.github.com/users/wds15/orgs","repos_url":"https://api.github.com/users/wds15/repos","events_url":"https://api.github.com/users/wds15/events{/privacy}","received_events_url":"https://api.github.com/users/wds15/received_events","type":"User","site_admin":false},"created_at":"2016-04-01T07:03:19Z","updated_at":"2016-04-01T07:03:19Z","body":"@bob-carpenter : Just for the future: You are pointing towards test-driven development. For this specific case the already existing test was actually wrong. So if I were to redo this again, would it have been ok to CHANGE the existing test which tests for the wrongly transposed output to the correct behavior. That way the old test would be changed, but this would trigger the mis-behavior. Would this be ok from a test-driven dev perspective?"}}