{"action":"created","issue":{"url":"https://api.github.com/repos/woocommerce/woocommerce/issues/12501","repository_url":"https://api.github.com/repos/woocommerce/woocommerce","labels_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/12501/labels{/name}","comments_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/12501/comments","events_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/12501/events","html_url":"https://github.com/woocommerce/woocommerce/issues/12501","id":192771523,"number":12501,"title":"\"sale\" badge still there, even if sale ended","user":{"login":"scrobbleme","id":504835,"avatar_url":"https://avatars.githubusercontent.com/u/504835?v=3","gravatar_id":"","url":"https://api.github.com/users/scrobbleme","html_url":"https://github.com/scrobbleme","followers_url":"https://api.github.com/users/scrobbleme/followers","following_url":"https://api.github.com/users/scrobbleme/following{/other_user}","gists_url":"https://api.github.com/users/scrobbleme/gists{/gist_id}","starred_url":"https://api.github.com/users/scrobbleme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrobbleme/subscriptions","organizations_url":"https://api.github.com/users/scrobbleme/orgs","repos_url":"https://api.github.com/users/scrobbleme/repos","events_url":"https://api.github.com/users/scrobbleme/events{/privacy}","received_events_url":"https://api.github.com/users/scrobbleme/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-01T07:19:08Z","updated_at":"2016-12-05T12:43:03Z","closed_at":"2016-12-05T12:43:03Z","body":"## EXPLANATION OF THE ISSUE\r\n\r\nA customer reported this to me. \r\nShe did a sale with a scheduled end date. \r\n\r\nAfter the sale ended:\r\n\r\n- prices are okay\r\n- products still have the \"sale\" badge\r\n\r\n## STEPS TO REPRODUCE THE ISSUE\r\n\r\nCreate a scheduled sale, and wait until it ends\r\n\r\n(Workaround: remove the sale manually)\r\n"},"comment":{"url":"https://api.github.com/repos/woocommerce/woocommerce/issues/comments/264844793","html_url":"https://github.com/woocommerce/woocommerce/issues/12501#issuecomment-264844793","issue_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/12501","id":264844793,"user":{"login":"mikejolley","id":90977,"avatar_url":"https://avatars.githubusercontent.com/u/90977?v=3","gravatar_id":"","url":"https://api.github.com/users/mikejolley","html_url":"https://github.com/mikejolley","followers_url":"https://api.github.com/users/mikejolley/followers","following_url":"https://api.github.com/users/mikejolley/following{/other_user}","gists_url":"https://api.github.com/users/mikejolley/gists{/gist_id}","starred_url":"https://api.github.com/users/mikejolley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikejolley/subscriptions","organizations_url":"https://api.github.com/users/mikejolley/orgs","repos_url":"https://api.github.com/users/mikejolley/repos","events_url":"https://api.github.com/users/mikejolley/events{/privacy}","received_events_url":"https://api.github.com/users/mikejolley/received_events","type":"User","site_admin":false},"created_at":"2016-12-05T12:43:03Z","updated_at":"2016-12-05T12:43:03Z","body":"Cannot seem to replicate this one - prices are updated, and thats what the is_on_sale check uses so I cannot see where this would fail.. Is it variable? If so it's cache and we fixed in master/2.7. No bug exists with simple products though."}}
{"actor":{"display_login":"mikejolley"}}