{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments/58640083","id":58640083,"diff_hunk":"@@ -54,34 +38,87 @@ class Manifest extends Gather {\n     };\n   }\n \n+  /**\n+   * @private\n+   */\n+  static _createDeferred() {\n+    let resolve;\n+    let reject;\n+    const promise = new Promise((internalResolve, internalReject) => {\n+      resolve = internalResolve;\n+      reject = internalReject;\n+    });\n+\n+    return {\n+      promise,\n+      resolve,\n+      reject\n+    };\n+  }\n+\n+  /**\n+   * Creates a listener for manifests in network requests, a load timeout, and\n+   * a promise they resolve when complete.\n+   * @private\n+   */\n+  static _resolveOnManifest() {\n+    const manifestDeferred = Manifest._createDeferred();\n+\n+    setTimeout(_ => manifestDeferred.resolve(null), MANIFEST_LOAD_TIMEOUT);","path":"gatherers/manifest.js","position":73,"original_position":73,"commit_id":"663e5157a0fa6b2029e29f66d2810902af69d014","original_commit_id":"663e5157a0fa6b2029e29f66d2810902af69d014","user":{"login":"samccone","id":883126,"avatar_url":"https://avatars.githubusercontent.com/u/883126?v=3","gravatar_id":"","url":"https://api.github.com/users/samccone","html_url":"https://github.com/samccone","followers_url":"https://api.github.com/users/samccone/followers","following_url":"https://api.github.com/users/samccone/following{/other_user}","gists_url":"https://api.github.com/users/samccone/gists{/gist_id}","starred_url":"https://api.github.com/users/samccone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samccone/subscriptions","organizations_url":"https://api.github.com/users/samccone/orgs","repos_url":"https://api.github.com/users/samccone/repos","events_url":"https://api.github.com/users/samccone/events{/privacy}","received_events_url":"https://api.github.com/users/samccone/received_events","type":"User","site_admin":false},"body":"don't forget to clean this up :)","created_at":"2016-04-06T01:23:43Z","updated_at":"2016-04-06T01:23:43Z","html_url":"https://github.com/GoogleChrome/lighthouse/pull/137#discussion_r58640083","pull_request_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/137","_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments/58640083"},"html":{"href":"https://github.com/GoogleChrome/lighthouse/pull/137#discussion_r58640083"},"pull_request":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/137"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/137","id":65268602,"html_url":"https://github.com/GoogleChrome/lighthouse/pull/137","diff_url":"https://github.com/GoogleChrome/lighthouse/pull/137.diff","patch_url":"https://github.com/GoogleChrome/lighthouse/pull/137.patch","issue_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/137","number":137,"state":"open","locked":false,"title":"gather manifest by intercepting requestAppBanner load","user":{"login":"brendankenny","id":316891,"avatar_url":"https://avatars.githubusercontent.com/u/316891?v=3","gravatar_id":"","url":"https://api.github.com/users/brendankenny","html_url":"https://github.com/brendankenny","followers_url":"https://api.github.com/users/brendankenny/followers","following_url":"https://api.github.com/users/brendankenny/following{/other_user}","gists_url":"https://api.github.com/users/brendankenny/gists{/gist_id}","starred_url":"https://api.github.com/users/brendankenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendankenny/subscriptions","organizations_url":"https://api.github.com/users/brendankenny/orgs","repos_url":"https://api.github.com/users/brendankenny/repos","events_url":"https://api.github.com/users/brendankenny/events{/privacy}","received_events_url":"https://api.github.com/users/brendankenny/received_events","type":"User","site_admin":false},"body":"WIP stab at loading the manifest via the page itself. Works great for e.g. guitar-tuner and airhorner.\r\n\r\nA few problems I'm running into. Advice would be appreciated:\r\n- when this works, it only works the first time you open chrome and run lighthouse. If you leave Chrome open and re-run lighthouse, the manifest request always times out for me (even when testing a different site)\r\n- Looks like UA-emulation isn’t working for this request, at least. The request is sent with a UA string for my desktop, not what’s in emulation.js. For flipkart, this means I’m still getting a 404 when the page requests `https://www.flipkart.com/manifest.json`\r\n- for the Opera PWA list, even though `https://operasoftware.github.io/pwa-list/.webmanifest` finishes loading and status code is 200, I always get `No data found for resource with given identifier` from `Network.getResponseBody`","created_at":"2016-04-05T08:52:01Z","updated_at":"2016-04-06T01:23:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27dfd80ac6b80a7dc3de7fd02924604e32124537","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/137/commits","review_comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/137/comments","review_comment_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/137/comments","statuses_url":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/663e5157a0fa6b2029e29f66d2810902af69d014","head":{"label":"brendankenny:manifestcapture","ref":"manifestcapture","sha":"663e5157a0fa6b2029e29f66d2810902af69d014","user":{"login":"brendankenny","id":316891,"avatar_url":"https://avatars.githubusercontent.com/u/316891?v=3","gravatar_id":"","url":"https://api.github.com/users/brendankenny","html_url":"https://github.com/brendankenny","followers_url":"https://api.github.com/users/brendankenny/followers","following_url":"https://api.github.com/users/brendankenny/following{/other_user}","gists_url":"https://api.github.com/users/brendankenny/gists{/gist_id}","starred_url":"https://api.github.com/users/brendankenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendankenny/subscriptions","organizations_url":"https://api.github.com/users/brendankenny/orgs","repos_url":"https://api.github.com/users/brendankenny/repos","events_url":"https://api.github.com/users/brendankenny/events{/privacy}","received_events_url":"https://api.github.com/users/brendankenny/received_events","type":"User","site_admin":false},"repo":{"id":53702738,"name":"lighthouse","full_name":"brendankenny/lighthouse","owner":{"login":"brendankenny","id":316891,"avatar_url":"https://avatars.githubusercontent.com/u/316891?v=3","gravatar_id":"","url":"https://api.github.com/users/brendankenny","html_url":"https://github.com/brendankenny","followers_url":"https://api.github.com/users/brendankenny/followers","following_url":"https://api.github.com/users/brendankenny/following{/other_user}","gists_url":"https://api.github.com/users/brendankenny/gists{/gist_id}","starred_url":"https://api.github.com/users/brendankenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendankenny/subscriptions","organizations_url":"https://api.github.com/users/brendankenny/orgs","repos_url":"https://api.github.com/users/brendankenny/repos","events_url":"https://api.github.com/users/brendankenny/events{/privacy}","received_events_url":"https://api.github.com/users/brendankenny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brendankenny/lighthouse","description":null,"fork":true,"url":"https://api.github.com/repos/brendankenny/lighthouse","forks_url":"https://api.github.com/repos/brendankenny/lighthouse/forks","keys_url":"https://api.github.com/repos/brendankenny/lighthouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brendankenny/lighthouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brendankenny/lighthouse/teams","hooks_url":"https://api.github.com/repos/brendankenny/lighthouse/hooks","issue_events_url":"https://api.github.com/repos/brendankenny/lighthouse/issues/events{/number}","events_url":"https://api.github.com/repos/brendankenny/lighthouse/events","assignees_url":"https://api.github.com/repos/brendankenny/lighthouse/assignees{/user}","branches_url":"https://api.github.com/repos/brendankenny/lighthouse/branches{/branch}","tags_url":"https://api.github.com/repos/brendankenny/lighthouse/tags","blobs_url":"https://api.github.com/repos/brendankenny/lighthouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brendankenny/lighthouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brendankenny/lighthouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/brendankenny/lighthouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brendankenny/lighthouse/statuses/{sha}","languages_url":"https://api.github.com/repos/brendankenny/lighthouse/languages","stargazers_url":"https://api.github.com/repos/brendankenny/lighthouse/stargazers","contributors_url":"https://api.github.com/repos/brendankenny/lighthouse/contributors","subscribers_url":"https://api.github.com/repos/brendankenny/lighthouse/subscribers","subscription_url":"https://api.github.com/repos/brendankenny/lighthouse/subscription","commits_url":"https://api.github.com/repos/brendankenny/lighthouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/brendankenny/lighthouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/brendankenny/lighthouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/brendankenny/lighthouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/brendankenny/lighthouse/contents/{+path}","compare_url":"https://api.github.com/repos/brendankenny/lighthouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brendankenny/lighthouse/merges","archive_url":"https://api.github.com/repos/brendankenny/lighthouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brendankenny/lighthouse/downloads","issues_url":"https://api.github.com/repos/brendankenny/lighthouse/issues{/number}","pulls_url":"https://api.github.com/repos/brendankenny/lighthouse/pulls{/number}","milestones_url":"https://api.github.com/repos/brendankenny/lighthouse/milestones{/number}","notifications_url":"https://api.github.com/repos/brendankenny/lighthouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brendankenny/lighthouse/labels{/name}","releases_url":"https://api.github.com/repos/brendankenny/lighthouse/releases{/id}","deployments_url":"https://api.github.com/repos/brendankenny/lighthouse/deployments","created_at":"2016-03-11T23:23:05Z","updated_at":"2016-03-11T23:23:06Z","pushed_at":"2016-04-05T21:39:30Z","git_url":"git://github.com/brendankenny/lighthouse.git","ssh_url":"git@github.com:brendankenny/lighthouse.git","clone_url":"https://github.com/brendankenny/lighthouse.git","svn_url":"https://github.com/brendankenny/lighthouse","homepage":null,"size":2426,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleChrome:master","ref":"master","sha":"5a511fff6051524dbd50bf171687826db61ee16c","user":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"repo":{"id":53370988,"name":"lighthouse","full_name":"GoogleChrome/lighthouse","owner":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleChrome/lighthouse","description":null,"fork":false,"url":"https://api.github.com/repos/GoogleChrome/lighthouse","forks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/forks","keys_url":"https://api.github.com/repos/GoogleChrome/lighthouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChrome/lighthouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChrome/lighthouse/teams","hooks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/hooks","issue_events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/events","assignees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChrome/lighthouse/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/tags","blobs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChrome/lighthouse/languages","stargazers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/stargazers","contributors_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contributors","subscribers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscribers","subscription_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscription","commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChrome/lighthouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChrome/lighthouse/merges","archive_url":"https://api.github.com/repos/GoogleChrome/lighthouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChrome/lighthouse/downloads","issues_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChrome/lighthouse/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChrome/lighthouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChrome/lighthouse/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChrome/lighthouse/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/deployments","created_at":"2016-03-08T01:03:11Z","updated_at":"2016-04-05T22:07:28Z","pushed_at":"2016-04-05T22:35:55Z","git_url":"git://github.com/GoogleChrome/lighthouse.git","ssh_url":"git@github.com:GoogleChrome/lighthouse.git","clone_url":"https://github.com/GoogleChrome/lighthouse.git","svn_url":"https://github.com/GoogleChrome/lighthouse","homepage":null,"size":2487,"stargazers_count":62,"watchers_count":62,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":25,"forks":11,"open_issues":25,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/137"},"html":{"href":"https://github.com/GoogleChrome/lighthouse/pull/137"},"issue":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/137"},"comments":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/663e5157a0fa6b2029e29f66d2810902af69d014"}}}}