{"action":"created","comment":{"url":"https://api.github.com/repos/drush-ops/drush/pulls/comments/81251611","pull_request_review_id":2246186,"id":81251611,"diff_hunk":"@@ -0,0 +1,24 @@\n+<?php\n+namespace Drush\\CommandFiles\\core;\n+\n+class DrupliconCommands {\n+\n+  /**\n+   * Print druplicon as post-command output.\n+   *\n+   * @hook post-command *\n+   * @option $druplicon Shows the druplicon as glorious ASCII art.\n+   */\n+  public function druplicon($result, $argsAndOptions, $annotationData) {\n+    if (isset($argsAndOptions['options']['druplicon'])) {","path":"lib/Drush/CommandFiles/core/DrupliconCommands.php","position":13,"original_position":13,"commit_id":"993ab593ccdd8581d1fa930d1561509fa1abed77","original_commit_id":"993ab593ccdd8581d1fa930d1561509fa1abed77","user":{"login":"greg-1-anderson","id":612191,"avatar_url":"https://avatars.githubusercontent.com/u/612191?v=3","gravatar_id":"","url":"https://api.github.com/users/greg-1-anderson","html_url":"https://github.com/greg-1-anderson","followers_url":"https://api.github.com/users/greg-1-anderson/followers","following_url":"https://api.github.com/users/greg-1-anderson/following{/other_user}","gists_url":"https://api.github.com/users/greg-1-anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/greg-1-anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg-1-anderson/subscriptions","organizations_url":"https://api.github.com/users/greg-1-anderson/orgs","repos_url":"https://api.github.com/users/greg-1-anderson/repos","events_url":"https://api.github.com/users/greg-1-anderson/events{/privacy}","received_events_url":"https://api.github.com/users/greg-1-anderson/received_events","type":"User","site_admin":false},"body":"@weitzman Do you hate `$argsAndOptions`?  I think I hate it.  I could split this into separate `$args` and `$options`.  It is tempting to try to make the new post-command hook look like the old post-command hook -- that is, have Drush call it with the same calling conventions as the primary command hook.  However, doing that is hard on hooks that want to attach to every command, as the parameter order can be different for different commands.  Additionally, we want to pass in options as a parameter rather than call a globally-scoped function, and we also have annotation data to provide.\r\n\r\nFinally, note that the master branch does not use `isset` in its comparison; at the moment, 8.x is not providing default values for missing options.  I'll try to fix that next, so that we can have the same expectations in 8.x and master.","created_at":"2016-09-29T22:54:34Z","updated_at":"2016-09-29T22:54:34Z","html_url":"https://github.com/drush-ops/drush/pull/2366#discussion_r81251611","pull_request_url":"https://api.github.com/repos/drush-ops/drush/pulls/2366","_links":{"self":{"href":"https://api.github.com/repos/drush-ops/drush/pulls/comments/81251611"},"html":{"href":"https://github.com/drush-ops/drush/pull/2366#discussion_r81251611"},"pull_request":{"href":"https://api.github.com/repos/drush-ops/drush/pulls/2366"}}},"pull_request":{"url":"https://api.github.com/repos/drush-ops/drush/pulls/2366","id":86967409,"html_url":"https://github.com/drush-ops/drush/pull/2366","diff_url":"https://github.com/drush-ops/drush/pull/2366.diff","patch_url":"https://github.com/drush-ops/drush/pull/2366.patch","issue_url":"https://api.github.com/repos/drush-ops/drush/issues/2366","number":2366,"state":"open","locked":false,"title":"Update 8.x branch to Annotated Commands 2.0.0-rc6.","user":{"login":"greg-1-anderson","id":612191,"avatar_url":"https://avatars.githubusercontent.com/u/612191?v=3","gravatar_id":"","url":"https://api.github.com/users/greg-1-anderson","html_url":"https://github.com/greg-1-anderson","followers_url":"https://api.github.com/users/greg-1-anderson/followers","following_url":"https://api.github.com/users/greg-1-anderson/following{/other_user}","gists_url":"https://api.github.com/users/greg-1-anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/greg-1-anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg-1-anderson/subscriptions","organizations_url":"https://api.github.com/users/greg-1-anderson/orgs","repos_url":"https://api.github.com/users/greg-1-anderson/repos","events_url":"https://api.github.com/users/greg-1-anderson/events{/privacy}","received_events_url":"https://api.github.com/users/greg-1-anderson/received_events","type":"User","site_admin":false},"body":"This PR updates the 8.x branch to use Annotated Commands 2.0.0-rc3, to keep it in alignment with what is being used on master (sans Robo).\r\n\r\nNote that we should be sure to bump up to 2.0.0 prior to releasing a stable 8.x release -- perhaps even before merging this branch.  This should be available soon.\r\n\r\nSee also https://github.com/drush-ops/drush/pull/2357","created_at":"2016-09-27T16:43:11Z","updated_at":"2016-09-29T22:54:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42636e4501d322709fda7e1e3d00af3b79fc7b22","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/drush-ops/drush/pulls/2366/commits","review_comments_url":"https://api.github.com/repos/drush-ops/drush/pulls/2366/comments","review_comment_url":"https://api.github.com/repos/drush-ops/drush/pulls/comments{/number}","comments_url":"https://api.github.com/repos/drush-ops/drush/issues/2366/comments","statuses_url":"https://api.github.com/repos/drush-ops/drush/statuses/993ab593ccdd8581d1fa930d1561509fa1abed77","head":{"label":"drush-ops:annotation-command-rc3","ref":"annotation-command-rc3","sha":"993ab593ccdd8581d1fa930d1561509fa1abed77","user":{"login":"drush-ops","id":931201,"avatar_url":"https://avatars.githubusercontent.com/u/931201?v=3","gravatar_id":"","url":"https://api.github.com/users/drush-ops","html_url":"https://github.com/drush-ops","followers_url":"https://api.github.com/users/drush-ops/followers","following_url":"https://api.github.com/users/drush-ops/following{/other_user}","gists_url":"https://api.github.com/users/drush-ops/gists{/gist_id}","starred_url":"https://api.github.com/users/drush-ops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drush-ops/subscriptions","organizations_url":"https://api.github.com/users/drush-ops/orgs","repos_url":"https://api.github.com/users/drush-ops/repos","events_url":"https://api.github.com/users/drush-ops/events{/privacy}","received_events_url":"https://api.github.com/users/drush-ops/received_events","type":"Organization","site_admin":false},"repo":{"id":3193843,"name":"drush","full_name":"drush-ops/drush","owner":{"login":"drush-ops","id":931201,"avatar_url":"https://avatars.githubusercontent.com/u/931201?v=3","gravatar_id":"","url":"https://api.github.com/users/drush-ops","html_url":"https://github.com/drush-ops","followers_url":"https://api.github.com/users/drush-ops/followers","following_url":"https://api.github.com/users/drush-ops/following{/other_user}","gists_url":"https://api.github.com/users/drush-ops/gists{/gist_id}","starred_url":"https://api.github.com/users/drush-ops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drush-ops/subscriptions","organizations_url":"https://api.github.com/users/drush-ops/orgs","repos_url":"https://api.github.com/users/drush-ops/repos","events_url":"https://api.github.com/users/drush-ops/events{/privacy}","received_events_url":"https://api.github.com/users/drush-ops/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/drush-ops/drush","description":"Drush is a command-line shell and scripting interface for Drupal, a veritable Swiss Army knife designed to make life easier for those who spend their working hours hacking away at the command prompt.","fork":false,"url":"https://api.github.com/repos/drush-ops/drush","forks_url":"https://api.github.com/repos/drush-ops/drush/forks","keys_url":"https://api.github.com/repos/drush-ops/drush/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drush-ops/drush/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drush-ops/drush/teams","hooks_url":"https://api.github.com/repos/drush-ops/drush/hooks","issue_events_url":"https://api.github.com/repos/drush-ops/drush/issues/events{/number}","events_url":"https://api.github.com/repos/drush-ops/drush/events","assignees_url":"https://api.github.com/repos/drush-ops/drush/assignees{/user}","branches_url":"https://api.github.com/repos/drush-ops/drush/branches{/branch}","tags_url":"https://api.github.com/repos/drush-ops/drush/tags","blobs_url":"https://api.github.com/repos/drush-ops/drush/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drush-ops/drush/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drush-ops/drush/git/refs{/sha}","trees_url":"https://api.github.com/repos/drush-ops/drush/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drush-ops/drush/statuses/{sha}","languages_url":"https://api.github.com/repos/drush-ops/drush/languages","stargazers_url":"https://api.github.com/repos/drush-ops/drush/stargazers","contributors_url":"https://api.github.com/repos/drush-ops/drush/contributors","subscribers_url":"https://api.github.com/repos/drush-ops/drush/subscribers","subscription_url":"https://api.github.com/repos/drush-ops/drush/subscription","commits_url":"https://api.github.com/repos/drush-ops/drush/commits{/sha}","git_commits_url":"https://api.github.com/repos/drush-ops/drush/git/commits{/sha}","comments_url":"https://api.github.com/repos/drush-ops/drush/comments{/number}","issue_comment_url":"https://api.github.com/repos/drush-ops/drush/issues/comments{/number}","contents_url":"https://api.github.com/repos/drush-ops/drush/contents/{+path}","compare_url":"https://api.github.com/repos/drush-ops/drush/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drush-ops/drush/merges","archive_url":"https://api.github.com/repos/drush-ops/drush/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drush-ops/drush/downloads","issues_url":"https://api.github.com/repos/drush-ops/drush/issues{/number}","pulls_url":"https://api.github.com/repos/drush-ops/drush/pulls{/number}","milestones_url":"https://api.github.com/repos/drush-ops/drush/milestones{/number}","notifications_url":"https://api.github.com/repos/drush-ops/drush/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drush-ops/drush/labels{/name}","releases_url":"https://api.github.com/repos/drush-ops/drush/releases{/id}","deployments_url":"https://api.github.com/repos/drush-ops/drush/deployments","created_at":"2012-01-16T20:26:51Z","updated_at":"2016-09-29T16:49:36Z","pushed_at":"2016-09-29T22:46:17Z","git_url":"git://github.com/drush-ops/drush.git","ssh_url":"git@github.com:drush-ops/drush.git","clone_url":"https://github.com/drush-ops/drush.git","svn_url":"https://github.com/drush-ops/drush","homepage":"","size":23116,"stargazers_count":1478,"watchers_count":1478,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":738,"mirror_url":null,"open_issues_count":443,"forks":738,"open_issues":443,"watchers":1478,"default_branch":"master"}},"base":{"label":"drush-ops:8.x","ref":"8.x","sha":"41e3868fd0de0240b17cd0c6cc4d32cf3f07fa31","user":{"login":"drush-ops","id":931201,"avatar_url":"https://avatars.githubusercontent.com/u/931201?v=3","gravatar_id":"","url":"https://api.github.com/users/drush-ops","html_url":"https://github.com/drush-ops","followers_url":"https://api.github.com/users/drush-ops/followers","following_url":"https://api.github.com/users/drush-ops/following{/other_user}","gists_url":"https://api.github.com/users/drush-ops/gists{/gist_id}","starred_url":"https://api.github.com/users/drush-ops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drush-ops/subscriptions","organizations_url":"https://api.github.com/users/drush-ops/orgs","repos_url":"https://api.github.com/users/drush-ops/repos","events_url":"https://api.github.com/users/drush-ops/events{/privacy}","received_events_url":"https://api.github.com/users/drush-ops/received_events","type":"Organization","site_admin":false},"repo":{"id":3193843,"name":"drush","full_name":"drush-ops/drush","owner":{"login":"drush-ops","id":931201,"avatar_url":"https://avatars.githubusercontent.com/u/931201?v=3","gravatar_id":"","url":"https://api.github.com/users/drush-ops","html_url":"https://github.com/drush-ops","followers_url":"https://api.github.com/users/drush-ops/followers","following_url":"https://api.github.com/users/drush-ops/following{/other_user}","gists_url":"https://api.github.com/users/drush-ops/gists{/gist_id}","starred_url":"https://api.github.com/users/drush-ops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drush-ops/subscriptions","organizations_url":"https://api.github.com/users/drush-ops/orgs","repos_url":"https://api.github.com/users/drush-ops/repos","events_url":"https://api.github.com/users/drush-ops/events{/privacy}","received_events_url":"https://api.github.com/users/drush-ops/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/drush-ops/drush","description":"Drush is a command-line shell and scripting interface for Drupal, a veritable Swiss Army knife designed to make life easier for those who spend their working hours hacking away at the command prompt.","fork":false,"url":"https://api.github.com/repos/drush-ops/drush","forks_url":"https://api.github.com/repos/drush-ops/drush/forks","keys_url":"https://api.github.com/repos/drush-ops/drush/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drush-ops/drush/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drush-ops/drush/teams","hooks_url":"https://api.github.com/repos/drush-ops/drush/hooks","issue_events_url":"https://api.github.com/repos/drush-ops/drush/issues/events{/number}","events_url":"https://api.github.com/repos/drush-ops/drush/events","assignees_url":"https://api.github.com/repos/drush-ops/drush/assignees{/user}","branches_url":"https://api.github.com/repos/drush-ops/drush/branches{/branch}","tags_url":"https://api.github.com/repos/drush-ops/drush/tags","blobs_url":"https://api.github.com/repos/drush-ops/drush/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drush-ops/drush/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drush-ops/drush/git/refs{/sha}","trees_url":"https://api.github.com/repos/drush-ops/drush/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drush-ops/drush/statuses/{sha}","languages_url":"https://api.github.com/repos/drush-ops/drush/languages","stargazers_url":"https://api.github.com/repos/drush-ops/drush/stargazers","contributors_url":"https://api.github.com/repos/drush-ops/drush/contributors","subscribers_url":"https://api.github.com/repos/drush-ops/drush/subscribers","subscription_url":"https://api.github.com/repos/drush-ops/drush/subscription","commits_url":"https://api.github.com/repos/drush-ops/drush/commits{/sha}","git_commits_url":"https://api.github.com/repos/drush-ops/drush/git/commits{/sha}","comments_url":"https://api.github.com/repos/drush-ops/drush/comments{/number}","issue_comment_url":"https://api.github.com/repos/drush-ops/drush/issues/comments{/number}","contents_url":"https://api.github.com/repos/drush-ops/drush/contents/{+path}","compare_url":"https://api.github.com/repos/drush-ops/drush/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drush-ops/drush/merges","archive_url":"https://api.github.com/repos/drush-ops/drush/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drush-ops/drush/downloads","issues_url":"https://api.github.com/repos/drush-ops/drush/issues{/number}","pulls_url":"https://api.github.com/repos/drush-ops/drush/pulls{/number}","milestones_url":"https://api.github.com/repos/drush-ops/drush/milestones{/number}","notifications_url":"https://api.github.com/repos/drush-ops/drush/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drush-ops/drush/labels{/name}","releases_url":"https://api.github.com/repos/drush-ops/drush/releases{/id}","deployments_url":"https://api.github.com/repos/drush-ops/drush/deployments","created_at":"2012-01-16T20:26:51Z","updated_at":"2016-09-29T16:49:36Z","pushed_at":"2016-09-29T22:46:17Z","git_url":"git://github.com/drush-ops/drush.git","ssh_url":"git@github.com:drush-ops/drush.git","clone_url":"https://github.com/drush-ops/drush.git","svn_url":"https://github.com/drush-ops/drush","homepage":"","size":23116,"stargazers_count":1478,"watchers_count":1478,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":738,"mirror_url":null,"open_issues_count":443,"forks":738,"open_issues":443,"watchers":1478,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/drush-ops/drush/pulls/2366"},"html":{"href":"https://github.com/drush-ops/drush/pull/2366"},"issue":{"href":"https://api.github.com/repos/drush-ops/drush/issues/2366"},"comments":{"href":"https://api.github.com/repos/drush-ops/drush/issues/2366/comments"},"review_comments":{"href":"https://api.github.com/repos/drush-ops/drush/pulls/2366/comments"},"review_comment":{"href":"https://api.github.com/repos/drush-ops/drush/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/drush-ops/drush/pulls/2366/commits"},"statuses":{"href":"https://api.github.com/repos/drush-ops/drush/statuses/993ab593ccdd8581d1fa930d1561509fa1abed77"}}}}
{"actor":{"display_login":"greg-1-anderson"}}