{"action":"created","issue":{"url":"https://api.github.com/repos/squaremo/amqp.node/issues/229","repository_url":"https://api.github.com/repos/squaremo/amqp.node","labels_url":"https://api.github.com/repos/squaremo/amqp.node/issues/229/labels{/name}","comments_url":"https://api.github.com/repos/squaremo/amqp.node/issues/229/comments","events_url":"https://api.github.com/repos/squaremo/amqp.node/issues/229/events","html_url":"https://github.com/squaremo/amqp.node/issues/229","id":131093364,"number":229,"title":"No existing functionality to pass in query params in url object","user":{"login":"JasonTowner","id":1108191,"avatar_url":"https://avatars.githubusercontent.com/u/1108191?v=3","gravatar_id":"","url":"https://api.github.com/users/JasonTowner","html_url":"https://github.com/JasonTowner","followers_url":"https://api.github.com/users/JasonTowner/followers","following_url":"https://api.github.com/users/JasonTowner/following{/other_user}","gists_url":"https://api.github.com/users/JasonTowner/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonTowner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonTowner/subscriptions","organizations_url":"https://api.github.com/users/JasonTowner/orgs","repos_url":"https://api.github.com/users/JasonTowner/repos","events_url":"https://api.github.com/users/JasonTowner/events{/privacy}","received_events_url":"https://api.github.com/users/JasonTowner/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-02-03T17:19:03Z","updated_at":"2016-11-10T14:31:25Z","closed_at":null,"body":"amqp support query string params to allow further options on the connection. They are only available with `amqplib` if your param type is a url connection string; if you pass in an object, there is no support for the query string as an object.\n### Missing functionality\n\n`frameMax`\n`channelMax`\n`heartbeat`\n`locale`\n"},"comment":{"url":"https://api.github.com/repos/squaremo/amqp.node/issues/comments/259704202","html_url":"https://github.com/squaremo/amqp.node/issues/229#issuecomment-259704202","issue_url":"https://api.github.com/repos/squaremo/amqp.node/issues/229","id":259704202,"user":{"login":"ikhemissi","id":1769608,"avatar_url":"https://avatars.githubusercontent.com/u/1769608?v=3","gravatar_id":"","url":"https://api.github.com/users/ikhemissi","html_url":"https://github.com/ikhemissi","followers_url":"https://api.github.com/users/ikhemissi/followers","following_url":"https://api.github.com/users/ikhemissi/following{/other_user}","gists_url":"https://api.github.com/users/ikhemissi/gists{/gist_id}","starred_url":"https://api.github.com/users/ikhemissi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikhemissi/subscriptions","organizations_url":"https://api.github.com/users/ikhemissi/orgs","repos_url":"https://api.github.com/users/ikhemissi/repos","events_url":"https://api.github.com/users/ikhemissi/events{/privacy}","received_events_url":"https://api.github.com/users/ikhemissi/received_events","type":"User","site_admin":false},"created_at":"2016-11-10T14:31:24Z","updated_at":"2016-11-10T14:31:24Z","body":"Hi,\r\n\r\nI added an other PR for the same issue, but the difference is that the extra configuration (e.g. heartbeat) is expected in the `url` param of `connect` instead of `socketOptions`: https://github.com/ikhemissi/amqp.node/blob/bb1e6c8efd6ec2d4598512cdedb793527f764b47/lib/connect.js#L90\r\n\r\nI'm happy with whichever PR (#226 or #304) gets merged first, and I'm also happy to make any changes in the #304 to make it follow any contribution guidelines or roadmap goals.\r\n\r\nThanks guys"}}
{"actor":{"display_login":"ikhemissi"}}