{"action":"opened","number":318,"pull_request":{"url":"https://api.github.com/repos/floere/phony/pulls/318","id":65328365,"html_url":"https://github.com/floere/phony/pull/318","diff_url":"https://github.com/floere/phony/pull/318.diff","patch_url":"https://github.com/floere/phony/pull/318.patch","issue_url":"https://api.github.com/repos/floere/phony/issues/318","number":318,"state":"open","locked":false,"title":"Add support for 5 digit Swedish numbers and extend NDCS list","user":{"login":"mentero","id":1586455,"avatar_url":"https://avatars.githubusercontent.com/u/1586455?v=3","gravatar_id":"","url":"https://api.github.com/users/mentero","html_url":"https://github.com/mentero","followers_url":"https://api.github.com/users/mentero/followers","following_url":"https://api.github.com/users/mentero/following{/other_user}","gists_url":"https://api.github.com/users/mentero/gists{/gist_id}","starred_url":"https://api.github.com/users/mentero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mentero/subscriptions","organizations_url":"https://api.github.com/users/mentero/orgs","repos_url":"https://api.github.com/users/mentero/repos","events_url":"https://api.github.com/users/mentero/events{/privacy}","received_events_url":"https://api.github.com/users/mentero/received_events","type":"User","site_admin":false},"body":"Hi everyone!\r\n\r\nWe are using `Phony` in our app with a great success and pleasure but we ran into some issues.\r\nOur product is Sweden based so we have mostly Swedish numbers and not every one of them was passing validations.\r\n\r\nThe most common reason for us was that current implementation of `Phony` does not support 5 digit phone numbers for SE and according to my Swedish client they are not that uncommon - he has one as his home number himself. \r\n\r\nToday one of our users from Tomelillia could not validate his 5 digit number too so I decided to make a patch. I had to add Tomelillia NDCS and enable all the 5-digits.\r\n\r\nI also asked if there is a convention used for splitting 5 digit numbers and was told the `[3, 2]` split is sometimes used. \r\n\r\nSo here you are :)\r\n","created_at":"2016-04-05T15:48:46Z","updated_at":"2016-04-05T15:48:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/floere/phony/pulls/318/commits","review_comments_url":"https://api.github.com/repos/floere/phony/pulls/318/comments","review_comment_url":"https://api.github.com/repos/floere/phony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/floere/phony/issues/318/comments","statuses_url":"https://api.github.com/repos/floere/phony/statuses/11d3f2c58958a1d9524cc312197624c01e88a2e0","head":{"label":"fieldly:master","ref":"master","sha":"11d3f2c58958a1d9524cc312197624c01e88a2e0","user":{"login":"fieldly","id":8399124,"avatar_url":"https://avatars.githubusercontent.com/u/8399124?v=3","gravatar_id":"","url":"https://api.github.com/users/fieldly","html_url":"https://github.com/fieldly","followers_url":"https://api.github.com/users/fieldly/followers","following_url":"https://api.github.com/users/fieldly/following{/other_user}","gists_url":"https://api.github.com/users/fieldly/gists{/gist_id}","starred_url":"https://api.github.com/users/fieldly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fieldly/subscriptions","organizations_url":"https://api.github.com/users/fieldly/orgs","repos_url":"https://api.github.com/users/fieldly/repos","events_url":"https://api.github.com/users/fieldly/events{/privacy}","received_events_url":"https://api.github.com/users/fieldly/received_events","type":"Organization","site_admin":false},"repo":{"id":55513420,"name":"phony","full_name":"fieldly/phony","owner":{"login":"fieldly","id":8399124,"avatar_url":"https://avatars.githubusercontent.com/u/8399124?v=3","gravatar_id":"","url":"https://api.github.com/users/fieldly","html_url":"https://github.com/fieldly","followers_url":"https://api.github.com/users/fieldly/followers","following_url":"https://api.github.com/users/fieldly/following{/other_user}","gists_url":"https://api.github.com/users/fieldly/gists{/gist_id}","starred_url":"https://api.github.com/users/fieldly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fieldly/subscriptions","organizations_url":"https://api.github.com/users/fieldly/orgs","repos_url":"https://api.github.com/users/fieldly/repos","events_url":"https://api.github.com/users/fieldly/events{/privacy}","received_events_url":"https://api.github.com/users/fieldly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fieldly/phony","description":"E164 international phone number normalizing, splitting, formatting. ","fork":true,"url":"https://api.github.com/repos/fieldly/phony","forks_url":"https://api.github.com/repos/fieldly/phony/forks","keys_url":"https://api.github.com/repos/fieldly/phony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fieldly/phony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fieldly/phony/teams","hooks_url":"https://api.github.com/repos/fieldly/phony/hooks","issue_events_url":"https://api.github.com/repos/fieldly/phony/issues/events{/number}","events_url":"https://api.github.com/repos/fieldly/phony/events","assignees_url":"https://api.github.com/repos/fieldly/phony/assignees{/user}","branches_url":"https://api.github.com/repos/fieldly/phony/branches{/branch}","tags_url":"https://api.github.com/repos/fieldly/phony/tags","blobs_url":"https://api.github.com/repos/fieldly/phony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fieldly/phony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fieldly/phony/git/refs{/sha}","trees_url":"https://api.github.com/repos/fieldly/phony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fieldly/phony/statuses/{sha}","languages_url":"https://api.github.com/repos/fieldly/phony/languages","stargazers_url":"https://api.github.com/repos/fieldly/phony/stargazers","contributors_url":"https://api.github.com/repos/fieldly/phony/contributors","subscribers_url":"https://api.github.com/repos/fieldly/phony/subscribers","subscription_url":"https://api.github.com/repos/fieldly/phony/subscription","commits_url":"https://api.github.com/repos/fieldly/phony/commits{/sha}","git_commits_url":"https://api.github.com/repos/fieldly/phony/git/commits{/sha}","comments_url":"https://api.github.com/repos/fieldly/phony/comments{/number}","issue_comment_url":"https://api.github.com/repos/fieldly/phony/issues/comments{/number}","contents_url":"https://api.github.com/repos/fieldly/phony/contents/{+path}","compare_url":"https://api.github.com/repos/fieldly/phony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fieldly/phony/merges","archive_url":"https://api.github.com/repos/fieldly/phony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fieldly/phony/downloads","issues_url":"https://api.github.com/repos/fieldly/phony/issues{/number}","pulls_url":"https://api.github.com/repos/fieldly/phony/pulls{/number}","milestones_url":"https://api.github.com/repos/fieldly/phony/milestones{/number}","notifications_url":"https://api.github.com/repos/fieldly/phony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fieldly/phony/labels{/name}","releases_url":"https://api.github.com/repos/fieldly/phony/releases{/id}","deployments_url":"https://api.github.com/repos/fieldly/phony/deployments","created_at":"2016-04-05T14:10:19Z","updated_at":"2016-04-05T14:10:20Z","pushed_at":"2016-04-05T15:28:29Z","git_url":"git://github.com/fieldly/phony.git","ssh_url":"git@github.com:fieldly/phony.git","clone_url":"https://github.com/fieldly/phony.git","svn_url":"https://github.com/fieldly/phony","homepage":"http://florianhanke.com/phony/","size":5293,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"floere:master","ref":"master","sha":"94ce52a1b3b180456c9edabf30a35f6a03c08d4a","user":{"login":"floere","id":3022,"avatar_url":"https://avatars.githubusercontent.com/u/3022?v=3","gravatar_id":"","url":"https://api.github.com/users/floere","html_url":"https://github.com/floere","followers_url":"https://api.github.com/users/floere/followers","following_url":"https://api.github.com/users/floere/following{/other_user}","gists_url":"https://api.github.com/users/floere/gists{/gist_id}","starred_url":"https://api.github.com/users/floere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floere/subscriptions","organizations_url":"https://api.github.com/users/floere/orgs","repos_url":"https://api.github.com/users/floere/repos","events_url":"https://api.github.com/users/floere/events{/privacy}","received_events_url":"https://api.github.com/users/floere/received_events","type":"User","site_admin":false},"repo":{"id":564719,"name":"phony","full_name":"floere/phony","owner":{"login":"floere","id":3022,"avatar_url":"https://avatars.githubusercontent.com/u/3022?v=3","gravatar_id":"","url":"https://api.github.com/users/floere","html_url":"https://github.com/floere","followers_url":"https://api.github.com/users/floere/followers","following_url":"https://api.github.com/users/floere/following{/other_user}","gists_url":"https://api.github.com/users/floere/gists{/gist_id}","starred_url":"https://api.github.com/users/floere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floere/subscriptions","organizations_url":"https://api.github.com/users/floere/orgs","repos_url":"https://api.github.com/users/floere/repos","events_url":"https://api.github.com/users/floere/events{/privacy}","received_events_url":"https://api.github.com/users/floere/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/floere/phony","description":"E164 international phone number normalizing, splitting, formatting. ","fork":false,"url":"https://api.github.com/repos/floere/phony","forks_url":"https://api.github.com/repos/floere/phony/forks","keys_url":"https://api.github.com/repos/floere/phony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/floere/phony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/floere/phony/teams","hooks_url":"https://api.github.com/repos/floere/phony/hooks","issue_events_url":"https://api.github.com/repos/floere/phony/issues/events{/number}","events_url":"https://api.github.com/repos/floere/phony/events","assignees_url":"https://api.github.com/repos/floere/phony/assignees{/user}","branches_url":"https://api.github.com/repos/floere/phony/branches{/branch}","tags_url":"https://api.github.com/repos/floere/phony/tags","blobs_url":"https://api.github.com/repos/floere/phony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/floere/phony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/floere/phony/git/refs{/sha}","trees_url":"https://api.github.com/repos/floere/phony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/floere/phony/statuses/{sha}","languages_url":"https://api.github.com/repos/floere/phony/languages","stargazers_url":"https://api.github.com/repos/floere/phony/stargazers","contributors_url":"https://api.github.com/repos/floere/phony/contributors","subscribers_url":"https://api.github.com/repos/floere/phony/subscribers","subscription_url":"https://api.github.com/repos/floere/phony/subscription","commits_url":"https://api.github.com/repos/floere/phony/commits{/sha}","git_commits_url":"https://api.github.com/repos/floere/phony/git/commits{/sha}","comments_url":"https://api.github.com/repos/floere/phony/comments{/number}","issue_comment_url":"https://api.github.com/repos/floere/phony/issues/comments{/number}","contents_url":"https://api.github.com/repos/floere/phony/contents/{+path}","compare_url":"https://api.github.com/repos/floere/phony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/floere/phony/merges","archive_url":"https://api.github.com/repos/floere/phony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/floere/phony/downloads","issues_url":"https://api.github.com/repos/floere/phony/issues{/number}","pulls_url":"https://api.github.com/repos/floere/phony/pulls{/number}","milestones_url":"https://api.github.com/repos/floere/phony/milestones{/number}","notifications_url":"https://api.github.com/repos/floere/phony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/floere/phony/labels{/name}","releases_url":"https://api.github.com/repos/floere/phony/releases{/id}","deployments_url":"https://api.github.com/repos/floere/phony/deployments","created_at":"2010-03-16T09:04:51Z","updated_at":"2016-04-04T12:59:18Z","pushed_at":"2016-04-05T15:48:46Z","git_url":"git://github.com/floere/phony.git","ssh_url":"git@github.com:floere/phony.git","clone_url":"https://github.com/floere/phony.git","svn_url":"https://github.com/floere/phony","homepage":"http://florianhanke.com/phony/","size":5434,"stargazers_count":548,"watchers_count":548,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":133,"mirror_url":null,"open_issues_count":4,"forks":133,"open_issues":4,"watchers":548,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/floere/phony/pulls/318"},"html":{"href":"https://github.com/floere/phony/pull/318"},"issue":{"href":"https://api.github.com/repos/floere/phony/issues/318"},"comments":{"href":"https://api.github.com/repos/floere/phony/issues/318/comments"},"review_comments":{"href":"https://api.github.com/repos/floere/phony/pulls/318/comments"},"review_comment":{"href":"https://api.github.com/repos/floere/phony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/floere/phony/pulls/318/commits"},"statuses":{"href":"https://api.github.com/repos/floere/phony/statuses/11d3f2c58958a1d9524cc312197624c01e88a2e0"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":29,"deletions":26,"changed_files":4}}