{"action":"created","issue":{"url":"https://api.github.com/repos/openworm/org.geppetto.model.nwb/issues/7","repository_url":"https://api.github.com/repos/openworm/org.geppetto.model.nwb","labels_url":"https://api.github.com/repos/openworm/org.geppetto.model.nwb/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/openworm/org.geppetto.model.nwb/issues/7/comments","events_url":"https://api.github.com/repos/openworm/org.geppetto.model.nwb/issues/7/events","html_url":"https://github.com/openworm/org.geppetto.model.nwb/issues/7","id":184017965,"number":7,"title":"Refactor types creation in NWB Model Interpreter","user":{"login":"tarelli","id":81127,"avatar_url":"https://avatars.githubusercontent.com/u/81127?v=3","gravatar_id":"","url":"https://api.github.com/users/tarelli","html_url":"https://github.com/tarelli","followers_url":"https://api.github.com/users/tarelli/followers","following_url":"https://api.github.com/users/tarelli/following{/other_user}","gists_url":"https://api.github.com/users/tarelli/gists{/gist_id}","starred_url":"https://api.github.com/users/tarelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarelli/subscriptions","organizations_url":"https://api.github.com/users/tarelli/orgs","repos_url":"https://api.github.com/users/tarelli/repos","events_url":"https://api.github.com/users/tarelli/events{/privacy}","received_events_url":"https://api.github.com/users/tarelli/received_events","type":"User","site_admin":false},"labels":[{"id":389809056,"url":"https://api.github.com/repos/openworm/org.geppetto.model.nwb/labels/ready","name":"ready","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"niteshthali08","id":4617921,"avatar_url":"https://avatars.githubusercontent.com/u/4617921?v=3","gravatar_id":"","url":"https://api.github.com/users/niteshthali08","html_url":"https://github.com/niteshthali08","followers_url":"https://api.github.com/users/niteshthali08/followers","following_url":"https://api.github.com/users/niteshthali08/following{/other_user}","gists_url":"https://api.github.com/users/niteshthali08/gists{/gist_id}","starred_url":"https://api.github.com/users/niteshthali08/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niteshthali08/subscriptions","organizations_url":"https://api.github.com/users/niteshthali08/orgs","repos_url":"https://api.github.com/users/niteshthali08/repos","events_url":"https://api.github.com/users/niteshthali08/events{/privacy}","received_events_url":"https://api.github.com/users/niteshthali08/received_events","type":"User","site_admin":false},"assignees":[{"login":"niteshthali08","id":4617921,"avatar_url":"https://avatars.githubusercontent.com/u/4617921?v=3","gravatar_id":"","url":"https://api.github.com/users/niteshthali08","html_url":"https://github.com/niteshthali08","followers_url":"https://api.github.com/users/niteshthali08/followers","following_url":"https://api.github.com/users/niteshthali08/following{/other_user}","gists_url":"https://api.github.com/users/niteshthali08/gists{/gist_id}","starred_url":"https://api.github.com/users/niteshthali08/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niteshthali08/subscriptions","organizations_url":"https://api.github.com/users/niteshthali08/orgs","repos_url":"https://api.github.com/users/niteshthali08/repos","events_url":"https://api.github.com/users/niteshthali08/events{/privacy}","received_events_url":"https://api.github.com/users/niteshthali08/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2016-10-19T16:54:46Z","updated_at":"2016-11-16T18:56:48Z","closed_at":null,"body":"Currently we are creating a new type for every sweep and for every signal. We need to have only one type of type Sweep and only one type of type Signal. These two types are then reused by all sweeps and all signals (both stimulus and response) in the model.\r\n- [x] Review design\r\n  ![Image](https://www.lucidchart.com/publicSegments/view/627bdb77-6f3b-4063-aaa8-9f35505ec6c6/image.png)\r\n- [x] Refactor creation of types\r\n- [x] Use CompositeValue to specify values for variables nested inside a CompositeType\r\n- [ ] Add to an Instance .getValue() which returns whatever is in the composite value at the higher level Check with @gidili design for this\r\n- [ ] Update unit tests\r\n- [ ] Make sure everything works as before\r\n"},"comment":{"url":"https://api.github.com/repos/openworm/org.geppetto.model.nwb/issues/comments/261037695","html_url":"https://github.com/openworm/org.geppetto.model.nwb/issues/7#issuecomment-261037695","issue_url":"https://api.github.com/repos/openworm/org.geppetto.model.nwb/issues/7","id":261037695,"user":{"login":"tarelli","id":81127,"avatar_url":"https://avatars.githubusercontent.com/u/81127?v=3","gravatar_id":"","url":"https://api.github.com/users/tarelli","html_url":"https://github.com/tarelli","followers_url":"https://api.github.com/users/tarelli/followers","following_url":"https://api.github.com/users/tarelli/following{/other_user}","gists_url":"https://api.github.com/users/tarelli/gists{/gist_id}","starred_url":"https://api.github.com/users/tarelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarelli/subscriptions","organizations_url":"https://api.github.com/users/tarelli/orgs","repos_url":"https://api.github.com/users/tarelli/repos","events_url":"https://api.github.com/users/tarelli/events{/privacy}","received_events_url":"https://api.github.com/users/tarelli/received_events","type":"User","site_admin":false},"created_at":"2016-11-16T18:56:47Z","updated_at":"2016-11-16T18:56:47Z","body":"Regardless, the value if it exists at the type level would still be only a\ndefault to option but if a specific value for that instance is specified\nthat takes the priority. We should have a smart way to avoid traversing\neverything every time we do getValue, something like tracking whether a\ncomposite value has been provided or not to avoid traversing in most cases.\n\nOn Wed, 16 Nov 2016, 19:35 Giovanni Idili, <notifications@github.com> wrote:\n\n> 🙈\n>\n> Is this to happen only if there is not already a value for the variable\n> associated to that instance we do getValue on or regardless?\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/openworm/org.geppetto.model.nwb/issues/7#issuecomment-261031812>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AAE85_nlh2ZBXvoZWxnOkDAVKHHx81A8ks5q-00BgaJpZM4KbNkL>\n> .\n>\n"}}
{"actor":{"display_login":"tarelli"}}