{"action":"created","issue":{"url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/1054","repository_url":"https://api.github.com/repos/BloomBooks/BloomDesktop","labels_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/1054/labels{/name}","comments_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/1054/comments","events_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/1054/events","html_url":"https://github.com/BloomBooks/BloomDesktop/pull/1054","id":153534284,"number":1054,"title":"BL-3307 Make immediately needed thumbnails in foreground","user":{"login":"JohnThomson","id":1360521,"avatar_url":"https://avatars.githubusercontent.com/u/1360521?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnThomson","html_url":"https://github.com/JohnThomson","followers_url":"https://api.github.com/users/JohnThomson/followers","following_url":"https://api.github.com/users/JohnThomson/following{/other_user}","gists_url":"https://api.github.com/users/JohnThomson/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnThomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnThomson/subscriptions","organizations_url":"https://api.github.com/users/JohnThomson/orgs","repos_url":"https://api.github.com/users/JohnThomson/repos","events_url":"https://api.github.com/users/JohnThomson/events{/privacy}","received_events_url":"https://api.github.com/users/JohnThomson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-05-06T20:42:37Z","updated_at":"2016-05-10T20:36:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/1054","html_url":"https://github.com/BloomBooks/BloomDesktop/pull/1054","diff_url":"https://github.com/BloomBooks/BloomDesktop/pull/1054.diff","patch_url":"https://github.com/BloomBooks/BloomDesktop/pull/1054.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/bloombooks/bloomdesktop/1054)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/comments/218283333","html_url":"https://github.com/BloomBooks/BloomDesktop/pull/1054#issuecomment-218283333","issue_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/1054","id":218283333,"user":{"login":"hatton","id":8448,"avatar_url":"https://avatars.githubusercontent.com/u/8448?v=3","gravatar_id":"","url":"https://api.github.com/users/hatton","html_url":"https://github.com/hatton","followers_url":"https://api.github.com/users/hatton/followers","following_url":"https://api.github.com/users/hatton/following{/other_user}","gists_url":"https://api.github.com/users/hatton/gists{/gist_id}","starred_url":"https://api.github.com/users/hatton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatton/subscriptions","organizations_url":"https://api.github.com/users/hatton/orgs","repos_url":"https://api.github.com/users/hatton/repos","events_url":"https://api.github.com/users/hatton/events{/privacy}","received_events_url":"https://api.github.com/users/hatton/received_events","type":"User","site_admin":false},"created_at":"2016-05-10T20:36:56Z","updated_at":"2016-05-10T20:36:56Z","body":"\n\n\n\n\n\nReview status: 0 of 3 files reviewed at latest revision, 3 unresolved discussions.\n\n---\n\n*[src/BloomExe/BookThumbNailer.cs, line 161 \\[r3\\]](https://reviewable.io:443/reviews/bloombooks/bloomdesktop/1054#-KHRNKtKAeKJYMylZ9On:-KHRNKtKAeKJYMylZ9Oo:1903459714) ([raw file](https://github.com/bloombooks/bloomdesktop/blob/13a5caa5329ac106145ab4718ba8a18dc20b87e4/src/BloomExe/BookThumbNailer.cs#L161)):*\n> ```Smalltalk\n> \t\t\tAction<BookInfo, Exception> errorCallback)\n> \t\t{\n> \t\t\tRebuildThumbNail(book, thumbnailOptions, (info, image) => { }, errorCallback, false);\n> ```\n\nSame with the other callback. Synchronous methods can throw, or return, but not do callbacks. Since your only client here supplies a callback that just throws, migh as well remove this parameter and supply your own callback that does the throwing.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/bloombooks/bloomdesktop/1054)*\n<!-- Sent from Reviewable.io -->\n"}}