{"action":"created","comment":{"url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/pulls/comments/75063726","id":75063726,"diff_hunk":"@@ -59,12 +73,36 @@ public Object search(@RequestParam(\"term\") String query, @RequestParam Integer l\n \n         for (ConceptName diagnosis : resultList) {\n             SimpleObject diagnosisObject = new SimpleObject();\n-            diagnosisObject.add(\"conceptName\", diagnosis.getConcept().getName().getName());\n+            diagnosisObject.add(\"conceptName\", getConceptName(diagnosis.getConcept()));\n             diagnosisObject.add(\"conceptUuid\", diagnosis.getConcept().getUuid());\n             diagnosisObject.add(\"matchedName\", diagnosis.getName());\n             allDiagnoses.add(diagnosisObject);\n         }\n         return allDiagnoses;\n     }\n+\n+    private String getConceptName(Concept concept){","path":"omod/src/main/java/org/openmrs/module/emrapi/web/controller/EmrConceptSearchController.java","position":73,"original_position":73,"commit_id":"7ab21137a30baa810fe50ac3b5bafd9c9b5f6b4e","original_commit_id":"7ab21137a30baa810fe50ac3b5bafd9c9b5f6b4e","user":{"login":"sravanthi17","id":8520606,"avatar_url":"https://avatars.githubusercontent.com/u/8520606?v=3","gravatar_id":"","url":"https://api.github.com/users/sravanthi17","html_url":"https://github.com/sravanthi17","followers_url":"https://api.github.com/users/sravanthi17/followers","following_url":"https://api.github.com/users/sravanthi17/following{/other_user}","gists_url":"https://api.github.com/users/sravanthi17/gists{/gist_id}","starred_url":"https://api.github.com/users/sravanthi17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sravanthi17/subscriptions","organizations_url":"https://api.github.com/users/sravanthi17/orgs","repos_url":"https://api.github.com/users/sravanthi17/repos","events_url":"https://api.github.com/users/sravanthi17/events{/privacy}","received_events_url":"https://api.github.com/users/sravanthi17/received_events","type":"User","site_admin":false},"body":"Previously the api is always fetching from English locale. As you rightly said, picking short name is Bahmni-specific behaviour. This has been followed in lot of other places. (Example : https://github.com/openmrs/openmrs-module-emrapi/blob/master/api/src/main/java/org/openmrs/module/emrapi/encounter/ConceptMapper.java#L56)\r\nWe can discuss more on the right way to approach this. ","created_at":"2016-08-17T05:17:55Z","updated_at":"2016-08-17T05:17:55Z","html_url":"https://github.com/openmrs/openmrs-module-emrapi/pull/100#discussion_r75063726","pull_request_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/pulls/100","_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/pulls/comments/75063726"},"html":{"href":"https://github.com/openmrs/openmrs-module-emrapi/pull/100#discussion_r75063726"},"pull_request":{"href":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/pulls/100"}}},"pull_request":{"url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/pulls/100","id":80576253,"html_url":"https://github.com/openmrs/openmrs-module-emrapi/pull/100","diff_url":"https://github.com/openmrs/openmrs-module-emrapi/pull/100.diff","patch_url":"https://github.com/openmrs/openmrs-module-emrapi/pull/100.patch","issue_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/issues/100","number":100,"state":"open","locked":false,"title":"Ravi, Sravanthi |#EA-104 | Populating locale preferred concept names..","user":{"login":"sravanthi17","id":8520606,"avatar_url":"https://avatars.githubusercontent.com/u/8520606?v=3","gravatar_id":"","url":"https://api.github.com/users/sravanthi17","html_url":"https://github.com/sravanthi17","followers_url":"https://api.github.com/users/sravanthi17/followers","following_url":"https://api.github.com/users/sravanthi17/following{/other_user}","gists_url":"https://api.github.com/users/sravanthi17/gists{/gist_id}","starred_url":"https://api.github.com/users/sravanthi17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sravanthi17/subscriptions","organizations_url":"https://api.github.com/users/sravanthi17/orgs","repos_url":"https://api.github.com/users/sravanthi17/repos","events_url":"https://api.github.com/users/sravanthi17/events{/privacy}","received_events_url":"https://api.github.com/users/sravanthi17/received_events","type":"User","site_admin":false},"body":"…in diagnosis auto complete search list\r\n\r\nRefer the corresponding issue raised @ https://issues.openmrs.org/browse/EA-104.\r\n\r\nPlease review and merge the pull request.","created_at":"2016-08-09T07:56:11Z","updated_at":"2016-08-17T05:17:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab4fff2b7cc23ebd6f09ceec096cc37ee01cf26e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/pulls/100/commits","review_comments_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/pulls/100/comments","review_comment_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/issues/100/comments","statuses_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/statuses/7ab21137a30baa810fe50ac3b5bafd9c9b5f6b4e","head":{"label":"sravanthi17:EA-104","ref":"EA-104","sha":"7ab21137a30baa810fe50ac3b5bafd9c9b5f6b4e","user":{"login":"sravanthi17","id":8520606,"avatar_url":"https://avatars.githubusercontent.com/u/8520606?v=3","gravatar_id":"","url":"https://api.github.com/users/sravanthi17","html_url":"https://github.com/sravanthi17","followers_url":"https://api.github.com/users/sravanthi17/followers","following_url":"https://api.github.com/users/sravanthi17/following{/other_user}","gists_url":"https://api.github.com/users/sravanthi17/gists{/gist_id}","starred_url":"https://api.github.com/users/sravanthi17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sravanthi17/subscriptions","organizations_url":"https://api.github.com/users/sravanthi17/orgs","repos_url":"https://api.github.com/users/sravanthi17/repos","events_url":"https://api.github.com/users/sravanthi17/events{/privacy}","received_events_url":"https://api.github.com/users/sravanthi17/received_events","type":"User","site_admin":false},"repo":{"id":29189366,"name":"openmrs-module-emrapi","full_name":"sravanthi17/openmrs-module-emrapi","owner":{"login":"sravanthi17","id":8520606,"avatar_url":"https://avatars.githubusercontent.com/u/8520606?v=3","gravatar_id":"","url":"https://api.github.com/users/sravanthi17","html_url":"https://github.com/sravanthi17","followers_url":"https://api.github.com/users/sravanthi17/followers","following_url":"https://api.github.com/users/sravanthi17/following{/other_user}","gists_url":"https://api.github.com/users/sravanthi17/gists{/gist_id}","starred_url":"https://api.github.com/users/sravanthi17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sravanthi17/subscriptions","organizations_url":"https://api.github.com/users/sravanthi17/orgs","repos_url":"https://api.github.com/users/sravanthi17/repos","events_url":"https://api.github.com/users/sravanthi17/events{/privacy}","received_events_url":"https://api.github.com/users/sravanthi17/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sravanthi17/openmrs-module-emrapi","description":"Higher-level APIs to support building EMR functionality in OpenMRS, to supplement the data-level APIs in the OpenMRS core.","fork":true,"url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi","forks_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/forks","keys_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/teams","hooks_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/hooks","issue_events_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/issues/events{/number}","events_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/events","assignees_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/assignees{/user}","branches_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/branches{/branch}","tags_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/tags","blobs_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/statuses/{sha}","languages_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/languages","stargazers_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/stargazers","contributors_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/contributors","subscribers_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/subscribers","subscription_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/subscription","commits_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/contents/{+path}","compare_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/merges","archive_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/downloads","issues_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/issues{/number}","pulls_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/pulls{/number}","milestones_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/milestones{/number}","notifications_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/labels{/name}","releases_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/releases{/id}","deployments_url":"https://api.github.com/repos/sravanthi17/openmrs-module-emrapi/deployments","created_at":"2015-01-13T12:42:32Z","updated_at":"2015-01-13T12:42:33Z","pushed_at":"2016-08-09T07:54:42Z","git_url":"git://github.com/sravanthi17/openmrs-module-emrapi.git","ssh_url":"git@github.com:sravanthi17/openmrs-module-emrapi.git","clone_url":"https://github.com/sravanthi17/openmrs-module-emrapi.git","svn_url":"https://github.com/sravanthi17/openmrs-module-emrapi","homepage":null,"size":2321,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openmrs:master","ref":"master","sha":"cb0b5ea588a91b1a7cb310633eb6a97407cdac6f","user":{"login":"openmrs","id":860776,"avatar_url":"https://avatars.githubusercontent.com/u/860776?v=3","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"repo":{"id":9158616,"name":"openmrs-module-emrapi","full_name":"openmrs/openmrs-module-emrapi","owner":{"login":"openmrs","id":860776,"avatar_url":"https://avatars.githubusercontent.com/u/860776?v=3","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openmrs/openmrs-module-emrapi","description":"Higher-level APIs to support building EMR functionality in OpenMRS, to supplement the data-level APIs in the OpenMRS core.","fork":false,"url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi","forks_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/forks","keys_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/teams","hooks_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/hooks","issue_events_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/issues/events{/number}","events_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/events","assignees_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/assignees{/user}","branches_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/branches{/branch}","tags_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/tags","blobs_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/statuses/{sha}","languages_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/languages","stargazers_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/stargazers","contributors_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/contributors","subscribers_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/subscribers","subscription_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/subscription","commits_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/contents/{+path}","compare_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/merges","archive_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/downloads","issues_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/issues{/number}","pulls_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/pulls{/number}","milestones_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/milestones{/number}","notifications_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/labels{/name}","releases_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/releases{/id}","deployments_url":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/deployments","created_at":"2013-04-01T23:55:31Z","updated_at":"2016-07-31T06:40:20Z","pushed_at":"2016-08-16T13:31:14Z","git_url":"git://github.com/openmrs/openmrs-module-emrapi.git","ssh_url":"git@github.com:openmrs/openmrs-module-emrapi.git","clone_url":"https://github.com/openmrs/openmrs-module-emrapi.git","svn_url":"https://github.com/openmrs/openmrs-module-emrapi","homepage":null,"size":2648,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":2,"forks":65,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/pulls/100"},"html":{"href":"https://github.com/openmrs/openmrs-module-emrapi/pull/100"},"issue":{"href":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/issues/100"},"comments":{"href":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/openmrs/openmrs-module-emrapi/statuses/7ab21137a30baa810fe50ac3b5bafd9c9b5f6b4e"}}}}
{"actor":{"display_login":"sravanthi17"}}