{"action":"created","issue":{"url":"https://api.github.com/repos/rock-core/base-types/issues/94","repository_url":"https://api.github.com/repos/rock-core/base-types","labels_url":"https://api.github.com/repos/rock-core/base-types/issues/94/labels{/name}","comments_url":"https://api.github.com/repos/rock-core/base-types/issues/94/comments","events_url":"https://api.github.com/repos/rock-core/base-types/issues/94/events","html_url":"https://github.com/rock-core/base-types/pull/94","id":170111308,"number":94,"title":"Splitted base/types to seperate cpp and hpp files","user":{"login":"hemker","id":5691856,"avatar_url":"https://avatars.githubusercontent.com/u/5691856?v=3","gravatar_id":"","url":"https://api.github.com/users/hemker","html_url":"https://github.com/hemker","followers_url":"https://api.github.com/users/hemker/followers","following_url":"https://api.github.com/users/hemker/following{/other_user}","gists_url":"https://api.github.com/users/hemker/gists{/gist_id}","starred_url":"https://api.github.com/users/hemker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hemker/subscriptions","organizations_url":"https://api.github.com/users/hemker/orgs","repos_url":"https://api.github.com/users/hemker/repos","events_url":"https://api.github.com/users/hemker/events{/privacy}","received_events_url":"https://api.github.com/users/hemker/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":45,"created_at":"2016-08-09T08:39:34Z","updated_at":"2016-09-08T12:01:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rock-core/base-types/pulls/94","html_url":"https://github.com/rock-core/base-types/pull/94","diff_url":"https://github.com/rock-core/base-types/pull/94.diff","patch_url":"https://github.com/rock-core/base-types/pull/94.patch"},"body":"We splitted the base-types header-only lib into a separate .cpp/.hpp implementation due to very long orogen parsing times. The old implementation needed about 8 minutes (on a SSD) to finish the orogen phase in base/orogen/types. With the new concept, an enhancement of nearly 6 minutes (parsing times around 2 minutes) can be achieved. Furthermore, we removed some deprecated stuff.\r\n\r\nSplit Pose.hpp into implementation and header\r\n\r\nFloat.hpp: Use std function, not boost ones\r\n\r\nEigen: remove isnotnan and isfinite\r\n\r\nThis is a duplicate of the buildin\r\nallFinite()\r\n\r\nmove guaranteeSPD into TwistWithCovariance.\r\n\r\nThis one includes SVD, which is a big include in the base eigen.\r\n\r\nmoved Wrench.hpp to new src\r\n\r\nmoved TwistWithCovariance.hpp to new lib/src\r\n\r\nmoved Waypoint to new src folder\r\n\r\nre-patched new isnan interface\r\n\r\nsplitted TransformWithCovariance\r\n\r\nsplitted Timueout\r\n\r\nmoved headers to cpp files\r\n\r\nsplitted TimeMark\r\n\r\nremoved inlining\r\n\r\nsplitted Time\r\n\r\nsplitted Temperature\r\n\r\nmoved Point\r\n\r\nsplitted Pressure\r\n\r\nfixed compile errors\r\n\r\nAdded correct PC file for base-types, made base-lib a dummy\r\n\r\nmoved CircularBuffer\r\n\r\nmoved Deprecated\r\n\r\nmoved JointLimitRange\r\n\r\nmoved JointLimits\r\n\r\nmoved JointState\r\n\r\nmoved JointTransform\r\n\r\nmoved JointsTrajectory\r\n\r\nmoved NamedVector\r\n\r\nmoved Odometry\r\n\r\nadded odometry\r\n\r\nported rest of types\r\n\r\nre-removed vector included\r\n\r\nchanged dep to right lib name\r\n\r\ncompile fixes"},"comment":{"url":"https://api.github.com/repos/rock-core/base-types/issues/comments/245575784","html_url":"https://github.com/rock-core/base-types/pull/94#issuecomment-245575784","issue_url":"https://api.github.com/repos/rock-core/base-types/issues/94","id":245575784,"user":{"login":"doudou","id":292,"avatar_url":"https://avatars.githubusercontent.com/u/292?v=3","gravatar_id":"","url":"https://api.github.com/users/doudou","html_url":"https://github.com/doudou","followers_url":"https://api.github.com/users/doudou/followers","following_url":"https://api.github.com/users/doudou/following{/other_user}","gists_url":"https://api.github.com/users/doudou/gists{/gist_id}","starred_url":"https://api.github.com/users/doudou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doudou/subscriptions","organizations_url":"https://api.github.com/users/doudou/orgs","repos_url":"https://api.github.com/users/doudou/repos","events_url":"https://api.github.com/users/doudou/events{/privacy}","received_events_url":"https://api.github.com/users/doudou/received_events","type":"User","site_admin":false},"created_at":"2016-09-08T12:01:25Z","updated_at":"2016-09-08T12:01:25Z","body":"> All right, I'm fine with that (but I guess, I don't have the final call on this).\r\n\r\nThis is base-types. No one does have \"the final call on this\""}}
{"actor":{"display_login":"doudou"}}