{"action":"created","comment":{"url":"https://api.github.com/repos/UW-Hydro/RBM/pulls/comments/51333972","id":51333972,"diff_hunk":"@@ -182,116 +181,116 @@ SUBROUTINE SYSTMM(temp_file,param_file)\n             T_0 = T_head(nr)\n           else \n !\n-!     Interpolation at the downstream boundary\r\n+!     Interpolation at the downstream boundary\n !\n           if(nseg.eq.no_celm(nr)) npndx=3\n-!\r\n-          do ntrp=1,nterp(npndx)\r\n-            npart=nseg+ntrp+ndltp(npndx)\r\n-            xa(ntrp)=x_dist(nr,npart)\r\n-            ta(ntrp)=temp(nr,npart,n1)\r\n-          end do\r\n-          x=x_part(ns)\r\r\n-!\r\n-!     Call the interpolation function\r\n-!\r\n+!\n+          do ntrp=1,nterp(npndx)\n+            npart=nseg+ntrp+ndltp(npndx)\n+            xa(ntrp)=x_dist(nr,npart)\n+            ta(ntrp)=temp(nr,npart,n1)\n+          end do\n+          x=x_part(ns)\n+!\n+!     Call the interpolation function\n+!\n           T_0=tntrp(xa,ta,x,nterp(npndx))\n           end if\n-!\r\n-300 continue\r\n+!\n+300 continue\n 350 continue\n-!\r          dt_calc=dt_part(ns)\r\n-          nncell=segment_cell(nr,nstrt_elm(ns))\r\n-!\r\n-!    Set NCELL0 for purposes of tributary input\r\n-!\r\n-          ncell0=nncell\r\n-          dt_total=dt_calc\r\n-          do nm=no_dt(ns),1,-1\r\n-            z=depth(nncell)\r\n-            call energy(T_0,q_surf,nncell)\r\n-            q_dot=(q_surf/(z*rfac))\r\n-            T_0=T_0+q_dot*dt_calc\r\n-            if(T_0.lt.0.0) T_0=0.0\r\n-!\r\n-!     Look for a tributary.\r\n-!\r\n-            Q1=Q_in(nncell)\r\n-            ntribs=no_tribs(nncell)\r\n-            if(ntribs.gt.0.and..not.DONE) then\r\n-              do ntrb=1,ntribs\r\n-                nr_trib=trib(nncell,ntrb)\r\n-                if(Q_trib(nr_trib).gt.0.0) then\r\n-                  Q2=Q1+Q_trib(nr_trib)\r\n-                  T_0=(Q1*T_0+Q_trib(nr_trib)*T_trib(nr_trib))/Q2\r\n+!          dt_calc=dt_part(ns)\n+          nncell=segment_cell(nr,nstrt_elm(ns))\n+!\n+!    Set NCELL0 for purposes of tributary input\n+!\n+          ncell0=nncell\n+          dt_total=dt_calc\n+          do nm=no_dt(ns),1,-1\n+            z=depth(nncell)\n+            call energy(T_0,q_surf,nncell)\n+            q_dot=(q_surf/(z*rfac))\n+            T_0=T_0+q_dot*dt_calc\n+            if(T_0.lt.0.0) T_0=0.0\n+!","path":"src/Systmm.f90","position":285,"original_position":277,"commit_id":"df2dacca396c00ef9c099928acf9c4cbc63ae29a","original_commit_id":"9dea91ca6c3a786acdf39cf701e20b5e8f6f39be","user":{"login":"bartnijssen","id":1106706,"avatar_url":"https://avatars.githubusercontent.com/u/1106706?v=3","gravatar_id":"","url":"https://api.github.com/users/bartnijssen","html_url":"https://github.com/bartnijssen","followers_url":"https://api.github.com/users/bartnijssen/followers","following_url":"https://api.github.com/users/bartnijssen/following{/other_user}","gists_url":"https://api.github.com/users/bartnijssen/gists{/gist_id}","starred_url":"https://api.github.com/users/bartnijssen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartnijssen/subscriptions","organizations_url":"https://api.github.com/users/bartnijssen/orgs","repos_url":"https://api.github.com/users/bartnijssen/repos","events_url":"https://api.github.com/users/bartnijssen/events{/privacy}","received_events_url":"https://api.github.com/users/bartnijssen/received_events","type":"User","site_admin":false},"body":"Not sure what is going on. I think git is perhaps thrown off a bit by all the whitespace changes, which clutter this entire PR. The better way would have been to fix all the whitespace changes separately and then make the code changes.","created_at":"2016-01-30T00:26:25Z","updated_at":"2016-01-30T00:26:25Z","html_url":"https://github.com/UW-Hydro/RBM/pull/5#discussion_r51333972","pull_request_url":"https://api.github.com/repos/UW-Hydro/RBM/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/UW-Hydro/RBM/pulls/comments/51333972"},"html":{"href":"https://github.com/UW-Hydro/RBM/pull/5#discussion_r51333972"},"pull_request":{"href":"https://api.github.com/repos/UW-Hydro/RBM/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/UW-Hydro/RBM/pulls/5","id":56230539,"html_url":"https://github.com/UW-Hydro/RBM/pull/5","diff_url":"https://github.com/UW-Hydro/RBM/pull/5.diff","patch_url":"https://github.com/UW-Hydro/RBM/pull/5.patch","issue_url":"https://api.github.com/repos/UW-Hydro/RBM/issues/5","number":5,"state":"open","locked":false,"title":"rvic_reservoir develop","user":{"login":"yixinmao","id":5818020,"avatar_url":"https://avatars.githubusercontent.com/u/5818020?v=3","gravatar_id":"","url":"https://api.github.com/users/yixinmao","html_url":"https://github.com/yixinmao","followers_url":"https://api.github.com/users/yixinmao/followers","following_url":"https://api.github.com/users/yixinmao/following{/other_user}","gists_url":"https://api.github.com/users/yixinmao/gists{/gist_id}","starred_url":"https://api.github.com/users/yixinmao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yixinmao/subscriptions","organizations_url":"https://api.github.com/users/yixinmao/orgs","repos_url":"https://api.github.com/users/yixinmao/repos","events_url":"https://api.github.com/users/yixinmao/events{/privacy}","received_events_url":"https://api.github.com/users/yixinmao/received_events","type":"User","site_admin":false},"body":"First time merging in Yixin's changes to RBM code. Major changes:\r\n    - Changed direct RBM input data format (flow and energy files are now split\r\n      into separate lines, each line for one grid cell and one time step)\r\n    - Added tool scripts to link VIC/RVIC/reservoir to RBM:\r\n        * To convert VIC energy fluxes and RVIC/reservoir flow output to RBM\r\n          input format;\r\n        * To prepare RBM control file (\"*_Network\")\r\n    - Cleaned up some unused parameters in RBM code\r\n\r\nOther notes:\r\n    - For several files, it shows that almost every line has been changed; that is just because I got rid of the \"^M\" in the original version from the end of each line\r\n    - Many of the commit history were dealing with the old modified routing model, which we are not using anymore and were completely removed in the latest commit","created_at":"2016-01-15T22:36:15Z","updated_at":"2016-01-30T00:26:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b77383e380012ed3ba7a5f18af869b2460e1054","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/UW-Hydro/RBM/pulls/5/commits","review_comments_url":"https://api.github.com/repos/UW-Hydro/RBM/pulls/5/comments","review_comment_url":"https://api.github.com/repos/UW-Hydro/RBM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UW-Hydro/RBM/issues/5/comments","statuses_url":"https://api.github.com/repos/UW-Hydro/RBM/statuses/df2dacca396c00ef9c099928acf9c4cbc63ae29a","head":{"label":"yixinmao:rvic_reservoir_develop","ref":"rvic_reservoir_develop","sha":"df2dacca396c00ef9c099928acf9c4cbc63ae29a","user":{"login":"yixinmao","id":5818020,"avatar_url":"https://avatars.githubusercontent.com/u/5818020?v=3","gravatar_id":"","url":"https://api.github.com/users/yixinmao","html_url":"https://github.com/yixinmao","followers_url":"https://api.github.com/users/yixinmao/followers","following_url":"https://api.github.com/users/yixinmao/following{/other_user}","gists_url":"https://api.github.com/users/yixinmao/gists{/gist_id}","starred_url":"https://api.github.com/users/yixinmao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yixinmao/subscriptions","organizations_url":"https://api.github.com/users/yixinmao/orgs","repos_url":"https://api.github.com/users/yixinmao/repos","events_url":"https://api.github.com/users/yixinmao/events{/privacy}","received_events_url":"https://api.github.com/users/yixinmao/received_events","type":"User","site_admin":false},"repo":{"id":49684807,"name":"RBM","full_name":"yixinmao/RBM","owner":{"login":"yixinmao","id":5818020,"avatar_url":"https://avatars.githubusercontent.com/u/5818020?v=3","gravatar_id":"","url":"https://api.github.com/users/yixinmao","html_url":"https://github.com/yixinmao","followers_url":"https://api.github.com/users/yixinmao/followers","following_url":"https://api.github.com/users/yixinmao/following{/other_user}","gists_url":"https://api.github.com/users/yixinmao/gists{/gist_id}","starred_url":"https://api.github.com/users/yixinmao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yixinmao/subscriptions","organizations_url":"https://api.github.com/users/yixinmao/orgs","repos_url":"https://api.github.com/users/yixinmao/repos","events_url":"https://api.github.com/users/yixinmao/events{/privacy}","received_events_url":"https://api.github.com/users/yixinmao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yixinmao/RBM","description":"River Basin Model - Stream temperature modeling","fork":true,"url":"https://api.github.com/repos/yixinmao/RBM","forks_url":"https://api.github.com/repos/yixinmao/RBM/forks","keys_url":"https://api.github.com/repos/yixinmao/RBM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yixinmao/RBM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yixinmao/RBM/teams","hooks_url":"https://api.github.com/repos/yixinmao/RBM/hooks","issue_events_url":"https://api.github.com/repos/yixinmao/RBM/issues/events{/number}","events_url":"https://api.github.com/repos/yixinmao/RBM/events","assignees_url":"https://api.github.com/repos/yixinmao/RBM/assignees{/user}","branches_url":"https://api.github.com/repos/yixinmao/RBM/branches{/branch}","tags_url":"https://api.github.com/repos/yixinmao/RBM/tags","blobs_url":"https://api.github.com/repos/yixinmao/RBM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yixinmao/RBM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yixinmao/RBM/git/refs{/sha}","trees_url":"https://api.github.com/repos/yixinmao/RBM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yixinmao/RBM/statuses/{sha}","languages_url":"https://api.github.com/repos/yixinmao/RBM/languages","stargazers_url":"https://api.github.com/repos/yixinmao/RBM/stargazers","contributors_url":"https://api.github.com/repos/yixinmao/RBM/contributors","subscribers_url":"https://api.github.com/repos/yixinmao/RBM/subscribers","subscription_url":"https://api.github.com/repos/yixinmao/RBM/subscription","commits_url":"https://api.github.com/repos/yixinmao/RBM/commits{/sha}","git_commits_url":"https://api.github.com/repos/yixinmao/RBM/git/commits{/sha}","comments_url":"https://api.github.com/repos/yixinmao/RBM/comments{/number}","issue_comment_url":"https://api.github.com/repos/yixinmao/RBM/issues/comments{/number}","contents_url":"https://api.github.com/repos/yixinmao/RBM/contents/{+path}","compare_url":"https://api.github.com/repos/yixinmao/RBM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yixinmao/RBM/merges","archive_url":"https://api.github.com/repos/yixinmao/RBM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yixinmao/RBM/downloads","issues_url":"https://api.github.com/repos/yixinmao/RBM/issues{/number}","pulls_url":"https://api.github.com/repos/yixinmao/RBM/pulls{/number}","milestones_url":"https://api.github.com/repos/yixinmao/RBM/milestones{/number}","notifications_url":"https://api.github.com/repos/yixinmao/RBM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yixinmao/RBM/labels{/name}","releases_url":"https://api.github.com/repos/yixinmao/RBM/releases{/id}","deployments_url":"https://api.github.com/repos/yixinmao/RBM/deployments","created_at":"2016-01-15T00:36:07Z","updated_at":"2016-01-15T00:36:08Z","pushed_at":"2016-01-21T00:15:32Z","git_url":"git://github.com/yixinmao/RBM.git","ssh_url":"git@github.com:yixinmao/RBM.git","clone_url":"https://github.com/yixinmao/RBM.git","svn_url":"https://github.com/yixinmao/RBM","homepage":"","size":115,"stargazers_count":0,"watchers_count":0,"language":"FORTRAN","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"UW-Hydro:rvic_reservoir","ref":"rvic_reservoir","sha":"2a79cc47abe0bb84bf564329a81c08f023dc0671","user":{"login":"UW-Hydro","id":3475662,"avatar_url":"https://avatars.githubusercontent.com/u/3475662?v=3","gravatar_id":"","url":"https://api.github.com/users/UW-Hydro","html_url":"https://github.com/UW-Hydro","followers_url":"https://api.github.com/users/UW-Hydro/followers","following_url":"https://api.github.com/users/UW-Hydro/following{/other_user}","gists_url":"https://api.github.com/users/UW-Hydro/gists{/gist_id}","starred_url":"https://api.github.com/users/UW-Hydro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UW-Hydro/subscriptions","organizations_url":"https://api.github.com/users/UW-Hydro/orgs","repos_url":"https://api.github.com/users/UW-Hydro/repos","events_url":"https://api.github.com/users/UW-Hydro/events{/privacy}","received_events_url":"https://api.github.com/users/UW-Hydro/received_events","type":"Organization","site_admin":false},"repo":{"id":49602965,"name":"RBM","full_name":"UW-Hydro/RBM","owner":{"login":"UW-Hydro","id":3475662,"avatar_url":"https://avatars.githubusercontent.com/u/3475662?v=3","gravatar_id":"","url":"https://api.github.com/users/UW-Hydro","html_url":"https://github.com/UW-Hydro","followers_url":"https://api.github.com/users/UW-Hydro/followers","following_url":"https://api.github.com/users/UW-Hydro/following{/other_user}","gists_url":"https://api.github.com/users/UW-Hydro/gists{/gist_id}","starred_url":"https://api.github.com/users/UW-Hydro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UW-Hydro/subscriptions","organizations_url":"https://api.github.com/users/UW-Hydro/orgs","repos_url":"https://api.github.com/users/UW-Hydro/repos","events_url":"https://api.github.com/users/UW-Hydro/events{/privacy}","received_events_url":"https://api.github.com/users/UW-Hydro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UW-Hydro/RBM","description":"River Basin Model - Stream temperature modeling","fork":false,"url":"https://api.github.com/repos/UW-Hydro/RBM","forks_url":"https://api.github.com/repos/UW-Hydro/RBM/forks","keys_url":"https://api.github.com/repos/UW-Hydro/RBM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UW-Hydro/RBM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UW-Hydro/RBM/teams","hooks_url":"https://api.github.com/repos/UW-Hydro/RBM/hooks","issue_events_url":"https://api.github.com/repos/UW-Hydro/RBM/issues/events{/number}","events_url":"https://api.github.com/repos/UW-Hydro/RBM/events","assignees_url":"https://api.github.com/repos/UW-Hydro/RBM/assignees{/user}","branches_url":"https://api.github.com/repos/UW-Hydro/RBM/branches{/branch}","tags_url":"https://api.github.com/repos/UW-Hydro/RBM/tags","blobs_url":"https://api.github.com/repos/UW-Hydro/RBM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UW-Hydro/RBM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UW-Hydro/RBM/git/refs{/sha}","trees_url":"https://api.github.com/repos/UW-Hydro/RBM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UW-Hydro/RBM/statuses/{sha}","languages_url":"https://api.github.com/repos/UW-Hydro/RBM/languages","stargazers_url":"https://api.github.com/repos/UW-Hydro/RBM/stargazers","contributors_url":"https://api.github.com/repos/UW-Hydro/RBM/contributors","subscribers_url":"https://api.github.com/repos/UW-Hydro/RBM/subscribers","subscription_url":"https://api.github.com/repos/UW-Hydro/RBM/subscription","commits_url":"https://api.github.com/repos/UW-Hydro/RBM/commits{/sha}","git_commits_url":"https://api.github.com/repos/UW-Hydro/RBM/git/commits{/sha}","comments_url":"https://api.github.com/repos/UW-Hydro/RBM/comments{/number}","issue_comment_url":"https://api.github.com/repos/UW-Hydro/RBM/issues/comments{/number}","contents_url":"https://api.github.com/repos/UW-Hydro/RBM/contents/{+path}","compare_url":"https://api.github.com/repos/UW-Hydro/RBM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UW-Hydro/RBM/merges","archive_url":"https://api.github.com/repos/UW-Hydro/RBM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UW-Hydro/RBM/downloads","issues_url":"https://api.github.com/repos/UW-Hydro/RBM/issues{/number}","pulls_url":"https://api.github.com/repos/UW-Hydro/RBM/pulls{/number}","milestones_url":"https://api.github.com/repos/UW-Hydro/RBM/milestones{/number}","notifications_url":"https://api.github.com/repos/UW-Hydro/RBM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UW-Hydro/RBM/labels{/name}","releases_url":"https://api.github.com/repos/UW-Hydro/RBM/releases{/id}","deployments_url":"https://api.github.com/repos/UW-Hydro/RBM/deployments","created_at":"2016-01-13T21:26:50Z","updated_at":"2016-01-13T21:47:04Z","pushed_at":"2016-01-21T00:15:32Z","git_url":"git://github.com/UW-Hydro/RBM.git","ssh_url":"git@github.com:UW-Hydro/RBM.git","clone_url":"https://github.com/UW-Hydro/RBM.git","svn_url":"https://github.com/UW-Hydro/RBM","homepage":"","size":50,"stargazers_count":0,"watchers_count":0,"language":"FORTRAN","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UW-Hydro/RBM/pulls/5"},"html":{"href":"https://github.com/UW-Hydro/RBM/pull/5"},"issue":{"href":"https://api.github.com/repos/UW-Hydro/RBM/issues/5"},"comments":{"href":"https://api.github.com/repos/UW-Hydro/RBM/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/UW-Hydro/RBM/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/UW-Hydro/RBM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UW-Hydro/RBM/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/UW-Hydro/RBM/statuses/df2dacca396c00ef9c099928acf9c4cbc63ae29a"}}}}