{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/dashboard/issues/296","repository_url":"https://api.github.com/repos/kubernetes/dashboard","labels_url":"https://api.github.com/repos/kubernetes/dashboard/issues/296/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/dashboard/issues/296/comments","events_url":"https://api.github.com/repos/kubernetes/dashboard/issues/296/events","html_url":"https://github.com/kubernetes/dashboard/pull/296","id":128831414,"number":296,"title":"Validation and layout on deploy page","user":{"login":"digitalfishpond","id":13361549,"avatar_url":"https://avatars.githubusercontent.com/u/13361549?v=3","gravatar_id":"","url":"https://api.github.com/users/digitalfishpond","html_url":"https://github.com/digitalfishpond","followers_url":"https://api.github.com/users/digitalfishpond/followers","following_url":"https://api.github.com/users/digitalfishpond/following{/other_user}","gists_url":"https://api.github.com/users/digitalfishpond/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalfishpond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalfishpond/subscriptions","organizations_url":"https://api.github.com/users/digitalfishpond/orgs","repos_url":"https://api.github.com/users/digitalfishpond/repos","events_url":"https://api.github.com/users/digitalfishpond/events{/privacy}","received_events_url":"https://api.github.com/users/digitalfishpond/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/dashboard/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":28,"created_at":"2016-01-26T14:14:28Z","updated_at":"2016-02-11T07:39:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/dashboard/pulls/296","html_url":"https://github.com/kubernetes/dashboard/pull/296","diff_url":"https://github.com/kubernetes/dashboard/pull/296.diff","patch_url":"https://github.com/kubernetes/dashboard/pull/296.patch"},"body":"Validation:\r\n1) validation - message not showing when 2 different errors caused consecutively - fixed\r\n2) validation - regex check to ensure lowercase and hyphens only\r\n3) validation - increased responsiveness by replacing ng-model-options with ng-if=\"<model>.$touched\"\r\n4) validation - removed md-progress linear which was causing page to jitter (showing progress bar - creating a new line in the form - for fractions of a second and then hiding again). Validation for unique-name still works.\r\n5) validation - for 'number of pods', added validation message for 'required' as it is possible to remove default value.\r\n\r\nLayout:\r\n6) layout - set default font-size to 14px\r\n7) layout - adjusted alignment between components within a single row by removing .kd-deploy-input-row formatting in scss and adding md-input-container.\r\n8) layout - renamed 'more options / less options' to 'show advanced options / hide advanced options' to avoid grammatical error and clumsiness of 'more options / fewer options'\r\n9) moved 'show advanced options / hide advanced options' toggle to top of advanced options section to avoid having to scroll down to hide, but also added a 'hide advanced options' button at bottom of advanced options section\r\n10) replaced switches for checkboxes contained in 'div' tags to preserve alignment between checkbox and label.\r\n\r\n@bryk, please forgive my inevitable first-timer mistakes, and let me know what I need to change. Many thanks!"},"comment":{"url":"https://api.github.com/repos/kubernetes/dashboard/issues/comments/182750222","html_url":"https://github.com/kubernetes/dashboard/pull/296#issuecomment-182750222","issue_url":"https://api.github.com/repos/kubernetes/dashboard/issues/296","id":182750222,"user":{"login":"digitalfishpond","id":13361549,"avatar_url":"https://avatars.githubusercontent.com/u/13361549?v=3","gravatar_id":"","url":"https://api.github.com/users/digitalfishpond","html_url":"https://github.com/digitalfishpond","followers_url":"https://api.github.com/users/digitalfishpond/followers","following_url":"https://api.github.com/users/digitalfishpond/following{/other_user}","gists_url":"https://api.github.com/users/digitalfishpond/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalfishpond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalfishpond/subscriptions","organizations_url":"https://api.github.com/users/digitalfishpond/orgs","repos_url":"https://api.github.com/users/digitalfishpond/repos","events_url":"https://api.github.com/users/digitalfishpond/events{/privacy}","received_events_url":"https://api.github.com/users/digitalfishpond/received_events","type":"User","site_admin":false},"created_at":"2016-02-11T07:39:34Z","updated_at":"2016-02-11T07:39:34Z","body":"@bryk PTAL"}}