{"action":"created","comment":{"url":"https://api.github.com/repos/holidayextras/culture/pulls/comments/67843499","id":67843499,"diff_hunk":"@@ -0,0 +1,22 @@\n+# HolidayExtras Automated Testing Commandments\n+\n+## Thou shalt be consistent within projects\n+If a project has a de-facto standard, it should be maintained. The process for changing a de-facto standard should take the form of a whiteboard meeting, not a pull request.\n+\n+## Thy tests should be obvious\n+If the test behaviour isn't obvious by looking at it, it's no good. If I have to scroll for days to read a test, it's no good.\n+\n+## Thy tests should be loosely coupled with thy code","path":"testing-commandments.md","position":11,"original_position":9,"commit_id":"7288b895dc5d94909f5d7be546b4c070b90bea6e","original_commit_id":"b6ce7ea2cc45a49a343b31d007ce566742ebd9b8","user":{"login":"theninj4","id":3055120,"avatar_url":"https://avatars.githubusercontent.com/u/3055120?v=3","gravatar_id":"","url":"https://api.github.com/users/theninj4","html_url":"https://github.com/theninj4","followers_url":"https://api.github.com/users/theninj4/followers","following_url":"https://api.github.com/users/theninj4/following{/other_user}","gists_url":"https://api.github.com/users/theninj4/gists{/gist_id}","starred_url":"https://api.github.com/users/theninj4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theninj4/subscriptions","organizations_url":"https://api.github.com/users/theninj4/orgs","repos_url":"https://api.github.com/users/theninj4/repos","events_url":"https://api.github.com/users/theninj4/events{/privacy}","received_events_url":"https://api.github.com/users/theninj4/received_events","type":"User","site_admin":false},"body":"Yes, your example is Ok. However, if you make that change and 50 tests fail, it's not Ok.\r\n\r\nI'm using `Code` to mean the thing that's being tested.","created_at":"2016-06-21T10:22:24Z","updated_at":"2016-06-21T10:22:24Z","html_url":"https://github.com/holidayextras/culture/pull/130#discussion_r67843499","pull_request_url":"https://api.github.com/repos/holidayextras/culture/pulls/130","_links":{"self":{"href":"https://api.github.com/repos/holidayextras/culture/pulls/comments/67843499"},"html":{"href":"https://github.com/holidayextras/culture/pull/130#discussion_r67843499"},"pull_request":{"href":"https://api.github.com/repos/holidayextras/culture/pulls/130"}}},"pull_request":{"url":"https://api.github.com/repos/holidayextras/culture/pulls/130","id":74571185,"html_url":"https://github.com/holidayextras/culture/pull/130","diff_url":"https://github.com/holidayextras/culture/pull/130.diff","patch_url":"https://github.com/holidayextras/culture/pull/130.patch","issue_url":"https://api.github.com/repos/holidayextras/culture/issues/130","number":130,"state":"open","locked":false,"title":"Automated Testing Commandments","user":{"login":"theninj4","id":3055120,"avatar_url":"https://avatars.githubusercontent.com/u/3055120?v=3","gravatar_id":"","url":"https://api.github.com/users/theninj4","html_url":"https://github.com/theninj4","followers_url":"https://api.github.com/users/theninj4/followers","following_url":"https://api.github.com/users/theninj4/following{/other_user}","gists_url":"https://api.github.com/users/theninj4/gists{/gist_id}","starred_url":"https://api.github.com/users/theninj4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theninj4/subscriptions","organizations_url":"https://api.github.com/users/theninj4/orgs","repos_url":"https://api.github.com/users/theninj4/repos","events_url":"https://api.github.com/users/theninj4/events{/privacy}","received_events_url":"https://api.github.com/users/theninj4/received_events","type":"User","site_admin":false},"body":"In an attempt to enable creative thinking without compromising what good testing looks like, I present the 7 commandments of automated testing.","created_at":"2016-06-21T08:37:40Z","updated_at":"2016-06-21T10:22:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5012fa6769002d9232153d60c6c27f50b68b46f4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/holidayextras/culture/pulls/130/commits","review_comments_url":"https://api.github.com/repos/holidayextras/culture/pulls/130/comments","review_comment_url":"https://api.github.com/repos/holidayextras/culture/pulls/comments{/number}","comments_url":"https://api.github.com/repos/holidayextras/culture/issues/130/comments","statuses_url":"https://api.github.com/repos/holidayextras/culture/statuses/7288b895dc5d94909f5d7be546b4c070b90bea6e","head":{"label":"holidayextras:testing-commandments","ref":"testing-commandments","sha":"7288b895dc5d94909f5d7be546b4c070b90bea6e","user":{"login":"holidayextras","id":286993,"avatar_url":"https://avatars.githubusercontent.com/u/286993?v=3","gravatar_id":"","url":"https://api.github.com/users/holidayextras","html_url":"https://github.com/holidayextras","followers_url":"https://api.github.com/users/holidayextras/followers","following_url":"https://api.github.com/users/holidayextras/following{/other_user}","gists_url":"https://api.github.com/users/holidayextras/gists{/gist_id}","starred_url":"https://api.github.com/users/holidayextras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidayextras/subscriptions","organizations_url":"https://api.github.com/users/holidayextras/orgs","repos_url":"https://api.github.com/users/holidayextras/repos","events_url":"https://api.github.com/users/holidayextras/events{/privacy}","received_events_url":"https://api.github.com/users/holidayextras/received_events","type":"Organization","site_admin":false},"repo":{"id":35272731,"name":"culture","full_name":"holidayextras/culture","owner":{"login":"holidayextras","id":286993,"avatar_url":"https://avatars.githubusercontent.com/u/286993?v=3","gravatar_id":"","url":"https://api.github.com/users/holidayextras","html_url":"https://github.com/holidayextras","followers_url":"https://api.github.com/users/holidayextras/followers","following_url":"https://api.github.com/users/holidayextras/following{/other_user}","gists_url":"https://api.github.com/users/holidayextras/gists{/gist_id}","starred_url":"https://api.github.com/users/holidayextras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidayextras/subscriptions","organizations_url":"https://api.github.com/users/holidayextras/orgs","repos_url":"https://api.github.com/users/holidayextras/repos","events_url":"https://api.github.com/users/holidayextras/events{/privacy}","received_events_url":"https://api.github.com/users/holidayextras/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/holidayextras/culture","description":"Coding culture for HX","fork":false,"url":"https://api.github.com/repos/holidayextras/culture","forks_url":"https://api.github.com/repos/holidayextras/culture/forks","keys_url":"https://api.github.com/repos/holidayextras/culture/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holidayextras/culture/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holidayextras/culture/teams","hooks_url":"https://api.github.com/repos/holidayextras/culture/hooks","issue_events_url":"https://api.github.com/repos/holidayextras/culture/issues/events{/number}","events_url":"https://api.github.com/repos/holidayextras/culture/events","assignees_url":"https://api.github.com/repos/holidayextras/culture/assignees{/user}","branches_url":"https://api.github.com/repos/holidayextras/culture/branches{/branch}","tags_url":"https://api.github.com/repos/holidayextras/culture/tags","blobs_url":"https://api.github.com/repos/holidayextras/culture/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holidayextras/culture/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holidayextras/culture/git/refs{/sha}","trees_url":"https://api.github.com/repos/holidayextras/culture/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holidayextras/culture/statuses/{sha}","languages_url":"https://api.github.com/repos/holidayextras/culture/languages","stargazers_url":"https://api.github.com/repos/holidayextras/culture/stargazers","contributors_url":"https://api.github.com/repos/holidayextras/culture/contributors","subscribers_url":"https://api.github.com/repos/holidayextras/culture/subscribers","subscription_url":"https://api.github.com/repos/holidayextras/culture/subscription","commits_url":"https://api.github.com/repos/holidayextras/culture/commits{/sha}","git_commits_url":"https://api.github.com/repos/holidayextras/culture/git/commits{/sha}","comments_url":"https://api.github.com/repos/holidayextras/culture/comments{/number}","issue_comment_url":"https://api.github.com/repos/holidayextras/culture/issues/comments{/number}","contents_url":"https://api.github.com/repos/holidayextras/culture/contents/{+path}","compare_url":"https://api.github.com/repos/holidayextras/culture/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holidayextras/culture/merges","archive_url":"https://api.github.com/repos/holidayextras/culture/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holidayextras/culture/downloads","issues_url":"https://api.github.com/repos/holidayextras/culture/issues{/number}","pulls_url":"https://api.github.com/repos/holidayextras/culture/pulls{/number}","milestones_url":"https://api.github.com/repos/holidayextras/culture/milestones{/number}","notifications_url":"https://api.github.com/repos/holidayextras/culture/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holidayextras/culture/labels{/name}","releases_url":"https://api.github.com/repos/holidayextras/culture/releases{/id}","deployments_url":"https://api.github.com/repos/holidayextras/culture/deployments","created_at":"2015-05-08T10:13:05Z","updated_at":"2016-06-17T08:40:33Z","pushed_at":"2016-06-21T10:02:18Z","git_url":"git://github.com/holidayextras/culture.git","ssh_url":"git@github.com:holidayextras/culture.git","clone_url":"https://github.com/holidayextras/culture.git","svn_url":"https://github.com/holidayextras/culture","homepage":null,"size":3362,"stargazers_count":15,"watchers_count":15,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":14,"forks":4,"open_issues":14,"watchers":15,"default_branch":"master"}},"base":{"label":"holidayextras:master","ref":"master","sha":"62cf455fbab843395c627d22d394fb234c55fa46","user":{"login":"holidayextras","id":286993,"avatar_url":"https://avatars.githubusercontent.com/u/286993?v=3","gravatar_id":"","url":"https://api.github.com/users/holidayextras","html_url":"https://github.com/holidayextras","followers_url":"https://api.github.com/users/holidayextras/followers","following_url":"https://api.github.com/users/holidayextras/following{/other_user}","gists_url":"https://api.github.com/users/holidayextras/gists{/gist_id}","starred_url":"https://api.github.com/users/holidayextras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidayextras/subscriptions","organizations_url":"https://api.github.com/users/holidayextras/orgs","repos_url":"https://api.github.com/users/holidayextras/repos","events_url":"https://api.github.com/users/holidayextras/events{/privacy}","received_events_url":"https://api.github.com/users/holidayextras/received_events","type":"Organization","site_admin":false},"repo":{"id":35272731,"name":"culture","full_name":"holidayextras/culture","owner":{"login":"holidayextras","id":286993,"avatar_url":"https://avatars.githubusercontent.com/u/286993?v=3","gravatar_id":"","url":"https://api.github.com/users/holidayextras","html_url":"https://github.com/holidayextras","followers_url":"https://api.github.com/users/holidayextras/followers","following_url":"https://api.github.com/users/holidayextras/following{/other_user}","gists_url":"https://api.github.com/users/holidayextras/gists{/gist_id}","starred_url":"https://api.github.com/users/holidayextras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidayextras/subscriptions","organizations_url":"https://api.github.com/users/holidayextras/orgs","repos_url":"https://api.github.com/users/holidayextras/repos","events_url":"https://api.github.com/users/holidayextras/events{/privacy}","received_events_url":"https://api.github.com/users/holidayextras/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/holidayextras/culture","description":"Coding culture for HX","fork":false,"url":"https://api.github.com/repos/holidayextras/culture","forks_url":"https://api.github.com/repos/holidayextras/culture/forks","keys_url":"https://api.github.com/repos/holidayextras/culture/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holidayextras/culture/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holidayextras/culture/teams","hooks_url":"https://api.github.com/repos/holidayextras/culture/hooks","issue_events_url":"https://api.github.com/repos/holidayextras/culture/issues/events{/number}","events_url":"https://api.github.com/repos/holidayextras/culture/events","assignees_url":"https://api.github.com/repos/holidayextras/culture/assignees{/user}","branches_url":"https://api.github.com/repos/holidayextras/culture/branches{/branch}","tags_url":"https://api.github.com/repos/holidayextras/culture/tags","blobs_url":"https://api.github.com/repos/holidayextras/culture/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holidayextras/culture/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holidayextras/culture/git/refs{/sha}","trees_url":"https://api.github.com/repos/holidayextras/culture/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holidayextras/culture/statuses/{sha}","languages_url":"https://api.github.com/repos/holidayextras/culture/languages","stargazers_url":"https://api.github.com/repos/holidayextras/culture/stargazers","contributors_url":"https://api.github.com/repos/holidayextras/culture/contributors","subscribers_url":"https://api.github.com/repos/holidayextras/culture/subscribers","subscription_url":"https://api.github.com/repos/holidayextras/culture/subscription","commits_url":"https://api.github.com/repos/holidayextras/culture/commits{/sha}","git_commits_url":"https://api.github.com/repos/holidayextras/culture/git/commits{/sha}","comments_url":"https://api.github.com/repos/holidayextras/culture/comments{/number}","issue_comment_url":"https://api.github.com/repos/holidayextras/culture/issues/comments{/number}","contents_url":"https://api.github.com/repos/holidayextras/culture/contents/{+path}","compare_url":"https://api.github.com/repos/holidayextras/culture/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holidayextras/culture/merges","archive_url":"https://api.github.com/repos/holidayextras/culture/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holidayextras/culture/downloads","issues_url":"https://api.github.com/repos/holidayextras/culture/issues{/number}","pulls_url":"https://api.github.com/repos/holidayextras/culture/pulls{/number}","milestones_url":"https://api.github.com/repos/holidayextras/culture/milestones{/number}","notifications_url":"https://api.github.com/repos/holidayextras/culture/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holidayextras/culture/labels{/name}","releases_url":"https://api.github.com/repos/holidayextras/culture/releases{/id}","deployments_url":"https://api.github.com/repos/holidayextras/culture/deployments","created_at":"2015-05-08T10:13:05Z","updated_at":"2016-06-17T08:40:33Z","pushed_at":"2016-06-21T10:02:18Z","git_url":"git://github.com/holidayextras/culture.git","ssh_url":"git@github.com:holidayextras/culture.git","clone_url":"https://github.com/holidayextras/culture.git","svn_url":"https://github.com/holidayextras/culture","homepage":null,"size":3362,"stargazers_count":15,"watchers_count":15,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":14,"forks":4,"open_issues":14,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/holidayextras/culture/pulls/130"},"html":{"href":"https://github.com/holidayextras/culture/pull/130"},"issue":{"href":"https://api.github.com/repos/holidayextras/culture/issues/130"},"comments":{"href":"https://api.github.com/repos/holidayextras/culture/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/holidayextras/culture/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/holidayextras/culture/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/holidayextras/culture/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/holidayextras/culture/statuses/7288b895dc5d94909f5d7be546b4c070b90bea6e"}}}}
{"actor":{"display_login":"theninj4"}}