{"action":"created","comment":{"url":"https://api.github.com/repos/LMMS/lmms/pulls/comments/87881693","pull_request_review_id":8474068,"id":87881693,"diff_hunk":"@@ -90,37 +283,57 @@ class InstrumentFunctionNoteStacking : public Model, public JournallingObject\n \t\t\treturn size() == 0;\n \t\t}\n \n-\t\tbool hasSemiTone( int8_t semiTone ) const;\n+\t\tbool hasSemiTone(int8_t semiTone) const;\n \n-\t\tint8_t last() const\n+\t\tconst int8_t &last() const\n \t\t{\n-\t\t\treturn m_semiTones[size() - 1];\n+\t\t\treturn m_semiTones.last().key;\n \t\t}\n \n-\t\tconst QString & getName() const\n+\t\tconst QString &getName() const\n \t\t{\n \t\t\treturn m_name;\n \t\t}\n \n-\t\tint8_t operator [] ( int n ) const\n-\t\t{\n+\t\tint8_t operator[](int n) const {\n+\t\t\t// recalling the ChordSemiTones overloaded operator [], which returns the\n+\t\t\t// key, for the sake of compatibility\n \t\t\treturn m_semiTones[n];\n \t\t}\n-\t};\n+\n+\t\tconst ChordSemiTones getChordSemiTones() const\n+\t\t{\n+\t\t\treturn m_semiTones;\n+\t\t}\n \n \n-\tstruct ChordTable : public QVector<Chord>\n-\t{\n+\t\t/**\n+\t\t* In opposition to the overloaded [] this gets the ChordSemiTone object\n+\t\t* @brief at\n+\t\t* @param i\n+\t\t* @return\n+\t\t*/\n+\t\tconst ChordSemiTone at(int i) const {","path":"include/InstrumentFunctions.h","position":296,"original_position":296,"commit_id":"060bdbe512f193082a16a4e398459bf099bda7d2","original_commit_id":"060bdbe512f193082a16a4e398459bf099bda7d2","user":{"login":"BaraMGB","id":6502580,"avatar_url":"https://avatars.githubusercontent.com/u/6502580?v=3","gravatar_id":"","url":"https://api.github.com/users/BaraMGB","html_url":"https://github.com/BaraMGB","followers_url":"https://api.github.com/users/BaraMGB/followers","following_url":"https://api.github.com/users/BaraMGB/following{/other_user}","gists_url":"https://api.github.com/users/BaraMGB/gists{/gist_id}","starred_url":"https://api.github.com/users/BaraMGB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BaraMGB/subscriptions","organizations_url":"https://api.github.com/users/BaraMGB/orgs","repos_url":"https://api.github.com/users/BaraMGB/repos","events_url":"https://api.github.com/users/BaraMGB/events{/privacy}","received_events_url":"https://api.github.com/users/BaraMGB/received_events","type":"User","site_admin":false},"body":"Brace again ","created_at":"2016-11-14T20:05:45Z","updated_at":"2016-11-14T20:13:26Z","html_url":"https://github.com/LMMS/lmms/pull/3117#discussion_r87881693","pull_request_url":"https://api.github.com/repos/LMMS/lmms/pulls/3117","_links":{"self":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/comments/87881693"},"html":{"href":"https://github.com/LMMS/lmms/pull/3117#discussion_r87881693"},"pull_request":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/3117"}}},"pull_request":{"url":"https://api.github.com/repos/LMMS/lmms/pulls/3117","id":93447344,"html_url":"https://github.com/LMMS/lmms/pull/3117","diff_url":"https://github.com/LMMS/lmms/pull/3117.diff","patch_url":"https://github.com/LMMS/lmms/pull/3117.patch","issue_url":"https://api.github.com/repos/LMMS/lmms/issues/3117","number":3117,"state":"open","locked":false,"title":"Enhanced arpeggio - rebased to master, fixed formatting and compile","user":{"login":"Rikislav","id":13100084,"avatar_url":"https://avatars.githubusercontent.com/u/13100084?v=3","gravatar_id":"","url":"https://api.github.com/users/Rikislav","html_url":"https://github.com/Rikislav","followers_url":"https://api.github.com/users/Rikislav/followers","following_url":"https://api.github.com/users/Rikislav/following{/other_user}","gists_url":"https://api.github.com/users/Rikislav/gists{/gist_id}","starred_url":"https://api.github.com/users/Rikislav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rikislav/subscriptions","organizations_url":"https://api.github.com/users/Rikislav/orgs","repos_url":"https://api.github.com/users/Rikislav/repos","events_url":"https://api.github.com/users/Rikislav/events{/privacy}","received_events_url":"https://api.github.com/users/Rikislav/received_events","type":"User","site_admin":false},"body":"I'm trying to enhance the arpeggio functions by changing the int8 key semitones array into a structure which can hold data, at present pan and volume.\r\n\r\nThe chords are now a hardcoded QString, with the future objective to put data into a text or xml file which will be edited through a dedicated controller.\r\n\r\nI added to the chords some examples which can show the possibilities (the Pan ones actually change volume and pan), in future releases things should of course be organized better\r\n\r\nHere some simple demonstration: [herostrat/lmms](http://www.herostrat.site/lmms/)\r\n\r\nPS. I am not a pro c++ programmer, and I guess would need some correction/advice for my empiric solution as to deal with pointers, vectors etc.. Forgive my naive comments, too\r\n","created_at":"2016-11-12T18:27:16Z","updated_at":"2016-11-14T20:13:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82a9ff4f0e65bfb022c098c03ce0e7c6cdcdb05d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/LMMS/lmms/pulls/3117/commits","review_comments_url":"https://api.github.com/repos/LMMS/lmms/pulls/3117/comments","review_comment_url":"https://api.github.com/repos/LMMS/lmms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LMMS/lmms/issues/3117/comments","statuses_url":"https://api.github.com/repos/LMMS/lmms/statuses/060bdbe512f193082a16a4e398459bf099bda7d2","head":{"label":"Rikislav:master","ref":"master","sha":"060bdbe512f193082a16a4e398459bf099bda7d2","user":{"login":"Rikislav","id":13100084,"avatar_url":"https://avatars.githubusercontent.com/u/13100084?v=3","gravatar_id":"","url":"https://api.github.com/users/Rikislav","html_url":"https://github.com/Rikislav","followers_url":"https://api.github.com/users/Rikislav/followers","following_url":"https://api.github.com/users/Rikislav/following{/other_user}","gists_url":"https://api.github.com/users/Rikislav/gists{/gist_id}","starred_url":"https://api.github.com/users/Rikislav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rikislav/subscriptions","organizations_url":"https://api.github.com/users/Rikislav/orgs","repos_url":"https://api.github.com/users/Rikislav/repos","events_url":"https://api.github.com/users/Rikislav/events{/privacy}","received_events_url":"https://api.github.com/users/Rikislav/received_events","type":"User","site_admin":false},"repo":{"id":72439426,"name":"lmms","full_name":"Rikislav/lmms","owner":{"login":"Rikislav","id":13100084,"avatar_url":"https://avatars.githubusercontent.com/u/13100084?v=3","gravatar_id":"","url":"https://api.github.com/users/Rikislav","html_url":"https://github.com/Rikislav","followers_url":"https://api.github.com/users/Rikislav/followers","following_url":"https://api.github.com/users/Rikislav/following{/other_user}","gists_url":"https://api.github.com/users/Rikislav/gists{/gist_id}","starred_url":"https://api.github.com/users/Rikislav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rikislav/subscriptions","organizations_url":"https://api.github.com/users/Rikislav/orgs","repos_url":"https://api.github.com/users/Rikislav/repos","events_url":"https://api.github.com/users/Rikislav/events{/privacy}","received_events_url":"https://api.github.com/users/Rikislav/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Rikislav/lmms","description":"Cross-platform music production software","fork":true,"url":"https://api.github.com/repos/Rikislav/lmms","forks_url":"https://api.github.com/repos/Rikislav/lmms/forks","keys_url":"https://api.github.com/repos/Rikislav/lmms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rikislav/lmms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rikislav/lmms/teams","hooks_url":"https://api.github.com/repos/Rikislav/lmms/hooks","issue_events_url":"https://api.github.com/repos/Rikislav/lmms/issues/events{/number}","events_url":"https://api.github.com/repos/Rikislav/lmms/events","assignees_url":"https://api.github.com/repos/Rikislav/lmms/assignees{/user}","branches_url":"https://api.github.com/repos/Rikislav/lmms/branches{/branch}","tags_url":"https://api.github.com/repos/Rikislav/lmms/tags","blobs_url":"https://api.github.com/repos/Rikislav/lmms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rikislav/lmms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rikislav/lmms/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rikislav/lmms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rikislav/lmms/statuses/{sha}","languages_url":"https://api.github.com/repos/Rikislav/lmms/languages","stargazers_url":"https://api.github.com/repos/Rikislav/lmms/stargazers","contributors_url":"https://api.github.com/repos/Rikislav/lmms/contributors","subscribers_url":"https://api.github.com/repos/Rikislav/lmms/subscribers","subscription_url":"https://api.github.com/repos/Rikislav/lmms/subscription","commits_url":"https://api.github.com/repos/Rikislav/lmms/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rikislav/lmms/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rikislav/lmms/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rikislav/lmms/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rikislav/lmms/contents/{+path}","compare_url":"https://api.github.com/repos/Rikislav/lmms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rikislav/lmms/merges","archive_url":"https://api.github.com/repos/Rikislav/lmms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rikislav/lmms/downloads","issues_url":"https://api.github.com/repos/Rikislav/lmms/issues{/number}","pulls_url":"https://api.github.com/repos/Rikislav/lmms/pulls{/number}","milestones_url":"https://api.github.com/repos/Rikislav/lmms/milestones{/number}","notifications_url":"https://api.github.com/repos/Rikislav/lmms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rikislav/lmms/labels{/name}","releases_url":"https://api.github.com/repos/Rikislav/lmms/releases{/id}","deployments_url":"https://api.github.com/repos/Rikislav/lmms/deployments","created_at":"2016-10-31T13:35:20Z","updated_at":"2016-10-31T13:35:29Z","pushed_at":"2016-11-14T17:26:45Z","git_url":"git://github.com/Rikislav/lmms.git","ssh_url":"git@github.com:Rikislav/lmms.git","clone_url":"https://github.com/Rikislav/lmms.git","svn_url":"https://github.com/Rikislav/lmms","homepage":"https://lmms.io/","size":73552,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"controller-arpeggio"}},"base":{"label":"LMMS:master","ref":"master","sha":"27a2748b69960588cdfd9dca97260184628eee65","user":{"login":"LMMS","id":6363159,"avatar_url":"https://avatars.githubusercontent.com/u/6363159?v=3","gravatar_id":"","url":"https://api.github.com/users/LMMS","html_url":"https://github.com/LMMS","followers_url":"https://api.github.com/users/LMMS/followers","following_url":"https://api.github.com/users/LMMS/following{/other_user}","gists_url":"https://api.github.com/users/LMMS/gists{/gist_id}","starred_url":"https://api.github.com/users/LMMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LMMS/subscriptions","organizations_url":"https://api.github.com/users/LMMS/orgs","repos_url":"https://api.github.com/users/LMMS/repos","events_url":"https://api.github.com/users/LMMS/events{/privacy}","received_events_url":"https://api.github.com/users/LMMS/received_events","type":"Organization","site_admin":false},"repo":{"id":15778896,"name":"lmms","full_name":"LMMS/lmms","owner":{"login":"LMMS","id":6363159,"avatar_url":"https://avatars.githubusercontent.com/u/6363159?v=3","gravatar_id":"","url":"https://api.github.com/users/LMMS","html_url":"https://github.com/LMMS","followers_url":"https://api.github.com/users/LMMS/followers","following_url":"https://api.github.com/users/LMMS/following{/other_user}","gists_url":"https://api.github.com/users/LMMS/gists{/gist_id}","starred_url":"https://api.github.com/users/LMMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LMMS/subscriptions","organizations_url":"https://api.github.com/users/LMMS/orgs","repos_url":"https://api.github.com/users/LMMS/repos","events_url":"https://api.github.com/users/LMMS/events{/privacy}","received_events_url":"https://api.github.com/users/LMMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LMMS/lmms","description":"Cross-platform music production software","fork":false,"url":"https://api.github.com/repos/LMMS/lmms","forks_url":"https://api.github.com/repos/LMMS/lmms/forks","keys_url":"https://api.github.com/repos/LMMS/lmms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LMMS/lmms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LMMS/lmms/teams","hooks_url":"https://api.github.com/repos/LMMS/lmms/hooks","issue_events_url":"https://api.github.com/repos/LMMS/lmms/issues/events{/number}","events_url":"https://api.github.com/repos/LMMS/lmms/events","assignees_url":"https://api.github.com/repos/LMMS/lmms/assignees{/user}","branches_url":"https://api.github.com/repos/LMMS/lmms/branches{/branch}","tags_url":"https://api.github.com/repos/LMMS/lmms/tags","blobs_url":"https://api.github.com/repos/LMMS/lmms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LMMS/lmms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LMMS/lmms/git/refs{/sha}","trees_url":"https://api.github.com/repos/LMMS/lmms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LMMS/lmms/statuses/{sha}","languages_url":"https://api.github.com/repos/LMMS/lmms/languages","stargazers_url":"https://api.github.com/repos/LMMS/lmms/stargazers","contributors_url":"https://api.github.com/repos/LMMS/lmms/contributors","subscribers_url":"https://api.github.com/repos/LMMS/lmms/subscribers","subscription_url":"https://api.github.com/repos/LMMS/lmms/subscription","commits_url":"https://api.github.com/repos/LMMS/lmms/commits{/sha}","git_commits_url":"https://api.github.com/repos/LMMS/lmms/git/commits{/sha}","comments_url":"https://api.github.com/repos/LMMS/lmms/comments{/number}","issue_comment_url":"https://api.github.com/repos/LMMS/lmms/issues/comments{/number}","contents_url":"https://api.github.com/repos/LMMS/lmms/contents/{+path}","compare_url":"https://api.github.com/repos/LMMS/lmms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LMMS/lmms/merges","archive_url":"https://api.github.com/repos/LMMS/lmms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LMMS/lmms/downloads","issues_url":"https://api.github.com/repos/LMMS/lmms/issues{/number}","pulls_url":"https://api.github.com/repos/LMMS/lmms/pulls{/number}","milestones_url":"https://api.github.com/repos/LMMS/lmms/milestones{/number}","notifications_url":"https://api.github.com/repos/LMMS/lmms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LMMS/lmms/labels{/name}","releases_url":"https://api.github.com/repos/LMMS/lmms/releases{/id}","deployments_url":"https://api.github.com/repos/LMMS/lmms/deployments","created_at":"2014-01-09T20:43:43Z","updated_at":"2016-11-14T06:37:14Z","pushed_at":"2016-11-14T16:52:33Z","git_url":"git://github.com/LMMS/lmms.git","ssh_url":"git@github.com:LMMS/lmms.git","clone_url":"https://github.com/LMMS/lmms.git","svn_url":"https://github.com/LMMS/lmms","homepage":"https://lmms.io/","size":84445,"stargazers_count":976,"watchers_count":976,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":250,"mirror_url":null,"open_issues_count":539,"forks":250,"open_issues":539,"watchers":976,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/3117"},"html":{"href":"https://github.com/LMMS/lmms/pull/3117"},"issue":{"href":"https://api.github.com/repos/LMMS/lmms/issues/3117"},"comments":{"href":"https://api.github.com/repos/LMMS/lmms/issues/3117/comments"},"review_comments":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/3117/comments"},"review_comment":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/3117/commits"},"statuses":{"href":"https://api.github.com/repos/LMMS/lmms/statuses/060bdbe512f193082a16a4e398459bf099bda7d2"}}}}
{"actor":{"display_login":"BaraMGB"}}