{"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/pulls/comments/93332571","pull_request_review_id":13858135,"id":93332571,"diff_hunk":"@@ -0,0 +1,29 @@\n+class AbstractView {\n+\n+  getMarkup() {\n+    if (!this.template) {","path":"js/class-abstract-view.js","position":4,"original_position":4,"commit_id":"b399ad6e7c063d94c3eac9f2224f227398c73a71","original_commit_id":"b399ad6e7c063d94c3eac9f2224f227398c73a71","user":{"login":"vetrov","id":220085,"avatar_url":"https://avatars.githubusercontent.com/u/220085?v=3","gravatar_id":"","url":"https://api.github.com/users/vetrov","html_url":"https://github.com/vetrov","followers_url":"https://api.github.com/users/vetrov/followers","following_url":"https://api.github.com/users/vetrov/following{/other_user}","gists_url":"https://api.github.com/users/vetrov/gists{/gist_id}","starred_url":"https://api.github.com/users/vetrov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vetrov/subscriptions","organizations_url":"https://api.github.com/users/vetrov/orgs","repos_url":"https://api.github.com/users/vetrov/repos","events_url":"https://api.github.com/users/vetrov/events{/privacy}","received_events_url":"https://api.github.com/users/vetrov/received_events","type":"User","site_admin":false},"body":"А нужна ли вообще эта this.template? Мне не нравится, что уже в абстрактном классе появляется зависимость от некой переменной, определяемой только в потомках. \r\n\r\nЯ бы постарался сделать так, чтобы getMarkup переопределялась в потомках и прямо возвращала разметку. Так понятнее и проще.","created_at":"2016-12-20T21:48:59Z","updated_at":"2016-12-20T21:48:59Z","html_url":"https://github.com/htmlacademy-ecmascript/179111-pixel-hunter/pull/10#discussion_r93332571","pull_request_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/pulls/comments/93332571"},"html":{"href":"https://github.com/htmlacademy-ecmascript/179111-pixel-hunter/pull/10#discussion_r93332571"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/pulls/10","id":98200538,"html_url":"https://github.com/htmlacademy-ecmascript/179111-pixel-hunter/pull/10","diff_url":"https://github.com/htmlacademy-ecmascript/179111-pixel-hunter/pull/10.diff","patch_url":"https://github.com/htmlacademy-ecmascript/179111-pixel-hunter/pull/10.patch","issue_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/issues/10","number":10,"state":"open","locked":false,"title":"Модельный показ","user":{"login":"bolshovalexandr","id":19558362,"avatar_url":"https://avatars.githubusercontent.com/u/19558362?v=3","gravatar_id":"","url":"https://api.github.com/users/bolshovalexandr","html_url":"https://github.com/bolshovalexandr","followers_url":"https://api.github.com/users/bolshovalexandr/followers","following_url":"https://api.github.com/users/bolshovalexandr/following{/other_user}","gists_url":"https://api.github.com/users/bolshovalexandr/gists{/gist_id}","starred_url":"https://api.github.com/users/bolshovalexandr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bolshovalexandr/subscriptions","organizations_url":"https://api.github.com/users/bolshovalexandr/orgs","repos_url":"https://api.github.com/users/bolshovalexandr/repos","events_url":"https://api.github.com/users/bolshovalexandr/events{/privacy}","received_events_url":"https://api.github.com/users/bolshovalexandr/received_events","type":"User","site_admin":false},"body":"\n\n--\n:boom: https://htmlacademy-ecmascript.github.io/179111-pixel-hunter/10/","created_at":"2016-12-15T18:00:23Z","updated_at":"2016-12-20T21:48:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d9147ef1078df09329f77705342ff88c5f7b91f","assignee":{"login":"vetrov","id":220085,"avatar_url":"https://avatars.githubusercontent.com/u/220085?v=3","gravatar_id":"","url":"https://api.github.com/users/vetrov","html_url":"https://github.com/vetrov","followers_url":"https://api.github.com/users/vetrov/followers","following_url":"https://api.github.com/users/vetrov/following{/other_user}","gists_url":"https://api.github.com/users/vetrov/gists{/gist_id}","starred_url":"https://api.github.com/users/vetrov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vetrov/subscriptions","organizations_url":"https://api.github.com/users/vetrov/orgs","repos_url":"https://api.github.com/users/vetrov/repos","events_url":"https://api.github.com/users/vetrov/events{/privacy}","received_events_url":"https://api.github.com/users/vetrov/received_events","type":"User","site_admin":false},"assignees":[{"login":"vetrov","id":220085,"avatar_url":"https://avatars.githubusercontent.com/u/220085?v=3","gravatar_id":"","url":"https://api.github.com/users/vetrov","html_url":"https://github.com/vetrov","followers_url":"https://api.github.com/users/vetrov/followers","following_url":"https://api.github.com/users/vetrov/following{/other_user}","gists_url":"https://api.github.com/users/vetrov/gists{/gist_id}","starred_url":"https://api.github.com/users/vetrov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vetrov/subscriptions","organizations_url":"https://api.github.com/users/vetrov/orgs","repos_url":"https://api.github.com/users/vetrov/repos","events_url":"https://api.github.com/users/vetrov/events{/privacy}","received_events_url":"https://api.github.com/users/vetrov/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/pulls/10/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/pulls/10/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/issues/10/comments","statuses_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/statuses/b399ad6e7c063d94c3eac9f2224f227398c73a71","head":{"label":"bolshovalexandr:module5-task1","ref":"module5-task1","sha":"b399ad6e7c063d94c3eac9f2224f227398c73a71","user":{"login":"bolshovalexandr","id":19558362,"avatar_url":"https://avatars.githubusercontent.com/u/19558362?v=3","gravatar_id":"","url":"https://api.github.com/users/bolshovalexandr","html_url":"https://github.com/bolshovalexandr","followers_url":"https://api.github.com/users/bolshovalexandr/followers","following_url":"https://api.github.com/users/bolshovalexandr/following{/other_user}","gists_url":"https://api.github.com/users/bolshovalexandr/gists{/gist_id}","starred_url":"https://api.github.com/users/bolshovalexandr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bolshovalexandr/subscriptions","organizations_url":"https://api.github.com/users/bolshovalexandr/orgs","repos_url":"https://api.github.com/users/bolshovalexandr/repos","events_url":"https://api.github.com/users/bolshovalexandr/events{/privacy}","received_events_url":"https://api.github.com/users/bolshovalexandr/received_events","type":"User","site_admin":false},"repo":{"id":73839345,"name":"179111-pixel-hunter","full_name":"bolshovalexandr/179111-pixel-hunter","owner":{"login":"bolshovalexandr","id":19558362,"avatar_url":"https://avatars.githubusercontent.com/u/19558362?v=3","gravatar_id":"","url":"https://api.github.com/users/bolshovalexandr","html_url":"https://github.com/bolshovalexandr","followers_url":"https://api.github.com/users/bolshovalexandr/followers","following_url":"https://api.github.com/users/bolshovalexandr/following{/other_user}","gists_url":"https://api.github.com/users/bolshovalexandr/gists{/gist_id}","starred_url":"https://api.github.com/users/bolshovalexandr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bolshovalexandr/subscriptions","organizations_url":"https://api.github.com/users/bolshovalexandr/orgs","repos_url":"https://api.github.com/users/bolshovalexandr/repos","events_url":"https://api.github.com/users/bolshovalexandr/events{/privacy}","received_events_url":"https://api.github.com/users/bolshovalexandr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bolshovalexandr/179111-pixel-hunter","description":"Александр Большов","fork":true,"url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter","forks_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/forks","keys_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/teams","hooks_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/hooks","issue_events_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/issues/events{/number}","events_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/events","assignees_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/assignees{/user}","branches_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/branches{/branch}","tags_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/tags","blobs_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/git/refs{/sha}","trees_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/statuses/{sha}","languages_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/languages","stargazers_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/stargazers","contributors_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/contributors","subscribers_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/subscribers","subscription_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/subscription","commits_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/commits{/sha}","git_commits_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/git/commits{/sha}","comments_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/comments{/number}","issue_comment_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/issues/comments{/number}","contents_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/contents/{+path}","compare_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/merges","archive_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/downloads","issues_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/issues{/number}","pulls_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/pulls{/number}","milestones_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/milestones{/number}","notifications_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/labels{/name}","releases_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/releases{/id}","deployments_url":"https://api.github.com/repos/bolshovalexandr/179111-pixel-hunter/deployments","created_at":"2016-11-15T17:40:58Z","updated_at":"2016-11-22T18:34:25Z","pushed_at":"2016-12-19T16:44:00Z","git_url":"git://github.com/bolshovalexandr/179111-pixel-hunter.git","ssh_url":"git@github.com:bolshovalexandr/179111-pixel-hunter.git","clone_url":"https://github.com/bolshovalexandr/179111-pixel-hunter.git","svn_url":"https://github.com/bolshovalexandr/179111-pixel-hunter","homepage":null,"size":680,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-ecmascript:master","ref":"master","sha":"a1cac008d7c02e3e909fc014c626612ac6a93887","user":{"login":"htmlacademy-ecmascript","id":22890904,"avatar_url":"https://avatars.githubusercontent.com/u/22890904?v=3","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-ecmascript","html_url":"https://github.com/htmlacademy-ecmascript","followers_url":"https://api.github.com/users/htmlacademy-ecmascript/followers","following_url":"https://api.github.com/users/htmlacademy-ecmascript/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-ecmascript/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-ecmascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-ecmascript/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-ecmascript/orgs","repos_url":"https://api.github.com/users/htmlacademy-ecmascript/repos","events_url":"https://api.github.com/users/htmlacademy-ecmascript/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-ecmascript/received_events","type":"Organization","site_admin":false},"repo":{"id":73839216,"name":"179111-pixel-hunter","full_name":"htmlacademy-ecmascript/179111-pixel-hunter","owner":{"login":"htmlacademy-ecmascript","id":22890904,"avatar_url":"https://avatars.githubusercontent.com/u/22890904?v=3","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-ecmascript","html_url":"https://github.com/htmlacademy-ecmascript","followers_url":"https://api.github.com/users/htmlacademy-ecmascript/followers","following_url":"https://api.github.com/users/htmlacademy-ecmascript/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-ecmascript/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-ecmascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-ecmascript/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-ecmascript/orgs","repos_url":"https://api.github.com/users/htmlacademy-ecmascript/repos","events_url":"https://api.github.com/users/htmlacademy-ecmascript/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-ecmascript/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/htmlacademy-ecmascript/179111-pixel-hunter","description":"Александр Большов","fork":false,"url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter","forks_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/forks","keys_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/teams","hooks_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/events","assignees_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/tags","blobs_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/subscription","commits_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/merges","archive_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/downloads","issues_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/deployments","created_at":"2016-11-15T17:39:17Z","updated_at":"2016-11-22T17:30:54Z","pushed_at":"2016-12-19T16:44:01Z","git_url":"git://github.com/htmlacademy-ecmascript/179111-pixel-hunter.git","ssh_url":"git@github.com:htmlacademy-ecmascript/179111-pixel-hunter.git","clone_url":"https://github.com/htmlacademy-ecmascript/179111-pixel-hunter.git","svn_url":"https://github.com/htmlacademy-ecmascript/179111-pixel-hunter","homepage":"https://github.com/bolshovalexandr/179111-pixel-hunter","size":790,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/pulls/10"},"html":{"href":"https://github.com/htmlacademy-ecmascript/179111-pixel-hunter/pull/10"},"issue":{"href":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/issues/10"},"comments":{"href":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-ecmascript/179111-pixel-hunter/statuses/b399ad6e7c063d94c3eac9f2224f227398c73a71"}}}}
{"actor":{"display_login":"vetrov"}}