{"action":"created","issue":{"url":"https://api.github.com/repos/tonypesdm/CAMS/issues/15","repository_url":"https://api.github.com/repos/tonypesdm/CAMS","labels_url":"https://api.github.com/repos/tonypesdm/CAMS/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/tonypesdm/CAMS/issues/15/comments","events_url":"https://api.github.com/repos/tonypesdm/CAMS/issues/15/events","html_url":"https://github.com/tonypesdm/CAMS/issues/15","id":192565421,"number":15,"title":"1 Various data submit faults in survey submit code","user":{"login":"tonypesdm","id":23658411,"avatar_url":"https://avatars.githubusercontent.com/u/23658411?v=3","gravatar_id":"","url":"https://api.github.com/users/tonypesdm","html_url":"https://github.com/tonypesdm","followers_url":"https://api.github.com/users/tonypesdm/followers","following_url":"https://api.github.com/users/tonypesdm/following{/other_user}","gists_url":"https://api.github.com/users/tonypesdm/gists{/gist_id}","starred_url":"https://api.github.com/users/tonypesdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonypesdm/subscriptions","organizations_url":"https://api.github.com/users/tonypesdm/orgs","repos_url":"https://api.github.com/users/tonypesdm/repos","events_url":"https://api.github.com/users/tonypesdm/events{/privacy}","received_events_url":"https://api.github.com/users/tonypesdm/received_events","type":"User","site_admin":false},"labels":[{"id":487655906,"url":"https://api.github.com/repos/tonypesdm/CAMS/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":{"login":"joerichardsESDM","id":13380424,"avatar_url":"https://avatars.githubusercontent.com/u/13380424?v=3","gravatar_id":"","url":"https://api.github.com/users/joerichardsESDM","html_url":"https://github.com/joerichardsESDM","followers_url":"https://api.github.com/users/joerichardsESDM/followers","following_url":"https://api.github.com/users/joerichardsESDM/following{/other_user}","gists_url":"https://api.github.com/users/joerichardsESDM/gists{/gist_id}","starred_url":"https://api.github.com/users/joerichardsESDM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joerichardsESDM/subscriptions","organizations_url":"https://api.github.com/users/joerichardsESDM/orgs","repos_url":"https://api.github.com/users/joerichardsESDM/repos","events_url":"https://api.github.com/users/joerichardsESDM/events{/privacy}","received_events_url":"https://api.github.com/users/joerichardsESDM/received_events","type":"User","site_admin":false},"assignees":[{"login":"joerichardsESDM","id":13380424,"avatar_url":"https://avatars.githubusercontent.com/u/13380424?v=3","gravatar_id":"","url":"https://api.github.com/users/joerichardsESDM","html_url":"https://github.com/joerichardsESDM","followers_url":"https://api.github.com/users/joerichardsESDM/followers","following_url":"https://api.github.com/users/joerichardsESDM/following{/other_user}","gists_url":"https://api.github.com/users/joerichardsESDM/gists{/gist_id}","starred_url":"https://api.github.com/users/joerichardsESDM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joerichardsESDM/subscriptions","organizations_url":"https://api.github.com/users/joerichardsESDM/orgs","repos_url":"https://api.github.com/users/joerichardsESDM/repos","events_url":"https://api.github.com/users/joerichardsESDM/events{/privacy}","received_events_url":"https://api.github.com/users/joerichardsESDM/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/tonypesdm/CAMS/milestones/3","html_url":"https://github.com/tonypesdm/CAMS/milestones/CAMS%20Web%202.3%20freeze","labels_url":"https://api.github.com/repos/tonypesdm/CAMS/milestones/3/labels","id":2163432,"number":3,"title":"CAMS Web 2.3 freeze","description":"","creator":{"login":"tonypesdm","id":23658411,"avatar_url":"https://avatars.githubusercontent.com/u/23658411?v=3","gravatar_id":"","url":"https://api.github.com/users/tonypesdm","html_url":"https://github.com/tonypesdm","followers_url":"https://api.github.com/users/tonypesdm/followers","following_url":"https://api.github.com/users/tonypesdm/following{/other_user}","gists_url":"https://api.github.com/users/tonypesdm/gists{/gist_id}","starred_url":"https://api.github.com/users/tonypesdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonypesdm/subscriptions","organizations_url":"https://api.github.com/users/tonypesdm/orgs","repos_url":"https://api.github.com/users/tonypesdm/repos","events_url":"https://api.github.com/users/tonypesdm/events{/privacy}","received_events_url":"https://api.github.com/users/tonypesdm/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":0,"state":"open","created_at":"2016-11-29T11:28:26Z","updated_at":"2016-12-01T12:34:15Z","due_on":"2016-12-05T00:00:00Z","closed_at":null},"comments":5,"created_at":"2016-11-30T13:28:15Z","updated_at":"2016-12-02T12:18:52Z","closed_at":null,"body":"1)\tAdminArea value is not being submitted correctly. The nature of the submission varies. \r\no\tFor the following submission types, an example submission would be:  “Llanbadoc Community|362” – it needs to drop the  “|362” from the submission value – **Fault in submit code**\r\nDescription\tEntity\tRecordType\tExample HoldingID\r\nAssigned Survey: New furniture + good condition\tInfra\tInsert\t3005\r\nAssigned Survey: New furniture + good condition\tInfraCondition\tInsert\t3006\r\nAssigned Survey: New furniture + bad condition + issue\tInfra\tInsert\t3007\r\nAssigned Survey: New furniture + bad condition + issue\tInfraCondition\tInsert\t3008\r\nAssigned Survey: New furniture + bad condition + issue\tMaint\tInsert\t3009\r\nAssigned Survey: New Issue\tMaint\tInsert\t3010\r\nAssigned Survey: Edit furniture condition (Bad)\tInfraCondition\tInsert\t3017\r\nAssigned Survey: Edit furniture condition (Bad)\tMaint\tInsert\t3018\r\n\r\nNote that the fault is in the submit code - I think\r\n\r\n  <data>\r\n    <CAMSData>\r\n      <entity>Infra</entity>\r\n      <recordType>Insert</recordType>\r\n      <recordUserID>03FC0BEE-1480-429C-AC0B-265CF7773F11</recordUserID>\r\n      <adminAreaGroup>Llanbadoc Community|362Usk Community|383</adminAreaGroup>\r\n      <dateSubmitted>2016-11-17T17:05:29</dateSubmitted>\r\n      <dateOccurred>2016-11-17T17:05:29</dateOccurred>\r\n      <recordGUID>574636af-b1b9-4729-a73e-923fa220a018</recordGUID>\r\n      <parentGUID>00000000-0000-0000-0000-000000000000</parentGUID>\r\n    </CAMSData>\r\n    <infra>\r\n      <InfraCode />\r\n      <InfraType>2</InfraType>\r\n      <GroupTypeDescr>Alongside</GroupTypeDescr>\r\n      <TypeDescr>Alongside/Barbed</TypeDescr>\r\n      <AdminArea>362Usk Community</AdminArea>\r\n      <AdminAreaDescr>Llanbadoc Community</AdminAreaDescr>\r\n      <OnRoute />\r\n\r\no\tThe following submission is not getting the AdminArea and just submitting the literal ‘[AdminAreaGroup]’ instead – **Fault in submit code**\r\nDescription\tEntity\tRecordType\tExample HoldingID\r\nRequest an update\tMaint\tAddUser\t3004\r\n\r\n2)\tThe following values are not submitting the Priority or PriorityDescr values (even though they request them on the web form) – **Add Priority to the submit code**\r\nDescription\tEntity\tRecordType\tExample HoldingID\r\nAssigned Survey: New furniture + bad condition + issue\tMaint\tInsert\t3009\r\nAssigned Survey: Edit furniture condition (Bad)\tMaint\tInsert\t3018\r\n\r\n4)\tCompleted Assigned Path Surveys and Completed Assigned Issues does not refresh after submission and continues to display the confirmation when trying to submit a new record (a manual page refresh is needed). **Fault in code**\r\n5)\tFor the following submission the submitted workcode value within xml is not right - should be the surveycode, seems to be submitting a random number instead. Example submission: **Fault in code**\r\nDescription\tEntity\tRecordType\tExample HoldingID\r\nAssigned Survey: Reject Task\tWork\tRoute\t3021\r\n\r\n6)\tOn the ‘Complete Assigned Issue’ form we are exposing 'assigned to web user' as part of values list - should just be complete or incomplete. I’ve got a feeling this was previously hardcoded just to these 2 values… **What view is used – should we be creating a new LUT and associated view – eg TaskStatusLUT?**\r\n\r\n8)\tThe following submissions are placing the landcode value under RouteCode. Value needs to be moved under landcode. **The following script in the ascx forms is not working:\r\n            if (ESDM.CAMS.Forms.getParentType() == 4) {\r\n                ESDM.CAMS.Forms.autoSetFields(\"[ParentCode],Form_InfraNew_Officer_Infra_LandCode_tbx\");\r\n            } else {\r\n                ESDM.CAMS.Forms.autoSetFields(\"[ParentCode],Form_InfraNew_Officer_Infra_RouteCode_tbx\");\r\n            }**\r\nDescription\tEntity\tRecordType\tExample HoldingID\r\nOfficer: New furniture + good condition (on LAND)\tInfra1\tInsert\t3027\r\nOfficer: New furniture + bad condition + issue (on LAND)\tInfra1\tInsert\t3030\r\n\r\n11)\tThe following submissions did not submit a parent value. Would expect them to submit either a Landcode or Routecode value within the Infra node – This is on purpose to avoid inadvertently sending the wrong value.  **The field should not be required because it is an update**\r\nDescription\tEntity\tRecordType\tExample HoldingID\r\nOfficer: Edit furniture + good condition (on ROUTE)\tInfra1\tUpdate\t3031\r\nOfficer: Edit furniture + good condition (on LAND)\tInfra1\tUpdate\t3032\r\nOfficer: Edit furniture + bad condition + issue (on ROUTE)\tInfra1\tUpdate\t3033\r\nOfficer: Edit furniture + bad condition + issue (on LAND)\tInfra1\tUpdate\tn/a\r\n\r\n\r\n\r\n  "},"comment":{"url":"https://api.github.com/repos/tonypesdm/CAMS/issues/comments/264442212","html_url":"https://github.com/tonypesdm/CAMS/issues/15#issuecomment-264442212","issue_url":"https://api.github.com/repos/tonypesdm/CAMS/issues/15","id":264442212,"user":{"login":"joerichardsESDM","id":13380424,"avatar_url":"https://avatars.githubusercontent.com/u/13380424?v=3","gravatar_id":"","url":"https://api.github.com/users/joerichardsESDM","html_url":"https://github.com/joerichardsESDM","followers_url":"https://api.github.com/users/joerichardsESDM/followers","following_url":"https://api.github.com/users/joerichardsESDM/following{/other_user}","gists_url":"https://api.github.com/users/joerichardsESDM/gists{/gist_id}","starred_url":"https://api.github.com/users/joerichardsESDM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joerichardsESDM/subscriptions","organizations_url":"https://api.github.com/users/joerichardsESDM/orgs","repos_url":"https://api.github.com/users/joerichardsESDM/repos","events_url":"https://api.github.com/users/joerichardsESDM/events{/privacy}","received_events_url":"https://api.github.com/users/joerichardsESDM/received_events","type":"User","site_admin":false},"created_at":"2016-12-02T12:18:52Z","updated_at":"2016-12-02T12:18:52Z","body":"looked at 6; it is working fine for me, submitting the following JSON with a LandCode:\r\n\r\n\"Infra\": {\r\n    \"RouteCode\": \"\",\r\n    \"LandCode\": \"00221\",\r\n    \"WKTPoint\": \"POINT(338653.77998168947 221667.23500305176)\",\r\n    \"AdminArea\": \"359\",\r\n    \"Easting\": \"338653.780\",\r\n    \"Northing\": \"221667.235\",\r\n    \"InfraType\": \"4\",\r\n    \"DateInst\": \"02/12/2016\",\r\n    \"Name\": \"\",\r\n    \"OnRoute\": 0,\r\n    \"LRO\": 0\r\n  },"}}
{"actor":{"display_login":"joerichardsESDM"}}