{"action":"closed","issue":{"url":"https://api.github.com/repos/zalmoxisus/remotedev-server/issues/23","repository_url":"https://api.github.com/repos/zalmoxisus/remotedev-server","labels_url":"https://api.github.com/repos/zalmoxisus/remotedev-server/issues/23/labels{/name}","comments_url":"https://api.github.com/repos/zalmoxisus/remotedev-server/issues/23/comments","events_url":"https://api.github.com/repos/zalmoxisus/remotedev-server/issues/23/events","html_url":"https://github.com/zalmoxisus/remotedev-server/issues/23","id":187538686,"number":23,"title":"Feature request: Ability to use as Express middleware","user":{"login":"jrullmann","id":1865328,"avatar_url":"https://avatars.githubusercontent.com/u/1865328?v=3","gravatar_id":"","url":"https://api.github.com/users/jrullmann","html_url":"https://github.com/jrullmann","followers_url":"https://api.github.com/users/jrullmann/followers","following_url":"https://api.github.com/users/jrullmann/following{/other_user}","gists_url":"https://api.github.com/users/jrullmann/gists{/gist_id}","starred_url":"https://api.github.com/users/jrullmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrullmann/subscriptions","organizations_url":"https://api.github.com/users/jrullmann/orgs","repos_url":"https://api.github.com/users/jrullmann/repos","events_url":"https://api.github.com/users/jrullmann/events{/privacy}","received_events_url":"https://api.github.com/users/jrullmann/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-11-06T03:09:06Z","updated_at":"2016-11-06T17:46:59Z","closed_at":"2016-11-06T17:46:59Z","body":"Some deployment platforms hit specific endpoints to check the health of running web applications, and those endpoints are not configurable. For these systems remotedev-server will never be considered healthy because it only responds to specific endpoints.\r\n\r\nTo reproduce, run remotedev-server and curl an endpoint that is not defined. For example:\r\n\r\n```\r\n$ curl http://localhost:8000/health_check \r\nCannot GET /health_check\r\n```\r\n\r\nWhile you could add a catch-all route that returns a 200 (and possibly the index page), adding the ability to use as an Express middleware would both solve this specific problem and also be very flexible for other use cases.\r\n\r\nThe [drakov](https://github.com/Aconex/drakov) project is an example of a web server that can be used independently or as middleware. Although I don't think remotedev-server needs the explicit init function, and a [classic](https://expressjs.com/en/guide/writing-middleware.html) middleware function should work.\r\n\r\nApologies for not submitting a PR with this request - my company doesn't let me open source code without approval.\r\n\r\n"}}
{"actor":{"display_login":"zalmoxisus"}}