{"action":"created","issue":{"url":"https://api.github.com/repos/intuit/wasabi/issues/94","repository_url":"https://api.github.com/repos/intuit/wasabi","labels_url":"https://api.github.com/repos/intuit/wasabi/issues/94/labels{/name}","comments_url":"https://api.github.com/repos/intuit/wasabi/issues/94/comments","events_url":"https://api.github.com/repos/intuit/wasabi/issues/94/events","html_url":"https://github.com/intuit/wasabi/pull/94","id":180558093,"number":94,"title":"Exception and Pagination refactor, major Integration test cleanup","user":{"login":"shoeffner","id":1836815,"avatar_url":"https://avatars.githubusercontent.com/u/1836815?v=3","gravatar_id":"","url":"https://api.github.com/users/shoeffner","html_url":"https://github.com/shoeffner","followers_url":"https://api.github.com/users/shoeffner/followers","following_url":"https://api.github.com/users/shoeffner/following{/other_user}","gists_url":"https://api.github.com/users/shoeffner/gists{/gist_id}","starred_url":"https://api.github.com/users/shoeffner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoeffner/subscriptions","organizations_url":"https://api.github.com/users/shoeffner/orgs","repos_url":"https://api.github.com/users/shoeffner/repos","events_url":"https://api.github.com/users/shoeffner/events{/privacy}","received_events_url":"https://api.github.com/users/shoeffner/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/intuit/wasabi/labels/fix","name":"fix","color":"e99695"}],"state":"open","locked":false,"assignee":{"login":"AndreaSuckro","id":4687506,"avatar_url":"https://avatars.githubusercontent.com/u/4687506?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreaSuckro","html_url":"https://github.com/AndreaSuckro","followers_url":"https://api.github.com/users/AndreaSuckro/followers","following_url":"https://api.github.com/users/AndreaSuckro/following{/other_user}","gists_url":"https://api.github.com/users/AndreaSuckro/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreaSuckro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreaSuckro/subscriptions","organizations_url":"https://api.github.com/users/AndreaSuckro/orgs","repos_url":"https://api.github.com/users/AndreaSuckro/repos","events_url":"https://api.github.com/users/AndreaSuckro/events{/privacy}","received_events_url":"https://api.github.com/users/AndreaSuckro/received_events","type":"User","site_admin":false},"assignees":[{"login":"AndreaSuckro","id":4687506,"avatar_url":"https://avatars.githubusercontent.com/u/4687506?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreaSuckro","html_url":"https://github.com/AndreaSuckro","followers_url":"https://api.github.com/users/AndreaSuckro/followers","following_url":"https://api.github.com/users/AndreaSuckro/following{/other_user}","gists_url":"https://api.github.com/users/AndreaSuckro/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreaSuckro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreaSuckro/subscriptions","organizations_url":"https://api.github.com/users/AndreaSuckro/orgs","repos_url":"https://api.github.com/users/AndreaSuckro/repos","events_url":"https://api.github.com/users/AndreaSuckro/events{/privacy}","received_events_url":"https://api.github.com/users/AndreaSuckro/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-10-03T03:43:27Z","updated_at":"2016-10-06T10:00:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/intuit/wasabi/pulls/94","html_url":"https://github.com/intuit/wasabi/pull/94","diff_url":"https://github.com/intuit/wasabi/pull/94.diff","patch_url":"https://github.com/intuit/wasabi/pull/94.patch"},"body":"- Moved exceptions from the experiments-objects module to the exceptions module.\r\n- Moved specific exceptions to their respective packages, leaving only exceptions which are not dependent on other modules behind.\r\n- Adjusted pagination to follow Java style more closely (converting enums to UPPER_CASE).\r\n- Simplified ExceptionProvider unit tests and added exception providers to avoid some \"500: null\" exceptions.\r\n- As a result had to change a couple of integration tests, and while I started I couldn't stop. Hence here we go:\r\n    - Restructured the messy service package into multiple meaningful packages.\r\n    - Cleaned up the TestNG XML files and moved all general tests to the main file, while keeping the ability to run smoke and perf tests individually.\r\n    - Updated the module README.\r\n    - Enforced camelCase method names in all service files. Simplified code where IntelliJ's inspections told me to take action.\r\n    - Unified license headers in all integration test service files.\r\n    - Resolved a lot of FIXME's around multiple tests, many of which were automatically resolved thanks to the exception changes from 500s to more useful ones.\r\n    - Removed dead code (commented out or only called by a test but no where else).\r\n    - Simplified the APIServerConnector to only have one request method (code dedup).\r\n- Instead of ignoring the EventLog tests, I removed one of them as it basically tested try-finally capability, and improved one to a mockito timeout\r\n- simplified some code in the EventLog with the potential of speed-up through parallel streams"},"comment":{"url":"https://api.github.com/repos/intuit/wasabi/issues/comments/251918732","html_url":"https://github.com/intuit/wasabi/pull/94#issuecomment-251918732","issue_url":"https://api.github.com/repos/intuit/wasabi/issues/94","id":251918732,"user":{"login":"AndreaSuckro","id":4687506,"avatar_url":"https://avatars.githubusercontent.com/u/4687506?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreaSuckro","html_url":"https://github.com/AndreaSuckro","followers_url":"https://api.github.com/users/AndreaSuckro/followers","following_url":"https://api.github.com/users/AndreaSuckro/following{/other_user}","gists_url":"https://api.github.com/users/AndreaSuckro/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreaSuckro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreaSuckro/subscriptions","organizations_url":"https://api.github.com/users/AndreaSuckro/orgs","repos_url":"https://api.github.com/users/AndreaSuckro/repos","events_url":"https://api.github.com/users/AndreaSuckro/events{/privacy}","received_events_url":"https://api.github.com/users/AndreaSuckro/received_events","type":"User","site_admin":false},"created_at":"2016-10-06T10:00:21Z","updated_at":"2016-10-06T10:00:21Z","body":"Ok I tried everything as you described it. Got also the beer-problem in the start step (will take a look at that since it still works in my branch). So normally a\r\n```\r\n./bin/wasabi.sh stop remove build start\r\n```\r\nshould be enough when I switch from one branch to the other, right? The tests are running through now with ```/bin/wasabi.sh test and mvn test``` but for some reason when I use IntelliJ some of them are failing. This could be either an IntelliJ internal -not refreshed everything properly- thing or maybe the problem is that something is not properly cleaned up and when I run the tests via IntelliJ it fails during to that.\r\n\r\nEither way: I am not sure whether this is really blocking your merge, but I will investigate a little bit further. "}}
{"actor":{"display_login":"AndreaSuckro"}}