{"action":"created","comment":{"url":"https://api.github.com/repos/kwsch/PKHeX/pulls/comments/75684099","id":75684099,"diff_hunk":"@@ -361,4 +361,14 @@ L_Country = Pays\n - **Please leave the {0} in your line. The OT name will show instead.\n --\n L_Arguments = Onglet désactivé ; Toujours avec ; DO ; Génération précédente - ; Souvenirs avec ; Pokémon  ; Zone  ; Objet(s)  ; Attaque  ; Emplacement \n+! End\n+! -----------------------------------------------------\n+- DO NOT CHANGE THIS SECTION.\n+! ErrorWindow = Erreur\n+- Change stuff below this line, not above.\n+-------------------------------------------------------\n+L_ProvideInfo = S'il vous plaît fournir ces informations lorsque vous rapportez cette error: \n+B_CopyToClipboard = Copier dans les Notes\n+B_Continue = Continuer\n+B_Abort = Abandonner","path":"PKHeX/Resources/text/fr/lang_fr.txt","position":13,"original_position":13,"commit_id":"e6cbd35f05b3aa60c1daa23154d3477d29e94ea1","original_commit_id":"e6cbd35f05b3aa60c1daa23154d3477d29e94ea1","user":{"login":"TheSonAlsoRises","id":8591366,"avatar_url":"https://avatars.githubusercontent.com/u/8591366?v=3","gravatar_id":"","url":"https://api.github.com/users/TheSonAlsoRises","html_url":"https://github.com/TheSonAlsoRises","followers_url":"https://api.github.com/users/TheSonAlsoRises/followers","following_url":"https://api.github.com/users/TheSonAlsoRises/following{/other_user}","gists_url":"https://api.github.com/users/TheSonAlsoRises/gists{/gist_id}","starred_url":"https://api.github.com/users/TheSonAlsoRises/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheSonAlsoRises/subscriptions","organizations_url":"https://api.github.com/users/TheSonAlsoRises/orgs","repos_url":"https://api.github.com/users/TheSonAlsoRises/repos","events_url":"https://api.github.com/users/TheSonAlsoRises/events{/privacy}","received_events_url":"https://api.github.com/users/TheSonAlsoRises/received_events","type":"User","site_admin":false},"body":">S'il vous plaît fournir ces informations lorsque vous rapportez cette error: \r\n\r\nVeuillez fournir les informations suivantes dans votre rapport d'erreur :\r\n\r\n>Copier dans les Notes\r\n\r\nCopier dans le presse-papier","created_at":"2016-08-22T14:10:23Z","updated_at":"2016-08-22T14:10:23Z","html_url":"https://github.com/kwsch/PKHeX/pull/191#discussion_r75684099","pull_request_url":"https://api.github.com/repos/kwsch/PKHeX/pulls/191","_links":{"self":{"href":"https://api.github.com/repos/kwsch/PKHeX/pulls/comments/75684099"},"html":{"href":"https://github.com/kwsch/PKHeX/pull/191#discussion_r75684099"},"pull_request":{"href":"https://api.github.com/repos/kwsch/PKHeX/pulls/191"}}},"pull_request":{"url":"https://api.github.com/repos/kwsch/PKHeX/pulls/191","id":82124835,"html_url":"https://github.com/kwsch/PKHeX/pull/191","diff_url":"https://github.com/kwsch/PKHeX/pull/191.diff","patch_url":"https://github.com/kwsch/PKHeX/pull/191.patch","issue_url":"https://api.github.com/repos/kwsch/PKHeX/issues/191","number":191,"state":"open","locked":false,"title":"Improved Error Handling & Minor Translation Refactor","user":{"login":"evandixon","id":2699524,"avatar_url":"https://avatars.githubusercontent.com/u/2699524?v=3","gravatar_id":"","url":"https://api.github.com/users/evandixon","html_url":"https://github.com/evandixon","followers_url":"https://api.github.com/users/evandixon/followers","following_url":"https://api.github.com/users/evandixon/following{/other_user}","gists_url":"https://api.github.com/users/evandixon/gists{/gist_id}","starred_url":"https://api.github.com/users/evandixon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evandixon/subscriptions","organizations_url":"https://api.github.com/users/evandixon/orgs","repos_url":"https://api.github.com/users/evandixon/repos","events_url":"https://api.github.com/users/evandixon/events{/privacy}","received_events_url":"https://api.github.com/users/evandixon/received_events","type":"User","site_admin":false},"body":"There was recently [an unhandled exception reported on PP.org](https://projectpokemon.org/forums/showthread.php?49649-Critical-Error), which nobody could have predicted or even have prevented.  But I think it could have been handled a little nicer, instead of having a generic .Net error.\r\n\r\n## Overview of Changes\r\n### Added Window to Display Error Messages\r\n![image](https://cloud.githubusercontent.com/assets/2699524/17841441/12b7464e-67de-11e6-8c4b-005e1b8e64e5.png)\r\nNotable features:\r\n- Displays the exception details, with a button that copies the text to the user's clipboard\r\n- Displays a context-specific user-friendly error message above it, set by whatever opens the dialog\r\n- At least partially translatable (the friendly error message, which is not technically part of the form, is currently not)\r\n\r\n### Added Unhandled Exception Event Handlers\r\nWhenever there's an unhandled exception in the application, the error form will be shown.\r\n\r\n### Added Try/Catch statement to save file auto-detection on load\r\n`path = SaveUtil.detectSaveFile();` is now in a try statement, using the above form on error, in case someone has the file corruption problem, linked to above.\r\n\r\n### Language\r\nIn order to make ErrorWindow translatable, it needs to know what language the form is set to.  To accomplish this, whenever the language is set in the MainWindow, the culture of the current thread is changed, which the ErrorWindow uses during translation.\r\n\r\nI also added a French translation for the ErrorWindow.  Disclaimer: I'm still a French student, so the wording might be a little off.  I'd appreciate it if someone more familiar with French could review it (I'll add a line note marking my translation to make it easier to find).\r\n\r\n## Still Needed\r\nI'm not sure what the best way to make the user-friendly messages translatable is.  It seems that the current translation engine is designed to translate forms, not provide specific strings to the code.  This isn't limited just to my new inline strings.  Other things like \"Illegal mode activated.\" and \"Decrypted PKM File\" in the SaveFileDialog filter are affected too.\r\n\r\nIn Sky Editor, I use resource files to store strings, so in the code, I use `My.Resources.Language.Whatever` to get the localized \"Whatever\" string in Language.resx, and there's similar syntax in WPF.  I don't know what the best way to do this in PKHeX would be.  While I want to say resource files, that would be a big change.  However, this is probably a discussion for another day.  Once this PR is completed (and people get a chance to review my code), I'll open an issue for further discussion.","created_at":"2016-08-22T01:41:51Z","updated_at":"2016-08-22T14:10:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2bdce53dc2c6dd2b299acea44b7f1f9ee5d135b9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kwsch/PKHeX/pulls/191/commits","review_comments_url":"https://api.github.com/repos/kwsch/PKHeX/pulls/191/comments","review_comment_url":"https://api.github.com/repos/kwsch/PKHeX/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kwsch/PKHeX/issues/191/comments","statuses_url":"https://api.github.com/repos/kwsch/PKHeX/statuses/e6cbd35f05b3aa60c1daa23154d3477d29e94ea1","head":{"label":"kwsch:f/better-error-handling","ref":"f/better-error-handling","sha":"e6cbd35f05b3aa60c1daa23154d3477d29e94ea1","user":{"login":"kwsch","id":6393368,"avatar_url":"https://avatars.githubusercontent.com/u/6393368?v=3","gravatar_id":"","url":"https://api.github.com/users/kwsch","html_url":"https://github.com/kwsch","followers_url":"https://api.github.com/users/kwsch/followers","following_url":"https://api.github.com/users/kwsch/following{/other_user}","gists_url":"https://api.github.com/users/kwsch/gists{/gist_id}","starred_url":"https://api.github.com/users/kwsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwsch/subscriptions","organizations_url":"https://api.github.com/users/kwsch/orgs","repos_url":"https://api.github.com/users/kwsch/repos","events_url":"https://api.github.com/users/kwsch/events{/privacy}","received_events_url":"https://api.github.com/users/kwsch/received_events","type":"User","site_admin":false},"repo":{"id":21311240,"name":"PKHeX","full_name":"kwsch/PKHeX","owner":{"login":"kwsch","id":6393368,"avatar_url":"https://avatars.githubusercontent.com/u/6393368?v=3","gravatar_id":"","url":"https://api.github.com/users/kwsch","html_url":"https://github.com/kwsch","followers_url":"https://api.github.com/users/kwsch/followers","following_url":"https://api.github.com/users/kwsch/following{/other_user}","gists_url":"https://api.github.com/users/kwsch/gists{/gist_id}","starred_url":"https://api.github.com/users/kwsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwsch/subscriptions","organizations_url":"https://api.github.com/users/kwsch/orgs","repos_url":"https://api.github.com/users/kwsch/repos","events_url":"https://api.github.com/users/kwsch/events{/privacy}","received_events_url":"https://api.github.com/users/kwsch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kwsch/PKHeX","description":"Pokémon GBA/NDS/3DS Save Editor","fork":false,"url":"https://api.github.com/repos/kwsch/PKHeX","forks_url":"https://api.github.com/repos/kwsch/PKHeX/forks","keys_url":"https://api.github.com/repos/kwsch/PKHeX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kwsch/PKHeX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kwsch/PKHeX/teams","hooks_url":"https://api.github.com/repos/kwsch/PKHeX/hooks","issue_events_url":"https://api.github.com/repos/kwsch/PKHeX/issues/events{/number}","events_url":"https://api.github.com/repos/kwsch/PKHeX/events","assignees_url":"https://api.github.com/repos/kwsch/PKHeX/assignees{/user}","branches_url":"https://api.github.com/repos/kwsch/PKHeX/branches{/branch}","tags_url":"https://api.github.com/repos/kwsch/PKHeX/tags","blobs_url":"https://api.github.com/repos/kwsch/PKHeX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kwsch/PKHeX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kwsch/PKHeX/git/refs{/sha}","trees_url":"https://api.github.com/repos/kwsch/PKHeX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kwsch/PKHeX/statuses/{sha}","languages_url":"https://api.github.com/repos/kwsch/PKHeX/languages","stargazers_url":"https://api.github.com/repos/kwsch/PKHeX/stargazers","contributors_url":"https://api.github.com/repos/kwsch/PKHeX/contributors","subscribers_url":"https://api.github.com/repos/kwsch/PKHeX/subscribers","subscription_url":"https://api.github.com/repos/kwsch/PKHeX/subscription","commits_url":"https://api.github.com/repos/kwsch/PKHeX/commits{/sha}","git_commits_url":"https://api.github.com/repos/kwsch/PKHeX/git/commits{/sha}","comments_url":"https://api.github.com/repos/kwsch/PKHeX/comments{/number}","issue_comment_url":"https://api.github.com/repos/kwsch/PKHeX/issues/comments{/number}","contents_url":"https://api.github.com/repos/kwsch/PKHeX/contents/{+path}","compare_url":"https://api.github.com/repos/kwsch/PKHeX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kwsch/PKHeX/merges","archive_url":"https://api.github.com/repos/kwsch/PKHeX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kwsch/PKHeX/downloads","issues_url":"https://api.github.com/repos/kwsch/PKHeX/issues{/number}","pulls_url":"https://api.github.com/repos/kwsch/PKHeX/pulls{/number}","milestones_url":"https://api.github.com/repos/kwsch/PKHeX/milestones{/number}","notifications_url":"https://api.github.com/repos/kwsch/PKHeX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kwsch/PKHeX/labels{/name}","releases_url":"https://api.github.com/repos/kwsch/PKHeX/releases{/id}","deployments_url":"https://api.github.com/repos/kwsch/PKHeX/deployments","created_at":"2014-06-28T21:20:30Z","updated_at":"2016-08-21T22:55:38Z","pushed_at":"2016-08-22T07:29:59Z","git_url":"git://github.com/kwsch/PKHeX.git","ssh_url":"git@github.com:kwsch/PKHeX.git","clone_url":"https://github.com/kwsch/PKHeX.git","svn_url":"https://github.com/kwsch/PKHeX","homepage":"http://projectpokemon.org/forums/showthread.php?36986","size":11567,"stargazers_count":157,"watchers_count":157,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":85,"mirror_url":null,"open_issues_count":6,"forks":85,"open_issues":6,"watchers":157,"default_branch":"master"}},"base":{"label":"kwsch:master","ref":"master","sha":"24b00d0371d9291fcb29fed8586d52eb6cc95fb7","user":{"login":"kwsch","id":6393368,"avatar_url":"https://avatars.githubusercontent.com/u/6393368?v=3","gravatar_id":"","url":"https://api.github.com/users/kwsch","html_url":"https://github.com/kwsch","followers_url":"https://api.github.com/users/kwsch/followers","following_url":"https://api.github.com/users/kwsch/following{/other_user}","gists_url":"https://api.github.com/users/kwsch/gists{/gist_id}","starred_url":"https://api.github.com/users/kwsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwsch/subscriptions","organizations_url":"https://api.github.com/users/kwsch/orgs","repos_url":"https://api.github.com/users/kwsch/repos","events_url":"https://api.github.com/users/kwsch/events{/privacy}","received_events_url":"https://api.github.com/users/kwsch/received_events","type":"User","site_admin":false},"repo":{"id":21311240,"name":"PKHeX","full_name":"kwsch/PKHeX","owner":{"login":"kwsch","id":6393368,"avatar_url":"https://avatars.githubusercontent.com/u/6393368?v=3","gravatar_id":"","url":"https://api.github.com/users/kwsch","html_url":"https://github.com/kwsch","followers_url":"https://api.github.com/users/kwsch/followers","following_url":"https://api.github.com/users/kwsch/following{/other_user}","gists_url":"https://api.github.com/users/kwsch/gists{/gist_id}","starred_url":"https://api.github.com/users/kwsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwsch/subscriptions","organizations_url":"https://api.github.com/users/kwsch/orgs","repos_url":"https://api.github.com/users/kwsch/repos","events_url":"https://api.github.com/users/kwsch/events{/privacy}","received_events_url":"https://api.github.com/users/kwsch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kwsch/PKHeX","description":"Pokémon GBA/NDS/3DS Save Editor","fork":false,"url":"https://api.github.com/repos/kwsch/PKHeX","forks_url":"https://api.github.com/repos/kwsch/PKHeX/forks","keys_url":"https://api.github.com/repos/kwsch/PKHeX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kwsch/PKHeX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kwsch/PKHeX/teams","hooks_url":"https://api.github.com/repos/kwsch/PKHeX/hooks","issue_events_url":"https://api.github.com/repos/kwsch/PKHeX/issues/events{/number}","events_url":"https://api.github.com/repos/kwsch/PKHeX/events","assignees_url":"https://api.github.com/repos/kwsch/PKHeX/assignees{/user}","branches_url":"https://api.github.com/repos/kwsch/PKHeX/branches{/branch}","tags_url":"https://api.github.com/repos/kwsch/PKHeX/tags","blobs_url":"https://api.github.com/repos/kwsch/PKHeX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kwsch/PKHeX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kwsch/PKHeX/git/refs{/sha}","trees_url":"https://api.github.com/repos/kwsch/PKHeX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kwsch/PKHeX/statuses/{sha}","languages_url":"https://api.github.com/repos/kwsch/PKHeX/languages","stargazers_url":"https://api.github.com/repos/kwsch/PKHeX/stargazers","contributors_url":"https://api.github.com/repos/kwsch/PKHeX/contributors","subscribers_url":"https://api.github.com/repos/kwsch/PKHeX/subscribers","subscription_url":"https://api.github.com/repos/kwsch/PKHeX/subscription","commits_url":"https://api.github.com/repos/kwsch/PKHeX/commits{/sha}","git_commits_url":"https://api.github.com/repos/kwsch/PKHeX/git/commits{/sha}","comments_url":"https://api.github.com/repos/kwsch/PKHeX/comments{/number}","issue_comment_url":"https://api.github.com/repos/kwsch/PKHeX/issues/comments{/number}","contents_url":"https://api.github.com/repos/kwsch/PKHeX/contents/{+path}","compare_url":"https://api.github.com/repos/kwsch/PKHeX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kwsch/PKHeX/merges","archive_url":"https://api.github.com/repos/kwsch/PKHeX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kwsch/PKHeX/downloads","issues_url":"https://api.github.com/repos/kwsch/PKHeX/issues{/number}","pulls_url":"https://api.github.com/repos/kwsch/PKHeX/pulls{/number}","milestones_url":"https://api.github.com/repos/kwsch/PKHeX/milestones{/number}","notifications_url":"https://api.github.com/repos/kwsch/PKHeX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kwsch/PKHeX/labels{/name}","releases_url":"https://api.github.com/repos/kwsch/PKHeX/releases{/id}","deployments_url":"https://api.github.com/repos/kwsch/PKHeX/deployments","created_at":"2014-06-28T21:20:30Z","updated_at":"2016-08-21T22:55:38Z","pushed_at":"2016-08-22T07:29:59Z","git_url":"git://github.com/kwsch/PKHeX.git","ssh_url":"git@github.com:kwsch/PKHeX.git","clone_url":"https://github.com/kwsch/PKHeX.git","svn_url":"https://github.com/kwsch/PKHeX","homepage":"http://projectpokemon.org/forums/showthread.php?36986","size":11567,"stargazers_count":157,"watchers_count":157,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":85,"mirror_url":null,"open_issues_count":6,"forks":85,"open_issues":6,"watchers":157,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kwsch/PKHeX/pulls/191"},"html":{"href":"https://github.com/kwsch/PKHeX/pull/191"},"issue":{"href":"https://api.github.com/repos/kwsch/PKHeX/issues/191"},"comments":{"href":"https://api.github.com/repos/kwsch/PKHeX/issues/191/comments"},"review_comments":{"href":"https://api.github.com/repos/kwsch/PKHeX/pulls/191/comments"},"review_comment":{"href":"https://api.github.com/repos/kwsch/PKHeX/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kwsch/PKHeX/pulls/191/commits"},"statuses":{"href":"https://api.github.com/repos/kwsch/PKHeX/statuses/e6cbd35f05b3aa60c1daa23154d3477d29e94ea1"}}}}
{"actor":{"display_login":"TheSonAlsoRises"}}