{"action":"created","issue":{"url":"https://api.github.com/repos/scopatz/xonsh/issues/630","labels_url":"https://api.github.com/repos/scopatz/xonsh/issues/630/labels{/name}","comments_url":"https://api.github.com/repos/scopatz/xonsh/issues/630/comments","events_url":"https://api.github.com/repos/scopatz/xonsh/issues/630/events","html_url":"https://github.com/scopatz/xonsh/pull/630","id":126971532,"number":630,"title":"Fix background colors for PTK","user":{"login":"BYK","id":126780,"avatar_url":"https://avatars.githubusercontent.com/u/126780?v=3","gravatar_id":"","url":"https://api.github.com/users/BYK","html_url":"https://github.com/BYK","followers_url":"https://api.github.com/users/BYK/followers","following_url":"https://api.github.com/users/BYK/following{/other_user}","gists_url":"https://api.github.com/users/BYK/gists{/gist_id}","starred_url":"https://api.github.com/users/BYK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BYK/subscriptions","organizations_url":"https://api.github.com/users/BYK/orgs","repos_url":"https://api.github.com/users/BYK/repos","events_url":"https://api.github.com/users/BYK/events{/privacy}","received_events_url":"https://api.github.com/users/BYK/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/scopatz/xonsh/labels/feature","name":"feature","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/scopatz/xonsh/milestones/2","html_url":"https://github.com/scopatz/xonsh/milestones/v0.3","labels_url":"https://api.github.com/repos/scopatz/xonsh/milestones/2/labels","id":1302567,"number":2,"title":"v0.3","description":"","creator":{"login":"scopatz","id":320553,"avatar_url":"https://avatars.githubusercontent.com/u/320553?v=3","gravatar_id":"","url":"https://api.github.com/users/scopatz","html_url":"https://github.com/scopatz","followers_url":"https://api.github.com/users/scopatz/followers","following_url":"https://api.github.com/users/scopatz/following{/other_user}","gists_url":"https://api.github.com/users/scopatz/gists{/gist_id}","starred_url":"https://api.github.com/users/scopatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scopatz/subscriptions","organizations_url":"https://api.github.com/users/scopatz/orgs","repos_url":"https://api.github.com/users/scopatz/repos","events_url":"https://api.github.com/users/scopatz/events{/privacy}","received_events_url":"https://api.github.com/users/scopatz/received_events","type":"User","site_admin":false},"open_issues":100,"closed_issues":176,"state":"open","created_at":"2015-09-12T18:28:59Z","updated_at":"2016-01-19T18:14:02Z","due_on":null,"closed_at":null},"comments":15,"created_at":"2016-01-15T22:29:23Z","updated_at":"2016-01-20T21:56:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scopatz/xonsh/pulls/630","html_url":"https://github.com/scopatz/xonsh/pull/630","diff_url":"https://github.com/scopatz/xonsh/pull/630.diff","patch_url":"https://github.com/scopatz/xonsh/pull/630.patch"},"body":"Background colors in PTK doesn't work at all. This patch makes a weak attempt to make them work. Definitely not a great or permanent solution but should be a good start."},"comment":{"url":"https://api.github.com/repos/scopatz/xonsh/issues/comments/173373956","html_url":"https://github.com/scopatz/xonsh/pull/630#issuecomment-173373956","issue_url":"https://api.github.com/repos/scopatz/xonsh/issues/630","id":173373956,"user":{"login":"melund","id":1038978,"avatar_url":"https://avatars.githubusercontent.com/u/1038978?v=3","gravatar_id":"","url":"https://api.github.com/users/melund","html_url":"https://github.com/melund","followers_url":"https://api.github.com/users/melund/followers","following_url":"https://api.github.com/users/melund/following{/other_user}","gists_url":"https://api.github.com/users/melund/gists{/gist_id}","starred_url":"https://api.github.com/users/melund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melund/subscriptions","organizations_url":"https://api.github.com/users/melund/orgs","repos_url":"https://api.github.com/users/melund/repos","events_url":"https://api.github.com/users/melund/events{/privacy}","received_events_url":"https://api.github.com/users/melund/received_events","type":"User","site_admin":false},"created_at":"2016-01-20T21:56:46Z","updated_at":"2016-01-20T21:56:46Z","body":"@BYK . I was trying to say that your PR is changing how the default prompt looks. You moved the tweaked colors into the Intense color_mapping. I do think it makes sense, but since the default prompt doesn't use the intense keyword`'{BOLD_GREEN}{user}@{hostname}{BOLD_CYAN} {cwd}{branch_color}{curr_branch} {BOLD_WHITE}{prompt_end}{NO_COLOR} '` the prompt will look like this on windows...\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1038978/12464185/100a0cb0-bfc8-11e5-9af0-c2a252aaaab8.png)\r\n\r\n\r\nI suggest that you also update the default prompt to: \r\n\r\n`'{BOLD_INTENSE_GREEN}{user}@{hostname}{BOLD_INTENSE_CYAN} {cwd}{branch_color}{curr_branch} {BOLD_WHITE}{prompt_end}{NO_COLOR} '`"}}