{"action":"created","comment":{"url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/pulls/comments/87669926","pull_request_review_id":8277050,"id":87669926,"diff_hunk":"@@ -0,0 +1,1065 @@\n+**********************","path":"PowerShell-PoC-Transcript-2016-10-21-0834.log","position":1,"original_position":1,"commit_id":"52c94a3ae6b7985bbbfe6bd42068279bd5e3e492","original_commit_id":"52c94a3ae6b7985bbbfe6bd42068279bd5e3e492","user":{"login":"paulomarquesc","id":17993275,"avatar_url":"https://avatars.githubusercontent.com/u/17993275?v=3","gravatar_id":"","url":"https://api.github.com/users/paulomarquesc","html_url":"https://github.com/paulomarquesc","followers_url":"https://api.github.com/users/paulomarquesc/followers","following_url":"https://api.github.com/users/paulomarquesc/following{/other_user}","gists_url":"https://api.github.com/users/paulomarquesc/gists{/gist_id}","starred_url":"https://api.github.com/users/paulomarquesc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulomarquesc/subscriptions","organizations_url":"https://api.github.com/users/paulomarquesc/orgs","repos_url":"https://api.github.com/users/paulomarquesc/repos","events_url":"https://api.github.com/users/paulomarquesc/events{/privacy}","received_events_url":"https://api.github.com/users/paulomarquesc/received_events","type":"User","site_admin":false},"body":"Please, remove the transcript file from the commit, we don't want that uploaded into the solution","created_at":"2016-11-11T22:36:01Z","updated_at":"2016-11-11T22:36:01Z","html_url":"https://github.com/paulomarquesc/AzurePowerShellSampleDeployment/pull/1#discussion_r87669926","pull_request_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/pulls/comments/87669926"},"html":{"href":"https://github.com/paulomarquesc/AzurePowerShellSampleDeployment/pull/1#discussion_r87669926"},"pull_request":{"href":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/pulls/1","id":90913109,"html_url":"https://github.com/paulomarquesc/AzurePowerShellSampleDeployment/pull/1","diff_url":"https://github.com/paulomarquesc/AzurePowerShellSampleDeployment/pull/1.diff","patch_url":"https://github.com/paulomarquesc/AzurePowerShellSampleDeployment/pull/1.patch","issue_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/issues/1","number":1,"state":"open","locked":false,"title":"PoC Script Updates","user":{"login":"unisol14","id":15109536,"avatar_url":"https://avatars.githubusercontent.com/u/15109536?v=3","gravatar_id":"","url":"https://api.github.com/users/unisol14","html_url":"https://github.com/unisol14","followers_url":"https://api.github.com/users/unisol14/followers","following_url":"https://api.github.com/users/unisol14/following{/other_user}","gists_url":"https://api.github.com/users/unisol14/gists{/gist_id}","starred_url":"https://api.github.com/users/unisol14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unisol14/subscriptions","organizations_url":"https://api.github.com/users/unisol14/orgs","repos_url":"https://api.github.com/users/unisol14/repos","events_url":"https://api.github.com/users/unisol14/events{/privacy}","received_events_url":"https://api.github.com/users/unisol14/received_events","type":"User","site_admin":false},"body":"Included New-RandomString function to automatically generate passwords and other random strings.\nthat will be used during the script, i.e. suffixes for storage account names and shared key for VNET\nto VNET connection, load balancer dns prefix label, etc.\nAdded code to prompt user for subscription name instead of requiring a direct hard coded update to the script\nCalled New-RandomString function to produce unique shared key for VNET to VNET connection.\nAdd a random infix inside the Dnslabel name to avoid conflicts with existing deployments generated from this script\nCreate a new random string, then extract the 4 digits to use as the last characters for the storage account name for each region\nAdded the Transciption feature from the Start-Transcript and Stop-Transcript cmdlets to record more script activity details,\nalso repositioned the log creation earlier in the script.\nAdded an expression after script executes as a convenient option for the user to quickly remove the 'poc...' resource groups\nif desired (for a dev/test/poc situation only).\nAdded author, editor, keyword, license information in the .NOTES help keyword. Also added the .LINK help keyword.\nAdded $BeginTimer variable at the start of the script so that total script execution time can be measured at script completion.\nConstruct custom path for log files based on current user's $env:HOMEPATH directory for both the log and transcript files.\nCreate both log and transcript files with time/date stamps included in their filenames.\nAdded work-items (tasks) comment section to track outstanding tasks.\nAdded region tags to accomodate collapsing sections of script to hide details or make it easier to scroll.\nCreate prompt and responses custom object for opening logs after script completes.\nAdd logging module: WriteToLogs.\nAdd and display header.\nFormat and truncate the results of the New-Guid cmdlet for a subset of random numeric and lowercase combination of characters\nAdd a random infix (4 numeric digits) inside the Dnslabel name to avoid conflicts with existing deployments generated from this scr\nCreate a new random string, then extract the 4 digits to use as the last characters for the storage account name for each region.\nGenerate a pseudo-random password based on the prefix \"SAFE\" to satisfy the uppercase characters complexity requirement, plus a ran\ncombination of 8 lowercase and numeric characters. As such, this meets the password complexity requirement of 3 of the 4 complexity\nwhile reducing the probability that an offensive word will be generated.\nUse previously captured plain-text password variable instead of hard-coding in script.\nAdded footer region to calculate elapsed time, display footer message, prompt to open log and transcript files, stop transcript...\nas well as added a commented section that can be used to decommission PoC environment for test/dev situations in order to clean up \n","created_at":"2016-10-25T23:49:56Z","updated_at":"2016-11-11T22:36:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"935ec87872e1f317ebbb37b761140d2fb8cd0529","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/pulls/1/commits","review_comments_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/pulls/1/comments","review_comment_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/issues/1/comments","statuses_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/statuses/52c94a3ae6b7985bbbfe6bd42068279bd5e3e492","head":{"label":"unisol14:v01","ref":"v01","sha":"52c94a3ae6b7985bbbfe6bd42068279bd5e3e492","user":{"login":"unisol14","id":15109536,"avatar_url":"https://avatars.githubusercontent.com/u/15109536?v=3","gravatar_id":"","url":"https://api.github.com/users/unisol14","html_url":"https://github.com/unisol14","followers_url":"https://api.github.com/users/unisol14/followers","following_url":"https://api.github.com/users/unisol14/following{/other_user}","gists_url":"https://api.github.com/users/unisol14/gists{/gist_id}","starred_url":"https://api.github.com/users/unisol14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unisol14/subscriptions","organizations_url":"https://api.github.com/users/unisol14/orgs","repos_url":"https://api.github.com/users/unisol14/repos","events_url":"https://api.github.com/users/unisol14/events{/privacy}","received_events_url":"https://api.github.com/users/unisol14/received_events","type":"User","site_admin":false},"repo":{"id":71945494,"name":"AzurePowerShellSampleDeployment","full_name":"unisol14/AzurePowerShellSampleDeployment","owner":{"login":"unisol14","id":15109536,"avatar_url":"https://avatars.githubusercontent.com/u/15109536?v=3","gravatar_id":"","url":"https://api.github.com/users/unisol14","html_url":"https://github.com/unisol14","followers_url":"https://api.github.com/users/unisol14/followers","following_url":"https://api.github.com/users/unisol14/following{/other_user}","gists_url":"https://api.github.com/users/unisol14/gists{/gist_id}","starred_url":"https://api.github.com/users/unisol14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unisol14/subscriptions","organizations_url":"https://api.github.com/users/unisol14/orgs","repos_url":"https://api.github.com/users/unisol14/repos","events_url":"https://api.github.com/users/unisol14/events{/privacy}","received_events_url":"https://api.github.com/users/unisol14/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/unisol14/AzurePowerShellSampleDeployment","description":null,"fork":true,"url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment","forks_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/forks","keys_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/teams","hooks_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/hooks","issue_events_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/issues/events{/number}","events_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/events","assignees_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/assignees{/user}","branches_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/branches{/branch}","tags_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/tags","blobs_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/git/refs{/sha}","trees_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/statuses/{sha}","languages_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/languages","stargazers_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/stargazers","contributors_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/contributors","subscribers_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/subscribers","subscription_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/subscription","commits_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/commits{/sha}","git_commits_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/git/commits{/sha}","comments_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/comments{/number}","issue_comment_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/issues/comments{/number}","contents_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/contents/{+path}","compare_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/merges","archive_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/downloads","issues_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/issues{/number}","pulls_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/pulls{/number}","milestones_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/milestones{/number}","notifications_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/labels{/name}","releases_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/releases{/id}","deployments_url":"https://api.github.com/repos/unisol14/AzurePowerShellSampleDeployment/deployments","created_at":"2016-10-25T22:50:44Z","updated_at":"2016-10-25T22:50:45Z","pushed_at":"2016-10-25T23:40:34Z","git_url":"git://github.com/unisol14/AzurePowerShellSampleDeployment.git","ssh_url":"git@github.com:unisol14/AzurePowerShellSampleDeployment.git","clone_url":"https://github.com/unisol14/AzurePowerShellSampleDeployment.git","svn_url":"https://github.com/unisol14/AzurePowerShellSampleDeployment","homepage":null,"size":94,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"paulomarquesc:master","ref":"master","sha":"cfde0a74d5c18b2e7c93b31eb2215689eec2f9f9","user":{"login":"paulomarquesc","id":17993275,"avatar_url":"https://avatars.githubusercontent.com/u/17993275?v=3","gravatar_id":"","url":"https://api.github.com/users/paulomarquesc","html_url":"https://github.com/paulomarquesc","followers_url":"https://api.github.com/users/paulomarquesc/followers","following_url":"https://api.github.com/users/paulomarquesc/following{/other_user}","gists_url":"https://api.github.com/users/paulomarquesc/gists{/gist_id}","starred_url":"https://api.github.com/users/paulomarquesc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulomarquesc/subscriptions","organizations_url":"https://api.github.com/users/paulomarquesc/orgs","repos_url":"https://api.github.com/users/paulomarquesc/repos","events_url":"https://api.github.com/users/paulomarquesc/events{/privacy}","received_events_url":"https://api.github.com/users/paulomarquesc/received_events","type":"User","site_admin":false},"repo":{"id":71247622,"name":"AzurePowerShellSampleDeployment","full_name":"paulomarquesc/AzurePowerShellSampleDeployment","owner":{"login":"paulomarquesc","id":17993275,"avatar_url":"https://avatars.githubusercontent.com/u/17993275?v=3","gravatar_id":"","url":"https://api.github.com/users/paulomarquesc","html_url":"https://github.com/paulomarquesc","followers_url":"https://api.github.com/users/paulomarquesc/followers","following_url":"https://api.github.com/users/paulomarquesc/following{/other_user}","gists_url":"https://api.github.com/users/paulomarquesc/gists{/gist_id}","starred_url":"https://api.github.com/users/paulomarquesc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulomarquesc/subscriptions","organizations_url":"https://api.github.com/users/paulomarquesc/orgs","repos_url":"https://api.github.com/users/paulomarquesc/repos","events_url":"https://api.github.com/users/paulomarquesc/events{/privacy}","received_events_url":"https://api.github.com/users/paulomarquesc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paulomarquesc/AzurePowerShellSampleDeployment","description":null,"fork":false,"url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment","forks_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/forks","keys_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/teams","hooks_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/hooks","issue_events_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/issues/events{/number}","events_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/events","assignees_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/assignees{/user}","branches_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/branches{/branch}","tags_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/tags","blobs_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/git/refs{/sha}","trees_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/statuses/{sha}","languages_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/languages","stargazers_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/stargazers","contributors_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/contributors","subscribers_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/subscribers","subscription_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/subscription","commits_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/commits{/sha}","git_commits_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/git/commits{/sha}","comments_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/comments{/number}","issue_comment_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/issues/comments{/number}","contents_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/contents/{+path}","compare_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/merges","archive_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/downloads","issues_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/issues{/number}","pulls_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/pulls{/number}","milestones_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/milestones{/number}","notifications_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/labels{/name}","releases_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/releases{/id}","deployments_url":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/deployments","created_at":"2016-10-18T12:49:34Z","updated_at":"2016-10-18T12:51:04Z","pushed_at":"2016-10-25T23:49:57Z","git_url":"git://github.com/paulomarquesc/AzurePowerShellSampleDeployment.git","ssh_url":"git@github.com:paulomarquesc/AzurePowerShellSampleDeployment.git","clone_url":"https://github.com/paulomarquesc/AzurePowerShellSampleDeployment.git","svn_url":"https://github.com/paulomarquesc/AzurePowerShellSampleDeployment","homepage":null,"size":82,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/pulls/1"},"html":{"href":"https://github.com/paulomarquesc/AzurePowerShellSampleDeployment/pull/1"},"issue":{"href":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/issues/1"},"comments":{"href":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/paulomarquesc/AzurePowerShellSampleDeployment/statuses/52c94a3ae6b7985bbbfe6bd42068279bd5e3e492"}}}}
{"actor":{"display_login":"paulomarquesc"}}