{"action":"created","comment":{"url":"https://api.github.com/repos/sarif-standard/sarif-spec/pulls/comments/75215958","id":75215958,"diff_hunk":"@@ -1656,8 +1699,9 @@ or include them in bug counts.\n ~\n \n If present, this property conveys the reason or reasons that the result has been suppressed.\n-In this version of the SARIF standard, the only supported reason for suppressing a result is that\n-the developer has suppressed it in the source code (see &sect;[#result-suppressionStates-suppressedInSource]).\n+In this version of the SARIF standard, the only supported reasons for suppressing a result is that\n+the developer has suppressed it in the source code (see &sect;[#result-suppressionStates-suppressedInSource])\n+or that it is marked as \"suppressed\" an external database (see &sect;[#result-suppressionStates-suppressedExternally]).","path":"document/FileFormat.mdk","position":274,"original_position":274,"commit_id":"bf5ce1f3b7c4c390efa6f56624be488b2cc0726a","original_commit_id":"66f285779ae819be6d47a20d6de96366ff9e7ea3","user":{"login":"lgolding","id":11762653,"avatar_url":"https://avatars.githubusercontent.com/u/11762653?v=3","gravatar_id":"","url":"https://api.github.com/users/lgolding","html_url":"https://github.com/lgolding","followers_url":"https://api.github.com/users/lgolding/followers","following_url":"https://api.github.com/users/lgolding/following{/other_user}","gists_url":"https://api.github.com/users/lgolding/gists{/gist_id}","starred_url":"https://api.github.com/users/lgolding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgolding/subscriptions","organizations_url":"https://api.github.com/users/lgolding/orgs","repos_url":"https://api.github.com/users/lgolding/repos","events_url":"https://api.github.com/users/lgolding/events{/privacy}","received_events_url":"https://api.github.com/users/lgolding/received_events","type":"User","site_admin":false},"body":"fixed, fixed.\r\n\r\n---\r\nIn reply to: [75183149](https://github.com/sarif-standard/sarif-spec/pull/256#discussion_r75183149) [](ancestors = 75183149)","created_at":"2016-08-17T22:02:43Z","updated_at":"2016-08-17T22:02:43Z","html_url":"https://github.com/sarif-standard/sarif-spec/pull/256#discussion_r75215958","pull_request_url":"https://api.github.com/repos/sarif-standard/sarif-spec/pulls/256","_links":{"self":{"href":"https://api.github.com/repos/sarif-standard/sarif-spec/pulls/comments/75215958"},"html":{"href":"https://github.com/sarif-standard/sarif-spec/pull/256#discussion_r75215958"},"pull_request":{"href":"https://api.github.com/repos/sarif-standard/sarif-spec/pulls/256"}}},"pull_request":{"url":"https://api.github.com/repos/sarif-standard/sarif-spec/pulls/256","id":79426354,"html_url":"https://github.com/sarif-standard/sarif-spec/pull/256","diff_url":"https://github.com/sarif-standard/sarif-spec/pull/256.diff","patch_url":"https://github.com/sarif-standard/sarif-spec/pull/256.patch","issue_url":"https://api.github.com/repos/sarif-standard/sarif-spec/issues/256","number":256,"state":"open","locked":false,"title":"Fix #208: Specify numeric and string constraints","user":{"login":"lgolding","id":11762653,"avatar_url":"https://avatars.githubusercontent.com/u/11762653?v=3","gravatar_id":"","url":"https://api.github.com/users/lgolding","html_url":"https://github.com/lgolding","followers_url":"https://api.github.com/users/lgolding/followers","following_url":"https://api.github.com/users/lgolding/following{/other_user}","gists_url":"https://api.github.com/users/lgolding/gists{/gist_id}","starred_url":"https://api.github.com/users/lgolding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgolding/subscriptions","organizations_url":"https://api.github.com/users/lgolding/orgs","repos_url":"https://api.github.com/users/lgolding/repos","events_url":"https://api.github.com/users/lgolding/events{/privacy}","received_events_url":"https://api.github.com/users/lgolding/received_events","type":"User","site_admin":false},"body":"We reviewed the string length and numeric value constraints on all SARIF properties, as well as the length constraints on all array properties, and the constraints on the number of sub-properties in properties such as `run.files`.\r\n\r\nThe following arrays were required to be non-empty if present, and I did not change them:\r\n\r\n* `sarifLog.runs`\r\n* `result.locations`\r\n* `result.stacks`\r\n* `result.relatedLocations`\r\n* `codeFlow.locations`\r\n* `stack.Frames`\r\n\r\n`result.CodeFlows` was not required to be non-empty, so I changed it for consistency with `result.stacks`.\r\n\r\nThe following arrays are allowed to be empty:\r\n\r\n* `run.results` (a special case)\r\n* `result.fixes` (why?)\r\n* `exception.innerException`\r\n\r\nAs the text now stands, empty objects (`{}`) are optional, but most empty arrays (`[]`) are forbidden. This doesn't make sense to me. Let's discuss.\r\n\r\nAlso:\r\n* Adjusted several places where we expressed the same thing using slightly different phrasing or punctuation in different places. In all such cases, I unified on the construct that was used most often.","created_at":"2016-07-29T21:21:24Z","updated_at":"2016-08-17T22:02:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a4dfd9f5ff02a85f4382e0535e946837d36c6a1","assignee":{"login":"michaelcfanning","id":13526455,"avatar_url":"https://avatars.githubusercontent.com/u/13526455?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelcfanning","html_url":"https://github.com/michaelcfanning","followers_url":"https://api.github.com/users/michaelcfanning/followers","following_url":"https://api.github.com/users/michaelcfanning/following{/other_user}","gists_url":"https://api.github.com/users/michaelcfanning/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelcfanning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelcfanning/subscriptions","organizations_url":"https://api.github.com/users/michaelcfanning/orgs","repos_url":"https://api.github.com/users/michaelcfanning/repos","events_url":"https://api.github.com/users/michaelcfanning/events{/privacy}","received_events_url":"https://api.github.com/users/michaelcfanning/received_events","type":"User","site_admin":false},"assignees":[{"login":"michaelcfanning","id":13526455,"avatar_url":"https://avatars.githubusercontent.com/u/13526455?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelcfanning","html_url":"https://github.com/michaelcfanning","followers_url":"https://api.github.com/users/michaelcfanning/followers","following_url":"https://api.github.com/users/michaelcfanning/following{/other_user}","gists_url":"https://api.github.com/users/michaelcfanning/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelcfanning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelcfanning/subscriptions","organizations_url":"https://api.github.com/users/michaelcfanning/orgs","repos_url":"https://api.github.com/users/michaelcfanning/repos","events_url":"https://api.github.com/users/michaelcfanning/events{/privacy}","received_events_url":"https://api.github.com/users/michaelcfanning/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sarif-standard/sarif-spec/pulls/256/commits","review_comments_url":"https://api.github.com/repos/sarif-standard/sarif-spec/pulls/256/comments","review_comment_url":"https://api.github.com/repos/sarif-standard/sarif-spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sarif-standard/sarif-spec/issues/256/comments","statuses_url":"https://api.github.com/repos/sarif-standard/sarif-spec/statuses/bf5ce1f3b7c4c390efa6f56624be488b2cc0726a","head":{"label":"lgolding:master","ref":"master","sha":"bf5ce1f3b7c4c390efa6f56624be488b2cc0726a","user":{"login":"lgolding","id":11762653,"avatar_url":"https://avatars.githubusercontent.com/u/11762653?v=3","gravatar_id":"","url":"https://api.github.com/users/lgolding","html_url":"https://github.com/lgolding","followers_url":"https://api.github.com/users/lgolding/followers","following_url":"https://api.github.com/users/lgolding/following{/other_user}","gists_url":"https://api.github.com/users/lgolding/gists{/gist_id}","starred_url":"https://api.github.com/users/lgolding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgolding/subscriptions","organizations_url":"https://api.github.com/users/lgolding/orgs","repos_url":"https://api.github.com/users/lgolding/repos","events_url":"https://api.github.com/users/lgolding/events{/privacy}","received_events_url":"https://api.github.com/users/lgolding/received_events","type":"User","site_admin":false},"repo":{"id":52565043,"name":"sarif-spec","full_name":"lgolding/sarif-spec","owner":{"login":"lgolding","id":11762653,"avatar_url":"https://avatars.githubusercontent.com/u/11762653?v=3","gravatar_id":"","url":"https://api.github.com/users/lgolding","html_url":"https://github.com/lgolding","followers_url":"https://api.github.com/users/lgolding/followers","following_url":"https://api.github.com/users/lgolding/following{/other_user}","gists_url":"https://api.github.com/users/lgolding/gists{/gist_id}","starred_url":"https://api.github.com/users/lgolding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgolding/subscriptions","organizations_url":"https://api.github.com/users/lgolding/orgs","repos_url":"https://api.github.com/users/lgolding/repos","events_url":"https://api.github.com/users/lgolding/events{/privacy}","received_events_url":"https://api.github.com/users/lgolding/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lgolding/sarif-spec","description":"The specification document for the Static Analysis Results Interchange Format (SARIF)","fork":true,"url":"https://api.github.com/repos/lgolding/sarif-spec","forks_url":"https://api.github.com/repos/lgolding/sarif-spec/forks","keys_url":"https://api.github.com/repos/lgolding/sarif-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lgolding/sarif-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lgolding/sarif-spec/teams","hooks_url":"https://api.github.com/repos/lgolding/sarif-spec/hooks","issue_events_url":"https://api.github.com/repos/lgolding/sarif-spec/issues/events{/number}","events_url":"https://api.github.com/repos/lgolding/sarif-spec/events","assignees_url":"https://api.github.com/repos/lgolding/sarif-spec/assignees{/user}","branches_url":"https://api.github.com/repos/lgolding/sarif-spec/branches{/branch}","tags_url":"https://api.github.com/repos/lgolding/sarif-spec/tags","blobs_url":"https://api.github.com/repos/lgolding/sarif-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lgolding/sarif-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lgolding/sarif-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/lgolding/sarif-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lgolding/sarif-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/lgolding/sarif-spec/languages","stargazers_url":"https://api.github.com/repos/lgolding/sarif-spec/stargazers","contributors_url":"https://api.github.com/repos/lgolding/sarif-spec/contributors","subscribers_url":"https://api.github.com/repos/lgolding/sarif-spec/subscribers","subscription_url":"https://api.github.com/repos/lgolding/sarif-spec/subscription","commits_url":"https://api.github.com/repos/lgolding/sarif-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/lgolding/sarif-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/lgolding/sarif-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/lgolding/sarif-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/lgolding/sarif-spec/contents/{+path}","compare_url":"https://api.github.com/repos/lgolding/sarif-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lgolding/sarif-spec/merges","archive_url":"https://api.github.com/repos/lgolding/sarif-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lgolding/sarif-spec/downloads","issues_url":"https://api.github.com/repos/lgolding/sarif-spec/issues{/number}","pulls_url":"https://api.github.com/repos/lgolding/sarif-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/lgolding/sarif-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/lgolding/sarif-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lgolding/sarif-spec/labels{/name}","releases_url":"https://api.github.com/repos/lgolding/sarif-spec/releases{/id}","deployments_url":"https://api.github.com/repos/lgolding/sarif-spec/deployments","created_at":"2016-02-25T23:44:18Z","updated_at":"2016-02-25T23:44:19Z","pushed_at":"2016-08-17T21:42:16Z","git_url":"git://github.com/lgolding/sarif-spec.git","ssh_url":"git@github.com:lgolding/sarif-spec.git","clone_url":"https://github.com/lgolding/sarif-spec.git","svn_url":"https://github.com/lgolding/sarif-spec","homepage":null,"size":3654,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sarif-standard:master","ref":"master","sha":"65c0bc06d10b73ba1c28c3ba788d89ce2c00b2f5","user":{"login":"sarif-standard","id":13755421,"avatar_url":"https://avatars.githubusercontent.com/u/13755421?v=3","gravatar_id":"","url":"https://api.github.com/users/sarif-standard","html_url":"https://github.com/sarif-standard","followers_url":"https://api.github.com/users/sarif-standard/followers","following_url":"https://api.github.com/users/sarif-standard/following{/other_user}","gists_url":"https://api.github.com/users/sarif-standard/gists{/gist_id}","starred_url":"https://api.github.com/users/sarif-standard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarif-standard/subscriptions","organizations_url":"https://api.github.com/users/sarif-standard/orgs","repos_url":"https://api.github.com/users/sarif-standard/repos","events_url":"https://api.github.com/users/sarif-standard/events{/privacy}","received_events_url":"https://api.github.com/users/sarif-standard/received_events","type":"Organization","site_admin":false},"repo":{"id":40567795,"name":"sarif-spec","full_name":"sarif-standard/sarif-spec","owner":{"login":"sarif-standard","id":13755421,"avatar_url":"https://avatars.githubusercontent.com/u/13755421?v=3","gravatar_id":"","url":"https://api.github.com/users/sarif-standard","html_url":"https://github.com/sarif-standard","followers_url":"https://api.github.com/users/sarif-standard/followers","following_url":"https://api.github.com/users/sarif-standard/following{/other_user}","gists_url":"https://api.github.com/users/sarif-standard/gists{/gist_id}","starred_url":"https://api.github.com/users/sarif-standard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarif-standard/subscriptions","organizations_url":"https://api.github.com/users/sarif-standard/orgs","repos_url":"https://api.github.com/users/sarif-standard/repos","events_url":"https://api.github.com/users/sarif-standard/events{/privacy}","received_events_url":"https://api.github.com/users/sarif-standard/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sarif-standard/sarif-spec","description":"The specification document for the Static Analysis Results Interchange Format (SARIF)","fork":false,"url":"https://api.github.com/repos/sarif-standard/sarif-spec","forks_url":"https://api.github.com/repos/sarif-standard/sarif-spec/forks","keys_url":"https://api.github.com/repos/sarif-standard/sarif-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sarif-standard/sarif-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sarif-standard/sarif-spec/teams","hooks_url":"https://api.github.com/repos/sarif-standard/sarif-spec/hooks","issue_events_url":"https://api.github.com/repos/sarif-standard/sarif-spec/issues/events{/number}","events_url":"https://api.github.com/repos/sarif-standard/sarif-spec/events","assignees_url":"https://api.github.com/repos/sarif-standard/sarif-spec/assignees{/user}","branches_url":"https://api.github.com/repos/sarif-standard/sarif-spec/branches{/branch}","tags_url":"https://api.github.com/repos/sarif-standard/sarif-spec/tags","blobs_url":"https://api.github.com/repos/sarif-standard/sarif-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sarif-standard/sarif-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sarif-standard/sarif-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/sarif-standard/sarif-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sarif-standard/sarif-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/sarif-standard/sarif-spec/languages","stargazers_url":"https://api.github.com/repos/sarif-standard/sarif-spec/stargazers","contributors_url":"https://api.github.com/repos/sarif-standard/sarif-spec/contributors","subscribers_url":"https://api.github.com/repos/sarif-standard/sarif-spec/subscribers","subscription_url":"https://api.github.com/repos/sarif-standard/sarif-spec/subscription","commits_url":"https://api.github.com/repos/sarif-standard/sarif-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/sarif-standard/sarif-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/sarif-standard/sarif-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/sarif-standard/sarif-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/sarif-standard/sarif-spec/contents/{+path}","compare_url":"https://api.github.com/repos/sarif-standard/sarif-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sarif-standard/sarif-spec/merges","archive_url":"https://api.github.com/repos/sarif-standard/sarif-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sarif-standard/sarif-spec/downloads","issues_url":"https://api.github.com/repos/sarif-standard/sarif-spec/issues{/number}","pulls_url":"https://api.github.com/repos/sarif-standard/sarif-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/sarif-standard/sarif-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/sarif-standard/sarif-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sarif-standard/sarif-spec/labels{/name}","releases_url":"https://api.github.com/repos/sarif-standard/sarif-spec/releases{/id}","deployments_url":"https://api.github.com/repos/sarif-standard/sarif-spec/deployments","created_at":"2015-08-11T22:14:51Z","updated_at":"2016-08-10T16:20:11Z","pushed_at":"2016-08-17T21:42:16Z","git_url":"git://github.com/sarif-standard/sarif-spec.git","ssh_url":"git@github.com:sarif-standard/sarif-spec.git","clone_url":"https://github.com/sarif-standard/sarif-spec.git","svn_url":"https://github.com/sarif-standard/sarif-spec","homepage":null,"size":3490,"stargazers_count":11,"watchers_count":11,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":25,"forks":5,"open_issues":25,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sarif-standard/sarif-spec/pulls/256"},"html":{"href":"https://github.com/sarif-standard/sarif-spec/pull/256"},"issue":{"href":"https://api.github.com/repos/sarif-standard/sarif-spec/issues/256"},"comments":{"href":"https://api.github.com/repos/sarif-standard/sarif-spec/issues/256/comments"},"review_comments":{"href":"https://api.github.com/repos/sarif-standard/sarif-spec/pulls/256/comments"},"review_comment":{"href":"https://api.github.com/repos/sarif-standard/sarif-spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sarif-standard/sarif-spec/pulls/256/commits"},"statuses":{"href":"https://api.github.com/repos/sarif-standard/sarif-spec/statuses/bf5ce1f3b7c4c390efa6f56624be488b2cc0726a"}}}}
{"actor":{"display_login":"lgolding"}}