{"action":"created","issue":{"url":"https://api.github.com/repos/PX4/Firmware/issues/5845","repository_url":"https://api.github.com/repos/PX4/Firmware","labels_url":"https://api.github.com/repos/PX4/Firmware/issues/5845/labels{/name}","comments_url":"https://api.github.com/repos/PX4/Firmware/issues/5845/comments","events_url":"https://api.github.com/repos/PX4/Firmware/issues/5845/events","html_url":"https://github.com/PX4/Firmware/pull/5845","id":188943838,"number":5845,"title":"add differential pressure logging and log all airspeed fields","user":{"login":"dagar","id":84712,"avatar_url":"https://avatars.githubusercontent.com/u/84712?v=3","gravatar_id":"","url":"https://api.github.com/users/dagar","html_url":"https://github.com/dagar","followers_url":"https://api.github.com/users/dagar/followers","following_url":"https://api.github.com/users/dagar/following{/other_user}","gists_url":"https://api.github.com/users/dagar/gists{/gist_id}","starred_url":"https://api.github.com/users/dagar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagar/subscriptions","organizations_url":"https://api.github.com/users/dagar/orgs","repos_url":"https://api.github.com/users/dagar/repos","events_url":"https://api.github.com/users/dagar/events{/privacy}","received_events_url":"https://api.github.com/users/dagar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-13T00:39:31Z","updated_at":"2016-11-13T21:03:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PX4/Firmware/pulls/5845","html_url":"https://github.com/PX4/Firmware/pull/5845","diff_url":"https://github.com/PX4/Firmware/pull/5845.diff","patch_url":"https://github.com/PX4/Firmware/pull/5845.patch"},"body":"I've been having trouble helping people recognize bad airspeed setups (interference with long i2c runs, etc).\r\n\r\nThis PR aborts airspeed calibration if the differential pressure error count is non zero, adds differential pressure to logger default topics, and full logging of airspeed + diff pres in sdlog2.\r\n\r\nAny other ideas? What about using the DataValidator in sensors to only publish airspeed (from diff pres) with high confidence or no error and also alert the user? https://github.com/PX4/Firmware/blob/master/src/modules/sensors/sensors.cpp#L1330"},"comment":{"url":"https://api.github.com/repos/PX4/Firmware/issues/comments/260212657","html_url":"https://github.com/PX4/Firmware/pull/5845#issuecomment-260212657","issue_url":"https://api.github.com/repos/PX4/Firmware/issues/5845","id":260212657,"user":{"login":"dagar","id":84712,"avatar_url":"https://avatars.githubusercontent.com/u/84712?v=3","gravatar_id":"","url":"https://api.github.com/users/dagar","html_url":"https://github.com/dagar","followers_url":"https://api.github.com/users/dagar/followers","following_url":"https://api.github.com/users/dagar/following{/other_user}","gists_url":"https://api.github.com/users/dagar/gists{/gist_id}","starred_url":"https://api.github.com/users/dagar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagar/subscriptions","organizations_url":"https://api.github.com/users/dagar/orgs","repos_url":"https://api.github.com/users/dagar/repos","events_url":"https://api.github.com/users/dagar/events{/privacy}","received_events_url":"https://api.github.com/users/dagar/received_events","type":"User","site_admin":false},"created_at":"2016-11-13T21:03:07Z","updated_at":"2016-11-13T21:03:07Z","body":"Got it. Do you have any firm guidelines? So far I've mainly come across a few extremes where it's obviously become a problem, and a few questionable situations, but we didn't have sufficient data.\r\n\r\n - limit i2c length\r\nhttps://groups.google.com/forum/#!topic/drones-discuss/C28lZeghcrk\r\n\r\n    If the length of the bus lines on a PCB or ribbon cable exceeds 10 cm and includes the \r\nVDD and VSS lines, the wiring pattern should be:\r\n\r\n    SDA _______________________\r\n    VDD ________________________\r\n    VSS ________________________\r\n    SCL _______________________\r\n\r\n\r\n - 3.3V vs 5V - is using the correct sensor strictly better, or does it only actually matter in certain situations? Most sellers don't advertise the version.\r\n\r\n - mounting location, outside of avionics bay close to external air temperature\r\n\r\n - calibration recommendations, before each flight for now as a precaution. Both for calibration at actual field temperature and to notify the user if the sensor reports any errors at all.\r\n\r\n - differential pressure sensor error_count checked during calibration and now logged\r\n - airspeed confidence value required for arming and now logged\r\n\r\n\r\n\r\nThis might be helpful for https://github.com/PX4/Firmware/issues/5595. Perhaps we should log the actual raw pressure value from the sensor without the offset and voltage correction."}}
{"actor":{"display_login":"dagar"}}