{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/72874619","id":72874619,"diff_hunk":"@@ -496,12 +496,12 @@ class _SwiftNativeNSSet {}\n class _SwiftNativeNSEnumerator {}\n \n @objc @_swift_native_objc_runtime_base(_SwiftNativeNSDataBase)\n-public class _SwiftNativeNSData {\n+open class _SwiftNativeNSData {\n   public init() {}\n }\n \n @objc @_swift_native_objc_runtime_base(_SwiftNativeNSCharacterSetBase)\n-public class _SwiftNativeNSCharacterSet {\n+open class _SwiftNativeNSCharacterSet {","path":"stdlib/public/core/Runtime.swift.gyb","position":11,"original_position":11,"commit_id":"005b014de66cbcdbe718d40bc6b8ff4959e8db2d","original_commit_id":"005b014de66cbcdbe718d40bc6b8ff4959e8db2d","user":{"login":"jrose-apple","id":15097531,"avatar_url":"https://avatars.githubusercontent.com/u/15097531?v=3","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"body":"@gribozavr, do these need to be `open`, or just public?","created_at":"2016-07-29T23:31:46Z","updated_at":"2016-07-29T23:31:46Z","html_url":"https://github.com/apple/swift/pull/3876#discussion_r72874619","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/3876","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/72874619"},"html":{"href":"https://github.com/apple/swift/pull/3876#discussion_r72874619"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/3876"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/3876","id":79438418,"html_url":"https://github.com/apple/swift/pull/3876","diff_url":"https://github.com/apple/swift/pull/3876.diff","patch_url":"https://github.com/apple/swift/pull/3876.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/3876","number":3876,"state":"open","locked":false,"title":"[REVIEW] [stdlib] Mark public classes as 'open'.","user":{"login":"jrose-apple","id":15097531,"avatar_url":"https://avatars.githubusercontent.com/u/15097531?v=3","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"body":"Depends on #3875 (or the full implementation of `open`). PR for review by the stdlib team.\r\n\r\n* * * *\r\n\r\n<!-- This selection should only be completed by Swift admin -->\r\nBefore merging this pull request to apple/swift repository:\r\n- [ ] Test pull request on Swift continuous integration.\r\n\r\n<details>\r\n  <summary>Triggering Swift CI</summary>\r\n\r\nThe swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:\r\n\r\n**Smoke Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please smoke test\r\n        All supported platforms     | @swift-ci Please smoke test and merge\r\n        OS X platform               | @swift-ci Please smoke test OS X platform\r\n        Linux platform              | @swift-ci Please smoke test Linux platform\r\n\r\nA smoke test on macOS does the following:\r\n\r\n1. Builds the compiler incrementally.\r\n2. Builds the standard library only for macOS. Simulator standard libraries and\r\n   device standard libraries are not built.\r\n3. lldb is not built.\r\n4. The test and validation-test targets are run only for macOS. The optimized\r\n   version of these tests are not run.\r\n\r\nA smoke test on Linux does the following:\r\n\r\n1. Builds the compiler incrementally.\r\n2. Builds the standard library incrementally.\r\n3. lldb is built incrementally.\r\n4. The swift test and validation-test targets are run. The optimized version of these\r\n   tests are not run.\r\n5. lldb is tested.\r\n\r\n**Validation Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please test\r\n        All supported platforms     | @swift-ci Please test and merge\r\n        OS X platform               | @swift-ci Please test OS X platform\r\n        OS X platform               | @swift-ci Please benchmark\r\n        Linux platform              | @swift-ci Please test Linux platform\r\n\r\n\r\n**Lint Testing**\r\n\r\n        Language     | Comment\r\n        ------------ | -------------\r\n        Python       | @swift-ci Please Python lint\r\n\r\nNote: Only members of the Apple organization can trigger swift-ci.\r\n</details>\r\n<!-- Thank you for your contribution to Swift! -->\r\n","created_at":"2016-07-29T23:31:13Z","updated_at":"2016-07-29T23:31:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30f460b3d8297975d0991413f2ab6439595e6632","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/3876/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/3876/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/3876/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/005b014de66cbcdbe718d40bc6b8ff4959e8db2d","head":{"label":"jrose-apple:open-stdlib","ref":"open-stdlib","sha":"005b014de66cbcdbe718d40bc6b8ff4959e8db2d","user":{"login":"jrose-apple","id":15097531,"avatar_url":"https://avatars.githubusercontent.com/u/15097531?v=3","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"repo":{"id":47434397,"name":"swift","full_name":"jrose-apple/swift","owner":{"login":"jrose-apple","id":15097531,"avatar_url":"https://avatars.githubusercontent.com/u/15097531?v=3","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrose-apple/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/jrose-apple/swift","forks_url":"https://api.github.com/repos/jrose-apple/swift/forks","keys_url":"https://api.github.com/repos/jrose-apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrose-apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrose-apple/swift/teams","hooks_url":"https://api.github.com/repos/jrose-apple/swift/hooks","issue_events_url":"https://api.github.com/repos/jrose-apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/jrose-apple/swift/events","assignees_url":"https://api.github.com/repos/jrose-apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/jrose-apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/jrose-apple/swift/tags","blobs_url":"https://api.github.com/repos/jrose-apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrose-apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrose-apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrose-apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrose-apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/jrose-apple/swift/languages","stargazers_url":"https://api.github.com/repos/jrose-apple/swift/stargazers","contributors_url":"https://api.github.com/repos/jrose-apple/swift/contributors","subscribers_url":"https://api.github.com/repos/jrose-apple/swift/subscribers","subscription_url":"https://api.github.com/repos/jrose-apple/swift/subscription","commits_url":"https://api.github.com/repos/jrose-apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrose-apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrose-apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrose-apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrose-apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/jrose-apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrose-apple/swift/merges","archive_url":"https://api.github.com/repos/jrose-apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrose-apple/swift/downloads","issues_url":"https://api.github.com/repos/jrose-apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/jrose-apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/jrose-apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/jrose-apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrose-apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/jrose-apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/jrose-apple/swift/deployments","created_at":"2015-12-04T23:42:49Z","updated_at":"2016-01-23T08:12:32Z","pushed_at":"2016-07-29T23:30:35Z","git_url":"git://github.com/jrose-apple/swift.git","ssh_url":"git@github.com:jrose-apple/swift.git","clone_url":"https://github.com/jrose-apple/swift.git","svn_url":"https://github.com/jrose-apple/swift","homepage":"","size":108316,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"empty"}},"base":{"label":"apple:master","ref":"master","sha":"71de3c95f06190ebd2627a5c92cfc2f3c3ba4fdb","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2016-07-29T22:14:04Z","pushed_at":"2016-07-29T23:31:14Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":166998,"stargazers_count":32682,"watchers_count":32682,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4553,"mirror_url":null,"open_issues_count":91,"forks":4553,"open_issues":91,"watchers":32682,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/3876"},"html":{"href":"https://github.com/apple/swift/pull/3876"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/3876"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/3876/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/3876/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/3876/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/005b014de66cbcdbe718d40bc6b8ff4959e8db2d"}}}}
{"actor":{"display_login":"jrose-apple"}}