{"action":"created","comment":{"url":"https://api.github.com/repos/hal/core/pulls/comments/86533776","pull_request_review_id":7188661,"id":86533776,"diff_hunk":"@@ -38,123 +51,127 @@\n     public static final String DATASOURCE = \"org.wildfly.data-source\";\n     public static final String SECURITY_DOMAIN = \"org.wildfly.security.security-domain\";\n     public static final String STATELESS_SESSION_BEAN_POOL = \"org.wildfly.ejb3.slsb-pool\";\n-    public static final String EJB_THREAD_POOL = \"org.wildfly.ejb3.thread-pool\";\n     public static final String EJB_CACHE = \"org.wildfly.ejb3.cache\";\n     public static final String EJB_PASSIVATION_STORE = \"org.wildfly.ejb3.passivation-store\";\n-    public static final String CACHE_CONTAINER = \"org.wildfly.infinispan.cache-container\";\n+    public static final String CACHE_CONTAINER = \"org.wildfly.clustering.infinispan.cache-container\";\n+    public static final String EJB_THREAD_POOL = \"org.wildfly.ejb3.thread-pool\";\n     public static final String REMOTING_HTTP_CONNECTOR = \"org.wildfly.remoting.http-connector\";\n     public static final String LOGGING_FORMATTER = \"org.wildfly.logging.formatter\";\n     public static final String JGROUPS_STACK = \"org.wildfly.jgroups.stack\";\n-    public static final String JGROUPS_CHANNEL = \"org.wildfly.jgroups.channel\";\n-    public static final String UNDERTOW_CONNECTOR = \"org.wildfly.undertow.connector\";\n+    public static final String JGROUPS_CHANNEL = \"org.wildfly.clustering.jgroups.channel\";\n+    public static final String UNDERTOW_LISTENER = \"org.wildfly.undertow.listener\";\n     public static final String UNDERTOW_SERVER = \"org.wildfly.undertow.server\";\n     public static final String UNDERTOW_HOST = \"org.wildfly.undertow.host\";\n     public static final String UNDERTOW_SERVLET_CONTAINER = \"org.wildfly.undertow.servlet-container\";\n     public static final String UNDERTOW_RESPONSE_FILTER = \"org.wildfly.undertow.filter\";\n \n-\n+    private DispatchAsync dispatcher;\n+    private HostStore hostStore;\n     private final Capabilities capabilities;\n \n     @Inject\n-    public CoreCapabilitiesRegister(Capabilities capabilities) {\n+    public CoreCapabilitiesRegister(DispatchAsync dispatcher, HostStore hostStore, Capabilities capabilities) {\n+        this.dispatcher = dispatcher;\n+        this.hostStore = hostStore;\n         this.capabilities = capabilities;\n     }\n \n     @Override\n-    //@SuppressWarnings({\"HardCodedStringLiteral\", \"DuplicateStringLiteralInspection\"})\n     public void execute(final Control<BootstrapContext> control) {\n \n-        // Selected capabilities from https://github.com/wildfly/wildfly-capabilities\n-        capabilities.register(DATASOURCE, true,\n-                AddressTemplate.of(\"/{selected.profile}/subsystem=datasources/data-source=*\"));\n-        \n-        capabilities.register(\"org.wildfly.io.buffer-pool\", true,\n-                AddressTemplate.of(\"/{selected.profile}/subsystem=io/buffer-pool=*\"));\n-        \n-        capabilities.register(\"org.wildfly.io.worker\", true,\n-                AddressTemplate.of(\"/{selected.profile}/subsystem=io/worker=*\"));\n-        \n-        // Lists local and remote outbound socket bindings of all socket binding groups\n-        capabilities.register(NETWORK_OUTBOUND_SOCKET_BINDING, true,\n-                AddressTemplate.of(\"/socket-binding-group=*/local-destination-outbound-socket-binding=*\"),\n-                AddressTemplate.of(\"/socket-binding-group=*/remote-destination-outbound-socket-binding=*\"));\n-\n-        // Lists all socket bindings of all socket binding groups\n-        capabilities.register(NETWORK_SOCKET_BINDING, true,\n-                AddressTemplate.of(\"/socket-binding-group=*/socket-binding=*\"));\n-\n-        // Well-known capabilities not (yet) on https://github.com/wildfly/wildfly-capabilities\n-        capabilities.register(\"org.wildfly.network.interface\", true, AddressTemplate.of(\"/interface=*\"));\n+        ResourceAddress address = new ResourceAddress().add(HOST, hostStore.getSelectedHost());","path":"gui/src/main/java/org/jboss/as/console/client/meta/CoreCapabilitiesRegister.java","position":90,"original_position":90,"commit_id":"da42bbd739f38364e866d9f2ba1e6f8a8d44f70e","original_commit_id":"da42bbd739f38364e866d9f2ba1e6f8a8d44f70e","user":{"login":"claudio4j","id":836543,"avatar_url":"https://avatars.githubusercontent.com/u/836543?v=3","gravatar_id":"","url":"https://api.github.com/users/claudio4j","html_url":"https://github.com/claudio4j","followers_url":"https://api.github.com/users/claudio4j/followers","following_url":"https://api.github.com/users/claudio4j/following{/other_user}","gists_url":"https://api.github.com/users/claudio4j/gists{/gist_id}","starred_url":"https://api.github.com/users/claudio4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claudio4j/subscriptions","organizations_url":"https://api.github.com/users/claudio4j/orgs","repos_url":"https://api.github.com/users/claudio4j/repos","events_url":"https://api.github.com/users/claudio4j/events{/privacy}","received_events_url":"https://api.github.com/users/claudio4j/received_events","type":"User","site_admin":false},"body":"Ops, forgot that. I went to fix, but saw you had already fixed. Thanks.","created_at":"2016-11-04T12:18:55Z","updated_at":"2016-11-04T12:18:55Z","html_url":"https://github.com/hal/core/pull/329#discussion_r86533776","pull_request_url":"https://api.github.com/repos/hal/core/pulls/329","_links":{"self":{"href":"https://api.github.com/repos/hal/core/pulls/comments/86533776"},"html":{"href":"https://github.com/hal/core/pull/329#discussion_r86533776"},"pull_request":{"href":"https://api.github.com/repos/hal/core/pulls/329"}}},"pull_request":{"url":"https://api.github.com/repos/hal/core/pulls/329","id":92156816,"html_url":"https://github.com/hal/core/pull/329","diff_url":"https://github.com/hal/core/pull/329.diff","patch_url":"https://github.com/hal/core/pull/329.patch","issue_url":"https://api.github.com/repos/hal/core/issues/329","number":329,"state":"closed","locked":false,"title":"HAL-1190 - Enhance CoreCapabilitiesRegister to load from /core-service=capability-registry","user":{"login":"claudio4j","id":836543,"avatar_url":"https://avatars.githubusercontent.com/u/836543?v=3","gravatar_id":"","url":"https://api.github.com/users/claudio4j","html_url":"https://github.com/claudio4j","followers_url":"https://api.github.com/users/claudio4j/followers","following_url":"https://api.github.com/users/claudio4j/following{/other_user}","gists_url":"https://api.github.com/users/claudio4j/gists{/gist_id}","starred_url":"https://api.github.com/users/claudio4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claudio4j/subscriptions","organizations_url":"https://api.github.com/users/claudio4j/orgs","repos_url":"https://api.github.com/users/claudio4j/repos","events_url":"https://api.github.com/users/claudio4j/events{/privacy}","received_events_url":"https://api.github.com/users/claudio4j/received_events","type":"User","site_admin":false},"body":"https://issues.jboss.org/browse/HAL-1190","created_at":"2016-11-03T13:50:16Z","updated_at":"2016-11-04T12:18:55Z","closed_at":"2016-11-03T16:36:12Z","merged_at":"2016-11-03T16:36:12Z","merge_commit_sha":"f479dfd1fca9a1e3476076b265f0846c53219ba8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hal/core/pulls/329/commits","review_comments_url":"https://api.github.com/repos/hal/core/pulls/329/comments","review_comment_url":"https://api.github.com/repos/hal/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hal/core/issues/329/comments","statuses_url":"https://api.github.com/repos/hal/core/statuses/da42bbd739f38364e866d9f2ba1e6f8a8d44f70e","head":{"label":"claudio4j:HAL-1190","ref":"HAL-1190","sha":"da42bbd739f38364e866d9f2ba1e6f8a8d44f70e","user":{"login":"claudio4j","id":836543,"avatar_url":"https://avatars.githubusercontent.com/u/836543?v=3","gravatar_id":"","url":"https://api.github.com/users/claudio4j","html_url":"https://github.com/claudio4j","followers_url":"https://api.github.com/users/claudio4j/followers","following_url":"https://api.github.com/users/claudio4j/following{/other_user}","gists_url":"https://api.github.com/users/claudio4j/gists{/gist_id}","starred_url":"https://api.github.com/users/claudio4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claudio4j/subscriptions","organizations_url":"https://api.github.com/users/claudio4j/orgs","repos_url":"https://api.github.com/users/claudio4j/repos","events_url":"https://api.github.com/users/claudio4j/events{/privacy}","received_events_url":"https://api.github.com/users/claudio4j/received_events","type":"User","site_admin":false},"repo":{"id":16496390,"name":"hal-core","full_name":"claudio4j/hal-core","owner":{"login":"claudio4j","id":836543,"avatar_url":"https://avatars.githubusercontent.com/u/836543?v=3","gravatar_id":"","url":"https://api.github.com/users/claudio4j","html_url":"https://github.com/claudio4j","followers_url":"https://api.github.com/users/claudio4j/followers","following_url":"https://api.github.com/users/claudio4j/following{/other_user}","gists_url":"https://api.github.com/users/claudio4j/gists{/gist_id}","starred_url":"https://api.github.com/users/claudio4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claudio4j/subscriptions","organizations_url":"https://api.github.com/users/claudio4j/orgs","repos_url":"https://api.github.com/users/claudio4j/repos","events_url":"https://api.github.com/users/claudio4j/events{/privacy}","received_events_url":"https://api.github.com/users/claudio4j/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/claudio4j/hal-core","description":"Core Console & SPI","fork":true,"url":"https://api.github.com/repos/claudio4j/hal-core","forks_url":"https://api.github.com/repos/claudio4j/hal-core/forks","keys_url":"https://api.github.com/repos/claudio4j/hal-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/claudio4j/hal-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/claudio4j/hal-core/teams","hooks_url":"https://api.github.com/repos/claudio4j/hal-core/hooks","issue_events_url":"https://api.github.com/repos/claudio4j/hal-core/issues/events{/number}","events_url":"https://api.github.com/repos/claudio4j/hal-core/events","assignees_url":"https://api.github.com/repos/claudio4j/hal-core/assignees{/user}","branches_url":"https://api.github.com/repos/claudio4j/hal-core/branches{/branch}","tags_url":"https://api.github.com/repos/claudio4j/hal-core/tags","blobs_url":"https://api.github.com/repos/claudio4j/hal-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/claudio4j/hal-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/claudio4j/hal-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/claudio4j/hal-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/claudio4j/hal-core/statuses/{sha}","languages_url":"https://api.github.com/repos/claudio4j/hal-core/languages","stargazers_url":"https://api.github.com/repos/claudio4j/hal-core/stargazers","contributors_url":"https://api.github.com/repos/claudio4j/hal-core/contributors","subscribers_url":"https://api.github.com/repos/claudio4j/hal-core/subscribers","subscription_url":"https://api.github.com/repos/claudio4j/hal-core/subscription","commits_url":"https://api.github.com/repos/claudio4j/hal-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/claudio4j/hal-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/claudio4j/hal-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/claudio4j/hal-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/claudio4j/hal-core/contents/{+path}","compare_url":"https://api.github.com/repos/claudio4j/hal-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/claudio4j/hal-core/merges","archive_url":"https://api.github.com/repos/claudio4j/hal-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/claudio4j/hal-core/downloads","issues_url":"https://api.github.com/repos/claudio4j/hal-core/issues{/number}","pulls_url":"https://api.github.com/repos/claudio4j/hal-core/pulls{/number}","milestones_url":"https://api.github.com/repos/claudio4j/hal-core/milestones{/number}","notifications_url":"https://api.github.com/repos/claudio4j/hal-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/claudio4j/hal-core/labels{/name}","releases_url":"https://api.github.com/repos/claudio4j/hal-core/releases{/id}","deployments_url":"https://api.github.com/repos/claudio4j/hal-core/deployments","created_at":"2014-02-03T23:16:43Z","updated_at":"2014-07-28T04:10:43Z","pushed_at":"2016-11-04T12:12:31Z","git_url":"git://github.com/claudio4j/hal-core.git","ssh_url":"git@github.com:claudio4j/hal-core.git","clone_url":"https://github.com/claudio4j/hal-core.git","svn_url":"https://github.com/claudio4j/hal-core","homepage":"","size":30641,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hal:master","ref":"master","sha":"1a6d4aaee7b953c870a632af4900e5e23bd435ec","user":{"login":"hal","id":4076071,"avatar_url":"https://avatars.githubusercontent.com/u/4076071?v=3","gravatar_id":"","url":"https://api.github.com/users/hal","html_url":"https://github.com/hal","followers_url":"https://api.github.com/users/hal/followers","following_url":"https://api.github.com/users/hal/following{/other_user}","gists_url":"https://api.github.com/users/hal/gists{/gist_id}","starred_url":"https://api.github.com/users/hal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hal/subscriptions","organizations_url":"https://api.github.com/users/hal/orgs","repos_url":"https://api.github.com/users/hal/repos","events_url":"https://api.github.com/users/hal/events{/privacy}","received_events_url":"https://api.github.com/users/hal/received_events","type":"Organization","site_admin":false},"repo":{"id":9318794,"name":"core","full_name":"hal/core","owner":{"login":"hal","id":4076071,"avatar_url":"https://avatars.githubusercontent.com/u/4076071?v=3","gravatar_id":"","url":"https://api.github.com/users/hal","html_url":"https://github.com/hal","followers_url":"https://api.github.com/users/hal/followers","following_url":"https://api.github.com/users/hal/following{/other_user}","gists_url":"https://api.github.com/users/hal/gists{/gist_id}","starred_url":"https://api.github.com/users/hal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hal/subscriptions","organizations_url":"https://api.github.com/users/hal/orgs","repos_url":"https://api.github.com/users/hal/repos","events_url":"https://api.github.com/users/hal/events{/privacy}","received_events_url":"https://api.github.com/users/hal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hal/core","description":"Core Console & SPI","fork":false,"url":"https://api.github.com/repos/hal/core","forks_url":"https://api.github.com/repos/hal/core/forks","keys_url":"https://api.github.com/repos/hal/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hal/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hal/core/teams","hooks_url":"https://api.github.com/repos/hal/core/hooks","issue_events_url":"https://api.github.com/repos/hal/core/issues/events{/number}","events_url":"https://api.github.com/repos/hal/core/events","assignees_url":"https://api.github.com/repos/hal/core/assignees{/user}","branches_url":"https://api.github.com/repos/hal/core/branches{/branch}","tags_url":"https://api.github.com/repos/hal/core/tags","blobs_url":"https://api.github.com/repos/hal/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hal/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hal/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/hal/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hal/core/statuses/{sha}","languages_url":"https://api.github.com/repos/hal/core/languages","stargazers_url":"https://api.github.com/repos/hal/core/stargazers","contributors_url":"https://api.github.com/repos/hal/core/contributors","subscribers_url":"https://api.github.com/repos/hal/core/subscribers","subscription_url":"https://api.github.com/repos/hal/core/subscription","commits_url":"https://api.github.com/repos/hal/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/hal/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/hal/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/hal/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/hal/core/contents/{+path}","compare_url":"https://api.github.com/repos/hal/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hal/core/merges","archive_url":"https://api.github.com/repos/hal/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hal/core/downloads","issues_url":"https://api.github.com/repos/hal/core/issues{/number}","pulls_url":"https://api.github.com/repos/hal/core/pulls{/number}","milestones_url":"https://api.github.com/repos/hal/core/milestones{/number}","notifications_url":"https://api.github.com/repos/hal/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hal/core/labels{/name}","releases_url":"https://api.github.com/repos/hal/core/releases{/id}","deployments_url":"https://api.github.com/repos/hal/core/deployments","created_at":"2013-04-09T10:36:00Z","updated_at":"2016-10-24T09:30:22Z","pushed_at":"2016-11-04T10:56:19Z","git_url":"git://github.com/hal/core.git","ssh_url":"git@github.com:hal/core.git","clone_url":"https://github.com/hal/core.git","svn_url":"https://github.com/hal/core","homepage":"","size":34690,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":19,"forks":53,"open_issues":19,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hal/core/pulls/329"},"html":{"href":"https://github.com/hal/core/pull/329"},"issue":{"href":"https://api.github.com/repos/hal/core/issues/329"},"comments":{"href":"https://api.github.com/repos/hal/core/issues/329/comments"},"review_comments":{"href":"https://api.github.com/repos/hal/core/pulls/329/comments"},"review_comment":{"href":"https://api.github.com/repos/hal/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hal/core/pulls/329/commits"},"statuses":{"href":"https://api.github.com/repos/hal/core/statuses/da42bbd739f38364e866d9f2ba1e6f8a8d44f70e"}}}}
{"actor":{"display_login":"claudio4j"}}