{"action":"created","comment":{"url":"https://api.github.com/repos/OSGP/Platform/pulls/comments/67862017","id":67862017,"diff_hunk":"@@ -456,4 +462,69 @@ public void handleReplaceKeysResponse(final DeviceMessageMetadata deviceMessageM\n                 result, exception, null, deviceMessageMetadata.getMessagePriority()), deviceMessageMetadata\n                 .getMessageType());\n     }\n+\n+    /**\n+     * Deligates the requests of the retrieval of the firmware version(s) from\n+     * the protocol adapter layer to the core layer\n+     *\n+     * @param deviceMessageMetadata\n+     *            contains the message meta data\n+     * @param getFirmwareVersion\n+     *            marker object to request the firmware version(s)\n+     * @throws FunctionalException\n+     *             is thrown when the device cannot be found in the database\n+     */\n+    public void requestFirmwareVersion(DeviceMessageMetadata deviceMessageMetadata,\n+            com.alliander.osgp.domain.core.valueobjects.smartmetering.GetFirmwareVersion getFirmwareVersion)\n+            throws FunctionalException {\n+\n+        LOGGER.info(\"requestFirmwareVersion for organisationIdentification: {} for deviceIdentification: {}\",\n+                deviceMessageMetadata.getOrganisationIdentification(), deviceMessageMetadata.getDeviceIdentification());\n+\n+        final SmartMeter smartMeteringDevice = this.domainHelperService.findSmartMeter(deviceMessageMetadata\n+                .getDeviceIdentification());\n+\n+        LOGGER.info(SENDING_REQUEST_MESSAGE_TO_CORE_LOG_MSG);\n+\n+        this.osgpCoreRequestMessageSender.send(new RequestMessage(deviceMessageMetadata.getCorrelationUid(),\n+                deviceMessageMetadata.getOrganisationIdentification(), deviceMessageMetadata.getDeviceIdentification(),\n+                smartMeteringDevice.getIpAddress(), new GetFirmwareVersionRequestDto()), deviceMessageMetadata\n+                .getMessageType(), deviceMessageMetadata.getMessagePriority(), deviceMessageMetadata.getScheduleTime());\n+    }\n+\n+    /**\n+     *\n+     * Maps the firmware Dto's to value objects and sends it back to the\n+     * ws-adapter layer\n+     *\n+     * @param deviceMessageMetadata\n+     *            contains the message meta data\n+     * @param result\n+     *            indicates whether the execution was succesfull\n+     * @param exception\n+     *            contains the exception if one was thrown\n+     * @param firmwareVersionList\n+     *            contains the firmware result list\n+     */\n+    public void handleGetFirmwareVersionResponse(DeviceMessageMetadata deviceMessageMetadata,\n+            ResponseMessageResultType result, OsgpException exception, List<FirmwareVersionDto> firmwareVersionList) {\n+\n+        LOGGER.info(\"handleGetFirmwareVersionResponse for MessageType: {}\", deviceMessageMetadata.getMessageType());\n+\n+        if (exception != null) {\n+            LOGGER.error(\"Replace Keys Response not ok. Unexpected Exception\", exception);\n+            result = ResponseMessageResultType.NOT_OK;","path":"osgp-adapter-domain-smartmetering/src/main/java/com/alliander/osgp/adapter/domain/smartmetering/application/services/ConfigurationService.java","position":85,"original_position":85,"commit_id":"ea37b60cac2b61800e85d1f8b1e1c5fef2571744","original_commit_id":"ea37b60cac2b61800e85d1f8b1e1c5fef2571744","user":{"login":"jenkins-ip-10-4-24-184","id":12208121,"avatar_url":"https://avatars.githubusercontent.com/u/12208121?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkins-ip-10-4-24-184","html_url":"https://github.com/jenkins-ip-10-4-24-184","followers_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/followers","following_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/following{/other_user}","gists_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/subscriptions","organizations_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/orgs","repos_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/repos","events_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/events{/privacy}","received_events_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/received_events","type":"User","site_admin":false},"body":"![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) Introduce a new variable instead of reusing the parameter \"result\". [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://54.77.62.182/sonarqube/coding_rules#rule_key=squid%3AS1226)\n","created_at":"2016-06-21T12:56:31Z","updated_at":"2016-06-21T12:56:31Z","html_url":"https://github.com/OSGP/Platform/pull/432#discussion_r67862017","pull_request_url":"https://api.github.com/repos/OSGP/Platform/pulls/432","_links":{"self":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/comments/67862017"},"html":{"href":"https://github.com/OSGP/Platform/pull/432#discussion_r67862017"},"pull_request":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/432"}}},"pull_request":{"url":"https://api.github.com/repos/OSGP/Platform/pulls/432","id":74605569,"html_url":"https://github.com/OSGP/Platform/pull/432","diff_url":"https://github.com/OSGP/Platform/pull/432.diff","patch_url":"https://github.com/OSGP/Platform/pull/432.patch","issue_url":"https://api.github.com/repos/OSGP/Platform/issues/432","number":432,"state":"open","locked":false,"title":"Commiting the support for getting firmware versions single request in","user":{"login":"hannek24","id":6457709,"avatar_url":"https://avatars.githubusercontent.com/u/6457709?v=3","gravatar_id":"","url":"https://api.github.com/users/hannek24","html_url":"https://github.com/hannek24","followers_url":"https://api.github.com/users/hannek24/followers","following_url":"https://api.github.com/users/hannek24/following{/other_user}","gists_url":"https://api.github.com/users/hannek24/gists{/gist_id}","starred_url":"https://api.github.com/users/hannek24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannek24/subscriptions","organizations_url":"https://api.github.com/users/hannek24/orgs","repos_url":"https://api.github.com/users/hannek24/repos","events_url":"https://api.github.com/users/hannek24/events{/privacy}","received_events_url":"https://api.github.com/users/hannek24/received_events","type":"User","site_admin":false},"body":"the ws-adapter-smartmeter","created_at":"2016-06-21T12:50:23Z","updated_at":"2016-06-21T12:56:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4011bc90910a9d0f7b994be18f409baa3f04dd35","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OSGP/Platform/pulls/432/commits","review_comments_url":"https://api.github.com/repos/OSGP/Platform/pulls/432/comments","review_comment_url":"https://api.github.com/repos/OSGP/Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OSGP/Platform/issues/432/comments","statuses_url":"https://api.github.com/repos/OSGP/Platform/statuses/ea37b60cac2b61800e85d1f8b1e1c5fef2571744","head":{"label":"OSGP:SLIM-598-GetFirmwareVersionsSingleRequest","ref":"SLIM-598-GetFirmwareVersionsSingleRequest","sha":"ea37b60cac2b61800e85d1f8b1e1c5fef2571744","user":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"repo":{"id":32739388,"name":"Platform","full_name":"OSGP/Platform","owner":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OSGP/Platform","description":"The main components of OSGP.","fork":false,"url":"https://api.github.com/repos/OSGP/Platform","forks_url":"https://api.github.com/repos/OSGP/Platform/forks","keys_url":"https://api.github.com/repos/OSGP/Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OSGP/Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OSGP/Platform/teams","hooks_url":"https://api.github.com/repos/OSGP/Platform/hooks","issue_events_url":"https://api.github.com/repos/OSGP/Platform/issues/events{/number}","events_url":"https://api.github.com/repos/OSGP/Platform/events","assignees_url":"https://api.github.com/repos/OSGP/Platform/assignees{/user}","branches_url":"https://api.github.com/repos/OSGP/Platform/branches{/branch}","tags_url":"https://api.github.com/repos/OSGP/Platform/tags","blobs_url":"https://api.github.com/repos/OSGP/Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OSGP/Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OSGP/Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/OSGP/Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OSGP/Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/OSGP/Platform/languages","stargazers_url":"https://api.github.com/repos/OSGP/Platform/stargazers","contributors_url":"https://api.github.com/repos/OSGP/Platform/contributors","subscribers_url":"https://api.github.com/repos/OSGP/Platform/subscribers","subscription_url":"https://api.github.com/repos/OSGP/Platform/subscription","commits_url":"https://api.github.com/repos/OSGP/Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/OSGP/Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/OSGP/Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/OSGP/Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/OSGP/Platform/contents/{+path}","compare_url":"https://api.github.com/repos/OSGP/Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OSGP/Platform/merges","archive_url":"https://api.github.com/repos/OSGP/Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OSGP/Platform/downloads","issues_url":"https://api.github.com/repos/OSGP/Platform/issues{/number}","pulls_url":"https://api.github.com/repos/OSGP/Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/OSGP/Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/OSGP/Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OSGP/Platform/labels{/name}","releases_url":"https://api.github.com/repos/OSGP/Platform/releases{/id}","deployments_url":"https://api.github.com/repos/OSGP/Platform/deployments","created_at":"2015-03-23T15:05:40Z","updated_at":"2016-06-14T13:44:45Z","pushed_at":"2016-06-21T12:50:23Z","git_url":"git://github.com/OSGP/Platform.git","ssh_url":"git@github.com:OSGP/Platform.git","clone_url":"https://github.com/OSGP/Platform.git","svn_url":"https://github.com/OSGP/Platform","homepage":"http://www.opensmartgridplatform.org/","size":27317,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":25,"forks":4,"open_issues":25,"watchers":9,"default_branch":"development"}},"base":{"label":"OSGP:development","ref":"development","sha":"3ea50810ba78cddb2620a5a32ac5dcca445814f8","user":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"repo":{"id":32739388,"name":"Platform","full_name":"OSGP/Platform","owner":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OSGP/Platform","description":"The main components of OSGP.","fork":false,"url":"https://api.github.com/repos/OSGP/Platform","forks_url":"https://api.github.com/repos/OSGP/Platform/forks","keys_url":"https://api.github.com/repos/OSGP/Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OSGP/Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OSGP/Platform/teams","hooks_url":"https://api.github.com/repos/OSGP/Platform/hooks","issue_events_url":"https://api.github.com/repos/OSGP/Platform/issues/events{/number}","events_url":"https://api.github.com/repos/OSGP/Platform/events","assignees_url":"https://api.github.com/repos/OSGP/Platform/assignees{/user}","branches_url":"https://api.github.com/repos/OSGP/Platform/branches{/branch}","tags_url":"https://api.github.com/repos/OSGP/Platform/tags","blobs_url":"https://api.github.com/repos/OSGP/Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OSGP/Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OSGP/Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/OSGP/Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OSGP/Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/OSGP/Platform/languages","stargazers_url":"https://api.github.com/repos/OSGP/Platform/stargazers","contributors_url":"https://api.github.com/repos/OSGP/Platform/contributors","subscribers_url":"https://api.github.com/repos/OSGP/Platform/subscribers","subscription_url":"https://api.github.com/repos/OSGP/Platform/subscription","commits_url":"https://api.github.com/repos/OSGP/Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/OSGP/Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/OSGP/Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/OSGP/Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/OSGP/Platform/contents/{+path}","compare_url":"https://api.github.com/repos/OSGP/Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OSGP/Platform/merges","archive_url":"https://api.github.com/repos/OSGP/Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OSGP/Platform/downloads","issues_url":"https://api.github.com/repos/OSGP/Platform/issues{/number}","pulls_url":"https://api.github.com/repos/OSGP/Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/OSGP/Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/OSGP/Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OSGP/Platform/labels{/name}","releases_url":"https://api.github.com/repos/OSGP/Platform/releases{/id}","deployments_url":"https://api.github.com/repos/OSGP/Platform/deployments","created_at":"2015-03-23T15:05:40Z","updated_at":"2016-06-14T13:44:45Z","pushed_at":"2016-06-21T12:50:23Z","git_url":"git://github.com/OSGP/Platform.git","ssh_url":"git@github.com:OSGP/Platform.git","clone_url":"https://github.com/OSGP/Platform.git","svn_url":"https://github.com/OSGP/Platform","homepage":"http://www.opensmartgridplatform.org/","size":27317,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":25,"forks":4,"open_issues":25,"watchers":9,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/432"},"html":{"href":"https://github.com/OSGP/Platform/pull/432"},"issue":{"href":"https://api.github.com/repos/OSGP/Platform/issues/432"},"comments":{"href":"https://api.github.com/repos/OSGP/Platform/issues/432/comments"},"review_comments":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/432/comments"},"review_comment":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/432/commits"},"statuses":{"href":"https://api.github.com/repos/OSGP/Platform/statuses/ea37b60cac2b61800e85d1f8b1e1c5fef2571744"}}}}
{"actor":{"display_login":"jenkins-ip-10-4-24-184"}}