{"action":"closed","number":145,"pull_request":{"url":"https://api.github.com/repos/pajato/GameChat/pulls/145","id":96490693,"html_url":"https://github.com/pajato/GameChat/pull/145","diff_url":"https://github.com/pajato/GameChat/pull/145.diff","patch_url":"https://github.com/pajato/GameChat/pull/145.patch","issue_url":"https://api.github.com/repos/pajato/GameChat/issues/145","number":145,"state":"closed","locked":false,"title":"Add a join room selection indication.","user":{"login":"pajatopmr","id":2983697,"avatar_url":"https://avatars.githubusercontent.com/u/2983697?v=3","gravatar_id":"","url":"https://api.github.com/users/pajatopmr","html_url":"https://github.com/pajatopmr","followers_url":"https://api.github.com/users/pajatopmr/followers","following_url":"https://api.github.com/users/pajatopmr/following{/other_user}","gists_url":"https://api.github.com/users/pajatopmr/gists{/gist_id}","starred_url":"https://api.github.com/users/pajatopmr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pajatopmr/subscriptions","organizations_url":"https://api.github.com/users/pajatopmr/orgs","repos_url":"https://api.github.com/users/pajatopmr/repos","events_url":"https://api.github.com/users/pajatopmr/events{/privacy}","received_events_url":"https://api.github.com/users/pajatopmr/received_events","type":"User","site_admin":false},"body":"<h1>Rationale:</h1>\r\n\r\nThis commit provides a check image to be shown when a room or member is selected for joining.  In so doing, some complexity added to support rooms and members has been simplified.\r\n\r\n<h1>File changes:</h1>\r\n\r\nmodified:   app/src/main/java/com/pajato/android/gamechat/chat/BaseChatFragment.java\r\n\r\n- onDispatch(): use the simplifed room item constructor.\r\n\r\nmodified:   app/src/main/java/com/pajato/android/gamechat/chat/adapter/ChatListAdapter.java\r\n\r\n- onCreateViewHolder(), onBindViewHolder(): replace the member item type cases with one each for selectable rooms and members.\r\n- setChatIcon(): use SELECTABLE_MEMBER_ITEM_TYPE.\r\n\r\nmodified:   app/src/main/java/com/pajato/android/gamechat/chat/adapter/ChatListItem.java\r\n\r\n- MEMBER_ITEM_TYPE: renamed to SELECTABLE_MEMBER_ITEM_TYPE.\r\n- SELECTABLE_ROOM_ITEM_TYPE: new constant.\r\n- desc: rename to mDesc and make private.\r\n- phone: hide while it is not being used (unhide it when needed).\r\n- ChatListItem(): reorganize the constructos per RNF; new constructor for a selectable room item.\r\n- toString(): provide debug support.\r\n\r\nmodified:   app/src/main/java/com/pajato/android/gamechat/chat/adapter/RoomItem.java\r\n\r\n- TextType: remove to simplify.\r\n- RoomItem(): simplify.\r\n\r\nrenamed:    app/src/main/java/com/pajato/android/gamechat/chat/adapter/MemberItem.java -> app/src/main/java/com/pajato/android/gamechat/chat/adapter/SelectableMemberItem.java\r\nnew file:   app/src/main/java/com/pajato/android/gamechat/chat/adapter/SelectableRoomItem.java\r\n\r\nmodified:   app/src/main/java/com/pajato/android/gamechat/chat/model/Room.java\r\n\r\n- expProfileList: move per RNF.\r\n\r\nmodified:   app/src/main/java/com/pajato/android/gamechat/database/DatabaseListManager.java\r\n\r\n- getList(): simplify the room case; lose the join member room case.\r\n- getAvailableMembers(): use SelectableMemberItem() instead of MemberItem().\r\n- getAvailableRooms(): use SelectableRoomItem() instead of RoomItem().\r\n- getMemberListData(): remove (stale).\r\n- getRoomListData(): simplify.\r\n\r\nnew file:   app/src/main/res/drawable/vd_check_white_24px.xml\r\n\r\nmodified:   app/src/main/res/layout/fragment_chat_join_rooms.xml\r\n\r\n- Summary: remove the room icon and add start margin to the edit box.\r\n\r\nmodified:   app/src/main/res/layout/item_group.xml\r\n\r\n- Summary: use explicit content description attributes as style provided ones bother Android Studio.\r\n\r\nrenamed:    app/src/main/res/layout/item_member.xml -> app/src/main/res/layout/item_join_member.xml\r\nnew file:   app/src/main/res/layout/item_join_room.xml\r\n\r\nmodified:   app/src/main/res/values/strings_chat.xml\r\n\r\n- SetRoomIconDesc: hide for now.\r\n\r\nmodified:   app/src/main/res/values/styles.xml\r\n\r\n- ChatListItemSelector, ChatListItemSelectorImage: new styles supporting selection.","created_at":"2016-12-05T09:02:20Z","updated_at":"2016-12-05T09:02:26Z","closed_at":"2016-12-05T09:02:26Z","merged_at":"2016-12-05T09:02:26Z","merge_commit_sha":"2b75b5108f697f96ac4e86d72696fdb792a3aa15","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pajato/GameChat/pulls/145/commits","review_comments_url":"https://api.github.com/repos/pajato/GameChat/pulls/145/comments","review_comment_url":"https://api.github.com/repos/pajato/GameChat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pajato/GameChat/issues/145/comments","statuses_url":"https://api.github.com/repos/pajato/GameChat/statuses/867c78f9a097d4bda22490e5a6c190ed5ef2323c","head":{"label":"pajato:join-selector","ref":"join-selector","sha":"867c78f9a097d4bda22490e5a6c190ed5ef2323c","user":{"login":"pajato","id":13346210,"avatar_url":"https://avatars.githubusercontent.com/u/13346210?v=3","gravatar_id":"","url":"https://api.github.com/users/pajato","html_url":"https://github.com/pajato","followers_url":"https://api.github.com/users/pajato/followers","following_url":"https://api.github.com/users/pajato/following{/other_user}","gists_url":"https://api.github.com/users/pajato/gists{/gist_id}","starred_url":"https://api.github.com/users/pajato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pajato/subscriptions","organizations_url":"https://api.github.com/users/pajato/orgs","repos_url":"https://api.github.com/users/pajato/repos","events_url":"https://api.github.com/users/pajato/events{/privacy}","received_events_url":"https://api.github.com/users/pajato/received_events","type":"Organization","site_admin":false},"repo":{"id":58804972,"name":"GameChat","full_name":"pajato/GameChat","owner":{"login":"pajato","id":13346210,"avatar_url":"https://avatars.githubusercontent.com/u/13346210?v=3","gravatar_id":"","url":"https://api.github.com/users/pajato","html_url":"https://github.com/pajato","followers_url":"https://api.github.com/users/pajato/followers","following_url":"https://api.github.com/users/pajato/following{/other_user}","gists_url":"https://api.github.com/users/pajato/gists{/gist_id}","starred_url":"https://api.github.com/users/pajato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pajato/subscriptions","organizations_url":"https://api.github.com/users/pajato/orgs","repos_url":"https://api.github.com/users/pajato/repos","events_url":"https://api.github.com/users/pajato/events{/privacy}","received_events_url":"https://api.github.com/users/pajato/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pajato/GameChat","description":"An Android app allowing gamers and gawkers to chat while playing and observing one or more games.","fork":false,"url":"https://api.github.com/repos/pajato/GameChat","forks_url":"https://api.github.com/repos/pajato/GameChat/forks","keys_url":"https://api.github.com/repos/pajato/GameChat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pajato/GameChat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pajato/GameChat/teams","hooks_url":"https://api.github.com/repos/pajato/GameChat/hooks","issue_events_url":"https://api.github.com/repos/pajato/GameChat/issues/events{/number}","events_url":"https://api.github.com/repos/pajato/GameChat/events","assignees_url":"https://api.github.com/repos/pajato/GameChat/assignees{/user}","branches_url":"https://api.github.com/repos/pajato/GameChat/branches{/branch}","tags_url":"https://api.github.com/repos/pajato/GameChat/tags","blobs_url":"https://api.github.com/repos/pajato/GameChat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pajato/GameChat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pajato/GameChat/git/refs{/sha}","trees_url":"https://api.github.com/repos/pajato/GameChat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pajato/GameChat/statuses/{sha}","languages_url":"https://api.github.com/repos/pajato/GameChat/languages","stargazers_url":"https://api.github.com/repos/pajato/GameChat/stargazers","contributors_url":"https://api.github.com/repos/pajato/GameChat/contributors","subscribers_url":"https://api.github.com/repos/pajato/GameChat/subscribers","subscription_url":"https://api.github.com/repos/pajato/GameChat/subscription","commits_url":"https://api.github.com/repos/pajato/GameChat/commits{/sha}","git_commits_url":"https://api.github.com/repos/pajato/GameChat/git/commits{/sha}","comments_url":"https://api.github.com/repos/pajato/GameChat/comments{/number}","issue_comment_url":"https://api.github.com/repos/pajato/GameChat/issues/comments{/number}","contents_url":"https://api.github.com/repos/pajato/GameChat/contents/{+path}","compare_url":"https://api.github.com/repos/pajato/GameChat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pajato/GameChat/merges","archive_url":"https://api.github.com/repos/pajato/GameChat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pajato/GameChat/downloads","issues_url":"https://api.github.com/repos/pajato/GameChat/issues{/number}","pulls_url":"https://api.github.com/repos/pajato/GameChat/pulls{/number}","milestones_url":"https://api.github.com/repos/pajato/GameChat/milestones{/number}","notifications_url":"https://api.github.com/repos/pajato/GameChat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pajato/GameChat/labels{/name}","releases_url":"https://api.github.com/repos/pajato/GameChat/releases{/id}","deployments_url":"https://api.github.com/repos/pajato/GameChat/deployments","created_at":"2016-05-14T11:42:49Z","updated_at":"2016-05-15T08:58:39Z","pushed_at":"2016-12-05T09:02:26Z","git_url":"git://github.com/pajato/GameChat.git","ssh_url":"git@github.com:pajato/GameChat.git","clone_url":"https://github.com/pajato/GameChat.git","svn_url":"https://github.com/pajato/GameChat","homepage":null,"size":3378,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"pajato:master","ref":"master","sha":"2be960482b7b737f00f0b1b97e68faaa6c1645cf","user":{"login":"pajato","id":13346210,"avatar_url":"https://avatars.githubusercontent.com/u/13346210?v=3","gravatar_id":"","url":"https://api.github.com/users/pajato","html_url":"https://github.com/pajato","followers_url":"https://api.github.com/users/pajato/followers","following_url":"https://api.github.com/users/pajato/following{/other_user}","gists_url":"https://api.github.com/users/pajato/gists{/gist_id}","starred_url":"https://api.github.com/users/pajato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pajato/subscriptions","organizations_url":"https://api.github.com/users/pajato/orgs","repos_url":"https://api.github.com/users/pajato/repos","events_url":"https://api.github.com/users/pajato/events{/privacy}","received_events_url":"https://api.github.com/users/pajato/received_events","type":"Organization","site_admin":false},"repo":{"id":58804972,"name":"GameChat","full_name":"pajato/GameChat","owner":{"login":"pajato","id":13346210,"avatar_url":"https://avatars.githubusercontent.com/u/13346210?v=3","gravatar_id":"","url":"https://api.github.com/users/pajato","html_url":"https://github.com/pajato","followers_url":"https://api.github.com/users/pajato/followers","following_url":"https://api.github.com/users/pajato/following{/other_user}","gists_url":"https://api.github.com/users/pajato/gists{/gist_id}","starred_url":"https://api.github.com/users/pajato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pajato/subscriptions","organizations_url":"https://api.github.com/users/pajato/orgs","repos_url":"https://api.github.com/users/pajato/repos","events_url":"https://api.github.com/users/pajato/events{/privacy}","received_events_url":"https://api.github.com/users/pajato/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pajato/GameChat","description":"An Android app allowing gamers and gawkers to chat while playing and observing one or more games.","fork":false,"url":"https://api.github.com/repos/pajato/GameChat","forks_url":"https://api.github.com/repos/pajato/GameChat/forks","keys_url":"https://api.github.com/repos/pajato/GameChat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pajato/GameChat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pajato/GameChat/teams","hooks_url":"https://api.github.com/repos/pajato/GameChat/hooks","issue_events_url":"https://api.github.com/repos/pajato/GameChat/issues/events{/number}","events_url":"https://api.github.com/repos/pajato/GameChat/events","assignees_url":"https://api.github.com/repos/pajato/GameChat/assignees{/user}","branches_url":"https://api.github.com/repos/pajato/GameChat/branches{/branch}","tags_url":"https://api.github.com/repos/pajato/GameChat/tags","blobs_url":"https://api.github.com/repos/pajato/GameChat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pajato/GameChat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pajato/GameChat/git/refs{/sha}","trees_url":"https://api.github.com/repos/pajato/GameChat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pajato/GameChat/statuses/{sha}","languages_url":"https://api.github.com/repos/pajato/GameChat/languages","stargazers_url":"https://api.github.com/repos/pajato/GameChat/stargazers","contributors_url":"https://api.github.com/repos/pajato/GameChat/contributors","subscribers_url":"https://api.github.com/repos/pajato/GameChat/subscribers","subscription_url":"https://api.github.com/repos/pajato/GameChat/subscription","commits_url":"https://api.github.com/repos/pajato/GameChat/commits{/sha}","git_commits_url":"https://api.github.com/repos/pajato/GameChat/git/commits{/sha}","comments_url":"https://api.github.com/repos/pajato/GameChat/comments{/number}","issue_comment_url":"https://api.github.com/repos/pajato/GameChat/issues/comments{/number}","contents_url":"https://api.github.com/repos/pajato/GameChat/contents/{+path}","compare_url":"https://api.github.com/repos/pajato/GameChat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pajato/GameChat/merges","archive_url":"https://api.github.com/repos/pajato/GameChat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pajato/GameChat/downloads","issues_url":"https://api.github.com/repos/pajato/GameChat/issues{/number}","pulls_url":"https://api.github.com/repos/pajato/GameChat/pulls{/number}","milestones_url":"https://api.github.com/repos/pajato/GameChat/milestones{/number}","notifications_url":"https://api.github.com/repos/pajato/GameChat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pajato/GameChat/labels{/name}","releases_url":"https://api.github.com/repos/pajato/GameChat/releases{/id}","deployments_url":"https://api.github.com/repos/pajato/GameChat/deployments","created_at":"2016-05-14T11:42:49Z","updated_at":"2016-05-15T08:58:39Z","pushed_at":"2016-12-05T09:02:26Z","git_url":"git://github.com/pajato/GameChat.git","ssh_url":"git@github.com:pajato/GameChat.git","clone_url":"https://github.com/pajato/GameChat.git","svn_url":"https://github.com/pajato/GameChat","homepage":null,"size":3378,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pajato/GameChat/pulls/145"},"html":{"href":"https://github.com/pajato/GameChat/pull/145"},"issue":{"href":"https://api.github.com/repos/pajato/GameChat/issues/145"},"comments":{"href":"https://api.github.com/repos/pajato/GameChat/issues/145/comments"},"review_comments":{"href":"https://api.github.com/repos/pajato/GameChat/pulls/145/comments"},"review_comment":{"href":"https://api.github.com/repos/pajato/GameChat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pajato/GameChat/pulls/145/commits"},"statuses":{"href":"https://api.github.com/repos/pajato/GameChat/statuses/867c78f9a097d4bda22490e5a6c190ed5ef2323c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pajatopmr","id":2983697,"avatar_url":"https://avatars.githubusercontent.com/u/2983697?v=3","gravatar_id":"","url":"https://api.github.com/users/pajatopmr","html_url":"https://github.com/pajatopmr","followers_url":"https://api.github.com/users/pajatopmr/followers","following_url":"https://api.github.com/users/pajatopmr/following{/other_user}","gists_url":"https://api.github.com/users/pajatopmr/gists{/gist_id}","starred_url":"https://api.github.com/users/pajatopmr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pajatopmr/subscriptions","organizations_url":"https://api.github.com/users/pajatopmr/orgs","repos_url":"https://api.github.com/users/pajatopmr/repos","events_url":"https://api.github.com/users/pajatopmr/events{/privacy}","received_events_url":"https://api.github.com/users/pajatopmr/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":203,"deletions":104,"changed_files":16}}
{"actor":{"display_login":"pajatopmr"}}