{"action":"created","issue":{"url":"https://api.github.com/repos/fastlane/fastlane/issues/3771","repository_url":"https://api.github.com/repos/fastlane/fastlane","labels_url":"https://api.github.com/repos/fastlane/fastlane/issues/3771/labels{/name}","comments_url":"https://api.github.com/repos/fastlane/fastlane/issues/3771/comments","events_url":"https://api.github.com/repos/fastlane/fastlane/issues/3771/events","html_url":"https://github.com/fastlane/fastlane/issues/3771","id":141153466,"number":3771,"title":"submit_for_beta_review! submits the placeholder information if none is specified [spaceship]","user":{"login":"revile","id":1697654,"avatar_url":"https://avatars.githubusercontent.com/u/1697654?v=3","gravatar_id":"","url":"https://api.github.com/users/revile","html_url":"https://github.com/revile","followers_url":"https://api.github.com/users/revile/followers","following_url":"https://api.github.com/users/revile/following{/other_user}","gists_url":"https://api.github.com/users/revile/gists{/gist_id}","starred_url":"https://api.github.com/users/revile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/revile/subscriptions","organizations_url":"https://api.github.com/users/revile/orgs","repos_url":"https://api.github.com/users/revile/repos","events_url":"https://api.github.com/users/revile/events{/privacy}","received_events_url":"https://api.github.com/users/revile/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/fastlane/fastlane/labels/spaceship","name":"spaceship","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-16T02:23:54Z","updated_at":"2016-03-22T04:57:39Z","closed_at":null,"body":"### New Issue Checklist\r\n\r\n- [x] Updated fastlane to the latest version\r\n- [x] I have read the [Contribution Guidelines](https://github.com/fastlane/fastlane/blob/master/CONTRIBUTING.md)\r\n\r\n### Issue Description\r\n\r\n`Build::submit_for_beta_review!` in spaceship submits the placeholder information if none is specified.\r\n\r\n```ruby\r\ndef submit_for_beta_review!(metadata)\r\n        parameters = {\r\n          app_id: self.apple_id,\r\n          train: self.train_version,\r\n          build_number: self.build_version,\r\n          platform: self.platform,\r\n\r\n          # Required Metadata:\r\n          changelog: \"No changelog provided\",\r\n          description: \"No app description provided\",\r\n          feedback_email: \"contact@company.com\",\r\n          marketing_url: \"http://marketing.com\",\r\n          first_name: \"Felix\",\r\n          last_name: \"Krause\",\r\n          review_email: \"contact@company.com\",\r\n          phone_number: \"0123456789\",\r\n          significant_change: false,\r\n\r\n          # Optional Metadata:\r\n          privacy_policy_url: nil,\r\n          review_user_name: nil,\r\n          review_password: nil,\r\n          encryption: false\r\n        }.merge(metadata)\r\n\r\n        client.submit_testflight_build_for_review!(parameters)\r\n\r\n        # Last, enable beta testing for this train (per iTC requirement). This will fail until the app has been approved for beta testing\r\n        self.build_train.update_testing_status!(true, 'external', self)\r\n\r\n        return parameters\r\n      end\r\n```\r\n\r\nThese fields don't _seem_ to be required. My understanding is this data is mostly pulled through from the store submission and pre-filled for you. I commented most of these out (except the top 4, obviously) and started getting an error: `Review Notes are required`\r\n\r\nI added the option to specify review notes (with a placeholder) and now everything seems to work fine. \r\n\r\nI am confused by the comment and code at the bottom of this function though, can someone explain why we attempt to submit the build for external testing when we just submitted it for review? Won't this always fail? Is this some kind of special handling for when we specify no significant changes and the build is immediately available?\r\n\r\n### Environment\r\n\r\nspaceship 0.23.0\r\n"},"comment":{"url":"https://api.github.com/repos/fastlane/fastlane/issues/comments/199638741","html_url":"https://github.com/fastlane/fastlane/issues/3771#issuecomment-199638741","issue_url":"https://api.github.com/repos/fastlane/fastlane/issues/3771","id":199638741,"user":{"login":"revile","id":1697654,"avatar_url":"https://avatars.githubusercontent.com/u/1697654?v=3","gravatar_id":"","url":"https://api.github.com/users/revile","html_url":"https://github.com/revile","followers_url":"https://api.github.com/users/revile/followers","following_url":"https://api.github.com/users/revile/following{/other_user}","gists_url":"https://api.github.com/users/revile/gists{/gist_id}","starred_url":"https://api.github.com/users/revile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/revile/subscriptions","organizations_url":"https://api.github.com/users/revile/orgs","repos_url":"https://api.github.com/users/revile/repos","events_url":"https://api.github.com/users/revile/events{/privacy}","received_events_url":"https://api.github.com/users/revile/received_events","type":"User","site_admin":false},"created_at":"2016-03-22T04:57:39Z","updated_at":"2016-03-22T04:57:39Z","body":"FYI this is fixed in #3789, which AFAIK is ready for merge."}}