{"action":"created","issue":{"url":"https://api.github.com/repos/espruino/EspruinoDocs/issues/268","repository_url":"https://api.github.com/repos/espruino/EspruinoDocs","labels_url":"https://api.github.com/repos/espruino/EspruinoDocs/issues/268/labels{/name}","comments_url":"https://api.github.com/repos/espruino/EspruinoDocs/issues/268/comments","events_url":"https://api.github.com/repos/espruino/EspruinoDocs/issues/268/events","html_url":"https://github.com/espruino/EspruinoDocs/issues/268","id":172388381,"number":268,"title":"Websocket client needs masking","user":{"login":"gfwilliams","id":754445,"avatar_url":"https://avatars.githubusercontent.com/u/754445?v=3","gravatar_id":"","url":"https://api.github.com/users/gfwilliams","html_url":"https://github.com/gfwilliams","followers_url":"https://api.github.com/users/gfwilliams/followers","following_url":"https://api.github.com/users/gfwilliams/following{/other_user}","gists_url":"https://api.github.com/users/gfwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/gfwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfwilliams/subscriptions","organizations_url":"https://api.github.com/users/gfwilliams/orgs","repos_url":"https://api.github.com/users/gfwilliams/repos","events_url":"https://api.github.com/users/gfwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/gfwilliams/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-22T07:48:34Z","updated_at":"2016-08-24T09:18:12Z","closed_at":"2016-08-22T16:20:03Z","body":"`ws` on node.hs is fine with it, but vertx.io drops connections if it's not there:\r\n\r\nhttp://forum.espruino.com/conversations/291544/#comment13167995\r\n\r\nThe code that needs changing is in `send`, in: https://github.com/espruino/EspruinoDocs/blob/master/modules/ws.js#L175\r\n\r\nThere is already some unmasking code, so you're basically just doing the same thing again: https://github.com/espruino/EspruinoDocs/blob/master/modules/ws.js#L154"},"comment":{"url":"https://api.github.com/repos/espruino/EspruinoDocs/issues/comments/242004565","html_url":"https://github.com/espruino/EspruinoDocs/issues/268#issuecomment-242004565","issue_url":"https://api.github.com/repos/espruino/EspruinoDocs/issues/268","id":242004565,"user":{"login":"injecteer","id":32952,"avatar_url":"https://avatars.githubusercontent.com/u/32952?v=3","gravatar_id":"","url":"https://api.github.com/users/injecteer","html_url":"https://github.com/injecteer","followers_url":"https://api.github.com/users/injecteer/followers","following_url":"https://api.github.com/users/injecteer/following{/other_user}","gists_url":"https://api.github.com/users/injecteer/gists{/gist_id}","starred_url":"https://api.github.com/users/injecteer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/injecteer/subscriptions","organizations_url":"https://api.github.com/users/injecteer/orgs","repos_url":"https://api.github.com/users/injecteer/repos","events_url":"https://api.github.com/users/injecteer/events{/privacy}","received_events_url":"https://api.github.com/users/injecteer/received_events","type":"User","site_admin":false},"created_at":"2016-08-24T09:18:12Z","updated_at":"2016-08-24T09:18:12Z","body":"I tested that for sending and receiving, and it's working like charm. Thanks!"}}
{"actor":{"display_login":"injecteer"}}