{"action":"created","comment":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments/75685078","id":75685078,"diff_hunk":"@@ -0,0 +1,41 @@\n+package net.minecraftforge.common.smelting;\n+\n+import static com.google.common.base.Preconditions.checkArgument;\n+import net.minecraft.item.ItemStack;\n+\n+/**\n+ * Base class for {@code SmeltingRecipe} implementations.\n+ */\n+public abstract class AbstractSmeltingRecipe implements SmeltingRecipe\n+{\n+\n+    protected final int duration;\n+\n+    protected AbstractSmeltingRecipe(int duration)\n+    {\n+        checkArgument(duration > 0);\n+        this.duration = duration;\n+    }\n+\n+    @Override\n+    public final ItemStack getOutput(ItemStack input)\n+    {\n+        return matches(input) ? ItemStack.copyItemStack(getOutput0(input)) : null;\n+    }\n+\n+    /**\n+     * Get the raw output for this recipe based on the given input. The resulting stack should not be\n+     * a defensive copy. This method is only called, if {@code matches} returns true.\n+     *\n+     * @param input the input stack\n+     * @return the raw output stack\n+     */\n+    protected abstract ItemStack getOutput0(ItemStack input);","path":"src/main/java/net/minecraftforge/common/smelting/AbstractSmeltingRecipe.java","position":33,"original_position":33,"commit_id":"ef064db641b38587a4513e7f67f8d750afaea797","original_commit_id":"ef064db641b38587a4513e7f67f8d750afaea797","user":{"login":"jk-5","id":1783250,"avatar_url":"https://avatars.githubusercontent.com/u/1783250?v=3","gravatar_id":"","url":"https://api.github.com/users/jk-5","html_url":"https://github.com/jk-5","followers_url":"https://api.github.com/users/jk-5/followers","following_url":"https://api.github.com/users/jk-5/following{/other_user}","gists_url":"https://api.github.com/users/jk-5/gists{/gist_id}","starred_url":"https://api.github.com/users/jk-5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jk-5/subscriptions","organizations_url":"https://api.github.com/users/jk-5/orgs","repos_url":"https://api.github.com/users/jk-5/repos","events_url":"https://api.github.com/users/jk-5/events{/privacy}","received_events_url":"https://api.github.com/users/jk-5/received_events","type":"User","site_admin":false},"body":"Maybe a name like 'getRawOutput' would fit better here. Generally i dislike method names with numbers suffixed in public api. Adding to that, i can't really come up with a case where the recipe input does not match, but still wants to generate output. Maybe drop this method and make the normal 'getOutput' method do that?","created_at":"2016-08-22T14:15:32Z","updated_at":"2016-08-22T14:15:32Z","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3141#discussion_r75685078","pull_request_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3141","_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments/75685078"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/3141#discussion_r75685078"},"pull_request":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3141"}}},"pull_request":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3141","id":79498973,"html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3141","diff_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3141.diff","patch_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3141.patch","issue_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3141","number":3141,"state":"open","locked":false,"title":"Add Smelting Recipes","user":{"login":"diesieben07","id":1915984,"avatar_url":"https://avatars.githubusercontent.com/u/1915984?v=3","gravatar_id":"","url":"https://api.github.com/users/diesieben07","html_url":"https://github.com/diesieben07","followers_url":"https://api.github.com/users/diesieben07/followers","following_url":"https://api.github.com/users/diesieben07/following{/other_user}","gists_url":"https://api.github.com/users/diesieben07/gists{/gist_id}","starred_url":"https://api.github.com/users/diesieben07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diesieben07/subscriptions","organizations_url":"https://api.github.com/users/diesieben07/orgs","repos_url":"https://api.github.com/users/diesieben07/repos","events_url":"https://api.github.com/users/diesieben07/events{/privacy}","received_events_url":"https://api.github.com/users/diesieben07/received_events","type":"User","site_admin":false},"body":"Allows items to specify how long they take to cook in a furnace.","created_at":"2016-07-31T23:08:10Z","updated_at":"2016-08-22T14:15:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de0330f5f444d1e04c1be2dbe6e018e45d373dc3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3141/commits","review_comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3141/comments","review_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3141/comments","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/ef064db641b38587a4513e7f67f8d750afaea797","head":{"label":"diesieben07:cook-time","ref":"cook-time","sha":"ef064db641b38587a4513e7f67f8d750afaea797","user":{"login":"diesieben07","id":1915984,"avatar_url":"https://avatars.githubusercontent.com/u/1915984?v=3","gravatar_id":"","url":"https://api.github.com/users/diesieben07","html_url":"https://github.com/diesieben07","followers_url":"https://api.github.com/users/diesieben07/followers","following_url":"https://api.github.com/users/diesieben07/following{/other_user}","gists_url":"https://api.github.com/users/diesieben07/gists{/gist_id}","starred_url":"https://api.github.com/users/diesieben07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diesieben07/subscriptions","organizations_url":"https://api.github.com/users/diesieben07/orgs","repos_url":"https://api.github.com/users/diesieben07/repos","events_url":"https://api.github.com/users/diesieben07/events{/privacy}","received_events_url":"https://api.github.com/users/diesieben07/received_events","type":"User","site_admin":false},"repo":{"id":37376802,"name":"MinecraftForge","full_name":"diesieben07/MinecraftForge","owner":{"login":"diesieben07","id":1915984,"avatar_url":"https://avatars.githubusercontent.com/u/1915984?v=3","gravatar_id":"","url":"https://api.github.com/users/diesieben07","html_url":"https://github.com/diesieben07","followers_url":"https://api.github.com/users/diesieben07/followers","following_url":"https://api.github.com/users/diesieben07/following{/other_user}","gists_url":"https://api.github.com/users/diesieben07/gists{/gist_id}","starred_url":"https://api.github.com/users/diesieben07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diesieben07/subscriptions","organizations_url":"https://api.github.com/users/diesieben07/orgs","repos_url":"https://api.github.com/users/diesieben07/repos","events_url":"https://api.github.com/users/diesieben07/events{/privacy}","received_events_url":"https://api.github.com/users/diesieben07/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/diesieben07/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":true,"url":"https://api.github.com/repos/diesieben07/MinecraftForge","forks_url":"https://api.github.com/repos/diesieben07/MinecraftForge/forks","keys_url":"https://api.github.com/repos/diesieben07/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diesieben07/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diesieben07/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/diesieben07/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/diesieben07/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/diesieben07/MinecraftForge/events","assignees_url":"https://api.github.com/repos/diesieben07/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/diesieben07/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/diesieben07/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/diesieben07/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diesieben07/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diesieben07/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/diesieben07/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diesieben07/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/diesieben07/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/diesieben07/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/diesieben07/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/diesieben07/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/diesieben07/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/diesieben07/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/diesieben07/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/diesieben07/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/diesieben07/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/diesieben07/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/diesieben07/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diesieben07/MinecraftForge/merges","archive_url":"https://api.github.com/repos/diesieben07/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diesieben07/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/diesieben07/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/diesieben07/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/diesieben07/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/diesieben07/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diesieben07/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/diesieben07/MinecraftForge/releases{/id}","deployments_url":"https://api.github.com/repos/diesieben07/MinecraftForge/deployments","created_at":"2015-06-13T15:34:04Z","updated_at":"2016-01-28T19:05:53Z","pushed_at":"2016-08-13T15:20:57Z","git_url":"git://github.com/diesieben07/MinecraftForge.git","ssh_url":"git@github.com:diesieben07/MinecraftForge.git","clone_url":"https://github.com/diesieben07/MinecraftForge.git","svn_url":"https://github.com/diesieben07/MinecraftForge","homepage":"","size":87988,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MinecraftForge:1.10.x","ref":"1.10.x","sha":"8195c36434f1930ca0917ae3ad701fab9549a86b","user":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars.githubusercontent.com/u/1390178?v=3","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"repo":{"id":3301400,"name":"MinecraftForge","full_name":"MinecraftForge/MinecraftForge","owner":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars.githubusercontent.com/u/1390178?v=3","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MinecraftForge/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":false,"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge","forks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/forks","keys_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/events","assignees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/merges","archive_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/releases{/id}","deployments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/deployments","created_at":"2012-01-30T01:35:01Z","updated_at":"2016-08-22T01:22:16Z","pushed_at":"2016-08-21T23:03:51Z","git_url":"git://github.com/MinecraftForge/MinecraftForge.git","ssh_url":"git@github.com:MinecraftForge/MinecraftForge.git","clone_url":"https://github.com/MinecraftForge/MinecraftForge.git","svn_url":"https://github.com/MinecraftForge/MinecraftForge","homepage":"","size":153215,"stargazers_count":1503,"watchers_count":1503,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":819,"mirror_url":null,"open_issues_count":205,"forks":819,"open_issues":205,"watchers":1503,"default_branch":"1.10.x"}},"_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3141"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/3141"},"issue":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3141"},"comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3141/comments"},"review_comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3141/comments"},"review_comment":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3141/commits"},"statuses":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/ef064db641b38587a4513e7f67f8d750afaea797"}}}}
{"actor":{"display_login":"jk-5"}}